gdb/ChangeLog

   1 2019-07-09  Pedro Alves  <palves@redhat.com>
   2
   3         * break-catch-throw.c (is_exception_catchpoint): New.
   4         * breakpoint.c (print_one_breakpoint_location): New parameter
   5         'raw_loc'.  Handle it.  Use
   6         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
   7         looking at the breakpoint's type.
   8         (print_one_breakpoint): If handling "maint info breakpoints", also
   9         print locations of exception catchpoints.
  10         * breakpoint.h (is_exception_catchpoint): Declare.
  11
  12 2019-07-09  Pedro Alves  <palves@redhat.com>
  13
  14         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
  15         "addr" field.
  16         (allocate_location_exception_catchpoint): New.
  17         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
  18         (initialize_throw_catchpoint_ops): Install
  19         allocate_location_exception_catchpoint as allocate_location
  20         method.
  21         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
  22         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
  23         bp_loc_other.
  24         (breakpoint_address_is_meaningful): Delete.
  25         (bl_address_is_meaningful): New.
  26         (breakpoint_locations_match): Adjust comment.
  27         (bp_location_from_bp_type): New, factored out of...
  28         (bp_location::bp_location(breakpoint *)): ... this.
  29         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
  30         factored out of...
  31         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
  32         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
  33         breakpoint_address_is_meaningful.
  34         (bp_locations_compare): Adjust comment.
  35         (update_global_location_list): Use bl_address_is_meaningful
  36         instead of breakpoint_address_is_meaningful.
  37         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
  38         explicit.
  39         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
  40         * python/py-breakpoint.c (bppy_get_location): No longer check
  41         whether location is null.
  42
  43 2019-07-09  Pedro Alves  <palves@redhat.com>
  44
  45         PR c++/15468
  46         * breakpoint.c (print_one_breakpoint_location): Remove
  47         single-location assert.
  48
  49 2019-07-09  Tom Tromey  <tom@tromey.com>
  50
  51         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
  52         * configure: Rebuild.
  53         * configure.ac: Change common to gdbsupport.
  54         * gdbsupport: Rename from common.
  55         * acinclude.m4: Change common to gdbsupport.
  56         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
  57         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
  58         gdbsupport.
  59         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
  60         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
  61         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
  62         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
  63         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
  64         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
  65         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
  66         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
  67         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
  68         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
  69         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
  70         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
  71         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
  72         coff-pe-read.c, command.h, compile/compile-c-support.c,
  73         compile/compile-c.h, compile/compile-cplus-symbols.c,
  74         compile/compile-cplus-types.c, compile/compile-cplus.h,
  75         compile/compile-loc2c.c, compile/compile.c, completer.c,
  76         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
  77         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
  78         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
  79         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
  80         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
  81         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
  82         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
  83         features/aarch64-core.c, features/aarch64-fpu.c,
  84         features/aarch64-pauth.c, features/aarch64-sve.c,
  85         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
  86         features/i386/32bit-core.c, features/i386/32bit-linux.c,
  87         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
  88         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
  89         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
  90         features/i386/64bit-core.c, features/i386/64bit-linux.c,
  91         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
  92         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
  93         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
  94         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
  95         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
  96         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
  97         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
  98         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
  99         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 100         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 101         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 102         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 103         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 104         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 105         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 106         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 107         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 108         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 109         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 110         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 111         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 112         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 113         minsyms.c, mips-linux-tdep.c, namespace.h,
 114         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 115         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 116         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 117         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 118         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 119         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 120         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 121         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 122         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 123         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 124         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 125         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 126         procfs.c, producer.c, progspace.h, psymtab.h,
 127         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 128         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 129         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 130         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 131         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
 132         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
 133         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
 134         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
 135         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
 136         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
 137         target-memory.c, target.c, target.h, target/waitstatus.c,
 138         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
 139         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
 140         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
 141         unittests/array-view-selftests.c,
 142         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
 143         unittests/common-utils-selftests.c,
 144         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
 145         unittests/format_pieces-selftests.c,
 146         unittests/function-view-selftests.c,
 147         unittests/lookup_name_info-selftests.c,
 148         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
 149         unittests/mkdir-recursive-selftests.c,
 150         unittests/observable-selftests.c,
 151         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
 152         unittests/parse-connection-spec-selftests.c,
 153         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
 154         unittests/scoped_fd-selftests.c,
 155         unittests/scoped_mmap-selftests.c,
 156         unittests/scoped_restore-selftests.c,
 157         unittests/string_view-selftests.c, unittests/style-selftests.c,
 158         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
 159         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
 160         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
 161         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
 162         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
 163         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
 164
 165 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 166
 167         * linespec.c (decode_digits_list_mode): Set explicit_line to a
 168         bool value.
 169         (decode_digits_ordinary): Set explicit_line field in sal.
 170         * symtab.c (skip_prologue_sal): Don't skip prologue for a
 171         symtab_and_line that was set on an explicit line number in
 172         assembler code.  Do always update the recorded symtab and line if
 173         we do skip the prologue.
 174
 175 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 176
 177         * breakpoint.c (set_breakpoint_location_function): Remove
 178         explicit_loc parameter.
 179         (momentary_breakpoint_from_master): Update call to
 180         set_breakpoint_location_function.
 181         (add_location_to_breakpoint): Likewise.
 182
 183 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 184
 185         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
 186         required features based on default bfd type when no specific bfd
 187         is present.
 188
 189 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 190
 191         * NEWS: Mention that GDB printf and eval commands can now print
 192         C-style and Ada-style convenience var strings without
 193         calling the inferior.
 194         * printcmd.c (printf_c_string): Locally print GDB internal var
 195         instead of transiting via the inferior.
 196         (printf_wide_c_string): Likewise.
 197
 198 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 199
 200         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
 201
 202 2019-07-04  Tom Tromey  <tom@tromey.com>
 203
 204         PR tui/24724:
 205         * tui/tui-winsource.c (tui_clear_source_content): Update.
 206         (tui_source_window_base::set_is_exec_point_at): Fix comment.
 207         (tui_update_breakpoint_info): Update.
 208         (tui_set_exec_info_content): Update.
 209         * tui/tui-source.c (tui_set_source_content_nil): Update.
 210         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
 211         has_break.
 212         * tui/tui-data.h (enum tui_bp_flag): New.
 213         (tui_bp_flags): New enum flags type.
 214         (struct tui_source_element) <break_mode>: Change type.  Rename
 215         from has_break.
 216         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
 217         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
 218         constants.
 219         * tui/tui-winsource.h: Fix comment.
 220
 221 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 222
 223         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
 224         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
 225         (store_fpregs_to_thread)
 226         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 227         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
 228         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
 229         (IWMMXT_REGS_SIZE): Add define.
 230         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
 231         (fetch_vfp_regs, store_vfp_regs)
 232         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 233         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
 234
 235 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 236
 237         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
 238         defines.
 239         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
 240         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
 241         (ARM_INT_REGISTER_SIZE): ...to this.
 242         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
 243         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
 244         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
 245         (arm_linux_collect_gregset, supply_nwfpe_register)
 246         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
 247         defines.
 248         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
 249         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
 250         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
 251         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
 252         (arm_return_in_memory, arm_store_return_value)
 253         (arm_get_longjmp_target, arm_register_g_packet_guesses)
 254         (arm_record_ld_st_multiple): Likewise.
 255         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
 256         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
 257
 258 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 259
 260         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
 261         AARCH64_DISPLACED_MODIFIED_INSNS.
 262         * aarch64-tdep.c (struct aarch64_displaced_step_data)
 263         (aarch64_displaced_step_copy_insn): Likewise.
 264         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 265         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
 266         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
 267         ARM_DISPLACED_MODIFIED_INSNS.
 268         * arm-tdep.c (arm_gdbarch_init): Likewise.
 269         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 270         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
 271         (struct arm_displaced_step_closure): Use
 272         ARM_DISPLACED_MODIFIED_INSNS.
 273
 274 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 275
 276         * features/Makefile: Remove unused xml files.
 277         * features/aarch64.xml: Remove.
 278         * features/i386/amd64-avx-avx512-linux.xml: Remove.
 279         * features/i386/amd64-avx-avx512.xml: Remove.
 280         * features/i386/amd64-avx-linux.xml: Remove.
 281         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
 282         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
 283         * features/i386/amd64-avx-mpx-linux.xml: Remove.
 284         * features/i386/amd64-avx-mpx.xml: Remove.
 285         * features/i386/amd64-avx.xml: Remove.
 286         * features/i386/amd64-linux.xml: Remove.
 287         * features/i386/amd64-mpx-linux.xml: Remove.
 288         * features/i386/amd64-mpx.xml: Remove.
 289         * features/i386/amd64.xml: Remove.
 290         * features/i386/i386-avx-avx512-linux.xml: Remove.
 291         * features/i386/i386-avx-avx512.xml: Remove.
 292         * features/i386/i386-avx-linux.xml: Remove.
 293         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
 294         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
 295         * features/i386/i386-avx-mpx-linux.xml: Remove.
 296         * features/i386/i386-avx-mpx.xml: Remove.
 297         * features/i386/i386-avx.xml: Remove.
 298         * features/i386/i386-linux.xml: Remove.
 299         * features/i386/i386-mmx-linux.xml: Remove.
 300         * features/i386/i386-mmx.xml: Remove.
 301         * features/i386/i386-mpx-linux.xml: Remove.
 302         * features/i386/i386-mpx.xml: Remove.
 303         * features/i386/i386.xml: Remove.
 304         * features/i386/x32-avx-avx512-linux.xml: Remove.
 305         * features/i386/x32-avx-linux.xml: Remove.
 306         * features/i386/x32-linux.xml: Remove.
 307
 308 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 309
 310         * regformats/aarch64.dat: Remove.
 311         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
 312         * regformats/i386/amd64-avx-linux.dat: Remove.
 313         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
 314         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
 315         * regformats/i386/amd64-linux.dat: Remove.
 316         * regformats/i386/amd64-mpx-linux.dat: Remove.
 317         * regformats/i386/amd64.dat: Remove.
 318         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
 319         * regformats/i386/i386-avx-linux.dat: Remove.
 320         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
 321         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
 322         * regformats/i386/i386-linux.dat: Remove.
 323         * regformats/i386/i386-mmx-linux.dat: Remove.
 324         * regformats/i386/i386-mpx-linux.dat: Remove.
 325         * regformats/i386/i386.dat: Remove.
 326         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
 327         * regformats/i386/x32-avx-linux.dat: Remove.
 328         * regformats/i386/x32-linux.dat: Remove.
 329
 330 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 331
 332         * aarch64-tdep.c: Remove xml self tests.
 333         * amd64-linux-tdep.c: Likewise.
 334         * amd64-tdep.c: Likewise.
 335         * i386-linux-tdep.c: Likewise.
 336         * i386-tdep.c: Likewise.
 337
 338 2019-07-03  Pedro Alves  <palves@redhat.com>
 339
 340         PR cli/24732
 341         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
 342         (pipe_cmd_option_defs): New.
 343         (make_pipe_cmd_options_def_group): New.
 344         (pipe_command): Use gdb::option::process_options.
 345         (pipe_command_completer): New function.
 346         (_initialize_cli_cmds): Install completer for "pipe" command.
 347
 348 2019-07-03  Pedro Alves  <palves@redhat.com>
 349
 350         * cli/cli-option.c (union option_value) <string>: New field.
 351         (struct option_def_and_value): Add ctor, move ctor, dtor and
 352         use DISABLE_COPY_AND_ASSIGN.
 353         (option_def_and_value::clear_value): New.
 354         (parse_option, save_option_value_in_ctx, get_val_type_str)
 355         (add_setshow_cmds_for_options): Handle var_string.
 356         * cli-option.h (union option_def::var_address) <string>: New
 357         field.
 358         (struct string_option_def): New.
 359         * maint-test-options.c (struct test_options_opts): Add default
 360         ctor and use DISABLE_COPY_AND_ASSIGN.
 361         <string_opt>: New field.
 362         (test_options_opts::~test_options_opts): New.
 363         (test_options_opts::dump): Also dump "-string".
 364         (test_options_option_defs): Install "string.
 365
 366 2019-07-03  Pedro Alves  <palves@redhat.com>
 367
 368         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
 369         option_value with a null enumeration.
 370         (complete_options): Save the option values in the context.
 371         (save_option_value_in_ctx): New, factored out from ...
 372         (process_options): ... here.
 373         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
 374         of the function.
 375         * maint-test-options.c (test_options_opts::dump): New, factored
 376         out from ...
 377         (maintenance_test_options_command_mode): ... here.
 378         (maintenance_test_options_command_completion_result): Delete.
 379         (maintenance_test_options_command_completion_text): Update
 380         comment.
 381         (maintenance_show_test_options_completion_result): Change
 382         prototype.  Just print
 383         maintenance_test_options_command_completion_text.
 384         (save_completion_result): New.
 385         (maintenance_test_options_completer_mode): Pass options context to
 386         complete_options, and then save a dump.
 387         (_initialize_maint_test_options): Use add_cmd to install "maint
 388         show test-options-completion-result".
 389
 390 2019-07-03  Pedro Alves  <palves@redhat.com>
 391
 392         * NEWS (New commands): Mention "with" and "maint with".
 393         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
 394         (with_command, with_command_completer): New.
 395         (pipe_command): Adjust to new repeat_previous
 396         interface.
 397         (_initialize_cli_cmds): Install the "with" command and its "w"
 398         alias.
 399         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
 400         declarations.
 401         * cli/cli-setshow.c (parse_cli_var_uinteger)
 402         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
 403         argument strings for all var_types.
 404         (get_setshow_command_value_string): New, factored out from ...
 405         (do_show_command): ... this.
 406         * cli/cli-setshow.h: Include <string>.
 407         (get_setshow_command_value_string): Declare.
 408         * command.h (repeat_previous): Now returns const char *.  Adjust
 409         comment.
 410         * maint.c: Include "cli/cli-cmds.h".
 411         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
 412         (_initialize_maint_cmds): Register the "maintenance with" command.
 413         * top.c (repeat_previous): Move bits from pipe_command here:
 414         Return the saved command line, if any; error out if there's no
 415         command to relaunch.
 416
 417 2019-07-03  Pedro Alves  <palves@redhat.com>
 418
 419         * NEWS (New commands): Mention "maint set/show test-settings"
 420         instead of "maint test-settings".
 421         * maint-test-settings.c (maintenance_test_settings_list): Delete.
 422         (maintenance_test_settings_set_list): Rename to ...
 423         (maintenance_set_test_settings_list): ... this.
 424         (maintenance_test_settings_show_list): Rename to  ...
 425         (maintenance_show_test_settings_list): ... this.
 426         (maintenance_test_settings_cmd): Delete.
 427         (maintenance_test_settings_set_cmd): ...
 428         (maintenance_set_test_settings_cmd): ... this.
 429         (maintenance_test_settings_show_cmd): ...
 430         (maintenance_show_test_settings_cmd): ... this.
 431         (maintenance_test_settings_show_value_cmd):
 432         (maintenance_show_test_settings_value_cmd): ... this.
 433         (_initialize_maint_test_settings): No longer install the "maint
 434         test-settings" prefix command.  Rename "maint test-settings set"
 435         to "maint set test-settings", and "maint test-settings show" to
 436         "maint show test-settings".  Adjust all subcommands.
 437
 438 2019-07-03  Pedro Alves  <palves@redhat.com>
 439
 440         * maint-test-settings.c: Fix file's intro comment.  Replace all
 441         references to "test-options" with references to "test-settings",
 442         in comments.
 443
 444 2019-07-03  Pedro Alves  <palves@redhat.com>
 445
 446         * maint-test-settings.c (maintenance_test_settings_xxx)
 447         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
 448         New.
 449         (maintenance_test_settings_enums): Use them.
 450         (maintenance_test_settings_enum): Default to
 451         maintenance_test_settings_xxx.
 452         (_initialize_maint_test_settings): Initialize
 453         MAINTENANCE_TEST_SETTINGS_FILENAME.
 454
 455 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 456
 457         * breakpoint.h (remove_breakpoints_inf): Change return type to
 458         void, move function documentation here.
 459         * breakpoint.c (remove_breakpoints_inf): Change return type to
 460         void, move function documentation to header.
 461
 462 2019-07-02  Pedro Alves  <palves@redhat.com>
 463
 464         * NEWS (Completion improvements): Mention "info threads".
 465         * thread.c (struct info_threads_opts, info_threads_option_defs)
 466         (make_info_threads_options_def_group): New.
 467         (info_threads_command): Use gdb::option::process_options.
 468         (info_threads_command_completer): New.
 469         (_initialize_thread): Use gdb::option::build_help to build the
 470         help text for "info threads".
 471
 472 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 473
 474         * defs.h (generic_load): Move from here...
 475         * symfile.h (generic_load): ... to here.  Rename name parameter
 476         to args.
 477         * symfile.c (generic_load): Add comment.
 478
 479 2019-07-01  Tom Tromey  <tromey@adacore.com>
 480
 481         * dwarf2read.c
 482         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
 483         declaration of without_params.  Fix formatting.
 484
 485 2019-07-01  Tom Tromey  <tromey@adacore.com>
 486
 487         * ada-exp.y (find_primitive_type): Update.
 488         * ada-lang.h (ada_lookup_symbol): Update.
 489         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
 490         parameter.
 491         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
 492
 493 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 494
 495         PR breakpoints/24541
 496         * gdbarch.c: Regenerate.
 497         * gdbarch.h: Regenerate.
 498         * gdbarch.sh: Add 'stap_adjust_register'.
 499         * i386-tdep.c: Include '<unordered_set>'.
 500         (i386_stap_adjust_register): New function.
 501         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
 502         * stap-probe.c (stap_parse_register_operand): Call
 503         'gdbarch_stap_adjust_register'.
 504
 505 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 506
 507         PR python/24742
 508         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
 509         * python/python.c (do_start_initialization): Use 'xmalloc'
 510         instead of 'PyMem_Malloc'.
 511
 512 2019-06-28  Tom Tromey  <tromey@adacore.com>
 513
 514         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
 515         for Ada.
 516
 517 2019-06-27  Tom Tromey  <tromey@adacore.com>
 518
 519         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
 520         objfile_key.
 521         (arm_find_mapping_symbol, arm_record_special_symbol)
 522         (_initialize_arm_tdep): Update.
 523         (arm_objfile_data_free): Remove.
 524
 525 2019-06-27  Tom Tromey  <tromey@adacore.com>
 526
 527         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
 528         to cp_print_static_field.
 529
 530 2019-06-26  Tom Tromey  <tromey@adacore.com>
 531
 532         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
 533         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
 534         declare.
 535
 536 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 537
 538         * features/aarch64-core.c (create_feature_aarch64_core):
 539         Regenerate.
 540         * features/aarch64-core.xml: Add cpsr flags.
 541
 542 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 543
 544         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
 545         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
 546
 547 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 548
 549         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
 550         field.
 551         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
 552         use.
 553         (arm_record_special_symbol): Don't insert new symbol in sorted
 554         position, push it at the end.
 555
 556 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 557
 558         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
 559         (arm_mapping_symbol_s): Remove.
 560         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
 561         (arm_mapping_symbol_vec): New typedef.
 562         (struct arm_per_objfile): Add constructor.
 563         <section_maps>: Change type to
 564         std::unique_ptr<arm_mapping_symbol_vec[]>.
 565         (arm_compare_mapping_symbols): Remove.
 566         (arm_find_mapping_symbol): Adjust to section_maps type change.
 567         (arm_objfile_data_free): Call delete on arm_per_objfile.
 568         (arm_record_special_symbol): Adjust to section_maps type change.
 569         Allocate arm_per_objfile with new.
 570
 571 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 572
 573         * cli/cli-cmds.c (alias_command): Compare the alias prefix
 574         with the command prefix.
 575
 576 2019-06-25  Tom Tromey  <tom@tromey.com>
 577
 578         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
 579         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
 580
 581 2019-06-25  Tom Tromey  <tom@tromey.com>
 582
 583         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
 584         type.
 585         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
 586         protected.
 587
 588 2019-06-25  Tom Tromey  <tom@tromey.com>
 589
 590         * tui/tui-winsource.c
 591         (tui_source_window_base::set_is_exec_point_at): Add check against
 592         LOA_ADDRESS.
 593
 594 2019-06-25  Tom Tromey  <tom@tromey.com>
 595
 596         * tui/tui-source.c (tui_set_source_content): Don't check before
 597         xfree.
 598         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
 599
 600 2019-06-25  Tom Tromey  <tom@tromey.com>
 601
 602         * tui/tui-winsource.h (tui_update_source_window_as_is)
 603         (tui_alloc_source_buffer, tui_line_is_displayed)
 604         (tui_addr_is_displayed): Change type of win_info.
 605         * tui/tui-winsource.c (tui_update_source_window_as_is)
 606         (tui_clear_source_content, tui_show_source_line)
 607         (tui_show_source_content, tui_source_window_base::refill)
 608         (tui_source_window_base::set_is_exec_point_at)
 609         (tui_source_window_base::set_is_exec_point_at)
 610         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
 611         (tui_alloc_source_buffer, tui_line_is_displayed)
 612         (tui_addr_is_displayed): Change type of win_info.  Update.
 613         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 614         (tui_source_window_base::do_make_visible_with_new_height):
 615         Update.
 616         * tui/tui-source.c (tui_set_source_content)
 617         (tui_set_source_content_nil)
 618         (tui_source_window::do_scroll_vertical): Update.
 619         * tui/tui-layout.c (show_layout): Update.
 620         * tui/tui-disasm.c (tui_set_disassem_content)
 621         (tui_disasm_window::do_scroll_vertical): Update.
 622         * tui/tui-data.h (tui_win_content): Remove.
 623         (struct tui_gen_win_info) <content, content_size>: Remove.
 624         (struct tui_source_element): Add initializers and destructor.
 625         (union tui_which_element, struct tui_win_element): Remove.
 626         (struct tui_source_window_base) <content>: New field.
 627         (struct tui_data_window): Remove destructor.
 628         (tui_alloc_content, tui_free_win_content)
 629         (tui_free_all_source_wins_content): Don't declare.
 630         * tui/tui-data.c (tui_initialize_static_data): Update.
 631         (init_content_element, tui_alloc_content): Remove.
 632         (~tui_gen_win_info): Update.
 633         (~tui_data_window, tui_free_all_source_wins_content)
 634         (tui_free_win_content, free_content, free_content_elements):
 635         Remove.
 636
 637 2019-06-25  Tom Tromey  <tom@tromey.com>
 638
 639         * tui/tui-winsource.h (tui_clear_source_content)
 640         (tui_erase_source_content, tui_show_source_content): Change type
 641         of win_info.
 642         * tui/tui-winsource.c (tui_clear_source_content)
 643         (tui_erase_source_content, tui_show_source_content): Change type
 644         of win_info.
 645         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 646         * tui/tui-source.h (tui_set_source_content_nil): Change type of
 647         win_info.
 648         * tui/tui-source.c (tui_set_source_content_nil): Change type of
 649         win_info.
 650         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
 651
 652 2019-06-25  Tom Tromey  <tom@tromey.com>
 653
 654         * tui/tui-winsource.c (tui_clear_source_content)
 655         (tui_source_window_base::set_is_exec_point_at): Update.
 656         * tui/tui-source.c (tui_set_source_content_nil): Update.
 657         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
 658         a bool.
 659         * tui/tui-data.c (init_content_element): Update.
 660
 661 2019-06-25  Tom Tromey  <tom@tromey.com>
 662
 663         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
 664         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
 665         * tui/tui-layout.c (init_and_make_win): Update.
 666         * tui/tui.h (enum tui_win_type): Update.
 667         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
 668         tui_win_is_auxillary.
 669         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
 670         tui_win_is_auxillary.
 671
 672 2019-06-25  Tom Tromey  <tom@tromey.com>
 673
 674         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
 675         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
 676         (tui_delete_data_content_windows, tui_display_all_data)
 677         (tui_data_window::do_scroll_vertical, tui_display_data_from):
 678         Update.
 679         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
 680         * tui/tui-regs.c (tui_last_regs_line_no)
 681         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 682         (tui_show_registers): Update.
 683         (tui_show_register_group): Return void.  Update.
 684         (tui_display_registers_from, tui_display_reg_element_at_line)
 685         (tui_display_registers_from_line, tui_check_register_values):
 686         Update.
 687         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
 688         member.
 689         (struct tui_data_window) <regs_content>: Now a std::vector.
 690         <regs_content_count>: Remove.
 691         (tui_add_content_elements, tui_free_data_content): Don't declare.
 692         * tui/tui-data.c (tui_data_window::clear_detail): Update.
 693         (init_content_element): Remove DATA_WIN case.  Add assert.
 694         (tui_add_content_elements): Remove.
 695         (tui_data_window): Update.
 696         (tui_free_data_content): Remove.
 697         (free_content_elements): Remove DATA_WIN case.
 698
 699 2019-06-25  Tom Tromey  <tom@tromey.com>
 700
 701         * tui/tui-data.c (tui_data_item_window): Update.
 702         * tui/tui-windata.h (tui_check_data_values): Don't declare.
 703         * tui/tui-windata.c (tui_display_all_data)
 704         (tui_display_data_from_line): Update.
 705         (tui_check_data_values): Remove.
 706         * tui/tui-regs.c (tui_show_register_group)
 707         (tui_display_reg_element_at_line): Update.
 708         * tui/tui-hooks.c (tui_register_changed)
 709         (tui_refresh_frame_and_register_information): Call
 710         tui_check_register_values.
 711         * tui/tui-data.h (struct tui_data_window) <data_content,
 712         data_content_count, data_type>: Remove.
 713         (enum tui_data_type): Remove.
 714
 715         * tui/tui-data.c (tui_data_window::clear_detail)
 716         (~tui_data_window): Update.
 717
 718 2019-06-25  Tom Tromey  <tom@tromey.com>
 719
 720         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
 721         declare.
 722         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
 723         Rename from tui_first_data_item_displayed.  Update.
 724         (tui_data_window::refresh_all)
 725         (tui_data_window::do_scroll_vertical): Update.
 726         * tui/tui-data.h (struct tui_data_window)
 727         <first_data_item_displayed>: Declare new method.
 728
 729 2019-06-25  Tom Tromey  <tom@tromey.com>
 730
 731         * tui/tui-data.h (tui_init_generic_part): Don't declare.
 732         * tui/tui-data.c (tui_init_generic_part): Remove, moving
 733         contents...
 734         (tui_initialize_static_data): ...here.
 735
 736 2019-06-25  Tom Tromey  <tom@tromey.com>
 737
 738         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 739         (tui_display_registers_from, tui_check_register_values): Update.
 740         (tui_display_register): Remove win_info parameter; update.
 741         (tui_get_register): Change type of parameters.
 742         * tui/tui-data.h (struct tui_data_element): Remove.
 743         (union tui_which_element) <data>: Remove.
 744         <data_window>: Change type.
 745         (struct tui_data_item_window): New.
 746         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
 747         case.  Add assert.
 748         (~tui_data_item_window): New destructor.
 749         (free_content_elements): Remove DATA_ITEM_WIN case.
 750
 751 2019-06-25  Tom Tromey  <tom@tromey.com>
 752
 753         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
 754         Remove.
 755
 756 2019-06-25  Tom Tromey  <tom@tromey.com>
 757
 758         * tui/tui-data.h (struct tui_command_element): Remove.
 759         (union tui_which_element) <command>: Remove.
 760         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
 761         assert.
 762         (free_content_elements): Remove CMD_WIN case.
 763
 764 2019-06-25  Tom Tromey  <tom@tromey.com>
 765
 766         * tui/tui-layout.c (tui_set_layout): Update.
 767         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
 768         * tui/tui-data.c (layout_def): Update.
 769
 770 2019-06-25  Tom Tromey  <tom@tromey.com>
 771
 772         * tui/tui-wingeneral.c (tui_refresh_all): Update.
 773         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 774         (tui_source_window_base::set_new_height): Update.
 775         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
 776         Update.
 777         (tui_set_locator_fullname, tui_set_locator_info)
 778         (tui_show_frame_info): Update.
 779         * tui/tui-source.c (tui_set_source_content)
 780         (tui_source_is_displayed): Update.
 781         * tui/tui-layout.c (show_source_disasm_command, show_data)
 782         (show_source_or_disasm_and_command): Update.
 783         * tui/tui-disasm.c (tui_set_disassem_content)
 784         (tui_get_begin_asm_address): Update.
 785         * tui/tui-data.h (struct tui_locator_element): Remove.
 786         (union tui_which_element) <locator>: Remove.
 787         (struct tui_locator_window): New.
 788         (tui_locator_win_info_ptr): Change return type.
 789         * tui/tui-data.c (_locator): Change type.
 790         (tui_locator_win_info_ptr): Change return type.
 791         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
 792         (tui_alloc_content): Add assert.
 793
 794 2019-06-25  Tom Tromey  <tom@tromey.com>
 795
 796         * tui/tui-winsource.c
 797         (tui_exec_info_window::maybe_allocate_content): New method.
 798         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
 799         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
 800         (make_source_or_disasm_window): Add cast.
 801         * tui/tui-data.h (union tui_which_element) <simple_string>:
 802         Remove.
 803         (struct tui_source_info): New.
 804         (struct tui_source_window_base) <execution_info>: Change type.
 805         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
 806         case, and add assert.
 807         (tui_alloc_content): Add assert.
 808
 809 2019-06-25  Tom Tromey  <tom@tromey.com>
 810
 811         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
 812         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
 813         * tui/tui-data.c (tui_alloc_win_info): Remove.
 814
 815 2019-06-25  Tom Tromey  <tom@tromey.com>
 816
 817         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
 818         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
 819         can_highlight.
 820
 821 2019-06-25  Tom Tromey  <tom@tromey.com>
 822
 823         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
 824         make_visible_with_new_height method.
 825         (tui_win_info::make_visible_with_new_height): New method.
 826         (tui_source_window_base::do_make_visible_with_new_height)
 827         (tui_data_window::do_make_visible_with_new_height)
 828         (tui_cmd_window::do_make_visible_with_new_height): New methods.
 829         (make_visible_with_new_height): Remove.
 830         (tui_resize_all, tui_adjust_win_heights): Use
 831         make_visible_with_new_height method.
 832         * tui/tui-data.h (struct tui_win_info)
 833         <do_make_visible_with_new_height, make_visible_with_new_height>:
 834         New methods.
 835         (struct tui_source_window_base, struct tui_data_window)
 836         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
 837         methods.
 838
 839 2019-06-25  Tom Tromey  <tom@tromey.com>
 840
 841         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
 842         method.
 843         (update_tab_width): Call update_tab_width method.
 844         * tui/tui-data.h (struct tui_win_info)
 845         (struct tui_source_window_base) <update_tab_width>: New methods.
 846
 847 2019-06-25  Tom Tromey  <tom@tromey.com>
 848
 849         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
 850         parameter.
 851         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
 852         parameter.
 853         (tui_gen_win_info::make_visible): Update.
 854         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
 855         parameter.
 856         * tui/tui-data.h (enum tui_box): New enum.
 857         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
 858
 859 2019-06-25  Tom Tromey  <tom@tromey.com>
 860
 861         * tui/tui-layout.c (make_source_or_disasm_window): Always use
 862         init_and_make_win for EXEC_INFO_WIN.
 863         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
 864         longer inline.
 865         (struct tui_win_info) <~tui_win_info>: Inline.
 866         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 867         Don't declare.
 868         * tui/tui-data.c (source_win, disasm_win): Remove globals.
 869         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 870         Remove.
 871         (tui_initialize_static_data): Update.
 872         (~tui_gen_win_info): Handle more cleanup here.
 873         (~tui_source_window_base): Delete "execution_info".
 874         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
 875
 876 2019-06-25  Tom Tromey  <tom@tromey.com>
 877
 878         * tui/tui-layout.c (make_command_window): Don't set
 879         can_highlight.
 880         (show_source_disasm_command): Call the reset method.
 881         (show_data): Don't set can_highlight.  Call the reset method.
 882         (tui_gen_win_info::reset): Rename from init_gen_win_info
 883         (init_and_make_win): Simplify.  Return tui_gen_win_info.
 884         (show_source_or_disasm_and_command): Call the reset method.
 885         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
 886         (struct tui_cmd_window): Set can_highlight.
 887
 888 2019-06-25  Tom Tromey  <tom@tromey.com>
 889
 890         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
 891         from make_visible.
 892         (tui_make_visible, tui_make_invisible): Rewrite.
 893         (tui_win_info::make_visible): Remove.
 894         (tui_source_window_base::make_visible): Update.
 895         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
 896         method.  Moved from...
 897         (struct tui_win_info) <make_visible>: ...here.
 898
 899 2019-06-25  Tom Tromey  <tom@tromey.com>
 900
 901         * tui/tui-winsource.c
 902         (tui_source_window_base::do_scroll_horizontal): Remove direction
 903         parameter.
 904         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
 905         direction parameter.
 906         * tui/tui-win.c (tui_win_info::forward_scroll)
 907         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 908         (tui_win_info::right_scroll): Update.
 909         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
 910         direction parameter.
 911         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
 912         direction parameter.
 913         * tui/tui-data.h (enum tui_scroll_direction): Remove.
 914         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
 915         Remove direction parameter.
 916         (struct tui_source_window_base, struct tui_source_window)
 917         (struct tui_disasm_window, struct tui_data_window)
 918         (struct tui_cmd_window): Update.
 919
 920 2019-06-25  Tom Tromey  <tom@tromey.com>
 921
 922         * tui/tui-winsource.h (tui_set_exec_info_content)
 923         (tui_show_exec_info_content, tui_erase_exec_info_content)
 924         (tui_clear_exec_info_content, tui_update_exec_info): Change
 925         argument to tui_source_window_base.
 926         * tui/tui-winsource.c (tui_set_exec_info_content)
 927         (tui_show_exec_info_content, tui_erase_exec_info_content)
 928         (tui_clear_exec_info_content, tui_update_exec_info): Change
 929         argument to tui_source_window_base.
 930
 931 2019-06-25  Tom Tromey  <tom@tromey.com>
 932
 933         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
 934         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
 935
 936 2019-06-25  Tom Tromey  <tom@tromey.com>
 937
 938         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
 939         check.
 940
 941 2019-06-25  Tom Tromey  <tom@tromey.com>
 942
 943         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
 944         type to void.
 945         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
 946         type to void.
 947         * tui/tui-source.c (tui_set_source_content): Update.
 948         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 949
 950 2019-06-25  Tom Tromey  <tom@tromey.com>
 951
 952         * tui/tui-win.c (window_name_completer, tui_set_focus)
 953         (tui_all_windows_info): Use name method.
 954         * tui/tui-data.h (struct tui_gen_win_info)
 955         (struct tui_source_window, struct tui_disasm_window)
 956         (struct tui_data_window, struct tui_cmd_window) <name>: New
 957         method.
 958         (tui_win_name): Don't declare.
 959         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
 960         (tui_win_name): Remove.
 961
 962 2019-06-25  Tom Tromey  <tom@tromey.com>
 963
 964         * tui/tui-winsource.h (tui_update_source_window)
 965         (tui_update_source_window_as_is): Change parameter type.
 966         * tui/tui-winsource.c (tui_update_source_window): Change win_info
 967         to be a tui_source_window_base.
 968         (tui_update_source_window_as_is): Likewise.
 969         * tui/tui-win.c (make_visible_with_new_height): Update.
 970
 971 2019-06-25  Tom Tromey  <tom@tromey.com>
 972
 973         * tui/tui-winsource.c (tui_erase_source_content)
 974         (tui_show_source_content, tui_show_exec_info_content)
 975         (tui_erase_exec_info_content): Use refresh_window method.
 976         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
 977         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
 978         from tui_refresh_win.
 979         (tui_data_window::refresh_window): New method.
 980         (tui_win_info::refresh, tui_source_window_base::refresh)
 981         (tui_refresh_all): Use refresh_window method.
 982         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
 983         method.
 984         * tui/tui-regs.c (tui_display_register): Call refresh_window
 985         method.
 986         * tui/tui-layout.c (show_source_disasm_command)
 987         (show_source_or_disasm_and_command): Call refresh_window method.
 988         * tui/tui-data.h (struct tui_gen_win_info)
 989         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
 990         New method.
 991
 992 2019-06-25  Tom Tromey  <tom@tromey.com>
 993
 994         * tui/tui.c (tui_rl_other_window, tui_enable)
 995         (tui_is_window_visible, tui_get_command_dimension): Update.
 996         * tui/tui-winsource.c (tui_update_source_window_as_is)
 997         (tui_clear_source_content, tui_erase_source_content)
 998         (tui_show_source_line, tui_source_window_base::refill)
 999         (tui_source_window_base::do_scroll_horizontal)
1000         (tui_source_window_base::set_is_exec_point_at)
1001         (tui_update_breakpoint_info, tui_set_exec_info_content)
1002         (tui_alloc_source_buffer, tui_line_is_displayed)
1003         (tui_addr_is_displayed): Update.
1004         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1005         (tui_check_and_display_highlight_if_needed)
1006         (tui_win_info::make_visible, tui_win_info::refresh)
1007         (tui_refresh_all): Update.
1008         * tui/tui-windata.c (tui_first_data_item_displayed)
1009         (tui_delete_data_content_windows, tui_erase_data_content)
1010         (tui_display_all_data, tui_data_window::refresh_all)
1011         (tui_check_data_values): Update.
1012         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1013         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1014         (tui_win_info::backward_scroll, tui_refresh_all_win)
1015         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1016         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1017         (tui_source_window_base::set_new_height)
1018         (tui_data_window::set_new_height)
1019         (make_invisible_and_set_new_height)
1020         (make_visible_with_new_height, new_height_ok)
1021         (parse_scrolling_args): Update.
1022         * tui/tui-stack.c (tui_show_frame_info): Update.
1023         * tui/tui-source.c (tui_set_source_content)
1024         (tui_set_source_content_nil, tui_source_is_displayed)
1025         (tui_source_window::do_scroll_vertical): Update.
1026         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1027         (tui_display_registers_from, tui_display_reg_element_at_line)
1028         (tui_check_register_values, tui_reg_command): Update.
1029         * tui/tui-layout.c (tui_default_win_height)
1030         (show_source_disasm_command, show_data, init_and_make_win)
1031         (show_source_or_disasm_and_command): Update.
1032         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1033         (tui_redisplay_readline, tui_mld_flush)
1034         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1035         (tui_getc): Update.
1036         * tui/tui-disasm.c (tui_set_disassem_content)
1037         (tui_disasm_window::do_scroll_vertical): Update.
1038         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1039         Now virtual.
1040         (struct tui_win_info): Derive from tui_gen_win_info.
1041         <~tui_win_info>: Mark as override.
1042         <generic>: Remove member.
1043         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1044         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1045         (~tui_data_window, ~tui_win_info)
1046         (tui_free_all_source_wins_content): Update.
1047         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1048
1049 2019-06-25  Tom Tromey  <tom@tromey.com>
1050
1051         * tui/tui-layout.c (init_and_make_win): Use new.
1052         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1053         destructor, initializers.
1054         (tui_alloc_generic_win_info): Don't declare.
1055         * tui/tui-data.c (_locator): Add argument to constructor.
1056         (source_win, disasm_win): New globals.
1057         (exec_info): Remove.
1058         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1059         Update.
1060         (tui_alloc_generic_win_info): Remove.
1061         (init_content_element): Use new.
1062         (tui_win_info::tui_win_info): Update.
1063         (free_content_elements) <case DATA_WIN>: Use delete.
1064
1065 2019-06-25  Tom Tromey  <tom@tromey.com>
1066
1067         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1068         * tui/tui-windata.c (tui_first_data_item_displayed)
1069         (tui_delete_data_content_windows): Update.
1070         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1071         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1072         (tui_display_registers_from, tui_check_register_values): Update.
1073         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1074         pointer.
1075         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1076         window.
1077         (tui_free_data_content): Update.
1078         (free_content_elements) <case DATA_WIN>: Free the window.
1079
1080 2019-06-25  Tom Tromey  <tom@tromey.com>
1081
1082         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1083         Update.
1084         * tui/tui-layout.c (make_command_window)
1085         (show_source_disasm_command, show_data, init_and_make_win)
1086         (show_source_or_disasm_and_command): Update.
1087         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1088         method.
1089         <can_highight, is_highlighted>: Now bool.
1090         (tui_set_win_highlight): Don't declare.
1091         * tui/tui-data.c (tui_set_win_highlight): Remove.
1092
1093 2019-06-25  Tom Tromey  <tom@tromey.com>
1094
1095         * tui/tui-wingeneral.c (make_visible): Remove check of window
1096         type.
1097
1098 2019-06-25  Tom Tromey  <tom@tromey.com>
1099
1100         * tui/tui-win.c (tui_win_info::max_height)
1101         (tui_cmd_window::max_height): New methods.
1102         (new_height_ok): Call max_height.
1103         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1104         <max_height>: New method.
1105
1106 2019-06-25  Tom Tromey  <tom@tromey.com>
1107
1108         * tui/tui-win.c (tui_source_window_base::set_new_height)
1109         (tui_data_window::set_new_height): New methods.
1110         (make_invisible_and_set_new_height): Call set_new_height method.
1111         * tui/tui-data.h (struct tui_win_info)
1112         (struct tui_source_window_base, struct tui_data_window)
1113         <set_new_height>: New method.
1114
1115 2019-06-25  Tom Tromey  <tom@tromey.com>
1116
1117         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1118         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1119         tui_refresh_data_win.
1120         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1121         method.
1122         (tui_refresh_all_win): Call the refresh_all method.
1123         (tui_set_focus): Likewise.
1124         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1125         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1126         Likewise.
1127
1128 2019-06-25  Tom Tromey  <tom@tromey.com>
1129
1130         * tui/tui-winsource.h (tui_refill_source_window)
1131         (tui_set_is_exec_point_at): Don't declare.
1132         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1133         (tui_source_window_base::refill): Rename from
1134         tui_refill_source_window.
1135         (tui_source_window_base::do_scroll_horizontal): Update.
1136         (tui_source_window_base::set_is_exec_point_at): Rename from
1137         tui_set_is_exec_point_at.
1138         (tui_update_all_breakpoint_info): Update.
1139         * tui/tui-stack.c (tui_show_frame_info): Update.
1140         * tui/tui-layout.c (show_data): Add cast.
1141         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1142         * tui/tui-data.h (struct tui_source_window_base) <refill,
1143         set_is_exec_point_at>: New methods.
1144         (tui_source_windows, tui_add_to_source_windows): Update types.
1145         (tui_add_to_source_windows): Remove redundant declaration.
1146         * tui/tui-data.c (source_windows): Store tui_source_window_base.
1147         (tui_source_windows): Change return type.
1148         (tui_clear_source_windows_detail): Update.
1149         (tui_add_to_source_windows): Change type of parameter.
1150         (tui_free_all_source_wins_content): Update.
1151
1152 2019-06-25  Tom Tromey  <tom@tromey.com>
1153
1154         * tui/tui-wingeneral.c (tui_win_info::refresh)
1155         (tui_source_window_base::refresh): New methods.
1156         (tui_refresh_all): Call the refresh method.
1157         * tui/tui-data.h (struct tui_win_info)
1158         (struct tui_source_window_base) <refresh>: New method.
1159
1160 2019-06-25  Tom Tromey  <tom@tromey.com>
1161
1162         * tui/tui.h (tui_is_window_visible): Return bool.
1163         * tui/tui.c (tui_is_window_visible): Return bool.
1164         * tui/tui-wingeneral.c (tui_make_window, make_visible)
1165         (tui_make_visible, tui_make_invisible)
1166         (tui_win_info::make_visible)
1167         (tui_source_window_base::make_visible, make_all_visible)
1168         (tui_make_all_visible, tui_make_all_invisible): Update.
1169         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
1170         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
1171         bool.
1172         (struct tui_win_info, struct tui_source_window_base)
1173         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
1174         * tui/tui-data.c (tui_init_generic_part): Update.
1175
1176 2019-06-25  Tom Tromey  <tom@tromey.com>
1177
1178         * tui/tui-wingeneral.c (tui_win_info::make_visible)
1179         (tui_source_window_base::make_visible): New methods.
1180         (make_all_visible): Make method call.
1181         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
1182         (struct tui_source_window_base, struct tui_cmd_window): Override
1183         make_visible.
1184         (tui_win_is_source_type): Don't declare.
1185         * tui/tui-data.c (tui_win_is_source_type): Remove.
1186
1187 2019-06-25  Tom Tromey  <tom@tromey.com>
1188
1189         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
1190         NULL check.
1191
1192 2019-06-25  Tom Tromey  <tom@tromey.com>
1193
1194         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
1195         Inline constructor.  Add initializers for members.
1196         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
1197         constructors; now inline in class.
1198
1199 2019-06-25  Tom Tromey  <tom@tromey.com>
1200
1201         * tui/tui-regs.c (tui_show_registers): Update.
1202         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
1203         bool.
1204         * tui/tui-data.c (tui_data_window::clear_detail)
1205         (tui_data_window): Update.
1206
1207 2019-06-25  Tom Tromey  <tom@tromey.com>
1208
1209         * tui/tui-windata.c (tui_display_all_data)
1210         (tui_display_data_from_line, tui_display_data_from)
1211         (tui_check_data_values, tui_data_window::do_scroll_vertical):
1212         Update.
1213         * tui/tui-regs.c (tui_last_regs_line_no)
1214         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1215         (tui_show_registers, tui_show_register_group)
1216         (tui_display_registers_from, tui_display_reg_element_at_line)
1217         (tui_display_registers_from_line, tui_check_register_values)
1218         (tui_reg_next, tui_reg_prev): Update.
1219         * tui/tui-layout.c (tui_set_layout, show_data): Update.
1220         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
1221         tui_data_window.
1222         (struct tui_win_info) <detail>: Remove.  Add new fields from
1223         tui_data_info.
1224         (TUI_DATA_WIN): Add cast.
1225         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
1226         (~tui_data_window): Simplify.
1227
1228 2019-06-25  Tom Tromey  <tom@tromey.com>
1229
1230         * tui/tui-layout.c (show_source_disasm_command)
1231         (show_source_or_disasm_and_command): Update.
1232         * tui/tui-io.c (update_cmdwin_start_line)
1233         (tui_redisplay_readline): Update.
1234         * tui/tui-data.h (struct tui_command_info): Remove.
1235         (struct tui_win_info) <detail>: Remove command_info member.
1236         (struct tui_data_window) <start_line>: New member, from
1237         tui_command_info.
1238         (TUI_CMD_WIN): Add casts.
1239
1240 2019-06-25  Tom Tromey  <tom@tromey.com>
1241
1242         * tui/tui-winsource.c (tui_update_source_window)
1243         (tui_refill_source_window)
1244         (tui_source_window_base::do_scroll_horizontal)
1245         (tui_update_breakpoint_info, tui_set_exec_info_content)
1246         (tui_show_exec_info_content, tui_erase_exec_info_content)
1247         (tui_clear_exec_info_content): Update.
1248         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
1249         Update.
1250         * tui/tui-win.c (make_invisible_and_set_new_height)
1251         (make_visible_with_new_height): Update.
1252         * tui/tui-source.c (tui_set_source_content)
1253         (tui_show_symtab_source): Update.
1254         * tui/tui-layout.c (extract_display_start_addr)
1255         (show_source_disasm_command, show_data)
1256         (make_source_or_disasm_window)
1257         (show_source_or_disasm_and_command): Update.
1258         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
1259         (tui_disasm_window::do_scroll_vertical): Remove shadowing
1260         "gdbarch".
1261         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
1262         to tui_source_window_base.
1263         (struct tui_win_info) <detail>: Remove source_info member.
1264         (struct tui_source_window_base) <has_locator>: Inline.
1265         Move contents from tui_source_info; rename has_locator member to
1266         m_has_locator.
1267         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
1268         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
1269         header file.
1270         (tui_source_window_base::clear_detail, ~tui_source_window_base):
1271         Simplify.
1272         (tui_free_all_source_wins_content): Cast to
1273         tui_source_window_base.
1274
1275 2019-06-25  Tom Tromey  <tom@tromey.com>
1276
1277         * tui/tui-win.c (make_invisible_and_set_new_height)
1278         (make_visible_with_new_height): Call has_locator method.
1279         * tui/tui-layout.c (show_source_disasm_command, show_data)
1280         (show_source_or_disasm_and_command): Update for bool change.
1281         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
1282         (tui_win_info) <has_locator>: New method.
1283         (struct tui_source_window_base) <has_locator>: New method.
1284         (tui_win_has_locator): Don't declare.
1285         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
1286         from tui_win_has_locator.
1287         (tui_source_window_base): Use false, not FALSE.
1288
1289 2019-06-25  Tom Tromey  <tom@tromey.com>
1290
1291         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
1292         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
1293         clear_detail method directly.
1294         (tui_clear_win_detail): Remove.
1295
1296 2019-06-25  Tom Tromey  <tom@tromey.com>
1297
1298         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
1299         "this", not TUI_DISASM_WIN.
1300
1301 2019-06-25  Tom Tromey  <tom@tromey.com>
1302
1303         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
1304         declare.
1305         * tui/tui-winsource.c
1306         (tui_source_window_base::do_scroll_horizontal): Rename from
1307         tui_horizontal_source_scroll.
1308         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
1309         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
1310         from tui_vertical_data_scroll.
1311         * tui/tui-win.h (tui_scroll): Don't declare.
1312         * tui/tui-win.c (tui_win_info::forward_scroll)
1313         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1314         (tui_win_info::right_scroll): Rename and update.
1315         (tui_scroll_forward_command, tui_scroll_backward_command)
1316         (tui_scroll_left_command, tui_scroll_right_command): Update.
1317         (tui_scroll): Remove.
1318         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
1319         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
1320         from tui_vertical_source_scroll.
1321         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
1322         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
1323         from tui_vertical_disassem_scroll.
1324         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
1325         do_scroll_horizontal>: New methods.
1326         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
1327         Likewise.
1328         (struct tui_source_window_base): Add do_scroll_horizontal.
1329         (struct tui_source_window, struct tui_disasm_window): Add
1330         do_scroll_vertical.
1331         (struct tui_data_window, struct tui_cmd_window): Add
1332         do_scroll_horizontal and do_scroll_vertical.
1333         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
1334
1335 2019-06-25  Tom Tromey  <tom@tromey.com>
1336
1337         * tui/tui-data.h (struct tui_source_window_base): New struct.
1338         (struct tui_source_window): Derive from tui_source_window_base.
1339         (struct tui_disasm_window): New struct.
1340         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
1341         from tui_source_window::clear_detail.
1342         (tui_source_window_base): Rename from tui_source_window.
1343         (~tui_source_window_base): Rename from ~tui_source_window.
1344         (tui_alloc_win_info): Create a tui_disasm_window.
1345
1346 2019-06-25  Tom Tromey  <tom@tromey.com>
1347
1348         * tui/tui-data.h (struct tui_source_window)
1349         (struct tui_data_window): Declare destructors.
1350         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
1351         destructors.
1352         (tui_win_info): Simplify.
1353
1354 2019-06-25  Tom Tromey  <tom@tromey.com>
1355
1356         * tui/tui-winsource.c (tui_display_main)
1357         (tui_update_source_windows_with_addr)
1358         (tui_update_all_breakpoint_info): Update.
1359         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1360         (new_height_ok, parse_scrolling_args): Update.
1361         * tui/tui-stack.c (tui_show_frame_info): Update.
1362         * tui/tui-data.h (struct tui_list): Remove.
1363         (tui_source_windows): Return a reference to a std::vector.
1364         * tui/tui-data.c (source_windows): Now a std::vector.
1365         (tui_source_windows): Change return type.
1366         (tui_clear_source_windows): Rewrite.
1367         (tui_clear_source_windows_detail, tui_add_to_source_windows)
1368         (tui_free_all_source_wins_content): Rewrite.
1369
1370 2019-06-25  Tom Tromey  <tom@tromey.com>
1371
1372         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
1373         (struct tui_data_window, struct tui_cmd_window): Declare
1374         clear_detail method.
1375         * tui/tui-data.c (tui_source_window::clear_detail)
1376         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
1377         methods.
1378         (tui_clear_win_detail): Simplify.
1379
1380 2019-06-25  Tom Tromey  <tom@tromey.com>
1381
1382         * tui/tui-layout.c (make_source_window, make_disasm_window)
1383         (make_source_or_disasm_window): Remove win_info_ptr parameter.
1384         Return the new window.
1385         (show_source_disasm_command, show_data)
1386         (show_source_or_disasm_and_command): Update.
1387
1388 2019-06-25  Tom Tromey  <tom@tromey.com>
1389
1390         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
1391         parameter.  Return the new window.
1392         (show_source_disasm_command): Update and remove NULL check.
1393         (show_source_or_disasm_and_command): Update.
1394
1395 2019-06-25  Tom Tromey  <tom@tromey.com>
1396
1397         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
1398
1399 2019-06-25  Tom Tromey  <tom@tromey.com>
1400
1401         * tui/tui-data.h (struct tui_win_info): Make constructor
1402         protected.  Make destructor virtual.  Add initializers.
1403         (tui_source_window, tui_data_window, tui_cmd_window): New
1404         classes.
1405         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
1406         constructor.  Add "type" parameter.
1407         (tui_source_window, tui_data_window, tui_cmd_window): New
1408         constructors.
1409         (tui_alloc_win_info): Instantiate the appropriate subclass.
1410
1411 2019-06-25  Tom Tromey  <tom@tromey.com>
1412
1413         * tui/tui-win.c (tui_resize_all): Use delete.
1414         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
1415         destructor.
1416         (tui_free_window): Don't declare.
1417         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
1418         Update.
1419
1420 2019-06-25  Tom Tromey  <tom@tromey.com>
1421
1422         * tui/tui-data.h (struct tui_win_info): Add constructor.
1423         * tui/tui-data.c (tui_alloc_win_info): Use new.
1424         (tui_free_window): Use delete.
1425
1426 2019-06-22  Tom Tromey  <tom@tromey.com>
1427
1428         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
1429         declare.
1430         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
1431
1432 2019-06-22  Tom Tromey  <tom@tromey.com>
1433
1434         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
1435         declare.
1436         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
1437
1438 2019-06-22  Tom de Vries  <tdevries@suse.de>
1439
1440         * dwarf2read.c (create_addrmap_from_aranges)
1441         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
1442         instead of '%zu'.
1443
1444 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
1445
1446         * dwarf2read.h (dwarf2_section_info_def): Remove.
1447         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
1448         * dwarf2read.c (struct dwo_sections) <types>: Change type to
1449         std::vector<dwarf2_section_info>.
1450         (struct dwo_file) <~dwo_file>: Remove.
1451         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
1452         types field.
1453         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
1454         (dwarf2_read_debug_names): Likewise.
1455         (create_debug_types_hash_table): Change parameter type to
1456         array_view, adjust code accordingly.
1457         (dwarf2_locate_dwo_sections): Adjust to std::vector.
1458         (partial_die_info::fixup): Likewise.
1459         (determine_prefix): Likewise.
1460         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
1461
1462 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1463
1464         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
1465         gdb_bfd_ref_ptr.
1466         <~dwo_file>: Remove call to gdb_bfd_unref.
1467         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
1468         gdb_bfd_ref_ptr::get.
1469
1470 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1471
1472         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
1473         type to htab_up.
1474         * dwarf2read.c (struct dwo_file): Initialize fields.
1475         <~dwo_file>: New.
1476         (free_dwo_file): Remove, move content to ~dwo_file.
1477         (struct dwo_file_deleter): Remove.
1478         (dwo_file_up>: Remove custom deleter.
1479         (free_dwo_files): Remove.
1480         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
1481         dwo_files.
1482         (process_skeletonless_type_units): Call unique_ptr::get.
1483         (allocate_dwo_file_hash_table): Add deleter to created hash
1484         table.  Change return type to htab_up.
1485         (lookup_dwo_file_slot): Don't memset dwo_file, call
1486         unique_ptr::get.
1487         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
1488         (create_dwo_unit_in_dwp_v2): Likewise.
1489         (open_and_init_dwo_file): Likewise.
1490         (free_dwo_file_from_slot): Remove.
1491
1492 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1493
1494         * dwarf2read.h (struct dwarf2_section_info) <readin,
1495         is_virtual>: Change type to bool.
1496         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
1497         true instead of 1.
1498
1499 2019-06-19  Tom Tromey  <tom@tromey.com>
1500
1501         * tui/tui-data.h (tui_init_content_element): Don't declare.
1502
1503 2019-06-19  Tom Tromey  <tom@tromey.com>
1504
1505         * tui/tui-data.h (tui_init_win_info): Don't declare.
1506
1507 2019-06-19  Tom de Vries  <tdevries@suse.de>
1508
1509         * dwarf2read.h (abstract_to_concrete): Change type to
1510         std::unordered_map<sect_offset, std::vector<sect_offset>,
1511         gdb::hash_enum<sect_offset>>.
1512
1513 2019-06-19  Tom Tromey  <tromey@adacore.com>
1514
1515         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
1516         EVAL_AVOID_SIDE_EFFECTS specially.
1517
1518 2019-06-19  Tom Tromey  <tromey@adacore.com>
1519
1520         * source-cache.c (highlighter): New global.
1521         (source_cache::get_source_lines): Create a highlighter on demand.
1522
1523 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1524
1525         * defs.h (deprecated_interactive_hook): Delete declaration.
1526         * interps.c (clear_interpreter_hooks): Remove use of
1527         deprecated_interactive_hook.
1528         * top.c (deprecated_interactive_hook): Delete definition.
1529         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
1530
1531 2019-06-18  Tom de Vries  <tdevries@suse.de>
1532
1533         PR gdb/24515
1534         * dwarf2read.h (abstract_to_concrete): Change type from
1535         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
1536         std::unordered_map<sect_offset, std::vector<sect_offset>>.
1537         * dwarf2read.c (read_variable): Update.
1538         (dwarf2_fetch_die_loc_sect_off): Update.
1539
1540 2019-06-17  Tom de Vries  <tdevries@suse.de>
1541
1542         PR gdb/24617
1543         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
1544         accessing parent[parent_len - 1].
1545
1546 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
1547
1548         PR gdb/24364
1549         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
1550         call dtrace_process_dof with NULL dof.
1551
1552 2019-06-16  Tom de Vries  <tdevries@suse.de>
1553
1554         PR gdb/24445
1555         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
1556
1557 2019-06-16  Tom Tromey  <tom@tromey.com>
1558
1559         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1560         (make_all_visible): Use address of member.
1561
1562 2019-06-16  Tom Tromey  <tom@tromey.com>
1563
1564         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
1565         (tui_free_window, free_content, free_content_elements): Remove
1566         unnecessary cast.
1567         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
1568         cast.
1569         * tui/tui-regs.c (tui_show_register_group)
1570         (tui_display_registers_from, tui_display_reg_element_at_line):
1571         Remove unnecessary cast.
1572
1573 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
1574
1575         * linux-nat.c (normal_mask): Delete.
1576         (_initialize_linux_nat): Don't initialise normal_mask.
1577
1578 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
1579
1580         PR gdb/24445
1581         * dwarf-index-write.h (write_psymtabs_to_index): Add
1582         dwz_basename parameter.
1583         * dwarf-index-write.c (write_gdbindex): Move file writing to
1584         write_gdbindex_1.  Change return type void.
1585         (assert_file_size): Move up, remove filename parameter.
1586         (write_gdbindex_1): New function.
1587         (write_debug_names): Change return type to void, call
1588         assert_file_size.
1589         (struct index_wip_file): New struct.
1590         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
1591         file logic to index_wip_file.  Write index for dwz file if
1592         needed.
1593         (save_gdb_index_command): Pass basename of dwz file, if present.
1594         * dwarf-index-cache.c (index_cache::store): Obtain and pass
1595         build-id of dwz file, if present.
1596         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
1597         (dwarf2_get_dwz_file): Likewise.
1598         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
1599         (dwarf2_get_dwz_file): Likewise.
1600
1601 2019-06-16  Tom Tromey  <tom@tromey.com>
1602
1603         * coffread.c (process_coff_symbol): Use xstrdup.
1604         * value.c (create_internalvar): Use xstrdup.
1605
1606 2019-06-16  Tom Tromey  <tom@tromey.com>
1607
1608         * valops.c (value_cast, value_slice): Remove unnecessary cast.
1609         * breakpoint.c (stopin_command, stopat_command)
1610         (until_break_command, decode_location_default): Remove unnecessary
1611         cast.
1612         * utils.c (subset_compare): Remove unnecessary cast.
1613         * ada-lang.c (ada_update_initial_language): Remove unnecessary
1614         cast.
1615         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
1616         cast.
1617         * infcmd.c (path_command): Remove unnecessary cast.
1618         * coffread.c (decode_type): Remove unnecessary cast.
1619         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
1620         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
1621         * tui/tui-stack.c (tui_show_locator_content)
1622         (tui_show_frame_info): Remove unnecessary cast.
1623         * tui/tui-win.c (tui_scroll_forward_command)
1624         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
1625         (parse_scrolling_args): Remove unnecessary cast.
1626         * tui/tui-data.c (init_win_info, tui_del_window)
1627         (tui_free_window, tui_del_data_windows, tui_free_data_content)
1628         (free_content_elements): Remove unnecessary cast.
1629         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
1630         unnecessary cast.
1631         * tui/tui-source.c (tui_set_source_content)
1632         (tui_vertical_source_scroll): Remove unnecessary cast.
1633         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
1634         cast.
1635         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
1636         * tui/tui-regs.c (tui_display_registers_from)
1637         (tui_display_register): Remove unnecessary cast.
1638         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
1639         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
1640         (make_visible): Remove unnecessary cast.
1641         * tui/tui-winsource.c (tui_erase_source_content)
1642         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
1643         unnecessary cast.
1644         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
1645         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
1646         * stabsread.c (read_type, read_array_type, read_range_type):
1647         Remove unnecessary cast.
1648         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
1649         (parse_symbol, parse_type, upgrade_type, parse_external)
1650         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
1651         unnecessary cast.
1652         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
1653
1654 2019-06-16  Tom Tromey  <tom@tromey.com>
1655
1656         * tui/tui-data.c (tui_alloc_generic_win_info)
1657         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
1658         checks.
1659
1660 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
1661             Andrew Burgess  <andrew.burgess@embecosm.com>
1662
1663         * f-typeprint.c (f_print_type): Don't return early for not
1664         associated or not allocated types.
1665         (f_type_print_varspec_suffix): Add print_rank parameter and print
1666         ranks of array types in case they dangling.
1667         (f_type_print_base): Add print_rank parameter.
1668
1669 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1670
1671         * NEWS: Mention new MI commands.
1672         * break-catch-throw.c (enum exception_event_kind): Move to
1673         breakpoint.h.
1674         (print_mention_exception_catchpoint): Output text as a single
1675         message.
1676         (catch_exception_command_1): Rename to...
1677         (catch_exception_event): ...this, make non-static, update header
1678         command, and change some parameter types.
1679         (catch_catch_command): Update for changes to
1680         catch_exception_command_1.
1681         (catch_throw_command): Likewise.
1682         (catch_rethrow_command): Likewise.
1683         * breakpoint.c (enum exception_event_kind): Delete.
1684         * breakpoint.h (enum exception_event_kind): Moved here from
1685         break-catch-throw.c.
1686         (catch_exception_event): Declare.
1687         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
1688         (mi_cmd_catch_throw): New function.
1689         (mi_cmd_catch_rethrow): New function.
1690         (mi_cmd_catch_catch): New function.
1691         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
1692         'catch-catch' entries.
1693         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
1694         (mi_cmd_catch_rethrow): Declare.
1695         (mi_cmd_catch_catch): Declare.
1696
1697 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1698
1699         * annotate.c (annotate_source_line): Change return type to void,
1700         update implementation to match.
1701         * annotate.h (annotate_source_line): Change return type to void,
1702         update header comment.
1703         * stack.c (print_frame_info): Don't change what frame information
1704         is printed based on whether annotations are on or not.
1705
1706 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1707
1708         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
1709         (annotate_source): Make static.
1710         (annotate_source_line): Moved from source.c and renamed from
1711         identify_source_line.  Update the return type.
1712         * annotate.h (annotate_source): Delete declaration.
1713         (annotate_source_line): Declaration moved from source.h, and
1714         renamed from identify_source_line.  Return type updated.
1715         * source.c (identify_source_line): Moved to annotate.c and renamed
1716         to annotate_source_line.
1717         (info_line_command): Remove check of annotation_level.
1718         * source.h (identify_source_line): Move declaration to annotate.h
1719         and rename to annotate_source_line.
1720         * stack.c: Add 'annotate.h' include.
1721         (print_frame_info): Remove check of annotation_level before
1722         calling annotate_source_line.
1723
1724 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1725
1726         * source-cache.c (source_cache::get_plain_source_lines): Use
1727         open_source_file_with_line_charpos instead of just
1728         open_source_file, remove call to find_source_lines.
1729         (source_cache::get_source_lines): Likewise.
1730         * source.c (find_source_lines): Make static.
1731         (get_filename_and_charpos): Renamed into...
1732         (open_source_file_with_line_charpos): ..this along with changes to
1733         return a scoped_fd, and some other minor clean ups.
1734         (identify_source_line): Use open_source_file_with_line_charpos.
1735         (search_command_helper): Use open_source_file_with_line_charpos
1736         instead of just open_source_file, remove call to
1737         find_source_lines.
1738         * source.h (open_source_file_with_line_charpos): Declare new
1739         function.
1740         (find_source_lines): Delete declaration.
1741
1742 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1743
1744         * source.c (get_filename_and_charpos): Remove fullname
1745         parameter.
1746         (identify_source_line): Update call to get_filename_and_charpos.
1747
1748 2019-06-14  Tom Tromey  <tromey@adacore.com>
1749
1750         PR gdb/24502:
1751         * ui-style.h (skip_ansi_escape): Update comment.
1752         * ui-file.h (class no_terminal_escape_file): New class.
1753         * ui-file.c (no_terminal_escape_file::write)
1754         (no_terminal_escape_file::puts): New methods.
1755         * cli/cli-logging.c (handle_redirections): Use
1756         no_terminal_escape_file.
1757
1758 2019-06-14  Tom Tromey  <tromey@adacore.com>
1759
1760         * NEWS: Move convenience variable news above Python news.
1761
1762 2019-06-14  Tom Tromey  <tom@tromey.com>
1763
1764         * gnulib: Move directory to top-level.
1765         * configure.ac: Don't configure gnulib.
1766         * configure: Rebuild.
1767         * common/common-defs.h: Use new path to gnulib.
1768         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
1769         (GNULIB_H): Remove.
1770         (INCGNU): Look in new gnulib location.
1771         (HFILES_NO_SRCDIR): Remove gnulib files.
1772         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
1773         (generated_files): Remove GNULIB_H.
1774         ($(LIBGNU), all-lib): Remove targets.
1775         (distclean): Don't mention GNULIB_BUILDDIR.
1776         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
1777
1778 2019-06-14  Tom Tromey  <tromey@adacore.com>
1779
1780         * symfile.c (add_symbol_file_command): Remove obsolete comment.
1781         Warn if symbol file does not provide any symbols.
1782
1783 2019-06-14  Tom Tromey  <tromey@adacore.com>
1784
1785         * source.c (find_and_open_source): Respect basenames_may_differ.
1786
1787 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
1788
1789         * annotate.c (annotate_breakpoints_invalid): Make use of
1790         scoped_restore_terminal_state.
1791         (annotate_frames_invalid): Likewise.
1792
1793 2019-06-14  Tom Tromey  <tromey@adacore.com>
1794
1795         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
1796         allow assignment to an internalvar.
1797
1798 2019-06-14  Tom Tromey  <tromey@adacore.com>
1799
1800         * ada-lex.l: Allow "_" in attribute names.
1801
1802 2019-06-14  Tom Tromey  <tromey@adacore.com>
1803
1804         PR gdb/24653:
1805         * regcache.c (registers_changed): Don't call alloca.
1806         * top.c (execute_command): Don't call alloca.
1807
1808 2019-06-13  Pedro Alves  <palves@redhat.com>
1809
1810         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
1811         'expression'.  When parsing an expression, error out if there's
1812         junk after "unlimited".
1813         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1814         (do_set_command): Adjust calls to is_unlimited_literal.
1815
1816 2019-06-13  Pedro Alves  <palves@redhat.com>
1817
1818         * compile/compile.c (make_compile_options_def_group): Add braces
1819         around array_view initializer.
1820         * thread.c (make_thread_apply_all_options_def_group)
1821         (make_thread_apply_all_options_def_group): Likewise.
1822
1823 2019-06-13  Pedro Alves  <palves@redhat.com>
1824
1825         * NEWS (New commands): Mention "maint test-options
1826         require-delimiter", "maint test-options unknown-is-error", "maint
1827         test-options unknown-is-operand" and "maint show
1828         test-options-completion-result".
1829         (New command options, command completion): New section.
1830         (Completion improvements): New section.
1831         Mention that you can abbreviate "unlimited".
1832
1833 2019-06-13  Pedro Alves  <palves@redhat.com>
1834
1835         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
1836         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
1837         * unittests/cli-utils-selftests.c (test_parse_flags)
1838         (test_parse_flags_qcs): Delete.
1839         (test_cli_utils): Don't call deleted functions.
1840
1841 2019-06-13  Pedro Alves  <palves@redhat.com>
1842
1843         * thread.c: Include "cli/cli-option.h".
1844         (tp_array_compar_ascending): Global.
1845         (tp_array_compar): Delete function.
1846         (tp_array_compar_ascending, tp_array_compar_descending): New
1847         functions.
1848         (ascending_option_def, qcs_flag_option_def)
1849         (thr_qcs_flags_option_defs)
1850         (make_thread_apply_all_options_def_group)
1851         (make_thread_apply_options_def_group): New.
1852         (thread_apply_all_command): Use gdb::option::process_options.
1853         (thread_apply_command_completer)
1854         (thread_apply_all_command_completer): New.
1855         (thread_apply_command): Use gdb::option::process_options.
1856         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
1857         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
1858         to generate help text of "thread apply".  Adjust "taas"'s help.
1859         * tid-parse.c (tid_range_parser::in_thread_range): New method.
1860         * tid-parse.h (tid_range_parser::in_thread_range): New method.
1861
1862 2019-06-13  Pedro Alves  <palves@redhat.com>
1863
1864         * thread.c (thread_apply_command): Check for invalid TID with
1865         isdigit instead of !isalpha.
1866
1867 2019-06-13  Pedro Alves  <palves@redhat.com>
1868
1869         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
1870         (validate_flags_qcs): New.
1871         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
1872         (validate_flags_qcs): Declare.
1873         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
1874         (make_frame_apply_options_def_group): New.
1875         (frame_apply_command_count): Process options with
1876         gdb::option::process_options.
1877         (frame_apply_completer): New.
1878         (frame_apply_level_completer, frame_apply_all_completer)
1879         (frame_apply_completer): New.
1880         (_initialize_stack): Update help of "frame apply", "frame apply
1881         level", "frame apply all" and "faas" to mention supported options
1882         and install command completers.
1883         * stack.h (frame_apply_all_completer): Declare.
1884         * thread.c: Include "stack.h".
1885         (tfaas_command): Add "--".
1886         (_initialize_thread): Update help "tfaas" to mention supported
1887         options and install command completer.
1888
1889 2019-06-13  Pedro Alves  <palves@redhat.com>
1890
1891         * completer.c (complete_nested_command_line): New.
1892         (gdb_completion_word_break_characters_throw): Add assertion.
1893         * completer.h (complete_nested_command_line): Declare.
1894
1895 2019-06-13  Pedro Alves  <palves@redhat.com>
1896
1897         * stack.c (parse_backtrace_qualifiers): New.
1898         (backtrace_command): Use it.
1899         (backtrace_command_completer): Complete on qualifiers.
1900
1901 2019-06-13  Pedro Alves  <palves@redhat.com>
1902
1903         * frame.c: Include "cli/cli-option.h.
1904         (user_set_backtrace_options): New.
1905         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
1906         Delete.
1907         (get_prev_frame): Adjust.
1908         (boolean_option_def, uinteger_option_def)
1909         (set_backtrace_option_defs): New.
1910         (_initialize_frame): Adjust and use
1911         gdb::option::add_setshow_cmds_for_options to install "set
1912         backtrace past-main" and "set backtrace past-entry".
1913         * frame.h: Include "cli/cli-option.h".
1914         (struct frame_print_options): Forward declare.
1915         (print_frame_arguments_all, print_frame_arguments_scalars)
1916         (print_frame_arguments_none): Declare.
1917         (print_entry_values): Delete declaration.
1918         (struct frame_print_options, user_frame_print_options): New.
1919         (struct set_backtrace_options): New.
1920         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
1921         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
1922         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
1923         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
1924         (list_args_or_locals): Add frame_print_options parameter.
1925         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1926         * python/py-framefilter.c (enumerate_args): Pass down
1927         USER_FRAME_PRINT_OPTIONS.
1928         * stack.c: Include "cli/cli-option.h".
1929         (print_frame_arguments_all, print_frame_arguments_scalars)
1930         (print_frame_arguments_none): Declare.
1931         (print_raw_frame_arguments, print_entry_values): Delete.
1932         (user_frame_print_options): New.
1933         (boolean_option_def, enum_option_def, frame_print_option_defs):
1934         New.
1935         (struct backtrace_cmd_options): New.
1936         (bt_flag_option_def): New.
1937         (backtrace_command_option_defs): New.
1938         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1939         (print_frame_arg, read_frame_arg, print_frame_args)
1940         (print_frame_info, print_frame): Add frame_print_options parameter
1941         and use it.
1942         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
1943         (backtrace_command_1): Add frame_print_options and
1944         backtrace_cmd_options parameters and use them.
1945         (make_backtrace_options_def_group): New.
1946         (backtrace_command): Process command options with
1947         gdb::option::process_options.
1948         (backtrace_command_completer): New.
1949         (_initialize_stack): Extend "backtrace"'s help to mention
1950         supported options.  Install completer for "backtrace".
1951         Install some settings commands with add_setshow_cmds_for_options.
1952
1953 2019-06-13  Pedro Alves  <palves@redhat.com>
1954
1955         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
1956         and that "set/show print raw frame-arguments" are now deprecated.
1957
1958         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
1959         command.
1960         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
1961         * stack.c (_initialize_stack): Install "set/show print
1962         raw-frame-arguments", and deprecate "set/show print raw
1963         frame-arguments".
1964         * valprint.c (_initialize_valprint): Deprecate "set/show print
1965         raw".
1966
1967 2019-06-13  Pedro Alves  <palves@redhat.com>
1968
1969         * compile/compile.c (struct compile_options): New.
1970         (compile_flag_option_def, compile_command_option_defs)
1971         (make_compile_options_def_group): New.
1972         (compile_file_command): Handle options with
1973         gdb::option::process_options.
1974         (compile_file_command_completer): New function.
1975         (compile_code_command): Handle options with
1976         gdb::option::process_options.
1977         (compile_code_command_completer): New function.
1978         (_initialize_compiler): Install completers for "compile code" and
1979         "compile file".  Mention available options in "compile code" and
1980         "compile code"'s help.
1981         * completer.c (advance_to_completion_word): New, factored out from
1982         ...
1983         (advance_to_expression_complete_word_point): ... this.
1984         (advance_to_filename_complete_word_point): New.
1985         * completer.h (advance_to_filename_complete_word_point): New
1986         declaration.
1987
1988 2019-06-13  Pedro Alves  <palves@redhat.com>
1989
1990         * compile/compile.c: Include "cli/cli-option.h".
1991         (compile_print_value): Scope data pointer is now a
1992         value_print_options pointer; adjust.
1993         (compile_print_command): Process options.  Scope data pointer is
1994         now a value_print_options pointer; adjust.
1995         (_initialize_compile): Update "compile print"'s help to include
1996         supported options.  Install a completer for "compile print".
1997         * cp-valprint.c (show_vtblprint, show_objectprint)
1998         (show_static_field_print): Delete.
1999         (_initialize_cp_valprint): Don't install "set print
2000         static-members", "set print vtbl", "set print object" here.
2001         * printcmd.c: Include "cli/cli-option.h" and
2002         "common/gdb_optional.h".
2003         (print_command_parse_format): Rework to fill in a
2004         value_print_options instead of a format_data.
2005         (print_value): Change parameter type from format_data pointer to
2006         value_print_options reference.  Adjust.
2007         (print_command_1): Process options.  Adjust to pass down a
2008         value_print_options.
2009         (print_command_completer): New.
2010         (_initialize_printcmd): Install print_command_completer as
2011         handle_brkchars completer for the "print" command.  Update
2012         "print"'s help to include supported options.
2013         * valprint.c: Include "cli/cli-option.h".
2014         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2015         here from cp-valprint.c.
2016         (boolean_option_def, uinteger_option_def)
2017         (value_print_option_defs, make_value_print_options_def_group):
2018         New.  Use gdb::option::add_setshow_cmds_for_options to install
2019         "set print elements", "set print null-stop", "set print repeats",
2020         "set print pretty", "set print union", "set print array", "set
2021         print address", "set print symbol", "set print array-indexes".
2022         * valprint.h: Include <string> and "cli/cli-option.h".
2023         (make_value_print_options_def_group): Declare.
2024         (print_value): Change parameter type from format_data pointer to
2025         value_print_options reference.
2026         (print_command_completer): Declare.
2027
2028 2019-06-13  Pedro Alves  <palves@redhat.com>
2029
2030         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2031         (COMMON_SFILES): Add maint-test-settings.c.
2032         * cli/cli-decode.c (boolean_enums): New global, factored out from
2033         ...
2034         (add_setshow_boolean_cmd): ... here.
2035         * cli/cli-decode.h (boolean_enums): Declare.
2036         * cli/cli-option.c: New file.
2037         * cli/cli-option.h: New file.
2038         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2039         factored out from ...
2040         (parse_cli_boolean_value(const char *)): ... this.
2041         (is_unlimited_literal): Change parameter type to pointer to
2042         pointer.  Adjust and advance ARG pointer.
2043         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2044         (parse_cli_var_enum): New, factored out from ...
2045         (do_set_command): ... this.  Adjust.
2046         * cli/cli-setshow.h (parse_cli_boolean_value)
2047         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2048         (parse_cli_var_enum): Declare.
2049         * cli/cli-utils.c: Include "cli/cli-option.h".
2050         (get_ulongest): New.
2051         * cli/cli-utils.h (get_ulongest): Declare.
2052         (check_for_argument): New overloads.
2053         * maint-test-options.c: New file.
2054
2055 2019-06-13  Pedro Alves  <palves@redhat.com>
2056
2057         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2058         parse a range if "-" is at the end of the string.
2059
2060 2019-06-13  Pedro Alves  <palves@redhat.com>
2061
2062         * cli/cli-setshow.c (parse_auto_binary_operation)
2063         (parse_cli_boolean_value): Don't allow "o".
2064
2065 2019-06-13  Pedro Alves  <palves@redhat.com>
2066
2067         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2068         * NEWS: Mention maint test-settings KIND.
2069         * maint-test-settings.c: New file.
2070
2071 2019-06-13  Pedro Alves  <palves@redhat.com>
2072
2073         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2074         completer.
2075         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2076         "set" completers.
2077
2078 2019-06-13  Pedro Alves  <palves@redhat.com>
2079
2080         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2081         after item.
2082
2083 2019-06-13  Pedro Alves  <palves@redhat.com>
2084
2085         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2086
2087 2019-06-13  Pedro Alves <palves@redhat.com>
2088
2089         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2090         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2091         call.
2092         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2093         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2094         calls.
2095         (check_for_argument): Skip spaces after argument.
2096
2097 2019-06-13  Pedro Alves  <palves@redhat.com>
2098
2099         * thread.c (thread_apply_command): Adjust TID parsing.
2100         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2101         detected before end of string.
2102         (tid_is_in_list): Error out if LIST is invalid.
2103
2104 2019-06-13  Pedro Alves  <palves@redhat.com>
2105
2106         * completer.c (complete_line_internal_1): Rewind completion word
2107         point.
2108         (completion_tracker::advance_custom_word_point_by): Change
2109         parameter type to int.
2110         * completer.h (completion_tracker::advance_custom_word_point_by):
2111         Likewise.
2112
2113 2019-06-13  Pedro Alves  <palves@redhat.com>
2114
2115         * completer.c (advance_to_completion_word): Handle delimiters.
2116
2117 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2118
2119         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2120
2121 2019-06-11  Tom Tromey  <tom@tromey.com>
2122
2123         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2124         (xmalloc_failed): Move to alloc.c.
2125         * alloc.c: New file.
2126         * Makefile.in (COMMON_SFILES): Add alloc.c.
2127
2128 2019-06-11  Tom Tromey  <tom@tromey.com>
2129
2130         * nat/linux-waitpid.c: Don't include server.h.
2131         (linux_debug): Remove.
2132         (my_waitpid): Update.
2133
2134 2019-06-11  Tom Tromey  <tromey@adacore.com>
2135
2136         * infcall.c (_initialize_infcall): Remove trailing newline from
2137         help.
2138         * user-regs.c (_initialize_user_regs): Remove trailing newline
2139         from help.
2140         * typeprint.c (_initialize_typeprint): Remove trailing newline
2141         from help.
2142         * reverse.c (_initialize_reverse): Remove trailing newlines from
2143         help.
2144         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2145         from help.
2146         * language.c (add_set_language_command): Remove trailing newline
2147         from help.
2148         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2149         help.
2150         * disasm.c (_initialize_disasm): Remove trailing newline from
2151         help.
2152         * top.c (init_main): Remove trailing newline from help.
2153         * interps.c (_initialize_interpreter): Remove trailing newline
2154         from help.
2155         * btrace.c (_initialize_btrace): Remove trailing newlines from
2156         help.
2157         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
2158         from help.
2159         * python/python.c (_initialize_python): Remove trailing newline
2160         from help.
2161         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
2162         help.
2163         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
2164         from help.  Reformat some text.
2165         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
2166         from help.
2167         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
2168         newline from help.
2169
2170 2019-06-11  Tom Tromey  <tromey@adacore.com>
2171
2172         * darwin-nat.c (darwin_decode_exception_message)
2173         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
2174
2175 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2176
2177         * valops.c (value_slice): Check for not allocated or not
2178         associated values.
2179
2180 2019-06-10  Tom de Vries  <tdevries@suse.de>
2181
2182         PR gdb/24618
2183         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
2184         sure an empty slot (defined by a 32-bit zero pair) is recognized as
2185         invalid.
2186
2187 2019-06-10  Tom de Vries  <tdevries@suse.de>
2188
2189         PR gdb/24611
2190         * linespec.c (linespec_lexer_lex_string): Remove incorrect
2191         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
2192
2193 2019-06-10  Tom de Vries  <tdevries@suse.de>
2194
2195         PR symtab/24545
2196         * symtab.c (struct demangled_name_entry): Add language field.
2197         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
2198         static minimal symbol".  Set and use language field.
2199
2200 2019-06-10  Tom Tromey  <tromey@adacore.com>
2201
2202         * ada-lang.c (_initialize_ada_language): Update help text.
2203
2204 2019-06-10  Tom Tromey  <tromey@adacore.com>
2205
2206         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
2207         with a newline.
2208         * guile/guile.c (handle_boot_error): Don't end warning with a
2209         newline.
2210         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
2211         warning with a newline.
2212         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
2213         newline.
2214         (s12z_frame_cache): Likewise.
2215         * dwarf-index-cache.c (index_cache::store): Don't end warning with
2216         a newline.
2217         * solib-svr4.c (disable_probes_interface): Don't end warning with
2218         a newline.
2219         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2220         newline.
2221         * python/python.c (do_finish_initialization): Don't end warning
2222         with a newline.
2223
2224 2019-06-10  Tom Tromey  <tom@tromey.com>
2225
2226         * python/py-breakpoint.c (gdbpy_breakpoint_created)
2227         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
2228         gdbpy_enter.
2229
2230 2019-06-10  Tom Tromey  <tromey@adacore.com>
2231
2232         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
2233         data.
2234         (elf_new_init): Don't call stabsread_new_init.
2235         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
2236         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
2237         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
2238
2239 2019-06-10  Tom de Vries  <tdevries@suse.de>
2240
2241         PR symtab/16264
2242         PR symtab/24517
2243         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
2244
2245 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
2246
2247         * source.c (find_and_open_source): Also rewrite relative file
2248         names.
2249
2250 2019-04-26  Amos Bird  <amosbird@gmail.com>
2251
2252         * annotate.c (annotate_thread_exited): Add "thread-exited"
2253         annotation.
2254
2255 2019-06-06  Tom Tromey  <tromey@adacore.com>
2256
2257         * maint.h (class scoped_command_stats): Use
2258         DISABLE_COPY_AND_ASSIGN.
2259         <print_time>: New method.
2260         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
2261         print_time.
2262         (scoped_command_stats::print_time): New method.
2263
2264 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2265
2266         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
2267         instructions of lengths 6 or 8 bytes.
2268
2269 2019-06-04  Pedro Alves  <palves@redhat.com>
2270
2271         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
2272
2273         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
2274         * breakpoint.c (condition_completer): Likewise.
2275         * cli/cli-dump.c (scan_expression): Likewise.
2276         * common/filestuff.c (mkdir_recursive): Likewise.
2277         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
2278         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
2279         (gdb_abspath): Likewise.
2280         * compile/compile-cplus-types.c
2281         (compile_cplus_instance::decl_name): Likewise.
2282         * completer.c (complete_explicit_location):
2283         (signal_completer, reg_or_group_completer_1): Likewise.
2284         * cp-support.c (cp_remove_params_if_any): Likewise.
2285         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
2286         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
2287         * infcmd.c (strip_bg_char): Likewise.
2288         * linespec.c (copy_token_string): Likewise.
2289         * mi/mi-main.c (output_cores): Likewise.
2290         * psymtab.c (psymtab_search_name):
2291         * symfile.c (test_set_ext_lang_command): Likewise.
2292         * target.c (target_fileio_read_stralloc): Likewise.
2293         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
2294         * value.c (complete_internalvar): Likewise.
2295
2296 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
2297
2298         Add objfile property to gdb.Type.
2299         * NEWS: Mention Python API addition.
2300         * python/py-type.c (typy_get_objfile): New method.
2301
2302 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2303
2304         * NEWS: Mention the new set|show style [title|highlight].
2305         Mention changes to "show style", "help" and "apropos".
2306
2307 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2308
2309         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
2310         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
2311         instead of print_help_for_command.
2312         (print_doc_of_command): New function.
2313         (help_list): Add 'apropos -v word' suggestion.
2314         (print_help_for_command): Style the command name using title style.
2315         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
2316         (_initialize_cli_cmds): Describe -v in apropos_command help.
2317
2318 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2319
2320         * cli/cli-style.h (cli_style_option): Add name in constructor,
2321         add m_name class member, add constructor with intensity,
2322         add name class function.
2323         (cli_style_option::add_setshow_commands): Remove name argument.
2324         (highlight_style, title_style): New styles.
2325         * cli/cli-style.c (do_show): New function that shows a style
2326         characteristic styling the style name with itself.
2327         (set_style_name): New function.
2328         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
2329         Update all callers according to the changes in cli/cli-style.h.
2330         * utils.h (fputs_highlighted): New function.
2331         * utils.c (fputs_highlighted): Likewise.
2332
2333 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2334
2335         * NEWS: Mention new pipe command and new convenience variables.
2336
2337 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2338
2339         * cli/cli-cmds.c (pipe_command): New function.
2340         (_initialize_cli_cmds): Call add_com for pipe_command.
2341         Define | as an alias for pipe.
2342         (exit_status_set_internal_vars): New function.
2343         (shell_escape): Call exit_status_set_internal_vars.
2344         cli/cli-decode.c (find_command_name_length): Recognize | as
2345         a single character command.
2346
2347 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2348
2349         * gdbcmd.h (execute_command_to_ui_file): New declaration.
2350         top.c (execute_command_to_ui_file): New function, mostly a copy
2351         of execute_command_to_string.
2352         (execute_command_to_string): Implement by calling
2353         execute_command_to_ui_file.
2354
2355 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2356
2357         * top.h (saved_command_line): Remove declaration.
2358         * top.c (previous_saved_command_line, previous_repeat_arguments):
2359         New variables.
2360         (saved_command_line): Make static, define together with other
2361         'repeat variables'.
2362         (dont_repeat): Clear repeat_arguments.
2363         (repeat_previous, get_saved_command_line, save_command_line):
2364         New functions.
2365         (gdb_init): Initialize saved_command_line
2366         and previous_saved_command_line.
2367         * main.c (captured_main_1): Remove saved_command_line initialization.
2368         * event-top.c (handle_line_of_input): Update to use
2369         the new 'repeat' related functions instead of direct access to
2370         saved_command_line.
2371         * command.h (repeat_previous, get_saved_command_line,
2372         save_command_line): New declarations.
2373         (dont_repeat): Add comment.
2374
2375 2019-05-30  Tom Tromey  <tromey@adacore.com>
2376
2377         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
2378         Fix comment.
2379         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
2380
2381 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
2382
2383         PR cli/24587
2384         * completer.c (complete): Initialize variable word.
2385
2386 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
2387
2388         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2389         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
2390         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
2391         'body' is NULL to the outter 'if', protecting the '!is_define'
2392         situation as well.
2393
2394 2019-05-29  Tom Tromey  <tromey@adacore.com>
2395
2396         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
2397         (dwarf_unknown): New function.
2398         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
2399         (dwarf_type_encoding_name): Use dwarf_unknown.
2400
2401 2019-05-29  Tom Tromey  <tromey@adacore.com>
2402
2403         PR c++/20020:
2404         * cp-valprint.c (cp_print_value_fields): Call
2405         cp_print_static_field inside "try".
2406
2407 2019-05-29  Tom Tromey  <tromey@adacore.com>
2408
2409         * inflow.c (struct terminal_info): Add default operator=.
2410         * configure: Rebuild.
2411         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
2412         -Wdeprecated-copy-dtor, -Wredundant-move.
2413
2414 2019-05-29  Tom Tromey  <tromey@adacore.com>
2415
2416         * NEWS: Add entry.
2417         * infcmd.c (print_return_value_1): Handle finish_print
2418         option.
2419         (show_print_finish): New function.
2420         (_initialize_infcmd): Add "set/show print finish" commands.
2421         * valprint.c (user_print_options): Initialize new member.
2422         * valprint.h (struct value_print_options) <finish_print>: New
2423         member.
2424
2425 2019-05-28  Tom Tromey  <tromey@adacore.com>
2426
2427         * ada-lang.c (ada_remove_Xbn_suffix)
2428         (find_old_style_renaming_symbol)
2429         (parse_old_style_renaming): Remove.
2430         (ada_find_renaming_symbol): Don't call
2431         find_old_style_renaming_symbol.
2432         (ada_is_renaming_symbol): Rename from
2433         ada_find_renaming_symbol.  Remove "block" parameter.  Return
2434         bool.  Now static.
2435         (ada_read_var_value): Update and simplify.
2436         * ada-exp.y (write_var_or_type): Remove old code.
2437
2438 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
2439
2440         * event-top.c: Remove include comment.
2441         * inflow.c (class scoped_ignore_sigttou): Move from here...
2442         * inflow.h (class scoped_ignore_sigttou): ...to here.
2443         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
2444         * top.c:  Remove include comment.
2445
2446 2019-05-27  Tom Tromey  <tom@tromey.com>
2447
2448         * NEWS: Fix typo.
2449
2450 2019-05-22  Tom Tromey  <tromey@adacore.com>
2451
2452         * target.c (target_follow_exec): Constify parameter.
2453         * target-delegates.c: Rebuild.
2454         * remote.c (remote_target::follow_exec): Constify parameter.
2455         * infrun.c (follow_exec): Constify parameter.
2456         * target.h (struct target_ops) <follow_exec>: Constify parameter.
2457         (target_follow_exec): Likewise.
2458
2459 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2460
2461         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
2462         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
2463
2464 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2465
2466         * NEWS: Add debugredirect and testsuite sections.
2467
2468 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
2469
2470         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
2471         target descriptions using exclusively floating point register name
2472         aliases.
2473
2474 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2475
2476         PR gdb/18644:
2477         * f-lang.c (build_fortran_types): Handle the case where
2478         gdbarch_floatformat_for_type returns a nullptr.
2479
2480 2019-05-21  Tom de Vries  <tdevries@suse.de>
2481
2482         PR cli/24587
2483         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
2484
2485 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2486
2487         PR gdb/18644:
2488         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
2489         16-byte floats.
2490         * i386-tdep.c (i386_floatformat_for_type): Use
2491         floatformats_ia64_quad for the 16-byte floating point component
2492         within a fortran 32-byte complex number.
2493
2494 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2495
2496         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
2497         delete default constructor.
2498         (find_partial_die): Update to return const struct.
2499         (partial_die_parent_scope): Move variable declaration into scope
2500         of its use and change its type to auto.
2501         (guess_partial_die_structure_name): Likewise.
2502         (partial_die_info::fixup): Likewise.
2503
2504 2019-05-17  Tom Tromey  <tromey@adacore.com>
2505
2506         * source.c (find_and_open_source): Remove cast.
2507
2508 2019-05-17  Tom Tromey  <tromey@adacore.com>
2509
2510         * annotate.c (annotate_source): Make "filename" const.
2511         * annotate.h (annotate_source): Use const.
2512
2513 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2514
2515         * disasm.c (set_disassembler_options): Send errors to stderr.
2516
2517 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2518
2519         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
2520         (cli_interp_base::set_logging): Check debug_redirect.
2521         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
2522         * cli/cli-logging.c (debug_redirect): Add static variable.
2523         (pop_output_files): Add default param.
2524         (handle_redirections): Print debug setting.
2525         (show_logging_command): Likewise.
2526         (_initialize_cli_logging): Add debugredirect command.
2527         * interps.c (current_interp_set_logging): Add debug_redirect
2528         parameter.
2529         * interps.h (set_logging): Add debug_redirect parameter.
2530         (current_interp_set_logging): Likewise.
2531         * mi/mi-common.h: Likewise.
2532         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
2533
2534 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2535             Tom Tromey  <tromey@adacore.com>
2536
2537         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
2538         directly.
2539         * cli/cli-interp.h (make_logging_output): Remove declaration.
2540         * cli/cli-logging.c (make_logging_output): Remove function.
2541         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
2542         directly.
2543         * ui-file.c (tee_file::tee_file): Remove bools.
2544         (tee_file::~tee_file): Remove deletes.
2545         * ui-file.h (tee_file): Remove bools.
2546
2547 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
2548
2549         * mi/mi-cmds.h (mi_cmd_complete): New function.
2550         * mi/mi-main.c (mi_cmd_complete): Likewise.
2551         * mi/mi-cmds.c: Define new MI command -complete.
2552         * NEWS: Mention new -complete command.
2553
2554 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
2555
2556         * completer.h (complete): New function.
2557         * completer.c (complete): Likewise.
2558         * cli/cli-cmds.c: (complete_command): Update to use new complete()
2559         function defined in completer.h.
2560
2561 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
2562
2563         * MAINTAINERS (Write After Approval): Add myself.
2564
2565 2019-05-17  Tom de Vries  <tdevries@suse.de>
2566
2567         PR gdb/24094
2568         * dwarf2read.c (struct cu_partial_die_info): New struct.
2569         (find_partial_die): Return cu_partial_die_info.
2570         (partial_die_parent_scope, guess_partial_die_structure_name)
2571         (partial_die_info::fixup): Handle new return type of find_partial_die.
2572
2573 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2574
2575         * stap-probe.c (stap_parse_register_operand): Make "regname" an
2576         "std::string", simplifying the algorithm.
2577
2578 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2579
2580         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
2581         (stap_static_probe_ops::get_probes): Likewise.
2582
2583 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2584
2585         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
2586         '-')" and "else if".
2587         (stap_parse_single_operand): Join checks for
2588         "gdbarch_stap_parse_special_token_p" and
2589         "gdbarch_stap_parse_special_token" in the same "if" statement.
2590         Invert check when verifying for operation on register
2591         displacement.
2592
2593 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2594
2595         * stap-probe.c (stap_get_opcode): Update comment.
2596         (stap_get_expected_argument_type): Likewise.
2597         (handle_stap_probe): Likewise.
2598
2599 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2600
2601         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
2602         return type to 'bool'.  Adjust comment.  Use 'bool' when
2603         appropriate.
2604         (i386_stap_parse_special_token_three_arg_disp): Likewise.
2605         * stap-probe.c (stap_parse_argument_1): Likewise.
2606         (stap_is_operator): Likewise.
2607         (stap_is_generic_prefix): Likewise.
2608         (stap_is_register_prefix): Likewise.
2609         (stap_is_register_indirection_prefix): Likewise.
2610         (stap_is_integer_prefix): Likewise.
2611         (stap_generic_check_suffix): Likewise.
2612         (stap_check_integer_suffix): Likewise.
2613         (stap_check_register_suffix): Likewise.
2614         (stap_check_register_indirection_suffix): Likewise.
2615         (stap_parse_register_operand): Likewise.
2616         (stap_parse_single_operand): Likewise.
2617         (stap_parse_argument_1): Likewise.
2618         (stap_probe::get_argument_count): Likewise.
2619         (stap_is_operator): Likewise.
2620
2621 2019-05-16  Tom Tromey  <tromey@adacore.com>
2622
2623         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
2624         keyword to foreach.
2625
2626 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
2627
2628         * linux-thread-db.c (try_thread_db_load_1): Change return type
2629         to bool.
2630         (try_thread_db_load): Likewise.
2631         (try_thread_db_load_from_pdir_1): Likewise.
2632         (try_thread_db_load_from_pdir): Likewise.
2633         (try_thread_db_load_from_sdir): Likewise.
2634         (try_thread_db_load_from_dir): Likewise.
2635         (thread_db_load_search): Likewise.
2636         (has_libpthread): Likewise.
2637         (thread_db_load): Likewise.
2638
2639 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
2640
2641         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2642         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
2643         NULL, and complain/return if that's the case.
2644
2645 2019-05-15  John Darrington <john@darrington.wattle.id.au>
2646
2647         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
2648         (advance, posn, abstract_read_memory): New functions.
2649         [struct mem_read_abstraction]: New struct.
2650         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
2651
2652 2019-05-14  Tom Tromey  <tromey@adacore.com>
2653
2654         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
2655         value is not lval_memory.
2656
2657 2019-05-14  Tom Tromey  <tromey@adacore.com>
2658
2659         * solib.c (info_sharedlibrary_command): Style the file name.
2660
2661 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
2662
2663         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
2664         (aarch64_vnv_type): Likewise.
2665         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
2666         * common/tdesc.c: Likewise.
2667         * common/tdesc.h (enum tdesc_type_kind): Likewise.
2668         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
2669         * features/aarch64-fpu.xml: Add ieee half view.
2670         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
2671         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
2672         * gdbtypes.h (struct builtin_type): Likewise.
2673         (struct objfile_type): Likewise.
2674
2675 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
2676
2677         * language.c (language_sniff_from_mangled_name): Fix "langauge"
2678         typo.
2679         * location.h (string_to_event_location): Likewise.
2680
2681 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
2682
2683         GDB 8.3 released.
2684
2685 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2686
2687         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
2688         New variable declaration.
2689         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
2690         New variable.
2691         (print_one_breakpoint): Use ui_out::test_flags and new global
2692         variable to compute use_fixed_output.
2693         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
2694         Remove.
2695         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
2696         (mi_multi_location_breakpoint_output_fixed): Remove.
2697         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
2698         new variable.
2699         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
2700         fix_multi_location_breakpoint_output flag if version >= 3.
2701         * ui-out.h (enum ui_out_flag)
2702         <fix_multi_location_breakpoint_output>: New enumerator.
2703
2704 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2705
2706         * contrib/cc-with-tweaks.sh: Validate dwz's work.
2707
2708 2019-05-10  Tom Tromey  <tromey@adacore.com>
2709
2710         * ada-lang.c (catch_ada_completer): New function.
2711         (_initialize_ada_language): Use it.
2712
2713 2019-05-10  Tom Tromey  <tromey@adacore.com>
2714
2715         * thread.c (print_thread_info): Make "requested_threads" const.
2716         * gdbthread.h (print_thread_info): Make "requested_threads"
2717         const.
2718         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
2719         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
2720
2721 2019-05-08  Tom Tromey  <tom@tromey.com>
2722
2723         * gdbtypes.c (objfile_type_data): Change type.
2724         (objfile_type, _initialize_gdbtypes): Update.
2725
2726 2019-05-08  Tom Tromey  <tom@tromey.com>
2727
2728         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
2729         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
2730         (_initialize_dwarf2_frame): Update.
2731
2732 2019-05-08  Tom Tromey  <tom@tromey.com>
2733
2734         * objc-lang.c (objc_objfile_data): Change type.
2735         (find_methods): Update.
2736         (_initialize_objc_lang): Remove.
2737
2738 2019-05-08  Tom Tromey  <tom@tromey.com>
2739
2740         * stabsread.c (rs6000_builtin_type_data): Change type.
2741         (rs6000_builtin_type, _initialize_stabsread): Update.
2742
2743 2019-05-08  Tom Tromey  <tom@tromey.com>
2744
2745         * mips-tdep.c (mips_pdr_data): Remove.
2746         (_initialize_mips_tdep): Update.
2747
2748 2019-05-08  Tom Tromey  <tom@tromey.com>
2749
2750         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
2751         (hppa_init_objfile_priv_data, read_unwind_info)
2752         (find_unwind_entry, _initialize_hppa_tdep): Update.
2753
2754 2019-05-08  Tom Tromey  <tom@tromey.com>
2755
2756         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
2757         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
2758         on obstack.
2759         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
2760
2761 2019-05-08  Tom Tromey  <tom@tromey.com>
2762
2763         * mdebugread.c (basic_type_data): Change type.
2764         (basic_type, _initialize_mdebugread): Update.
2765
2766 2019-05-08  Tom Tromey  <tom@tromey.com>
2767
2768         * common/gdb_unique_ptr.h (struct noop_deleter): New.
2769
2770 2019-05-08  Tom Tromey  <tom@tromey.com>
2771
2772         * nto-tdep.c (nto_inferior_data_reg): Change type.
2773         (nto_inferior_data): Update.
2774         (nto_inferior_data_cleanup, nto_new_inferior_data)
2775         (_initialize_nto_tdep): Remove.
2776         * nto-tdep.h (struct nto_inferior_data): Add initializers.
2777
2778 2019-05-08  Tom Tromey  <tom@tromey.com>
2779
2780         * ada-lang.c (struct ada_inferior_data): Add initializers.
2781         (ada_inferior_data): Change type.
2782         (ada_inferior_data_cleanup): Remove.
2783         (get_ada_inferior_data, ada_inferior_exit)
2784         (struct ada_pspace_data): Add initializers, destructor.
2785         (ada_pspace_data_handle): Change type.
2786         (get_ada_pspace_data): Update.
2787         (ada_pspace_data_cleanup): Remove.
2788
2789 2019-05-08  Tom Tromey  <tom@tromey.com>
2790
2791         * coffread.c (struct coff_symfile_info): Add initializers.
2792         (coff_objfile_data_key): Move lower.  Change type.
2793         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
2794         Update.
2795         (coff_free_info): Remove.
2796
2797 2019-05-08  Tom Tromey  <tom@tromey.com>
2798
2799         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
2800         (fbsd_pspace_data_handle): Move lower.  Change type.
2801         (get_fbsd_pspace_data): Update.
2802         (fbsd_pspace_data_cleanup): Remove.
2803         (_initialize_fbsd_tdep): Update.
2804
2805 2019-05-08  Tom Tromey  <tom@tromey.com>
2806
2807         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
2808         (get_ada_tasks_pspace_data): Update.
2809         (ada_tasks_pspace_data_cleanup): Remove.
2810         (_initialize_tasks): Update.
2811         (ada_tasks_inferior_data_handle): Change type.
2812         (get_ada_tasks_inferior_data): Update.
2813         (ada_tasks_inferior_data_cleanup): Remove.
2814         (struct ada_tasks_pspace_data): Add initializers.
2815
2816 2019-05-08  Tom Tromey  <tom@tromey.com>
2817
2818         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
2819         * symfile-debug.c (debug_sym_get_probes): Change type.
2820         * stap-probe.c (handle_stap_probe):
2821         (stap_static_probe_ops::get_probes): Change type.
2822         * probe.h (class static_probe_ops) <get_probes>: Change type.
2823         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
2824         (parse_probes_in_pspace): Update.
2825         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
2826         Update.
2827         (any_static_probe_ops::get_probes): Change type.
2828         * elfread.c (elfread_data): New typedef.
2829         (probe_key): Change type.
2830         (elf_get_probes): Likewise.  Update.
2831         (probe_key_free): Remove.
2832         (_initialize_elfread): Update.
2833         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
2834         Change type.
2835         (dtrace_process_dof_probe, dtrace_process_dof)
2836         (dtrace_static_probe_ops::get_probe): Change type.
2837
2838 2019-05-08  Tom Tromey  <tom@tromey.com>
2839
2840         * xcoffread.c (struct xcoff_symfile_info): Rename from
2841         coff_symfile_info.  Add initializers.
2842         (xcoff_objfile_data_key): Move lower.  Change type.
2843         (XCOFF_DATA): Rewrite.
2844         (xcoff_free_info): Remove.
2845         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
2846         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
2847         (xcoff_initial_scan): Update.
2848
2849 2019-05-08  Tom Tromey  <tom@tromey.com>
2850
2851         * solib-svr4.c (struct svr4_info): Add initializers and
2852         destructor.
2853         <probes_table>: Now an htab_up.
2854         (solib_svr4_pspace_data): Change type.
2855         (free_probes_table): Simplify.
2856         (~svr4_info): Rename from svr4_pspace_data_cleanup.
2857         (get_svr4_info, probes_table_htab_remove_objfile_probes)
2858         (probes_table_remove_objfile_probes, register_solib_event_probe)
2859         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
2860         (_initialize_svr4_solib): Update.
2861
2862 2019-05-08  Tom Tromey  <tom@tromey.com>
2863
2864         * remote.c (remote_pspace_data): Change type.
2865         (remote_pspace_data_cleanup): Remove.
2866         (get_remote_exec_file, set_pspace_remote_exec_file)
2867         (_initialize_remote): Update.
2868
2869 2019-05-08  Tom Tromey  <tom@tromey.com>
2870
2871         * breakpoint.c (breakpoint_objfile_key): Change type.
2872         (get_breakpoint_objfile_data): Update.
2873         (free_breakpoint_objfile_data): Remove.
2874         (_initialize_breakpoint): Update.
2875
2876 2019-05-08  Tom Tromey  <tom@tromey.com>
2877
2878         * linux-tdep.c (struct linux_info): Add initializers.
2879         (linux_inferior_data): Move.  Change type.
2880         (invalidate_linux_cache_inf): Update.
2881         (linux_inferior_data_cleanup): Remove.
2882         (get_linux_inferior_data, _initialize_linux_tdep): Update.
2883
2884 2019-05-08  Tom Tromey  <tom@tromey.com>
2885
2886         * auxv.c (auxv_inferior_data): Move.  Change type.
2887         (auxv_inferior_data_cleanup): Remove.
2888         (invalidate_auxv_cache_inf): Rewrite.
2889         (get_auxv_inferior_data, _initialize_auxv): Update.
2890
2891 2019-05-08  Tom Tromey  <tom@tromey.com>
2892
2893         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
2894         (symfile_debug_objfile_data_key): Change type.
2895         (symfile_debug_installed, debug_qf_has_symbols)
2896         (debug_qf_find_last_source_symtab)
2897         (debug_qf_forget_cached_source_info)
2898         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
2899         (debug_qf_print_stats, debug_qf_dump)
2900         (debug_qf_expand_symtabs_for_function)
2901         (debug_qf_expand_all_symtabs)
2902         (debug_qf_expand_symtabs_with_fullname)
2903         (debug_qf_map_matching_symbols)
2904         (debug_qf_expand_symtabs_matching)
2905         (debug_qf_find_pc_sect_compunit_symtab)
2906         (debug_qf_map_symbol_filenames)
2907         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
2908         (debug_sym_new_init, debug_sym_init, debug_sym_read)
2909         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
2910         (debug_sym_read_linetable, debug_sym_relocate): Update.
2911         (symfile_debug_free_objfile): Remove.
2912         (install_symfile_debug_logging, _initialize_symfile_debug):
2913         Update.
2914
2915 2019-05-08  Tom Tromey  <tom@tromey.com>
2916
2917         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
2918         allocate_on_obstack.
2919         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
2920         (get_dwarf2_per_objfile): Update.
2921         (set_dwarf2_per_objfile): Remove.
2922         (dwarf2_has_info, dwarf2_get_section_info): Update.
2923         (dwarf2_free_objfile): Remove.
2924         (_initialize_dwarf2_read): Update.
2925
2926 2019-05-08  Tom Tromey  <tom@tromey.com>
2927
2928         * auto-load.c (struct auto_load_pspace_info): Add destructor and
2929         initializers.
2930         <unsupported_script_warning_printed,
2931         script_not_found_warning_printed>: Now bool.
2932         (auto_load_pspace_data): Change type.
2933         (~auto_load_pspace_info): Rename from
2934         auto_load_pspace_data_cleanup.
2935         (get_auto_load_pspace_data, init_loaded_scripts_info)
2936         (clear_section_scripts, maybe_print_unsupported_script_warning)
2937         (maybe_print_script_not_found_warning, _initialize_auto_load):
2938         Update.
2939
2940 2019-05-08  Tom Tromey  <tom@tromey.com>
2941
2942         * objfiles.c (objfile_pspace_info): Add destructor and
2943         initializers.
2944         (objfiles_pspace_data): Change type.
2945         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
2946         (get_objfile_pspace_data): Update.
2947         (objfiles_bfd_data): Change type.
2948         (get_objfile_bfd_data): Update.
2949         (objfile_bfd_data_free, _initialize_objfiles): Remove.
2950
2951 2019-05-08  Tom Tromey  <tom@tromey.com>
2952
2953         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
2954         Change type.
2955         (get_catch_syscall_inferior_data): Update.
2956         (catch_syscall_inferior_data_cleanup): Remove.
2957         (_initialize_break_catch_syscall): Update.
2958
2959 2019-05-08  Tom Tromey  <tom@tromey.com>
2960
2961         * inflow.c (struct terminal_info): Add destructor and
2962         initializers.
2963         (inflow_inferior_data): Change type.
2964         (~terminal_info): Rename from inflow_inferior_data_cleanup.
2965         (get_inflow_inferior_data, inflow_inferior_exit)
2966         (swap_terminal_info, _initialize_inflow): Update.
2967
2968 2019-05-08  Tom Tromey  <tom@tromey.com>
2969
2970         * target-dcache.c (target_dcache_cleanup): Remove.
2971         (target_dcache_aspace_key): Change type.
2972         (target_dcache_init_p, target_dcache_invalidate)
2973         (target_dcache_get, target_dcache_get_or_init)
2974         (_initialize_target_dcache): Update.
2975         * dcache.h (struct dcache_deleter): New.
2976
2977 2019-05-08  Tom Tromey  <tom@tromey.com>
2978
2979         * symtab.c (struct symbol_cache): Add destructor and
2980         initializers.
2981         (symbol_cache_key): Move.  Change type.
2982         (make_symbol_cache, free_symbol_cache): Remove.
2983         (get_symbol_cache): Update.
2984         (symbol_cache_cleanup): Remove.
2985         (ALL_PSPACES, symbol_cache_flush)
2986         (maintenance_print_symbol_cache)
2987         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
2988         Update.
2989
2990 2019-05-08  Tom Tromey  <tom@tromey.com>
2991
2992         * symtab.c (struct main_info): Add destructor and initializers.
2993         (main_progspace_key): Move.  Change type.
2994         (get_main_info): Update.
2995         (main_info_cleanup): Remove.
2996         (_initialize_symtab): Update.
2997
2998 2019-05-08  Tom Tromey  <tom@tromey.com>
2999
3000         * registry.h (DECLARE_REGISTRY): Define the _key class.
3001
3002 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3003
3004         * NEWS: Merge two 'New commands' sections.
3005
3006 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3007
3008         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3009         parameter and use Ada language definition instead.
3010         (ada_val_print_ptr): Remove unused language parameter.
3011         (ada_val_print_num): Remove language parameter and use Ada language
3012         definition instead.
3013         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3014         parameter.
3015         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3016         parameter and use Ada language definition instead.
3017         (ada_val_print_1): Update all ada_val_print_xxx calls.
3018         Remove language parameter.
3019         (ada_val_print): Update ada_val_print_1 call.
3020
3021 2019-05-08  Tom Tromey  <tromey@adacore.com>
3022
3023         * remote.c (remote_hw_watchpoint_limit)
3024         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3025         Now static.
3026
3027 2019-05-08  Tom Tromey  <tromey@adacore.com>
3028
3029         * maint.c (_initialize_maint_cmds): Move initialization code to
3030         remote.c.
3031         (watchdog, show_watchdog): Move to remote.c.
3032         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3033         "watchdog" static.
3034         (_initialize_remote): Move initialization code from maint.c.
3035         * defs.h (watchdog): Don't declare.
3036
3037 2019-05-08  Tom Tromey  <tromey@adacore.com>
3038
3039         * tui/tui-interp.c: Include main.h.
3040         * interps.c: Include main.h.
3041         * main.h (interpreter_p): Declare.
3042         * defs.h (interpreter_p): Don't declare.
3043
3044 2019-05-08  Tom Tromey  <tromey@adacore.com>
3045
3046         * dwarf2loc.c: Include dwarf2read.h.
3047         * defs.h (read_unsigned_leb128): Don't declare.
3048         * dwarf2read.h (read_unsigned_leb128): Declare.
3049
3050 2019-05-08  Tom Tromey  <tromey@adacore.com>
3051
3052         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3053         method.
3054
3055 2019-05-08  Tom Tromey  <tromey@adacore.com>
3056
3057         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3058         when no wrap column is set.
3059
3060 2019-05-08  Tom Tromey  <tromey@adacore.com>
3061
3062         * c-lang.c (c_get_string): Handle non-C-style arrays.
3063
3064 2019-05-08  Tom Tromey  <tromey@adacore.com>
3065
3066         * typeprint.c (print_offset_data::update): Print the bit offset,
3067         not the number of bits remaining.
3068
3069 2019-05-08  Tom Tromey  <tromey@adacore.com>
3070
3071         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3072         padding at end of comment.
3073
3074 2019-05-08  Tom Tromey  <tromey@adacore.com>
3075
3076         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3077         Compare main types.
3078
3079 2019-05-06  Tom Tromey  <tom@tromey.com>
3080
3081         * common/scoped_mmap.c: Include common-defs.h.
3082         * common/scoped_mmap.h: Don't include config.h.
3083
3084 2019-05-04  Tom Tromey  <tom@tromey.com>
3085
3086         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3087         (struct aarch64_call_info): Add initializers.
3088         <si>: Now a std::vector.
3089         (pass_on_stack, aarch64_push_dummy_call): Update.
3090
3091 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3092             Tom Tromey  <tom@tromey.com>
3093
3094         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3095         (ppc_threads): Now a std::vector.  Now static.
3096         (hwdebug_find_thread_points_by_tid)
3097         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3098         Update.
3099
3100 2019-05-04  Tom Tromey  <tom@tromey.com>
3101
3102         * arc-tdep.c (arc_tdesc_init): Return bool.
3103
3104 2019-05-04  Tom Tromey  <tom@tromey.com>
3105
3106         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3107         Use gdb_assert_not_reached.
3108
3109 2019-05-04  Tom Tromey  <tom@tromey.com>
3110
3111         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3112         "false".
3113
3114 2019-05-04  Tom Tromey  <tom@tromey.com>
3115
3116         * arc-tdep.c (arc_tdesc_init): Use bool.
3117
3118 2019-05-04  Tom Tromey  <tom@tromey.com>
3119
3120         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3121
3122 2019-05-04  Tom Tromey  <tom@tromey.com>
3123
3124         * cli/cli-cmds.c (valid_command_p): Return bool.
3125
3126 2019-05-04  Tom Tromey  <tom@tromey.com>
3127
3128         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3129         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3130
3131 2019-05-04  Raul Tambre  <raul@tambre.ee>
3132
3133         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3134         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3135         operator for comparison.
3136
3137 2019-05-04  Tom Tromey  <tom@tromey.com>
3138
3139         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3140         (lookup_partial_symbol, print_partial_symbols)
3141         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3142         (psymbol_compare): Update.
3143         (add_psymbol_to_bcache): Clear the entire psymbol.
3144         (maintenance_check_psymtabs): Update.
3145         * psympriv.h (struct partial_symbol): Don't derive from
3146         general_symbol_info.
3147         <obj_section, unrelocated_address, address,
3148         set_unrelocated_address>: Update.
3149         <ginfo>: New member.
3150         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3151         (debug_names::write_psymbols): Update.
3152
3153 2019-05-04  Tom de Vries  <tdevries@suse.de>
3154
3155         * contrib/cc-with-tweaks.sh: Support -n arg.
3156
3157 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3158
3159         * corelow.c (core_target::detach): Ensure frame cache and
3160         register caches are cleared.
3161         inferior.c (exit_inferior_1): Likewise.
3162
3163 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
3164             Tom Tromey  <tom@tromey.com>
3165
3166         * dictionary.c (collate_pending_symbols_by_language): Remove
3167         "struct" from foreach.
3168         * symtab.c (lookup_global_symbol_from_objfile)
3169         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
3170         foreach.
3171         * ser-tcp.c (net_open): Remove "struct" from foreach.
3172         * objfiles.c (objfile_relocate, objfile_rebase)
3173         (objfile_has_symbols): Remove "struct" from foreach.
3174         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
3175         from foreach.
3176         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
3177         foreach.
3178         * darwin-nat.c (thread_info_from_private_thread_info): Remove
3179         "struct" from foreach.
3180         * ada-lang.c (create_excep_cond_exprs)
3181         (ada_exception_catchpoint_cond_string): Remove "struct" from
3182         foreach.
3183
3184 2019-05-03  Tom Tromey  <tromey@adacore.com>
3185
3186         * ada-exp.y (convert_char_literal): Check suffix of each
3187         enumerator.
3188
3189 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
3190
3191         PR ada/21406:
3192         * ada-exp.y (yywrap): Don't define.
3193         * ada-lex.l (%option): Add noyywrap
3194         (yywrap): Remove.
3195
3196 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
3197
3198         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
3199         _WIN32_WINNT to the XP level, unless already defined to a higher
3200         level.
3201
3202         * unittests/parse-connection-spec-selftests.c:
3203         * ser-tcp.c:
3204         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
3205         override.
3206
3207         * symfile.c (find_separate_debug_file): Remove colon from the
3208         drive spec of DOS/Windows file names of the target, so that the
3209         file name produced from DEBUGDIR and the target's directory will
3210         be valid on DOS/Windows systems.
3211
3212 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3213
3214         * rust-lang.c (val_print_struct): Handle printing structures
3215         containing strings.
3216
3217 2019-05-02  Tom Tromey  <tromey@adacore.com>
3218
3219         * valarith.c (_initialize_valarith): Remove.
3220
3221 2019-05-01  Tom Tromey  <tromey@adacore.com>
3222
3223         * ada-lang.c (ada_value_primitive_field): Treat more fields as
3224         bitfields.
3225
3226 2019-05-01  Tom Tromey  <tromey@adacore.com>
3227
3228         * ada-lang.c (ada_value_assign): Correctly compute starting offset
3229         for big-endian copies.
3230
3231 2019-04-30  Ali Tamur  <tamur@google.com>
3232         * gdb/dwarf2read.c (read_3_bytes): New declaration.
3233         (read_attribute_value): Added DW_FORM_strx1-4 cases.
3234         (read_3_bytes): New function.
3235
3236 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3237
3238         * windows-nat.c (main_thread_id): Delete.
3239         (handle_output_debug_string): Replace main_thread_id by
3240         current_event.dwThreadId.
3241         (fake_create_process): Likewise.
3242         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
3243         Do not set main_thread_id.
3244         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
3245         current_event.dwThreadId.
3246         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
3247
3248 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3249
3250         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
3251         Use current_event.dwThreadId instead of main_thread_id.
3252
3253 2019-04-30  Tom Tromey  <tromey@adacore.com>
3254
3255         * ada-lang.c (ada_lookup_simple_minsyms): New function.
3256         (create_excep_cond_exprs): Iterate over program spaces.
3257         (ada_exception_catchpoint_cond_string): Examine all minimal
3258         symbols for exception types.
3259
3260 2019-04-30  Tom Tromey  <tromey@adacore.com>
3261
3262         PR c++/24470:
3263         * dwarf2read.c (process_structure_scope): Handle case where type
3264         has template parameters but no symbol was created.
3265
3266 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3267             Chris January  <chris.january@arm.com>
3268
3269         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
3270         qualifier.
3271         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
3272
3273 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3274
3275         * f-typeprint.c (f_print_type): Update rules for printing
3276         whitespace.
3277         (f_type_print_varspec_suffix): Likewise.
3278
3279 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3280             Chris January  <chris.january@arm.com>
3281
3282         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
3283         function arguments.
3284
3285 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3286
3287         * f-lang.c (build_fortran_types): Change name of void type to
3288         lower case.
3289         * f-typeprint.c (f_type_print_base): Print the name of the void
3290         type, rather than a fixed string.
3291         * f-valprint.c (f_decorations): Use lower case void string.
3292
3293 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3294             Chris January  <chris.january@arm.com>
3295
3296         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
3297         types for Fortran.
3298
3299 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3300             Chris January  <chris.january@arm.com>
3301             David Lecomber  <david.lecomber@arm.com>
3302
3303         * f-exp.y (BINOP_INTRINSIC): New token.
3304         (exp): New parser rule handling BINOP_INTRINSIC.
3305         (f77_keywords): Add new builtin procedures.
3306         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
3307         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3308         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
3309         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3310         (print_unop_subexp_f): New function.
3311         (print_binop_subexp_f): New function.
3312         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3313         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3314         (dump_subexp_body_f): Likewise.
3315         (operator_check_f): Likewise.
3316         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3317         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
3318
3319 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3320
3321         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
3322         UNOP_KIND.
3323         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
3324         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
3325         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
3326         (operator_length_f): New fuction.
3327         (print_subexp_f): New function.
3328         (op_name_f): New function.
3329         (dump_subexp_body_f): New function.
3330         (operator_check_f): New function.
3331         (exp_descriptor_f): Replace standard expression handling functions
3332         with new functions.
3333         * gdb/fortran-operator.def: New file.
3334         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
3335         * gdb/std-operator.def: Remove UNOP_KIND.
3336
3337 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3338
3339         * std-operator.def: Remove unbalanced, stray double quote
3340         character.
3341
3342 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3343             Chris January  <chris.january@arm.com>
3344             Daniel Everett  <daniel.everett@arm.com>
3345             Nick Forrington  <nick.forrington@arm.com>
3346             Richard Bunt  <richard.bunt@arm.com>
3347
3348         * cp-valprint.c (cp_print_value_fields): Allow an additional level
3349         of depth when printing anonymous structs or unions.
3350         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
3351         Don't print either the top-level value, or the children if the
3352         max-depth is exceeded.
3353         (ppscm_print_children): When printing the key of a map, allow one
3354         extra level of depth.
3355         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
3356         print either the top-level value, or the children if the max-depth
3357         is exceeded.
3358         (print_children): When printing the key of a map, allow one extra
3359         level of depth.
3360         * python/py-value.c (valpy_format_string): Add max_depth keyword.
3361         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
3362         (user_print_options): Initialise max_depth field.
3363         (val_print_scalar_or_string_type_p): New function.
3364         (val_print): Check to see if the max depth has been reached.
3365         (val_print_check_max_depth): Define new function.
3366         (show_print_max_depth): New function.
3367         (_initialize_valprint): Add 'print max-depth' option.
3368         * valprint.h (struct value_print_options) <max_depth>: New field.
3369         (val_print_check_max_depth): Declare new function.
3370         * NEWS: Document new feature.
3371
3372 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3373
3374         * ada-lang.c (ada_language_defn): Initialise new field.
3375         * c-lang.c (c_is_string_type_p): New function.
3376         (c_language_defn): Initialise new field.
3377         (cplus_language_defn): Initialise new field.
3378         (asm_language_defn): Initialise new field.
3379         (minimal_language_defn): Initialise new field.
3380         * c-lang.h (c_is_string_type_p): Declare new function.
3381         * d-lang.c (d_language_defn): Initialise new field.
3382         * f-lang.c (f_is_string_type_p): New function.
3383         (f_language_defn): Initialise new field.
3384         * go-lang.c (go_is_string_type_p): New function.
3385         (go_language_defn): Initialise new field.
3386         * language.c (default_is_string_type_p): New function.
3387         (unknown_language_defn): Initialise new field.
3388         (auto_language_defn): Initialise new field.
3389         * language.h (struct language_defn) <la_is_string_type_p>: New
3390         member variable.
3391         (default_is_string_type_p): Declare new function.
3392         * m2-lang.c (m2_language_defn): Initialise new field.
3393         * objc-lang.c (objc_language_defn): Initialise new field.
3394         * opencl-lang.c (opencl_language_defn): Initialise new field.
3395         * p-lang.c (pascal_is_string_type_p): New function.
3396         (pascal_language_defn): Initialise new field.
3397         * rust-lang.c (rust_is_string_type_p): New function.
3398         (rust_language_defn): Initialise new field.
3399
3400 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3401
3402         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
3403         New field.
3404         * ada-lang.c (ada_language_defn): Initialise new field.
3405         * c-lang.c (c_language_defn): Likewise.
3406         (cplus_language_defn): Likewise.
3407         (asm_language_defn): Likewise.
3408         (minimal_language_defn): Likewise.
3409         * d-lang.c (d_language_defn): Likewise.
3410         * f-lang.c (f_language_defn): Likewise.
3411         * go-lang.c (go_language_defn): Likewise.
3412         * language.c (unknown_language_defn): Likewise.
3413         (auto_language_defn): Likewise.
3414         * m2-lang.c (m2_language_defn): Likewise.
3415         * objc-lang.c (objc_language_defn): Likewise.
3416         * opencl-lang.c (opencl_language_defn): Likewise.
3417         * p-lang.c (pascal_language_defn): Likewise.
3418         * rust-lang.c (rust_language_defn): Likewise.
3419
3420 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3421
3422         * ada-lang.c (ada_is_character_type): Change return type to bool.
3423         (ada_is_string_type): Likewise.
3424         * ada-lang.h (ada_is_character_type): Update declaration
3425         (ada_is_string_type): Likewise.
3426
3427 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3428
3429         Support style in 'frame|thread apply'
3430
3431         * gdbcmd.h (execute_command_to_string): New term_out parameter.
3432         * record.c (record_start, record_stop): Update callers of
3433         execute_command_to_string with false.
3434         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
3435         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
3436         methods.
3437         (class string_file): New constructor with term_out parameter.
3438         Override methods term_out and can_emit_style_escape.  New member
3439         term_out.
3440         (class stdio_file): Override can_emit_style_escape.
3441         (class tee_file): Override term_out and can_emit_style_escape.
3442         * utils.h (can_emit_style_escape): Remove.
3443         * utils.c (can_emit_style_escape): Likewise.
3444         Update all callers of can_emit_style_escape (SOMESTREAM) to
3445         SOMESTREAM->can_emit_style_escape.
3446         * source-cache.c (source_cache::get_source_lines): Likewise.
3447         * stack.c (frame_apply_command_count): Call execute_command_to_string
3448         passing the term_out characteristic of the current gdb_stdout.
3449         * thread.c (thr_try_catch_cmd): Likewise.
3450         * top.c (execute_command_to_string): pass term_out parameter
3451         to construct the string_file for the command output.
3452         * ui-file.c (term_cli_styling): New function (most code moved
3453         from utils.c can_emit_style_escape).
3454         (string_file::string_file, string_file::can_emit_style_escape,
3455         stdio_file::can_emit_style_escape, tee_file::term_out,
3456         tee_file::can_emit_style_escape): New functions.
3457
3458 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3459
3460         * NEWS: Mention the new set|show may-call-functions.
3461         * infcall.c (may_call_functions_p): New variable.
3462         (show_may_call_functions_p): New function.
3463         (call_function_by_hand_dummy): Throws an error if not
3464         may-call-functions.
3465         (_initialize_infcall): Call add_setshow_boolean_cmd for
3466         may-call-functions.
3467
3468 2019-04-25  Keith Seitz  <keiths@redhat.com>
3469
3470         PR c++/24367
3471         * cp-support.c (inspect_type): Don't attempt substitutions
3472         of symbol with the same name.
3473
3474 2019-04-25  Tom Tromey  <tromey@adacore.com>
3475
3476         PR gdb/24475:
3477         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
3478         static.
3479
3480 2019-04-25  Tom Tromey  <tromey@adacore.com>
3481
3482         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
3483         rvalue reference.
3484         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
3485         (gdb_xml_parser::parse): Use std::move.
3486         * python/python-internal.h (gdbpy_convert_exception): Take a const
3487         reference.
3488         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
3489         std::move.
3490         * python/py-utils.c (gdbpy_convert_exception): Take a const
3491         reference.
3492         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3493         Use std::move.
3494         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3495         Use std::move.
3496         * mi/mi-main.c (mi_print_exception): Take a const reference.
3497         * main.c (handle_command_errors): Take a const reference.
3498         * linespec.c (parse_linespec): Use std::move.
3499         * infcall.c (run_inferior_call): Use std::move.
3500         (call_function_by_hand_dummy): Use std::move.
3501         * exec.c (try_open_exec_file): Use std::move.
3502         * exceptions.h (exception_print, exception_fprintf)
3503         (exception_print_same): Update.
3504         * exceptions.c (print_exception, exception_print)
3505         (exception_fprintf, exception_print_same): Change parameters to
3506         const reference.
3507         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
3508         * common/new-op.c: Use std::move.
3509         * common/common-exceptions.h (struct gdb_exception): Add move
3510         constructor.
3511         (struct gdb_exception_error, struct gdb_exception_quit, struct
3512         gdb_quit_bad_alloc): Change constructor to move constructor.
3513         (throw_exception): Change parameter to rvalue reference.
3514         * common/common-exceptions.c (throw_exception): Take rvalue
3515         reference.
3516         * cli/cli-interp.c (safe_execute_command): Use std::move.
3517         * breakpoint.c (insert_bp_location, location_to_sals): Use
3518         std::move.
3519
3520 2019-04-25  Tom Tromey  <tromey@adacore.com>
3521
3522         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
3523         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
3524         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
3525         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
3526         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
3527         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
3528         guile/scm-value.c: Use unpack.
3529         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
3530         gdbscm_gdb_exception.
3531         (gdbscm_throw_gdb_exception): Likewise.
3532         (struct gdbscm_gdb_exception): New.
3533         (unpack): New function.
3534         (gdbscm_wrap): Use unpack.
3535
3536 2019-04-25  Tom Tromey  <tromey@adacore.com>
3537
3538         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3539         (gdb_rl_callback_handler): Use std::move.
3540         * common/common-exceptions.h (struct gdb_exception): Add move
3541         assignment operator.
3542         (throw_exception_sjlj): Change "exception" to const reference.
3543         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
3544         (throw_exception_sjlj): Change "exception" to const reference.
3545
3546 2019-04-25  Tom Tromey  <tromey@adacore.com>
3547
3548         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
3549         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
3550         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3551         Update.
3552         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3553         Update.
3554         * mi/mi-interp.c (mi_interp::exec): Update.
3555         * linespec.c (parse_linespec): Update.
3556         * infcall.c (run_inferior_call): Update.
3557         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
3558         * guile/scm-symbol.c (gdbscm_lookup_symbol)
3559         (gdbscm_lookup_global_symbol): Update.
3560         * guile/scm-param.c (gdbscm_parameter_value): Update.
3561         * guile/scm-frame.c (gdbscm_frame_read_register)
3562         (gdbscm_frame_read_var): Update.
3563         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
3564         * exec.c (try_open_exec_file): Update.
3565         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3566         (gdb_rl_callback_handler): Update.
3567         * common/common-exceptions.h (exception_none): Don't declare.
3568         * common/common-exceptions.c (exception_none): Don't define.
3569         (struct catcher) <exception>: Update.
3570         * cli/cli-interp.c (safe_execute_command): Update.
3571         * breakpoint.c (insert_bp_location, location_to_sals): Update.
3572
3573 2019-04-25  Ali Tamur  <tamur@google.com>
3574
3575         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
3576         (read_attribute_value): Likewise.
3577         (dwarf2_read_addr_index): Update comment.
3578         (read_str_index): Add DW_FORM_strx.
3579         (dwarf2_string_attr): Likewise.
3580         (dwarf2_const_value_attr): Likewise.
3581         (dump_die_shallow): Likewise.
3582         (dwarf2_fetch_constant_bytes): Likewise.
3583         (skip_form_bytes): Likewise.
3584         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
3585
3586 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
3587
3588         PR corefiles/11608
3589         PR corefiles/18187
3590         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
3591         OFFSET.  Verify if current mapping contains an ELF header.
3592         (linux_find_memory_regions_full): Adjust call to
3593         dump_mapping_p.
3594
3595 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
3596             Kang Li <kanglictf@gmail.com>
3597
3598         PR gdb/21600
3599
3600         * dwarf2-frame.c (read_initial_length): Be consistent about using
3601         unsigned representation of length.
3602         (decode_frame_entry_1): Likewise.  Check for wraparound of
3603         end pointer as well as buffer overflow.
3604
3605 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
3606
3607         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
3608         "vq".
3609
3610 2019-04-24  Tom Tromey  <tromey@adacore.com>
3611
3612         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
3613
3614 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3615
3616         * s12z-tdep.c (s12z_unwind_pc): Delete.
3617         (s12z_unwind_sp): Delete.
3618         (s12z_gdbarch_init): Don't register deleted functions with
3619         gdbarch.
3620
3621 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3622
3623         * rl78-tdep.c (rl78_unwind_sp): Delete.
3624         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
3625
3626 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3627
3628         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
3629         (xstormy16_unwind_pc): Delete.
3630         (xstormy16_dummy_id): Delete.
3631         (xstormy16_gdbarch_init): Don't register deleted functions with
3632         gdbarch.
3633
3634 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3635
3636         * vax-tdep.c (vax_unwind_pc): Delete.
3637         (vax_gdbarch_init): Don't register deleted function with gdbarch.
3638
3639 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3640
3641         * v850-tdep.c (v850_unwind_sp): Delete.
3642         (v850_unwind_pc): Delete.
3643         (v850_dummy_id): Delete.
3644         (v850_gdbarch_init): Don't register deleted functions with
3645         gdbarch.
3646
3647 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3648
3649         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
3650         (tilegx_unwind_pc): Delete.
3651         (tilegx_unwind_dummy_id): Delete.
3652         (tilegx_gdbarch_init): Don't register deleted functions with
3653         gdbarch.
3654
3655 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3656
3657         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
3658         (tic6x_dummy_id): Delete.
3659         (tic6x_gdbarch_init): Don't register deleted functions with
3660         gdbarch.
3661
3662 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3663
3664         * sparc-tdep.c (sparc_unwind_pc): Delete.
3665         (sparc32_gdbarch_init): Don't register deleted function with
3666         gdbarch.
3667
3668 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3669
3670         * sh-tdep.c (sh_unwind_sp): Delete.
3671         (sh_unwind_pc): Delete.
3672         (sh_dummy_id): Delete.
3673         (sh_gdbarch_init): Don't register deleted functions with
3674         gdbarch.
3675
3676 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3677
3678         * score-tdep.c (score_unwind_sp): Delete.
3679         (score_unwind_pc): Delete.
3680         (score_dummy_id): Delete.
3681         (score_gdbarch_init): Don't register deleted functions with
3682         gdbarch.
3683
3684 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3685
3686         * rx-tdep.c (rx_unwind_pc): Delete.
3687         (rx_unwind_sp): Delete.
3688         (rx_dummy_id): Delete.
3689         (rx_gdbarch_init): Don't register deleted functions with
3690         gdbarch.  Update comment.
3691
3692 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3693
3694         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
3695         (rs6000_dummy_id): Delete.
3696         (rs6000_gdbarch_init): Don't register deleted functions with
3697         gdbarch.
3698
3699 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3700
3701         * or1k-tdep.c (or1k_dummy_id): Delete.
3702         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
3703
3704 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3705
3706         * nios2-tdep.c (nios2_dummy_id): Delete.
3707         (nios2_unwind_sp): Delete.
3708         (nios2_gdbarch_init): Don't register deleted functions with
3709         gdbarch.
3710
3711 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3712
3713         * nds32-tdep.c (nds32_dummy_id): Delete.
3714         (nds32_unwind_pc): Delete.
3715         (nds32_unwind_sp): Delete.
3716         (nds32_gdbarch_init): Don't register deleted functions with
3717         gdbarch.
3718
3719 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3720
3721         * msp430-tdep.c (msp430_unwind_pc): Delete.
3722         (msp430_unwind_sp): Delete.
3723         (msp430_dummy_id): Delete.
3724         (msp430_gdbarch_init): Don't register deleted functions with
3725         gdbarch.
3726
3727 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3728
3729         * moxie-tdep.c (moxie_unwind_sp): Delete.
3730         (moxie_unwind_pc): Delete.
3731         (moxie_dummy_id): Delete.
3732         (moxie_gdbarch_init): Don't register deleted functions with
3733         gdbarch.
3734
3735 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3736
3737         * mn10300-tdep.c (mn10300_dummy_id): Delete.
3738         (mn10300_unwind_pc): Delete.
3739         (mn10300_unwind_sp): Delete.
3740         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
3741         mn10300_unwind_sp.
3742         (mn10300_frame_unwind_init): Don't register deleted functions with
3743         gdbarch.
3744
3745 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3746
3747         * mep-tdep.c (mep_unwind_pc): Delete.
3748         (mep_unwind_sp): Delete.
3749         (mep_dummy_id): Delete.
3750         (mep_gdbarch_init): Don't register deleted functions with
3751         gdbarch.
3752
3753 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3754
3755         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
3756         (m68hc11_unwind_sp): Delete.
3757         (m68hc11_gdbarch_init): Don't register deleted functions with
3758         gdbarch.
3759
3760 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3761
3762         * m32r-tdep.c (m32r_unwind_sp): Delete.
3763         (m32r_unwind_pc): Delete.
3764         (m32r_dummy_id): Delete.
3765         (m32r_gdbarch_init): Don't register deleted functions with
3766         gdbarch.
3767
3768 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3769
3770         * m32c-tdep.c (m32c_unwind_pc): Delete.
3771         (m32c_unwind_sp): Delete.
3772         (m32c_dummy_id): Delete.
3773         (m32c_gdbarch_init): Don't register deleted functions with
3774         gdbarch.
3775
3776 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3777
3778         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
3779         (lm32_unwind_pc): Delete.
3780         (lm32_dummy_id): Delete.
3781         (lm32_gdbarch_init): Don't register deleted functions with
3782         gdbarch.
3783
3784 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3785
3786         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
3787         (iq2000_unwind_pc): Delete.
3788         (iq2000_dummy_id): Delete.
3789         (iq2000_gdbarch_init): Don't register deleted functions with
3790         gdbarch.
3791
3792 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3793
3794         * nds32-tdep.c (nds32_type_align): Delete.
3795         (nds32_push_dummy_call): Use type_align instead.
3796
3797 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3798
3799         * arm-tdep.c (arm_type_align): Only handle vector override case.
3800         (arm_push_dummy_call): Use type_align.
3801         (arm_gdbarch_init): Register arm_type_align gdbarch function.
3802
3803 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3804
3805         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
3806         case.
3807         (pass_on_stack): Use type_align.
3808         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
3809         function.
3810
3811 2019-04-23  Tom Tromey  <tromey@adacore.com>
3812
3813         * dwarf2read.c (line_header::file_name_at): Remove unused
3814         overload.
3815
3816 2019-04-23  Tom de Vries  <tdevries@suse.de>
3817
3818         PR gdb/24438
3819         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
3820         invocation.
3821
3822
3823 2019-03-27  Ali Tamur  <tamur@google.com>
3824
3825         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
3826         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
3827         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
3828         (dwarf_expr_context::get_addr_index): Likewise
3829         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
3830         (symbol_needs_eval_context::get_addr_index): Likewise
3831         (disassemble_dwarf_expression): Add DW_OP_addrx
3832         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
3833         (read_cutu_die_from_dwo): Update comment
3834         (skip_one_die): Add DW_FORM_addrx
3835         (read_attribute_value): Likewise
3836         (var_decode_location): Add DW_OP_addrx
3837         (dwarf2_const_value_attr): Add DW_FORM_addrx
3838         (dump_die_shallow): Likewise
3839         (dwarf2_fetch_constant_bytes): Likewise
3840         (decode_locdesc): Add DW_OP_addrx
3841         (skip_form_bytes): Add DW_FORM_addrx
3842
3843 2019-04-22  Ali Tamur  <tamur@google.com>
3844
3845         * MAINTAINERS (Write After Approval): Add self.
3846
3847 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
3848
3849         * solib-svr4.c (get_svr4_info): Add pspace parameter.
3850         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
3851         (open_symbol_file_object): Likewise.
3852         (svr4_default_sos): Add info parameter.
3853         (svr4_read_so_list): Likewise.
3854         (svr4_current_sos_direct): Adjust functions calls to pass down
3855         info.
3856         (svr4_current_sos_1): Add info parameter.
3857         (svr4_current_sos): Call get_svr4_info, pass info down to
3858         svr4_current_sos_1.
3859         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
3860         get_svr4_info.
3861         (svr4_in_dynsym_resolve_code): Pass current_program_space to
3862         get_svr4_info.
3863         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
3864         to get_svr4_info.
3865         (probes_table_remove_objfile_probes): Likewise.
3866         (register_solib_event_probe): Add info parameter.
3867         (solist_update_incremental): Pass info parameter down to
3868         svr4_read_so_list.
3869         (disable_probes_interface): Add info parameter.
3870         (svr4_handle_solib_event): Pass current_program_space to
3871         get_svr4_info.  Adjust disable_probes_interface cleanup.
3872         (svr4_create_probe_breakpoints): Add info parameter, pass it
3873         down to register_solib_event_probe.
3874         (svr4_create_solib_event_breakpoints): Add info parameter,
3875         pass it down to svr4_create_probe_breakpoints.
3876         (enable_break): Pass info down to
3877         svr4_create_solib_event_breakpoints.
3878         (svr4_solib_create_inferior_hook): Pass current_program_space to
3879         get_svr4_info.
3880         (svr4_clear_solib): Likewise.
3881
3882 2019-04-22  Pedro Alves  <palves@redhat.com>
3883
3884         * solib-svr4.c (svr4_free_objfile_observer): New.
3885         (probe_and_action::objfile): New field.
3886         (probes_table_htab_remove_objfile_probes)
3887         (probes_table_remove_objfile_probes): New functions.
3888         (register_solib_event_probe): Add 'objfile' parameter.  Store it
3889         in the new probe_and_action.  Don't store the probe in 'lookup'.
3890         (svr4_create_probe_breakpoints): Pass objfile to
3891         register_solib_event_probe.
3892         (_initialize_svr4_solib): Register a free_objfile observer.
3893
3894 2019-04-19  Tom Tromey  <tom@tromey.com>
3895
3896         * common/queue.h: Remove.
3897
3898 2019-04-19  Tom Tromey  <tom@tromey.com>
3899
3900         * event-loop.c: Don't include "common/queue.h".
3901
3902 2019-04-19  Tom Tromey  <tom@tromey.com>
3903
3904         * remote.c (remote_target): Use delete.
3905         * remote-notif.h: Include <list>, not "common/queue.h".
3906         (notif_client_p): Remove typedef.
3907         (remote_notif_state): Add constructor, destructor, initializer.
3908         <notif_queue>: Now a std::list.
3909         (remote_notif_state_xfree): Don't declare.
3910         * remote-notif.c (remote_notif_process, handle_notification)
3911         (remote_notif_state_allocate): Update.
3912         (~remote_notif_state): Rename from remote_notif_state_xfree.
3913
3914 2019-04-19  Tom Tromey  <tom@tromey.com>
3915
3916         * symfile.c (reread_symbols): Update.
3917         * objfiles.c (objfile_register_static_link)
3918         (objfile_lookup_static_link): Update
3919         (~objfile) Don't delete static_links.
3920         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
3921
3922 2019-04-19  Tom Tromey  <tom@tromey.com>
3923
3924         * type-stack.h (struct type_stack) <insert>: Constify string.
3925         * type-stack.c (type_stack::insert): Constify string.
3926         * gdbtypes.h (lookup_template_type): Update.
3927         (address_space_name_to_int): Update.
3928         * gdbtypes.c (address_space_name_to_int): Make space_identifier
3929         const.
3930         (lookup_template_type): Make name const.
3931         * c-exp.y: Update rules.
3932         (lex_one_token, classify_name, classify_inner_name)
3933         (c_print_token): Update.
3934         * p-exp.y: Update rules.
3935         (yylex): Update.
3936         * f-exp.y: Update rules.
3937         (yylex): Update.
3938         * d-exp.y: Update rules.
3939         (lex_one_token, classify_name, classify_inner_name): Update.
3940         * parse.c (write_dollar_variable, copy_name): Return std::string.
3941         * parser-defs.h (copy_name): Change return type.
3942         * m2-exp.y: Update rules.
3943         (yylex): Update.
3944         * go-exp.y (lex_one_token): Update.
3945         Update rules.
3946         (classify_unsafe_function, classify_packaged_name)
3947         (classify_name, yylex): Update.
3948
3949 2019-04-19  Sergei Trofimovich <siarheit@google.com>
3950
3951         * configure.ac: add --enable-source-highlight switch.
3952         * configure: Regenerate.
3953         * top.c (print_gdb_version): plumb --enable-source-highlight
3954         status to "show configuration".
3955
3956 2019-04-19  Tom Tromey  <tromey@adacore.com>
3957
3958         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
3959         Check ADA_TYPE_P.
3960         (empty_record, ada_template_to_fixed_record_type_1)
3961         (template_to_static_fixed_type)
3962         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
3963         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
3964         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
3965         macros.
3966
3967 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
3968
3969         PR symtab/24423:
3970         * source.c (print_source_lines_base): Advance "iter" when a
3971         control character is seen.
3972
3973 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3974
3975         * inferior.h (struct infcall_suspend_state_deleter):
3976         Catch exception in destructor to avoid crash.
3977
3978 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3979
3980         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
3981         close to the add_com "shell".
3982
3983 2019-04-18  Tom Tromey  <tromey@adacore.com>
3984
3985         * process-stratum-target.h (class process_stratum_target)
3986         <stratum>: Add "final".
3987
3988 2019-04-17  Tom Tromey  <tromey@adacore.com>
3989
3990         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
3991         against nullptr before use.
3992
3993 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
3994
3995         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
3996
3997 2019-04-17  Jim Wilson  <jimw@sifive.com>
3998             Andrew Burgess  <andrew.burgess@embecosm.com>
3999
4000         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4001         code read might fail, assume 4-byte breakpoint in that case.
4002
4003 2019-04-15  Leszek Swirski  <leszeks@google.com>
4004
4005         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4006         rather than a hand-rolled POD check when checking for forced MEMORY
4007         classification.
4008
4009 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4010
4011         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4012         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4013         function.
4014         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4015         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4016         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4017         declaration.
4018
4019 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4020
4021         * aarch64-linux-nat.c
4022         (aarch64_linux_nat_target::thread_architecture): Add override.
4023         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4024         each VQ.
4025
4026 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4027
4028         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4029
4030 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4031
4032         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4033         target types of size 96-bits, add some additional comments, and
4034         check that the builtin type we found was the correct size.
4035
4036 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4037
4038         * utils.c (prompt_for_continue): Don't restore the styling at the
4039         end, as applied_style has the wrong value.  This fixes styling in
4040         long lists of file names that are interrupted by the "Continue?"
4041         prompt.
4042
4043 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4044
4045         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4046         * c-lang.c (c_language_defn): Likewise.
4047         (cplus_language_defn): Likewise.
4048         (asm_language_defn): Likewise.
4049         (minimal_language_defn): Likewise.
4050         * d-lang.c (d_language_defn): Likewise.
4051         * f-lang.c (f_language_defn): Likewise.
4052         * go-lang.c (go_language_defn): Likewise.
4053         * language.c (unknown_language_defn): Likewise.
4054         (auto_language_defn): Likewise.
4055         * language.h (struct language_defn): Remove la_magic field.
4056         (LANG_MAGIC): Delete.
4057         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4058         * objc-lang.c (objc_language_defn): Likewise.
4059         * opencl-lang.c (opencl_language_defn): Likewise.
4060         * p-lang.c (pascal_language_defn): Likewise.
4061         * rust-lang.c (rust_language_defn): Likewise.
4062
4063 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4064
4065         * riscv-tdep.c (riscv_type_align): New function.
4066         (riscv_type_alignment): Delete.
4067         (riscv_arg_location): Use 'type_align'.
4068         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4069
4070 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4071
4072         * gdbtypes.c (type_align): A struct with no non-static fields also
4073         has alignment of 1.
4074
4075 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4076
4077         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4078         component to 0.
4079         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4080         member.
4081         (riscv_struct_info::analyse): New implementation using new
4082         analyse_inner member function.
4083         (riscv_struct_info::field_offset): New member function.
4084         (riscv_struct_info::m_offsets): New member variable.
4085         (riscv_struct_info::analyse_inner): New private member function,
4086         takes the old implementation of riscv_struct_info::analyse but
4087         extended to track field offsets.
4088         (riscv_call_arg_struct): Update the struct folding special cases
4089         to handle cases where empty C++ structs, which are non-zero
4090         length, are found.
4091         (riscv_arg_location): Initialise the length of each location, a
4092         non-zero length now indicates the location is in use.
4093         (riscv_push_dummy_call): Allow for the first location having a
4094         non-zero offset when setting up arguments.
4095         (riscv_return_value): Likewise, but for return values.
4096
4097 2019-04-11  Tom Tromey  <tromey@adacore.com>
4098
4099         * utils.c (internal_vproblem): Make "msg" const.
4100
4101 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4102
4103         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4104         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4105         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4106         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4107
4108 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4109
4110         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4111         function.
4112         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4113         of amd64_collect_native_gregset.
4114         (amd64_linux_nat_target::store_registers): Likewise.
4115
4116 2019-04-10  Tom Tromey  <tom@tromey.com>
4117
4118         * symtab.c (lookup_global_symbol_from_objfile)
4119         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4120         * objfiles.h (class separate_debug_iterator): New.
4121         (class separate_debug_range): New.
4122         (struct objfile) <separate_debug_objfiles>: New method.
4123         (objfile_separate_debug_iterate): Don't declare.
4124         * objfiles.c (separate_debug_iterator::operator++): Rename from
4125         objfile_separate_debug_iterate.
4126         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4127         iterator.
4128         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4129         iterator.
4130
4131 2019-04-10  Tom Tromey  <tom@tromey.com>
4132
4133         * symfile.c (reread_symbols): Remove old comment.
4134         * objfiles.c (free_all_objfiles): Fix a typo.
4135
4136 2019-04-10  Tom Tromey  <tom@tromey.com>
4137
4138         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4139         * minsyms.c (lookup_minimal_symbol): Use foreach.
4140         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4141         (lookup_minimal_symbol_solib_trampoline): Likewise.
4142         * symfile.c (reread_symbols): Use foreach.
4143
4144 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4145             Tom Tromey  <tromey@adacore.com>
4146
4147         PR rust/24414:
4148         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4149         (rust_lex_int_test): Change "value" to be LONGEST.
4150         (rust_lex_tests): Add test for long integer literal.
4151
4152 2019-04-09  Tom Tromey  <tromey@adacore.com>
4153
4154         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
4155         to bool.
4156         (extended_remote_target::attach): Update.
4157         (remote_target::remote_notice_new_inferior): Update.
4158         (remote_target::add_current_inferior_and_thread): Update.
4159         * inferior.c (exit_inferior_1): Use "false".
4160         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
4161
4162 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
4163
4164         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
4165         the "start" command.
4166
4167 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4168
4169         * python/py-inferior.c (infpy_thread_from_thread_handle):
4170         Adjust comments to reflect renaming of thread_from_thread_handle
4171         to thread_from_handle.  Adjust keywords.  Fix type error message.
4172         (inferior_object_methods): Add thread_from_handle.  Retain
4173         thread_from_thread_handle, but mark it as deprecated.
4174
4175 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4176
4177         * gdbthread.h (find_thread_by_handle): Revise declaration.
4178         * thread.c (find_thread_by_handle): Likewise.  Adjust
4179         implementation too.
4180         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
4181         support for buffer objects as handles.
4182
4183 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4184
4185         * python/py-infthread.c (thpy_thread_handle): New function.
4186         (thread_object_methods): Register thpy_thread_handle.
4187
4188 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4189
4190         * gdbthread.h (thread_to_thread_handle): Declare.
4191         * thread.c (gdbtypes.h): Include.
4192         (thread_to_thread_handle): New function.
4193
4194         * target.h (struct target_ops): Add thread_info_to_thread_handle.
4195         (target_thread_info_to_thread_handle): Declare.
4196         * target.c (target_thread_info_to_thread_handle): New function.
4197         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
4198         * target-delegates.c: Regenerate.
4199
4200         * linux-thread-db.c (class thread_db_target): Add method
4201         thread_info_to_thread_handle.
4202         (thread_db_target::thread_info_to_thread_handle): Define.
4203         * remote.c (class remote_target): Add new method
4204         thread_info_to_thread_handle.
4205         (remote_target::thread_info_to_thread_handle): Define.
4206
4207 2019-04-08  Pedro Alves  <palves@redhat.com>
4208
4209         * common/common-exceptions.c (throw_exception): Don't create
4210         named object to throw; throw directly.
4211         (throw_it): Likewise.  Don't initialize gdb_exception::message
4212         here, with new; pass FMT and AP to the ctor instead.
4213         * common/common-exceptions.h: Include <string>.
4214         (gdb_exception::gdb_exception(enum return_reason, enum errors,
4215         const char *, va_list)): New ctor.  Use std::make_shared.
4216         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
4217         errors)): Delete.
4218         (gdb_exception_error::gdb_exception_error(enum errors, const char
4219         *, va_list)): New.
4220         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
4221         Add assertion.
4222         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
4223         errors)): Delete.
4224         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
4225         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
4226         Add assertion.
4227
4228 2019-04-08  Tom Tromey  <tom@tromey.com>
4229
4230         * valops.c (value_rtti_indirect_type): Replace throw_exception
4231         with throw.
4232         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
4233         with throw.
4234         * thread.c (thr_try_catch_cmd): Replace throw_exception with
4235         throw.
4236         * target.c (target_translate_tls_address): Replace throw_exception
4237         with throw.
4238         * stack.c (frame_apply_command_count): Replace throw_exception
4239         with throw.
4240         * solib-spu.c (append_ocl_sos): Replace throw_exception with
4241         throw.
4242         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
4243         with throw.
4244         * rs6000-tdep.c (rs6000_frame_cache)
4245         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
4246         * remote.c: Replace throw_exception with throw.
4247         * record-full.c (record_full_message, record_full_wait_1)
4248         (record_full_restore): Replace throw_exception with throw.
4249         * record-btrace.c:
4250         (get_thread_current_frame_id, record_btrace_start_replaying)
4251         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
4252         (cmd_record_btrace_start): Replace throw_exception with throw.
4253         * parse.c (parse_exp_in_context_1): Replace throw_exception with
4254         throw.
4255         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
4256         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
4257         * linespec.c:
4258         (find_linespec_symbols): Replace throw_exception with throw.
4259         * infrun.c (displaced_step_prepare, resume): Replace
4260         throw_exception with throw.
4261         * infcmd.c (post_create_inferior): Replace throw_exception with
4262         throw.
4263         * inf-loop.c (inferior_event_handler): Replace throw_exception
4264         with throw.
4265         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
4266         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
4267         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
4268         (get_prev_frame_always, get_frame_pc_if_available)
4269         (get_frame_address_in_block_if_available, get_frame_language):
4270         Replace throw_exception with throw.
4271         * frame-unwind.c (frame_unwind_try_unwinder): Replace
4272         throw_exception with throw.
4273         * eval.c (fetch_subexp_value, evaluate_var_value)
4274         (evaluate_funcall, evaluate_subexp_standard): Replace
4275         throw_exception with throw.
4276         * dwarf2loc.c (call_site_find_chain)
4277         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
4278         Replace throw_exception with throw.
4279         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
4280         with throw.
4281         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
4282         throw.
4283         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
4284         * completer.c (complete_line_internal): Replace throw_exception
4285         with throw.
4286         * compile/compile-object-run.c (compile_object_run): Replace
4287         throw_exception with throw.
4288         * cli/cli-script.c (process_next_line): Replace throw_exception
4289         with throw.
4290         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
4291         (btrace_enable, btrace_maint_update_pt_packets): Replace
4292         throw_exception with throw.
4293         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
4294         throw_exception with throw.
4295         * break-catch-throw.c (re_set_exception_catchpoint): Replace
4296         throw_exception with throw.
4297         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
4298         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
4299         * aarch64-tdep.c (aarch64_make_prologue_cache)
4300         (aarch64_make_stub_cache): Replace throw_exception with throw.
4301
4302 2019-04-08  Tom Tromey  <tom@tromey.com>
4303
4304         * common/common-exceptions.c (throw_exception): Rename from
4305         throw_exception_cxx.  Remove old copy.  Make argument const.
4306         (throw_it): Create and throw exception objects directly.
4307         * common/common-exceptions.h (throw_exception): Make argument
4308         const.
4309         (struct gdb_exception_error): Add constructor.
4310         (struct gdb_exception_quit): Add constructor.
4311
4312 2019-04-08  Tom Tromey  <tom@tromey.com>
4313
4314         * common/common-exceptions.h (exception_rethrow): Don't declare.
4315         (TRY_SJLJ): Update comment.
4316         (TRY, CATCH, END_CATCH): Remove.
4317         * common/common-exceptions.c (exception_rethrow): Remove.
4318
4319 2019-04-08  Tom Tromey  <tom@tromey.com>
4320
4321         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
4322         Remove.
4323         (gdb_exception_error): Rename from
4324         gdb_exception_RETURN_MASK_ERROR.
4325         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
4326         (gdb_quit_bad_alloc): Update.
4327         * aarch64-tdep.c: Update.
4328         * ada-lang.c: Update.
4329         * ada-typeprint.c: Update.
4330         * ada-valprint.c: Update.
4331         * amd64-tdep.c: Update.
4332         * arch-utils.c: Update.
4333         * break-catch-throw.c: Update.
4334         * breakpoint.c: Update.
4335         * btrace.c: Update.
4336         * c-varobj.c: Update.
4337         * cli/cli-cmds.c: Update.
4338         * cli/cli-interp.c: Update.
4339         * cli/cli-script.c: Update.
4340         * common/common-exceptions.c: Update.
4341         * common/new-op.c: Update.
4342         * common/selftest.c: Update.
4343         * compile/compile-c-symbols.c: Update.
4344         * compile/compile-cplus-symbols.c: Update.
4345         * compile/compile-object-load.c: Update.
4346         * compile/compile-object-run.c: Update.
4347         * completer.c: Update.
4348         * corelow.c: Update.
4349         * cp-abi.c: Update.
4350         * cp-support.c: Update.
4351         * cp-valprint.c: Update.
4352         * darwin-nat.c: Update.
4353         * disasm-selftests.c: Update.
4354         * dtrace-probe.c: Update.
4355         * dwarf-index-cache.c: Update.
4356         * dwarf-index-write.c: Update.
4357         * dwarf2-frame-tailcall.c: Update.
4358         * dwarf2-frame.c: Update.
4359         * dwarf2loc.c: Update.
4360         * dwarf2read.c: Update.
4361         * eval.c: Update.
4362         * event-loop.c: Update.
4363         * event-top.c: Update.
4364         * exec.c: Update.
4365         * f-valprint.c: Update.
4366         * fbsd-tdep.c: Update.
4367         * frame-unwind.c: Update.
4368         * frame.c: Update.
4369         * gdbtypes.c: Update.
4370         * gnu-v3-abi.c: Update.
4371         * guile/guile-internal.h: Update.
4372         * guile/scm-block.c: Update.
4373         * guile/scm-breakpoint.c: Update.
4374         * guile/scm-cmd.c: Update.
4375         * guile/scm-disasm.c: Update.
4376         * guile/scm-frame.c: Update.
4377         * guile/scm-lazy-string.c: Update.
4378         * guile/scm-math.c: Update.
4379         * guile/scm-param.c: Update.
4380         * guile/scm-ports.c: Update.
4381         * guile/scm-pretty-print.c: Update.
4382         * guile/scm-symbol.c: Update.
4383         * guile/scm-symtab.c: Update.
4384         * guile/scm-type.c: Update.
4385         * guile/scm-value.c: Update.
4386         * i386-linux-tdep.c: Update.
4387         * i386-tdep.c: Update.
4388         * inf-loop.c: Update.
4389         * infcall.c: Update.
4390         * infcmd.c: Update.
4391         * infrun.c: Update.
4392         * jit.c: Update.
4393         * language.c: Update.
4394         * linespec.c: Update.
4395         * linux-fork.c: Update.
4396         * linux-nat.c: Update.
4397         * linux-tdep.c: Update.
4398         * linux-thread-db.c: Update.
4399         * main.c: Update.
4400         * mi/mi-cmd-break.c: Update.
4401         * mi/mi-cmd-stack.c: Update.
4402         * mi/mi-interp.c: Update.
4403         * mi/mi-main.c: Update.
4404         * objc-lang.c: Update.
4405         * p-valprint.c: Update.
4406         * parse.c: Update.
4407         * ppc-linux-tdep.c: Update.
4408         * printcmd.c: Update.
4409         * python/py-arch.c: Update.
4410         * python/py-breakpoint.c: Update.
4411         * python/py-cmd.c: Update.
4412         * python/py-finishbreakpoint.c: Update.
4413         * python/py-frame.c: Update.
4414         * python/py-framefilter.c: Update.
4415         * python/py-gdb-readline.c: Update.
4416         * python/py-inferior.c: Update.
4417         * python/py-infthread.c: Update.
4418         * python/py-lazy-string.c: Update.
4419         * python/py-linetable.c: Update.
4420         * python/py-objfile.c: Update.
4421         * python/py-param.c: Update.
4422         * python/py-prettyprint.c: Update.
4423         * python/py-progspace.c: Update.
4424         * python/py-record-btrace.c: Update.
4425         * python/py-record.c: Update.
4426         * python/py-symbol.c: Update.
4427         * python/py-type.c: Update.
4428         * python/py-unwind.c: Update.
4429         * python/py-utils.c: Update.
4430         * python/py-value.c: Update.
4431         * python/python.c: Update.
4432         * record-btrace.c: Update.
4433         * record-full.c: Update.
4434         * remote-fileio.c: Update.
4435         * remote.c: Update.
4436         * riscv-tdep.c: Update.
4437         * rs6000-aix-tdep.c: Update.
4438         * rs6000-tdep.c: Update.
4439         * rust-exp.y: Update.
4440         * rust-lang.c: Update.
4441         * s390-tdep.c: Update.
4442         * selftest-arch.c: Update.
4443         * solib-dsbt.c: Update.
4444         * solib-frv.c: Update.
4445         * solib-spu.c: Update.
4446         * solib-svr4.c: Update.
4447         * solib.c: Update.
4448         * sparc64-linux-tdep.c: Update.
4449         * stack.c: Update.
4450         * symfile-mem.c: Update.
4451         * symmisc.c: Update.
4452         * target.c: Update.
4453         * thread.c: Update.
4454         * top.c: Update.
4455         * tracefile-tfile.c: Update.
4456         * tui/tui.c: Update.
4457         * typeprint.c: Update.
4458         * unittests/cli-utils-selftests.c: Update.
4459         * unittests/parse-connection-spec-selftests.c: Update.
4460         * valops.c: Update.
4461         * valprint.c: Update.
4462         * value.c: Update.
4463         * varobj.c: Update.
4464         * windows-nat.c: Update.
4465         * x86-linux-nat.c: Update.
4466         * xml-support.c: Update.
4467
4468 2019-04-08  Tom Tromey  <tom@tromey.com>
4469
4470         * xml-support.c: Use C++ exception handling.
4471         * x86-linux-nat.c: Use C++ exception handling.
4472         * windows-nat.c: Use C++ exception handling.
4473         * varobj.c: Use C++ exception handling.
4474         * value.c: Use C++ exception handling.
4475         * valprint.c: Use C++ exception handling.
4476         * valops.c: Use C++ exception handling.
4477         * unittests/parse-connection-spec-selftests.c: Use C++ exception
4478         handling.
4479         * unittests/cli-utils-selftests.c: Use C++ exception handling.
4480         * typeprint.c: Use C++ exception handling.
4481         * tui/tui.c: Use C++ exception handling.
4482         * tracefile-tfile.c: Use C++ exception handling.
4483         * top.c: Use C++ exception handling.
4484         * thread.c: Use C++ exception handling.
4485         * target.c: Use C++ exception handling.
4486         * symmisc.c: Use C++ exception handling.
4487         * symfile-mem.c: Use C++ exception handling.
4488         * stack.c: Use C++ exception handling.
4489         * sparc64-linux-tdep.c: Use C++ exception handling.
4490         * solib.c: Use C++ exception handling.
4491         * solib-svr4.c: Use C++ exception handling.
4492         * solib-spu.c: Use C++ exception handling.
4493         * solib-frv.c: Use C++ exception handling.
4494         * solib-dsbt.c: Use C++ exception handling.
4495         * selftest-arch.c: Use C++ exception handling.
4496         * s390-tdep.c: Use C++ exception handling.
4497         * rust-lang.c: Use C++ exception handling.
4498         * rust-exp.y: Use C++ exception handling.
4499         * rs6000-tdep.c: Use C++ exception handling.
4500         * rs6000-aix-tdep.c: Use C++ exception handling.
4501         * riscv-tdep.c: Use C++ exception handling.
4502         * remote.c: Use C++ exception handling.
4503         * remote-fileio.c: Use C++ exception handling.
4504         * record-full.c: Use C++ exception handling.
4505         * record-btrace.c: Use C++ exception handling.
4506         * python/python.c: Use C++ exception handling.
4507         * python/py-value.c: Use C++ exception handling.
4508         * python/py-utils.c: Use C++ exception handling.
4509         * python/py-unwind.c: Use C++ exception handling.
4510         * python/py-type.c: Use C++ exception handling.
4511         * python/py-symbol.c: Use C++ exception handling.
4512         * python/py-record.c: Use C++ exception handling.
4513         * python/py-record-btrace.c: Use C++ exception handling.
4514         * python/py-progspace.c: Use C++ exception handling.
4515         * python/py-prettyprint.c: Use C++ exception handling.
4516         * python/py-param.c: Use C++ exception handling.
4517         * python/py-objfile.c: Use C++ exception handling.
4518         * python/py-linetable.c: Use C++ exception handling.
4519         * python/py-lazy-string.c: Use C++ exception handling.
4520         * python/py-infthread.c: Use C++ exception handling.
4521         * python/py-inferior.c: Use C++ exception handling.
4522         * python/py-gdb-readline.c: Use C++ exception handling.
4523         * python/py-framefilter.c: Use C++ exception handling.
4524         * python/py-frame.c: Use C++ exception handling.
4525         * python/py-finishbreakpoint.c: Use C++ exception handling.
4526         * python/py-cmd.c: Use C++ exception handling.
4527         * python/py-breakpoint.c: Use C++ exception handling.
4528         * python/py-arch.c: Use C++ exception handling.
4529         * printcmd.c: Use C++ exception handling.
4530         * ppc-linux-tdep.c: Use C++ exception handling.
4531         * parse.c: Use C++ exception handling.
4532         * p-valprint.c: Use C++ exception handling.
4533         * objc-lang.c: Use C++ exception handling.
4534         * mi/mi-main.c: Use C++ exception handling.
4535         * mi/mi-interp.c: Use C++ exception handling.
4536         * mi/mi-cmd-stack.c: Use C++ exception handling.
4537         * mi/mi-cmd-break.c: Use C++ exception handling.
4538         * main.c: Use C++ exception handling.
4539         * linux-thread-db.c: Use C++ exception handling.
4540         * linux-tdep.c: Use C++ exception handling.
4541         * linux-nat.c: Use C++ exception handling.
4542         * linux-fork.c: Use C++ exception handling.
4543         * linespec.c: Use C++ exception handling.
4544         * language.c: Use C++ exception handling.
4545         * jit.c: Use C++ exception handling.
4546         * infrun.c: Use C++ exception handling.
4547         * infcmd.c: Use C++ exception handling.
4548         * infcall.c: Use C++ exception handling.
4549         * inf-loop.c: Use C++ exception handling.
4550         * i386-tdep.c: Use C++ exception handling.
4551         * i386-linux-tdep.c: Use C++ exception handling.
4552         * guile/scm-value.c: Use C++ exception handling.
4553         * guile/scm-type.c: Use C++ exception handling.
4554         * guile/scm-symtab.c: Use C++ exception handling.
4555         * guile/scm-symbol.c: Use C++ exception handling.
4556         * guile/scm-pretty-print.c: Use C++ exception handling.
4557         * guile/scm-ports.c: Use C++ exception handling.
4558         * guile/scm-param.c: Use C++ exception handling.
4559         * guile/scm-math.c: Use C++ exception handling.
4560         * guile/scm-lazy-string.c: Use C++ exception handling.
4561         * guile/scm-frame.c: Use C++ exception handling.
4562         * guile/scm-disasm.c: Use C++ exception handling.
4563         * guile/scm-cmd.c: Use C++ exception handling.
4564         * guile/scm-breakpoint.c: Use C++ exception handling.
4565         * guile/scm-block.c: Use C++ exception handling.
4566         * guile/guile-internal.h: Use C++ exception handling.
4567         * gnu-v3-abi.c: Use C++ exception handling.
4568         * gdbtypes.c: Use C++ exception handling.
4569         * frame.c: Use C++ exception handling.
4570         * frame-unwind.c: Use C++ exception handling.
4571         * fbsd-tdep.c: Use C++ exception handling.
4572         * f-valprint.c: Use C++ exception handling.
4573         * exec.c: Use C++ exception handling.
4574         * event-top.c: Use C++ exception handling.
4575         * event-loop.c: Use C++ exception handling.
4576         * eval.c: Use C++ exception handling.
4577         * dwarf2read.c: Use C++ exception handling.
4578         * dwarf2loc.c: Use C++ exception handling.
4579         * dwarf2-frame.c: Use C++ exception handling.
4580         * dwarf2-frame-tailcall.c: Use C++ exception handling.
4581         * dwarf-index-write.c: Use C++ exception handling.
4582         * dwarf-index-cache.c: Use C++ exception handling.
4583         * dtrace-probe.c: Use C++ exception handling.
4584         * disasm-selftests.c: Use C++ exception handling.
4585         * darwin-nat.c: Use C++ exception handling.
4586         * cp-valprint.c: Use C++ exception handling.
4587         * cp-support.c: Use C++ exception handling.
4588         * cp-abi.c: Use C++ exception handling.
4589         * corelow.c: Use C++ exception handling.
4590         * completer.c: Use C++ exception handling.
4591         * compile/compile-object-run.c: Use C++ exception handling.
4592         * compile/compile-object-load.c: Use C++ exception handling.
4593         * compile/compile-cplus-symbols.c: Use C++ exception handling.
4594         * compile/compile-c-symbols.c: Use C++ exception handling.
4595         * common/selftest.c: Use C++ exception handling.
4596         * common/new-op.c: Use C++ exception handling.
4597         * cli/cli-script.c: Use C++ exception handling.
4598         * cli/cli-interp.c: Use C++ exception handling.
4599         * cli/cli-cmds.c: Use C++ exception handling.
4600         * c-varobj.c: Use C++ exception handling.
4601         * btrace.c: Use C++ exception handling.
4602         * breakpoint.c: Use C++ exception handling.
4603         * break-catch-throw.c: Use C++ exception handling.
4604         * arch-utils.c: Use C++ exception handling.
4605         * amd64-tdep.c: Use C++ exception handling.
4606         * ada-valprint.c: Use C++ exception handling.
4607         * ada-typeprint.c: Use C++ exception handling.
4608         * ada-lang.c: Use C++ exception handling.
4609         * aarch64-tdep.c: Use C++ exception handling.
4610
4611 2019-04-08  Tom Tromey  <tom@tromey.com>
4612
4613         * xml-support.c (gdb_xml_parser::parse): Update.
4614         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4615         * value.c (show_convenience): Update.
4616         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
4617         (test_parse_flags_qcs): Update.
4618         * thread.c (thr_try_catch_cmd): Update.
4619         * target.c (target_translate_tls_address): Update.
4620         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4621         (info_frame_command_core, frame_apply_command_count): Update.
4622         * rust-exp.y (rust_lex_exception_test): Update.
4623         * riscv-tdep.c (riscv_print_one_register_info): Update.
4624         * remote.c (remote_target::enable_btrace): Update.
4625         * record-btrace.c (record_btrace_enable_warn): Update.
4626         * python/py-utils.c (gdbpy_convert_exception): Update.
4627         * printcmd.c (do_one_display, print_variable_and_value): Update.
4628         * mi/mi-main.c (mi_print_exception): Update.
4629         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
4630         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4631         * linux-nat.c (linux_nat_target::attach): Update.
4632         * linux-fork.c (class scoped_switch_fork_info): Update.
4633         * infrun.c (displaced_step_prepare): Update.
4634         * infcall.c (call_function_by_hand_dummy): Update.
4635         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
4636         * gnu-v3-abi.c (print_one_vtable): Update.
4637         * frame.c (get_prev_frame_always): Update.
4638         * f-valprint.c (info_common_command_for_block): Update.
4639         * exec.c (try_open_exec_file): Update.
4640         * exceptions.c (print_exception, exception_print)
4641         (exception_fprintf, exception_print_same): Update.
4642         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
4643         * dwarf-index-cache.c (index_cache::store)
4644         (index_cache::lookup_gdb_index): Update.
4645         * darwin-nat.c (maybe_cache_shell): Update.
4646         * cp-valprint.c (cp_print_value_fields): Update.
4647         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
4648         (gcc_cplus_symbol_address): Update.
4649         * compile/compile-c-symbols.c (gcc_convert_symbol)
4650         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
4651         * common/selftest.c: Update.
4652         * common/common-exceptions.h (struct gdb_exception) <message>: Now
4653         a std::string.
4654         (exception_try_scope_entry, exception_try_scope_exit): Don't
4655         declare.
4656         (struct exception_try_scope): Remove.
4657         (TRY): Don't use exception_try_scope.
4658         (struct gdb_exception): Add constructor, operator=.
4659         <what>: New method.
4660         (struct gdb_exception_RETURN_MASK_ALL)
4661         (struct gdb_exception_RETURN_MASK_ERROR)
4662         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
4663         (struct gdb_quit_bad_alloc): Update.
4664         * common/common-exceptions.c (exception_none): Change
4665         initializer.
4666         (struct catcher) <state, exception>: Initialize inline.
4667         <prev>: Remove member.
4668         (current_catcher): Remove.
4669         (catchers): New global.
4670         (exceptions_state_mc_init): Simplify.
4671         (catcher_pop): Remove.
4672         (exceptions_state_mc, exceptions_state_mc_catch): Update.
4673         (try_scope_depth, exception_try_scope_entry)
4674         (exception_try_scope_exit): Remove.
4675         (throw_exception_sjlj): Update.
4676         (exception_messages, exception_messages_size): Remove.
4677         (throw_it): Simplify.
4678         (gdb_exception_sliced_copy): Remove.
4679         (throw_exception_cxx): Update.
4680         * cli/cli-script.c (script_from_file): Update.
4681         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
4682         Update.
4683         * ada-valprint.c (ada_val_print): Update.
4684         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
4685         (create_excep_cond_exprs): Update.
4686
4687 2019-04-08  Tom Tromey  <tom@tromey.com>
4688
4689         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
4690         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
4691         (TRY, CATCH, END_CATCH): Remove some definitions.
4692         * common/common-exceptions.c: Don't use GDB_XCPT.
4693         (catcher_list_size): Remove.
4694         (throw_exception, throw_it): Simplify.
4695
4696 2019-04-05  Tom Tromey  <tom@tromey.com>
4697
4698         Revert the header-sorting patch.
4699         * ft32-tdep.c: Revert.
4700         * frv-tdep.c: Revert.
4701         * frv-linux-tdep.c: Revert.
4702         * frame.c: Revert.
4703         * frame-unwind.c: Revert.
4704         * frame-base.c: Revert.
4705         * fork-child.c: Revert.
4706         * findvar.c: Revert.
4707         * findcmd.c: Revert.
4708         * filesystem.c: Revert.
4709         * filename-seen-cache.h: Revert.
4710         * filename-seen-cache.c: Revert.
4711         * fbsd-tdep.c: Revert.
4712         * fbsd-nat.h: Revert.
4713         * fbsd-nat.c: Revert.
4714         * f-valprint.c: Revert.
4715         * f-typeprint.c: Revert.
4716         * f-lang.c: Revert.
4717         * extension.h: Revert.
4718         * extension.c: Revert.
4719         * extension-priv.h: Revert.
4720         * expprint.c: Revert.
4721         * exec.h: Revert.
4722         * exec.c: Revert.
4723         * exceptions.c: Revert.
4724         * event-top.c: Revert.
4725         * event-loop.c: Revert.
4726         * eval.c: Revert.
4727         * elfread.c: Revert.
4728         * dwarf2read.h: Revert.
4729         * dwarf2read.c: Revert.
4730         * dwarf2loc.c: Revert.
4731         * dwarf2expr.h: Revert.
4732         * dwarf2expr.c: Revert.
4733         * dwarf2-frame.c: Revert.
4734         * dwarf2-frame-tailcall.c: Revert.
4735         * dwarf-index-write.h: Revert.
4736         * dwarf-index-write.c: Revert.
4737         * dwarf-index-common.c: Revert.
4738         * dwarf-index-cache.h: Revert.
4739         * dwarf-index-cache.c: Revert.
4740         * dummy-frame.c: Revert.
4741         * dtrace-probe.c: Revert.
4742         * disasm.h: Revert.
4743         * disasm.c: Revert.
4744         * disasm-selftests.c: Revert.
4745         * dictionary.c: Revert.
4746         * dicos-tdep.c: Revert.
4747         * demangle.c: Revert.
4748         * dcache.h: Revert.
4749         * dcache.c: Revert.
4750         * darwin-nat.h: Revert.
4751         * darwin-nat.c: Revert.
4752         * darwin-nat-info.c: Revert.
4753         * d-valprint.c: Revert.
4754         * d-namespace.c: Revert.
4755         * d-lang.c: Revert.
4756         * ctf.c: Revert.
4757         * csky-tdep.c: Revert.
4758         * csky-linux-tdep.c: Revert.
4759         * cris-tdep.c: Revert.
4760         * cris-linux-tdep.c: Revert.
4761         * cp-valprint.c: Revert.
4762         * cp-support.c: Revert.
4763         * cp-namespace.c: Revert.
4764         * cp-abi.c: Revert.
4765         * corelow.c: Revert.
4766         * corefile.c: Revert.
4767         * continuations.c: Revert.
4768         * completer.h: Revert.
4769         * completer.c: Revert.
4770         * complaints.c: Revert.
4771         * coffread.c: Revert.
4772         * coff-pe-read.c: Revert.
4773         * cli-out.h: Revert.
4774         * cli-out.c: Revert.
4775         * charset.c: Revert.
4776         * c-varobj.c: Revert.
4777         * c-valprint.c: Revert.
4778         * c-typeprint.c: Revert.
4779         * c-lang.c: Revert.
4780         * buildsym.c: Revert.
4781         * buildsym-legacy.c: Revert.
4782         * build-id.h: Revert.
4783         * build-id.c: Revert.
4784         * btrace.c: Revert.
4785         * bsd-uthread.c: Revert.
4786         * breakpoint.h: Revert.
4787         * breakpoint.c: Revert.
4788         * break-catch-throw.c: Revert.
4789         * break-catch-syscall.c: Revert.
4790         * break-catch-sig.c: Revert.
4791         * blockframe.c: Revert.
4792         * block.c: Revert.
4793         * bfin-tdep.c: Revert.
4794         * bfin-linux-tdep.c: Revert.
4795         * bfd-target.c: Revert.
4796         * bcache.c: Revert.
4797         * ax-general.c: Revert.
4798         * ax-gdb.h: Revert.
4799         * ax-gdb.c: Revert.
4800         * avr-tdep.c: Revert.
4801         * auxv.c: Revert.
4802         * auto-load.c: Revert.
4803         * arm-wince-tdep.c: Revert.
4804         * arm-tdep.c: Revert.
4805         * arm-symbian-tdep.c: Revert.
4806         * arm-pikeos-tdep.c: Revert.
4807         * arm-obsd-tdep.c: Revert.
4808         * arm-nbsd-tdep.c: Revert.
4809         * arm-nbsd-nat.c: Revert.
4810         * arm-linux-tdep.c: Revert.
4811         * arm-linux-nat.c: Revert.
4812         * arm-fbsd-tdep.c: Revert.
4813         * arm-fbsd-nat.c: Revert.
4814         * arm-bsd-tdep.c: Revert.
4815         * arch-utils.c: Revert.
4816         * arc-tdep.c: Revert.
4817         * arc-newlib-tdep.c: Revert.
4818         * annotate.h: Revert.
4819         * annotate.c: Revert.
4820         * amd64-windows-tdep.c: Revert.
4821         * amd64-windows-nat.c: Revert.
4822         * amd64-tdep.c: Revert.
4823         * amd64-sol2-tdep.c: Revert.
4824         * amd64-obsd-tdep.c: Revert.
4825         * amd64-obsd-nat.c: Revert.
4826         * amd64-nbsd-tdep.c: Revert.
4827         * amd64-nbsd-nat.c: Revert.
4828         * amd64-nat.c: Revert.
4829         * amd64-linux-tdep.c: Revert.
4830         * amd64-linux-nat.c: Revert.
4831         * amd64-fbsd-tdep.c: Revert.
4832         * amd64-fbsd-nat.c: Revert.
4833         * amd64-dicos-tdep.c: Revert.
4834         * amd64-darwin-tdep.c: Revert.
4835         * amd64-bsd-nat.c: Revert.
4836         * alpha-tdep.c: Revert.
4837         * alpha-obsd-tdep.c: Revert.
4838         * alpha-nbsd-tdep.c: Revert.
4839         * alpha-mdebug-tdep.c: Revert.
4840         * alpha-linux-tdep.c: Revert.
4841         * alpha-linux-nat.c: Revert.
4842         * alpha-bsd-tdep.c: Revert.
4843         * alpha-bsd-nat.c: Revert.
4844         * aix-thread.c: Revert.
4845         * agent.c: Revert.
4846         * addrmap.c: Revert.
4847         * ada-varobj.c: Revert.
4848         * ada-valprint.c: Revert.
4849         * ada-typeprint.c: Revert.
4850         * ada-tasks.c: Revert.
4851         * ada-lang.c: Revert.
4852         * aarch64-tdep.c: Revert.
4853         * aarch64-ravenscar-thread.c: Revert.
4854         * aarch64-newlib-tdep.c: Revert.
4855         * aarch64-linux-tdep.c: Revert.
4856         * aarch64-linux-nat.c: Revert.
4857         * aarch64-fbsd-tdep.c: Revert.
4858         * aarch64-fbsd-nat.c: Revert.
4859         * aarch32-linux-nat.c: Revert.
4860
4861 2019-04-05  Tom Tromey  <tom@tromey.com>
4862
4863         * ft32-tdep.c: Sort headers.
4864         * frv-tdep.c: Sort headers.
4865         * frv-linux-tdep.c: Sort headers.
4866         * frame.c: Sort headers.
4867         * frame-unwind.c: Sort headers.
4868         * frame-base.c: Sort headers.
4869         * fork-child.c: Sort headers.
4870         * findvar.c: Sort headers.
4871         * findcmd.c: Sort headers.
4872         * filesystem.c: Sort headers.
4873         * filename-seen-cache.h: Sort headers.
4874         * filename-seen-cache.c: Sort headers.
4875         * fbsd-tdep.c: Sort headers.
4876         * fbsd-nat.h: Sort headers.
4877         * fbsd-nat.c: Sort headers.
4878         * f-valprint.c: Sort headers.
4879         * f-typeprint.c: Sort headers.
4880         * f-lang.c: Sort headers.
4881         * extension.h: Sort headers.
4882         * extension.c: Sort headers.
4883         * extension-priv.h: Sort headers.
4884         * expprint.c: Sort headers.
4885         * exec.h: Sort headers.
4886         * exec.c: Sort headers.
4887         * exceptions.c: Sort headers.
4888         * event-top.c: Sort headers.
4889         * event-loop.c: Sort headers.
4890         * eval.c: Sort headers.
4891         * elfread.c: Sort headers.
4892         * dwarf2read.h: Sort headers.
4893         * dwarf2read.c: Sort headers.
4894         * dwarf2loc.c: Sort headers.
4895         * dwarf2expr.h: Sort headers.
4896         * dwarf2expr.c: Sort headers.
4897         * dwarf2-frame.c: Sort headers.
4898         * dwarf2-frame-tailcall.c: Sort headers.
4899         * dwarf-index-write.h: Sort headers.
4900         * dwarf-index-write.c: Sort headers.
4901         * dwarf-index-common.c: Sort headers.
4902         * dwarf-index-cache.h: Sort headers.
4903         * dwarf-index-cache.c: Sort headers.
4904         * dummy-frame.c: Sort headers.
4905         * dtrace-probe.c: Sort headers.
4906         * disasm.h: Sort headers.
4907         * disasm.c: Sort headers.
4908         * disasm-selftests.c: Sort headers.
4909         * dictionary.c: Sort headers.
4910         * dicos-tdep.c: Sort headers.
4911         * demangle.c: Sort headers.
4912         * dcache.h: Sort headers.
4913         * dcache.c: Sort headers.
4914         * darwin-nat.h: Sort headers.
4915         * darwin-nat.c: Sort headers.
4916         * darwin-nat-info.c: Sort headers.
4917         * d-valprint.c: Sort headers.
4918         * d-namespace.c: Sort headers.
4919         * d-lang.c: Sort headers.
4920         * ctf.c: Sort headers.
4921         * csky-tdep.c: Sort headers.
4922         * csky-linux-tdep.c: Sort headers.
4923         * cris-tdep.c: Sort headers.
4924         * cris-linux-tdep.c: Sort headers.
4925         * cp-valprint.c: Sort headers.
4926         * cp-support.c: Sort headers.
4927         * cp-namespace.c: Sort headers.
4928         * cp-abi.c: Sort headers.
4929         * corelow.c: Sort headers.
4930         * corefile.c: Sort headers.
4931         * continuations.c: Sort headers.
4932         * completer.h: Sort headers.
4933         * completer.c: Sort headers.
4934         * complaints.c: Sort headers.
4935         * coffread.c: Sort headers.
4936         * coff-pe-read.c: Sort headers.
4937         * cli-out.h: Sort headers.
4938         * cli-out.c: Sort headers.
4939         * charset.c: Sort headers.
4940         * c-varobj.c: Sort headers.
4941         * c-valprint.c: Sort headers.
4942         * c-typeprint.c: Sort headers.
4943         * c-lang.c: Sort headers.
4944         * buildsym.c: Sort headers.
4945         * buildsym-legacy.c: Sort headers.
4946         * build-id.h: Sort headers.
4947         * build-id.c: Sort headers.
4948         * btrace.c: Sort headers.
4949         * bsd-uthread.c: Sort headers.
4950         * breakpoint.h: Sort headers.
4951         * breakpoint.c: Sort headers.
4952         * break-catch-throw.c: Sort headers.
4953         * break-catch-syscall.c: Sort headers.
4954         * break-catch-sig.c: Sort headers.
4955         * blockframe.c: Sort headers.
4956         * block.c: Sort headers.
4957         * bfin-tdep.c: Sort headers.
4958         * bfin-linux-tdep.c: Sort headers.
4959         * bfd-target.c: Sort headers.
4960         * bcache.c: Sort headers.
4961         * ax-general.c: Sort headers.
4962         * ax-gdb.h: Sort headers.
4963         * ax-gdb.c: Sort headers.
4964         * avr-tdep.c: Sort headers.
4965         * auxv.c: Sort headers.
4966         * auto-load.c: Sort headers.
4967         * arm-wince-tdep.c: Sort headers.
4968         * arm-tdep.c: Sort headers.
4969         * arm-symbian-tdep.c: Sort headers.
4970         * arm-pikeos-tdep.c: Sort headers.
4971         * arm-obsd-tdep.c: Sort headers.
4972         * arm-nbsd-tdep.c: Sort headers.
4973         * arm-nbsd-nat.c: Sort headers.
4974         * arm-linux-tdep.c: Sort headers.
4975         * arm-linux-nat.c: Sort headers.
4976         * arm-fbsd-tdep.c: Sort headers.
4977         * arm-fbsd-nat.c: Sort headers.
4978         * arm-bsd-tdep.c: Sort headers.
4979         * arch-utils.c: Sort headers.
4980         * arc-tdep.c: Sort headers.
4981         * arc-newlib-tdep.c: Sort headers.
4982         * annotate.h: Sort headers.
4983         * annotate.c: Sort headers.
4984         * amd64-windows-tdep.c: Sort headers.
4985         * amd64-windows-nat.c: Sort headers.
4986         * amd64-tdep.c: Sort headers.
4987         * amd64-sol2-tdep.c: Sort headers.
4988         * amd64-obsd-tdep.c: Sort headers.
4989         * amd64-obsd-nat.c: Sort headers.
4990         * amd64-nbsd-tdep.c: Sort headers.
4991         * amd64-nbsd-nat.c: Sort headers.
4992         * amd64-nat.c: Sort headers.
4993         * amd64-linux-tdep.c: Sort headers.
4994         * amd64-linux-nat.c: Sort headers.
4995         * amd64-fbsd-tdep.c: Sort headers.
4996         * amd64-fbsd-nat.c: Sort headers.
4997         * amd64-dicos-tdep.c: Sort headers.
4998         * amd64-darwin-tdep.c: Sort headers.
4999         * amd64-bsd-nat.c: Sort headers.
5000         * alpha-tdep.c: Sort headers.
5001         * alpha-obsd-tdep.c: Sort headers.
5002         * alpha-nbsd-tdep.c: Sort headers.
5003         * alpha-mdebug-tdep.c: Sort headers.
5004         * alpha-linux-tdep.c: Sort headers.
5005         * alpha-linux-nat.c: Sort headers.
5006         * alpha-bsd-tdep.c: Sort headers.
5007         * alpha-bsd-nat.c: Sort headers.
5008         * aix-thread.c: Sort headers.
5009         * agent.c: Sort headers.
5010         * addrmap.c: Sort headers.
5011         * ada-varobj.c: Sort headers.
5012         * ada-valprint.c: Sort headers.
5013         * ada-typeprint.c: Sort headers.
5014         * ada-tasks.c: Sort headers.
5015         * ada-lang.c: Sort headers.
5016         * aarch64-tdep.c: Sort headers.
5017         * aarch64-ravenscar-thread.c: Sort headers.
5018         * aarch64-newlib-tdep.c: Sort headers.
5019         * aarch64-linux-tdep.c: Sort headers.
5020         * aarch64-linux-nat.c: Sort headers.
5021         * aarch64-fbsd-tdep.c: Sort headers.
5022         * aarch64-fbsd-nat.c: Sort headers.
5023         * aarch32-linux-nat.c: Sort headers.
5024
5025 2019-04-04  Tom Tromey  <tom@tromey.com>
5026
5027         * varobj.c (varobj_create): Update.
5028         * rust-exp.y (struct rust_parser) <update_innermost_block,
5029         lookup_symbol>: New methods.
5030         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5031         Rename.
5032         (rust_parser::rust_lookup_type)
5033         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5034         * printcmd.c (display_command, do_one_display): Update.
5035         * parser-defs.h (struct parser_state) <parser_state>: Add
5036         "tracker" parameter.
5037         (block_tracker): New member.
5038         (class innermost_block_tracker) <innermost_block_tracker>: Add
5039         "types" parameter.
5040         <reset>: Remove method.
5041         (innermost_block): Don't declare.
5042         (null_post_parser): Update.
5043         * parse.c (innermost_block): Remove global.
5044         (write_dollar_variable): Update.
5045         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5046         Remove "tracker_types" parameter.
5047         (parse_expression): Add "tracker" parameter.
5048         (parse_expression_for_completion): Update.
5049         (null_post_parser): Add "tracker" parameter.
5050         * p-exp.y: Update rules.
5051         * m2-exp.y: Update rules.
5052         * language.h (struct language_defn) <la_post_parser>: Add
5053         "tracker" parameter.
5054         * go-exp.y: Update rules.
5055         * f-exp.y: Update rules.
5056         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5057         parameter.
5058         * d-exp.y: Update rules.
5059         * c-exp.y: Update rules.
5060         * breakpoint.c (set_breakpoint_condition): Create an
5061         innermost_block_tracker.
5062         (watch_command_1): Likewise.
5063         * ada-lang.c (resolve): Add "tracker" parameter.
5064         (resolve_subexp): Likewise.
5065         * ada-exp.y (write_var_from_sym): Update.
5066
5067 2019-04-04  Tom Tromey  <tom@tromey.com>
5068
5069         * type-stack.h: New file.
5070         * type-stack.c: New file.
5071         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5072         type-stack.h.
5073         (insert_into_type_stack, insert_type, push_type, push_type_int)
5074         (insert_type_address_space, pop_type, pop_type_int)
5075         (pop_typelist, pop_type_stack, append_type_stack)
5076         (push_type_stack, get_type_stack, push_typelist)
5077         (follow_type_instance_flags, follow_types): Don't declare.
5078         * parse.c (type_stack): Remove global.
5079         (parse_exp_in_context): Update.
5080         (insert_into_type_stack, insert_type, push_type, push_type_int)
5081         (insert_type_address_space, pop_type, pop_type_int)
5082         (pop_typelist, pop_type_stack, append_type_stack)
5083         (push_type_stack, get_type_stack, push_typelist)
5084         (follow_type_instance_flags, follow_types): Remove (moved to
5085         type-stack.c).
5086         * f-exp.y (type_stack): New global.
5087         Update rules.
5088         (push_kind_type, f_parse): Update.
5089         * d-exp.y (type_stack): New global.
5090         Update rules.
5091         (d_parse): Update.
5092         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5093         Update rules.
5094         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5095         (HFILES_NO_SRCDIR): Add type-stack.h.
5096
5097 2019-04-04  Tom Tromey  <tom@tromey.com>
5098
5099         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5100         (rust_parser::convert_ast_to_expression, rust_parse)
5101         (rust_lex_test_completion, rust_lex_tests): Update.
5102         * parser-defs.h (struct expr_completion_state): New.
5103         (struct parser_state) <parser_state>: Add completion parameter.
5104         <mark_struct_expression, mark_completion_tag>: New methods.
5105         <parse_completion, m_completion_state>: New members.
5106         (prefixify_expression, null_post_parser): Update.
5107         (mark_struct_expression, mark_completion_tag): Don't declare.
5108         * parse.c (parse_completion, expout_last_struct)
5109         (expout_tag_completion_type, expout_completion_name): Remove
5110         globals.
5111         (parser_state::mark_struct_expression)
5112         (parser_state::mark_completion_tag): Now methods.
5113         (prefixify_expression): Add last_struct parameter.
5114         (prefixify_subexp): Likewise.
5115         (parse_exp_1): Update.
5116         (parse_exp_in_context): Add cstate parameter.  Update.
5117         (parse_expression_for_completion): Create an
5118         expr_completion_state.
5119         (null_post_parser): Add "completion" parameter.
5120         * p-exp.y: Update rules.
5121         (yylex): Update.
5122         * language.h (struct language_defn) <la_post_parser>: Add
5123         "completing" parameter.
5124         * go-exp.y: Update rules.
5125         (lex_one_token): Update.
5126         * expression.h (parse_completion): Don't declare.
5127         * d-exp.y: Update rules.
5128         (lex_one_token): Update rules.
5129         * c-exp.y: Update rules.
5130         (lex_one_token): Update.
5131         * ada-lang.c (resolve): Add "parse_completion" parameter.
5132         (resolve_subexp): Likewise.
5133         (ada_resolve_function): Likewise.
5134
5135 2019-04-04  Tom Tromey  <tom@tromey.com>
5136
5137         * parser-defs.h (struct parser_state) <start_arglist,
5138         end_arglist>: New methods.
5139         <arglist_len, m_funcall_chain>: New members.
5140         (arglist_len, start_arglist, end_arglist): Don't declare.
5141         * parse.c (arglist_len, funcall_chain): Remove global.
5142         (start_arglist, end_arglist): Remove functions.
5143         (parse_exp_in_context): Update.
5144         * p-exp.y: Update rules.
5145         * m2-exp.y: Update rules.
5146         * go-exp.y: Update rules.
5147         * f-exp.y: Update rules.
5148         * d-exp.y: Update rules.
5149         * c-exp.y: Update rules.
5150
5151 2019-04-04  Tom Tromey  <tom@tromey.com>
5152
5153         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
5154         lex_operator, push_back>: New methods.
5155         Update all rules.
5156         (rust_parser::lex_hex, lex_escape): Rename and update.
5157         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
5158         (rust_parser::lex_operator): Rename and update.
5159         (rust_parser::lex_number, rustyylex, rustyyerror)
5160         (rust_lex_test_init, rust_lex_test_sequence)
5161         (rust_lex_test_push_back, rust_lex_tests): Update.
5162         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
5163         parameter.
5164         <lexptr, prev_lexptr>: New members.
5165         (lexptr, prev_lexptr): Don't declare.
5166         * parse.c (lexptr, prev_lexptr): Remove globals.
5167         (parse_exp_in_context): Update.
5168         * p-exp.y (yylex, yyerror): Update.
5169         * m2-exp.y (parse_number, yylex, yyerror): Update.
5170         * go-exp.y (lex_one_token, yyerror): Update.
5171         * f-exp.y (match_string_literal, yylex, yyerror): Update.
5172         * d-exp.y (lex_one_token, yyerror): Update.
5173         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
5174         (lex_one_token, yyerror): Update.
5175         * ada-lex.l (YY_INPUT): Update.
5176         (rewind_to_char): Update.
5177         * ada-exp.y (yyerror): Update.
5178
5179 2019-04-04  Tom Tromey  <tom@tromey.com>
5180
5181         * rust-exp.y (rustyylex, rust_lex_tests): Update.
5182         * parser-defs.h (struct parser_state) <parser_state>: Add new
5183         parameter.
5184         <comma_terminates>: New member.
5185         (comma_terminates): Don't declare global.
5186         * parse.c (comma_terminates): Remove global.
5187         (parse_exp_in_context): Update.
5188         * p-exp.y (yylex): Update.
5189         * m2-exp.y (yylex): Update.
5190         * go-exp.y (lex_one_token): Update.
5191         * f-exp.y (yylex): Update.
5192         * d-exp.y (lex_one_token): Update.
5193         * c-exp.y (lex_one_token): Update.
5194         * ada-lex.l: Update.
5195
5196 2019-04-04  Tom Tromey  <tom@tromey.com>
5197
5198         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
5199         (rustyylex, rust_lex_test_init, rust_lex_test_one)
5200         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
5201         * parser-defs.h (paren_depth): Don't declare.
5202         * parse.c (paren_depth): Remove global.
5203         (parse_exp_in_context): Update.
5204         * p-exp.y (paren_depth): New global.
5205         (pascal_parse): Initialize it.
5206         * m2-exp.y (paren_depth): New global.
5207         (m2_parse): Initialize it.
5208         * go-exp.y (paren_depth): New global.
5209         (go_parse): Initialize it.
5210         * f-exp.y (paren_depth): New global.
5211         (f_parse): Initialize it.
5212         * d-exp.y (paren_depth): New global.
5213         (d_parse): Initialize it.
5214         * c-exp.y (paren_depth): New global.
5215         (c_parse): Initialize it.
5216         * ada-lex.l (paren_depth): New global.
5217         (lexer_init): Initialize it.
5218
5219 2019-04-04  Tom Tromey  <tom@tromey.com>
5220
5221         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
5222         (rust_parser::convert_ast_to_type)
5223         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5224         * parser-defs.h (struct parser_state) <parser_state>: Add
5225         parameters.  Initialize new members.
5226         <expression_context_block, expression_context_pc>: New members.
5227         * parse.c (expression_context_block, expression_context_pc):
5228         Remove globals.
5229         (parse_exp_in_context): Update.
5230         * p-exp.y: Update all rules.
5231         (yylex): Update.
5232         * m2-exp.y: Update all rules.
5233         (yylex): Update.
5234         * go-exp.y (yylex): Update.
5235         * f-exp.y (yylex): Update.
5236         * d-exp.y: Update all rules.
5237         (yylex): Update.
5238         * c-exp.y: Update all rules.
5239         (lex_one_token, classify_name, yylex, c_parse): Update.
5240         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
5241
5242 2019-04-04  Tom Tromey  <tom@tromey.com>
5243
5244         * gdbarch.h, gdbarch.c: Rebuild.
5245         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
5246         * stap-probe.h:
5247         (struct stap_parse_info): Replace "parser_state" with
5248         "expr_builder".
5249         * parser-defs.h (struct expr_builder): Rename from "parser_state".
5250         (parser_state): New class.
5251         * parse.c (expr_builder): Rename.
5252         (expr_builder::release): Rename.
5253         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
5254         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
5255         (write_exp_elt_longcst, write_exp_elt_floatcst)
5256         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
5257         (write_exp_string_vector, write_exp_bitstring)
5258         (write_exp_msymbol, mark_struct_expression)
5259         (write_dollar_variable)
5260         (insert_type_address_space, increase_expout_size): Replace
5261         "parser_state" with "expr_builder".
5262         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
5263         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
5264         "parser_state" with "expr_builder".
5265
5266 2019-04-04  Tom Tromey  <tom@tromey.com>
5267
5268         * rust-exp.y: Replace "parse_language" with method call.
5269         * p-exp.y:
5270         (yylex): Replace "parse_language" with method call.
5271         * m2-exp.y:
5272         (yylex): Replace "parse_language" with method call.
5273         * go-exp.y (classify_name): Replace "parse_language" with method
5274         call.
5275         * f-exp.y (yylex): Replace "parse_language" with method call.
5276         * d-exp.y (lex_one_token): Replace "parse_language" with method
5277         call.
5278         * c-exp.y:
5279         (lex_one_token, classify_name, yylex): Replace "parse_language"
5280         with method call.
5281         * ada-exp.y (find_primitive_type, type_char)
5282         (type_system_address): Replace "parse_language" with method call.
5283
5284 2019-04-04  Tom Tromey  <tom@tromey.com>
5285
5286         * rust-exp.y: Replace "parse_gdbarch" with method call.
5287         * parse.c (write_dollar_variable, insert_type_address_space):
5288         Replace "parse_gdbarch" with method call.
5289         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
5290         call.
5291         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
5292         call.
5293         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
5294         "parse_gdbarch" with method call.
5295         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
5296         with method call.
5297         * f-exp.y (parse_type, parse_f_type, yylex): Replace
5298         "parse_gdbarch" with method call.
5299         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
5300         "parse_gdbarch" with method call.
5301         * c-exp.y (parse_type, parse_number, classify_name): Replace
5302         "parse_gdbarch" with method call.
5303         * ada-lex.l: Replace "parse_gdbarch" with method call.
5304         * ada-exp.y (parse_type, find_primitive_type, type_char)
5305         (type_system_address): Replace "parse_gdbarch" with method call.
5306
5307 2019-04-04  Tom Tromey  <tom@tromey.com>
5308
5309         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
5310         * stap-probe.c (stap_parse_argument): Update.
5311         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
5312         initial_size parameter.
5313         * rust-exp.y (rust_lex_tests): Update.
5314         * parse.c (parser_state): Update.
5315         (parse_exp_in_context): Update.
5316         * parser-defs.h (struct parser_state) <parser_state>: Remove
5317         "initial_size" parameter.
5318
5319 2019-04-04  Tom Tromey  <tom@tromey.com>
5320
5321         * parser-defs.h (increase_expout_size): Don't declare.
5322         * parse.c (increase_expout_size): Now static.
5323
5324 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
5325
5326         * gnu-nat.c (gnu_nat_target::wait): Fix
5327         target_waitstatus_to_string call.
5328
5329 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5330
5331         * eval.c (evaluate_subexp_standard): Handle internal functions
5332         during Fortran function call handling.
5333
5334 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5335
5336         * NEWS: Mention new internal functions.
5337         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
5338         (read_base_type): Use dwarf2_init_complex_target_type.
5339         * value.c (creal_internal_fn): New function.
5340         (cimag_internal_fn): New function.
5341         (_initialize_values): Register new internal functions.
5342
5343 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5344
5345         * infrun.c (stop_all_threads): If debug_infrun, always
5346         trace the wait status after wait_one, using
5347         target_waitstatus_to_string and target_pid_to_str.
5348         (handle_inferior_event): Replace various trace of
5349         wait status kind by a single trace.
5350         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
5351         wait status kind image by target_waitstatus_to_string.
5352         * target/waitstatus.c (target_waitstatus_to_string): Fix
5353         obsolete comment.
5354
5355 2019-04-01  Tom Tromey  <tromey@adacore.com>
5356
5357         PR symtab/23331:
5358         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
5359
5360 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5361             Pedro Alves  <palves@redhat.com>
5362
5363         * top.c (quit_force): Call 'finalize_values'.
5364         * value.c (finalize_values): New function.
5365         * value.h (finalize_values): Declare.
5366
5367 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
5368
5369         * NEWS: Announce $_gdb_major and $_gdb_minor.
5370
5371         * top.c (init_gdb_version_vars): New function.
5372         (gdb_init): Call init_gdb_version_vars.
5373
5374 2019-03-29  Tom Tromey  <tromey@adacore.com>
5375
5376         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
5377         help text.  Remove dead code.
5378
5379 2019-03-29  Keith Seitz  <keiths@redhat.com>
5380
5381         From Siddhesh Poyarekar:
5382         * f-lang.h (f77_get_upperbound): Return LONGEST.
5383         (f77_get_lowerbound): Likewise.
5384         * f-typeprint.c (f_type_print_varspec_suffix): Expand
5385         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
5386         print them.
5387         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
5388         plongest to format print it.
5389         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
5390         (f77_get_upperbound): Likewise.
5391         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
5392         LOWER_BOUND to LONGEST.
5393         (f77_create_arrayprint_offset_tbl): Likewise.
5394
5395 2019-03-29  Keith Seitz  <keiths@redhat.com>
5396
5397         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
5398         %s/pulongest for TYPE_LENGTH instead of %d in format
5399         strings.
5400         * ada-typerint.c (ada_print_type): Likewise.
5401         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
5402         * compile/compile-c-support.c (generate_register_struct): Likewise.
5403         * gdbtypes.c (recursive_dump_type): Likewise.
5404         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
5405         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
5406         instead of %d in format strings.
5407         * riscv-tdep.c (riscv_type_alignment): Cast second argument
5408         to std::min to ULONGEST.
5409         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
5410         instead of %d in format strings.
5411         * tracepoint.c (info_scope_command): Likewise.
5412         * typeprint.c (print_offset_data::update)
5413         (print_offset_data::finish): Likewise.
5414         * xtensa-tdep.c (xtensa_store_return_value)
5415         (xtensa_push_dummy_call): Likewise.
5416
5417 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
5418
5419         * windows-nat.c (display_selector): Fixed format specifications
5420         for 64-bit Cygwin.
5421
5422 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5423
5424         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
5425
5426 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
5427
5428         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
5429         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
5430         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
5431         (nios2_linux_init_abi): Install it.
5432
5433 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5434
5435         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
5436
5437 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5438
5439         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
5440
5441 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5442             Tom Tromey  <tromey@adacore.com>
5443
5444         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
5445
5446 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
5447
5448         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
5449         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
5450         method to compute the bounds of range types. Also print "[evaluated]"
5451         if the bounds' values come from a dynamic evaluation.
5452
5453 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5454
5455         * cp-valprint.c (cp_print_value_fields): Don't print trailing
5456         whitespace when pretty printing is on.
5457
5458 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5459
5460         * ppc-linux-nat.c: Add include.
5461
5462 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5463
5464         * NEWS: Mention AArch64 Pointer Authentication.
5465
5466 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5467
5468         * arm-linux-nat.c: Add include.
5469
5470 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
5471
5472         * source-cache.c (source_cache::get_source_lines): Re-read
5473         fullname after calling open_source_file.
5474
5475 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
5476
5477         * NEWS: Mention TLS support for FreeBSD.
5478
5479 2019-03-25  Tom Tromey  <tromey@adacore.com>
5480
5481         * minsyms.c (BUNCH_SIZE): Update comment.
5482         (~minimal_symbol_reader): Remove old comment.
5483         (compact_minimal_symbols): Update comment.
5484         (minimal_symbol_reader::install): Remove old comment.  Update
5485         other comments.
5486
5487 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5488
5489         * s390-linux-nat.c: Add include.
5490
5491 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5492
5493         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5494         Call linux_get_hwcap.
5495         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
5496         Likewise.
5497         (aarch64_linux_get_hwcap): Remove function.
5498         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
5499         declaration.
5500         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
5501         linux_get_hwcap.
5502         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5503         * linux-tdep.c (linux_get_hwcap): Add function.
5504         (linux_get_hwcap2): Likewise.
5505         * linux-tdep.h (linux_get_hwcap): Add declaration.
5506         (linux_get_hwcap2): Likewise.
5507         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
5508         (ppc_linux_get_hwcap2): Likewise.
5509         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
5510         linux_get_hwcap.
5511         (ppc_linux_nat_target::insert_watchpoint): Likewise.
5512         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
5513         (ppc_linux_nat_target::read_description): Likewise.
5514         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
5515         * s390-linux-nat.c: Likewise.
5516         * s390-linux-tdep.c (s390_core_read_description): Likewise.
5517
5518 2019-03-24  Tom Tromey  <tom@tromey.com>
5519
5520         * ada-lang.c (standard_lookup): Simplify initialization.
5521         (ada_lookup_symbol_nonlocal): Simplify return.
5522         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
5523         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
5524         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
5525         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
5526         initialization.
5527         * solib.c (solib_global_lookup): Simplify.
5528         * symtab.c (null_block_symbol): Remove.
5529         (symbol_cache_lookup): Simplify returns.
5530         (lookup_language_this): Simplify returns.
5531         (lookup_symbol_aux): Simplify return.
5532         (lookup_local_symbol): Simplify returns.
5533         (lookup_global_symbol_from_objfile): Simplify return.
5534         (lookup_symbol_in_objfile_symtabs)
5535         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
5536         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
5537         (lookup_static_symbol, lookup_global_symbol): Simplify return.
5538         * cp-namespace.c (cp_lookup_bare_symbol)
5539         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
5540         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
5541         (cp_lookup_nested_symbol): Don't use null_block_symbol.
5542         (cp_lookup_symbol_via_imports): Simplify initialization.
5543         (find_symbol_in_baseclass): Likewise.
5544         * symtab.h (null_block_symbol): Remove.
5545         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
5546         (d_lookup_nested_symbol, d_lookup_symbol_imports)
5547         (d_lookup_symbol_module): Likewise.
5548         (find_symbol_in_baseclass): Simplify initialization.
5549
5550 2019-03-24  Tom Tromey  <tom@tromey.com>
5551
5552         * expression.h: Don't include symtab.h.
5553         (struct block): Forward declare.
5554
5555 2019-03-24  Tom Tromey  <tom@tromey.com>
5556
5557         * c-exp.y (typebase): Remove casts.
5558         * gdbtypes.c (lookup_unsigned_typename, )
5559         (lookup_signed_typename): Remove cast.
5560         * eval.c (parse_to_comma_and_eval): Remove cast.
5561         * parse.c (write_dollar_variable): Remove cast.
5562         * block.h (struct block) <superblock>: Now const.
5563         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
5564         * psymtab.c (psym_map_matching_symbols): Make "block" const.
5565         (map_block): Make "block" const.
5566         * symfile.h (struct quick_symbol_functions)
5567         <map_matching_symbols>: Constify block argument to "callback".
5568         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
5569         const.
5570         (find_pc_sect_compunit_symtab): Make "b" const.
5571         (find_symbol_at_address): Likewise.
5572         (search_symbols): Likewise.
5573         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
5574         (dw2_debug_names_lookup_symbol): Likewise.
5575         (dw2_map_matching_symbols): Update.
5576         * p-valprint.c (pascal_val_print): Remove "block".
5577         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
5578         (aux_add_nonlocal_symbols): Make "block" const.
5579         (resolve_subexp): Remove cast.
5580         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
5581         const.
5582         (iterate_over_file_blocks): Likewise.
5583         * f-exp.y (%union) <bval>: Remove.
5584         * coffread.c (patch_opaque_types): Make "b" const.
5585         * spu-tdep.c (spu_catch_start): Make "block" const.
5586         * c-valprint.c (print_unpacked_pointer): Remove "block".
5587         * symmisc.c (dump_symtab_1): Make "b" const.
5588         (block_depth): Make "block" const.
5589         * d-exp.y (%union) <bval>: Remove.
5590         * cp-support.h (cp_lookup_rtti_type): Update.
5591         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
5592         * psymtab.c (psym_lookup_symbol): Make "block" const.
5593         (maintenance_check_psymtabs): Make "b" const.
5594         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
5595         (enumerate_locals, enumerate_args): Update.
5596         * python/py-symtab.c (stpy_global_block): Make "block" const.
5597         (stpy_static_block): Likewise.
5598         * inline-frame.c (block_starting_point_at): Make "new_block"
5599         const.
5600         * block.c (find_block_in_blockvector): Make return type const.
5601         (blockvector_for_pc_sect): Make "b" const.
5602         (find_block_in_blockvector): Make "b" const.
5603
5604 2019-03-23  Tom Tromey  <tom@tromey.com>
5605
5606         * varobj.c (varobj_create): Update.
5607         * symfile.c (clear_symtab_users): Don't reset innermost_block.
5608         * printcmd.c (display_command, do_one_display): Don't reset
5609         innermost_block.
5610         * parser-defs.h (enum innermost_block_tracker_type): Move to
5611         expression.h.
5612         (innermost_block): Update comment.
5613         * parse.c (parse_exp_1): Add tracker_types parameter.
5614         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
5615         tracker_types parameter.  Reset innermost_block.
5616         (parse_exp_in_context): Remove.
5617         (parse_expression_for_completion): Update.
5618         * objfiles.c (~objfile): Don't reset expression_context_block or
5619         innermost_block.
5620         * expression.h (enum innermost_block_tracker_type): Move from
5621         parser-defs.h.
5622         (parse_exp_1): Add tracker_types parameter.
5623         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
5624         reset innermost_block.
5625
5626 2019-03-23  Tom Tromey  <tom@tromey.com>
5627
5628         * objfiles.h: Include bcache.h.
5629
5630 2019-03-23  Tom Tromey  <tom@tromey.com>
5631
5632         * linespec.c (get_current_search_block): Use
5633         scoped_restore_current_language.
5634         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
5635
5636 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5637             Jiong Wang  <jiong.wang@arm.com>
5638
5639         * aarch64-linux-tdep.c
5640         (aarch64_linux_iterate_over_regset_sections): Check for pauth
5641         section.
5642         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
5643
5644 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5645             Jiong Wang  <jiong.wang@arm.com>
5646
5647         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
5648         instructions.
5649         (aarch64_analyze_prologue_test): Add PACIASP test.
5650         (aarch64_prologue_prev_register): Unmask PC value.
5651
5652 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5653             Jiong Wang  <jiong.wang@arm.com>
5654
5655         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
5656         (aarch64_dwarf2_prev_register): Unmask PC value.
5657         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
5658         (aarch64_execute_dwarf_cfa_vendor_op): Check for
5659         DW_CFA_AARCH64_negate_ra_state.
5660         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
5661
5662 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5663             Jiong Wang  <jiong.wang@arm.com>
5664
5665         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
5666         registers.
5667         (aarch64_pseudo_register_name): Likewise.
5668         (aarch64_pseudo_register_type): Likewise.
5669         (aarch64_pseudo_register_reggroup_p): Likewise.
5670         (aarch64_gdbarch_init): Add pauth registers.
5671         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
5672         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
5673         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
5674         (struct gdbarch_tdep): Add regnum for ra_state.
5675
5676 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5677             Jiong Wang  <jiong.wang@arm.com>
5678
5679         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
5680
5681 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5682             Jiong Wang  <jiong.wang@arm.com>
5683
5684         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
5685         function.
5686         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
5687         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
5688         (aarch64_gdbarch_init): Add puth registers.
5689         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
5690         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
5691         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
5692
5693 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5694             Jiong Wang  <jiong.wang@arm.com>
5695
5696         * aarch64-linux-nat.c
5697         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
5698         * aarch64-linux-tdep.c
5699         (aarch64_linux_core_read_description): Likewise.
5700         (aarch64_linux_get_hwcap): New function.
5701         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
5702         (aarch64_linux_get_hwcap): New declaration.
5703
5704 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5705             Jiong Wang  <jiong.wang@arm.com>
5706
5707         * aarch64-linux-nat.c
5708         (aarch64_linux_nat_target::read_description): Add pauth param.
5709         * aarch64-linux-tdep.c
5710         (aarch64_linux_core_read_description): Likewise.
5711         * aarch64-tdep.c (struct target_desc): Add in pauth.
5712         (aarch64_read_description): Add pauth param.
5713         (aarch64_gdbarch_init): Likewise.
5714         * aarch64-tdep.h (aarch64_read_description): Likewise.
5715         * arch/aarch64.c (aarch64_create_target_description): Likewise.
5716         * arch/aarch64.h (aarch64_create_target_description): Likewise.
5717         * features/Makefile: Add new files.
5718         * features/aarch64-pauth.c: New file.
5719         * features/aarch64-pauth.xml: New file.
5720
5721 2019-03-20  Tom Tromey  <tromey@adacore.com>
5722
5723         * infrun.c (handle_inferior_event): Rename from
5724         handle_inferior_event_1.  Create a scoped_value_mark.
5725         (handle_inferior_event): Remove.
5726
5727 2019-03-19  Tom Tromey  <tromey@adacore.com>
5728
5729         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
5730         * infrun.h (print_stop_event): Add "displays" parameter.
5731         * infrun.c (print_stop_event): Add "displays" parameter.
5732
5733 2019-03-19  Pedro Alves  <palves@redhat.com>
5734
5735         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
5736         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
5737         to -1.  Fix TABs vs spaces.
5738         (tui_ui_out::tui_ui_out): Don't initialize fields here.
5739         * tui/tui-out.h (tui_ui_out) Add intro comments.
5740         <m_line, m_start_of_line>: In-class initialize, and add describing
5741         comment.
5742
5743 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
5744
5745         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
5746         variable names.
5747         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
5748
5749 2019-03-18  Pedro Alves  <palves@redhat.com>
5750             Eli Zaretskii <eliz@gnu.org>
5751
5752         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
5753         m_line and m_start_of_line.
5754
5755 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
5756
5757         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
5758         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
5759         it returns a newline.  This fixes a regression in TU mode, whereby
5760         the next line is output on the same screen line as the user input.
5761
5762 2019-03-18  Tom Tromey  <tromey@adacore.com>
5763
5764         * minsyms.c (minimal_symbol_reader::install): Remove call to
5765         obstack_blank.
5766
5767 2019-03-18  Pedro Alves  <palves@redhat.com>
5768
5769         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
5770         New globals.
5771         (apply_style): New, factored out from ...
5772         (apply_ansi_escape): ... this.  Handle reverse video mode.
5773         (tui_set_reverse_mode): New function.
5774         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
5775         * tui/tui-winsource.c (tui_show_source_line): Use
5776         tui_set_reverse_mode instead of setting A_STANDOUT.
5777         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
5778         New setter methods.
5779
5780 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
5781
5782         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
5783         Handle tabs.
5784
5785 2019-03-18  Tom Tromey  <tromey@adacore.com>
5786
5787         * ada-lang.c (empty_array): Add "high" parameter.
5788         (ada_evaluate_subexp): Update.
5789
5790 2019-03-17  Sergei Trofimovich <siarheit@google.com>
5791
5792         * unittests/string_view-selftests.c: Define
5793         _initialize_string_view_selftests unconditionally.
5794
5795 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5796
5797         PR gdb/24350
5798         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
5799
5800 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5801
5802         PR gdb/24351
5803         * windows-nat.c (display_selector): Fix format specifiers.
5804
5805 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
5806
5807         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
5808         tui_refill_source_window instead of tui_refresh_win, to update the
5809         current execution line.  This fixes redisplay of the current line
5810         when stepping through the code with "next" or "step".
5811
5812 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5813
5814         * source-cache.c (source_cache::get_source_lines): Call
5815         find_source_lines to initialize s->nlines.  This fixes vertical
5816         scrolling of TUI source window when the DOWN arrow is pressed.
5817
5818 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5819
5820         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
5821         linux-thread-db.c (_initialize_thread_db): Likewise.
5822
5823 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5824
5825         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
5826         wclrtoeol in tui_show_source_line".  This reverts changes made in
5827         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
5828
5829 2019-03-15  Tom Tromey  <tom@tromey.com>
5830
5831         * symtab.h (struct minimal_symbol): Derive from
5832         general_symbol_info.
5833         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
5834         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
5835         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
5836         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
5837         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
5838         (MSYMBOL_SEARCH_NAME): Update.
5839         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
5840         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
5841         * minsyms.c (minimal_symbol_reader::record_full): Update.
5842
5843 2019-03-15  Tom Tromey  <tom@tromey.com>
5844
5845         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
5846
5847 2019-03-15  Tom Tromey  <tom@tromey.com>
5848
5849         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
5850         unique_xmalloc_ptr.
5851         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
5852         Update.
5853         * minsyms.c (lookup_minimal_symbol_by_pc_section)
5854         (build_minimal_symbol_hash_tables)
5855         (minimal_symbol_reader::install): Update.
5856
5857 2019-03-15  Tom Tromey  <tom@tromey.com>
5858
5859         * symtab.c (create_demangled_names_hash): Update.
5860         (symbol_set_names): Update.
5861         * objfiles.h (struct objfile_per_bfd_storage)
5862         <demangled_names_hash>: Now an htab_up.
5863         * objfiles.c (objfile_per_bfd_storage): Simplify.
5864
5865 2019-03-15  Tom Tromey  <tom@tromey.com>
5866
5867         * objfiles.h (struct objfile_per_bfd_storage): Declare
5868         destructor.
5869         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
5870         New.
5871         (get_objfile_bfd_data): Use new.  Don't initialize
5872         language_of_main.
5873         (free_objfile_per_bfd_storage): Remove.
5874         (objfile_bfd_data_free, objfile::~objfile): Use delete.
5875
5876 2019-03-15  Tom Tromey  <tom@tromey.com>
5877
5878         * symfile.c (reread_symbols): Update.
5879         * objfiles.c (objfile::objfile): Update.
5880         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
5881         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
5882         comment.
5883         (minimal_symbol_reader::install): Update.
5884         (terminate_minimal_symbol_table): Remove.
5885         * jit.c (jit_object_close_impl): Update.
5886
5887 2019-03-15  Tom Tromey  <tom@tromey.com>
5888
5889         * minsyms.c (minimal_symbol_reader::record_full): Remove some
5890         initializations.
5891
5892 2019-03-15  Tom Tromey  <tom@tromey.com>
5893
5894         * objfiles.h (struct objfile_per_bfd_storage)
5895         <demangled_hash_languages>: Now a bitset.
5896         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
5897         (lookup_minimal_symbol): Update.
5898
5899 2019-03-15  Tom Tromey  <tom@tromey.com>
5900
5901         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
5902         Don't return the symbol.
5903         * coffread.c (record_minimal_symbol): Use record_full.
5904
5905 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
5906
5907         The MS-Windows port of ncurses fails to switch to a color pair if
5908         one or both of the colors are the implicit default colors.  This
5909         change records the default colors when TUI is initialized, and
5910         then specifies them explicitly when a color pair uses the default
5911         colors.  This allows color styling in TUI mode on MS-Windows.
5912
5913         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
5914         ncurses_norm_attr.
5915         (tui_initialize_io) [__MINGW32__]: Record the default terminal
5916         colors in ncurses_norm_attr.
5917         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
5918         "none", replace it with the default color recorded in
5919         ncurses_norm_attr.
5920
5921 2019-03-14  Tom Tromey  <tromey@adacore.com>
5922
5923         * source-cache.h (class source_cache) <get_source_lines>: Return
5924         std::string.
5925         * source-cache.c (source_cache::extract_lines): Handle case where
5926         first_pos==npos.  Return std::string.
5927         (source_cache::get_source_lines): Update.
5928
5929 2019-03-14  Tom Tromey  <tromey@adacore.com>
5930
5931         * NEWS: Add item for "style sources" commands.
5932         * source-cache.c (source_cache::get_source_lines): Check
5933         source_styling.
5934         * cli/cli-style.c (source_styling): New global.
5935         (_initialize_cli_style): Add "style sources" commands.
5936         (show_style_sources): New function.
5937         * cli/cli-style.h (source_styling): Declare.
5938
5939 2019-03-14  Pedro Alves  <palves@redhat.com>
5940             Tom Tromey  <tromey@adacore.com>
5941
5942         * tui/tui-winsource.h (tui_refill_source_window): Declare.
5943         * tui/tui-winsource.c (tui_refill_source_window): New function,
5944         from...
5945         (tui_horizontal_source_scroll): ... here.  Move some logic.
5946         * cli/cli-style.c (set_style_enabled): Notify new observable.
5947         * tui/tui-hooks.c (tui_redisplay_source): New function.
5948         (tui_attach_detach_observers): Attach or detach
5949         tui_redisplay_source.
5950         * observable.h (source_styling_changed): New observable.
5951         * observable.c: Define source_styling_changed observable.
5952
5953 2019-03-13  Tom Tromey  <tromey@adacore.com>
5954
5955         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
5956         (i386_gnu_nat_target::store_registers): Update.
5957         * target-debug.h (target_debug_print_std_string): New macro.
5958         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5959         * windows-tdep.c (display_one_tib): Update.
5960         * tui/tui-stack.c (tui_make_status_line): Update.
5961         * top.c (print_inferior_quit_action): Update.
5962         * thread.c (thr_try_catch_cmd): Update.
5963         (add_thread_with_info): Update.
5964         (thread_target_id_str): Update.
5965         (thr_try_catch_cmd): Update.
5966         (thread_command): Update.
5967         (thread_find_command): Update.
5968         * record-btrace.c (record_btrace_target::info_record)
5969         (record_btrace_resume_thread, record_btrace_target::resume)
5970         (record_btrace_cancel_resume, record_btrace_step_thread)
5971         (record_btrace_target::wait, record_btrace_target::wait)
5972         (record_btrace_target::wait, record_btrace_target::stop): Update.
5973         * progspace.c (print_program_space): Update.
5974         * process-stratum-target.c
5975         (process_stratum_target::thread_address_space): Update.
5976         * linux-fork.c (linux_fork_mourn_inferior)
5977         (detach_checkpoint_command, info_checkpoints_command)
5978         (linux_fork_context): Update.
5979         (linux_fork_detach): Update.
5980         (class scoped_switch_fork_info): Update.
5981         (delete_checkpoint_command): Update.
5982         * infrun.c (follow_fork_inferior): Update.
5983         (follow_fork_inferior): Update.
5984         (proceed_after_vfork_done): Update.
5985         (handle_vfork_child_exec_or_exit): Update.
5986         (follow_exec): Update.
5987         (displaced_step_prepare_throw): Update.
5988         (displaced_step_restore): Update.
5989         (start_step_over): Update.
5990         (resume_1): Update.
5991         (clear_proceed_status_thread): Update.
5992         (proceed): Update.
5993         (print_target_wait_results): Update.
5994         (do_target_wait): Update.
5995         (context_switch): Update.
5996         (stop_all_threads): Update.
5997         (restart_threads): Update.
5998         (finish_step_over): Update.
5999         (handle_signal_stop): Update.
6000         (switch_back_to_stepped_thread): Update.
6001         (keep_going_pass_signal): Update.
6002         (print_exited_reason): Update.
6003         (normal_stop): Update.
6004         * inferior.c (inferior_pid_to_str): Change return type.
6005         (print_selected_inferior): Update.
6006         (add_inferior): Update.
6007         (detach_inferior): Update.
6008         * dummy-frame.c (fprint_dummy_frames): Update.
6009         * dcache.c (dcache_info_1): Update.
6010         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6011         (btrace_fetch, btrace_clear): Update.
6012         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6013         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6014         type.
6015         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6016         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6017         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6018         * gdbarch.c, gdbarch.h: Rebuild.
6019         * gdbarch.sh (core_pid_to_str): Change return type.
6020         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6021         return type.
6022         (windows_nat_target::pid_to_str): Change return type.
6023         (windows_delete_thread): Update.
6024         (windows_nat_target::attach): Update.
6025         (windows_nat_target::files_info): Update.
6026         * target-delegates.c: Rebuild.
6027         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6028         return type.
6029         (sol_thread_target::pid_to_str): Change return type.
6030         * remote.c (class remote_target) <pid_to_str>: Change return
6031         type.
6032         (remote_target::pid_to_str): Change return type.
6033         (extended_remote_target::attach, remote_target::remote_stop_ns)
6034         (remote_target::remote_notif_remove_queued_reply)
6035         (remote_target::push_stop_reply, remote_target::disable_btrace):
6036         Update.
6037         (extended_remote_target::attach): Update.
6038         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6039         type.
6040         (gdbsim_target::pid_to_str): Change return type.
6041         * ravenscar-thread.c (struct ravenscar_thread_target)
6042         <pid_to_str>: Change return type.
6043         (ravenscar_thread_target::pid_to_str): Change return type.
6044         * procfs.c (class procfs_target) <pid_to_str>: Change return
6045         type.
6046         (procfs_target::pid_to_str): Change return type.
6047         (procfs_target::attach): Update.
6048         (procfs_target::detach): Update.
6049         (procfs_target::fetch_registers): Update.
6050         (procfs_target::store_registers): Update.
6051         (procfs_target::wait): Update.
6052         (procfs_target::files_info): Update.
6053         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6054         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6055         return type.
6056         (nto_procfs_target::pid_to_str): Change return type.
6057         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6058         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6059         return type.
6060         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6061         (exit_lwp): Update.
6062         (attach_proc_task_lwp_callback, get_detach_signal)
6063         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6064         (linux_nat_target::resume, wait_lwp, stop_callback)
6065         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6066         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6067         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6068         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6069         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6070         type.
6071         (inf_ptrace_target::attach): Update.
6072         (inf_ptrace_target::files_info): Update.
6073         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6074         type.
6075         (go32_nat_target::pid_to_str): Change return type.
6076         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6077         (gnu_nat_target::wait): Update.
6078         (gnu_nat_target::wait): Update.
6079         (gnu_nat_target::resume): Update.
6080         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6081         (fbsd_nat_target::wait): Update.
6082         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6083         type.
6084         (darwin_nat_target::attach): Update.
6085         * corelow.c (class core_target) <pid_to_str>: Change return type.
6086         (core_target::pid_to_str): Change return type.
6087         * target.c (normal_pid_to_str): Change return type.
6088         (default_pid_to_str): Likewise.
6089         (target_pid_to_str): Change return type.
6090         (target_translate_tls_address): Update.
6091         (target_announce_detach): Update.
6092         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6093         return type.
6094         (bsd_uthread_target::pid_to_str): Change return type.
6095         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6096         type.
6097         (bsd_kvm_target::pid_to_str): Change return type.
6098         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6099         return type.
6100         (aix_thread_target::pid_to_str): Change return type.
6101         * target.h (struct target_ops) <pid_to_str>: Change return type.
6102         (target_pid_to_str, normal_pid_to_str): Likewise.
6103         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6104         type.
6105         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6106         type.
6107         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6108         return type.
6109         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6110         type.
6111         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6112         type.
6113         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6114         return type.
6115
6116 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6117
6118         * NEWS: Mention that the new default MI version is 3.  Mention
6119         changes to the output of commands and events that deal with
6120         multi-location breakpoints.
6121         * breakpoint.c: Include "mi/mi-out.h".
6122         (print_one_breakpoint): Change output syntax if using MI version
6123         >= 3.
6124         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6125         New.
6126         (mi_multi_location_breakpoint_output_fixed): New.
6127         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6128         (mi_cmd_fix_multi_location_breakpoint_output): New.
6129         (mi_multi_location_breakpoint_output_fixed): New.
6130         * mi/mi-cmds.c (mi_cmds): Register command
6131         -fix-multi-location-breakpoint-output.
6132         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6133         interpreter "mi".
6134
6135 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6136
6137         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6138         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6139         instantiate mi_ui_out based on interpreter name.
6140         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6141         * mi/mi-main.c (mi_load_progress): Likewise.
6142
6143 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6144
6145         * NEWS: Combine separate "New targets" sections for 8.3.
6146
6147 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6148
6149         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6150         (ppcfbsd_init_abi): Install gdbarch
6151         "fetch_tls_load_module_address" and "get_thread_local_address"
6152         methods.
6153
6154 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6155
6156         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
6157         (riscv_fbsd_init_abi): Install gdbarch
6158         "fetch_tls_load_module_address" and "get_thread_local_address"
6159         methods.
6160
6161 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6162
6163         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
6164         (i386fbsd_init_abi): Install gdbarch
6165         "fetch_tls_load_module_address" and "get_thread_local_address"
6166         methods.
6167
6168 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6169
6170         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
6171         (amd64fbsd_init_abi): Install gdbarch
6172         "fetch_tls_load_module_address" and "get_thread_local_address"
6173         methods.
6174
6175 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6176
6177         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
6178         (struct fbsd_pspace_data): New type.
6179         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
6180         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
6181         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
6182         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
6183         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
6184
6185 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6186
6187         * gdbtypes.c (lookup_struct_elt): New function.
6188         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
6189         * gdbtypes.h (struct struct_elt): New type.
6190         (lookup_struct_elt): New prototype.
6191
6192 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6193
6194         * gdbtypes.c (lookup_struct_elt_type): Update comment and
6195         remove disabled code block.
6196
6197 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6198
6199         * gdbarch.sh (get_thread_local_address): New method.
6200         * gdbarch.h, gdbarch.c: Regenerate.
6201         * target.c (target_translate_tls_address): Use
6202         gdbarch_get_thread_local_address if present instead of
6203         target::get_thread_local_address.
6204
6205 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6206
6207         * target.h (target::get_thread_local_address): Update comment.
6208
6209 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6210
6211         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
6212         objfile->separate_debug_objfile_backlink if not NULL.
6213
6214 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6215
6216         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6217         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
6218         (amd64bsd_store_inferior_registers): Likewise.
6219         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6220         Enable segment base registers.
6221         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
6222         PT_GETFSBASE and PT_GETGSBASE.
6223         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
6224         PT_SETGSBASE.
6225         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
6226         segment base registers.
6227         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6228
6229 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6230
6231         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6232         Update calls to i386_target_description to add 'segments'
6233         parameter.
6234         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
6235         add segment base registers.
6236         * arch/i386.c (i386_create_target_description): Add 'segments'
6237         parameter to enable segment base registers.
6238         * arch/i386.h (i386_create_target_description): Likewise.
6239         * features/i386/32bit-segments.xml: New file.
6240         * features/i386/32bit-segments.c: Generate.
6241         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
6242         call to i386_target_description to add 'segments' parameter.
6243         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6244         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
6245         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
6246         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
6247         if feature is present.
6248         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
6249         Add 'segments' parameter to call to i386_target_description.
6250         (i386_target_description): Add 'segments' parameter to enable
6251         segment base registers.
6252         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
6253         to call to i386_target_description.
6254         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
6255         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
6256         Define I386_NUM_REGS.
6257         (i386_target_description): Add 'segments' parameter to enable
6258         segment base registers.
6259
6260 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
6261
6262         PR/24325
6263         * source-cache.c: #undef open and close, to avoid unresolved
6264         externals during linking.
6265
6266 2019-03-12  Tom Tromey  <tromey@adacore.com>
6267
6268         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
6269         const.  Add initializers.
6270         (_initialize_remote): Don't initialize ptid globals.
6271
6272 2019-03-12  Pedro Alves  <palves@redhat.com>
6273
6274         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
6275
6276 2019-03-12  Pedro Alves  <palves@redhat.com>
6277
6278         * cp-name-parser.y (main): Remove unused 'len' variable.
6279
6280 2019-03-12  Tom Tromey  <tromey@adacore.com>
6281
6282         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
6283         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
6284
6285 2019-03-12  Tom Tromey  <tromey@adacore.com>
6286
6287         * linux-nat.c (iterate_over_lwps): Update.
6288         (stop_callback): Remove parameter.
6289         (stop_wait_callback, detach_callback, resume_set_callback)
6290         (select_singlestep_lwp_callback, set_ignore_sigint)
6291         (status_callback, resumed_callback, resume_clear_callback)
6292         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
6293         data parameter.
6294         (linux_nat_target::detach, linux_nat_target::resume)
6295         (linux_stop_and_wait_all_lwps, select_event_lwp)
6296         (linux_nat_filter_event, linux_nat_wait_1)
6297         (linux_nat_target::kill, linux_nat_target::stop)
6298         (linux_nat_target::stop): Update.
6299         (linux_nat_resume_callback): Change type.
6300         (resume_stopped_resumed_lwps, count_events_callback)
6301         (select_event_lwp_callback): Likewise.
6302         (linux_stop_lwp, linux_nat_stop_lwp): Update.
6303         * arm-linux-nat.c (struct update_registers_data): Remove.
6304         (update_registers_callback): Change type.
6305         (arm_linux_insert_hw_breakpoint1): Update.
6306         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
6307         parameter.
6308         (x86_linux_dr_set_addr): Update.
6309         (x86_linux_dr_set_control): Update.
6310         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
6311         (iterate_over_lwps): Use gdb::function_view.
6312         * nat/aarch64-linux-hw-point.c (struct
6313         aarch64_dr_update_callback_param): Remove.
6314         (debug_reg_change_callback): Change type.
6315         (aarch64_notify_debug_reg_change): Update.
6316         * s390-linux-nat.c (s390_refresh_per_info): Update.
6317
6318 2019-03-11  Tom Tromey  <tromey@adacore.com>
6319
6320         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
6321         redundant assignment to "this_cu".
6322
6323 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6324
6325         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
6326
6327 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6328
6329         * gdbtypes.c (rank_one_type_parm_set): New function extracted
6330         from...
6331         (rank_one_type): ... this.
6332
6333 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6334
6335         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
6336         from...
6337         (rank_one_type): ... this.
6338
6339 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6340
6341         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
6342         from...
6343         (rank_one_type): ... this.
6344
6345 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6346
6347         * gdbtypes.c (rank_one_type_parm_float): New function extracted
6348         from...
6349         (rank_one_type): ... this.
6350
6351 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6352
6353         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
6354         from...
6355         (rank_one_type): ... this.
6356
6357 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6358
6359         * gdbtypes.c (rank_one_type_parm_range): New function extracted
6360         from...
6361         (rank_one_type): ... this.
6362
6363 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6364
6365         * gdbtypes.c (rank_one_type_parm_char): New function extracted
6366         from...
6367         (rank_one_type): ... this.
6368
6369 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6370
6371         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
6372         from...
6373         (rank_one_type): ... this.
6374
6375 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6376
6377         * gdbtypes.c (rank_one_type_parm_int): New function extracted
6378         from...
6379         (rank_one_type): ... this.
6380
6381 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6382
6383         * gdbtypes.c (rank_one_type_parm_func): New function extracted
6384         from...
6385         (rank_one_type): ... this.
6386
6387 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6388
6389         * gdbtypes.c (rank_one_type_parm_array): New function extracted
6390         from...
6391         (rank_one_type): ... this.
6392
6393 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6394
6395         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
6396         from...
6397         (rank_one_type): ... this.
6398
6399 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6400
6401         * inferior.c (initialize_inferiors): Ensure 'help set/show print
6402         inferior-events' shows the example events.
6403
6404 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
6405
6406         Support styling on native MS-Windows console
6407
6408         PR/24315
6409         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
6410         on MS-Windows if $TERM is not defined.
6411
6412         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
6413
6414         * posix-hdep.c (gdb_console_fputs):
6415         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
6416         functions.
6417         * ui-file.h (gdb_console_fputs): Add prototype.
6418
6419         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
6420         back to fputs only if the former returns zero.
6421
6422 2019-03-07  Tom Tromey  <tom@tromey.com>
6423
6424         * symmisc.c (print_symbol_bcache_statistics): Update.
6425         (print_objfile_statistics): Update.
6426         * symfile.c (allocate_symtab): Update.
6427         * stabsread.c: Don't include bcache.h.
6428         * psymtab.h (struct psymbol_bcache): Don't declare.
6429         (class psymtab_storage) <psymbol_cache>: Now a bcache.
6430         (psymbol_bcache_init, psymbol_bcache_free)
6431         (psymbol_bcache_get_bcache): Don't declare.
6432         * psymtab.c (struct psymbol_bcache): Remove.
6433         (psymtab_storage::psymtab_storage): Update.
6434         (psymtab_storage::~psymtab_storage): Update.
6435         (psymbol_bcache_init, psymbol_bcache_free)
6436         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
6437         (add_psymbol_to_bcache): Update.
6438         (allocate_psymtab): Update.
6439         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
6440         macro_cache>: No longer pointers.
6441         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
6442         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
6443         * macrotab.c (macro_bcache): Update.
6444         * macroexp.c: Don't include bcache.h.
6445         * gdbtypes.c (check_types_worklist): Update.
6446         (types_deeply_equal): Remove TRY/CATCH.  Update.
6447         * elfread.c (elf_symtab_read): Update.
6448         * dwarf2read.c: Don't include bcache.h.
6449         * buildsym.c (buildsym_compunit::get_macro_table): Update.
6450         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
6451         (print_bcache_statistics, bcache_memory_used): Don't declare.
6452         (struct bcache): Move from bcache.c.  Add constructor, destructor,
6453         methods.  Rename all data members.
6454         * bcache.c (struct bcache): Move to bcache.h.
6455         (bcache::expand_hash_table): Rename from expand_hash_table.
6456         (bcache): Remove.
6457         (bcache::insert): Rename from bcache_full.
6458         (bcache::compare): Rename from bcache_compare.
6459         (bcache_xmalloc): Remove.
6460         (bcache::~bcache): Rename from bcache_xfree.
6461         (bcache::print_statistics): Rename from print_bcache_statistics.
6462         (bcache::memory_used): Rename from bcache_memory_used.
6463
6464 2019-03-07  Pedro Alves  <palves@redhat.com>
6465
6466         * infrun.c (normal_stop): Also check for
6467         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
6468
6469 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
6470
6471         * f-lang.c (value_from_host_double): Moved to...
6472         * value.c (value_from_host_double): ...here.
6473         * value.h (value_from_host_double): Declare.
6474         * guile/scm-math.c (vlscm_convert_typed_number): Use
6475         value_from_host_double.
6476         (vlscm_convert_number): Likewise.
6477         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
6478         * python/py-value.c (convert_value_from_python): Likewise.
6479
6480 2019-03-06  Tom Tromey  <tom@tromey.com>
6481
6482         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
6483
6484 2019-03-06  Tom Tromey  <tom@tromey.com>
6485
6486         * utils.h (free_current_contents): Don't declare.
6487         * utils.c (free_current_contents): Remove.
6488
6489 2019-03-06  Tom Tromey  <tom@tromey.com>
6490
6491         * top.c (quit_force): Update.
6492         * main.c (captured_command_loop): Update.
6493         * common/new-op.c (operator new): Update.
6494         * common/common-exceptions.c (struct catcher)
6495         <save_cleanup_chain>: Remove member.
6496         (exceptions_state_mc_init): Update.
6497         (exception_try_scope_entry): Return nullptr.
6498         (exception_try_scope_exit, exception_rethrow)
6499         (throw_exception_sjlj, throw_exception_cxx): Update.
6500         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
6501         (all_cleanups, do_cleanups, discard_cleanups)
6502         (discard_final_cleanups, save_cleanups, save_final_cleanups)
6503         (restore_cleanups, restore_final_cleanups): Don't declare.
6504         (do_final_cleanups): Remove parameter.
6505         * common/cleanups.c (cleanup_chain, make_cleanup)
6506         (make_cleanup_dtor, all_cleanups, do_cleanups)
6507         (discard_my_cleanups, discard_cleanups)
6508         (discard_final_cleanups, save_my_cleanups, save_cleanups)
6509         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
6510         (null_cleanup): Remove.
6511         (do_final_cleanups): Remove parameter.
6512
6513 2019-03-06  Tom Tromey  <tom@tromey.com>
6514
6515         * remote.c (remote_target::remote_parse_stop_reply): Use
6516         unique_xmalloc_ptr.
6517
6518 2019-03-06  Tom Tromey  <tom@tromey.com>
6519
6520         * stabsread.c (struct stabs_field_info): Rename from field_info.
6521         <list, fnlist>: Add initializers.
6522         <obstack>: New member.
6523         (read_member_functions, read_struct_fields, read_baseclasses):
6524         Allocate on obstack.  Don't use cleanups.
6525         (read_one_struct_field, read_member_functions, read_struct_fields)
6526         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
6527         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
6528         (read_struct_type): Update.
6529
6530 2019-03-06  Tom Tromey  <tom@tromey.com>
6531
6532         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
6533         * common/filestuff.h (make_cleanup_close): Don't declare.
6534         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
6535         Remove.
6536
6537 2019-03-06  Tom Tromey  <tom@tromey.com>
6538
6539         * solib-aix.c: Use make_scope_exit.
6540
6541 2019-03-06  Tom Tromey  <tom@tromey.com>
6542
6543         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
6544         Use make_scope_exit.
6545
6546 2019-03-06  Tom Tromey  <tom@tromey.com>
6547
6548         * solib-svr4.c (disable_probes_interface): Remove parameter.
6549         (svr4_handle_solib_event): Use make_scope_exit.
6550
6551 2019-03-06  Tom Tromey  <tom@tromey.com>
6552
6553         * remote.c (struct stop_reply_deleter): Remove.
6554         (stop_reply_up): Update.
6555         (struct stop_reply): Derive from notif_event.  Don't typedef.
6556         <regcache>: Now a std::vector.
6557         (stop_reply_xfree): Remove.
6558         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
6559         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
6560         (remote_target::discard_pending_stop_replies): Use delete.
6561         (remote_target::remote_parse_stop_reply): Update.
6562         (remote_target::process_stop_reply): Update.
6563         * remote-notif.h (struct notif_event): Add virtual destructor.
6564         Remove "dtr" member.
6565         (struct notif_client) <alloc_event>: Return a unique_ptr.
6566         (notif_event_xfree): Don't declare.
6567         (notif_event_up): New typedef.
6568         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
6569         (notif_event_xfree, do_notif_event_xfree): Remove.
6570         (remote_notif_state_xfree): Update.
6571
6572 2019-03-06  Tom Tromey  <tom@tromey.com>
6573
6574         * infrun.c (displaced_step_clear_cleanup): Now a
6575         forward_scope_exit type.
6576         (displaced_step_prepare_throw): Update.
6577         (displaced_step_fixup): Update.
6578
6579 2019-03-06  Tom Tromey  <tom@tromey.com>
6580
6581         * inferior.h (class inferior): Update comment.
6582         * gdbthread.h (class thread_info): Update comment.
6583
6584 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
6585             Tom Tromey  <tom@tromey.com>
6586
6587         * stabsread.h (struct stab_section_list): Remove.
6588         (coffstab_build_psymtabs): Update.
6589         * dbxread.c (symbuf_sections): Now a std::vector.
6590         (sect_idx): New global.
6591         (fill_symbuf): Update.
6592         (coffstab_build_psymtabs): Change type of stabsects parameter.
6593         Update.
6594         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
6595         std::vector.
6596         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
6597         (coff_locate_sections): Update.
6598         (coff_symfile_read): Remove cleanups.  Update.
6599         (init_stringtab): Add storage parameter.
6600         (free_stringtab, free_stringtab_cleanup): Remove.
6601         (init_lineno): Add storage parameter.
6602         (free_linetab, free_linetab_cleanup): Remove.
6603
6604 2019-03-06  Pedro Alves  <palves@redhat.com>
6605
6606         * linux-fork.c (fork_info::clobber_regs): Delete.
6607         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
6608         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
6609         comment.  Adjust.
6610         (scoped_switch_fork_info::scoped_switch_fork_info)
6611         (checkpoint_command, linux_fork_context): Adjust
6612         fork_save_infrun_state calls.
6613
6614 2019-03-06  Pedro Alves  <palves@redhat.com>
6615
6616         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
6617         (inf_has_multiple_threads): Return 'bool' and rewrite using
6618         inferior_info::threads().
6619
6620 2019-03-06  Pedro Alves  <palves@redhat.com>
6621
6622         * linux-fork.c: Include <list>.
6623         (fork_list): Now a std::list instance.
6624         (fork_info): Add ctor, dtor, and in-class initialize all fields.
6625         (forks_exist_p, find_last_fork): Adjust.
6626         (new_fork): Delete.
6627         (one_fork_p): New.
6628         (add_fork): Adjust.
6629         (free_fork): Delete, folded into fork_info::~fork_info().
6630         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
6631         Adjust.
6632         (init_fork_list): Delete.
6633         (linux_fork_killall, linux_fork_mourn_inferior)
6634         (linux_fork_detach, info_checkpoints_command): Adjust.
6635         (_initialize_linux_fork): No longer call init_fork_list.
6636
6637 2019-03-06  Pedro Alves  <palves@redhat.com>
6638
6639         * linux-fork.c (new_fork): New, split out of ...
6640         (add_fork): ... this.  Return void.  Move "first fork" special
6641         case from here, to ...
6642         (checkpoint_command): ... here.
6643         * linux-linux.h (add_fork): Return void.
6644
6645 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6646
6647         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
6648
6649 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6650             Chris January  <chris.january@arm.com>
6651             David Lecomber  <david.lecomber@arm.com>
6652
6653         * f-exp.y: New token, UNOP_INTRINSIC.
6654         (exp): New pattern using UNOP_INTRINSIC token.
6655         (f77_keywords): Add 'abs' keyword.
6656         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
6657         (value_from_host_double): New function.
6658         (evaluate_subexp_f): Support UNOP_ABS.
6659
6660 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6661
6662         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
6663         types.
6664
6665 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6666
6667         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
6668         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
6669         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
6670
6671 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6672
6673         * f-exp.y (convert_to_kind_type): Handle more type kinds.
6674
6675 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6676             Chris January  <chris.january@arm.com>
6677
6678         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
6679         * f-exp.y: Define 'KIND' token.
6680         (exp): New pattern for KIND expressions.
6681         (ptype): Handle types with a kind extension.
6682         (direct_abs_decl): Extend to spot kind extensions.
6683         (f77_keywords): Add 'kind' to the list.
6684         (push_kind_type): New function.
6685         (convert_to_kind_type): New function.
6686         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
6687         * parse.c (operator_length_standard): Likewise.
6688         * parser-defs.h (enum type_pieces): Add tp_kind.
6689         * std-operator.def: Add UNOP_KIND.
6690
6691 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6692
6693         * f-exp.y (f_parse): Set yydebug.
6694
6695 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6696
6697         * f-lang.c (evaluate_subexp_f): New function.
6698         (exp_descriptor_f): New global.
6699         (f_language_defn): Use exp_descriptor_f instead of
6700         exp_descriptor_standard.
6701
6702 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6703
6704         * f-exp.y (struct token): Add comments.
6705         (dot_ops): Remove uppercase versions and the end marker.
6706         (f77_keywords): Likewise.
6707         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
6708         entries in the dot_ops array are case insensitive, and use
6709         strncasecmp to compare strings.  Also some whitespace cleanup in
6710         this area.  Similar for the f77_keywords array, except entries in
6711         this list might be case sensitive.
6712
6713 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6714
6715         * f-exp.y (struct f77_boolean_val): Add comments.
6716         (boolean_values): Remove uppercase versions, and end marker.
6717         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
6718         and use strncasecmp to achieve case insensitivity.  Additionally,
6719         perform whitespace cleanup around this code.
6720
6721 2019-03-06  Tom Tromey  <tromey@adacore.com>
6722
6723         * remote-sim.c (gdbsim_target_open): Use result of
6724         gdb_argv::release.
6725
6726 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
6727         Dirk Schubert  <dirk.schubert@arm.com>
6728         Chris January  <chris.january@arm.com>
6729
6730         * eval.c (evaluate_subexp_standard): Call Fortran argument
6731         wrapping logic.
6732         * f-lang.c (struct value): A value which can be passed into a
6733         Fortran function call.
6734         (fortran_argument_convert): Wrap Fortran arguments in a pointer
6735         where appropriate.
6736         (struct type): Value ready for a Fortran function call.
6737         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
6738         is needed.
6739         * f-lang.h (fortran_argument_convert): Declaration.
6740         (fortran_preserve_arg_pointer): Declaration.
6741         * infcall.c (value_arg_coerce): Call Fortran argument logic.
6742
6743 2019-03-05  Tom Tromey  <tromey@adacore.com>
6744
6745         * python/py-prettyprint.c (print_string_repr): Remove #if.
6746         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
6747
6748 2019-03-05  Tom Tromey  <tromey@adacore.com>
6749
6750         * target.c (the_dummy_target): Move later.  Change type to
6751         "dummy_target".
6752         (initialize_targets): Don't initialize the_dummy_target.
6753
6754 2019-03-05  Tom Tromey  <tromey@adacore.com>
6755
6756         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
6757         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
6758
6759 2019-03-05  Tom Tromey  <tromey@adacore.com>
6760
6761         * windows-nat.c (windows_nat_target::attach)
6762         (windows_nat_target::detach): Don't call gdb_flush.
6763         * valprint.c (generic_val_print, val_print, val_print_string):
6764         Don't call gdb_flush.
6765         * utils.c (defaulted_query): Don't call gdb_flush.
6766         * typeprint.c (print_type_scalar): Don't call gdb_flush.
6767         * target.c (target_announce_detach): Don't call gdb_flush.
6768         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
6769         * remote.c (extended_remote_target::attach): Don't call
6770         gdb_flush.
6771         * procfs.c (procfs_target::detach): Don't call gdb_flush.
6772         * printcmd.c (do_examine): Don't call gdb_flush.
6773         (info_display_command): Don't call gdb_flush.
6774         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
6775         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
6776         * memattr.c (info_mem_command): Don't call gdb_flush.
6777         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
6778         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
6779         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
6780         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
6781         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
6782         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
6783         (gnu_nat_target::detach): Don't call gdb_flush.
6784         * f-valprint.c (f_val_print): Don't call gdb_flush.
6785         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
6786         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
6787         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
6788         gdb_flush.
6789         * c-valprint.c (c_val_print): Don't call gdb_flush.
6790         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
6791
6792 2019-03-05  Tom Tromey  <tromey@adacore.com>
6793
6794         * varobj.c (update_dynamic_varobj_children): Update.
6795         (install_default_visualizer): Use reset, not release.
6796         * value.c (set_internalvar): Update.
6797         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
6798         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
6799         ATTRIBUTE_UNUSED_RESULT.
6800
6801 2019-03-05  Tom Tromey  <tromey@adacore.com>
6802
6803         * remote.c (class scoped_remote_fd) <release>: Add
6804         ATTRIBUTE_UNUSED_RESULT.
6805
6806 2019-03-05  Tom Tromey  <tromey@adacore.com>
6807
6808         * macroexp.c (struct macro_buffer) <release>: Add
6809         ATTRIBUTE_UNUSED_RESULT.
6810
6811 2019-03-05  Tom Tromey  <tromey@adacore.com>
6812
6813         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
6814         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
6815         ATTRIBUTE_UNUSED_RESULT.
6816
6817 2019-03-05  Tom Tromey  <tromey@adacore.com>
6818
6819         * common/scoped_fd.h (class scoped_fd) <release>: Add
6820         ATTRIBUTE_UNUSED_RESULT.
6821
6822 2019-03-05  Tom Tromey  <tromey@adacore.com>
6823
6824         * parser-defs.h (struct parser_state) <release>: Add
6825         ATTRIBUTE_UNUSED_RESULT.
6826
6827 2019-03-05  Tom Tromey  <tromey@adacore.com>
6828
6829         * utils.h (class gdb_argv) <release>: Add
6830         ATTRIBUTE_UNUSED_RESULT.
6831         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
6832
6833 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
6834
6835         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
6836         for-loop range, to avoid compiler warnings.
6837
6838         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
6839         avoid compiler warnings about unused variables.
6840
6841         * NEWS: Mention end of support for native debugging on MS-Windows
6842         before XP.
6843
6844         PR gdb/24292
6845         * common/netstuff.c:
6846         * gdbserver/gdbreplay.c
6847         * gdbserver/remote-utils.c:
6848         * ser-tcp.c:
6849         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
6850         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
6851         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
6852         'getaddrinfo' and 'freeaddrinfo' were not available before
6853         Windows XP, and mingw.org's MinGW headers by default define
6854         _WIN32_WINNT to 0x500.
6855
6856 2019-03-01  Gary Benson <gbenson@redhat.com>
6857
6858         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
6859
6860 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
6861             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
6862
6863         PR gdb/8527
6864         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
6865         set_sigint_trap, clear_sigint_trap.
6866
6867 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6868
6869         * target.c (target_detach): Clear the regcache and the
6870         frame cache.
6871
6872 2019-02-27  Pedro Alves  <palves@redhat.com>
6873
6874         * utils.c (set_screen_size): When we cap the height/width sizes,
6875         tweak the corresponding command variable to show "unlimited":
6876
6877 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
6878             Pedro Alves  <palves@redhat.com>
6879
6880         * utils.c (set_screen_size): Reduce "infinite" rows and columns
6881         before calling rl_set_screen_size.
6882
6883 2019-02-27  Tom Tromey  <tromey@adacore.com>
6884
6885         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
6886         define.
6887         * python/py-value.c: Remove Python 2.4 workaround.
6888         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
6889         workaround.
6890         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
6891         Python 2.4 workaround.
6892         * python/python-internal.h: Remove Python 2.4 comment.
6893         (Py_ssize_t): Don't define.
6894         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
6895         (gdb_Py_DECREF): Remove Python 2.4 workaround.
6896         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
6897         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
6898         * python/python.c (do_start_initialization): Remove Python 2.4
6899         workaround.
6900         * python/py-prettyprint.c (class dummy_python_frame): Remove.
6901         (print_children): Remove Python 2.4 workaround.
6902         * python/py-inferior.c (buffer_procs): Remove Python 2.4
6903         workaround.
6904         (CHARBUFFERPROC_NAME): Remove.
6905         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
6906         Python 2.4 workaround.
6907
6908 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6909
6910         * NEWS: Note minimum Python version.
6911
6912 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6913
6914         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
6915         code from these functions.  Remove corresponding ifdefs.  Use
6916         Py_buffer_up instead of explicit calls to PyBuffer_Release.
6917         Remove gotos and target of gotos.
6918         (infpy_search_memory): Likewise.
6919
6920 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6921
6922         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
6923         (hppa_gdbarch_init): Don't register deleted functions with
6924         gdbarch.
6925
6926 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6927
6928         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
6929         (h8300_unwind_sp): Delete.
6930         (h8300_dummy_id): Delete.
6931         (h8300_gdbarch_init): Don't register deleted functions with
6932         gdbarch.
6933
6934 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6935
6936         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
6937         (ft32_unwind_pc): Delete.
6938         (ft32_unwind_sp): Delete.
6939         (ft32_gdbarch_init): Don't register deleted functions with
6940         gdbarch.
6941
6942 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6943
6944         * gdb/frv-tdep.c (frv_dummy_id): Delete.
6945         (frv_unwind_pc): Delete.
6946         (frv_unwind_sp): Delete.
6947         (frv_gdbarch_init): Don't register deleted functions with
6948         gdbarch.
6949
6950 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6951
6952         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
6953         (riscv_unwind_pc): Delete.
6954         (riscv_unwind_sp): Delete.
6955         (riscv_gdbarch_init): Don't register deleted functions with
6956         gdbarch.
6957
6958 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6959
6960         * gdb/csky-tdep.c (csky_dummy_id): Delete.
6961         (csky_unwind_pc): Delete.
6962         (csky_unwind_sp): Delete.
6963         (csky_gdbarch_init): Don't register deleted functions with
6964         gdbarch.
6965
6966 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6967
6968         * gdb/cris-tdep.c (cris_dummy_id): Delete.
6969         (cris_unwind_pc): Delete.
6970         (cris_unwind_sp): Delete.
6971         (cris_gdbarch_init): Don't register deleted functions with
6972         gdbarch.
6973
6974 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6975
6976         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
6977         (bfin_unwind_pc): Delete.
6978         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
6979
6980 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6981
6982         * gdb/arm-tdep.c (arm_dummy_id): Delete.
6983         (arm_unwind_pc): Delete.
6984         (arm_unwind_sp): Delete.
6985         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
6986
6987 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6988
6989         * gdb/arc-tdep.c (arc_dummy_id): Delete.
6990         (arc_unwind_pc): Delete.
6991         (arc_unwind_sp): Delete.
6992         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
6993
6994 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6995
6996         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
6997         (alpha_unwind_pc): Delete.
6998         (alpha_gdbarch_init): Don't register deleted functions with
6999         gdbarch.
7000
7001 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7002
7003         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7004         (aarch64_unwind_pc): Delete.
7005         (aarch64_unwind_sp): Delete.
7006         (aarch64_gdbarch_init): Don't register deleted functions with
7007         gdbarch.
7008
7009 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7010
7011         * gdbtypes.c (type_align): Don't consider static members when
7012         computing structure alignment.
7013
7014 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7015
7016         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7017         return 0 for other types.
7018         * arch-utils.c (default_type_align): Always return 0.
7019         * gdbarch.h: Regenerate.
7020         * gdbarch.sh (type_align): Extend comment.
7021         * gdbtypes.c (type_align): Add additional comments, always call
7022         gdbarch_type_align before applying the default rules.
7023         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7024         generic code will then apply a suitable default.
7025         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7026         types, return 0 for other types.
7027
7028 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7029
7030         * NEWS: Create a new section for the next release branch.
7031         Rename the section of the current branch, now that it has
7032         been cut.
7033
7034 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7035
7036         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7037         * version.in: Bump version to 8.3.50.DATE-git.
7038
7039 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7040
7041         * aix-thread.c (ptid_cmp): Remove unused variable.
7042         (get_signaled_thread): Likewise.
7043         (store_regs_user_thread): Likewise.
7044         (store_regs_kernel_thread): Likewise.
7045         (fetch_regs_kernel_thread): Remove shadowed variable.
7046
7047 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7048
7049         * features/riscv/32bit-cpu.xml: Add register numbers.
7050         * features/riscv/32bit-fpu.c: Regenerate.
7051         * features/riscv/32bit-fpu.xml: Add register numbers.
7052         * features/riscv/64bit-cpu.xml: Add register numbers.
7053         * features/riscv/64bit-fpu.c: Regenerate.
7054         * features/riscv/64bit-fpu.xml: Add register numbers.
7055
7056 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7057
7058         * NEWS: Mention two argument form of gdb.Value constructor.
7059         * python/py-value.c (convert_buffer_and_type_to_value): New
7060         function.
7061         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7062         Add support for handling an optional second argument.  Call
7063         convert_buffer_and_type_to_value as appropriate.
7064         * python/python-internal.h (Py_buffer_deleter): New struct.
7065         (Py_buffer_up): New typedef.
7066
7067 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7068
7069         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7070         instead of releasing ownership.
7071
7072 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7073
7074         * dwarf2read.c (open_and_init_dwp_file): Call
7075         elf_numsections instead of bfd_count_sections to initialize
7076         dwp_file->num_sections.
7077
7078 2019-02-25  Tom Tromey  <tromey@adacore.com>
7079
7080         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7081
7082 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7083
7084         * gcore.in: Add '--readnever' option when invoking GDB.
7085
7086 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7087
7088         * MAINTAINERS: Update my email address.
7089
7090 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7091
7092         * build-id.c (build_id_to_debug_bfd_1): New function.
7093         (build_id_to_debug_bfd): Look for separate debug file in
7094         sysroot.
7095
7096 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7097
7098         * gdbarch.sh: Update the copyright year range that is placed into
7099         generated files.
7100
7101 2019-02-22  Keith Seitz  <keiths@redhat.com>
7102
7103         PR symtab/23853
7104         * linespec.c (create_sals_line_offset): Search for the default
7105         symtab's filename instead of its fullname.
7106
7107 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7108
7109         * NEWS: Update style defaults.
7110
7111 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7112
7113         * main.c (captured_main_1): Disable styling in batch mode.
7114
7115 2019-02-20  Tom Tromey  <tom@tromey.com>
7116
7117         * symtab.c (symtab_symbol_info): Fix typos.
7118
7119 2019-02-20  Tom Tromey  <tromey@adacore.com>
7120
7121         * findcmd.c (_initialize_mem_search): Use upper case for
7122         metasyntactic variables.
7123
7124 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7125
7126         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7127         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7128
7129 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7130
7131         * top.h (source_file_name): Change to std::string.
7132         * top.c (source_file_name): Likewise.
7133         (command_line_input): Adjust.
7134         * cli/cli-script.c (script_from_file): Adjust.
7135
7136 2019-02-19  Tom Tromey  <tromey@adacore.com>
7137
7138         * ravenscar-thread.c
7139         (ravenscar_thread_target::update_thread_list): Don't call
7140         ada_build_task_list.
7141         * ada-lang.h (ada_build_task_list): Don't declare.
7142         * ada-tasks.c (struct ada_tasks_inferior_data)
7143         <task_list_valid_p>: Now bool.
7144         (read_known_tasks, ada_task_list_changed)
7145         (ada_tasks_invalidate_inferior_data): Update.
7146         (read_known_tasks_array): Return bool.
7147         (read_known_tasks_list): Likewise.
7148         (read_known_tasks): Return void.
7149         (ada_build_task_list): Now static.
7150
7151 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7152
7153         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
7154         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
7155
7156 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7157
7158         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
7159         variant for ada_tasks_pspace_data_handle and
7160         ada_tasks_inferior_data_handle.
7161         (ada_tasks_pspace_data_cleanup): New function.
7162         (ada_tasks_inferior_data_cleanup): New function.
7163
7164 2019-02-17  Tom Tromey  <tom@tromey.com>
7165
7166         * macrotab.h (macro_source_fullname): Return a std::string.
7167         * macrotab.c (macro_include, check_for_redefinition)
7168         (macro_undef, macro_lookup_definition, foreach_macro)
7169         (foreach_macro_in_scope): Update.
7170         (macro_source_fullname): Return a std::string.
7171         * macrocmd.c (show_pp_source_pos): Update.
7172
7173 2019-02-17  Tom Tromey  <tom@tromey.com>
7174
7175         * macrocmd.c (show_pp_source_pos): Style the file names.
7176
7177 2019-02-17  Tom Tromey  <tom@tromey.com>
7178
7179         PR tui/24197:
7180         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
7181
7182 2019-02-17  Tom Tromey  <tom@tromey.com>
7183
7184         * ada-lang.c (user_select_syms): Use filtered printing.
7185         * utils.c (wrap_style): New global.
7186         (desired_style): Remove.
7187         (emit_style_escape): Add stream parameter.
7188         (set_output_style, reset_terminal_style, prompt_for_continue):
7189         Update.
7190         (flush_wrap_buffer): Only flush gdb_stdout.
7191         (wrap_here): Set wrap_style.
7192         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
7193         treat escape sequences as a character.  Change when wrap buffer is
7194         flushed.
7195         (fputs_styled): Do not set the output style when the default is
7196         requested.
7197         * ui-style.h (struct ui_file_style) <is_default>: New method.
7198         * source.c (print_source_lines_base): Emit escape sequences in one
7199         piece.
7200
7201 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7202
7203         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
7204         integers and enumeration types.
7205
7206 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7207
7208         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
7209         instead of lookup_symbol_in_language
7210         (do_exact_match): New function.
7211         (ada_get_symbol_name_matcher): Return do_exact_match when
7212         doing a verbatim match.
7213
7214 2019-02-15  Tom Tromey  <tromey@adacore.com>
7215
7216         * ravenscar-thread.c (ravenscar_thread_target::resume)
7217         (ravenscar_thread_target::wait): Special case wildcard requests.
7218
7219 2019-02-15  Tom Tromey  <tromey@adacore.com>
7220
7221         * ravenscar-thread.c (base_ptid): Remove.
7222         (struct ravenscar_thread_target) <close>: New method.
7223         <m_base_ptid>: New member.
7224         <update_inferior_ptid, active_task, task_is_currently_active,
7225         runtime_initialized>: Declare methods.
7226         <ravenscar_thread_target>: Add constructor.
7227         (ravenscar_thread_target::task_is_currently_active)
7228         (ravenscar_thread_target::update_inferior_ptid)
7229         (ravenscar_runtime_initialized): Rename.  Now methods.
7230         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
7231         (ravenscar_thread_target::update_thread_list): Update.
7232         (ravenscar_thread_target::active_task): Now method.
7233         (ravenscar_thread_target::store_registers)
7234         (ravenscar_thread_target::prepare_to_store)
7235         (ravenscar_thread_target::prepare_to_store)
7236         (ravenscar_thread_target::mourn_inferior): Update.
7237         (ravenscar_inferior_created): Use "new" to create target.
7238         (ravenscar_thread_target::get_ada_task_ptid): Update.
7239         (_initialize_ravenscar): Don't initialize base_ptid.
7240         (ravenscar_ops): Remove global.
7241
7242 2019-02-15  Tom Tromey  <tromey@adacore.com>
7243
7244         * target.h (push_target): Declare new overload.
7245         * target.c (push_target): New overload, taking an rvalue reference.
7246         * remote.c (remote_target::open_1): Use push_target overload.
7247         * corelow.c (core_target_open): Use push_target overload.
7248
7249 2019-02-15  Tom Tromey  <tromey@adacore.com>
7250
7251         * ravenscar-thread.c (is_ravenscar_task)
7252         (ravenscar_task_is_currently_active): Return bool.
7253         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
7254         (_initialize_ravenscar): Remove "(void)".
7255         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
7256         Return bool.
7257
7258 2019-02-15  Tom Tromey  <tromey@adacore.com>
7259
7260         * ravenscar-thread.c (ravenscar_runtime_initializer)
7261         (has_ravenscar_runtime, get_running_thread_id)
7262         (ravenscar_thread_target::resume): Fix indentation.
7263
7264 2019-02-15  Tom Tromey  <tromey@adacore.com>
7265
7266         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
7267         from ravenscar_arch_ops.
7268         (sparc_ravenscar_ops::fetch_registers)
7269         (sparc_ravenscar_ops::store_registers): Now methods.
7270         (sparc_ravenscar_prepare_to_store): Remove.
7271         (sparc_ravenscar_ops): Redefine.
7272         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
7273         methods and destructor.  Remove members.
7274         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
7275         (ravenscar_thread_target::store_registers)
7276         (ravenscar_thread_target::prepare_to_store): Update.
7277         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
7278         Remove.
7279         (struct ppc_ravenscar_powerpc_ops): Derive from
7280         ravenscar_arch_ops.
7281         (ppc_ravenscar_powerpc_ops::fetch_registers)
7282         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
7283         (ppc_ravenscar_powerpc_ops): Redefine.
7284         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
7285         (ppc_ravenscar_e500_ops::fetch_registers)
7286         (ppc_ravenscar_e500_ops::store_registers): Now methods.
7287         (ppc_ravenscar_e500_ops): Redefine.
7288         * aarch64-ravenscar-thread.c
7289         (aarch64_ravenscar_generic_prepare_to_store): Remove.
7290         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
7291         (aarch64_ravenscar_fetch_registers)
7292         (aarch64_ravenscar_store_registers): Now methods.
7293         (aarch64_ravenscar_ops): Redefine.
7294
7295 2019-02-15  Tom Tromey  <tromey@adacore.com>
7296
7297         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
7298         (ravenscar_thread_target::stopped_by_hw_breakpoint)
7299         (ravenscar_thread_target::stopped_by_watchpoint)
7300         (ravenscar_thread_target::stopped_data_address)
7301         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
7302
7303 2019-02-15  Tom Tromey  <tromey@adacore.com>
7304
7305         * ravenscar-thread.c: Fix some typos.
7306
7307 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7308             Tom Tromey  <tromey@adacore.com>
7309
7310         * ada-lang.c (ada_exception_sal): Change addr_string to a
7311         std::string.
7312         (create_ada_exception_catchpoint): Update.
7313
7314 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7315             Tom Tromey  <tromey@adacore.com>
7316
7317         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
7318         (bp_location_ops): Remove.
7319         (base_breakpoint_allocate_location): Update.
7320         (free_bp_location): Update.
7321         * ada-lang.c (class ada_catchpoint_location)
7322         <ada_catchpoint_location>: Remove ops parameter.
7323         (ada_catchpoint_location_dtor): Remove.
7324         (ada_catchpoint_location_ops): Remove.
7325         (allocate_location_exception): Update.
7326         * breakpoint.h (struct bp_location_ops): Remove.
7327         (class bp_location) <bp_location>: Remove bp_location_ops
7328         parameter.
7329         <~bp_location>: Add destructor.
7330         <ops>: Remove.
7331
7332 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7333             Pedro Alves  <palves@redhat.com>
7334
7335         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
7336         'PATH_MAX'.
7337
7338 2019-02-14  David Michael  <fedora.dm0@gmail.com>
7339             Samuel Thibault  <samuel.thibault@gnu.org>
7340             Thomas Schwinge  <thomas@codesourcery.com>
7341
7342         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
7343         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
7344
7345 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7346
7347         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
7348         (check_empty): Use "const char *".
7349
7350         * gnu-nat.c (gnu_nat_target::detach): Instead of
7351         'detach_inferior (pid)' call
7352         'detach_inferior (find_inferior_pid (pid))'.
7353
7354         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
7355         'nat/fork-inferior.o'.
7356         * gnu-nat.c: #include "nat/fork-inferior.h".
7357
7358         * gnu-nat.c (gnu_nat_target::detach): Instead of
7359         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
7360         * gnu-nat.h: #include "inf-child.h".
7361         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
7362         'i386_gnu_nat_target::fetch_registers'.
7363         (gnu_store_registers): Rename/move to
7364         'i386_gnu_nat_target::store_registers'.
7365
7366         * config/i386/nm-i386gnu.h: Don't "#include" any files.
7367         * gnu-nat.h (mach_thread_info): New function.
7368         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
7369
7370         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
7371
7372 2019-02-14  Frederic Konrad  <konrad@adacore.com>
7373
7374         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
7375
7376 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
7377
7378         * windows-nat.c (windows_add_thread): Add new parameter
7379         "main_thread_p" with default value set to false.  Update
7380         function documentation as well as all callers.
7381         (windows_delete_thread): Likewise.
7382         (fake_create_process): Update call to windows_add_thread.
7383         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
7384         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
7385         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
7386         call to windows_delete_thread.
7387
7388 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
7389
7390         * MAINTAINERS: Add Andrew Burgess as global maintainer.
7391
7392 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7393
7394         * symfile.c (find_separate_debug_file): Use canonical path of
7395         sysroot with child_path instead of gdb_sysroot if it is valid.
7396
7397 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7398
7399         * symfile.c (find_separate_debug_file): Use child_path to
7400         determine if an object file is under a sysroot.
7401
7402 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7403
7404         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
7405         unittests/child-path-selftests.c.
7406         * common/pathstuff.c (child_path): New function.
7407         * common/pathstuff.h (child_path): New prototype.
7408         * unittests/child-path-selftests.c: New file.
7409
7410 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7411
7412         * symfile.c (find_separate_debug_file): Look for separate debug
7413         files in debug directories under the sysroot.
7414
7415 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7416
7417         * symtab.h (struct minimal_symbol data_p): New const method.
7418         (struct minimal_symbol text_p): Likewise.
7419         * symtab.c (output_source_filename): Use file name style
7420         to print file name.
7421         (print_symbol_info): Likewise.
7422         (print_msymbol_info): Use address style to print addresses.
7423         Use function name style to print executable text symbols.
7424         (expand_symtab_containing_pc): Use data_p.
7425         (find_pc_sect_compunit_symtab): Likewise.
7426
7427 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7428
7429         * breakpoint.c (describe_other_breakpoints): Use address style
7430         to print addresses.
7431         (say_where): Likewise.
7432
7433 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7434
7435         * ada-typeprint.c (print_func_type): Print function name
7436         style to print function name.
7437         * c-typeprint.c (c_print_type_1): Likewise.
7438
7439 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
7440
7441         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
7442         for execve.
7443
7444 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7445
7446         * c-exp.y (direct_abs_decl): Use emplace_back to record the
7447         type_stack.
7448
7449 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
7450
7451         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
7452         TYPE_CODE_REF types.
7453
7454 2019-02-08  Jim Wilson  <jimw@sifive.com>
7455
7456         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
7457         (riscv_linux_fregset): New.
7458         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
7459
7460 2019-02-07  Tom Tromey  <tom@tromey.com>
7461
7462         * thread.c (thread_cancel_execution_command): Update.
7463         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
7464         methods.
7465         (struct thread_fsm_ops): Remove.
7466         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
7467         (thread_fsm_should_stop, thread_fsm_return_value)
7468         (thread_fsm_set_finished, thread_fsm_finished_p)
7469         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
7470         Don't declare.
7471         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
7472         * infrun.c (clear_proceed_status_thread)
7473         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
7474         (print_stop_event): Update.
7475         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
7476         Add constructor.
7477         (step_command_fsm_ops): Remove.
7478         (new_step_command_fsm): Remove.
7479         (step_1): Update.
7480         (step_command_fsm::should_stop): Rename from
7481         step_command_fsm_should_stop.
7482         (step_command_fsm::clean_up): Rename from
7483         step_command_fsm_clean_up.
7484         (step_command_fsm::do_async_reply_reason): Rename from
7485         step_command_fsm_async_reply_reason.
7486         (struct until_next_fsm): Inherit from thread_fsm.  Add
7487         constructor.
7488         (until_next_fsm_ops): Remove.
7489         (new_until_next_fsm): Remove.
7490         (until_next_fsm::should_stop): Rename from
7491         until_next_fsm_should_stop.
7492         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
7493         (until_next_fsm::do_async_reply_reason): Rename from
7494         until_next_fsm_async_reply_reason.
7495         (struct finish_command_fsm): Inherit from thread_fsm.  Add
7496         constructor.  Change type of breakpoint.
7497         (finish_command_fsm_ops): Remove.
7498         (new_finish_command_fsm): Remove.
7499         (finish_command_fsm::should_stop): Rename from
7500         finish_command_fsm_should_stop.
7501         (finish_command_fsm::clean_up): Rename from
7502         finish_command_fsm_clean_up.
7503         (finish_command_fsm::return_value): Rename from
7504         finish_command_fsm_return_value.
7505         (finish_command_fsm::do_async_reply_reason): Rename from
7506         finish_command_fsm_async_reply_reason.
7507         (finish_command): Update.
7508         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
7509         Add constructor.
7510         (call_thread_fsm_ops): Remove.
7511         (call_thread_fsm::call_thread_fsm): Rename from
7512         new_call_thread_fsm.
7513         (call_thread_fsm::should_stop): Rename from
7514         call_thread_fsm_should_stop.
7515         (call_thread_fsm::should_notify_stop): Rename from
7516         call_thread_fsm_should_notify_stop.
7517         (run_inferior_call, call_function_by_hand_dummy): Update.
7518         * cli/cli-interp.c (should_print_stop_to_console): Update.
7519         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
7520         Add constructor.  Change type of location_breakpoint,
7521         caller_breakpoint.
7522         (until_break_fsm_ops): Remove.
7523         (new_until_break_fsm): Remove.
7524         (until_break_fsm::should_stop): Rename from
7525         until_break_fsm_should_stop.
7526         (until_break_fsm::clean_up): Rename from
7527         until_break_fsm_clean_up.
7528         (until_break_fsm::do_async_reply_reason): Rename from
7529         until_break_fsm_async_reply_reason.
7530         (until_break_command): Update.
7531         * thread-fsm.c: Remove.
7532         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
7533
7534 2019-02-07  Tom Tromey  <tom@tromey.com>
7535
7536         * yy-remap.h: Add include guard.
7537         * xtensa-tdep.h: Add include guard.
7538         * xcoffread.h: Rename include guard.
7539         * varobj-iter.h: Add include guard.
7540         * tui/tui.h: Rename include guard.
7541         * tui/tui-winsource.h: Rename include guard.
7542         * tui/tui-wingeneral.h: Rename include guard.
7543         * tui/tui-windata.h: Rename include guard.
7544         * tui/tui-win.h: Rename include guard.
7545         * tui/tui-stack.h: Rename include guard.
7546         * tui/tui-source.h: Rename include guard.
7547         * tui/tui-regs.h: Rename include guard.
7548         * tui/tui-out.h: Rename include guard.
7549         * tui/tui-layout.h: Rename include guard.
7550         * tui/tui-io.h: Rename include guard.
7551         * tui/tui-hooks.h: Rename include guard.
7552         * tui/tui-file.h: Rename include guard.
7553         * tui/tui-disasm.h: Rename include guard.
7554         * tui/tui-data.h: Rename include guard.
7555         * tui/tui-command.h: Rename include guard.
7556         * tic6x-tdep.h: Add include guard.
7557         * target/waitstatus.h: Rename include guard.
7558         * target/wait.h: Rename include guard.
7559         * target/target.h: Rename include guard.
7560         * target/resume.h: Rename include guard.
7561         * target-float.h: Rename include guard.
7562         * stabsread.h: Add include guard.
7563         * rs6000-tdep.h: Add include guard.
7564         * riscv-fbsd-tdep.h: Add include guard.
7565         * regformats/regdef.h: Rename include guard.
7566         * record.h: Rename include guard.
7567         * python/python.h: Rename include guard.
7568         * python/python-internal.h: Rename include guard.
7569         * python/py-stopevent.h: Rename include guard.
7570         * python/py-ref.h: Rename include guard.
7571         * python/py-record.h: Rename include guard.
7572         * python/py-record-full.h: Rename include guard.
7573         * python/py-record-btrace.h: Rename include guard.
7574         * python/py-instruction.h: Rename include guard.
7575         * python/py-events.h: Rename include guard.
7576         * python/py-event.h: Rename include guard.
7577         * procfs.h: Add include guard.
7578         * proc-utils.h: Add include guard.
7579         * p-lang.h: Add include guard.
7580         * or1k-tdep.h: Rename include guard.
7581         * observable.h: Rename include guard.
7582         * nto-tdep.h: Rename include guard.
7583         * nat/x86-linux.h: Rename include guard.
7584         * nat/x86-linux-dregs.h: Rename include guard.
7585         * nat/x86-gcc-cpuid.h: Add include guard.
7586         * nat/x86-dregs.h: Rename include guard.
7587         * nat/x86-cpuid.h: Rename include guard.
7588         * nat/ppc-linux.h: Rename include guard.
7589         * nat/mips-linux-watch.h: Rename include guard.
7590         * nat/linux-waitpid.h: Rename include guard.
7591         * nat/linux-ptrace.h: Rename include guard.
7592         * nat/linux-procfs.h: Rename include guard.
7593         * nat/linux-osdata.h: Rename include guard.
7594         * nat/linux-nat.h: Rename include guard.
7595         * nat/linux-namespaces.h: Rename include guard.
7596         * nat/linux-btrace.h: Rename include guard.
7597         * nat/glibc_thread_db.h: Rename include guard.
7598         * nat/gdb_thread_db.h: Rename include guard.
7599         * nat/gdb_ptrace.h: Rename include guard.
7600         * nat/fork-inferior.h: Rename include guard.
7601         * nat/amd64-linux-siginfo.h: Rename include guard.
7602         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
7603         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
7604         * nat/aarch64-linux.h: Rename include guard.
7605         * nat/aarch64-linux-hw-point.h: Rename include guard.
7606         * mn10300-tdep.h: Add include guard.
7607         * mips-linux-tdep.h: Add include guard.
7608         * mi/mi-parse.h: Rename include guard.
7609         * mi/mi-out.h: Rename include guard.
7610         * mi/mi-main.h: Rename include guard.
7611         * mi/mi-interp.h: Rename include guard.
7612         * mi/mi-getopt.h: Rename include guard.
7613         * mi/mi-console.h: Rename include guard.
7614         * mi/mi-common.h: Rename include guard.
7615         * mi/mi-cmds.h: Rename include guard.
7616         * mi/mi-cmd-break.h: Rename include guard.
7617         * m2-lang.h: Add include guard.
7618         * location.h: Rename include guard.
7619         * linux-record.h: Rename include guard.
7620         * linux-nat.h: Add include guard.
7621         * linux-fork.h: Add include guard.
7622         * i386-darwin-tdep.h: Rename include guard.
7623         * hppa-linux-offsets.h: Add include guard.
7624         * guile/guile.h: Rename include guard.
7625         * guile/guile-internal.h: Rename include guard.
7626         * gnu-nat.h: Rename include guard.
7627         * gdb-stabs.h: Rename include guard.
7628         * frv-tdep.h: Add include guard.
7629         * f-lang.h: Add include guard.
7630         * event-loop.h: Add include guard.
7631         * darwin-nat.h: Rename include guard.
7632         * cp-abi.h: Rename include guard.
7633         * config/sparc/nm-sol2.h: Rename include guard.
7634         * config/nm-nto.h: Rename include guard.
7635         * config/nm-linux.h: Add include guard.
7636         * config/i386/nm-i386gnu.h: Rename include guard.
7637         * config/djgpp/nl_types.h: Rename include guard.
7638         * config/djgpp/langinfo.h: Rename include guard.
7639         * compile/gcc-cp-plugin.h: Add include guard.
7640         * compile/gcc-c-plugin.h: Add include guard.
7641         * compile/compile.h: Rename include guard.
7642         * compile/compile-object-run.h: Rename include guard.
7643         * compile/compile-object-load.h: Rename include guard.
7644         * compile/compile-internal.h: Rename include guard.
7645         * compile/compile-cplus.h: Rename include guard.
7646         * compile/compile-c.h: Rename include guard.
7647         * common/xml-utils.h: Rename include guard.
7648         * common/x86-xstate.h: Rename include guard.
7649         * common/version.h: Rename include guard.
7650         * common/vec.h: Rename include guard.
7651         * common/tdesc.h: Rename include guard.
7652         * common/selftest.h: Rename include guard.
7653         * common/scoped_restore.h: Rename include guard.
7654         * common/scoped_mmap.h: Rename include guard.
7655         * common/scoped_fd.h: Rename include guard.
7656         * common/safe-iterator.h: Rename include guard.
7657         * common/run-time-clock.h: Rename include guard.
7658         * common/refcounted-object.h: Rename include guard.
7659         * common/queue.h: Rename include guard.
7660         * common/ptid.h: Rename include guard.
7661         * common/print-utils.h: Rename include guard.
7662         * common/preprocessor.h: Rename include guard.
7663         * common/pathstuff.h: Rename include guard.
7664         * common/observable.h: Rename include guard.
7665         * common/netstuff.h: Rename include guard.
7666         * common/job-control.h: Rename include guard.
7667         * common/host-defs.h: Rename include guard.
7668         * common/gdb_wait.h: Rename include guard.
7669         * common/gdb_vecs.h: Rename include guard.
7670         * common/gdb_unlinker.h: Rename include guard.
7671         * common/gdb_unique_ptr.h: Rename include guard.
7672         * common/gdb_tilde_expand.h: Rename include guard.
7673         * common/gdb_sys_time.h: Rename include guard.
7674         * common/gdb_string_view.h: Rename include guard.
7675         * common/gdb_splay_tree.h: Rename include guard.
7676         * common/gdb_setjmp.h: Rename include guard.
7677         * common/gdb_ref_ptr.h: Rename include guard.
7678         * common/gdb_optional.h: Rename include guard.
7679         * common/gdb_locale.h: Rename include guard.
7680         * common/gdb_assert.h: Rename include guard.
7681         * common/filtered-iterator.h: Rename include guard.
7682         * common/filestuff.h: Rename include guard.
7683         * common/fileio.h: Rename include guard.
7684         * common/environ.h: Rename include guard.
7685         * common/common-utils.h: Rename include guard.
7686         * common/common-types.h: Rename include guard.
7687         * common/common-regcache.h: Rename include guard.
7688         * common/common-inferior.h: Rename include guard.
7689         * common/common-gdbthread.h: Rename include guard.
7690         * common/common-exceptions.h: Rename include guard.
7691         * common/common-defs.h: Rename include guard.
7692         * common/common-debug.h: Rename include guard.
7693         * common/cleanups.h: Rename include guard.
7694         * common/buffer.h: Rename include guard.
7695         * common/btrace-common.h: Rename include guard.
7696         * common/break-common.h: Rename include guard.
7697         * cli/cli-utils.h: Rename include guard.
7698         * cli/cli-style.h: Rename include guard.
7699         * cli/cli-setshow.h: Rename include guard.
7700         * cli/cli-script.h: Rename include guard.
7701         * cli/cli-interp.h: Rename include guard.
7702         * cli/cli-decode.h: Rename include guard.
7703         * cli/cli-cmds.h: Rename include guard.
7704         * charset-list.h: Add include guard.
7705         * buildsym-legacy.h: Rename include guard.
7706         * bfin-tdep.h: Add include guard.
7707         * ax.h: Rename include guard.
7708         * arm-linux-tdep.h: Add include guard.
7709         * arm-fbsd-tdep.h: Add include guard.
7710         * arch/xtensa.h: Rename include guard.
7711         * arch/tic6x.h: Add include guard.
7712         * arch/i386.h: Add include guard.
7713         * arch/arm.h: Rename include guard.
7714         * arch/arm-linux.h: Rename include guard.
7715         * arch/arm-get-next-pcs.h: Rename include guard.
7716         * arch/amd64.h: Add include guard.
7717         * arch/aarch64-insn.h: Rename include guard.
7718         * arch-utils.h: Rename include guard.
7719         * annotate.h: Add include guard.
7720         * amd64-darwin-tdep.h: Rename include guard.
7721         * aarch64-linux-tdep.h: Add include guard.
7722         * aarch64-fbsd-tdep.h: Add include guard.
7723         * aarch32-linux-nat.h: Add include guard.
7724
7725 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7726
7727         * macrotab.c (macro_define_internal): New function that
7728         factorizes macro_define_object_internal and macro_define_function
7729         code.
7730         (macro_define_object_internal): Use macro_define_internal.
7731         (macro_define_function): Likewise.
7732
7733 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7734
7735         * macrocmd.c (extract_identifier): Return
7736         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
7737         callers.
7738
7739 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
7740
7741         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
7742
7743 2019-02-05  Tom Tromey  <tom@tromey.com>
7744
7745         * target.c (target_stack::unpush): Move assertion earlier.
7746
7747 2019-01-30  Tom Tromey  <tom@tromey.com>
7748
7749         PR python/23615:
7750         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
7751         (gdbpy_parse_and_eval): Likewise.
7752         * python/python-internal.h (gdbpy_allow_threads): New class.
7753
7754 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
7755
7756         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
7757         (aarch64_fbsd_fpregmap): Move earlier.
7758         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
7759         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7760         instead of individual calls to trad_frame_set_reg_addr.
7761         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
7762         earlier.
7763         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
7764         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7765         instead of individual calls to trad_frame_set_reg_addr.
7766
7767 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
7768
7769         * CONTRIBUTE: Replace contribution list with wiki link.
7770
7771 2019-01-25  Tom Tromey  <tom@tromey.com>
7772
7773         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
7774
7775 2019-01-25  Tom Tromey  <tom@tromey.com>
7776
7777         * xtensa-linux-nat.c: Fix common/ includes.
7778         * xml-support.h: Fix common/ includes.
7779         * xml-support.c: Fix common/ includes.
7780         * x86-linux-nat.c: Fix common/ includes.
7781         * windows-nat.c: Fix common/ includes.
7782         * varobj.h: Fix common/ includes.
7783         * varobj.c: Fix common/ includes.
7784         * value.c: Fix common/ includes.
7785         * valops.c: Fix common/ includes.
7786         * utils.c: Fix common/ includes.
7787         * unittests/xml-utils-selftests.c: Fix common/ includes.
7788         * unittests/utils-selftests.c: Fix common/ includes.
7789         * unittests/unpack-selftests.c: Fix common/ includes.
7790         * unittests/tracepoint-selftests.c: Fix common/ includes.
7791         * unittests/style-selftests.c: Fix common/ includes.
7792         * unittests/string_view-selftests.c: Fix common/ includes.
7793         * unittests/scoped_restore-selftests.c: Fix common/ includes.
7794         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
7795         * unittests/scoped_fd-selftests.c: Fix common/ includes.
7796         * unittests/rsp-low-selftests.c: Fix common/ includes.
7797         * unittests/parse-connection-spec-selftests.c: Fix common/
7798         includes.
7799         * unittests/optional-selftests.c: Fix common/ includes.
7800         * unittests/offset-type-selftests.c: Fix common/ includes.
7801         * unittests/observable-selftests.c: Fix common/ includes.
7802         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
7803         * unittests/memrange-selftests.c: Fix common/ includes.
7804         * unittests/memory-map-selftests.c: Fix common/ includes.
7805         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
7806         * unittests/function-view-selftests.c: Fix common/ includes.
7807         * unittests/environ-selftests.c: Fix common/ includes.
7808         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
7809         * unittests/common-utils-selftests.c: Fix common/ includes.
7810         * unittests/cli-utils-selftests.c: Fix common/ includes.
7811         * unittests/array-view-selftests.c: Fix common/ includes.
7812         * ui-file.c: Fix common/ includes.
7813         * tui/tui-io.c: Fix common/ includes.
7814         * tracepoint.h: Fix common/ includes.
7815         * tracepoint.c: Fix common/ includes.
7816         * tracefile-tfile.c: Fix common/ includes.
7817         * top.h: Fix common/ includes.
7818         * top.c: Fix common/ includes.
7819         * thread.c: Fix common/ includes.
7820         * target/waitstatus.h: Fix common/ includes.
7821         * target/waitstatus.c: Fix common/ includes.
7822         * target.h: Fix common/ includes.
7823         * target.c: Fix common/ includes.
7824         * target-memory.c: Fix common/ includes.
7825         * target-descriptions.c: Fix common/ includes.
7826         * symtab.h: Fix common/ includes.
7827         * symfile.c: Fix common/ includes.
7828         * stap-probe.c: Fix common/ includes.
7829         * spu-linux-nat.c: Fix common/ includes.
7830         * sparc-nat.c: Fix common/ includes.
7831         * source.c: Fix common/ includes.
7832         * solib.c: Fix common/ includes.
7833         * solib-target.c: Fix common/ includes.
7834         * ser-unix.c: Fix common/ includes.
7835         * ser-tcp.c: Fix common/ includes.
7836         * ser-pipe.c: Fix common/ includes.
7837         * ser-base.c: Fix common/ includes.
7838         * selftest-arch.c: Fix common/ includes.
7839         * s12z-tdep.c: Fix common/ includes.
7840         * rust-exp.y: Fix common/ includes.
7841         * rs6000-aix-tdep.c: Fix common/ includes.
7842         * riscv-tdep.c: Fix common/ includes.
7843         * remote.c: Fix common/ includes.
7844         * remote-notif.h: Fix common/ includes.
7845         * remote-fileio.h: Fix common/ includes.
7846         * remote-fileio.c: Fix common/ includes.
7847         * regcache.h: Fix common/ includes.
7848         * regcache.c: Fix common/ includes.
7849         * record-btrace.c: Fix common/ includes.
7850         * python/python.c: Fix common/ includes.
7851         * python/py-type.c: Fix common/ includes.
7852         * python/py-inferior.c: Fix common/ includes.
7853         * progspace.h: Fix common/ includes.
7854         * producer.c: Fix common/ includes.
7855         * procfs.c: Fix common/ includes.
7856         * proc-api.c: Fix common/ includes.
7857         * printcmd.c: Fix common/ includes.
7858         * ppc-linux-nat.c: Fix common/ includes.
7859         * parser-defs.h: Fix common/ includes.
7860         * osdata.c: Fix common/ includes.
7861         * obsd-nat.c: Fix common/ includes.
7862         * nat/x86-linux.c: Fix common/ includes.
7863         * nat/x86-linux-dregs.c: Fix common/ includes.
7864         * nat/x86-dregs.h: Fix common/ includes.
7865         * nat/x86-dregs.c: Fix common/ includes.
7866         * nat/ppc-linux.c: Fix common/ includes.
7867         * nat/mips-linux-watch.h: Fix common/ includes.
7868         * nat/mips-linux-watch.c: Fix common/ includes.
7869         * nat/linux-waitpid.c: Fix common/ includes.
7870         * nat/linux-ptrace.h: Fix common/ includes.
7871         * nat/linux-ptrace.c: Fix common/ includes.
7872         * nat/linux-procfs.c: Fix common/ includes.
7873         * nat/linux-personality.c: Fix common/ includes.
7874         * nat/linux-osdata.c: Fix common/ includes.
7875         * nat/linux-namespaces.c: Fix common/ includes.
7876         * nat/linux-btrace.h: Fix common/ includes.
7877         * nat/linux-btrace.c: Fix common/ includes.
7878         * nat/fork-inferior.c: Fix common/ includes.
7879         * nat/amd64-linux-siginfo.c: Fix common/ includes.
7880         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
7881         * nat/aarch64-linux.c: Fix common/ includes.
7882         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
7883         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
7884         * namespace.h: Fix common/ includes.
7885         * mips-linux-tdep.c: Fix common/ includes.
7886         * minsyms.c: Fix common/ includes.
7887         * mi/mi-parse.h: Fix common/ includes.
7888         * mi/mi-main.c: Fix common/ includes.
7889         * mi/mi-cmd-env.c: Fix common/ includes.
7890         * memrange.h: Fix common/ includes.
7891         * memattr.c: Fix common/ includes.
7892         * maint.h: Fix common/ includes.
7893         * maint.c: Fix common/ includes.
7894         * main.c: Fix common/ includes.
7895         * machoread.c: Fix common/ includes.
7896         * location.c: Fix common/ includes.
7897         * linux-thread-db.c: Fix common/ includes.
7898         * linux-nat.c: Fix common/ includes.
7899         * linux-fork.c: Fix common/ includes.
7900         * inline-frame.c: Fix common/ includes.
7901         * infrun.c: Fix common/ includes.
7902         * inflow.c: Fix common/ includes.
7903         * inferior.h: Fix common/ includes.
7904         * inferior.c: Fix common/ includes.
7905         * infcmd.c: Fix common/ includes.
7906         * inf-ptrace.c: Fix common/ includes.
7907         * inf-child.c: Fix common/ includes.
7908         * ia64-linux-nat.c: Fix common/ includes.
7909         * i387-tdep.c: Fix common/ includes.
7910         * i386-tdep.c: Fix common/ includes.
7911         * i386-linux-tdep.c: Fix common/ includes.
7912         * i386-linux-nat.c: Fix common/ includes.
7913         * i386-go32-tdep.c: Fix common/ includes.
7914         * i386-fbsd-tdep.c: Fix common/ includes.
7915         * i386-fbsd-nat.c: Fix common/ includes.
7916         * guile/scm-type.c: Fix common/ includes.
7917         * guile/guile.c: Fix common/ includes.
7918         * go32-nat.c: Fix common/ includes.
7919         * gnu-nat.c: Fix common/ includes.
7920         * gdbthread.h: Fix common/ includes.
7921         * gdbarch-selftests.c: Fix common/ includes.
7922         * gdb_usleep.c: Fix common/ includes.
7923         * gdb_select.h: Fix common/ includes.
7924         * gdb_bfd.c: Fix common/ includes.
7925         * gcore.c: Fix common/ includes.
7926         * fork-child.c: Fix common/ includes.
7927         * findvar.c: Fix common/ includes.
7928         * fbsd-nat.c: Fix common/ includes.
7929         * event-top.c: Fix common/ includes.
7930         * event-loop.c: Fix common/ includes.
7931         * dwarf2read.c: Fix common/ includes.
7932         * dwarf2loc.c: Fix common/ includes.
7933         * dwarf2-frame.c: Fix common/ includes.
7934         * dwarf-index-cache.c: Fix common/ includes.
7935         * dtrace-probe.c: Fix common/ includes.
7936         * disasm-selftests.c: Fix common/ includes.
7937         * defs.h: Fix common/ includes.
7938         * csky-tdep.c: Fix common/ includes.
7939         * cp-valprint.c: Fix common/ includes.
7940         * cp-support.h: Fix common/ includes.
7941         * cp-support.c: Fix common/ includes.
7942         * corelow.c: Fix common/ includes.
7943         * completer.h: Fix common/ includes.
7944         * completer.c: Fix common/ includes.
7945         * compile/compile.c: Fix common/ includes.
7946         * compile/compile-loc2c.c: Fix common/ includes.
7947         * compile/compile-cplus-types.c: Fix common/ includes.
7948         * compile/compile-cplus-symbols.c: Fix common/ includes.
7949         * command.h: Fix common/ includes.
7950         * cli/cli-dump.c: Fix common/ includes.
7951         * cli/cli-cmds.c: Fix common/ includes.
7952         * charset.c: Fix common/ includes.
7953         * build-id.c: Fix common/ includes.
7954         * btrace.h: Fix common/ includes.
7955         * btrace.c: Fix common/ includes.
7956         * breakpoint.h: Fix common/ includes.
7957         * breakpoint.c: Fix common/ includes.
7958         * ax.h:
7959         (enum agent_op): Fix common/ includes.
7960         * ax-general.c (struct aop_map): Fix common/ includes.
7961         * ax-gdb.c: Fix common/ includes.
7962         * auxv.c: Fix common/ includes.
7963         * auto-load.c: Fix common/ includes.
7964         * arm-tdep.c: Fix common/ includes.
7965         * arch/riscv.c: Fix common/ includes.
7966         * arch/ppc-linux-common.c: Fix common/ includes.
7967         * arch/i386.c: Fix common/ includes.
7968         * arch/arm.c: Fix common/ includes.
7969         * arch/arm-linux.c: Fix common/ includes.
7970         * arch/arm-get-next-pcs.c: Fix common/ includes.
7971         * arch/amd64.c: Fix common/ includes.
7972         * arch/aarch64.c: Fix common/ includes.
7973         * arch/aarch64-insn.c: Fix common/ includes.
7974         * arch-utils.c: Fix common/ includes.
7975         * amd64-windows-tdep.c: Fix common/ includes.
7976         * amd64-tdep.c: Fix common/ includes.
7977         * amd64-sol2-tdep.c: Fix common/ includes.
7978         * amd64-obsd-tdep.c: Fix common/ includes.
7979         * amd64-nbsd-tdep.c: Fix common/ includes.
7980         * amd64-linux-tdep.c: Fix common/ includes.
7981         * amd64-linux-nat.c: Fix common/ includes.
7982         * amd64-fbsd-tdep.c: Fix common/ includes.
7983         * amd64-fbsd-nat.c: Fix common/ includes.
7984         * amd64-dicos-tdep.c: Fix common/ includes.
7985         * amd64-darwin-tdep.c: Fix common/ includes.
7986         * agent.c: Fix common/ includes.
7987         * ada-lang.h: Fix common/ includes.
7988         * ada-lang.c: Fix common/ includes.
7989         * aarch64-tdep.c: Fix common/ includes.
7990
7991 2019-01-25  Tom Tromey  <tom@tromey.com>
7992
7993         * common/create-version.sh: Use common/version.h.
7994
7995 2019-01-24  Pedro Alves  <palves@redhat.com>
7996
7997         * infrun.c (signal_stop, signal_print, signal_program)
7998         (signal_catch, signal_pass): Now arrays instead of pointers.
7999         (update_signals_program_target, do_target_resume)
8000         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8001         * linux-nat.c (linux_nat_target::pass_signals)
8002         (linux_nat_target::create_inferior, linux_nat_target::attach):
8003         Adjust.
8004         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8005         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8006         * procfs.c (procfs_target::pass_signals): Adjust.
8007         * record-full.c (record_full_target::resume): Adjust.
8008         * remote.c (remote_target::pass_signals)
8009         (remote_target::program_signals): Adjust.
8010         * target-debug.h (target_debug_print_signals): Now takes a
8011         gdb::array_view as parameter.  Adjust.
8012         * target.h (target_ops) <pass_signals, program_signals>: Replace
8013         pointer and length parameters with gdb::array_view.
8014         (target_pass_signals, target_program_signals): Likewise.
8015         * target-delegates.c: Regenerate.
8016
8017 2019-01-24  Pedro Alves  <palves@redhat.com>
8018
8019         * common/forward-scope-exit.h
8020         (forward_scope_exit::forward_scope_exit): Pass arguments to
8021         m_bind_function directly, instead of creating a std::bind and
8022         copying that.
8023
8024 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8025
8026         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8027         for static members.
8028         (pass_in_v_vfp_candidate): Likewise.
8029
8030 2019-01-23  Tom Tromey  <tom@tromey.com>
8031             Pedro Alves  <palves@redhat.com>
8032
8033         * regcache.c (class regcache_invalidator): Remove.
8034         (regcache::raw_write): Use make_scope_exit.
8035
8036 2019-01-23  Tom Tromey  <tom@tromey.com>
8037
8038         * ui-out.h (class ui_out_emit_type): Update comment.
8039
8040 2019-01-23  Tom Tromey  <tom@tromey.com>
8041
8042         * infrun.c (fetch_inferior_event): Update comment.
8043
8044 2019-01-23  Tom Tromey  <tom@tromey.com>
8045             Pedro Alves  <palves@redhat.com>
8046
8047         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8048         parameter.
8049         (fetch_inferior_event): Use SCOPE_EXIT.
8050
8051
8052 2019-01-23  Tom Tromey  <tom@tromey.com>
8053             Pedro Alves  <palves@redhat.com>
8054
8055         * infrun.c (disable_thread_events): Delete.
8056         (stop_all_threads): Use SCOPE_EXIT.
8057
8058 2019-01-23  Tom Tromey  <tom@tromey.com>
8059             Pedro Alves  <palves@redhat.com>
8060
8061         * symfile.c: Include forward-scope-exit.h.
8062         (clear_symtab_users_cleanup): Replace forward declaration with
8063         a FORWARD_SCOPE_EXIT.
8064         (syms_from_objfile_1): Use the forward_scope_exit and
8065         gdb::optional instead of cleanup_function.
8066         (reread_symbols): Use the forward_scope_exit instead of
8067         cleanup_function.
8068         (clear_symtab_users_cleanup): Remove function.
8069
8070 2019-01-23  Tom Tromey  <tom@tromey.com>
8071             Pedro Alves  <palves@redhat.com>
8072
8073         * linux-nat.c: Include scope-exit.h.
8074         (cleanup_target_stop): Remove.
8075         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8076         SCOPE_EXIT.
8077
8078 2019-01-23  Tom Tromey  <tom@tromey.com>
8079             Pedro Alves  <palves@redhat.com>
8080
8081         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8082         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8083
8084 2019-01-23  Tom Tromey  <tom@tromey.com>
8085             Andrew Burgess  <andrew.burgess@embecosm.com>
8086             Pedro Alves  <palves@redhat.com>
8087
8088         * infrun.c (fetch_inferior_event): Use scope_exit.
8089         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8090         * top.c (execute_command): Use scope_exit.
8091         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8092         * utils.c (do_bpstat_clear_actions_cleanup)
8093         (make_bpstat_clear_actions_cleanup): Remove.
8094
8095 2019-01-23  Tom Tromey  <tom@tromey.com>
8096             Pedro Alves  <palves@redhat.com>
8097
8098         * infrun.c: Include "common/scope-exit.h"
8099         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8100         (wait_for_inferior): Use SCOPE_EXIT.
8101         (fetch_inferior_event): Use scope_exit.
8102
8103 2019-01-23  Tom Tromey  <tom@tromey.com>
8104             Pedro Alves  <palves@redhat.com>
8105
8106         * breakpoint.c (create_breakpoint): Remove cleanup.
8107
8108 2019-01-23  Tom Tromey  <tom@tromey.com>
8109             Andrew Burgess  <andrew.burgess@embecosm.com>
8110             Pedro Alves  <palves@redhat.com>
8111
8112 2019-01-23  Pedro Alves  <palves@redhat.com>
8113
8114         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8115
8116 2019-01-23  Pedro Alves  <palves@redhat.com>
8117             Andrew Burgess  <andrew.burgess@embecosm.com>
8118
8119         * gdbthread.h: Include "common/forward-scope-exit.h".
8120         (scoped_finish_thread_state): Redefine custom class in terms of
8121         forward_scope_exit.
8122
8123 2019-01-23  Pedro Alves  <palves@redhat.com>
8124             Andrew Burgess  <andrew.burgess@embecosm.com>
8125
8126         * common/forward-scope-exit.h: New file.
8127
8128 2019-01-23  Pedro Alves  <palves@redhat.com>
8129             Andrew Burgess  <andrew.burgess@embecosm.com>
8130             Tom Tromey  <tom@tromey.com>
8131
8132         * common/scope-exit.h: New file.
8133
8134 2019-01-23  Pedro Alves  <palves@redhat.com>
8135
8136         * common/preprocessor.h (ESC): Rename to ...
8137         (ESC_PARENS): ... this.
8138         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8139         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8140
8141 2019-01-23  Tom Tromey  <tom@tromey.com>
8142
8143         * language.h (class scoped_switch_to_sym_language_if_auto):
8144         Initialize m_lang in both cases.
8145
8146 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
8147
8148         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8149         with XCNEW.
8150
8151 2019-01-22  Tom Tromey  <tom@tromey.com>
8152
8153         * corelow.c: Do not include sys/file.h.
8154
8155 2019-01-22  Tom Tromey  <tom@tromey.com>
8156
8157         * tui/tui-wingeneral.h: Include gdb_curses.h.
8158
8159 2019-01-22  Tom Tromey  <tom@tromey.com>
8160
8161         * source-cache.h (class source_cache) <get_source_lines,
8162         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
8163
8164 2019-01-22  Tom Tromey  <tom@tromey.com>
8165
8166         * remote-fileio.h (struct remote_target): Declare.
8167
8168 2019-01-22  Tom Tromey  <tom@tromey.com>
8169
8170         * python/py-arch.c: Do not include py-ref.h.
8171         * python/py-bpevent.c: Do not include py-ref.h.
8172         * python/py-cmd.c: Do not include py-ref.h.
8173         * python/py-continueevent.c: Do not include py-ref.h.
8174         * python/py-event.h: Do not include py-ref.h.
8175         * python/py-evtregistry.c: Do not include py-ref.h.
8176         * python/py-finishbreakpoint.c: Do not include py-ref.h.
8177         * python/py-frame.c: Do not include py-ref.h.
8178         * python/py-framefilter.c: Do not include py-ref.h.
8179         * python/py-function.c: Do not include py-ref.h.
8180         * python/py-infevents.c: Do not include py-ref.h.
8181         * python/py-linetable.c: Do not include py-ref.h.
8182         * python/py-objfile.c: Do not include py-ref.h.
8183         * python/py-param.c: Do not include py-ref.h.
8184         * python/py-prettyprint.c: Do not include py-ref.h.
8185         * python/py-progspace.c: Do not include py-ref.h.
8186         * python/py-symbol.c: Do not include py-ref.h.
8187         * python/py-symtab.c: Do not include py-ref.h.
8188         * python/py-type.c: Do not include py-ref.h.
8189         * python/py-unwind.c: Do not include py-ref.h.
8190         * python/py-utils.c: Do not include py-ref.h.
8191         * python/py-value.c: Do not include py-ref.h.
8192         * python/py-varobj.c: Do not include py-ref.h.
8193         * python/py-xmethods.c: Do not include py-ref.h.
8194         * python/python.c: Do not include py-ref.h.
8195         * varobj.c: Do not include py-ref.h.
8196
8197 2019-01-22  Tom Tromey  <tom@tromey.com>
8198
8199         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
8200         keyword for bcache.
8201
8202 2019-01-22  Tom Tromey  <tom@tromey.com>
8203
8204         * compile/compile-cplus-types.c: Remove a comment by #include.
8205
8206 2019-01-22  Tom Tromey  <tom@tromey.com>
8207
8208         * compile/gcc-c-plugin.h: Include compile-internal.h.
8209
8210 2019-01-22  Tom Tromey  <tom@tromey.com>
8211
8212         * stabsread.c (EXTERN): Do not define.
8213         (symnum, next_symbol_text_func, processing_gcc_compilation)
8214         (within_function, global_sym_chain, global_stabs)
8215         (previous_stab_code, this_object_header_files)
8216         (n_this_object_header_files)
8217         (n_allocated_this_object_header_files): Define.
8218         * stabsread.h (EXTERN): Never define.  Use "extern".
8219
8220 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8221
8222         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
8223         history_value.
8224
8225 2019-01-21  Tom Tromey  <tom@tromey.com>
8226
8227         * ui-out.c: Fix includes.
8228         * tui/tui-source.c: Fix includes.
8229         * target.c: Fix includes.
8230         * remote.c: Fix includes.
8231         * regcache.c: Fix includes.
8232         * python/py-block.c: Fix includes.
8233         * printcmd.c: Fix includes.
8234         * or1k-tdep.c: Fix includes.
8235         * mi/mi-main.c: Fix includes.
8236         * m32r-tdep.c: Fix includes.
8237         * csky-tdep.c: Fix includes.
8238         * compile/compile-cplus-types.c: Fix includes.
8239         * cli/cli-interp.c: Fix includes.
8240
8241 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
8242
8243         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8244         for padding.
8245
8246 2019-01-16  Tom Tromey  <tom@tromey.com>
8247
8248         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
8249         earlier.
8250         (struct objfile) <msymbols_range>: Move from top level.
8251         <msymbols>: New method.
8252         (class objfile_msymbols): Remove.
8253         * symtab.c (default_collect_symbol_completion_matches_break_on):
8254         Update.
8255         * symmisc.c (dump_msymbols): Update.
8256         * stabsread.c (scan_file_globals): Update.
8257         * objc-lang.c (info_selectors_command, info_classes_command)
8258         (find_methods): Update.
8259         * minsyms.c (find_solib_trampoline_target): Update.
8260         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
8261         * coffread.c (coff_symfile_read): Update.
8262         * ada-lang.c (ada_lookup_simple_minsym)
8263         (ada_collect_symbol_completion_matches): Update.
8264
8265 2019-01-16  Tom Tromey  <tom@tromey.com>
8266
8267         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
8268         type.  Remove no-argument constructor.
8269         <iterator::operator++>: Simplify.
8270         <begin>: Update.
8271         <end>: Use minimal_symbol_count.
8272
8273 2019-01-16  Tom Tromey  <tom@tromey.com>
8274
8275         * objfiles.h (struct objfile) <psymtabs>: New method.
8276         (class objfile_psymtabs): Remove.
8277         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
8278         typedef.
8279         <range>: New method.
8280         (require_partial_symbols): Change return type.
8281         * psymtab.c (require_partial_symbols)
8282         (psym_expand_symtabs_matching): Update.
8283         * mdebugread.c (parse_partial_symbols): Update.
8284         * dbxread.c (dbx_end_psymtab): Update.
8285
8286 2019-01-15  Tom Tromey  <tom@tromey.com>
8287
8288         * symtab.c (lookup_objfile_from_block)
8289         (lookup_symbol_in_objfile_symtabs)
8290         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
8291         (find_line_symtab, info_sources_command)
8292         (default_collect_symbol_completion_matches_break_on)
8293         (make_source_files_completion_list): Update.
8294         * symmisc.c (print_objfile_statistics, dump_objfile)
8295         (maintenance_print_symbols, maintenance_info_symtabs)
8296         (maintenance_check_symtabs, maintenance_info_line_tables):
8297         Update.
8298         * source.c (select_source_symtab)
8299         (forget_cached_source_info_for_objfile): Update.
8300         * objfiles.h (class objfile_compunits): Remove.
8301         (struct objfile) <compunits_range>: New typedef.
8302         (compunits): New method.
8303         * objfiles.c (objfile_relocate1): Update.
8304         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8305         * maint.c (count_symtabs_and_blocks): Update.
8306         * linespec.c (iterate_over_all_matching_symtabs): Update.
8307         * cp-support.c (add_symbol_overload_list_qualified): Update.
8308         * coffread.c (coff_symtab_read): Update.
8309         * ada-lang.c (add_nonlocal_symbols)
8310         (ada_collect_symbol_completion_matches)
8311         (ada_add_global_exceptions): Update.
8312
8313 2019-01-15  Tom Tromey  <tom@tromey.com>
8314
8315         * progspace.h (program_space) <objfiles_safe_range>: New
8316         typedef.
8317         <objfiles_safe>: New method.
8318         * objfiles.h (class all_objfiles_safe): Remove.
8319         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
8320         * jit.c (jit_inferior_exit_hook): Update.
8321
8322 2019-01-17  Tom Tromey  <tom@tromey.com>
8323
8324         * progspace.h (program_space) <objfiles_range>: New typedef.
8325         <objfiles>: New method.
8326         <objfiles_head>: Rename from objfiles.
8327         (object_files): Update.
8328         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
8329         * guile/scm-pretty-print.c
8330         (ppscm_find_pretty_printer_from_objfiles): Update.
8331         * guile/scm-objfile.c (gdbscm_objfiles): Update.
8332         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
8333         Update.
8334         * python/py-progspace.c (pspy_get_objfiles): Update.
8335         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8336         Update.
8337         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8338         (objfpy_lookup_objfile_by_build_id): Update.
8339         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8340         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8341         Update.
8342         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8343         (expand_symtab_containing_pc, lookup_objfile_from_block)
8344         (lookup_static_symbol, basic_lookup_transparent_type)
8345         (find_pc_sect_compunit_symtab, find_symbol_at_address)
8346         (find_line_symtab, info_sources_command)
8347         (default_collect_symbol_completion_matches_break_on)
8348         (make_source_files_completion_list, find_main_name): Update.
8349         * symmisc.c (print_symbol_bcache_statistics)
8350         (print_objfile_statistics, maintenance_print_symbols)
8351         (maintenance_print_msymbols, maintenance_print_objfiles)
8352         (maintenance_info_symtabs, maintenance_check_symtabs)
8353         (maintenance_expand_symtabs, maintenance_info_line_tables):
8354         Update.
8355         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
8356         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
8357         (map_overlay_command, unmap_overlay_command)
8358         (simple_overlay_update, expand_symtabs_matching)
8359         (map_symbol_filenames): Update.
8360         * symfile-debug.c (set_debug_symfile): Update.
8361         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
8362         Update.
8363         * source.c (select_source_symtab, forget_cached_source_info):
8364         Update.
8365         * solib.c (solib_read_symbols): Update.
8366         * solib-spu.c (append_ocl_sos): Update.
8367         * psymtab.c (maintenance_print_psymbols)
8368         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
8369         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
8370         * printcmd.c (info_symbol_command): Update.
8371         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
8372         Update.
8373         * objfiles.h (class all_objfiles): Remove.
8374         * objfiles.c (have_partial_symbols, have_full_symbols)
8375         (have_minimal_symbols, qsort_cmp, update_section_map)
8376         (shared_objfile_contains_address_p)
8377         (default_iterate_over_objfiles_in_search_order): Update.
8378         * objc-lang.c (info_selectors_command, info_classes_command)
8379         (find_methods): Update.
8380         * minsyms.c (find_solib_trampoline_target): Update.
8381         * maint.c (maintenance_info_sections)
8382         (maintenance_translate_address, count_symtabs_and_blocks):
8383         Update.
8384         * main.c (captured_main_1): Update.
8385         * linux-thread-db.c (try_thread_db_load_from_pdir)
8386         (has_libpthread): Update.
8387         * linespec.c (iterate_over_all_matching_symtabs)
8388         (search_minsyms_for_name): Update.
8389         * jit.c (jit_find_objf_with_entry_addr): Update.
8390         * hppa-tdep.c (find_unwind_entry)
8391         (hppa_lookup_stub_minimal_symbol): Update.
8392         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
8393         Update.
8394         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8395         (elf_gnu_ifunc_resolve_by_got): Update.
8396         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
8397         * dwarf-index-write.c (save_gdb_index_command): Update.
8398         * cp-support.c (add_symbol_overload_list_qualified): Update.
8399         * breakpoint.c (create_overlay_event_breakpoint)
8400         (create_longjmp_master_breakpoint)
8401         (create_std_terminate_master_breakpoint)
8402         (create_exception_master_breakpoint): Update.
8403         * blockframe.c (find_pc_partial_function): Update.
8404         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
8405         (ada_collect_symbol_completion_matches)
8406         (ada_add_global_exceptions): Update.
8407
8408 2019-01-17  Tom Tromey  <tom@tromey.com>
8409
8410         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
8411         declare VEC.
8412         (solib_target_parse_libraries): Change return type.
8413         (library_list_start_segment, library_list_start_section)
8414         (library_list_end_library, library_list_start_library); Update.
8415         (solib_target_free_library_list): Remove.
8416         (solib_target_parse_libraries): Remove cleanup.  Change return
8417         type.
8418         (solib_target_current_sos): Update.
8419
8420 2019-01-17  Tom Tromey  <tromey@bapiya>
8421
8422         * valprint.c: Replace "the the" with "the".
8423         * symtab.c: Replace "the the" with "the".
8424         * solib.c: Replace "the the" with "the".
8425         * solib-dsbt.c: Replace "the the" with "the".
8426         * linespec.c: Replace "the the" with "the".
8427         * dwarf2loc.h: Replace "the the" with "the".
8428         * amd64-windows-tdep.c: Replace "the the" with "the".
8429         * aarch64-tdep.c: Replace "the the" with "the".
8430
8431 2019-01-16  Keith Seitz  <keiths@redhat.com>
8432
8433         PR gdb/23773
8434         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
8435         <builder>: Rename to ..
8436         <m_builder>: ... this and make private.
8437         (dwarf2_cu::get_builder): New method.  Change all users of
8438         `builder' to use this method.
8439         (dwarf2_start_symtab): Move to ...
8440         (dwarf2_cu::start_symtab): ... here.  Update all callers
8441         (setup_type_unit_groups): Move to ...
8442         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
8443         callers.
8444         (dwarf2_cu::reset_builder): New method.
8445         (process_full_compunit, process_full_type_unit): Use
8446         dwarf2_cu::reset_builder.
8447         (follow_die_offset): Record the ancestor CU if it is different
8448         from the followed DIE's CU.
8449         (follow_die_sig_1): Likewise.
8450
8451 2019-01-15  Tom Tromey  <tom@tromey.com>
8452
8453         * remote.c (class remote_state) <buf>: Now a char_vector.
8454         <buf_size>: Remove.
8455         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
8456         parameter.
8457         (remote_target::getpkt_or_notif_sane_1)
8458         (remote_target::getpkt_sane)
8459         (remote_target::getpkt_or_notif_sane): Likewise.
8460         (class remote_target) <putpkt>: New overload.
8461         (remote_target::read_frame): Change type of "buf_p".  Remove
8462         sizeof_p parameter.
8463         (packet_ok): New overload.
8464         (packet_check_result): New overload.
8465         Update all uses.
8466
8467 2019-01-14  Tom Tromey  <tom@tromey.com>
8468
8469         * remote-notif.c (handle_notification, remote_notif_ack)
8470         (remote_notif_parse): Make "buf" const.
8471         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
8472         const.
8473         (remote_notif_parse, remote_notif_ack, handle_notification):
8474         Likewise.
8475         * remote.c (remote_notif_stop_parse): Make "buf" const.
8476         (remote_target::remote_parse_stop_reply): Make "buf" const.
8477         (remote_notif_stop_ack): Make "buf" const.
8478
8479 2019-01-14  Tom Tromey  <tom@tromey.com>
8480
8481         * remote.c (remote_console_output): Make parameter const.
8482
8483 2019-01-14  Tom Tromey  <tom@tromey.com>
8484
8485         * target-debug.h (target_debug_print_signals): Constify.
8486         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
8487         * procfs.c (procfs_target::pass_signals): Update.
8488         * linux-nat.c (linux_nat_target::pass_signals): Update.
8489         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
8490         * target-delegates.c: Rebuild.
8491         * remote.c (remote_target::program_signals): Update.
8492         (remote_target::pass_signals): Update.
8493         * target.c (target_pass_signals): Constify argument.
8494         (target_program_signals): Likewise.
8495         * target.h (struct target_ops) <pass_signals, program_signals>:
8496         Constify argument.
8497         (target_pass_signals, target_program_signals): Constify argument.
8498
8499 2019-01-14  Tom Tromey  <tom@tromey.com>
8500
8501         PR tui/28819:
8502         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
8503
8504 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
8505
8506         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
8507         field.
8508         * rs6000-tdep.c: Include reggroups.h.
8509         (IS_V_ALIAS_PSEUDOREG): Define.
8510         (rs6000_register_name): Return names for the "vX" aliases.
8511         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
8512         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
8513         aliases.  Call default_register_reggroup_p for all other
8514         pseudo-registers.
8515         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
8516         New functions.
8517         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
8518         Handle "vX" aliases.
8519         (v_alias_pseudo_register_collect): New function.
8520         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
8521         (rs6000_gdbarch_init): Initialize "vX" aliases as
8522         pseudo-registers.  Restore registration of
8523         rs6000_pseudo_register_reggroup_p with
8524         set_tdesc_pseudo_register_reggroup_p.
8525
8526 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
8527
8528         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
8529         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
8530         set_gdbarch_num_pseudo_regs.
8531
8532 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8533
8534         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
8535         Remove arg prefixname, add do_set and do_show.
8536         Add member functions set_list and show_list.
8537         * cli/cli-style.c (class cli_style_option): Update accordingly.
8538         (style_set_list): Move to file scope.
8539         (style_show_list): Likewise.
8540         (set_style): Call help_list.
8541         (show_style): Call cmd_show_list.
8542         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
8543         Update to use the new macro.
8544
8545 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
8546
8547         * ada-lang.c (_initialize_ada_language): Expand the help text
8548         for the "catch exception" command.
8549
8550 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8551
8552         * symtab.c (matching_obj_sections): Initialize obj,
8553         declare it closer to its usage.
8554
8555 2019-01-10  Tom Tromey  <tom@tromey.com>
8556
8557         * thread-iter.h (inf_threads_iterator): Use next_iterator.
8558         (basic_inf_threads_range): Remove.
8559         (inf_threads_range, inf_non_exited_threads_range)
8560         (safe_inf_threads_range): Use next_adapter.
8561
8562 2019-01-10  Keith Seitz  <keiths@redhat.com>
8563
8564         PR gdb/23712
8565         PR symtab/23010
8566         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
8567         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
8568
8569 2019-01-10  Keith Seitz  <keiths@redhat.com>
8570
8571         PR gdb/23712
8572         PR symtab/23010
8573         * dictionary.c (pending_to_vector): Remove.
8574         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8575         Remove _1 suffix, replacing functions of the same name.  Update
8576         all callers.
8577         (dict_create_hashed, dict_create_hashed_expandable)
8578         (dict_create_linear, dict_create_linear_expandable, dict_free)
8579         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
8580         Make functions static.
8581
8582 2019-01-10  Keith Seitz  <keiths@redhat.com>
8583
8584         PR gdb/23712
8585         PR symtab/23010
8586         * dictionary.h (struct dictionary): Replace declaration with
8587         multidictionary.
8588         (dict_create_hashed, dict_create_hashed_expandable)
8589         (dict_create_linear, dict_create_linear_expandable)
8590         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
8591         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
8592         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
8593         taking multidictionary argument.
8594         [ALL_DICT_SYMBOLS]: Update for multidictionary.
8595         * block.h (struct block) <dict>: Change to multidictionary
8596         and rename `multidict'.
8597         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
8598         symmisc.c: Update all dictionary references to multidictionary.
8599
8600 2019-01-10  Keith Seitz  <keiths@redhat.com>
8601
8602         PR gdb/23712
8603         PR symtab/23010
8604         * dictionary.c: Include unordered_map.
8605         (pending_to_vector): New function.
8606         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8607         Rewrite the non-"_1" functions to take vector instead
8608         of linked list.
8609         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
8610         "new" _1 versions of the same name.
8611         (multidictionary): Define.
8612         (std::hash<enum language): New definition.
8613         (collate_pending_symbols_by_language, mdict_create_hashed)
8614         (mdict_create_hashed_expandable, mdict_create_linear)
8615         (mdict_create_linear_expandable, mdict_free)
8616         (find_language_dictionary, create_new_language_dictionary)
8617         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
8618         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
8619         (mdict_size, mdict_empty): New functions.
8620         * dictionary.h (mdict_iterator): Define.
8621
8622 2019-01-10  Pedro Alves  <palves@redhat.com>
8623
8624         * breakpoint.c (read_uploaded_action)
8625         (create_tracepoint_from_upload): Adjust to use
8626         gdb::unique_xmalloc_ptr.
8627         * ctf.c (ctf_write_uploaded_tp):
8628         (SET_ARRAY_FIELD): Use emplace_back.
8629         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
8630         * tracefile-tfile.c (tfile_write_uploaded_tp):
8631         * tracepoint.c (parse_tracepoint_definition): Adjust to use
8632         gdb::unique_xmalloc_ptr.
8633         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
8634         at_string, cond_string, cmd_strings>: Replace char pointers
8635         with gdb::unique_xmalloc_ptr.
8636
8637 2019-01-10  Pedro Alves  <palves@redhat.com>
8638
8639         * solib-target.c (library_list_start_library): Don't xstrdup name.
8640
8641 2019-01-10  Pedro Alves  <palves@redhat.com>
8642
8643         * mdebugread.c (parse_partial_symbols): Use
8644         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
8645
8646 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8647
8648         * linux-fork.c (scoped_switch_fork_info)
8649         <~scoped_switch_fork_info>: Fix incorrect variable name.
8650
8651 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8652
8653         * linux-fork.c (scoped_switch_fork_info)
8654         <scoped_switch_fork_info>: Make explicit.
8655         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
8656
8657 2019-01-10  Tom Tromey  <tom@tromey.com>
8658
8659         * objfiles.h (objfile::reset_psymtabs): Update.
8660         * objfiles.c (objfile::objfile): Update.
8661         * psymtab.h (psymtab_storage::obstack): Update.
8662         (psymtab_storage::m_obstack): Use gdb::optional.
8663         (class psymtab_storage): Update comment.  Remove objfile
8664         parameter.
8665         * psymtab.c (psymtab_storage::psymtab_storage): Update.
8666
8667 2019-01-10  Tom Tromey  <tom@tromey.com>
8668
8669         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
8670         <free_psymtabs>: Now private.
8671         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
8672         (allocate_psymtab): Use new method.
8673
8674 2019-01-10  Tom Tromey  <tom@tromey.com>
8675
8676         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
8677         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
8678         * mdebugread.c (parse_partial_symbols): Use
8679         allocate_dependencies.
8680         * dwarf2read.c (dwarf2_create_include_psymtab): Use
8681         allocate_dependencies.
8682         (process_psymtab_comp_unit_reader)
8683         (build_type_psymtab_dependencies): Likewise.
8684         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
8685
8686 2019-01-10  Tom Tromey  <tom@tromey.com>
8687
8688         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
8689         PSYMBOL_SET_LANGUAGE.
8690         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
8691
8692 2019-01-10  Tom Tromey  <tom@tromey.com>
8693
8694         * psymtab.h (psymtab_storage::obstack): New method.
8695         <m_obstack>: Rename from obstack; now private.
8696         * psymtab.c (psymtab_storage): Update.
8697         * dwarf2read.c (create_addrmap_from_index)
8698         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
8699         Update.
8700
8701 2019-01-10  Tom Tromey  <tom@tromey.com>
8702
8703         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
8704         * objfiles.h (objfile::reset_psymtabs): New method.
8705
8706 2019-01-10  Tom Tromey  <tom@tromey.com>
8707
8708         * symmisc.c (print_symbol_bcache_statistics): Update.
8709         (print_objfile_statistics): Update.
8710         * symfile.c (reread_symbols): Update.
8711         * psymtab.h (class psymtab_storage): New.
8712         * psymtab.c (psymtab_storage): New constructor.
8713         (~psymtab_storage): New destructor.
8714         (require_partial_symbols): Update.
8715         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
8716         (find_pc_sect_psymtab, find_pc_sect_psymbol)
8717         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
8718         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
8719         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
8720         (start_psymtab_common, end_psymtab_common)
8721         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
8722         (allocate_psymtab): Update.
8723         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
8724         Update.
8725         (dump_psymtab_addrmap, maintenance_print_psymbols)
8726         (maintenance_check_psymtabs): Update.
8727         (class objfile_psymtabs): Move to objfiles.h.
8728         * psympriv.h (discard_psymtab): Now inline.
8729         (psymtab_discarder::psymtab_discarder): Update.
8730         (psymtab_discarder::~psymtab_discarder): Update.
8731         (ALL_OBJFILE_PSYMTABS): Rewrite.
8732         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
8733         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
8734         Remove fields.
8735         <partial_symtabs>: New field.
8736         (class objfile_psymtabs): Move from psymtab.h.  Update.
8737         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
8738         psymbol_cache.
8739         (objfile::~objfile): Don't destroy psymbol_cache.
8740         * mdebugread.c (parse_partial_symbols): Update.
8741         * dwarf2read.c (create_addrmap_from_index)
8742         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
8743         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
8744         (add_partial_subprogram, dwarf2_ranges_read): Update.
8745         * dwarf-index-write.c (write_address_map)
8746         (write_one_signatured_type, recursively_write_psymbols)
8747         (class debug_names, class debug_names, write_psymtabs_to_index):
8748         Update.
8749
8750 2019-01-10  Tom Tromey  <tom@tromey.com>
8751
8752         * symtab.h (SYMBOL_SET_NAMES): Update.
8753         (symbol_set_names): Update.
8754         (MSYMBOL_SET_NAMES): Update.
8755         * symtab.c (symbol_set_names): Change argument to be an
8756         objfile_per_bfd_storage.
8757         * psymtab.c (add_psymbol_to_bcache): Update.
8758         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
8759
8760 2019-01-10  Tom Tromey  <tom@tromey.com>
8761
8762         * symtab.c (create_demangled_names_hash): Change argument to be an
8763         objfile_per_bfd_storage.
8764         (symbol_set_names): Update.
8765
8766 2019-01-10  Tom Tromey  <tom@tromey.com>
8767
8768         * xcoffread.c (xcoff_initial_scan): Unconditionally call
8769         init_psymbol_list.
8770         * psymtab.c (init_psymbol_list): Do nothing if already called.
8771         * psympriv.h (init_psymbol_list): Add comment.
8772         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
8773         init_psymbol_list.
8774         * dbxread.c (dbx_symfile_read): Unconditionally call
8775         init_psymbol_list.
8776
8777 2019-01-10  Tom Tromey  <tom@tromey.com>
8778
8779         * xcoffread.c (scan_xcoff_symtab): Update.
8780         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
8781         "where".
8782         * mdebugread.c (parse_partial_symbols)
8783         (handle_psymbol_enumerators): Update.
8784         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
8785         * dbxread.c (read_dbx_symtab): Update.
8786         * psympriv.h (psymbol_placement): New enum.
8787         (add_psymbol_to_list): Update.
8788
8789 2019-01-10  Tom Tromey  <tom@tromey.com>
8790
8791         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
8792         static_psymbols parameters.
8793         (scan_xcoff_symtab): Update.
8794         * psymtab.c (start_psymtab_common): Remove global_psymbols and
8795         static_psymbols parameters.
8796         * psympriv.h (start_psymtab_common): Update.
8797         * mdebugread.c (parse_partial_symbols): Update.
8798         * dwarf2read.c (create_partial_symtab): Update.
8799         * dbxread.c (read_dbx_symtab): Update.
8800         (start_psymtab): Remove global_psymbols and static_psymbols
8801         parameters.
8802
8803 2019-01-10  Tom Tromey  <tom@tromey.com>
8804
8805         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
8806         * psymtab.c (allocate_psymtab): Add comment.
8807         * psympriv.h (allocate_psymtab): Add comment.
8808         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
8809         initializations.
8810         * dbxread.c (dbx_end_psymtab): Remove some initializations.
8811
8812 2019-01-10  Tom Tromey  <tom@tromey.com>
8813
8814         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8815         Don't declare.
8816         * mipsread.c: Include mdebugread.h.
8817         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8818         Declare.
8819         * elfread.c: Include mdebugread.h.
8820
8821 2019-01-09  Tom Tromey  <tom@tromey.com>
8822
8823         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
8824         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
8825         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
8826         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
8827         (psym_lookup_symbol, psym_find_last_source_symtab)
8828         (psym_forget_cached_source_info, psym_print_stats)
8829         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
8830         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
8831         (psym_map_matching_symbols, psym_expand_symtabs_matching)
8832         (psym_find_compunit_symtab_by_address)
8833         (maintenance_print_psymbols, maintenance_info_psymtabs)
8834         (maintenance_check_psymtabs): Use ranged for.
8835         * psymtab.h (class objfile_psymtabs): New.
8836         (require_partial_symbols): Return objfile_psymtabs.
8837         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
8838
8839 2019-01-09  Tom Tromey  <tom@tromey.com>
8840
8841         * symfile.c (overlay_invalidate_all, find_pc_overlay)
8842         (find_pc_mapped_section, list_overlays_command)
8843         (map_overlay_command, unmap_overlay_command)
8844         (simple_overlay_update): Use all_objfiles.
8845         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
8846         * printcmd.c (info_symbol_command): Use all_objfiles.
8847         * objfiles.h (ALL_OBJSECTIONS): Remove.
8848         * maint.c (maintenance_translate_address): Use all_objfiles.
8849         * gcore.c (gcore_create_callback): Use all_objfiles.
8850         (objfile_find_memory_regions): Likewise.
8851
8852 2019-01-09  Tom Tromey  <tom@tromey.com>
8853
8854         * symtab.c (find_line_symtab, info_sources_command)
8855         (make_source_files_completion_list): Use objfile_compunits.
8856         * source.c (select_source_symtab): Use objfile_compunits.
8857         * objfiles.h (struct objfile): Update comment.
8858         (ALL_OBJFILES): Remove.
8859         (ALL_FILETABS): Remove.
8860         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
8861         objfile_compunits.
8862
8863 2019-01-09  Tom Tromey  <tom@tromey.com>
8864
8865         * symmisc.c (print_objfile_statistics, dump_objfile)
8866         (maintenance_print_symbols): Use compunit_filetabs.
8867         * source.c (forget_cached_source_info_for_objfile): Use
8868         compunit_filetabs.
8869         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
8870         (ALL_FILETABS): Use compunit_filetabs.
8871         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
8872         * coffread.c (coff_symtab_read): Use compunit_filetabs.
8873
8874 2019-01-09  Tom Tromey  <tom@tromey.com>
8875
8876         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
8877         (compunit_filetabs): New.
8878         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
8879         compunit_filetabs.
8880         (info_sources_command, make_source_files_completion_list): Remove
8881         declaration.
8882         * symmisc.c (print_objfile_statistics, dump_objfile)
8883         (maintenance_print_symbols): Remove declaration.
8884         (maintenance_info_symtabs): Use compunit_filetabs.
8885         (maintenance_info_line_tables): Likewise.
8886         * source.c (select_source_symtab): Change local variable name.
8887         (forget_cached_source_info_for_objfile): Remove declaration.
8888         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
8889         * objfiles.c (objfile_relocate1): Remove declaration.
8890         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8891         declaration.
8892         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
8893         * coffread.c (coff_symtab_read): Remove declaration.
8894         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
8895         compunit_filetabs.
8896
8897 2019-01-09  Tom Tromey  <tom@tromey.com>
8898
8899         * symtab.c (lookup_objfile_from_block)
8900         (find_pc_sect_compunit_symtab, search_symbols)
8901         (default_collect_symbol_completion_matches_break_on): Use
8902         objfile_compunits.
8903         * objfiles.h (ALL_COMPUNITS): Remove.
8904         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
8905         * cp-support.c (add_symbol_overload_list_qualified): Use
8906         objfile_compunits.
8907         * ada-lang.c (ada_collect_symbol_completion_matches)
8908         (ada_add_global_exceptions): Use objfile_compunits.
8909
8910 2019-01-09  Tom Tromey  <tom@tromey.com>
8911
8912         * source.c (select_source_symtab)
8913         (forget_cached_source_info_for_objfile): Remove declaration.
8914         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8915         declaration.
8916         * maint.c (count_symtabs_and_blocks): Remove declaration.
8917         * cp-support.c (add_symbol_overload_list_qualified): Remove
8918         declaration.
8919         * coffread.c (coff_symtab_read): Remove declaration.
8920         * symtab.c (lookup_symbol_in_objfile_symtabs)
8921         (basic_lookup_transparent_type_1): Use objfile_compunits.
8922         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
8923         (info_sources_command, search_symbols)
8924         (default_collect_symbol_completion_matches_break_on)
8925         (make_source_files_completion_list): Remove declaration.
8926         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
8927         (ada_collect_symbol_completion_matches)
8928         (ada_add_global_exceptions): Remove declaration.
8929         * linespec.c (iterate_over_all_matching_symtabs): Use
8930         objfile_compunits.
8931         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
8932         (class objfile_compunits): New.
8933         (ALL_COMPUNITS): Use objfile_compunits.
8934         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
8935         (maintenance_check_symtabs, maintenance_info_line_tables): Use
8936         objfile_compunits.
8937         * objfiles.c (objfile_relocate1): Use objfile_compunits.
8938
8939 2019-01-09  Tom Tromey  <tom@tromey.com>
8940
8941         * symtab.c (search_symbols)
8942         (default_collect_symbol_completion_matches_break_on): Use
8943         objfile_msymbols.
8944         * ada-lang.c (ada_lookup_simple_minsym)
8945         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
8946         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
8947         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
8948         objfile_msymbols.
8949         * coffread.c (coff_symfile_read): Use objfile_msymbols.
8950         * symmisc.c (dump_msymbols): Use objfile_msymbols.
8951         * objc-lang.c (find_methods): Use objfile_msymbols.
8952         (info_selectors_command, info_classes_command): Likewise.
8953         * stabsread.c (scan_file_globals): Use objfile_msymbols.
8954         * objfiles.h (class objfile_msymbols): New.
8955         (ALL_OBJFILE_MSYMBOLS): Remove.
8956         (ALL_MSYMBOLS): Remove.
8957
8958 2019-01-09  Tom Tromey  <tom@tromey.com>
8959
8960         * common/next-iterator.h (next_adapter): Add Iterator template
8961         parameter.
8962         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
8963         (class all_objfiles_safe): New.
8964         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
8965         * objfiles.c (put_objfile_before): Update comment.
8966         (add_separate_debug_objfile): Likewise.
8967         (free_all_objfiles): Use all_objfiles_safe.
8968         (objfile_purge_solibs): Likewise.
8969
8970 2019-01-09  Tom Tromey  <tom@tromey.com>
8971
8972         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8973         (expand_symtab_containing_pc, lookup_static_symbol)
8974         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
8975         (find_symbol_at_address, find_line_symtab, find_main_name): Use
8976         all_objfiles.
8977         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
8978         * breakpoint.c (create_overlay_event_breakpoint)
8979         (create_longjmp_master_breakpoint)
8980         (create_std_terminate_master_breakpoint)
8981         (create_exception_master_breakpoint): Use all_objfiles.
8982         * linux-thread-db.c (try_thread_db_load_from_pdir)
8983         (has_libpthread): Use all_objfiles.
8984         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
8985         * linespec.c (iterate_over_all_matching_symtabs)
8986         (search_minsyms_for_name): Use all_objfiles.
8987         * maint.c (maintenance_info_sections): Use all_objfiles.
8988         * main.c (captured_main_1): Use all_objfiles.
8989         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
8990         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
8991         * guile/scm-pretty-print.c
8992         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
8993         * solib-spu.c (append_ocl_sos): Use all_objfiles.
8994         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
8995         (maintenance_print_msymbols): Use all_objfiles.
8996         * source.c (select_source_symtab): Use all_objfiles.
8997         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
8998         * symfile.c (remove_symbol_file_command)
8999         (expand_symtabs_matching, map_symbol_filenames): Use
9000         all_objfiles.
9001         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9002         all_objfiles.
9003         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9004         * objc-lang.c (find_methods): Use all_objfiles.
9005         * objfiles.c (have_partial_symbols, have_full_symbols)
9006         (have_minimal_symbols, qsort_cmp)
9007         (default_iterate_over_objfiles_in_search_order): Use
9008         all_objfiles.
9009         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9010         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9011         (maintenance_check_psymtabs): Use all_objfiles.
9012         (ALL_PSYMTABS): Remove.
9013         * compile/compile-object-run.c (do_module_cleanup): Use
9014         all_objfiles.
9015         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9016         * cp-support.c (add_symbol_overload_list_qualified): Use
9017         all_objfiles.
9018         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9019         Use all_objfiles.
9020         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9021         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9022         all_objfiles.
9023         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9024         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9025         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9026         Uses all_objfiles.
9027         * solib.c (solib_read_symbols): Use all_objfiles
9028
9029 2019-01-09  Tom Tromey  <tom@tromey.com>
9030
9031         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9032         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9033         all_objfiles.
9034         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9035         * symmisc.c (print_symbol_bcache_statistics)
9036         (print_objfile_statistics, maintenance_print_objfiles)
9037         (maintenance_info_symtabs, maintenance_check_symtabs)
9038         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9039         all_objfiles.
9040         * source.c (forget_cached_source_info): Use all_objfiles.
9041         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9042         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9043         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9044         * objfiles.c (update_section_map): Use all_objfiles.
9045         (shared_objfile_contains_address_p): Likewise.
9046         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9047         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9048
9049 2019-01-09  Tom Tromey  <tom@tromey.com>
9050
9051         * common/next-iterator.h: New file.
9052         * objfiles.h (class all_objfiles): New.
9053         (struct objfile_iterator): New.
9054
9055 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9056
9057         * NEWS: Move the description of the changed "frame", "select-frame",
9058          and "info frame" commands to the Changed commands section.
9059
9060 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9061
9062         * gdbtypes.c (check_stub_method_group): Remove handling of old
9063         mangling schemes.
9064         * linespec.c (find_methods): Likewise.
9065         * stabsread.c (read_member_functions): Likewise.
9066         * valops.c (search_struct_method): Likewise.
9067         (value_struct_elt_for_reference): Likewise.
9068         * NEWS: Mention this change.
9069
9070 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9071
9072         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9073         print_source_lines.
9074         * source.c (print_source_lines_base): Update line number check.
9075         (print_source_lines): New function.
9076         (source_lines_range::source_lines_range): New function.
9077         * source.h (class source_lines_range): New class.
9078         (print_source_lines): New declaration.
9079
9080 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9081
9082         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9083
9084 2019-01-08  Tom Tromey  <tom@tromey.com>
9085             Simon Marchi  <simon.marchi@ericsson.com>
9086
9087         PR gdb/24060
9088         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9089         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9090         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9091         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9092         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9093         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9094
9095 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9096
9097         * source.c (select_source_symtab): Move header comment to
9098         declaration in source.h.
9099         (forget_cached_source_info_for_objfile): Likewise.
9100         (forget_cached_source_info): Likewise.
9101         (identify_source_line): Likewise.
9102         * source.h (identify_source_line): Move declaration from symtab.h
9103         and add comment from source.c
9104         (print_source_lines): Likewise.
9105         (forget_cached_source_info_for_objfile): Likewise.
9106         (forget_cached_source_info): Likewise.
9107         (select_source_symtab): Likewise.
9108         (enum print_source_lines_flag): Move definition from symtab.h.
9109         * symtab.h (identify_source_line): Move declaration to source.h.
9110         (print_source_lines): Likewise.
9111         (forget_cached_source_info_for_objfile): Likewise.
9112         (forget_cached_source_info): Likewise.
9113         (select_source_symtab): Likewise.
9114         (enum print_source_lines_flag): Move definition to source.h.
9115         * tui/tui-hooks.c: Add 'source.h' include.
9116
9117 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9118
9119         * source.c (print_source_lines_base): Handle requests to print
9120         reverse line number sequences, and guard against empty lines
9121         string.
9122
9123 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9124
9125         * source.c (print_source_lines_base): Fix skip of '\r' if next
9126         character is '\n'.
9127
9128 2019-01-06  Tom Tromey  <tom@tromey.com>
9129
9130         * c-exp.y (struct c_parse_state) <macro_original_text,
9131         expansion_obstack>: New member.
9132         (macro_original_text, expansion_obstack): Remove globals.
9133         (scan_macro_expansion, scanning_macro_expansion)
9134         (finished_macro_expansion): Update.
9135         (scan_macro_cleanup): Remove.
9136         (yylex, c_parse): Update.
9137
9138 2019-01-06  Tom Tromey  <tom@tromey.com>
9139
9140         * c-exp.y (struct c_parse_state) <strings>: New member.
9141         (operator_stoken): Update.
9142
9143 2019-01-06  Tom Tromey  <tom@tromey.com>
9144
9145         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9146         (union type_stack_elt) <typelist_val>: Now a pointer to
9147         std::vector.
9148         (type_stack_cleanup): Don't declare.
9149         (push_typelist): Update.
9150         * parse.c (pop_typelist): Return a std::vector.
9151         (push_typelist): Take a std::vector.
9152         (follow_types): Update.  Do not free args.
9153         (type_stack_cleanup): Remove.
9154         * c-exp.y (struct c_parse_state): New.
9155         (cpstate): New global.
9156         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
9157         (nonempty_typelist): Update.
9158         (func_mod): Create a new vector.
9159         (c_parse): Create a c_parse_state.
9160         (check_parameter_typelist): Do not delete params.
9161         (function_method): Update.  Do not delete type_list.
9162
9163 2019-01-06  Tom Tromey  <tom@tromey.com>
9164
9165         PR gdb/28155:
9166         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
9167         check_typedef.
9168         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
9169         (print_return_value): Likewise.
9170
9171 2019-01-05  Tom Tromey  <tom@tromey.com>
9172
9173         * contrib/cleanup_check.py: Remove.
9174         * contrib/gcc-with-excheck: Remove.
9175         * contrib/exsummary.py: Remove.
9176         * contrib/excheck.py: Remove.
9177
9178 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
9179
9180         * thread.c (delete_thread_1): Add gdb_assert that THR is not
9181         NULL. Initialize tpprev to NULL instead of assigning it
9182         to NULL on the next statement.
9183         * windows-nat.c (windows_delete_thread): Remove check for
9184         main_thread_id before printing thread exit notifications.
9185         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
9186         Remove thread ID check against main_thread_id.
9187         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
9188         windows_delete_thread.
9189         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
9190
9191 2019-01-04  Tom Tromey  <tom@tromey.com>
9192
9193         * compile/compile.c (_initialize_compile): Use upper case for
9194         metasyntactic variables.
9195         * symmisc.c (_initialize_symmisc): Use upper case for
9196         metasyntactic variables.
9197         * psymtab.c (_initialize_psymtab): Use upper case for
9198         metasyntactic variables.
9199         * demangle.c (demangle_command): Use upper case for metasyntactic
9200         variables.
9201         (_initialize_demangler): Likewise.
9202         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
9203         variables.
9204
9205 2019-01-03  Tom Tromey  <tom@tromey.com>
9206
9207         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
9208
9209 2019-01-03  Tom Tromey  <tom@tromey.com>
9210
9211         * python/py-symtab.c (salpy_str): Update.
9212         (struct salpy_sal_object) <symtab>: Now a PyObject.
9213         (salpy_dealloc): Update.
9214         (del_objfile_sal): Use gdbpy_ref.
9215
9216 2019-01-03  Tom Tromey  <tom@tromey.com>
9217
9218         * python/py-type.c (convert_field): Use new_reference.  Return
9219         gdbpy_ref.
9220         (make_fielditem): Return gdbpy_ref.
9221         (typy_fields): Update.
9222         (typy_getitem): Update.
9223         (field_name): Return gdbpy_ref.  Use new_reference.
9224         (typy_iterator_iternext): Update.
9225
9226 2019-01-03  Tom Tromey  <tom@tromey.com>
9227
9228         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
9229
9230 2019-01-03  Tom Tromey  <tom@tromey.com>
9231
9232         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
9233         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
9234         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
9235         (pspy_set_frame_filters, pspy_set_frame_unwinders)
9236         (pspy_set_type_printers): Likewise.
9237         * python/py-function.c (fnpy_init): Use gdbpy_ref.
9238         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
9239         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
9240         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
9241         (objfpy_set_type_printers): Likewise.
9242
9243 2019-01-03  Tom Tromey  <tom@tromey.com>
9244
9245         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
9246         (gdbpy_print_stack): Use gdbpy_err_fetch.
9247         * python/python-internal.h (class gdbpy_err_fetch): New class.
9248         (class gdbpy_enter) <m_error_type, m_error_value,
9249         m_error_traceback>: Remove.
9250         <m_error>: New member.
9251         (gdbpy_exception_to_string): Don't declare.
9252         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
9253         * python/py-value.c (convert_value_from_python): Use
9254         gdbpy_err_fetch.
9255         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
9256         gdbpy_exception_to_string.
9257         (gdbpy_handle_exception): Use gdbpy_err_fetch.
9258         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
9259         gdbpy_err_fetch.
9260
9261 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9262
9263         * linux-nat.c (delete_lwp_cleanup): Delete.
9264         (struct lwp_deleter): New struct.
9265         (lwp_info_up): New typedef.
9266         (linux_nat_target::follow_fork): Delete cleanup, and make use of
9267         lwp_info_up.
9268
9269 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9270
9271         * linux-fork.c (class scoped_switch_fork_info): New class.
9272         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
9273
9274 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9275
9276         * valops.c (find_overload_match): Remove use of null_cleanup, and
9277         calls to do_cleanups.
9278
9279 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9280
9281         * compile/compile-cplus-types.c
9282         (compile_cplus_instance::decl_name): Handle changes to
9283         cp_func_name.
9284         * cp-support.c (cp_func_name): Update header comment, update
9285         return type.
9286         * cp-support.h (cp_func_name): Update return type in declaration.
9287         * valops.c (find_overload_match): Move temp_func local to top
9288         level of function and change its type.  Use temp_func to hold and
9289         delete temporary string obtained from cp_func_name.
9290
9291 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9292
9293         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
9294         gdb::char_vector, remove cleanup, and update uses of `msg`.
9295
9296 2019-01-03  Jim Wilson  <jimw@sifive.com>
9297
9298         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
9299
9300 2019-01-02  Tom Tromey  <tom@tromey.com>
9301
9302         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
9303         (tdesc_parse_xml): Remove cleanups.
9304         * target-descriptions.h (make_cleanup_free_target_description):
9305         Don't declare.
9306         (target_desc_deleter): New struct.
9307         (target_desc_up): New typedef.
9308         * target-descriptions.c (target_desc_deleter::operator()): Rename
9309         from free_target_description.
9310         (make_cleanup_free_target_description): Remove.
9311
9312 2019-01-02  Tom Tromey  <tom@tromey.com>
9313
9314         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
9315         constructor, destructor.
9316         (linespec_parser): Remove typedef.
9317         (~linespec_parser): Rename from linespec_parser_delete.
9318         (linespec_lex_to_end, linespec_complete_label)
9319         (linespec_complete): Update.
9320         (decode_line_full): Remove cleanups.
9321         (decode_line_1): Update.
9322
9323 2019-01-02  Tom Tromey  <tom@tromey.com>
9324
9325         * python/python-internal.h (inferior_to_inferior_object): Change
9326         return type.
9327         * python/py-exitedevent.c (create_exited_event_object): Update.
9328         * python/py-inferior.c (inferior_to_inferior_object): Return
9329         gdbpy_ref.
9330         (python_new_inferior, python_inferior_deleted)
9331         (thread_to_thread_object, delete_thread_object)
9332         (build_inferior_list, gdbpy_selected_inferior): Update.
9333         * python/py-infthread.c (create_thread_object): Update.  Also fail
9334         if inferior_to_inferior_object fails.
9335
9336 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
9337
9338         * inferior.h (class inferior) <displaced_step_state>: New field.
9339         * infrun.h (struct displaced_step_state): Move here from
9340         infrun.c.  Initialize fields, add constructor.
9341         <inf>: Remove field.
9342         <reset>: New method.
9343         * infrun.c (struct displaced_step_inferior_state): Move to
9344         infrun.h.
9345         (displaced_step_inferior_states): Remove.
9346         (get_displaced_stepping_state): Adust.
9347         (displaced_step_in_progress_any_inferior): Adjust.
9348         (displaced_step_in_progress_thread): Adjust.
9349         (displaced_step_in_progress): Adjust.
9350         (add_displaced_stepping_state): Remove.
9351         (get_displaced_step_closure_by_addr): Adjust.
9352         (remove_displaced_stepping_state): Remove.
9353         (infrun_inferior_exit): Call displaced_step_state.reset.
9354         (use_displaced_stepping): Don't check for NULL.
9355         (displaced_step_prepare_throw): Call
9356         get_displaced_stepping_state.
9357         (displaced_step_fixup): Don't check for NULL.
9358         (prepare_for_detach): Don't check for NULL.
9359
9360 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9361
9362         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
9363          in case of call that did not complete.
9364
9365 2019-01-02  Andrey Utkin  <autkin@undo.io>
9366
9367         * symfile.c (find_separate_debug_file): Fix search of debug files for
9368         remote debuggee.
9369
9370 2019-01-02  Tom Tromey  <tom@tromey.com>
9371
9372         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
9373         indentation.
9374         * python/py-frame.c (frapy_older): Remove cast.
9375         (frapy_newer): Likewise.
9376         * python/py-breakpoint.c (local_setattro): Remove cast.
9377         * python/py-arch.c (archpy_name): Remove local variable.
9378         * python/py-type.c (gdbpy_lookup_type): Remove cast.
9379
9380 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
9381
9382         * unittests/basic_string_view/element_access/char/empty.cc:
9383         Fix year range in copyright header.
9384
9385 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9386
9387         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
9388         Delete.
9389         <operator==>: Update with for removed field.
9390         <hash>: Likewise.
9391         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
9392         <isa_features>: ...this.
9393         <abi_features>: New field.
9394         (riscv_isa_flen): Update comment.
9395         (riscv_abi_xlen): New declaration.
9396         (riscv_abi_flen): New declaration.
9397         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
9398         isa_features.
9399         (riscv_abi_xlen): New function.
9400         (riscv_isa_flen): Update to get answer from isa_features.
9401         (riscv_abi_flen): New function.
9402         (riscv_has_fp_abi): Update to get answer from abi_features.
9403         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
9404         xlen and flen.
9405         (riscv_call_info) <xlen, flen>: Update comment.
9406         (riscv_call_arg_struct): Remove invalid assertions
9407         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
9408         is removed.
9409         (riscv_gdbarch_init): Gather isa features and abi features
9410         separately, ensure both match on the gdbarch when reusing an old
9411         gdbarch.  Relax an error check to allow 32-bit abi float to run on
9412         a target with 64-bit float hardware.
9413
9414 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9415
9416         * source.c (search_command_helper): Stop reverse search
9417         when line 1 has been searched.
9418
9419 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9420
9421         * record-full.c (record_full_base_target::close): Rewrite
9422         record_full_core_buf_list free logic.
9423
9424 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9425
9426         * break-catch-syscall.c (print_one_catch_syscall): xfree
9427         the last text.
9428
9429 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9430
9431         * top.c (print_gdb_version): Update Copyright year in version
9432         message.
9433
9434 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9435
9436         Update copyright year range in all GDB files.
9437
9438 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
9439
9440         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
9441
9442 For older changes see ChangeLog-2018.
9443 \f
9444 Local Variables:
9445 mode: change-log
9446 left-margin: 8
9447 fill-column: 74
9448 version-control: never
9449 coding: utf-8
9450 End:
9451