gdb/ChangeLog

   1 2019-07-16  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
   4         declare.
   5
   6 2019-07-30  Tom Tromey  <tromey@adacore.com>
   7
   8         * block.c (contained_in): Remove BLOCK_FUNCTION check.
   9
  10 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
  11
  12         * printcmd.c (print_address_symbolic): Print negative offsets.
  13         (build_address_symbolic): Force signed arithmetic when computing
  14         offset.
  15
  16 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
  17
  18         PR/24474: Add a function to lookup static variables.
  19         * NEWS: Mention this new function.
  20         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
  21         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
  22         * python/python.c (python_GdbMethods): Add new function.
  23
  24 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
  25
  26         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
  27         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
  28         (objfpy_lookup_static_symbol): New function.
  29         (objfile_object_methods): Add new functions.
  30
  31 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  32
  33         * NEWS: Mention 'set|show print frame-info'.  Mention new
  34         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
  35         backtrace argument.  Mention that python frame filtering code
  36         is now consistent with what 'backtrace' command prints.
  37
  38 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  39
  40         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
  41         comments.
  42         (print_frame_info_auto, print_frame_info_source_line,
  43         print_frame_info_location, print_frame_info_source_and_location,
  44         print_frame_info_location_and_address, print_frame_info_short_location):
  45         New declarations.
  46         (struct frame_print_options): New member print_frame_info.
  47         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
  48         * stack.h (get_user_print_what_frame_info): New declaration.
  49         (frame_show_address): New declaration.
  50         * stack.c (print_frame_arguments_choices): New value 'presence'.
  51         (print_frame_info_auto, print_frame_info_source_line,
  52         print_frame_info_location, print_frame_info_source_and_location,
  53         print_frame_info_location_and_address, print_frame_info_short_location,
  54         print_frame_info_choices, print_frame_info_print_what): New definitions.
  55         (print_frame_args): Only print dots for args if print frame-arguments
  56         is 'presence'.
  57         (frame_print_option_defs): New element for "frame-info".
  58         (get_user_print_what_frame_info): New function.
  59         (frame_show_address): Make non static.  Move comment to stack.h.
  60         (print_frame_info_to_print_what): New function.
  61         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
  62         to decide what to print.
  63         (backtrace_command_1): Handle the new print_frame_arguments_presence
  64         value.
  65         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
  66         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
  67         (py_print_frame): In non-mi mode, use LOCATION as default for
  68         print_what, similarly to frame information printed directly by
  69         backtrace command. Handle frame-info user option in non MI mode.
  70
  71 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
  72
  73         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
  74         Add case for debugging 32-bit target on 64-bit host.  Revise
  75         comment.
  76
  77 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
  78
  79         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
  80         instead of find_function_entry_range_from_pc.
  81
  82 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
  83
  84         * stack.c (find_frame_funname): Remove code which preferred
  85         minsym over symtab sym in "certain pathological cases".
  86
  87         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
  88         parameter.  Change type of "do_demangle" to bool.
  89         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
  90         Pass suitable "prefer_sym_over_minsym" flag to
  91         build_address_symbolic().  Don't output "+" for negative offsets.
  92         * printcmd.c (print_address_symbolic): Update invocation of
  93         build_address_symbolic to include a "prefer_sym_over_minsym"
  94         flag.
  95         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
  96         Restrict cases in which use of minimal symbol is preferred to that
  97         of a found symbol.  Update comments.
  98
  99         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
 100         for entry pc when entry pc is out of range for that FDE.
 101
 102 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
 103
 104         PR gdb/24839:
 105         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
 106         type.
 107
 108 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
 109
 110         * python/py-objfile.c (add_separate_debug_file): Fix comment about
 111         this function's Python signature.
 112
 113
 114 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
 115
 116         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
 117         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 118         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 119         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
 120         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
 121
 122
 123 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
 124
 125         * h8300-tdep.c (h8300_register_name_common): New.
 126         h8300_register_name): Use h8300_register_name_common.
 127         (h8300s_register_name): Likewise.
 128         (h8300sx_register_name): Likewise.
 129         (h8300h_register_nam): New.
 130         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
 131
 132
 133 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
 134
 135         * arm-tdep.c (arm_skip_cmse_entry): New function.
 136         (arm_is_sgstubs_section): New function.
 137         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
 138
 139 2019-07-22  Tom Tromey  <tom@tromey.com>
 140
 141         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
 142         Don't self-assign.
 143
 144 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 145
 146         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
 147         type_print.
 148
 149 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 150
 151         * symtab.c (search_symbols): Adjust msymbol matching type arrays
 152         so that GDB doesn't match any msymbols when searching in the
 153         TYPES_DOMAIN.
 154         (print_symbol_info): Print using typedef_print or type_print based
 155         on the type of the symbol.  Add updated FIXME comment moved from...
 156         (_initialize_symtab): ... move and update FIXME comment to above.
 157
 158 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 159
 160         * NEWS: Mention adding -q option to "info types".
 161         * symtab.c (struct info_types_options): New struct.
 162         (info_types_options_defs): New variable.
 163         (make_info_types_options_def_group): New function.
 164         (info_types_command): Use gdb::option framework to parse options.
 165         (info_types_command_completer): New function.
 166         (_initialize_symtab): Extend the help text on "info types" and
 167         register command completer.
 168
 169 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
 170
 171         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
 172         (lookup_symbol_in_objfile): Change int to block_enum and add a
 173         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
 174
 175 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
 176
 177         * MAINTAINERS (Write After Approval): Add self.
 178
 179 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
 180
 181         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
 182         instruction to the dummy code region.
 183
 184 2019-07-19  Tom Tromey  <tromey@adacore.com>
 185
 186         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
 187         (ARGSUSED, PARAMS, __func__): Remove rules.
 188
 189 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 190
 191         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
 192         * features/arm/arm-with-iwmmxt.c: Remove.
 193         * features/arm/arm-with-iwmmxt.xml: Remove.
 194         * features/arm/arm-with-m-fpa-layout.c: Remove.
 195         * features/arm/arm-with-m-fpa-layout.xml: Remove.
 196         * features/arm/arm-with-m-vfp-d16.c: Remove.
 197         * features/arm/arm-with-m-vfp-d16.xml: Remove.
 198         * features/arm/arm-with-m.c: Remove.
 199         * features/arm/arm-with-m.xml: Remove.
 200         * features/arm/arm-with-neon.c: Remove.
 201         * features/arm/arm-with-neon.xml: Remove.
 202         * features/arm/arm-with-vfpv2.c: Remove.
 203         * features/arm/arm-with-vfpv2.xml: Remove.
 204         * features/arm/arm-with-vfpv3.c: Remove.
 205         * features/arm/arm-with-vfpv3.xml: Remove.
 206
 207 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 208
 209         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
 210
 211 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 212
 213         * arch/aarch32.c (aarch32_create_target_description): Create
 214         target descriptions using features.
 215         * arch/arm.c (arm_create_target_description)
 216         (arm_create_mprofile_target_description): Likewise.
 217         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
 218
 219 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 220
 221         * Makefile.in: Add new files.
 222         * aarch32-tdep.c: New file.
 223         * aarch32-tdep.h: New file.
 224         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 225         Call aarch32_read_description.
 226         * arch/aarch32.c: New file.
 227         * arch/aarch32.h: New file.
 228         * arch/arm.c (arm_create_target_description)
 229         (arm_create_mprofile_target_description): New function.
 230         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
 231         (arm_create_target_description)
 232         (arm_create_mprofile_target_description): New declaration.
 233         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
 234         read_description functions.
 235         * arm-linux-nat.c (arm_linux_nat_target::read_description):
 236         Likewise.
 237         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 238         * arm-tdep.c (tdesc_arm_list): New variable.
 239         (arm_register_g_packet_guesses): Call create description functions.
 240         (arm_read_description) (arm_read_mprofile_description): New
 241         function.
 242         * arm-tdep.h (arm_read_description)
 243         (arm_read_mprofile_description): Add declaration.
 244         * configure.tgt: Add new files.
 245
 246 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
 247
 248         * top.c (new_ui_command): Open specified terminal just once.
 249
 250 2019-07-18  Tom Tromey  <tromey@adacore.com>
 251
 252         * symtab.c (main_name): Constify return type.
 253         * symfile.c (set_initial_language): Update.
 254         * symtab.h (main_name): Constify return type.
 255
 256 2019-07-17  Tom Tromey  <tom@tromey.com>
 257
 258         * tui/tui-winsource.c (tui_update_source_window)
 259         (tui_update_source_window_as_is)
 260         (tui_update_source_windows_with_line): Remove return.
 261         * tui/tui-disasm.c (tui_show_disassem)
 262         (tui_show_disassem_and_update_source): Remove return.
 263         * tui/tui.c (tui_reset): Remove return.
 264         * tui/tui-wingeneral.c
 265         (tui_check_and_display_highlight_if_needed): Remove return.
 266
 267 2019-07-17  Tom Tromey  <tom@tromey.com>
 268
 269         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
 270
 271 2019-07-17  Tom Tromey  <tom@tromey.com>
 272
 273         * tui/tui-winsource.h (struct tui_exec_info_window)
 274         (struct tui_source_window_base): Move from tui-data.h.
 275         * tui/tui-winsource.c: Move many method definitions from
 276         elsewhere.  Remove "structuring" comments.
 277         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
 278         (tui_source_window_base::refresh_window): Move to
 279         tui-winsource.c.
 280         * tui/tui-win.c (tui_source_window_base::refresh_all)
 281         (tui_source_window_base::update_tab_width)
 282         (tui_source_window_base::set_new_height)
 283         (tui_source_window_base::do_make_visible_with_new_height): Move to
 284         tui-winsource.c.
 285         * tui/tui-source.h: Update.
 286         * tui/tui-source.c (tui_source_window_base::reset): Move to
 287         tui-winsource.c.
 288         * tui/tui-disasm.h: Update.
 289         * tui/tui-data.h (struct tui_exec_info_window): Move to
 290         tui-winsource.h.
 291         (struct tui_source_window_base): Likewise.
 292         * tui/tui-data.c (tui_source_window_base::clear_detail)
 293         (tui_source_window_base, ~tui_source_window_base): Move to
 294         tui-winsource.c.
 295
 296 2019-07-17  Tom Tromey  <tom@tromey.com>
 297
 298         * tui/tui-win.c (tui_resize_all)
 299         (tui_source_window_base::update_tab_width)
 300         (tui_adjust_win_heights): Update.
 301         (tui_win_info::make_invisible_and_set_new_height): Rename from
 302         make_invisible_and_set_new_height.
 303         * tui/tui-data.h (struct tui_win_info)
 304         <make_invisible_and_set_new_height>: New method.
 305
 306 2019-07-17  Tom Tromey  <tom@tromey.com>
 307
 308         * tui/tui.c: Update.
 309         * tui/tui-source.h (struct tui_source_window): Move from
 310         tui-data.h.
 311         * tui/tui-layout.c: Update.
 312         * tui/tui-disasm.c: Update.
 313         * tui/tui-data.h (struct tui_source_window): Move to
 314         tui-source.h.
 315
 316 2019-07-17  Tom Tromey  <tom@tromey.com>
 317
 318         * tui/tui-disasm.h (struct tui_disasm_window): Move from
 319         tui-data.h.
 320         * tui/tui-data.h (struct tui_disasm_window): Move to
 321         tui-disasm.h.
 322
 323 2019-07-17  Tom Tromey  <tom@tromey.com>
 324
 325         * tui/tui-regs.h (struct tui_data_item_window): Move from
 326         tui-data.h.
 327         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
 328         * tui/tui-data.h (struct tui_data_item_window): Move to
 329         tui-regs.h.
 330         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
 331
 332 2019-07-17  Tom Tromey  <tom@tromey.com>
 333
 334         * tui/tui.c: Update.
 335         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
 336         (tui_cmd_window::max_height): Move to tui-command.c.
 337         * tui/tui-layout.c: Update.
 338         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
 339         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
 340         tui-command.c.
 341         * tui/tui-command.h (struct tui_cmd_window): Move from
 342         tui-data.h.
 343         * tui/tui-command.c: Remove "structuring" comments.
 344         (tui_cmd_window::clear_detail)
 345         (tui_cmd_window::do_make_visible_with_new_height)
 346         (tui_cmd_window::max_height): Move from elsewhere.
 347
 348 2019-07-17  Tom Tromey  <tom@tromey.com>
 349
 350         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
 351         Now static.
 352         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
 353         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
 354
 355 2019-07-17  Tom Tromey  <tom@tromey.com>
 356
 357         * tui/tui.c: Update.
 358         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
 359         tui-regs.c.
 360         * tui/tui-windata.h: Remove file.
 361         * tui/tui-windata.c: Remove file.
 362         * tui/tui-win.c (tui_data_window::set_new_height)
 363         (tui_data_window::do_make_visible_with_new_height): Move to
 364         tui-regs.c.
 365         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
 366         * tui/tui-regs.c: Remove "structuring" comments.
 367         (tui_data_window::first_data_item_displayed)
 368         (tui_data_window::delete_data_content_windows)
 369         (tui_data_window::erase_data_content)
 370         (tui_data_window::display_all_data)
 371         (tui_data_window::refresh_all)
 372         (tui_data_window::do_scroll_vertical)
 373         (tui_data_window::clear_detail, tui_data_window::set_new_height)
 374         (tui_data_window::do_make_visible_with_new_height)
 375         (tui_data_window::refresh_window): Move from elsewhere.
 376         (_initialize_tui_regs): Move to end of file.
 377         * tui/tui-layout.c: Update.
 378         * tui/tui-hooks.c: Update.
 379         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
 380         * tui/tui-data.c (tui_data_window::clear_detail): Move to
 381         tui-regs.c.
 382         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
 383
 384 2019-07-17  Tom Tromey  <tom@tromey.com>
 385
 386         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
 387         seen.
 388
 389 2019-07-17  Tom Tromey  <tom@tromey.com>
 390
 391         * tui/tui-win.c (tui_source_window_base::set_new_height)
 392         (tui_source_window_base::do_make_visible_with_new_height): Use
 393         m_has_locator field directly.
 394         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
 395         method.
 396         (struct tui_source_window_base) <has_locator>: Likewise.
 397
 398 2019-07-17  Tom Tromey  <tom@tromey.com>
 399
 400         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
 401         Don't declare.
 402         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
 403         Remove.
 404         * tui/tui-win.c (tui_source_window_base::set_new_height)
 405         (tui_source_window_base::set_new_height)
 406         (make_invisible_and_set_new_height)
 407         (tui_source_window_base::do_make_visible_with_new_height)
 408         (tui_source_window_base::do_make_visible_with_new_height):
 409         Update.
 410         * tui/tui-layout.c (show_source_disasm_command, show_data)
 411         (show_source_or_disasm_and_command): Update.
 412         * tui/tui-layout.c (show_layout): Update.
 413
 414 2019-07-17  Tom Tromey  <tom@tromey.com>
 415
 416         * tui/tui-layout.c (make_data_window): Remove.
 417         (show_data): Unify creation and re-initialization cases.
 418
 419 2019-07-17  Tom Tromey  <tom@tromey.com>
 420
 421         * tui/tui-layout.c (make_source_window, make_disasm_window):
 422         Remove.
 423         (show_data): Unify creation and re-initialization cases.
 424
 425 2019-07-17  Tom Tromey  <tom@tromey.com>
 426
 427         * tui/tui-layout.c (make_command_window): Remove.
 428         (show_source_disasm_command, show_source_or_disasm_and_command):
 429         Unify creation and re-initialization cases.
 430
 431 2019-07-17  Tom Tromey  <tom@tromey.com>
 432
 433         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
 434         creation and re-initialization cases.
 435
 436 2019-07-17  Tom Tromey  <tom@tromey.com>
 437
 438         * tui/tui-regs.c (tui_get_register): Return void.
 439
 440 2019-07-17  Tom Tromey  <tom@tromey.com>
 441
 442         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
 443         Simplify.
 444
 445 2019-07-17  Tom Tromey  <tom@tromey.com>
 446
 447         * tui/tui-layout.c (show_source_disasm_command): Simplify window
 448         resetting.
 449
 450 2019-07-17  Tom Tromey  <tom@tromey.com>
 451
 452         * tui/tui.h (tui_set_layout_by_name): Don't declare.
 453         * tui/tui-regs.c (tui_reg_layout): New function.
 454         (tui_show_registers, tui_reg_command): Use it.
 455         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
 456         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
 457         parameters.
 458         (tui_layout_command): Remove.
 459
 460 2019-07-17  Tom Tromey  <tom@tromey.com>
 461
 462         * tui/tui-layout.h (tui/tui-layout): Return void.
 463         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
 464
 465 2019-07-17  Tom Tromey  <tom@tromey.com>
 466
 467         * tui/tui-layout.c (show_source_disasm_command, show_data):
 468         Update.
 469         (reset_locator): Remove.
 470         (show_source_or_disasm_and_command): Update.
 471
 472 2019-07-17  Tom Tromey  <tom@tromey.com>
 473
 474         * tui/tui-source.c (tui_source_window_base::reset): Remove
 475         win_type parameter.
 476         * tui/tui-layout.c (make_command_window, make_source_window)
 477         (make_disasm_window, make_data_window)
 478         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
 479         (reset_locator, show_source_or_disasm_and_command): Update.
 480         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
 481         win_type parameter.
 482         (struct tui_source_window_base) <reset>: Likewise.
 483
 484 2019-07-17  Tom Tromey  <tom@tromey.com>
 485
 486         * tui/tui-layout.c (show_source_disasm_command): Use
 487         reset_locator.
 488         (reset_locator): New function.
 489         (init_and_make_win): Remove.
 490         (show_source_or_disasm_and_command): Use reset_locator.
 491
 492 2019-07-17  Tom Tromey  <tom@tromey.com>
 493
 494         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
 495         condition.
 496         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
 497         Remove condition.
 498         * tui/tui-source.c (tui_source_window_base::reset): New method.
 499         * tui/tui-layout.c (make_command_window): Don't call
 500         init_and_make_win.
 501         (make_source_window, make_disasm_window): Don't call
 502         make_source_or_disasm_window.
 503         (make_data_window): Don't call init_and_make_win.  Change calling
 504         convention.
 505         (show_source_disasm_command, show_data): Simplify.
 506         (make_source_or_disasm_window): Remove.
 507         (show_source_or_disasm_and_command): Simplify.
 508         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
 509         (struct tui_source_window_base) <reset>: Likewise.
 510         <execution_info>: Remove initializer.
 511         * tui/tui-data.c (tui_source_window_base): Initialize
 512         execution_info.
 513
 514 2019-07-17  Tom Tromey  <tom@tromey.com>
 515
 516         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
 517         variable.
 518
 519 2019-07-17  Tom Tromey  <tom@tromey.com>
 520
 521         * tui/tui.c (tui_rl_other_window): Update.
 522         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
 523         superclass method first.  Always iterate over regs_content.
 524         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
 525         method.
 526         * tui/tui-win.c (tui_set_focus_command): Update.
 527
 528 2019-07-17  Tom Tromey  <tom@tromey.com>
 529
 530         * tui/tui-win.c (tui_set_focus_command): Rename from
 531         tui_set_focus.  Call tui_enable.
 532         (tui_set_focus_command): Remove.
 533
 534 2019-07-17  Tom Tromey  <tom@tromey.com>
 535
 536         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
 537         refresh_window.
 538         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
 539         touchwin.
 540         (tui_data_window::refresh_window): Call refresh_window on data
 541         items.  Always call superclass refresh_window.
 542         (tui_win_info::refresh): Remove.
 543         (tui_source_window_base::refresh_window): Update.
 544         (tui_refresh_all): Update.
 545         * tui/tui-layout.c (show_source_disasm_command): Remove call to
 546         refresh_window.
 547         (show_source_or_disasm_and_command): Likewise.
 548         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 549         (struct tui_source_window_base) <refresh>: Likewise.
 550
 551 2019-07-17  Tom Tromey  <tom@tromey.com>
 552
 553         * tui/tui-winsource.c (tui_clear_source_content)
 554         (tui_show_source_content): Update.
 555         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 556         whether content is empty.
 557         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 558         Remove.
 559
 560 2019-07-17  Tom Tromey  <tom@tromey.com>
 561
 562         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 563         window's contents.
 564         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 565         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 566
 567 2019-07-17  Tom Tromey  <tom@tromey.com>
 568
 569         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 570         (struct tui_data_item_window): Update.
 571
 572 2019-07-17  Tom Tromey  <tom@tromey.com>
 573
 574         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 575         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 576         defines.
 577
 578 2019-07-17  Tom Tromey  <tom@tromey.com>
 579
 580         * tui/tui-winsource.h (tui_erase_source_content)
 581         (tui_clear_source_content): Remove "display_prompt" parameter.
 582         * tui/tui-winsource.c (tui_update_source_window_as_is)
 583         (tui_update_source_windows_with_addr): Update.
 584         (tui_clear_source_content): Remove "display_prompt" parameter.
 585         (tui_erase_source_content): Likewise.  Simplify.
 586         (tui_show_source_content): Update.
 587         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 588         * tui/tui-stack.c (tui_show_frame_info): Update.
 589         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 590         Remove defines.
 591
 592 2019-07-17  Tom Tromey  <tom@tromey.com>
 593
 594         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 595         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 596         parameter.
 597         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 598         parameter.
 599
 600 2019-07-17  Tom Tromey  <tom@tromey.com>
 601
 602         * tui/tui-winsource.c (tui_clear_source_content)
 603         (tui_show_source_content, tui_show_exec_info_content)
 604         (tui_clear_exec_info_content): Update.
 605         * tui/tui-stack.c (tui_show_locator_content): Update.
 606         (tui_show_frame_info): Update.
 607         * tui/tui-source.h (tui_source_window): Don't declare.
 608         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 609         from tui_source_is_displayed.
 610         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 611         Remove field.
 612         (struct tui_source_window_base) <content_in_use>: New field.  Now
 613         bool.
 614         (struct tui_source_window) <showing_source_p>: New method.
 615         (TUI_SRC_WIN): Change cast.
 616         * tui/tui-data.c (tui_initialize_static_data): Update.
 617
 618 2019-07-17  Tom Tromey  <tom@tromey.com>
 619
 620         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 621         location_matches_p.
 622         * tui/tui-source.c (tui_source_window::location_matches_p): New
 623         method.
 624         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 625         method.
 626         * tui/tui-data.h (struct tui_source_window_base)
 627         <location_matches_p>: New method.
 628         (struct tui_source_window, struct tui_disasm_window)
 629         <location_matches_p>: Likewise.
 630
 631 2019-07-17  Tom Tromey  <tom@tromey.com>
 632
 633         * tui/tui-win.c (tui_set_win_height_command): Rename from
 634         tui_set_win_height.
 635         (tui_set_win_height_command): Remove.
 636
 637 2019-07-17  Tom Tromey  <tom@tromey.com>
 638
 639         * tui/tui-source.c (tui_source_window): New constructor.  Add
 640         observer.
 641         (~tui_source_window): New destructor.
 642         (tui_source_window::style_changed): New method.
 643         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 644         (tui_attach_detach_observers): Update.
 645         * tui/tui-data.h (struct tui_source_window): Make constructor not
 646         inline.  Add destructor.
 647         (struct tui_source_window) <style_changed>: New method.
 648         <m_observable>: New member.
 649
 650 2019-07-17  Tom Tromey  <tom@tromey.com>
 651
 652         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 653         * tui/tui-win.c (tui_resize_all): Fix typo.
 654
 655 2019-07-17  Tom Tromey  <tom@tromey.com>
 656
 657         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 658         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 659         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 660         * tui/tui-win.c (window_name_completer): Use foreach.
 661         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 662         (update_tab_width): Likewise.
 663         * tui/tui-layout.c (show_layout): Update.
 664         * tui/tui-data.h (class tui_window_iterator): New.
 665         (struct all_tui_windows): New.
 666         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 667
 668 2019-07-17  Tom Tromey  <tom@tromey.com>
 669
 670         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 671         parameter.  Don't reference globals.
 672         (tui_reg_command): Update.
 673
 674 2019-07-17  Tom Tromey  <tom@tromey.com>
 675
 676         * tui/tui-regs.c (tui_show_registers): Simplify.
 677
 678 2019-07-17  Tom Tromey  <tom@tromey.com>
 679
 680         * tui/tui-regs.c (tui_show_registers): Update.
 681         (tui_show_register_group): Add win_info parameter.
 682
 683 2019-07-17  Tom Tromey  <tom@tromey.com>
 684
 685         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 686         Rename from tui_display_reg_element_at_line.
 687         (tui_data_window::display_registers_from_line): Update.
 688         * tui/tui-data.h (struct tui_data_window)
 689         <display_reg_element_at_line>: New method.
 690
 691 2019-07-17  Tom Tromey  <tom@tromey.com>
 692
 693         * tui/tui-regs.h (tui_display_registers_from)
 694         (tui_display_registers_from_line): Don't declare.
 695         * tui/tui-windata.c (tui_data_window::display_all_data)
 696         (tui_data_window::refresh_all)
 697         (tui_data_window::do_scroll_vertical): Update.
 698         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 699         from tui_display_registers_from.
 700         (tui_display_reg_element_at_line): Update.
 701         (tui_data_window::display_registers_from_line): Rename from
 702         tui_display_registers_from_line.
 703         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 704         display_registers_from_line>: New methods.
 705
 706 2019-07-17  Tom Tromey  <tom@tromey.com>
 707
 708         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 709         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 710         from tui_erase_data_content.
 711         (tui_data_window::display_all_data)
 712         (tui_data_window::refresh_all)
 713         (tui_data_window::do_scroll_vertical): Update.
 714         * tui/tui-regs.c (tui_show_registers): Update.
 715         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 716         New method.
 717
 718 2019-07-17  Tom Tromey  <tom@tromey.com>
 719
 720         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 721         declare.
 722         * tui/tui-windata.c
 723         (tui_data_window::delete_data_content_windows): Rename from
 724         tui_delete_data_content_windows.
 725         (tui_data_window::display_all_data)
 726         (tui_data_window::do_scroll_vertical): Update.
 727         * tui/tui-data.h (struct tui_data_window)
 728         <delete_data_content_windows>: New method.
 729
 730 2019-07-17  Tom Tromey  <tom@tromey.com>
 731
 732         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 733         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 734
 735 2019-07-17  Tom Tromey  <tom@tromey.com>
 736
 737         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 738         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 739         from tui_display_all_data.
 740         * tui/tui-win.c
 741         (tui_data_window::do_make_visible_with_new_height): Update.
 742         * tui/tui-regs.c (tui_show_registers): Update.
 743         * tui/tui-layout.c (tui_set_layout): Update.
 744         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 745         method.
 746
 747 2019-07-17  Tom Tromey  <tom@tromey.com>
 748
 749         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 750         * tui/tui-windata.c (tui_display_data_from): Remove.
 751         (tui_data_window::refresh_all): Update.
 752
 753 2019-07-17  Tom Tromey  <tom@tromey.com>
 754
 755         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 756         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 757         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 758         tui_display_registers_from_line.
 759         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 760         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 761         "force_display" parameter.
 762
 763 2019-07-17  Tom Tromey  <tom@tromey.com>
 764
 765         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 766         declare.
 767         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 768         Rename from tui_first_reg_element_no_inline.
 769         (tui_display_reg_element_at_line)
 770         (tui_display_registers_from_line): Update.
 771         * tui/tui-data.h (struct tui_data_window)
 772         <first_reg_element_no_inline>: New method.
 773
 774 2019-07-17  Tom Tromey  <tom@tromey.com>
 775
 776         * tui/tui-windata.c (tui_display_data_from)
 777         (tui_data_window::do_scroll_vertical): Update.
 778         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 779         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 780         Rename from tui_line_from_reg_element_no.
 781         (tui_display_registers_from_line): Update.
 782         * tui/tui-data.h (struct tui_data_window)
 783         <line_from_reg_element_no>: New method.
 784
 785 2019-07-17  Tom Tromey  <tom@tromey.com>
 786
 787         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 788         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 789         tui_last_regs_line_no.
 790         (tui_display_reg_element_at_line)
 791         (tui_display_registers_from_line): Update.
 792         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 793         method.
 794
 795 2019-07-17  Tom Tromey  <tom@tromey.com>
 796
 797         PR tui/24722:
 798         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 799         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 800         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 801         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 802         (tui_update_breakpoint_info): Likewise.
 803         * tui/tui-hooks.c (tui_event_create_breakpoint)
 804         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 805         Update.
 806
 807 2019-07-17  Tom Tromey  <tom@tromey.com>
 808
 809         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 810
 811 2019-07-17  Tom Tromey  <tom@tromey.com>
 812
 813         * tui/tui-winsource.c (tui_update_source_window_as_is)
 814         (tui_update_source_windows_with_addr): Update.
 815         * tui/tui-source.h (tui_set_source_content)
 816         (tui_show_symtab_source): Add "win_info" parameter.
 817         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 818         parameter.
 819         (tui_show_symtab_source): Likewise.
 820
 821 2019-07-17  Tom Tromey  <tom@tromey.com>
 822
 823         * tui/tui-wingeneral.c
 824         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 825
 826 2019-07-17  Tom Tromey  <tom@tromey.com>
 827
 828         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 829         (struct tui_cmd_window) <can_scroll>: New method.
 830         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 831         method.
 832
 833 2019-07-17  Tom Tromey  <tromey@adacore.com>
 834
 835         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 836         do_field_signed>: Rename.  Change type of "value".
 837         * ui-out.c (ui_out::field_signed): Rename from field_int.
 838         Change type of "value".
 839         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 840         type of "value".
 841         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 842         do_field_int.  Change type of "value".
 843         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 844         do_field_int.  Change type of "value".
 845         * tracepoint.c (trace_status_mi, tfind_1)
 846         (print_one_static_tracepoint_marker): Update.
 847         * thread.c (print_thread_info_1, print_selected_thread_frame):
 848         Update.
 849         * stack.c (print_frame, print_frame_info): Update.
 850         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 851         Update.
 852         * source.c (print_source_lines_base): Update.
 853         * skip.c (info_skip_command): Update.
 854         * record-btrace.c (btrace_ui_out_decode_error)
 855         (btrace_call_history_src_line): Update.
 856         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 857         Update.
 858         * progspace.c (print_program_space): Update.
 859         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 860         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 861         do_field_int.  Change type of "value".
 862         * mi/mi-out.c (mi_ui_out::do_table_begin)
 863         (mi_ui_out::do_table_header): Update.
 864         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 865         type of "value".
 866         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 867         (mi_cmd_data_list_changed_registers, output_register)
 868         (mi_cmd_data_read_memory, mi_load_progress)
 869         (mi_cmd_trace_frame_collected): Update.
 870         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 871         Update.
 872         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 873         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 874         (mi_cmd_var_list_children, varobj_update_one): Update.
 875         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 876         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 877         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 878         * inferior.c (print_inferior): Update.
 879         * gdb_bfd.c (print_one_bfd): Update.
 880         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 881         Update.
 882         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 883         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 884         do_field_int.  Change type of "value".
 885         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 886         do_field_int.  Change type of "value".
 887         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 888         (print_one_breakpoint_location, print_it_catch_fork)
 889         (print_one_catch_fork, print_it_catch_vfork)
 890         (print_one_catch_vfork, print_it_catch_solib)
 891         (print_it_catch_exec, print_it_ranged_breakpoint)
 892         (print_mention_watchpoint, print_mention_masked_watchpoint)
 893         (bkpt_print_it, update_static_tracepoint): Update.
 894         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 895         * break-catch-syscall.c (print_it_catch_syscall): Update.
 896         * ada-tasks.c (print_ada_task_info): Update.
 897         * ada-lang.c (print_it_exception, print_mention_exception):
 898         Update.
 899
 900 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 901
 902         PR breakpoints/24541
 903         * gdbarch.c: Regenerate.
 904         * gdbarch.h: Regenerate.
 905         * gdbarch.sh: Adjust return type and parameter types for
 906         'stap_adjust_register'.
 907         (i386_stap_adjust_register): Adjust signature and return new
 908         register name.
 909         * stap-probe.c (stap_parse_register_operand): Adjust use of
 910         'gdbarch_stap_adjust_register'.
 911
 912 2019-07-17  Tom Tromey  <tromey@adacore.com>
 913
 914         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 915         declare VEC.
 916         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 917         std::vector.
 918         (struct s390_process_info): Add initializers.
 919         (s390_add_process): Use new.
 920         (s390_linux_nat_target::low_forget_process): Use delete.
 921         (s390_linux_nat_target::low_new_fork)
 922         (s390_linux_nat_target::stopped_by_watchpoint)
 923         (s390_linux_nat_target::low_prepare_to_resume)
 924         (s390_linux_nat_target::insert_watchpoint)
 925         (s390_linux_nat_target::insert_hw_breakpoint)
 926         (s390_linux_nat_target::remove_watchpoint)
 927         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 928
 929 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 930
 931         * aarch64-fbsd-nat.c: Include regcache.h.
 932         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 933         argument.
 934         (aarch64_fbsd_nat_target::fetch_registers)
 935         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 936         variable.
 937         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 938
 939 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 940
 941         * fbsd-nat.c: Include gdbarch.h.
 942
 943 2019-07-15  Tom Tromey  <tromey@adacore.com>
 944
 945         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 946
 947 2019-07-15  Tom Tromey  <tromey@adacore.com>
 948
 949         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 950         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 951         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 952         * cli-out.c (cli_ui_out::do_field_int): New method.
 953         * ui-out.c (ui_out::field_unsigned): New method.
 954         * symfile.c (generic_load): Use field_unsigned.
 955         (print_transfer_performance): Likewise.
 956         * record-btrace.c (ui_out_field_uint): Remove.
 957         (btrace_call_history_insn_range, btrace_call_history): Use
 958         field_unsigned.
 959         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 960         field_unsigned.
 961         * ui-out.h (class ui_out) <field_unsigned>: New method.
 962         <do_field_unsigned>: Likewise.
 963
 964 2019-07-15  Tom Tromey  <tromey@adacore.com>
 965
 966         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 967         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 968         * target.c (flash_erase_command): Use field_string.
 969         * infrun.c (print_signal_received_reason): Use field_string.
 970         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 971         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 972         field_string.
 973         * ada-tasks.c (print_ada_task_info): Use field_string.
 974
 975 2019-07-15  Tom Tromey  <tromey@adacore.com>
 976
 977         * target.c (flash_erase_command): Use field_core_addr.
 978         * symfile.c (generic_load): Use field_core_addr.
 979         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 980         Use field_core_addr.
 981         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 982         field_core_addr.
 983
 984 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 985
 986         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 987         value if its desired type is smaller than a CORE_ADDR and signed.
 988
 989 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 990
 991         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 992         of changes to field names, and use new is_reference field to
 993         decide if a property is a reference or not.
 994         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 995         field.
 996         (struct dwarf2_property_baton): Update header comment, rename
 997         'referenced_type' to 'property_type' and update comments.
 998         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 999         default property type, store in property baton, update to take
1000         accound of renamed field.
1001         (read_func_scope): Update call to attr_to_dynamic_prop.
1002         (read_array_type): Likewise.
1003         (dwarf2_per_cu_addr_sized_int_type): New function.
1004         (read_subrange_index_type): Move type finding code to
1005         dwarf2_per_cu_addr_sized_int_type.
1006         (read_subrange_type): Update calls to attr_to_dynamic_prop.
1007         (dwarf2_per_cu_addr_type): New function.
1008         (set_die_type): Update calls to attr_to_dynamic_prop.
1009
1010 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1011
1012         * dwarf2read.c (read_subrange_index_type): New function.
1013         (read_subrange_type): Move code into new function and call it.
1014         * gdbtypes.c (create_range_type): Add some asserts.
1015
1016 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1017
1018         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
1019         update return statements.
1020         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
1021         declaration, and update comment to match.
1022         * gdbtypes.c (resolve_dynamic_array): Update call to
1023         dwarf2_evaluate_property to match new return type.
1024
1025 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1026
1027         * valarith.c (value_subscripted_rvalue): Change lowerbound
1028         parameter type from int to LONGEST.
1029         * value.h (value_subscripted_rvalue): Likewise in declaration.
1030
1031 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1032
1033         * cli/cli-utils.c (info_print_command_completer): New function.
1034         * cli/cli-utils.h: Add 'completer.h' include, and forward
1035         declaration for 'struct cmd_list_element'.
1036         (info_print_command_completer): Declare.
1037         * stack.c (_initialize_stack): Add completer for 'info locals' and
1038         'info args'.
1039         * symtab.c (_initialize_symtab): Add completer for 'info
1040         variables' and 'info functions'.
1041         * NEWS: Mention completion for additional info commands.
1042
1043 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1044
1045         * cli/cli-utils.c (extract_info_print_args): Delete.
1046         (extract_arg_maybe_quoted): Delete.
1047         (info_print_options_defs): New variable.
1048         (make_info_print_options_def_group): New function.
1049         (extract_info_print_options): Define new function.
1050         * cli/cli-utils.h (extract_info_print_args): Delete.
1051         (struct info_print_options): New structure.
1052         (extract_info_print_options): Declare new function.
1053         * stack.c (info_locals_command): Update to use new
1054         extract_info_print_options, also add a header comment.
1055         (info_args_command): Likewise.
1056         * symtab.c (info_variables_command): Likewise.
1057         (info_functions_command): Likewise.
1058
1059 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1060
1061         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
1062         to extract string arguments.
1063         * common/common-utils.c (extract_string_maybe_quoted): New function.
1064         * common/common-utils.h (extract_string_maybe_quoted): Declare.
1065
1066 2019-07-11  Tom Tromey  <tromey@adacore.com>
1067
1068         * main.c (get_init_files): Use GDBINIT, not gdbinit.
1069         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
1070         * top.h (gdbinit): Don't declare.
1071         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
1072         into...
1073         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
1074         * top.c (gdb_init): Don't call init_cli_cmds.
1075         (gdbinit): Remove.
1076         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
1077
1078 2019-07-11  Tom Tromey  <tromey@adacore.com>
1079
1080         * python/py-inferior.c (add_thread_object): Don't use thread_obj
1081         after it has been moved.
1082
1083 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1084
1085         * valops.c (value_must_coerce_to_target): Change return type to
1086         bool.
1087         * value.h (value_must_coerce_to_target): Likewise.
1088
1089 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
1090
1091         * breakpoint.c (is_hardware_watchpoint): Remove
1092         forward-declaration.
1093         (is_masked_watchpoint): Change return type to bool.
1094         (is_tracepoint): Likewise.
1095         (is_breakpoint): Likewise.
1096         (is_hardware_watchpoint): Likewise.
1097         (is_watchpoint): Likewise.
1098         (is_no_memory_software_watchpoint): Likewise.
1099         (is_catchpoint): Likewise.
1100         (breakpoint_1): Make FILTER parameter's return type bool.
1101         is_masked_watchpoint): Change return type to bool.
1102         (save_breakpoints): Make FILTER parameter's return type bool.
1103         * breakpoint.h (is_breakpoint): Change return type to bool.
1104         (is_watchpoint): Likewise.
1105         (is_catchpoint): Likewise.
1106         (is_tracepoint): Likewise.
1107
1108 2019-07-10  Tom Tromey  <tom@tromey.com>
1109
1110         * defs.h: Don't include gdbarch.h.
1111         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
1112         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
1113         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
1114         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
1115         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
1116         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
1117         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
1118         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
1119         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
1120         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
1121         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
1122         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
1123         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
1124         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
1125         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
1126         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
1127         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
1128         record-btrace.c, record.h, regcache-dump.c, regcache.h,
1129         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
1130         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
1131         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
1132         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
1133         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
1134         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
1135         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
1136         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
1137         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
1138
1139 2019-07-10  Tom Tromey  <tromey@adacore.com>
1140
1141         * ada-lang.h (is_ada_exception_catchpoint): Declare.
1142         * breakpoint.c (init_ada_exception_breakpoint): Register as
1143         bp_catchpoint.
1144         (print_one_breakpoint_location, print_one_breakpoint): Use
1145         is_ada_exception_catchpoint.
1146         * ada-lang.c (class ada_catchpoint_location): Pass
1147         bp_loc_software_breakpoint to bp_location constructor.
1148         (is_ada_exception_catchpoint): New function.
1149
1150 2019-07-10  Tom Tromey  <tromey@adacore.com>
1151
1152         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
1153         VEC.
1154         (struct arm_exidx_entry): New method operator<.
1155         (struct arm_exidx_data) <section_maps>: Change type.
1156         (arm_exidx_data_free): Remove.
1157         (arm_exidx_data_key): Change type.  Move lower.
1158         (arm_exidx_new_objfile): Update.
1159         (arm_compare_exidx_entries): Remove.
1160         (arm_find_exidx_entry, _initialize_arm_tdep)
1161
1162 2019-07-10  Tom Tromey  <tromey@adacore.com>
1163
1164         * solib-spu.c (ocl_program_data_key): Change type.
1165         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
1166         Update.
1167
1168 2019-07-10  Tom Tromey  <tromey@adacore.com>
1169
1170         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
1171         (struct solib_aix_inferior_data) <library_list>: Change type.
1172         (solib_aix_inferior_data_handle): Change type.
1173         (get_solib_aix_inferior_data): Update.
1174         (solib_aix_free_library_list): Remove.
1175         (library_list_start_library): Update.
1176         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1177         return type.
1178         (solib_aix_get_library_list)
1179         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1180         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1181
1182 2019-07-10  Tom Tromey  <tromey@adacore.com>
1183
1184         * solib-dsbt.c (struct dsbt_info): Add initializers.
1185         (solib_dsbt_pspace_data): Change type.
1186         (dsbt_pspace_data_cleanup): Remove.
1187         (get_dsbt_info, _initialize_dsbt_solib): Update.
1188
1189 2019-07-10  Tom Tromey  <tromey@adacore.com>
1190
1191         * spu-tdep.c (spu_overlay_data): Change type.
1192         (spu_get_overlay_table, spu_overlay_new_objfile)
1193         (_initialize_spu_tdep): Update.
1194
1195 2019-07-10  Tom Tromey  <tromey@adacore.com>
1196
1197         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1198         destructor.
1199         (dbx_objfile_data_key): Change type and declare later.
1200         (DBX_SYMFILE_INFO): Rewrite.
1201         * dbxread.c (dbx_objfile_data_key): Change type.
1202         (dbx_symfile_init): Update.
1203         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
1204         (coffstab_build_psymtabs, elfstab_build_psymtabs)
1205         (stabsect_build_psymtabs, _initialize_dbxread): Update.
1206
1207 2019-07-10  Tom Tromey  <tromey@adacore.com>
1208
1209         * jit.c (jit_program_space_key): Change type.  Move lower.
1210         (get_jit_program_space_data): Update.
1211         (jit_program_space_data_cleanup): Remove.
1212         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1213         Update.
1214         (struct jit_program_space_data): Add initializers.
1215
1216 2019-07-10  Tom Tromey  <tromey@adacore.com>
1217
1218         * solib-darwin.c (struct darwin_info): Add initializers.
1219         (solib_darwin_pspace_data): Change type.
1220         (darwin_pspace_data_cleanup): Remove.
1221         (get_darwin_info, _initialize_darwin_solib): Update.
1222
1223 2019-07-10  Tom Tromey  <tromey@adacore.com>
1224
1225         * remote-sim.c (struct sim_inferior_data): Add initializers,
1226         constructor, and destructor.
1227         (sim_inferior_data_key): Change type.  Move lower.
1228         (check_for_duplicate_sim_descriptor): Update.
1229         (get_sim_inferior_data): Use new.  Update.
1230         (~sim_inferior_data_cleanup): Rename from
1231         sim_inferior_data_cleanup.  Simplify.
1232         (gdbsim_close_inferior, simulator_command)
1233         (sim_command_completer, _initialize_remote_sim): Update.
1234         (next_pid, INITIAL_PID): Move earlier.
1235
1236 2019-07-10  Tom Tromey  <tromey@adacore.com>
1237
1238         * python/python-internal.h (create_thread_object): Return
1239         gdbpy_ref.
1240         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1241         * python/py-inferior.c (struct threadlist_entry): Add
1242         constructor.
1243         <thread_obj>: Now a gdbpy_ref.
1244         (thread_to_thread_object): Update.
1245         (add_thread_object): Use new.
1246         (delete_thread_object): Use delete.
1247         (infpy_threads): Update.
1248         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
1249         GIL.
1250
1251 2019-07-10  Tom Tromey  <tromey@adacore.com>
1252
1253         * valops.c (value_cast): Specialize error message for Ada.
1254
1255 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1256
1257         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1258
1259 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1260
1261         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1262         bpstat_should_step): Return bool, adjust comments.
1263         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1264         bpstat_should_step): Likewise.
1265
1266 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1267
1268         * features/Makefile: Use feature target descriptions for Arm.
1269         * features/arm/arm-core.c: Generate new file.
1270         * features/arm/arm-fpa.c: Likewise.
1271         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1272         * features/arm/arm-m-profile.c: Likewise.
1273         * features/arm/arm-vfpv2.c: Likewise.
1274         * features/arm/arm-vfpv3.c: Likewise.
1275         * features/arm/xscale-iwmmxt.c: Likewise.
1276         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1277
1278 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1279
1280         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1281         ptrace earlier.
1282
1283 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1284
1285         * features/aarch64-pauth.c: Regenerate.
1286
1287 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1288
1289         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1290         bool.
1291         (bpstat_what): Use false instead of 0.
1292
1293 2019-07-09  Pedro Alves  <palves@redhat.com>
1294
1295         * break-catch-throw.c (is_exception_catchpoint): New.
1296         * breakpoint.c (print_one_breakpoint_location): New parameter
1297         'raw_loc'.  Handle it.  Use
1298         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1299         looking at the breakpoint's type.
1300         (print_one_breakpoint): If handling "maint info breakpoints", also
1301         print locations of exception catchpoints.
1302         * breakpoint.h (is_exception_catchpoint): Declare.
1303
1304 2019-07-09  Pedro Alves  <palves@redhat.com>
1305
1306         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1307         "addr" field.
1308         (allocate_location_exception_catchpoint): New.
1309         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1310         (initialize_throw_catchpoint_ops): Install
1311         allocate_location_exception_catchpoint as allocate_location
1312         method.
1313         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1314         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1315         bp_loc_other.
1316         (breakpoint_address_is_meaningful): Delete.
1317         (bl_address_is_meaningful): New.
1318         (breakpoint_locations_match): Adjust comment.
1319         (bp_location_from_bp_type): New, factored out of...
1320         (bp_location::bp_location(breakpoint *)): ... this.
1321         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1322         factored out of...
1323         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1324         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1325         breakpoint_address_is_meaningful.
1326         (bp_locations_compare): Adjust comment.
1327         (update_global_location_list): Use bl_address_is_meaningful
1328         instead of breakpoint_address_is_meaningful.
1329         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1330         explicit.
1331         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1332         * python/py-breakpoint.c (bppy_get_location): No longer check
1333         whether location is null.
1334
1335 2019-07-09  Pedro Alves  <palves@redhat.com>
1336
1337         PR c++/15468
1338         * breakpoint.c (print_one_breakpoint_location): Remove
1339         single-location assert.
1340
1341 2019-07-09  Tom Tromey  <tom@tromey.com>
1342
1343         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1344         * configure: Rebuild.
1345         * configure.ac: Change common to gdbsupport.
1346         * gdbsupport: Rename from common.
1347         * acinclude.m4: Change common to gdbsupport.
1348         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1349         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1350         gdbsupport.
1351         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1352         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1353         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1354         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1355         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1356         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1357         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1358         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1359         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1360         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1361         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1362         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1363         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1364         coff-pe-read.c, command.h, compile/compile-c-support.c,
1365         compile/compile-c.h, compile/compile-cplus-symbols.c,
1366         compile/compile-cplus-types.c, compile/compile-cplus.h,
1367         compile/compile-loc2c.c, compile/compile.c, completer.c,
1368         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1369         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1370         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1371         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1372         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1373         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1374         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1375         features/aarch64-core.c, features/aarch64-fpu.c,
1376         features/aarch64-pauth.c, features/aarch64-sve.c,
1377         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1378         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1379         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1380         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1381         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1382         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1383         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1384         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1385         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1386         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1387         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1388         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1389         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1390         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1391         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1392         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1393         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1394         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1395         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1396         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1397         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1398         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1399         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1400         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1401         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1402         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1403         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1404         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1405         minsyms.c, mips-linux-tdep.c, namespace.h,
1406         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1407         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1408         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1409         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1410         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1411         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1412         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1413         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1414         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1415         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1416         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1417         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1418         procfs.c, producer.c, progspace.h, psymtab.h,
1419         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1420         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1421         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1422         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1423         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1424         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1425         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1426         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1427         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1428         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1429         target-memory.c, target.c, target.h, target/waitstatus.c,
1430         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1431         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1432         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1433         unittests/array-view-selftests.c,
1434         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1435         unittests/common-utils-selftests.c,
1436         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1437         unittests/format_pieces-selftests.c,
1438         unittests/function-view-selftests.c,
1439         unittests/lookup_name_info-selftests.c,
1440         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1441         unittests/mkdir-recursive-selftests.c,
1442         unittests/observable-selftests.c,
1443         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1444         unittests/parse-connection-spec-selftests.c,
1445         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1446         unittests/scoped_fd-selftests.c,
1447         unittests/scoped_mmap-selftests.c,
1448         unittests/scoped_restore-selftests.c,
1449         unittests/string_view-selftests.c, unittests/style-selftests.c,
1450         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1451         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1452         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1453         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1454         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1455         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1456
1457 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1458
1459         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1460         bool value.
1461         (decode_digits_ordinary): Set explicit_line field in sal.
1462         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1463         symtab_and_line that was set on an explicit line number in
1464         assembler code.  Do always update the recorded symtab and line if
1465         we do skip the prologue.
1466
1467 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1468
1469         * breakpoint.c (set_breakpoint_location_function): Remove
1470         explicit_loc parameter.
1471         (momentary_breakpoint_from_master): Update call to
1472         set_breakpoint_location_function.
1473         (add_location_to_breakpoint): Likewise.
1474
1475 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1476
1477         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1478         required features based on default bfd type when no specific bfd
1479         is present.
1480
1481 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1482
1483         * NEWS: Mention that GDB printf and eval commands can now print
1484         C-style and Ada-style convenience var strings without
1485         calling the inferior.
1486         * printcmd.c (printf_c_string): Locally print GDB internal var
1487         instead of transiting via the inferior.
1488         (printf_wide_c_string): Likewise.
1489
1490 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1491
1492         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1493
1494 2019-07-04  Tom Tromey  <tom@tromey.com>
1495
1496         PR tui/24724:
1497         * tui/tui-winsource.c (tui_clear_source_content): Update.
1498         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1499         (tui_update_breakpoint_info): Update.
1500         (tui_set_exec_info_content): Update.
1501         * tui/tui-source.c (tui_set_source_content_nil): Update.
1502         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1503         has_break.
1504         * tui/tui-data.h (enum tui_bp_flag): New.
1505         (tui_bp_flags): New enum flags type.
1506         (struct tui_source_element) <break_mode>: Change type.  Rename
1507         from has_break.
1508         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1509         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1510         constants.
1511         * tui/tui-winsource.h: Fix comment.
1512
1513 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1514
1515         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1516         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1517         (store_fpregs_to_thread)
1518         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1519         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1520         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1521         (IWMMXT_REGS_SIZE): Add define.
1522         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1523         (fetch_vfp_regs, store_vfp_regs)
1524         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1525         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1526
1527 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1528
1529         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1530         defines.
1531         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1532         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1533         (ARM_INT_REGISTER_SIZE): ...to this.
1534         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1535         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1536         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1537         (arm_linux_collect_gregset, supply_nwfpe_register)
1538         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1539         defines.
1540         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1541         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1542         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1543         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1544         (arm_return_in_memory, arm_store_return_value)
1545         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1546         (arm_record_ld_st_multiple): Likewise.
1547         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1548         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1549
1550 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1551
1552         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1553         AARCH64_DISPLACED_MODIFIED_INSNS.
1554         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1555         (aarch64_displaced_step_copy_insn): Likewise.
1556         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1557         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1558         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1559         ARM_DISPLACED_MODIFIED_INSNS.
1560         * arm-tdep.c (arm_gdbarch_init): Likewise.
1561         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1562         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1563         (struct arm_displaced_step_closure): Use
1564         ARM_DISPLACED_MODIFIED_INSNS.
1565
1566 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1567
1568         * features/Makefile: Remove unused xml files.
1569         * features/aarch64.xml: Remove.
1570         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1571         * features/i386/amd64-avx-avx512.xml: Remove.
1572         * features/i386/amd64-avx-linux.xml: Remove.
1573         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1574         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1575         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1576         * features/i386/amd64-avx-mpx.xml: Remove.
1577         * features/i386/amd64-avx.xml: Remove.
1578         * features/i386/amd64-linux.xml: Remove.
1579         * features/i386/amd64-mpx-linux.xml: Remove.
1580         * features/i386/amd64-mpx.xml: Remove.
1581         * features/i386/amd64.xml: Remove.
1582         * features/i386/i386-avx-avx512-linux.xml: Remove.
1583         * features/i386/i386-avx-avx512.xml: Remove.
1584         * features/i386/i386-avx-linux.xml: Remove.
1585         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1586         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1587         * features/i386/i386-avx-mpx-linux.xml: Remove.
1588         * features/i386/i386-avx-mpx.xml: Remove.
1589         * features/i386/i386-avx.xml: Remove.
1590         * features/i386/i386-linux.xml: Remove.
1591         * features/i386/i386-mmx-linux.xml: Remove.
1592         * features/i386/i386-mmx.xml: Remove.
1593         * features/i386/i386-mpx-linux.xml: Remove.
1594         * features/i386/i386-mpx.xml: Remove.
1595         * features/i386/i386.xml: Remove.
1596         * features/i386/x32-avx-avx512-linux.xml: Remove.
1597         * features/i386/x32-avx-linux.xml: Remove.
1598         * features/i386/x32-linux.xml: Remove.
1599
1600 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1601
1602         * regformats/aarch64.dat: Remove.
1603         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1604         * regformats/i386/amd64-avx-linux.dat: Remove.
1605         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1606         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1607         * regformats/i386/amd64-linux.dat: Remove.
1608         * regformats/i386/amd64-mpx-linux.dat: Remove.
1609         * regformats/i386/amd64.dat: Remove.
1610         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1611         * regformats/i386/i386-avx-linux.dat: Remove.
1612         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1613         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1614         * regformats/i386/i386-linux.dat: Remove.
1615         * regformats/i386/i386-mmx-linux.dat: Remove.
1616         * regformats/i386/i386-mpx-linux.dat: Remove.
1617         * regformats/i386/i386.dat: Remove.
1618         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1619         * regformats/i386/x32-avx-linux.dat: Remove.
1620         * regformats/i386/x32-linux.dat: Remove.
1621
1622 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1623
1624         * aarch64-tdep.c: Remove xml self tests.
1625         * amd64-linux-tdep.c: Likewise.
1626         * amd64-tdep.c: Likewise.
1627         * i386-linux-tdep.c: Likewise.
1628         * i386-tdep.c: Likewise.
1629
1630 2019-07-03  Pedro Alves  <palves@redhat.com>
1631
1632         PR cli/24732
1633         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1634         (pipe_cmd_option_defs): New.
1635         (make_pipe_cmd_options_def_group): New.
1636         (pipe_command): Use gdb::option::process_options.
1637         (pipe_command_completer): New function.
1638         (_initialize_cli_cmds): Install completer for "pipe" command.
1639
1640 2019-07-03  Pedro Alves  <palves@redhat.com>
1641
1642         * cli/cli-option.c (union option_value) <string>: New field.
1643         (struct option_def_and_value): Add ctor, move ctor, dtor and
1644         use DISABLE_COPY_AND_ASSIGN.
1645         (option_def_and_value::clear_value): New.
1646         (parse_option, save_option_value_in_ctx, get_val_type_str)
1647         (add_setshow_cmds_for_options): Handle var_string.
1648         * cli-option.h (union option_def::var_address) <string>: New
1649         field.
1650         (struct string_option_def): New.
1651         * maint-test-options.c (struct test_options_opts): Add default
1652         ctor and use DISABLE_COPY_AND_ASSIGN.
1653         <string_opt>: New field.
1654         (test_options_opts::~test_options_opts): New.
1655         (test_options_opts::dump): Also dump "-string".
1656         (test_options_option_defs): Install "string.
1657
1658 2019-07-03  Pedro Alves  <palves@redhat.com>
1659
1660         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1661         option_value with a null enumeration.
1662         (complete_options): Save the option values in the context.
1663         (save_option_value_in_ctx): New, factored out from ...
1664         (process_options): ... here.
1665         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1666         of the function.
1667         * maint-test-options.c (test_options_opts::dump): New, factored
1668         out from ...
1669         (maintenance_test_options_command_mode): ... here.
1670         (maintenance_test_options_command_completion_result): Delete.
1671         (maintenance_test_options_command_completion_text): Update
1672         comment.
1673         (maintenance_show_test_options_completion_result): Change
1674         prototype.  Just print
1675         maintenance_test_options_command_completion_text.
1676         (save_completion_result): New.
1677         (maintenance_test_options_completer_mode): Pass options context to
1678         complete_options, and then save a dump.
1679         (_initialize_maint_test_options): Use add_cmd to install "maint
1680         show test-options-completion-result".
1681
1682 2019-07-03  Pedro Alves  <palves@redhat.com>
1683
1684         * NEWS (New commands): Mention "with" and "maint with".
1685         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1686         (with_command, with_command_completer): New.
1687         (pipe_command): Adjust to new repeat_previous
1688         interface.
1689         (_initialize_cli_cmds): Install the "with" command and its "w"
1690         alias.
1691         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1692         declarations.
1693         * cli/cli-setshow.c (parse_cli_var_uinteger)
1694         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1695         argument strings for all var_types.
1696         (get_setshow_command_value_string): New, factored out from ...
1697         (do_show_command): ... this.
1698         * cli/cli-setshow.h: Include <string>.
1699         (get_setshow_command_value_string): Declare.
1700         * command.h (repeat_previous): Now returns const char *.  Adjust
1701         comment.
1702         * maint.c: Include "cli/cli-cmds.h".
1703         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1704         (_initialize_maint_cmds): Register the "maintenance with" command.
1705         * top.c (repeat_previous): Move bits from pipe_command here:
1706         Return the saved command line, if any; error out if there's no
1707         command to relaunch.
1708
1709 2019-07-03  Pedro Alves  <palves@redhat.com>
1710
1711         * NEWS (New commands): Mention "maint set/show test-settings"
1712         instead of "maint test-settings".
1713         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1714         (maintenance_test_settings_set_list): Rename to ...
1715         (maintenance_set_test_settings_list): ... this.
1716         (maintenance_test_settings_show_list): Rename to  ...
1717         (maintenance_show_test_settings_list): ... this.
1718         (maintenance_test_settings_cmd): Delete.
1719         (maintenance_test_settings_set_cmd): ...
1720         (maintenance_set_test_settings_cmd): ... this.
1721         (maintenance_test_settings_show_cmd): ...
1722         (maintenance_show_test_settings_cmd): ... this.
1723         (maintenance_test_settings_show_value_cmd):
1724         (maintenance_show_test_settings_value_cmd): ... this.
1725         (_initialize_maint_test_settings): No longer install the "maint
1726         test-settings" prefix command.  Rename "maint test-settings set"
1727         to "maint set test-settings", and "maint test-settings show" to
1728         "maint show test-settings".  Adjust all subcommands.
1729
1730 2019-07-03  Pedro Alves  <palves@redhat.com>
1731
1732         * maint-test-settings.c: Fix file's intro comment.  Replace all
1733         references to "test-options" with references to "test-settings",
1734         in comments.
1735
1736 2019-07-03  Pedro Alves  <palves@redhat.com>
1737
1738         * maint-test-settings.c (maintenance_test_settings_xxx)
1739         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1740         New.
1741         (maintenance_test_settings_enums): Use them.
1742         (maintenance_test_settings_enum): Default to
1743         maintenance_test_settings_xxx.
1744         (_initialize_maint_test_settings): Initialize
1745         MAINTENANCE_TEST_SETTINGS_FILENAME.
1746
1747 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1748
1749         * breakpoint.h (remove_breakpoints_inf): Change return type to
1750         void, move function documentation here.
1751         * breakpoint.c (remove_breakpoints_inf): Change return type to
1752         void, move function documentation to header.
1753
1754 2019-07-02  Pedro Alves  <palves@redhat.com>
1755
1756         * NEWS (Completion improvements): Mention "info threads".
1757         * thread.c (struct info_threads_opts, info_threads_option_defs)
1758         (make_info_threads_options_def_group): New.
1759         (info_threads_command): Use gdb::option::process_options.
1760         (info_threads_command_completer): New.
1761         (_initialize_thread): Use gdb::option::build_help to build the
1762         help text for "info threads".
1763
1764 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1765
1766         * defs.h (generic_load): Move from here...
1767         * symfile.h (generic_load): ... to here.  Rename name parameter
1768         to args.
1769         * symfile.c (generic_load): Add comment.
1770
1771 2019-07-01  Tom Tromey  <tromey@adacore.com>
1772
1773         * dwarf2read.c
1774         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1775         declaration of without_params.  Fix formatting.
1776
1777 2019-07-01  Tom Tromey  <tromey@adacore.com>
1778
1779         * ada-exp.y (find_primitive_type): Update.
1780         * ada-lang.h (ada_lookup_symbol): Update.
1781         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1782         parameter.
1783         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1784
1785 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1786
1787         PR breakpoints/24541
1788         * gdbarch.c: Regenerate.
1789         * gdbarch.h: Regenerate.
1790         * gdbarch.sh: Add 'stap_adjust_register'.
1791         * i386-tdep.c: Include '<unordered_set>'.
1792         (i386_stap_adjust_register): New function.
1793         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1794         * stap-probe.c (stap_parse_register_operand): Call
1795         'gdbarch_stap_adjust_register'.
1796
1797 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1798
1799         PR python/24742
1800         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1801         * python/python.c (do_start_initialization): Use 'xmalloc'
1802         instead of 'PyMem_Malloc'.
1803
1804 2019-06-28  Tom Tromey  <tromey@adacore.com>
1805
1806         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1807         for Ada.
1808
1809 2019-06-27  Tom Tromey  <tromey@adacore.com>
1810
1811         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1812         objfile_key.
1813         (arm_find_mapping_symbol, arm_record_special_symbol)
1814         (_initialize_arm_tdep): Update.
1815         (arm_objfile_data_free): Remove.
1816
1817 2019-06-27  Tom Tromey  <tromey@adacore.com>
1818
1819         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1820         to cp_print_static_field.
1821
1822 2019-06-26  Tom Tromey  <tromey@adacore.com>
1823
1824         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1825         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1826         declare.
1827
1828 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1829
1830         * features/aarch64-core.c (create_feature_aarch64_core):
1831         Regenerate.
1832         * features/aarch64-core.xml: Add cpsr flags.
1833
1834 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1835
1836         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1837         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1838
1839 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1840
1841         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1842         field.
1843         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1844         use.
1845         (arm_record_special_symbol): Don't insert new symbol in sorted
1846         position, push it at the end.
1847
1848 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1849
1850         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1851         (arm_mapping_symbol_s): Remove.
1852         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1853         (arm_mapping_symbol_vec): New typedef.
1854         (struct arm_per_objfile): Add constructor.
1855         <section_maps>: Change type to
1856         std::unique_ptr<arm_mapping_symbol_vec[]>.
1857         (arm_compare_mapping_symbols): Remove.
1858         (arm_find_mapping_symbol): Adjust to section_maps type change.
1859         (arm_objfile_data_free): Call delete on arm_per_objfile.
1860         (arm_record_special_symbol): Adjust to section_maps type change.
1861         Allocate arm_per_objfile with new.
1862
1863 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1864
1865         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1866         with the command prefix.
1867
1868 2019-06-25  Tom Tromey  <tom@tromey.com>
1869
1870         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1871         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1872
1873 2019-06-25  Tom Tromey  <tom@tromey.com>
1874
1875         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1876         type.
1877         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1878         protected.
1879
1880 2019-06-25  Tom Tromey  <tom@tromey.com>
1881
1882         * tui/tui-winsource.c
1883         (tui_source_window_base::set_is_exec_point_at): Add check against
1884         LOA_ADDRESS.
1885
1886 2019-06-25  Tom Tromey  <tom@tromey.com>
1887
1888         * tui/tui-source.c (tui_set_source_content): Don't check before
1889         xfree.
1890         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1891
1892 2019-06-25  Tom Tromey  <tom@tromey.com>
1893
1894         * tui/tui-winsource.h (tui_update_source_window_as_is)
1895         (tui_alloc_source_buffer, tui_line_is_displayed)
1896         (tui_addr_is_displayed): Change type of win_info.
1897         * tui/tui-winsource.c (tui_update_source_window_as_is)
1898         (tui_clear_source_content, tui_show_source_line)
1899         (tui_show_source_content, tui_source_window_base::refill)
1900         (tui_source_window_base::set_is_exec_point_at)
1901         (tui_source_window_base::set_is_exec_point_at)
1902         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1903         (tui_alloc_source_buffer, tui_line_is_displayed)
1904         (tui_addr_is_displayed): Change type of win_info.  Update.
1905         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1906         (tui_source_window_base::do_make_visible_with_new_height):
1907         Update.
1908         * tui/tui-source.c (tui_set_source_content)
1909         (tui_set_source_content_nil)
1910         (tui_source_window::do_scroll_vertical): Update.
1911         * tui/tui-layout.c (show_layout): Update.
1912         * tui/tui-disasm.c (tui_set_disassem_content)
1913         (tui_disasm_window::do_scroll_vertical): Update.
1914         * tui/tui-data.h (tui_win_content): Remove.
1915         (struct tui_gen_win_info) <content, content_size>: Remove.
1916         (struct tui_source_element): Add initializers and destructor.
1917         (union tui_which_element, struct tui_win_element): Remove.
1918         (struct tui_source_window_base) <content>: New field.
1919         (struct tui_data_window): Remove destructor.
1920         (tui_alloc_content, tui_free_win_content)
1921         (tui_free_all_source_wins_content): Don't declare.
1922         * tui/tui-data.c (tui_initialize_static_data): Update.
1923         (init_content_element, tui_alloc_content): Remove.
1924         (~tui_gen_win_info): Update.
1925         (~tui_data_window, tui_free_all_source_wins_content)
1926         (tui_free_win_content, free_content, free_content_elements):
1927         Remove.
1928
1929 2019-06-25  Tom Tromey  <tom@tromey.com>
1930
1931         * tui/tui-winsource.h (tui_clear_source_content)
1932         (tui_erase_source_content, tui_show_source_content): Change type
1933         of win_info.
1934         * tui/tui-winsource.c (tui_clear_source_content)
1935         (tui_erase_source_content, tui_show_source_content): Change type
1936         of win_info.
1937         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1938         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1939         win_info.
1940         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1941         win_info.
1942         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1943
1944 2019-06-25  Tom Tromey  <tom@tromey.com>
1945
1946         * tui/tui-winsource.c (tui_clear_source_content)
1947         (tui_source_window_base::set_is_exec_point_at): Update.
1948         * tui/tui-source.c (tui_set_source_content_nil): Update.
1949         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1950         a bool.
1951         * tui/tui-data.c (init_content_element): Update.
1952
1953 2019-06-25  Tom Tromey  <tom@tromey.com>
1954
1955         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1956         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1957         * tui/tui-layout.c (init_and_make_win): Update.
1958         * tui/tui.h (enum tui_win_type): Update.
1959         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1960         tui_win_is_auxillary.
1961         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1962         tui_win_is_auxillary.
1963
1964 2019-06-25  Tom Tromey  <tom@tromey.com>
1965
1966         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1967         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1968         (tui_delete_data_content_windows, tui_display_all_data)
1969         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1970         Update.
1971         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1972         * tui/tui-regs.c (tui_last_regs_line_no)
1973         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1974         (tui_show_registers): Update.
1975         (tui_show_register_group): Return void.  Update.
1976         (tui_display_registers_from, tui_display_reg_element_at_line)
1977         (tui_display_registers_from_line, tui_check_register_values):
1978         Update.
1979         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1980         member.
1981         (struct tui_data_window) <regs_content>: Now a std::vector.
1982         <regs_content_count>: Remove.
1983         (tui_add_content_elements, tui_free_data_content): Don't declare.
1984         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1985         (init_content_element): Remove DATA_WIN case.  Add assert.
1986         (tui_add_content_elements): Remove.
1987         (tui_data_window): Update.
1988         (tui_free_data_content): Remove.
1989         (free_content_elements): Remove DATA_WIN case.
1990
1991 2019-06-25  Tom Tromey  <tom@tromey.com>
1992
1993         * tui/tui-data.c (tui_data_item_window): Update.
1994         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1995         * tui/tui-windata.c (tui_display_all_data)
1996         (tui_display_data_from_line): Update.
1997         (tui_check_data_values): Remove.
1998         * tui/tui-regs.c (tui_show_register_group)
1999         (tui_display_reg_element_at_line): Update.
2000         * tui/tui-hooks.c (tui_register_changed)
2001         (tui_refresh_frame_and_register_information): Call
2002         tui_check_register_values.
2003         * tui/tui-data.h (struct tui_data_window) <data_content,
2004         data_content_count, data_type>: Remove.
2005         (enum tui_data_type): Remove.
2006
2007         * tui/tui-data.c (tui_data_window::clear_detail)
2008         (~tui_data_window): Update.
2009
2010 2019-06-25  Tom Tromey  <tom@tromey.com>
2011
2012         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
2013         declare.
2014         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
2015         Rename from tui_first_data_item_displayed.  Update.
2016         (tui_data_window::refresh_all)
2017         (tui_data_window::do_scroll_vertical): Update.
2018         * tui/tui-data.h (struct tui_data_window)
2019         <first_data_item_displayed>: Declare new method.
2020
2021 2019-06-25  Tom Tromey  <tom@tromey.com>
2022
2023         * tui/tui-data.h (tui_init_generic_part): Don't declare.
2024         * tui/tui-data.c (tui_init_generic_part): Remove, moving
2025         contents...
2026         (tui_initialize_static_data): ...here.
2027
2028 2019-06-25  Tom Tromey  <tom@tromey.com>
2029
2030         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2031         (tui_display_registers_from, tui_check_register_values): Update.
2032         (tui_display_register): Remove win_info parameter; update.
2033         (tui_get_register): Change type of parameters.
2034         * tui/tui-data.h (struct tui_data_element): Remove.
2035         (union tui_which_element) <data>: Remove.
2036         <data_window>: Change type.
2037         (struct tui_data_item_window): New.
2038         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
2039         case.  Add assert.
2040         (~tui_data_item_window): New destructor.
2041         (free_content_elements): Remove DATA_ITEM_WIN case.
2042
2043 2019-06-25  Tom Tromey  <tom@tromey.com>
2044
2045         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
2046         Remove.
2047
2048 2019-06-25  Tom Tromey  <tom@tromey.com>
2049
2050         * tui/tui-data.h (struct tui_command_element): Remove.
2051         (union tui_which_element) <command>: Remove.
2052         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
2053         assert.
2054         (free_content_elements): Remove CMD_WIN case.
2055
2056 2019-06-25  Tom Tromey  <tom@tromey.com>
2057
2058         * tui/tui-layout.c (tui_set_layout): Update.
2059         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
2060         * tui/tui-data.c (layout_def): Update.
2061
2062 2019-06-25  Tom Tromey  <tom@tromey.com>
2063
2064         * tui/tui-wingeneral.c (tui_refresh_all): Update.
2065         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2066         (tui_source_window_base::set_new_height): Update.
2067         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
2068         Update.
2069         (tui_set_locator_fullname, tui_set_locator_info)
2070         (tui_show_frame_info): Update.
2071         * tui/tui-source.c (tui_set_source_content)
2072         (tui_source_is_displayed): Update.
2073         * tui/tui-layout.c (show_source_disasm_command, show_data)
2074         (show_source_or_disasm_and_command): Update.
2075         * tui/tui-disasm.c (tui_set_disassem_content)
2076         (tui_get_begin_asm_address): Update.
2077         * tui/tui-data.h (struct tui_locator_element): Remove.
2078         (union tui_which_element) <locator>: Remove.
2079         (struct tui_locator_window): New.
2080         (tui_locator_win_info_ptr): Change return type.
2081         * tui/tui-data.c (_locator): Change type.
2082         (tui_locator_win_info_ptr): Change return type.
2083         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
2084         (tui_alloc_content): Add assert.
2085
2086 2019-06-25  Tom Tromey  <tom@tromey.com>
2087
2088         * tui/tui-winsource.c
2089         (tui_exec_info_window::maybe_allocate_content): New method.
2090         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
2091         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
2092         (make_source_or_disasm_window): Add cast.
2093         * tui/tui-data.h (union tui_which_element) <simple_string>:
2094         Remove.
2095         (struct tui_source_info): New.
2096         (struct tui_source_window_base) <execution_info>: Change type.
2097         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
2098         case, and add assert.
2099         (tui_alloc_content): Add assert.
2100
2101 2019-06-25  Tom Tromey  <tom@tromey.com>
2102
2103         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
2104         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
2105         * tui/tui-data.c (tui_alloc_win_info): Remove.
2106
2107 2019-06-25  Tom Tromey  <tom@tromey.com>
2108
2109         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
2110         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
2111         can_highlight.
2112
2113 2019-06-25  Tom Tromey  <tom@tromey.com>
2114
2115         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
2116         make_visible_with_new_height method.
2117         (tui_win_info::make_visible_with_new_height): New method.
2118         (tui_source_window_base::do_make_visible_with_new_height)
2119         (tui_data_window::do_make_visible_with_new_height)
2120         (tui_cmd_window::do_make_visible_with_new_height): New methods.
2121         (make_visible_with_new_height): Remove.
2122         (tui_resize_all, tui_adjust_win_heights): Use
2123         make_visible_with_new_height method.
2124         * tui/tui-data.h (struct tui_win_info)
2125         <do_make_visible_with_new_height, make_visible_with_new_height>:
2126         New methods.
2127         (struct tui_source_window_base, struct tui_data_window)
2128         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
2129         methods.
2130
2131 2019-06-25  Tom Tromey  <tom@tromey.com>
2132
2133         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
2134         method.
2135         (update_tab_width): Call update_tab_width method.
2136         * tui/tui-data.h (struct tui_win_info)
2137         (struct tui_source_window_base) <update_tab_width>: New methods.
2138
2139 2019-06-25  Tom Tromey  <tom@tromey.com>
2140
2141         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
2142         parameter.
2143         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
2144         parameter.
2145         (tui_gen_win_info::make_visible): Update.
2146         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
2147         parameter.
2148         * tui/tui-data.h (enum tui_box): New enum.
2149         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
2150
2151 2019-06-25  Tom Tromey  <tom@tromey.com>
2152
2153         * tui/tui-layout.c (make_source_or_disasm_window): Always use
2154         init_and_make_win for EXEC_INFO_WIN.
2155         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
2156         longer inline.
2157         (struct tui_win_info) <~tui_win_info>: Inline.
2158         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2159         Don't declare.
2160         * tui/tui-data.c (source_win, disasm_win): Remove globals.
2161         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2162         Remove.
2163         (tui_initialize_static_data): Update.
2164         (~tui_gen_win_info): Handle more cleanup here.
2165         (~tui_source_window_base): Delete "execution_info".
2166         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
2167
2168 2019-06-25  Tom Tromey  <tom@tromey.com>
2169
2170         * tui/tui-layout.c (make_command_window): Don't set
2171         can_highlight.
2172         (show_source_disasm_command): Call the reset method.
2173         (show_data): Don't set can_highlight.  Call the reset method.
2174         (tui_gen_win_info::reset): Rename from init_gen_win_info
2175         (init_and_make_win): Simplify.  Return tui_gen_win_info.
2176         (show_source_or_disasm_and_command): Call the reset method.
2177         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2178         (struct tui_cmd_window): Set can_highlight.
2179
2180 2019-06-25  Tom Tromey  <tom@tromey.com>
2181
2182         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2183         from make_visible.
2184         (tui_make_visible, tui_make_invisible): Rewrite.
2185         (tui_win_info::make_visible): Remove.
2186         (tui_source_window_base::make_visible): Update.
2187         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2188         method.  Moved from...
2189         (struct tui_win_info) <make_visible>: ...here.
2190
2191 2019-06-25  Tom Tromey  <tom@tromey.com>
2192
2193         * tui/tui-winsource.c
2194         (tui_source_window_base::do_scroll_horizontal): Remove direction
2195         parameter.
2196         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2197         direction parameter.
2198         * tui/tui-win.c (tui_win_info::forward_scroll)
2199         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2200         (tui_win_info::right_scroll): Update.
2201         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2202         direction parameter.
2203         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2204         direction parameter.
2205         * tui/tui-data.h (enum tui_scroll_direction): Remove.
2206         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2207         Remove direction parameter.
2208         (struct tui_source_window_base, struct tui_source_window)
2209         (struct tui_disasm_window, struct tui_data_window)
2210         (struct tui_cmd_window): Update.
2211
2212 2019-06-25  Tom Tromey  <tom@tromey.com>
2213
2214         * tui/tui-winsource.h (tui_set_exec_info_content)
2215         (tui_show_exec_info_content, tui_erase_exec_info_content)
2216         (tui_clear_exec_info_content, tui_update_exec_info): Change
2217         argument to tui_source_window_base.
2218         * tui/tui-winsource.c (tui_set_exec_info_content)
2219         (tui_show_exec_info_content, tui_erase_exec_info_content)
2220         (tui_clear_exec_info_content, tui_update_exec_info): Change
2221         argument to tui_source_window_base.
2222
2223 2019-06-25  Tom Tromey  <tom@tromey.com>
2224
2225         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2226         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2227
2228 2019-06-25  Tom Tromey  <tom@tromey.com>
2229
2230         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2231         check.
2232
2233 2019-06-25  Tom Tromey  <tom@tromey.com>
2234
2235         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2236         type to void.
2237         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2238         type to void.
2239         * tui/tui-source.c (tui_set_source_content): Update.
2240         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2241
2242 2019-06-25  Tom Tromey  <tom@tromey.com>
2243
2244         * tui/tui-win.c (window_name_completer, tui_set_focus)
2245         (tui_all_windows_info): Use name method.
2246         * tui/tui-data.h (struct tui_gen_win_info)
2247         (struct tui_source_window, struct tui_disasm_window)
2248         (struct tui_data_window, struct tui_cmd_window) <name>: New
2249         method.
2250         (tui_win_name): Don't declare.
2251         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2252         (tui_win_name): Remove.
2253
2254 2019-06-25  Tom Tromey  <tom@tromey.com>
2255
2256         * tui/tui-winsource.h (tui_update_source_window)
2257         (tui_update_source_window_as_is): Change parameter type.
2258         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2259         to be a tui_source_window_base.
2260         (tui_update_source_window_as_is): Likewise.
2261         * tui/tui-win.c (make_visible_with_new_height): Update.
2262
2263 2019-06-25  Tom Tromey  <tom@tromey.com>
2264
2265         * tui/tui-winsource.c (tui_erase_source_content)
2266         (tui_show_source_content, tui_show_exec_info_content)
2267         (tui_erase_exec_info_content): Use refresh_window method.
2268         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2269         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2270         from tui_refresh_win.
2271         (tui_data_window::refresh_window): New method.
2272         (tui_win_info::refresh, tui_source_window_base::refresh)
2273         (tui_refresh_all): Use refresh_window method.
2274         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2275         method.
2276         * tui/tui-regs.c (tui_display_register): Call refresh_window
2277         method.
2278         * tui/tui-layout.c (show_source_disasm_command)
2279         (show_source_or_disasm_and_command): Call refresh_window method.
2280         * tui/tui-data.h (struct tui_gen_win_info)
2281         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2282         New method.
2283
2284 2019-06-25  Tom Tromey  <tom@tromey.com>
2285
2286         * tui/tui.c (tui_rl_other_window, tui_enable)
2287         (tui_is_window_visible, tui_get_command_dimension): Update.
2288         * tui/tui-winsource.c (tui_update_source_window_as_is)
2289         (tui_clear_source_content, tui_erase_source_content)
2290         (tui_show_source_line, tui_source_window_base::refill)
2291         (tui_source_window_base::do_scroll_horizontal)
2292         (tui_source_window_base::set_is_exec_point_at)
2293         (tui_update_breakpoint_info, tui_set_exec_info_content)
2294         (tui_alloc_source_buffer, tui_line_is_displayed)
2295         (tui_addr_is_displayed): Update.
2296         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2297         (tui_check_and_display_highlight_if_needed)
2298         (tui_win_info::make_visible, tui_win_info::refresh)
2299         (tui_refresh_all): Update.
2300         * tui/tui-windata.c (tui_first_data_item_displayed)
2301         (tui_delete_data_content_windows, tui_erase_data_content)
2302         (tui_display_all_data, tui_data_window::refresh_all)
2303         (tui_check_data_values): Update.
2304         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2305         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2306         (tui_win_info::backward_scroll, tui_refresh_all_win)
2307         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2308         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2309         (tui_source_window_base::set_new_height)
2310         (tui_data_window::set_new_height)
2311         (make_invisible_and_set_new_height)
2312         (make_visible_with_new_height, new_height_ok)
2313         (parse_scrolling_args): Update.
2314         * tui/tui-stack.c (tui_show_frame_info): Update.
2315         * tui/tui-source.c (tui_set_source_content)
2316         (tui_set_source_content_nil, tui_source_is_displayed)
2317         (tui_source_window::do_scroll_vertical): Update.
2318         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2319         (tui_display_registers_from, tui_display_reg_element_at_line)
2320         (tui_check_register_values, tui_reg_command): Update.
2321         * tui/tui-layout.c (tui_default_win_height)
2322         (show_source_disasm_command, show_data, init_and_make_win)
2323         (show_source_or_disasm_and_command): Update.
2324         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2325         (tui_redisplay_readline, tui_mld_flush)
2326         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2327         (tui_getc): Update.
2328         * tui/tui-disasm.c (tui_set_disassem_content)
2329         (tui_disasm_window::do_scroll_vertical): Update.
2330         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2331         Now virtual.
2332         (struct tui_win_info): Derive from tui_gen_win_info.
2333         <~tui_win_info>: Mark as override.
2334         <generic>: Remove member.
2335         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2336         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2337         (~tui_data_window, ~tui_win_info)
2338         (tui_free_all_source_wins_content): Update.
2339         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2340
2341 2019-06-25  Tom Tromey  <tom@tromey.com>
2342
2343         * tui/tui-layout.c (init_and_make_win): Use new.
2344         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2345         destructor, initializers.
2346         (tui_alloc_generic_win_info): Don't declare.
2347         * tui/tui-data.c (_locator): Add argument to constructor.
2348         (source_win, disasm_win): New globals.
2349         (exec_info): Remove.
2350         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2351         Update.
2352         (tui_alloc_generic_win_info): Remove.
2353         (init_content_element): Use new.
2354         (tui_win_info::tui_win_info): Update.
2355         (free_content_elements) <case DATA_WIN>: Use delete.
2356
2357 2019-06-25  Tom Tromey  <tom@tromey.com>
2358
2359         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2360         * tui/tui-windata.c (tui_first_data_item_displayed)
2361         (tui_delete_data_content_windows): Update.
2362         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2363         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2364         (tui_display_registers_from, tui_check_register_values): Update.
2365         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2366         pointer.
2367         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2368         window.
2369         (tui_free_data_content): Update.
2370         (free_content_elements) <case DATA_WIN>: Free the window.
2371
2372 2019-06-25  Tom Tromey  <tom@tromey.com>
2373
2374         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2375         Update.
2376         * tui/tui-layout.c (make_command_window)
2377         (show_source_disasm_command, show_data, init_and_make_win)
2378         (show_source_or_disasm_and_command): Update.
2379         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2380         method.
2381         <can_highight, is_highlighted>: Now bool.
2382         (tui_set_win_highlight): Don't declare.
2383         * tui/tui-data.c (tui_set_win_highlight): Remove.
2384
2385 2019-06-25  Tom Tromey  <tom@tromey.com>
2386
2387         * tui/tui-wingeneral.c (make_visible): Remove check of window
2388         type.
2389
2390 2019-06-25  Tom Tromey  <tom@tromey.com>
2391
2392         * tui/tui-win.c (tui_win_info::max_height)
2393         (tui_cmd_window::max_height): New methods.
2394         (new_height_ok): Call max_height.
2395         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2396         <max_height>: New method.
2397
2398 2019-06-25  Tom Tromey  <tom@tromey.com>
2399
2400         * tui/tui-win.c (tui_source_window_base::set_new_height)
2401         (tui_data_window::set_new_height): New methods.
2402         (make_invisible_and_set_new_height): Call set_new_height method.
2403         * tui/tui-data.h (struct tui_win_info)
2404         (struct tui_source_window_base, struct tui_data_window)
2405         <set_new_height>: New method.
2406
2407 2019-06-25  Tom Tromey  <tom@tromey.com>
2408
2409         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2410         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2411         tui_refresh_data_win.
2412         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2413         method.
2414         (tui_refresh_all_win): Call the refresh_all method.
2415         (tui_set_focus): Likewise.
2416         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2417         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2418         Likewise.
2419
2420 2019-06-25  Tom Tromey  <tom@tromey.com>
2421
2422         * tui/tui-winsource.h (tui_refill_source_window)
2423         (tui_set_is_exec_point_at): Don't declare.
2424         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2425         (tui_source_window_base::refill): Rename from
2426         tui_refill_source_window.
2427         (tui_source_window_base::do_scroll_horizontal): Update.
2428         (tui_source_window_base::set_is_exec_point_at): Rename from
2429         tui_set_is_exec_point_at.
2430         (tui_update_all_breakpoint_info): Update.
2431         * tui/tui-stack.c (tui_show_frame_info): Update.
2432         * tui/tui-layout.c (show_data): Add cast.
2433         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2434         * tui/tui-data.h (struct tui_source_window_base) <refill,
2435         set_is_exec_point_at>: New methods.
2436         (tui_source_windows, tui_add_to_source_windows): Update types.
2437         (tui_add_to_source_windows): Remove redundant declaration.
2438         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2439         (tui_source_windows): Change return type.
2440         (tui_clear_source_windows_detail): Update.
2441         (tui_add_to_source_windows): Change type of parameter.
2442         (tui_free_all_source_wins_content): Update.
2443
2444 2019-06-25  Tom Tromey  <tom@tromey.com>
2445
2446         * tui/tui-wingeneral.c (tui_win_info::refresh)
2447         (tui_source_window_base::refresh): New methods.
2448         (tui_refresh_all): Call the refresh method.
2449         * tui/tui-data.h (struct tui_win_info)
2450         (struct tui_source_window_base) <refresh>: New method.
2451
2452 2019-06-25  Tom Tromey  <tom@tromey.com>
2453
2454         * tui/tui.h (tui_is_window_visible): Return bool.
2455         * tui/tui.c (tui_is_window_visible): Return bool.
2456         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2457         (tui_make_visible, tui_make_invisible)
2458         (tui_win_info::make_visible)
2459         (tui_source_window_base::make_visible, make_all_visible)
2460         (tui_make_all_visible, tui_make_all_invisible): Update.
2461         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2462         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2463         bool.
2464         (struct tui_win_info, struct tui_source_window_base)
2465         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2466         * tui/tui-data.c (tui_init_generic_part): Update.
2467
2468 2019-06-25  Tom Tromey  <tom@tromey.com>
2469
2470         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2471         (tui_source_window_base::make_visible): New methods.
2472         (make_all_visible): Make method call.
2473         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2474         (struct tui_source_window_base, struct tui_cmd_window): Override
2475         make_visible.
2476         (tui_win_is_source_type): Don't declare.
2477         * tui/tui-data.c (tui_win_is_source_type): Remove.
2478
2479 2019-06-25  Tom Tromey  <tom@tromey.com>
2480
2481         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2482         NULL check.
2483
2484 2019-06-25  Tom Tromey  <tom@tromey.com>
2485
2486         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2487         Inline constructor.  Add initializers for members.
2488         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2489         constructors; now inline in class.
2490
2491 2019-06-25  Tom Tromey  <tom@tromey.com>
2492
2493         * tui/tui-regs.c (tui_show_registers): Update.
2494         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2495         bool.
2496         * tui/tui-data.c (tui_data_window::clear_detail)
2497         (tui_data_window): Update.
2498
2499 2019-06-25  Tom Tromey  <tom@tromey.com>
2500
2501         * tui/tui-windata.c (tui_display_all_data)
2502         (tui_display_data_from_line, tui_display_data_from)
2503         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2504         Update.
2505         * tui/tui-regs.c (tui_last_regs_line_no)
2506         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2507         (tui_show_registers, tui_show_register_group)
2508         (tui_display_registers_from, tui_display_reg_element_at_line)
2509         (tui_display_registers_from_line, tui_check_register_values)
2510         (tui_reg_next, tui_reg_prev): Update.
2511         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2512         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2513         tui_data_window.
2514         (struct tui_win_info) <detail>: Remove.  Add new fields from
2515         tui_data_info.
2516         (TUI_DATA_WIN): Add cast.
2517         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2518         (~tui_data_window): Simplify.
2519
2520 2019-06-25  Tom Tromey  <tom@tromey.com>
2521
2522         * tui/tui-layout.c (show_source_disasm_command)
2523         (show_source_or_disasm_and_command): Update.
2524         * tui/tui-io.c (update_cmdwin_start_line)
2525         (tui_redisplay_readline): Update.
2526         * tui/tui-data.h (struct tui_command_info): Remove.
2527         (struct tui_win_info) <detail>: Remove command_info member.
2528         (struct tui_data_window) <start_line>: New member, from
2529         tui_command_info.
2530         (TUI_CMD_WIN): Add casts.
2531
2532 2019-06-25  Tom Tromey  <tom@tromey.com>
2533
2534         * tui/tui-winsource.c (tui_update_source_window)
2535         (tui_refill_source_window)
2536         (tui_source_window_base::do_scroll_horizontal)
2537         (tui_update_breakpoint_info, tui_set_exec_info_content)
2538         (tui_show_exec_info_content, tui_erase_exec_info_content)
2539         (tui_clear_exec_info_content): Update.
2540         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2541         Update.
2542         * tui/tui-win.c (make_invisible_and_set_new_height)
2543         (make_visible_with_new_height): Update.
2544         * tui/tui-source.c (tui_set_source_content)
2545         (tui_show_symtab_source): Update.
2546         * tui/tui-layout.c (extract_display_start_addr)
2547         (show_source_disasm_command, show_data)
2548         (make_source_or_disasm_window)
2549         (show_source_or_disasm_and_command): Update.
2550         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2551         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2552         "gdbarch".
2553         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2554         to tui_source_window_base.
2555         (struct tui_win_info) <detail>: Remove source_info member.
2556         (struct tui_source_window_base) <has_locator>: Inline.
2557         Move contents from tui_source_info; rename has_locator member to
2558         m_has_locator.
2559         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2560         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2561         header file.
2562         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2563         Simplify.
2564         (tui_free_all_source_wins_content): Cast to
2565         tui_source_window_base.
2566
2567 2019-06-25  Tom Tromey  <tom@tromey.com>
2568
2569         * tui/tui-win.c (make_invisible_and_set_new_height)
2570         (make_visible_with_new_height): Call has_locator method.
2571         * tui/tui-layout.c (show_source_disasm_command, show_data)
2572         (show_source_or_disasm_and_command): Update for bool change.
2573         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2574         (tui_win_info) <has_locator>: New method.
2575         (struct tui_source_window_base) <has_locator>: New method.
2576         (tui_win_has_locator): Don't declare.
2577         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2578         from tui_win_has_locator.
2579         (tui_source_window_base): Use false, not FALSE.
2580
2581 2019-06-25  Tom Tromey  <tom@tromey.com>
2582
2583         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2584         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2585         clear_detail method directly.
2586         (tui_clear_win_detail): Remove.
2587
2588 2019-06-25  Tom Tromey  <tom@tromey.com>
2589
2590         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2591         "this", not TUI_DISASM_WIN.
2592
2593 2019-06-25  Tom Tromey  <tom@tromey.com>
2594
2595         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2596         declare.
2597         * tui/tui-winsource.c
2598         (tui_source_window_base::do_scroll_horizontal): Rename from
2599         tui_horizontal_source_scroll.
2600         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2601         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2602         from tui_vertical_data_scroll.
2603         * tui/tui-win.h (tui_scroll): Don't declare.
2604         * tui/tui-win.c (tui_win_info::forward_scroll)
2605         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2606         (tui_win_info::right_scroll): Rename and update.
2607         (tui_scroll_forward_command, tui_scroll_backward_command)
2608         (tui_scroll_left_command, tui_scroll_right_command): Update.
2609         (tui_scroll): Remove.
2610         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2611         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2612         from tui_vertical_source_scroll.
2613         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2614         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2615         from tui_vertical_disassem_scroll.
2616         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2617         do_scroll_horizontal>: New methods.
2618         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2619         Likewise.
2620         (struct tui_source_window_base): Add do_scroll_horizontal.
2621         (struct tui_source_window, struct tui_disasm_window): Add
2622         do_scroll_vertical.
2623         (struct tui_data_window, struct tui_cmd_window): Add
2624         do_scroll_horizontal and do_scroll_vertical.
2625         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2626
2627 2019-06-25  Tom Tromey  <tom@tromey.com>
2628
2629         * tui/tui-data.h (struct tui_source_window_base): New struct.
2630         (struct tui_source_window): Derive from tui_source_window_base.
2631         (struct tui_disasm_window): New struct.
2632         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2633         from tui_source_window::clear_detail.
2634         (tui_source_window_base): Rename from tui_source_window.
2635         (~tui_source_window_base): Rename from ~tui_source_window.
2636         (tui_alloc_win_info): Create a tui_disasm_window.
2637
2638 2019-06-25  Tom Tromey  <tom@tromey.com>
2639
2640         * tui/tui-data.h (struct tui_source_window)
2641         (struct tui_data_window): Declare destructors.
2642         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2643         destructors.
2644         (tui_win_info): Simplify.
2645
2646 2019-06-25  Tom Tromey  <tom@tromey.com>
2647
2648         * tui/tui-winsource.c (tui_display_main)
2649         (tui_update_source_windows_with_addr)
2650         (tui_update_all_breakpoint_info): Update.
2651         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2652         (new_height_ok, parse_scrolling_args): Update.
2653         * tui/tui-stack.c (tui_show_frame_info): Update.
2654         * tui/tui-data.h (struct tui_list): Remove.
2655         (tui_source_windows): Return a reference to a std::vector.
2656         * tui/tui-data.c (source_windows): Now a std::vector.
2657         (tui_source_windows): Change return type.
2658         (tui_clear_source_windows): Rewrite.
2659         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2660         (tui_free_all_source_wins_content): Rewrite.
2661
2662 2019-06-25  Tom Tromey  <tom@tromey.com>
2663
2664         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2665         (struct tui_data_window, struct tui_cmd_window): Declare
2666         clear_detail method.
2667         * tui/tui-data.c (tui_source_window::clear_detail)
2668         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2669         methods.
2670         (tui_clear_win_detail): Simplify.
2671
2672 2019-06-25  Tom Tromey  <tom@tromey.com>
2673
2674         * tui/tui-layout.c (make_source_window, make_disasm_window)
2675         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2676         Return the new window.
2677         (show_source_disasm_command, show_data)
2678         (show_source_or_disasm_and_command): Update.
2679
2680 2019-06-25  Tom Tromey  <tom@tromey.com>
2681
2682         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2683         parameter.  Return the new window.
2684         (show_source_disasm_command): Update and remove NULL check.
2685         (show_source_or_disasm_and_command): Update.
2686
2687 2019-06-25  Tom Tromey  <tom@tromey.com>
2688
2689         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2690
2691 2019-06-25  Tom Tromey  <tom@tromey.com>
2692
2693         * tui/tui-data.h (struct tui_win_info): Make constructor
2694         protected.  Make destructor virtual.  Add initializers.
2695         (tui_source_window, tui_data_window, tui_cmd_window): New
2696         classes.
2697         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2698         constructor.  Add "type" parameter.
2699         (tui_source_window, tui_data_window, tui_cmd_window): New
2700         constructors.
2701         (tui_alloc_win_info): Instantiate the appropriate subclass.
2702
2703 2019-06-25  Tom Tromey  <tom@tromey.com>
2704
2705         * tui/tui-win.c (tui_resize_all): Use delete.
2706         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2707         destructor.
2708         (tui_free_window): Don't declare.
2709         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2710         Update.
2711
2712 2019-06-25  Tom Tromey  <tom@tromey.com>
2713
2714         * tui/tui-data.h (struct tui_win_info): Add constructor.
2715         * tui/tui-data.c (tui_alloc_win_info): Use new.
2716         (tui_free_window): Use delete.
2717
2718 2019-06-22  Tom Tromey  <tom@tromey.com>
2719
2720         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2721         declare.
2722         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2723
2724 2019-06-22  Tom Tromey  <tom@tromey.com>
2725
2726         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2727         declare.
2728         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2729
2730 2019-06-22  Tom de Vries  <tdevries@suse.de>
2731
2732         * dwarf2read.c (create_addrmap_from_aranges)
2733         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2734         instead of '%zu'.
2735
2736 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2737
2738         * dwarf2read.h (dwarf2_section_info_def): Remove.
2739         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2740         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2741         std::vector<dwarf2_section_info>.
2742         (struct dwo_file) <~dwo_file>: Remove.
2743         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2744         types field.
2745         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2746         (dwarf2_read_debug_names): Likewise.
2747         (create_debug_types_hash_table): Change parameter type to
2748         array_view, adjust code accordingly.
2749         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2750         (partial_die_info::fixup): Likewise.
2751         (determine_prefix): Likewise.
2752         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2753
2754 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2755
2756         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2757         gdb_bfd_ref_ptr.
2758         <~dwo_file>: Remove call to gdb_bfd_unref.
2759         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2760         gdb_bfd_ref_ptr::get.
2761
2762 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2763
2764         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2765         type to htab_up.
2766         * dwarf2read.c (struct dwo_file): Initialize fields.
2767         <~dwo_file>: New.
2768         (free_dwo_file): Remove, move content to ~dwo_file.
2769         (struct dwo_file_deleter): Remove.
2770         (dwo_file_up>: Remove custom deleter.
2771         (free_dwo_files): Remove.
2772         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2773         dwo_files.
2774         (process_skeletonless_type_units): Call unique_ptr::get.
2775         (allocate_dwo_file_hash_table): Add deleter to created hash
2776         table.  Change return type to htab_up.
2777         (lookup_dwo_file_slot): Don't memset dwo_file, call
2778         unique_ptr::get.
2779         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2780         (create_dwo_unit_in_dwp_v2): Likewise.
2781         (open_and_init_dwo_file): Likewise.
2782         (free_dwo_file_from_slot): Remove.
2783
2784 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2785
2786         * dwarf2read.h (struct dwarf2_section_info) <readin,
2787         is_virtual>: Change type to bool.
2788         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2789         true instead of 1.
2790
2791 2019-06-19  Tom Tromey  <tom@tromey.com>
2792
2793         * tui/tui-data.h (tui_init_content_element): Don't declare.
2794
2795 2019-06-19  Tom Tromey  <tom@tromey.com>
2796
2797         * tui/tui-data.h (tui_init_win_info): Don't declare.
2798
2799 2019-06-19  Tom de Vries  <tdevries@suse.de>
2800
2801         * dwarf2read.h (abstract_to_concrete): Change type to
2802         std::unordered_map<sect_offset, std::vector<sect_offset>,
2803         gdb::hash_enum<sect_offset>>.
2804
2805 2019-06-19  Tom Tromey  <tromey@adacore.com>
2806
2807         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2808         EVAL_AVOID_SIDE_EFFECTS specially.
2809
2810 2019-06-19  Tom Tromey  <tromey@adacore.com>
2811
2812         * source-cache.c (highlighter): New global.
2813         (source_cache::get_source_lines): Create a highlighter on demand.
2814
2815 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2816
2817         * defs.h (deprecated_interactive_hook): Delete declaration.
2818         * interps.c (clear_interpreter_hooks): Remove use of
2819         deprecated_interactive_hook.
2820         * top.c (deprecated_interactive_hook): Delete definition.
2821         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2822
2823 2019-06-18  Tom de Vries  <tdevries@suse.de>
2824
2825         PR gdb/24515
2826         * dwarf2read.h (abstract_to_concrete): Change type from
2827         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2828         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2829         * dwarf2read.c (read_variable): Update.
2830         (dwarf2_fetch_die_loc_sect_off): Update.
2831
2832 2019-06-17  Tom de Vries  <tdevries@suse.de>
2833
2834         PR gdb/24617
2835         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2836         accessing parent[parent_len - 1].
2837
2838 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2839
2840         PR gdb/24364
2841         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2842         call dtrace_process_dof with NULL dof.
2843
2844 2019-06-16  Tom de Vries  <tdevries@suse.de>
2845
2846         PR gdb/24445
2847         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2848
2849 2019-06-16  Tom Tromey  <tom@tromey.com>
2850
2851         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2852         (make_all_visible): Use address of member.
2853
2854 2019-06-16  Tom Tromey  <tom@tromey.com>
2855
2856         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2857         (tui_free_window, free_content, free_content_elements): Remove
2858         unnecessary cast.
2859         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2860         cast.
2861         * tui/tui-regs.c (tui_show_register_group)
2862         (tui_display_registers_from, tui_display_reg_element_at_line):
2863         Remove unnecessary cast.
2864
2865 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2866
2867         * linux-nat.c (normal_mask): Delete.
2868         (_initialize_linux_nat): Don't initialise normal_mask.
2869
2870 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2871
2872         PR gdb/24445
2873         * dwarf-index-write.h (write_psymtabs_to_index): Add
2874         dwz_basename parameter.
2875         * dwarf-index-write.c (write_gdbindex): Move file writing to
2876         write_gdbindex_1.  Change return type void.
2877         (assert_file_size): Move up, remove filename parameter.
2878         (write_gdbindex_1): New function.
2879         (write_debug_names): Change return type to void, call
2880         assert_file_size.
2881         (struct index_wip_file): New struct.
2882         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2883         file logic to index_wip_file.  Write index for dwz file if
2884         needed.
2885         (save_gdb_index_command): Pass basename of dwz file, if present.
2886         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2887         build-id of dwz file, if present.
2888         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2889         (dwarf2_get_dwz_file): Likewise.
2890         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2891         (dwarf2_get_dwz_file): Likewise.
2892
2893 2019-06-16  Tom Tromey  <tom@tromey.com>
2894
2895         * coffread.c (process_coff_symbol): Use xstrdup.
2896         * value.c (create_internalvar): Use xstrdup.
2897
2898 2019-06-16  Tom Tromey  <tom@tromey.com>
2899
2900         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2901         * breakpoint.c (stopin_command, stopat_command)
2902         (until_break_command, decode_location_default): Remove unnecessary
2903         cast.
2904         * utils.c (subset_compare): Remove unnecessary cast.
2905         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2906         cast.
2907         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2908         cast.
2909         * infcmd.c (path_command): Remove unnecessary cast.
2910         * coffread.c (decode_type): Remove unnecessary cast.
2911         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2912         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2913         * tui/tui-stack.c (tui_show_locator_content)
2914         (tui_show_frame_info): Remove unnecessary cast.
2915         * tui/tui-win.c (tui_scroll_forward_command)
2916         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2917         (parse_scrolling_args): Remove unnecessary cast.
2918         * tui/tui-data.c (init_win_info, tui_del_window)
2919         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2920         (free_content_elements): Remove unnecessary cast.
2921         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2922         unnecessary cast.
2923         * tui/tui-source.c (tui_set_source_content)
2924         (tui_vertical_source_scroll): Remove unnecessary cast.
2925         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2926         cast.
2927         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2928         * tui/tui-regs.c (tui_display_registers_from)
2929         (tui_display_register): Remove unnecessary cast.
2930         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2931         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2932         (make_visible): Remove unnecessary cast.
2933         * tui/tui-winsource.c (tui_erase_source_content)
2934         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2935         unnecessary cast.
2936         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2937         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2938         * stabsread.c (read_type, read_array_type, read_range_type):
2939         Remove unnecessary cast.
2940         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2941         (parse_symbol, parse_type, upgrade_type, parse_external)
2942         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2943         unnecessary cast.
2944         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2945
2946 2019-06-16  Tom Tromey  <tom@tromey.com>
2947
2948         * tui/tui-data.c (tui_alloc_generic_win_info)
2949         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2950         checks.
2951
2952 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2953             Andrew Burgess  <andrew.burgess@embecosm.com>
2954
2955         * f-typeprint.c (f_print_type): Don't return early for not
2956         associated or not allocated types.
2957         (f_type_print_varspec_suffix): Add print_rank parameter and print
2958         ranks of array types in case they dangling.
2959         (f_type_print_base): Add print_rank parameter.
2960
2961 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2962
2963         * NEWS: Mention new MI commands.
2964         * break-catch-throw.c (enum exception_event_kind): Move to
2965         breakpoint.h.
2966         (print_mention_exception_catchpoint): Output text as a single
2967         message.
2968         (catch_exception_command_1): Rename to...
2969         (catch_exception_event): ...this, make non-static, update header
2970         command, and change some parameter types.
2971         (catch_catch_command): Update for changes to
2972         catch_exception_command_1.
2973         (catch_throw_command): Likewise.
2974         (catch_rethrow_command): Likewise.
2975         * breakpoint.c (enum exception_event_kind): Delete.
2976         * breakpoint.h (enum exception_event_kind): Moved here from
2977         break-catch-throw.c.
2978         (catch_exception_event): Declare.
2979         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2980         (mi_cmd_catch_throw): New function.
2981         (mi_cmd_catch_rethrow): New function.
2982         (mi_cmd_catch_catch): New function.
2983         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2984         'catch-catch' entries.
2985         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2986         (mi_cmd_catch_rethrow): Declare.
2987         (mi_cmd_catch_catch): Declare.
2988
2989 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2990
2991         * annotate.c (annotate_source_line): Change return type to void,
2992         update implementation to match.
2993         * annotate.h (annotate_source_line): Change return type to void,
2994         update header comment.
2995         * stack.c (print_frame_info): Don't change what frame information
2996         is printed based on whether annotations are on or not.
2997
2998 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2999
3000         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
3001         (annotate_source): Make static.
3002         (annotate_source_line): Moved from source.c and renamed from
3003         identify_source_line.  Update the return type.
3004         * annotate.h (annotate_source): Delete declaration.
3005         (annotate_source_line): Declaration moved from source.h, and
3006         renamed from identify_source_line.  Return type updated.
3007         * source.c (identify_source_line): Moved to annotate.c and renamed
3008         to annotate_source_line.
3009         (info_line_command): Remove check of annotation_level.
3010         * source.h (identify_source_line): Move declaration to annotate.h
3011         and rename to annotate_source_line.
3012         * stack.c: Add 'annotate.h' include.
3013         (print_frame_info): Remove check of annotation_level before
3014         calling annotate_source_line.
3015
3016 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3017
3018         * source-cache.c (source_cache::get_plain_source_lines): Use
3019         open_source_file_with_line_charpos instead of just
3020         open_source_file, remove call to find_source_lines.
3021         (source_cache::get_source_lines): Likewise.
3022         * source.c (find_source_lines): Make static.
3023         (get_filename_and_charpos): Renamed into...
3024         (open_source_file_with_line_charpos): ..this along with changes to
3025         return a scoped_fd, and some other minor clean ups.
3026         (identify_source_line): Use open_source_file_with_line_charpos.
3027         (search_command_helper): Use open_source_file_with_line_charpos
3028         instead of just open_source_file, remove call to
3029         find_source_lines.
3030         * source.h (open_source_file_with_line_charpos): Declare new
3031         function.
3032         (find_source_lines): Delete declaration.
3033
3034 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3035
3036         * source.c (get_filename_and_charpos): Remove fullname
3037         parameter.
3038         (identify_source_line): Update call to get_filename_and_charpos.
3039
3040 2019-06-14  Tom Tromey  <tromey@adacore.com>
3041
3042         PR gdb/24502:
3043         * ui-style.h (skip_ansi_escape): Update comment.
3044         * ui-file.h (class no_terminal_escape_file): New class.
3045         * ui-file.c (no_terminal_escape_file::write)
3046         (no_terminal_escape_file::puts): New methods.
3047         * cli/cli-logging.c (handle_redirections): Use
3048         no_terminal_escape_file.
3049
3050 2019-06-14  Tom Tromey  <tromey@adacore.com>
3051
3052         * NEWS: Move convenience variable news above Python news.
3053
3054 2019-06-14  Tom Tromey  <tom@tromey.com>
3055
3056         * gnulib: Move directory to top-level.
3057         * configure.ac: Don't configure gnulib.
3058         * configure: Rebuild.
3059         * common/common-defs.h: Use new path to gnulib.
3060         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
3061         (GNULIB_H): Remove.
3062         (INCGNU): Look in new gnulib location.
3063         (HFILES_NO_SRCDIR): Remove gnulib files.
3064         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
3065         (generated_files): Remove GNULIB_H.
3066         ($(LIBGNU), all-lib): Remove targets.
3067         (distclean): Don't mention GNULIB_BUILDDIR.
3068         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
3069
3070 2019-06-14  Tom Tromey  <tromey@adacore.com>
3071
3072         * symfile.c (add_symbol_file_command): Remove obsolete comment.
3073         Warn if symbol file does not provide any symbols.
3074
3075 2019-06-14  Tom Tromey  <tromey@adacore.com>
3076
3077         * source.c (find_and_open_source): Respect basenames_may_differ.
3078
3079 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
3080
3081         * annotate.c (annotate_breakpoints_invalid): Make use of
3082         scoped_restore_terminal_state.
3083         (annotate_frames_invalid): Likewise.
3084
3085 2019-06-14  Tom Tromey  <tromey@adacore.com>
3086
3087         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
3088         allow assignment to an internalvar.
3089
3090 2019-06-14  Tom Tromey  <tromey@adacore.com>
3091
3092         * ada-lex.l: Allow "_" in attribute names.
3093
3094 2019-06-14  Tom Tromey  <tromey@adacore.com>
3095
3096         PR gdb/24653:
3097         * regcache.c (registers_changed): Don't call alloca.
3098         * top.c (execute_command): Don't call alloca.
3099
3100 2019-06-13  Pedro Alves  <palves@redhat.com>
3101
3102         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
3103         'expression'.  When parsing an expression, error out if there's
3104         junk after "unlimited".
3105         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3106         (do_set_command): Adjust calls to is_unlimited_literal.
3107
3108 2019-06-13  Pedro Alves  <palves@redhat.com>
3109
3110         * compile/compile.c (make_compile_options_def_group): Add braces
3111         around array_view initializer.
3112         * thread.c (make_thread_apply_all_options_def_group)
3113         (make_thread_apply_all_options_def_group): Likewise.
3114
3115 2019-06-13  Pedro Alves  <palves@redhat.com>
3116
3117         * NEWS (New commands): Mention "maint test-options
3118         require-delimiter", "maint test-options unknown-is-error", "maint
3119         test-options unknown-is-operand" and "maint show
3120         test-options-completion-result".
3121         (New command options, command completion): New section.
3122         (Completion improvements): New section.
3123         Mention that you can abbreviate "unlimited".
3124
3125 2019-06-13  Pedro Alves  <palves@redhat.com>
3126
3127         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
3128         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
3129         * unittests/cli-utils-selftests.c (test_parse_flags)
3130         (test_parse_flags_qcs): Delete.
3131         (test_cli_utils): Don't call deleted functions.
3132
3133 2019-06-13  Pedro Alves  <palves@redhat.com>
3134
3135         * thread.c: Include "cli/cli-option.h".
3136         (tp_array_compar_ascending): Global.
3137         (tp_array_compar): Delete function.
3138         (tp_array_compar_ascending, tp_array_compar_descending): New
3139         functions.
3140         (ascending_option_def, qcs_flag_option_def)
3141         (thr_qcs_flags_option_defs)
3142         (make_thread_apply_all_options_def_group)
3143         (make_thread_apply_options_def_group): New.
3144         (thread_apply_all_command): Use gdb::option::process_options.
3145         (thread_apply_command_completer)
3146         (thread_apply_all_command_completer): New.
3147         (thread_apply_command): Use gdb::option::process_options.
3148         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
3149         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
3150         to generate help text of "thread apply".  Adjust "taas"'s help.
3151         * tid-parse.c (tid_range_parser::in_thread_range): New method.
3152         * tid-parse.h (tid_range_parser::in_thread_range): New method.
3153
3154 2019-06-13  Pedro Alves  <palves@redhat.com>
3155
3156         * thread.c (thread_apply_command): Check for invalid TID with
3157         isdigit instead of !isalpha.
3158
3159 2019-06-13  Pedro Alves  <palves@redhat.com>
3160
3161         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
3162         (validate_flags_qcs): New.
3163         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
3164         (validate_flags_qcs): Declare.
3165         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
3166         (make_frame_apply_options_def_group): New.
3167         (frame_apply_command_count): Process options with
3168         gdb::option::process_options.
3169         (frame_apply_completer): New.
3170         (frame_apply_level_completer, frame_apply_all_completer)
3171         (frame_apply_completer): New.
3172         (_initialize_stack): Update help of "frame apply", "frame apply
3173         level", "frame apply all" and "faas" to mention supported options
3174         and install command completers.
3175         * stack.h (frame_apply_all_completer): Declare.
3176         * thread.c: Include "stack.h".
3177         (tfaas_command): Add "--".
3178         (_initialize_thread): Update help "tfaas" to mention supported
3179         options and install command completer.
3180
3181 2019-06-13  Pedro Alves  <palves@redhat.com>
3182
3183         * completer.c (complete_nested_command_line): New.
3184         (gdb_completion_word_break_characters_throw): Add assertion.
3185         * completer.h (complete_nested_command_line): Declare.
3186
3187 2019-06-13  Pedro Alves  <palves@redhat.com>
3188
3189         * stack.c (parse_backtrace_qualifiers): New.
3190         (backtrace_command): Use it.
3191         (backtrace_command_completer): Complete on qualifiers.
3192
3193 2019-06-13  Pedro Alves  <palves@redhat.com>
3194
3195         * frame.c: Include "cli/cli-option.h.
3196         (user_set_backtrace_options): New.
3197         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3198         Delete.
3199         (get_prev_frame): Adjust.
3200         (boolean_option_def, uinteger_option_def)
3201         (set_backtrace_option_defs): New.
3202         (_initialize_frame): Adjust and use
3203         gdb::option::add_setshow_cmds_for_options to install "set
3204         backtrace past-main" and "set backtrace past-entry".
3205         * frame.h: Include "cli/cli-option.h".
3206         (struct frame_print_options): Forward declare.
3207         (print_frame_arguments_all, print_frame_arguments_scalars)
3208         (print_frame_arguments_none): Declare.
3209         (print_entry_values): Delete declaration.
3210         (struct frame_print_options, user_frame_print_options): New.
3211         (struct set_backtrace_options): New.
3212         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3213         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3214         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3215         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3216         (list_args_or_locals): Add frame_print_options parameter.
3217         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3218         * python/py-framefilter.c (enumerate_args): Pass down
3219         USER_FRAME_PRINT_OPTIONS.
3220         * stack.c: Include "cli/cli-option.h".
3221         (print_frame_arguments_all, print_frame_arguments_scalars)
3222         (print_frame_arguments_none): Declare.
3223         (print_raw_frame_arguments, print_entry_values): Delete.
3224         (user_frame_print_options): New.
3225         (boolean_option_def, enum_option_def, frame_print_option_defs):
3226         New.
3227         (struct backtrace_cmd_options): New.
3228         (bt_flag_option_def): New.
3229         (backtrace_command_option_defs): New.
3230         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3231         (print_frame_arg, read_frame_arg, print_frame_args)
3232         (print_frame_info, print_frame): Add frame_print_options parameter
3233         and use it.
3234         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3235         (backtrace_command_1): Add frame_print_options and
3236         backtrace_cmd_options parameters and use them.
3237         (make_backtrace_options_def_group): New.
3238         (backtrace_command): Process command options with
3239         gdb::option::process_options.
3240         (backtrace_command_completer): New.
3241         (_initialize_stack): Extend "backtrace"'s help to mention
3242         supported options.  Install completer for "backtrace".
3243         Install some settings commands with add_setshow_cmds_for_options.
3244
3245 2019-06-13  Pedro Alves  <palves@redhat.com>
3246
3247         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3248         and that "set/show print raw frame-arguments" are now deprecated.
3249
3250         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3251         command.
3252         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3253         * stack.c (_initialize_stack): Install "set/show print
3254         raw-frame-arguments", and deprecate "set/show print raw
3255         frame-arguments".
3256         * valprint.c (_initialize_valprint): Deprecate "set/show print
3257         raw".
3258
3259 2019-06-13  Pedro Alves  <palves@redhat.com>
3260
3261         * compile/compile.c (struct compile_options): New.
3262         (compile_flag_option_def, compile_command_option_defs)
3263         (make_compile_options_def_group): New.
3264         (compile_file_command): Handle options with
3265         gdb::option::process_options.
3266         (compile_file_command_completer): New function.
3267         (compile_code_command): Handle options with
3268         gdb::option::process_options.
3269         (compile_code_command_completer): New function.
3270         (_initialize_compiler): Install completers for "compile code" and
3271         "compile file".  Mention available options in "compile code" and
3272         "compile code"'s help.
3273         * completer.c (advance_to_completion_word): New, factored out from
3274         ...
3275         (advance_to_expression_complete_word_point): ... this.
3276         (advance_to_filename_complete_word_point): New.
3277         * completer.h (advance_to_filename_complete_word_point): New
3278         declaration.
3279
3280 2019-06-13  Pedro Alves  <palves@redhat.com>
3281
3282         * compile/compile.c: Include "cli/cli-option.h".
3283         (compile_print_value): Scope data pointer is now a
3284         value_print_options pointer; adjust.
3285         (compile_print_command): Process options.  Scope data pointer is
3286         now a value_print_options pointer; adjust.
3287         (_initialize_compile): Update "compile print"'s help to include
3288         supported options.  Install a completer for "compile print".
3289         * cp-valprint.c (show_vtblprint, show_objectprint)
3290         (show_static_field_print): Delete.
3291         (_initialize_cp_valprint): Don't install "set print
3292         static-members", "set print vtbl", "set print object" here.
3293         * printcmd.c: Include "cli/cli-option.h" and
3294         "common/gdb_optional.h".
3295         (print_command_parse_format): Rework to fill in a
3296         value_print_options instead of a format_data.
3297         (print_value): Change parameter type from format_data pointer to
3298         value_print_options reference.  Adjust.
3299         (print_command_1): Process options.  Adjust to pass down a
3300         value_print_options.
3301         (print_command_completer): New.
3302         (_initialize_printcmd): Install print_command_completer as
3303         handle_brkchars completer for the "print" command.  Update
3304         "print"'s help to include supported options.
3305         * valprint.c: Include "cli/cli-option.h".
3306         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3307         here from cp-valprint.c.
3308         (boolean_option_def, uinteger_option_def)
3309         (value_print_option_defs, make_value_print_options_def_group):
3310         New.  Use gdb::option::add_setshow_cmds_for_options to install
3311         "set print elements", "set print null-stop", "set print repeats",
3312         "set print pretty", "set print union", "set print array", "set
3313         print address", "set print symbol", "set print array-indexes".
3314         * valprint.h: Include <string> and "cli/cli-option.h".
3315         (make_value_print_options_def_group): Declare.
3316         (print_value): Change parameter type from format_data pointer to
3317         value_print_options reference.
3318         (print_command_completer): Declare.
3319
3320 2019-06-13  Pedro Alves  <palves@redhat.com>
3321
3322         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3323         (COMMON_SFILES): Add maint-test-settings.c.
3324         * cli/cli-decode.c (boolean_enums): New global, factored out from
3325         ...
3326         (add_setshow_boolean_cmd): ... here.
3327         * cli/cli-decode.h (boolean_enums): Declare.
3328         * cli/cli-option.c: New file.
3329         * cli/cli-option.h: New file.
3330         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3331         factored out from ...
3332         (parse_cli_boolean_value(const char *)): ... this.
3333         (is_unlimited_literal): Change parameter type to pointer to
3334         pointer.  Adjust and advance ARG pointer.
3335         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3336         (parse_cli_var_enum): New, factored out from ...
3337         (do_set_command): ... this.  Adjust.
3338         * cli/cli-setshow.h (parse_cli_boolean_value)
3339         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3340         (parse_cli_var_enum): Declare.
3341         * cli/cli-utils.c: Include "cli/cli-option.h".
3342         (get_ulongest): New.
3343         * cli/cli-utils.h (get_ulongest): Declare.
3344         (check_for_argument): New overloads.
3345         * maint-test-options.c: New file.
3346
3347 2019-06-13  Pedro Alves  <palves@redhat.com>
3348
3349         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3350         parse a range if "-" is at the end of the string.
3351
3352 2019-06-13  Pedro Alves  <palves@redhat.com>
3353
3354         * cli/cli-setshow.c (parse_auto_binary_operation)
3355         (parse_cli_boolean_value): Don't allow "o".
3356
3357 2019-06-13  Pedro Alves  <palves@redhat.com>
3358
3359         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3360         * NEWS: Mention maint test-settings KIND.
3361         * maint-test-settings.c: New file.
3362
3363 2019-06-13  Pedro Alves  <palves@redhat.com>
3364
3365         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3366         completer.
3367         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3368         "set" completers.
3369
3370 2019-06-13  Pedro Alves  <palves@redhat.com>
3371
3372         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3373         after item.
3374
3375 2019-06-13  Pedro Alves  <palves@redhat.com>
3376
3377         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3378
3379 2019-06-13  Pedro Alves <palves@redhat.com>
3380
3381         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3382         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3383         call.
3384         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3385         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3386         calls.
3387         (check_for_argument): Skip spaces after argument.
3388
3389 2019-06-13  Pedro Alves  <palves@redhat.com>
3390
3391         * thread.c (thread_apply_command): Adjust TID parsing.
3392         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3393         detected before end of string.
3394         (tid_is_in_list): Error out if LIST is invalid.
3395
3396 2019-06-13  Pedro Alves  <palves@redhat.com>
3397
3398         * completer.c (complete_line_internal_1): Rewind completion word
3399         point.
3400         (completion_tracker::advance_custom_word_point_by): Change
3401         parameter type to int.
3402         * completer.h (completion_tracker::advance_custom_word_point_by):
3403         Likewise.
3404
3405 2019-06-13  Pedro Alves  <palves@redhat.com>
3406
3407         * completer.c (advance_to_completion_word): Handle delimiters.
3408
3409 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3410
3411         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3412
3413 2019-06-11  Tom Tromey  <tom@tromey.com>
3414
3415         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3416         (xmalloc_failed): Move to alloc.c.
3417         * alloc.c: New file.
3418         * Makefile.in (COMMON_SFILES): Add alloc.c.
3419
3420 2019-06-11  Tom Tromey  <tom@tromey.com>
3421
3422         * nat/linux-waitpid.c: Don't include server.h.
3423         (linux_debug): Remove.
3424         (my_waitpid): Update.
3425
3426 2019-06-11  Tom Tromey  <tromey@adacore.com>
3427
3428         * infcall.c (_initialize_infcall): Remove trailing newline from
3429         help.
3430         * user-regs.c (_initialize_user_regs): Remove trailing newline
3431         from help.
3432         * typeprint.c (_initialize_typeprint): Remove trailing newline
3433         from help.
3434         * reverse.c (_initialize_reverse): Remove trailing newlines from
3435         help.
3436         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3437         from help.
3438         * language.c (add_set_language_command): Remove trailing newline
3439         from help.
3440         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3441         help.
3442         * disasm.c (_initialize_disasm): Remove trailing newline from
3443         help.
3444         * top.c (init_main): Remove trailing newline from help.
3445         * interps.c (_initialize_interpreter): Remove trailing newline
3446         from help.
3447         * btrace.c (_initialize_btrace): Remove trailing newlines from
3448         help.
3449         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3450         from help.
3451         * python/python.c (_initialize_python): Remove trailing newline
3452         from help.
3453         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3454         help.
3455         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3456         from help.  Reformat some text.
3457         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3458         from help.
3459         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3460         newline from help.
3461
3462 2019-06-11  Tom Tromey  <tromey@adacore.com>
3463
3464         * darwin-nat.c (darwin_decode_exception_message)
3465         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3466
3467 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3468
3469         * valops.c (value_slice): Check for not allocated or not
3470         associated values.
3471
3472 2019-06-10  Tom de Vries  <tdevries@suse.de>
3473
3474         PR gdb/24618
3475         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3476         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3477         invalid.
3478
3479 2019-06-10  Tom de Vries  <tdevries@suse.de>
3480
3481         PR gdb/24611
3482         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3483         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3484
3485 2019-06-10  Tom de Vries  <tdevries@suse.de>
3486
3487         PR symtab/24545
3488         * symtab.c (struct demangled_name_entry): Add language field.
3489         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3490         static minimal symbol".  Set and use language field.
3491
3492 2019-06-10  Tom Tromey  <tromey@adacore.com>
3493
3494         * ada-lang.c (_initialize_ada_language): Update help text.
3495
3496 2019-06-10  Tom Tromey  <tromey@adacore.com>
3497
3498         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3499         with a newline.
3500         * guile/guile.c (handle_boot_error): Don't end warning with a
3501         newline.
3502         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3503         warning with a newline.
3504         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3505         newline.
3506         (s12z_frame_cache): Likewise.
3507         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3508         a newline.
3509         * solib-svr4.c (disable_probes_interface): Don't end warning with
3510         a newline.
3511         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3512         newline.
3513         * python/python.c (do_finish_initialization): Don't end warning
3514         with a newline.
3515
3516 2019-06-10  Tom Tromey  <tom@tromey.com>
3517
3518         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3519         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3520         gdbpy_enter.
3521
3522 2019-06-10  Tom Tromey  <tromey@adacore.com>
3523
3524         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3525         data.
3526         (elf_new_init): Don't call stabsread_new_init.
3527         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3528         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3529         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3530
3531 2019-06-10  Tom de Vries  <tdevries@suse.de>
3532
3533         PR symtab/16264
3534         PR symtab/24517
3535         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3536
3537 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3538
3539         * source.c (find_and_open_source): Also rewrite relative file
3540         names.
3541
3542 2019-04-26  Amos Bird  <amosbird@gmail.com>
3543
3544         * annotate.c (annotate_thread_exited): Add "thread-exited"
3545         annotation.
3546
3547 2019-06-06  Tom Tromey  <tromey@adacore.com>
3548
3549         * maint.h (class scoped_command_stats): Use
3550         DISABLE_COPY_AND_ASSIGN.
3551         <print_time>: New method.
3552         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3553         print_time.
3554         (scoped_command_stats::print_time): New method.
3555
3556 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3557
3558         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3559         instructions of lengths 6 or 8 bytes.
3560
3561 2019-06-04  Pedro Alves  <palves@redhat.com>
3562
3563         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3564
3565         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3566         * breakpoint.c (condition_completer): Likewise.
3567         * cli/cli-dump.c (scan_expression): Likewise.
3568         * common/filestuff.c (mkdir_recursive): Likewise.
3569         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3570         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3571         (gdb_abspath): Likewise.
3572         * compile/compile-cplus-types.c
3573         (compile_cplus_instance::decl_name): Likewise.
3574         * completer.c (complete_explicit_location):
3575         (signal_completer, reg_or_group_completer_1): Likewise.
3576         * cp-support.c (cp_remove_params_if_any): Likewise.
3577         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3578         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3579         * infcmd.c (strip_bg_char): Likewise.
3580         * linespec.c (copy_token_string): Likewise.
3581         * mi/mi-main.c (output_cores): Likewise.
3582         * psymtab.c (psymtab_search_name):
3583         * symfile.c (test_set_ext_lang_command): Likewise.
3584         * target.c (target_fileio_read_stralloc): Likewise.
3585         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3586         * value.c (complete_internalvar): Likewise.
3587
3588 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3589
3590         Add objfile property to gdb.Type.
3591         * NEWS: Mention Python API addition.
3592         * python/py-type.c (typy_get_objfile): New method.
3593
3594 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3595
3596         * NEWS: Mention the new set|show style [title|highlight].
3597         Mention changes to "show style", "help" and "apropos".
3598
3599 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3600
3601         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3602         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3603         instead of print_help_for_command.
3604         (print_doc_of_command): New function.
3605         (help_list): Add 'apropos -v word' suggestion.
3606         (print_help_for_command): Style the command name using title style.
3607         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3608         (_initialize_cli_cmds): Describe -v in apropos_command help.
3609
3610 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3611
3612         * cli/cli-style.h (cli_style_option): Add name in constructor,
3613         add m_name class member, add constructor with intensity,
3614         add name class function.
3615         (cli_style_option::add_setshow_commands): Remove name argument.
3616         (highlight_style, title_style): New styles.
3617         * cli/cli-style.c (do_show): New function that shows a style
3618         characteristic styling the style name with itself.
3619         (set_style_name): New function.
3620         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3621         Update all callers according to the changes in cli/cli-style.h.
3622         * utils.h (fputs_highlighted): New function.
3623         * utils.c (fputs_highlighted): Likewise.
3624
3625 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3626
3627         * NEWS: Mention new pipe command and new convenience variables.
3628
3629 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3630
3631         * cli/cli-cmds.c (pipe_command): New function.
3632         (_initialize_cli_cmds): Call add_com for pipe_command.
3633         Define | as an alias for pipe.
3634         (exit_status_set_internal_vars): New function.
3635         (shell_escape): Call exit_status_set_internal_vars.
3636         cli/cli-decode.c (find_command_name_length): Recognize | as
3637         a single character command.
3638
3639 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3640
3641         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3642         top.c (execute_command_to_ui_file): New function, mostly a copy
3643         of execute_command_to_string.
3644         (execute_command_to_string): Implement by calling
3645         execute_command_to_ui_file.
3646
3647 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3648
3649         * top.h (saved_command_line): Remove declaration.
3650         * top.c (previous_saved_command_line, previous_repeat_arguments):
3651         New variables.
3652         (saved_command_line): Make static, define together with other
3653         'repeat variables'.
3654         (dont_repeat): Clear repeat_arguments.
3655         (repeat_previous, get_saved_command_line, save_command_line):
3656         New functions.
3657         (gdb_init): Initialize saved_command_line
3658         and previous_saved_command_line.
3659         * main.c (captured_main_1): Remove saved_command_line initialization.
3660         * event-top.c (handle_line_of_input): Update to use
3661         the new 'repeat' related functions instead of direct access to
3662         saved_command_line.
3663         * command.h (repeat_previous, get_saved_command_line,
3664         save_command_line): New declarations.
3665         (dont_repeat): Add comment.
3666
3667 2019-05-30  Tom Tromey  <tromey@adacore.com>
3668
3669         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3670         Fix comment.
3671         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3672
3673 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3674
3675         PR cli/24587
3676         * completer.c (complete): Initialize variable word.
3677
3678 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3679
3680         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3681         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3682         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3683         'body' is NULL to the outter 'if', protecting the '!is_define'
3684         situation as well.
3685
3686 2019-05-29  Tom Tromey  <tromey@adacore.com>
3687
3688         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3689         (dwarf_unknown): New function.
3690         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3691         (dwarf_type_encoding_name): Use dwarf_unknown.
3692
3693 2019-05-29  Tom Tromey  <tromey@adacore.com>
3694
3695         PR c++/20020:
3696         * cp-valprint.c (cp_print_value_fields): Call
3697         cp_print_static_field inside "try".
3698
3699 2019-05-29  Tom Tromey  <tromey@adacore.com>
3700
3701         * inflow.c (struct terminal_info): Add default operator=.
3702         * configure: Rebuild.
3703         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3704         -Wdeprecated-copy-dtor, -Wredundant-move.
3705
3706 2019-05-29  Tom Tromey  <tromey@adacore.com>
3707
3708         * NEWS: Add entry.
3709         * infcmd.c (print_return_value_1): Handle finish_print
3710         option.
3711         (show_print_finish): New function.
3712         (_initialize_infcmd): Add "set/show print finish" commands.
3713         * valprint.c (user_print_options): Initialize new member.
3714         * valprint.h (struct value_print_options) <finish_print>: New
3715         member.
3716
3717 2019-05-28  Tom Tromey  <tromey@adacore.com>
3718
3719         * ada-lang.c (ada_remove_Xbn_suffix)
3720         (find_old_style_renaming_symbol)
3721         (parse_old_style_renaming): Remove.
3722         (ada_find_renaming_symbol): Don't call
3723         find_old_style_renaming_symbol.
3724         (ada_is_renaming_symbol): Rename from
3725         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3726         bool.  Now static.
3727         (ada_read_var_value): Update and simplify.
3728         * ada-exp.y (write_var_or_type): Remove old code.
3729
3730 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3731
3732         * event-top.c: Remove include comment.
3733         * inflow.c (class scoped_ignore_sigttou): Move from here...
3734         * inflow.h (class scoped_ignore_sigttou): ...to here.
3735         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3736         * top.c:  Remove include comment.
3737
3738 2019-05-27  Tom Tromey  <tom@tromey.com>
3739
3740         * NEWS: Fix typo.
3741
3742 2019-05-22  Tom Tromey  <tromey@adacore.com>
3743
3744         * target.c (target_follow_exec): Constify parameter.
3745         * target-delegates.c: Rebuild.
3746         * remote.c (remote_target::follow_exec): Constify parameter.
3747         * infrun.c (follow_exec): Constify parameter.
3748         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3749         (target_follow_exec): Likewise.
3750
3751 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3752
3753         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3754         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3755
3756 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3757
3758         * NEWS: Add debugredirect and testsuite sections.
3759
3760 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3761
3762         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3763         target descriptions using exclusively floating point register name
3764         aliases.
3765
3766 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3767
3768         PR gdb/18644:
3769         * f-lang.c (build_fortran_types): Handle the case where
3770         gdbarch_floatformat_for_type returns a nullptr.
3771
3772 2019-05-21  Tom de Vries  <tdevries@suse.de>
3773
3774         PR cli/24587
3775         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3776
3777 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3778
3779         PR gdb/18644:
3780         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3781         16-byte floats.
3782         * i386-tdep.c (i386_floatformat_for_type): Use
3783         floatformats_ia64_quad for the 16-byte floating point component
3784         within a fortran 32-byte complex number.
3785
3786 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3787
3788         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3789         delete default constructor.
3790         (find_partial_die): Update to return const struct.
3791         (partial_die_parent_scope): Move variable declaration into scope
3792         of its use and change its type to auto.
3793         (guess_partial_die_structure_name): Likewise.
3794         (partial_die_info::fixup): Likewise.
3795
3796 2019-05-17  Tom Tromey  <tromey@adacore.com>
3797
3798         * source.c (find_and_open_source): Remove cast.
3799
3800 2019-05-17  Tom Tromey  <tromey@adacore.com>
3801
3802         * annotate.c (annotate_source): Make "filename" const.
3803         * annotate.h (annotate_source): Use const.
3804
3805 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3806
3807         * disasm.c (set_disassembler_options): Send errors to stderr.
3808
3809 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3810
3811         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3812         (cli_interp_base::set_logging): Check debug_redirect.
3813         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3814         * cli/cli-logging.c (debug_redirect): Add static variable.
3815         (pop_output_files): Add default param.
3816         (handle_redirections): Print debug setting.
3817         (show_logging_command): Likewise.
3818         (_initialize_cli_logging): Add debugredirect command.
3819         * interps.c (current_interp_set_logging): Add debug_redirect
3820         parameter.
3821         * interps.h (set_logging): Add debug_redirect parameter.
3822         (current_interp_set_logging): Likewise.
3823         * mi/mi-common.h: Likewise.
3824         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3825
3826 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3827             Tom Tromey  <tromey@adacore.com>
3828
3829         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3830         directly.
3831         * cli/cli-interp.h (make_logging_output): Remove declaration.
3832         * cli/cli-logging.c (make_logging_output): Remove function.
3833         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3834         directly.
3835         * ui-file.c (tee_file::tee_file): Remove bools.
3836         (tee_file::~tee_file): Remove deletes.
3837         * ui-file.h (tee_file): Remove bools.
3838
3839 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3840
3841         * mi/mi-cmds.h (mi_cmd_complete): New function.
3842         * mi/mi-main.c (mi_cmd_complete): Likewise.
3843         * mi/mi-cmds.c: Define new MI command -complete.
3844         * NEWS: Mention new -complete command.
3845
3846 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3847
3848         * completer.h (complete): New function.
3849         * completer.c (complete): Likewise.
3850         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3851         function defined in completer.h.
3852
3853 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3854
3855         * MAINTAINERS (Write After Approval): Add myself.
3856
3857 2019-05-17  Tom de Vries  <tdevries@suse.de>
3858
3859         PR gdb/24094
3860         * dwarf2read.c (struct cu_partial_die_info): New struct.
3861         (find_partial_die): Return cu_partial_die_info.
3862         (partial_die_parent_scope, guess_partial_die_structure_name)
3863         (partial_die_info::fixup): Handle new return type of find_partial_die.
3864
3865 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3866
3867         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3868         "std::string", simplifying the algorithm.
3869
3870 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3871
3872         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3873         (stap_static_probe_ops::get_probes): Likewise.
3874
3875 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3876
3877         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3878         '-')" and "else if".
3879         (stap_parse_single_operand): Join checks for
3880         "gdbarch_stap_parse_special_token_p" and
3881         "gdbarch_stap_parse_special_token" in the same "if" statement.
3882         Invert check when verifying for operation on register
3883         displacement.
3884
3885 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3886
3887         * stap-probe.c (stap_get_opcode): Update comment.
3888         (stap_get_expected_argument_type): Likewise.
3889         (handle_stap_probe): Likewise.
3890
3891 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3892
3893         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3894         return type to 'bool'.  Adjust comment.  Use 'bool' when
3895         appropriate.
3896         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3897         * stap-probe.c (stap_parse_argument_1): Likewise.
3898         (stap_is_operator): Likewise.
3899         (stap_is_generic_prefix): Likewise.
3900         (stap_is_register_prefix): Likewise.
3901         (stap_is_register_indirection_prefix): Likewise.
3902         (stap_is_integer_prefix): Likewise.
3903         (stap_generic_check_suffix): Likewise.
3904         (stap_check_integer_suffix): Likewise.
3905         (stap_check_register_suffix): Likewise.
3906         (stap_check_register_indirection_suffix): Likewise.
3907         (stap_parse_register_operand): Likewise.
3908         (stap_parse_single_operand): Likewise.
3909         (stap_parse_argument_1): Likewise.
3910         (stap_probe::get_argument_count): Likewise.
3911         (stap_is_operator): Likewise.
3912
3913 2019-05-16  Tom Tromey  <tromey@adacore.com>
3914
3915         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3916         keyword to foreach.
3917
3918 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3919
3920         * linux-thread-db.c (try_thread_db_load_1): Change return type
3921         to bool.
3922         (try_thread_db_load): Likewise.
3923         (try_thread_db_load_from_pdir_1): Likewise.
3924         (try_thread_db_load_from_pdir): Likewise.
3925         (try_thread_db_load_from_sdir): Likewise.
3926         (try_thread_db_load_from_dir): Likewise.
3927         (thread_db_load_search): Likewise.
3928         (has_libpthread): Likewise.
3929         (thread_db_load): Likewise.
3930
3931 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3932
3933         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3934         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3935         NULL, and complain/return if that's the case.
3936
3937 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3938
3939         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3940         (advance, posn, abstract_read_memory): New functions.
3941         [struct mem_read_abstraction]: New struct.
3942         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3943
3944 2019-05-14  Tom Tromey  <tromey@adacore.com>
3945
3946         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3947         value is not lval_memory.
3948
3949 2019-05-14  Tom Tromey  <tromey@adacore.com>
3950
3951         * solib.c (info_sharedlibrary_command): Style the file name.
3952
3953 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3954
3955         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3956         (aarch64_vnv_type): Likewise.
3957         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3958         * common/tdesc.c: Likewise.
3959         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3960         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3961         * features/aarch64-fpu.xml: Add ieee half view.
3962         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3963         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3964         * gdbtypes.h (struct builtin_type): Likewise.
3965         (struct objfile_type): Likewise.
3966
3967 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3968
3969         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3970         typo.
3971         * location.h (string_to_event_location): Likewise.
3972
3973 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3974
3975         GDB 8.3 released.
3976
3977 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3978
3979         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3980         New variable declaration.
3981         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3982         New variable.
3983         (print_one_breakpoint): Use ui_out::test_flags and new global
3984         variable to compute use_fixed_output.
3985         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3986         Remove.
3987         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3988         (mi_multi_location_breakpoint_output_fixed): Remove.
3989         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3990         new variable.
3991         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3992         fix_multi_location_breakpoint_output flag if version >= 3.
3993         * ui-out.h (enum ui_out_flag)
3994         <fix_multi_location_breakpoint_output>: New enumerator.
3995
3996 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3997
3998         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3999
4000 2019-05-10  Tom Tromey  <tromey@adacore.com>
4001
4002         * ada-lang.c (catch_ada_completer): New function.
4003         (_initialize_ada_language): Use it.
4004
4005 2019-05-10  Tom Tromey  <tromey@adacore.com>
4006
4007         * thread.c (print_thread_info): Make "requested_threads" const.
4008         * gdbthread.h (print_thread_info): Make "requested_threads"
4009         const.
4010         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
4011         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
4012
4013 2019-05-08  Tom Tromey  <tom@tromey.com>
4014
4015         * gdbtypes.c (objfile_type_data): Change type.
4016         (objfile_type, _initialize_gdbtypes): Update.
4017
4018 2019-05-08  Tom Tromey  <tom@tromey.com>
4019
4020         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
4021         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
4022         (_initialize_dwarf2_frame): Update.
4023
4024 2019-05-08  Tom Tromey  <tom@tromey.com>
4025
4026         * objc-lang.c (objc_objfile_data): Change type.
4027         (find_methods): Update.
4028         (_initialize_objc_lang): Remove.
4029
4030 2019-05-08  Tom Tromey  <tom@tromey.com>
4031
4032         * stabsread.c (rs6000_builtin_type_data): Change type.
4033         (rs6000_builtin_type, _initialize_stabsread): Update.
4034
4035 2019-05-08  Tom Tromey  <tom@tromey.com>
4036
4037         * mips-tdep.c (mips_pdr_data): Remove.
4038         (_initialize_mips_tdep): Update.
4039
4040 2019-05-08  Tom Tromey  <tom@tromey.com>
4041
4042         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
4043         (hppa_init_objfile_priv_data, read_unwind_info)
4044         (find_unwind_entry, _initialize_hppa_tdep): Update.
4045
4046 2019-05-08  Tom Tromey  <tom@tromey.com>
4047
4048         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
4049         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
4050         on obstack.
4051         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
4052
4053 2019-05-08  Tom Tromey  <tom@tromey.com>
4054
4055         * mdebugread.c (basic_type_data): Change type.
4056         (basic_type, _initialize_mdebugread): Update.
4057
4058 2019-05-08  Tom Tromey  <tom@tromey.com>
4059
4060         * common/gdb_unique_ptr.h (struct noop_deleter): New.
4061
4062 2019-05-08  Tom Tromey  <tom@tromey.com>
4063
4064         * nto-tdep.c (nto_inferior_data_reg): Change type.
4065         (nto_inferior_data): Update.
4066         (nto_inferior_data_cleanup, nto_new_inferior_data)
4067         (_initialize_nto_tdep): Remove.
4068         * nto-tdep.h (struct nto_inferior_data): Add initializers.
4069
4070 2019-05-08  Tom Tromey  <tom@tromey.com>
4071
4072         * ada-lang.c (struct ada_inferior_data): Add initializers.
4073         (ada_inferior_data): Change type.
4074         (ada_inferior_data_cleanup): Remove.
4075         (get_ada_inferior_data, ada_inferior_exit)
4076         (struct ada_pspace_data): Add initializers, destructor.
4077         (ada_pspace_data_handle): Change type.
4078         (get_ada_pspace_data): Update.
4079         (ada_pspace_data_cleanup): Remove.
4080
4081 2019-05-08  Tom Tromey  <tom@tromey.com>
4082
4083         * coffread.c (struct coff_symfile_info): Add initializers.
4084         (coff_objfile_data_key): Move lower.  Change type.
4085         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
4086         Update.
4087         (coff_free_info): Remove.
4088
4089 2019-05-08  Tom Tromey  <tom@tromey.com>
4090
4091         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
4092         (fbsd_pspace_data_handle): Move lower.  Change type.
4093         (get_fbsd_pspace_data): Update.
4094         (fbsd_pspace_data_cleanup): Remove.
4095         (_initialize_fbsd_tdep): Update.
4096
4097 2019-05-08  Tom Tromey  <tom@tromey.com>
4098
4099         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
4100         (get_ada_tasks_pspace_data): Update.
4101         (ada_tasks_pspace_data_cleanup): Remove.
4102         (_initialize_tasks): Update.
4103         (ada_tasks_inferior_data_handle): Change type.
4104         (get_ada_tasks_inferior_data): Update.
4105         (ada_tasks_inferior_data_cleanup): Remove.
4106         (struct ada_tasks_pspace_data): Add initializers.
4107
4108 2019-05-08  Tom Tromey  <tom@tromey.com>
4109
4110         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
4111         * symfile-debug.c (debug_sym_get_probes): Change type.
4112         * stap-probe.c (handle_stap_probe):
4113         (stap_static_probe_ops::get_probes): Change type.
4114         * probe.h (class static_probe_ops) <get_probes>: Change type.
4115         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
4116         (parse_probes_in_pspace): Update.
4117         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
4118         Update.
4119         (any_static_probe_ops::get_probes): Change type.
4120         * elfread.c (elfread_data): New typedef.
4121         (probe_key): Change type.
4122         (elf_get_probes): Likewise.  Update.
4123         (probe_key_free): Remove.
4124         (_initialize_elfread): Update.
4125         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
4126         Change type.
4127         (dtrace_process_dof_probe, dtrace_process_dof)
4128         (dtrace_static_probe_ops::get_probe): Change type.
4129
4130 2019-05-08  Tom Tromey  <tom@tromey.com>
4131
4132         * xcoffread.c (struct xcoff_symfile_info): Rename from
4133         coff_symfile_info.  Add initializers.
4134         (xcoff_objfile_data_key): Move lower.  Change type.
4135         (XCOFF_DATA): Rewrite.
4136         (xcoff_free_info): Remove.
4137         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
4138         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
4139         (xcoff_initial_scan): Update.
4140
4141 2019-05-08  Tom Tromey  <tom@tromey.com>
4142
4143         * solib-svr4.c (struct svr4_info): Add initializers and
4144         destructor.
4145         <probes_table>: Now an htab_up.
4146         (solib_svr4_pspace_data): Change type.
4147         (free_probes_table): Simplify.
4148         (~svr4_info): Rename from svr4_pspace_data_cleanup.
4149         (get_svr4_info, probes_table_htab_remove_objfile_probes)
4150         (probes_table_remove_objfile_probes, register_solib_event_probe)
4151         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
4152         (_initialize_svr4_solib): Update.
4153
4154 2019-05-08  Tom Tromey  <tom@tromey.com>
4155
4156         * remote.c (remote_pspace_data): Change type.
4157         (remote_pspace_data_cleanup): Remove.
4158         (get_remote_exec_file, set_pspace_remote_exec_file)
4159         (_initialize_remote): Update.
4160
4161 2019-05-08  Tom Tromey  <tom@tromey.com>
4162
4163         * breakpoint.c (breakpoint_objfile_key): Change type.
4164         (get_breakpoint_objfile_data): Update.
4165         (free_breakpoint_objfile_data): Remove.
4166         (_initialize_breakpoint): Update.
4167
4168 2019-05-08  Tom Tromey  <tom@tromey.com>
4169
4170         * linux-tdep.c (struct linux_info): Add initializers.
4171         (linux_inferior_data): Move.  Change type.
4172         (invalidate_linux_cache_inf): Update.
4173         (linux_inferior_data_cleanup): Remove.
4174         (get_linux_inferior_data, _initialize_linux_tdep): Update.
4175
4176 2019-05-08  Tom Tromey  <tom@tromey.com>
4177
4178         * auxv.c (auxv_inferior_data): Move.  Change type.
4179         (auxv_inferior_data_cleanup): Remove.
4180         (invalidate_auxv_cache_inf): Rewrite.
4181         (get_auxv_inferior_data, _initialize_auxv): Update.
4182
4183 2019-05-08  Tom Tromey  <tom@tromey.com>
4184
4185         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4186         (symfile_debug_objfile_data_key): Change type.
4187         (symfile_debug_installed, debug_qf_has_symbols)
4188         (debug_qf_find_last_source_symtab)
4189         (debug_qf_forget_cached_source_info)
4190         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4191         (debug_qf_print_stats, debug_qf_dump)
4192         (debug_qf_expand_symtabs_for_function)
4193         (debug_qf_expand_all_symtabs)
4194         (debug_qf_expand_symtabs_with_fullname)
4195         (debug_qf_map_matching_symbols)
4196         (debug_qf_expand_symtabs_matching)
4197         (debug_qf_find_pc_sect_compunit_symtab)
4198         (debug_qf_map_symbol_filenames)
4199         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4200         (debug_sym_new_init, debug_sym_init, debug_sym_read)
4201         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4202         (debug_sym_read_linetable, debug_sym_relocate): Update.
4203         (symfile_debug_free_objfile): Remove.
4204         (install_symfile_debug_logging, _initialize_symfile_debug):
4205         Update.
4206
4207 2019-05-08  Tom Tromey  <tom@tromey.com>
4208
4209         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4210         allocate_on_obstack.
4211         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4212         (get_dwarf2_per_objfile): Update.
4213         (set_dwarf2_per_objfile): Remove.
4214         (dwarf2_has_info, dwarf2_get_section_info): Update.
4215         (dwarf2_free_objfile): Remove.
4216         (_initialize_dwarf2_read): Update.
4217
4218 2019-05-08  Tom Tromey  <tom@tromey.com>
4219
4220         * auto-load.c (struct auto_load_pspace_info): Add destructor and
4221         initializers.
4222         <unsupported_script_warning_printed,
4223         script_not_found_warning_printed>: Now bool.
4224         (auto_load_pspace_data): Change type.
4225         (~auto_load_pspace_info): Rename from
4226         auto_load_pspace_data_cleanup.
4227         (get_auto_load_pspace_data, init_loaded_scripts_info)
4228         (clear_section_scripts, maybe_print_unsupported_script_warning)
4229         (maybe_print_script_not_found_warning, _initialize_auto_load):
4230         Update.
4231
4232 2019-05-08  Tom Tromey  <tom@tromey.com>
4233
4234         * objfiles.c (objfile_pspace_info): Add destructor and
4235         initializers.
4236         (objfiles_pspace_data): Change type.
4237         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4238         (get_objfile_pspace_data): Update.
4239         (objfiles_bfd_data): Change type.
4240         (get_objfile_bfd_data): Update.
4241         (objfile_bfd_data_free, _initialize_objfiles): Remove.
4242
4243 2019-05-08  Tom Tromey  <tom@tromey.com>
4244
4245         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4246         Change type.
4247         (get_catch_syscall_inferior_data): Update.
4248         (catch_syscall_inferior_data_cleanup): Remove.
4249         (_initialize_break_catch_syscall): Update.
4250
4251 2019-05-08  Tom Tromey  <tom@tromey.com>
4252
4253         * inflow.c (struct terminal_info): Add destructor and
4254         initializers.
4255         (inflow_inferior_data): Change type.
4256         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4257         (get_inflow_inferior_data, inflow_inferior_exit)
4258         (swap_terminal_info, _initialize_inflow): Update.
4259
4260 2019-05-08  Tom Tromey  <tom@tromey.com>
4261
4262         * target-dcache.c (target_dcache_cleanup): Remove.
4263         (target_dcache_aspace_key): Change type.
4264         (target_dcache_init_p, target_dcache_invalidate)
4265         (target_dcache_get, target_dcache_get_or_init)
4266         (_initialize_target_dcache): Update.
4267         * dcache.h (struct dcache_deleter): New.
4268
4269 2019-05-08  Tom Tromey  <tom@tromey.com>
4270
4271         * symtab.c (struct symbol_cache): Add destructor and
4272         initializers.
4273         (symbol_cache_key): Move.  Change type.
4274         (make_symbol_cache, free_symbol_cache): Remove.
4275         (get_symbol_cache): Update.
4276         (symbol_cache_cleanup): Remove.
4277         (ALL_PSPACES, symbol_cache_flush)
4278         (maintenance_print_symbol_cache)
4279         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4280         Update.
4281
4282 2019-05-08  Tom Tromey  <tom@tromey.com>
4283
4284         * symtab.c (struct main_info): Add destructor and initializers.
4285         (main_progspace_key): Move.  Change type.
4286         (get_main_info): Update.
4287         (main_info_cleanup): Remove.
4288         (_initialize_symtab): Update.
4289
4290 2019-05-08  Tom Tromey  <tom@tromey.com>
4291
4292         * registry.h (DECLARE_REGISTRY): Define the _key class.
4293
4294 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4295
4296         * NEWS: Merge two 'New commands' sections.
4297
4298 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4299
4300         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4301         parameter and use Ada language definition instead.
4302         (ada_val_print_ptr): Remove unused language parameter.
4303         (ada_val_print_num): Remove language parameter and use Ada language
4304         definition instead.
4305         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4306         parameter.
4307         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4308         parameter and use Ada language definition instead.
4309         (ada_val_print_1): Update all ada_val_print_xxx calls.
4310         Remove language parameter.
4311         (ada_val_print): Update ada_val_print_1 call.
4312
4313 2019-05-08  Tom Tromey  <tromey@adacore.com>
4314
4315         * remote.c (remote_hw_watchpoint_limit)
4316         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4317         Now static.
4318
4319 2019-05-08  Tom Tromey  <tromey@adacore.com>
4320
4321         * maint.c (_initialize_maint_cmds): Move initialization code to
4322         remote.c.
4323         (watchdog, show_watchdog): Move to remote.c.
4324         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4325         "watchdog" static.
4326         (_initialize_remote): Move initialization code from maint.c.
4327         * defs.h (watchdog): Don't declare.
4328
4329 2019-05-08  Tom Tromey  <tromey@adacore.com>
4330
4331         * tui/tui-interp.c: Include main.h.
4332         * interps.c: Include main.h.
4333         * main.h (interpreter_p): Declare.
4334         * defs.h (interpreter_p): Don't declare.
4335
4336 2019-05-08  Tom Tromey  <tromey@adacore.com>
4337
4338         * dwarf2loc.c: Include dwarf2read.h.
4339         * defs.h (read_unsigned_leb128): Don't declare.
4340         * dwarf2read.h (read_unsigned_leb128): Declare.
4341
4342 2019-05-08  Tom Tromey  <tromey@adacore.com>
4343
4344         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4345         method.
4346
4347 2019-05-08  Tom Tromey  <tromey@adacore.com>
4348
4349         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4350         when no wrap column is set.
4351
4352 2019-05-08  Tom Tromey  <tromey@adacore.com>
4353
4354         * c-lang.c (c_get_string): Handle non-C-style arrays.
4355
4356 2019-05-08  Tom Tromey  <tromey@adacore.com>
4357
4358         * typeprint.c (print_offset_data::update): Print the bit offset,
4359         not the number of bits remaining.
4360
4361 2019-05-08  Tom Tromey  <tromey@adacore.com>
4362
4363         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4364         padding at end of comment.
4365
4366 2019-05-08  Tom Tromey  <tromey@adacore.com>
4367
4368         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4369         Compare main types.
4370
4371 2019-05-06  Tom Tromey  <tom@tromey.com>
4372
4373         * common/scoped_mmap.c: Include common-defs.h.
4374         * common/scoped_mmap.h: Don't include config.h.
4375
4376 2019-05-04  Tom Tromey  <tom@tromey.com>
4377
4378         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4379         (struct aarch64_call_info): Add initializers.
4380         <si>: Now a std::vector.
4381         (pass_on_stack, aarch64_push_dummy_call): Update.
4382
4383 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4384             Tom Tromey  <tom@tromey.com>
4385
4386         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4387         (ppc_threads): Now a std::vector.  Now static.
4388         (hwdebug_find_thread_points_by_tid)
4389         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4390         Update.
4391
4392 2019-05-04  Tom Tromey  <tom@tromey.com>
4393
4394         * arc-tdep.c (arc_tdesc_init): Return bool.
4395
4396 2019-05-04  Tom Tromey  <tom@tromey.com>
4397
4398         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4399         Use gdb_assert_not_reached.
4400
4401 2019-05-04  Tom Tromey  <tom@tromey.com>
4402
4403         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4404         "false".
4405
4406 2019-05-04  Tom Tromey  <tom@tromey.com>
4407
4408         * arc-tdep.c (arc_tdesc_init): Use bool.
4409
4410 2019-05-04  Tom Tromey  <tom@tromey.com>
4411
4412         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4413
4414 2019-05-04  Tom Tromey  <tom@tromey.com>
4415
4416         * cli/cli-cmds.c (valid_command_p): Return bool.
4417
4418 2019-05-04  Tom Tromey  <tom@tromey.com>
4419
4420         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4421         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4422
4423 2019-05-04  Raul Tambre  <raul@tambre.ee>
4424
4425         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4426         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4427         operator for comparison.
4428
4429 2019-05-04  Tom Tromey  <tom@tromey.com>
4430
4431         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4432         (lookup_partial_symbol, print_partial_symbols)
4433         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4434         (psymbol_compare): Update.
4435         (add_psymbol_to_bcache): Clear the entire psymbol.
4436         (maintenance_check_psymtabs): Update.
4437         * psympriv.h (struct partial_symbol): Don't derive from
4438         general_symbol_info.
4439         <obj_section, unrelocated_address, address,
4440         set_unrelocated_address>: Update.
4441         <ginfo>: New member.
4442         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4443         (debug_names::write_psymbols): Update.
4444
4445 2019-05-04  Tom de Vries  <tdevries@suse.de>
4446
4447         * contrib/cc-with-tweaks.sh: Support -n arg.
4448
4449 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4450
4451         * corelow.c (core_target::detach): Ensure frame cache and
4452         register caches are cleared.
4453         inferior.c (exit_inferior_1): Likewise.
4454
4455 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4456             Tom Tromey  <tom@tromey.com>
4457
4458         * dictionary.c (collate_pending_symbols_by_language): Remove
4459         "struct" from foreach.
4460         * symtab.c (lookup_global_symbol_from_objfile)
4461         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4462         foreach.
4463         * ser-tcp.c (net_open): Remove "struct" from foreach.
4464         * objfiles.c (objfile_relocate, objfile_rebase)
4465         (objfile_has_symbols): Remove "struct" from foreach.
4466         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4467         from foreach.
4468         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4469         foreach.
4470         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4471         "struct" from foreach.
4472         * ada-lang.c (create_excep_cond_exprs)
4473         (ada_exception_catchpoint_cond_string): Remove "struct" from
4474         foreach.
4475
4476 2019-05-03  Tom Tromey  <tromey@adacore.com>
4477
4478         * ada-exp.y (convert_char_literal): Check suffix of each
4479         enumerator.
4480
4481 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4482
4483         PR ada/21406:
4484         * ada-exp.y (yywrap): Don't define.
4485         * ada-lex.l (%option): Add noyywrap
4486         (yywrap): Remove.
4487
4488 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4489
4490         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4491         _WIN32_WINNT to the XP level, unless already defined to a higher
4492         level.
4493
4494         * unittests/parse-connection-spec-selftests.c:
4495         * ser-tcp.c:
4496         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4497         override.
4498
4499         * symfile.c (find_separate_debug_file): Remove colon from the
4500         drive spec of DOS/Windows file names of the target, so that the
4501         file name produced from DEBUGDIR and the target's directory will
4502         be valid on DOS/Windows systems.
4503
4504 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4505
4506         * rust-lang.c (val_print_struct): Handle printing structures
4507         containing strings.
4508
4509 2019-05-02  Tom Tromey  <tromey@adacore.com>
4510
4511         * valarith.c (_initialize_valarith): Remove.
4512
4513 2019-05-01  Tom Tromey  <tromey@adacore.com>
4514
4515         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4516         bitfields.
4517
4518 2019-05-01  Tom Tromey  <tromey@adacore.com>
4519
4520         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4521         for big-endian copies.
4522
4523 2019-04-30  Ali Tamur  <tamur@google.com>
4524         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4525         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4526         (read_3_bytes): New function.
4527
4528 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4529
4530         * windows-nat.c (main_thread_id): Delete.
4531         (handle_output_debug_string): Replace main_thread_id by
4532         current_event.dwThreadId.
4533         (fake_create_process): Likewise.
4534         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4535         Do not set main_thread_id.
4536         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4537         current_event.dwThreadId.
4538         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4539
4540 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4541
4542         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4543         Use current_event.dwThreadId instead of main_thread_id.
4544
4545 2019-04-30  Tom Tromey  <tromey@adacore.com>
4546
4547         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4548         (create_excep_cond_exprs): Iterate over program spaces.
4549         (ada_exception_catchpoint_cond_string): Examine all minimal
4550         symbols for exception types.
4551
4552 2019-04-30  Tom Tromey  <tromey@adacore.com>
4553
4554         PR c++/24470:
4555         * dwarf2read.c (process_structure_scope): Handle case where type
4556         has template parameters but no symbol was created.
4557
4558 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4559             Chris January  <chris.january@arm.com>
4560
4561         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4562         qualifier.
4563         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4564
4565 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4566
4567         * f-typeprint.c (f_print_type): Update rules for printing
4568         whitespace.
4569         (f_type_print_varspec_suffix): Likewise.
4570
4571 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4572             Chris January  <chris.january@arm.com>
4573
4574         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4575         function arguments.
4576
4577 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4578
4579         * f-lang.c (build_fortran_types): Change name of void type to
4580         lower case.
4581         * f-typeprint.c (f_type_print_base): Print the name of the void
4582         type, rather than a fixed string.
4583         * f-valprint.c (f_decorations): Use lower case void string.
4584
4585 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4586             Chris January  <chris.january@arm.com>
4587
4588         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4589         types for Fortran.
4590
4591 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4592             Chris January  <chris.january@arm.com>
4593             David Lecomber  <david.lecomber@arm.com>
4594
4595         * f-exp.y (BINOP_INTRINSIC): New token.
4596         (exp): New parser rule handling BINOP_INTRINSIC.
4597         (f77_keywords): Add new builtin procedures.
4598         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4599         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4600         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4601         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4602         (print_unop_subexp_f): New function.
4603         (print_binop_subexp_f): New function.
4604         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4605         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4606         (dump_subexp_body_f): Likewise.
4607         (operator_check_f): Likewise.
4608         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4609         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4610
4611 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4612
4613         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4614         UNOP_KIND.
4615         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4616         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4617         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4618         (operator_length_f): New fuction.
4619         (print_subexp_f): New function.
4620         (op_name_f): New function.
4621         (dump_subexp_body_f): New function.
4622         (operator_check_f): New function.
4623         (exp_descriptor_f): Replace standard expression handling functions
4624         with new functions.
4625         * gdb/fortran-operator.def: New file.
4626         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4627         * gdb/std-operator.def: Remove UNOP_KIND.
4628
4629 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4630
4631         * std-operator.def: Remove unbalanced, stray double quote
4632         character.
4633
4634 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4635             Chris January  <chris.january@arm.com>
4636             Daniel Everett  <daniel.everett@arm.com>
4637             Nick Forrington  <nick.forrington@arm.com>
4638             Richard Bunt  <richard.bunt@arm.com>
4639
4640         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4641         of depth when printing anonymous structs or unions.
4642         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4643         Don't print either the top-level value, or the children if the
4644         max-depth is exceeded.
4645         (ppscm_print_children): When printing the key of a map, allow one
4646         extra level of depth.
4647         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4648         print either the top-level value, or the children if the max-depth
4649         is exceeded.
4650         (print_children): When printing the key of a map, allow one extra
4651         level of depth.
4652         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4653         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4654         (user_print_options): Initialise max_depth field.
4655         (val_print_scalar_or_string_type_p): New function.
4656         (val_print): Check to see if the max depth has been reached.
4657         (val_print_check_max_depth): Define new function.
4658         (show_print_max_depth): New function.
4659         (_initialize_valprint): Add 'print max-depth' option.
4660         * valprint.h (struct value_print_options) <max_depth>: New field.
4661         (val_print_check_max_depth): Declare new function.
4662         * NEWS: Document new feature.
4663
4664 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4665
4666         * ada-lang.c (ada_language_defn): Initialise new field.
4667         * c-lang.c (c_is_string_type_p): New function.
4668         (c_language_defn): Initialise new field.
4669         (cplus_language_defn): Initialise new field.
4670         (asm_language_defn): Initialise new field.
4671         (minimal_language_defn): Initialise new field.
4672         * c-lang.h (c_is_string_type_p): Declare new function.
4673         * d-lang.c (d_language_defn): Initialise new field.
4674         * f-lang.c (f_is_string_type_p): New function.
4675         (f_language_defn): Initialise new field.
4676         * go-lang.c (go_is_string_type_p): New function.
4677         (go_language_defn): Initialise new field.
4678         * language.c (default_is_string_type_p): New function.
4679         (unknown_language_defn): Initialise new field.
4680         (auto_language_defn): Initialise new field.
4681         * language.h (struct language_defn) <la_is_string_type_p>: New
4682         member variable.
4683         (default_is_string_type_p): Declare new function.
4684         * m2-lang.c (m2_language_defn): Initialise new field.
4685         * objc-lang.c (objc_language_defn): Initialise new field.
4686         * opencl-lang.c (opencl_language_defn): Initialise new field.
4687         * p-lang.c (pascal_is_string_type_p): New function.
4688         (pascal_language_defn): Initialise new field.
4689         * rust-lang.c (rust_is_string_type_p): New function.
4690         (rust_language_defn): Initialise new field.
4691
4692 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4693
4694         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4695         New field.
4696         * ada-lang.c (ada_language_defn): Initialise new field.
4697         * c-lang.c (c_language_defn): Likewise.
4698         (cplus_language_defn): Likewise.
4699         (asm_language_defn): Likewise.
4700         (minimal_language_defn): Likewise.
4701         * d-lang.c (d_language_defn): Likewise.
4702         * f-lang.c (f_language_defn): Likewise.
4703         * go-lang.c (go_language_defn): Likewise.
4704         * language.c (unknown_language_defn): Likewise.
4705         (auto_language_defn): Likewise.
4706         * m2-lang.c (m2_language_defn): Likewise.
4707         * objc-lang.c (objc_language_defn): Likewise.
4708         * opencl-lang.c (opencl_language_defn): Likewise.
4709         * p-lang.c (pascal_language_defn): Likewise.
4710         * rust-lang.c (rust_language_defn): Likewise.
4711
4712 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4713
4714         * ada-lang.c (ada_is_character_type): Change return type to bool.
4715         (ada_is_string_type): Likewise.
4716         * ada-lang.h (ada_is_character_type): Update declaration
4717         (ada_is_string_type): Likewise.
4718
4719 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4720
4721         Support style in 'frame|thread apply'
4722
4723         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4724         * record.c (record_start, record_stop): Update callers of
4725         execute_command_to_string with false.
4726         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4727         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4728         methods.
4729         (class string_file): New constructor with term_out parameter.
4730         Override methods term_out and can_emit_style_escape.  New member
4731         term_out.
4732         (class stdio_file): Override can_emit_style_escape.
4733         (class tee_file): Override term_out and can_emit_style_escape.
4734         * utils.h (can_emit_style_escape): Remove.
4735         * utils.c (can_emit_style_escape): Likewise.
4736         Update all callers of can_emit_style_escape (SOMESTREAM) to
4737         SOMESTREAM->can_emit_style_escape.
4738         * source-cache.c (source_cache::get_source_lines): Likewise.
4739         * stack.c (frame_apply_command_count): Call execute_command_to_string
4740         passing the term_out characteristic of the current gdb_stdout.
4741         * thread.c (thr_try_catch_cmd): Likewise.
4742         * top.c (execute_command_to_string): pass term_out parameter
4743         to construct the string_file for the command output.
4744         * ui-file.c (term_cli_styling): New function (most code moved
4745         from utils.c can_emit_style_escape).
4746         (string_file::string_file, string_file::can_emit_style_escape,
4747         stdio_file::can_emit_style_escape, tee_file::term_out,
4748         tee_file::can_emit_style_escape): New functions.
4749
4750 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4751
4752         * NEWS: Mention the new set|show may-call-functions.
4753         * infcall.c (may_call_functions_p): New variable.
4754         (show_may_call_functions_p): New function.
4755         (call_function_by_hand_dummy): Throws an error if not
4756         may-call-functions.
4757         (_initialize_infcall): Call add_setshow_boolean_cmd for
4758         may-call-functions.
4759
4760 2019-04-25  Keith Seitz  <keiths@redhat.com>
4761
4762         PR c++/24367
4763         * cp-support.c (inspect_type): Don't attempt substitutions
4764         of symbol with the same name.
4765
4766 2019-04-25  Tom Tromey  <tromey@adacore.com>
4767
4768         PR gdb/24475:
4769         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4770         static.
4771
4772 2019-04-25  Tom Tromey  <tromey@adacore.com>
4773
4774         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4775         rvalue reference.
4776         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4777         (gdb_xml_parser::parse): Use std::move.
4778         * python/python-internal.h (gdbpy_convert_exception): Take a const
4779         reference.
4780         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4781         std::move.
4782         * python/py-utils.c (gdbpy_convert_exception): Take a const
4783         reference.
4784         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4785         Use std::move.
4786         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4787         Use std::move.
4788         * mi/mi-main.c (mi_print_exception): Take a const reference.
4789         * main.c (handle_command_errors): Take a const reference.
4790         * linespec.c (parse_linespec): Use std::move.
4791         * infcall.c (run_inferior_call): Use std::move.
4792         (call_function_by_hand_dummy): Use std::move.
4793         * exec.c (try_open_exec_file): Use std::move.
4794         * exceptions.h (exception_print, exception_fprintf)
4795         (exception_print_same): Update.
4796         * exceptions.c (print_exception, exception_print)
4797         (exception_fprintf, exception_print_same): Change parameters to
4798         const reference.
4799         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4800         * common/new-op.c: Use std::move.
4801         * common/common-exceptions.h (struct gdb_exception): Add move
4802         constructor.
4803         (struct gdb_exception_error, struct gdb_exception_quit, struct
4804         gdb_quit_bad_alloc): Change constructor to move constructor.
4805         (throw_exception): Change parameter to rvalue reference.
4806         * common/common-exceptions.c (throw_exception): Take rvalue
4807         reference.
4808         * cli/cli-interp.c (safe_execute_command): Use std::move.
4809         * breakpoint.c (insert_bp_location, location_to_sals): Use
4810         std::move.
4811
4812 2019-04-25  Tom Tromey  <tromey@adacore.com>
4813
4814         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4815         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4816         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4817         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4818         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4819         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4820         guile/scm-value.c: Use unpack.
4821         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4822         gdbscm_gdb_exception.
4823         (gdbscm_throw_gdb_exception): Likewise.
4824         (struct gdbscm_gdb_exception): New.
4825         (unpack): New function.
4826         (gdbscm_wrap): Use unpack.
4827
4828 2019-04-25  Tom Tromey  <tromey@adacore.com>
4829
4830         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4831         (gdb_rl_callback_handler): Use std::move.
4832         * common/common-exceptions.h (struct gdb_exception): Add move
4833         assignment operator.
4834         (throw_exception_sjlj): Change "exception" to const reference.
4835         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4836         (throw_exception_sjlj): Change "exception" to const reference.
4837
4838 2019-04-25  Tom Tromey  <tromey@adacore.com>
4839
4840         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4841         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4842         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4843         Update.
4844         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4845         Update.
4846         * mi/mi-interp.c (mi_interp::exec): Update.
4847         * linespec.c (parse_linespec): Update.
4848         * infcall.c (run_inferior_call): Update.
4849         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4850         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4851         (gdbscm_lookup_global_symbol): Update.
4852         * guile/scm-param.c (gdbscm_parameter_value): Update.
4853         * guile/scm-frame.c (gdbscm_frame_read_register)
4854         (gdbscm_frame_read_var): Update.
4855         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4856         * exec.c (try_open_exec_file): Update.
4857         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4858         (gdb_rl_callback_handler): Update.
4859         * common/common-exceptions.h (exception_none): Don't declare.
4860         * common/common-exceptions.c (exception_none): Don't define.
4861         (struct catcher) <exception>: Update.
4862         * cli/cli-interp.c (safe_execute_command): Update.
4863         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4864
4865 2019-04-25  Ali Tamur  <tamur@google.com>
4866
4867         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4868         (read_attribute_value): Likewise.
4869         (dwarf2_read_addr_index): Update comment.
4870         (read_str_index): Add DW_FORM_strx.
4871         (dwarf2_string_attr): Likewise.
4872         (dwarf2_const_value_attr): Likewise.
4873         (dump_die_shallow): Likewise.
4874         (dwarf2_fetch_constant_bytes): Likewise.
4875         (skip_form_bytes): Likewise.
4876         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4877
4878 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4879
4880         PR corefiles/11608
4881         PR corefiles/18187
4882         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4883         OFFSET.  Verify if current mapping contains an ELF header.
4884         (linux_find_memory_regions_full): Adjust call to
4885         dump_mapping_p.
4886
4887 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4888             Kang Li <kanglictf@gmail.com>
4889
4890         PR gdb/21600
4891
4892         * dwarf2-frame.c (read_initial_length): Be consistent about using
4893         unsigned representation of length.
4894         (decode_frame_entry_1): Likewise.  Check for wraparound of
4895         end pointer as well as buffer overflow.
4896
4897 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4898
4899         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4900         "vq".
4901
4902 2019-04-24  Tom Tromey  <tromey@adacore.com>
4903
4904         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4905
4906 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4907
4908         * s12z-tdep.c (s12z_unwind_pc): Delete.
4909         (s12z_unwind_sp): Delete.
4910         (s12z_gdbarch_init): Don't register deleted functions with
4911         gdbarch.
4912
4913 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4914
4915         * rl78-tdep.c (rl78_unwind_sp): Delete.
4916         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4917
4918 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4919
4920         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4921         (xstormy16_unwind_pc): Delete.
4922         (xstormy16_dummy_id): Delete.
4923         (xstormy16_gdbarch_init): Don't register deleted functions with
4924         gdbarch.
4925
4926 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4927
4928         * vax-tdep.c (vax_unwind_pc): Delete.
4929         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4930
4931 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4932
4933         * v850-tdep.c (v850_unwind_sp): Delete.
4934         (v850_unwind_pc): Delete.
4935         (v850_dummy_id): Delete.
4936         (v850_gdbarch_init): Don't register deleted functions with
4937         gdbarch.
4938
4939 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4940
4941         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4942         (tilegx_unwind_pc): Delete.
4943         (tilegx_unwind_dummy_id): Delete.
4944         (tilegx_gdbarch_init): Don't register deleted functions with
4945         gdbarch.
4946
4947 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4948
4949         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4950         (tic6x_dummy_id): Delete.
4951         (tic6x_gdbarch_init): Don't register deleted functions with
4952         gdbarch.
4953
4954 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4955
4956         * sparc-tdep.c (sparc_unwind_pc): Delete.
4957         (sparc32_gdbarch_init): Don't register deleted function with
4958         gdbarch.
4959
4960 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4961
4962         * sh-tdep.c (sh_unwind_sp): Delete.
4963         (sh_unwind_pc): Delete.
4964         (sh_dummy_id): Delete.
4965         (sh_gdbarch_init): Don't register deleted functions with
4966         gdbarch.
4967
4968 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4969
4970         * score-tdep.c (score_unwind_sp): Delete.
4971         (score_unwind_pc): Delete.
4972         (score_dummy_id): Delete.
4973         (score_gdbarch_init): Don't register deleted functions with
4974         gdbarch.
4975
4976 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4977
4978         * rx-tdep.c (rx_unwind_pc): Delete.
4979         (rx_unwind_sp): Delete.
4980         (rx_dummy_id): Delete.
4981         (rx_gdbarch_init): Don't register deleted functions with
4982         gdbarch.  Update comment.
4983
4984 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4985
4986         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4987         (rs6000_dummy_id): Delete.
4988         (rs6000_gdbarch_init): Don't register deleted functions with
4989         gdbarch.
4990
4991 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4992
4993         * or1k-tdep.c (or1k_dummy_id): Delete.
4994         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4995
4996 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4997
4998         * nios2-tdep.c (nios2_dummy_id): Delete.
4999         (nios2_unwind_sp): Delete.
5000         (nios2_gdbarch_init): Don't register deleted functions with
5001         gdbarch.
5002
5003 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5004
5005         * nds32-tdep.c (nds32_dummy_id): Delete.
5006         (nds32_unwind_pc): Delete.
5007         (nds32_unwind_sp): Delete.
5008         (nds32_gdbarch_init): Don't register deleted functions with
5009         gdbarch.
5010
5011 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5012
5013         * msp430-tdep.c (msp430_unwind_pc): Delete.
5014         (msp430_unwind_sp): Delete.
5015         (msp430_dummy_id): Delete.
5016         (msp430_gdbarch_init): Don't register deleted functions with
5017         gdbarch.
5018
5019 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5020
5021         * moxie-tdep.c (moxie_unwind_sp): Delete.
5022         (moxie_unwind_pc): Delete.
5023         (moxie_dummy_id): Delete.
5024         (moxie_gdbarch_init): Don't register deleted functions with
5025         gdbarch.
5026
5027 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5028
5029         * mn10300-tdep.c (mn10300_dummy_id): Delete.
5030         (mn10300_unwind_pc): Delete.
5031         (mn10300_unwind_sp): Delete.
5032         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
5033         mn10300_unwind_sp.
5034         (mn10300_frame_unwind_init): Don't register deleted functions with
5035         gdbarch.
5036
5037 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5038
5039         * mep-tdep.c (mep_unwind_pc): Delete.
5040         (mep_unwind_sp): Delete.
5041         (mep_dummy_id): Delete.
5042         (mep_gdbarch_init): Don't register deleted functions with
5043         gdbarch.
5044
5045 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5046
5047         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
5048         (m68hc11_unwind_sp): Delete.
5049         (m68hc11_gdbarch_init): Don't register deleted functions with
5050         gdbarch.
5051
5052 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5053
5054         * m32r-tdep.c (m32r_unwind_sp): Delete.
5055         (m32r_unwind_pc): Delete.
5056         (m32r_dummy_id): Delete.
5057         (m32r_gdbarch_init): Don't register deleted functions with
5058         gdbarch.
5059
5060 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5061
5062         * m32c-tdep.c (m32c_unwind_pc): Delete.
5063         (m32c_unwind_sp): Delete.
5064         (m32c_dummy_id): Delete.
5065         (m32c_gdbarch_init): Don't register deleted functions with
5066         gdbarch.
5067
5068 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5069
5070         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
5071         (lm32_unwind_pc): Delete.
5072         (lm32_dummy_id): Delete.
5073         (lm32_gdbarch_init): Don't register deleted functions with
5074         gdbarch.
5075
5076 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5077
5078         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
5079         (iq2000_unwind_pc): Delete.
5080         (iq2000_dummy_id): Delete.
5081         (iq2000_gdbarch_init): Don't register deleted functions with
5082         gdbarch.
5083
5084 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5085
5086         * nds32-tdep.c (nds32_type_align): Delete.
5087         (nds32_push_dummy_call): Use type_align instead.
5088
5089 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5090
5091         * arm-tdep.c (arm_type_align): Only handle vector override case.
5092         (arm_push_dummy_call): Use type_align.
5093         (arm_gdbarch_init): Register arm_type_align gdbarch function.
5094
5095 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5096
5097         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
5098         case.
5099         (pass_on_stack): Use type_align.
5100         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
5101         function.
5102
5103 2019-04-23  Tom Tromey  <tromey@adacore.com>
5104
5105         * dwarf2read.c (line_header::file_name_at): Remove unused
5106         overload.
5107
5108 2019-04-23  Tom de Vries  <tdevries@suse.de>
5109
5110         PR gdb/24438
5111         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
5112         invocation.
5113
5114
5115 2019-03-27  Ali Tamur  <tamur@google.com>
5116
5117         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
5118         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
5119         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
5120         (dwarf_expr_context::get_addr_index): Likewise
5121         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
5122         (symbol_needs_eval_context::get_addr_index): Likewise
5123         (disassemble_dwarf_expression): Add DW_OP_addrx
5124         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
5125         (read_cutu_die_from_dwo): Update comment
5126         (skip_one_die): Add DW_FORM_addrx
5127         (read_attribute_value): Likewise
5128         (var_decode_location): Add DW_OP_addrx
5129         (dwarf2_const_value_attr): Add DW_FORM_addrx
5130         (dump_die_shallow): Likewise
5131         (dwarf2_fetch_constant_bytes): Likewise
5132         (decode_locdesc): Add DW_OP_addrx
5133         (skip_form_bytes): Add DW_FORM_addrx
5134
5135 2019-04-22  Ali Tamur  <tamur@google.com>
5136
5137         * MAINTAINERS (Write After Approval): Add self.
5138
5139 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
5140
5141         * solib-svr4.c (get_svr4_info): Add pspace parameter.
5142         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
5143         (open_symbol_file_object): Likewise.
5144         (svr4_default_sos): Add info parameter.
5145         (svr4_read_so_list): Likewise.
5146         (svr4_current_sos_direct): Adjust functions calls to pass down
5147         info.
5148         (svr4_current_sos_1): Add info parameter.
5149         (svr4_current_sos): Call get_svr4_info, pass info down to
5150         svr4_current_sos_1.
5151         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
5152         get_svr4_info.
5153         (svr4_in_dynsym_resolve_code): Pass current_program_space to
5154         get_svr4_info.
5155         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
5156         to get_svr4_info.
5157         (probes_table_remove_objfile_probes): Likewise.
5158         (register_solib_event_probe): Add info parameter.
5159         (solist_update_incremental): Pass info parameter down to
5160         svr4_read_so_list.
5161         (disable_probes_interface): Add info parameter.
5162         (svr4_handle_solib_event): Pass current_program_space to
5163         get_svr4_info.  Adjust disable_probes_interface cleanup.
5164         (svr4_create_probe_breakpoints): Add info parameter, pass it
5165         down to register_solib_event_probe.
5166         (svr4_create_solib_event_breakpoints): Add info parameter,
5167         pass it down to svr4_create_probe_breakpoints.
5168         (enable_break): Pass info down to
5169         svr4_create_solib_event_breakpoints.
5170         (svr4_solib_create_inferior_hook): Pass current_program_space to
5171         get_svr4_info.
5172         (svr4_clear_solib): Likewise.
5173
5174 2019-04-22  Pedro Alves  <palves@redhat.com>
5175
5176         * solib-svr4.c (svr4_free_objfile_observer): New.
5177         (probe_and_action::objfile): New field.
5178         (probes_table_htab_remove_objfile_probes)
5179         (probes_table_remove_objfile_probes): New functions.
5180         (register_solib_event_probe): Add 'objfile' parameter.  Store it
5181         in the new probe_and_action.  Don't store the probe in 'lookup'.
5182         (svr4_create_probe_breakpoints): Pass objfile to
5183         register_solib_event_probe.
5184         (_initialize_svr4_solib): Register a free_objfile observer.
5185
5186 2019-04-19  Tom Tromey  <tom@tromey.com>
5187
5188         * common/queue.h: Remove.
5189
5190 2019-04-19  Tom Tromey  <tom@tromey.com>
5191
5192         * event-loop.c: Don't include "common/queue.h".
5193
5194 2019-04-19  Tom Tromey  <tom@tromey.com>
5195
5196         * remote.c (remote_target): Use delete.
5197         * remote-notif.h: Include <list>, not "common/queue.h".
5198         (notif_client_p): Remove typedef.
5199         (remote_notif_state): Add constructor, destructor, initializer.
5200         <notif_queue>: Now a std::list.
5201         (remote_notif_state_xfree): Don't declare.
5202         * remote-notif.c (remote_notif_process, handle_notification)
5203         (remote_notif_state_allocate): Update.
5204         (~remote_notif_state): Rename from remote_notif_state_xfree.
5205
5206 2019-04-19  Tom Tromey  <tom@tromey.com>
5207
5208         * symfile.c (reread_symbols): Update.
5209         * objfiles.c (objfile_register_static_link)
5210         (objfile_lookup_static_link): Update
5211         (~objfile) Don't delete static_links.
5212         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5213
5214 2019-04-19  Tom Tromey  <tom@tromey.com>
5215
5216         * type-stack.h (struct type_stack) <insert>: Constify string.
5217         * type-stack.c (type_stack::insert): Constify string.
5218         * gdbtypes.h (lookup_template_type): Update.
5219         (address_space_name_to_int): Update.
5220         * gdbtypes.c (address_space_name_to_int): Make space_identifier
5221         const.
5222         (lookup_template_type): Make name const.
5223         * c-exp.y: Update rules.
5224         (lex_one_token, classify_name, classify_inner_name)
5225         (c_print_token): Update.
5226         * p-exp.y: Update rules.
5227         (yylex): Update.
5228         * f-exp.y: Update rules.
5229         (yylex): Update.
5230         * d-exp.y: Update rules.
5231         (lex_one_token, classify_name, classify_inner_name): Update.
5232         * parse.c (write_dollar_variable, copy_name): Return std::string.
5233         * parser-defs.h (copy_name): Change return type.
5234         * m2-exp.y: Update rules.
5235         (yylex): Update.
5236         * go-exp.y (lex_one_token): Update.
5237         Update rules.
5238         (classify_unsafe_function, classify_packaged_name)
5239         (classify_name, yylex): Update.
5240
5241 2019-04-19  Sergei Trofimovich <siarheit@google.com>
5242
5243         * configure.ac: add --enable-source-highlight switch.
5244         * configure: Regenerate.
5245         * top.c (print_gdb_version): plumb --enable-source-highlight
5246         status to "show configuration".
5247
5248 2019-04-19  Tom Tromey  <tromey@adacore.com>
5249
5250         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5251         Check ADA_TYPE_P.
5252         (empty_record, ada_template_to_fixed_record_type_1)
5253         (template_to_static_fixed_type)
5254         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5255         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5256         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5257         macros.
5258
5259 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5260
5261         PR symtab/24423:
5262         * source.c (print_source_lines_base): Advance "iter" when a
5263         control character is seen.
5264
5265 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5266
5267         * inferior.h (struct infcall_suspend_state_deleter):
5268         Catch exception in destructor to avoid crash.
5269
5270 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5271
5272         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5273         close to the add_com "shell".
5274
5275 2019-04-18  Tom Tromey  <tromey@adacore.com>
5276
5277         * process-stratum-target.h (class process_stratum_target)
5278         <stratum>: Add "final".
5279
5280 2019-04-17  Tom Tromey  <tromey@adacore.com>
5281
5282         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5283         against nullptr before use.
5284
5285 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5286
5287         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5288
5289 2019-04-17  Jim Wilson  <jimw@sifive.com>
5290             Andrew Burgess  <andrew.burgess@embecosm.com>
5291
5292         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5293         code read might fail, assume 4-byte breakpoint in that case.
5294
5295 2019-04-15  Leszek Swirski  <leszeks@google.com>
5296
5297         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5298         rather than a hand-rolled POD check when checking for forced MEMORY
5299         classification.
5300
5301 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5302
5303         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5304         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5305         function.
5306         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5307         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5308         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5309         declaration.
5310
5311 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5312
5313         * aarch64-linux-nat.c
5314         (aarch64_linux_nat_target::thread_architecture): Add override.
5315         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5316         each VQ.
5317
5318 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5319
5320         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5321
5322 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5323
5324         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5325         target types of size 96-bits, add some additional comments, and
5326         check that the builtin type we found was the correct size.
5327
5328 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5329
5330         * utils.c (prompt_for_continue): Don't restore the styling at the
5331         end, as applied_style has the wrong value.  This fixes styling in
5332         long lists of file names that are interrupted by the "Continue?"
5333         prompt.
5334
5335 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5336
5337         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5338         * c-lang.c (c_language_defn): Likewise.
5339         (cplus_language_defn): Likewise.
5340         (asm_language_defn): Likewise.
5341         (minimal_language_defn): Likewise.
5342         * d-lang.c (d_language_defn): Likewise.
5343         * f-lang.c (f_language_defn): Likewise.
5344         * go-lang.c (go_language_defn): Likewise.
5345         * language.c (unknown_language_defn): Likewise.
5346         (auto_language_defn): Likewise.
5347         * language.h (struct language_defn): Remove la_magic field.
5348         (LANG_MAGIC): Delete.
5349         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5350         * objc-lang.c (objc_language_defn): Likewise.
5351         * opencl-lang.c (opencl_language_defn): Likewise.
5352         * p-lang.c (pascal_language_defn): Likewise.
5353         * rust-lang.c (rust_language_defn): Likewise.
5354
5355 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5356
5357         * riscv-tdep.c (riscv_type_align): New function.
5358         (riscv_type_alignment): Delete.
5359         (riscv_arg_location): Use 'type_align'.
5360         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5361
5362 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5363
5364         * gdbtypes.c (type_align): A struct with no non-static fields also
5365         has alignment of 1.
5366
5367 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5368
5369         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5370         component to 0.
5371         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5372         member.
5373         (riscv_struct_info::analyse): New implementation using new
5374         analyse_inner member function.
5375         (riscv_struct_info::field_offset): New member function.
5376         (riscv_struct_info::m_offsets): New member variable.
5377         (riscv_struct_info::analyse_inner): New private member function,
5378         takes the old implementation of riscv_struct_info::analyse but
5379         extended to track field offsets.
5380         (riscv_call_arg_struct): Update the struct folding special cases
5381         to handle cases where empty C++ structs, which are non-zero
5382         length, are found.
5383         (riscv_arg_location): Initialise the length of each location, a
5384         non-zero length now indicates the location is in use.
5385         (riscv_push_dummy_call): Allow for the first location having a
5386         non-zero offset when setting up arguments.
5387         (riscv_return_value): Likewise, but for return values.
5388
5389 2019-04-11  Tom Tromey  <tromey@adacore.com>
5390
5391         * utils.c (internal_vproblem): Make "msg" const.
5392
5393 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5394
5395         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5396         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5397         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5398         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5399
5400 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5401
5402         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5403         function.
5404         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5405         of amd64_collect_native_gregset.
5406         (amd64_linux_nat_target::store_registers): Likewise.
5407
5408 2019-04-10  Tom Tromey  <tom@tromey.com>
5409
5410         * symtab.c (lookup_global_symbol_from_objfile)
5411         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5412         * objfiles.h (class separate_debug_iterator): New.
5413         (class separate_debug_range): New.
5414         (struct objfile) <separate_debug_objfiles>: New method.
5415         (objfile_separate_debug_iterate): Don't declare.
5416         * objfiles.c (separate_debug_iterator::operator++): Rename from
5417         objfile_separate_debug_iterate.
5418         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5419         iterator.
5420         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5421         iterator.
5422
5423 2019-04-10  Tom Tromey  <tom@tromey.com>
5424
5425         * symfile.c (reread_symbols): Remove old comment.
5426         * objfiles.c (free_all_objfiles): Fix a typo.
5427
5428 2019-04-10  Tom Tromey  <tom@tromey.com>
5429
5430         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5431         * minsyms.c (lookup_minimal_symbol): Use foreach.
5432         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5433         (lookup_minimal_symbol_solib_trampoline): Likewise.
5434         * symfile.c (reread_symbols): Use foreach.
5435
5436 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5437             Tom Tromey  <tromey@adacore.com>
5438
5439         PR rust/24414:
5440         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5441         (rust_lex_int_test): Change "value" to be LONGEST.
5442         (rust_lex_tests): Add test for long integer literal.
5443
5444 2019-04-09  Tom Tromey  <tromey@adacore.com>
5445
5446         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5447         to bool.
5448         (extended_remote_target::attach): Update.
5449         (remote_target::remote_notice_new_inferior): Update.
5450         (remote_target::add_current_inferior_and_thread): Update.
5451         * inferior.c (exit_inferior_1): Use "false".
5452         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5453
5454 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5455
5456         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5457         the "start" command.
5458
5459 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5460
5461         * python/py-inferior.c (infpy_thread_from_thread_handle):
5462         Adjust comments to reflect renaming of thread_from_thread_handle
5463         to thread_from_handle.  Adjust keywords.  Fix type error message.
5464         (inferior_object_methods): Add thread_from_handle.  Retain
5465         thread_from_thread_handle, but mark it as deprecated.
5466
5467 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5468
5469         * gdbthread.h (find_thread_by_handle): Revise declaration.
5470         * thread.c (find_thread_by_handle): Likewise.  Adjust
5471         implementation too.
5472         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5473         support for buffer objects as handles.
5474
5475 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5476
5477         * python/py-infthread.c (thpy_thread_handle): New function.
5478         (thread_object_methods): Register thpy_thread_handle.
5479
5480 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5481
5482         * gdbthread.h (thread_to_thread_handle): Declare.
5483         * thread.c (gdbtypes.h): Include.
5484         (thread_to_thread_handle): New function.
5485
5486         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5487         (target_thread_info_to_thread_handle): Declare.
5488         * target.c (target_thread_info_to_thread_handle): New function.
5489         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5490         * target-delegates.c: Regenerate.
5491
5492         * linux-thread-db.c (class thread_db_target): Add method
5493         thread_info_to_thread_handle.
5494         (thread_db_target::thread_info_to_thread_handle): Define.
5495         * remote.c (class remote_target): Add new method
5496         thread_info_to_thread_handle.
5497         (remote_target::thread_info_to_thread_handle): Define.
5498
5499 2019-04-08  Pedro Alves  <palves@redhat.com>
5500
5501         * common/common-exceptions.c (throw_exception): Don't create
5502         named object to throw; throw directly.
5503         (throw_it): Likewise.  Don't initialize gdb_exception::message
5504         here, with new; pass FMT and AP to the ctor instead.
5505         * common/common-exceptions.h: Include <string>.
5506         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5507         const char *, va_list)): New ctor.  Use std::make_shared.
5508         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5509         errors)): Delete.
5510         (gdb_exception_error::gdb_exception_error(enum errors, const char
5511         *, va_list)): New.
5512         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5513         Add assertion.
5514         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5515         errors)): Delete.
5516         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5517         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5518         Add assertion.
5519
5520 2019-04-08  Tom Tromey  <tom@tromey.com>
5521
5522         * valops.c (value_rtti_indirect_type): Replace throw_exception
5523         with throw.
5524         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5525         with throw.
5526         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5527         throw.
5528         * target.c (target_translate_tls_address): Replace throw_exception
5529         with throw.
5530         * stack.c (frame_apply_command_count): Replace throw_exception
5531         with throw.
5532         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5533         throw.
5534         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5535         with throw.
5536         * rs6000-tdep.c (rs6000_frame_cache)
5537         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5538         * remote.c: Replace throw_exception with throw.
5539         * record-full.c (record_full_message, record_full_wait_1)
5540         (record_full_restore): Replace throw_exception with throw.
5541         * record-btrace.c:
5542         (get_thread_current_frame_id, record_btrace_start_replaying)
5543         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5544         (cmd_record_btrace_start): Replace throw_exception with throw.
5545         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5546         throw.
5547         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5548         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5549         * linespec.c:
5550         (find_linespec_symbols): Replace throw_exception with throw.
5551         * infrun.c (displaced_step_prepare, resume): Replace
5552         throw_exception with throw.
5553         * infcmd.c (post_create_inferior): Replace throw_exception with
5554         throw.
5555         * inf-loop.c (inferior_event_handler): Replace throw_exception
5556         with throw.
5557         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5558         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5559         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5560         (get_prev_frame_always, get_frame_pc_if_available)
5561         (get_frame_address_in_block_if_available, get_frame_language):
5562         Replace throw_exception with throw.
5563         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5564         throw_exception with throw.
5565         * eval.c (fetch_subexp_value, evaluate_var_value)
5566         (evaluate_funcall, evaluate_subexp_standard): Replace
5567         throw_exception with throw.
5568         * dwarf2loc.c (call_site_find_chain)
5569         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5570         Replace throw_exception with throw.
5571         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5572         with throw.
5573         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5574         throw.
5575         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5576         * completer.c (complete_line_internal): Replace throw_exception
5577         with throw.
5578         * compile/compile-object-run.c (compile_object_run): Replace
5579         throw_exception with throw.
5580         * cli/cli-script.c (process_next_line): Replace throw_exception
5581         with throw.
5582         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5583         (btrace_enable, btrace_maint_update_pt_packets): Replace
5584         throw_exception with throw.
5585         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5586         throw_exception with throw.
5587         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5588         throw_exception with throw.
5589         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5590         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5591         * aarch64-tdep.c (aarch64_make_prologue_cache)
5592         (aarch64_make_stub_cache): Replace throw_exception with throw.
5593
5594 2019-04-08  Tom Tromey  <tom@tromey.com>
5595
5596         * common/common-exceptions.c (throw_exception): Rename from
5597         throw_exception_cxx.  Remove old copy.  Make argument const.
5598         (throw_it): Create and throw exception objects directly.
5599         * common/common-exceptions.h (throw_exception): Make argument
5600         const.
5601         (struct gdb_exception_error): Add constructor.
5602         (struct gdb_exception_quit): Add constructor.
5603
5604 2019-04-08  Tom Tromey  <tom@tromey.com>
5605
5606         * common/common-exceptions.h (exception_rethrow): Don't declare.
5607         (TRY_SJLJ): Update comment.
5608         (TRY, CATCH, END_CATCH): Remove.
5609         * common/common-exceptions.c (exception_rethrow): Remove.
5610
5611 2019-04-08  Tom Tromey  <tom@tromey.com>
5612
5613         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5614         Remove.
5615         (gdb_exception_error): Rename from
5616         gdb_exception_RETURN_MASK_ERROR.
5617         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5618         (gdb_quit_bad_alloc): Update.
5619         * aarch64-tdep.c: Update.
5620         * ada-lang.c: Update.
5621         * ada-typeprint.c: Update.
5622         * ada-valprint.c: Update.
5623         * amd64-tdep.c: Update.
5624         * arch-utils.c: Update.
5625         * break-catch-throw.c: Update.
5626         * breakpoint.c: Update.
5627         * btrace.c: Update.
5628         * c-varobj.c: Update.
5629         * cli/cli-cmds.c: Update.
5630         * cli/cli-interp.c: Update.
5631         * cli/cli-script.c: Update.
5632         * common/common-exceptions.c: Update.
5633         * common/new-op.c: Update.
5634         * common/selftest.c: Update.
5635         * compile/compile-c-symbols.c: Update.
5636         * compile/compile-cplus-symbols.c: Update.
5637         * compile/compile-object-load.c: Update.
5638         * compile/compile-object-run.c: Update.
5639         * completer.c: Update.
5640         * corelow.c: Update.
5641         * cp-abi.c: Update.
5642         * cp-support.c: Update.
5643         * cp-valprint.c: Update.
5644         * darwin-nat.c: Update.
5645         * disasm-selftests.c: Update.
5646         * dtrace-probe.c: Update.
5647         * dwarf-index-cache.c: Update.
5648         * dwarf-index-write.c: Update.
5649         * dwarf2-frame-tailcall.c: Update.
5650         * dwarf2-frame.c: Update.
5651         * dwarf2loc.c: Update.
5652         * dwarf2read.c: Update.
5653         * eval.c: Update.
5654         * event-loop.c: Update.
5655         * event-top.c: Update.
5656         * exec.c: Update.
5657         * f-valprint.c: Update.
5658         * fbsd-tdep.c: Update.
5659         * frame-unwind.c: Update.
5660         * frame.c: Update.
5661         * gdbtypes.c: Update.
5662         * gnu-v3-abi.c: Update.
5663         * guile/guile-internal.h: Update.
5664         * guile/scm-block.c: Update.
5665         * guile/scm-breakpoint.c: Update.
5666         * guile/scm-cmd.c: Update.
5667         * guile/scm-disasm.c: Update.
5668         * guile/scm-frame.c: Update.
5669         * guile/scm-lazy-string.c: Update.
5670         * guile/scm-math.c: Update.
5671         * guile/scm-param.c: Update.
5672         * guile/scm-ports.c: Update.
5673         * guile/scm-pretty-print.c: Update.
5674         * guile/scm-symbol.c: Update.
5675         * guile/scm-symtab.c: Update.
5676         * guile/scm-type.c: Update.
5677         * guile/scm-value.c: Update.
5678         * i386-linux-tdep.c: Update.
5679         * i386-tdep.c: Update.
5680         * inf-loop.c: Update.
5681         * infcall.c: Update.
5682         * infcmd.c: Update.
5683         * infrun.c: Update.
5684         * jit.c: Update.
5685         * language.c: Update.
5686         * linespec.c: Update.
5687         * linux-fork.c: Update.
5688         * linux-nat.c: Update.
5689         * linux-tdep.c: Update.
5690         * linux-thread-db.c: Update.
5691         * main.c: Update.
5692         * mi/mi-cmd-break.c: Update.
5693         * mi/mi-cmd-stack.c: Update.
5694         * mi/mi-interp.c: Update.
5695         * mi/mi-main.c: Update.
5696         * objc-lang.c: Update.
5697         * p-valprint.c: Update.
5698         * parse.c: Update.
5699         * ppc-linux-tdep.c: Update.
5700         * printcmd.c: Update.
5701         * python/py-arch.c: Update.
5702         * python/py-breakpoint.c: Update.
5703         * python/py-cmd.c: Update.
5704         * python/py-finishbreakpoint.c: Update.
5705         * python/py-frame.c: Update.
5706         * python/py-framefilter.c: Update.
5707         * python/py-gdb-readline.c: Update.
5708         * python/py-inferior.c: Update.
5709         * python/py-infthread.c: Update.
5710         * python/py-lazy-string.c: Update.
5711         * python/py-linetable.c: Update.
5712         * python/py-objfile.c: Update.
5713         * python/py-param.c: Update.
5714         * python/py-prettyprint.c: Update.
5715         * python/py-progspace.c: Update.
5716         * python/py-record-btrace.c: Update.
5717         * python/py-record.c: Update.
5718         * python/py-symbol.c: Update.
5719         * python/py-type.c: Update.
5720         * python/py-unwind.c: Update.
5721         * python/py-utils.c: Update.
5722         * python/py-value.c: Update.
5723         * python/python.c: Update.
5724         * record-btrace.c: Update.
5725         * record-full.c: Update.
5726         * remote-fileio.c: Update.
5727         * remote.c: Update.
5728         * riscv-tdep.c: Update.
5729         * rs6000-aix-tdep.c: Update.
5730         * rs6000-tdep.c: Update.
5731         * rust-exp.y: Update.
5732         * rust-lang.c: Update.
5733         * s390-tdep.c: Update.
5734         * selftest-arch.c: Update.
5735         * solib-dsbt.c: Update.
5736         * solib-frv.c: Update.
5737         * solib-spu.c: Update.
5738         * solib-svr4.c: Update.
5739         * solib.c: Update.
5740         * sparc64-linux-tdep.c: Update.
5741         * stack.c: Update.
5742         * symfile-mem.c: Update.
5743         * symmisc.c: Update.
5744         * target.c: Update.
5745         * thread.c: Update.
5746         * top.c: Update.
5747         * tracefile-tfile.c: Update.
5748         * tui/tui.c: Update.
5749         * typeprint.c: Update.
5750         * unittests/cli-utils-selftests.c: Update.
5751         * unittests/parse-connection-spec-selftests.c: Update.
5752         * valops.c: Update.
5753         * valprint.c: Update.
5754         * value.c: Update.
5755         * varobj.c: Update.
5756         * windows-nat.c: Update.
5757         * x86-linux-nat.c: Update.
5758         * xml-support.c: Update.
5759
5760 2019-04-08  Tom Tromey  <tom@tromey.com>
5761
5762         * xml-support.c: Use C++ exception handling.
5763         * x86-linux-nat.c: Use C++ exception handling.
5764         * windows-nat.c: Use C++ exception handling.
5765         * varobj.c: Use C++ exception handling.
5766         * value.c: Use C++ exception handling.
5767         * valprint.c: Use C++ exception handling.
5768         * valops.c: Use C++ exception handling.
5769         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5770         handling.
5771         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5772         * typeprint.c: Use C++ exception handling.
5773         * tui/tui.c: Use C++ exception handling.
5774         * tracefile-tfile.c: Use C++ exception handling.
5775         * top.c: Use C++ exception handling.
5776         * thread.c: Use C++ exception handling.
5777         * target.c: Use C++ exception handling.
5778         * symmisc.c: Use C++ exception handling.
5779         * symfile-mem.c: Use C++ exception handling.
5780         * stack.c: Use C++ exception handling.
5781         * sparc64-linux-tdep.c: Use C++ exception handling.
5782         * solib.c: Use C++ exception handling.
5783         * solib-svr4.c: Use C++ exception handling.
5784         * solib-spu.c: Use C++ exception handling.
5785         * solib-frv.c: Use C++ exception handling.
5786         * solib-dsbt.c: Use C++ exception handling.
5787         * selftest-arch.c: Use C++ exception handling.
5788         * s390-tdep.c: Use C++ exception handling.
5789         * rust-lang.c: Use C++ exception handling.
5790         * rust-exp.y: Use C++ exception handling.
5791         * rs6000-tdep.c: Use C++ exception handling.
5792         * rs6000-aix-tdep.c: Use C++ exception handling.
5793         * riscv-tdep.c: Use C++ exception handling.
5794         * remote.c: Use C++ exception handling.
5795         * remote-fileio.c: Use C++ exception handling.
5796         * record-full.c: Use C++ exception handling.
5797         * record-btrace.c: Use C++ exception handling.
5798         * python/python.c: Use C++ exception handling.
5799         * python/py-value.c: Use C++ exception handling.
5800         * python/py-utils.c: Use C++ exception handling.
5801         * python/py-unwind.c: Use C++ exception handling.
5802         * python/py-type.c: Use C++ exception handling.
5803         * python/py-symbol.c: Use C++ exception handling.
5804         * python/py-record.c: Use C++ exception handling.
5805         * python/py-record-btrace.c: Use C++ exception handling.
5806         * python/py-progspace.c: Use C++ exception handling.
5807         * python/py-prettyprint.c: Use C++ exception handling.
5808         * python/py-param.c: Use C++ exception handling.
5809         * python/py-objfile.c: Use C++ exception handling.
5810         * python/py-linetable.c: Use C++ exception handling.
5811         * python/py-lazy-string.c: Use C++ exception handling.
5812         * python/py-infthread.c: Use C++ exception handling.
5813         * python/py-inferior.c: Use C++ exception handling.
5814         * python/py-gdb-readline.c: Use C++ exception handling.
5815         * python/py-framefilter.c: Use C++ exception handling.
5816         * python/py-frame.c: Use C++ exception handling.
5817         * python/py-finishbreakpoint.c: Use C++ exception handling.
5818         * python/py-cmd.c: Use C++ exception handling.
5819         * python/py-breakpoint.c: Use C++ exception handling.
5820         * python/py-arch.c: Use C++ exception handling.
5821         * printcmd.c: Use C++ exception handling.
5822         * ppc-linux-tdep.c: Use C++ exception handling.
5823         * parse.c: Use C++ exception handling.
5824         * p-valprint.c: Use C++ exception handling.
5825         * objc-lang.c: Use C++ exception handling.
5826         * mi/mi-main.c: Use C++ exception handling.
5827         * mi/mi-interp.c: Use C++ exception handling.
5828         * mi/mi-cmd-stack.c: Use C++ exception handling.
5829         * mi/mi-cmd-break.c: Use C++ exception handling.
5830         * main.c: Use C++ exception handling.
5831         * linux-thread-db.c: Use C++ exception handling.
5832         * linux-tdep.c: Use C++ exception handling.
5833         * linux-nat.c: Use C++ exception handling.
5834         * linux-fork.c: Use C++ exception handling.
5835         * linespec.c: Use C++ exception handling.
5836         * language.c: Use C++ exception handling.
5837         * jit.c: Use C++ exception handling.
5838         * infrun.c: Use C++ exception handling.
5839         * infcmd.c: Use C++ exception handling.
5840         * infcall.c: Use C++ exception handling.
5841         * inf-loop.c: Use C++ exception handling.
5842         * i386-tdep.c: Use C++ exception handling.
5843         * i386-linux-tdep.c: Use C++ exception handling.
5844         * guile/scm-value.c: Use C++ exception handling.
5845         * guile/scm-type.c: Use C++ exception handling.
5846         * guile/scm-symtab.c: Use C++ exception handling.
5847         * guile/scm-symbol.c: Use C++ exception handling.
5848         * guile/scm-pretty-print.c: Use C++ exception handling.
5849         * guile/scm-ports.c: Use C++ exception handling.
5850         * guile/scm-param.c: Use C++ exception handling.
5851         * guile/scm-math.c: Use C++ exception handling.
5852         * guile/scm-lazy-string.c: Use C++ exception handling.
5853         * guile/scm-frame.c: Use C++ exception handling.
5854         * guile/scm-disasm.c: Use C++ exception handling.
5855         * guile/scm-cmd.c: Use C++ exception handling.
5856         * guile/scm-breakpoint.c: Use C++ exception handling.
5857         * guile/scm-block.c: Use C++ exception handling.
5858         * guile/guile-internal.h: Use C++ exception handling.
5859         * gnu-v3-abi.c: Use C++ exception handling.
5860         * gdbtypes.c: Use C++ exception handling.
5861         * frame.c: Use C++ exception handling.
5862         * frame-unwind.c: Use C++ exception handling.
5863         * fbsd-tdep.c: Use C++ exception handling.
5864         * f-valprint.c: Use C++ exception handling.
5865         * exec.c: Use C++ exception handling.
5866         * event-top.c: Use C++ exception handling.
5867         * event-loop.c: Use C++ exception handling.
5868         * eval.c: Use C++ exception handling.
5869         * dwarf2read.c: Use C++ exception handling.
5870         * dwarf2loc.c: Use C++ exception handling.
5871         * dwarf2-frame.c: Use C++ exception handling.
5872         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5873         * dwarf-index-write.c: Use C++ exception handling.
5874         * dwarf-index-cache.c: Use C++ exception handling.
5875         * dtrace-probe.c: Use C++ exception handling.
5876         * disasm-selftests.c: Use C++ exception handling.
5877         * darwin-nat.c: Use C++ exception handling.
5878         * cp-valprint.c: Use C++ exception handling.
5879         * cp-support.c: Use C++ exception handling.
5880         * cp-abi.c: Use C++ exception handling.
5881         * corelow.c: Use C++ exception handling.
5882         * completer.c: Use C++ exception handling.
5883         * compile/compile-object-run.c: Use C++ exception handling.
5884         * compile/compile-object-load.c: Use C++ exception handling.
5885         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5886         * compile/compile-c-symbols.c: Use C++ exception handling.
5887         * common/selftest.c: Use C++ exception handling.
5888         * common/new-op.c: Use C++ exception handling.
5889         * cli/cli-script.c: Use C++ exception handling.
5890         * cli/cli-interp.c: Use C++ exception handling.
5891         * cli/cli-cmds.c: Use C++ exception handling.
5892         * c-varobj.c: Use C++ exception handling.
5893         * btrace.c: Use C++ exception handling.
5894         * breakpoint.c: Use C++ exception handling.
5895         * break-catch-throw.c: Use C++ exception handling.
5896         * arch-utils.c: Use C++ exception handling.
5897         * amd64-tdep.c: Use C++ exception handling.
5898         * ada-valprint.c: Use C++ exception handling.
5899         * ada-typeprint.c: Use C++ exception handling.
5900         * ada-lang.c: Use C++ exception handling.
5901         * aarch64-tdep.c: Use C++ exception handling.
5902
5903 2019-04-08  Tom Tromey  <tom@tromey.com>
5904
5905         * xml-support.c (gdb_xml_parser::parse): Update.
5906         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5907         * value.c (show_convenience): Update.
5908         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5909         (test_parse_flags_qcs): Update.
5910         * thread.c (thr_try_catch_cmd): Update.
5911         * target.c (target_translate_tls_address): Update.
5912         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5913         (info_frame_command_core, frame_apply_command_count): Update.
5914         * rust-exp.y (rust_lex_exception_test): Update.
5915         * riscv-tdep.c (riscv_print_one_register_info): Update.
5916         * remote.c (remote_target::enable_btrace): Update.
5917         * record-btrace.c (record_btrace_enable_warn): Update.
5918         * python/py-utils.c (gdbpy_convert_exception): Update.
5919         * printcmd.c (do_one_display, print_variable_and_value): Update.
5920         * mi/mi-main.c (mi_print_exception): Update.
5921         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5922         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5923         * linux-nat.c (linux_nat_target::attach): Update.
5924         * linux-fork.c (class scoped_switch_fork_info): Update.
5925         * infrun.c (displaced_step_prepare): Update.
5926         * infcall.c (call_function_by_hand_dummy): Update.
5927         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5928         * gnu-v3-abi.c (print_one_vtable): Update.
5929         * frame.c (get_prev_frame_always): Update.
5930         * f-valprint.c (info_common_command_for_block): Update.
5931         * exec.c (try_open_exec_file): Update.
5932         * exceptions.c (print_exception, exception_print)
5933         (exception_fprintf, exception_print_same): Update.
5934         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5935         * dwarf-index-cache.c (index_cache::store)
5936         (index_cache::lookup_gdb_index): Update.
5937         * darwin-nat.c (maybe_cache_shell): Update.
5938         * cp-valprint.c (cp_print_value_fields): Update.
5939         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5940         (gcc_cplus_symbol_address): Update.
5941         * compile/compile-c-symbols.c (gcc_convert_symbol)
5942         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5943         * common/selftest.c: Update.
5944         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5945         a std::string.
5946         (exception_try_scope_entry, exception_try_scope_exit): Don't
5947         declare.
5948         (struct exception_try_scope): Remove.
5949         (TRY): Don't use exception_try_scope.
5950         (struct gdb_exception): Add constructor, operator=.
5951         <what>: New method.
5952         (struct gdb_exception_RETURN_MASK_ALL)
5953         (struct gdb_exception_RETURN_MASK_ERROR)
5954         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5955         (struct gdb_quit_bad_alloc): Update.
5956         * common/common-exceptions.c (exception_none): Change
5957         initializer.
5958         (struct catcher) <state, exception>: Initialize inline.
5959         <prev>: Remove member.
5960         (current_catcher): Remove.
5961         (catchers): New global.
5962         (exceptions_state_mc_init): Simplify.
5963         (catcher_pop): Remove.
5964         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5965         (try_scope_depth, exception_try_scope_entry)
5966         (exception_try_scope_exit): Remove.
5967         (throw_exception_sjlj): Update.
5968         (exception_messages, exception_messages_size): Remove.
5969         (throw_it): Simplify.
5970         (gdb_exception_sliced_copy): Remove.
5971         (throw_exception_cxx): Update.
5972         * cli/cli-script.c (script_from_file): Update.
5973         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5974         Update.
5975         * ada-valprint.c (ada_val_print): Update.
5976         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5977         (create_excep_cond_exprs): Update.
5978
5979 2019-04-08  Tom Tromey  <tom@tromey.com>
5980
5981         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5982         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5983         (TRY, CATCH, END_CATCH): Remove some definitions.
5984         * common/common-exceptions.c: Don't use GDB_XCPT.
5985         (catcher_list_size): Remove.
5986         (throw_exception, throw_it): Simplify.
5987
5988 2019-04-05  Tom Tromey  <tom@tromey.com>
5989
5990         Revert the header-sorting patch.
5991         * ft32-tdep.c: Revert.
5992         * frv-tdep.c: Revert.
5993         * frv-linux-tdep.c: Revert.
5994         * frame.c: Revert.
5995         * frame-unwind.c: Revert.
5996         * frame-base.c: Revert.
5997         * fork-child.c: Revert.
5998         * findvar.c: Revert.
5999         * findcmd.c: Revert.
6000         * filesystem.c: Revert.
6001         * filename-seen-cache.h: Revert.
6002         * filename-seen-cache.c: Revert.
6003         * fbsd-tdep.c: Revert.
6004         * fbsd-nat.h: Revert.
6005         * fbsd-nat.c: Revert.
6006         * f-valprint.c: Revert.
6007         * f-typeprint.c: Revert.
6008         * f-lang.c: Revert.
6009         * extension.h: Revert.
6010         * extension.c: Revert.
6011         * extension-priv.h: Revert.
6012         * expprint.c: Revert.
6013         * exec.h: Revert.
6014         * exec.c: Revert.
6015         * exceptions.c: Revert.
6016         * event-top.c: Revert.
6017         * event-loop.c: Revert.
6018         * eval.c: Revert.
6019         * elfread.c: Revert.
6020         * dwarf2read.h: Revert.
6021         * dwarf2read.c: Revert.
6022         * dwarf2loc.c: Revert.
6023         * dwarf2expr.h: Revert.
6024         * dwarf2expr.c: Revert.
6025         * dwarf2-frame.c: Revert.
6026         * dwarf2-frame-tailcall.c: Revert.
6027         * dwarf-index-write.h: Revert.
6028         * dwarf-index-write.c: Revert.
6029         * dwarf-index-common.c: Revert.
6030         * dwarf-index-cache.h: Revert.
6031         * dwarf-index-cache.c: Revert.
6032         * dummy-frame.c: Revert.
6033         * dtrace-probe.c: Revert.
6034         * disasm.h: Revert.
6035         * disasm.c: Revert.
6036         * disasm-selftests.c: Revert.
6037         * dictionary.c: Revert.
6038         * dicos-tdep.c: Revert.
6039         * demangle.c: Revert.
6040         * dcache.h: Revert.
6041         * dcache.c: Revert.
6042         * darwin-nat.h: Revert.
6043         * darwin-nat.c: Revert.
6044         * darwin-nat-info.c: Revert.
6045         * d-valprint.c: Revert.
6046         * d-namespace.c: Revert.
6047         * d-lang.c: Revert.
6048         * ctf.c: Revert.
6049         * csky-tdep.c: Revert.
6050         * csky-linux-tdep.c: Revert.
6051         * cris-tdep.c: Revert.
6052         * cris-linux-tdep.c: Revert.
6053         * cp-valprint.c: Revert.
6054         * cp-support.c: Revert.
6055         * cp-namespace.c: Revert.
6056         * cp-abi.c: Revert.
6057         * corelow.c: Revert.
6058         * corefile.c: Revert.
6059         * continuations.c: Revert.
6060         * completer.h: Revert.
6061         * completer.c: Revert.
6062         * complaints.c: Revert.
6063         * coffread.c: Revert.
6064         * coff-pe-read.c: Revert.
6065         * cli-out.h: Revert.
6066         * cli-out.c: Revert.
6067         * charset.c: Revert.
6068         * c-varobj.c: Revert.
6069         * c-valprint.c: Revert.
6070         * c-typeprint.c: Revert.
6071         * c-lang.c: Revert.
6072         * buildsym.c: Revert.
6073         * buildsym-legacy.c: Revert.
6074         * build-id.h: Revert.
6075         * build-id.c: Revert.
6076         * btrace.c: Revert.
6077         * bsd-uthread.c: Revert.
6078         * breakpoint.h: Revert.
6079         * breakpoint.c: Revert.
6080         * break-catch-throw.c: Revert.
6081         * break-catch-syscall.c: Revert.
6082         * break-catch-sig.c: Revert.
6083         * blockframe.c: Revert.
6084         * block.c: Revert.
6085         * bfin-tdep.c: Revert.
6086         * bfin-linux-tdep.c: Revert.
6087         * bfd-target.c: Revert.
6088         * bcache.c: Revert.
6089         * ax-general.c: Revert.
6090         * ax-gdb.h: Revert.
6091         * ax-gdb.c: Revert.
6092         * avr-tdep.c: Revert.
6093         * auxv.c: Revert.
6094         * auto-load.c: Revert.
6095         * arm-wince-tdep.c: Revert.
6096         * arm-tdep.c: Revert.
6097         * arm-symbian-tdep.c: Revert.
6098         * arm-pikeos-tdep.c: Revert.
6099         * arm-obsd-tdep.c: Revert.
6100         * arm-nbsd-tdep.c: Revert.
6101         * arm-nbsd-nat.c: Revert.
6102         * arm-linux-tdep.c: Revert.
6103         * arm-linux-nat.c: Revert.
6104         * arm-fbsd-tdep.c: Revert.
6105         * arm-fbsd-nat.c: Revert.
6106         * arm-bsd-tdep.c: Revert.
6107         * arch-utils.c: Revert.
6108         * arc-tdep.c: Revert.
6109         * arc-newlib-tdep.c: Revert.
6110         * annotate.h: Revert.
6111         * annotate.c: Revert.
6112         * amd64-windows-tdep.c: Revert.
6113         * amd64-windows-nat.c: Revert.
6114         * amd64-tdep.c: Revert.
6115         * amd64-sol2-tdep.c: Revert.
6116         * amd64-obsd-tdep.c: Revert.
6117         * amd64-obsd-nat.c: Revert.
6118         * amd64-nbsd-tdep.c: Revert.
6119         * amd64-nbsd-nat.c: Revert.
6120         * amd64-nat.c: Revert.
6121         * amd64-linux-tdep.c: Revert.
6122         * amd64-linux-nat.c: Revert.
6123         * amd64-fbsd-tdep.c: Revert.
6124         * amd64-fbsd-nat.c: Revert.
6125         * amd64-dicos-tdep.c: Revert.
6126         * amd64-darwin-tdep.c: Revert.
6127         * amd64-bsd-nat.c: Revert.
6128         * alpha-tdep.c: Revert.
6129         * alpha-obsd-tdep.c: Revert.
6130         * alpha-nbsd-tdep.c: Revert.
6131         * alpha-mdebug-tdep.c: Revert.
6132         * alpha-linux-tdep.c: Revert.
6133         * alpha-linux-nat.c: Revert.
6134         * alpha-bsd-tdep.c: Revert.
6135         * alpha-bsd-nat.c: Revert.
6136         * aix-thread.c: Revert.
6137         * agent.c: Revert.
6138         * addrmap.c: Revert.
6139         * ada-varobj.c: Revert.
6140         * ada-valprint.c: Revert.
6141         * ada-typeprint.c: Revert.
6142         * ada-tasks.c: Revert.
6143         * ada-lang.c: Revert.
6144         * aarch64-tdep.c: Revert.
6145         * aarch64-ravenscar-thread.c: Revert.
6146         * aarch64-newlib-tdep.c: Revert.
6147         * aarch64-linux-tdep.c: Revert.
6148         * aarch64-linux-nat.c: Revert.
6149         * aarch64-fbsd-tdep.c: Revert.
6150         * aarch64-fbsd-nat.c: Revert.
6151         * aarch32-linux-nat.c: Revert.
6152
6153 2019-04-05  Tom Tromey  <tom@tromey.com>
6154
6155         * ft32-tdep.c: Sort headers.
6156         * frv-tdep.c: Sort headers.
6157         * frv-linux-tdep.c: Sort headers.
6158         * frame.c: Sort headers.
6159         * frame-unwind.c: Sort headers.
6160         * frame-base.c: Sort headers.
6161         * fork-child.c: Sort headers.
6162         * findvar.c: Sort headers.
6163         * findcmd.c: Sort headers.
6164         * filesystem.c: Sort headers.
6165         * filename-seen-cache.h: Sort headers.
6166         * filename-seen-cache.c: Sort headers.
6167         * fbsd-tdep.c: Sort headers.
6168         * fbsd-nat.h: Sort headers.
6169         * fbsd-nat.c: Sort headers.
6170         * f-valprint.c: Sort headers.
6171         * f-typeprint.c: Sort headers.
6172         * f-lang.c: Sort headers.
6173         * extension.h: Sort headers.
6174         * extension.c: Sort headers.
6175         * extension-priv.h: Sort headers.
6176         * expprint.c: Sort headers.
6177         * exec.h: Sort headers.
6178         * exec.c: Sort headers.
6179         * exceptions.c: Sort headers.
6180         * event-top.c: Sort headers.
6181         * event-loop.c: Sort headers.
6182         * eval.c: Sort headers.
6183         * elfread.c: Sort headers.
6184         * dwarf2read.h: Sort headers.
6185         * dwarf2read.c: Sort headers.
6186         * dwarf2loc.c: Sort headers.
6187         * dwarf2expr.h: Sort headers.
6188         * dwarf2expr.c: Sort headers.
6189         * dwarf2-frame.c: Sort headers.
6190         * dwarf2-frame-tailcall.c: Sort headers.
6191         * dwarf-index-write.h: Sort headers.
6192         * dwarf-index-write.c: Sort headers.
6193         * dwarf-index-common.c: Sort headers.
6194         * dwarf-index-cache.h: Sort headers.
6195         * dwarf-index-cache.c: Sort headers.
6196         * dummy-frame.c: Sort headers.
6197         * dtrace-probe.c: Sort headers.
6198         * disasm.h: Sort headers.
6199         * disasm.c: Sort headers.
6200         * disasm-selftests.c: Sort headers.
6201         * dictionary.c: Sort headers.
6202         * dicos-tdep.c: Sort headers.
6203         * demangle.c: Sort headers.
6204         * dcache.h: Sort headers.
6205         * dcache.c: Sort headers.
6206         * darwin-nat.h: Sort headers.
6207         * darwin-nat.c: Sort headers.
6208         * darwin-nat-info.c: Sort headers.
6209         * d-valprint.c: Sort headers.
6210         * d-namespace.c: Sort headers.
6211         * d-lang.c: Sort headers.
6212         * ctf.c: Sort headers.
6213         * csky-tdep.c: Sort headers.
6214         * csky-linux-tdep.c: Sort headers.
6215         * cris-tdep.c: Sort headers.
6216         * cris-linux-tdep.c: Sort headers.
6217         * cp-valprint.c: Sort headers.
6218         * cp-support.c: Sort headers.
6219         * cp-namespace.c: Sort headers.
6220         * cp-abi.c: Sort headers.
6221         * corelow.c: Sort headers.
6222         * corefile.c: Sort headers.
6223         * continuations.c: Sort headers.
6224         * completer.h: Sort headers.
6225         * completer.c: Sort headers.
6226         * complaints.c: Sort headers.
6227         * coffread.c: Sort headers.
6228         * coff-pe-read.c: Sort headers.
6229         * cli-out.h: Sort headers.
6230         * cli-out.c: Sort headers.
6231         * charset.c: Sort headers.
6232         * c-varobj.c: Sort headers.
6233         * c-valprint.c: Sort headers.
6234         * c-typeprint.c: Sort headers.
6235         * c-lang.c: Sort headers.
6236         * buildsym.c: Sort headers.
6237         * buildsym-legacy.c: Sort headers.
6238         * build-id.h: Sort headers.
6239         * build-id.c: Sort headers.
6240         * btrace.c: Sort headers.
6241         * bsd-uthread.c: Sort headers.
6242         * breakpoint.h: Sort headers.
6243         * breakpoint.c: Sort headers.
6244         * break-catch-throw.c: Sort headers.
6245         * break-catch-syscall.c: Sort headers.
6246         * break-catch-sig.c: Sort headers.
6247         * blockframe.c: Sort headers.
6248         * block.c: Sort headers.
6249         * bfin-tdep.c: Sort headers.
6250         * bfin-linux-tdep.c: Sort headers.
6251         * bfd-target.c: Sort headers.
6252         * bcache.c: Sort headers.
6253         * ax-general.c: Sort headers.
6254         * ax-gdb.h: Sort headers.
6255         * ax-gdb.c: Sort headers.
6256         * avr-tdep.c: Sort headers.
6257         * auxv.c: Sort headers.
6258         * auto-load.c: Sort headers.
6259         * arm-wince-tdep.c: Sort headers.
6260         * arm-tdep.c: Sort headers.
6261         * arm-symbian-tdep.c: Sort headers.
6262         * arm-pikeos-tdep.c: Sort headers.
6263         * arm-obsd-tdep.c: Sort headers.
6264         * arm-nbsd-tdep.c: Sort headers.
6265         * arm-nbsd-nat.c: Sort headers.
6266         * arm-linux-tdep.c: Sort headers.
6267         * arm-linux-nat.c: Sort headers.
6268         * arm-fbsd-tdep.c: Sort headers.
6269         * arm-fbsd-nat.c: Sort headers.
6270         * arm-bsd-tdep.c: Sort headers.
6271         * arch-utils.c: Sort headers.
6272         * arc-tdep.c: Sort headers.
6273         * arc-newlib-tdep.c: Sort headers.
6274         * annotate.h: Sort headers.
6275         * annotate.c: Sort headers.
6276         * amd64-windows-tdep.c: Sort headers.
6277         * amd64-windows-nat.c: Sort headers.
6278         * amd64-tdep.c: Sort headers.
6279         * amd64-sol2-tdep.c: Sort headers.
6280         * amd64-obsd-tdep.c: Sort headers.
6281         * amd64-obsd-nat.c: Sort headers.
6282         * amd64-nbsd-tdep.c: Sort headers.
6283         * amd64-nbsd-nat.c: Sort headers.
6284         * amd64-nat.c: Sort headers.
6285         * amd64-linux-tdep.c: Sort headers.
6286         * amd64-linux-nat.c: Sort headers.
6287         * amd64-fbsd-tdep.c: Sort headers.
6288         * amd64-fbsd-nat.c: Sort headers.
6289         * amd64-dicos-tdep.c: Sort headers.
6290         * amd64-darwin-tdep.c: Sort headers.
6291         * amd64-bsd-nat.c: Sort headers.
6292         * alpha-tdep.c: Sort headers.
6293         * alpha-obsd-tdep.c: Sort headers.
6294         * alpha-nbsd-tdep.c: Sort headers.
6295         * alpha-mdebug-tdep.c: Sort headers.
6296         * alpha-linux-tdep.c: Sort headers.
6297         * alpha-linux-nat.c: Sort headers.
6298         * alpha-bsd-tdep.c: Sort headers.
6299         * alpha-bsd-nat.c: Sort headers.
6300         * aix-thread.c: Sort headers.
6301         * agent.c: Sort headers.
6302         * addrmap.c: Sort headers.
6303         * ada-varobj.c: Sort headers.
6304         * ada-valprint.c: Sort headers.
6305         * ada-typeprint.c: Sort headers.
6306         * ada-tasks.c: Sort headers.
6307         * ada-lang.c: Sort headers.
6308         * aarch64-tdep.c: Sort headers.
6309         * aarch64-ravenscar-thread.c: Sort headers.
6310         * aarch64-newlib-tdep.c: Sort headers.
6311         * aarch64-linux-tdep.c: Sort headers.
6312         * aarch64-linux-nat.c: Sort headers.
6313         * aarch64-fbsd-tdep.c: Sort headers.
6314         * aarch64-fbsd-nat.c: Sort headers.
6315         * aarch32-linux-nat.c: Sort headers.
6316
6317 2019-04-04  Tom Tromey  <tom@tromey.com>
6318
6319         * varobj.c (varobj_create): Update.
6320         * rust-exp.y (struct rust_parser) <update_innermost_block,
6321         lookup_symbol>: New methods.
6322         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6323         Rename.
6324         (rust_parser::rust_lookup_type)
6325         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6326         * printcmd.c (display_command, do_one_display): Update.
6327         * parser-defs.h (struct parser_state) <parser_state>: Add
6328         "tracker" parameter.
6329         (block_tracker): New member.
6330         (class innermost_block_tracker) <innermost_block_tracker>: Add
6331         "types" parameter.
6332         <reset>: Remove method.
6333         (innermost_block): Don't declare.
6334         (null_post_parser): Update.
6335         * parse.c (innermost_block): Remove global.
6336         (write_dollar_variable): Update.
6337         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6338         Remove "tracker_types" parameter.
6339         (parse_expression): Add "tracker" parameter.
6340         (parse_expression_for_completion): Update.
6341         (null_post_parser): Add "tracker" parameter.
6342         * p-exp.y: Update rules.
6343         * m2-exp.y: Update rules.
6344         * language.h (struct language_defn) <la_post_parser>: Add
6345         "tracker" parameter.
6346         * go-exp.y: Update rules.
6347         * f-exp.y: Update rules.
6348         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6349         parameter.
6350         * d-exp.y: Update rules.
6351         * c-exp.y: Update rules.
6352         * breakpoint.c (set_breakpoint_condition): Create an
6353         innermost_block_tracker.
6354         (watch_command_1): Likewise.
6355         * ada-lang.c (resolve): Add "tracker" parameter.
6356         (resolve_subexp): Likewise.
6357         * ada-exp.y (write_var_from_sym): Update.
6358
6359 2019-04-04  Tom Tromey  <tom@tromey.com>
6360
6361         * type-stack.h: New file.
6362         * type-stack.c: New file.
6363         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6364         type-stack.h.
6365         (insert_into_type_stack, insert_type, push_type, push_type_int)
6366         (insert_type_address_space, pop_type, pop_type_int)
6367         (pop_typelist, pop_type_stack, append_type_stack)
6368         (push_type_stack, get_type_stack, push_typelist)
6369         (follow_type_instance_flags, follow_types): Don't declare.
6370         * parse.c (type_stack): Remove global.
6371         (parse_exp_in_context): Update.
6372         (insert_into_type_stack, insert_type, push_type, push_type_int)
6373         (insert_type_address_space, pop_type, pop_type_int)
6374         (pop_typelist, pop_type_stack, append_type_stack)
6375         (push_type_stack, get_type_stack, push_typelist)
6376         (follow_type_instance_flags, follow_types): Remove (moved to
6377         type-stack.c).
6378         * f-exp.y (type_stack): New global.
6379         Update rules.
6380         (push_kind_type, f_parse): Update.
6381         * d-exp.y (type_stack): New global.
6382         Update rules.
6383         (d_parse): Update.
6384         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6385         Update rules.
6386         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6387         (HFILES_NO_SRCDIR): Add type-stack.h.
6388
6389 2019-04-04  Tom Tromey  <tom@tromey.com>
6390
6391         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6392         (rust_parser::convert_ast_to_expression, rust_parse)
6393         (rust_lex_test_completion, rust_lex_tests): Update.
6394         * parser-defs.h (struct expr_completion_state): New.
6395         (struct parser_state) <parser_state>: Add completion parameter.
6396         <mark_struct_expression, mark_completion_tag>: New methods.
6397         <parse_completion, m_completion_state>: New members.
6398         (prefixify_expression, null_post_parser): Update.
6399         (mark_struct_expression, mark_completion_tag): Don't declare.
6400         * parse.c (parse_completion, expout_last_struct)
6401         (expout_tag_completion_type, expout_completion_name): Remove
6402         globals.
6403         (parser_state::mark_struct_expression)
6404         (parser_state::mark_completion_tag): Now methods.
6405         (prefixify_expression): Add last_struct parameter.
6406         (prefixify_subexp): Likewise.
6407         (parse_exp_1): Update.
6408         (parse_exp_in_context): Add cstate parameter.  Update.
6409         (parse_expression_for_completion): Create an
6410         expr_completion_state.
6411         (null_post_parser): Add "completion" parameter.
6412         * p-exp.y: Update rules.
6413         (yylex): Update.
6414         * language.h (struct language_defn) <la_post_parser>: Add
6415         "completing" parameter.
6416         * go-exp.y: Update rules.
6417         (lex_one_token): Update.
6418         * expression.h (parse_completion): Don't declare.
6419         * d-exp.y: Update rules.
6420         (lex_one_token): Update rules.
6421         * c-exp.y: Update rules.
6422         (lex_one_token): Update.
6423         * ada-lang.c (resolve): Add "parse_completion" parameter.
6424         (resolve_subexp): Likewise.
6425         (ada_resolve_function): Likewise.
6426
6427 2019-04-04  Tom Tromey  <tom@tromey.com>
6428
6429         * parser-defs.h (struct parser_state) <start_arglist,
6430         end_arglist>: New methods.
6431         <arglist_len, m_funcall_chain>: New members.
6432         (arglist_len, start_arglist, end_arglist): Don't declare.
6433         * parse.c (arglist_len, funcall_chain): Remove global.
6434         (start_arglist, end_arglist): Remove functions.
6435         (parse_exp_in_context): Update.
6436         * p-exp.y: Update rules.
6437         * m2-exp.y: Update rules.
6438         * go-exp.y: Update rules.
6439         * f-exp.y: Update rules.
6440         * d-exp.y: Update rules.
6441         * c-exp.y: Update rules.
6442
6443 2019-04-04  Tom Tromey  <tom@tromey.com>
6444
6445         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6446         lex_operator, push_back>: New methods.
6447         Update all rules.
6448         (rust_parser::lex_hex, lex_escape): Rename and update.
6449         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6450         (rust_parser::lex_operator): Rename and update.
6451         (rust_parser::lex_number, rustyylex, rustyyerror)
6452         (rust_lex_test_init, rust_lex_test_sequence)
6453         (rust_lex_test_push_back, rust_lex_tests): Update.
6454         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6455         parameter.
6456         <lexptr, prev_lexptr>: New members.
6457         (lexptr, prev_lexptr): Don't declare.
6458         * parse.c (lexptr, prev_lexptr): Remove globals.
6459         (parse_exp_in_context): Update.
6460         * p-exp.y (yylex, yyerror): Update.
6461         * m2-exp.y (parse_number, yylex, yyerror): Update.
6462         * go-exp.y (lex_one_token, yyerror): Update.
6463         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6464         * d-exp.y (lex_one_token, yyerror): Update.
6465         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6466         (lex_one_token, yyerror): Update.
6467         * ada-lex.l (YY_INPUT): Update.
6468         (rewind_to_char): Update.
6469         * ada-exp.y (yyerror): Update.
6470
6471 2019-04-04  Tom Tromey  <tom@tromey.com>
6472
6473         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6474         * parser-defs.h (struct parser_state) <parser_state>: Add new
6475         parameter.
6476         <comma_terminates>: New member.
6477         (comma_terminates): Don't declare global.
6478         * parse.c (comma_terminates): Remove global.
6479         (parse_exp_in_context): Update.
6480         * p-exp.y (yylex): Update.
6481         * m2-exp.y (yylex): Update.
6482         * go-exp.y (lex_one_token): Update.
6483         * f-exp.y (yylex): Update.
6484         * d-exp.y (lex_one_token): Update.
6485         * c-exp.y (lex_one_token): Update.
6486         * ada-lex.l: Update.
6487
6488 2019-04-04  Tom Tromey  <tom@tromey.com>
6489
6490         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6491         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6492         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6493         * parser-defs.h (paren_depth): Don't declare.
6494         * parse.c (paren_depth): Remove global.
6495         (parse_exp_in_context): Update.
6496         * p-exp.y (paren_depth): New global.
6497         (pascal_parse): Initialize it.
6498         * m2-exp.y (paren_depth): New global.
6499         (m2_parse): Initialize it.
6500         * go-exp.y (paren_depth): New global.
6501         (go_parse): Initialize it.
6502         * f-exp.y (paren_depth): New global.
6503         (f_parse): Initialize it.
6504         * d-exp.y (paren_depth): New global.
6505         (d_parse): Initialize it.
6506         * c-exp.y (paren_depth): New global.
6507         (c_parse): Initialize it.
6508         * ada-lex.l (paren_depth): New global.
6509         (lexer_init): Initialize it.
6510
6511 2019-04-04  Tom Tromey  <tom@tromey.com>
6512
6513         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6514         (rust_parser::convert_ast_to_type)
6515         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6516         * parser-defs.h (struct parser_state) <parser_state>: Add
6517         parameters.  Initialize new members.
6518         <expression_context_block, expression_context_pc>: New members.
6519         * parse.c (expression_context_block, expression_context_pc):
6520         Remove globals.
6521         (parse_exp_in_context): Update.
6522         * p-exp.y: Update all rules.
6523         (yylex): Update.
6524         * m2-exp.y: Update all rules.
6525         (yylex): Update.
6526         * go-exp.y (yylex): Update.
6527         * f-exp.y (yylex): Update.
6528         * d-exp.y: Update all rules.
6529         (yylex): Update.
6530         * c-exp.y: Update all rules.
6531         (lex_one_token, classify_name, yylex, c_parse): Update.
6532         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6533
6534 2019-04-04  Tom Tromey  <tom@tromey.com>
6535
6536         * gdbarch.h, gdbarch.c: Rebuild.
6537         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6538         * stap-probe.h:
6539         (struct stap_parse_info): Replace "parser_state" with
6540         "expr_builder".
6541         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6542         (parser_state): New class.
6543         * parse.c (expr_builder): Rename.
6544         (expr_builder::release): Rename.
6545         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6546         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6547         (write_exp_elt_longcst, write_exp_elt_floatcst)
6548         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6549         (write_exp_string_vector, write_exp_bitstring)
6550         (write_exp_msymbol, mark_struct_expression)
6551         (write_dollar_variable)
6552         (insert_type_address_space, increase_expout_size): Replace
6553         "parser_state" with "expr_builder".
6554         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6555         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6556         "parser_state" with "expr_builder".
6557
6558 2019-04-04  Tom Tromey  <tom@tromey.com>
6559
6560         * rust-exp.y: Replace "parse_language" with method call.
6561         * p-exp.y:
6562         (yylex): Replace "parse_language" with method call.
6563         * m2-exp.y:
6564         (yylex): Replace "parse_language" with method call.
6565         * go-exp.y (classify_name): Replace "parse_language" with method
6566         call.
6567         * f-exp.y (yylex): Replace "parse_language" with method call.
6568         * d-exp.y (lex_one_token): Replace "parse_language" with method
6569         call.
6570         * c-exp.y:
6571         (lex_one_token, classify_name, yylex): Replace "parse_language"
6572         with method call.
6573         * ada-exp.y (find_primitive_type, type_char)
6574         (type_system_address): Replace "parse_language" with method call.
6575
6576 2019-04-04  Tom Tromey  <tom@tromey.com>
6577
6578         * rust-exp.y: Replace "parse_gdbarch" with method call.
6579         * parse.c (write_dollar_variable, insert_type_address_space):
6580         Replace "parse_gdbarch" with method call.
6581         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6582         call.
6583         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6584         call.
6585         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6586         "parse_gdbarch" with method call.
6587         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6588         with method call.
6589         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6590         "parse_gdbarch" with method call.
6591         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6592         "parse_gdbarch" with method call.
6593         * c-exp.y (parse_type, parse_number, classify_name): Replace
6594         "parse_gdbarch" with method call.
6595         * ada-lex.l: Replace "parse_gdbarch" with method call.
6596         * ada-exp.y (parse_type, find_primitive_type, type_char)
6597         (type_system_address): Replace "parse_gdbarch" with method call.
6598
6599 2019-04-04  Tom Tromey  <tom@tromey.com>
6600
6601         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6602         * stap-probe.c (stap_parse_argument): Update.
6603         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6604         initial_size parameter.
6605         * rust-exp.y (rust_lex_tests): Update.
6606         * parse.c (parser_state): Update.
6607         (parse_exp_in_context): Update.
6608         * parser-defs.h (struct parser_state) <parser_state>: Remove
6609         "initial_size" parameter.
6610
6611 2019-04-04  Tom Tromey  <tom@tromey.com>
6612
6613         * parser-defs.h (increase_expout_size): Don't declare.
6614         * parse.c (increase_expout_size): Now static.
6615
6616 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6617
6618         * gnu-nat.c (gnu_nat_target::wait): Fix
6619         target_waitstatus_to_string call.
6620
6621 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6622
6623         * eval.c (evaluate_subexp_standard): Handle internal functions
6624         during Fortran function call handling.
6625
6626 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6627
6628         * NEWS: Mention new internal functions.
6629         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6630         (read_base_type): Use dwarf2_init_complex_target_type.
6631         * value.c (creal_internal_fn): New function.
6632         (cimag_internal_fn): New function.
6633         (_initialize_values): Register new internal functions.
6634
6635 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6636
6637         * infrun.c (stop_all_threads): If debug_infrun, always
6638         trace the wait status after wait_one, using
6639         target_waitstatus_to_string and target_pid_to_str.
6640         (handle_inferior_event): Replace various trace of
6641         wait status kind by a single trace.
6642         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6643         wait status kind image by target_waitstatus_to_string.
6644         * target/waitstatus.c (target_waitstatus_to_string): Fix
6645         obsolete comment.
6646
6647 2019-04-01  Tom Tromey  <tromey@adacore.com>
6648
6649         PR symtab/23331:
6650         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6651
6652 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6653             Pedro Alves  <palves@redhat.com>
6654
6655         * top.c (quit_force): Call 'finalize_values'.
6656         * value.c (finalize_values): New function.
6657         * value.h (finalize_values): Declare.
6658
6659 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6660
6661         * NEWS: Announce $_gdb_major and $_gdb_minor.
6662
6663         * top.c (init_gdb_version_vars): New function.
6664         (gdb_init): Call init_gdb_version_vars.
6665
6666 2019-03-29  Tom Tromey  <tromey@adacore.com>
6667
6668         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6669         help text.  Remove dead code.
6670
6671 2019-03-29  Keith Seitz  <keiths@redhat.com>
6672
6673         From Siddhesh Poyarekar:
6674         * f-lang.h (f77_get_upperbound): Return LONGEST.
6675         (f77_get_lowerbound): Likewise.
6676         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6677         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6678         print them.
6679         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6680         plongest to format print it.
6681         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6682         (f77_get_upperbound): Likewise.
6683         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6684         LOWER_BOUND to LONGEST.
6685         (f77_create_arrayprint_offset_tbl): Likewise.
6686
6687 2019-03-29  Keith Seitz  <keiths@redhat.com>
6688
6689         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6690         %s/pulongest for TYPE_LENGTH instead of %d in format
6691         strings.
6692         * ada-typerint.c (ada_print_type): Likewise.
6693         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6694         * compile/compile-c-support.c (generate_register_struct): Likewise.
6695         * gdbtypes.c (recursive_dump_type): Likewise.
6696         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6697         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6698         instead of %d in format strings.
6699         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6700         to std::min to ULONGEST.
6701         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6702         instead of %d in format strings.
6703         * tracepoint.c (info_scope_command): Likewise.
6704         * typeprint.c (print_offset_data::update)
6705         (print_offset_data::finish): Likewise.
6706         * xtensa-tdep.c (xtensa_store_return_value)
6707         (xtensa_push_dummy_call): Likewise.
6708
6709 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6710
6711         * windows-nat.c (display_selector): Fixed format specifications
6712         for 64-bit Cygwin.
6713
6714 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6715
6716         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6717
6718 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6719
6720         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6721         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6722         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6723         (nios2_linux_init_abi): Install it.
6724
6725 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6726
6727         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6728
6729 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6730
6731         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6732
6733 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6734             Tom Tromey  <tromey@adacore.com>
6735
6736         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6737
6738 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6739
6740         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6741         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6742         method to compute the bounds of range types. Also print "[evaluated]"
6743         if the bounds' values come from a dynamic evaluation.
6744
6745 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6746
6747         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6748         whitespace when pretty printing is on.
6749
6750 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6751
6752         * ppc-linux-nat.c: Add include.
6753
6754 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6755
6756         * NEWS: Mention AArch64 Pointer Authentication.
6757
6758 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6759
6760         * arm-linux-nat.c: Add include.
6761
6762 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6763
6764         * source-cache.c (source_cache::get_source_lines): Re-read
6765         fullname after calling open_source_file.
6766
6767 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6768
6769         * NEWS: Mention TLS support for FreeBSD.
6770
6771 2019-03-25  Tom Tromey  <tromey@adacore.com>
6772
6773         * minsyms.c (BUNCH_SIZE): Update comment.
6774         (~minimal_symbol_reader): Remove old comment.
6775         (compact_minimal_symbols): Update comment.
6776         (minimal_symbol_reader::install): Remove old comment.  Update
6777         other comments.
6778
6779 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6780
6781         * s390-linux-nat.c: Add include.
6782
6783 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6784
6785         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6786         Call linux_get_hwcap.
6787         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6788         Likewise.
6789         (aarch64_linux_get_hwcap): Remove function.
6790         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6791         declaration.
6792         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6793         linux_get_hwcap.
6794         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6795         * linux-tdep.c (linux_get_hwcap): Add function.
6796         (linux_get_hwcap2): Likewise.
6797         * linux-tdep.h (linux_get_hwcap): Add declaration.
6798         (linux_get_hwcap2): Likewise.
6799         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6800         (ppc_linux_get_hwcap2): Likewise.
6801         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6802         linux_get_hwcap.
6803         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6804         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6805         (ppc_linux_nat_target::read_description): Likewise.
6806         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6807         * s390-linux-nat.c: Likewise.
6808         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6809
6810 2019-03-24  Tom Tromey  <tom@tromey.com>
6811
6812         * ada-lang.c (standard_lookup): Simplify initialization.
6813         (ada_lookup_symbol_nonlocal): Simplify return.
6814         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6815         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6816         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6817         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6818         initialization.
6819         * solib.c (solib_global_lookup): Simplify.
6820         * symtab.c (null_block_symbol): Remove.
6821         (symbol_cache_lookup): Simplify returns.
6822         (lookup_language_this): Simplify returns.
6823         (lookup_symbol_aux): Simplify return.
6824         (lookup_local_symbol): Simplify returns.
6825         (lookup_global_symbol_from_objfile): Simplify return.
6826         (lookup_symbol_in_objfile_symtabs)
6827         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6828         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6829         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6830         * cp-namespace.c (cp_lookup_bare_symbol)
6831         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6832         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6833         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6834         (cp_lookup_symbol_via_imports): Simplify initialization.
6835         (find_symbol_in_baseclass): Likewise.
6836         * symtab.h (null_block_symbol): Remove.
6837         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6838         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6839         (d_lookup_symbol_module): Likewise.
6840         (find_symbol_in_baseclass): Simplify initialization.
6841
6842 2019-03-24  Tom Tromey  <tom@tromey.com>
6843
6844         * expression.h: Don't include symtab.h.
6845         (struct block): Forward declare.
6846
6847 2019-03-24  Tom Tromey  <tom@tromey.com>
6848
6849         * c-exp.y (typebase): Remove casts.
6850         * gdbtypes.c (lookup_unsigned_typename, )
6851         (lookup_signed_typename): Remove cast.
6852         * eval.c (parse_to_comma_and_eval): Remove cast.
6853         * parse.c (write_dollar_variable): Remove cast.
6854         * block.h (struct block) <superblock>: Now const.
6855         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6856         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6857         (map_block): Make "block" const.
6858         * symfile.h (struct quick_symbol_functions)
6859         <map_matching_symbols>: Constify block argument to "callback".
6860         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6861         const.
6862         (find_pc_sect_compunit_symtab): Make "b" const.
6863         (find_symbol_at_address): Likewise.
6864         (search_symbols): Likewise.
6865         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6866         (dw2_debug_names_lookup_symbol): Likewise.
6867         (dw2_map_matching_symbols): Update.
6868         * p-valprint.c (pascal_val_print): Remove "block".
6869         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6870         (aux_add_nonlocal_symbols): Make "block" const.
6871         (resolve_subexp): Remove cast.
6872         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6873         const.
6874         (iterate_over_file_blocks): Likewise.
6875         * f-exp.y (%union) <bval>: Remove.
6876         * coffread.c (patch_opaque_types): Make "b" const.
6877         * spu-tdep.c (spu_catch_start): Make "block" const.
6878         * c-valprint.c (print_unpacked_pointer): Remove "block".
6879         * symmisc.c (dump_symtab_1): Make "b" const.
6880         (block_depth): Make "block" const.
6881         * d-exp.y (%union) <bval>: Remove.
6882         * cp-support.h (cp_lookup_rtti_type): Update.
6883         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6884         * psymtab.c (psym_lookup_symbol): Make "block" const.
6885         (maintenance_check_psymtabs): Make "b" const.
6886         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6887         (enumerate_locals, enumerate_args): Update.
6888         * python/py-symtab.c (stpy_global_block): Make "block" const.
6889         (stpy_static_block): Likewise.
6890         * inline-frame.c (block_starting_point_at): Make "new_block"
6891         const.
6892         * block.c (find_block_in_blockvector): Make return type const.
6893         (blockvector_for_pc_sect): Make "b" const.
6894         (find_block_in_blockvector): Make "b" const.
6895
6896 2019-03-23  Tom Tromey  <tom@tromey.com>
6897
6898         * varobj.c (varobj_create): Update.
6899         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6900         * printcmd.c (display_command, do_one_display): Don't reset
6901         innermost_block.
6902         * parser-defs.h (enum innermost_block_tracker_type): Move to
6903         expression.h.
6904         (innermost_block): Update comment.
6905         * parse.c (parse_exp_1): Add tracker_types parameter.
6906         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6907         tracker_types parameter.  Reset innermost_block.
6908         (parse_exp_in_context): Remove.
6909         (parse_expression_for_completion): Update.
6910         * objfiles.c (~objfile): Don't reset expression_context_block or
6911         innermost_block.
6912         * expression.h (enum innermost_block_tracker_type): Move from
6913         parser-defs.h.
6914         (parse_exp_1): Add tracker_types parameter.
6915         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6916         reset innermost_block.
6917
6918 2019-03-23  Tom Tromey  <tom@tromey.com>
6919
6920         * objfiles.h: Include bcache.h.
6921
6922 2019-03-23  Tom Tromey  <tom@tromey.com>
6923
6924         * linespec.c (get_current_search_block): Use
6925         scoped_restore_current_language.
6926         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6927
6928 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6929             Jiong Wang  <jiong.wang@arm.com>
6930
6931         * aarch64-linux-tdep.c
6932         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6933         section.
6934         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6935
6936 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6937             Jiong Wang  <jiong.wang@arm.com>
6938
6939         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6940         instructions.
6941         (aarch64_analyze_prologue_test): Add PACIASP test.
6942         (aarch64_prologue_prev_register): Unmask PC value.
6943
6944 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6945             Jiong Wang  <jiong.wang@arm.com>
6946
6947         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6948         (aarch64_dwarf2_prev_register): Unmask PC value.
6949         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6950         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6951         DW_CFA_AARCH64_negate_ra_state.
6952         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6953
6954 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6955             Jiong Wang  <jiong.wang@arm.com>
6956
6957         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6958         registers.
6959         (aarch64_pseudo_register_name): Likewise.
6960         (aarch64_pseudo_register_type): Likewise.
6961         (aarch64_pseudo_register_reggroup_p): Likewise.
6962         (aarch64_gdbarch_init): Add pauth registers.
6963         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6964         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6965         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6966         (struct gdbarch_tdep): Add regnum for ra_state.
6967
6968 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6969             Jiong Wang  <jiong.wang@arm.com>
6970
6971         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6972
6973 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6974             Jiong Wang  <jiong.wang@arm.com>
6975
6976         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6977         function.
6978         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6979         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6980         (aarch64_gdbarch_init): Add puth registers.
6981         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6982         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6983         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6984
6985 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6986             Jiong Wang  <jiong.wang@arm.com>
6987
6988         * aarch64-linux-nat.c
6989         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6990         * aarch64-linux-tdep.c
6991         (aarch64_linux_core_read_description): Likewise.
6992         (aarch64_linux_get_hwcap): New function.
6993         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6994         (aarch64_linux_get_hwcap): New declaration.
6995
6996 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6997             Jiong Wang  <jiong.wang@arm.com>
6998
6999         * aarch64-linux-nat.c
7000         (aarch64_linux_nat_target::read_description): Add pauth param.
7001         * aarch64-linux-tdep.c
7002         (aarch64_linux_core_read_description): Likewise.
7003         * aarch64-tdep.c (struct target_desc): Add in pauth.
7004         (aarch64_read_description): Add pauth param.
7005         (aarch64_gdbarch_init): Likewise.
7006         * aarch64-tdep.h (aarch64_read_description): Likewise.
7007         * arch/aarch64.c (aarch64_create_target_description): Likewise.
7008         * arch/aarch64.h (aarch64_create_target_description): Likewise.
7009         * features/Makefile: Add new files.
7010         * features/aarch64-pauth.c: New file.
7011         * features/aarch64-pauth.xml: New file.
7012
7013 2019-03-20  Tom Tromey  <tromey@adacore.com>
7014
7015         * infrun.c (handle_inferior_event): Rename from
7016         handle_inferior_event_1.  Create a scoped_value_mark.
7017         (handle_inferior_event): Remove.
7018
7019 2019-03-19  Tom Tromey  <tromey@adacore.com>
7020
7021         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
7022         * infrun.h (print_stop_event): Add "displays" parameter.
7023         * infrun.c (print_stop_event): Add "displays" parameter.
7024
7025 2019-03-19  Pedro Alves  <palves@redhat.com>
7026
7027         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
7028         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
7029         to -1.  Fix TABs vs spaces.
7030         (tui_ui_out::tui_ui_out): Don't initialize fields here.
7031         * tui/tui-out.h (tui_ui_out) Add intro comments.
7032         <m_line, m_start_of_line>: In-class initialize, and add describing
7033         comment.
7034
7035 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
7036
7037         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
7038         variable names.
7039         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
7040
7041 2019-03-18  Pedro Alves  <palves@redhat.com>
7042             Eli Zaretskii <eliz@gnu.org>
7043
7044         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
7045         m_line and m_start_of_line.
7046
7047 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
7048
7049         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
7050         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
7051         it returns a newline.  This fixes a regression in TU mode, whereby
7052         the next line is output on the same screen line as the user input.
7053
7054 2019-03-18  Tom Tromey  <tromey@adacore.com>
7055
7056         * minsyms.c (minimal_symbol_reader::install): Remove call to
7057         obstack_blank.
7058
7059 2019-03-18  Pedro Alves  <palves@redhat.com>
7060
7061         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
7062         New globals.
7063         (apply_style): New, factored out from ...
7064         (apply_ansi_escape): ... this.  Handle reverse video mode.
7065         (tui_set_reverse_mode): New function.
7066         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
7067         * tui/tui-winsource.c (tui_show_source_line): Use
7068         tui_set_reverse_mode instead of setting A_STANDOUT.
7069         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
7070         New setter methods.
7071
7072 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
7073
7074         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
7075         Handle tabs.
7076
7077 2019-03-18  Tom Tromey  <tromey@adacore.com>
7078
7079         * ada-lang.c (empty_array): Add "high" parameter.
7080         (ada_evaluate_subexp): Update.
7081
7082 2019-03-17  Sergei Trofimovich <siarheit@google.com>
7083
7084         * unittests/string_view-selftests.c: Define
7085         _initialize_string_view_selftests unconditionally.
7086
7087 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7088
7089         PR gdb/24350
7090         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
7091
7092 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7093
7094         PR gdb/24351
7095         * windows-nat.c (display_selector): Fix format specifiers.
7096
7097 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
7098
7099         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
7100         tui_refill_source_window instead of tui_refresh_win, to update the
7101         current execution line.  This fixes redisplay of the current line
7102         when stepping through the code with "next" or "step".
7103
7104 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7105
7106         * source-cache.c (source_cache::get_source_lines): Call
7107         find_source_lines to initialize s->nlines.  This fixes vertical
7108         scrolling of TUI source window when the DOWN arrow is pressed.
7109
7110 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7111
7112         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
7113         linux-thread-db.c (_initialize_thread_db): Likewise.
7114
7115 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7116
7117         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
7118         wclrtoeol in tui_show_source_line".  This reverts changes made in
7119         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
7120
7121 2019-03-15  Tom Tromey  <tom@tromey.com>
7122
7123         * symtab.h (struct minimal_symbol): Derive from
7124         general_symbol_info.
7125         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
7126         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
7127         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
7128         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
7129         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
7130         (MSYMBOL_SEARCH_NAME): Update.
7131         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
7132         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
7133         * minsyms.c (minimal_symbol_reader::record_full): Update.
7134
7135 2019-03-15  Tom Tromey  <tom@tromey.com>
7136
7137         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
7138
7139 2019-03-15  Tom Tromey  <tom@tromey.com>
7140
7141         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
7142         unique_xmalloc_ptr.
7143         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
7144         Update.
7145         * minsyms.c (lookup_minimal_symbol_by_pc_section)
7146         (build_minimal_symbol_hash_tables)
7147         (minimal_symbol_reader::install): Update.
7148
7149 2019-03-15  Tom Tromey  <tom@tromey.com>
7150
7151         * symtab.c (create_demangled_names_hash): Update.
7152         (symbol_set_names): Update.
7153         * objfiles.h (struct objfile_per_bfd_storage)
7154         <demangled_names_hash>: Now an htab_up.
7155         * objfiles.c (objfile_per_bfd_storage): Simplify.
7156
7157 2019-03-15  Tom Tromey  <tom@tromey.com>
7158
7159         * objfiles.h (struct objfile_per_bfd_storage): Declare
7160         destructor.
7161         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
7162         New.
7163         (get_objfile_bfd_data): Use new.  Don't initialize
7164         language_of_main.
7165         (free_objfile_per_bfd_storage): Remove.
7166         (objfile_bfd_data_free, objfile::~objfile): Use delete.
7167
7168 2019-03-15  Tom Tromey  <tom@tromey.com>
7169
7170         * symfile.c (reread_symbols): Update.
7171         * objfiles.c (objfile::objfile): Update.
7172         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
7173         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7174         comment.
7175         (minimal_symbol_reader::install): Update.
7176         (terminate_minimal_symbol_table): Remove.
7177         * jit.c (jit_object_close_impl): Update.
7178
7179 2019-03-15  Tom Tromey  <tom@tromey.com>
7180
7181         * minsyms.c (minimal_symbol_reader::record_full): Remove some
7182         initializations.
7183
7184 2019-03-15  Tom Tromey  <tom@tromey.com>
7185
7186         * objfiles.h (struct objfile_per_bfd_storage)
7187         <demangled_hash_languages>: Now a bitset.
7188         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7189         (lookup_minimal_symbol): Update.
7190
7191 2019-03-15  Tom Tromey  <tom@tromey.com>
7192
7193         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7194         Don't return the symbol.
7195         * coffread.c (record_minimal_symbol): Use record_full.
7196
7197 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
7198
7199         The MS-Windows port of ncurses fails to switch to a color pair if
7200         one or both of the colors are the implicit default colors.  This
7201         change records the default colors when TUI is initialized, and
7202         then specifies them explicitly when a color pair uses the default
7203         colors.  This allows color styling in TUI mode on MS-Windows.
7204
7205         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
7206         ncurses_norm_attr.
7207         (tui_initialize_io) [__MINGW32__]: Record the default terminal
7208         colors in ncurses_norm_attr.
7209         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7210         "none", replace it with the default color recorded in
7211         ncurses_norm_attr.
7212
7213 2019-03-14  Tom Tromey  <tromey@adacore.com>
7214
7215         * source-cache.h (class source_cache) <get_source_lines>: Return
7216         std::string.
7217         * source-cache.c (source_cache::extract_lines): Handle case where
7218         first_pos==npos.  Return std::string.
7219         (source_cache::get_source_lines): Update.
7220
7221 2019-03-14  Tom Tromey  <tromey@adacore.com>
7222
7223         * NEWS: Add item for "style sources" commands.
7224         * source-cache.c (source_cache::get_source_lines): Check
7225         source_styling.
7226         * cli/cli-style.c (source_styling): New global.
7227         (_initialize_cli_style): Add "style sources" commands.
7228         (show_style_sources): New function.
7229         * cli/cli-style.h (source_styling): Declare.
7230
7231 2019-03-14  Pedro Alves  <palves@redhat.com>
7232             Tom Tromey  <tromey@adacore.com>
7233
7234         * tui/tui-winsource.h (tui_refill_source_window): Declare.
7235         * tui/tui-winsource.c (tui_refill_source_window): New function,
7236         from...
7237         (tui_horizontal_source_scroll): ... here.  Move some logic.
7238         * cli/cli-style.c (set_style_enabled): Notify new observable.
7239         * tui/tui-hooks.c (tui_redisplay_source): New function.
7240         (tui_attach_detach_observers): Attach or detach
7241         tui_redisplay_source.
7242         * observable.h (source_styling_changed): New observable.
7243         * observable.c: Define source_styling_changed observable.
7244
7245 2019-03-13  Tom Tromey  <tromey@adacore.com>
7246
7247         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7248         (i386_gnu_nat_target::store_registers): Update.
7249         * target-debug.h (target_debug_print_std_string): New macro.
7250         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7251         * windows-tdep.c (display_one_tib): Update.
7252         * tui/tui-stack.c (tui_make_status_line): Update.
7253         * top.c (print_inferior_quit_action): Update.
7254         * thread.c (thr_try_catch_cmd): Update.
7255         (add_thread_with_info): Update.
7256         (thread_target_id_str): Update.
7257         (thr_try_catch_cmd): Update.
7258         (thread_command): Update.
7259         (thread_find_command): Update.
7260         * record-btrace.c (record_btrace_target::info_record)
7261         (record_btrace_resume_thread, record_btrace_target::resume)
7262         (record_btrace_cancel_resume, record_btrace_step_thread)
7263         (record_btrace_target::wait, record_btrace_target::wait)
7264         (record_btrace_target::wait, record_btrace_target::stop): Update.
7265         * progspace.c (print_program_space): Update.
7266         * process-stratum-target.c
7267         (process_stratum_target::thread_address_space): Update.
7268         * linux-fork.c (linux_fork_mourn_inferior)
7269         (detach_checkpoint_command, info_checkpoints_command)
7270         (linux_fork_context): Update.
7271         (linux_fork_detach): Update.
7272         (class scoped_switch_fork_info): Update.
7273         (delete_checkpoint_command): Update.
7274         * infrun.c (follow_fork_inferior): Update.
7275         (follow_fork_inferior): Update.
7276         (proceed_after_vfork_done): Update.
7277         (handle_vfork_child_exec_or_exit): Update.
7278         (follow_exec): Update.
7279         (displaced_step_prepare_throw): Update.
7280         (displaced_step_restore): Update.
7281         (start_step_over): Update.
7282         (resume_1): Update.
7283         (clear_proceed_status_thread): Update.
7284         (proceed): Update.
7285         (print_target_wait_results): Update.
7286         (do_target_wait): Update.
7287         (context_switch): Update.
7288         (stop_all_threads): Update.
7289         (restart_threads): Update.
7290         (finish_step_over): Update.
7291         (handle_signal_stop): Update.
7292         (switch_back_to_stepped_thread): Update.
7293         (keep_going_pass_signal): Update.
7294         (print_exited_reason): Update.
7295         (normal_stop): Update.
7296         * inferior.c (inferior_pid_to_str): Change return type.
7297         (print_selected_inferior): Update.
7298         (add_inferior): Update.
7299         (detach_inferior): Update.
7300         * dummy-frame.c (fprint_dummy_frames): Update.
7301         * dcache.c (dcache_info_1): Update.
7302         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7303         (btrace_fetch, btrace_clear): Update.
7304         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7305         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7306         type.
7307         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7308         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7309         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7310         * gdbarch.c, gdbarch.h: Rebuild.
7311         * gdbarch.sh (core_pid_to_str): Change return type.
7312         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7313         return type.
7314         (windows_nat_target::pid_to_str): Change return type.
7315         (windows_delete_thread): Update.
7316         (windows_nat_target::attach): Update.
7317         (windows_nat_target::files_info): Update.
7318         * target-delegates.c: Rebuild.
7319         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7320         return type.
7321         (sol_thread_target::pid_to_str): Change return type.
7322         * remote.c (class remote_target) <pid_to_str>: Change return
7323         type.
7324         (remote_target::pid_to_str): Change return type.
7325         (extended_remote_target::attach, remote_target::remote_stop_ns)
7326         (remote_target::remote_notif_remove_queued_reply)
7327         (remote_target::push_stop_reply, remote_target::disable_btrace):
7328         Update.
7329         (extended_remote_target::attach): Update.
7330         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7331         type.
7332         (gdbsim_target::pid_to_str): Change return type.
7333         * ravenscar-thread.c (struct ravenscar_thread_target)
7334         <pid_to_str>: Change return type.
7335         (ravenscar_thread_target::pid_to_str): Change return type.
7336         * procfs.c (class procfs_target) <pid_to_str>: Change return
7337         type.
7338         (procfs_target::pid_to_str): Change return type.
7339         (procfs_target::attach): Update.
7340         (procfs_target::detach): Update.
7341         (procfs_target::fetch_registers): Update.
7342         (procfs_target::store_registers): Update.
7343         (procfs_target::wait): Update.
7344         (procfs_target::files_info): Update.
7345         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7346         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7347         return type.
7348         (nto_procfs_target::pid_to_str): Change return type.
7349         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7350         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7351         return type.
7352         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7353         (exit_lwp): Update.
7354         (attach_proc_task_lwp_callback, get_detach_signal)
7355         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7356         (linux_nat_target::resume, wait_lwp, stop_callback)
7357         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7358         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7359         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7360         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7361         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7362         type.
7363         (inf_ptrace_target::attach): Update.
7364         (inf_ptrace_target::files_info): Update.
7365         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7366         type.
7367         (go32_nat_target::pid_to_str): Change return type.
7368         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7369         (gnu_nat_target::wait): Update.
7370         (gnu_nat_target::wait): Update.
7371         (gnu_nat_target::resume): Update.
7372         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7373         (fbsd_nat_target::wait): Update.
7374         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7375         type.
7376         (darwin_nat_target::attach): Update.
7377         * corelow.c (class core_target) <pid_to_str>: Change return type.
7378         (core_target::pid_to_str): Change return type.
7379         * target.c (normal_pid_to_str): Change return type.
7380         (default_pid_to_str): Likewise.
7381         (target_pid_to_str): Change return type.
7382         (target_translate_tls_address): Update.
7383         (target_announce_detach): Update.
7384         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7385         return type.
7386         (bsd_uthread_target::pid_to_str): Change return type.
7387         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7388         type.
7389         (bsd_kvm_target::pid_to_str): Change return type.
7390         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7391         return type.
7392         (aix_thread_target::pid_to_str): Change return type.
7393         * target.h (struct target_ops) <pid_to_str>: Change return type.
7394         (target_pid_to_str, normal_pid_to_str): Likewise.
7395         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7396         type.
7397         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7398         type.
7399         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7400         return type.
7401         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7402         type.
7403         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7404         type.
7405         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7406         return type.
7407
7408 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7409
7410         * NEWS: Mention that the new default MI version is 3.  Mention
7411         changes to the output of commands and events that deal with
7412         multi-location breakpoints.
7413         * breakpoint.c: Include "mi/mi-out.h".
7414         (print_one_breakpoint): Change output syntax if using MI version
7415         >= 3.
7416         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7417         New.
7418         (mi_multi_location_breakpoint_output_fixed): New.
7419         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7420         (mi_cmd_fix_multi_location_breakpoint_output): New.
7421         (mi_multi_location_breakpoint_output_fixed): New.
7422         * mi/mi-cmds.c (mi_cmds): Register command
7423         -fix-multi-location-breakpoint-output.
7424         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7425         interpreter "mi".
7426
7427 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7428
7429         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7430         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7431         instantiate mi_ui_out based on interpreter name.
7432         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7433         * mi/mi-main.c (mi_load_progress): Likewise.
7434
7435 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7436
7437         * NEWS: Combine separate "New targets" sections for 8.3.
7438
7439 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7440
7441         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7442         (ppcfbsd_init_abi): Install gdbarch
7443         "fetch_tls_load_module_address" and "get_thread_local_address"
7444         methods.
7445
7446 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7447
7448         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7449         (riscv_fbsd_init_abi): Install gdbarch
7450         "fetch_tls_load_module_address" and "get_thread_local_address"
7451         methods.
7452
7453 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7454
7455         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7456         (i386fbsd_init_abi): Install gdbarch
7457         "fetch_tls_load_module_address" and "get_thread_local_address"
7458         methods.
7459
7460 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7461
7462         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7463         (amd64fbsd_init_abi): Install gdbarch
7464         "fetch_tls_load_module_address" and "get_thread_local_address"
7465         methods.
7466
7467 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7468
7469         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7470         (struct fbsd_pspace_data): New type.
7471         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7472         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7473         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7474         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7475         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7476
7477 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7478
7479         * gdbtypes.c (lookup_struct_elt): New function.
7480         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7481         * gdbtypes.h (struct struct_elt): New type.
7482         (lookup_struct_elt): New prototype.
7483
7484 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7485
7486         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7487         remove disabled code block.
7488
7489 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7490
7491         * gdbarch.sh (get_thread_local_address): New method.
7492         * gdbarch.h, gdbarch.c: Regenerate.
7493         * target.c (target_translate_tls_address): Use
7494         gdbarch_get_thread_local_address if present instead of
7495         target::get_thread_local_address.
7496
7497 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7498
7499         * target.h (target::get_thread_local_address): Update comment.
7500
7501 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7502
7503         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7504         objfile->separate_debug_objfile_backlink if not NULL.
7505
7506 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7507
7508         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7509         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7510         (amd64bsd_store_inferior_registers): Likewise.
7511         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7512         Enable segment base registers.
7513         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7514         PT_GETFSBASE and PT_GETGSBASE.
7515         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7516         PT_SETGSBASE.
7517         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7518         segment base registers.
7519         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7520
7521 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7522
7523         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7524         Update calls to i386_target_description to add 'segments'
7525         parameter.
7526         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7527         add segment base registers.
7528         * arch/i386.c (i386_create_target_description): Add 'segments'
7529         parameter to enable segment base registers.
7530         * arch/i386.h (i386_create_target_description): Likewise.
7531         * features/i386/32bit-segments.xml: New file.
7532         * features/i386/32bit-segments.c: Generate.
7533         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7534         call to i386_target_description to add 'segments' parameter.
7535         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7536         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7537         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7538         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7539         if feature is present.
7540         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7541         Add 'segments' parameter to call to i386_target_description.
7542         (i386_target_description): Add 'segments' parameter to enable
7543         segment base registers.
7544         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7545         to call to i386_target_description.
7546         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7547         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7548         Define I386_NUM_REGS.
7549         (i386_target_description): Add 'segments' parameter to enable
7550         segment base registers.
7551
7552 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7553
7554         PR/24325
7555         * source-cache.c: #undef open and close, to avoid unresolved
7556         externals during linking.
7557
7558 2019-03-12  Tom Tromey  <tromey@adacore.com>
7559
7560         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7561         const.  Add initializers.
7562         (_initialize_remote): Don't initialize ptid globals.
7563
7564 2019-03-12  Pedro Alves  <palves@redhat.com>
7565
7566         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7567
7568 2019-03-12  Pedro Alves  <palves@redhat.com>
7569
7570         * cp-name-parser.y (main): Remove unused 'len' variable.
7571
7572 2019-03-12  Tom Tromey  <tromey@adacore.com>
7573
7574         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7575         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7576
7577 2019-03-12  Tom Tromey  <tromey@adacore.com>
7578
7579         * linux-nat.c (iterate_over_lwps): Update.
7580         (stop_callback): Remove parameter.
7581         (stop_wait_callback, detach_callback, resume_set_callback)
7582         (select_singlestep_lwp_callback, set_ignore_sigint)
7583         (status_callback, resumed_callback, resume_clear_callback)
7584         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7585         data parameter.
7586         (linux_nat_target::detach, linux_nat_target::resume)
7587         (linux_stop_and_wait_all_lwps, select_event_lwp)
7588         (linux_nat_filter_event, linux_nat_wait_1)
7589         (linux_nat_target::kill, linux_nat_target::stop)
7590         (linux_nat_target::stop): Update.
7591         (linux_nat_resume_callback): Change type.
7592         (resume_stopped_resumed_lwps, count_events_callback)
7593         (select_event_lwp_callback): Likewise.
7594         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7595         * arm-linux-nat.c (struct update_registers_data): Remove.
7596         (update_registers_callback): Change type.
7597         (arm_linux_insert_hw_breakpoint1): Update.
7598         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7599         parameter.
7600         (x86_linux_dr_set_addr): Update.
7601         (x86_linux_dr_set_control): Update.
7602         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7603         (iterate_over_lwps): Use gdb::function_view.
7604         * nat/aarch64-linux-hw-point.c (struct
7605         aarch64_dr_update_callback_param): Remove.
7606         (debug_reg_change_callback): Change type.
7607         (aarch64_notify_debug_reg_change): Update.
7608         * s390-linux-nat.c (s390_refresh_per_info): Update.
7609
7610 2019-03-11  Tom Tromey  <tromey@adacore.com>
7611
7612         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7613         redundant assignment to "this_cu".
7614
7615 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7616
7617         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7618
7619 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7620
7621         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7622         from...
7623         (rank_one_type): ... this.
7624
7625 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7626
7627         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7628         from...
7629         (rank_one_type): ... this.
7630
7631 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7632
7633         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7634         from...
7635         (rank_one_type): ... this.
7636
7637 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7638
7639         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7640         from...
7641         (rank_one_type): ... this.
7642
7643 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7644
7645         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7646         from...
7647         (rank_one_type): ... this.
7648
7649 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7650
7651         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7652         from...
7653         (rank_one_type): ... this.
7654
7655 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7656
7657         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7658         from...
7659         (rank_one_type): ... this.
7660
7661 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7662
7663         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7664         from...
7665         (rank_one_type): ... this.
7666
7667 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7668
7669         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7670         from...
7671         (rank_one_type): ... this.
7672
7673 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7674
7675         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7676         from...
7677         (rank_one_type): ... this.
7678
7679 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7680
7681         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7682         from...
7683         (rank_one_type): ... this.
7684
7685 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7686
7687         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7688         from...
7689         (rank_one_type): ... this.
7690
7691 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7692
7693         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7694         inferior-events' shows the example events.
7695
7696 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7697
7698         Support styling on native MS-Windows console
7699
7700         PR/24315
7701         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7702         on MS-Windows if $TERM is not defined.
7703
7704         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7705
7706         * posix-hdep.c (gdb_console_fputs):
7707         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7708         functions.
7709         * ui-file.h (gdb_console_fputs): Add prototype.
7710
7711         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7712         back to fputs only if the former returns zero.
7713
7714 2019-03-07  Tom Tromey  <tom@tromey.com>
7715
7716         * symmisc.c (print_symbol_bcache_statistics): Update.
7717         (print_objfile_statistics): Update.
7718         * symfile.c (allocate_symtab): Update.
7719         * stabsread.c: Don't include bcache.h.
7720         * psymtab.h (struct psymbol_bcache): Don't declare.
7721         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7722         (psymbol_bcache_init, psymbol_bcache_free)
7723         (psymbol_bcache_get_bcache): Don't declare.
7724         * psymtab.c (struct psymbol_bcache): Remove.
7725         (psymtab_storage::psymtab_storage): Update.
7726         (psymtab_storage::~psymtab_storage): Update.
7727         (psymbol_bcache_init, psymbol_bcache_free)
7728         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7729         (add_psymbol_to_bcache): Update.
7730         (allocate_psymtab): Update.
7731         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7732         macro_cache>: No longer pointers.
7733         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7734         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7735         * macrotab.c (macro_bcache): Update.
7736         * macroexp.c: Don't include bcache.h.
7737         * gdbtypes.c (check_types_worklist): Update.
7738         (types_deeply_equal): Remove TRY/CATCH.  Update.
7739         * elfread.c (elf_symtab_read): Update.
7740         * dwarf2read.c: Don't include bcache.h.
7741         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7742         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7743         (print_bcache_statistics, bcache_memory_used): Don't declare.
7744         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7745         methods.  Rename all data members.
7746         * bcache.c (struct bcache): Move to bcache.h.
7747         (bcache::expand_hash_table): Rename from expand_hash_table.
7748         (bcache): Remove.
7749         (bcache::insert): Rename from bcache_full.
7750         (bcache::compare): Rename from bcache_compare.
7751         (bcache_xmalloc): Remove.
7752         (bcache::~bcache): Rename from bcache_xfree.
7753         (bcache::print_statistics): Rename from print_bcache_statistics.
7754         (bcache::memory_used): Rename from bcache_memory_used.
7755
7756 2019-03-07  Pedro Alves  <palves@redhat.com>
7757
7758         * infrun.c (normal_stop): Also check for
7759         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7760
7761 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7762
7763         * f-lang.c (value_from_host_double): Moved to...
7764         * value.c (value_from_host_double): ...here.
7765         * value.h (value_from_host_double): Declare.
7766         * guile/scm-math.c (vlscm_convert_typed_number): Use
7767         value_from_host_double.
7768         (vlscm_convert_number): Likewise.
7769         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7770         * python/py-value.c (convert_value_from_python): Likewise.
7771
7772 2019-03-06  Tom Tromey  <tom@tromey.com>
7773
7774         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7775
7776 2019-03-06  Tom Tromey  <tom@tromey.com>
7777
7778         * utils.h (free_current_contents): Don't declare.
7779         * utils.c (free_current_contents): Remove.
7780
7781 2019-03-06  Tom Tromey  <tom@tromey.com>
7782
7783         * top.c (quit_force): Update.
7784         * main.c (captured_command_loop): Update.
7785         * common/new-op.c (operator new): Update.
7786         * common/common-exceptions.c (struct catcher)
7787         <save_cleanup_chain>: Remove member.
7788         (exceptions_state_mc_init): Update.
7789         (exception_try_scope_entry): Return nullptr.
7790         (exception_try_scope_exit, exception_rethrow)
7791         (throw_exception_sjlj, throw_exception_cxx): Update.
7792         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7793         (all_cleanups, do_cleanups, discard_cleanups)
7794         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7795         (restore_cleanups, restore_final_cleanups): Don't declare.
7796         (do_final_cleanups): Remove parameter.
7797         * common/cleanups.c (cleanup_chain, make_cleanup)
7798         (make_cleanup_dtor, all_cleanups, do_cleanups)
7799         (discard_my_cleanups, discard_cleanups)
7800         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7801         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7802         (null_cleanup): Remove.
7803         (do_final_cleanups): Remove parameter.
7804
7805 2019-03-06  Tom Tromey  <tom@tromey.com>
7806
7807         * remote.c (remote_target::remote_parse_stop_reply): Use
7808         unique_xmalloc_ptr.
7809
7810 2019-03-06  Tom Tromey  <tom@tromey.com>
7811
7812         * stabsread.c (struct stabs_field_info): Rename from field_info.
7813         <list, fnlist>: Add initializers.
7814         <obstack>: New member.
7815         (read_member_functions, read_struct_fields, read_baseclasses):
7816         Allocate on obstack.  Don't use cleanups.
7817         (read_one_struct_field, read_member_functions, read_struct_fields)
7818         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7819         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7820         (read_struct_type): Update.
7821
7822 2019-03-06  Tom Tromey  <tom@tromey.com>
7823
7824         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7825         * common/filestuff.h (make_cleanup_close): Don't declare.
7826         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7827         Remove.
7828
7829 2019-03-06  Tom Tromey  <tom@tromey.com>
7830
7831         * solib-aix.c: Use make_scope_exit.
7832
7833 2019-03-06  Tom Tromey  <tom@tromey.com>
7834
7835         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7836         Use make_scope_exit.
7837
7838 2019-03-06  Tom Tromey  <tom@tromey.com>
7839
7840         * solib-svr4.c (disable_probes_interface): Remove parameter.
7841         (svr4_handle_solib_event): Use make_scope_exit.
7842
7843 2019-03-06  Tom Tromey  <tom@tromey.com>
7844
7845         * remote.c (struct stop_reply_deleter): Remove.
7846         (stop_reply_up): Update.
7847         (struct stop_reply): Derive from notif_event.  Don't typedef.
7848         <regcache>: Now a std::vector.
7849         (stop_reply_xfree): Remove.
7850         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7851         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7852         (remote_target::discard_pending_stop_replies): Use delete.
7853         (remote_target::remote_parse_stop_reply): Update.
7854         (remote_target::process_stop_reply): Update.
7855         * remote-notif.h (struct notif_event): Add virtual destructor.
7856         Remove "dtr" member.
7857         (struct notif_client) <alloc_event>: Return a unique_ptr.
7858         (notif_event_xfree): Don't declare.
7859         (notif_event_up): New typedef.
7860         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7861         (notif_event_xfree, do_notif_event_xfree): Remove.
7862         (remote_notif_state_xfree): Update.
7863
7864 2019-03-06  Tom Tromey  <tom@tromey.com>
7865
7866         * infrun.c (displaced_step_clear_cleanup): Now a
7867         forward_scope_exit type.
7868         (displaced_step_prepare_throw): Update.
7869         (displaced_step_fixup): Update.
7870
7871 2019-03-06  Tom Tromey  <tom@tromey.com>
7872
7873         * inferior.h (class inferior): Update comment.
7874         * gdbthread.h (class thread_info): Update comment.
7875
7876 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7877             Tom Tromey  <tom@tromey.com>
7878
7879         * stabsread.h (struct stab_section_list): Remove.
7880         (coffstab_build_psymtabs): Update.
7881         * dbxread.c (symbuf_sections): Now a std::vector.
7882         (sect_idx): New global.
7883         (fill_symbuf): Update.
7884         (coffstab_build_psymtabs): Change type of stabsects parameter.
7885         Update.
7886         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7887         std::vector.
7888         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7889         (coff_locate_sections): Update.
7890         (coff_symfile_read): Remove cleanups.  Update.
7891         (init_stringtab): Add storage parameter.
7892         (free_stringtab, free_stringtab_cleanup): Remove.
7893         (init_lineno): Add storage parameter.
7894         (free_linetab, free_linetab_cleanup): Remove.
7895
7896 2019-03-06  Pedro Alves  <palves@redhat.com>
7897
7898         * linux-fork.c (fork_info::clobber_regs): Delete.
7899         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7900         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7901         comment.  Adjust.
7902         (scoped_switch_fork_info::scoped_switch_fork_info)
7903         (checkpoint_command, linux_fork_context): Adjust
7904         fork_save_infrun_state calls.
7905
7906 2019-03-06  Pedro Alves  <palves@redhat.com>
7907
7908         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7909         (inf_has_multiple_threads): Return 'bool' and rewrite using
7910         inferior_info::threads().
7911
7912 2019-03-06  Pedro Alves  <palves@redhat.com>
7913
7914         * linux-fork.c: Include <list>.
7915         (fork_list): Now a std::list instance.
7916         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7917         (forks_exist_p, find_last_fork): Adjust.
7918         (new_fork): Delete.
7919         (one_fork_p): New.
7920         (add_fork): Adjust.
7921         (free_fork): Delete, folded into fork_info::~fork_info().
7922         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7923         Adjust.
7924         (init_fork_list): Delete.
7925         (linux_fork_killall, linux_fork_mourn_inferior)
7926         (linux_fork_detach, info_checkpoints_command): Adjust.
7927         (_initialize_linux_fork): No longer call init_fork_list.
7928
7929 2019-03-06  Pedro Alves  <palves@redhat.com>
7930
7931         * linux-fork.c (new_fork): New, split out of ...
7932         (add_fork): ... this.  Return void.  Move "first fork" special
7933         case from here, to ...
7934         (checkpoint_command): ... here.
7935         * linux-linux.h (add_fork): Return void.
7936
7937 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7938
7939         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7940
7941 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7942             Chris January  <chris.january@arm.com>
7943             David Lecomber  <david.lecomber@arm.com>
7944
7945         * f-exp.y: New token, UNOP_INTRINSIC.
7946         (exp): New pattern using UNOP_INTRINSIC token.
7947         (f77_keywords): Add 'abs' keyword.
7948         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7949         (value_from_host_double): New function.
7950         (evaluate_subexp_f): Support UNOP_ABS.
7951
7952 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7953
7954         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7955         types.
7956
7957 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7958
7959         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7960         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7961         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7962
7963 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7964
7965         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7966
7967 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7968             Chris January  <chris.january@arm.com>
7969
7970         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7971         * f-exp.y: Define 'KIND' token.
7972         (exp): New pattern for KIND expressions.
7973         (ptype): Handle types with a kind extension.
7974         (direct_abs_decl): Extend to spot kind extensions.
7975         (f77_keywords): Add 'kind' to the list.
7976         (push_kind_type): New function.
7977         (convert_to_kind_type): New function.
7978         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7979         * parse.c (operator_length_standard): Likewise.
7980         * parser-defs.h (enum type_pieces): Add tp_kind.
7981         * std-operator.def: Add UNOP_KIND.
7982
7983 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7984
7985         * f-exp.y (f_parse): Set yydebug.
7986
7987 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7988
7989         * f-lang.c (evaluate_subexp_f): New function.
7990         (exp_descriptor_f): New global.
7991         (f_language_defn): Use exp_descriptor_f instead of
7992         exp_descriptor_standard.
7993
7994 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7995
7996         * f-exp.y (struct token): Add comments.
7997         (dot_ops): Remove uppercase versions and the end marker.
7998         (f77_keywords): Likewise.
7999         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
8000         entries in the dot_ops array are case insensitive, and use
8001         strncasecmp to compare strings.  Also some whitespace cleanup in
8002         this area.  Similar for the f77_keywords array, except entries in
8003         this list might be case sensitive.
8004
8005 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8006
8007         * f-exp.y (struct f77_boolean_val): Add comments.
8008         (boolean_values): Remove uppercase versions, and end marker.
8009         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
8010         and use strncasecmp to achieve case insensitivity.  Additionally,
8011         perform whitespace cleanup around this code.
8012
8013 2019-03-06  Tom Tromey  <tromey@adacore.com>
8014
8015         * remote-sim.c (gdbsim_target_open): Use result of
8016         gdb_argv::release.
8017
8018 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
8019         Dirk Schubert  <dirk.schubert@arm.com>
8020         Chris January  <chris.january@arm.com>
8021
8022         * eval.c (evaluate_subexp_standard): Call Fortran argument
8023         wrapping logic.
8024         * f-lang.c (struct value): A value which can be passed into a
8025         Fortran function call.
8026         (fortran_argument_convert): Wrap Fortran arguments in a pointer
8027         where appropriate.
8028         (struct type): Value ready for a Fortran function call.
8029         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
8030         is needed.
8031         * f-lang.h (fortran_argument_convert): Declaration.
8032         (fortran_preserve_arg_pointer): Declaration.
8033         * infcall.c (value_arg_coerce): Call Fortran argument logic.
8034
8035 2019-03-05  Tom Tromey  <tromey@adacore.com>
8036
8037         * python/py-prettyprint.c (print_string_repr): Remove #if.
8038         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
8039
8040 2019-03-05  Tom Tromey  <tromey@adacore.com>
8041
8042         * target.c (the_dummy_target): Move later.  Change type to
8043         "dummy_target".
8044         (initialize_targets): Don't initialize the_dummy_target.
8045
8046 2019-03-05  Tom Tromey  <tromey@adacore.com>
8047
8048         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
8049         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
8050
8051 2019-03-05  Tom Tromey  <tromey@adacore.com>
8052
8053         * windows-nat.c (windows_nat_target::attach)
8054         (windows_nat_target::detach): Don't call gdb_flush.
8055         * valprint.c (generic_val_print, val_print, val_print_string):
8056         Don't call gdb_flush.
8057         * utils.c (defaulted_query): Don't call gdb_flush.
8058         * typeprint.c (print_type_scalar): Don't call gdb_flush.
8059         * target.c (target_announce_detach): Don't call gdb_flush.
8060         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
8061         * remote.c (extended_remote_target::attach): Don't call
8062         gdb_flush.
8063         * procfs.c (procfs_target::detach): Don't call gdb_flush.
8064         * printcmd.c (do_examine): Don't call gdb_flush.
8065         (info_display_command): Don't call gdb_flush.
8066         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
8067         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
8068         * memattr.c (info_mem_command): Don't call gdb_flush.
8069         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
8070         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
8071         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
8072         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
8073         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
8074         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
8075         (gnu_nat_target::detach): Don't call gdb_flush.
8076         * f-valprint.c (f_val_print): Don't call gdb_flush.
8077         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
8078         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
8079         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
8080         gdb_flush.
8081         * c-valprint.c (c_val_print): Don't call gdb_flush.
8082         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
8083
8084 2019-03-05  Tom Tromey  <tromey@adacore.com>
8085
8086         * varobj.c (update_dynamic_varobj_children): Update.
8087         (install_default_visualizer): Use reset, not release.
8088         * value.c (set_internalvar): Update.
8089         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
8090         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
8091         ATTRIBUTE_UNUSED_RESULT.
8092
8093 2019-03-05  Tom Tromey  <tromey@adacore.com>
8094
8095         * remote.c (class scoped_remote_fd) <release>: Add
8096         ATTRIBUTE_UNUSED_RESULT.
8097
8098 2019-03-05  Tom Tromey  <tromey@adacore.com>
8099
8100         * macroexp.c (struct macro_buffer) <release>: Add
8101         ATTRIBUTE_UNUSED_RESULT.
8102
8103 2019-03-05  Tom Tromey  <tromey@adacore.com>
8104
8105         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
8106         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
8107         ATTRIBUTE_UNUSED_RESULT.
8108
8109 2019-03-05  Tom Tromey  <tromey@adacore.com>
8110
8111         * common/scoped_fd.h (class scoped_fd) <release>: Add
8112         ATTRIBUTE_UNUSED_RESULT.
8113
8114 2019-03-05  Tom Tromey  <tromey@adacore.com>
8115
8116         * parser-defs.h (struct parser_state) <release>: Add
8117         ATTRIBUTE_UNUSED_RESULT.
8118
8119 2019-03-05  Tom Tromey  <tromey@adacore.com>
8120
8121         * utils.h (class gdb_argv) <release>: Add
8122         ATTRIBUTE_UNUSED_RESULT.
8123         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
8124
8125 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
8126
8127         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
8128         for-loop range, to avoid compiler warnings.
8129
8130         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
8131         avoid compiler warnings about unused variables.
8132
8133         * NEWS: Mention end of support for native debugging on MS-Windows
8134         before XP.
8135
8136         PR gdb/24292
8137         * common/netstuff.c:
8138         * gdbserver/gdbreplay.c
8139         * gdbserver/remote-utils.c:
8140         * ser-tcp.c:
8141         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
8142         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
8143         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
8144         'getaddrinfo' and 'freeaddrinfo' were not available before
8145         Windows XP, and mingw.org's MinGW headers by default define
8146         _WIN32_WINNT to 0x500.
8147
8148 2019-03-01  Gary Benson <gbenson@redhat.com>
8149
8150         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
8151
8152 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
8153             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
8154
8155         PR gdb/8527
8156         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
8157         set_sigint_trap, clear_sigint_trap.
8158
8159 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8160
8161         * target.c (target_detach): Clear the regcache and the
8162         frame cache.
8163
8164 2019-02-27  Pedro Alves  <palves@redhat.com>
8165
8166         * utils.c (set_screen_size): When we cap the height/width sizes,
8167         tweak the corresponding command variable to show "unlimited":
8168
8169 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
8170             Pedro Alves  <palves@redhat.com>
8171
8172         * utils.c (set_screen_size): Reduce "infinite" rows and columns
8173         before calling rl_set_screen_size.
8174
8175 2019-02-27  Tom Tromey  <tromey@adacore.com>
8176
8177         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8178         define.
8179         * python/py-value.c: Remove Python 2.4 workaround.
8180         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8181         workaround.
8182         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8183         Python 2.4 workaround.
8184         * python/python-internal.h: Remove Python 2.4 comment.
8185         (Py_ssize_t): Don't define.
8186         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8187         (gdb_Py_DECREF): Remove Python 2.4 workaround.
8188         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8189         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8190         * python/python.c (do_start_initialization): Remove Python 2.4
8191         workaround.
8192         * python/py-prettyprint.c (class dummy_python_frame): Remove.
8193         (print_children): Remove Python 2.4 workaround.
8194         * python/py-inferior.c (buffer_procs): Remove Python 2.4
8195         workaround.
8196         (CHARBUFFERPROC_NAME): Remove.
8197         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8198         Python 2.4 workaround.
8199
8200 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8201
8202         * NEWS: Note minimum Python version.
8203
8204 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8205
8206         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8207         code from these functions.  Remove corresponding ifdefs.  Use
8208         Py_buffer_up instead of explicit calls to PyBuffer_Release.
8209         Remove gotos and target of gotos.
8210         (infpy_search_memory): Likewise.
8211
8212 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8213
8214         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8215         (hppa_gdbarch_init): Don't register deleted functions with
8216         gdbarch.
8217
8218 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8219
8220         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8221         (h8300_unwind_sp): Delete.
8222         (h8300_dummy_id): Delete.
8223         (h8300_gdbarch_init): Don't register deleted functions with
8224         gdbarch.
8225
8226 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8227
8228         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8229         (ft32_unwind_pc): Delete.
8230         (ft32_unwind_sp): Delete.
8231         (ft32_gdbarch_init): Don't register deleted functions with
8232         gdbarch.
8233
8234 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8235
8236         * gdb/frv-tdep.c (frv_dummy_id): Delete.
8237         (frv_unwind_pc): Delete.
8238         (frv_unwind_sp): Delete.
8239         (frv_gdbarch_init): Don't register deleted functions with
8240         gdbarch.
8241
8242 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8243
8244         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8245         (riscv_unwind_pc): Delete.
8246         (riscv_unwind_sp): Delete.
8247         (riscv_gdbarch_init): Don't register deleted functions with
8248         gdbarch.
8249
8250 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8251
8252         * gdb/csky-tdep.c (csky_dummy_id): Delete.
8253         (csky_unwind_pc): Delete.
8254         (csky_unwind_sp): Delete.
8255         (csky_gdbarch_init): Don't register deleted functions with
8256         gdbarch.
8257
8258 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8259
8260         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8261         (cris_unwind_pc): Delete.
8262         (cris_unwind_sp): Delete.
8263         (cris_gdbarch_init): Don't register deleted functions with
8264         gdbarch.
8265
8266 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8267
8268         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8269         (bfin_unwind_pc): Delete.
8270         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8271
8272 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8273
8274         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8275         (arm_unwind_pc): Delete.
8276         (arm_unwind_sp): Delete.
8277         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8278
8279 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8280
8281         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8282         (arc_unwind_pc): Delete.
8283         (arc_unwind_sp): Delete.
8284         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8285
8286 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8287
8288         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8289         (alpha_unwind_pc): Delete.
8290         (alpha_gdbarch_init): Don't register deleted functions with
8291         gdbarch.
8292
8293 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8294
8295         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8296         (aarch64_unwind_pc): Delete.
8297         (aarch64_unwind_sp): Delete.
8298         (aarch64_gdbarch_init): Don't register deleted functions with
8299         gdbarch.
8300
8301 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8302
8303         * gdbtypes.c (type_align): Don't consider static members when
8304         computing structure alignment.
8305
8306 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8307
8308         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8309         return 0 for other types.
8310         * arch-utils.c (default_type_align): Always return 0.
8311         * gdbarch.h: Regenerate.
8312         * gdbarch.sh (type_align): Extend comment.
8313         * gdbtypes.c (type_align): Add additional comments, always call
8314         gdbarch_type_align before applying the default rules.
8315         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8316         generic code will then apply a suitable default.
8317         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8318         types, return 0 for other types.
8319
8320 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8321
8322         * NEWS: Create a new section for the next release branch.
8323         Rename the section of the current branch, now that it has
8324         been cut.
8325
8326 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8327
8328         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8329         * version.in: Bump version to 8.3.50.DATE-git.
8330
8331 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8332
8333         * aix-thread.c (ptid_cmp): Remove unused variable.
8334         (get_signaled_thread): Likewise.
8335         (store_regs_user_thread): Likewise.
8336         (store_regs_kernel_thread): Likewise.
8337         (fetch_regs_kernel_thread): Remove shadowed variable.
8338
8339 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8340
8341         * features/riscv/32bit-cpu.xml: Add register numbers.
8342         * features/riscv/32bit-fpu.c: Regenerate.
8343         * features/riscv/32bit-fpu.xml: Add register numbers.
8344         * features/riscv/64bit-cpu.xml: Add register numbers.
8345         * features/riscv/64bit-fpu.c: Regenerate.
8346         * features/riscv/64bit-fpu.xml: Add register numbers.
8347
8348 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8349
8350         * NEWS: Mention two argument form of gdb.Value constructor.
8351         * python/py-value.c (convert_buffer_and_type_to_value): New
8352         function.
8353         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8354         Add support for handling an optional second argument.  Call
8355         convert_buffer_and_type_to_value as appropriate.
8356         * python/python-internal.h (Py_buffer_deleter): New struct.
8357         (Py_buffer_up): New typedef.
8358
8359 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8360
8361         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8362         instead of releasing ownership.
8363
8364 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8365
8366         * dwarf2read.c (open_and_init_dwp_file): Call
8367         elf_numsections instead of bfd_count_sections to initialize
8368         dwp_file->num_sections.
8369
8370 2019-02-25  Tom Tromey  <tromey@adacore.com>
8371
8372         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8373
8374 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8375
8376         * gcore.in: Add '--readnever' option when invoking GDB.
8377
8378 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8379
8380         * MAINTAINERS: Update my email address.
8381
8382 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8383
8384         * build-id.c (build_id_to_debug_bfd_1): New function.
8385         (build_id_to_debug_bfd): Look for separate debug file in
8386         sysroot.
8387
8388 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8389
8390         * gdbarch.sh: Update the copyright year range that is placed into
8391         generated files.
8392
8393 2019-02-22  Keith Seitz  <keiths@redhat.com>
8394
8395         PR symtab/23853
8396         * linespec.c (create_sals_line_offset): Search for the default
8397         symtab's filename instead of its fullname.
8398
8399 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8400
8401         * NEWS: Update style defaults.
8402
8403 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8404
8405         * main.c (captured_main_1): Disable styling in batch mode.
8406
8407 2019-02-20  Tom Tromey  <tom@tromey.com>
8408
8409         * symtab.c (symtab_symbol_info): Fix typos.
8410
8411 2019-02-20  Tom Tromey  <tromey@adacore.com>
8412
8413         * findcmd.c (_initialize_mem_search): Use upper case for
8414         metasyntactic variables.
8415
8416 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8417
8418         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8419         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8420
8421 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8422
8423         * top.h (source_file_name): Change to std::string.
8424         * top.c (source_file_name): Likewise.
8425         (command_line_input): Adjust.
8426         * cli/cli-script.c (script_from_file): Adjust.
8427
8428 2019-02-19  Tom Tromey  <tromey@adacore.com>
8429
8430         * ravenscar-thread.c
8431         (ravenscar_thread_target::update_thread_list): Don't call
8432         ada_build_task_list.
8433         * ada-lang.h (ada_build_task_list): Don't declare.
8434         * ada-tasks.c (struct ada_tasks_inferior_data)
8435         <task_list_valid_p>: Now bool.
8436         (read_known_tasks, ada_task_list_changed)
8437         (ada_tasks_invalidate_inferior_data): Update.
8438         (read_known_tasks_array): Return bool.
8439         (read_known_tasks_list): Likewise.
8440         (read_known_tasks): Return void.
8441         (ada_build_task_list): Now static.
8442
8443 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8444
8445         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8446         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8447
8448 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8449
8450         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8451         variant for ada_tasks_pspace_data_handle and
8452         ada_tasks_inferior_data_handle.
8453         (ada_tasks_pspace_data_cleanup): New function.
8454         (ada_tasks_inferior_data_cleanup): New function.
8455
8456 2019-02-17  Tom Tromey  <tom@tromey.com>
8457
8458         * macrotab.h (macro_source_fullname): Return a std::string.
8459         * macrotab.c (macro_include, check_for_redefinition)
8460         (macro_undef, macro_lookup_definition, foreach_macro)
8461         (foreach_macro_in_scope): Update.
8462         (macro_source_fullname): Return a std::string.
8463         * macrocmd.c (show_pp_source_pos): Update.
8464
8465 2019-02-17  Tom Tromey  <tom@tromey.com>
8466
8467         * macrocmd.c (show_pp_source_pos): Style the file names.
8468
8469 2019-02-17  Tom Tromey  <tom@tromey.com>
8470
8471         PR tui/24197:
8472         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8473
8474 2019-02-17  Tom Tromey  <tom@tromey.com>
8475
8476         * ada-lang.c (user_select_syms): Use filtered printing.
8477         * utils.c (wrap_style): New global.
8478         (desired_style): Remove.
8479         (emit_style_escape): Add stream parameter.
8480         (set_output_style, reset_terminal_style, prompt_for_continue):
8481         Update.
8482         (flush_wrap_buffer): Only flush gdb_stdout.
8483         (wrap_here): Set wrap_style.
8484         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8485         treat escape sequences as a character.  Change when wrap buffer is
8486         flushed.
8487         (fputs_styled): Do not set the output style when the default is
8488         requested.
8489         * ui-style.h (struct ui_file_style) <is_default>: New method.
8490         * source.c (print_source_lines_base): Emit escape sequences in one
8491         piece.
8492
8493 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8494
8495         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8496         integers and enumeration types.
8497
8498 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8499
8500         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8501         instead of lookup_symbol_in_language
8502         (do_exact_match): New function.
8503         (ada_get_symbol_name_matcher): Return do_exact_match when
8504         doing a verbatim match.
8505
8506 2019-02-15  Tom Tromey  <tromey@adacore.com>
8507
8508         * ravenscar-thread.c (ravenscar_thread_target::resume)
8509         (ravenscar_thread_target::wait): Special case wildcard requests.
8510
8511 2019-02-15  Tom Tromey  <tromey@adacore.com>
8512
8513         * ravenscar-thread.c (base_ptid): Remove.
8514         (struct ravenscar_thread_target) <close>: New method.
8515         <m_base_ptid>: New member.
8516         <update_inferior_ptid, active_task, task_is_currently_active,
8517         runtime_initialized>: Declare methods.
8518         <ravenscar_thread_target>: Add constructor.
8519         (ravenscar_thread_target::task_is_currently_active)
8520         (ravenscar_thread_target::update_inferior_ptid)
8521         (ravenscar_runtime_initialized): Rename.  Now methods.
8522         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8523         (ravenscar_thread_target::update_thread_list): Update.
8524         (ravenscar_thread_target::active_task): Now method.
8525         (ravenscar_thread_target::store_registers)
8526         (ravenscar_thread_target::prepare_to_store)
8527         (ravenscar_thread_target::prepare_to_store)
8528         (ravenscar_thread_target::mourn_inferior): Update.
8529         (ravenscar_inferior_created): Use "new" to create target.
8530         (ravenscar_thread_target::get_ada_task_ptid): Update.
8531         (_initialize_ravenscar): Don't initialize base_ptid.
8532         (ravenscar_ops): Remove global.
8533
8534 2019-02-15  Tom Tromey  <tromey@adacore.com>
8535
8536         * target.h (push_target): Declare new overload.
8537         * target.c (push_target): New overload, taking an rvalue reference.
8538         * remote.c (remote_target::open_1): Use push_target overload.
8539         * corelow.c (core_target_open): Use push_target overload.
8540
8541 2019-02-15  Tom Tromey  <tromey@adacore.com>
8542
8543         * ravenscar-thread.c (is_ravenscar_task)
8544         (ravenscar_task_is_currently_active): Return bool.
8545         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8546         (_initialize_ravenscar): Remove "(void)".
8547         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8548         Return bool.
8549
8550 2019-02-15  Tom Tromey  <tromey@adacore.com>
8551
8552         * ravenscar-thread.c (ravenscar_runtime_initializer)
8553         (has_ravenscar_runtime, get_running_thread_id)
8554         (ravenscar_thread_target::resume): Fix indentation.
8555
8556 2019-02-15  Tom Tromey  <tromey@adacore.com>
8557
8558         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8559         from ravenscar_arch_ops.
8560         (sparc_ravenscar_ops::fetch_registers)
8561         (sparc_ravenscar_ops::store_registers): Now methods.
8562         (sparc_ravenscar_prepare_to_store): Remove.
8563         (sparc_ravenscar_ops): Redefine.
8564         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8565         methods and destructor.  Remove members.
8566         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8567         (ravenscar_thread_target::store_registers)
8568         (ravenscar_thread_target::prepare_to_store): Update.
8569         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8570         Remove.
8571         (struct ppc_ravenscar_powerpc_ops): Derive from
8572         ravenscar_arch_ops.
8573         (ppc_ravenscar_powerpc_ops::fetch_registers)
8574         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8575         (ppc_ravenscar_powerpc_ops): Redefine.
8576         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8577         (ppc_ravenscar_e500_ops::fetch_registers)
8578         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8579         (ppc_ravenscar_e500_ops): Redefine.
8580         * aarch64-ravenscar-thread.c
8581         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8582         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8583         (aarch64_ravenscar_fetch_registers)
8584         (aarch64_ravenscar_store_registers): Now methods.
8585         (aarch64_ravenscar_ops): Redefine.
8586
8587 2019-02-15  Tom Tromey  <tromey@adacore.com>
8588
8589         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8590         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8591         (ravenscar_thread_target::stopped_by_watchpoint)
8592         (ravenscar_thread_target::stopped_data_address)
8593         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8594
8595 2019-02-15  Tom Tromey  <tromey@adacore.com>
8596
8597         * ravenscar-thread.c: Fix some typos.
8598
8599 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8600             Tom Tromey  <tromey@adacore.com>
8601
8602         * ada-lang.c (ada_exception_sal): Change addr_string to a
8603         std::string.
8604         (create_ada_exception_catchpoint): Update.
8605
8606 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8607             Tom Tromey  <tromey@adacore.com>
8608
8609         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8610         (bp_location_ops): Remove.
8611         (base_breakpoint_allocate_location): Update.
8612         (free_bp_location): Update.
8613         * ada-lang.c (class ada_catchpoint_location)
8614         <ada_catchpoint_location>: Remove ops parameter.
8615         (ada_catchpoint_location_dtor): Remove.
8616         (ada_catchpoint_location_ops): Remove.
8617         (allocate_location_exception): Update.
8618         * breakpoint.h (struct bp_location_ops): Remove.
8619         (class bp_location) <bp_location>: Remove bp_location_ops
8620         parameter.
8621         <~bp_location>: Add destructor.
8622         <ops>: Remove.
8623
8624 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8625             Pedro Alves  <palves@redhat.com>
8626
8627         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8628         'PATH_MAX'.
8629
8630 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8631             Samuel Thibault  <samuel.thibault@gnu.org>
8632             Thomas Schwinge  <thomas@codesourcery.com>
8633
8634         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8635         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8636
8637 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8638
8639         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8640         (check_empty): Use "const char *".
8641
8642         * gnu-nat.c (gnu_nat_target::detach): Instead of
8643         'detach_inferior (pid)' call
8644         'detach_inferior (find_inferior_pid (pid))'.
8645
8646         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8647         'nat/fork-inferior.o'.
8648         * gnu-nat.c: #include "nat/fork-inferior.h".
8649
8650         * gnu-nat.c (gnu_nat_target::detach): Instead of
8651         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8652         * gnu-nat.h: #include "inf-child.h".
8653         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8654         'i386_gnu_nat_target::fetch_registers'.
8655         (gnu_store_registers): Rename/move to
8656         'i386_gnu_nat_target::store_registers'.
8657
8658         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8659         * gnu-nat.h (mach_thread_info): New function.
8660         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8661
8662         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8663
8664 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8665
8666         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8667
8668 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8669
8670         * windows-nat.c (windows_add_thread): Add new parameter
8671         "main_thread_p" with default value set to false.  Update
8672         function documentation as well as all callers.
8673         (windows_delete_thread): Likewise.
8674         (fake_create_process): Update call to windows_add_thread.
8675         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8676         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8677         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8678         call to windows_delete_thread.
8679
8680 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8681
8682         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8683
8684 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8685
8686         * symfile.c (find_separate_debug_file): Use canonical path of
8687         sysroot with child_path instead of gdb_sysroot if it is valid.
8688
8689 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8690
8691         * symfile.c (find_separate_debug_file): Use child_path to
8692         determine if an object file is under a sysroot.
8693
8694 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8695
8696         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8697         unittests/child-path-selftests.c.
8698         * common/pathstuff.c (child_path): New function.
8699         * common/pathstuff.h (child_path): New prototype.
8700         * unittests/child-path-selftests.c: New file.
8701
8702 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8703
8704         * symfile.c (find_separate_debug_file): Look for separate debug
8705         files in debug directories under the sysroot.
8706
8707 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8708
8709         * symtab.h (struct minimal_symbol data_p): New const method.
8710         (struct minimal_symbol text_p): Likewise.
8711         * symtab.c (output_source_filename): Use file name style
8712         to print file name.
8713         (print_symbol_info): Likewise.
8714         (print_msymbol_info): Use address style to print addresses.
8715         Use function name style to print executable text symbols.
8716         (expand_symtab_containing_pc): Use data_p.
8717         (find_pc_sect_compunit_symtab): Likewise.
8718
8719 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8720
8721         * breakpoint.c (describe_other_breakpoints): Use address style
8722         to print addresses.
8723         (say_where): Likewise.
8724
8725 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8726
8727         * ada-typeprint.c (print_func_type): Print function name
8728         style to print function name.
8729         * c-typeprint.c (c_print_type_1): Likewise.
8730
8731 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8732
8733         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8734         for execve.
8735
8736 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8737
8738         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8739         type_stack.
8740
8741 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8742
8743         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8744         TYPE_CODE_REF types.
8745
8746 2019-02-08  Jim Wilson  <jimw@sifive.com>
8747
8748         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8749         (riscv_linux_fregset): New.
8750         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8751
8752 2019-02-07  Tom Tromey  <tom@tromey.com>
8753
8754         * thread.c (thread_cancel_execution_command): Update.
8755         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8756         methods.
8757         (struct thread_fsm_ops): Remove.
8758         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8759         (thread_fsm_should_stop, thread_fsm_return_value)
8760         (thread_fsm_set_finished, thread_fsm_finished_p)
8761         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8762         Don't declare.
8763         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8764         * infrun.c (clear_proceed_status_thread)
8765         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8766         (print_stop_event): Update.
8767         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8768         Add constructor.
8769         (step_command_fsm_ops): Remove.
8770         (new_step_command_fsm): Remove.
8771         (step_1): Update.
8772         (step_command_fsm::should_stop): Rename from
8773         step_command_fsm_should_stop.
8774         (step_command_fsm::clean_up): Rename from
8775         step_command_fsm_clean_up.
8776         (step_command_fsm::do_async_reply_reason): Rename from
8777         step_command_fsm_async_reply_reason.
8778         (struct until_next_fsm): Inherit from thread_fsm.  Add
8779         constructor.
8780         (until_next_fsm_ops): Remove.
8781         (new_until_next_fsm): Remove.
8782         (until_next_fsm::should_stop): Rename from
8783         until_next_fsm_should_stop.
8784         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8785         (until_next_fsm::do_async_reply_reason): Rename from
8786         until_next_fsm_async_reply_reason.
8787         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8788         constructor.  Change type of breakpoint.
8789         (finish_command_fsm_ops): Remove.
8790         (new_finish_command_fsm): Remove.
8791         (finish_command_fsm::should_stop): Rename from
8792         finish_command_fsm_should_stop.
8793         (finish_command_fsm::clean_up): Rename from
8794         finish_command_fsm_clean_up.
8795         (finish_command_fsm::return_value): Rename from
8796         finish_command_fsm_return_value.
8797         (finish_command_fsm::do_async_reply_reason): Rename from
8798         finish_command_fsm_async_reply_reason.
8799         (finish_command): Update.
8800         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8801         Add constructor.
8802         (call_thread_fsm_ops): Remove.
8803         (call_thread_fsm::call_thread_fsm): Rename from
8804         new_call_thread_fsm.
8805         (call_thread_fsm::should_stop): Rename from
8806         call_thread_fsm_should_stop.
8807         (call_thread_fsm::should_notify_stop): Rename from
8808         call_thread_fsm_should_notify_stop.
8809         (run_inferior_call, call_function_by_hand_dummy): Update.
8810         * cli/cli-interp.c (should_print_stop_to_console): Update.
8811         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8812         Add constructor.  Change type of location_breakpoint,
8813         caller_breakpoint.
8814         (until_break_fsm_ops): Remove.
8815         (new_until_break_fsm): Remove.
8816         (until_break_fsm::should_stop): Rename from
8817         until_break_fsm_should_stop.
8818         (until_break_fsm::clean_up): Rename from
8819         until_break_fsm_clean_up.
8820         (until_break_fsm::do_async_reply_reason): Rename from
8821         until_break_fsm_async_reply_reason.
8822         (until_break_command): Update.
8823         * thread-fsm.c: Remove.
8824         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8825
8826 2019-02-07  Tom Tromey  <tom@tromey.com>
8827
8828         * yy-remap.h: Add include guard.
8829         * xtensa-tdep.h: Add include guard.
8830         * xcoffread.h: Rename include guard.
8831         * varobj-iter.h: Add include guard.
8832         * tui/tui.h: Rename include guard.
8833         * tui/tui-winsource.h: Rename include guard.
8834         * tui/tui-wingeneral.h: Rename include guard.
8835         * tui/tui-windata.h: Rename include guard.
8836         * tui/tui-win.h: Rename include guard.
8837         * tui/tui-stack.h: Rename include guard.
8838         * tui/tui-source.h: Rename include guard.
8839         * tui/tui-regs.h: Rename include guard.
8840         * tui/tui-out.h: Rename include guard.
8841         * tui/tui-layout.h: Rename include guard.
8842         * tui/tui-io.h: Rename include guard.
8843         * tui/tui-hooks.h: Rename include guard.
8844         * tui/tui-file.h: Rename include guard.
8845         * tui/tui-disasm.h: Rename include guard.
8846         * tui/tui-data.h: Rename include guard.
8847         * tui/tui-command.h: Rename include guard.
8848         * tic6x-tdep.h: Add include guard.
8849         * target/waitstatus.h: Rename include guard.
8850         * target/wait.h: Rename include guard.
8851         * target/target.h: Rename include guard.
8852         * target/resume.h: Rename include guard.
8853         * target-float.h: Rename include guard.
8854         * stabsread.h: Add include guard.
8855         * rs6000-tdep.h: Add include guard.
8856         * riscv-fbsd-tdep.h: Add include guard.
8857         * regformats/regdef.h: Rename include guard.
8858         * record.h: Rename include guard.
8859         * python/python.h: Rename include guard.
8860         * python/python-internal.h: Rename include guard.
8861         * python/py-stopevent.h: Rename include guard.
8862         * python/py-ref.h: Rename include guard.
8863         * python/py-record.h: Rename include guard.
8864         * python/py-record-full.h: Rename include guard.
8865         * python/py-record-btrace.h: Rename include guard.
8866         * python/py-instruction.h: Rename include guard.
8867         * python/py-events.h: Rename include guard.
8868         * python/py-event.h: Rename include guard.
8869         * procfs.h: Add include guard.
8870         * proc-utils.h: Add include guard.
8871         * p-lang.h: Add include guard.
8872         * or1k-tdep.h: Rename include guard.
8873         * observable.h: Rename include guard.
8874         * nto-tdep.h: Rename include guard.
8875         * nat/x86-linux.h: Rename include guard.
8876         * nat/x86-linux-dregs.h: Rename include guard.
8877         * nat/x86-gcc-cpuid.h: Add include guard.
8878         * nat/x86-dregs.h: Rename include guard.
8879         * nat/x86-cpuid.h: Rename include guard.
8880         * nat/ppc-linux.h: Rename include guard.
8881         * nat/mips-linux-watch.h: Rename include guard.
8882         * nat/linux-waitpid.h: Rename include guard.
8883         * nat/linux-ptrace.h: Rename include guard.
8884         * nat/linux-procfs.h: Rename include guard.
8885         * nat/linux-osdata.h: Rename include guard.
8886         * nat/linux-nat.h: Rename include guard.
8887         * nat/linux-namespaces.h: Rename include guard.
8888         * nat/linux-btrace.h: Rename include guard.
8889         * nat/glibc_thread_db.h: Rename include guard.
8890         * nat/gdb_thread_db.h: Rename include guard.
8891         * nat/gdb_ptrace.h: Rename include guard.
8892         * nat/fork-inferior.h: Rename include guard.
8893         * nat/amd64-linux-siginfo.h: Rename include guard.
8894         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8895         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8896         * nat/aarch64-linux.h: Rename include guard.
8897         * nat/aarch64-linux-hw-point.h: Rename include guard.
8898         * mn10300-tdep.h: Add include guard.
8899         * mips-linux-tdep.h: Add include guard.
8900         * mi/mi-parse.h: Rename include guard.
8901         * mi/mi-out.h: Rename include guard.
8902         * mi/mi-main.h: Rename include guard.
8903         * mi/mi-interp.h: Rename include guard.
8904         * mi/mi-getopt.h: Rename include guard.
8905         * mi/mi-console.h: Rename include guard.
8906         * mi/mi-common.h: Rename include guard.
8907         * mi/mi-cmds.h: Rename include guard.
8908         * mi/mi-cmd-break.h: Rename include guard.
8909         * m2-lang.h: Add include guard.
8910         * location.h: Rename include guard.
8911         * linux-record.h: Rename include guard.
8912         * linux-nat.h: Add include guard.
8913         * linux-fork.h: Add include guard.
8914         * i386-darwin-tdep.h: Rename include guard.
8915         * hppa-linux-offsets.h: Add include guard.
8916         * guile/guile.h: Rename include guard.
8917         * guile/guile-internal.h: Rename include guard.
8918         * gnu-nat.h: Rename include guard.
8919         * gdb-stabs.h: Rename include guard.
8920         * frv-tdep.h: Add include guard.
8921         * f-lang.h: Add include guard.
8922         * event-loop.h: Add include guard.
8923         * darwin-nat.h: Rename include guard.
8924         * cp-abi.h: Rename include guard.
8925         * config/sparc/nm-sol2.h: Rename include guard.
8926         * config/nm-nto.h: Rename include guard.
8927         * config/nm-linux.h: Add include guard.
8928         * config/i386/nm-i386gnu.h: Rename include guard.
8929         * config/djgpp/nl_types.h: Rename include guard.
8930         * config/djgpp/langinfo.h: Rename include guard.
8931         * compile/gcc-cp-plugin.h: Add include guard.
8932         * compile/gcc-c-plugin.h: Add include guard.
8933         * compile/compile.h: Rename include guard.
8934         * compile/compile-object-run.h: Rename include guard.
8935         * compile/compile-object-load.h: Rename include guard.
8936         * compile/compile-internal.h: Rename include guard.
8937         * compile/compile-cplus.h: Rename include guard.
8938         * compile/compile-c.h: Rename include guard.
8939         * common/xml-utils.h: Rename include guard.
8940         * common/x86-xstate.h: Rename include guard.
8941         * common/version.h: Rename include guard.
8942         * common/vec.h: Rename include guard.
8943         * common/tdesc.h: Rename include guard.
8944         * common/selftest.h: Rename include guard.
8945         * common/scoped_restore.h: Rename include guard.
8946         * common/scoped_mmap.h: Rename include guard.
8947         * common/scoped_fd.h: Rename include guard.
8948         * common/safe-iterator.h: Rename include guard.
8949         * common/run-time-clock.h: Rename include guard.
8950         * common/refcounted-object.h: Rename include guard.
8951         * common/queue.h: Rename include guard.
8952         * common/ptid.h: Rename include guard.
8953         * common/print-utils.h: Rename include guard.
8954         * common/preprocessor.h: Rename include guard.
8955         * common/pathstuff.h: Rename include guard.
8956         * common/observable.h: Rename include guard.
8957         * common/netstuff.h: Rename include guard.
8958         * common/job-control.h: Rename include guard.
8959         * common/host-defs.h: Rename include guard.
8960         * common/gdb_wait.h: Rename include guard.
8961         * common/gdb_vecs.h: Rename include guard.
8962         * common/gdb_unlinker.h: Rename include guard.
8963         * common/gdb_unique_ptr.h: Rename include guard.
8964         * common/gdb_tilde_expand.h: Rename include guard.
8965         * common/gdb_sys_time.h: Rename include guard.
8966         * common/gdb_string_view.h: Rename include guard.
8967         * common/gdb_splay_tree.h: Rename include guard.
8968         * common/gdb_setjmp.h: Rename include guard.
8969         * common/gdb_ref_ptr.h: Rename include guard.
8970         * common/gdb_optional.h: Rename include guard.
8971         * common/gdb_locale.h: Rename include guard.
8972         * common/gdb_assert.h: Rename include guard.
8973         * common/filtered-iterator.h: Rename include guard.
8974         * common/filestuff.h: Rename include guard.
8975         * common/fileio.h: Rename include guard.
8976         * common/environ.h: Rename include guard.
8977         * common/common-utils.h: Rename include guard.
8978         * common/common-types.h: Rename include guard.
8979         * common/common-regcache.h: Rename include guard.
8980         * common/common-inferior.h: Rename include guard.
8981         * common/common-gdbthread.h: Rename include guard.
8982         * common/common-exceptions.h: Rename include guard.
8983         * common/common-defs.h: Rename include guard.
8984         * common/common-debug.h: Rename include guard.
8985         * common/cleanups.h: Rename include guard.
8986         * common/buffer.h: Rename include guard.
8987         * common/btrace-common.h: Rename include guard.
8988         * common/break-common.h: Rename include guard.
8989         * cli/cli-utils.h: Rename include guard.
8990         * cli/cli-style.h: Rename include guard.
8991         * cli/cli-setshow.h: Rename include guard.
8992         * cli/cli-script.h: Rename include guard.
8993         * cli/cli-interp.h: Rename include guard.
8994         * cli/cli-decode.h: Rename include guard.
8995         * cli/cli-cmds.h: Rename include guard.
8996         * charset-list.h: Add include guard.
8997         * buildsym-legacy.h: Rename include guard.
8998         * bfin-tdep.h: Add include guard.
8999         * ax.h: Rename include guard.
9000         * arm-linux-tdep.h: Add include guard.
9001         * arm-fbsd-tdep.h: Add include guard.
9002         * arch/xtensa.h: Rename include guard.
9003         * arch/tic6x.h: Add include guard.
9004         * arch/i386.h: Add include guard.
9005         * arch/arm.h: Rename include guard.
9006         * arch/arm-linux.h: Rename include guard.
9007         * arch/arm-get-next-pcs.h: Rename include guard.
9008         * arch/amd64.h: Add include guard.
9009         * arch/aarch64-insn.h: Rename include guard.
9010         * arch-utils.h: Rename include guard.
9011         * annotate.h: Add include guard.
9012         * amd64-darwin-tdep.h: Rename include guard.
9013         * aarch64-linux-tdep.h: Add include guard.
9014         * aarch64-fbsd-tdep.h: Add include guard.
9015         * aarch32-linux-nat.h: Add include guard.
9016
9017 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9018
9019         * macrotab.c (macro_define_internal): New function that
9020         factorizes macro_define_object_internal and macro_define_function
9021         code.
9022         (macro_define_object_internal): Use macro_define_internal.
9023         (macro_define_function): Likewise.
9024
9025 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9026
9027         * macrocmd.c (extract_identifier): Return
9028         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
9029         callers.
9030
9031 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
9032
9033         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
9034
9035 2019-02-05  Tom Tromey  <tom@tromey.com>
9036
9037         * target.c (target_stack::unpush): Move assertion earlier.
9038
9039 2019-01-30  Tom Tromey  <tom@tromey.com>
9040
9041         PR python/23615:
9042         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
9043         (gdbpy_parse_and_eval): Likewise.
9044         * python/python-internal.h (gdbpy_allow_threads): New class.
9045
9046 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
9047
9048         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
9049         (aarch64_fbsd_fpregmap): Move earlier.
9050         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
9051         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9052         instead of individual calls to trad_frame_set_reg_addr.
9053         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
9054         earlier.
9055         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
9056         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9057         instead of individual calls to trad_frame_set_reg_addr.
9058
9059 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
9060
9061         * CONTRIBUTE: Replace contribution list with wiki link.
9062
9063 2019-01-25  Tom Tromey  <tom@tromey.com>
9064
9065         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
9066
9067 2019-01-25  Tom Tromey  <tom@tromey.com>
9068
9069         * xtensa-linux-nat.c: Fix common/ includes.
9070         * xml-support.h: Fix common/ includes.
9071         * xml-support.c: Fix common/ includes.
9072         * x86-linux-nat.c: Fix common/ includes.
9073         * windows-nat.c: Fix common/ includes.
9074         * varobj.h: Fix common/ includes.
9075         * varobj.c: Fix common/ includes.
9076         * value.c: Fix common/ includes.
9077         * valops.c: Fix common/ includes.
9078         * utils.c: Fix common/ includes.
9079         * unittests/xml-utils-selftests.c: Fix common/ includes.
9080         * unittests/utils-selftests.c: Fix common/ includes.
9081         * unittests/unpack-selftests.c: Fix common/ includes.
9082         * unittests/tracepoint-selftests.c: Fix common/ includes.
9083         * unittests/style-selftests.c: Fix common/ includes.
9084         * unittests/string_view-selftests.c: Fix common/ includes.
9085         * unittests/scoped_restore-selftests.c: Fix common/ includes.
9086         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
9087         * unittests/scoped_fd-selftests.c: Fix common/ includes.
9088         * unittests/rsp-low-selftests.c: Fix common/ includes.
9089         * unittests/parse-connection-spec-selftests.c: Fix common/
9090         includes.
9091         * unittests/optional-selftests.c: Fix common/ includes.
9092         * unittests/offset-type-selftests.c: Fix common/ includes.
9093         * unittests/observable-selftests.c: Fix common/ includes.
9094         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
9095         * unittests/memrange-selftests.c: Fix common/ includes.
9096         * unittests/memory-map-selftests.c: Fix common/ includes.
9097         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
9098         * unittests/function-view-selftests.c: Fix common/ includes.
9099         * unittests/environ-selftests.c: Fix common/ includes.
9100         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
9101         * unittests/common-utils-selftests.c: Fix common/ includes.
9102         * unittests/cli-utils-selftests.c: Fix common/ includes.
9103         * unittests/array-view-selftests.c: Fix common/ includes.
9104         * ui-file.c: Fix common/ includes.
9105         * tui/tui-io.c: Fix common/ includes.
9106         * tracepoint.h: Fix common/ includes.
9107         * tracepoint.c: Fix common/ includes.
9108         * tracefile-tfile.c: Fix common/ includes.
9109         * top.h: Fix common/ includes.
9110         * top.c: Fix common/ includes.
9111         * thread.c: Fix common/ includes.
9112         * target/waitstatus.h: Fix common/ includes.
9113         * target/waitstatus.c: Fix common/ includes.
9114         * target.h: Fix common/ includes.
9115         * target.c: Fix common/ includes.
9116         * target-memory.c: Fix common/ includes.
9117         * target-descriptions.c: Fix common/ includes.
9118         * symtab.h: Fix common/ includes.
9119         * symfile.c: Fix common/ includes.
9120         * stap-probe.c: Fix common/ includes.
9121         * spu-linux-nat.c: Fix common/ includes.
9122         * sparc-nat.c: Fix common/ includes.
9123         * source.c: Fix common/ includes.
9124         * solib.c: Fix common/ includes.
9125         * solib-target.c: Fix common/ includes.
9126         * ser-unix.c: Fix common/ includes.
9127         * ser-tcp.c: Fix common/ includes.
9128         * ser-pipe.c: Fix common/ includes.
9129         * ser-base.c: Fix common/ includes.
9130         * selftest-arch.c: Fix common/ includes.
9131         * s12z-tdep.c: Fix common/ includes.
9132         * rust-exp.y: Fix common/ includes.
9133         * rs6000-aix-tdep.c: Fix common/ includes.
9134         * riscv-tdep.c: Fix common/ includes.
9135         * remote.c: Fix common/ includes.
9136         * remote-notif.h: Fix common/ includes.
9137         * remote-fileio.h: Fix common/ includes.
9138         * remote-fileio.c: Fix common/ includes.
9139         * regcache.h: Fix common/ includes.
9140         * regcache.c: Fix common/ includes.
9141         * record-btrace.c: Fix common/ includes.
9142         * python/python.c: Fix common/ includes.
9143         * python/py-type.c: Fix common/ includes.
9144         * python/py-inferior.c: Fix common/ includes.
9145         * progspace.h: Fix common/ includes.
9146         * producer.c: Fix common/ includes.
9147         * procfs.c: Fix common/ includes.
9148         * proc-api.c: Fix common/ includes.
9149         * printcmd.c: Fix common/ includes.
9150         * ppc-linux-nat.c: Fix common/ includes.
9151         * parser-defs.h: Fix common/ includes.
9152         * osdata.c: Fix common/ includes.
9153         * obsd-nat.c: Fix common/ includes.
9154         * nat/x86-linux.c: Fix common/ includes.
9155         * nat/x86-linux-dregs.c: Fix common/ includes.
9156         * nat/x86-dregs.h: Fix common/ includes.
9157         * nat/x86-dregs.c: Fix common/ includes.
9158         * nat/ppc-linux.c: Fix common/ includes.
9159         * nat/mips-linux-watch.h: Fix common/ includes.
9160         * nat/mips-linux-watch.c: Fix common/ includes.
9161         * nat/linux-waitpid.c: Fix common/ includes.
9162         * nat/linux-ptrace.h: Fix common/ includes.
9163         * nat/linux-ptrace.c: Fix common/ includes.
9164         * nat/linux-procfs.c: Fix common/ includes.
9165         * nat/linux-personality.c: Fix common/ includes.
9166         * nat/linux-osdata.c: Fix common/ includes.
9167         * nat/linux-namespaces.c: Fix common/ includes.
9168         * nat/linux-btrace.h: Fix common/ includes.
9169         * nat/linux-btrace.c: Fix common/ includes.
9170         * nat/fork-inferior.c: Fix common/ includes.
9171         * nat/amd64-linux-siginfo.c: Fix common/ includes.
9172         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
9173         * nat/aarch64-linux.c: Fix common/ includes.
9174         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9175         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9176         * namespace.h: Fix common/ includes.
9177         * mips-linux-tdep.c: Fix common/ includes.
9178         * minsyms.c: Fix common/ includes.
9179         * mi/mi-parse.h: Fix common/ includes.
9180         * mi/mi-main.c: Fix common/ includes.
9181         * mi/mi-cmd-env.c: Fix common/ includes.
9182         * memrange.h: Fix common/ includes.
9183         * memattr.c: Fix common/ includes.
9184         * maint.h: Fix common/ includes.
9185         * maint.c: Fix common/ includes.
9186         * main.c: Fix common/ includes.
9187         * machoread.c: Fix common/ includes.
9188         * location.c: Fix common/ includes.
9189         * linux-thread-db.c: Fix common/ includes.
9190         * linux-nat.c: Fix common/ includes.
9191         * linux-fork.c: Fix common/ includes.
9192         * inline-frame.c: Fix common/ includes.
9193         * infrun.c: Fix common/ includes.
9194         * inflow.c: Fix common/ includes.
9195         * inferior.h: Fix common/ includes.
9196         * inferior.c: Fix common/ includes.
9197         * infcmd.c: Fix common/ includes.
9198         * inf-ptrace.c: Fix common/ includes.
9199         * inf-child.c: Fix common/ includes.
9200         * ia64-linux-nat.c: Fix common/ includes.
9201         * i387-tdep.c: Fix common/ includes.
9202         * i386-tdep.c: Fix common/ includes.
9203         * i386-linux-tdep.c: Fix common/ includes.
9204         * i386-linux-nat.c: Fix common/ includes.
9205         * i386-go32-tdep.c: Fix common/ includes.
9206         * i386-fbsd-tdep.c: Fix common/ includes.
9207         * i386-fbsd-nat.c: Fix common/ includes.
9208         * guile/scm-type.c: Fix common/ includes.
9209         * guile/guile.c: Fix common/ includes.
9210         * go32-nat.c: Fix common/ includes.
9211         * gnu-nat.c: Fix common/ includes.
9212         * gdbthread.h: Fix common/ includes.
9213         * gdbarch-selftests.c: Fix common/ includes.
9214         * gdb_usleep.c: Fix common/ includes.
9215         * gdb_select.h: Fix common/ includes.
9216         * gdb_bfd.c: Fix common/ includes.
9217         * gcore.c: Fix common/ includes.
9218         * fork-child.c: Fix common/ includes.
9219         * findvar.c: Fix common/ includes.
9220         * fbsd-nat.c: Fix common/ includes.
9221         * event-top.c: Fix common/ includes.
9222         * event-loop.c: Fix common/ includes.
9223         * dwarf2read.c: Fix common/ includes.
9224         * dwarf2loc.c: Fix common/ includes.
9225         * dwarf2-frame.c: Fix common/ includes.
9226         * dwarf-index-cache.c: Fix common/ includes.
9227         * dtrace-probe.c: Fix common/ includes.
9228         * disasm-selftests.c: Fix common/ includes.
9229         * defs.h: Fix common/ includes.
9230         * csky-tdep.c: Fix common/ includes.
9231         * cp-valprint.c: Fix common/ includes.
9232         * cp-support.h: Fix common/ includes.
9233         * cp-support.c: Fix common/ includes.
9234         * corelow.c: Fix common/ includes.
9235         * completer.h: Fix common/ includes.
9236         * completer.c: Fix common/ includes.
9237         * compile/compile.c: Fix common/ includes.
9238         * compile/compile-loc2c.c: Fix common/ includes.
9239         * compile/compile-cplus-types.c: Fix common/ includes.
9240         * compile/compile-cplus-symbols.c: Fix common/ includes.
9241         * command.h: Fix common/ includes.
9242         * cli/cli-dump.c: Fix common/ includes.
9243         * cli/cli-cmds.c: Fix common/ includes.
9244         * charset.c: Fix common/ includes.
9245         * build-id.c: Fix common/ includes.
9246         * btrace.h: Fix common/ includes.
9247         * btrace.c: Fix common/ includes.
9248         * breakpoint.h: Fix common/ includes.
9249         * breakpoint.c: Fix common/ includes.
9250         * ax.h:
9251         (enum agent_op): Fix common/ includes.
9252         * ax-general.c (struct aop_map): Fix common/ includes.
9253         * ax-gdb.c: Fix common/ includes.
9254         * auxv.c: Fix common/ includes.
9255         * auto-load.c: Fix common/ includes.
9256         * arm-tdep.c: Fix common/ includes.
9257         * arch/riscv.c: Fix common/ includes.
9258         * arch/ppc-linux-common.c: Fix common/ includes.
9259         * arch/i386.c: Fix common/ includes.
9260         * arch/arm.c: Fix common/ includes.
9261         * arch/arm-linux.c: Fix common/ includes.
9262         * arch/arm-get-next-pcs.c: Fix common/ includes.
9263         * arch/amd64.c: Fix common/ includes.
9264         * arch/aarch64.c: Fix common/ includes.
9265         * arch/aarch64-insn.c: Fix common/ includes.
9266         * arch-utils.c: Fix common/ includes.
9267         * amd64-windows-tdep.c: Fix common/ includes.
9268         * amd64-tdep.c: Fix common/ includes.
9269         * amd64-sol2-tdep.c: Fix common/ includes.
9270         * amd64-obsd-tdep.c: Fix common/ includes.
9271         * amd64-nbsd-tdep.c: Fix common/ includes.
9272         * amd64-linux-tdep.c: Fix common/ includes.
9273         * amd64-linux-nat.c: Fix common/ includes.
9274         * amd64-fbsd-tdep.c: Fix common/ includes.
9275         * amd64-fbsd-nat.c: Fix common/ includes.
9276         * amd64-dicos-tdep.c: Fix common/ includes.
9277         * amd64-darwin-tdep.c: Fix common/ includes.
9278         * agent.c: Fix common/ includes.
9279         * ada-lang.h: Fix common/ includes.
9280         * ada-lang.c: Fix common/ includes.
9281         * aarch64-tdep.c: Fix common/ includes.
9282
9283 2019-01-25  Tom Tromey  <tom@tromey.com>
9284
9285         * common/create-version.sh: Use common/version.h.
9286
9287 2019-01-24  Pedro Alves  <palves@redhat.com>
9288
9289         * infrun.c (signal_stop, signal_print, signal_program)
9290         (signal_catch, signal_pass): Now arrays instead of pointers.
9291         (update_signals_program_target, do_target_resume)
9292         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9293         * linux-nat.c (linux_nat_target::pass_signals)
9294         (linux_nat_target::create_inferior, linux_nat_target::attach):
9295         Adjust.
9296         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9297         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9298         * procfs.c (procfs_target::pass_signals): Adjust.
9299         * record-full.c (record_full_target::resume): Adjust.
9300         * remote.c (remote_target::pass_signals)
9301         (remote_target::program_signals): Adjust.
9302         * target-debug.h (target_debug_print_signals): Now takes a
9303         gdb::array_view as parameter.  Adjust.
9304         * target.h (target_ops) <pass_signals, program_signals>: Replace
9305         pointer and length parameters with gdb::array_view.
9306         (target_pass_signals, target_program_signals): Likewise.
9307         * target-delegates.c: Regenerate.
9308
9309 2019-01-24  Pedro Alves  <palves@redhat.com>
9310
9311         * common/forward-scope-exit.h
9312         (forward_scope_exit::forward_scope_exit): Pass arguments to
9313         m_bind_function directly, instead of creating a std::bind and
9314         copying that.
9315
9316 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9317
9318         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9319         for static members.
9320         (pass_in_v_vfp_candidate): Likewise.
9321
9322 2019-01-23  Tom Tromey  <tom@tromey.com>
9323             Pedro Alves  <palves@redhat.com>
9324
9325         * regcache.c (class regcache_invalidator): Remove.
9326         (regcache::raw_write): Use make_scope_exit.
9327
9328 2019-01-23  Tom Tromey  <tom@tromey.com>
9329
9330         * ui-out.h (class ui_out_emit_type): Update comment.
9331
9332 2019-01-23  Tom Tromey  <tom@tromey.com>
9333
9334         * infrun.c (fetch_inferior_event): Update comment.
9335
9336 2019-01-23  Tom Tromey  <tom@tromey.com>
9337             Pedro Alves  <palves@redhat.com>
9338
9339         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9340         parameter.
9341         (fetch_inferior_event): Use SCOPE_EXIT.
9342
9343
9344 2019-01-23  Tom Tromey  <tom@tromey.com>
9345             Pedro Alves  <palves@redhat.com>
9346
9347         * infrun.c (disable_thread_events): Delete.
9348         (stop_all_threads): Use SCOPE_EXIT.
9349
9350 2019-01-23  Tom Tromey  <tom@tromey.com>
9351             Pedro Alves  <palves@redhat.com>
9352
9353         * symfile.c: Include forward-scope-exit.h.
9354         (clear_symtab_users_cleanup): Replace forward declaration with
9355         a FORWARD_SCOPE_EXIT.
9356         (syms_from_objfile_1): Use the forward_scope_exit and
9357         gdb::optional instead of cleanup_function.
9358         (reread_symbols): Use the forward_scope_exit instead of
9359         cleanup_function.
9360         (clear_symtab_users_cleanup): Remove function.
9361
9362 2019-01-23  Tom Tromey  <tom@tromey.com>
9363             Pedro Alves  <palves@redhat.com>
9364
9365         * linux-nat.c: Include scope-exit.h.
9366         (cleanup_target_stop): Remove.
9367         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9368         SCOPE_EXIT.
9369
9370 2019-01-23  Tom Tromey  <tom@tromey.com>
9371             Pedro Alves  <palves@redhat.com>
9372
9373         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9374         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9375
9376 2019-01-23  Tom Tromey  <tom@tromey.com>
9377             Andrew Burgess  <andrew.burgess@embecosm.com>
9378             Pedro Alves  <palves@redhat.com>
9379
9380         * infrun.c (fetch_inferior_event): Use scope_exit.
9381         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9382         * top.c (execute_command): Use scope_exit.
9383         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9384         * utils.c (do_bpstat_clear_actions_cleanup)
9385         (make_bpstat_clear_actions_cleanup): Remove.
9386
9387 2019-01-23  Tom Tromey  <tom@tromey.com>
9388             Pedro Alves  <palves@redhat.com>
9389
9390         * infrun.c: Include "common/scope-exit.h"
9391         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9392         (wait_for_inferior): Use SCOPE_EXIT.
9393         (fetch_inferior_event): Use scope_exit.
9394
9395 2019-01-23  Tom Tromey  <tom@tromey.com>
9396             Pedro Alves  <palves@redhat.com>
9397
9398         * breakpoint.c (create_breakpoint): Remove cleanup.
9399
9400 2019-01-23  Tom Tromey  <tom@tromey.com>
9401             Andrew Burgess  <andrew.burgess@embecosm.com>
9402             Pedro Alves  <palves@redhat.com>
9403
9404 2019-01-23  Pedro Alves  <palves@redhat.com>
9405
9406         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9407
9408 2019-01-23  Pedro Alves  <palves@redhat.com>
9409             Andrew Burgess  <andrew.burgess@embecosm.com>
9410
9411         * gdbthread.h: Include "common/forward-scope-exit.h".
9412         (scoped_finish_thread_state): Redefine custom class in terms of
9413         forward_scope_exit.
9414
9415 2019-01-23  Pedro Alves  <palves@redhat.com>
9416             Andrew Burgess  <andrew.burgess@embecosm.com>
9417
9418         * common/forward-scope-exit.h: New file.
9419
9420 2019-01-23  Pedro Alves  <palves@redhat.com>
9421             Andrew Burgess  <andrew.burgess@embecosm.com>
9422             Tom Tromey  <tom@tromey.com>
9423
9424         * common/scope-exit.h: New file.
9425
9426 2019-01-23  Pedro Alves  <palves@redhat.com>
9427
9428         * common/preprocessor.h (ESC): Rename to ...
9429         (ESC_PARENS): ... this.
9430         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9431         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9432
9433 2019-01-23  Tom Tromey  <tom@tromey.com>
9434
9435         * language.h (class scoped_switch_to_sym_language_if_auto):
9436         Initialize m_lang in both cases.
9437
9438 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9439
9440         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9441         with XCNEW.
9442
9443 2019-01-22  Tom Tromey  <tom@tromey.com>
9444
9445         * corelow.c: Do not include sys/file.h.
9446
9447 2019-01-22  Tom Tromey  <tom@tromey.com>
9448
9449         * tui/tui-wingeneral.h: Include gdb_curses.h.
9450
9451 2019-01-22  Tom Tromey  <tom@tromey.com>
9452
9453         * source-cache.h (class source_cache) <get_source_lines,
9454         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9455
9456 2019-01-22  Tom Tromey  <tom@tromey.com>
9457
9458         * remote-fileio.h (struct remote_target): Declare.
9459
9460 2019-01-22  Tom Tromey  <tom@tromey.com>
9461
9462         * python/py-arch.c: Do not include py-ref.h.
9463         * python/py-bpevent.c: Do not include py-ref.h.
9464         * python/py-cmd.c: Do not include py-ref.h.
9465         * python/py-continueevent.c: Do not include py-ref.h.
9466         * python/py-event.h: Do not include py-ref.h.
9467         * python/py-evtregistry.c: Do not include py-ref.h.
9468         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9469         * python/py-frame.c: Do not include py-ref.h.
9470         * python/py-framefilter.c: Do not include py-ref.h.
9471         * python/py-function.c: Do not include py-ref.h.
9472         * python/py-infevents.c: Do not include py-ref.h.
9473         * python/py-linetable.c: Do not include py-ref.h.
9474         * python/py-objfile.c: Do not include py-ref.h.
9475         * python/py-param.c: Do not include py-ref.h.
9476         * python/py-prettyprint.c: Do not include py-ref.h.
9477         * python/py-progspace.c: Do not include py-ref.h.
9478         * python/py-symbol.c: Do not include py-ref.h.
9479         * python/py-symtab.c: Do not include py-ref.h.
9480         * python/py-type.c: Do not include py-ref.h.
9481         * python/py-unwind.c: Do not include py-ref.h.
9482         * python/py-utils.c: Do not include py-ref.h.
9483         * python/py-value.c: Do not include py-ref.h.
9484         * python/py-varobj.c: Do not include py-ref.h.
9485         * python/py-xmethods.c: Do not include py-ref.h.
9486         * python/python.c: Do not include py-ref.h.
9487         * varobj.c: Do not include py-ref.h.
9488
9489 2019-01-22  Tom Tromey  <tom@tromey.com>
9490
9491         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9492         keyword for bcache.
9493
9494 2019-01-22  Tom Tromey  <tom@tromey.com>
9495
9496         * compile/compile-cplus-types.c: Remove a comment by #include.
9497
9498 2019-01-22  Tom Tromey  <tom@tromey.com>
9499
9500         * compile/gcc-c-plugin.h: Include compile-internal.h.
9501
9502 2019-01-22  Tom Tromey  <tom@tromey.com>
9503
9504         * stabsread.c (EXTERN): Do not define.
9505         (symnum, next_symbol_text_func, processing_gcc_compilation)
9506         (within_function, global_sym_chain, global_stabs)
9507         (previous_stab_code, this_object_header_files)
9508         (n_this_object_header_files)
9509         (n_allocated_this_object_header_files): Define.
9510         * stabsread.h (EXTERN): Never define.  Use "extern".
9511
9512 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9513
9514         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9515         history_value.
9516
9517 2019-01-21  Tom Tromey  <tom@tromey.com>
9518
9519         * ui-out.c: Fix includes.
9520         * tui/tui-source.c: Fix includes.
9521         * target.c: Fix includes.
9522         * remote.c: Fix includes.
9523         * regcache.c: Fix includes.
9524         * python/py-block.c: Fix includes.
9525         * printcmd.c: Fix includes.
9526         * or1k-tdep.c: Fix includes.
9527         * mi/mi-main.c: Fix includes.
9528         * m32r-tdep.c: Fix includes.
9529         * csky-tdep.c: Fix includes.
9530         * compile/compile-cplus-types.c: Fix includes.
9531         * cli/cli-interp.c: Fix includes.
9532
9533 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9534
9535         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9536         for padding.
9537
9538 2019-01-16  Tom Tromey  <tom@tromey.com>
9539
9540         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9541         earlier.
9542         (struct objfile) <msymbols_range>: Move from top level.
9543         <msymbols>: New method.
9544         (class objfile_msymbols): Remove.
9545         * symtab.c (default_collect_symbol_completion_matches_break_on):
9546         Update.
9547         * symmisc.c (dump_msymbols): Update.
9548         * stabsread.c (scan_file_globals): Update.
9549         * objc-lang.c (info_selectors_command, info_classes_command)
9550         (find_methods): Update.
9551         * minsyms.c (find_solib_trampoline_target): Update.
9552         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9553         * coffread.c (coff_symfile_read): Update.
9554         * ada-lang.c (ada_lookup_simple_minsym)
9555         (ada_collect_symbol_completion_matches): Update.
9556
9557 2019-01-16  Tom Tromey  <tom@tromey.com>
9558
9559         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9560         type.  Remove no-argument constructor.
9561         <iterator::operator++>: Simplify.
9562         <begin>: Update.
9563         <end>: Use minimal_symbol_count.
9564
9565 2019-01-16  Tom Tromey  <tom@tromey.com>
9566
9567         * objfiles.h (struct objfile) <psymtabs>: New method.
9568         (class objfile_psymtabs): Remove.
9569         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9570         typedef.
9571         <range>: New method.
9572         (require_partial_symbols): Change return type.
9573         * psymtab.c (require_partial_symbols)
9574         (psym_expand_symtabs_matching): Update.
9575         * mdebugread.c (parse_partial_symbols): Update.
9576         * dbxread.c (dbx_end_psymtab): Update.
9577
9578 2019-01-15  Tom Tromey  <tom@tromey.com>
9579
9580         * symtab.c (lookup_objfile_from_block)
9581         (lookup_symbol_in_objfile_symtabs)
9582         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9583         (find_line_symtab, info_sources_command)
9584         (default_collect_symbol_completion_matches_break_on)
9585         (make_source_files_completion_list): Update.
9586         * symmisc.c (print_objfile_statistics, dump_objfile)
9587         (maintenance_print_symbols, maintenance_info_symtabs)
9588         (maintenance_check_symtabs, maintenance_info_line_tables):
9589         Update.
9590         * source.c (select_source_symtab)
9591         (forget_cached_source_info_for_objfile): Update.
9592         * objfiles.h (class objfile_compunits): Remove.
9593         (struct objfile) <compunits_range>: New typedef.
9594         (compunits): New method.
9595         * objfiles.c (objfile_relocate1): Update.
9596         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9597         * maint.c (count_symtabs_and_blocks): Update.
9598         * linespec.c (iterate_over_all_matching_symtabs): Update.
9599         * cp-support.c (add_symbol_overload_list_qualified): Update.
9600         * coffread.c (coff_symtab_read): Update.
9601         * ada-lang.c (add_nonlocal_symbols)
9602         (ada_collect_symbol_completion_matches)
9603         (ada_add_global_exceptions): Update.
9604
9605 2019-01-15  Tom Tromey  <tom@tromey.com>
9606
9607         * progspace.h (program_space) <objfiles_safe_range>: New
9608         typedef.
9609         <objfiles_safe>: New method.
9610         * objfiles.h (class all_objfiles_safe): Remove.
9611         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9612         * jit.c (jit_inferior_exit_hook): Update.
9613
9614 2019-01-17  Tom Tromey  <tom@tromey.com>
9615
9616         * progspace.h (program_space) <objfiles_range>: New typedef.
9617         <objfiles>: New method.
9618         <objfiles_head>: Rename from objfiles.
9619         (object_files): Update.
9620         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9621         * guile/scm-pretty-print.c
9622         (ppscm_find_pretty_printer_from_objfiles): Update.
9623         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9624         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9625         Update.
9626         * python/py-progspace.c (pspy_get_objfiles): Update.
9627         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9628         Update.
9629         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9630         (objfpy_lookup_objfile_by_build_id): Update.
9631         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9632         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9633         Update.
9634         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9635         (expand_symtab_containing_pc, lookup_objfile_from_block)
9636         (lookup_static_symbol, basic_lookup_transparent_type)
9637         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9638         (find_line_symtab, info_sources_command)
9639         (default_collect_symbol_completion_matches_break_on)
9640         (make_source_files_completion_list, find_main_name): Update.
9641         * symmisc.c (print_symbol_bcache_statistics)
9642         (print_objfile_statistics, maintenance_print_symbols)
9643         (maintenance_print_msymbols, maintenance_print_objfiles)
9644         (maintenance_info_symtabs, maintenance_check_symtabs)
9645         (maintenance_expand_symtabs, maintenance_info_line_tables):
9646         Update.
9647         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9648         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9649         (map_overlay_command, unmap_overlay_command)
9650         (simple_overlay_update, expand_symtabs_matching)
9651         (map_symbol_filenames): Update.
9652         * symfile-debug.c (set_debug_symfile): Update.
9653         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9654         Update.
9655         * source.c (select_source_symtab, forget_cached_source_info):
9656         Update.
9657         * solib.c (solib_read_symbols): Update.
9658         * solib-spu.c (append_ocl_sos): Update.
9659         * psymtab.c (maintenance_print_psymbols)
9660         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9661         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9662         * printcmd.c (info_symbol_command): Update.
9663         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9664         Update.
9665         * objfiles.h (class all_objfiles): Remove.
9666         * objfiles.c (have_partial_symbols, have_full_symbols)
9667         (have_minimal_symbols, qsort_cmp, update_section_map)
9668         (shared_objfile_contains_address_p)
9669         (default_iterate_over_objfiles_in_search_order): Update.
9670         * objc-lang.c (info_selectors_command, info_classes_command)
9671         (find_methods): Update.
9672         * minsyms.c (find_solib_trampoline_target): Update.
9673         * maint.c (maintenance_info_sections)
9674         (maintenance_translate_address, count_symtabs_and_blocks):
9675         Update.
9676         * main.c (captured_main_1): Update.
9677         * linux-thread-db.c (try_thread_db_load_from_pdir)
9678         (has_libpthread): Update.
9679         * linespec.c (iterate_over_all_matching_symtabs)
9680         (search_minsyms_for_name): Update.
9681         * jit.c (jit_find_objf_with_entry_addr): Update.
9682         * hppa-tdep.c (find_unwind_entry)
9683         (hppa_lookup_stub_minimal_symbol): Update.
9684         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9685         Update.
9686         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9687         (elf_gnu_ifunc_resolve_by_got): Update.
9688         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9689         * dwarf-index-write.c (save_gdb_index_command): Update.
9690         * cp-support.c (add_symbol_overload_list_qualified): Update.
9691         * breakpoint.c (create_overlay_event_breakpoint)
9692         (create_longjmp_master_breakpoint)
9693         (create_std_terminate_master_breakpoint)
9694         (create_exception_master_breakpoint): Update.
9695         * blockframe.c (find_pc_partial_function): Update.
9696         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9697         (ada_collect_symbol_completion_matches)
9698         (ada_add_global_exceptions): Update.
9699
9700 2019-01-17  Tom Tromey  <tom@tromey.com>
9701
9702         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9703         declare VEC.
9704         (solib_target_parse_libraries): Change return type.
9705         (library_list_start_segment, library_list_start_section)
9706         (library_list_end_library, library_list_start_library); Update.
9707         (solib_target_free_library_list): Remove.
9708         (solib_target_parse_libraries): Remove cleanup.  Change return
9709         type.
9710         (solib_target_current_sos): Update.
9711
9712 2019-01-17  Tom Tromey  <tromey@bapiya>
9713
9714         * valprint.c: Replace "the the" with "the".
9715         * symtab.c: Replace "the the" with "the".
9716         * solib.c: Replace "the the" with "the".
9717         * solib-dsbt.c: Replace "the the" with "the".
9718         * linespec.c: Replace "the the" with "the".
9719         * dwarf2loc.h: Replace "the the" with "the".
9720         * amd64-windows-tdep.c: Replace "the the" with "the".
9721         * aarch64-tdep.c: Replace "the the" with "the".
9722
9723 2019-01-16  Keith Seitz  <keiths@redhat.com>
9724
9725         PR gdb/23773
9726         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9727         <builder>: Rename to ..
9728         <m_builder>: ... this and make private.
9729         (dwarf2_cu::get_builder): New method.  Change all users of
9730         `builder' to use this method.
9731         (dwarf2_start_symtab): Move to ...
9732         (dwarf2_cu::start_symtab): ... here.  Update all callers
9733         (setup_type_unit_groups): Move to ...
9734         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9735         callers.
9736         (dwarf2_cu::reset_builder): New method.
9737         (process_full_compunit, process_full_type_unit): Use
9738         dwarf2_cu::reset_builder.
9739         (follow_die_offset): Record the ancestor CU if it is different
9740         from the followed DIE's CU.
9741         (follow_die_sig_1): Likewise.
9742
9743 2019-01-15  Tom Tromey  <tom@tromey.com>
9744
9745         * remote.c (class remote_state) <buf>: Now a char_vector.
9746         <buf_size>: Remove.
9747         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9748         parameter.
9749         (remote_target::getpkt_or_notif_sane_1)
9750         (remote_target::getpkt_sane)
9751         (remote_target::getpkt_or_notif_sane): Likewise.
9752         (class remote_target) <putpkt>: New overload.
9753         (remote_target::read_frame): Change type of "buf_p".  Remove
9754         sizeof_p parameter.
9755         (packet_ok): New overload.
9756         (packet_check_result): New overload.
9757         Update all uses.
9758
9759 2019-01-14  Tom Tromey  <tom@tromey.com>
9760
9761         * remote-notif.c (handle_notification, remote_notif_ack)
9762         (remote_notif_parse): Make "buf" const.
9763         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9764         const.
9765         (remote_notif_parse, remote_notif_ack, handle_notification):
9766         Likewise.
9767         * remote.c (remote_notif_stop_parse): Make "buf" const.
9768         (remote_target::remote_parse_stop_reply): Make "buf" const.
9769         (remote_notif_stop_ack): Make "buf" const.
9770
9771 2019-01-14  Tom Tromey  <tom@tromey.com>
9772
9773         * remote.c (remote_console_output): Make parameter const.
9774
9775 2019-01-14  Tom Tromey  <tom@tromey.com>
9776
9777         * target-debug.h (target_debug_print_signals): Constify.
9778         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9779         * procfs.c (procfs_target::pass_signals): Update.
9780         * linux-nat.c (linux_nat_target::pass_signals): Update.
9781         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9782         * target-delegates.c: Rebuild.
9783         * remote.c (remote_target::program_signals): Update.
9784         (remote_target::pass_signals): Update.
9785         * target.c (target_pass_signals): Constify argument.
9786         (target_program_signals): Likewise.
9787         * target.h (struct target_ops) <pass_signals, program_signals>:
9788         Constify argument.
9789         (target_pass_signals, target_program_signals): Constify argument.
9790
9791 2019-01-14  Tom Tromey  <tom@tromey.com>
9792
9793         PR tui/28819:
9794         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9795
9796 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9797
9798         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9799         field.
9800         * rs6000-tdep.c: Include reggroups.h.
9801         (IS_V_ALIAS_PSEUDOREG): Define.
9802         (rs6000_register_name): Return names for the "vX" aliases.
9803         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9804         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9805         aliases.  Call default_register_reggroup_p for all other
9806         pseudo-registers.
9807         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9808         New functions.
9809         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9810         Handle "vX" aliases.
9811         (v_alias_pseudo_register_collect): New function.
9812         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9813         (rs6000_gdbarch_init): Initialize "vX" aliases as
9814         pseudo-registers.  Restore registration of
9815         rs6000_pseudo_register_reggroup_p with
9816         set_tdesc_pseudo_register_reggroup_p.
9817
9818 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9819
9820         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9821         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9822         set_gdbarch_num_pseudo_regs.
9823
9824 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9825
9826         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9827         Remove arg prefixname, add do_set and do_show.
9828         Add member functions set_list and show_list.
9829         * cli/cli-style.c (class cli_style_option): Update accordingly.
9830         (style_set_list): Move to file scope.
9831         (style_show_list): Likewise.
9832         (set_style): Call help_list.
9833         (show_style): Call cmd_show_list.
9834         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9835         Update to use the new macro.
9836
9837 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9838
9839         * ada-lang.c (_initialize_ada_language): Expand the help text
9840         for the "catch exception" command.
9841
9842 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9843
9844         * symtab.c (matching_obj_sections): Initialize obj,
9845         declare it closer to its usage.
9846
9847 2019-01-10  Tom Tromey  <tom@tromey.com>
9848
9849         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9850         (basic_inf_threads_range): Remove.
9851         (inf_threads_range, inf_non_exited_threads_range)
9852         (safe_inf_threads_range): Use next_adapter.
9853
9854 2019-01-10  Keith Seitz  <keiths@redhat.com>
9855
9856         PR gdb/23712
9857         PR symtab/23010
9858         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9859         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9860
9861 2019-01-10  Keith Seitz  <keiths@redhat.com>
9862
9863         PR gdb/23712
9864         PR symtab/23010
9865         * dictionary.c (pending_to_vector): Remove.
9866         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9867         Remove _1 suffix, replacing functions of the same name.  Update
9868         all callers.
9869         (dict_create_hashed, dict_create_hashed_expandable)
9870         (dict_create_linear, dict_create_linear_expandable, dict_free)
9871         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9872         Make functions static.
9873
9874 2019-01-10  Keith Seitz  <keiths@redhat.com>
9875
9876         PR gdb/23712
9877         PR symtab/23010
9878         * dictionary.h (struct dictionary): Replace declaration with
9879         multidictionary.
9880         (dict_create_hashed, dict_create_hashed_expandable)
9881         (dict_create_linear, dict_create_linear_expandable)
9882         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9883         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9884         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9885         taking multidictionary argument.
9886         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9887         * block.h (struct block) <dict>: Change to multidictionary
9888         and rename `multidict'.
9889         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9890         symmisc.c: Update all dictionary references to multidictionary.
9891
9892 2019-01-10  Keith Seitz  <keiths@redhat.com>
9893
9894         PR gdb/23712
9895         PR symtab/23010
9896         * dictionary.c: Include unordered_map.
9897         (pending_to_vector): New function.
9898         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9899         Rewrite the non-"_1" functions to take vector instead
9900         of linked list.
9901         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9902         "new" _1 versions of the same name.
9903         (multidictionary): Define.
9904         (std::hash<enum language): New definition.
9905         (collate_pending_symbols_by_language, mdict_create_hashed)
9906         (mdict_create_hashed_expandable, mdict_create_linear)
9907         (mdict_create_linear_expandable, mdict_free)
9908         (find_language_dictionary, create_new_language_dictionary)
9909         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9910         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9911         (mdict_size, mdict_empty): New functions.
9912         * dictionary.h (mdict_iterator): Define.
9913
9914 2019-01-10  Pedro Alves  <palves@redhat.com>
9915
9916         * breakpoint.c (read_uploaded_action)
9917         (create_tracepoint_from_upload): Adjust to use
9918         gdb::unique_xmalloc_ptr.
9919         * ctf.c (ctf_write_uploaded_tp):
9920         (SET_ARRAY_FIELD): Use emplace_back.
9921         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9922         * tracefile-tfile.c (tfile_write_uploaded_tp):
9923         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9924         gdb::unique_xmalloc_ptr.
9925         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9926         at_string, cond_string, cmd_strings>: Replace char pointers
9927         with gdb::unique_xmalloc_ptr.
9928
9929 2019-01-10  Pedro Alves  <palves@redhat.com>
9930
9931         * solib-target.c (library_list_start_library): Don't xstrdup name.
9932
9933 2019-01-10  Pedro Alves  <palves@redhat.com>
9934
9935         * mdebugread.c (parse_partial_symbols): Use
9936         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9937
9938 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9939
9940         * linux-fork.c (scoped_switch_fork_info)
9941         <~scoped_switch_fork_info>: Fix incorrect variable name.
9942
9943 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9944
9945         * linux-fork.c (scoped_switch_fork_info)
9946         <scoped_switch_fork_info>: Make explicit.
9947         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9948
9949 2019-01-10  Tom Tromey  <tom@tromey.com>
9950
9951         * objfiles.h (objfile::reset_psymtabs): Update.
9952         * objfiles.c (objfile::objfile): Update.
9953         * psymtab.h (psymtab_storage::obstack): Update.
9954         (psymtab_storage::m_obstack): Use gdb::optional.
9955         (class psymtab_storage): Update comment.  Remove objfile
9956         parameter.
9957         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9958
9959 2019-01-10  Tom Tromey  <tom@tromey.com>
9960
9961         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9962         <free_psymtabs>: Now private.
9963         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9964         (allocate_psymtab): Use new method.
9965
9966 2019-01-10  Tom Tromey  <tom@tromey.com>
9967
9968         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9969         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9970         * mdebugread.c (parse_partial_symbols): Use
9971         allocate_dependencies.
9972         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9973         allocate_dependencies.
9974         (process_psymtab_comp_unit_reader)
9975         (build_type_psymtab_dependencies): Likewise.
9976         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9977
9978 2019-01-10  Tom Tromey  <tom@tromey.com>
9979
9980         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9981         PSYMBOL_SET_LANGUAGE.
9982         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9983
9984 2019-01-10  Tom Tromey  <tom@tromey.com>
9985
9986         * psymtab.h (psymtab_storage::obstack): New method.
9987         <m_obstack>: Rename from obstack; now private.
9988         * psymtab.c (psymtab_storage): Update.
9989         * dwarf2read.c (create_addrmap_from_index)
9990         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9991         Update.
9992
9993 2019-01-10  Tom Tromey  <tom@tromey.com>
9994
9995         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9996         * objfiles.h (objfile::reset_psymtabs): New method.
9997
9998 2019-01-10  Tom Tromey  <tom@tromey.com>
9999
10000         * symmisc.c (print_symbol_bcache_statistics): Update.
10001         (print_objfile_statistics): Update.
10002         * symfile.c (reread_symbols): Update.
10003         * psymtab.h (class psymtab_storage): New.
10004         * psymtab.c (psymtab_storage): New constructor.
10005         (~psymtab_storage): New destructor.
10006         (require_partial_symbols): Update.
10007         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
10008         (find_pc_sect_psymtab, find_pc_sect_psymbol)
10009         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
10010         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
10011         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
10012         (start_psymtab_common, end_psymtab_common)
10013         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
10014         (allocate_psymtab): Update.
10015         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
10016         Update.
10017         (dump_psymtab_addrmap, maintenance_print_psymbols)
10018         (maintenance_check_psymtabs): Update.
10019         (class objfile_psymtabs): Move to objfiles.h.
10020         * psympriv.h (discard_psymtab): Now inline.
10021         (psymtab_discarder::psymtab_discarder): Update.
10022         (psymtab_discarder::~psymtab_discarder): Update.
10023         (ALL_OBJFILE_PSYMTABS): Rewrite.
10024         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
10025         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
10026         Remove fields.
10027         <partial_symtabs>: New field.
10028         (class objfile_psymtabs): Move from psymtab.h.  Update.
10029         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
10030         psymbol_cache.
10031         (objfile::~objfile): Don't destroy psymbol_cache.
10032         * mdebugread.c (parse_partial_symbols): Update.
10033         * dwarf2read.c (create_addrmap_from_index)
10034         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10035         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
10036         (add_partial_subprogram, dwarf2_ranges_read): Update.
10037         * dwarf-index-write.c (write_address_map)
10038         (write_one_signatured_type, recursively_write_psymbols)
10039         (class debug_names, class debug_names, write_psymtabs_to_index):
10040         Update.
10041
10042 2019-01-10  Tom Tromey  <tom@tromey.com>
10043
10044         * symtab.h (SYMBOL_SET_NAMES): Update.
10045         (symbol_set_names): Update.
10046         (MSYMBOL_SET_NAMES): Update.
10047         * symtab.c (symbol_set_names): Change argument to be an
10048         objfile_per_bfd_storage.
10049         * psymtab.c (add_psymbol_to_bcache): Update.
10050         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
10051
10052 2019-01-10  Tom Tromey  <tom@tromey.com>
10053
10054         * symtab.c (create_demangled_names_hash): Change argument to be an
10055         objfile_per_bfd_storage.
10056         (symbol_set_names): Update.
10057
10058 2019-01-10  Tom Tromey  <tom@tromey.com>
10059
10060         * xcoffread.c (xcoff_initial_scan): Unconditionally call
10061         init_psymbol_list.
10062         * psymtab.c (init_psymbol_list): Do nothing if already called.
10063         * psympriv.h (init_psymbol_list): Add comment.
10064         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
10065         init_psymbol_list.
10066         * dbxread.c (dbx_symfile_read): Unconditionally call
10067         init_psymbol_list.
10068
10069 2019-01-10  Tom Tromey  <tom@tromey.com>
10070
10071         * xcoffread.c (scan_xcoff_symtab): Update.
10072         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
10073         "where".
10074         * mdebugread.c (parse_partial_symbols)
10075         (handle_psymbol_enumerators): Update.
10076         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
10077         * dbxread.c (read_dbx_symtab): Update.
10078         * psympriv.h (psymbol_placement): New enum.
10079         (add_psymbol_to_list): Update.
10080
10081 2019-01-10  Tom Tromey  <tom@tromey.com>
10082
10083         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
10084         static_psymbols parameters.
10085         (scan_xcoff_symtab): Update.
10086         * psymtab.c (start_psymtab_common): Remove global_psymbols and
10087         static_psymbols parameters.
10088         * psympriv.h (start_psymtab_common): Update.
10089         * mdebugread.c (parse_partial_symbols): Update.
10090         * dwarf2read.c (create_partial_symtab): Update.
10091         * dbxread.c (read_dbx_symtab): Update.
10092         (start_psymtab): Remove global_psymbols and static_psymbols
10093         parameters.
10094
10095 2019-01-10  Tom Tromey  <tom@tromey.com>
10096
10097         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
10098         * psymtab.c (allocate_psymtab): Add comment.
10099         * psympriv.h (allocate_psymtab): Add comment.
10100         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
10101         initializations.
10102         * dbxread.c (dbx_end_psymtab): Remove some initializations.
10103
10104 2019-01-10  Tom Tromey  <tom@tromey.com>
10105
10106         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10107         Don't declare.
10108         * mipsread.c: Include mdebugread.h.
10109         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10110         Declare.
10111         * elfread.c: Include mdebugread.h.
10112
10113 2019-01-09  Tom Tromey  <tom@tromey.com>
10114
10115         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
10116         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
10117         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
10118         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
10119         (psym_lookup_symbol, psym_find_last_source_symtab)
10120         (psym_forget_cached_source_info, psym_print_stats)
10121         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
10122         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
10123         (psym_map_matching_symbols, psym_expand_symtabs_matching)
10124         (psym_find_compunit_symtab_by_address)
10125         (maintenance_print_psymbols, maintenance_info_psymtabs)
10126         (maintenance_check_psymtabs): Use ranged for.
10127         * psymtab.h (class objfile_psymtabs): New.
10128         (require_partial_symbols): Return objfile_psymtabs.
10129         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
10130
10131 2019-01-09  Tom Tromey  <tom@tromey.com>
10132
10133         * symfile.c (overlay_invalidate_all, find_pc_overlay)
10134         (find_pc_mapped_section, list_overlays_command)
10135         (map_overlay_command, unmap_overlay_command)
10136         (simple_overlay_update): Use all_objfiles.
10137         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
10138         * printcmd.c (info_symbol_command): Use all_objfiles.
10139         * objfiles.h (ALL_OBJSECTIONS): Remove.
10140         * maint.c (maintenance_translate_address): Use all_objfiles.
10141         * gcore.c (gcore_create_callback): Use all_objfiles.
10142         (objfile_find_memory_regions): Likewise.
10143
10144 2019-01-09  Tom Tromey  <tom@tromey.com>
10145
10146         * symtab.c (find_line_symtab, info_sources_command)
10147         (make_source_files_completion_list): Use objfile_compunits.
10148         * source.c (select_source_symtab): Use objfile_compunits.
10149         * objfiles.h (struct objfile): Update comment.
10150         (ALL_OBJFILES): Remove.
10151         (ALL_FILETABS): Remove.
10152         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
10153         objfile_compunits.
10154
10155 2019-01-09  Tom Tromey  <tom@tromey.com>
10156
10157         * symmisc.c (print_objfile_statistics, dump_objfile)
10158         (maintenance_print_symbols): Use compunit_filetabs.
10159         * source.c (forget_cached_source_info_for_objfile): Use
10160         compunit_filetabs.
10161         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
10162         (ALL_FILETABS): Use compunit_filetabs.
10163         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
10164         * coffread.c (coff_symtab_read): Use compunit_filetabs.
10165
10166 2019-01-09  Tom Tromey  <tom@tromey.com>
10167
10168         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
10169         (compunit_filetabs): New.
10170         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
10171         compunit_filetabs.
10172         (info_sources_command, make_source_files_completion_list): Remove
10173         declaration.
10174         * symmisc.c (print_objfile_statistics, dump_objfile)
10175         (maintenance_print_symbols): Remove declaration.
10176         (maintenance_info_symtabs): Use compunit_filetabs.
10177         (maintenance_info_line_tables): Likewise.
10178         * source.c (select_source_symtab): Change local variable name.
10179         (forget_cached_source_info_for_objfile): Remove declaration.
10180         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10181         * objfiles.c (objfile_relocate1): Remove declaration.
10182         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10183         declaration.
10184         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10185         * coffread.c (coff_symtab_read): Remove declaration.
10186         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10187         compunit_filetabs.
10188
10189 2019-01-09  Tom Tromey  <tom@tromey.com>
10190
10191         * symtab.c (lookup_objfile_from_block)
10192         (find_pc_sect_compunit_symtab, search_symbols)
10193         (default_collect_symbol_completion_matches_break_on): Use
10194         objfile_compunits.
10195         * objfiles.h (ALL_COMPUNITS): Remove.
10196         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10197         * cp-support.c (add_symbol_overload_list_qualified): Use
10198         objfile_compunits.
10199         * ada-lang.c (ada_collect_symbol_completion_matches)
10200         (ada_add_global_exceptions): Use objfile_compunits.
10201
10202 2019-01-09  Tom Tromey  <tom@tromey.com>
10203
10204         * source.c (select_source_symtab)
10205         (forget_cached_source_info_for_objfile): Remove declaration.
10206         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10207         declaration.
10208         * maint.c (count_symtabs_and_blocks): Remove declaration.
10209         * cp-support.c (add_symbol_overload_list_qualified): Remove
10210         declaration.
10211         * coffread.c (coff_symtab_read): Remove declaration.
10212         * symtab.c (lookup_symbol_in_objfile_symtabs)
10213         (basic_lookup_transparent_type_1): Use objfile_compunits.
10214         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10215         (info_sources_command, search_symbols)
10216         (default_collect_symbol_completion_matches_break_on)
10217         (make_source_files_completion_list): Remove declaration.
10218         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10219         (ada_collect_symbol_completion_matches)
10220         (ada_add_global_exceptions): Remove declaration.
10221         * linespec.c (iterate_over_all_matching_symtabs): Use
10222         objfile_compunits.
10223         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10224         (class objfile_compunits): New.
10225         (ALL_COMPUNITS): Use objfile_compunits.
10226         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10227         (maintenance_check_symtabs, maintenance_info_line_tables): Use
10228         objfile_compunits.
10229         * objfiles.c (objfile_relocate1): Use objfile_compunits.
10230
10231 2019-01-09  Tom Tromey  <tom@tromey.com>
10232
10233         * symtab.c (search_symbols)
10234         (default_collect_symbol_completion_matches_break_on): Use
10235         objfile_msymbols.
10236         * ada-lang.c (ada_lookup_simple_minsym)
10237         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10238         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10239         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10240         objfile_msymbols.
10241         * coffread.c (coff_symfile_read): Use objfile_msymbols.
10242         * symmisc.c (dump_msymbols): Use objfile_msymbols.
10243         * objc-lang.c (find_methods): Use objfile_msymbols.
10244         (info_selectors_command, info_classes_command): Likewise.
10245         * stabsread.c (scan_file_globals): Use objfile_msymbols.
10246         * objfiles.h (class objfile_msymbols): New.
10247         (ALL_OBJFILE_MSYMBOLS): Remove.
10248         (ALL_MSYMBOLS): Remove.
10249
10250 2019-01-09  Tom Tromey  <tom@tromey.com>
10251
10252         * common/next-iterator.h (next_adapter): Add Iterator template
10253         parameter.
10254         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10255         (class all_objfiles_safe): New.
10256         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10257         * objfiles.c (put_objfile_before): Update comment.
10258         (add_separate_debug_objfile): Likewise.
10259         (free_all_objfiles): Use all_objfiles_safe.
10260         (objfile_purge_solibs): Likewise.
10261
10262 2019-01-09  Tom Tromey  <tom@tromey.com>
10263
10264         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10265         (expand_symtab_containing_pc, lookup_static_symbol)
10266         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10267         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10268         all_objfiles.
10269         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10270         * breakpoint.c (create_overlay_event_breakpoint)
10271         (create_longjmp_master_breakpoint)
10272         (create_std_terminate_master_breakpoint)
10273         (create_exception_master_breakpoint): Use all_objfiles.
10274         * linux-thread-db.c (try_thread_db_load_from_pdir)
10275         (has_libpthread): Use all_objfiles.
10276         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10277         * linespec.c (iterate_over_all_matching_symtabs)
10278         (search_minsyms_for_name): Use all_objfiles.
10279         * maint.c (maintenance_info_sections): Use all_objfiles.
10280         * main.c (captured_main_1): Use all_objfiles.
10281         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10282         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10283         * guile/scm-pretty-print.c
10284         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10285         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10286         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10287         (maintenance_print_msymbols): Use all_objfiles.
10288         * source.c (select_source_symtab): Use all_objfiles.
10289         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10290         * symfile.c (remove_symbol_file_command)
10291         (expand_symtabs_matching, map_symbol_filenames): Use
10292         all_objfiles.
10293         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10294         all_objfiles.
10295         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10296         * objc-lang.c (find_methods): Use all_objfiles.
10297         * objfiles.c (have_partial_symbols, have_full_symbols)
10298         (have_minimal_symbols, qsort_cmp)
10299         (default_iterate_over_objfiles_in_search_order): Use
10300         all_objfiles.
10301         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10302         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10303         (maintenance_check_psymtabs): Use all_objfiles.
10304         (ALL_PSYMTABS): Remove.
10305         * compile/compile-object-run.c (do_module_cleanup): Use
10306         all_objfiles.
10307         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10308         * cp-support.c (add_symbol_overload_list_qualified): Use
10309         all_objfiles.
10310         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10311         Use all_objfiles.
10312         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10313         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10314         all_objfiles.
10315         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10316         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10317         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10318         Uses all_objfiles.
10319         * solib.c (solib_read_symbols): Use all_objfiles
10320
10321 2019-01-09  Tom Tromey  <tom@tromey.com>
10322
10323         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10324         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10325         all_objfiles.
10326         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10327         * symmisc.c (print_symbol_bcache_statistics)
10328         (print_objfile_statistics, maintenance_print_objfiles)
10329         (maintenance_info_symtabs, maintenance_check_symtabs)
10330         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10331         all_objfiles.
10332         * source.c (forget_cached_source_info): Use all_objfiles.
10333         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10334         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10335         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10336         * objfiles.c (update_section_map): Use all_objfiles.
10337         (shared_objfile_contains_address_p): Likewise.
10338         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10339         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10340
10341 2019-01-09  Tom Tromey  <tom@tromey.com>
10342
10343         * common/next-iterator.h: New file.
10344         * objfiles.h (class all_objfiles): New.
10345         (struct objfile_iterator): New.
10346
10347 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10348
10349         * NEWS: Move the description of the changed "frame", "select-frame",
10350          and "info frame" commands to the Changed commands section.
10351
10352 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10353
10354         * gdbtypes.c (check_stub_method_group): Remove handling of old
10355         mangling schemes.
10356         * linespec.c (find_methods): Likewise.
10357         * stabsread.c (read_member_functions): Likewise.
10358         * valops.c (search_struct_method): Likewise.
10359         (value_struct_elt_for_reference): Likewise.
10360         * NEWS: Mention this change.
10361
10362 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10363
10364         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10365         print_source_lines.
10366         * source.c (print_source_lines_base): Update line number check.
10367         (print_source_lines): New function.
10368         (source_lines_range::source_lines_range): New function.
10369         * source.h (class source_lines_range): New class.
10370         (print_source_lines): New declaration.
10371
10372 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10373
10374         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10375
10376 2019-01-08  Tom Tromey  <tom@tromey.com>
10377             Simon Marchi  <simon.marchi@ericsson.com>
10378
10379         PR gdb/24060
10380         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10381         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10382         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10383         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10384         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10385         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10386
10387 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10388
10389         * source.c (select_source_symtab): Move header comment to
10390         declaration in source.h.
10391         (forget_cached_source_info_for_objfile): Likewise.
10392         (forget_cached_source_info): Likewise.
10393         (identify_source_line): Likewise.
10394         * source.h (identify_source_line): Move declaration from symtab.h
10395         and add comment from source.c
10396         (print_source_lines): Likewise.
10397         (forget_cached_source_info_for_objfile): Likewise.
10398         (forget_cached_source_info): Likewise.
10399         (select_source_symtab): Likewise.
10400         (enum print_source_lines_flag): Move definition from symtab.h.
10401         * symtab.h (identify_source_line): Move declaration to source.h.
10402         (print_source_lines): Likewise.
10403         (forget_cached_source_info_for_objfile): Likewise.
10404         (forget_cached_source_info): Likewise.
10405         (select_source_symtab): Likewise.
10406         (enum print_source_lines_flag): Move definition to source.h.
10407         * tui/tui-hooks.c: Add 'source.h' include.
10408
10409 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10410
10411         * source.c (print_source_lines_base): Handle requests to print
10412         reverse line number sequences, and guard against empty lines
10413         string.
10414
10415 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10416
10417         * source.c (print_source_lines_base): Fix skip of '\r' if next
10418         character is '\n'.
10419
10420 2019-01-06  Tom Tromey  <tom@tromey.com>
10421
10422         * c-exp.y (struct c_parse_state) <macro_original_text,
10423         expansion_obstack>: New member.
10424         (macro_original_text, expansion_obstack): Remove globals.
10425         (scan_macro_expansion, scanning_macro_expansion)
10426         (finished_macro_expansion): Update.
10427         (scan_macro_cleanup): Remove.
10428         (yylex, c_parse): Update.
10429
10430 2019-01-06  Tom Tromey  <tom@tromey.com>
10431
10432         * c-exp.y (struct c_parse_state) <strings>: New member.
10433         (operator_stoken): Update.
10434
10435 2019-01-06  Tom Tromey  <tom@tromey.com>
10436
10437         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10438         (union type_stack_elt) <typelist_val>: Now a pointer to
10439         std::vector.
10440         (type_stack_cleanup): Don't declare.
10441         (push_typelist): Update.
10442         * parse.c (pop_typelist): Return a std::vector.
10443         (push_typelist): Take a std::vector.
10444         (follow_types): Update.  Do not free args.
10445         (type_stack_cleanup): Remove.
10446         * c-exp.y (struct c_parse_state): New.
10447         (cpstate): New global.
10448         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10449         (nonempty_typelist): Update.
10450         (func_mod): Create a new vector.
10451         (c_parse): Create a c_parse_state.
10452         (check_parameter_typelist): Do not delete params.
10453         (function_method): Update.  Do not delete type_list.
10454
10455 2019-01-06  Tom Tromey  <tom@tromey.com>
10456
10457         PR gdb/28155:
10458         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10459         check_typedef.
10460         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10461         (print_return_value): Likewise.
10462
10463 2019-01-05  Tom Tromey  <tom@tromey.com>
10464
10465         * contrib/cleanup_check.py: Remove.
10466         * contrib/gcc-with-excheck: Remove.
10467         * contrib/exsummary.py: Remove.
10468         * contrib/excheck.py: Remove.
10469
10470 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10471
10472         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10473         NULL. Initialize tpprev to NULL instead of assigning it
10474         to NULL on the next statement.
10475         * windows-nat.c (windows_delete_thread): Remove check for
10476         main_thread_id before printing thread exit notifications.
10477         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10478         Remove thread ID check against main_thread_id.
10479         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10480         windows_delete_thread.
10481         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10482
10483 2019-01-04  Tom Tromey  <tom@tromey.com>
10484
10485         * compile/compile.c (_initialize_compile): Use upper case for
10486         metasyntactic variables.
10487         * symmisc.c (_initialize_symmisc): Use upper case for
10488         metasyntactic variables.
10489         * psymtab.c (_initialize_psymtab): Use upper case for
10490         metasyntactic variables.
10491         * demangle.c (demangle_command): Use upper case for metasyntactic
10492         variables.
10493         (_initialize_demangler): Likewise.
10494         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10495         variables.
10496
10497 2019-01-03  Tom Tromey  <tom@tromey.com>
10498
10499         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10500
10501 2019-01-03  Tom Tromey  <tom@tromey.com>
10502
10503         * python/py-symtab.c (salpy_str): Update.
10504         (struct salpy_sal_object) <symtab>: Now a PyObject.
10505         (salpy_dealloc): Update.
10506         (del_objfile_sal): Use gdbpy_ref.
10507
10508 2019-01-03  Tom Tromey  <tom@tromey.com>
10509
10510         * python/py-type.c (convert_field): Use new_reference.  Return
10511         gdbpy_ref.
10512         (make_fielditem): Return gdbpy_ref.
10513         (typy_fields): Update.
10514         (typy_getitem): Update.
10515         (field_name): Return gdbpy_ref.  Use new_reference.
10516         (typy_iterator_iternext): Update.
10517
10518 2019-01-03  Tom Tromey  <tom@tromey.com>
10519
10520         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10521
10522 2019-01-03  Tom Tromey  <tom@tromey.com>
10523
10524         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10525         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10526         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10527         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10528         (pspy_set_type_printers): Likewise.
10529         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10530         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10531         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10532         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10533         (objfpy_set_type_printers): Likewise.
10534
10535 2019-01-03  Tom Tromey  <tom@tromey.com>
10536
10537         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10538         (gdbpy_print_stack): Use gdbpy_err_fetch.
10539         * python/python-internal.h (class gdbpy_err_fetch): New class.
10540         (class gdbpy_enter) <m_error_type, m_error_value,
10541         m_error_traceback>: Remove.
10542         <m_error>: New member.
10543         (gdbpy_exception_to_string): Don't declare.
10544         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10545         * python/py-value.c (convert_value_from_python): Use
10546         gdbpy_err_fetch.
10547         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10548         gdbpy_exception_to_string.
10549         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10550         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10551         gdbpy_err_fetch.
10552
10553 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10554
10555         * linux-nat.c (delete_lwp_cleanup): Delete.
10556         (struct lwp_deleter): New struct.
10557         (lwp_info_up): New typedef.
10558         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10559         lwp_info_up.
10560
10561 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10562
10563         * linux-fork.c (class scoped_switch_fork_info): New class.
10564         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10565
10566 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10567
10568         * valops.c (find_overload_match): Remove use of null_cleanup, and
10569         calls to do_cleanups.
10570
10571 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10572
10573         * compile/compile-cplus-types.c
10574         (compile_cplus_instance::decl_name): Handle changes to
10575         cp_func_name.
10576         * cp-support.c (cp_func_name): Update header comment, update
10577         return type.
10578         * cp-support.h (cp_func_name): Update return type in declaration.
10579         * valops.c (find_overload_match): Move temp_func local to top
10580         level of function and change its type.  Use temp_func to hold and
10581         delete temporary string obtained from cp_func_name.
10582
10583 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10584
10585         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10586         gdb::char_vector, remove cleanup, and update uses of `msg`.
10587
10588 2019-01-03  Jim Wilson  <jimw@sifive.com>
10589
10590         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10591
10592 2019-01-02  Tom Tromey  <tom@tromey.com>
10593
10594         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10595         (tdesc_parse_xml): Remove cleanups.
10596         * target-descriptions.h (make_cleanup_free_target_description):
10597         Don't declare.
10598         (target_desc_deleter): New struct.
10599         (target_desc_up): New typedef.
10600         * target-descriptions.c (target_desc_deleter::operator()): Rename
10601         from free_target_description.
10602         (make_cleanup_free_target_description): Remove.
10603
10604 2019-01-02  Tom Tromey  <tom@tromey.com>
10605
10606         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10607         constructor, destructor.
10608         (linespec_parser): Remove typedef.
10609         (~linespec_parser): Rename from linespec_parser_delete.
10610         (linespec_lex_to_end, linespec_complete_label)
10611         (linespec_complete): Update.
10612         (decode_line_full): Remove cleanups.
10613         (decode_line_1): Update.
10614
10615 2019-01-02  Tom Tromey  <tom@tromey.com>
10616
10617         * python/python-internal.h (inferior_to_inferior_object): Change
10618         return type.
10619         * python/py-exitedevent.c (create_exited_event_object): Update.
10620         * python/py-inferior.c (inferior_to_inferior_object): Return
10621         gdbpy_ref.
10622         (python_new_inferior, python_inferior_deleted)
10623         (thread_to_thread_object, delete_thread_object)
10624         (build_inferior_list, gdbpy_selected_inferior): Update.
10625         * python/py-infthread.c (create_thread_object): Update.  Also fail
10626         if inferior_to_inferior_object fails.
10627
10628 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10629
10630         * inferior.h (class inferior) <displaced_step_state>: New field.
10631         * infrun.h (struct displaced_step_state): Move here from
10632         infrun.c.  Initialize fields, add constructor.
10633         <inf>: Remove field.
10634         <reset>: New method.
10635         * infrun.c (struct displaced_step_inferior_state): Move to
10636         infrun.h.
10637         (displaced_step_inferior_states): Remove.
10638         (get_displaced_stepping_state): Adust.
10639         (displaced_step_in_progress_any_inferior): Adjust.
10640         (displaced_step_in_progress_thread): Adjust.
10641         (displaced_step_in_progress): Adjust.
10642         (add_displaced_stepping_state): Remove.
10643         (get_displaced_step_closure_by_addr): Adjust.
10644         (remove_displaced_stepping_state): Remove.
10645         (infrun_inferior_exit): Call displaced_step_state.reset.
10646         (use_displaced_stepping): Don't check for NULL.
10647         (displaced_step_prepare_throw): Call
10648         get_displaced_stepping_state.
10649         (displaced_step_fixup): Don't check for NULL.
10650         (prepare_for_detach): Don't check for NULL.
10651
10652 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10653
10654         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10655          in case of call that did not complete.
10656
10657 2019-01-02  Andrey Utkin  <autkin@undo.io>
10658
10659         * symfile.c (find_separate_debug_file): Fix search of debug files for
10660         remote debuggee.
10661
10662 2019-01-02  Tom Tromey  <tom@tromey.com>
10663
10664         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10665         indentation.
10666         * python/py-frame.c (frapy_older): Remove cast.
10667         (frapy_newer): Likewise.
10668         * python/py-breakpoint.c (local_setattro): Remove cast.
10669         * python/py-arch.c (archpy_name): Remove local variable.
10670         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10671
10672 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10673
10674         * unittests/basic_string_view/element_access/char/empty.cc:
10675         Fix year range in copyright header.
10676
10677 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10678
10679         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10680         Delete.
10681         <operator==>: Update with for removed field.
10682         <hash>: Likewise.
10683         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10684         <isa_features>: ...this.
10685         <abi_features>: New field.
10686         (riscv_isa_flen): Update comment.
10687         (riscv_abi_xlen): New declaration.
10688         (riscv_abi_flen): New declaration.
10689         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10690         isa_features.
10691         (riscv_abi_xlen): New function.
10692         (riscv_isa_flen): Update to get answer from isa_features.
10693         (riscv_abi_flen): New function.
10694         (riscv_has_fp_abi): Update to get answer from abi_features.
10695         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10696         xlen and flen.
10697         (riscv_call_info) <xlen, flen>: Update comment.
10698         (riscv_call_arg_struct): Remove invalid assertions
10699         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10700         is removed.
10701         (riscv_gdbarch_init): Gather isa features and abi features
10702         separately, ensure both match on the gdbarch when reusing an old
10703         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10704         a target with 64-bit float hardware.
10705
10706 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10707
10708         * source.c (search_command_helper): Stop reverse search
10709         when line 1 has been searched.
10710
10711 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10712
10713         * record-full.c (record_full_base_target::close): Rewrite
10714         record_full_core_buf_list free logic.
10715
10716 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10717
10718         * break-catch-syscall.c (print_one_catch_syscall): xfree
10719         the last text.
10720
10721 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10722
10723         * top.c (print_gdb_version): Update Copyright year in version
10724         message.
10725
10726 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10727
10728         Update copyright year range in all GDB files.
10729
10730 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10731
10732         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10733
10734 For older changes see ChangeLog-2018.
10735 \f
10736 Local Variables:
10737 mode: change-log
10738 left-margin: 8
10739 fill-column: 74
10740 version-control: never
10741 coding: utf-8
10742 End:
10743