gdb/ChangeLog

   1 2019-07-10  Tom Tromey  <tromey@adacore.com>
   2
   3         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
   4         (struct solib_aix_inferior_data) <library_list>: Change type.
   5         (solib_aix_inferior_data_handle): Change type.
   6         (get_solib_aix_inferior_data): Update.
   7         (solib_aix_free_library_list): Remove.
   8         (library_list_start_library): Update.
   9         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
  10         return type.
  11         (solib_aix_get_library_list)
  12         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
  13         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
  14
  15 2019-07-10  Tom Tromey  <tromey@adacore.com>
  16
  17         * solib-dsbt.c (struct dsbt_info): Add initializers.
  18         (solib_dsbt_pspace_data): Change type.
  19         (dsbt_pspace_data_cleanup): Remove.
  20         (get_dsbt_info, _initialize_dsbt_solib): Update.
  21
  22 2019-07-10  Tom Tromey  <tromey@adacore.com>
  23
  24         * spu-tdep.c (spu_overlay_data): Change type.
  25         (spu_get_overlay_table, spu_overlay_new_objfile)
  26         (_initialize_spu_tdep): Update.
  27
  28 2019-07-10  Tom Tromey  <tromey@adacore.com>
  29
  30         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
  31         destructor.
  32         (dbx_objfile_data_key): Change type and declare later.
  33         (DBX_SYMFILE_INFO): Rewrite.
  34         * dbxread.c (dbx_objfile_data_key): Change type.
  35         (dbx_symfile_init): Update.
  36         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
  37         (coffstab_build_psymtabs, elfstab_build_psymtabs)
  38         (stabsect_build_psymtabs, _initialize_dbxread): Update.
  39
  40 2019-07-10  Tom Tromey  <tromey@adacore.com>
  41
  42         * jit.c (jit_program_space_key): Change type.  Move lower.
  43         (get_jit_program_space_data): Update.
  44         (jit_program_space_data_cleanup): Remove.
  45         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
  46         Update.
  47         (struct jit_program_space_data): Add initializers.
  48
  49 2019-07-10  Tom Tromey  <tromey@adacore.com>
  50
  51         * solib-darwin.c (struct darwin_info): Add initializers.
  52         (solib_darwin_pspace_data): Change type.
  53         (darwin_pspace_data_cleanup): Remove.
  54         (get_darwin_info, _initialize_darwin_solib): Update.
  55
  56 2019-07-10  Tom Tromey  <tromey@adacore.com>
  57
  58         * remote-sim.c (struct sim_inferior_data): Add initializers,
  59         constructor, and destructor.
  60         (sim_inferior_data_key): Change type.  Move lower.
  61         (check_for_duplicate_sim_descriptor): Update.
  62         (get_sim_inferior_data): Use new.  Update.
  63         (~sim_inferior_data_cleanup): Rename from
  64         sim_inferior_data_cleanup.  Simplify.
  65         (gdbsim_close_inferior, simulator_command)
  66         (sim_command_completer, _initialize_remote_sim): Update.
  67         (next_pid, INITIAL_PID): Move earlier.
  68
  69 2019-07-10  Tom Tromey  <tromey@adacore.com>
  70
  71         * python/python-internal.h (create_thread_object): Return
  72         gdbpy_ref.
  73         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
  74         * python/py-inferior.c (struct threadlist_entry): Add
  75         constructor.
  76         <thread_obj>: Now a gdbpy_ref.
  77         (thread_to_thread_object): Update.
  78         (add_thread_object): Use new.
  79         (delete_thread_object): Use delete.
  80         (infpy_threads): Update.
  81         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
  82         GIL.
  83
  84 2019-07-10  Tom Tromey  <tromey@adacore.com>
  85
  86         * valops.c (value_cast): Specialize error message for Ada.
  87
  88 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
  89
  90         * breakpoint.c (breakpoint_1): Update doc and parameter names.
  91
  92 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
  93
  94         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
  95         bpstat_should_step): Return bool, adjust comments.
  96         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
  97         bpstat_should_step): Likewise.
  98
  99 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 100
 101         * features/Makefile: Use feature target descriptions for Arm.
 102         * features/arm/arm-core.c: Generate new file.
 103         * features/arm/arm-fpa.c: Likewise.
 104         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
 105         * features/arm/arm-m-profile.c: Likewise.
 106         * features/arm/arm-vfpv2.c: Likewise.
 107         * features/arm/arm-vfpv3.c: Likewise.
 108         * features/arm/xscale-iwmmxt.c: Likewise.
 109         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
 110
 111 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 112
 113         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
 114         ptrace earlier.
 115
 116 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 117
 118         * features/aarch64-pauth.c: Regenerate.
 119
 120 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
 121
 122         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
 123         bool.
 124         (bpstat_what): Use false instead of 0.
 125
 126 2019-07-09  Pedro Alves  <palves@redhat.com>
 127
 128         * break-catch-throw.c (is_exception_catchpoint): New.
 129         * breakpoint.c (print_one_breakpoint_location): New parameter
 130         'raw_loc'.  Handle it.  Use
 131         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
 132         looking at the breakpoint's type.
 133         (print_one_breakpoint): If handling "maint info breakpoints", also
 134         print locations of exception catchpoints.
 135         * breakpoint.h (is_exception_catchpoint): Declare.
 136
 137 2019-07-09  Pedro Alves  <palves@redhat.com>
 138
 139         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
 140         "addr" field.
 141         (allocate_location_exception_catchpoint): New.
 142         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
 143         (initialize_throw_catchpoint_ops): Install
 144         allocate_location_exception_catchpoint as allocate_location
 145         method.
 146         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
 147         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
 148         bp_loc_other.
 149         (breakpoint_address_is_meaningful): Delete.
 150         (bl_address_is_meaningful): New.
 151         (breakpoint_locations_match): Adjust comment.
 152         (bp_location_from_bp_type): New, factored out of...
 153         (bp_location::bp_location(breakpoint *)): ... this.
 154         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
 155         factored out of...
 156         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
 157         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
 158         breakpoint_address_is_meaningful.
 159         (bp_locations_compare): Adjust comment.
 160         (update_global_location_list): Use bl_address_is_meaningful
 161         instead of breakpoint_address_is_meaningful.
 162         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
 163         explicit.
 164         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
 165         * python/py-breakpoint.c (bppy_get_location): No longer check
 166         whether location is null.
 167
 168 2019-07-09  Pedro Alves  <palves@redhat.com>
 169
 170         PR c++/15468
 171         * breakpoint.c (print_one_breakpoint_location): Remove
 172         single-location assert.
 173
 174 2019-07-09  Tom Tromey  <tom@tromey.com>
 175
 176         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
 177         * configure: Rebuild.
 178         * configure.ac: Change common to gdbsupport.
 179         * gdbsupport: Rename from common.
 180         * acinclude.m4: Change common to gdbsupport.
 181         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
 182         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
 183         gdbsupport.
 184         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
 185         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
 186         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
 187         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
 188         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
 189         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
 190         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
 191         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
 192         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
 193         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
 194         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
 195         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
 196         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
 197         coff-pe-read.c, command.h, compile/compile-c-support.c,
 198         compile/compile-c.h, compile/compile-cplus-symbols.c,
 199         compile/compile-cplus-types.c, compile/compile-cplus.h,
 200         compile/compile-loc2c.c, compile/compile.c, completer.c,
 201         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 202         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 203         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 204         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 205         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 206         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 207         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 208         features/aarch64-core.c, features/aarch64-fpu.c,
 209         features/aarch64-pauth.c, features/aarch64-sve.c,
 210         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 211         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 212         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 213         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 214         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 215         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 216         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 217         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 218         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 219         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 220         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 221         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 222         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 223         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 224         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 225         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 226         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 227         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 228         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 229         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 230         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 231         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 232         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 233         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 234         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 235         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 236         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 237         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 238         minsyms.c, mips-linux-tdep.c, namespace.h,
 239         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 240         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 241         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 242         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 243         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 244         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 245         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 246         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 247         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 248         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 249         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 250         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 251         procfs.c, producer.c, progspace.h, psymtab.h,
 252         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 253         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 254         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 255         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 256         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
 257         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
 258         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
 259         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
 260         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
 261         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
 262         target-memory.c, target.c, target.h, target/waitstatus.c,
 263         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
 264         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
 265         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
 266         unittests/array-view-selftests.c,
 267         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
 268         unittests/common-utils-selftests.c,
 269         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
 270         unittests/format_pieces-selftests.c,
 271         unittests/function-view-selftests.c,
 272         unittests/lookup_name_info-selftests.c,
 273         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
 274         unittests/mkdir-recursive-selftests.c,
 275         unittests/observable-selftests.c,
 276         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
 277         unittests/parse-connection-spec-selftests.c,
 278         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
 279         unittests/scoped_fd-selftests.c,
 280         unittests/scoped_mmap-selftests.c,
 281         unittests/scoped_restore-selftests.c,
 282         unittests/string_view-selftests.c, unittests/style-selftests.c,
 283         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
 284         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
 285         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
 286         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
 287         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
 288         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
 289
 290 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 291
 292         * linespec.c (decode_digits_list_mode): Set explicit_line to a
 293         bool value.
 294         (decode_digits_ordinary): Set explicit_line field in sal.
 295         * symtab.c (skip_prologue_sal): Don't skip prologue for a
 296         symtab_and_line that was set on an explicit line number in
 297         assembler code.  Do always update the recorded symtab and line if
 298         we do skip the prologue.
 299
 300 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 301
 302         * breakpoint.c (set_breakpoint_location_function): Remove
 303         explicit_loc parameter.
 304         (momentary_breakpoint_from_master): Update call to
 305         set_breakpoint_location_function.
 306         (add_location_to_breakpoint): Likewise.
 307
 308 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 309
 310         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
 311         required features based on default bfd type when no specific bfd
 312         is present.
 313
 314 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 315
 316         * NEWS: Mention that GDB printf and eval commands can now print
 317         C-style and Ada-style convenience var strings without
 318         calling the inferior.
 319         * printcmd.c (printf_c_string): Locally print GDB internal var
 320         instead of transiting via the inferior.
 321         (printf_wide_c_string): Likewise.
 322
 323 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 324
 325         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
 326
 327 2019-07-04  Tom Tromey  <tom@tromey.com>
 328
 329         PR tui/24724:
 330         * tui/tui-winsource.c (tui_clear_source_content): Update.
 331         (tui_source_window_base::set_is_exec_point_at): Fix comment.
 332         (tui_update_breakpoint_info): Update.
 333         (tui_set_exec_info_content): Update.
 334         * tui/tui-source.c (tui_set_source_content_nil): Update.
 335         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
 336         has_break.
 337         * tui/tui-data.h (enum tui_bp_flag): New.
 338         (tui_bp_flags): New enum flags type.
 339         (struct tui_source_element) <break_mode>: Change type.  Rename
 340         from has_break.
 341         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
 342         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
 343         constants.
 344         * tui/tui-winsource.h: Fix comment.
 345
 346 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 347
 348         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
 349         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
 350         (store_fpregs_to_thread)
 351         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 352         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
 353         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
 354         (IWMMXT_REGS_SIZE): Add define.
 355         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
 356         (fetch_vfp_regs, store_vfp_regs)
 357         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 358         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
 359
 360 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 361
 362         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
 363         defines.
 364         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
 365         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
 366         (ARM_INT_REGISTER_SIZE): ...to this.
 367         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
 368         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
 369         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
 370         (arm_linux_collect_gregset, supply_nwfpe_register)
 371         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
 372         defines.
 373         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
 374         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
 375         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
 376         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
 377         (arm_return_in_memory, arm_store_return_value)
 378         (arm_get_longjmp_target, arm_register_g_packet_guesses)
 379         (arm_record_ld_st_multiple): Likewise.
 380         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
 381         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
 382
 383 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 384
 385         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
 386         AARCH64_DISPLACED_MODIFIED_INSNS.
 387         * aarch64-tdep.c (struct aarch64_displaced_step_data)
 388         (aarch64_displaced_step_copy_insn): Likewise.
 389         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 390         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
 391         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
 392         ARM_DISPLACED_MODIFIED_INSNS.
 393         * arm-tdep.c (arm_gdbarch_init): Likewise.
 394         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 395         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
 396         (struct arm_displaced_step_closure): Use
 397         ARM_DISPLACED_MODIFIED_INSNS.
 398
 399 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 400
 401         * features/Makefile: Remove unused xml files.
 402         * features/aarch64.xml: Remove.
 403         * features/i386/amd64-avx-avx512-linux.xml: Remove.
 404         * features/i386/amd64-avx-avx512.xml: Remove.
 405         * features/i386/amd64-avx-linux.xml: Remove.
 406         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
 407         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
 408         * features/i386/amd64-avx-mpx-linux.xml: Remove.
 409         * features/i386/amd64-avx-mpx.xml: Remove.
 410         * features/i386/amd64-avx.xml: Remove.
 411         * features/i386/amd64-linux.xml: Remove.
 412         * features/i386/amd64-mpx-linux.xml: Remove.
 413         * features/i386/amd64-mpx.xml: Remove.
 414         * features/i386/amd64.xml: Remove.
 415         * features/i386/i386-avx-avx512-linux.xml: Remove.
 416         * features/i386/i386-avx-avx512.xml: Remove.
 417         * features/i386/i386-avx-linux.xml: Remove.
 418         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
 419         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
 420         * features/i386/i386-avx-mpx-linux.xml: Remove.
 421         * features/i386/i386-avx-mpx.xml: Remove.
 422         * features/i386/i386-avx.xml: Remove.
 423         * features/i386/i386-linux.xml: Remove.
 424         * features/i386/i386-mmx-linux.xml: Remove.
 425         * features/i386/i386-mmx.xml: Remove.
 426         * features/i386/i386-mpx-linux.xml: Remove.
 427         * features/i386/i386-mpx.xml: Remove.
 428         * features/i386/i386.xml: Remove.
 429         * features/i386/x32-avx-avx512-linux.xml: Remove.
 430         * features/i386/x32-avx-linux.xml: Remove.
 431         * features/i386/x32-linux.xml: Remove.
 432
 433 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 434
 435         * regformats/aarch64.dat: Remove.
 436         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
 437         * regformats/i386/amd64-avx-linux.dat: Remove.
 438         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
 439         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
 440         * regformats/i386/amd64-linux.dat: Remove.
 441         * regformats/i386/amd64-mpx-linux.dat: Remove.
 442         * regformats/i386/amd64.dat: Remove.
 443         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
 444         * regformats/i386/i386-avx-linux.dat: Remove.
 445         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
 446         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
 447         * regformats/i386/i386-linux.dat: Remove.
 448         * regformats/i386/i386-mmx-linux.dat: Remove.
 449         * regformats/i386/i386-mpx-linux.dat: Remove.
 450         * regformats/i386/i386.dat: Remove.
 451         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
 452         * regformats/i386/x32-avx-linux.dat: Remove.
 453         * regformats/i386/x32-linux.dat: Remove.
 454
 455 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 456
 457         * aarch64-tdep.c: Remove xml self tests.
 458         * amd64-linux-tdep.c: Likewise.
 459         * amd64-tdep.c: Likewise.
 460         * i386-linux-tdep.c: Likewise.
 461         * i386-tdep.c: Likewise.
 462
 463 2019-07-03  Pedro Alves  <palves@redhat.com>
 464
 465         PR cli/24732
 466         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
 467         (pipe_cmd_option_defs): New.
 468         (make_pipe_cmd_options_def_group): New.
 469         (pipe_command): Use gdb::option::process_options.
 470         (pipe_command_completer): New function.
 471         (_initialize_cli_cmds): Install completer for "pipe" command.
 472
 473 2019-07-03  Pedro Alves  <palves@redhat.com>
 474
 475         * cli/cli-option.c (union option_value) <string>: New field.
 476         (struct option_def_and_value): Add ctor, move ctor, dtor and
 477         use DISABLE_COPY_AND_ASSIGN.
 478         (option_def_and_value::clear_value): New.
 479         (parse_option, save_option_value_in_ctx, get_val_type_str)
 480         (add_setshow_cmds_for_options): Handle var_string.
 481         * cli-option.h (union option_def::var_address) <string>: New
 482         field.
 483         (struct string_option_def): New.
 484         * maint-test-options.c (struct test_options_opts): Add default
 485         ctor and use DISABLE_COPY_AND_ASSIGN.
 486         <string_opt>: New field.
 487         (test_options_opts::~test_options_opts): New.
 488         (test_options_opts::dump): Also dump "-string".
 489         (test_options_option_defs): Install "string.
 490
 491 2019-07-03  Pedro Alves  <palves@redhat.com>
 492
 493         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
 494         option_value with a null enumeration.
 495         (complete_options): Save the option values in the context.
 496         (save_option_value_in_ctx): New, factored out from ...
 497         (process_options): ... here.
 498         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
 499         of the function.
 500         * maint-test-options.c (test_options_opts::dump): New, factored
 501         out from ...
 502         (maintenance_test_options_command_mode): ... here.
 503         (maintenance_test_options_command_completion_result): Delete.
 504         (maintenance_test_options_command_completion_text): Update
 505         comment.
 506         (maintenance_show_test_options_completion_result): Change
 507         prototype.  Just print
 508         maintenance_test_options_command_completion_text.
 509         (save_completion_result): New.
 510         (maintenance_test_options_completer_mode): Pass options context to
 511         complete_options, and then save a dump.
 512         (_initialize_maint_test_options): Use add_cmd to install "maint
 513         show test-options-completion-result".
 514
 515 2019-07-03  Pedro Alves  <palves@redhat.com>
 516
 517         * NEWS (New commands): Mention "with" and "maint with".
 518         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
 519         (with_command, with_command_completer): New.
 520         (pipe_command): Adjust to new repeat_previous
 521         interface.
 522         (_initialize_cli_cmds): Install the "with" command and its "w"
 523         alias.
 524         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
 525         declarations.
 526         * cli/cli-setshow.c (parse_cli_var_uinteger)
 527         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
 528         argument strings for all var_types.
 529         (get_setshow_command_value_string): New, factored out from ...
 530         (do_show_command): ... this.
 531         * cli/cli-setshow.h: Include <string>.
 532         (get_setshow_command_value_string): Declare.
 533         * command.h (repeat_previous): Now returns const char *.  Adjust
 534         comment.
 535         * maint.c: Include "cli/cli-cmds.h".
 536         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
 537         (_initialize_maint_cmds): Register the "maintenance with" command.
 538         * top.c (repeat_previous): Move bits from pipe_command here:
 539         Return the saved command line, if any; error out if there's no
 540         command to relaunch.
 541
 542 2019-07-03  Pedro Alves  <palves@redhat.com>
 543
 544         * NEWS (New commands): Mention "maint set/show test-settings"
 545         instead of "maint test-settings".
 546         * maint-test-settings.c (maintenance_test_settings_list): Delete.
 547         (maintenance_test_settings_set_list): Rename to ...
 548         (maintenance_set_test_settings_list): ... this.
 549         (maintenance_test_settings_show_list): Rename to  ...
 550         (maintenance_show_test_settings_list): ... this.
 551         (maintenance_test_settings_cmd): Delete.
 552         (maintenance_test_settings_set_cmd): ...
 553         (maintenance_set_test_settings_cmd): ... this.
 554         (maintenance_test_settings_show_cmd): ...
 555         (maintenance_show_test_settings_cmd): ... this.
 556         (maintenance_test_settings_show_value_cmd):
 557         (maintenance_show_test_settings_value_cmd): ... this.
 558         (_initialize_maint_test_settings): No longer install the "maint
 559         test-settings" prefix command.  Rename "maint test-settings set"
 560         to "maint set test-settings", and "maint test-settings show" to
 561         "maint show test-settings".  Adjust all subcommands.
 562
 563 2019-07-03  Pedro Alves  <palves@redhat.com>
 564
 565         * maint-test-settings.c: Fix file's intro comment.  Replace all
 566         references to "test-options" with references to "test-settings",
 567         in comments.
 568
 569 2019-07-03  Pedro Alves  <palves@redhat.com>
 570
 571         * maint-test-settings.c (maintenance_test_settings_xxx)
 572         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
 573         New.
 574         (maintenance_test_settings_enums): Use them.
 575         (maintenance_test_settings_enum): Default to
 576         maintenance_test_settings_xxx.
 577         (_initialize_maint_test_settings): Initialize
 578         MAINTENANCE_TEST_SETTINGS_FILENAME.
 579
 580 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 581
 582         * breakpoint.h (remove_breakpoints_inf): Change return type to
 583         void, move function documentation here.
 584         * breakpoint.c (remove_breakpoints_inf): Change return type to
 585         void, move function documentation to header.
 586
 587 2019-07-02  Pedro Alves  <palves@redhat.com>
 588
 589         * NEWS (Completion improvements): Mention "info threads".
 590         * thread.c (struct info_threads_opts, info_threads_option_defs)
 591         (make_info_threads_options_def_group): New.
 592         (info_threads_command): Use gdb::option::process_options.
 593         (info_threads_command_completer): New.
 594         (_initialize_thread): Use gdb::option::build_help to build the
 595         help text for "info threads".
 596
 597 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 598
 599         * defs.h (generic_load): Move from here...
 600         * symfile.h (generic_load): ... to here.  Rename name parameter
 601         to args.
 602         * symfile.c (generic_load): Add comment.
 603
 604 2019-07-01  Tom Tromey  <tromey@adacore.com>
 605
 606         * dwarf2read.c
 607         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
 608         declaration of without_params.  Fix formatting.
 609
 610 2019-07-01  Tom Tromey  <tromey@adacore.com>
 611
 612         * ada-exp.y (find_primitive_type): Update.
 613         * ada-lang.h (ada_lookup_symbol): Update.
 614         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
 615         parameter.
 616         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
 617
 618 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 619
 620         PR breakpoints/24541
 621         * gdbarch.c: Regenerate.
 622         * gdbarch.h: Regenerate.
 623         * gdbarch.sh: Add 'stap_adjust_register'.
 624         * i386-tdep.c: Include '<unordered_set>'.
 625         (i386_stap_adjust_register): New function.
 626         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
 627         * stap-probe.c (stap_parse_register_operand): Call
 628         'gdbarch_stap_adjust_register'.
 629
 630 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 631
 632         PR python/24742
 633         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
 634         * python/python.c (do_start_initialization): Use 'xmalloc'
 635         instead of 'PyMem_Malloc'.
 636
 637 2019-06-28  Tom Tromey  <tromey@adacore.com>
 638
 639         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
 640         for Ada.
 641
 642 2019-06-27  Tom Tromey  <tromey@adacore.com>
 643
 644         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
 645         objfile_key.
 646         (arm_find_mapping_symbol, arm_record_special_symbol)
 647         (_initialize_arm_tdep): Update.
 648         (arm_objfile_data_free): Remove.
 649
 650 2019-06-27  Tom Tromey  <tromey@adacore.com>
 651
 652         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
 653         to cp_print_static_field.
 654
 655 2019-06-26  Tom Tromey  <tromey@adacore.com>
 656
 657         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
 658         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
 659         declare.
 660
 661 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 662
 663         * features/aarch64-core.c (create_feature_aarch64_core):
 664         Regenerate.
 665         * features/aarch64-core.xml: Add cpsr flags.
 666
 667 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 668
 669         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
 670         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
 671
 672 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 673
 674         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
 675         field.
 676         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
 677         use.
 678         (arm_record_special_symbol): Don't insert new symbol in sorted
 679         position, push it at the end.
 680
 681 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 682
 683         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
 684         (arm_mapping_symbol_s): Remove.
 685         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
 686         (arm_mapping_symbol_vec): New typedef.
 687         (struct arm_per_objfile): Add constructor.
 688         <section_maps>: Change type to
 689         std::unique_ptr<arm_mapping_symbol_vec[]>.
 690         (arm_compare_mapping_symbols): Remove.
 691         (arm_find_mapping_symbol): Adjust to section_maps type change.
 692         (arm_objfile_data_free): Call delete on arm_per_objfile.
 693         (arm_record_special_symbol): Adjust to section_maps type change.
 694         Allocate arm_per_objfile with new.
 695
 696 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 697
 698         * cli/cli-cmds.c (alias_command): Compare the alias prefix
 699         with the command prefix.
 700
 701 2019-06-25  Tom Tromey  <tom@tromey.com>
 702
 703         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
 704         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
 705
 706 2019-06-25  Tom Tromey  <tom@tromey.com>
 707
 708         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
 709         type.
 710         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
 711         protected.
 712
 713 2019-06-25  Tom Tromey  <tom@tromey.com>
 714
 715         * tui/tui-winsource.c
 716         (tui_source_window_base::set_is_exec_point_at): Add check against
 717         LOA_ADDRESS.
 718
 719 2019-06-25  Tom Tromey  <tom@tromey.com>
 720
 721         * tui/tui-source.c (tui_set_source_content): Don't check before
 722         xfree.
 723         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
 724
 725 2019-06-25  Tom Tromey  <tom@tromey.com>
 726
 727         * tui/tui-winsource.h (tui_update_source_window_as_is)
 728         (tui_alloc_source_buffer, tui_line_is_displayed)
 729         (tui_addr_is_displayed): Change type of win_info.
 730         * tui/tui-winsource.c (tui_update_source_window_as_is)
 731         (tui_clear_source_content, tui_show_source_line)
 732         (tui_show_source_content, tui_source_window_base::refill)
 733         (tui_source_window_base::set_is_exec_point_at)
 734         (tui_source_window_base::set_is_exec_point_at)
 735         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
 736         (tui_alloc_source_buffer, tui_line_is_displayed)
 737         (tui_addr_is_displayed): Change type of win_info.  Update.
 738         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 739         (tui_source_window_base::do_make_visible_with_new_height):
 740         Update.
 741         * tui/tui-source.c (tui_set_source_content)
 742         (tui_set_source_content_nil)
 743         (tui_source_window::do_scroll_vertical): Update.
 744         * tui/tui-layout.c (show_layout): Update.
 745         * tui/tui-disasm.c (tui_set_disassem_content)
 746         (tui_disasm_window::do_scroll_vertical): Update.
 747         * tui/tui-data.h (tui_win_content): Remove.
 748         (struct tui_gen_win_info) <content, content_size>: Remove.
 749         (struct tui_source_element): Add initializers and destructor.
 750         (union tui_which_element, struct tui_win_element): Remove.
 751         (struct tui_source_window_base) <content>: New field.
 752         (struct tui_data_window): Remove destructor.
 753         (tui_alloc_content, tui_free_win_content)
 754         (tui_free_all_source_wins_content): Don't declare.
 755         * tui/tui-data.c (tui_initialize_static_data): Update.
 756         (init_content_element, tui_alloc_content): Remove.
 757         (~tui_gen_win_info): Update.
 758         (~tui_data_window, tui_free_all_source_wins_content)
 759         (tui_free_win_content, free_content, free_content_elements):
 760         Remove.
 761
 762 2019-06-25  Tom Tromey  <tom@tromey.com>
 763
 764         * tui/tui-winsource.h (tui_clear_source_content)
 765         (tui_erase_source_content, tui_show_source_content): Change type
 766         of win_info.
 767         * tui/tui-winsource.c (tui_clear_source_content)
 768         (tui_erase_source_content, tui_show_source_content): Change type
 769         of win_info.
 770         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 771         * tui/tui-source.h (tui_set_source_content_nil): Change type of
 772         win_info.
 773         * tui/tui-source.c (tui_set_source_content_nil): Change type of
 774         win_info.
 775         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
 776
 777 2019-06-25  Tom Tromey  <tom@tromey.com>
 778
 779         * tui/tui-winsource.c (tui_clear_source_content)
 780         (tui_source_window_base::set_is_exec_point_at): Update.
 781         * tui/tui-source.c (tui_set_source_content_nil): Update.
 782         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
 783         a bool.
 784         * tui/tui-data.c (init_content_element): Update.
 785
 786 2019-06-25  Tom Tromey  <tom@tromey.com>
 787
 788         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
 789         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
 790         * tui/tui-layout.c (init_and_make_win): Update.
 791         * tui/tui.h (enum tui_win_type): Update.
 792         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
 793         tui_win_is_auxillary.
 794         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
 795         tui_win_is_auxillary.
 796
 797 2019-06-25  Tom Tromey  <tom@tromey.com>
 798
 799         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
 800         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
 801         (tui_delete_data_content_windows, tui_display_all_data)
 802         (tui_data_window::do_scroll_vertical, tui_display_data_from):
 803         Update.
 804         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
 805         * tui/tui-regs.c (tui_last_regs_line_no)
 806         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 807         (tui_show_registers): Update.
 808         (tui_show_register_group): Return void.  Update.
 809         (tui_display_registers_from, tui_display_reg_element_at_line)
 810         (tui_display_registers_from_line, tui_check_register_values):
 811         Update.
 812         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
 813         member.
 814         (struct tui_data_window) <regs_content>: Now a std::vector.
 815         <regs_content_count>: Remove.
 816         (tui_add_content_elements, tui_free_data_content): Don't declare.
 817         * tui/tui-data.c (tui_data_window::clear_detail): Update.
 818         (init_content_element): Remove DATA_WIN case.  Add assert.
 819         (tui_add_content_elements): Remove.
 820         (tui_data_window): Update.
 821         (tui_free_data_content): Remove.
 822         (free_content_elements): Remove DATA_WIN case.
 823
 824 2019-06-25  Tom Tromey  <tom@tromey.com>
 825
 826         * tui/tui-data.c (tui_data_item_window): Update.
 827         * tui/tui-windata.h (tui_check_data_values): Don't declare.
 828         * tui/tui-windata.c (tui_display_all_data)
 829         (tui_display_data_from_line): Update.
 830         (tui_check_data_values): Remove.
 831         * tui/tui-regs.c (tui_show_register_group)
 832         (tui_display_reg_element_at_line): Update.
 833         * tui/tui-hooks.c (tui_register_changed)
 834         (tui_refresh_frame_and_register_information): Call
 835         tui_check_register_values.
 836         * tui/tui-data.h (struct tui_data_window) <data_content,
 837         data_content_count, data_type>: Remove.
 838         (enum tui_data_type): Remove.
 839
 840         * tui/tui-data.c (tui_data_window::clear_detail)
 841         (~tui_data_window): Update.
 842
 843 2019-06-25  Tom Tromey  <tom@tromey.com>
 844
 845         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
 846         declare.
 847         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
 848         Rename from tui_first_data_item_displayed.  Update.
 849         (tui_data_window::refresh_all)
 850         (tui_data_window::do_scroll_vertical): Update.
 851         * tui/tui-data.h (struct tui_data_window)
 852         <first_data_item_displayed>: Declare new method.
 853
 854 2019-06-25  Tom Tromey  <tom@tromey.com>
 855
 856         * tui/tui-data.h (tui_init_generic_part): Don't declare.
 857         * tui/tui-data.c (tui_init_generic_part): Remove, moving
 858         contents...
 859         (tui_initialize_static_data): ...here.
 860
 861 2019-06-25  Tom Tromey  <tom@tromey.com>
 862
 863         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 864         (tui_display_registers_from, tui_check_register_values): Update.
 865         (tui_display_register): Remove win_info parameter; update.
 866         (tui_get_register): Change type of parameters.
 867         * tui/tui-data.h (struct tui_data_element): Remove.
 868         (union tui_which_element) <data>: Remove.
 869         <data_window>: Change type.
 870         (struct tui_data_item_window): New.
 871         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
 872         case.  Add assert.
 873         (~tui_data_item_window): New destructor.
 874         (free_content_elements): Remove DATA_ITEM_WIN case.
 875
 876 2019-06-25  Tom Tromey  <tom@tromey.com>
 877
 878         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
 879         Remove.
 880
 881 2019-06-25  Tom Tromey  <tom@tromey.com>
 882
 883         * tui/tui-data.h (struct tui_command_element): Remove.
 884         (union tui_which_element) <command>: Remove.
 885         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
 886         assert.
 887         (free_content_elements): Remove CMD_WIN case.
 888
 889 2019-06-25  Tom Tromey  <tom@tromey.com>
 890
 891         * tui/tui-layout.c (tui_set_layout): Update.
 892         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
 893         * tui/tui-data.c (layout_def): Update.
 894
 895 2019-06-25  Tom Tromey  <tom@tromey.com>
 896
 897         * tui/tui-wingeneral.c (tui_refresh_all): Update.
 898         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 899         (tui_source_window_base::set_new_height): Update.
 900         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
 901         Update.
 902         (tui_set_locator_fullname, tui_set_locator_info)
 903         (tui_show_frame_info): Update.
 904         * tui/tui-source.c (tui_set_source_content)
 905         (tui_source_is_displayed): Update.
 906         * tui/tui-layout.c (show_source_disasm_command, show_data)
 907         (show_source_or_disasm_and_command): Update.
 908         * tui/tui-disasm.c (tui_set_disassem_content)
 909         (tui_get_begin_asm_address): Update.
 910         * tui/tui-data.h (struct tui_locator_element): Remove.
 911         (union tui_which_element) <locator>: Remove.
 912         (struct tui_locator_window): New.
 913         (tui_locator_win_info_ptr): Change return type.
 914         * tui/tui-data.c (_locator): Change type.
 915         (tui_locator_win_info_ptr): Change return type.
 916         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
 917         (tui_alloc_content): Add assert.
 918
 919 2019-06-25  Tom Tromey  <tom@tromey.com>
 920
 921         * tui/tui-winsource.c
 922         (tui_exec_info_window::maybe_allocate_content): New method.
 923         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
 924         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
 925         (make_source_or_disasm_window): Add cast.
 926         * tui/tui-data.h (union tui_which_element) <simple_string>:
 927         Remove.
 928         (struct tui_source_info): New.
 929         (struct tui_source_window_base) <execution_info>: Change type.
 930         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
 931         case, and add assert.
 932         (tui_alloc_content): Add assert.
 933
 934 2019-06-25  Tom Tromey  <tom@tromey.com>
 935
 936         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
 937         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
 938         * tui/tui-data.c (tui_alloc_win_info): Remove.
 939
 940 2019-06-25  Tom Tromey  <tom@tromey.com>
 941
 942         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
 943         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
 944         can_highlight.
 945
 946 2019-06-25  Tom Tromey  <tom@tromey.com>
 947
 948         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
 949         make_visible_with_new_height method.
 950         (tui_win_info::make_visible_with_new_height): New method.
 951         (tui_source_window_base::do_make_visible_with_new_height)
 952         (tui_data_window::do_make_visible_with_new_height)
 953         (tui_cmd_window::do_make_visible_with_new_height): New methods.
 954         (make_visible_with_new_height): Remove.
 955         (tui_resize_all, tui_adjust_win_heights): Use
 956         make_visible_with_new_height method.
 957         * tui/tui-data.h (struct tui_win_info)
 958         <do_make_visible_with_new_height, make_visible_with_new_height>:
 959         New methods.
 960         (struct tui_source_window_base, struct tui_data_window)
 961         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
 962         methods.
 963
 964 2019-06-25  Tom Tromey  <tom@tromey.com>
 965
 966         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
 967         method.
 968         (update_tab_width): Call update_tab_width method.
 969         * tui/tui-data.h (struct tui_win_info)
 970         (struct tui_source_window_base) <update_tab_width>: New methods.
 971
 972 2019-06-25  Tom Tromey  <tom@tromey.com>
 973
 974         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
 975         parameter.
 976         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
 977         parameter.
 978         (tui_gen_win_info::make_visible): Update.
 979         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
 980         parameter.
 981         * tui/tui-data.h (enum tui_box): New enum.
 982         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
 983
 984 2019-06-25  Tom Tromey  <tom@tromey.com>
 985
 986         * tui/tui-layout.c (make_source_or_disasm_window): Always use
 987         init_and_make_win for EXEC_INFO_WIN.
 988         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
 989         longer inline.
 990         (struct tui_win_info) <~tui_win_info>: Inline.
 991         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 992         Don't declare.
 993         * tui/tui-data.c (source_win, disasm_win): Remove globals.
 994         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 995         Remove.
 996         (tui_initialize_static_data): Update.
 997         (~tui_gen_win_info): Handle more cleanup here.
 998         (~tui_source_window_base): Delete "execution_info".
 999         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1000
1001 2019-06-25  Tom Tromey  <tom@tromey.com>
1002
1003         * tui/tui-layout.c (make_command_window): Don't set
1004         can_highlight.
1005         (show_source_disasm_command): Call the reset method.
1006         (show_data): Don't set can_highlight.  Call the reset method.
1007         (tui_gen_win_info::reset): Rename from init_gen_win_info
1008         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1009         (show_source_or_disasm_and_command): Call the reset method.
1010         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1011         (struct tui_cmd_window): Set can_highlight.
1012
1013 2019-06-25  Tom Tromey  <tom@tromey.com>
1014
1015         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1016         from make_visible.
1017         (tui_make_visible, tui_make_invisible): Rewrite.
1018         (tui_win_info::make_visible): Remove.
1019         (tui_source_window_base::make_visible): Update.
1020         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1021         method.  Moved from...
1022         (struct tui_win_info) <make_visible>: ...here.
1023
1024 2019-06-25  Tom Tromey  <tom@tromey.com>
1025
1026         * tui/tui-winsource.c
1027         (tui_source_window_base::do_scroll_horizontal): Remove direction
1028         parameter.
1029         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1030         direction parameter.
1031         * tui/tui-win.c (tui_win_info::forward_scroll)
1032         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1033         (tui_win_info::right_scroll): Update.
1034         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1035         direction parameter.
1036         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1037         direction parameter.
1038         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1039         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1040         Remove direction parameter.
1041         (struct tui_source_window_base, struct tui_source_window)
1042         (struct tui_disasm_window, struct tui_data_window)
1043         (struct tui_cmd_window): Update.
1044
1045 2019-06-25  Tom Tromey  <tom@tromey.com>
1046
1047         * tui/tui-winsource.h (tui_set_exec_info_content)
1048         (tui_show_exec_info_content, tui_erase_exec_info_content)
1049         (tui_clear_exec_info_content, tui_update_exec_info): Change
1050         argument to tui_source_window_base.
1051         * tui/tui-winsource.c (tui_set_exec_info_content)
1052         (tui_show_exec_info_content, tui_erase_exec_info_content)
1053         (tui_clear_exec_info_content, tui_update_exec_info): Change
1054         argument to tui_source_window_base.
1055
1056 2019-06-25  Tom Tromey  <tom@tromey.com>
1057
1058         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1059         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1060
1061 2019-06-25  Tom Tromey  <tom@tromey.com>
1062
1063         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1064         check.
1065
1066 2019-06-25  Tom Tromey  <tom@tromey.com>
1067
1068         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1069         type to void.
1070         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1071         type to void.
1072         * tui/tui-source.c (tui_set_source_content): Update.
1073         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1074
1075 2019-06-25  Tom Tromey  <tom@tromey.com>
1076
1077         * tui/tui-win.c (window_name_completer, tui_set_focus)
1078         (tui_all_windows_info): Use name method.
1079         * tui/tui-data.h (struct tui_gen_win_info)
1080         (struct tui_source_window, struct tui_disasm_window)
1081         (struct tui_data_window, struct tui_cmd_window) <name>: New
1082         method.
1083         (tui_win_name): Don't declare.
1084         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1085         (tui_win_name): Remove.
1086
1087 2019-06-25  Tom Tromey  <tom@tromey.com>
1088
1089         * tui/tui-winsource.h (tui_update_source_window)
1090         (tui_update_source_window_as_is): Change parameter type.
1091         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1092         to be a tui_source_window_base.
1093         (tui_update_source_window_as_is): Likewise.
1094         * tui/tui-win.c (make_visible_with_new_height): Update.
1095
1096 2019-06-25  Tom Tromey  <tom@tromey.com>
1097
1098         * tui/tui-winsource.c (tui_erase_source_content)
1099         (tui_show_source_content, tui_show_exec_info_content)
1100         (tui_erase_exec_info_content): Use refresh_window method.
1101         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1102         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1103         from tui_refresh_win.
1104         (tui_data_window::refresh_window): New method.
1105         (tui_win_info::refresh, tui_source_window_base::refresh)
1106         (tui_refresh_all): Use refresh_window method.
1107         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1108         method.
1109         * tui/tui-regs.c (tui_display_register): Call refresh_window
1110         method.
1111         * tui/tui-layout.c (show_source_disasm_command)
1112         (show_source_or_disasm_and_command): Call refresh_window method.
1113         * tui/tui-data.h (struct tui_gen_win_info)
1114         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1115         New method.
1116
1117 2019-06-25  Tom Tromey  <tom@tromey.com>
1118
1119         * tui/tui.c (tui_rl_other_window, tui_enable)
1120         (tui_is_window_visible, tui_get_command_dimension): Update.
1121         * tui/tui-winsource.c (tui_update_source_window_as_is)
1122         (tui_clear_source_content, tui_erase_source_content)
1123         (tui_show_source_line, tui_source_window_base::refill)
1124         (tui_source_window_base::do_scroll_horizontal)
1125         (tui_source_window_base::set_is_exec_point_at)
1126         (tui_update_breakpoint_info, tui_set_exec_info_content)
1127         (tui_alloc_source_buffer, tui_line_is_displayed)
1128         (tui_addr_is_displayed): Update.
1129         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1130         (tui_check_and_display_highlight_if_needed)
1131         (tui_win_info::make_visible, tui_win_info::refresh)
1132         (tui_refresh_all): Update.
1133         * tui/tui-windata.c (tui_first_data_item_displayed)
1134         (tui_delete_data_content_windows, tui_erase_data_content)
1135         (tui_display_all_data, tui_data_window::refresh_all)
1136         (tui_check_data_values): Update.
1137         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1138         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1139         (tui_win_info::backward_scroll, tui_refresh_all_win)
1140         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1141         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1142         (tui_source_window_base::set_new_height)
1143         (tui_data_window::set_new_height)
1144         (make_invisible_and_set_new_height)
1145         (make_visible_with_new_height, new_height_ok)
1146         (parse_scrolling_args): Update.
1147         * tui/tui-stack.c (tui_show_frame_info): Update.
1148         * tui/tui-source.c (tui_set_source_content)
1149         (tui_set_source_content_nil, tui_source_is_displayed)
1150         (tui_source_window::do_scroll_vertical): Update.
1151         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1152         (tui_display_registers_from, tui_display_reg_element_at_line)
1153         (tui_check_register_values, tui_reg_command): Update.
1154         * tui/tui-layout.c (tui_default_win_height)
1155         (show_source_disasm_command, show_data, init_and_make_win)
1156         (show_source_or_disasm_and_command): Update.
1157         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1158         (tui_redisplay_readline, tui_mld_flush)
1159         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1160         (tui_getc): Update.
1161         * tui/tui-disasm.c (tui_set_disassem_content)
1162         (tui_disasm_window::do_scroll_vertical): Update.
1163         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1164         Now virtual.
1165         (struct tui_win_info): Derive from tui_gen_win_info.
1166         <~tui_win_info>: Mark as override.
1167         <generic>: Remove member.
1168         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1169         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1170         (~tui_data_window, ~tui_win_info)
1171         (tui_free_all_source_wins_content): Update.
1172         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1173
1174 2019-06-25  Tom Tromey  <tom@tromey.com>
1175
1176         * tui/tui-layout.c (init_and_make_win): Use new.
1177         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1178         destructor, initializers.
1179         (tui_alloc_generic_win_info): Don't declare.
1180         * tui/tui-data.c (_locator): Add argument to constructor.
1181         (source_win, disasm_win): New globals.
1182         (exec_info): Remove.
1183         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1184         Update.
1185         (tui_alloc_generic_win_info): Remove.
1186         (init_content_element): Use new.
1187         (tui_win_info::tui_win_info): Update.
1188         (free_content_elements) <case DATA_WIN>: Use delete.
1189
1190 2019-06-25  Tom Tromey  <tom@tromey.com>
1191
1192         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1193         * tui/tui-windata.c (tui_first_data_item_displayed)
1194         (tui_delete_data_content_windows): Update.
1195         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1196         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1197         (tui_display_registers_from, tui_check_register_values): Update.
1198         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1199         pointer.
1200         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1201         window.
1202         (tui_free_data_content): Update.
1203         (free_content_elements) <case DATA_WIN>: Free the window.
1204
1205 2019-06-25  Tom Tromey  <tom@tromey.com>
1206
1207         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1208         Update.
1209         * tui/tui-layout.c (make_command_window)
1210         (show_source_disasm_command, show_data, init_and_make_win)
1211         (show_source_or_disasm_and_command): Update.
1212         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1213         method.
1214         <can_highight, is_highlighted>: Now bool.
1215         (tui_set_win_highlight): Don't declare.
1216         * tui/tui-data.c (tui_set_win_highlight): Remove.
1217
1218 2019-06-25  Tom Tromey  <tom@tromey.com>
1219
1220         * tui/tui-wingeneral.c (make_visible): Remove check of window
1221         type.
1222
1223 2019-06-25  Tom Tromey  <tom@tromey.com>
1224
1225         * tui/tui-win.c (tui_win_info::max_height)
1226         (tui_cmd_window::max_height): New methods.
1227         (new_height_ok): Call max_height.
1228         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1229         <max_height>: New method.
1230
1231 2019-06-25  Tom Tromey  <tom@tromey.com>
1232
1233         * tui/tui-win.c (tui_source_window_base::set_new_height)
1234         (tui_data_window::set_new_height): New methods.
1235         (make_invisible_and_set_new_height): Call set_new_height method.
1236         * tui/tui-data.h (struct tui_win_info)
1237         (struct tui_source_window_base, struct tui_data_window)
1238         <set_new_height>: New method.
1239
1240 2019-06-25  Tom Tromey  <tom@tromey.com>
1241
1242         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1243         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1244         tui_refresh_data_win.
1245         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1246         method.
1247         (tui_refresh_all_win): Call the refresh_all method.
1248         (tui_set_focus): Likewise.
1249         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1250         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1251         Likewise.
1252
1253 2019-06-25  Tom Tromey  <tom@tromey.com>
1254
1255         * tui/tui-winsource.h (tui_refill_source_window)
1256         (tui_set_is_exec_point_at): Don't declare.
1257         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1258         (tui_source_window_base::refill): Rename from
1259         tui_refill_source_window.
1260         (tui_source_window_base::do_scroll_horizontal): Update.
1261         (tui_source_window_base::set_is_exec_point_at): Rename from
1262         tui_set_is_exec_point_at.
1263         (tui_update_all_breakpoint_info): Update.
1264         * tui/tui-stack.c (tui_show_frame_info): Update.
1265         * tui/tui-layout.c (show_data): Add cast.
1266         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1267         * tui/tui-data.h (struct tui_source_window_base) <refill,
1268         set_is_exec_point_at>: New methods.
1269         (tui_source_windows, tui_add_to_source_windows): Update types.
1270         (tui_add_to_source_windows): Remove redundant declaration.
1271         * tui/tui-data.c (source_windows): Store tui_source_window_base.
1272         (tui_source_windows): Change return type.
1273         (tui_clear_source_windows_detail): Update.
1274         (tui_add_to_source_windows): Change type of parameter.
1275         (tui_free_all_source_wins_content): Update.
1276
1277 2019-06-25  Tom Tromey  <tom@tromey.com>
1278
1279         * tui/tui-wingeneral.c (tui_win_info::refresh)
1280         (tui_source_window_base::refresh): New methods.
1281         (tui_refresh_all): Call the refresh method.
1282         * tui/tui-data.h (struct tui_win_info)
1283         (struct tui_source_window_base) <refresh>: New method.
1284
1285 2019-06-25  Tom Tromey  <tom@tromey.com>
1286
1287         * tui/tui.h (tui_is_window_visible): Return bool.
1288         * tui/tui.c (tui_is_window_visible): Return bool.
1289         * tui/tui-wingeneral.c (tui_make_window, make_visible)
1290         (tui_make_visible, tui_make_invisible)
1291         (tui_win_info::make_visible)
1292         (tui_source_window_base::make_visible, make_all_visible)
1293         (tui_make_all_visible, tui_make_all_invisible): Update.
1294         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
1295         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
1296         bool.
1297         (struct tui_win_info, struct tui_source_window_base)
1298         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
1299         * tui/tui-data.c (tui_init_generic_part): Update.
1300
1301 2019-06-25  Tom Tromey  <tom@tromey.com>
1302
1303         * tui/tui-wingeneral.c (tui_win_info::make_visible)
1304         (tui_source_window_base::make_visible): New methods.
1305         (make_all_visible): Make method call.
1306         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
1307         (struct tui_source_window_base, struct tui_cmd_window): Override
1308         make_visible.
1309         (tui_win_is_source_type): Don't declare.
1310         * tui/tui-data.c (tui_win_is_source_type): Remove.
1311
1312 2019-06-25  Tom Tromey  <tom@tromey.com>
1313
1314         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
1315         NULL check.
1316
1317 2019-06-25  Tom Tromey  <tom@tromey.com>
1318
1319         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
1320         Inline constructor.  Add initializers for members.
1321         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
1322         constructors; now inline in class.
1323
1324 2019-06-25  Tom Tromey  <tom@tromey.com>
1325
1326         * tui/tui-regs.c (tui_show_registers): Update.
1327         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
1328         bool.
1329         * tui/tui-data.c (tui_data_window::clear_detail)
1330         (tui_data_window): Update.
1331
1332 2019-06-25  Tom Tromey  <tom@tromey.com>
1333
1334         * tui/tui-windata.c (tui_display_all_data)
1335         (tui_display_data_from_line, tui_display_data_from)
1336         (tui_check_data_values, tui_data_window::do_scroll_vertical):
1337         Update.
1338         * tui/tui-regs.c (tui_last_regs_line_no)
1339         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1340         (tui_show_registers, tui_show_register_group)
1341         (tui_display_registers_from, tui_display_reg_element_at_line)
1342         (tui_display_registers_from_line, tui_check_register_values)
1343         (tui_reg_next, tui_reg_prev): Update.
1344         * tui/tui-layout.c (tui_set_layout, show_data): Update.
1345         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
1346         tui_data_window.
1347         (struct tui_win_info) <detail>: Remove.  Add new fields from
1348         tui_data_info.
1349         (TUI_DATA_WIN): Add cast.
1350         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
1351         (~tui_data_window): Simplify.
1352
1353 2019-06-25  Tom Tromey  <tom@tromey.com>
1354
1355         * tui/tui-layout.c (show_source_disasm_command)
1356         (show_source_or_disasm_and_command): Update.
1357         * tui/tui-io.c (update_cmdwin_start_line)
1358         (tui_redisplay_readline): Update.
1359         * tui/tui-data.h (struct tui_command_info): Remove.
1360         (struct tui_win_info) <detail>: Remove command_info member.
1361         (struct tui_data_window) <start_line>: New member, from
1362         tui_command_info.
1363         (TUI_CMD_WIN): Add casts.
1364
1365 2019-06-25  Tom Tromey  <tom@tromey.com>
1366
1367         * tui/tui-winsource.c (tui_update_source_window)
1368         (tui_refill_source_window)
1369         (tui_source_window_base::do_scroll_horizontal)
1370         (tui_update_breakpoint_info, tui_set_exec_info_content)
1371         (tui_show_exec_info_content, tui_erase_exec_info_content)
1372         (tui_clear_exec_info_content): Update.
1373         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
1374         Update.
1375         * tui/tui-win.c (make_invisible_and_set_new_height)
1376         (make_visible_with_new_height): Update.
1377         * tui/tui-source.c (tui_set_source_content)
1378         (tui_show_symtab_source): Update.
1379         * tui/tui-layout.c (extract_display_start_addr)
1380         (show_source_disasm_command, show_data)
1381         (make_source_or_disasm_window)
1382         (show_source_or_disasm_and_command): Update.
1383         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
1384         (tui_disasm_window::do_scroll_vertical): Remove shadowing
1385         "gdbarch".
1386         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
1387         to tui_source_window_base.
1388         (struct tui_win_info) <detail>: Remove source_info member.
1389         (struct tui_source_window_base) <has_locator>: Inline.
1390         Move contents from tui_source_info; rename has_locator member to
1391         m_has_locator.
1392         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
1393         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
1394         header file.
1395         (tui_source_window_base::clear_detail, ~tui_source_window_base):
1396         Simplify.
1397         (tui_free_all_source_wins_content): Cast to
1398         tui_source_window_base.
1399
1400 2019-06-25  Tom Tromey  <tom@tromey.com>
1401
1402         * tui/tui-win.c (make_invisible_and_set_new_height)
1403         (make_visible_with_new_height): Call has_locator method.
1404         * tui/tui-layout.c (show_source_disasm_command, show_data)
1405         (show_source_or_disasm_and_command): Update for bool change.
1406         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
1407         (tui_win_info) <has_locator>: New method.
1408         (struct tui_source_window_base) <has_locator>: New method.
1409         (tui_win_has_locator): Don't declare.
1410         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
1411         from tui_win_has_locator.
1412         (tui_source_window_base): Use false, not FALSE.
1413
1414 2019-06-25  Tom Tromey  <tom@tromey.com>
1415
1416         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
1417         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
1418         clear_detail method directly.
1419         (tui_clear_win_detail): Remove.
1420
1421 2019-06-25  Tom Tromey  <tom@tromey.com>
1422
1423         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
1424         "this", not TUI_DISASM_WIN.
1425
1426 2019-06-25  Tom Tromey  <tom@tromey.com>
1427
1428         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
1429         declare.
1430         * tui/tui-winsource.c
1431         (tui_source_window_base::do_scroll_horizontal): Rename from
1432         tui_horizontal_source_scroll.
1433         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
1434         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
1435         from tui_vertical_data_scroll.
1436         * tui/tui-win.h (tui_scroll): Don't declare.
1437         * tui/tui-win.c (tui_win_info::forward_scroll)
1438         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1439         (tui_win_info::right_scroll): Rename and update.
1440         (tui_scroll_forward_command, tui_scroll_backward_command)
1441         (tui_scroll_left_command, tui_scroll_right_command): Update.
1442         (tui_scroll): Remove.
1443         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
1444         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
1445         from tui_vertical_source_scroll.
1446         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
1447         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
1448         from tui_vertical_disassem_scroll.
1449         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
1450         do_scroll_horizontal>: New methods.
1451         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
1452         Likewise.
1453         (struct tui_source_window_base): Add do_scroll_horizontal.
1454         (struct tui_source_window, struct tui_disasm_window): Add
1455         do_scroll_vertical.
1456         (struct tui_data_window, struct tui_cmd_window): Add
1457         do_scroll_horizontal and do_scroll_vertical.
1458         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
1459
1460 2019-06-25  Tom Tromey  <tom@tromey.com>
1461
1462         * tui/tui-data.h (struct tui_source_window_base): New struct.
1463         (struct tui_source_window): Derive from tui_source_window_base.
1464         (struct tui_disasm_window): New struct.
1465         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
1466         from tui_source_window::clear_detail.
1467         (tui_source_window_base): Rename from tui_source_window.
1468         (~tui_source_window_base): Rename from ~tui_source_window.
1469         (tui_alloc_win_info): Create a tui_disasm_window.
1470
1471 2019-06-25  Tom Tromey  <tom@tromey.com>
1472
1473         * tui/tui-data.h (struct tui_source_window)
1474         (struct tui_data_window): Declare destructors.
1475         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
1476         destructors.
1477         (tui_win_info): Simplify.
1478
1479 2019-06-25  Tom Tromey  <tom@tromey.com>
1480
1481         * tui/tui-winsource.c (tui_display_main)
1482         (tui_update_source_windows_with_addr)
1483         (tui_update_all_breakpoint_info): Update.
1484         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1485         (new_height_ok, parse_scrolling_args): Update.
1486         * tui/tui-stack.c (tui_show_frame_info): Update.
1487         * tui/tui-data.h (struct tui_list): Remove.
1488         (tui_source_windows): Return a reference to a std::vector.
1489         * tui/tui-data.c (source_windows): Now a std::vector.
1490         (tui_source_windows): Change return type.
1491         (tui_clear_source_windows): Rewrite.
1492         (tui_clear_source_windows_detail, tui_add_to_source_windows)
1493         (tui_free_all_source_wins_content): Rewrite.
1494
1495 2019-06-25  Tom Tromey  <tom@tromey.com>
1496
1497         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
1498         (struct tui_data_window, struct tui_cmd_window): Declare
1499         clear_detail method.
1500         * tui/tui-data.c (tui_source_window::clear_detail)
1501         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
1502         methods.
1503         (tui_clear_win_detail): Simplify.
1504
1505 2019-06-25  Tom Tromey  <tom@tromey.com>
1506
1507         * tui/tui-layout.c (make_source_window, make_disasm_window)
1508         (make_source_or_disasm_window): Remove win_info_ptr parameter.
1509         Return the new window.
1510         (show_source_disasm_command, show_data)
1511         (show_source_or_disasm_and_command): Update.
1512
1513 2019-06-25  Tom Tromey  <tom@tromey.com>
1514
1515         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
1516         parameter.  Return the new window.
1517         (show_source_disasm_command): Update and remove NULL check.
1518         (show_source_or_disasm_and_command): Update.
1519
1520 2019-06-25  Tom Tromey  <tom@tromey.com>
1521
1522         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
1523
1524 2019-06-25  Tom Tromey  <tom@tromey.com>
1525
1526         * tui/tui-data.h (struct tui_win_info): Make constructor
1527         protected.  Make destructor virtual.  Add initializers.
1528         (tui_source_window, tui_data_window, tui_cmd_window): New
1529         classes.
1530         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
1531         constructor.  Add "type" parameter.
1532         (tui_source_window, tui_data_window, tui_cmd_window): New
1533         constructors.
1534         (tui_alloc_win_info): Instantiate the appropriate subclass.
1535
1536 2019-06-25  Tom Tromey  <tom@tromey.com>
1537
1538         * tui/tui-win.c (tui_resize_all): Use delete.
1539         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
1540         destructor.
1541         (tui_free_window): Don't declare.
1542         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
1543         Update.
1544
1545 2019-06-25  Tom Tromey  <tom@tromey.com>
1546
1547         * tui/tui-data.h (struct tui_win_info): Add constructor.
1548         * tui/tui-data.c (tui_alloc_win_info): Use new.
1549         (tui_free_window): Use delete.
1550
1551 2019-06-22  Tom Tromey  <tom@tromey.com>
1552
1553         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
1554         declare.
1555         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
1556
1557 2019-06-22  Tom Tromey  <tom@tromey.com>
1558
1559         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
1560         declare.
1561         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
1562
1563 2019-06-22  Tom de Vries  <tdevries@suse.de>
1564
1565         * dwarf2read.c (create_addrmap_from_aranges)
1566         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
1567         instead of '%zu'.
1568
1569 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
1570
1571         * dwarf2read.h (dwarf2_section_info_def): Remove.
1572         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
1573         * dwarf2read.c (struct dwo_sections) <types>: Change type to
1574         std::vector<dwarf2_section_info>.
1575         (struct dwo_file) <~dwo_file>: Remove.
1576         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
1577         types field.
1578         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
1579         (dwarf2_read_debug_names): Likewise.
1580         (create_debug_types_hash_table): Change parameter type to
1581         array_view, adjust code accordingly.
1582         (dwarf2_locate_dwo_sections): Adjust to std::vector.
1583         (partial_die_info::fixup): Likewise.
1584         (determine_prefix): Likewise.
1585         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
1586
1587 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1588
1589         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
1590         gdb_bfd_ref_ptr.
1591         <~dwo_file>: Remove call to gdb_bfd_unref.
1592         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
1593         gdb_bfd_ref_ptr::get.
1594
1595 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1596
1597         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
1598         type to htab_up.
1599         * dwarf2read.c (struct dwo_file): Initialize fields.
1600         <~dwo_file>: New.
1601         (free_dwo_file): Remove, move content to ~dwo_file.
1602         (struct dwo_file_deleter): Remove.
1603         (dwo_file_up>: Remove custom deleter.
1604         (free_dwo_files): Remove.
1605         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
1606         dwo_files.
1607         (process_skeletonless_type_units): Call unique_ptr::get.
1608         (allocate_dwo_file_hash_table): Add deleter to created hash
1609         table.  Change return type to htab_up.
1610         (lookup_dwo_file_slot): Don't memset dwo_file, call
1611         unique_ptr::get.
1612         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
1613         (create_dwo_unit_in_dwp_v2): Likewise.
1614         (open_and_init_dwo_file): Likewise.
1615         (free_dwo_file_from_slot): Remove.
1616
1617 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1618
1619         * dwarf2read.h (struct dwarf2_section_info) <readin,
1620         is_virtual>: Change type to bool.
1621         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
1622         true instead of 1.
1623
1624 2019-06-19  Tom Tromey  <tom@tromey.com>
1625
1626         * tui/tui-data.h (tui_init_content_element): Don't declare.
1627
1628 2019-06-19  Tom Tromey  <tom@tromey.com>
1629
1630         * tui/tui-data.h (tui_init_win_info): Don't declare.
1631
1632 2019-06-19  Tom de Vries  <tdevries@suse.de>
1633
1634         * dwarf2read.h (abstract_to_concrete): Change type to
1635         std::unordered_map<sect_offset, std::vector<sect_offset>,
1636         gdb::hash_enum<sect_offset>>.
1637
1638 2019-06-19  Tom Tromey  <tromey@adacore.com>
1639
1640         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
1641         EVAL_AVOID_SIDE_EFFECTS specially.
1642
1643 2019-06-19  Tom Tromey  <tromey@adacore.com>
1644
1645         * source-cache.c (highlighter): New global.
1646         (source_cache::get_source_lines): Create a highlighter on demand.
1647
1648 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1649
1650         * defs.h (deprecated_interactive_hook): Delete declaration.
1651         * interps.c (clear_interpreter_hooks): Remove use of
1652         deprecated_interactive_hook.
1653         * top.c (deprecated_interactive_hook): Delete definition.
1654         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
1655
1656 2019-06-18  Tom de Vries  <tdevries@suse.de>
1657
1658         PR gdb/24515
1659         * dwarf2read.h (abstract_to_concrete): Change type from
1660         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
1661         std::unordered_map<sect_offset, std::vector<sect_offset>>.
1662         * dwarf2read.c (read_variable): Update.
1663         (dwarf2_fetch_die_loc_sect_off): Update.
1664
1665 2019-06-17  Tom de Vries  <tdevries@suse.de>
1666
1667         PR gdb/24617
1668         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
1669         accessing parent[parent_len - 1].
1670
1671 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
1672
1673         PR gdb/24364
1674         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
1675         call dtrace_process_dof with NULL dof.
1676
1677 2019-06-16  Tom de Vries  <tdevries@suse.de>
1678
1679         PR gdb/24445
1680         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
1681
1682 2019-06-16  Tom Tromey  <tom@tromey.com>
1683
1684         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1685         (make_all_visible): Use address of member.
1686
1687 2019-06-16  Tom Tromey  <tom@tromey.com>
1688
1689         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
1690         (tui_free_window, free_content, free_content_elements): Remove
1691         unnecessary cast.
1692         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
1693         cast.
1694         * tui/tui-regs.c (tui_show_register_group)
1695         (tui_display_registers_from, tui_display_reg_element_at_line):
1696         Remove unnecessary cast.
1697
1698 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
1699
1700         * linux-nat.c (normal_mask): Delete.
1701         (_initialize_linux_nat): Don't initialise normal_mask.
1702
1703 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
1704
1705         PR gdb/24445
1706         * dwarf-index-write.h (write_psymtabs_to_index): Add
1707         dwz_basename parameter.
1708         * dwarf-index-write.c (write_gdbindex): Move file writing to
1709         write_gdbindex_1.  Change return type void.
1710         (assert_file_size): Move up, remove filename parameter.
1711         (write_gdbindex_1): New function.
1712         (write_debug_names): Change return type to void, call
1713         assert_file_size.
1714         (struct index_wip_file): New struct.
1715         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
1716         file logic to index_wip_file.  Write index for dwz file if
1717         needed.
1718         (save_gdb_index_command): Pass basename of dwz file, if present.
1719         * dwarf-index-cache.c (index_cache::store): Obtain and pass
1720         build-id of dwz file, if present.
1721         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
1722         (dwarf2_get_dwz_file): Likewise.
1723         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
1724         (dwarf2_get_dwz_file): Likewise.
1725
1726 2019-06-16  Tom Tromey  <tom@tromey.com>
1727
1728         * coffread.c (process_coff_symbol): Use xstrdup.
1729         * value.c (create_internalvar): Use xstrdup.
1730
1731 2019-06-16  Tom Tromey  <tom@tromey.com>
1732
1733         * valops.c (value_cast, value_slice): Remove unnecessary cast.
1734         * breakpoint.c (stopin_command, stopat_command)
1735         (until_break_command, decode_location_default): Remove unnecessary
1736         cast.
1737         * utils.c (subset_compare): Remove unnecessary cast.
1738         * ada-lang.c (ada_update_initial_language): Remove unnecessary
1739         cast.
1740         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
1741         cast.
1742         * infcmd.c (path_command): Remove unnecessary cast.
1743         * coffread.c (decode_type): Remove unnecessary cast.
1744         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
1745         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
1746         * tui/tui-stack.c (tui_show_locator_content)
1747         (tui_show_frame_info): Remove unnecessary cast.
1748         * tui/tui-win.c (tui_scroll_forward_command)
1749         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
1750         (parse_scrolling_args): Remove unnecessary cast.
1751         * tui/tui-data.c (init_win_info, tui_del_window)
1752         (tui_free_window, tui_del_data_windows, tui_free_data_content)
1753         (free_content_elements): Remove unnecessary cast.
1754         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
1755         unnecessary cast.
1756         * tui/tui-source.c (tui_set_source_content)
1757         (tui_vertical_source_scroll): Remove unnecessary cast.
1758         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
1759         cast.
1760         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
1761         * tui/tui-regs.c (tui_display_registers_from)
1762         (tui_display_register): Remove unnecessary cast.
1763         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
1764         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
1765         (make_visible): Remove unnecessary cast.
1766         * tui/tui-winsource.c (tui_erase_source_content)
1767         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
1768         unnecessary cast.
1769         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
1770         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
1771         * stabsread.c (read_type, read_array_type, read_range_type):
1772         Remove unnecessary cast.
1773         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
1774         (parse_symbol, parse_type, upgrade_type, parse_external)
1775         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
1776         unnecessary cast.
1777         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
1778
1779 2019-06-16  Tom Tromey  <tom@tromey.com>
1780
1781         * tui/tui-data.c (tui_alloc_generic_win_info)
1782         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
1783         checks.
1784
1785 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
1786             Andrew Burgess  <andrew.burgess@embecosm.com>
1787
1788         * f-typeprint.c (f_print_type): Don't return early for not
1789         associated or not allocated types.
1790         (f_type_print_varspec_suffix): Add print_rank parameter and print
1791         ranks of array types in case they dangling.
1792         (f_type_print_base): Add print_rank parameter.
1793
1794 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1795
1796         * NEWS: Mention new MI commands.
1797         * break-catch-throw.c (enum exception_event_kind): Move to
1798         breakpoint.h.
1799         (print_mention_exception_catchpoint): Output text as a single
1800         message.
1801         (catch_exception_command_1): Rename to...
1802         (catch_exception_event): ...this, make non-static, update header
1803         command, and change some parameter types.
1804         (catch_catch_command): Update for changes to
1805         catch_exception_command_1.
1806         (catch_throw_command): Likewise.
1807         (catch_rethrow_command): Likewise.
1808         * breakpoint.c (enum exception_event_kind): Delete.
1809         * breakpoint.h (enum exception_event_kind): Moved here from
1810         break-catch-throw.c.
1811         (catch_exception_event): Declare.
1812         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
1813         (mi_cmd_catch_throw): New function.
1814         (mi_cmd_catch_rethrow): New function.
1815         (mi_cmd_catch_catch): New function.
1816         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
1817         'catch-catch' entries.
1818         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
1819         (mi_cmd_catch_rethrow): Declare.
1820         (mi_cmd_catch_catch): Declare.
1821
1822 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1823
1824         * annotate.c (annotate_source_line): Change return type to void,
1825         update implementation to match.
1826         * annotate.h (annotate_source_line): Change return type to void,
1827         update header comment.
1828         * stack.c (print_frame_info): Don't change what frame information
1829         is printed based on whether annotations are on or not.
1830
1831 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1832
1833         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
1834         (annotate_source): Make static.
1835         (annotate_source_line): Moved from source.c and renamed from
1836         identify_source_line.  Update the return type.
1837         * annotate.h (annotate_source): Delete declaration.
1838         (annotate_source_line): Declaration moved from source.h, and
1839         renamed from identify_source_line.  Return type updated.
1840         * source.c (identify_source_line): Moved to annotate.c and renamed
1841         to annotate_source_line.
1842         (info_line_command): Remove check of annotation_level.
1843         * source.h (identify_source_line): Move declaration to annotate.h
1844         and rename to annotate_source_line.
1845         * stack.c: Add 'annotate.h' include.
1846         (print_frame_info): Remove check of annotation_level before
1847         calling annotate_source_line.
1848
1849 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1850
1851         * source-cache.c (source_cache::get_plain_source_lines): Use
1852         open_source_file_with_line_charpos instead of just
1853         open_source_file, remove call to find_source_lines.
1854         (source_cache::get_source_lines): Likewise.
1855         * source.c (find_source_lines): Make static.
1856         (get_filename_and_charpos): Renamed into...
1857         (open_source_file_with_line_charpos): ..this along with changes to
1858         return a scoped_fd, and some other minor clean ups.
1859         (identify_source_line): Use open_source_file_with_line_charpos.
1860         (search_command_helper): Use open_source_file_with_line_charpos
1861         instead of just open_source_file, remove call to
1862         find_source_lines.
1863         * source.h (open_source_file_with_line_charpos): Declare new
1864         function.
1865         (find_source_lines): Delete declaration.
1866
1867 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1868
1869         * source.c (get_filename_and_charpos): Remove fullname
1870         parameter.
1871         (identify_source_line): Update call to get_filename_and_charpos.
1872
1873 2019-06-14  Tom Tromey  <tromey@adacore.com>
1874
1875         PR gdb/24502:
1876         * ui-style.h (skip_ansi_escape): Update comment.
1877         * ui-file.h (class no_terminal_escape_file): New class.
1878         * ui-file.c (no_terminal_escape_file::write)
1879         (no_terminal_escape_file::puts): New methods.
1880         * cli/cli-logging.c (handle_redirections): Use
1881         no_terminal_escape_file.
1882
1883 2019-06-14  Tom Tromey  <tromey@adacore.com>
1884
1885         * NEWS: Move convenience variable news above Python news.
1886
1887 2019-06-14  Tom Tromey  <tom@tromey.com>
1888
1889         * gnulib: Move directory to top-level.
1890         * configure.ac: Don't configure gnulib.
1891         * configure: Rebuild.
1892         * common/common-defs.h: Use new path to gnulib.
1893         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
1894         (GNULIB_H): Remove.
1895         (INCGNU): Look in new gnulib location.
1896         (HFILES_NO_SRCDIR): Remove gnulib files.
1897         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
1898         (generated_files): Remove GNULIB_H.
1899         ($(LIBGNU), all-lib): Remove targets.
1900         (distclean): Don't mention GNULIB_BUILDDIR.
1901         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
1902
1903 2019-06-14  Tom Tromey  <tromey@adacore.com>
1904
1905         * symfile.c (add_symbol_file_command): Remove obsolete comment.
1906         Warn if symbol file does not provide any symbols.
1907
1908 2019-06-14  Tom Tromey  <tromey@adacore.com>
1909
1910         * source.c (find_and_open_source): Respect basenames_may_differ.
1911
1912 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
1913
1914         * annotate.c (annotate_breakpoints_invalid): Make use of
1915         scoped_restore_terminal_state.
1916         (annotate_frames_invalid): Likewise.
1917
1918 2019-06-14  Tom Tromey  <tromey@adacore.com>
1919
1920         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
1921         allow assignment to an internalvar.
1922
1923 2019-06-14  Tom Tromey  <tromey@adacore.com>
1924
1925         * ada-lex.l: Allow "_" in attribute names.
1926
1927 2019-06-14  Tom Tromey  <tromey@adacore.com>
1928
1929         PR gdb/24653:
1930         * regcache.c (registers_changed): Don't call alloca.
1931         * top.c (execute_command): Don't call alloca.
1932
1933 2019-06-13  Pedro Alves  <palves@redhat.com>
1934
1935         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
1936         'expression'.  When parsing an expression, error out if there's
1937         junk after "unlimited".
1938         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1939         (do_set_command): Adjust calls to is_unlimited_literal.
1940
1941 2019-06-13  Pedro Alves  <palves@redhat.com>
1942
1943         * compile/compile.c (make_compile_options_def_group): Add braces
1944         around array_view initializer.
1945         * thread.c (make_thread_apply_all_options_def_group)
1946         (make_thread_apply_all_options_def_group): Likewise.
1947
1948 2019-06-13  Pedro Alves  <palves@redhat.com>
1949
1950         * NEWS (New commands): Mention "maint test-options
1951         require-delimiter", "maint test-options unknown-is-error", "maint
1952         test-options unknown-is-operand" and "maint show
1953         test-options-completion-result".
1954         (New command options, command completion): New section.
1955         (Completion improvements): New section.
1956         Mention that you can abbreviate "unlimited".
1957
1958 2019-06-13  Pedro Alves  <palves@redhat.com>
1959
1960         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
1961         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
1962         * unittests/cli-utils-selftests.c (test_parse_flags)
1963         (test_parse_flags_qcs): Delete.
1964         (test_cli_utils): Don't call deleted functions.
1965
1966 2019-06-13  Pedro Alves  <palves@redhat.com>
1967
1968         * thread.c: Include "cli/cli-option.h".
1969         (tp_array_compar_ascending): Global.
1970         (tp_array_compar): Delete function.
1971         (tp_array_compar_ascending, tp_array_compar_descending): New
1972         functions.
1973         (ascending_option_def, qcs_flag_option_def)
1974         (thr_qcs_flags_option_defs)
1975         (make_thread_apply_all_options_def_group)
1976         (make_thread_apply_options_def_group): New.
1977         (thread_apply_all_command): Use gdb::option::process_options.
1978         (thread_apply_command_completer)
1979         (thread_apply_all_command_completer): New.
1980         (thread_apply_command): Use gdb::option::process_options.
1981         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
1982         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
1983         to generate help text of "thread apply".  Adjust "taas"'s help.
1984         * tid-parse.c (tid_range_parser::in_thread_range): New method.
1985         * tid-parse.h (tid_range_parser::in_thread_range): New method.
1986
1987 2019-06-13  Pedro Alves  <palves@redhat.com>
1988
1989         * thread.c (thread_apply_command): Check for invalid TID with
1990         isdigit instead of !isalpha.
1991
1992 2019-06-13  Pedro Alves  <palves@redhat.com>
1993
1994         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
1995         (validate_flags_qcs): New.
1996         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
1997         (validate_flags_qcs): Declare.
1998         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
1999         (make_frame_apply_options_def_group): New.
2000         (frame_apply_command_count): Process options with
2001         gdb::option::process_options.
2002         (frame_apply_completer): New.
2003         (frame_apply_level_completer, frame_apply_all_completer)
2004         (frame_apply_completer): New.
2005         (_initialize_stack): Update help of "frame apply", "frame apply
2006         level", "frame apply all" and "faas" to mention supported options
2007         and install command completers.
2008         * stack.h (frame_apply_all_completer): Declare.
2009         * thread.c: Include "stack.h".
2010         (tfaas_command): Add "--".
2011         (_initialize_thread): Update help "tfaas" to mention supported
2012         options and install command completer.
2013
2014 2019-06-13  Pedro Alves  <palves@redhat.com>
2015
2016         * completer.c (complete_nested_command_line): New.
2017         (gdb_completion_word_break_characters_throw): Add assertion.
2018         * completer.h (complete_nested_command_line): Declare.
2019
2020 2019-06-13  Pedro Alves  <palves@redhat.com>
2021
2022         * stack.c (parse_backtrace_qualifiers): New.
2023         (backtrace_command): Use it.
2024         (backtrace_command_completer): Complete on qualifiers.
2025
2026 2019-06-13  Pedro Alves  <palves@redhat.com>
2027
2028         * frame.c: Include "cli/cli-option.h.
2029         (user_set_backtrace_options): New.
2030         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2031         Delete.
2032         (get_prev_frame): Adjust.
2033         (boolean_option_def, uinteger_option_def)
2034         (set_backtrace_option_defs): New.
2035         (_initialize_frame): Adjust and use
2036         gdb::option::add_setshow_cmds_for_options to install "set
2037         backtrace past-main" and "set backtrace past-entry".
2038         * frame.h: Include "cli/cli-option.h".
2039         (struct frame_print_options): Forward declare.
2040         (print_frame_arguments_all, print_frame_arguments_scalars)
2041         (print_frame_arguments_none): Declare.
2042         (print_entry_values): Delete declaration.
2043         (struct frame_print_options, user_frame_print_options): New.
2044         (struct set_backtrace_options): New.
2045         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2046         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2047         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2048         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2049         (list_args_or_locals): Add frame_print_options parameter.
2050         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2051         * python/py-framefilter.c (enumerate_args): Pass down
2052         USER_FRAME_PRINT_OPTIONS.
2053         * stack.c: Include "cli/cli-option.h".
2054         (print_frame_arguments_all, print_frame_arguments_scalars)
2055         (print_frame_arguments_none): Declare.
2056         (print_raw_frame_arguments, print_entry_values): Delete.
2057         (user_frame_print_options): New.
2058         (boolean_option_def, enum_option_def, frame_print_option_defs):
2059         New.
2060         (struct backtrace_cmd_options): New.
2061         (bt_flag_option_def): New.
2062         (backtrace_command_option_defs): New.
2063         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2064         (print_frame_arg, read_frame_arg, print_frame_args)
2065         (print_frame_info, print_frame): Add frame_print_options parameter
2066         and use it.
2067         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2068         (backtrace_command_1): Add frame_print_options and
2069         backtrace_cmd_options parameters and use them.
2070         (make_backtrace_options_def_group): New.
2071         (backtrace_command): Process command options with
2072         gdb::option::process_options.
2073         (backtrace_command_completer): New.
2074         (_initialize_stack): Extend "backtrace"'s help to mention
2075         supported options.  Install completer for "backtrace".
2076         Install some settings commands with add_setshow_cmds_for_options.
2077
2078 2019-06-13  Pedro Alves  <palves@redhat.com>
2079
2080         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2081         and that "set/show print raw frame-arguments" are now deprecated.
2082
2083         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2084         command.
2085         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2086         * stack.c (_initialize_stack): Install "set/show print
2087         raw-frame-arguments", and deprecate "set/show print raw
2088         frame-arguments".
2089         * valprint.c (_initialize_valprint): Deprecate "set/show print
2090         raw".
2091
2092 2019-06-13  Pedro Alves  <palves@redhat.com>
2093
2094         * compile/compile.c (struct compile_options): New.
2095         (compile_flag_option_def, compile_command_option_defs)
2096         (make_compile_options_def_group): New.
2097         (compile_file_command): Handle options with
2098         gdb::option::process_options.
2099         (compile_file_command_completer): New function.
2100         (compile_code_command): Handle options with
2101         gdb::option::process_options.
2102         (compile_code_command_completer): New function.
2103         (_initialize_compiler): Install completers for "compile code" and
2104         "compile file".  Mention available options in "compile code" and
2105         "compile code"'s help.
2106         * completer.c (advance_to_completion_word): New, factored out from
2107         ...
2108         (advance_to_expression_complete_word_point): ... this.
2109         (advance_to_filename_complete_word_point): New.
2110         * completer.h (advance_to_filename_complete_word_point): New
2111         declaration.
2112
2113 2019-06-13  Pedro Alves  <palves@redhat.com>
2114
2115         * compile/compile.c: Include "cli/cli-option.h".
2116         (compile_print_value): Scope data pointer is now a
2117         value_print_options pointer; adjust.
2118         (compile_print_command): Process options.  Scope data pointer is
2119         now a value_print_options pointer; adjust.
2120         (_initialize_compile): Update "compile print"'s help to include
2121         supported options.  Install a completer for "compile print".
2122         * cp-valprint.c (show_vtblprint, show_objectprint)
2123         (show_static_field_print): Delete.
2124         (_initialize_cp_valprint): Don't install "set print
2125         static-members", "set print vtbl", "set print object" here.
2126         * printcmd.c: Include "cli/cli-option.h" and
2127         "common/gdb_optional.h".
2128         (print_command_parse_format): Rework to fill in a
2129         value_print_options instead of a format_data.
2130         (print_value): Change parameter type from format_data pointer to
2131         value_print_options reference.  Adjust.
2132         (print_command_1): Process options.  Adjust to pass down a
2133         value_print_options.
2134         (print_command_completer): New.
2135         (_initialize_printcmd): Install print_command_completer as
2136         handle_brkchars completer for the "print" command.  Update
2137         "print"'s help to include supported options.
2138         * valprint.c: Include "cli/cli-option.h".
2139         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2140         here from cp-valprint.c.
2141         (boolean_option_def, uinteger_option_def)
2142         (value_print_option_defs, make_value_print_options_def_group):
2143         New.  Use gdb::option::add_setshow_cmds_for_options to install
2144         "set print elements", "set print null-stop", "set print repeats",
2145         "set print pretty", "set print union", "set print array", "set
2146         print address", "set print symbol", "set print array-indexes".
2147         * valprint.h: Include <string> and "cli/cli-option.h".
2148         (make_value_print_options_def_group): Declare.
2149         (print_value): Change parameter type from format_data pointer to
2150         value_print_options reference.
2151         (print_command_completer): Declare.
2152
2153 2019-06-13  Pedro Alves  <palves@redhat.com>
2154
2155         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2156         (COMMON_SFILES): Add maint-test-settings.c.
2157         * cli/cli-decode.c (boolean_enums): New global, factored out from
2158         ...
2159         (add_setshow_boolean_cmd): ... here.
2160         * cli/cli-decode.h (boolean_enums): Declare.
2161         * cli/cli-option.c: New file.
2162         * cli/cli-option.h: New file.
2163         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2164         factored out from ...
2165         (parse_cli_boolean_value(const char *)): ... this.
2166         (is_unlimited_literal): Change parameter type to pointer to
2167         pointer.  Adjust and advance ARG pointer.
2168         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2169         (parse_cli_var_enum): New, factored out from ...
2170         (do_set_command): ... this.  Adjust.
2171         * cli/cli-setshow.h (parse_cli_boolean_value)
2172         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2173         (parse_cli_var_enum): Declare.
2174         * cli/cli-utils.c: Include "cli/cli-option.h".
2175         (get_ulongest): New.
2176         * cli/cli-utils.h (get_ulongest): Declare.
2177         (check_for_argument): New overloads.
2178         * maint-test-options.c: New file.
2179
2180 2019-06-13  Pedro Alves  <palves@redhat.com>
2181
2182         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2183         parse a range if "-" is at the end of the string.
2184
2185 2019-06-13  Pedro Alves  <palves@redhat.com>
2186
2187         * cli/cli-setshow.c (parse_auto_binary_operation)
2188         (parse_cli_boolean_value): Don't allow "o".
2189
2190 2019-06-13  Pedro Alves  <palves@redhat.com>
2191
2192         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2193         * NEWS: Mention maint test-settings KIND.
2194         * maint-test-settings.c: New file.
2195
2196 2019-06-13  Pedro Alves  <palves@redhat.com>
2197
2198         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2199         completer.
2200         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2201         "set" completers.
2202
2203 2019-06-13  Pedro Alves  <palves@redhat.com>
2204
2205         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2206         after item.
2207
2208 2019-06-13  Pedro Alves  <palves@redhat.com>
2209
2210         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2211
2212 2019-06-13  Pedro Alves <palves@redhat.com>
2213
2214         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2215         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2216         call.
2217         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2218         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2219         calls.
2220         (check_for_argument): Skip spaces after argument.
2221
2222 2019-06-13  Pedro Alves  <palves@redhat.com>
2223
2224         * thread.c (thread_apply_command): Adjust TID parsing.
2225         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2226         detected before end of string.
2227         (tid_is_in_list): Error out if LIST is invalid.
2228
2229 2019-06-13  Pedro Alves  <palves@redhat.com>
2230
2231         * completer.c (complete_line_internal_1): Rewind completion word
2232         point.
2233         (completion_tracker::advance_custom_word_point_by): Change
2234         parameter type to int.
2235         * completer.h (completion_tracker::advance_custom_word_point_by):
2236         Likewise.
2237
2238 2019-06-13  Pedro Alves  <palves@redhat.com>
2239
2240         * completer.c (advance_to_completion_word): Handle delimiters.
2241
2242 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2243
2244         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2245
2246 2019-06-11  Tom Tromey  <tom@tromey.com>
2247
2248         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2249         (xmalloc_failed): Move to alloc.c.
2250         * alloc.c: New file.
2251         * Makefile.in (COMMON_SFILES): Add alloc.c.
2252
2253 2019-06-11  Tom Tromey  <tom@tromey.com>
2254
2255         * nat/linux-waitpid.c: Don't include server.h.
2256         (linux_debug): Remove.
2257         (my_waitpid): Update.
2258
2259 2019-06-11  Tom Tromey  <tromey@adacore.com>
2260
2261         * infcall.c (_initialize_infcall): Remove trailing newline from
2262         help.
2263         * user-regs.c (_initialize_user_regs): Remove trailing newline
2264         from help.
2265         * typeprint.c (_initialize_typeprint): Remove trailing newline
2266         from help.
2267         * reverse.c (_initialize_reverse): Remove trailing newlines from
2268         help.
2269         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2270         from help.
2271         * language.c (add_set_language_command): Remove trailing newline
2272         from help.
2273         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2274         help.
2275         * disasm.c (_initialize_disasm): Remove trailing newline from
2276         help.
2277         * top.c (init_main): Remove trailing newline from help.
2278         * interps.c (_initialize_interpreter): Remove trailing newline
2279         from help.
2280         * btrace.c (_initialize_btrace): Remove trailing newlines from
2281         help.
2282         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
2283         from help.
2284         * python/python.c (_initialize_python): Remove trailing newline
2285         from help.
2286         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
2287         help.
2288         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
2289         from help.  Reformat some text.
2290         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
2291         from help.
2292         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
2293         newline from help.
2294
2295 2019-06-11  Tom Tromey  <tromey@adacore.com>
2296
2297         * darwin-nat.c (darwin_decode_exception_message)
2298         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
2299
2300 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2301
2302         * valops.c (value_slice): Check for not allocated or not
2303         associated values.
2304
2305 2019-06-10  Tom de Vries  <tdevries@suse.de>
2306
2307         PR gdb/24618
2308         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
2309         sure an empty slot (defined by a 32-bit zero pair) is recognized as
2310         invalid.
2311
2312 2019-06-10  Tom de Vries  <tdevries@suse.de>
2313
2314         PR gdb/24611
2315         * linespec.c (linespec_lexer_lex_string): Remove incorrect
2316         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
2317
2318 2019-06-10  Tom de Vries  <tdevries@suse.de>
2319
2320         PR symtab/24545
2321         * symtab.c (struct demangled_name_entry): Add language field.
2322         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
2323         static minimal symbol".  Set and use language field.
2324
2325 2019-06-10  Tom Tromey  <tromey@adacore.com>
2326
2327         * ada-lang.c (_initialize_ada_language): Update help text.
2328
2329 2019-06-10  Tom Tromey  <tromey@adacore.com>
2330
2331         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
2332         with a newline.
2333         * guile/guile.c (handle_boot_error): Don't end warning with a
2334         newline.
2335         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
2336         warning with a newline.
2337         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
2338         newline.
2339         (s12z_frame_cache): Likewise.
2340         * dwarf-index-cache.c (index_cache::store): Don't end warning with
2341         a newline.
2342         * solib-svr4.c (disable_probes_interface): Don't end warning with
2343         a newline.
2344         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2345         newline.
2346         * python/python.c (do_finish_initialization): Don't end warning
2347         with a newline.
2348
2349 2019-06-10  Tom Tromey  <tom@tromey.com>
2350
2351         * python/py-breakpoint.c (gdbpy_breakpoint_created)
2352         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
2353         gdbpy_enter.
2354
2355 2019-06-10  Tom Tromey  <tromey@adacore.com>
2356
2357         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
2358         data.
2359         (elf_new_init): Don't call stabsread_new_init.
2360         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
2361         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
2362         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
2363
2364 2019-06-10  Tom de Vries  <tdevries@suse.de>
2365
2366         PR symtab/16264
2367         PR symtab/24517
2368         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
2369
2370 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
2371
2372         * source.c (find_and_open_source): Also rewrite relative file
2373         names.
2374
2375 2019-04-26  Amos Bird  <amosbird@gmail.com>
2376
2377         * annotate.c (annotate_thread_exited): Add "thread-exited"
2378         annotation.
2379
2380 2019-06-06  Tom Tromey  <tromey@adacore.com>
2381
2382         * maint.h (class scoped_command_stats): Use
2383         DISABLE_COPY_AND_ASSIGN.
2384         <print_time>: New method.
2385         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
2386         print_time.
2387         (scoped_command_stats::print_time): New method.
2388
2389 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2390
2391         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
2392         instructions of lengths 6 or 8 bytes.
2393
2394 2019-06-04  Pedro Alves  <palves@redhat.com>
2395
2396         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
2397
2398         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
2399         * breakpoint.c (condition_completer): Likewise.
2400         * cli/cli-dump.c (scan_expression): Likewise.
2401         * common/filestuff.c (mkdir_recursive): Likewise.
2402         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
2403         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
2404         (gdb_abspath): Likewise.
2405         * compile/compile-cplus-types.c
2406         (compile_cplus_instance::decl_name): Likewise.
2407         * completer.c (complete_explicit_location):
2408         (signal_completer, reg_or_group_completer_1): Likewise.
2409         * cp-support.c (cp_remove_params_if_any): Likewise.
2410         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
2411         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
2412         * infcmd.c (strip_bg_char): Likewise.
2413         * linespec.c (copy_token_string): Likewise.
2414         * mi/mi-main.c (output_cores): Likewise.
2415         * psymtab.c (psymtab_search_name):
2416         * symfile.c (test_set_ext_lang_command): Likewise.
2417         * target.c (target_fileio_read_stralloc): Likewise.
2418         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
2419         * value.c (complete_internalvar): Likewise.
2420
2421 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
2422
2423         Add objfile property to gdb.Type.
2424         * NEWS: Mention Python API addition.
2425         * python/py-type.c (typy_get_objfile): New method.
2426
2427 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2428
2429         * NEWS: Mention the new set|show style [title|highlight].
2430         Mention changes to "show style", "help" and "apropos".
2431
2432 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2433
2434         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
2435         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
2436         instead of print_help_for_command.
2437         (print_doc_of_command): New function.
2438         (help_list): Add 'apropos -v word' suggestion.
2439         (print_help_for_command): Style the command name using title style.
2440         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
2441         (_initialize_cli_cmds): Describe -v in apropos_command help.
2442
2443 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2444
2445         * cli/cli-style.h (cli_style_option): Add name in constructor,
2446         add m_name class member, add constructor with intensity,
2447         add name class function.
2448         (cli_style_option::add_setshow_commands): Remove name argument.
2449         (highlight_style, title_style): New styles.
2450         * cli/cli-style.c (do_show): New function that shows a style
2451         characteristic styling the style name with itself.
2452         (set_style_name): New function.
2453         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
2454         Update all callers according to the changes in cli/cli-style.h.
2455         * utils.h (fputs_highlighted): New function.
2456         * utils.c (fputs_highlighted): Likewise.
2457
2458 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2459
2460         * NEWS: Mention new pipe command and new convenience variables.
2461
2462 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2463
2464         * cli/cli-cmds.c (pipe_command): New function.
2465         (_initialize_cli_cmds): Call add_com for pipe_command.
2466         Define | as an alias for pipe.
2467         (exit_status_set_internal_vars): New function.
2468         (shell_escape): Call exit_status_set_internal_vars.
2469         cli/cli-decode.c (find_command_name_length): Recognize | as
2470         a single character command.
2471
2472 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2473
2474         * gdbcmd.h (execute_command_to_ui_file): New declaration.
2475         top.c (execute_command_to_ui_file): New function, mostly a copy
2476         of execute_command_to_string.
2477         (execute_command_to_string): Implement by calling
2478         execute_command_to_ui_file.
2479
2480 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2481
2482         * top.h (saved_command_line): Remove declaration.
2483         * top.c (previous_saved_command_line, previous_repeat_arguments):
2484         New variables.
2485         (saved_command_line): Make static, define together with other
2486         'repeat variables'.
2487         (dont_repeat): Clear repeat_arguments.
2488         (repeat_previous, get_saved_command_line, save_command_line):
2489         New functions.
2490         (gdb_init): Initialize saved_command_line
2491         and previous_saved_command_line.
2492         * main.c (captured_main_1): Remove saved_command_line initialization.
2493         * event-top.c (handle_line_of_input): Update to use
2494         the new 'repeat' related functions instead of direct access to
2495         saved_command_line.
2496         * command.h (repeat_previous, get_saved_command_line,
2497         save_command_line): New declarations.
2498         (dont_repeat): Add comment.
2499
2500 2019-05-30  Tom Tromey  <tromey@adacore.com>
2501
2502         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
2503         Fix comment.
2504         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
2505
2506 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
2507
2508         PR cli/24587
2509         * completer.c (complete): Initialize variable word.
2510
2511 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
2512
2513         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2514         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
2515         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
2516         'body' is NULL to the outter 'if', protecting the '!is_define'
2517         situation as well.
2518
2519 2019-05-29  Tom Tromey  <tromey@adacore.com>
2520
2521         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
2522         (dwarf_unknown): New function.
2523         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
2524         (dwarf_type_encoding_name): Use dwarf_unknown.
2525
2526 2019-05-29  Tom Tromey  <tromey@adacore.com>
2527
2528         PR c++/20020:
2529         * cp-valprint.c (cp_print_value_fields): Call
2530         cp_print_static_field inside "try".
2531
2532 2019-05-29  Tom Tromey  <tromey@adacore.com>
2533
2534         * inflow.c (struct terminal_info): Add default operator=.
2535         * configure: Rebuild.
2536         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
2537         -Wdeprecated-copy-dtor, -Wredundant-move.
2538
2539 2019-05-29  Tom Tromey  <tromey@adacore.com>
2540
2541         * NEWS: Add entry.
2542         * infcmd.c (print_return_value_1): Handle finish_print
2543         option.
2544         (show_print_finish): New function.
2545         (_initialize_infcmd): Add "set/show print finish" commands.
2546         * valprint.c (user_print_options): Initialize new member.
2547         * valprint.h (struct value_print_options) <finish_print>: New
2548         member.
2549
2550 2019-05-28  Tom Tromey  <tromey@adacore.com>
2551
2552         * ada-lang.c (ada_remove_Xbn_suffix)
2553         (find_old_style_renaming_symbol)
2554         (parse_old_style_renaming): Remove.
2555         (ada_find_renaming_symbol): Don't call
2556         find_old_style_renaming_symbol.
2557         (ada_is_renaming_symbol): Rename from
2558         ada_find_renaming_symbol.  Remove "block" parameter.  Return
2559         bool.  Now static.
2560         (ada_read_var_value): Update and simplify.
2561         * ada-exp.y (write_var_or_type): Remove old code.
2562
2563 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
2564
2565         * event-top.c: Remove include comment.
2566         * inflow.c (class scoped_ignore_sigttou): Move from here...
2567         * inflow.h (class scoped_ignore_sigttou): ...to here.
2568         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
2569         * top.c:  Remove include comment.
2570
2571 2019-05-27  Tom Tromey  <tom@tromey.com>
2572
2573         * NEWS: Fix typo.
2574
2575 2019-05-22  Tom Tromey  <tromey@adacore.com>
2576
2577         * target.c (target_follow_exec): Constify parameter.
2578         * target-delegates.c: Rebuild.
2579         * remote.c (remote_target::follow_exec): Constify parameter.
2580         * infrun.c (follow_exec): Constify parameter.
2581         * target.h (struct target_ops) <follow_exec>: Constify parameter.
2582         (target_follow_exec): Likewise.
2583
2584 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2585
2586         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
2587         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
2588
2589 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2590
2591         * NEWS: Add debugredirect and testsuite sections.
2592
2593 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
2594
2595         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
2596         target descriptions using exclusively floating point register name
2597         aliases.
2598
2599 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2600
2601         PR gdb/18644:
2602         * f-lang.c (build_fortran_types): Handle the case where
2603         gdbarch_floatformat_for_type returns a nullptr.
2604
2605 2019-05-21  Tom de Vries  <tdevries@suse.de>
2606
2607         PR cli/24587
2608         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
2609
2610 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2611
2612         PR gdb/18644:
2613         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
2614         16-byte floats.
2615         * i386-tdep.c (i386_floatformat_for_type): Use
2616         floatformats_ia64_quad for the 16-byte floating point component
2617         within a fortran 32-byte complex number.
2618
2619 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2620
2621         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
2622         delete default constructor.
2623         (find_partial_die): Update to return const struct.
2624         (partial_die_parent_scope): Move variable declaration into scope
2625         of its use and change its type to auto.
2626         (guess_partial_die_structure_name): Likewise.
2627         (partial_die_info::fixup): Likewise.
2628
2629 2019-05-17  Tom Tromey  <tromey@adacore.com>
2630
2631         * source.c (find_and_open_source): Remove cast.
2632
2633 2019-05-17  Tom Tromey  <tromey@adacore.com>
2634
2635         * annotate.c (annotate_source): Make "filename" const.
2636         * annotate.h (annotate_source): Use const.
2637
2638 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2639
2640         * disasm.c (set_disassembler_options): Send errors to stderr.
2641
2642 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2643
2644         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
2645         (cli_interp_base::set_logging): Check debug_redirect.
2646         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
2647         * cli/cli-logging.c (debug_redirect): Add static variable.
2648         (pop_output_files): Add default param.
2649         (handle_redirections): Print debug setting.
2650         (show_logging_command): Likewise.
2651         (_initialize_cli_logging): Add debugredirect command.
2652         * interps.c (current_interp_set_logging): Add debug_redirect
2653         parameter.
2654         * interps.h (set_logging): Add debug_redirect parameter.
2655         (current_interp_set_logging): Likewise.
2656         * mi/mi-common.h: Likewise.
2657         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
2658
2659 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2660             Tom Tromey  <tromey@adacore.com>
2661
2662         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
2663         directly.
2664         * cli/cli-interp.h (make_logging_output): Remove declaration.
2665         * cli/cli-logging.c (make_logging_output): Remove function.
2666         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
2667         directly.
2668         * ui-file.c (tee_file::tee_file): Remove bools.
2669         (tee_file::~tee_file): Remove deletes.
2670         * ui-file.h (tee_file): Remove bools.
2671
2672 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
2673
2674         * mi/mi-cmds.h (mi_cmd_complete): New function.
2675         * mi/mi-main.c (mi_cmd_complete): Likewise.
2676         * mi/mi-cmds.c: Define new MI command -complete.
2677         * NEWS: Mention new -complete command.
2678
2679 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
2680
2681         * completer.h (complete): New function.
2682         * completer.c (complete): Likewise.
2683         * cli/cli-cmds.c: (complete_command): Update to use new complete()
2684         function defined in completer.h.
2685
2686 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
2687
2688         * MAINTAINERS (Write After Approval): Add myself.
2689
2690 2019-05-17  Tom de Vries  <tdevries@suse.de>
2691
2692         PR gdb/24094
2693         * dwarf2read.c (struct cu_partial_die_info): New struct.
2694         (find_partial_die): Return cu_partial_die_info.
2695         (partial_die_parent_scope, guess_partial_die_structure_name)
2696         (partial_die_info::fixup): Handle new return type of find_partial_die.
2697
2698 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2699
2700         * stap-probe.c (stap_parse_register_operand): Make "regname" an
2701         "std::string", simplifying the algorithm.
2702
2703 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2704
2705         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
2706         (stap_static_probe_ops::get_probes): Likewise.
2707
2708 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2709
2710         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
2711         '-')" and "else if".
2712         (stap_parse_single_operand): Join checks for
2713         "gdbarch_stap_parse_special_token_p" and
2714         "gdbarch_stap_parse_special_token" in the same "if" statement.
2715         Invert check when verifying for operation on register
2716         displacement.
2717
2718 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2719
2720         * stap-probe.c (stap_get_opcode): Update comment.
2721         (stap_get_expected_argument_type): Likewise.
2722         (handle_stap_probe): Likewise.
2723
2724 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2725
2726         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
2727         return type to 'bool'.  Adjust comment.  Use 'bool' when
2728         appropriate.
2729         (i386_stap_parse_special_token_three_arg_disp): Likewise.
2730         * stap-probe.c (stap_parse_argument_1): Likewise.
2731         (stap_is_operator): Likewise.
2732         (stap_is_generic_prefix): Likewise.
2733         (stap_is_register_prefix): Likewise.
2734         (stap_is_register_indirection_prefix): Likewise.
2735         (stap_is_integer_prefix): Likewise.
2736         (stap_generic_check_suffix): Likewise.
2737         (stap_check_integer_suffix): Likewise.
2738         (stap_check_register_suffix): Likewise.
2739         (stap_check_register_indirection_suffix): Likewise.
2740         (stap_parse_register_operand): Likewise.
2741         (stap_parse_single_operand): Likewise.
2742         (stap_parse_argument_1): Likewise.
2743         (stap_probe::get_argument_count): Likewise.
2744         (stap_is_operator): Likewise.
2745
2746 2019-05-16  Tom Tromey  <tromey@adacore.com>
2747
2748         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
2749         keyword to foreach.
2750
2751 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
2752
2753         * linux-thread-db.c (try_thread_db_load_1): Change return type
2754         to bool.
2755         (try_thread_db_load): Likewise.
2756         (try_thread_db_load_from_pdir_1): Likewise.
2757         (try_thread_db_load_from_pdir): Likewise.
2758         (try_thread_db_load_from_sdir): Likewise.
2759         (try_thread_db_load_from_dir): Likewise.
2760         (thread_db_load_search): Likewise.
2761         (has_libpthread): Likewise.
2762         (thread_db_load): Likewise.
2763
2764 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
2765
2766         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2767         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
2768         NULL, and complain/return if that's the case.
2769
2770 2019-05-15  John Darrington <john@darrington.wattle.id.au>
2771
2772         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
2773         (advance, posn, abstract_read_memory): New functions.
2774         [struct mem_read_abstraction]: New struct.
2775         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
2776
2777 2019-05-14  Tom Tromey  <tromey@adacore.com>
2778
2779         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
2780         value is not lval_memory.
2781
2782 2019-05-14  Tom Tromey  <tromey@adacore.com>
2783
2784         * solib.c (info_sharedlibrary_command): Style the file name.
2785
2786 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
2787
2788         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
2789         (aarch64_vnv_type): Likewise.
2790         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
2791         * common/tdesc.c: Likewise.
2792         * common/tdesc.h (enum tdesc_type_kind): Likewise.
2793         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
2794         * features/aarch64-fpu.xml: Add ieee half view.
2795         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
2796         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
2797         * gdbtypes.h (struct builtin_type): Likewise.
2798         (struct objfile_type): Likewise.
2799
2800 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
2801
2802         * language.c (language_sniff_from_mangled_name): Fix "langauge"
2803         typo.
2804         * location.h (string_to_event_location): Likewise.
2805
2806 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
2807
2808         GDB 8.3 released.
2809
2810 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2811
2812         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
2813         New variable declaration.
2814         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
2815         New variable.
2816         (print_one_breakpoint): Use ui_out::test_flags and new global
2817         variable to compute use_fixed_output.
2818         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
2819         Remove.
2820         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
2821         (mi_multi_location_breakpoint_output_fixed): Remove.
2822         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
2823         new variable.
2824         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
2825         fix_multi_location_breakpoint_output flag if version >= 3.
2826         * ui-out.h (enum ui_out_flag)
2827         <fix_multi_location_breakpoint_output>: New enumerator.
2828
2829 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2830
2831         * contrib/cc-with-tweaks.sh: Validate dwz's work.
2832
2833 2019-05-10  Tom Tromey  <tromey@adacore.com>
2834
2835         * ada-lang.c (catch_ada_completer): New function.
2836         (_initialize_ada_language): Use it.
2837
2838 2019-05-10  Tom Tromey  <tromey@adacore.com>
2839
2840         * thread.c (print_thread_info): Make "requested_threads" const.
2841         * gdbthread.h (print_thread_info): Make "requested_threads"
2842         const.
2843         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
2844         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
2845
2846 2019-05-08  Tom Tromey  <tom@tromey.com>
2847
2848         * gdbtypes.c (objfile_type_data): Change type.
2849         (objfile_type, _initialize_gdbtypes): Update.
2850
2851 2019-05-08  Tom Tromey  <tom@tromey.com>
2852
2853         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
2854         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
2855         (_initialize_dwarf2_frame): Update.
2856
2857 2019-05-08  Tom Tromey  <tom@tromey.com>
2858
2859         * objc-lang.c (objc_objfile_data): Change type.
2860         (find_methods): Update.
2861         (_initialize_objc_lang): Remove.
2862
2863 2019-05-08  Tom Tromey  <tom@tromey.com>
2864
2865         * stabsread.c (rs6000_builtin_type_data): Change type.
2866         (rs6000_builtin_type, _initialize_stabsread): Update.
2867
2868 2019-05-08  Tom Tromey  <tom@tromey.com>
2869
2870         * mips-tdep.c (mips_pdr_data): Remove.
2871         (_initialize_mips_tdep): Update.
2872
2873 2019-05-08  Tom Tromey  <tom@tromey.com>
2874
2875         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
2876         (hppa_init_objfile_priv_data, read_unwind_info)
2877         (find_unwind_entry, _initialize_hppa_tdep): Update.
2878
2879 2019-05-08  Tom Tromey  <tom@tromey.com>
2880
2881         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
2882         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
2883         on obstack.
2884         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
2885
2886 2019-05-08  Tom Tromey  <tom@tromey.com>
2887
2888         * mdebugread.c (basic_type_data): Change type.
2889         (basic_type, _initialize_mdebugread): Update.
2890
2891 2019-05-08  Tom Tromey  <tom@tromey.com>
2892
2893         * common/gdb_unique_ptr.h (struct noop_deleter): New.
2894
2895 2019-05-08  Tom Tromey  <tom@tromey.com>
2896
2897         * nto-tdep.c (nto_inferior_data_reg): Change type.
2898         (nto_inferior_data): Update.
2899         (nto_inferior_data_cleanup, nto_new_inferior_data)
2900         (_initialize_nto_tdep): Remove.
2901         * nto-tdep.h (struct nto_inferior_data): Add initializers.
2902
2903 2019-05-08  Tom Tromey  <tom@tromey.com>
2904
2905         * ada-lang.c (struct ada_inferior_data): Add initializers.
2906         (ada_inferior_data): Change type.
2907         (ada_inferior_data_cleanup): Remove.
2908         (get_ada_inferior_data, ada_inferior_exit)
2909         (struct ada_pspace_data): Add initializers, destructor.
2910         (ada_pspace_data_handle): Change type.
2911         (get_ada_pspace_data): Update.
2912         (ada_pspace_data_cleanup): Remove.
2913
2914 2019-05-08  Tom Tromey  <tom@tromey.com>
2915
2916         * coffread.c (struct coff_symfile_info): Add initializers.
2917         (coff_objfile_data_key): Move lower.  Change type.
2918         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
2919         Update.
2920         (coff_free_info): Remove.
2921
2922 2019-05-08  Tom Tromey  <tom@tromey.com>
2923
2924         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
2925         (fbsd_pspace_data_handle): Move lower.  Change type.
2926         (get_fbsd_pspace_data): Update.
2927         (fbsd_pspace_data_cleanup): Remove.
2928         (_initialize_fbsd_tdep): Update.
2929
2930 2019-05-08  Tom Tromey  <tom@tromey.com>
2931
2932         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
2933         (get_ada_tasks_pspace_data): Update.
2934         (ada_tasks_pspace_data_cleanup): Remove.
2935         (_initialize_tasks): Update.
2936         (ada_tasks_inferior_data_handle): Change type.
2937         (get_ada_tasks_inferior_data): Update.
2938         (ada_tasks_inferior_data_cleanup): Remove.
2939         (struct ada_tasks_pspace_data): Add initializers.
2940
2941 2019-05-08  Tom Tromey  <tom@tromey.com>
2942
2943         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
2944         * symfile-debug.c (debug_sym_get_probes): Change type.
2945         * stap-probe.c (handle_stap_probe):
2946         (stap_static_probe_ops::get_probes): Change type.
2947         * probe.h (class static_probe_ops) <get_probes>: Change type.
2948         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
2949         (parse_probes_in_pspace): Update.
2950         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
2951         Update.
2952         (any_static_probe_ops::get_probes): Change type.
2953         * elfread.c (elfread_data): New typedef.
2954         (probe_key): Change type.
2955         (elf_get_probes): Likewise.  Update.
2956         (probe_key_free): Remove.
2957         (_initialize_elfread): Update.
2958         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
2959         Change type.
2960         (dtrace_process_dof_probe, dtrace_process_dof)
2961         (dtrace_static_probe_ops::get_probe): Change type.
2962
2963 2019-05-08  Tom Tromey  <tom@tromey.com>
2964
2965         * xcoffread.c (struct xcoff_symfile_info): Rename from
2966         coff_symfile_info.  Add initializers.
2967         (xcoff_objfile_data_key): Move lower.  Change type.
2968         (XCOFF_DATA): Rewrite.
2969         (xcoff_free_info): Remove.
2970         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
2971         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
2972         (xcoff_initial_scan): Update.
2973
2974 2019-05-08  Tom Tromey  <tom@tromey.com>
2975
2976         * solib-svr4.c (struct svr4_info): Add initializers and
2977         destructor.
2978         <probes_table>: Now an htab_up.
2979         (solib_svr4_pspace_data): Change type.
2980         (free_probes_table): Simplify.
2981         (~svr4_info): Rename from svr4_pspace_data_cleanup.
2982         (get_svr4_info, probes_table_htab_remove_objfile_probes)
2983         (probes_table_remove_objfile_probes, register_solib_event_probe)
2984         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
2985         (_initialize_svr4_solib): Update.
2986
2987 2019-05-08  Tom Tromey  <tom@tromey.com>
2988
2989         * remote.c (remote_pspace_data): Change type.
2990         (remote_pspace_data_cleanup): Remove.
2991         (get_remote_exec_file, set_pspace_remote_exec_file)
2992         (_initialize_remote): Update.
2993
2994 2019-05-08  Tom Tromey  <tom@tromey.com>
2995
2996         * breakpoint.c (breakpoint_objfile_key): Change type.
2997         (get_breakpoint_objfile_data): Update.
2998         (free_breakpoint_objfile_data): Remove.
2999         (_initialize_breakpoint): Update.
3000
3001 2019-05-08  Tom Tromey  <tom@tromey.com>
3002
3003         * linux-tdep.c (struct linux_info): Add initializers.
3004         (linux_inferior_data): Move.  Change type.
3005         (invalidate_linux_cache_inf): Update.
3006         (linux_inferior_data_cleanup): Remove.
3007         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3008
3009 2019-05-08  Tom Tromey  <tom@tromey.com>
3010
3011         * auxv.c (auxv_inferior_data): Move.  Change type.
3012         (auxv_inferior_data_cleanup): Remove.
3013         (invalidate_auxv_cache_inf): Rewrite.
3014         (get_auxv_inferior_data, _initialize_auxv): Update.
3015
3016 2019-05-08  Tom Tromey  <tom@tromey.com>
3017
3018         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3019         (symfile_debug_objfile_data_key): Change type.
3020         (symfile_debug_installed, debug_qf_has_symbols)
3021         (debug_qf_find_last_source_symtab)
3022         (debug_qf_forget_cached_source_info)
3023         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3024         (debug_qf_print_stats, debug_qf_dump)
3025         (debug_qf_expand_symtabs_for_function)
3026         (debug_qf_expand_all_symtabs)
3027         (debug_qf_expand_symtabs_with_fullname)
3028         (debug_qf_map_matching_symbols)
3029         (debug_qf_expand_symtabs_matching)
3030         (debug_qf_find_pc_sect_compunit_symtab)
3031         (debug_qf_map_symbol_filenames)
3032         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3033         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3034         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3035         (debug_sym_read_linetable, debug_sym_relocate): Update.
3036         (symfile_debug_free_objfile): Remove.
3037         (install_symfile_debug_logging, _initialize_symfile_debug):
3038         Update.
3039
3040 2019-05-08  Tom Tromey  <tom@tromey.com>
3041
3042         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3043         allocate_on_obstack.
3044         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3045         (get_dwarf2_per_objfile): Update.
3046         (set_dwarf2_per_objfile): Remove.
3047         (dwarf2_has_info, dwarf2_get_section_info): Update.
3048         (dwarf2_free_objfile): Remove.
3049         (_initialize_dwarf2_read): Update.
3050
3051 2019-05-08  Tom Tromey  <tom@tromey.com>
3052
3053         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3054         initializers.
3055         <unsupported_script_warning_printed,
3056         script_not_found_warning_printed>: Now bool.
3057         (auto_load_pspace_data): Change type.
3058         (~auto_load_pspace_info): Rename from
3059         auto_load_pspace_data_cleanup.
3060         (get_auto_load_pspace_data, init_loaded_scripts_info)
3061         (clear_section_scripts, maybe_print_unsupported_script_warning)
3062         (maybe_print_script_not_found_warning, _initialize_auto_load):
3063         Update.
3064
3065 2019-05-08  Tom Tromey  <tom@tromey.com>
3066
3067         * objfiles.c (objfile_pspace_info): Add destructor and
3068         initializers.
3069         (objfiles_pspace_data): Change type.
3070         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3071         (get_objfile_pspace_data): Update.
3072         (objfiles_bfd_data): Change type.
3073         (get_objfile_bfd_data): Update.
3074         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3075
3076 2019-05-08  Tom Tromey  <tom@tromey.com>
3077
3078         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3079         Change type.
3080         (get_catch_syscall_inferior_data): Update.
3081         (catch_syscall_inferior_data_cleanup): Remove.
3082         (_initialize_break_catch_syscall): Update.
3083
3084 2019-05-08  Tom Tromey  <tom@tromey.com>
3085
3086         * inflow.c (struct terminal_info): Add destructor and
3087         initializers.
3088         (inflow_inferior_data): Change type.
3089         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3090         (get_inflow_inferior_data, inflow_inferior_exit)
3091         (swap_terminal_info, _initialize_inflow): Update.
3092
3093 2019-05-08  Tom Tromey  <tom@tromey.com>
3094
3095         * target-dcache.c (target_dcache_cleanup): Remove.
3096         (target_dcache_aspace_key): Change type.
3097         (target_dcache_init_p, target_dcache_invalidate)
3098         (target_dcache_get, target_dcache_get_or_init)
3099         (_initialize_target_dcache): Update.
3100         * dcache.h (struct dcache_deleter): New.
3101
3102 2019-05-08  Tom Tromey  <tom@tromey.com>
3103
3104         * symtab.c (struct symbol_cache): Add destructor and
3105         initializers.
3106         (symbol_cache_key): Move.  Change type.
3107         (make_symbol_cache, free_symbol_cache): Remove.
3108         (get_symbol_cache): Update.
3109         (symbol_cache_cleanup): Remove.
3110         (ALL_PSPACES, symbol_cache_flush)
3111         (maintenance_print_symbol_cache)
3112         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3113         Update.
3114
3115 2019-05-08  Tom Tromey  <tom@tromey.com>
3116
3117         * symtab.c (struct main_info): Add destructor and initializers.
3118         (main_progspace_key): Move.  Change type.
3119         (get_main_info): Update.
3120         (main_info_cleanup): Remove.
3121         (_initialize_symtab): Update.
3122
3123 2019-05-08  Tom Tromey  <tom@tromey.com>
3124
3125         * registry.h (DECLARE_REGISTRY): Define the _key class.
3126
3127 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3128
3129         * NEWS: Merge two 'New commands' sections.
3130
3131 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3132
3133         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3134         parameter and use Ada language definition instead.
3135         (ada_val_print_ptr): Remove unused language parameter.
3136         (ada_val_print_num): Remove language parameter and use Ada language
3137         definition instead.
3138         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3139         parameter.
3140         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3141         parameter and use Ada language definition instead.
3142         (ada_val_print_1): Update all ada_val_print_xxx calls.
3143         Remove language parameter.
3144         (ada_val_print): Update ada_val_print_1 call.
3145
3146 2019-05-08  Tom Tromey  <tromey@adacore.com>
3147
3148         * remote.c (remote_hw_watchpoint_limit)
3149         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3150         Now static.
3151
3152 2019-05-08  Tom Tromey  <tromey@adacore.com>
3153
3154         * maint.c (_initialize_maint_cmds): Move initialization code to
3155         remote.c.
3156         (watchdog, show_watchdog): Move to remote.c.
3157         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3158         "watchdog" static.
3159         (_initialize_remote): Move initialization code from maint.c.
3160         * defs.h (watchdog): Don't declare.
3161
3162 2019-05-08  Tom Tromey  <tromey@adacore.com>
3163
3164         * tui/tui-interp.c: Include main.h.
3165         * interps.c: Include main.h.
3166         * main.h (interpreter_p): Declare.
3167         * defs.h (interpreter_p): Don't declare.
3168
3169 2019-05-08  Tom Tromey  <tromey@adacore.com>
3170
3171         * dwarf2loc.c: Include dwarf2read.h.
3172         * defs.h (read_unsigned_leb128): Don't declare.
3173         * dwarf2read.h (read_unsigned_leb128): Declare.
3174
3175 2019-05-08  Tom Tromey  <tromey@adacore.com>
3176
3177         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3178         method.
3179
3180 2019-05-08  Tom Tromey  <tromey@adacore.com>
3181
3182         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3183         when no wrap column is set.
3184
3185 2019-05-08  Tom Tromey  <tromey@adacore.com>
3186
3187         * c-lang.c (c_get_string): Handle non-C-style arrays.
3188
3189 2019-05-08  Tom Tromey  <tromey@adacore.com>
3190
3191         * typeprint.c (print_offset_data::update): Print the bit offset,
3192         not the number of bits remaining.
3193
3194 2019-05-08  Tom Tromey  <tromey@adacore.com>
3195
3196         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3197         padding at end of comment.
3198
3199 2019-05-08  Tom Tromey  <tromey@adacore.com>
3200
3201         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3202         Compare main types.
3203
3204 2019-05-06  Tom Tromey  <tom@tromey.com>
3205
3206         * common/scoped_mmap.c: Include common-defs.h.
3207         * common/scoped_mmap.h: Don't include config.h.
3208
3209 2019-05-04  Tom Tromey  <tom@tromey.com>
3210
3211         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3212         (struct aarch64_call_info): Add initializers.
3213         <si>: Now a std::vector.
3214         (pass_on_stack, aarch64_push_dummy_call): Update.
3215
3216 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3217             Tom Tromey  <tom@tromey.com>
3218
3219         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3220         (ppc_threads): Now a std::vector.  Now static.
3221         (hwdebug_find_thread_points_by_tid)
3222         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3223         Update.
3224
3225 2019-05-04  Tom Tromey  <tom@tromey.com>
3226
3227         * arc-tdep.c (arc_tdesc_init): Return bool.
3228
3229 2019-05-04  Tom Tromey  <tom@tromey.com>
3230
3231         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3232         Use gdb_assert_not_reached.
3233
3234 2019-05-04  Tom Tromey  <tom@tromey.com>
3235
3236         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3237         "false".
3238
3239 2019-05-04  Tom Tromey  <tom@tromey.com>
3240
3241         * arc-tdep.c (arc_tdesc_init): Use bool.
3242
3243 2019-05-04  Tom Tromey  <tom@tromey.com>
3244
3245         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3246
3247 2019-05-04  Tom Tromey  <tom@tromey.com>
3248
3249         * cli/cli-cmds.c (valid_command_p): Return bool.
3250
3251 2019-05-04  Tom Tromey  <tom@tromey.com>
3252
3253         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3254         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3255
3256 2019-05-04  Raul Tambre  <raul@tambre.ee>
3257
3258         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3259         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3260         operator for comparison.
3261
3262 2019-05-04  Tom Tromey  <tom@tromey.com>
3263
3264         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3265         (lookup_partial_symbol, print_partial_symbols)
3266         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3267         (psymbol_compare): Update.
3268         (add_psymbol_to_bcache): Clear the entire psymbol.
3269         (maintenance_check_psymtabs): Update.
3270         * psympriv.h (struct partial_symbol): Don't derive from
3271         general_symbol_info.
3272         <obj_section, unrelocated_address, address,
3273         set_unrelocated_address>: Update.
3274         <ginfo>: New member.
3275         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3276         (debug_names::write_psymbols): Update.
3277
3278 2019-05-04  Tom de Vries  <tdevries@suse.de>
3279
3280         * contrib/cc-with-tweaks.sh: Support -n arg.
3281
3282 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3283
3284         * corelow.c (core_target::detach): Ensure frame cache and
3285         register caches are cleared.
3286         inferior.c (exit_inferior_1): Likewise.
3287
3288 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
3289             Tom Tromey  <tom@tromey.com>
3290
3291         * dictionary.c (collate_pending_symbols_by_language): Remove
3292         "struct" from foreach.
3293         * symtab.c (lookup_global_symbol_from_objfile)
3294         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
3295         foreach.
3296         * ser-tcp.c (net_open): Remove "struct" from foreach.
3297         * objfiles.c (objfile_relocate, objfile_rebase)
3298         (objfile_has_symbols): Remove "struct" from foreach.
3299         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
3300         from foreach.
3301         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
3302         foreach.
3303         * darwin-nat.c (thread_info_from_private_thread_info): Remove
3304         "struct" from foreach.
3305         * ada-lang.c (create_excep_cond_exprs)
3306         (ada_exception_catchpoint_cond_string): Remove "struct" from
3307         foreach.
3308
3309 2019-05-03  Tom Tromey  <tromey@adacore.com>
3310
3311         * ada-exp.y (convert_char_literal): Check suffix of each
3312         enumerator.
3313
3314 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
3315
3316         PR ada/21406:
3317         * ada-exp.y (yywrap): Don't define.
3318         * ada-lex.l (%option): Add noyywrap
3319         (yywrap): Remove.
3320
3321 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
3322
3323         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
3324         _WIN32_WINNT to the XP level, unless already defined to a higher
3325         level.
3326
3327         * unittests/parse-connection-spec-selftests.c:
3328         * ser-tcp.c:
3329         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
3330         override.
3331
3332         * symfile.c (find_separate_debug_file): Remove colon from the
3333         drive spec of DOS/Windows file names of the target, so that the
3334         file name produced from DEBUGDIR and the target's directory will
3335         be valid on DOS/Windows systems.
3336
3337 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3338
3339         * rust-lang.c (val_print_struct): Handle printing structures
3340         containing strings.
3341
3342 2019-05-02  Tom Tromey  <tromey@adacore.com>
3343
3344         * valarith.c (_initialize_valarith): Remove.
3345
3346 2019-05-01  Tom Tromey  <tromey@adacore.com>
3347
3348         * ada-lang.c (ada_value_primitive_field): Treat more fields as
3349         bitfields.
3350
3351 2019-05-01  Tom Tromey  <tromey@adacore.com>
3352
3353         * ada-lang.c (ada_value_assign): Correctly compute starting offset
3354         for big-endian copies.
3355
3356 2019-04-30  Ali Tamur  <tamur@google.com>
3357         * gdb/dwarf2read.c (read_3_bytes): New declaration.
3358         (read_attribute_value): Added DW_FORM_strx1-4 cases.
3359         (read_3_bytes): New function.
3360
3361 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3362
3363         * windows-nat.c (main_thread_id): Delete.
3364         (handle_output_debug_string): Replace main_thread_id by
3365         current_event.dwThreadId.
3366         (fake_create_process): Likewise.
3367         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
3368         Do not set main_thread_id.
3369         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
3370         current_event.dwThreadId.
3371         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
3372
3373 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3374
3375         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
3376         Use current_event.dwThreadId instead of main_thread_id.
3377
3378 2019-04-30  Tom Tromey  <tromey@adacore.com>
3379
3380         * ada-lang.c (ada_lookup_simple_minsyms): New function.
3381         (create_excep_cond_exprs): Iterate over program spaces.
3382         (ada_exception_catchpoint_cond_string): Examine all minimal
3383         symbols for exception types.
3384
3385 2019-04-30  Tom Tromey  <tromey@adacore.com>
3386
3387         PR c++/24470:
3388         * dwarf2read.c (process_structure_scope): Handle case where type
3389         has template parameters but no symbol was created.
3390
3391 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3392             Chris January  <chris.january@arm.com>
3393
3394         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
3395         qualifier.
3396         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
3397
3398 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3399
3400         * f-typeprint.c (f_print_type): Update rules for printing
3401         whitespace.
3402         (f_type_print_varspec_suffix): Likewise.
3403
3404 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3405             Chris January  <chris.january@arm.com>
3406
3407         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
3408         function arguments.
3409
3410 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3411
3412         * f-lang.c (build_fortran_types): Change name of void type to
3413         lower case.
3414         * f-typeprint.c (f_type_print_base): Print the name of the void
3415         type, rather than a fixed string.
3416         * f-valprint.c (f_decorations): Use lower case void string.
3417
3418 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3419             Chris January  <chris.january@arm.com>
3420
3421         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
3422         types for Fortran.
3423
3424 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3425             Chris January  <chris.january@arm.com>
3426             David Lecomber  <david.lecomber@arm.com>
3427
3428         * f-exp.y (BINOP_INTRINSIC): New token.
3429         (exp): New parser rule handling BINOP_INTRINSIC.
3430         (f77_keywords): Add new builtin procedures.
3431         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
3432         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3433         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
3434         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3435         (print_unop_subexp_f): New function.
3436         (print_binop_subexp_f): New function.
3437         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3438         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3439         (dump_subexp_body_f): Likewise.
3440         (operator_check_f): Likewise.
3441         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3442         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
3443
3444 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3445
3446         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
3447         UNOP_KIND.
3448         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
3449         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
3450         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
3451         (operator_length_f): New fuction.
3452         (print_subexp_f): New function.
3453         (op_name_f): New function.
3454         (dump_subexp_body_f): New function.
3455         (operator_check_f): New function.
3456         (exp_descriptor_f): Replace standard expression handling functions
3457         with new functions.
3458         * gdb/fortran-operator.def: New file.
3459         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
3460         * gdb/std-operator.def: Remove UNOP_KIND.
3461
3462 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3463
3464         * std-operator.def: Remove unbalanced, stray double quote
3465         character.
3466
3467 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3468             Chris January  <chris.january@arm.com>
3469             Daniel Everett  <daniel.everett@arm.com>
3470             Nick Forrington  <nick.forrington@arm.com>
3471             Richard Bunt  <richard.bunt@arm.com>
3472
3473         * cp-valprint.c (cp_print_value_fields): Allow an additional level
3474         of depth when printing anonymous structs or unions.
3475         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
3476         Don't print either the top-level value, or the children if the
3477         max-depth is exceeded.
3478         (ppscm_print_children): When printing the key of a map, allow one
3479         extra level of depth.
3480         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
3481         print either the top-level value, or the children if the max-depth
3482         is exceeded.
3483         (print_children): When printing the key of a map, allow one extra
3484         level of depth.
3485         * python/py-value.c (valpy_format_string): Add max_depth keyword.
3486         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
3487         (user_print_options): Initialise max_depth field.
3488         (val_print_scalar_or_string_type_p): New function.
3489         (val_print): Check to see if the max depth has been reached.
3490         (val_print_check_max_depth): Define new function.
3491         (show_print_max_depth): New function.
3492         (_initialize_valprint): Add 'print max-depth' option.
3493         * valprint.h (struct value_print_options) <max_depth>: New field.
3494         (val_print_check_max_depth): Declare new function.
3495         * NEWS: Document new feature.
3496
3497 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3498
3499         * ada-lang.c (ada_language_defn): Initialise new field.
3500         * c-lang.c (c_is_string_type_p): New function.
3501         (c_language_defn): Initialise new field.
3502         (cplus_language_defn): Initialise new field.
3503         (asm_language_defn): Initialise new field.
3504         (minimal_language_defn): Initialise new field.
3505         * c-lang.h (c_is_string_type_p): Declare new function.
3506         * d-lang.c (d_language_defn): Initialise new field.
3507         * f-lang.c (f_is_string_type_p): New function.
3508         (f_language_defn): Initialise new field.
3509         * go-lang.c (go_is_string_type_p): New function.
3510         (go_language_defn): Initialise new field.
3511         * language.c (default_is_string_type_p): New function.
3512         (unknown_language_defn): Initialise new field.
3513         (auto_language_defn): Initialise new field.
3514         * language.h (struct language_defn) <la_is_string_type_p>: New
3515         member variable.
3516         (default_is_string_type_p): Declare new function.
3517         * m2-lang.c (m2_language_defn): Initialise new field.
3518         * objc-lang.c (objc_language_defn): Initialise new field.
3519         * opencl-lang.c (opencl_language_defn): Initialise new field.
3520         * p-lang.c (pascal_is_string_type_p): New function.
3521         (pascal_language_defn): Initialise new field.
3522         * rust-lang.c (rust_is_string_type_p): New function.
3523         (rust_language_defn): Initialise new field.
3524
3525 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3526
3527         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
3528         New field.
3529         * ada-lang.c (ada_language_defn): Initialise new field.
3530         * c-lang.c (c_language_defn): Likewise.
3531         (cplus_language_defn): Likewise.
3532         (asm_language_defn): Likewise.
3533         (minimal_language_defn): Likewise.
3534         * d-lang.c (d_language_defn): Likewise.
3535         * f-lang.c (f_language_defn): Likewise.
3536         * go-lang.c (go_language_defn): Likewise.
3537         * language.c (unknown_language_defn): Likewise.
3538         (auto_language_defn): Likewise.
3539         * m2-lang.c (m2_language_defn): Likewise.
3540         * objc-lang.c (objc_language_defn): Likewise.
3541         * opencl-lang.c (opencl_language_defn): Likewise.
3542         * p-lang.c (pascal_language_defn): Likewise.
3543         * rust-lang.c (rust_language_defn): Likewise.
3544
3545 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3546
3547         * ada-lang.c (ada_is_character_type): Change return type to bool.
3548         (ada_is_string_type): Likewise.
3549         * ada-lang.h (ada_is_character_type): Update declaration
3550         (ada_is_string_type): Likewise.
3551
3552 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3553
3554         Support style in 'frame|thread apply'
3555
3556         * gdbcmd.h (execute_command_to_string): New term_out parameter.
3557         * record.c (record_start, record_stop): Update callers of
3558         execute_command_to_string with false.
3559         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
3560         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
3561         methods.
3562         (class string_file): New constructor with term_out parameter.
3563         Override methods term_out and can_emit_style_escape.  New member
3564         term_out.
3565         (class stdio_file): Override can_emit_style_escape.
3566         (class tee_file): Override term_out and can_emit_style_escape.
3567         * utils.h (can_emit_style_escape): Remove.
3568         * utils.c (can_emit_style_escape): Likewise.
3569         Update all callers of can_emit_style_escape (SOMESTREAM) to
3570         SOMESTREAM->can_emit_style_escape.
3571         * source-cache.c (source_cache::get_source_lines): Likewise.
3572         * stack.c (frame_apply_command_count): Call execute_command_to_string
3573         passing the term_out characteristic of the current gdb_stdout.
3574         * thread.c (thr_try_catch_cmd): Likewise.
3575         * top.c (execute_command_to_string): pass term_out parameter
3576         to construct the string_file for the command output.
3577         * ui-file.c (term_cli_styling): New function (most code moved
3578         from utils.c can_emit_style_escape).
3579         (string_file::string_file, string_file::can_emit_style_escape,
3580         stdio_file::can_emit_style_escape, tee_file::term_out,
3581         tee_file::can_emit_style_escape): New functions.
3582
3583 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3584
3585         * NEWS: Mention the new set|show may-call-functions.
3586         * infcall.c (may_call_functions_p): New variable.
3587         (show_may_call_functions_p): New function.
3588         (call_function_by_hand_dummy): Throws an error if not
3589         may-call-functions.
3590         (_initialize_infcall): Call add_setshow_boolean_cmd for
3591         may-call-functions.
3592
3593 2019-04-25  Keith Seitz  <keiths@redhat.com>
3594
3595         PR c++/24367
3596         * cp-support.c (inspect_type): Don't attempt substitutions
3597         of symbol with the same name.
3598
3599 2019-04-25  Tom Tromey  <tromey@adacore.com>
3600
3601         PR gdb/24475:
3602         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
3603         static.
3604
3605 2019-04-25  Tom Tromey  <tromey@adacore.com>
3606
3607         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
3608         rvalue reference.
3609         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
3610         (gdb_xml_parser::parse): Use std::move.
3611         * python/python-internal.h (gdbpy_convert_exception): Take a const
3612         reference.
3613         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
3614         std::move.
3615         * python/py-utils.c (gdbpy_convert_exception): Take a const
3616         reference.
3617         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3618         Use std::move.
3619         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3620         Use std::move.
3621         * mi/mi-main.c (mi_print_exception): Take a const reference.
3622         * main.c (handle_command_errors): Take a const reference.
3623         * linespec.c (parse_linespec): Use std::move.
3624         * infcall.c (run_inferior_call): Use std::move.
3625         (call_function_by_hand_dummy): Use std::move.
3626         * exec.c (try_open_exec_file): Use std::move.
3627         * exceptions.h (exception_print, exception_fprintf)
3628         (exception_print_same): Update.
3629         * exceptions.c (print_exception, exception_print)
3630         (exception_fprintf, exception_print_same): Change parameters to
3631         const reference.
3632         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
3633         * common/new-op.c: Use std::move.
3634         * common/common-exceptions.h (struct gdb_exception): Add move
3635         constructor.
3636         (struct gdb_exception_error, struct gdb_exception_quit, struct
3637         gdb_quit_bad_alloc): Change constructor to move constructor.
3638         (throw_exception): Change parameter to rvalue reference.
3639         * common/common-exceptions.c (throw_exception): Take rvalue
3640         reference.
3641         * cli/cli-interp.c (safe_execute_command): Use std::move.
3642         * breakpoint.c (insert_bp_location, location_to_sals): Use
3643         std::move.
3644
3645 2019-04-25  Tom Tromey  <tromey@adacore.com>
3646
3647         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
3648         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
3649         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
3650         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
3651         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
3652         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
3653         guile/scm-value.c: Use unpack.
3654         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
3655         gdbscm_gdb_exception.
3656         (gdbscm_throw_gdb_exception): Likewise.
3657         (struct gdbscm_gdb_exception): New.
3658         (unpack): New function.
3659         (gdbscm_wrap): Use unpack.
3660
3661 2019-04-25  Tom Tromey  <tromey@adacore.com>
3662
3663         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3664         (gdb_rl_callback_handler): Use std::move.
3665         * common/common-exceptions.h (struct gdb_exception): Add move
3666         assignment operator.
3667         (throw_exception_sjlj): Change "exception" to const reference.
3668         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
3669         (throw_exception_sjlj): Change "exception" to const reference.
3670
3671 2019-04-25  Tom Tromey  <tromey@adacore.com>
3672
3673         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
3674         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
3675         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3676         Update.
3677         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3678         Update.
3679         * mi/mi-interp.c (mi_interp::exec): Update.
3680         * linespec.c (parse_linespec): Update.
3681         * infcall.c (run_inferior_call): Update.
3682         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
3683         * guile/scm-symbol.c (gdbscm_lookup_symbol)
3684         (gdbscm_lookup_global_symbol): Update.
3685         * guile/scm-param.c (gdbscm_parameter_value): Update.
3686         * guile/scm-frame.c (gdbscm_frame_read_register)
3687         (gdbscm_frame_read_var): Update.
3688         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
3689         * exec.c (try_open_exec_file): Update.
3690         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3691         (gdb_rl_callback_handler): Update.
3692         * common/common-exceptions.h (exception_none): Don't declare.
3693         * common/common-exceptions.c (exception_none): Don't define.
3694         (struct catcher) <exception>: Update.
3695         * cli/cli-interp.c (safe_execute_command): Update.
3696         * breakpoint.c (insert_bp_location, location_to_sals): Update.
3697
3698 2019-04-25  Ali Tamur  <tamur@google.com>
3699
3700         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
3701         (read_attribute_value): Likewise.
3702         (dwarf2_read_addr_index): Update comment.
3703         (read_str_index): Add DW_FORM_strx.
3704         (dwarf2_string_attr): Likewise.
3705         (dwarf2_const_value_attr): Likewise.
3706         (dump_die_shallow): Likewise.
3707         (dwarf2_fetch_constant_bytes): Likewise.
3708         (skip_form_bytes): Likewise.
3709         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
3710
3711 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
3712
3713         PR corefiles/11608
3714         PR corefiles/18187
3715         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
3716         OFFSET.  Verify if current mapping contains an ELF header.
3717         (linux_find_memory_regions_full): Adjust call to
3718         dump_mapping_p.
3719
3720 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
3721             Kang Li <kanglictf@gmail.com>
3722
3723         PR gdb/21600
3724
3725         * dwarf2-frame.c (read_initial_length): Be consistent about using
3726         unsigned representation of length.
3727         (decode_frame_entry_1): Likewise.  Check for wraparound of
3728         end pointer as well as buffer overflow.
3729
3730 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
3731
3732         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
3733         "vq".
3734
3735 2019-04-24  Tom Tromey  <tromey@adacore.com>
3736
3737         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
3738
3739 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3740
3741         * s12z-tdep.c (s12z_unwind_pc): Delete.
3742         (s12z_unwind_sp): Delete.
3743         (s12z_gdbarch_init): Don't register deleted functions with
3744         gdbarch.
3745
3746 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3747
3748         * rl78-tdep.c (rl78_unwind_sp): Delete.
3749         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
3750
3751 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3752
3753         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
3754         (xstormy16_unwind_pc): Delete.
3755         (xstormy16_dummy_id): Delete.
3756         (xstormy16_gdbarch_init): Don't register deleted functions with
3757         gdbarch.
3758
3759 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3760
3761         * vax-tdep.c (vax_unwind_pc): Delete.
3762         (vax_gdbarch_init): Don't register deleted function with gdbarch.
3763
3764 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3765
3766         * v850-tdep.c (v850_unwind_sp): Delete.
3767         (v850_unwind_pc): Delete.
3768         (v850_dummy_id): Delete.
3769         (v850_gdbarch_init): Don't register deleted functions with
3770         gdbarch.
3771
3772 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3773
3774         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
3775         (tilegx_unwind_pc): Delete.
3776         (tilegx_unwind_dummy_id): Delete.
3777         (tilegx_gdbarch_init): Don't register deleted functions with
3778         gdbarch.
3779
3780 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3781
3782         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
3783         (tic6x_dummy_id): Delete.
3784         (tic6x_gdbarch_init): Don't register deleted functions with
3785         gdbarch.
3786
3787 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3788
3789         * sparc-tdep.c (sparc_unwind_pc): Delete.
3790         (sparc32_gdbarch_init): Don't register deleted function with
3791         gdbarch.
3792
3793 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3794
3795         * sh-tdep.c (sh_unwind_sp): Delete.
3796         (sh_unwind_pc): Delete.
3797         (sh_dummy_id): Delete.
3798         (sh_gdbarch_init): Don't register deleted functions with
3799         gdbarch.
3800
3801 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3802
3803         * score-tdep.c (score_unwind_sp): Delete.
3804         (score_unwind_pc): Delete.
3805         (score_dummy_id): Delete.
3806         (score_gdbarch_init): Don't register deleted functions with
3807         gdbarch.
3808
3809 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3810
3811         * rx-tdep.c (rx_unwind_pc): Delete.
3812         (rx_unwind_sp): Delete.
3813         (rx_dummy_id): Delete.
3814         (rx_gdbarch_init): Don't register deleted functions with
3815         gdbarch.  Update comment.
3816
3817 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3818
3819         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
3820         (rs6000_dummy_id): Delete.
3821         (rs6000_gdbarch_init): Don't register deleted functions with
3822         gdbarch.
3823
3824 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3825
3826         * or1k-tdep.c (or1k_dummy_id): Delete.
3827         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
3828
3829 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3830
3831         * nios2-tdep.c (nios2_dummy_id): Delete.
3832         (nios2_unwind_sp): Delete.
3833         (nios2_gdbarch_init): Don't register deleted functions with
3834         gdbarch.
3835
3836 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3837
3838         * nds32-tdep.c (nds32_dummy_id): Delete.
3839         (nds32_unwind_pc): Delete.
3840         (nds32_unwind_sp): Delete.
3841         (nds32_gdbarch_init): Don't register deleted functions with
3842         gdbarch.
3843
3844 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3845
3846         * msp430-tdep.c (msp430_unwind_pc): Delete.
3847         (msp430_unwind_sp): Delete.
3848         (msp430_dummy_id): Delete.
3849         (msp430_gdbarch_init): Don't register deleted functions with
3850         gdbarch.
3851
3852 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3853
3854         * moxie-tdep.c (moxie_unwind_sp): Delete.
3855         (moxie_unwind_pc): Delete.
3856         (moxie_dummy_id): Delete.
3857         (moxie_gdbarch_init): Don't register deleted functions with
3858         gdbarch.
3859
3860 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3861
3862         * mn10300-tdep.c (mn10300_dummy_id): Delete.
3863         (mn10300_unwind_pc): Delete.
3864         (mn10300_unwind_sp): Delete.
3865         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
3866         mn10300_unwind_sp.
3867         (mn10300_frame_unwind_init): Don't register deleted functions with
3868         gdbarch.
3869
3870 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3871
3872         * mep-tdep.c (mep_unwind_pc): Delete.
3873         (mep_unwind_sp): Delete.
3874         (mep_dummy_id): Delete.
3875         (mep_gdbarch_init): Don't register deleted functions with
3876         gdbarch.
3877
3878 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3879
3880         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
3881         (m68hc11_unwind_sp): Delete.
3882         (m68hc11_gdbarch_init): Don't register deleted functions with
3883         gdbarch.
3884
3885 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3886
3887         * m32r-tdep.c (m32r_unwind_sp): Delete.
3888         (m32r_unwind_pc): Delete.
3889         (m32r_dummy_id): Delete.
3890         (m32r_gdbarch_init): Don't register deleted functions with
3891         gdbarch.
3892
3893 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3894
3895         * m32c-tdep.c (m32c_unwind_pc): Delete.
3896         (m32c_unwind_sp): Delete.
3897         (m32c_dummy_id): Delete.
3898         (m32c_gdbarch_init): Don't register deleted functions with
3899         gdbarch.
3900
3901 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3902
3903         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
3904         (lm32_unwind_pc): Delete.
3905         (lm32_dummy_id): Delete.
3906         (lm32_gdbarch_init): Don't register deleted functions with
3907         gdbarch.
3908
3909 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3910
3911         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
3912         (iq2000_unwind_pc): Delete.
3913         (iq2000_dummy_id): Delete.
3914         (iq2000_gdbarch_init): Don't register deleted functions with
3915         gdbarch.
3916
3917 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3918
3919         * nds32-tdep.c (nds32_type_align): Delete.
3920         (nds32_push_dummy_call): Use type_align instead.
3921
3922 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3923
3924         * arm-tdep.c (arm_type_align): Only handle vector override case.
3925         (arm_push_dummy_call): Use type_align.
3926         (arm_gdbarch_init): Register arm_type_align gdbarch function.
3927
3928 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3929
3930         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
3931         case.
3932         (pass_on_stack): Use type_align.
3933         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
3934         function.
3935
3936 2019-04-23  Tom Tromey  <tromey@adacore.com>
3937
3938         * dwarf2read.c (line_header::file_name_at): Remove unused
3939         overload.
3940
3941 2019-04-23  Tom de Vries  <tdevries@suse.de>
3942
3943         PR gdb/24438
3944         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
3945         invocation.
3946
3947
3948 2019-03-27  Ali Tamur  <tamur@google.com>
3949
3950         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
3951         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
3952         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
3953         (dwarf_expr_context::get_addr_index): Likewise
3954         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
3955         (symbol_needs_eval_context::get_addr_index): Likewise
3956         (disassemble_dwarf_expression): Add DW_OP_addrx
3957         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
3958         (read_cutu_die_from_dwo): Update comment
3959         (skip_one_die): Add DW_FORM_addrx
3960         (read_attribute_value): Likewise
3961         (var_decode_location): Add DW_OP_addrx
3962         (dwarf2_const_value_attr): Add DW_FORM_addrx
3963         (dump_die_shallow): Likewise
3964         (dwarf2_fetch_constant_bytes): Likewise
3965         (decode_locdesc): Add DW_OP_addrx
3966         (skip_form_bytes): Add DW_FORM_addrx
3967
3968 2019-04-22  Ali Tamur  <tamur@google.com>
3969
3970         * MAINTAINERS (Write After Approval): Add self.
3971
3972 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
3973
3974         * solib-svr4.c (get_svr4_info): Add pspace parameter.
3975         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
3976         (open_symbol_file_object): Likewise.
3977         (svr4_default_sos): Add info parameter.
3978         (svr4_read_so_list): Likewise.
3979         (svr4_current_sos_direct): Adjust functions calls to pass down
3980         info.
3981         (svr4_current_sos_1): Add info parameter.
3982         (svr4_current_sos): Call get_svr4_info, pass info down to
3983         svr4_current_sos_1.
3984         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
3985         get_svr4_info.
3986         (svr4_in_dynsym_resolve_code): Pass current_program_space to
3987         get_svr4_info.
3988         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
3989         to get_svr4_info.
3990         (probes_table_remove_objfile_probes): Likewise.
3991         (register_solib_event_probe): Add info parameter.
3992         (solist_update_incremental): Pass info parameter down to
3993         svr4_read_so_list.
3994         (disable_probes_interface): Add info parameter.
3995         (svr4_handle_solib_event): Pass current_program_space to
3996         get_svr4_info.  Adjust disable_probes_interface cleanup.
3997         (svr4_create_probe_breakpoints): Add info parameter, pass it
3998         down to register_solib_event_probe.
3999         (svr4_create_solib_event_breakpoints): Add info parameter,
4000         pass it down to svr4_create_probe_breakpoints.
4001         (enable_break): Pass info down to
4002         svr4_create_solib_event_breakpoints.
4003         (svr4_solib_create_inferior_hook): Pass current_program_space to
4004         get_svr4_info.
4005         (svr4_clear_solib): Likewise.
4006
4007 2019-04-22  Pedro Alves  <palves@redhat.com>
4008
4009         * solib-svr4.c (svr4_free_objfile_observer): New.
4010         (probe_and_action::objfile): New field.
4011         (probes_table_htab_remove_objfile_probes)
4012         (probes_table_remove_objfile_probes): New functions.
4013         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4014         in the new probe_and_action.  Don't store the probe in 'lookup'.
4015         (svr4_create_probe_breakpoints): Pass objfile to
4016         register_solib_event_probe.
4017         (_initialize_svr4_solib): Register a free_objfile observer.
4018
4019 2019-04-19  Tom Tromey  <tom@tromey.com>
4020
4021         * common/queue.h: Remove.
4022
4023 2019-04-19  Tom Tromey  <tom@tromey.com>
4024
4025         * event-loop.c: Don't include "common/queue.h".
4026
4027 2019-04-19  Tom Tromey  <tom@tromey.com>
4028
4029         * remote.c (remote_target): Use delete.
4030         * remote-notif.h: Include <list>, not "common/queue.h".
4031         (notif_client_p): Remove typedef.
4032         (remote_notif_state): Add constructor, destructor, initializer.
4033         <notif_queue>: Now a std::list.
4034         (remote_notif_state_xfree): Don't declare.
4035         * remote-notif.c (remote_notif_process, handle_notification)
4036         (remote_notif_state_allocate): Update.
4037         (~remote_notif_state): Rename from remote_notif_state_xfree.
4038
4039 2019-04-19  Tom Tromey  <tom@tromey.com>
4040
4041         * symfile.c (reread_symbols): Update.
4042         * objfiles.c (objfile_register_static_link)
4043         (objfile_lookup_static_link): Update
4044         (~objfile) Don't delete static_links.
4045         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4046
4047 2019-04-19  Tom Tromey  <tom@tromey.com>
4048
4049         * type-stack.h (struct type_stack) <insert>: Constify string.
4050         * type-stack.c (type_stack::insert): Constify string.
4051         * gdbtypes.h (lookup_template_type): Update.
4052         (address_space_name_to_int): Update.
4053         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4054         const.
4055         (lookup_template_type): Make name const.
4056         * c-exp.y: Update rules.
4057         (lex_one_token, classify_name, classify_inner_name)
4058         (c_print_token): Update.
4059         * p-exp.y: Update rules.
4060         (yylex): Update.
4061         * f-exp.y: Update rules.
4062         (yylex): Update.
4063         * d-exp.y: Update rules.
4064         (lex_one_token, classify_name, classify_inner_name): Update.
4065         * parse.c (write_dollar_variable, copy_name): Return std::string.
4066         * parser-defs.h (copy_name): Change return type.
4067         * m2-exp.y: Update rules.
4068         (yylex): Update.
4069         * go-exp.y (lex_one_token): Update.
4070         Update rules.
4071         (classify_unsafe_function, classify_packaged_name)
4072         (classify_name, yylex): Update.
4073
4074 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4075
4076         * configure.ac: add --enable-source-highlight switch.
4077         * configure: Regenerate.
4078         * top.c (print_gdb_version): plumb --enable-source-highlight
4079         status to "show configuration".
4080
4081 2019-04-19  Tom Tromey  <tromey@adacore.com>
4082
4083         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4084         Check ADA_TYPE_P.
4085         (empty_record, ada_template_to_fixed_record_type_1)
4086         (template_to_static_fixed_type)
4087         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4088         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4089         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4090         macros.
4091
4092 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4093
4094         PR symtab/24423:
4095         * source.c (print_source_lines_base): Advance "iter" when a
4096         control character is seen.
4097
4098 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4099
4100         * inferior.h (struct infcall_suspend_state_deleter):
4101         Catch exception in destructor to avoid crash.
4102
4103 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4104
4105         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4106         close to the add_com "shell".
4107
4108 2019-04-18  Tom Tromey  <tromey@adacore.com>
4109
4110         * process-stratum-target.h (class process_stratum_target)
4111         <stratum>: Add "final".
4112
4113 2019-04-17  Tom Tromey  <tromey@adacore.com>
4114
4115         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4116         against nullptr before use.
4117
4118 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4119
4120         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4121
4122 2019-04-17  Jim Wilson  <jimw@sifive.com>
4123             Andrew Burgess  <andrew.burgess@embecosm.com>
4124
4125         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4126         code read might fail, assume 4-byte breakpoint in that case.
4127
4128 2019-04-15  Leszek Swirski  <leszeks@google.com>
4129
4130         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4131         rather than a hand-rolled POD check when checking for forced MEMORY
4132         classification.
4133
4134 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4135
4136         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4137         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4138         function.
4139         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4140         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4141         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4142         declaration.
4143
4144 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4145
4146         * aarch64-linux-nat.c
4147         (aarch64_linux_nat_target::thread_architecture): Add override.
4148         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4149         each VQ.
4150
4151 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4152
4153         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4154
4155 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4156
4157         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4158         target types of size 96-bits, add some additional comments, and
4159         check that the builtin type we found was the correct size.
4160
4161 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4162
4163         * utils.c (prompt_for_continue): Don't restore the styling at the
4164         end, as applied_style has the wrong value.  This fixes styling in
4165         long lists of file names that are interrupted by the "Continue?"
4166         prompt.
4167
4168 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4169
4170         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4171         * c-lang.c (c_language_defn): Likewise.
4172         (cplus_language_defn): Likewise.
4173         (asm_language_defn): Likewise.
4174         (minimal_language_defn): Likewise.
4175         * d-lang.c (d_language_defn): Likewise.
4176         * f-lang.c (f_language_defn): Likewise.
4177         * go-lang.c (go_language_defn): Likewise.
4178         * language.c (unknown_language_defn): Likewise.
4179         (auto_language_defn): Likewise.
4180         * language.h (struct language_defn): Remove la_magic field.
4181         (LANG_MAGIC): Delete.
4182         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4183         * objc-lang.c (objc_language_defn): Likewise.
4184         * opencl-lang.c (opencl_language_defn): Likewise.
4185         * p-lang.c (pascal_language_defn): Likewise.
4186         * rust-lang.c (rust_language_defn): Likewise.
4187
4188 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4189
4190         * riscv-tdep.c (riscv_type_align): New function.
4191         (riscv_type_alignment): Delete.
4192         (riscv_arg_location): Use 'type_align'.
4193         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4194
4195 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4196
4197         * gdbtypes.c (type_align): A struct with no non-static fields also
4198         has alignment of 1.
4199
4200 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4201
4202         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4203         component to 0.
4204         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4205         member.
4206         (riscv_struct_info::analyse): New implementation using new
4207         analyse_inner member function.
4208         (riscv_struct_info::field_offset): New member function.
4209         (riscv_struct_info::m_offsets): New member variable.
4210         (riscv_struct_info::analyse_inner): New private member function,
4211         takes the old implementation of riscv_struct_info::analyse but
4212         extended to track field offsets.
4213         (riscv_call_arg_struct): Update the struct folding special cases
4214         to handle cases where empty C++ structs, which are non-zero
4215         length, are found.
4216         (riscv_arg_location): Initialise the length of each location, a
4217         non-zero length now indicates the location is in use.
4218         (riscv_push_dummy_call): Allow for the first location having a
4219         non-zero offset when setting up arguments.
4220         (riscv_return_value): Likewise, but for return values.
4221
4222 2019-04-11  Tom Tromey  <tromey@adacore.com>
4223
4224         * utils.c (internal_vproblem): Make "msg" const.
4225
4226 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4227
4228         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4229         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4230         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4231         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4232
4233 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4234
4235         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4236         function.
4237         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4238         of amd64_collect_native_gregset.
4239         (amd64_linux_nat_target::store_registers): Likewise.
4240
4241 2019-04-10  Tom Tromey  <tom@tromey.com>
4242
4243         * symtab.c (lookup_global_symbol_from_objfile)
4244         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4245         * objfiles.h (class separate_debug_iterator): New.
4246         (class separate_debug_range): New.
4247         (struct objfile) <separate_debug_objfiles>: New method.
4248         (objfile_separate_debug_iterate): Don't declare.
4249         * objfiles.c (separate_debug_iterator::operator++): Rename from
4250         objfile_separate_debug_iterate.
4251         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4252         iterator.
4253         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4254         iterator.
4255
4256 2019-04-10  Tom Tromey  <tom@tromey.com>
4257
4258         * symfile.c (reread_symbols): Remove old comment.
4259         * objfiles.c (free_all_objfiles): Fix a typo.
4260
4261 2019-04-10  Tom Tromey  <tom@tromey.com>
4262
4263         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4264         * minsyms.c (lookup_minimal_symbol): Use foreach.
4265         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4266         (lookup_minimal_symbol_solib_trampoline): Likewise.
4267         * symfile.c (reread_symbols): Use foreach.
4268
4269 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4270             Tom Tromey  <tromey@adacore.com>
4271
4272         PR rust/24414:
4273         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4274         (rust_lex_int_test): Change "value" to be LONGEST.
4275         (rust_lex_tests): Add test for long integer literal.
4276
4277 2019-04-09  Tom Tromey  <tromey@adacore.com>
4278
4279         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
4280         to bool.
4281         (extended_remote_target::attach): Update.
4282         (remote_target::remote_notice_new_inferior): Update.
4283         (remote_target::add_current_inferior_and_thread): Update.
4284         * inferior.c (exit_inferior_1): Use "false".
4285         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
4286
4287 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
4288
4289         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
4290         the "start" command.
4291
4292 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4293
4294         * python/py-inferior.c (infpy_thread_from_thread_handle):
4295         Adjust comments to reflect renaming of thread_from_thread_handle
4296         to thread_from_handle.  Adjust keywords.  Fix type error message.
4297         (inferior_object_methods): Add thread_from_handle.  Retain
4298         thread_from_thread_handle, but mark it as deprecated.
4299
4300 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4301
4302         * gdbthread.h (find_thread_by_handle): Revise declaration.
4303         * thread.c (find_thread_by_handle): Likewise.  Adjust
4304         implementation too.
4305         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
4306         support for buffer objects as handles.
4307
4308 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4309
4310         * python/py-infthread.c (thpy_thread_handle): New function.
4311         (thread_object_methods): Register thpy_thread_handle.
4312
4313 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4314
4315         * gdbthread.h (thread_to_thread_handle): Declare.
4316         * thread.c (gdbtypes.h): Include.
4317         (thread_to_thread_handle): New function.
4318
4319         * target.h (struct target_ops): Add thread_info_to_thread_handle.
4320         (target_thread_info_to_thread_handle): Declare.
4321         * target.c (target_thread_info_to_thread_handle): New function.
4322         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
4323         * target-delegates.c: Regenerate.
4324
4325         * linux-thread-db.c (class thread_db_target): Add method
4326         thread_info_to_thread_handle.
4327         (thread_db_target::thread_info_to_thread_handle): Define.
4328         * remote.c (class remote_target): Add new method
4329         thread_info_to_thread_handle.
4330         (remote_target::thread_info_to_thread_handle): Define.
4331
4332 2019-04-08  Pedro Alves  <palves@redhat.com>
4333
4334         * common/common-exceptions.c (throw_exception): Don't create
4335         named object to throw; throw directly.
4336         (throw_it): Likewise.  Don't initialize gdb_exception::message
4337         here, with new; pass FMT and AP to the ctor instead.
4338         * common/common-exceptions.h: Include <string>.
4339         (gdb_exception::gdb_exception(enum return_reason, enum errors,
4340         const char *, va_list)): New ctor.  Use std::make_shared.
4341         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
4342         errors)): Delete.
4343         (gdb_exception_error::gdb_exception_error(enum errors, const char
4344         *, va_list)): New.
4345         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
4346         Add assertion.
4347         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
4348         errors)): Delete.
4349         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
4350         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
4351         Add assertion.
4352
4353 2019-04-08  Tom Tromey  <tom@tromey.com>
4354
4355         * valops.c (value_rtti_indirect_type): Replace throw_exception
4356         with throw.
4357         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
4358         with throw.
4359         * thread.c (thr_try_catch_cmd): Replace throw_exception with
4360         throw.
4361         * target.c (target_translate_tls_address): Replace throw_exception
4362         with throw.
4363         * stack.c (frame_apply_command_count): Replace throw_exception
4364         with throw.
4365         * solib-spu.c (append_ocl_sos): Replace throw_exception with
4366         throw.
4367         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
4368         with throw.
4369         * rs6000-tdep.c (rs6000_frame_cache)
4370         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
4371         * remote.c: Replace throw_exception with throw.
4372         * record-full.c (record_full_message, record_full_wait_1)
4373         (record_full_restore): Replace throw_exception with throw.
4374         * record-btrace.c:
4375         (get_thread_current_frame_id, record_btrace_start_replaying)
4376         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
4377         (cmd_record_btrace_start): Replace throw_exception with throw.
4378         * parse.c (parse_exp_in_context_1): Replace throw_exception with
4379         throw.
4380         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
4381         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
4382         * linespec.c:
4383         (find_linespec_symbols): Replace throw_exception with throw.
4384         * infrun.c (displaced_step_prepare, resume): Replace
4385         throw_exception with throw.
4386         * infcmd.c (post_create_inferior): Replace throw_exception with
4387         throw.
4388         * inf-loop.c (inferior_event_handler): Replace throw_exception
4389         with throw.
4390         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
4391         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
4392         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
4393         (get_prev_frame_always, get_frame_pc_if_available)
4394         (get_frame_address_in_block_if_available, get_frame_language):
4395         Replace throw_exception with throw.
4396         * frame-unwind.c (frame_unwind_try_unwinder): Replace
4397         throw_exception with throw.
4398         * eval.c (fetch_subexp_value, evaluate_var_value)
4399         (evaluate_funcall, evaluate_subexp_standard): Replace
4400         throw_exception with throw.
4401         * dwarf2loc.c (call_site_find_chain)
4402         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
4403         Replace throw_exception with throw.
4404         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
4405         with throw.
4406         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
4407         throw.
4408         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
4409         * completer.c (complete_line_internal): Replace throw_exception
4410         with throw.
4411         * compile/compile-object-run.c (compile_object_run): Replace
4412         throw_exception with throw.
4413         * cli/cli-script.c (process_next_line): Replace throw_exception
4414         with throw.
4415         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
4416         (btrace_enable, btrace_maint_update_pt_packets): Replace
4417         throw_exception with throw.
4418         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
4419         throw_exception with throw.
4420         * break-catch-throw.c (re_set_exception_catchpoint): Replace
4421         throw_exception with throw.
4422         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
4423         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
4424         * aarch64-tdep.c (aarch64_make_prologue_cache)
4425         (aarch64_make_stub_cache): Replace throw_exception with throw.
4426
4427 2019-04-08  Tom Tromey  <tom@tromey.com>
4428
4429         * common/common-exceptions.c (throw_exception): Rename from
4430         throw_exception_cxx.  Remove old copy.  Make argument const.
4431         (throw_it): Create and throw exception objects directly.
4432         * common/common-exceptions.h (throw_exception): Make argument
4433         const.
4434         (struct gdb_exception_error): Add constructor.
4435         (struct gdb_exception_quit): Add constructor.
4436
4437 2019-04-08  Tom Tromey  <tom@tromey.com>
4438
4439         * common/common-exceptions.h (exception_rethrow): Don't declare.
4440         (TRY_SJLJ): Update comment.
4441         (TRY, CATCH, END_CATCH): Remove.
4442         * common/common-exceptions.c (exception_rethrow): Remove.
4443
4444 2019-04-08  Tom Tromey  <tom@tromey.com>
4445
4446         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
4447         Remove.
4448         (gdb_exception_error): Rename from
4449         gdb_exception_RETURN_MASK_ERROR.
4450         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
4451         (gdb_quit_bad_alloc): Update.
4452         * aarch64-tdep.c: Update.
4453         * ada-lang.c: Update.
4454         * ada-typeprint.c: Update.
4455         * ada-valprint.c: Update.
4456         * amd64-tdep.c: Update.
4457         * arch-utils.c: Update.
4458         * break-catch-throw.c: Update.
4459         * breakpoint.c: Update.
4460         * btrace.c: Update.
4461         * c-varobj.c: Update.
4462         * cli/cli-cmds.c: Update.
4463         * cli/cli-interp.c: Update.
4464         * cli/cli-script.c: Update.
4465         * common/common-exceptions.c: Update.
4466         * common/new-op.c: Update.
4467         * common/selftest.c: Update.
4468         * compile/compile-c-symbols.c: Update.
4469         * compile/compile-cplus-symbols.c: Update.
4470         * compile/compile-object-load.c: Update.
4471         * compile/compile-object-run.c: Update.
4472         * completer.c: Update.
4473         * corelow.c: Update.
4474         * cp-abi.c: Update.
4475         * cp-support.c: Update.
4476         * cp-valprint.c: Update.
4477         * darwin-nat.c: Update.
4478         * disasm-selftests.c: Update.
4479         * dtrace-probe.c: Update.
4480         * dwarf-index-cache.c: Update.
4481         * dwarf-index-write.c: Update.
4482         * dwarf2-frame-tailcall.c: Update.
4483         * dwarf2-frame.c: Update.
4484         * dwarf2loc.c: Update.
4485         * dwarf2read.c: Update.
4486         * eval.c: Update.
4487         * event-loop.c: Update.
4488         * event-top.c: Update.
4489         * exec.c: Update.
4490         * f-valprint.c: Update.
4491         * fbsd-tdep.c: Update.
4492         * frame-unwind.c: Update.
4493         * frame.c: Update.
4494         * gdbtypes.c: Update.
4495         * gnu-v3-abi.c: Update.
4496         * guile/guile-internal.h: Update.
4497         * guile/scm-block.c: Update.
4498         * guile/scm-breakpoint.c: Update.
4499         * guile/scm-cmd.c: Update.
4500         * guile/scm-disasm.c: Update.
4501         * guile/scm-frame.c: Update.
4502         * guile/scm-lazy-string.c: Update.
4503         * guile/scm-math.c: Update.
4504         * guile/scm-param.c: Update.
4505         * guile/scm-ports.c: Update.
4506         * guile/scm-pretty-print.c: Update.
4507         * guile/scm-symbol.c: Update.
4508         * guile/scm-symtab.c: Update.
4509         * guile/scm-type.c: Update.
4510         * guile/scm-value.c: Update.
4511         * i386-linux-tdep.c: Update.
4512         * i386-tdep.c: Update.
4513         * inf-loop.c: Update.
4514         * infcall.c: Update.
4515         * infcmd.c: Update.
4516         * infrun.c: Update.
4517         * jit.c: Update.
4518         * language.c: Update.
4519         * linespec.c: Update.
4520         * linux-fork.c: Update.
4521         * linux-nat.c: Update.
4522         * linux-tdep.c: Update.
4523         * linux-thread-db.c: Update.
4524         * main.c: Update.
4525         * mi/mi-cmd-break.c: Update.
4526         * mi/mi-cmd-stack.c: Update.
4527         * mi/mi-interp.c: Update.
4528         * mi/mi-main.c: Update.
4529         * objc-lang.c: Update.
4530         * p-valprint.c: Update.
4531         * parse.c: Update.
4532         * ppc-linux-tdep.c: Update.
4533         * printcmd.c: Update.
4534         * python/py-arch.c: Update.
4535         * python/py-breakpoint.c: Update.
4536         * python/py-cmd.c: Update.
4537         * python/py-finishbreakpoint.c: Update.
4538         * python/py-frame.c: Update.
4539         * python/py-framefilter.c: Update.
4540         * python/py-gdb-readline.c: Update.
4541         * python/py-inferior.c: Update.
4542         * python/py-infthread.c: Update.
4543         * python/py-lazy-string.c: Update.
4544         * python/py-linetable.c: Update.
4545         * python/py-objfile.c: Update.
4546         * python/py-param.c: Update.
4547         * python/py-prettyprint.c: Update.
4548         * python/py-progspace.c: Update.
4549         * python/py-record-btrace.c: Update.
4550         * python/py-record.c: Update.
4551         * python/py-symbol.c: Update.
4552         * python/py-type.c: Update.
4553         * python/py-unwind.c: Update.
4554         * python/py-utils.c: Update.
4555         * python/py-value.c: Update.
4556         * python/python.c: Update.
4557         * record-btrace.c: Update.
4558         * record-full.c: Update.
4559         * remote-fileio.c: Update.
4560         * remote.c: Update.
4561         * riscv-tdep.c: Update.
4562         * rs6000-aix-tdep.c: Update.
4563         * rs6000-tdep.c: Update.
4564         * rust-exp.y: Update.
4565         * rust-lang.c: Update.
4566         * s390-tdep.c: Update.
4567         * selftest-arch.c: Update.
4568         * solib-dsbt.c: Update.
4569         * solib-frv.c: Update.
4570         * solib-spu.c: Update.
4571         * solib-svr4.c: Update.
4572         * solib.c: Update.
4573         * sparc64-linux-tdep.c: Update.
4574         * stack.c: Update.
4575         * symfile-mem.c: Update.
4576         * symmisc.c: Update.
4577         * target.c: Update.
4578         * thread.c: Update.
4579         * top.c: Update.
4580         * tracefile-tfile.c: Update.
4581         * tui/tui.c: Update.
4582         * typeprint.c: Update.
4583         * unittests/cli-utils-selftests.c: Update.
4584         * unittests/parse-connection-spec-selftests.c: Update.
4585         * valops.c: Update.
4586         * valprint.c: Update.
4587         * value.c: Update.
4588         * varobj.c: Update.
4589         * windows-nat.c: Update.
4590         * x86-linux-nat.c: Update.
4591         * xml-support.c: Update.
4592
4593 2019-04-08  Tom Tromey  <tom@tromey.com>
4594
4595         * xml-support.c: Use C++ exception handling.
4596         * x86-linux-nat.c: Use C++ exception handling.
4597         * windows-nat.c: Use C++ exception handling.
4598         * varobj.c: Use C++ exception handling.
4599         * value.c: Use C++ exception handling.
4600         * valprint.c: Use C++ exception handling.
4601         * valops.c: Use C++ exception handling.
4602         * unittests/parse-connection-spec-selftests.c: Use C++ exception
4603         handling.
4604         * unittests/cli-utils-selftests.c: Use C++ exception handling.
4605         * typeprint.c: Use C++ exception handling.
4606         * tui/tui.c: Use C++ exception handling.
4607         * tracefile-tfile.c: Use C++ exception handling.
4608         * top.c: Use C++ exception handling.
4609         * thread.c: Use C++ exception handling.
4610         * target.c: Use C++ exception handling.
4611         * symmisc.c: Use C++ exception handling.
4612         * symfile-mem.c: Use C++ exception handling.
4613         * stack.c: Use C++ exception handling.
4614         * sparc64-linux-tdep.c: Use C++ exception handling.
4615         * solib.c: Use C++ exception handling.
4616         * solib-svr4.c: Use C++ exception handling.
4617         * solib-spu.c: Use C++ exception handling.
4618         * solib-frv.c: Use C++ exception handling.
4619         * solib-dsbt.c: Use C++ exception handling.
4620         * selftest-arch.c: Use C++ exception handling.
4621         * s390-tdep.c: Use C++ exception handling.
4622         * rust-lang.c: Use C++ exception handling.
4623         * rust-exp.y: Use C++ exception handling.
4624         * rs6000-tdep.c: Use C++ exception handling.
4625         * rs6000-aix-tdep.c: Use C++ exception handling.
4626         * riscv-tdep.c: Use C++ exception handling.
4627         * remote.c: Use C++ exception handling.
4628         * remote-fileio.c: Use C++ exception handling.
4629         * record-full.c: Use C++ exception handling.
4630         * record-btrace.c: Use C++ exception handling.
4631         * python/python.c: Use C++ exception handling.
4632         * python/py-value.c: Use C++ exception handling.
4633         * python/py-utils.c: Use C++ exception handling.
4634         * python/py-unwind.c: Use C++ exception handling.
4635         * python/py-type.c: Use C++ exception handling.
4636         * python/py-symbol.c: Use C++ exception handling.
4637         * python/py-record.c: Use C++ exception handling.
4638         * python/py-record-btrace.c: Use C++ exception handling.
4639         * python/py-progspace.c: Use C++ exception handling.
4640         * python/py-prettyprint.c: Use C++ exception handling.
4641         * python/py-param.c: Use C++ exception handling.
4642         * python/py-objfile.c: Use C++ exception handling.
4643         * python/py-linetable.c: Use C++ exception handling.
4644         * python/py-lazy-string.c: Use C++ exception handling.
4645         * python/py-infthread.c: Use C++ exception handling.
4646         * python/py-inferior.c: Use C++ exception handling.
4647         * python/py-gdb-readline.c: Use C++ exception handling.
4648         * python/py-framefilter.c: Use C++ exception handling.
4649         * python/py-frame.c: Use C++ exception handling.
4650         * python/py-finishbreakpoint.c: Use C++ exception handling.
4651         * python/py-cmd.c: Use C++ exception handling.
4652         * python/py-breakpoint.c: Use C++ exception handling.
4653         * python/py-arch.c: Use C++ exception handling.
4654         * printcmd.c: Use C++ exception handling.
4655         * ppc-linux-tdep.c: Use C++ exception handling.
4656         * parse.c: Use C++ exception handling.
4657         * p-valprint.c: Use C++ exception handling.
4658         * objc-lang.c: Use C++ exception handling.
4659         * mi/mi-main.c: Use C++ exception handling.
4660         * mi/mi-interp.c: Use C++ exception handling.
4661         * mi/mi-cmd-stack.c: Use C++ exception handling.
4662         * mi/mi-cmd-break.c: Use C++ exception handling.
4663         * main.c: Use C++ exception handling.
4664         * linux-thread-db.c: Use C++ exception handling.
4665         * linux-tdep.c: Use C++ exception handling.
4666         * linux-nat.c: Use C++ exception handling.
4667         * linux-fork.c: Use C++ exception handling.
4668         * linespec.c: Use C++ exception handling.
4669         * language.c: Use C++ exception handling.
4670         * jit.c: Use C++ exception handling.
4671         * infrun.c: Use C++ exception handling.
4672         * infcmd.c: Use C++ exception handling.
4673         * infcall.c: Use C++ exception handling.
4674         * inf-loop.c: Use C++ exception handling.
4675         * i386-tdep.c: Use C++ exception handling.
4676         * i386-linux-tdep.c: Use C++ exception handling.
4677         * guile/scm-value.c: Use C++ exception handling.
4678         * guile/scm-type.c: Use C++ exception handling.
4679         * guile/scm-symtab.c: Use C++ exception handling.
4680         * guile/scm-symbol.c: Use C++ exception handling.
4681         * guile/scm-pretty-print.c: Use C++ exception handling.
4682         * guile/scm-ports.c: Use C++ exception handling.
4683         * guile/scm-param.c: Use C++ exception handling.
4684         * guile/scm-math.c: Use C++ exception handling.
4685         * guile/scm-lazy-string.c: Use C++ exception handling.
4686         * guile/scm-frame.c: Use C++ exception handling.
4687         * guile/scm-disasm.c: Use C++ exception handling.
4688         * guile/scm-cmd.c: Use C++ exception handling.
4689         * guile/scm-breakpoint.c: Use C++ exception handling.
4690         * guile/scm-block.c: Use C++ exception handling.
4691         * guile/guile-internal.h: Use C++ exception handling.
4692         * gnu-v3-abi.c: Use C++ exception handling.
4693         * gdbtypes.c: Use C++ exception handling.
4694         * frame.c: Use C++ exception handling.
4695         * frame-unwind.c: Use C++ exception handling.
4696         * fbsd-tdep.c: Use C++ exception handling.
4697         * f-valprint.c: Use C++ exception handling.
4698         * exec.c: Use C++ exception handling.
4699         * event-top.c: Use C++ exception handling.
4700         * event-loop.c: Use C++ exception handling.
4701         * eval.c: Use C++ exception handling.
4702         * dwarf2read.c: Use C++ exception handling.
4703         * dwarf2loc.c: Use C++ exception handling.
4704         * dwarf2-frame.c: Use C++ exception handling.
4705         * dwarf2-frame-tailcall.c: Use C++ exception handling.
4706         * dwarf-index-write.c: Use C++ exception handling.
4707         * dwarf-index-cache.c: Use C++ exception handling.
4708         * dtrace-probe.c: Use C++ exception handling.
4709         * disasm-selftests.c: Use C++ exception handling.
4710         * darwin-nat.c: Use C++ exception handling.
4711         * cp-valprint.c: Use C++ exception handling.
4712         * cp-support.c: Use C++ exception handling.
4713         * cp-abi.c: Use C++ exception handling.
4714         * corelow.c: Use C++ exception handling.
4715         * completer.c: Use C++ exception handling.
4716         * compile/compile-object-run.c: Use C++ exception handling.
4717         * compile/compile-object-load.c: Use C++ exception handling.
4718         * compile/compile-cplus-symbols.c: Use C++ exception handling.
4719         * compile/compile-c-symbols.c: Use C++ exception handling.
4720         * common/selftest.c: Use C++ exception handling.
4721         * common/new-op.c: Use C++ exception handling.
4722         * cli/cli-script.c: Use C++ exception handling.
4723         * cli/cli-interp.c: Use C++ exception handling.
4724         * cli/cli-cmds.c: Use C++ exception handling.
4725         * c-varobj.c: Use C++ exception handling.
4726         * btrace.c: Use C++ exception handling.
4727         * breakpoint.c: Use C++ exception handling.
4728         * break-catch-throw.c: Use C++ exception handling.
4729         * arch-utils.c: Use C++ exception handling.
4730         * amd64-tdep.c: Use C++ exception handling.
4731         * ada-valprint.c: Use C++ exception handling.
4732         * ada-typeprint.c: Use C++ exception handling.
4733         * ada-lang.c: Use C++ exception handling.
4734         * aarch64-tdep.c: Use C++ exception handling.
4735
4736 2019-04-08  Tom Tromey  <tom@tromey.com>
4737
4738         * xml-support.c (gdb_xml_parser::parse): Update.
4739         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4740         * value.c (show_convenience): Update.
4741         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
4742         (test_parse_flags_qcs): Update.
4743         * thread.c (thr_try_catch_cmd): Update.
4744         * target.c (target_translate_tls_address): Update.
4745         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4746         (info_frame_command_core, frame_apply_command_count): Update.
4747         * rust-exp.y (rust_lex_exception_test): Update.
4748         * riscv-tdep.c (riscv_print_one_register_info): Update.
4749         * remote.c (remote_target::enable_btrace): Update.
4750         * record-btrace.c (record_btrace_enable_warn): Update.
4751         * python/py-utils.c (gdbpy_convert_exception): Update.
4752         * printcmd.c (do_one_display, print_variable_and_value): Update.
4753         * mi/mi-main.c (mi_print_exception): Update.
4754         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
4755         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4756         * linux-nat.c (linux_nat_target::attach): Update.
4757         * linux-fork.c (class scoped_switch_fork_info): Update.
4758         * infrun.c (displaced_step_prepare): Update.
4759         * infcall.c (call_function_by_hand_dummy): Update.
4760         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
4761         * gnu-v3-abi.c (print_one_vtable): Update.
4762         * frame.c (get_prev_frame_always): Update.
4763         * f-valprint.c (info_common_command_for_block): Update.
4764         * exec.c (try_open_exec_file): Update.
4765         * exceptions.c (print_exception, exception_print)
4766         (exception_fprintf, exception_print_same): Update.
4767         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
4768         * dwarf-index-cache.c (index_cache::store)
4769         (index_cache::lookup_gdb_index): Update.
4770         * darwin-nat.c (maybe_cache_shell): Update.
4771         * cp-valprint.c (cp_print_value_fields): Update.
4772         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
4773         (gcc_cplus_symbol_address): Update.
4774         * compile/compile-c-symbols.c (gcc_convert_symbol)
4775         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
4776         * common/selftest.c: Update.
4777         * common/common-exceptions.h (struct gdb_exception) <message>: Now
4778         a std::string.
4779         (exception_try_scope_entry, exception_try_scope_exit): Don't
4780         declare.
4781         (struct exception_try_scope): Remove.
4782         (TRY): Don't use exception_try_scope.
4783         (struct gdb_exception): Add constructor, operator=.
4784         <what>: New method.
4785         (struct gdb_exception_RETURN_MASK_ALL)
4786         (struct gdb_exception_RETURN_MASK_ERROR)
4787         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
4788         (struct gdb_quit_bad_alloc): Update.
4789         * common/common-exceptions.c (exception_none): Change
4790         initializer.
4791         (struct catcher) <state, exception>: Initialize inline.
4792         <prev>: Remove member.
4793         (current_catcher): Remove.
4794         (catchers): New global.
4795         (exceptions_state_mc_init): Simplify.
4796         (catcher_pop): Remove.
4797         (exceptions_state_mc, exceptions_state_mc_catch): Update.
4798         (try_scope_depth, exception_try_scope_entry)
4799         (exception_try_scope_exit): Remove.
4800         (throw_exception_sjlj): Update.
4801         (exception_messages, exception_messages_size): Remove.
4802         (throw_it): Simplify.
4803         (gdb_exception_sliced_copy): Remove.
4804         (throw_exception_cxx): Update.
4805         * cli/cli-script.c (script_from_file): Update.
4806         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
4807         Update.
4808         * ada-valprint.c (ada_val_print): Update.
4809         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
4810         (create_excep_cond_exprs): Update.
4811
4812 2019-04-08  Tom Tromey  <tom@tromey.com>
4813
4814         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
4815         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
4816         (TRY, CATCH, END_CATCH): Remove some definitions.
4817         * common/common-exceptions.c: Don't use GDB_XCPT.
4818         (catcher_list_size): Remove.
4819         (throw_exception, throw_it): Simplify.
4820
4821 2019-04-05  Tom Tromey  <tom@tromey.com>
4822
4823         Revert the header-sorting patch.
4824         * ft32-tdep.c: Revert.
4825         * frv-tdep.c: Revert.
4826         * frv-linux-tdep.c: Revert.
4827         * frame.c: Revert.
4828         * frame-unwind.c: Revert.
4829         * frame-base.c: Revert.
4830         * fork-child.c: Revert.
4831         * findvar.c: Revert.
4832         * findcmd.c: Revert.
4833         * filesystem.c: Revert.
4834         * filename-seen-cache.h: Revert.
4835         * filename-seen-cache.c: Revert.
4836         * fbsd-tdep.c: Revert.
4837         * fbsd-nat.h: Revert.
4838         * fbsd-nat.c: Revert.
4839         * f-valprint.c: Revert.
4840         * f-typeprint.c: Revert.
4841         * f-lang.c: Revert.
4842         * extension.h: Revert.
4843         * extension.c: Revert.
4844         * extension-priv.h: Revert.
4845         * expprint.c: Revert.
4846         * exec.h: Revert.
4847         * exec.c: Revert.
4848         * exceptions.c: Revert.
4849         * event-top.c: Revert.
4850         * event-loop.c: Revert.
4851         * eval.c: Revert.
4852         * elfread.c: Revert.
4853         * dwarf2read.h: Revert.
4854         * dwarf2read.c: Revert.
4855         * dwarf2loc.c: Revert.
4856         * dwarf2expr.h: Revert.
4857         * dwarf2expr.c: Revert.
4858         * dwarf2-frame.c: Revert.
4859         * dwarf2-frame-tailcall.c: Revert.
4860         * dwarf-index-write.h: Revert.
4861         * dwarf-index-write.c: Revert.
4862         * dwarf-index-common.c: Revert.
4863         * dwarf-index-cache.h: Revert.
4864         * dwarf-index-cache.c: Revert.
4865         * dummy-frame.c: Revert.
4866         * dtrace-probe.c: Revert.
4867         * disasm.h: Revert.
4868         * disasm.c: Revert.
4869         * disasm-selftests.c: Revert.
4870         * dictionary.c: Revert.
4871         * dicos-tdep.c: Revert.
4872         * demangle.c: Revert.
4873         * dcache.h: Revert.
4874         * dcache.c: Revert.
4875         * darwin-nat.h: Revert.
4876         * darwin-nat.c: Revert.
4877         * darwin-nat-info.c: Revert.
4878         * d-valprint.c: Revert.
4879         * d-namespace.c: Revert.
4880         * d-lang.c: Revert.
4881         * ctf.c: Revert.
4882         * csky-tdep.c: Revert.
4883         * csky-linux-tdep.c: Revert.
4884         * cris-tdep.c: Revert.
4885         * cris-linux-tdep.c: Revert.
4886         * cp-valprint.c: Revert.
4887         * cp-support.c: Revert.
4888         * cp-namespace.c: Revert.
4889         * cp-abi.c: Revert.
4890         * corelow.c: Revert.
4891         * corefile.c: Revert.
4892         * continuations.c: Revert.
4893         * completer.h: Revert.
4894         * completer.c: Revert.
4895         * complaints.c: Revert.
4896         * coffread.c: Revert.
4897         * coff-pe-read.c: Revert.
4898         * cli-out.h: Revert.
4899         * cli-out.c: Revert.
4900         * charset.c: Revert.
4901         * c-varobj.c: Revert.
4902         * c-valprint.c: Revert.
4903         * c-typeprint.c: Revert.
4904         * c-lang.c: Revert.
4905         * buildsym.c: Revert.
4906         * buildsym-legacy.c: Revert.
4907         * build-id.h: Revert.
4908         * build-id.c: Revert.
4909         * btrace.c: Revert.
4910         * bsd-uthread.c: Revert.
4911         * breakpoint.h: Revert.
4912         * breakpoint.c: Revert.
4913         * break-catch-throw.c: Revert.
4914         * break-catch-syscall.c: Revert.
4915         * break-catch-sig.c: Revert.
4916         * blockframe.c: Revert.
4917         * block.c: Revert.
4918         * bfin-tdep.c: Revert.
4919         * bfin-linux-tdep.c: Revert.
4920         * bfd-target.c: Revert.
4921         * bcache.c: Revert.
4922         * ax-general.c: Revert.
4923         * ax-gdb.h: Revert.
4924         * ax-gdb.c: Revert.
4925         * avr-tdep.c: Revert.
4926         * auxv.c: Revert.
4927         * auto-load.c: Revert.
4928         * arm-wince-tdep.c: Revert.
4929         * arm-tdep.c: Revert.
4930         * arm-symbian-tdep.c: Revert.
4931         * arm-pikeos-tdep.c: Revert.
4932         * arm-obsd-tdep.c: Revert.
4933         * arm-nbsd-tdep.c: Revert.
4934         * arm-nbsd-nat.c: Revert.
4935         * arm-linux-tdep.c: Revert.
4936         * arm-linux-nat.c: Revert.
4937         * arm-fbsd-tdep.c: Revert.
4938         * arm-fbsd-nat.c: Revert.
4939         * arm-bsd-tdep.c: Revert.
4940         * arch-utils.c: Revert.
4941         * arc-tdep.c: Revert.
4942         * arc-newlib-tdep.c: Revert.
4943         * annotate.h: Revert.
4944         * annotate.c: Revert.
4945         * amd64-windows-tdep.c: Revert.
4946         * amd64-windows-nat.c: Revert.
4947         * amd64-tdep.c: Revert.
4948         * amd64-sol2-tdep.c: Revert.
4949         * amd64-obsd-tdep.c: Revert.
4950         * amd64-obsd-nat.c: Revert.
4951         * amd64-nbsd-tdep.c: Revert.
4952         * amd64-nbsd-nat.c: Revert.
4953         * amd64-nat.c: Revert.
4954         * amd64-linux-tdep.c: Revert.
4955         * amd64-linux-nat.c: Revert.
4956         * amd64-fbsd-tdep.c: Revert.
4957         * amd64-fbsd-nat.c: Revert.
4958         * amd64-dicos-tdep.c: Revert.
4959         * amd64-darwin-tdep.c: Revert.
4960         * amd64-bsd-nat.c: Revert.
4961         * alpha-tdep.c: Revert.
4962         * alpha-obsd-tdep.c: Revert.
4963         * alpha-nbsd-tdep.c: Revert.
4964         * alpha-mdebug-tdep.c: Revert.
4965         * alpha-linux-tdep.c: Revert.
4966         * alpha-linux-nat.c: Revert.
4967         * alpha-bsd-tdep.c: Revert.
4968         * alpha-bsd-nat.c: Revert.
4969         * aix-thread.c: Revert.
4970         * agent.c: Revert.
4971         * addrmap.c: Revert.
4972         * ada-varobj.c: Revert.
4973         * ada-valprint.c: Revert.
4974         * ada-typeprint.c: Revert.
4975         * ada-tasks.c: Revert.
4976         * ada-lang.c: Revert.
4977         * aarch64-tdep.c: Revert.
4978         * aarch64-ravenscar-thread.c: Revert.
4979         * aarch64-newlib-tdep.c: Revert.
4980         * aarch64-linux-tdep.c: Revert.
4981         * aarch64-linux-nat.c: Revert.
4982         * aarch64-fbsd-tdep.c: Revert.
4983         * aarch64-fbsd-nat.c: Revert.
4984         * aarch32-linux-nat.c: Revert.
4985
4986 2019-04-05  Tom Tromey  <tom@tromey.com>
4987
4988         * ft32-tdep.c: Sort headers.
4989         * frv-tdep.c: Sort headers.
4990         * frv-linux-tdep.c: Sort headers.
4991         * frame.c: Sort headers.
4992         * frame-unwind.c: Sort headers.
4993         * frame-base.c: Sort headers.
4994         * fork-child.c: Sort headers.
4995         * findvar.c: Sort headers.
4996         * findcmd.c: Sort headers.
4997         * filesystem.c: Sort headers.
4998         * filename-seen-cache.h: Sort headers.
4999         * filename-seen-cache.c: Sort headers.
5000         * fbsd-tdep.c: Sort headers.
5001         * fbsd-nat.h: Sort headers.
5002         * fbsd-nat.c: Sort headers.
5003         * f-valprint.c: Sort headers.
5004         * f-typeprint.c: Sort headers.
5005         * f-lang.c: Sort headers.
5006         * extension.h: Sort headers.
5007         * extension.c: Sort headers.
5008         * extension-priv.h: Sort headers.
5009         * expprint.c: Sort headers.
5010         * exec.h: Sort headers.
5011         * exec.c: Sort headers.
5012         * exceptions.c: Sort headers.
5013         * event-top.c: Sort headers.
5014         * event-loop.c: Sort headers.
5015         * eval.c: Sort headers.
5016         * elfread.c: Sort headers.
5017         * dwarf2read.h: Sort headers.
5018         * dwarf2read.c: Sort headers.
5019         * dwarf2loc.c: Sort headers.
5020         * dwarf2expr.h: Sort headers.
5021         * dwarf2expr.c: Sort headers.
5022         * dwarf2-frame.c: Sort headers.
5023         * dwarf2-frame-tailcall.c: Sort headers.
5024         * dwarf-index-write.h: Sort headers.
5025         * dwarf-index-write.c: Sort headers.
5026         * dwarf-index-common.c: Sort headers.
5027         * dwarf-index-cache.h: Sort headers.
5028         * dwarf-index-cache.c: Sort headers.
5029         * dummy-frame.c: Sort headers.
5030         * dtrace-probe.c: Sort headers.
5031         * disasm.h: Sort headers.
5032         * disasm.c: Sort headers.
5033         * disasm-selftests.c: Sort headers.
5034         * dictionary.c: Sort headers.
5035         * dicos-tdep.c: Sort headers.
5036         * demangle.c: Sort headers.
5037         * dcache.h: Sort headers.
5038         * dcache.c: Sort headers.
5039         * darwin-nat.h: Sort headers.
5040         * darwin-nat.c: Sort headers.
5041         * darwin-nat-info.c: Sort headers.
5042         * d-valprint.c: Sort headers.
5043         * d-namespace.c: Sort headers.
5044         * d-lang.c: Sort headers.
5045         * ctf.c: Sort headers.
5046         * csky-tdep.c: Sort headers.
5047         * csky-linux-tdep.c: Sort headers.
5048         * cris-tdep.c: Sort headers.
5049         * cris-linux-tdep.c: Sort headers.
5050         * cp-valprint.c: Sort headers.
5051         * cp-support.c: Sort headers.
5052         * cp-namespace.c: Sort headers.
5053         * cp-abi.c: Sort headers.
5054         * corelow.c: Sort headers.
5055         * corefile.c: Sort headers.
5056         * continuations.c: Sort headers.
5057         * completer.h: Sort headers.
5058         * completer.c: Sort headers.
5059         * complaints.c: Sort headers.
5060         * coffread.c: Sort headers.
5061         * coff-pe-read.c: Sort headers.
5062         * cli-out.h: Sort headers.
5063         * cli-out.c: Sort headers.
5064         * charset.c: Sort headers.
5065         * c-varobj.c: Sort headers.
5066         * c-valprint.c: Sort headers.
5067         * c-typeprint.c: Sort headers.
5068         * c-lang.c: Sort headers.
5069         * buildsym.c: Sort headers.
5070         * buildsym-legacy.c: Sort headers.
5071         * build-id.h: Sort headers.
5072         * build-id.c: Sort headers.
5073         * btrace.c: Sort headers.
5074         * bsd-uthread.c: Sort headers.
5075         * breakpoint.h: Sort headers.
5076         * breakpoint.c: Sort headers.
5077         * break-catch-throw.c: Sort headers.
5078         * break-catch-syscall.c: Sort headers.
5079         * break-catch-sig.c: Sort headers.
5080         * blockframe.c: Sort headers.
5081         * block.c: Sort headers.
5082         * bfin-tdep.c: Sort headers.
5083         * bfin-linux-tdep.c: Sort headers.
5084         * bfd-target.c: Sort headers.
5085         * bcache.c: Sort headers.
5086         * ax-general.c: Sort headers.
5087         * ax-gdb.h: Sort headers.
5088         * ax-gdb.c: Sort headers.
5089         * avr-tdep.c: Sort headers.
5090         * auxv.c: Sort headers.
5091         * auto-load.c: Sort headers.
5092         * arm-wince-tdep.c: Sort headers.
5093         * arm-tdep.c: Sort headers.
5094         * arm-symbian-tdep.c: Sort headers.
5095         * arm-pikeos-tdep.c: Sort headers.
5096         * arm-obsd-tdep.c: Sort headers.
5097         * arm-nbsd-tdep.c: Sort headers.
5098         * arm-nbsd-nat.c: Sort headers.
5099         * arm-linux-tdep.c: Sort headers.
5100         * arm-linux-nat.c: Sort headers.
5101         * arm-fbsd-tdep.c: Sort headers.
5102         * arm-fbsd-nat.c: Sort headers.
5103         * arm-bsd-tdep.c: Sort headers.
5104         * arch-utils.c: Sort headers.
5105         * arc-tdep.c: Sort headers.
5106         * arc-newlib-tdep.c: Sort headers.
5107         * annotate.h: Sort headers.
5108         * annotate.c: Sort headers.
5109         * amd64-windows-tdep.c: Sort headers.
5110         * amd64-windows-nat.c: Sort headers.
5111         * amd64-tdep.c: Sort headers.
5112         * amd64-sol2-tdep.c: Sort headers.
5113         * amd64-obsd-tdep.c: Sort headers.
5114         * amd64-obsd-nat.c: Sort headers.
5115         * amd64-nbsd-tdep.c: Sort headers.
5116         * amd64-nbsd-nat.c: Sort headers.
5117         * amd64-nat.c: Sort headers.
5118         * amd64-linux-tdep.c: Sort headers.
5119         * amd64-linux-nat.c: Sort headers.
5120         * amd64-fbsd-tdep.c: Sort headers.
5121         * amd64-fbsd-nat.c: Sort headers.
5122         * amd64-dicos-tdep.c: Sort headers.
5123         * amd64-darwin-tdep.c: Sort headers.
5124         * amd64-bsd-nat.c: Sort headers.
5125         * alpha-tdep.c: Sort headers.
5126         * alpha-obsd-tdep.c: Sort headers.
5127         * alpha-nbsd-tdep.c: Sort headers.
5128         * alpha-mdebug-tdep.c: Sort headers.
5129         * alpha-linux-tdep.c: Sort headers.
5130         * alpha-linux-nat.c: Sort headers.
5131         * alpha-bsd-tdep.c: Sort headers.
5132         * alpha-bsd-nat.c: Sort headers.
5133         * aix-thread.c: Sort headers.
5134         * agent.c: Sort headers.
5135         * addrmap.c: Sort headers.
5136         * ada-varobj.c: Sort headers.
5137         * ada-valprint.c: Sort headers.
5138         * ada-typeprint.c: Sort headers.
5139         * ada-tasks.c: Sort headers.
5140         * ada-lang.c: Sort headers.
5141         * aarch64-tdep.c: Sort headers.
5142         * aarch64-ravenscar-thread.c: Sort headers.
5143         * aarch64-newlib-tdep.c: Sort headers.
5144         * aarch64-linux-tdep.c: Sort headers.
5145         * aarch64-linux-nat.c: Sort headers.
5146         * aarch64-fbsd-tdep.c: Sort headers.
5147         * aarch64-fbsd-nat.c: Sort headers.
5148         * aarch32-linux-nat.c: Sort headers.
5149
5150 2019-04-04  Tom Tromey  <tom@tromey.com>
5151
5152         * varobj.c (varobj_create): Update.
5153         * rust-exp.y (struct rust_parser) <update_innermost_block,
5154         lookup_symbol>: New methods.
5155         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5156         Rename.
5157         (rust_parser::rust_lookup_type)
5158         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5159         * printcmd.c (display_command, do_one_display): Update.
5160         * parser-defs.h (struct parser_state) <parser_state>: Add
5161         "tracker" parameter.
5162         (block_tracker): New member.
5163         (class innermost_block_tracker) <innermost_block_tracker>: Add
5164         "types" parameter.
5165         <reset>: Remove method.
5166         (innermost_block): Don't declare.
5167         (null_post_parser): Update.
5168         * parse.c (innermost_block): Remove global.
5169         (write_dollar_variable): Update.
5170         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5171         Remove "tracker_types" parameter.
5172         (parse_expression): Add "tracker" parameter.
5173         (parse_expression_for_completion): Update.
5174         (null_post_parser): Add "tracker" parameter.
5175         * p-exp.y: Update rules.
5176         * m2-exp.y: Update rules.
5177         * language.h (struct language_defn) <la_post_parser>: Add
5178         "tracker" parameter.
5179         * go-exp.y: Update rules.
5180         * f-exp.y: Update rules.
5181         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5182         parameter.
5183         * d-exp.y: Update rules.
5184         * c-exp.y: Update rules.
5185         * breakpoint.c (set_breakpoint_condition): Create an
5186         innermost_block_tracker.
5187         (watch_command_1): Likewise.
5188         * ada-lang.c (resolve): Add "tracker" parameter.
5189         (resolve_subexp): Likewise.
5190         * ada-exp.y (write_var_from_sym): Update.
5191
5192 2019-04-04  Tom Tromey  <tom@tromey.com>
5193
5194         * type-stack.h: New file.
5195         * type-stack.c: New file.
5196         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5197         type-stack.h.
5198         (insert_into_type_stack, insert_type, push_type, push_type_int)
5199         (insert_type_address_space, pop_type, pop_type_int)
5200         (pop_typelist, pop_type_stack, append_type_stack)
5201         (push_type_stack, get_type_stack, push_typelist)
5202         (follow_type_instance_flags, follow_types): Don't declare.
5203         * parse.c (type_stack): Remove global.
5204         (parse_exp_in_context): Update.
5205         (insert_into_type_stack, insert_type, push_type, push_type_int)
5206         (insert_type_address_space, pop_type, pop_type_int)
5207         (pop_typelist, pop_type_stack, append_type_stack)
5208         (push_type_stack, get_type_stack, push_typelist)
5209         (follow_type_instance_flags, follow_types): Remove (moved to
5210         type-stack.c).
5211         * f-exp.y (type_stack): New global.
5212         Update rules.
5213         (push_kind_type, f_parse): Update.
5214         * d-exp.y (type_stack): New global.
5215         Update rules.
5216         (d_parse): Update.
5217         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5218         Update rules.
5219         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5220         (HFILES_NO_SRCDIR): Add type-stack.h.
5221
5222 2019-04-04  Tom Tromey  <tom@tromey.com>
5223
5224         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5225         (rust_parser::convert_ast_to_expression, rust_parse)
5226         (rust_lex_test_completion, rust_lex_tests): Update.
5227         * parser-defs.h (struct expr_completion_state): New.
5228         (struct parser_state) <parser_state>: Add completion parameter.
5229         <mark_struct_expression, mark_completion_tag>: New methods.
5230         <parse_completion, m_completion_state>: New members.
5231         (prefixify_expression, null_post_parser): Update.
5232         (mark_struct_expression, mark_completion_tag): Don't declare.
5233         * parse.c (parse_completion, expout_last_struct)
5234         (expout_tag_completion_type, expout_completion_name): Remove
5235         globals.
5236         (parser_state::mark_struct_expression)
5237         (parser_state::mark_completion_tag): Now methods.
5238         (prefixify_expression): Add last_struct parameter.
5239         (prefixify_subexp): Likewise.
5240         (parse_exp_1): Update.
5241         (parse_exp_in_context): Add cstate parameter.  Update.
5242         (parse_expression_for_completion): Create an
5243         expr_completion_state.
5244         (null_post_parser): Add "completion" parameter.
5245         * p-exp.y: Update rules.
5246         (yylex): Update.
5247         * language.h (struct language_defn) <la_post_parser>: Add
5248         "completing" parameter.
5249         * go-exp.y: Update rules.
5250         (lex_one_token): Update.
5251         * expression.h (parse_completion): Don't declare.
5252         * d-exp.y: Update rules.
5253         (lex_one_token): Update rules.
5254         * c-exp.y: Update rules.
5255         (lex_one_token): Update.
5256         * ada-lang.c (resolve): Add "parse_completion" parameter.
5257         (resolve_subexp): Likewise.
5258         (ada_resolve_function): Likewise.
5259
5260 2019-04-04  Tom Tromey  <tom@tromey.com>
5261
5262         * parser-defs.h (struct parser_state) <start_arglist,
5263         end_arglist>: New methods.
5264         <arglist_len, m_funcall_chain>: New members.
5265         (arglist_len, start_arglist, end_arglist): Don't declare.
5266         * parse.c (arglist_len, funcall_chain): Remove global.
5267         (start_arglist, end_arglist): Remove functions.
5268         (parse_exp_in_context): Update.
5269         * p-exp.y: Update rules.
5270         * m2-exp.y: Update rules.
5271         * go-exp.y: Update rules.
5272         * f-exp.y: Update rules.
5273         * d-exp.y: Update rules.
5274         * c-exp.y: Update rules.
5275
5276 2019-04-04  Tom Tromey  <tom@tromey.com>
5277
5278         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
5279         lex_operator, push_back>: New methods.
5280         Update all rules.
5281         (rust_parser::lex_hex, lex_escape): Rename and update.
5282         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
5283         (rust_parser::lex_operator): Rename and update.
5284         (rust_parser::lex_number, rustyylex, rustyyerror)
5285         (rust_lex_test_init, rust_lex_test_sequence)
5286         (rust_lex_test_push_back, rust_lex_tests): Update.
5287         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
5288         parameter.
5289         <lexptr, prev_lexptr>: New members.
5290         (lexptr, prev_lexptr): Don't declare.
5291         * parse.c (lexptr, prev_lexptr): Remove globals.
5292         (parse_exp_in_context): Update.
5293         * p-exp.y (yylex, yyerror): Update.
5294         * m2-exp.y (parse_number, yylex, yyerror): Update.
5295         * go-exp.y (lex_one_token, yyerror): Update.
5296         * f-exp.y (match_string_literal, yylex, yyerror): Update.
5297         * d-exp.y (lex_one_token, yyerror): Update.
5298         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
5299         (lex_one_token, yyerror): Update.
5300         * ada-lex.l (YY_INPUT): Update.
5301         (rewind_to_char): Update.
5302         * ada-exp.y (yyerror): Update.
5303
5304 2019-04-04  Tom Tromey  <tom@tromey.com>
5305
5306         * rust-exp.y (rustyylex, rust_lex_tests): Update.
5307         * parser-defs.h (struct parser_state) <parser_state>: Add new
5308         parameter.
5309         <comma_terminates>: New member.
5310         (comma_terminates): Don't declare global.
5311         * parse.c (comma_terminates): Remove global.
5312         (parse_exp_in_context): Update.
5313         * p-exp.y (yylex): Update.
5314         * m2-exp.y (yylex): Update.
5315         * go-exp.y (lex_one_token): Update.
5316         * f-exp.y (yylex): Update.
5317         * d-exp.y (lex_one_token): Update.
5318         * c-exp.y (lex_one_token): Update.
5319         * ada-lex.l: Update.
5320
5321 2019-04-04  Tom Tromey  <tom@tromey.com>
5322
5323         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
5324         (rustyylex, rust_lex_test_init, rust_lex_test_one)
5325         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
5326         * parser-defs.h (paren_depth): Don't declare.
5327         * parse.c (paren_depth): Remove global.
5328         (parse_exp_in_context): Update.
5329         * p-exp.y (paren_depth): New global.
5330         (pascal_parse): Initialize it.
5331         * m2-exp.y (paren_depth): New global.
5332         (m2_parse): Initialize it.
5333         * go-exp.y (paren_depth): New global.
5334         (go_parse): Initialize it.
5335         * f-exp.y (paren_depth): New global.
5336         (f_parse): Initialize it.
5337         * d-exp.y (paren_depth): New global.
5338         (d_parse): Initialize it.
5339         * c-exp.y (paren_depth): New global.
5340         (c_parse): Initialize it.
5341         * ada-lex.l (paren_depth): New global.
5342         (lexer_init): Initialize it.
5343
5344 2019-04-04  Tom Tromey  <tom@tromey.com>
5345
5346         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
5347         (rust_parser::convert_ast_to_type)
5348         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5349         * parser-defs.h (struct parser_state) <parser_state>: Add
5350         parameters.  Initialize new members.
5351         <expression_context_block, expression_context_pc>: New members.
5352         * parse.c (expression_context_block, expression_context_pc):
5353         Remove globals.
5354         (parse_exp_in_context): Update.
5355         * p-exp.y: Update all rules.
5356         (yylex): Update.
5357         * m2-exp.y: Update all rules.
5358         (yylex): Update.
5359         * go-exp.y (yylex): Update.
5360         * f-exp.y (yylex): Update.
5361         * d-exp.y: Update all rules.
5362         (yylex): Update.
5363         * c-exp.y: Update all rules.
5364         (lex_one_token, classify_name, yylex, c_parse): Update.
5365         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
5366
5367 2019-04-04  Tom Tromey  <tom@tromey.com>
5368
5369         * gdbarch.h, gdbarch.c: Rebuild.
5370         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
5371         * stap-probe.h:
5372         (struct stap_parse_info): Replace "parser_state" with
5373         "expr_builder".
5374         * parser-defs.h (struct expr_builder): Rename from "parser_state".
5375         (parser_state): New class.
5376         * parse.c (expr_builder): Rename.
5377         (expr_builder::release): Rename.
5378         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
5379         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
5380         (write_exp_elt_longcst, write_exp_elt_floatcst)
5381         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
5382         (write_exp_string_vector, write_exp_bitstring)
5383         (write_exp_msymbol, mark_struct_expression)
5384         (write_dollar_variable)
5385         (insert_type_address_space, increase_expout_size): Replace
5386         "parser_state" with "expr_builder".
5387         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
5388         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
5389         "parser_state" with "expr_builder".
5390
5391 2019-04-04  Tom Tromey  <tom@tromey.com>
5392
5393         * rust-exp.y: Replace "parse_language" with method call.
5394         * p-exp.y:
5395         (yylex): Replace "parse_language" with method call.
5396         * m2-exp.y:
5397         (yylex): Replace "parse_language" with method call.
5398         * go-exp.y (classify_name): Replace "parse_language" with method
5399         call.
5400         * f-exp.y (yylex): Replace "parse_language" with method call.
5401         * d-exp.y (lex_one_token): Replace "parse_language" with method
5402         call.
5403         * c-exp.y:
5404         (lex_one_token, classify_name, yylex): Replace "parse_language"
5405         with method call.
5406         * ada-exp.y (find_primitive_type, type_char)
5407         (type_system_address): Replace "parse_language" with method call.
5408
5409 2019-04-04  Tom Tromey  <tom@tromey.com>
5410
5411         * rust-exp.y: Replace "parse_gdbarch" with method call.
5412         * parse.c (write_dollar_variable, insert_type_address_space):
5413         Replace "parse_gdbarch" with method call.
5414         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
5415         call.
5416         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
5417         call.
5418         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
5419         "parse_gdbarch" with method call.
5420         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
5421         with method call.
5422         * f-exp.y (parse_type, parse_f_type, yylex): Replace
5423         "parse_gdbarch" with method call.
5424         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
5425         "parse_gdbarch" with method call.
5426         * c-exp.y (parse_type, parse_number, classify_name): Replace
5427         "parse_gdbarch" with method call.
5428         * ada-lex.l: Replace "parse_gdbarch" with method call.
5429         * ada-exp.y (parse_type, find_primitive_type, type_char)
5430         (type_system_address): Replace "parse_gdbarch" with method call.
5431
5432 2019-04-04  Tom Tromey  <tom@tromey.com>
5433
5434         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
5435         * stap-probe.c (stap_parse_argument): Update.
5436         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
5437         initial_size parameter.
5438         * rust-exp.y (rust_lex_tests): Update.
5439         * parse.c (parser_state): Update.
5440         (parse_exp_in_context): Update.
5441         * parser-defs.h (struct parser_state) <parser_state>: Remove
5442         "initial_size" parameter.
5443
5444 2019-04-04  Tom Tromey  <tom@tromey.com>
5445
5446         * parser-defs.h (increase_expout_size): Don't declare.
5447         * parse.c (increase_expout_size): Now static.
5448
5449 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
5450
5451         * gnu-nat.c (gnu_nat_target::wait): Fix
5452         target_waitstatus_to_string call.
5453
5454 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5455
5456         * eval.c (evaluate_subexp_standard): Handle internal functions
5457         during Fortran function call handling.
5458
5459 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5460
5461         * NEWS: Mention new internal functions.
5462         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
5463         (read_base_type): Use dwarf2_init_complex_target_type.
5464         * value.c (creal_internal_fn): New function.
5465         (cimag_internal_fn): New function.
5466         (_initialize_values): Register new internal functions.
5467
5468 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5469
5470         * infrun.c (stop_all_threads): If debug_infrun, always
5471         trace the wait status after wait_one, using
5472         target_waitstatus_to_string and target_pid_to_str.
5473         (handle_inferior_event): Replace various trace of
5474         wait status kind by a single trace.
5475         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
5476         wait status kind image by target_waitstatus_to_string.
5477         * target/waitstatus.c (target_waitstatus_to_string): Fix
5478         obsolete comment.
5479
5480 2019-04-01  Tom Tromey  <tromey@adacore.com>
5481
5482         PR symtab/23331:
5483         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
5484
5485 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5486             Pedro Alves  <palves@redhat.com>
5487
5488         * top.c (quit_force): Call 'finalize_values'.
5489         * value.c (finalize_values): New function.
5490         * value.h (finalize_values): Declare.
5491
5492 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
5493
5494         * NEWS: Announce $_gdb_major and $_gdb_minor.
5495
5496         * top.c (init_gdb_version_vars): New function.
5497         (gdb_init): Call init_gdb_version_vars.
5498
5499 2019-03-29  Tom Tromey  <tromey@adacore.com>
5500
5501         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
5502         help text.  Remove dead code.
5503
5504 2019-03-29  Keith Seitz  <keiths@redhat.com>
5505
5506         From Siddhesh Poyarekar:
5507         * f-lang.h (f77_get_upperbound): Return LONGEST.
5508         (f77_get_lowerbound): Likewise.
5509         * f-typeprint.c (f_type_print_varspec_suffix): Expand
5510         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
5511         print them.
5512         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
5513         plongest to format print it.
5514         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
5515         (f77_get_upperbound): Likewise.
5516         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
5517         LOWER_BOUND to LONGEST.
5518         (f77_create_arrayprint_offset_tbl): Likewise.
5519
5520 2019-03-29  Keith Seitz  <keiths@redhat.com>
5521
5522         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
5523         %s/pulongest for TYPE_LENGTH instead of %d in format
5524         strings.
5525         * ada-typerint.c (ada_print_type): Likewise.
5526         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
5527         * compile/compile-c-support.c (generate_register_struct): Likewise.
5528         * gdbtypes.c (recursive_dump_type): Likewise.
5529         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
5530         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
5531         instead of %d in format strings.
5532         * riscv-tdep.c (riscv_type_alignment): Cast second argument
5533         to std::min to ULONGEST.
5534         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
5535         instead of %d in format strings.
5536         * tracepoint.c (info_scope_command): Likewise.
5537         * typeprint.c (print_offset_data::update)
5538         (print_offset_data::finish): Likewise.
5539         * xtensa-tdep.c (xtensa_store_return_value)
5540         (xtensa_push_dummy_call): Likewise.
5541
5542 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
5543
5544         * windows-nat.c (display_selector): Fixed format specifications
5545         for 64-bit Cygwin.
5546
5547 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5548
5549         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
5550
5551 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
5552
5553         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
5554         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
5555         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
5556         (nios2_linux_init_abi): Install it.
5557
5558 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5559
5560         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
5561
5562 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5563
5564         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
5565
5566 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5567             Tom Tromey  <tromey@adacore.com>
5568
5569         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
5570
5571 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
5572
5573         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
5574         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
5575         method to compute the bounds of range types. Also print "[evaluated]"
5576         if the bounds' values come from a dynamic evaluation.
5577
5578 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5579
5580         * cp-valprint.c (cp_print_value_fields): Don't print trailing
5581         whitespace when pretty printing is on.
5582
5583 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5584
5585         * ppc-linux-nat.c: Add include.
5586
5587 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5588
5589         * NEWS: Mention AArch64 Pointer Authentication.
5590
5591 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5592
5593         * arm-linux-nat.c: Add include.
5594
5595 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
5596
5597         * source-cache.c (source_cache::get_source_lines): Re-read
5598         fullname after calling open_source_file.
5599
5600 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
5601
5602         * NEWS: Mention TLS support for FreeBSD.
5603
5604 2019-03-25  Tom Tromey  <tromey@adacore.com>
5605
5606         * minsyms.c (BUNCH_SIZE): Update comment.
5607         (~minimal_symbol_reader): Remove old comment.
5608         (compact_minimal_symbols): Update comment.
5609         (minimal_symbol_reader::install): Remove old comment.  Update
5610         other comments.
5611
5612 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5613
5614         * s390-linux-nat.c: Add include.
5615
5616 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5617
5618         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5619         Call linux_get_hwcap.
5620         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
5621         Likewise.
5622         (aarch64_linux_get_hwcap): Remove function.
5623         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
5624         declaration.
5625         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
5626         linux_get_hwcap.
5627         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5628         * linux-tdep.c (linux_get_hwcap): Add function.
5629         (linux_get_hwcap2): Likewise.
5630         * linux-tdep.h (linux_get_hwcap): Add declaration.
5631         (linux_get_hwcap2): Likewise.
5632         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
5633         (ppc_linux_get_hwcap2): Likewise.
5634         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
5635         linux_get_hwcap.
5636         (ppc_linux_nat_target::insert_watchpoint): Likewise.
5637         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
5638         (ppc_linux_nat_target::read_description): Likewise.
5639         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
5640         * s390-linux-nat.c: Likewise.
5641         * s390-linux-tdep.c (s390_core_read_description): Likewise.
5642
5643 2019-03-24  Tom Tromey  <tom@tromey.com>
5644
5645         * ada-lang.c (standard_lookup): Simplify initialization.
5646         (ada_lookup_symbol_nonlocal): Simplify return.
5647         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
5648         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
5649         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
5650         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
5651         initialization.
5652         * solib.c (solib_global_lookup): Simplify.
5653         * symtab.c (null_block_symbol): Remove.
5654         (symbol_cache_lookup): Simplify returns.
5655         (lookup_language_this): Simplify returns.
5656         (lookup_symbol_aux): Simplify return.
5657         (lookup_local_symbol): Simplify returns.
5658         (lookup_global_symbol_from_objfile): Simplify return.
5659         (lookup_symbol_in_objfile_symtabs)
5660         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
5661         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
5662         (lookup_static_symbol, lookup_global_symbol): Simplify return.
5663         * cp-namespace.c (cp_lookup_bare_symbol)
5664         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
5665         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
5666         (cp_lookup_nested_symbol): Don't use null_block_symbol.
5667         (cp_lookup_symbol_via_imports): Simplify initialization.
5668         (find_symbol_in_baseclass): Likewise.
5669         * symtab.h (null_block_symbol): Remove.
5670         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
5671         (d_lookup_nested_symbol, d_lookup_symbol_imports)
5672         (d_lookup_symbol_module): Likewise.
5673         (find_symbol_in_baseclass): Simplify initialization.
5674
5675 2019-03-24  Tom Tromey  <tom@tromey.com>
5676
5677         * expression.h: Don't include symtab.h.
5678         (struct block): Forward declare.
5679
5680 2019-03-24  Tom Tromey  <tom@tromey.com>
5681
5682         * c-exp.y (typebase): Remove casts.
5683         * gdbtypes.c (lookup_unsigned_typename, )
5684         (lookup_signed_typename): Remove cast.
5685         * eval.c (parse_to_comma_and_eval): Remove cast.
5686         * parse.c (write_dollar_variable): Remove cast.
5687         * block.h (struct block) <superblock>: Now const.
5688         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
5689         * psymtab.c (psym_map_matching_symbols): Make "block" const.
5690         (map_block): Make "block" const.
5691         * symfile.h (struct quick_symbol_functions)
5692         <map_matching_symbols>: Constify block argument to "callback".
5693         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
5694         const.
5695         (find_pc_sect_compunit_symtab): Make "b" const.
5696         (find_symbol_at_address): Likewise.
5697         (search_symbols): Likewise.
5698         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
5699         (dw2_debug_names_lookup_symbol): Likewise.
5700         (dw2_map_matching_symbols): Update.
5701         * p-valprint.c (pascal_val_print): Remove "block".
5702         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
5703         (aux_add_nonlocal_symbols): Make "block" const.
5704         (resolve_subexp): Remove cast.
5705         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
5706         const.
5707         (iterate_over_file_blocks): Likewise.
5708         * f-exp.y (%union) <bval>: Remove.
5709         * coffread.c (patch_opaque_types): Make "b" const.
5710         * spu-tdep.c (spu_catch_start): Make "block" const.
5711         * c-valprint.c (print_unpacked_pointer): Remove "block".
5712         * symmisc.c (dump_symtab_1): Make "b" const.
5713         (block_depth): Make "block" const.
5714         * d-exp.y (%union) <bval>: Remove.
5715         * cp-support.h (cp_lookup_rtti_type): Update.
5716         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
5717         * psymtab.c (psym_lookup_symbol): Make "block" const.
5718         (maintenance_check_psymtabs): Make "b" const.
5719         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
5720         (enumerate_locals, enumerate_args): Update.
5721         * python/py-symtab.c (stpy_global_block): Make "block" const.
5722         (stpy_static_block): Likewise.
5723         * inline-frame.c (block_starting_point_at): Make "new_block"
5724         const.
5725         * block.c (find_block_in_blockvector): Make return type const.
5726         (blockvector_for_pc_sect): Make "b" const.
5727         (find_block_in_blockvector): Make "b" const.
5728
5729 2019-03-23  Tom Tromey  <tom@tromey.com>
5730
5731         * varobj.c (varobj_create): Update.
5732         * symfile.c (clear_symtab_users): Don't reset innermost_block.
5733         * printcmd.c (display_command, do_one_display): Don't reset
5734         innermost_block.
5735         * parser-defs.h (enum innermost_block_tracker_type): Move to
5736         expression.h.
5737         (innermost_block): Update comment.
5738         * parse.c (parse_exp_1): Add tracker_types parameter.
5739         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
5740         tracker_types parameter.  Reset innermost_block.
5741         (parse_exp_in_context): Remove.
5742         (parse_expression_for_completion): Update.
5743         * objfiles.c (~objfile): Don't reset expression_context_block or
5744         innermost_block.
5745         * expression.h (enum innermost_block_tracker_type): Move from
5746         parser-defs.h.
5747         (parse_exp_1): Add tracker_types parameter.
5748         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
5749         reset innermost_block.
5750
5751 2019-03-23  Tom Tromey  <tom@tromey.com>
5752
5753         * objfiles.h: Include bcache.h.
5754
5755 2019-03-23  Tom Tromey  <tom@tromey.com>
5756
5757         * linespec.c (get_current_search_block): Use
5758         scoped_restore_current_language.
5759         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
5760
5761 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5762             Jiong Wang  <jiong.wang@arm.com>
5763
5764         * aarch64-linux-tdep.c
5765         (aarch64_linux_iterate_over_regset_sections): Check for pauth
5766         section.
5767         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
5768
5769 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5770             Jiong Wang  <jiong.wang@arm.com>
5771
5772         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
5773         instructions.
5774         (aarch64_analyze_prologue_test): Add PACIASP test.
5775         (aarch64_prologue_prev_register): Unmask PC value.
5776
5777 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5778             Jiong Wang  <jiong.wang@arm.com>
5779
5780         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
5781         (aarch64_dwarf2_prev_register): Unmask PC value.
5782         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
5783         (aarch64_execute_dwarf_cfa_vendor_op): Check for
5784         DW_CFA_AARCH64_negate_ra_state.
5785         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
5786
5787 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5788             Jiong Wang  <jiong.wang@arm.com>
5789
5790         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
5791         registers.
5792         (aarch64_pseudo_register_name): Likewise.
5793         (aarch64_pseudo_register_type): Likewise.
5794         (aarch64_pseudo_register_reggroup_p): Likewise.
5795         (aarch64_gdbarch_init): Add pauth registers.
5796         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
5797         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
5798         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
5799         (struct gdbarch_tdep): Add regnum for ra_state.
5800
5801 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5802             Jiong Wang  <jiong.wang@arm.com>
5803
5804         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
5805
5806 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5807             Jiong Wang  <jiong.wang@arm.com>
5808
5809         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
5810         function.
5811         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
5812         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
5813         (aarch64_gdbarch_init): Add puth registers.
5814         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
5815         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
5816         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
5817
5818 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5819             Jiong Wang  <jiong.wang@arm.com>
5820
5821         * aarch64-linux-nat.c
5822         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
5823         * aarch64-linux-tdep.c
5824         (aarch64_linux_core_read_description): Likewise.
5825         (aarch64_linux_get_hwcap): New function.
5826         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
5827         (aarch64_linux_get_hwcap): New declaration.
5828
5829 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5830             Jiong Wang  <jiong.wang@arm.com>
5831
5832         * aarch64-linux-nat.c
5833         (aarch64_linux_nat_target::read_description): Add pauth param.
5834         * aarch64-linux-tdep.c
5835         (aarch64_linux_core_read_description): Likewise.
5836         * aarch64-tdep.c (struct target_desc): Add in pauth.
5837         (aarch64_read_description): Add pauth param.
5838         (aarch64_gdbarch_init): Likewise.
5839         * aarch64-tdep.h (aarch64_read_description): Likewise.
5840         * arch/aarch64.c (aarch64_create_target_description): Likewise.
5841         * arch/aarch64.h (aarch64_create_target_description): Likewise.
5842         * features/Makefile: Add new files.
5843         * features/aarch64-pauth.c: New file.
5844         * features/aarch64-pauth.xml: New file.
5845
5846 2019-03-20  Tom Tromey  <tromey@adacore.com>
5847
5848         * infrun.c (handle_inferior_event): Rename from
5849         handle_inferior_event_1.  Create a scoped_value_mark.
5850         (handle_inferior_event): Remove.
5851
5852 2019-03-19  Tom Tromey  <tromey@adacore.com>
5853
5854         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
5855         * infrun.h (print_stop_event): Add "displays" parameter.
5856         * infrun.c (print_stop_event): Add "displays" parameter.
5857
5858 2019-03-19  Pedro Alves  <palves@redhat.com>
5859
5860         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
5861         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
5862         to -1.  Fix TABs vs spaces.
5863         (tui_ui_out::tui_ui_out): Don't initialize fields here.
5864         * tui/tui-out.h (tui_ui_out) Add intro comments.
5865         <m_line, m_start_of_line>: In-class initialize, and add describing
5866         comment.
5867
5868 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
5869
5870         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
5871         variable names.
5872         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
5873
5874 2019-03-18  Pedro Alves  <palves@redhat.com>
5875             Eli Zaretskii <eliz@gnu.org>
5876
5877         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
5878         m_line and m_start_of_line.
5879
5880 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
5881
5882         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
5883         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
5884         it returns a newline.  This fixes a regression in TU mode, whereby
5885         the next line is output on the same screen line as the user input.
5886
5887 2019-03-18  Tom Tromey  <tromey@adacore.com>
5888
5889         * minsyms.c (minimal_symbol_reader::install): Remove call to
5890         obstack_blank.
5891
5892 2019-03-18  Pedro Alves  <palves@redhat.com>
5893
5894         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
5895         New globals.
5896         (apply_style): New, factored out from ...
5897         (apply_ansi_escape): ... this.  Handle reverse video mode.
5898         (tui_set_reverse_mode): New function.
5899         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
5900         * tui/tui-winsource.c (tui_show_source_line): Use
5901         tui_set_reverse_mode instead of setting A_STANDOUT.
5902         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
5903         New setter methods.
5904
5905 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
5906
5907         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
5908         Handle tabs.
5909
5910 2019-03-18  Tom Tromey  <tromey@adacore.com>
5911
5912         * ada-lang.c (empty_array): Add "high" parameter.
5913         (ada_evaluate_subexp): Update.
5914
5915 2019-03-17  Sergei Trofimovich <siarheit@google.com>
5916
5917         * unittests/string_view-selftests.c: Define
5918         _initialize_string_view_selftests unconditionally.
5919
5920 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5921
5922         PR gdb/24350
5923         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
5924
5925 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5926
5927         PR gdb/24351
5928         * windows-nat.c (display_selector): Fix format specifiers.
5929
5930 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
5931
5932         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
5933         tui_refill_source_window instead of tui_refresh_win, to update the
5934         current execution line.  This fixes redisplay of the current line
5935         when stepping through the code with "next" or "step".
5936
5937 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5938
5939         * source-cache.c (source_cache::get_source_lines): Call
5940         find_source_lines to initialize s->nlines.  This fixes vertical
5941         scrolling of TUI source window when the DOWN arrow is pressed.
5942
5943 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5944
5945         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
5946         linux-thread-db.c (_initialize_thread_db): Likewise.
5947
5948 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5949
5950         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
5951         wclrtoeol in tui_show_source_line".  This reverts changes made in
5952         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
5953
5954 2019-03-15  Tom Tromey  <tom@tromey.com>
5955
5956         * symtab.h (struct minimal_symbol): Derive from
5957         general_symbol_info.
5958         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
5959         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
5960         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
5961         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
5962         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
5963         (MSYMBOL_SEARCH_NAME): Update.
5964         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
5965         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
5966         * minsyms.c (minimal_symbol_reader::record_full): Update.
5967
5968 2019-03-15  Tom Tromey  <tom@tromey.com>
5969
5970         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
5971
5972 2019-03-15  Tom Tromey  <tom@tromey.com>
5973
5974         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
5975         unique_xmalloc_ptr.
5976         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
5977         Update.
5978         * minsyms.c (lookup_minimal_symbol_by_pc_section)
5979         (build_minimal_symbol_hash_tables)
5980         (minimal_symbol_reader::install): Update.
5981
5982 2019-03-15  Tom Tromey  <tom@tromey.com>
5983
5984         * symtab.c (create_demangled_names_hash): Update.
5985         (symbol_set_names): Update.
5986         * objfiles.h (struct objfile_per_bfd_storage)
5987         <demangled_names_hash>: Now an htab_up.
5988         * objfiles.c (objfile_per_bfd_storage): Simplify.
5989
5990 2019-03-15  Tom Tromey  <tom@tromey.com>
5991
5992         * objfiles.h (struct objfile_per_bfd_storage): Declare
5993         destructor.
5994         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
5995         New.
5996         (get_objfile_bfd_data): Use new.  Don't initialize
5997         language_of_main.
5998         (free_objfile_per_bfd_storage): Remove.
5999         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6000
6001 2019-03-15  Tom Tromey  <tom@tromey.com>
6002
6003         * symfile.c (reread_symbols): Update.
6004         * objfiles.c (objfile::objfile): Update.
6005         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6006         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6007         comment.
6008         (minimal_symbol_reader::install): Update.
6009         (terminate_minimal_symbol_table): Remove.
6010         * jit.c (jit_object_close_impl): Update.
6011
6012 2019-03-15  Tom Tromey  <tom@tromey.com>
6013
6014         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6015         initializations.
6016
6017 2019-03-15  Tom Tromey  <tom@tromey.com>
6018
6019         * objfiles.h (struct objfile_per_bfd_storage)
6020         <demangled_hash_languages>: Now a bitset.
6021         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6022         (lookup_minimal_symbol): Update.
6023
6024 2019-03-15  Tom Tromey  <tom@tromey.com>
6025
6026         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6027         Don't return the symbol.
6028         * coffread.c (record_minimal_symbol): Use record_full.
6029
6030 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6031
6032         The MS-Windows port of ncurses fails to switch to a color pair if
6033         one or both of the colors are the implicit default colors.  This
6034         change records the default colors when TUI is initialized, and
6035         then specifies them explicitly when a color pair uses the default
6036         colors.  This allows color styling in TUI mode on MS-Windows.
6037
6038         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6039         ncurses_norm_attr.
6040         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6041         colors in ncurses_norm_attr.
6042         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6043         "none", replace it with the default color recorded in
6044         ncurses_norm_attr.
6045
6046 2019-03-14  Tom Tromey  <tromey@adacore.com>
6047
6048         * source-cache.h (class source_cache) <get_source_lines>: Return
6049         std::string.
6050         * source-cache.c (source_cache::extract_lines): Handle case where
6051         first_pos==npos.  Return std::string.
6052         (source_cache::get_source_lines): Update.
6053
6054 2019-03-14  Tom Tromey  <tromey@adacore.com>
6055
6056         * NEWS: Add item for "style sources" commands.
6057         * source-cache.c (source_cache::get_source_lines): Check
6058         source_styling.
6059         * cli/cli-style.c (source_styling): New global.
6060         (_initialize_cli_style): Add "style sources" commands.
6061         (show_style_sources): New function.
6062         * cli/cli-style.h (source_styling): Declare.
6063
6064 2019-03-14  Pedro Alves  <palves@redhat.com>
6065             Tom Tromey  <tromey@adacore.com>
6066
6067         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6068         * tui/tui-winsource.c (tui_refill_source_window): New function,
6069         from...
6070         (tui_horizontal_source_scroll): ... here.  Move some logic.
6071         * cli/cli-style.c (set_style_enabled): Notify new observable.
6072         * tui/tui-hooks.c (tui_redisplay_source): New function.
6073         (tui_attach_detach_observers): Attach or detach
6074         tui_redisplay_source.
6075         * observable.h (source_styling_changed): New observable.
6076         * observable.c: Define source_styling_changed observable.
6077
6078 2019-03-13  Tom Tromey  <tromey@adacore.com>
6079
6080         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6081         (i386_gnu_nat_target::store_registers): Update.
6082         * target-debug.h (target_debug_print_std_string): New macro.
6083         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6084         * windows-tdep.c (display_one_tib): Update.
6085         * tui/tui-stack.c (tui_make_status_line): Update.
6086         * top.c (print_inferior_quit_action): Update.
6087         * thread.c (thr_try_catch_cmd): Update.
6088         (add_thread_with_info): Update.
6089         (thread_target_id_str): Update.
6090         (thr_try_catch_cmd): Update.
6091         (thread_command): Update.
6092         (thread_find_command): Update.
6093         * record-btrace.c (record_btrace_target::info_record)
6094         (record_btrace_resume_thread, record_btrace_target::resume)
6095         (record_btrace_cancel_resume, record_btrace_step_thread)
6096         (record_btrace_target::wait, record_btrace_target::wait)
6097         (record_btrace_target::wait, record_btrace_target::stop): Update.
6098         * progspace.c (print_program_space): Update.
6099         * process-stratum-target.c
6100         (process_stratum_target::thread_address_space): Update.
6101         * linux-fork.c (linux_fork_mourn_inferior)
6102         (detach_checkpoint_command, info_checkpoints_command)
6103         (linux_fork_context): Update.
6104         (linux_fork_detach): Update.
6105         (class scoped_switch_fork_info): Update.
6106         (delete_checkpoint_command): Update.
6107         * infrun.c (follow_fork_inferior): Update.
6108         (follow_fork_inferior): Update.
6109         (proceed_after_vfork_done): Update.
6110         (handle_vfork_child_exec_or_exit): Update.
6111         (follow_exec): Update.
6112         (displaced_step_prepare_throw): Update.
6113         (displaced_step_restore): Update.
6114         (start_step_over): Update.
6115         (resume_1): Update.
6116         (clear_proceed_status_thread): Update.
6117         (proceed): Update.
6118         (print_target_wait_results): Update.
6119         (do_target_wait): Update.
6120         (context_switch): Update.
6121         (stop_all_threads): Update.
6122         (restart_threads): Update.
6123         (finish_step_over): Update.
6124         (handle_signal_stop): Update.
6125         (switch_back_to_stepped_thread): Update.
6126         (keep_going_pass_signal): Update.
6127         (print_exited_reason): Update.
6128         (normal_stop): Update.
6129         * inferior.c (inferior_pid_to_str): Change return type.
6130         (print_selected_inferior): Update.
6131         (add_inferior): Update.
6132         (detach_inferior): Update.
6133         * dummy-frame.c (fprint_dummy_frames): Update.
6134         * dcache.c (dcache_info_1): Update.
6135         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6136         (btrace_fetch, btrace_clear): Update.
6137         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6138         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6139         type.
6140         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6141         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6142         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6143         * gdbarch.c, gdbarch.h: Rebuild.
6144         * gdbarch.sh (core_pid_to_str): Change return type.
6145         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6146         return type.
6147         (windows_nat_target::pid_to_str): Change return type.
6148         (windows_delete_thread): Update.
6149         (windows_nat_target::attach): Update.
6150         (windows_nat_target::files_info): Update.
6151         * target-delegates.c: Rebuild.
6152         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6153         return type.
6154         (sol_thread_target::pid_to_str): Change return type.
6155         * remote.c (class remote_target) <pid_to_str>: Change return
6156         type.
6157         (remote_target::pid_to_str): Change return type.
6158         (extended_remote_target::attach, remote_target::remote_stop_ns)
6159         (remote_target::remote_notif_remove_queued_reply)
6160         (remote_target::push_stop_reply, remote_target::disable_btrace):
6161         Update.
6162         (extended_remote_target::attach): Update.
6163         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6164         type.
6165         (gdbsim_target::pid_to_str): Change return type.
6166         * ravenscar-thread.c (struct ravenscar_thread_target)
6167         <pid_to_str>: Change return type.
6168         (ravenscar_thread_target::pid_to_str): Change return type.
6169         * procfs.c (class procfs_target) <pid_to_str>: Change return
6170         type.
6171         (procfs_target::pid_to_str): Change return type.
6172         (procfs_target::attach): Update.
6173         (procfs_target::detach): Update.
6174         (procfs_target::fetch_registers): Update.
6175         (procfs_target::store_registers): Update.
6176         (procfs_target::wait): Update.
6177         (procfs_target::files_info): Update.
6178         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6179         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6180         return type.
6181         (nto_procfs_target::pid_to_str): Change return type.
6182         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6183         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6184         return type.
6185         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6186         (exit_lwp): Update.
6187         (attach_proc_task_lwp_callback, get_detach_signal)
6188         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6189         (linux_nat_target::resume, wait_lwp, stop_callback)
6190         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6191         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6192         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6193         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6194         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6195         type.
6196         (inf_ptrace_target::attach): Update.
6197         (inf_ptrace_target::files_info): Update.
6198         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6199         type.
6200         (go32_nat_target::pid_to_str): Change return type.
6201         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6202         (gnu_nat_target::wait): Update.
6203         (gnu_nat_target::wait): Update.
6204         (gnu_nat_target::resume): Update.
6205         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6206         (fbsd_nat_target::wait): Update.
6207         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6208         type.
6209         (darwin_nat_target::attach): Update.
6210         * corelow.c (class core_target) <pid_to_str>: Change return type.
6211         (core_target::pid_to_str): Change return type.
6212         * target.c (normal_pid_to_str): Change return type.
6213         (default_pid_to_str): Likewise.
6214         (target_pid_to_str): Change return type.
6215         (target_translate_tls_address): Update.
6216         (target_announce_detach): Update.
6217         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6218         return type.
6219         (bsd_uthread_target::pid_to_str): Change return type.
6220         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6221         type.
6222         (bsd_kvm_target::pid_to_str): Change return type.
6223         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6224         return type.
6225         (aix_thread_target::pid_to_str): Change return type.
6226         * target.h (struct target_ops) <pid_to_str>: Change return type.
6227         (target_pid_to_str, normal_pid_to_str): Likewise.
6228         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6229         type.
6230         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6231         type.
6232         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6233         return type.
6234         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6235         type.
6236         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6237         type.
6238         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6239         return type.
6240
6241 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6242
6243         * NEWS: Mention that the new default MI version is 3.  Mention
6244         changes to the output of commands and events that deal with
6245         multi-location breakpoints.
6246         * breakpoint.c: Include "mi/mi-out.h".
6247         (print_one_breakpoint): Change output syntax if using MI version
6248         >= 3.
6249         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6250         New.
6251         (mi_multi_location_breakpoint_output_fixed): New.
6252         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6253         (mi_cmd_fix_multi_location_breakpoint_output): New.
6254         (mi_multi_location_breakpoint_output_fixed): New.
6255         * mi/mi-cmds.c (mi_cmds): Register command
6256         -fix-multi-location-breakpoint-output.
6257         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6258         interpreter "mi".
6259
6260 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6261
6262         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6263         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6264         instantiate mi_ui_out based on interpreter name.
6265         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6266         * mi/mi-main.c (mi_load_progress): Likewise.
6267
6268 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6269
6270         * NEWS: Combine separate "New targets" sections for 8.3.
6271
6272 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6273
6274         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6275         (ppcfbsd_init_abi): Install gdbarch
6276         "fetch_tls_load_module_address" and "get_thread_local_address"
6277         methods.
6278
6279 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6280
6281         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
6282         (riscv_fbsd_init_abi): Install gdbarch
6283         "fetch_tls_load_module_address" and "get_thread_local_address"
6284         methods.
6285
6286 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6287
6288         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
6289         (i386fbsd_init_abi): Install gdbarch
6290         "fetch_tls_load_module_address" and "get_thread_local_address"
6291         methods.
6292
6293 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6294
6295         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
6296         (amd64fbsd_init_abi): Install gdbarch
6297         "fetch_tls_load_module_address" and "get_thread_local_address"
6298         methods.
6299
6300 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6301
6302         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
6303         (struct fbsd_pspace_data): New type.
6304         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
6305         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
6306         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
6307         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
6308         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
6309
6310 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6311
6312         * gdbtypes.c (lookup_struct_elt): New function.
6313         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
6314         * gdbtypes.h (struct struct_elt): New type.
6315         (lookup_struct_elt): New prototype.
6316
6317 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6318
6319         * gdbtypes.c (lookup_struct_elt_type): Update comment and
6320         remove disabled code block.
6321
6322 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6323
6324         * gdbarch.sh (get_thread_local_address): New method.
6325         * gdbarch.h, gdbarch.c: Regenerate.
6326         * target.c (target_translate_tls_address): Use
6327         gdbarch_get_thread_local_address if present instead of
6328         target::get_thread_local_address.
6329
6330 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6331
6332         * target.h (target::get_thread_local_address): Update comment.
6333
6334 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6335
6336         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
6337         objfile->separate_debug_objfile_backlink if not NULL.
6338
6339 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6340
6341         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6342         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
6343         (amd64bsd_store_inferior_registers): Likewise.
6344         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6345         Enable segment base registers.
6346         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
6347         PT_GETFSBASE and PT_GETGSBASE.
6348         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
6349         PT_SETGSBASE.
6350         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
6351         segment base registers.
6352         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6353
6354 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6355
6356         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6357         Update calls to i386_target_description to add 'segments'
6358         parameter.
6359         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
6360         add segment base registers.
6361         * arch/i386.c (i386_create_target_description): Add 'segments'
6362         parameter to enable segment base registers.
6363         * arch/i386.h (i386_create_target_description): Likewise.
6364         * features/i386/32bit-segments.xml: New file.
6365         * features/i386/32bit-segments.c: Generate.
6366         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
6367         call to i386_target_description to add 'segments' parameter.
6368         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6369         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
6370         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
6371         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
6372         if feature is present.
6373         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
6374         Add 'segments' parameter to call to i386_target_description.
6375         (i386_target_description): Add 'segments' parameter to enable
6376         segment base registers.
6377         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
6378         to call to i386_target_description.
6379         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
6380         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
6381         Define I386_NUM_REGS.
6382         (i386_target_description): Add 'segments' parameter to enable
6383         segment base registers.
6384
6385 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
6386
6387         PR/24325
6388         * source-cache.c: #undef open and close, to avoid unresolved
6389         externals during linking.
6390
6391 2019-03-12  Tom Tromey  <tromey@adacore.com>
6392
6393         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
6394         const.  Add initializers.
6395         (_initialize_remote): Don't initialize ptid globals.
6396
6397 2019-03-12  Pedro Alves  <palves@redhat.com>
6398
6399         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
6400
6401 2019-03-12  Pedro Alves  <palves@redhat.com>
6402
6403         * cp-name-parser.y (main): Remove unused 'len' variable.
6404
6405 2019-03-12  Tom Tromey  <tromey@adacore.com>
6406
6407         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
6408         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
6409
6410 2019-03-12  Tom Tromey  <tromey@adacore.com>
6411
6412         * linux-nat.c (iterate_over_lwps): Update.
6413         (stop_callback): Remove parameter.
6414         (stop_wait_callback, detach_callback, resume_set_callback)
6415         (select_singlestep_lwp_callback, set_ignore_sigint)
6416         (status_callback, resumed_callback, resume_clear_callback)
6417         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
6418         data parameter.
6419         (linux_nat_target::detach, linux_nat_target::resume)
6420         (linux_stop_and_wait_all_lwps, select_event_lwp)
6421         (linux_nat_filter_event, linux_nat_wait_1)
6422         (linux_nat_target::kill, linux_nat_target::stop)
6423         (linux_nat_target::stop): Update.
6424         (linux_nat_resume_callback): Change type.
6425         (resume_stopped_resumed_lwps, count_events_callback)
6426         (select_event_lwp_callback): Likewise.
6427         (linux_stop_lwp, linux_nat_stop_lwp): Update.
6428         * arm-linux-nat.c (struct update_registers_data): Remove.
6429         (update_registers_callback): Change type.
6430         (arm_linux_insert_hw_breakpoint1): Update.
6431         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
6432         parameter.
6433         (x86_linux_dr_set_addr): Update.
6434         (x86_linux_dr_set_control): Update.
6435         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
6436         (iterate_over_lwps): Use gdb::function_view.
6437         * nat/aarch64-linux-hw-point.c (struct
6438         aarch64_dr_update_callback_param): Remove.
6439         (debug_reg_change_callback): Change type.
6440         (aarch64_notify_debug_reg_change): Update.
6441         * s390-linux-nat.c (s390_refresh_per_info): Update.
6442
6443 2019-03-11  Tom Tromey  <tromey@adacore.com>
6444
6445         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
6446         redundant assignment to "this_cu".
6447
6448 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6449
6450         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
6451
6452 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6453
6454         * gdbtypes.c (rank_one_type_parm_set): New function extracted
6455         from...
6456         (rank_one_type): ... this.
6457
6458 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6459
6460         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
6461         from...
6462         (rank_one_type): ... this.
6463
6464 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6465
6466         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
6467         from...
6468         (rank_one_type): ... this.
6469
6470 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6471
6472         * gdbtypes.c (rank_one_type_parm_float): New function extracted
6473         from...
6474         (rank_one_type): ... this.
6475
6476 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6477
6478         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
6479         from...
6480         (rank_one_type): ... this.
6481
6482 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6483
6484         * gdbtypes.c (rank_one_type_parm_range): New function extracted
6485         from...
6486         (rank_one_type): ... this.
6487
6488 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6489
6490         * gdbtypes.c (rank_one_type_parm_char): New function extracted
6491         from...
6492         (rank_one_type): ... this.
6493
6494 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6495
6496         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
6497         from...
6498         (rank_one_type): ... this.
6499
6500 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6501
6502         * gdbtypes.c (rank_one_type_parm_int): New function extracted
6503         from...
6504         (rank_one_type): ... this.
6505
6506 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6507
6508         * gdbtypes.c (rank_one_type_parm_func): New function extracted
6509         from...
6510         (rank_one_type): ... this.
6511
6512 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6513
6514         * gdbtypes.c (rank_one_type_parm_array): New function extracted
6515         from...
6516         (rank_one_type): ... this.
6517
6518 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6519
6520         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
6521         from...
6522         (rank_one_type): ... this.
6523
6524 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6525
6526         * inferior.c (initialize_inferiors): Ensure 'help set/show print
6527         inferior-events' shows the example events.
6528
6529 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
6530
6531         Support styling on native MS-Windows console
6532
6533         PR/24315
6534         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
6535         on MS-Windows if $TERM is not defined.
6536
6537         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
6538
6539         * posix-hdep.c (gdb_console_fputs):
6540         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
6541         functions.
6542         * ui-file.h (gdb_console_fputs): Add prototype.
6543
6544         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
6545         back to fputs only if the former returns zero.
6546
6547 2019-03-07  Tom Tromey  <tom@tromey.com>
6548
6549         * symmisc.c (print_symbol_bcache_statistics): Update.
6550         (print_objfile_statistics): Update.
6551         * symfile.c (allocate_symtab): Update.
6552         * stabsread.c: Don't include bcache.h.
6553         * psymtab.h (struct psymbol_bcache): Don't declare.
6554         (class psymtab_storage) <psymbol_cache>: Now a bcache.
6555         (psymbol_bcache_init, psymbol_bcache_free)
6556         (psymbol_bcache_get_bcache): Don't declare.
6557         * psymtab.c (struct psymbol_bcache): Remove.
6558         (psymtab_storage::psymtab_storage): Update.
6559         (psymtab_storage::~psymtab_storage): Update.
6560         (psymbol_bcache_init, psymbol_bcache_free)
6561         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
6562         (add_psymbol_to_bcache): Update.
6563         (allocate_psymtab): Update.
6564         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
6565         macro_cache>: No longer pointers.
6566         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
6567         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
6568         * macrotab.c (macro_bcache): Update.
6569         * macroexp.c: Don't include bcache.h.
6570         * gdbtypes.c (check_types_worklist): Update.
6571         (types_deeply_equal): Remove TRY/CATCH.  Update.
6572         * elfread.c (elf_symtab_read): Update.
6573         * dwarf2read.c: Don't include bcache.h.
6574         * buildsym.c (buildsym_compunit::get_macro_table): Update.
6575         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
6576         (print_bcache_statistics, bcache_memory_used): Don't declare.
6577         (struct bcache): Move from bcache.c.  Add constructor, destructor,
6578         methods.  Rename all data members.
6579         * bcache.c (struct bcache): Move to bcache.h.
6580         (bcache::expand_hash_table): Rename from expand_hash_table.
6581         (bcache): Remove.
6582         (bcache::insert): Rename from bcache_full.
6583         (bcache::compare): Rename from bcache_compare.
6584         (bcache_xmalloc): Remove.
6585         (bcache::~bcache): Rename from bcache_xfree.
6586         (bcache::print_statistics): Rename from print_bcache_statistics.
6587         (bcache::memory_used): Rename from bcache_memory_used.
6588
6589 2019-03-07  Pedro Alves  <palves@redhat.com>
6590
6591         * infrun.c (normal_stop): Also check for
6592         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
6593
6594 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
6595
6596         * f-lang.c (value_from_host_double): Moved to...
6597         * value.c (value_from_host_double): ...here.
6598         * value.h (value_from_host_double): Declare.
6599         * guile/scm-math.c (vlscm_convert_typed_number): Use
6600         value_from_host_double.
6601         (vlscm_convert_number): Likewise.
6602         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
6603         * python/py-value.c (convert_value_from_python): Likewise.
6604
6605 2019-03-06  Tom Tromey  <tom@tromey.com>
6606
6607         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
6608
6609 2019-03-06  Tom Tromey  <tom@tromey.com>
6610
6611         * utils.h (free_current_contents): Don't declare.
6612         * utils.c (free_current_contents): Remove.
6613
6614 2019-03-06  Tom Tromey  <tom@tromey.com>
6615
6616         * top.c (quit_force): Update.
6617         * main.c (captured_command_loop): Update.
6618         * common/new-op.c (operator new): Update.
6619         * common/common-exceptions.c (struct catcher)
6620         <save_cleanup_chain>: Remove member.
6621         (exceptions_state_mc_init): Update.
6622         (exception_try_scope_entry): Return nullptr.
6623         (exception_try_scope_exit, exception_rethrow)
6624         (throw_exception_sjlj, throw_exception_cxx): Update.
6625         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
6626         (all_cleanups, do_cleanups, discard_cleanups)
6627         (discard_final_cleanups, save_cleanups, save_final_cleanups)
6628         (restore_cleanups, restore_final_cleanups): Don't declare.
6629         (do_final_cleanups): Remove parameter.
6630         * common/cleanups.c (cleanup_chain, make_cleanup)
6631         (make_cleanup_dtor, all_cleanups, do_cleanups)
6632         (discard_my_cleanups, discard_cleanups)
6633         (discard_final_cleanups, save_my_cleanups, save_cleanups)
6634         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
6635         (null_cleanup): Remove.
6636         (do_final_cleanups): Remove parameter.
6637
6638 2019-03-06  Tom Tromey  <tom@tromey.com>
6639
6640         * remote.c (remote_target::remote_parse_stop_reply): Use
6641         unique_xmalloc_ptr.
6642
6643 2019-03-06  Tom Tromey  <tom@tromey.com>
6644
6645         * stabsread.c (struct stabs_field_info): Rename from field_info.
6646         <list, fnlist>: Add initializers.
6647         <obstack>: New member.
6648         (read_member_functions, read_struct_fields, read_baseclasses):
6649         Allocate on obstack.  Don't use cleanups.
6650         (read_one_struct_field, read_member_functions, read_struct_fields)
6651         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
6652         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
6653         (read_struct_type): Update.
6654
6655 2019-03-06  Tom Tromey  <tom@tromey.com>
6656
6657         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
6658         * common/filestuff.h (make_cleanup_close): Don't declare.
6659         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
6660         Remove.
6661
6662 2019-03-06  Tom Tromey  <tom@tromey.com>
6663
6664         * solib-aix.c: Use make_scope_exit.
6665
6666 2019-03-06  Tom Tromey  <tom@tromey.com>
6667
6668         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
6669         Use make_scope_exit.
6670
6671 2019-03-06  Tom Tromey  <tom@tromey.com>
6672
6673         * solib-svr4.c (disable_probes_interface): Remove parameter.
6674         (svr4_handle_solib_event): Use make_scope_exit.
6675
6676 2019-03-06  Tom Tromey  <tom@tromey.com>
6677
6678         * remote.c (struct stop_reply_deleter): Remove.
6679         (stop_reply_up): Update.
6680         (struct stop_reply): Derive from notif_event.  Don't typedef.
6681         <regcache>: Now a std::vector.
6682         (stop_reply_xfree): Remove.
6683         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
6684         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
6685         (remote_target::discard_pending_stop_replies): Use delete.
6686         (remote_target::remote_parse_stop_reply): Update.
6687         (remote_target::process_stop_reply): Update.
6688         * remote-notif.h (struct notif_event): Add virtual destructor.
6689         Remove "dtr" member.
6690         (struct notif_client) <alloc_event>: Return a unique_ptr.
6691         (notif_event_xfree): Don't declare.
6692         (notif_event_up): New typedef.
6693         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
6694         (notif_event_xfree, do_notif_event_xfree): Remove.
6695         (remote_notif_state_xfree): Update.
6696
6697 2019-03-06  Tom Tromey  <tom@tromey.com>
6698
6699         * infrun.c (displaced_step_clear_cleanup): Now a
6700         forward_scope_exit type.
6701         (displaced_step_prepare_throw): Update.
6702         (displaced_step_fixup): Update.
6703
6704 2019-03-06  Tom Tromey  <tom@tromey.com>
6705
6706         * inferior.h (class inferior): Update comment.
6707         * gdbthread.h (class thread_info): Update comment.
6708
6709 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
6710             Tom Tromey  <tom@tromey.com>
6711
6712         * stabsread.h (struct stab_section_list): Remove.
6713         (coffstab_build_psymtabs): Update.
6714         * dbxread.c (symbuf_sections): Now a std::vector.
6715         (sect_idx): New global.
6716         (fill_symbuf): Update.
6717         (coffstab_build_psymtabs): Change type of stabsects parameter.
6718         Update.
6719         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
6720         std::vector.
6721         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
6722         (coff_locate_sections): Update.
6723         (coff_symfile_read): Remove cleanups.  Update.
6724         (init_stringtab): Add storage parameter.
6725         (free_stringtab, free_stringtab_cleanup): Remove.
6726         (init_lineno): Add storage parameter.
6727         (free_linetab, free_linetab_cleanup): Remove.
6728
6729 2019-03-06  Pedro Alves  <palves@redhat.com>
6730
6731         * linux-fork.c (fork_info::clobber_regs): Delete.
6732         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
6733         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
6734         comment.  Adjust.
6735         (scoped_switch_fork_info::scoped_switch_fork_info)
6736         (checkpoint_command, linux_fork_context): Adjust
6737         fork_save_infrun_state calls.
6738
6739 2019-03-06  Pedro Alves  <palves@redhat.com>
6740
6741         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
6742         (inf_has_multiple_threads): Return 'bool' and rewrite using
6743         inferior_info::threads().
6744
6745 2019-03-06  Pedro Alves  <palves@redhat.com>
6746
6747         * linux-fork.c: Include <list>.
6748         (fork_list): Now a std::list instance.
6749         (fork_info): Add ctor, dtor, and in-class initialize all fields.
6750         (forks_exist_p, find_last_fork): Adjust.
6751         (new_fork): Delete.
6752         (one_fork_p): New.
6753         (add_fork): Adjust.
6754         (free_fork): Delete, folded into fork_info::~fork_info().
6755         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
6756         Adjust.
6757         (init_fork_list): Delete.
6758         (linux_fork_killall, linux_fork_mourn_inferior)
6759         (linux_fork_detach, info_checkpoints_command): Adjust.
6760         (_initialize_linux_fork): No longer call init_fork_list.
6761
6762 2019-03-06  Pedro Alves  <palves@redhat.com>
6763
6764         * linux-fork.c (new_fork): New, split out of ...
6765         (add_fork): ... this.  Return void.  Move "first fork" special
6766         case from here, to ...
6767         (checkpoint_command): ... here.
6768         * linux-linux.h (add_fork): Return void.
6769
6770 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6771
6772         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
6773
6774 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6775             Chris January  <chris.january@arm.com>
6776             David Lecomber  <david.lecomber@arm.com>
6777
6778         * f-exp.y: New token, UNOP_INTRINSIC.
6779         (exp): New pattern using UNOP_INTRINSIC token.
6780         (f77_keywords): Add 'abs' keyword.
6781         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
6782         (value_from_host_double): New function.
6783         (evaluate_subexp_f): Support UNOP_ABS.
6784
6785 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6786
6787         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
6788         types.
6789
6790 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6791
6792         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
6793         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
6794         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
6795
6796 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6797
6798         * f-exp.y (convert_to_kind_type): Handle more type kinds.
6799
6800 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6801             Chris January  <chris.january@arm.com>
6802
6803         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
6804         * f-exp.y: Define 'KIND' token.
6805         (exp): New pattern for KIND expressions.
6806         (ptype): Handle types with a kind extension.
6807         (direct_abs_decl): Extend to spot kind extensions.
6808         (f77_keywords): Add 'kind' to the list.
6809         (push_kind_type): New function.
6810         (convert_to_kind_type): New function.
6811         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
6812         * parse.c (operator_length_standard): Likewise.
6813         * parser-defs.h (enum type_pieces): Add tp_kind.
6814         * std-operator.def: Add UNOP_KIND.
6815
6816 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6817
6818         * f-exp.y (f_parse): Set yydebug.
6819
6820 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6821
6822         * f-lang.c (evaluate_subexp_f): New function.
6823         (exp_descriptor_f): New global.
6824         (f_language_defn): Use exp_descriptor_f instead of
6825         exp_descriptor_standard.
6826
6827 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6828
6829         * f-exp.y (struct token): Add comments.
6830         (dot_ops): Remove uppercase versions and the end marker.
6831         (f77_keywords): Likewise.
6832         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
6833         entries in the dot_ops array are case insensitive, and use
6834         strncasecmp to compare strings.  Also some whitespace cleanup in
6835         this area.  Similar for the f77_keywords array, except entries in
6836         this list might be case sensitive.
6837
6838 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6839
6840         * f-exp.y (struct f77_boolean_val): Add comments.
6841         (boolean_values): Remove uppercase versions, and end marker.
6842         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
6843         and use strncasecmp to achieve case insensitivity.  Additionally,
6844         perform whitespace cleanup around this code.
6845
6846 2019-03-06  Tom Tromey  <tromey@adacore.com>
6847
6848         * remote-sim.c (gdbsim_target_open): Use result of
6849         gdb_argv::release.
6850
6851 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
6852         Dirk Schubert  <dirk.schubert@arm.com>
6853         Chris January  <chris.january@arm.com>
6854
6855         * eval.c (evaluate_subexp_standard): Call Fortran argument
6856         wrapping logic.
6857         * f-lang.c (struct value): A value which can be passed into a
6858         Fortran function call.
6859         (fortran_argument_convert): Wrap Fortran arguments in a pointer
6860         where appropriate.
6861         (struct type): Value ready for a Fortran function call.
6862         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
6863         is needed.
6864         * f-lang.h (fortran_argument_convert): Declaration.
6865         (fortran_preserve_arg_pointer): Declaration.
6866         * infcall.c (value_arg_coerce): Call Fortran argument logic.
6867
6868 2019-03-05  Tom Tromey  <tromey@adacore.com>
6869
6870         * python/py-prettyprint.c (print_string_repr): Remove #if.
6871         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
6872
6873 2019-03-05  Tom Tromey  <tromey@adacore.com>
6874
6875         * target.c (the_dummy_target): Move later.  Change type to
6876         "dummy_target".
6877         (initialize_targets): Don't initialize the_dummy_target.
6878
6879 2019-03-05  Tom Tromey  <tromey@adacore.com>
6880
6881         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
6882         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
6883
6884 2019-03-05  Tom Tromey  <tromey@adacore.com>
6885
6886         * windows-nat.c (windows_nat_target::attach)
6887         (windows_nat_target::detach): Don't call gdb_flush.
6888         * valprint.c (generic_val_print, val_print, val_print_string):
6889         Don't call gdb_flush.
6890         * utils.c (defaulted_query): Don't call gdb_flush.
6891         * typeprint.c (print_type_scalar): Don't call gdb_flush.
6892         * target.c (target_announce_detach): Don't call gdb_flush.
6893         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
6894         * remote.c (extended_remote_target::attach): Don't call
6895         gdb_flush.
6896         * procfs.c (procfs_target::detach): Don't call gdb_flush.
6897         * printcmd.c (do_examine): Don't call gdb_flush.
6898         (info_display_command): Don't call gdb_flush.
6899         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
6900         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
6901         * memattr.c (info_mem_command): Don't call gdb_flush.
6902         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
6903         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
6904         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
6905         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
6906         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
6907         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
6908         (gnu_nat_target::detach): Don't call gdb_flush.
6909         * f-valprint.c (f_val_print): Don't call gdb_flush.
6910         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
6911         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
6912         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
6913         gdb_flush.
6914         * c-valprint.c (c_val_print): Don't call gdb_flush.
6915         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
6916
6917 2019-03-05  Tom Tromey  <tromey@adacore.com>
6918
6919         * varobj.c (update_dynamic_varobj_children): Update.
6920         (install_default_visualizer): Use reset, not release.
6921         * value.c (set_internalvar): Update.
6922         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
6923         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
6924         ATTRIBUTE_UNUSED_RESULT.
6925
6926 2019-03-05  Tom Tromey  <tromey@adacore.com>
6927
6928         * remote.c (class scoped_remote_fd) <release>: Add
6929         ATTRIBUTE_UNUSED_RESULT.
6930
6931 2019-03-05  Tom Tromey  <tromey@adacore.com>
6932
6933         * macroexp.c (struct macro_buffer) <release>: Add
6934         ATTRIBUTE_UNUSED_RESULT.
6935
6936 2019-03-05  Tom Tromey  <tromey@adacore.com>
6937
6938         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
6939         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
6940         ATTRIBUTE_UNUSED_RESULT.
6941
6942 2019-03-05  Tom Tromey  <tromey@adacore.com>
6943
6944         * common/scoped_fd.h (class scoped_fd) <release>: Add
6945         ATTRIBUTE_UNUSED_RESULT.
6946
6947 2019-03-05  Tom Tromey  <tromey@adacore.com>
6948
6949         * parser-defs.h (struct parser_state) <release>: Add
6950         ATTRIBUTE_UNUSED_RESULT.
6951
6952 2019-03-05  Tom Tromey  <tromey@adacore.com>
6953
6954         * utils.h (class gdb_argv) <release>: Add
6955         ATTRIBUTE_UNUSED_RESULT.
6956         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
6957
6958 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
6959
6960         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
6961         for-loop range, to avoid compiler warnings.
6962
6963         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
6964         avoid compiler warnings about unused variables.
6965
6966         * NEWS: Mention end of support for native debugging on MS-Windows
6967         before XP.
6968
6969         PR gdb/24292
6970         * common/netstuff.c:
6971         * gdbserver/gdbreplay.c
6972         * gdbserver/remote-utils.c:
6973         * ser-tcp.c:
6974         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
6975         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
6976         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
6977         'getaddrinfo' and 'freeaddrinfo' were not available before
6978         Windows XP, and mingw.org's MinGW headers by default define
6979         _WIN32_WINNT to 0x500.
6980
6981 2019-03-01  Gary Benson <gbenson@redhat.com>
6982
6983         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
6984
6985 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
6986             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
6987
6988         PR gdb/8527
6989         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
6990         set_sigint_trap, clear_sigint_trap.
6991
6992 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6993
6994         * target.c (target_detach): Clear the regcache and the
6995         frame cache.
6996
6997 2019-02-27  Pedro Alves  <palves@redhat.com>
6998
6999         * utils.c (set_screen_size): When we cap the height/width sizes,
7000         tweak the corresponding command variable to show "unlimited":
7001
7002 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7003             Pedro Alves  <palves@redhat.com>
7004
7005         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7006         before calling rl_set_screen_size.
7007
7008 2019-02-27  Tom Tromey  <tromey@adacore.com>
7009
7010         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7011         define.
7012         * python/py-value.c: Remove Python 2.4 workaround.
7013         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7014         workaround.
7015         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7016         Python 2.4 workaround.
7017         * python/python-internal.h: Remove Python 2.4 comment.
7018         (Py_ssize_t): Don't define.
7019         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7020         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7021         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7022         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7023         * python/python.c (do_start_initialization): Remove Python 2.4
7024         workaround.
7025         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7026         (print_children): Remove Python 2.4 workaround.
7027         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7028         workaround.
7029         (CHARBUFFERPROC_NAME): Remove.
7030         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7031         Python 2.4 workaround.
7032
7033 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7034
7035         * NEWS: Note minimum Python version.
7036
7037 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7038
7039         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7040         code from these functions.  Remove corresponding ifdefs.  Use
7041         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7042         Remove gotos and target of gotos.
7043         (infpy_search_memory): Likewise.
7044
7045 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7046
7047         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7048         (hppa_gdbarch_init): Don't register deleted functions with
7049         gdbarch.
7050
7051 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7052
7053         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7054         (h8300_unwind_sp): Delete.
7055         (h8300_dummy_id): Delete.
7056         (h8300_gdbarch_init): Don't register deleted functions with
7057         gdbarch.
7058
7059 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7060
7061         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7062         (ft32_unwind_pc): Delete.
7063         (ft32_unwind_sp): Delete.
7064         (ft32_gdbarch_init): Don't register deleted functions with
7065         gdbarch.
7066
7067 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7068
7069         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7070         (frv_unwind_pc): Delete.
7071         (frv_unwind_sp): Delete.
7072         (frv_gdbarch_init): Don't register deleted functions with
7073         gdbarch.
7074
7075 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7076
7077         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7078         (riscv_unwind_pc): Delete.
7079         (riscv_unwind_sp): Delete.
7080         (riscv_gdbarch_init): Don't register deleted functions with
7081         gdbarch.
7082
7083 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7084
7085         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7086         (csky_unwind_pc): Delete.
7087         (csky_unwind_sp): Delete.
7088         (csky_gdbarch_init): Don't register deleted functions with
7089         gdbarch.
7090
7091 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7092
7093         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7094         (cris_unwind_pc): Delete.
7095         (cris_unwind_sp): Delete.
7096         (cris_gdbarch_init): Don't register deleted functions with
7097         gdbarch.
7098
7099 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7100
7101         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7102         (bfin_unwind_pc): Delete.
7103         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7104
7105 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7106
7107         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7108         (arm_unwind_pc): Delete.
7109         (arm_unwind_sp): Delete.
7110         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7111
7112 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7113
7114         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7115         (arc_unwind_pc): Delete.
7116         (arc_unwind_sp): Delete.
7117         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7118
7119 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7120
7121         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7122         (alpha_unwind_pc): Delete.
7123         (alpha_gdbarch_init): Don't register deleted functions with
7124         gdbarch.
7125
7126 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7127
7128         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7129         (aarch64_unwind_pc): Delete.
7130         (aarch64_unwind_sp): Delete.
7131         (aarch64_gdbarch_init): Don't register deleted functions with
7132         gdbarch.
7133
7134 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7135
7136         * gdbtypes.c (type_align): Don't consider static members when
7137         computing structure alignment.
7138
7139 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7140
7141         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7142         return 0 for other types.
7143         * arch-utils.c (default_type_align): Always return 0.
7144         * gdbarch.h: Regenerate.
7145         * gdbarch.sh (type_align): Extend comment.
7146         * gdbtypes.c (type_align): Add additional comments, always call
7147         gdbarch_type_align before applying the default rules.
7148         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7149         generic code will then apply a suitable default.
7150         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7151         types, return 0 for other types.
7152
7153 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7154
7155         * NEWS: Create a new section for the next release branch.
7156         Rename the section of the current branch, now that it has
7157         been cut.
7158
7159 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7160
7161         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7162         * version.in: Bump version to 8.3.50.DATE-git.
7163
7164 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7165
7166         * aix-thread.c (ptid_cmp): Remove unused variable.
7167         (get_signaled_thread): Likewise.
7168         (store_regs_user_thread): Likewise.
7169         (store_regs_kernel_thread): Likewise.
7170         (fetch_regs_kernel_thread): Remove shadowed variable.
7171
7172 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7173
7174         * features/riscv/32bit-cpu.xml: Add register numbers.
7175         * features/riscv/32bit-fpu.c: Regenerate.
7176         * features/riscv/32bit-fpu.xml: Add register numbers.
7177         * features/riscv/64bit-cpu.xml: Add register numbers.
7178         * features/riscv/64bit-fpu.c: Regenerate.
7179         * features/riscv/64bit-fpu.xml: Add register numbers.
7180
7181 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7182
7183         * NEWS: Mention two argument form of gdb.Value constructor.
7184         * python/py-value.c (convert_buffer_and_type_to_value): New
7185         function.
7186         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7187         Add support for handling an optional second argument.  Call
7188         convert_buffer_and_type_to_value as appropriate.
7189         * python/python-internal.h (Py_buffer_deleter): New struct.
7190         (Py_buffer_up): New typedef.
7191
7192 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7193
7194         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7195         instead of releasing ownership.
7196
7197 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7198
7199         * dwarf2read.c (open_and_init_dwp_file): Call
7200         elf_numsections instead of bfd_count_sections to initialize
7201         dwp_file->num_sections.
7202
7203 2019-02-25  Tom Tromey  <tromey@adacore.com>
7204
7205         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7206
7207 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7208
7209         * gcore.in: Add '--readnever' option when invoking GDB.
7210
7211 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7212
7213         * MAINTAINERS: Update my email address.
7214
7215 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7216
7217         * build-id.c (build_id_to_debug_bfd_1): New function.
7218         (build_id_to_debug_bfd): Look for separate debug file in
7219         sysroot.
7220
7221 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7222
7223         * gdbarch.sh: Update the copyright year range that is placed into
7224         generated files.
7225
7226 2019-02-22  Keith Seitz  <keiths@redhat.com>
7227
7228         PR symtab/23853
7229         * linespec.c (create_sals_line_offset): Search for the default
7230         symtab's filename instead of its fullname.
7231
7232 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7233
7234         * NEWS: Update style defaults.
7235
7236 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7237
7238         * main.c (captured_main_1): Disable styling in batch mode.
7239
7240 2019-02-20  Tom Tromey  <tom@tromey.com>
7241
7242         * symtab.c (symtab_symbol_info): Fix typos.
7243
7244 2019-02-20  Tom Tromey  <tromey@adacore.com>
7245
7246         * findcmd.c (_initialize_mem_search): Use upper case for
7247         metasyntactic variables.
7248
7249 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7250
7251         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7252         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7253
7254 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7255
7256         * top.h (source_file_name): Change to std::string.
7257         * top.c (source_file_name): Likewise.
7258         (command_line_input): Adjust.
7259         * cli/cli-script.c (script_from_file): Adjust.
7260
7261 2019-02-19  Tom Tromey  <tromey@adacore.com>
7262
7263         * ravenscar-thread.c
7264         (ravenscar_thread_target::update_thread_list): Don't call
7265         ada_build_task_list.
7266         * ada-lang.h (ada_build_task_list): Don't declare.
7267         * ada-tasks.c (struct ada_tasks_inferior_data)
7268         <task_list_valid_p>: Now bool.
7269         (read_known_tasks, ada_task_list_changed)
7270         (ada_tasks_invalidate_inferior_data): Update.
7271         (read_known_tasks_array): Return bool.
7272         (read_known_tasks_list): Likewise.
7273         (read_known_tasks): Return void.
7274         (ada_build_task_list): Now static.
7275
7276 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7277
7278         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
7279         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
7280
7281 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7282
7283         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
7284         variant for ada_tasks_pspace_data_handle and
7285         ada_tasks_inferior_data_handle.
7286         (ada_tasks_pspace_data_cleanup): New function.
7287         (ada_tasks_inferior_data_cleanup): New function.
7288
7289 2019-02-17  Tom Tromey  <tom@tromey.com>
7290
7291         * macrotab.h (macro_source_fullname): Return a std::string.
7292         * macrotab.c (macro_include, check_for_redefinition)
7293         (macro_undef, macro_lookup_definition, foreach_macro)
7294         (foreach_macro_in_scope): Update.
7295         (macro_source_fullname): Return a std::string.
7296         * macrocmd.c (show_pp_source_pos): Update.
7297
7298 2019-02-17  Tom Tromey  <tom@tromey.com>
7299
7300         * macrocmd.c (show_pp_source_pos): Style the file names.
7301
7302 2019-02-17  Tom Tromey  <tom@tromey.com>
7303
7304         PR tui/24197:
7305         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
7306
7307 2019-02-17  Tom Tromey  <tom@tromey.com>
7308
7309         * ada-lang.c (user_select_syms): Use filtered printing.
7310         * utils.c (wrap_style): New global.
7311         (desired_style): Remove.
7312         (emit_style_escape): Add stream parameter.
7313         (set_output_style, reset_terminal_style, prompt_for_continue):
7314         Update.
7315         (flush_wrap_buffer): Only flush gdb_stdout.
7316         (wrap_here): Set wrap_style.
7317         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
7318         treat escape sequences as a character.  Change when wrap buffer is
7319         flushed.
7320         (fputs_styled): Do not set the output style when the default is
7321         requested.
7322         * ui-style.h (struct ui_file_style) <is_default>: New method.
7323         * source.c (print_source_lines_base): Emit escape sequences in one
7324         piece.
7325
7326 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7327
7328         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
7329         integers and enumeration types.
7330
7331 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7332
7333         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
7334         instead of lookup_symbol_in_language
7335         (do_exact_match): New function.
7336         (ada_get_symbol_name_matcher): Return do_exact_match when
7337         doing a verbatim match.
7338
7339 2019-02-15  Tom Tromey  <tromey@adacore.com>
7340
7341         * ravenscar-thread.c (ravenscar_thread_target::resume)
7342         (ravenscar_thread_target::wait): Special case wildcard requests.
7343
7344 2019-02-15  Tom Tromey  <tromey@adacore.com>
7345
7346         * ravenscar-thread.c (base_ptid): Remove.
7347         (struct ravenscar_thread_target) <close>: New method.
7348         <m_base_ptid>: New member.
7349         <update_inferior_ptid, active_task, task_is_currently_active,
7350         runtime_initialized>: Declare methods.
7351         <ravenscar_thread_target>: Add constructor.
7352         (ravenscar_thread_target::task_is_currently_active)
7353         (ravenscar_thread_target::update_inferior_ptid)
7354         (ravenscar_runtime_initialized): Rename.  Now methods.
7355         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
7356         (ravenscar_thread_target::update_thread_list): Update.
7357         (ravenscar_thread_target::active_task): Now method.
7358         (ravenscar_thread_target::store_registers)
7359         (ravenscar_thread_target::prepare_to_store)
7360         (ravenscar_thread_target::prepare_to_store)
7361         (ravenscar_thread_target::mourn_inferior): Update.
7362         (ravenscar_inferior_created): Use "new" to create target.
7363         (ravenscar_thread_target::get_ada_task_ptid): Update.
7364         (_initialize_ravenscar): Don't initialize base_ptid.
7365         (ravenscar_ops): Remove global.
7366
7367 2019-02-15  Tom Tromey  <tromey@adacore.com>
7368
7369         * target.h (push_target): Declare new overload.
7370         * target.c (push_target): New overload, taking an rvalue reference.
7371         * remote.c (remote_target::open_1): Use push_target overload.
7372         * corelow.c (core_target_open): Use push_target overload.
7373
7374 2019-02-15  Tom Tromey  <tromey@adacore.com>
7375
7376         * ravenscar-thread.c (is_ravenscar_task)
7377         (ravenscar_task_is_currently_active): Return bool.
7378         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
7379         (_initialize_ravenscar): Remove "(void)".
7380         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
7381         Return bool.
7382
7383 2019-02-15  Tom Tromey  <tromey@adacore.com>
7384
7385         * ravenscar-thread.c (ravenscar_runtime_initializer)
7386         (has_ravenscar_runtime, get_running_thread_id)
7387         (ravenscar_thread_target::resume): Fix indentation.
7388
7389 2019-02-15  Tom Tromey  <tromey@adacore.com>
7390
7391         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
7392         from ravenscar_arch_ops.
7393         (sparc_ravenscar_ops::fetch_registers)
7394         (sparc_ravenscar_ops::store_registers): Now methods.
7395         (sparc_ravenscar_prepare_to_store): Remove.
7396         (sparc_ravenscar_ops): Redefine.
7397         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
7398         methods and destructor.  Remove members.
7399         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
7400         (ravenscar_thread_target::store_registers)
7401         (ravenscar_thread_target::prepare_to_store): Update.
7402         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
7403         Remove.
7404         (struct ppc_ravenscar_powerpc_ops): Derive from
7405         ravenscar_arch_ops.
7406         (ppc_ravenscar_powerpc_ops::fetch_registers)
7407         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
7408         (ppc_ravenscar_powerpc_ops): Redefine.
7409         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
7410         (ppc_ravenscar_e500_ops::fetch_registers)
7411         (ppc_ravenscar_e500_ops::store_registers): Now methods.
7412         (ppc_ravenscar_e500_ops): Redefine.
7413         * aarch64-ravenscar-thread.c
7414         (aarch64_ravenscar_generic_prepare_to_store): Remove.
7415         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
7416         (aarch64_ravenscar_fetch_registers)
7417         (aarch64_ravenscar_store_registers): Now methods.
7418         (aarch64_ravenscar_ops): Redefine.
7419
7420 2019-02-15  Tom Tromey  <tromey@adacore.com>
7421
7422         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
7423         (ravenscar_thread_target::stopped_by_hw_breakpoint)
7424         (ravenscar_thread_target::stopped_by_watchpoint)
7425         (ravenscar_thread_target::stopped_data_address)
7426         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
7427
7428 2019-02-15  Tom Tromey  <tromey@adacore.com>
7429
7430         * ravenscar-thread.c: Fix some typos.
7431
7432 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7433             Tom Tromey  <tromey@adacore.com>
7434
7435         * ada-lang.c (ada_exception_sal): Change addr_string to a
7436         std::string.
7437         (create_ada_exception_catchpoint): Update.
7438
7439 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7440             Tom Tromey  <tromey@adacore.com>
7441
7442         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
7443         (bp_location_ops): Remove.
7444         (base_breakpoint_allocate_location): Update.
7445         (free_bp_location): Update.
7446         * ada-lang.c (class ada_catchpoint_location)
7447         <ada_catchpoint_location>: Remove ops parameter.
7448         (ada_catchpoint_location_dtor): Remove.
7449         (ada_catchpoint_location_ops): Remove.
7450         (allocate_location_exception): Update.
7451         * breakpoint.h (struct bp_location_ops): Remove.
7452         (class bp_location) <bp_location>: Remove bp_location_ops
7453         parameter.
7454         <~bp_location>: Add destructor.
7455         <ops>: Remove.
7456
7457 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7458             Pedro Alves  <palves@redhat.com>
7459
7460         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
7461         'PATH_MAX'.
7462
7463 2019-02-14  David Michael  <fedora.dm0@gmail.com>
7464             Samuel Thibault  <samuel.thibault@gnu.org>
7465             Thomas Schwinge  <thomas@codesourcery.com>
7466
7467         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
7468         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
7469
7470 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7471
7472         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
7473         (check_empty): Use "const char *".
7474
7475         * gnu-nat.c (gnu_nat_target::detach): Instead of
7476         'detach_inferior (pid)' call
7477         'detach_inferior (find_inferior_pid (pid))'.
7478
7479         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
7480         'nat/fork-inferior.o'.
7481         * gnu-nat.c: #include "nat/fork-inferior.h".
7482
7483         * gnu-nat.c (gnu_nat_target::detach): Instead of
7484         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
7485         * gnu-nat.h: #include "inf-child.h".
7486         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
7487         'i386_gnu_nat_target::fetch_registers'.
7488         (gnu_store_registers): Rename/move to
7489         'i386_gnu_nat_target::store_registers'.
7490
7491         * config/i386/nm-i386gnu.h: Don't "#include" any files.
7492         * gnu-nat.h (mach_thread_info): New function.
7493         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
7494
7495         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
7496
7497 2019-02-14  Frederic Konrad  <konrad@adacore.com>
7498
7499         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
7500
7501 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
7502
7503         * windows-nat.c (windows_add_thread): Add new parameter
7504         "main_thread_p" with default value set to false.  Update
7505         function documentation as well as all callers.
7506         (windows_delete_thread): Likewise.
7507         (fake_create_process): Update call to windows_add_thread.
7508         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
7509         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
7510         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
7511         call to windows_delete_thread.
7512
7513 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
7514
7515         * MAINTAINERS: Add Andrew Burgess as global maintainer.
7516
7517 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7518
7519         * symfile.c (find_separate_debug_file): Use canonical path of
7520         sysroot with child_path instead of gdb_sysroot if it is valid.
7521
7522 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7523
7524         * symfile.c (find_separate_debug_file): Use child_path to
7525         determine if an object file is under a sysroot.
7526
7527 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7528
7529         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
7530         unittests/child-path-selftests.c.
7531         * common/pathstuff.c (child_path): New function.
7532         * common/pathstuff.h (child_path): New prototype.
7533         * unittests/child-path-selftests.c: New file.
7534
7535 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7536
7537         * symfile.c (find_separate_debug_file): Look for separate debug
7538         files in debug directories under the sysroot.
7539
7540 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7541
7542         * symtab.h (struct minimal_symbol data_p): New const method.
7543         (struct minimal_symbol text_p): Likewise.
7544         * symtab.c (output_source_filename): Use file name style
7545         to print file name.
7546         (print_symbol_info): Likewise.
7547         (print_msymbol_info): Use address style to print addresses.
7548         Use function name style to print executable text symbols.
7549         (expand_symtab_containing_pc): Use data_p.
7550         (find_pc_sect_compunit_symtab): Likewise.
7551
7552 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7553
7554         * breakpoint.c (describe_other_breakpoints): Use address style
7555         to print addresses.
7556         (say_where): Likewise.
7557
7558 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7559
7560         * ada-typeprint.c (print_func_type): Print function name
7561         style to print function name.
7562         * c-typeprint.c (c_print_type_1): Likewise.
7563
7564 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
7565
7566         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
7567         for execve.
7568
7569 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7570
7571         * c-exp.y (direct_abs_decl): Use emplace_back to record the
7572         type_stack.
7573
7574 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
7575
7576         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
7577         TYPE_CODE_REF types.
7578
7579 2019-02-08  Jim Wilson  <jimw@sifive.com>
7580
7581         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
7582         (riscv_linux_fregset): New.
7583         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
7584
7585 2019-02-07  Tom Tromey  <tom@tromey.com>
7586
7587         * thread.c (thread_cancel_execution_command): Update.
7588         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
7589         methods.
7590         (struct thread_fsm_ops): Remove.
7591         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
7592         (thread_fsm_should_stop, thread_fsm_return_value)
7593         (thread_fsm_set_finished, thread_fsm_finished_p)
7594         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
7595         Don't declare.
7596         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
7597         * infrun.c (clear_proceed_status_thread)
7598         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
7599         (print_stop_event): Update.
7600         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
7601         Add constructor.
7602         (step_command_fsm_ops): Remove.
7603         (new_step_command_fsm): Remove.
7604         (step_1): Update.
7605         (step_command_fsm::should_stop): Rename from
7606         step_command_fsm_should_stop.
7607         (step_command_fsm::clean_up): Rename from
7608         step_command_fsm_clean_up.
7609         (step_command_fsm::do_async_reply_reason): Rename from
7610         step_command_fsm_async_reply_reason.
7611         (struct until_next_fsm): Inherit from thread_fsm.  Add
7612         constructor.
7613         (until_next_fsm_ops): Remove.
7614         (new_until_next_fsm): Remove.
7615         (until_next_fsm::should_stop): Rename from
7616         until_next_fsm_should_stop.
7617         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
7618         (until_next_fsm::do_async_reply_reason): Rename from
7619         until_next_fsm_async_reply_reason.
7620         (struct finish_command_fsm): Inherit from thread_fsm.  Add
7621         constructor.  Change type of breakpoint.
7622         (finish_command_fsm_ops): Remove.
7623         (new_finish_command_fsm): Remove.
7624         (finish_command_fsm::should_stop): Rename from
7625         finish_command_fsm_should_stop.
7626         (finish_command_fsm::clean_up): Rename from
7627         finish_command_fsm_clean_up.
7628         (finish_command_fsm::return_value): Rename from
7629         finish_command_fsm_return_value.
7630         (finish_command_fsm::do_async_reply_reason): Rename from
7631         finish_command_fsm_async_reply_reason.
7632         (finish_command): Update.
7633         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
7634         Add constructor.
7635         (call_thread_fsm_ops): Remove.
7636         (call_thread_fsm::call_thread_fsm): Rename from
7637         new_call_thread_fsm.
7638         (call_thread_fsm::should_stop): Rename from
7639         call_thread_fsm_should_stop.
7640         (call_thread_fsm::should_notify_stop): Rename from
7641         call_thread_fsm_should_notify_stop.
7642         (run_inferior_call, call_function_by_hand_dummy): Update.
7643         * cli/cli-interp.c (should_print_stop_to_console): Update.
7644         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
7645         Add constructor.  Change type of location_breakpoint,
7646         caller_breakpoint.
7647         (until_break_fsm_ops): Remove.
7648         (new_until_break_fsm): Remove.
7649         (until_break_fsm::should_stop): Rename from
7650         until_break_fsm_should_stop.
7651         (until_break_fsm::clean_up): Rename from
7652         until_break_fsm_clean_up.
7653         (until_break_fsm::do_async_reply_reason): Rename from
7654         until_break_fsm_async_reply_reason.
7655         (until_break_command): Update.
7656         * thread-fsm.c: Remove.
7657         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
7658
7659 2019-02-07  Tom Tromey  <tom@tromey.com>
7660
7661         * yy-remap.h: Add include guard.
7662         * xtensa-tdep.h: Add include guard.
7663         * xcoffread.h: Rename include guard.
7664         * varobj-iter.h: Add include guard.
7665         * tui/tui.h: Rename include guard.
7666         * tui/tui-winsource.h: Rename include guard.
7667         * tui/tui-wingeneral.h: Rename include guard.
7668         * tui/tui-windata.h: Rename include guard.
7669         * tui/tui-win.h: Rename include guard.
7670         * tui/tui-stack.h: Rename include guard.
7671         * tui/tui-source.h: Rename include guard.
7672         * tui/tui-regs.h: Rename include guard.
7673         * tui/tui-out.h: Rename include guard.
7674         * tui/tui-layout.h: Rename include guard.
7675         * tui/tui-io.h: Rename include guard.
7676         * tui/tui-hooks.h: Rename include guard.
7677         * tui/tui-file.h: Rename include guard.
7678         * tui/tui-disasm.h: Rename include guard.
7679         * tui/tui-data.h: Rename include guard.
7680         * tui/tui-command.h: Rename include guard.
7681         * tic6x-tdep.h: Add include guard.
7682         * target/waitstatus.h: Rename include guard.
7683         * target/wait.h: Rename include guard.
7684         * target/target.h: Rename include guard.
7685         * target/resume.h: Rename include guard.
7686         * target-float.h: Rename include guard.
7687         * stabsread.h: Add include guard.
7688         * rs6000-tdep.h: Add include guard.
7689         * riscv-fbsd-tdep.h: Add include guard.
7690         * regformats/regdef.h: Rename include guard.
7691         * record.h: Rename include guard.
7692         * python/python.h: Rename include guard.
7693         * python/python-internal.h: Rename include guard.
7694         * python/py-stopevent.h: Rename include guard.
7695         * python/py-ref.h: Rename include guard.
7696         * python/py-record.h: Rename include guard.
7697         * python/py-record-full.h: Rename include guard.
7698         * python/py-record-btrace.h: Rename include guard.
7699         * python/py-instruction.h: Rename include guard.
7700         * python/py-events.h: Rename include guard.
7701         * python/py-event.h: Rename include guard.
7702         * procfs.h: Add include guard.
7703         * proc-utils.h: Add include guard.
7704         * p-lang.h: Add include guard.
7705         * or1k-tdep.h: Rename include guard.
7706         * observable.h: Rename include guard.
7707         * nto-tdep.h: Rename include guard.
7708         * nat/x86-linux.h: Rename include guard.
7709         * nat/x86-linux-dregs.h: Rename include guard.
7710         * nat/x86-gcc-cpuid.h: Add include guard.
7711         * nat/x86-dregs.h: Rename include guard.
7712         * nat/x86-cpuid.h: Rename include guard.
7713         * nat/ppc-linux.h: Rename include guard.
7714         * nat/mips-linux-watch.h: Rename include guard.
7715         * nat/linux-waitpid.h: Rename include guard.
7716         * nat/linux-ptrace.h: Rename include guard.
7717         * nat/linux-procfs.h: Rename include guard.
7718         * nat/linux-osdata.h: Rename include guard.
7719         * nat/linux-nat.h: Rename include guard.
7720         * nat/linux-namespaces.h: Rename include guard.
7721         * nat/linux-btrace.h: Rename include guard.
7722         * nat/glibc_thread_db.h: Rename include guard.
7723         * nat/gdb_thread_db.h: Rename include guard.
7724         * nat/gdb_ptrace.h: Rename include guard.
7725         * nat/fork-inferior.h: Rename include guard.
7726         * nat/amd64-linux-siginfo.h: Rename include guard.
7727         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
7728         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
7729         * nat/aarch64-linux.h: Rename include guard.
7730         * nat/aarch64-linux-hw-point.h: Rename include guard.
7731         * mn10300-tdep.h: Add include guard.
7732         * mips-linux-tdep.h: Add include guard.
7733         * mi/mi-parse.h: Rename include guard.
7734         * mi/mi-out.h: Rename include guard.
7735         * mi/mi-main.h: Rename include guard.
7736         * mi/mi-interp.h: Rename include guard.
7737         * mi/mi-getopt.h: Rename include guard.
7738         * mi/mi-console.h: Rename include guard.
7739         * mi/mi-common.h: Rename include guard.
7740         * mi/mi-cmds.h: Rename include guard.
7741         * mi/mi-cmd-break.h: Rename include guard.
7742         * m2-lang.h: Add include guard.
7743         * location.h: Rename include guard.
7744         * linux-record.h: Rename include guard.
7745         * linux-nat.h: Add include guard.
7746         * linux-fork.h: Add include guard.
7747         * i386-darwin-tdep.h: Rename include guard.
7748         * hppa-linux-offsets.h: Add include guard.
7749         * guile/guile.h: Rename include guard.
7750         * guile/guile-internal.h: Rename include guard.
7751         * gnu-nat.h: Rename include guard.
7752         * gdb-stabs.h: Rename include guard.
7753         * frv-tdep.h: Add include guard.
7754         * f-lang.h: Add include guard.
7755         * event-loop.h: Add include guard.
7756         * darwin-nat.h: Rename include guard.
7757         * cp-abi.h: Rename include guard.
7758         * config/sparc/nm-sol2.h: Rename include guard.
7759         * config/nm-nto.h: Rename include guard.
7760         * config/nm-linux.h: Add include guard.
7761         * config/i386/nm-i386gnu.h: Rename include guard.
7762         * config/djgpp/nl_types.h: Rename include guard.
7763         * config/djgpp/langinfo.h: Rename include guard.
7764         * compile/gcc-cp-plugin.h: Add include guard.
7765         * compile/gcc-c-plugin.h: Add include guard.
7766         * compile/compile.h: Rename include guard.
7767         * compile/compile-object-run.h: Rename include guard.
7768         * compile/compile-object-load.h: Rename include guard.
7769         * compile/compile-internal.h: Rename include guard.
7770         * compile/compile-cplus.h: Rename include guard.
7771         * compile/compile-c.h: Rename include guard.
7772         * common/xml-utils.h: Rename include guard.
7773         * common/x86-xstate.h: Rename include guard.
7774         * common/version.h: Rename include guard.
7775         * common/vec.h: Rename include guard.
7776         * common/tdesc.h: Rename include guard.
7777         * common/selftest.h: Rename include guard.
7778         * common/scoped_restore.h: Rename include guard.
7779         * common/scoped_mmap.h: Rename include guard.
7780         * common/scoped_fd.h: Rename include guard.
7781         * common/safe-iterator.h: Rename include guard.
7782         * common/run-time-clock.h: Rename include guard.
7783         * common/refcounted-object.h: Rename include guard.
7784         * common/queue.h: Rename include guard.
7785         * common/ptid.h: Rename include guard.
7786         * common/print-utils.h: Rename include guard.
7787         * common/preprocessor.h: Rename include guard.
7788         * common/pathstuff.h: Rename include guard.
7789         * common/observable.h: Rename include guard.
7790         * common/netstuff.h: Rename include guard.
7791         * common/job-control.h: Rename include guard.
7792         * common/host-defs.h: Rename include guard.
7793         * common/gdb_wait.h: Rename include guard.
7794         * common/gdb_vecs.h: Rename include guard.
7795         * common/gdb_unlinker.h: Rename include guard.
7796         * common/gdb_unique_ptr.h: Rename include guard.
7797         * common/gdb_tilde_expand.h: Rename include guard.
7798         * common/gdb_sys_time.h: Rename include guard.
7799         * common/gdb_string_view.h: Rename include guard.
7800         * common/gdb_splay_tree.h: Rename include guard.
7801         * common/gdb_setjmp.h: Rename include guard.
7802         * common/gdb_ref_ptr.h: Rename include guard.
7803         * common/gdb_optional.h: Rename include guard.
7804         * common/gdb_locale.h: Rename include guard.
7805         * common/gdb_assert.h: Rename include guard.
7806         * common/filtered-iterator.h: Rename include guard.
7807         * common/filestuff.h: Rename include guard.
7808         * common/fileio.h: Rename include guard.
7809         * common/environ.h: Rename include guard.
7810         * common/common-utils.h: Rename include guard.
7811         * common/common-types.h: Rename include guard.
7812         * common/common-regcache.h: Rename include guard.
7813         * common/common-inferior.h: Rename include guard.
7814         * common/common-gdbthread.h: Rename include guard.
7815         * common/common-exceptions.h: Rename include guard.
7816         * common/common-defs.h: Rename include guard.
7817         * common/common-debug.h: Rename include guard.
7818         * common/cleanups.h: Rename include guard.
7819         * common/buffer.h: Rename include guard.
7820         * common/btrace-common.h: Rename include guard.
7821         * common/break-common.h: Rename include guard.
7822         * cli/cli-utils.h: Rename include guard.
7823         * cli/cli-style.h: Rename include guard.
7824         * cli/cli-setshow.h: Rename include guard.
7825         * cli/cli-script.h: Rename include guard.
7826         * cli/cli-interp.h: Rename include guard.
7827         * cli/cli-decode.h: Rename include guard.
7828         * cli/cli-cmds.h: Rename include guard.
7829         * charset-list.h: Add include guard.
7830         * buildsym-legacy.h: Rename include guard.
7831         * bfin-tdep.h: Add include guard.
7832         * ax.h: Rename include guard.
7833         * arm-linux-tdep.h: Add include guard.
7834         * arm-fbsd-tdep.h: Add include guard.
7835         * arch/xtensa.h: Rename include guard.
7836         * arch/tic6x.h: Add include guard.
7837         * arch/i386.h: Add include guard.
7838         * arch/arm.h: Rename include guard.
7839         * arch/arm-linux.h: Rename include guard.
7840         * arch/arm-get-next-pcs.h: Rename include guard.
7841         * arch/amd64.h: Add include guard.
7842         * arch/aarch64-insn.h: Rename include guard.
7843         * arch-utils.h: Rename include guard.
7844         * annotate.h: Add include guard.
7845         * amd64-darwin-tdep.h: Rename include guard.
7846         * aarch64-linux-tdep.h: Add include guard.
7847         * aarch64-fbsd-tdep.h: Add include guard.
7848         * aarch32-linux-nat.h: Add include guard.
7849
7850 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7851
7852         * macrotab.c (macro_define_internal): New function that
7853         factorizes macro_define_object_internal and macro_define_function
7854         code.
7855         (macro_define_object_internal): Use macro_define_internal.
7856         (macro_define_function): Likewise.
7857
7858 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7859
7860         * macrocmd.c (extract_identifier): Return
7861         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
7862         callers.
7863
7864 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
7865
7866         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
7867
7868 2019-02-05  Tom Tromey  <tom@tromey.com>
7869
7870         * target.c (target_stack::unpush): Move assertion earlier.
7871
7872 2019-01-30  Tom Tromey  <tom@tromey.com>
7873
7874         PR python/23615:
7875         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
7876         (gdbpy_parse_and_eval): Likewise.
7877         * python/python-internal.h (gdbpy_allow_threads): New class.
7878
7879 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
7880
7881         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
7882         (aarch64_fbsd_fpregmap): Move earlier.
7883         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
7884         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7885         instead of individual calls to trad_frame_set_reg_addr.
7886         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
7887         earlier.
7888         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
7889         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7890         instead of individual calls to trad_frame_set_reg_addr.
7891
7892 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
7893
7894         * CONTRIBUTE: Replace contribution list with wiki link.
7895
7896 2019-01-25  Tom Tromey  <tom@tromey.com>
7897
7898         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
7899
7900 2019-01-25  Tom Tromey  <tom@tromey.com>
7901
7902         * xtensa-linux-nat.c: Fix common/ includes.
7903         * xml-support.h: Fix common/ includes.
7904         * xml-support.c: Fix common/ includes.
7905         * x86-linux-nat.c: Fix common/ includes.
7906         * windows-nat.c: Fix common/ includes.
7907         * varobj.h: Fix common/ includes.
7908         * varobj.c: Fix common/ includes.
7909         * value.c: Fix common/ includes.
7910         * valops.c: Fix common/ includes.
7911         * utils.c: Fix common/ includes.
7912         * unittests/xml-utils-selftests.c: Fix common/ includes.
7913         * unittests/utils-selftests.c: Fix common/ includes.
7914         * unittests/unpack-selftests.c: Fix common/ includes.
7915         * unittests/tracepoint-selftests.c: Fix common/ includes.
7916         * unittests/style-selftests.c: Fix common/ includes.
7917         * unittests/string_view-selftests.c: Fix common/ includes.
7918         * unittests/scoped_restore-selftests.c: Fix common/ includes.
7919         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
7920         * unittests/scoped_fd-selftests.c: Fix common/ includes.
7921         * unittests/rsp-low-selftests.c: Fix common/ includes.
7922         * unittests/parse-connection-spec-selftests.c: Fix common/
7923         includes.
7924         * unittests/optional-selftests.c: Fix common/ includes.
7925         * unittests/offset-type-selftests.c: Fix common/ includes.
7926         * unittests/observable-selftests.c: Fix common/ includes.
7927         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
7928         * unittests/memrange-selftests.c: Fix common/ includes.
7929         * unittests/memory-map-selftests.c: Fix common/ includes.
7930         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
7931         * unittests/function-view-selftests.c: Fix common/ includes.
7932         * unittests/environ-selftests.c: Fix common/ includes.
7933         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
7934         * unittests/common-utils-selftests.c: Fix common/ includes.
7935         * unittests/cli-utils-selftests.c: Fix common/ includes.
7936         * unittests/array-view-selftests.c: Fix common/ includes.
7937         * ui-file.c: Fix common/ includes.
7938         * tui/tui-io.c: Fix common/ includes.
7939         * tracepoint.h: Fix common/ includes.
7940         * tracepoint.c: Fix common/ includes.
7941         * tracefile-tfile.c: Fix common/ includes.
7942         * top.h: Fix common/ includes.
7943         * top.c: Fix common/ includes.
7944         * thread.c: Fix common/ includes.
7945         * target/waitstatus.h: Fix common/ includes.
7946         * target/waitstatus.c: Fix common/ includes.
7947         * target.h: Fix common/ includes.
7948         * target.c: Fix common/ includes.
7949         * target-memory.c: Fix common/ includes.
7950         * target-descriptions.c: Fix common/ includes.
7951         * symtab.h: Fix common/ includes.
7952         * symfile.c: Fix common/ includes.
7953         * stap-probe.c: Fix common/ includes.
7954         * spu-linux-nat.c: Fix common/ includes.
7955         * sparc-nat.c: Fix common/ includes.
7956         * source.c: Fix common/ includes.
7957         * solib.c: Fix common/ includes.
7958         * solib-target.c: Fix common/ includes.
7959         * ser-unix.c: Fix common/ includes.
7960         * ser-tcp.c: Fix common/ includes.
7961         * ser-pipe.c: Fix common/ includes.
7962         * ser-base.c: Fix common/ includes.
7963         * selftest-arch.c: Fix common/ includes.
7964         * s12z-tdep.c: Fix common/ includes.
7965         * rust-exp.y: Fix common/ includes.
7966         * rs6000-aix-tdep.c: Fix common/ includes.
7967         * riscv-tdep.c: Fix common/ includes.
7968         * remote.c: Fix common/ includes.
7969         * remote-notif.h: Fix common/ includes.
7970         * remote-fileio.h: Fix common/ includes.
7971         * remote-fileio.c: Fix common/ includes.
7972         * regcache.h: Fix common/ includes.
7973         * regcache.c: Fix common/ includes.
7974         * record-btrace.c: Fix common/ includes.
7975         * python/python.c: Fix common/ includes.
7976         * python/py-type.c: Fix common/ includes.
7977         * python/py-inferior.c: Fix common/ includes.
7978         * progspace.h: Fix common/ includes.
7979         * producer.c: Fix common/ includes.
7980         * procfs.c: Fix common/ includes.
7981         * proc-api.c: Fix common/ includes.
7982         * printcmd.c: Fix common/ includes.
7983         * ppc-linux-nat.c: Fix common/ includes.
7984         * parser-defs.h: Fix common/ includes.
7985         * osdata.c: Fix common/ includes.
7986         * obsd-nat.c: Fix common/ includes.
7987         * nat/x86-linux.c: Fix common/ includes.
7988         * nat/x86-linux-dregs.c: Fix common/ includes.
7989         * nat/x86-dregs.h: Fix common/ includes.
7990         * nat/x86-dregs.c: Fix common/ includes.
7991         * nat/ppc-linux.c: Fix common/ includes.
7992         * nat/mips-linux-watch.h: Fix common/ includes.
7993         * nat/mips-linux-watch.c: Fix common/ includes.
7994         * nat/linux-waitpid.c: Fix common/ includes.
7995         * nat/linux-ptrace.h: Fix common/ includes.
7996         * nat/linux-ptrace.c: Fix common/ includes.
7997         * nat/linux-procfs.c: Fix common/ includes.
7998         * nat/linux-personality.c: Fix common/ includes.
7999         * nat/linux-osdata.c: Fix common/ includes.
8000         * nat/linux-namespaces.c: Fix common/ includes.
8001         * nat/linux-btrace.h: Fix common/ includes.
8002         * nat/linux-btrace.c: Fix common/ includes.
8003         * nat/fork-inferior.c: Fix common/ includes.
8004         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8005         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8006         * nat/aarch64-linux.c: Fix common/ includes.
8007         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8008         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8009         * namespace.h: Fix common/ includes.
8010         * mips-linux-tdep.c: Fix common/ includes.
8011         * minsyms.c: Fix common/ includes.
8012         * mi/mi-parse.h: Fix common/ includes.
8013         * mi/mi-main.c: Fix common/ includes.
8014         * mi/mi-cmd-env.c: Fix common/ includes.
8015         * memrange.h: Fix common/ includes.
8016         * memattr.c: Fix common/ includes.
8017         * maint.h: Fix common/ includes.
8018         * maint.c: Fix common/ includes.
8019         * main.c: Fix common/ includes.
8020         * machoread.c: Fix common/ includes.
8021         * location.c: Fix common/ includes.
8022         * linux-thread-db.c: Fix common/ includes.
8023         * linux-nat.c: Fix common/ includes.
8024         * linux-fork.c: Fix common/ includes.
8025         * inline-frame.c: Fix common/ includes.
8026         * infrun.c: Fix common/ includes.
8027         * inflow.c: Fix common/ includes.
8028         * inferior.h: Fix common/ includes.
8029         * inferior.c: Fix common/ includes.
8030         * infcmd.c: Fix common/ includes.
8031         * inf-ptrace.c: Fix common/ includes.
8032         * inf-child.c: Fix common/ includes.
8033         * ia64-linux-nat.c: Fix common/ includes.
8034         * i387-tdep.c: Fix common/ includes.
8035         * i386-tdep.c: Fix common/ includes.
8036         * i386-linux-tdep.c: Fix common/ includes.
8037         * i386-linux-nat.c: Fix common/ includes.
8038         * i386-go32-tdep.c: Fix common/ includes.
8039         * i386-fbsd-tdep.c: Fix common/ includes.
8040         * i386-fbsd-nat.c: Fix common/ includes.
8041         * guile/scm-type.c: Fix common/ includes.
8042         * guile/guile.c: Fix common/ includes.
8043         * go32-nat.c: Fix common/ includes.
8044         * gnu-nat.c: Fix common/ includes.
8045         * gdbthread.h: Fix common/ includes.
8046         * gdbarch-selftests.c: Fix common/ includes.
8047         * gdb_usleep.c: Fix common/ includes.
8048         * gdb_select.h: Fix common/ includes.
8049         * gdb_bfd.c: Fix common/ includes.
8050         * gcore.c: Fix common/ includes.
8051         * fork-child.c: Fix common/ includes.
8052         * findvar.c: Fix common/ includes.
8053         * fbsd-nat.c: Fix common/ includes.
8054         * event-top.c: Fix common/ includes.
8055         * event-loop.c: Fix common/ includes.
8056         * dwarf2read.c: Fix common/ includes.
8057         * dwarf2loc.c: Fix common/ includes.
8058         * dwarf2-frame.c: Fix common/ includes.
8059         * dwarf-index-cache.c: Fix common/ includes.
8060         * dtrace-probe.c: Fix common/ includes.
8061         * disasm-selftests.c: Fix common/ includes.
8062         * defs.h: Fix common/ includes.
8063         * csky-tdep.c: Fix common/ includes.
8064         * cp-valprint.c: Fix common/ includes.
8065         * cp-support.h: Fix common/ includes.
8066         * cp-support.c: Fix common/ includes.
8067         * corelow.c: Fix common/ includes.
8068         * completer.h: Fix common/ includes.
8069         * completer.c: Fix common/ includes.
8070         * compile/compile.c: Fix common/ includes.
8071         * compile/compile-loc2c.c: Fix common/ includes.
8072         * compile/compile-cplus-types.c: Fix common/ includes.
8073         * compile/compile-cplus-symbols.c: Fix common/ includes.
8074         * command.h: Fix common/ includes.
8075         * cli/cli-dump.c: Fix common/ includes.
8076         * cli/cli-cmds.c: Fix common/ includes.
8077         * charset.c: Fix common/ includes.
8078         * build-id.c: Fix common/ includes.
8079         * btrace.h: Fix common/ includes.
8080         * btrace.c: Fix common/ includes.
8081         * breakpoint.h: Fix common/ includes.
8082         * breakpoint.c: Fix common/ includes.
8083         * ax.h:
8084         (enum agent_op): Fix common/ includes.
8085         * ax-general.c (struct aop_map): Fix common/ includes.
8086         * ax-gdb.c: Fix common/ includes.
8087         * auxv.c: Fix common/ includes.
8088         * auto-load.c: Fix common/ includes.
8089         * arm-tdep.c: Fix common/ includes.
8090         * arch/riscv.c: Fix common/ includes.
8091         * arch/ppc-linux-common.c: Fix common/ includes.
8092         * arch/i386.c: Fix common/ includes.
8093         * arch/arm.c: Fix common/ includes.
8094         * arch/arm-linux.c: Fix common/ includes.
8095         * arch/arm-get-next-pcs.c: Fix common/ includes.
8096         * arch/amd64.c: Fix common/ includes.
8097         * arch/aarch64.c: Fix common/ includes.
8098         * arch/aarch64-insn.c: Fix common/ includes.
8099         * arch-utils.c: Fix common/ includes.
8100         * amd64-windows-tdep.c: Fix common/ includes.
8101         * amd64-tdep.c: Fix common/ includes.
8102         * amd64-sol2-tdep.c: Fix common/ includes.
8103         * amd64-obsd-tdep.c: Fix common/ includes.
8104         * amd64-nbsd-tdep.c: Fix common/ includes.
8105         * amd64-linux-tdep.c: Fix common/ includes.
8106         * amd64-linux-nat.c: Fix common/ includes.
8107         * amd64-fbsd-tdep.c: Fix common/ includes.
8108         * amd64-fbsd-nat.c: Fix common/ includes.
8109         * amd64-dicos-tdep.c: Fix common/ includes.
8110         * amd64-darwin-tdep.c: Fix common/ includes.
8111         * agent.c: Fix common/ includes.
8112         * ada-lang.h: Fix common/ includes.
8113         * ada-lang.c: Fix common/ includes.
8114         * aarch64-tdep.c: Fix common/ includes.
8115
8116 2019-01-25  Tom Tromey  <tom@tromey.com>
8117
8118         * common/create-version.sh: Use common/version.h.
8119
8120 2019-01-24  Pedro Alves  <palves@redhat.com>
8121
8122         * infrun.c (signal_stop, signal_print, signal_program)
8123         (signal_catch, signal_pass): Now arrays instead of pointers.
8124         (update_signals_program_target, do_target_resume)
8125         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8126         * linux-nat.c (linux_nat_target::pass_signals)
8127         (linux_nat_target::create_inferior, linux_nat_target::attach):
8128         Adjust.
8129         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8130         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8131         * procfs.c (procfs_target::pass_signals): Adjust.
8132         * record-full.c (record_full_target::resume): Adjust.
8133         * remote.c (remote_target::pass_signals)
8134         (remote_target::program_signals): Adjust.
8135         * target-debug.h (target_debug_print_signals): Now takes a
8136         gdb::array_view as parameter.  Adjust.
8137         * target.h (target_ops) <pass_signals, program_signals>: Replace
8138         pointer and length parameters with gdb::array_view.
8139         (target_pass_signals, target_program_signals): Likewise.
8140         * target-delegates.c: Regenerate.
8141
8142 2019-01-24  Pedro Alves  <palves@redhat.com>
8143
8144         * common/forward-scope-exit.h
8145         (forward_scope_exit::forward_scope_exit): Pass arguments to
8146         m_bind_function directly, instead of creating a std::bind and
8147         copying that.
8148
8149 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8150
8151         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8152         for static members.
8153         (pass_in_v_vfp_candidate): Likewise.
8154
8155 2019-01-23  Tom Tromey  <tom@tromey.com>
8156             Pedro Alves  <palves@redhat.com>
8157
8158         * regcache.c (class regcache_invalidator): Remove.
8159         (regcache::raw_write): Use make_scope_exit.
8160
8161 2019-01-23  Tom Tromey  <tom@tromey.com>
8162
8163         * ui-out.h (class ui_out_emit_type): Update comment.
8164
8165 2019-01-23  Tom Tromey  <tom@tromey.com>
8166
8167         * infrun.c (fetch_inferior_event): Update comment.
8168
8169 2019-01-23  Tom Tromey  <tom@tromey.com>
8170             Pedro Alves  <palves@redhat.com>
8171
8172         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8173         parameter.
8174         (fetch_inferior_event): Use SCOPE_EXIT.
8175
8176
8177 2019-01-23  Tom Tromey  <tom@tromey.com>
8178             Pedro Alves  <palves@redhat.com>
8179
8180         * infrun.c (disable_thread_events): Delete.
8181         (stop_all_threads): Use SCOPE_EXIT.
8182
8183 2019-01-23  Tom Tromey  <tom@tromey.com>
8184             Pedro Alves  <palves@redhat.com>
8185
8186         * symfile.c: Include forward-scope-exit.h.
8187         (clear_symtab_users_cleanup): Replace forward declaration with
8188         a FORWARD_SCOPE_EXIT.
8189         (syms_from_objfile_1): Use the forward_scope_exit and
8190         gdb::optional instead of cleanup_function.
8191         (reread_symbols): Use the forward_scope_exit instead of
8192         cleanup_function.
8193         (clear_symtab_users_cleanup): Remove function.
8194
8195 2019-01-23  Tom Tromey  <tom@tromey.com>
8196             Pedro Alves  <palves@redhat.com>
8197
8198         * linux-nat.c: Include scope-exit.h.
8199         (cleanup_target_stop): Remove.
8200         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8201         SCOPE_EXIT.
8202
8203 2019-01-23  Tom Tromey  <tom@tromey.com>
8204             Pedro Alves  <palves@redhat.com>
8205
8206         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8207         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8208
8209 2019-01-23  Tom Tromey  <tom@tromey.com>
8210             Andrew Burgess  <andrew.burgess@embecosm.com>
8211             Pedro Alves  <palves@redhat.com>
8212
8213         * infrun.c (fetch_inferior_event): Use scope_exit.
8214         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8215         * top.c (execute_command): Use scope_exit.
8216         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8217         * utils.c (do_bpstat_clear_actions_cleanup)
8218         (make_bpstat_clear_actions_cleanup): Remove.
8219
8220 2019-01-23  Tom Tromey  <tom@tromey.com>
8221             Pedro Alves  <palves@redhat.com>
8222
8223         * infrun.c: Include "common/scope-exit.h"
8224         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8225         (wait_for_inferior): Use SCOPE_EXIT.
8226         (fetch_inferior_event): Use scope_exit.
8227
8228 2019-01-23  Tom Tromey  <tom@tromey.com>
8229             Pedro Alves  <palves@redhat.com>
8230
8231         * breakpoint.c (create_breakpoint): Remove cleanup.
8232
8233 2019-01-23  Tom Tromey  <tom@tromey.com>
8234             Andrew Burgess  <andrew.burgess@embecosm.com>
8235             Pedro Alves  <palves@redhat.com>
8236
8237 2019-01-23  Pedro Alves  <palves@redhat.com>
8238
8239         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8240
8241 2019-01-23  Pedro Alves  <palves@redhat.com>
8242             Andrew Burgess  <andrew.burgess@embecosm.com>
8243
8244         * gdbthread.h: Include "common/forward-scope-exit.h".
8245         (scoped_finish_thread_state): Redefine custom class in terms of
8246         forward_scope_exit.
8247
8248 2019-01-23  Pedro Alves  <palves@redhat.com>
8249             Andrew Burgess  <andrew.burgess@embecosm.com>
8250
8251         * common/forward-scope-exit.h: New file.
8252
8253 2019-01-23  Pedro Alves  <palves@redhat.com>
8254             Andrew Burgess  <andrew.burgess@embecosm.com>
8255             Tom Tromey  <tom@tromey.com>
8256
8257         * common/scope-exit.h: New file.
8258
8259 2019-01-23  Pedro Alves  <palves@redhat.com>
8260
8261         * common/preprocessor.h (ESC): Rename to ...
8262         (ESC_PARENS): ... this.
8263         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8264         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8265
8266 2019-01-23  Tom Tromey  <tom@tromey.com>
8267
8268         * language.h (class scoped_switch_to_sym_language_if_auto):
8269         Initialize m_lang in both cases.
8270
8271 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
8272
8273         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8274         with XCNEW.
8275
8276 2019-01-22  Tom Tromey  <tom@tromey.com>
8277
8278         * corelow.c: Do not include sys/file.h.
8279
8280 2019-01-22  Tom Tromey  <tom@tromey.com>
8281
8282         * tui/tui-wingeneral.h: Include gdb_curses.h.
8283
8284 2019-01-22  Tom Tromey  <tom@tromey.com>
8285
8286         * source-cache.h (class source_cache) <get_source_lines,
8287         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
8288
8289 2019-01-22  Tom Tromey  <tom@tromey.com>
8290
8291         * remote-fileio.h (struct remote_target): Declare.
8292
8293 2019-01-22  Tom Tromey  <tom@tromey.com>
8294
8295         * python/py-arch.c: Do not include py-ref.h.
8296         * python/py-bpevent.c: Do not include py-ref.h.
8297         * python/py-cmd.c: Do not include py-ref.h.
8298         * python/py-continueevent.c: Do not include py-ref.h.
8299         * python/py-event.h: Do not include py-ref.h.
8300         * python/py-evtregistry.c: Do not include py-ref.h.
8301         * python/py-finishbreakpoint.c: Do not include py-ref.h.
8302         * python/py-frame.c: Do not include py-ref.h.
8303         * python/py-framefilter.c: Do not include py-ref.h.
8304         * python/py-function.c: Do not include py-ref.h.
8305         * python/py-infevents.c: Do not include py-ref.h.
8306         * python/py-linetable.c: Do not include py-ref.h.
8307         * python/py-objfile.c: Do not include py-ref.h.
8308         * python/py-param.c: Do not include py-ref.h.
8309         * python/py-prettyprint.c: Do not include py-ref.h.
8310         * python/py-progspace.c: Do not include py-ref.h.
8311         * python/py-symbol.c: Do not include py-ref.h.
8312         * python/py-symtab.c: Do not include py-ref.h.
8313         * python/py-type.c: Do not include py-ref.h.
8314         * python/py-unwind.c: Do not include py-ref.h.
8315         * python/py-utils.c: Do not include py-ref.h.
8316         * python/py-value.c: Do not include py-ref.h.
8317         * python/py-varobj.c: Do not include py-ref.h.
8318         * python/py-xmethods.c: Do not include py-ref.h.
8319         * python/python.c: Do not include py-ref.h.
8320         * varobj.c: Do not include py-ref.h.
8321
8322 2019-01-22  Tom Tromey  <tom@tromey.com>
8323
8324         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
8325         keyword for bcache.
8326
8327 2019-01-22  Tom Tromey  <tom@tromey.com>
8328
8329         * compile/compile-cplus-types.c: Remove a comment by #include.
8330
8331 2019-01-22  Tom Tromey  <tom@tromey.com>
8332
8333         * compile/gcc-c-plugin.h: Include compile-internal.h.
8334
8335 2019-01-22  Tom Tromey  <tom@tromey.com>
8336
8337         * stabsread.c (EXTERN): Do not define.
8338         (symnum, next_symbol_text_func, processing_gcc_compilation)
8339         (within_function, global_sym_chain, global_stabs)
8340         (previous_stab_code, this_object_header_files)
8341         (n_this_object_header_files)
8342         (n_allocated_this_object_header_files): Define.
8343         * stabsread.h (EXTERN): Never define.  Use "extern".
8344
8345 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8346
8347         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
8348         history_value.
8349
8350 2019-01-21  Tom Tromey  <tom@tromey.com>
8351
8352         * ui-out.c: Fix includes.
8353         * tui/tui-source.c: Fix includes.
8354         * target.c: Fix includes.
8355         * remote.c: Fix includes.
8356         * regcache.c: Fix includes.
8357         * python/py-block.c: Fix includes.
8358         * printcmd.c: Fix includes.
8359         * or1k-tdep.c: Fix includes.
8360         * mi/mi-main.c: Fix includes.
8361         * m32r-tdep.c: Fix includes.
8362         * csky-tdep.c: Fix includes.
8363         * compile/compile-cplus-types.c: Fix includes.
8364         * cli/cli-interp.c: Fix includes.
8365
8366 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
8367
8368         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8369         for padding.
8370
8371 2019-01-16  Tom Tromey  <tom@tromey.com>
8372
8373         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
8374         earlier.
8375         (struct objfile) <msymbols_range>: Move from top level.
8376         <msymbols>: New method.
8377         (class objfile_msymbols): Remove.
8378         * symtab.c (default_collect_symbol_completion_matches_break_on):
8379         Update.
8380         * symmisc.c (dump_msymbols): Update.
8381         * stabsread.c (scan_file_globals): Update.
8382         * objc-lang.c (info_selectors_command, info_classes_command)
8383         (find_methods): Update.
8384         * minsyms.c (find_solib_trampoline_target): Update.
8385         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
8386         * coffread.c (coff_symfile_read): Update.
8387         * ada-lang.c (ada_lookup_simple_minsym)
8388         (ada_collect_symbol_completion_matches): Update.
8389
8390 2019-01-16  Tom Tromey  <tom@tromey.com>
8391
8392         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
8393         type.  Remove no-argument constructor.
8394         <iterator::operator++>: Simplify.
8395         <begin>: Update.
8396         <end>: Use minimal_symbol_count.
8397
8398 2019-01-16  Tom Tromey  <tom@tromey.com>
8399
8400         * objfiles.h (struct objfile) <psymtabs>: New method.
8401         (class objfile_psymtabs): Remove.
8402         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
8403         typedef.
8404         <range>: New method.
8405         (require_partial_symbols): Change return type.
8406         * psymtab.c (require_partial_symbols)
8407         (psym_expand_symtabs_matching): Update.
8408         * mdebugread.c (parse_partial_symbols): Update.
8409         * dbxread.c (dbx_end_psymtab): Update.
8410
8411 2019-01-15  Tom Tromey  <tom@tromey.com>
8412
8413         * symtab.c (lookup_objfile_from_block)
8414         (lookup_symbol_in_objfile_symtabs)
8415         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
8416         (find_line_symtab, info_sources_command)
8417         (default_collect_symbol_completion_matches_break_on)
8418         (make_source_files_completion_list): Update.
8419         * symmisc.c (print_objfile_statistics, dump_objfile)
8420         (maintenance_print_symbols, maintenance_info_symtabs)
8421         (maintenance_check_symtabs, maintenance_info_line_tables):
8422         Update.
8423         * source.c (select_source_symtab)
8424         (forget_cached_source_info_for_objfile): Update.
8425         * objfiles.h (class objfile_compunits): Remove.
8426         (struct objfile) <compunits_range>: New typedef.
8427         (compunits): New method.
8428         * objfiles.c (objfile_relocate1): Update.
8429         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8430         * maint.c (count_symtabs_and_blocks): Update.
8431         * linespec.c (iterate_over_all_matching_symtabs): Update.
8432         * cp-support.c (add_symbol_overload_list_qualified): Update.
8433         * coffread.c (coff_symtab_read): Update.
8434         * ada-lang.c (add_nonlocal_symbols)
8435         (ada_collect_symbol_completion_matches)
8436         (ada_add_global_exceptions): Update.
8437
8438 2019-01-15  Tom Tromey  <tom@tromey.com>
8439
8440         * progspace.h (program_space) <objfiles_safe_range>: New
8441         typedef.
8442         <objfiles_safe>: New method.
8443         * objfiles.h (class all_objfiles_safe): Remove.
8444         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
8445         * jit.c (jit_inferior_exit_hook): Update.
8446
8447 2019-01-17  Tom Tromey  <tom@tromey.com>
8448
8449         * progspace.h (program_space) <objfiles_range>: New typedef.
8450         <objfiles>: New method.
8451         <objfiles_head>: Rename from objfiles.
8452         (object_files): Update.
8453         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
8454         * guile/scm-pretty-print.c
8455         (ppscm_find_pretty_printer_from_objfiles): Update.
8456         * guile/scm-objfile.c (gdbscm_objfiles): Update.
8457         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
8458         Update.
8459         * python/py-progspace.c (pspy_get_objfiles): Update.
8460         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8461         Update.
8462         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8463         (objfpy_lookup_objfile_by_build_id): Update.
8464         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8465         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8466         Update.
8467         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8468         (expand_symtab_containing_pc, lookup_objfile_from_block)
8469         (lookup_static_symbol, basic_lookup_transparent_type)
8470         (find_pc_sect_compunit_symtab, find_symbol_at_address)
8471         (find_line_symtab, info_sources_command)
8472         (default_collect_symbol_completion_matches_break_on)
8473         (make_source_files_completion_list, find_main_name): Update.
8474         * symmisc.c (print_symbol_bcache_statistics)
8475         (print_objfile_statistics, maintenance_print_symbols)
8476         (maintenance_print_msymbols, maintenance_print_objfiles)
8477         (maintenance_info_symtabs, maintenance_check_symtabs)
8478         (maintenance_expand_symtabs, maintenance_info_line_tables):
8479         Update.
8480         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
8481         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
8482         (map_overlay_command, unmap_overlay_command)
8483         (simple_overlay_update, expand_symtabs_matching)
8484         (map_symbol_filenames): Update.
8485         * symfile-debug.c (set_debug_symfile): Update.
8486         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
8487         Update.
8488         * source.c (select_source_symtab, forget_cached_source_info):
8489         Update.
8490         * solib.c (solib_read_symbols): Update.
8491         * solib-spu.c (append_ocl_sos): Update.
8492         * psymtab.c (maintenance_print_psymbols)
8493         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
8494         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
8495         * printcmd.c (info_symbol_command): Update.
8496         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
8497         Update.
8498         * objfiles.h (class all_objfiles): Remove.
8499         * objfiles.c (have_partial_symbols, have_full_symbols)
8500         (have_minimal_symbols, qsort_cmp, update_section_map)
8501         (shared_objfile_contains_address_p)
8502         (default_iterate_over_objfiles_in_search_order): Update.
8503         * objc-lang.c (info_selectors_command, info_classes_command)
8504         (find_methods): Update.
8505         * minsyms.c (find_solib_trampoline_target): Update.
8506         * maint.c (maintenance_info_sections)
8507         (maintenance_translate_address, count_symtabs_and_blocks):
8508         Update.
8509         * main.c (captured_main_1): Update.
8510         * linux-thread-db.c (try_thread_db_load_from_pdir)
8511         (has_libpthread): Update.
8512         * linespec.c (iterate_over_all_matching_symtabs)
8513         (search_minsyms_for_name): Update.
8514         * jit.c (jit_find_objf_with_entry_addr): Update.
8515         * hppa-tdep.c (find_unwind_entry)
8516         (hppa_lookup_stub_minimal_symbol): Update.
8517         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
8518         Update.
8519         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8520         (elf_gnu_ifunc_resolve_by_got): Update.
8521         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
8522         * dwarf-index-write.c (save_gdb_index_command): Update.
8523         * cp-support.c (add_symbol_overload_list_qualified): Update.
8524         * breakpoint.c (create_overlay_event_breakpoint)
8525         (create_longjmp_master_breakpoint)
8526         (create_std_terminate_master_breakpoint)
8527         (create_exception_master_breakpoint): Update.
8528         * blockframe.c (find_pc_partial_function): Update.
8529         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
8530         (ada_collect_symbol_completion_matches)
8531         (ada_add_global_exceptions): Update.
8532
8533 2019-01-17  Tom Tromey  <tom@tromey.com>
8534
8535         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
8536         declare VEC.
8537         (solib_target_parse_libraries): Change return type.
8538         (library_list_start_segment, library_list_start_section)
8539         (library_list_end_library, library_list_start_library); Update.
8540         (solib_target_free_library_list): Remove.
8541         (solib_target_parse_libraries): Remove cleanup.  Change return
8542         type.
8543         (solib_target_current_sos): Update.
8544
8545 2019-01-17  Tom Tromey  <tromey@bapiya>
8546
8547         * valprint.c: Replace "the the" with "the".
8548         * symtab.c: Replace "the the" with "the".
8549         * solib.c: Replace "the the" with "the".
8550         * solib-dsbt.c: Replace "the the" with "the".
8551         * linespec.c: Replace "the the" with "the".
8552         * dwarf2loc.h: Replace "the the" with "the".
8553         * amd64-windows-tdep.c: Replace "the the" with "the".
8554         * aarch64-tdep.c: Replace "the the" with "the".
8555
8556 2019-01-16  Keith Seitz  <keiths@redhat.com>
8557
8558         PR gdb/23773
8559         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
8560         <builder>: Rename to ..
8561         <m_builder>: ... this and make private.
8562         (dwarf2_cu::get_builder): New method.  Change all users of
8563         `builder' to use this method.
8564         (dwarf2_start_symtab): Move to ...
8565         (dwarf2_cu::start_symtab): ... here.  Update all callers
8566         (setup_type_unit_groups): Move to ...
8567         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
8568         callers.
8569         (dwarf2_cu::reset_builder): New method.
8570         (process_full_compunit, process_full_type_unit): Use
8571         dwarf2_cu::reset_builder.
8572         (follow_die_offset): Record the ancestor CU if it is different
8573         from the followed DIE's CU.
8574         (follow_die_sig_1): Likewise.
8575
8576 2019-01-15  Tom Tromey  <tom@tromey.com>
8577
8578         * remote.c (class remote_state) <buf>: Now a char_vector.
8579         <buf_size>: Remove.
8580         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
8581         parameter.
8582         (remote_target::getpkt_or_notif_sane_1)
8583         (remote_target::getpkt_sane)
8584         (remote_target::getpkt_or_notif_sane): Likewise.
8585         (class remote_target) <putpkt>: New overload.
8586         (remote_target::read_frame): Change type of "buf_p".  Remove
8587         sizeof_p parameter.
8588         (packet_ok): New overload.
8589         (packet_check_result): New overload.
8590         Update all uses.
8591
8592 2019-01-14  Tom Tromey  <tom@tromey.com>
8593
8594         * remote-notif.c (handle_notification, remote_notif_ack)
8595         (remote_notif_parse): Make "buf" const.
8596         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
8597         const.
8598         (remote_notif_parse, remote_notif_ack, handle_notification):
8599         Likewise.
8600         * remote.c (remote_notif_stop_parse): Make "buf" const.
8601         (remote_target::remote_parse_stop_reply): Make "buf" const.
8602         (remote_notif_stop_ack): Make "buf" const.
8603
8604 2019-01-14  Tom Tromey  <tom@tromey.com>
8605
8606         * remote.c (remote_console_output): Make parameter const.
8607
8608 2019-01-14  Tom Tromey  <tom@tromey.com>
8609
8610         * target-debug.h (target_debug_print_signals): Constify.
8611         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
8612         * procfs.c (procfs_target::pass_signals): Update.
8613         * linux-nat.c (linux_nat_target::pass_signals): Update.
8614         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
8615         * target-delegates.c: Rebuild.
8616         * remote.c (remote_target::program_signals): Update.
8617         (remote_target::pass_signals): Update.
8618         * target.c (target_pass_signals): Constify argument.
8619         (target_program_signals): Likewise.
8620         * target.h (struct target_ops) <pass_signals, program_signals>:
8621         Constify argument.
8622         (target_pass_signals, target_program_signals): Constify argument.
8623
8624 2019-01-14  Tom Tromey  <tom@tromey.com>
8625
8626         PR tui/28819:
8627         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
8628
8629 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
8630
8631         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
8632         field.
8633         * rs6000-tdep.c: Include reggroups.h.
8634         (IS_V_ALIAS_PSEUDOREG): Define.
8635         (rs6000_register_name): Return names for the "vX" aliases.
8636         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
8637         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
8638         aliases.  Call default_register_reggroup_p for all other
8639         pseudo-registers.
8640         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
8641         New functions.
8642         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
8643         Handle "vX" aliases.
8644         (v_alias_pseudo_register_collect): New function.
8645         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
8646         (rs6000_gdbarch_init): Initialize "vX" aliases as
8647         pseudo-registers.  Restore registration of
8648         rs6000_pseudo_register_reggroup_p with
8649         set_tdesc_pseudo_register_reggroup_p.
8650
8651 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
8652
8653         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
8654         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
8655         set_gdbarch_num_pseudo_regs.
8656
8657 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8658
8659         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
8660         Remove arg prefixname, add do_set and do_show.
8661         Add member functions set_list and show_list.
8662         * cli/cli-style.c (class cli_style_option): Update accordingly.
8663         (style_set_list): Move to file scope.
8664         (style_show_list): Likewise.
8665         (set_style): Call help_list.
8666         (show_style): Call cmd_show_list.
8667         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
8668         Update to use the new macro.
8669
8670 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
8671
8672         * ada-lang.c (_initialize_ada_language): Expand the help text
8673         for the "catch exception" command.
8674
8675 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8676
8677         * symtab.c (matching_obj_sections): Initialize obj,
8678         declare it closer to its usage.
8679
8680 2019-01-10  Tom Tromey  <tom@tromey.com>
8681
8682         * thread-iter.h (inf_threads_iterator): Use next_iterator.
8683         (basic_inf_threads_range): Remove.
8684         (inf_threads_range, inf_non_exited_threads_range)
8685         (safe_inf_threads_range): Use next_adapter.
8686
8687 2019-01-10  Keith Seitz  <keiths@redhat.com>
8688
8689         PR gdb/23712
8690         PR symtab/23010
8691         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
8692         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
8693
8694 2019-01-10  Keith Seitz  <keiths@redhat.com>
8695
8696         PR gdb/23712
8697         PR symtab/23010
8698         * dictionary.c (pending_to_vector): Remove.
8699         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8700         Remove _1 suffix, replacing functions of the same name.  Update
8701         all callers.
8702         (dict_create_hashed, dict_create_hashed_expandable)
8703         (dict_create_linear, dict_create_linear_expandable, dict_free)
8704         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
8705         Make functions static.
8706
8707 2019-01-10  Keith Seitz  <keiths@redhat.com>
8708
8709         PR gdb/23712
8710         PR symtab/23010
8711         * dictionary.h (struct dictionary): Replace declaration with
8712         multidictionary.
8713         (dict_create_hashed, dict_create_hashed_expandable)
8714         (dict_create_linear, dict_create_linear_expandable)
8715         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
8716         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
8717         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
8718         taking multidictionary argument.
8719         [ALL_DICT_SYMBOLS]: Update for multidictionary.
8720         * block.h (struct block) <dict>: Change to multidictionary
8721         and rename `multidict'.
8722         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
8723         symmisc.c: Update all dictionary references to multidictionary.
8724
8725 2019-01-10  Keith Seitz  <keiths@redhat.com>
8726
8727         PR gdb/23712
8728         PR symtab/23010
8729         * dictionary.c: Include unordered_map.
8730         (pending_to_vector): New function.
8731         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8732         Rewrite the non-"_1" functions to take vector instead
8733         of linked list.
8734         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
8735         "new" _1 versions of the same name.
8736         (multidictionary): Define.
8737         (std::hash<enum language): New definition.
8738         (collate_pending_symbols_by_language, mdict_create_hashed)
8739         (mdict_create_hashed_expandable, mdict_create_linear)
8740         (mdict_create_linear_expandable, mdict_free)
8741         (find_language_dictionary, create_new_language_dictionary)
8742         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
8743         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
8744         (mdict_size, mdict_empty): New functions.
8745         * dictionary.h (mdict_iterator): Define.
8746
8747 2019-01-10  Pedro Alves  <palves@redhat.com>
8748
8749         * breakpoint.c (read_uploaded_action)
8750         (create_tracepoint_from_upload): Adjust to use
8751         gdb::unique_xmalloc_ptr.
8752         * ctf.c (ctf_write_uploaded_tp):
8753         (SET_ARRAY_FIELD): Use emplace_back.
8754         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
8755         * tracefile-tfile.c (tfile_write_uploaded_tp):
8756         * tracepoint.c (parse_tracepoint_definition): Adjust to use
8757         gdb::unique_xmalloc_ptr.
8758         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
8759         at_string, cond_string, cmd_strings>: Replace char pointers
8760         with gdb::unique_xmalloc_ptr.
8761
8762 2019-01-10  Pedro Alves  <palves@redhat.com>
8763
8764         * solib-target.c (library_list_start_library): Don't xstrdup name.
8765
8766 2019-01-10  Pedro Alves  <palves@redhat.com>
8767
8768         * mdebugread.c (parse_partial_symbols): Use
8769         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
8770
8771 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8772
8773         * linux-fork.c (scoped_switch_fork_info)
8774         <~scoped_switch_fork_info>: Fix incorrect variable name.
8775
8776 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8777
8778         * linux-fork.c (scoped_switch_fork_info)
8779         <scoped_switch_fork_info>: Make explicit.
8780         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
8781
8782 2019-01-10  Tom Tromey  <tom@tromey.com>
8783
8784         * objfiles.h (objfile::reset_psymtabs): Update.
8785         * objfiles.c (objfile::objfile): Update.
8786         * psymtab.h (psymtab_storage::obstack): Update.
8787         (psymtab_storage::m_obstack): Use gdb::optional.
8788         (class psymtab_storage): Update comment.  Remove objfile
8789         parameter.
8790         * psymtab.c (psymtab_storage::psymtab_storage): Update.
8791
8792 2019-01-10  Tom Tromey  <tom@tromey.com>
8793
8794         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
8795         <free_psymtabs>: Now private.
8796         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
8797         (allocate_psymtab): Use new method.
8798
8799 2019-01-10  Tom Tromey  <tom@tromey.com>
8800
8801         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
8802         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
8803         * mdebugread.c (parse_partial_symbols): Use
8804         allocate_dependencies.
8805         * dwarf2read.c (dwarf2_create_include_psymtab): Use
8806         allocate_dependencies.
8807         (process_psymtab_comp_unit_reader)
8808         (build_type_psymtab_dependencies): Likewise.
8809         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
8810
8811 2019-01-10  Tom Tromey  <tom@tromey.com>
8812
8813         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
8814         PSYMBOL_SET_LANGUAGE.
8815         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
8816
8817 2019-01-10  Tom Tromey  <tom@tromey.com>
8818
8819         * psymtab.h (psymtab_storage::obstack): New method.
8820         <m_obstack>: Rename from obstack; now private.
8821         * psymtab.c (psymtab_storage): Update.
8822         * dwarf2read.c (create_addrmap_from_index)
8823         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
8824         Update.
8825
8826 2019-01-10  Tom Tromey  <tom@tromey.com>
8827
8828         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
8829         * objfiles.h (objfile::reset_psymtabs): New method.
8830
8831 2019-01-10  Tom Tromey  <tom@tromey.com>
8832
8833         * symmisc.c (print_symbol_bcache_statistics): Update.
8834         (print_objfile_statistics): Update.
8835         * symfile.c (reread_symbols): Update.
8836         * psymtab.h (class psymtab_storage): New.
8837         * psymtab.c (psymtab_storage): New constructor.
8838         (~psymtab_storage): New destructor.
8839         (require_partial_symbols): Update.
8840         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
8841         (find_pc_sect_psymtab, find_pc_sect_psymbol)
8842         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
8843         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
8844         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
8845         (start_psymtab_common, end_psymtab_common)
8846         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
8847         (allocate_psymtab): Update.
8848         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
8849         Update.
8850         (dump_psymtab_addrmap, maintenance_print_psymbols)
8851         (maintenance_check_psymtabs): Update.
8852         (class objfile_psymtabs): Move to objfiles.h.
8853         * psympriv.h (discard_psymtab): Now inline.
8854         (psymtab_discarder::psymtab_discarder): Update.
8855         (psymtab_discarder::~psymtab_discarder): Update.
8856         (ALL_OBJFILE_PSYMTABS): Rewrite.
8857         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
8858         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
8859         Remove fields.
8860         <partial_symtabs>: New field.
8861         (class objfile_psymtabs): Move from psymtab.h.  Update.
8862         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
8863         psymbol_cache.
8864         (objfile::~objfile): Don't destroy psymbol_cache.
8865         * mdebugread.c (parse_partial_symbols): Update.
8866         * dwarf2read.c (create_addrmap_from_index)
8867         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
8868         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
8869         (add_partial_subprogram, dwarf2_ranges_read): Update.
8870         * dwarf-index-write.c (write_address_map)
8871         (write_one_signatured_type, recursively_write_psymbols)
8872         (class debug_names, class debug_names, write_psymtabs_to_index):
8873         Update.
8874
8875 2019-01-10  Tom Tromey  <tom@tromey.com>
8876
8877         * symtab.h (SYMBOL_SET_NAMES): Update.
8878         (symbol_set_names): Update.
8879         (MSYMBOL_SET_NAMES): Update.
8880         * symtab.c (symbol_set_names): Change argument to be an
8881         objfile_per_bfd_storage.
8882         * psymtab.c (add_psymbol_to_bcache): Update.
8883         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
8884
8885 2019-01-10  Tom Tromey  <tom@tromey.com>
8886
8887         * symtab.c (create_demangled_names_hash): Change argument to be an
8888         objfile_per_bfd_storage.
8889         (symbol_set_names): Update.
8890
8891 2019-01-10  Tom Tromey  <tom@tromey.com>
8892
8893         * xcoffread.c (xcoff_initial_scan): Unconditionally call
8894         init_psymbol_list.
8895         * psymtab.c (init_psymbol_list): Do nothing if already called.
8896         * psympriv.h (init_psymbol_list): Add comment.
8897         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
8898         init_psymbol_list.
8899         * dbxread.c (dbx_symfile_read): Unconditionally call
8900         init_psymbol_list.
8901
8902 2019-01-10  Tom Tromey  <tom@tromey.com>
8903
8904         * xcoffread.c (scan_xcoff_symtab): Update.
8905         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
8906         "where".
8907         * mdebugread.c (parse_partial_symbols)
8908         (handle_psymbol_enumerators): Update.
8909         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
8910         * dbxread.c (read_dbx_symtab): Update.
8911         * psympriv.h (psymbol_placement): New enum.
8912         (add_psymbol_to_list): Update.
8913
8914 2019-01-10  Tom Tromey  <tom@tromey.com>
8915
8916         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
8917         static_psymbols parameters.
8918         (scan_xcoff_symtab): Update.
8919         * psymtab.c (start_psymtab_common): Remove global_psymbols and
8920         static_psymbols parameters.
8921         * psympriv.h (start_psymtab_common): Update.
8922         * mdebugread.c (parse_partial_symbols): Update.
8923         * dwarf2read.c (create_partial_symtab): Update.
8924         * dbxread.c (read_dbx_symtab): Update.
8925         (start_psymtab): Remove global_psymbols and static_psymbols
8926         parameters.
8927
8928 2019-01-10  Tom Tromey  <tom@tromey.com>
8929
8930         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
8931         * psymtab.c (allocate_psymtab): Add comment.
8932         * psympriv.h (allocate_psymtab): Add comment.
8933         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
8934         initializations.
8935         * dbxread.c (dbx_end_psymtab): Remove some initializations.
8936
8937 2019-01-10  Tom Tromey  <tom@tromey.com>
8938
8939         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8940         Don't declare.
8941         * mipsread.c: Include mdebugread.h.
8942         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8943         Declare.
8944         * elfread.c: Include mdebugread.h.
8945
8946 2019-01-09  Tom Tromey  <tom@tromey.com>
8947
8948         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
8949         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
8950         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
8951         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
8952         (psym_lookup_symbol, psym_find_last_source_symtab)
8953         (psym_forget_cached_source_info, psym_print_stats)
8954         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
8955         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
8956         (psym_map_matching_symbols, psym_expand_symtabs_matching)
8957         (psym_find_compunit_symtab_by_address)
8958         (maintenance_print_psymbols, maintenance_info_psymtabs)
8959         (maintenance_check_psymtabs): Use ranged for.
8960         * psymtab.h (class objfile_psymtabs): New.
8961         (require_partial_symbols): Return objfile_psymtabs.
8962         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
8963
8964 2019-01-09  Tom Tromey  <tom@tromey.com>
8965
8966         * symfile.c (overlay_invalidate_all, find_pc_overlay)
8967         (find_pc_mapped_section, list_overlays_command)
8968         (map_overlay_command, unmap_overlay_command)
8969         (simple_overlay_update): Use all_objfiles.
8970         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
8971         * printcmd.c (info_symbol_command): Use all_objfiles.
8972         * objfiles.h (ALL_OBJSECTIONS): Remove.
8973         * maint.c (maintenance_translate_address): Use all_objfiles.
8974         * gcore.c (gcore_create_callback): Use all_objfiles.
8975         (objfile_find_memory_regions): Likewise.
8976
8977 2019-01-09  Tom Tromey  <tom@tromey.com>
8978
8979         * symtab.c (find_line_symtab, info_sources_command)
8980         (make_source_files_completion_list): Use objfile_compunits.
8981         * source.c (select_source_symtab): Use objfile_compunits.
8982         * objfiles.h (struct objfile): Update comment.
8983         (ALL_OBJFILES): Remove.
8984         (ALL_FILETABS): Remove.
8985         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
8986         objfile_compunits.
8987
8988 2019-01-09  Tom Tromey  <tom@tromey.com>
8989
8990         * symmisc.c (print_objfile_statistics, dump_objfile)
8991         (maintenance_print_symbols): Use compunit_filetabs.
8992         * source.c (forget_cached_source_info_for_objfile): Use
8993         compunit_filetabs.
8994         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
8995         (ALL_FILETABS): Use compunit_filetabs.
8996         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
8997         * coffread.c (coff_symtab_read): Use compunit_filetabs.
8998
8999 2019-01-09  Tom Tromey  <tom@tromey.com>
9000
9001         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9002         (compunit_filetabs): New.
9003         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9004         compunit_filetabs.
9005         (info_sources_command, make_source_files_completion_list): Remove
9006         declaration.
9007         * symmisc.c (print_objfile_statistics, dump_objfile)
9008         (maintenance_print_symbols): Remove declaration.
9009         (maintenance_info_symtabs): Use compunit_filetabs.
9010         (maintenance_info_line_tables): Likewise.
9011         * source.c (select_source_symtab): Change local variable name.
9012         (forget_cached_source_info_for_objfile): Remove declaration.
9013         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9014         * objfiles.c (objfile_relocate1): Remove declaration.
9015         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9016         declaration.
9017         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9018         * coffread.c (coff_symtab_read): Remove declaration.
9019         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9020         compunit_filetabs.
9021
9022 2019-01-09  Tom Tromey  <tom@tromey.com>
9023
9024         * symtab.c (lookup_objfile_from_block)
9025         (find_pc_sect_compunit_symtab, search_symbols)
9026         (default_collect_symbol_completion_matches_break_on): Use
9027         objfile_compunits.
9028         * objfiles.h (ALL_COMPUNITS): Remove.
9029         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9030         * cp-support.c (add_symbol_overload_list_qualified): Use
9031         objfile_compunits.
9032         * ada-lang.c (ada_collect_symbol_completion_matches)
9033         (ada_add_global_exceptions): Use objfile_compunits.
9034
9035 2019-01-09  Tom Tromey  <tom@tromey.com>
9036
9037         * source.c (select_source_symtab)
9038         (forget_cached_source_info_for_objfile): Remove declaration.
9039         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9040         declaration.
9041         * maint.c (count_symtabs_and_blocks): Remove declaration.
9042         * cp-support.c (add_symbol_overload_list_qualified): Remove
9043         declaration.
9044         * coffread.c (coff_symtab_read): Remove declaration.
9045         * symtab.c (lookup_symbol_in_objfile_symtabs)
9046         (basic_lookup_transparent_type_1): Use objfile_compunits.
9047         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9048         (info_sources_command, search_symbols)
9049         (default_collect_symbol_completion_matches_break_on)
9050         (make_source_files_completion_list): Remove declaration.
9051         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9052         (ada_collect_symbol_completion_matches)
9053         (ada_add_global_exceptions): Remove declaration.
9054         * linespec.c (iterate_over_all_matching_symtabs): Use
9055         objfile_compunits.
9056         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9057         (class objfile_compunits): New.
9058         (ALL_COMPUNITS): Use objfile_compunits.
9059         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9060         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9061         objfile_compunits.
9062         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9063
9064 2019-01-09  Tom Tromey  <tom@tromey.com>
9065
9066         * symtab.c (search_symbols)
9067         (default_collect_symbol_completion_matches_break_on): Use
9068         objfile_msymbols.
9069         * ada-lang.c (ada_lookup_simple_minsym)
9070         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9071         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9072         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9073         objfile_msymbols.
9074         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9075         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9076         * objc-lang.c (find_methods): Use objfile_msymbols.
9077         (info_selectors_command, info_classes_command): Likewise.
9078         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9079         * objfiles.h (class objfile_msymbols): New.
9080         (ALL_OBJFILE_MSYMBOLS): Remove.
9081         (ALL_MSYMBOLS): Remove.
9082
9083 2019-01-09  Tom Tromey  <tom@tromey.com>
9084
9085         * common/next-iterator.h (next_adapter): Add Iterator template
9086         parameter.
9087         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9088         (class all_objfiles_safe): New.
9089         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9090         * objfiles.c (put_objfile_before): Update comment.
9091         (add_separate_debug_objfile): Likewise.
9092         (free_all_objfiles): Use all_objfiles_safe.
9093         (objfile_purge_solibs): Likewise.
9094
9095 2019-01-09  Tom Tromey  <tom@tromey.com>
9096
9097         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9098         (expand_symtab_containing_pc, lookup_static_symbol)
9099         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9100         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9101         all_objfiles.
9102         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9103         * breakpoint.c (create_overlay_event_breakpoint)
9104         (create_longjmp_master_breakpoint)
9105         (create_std_terminate_master_breakpoint)
9106         (create_exception_master_breakpoint): Use all_objfiles.
9107         * linux-thread-db.c (try_thread_db_load_from_pdir)
9108         (has_libpthread): Use all_objfiles.
9109         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9110         * linespec.c (iterate_over_all_matching_symtabs)
9111         (search_minsyms_for_name): Use all_objfiles.
9112         * maint.c (maintenance_info_sections): Use all_objfiles.
9113         * main.c (captured_main_1): Use all_objfiles.
9114         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9115         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9116         * guile/scm-pretty-print.c
9117         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9118         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9119         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9120         (maintenance_print_msymbols): Use all_objfiles.
9121         * source.c (select_source_symtab): Use all_objfiles.
9122         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9123         * symfile.c (remove_symbol_file_command)
9124         (expand_symtabs_matching, map_symbol_filenames): Use
9125         all_objfiles.
9126         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9127         all_objfiles.
9128         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9129         * objc-lang.c (find_methods): Use all_objfiles.
9130         * objfiles.c (have_partial_symbols, have_full_symbols)
9131         (have_minimal_symbols, qsort_cmp)
9132         (default_iterate_over_objfiles_in_search_order): Use
9133         all_objfiles.
9134         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9135         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9136         (maintenance_check_psymtabs): Use all_objfiles.
9137         (ALL_PSYMTABS): Remove.
9138         * compile/compile-object-run.c (do_module_cleanup): Use
9139         all_objfiles.
9140         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9141         * cp-support.c (add_symbol_overload_list_qualified): Use
9142         all_objfiles.
9143         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9144         Use all_objfiles.
9145         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9146         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9147         all_objfiles.
9148         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9149         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9150         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9151         Uses all_objfiles.
9152         * solib.c (solib_read_symbols): Use all_objfiles
9153
9154 2019-01-09  Tom Tromey  <tom@tromey.com>
9155
9156         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9157         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9158         all_objfiles.
9159         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9160         * symmisc.c (print_symbol_bcache_statistics)
9161         (print_objfile_statistics, maintenance_print_objfiles)
9162         (maintenance_info_symtabs, maintenance_check_symtabs)
9163         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9164         all_objfiles.
9165         * source.c (forget_cached_source_info): Use all_objfiles.
9166         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9167         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9168         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9169         * objfiles.c (update_section_map): Use all_objfiles.
9170         (shared_objfile_contains_address_p): Likewise.
9171         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9172         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9173
9174 2019-01-09  Tom Tromey  <tom@tromey.com>
9175
9176         * common/next-iterator.h: New file.
9177         * objfiles.h (class all_objfiles): New.
9178         (struct objfile_iterator): New.
9179
9180 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9181
9182         * NEWS: Move the description of the changed "frame", "select-frame",
9183          and "info frame" commands to the Changed commands section.
9184
9185 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9186
9187         * gdbtypes.c (check_stub_method_group): Remove handling of old
9188         mangling schemes.
9189         * linespec.c (find_methods): Likewise.
9190         * stabsread.c (read_member_functions): Likewise.
9191         * valops.c (search_struct_method): Likewise.
9192         (value_struct_elt_for_reference): Likewise.
9193         * NEWS: Mention this change.
9194
9195 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9196
9197         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9198         print_source_lines.
9199         * source.c (print_source_lines_base): Update line number check.
9200         (print_source_lines): New function.
9201         (source_lines_range::source_lines_range): New function.
9202         * source.h (class source_lines_range): New class.
9203         (print_source_lines): New declaration.
9204
9205 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9206
9207         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9208
9209 2019-01-08  Tom Tromey  <tom@tromey.com>
9210             Simon Marchi  <simon.marchi@ericsson.com>
9211
9212         PR gdb/24060
9213         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9214         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9215         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9216         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9217         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9218         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9219
9220 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9221
9222         * source.c (select_source_symtab): Move header comment to
9223         declaration in source.h.
9224         (forget_cached_source_info_for_objfile): Likewise.
9225         (forget_cached_source_info): Likewise.
9226         (identify_source_line): Likewise.
9227         * source.h (identify_source_line): Move declaration from symtab.h
9228         and add comment from source.c
9229         (print_source_lines): Likewise.
9230         (forget_cached_source_info_for_objfile): Likewise.
9231         (forget_cached_source_info): Likewise.
9232         (select_source_symtab): Likewise.
9233         (enum print_source_lines_flag): Move definition from symtab.h.
9234         * symtab.h (identify_source_line): Move declaration to source.h.
9235         (print_source_lines): Likewise.
9236         (forget_cached_source_info_for_objfile): Likewise.
9237         (forget_cached_source_info): Likewise.
9238         (select_source_symtab): Likewise.
9239         (enum print_source_lines_flag): Move definition to source.h.
9240         * tui/tui-hooks.c: Add 'source.h' include.
9241
9242 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9243
9244         * source.c (print_source_lines_base): Handle requests to print
9245         reverse line number sequences, and guard against empty lines
9246         string.
9247
9248 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9249
9250         * source.c (print_source_lines_base): Fix skip of '\r' if next
9251         character is '\n'.
9252
9253 2019-01-06  Tom Tromey  <tom@tromey.com>
9254
9255         * c-exp.y (struct c_parse_state) <macro_original_text,
9256         expansion_obstack>: New member.
9257         (macro_original_text, expansion_obstack): Remove globals.
9258         (scan_macro_expansion, scanning_macro_expansion)
9259         (finished_macro_expansion): Update.
9260         (scan_macro_cleanup): Remove.
9261         (yylex, c_parse): Update.
9262
9263 2019-01-06  Tom Tromey  <tom@tromey.com>
9264
9265         * c-exp.y (struct c_parse_state) <strings>: New member.
9266         (operator_stoken): Update.
9267
9268 2019-01-06  Tom Tromey  <tom@tromey.com>
9269
9270         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9271         (union type_stack_elt) <typelist_val>: Now a pointer to
9272         std::vector.
9273         (type_stack_cleanup): Don't declare.
9274         (push_typelist): Update.
9275         * parse.c (pop_typelist): Return a std::vector.
9276         (push_typelist): Take a std::vector.
9277         (follow_types): Update.  Do not free args.
9278         (type_stack_cleanup): Remove.
9279         * c-exp.y (struct c_parse_state): New.
9280         (cpstate): New global.
9281         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
9282         (nonempty_typelist): Update.
9283         (func_mod): Create a new vector.
9284         (c_parse): Create a c_parse_state.
9285         (check_parameter_typelist): Do not delete params.
9286         (function_method): Update.  Do not delete type_list.
9287
9288 2019-01-06  Tom Tromey  <tom@tromey.com>
9289
9290         PR gdb/28155:
9291         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
9292         check_typedef.
9293         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
9294         (print_return_value): Likewise.
9295
9296 2019-01-05  Tom Tromey  <tom@tromey.com>
9297
9298         * contrib/cleanup_check.py: Remove.
9299         * contrib/gcc-with-excheck: Remove.
9300         * contrib/exsummary.py: Remove.
9301         * contrib/excheck.py: Remove.
9302
9303 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
9304
9305         * thread.c (delete_thread_1): Add gdb_assert that THR is not
9306         NULL. Initialize tpprev to NULL instead of assigning it
9307         to NULL on the next statement.
9308         * windows-nat.c (windows_delete_thread): Remove check for
9309         main_thread_id before printing thread exit notifications.
9310         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
9311         Remove thread ID check against main_thread_id.
9312         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
9313         windows_delete_thread.
9314         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
9315
9316 2019-01-04  Tom Tromey  <tom@tromey.com>
9317
9318         * compile/compile.c (_initialize_compile): Use upper case for
9319         metasyntactic variables.
9320         * symmisc.c (_initialize_symmisc): Use upper case for
9321         metasyntactic variables.
9322         * psymtab.c (_initialize_psymtab): Use upper case for
9323         metasyntactic variables.
9324         * demangle.c (demangle_command): Use upper case for metasyntactic
9325         variables.
9326         (_initialize_demangler): Likewise.
9327         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
9328         variables.
9329
9330 2019-01-03  Tom Tromey  <tom@tromey.com>
9331
9332         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
9333
9334 2019-01-03  Tom Tromey  <tom@tromey.com>
9335
9336         * python/py-symtab.c (salpy_str): Update.
9337         (struct salpy_sal_object) <symtab>: Now a PyObject.
9338         (salpy_dealloc): Update.
9339         (del_objfile_sal): Use gdbpy_ref.
9340
9341 2019-01-03  Tom Tromey  <tom@tromey.com>
9342
9343         * python/py-type.c (convert_field): Use new_reference.  Return
9344         gdbpy_ref.
9345         (make_fielditem): Return gdbpy_ref.
9346         (typy_fields): Update.
9347         (typy_getitem): Update.
9348         (field_name): Return gdbpy_ref.  Use new_reference.
9349         (typy_iterator_iternext): Update.
9350
9351 2019-01-03  Tom Tromey  <tom@tromey.com>
9352
9353         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
9354
9355 2019-01-03  Tom Tromey  <tom@tromey.com>
9356
9357         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
9358         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
9359         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
9360         (pspy_set_frame_filters, pspy_set_frame_unwinders)
9361         (pspy_set_type_printers): Likewise.
9362         * python/py-function.c (fnpy_init): Use gdbpy_ref.
9363         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
9364         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
9365         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
9366         (objfpy_set_type_printers): Likewise.
9367
9368 2019-01-03  Tom Tromey  <tom@tromey.com>
9369
9370         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
9371         (gdbpy_print_stack): Use gdbpy_err_fetch.
9372         * python/python-internal.h (class gdbpy_err_fetch): New class.
9373         (class gdbpy_enter) <m_error_type, m_error_value,
9374         m_error_traceback>: Remove.
9375         <m_error>: New member.
9376         (gdbpy_exception_to_string): Don't declare.
9377         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
9378         * python/py-value.c (convert_value_from_python): Use
9379         gdbpy_err_fetch.
9380         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
9381         gdbpy_exception_to_string.
9382         (gdbpy_handle_exception): Use gdbpy_err_fetch.
9383         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
9384         gdbpy_err_fetch.
9385
9386 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9387
9388         * linux-nat.c (delete_lwp_cleanup): Delete.
9389         (struct lwp_deleter): New struct.
9390         (lwp_info_up): New typedef.
9391         (linux_nat_target::follow_fork): Delete cleanup, and make use of
9392         lwp_info_up.
9393
9394 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9395
9396         * linux-fork.c (class scoped_switch_fork_info): New class.
9397         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
9398
9399 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9400
9401         * valops.c (find_overload_match): Remove use of null_cleanup, and
9402         calls to do_cleanups.
9403
9404 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9405
9406         * compile/compile-cplus-types.c
9407         (compile_cplus_instance::decl_name): Handle changes to
9408         cp_func_name.
9409         * cp-support.c (cp_func_name): Update header comment, update
9410         return type.
9411         * cp-support.h (cp_func_name): Update return type in declaration.
9412         * valops.c (find_overload_match): Move temp_func local to top
9413         level of function and change its type.  Use temp_func to hold and
9414         delete temporary string obtained from cp_func_name.
9415
9416 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9417
9418         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
9419         gdb::char_vector, remove cleanup, and update uses of `msg`.
9420
9421 2019-01-03  Jim Wilson  <jimw@sifive.com>
9422
9423         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
9424
9425 2019-01-02  Tom Tromey  <tom@tromey.com>
9426
9427         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
9428         (tdesc_parse_xml): Remove cleanups.
9429         * target-descriptions.h (make_cleanup_free_target_description):
9430         Don't declare.
9431         (target_desc_deleter): New struct.
9432         (target_desc_up): New typedef.
9433         * target-descriptions.c (target_desc_deleter::operator()): Rename
9434         from free_target_description.
9435         (make_cleanup_free_target_description): Remove.
9436
9437 2019-01-02  Tom Tromey  <tom@tromey.com>
9438
9439         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
9440         constructor, destructor.
9441         (linespec_parser): Remove typedef.
9442         (~linespec_parser): Rename from linespec_parser_delete.
9443         (linespec_lex_to_end, linespec_complete_label)
9444         (linespec_complete): Update.
9445         (decode_line_full): Remove cleanups.
9446         (decode_line_1): Update.
9447
9448 2019-01-02  Tom Tromey  <tom@tromey.com>
9449
9450         * python/python-internal.h (inferior_to_inferior_object): Change
9451         return type.
9452         * python/py-exitedevent.c (create_exited_event_object): Update.
9453         * python/py-inferior.c (inferior_to_inferior_object): Return
9454         gdbpy_ref.
9455         (python_new_inferior, python_inferior_deleted)
9456         (thread_to_thread_object, delete_thread_object)
9457         (build_inferior_list, gdbpy_selected_inferior): Update.
9458         * python/py-infthread.c (create_thread_object): Update.  Also fail
9459         if inferior_to_inferior_object fails.
9460
9461 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
9462
9463         * inferior.h (class inferior) <displaced_step_state>: New field.
9464         * infrun.h (struct displaced_step_state): Move here from
9465         infrun.c.  Initialize fields, add constructor.
9466         <inf>: Remove field.
9467         <reset>: New method.
9468         * infrun.c (struct displaced_step_inferior_state): Move to
9469         infrun.h.
9470         (displaced_step_inferior_states): Remove.
9471         (get_displaced_stepping_state): Adust.
9472         (displaced_step_in_progress_any_inferior): Adjust.
9473         (displaced_step_in_progress_thread): Adjust.
9474         (displaced_step_in_progress): Adjust.
9475         (add_displaced_stepping_state): Remove.
9476         (get_displaced_step_closure_by_addr): Adjust.
9477         (remove_displaced_stepping_state): Remove.
9478         (infrun_inferior_exit): Call displaced_step_state.reset.
9479         (use_displaced_stepping): Don't check for NULL.
9480         (displaced_step_prepare_throw): Call
9481         get_displaced_stepping_state.
9482         (displaced_step_fixup): Don't check for NULL.
9483         (prepare_for_detach): Don't check for NULL.
9484
9485 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9486
9487         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
9488          in case of call that did not complete.
9489
9490 2019-01-02  Andrey Utkin  <autkin@undo.io>
9491
9492         * symfile.c (find_separate_debug_file): Fix search of debug files for
9493         remote debuggee.
9494
9495 2019-01-02  Tom Tromey  <tom@tromey.com>
9496
9497         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
9498         indentation.
9499         * python/py-frame.c (frapy_older): Remove cast.
9500         (frapy_newer): Likewise.
9501         * python/py-breakpoint.c (local_setattro): Remove cast.
9502         * python/py-arch.c (archpy_name): Remove local variable.
9503         * python/py-type.c (gdbpy_lookup_type): Remove cast.
9504
9505 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
9506
9507         * unittests/basic_string_view/element_access/char/empty.cc:
9508         Fix year range in copyright header.
9509
9510 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9511
9512         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
9513         Delete.
9514         <operator==>: Update with for removed field.
9515         <hash>: Likewise.
9516         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
9517         <isa_features>: ...this.
9518         <abi_features>: New field.
9519         (riscv_isa_flen): Update comment.
9520         (riscv_abi_xlen): New declaration.
9521         (riscv_abi_flen): New declaration.
9522         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
9523         isa_features.
9524         (riscv_abi_xlen): New function.
9525         (riscv_isa_flen): Update to get answer from isa_features.
9526         (riscv_abi_flen): New function.
9527         (riscv_has_fp_abi): Update to get answer from abi_features.
9528         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
9529         xlen and flen.
9530         (riscv_call_info) <xlen, flen>: Update comment.
9531         (riscv_call_arg_struct): Remove invalid assertions
9532         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
9533         is removed.
9534         (riscv_gdbarch_init): Gather isa features and abi features
9535         separately, ensure both match on the gdbarch when reusing an old
9536         gdbarch.  Relax an error check to allow 32-bit abi float to run on
9537         a target with 64-bit float hardware.
9538
9539 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9540
9541         * source.c (search_command_helper): Stop reverse search
9542         when line 1 has been searched.
9543
9544 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9545
9546         * record-full.c (record_full_base_target::close): Rewrite
9547         record_full_core_buf_list free logic.
9548
9549 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9550
9551         * break-catch-syscall.c (print_one_catch_syscall): xfree
9552         the last text.
9553
9554 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9555
9556         * top.c (print_gdb_version): Update Copyright year in version
9557         message.
9558
9559 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9560
9561         Update copyright year range in all GDB files.
9562
9563 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
9564
9565         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
9566
9567 For older changes see ChangeLog-2018.
9568 \f
9569 Local Variables:
9570 mode: change-log
9571 left-margin: 8
9572 fill-column: 74
9573 version-control: never
9574 coding: utf-8
9575 End:
9576