gdb/ChangeLog

   1 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
   2
   3         PR gdb/24592
   4         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
   5         function.
   6         (fill_gregset): Call amd64_linux_collect_native_gregset instead
   7         of amd64_collect_native_gregset.
   8         (amd64_linux_nat_target::store_registers): Likewise.
   9
  10 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
  11
  12         * version.in: Set GDB version number to 8.3.0.DATE-git.
  13
  14 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
  15
  16         GDB 8.3 released.
  17
  18 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
  19
  20         * version.in: Set GDB version number to 8.3.
  21
  22 2019-05-08  Tom Tromey  <tromey@adacore.com>
  23
  24         * utils.c (fputs_maybe_filtered): Reset style after paging, even
  25         when no wrap column is set.
  26
  27 2019-05-04  Tom Tromey  <tom@tromey.com>
  28
  29         * psymtab.c (psymbol_name_matches, match_partial_symbol)
  30         (lookup_partial_symbol, print_partial_symbols)
  31         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
  32         (psymbol_compare): Update.
  33         (add_psymbol_to_bcache): Clear the entire psymbol.
  34         (maintenance_check_psymtabs): Update.
  35         * psympriv.h (struct partial_symbol): Don't derive from
  36         general_symbol_info.
  37         <obj_section, unrelocated_address, address,
  38         set_unrelocated_address>: Update.
  39         <ginfo>: New member.
  40         * dwarf-index-write.c (write_psymbols, debug_names::insert)
  41         (debug_names::write_psymbols): Update.
  42
  43 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
  44
  45         * windows-nat.c [_WIN32_WINNT]: Define _WIN32_WINNT to Windows XP
  46         level, so that various Windows header files expose the necessary
  47         declarations and definitions.
  48
  49         * symfile.c (find_separate_debug_file): Remove colon from the
  50         drive spec of DOS/Windows file names of the target, so that the
  51         file name produced from DEBUGDIR and the target's directory will
  52         be valid on DOS/Windows systems.
  53
  54 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
  55
  56         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
  57         Use current_event.dwThreadId instead of main_thread_id.
  58
  59 2019-04-30  Tom Tromey  <tromey@adacore.com>
  60
  61         PR c++/24470:
  62         * dwarf2read.c (process_structure_scope): Handle case where type
  63         has template parameters but no symbol was created.
  64
  65 2019-04-19  Sergei Trofimovich <siarheit@google.com>
  66
  67         * configure.ac: add --enable-source-highlight switch.
  68         * configure: Regenerate.
  69         * top.c (print_gdb_version): plumb --enable-source-highlight
  70         status to "show configuration".
  71
  72 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
  73
  74         PR symtab/24423:
  75         * source.c (print_source_lines_base): Advance "iter" when a
  76         control character is seen.
  77
  78 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  79
  80         * inferior.h (struct infcall_suspend_state_deleter):
  81         Catch exception in destructor to avoid crash.
  82
  83 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
  84
  85         * utils.c (prompt_for_continue): Don't restore the styling at the
  86         end, as applied_style has the wrong value.  This fixes styling in
  87         long lists of file names that are interrupted by the "Continue?"
  88         prompt.
  89
  90 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
  91
  92         * version.in: Set GDB version number to 8.2.91.DATE-git.
  93
  94 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
  95
  96         GDB 8.2.91 released.
  97
  98 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
  99
 100         * version.in: Set GDB version number to 8.2.91.
 101
 102 2019-03-20  Tom Tromey  <tromey@adacore.com>
 103
 104         PR gdb/24391
 105         * infrun.c (handle_inferior_event): Rename from
 106         handle_inferior_event_1.  Create a scoped_value_mark.
 107         (handle_inferior_event): Remove.
 108
 109 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
 110
 111         * source-cache.c (source_cache::get_source_lines): Re-read
 112         fullname after calling open_source_file.
 113
 114 2019-03-18  Pedro Alves  <palves@redhat.com>
 115             Eli Zaretskii <eliz@gnu.org>
 116
 117         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
 118         m_line and m_start_of_line.
 119
 120 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
 121
 122         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
 123         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
 124         it returns a newline.  This fixes a regression in TU mode, whereby
 125         the next line is output on the same screen line as the user input.
 126
 127 2019-03-18  Pedro Alves  <palves@redhat.com>
 128
 129         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
 130         New globals.
 131         (apply_style): New, factored out from ...
 132         (apply_ansi_escape): ... this.  Handle reverse video mode.
 133         (tui_set_reverse_mode): New function.
 134         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
 135         * tui/tui-winsource.c (tui_show_source_line): Use
 136         tui_set_reverse_mode instead of setting A_STANDOUT.
 137         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
 138         New setter methods.
 139
 140 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
 141
 142         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
 143         Handle tabs.
 144
 145 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
 146
 147         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
 148         tui_refill_source_window instead of tui_refresh_win, to update the
 149         current execution line.  This fixes redisplay of the current line
 150         when stepping through the code with "next" or "step".
 151
 152 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 153
 154         * source-cache.c (source_cache::get_source_lines): Call
 155         find_source_lines to initialize s->nlines.  This fixes vertical
 156         scrolling of TUI source window when the DOWN arrow is pressed.
 157
 158 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 159
 160         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
 161         wclrtoeol in tui_show_source_line".  This reverts changes made in
 162         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
 163
 164 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 165
 166         * NEWS: Combine separate "New targets" sections for 8.3.
 167
 168 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
 169
 170         The MS-Windows port of ncurses fails to switch to a color pair if
 171         one or both of the colors are the implicit default colors.  This
 172         change records the default colors when TUI is initialized, and
 173         then specifies them explicitly when a color pair uses the default
 174         colors.  This allows color styling in TUI mode on MS-Windows.
 175
 176         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
 177         ncurses_norm_attr.
 178         (tui_initialize_io) [__MINGW32__]: Record the default terminal
 179         colors in ncurses_norm_attr.
 180         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
 181         "none", replace it with the default color recorded in
 182         ncurses_norm_attr.
 183
 184 2019-03-14  Tom Tromey  <tromey@adacore.com>
 185
 186         * source-cache.h (class source_cache) <get_source_lines>: Return
 187         std::string.
 188         * source-cache.c (source_cache::extract_lines): Handle case where
 189         first_pos==npos.  Return std::string.
 190         (source_cache::get_source_lines): Update.
 191
 192 2019-03-14  Tom Tromey  <tromey@adacore.com>
 193
 194         * NEWS: Add item for "style sources" commands.
 195         * source-cache.c (source_cache::get_source_lines): Check
 196         source_styling.
 197         * cli/cli-style.c (source_styling): New global.
 198         (_initialize_cli_style): Add "style sources" commands.
 199         (show_style_sources): New function.
 200         * cli/cli-style.h (source_styling): Declare.
 201
 202 2019-03-14  Pedro Alves  <palves@redhat.com>
 203             Tom Tromey  <tromey@adacore.com>
 204
 205         * tui/tui-winsource.h (tui_refill_source_window): Declare.
 206         * tui/tui-winsource.c (tui_refill_source_window): New function,
 207         from...
 208         (tui_horizontal_source_scroll): ... here.  Move some logic.
 209         * cli/cli-style.c (set_style_enabled): Notify new observable.
 210         * tui/tui-hooks.c (tui_redisplay_source): New function.
 211         (tui_attach_detach_observers): Attach or detach
 212         tui_redisplay_source.
 213         * observable.h (source_styling_changed): New observable.
 214         * observable.c: Define source_styling_changed observable.
 215
 216 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
 217
 218         PR/24325
 219         * source-cache.c: #undef open and close, to avoid unresolved
 220         externals during linking.
 221
 222 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
 223
 224         Support styling on native MS-Windows console
 225
 226         PR/24315
 227         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
 228         on MS-Windows if $TERM is not defined.
 229
 230         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
 231
 232         * posix-hdep.c (gdb_console_fputs):
 233         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
 234         functions.
 235         * ui-file.h (gdb_console_fputs): Add prototype.
 236
 237         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
 238         back to fputs only if the former returns zero.
 239
 240 2019-03-07  Brian Vandenberg  <phantall@gmail.com>
 241             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 242
 243         PR gdb/8527
 244         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
 245         set_sigint_trap, clear_sigint_trap.
 246
 247 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
 248
 249         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
 250         for-loop range, to avoid compiler warnings.
 251
 252         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
 253         avoid compiler warnings about unused variables.
 254
 255 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
 256
 257         * NEWS: Mention end of support for native debugging on MS-Windows
 258         before XP.
 259
 260 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
 261
 262         PR gdb/24292
 263         * common/netstuff.c:
 264         * gdbserver/gdbreplay.c
 265         * gdbserver/remote-utils.c:
 266         * ser-tcp.c:
 267         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
 268         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
 269         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
 270         'getaddrinfo' and 'freeaddrinfo' were not available before
 271         Windows XP, and mingw.org's MinGW headers by default define
 272         _WIN32_WINNT to 0x500.
 273
 274 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
 275
 276         * NEWS: Note minimum Python version.
 277
 278 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 279
 280         * version.in: Set GDB version number to 8.2.90.DATE-git.
 281
 282 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 283
 284         GDB 8.2.90 released.
 285
 286 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 287
 288         * version.in: Set GDB version number to 8.2.90.
 289
 290 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 291
 292         * NEWS: Change "Changes since GDB 8.2" into "Changes in GDB 8.3".
 293
 294 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 295
 296         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
 297         * version.in: Bump version to 8.2.90.DATE-git.
 298
 299 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
 300
 301         * aix-thread.c (ptid_cmp): Remove unused variable.
 302         (get_signaled_thread): Likewise.
 303         (store_regs_user_thread): Likewise.
 304         (store_regs_kernel_thread): Likewise.
 305         (fetch_regs_kernel_thread): Remove shadowed variable.
 306
 307 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
 308
 309         * features/riscv/32bit-cpu.xml: Add register numbers.
 310         * features/riscv/32bit-fpu.c: Regenerate.
 311         * features/riscv/32bit-fpu.xml: Add register numbers.
 312         * features/riscv/64bit-cpu.xml: Add register numbers.
 313         * features/riscv/64bit-fpu.c: Regenerate.
 314         * features/riscv/64bit-fpu.xml: Add register numbers.
 315
 316 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
 317
 318         * NEWS: Mention two argument form of gdb.Value constructor.
 319         * python/py-value.c (convert_buffer_and_type_to_value): New
 320         function.
 321         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
 322         Add support for handling an optional second argument.  Call
 323         convert_buffer_and_type_to_value as appropriate.
 324         * python/python-internal.h (Py_buffer_deleter): New struct.
 325         (Py_buffer_up): New typedef.
 326
 327 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
 328
 329         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
 330         instead of releasing ownership.
 331
 332 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
 333
 334         * dwarf2read.c (open_and_init_dwp_file): Call
 335         elf_numsections instead of bfd_count_sections to initialize
 336         dwp_file->num_sections.
 337
 338 2019-02-25  Tom Tromey  <tromey@adacore.com>
 339
 340         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
 341
 342 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 343
 344         * gcore.in: Add '--readnever' option when invoking GDB.
 345
 346 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
 347
 348         * MAINTAINERS: Update my email address.
 349
 350 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
 351
 352         * build-id.c (build_id_to_debug_bfd_1): New function.
 353         (build_id_to_debug_bfd): Look for separate debug file in
 354         sysroot.
 355
 356 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 357
 358         * gdbarch.sh: Update the copyright year range that is placed into
 359         generated files.
 360
 361 2019-02-22  Keith Seitz  <keiths@redhat.com>
 362
 363         PR symtab/23853
 364         * linespec.c (create_sals_line_offset): Search for the default
 365         symtab's filename instead of its fullname.
 366
 367 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 368
 369         * NEWS: Update style defaults.
 370
 371 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 372
 373         * main.c (captured_main_1): Disable styling in batch mode.
 374
 375 2019-02-20  Tom Tromey  <tom@tromey.com>
 376
 377         * symtab.c (symtab_symbol_info): Fix typos.
 378
 379 2019-02-20  Tom Tromey  <tromey@adacore.com>
 380
 381         * findcmd.c (_initialize_mem_search): Use upper case for
 382         metasyntactic variables.
 383
 384 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
 385
 386         * aarch64-tdep.c (aarch64_add_reggroups): New function.
 387         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
 388
 389 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
 390
 391         * top.h (source_file_name): Change to std::string.
 392         * top.c (source_file_name): Likewise.
 393         (command_line_input): Adjust.
 394         * cli/cli-script.c (script_from_file): Adjust.
 395
 396 2019-02-19  Tom Tromey  <tromey@adacore.com>
 397
 398         * ravenscar-thread.c
 399         (ravenscar_thread_target::update_thread_list): Don't call
 400         ada_build_task_list.
 401         * ada-lang.h (ada_build_task_list): Don't declare.
 402         * ada-tasks.c (struct ada_tasks_inferior_data)
 403         <task_list_valid_p>: Now bool.
 404         (read_known_tasks, ada_task_list_changed)
 405         (ada_tasks_invalidate_inferior_data): Update.
 406         (read_known_tasks_array): Return bool.
 407         (read_known_tasks_list): Likewise.
 408         (read_known_tasks): Return void.
 409         (ada_build_task_list): Now static.
 410
 411 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 412
 413         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
 414         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
 415
 416 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 417
 418         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
 419         variant for ada_tasks_pspace_data_handle and
 420         ada_tasks_inferior_data_handle.
 421         (ada_tasks_pspace_data_cleanup): New function.
 422         (ada_tasks_inferior_data_cleanup): New function.
 423
 424 2019-02-17  Tom Tromey  <tom@tromey.com>
 425
 426         * macrotab.h (macro_source_fullname): Return a std::string.
 427         * macrotab.c (macro_include, check_for_redefinition)
 428         (macro_undef, macro_lookup_definition, foreach_macro)
 429         (foreach_macro_in_scope): Update.
 430         (macro_source_fullname): Return a std::string.
 431         * macrocmd.c (show_pp_source_pos): Update.
 432
 433 2019-02-17  Tom Tromey  <tom@tromey.com>
 434
 435         * macrocmd.c (show_pp_source_pos): Style the file names.
 436
 437 2019-02-17  Tom Tromey  <tom@tromey.com>
 438
 439         PR tui/24197:
 440         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
 441
 442 2019-02-17  Tom Tromey  <tom@tromey.com>
 443
 444         * ada-lang.c (user_select_syms): Use filtered printing.
 445         * utils.c (wrap_style): New global.
 446         (desired_style): Remove.
 447         (emit_style_escape): Add stream parameter.
 448         (set_output_style, reset_terminal_style, prompt_for_continue):
 449         Update.
 450         (flush_wrap_buffer): Only flush gdb_stdout.
 451         (wrap_here): Set wrap_style.
 452         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
 453         treat escape sequences as a character.  Change when wrap buffer is
 454         flushed.
 455         (fputs_styled): Do not set the output style when the default is
 456         requested.
 457         * ui-style.h (struct ui_file_style) <is_default>: New method.
 458         * source.c (print_source_lines_base): Emit escape sequences in one
 459         piece.
 460
 461 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 462
 463         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
 464         integers and enumeration types.
 465
 466 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 467
 468         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
 469         instead of lookup_symbol_in_language
 470         (do_exact_match): New function.
 471         (ada_get_symbol_name_matcher): Return do_exact_match when
 472         doing a verbatim match.
 473
 474 2019-02-15  Tom Tromey  <tromey@adacore.com>
 475
 476         * ravenscar-thread.c (ravenscar_thread_target::resume)
 477         (ravenscar_thread_target::wait): Special case wildcard requests.
 478
 479 2019-02-15  Tom Tromey  <tromey@adacore.com>
 480
 481         * ravenscar-thread.c (base_ptid): Remove.
 482         (struct ravenscar_thread_target) <close>: New method.
 483         <m_base_ptid>: New member.
 484         <update_inferior_ptid, active_task, task_is_currently_active,
 485         runtime_initialized>: Declare methods.
 486         <ravenscar_thread_target>: Add constructor.
 487         (ravenscar_thread_target::task_is_currently_active)
 488         (ravenscar_thread_target::update_inferior_ptid)
 489         (ravenscar_runtime_initialized): Rename.  Now methods.
 490         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
 491         (ravenscar_thread_target::update_thread_list): Update.
 492         (ravenscar_thread_target::active_task): Now method.
 493         (ravenscar_thread_target::store_registers)
 494         (ravenscar_thread_target::prepare_to_store)
 495         (ravenscar_thread_target::prepare_to_store)
 496         (ravenscar_thread_target::mourn_inferior): Update.
 497         (ravenscar_inferior_created): Use "new" to create target.
 498         (ravenscar_thread_target::get_ada_task_ptid): Update.
 499         (_initialize_ravenscar): Don't initialize base_ptid.
 500         (ravenscar_ops): Remove global.
 501
 502 2019-02-15  Tom Tromey  <tromey@adacore.com>
 503
 504         * target.h (push_target): Declare new overload.
 505         * target.c (push_target): New overload, taking an rvalue reference.
 506         * remote.c (remote_target::open_1): Use push_target overload.
 507         * corelow.c (core_target_open): Use push_target overload.
 508
 509 2019-02-15  Tom Tromey  <tromey@adacore.com>
 510
 511         * ravenscar-thread.c (is_ravenscar_task)
 512         (ravenscar_task_is_currently_active): Return bool.
 513         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
 514         (_initialize_ravenscar): Remove "(void)".
 515         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
 516         Return bool.
 517
 518 2019-02-15  Tom Tromey  <tromey@adacore.com>
 519
 520         * ravenscar-thread.c (ravenscar_runtime_initializer)
 521         (has_ravenscar_runtime, get_running_thread_id)
 522         (ravenscar_thread_target::resume): Fix indentation.
 523
 524 2019-02-15  Tom Tromey  <tromey@adacore.com>
 525
 526         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
 527         from ravenscar_arch_ops.
 528         (sparc_ravenscar_ops::fetch_registers)
 529         (sparc_ravenscar_ops::store_registers): Now methods.
 530         (sparc_ravenscar_prepare_to_store): Remove.
 531         (sparc_ravenscar_ops): Redefine.
 532         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
 533         methods and destructor.  Remove members.
 534         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
 535         (ravenscar_thread_target::store_registers)
 536         (ravenscar_thread_target::prepare_to_store): Update.
 537         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
 538         Remove.
 539         (struct ppc_ravenscar_powerpc_ops): Derive from
 540         ravenscar_arch_ops.
 541         (ppc_ravenscar_powerpc_ops::fetch_registers)
 542         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
 543         (ppc_ravenscar_powerpc_ops): Redefine.
 544         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
 545         (ppc_ravenscar_e500_ops::fetch_registers)
 546         (ppc_ravenscar_e500_ops::store_registers): Now methods.
 547         (ppc_ravenscar_e500_ops): Redefine.
 548         * aarch64-ravenscar-thread.c
 549         (aarch64_ravenscar_generic_prepare_to_store): Remove.
 550         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
 551         (aarch64_ravenscar_fetch_registers)
 552         (aarch64_ravenscar_store_registers): Now methods.
 553         (aarch64_ravenscar_ops): Redefine.
 554
 555 2019-02-15  Tom Tromey  <tromey@adacore.com>
 556
 557         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
 558         (ravenscar_thread_target::stopped_by_hw_breakpoint)
 559         (ravenscar_thread_target::stopped_by_watchpoint)
 560         (ravenscar_thread_target::stopped_data_address)
 561         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
 562
 563 2019-02-15  Tom Tromey  <tromey@adacore.com>
 564
 565         * ravenscar-thread.c: Fix some typos.
 566
 567 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 568             Tom Tromey  <tromey@adacore.com>
 569
 570         * ada-lang.c (ada_exception_sal): Change addr_string to a
 571         std::string.
 572         (create_ada_exception_catchpoint): Update.
 573
 574 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 575             Tom Tromey  <tromey@adacore.com>
 576
 577         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
 578         (bp_location_ops): Remove.
 579         (base_breakpoint_allocate_location): Update.
 580         (free_bp_location): Update.
 581         * ada-lang.c (class ada_catchpoint_location)
 582         <ada_catchpoint_location>: Remove ops parameter.
 583         (ada_catchpoint_location_dtor): Remove.
 584         (ada_catchpoint_location_ops): Remove.
 585         (allocate_location_exception): Update.
 586         * breakpoint.h (struct bp_location_ops): Remove.
 587         (class bp_location) <bp_location>: Remove bp_location_ops
 588         parameter.
 589         <~bp_location>: Add destructor.
 590         <ops>: Remove.
 591
 592 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 593             Pedro Alves  <palves@redhat.com>
 594
 595         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
 596         'PATH_MAX'.
 597
 598 2019-02-14  David Michael  <fedora.dm0@gmail.com>
 599             Samuel Thibault  <samuel.thibault@gnu.org>
 600             Thomas Schwinge  <thomas@codesourcery.com>
 601
 602         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
 603         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
 604
 605 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 606
 607         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
 608         (check_empty): Use "const char *".
 609
 610         * gnu-nat.c (gnu_nat_target::detach): Instead of
 611         'detach_inferior (pid)' call
 612         'detach_inferior (find_inferior_pid (pid))'.
 613
 614         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
 615         'nat/fork-inferior.o'.
 616         * gnu-nat.c: #include "nat/fork-inferior.h".
 617
 618         * gnu-nat.c (gnu_nat_target::detach): Instead of
 619         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
 620         * gnu-nat.h: #include "inf-child.h".
 621         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
 622         'i386_gnu_nat_target::fetch_registers'.
 623         (gnu_store_registers): Rename/move to
 624         'i386_gnu_nat_target::store_registers'.
 625
 626         * config/i386/nm-i386gnu.h: Don't "#include" any files.
 627         * gnu-nat.h (mach_thread_info): New function.
 628         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
 629
 630         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
 631
 632 2019-02-14  Frederic Konrad  <konrad@adacore.com>
 633
 634         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
 635
 636 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
 637
 638         * windows-nat.c (windows_add_thread): Add new parameter
 639         "main_thread_p" with default value set to false.  Update
 640         function documentation as well as all callers.
 641         (windows_delete_thread): Likewise.
 642         (fake_create_process): Update call to windows_add_thread.
 643         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
 644         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
 645         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
 646         call to windows_delete_thread.
 647
 648 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
 649
 650         * MAINTAINERS: Add Andrew Burgess as global maintainer.
 651
 652 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 653
 654         * symfile.c (find_separate_debug_file): Use canonical path of
 655         sysroot with child_path instead of gdb_sysroot if it is valid.
 656
 657 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 658
 659         * symfile.c (find_separate_debug_file): Use child_path to
 660         determine if an object file is under a sysroot.
 661
 662 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 663
 664         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 665         unittests/child-path-selftests.c.
 666         * common/pathstuff.c (child_path): New function.
 667         * common/pathstuff.h (child_path): New prototype.
 668         * unittests/child-path-selftests.c: New file.
 669
 670 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 671
 672         * symfile.c (find_separate_debug_file): Look for separate debug
 673         files in debug directories under the sysroot.
 674
 675 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 676
 677         * symtab.h (struct minimal_symbol data_p): New const method.
 678         (struct minimal_symbol text_p): Likewise.
 679         * symtab.c (output_source_filename): Use file name style
 680         to print file name.
 681         (print_symbol_info): Likewise.
 682         (print_msymbol_info): Use address style to print addresses.
 683         Use function name style to print executable text symbols.
 684         (expand_symtab_containing_pc): Use data_p.
 685         (find_pc_sect_compunit_symtab): Likewise.
 686
 687 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 688
 689         * breakpoint.c (describe_other_breakpoints): Use address style
 690         to print addresses.
 691         (say_where): Likewise.
 692
 693 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 694
 695         * ada-typeprint.c (print_func_type): Print function name
 696         style to print function name.
 697         * c-typeprint.c (c_print_type_1): Likewise.
 698
 699 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
 700
 701         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
 702         for execve.
 703
 704 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 705
 706         * c-exp.y (direct_abs_decl): Use emplace_back to record the
 707         type_stack.
 708
 709 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
 710
 711         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
 712         TYPE_CODE_REF types.
 713
 714 2019-02-08  Jim Wilson  <jimw@sifive.com>
 715
 716         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
 717         (riscv_linux_fregset): New.
 718         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
 719
 720 2019-02-07  Tom Tromey  <tom@tromey.com>
 721
 722         * thread.c (thread_cancel_execution_command): Update.
 723         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
 724         methods.
 725         (struct thread_fsm_ops): Remove.
 726         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
 727         (thread_fsm_should_stop, thread_fsm_return_value)
 728         (thread_fsm_set_finished, thread_fsm_finished_p)
 729         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
 730         Don't declare.
 731         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
 732         * infrun.c (clear_proceed_status_thread)
 733         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
 734         (print_stop_event): Update.
 735         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
 736         Add constructor.
 737         (step_command_fsm_ops): Remove.
 738         (new_step_command_fsm): Remove.
 739         (step_1): Update.
 740         (step_command_fsm::should_stop): Rename from
 741         step_command_fsm_should_stop.
 742         (step_command_fsm::clean_up): Rename from
 743         step_command_fsm_clean_up.
 744         (step_command_fsm::do_async_reply_reason): Rename from
 745         step_command_fsm_async_reply_reason.
 746         (struct until_next_fsm): Inherit from thread_fsm.  Add
 747         constructor.
 748         (until_next_fsm_ops): Remove.
 749         (new_until_next_fsm): Remove.
 750         (until_next_fsm::should_stop): Rename from
 751         until_next_fsm_should_stop.
 752         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
 753         (until_next_fsm::do_async_reply_reason): Rename from
 754         until_next_fsm_async_reply_reason.
 755         (struct finish_command_fsm): Inherit from thread_fsm.  Add
 756         constructor.  Change type of breakpoint.
 757         (finish_command_fsm_ops): Remove.
 758         (new_finish_command_fsm): Remove.
 759         (finish_command_fsm::should_stop): Rename from
 760         finish_command_fsm_should_stop.
 761         (finish_command_fsm::clean_up): Rename from
 762         finish_command_fsm_clean_up.
 763         (finish_command_fsm::return_value): Rename from
 764         finish_command_fsm_return_value.
 765         (finish_command_fsm::do_async_reply_reason): Rename from
 766         finish_command_fsm_async_reply_reason.
 767         (finish_command): Update.
 768         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
 769         Add constructor.
 770         (call_thread_fsm_ops): Remove.
 771         (call_thread_fsm::call_thread_fsm): Rename from
 772         new_call_thread_fsm.
 773         (call_thread_fsm::should_stop): Rename from
 774         call_thread_fsm_should_stop.
 775         (call_thread_fsm::should_notify_stop): Rename from
 776         call_thread_fsm_should_notify_stop.
 777         (run_inferior_call, call_function_by_hand_dummy): Update.
 778         * cli/cli-interp.c (should_print_stop_to_console): Update.
 779         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
 780         Add constructor.  Change type of location_breakpoint,
 781         caller_breakpoint.
 782         (until_break_fsm_ops): Remove.
 783         (new_until_break_fsm): Remove.
 784         (until_break_fsm::should_stop): Rename from
 785         until_break_fsm_should_stop.
 786         (until_break_fsm::clean_up): Rename from
 787         until_break_fsm_clean_up.
 788         (until_break_fsm::do_async_reply_reason): Rename from
 789         until_break_fsm_async_reply_reason.
 790         (until_break_command): Update.
 791         * thread-fsm.c: Remove.
 792         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
 793
 794 2019-02-07  Tom Tromey  <tom@tromey.com>
 795
 796         * yy-remap.h: Add include guard.
 797         * xtensa-tdep.h: Add include guard.
 798         * xcoffread.h: Rename include guard.
 799         * varobj-iter.h: Add include guard.
 800         * tui/tui.h: Rename include guard.
 801         * tui/tui-winsource.h: Rename include guard.
 802         * tui/tui-wingeneral.h: Rename include guard.
 803         * tui/tui-windata.h: Rename include guard.
 804         * tui/tui-win.h: Rename include guard.
 805         * tui/tui-stack.h: Rename include guard.
 806         * tui/tui-source.h: Rename include guard.
 807         * tui/tui-regs.h: Rename include guard.
 808         * tui/tui-out.h: Rename include guard.
 809         * tui/tui-layout.h: Rename include guard.
 810         * tui/tui-io.h: Rename include guard.
 811         * tui/tui-hooks.h: Rename include guard.
 812         * tui/tui-file.h: Rename include guard.
 813         * tui/tui-disasm.h: Rename include guard.
 814         * tui/tui-data.h: Rename include guard.
 815         * tui/tui-command.h: Rename include guard.
 816         * tic6x-tdep.h: Add include guard.
 817         * target/waitstatus.h: Rename include guard.
 818         * target/wait.h: Rename include guard.
 819         * target/target.h: Rename include guard.
 820         * target/resume.h: Rename include guard.
 821         * target-float.h: Rename include guard.
 822         * stabsread.h: Add include guard.
 823         * rs6000-tdep.h: Add include guard.
 824         * riscv-fbsd-tdep.h: Add include guard.
 825         * regformats/regdef.h: Rename include guard.
 826         * record.h: Rename include guard.
 827         * python/python.h: Rename include guard.
 828         * python/python-internal.h: Rename include guard.
 829         * python/py-stopevent.h: Rename include guard.
 830         * python/py-ref.h: Rename include guard.
 831         * python/py-record.h: Rename include guard.
 832         * python/py-record-full.h: Rename include guard.
 833         * python/py-record-btrace.h: Rename include guard.
 834         * python/py-instruction.h: Rename include guard.
 835         * python/py-events.h: Rename include guard.
 836         * python/py-event.h: Rename include guard.
 837         * procfs.h: Add include guard.
 838         * proc-utils.h: Add include guard.
 839         * p-lang.h: Add include guard.
 840         * or1k-tdep.h: Rename include guard.
 841         * observable.h: Rename include guard.
 842         * nto-tdep.h: Rename include guard.
 843         * nat/x86-linux.h: Rename include guard.
 844         * nat/x86-linux-dregs.h: Rename include guard.
 845         * nat/x86-gcc-cpuid.h: Add include guard.
 846         * nat/x86-dregs.h: Rename include guard.
 847         * nat/x86-cpuid.h: Rename include guard.
 848         * nat/ppc-linux.h: Rename include guard.
 849         * nat/mips-linux-watch.h: Rename include guard.
 850         * nat/linux-waitpid.h: Rename include guard.
 851         * nat/linux-ptrace.h: Rename include guard.
 852         * nat/linux-procfs.h: Rename include guard.
 853         * nat/linux-osdata.h: Rename include guard.
 854         * nat/linux-nat.h: Rename include guard.
 855         * nat/linux-namespaces.h: Rename include guard.
 856         * nat/linux-btrace.h: Rename include guard.
 857         * nat/glibc_thread_db.h: Rename include guard.
 858         * nat/gdb_thread_db.h: Rename include guard.
 859         * nat/gdb_ptrace.h: Rename include guard.
 860         * nat/fork-inferior.h: Rename include guard.
 861         * nat/amd64-linux-siginfo.h: Rename include guard.
 862         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
 863         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
 864         * nat/aarch64-linux.h: Rename include guard.
 865         * nat/aarch64-linux-hw-point.h: Rename include guard.
 866         * mn10300-tdep.h: Add include guard.
 867         * mips-linux-tdep.h: Add include guard.
 868         * mi/mi-parse.h: Rename include guard.
 869         * mi/mi-out.h: Rename include guard.
 870         * mi/mi-main.h: Rename include guard.
 871         * mi/mi-interp.h: Rename include guard.
 872         * mi/mi-getopt.h: Rename include guard.
 873         * mi/mi-console.h: Rename include guard.
 874         * mi/mi-common.h: Rename include guard.
 875         * mi/mi-cmds.h: Rename include guard.
 876         * mi/mi-cmd-break.h: Rename include guard.
 877         * m2-lang.h: Add include guard.
 878         * location.h: Rename include guard.
 879         * linux-record.h: Rename include guard.
 880         * linux-nat.h: Add include guard.
 881         * linux-fork.h: Add include guard.
 882         * i386-darwin-tdep.h: Rename include guard.
 883         * hppa-linux-offsets.h: Add include guard.
 884         * guile/guile.h: Rename include guard.
 885         * guile/guile-internal.h: Rename include guard.
 886         * gnu-nat.h: Rename include guard.
 887         * gdb-stabs.h: Rename include guard.
 888         * frv-tdep.h: Add include guard.
 889         * f-lang.h: Add include guard.
 890         * event-loop.h: Add include guard.
 891         * darwin-nat.h: Rename include guard.
 892         * cp-abi.h: Rename include guard.
 893         * config/sparc/nm-sol2.h: Rename include guard.
 894         * config/nm-nto.h: Rename include guard.
 895         * config/nm-linux.h: Add include guard.
 896         * config/i386/nm-i386gnu.h: Rename include guard.
 897         * config/djgpp/nl_types.h: Rename include guard.
 898         * config/djgpp/langinfo.h: Rename include guard.
 899         * compile/gcc-cp-plugin.h: Add include guard.
 900         * compile/gcc-c-plugin.h: Add include guard.
 901         * compile/compile.h: Rename include guard.
 902         * compile/compile-object-run.h: Rename include guard.
 903         * compile/compile-object-load.h: Rename include guard.
 904         * compile/compile-internal.h: Rename include guard.
 905         * compile/compile-cplus.h: Rename include guard.
 906         * compile/compile-c.h: Rename include guard.
 907         * common/xml-utils.h: Rename include guard.
 908         * common/x86-xstate.h: Rename include guard.
 909         * common/version.h: Rename include guard.
 910         * common/vec.h: Rename include guard.
 911         * common/tdesc.h: Rename include guard.
 912         * common/selftest.h: Rename include guard.
 913         * common/scoped_restore.h: Rename include guard.
 914         * common/scoped_mmap.h: Rename include guard.
 915         * common/scoped_fd.h: Rename include guard.
 916         * common/safe-iterator.h: Rename include guard.
 917         * common/run-time-clock.h: Rename include guard.
 918         * common/refcounted-object.h: Rename include guard.
 919         * common/queue.h: Rename include guard.
 920         * common/ptid.h: Rename include guard.
 921         * common/print-utils.h: Rename include guard.
 922         * common/preprocessor.h: Rename include guard.
 923         * common/pathstuff.h: Rename include guard.
 924         * common/observable.h: Rename include guard.
 925         * common/netstuff.h: Rename include guard.
 926         * common/job-control.h: Rename include guard.
 927         * common/host-defs.h: Rename include guard.
 928         * common/gdb_wait.h: Rename include guard.
 929         * common/gdb_vecs.h: Rename include guard.
 930         * common/gdb_unlinker.h: Rename include guard.
 931         * common/gdb_unique_ptr.h: Rename include guard.
 932         * common/gdb_tilde_expand.h: Rename include guard.
 933         * common/gdb_sys_time.h: Rename include guard.
 934         * common/gdb_string_view.h: Rename include guard.
 935         * common/gdb_splay_tree.h: Rename include guard.
 936         * common/gdb_setjmp.h: Rename include guard.
 937         * common/gdb_ref_ptr.h: Rename include guard.
 938         * common/gdb_optional.h: Rename include guard.
 939         * common/gdb_locale.h: Rename include guard.
 940         * common/gdb_assert.h: Rename include guard.
 941         * common/filtered-iterator.h: Rename include guard.
 942         * common/filestuff.h: Rename include guard.
 943         * common/fileio.h: Rename include guard.
 944         * common/environ.h: Rename include guard.
 945         * common/common-utils.h: Rename include guard.
 946         * common/common-types.h: Rename include guard.
 947         * common/common-regcache.h: Rename include guard.
 948         * common/common-inferior.h: Rename include guard.
 949         * common/common-gdbthread.h: Rename include guard.
 950         * common/common-exceptions.h: Rename include guard.
 951         * common/common-defs.h: Rename include guard.
 952         * common/common-debug.h: Rename include guard.
 953         * common/cleanups.h: Rename include guard.
 954         * common/buffer.h: Rename include guard.
 955         * common/btrace-common.h: Rename include guard.
 956         * common/break-common.h: Rename include guard.
 957         * cli/cli-utils.h: Rename include guard.
 958         * cli/cli-style.h: Rename include guard.
 959         * cli/cli-setshow.h: Rename include guard.
 960         * cli/cli-script.h: Rename include guard.
 961         * cli/cli-interp.h: Rename include guard.
 962         * cli/cli-decode.h: Rename include guard.
 963         * cli/cli-cmds.h: Rename include guard.
 964         * charset-list.h: Add include guard.
 965         * buildsym-legacy.h: Rename include guard.
 966         * bfin-tdep.h: Add include guard.
 967         * ax.h: Rename include guard.
 968         * arm-linux-tdep.h: Add include guard.
 969         * arm-fbsd-tdep.h: Add include guard.
 970         * arch/xtensa.h: Rename include guard.
 971         * arch/tic6x.h: Add include guard.
 972         * arch/i386.h: Add include guard.
 973         * arch/arm.h: Rename include guard.
 974         * arch/arm-linux.h: Rename include guard.
 975         * arch/arm-get-next-pcs.h: Rename include guard.
 976         * arch/amd64.h: Add include guard.
 977         * arch/aarch64-insn.h: Rename include guard.
 978         * arch-utils.h: Rename include guard.
 979         * annotate.h: Add include guard.
 980         * amd64-darwin-tdep.h: Rename include guard.
 981         * aarch64-linux-tdep.h: Add include guard.
 982         * aarch64-fbsd-tdep.h: Add include guard.
 983         * aarch32-linux-nat.h: Add include guard.
 984
 985 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 986
 987         * macrotab.c (macro_define_internal): New function that
 988         factorizes macro_define_object_internal and macro_define_function
 989         code.
 990         (macro_define_object_internal): Use macro_define_internal.
 991         (macro_define_function): Likewise.
 992
 993 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 994
 995         * macrocmd.c (extract_identifier): Return
 996         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
 997         callers.
 998
 999 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
1000
1001         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
1002
1003 2019-02-05  Tom Tromey  <tom@tromey.com>
1004
1005         * target.c (target_stack::unpush): Move assertion earlier.
1006
1007 2019-01-30  Tom Tromey  <tom@tromey.com>
1008
1009         PR python/23615:
1010         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
1011         (gdbpy_parse_and_eval): Likewise.
1012         * python/python-internal.h (gdbpy_allow_threads): New class.
1013
1014 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
1015
1016         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
1017         (aarch64_fbsd_fpregmap): Move earlier.
1018         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
1019         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1020         instead of individual calls to trad_frame_set_reg_addr.
1021         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
1022         earlier.
1023         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
1024         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1025         instead of individual calls to trad_frame_set_reg_addr.
1026
1027 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
1028
1029         * CONTRIBUTE: Replace contribution list with wiki link.
1030
1031 2019-01-25  Tom Tromey  <tom@tromey.com>
1032
1033         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
1034
1035 2019-01-25  Tom Tromey  <tom@tromey.com>
1036
1037         * xtensa-linux-nat.c: Fix common/ includes.
1038         * xml-support.h: Fix common/ includes.
1039         * xml-support.c: Fix common/ includes.
1040         * x86-linux-nat.c: Fix common/ includes.
1041         * windows-nat.c: Fix common/ includes.
1042         * varobj.h: Fix common/ includes.
1043         * varobj.c: Fix common/ includes.
1044         * value.c: Fix common/ includes.
1045         * valops.c: Fix common/ includes.
1046         * utils.c: Fix common/ includes.
1047         * unittests/xml-utils-selftests.c: Fix common/ includes.
1048         * unittests/utils-selftests.c: Fix common/ includes.
1049         * unittests/unpack-selftests.c: Fix common/ includes.
1050         * unittests/tracepoint-selftests.c: Fix common/ includes.
1051         * unittests/style-selftests.c: Fix common/ includes.
1052         * unittests/string_view-selftests.c: Fix common/ includes.
1053         * unittests/scoped_restore-selftests.c: Fix common/ includes.
1054         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
1055         * unittests/scoped_fd-selftests.c: Fix common/ includes.
1056         * unittests/rsp-low-selftests.c: Fix common/ includes.
1057         * unittests/parse-connection-spec-selftests.c: Fix common/
1058         includes.
1059         * unittests/optional-selftests.c: Fix common/ includes.
1060         * unittests/offset-type-selftests.c: Fix common/ includes.
1061         * unittests/observable-selftests.c: Fix common/ includes.
1062         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
1063         * unittests/memrange-selftests.c: Fix common/ includes.
1064         * unittests/memory-map-selftests.c: Fix common/ includes.
1065         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
1066         * unittests/function-view-selftests.c: Fix common/ includes.
1067         * unittests/environ-selftests.c: Fix common/ includes.
1068         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
1069         * unittests/common-utils-selftests.c: Fix common/ includes.
1070         * unittests/cli-utils-selftests.c: Fix common/ includes.
1071         * unittests/array-view-selftests.c: Fix common/ includes.
1072         * ui-file.c: Fix common/ includes.
1073         * tui/tui-io.c: Fix common/ includes.
1074         * tracepoint.h: Fix common/ includes.
1075         * tracepoint.c: Fix common/ includes.
1076         * tracefile-tfile.c: Fix common/ includes.
1077         * top.h: Fix common/ includes.
1078         * top.c: Fix common/ includes.
1079         * thread.c: Fix common/ includes.
1080         * target/waitstatus.h: Fix common/ includes.
1081         * target/waitstatus.c: Fix common/ includes.
1082         * target.h: Fix common/ includes.
1083         * target.c: Fix common/ includes.
1084         * target-memory.c: Fix common/ includes.
1085         * target-descriptions.c: Fix common/ includes.
1086         * symtab.h: Fix common/ includes.
1087         * symfile.c: Fix common/ includes.
1088         * stap-probe.c: Fix common/ includes.
1089         * spu-linux-nat.c: Fix common/ includes.
1090         * sparc-nat.c: Fix common/ includes.
1091         * source.c: Fix common/ includes.
1092         * solib.c: Fix common/ includes.
1093         * solib-target.c: Fix common/ includes.
1094         * ser-unix.c: Fix common/ includes.
1095         * ser-tcp.c: Fix common/ includes.
1096         * ser-pipe.c: Fix common/ includes.
1097         * ser-base.c: Fix common/ includes.
1098         * selftest-arch.c: Fix common/ includes.
1099         * s12z-tdep.c: Fix common/ includes.
1100         * rust-exp.y: Fix common/ includes.
1101         * rs6000-aix-tdep.c: Fix common/ includes.
1102         * riscv-tdep.c: Fix common/ includes.
1103         * remote.c: Fix common/ includes.
1104         * remote-notif.h: Fix common/ includes.
1105         * remote-fileio.h: Fix common/ includes.
1106         * remote-fileio.c: Fix common/ includes.
1107         * regcache.h: Fix common/ includes.
1108         * regcache.c: Fix common/ includes.
1109         * record-btrace.c: Fix common/ includes.
1110         * python/python.c: Fix common/ includes.
1111         * python/py-type.c: Fix common/ includes.
1112         * python/py-inferior.c: Fix common/ includes.
1113         * progspace.h: Fix common/ includes.
1114         * producer.c: Fix common/ includes.
1115         * procfs.c: Fix common/ includes.
1116         * proc-api.c: Fix common/ includes.
1117         * printcmd.c: Fix common/ includes.
1118         * ppc-linux-nat.c: Fix common/ includes.
1119         * parser-defs.h: Fix common/ includes.
1120         * osdata.c: Fix common/ includes.
1121         * obsd-nat.c: Fix common/ includes.
1122         * nat/x86-linux.c: Fix common/ includes.
1123         * nat/x86-linux-dregs.c: Fix common/ includes.
1124         * nat/x86-dregs.h: Fix common/ includes.
1125         * nat/x86-dregs.c: Fix common/ includes.
1126         * nat/ppc-linux.c: Fix common/ includes.
1127         * nat/mips-linux-watch.h: Fix common/ includes.
1128         * nat/mips-linux-watch.c: Fix common/ includes.
1129         * nat/linux-waitpid.c: Fix common/ includes.
1130         * nat/linux-ptrace.h: Fix common/ includes.
1131         * nat/linux-ptrace.c: Fix common/ includes.
1132         * nat/linux-procfs.c: Fix common/ includes.
1133         * nat/linux-personality.c: Fix common/ includes.
1134         * nat/linux-osdata.c: Fix common/ includes.
1135         * nat/linux-namespaces.c: Fix common/ includes.
1136         * nat/linux-btrace.h: Fix common/ includes.
1137         * nat/linux-btrace.c: Fix common/ includes.
1138         * nat/fork-inferior.c: Fix common/ includes.
1139         * nat/amd64-linux-siginfo.c: Fix common/ includes.
1140         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
1141         * nat/aarch64-linux.c: Fix common/ includes.
1142         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
1143         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
1144         * namespace.h: Fix common/ includes.
1145         * mips-linux-tdep.c: Fix common/ includes.
1146         * minsyms.c: Fix common/ includes.
1147         * mi/mi-parse.h: Fix common/ includes.
1148         * mi/mi-main.c: Fix common/ includes.
1149         * mi/mi-cmd-env.c: Fix common/ includes.
1150         * memrange.h: Fix common/ includes.
1151         * memattr.c: Fix common/ includes.
1152         * maint.h: Fix common/ includes.
1153         * maint.c: Fix common/ includes.
1154         * main.c: Fix common/ includes.
1155         * machoread.c: Fix common/ includes.
1156         * location.c: Fix common/ includes.
1157         * linux-thread-db.c: Fix common/ includes.
1158         * linux-nat.c: Fix common/ includes.
1159         * linux-fork.c: Fix common/ includes.
1160         * inline-frame.c: Fix common/ includes.
1161         * infrun.c: Fix common/ includes.
1162         * inflow.c: Fix common/ includes.
1163         * inferior.h: Fix common/ includes.
1164         * inferior.c: Fix common/ includes.
1165         * infcmd.c: Fix common/ includes.
1166         * inf-ptrace.c: Fix common/ includes.
1167         * inf-child.c: Fix common/ includes.
1168         * ia64-linux-nat.c: Fix common/ includes.
1169         * i387-tdep.c: Fix common/ includes.
1170         * i386-tdep.c: Fix common/ includes.
1171         * i386-linux-tdep.c: Fix common/ includes.
1172         * i386-linux-nat.c: Fix common/ includes.
1173         * i386-go32-tdep.c: Fix common/ includes.
1174         * i386-fbsd-tdep.c: Fix common/ includes.
1175         * i386-fbsd-nat.c: Fix common/ includes.
1176         * guile/scm-type.c: Fix common/ includes.
1177         * guile/guile.c: Fix common/ includes.
1178         * go32-nat.c: Fix common/ includes.
1179         * gnu-nat.c: Fix common/ includes.
1180         * gdbthread.h: Fix common/ includes.
1181         * gdbarch-selftests.c: Fix common/ includes.
1182         * gdb_usleep.c: Fix common/ includes.
1183         * gdb_select.h: Fix common/ includes.
1184         * gdb_bfd.c: Fix common/ includes.
1185         * gcore.c: Fix common/ includes.
1186         * fork-child.c: Fix common/ includes.
1187         * findvar.c: Fix common/ includes.
1188         * fbsd-nat.c: Fix common/ includes.
1189         * event-top.c: Fix common/ includes.
1190         * event-loop.c: Fix common/ includes.
1191         * dwarf2read.c: Fix common/ includes.
1192         * dwarf2loc.c: Fix common/ includes.
1193         * dwarf2-frame.c: Fix common/ includes.
1194         * dwarf-index-cache.c: Fix common/ includes.
1195         * dtrace-probe.c: Fix common/ includes.
1196         * disasm-selftests.c: Fix common/ includes.
1197         * defs.h: Fix common/ includes.
1198         * csky-tdep.c: Fix common/ includes.
1199         * cp-valprint.c: Fix common/ includes.
1200         * cp-support.h: Fix common/ includes.
1201         * cp-support.c: Fix common/ includes.
1202         * corelow.c: Fix common/ includes.
1203         * completer.h: Fix common/ includes.
1204         * completer.c: Fix common/ includes.
1205         * compile/compile.c: Fix common/ includes.
1206         * compile/compile-loc2c.c: Fix common/ includes.
1207         * compile/compile-cplus-types.c: Fix common/ includes.
1208         * compile/compile-cplus-symbols.c: Fix common/ includes.
1209         * command.h: Fix common/ includes.
1210         * cli/cli-dump.c: Fix common/ includes.
1211         * cli/cli-cmds.c: Fix common/ includes.
1212         * charset.c: Fix common/ includes.
1213         * build-id.c: Fix common/ includes.
1214         * btrace.h: Fix common/ includes.
1215         * btrace.c: Fix common/ includes.
1216         * breakpoint.h: Fix common/ includes.
1217         * breakpoint.c: Fix common/ includes.
1218         * ax.h:
1219         (enum agent_op): Fix common/ includes.
1220         * ax-general.c (struct aop_map): Fix common/ includes.
1221         * ax-gdb.c: Fix common/ includes.
1222         * auxv.c: Fix common/ includes.
1223         * auto-load.c: Fix common/ includes.
1224         * arm-tdep.c: Fix common/ includes.
1225         * arch/riscv.c: Fix common/ includes.
1226         * arch/ppc-linux-common.c: Fix common/ includes.
1227         * arch/i386.c: Fix common/ includes.
1228         * arch/arm.c: Fix common/ includes.
1229         * arch/arm-linux.c: Fix common/ includes.
1230         * arch/arm-get-next-pcs.c: Fix common/ includes.
1231         * arch/amd64.c: Fix common/ includes.
1232         * arch/aarch64.c: Fix common/ includes.
1233         * arch/aarch64-insn.c: Fix common/ includes.
1234         * arch-utils.c: Fix common/ includes.
1235         * amd64-windows-tdep.c: Fix common/ includes.
1236         * amd64-tdep.c: Fix common/ includes.
1237         * amd64-sol2-tdep.c: Fix common/ includes.
1238         * amd64-obsd-tdep.c: Fix common/ includes.
1239         * amd64-nbsd-tdep.c: Fix common/ includes.
1240         * amd64-linux-tdep.c: Fix common/ includes.
1241         * amd64-linux-nat.c: Fix common/ includes.
1242         * amd64-fbsd-tdep.c: Fix common/ includes.
1243         * amd64-fbsd-nat.c: Fix common/ includes.
1244         * amd64-dicos-tdep.c: Fix common/ includes.
1245         * amd64-darwin-tdep.c: Fix common/ includes.
1246         * agent.c: Fix common/ includes.
1247         * ada-lang.h: Fix common/ includes.
1248         * ada-lang.c: Fix common/ includes.
1249         * aarch64-tdep.c: Fix common/ includes.
1250
1251 2019-01-25  Tom Tromey  <tom@tromey.com>
1252
1253         * common/create-version.sh: Use common/version.h.
1254
1255 2019-01-24  Pedro Alves  <palves@redhat.com>
1256
1257         * infrun.c (signal_stop, signal_print, signal_program)
1258         (signal_catch, signal_pass): Now arrays instead of pointers.
1259         (update_signals_program_target, do_target_resume)
1260         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1261         * linux-nat.c (linux_nat_target::pass_signals)
1262         (linux_nat_target::create_inferior, linux_nat_target::attach):
1263         Adjust.
1264         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1265         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1266         * procfs.c (procfs_target::pass_signals): Adjust.
1267         * record-full.c (record_full_target::resume): Adjust.
1268         * remote.c (remote_target::pass_signals)
1269         (remote_target::program_signals): Adjust.
1270         * target-debug.h (target_debug_print_signals): Now takes a
1271         gdb::array_view as parameter.  Adjust.
1272         * target.h (target_ops) <pass_signals, program_signals>: Replace
1273         pointer and length parameters with gdb::array_view.
1274         (target_pass_signals, target_program_signals): Likewise.
1275         * target-delegates.c: Regenerate.
1276
1277 2019-01-24  Pedro Alves  <palves@redhat.com>
1278
1279         * common/forward-scope-exit.h
1280         (forward_scope_exit::forward_scope_exit): Pass arguments to
1281         m_bind_function directly, instead of creating a std::bind and
1282         copying that.
1283
1284 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1285
1286         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1287         for static members.
1288         (pass_in_v_vfp_candidate): Likewise.
1289
1290 2019-01-23  Tom Tromey  <tom@tromey.com>
1291             Pedro Alves  <palves@redhat.com>
1292
1293         * regcache.c (class regcache_invalidator): Remove.
1294         (regcache::raw_write): Use make_scope_exit.
1295
1296 2019-01-23  Tom Tromey  <tom@tromey.com>
1297
1298         * ui-out.h (class ui_out_emit_type): Update comment.
1299
1300 2019-01-23  Tom Tromey  <tom@tromey.com>
1301
1302         * infrun.c (fetch_inferior_event): Update comment.
1303
1304 2019-01-23  Tom Tromey  <tom@tromey.com>
1305             Pedro Alves  <palves@redhat.com>
1306
1307         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1308         parameter.
1309         (fetch_inferior_event): Use SCOPE_EXIT.
1310
1311
1312 2019-01-23  Tom Tromey  <tom@tromey.com>
1313             Pedro Alves  <palves@redhat.com>
1314
1315         * infrun.c (disable_thread_events): Delete.
1316         (stop_all_threads): Use SCOPE_EXIT.
1317
1318 2019-01-23  Tom Tromey  <tom@tromey.com>
1319             Pedro Alves  <palves@redhat.com>
1320
1321         * symfile.c: Include forward-scope-exit.h.
1322         (clear_symtab_users_cleanup): Replace forward declaration with
1323         a FORWARD_SCOPE_EXIT.
1324         (syms_from_objfile_1): Use the forward_scope_exit and
1325         gdb::optional instead of cleanup_function.
1326         (reread_symbols): Use the forward_scope_exit instead of
1327         cleanup_function.
1328         (clear_symtab_users_cleanup): Remove function.
1329
1330 2019-01-23  Tom Tromey  <tom@tromey.com>
1331             Pedro Alves  <palves@redhat.com>
1332
1333         * linux-nat.c: Include scope-exit.h.
1334         (cleanup_target_stop): Remove.
1335         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1336         SCOPE_EXIT.
1337
1338 2019-01-23  Tom Tromey  <tom@tromey.com>
1339             Pedro Alves  <palves@redhat.com>
1340
1341         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1342         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1343
1344 2019-01-23  Tom Tromey  <tom@tromey.com>
1345             Andrew Burgess  <andrew.burgess@embecosm.com>
1346             Pedro Alves  <palves@redhat.com>
1347
1348         * infrun.c (fetch_inferior_event): Use scope_exit.
1349         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1350         * top.c (execute_command): Use scope_exit.
1351         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1352         * utils.c (do_bpstat_clear_actions_cleanup)
1353         (make_bpstat_clear_actions_cleanup): Remove.
1354
1355 2019-01-23  Tom Tromey  <tom@tromey.com>
1356             Pedro Alves  <palves@redhat.com>
1357
1358         * infrun.c: Include "common/scope-exit.h"
1359         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1360         (wait_for_inferior): Use SCOPE_EXIT.
1361         (fetch_inferior_event): Use scope_exit.
1362
1363 2019-01-23  Tom Tromey  <tom@tromey.com>
1364             Pedro Alves  <palves@redhat.com>
1365
1366         * breakpoint.c (create_breakpoint): Remove cleanup.
1367
1368 2019-01-23  Tom Tromey  <tom@tromey.com>
1369             Andrew Burgess  <andrew.burgess@embecosm.com>
1370             Pedro Alves  <palves@redhat.com>
1371
1372 2019-01-23  Pedro Alves  <palves@redhat.com>
1373
1374         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1375
1376 2019-01-23  Pedro Alves  <palves@redhat.com>
1377             Andrew Burgess  <andrew.burgess@embecosm.com>
1378
1379         * gdbthread.h: Include "common/forward-scope-exit.h".
1380         (scoped_finish_thread_state): Redefine custom class in terms of
1381         forward_scope_exit.
1382
1383 2019-01-23  Pedro Alves  <palves@redhat.com>
1384             Andrew Burgess  <andrew.burgess@embecosm.com>
1385
1386         * common/forward-scope-exit.h: New file.
1387
1388 2019-01-23  Pedro Alves  <palves@redhat.com>
1389             Andrew Burgess  <andrew.burgess@embecosm.com>
1390             Tom Tromey  <tom@tromey.com>
1391
1392         * common/scope-exit.h: New file.
1393
1394 2019-01-23  Pedro Alves  <palves@redhat.com>
1395
1396         * common/preprocessor.h (ESC): Rename to ...
1397         (ESC_PARENS): ... this.
1398         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1399         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1400
1401 2019-01-23  Tom Tromey  <tom@tromey.com>
1402
1403         * language.h (class scoped_switch_to_sym_language_if_auto):
1404         Initialize m_lang in both cases.
1405
1406 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1407
1408         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1409         with XCNEW.
1410
1411 2019-01-22  Tom Tromey  <tom@tromey.com>
1412
1413         * corelow.c: Do not include sys/file.h.
1414
1415 2019-01-22  Tom Tromey  <tom@tromey.com>
1416
1417         * tui/tui-wingeneral.h: Include gdb_curses.h.
1418
1419 2019-01-22  Tom Tromey  <tom@tromey.com>
1420
1421         * source-cache.h (class source_cache) <get_source_lines,
1422         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1423
1424 2019-01-22  Tom Tromey  <tom@tromey.com>
1425
1426         * remote-fileio.h (struct remote_target): Declare.
1427
1428 2019-01-22  Tom Tromey  <tom@tromey.com>
1429
1430         * python/py-arch.c: Do not include py-ref.h.
1431         * python/py-bpevent.c: Do not include py-ref.h.
1432         * python/py-cmd.c: Do not include py-ref.h.
1433         * python/py-continueevent.c: Do not include py-ref.h.
1434         * python/py-event.h: Do not include py-ref.h.
1435         * python/py-evtregistry.c: Do not include py-ref.h.
1436         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1437         * python/py-frame.c: Do not include py-ref.h.
1438         * python/py-framefilter.c: Do not include py-ref.h.
1439         * python/py-function.c: Do not include py-ref.h.
1440         * python/py-infevents.c: Do not include py-ref.h.
1441         * python/py-linetable.c: Do not include py-ref.h.
1442         * python/py-objfile.c: Do not include py-ref.h.
1443         * python/py-param.c: Do not include py-ref.h.
1444         * python/py-prettyprint.c: Do not include py-ref.h.
1445         * python/py-progspace.c: Do not include py-ref.h.
1446         * python/py-symbol.c: Do not include py-ref.h.
1447         * python/py-symtab.c: Do not include py-ref.h.
1448         * python/py-type.c: Do not include py-ref.h.
1449         * python/py-unwind.c: Do not include py-ref.h.
1450         * python/py-utils.c: Do not include py-ref.h.
1451         * python/py-value.c: Do not include py-ref.h.
1452         * python/py-varobj.c: Do not include py-ref.h.
1453         * python/py-xmethods.c: Do not include py-ref.h.
1454         * python/python.c: Do not include py-ref.h.
1455         * varobj.c: Do not include py-ref.h.
1456
1457 2019-01-22  Tom Tromey  <tom@tromey.com>
1458
1459         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1460         keyword for bcache.
1461
1462 2019-01-22  Tom Tromey  <tom@tromey.com>
1463
1464         * compile/compile-cplus-types.c: Remove a comment by #include.
1465
1466 2019-01-22  Tom Tromey  <tom@tromey.com>
1467
1468         * compile/gcc-c-plugin.h: Include compile-internal.h.
1469
1470 2019-01-22  Tom Tromey  <tom@tromey.com>
1471
1472         * stabsread.c (EXTERN): Do not define.
1473         (symnum, next_symbol_text_func, processing_gcc_compilation)
1474         (within_function, global_sym_chain, global_stabs)
1475         (previous_stab_code, this_object_header_files)
1476         (n_this_object_header_files)
1477         (n_allocated_this_object_header_files): Define.
1478         * stabsread.h (EXTERN): Never define.  Use "extern".
1479
1480 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1481
1482         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1483         history_value.
1484
1485 2019-01-21  Tom Tromey  <tom@tromey.com>
1486
1487         * ui-out.c: Fix includes.
1488         * tui/tui-source.c: Fix includes.
1489         * target.c: Fix includes.
1490         * remote.c: Fix includes.
1491         * regcache.c: Fix includes.
1492         * python/py-block.c: Fix includes.
1493         * printcmd.c: Fix includes.
1494         * or1k-tdep.c: Fix includes.
1495         * mi/mi-main.c: Fix includes.
1496         * m32r-tdep.c: Fix includes.
1497         * csky-tdep.c: Fix includes.
1498         * compile/compile-cplus-types.c: Fix includes.
1499         * cli/cli-interp.c: Fix includes.
1500
1501 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1502
1503         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1504         for padding.
1505
1506 2019-01-16  Tom Tromey  <tom@tromey.com>
1507
1508         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1509         earlier.
1510         (struct objfile) <msymbols_range>: Move from top level.
1511         <msymbols>: New method.
1512         (class objfile_msymbols): Remove.
1513         * symtab.c (default_collect_symbol_completion_matches_break_on):
1514         Update.
1515         * symmisc.c (dump_msymbols): Update.
1516         * stabsread.c (scan_file_globals): Update.
1517         * objc-lang.c (info_selectors_command, info_classes_command)
1518         (find_methods): Update.
1519         * minsyms.c (find_solib_trampoline_target): Update.
1520         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1521         * coffread.c (coff_symfile_read): Update.
1522         * ada-lang.c (ada_lookup_simple_minsym)
1523         (ada_collect_symbol_completion_matches): Update.
1524
1525 2019-01-16  Tom Tromey  <tom@tromey.com>
1526
1527         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1528         type.  Remove no-argument constructor.
1529         <iterator::operator++>: Simplify.
1530         <begin>: Update.
1531         <end>: Use minimal_symbol_count.
1532
1533 2019-01-16  Tom Tromey  <tom@tromey.com>
1534
1535         * objfiles.h (struct objfile) <psymtabs>: New method.
1536         (class objfile_psymtabs): Remove.
1537         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1538         typedef.
1539         <range>: New method.
1540         (require_partial_symbols): Change return type.
1541         * psymtab.c (require_partial_symbols)
1542         (psym_expand_symtabs_matching): Update.
1543         * mdebugread.c (parse_partial_symbols): Update.
1544         * dbxread.c (dbx_end_psymtab): Update.
1545
1546 2019-01-15  Tom Tromey  <tom@tromey.com>
1547
1548         * symtab.c (lookup_objfile_from_block)
1549         (lookup_symbol_in_objfile_symtabs)
1550         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1551         (find_line_symtab, info_sources_command)
1552         (default_collect_symbol_completion_matches_break_on)
1553         (make_source_files_completion_list): Update.
1554         * symmisc.c (print_objfile_statistics, dump_objfile)
1555         (maintenance_print_symbols, maintenance_info_symtabs)
1556         (maintenance_check_symtabs, maintenance_info_line_tables):
1557         Update.
1558         * source.c (select_source_symtab)
1559         (forget_cached_source_info_for_objfile): Update.
1560         * objfiles.h (class objfile_compunits): Remove.
1561         (struct objfile) <compunits_range>: New typedef.
1562         (compunits): New method.
1563         * objfiles.c (objfile_relocate1): Update.
1564         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1565         * maint.c (count_symtabs_and_blocks): Update.
1566         * linespec.c (iterate_over_all_matching_symtabs): Update.
1567         * cp-support.c (add_symbol_overload_list_qualified): Update.
1568         * coffread.c (coff_symtab_read): Update.
1569         * ada-lang.c (add_nonlocal_symbols)
1570         (ada_collect_symbol_completion_matches)
1571         (ada_add_global_exceptions): Update.
1572
1573 2019-01-15  Tom Tromey  <tom@tromey.com>
1574
1575         * progspace.h (program_space) <objfiles_safe_range>: New
1576         typedef.
1577         <objfiles_safe>: New method.
1578         * objfiles.h (class all_objfiles_safe): Remove.
1579         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1580         * jit.c (jit_inferior_exit_hook): Update.
1581
1582 2019-01-17  Tom Tromey  <tom@tromey.com>
1583
1584         * progspace.h (program_space) <objfiles_range>: New typedef.
1585         <objfiles>: New method.
1586         <objfiles_head>: Rename from objfiles.
1587         (object_files): Update.
1588         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1589         * guile/scm-pretty-print.c
1590         (ppscm_find_pretty_printer_from_objfiles): Update.
1591         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1592         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1593         Update.
1594         * python/py-progspace.c (pspy_get_objfiles): Update.
1595         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1596         Update.
1597         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1598         (objfpy_lookup_objfile_by_build_id): Update.
1599         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1600         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1601         Update.
1602         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1603         (expand_symtab_containing_pc, lookup_objfile_from_block)
1604         (lookup_static_symbol, basic_lookup_transparent_type)
1605         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1606         (find_line_symtab, info_sources_command)
1607         (default_collect_symbol_completion_matches_break_on)
1608         (make_source_files_completion_list, find_main_name): Update.
1609         * symmisc.c (print_symbol_bcache_statistics)
1610         (print_objfile_statistics, maintenance_print_symbols)
1611         (maintenance_print_msymbols, maintenance_print_objfiles)
1612         (maintenance_info_symtabs, maintenance_check_symtabs)
1613         (maintenance_expand_symtabs, maintenance_info_line_tables):
1614         Update.
1615         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1616         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1617         (map_overlay_command, unmap_overlay_command)
1618         (simple_overlay_update, expand_symtabs_matching)
1619         (map_symbol_filenames): Update.
1620         * symfile-debug.c (set_debug_symfile): Update.
1621         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1622         Update.
1623         * source.c (select_source_symtab, forget_cached_source_info):
1624         Update.
1625         * solib.c (solib_read_symbols): Update.
1626         * solib-spu.c (append_ocl_sos): Update.
1627         * psymtab.c (maintenance_print_psymbols)
1628         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1629         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1630         * printcmd.c (info_symbol_command): Update.
1631         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1632         Update.
1633         * objfiles.h (class all_objfiles): Remove.
1634         * objfiles.c (have_partial_symbols, have_full_symbols)
1635         (have_minimal_symbols, qsort_cmp, update_section_map)
1636         (shared_objfile_contains_address_p)
1637         (default_iterate_over_objfiles_in_search_order): Update.
1638         * objc-lang.c (info_selectors_command, info_classes_command)
1639         (find_methods): Update.
1640         * minsyms.c (find_solib_trampoline_target): Update.
1641         * maint.c (maintenance_info_sections)
1642         (maintenance_translate_address, count_symtabs_and_blocks):
1643         Update.
1644         * main.c (captured_main_1): Update.
1645         * linux-thread-db.c (try_thread_db_load_from_pdir)
1646         (has_libpthread): Update.
1647         * linespec.c (iterate_over_all_matching_symtabs)
1648         (search_minsyms_for_name): Update.
1649         * jit.c (jit_find_objf_with_entry_addr): Update.
1650         * hppa-tdep.c (find_unwind_entry)
1651         (hppa_lookup_stub_minimal_symbol): Update.
1652         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1653         Update.
1654         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1655         (elf_gnu_ifunc_resolve_by_got): Update.
1656         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1657         * dwarf-index-write.c (save_gdb_index_command): Update.
1658         * cp-support.c (add_symbol_overload_list_qualified): Update.
1659         * breakpoint.c (create_overlay_event_breakpoint)
1660         (create_longjmp_master_breakpoint)
1661         (create_std_terminate_master_breakpoint)
1662         (create_exception_master_breakpoint): Update.
1663         * blockframe.c (find_pc_partial_function): Update.
1664         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1665         (ada_collect_symbol_completion_matches)
1666         (ada_add_global_exceptions): Update.
1667
1668 2019-01-17  Tom Tromey  <tom@tromey.com>
1669
1670         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1671         declare VEC.
1672         (solib_target_parse_libraries): Change return type.
1673         (library_list_start_segment, library_list_start_section)
1674         (library_list_end_library, library_list_start_library); Update.
1675         (solib_target_free_library_list): Remove.
1676         (solib_target_parse_libraries): Remove cleanup.  Change return
1677         type.
1678         (solib_target_current_sos): Update.
1679
1680 2019-01-17  Tom Tromey  <tromey@bapiya>
1681
1682         * valprint.c: Replace "the the" with "the".
1683         * symtab.c: Replace "the the" with "the".
1684         * solib.c: Replace "the the" with "the".
1685         * solib-dsbt.c: Replace "the the" with "the".
1686         * linespec.c: Replace "the the" with "the".
1687         * dwarf2loc.h: Replace "the the" with "the".
1688         * amd64-windows-tdep.c: Replace "the the" with "the".
1689         * aarch64-tdep.c: Replace "the the" with "the".
1690
1691 2019-01-16  Keith Seitz  <keiths@redhat.com>
1692
1693         PR gdb/23773
1694         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1695         <builder>: Rename to ..
1696         <m_builder>: ... this and make private.
1697         (dwarf2_cu::get_builder): New method.  Change all users of
1698         `builder' to use this method.
1699         (dwarf2_start_symtab): Move to ...
1700         (dwarf2_cu::start_symtab): ... here.  Update all callers
1701         (setup_type_unit_groups): Move to ...
1702         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1703         callers.
1704         (dwarf2_cu::reset_builder): New method.
1705         (process_full_compunit, process_full_type_unit): Use
1706         dwarf2_cu::reset_builder.
1707         (follow_die_offset): Record the ancestor CU if it is different
1708         from the followed DIE's CU.
1709         (follow_die_sig_1): Likewise.
1710
1711 2019-01-15  Tom Tromey  <tom@tromey.com>
1712
1713         * remote.c (class remote_state) <buf>: Now a char_vector.
1714         <buf_size>: Remove.
1715         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1716         parameter.
1717         (remote_target::getpkt_or_notif_sane_1)
1718         (remote_target::getpkt_sane)
1719         (remote_target::getpkt_or_notif_sane): Likewise.
1720         (class remote_target) <putpkt>: New overload.
1721         (remote_target::read_frame): Change type of "buf_p".  Remove
1722         sizeof_p parameter.
1723         (packet_ok): New overload.
1724         (packet_check_result): New overload.
1725         Update all uses.
1726
1727 2019-01-14  Tom Tromey  <tom@tromey.com>
1728
1729         * remote-notif.c (handle_notification, remote_notif_ack)
1730         (remote_notif_parse): Make "buf" const.
1731         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1732         const.
1733         (remote_notif_parse, remote_notif_ack, handle_notification):
1734         Likewise.
1735         * remote.c (remote_notif_stop_parse): Make "buf" const.
1736         (remote_target::remote_parse_stop_reply): Make "buf" const.
1737         (remote_notif_stop_ack): Make "buf" const.
1738
1739 2019-01-14  Tom Tromey  <tom@tromey.com>
1740
1741         * remote.c (remote_console_output): Make parameter const.
1742
1743 2019-01-14  Tom Tromey  <tom@tromey.com>
1744
1745         * target-debug.h (target_debug_print_signals): Constify.
1746         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1747         * procfs.c (procfs_target::pass_signals): Update.
1748         * linux-nat.c (linux_nat_target::pass_signals): Update.
1749         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1750         * target-delegates.c: Rebuild.
1751         * remote.c (remote_target::program_signals): Update.
1752         (remote_target::pass_signals): Update.
1753         * target.c (target_pass_signals): Constify argument.
1754         (target_program_signals): Likewise.
1755         * target.h (struct target_ops) <pass_signals, program_signals>:
1756         Constify argument.
1757         (target_pass_signals, target_program_signals): Constify argument.
1758
1759 2019-01-14  Tom Tromey  <tom@tromey.com>
1760
1761         PR tui/28819:
1762         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1763
1764 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1765
1766         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1767         field.
1768         * rs6000-tdep.c: Include reggroups.h.
1769         (IS_V_ALIAS_PSEUDOREG): Define.
1770         (rs6000_register_name): Return names for the "vX" aliases.
1771         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1772         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1773         aliases.  Call default_register_reggroup_p for all other
1774         pseudo-registers.
1775         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1776         New functions.
1777         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1778         Handle "vX" aliases.
1779         (v_alias_pseudo_register_collect): New function.
1780         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1781         (rs6000_gdbarch_init): Initialize "vX" aliases as
1782         pseudo-registers.  Restore registration of
1783         rs6000_pseudo_register_reggroup_p with
1784         set_tdesc_pseudo_register_reggroup_p.
1785
1786 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1787
1788         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1789         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1790         set_gdbarch_num_pseudo_regs.
1791
1792 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1793
1794         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1795         Remove arg prefixname, add do_set and do_show.
1796         Add member functions set_list and show_list.
1797         * cli/cli-style.c (class cli_style_option): Update accordingly.
1798         (style_set_list): Move to file scope.
1799         (style_show_list): Likewise.
1800         (set_style): Call help_list.
1801         (show_style): Call cmd_show_list.
1802         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1803         Update to use the new macro.
1804
1805 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1806
1807         * ada-lang.c (_initialize_ada_language): Expand the help text
1808         for the "catch exception" command.
1809
1810 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1811
1812         * symtab.c (matching_obj_sections): Initialize obj,
1813         declare it closer to its usage.
1814
1815 2019-01-10  Tom Tromey  <tom@tromey.com>
1816
1817         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1818         (basic_inf_threads_range): Remove.
1819         (inf_threads_range, inf_non_exited_threads_range)
1820         (safe_inf_threads_range): Use next_adapter.
1821
1822 2019-01-10  Keith Seitz  <keiths@redhat.com>
1823
1824         PR gdb/23712
1825         PR symtab/23010
1826         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1827         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1828
1829 2019-01-10  Keith Seitz  <keiths@redhat.com>
1830
1831         PR gdb/23712
1832         PR symtab/23010
1833         * dictionary.c (pending_to_vector): Remove.
1834         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1835         Remove _1 suffix, replacing functions of the same name.  Update
1836         all callers.
1837         (dict_create_hashed, dict_create_hashed_expandable)
1838         (dict_create_linear, dict_create_linear_expandable, dict_free)
1839         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1840         Make functions static.
1841
1842 2019-01-10  Keith Seitz  <keiths@redhat.com>
1843
1844         PR gdb/23712
1845         PR symtab/23010
1846         * dictionary.h (struct dictionary): Replace declaration with
1847         multidictionary.
1848         (dict_create_hashed, dict_create_hashed_expandable)
1849         (dict_create_linear, dict_create_linear_expandable)
1850         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1851         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1852         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1853         taking multidictionary argument.
1854         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1855         * block.h (struct block) <dict>: Change to multidictionary
1856         and rename `multidict'.
1857         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1858         symmisc.c: Update all dictionary references to multidictionary.
1859
1860 2019-01-10  Keith Seitz  <keiths@redhat.com>
1861
1862         PR gdb/23712
1863         PR symtab/23010
1864         * dictionary.c: Include unordered_map.
1865         (pending_to_vector): New function.
1866         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1867         Rewrite the non-"_1" functions to take vector instead
1868         of linked list.
1869         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1870         "new" _1 versions of the same name.
1871         (multidictionary): Define.
1872         (std::hash<enum language): New definition.
1873         (collate_pending_symbols_by_language, mdict_create_hashed)
1874         (mdict_create_hashed_expandable, mdict_create_linear)
1875         (mdict_create_linear_expandable, mdict_free)
1876         (find_language_dictionary, create_new_language_dictionary)
1877         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1878         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1879         (mdict_size, mdict_empty): New functions.
1880         * dictionary.h (mdict_iterator): Define.
1881
1882 2019-01-10  Pedro Alves  <palves@redhat.com>
1883
1884         * breakpoint.c (read_uploaded_action)
1885         (create_tracepoint_from_upload): Adjust to use
1886         gdb::unique_xmalloc_ptr.
1887         * ctf.c (ctf_write_uploaded_tp):
1888         (SET_ARRAY_FIELD): Use emplace_back.
1889         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1890         * tracefile-tfile.c (tfile_write_uploaded_tp):
1891         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1892         gdb::unique_xmalloc_ptr.
1893         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1894         at_string, cond_string, cmd_strings>: Replace char pointers
1895         with gdb::unique_xmalloc_ptr.
1896
1897 2019-01-10  Pedro Alves  <palves@redhat.com>
1898
1899         * solib-target.c (library_list_start_library): Don't xstrdup name.
1900
1901 2019-01-10  Pedro Alves  <palves@redhat.com>
1902
1903         * mdebugread.c (parse_partial_symbols): Use
1904         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1905
1906 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1907
1908         * linux-fork.c (scoped_switch_fork_info)
1909         <~scoped_switch_fork_info>: Fix incorrect variable name.
1910
1911 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1912
1913         * linux-fork.c (scoped_switch_fork_info)
1914         <scoped_switch_fork_info>: Make explicit.
1915         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1916
1917 2019-01-10  Tom Tromey  <tom@tromey.com>
1918
1919         * objfiles.h (objfile::reset_psymtabs): Update.
1920         * objfiles.c (objfile::objfile): Update.
1921         * psymtab.h (psymtab_storage::obstack): Update.
1922         (psymtab_storage::m_obstack): Use gdb::optional.
1923         (class psymtab_storage): Update comment.  Remove objfile
1924         parameter.
1925         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1926
1927 2019-01-10  Tom Tromey  <tom@tromey.com>
1928
1929         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1930         <free_psymtabs>: Now private.
1931         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1932         (allocate_psymtab): Use new method.
1933
1934 2019-01-10  Tom Tromey  <tom@tromey.com>
1935
1936         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1937         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1938         * mdebugread.c (parse_partial_symbols): Use
1939         allocate_dependencies.
1940         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1941         allocate_dependencies.
1942         (process_psymtab_comp_unit_reader)
1943         (build_type_psymtab_dependencies): Likewise.
1944         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1945
1946 2019-01-10  Tom Tromey  <tom@tromey.com>
1947
1948         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1949         PSYMBOL_SET_LANGUAGE.
1950         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1951
1952 2019-01-10  Tom Tromey  <tom@tromey.com>
1953
1954         * psymtab.h (psymtab_storage::obstack): New method.
1955         <m_obstack>: Rename from obstack; now private.
1956         * psymtab.c (psymtab_storage): Update.
1957         * dwarf2read.c (create_addrmap_from_index)
1958         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1959         Update.
1960
1961 2019-01-10  Tom Tromey  <tom@tromey.com>
1962
1963         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1964         * objfiles.h (objfile::reset_psymtabs): New method.
1965
1966 2019-01-10  Tom Tromey  <tom@tromey.com>
1967
1968         * symmisc.c (print_symbol_bcache_statistics): Update.
1969         (print_objfile_statistics): Update.
1970         * symfile.c (reread_symbols): Update.
1971         * psymtab.h (class psymtab_storage): New.
1972         * psymtab.c (psymtab_storage): New constructor.
1973         (~psymtab_storage): New destructor.
1974         (require_partial_symbols): Update.
1975         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1976         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1977         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1978         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1979         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1980         (start_psymtab_common, end_psymtab_common)
1981         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1982         (allocate_psymtab): Update.
1983         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1984         Update.
1985         (dump_psymtab_addrmap, maintenance_print_psymbols)
1986         (maintenance_check_psymtabs): Update.
1987         (class objfile_psymtabs): Move to objfiles.h.
1988         * psympriv.h (discard_psymtab): Now inline.
1989         (psymtab_discarder::psymtab_discarder): Update.
1990         (psymtab_discarder::~psymtab_discarder): Update.
1991         (ALL_OBJFILE_PSYMTABS): Rewrite.
1992         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1993         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1994         Remove fields.
1995         <partial_symtabs>: New field.
1996         (class objfile_psymtabs): Move from psymtab.h.  Update.
1997         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1998         psymbol_cache.
1999         (objfile::~objfile): Don't destroy psymbol_cache.
2000         * mdebugread.c (parse_partial_symbols): Update.
2001         * dwarf2read.c (create_addrmap_from_index)
2002         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
2003         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
2004         (add_partial_subprogram, dwarf2_ranges_read): Update.
2005         * dwarf-index-write.c (write_address_map)
2006         (write_one_signatured_type, recursively_write_psymbols)
2007         (class debug_names, class debug_names, write_psymtabs_to_index):
2008         Update.
2009
2010 2019-01-10  Tom Tromey  <tom@tromey.com>
2011
2012         * symtab.h (SYMBOL_SET_NAMES): Update.
2013         (symbol_set_names): Update.
2014         (MSYMBOL_SET_NAMES): Update.
2015         * symtab.c (symbol_set_names): Change argument to be an
2016         objfile_per_bfd_storage.
2017         * psymtab.c (add_psymbol_to_bcache): Update.
2018         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
2019
2020 2019-01-10  Tom Tromey  <tom@tromey.com>
2021
2022         * symtab.c (create_demangled_names_hash): Change argument to be an
2023         objfile_per_bfd_storage.
2024         (symbol_set_names): Update.
2025
2026 2019-01-10  Tom Tromey  <tom@tromey.com>
2027
2028         * xcoffread.c (xcoff_initial_scan): Unconditionally call
2029         init_psymbol_list.
2030         * psymtab.c (init_psymbol_list): Do nothing if already called.
2031         * psympriv.h (init_psymbol_list): Add comment.
2032         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
2033         init_psymbol_list.
2034         * dbxread.c (dbx_symfile_read): Unconditionally call
2035         init_psymbol_list.
2036
2037 2019-01-10  Tom Tromey  <tom@tromey.com>
2038
2039         * xcoffread.c (scan_xcoff_symtab): Update.
2040         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
2041         "where".
2042         * mdebugread.c (parse_partial_symbols)
2043         (handle_psymbol_enumerators): Update.
2044         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
2045         * dbxread.c (read_dbx_symtab): Update.
2046         * psympriv.h (psymbol_placement): New enum.
2047         (add_psymbol_to_list): Update.
2048
2049 2019-01-10  Tom Tromey  <tom@tromey.com>
2050
2051         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
2052         static_psymbols parameters.
2053         (scan_xcoff_symtab): Update.
2054         * psymtab.c (start_psymtab_common): Remove global_psymbols and
2055         static_psymbols parameters.
2056         * psympriv.h (start_psymtab_common): Update.
2057         * mdebugread.c (parse_partial_symbols): Update.
2058         * dwarf2read.c (create_partial_symtab): Update.
2059         * dbxread.c (read_dbx_symtab): Update.
2060         (start_psymtab): Remove global_psymbols and static_psymbols
2061         parameters.
2062
2063 2019-01-10  Tom Tromey  <tom@tromey.com>
2064
2065         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
2066         * psymtab.c (allocate_psymtab): Add comment.
2067         * psympriv.h (allocate_psymtab): Add comment.
2068         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
2069         initializations.
2070         * dbxread.c (dbx_end_psymtab): Remove some initializations.
2071
2072 2019-01-10  Tom Tromey  <tom@tromey.com>
2073
2074         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2075         Don't declare.
2076         * mipsread.c: Include mdebugread.h.
2077         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2078         Declare.
2079         * elfread.c: Include mdebugread.h.
2080
2081 2019-01-09  Tom Tromey  <tom@tromey.com>
2082
2083         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
2084         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
2085         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
2086         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
2087         (psym_lookup_symbol, psym_find_last_source_symtab)
2088         (psym_forget_cached_source_info, psym_print_stats)
2089         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
2090         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
2091         (psym_map_matching_symbols, psym_expand_symtabs_matching)
2092         (psym_find_compunit_symtab_by_address)
2093         (maintenance_print_psymbols, maintenance_info_psymtabs)
2094         (maintenance_check_psymtabs): Use ranged for.
2095         * psymtab.h (class objfile_psymtabs): New.
2096         (require_partial_symbols): Return objfile_psymtabs.
2097         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
2098
2099 2019-01-09  Tom Tromey  <tom@tromey.com>
2100
2101         * symfile.c (overlay_invalidate_all, find_pc_overlay)
2102         (find_pc_mapped_section, list_overlays_command)
2103         (map_overlay_command, unmap_overlay_command)
2104         (simple_overlay_update): Use all_objfiles.
2105         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
2106         * printcmd.c (info_symbol_command): Use all_objfiles.
2107         * objfiles.h (ALL_OBJSECTIONS): Remove.
2108         * maint.c (maintenance_translate_address): Use all_objfiles.
2109         * gcore.c (gcore_create_callback): Use all_objfiles.
2110         (objfile_find_memory_regions): Likewise.
2111
2112 2019-01-09  Tom Tromey  <tom@tromey.com>
2113
2114         * symtab.c (find_line_symtab, info_sources_command)
2115         (make_source_files_completion_list): Use objfile_compunits.
2116         * source.c (select_source_symtab): Use objfile_compunits.
2117         * objfiles.h (struct objfile): Update comment.
2118         (ALL_OBJFILES): Remove.
2119         (ALL_FILETABS): Remove.
2120         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
2121         objfile_compunits.
2122
2123 2019-01-09  Tom Tromey  <tom@tromey.com>
2124
2125         * symmisc.c (print_objfile_statistics, dump_objfile)
2126         (maintenance_print_symbols): Use compunit_filetabs.
2127         * source.c (forget_cached_source_info_for_objfile): Use
2128         compunit_filetabs.
2129         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
2130         (ALL_FILETABS): Use compunit_filetabs.
2131         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
2132         * coffread.c (coff_symtab_read): Use compunit_filetabs.
2133
2134 2019-01-09  Tom Tromey  <tom@tromey.com>
2135
2136         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
2137         (compunit_filetabs): New.
2138         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
2139         compunit_filetabs.
2140         (info_sources_command, make_source_files_completion_list): Remove
2141         declaration.
2142         * symmisc.c (print_objfile_statistics, dump_objfile)
2143         (maintenance_print_symbols): Remove declaration.
2144         (maintenance_info_symtabs): Use compunit_filetabs.
2145         (maintenance_info_line_tables): Likewise.
2146         * source.c (select_source_symtab): Change local variable name.
2147         (forget_cached_source_info_for_objfile): Remove declaration.
2148         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
2149         * objfiles.c (objfile_relocate1): Remove declaration.
2150         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2151         declaration.
2152         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
2153         * coffread.c (coff_symtab_read): Remove declaration.
2154         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2155         compunit_filetabs.
2156
2157 2019-01-09  Tom Tromey  <tom@tromey.com>
2158
2159         * symtab.c (lookup_objfile_from_block)
2160         (find_pc_sect_compunit_symtab, search_symbols)
2161         (default_collect_symbol_completion_matches_break_on): Use
2162         objfile_compunits.
2163         * objfiles.h (ALL_COMPUNITS): Remove.
2164         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
2165         * cp-support.c (add_symbol_overload_list_qualified): Use
2166         objfile_compunits.
2167         * ada-lang.c (ada_collect_symbol_completion_matches)
2168         (ada_add_global_exceptions): Use objfile_compunits.
2169
2170 2019-01-09  Tom Tromey  <tom@tromey.com>
2171
2172         * source.c (select_source_symtab)
2173         (forget_cached_source_info_for_objfile): Remove declaration.
2174         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2175         declaration.
2176         * maint.c (count_symtabs_and_blocks): Remove declaration.
2177         * cp-support.c (add_symbol_overload_list_qualified): Remove
2178         declaration.
2179         * coffread.c (coff_symtab_read): Remove declaration.
2180         * symtab.c (lookup_symbol_in_objfile_symtabs)
2181         (basic_lookup_transparent_type_1): Use objfile_compunits.
2182         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
2183         (info_sources_command, search_symbols)
2184         (default_collect_symbol_completion_matches_break_on)
2185         (make_source_files_completion_list): Remove declaration.
2186         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
2187         (ada_collect_symbol_completion_matches)
2188         (ada_add_global_exceptions): Remove declaration.
2189         * linespec.c (iterate_over_all_matching_symtabs): Use
2190         objfile_compunits.
2191         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
2192         (class objfile_compunits): New.
2193         (ALL_COMPUNITS): Use objfile_compunits.
2194         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
2195         (maintenance_check_symtabs, maintenance_info_line_tables): Use
2196         objfile_compunits.
2197         * objfiles.c (objfile_relocate1): Use objfile_compunits.
2198
2199 2019-01-09  Tom Tromey  <tom@tromey.com>
2200
2201         * symtab.c (search_symbols)
2202         (default_collect_symbol_completion_matches_break_on): Use
2203         objfile_msymbols.
2204         * ada-lang.c (ada_lookup_simple_minsym)
2205         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
2206         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
2207         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
2208         objfile_msymbols.
2209         * coffread.c (coff_symfile_read): Use objfile_msymbols.
2210         * symmisc.c (dump_msymbols): Use objfile_msymbols.
2211         * objc-lang.c (find_methods): Use objfile_msymbols.
2212         (info_selectors_command, info_classes_command): Likewise.
2213         * stabsread.c (scan_file_globals): Use objfile_msymbols.
2214         * objfiles.h (class objfile_msymbols): New.
2215         (ALL_OBJFILE_MSYMBOLS): Remove.
2216         (ALL_MSYMBOLS): Remove.
2217
2218 2019-01-09  Tom Tromey  <tom@tromey.com>
2219
2220         * common/next-iterator.h (next_adapter): Add Iterator template
2221         parameter.
2222         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
2223         (class all_objfiles_safe): New.
2224         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
2225         * objfiles.c (put_objfile_before): Update comment.
2226         (add_separate_debug_objfile): Likewise.
2227         (free_all_objfiles): Use all_objfiles_safe.
2228         (objfile_purge_solibs): Likewise.
2229
2230 2019-01-09  Tom Tromey  <tom@tromey.com>
2231
2232         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2233         (expand_symtab_containing_pc, lookup_static_symbol)
2234         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
2235         (find_symbol_at_address, find_line_symtab, find_main_name): Use
2236         all_objfiles.
2237         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
2238         * breakpoint.c (create_overlay_event_breakpoint)
2239         (create_longjmp_master_breakpoint)
2240         (create_std_terminate_master_breakpoint)
2241         (create_exception_master_breakpoint): Use all_objfiles.
2242         * linux-thread-db.c (try_thread_db_load_from_pdir)
2243         (has_libpthread): Use all_objfiles.
2244         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
2245         * linespec.c (iterate_over_all_matching_symtabs)
2246         (search_minsyms_for_name): Use all_objfiles.
2247         * maint.c (maintenance_info_sections): Use all_objfiles.
2248         * main.c (captured_main_1): Use all_objfiles.
2249         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
2250         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
2251         * guile/scm-pretty-print.c
2252         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
2253         * solib-spu.c (append_ocl_sos): Use all_objfiles.
2254         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2255         (maintenance_print_msymbols): Use all_objfiles.
2256         * source.c (select_source_symtab): Use all_objfiles.
2257         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2258         * symfile.c (remove_symbol_file_command)
2259         (expand_symtabs_matching, map_symbol_filenames): Use
2260         all_objfiles.
2261         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2262         all_objfiles.
2263         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2264         * objc-lang.c (find_methods): Use all_objfiles.
2265         * objfiles.c (have_partial_symbols, have_full_symbols)
2266         (have_minimal_symbols, qsort_cmp)
2267         (default_iterate_over_objfiles_in_search_order): Use
2268         all_objfiles.
2269         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2270         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2271         (maintenance_check_psymtabs): Use all_objfiles.
2272         (ALL_PSYMTABS): Remove.
2273         * compile/compile-object-run.c (do_module_cleanup): Use
2274         all_objfiles.
2275         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2276         * cp-support.c (add_symbol_overload_list_qualified): Use
2277         all_objfiles.
2278         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2279         Use all_objfiles.
2280         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2281         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2282         all_objfiles.
2283         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2284         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2285         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2286         Uses all_objfiles.
2287         * solib.c (solib_read_symbols): Use all_objfiles
2288
2289 2019-01-09  Tom Tromey  <tom@tromey.com>
2290
2291         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2292         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2293         all_objfiles.
2294         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2295         * symmisc.c (print_symbol_bcache_statistics)
2296         (print_objfile_statistics, maintenance_print_objfiles)
2297         (maintenance_info_symtabs, maintenance_check_symtabs)
2298         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2299         all_objfiles.
2300         * source.c (forget_cached_source_info): Use all_objfiles.
2301         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2302         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2303         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2304         * objfiles.c (update_section_map): Use all_objfiles.
2305         (shared_objfile_contains_address_p): Likewise.
2306         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2307         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2308
2309 2019-01-09  Tom Tromey  <tom@tromey.com>
2310
2311         * common/next-iterator.h: New file.
2312         * objfiles.h (class all_objfiles): New.
2313         (struct objfile_iterator): New.
2314
2315 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2316
2317         * NEWS: Move the description of the changed "frame", "select-frame",
2318          and "info frame" commands to the Changed commands section.
2319
2320 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2321
2322         * gdbtypes.c (check_stub_method_group): Remove handling of old
2323         mangling schemes.
2324         * linespec.c (find_methods): Likewise.
2325         * stabsread.c (read_member_functions): Likewise.
2326         * valops.c (search_struct_method): Likewise.
2327         (value_struct_elt_for_reference): Likewise.
2328         * NEWS: Mention this change.
2329
2330 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2331
2332         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2333         print_source_lines.
2334         * source.c (print_source_lines_base): Update line number check.
2335         (print_source_lines): New function.
2336         (source_lines_range::source_lines_range): New function.
2337         * source.h (class source_lines_range): New class.
2338         (print_source_lines): New declaration.
2339
2340 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2341
2342         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2343
2344 2019-01-08  Tom Tromey  <tom@tromey.com>
2345             Simon Marchi  <simon.marchi@ericsson.com>
2346
2347         PR gdb/24060
2348         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2349         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2350         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2351         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2352         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2353         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2354
2355 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2356
2357         * source.c (select_source_symtab): Move header comment to
2358         declaration in source.h.
2359         (forget_cached_source_info_for_objfile): Likewise.
2360         (forget_cached_source_info): Likewise.
2361         (identify_source_line): Likewise.
2362         * source.h (identify_source_line): Move declaration from symtab.h
2363         and add comment from source.c
2364         (print_source_lines): Likewise.
2365         (forget_cached_source_info_for_objfile): Likewise.
2366         (forget_cached_source_info): Likewise.
2367         (select_source_symtab): Likewise.
2368         (enum print_source_lines_flag): Move definition from symtab.h.
2369         * symtab.h (identify_source_line): Move declaration to source.h.
2370         (print_source_lines): Likewise.
2371         (forget_cached_source_info_for_objfile): Likewise.
2372         (forget_cached_source_info): Likewise.
2373         (select_source_symtab): Likewise.
2374         (enum print_source_lines_flag): Move definition to source.h.
2375         * tui/tui-hooks.c: Add 'source.h' include.
2376
2377 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2378
2379         * source.c (print_source_lines_base): Handle requests to print
2380         reverse line number sequences, and guard against empty lines
2381         string.
2382
2383 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2384
2385         * source.c (print_source_lines_base): Fix skip of '\r' if next
2386         character is '\n'.
2387
2388 2019-01-06  Tom Tromey  <tom@tromey.com>
2389
2390         * c-exp.y (struct c_parse_state) <macro_original_text,
2391         expansion_obstack>: New member.
2392         (macro_original_text, expansion_obstack): Remove globals.
2393         (scan_macro_expansion, scanning_macro_expansion)
2394         (finished_macro_expansion): Update.
2395         (scan_macro_cleanup): Remove.
2396         (yylex, c_parse): Update.
2397
2398 2019-01-06  Tom Tromey  <tom@tromey.com>
2399
2400         * c-exp.y (struct c_parse_state) <strings>: New member.
2401         (operator_stoken): Update.
2402
2403 2019-01-06  Tom Tromey  <tom@tromey.com>
2404
2405         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2406         (union type_stack_elt) <typelist_val>: Now a pointer to
2407         std::vector.
2408         (type_stack_cleanup): Don't declare.
2409         (push_typelist): Update.
2410         * parse.c (pop_typelist): Return a std::vector.
2411         (push_typelist): Take a std::vector.
2412         (follow_types): Update.  Do not free args.
2413         (type_stack_cleanup): Remove.
2414         * c-exp.y (struct c_parse_state): New.
2415         (cpstate): New global.
2416         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2417         (nonempty_typelist): Update.
2418         (func_mod): Create a new vector.
2419         (c_parse): Create a c_parse_state.
2420         (check_parameter_typelist): Do not delete params.
2421         (function_method): Update.  Do not delete type_list.
2422
2423 2019-01-06  Tom Tromey  <tom@tromey.com>
2424
2425         PR gdb/28155:
2426         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2427         check_typedef.
2428         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2429         (print_return_value): Likewise.
2430
2431 2019-01-05  Tom Tromey  <tom@tromey.com>
2432
2433         * contrib/cleanup_check.py: Remove.
2434         * contrib/gcc-with-excheck: Remove.
2435         * contrib/exsummary.py: Remove.
2436         * contrib/excheck.py: Remove.
2437
2438 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2439
2440         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2441         NULL. Initialize tpprev to NULL instead of assigning it
2442         to NULL on the next statement.
2443         * windows-nat.c (windows_delete_thread): Remove check for
2444         main_thread_id before printing thread exit notifications.
2445         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2446         Remove thread ID check against main_thread_id.
2447         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2448         windows_delete_thread.
2449         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2450
2451 2019-01-04  Tom Tromey  <tom@tromey.com>
2452
2453         * compile/compile.c (_initialize_compile): Use upper case for
2454         metasyntactic variables.
2455         * symmisc.c (_initialize_symmisc): Use upper case for
2456         metasyntactic variables.
2457         * psymtab.c (_initialize_psymtab): Use upper case for
2458         metasyntactic variables.
2459         * demangle.c (demangle_command): Use upper case for metasyntactic
2460         variables.
2461         (_initialize_demangler): Likewise.
2462         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2463         variables.
2464
2465 2019-01-03  Tom Tromey  <tom@tromey.com>
2466
2467         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2468
2469 2019-01-03  Tom Tromey  <tom@tromey.com>
2470
2471         * python/py-symtab.c (salpy_str): Update.
2472         (struct salpy_sal_object) <symtab>: Now a PyObject.
2473         (salpy_dealloc): Update.
2474         (del_objfile_sal): Use gdbpy_ref.
2475
2476 2019-01-03  Tom Tromey  <tom@tromey.com>
2477
2478         * python/py-type.c (convert_field): Use new_reference.  Return
2479         gdbpy_ref.
2480         (make_fielditem): Return gdbpy_ref.
2481         (typy_fields): Update.
2482         (typy_getitem): Update.
2483         (field_name): Return gdbpy_ref.  Use new_reference.
2484         (typy_iterator_iternext): Update.
2485
2486 2019-01-03  Tom Tromey  <tom@tromey.com>
2487
2488         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2489
2490 2019-01-03  Tom Tromey  <tom@tromey.com>
2491
2492         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2493         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2494         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2495         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2496         (pspy_set_type_printers): Likewise.
2497         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2498         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2499         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2500         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2501         (objfpy_set_type_printers): Likewise.
2502
2503 2019-01-03  Tom Tromey  <tom@tromey.com>
2504
2505         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2506         (gdbpy_print_stack): Use gdbpy_err_fetch.
2507         * python/python-internal.h (class gdbpy_err_fetch): New class.
2508         (class gdbpy_enter) <m_error_type, m_error_value,
2509         m_error_traceback>: Remove.
2510         <m_error>: New member.
2511         (gdbpy_exception_to_string): Don't declare.
2512         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2513         * python/py-value.c (convert_value_from_python): Use
2514         gdbpy_err_fetch.
2515         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2516         gdbpy_exception_to_string.
2517         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2518         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2519         gdbpy_err_fetch.
2520
2521 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2522
2523         * linux-nat.c (delete_lwp_cleanup): Delete.
2524         (struct lwp_deleter): New struct.
2525         (lwp_info_up): New typedef.
2526         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2527         lwp_info_up.
2528
2529 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2530
2531         * linux-fork.c (class scoped_switch_fork_info): New class.
2532         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2533
2534 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2535
2536         * valops.c (find_overload_match): Remove use of null_cleanup, and
2537         calls to do_cleanups.
2538
2539 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2540
2541         * compile/compile-cplus-types.c
2542         (compile_cplus_instance::decl_name): Handle changes to
2543         cp_func_name.
2544         * cp-support.c (cp_func_name): Update header comment, update
2545         return type.
2546         * cp-support.h (cp_func_name): Update return type in declaration.
2547         * valops.c (find_overload_match): Move temp_func local to top
2548         level of function and change its type.  Use temp_func to hold and
2549         delete temporary string obtained from cp_func_name.
2550
2551 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2552
2553         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2554         gdb::char_vector, remove cleanup, and update uses of `msg`.
2555
2556 2019-01-03  Jim Wilson  <jimw@sifive.com>
2557
2558         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2559
2560 2019-01-02  Tom Tromey  <tom@tromey.com>
2561
2562         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2563         (tdesc_parse_xml): Remove cleanups.
2564         * target-descriptions.h (make_cleanup_free_target_description):
2565         Don't declare.
2566         (target_desc_deleter): New struct.
2567         (target_desc_up): New typedef.
2568         * target-descriptions.c (target_desc_deleter::operator()): Rename
2569         from free_target_description.
2570         (make_cleanup_free_target_description): Remove.
2571
2572 2019-01-02  Tom Tromey  <tom@tromey.com>
2573
2574         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2575         constructor, destructor.
2576         (linespec_parser): Remove typedef.
2577         (~linespec_parser): Rename from linespec_parser_delete.
2578         (linespec_lex_to_end, linespec_complete_label)
2579         (linespec_complete): Update.
2580         (decode_line_full): Remove cleanups.
2581         (decode_line_1): Update.
2582
2583 2019-01-02  Tom Tromey  <tom@tromey.com>
2584
2585         * python/python-internal.h (inferior_to_inferior_object): Change
2586         return type.
2587         * python/py-exitedevent.c (create_exited_event_object): Update.
2588         * python/py-inferior.c (inferior_to_inferior_object): Return
2589         gdbpy_ref.
2590         (python_new_inferior, python_inferior_deleted)
2591         (thread_to_thread_object, delete_thread_object)
2592         (build_inferior_list, gdbpy_selected_inferior): Update.
2593         * python/py-infthread.c (create_thread_object): Update.  Also fail
2594         if inferior_to_inferior_object fails.
2595
2596 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2597
2598         * inferior.h (class inferior) <displaced_step_state>: New field.
2599         * infrun.h (struct displaced_step_state): Move here from
2600         infrun.c.  Initialize fields, add constructor.
2601         <inf>: Remove field.
2602         <reset>: New method.
2603         * infrun.c (struct displaced_step_inferior_state): Move to
2604         infrun.h.
2605         (displaced_step_inferior_states): Remove.
2606         (get_displaced_stepping_state): Adust.
2607         (displaced_step_in_progress_any_inferior): Adjust.
2608         (displaced_step_in_progress_thread): Adjust.
2609         (displaced_step_in_progress): Adjust.
2610         (add_displaced_stepping_state): Remove.
2611         (get_displaced_step_closure_by_addr): Adjust.
2612         (remove_displaced_stepping_state): Remove.
2613         (infrun_inferior_exit): Call displaced_step_state.reset.
2614         (use_displaced_stepping): Don't check for NULL.
2615         (displaced_step_prepare_throw): Call
2616         get_displaced_stepping_state.
2617         (displaced_step_fixup): Don't check for NULL.
2618         (prepare_for_detach): Don't check for NULL.
2619
2620 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2621
2622         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2623          in case of call that did not complete.
2624
2625 2019-01-02  Andrey Utkin  <autkin@undo.io>
2626
2627         * symfile.c (find_separate_debug_file): Fix search of debug files for
2628         remote debuggee.
2629
2630 2019-01-02  Tom Tromey  <tom@tromey.com>
2631
2632         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2633         indentation.
2634         * python/py-frame.c (frapy_older): Remove cast.
2635         (frapy_newer): Likewise.
2636         * python/py-breakpoint.c (local_setattro): Remove cast.
2637         * python/py-arch.c (archpy_name): Remove local variable.
2638         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2639
2640 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2641
2642         * unittests/basic_string_view/element_access/char/empty.cc:
2643         Fix year range in copyright header.
2644
2645 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2646
2647         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2648         Delete.
2649         <operator==>: Update with for removed field.
2650         <hash>: Likewise.
2651         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2652         <isa_features>: ...this.
2653         <abi_features>: New field.
2654         (riscv_isa_flen): Update comment.
2655         (riscv_abi_xlen): New declaration.
2656         (riscv_abi_flen): New declaration.
2657         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2658         isa_features.
2659         (riscv_abi_xlen): New function.
2660         (riscv_isa_flen): Update to get answer from isa_features.
2661         (riscv_abi_flen): New function.
2662         (riscv_has_fp_abi): Update to get answer from abi_features.
2663         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2664         xlen and flen.
2665         (riscv_call_info) <xlen, flen>: Update comment.
2666         (riscv_call_arg_struct): Remove invalid assertions
2667         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2668         is removed.
2669         (riscv_gdbarch_init): Gather isa features and abi features
2670         separately, ensure both match on the gdbarch when reusing an old
2671         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2672         a target with 64-bit float hardware.
2673
2674 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2675
2676         * source.c (search_command_helper): Stop reverse search
2677         when line 1 has been searched.
2678
2679 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2680
2681         * record-full.c (record_full_base_target::close): Rewrite
2682         record_full_core_buf_list free logic.
2683
2684 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2685
2686         * break-catch-syscall.c (print_one_catch_syscall): xfree
2687         the last text.
2688
2689 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2690
2691         * top.c (print_gdb_version): Update Copyright year in version
2692         message.
2693
2694 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2695
2696         Update copyright year range in all GDB files.
2697
2698 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2699
2700         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2701
2702 For older changes see ChangeLog-2018.
2703 \f
2704 Local Variables:
2705 mode: change-log
2706 left-margin: 8
2707 fill-column: 74
2708 version-control: never
2709 coding: utf-8
2710 End:
2711