Allow display of negative offsets in print_address_symbolic()
[external/binutils.git] / gdb / ChangeLog
1 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
2
3         * printcmd.c (print_address_symbolic): Print negative offsets.
4         (build_address_symbolic): Force signed arithmetic when computing
5         offset.
6
7 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
8
9         PR/24474: Add a function to lookup static variables.
10         * NEWS: Mention this new function.
11         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
12         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
13         * python/python.c (python_GdbMethods): Add new function.
14
15 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
16
17         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
18         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
19         (objfpy_lookup_static_symbol): New function.
20         (objfile_object_methods): Add new functions.
21
22 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
23
24         * NEWS: Mention 'set|show print frame-info'.  Mention new
25         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
26         backtrace argument.  Mention that python frame filtering code
27         is now consistent with what 'backtrace' command prints.
28
29 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
30
31         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
32         comments.
33         (print_frame_info_auto, print_frame_info_source_line,
34         print_frame_info_location, print_frame_info_source_and_location,
35         print_frame_info_location_and_address, print_frame_info_short_location):
36         New declarations.
37         (struct frame_print_options): New member print_frame_info.
38         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
39         * stack.h (get_user_print_what_frame_info): New declaration.
40         (frame_show_address): New declaration.
41         * stack.c (print_frame_arguments_choices): New value 'presence'.
42         (print_frame_info_auto, print_frame_info_source_line,
43         print_frame_info_location, print_frame_info_source_and_location,
44         print_frame_info_location_and_address, print_frame_info_short_location,
45         print_frame_info_choices, print_frame_info_print_what): New definitions.
46         (print_frame_args): Only print dots for args if print frame-arguments
47         is 'presence'.
48         (frame_print_option_defs): New element for "frame-info".
49         (get_user_print_what_frame_info): New function.
50         (frame_show_address): Make non static.  Move comment to stack.h.
51         (print_frame_info_to_print_what): New function.
52         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
53         to decide what to print.
54         (backtrace_command_1): Handle the new print_frame_arguments_presence
55         value.
56         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
57         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
58         (py_print_frame): In non-mi mode, use LOCATION as default for
59         print_what, similarly to frame information printed directly by
60         backtrace command. Handle frame-info user option in non MI mode.
61
62 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
63
64         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
65         Add case for debugging 32-bit target on 64-bit host.  Revise
66         comment.
67
68 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
69
70         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
71         instead of find_function_entry_range_from_pc.
72
73 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
74
75         * stack.c (find_frame_funname): Remove code which preferred
76         minsym over symtab sym in "certain pathological cases".
77
78         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
79         parameter.  Change type of "do_demangle" to bool.
80         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
81         Pass suitable "prefer_sym_over_minsym" flag to
82         build_address_symbolic().  Don't output "+" for negative offsets.
83         * printcmd.c (print_address_symbolic): Update invocation of
84         build_address_symbolic to include a "prefer_sym_over_minsym"
85         flag.
86         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
87         Restrict cases in which use of minimal symbol is preferred to that
88         of a found symbol.  Update comments.
89
90         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
91         for entry pc when entry pc is out of range for that FDE.
92
93 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
94
95         PR gdb/24839:
96         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
97         type.
98
99 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
100
101         * python/py-objfile.c (add_separate_debug_file): Fix comment about
102         this function's Python signature.
103
104
105 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
106
107         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
108         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
109         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
110         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
111         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
112
113
114 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
115
116         * h8300-tdep.c (h8300_register_name_common): New.
117         h8300_register_name): Use h8300_register_name_common.
118         (h8300s_register_name): Likewise.
119         (h8300sx_register_name): Likewise.
120         (h8300h_register_nam): New.
121         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
122
123
124 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
125
126         * arm-tdep.c (arm_skip_cmse_entry): New function.
127         (arm_is_sgstubs_section): New function.
128         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
129
130 2019-07-22  Tom Tromey  <tom@tromey.com>
131
132         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
133         Don't self-assign.
134
135 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
136
137         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
138         type_print.
139
140 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
141
142         * symtab.c (search_symbols): Adjust msymbol matching type arrays
143         so that GDB doesn't match any msymbols when searching in the
144         TYPES_DOMAIN.
145         (print_symbol_info): Print using typedef_print or type_print based
146         on the type of the symbol.  Add updated FIXME comment moved from...
147         (_initialize_symtab): ... move and update FIXME comment to above.
148
149 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
150
151         * NEWS: Mention adding -q option to "info types".
152         * symtab.c (struct info_types_options): New struct.
153         (info_types_options_defs): New variable.
154         (make_info_types_options_def_group): New function.
155         (info_types_command): Use gdb::option framework to parse options.
156         (info_types_command_completer): New function.
157         (_initialize_symtab): Extend the help text on "info types" and
158         register command completer.
159
160 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
161
162         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
163         (lookup_symbol_in_objfile): Change int to block_enum and add a
164         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
165
166 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
167
168         * MAINTAINERS (Write After Approval): Add self.
169
170 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
171
172         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
173         instruction to the dummy code region.
174
175 2019-07-19  Tom Tromey  <tromey@adacore.com>
176
177         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
178         (ARGSUSED, PARAMS, __func__): Remove rules.
179
180 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
181
182         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
183         * features/arm/arm-with-iwmmxt.c: Remove.
184         * features/arm/arm-with-iwmmxt.xml: Remove.
185         * features/arm/arm-with-m-fpa-layout.c: Remove.
186         * features/arm/arm-with-m-fpa-layout.xml: Remove.
187         * features/arm/arm-with-m-vfp-d16.c: Remove.
188         * features/arm/arm-with-m-vfp-d16.xml: Remove.
189         * features/arm/arm-with-m.c: Remove.
190         * features/arm/arm-with-m.xml: Remove.
191         * features/arm/arm-with-neon.c: Remove.
192         * features/arm/arm-with-neon.xml: Remove.
193         * features/arm/arm-with-vfpv2.c: Remove.
194         * features/arm/arm-with-vfpv2.xml: Remove.
195         * features/arm/arm-with-vfpv3.c: Remove.
196         * features/arm/arm-with-vfpv3.xml: Remove.
197
198 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
199
200         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
201
202 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
203
204         * arch/aarch32.c (aarch32_create_target_description): Create
205         target descriptions using features.
206         * arch/arm.c (arm_create_target_description)
207         (arm_create_mprofile_target_description): Likewise.
208         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
209
210 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
211
212         * Makefile.in: Add new files.
213         * aarch32-tdep.c: New file.
214         * aarch32-tdep.h: New file.
215         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
216         Call aarch32_read_description.
217         * arch/aarch32.c: New file.
218         * arch/aarch32.h: New file.
219         * arch/arm.c (arm_create_target_description)
220         (arm_create_mprofile_target_description): New function.
221         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
222         (arm_create_target_description)
223         (arm_create_mprofile_target_description): New declaration.
224         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
225         read_description functions.
226         * arm-linux-nat.c (arm_linux_nat_target::read_description):
227         Likewise.
228         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
229         * arm-tdep.c (tdesc_arm_list): New variable.
230         (arm_register_g_packet_guesses): Call create description functions.
231         (arm_read_description) (arm_read_mprofile_description): New
232         function.
233         * arm-tdep.h (arm_read_description)
234         (arm_read_mprofile_description): Add declaration.
235         * configure.tgt: Add new files.
236
237 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
238
239         * top.c (new_ui_command): Open specified terminal just once.
240
241 2019-07-18  Tom Tromey  <tromey@adacore.com>
242
243         * symtab.c (main_name): Constify return type.
244         * symfile.c (set_initial_language): Update.
245         * symtab.h (main_name): Constify return type.
246
247 2019-07-17  Tom Tromey  <tom@tromey.com>
248
249         * tui/tui-winsource.c (tui_update_source_window)
250         (tui_update_source_window_as_is)
251         (tui_update_source_windows_with_line): Remove return.
252         * tui/tui-disasm.c (tui_show_disassem)
253         (tui_show_disassem_and_update_source): Remove return.
254         * tui/tui.c (tui_reset): Remove return.
255         * tui/tui-wingeneral.c
256         (tui_check_and_display_highlight_if_needed): Remove return.
257
258 2019-07-17  Tom Tromey  <tom@tromey.com>
259
260         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
261
262 2019-07-17  Tom Tromey  <tom@tromey.com>
263
264         * tui/tui-winsource.h (struct tui_exec_info_window)
265         (struct tui_source_window_base): Move from tui-data.h.
266         * tui/tui-winsource.c: Move many method definitions from
267         elsewhere.  Remove "structuring" comments.
268         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
269         (tui_source_window_base::refresh_window): Move to
270         tui-winsource.c.
271         * tui/tui-win.c (tui_source_window_base::refresh_all)
272         (tui_source_window_base::update_tab_width)
273         (tui_source_window_base::set_new_height)
274         (tui_source_window_base::do_make_visible_with_new_height): Move to
275         tui-winsource.c.
276         * tui/tui-source.h: Update.
277         * tui/tui-source.c (tui_source_window_base::reset): Move to
278         tui-winsource.c.
279         * tui/tui-disasm.h: Update.
280         * tui/tui-data.h (struct tui_exec_info_window): Move to
281         tui-winsource.h.
282         (struct tui_source_window_base): Likewise.
283         * tui/tui-data.c (tui_source_window_base::clear_detail)
284         (tui_source_window_base, ~tui_source_window_base): Move to
285         tui-winsource.c.
286
287 2019-07-17  Tom Tromey  <tom@tromey.com>
288
289         * tui/tui-win.c (tui_resize_all)
290         (tui_source_window_base::update_tab_width)
291         (tui_adjust_win_heights): Update.
292         (tui_win_info::make_invisible_and_set_new_height): Rename from
293         make_invisible_and_set_new_height.
294         * tui/tui-data.h (struct tui_win_info)
295         <make_invisible_and_set_new_height>: New method.
296
297 2019-07-17  Tom Tromey  <tom@tromey.com>
298
299         * tui/tui.c: Update.
300         * tui/tui-source.h (struct tui_source_window): Move from
301         tui-data.h.
302         * tui/tui-layout.c: Update.
303         * tui/tui-disasm.c: Update.
304         * tui/tui-data.h (struct tui_source_window): Move to
305         tui-source.h.
306
307 2019-07-17  Tom Tromey  <tom@tromey.com>
308
309         * tui/tui-disasm.h (struct tui_disasm_window): Move from
310         tui-data.h.
311         * tui/tui-data.h (struct tui_disasm_window): Move to
312         tui-disasm.h.
313
314 2019-07-17  Tom Tromey  <tom@tromey.com>
315
316         * tui/tui-regs.h (struct tui_data_item_window): Move from
317         tui-data.h.
318         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
319         * tui/tui-data.h (struct tui_data_item_window): Move to
320         tui-regs.h.
321         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
322
323 2019-07-17  Tom Tromey  <tom@tromey.com>
324
325         * tui/tui.c: Update.
326         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
327         (tui_cmd_window::max_height): Move to tui-command.c.
328         * tui/tui-layout.c: Update.
329         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
330         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
331         tui-command.c.
332         * tui/tui-command.h (struct tui_cmd_window): Move from
333         tui-data.h.
334         * tui/tui-command.c: Remove "structuring" comments.
335         (tui_cmd_window::clear_detail)
336         (tui_cmd_window::do_make_visible_with_new_height)
337         (tui_cmd_window::max_height): Move from elsewhere.
338
339 2019-07-17  Tom Tromey  <tom@tromey.com>
340
341         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
342         Now static.
343         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
344         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
345
346 2019-07-17  Tom Tromey  <tom@tromey.com>
347
348         * tui/tui.c: Update.
349         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
350         tui-regs.c.
351         * tui/tui-windata.h: Remove file.
352         * tui/tui-windata.c: Remove file.
353         * tui/tui-win.c (tui_data_window::set_new_height)
354         (tui_data_window::do_make_visible_with_new_height): Move to
355         tui-regs.c.
356         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
357         * tui/tui-regs.c: Remove "structuring" comments.
358         (tui_data_window::first_data_item_displayed)
359         (tui_data_window::delete_data_content_windows)
360         (tui_data_window::erase_data_content)
361         (tui_data_window::display_all_data)
362         (tui_data_window::refresh_all)
363         (tui_data_window::do_scroll_vertical)
364         (tui_data_window::clear_detail, tui_data_window::set_new_height)
365         (tui_data_window::do_make_visible_with_new_height)
366         (tui_data_window::refresh_window): Move from elsewhere.
367         (_initialize_tui_regs): Move to end of file.
368         * tui/tui-layout.c: Update.
369         * tui/tui-hooks.c: Update.
370         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
371         * tui/tui-data.c (tui_data_window::clear_detail): Move to
372         tui-regs.c.
373         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
374
375 2019-07-17  Tom Tromey  <tom@tromey.com>
376
377         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
378         seen.
379
380 2019-07-17  Tom Tromey  <tom@tromey.com>
381
382         * tui/tui-win.c (tui_source_window_base::set_new_height)
383         (tui_source_window_base::do_make_visible_with_new_height): Use
384         m_has_locator field directly.
385         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
386         method.
387         (struct tui_source_window_base) <has_locator>: Likewise.
388
389 2019-07-17  Tom Tromey  <tom@tromey.com>
390
391         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
392         Don't declare.
393         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
394         Remove.
395         * tui/tui-win.c (tui_source_window_base::set_new_height)
396         (tui_source_window_base::set_new_height)
397         (make_invisible_and_set_new_height)
398         (tui_source_window_base::do_make_visible_with_new_height)
399         (tui_source_window_base::do_make_visible_with_new_height):
400         Update.
401         * tui/tui-layout.c (show_source_disasm_command, show_data)
402         (show_source_or_disasm_and_command): Update.
403         * tui/tui-layout.c (show_layout): Update.
404
405 2019-07-17  Tom Tromey  <tom@tromey.com>
406
407         * tui/tui-layout.c (make_data_window): Remove.
408         (show_data): Unify creation and re-initialization cases.
409
410 2019-07-17  Tom Tromey  <tom@tromey.com>
411
412         * tui/tui-layout.c (make_source_window, make_disasm_window):
413         Remove.
414         (show_data): Unify creation and re-initialization cases.
415
416 2019-07-17  Tom Tromey  <tom@tromey.com>
417
418         * tui/tui-layout.c (make_command_window): Remove.
419         (show_source_disasm_command, show_source_or_disasm_and_command):
420         Unify creation and re-initialization cases.
421
422 2019-07-17  Tom Tromey  <tom@tromey.com>
423
424         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
425         creation and re-initialization cases.
426
427 2019-07-17  Tom Tromey  <tom@tromey.com>
428
429         * tui/tui-regs.c (tui_get_register): Return void.
430
431 2019-07-17  Tom Tromey  <tom@tromey.com>
432
433         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
434         Simplify.
435
436 2019-07-17  Tom Tromey  <tom@tromey.com>
437
438         * tui/tui-layout.c (show_source_disasm_command): Simplify window
439         resetting.
440
441 2019-07-17  Tom Tromey  <tom@tromey.com>
442
443         * tui/tui.h (tui_set_layout_by_name): Don't declare.
444         * tui/tui-regs.c (tui_reg_layout): New function.
445         (tui_show_registers, tui_reg_command): Use it.
446         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
447         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
448         parameters.
449         (tui_layout_command): Remove.
450
451 2019-07-17  Tom Tromey  <tom@tromey.com>
452
453         * tui/tui-layout.h (tui/tui-layout): Return void.
454         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
455
456 2019-07-17  Tom Tromey  <tom@tromey.com>
457
458         * tui/tui-layout.c (show_source_disasm_command, show_data):
459         Update.
460         (reset_locator): Remove.
461         (show_source_or_disasm_and_command): Update.
462
463 2019-07-17  Tom Tromey  <tom@tromey.com>
464
465         * tui/tui-source.c (tui_source_window_base::reset): Remove
466         win_type parameter.
467         * tui/tui-layout.c (make_command_window, make_source_window)
468         (make_disasm_window, make_data_window)
469         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
470         (reset_locator, show_source_or_disasm_and_command): Update.
471         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
472         win_type parameter.
473         (struct tui_source_window_base) <reset>: Likewise.
474
475 2019-07-17  Tom Tromey  <tom@tromey.com>
476
477         * tui/tui-layout.c (show_source_disasm_command): Use
478         reset_locator.
479         (reset_locator): New function.
480         (init_and_make_win): Remove.
481         (show_source_or_disasm_and_command): Use reset_locator.
482
483 2019-07-17  Tom Tromey  <tom@tromey.com>
484
485         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
486         condition.
487         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
488         Remove condition.
489         * tui/tui-source.c (tui_source_window_base::reset): New method.
490         * tui/tui-layout.c (make_command_window): Don't call
491         init_and_make_win.
492         (make_source_window, make_disasm_window): Don't call
493         make_source_or_disasm_window.
494         (make_data_window): Don't call init_and_make_win.  Change calling
495         convention.
496         (show_source_disasm_command, show_data): Simplify.
497         (make_source_or_disasm_window): Remove.
498         (show_source_or_disasm_and_command): Simplify.
499         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
500         (struct tui_source_window_base) <reset>: Likewise.
501         <execution_info>: Remove initializer.
502         * tui/tui-data.c (tui_source_window_base): Initialize
503         execution_info.
504
505 2019-07-17  Tom Tromey  <tom@tromey.com>
506
507         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
508         variable.
509
510 2019-07-17  Tom Tromey  <tom@tromey.com>
511
512         * tui/tui.c (tui_rl_other_window): Update.
513         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
514         superclass method first.  Always iterate over regs_content.
515         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
516         method.
517         * tui/tui-win.c (tui_set_focus_command): Update.
518
519 2019-07-17  Tom Tromey  <tom@tromey.com>
520
521         * tui/tui-win.c (tui_set_focus_command): Rename from
522         tui_set_focus.  Call tui_enable.
523         (tui_set_focus_command): Remove.
524
525 2019-07-17  Tom Tromey  <tom@tromey.com>
526
527         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
528         refresh_window.
529         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
530         touchwin.
531         (tui_data_window::refresh_window): Call refresh_window on data
532         items.  Always call superclass refresh_window.
533         (tui_win_info::refresh): Remove.
534         (tui_source_window_base::refresh_window): Update.
535         (tui_refresh_all): Update.
536         * tui/tui-layout.c (show_source_disasm_command): Remove call to
537         refresh_window.
538         (show_source_or_disasm_and_command): Likewise.
539         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
540         (struct tui_source_window_base) <refresh>: Likewise.
541
542 2019-07-17  Tom Tromey  <tom@tromey.com>
543
544         * tui/tui-winsource.c (tui_clear_source_content)
545         (tui_show_source_content): Update.
546         * tui/tui-source.c (tui_source_window::showing_source_p): Check
547         whether content is empty.
548         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
549         Remove.
550
551 2019-07-17  Tom Tromey  <tom@tromey.com>
552
553         * tui/tui-winsource.c (tui_erase_source_content): Clear the
554         window's contents.
555         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
556         * tui/tui-source.c (tui_set_source_content_nil): Remove.
557
558 2019-07-17  Tom Tromey  <tom@tromey.com>
559
560         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
561         (struct tui_data_item_window): Update.
562
563 2019-07-17  Tom Tromey  <tom@tromey.com>
564
565         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
566         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
567         defines.
568
569 2019-07-17  Tom Tromey  <tom@tromey.com>
570
571         * tui/tui-winsource.h (tui_erase_source_content)
572         (tui_clear_source_content): Remove "display_prompt" parameter.
573         * tui/tui-winsource.c (tui_update_source_window_as_is)
574         (tui_update_source_windows_with_addr): Update.
575         (tui_clear_source_content): Remove "display_prompt" parameter.
576         (tui_erase_source_content): Likewise.  Simplify.
577         (tui_show_source_content): Update.
578         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
579         * tui/tui-stack.c (tui_show_frame_info): Update.
580         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
581         Remove defines.
582
583 2019-07-17  Tom Tromey  <tom@tromey.com>
584
585         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
586         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
587         parameter.
588         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
589         parameter.
590
591 2019-07-17  Tom Tromey  <tom@tromey.com>
592
593         * tui/tui-winsource.c (tui_clear_source_content)
594         (tui_show_source_content, tui_show_exec_info_content)
595         (tui_clear_exec_info_content): Update.
596         * tui/tui-stack.c (tui_show_locator_content): Update.
597         (tui_show_frame_info): Update.
598         * tui/tui-source.h (tui_source_window): Don't declare.
599         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
600         from tui_source_is_displayed.
601         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
602         Remove field.
603         (struct tui_source_window_base) <content_in_use>: New field.  Now
604         bool.
605         (struct tui_source_window) <showing_source_p>: New method.
606         (TUI_SRC_WIN): Change cast.
607         * tui/tui-data.c (tui_initialize_static_data): Update.
608
609 2019-07-17  Tom Tromey  <tom@tromey.com>
610
611         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
612         location_matches_p.
613         * tui/tui-source.c (tui_source_window::location_matches_p): New
614         method.
615         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
616         method.
617         * tui/tui-data.h (struct tui_source_window_base)
618         <location_matches_p>: New method.
619         (struct tui_source_window, struct tui_disasm_window)
620         <location_matches_p>: Likewise.
621
622 2019-07-17  Tom Tromey  <tom@tromey.com>
623
624         * tui/tui-win.c (tui_set_win_height_command): Rename from
625         tui_set_win_height.
626         (tui_set_win_height_command): Remove.
627
628 2019-07-17  Tom Tromey  <tom@tromey.com>
629
630         * tui/tui-source.c (tui_source_window): New constructor.  Add
631         observer.
632         (~tui_source_window): New destructor.
633         (tui_source_window::style_changed): New method.
634         * tui/tui-hooks.c (tui_redisplay_source): Remove.
635         (tui_attach_detach_observers): Update.
636         * tui/tui-data.h (struct tui_source_window): Make constructor not
637         inline.  Add destructor.
638         (struct tui_source_window) <style_changed>: New method.
639         <m_observable>: New member.
640
641 2019-07-17  Tom Tromey  <tom@tromey.com>
642
643         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
644         * tui/tui-win.c (tui_resize_all): Fix typo.
645
646 2019-07-17  Tom Tromey  <tom@tromey.com>
647
648         * tui/tui-wingeneral.h (tui_refresh_all): Update.
649         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
650         (tui_refresh_all): Remove "list" parameter.  Use foreach.
651         * tui/tui-win.c (window_name_completer): Use foreach.
652         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
653         (update_tab_width): Likewise.
654         * tui/tui-layout.c (show_layout): Update.
655         * tui/tui-data.h (class tui_window_iterator): New.
656         (struct all_tui_windows): New.
657         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
658
659 2019-07-17  Tom Tromey  <tom@tromey.com>
660
661         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
662         parameter.  Don't reference globals.
663         (tui_reg_command): Update.
664
665 2019-07-17  Tom Tromey  <tom@tromey.com>
666
667         * tui/tui-regs.c (tui_show_registers): Simplify.
668
669 2019-07-17  Tom Tromey  <tom@tromey.com>
670
671         * tui/tui-regs.c (tui_show_registers): Update.
672         (tui_show_register_group): Add win_info parameter.
673
674 2019-07-17  Tom Tromey  <tom@tromey.com>
675
676         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
677         Rename from tui_display_reg_element_at_line.
678         (tui_data_window::display_registers_from_line): Update.
679         * tui/tui-data.h (struct tui_data_window)
680         <display_reg_element_at_line>: New method.
681
682 2019-07-17  Tom Tromey  <tom@tromey.com>
683
684         * tui/tui-regs.h (tui_display_registers_from)
685         (tui_display_registers_from_line): Don't declare.
686         * tui/tui-windata.c (tui_data_window::display_all_data)
687         (tui_data_window::refresh_all)
688         (tui_data_window::do_scroll_vertical): Update.
689         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
690         from tui_display_registers_from.
691         (tui_display_reg_element_at_line): Update.
692         (tui_data_window::display_registers_from_line): Rename from
693         tui_display_registers_from_line.
694         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
695         display_registers_from_line>: New methods.
696
697 2019-07-17  Tom Tromey  <tom@tromey.com>
698
699         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
700         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
701         from tui_erase_data_content.
702         (tui_data_window::display_all_data)
703         (tui_data_window::refresh_all)
704         (tui_data_window::do_scroll_vertical): Update.
705         * tui/tui-regs.c (tui_show_registers): Update.
706         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
707         New method.
708
709 2019-07-17  Tom Tromey  <tom@tromey.com>
710
711         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
712         declare.
713         * tui/tui-windata.c
714         (tui_data_window::delete_data_content_windows): Rename from
715         tui_delete_data_content_windows.
716         (tui_data_window::display_all_data)
717         (tui_data_window::do_scroll_vertical): Update.
718         * tui/tui-data.h (struct tui_data_window)
719         <delete_data_content_windows>: New method.
720
721 2019-07-17  Tom Tromey  <tom@tromey.com>
722
723         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
724         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
725
726 2019-07-17  Tom Tromey  <tom@tromey.com>
727
728         * tui/tui-windata.h (tui_display_all_data): Don't declare.
729         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
730         from tui_display_all_data.
731         * tui/tui-win.c
732         (tui_data_window::do_make_visible_with_new_height): Update.
733         * tui/tui-regs.c (tui_show_registers): Update.
734         * tui/tui-layout.c (tui_set_layout): Update.
735         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
736         method.
737
738 2019-07-17  Tom Tromey  <tom@tromey.com>
739
740         * tui/tui-windata.h (tui_display_data_from): Don't declare.
741         * tui/tui-windata.c (tui_display_data_from): Remove.
742         (tui_data_window::refresh_all): Update.
743
744 2019-07-17  Tom Tromey  <tom@tromey.com>
745
746         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
747         * tui/tui-windata.c (tui_display_data_from_line): Remove.
748         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
749         tui_display_registers_from_line.
750         * tui/tui-regs.h (tui_display_registers_from_line): Update.
751         * tui/tui-regs.c (tui_display_registers_from_line): Remove
752         "force_display" parameter.
753
754 2019-07-17  Tom Tromey  <tom@tromey.com>
755
756         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
757         declare.
758         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
759         Rename from tui_first_reg_element_no_inline.
760         (tui_display_reg_element_at_line)
761         (tui_display_registers_from_line): Update.
762         * tui/tui-data.h (struct tui_data_window)
763         <first_reg_element_no_inline>: New method.
764
765 2019-07-17  Tom Tromey  <tom@tromey.com>
766
767         * tui/tui-windata.c (tui_display_data_from)
768         (tui_data_window::do_scroll_vertical): Update.
769         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
770         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
771         Rename from tui_line_from_reg_element_no.
772         (tui_display_registers_from_line): Update.
773         * tui/tui-data.h (struct tui_data_window)
774         <line_from_reg_element_no>: New method.
775
776 2019-07-17  Tom Tromey  <tom@tromey.com>
777
778         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
779         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
780         tui_last_regs_line_no.
781         (tui_display_reg_element_at_line)
782         (tui_display_registers_from_line): Update.
783         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
784         method.
785
786 2019-07-17  Tom Tromey  <tom@tromey.com>
787
788         PR tui/24722:
789         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
790         (tui_update_breakpoint_info): Add "being_deleted" parameter.
791         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
792         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
793         (tui_update_breakpoint_info): Likewise.
794         * tui/tui-hooks.c (tui_event_create_breakpoint)
795         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
796         Update.
797
798 2019-07-17  Tom Tromey  <tom@tromey.com>
799
800         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
801
802 2019-07-17  Tom Tromey  <tom@tromey.com>
803
804         * tui/tui-winsource.c (tui_update_source_window_as_is)
805         (tui_update_source_windows_with_addr): Update.
806         * tui/tui-source.h (tui_set_source_content)
807         (tui_show_symtab_source): Add "win_info" parameter.
808         * tui/tui-source.c (tui_set_source_content): Add "win_info"
809         parameter.
810         (tui_show_symtab_source): Likewise.
811
812 2019-07-17  Tom Tromey  <tom@tromey.com>
813
814         * tui/tui-wingeneral.c
815         (tui_check_and_display_highlight_if_needed): Check can_highlight.
816
817 2019-07-17  Tom Tromey  <tom@tromey.com>
818
819         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
820         (struct tui_cmd_window) <can_scroll>: New method.
821         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
822         method.
823
824 2019-07-17  Tom Tromey  <tromey@adacore.com>
825
826         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
827         do_field_signed>: Rename.  Change type of "value".
828         * ui-out.c (ui_out::field_signed): Rename from field_int.
829         Change type of "value".
830         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
831         type of "value".
832         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
833         do_field_int.  Change type of "value".
834         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
835         do_field_int.  Change type of "value".
836         * tracepoint.c (trace_status_mi, tfind_1)
837         (print_one_static_tracepoint_marker): Update.
838         * thread.c (print_thread_info_1, print_selected_thread_frame):
839         Update.
840         * stack.c (print_frame, print_frame_info): Update.
841         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
842         Update.
843         * source.c (print_source_lines_base): Update.
844         * skip.c (info_skip_command): Update.
845         * record-btrace.c (btrace_ui_out_decode_error)
846         (btrace_call_history_src_line): Update.
847         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
848         Update.
849         * progspace.c (print_program_space): Update.
850         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
851         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
852         do_field_int.  Change type of "value".
853         * mi/mi-out.c (mi_ui_out::do_table_begin)
854         (mi_ui_out::do_table_header): Update.
855         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
856         type of "value".
857         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
858         (mi_cmd_data_list_changed_registers, output_register)
859         (mi_cmd_data_read_memory, mi_load_progress)
860         (mi_cmd_trace_frame_collected): Update.
861         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
862         Update.
863         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
864         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
865         (mi_cmd_var_list_children, varobj_update_one): Update.
866         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
867         (mi_cmd_stack_list_args, list_arg_or_local): Update.
868         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
869         * inferior.c (print_inferior): Update.
870         * gdb_bfd.c (print_one_bfd): Update.
871         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
872         Update.
873         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
874         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
875         do_field_int.  Change type of "value".
876         * cli-out.c (cli_ui_out::do_field_signed): Rename from
877         do_field_int.  Change type of "value".
878         * breakpoint.c (watchpoint_check, print_breakpoint_location)
879         (print_one_breakpoint_location, print_it_catch_fork)
880         (print_one_catch_fork, print_it_catch_vfork)
881         (print_one_catch_vfork, print_it_catch_solib)
882         (print_it_catch_exec, print_it_ranged_breakpoint)
883         (print_mention_watchpoint, print_mention_masked_watchpoint)
884         (bkpt_print_it, update_static_tracepoint): Update.
885         * break-catch-throw.c (print_it_exception_catchpoint): Update.
886         * break-catch-syscall.c (print_it_catch_syscall): Update.
887         * ada-tasks.c (print_ada_task_info): Update.
888         * ada-lang.c (print_it_exception, print_mention_exception):
889         Update.
890
891 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
892
893         PR breakpoints/24541
894         * gdbarch.c: Regenerate.
895         * gdbarch.h: Regenerate.
896         * gdbarch.sh: Adjust return type and parameter types for
897         'stap_adjust_register'.
898         (i386_stap_adjust_register): Adjust signature and return new
899         register name.
900         * stap-probe.c (stap_parse_register_operand): Adjust use of
901         'gdbarch_stap_adjust_register'.
902
903 2019-07-17  Tom Tromey  <tromey@adacore.com>
904
905         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
906         declare VEC.
907         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
908         std::vector.
909         (struct s390_process_info): Add initializers.
910         (s390_add_process): Use new.
911         (s390_linux_nat_target::low_forget_process): Use delete.
912         (s390_linux_nat_target::low_new_fork)
913         (s390_linux_nat_target::stopped_by_watchpoint)
914         (s390_linux_nat_target::low_prepare_to_resume)
915         (s390_linux_nat_target::insert_watchpoint)
916         (s390_linux_nat_target::insert_hw_breakpoint)
917         (s390_linux_nat_target::remove_watchpoint)
918         (s390_linux_nat_target::remove_hw_breakpoint): Update.
919
920 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
921
922         * aarch64-fbsd-nat.c: Include regcache.h.
923         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
924         argument.
925         (aarch64_fbsd_nat_target::fetch_registers)
926         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
927         variable.
928         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
929
930 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
931
932         * fbsd-nat.c: Include gdbarch.h.
933
934 2019-07-15  Tom Tromey  <tromey@adacore.com>
935
936         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
937
938 2019-07-15  Tom Tromey  <tromey@adacore.com>
939
940         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
941         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
942         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
943         * cli-out.c (cli_ui_out::do_field_int): New method.
944         * ui-out.c (ui_out::field_unsigned): New method.
945         * symfile.c (generic_load): Use field_unsigned.
946         (print_transfer_performance): Likewise.
947         * record-btrace.c (ui_out_field_uint): Remove.
948         (btrace_call_history_insn_range, btrace_call_history): Use
949         field_unsigned.
950         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
951         field_unsigned.
952         * ui-out.h (class ui_out) <field_unsigned>: New method.
953         <do_field_unsigned>: Likewise.
954
955 2019-07-15  Tom Tromey  <tromey@adacore.com>
956
957         * mi/mi-main.c (list_available_thread_groups): Use field_string.
958         * mi/mi-interp.c (mi_memory_changed): Use field_string.
959         * target.c (flash_erase_command): Use field_string.
960         * infrun.c (print_signal_received_reason): Use field_string.
961         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
962         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
963         field_string.
964         * ada-tasks.c (print_ada_task_info): Use field_string.
965
966 2019-07-15  Tom Tromey  <tromey@adacore.com>
967
968         * target.c (flash_erase_command): Use field_core_addr.
969         * symfile.c (generic_load): Use field_core_addr.
970         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
971         Use field_core_addr.
972         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
973         field_core_addr.
974
975 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
976
977         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
978         value if its desired type is smaller than a CORE_ADDR and signed.
979
980 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
981
982         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
983         of changes to field names, and use new is_reference field to
984         decide if a property is a reference or not.
985         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
986         field.
987         (struct dwarf2_property_baton): Update header comment, rename
988         'referenced_type' to 'property_type' and update comments.
989         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
990         default property type, store in property baton, update to take
991         accound of renamed field.
992         (read_func_scope): Update call to attr_to_dynamic_prop.
993         (read_array_type): Likewise.
994         (dwarf2_per_cu_addr_sized_int_type): New function.
995         (read_subrange_index_type): Move type finding code to
996         dwarf2_per_cu_addr_sized_int_type.
997         (read_subrange_type): Update calls to attr_to_dynamic_prop.
998         (dwarf2_per_cu_addr_type): New function.
999         (set_die_type): Update calls to attr_to_dynamic_prop.
1000
1001 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1002
1003         * dwarf2read.c (read_subrange_index_type): New function.
1004         (read_subrange_type): Move code into new function and call it.
1005         * gdbtypes.c (create_range_type): Add some asserts.
1006
1007 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1008
1009         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
1010         update return statements.
1011         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
1012         declaration, and update comment to match.
1013         * gdbtypes.c (resolve_dynamic_array): Update call to
1014         dwarf2_evaluate_property to match new return type.
1015
1016 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1017
1018         * valarith.c (value_subscripted_rvalue): Change lowerbound
1019         parameter type from int to LONGEST.
1020         * value.h (value_subscripted_rvalue): Likewise in declaration.
1021
1022 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1023
1024         * cli/cli-utils.c (info_print_command_completer): New function.
1025         * cli/cli-utils.h: Add 'completer.h' include, and forward
1026         declaration for 'struct cmd_list_element'.
1027         (info_print_command_completer): Declare.
1028         * stack.c (_initialize_stack): Add completer for 'info locals' and
1029         'info args'.
1030         * symtab.c (_initialize_symtab): Add completer for 'info
1031         variables' and 'info functions'.
1032         * NEWS: Mention completion for additional info commands.
1033
1034 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1035
1036         * cli/cli-utils.c (extract_info_print_args): Delete.
1037         (extract_arg_maybe_quoted): Delete.
1038         (info_print_options_defs): New variable.
1039         (make_info_print_options_def_group): New function.
1040         (extract_info_print_options): Define new function.
1041         * cli/cli-utils.h (extract_info_print_args): Delete.
1042         (struct info_print_options): New structure.
1043         (extract_info_print_options): Declare new function.
1044         * stack.c (info_locals_command): Update to use new
1045         extract_info_print_options, also add a header comment.
1046         (info_args_command): Likewise.
1047         * symtab.c (info_variables_command): Likewise.
1048         (info_functions_command): Likewise.
1049
1050 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1051
1052         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
1053         to extract string arguments.
1054         * common/common-utils.c (extract_string_maybe_quoted): New function.
1055         * common/common-utils.h (extract_string_maybe_quoted): Declare.
1056
1057 2019-07-11  Tom Tromey  <tromey@adacore.com>
1058
1059         * main.c (get_init_files): Use GDBINIT, not gdbinit.
1060         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
1061         * top.h (gdbinit): Don't declare.
1062         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
1063         into...
1064         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
1065         * top.c (gdb_init): Don't call init_cli_cmds.
1066         (gdbinit): Remove.
1067         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
1068
1069 2019-07-11  Tom Tromey  <tromey@adacore.com>
1070
1071         * python/py-inferior.c (add_thread_object): Don't use thread_obj
1072         after it has been moved.
1073
1074 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1075
1076         * valops.c (value_must_coerce_to_target): Change return type to
1077         bool.
1078         * value.h (value_must_coerce_to_target): Likewise.
1079
1080 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
1081
1082         * breakpoint.c (is_hardware_watchpoint): Remove
1083         forward-declaration.
1084         (is_masked_watchpoint): Change return type to bool.
1085         (is_tracepoint): Likewise.
1086         (is_breakpoint): Likewise.
1087         (is_hardware_watchpoint): Likewise.
1088         (is_watchpoint): Likewise.
1089         (is_no_memory_software_watchpoint): Likewise.
1090         (is_catchpoint): Likewise.
1091         (breakpoint_1): Make FILTER parameter's return type bool.
1092         is_masked_watchpoint): Change return type to bool.
1093         (save_breakpoints): Make FILTER parameter's return type bool.
1094         * breakpoint.h (is_breakpoint): Change return type to bool.
1095         (is_watchpoint): Likewise.
1096         (is_catchpoint): Likewise.
1097         (is_tracepoint): Likewise.
1098
1099 2019-07-10  Tom Tromey  <tom@tromey.com>
1100
1101         * defs.h: Don't include gdbarch.h.
1102         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
1103         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
1104         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
1105         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
1106         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
1107         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
1108         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
1109         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
1110         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
1111         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
1112         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
1113         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
1114         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
1115         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
1116         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
1117         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
1118         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
1119         record-btrace.c, record.h, regcache-dump.c, regcache.h,
1120         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
1121         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
1122         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
1123         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
1124         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
1125         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
1126         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
1127         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
1128         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
1129
1130 2019-07-10  Tom Tromey  <tromey@adacore.com>
1131
1132         * ada-lang.h (is_ada_exception_catchpoint): Declare.
1133         * breakpoint.c (init_ada_exception_breakpoint): Register as
1134         bp_catchpoint.
1135         (print_one_breakpoint_location, print_one_breakpoint): Use
1136         is_ada_exception_catchpoint.
1137         * ada-lang.c (class ada_catchpoint_location): Pass
1138         bp_loc_software_breakpoint to bp_location constructor.
1139         (is_ada_exception_catchpoint): New function.
1140
1141 2019-07-10  Tom Tromey  <tromey@adacore.com>
1142
1143         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
1144         VEC.
1145         (struct arm_exidx_entry): New method operator<.
1146         (struct arm_exidx_data) <section_maps>: Change type.
1147         (arm_exidx_data_free): Remove.
1148         (arm_exidx_data_key): Change type.  Move lower.
1149         (arm_exidx_new_objfile): Update.
1150         (arm_compare_exidx_entries): Remove.
1151         (arm_find_exidx_entry, _initialize_arm_tdep)
1152
1153 2019-07-10  Tom Tromey  <tromey@adacore.com>
1154
1155         * solib-spu.c (ocl_program_data_key): Change type.
1156         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
1157         Update.
1158
1159 2019-07-10  Tom Tromey  <tromey@adacore.com>
1160
1161         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
1162         (struct solib_aix_inferior_data) <library_list>: Change type.
1163         (solib_aix_inferior_data_handle): Change type.
1164         (get_solib_aix_inferior_data): Update.
1165         (solib_aix_free_library_list): Remove.
1166         (library_list_start_library): Update.
1167         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1168         return type.
1169         (solib_aix_get_library_list)
1170         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1171         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1172
1173 2019-07-10  Tom Tromey  <tromey@adacore.com>
1174
1175         * solib-dsbt.c (struct dsbt_info): Add initializers.
1176         (solib_dsbt_pspace_data): Change type.
1177         (dsbt_pspace_data_cleanup): Remove.
1178         (get_dsbt_info, _initialize_dsbt_solib): Update.
1179
1180 2019-07-10  Tom Tromey  <tromey@adacore.com>
1181
1182         * spu-tdep.c (spu_overlay_data): Change type.
1183         (spu_get_overlay_table, spu_overlay_new_objfile)
1184         (_initialize_spu_tdep): Update.
1185
1186 2019-07-10  Tom Tromey  <tromey@adacore.com>
1187
1188         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1189         destructor.
1190         (dbx_objfile_data_key): Change type and declare later.
1191         (DBX_SYMFILE_INFO): Rewrite.
1192         * dbxread.c (dbx_objfile_data_key): Change type.
1193         (dbx_symfile_init): Update.
1194         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
1195         (coffstab_build_psymtabs, elfstab_build_psymtabs)
1196         (stabsect_build_psymtabs, _initialize_dbxread): Update.
1197
1198 2019-07-10  Tom Tromey  <tromey@adacore.com>
1199
1200         * jit.c (jit_program_space_key): Change type.  Move lower.
1201         (get_jit_program_space_data): Update.
1202         (jit_program_space_data_cleanup): Remove.
1203         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1204         Update.
1205         (struct jit_program_space_data): Add initializers.
1206
1207 2019-07-10  Tom Tromey  <tromey@adacore.com>
1208
1209         * solib-darwin.c (struct darwin_info): Add initializers.
1210         (solib_darwin_pspace_data): Change type.
1211         (darwin_pspace_data_cleanup): Remove.
1212         (get_darwin_info, _initialize_darwin_solib): Update.
1213
1214 2019-07-10  Tom Tromey  <tromey@adacore.com>
1215
1216         * remote-sim.c (struct sim_inferior_data): Add initializers,
1217         constructor, and destructor.
1218         (sim_inferior_data_key): Change type.  Move lower.
1219         (check_for_duplicate_sim_descriptor): Update.
1220         (get_sim_inferior_data): Use new.  Update.
1221         (~sim_inferior_data_cleanup): Rename from
1222         sim_inferior_data_cleanup.  Simplify.
1223         (gdbsim_close_inferior, simulator_command)
1224         (sim_command_completer, _initialize_remote_sim): Update.
1225         (next_pid, INITIAL_PID): Move earlier.
1226
1227 2019-07-10  Tom Tromey  <tromey@adacore.com>
1228
1229         * python/python-internal.h (create_thread_object): Return
1230         gdbpy_ref.
1231         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1232         * python/py-inferior.c (struct threadlist_entry): Add
1233         constructor.
1234         <thread_obj>: Now a gdbpy_ref.
1235         (thread_to_thread_object): Update.
1236         (add_thread_object): Use new.
1237         (delete_thread_object): Use delete.
1238         (infpy_threads): Update.
1239         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
1240         GIL.
1241
1242 2019-07-10  Tom Tromey  <tromey@adacore.com>
1243
1244         * valops.c (value_cast): Specialize error message for Ada.
1245
1246 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1247
1248         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1249
1250 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1251
1252         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1253         bpstat_should_step): Return bool, adjust comments.
1254         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1255         bpstat_should_step): Likewise.
1256
1257 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1258
1259         * features/Makefile: Use feature target descriptions for Arm.
1260         * features/arm/arm-core.c: Generate new file.
1261         * features/arm/arm-fpa.c: Likewise.
1262         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1263         * features/arm/arm-m-profile.c: Likewise.
1264         * features/arm/arm-vfpv2.c: Likewise.
1265         * features/arm/arm-vfpv3.c: Likewise.
1266         * features/arm/xscale-iwmmxt.c: Likewise.
1267         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1268
1269 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1270
1271         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1272         ptrace earlier.
1273
1274 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1275
1276         * features/aarch64-pauth.c: Regenerate.
1277
1278 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1279
1280         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1281         bool.
1282         (bpstat_what): Use false instead of 0.
1283
1284 2019-07-09  Pedro Alves  <palves@redhat.com>
1285
1286         * break-catch-throw.c (is_exception_catchpoint): New.
1287         * breakpoint.c (print_one_breakpoint_location): New parameter
1288         'raw_loc'.  Handle it.  Use
1289         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1290         looking at the breakpoint's type.
1291         (print_one_breakpoint): If handling "maint info breakpoints", also
1292         print locations of exception catchpoints.
1293         * breakpoint.h (is_exception_catchpoint): Declare.
1294
1295 2019-07-09  Pedro Alves  <palves@redhat.com>
1296
1297         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1298         "addr" field.
1299         (allocate_location_exception_catchpoint): New.
1300         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1301         (initialize_throw_catchpoint_ops): Install
1302         allocate_location_exception_catchpoint as allocate_location
1303         method.
1304         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1305         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1306         bp_loc_other.
1307         (breakpoint_address_is_meaningful): Delete.
1308         (bl_address_is_meaningful): New.
1309         (breakpoint_locations_match): Adjust comment.
1310         (bp_location_from_bp_type): New, factored out of...
1311         (bp_location::bp_location(breakpoint *)): ... this.
1312         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1313         factored out of...
1314         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1315         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1316         breakpoint_address_is_meaningful.
1317         (bp_locations_compare): Adjust comment.
1318         (update_global_location_list): Use bl_address_is_meaningful
1319         instead of breakpoint_address_is_meaningful.
1320         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1321         explicit.
1322         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1323         * python/py-breakpoint.c (bppy_get_location): No longer check
1324         whether location is null.
1325
1326 2019-07-09  Pedro Alves  <palves@redhat.com>
1327
1328         PR c++/15468
1329         * breakpoint.c (print_one_breakpoint_location): Remove
1330         single-location assert.
1331
1332 2019-07-09  Tom Tromey  <tom@tromey.com>
1333
1334         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1335         * configure: Rebuild.
1336         * configure.ac: Change common to gdbsupport.
1337         * gdbsupport: Rename from common.
1338         * acinclude.m4: Change common to gdbsupport.
1339         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1340         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1341         gdbsupport.
1342         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1343         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1344         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1345         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1346         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1347         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1348         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1349         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1350         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1351         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1352         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1353         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1354         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1355         coff-pe-read.c, command.h, compile/compile-c-support.c,
1356         compile/compile-c.h, compile/compile-cplus-symbols.c,
1357         compile/compile-cplus-types.c, compile/compile-cplus.h,
1358         compile/compile-loc2c.c, compile/compile.c, completer.c,
1359         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1360         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1361         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1362         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1363         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1364         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1365         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1366         features/aarch64-core.c, features/aarch64-fpu.c,
1367         features/aarch64-pauth.c, features/aarch64-sve.c,
1368         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1369         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1370         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1371         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1372         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1373         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1374         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1375         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1376         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1377         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1378         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1379         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1380         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1381         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1382         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1383         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1384         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1385         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1386         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1387         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1388         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1389         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1390         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1391         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1392         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1393         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1394         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1395         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1396         minsyms.c, mips-linux-tdep.c, namespace.h,
1397         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1398         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1399         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1400         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1401         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1402         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1403         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1404         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1405         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1406         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1407         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1408         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1409         procfs.c, producer.c, progspace.h, psymtab.h,
1410         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1411         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1412         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1413         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1414         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1415         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1416         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1417         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1418         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1419         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1420         target-memory.c, target.c, target.h, target/waitstatus.c,
1421         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1422         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1423         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1424         unittests/array-view-selftests.c,
1425         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1426         unittests/common-utils-selftests.c,
1427         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1428         unittests/format_pieces-selftests.c,
1429         unittests/function-view-selftests.c,
1430         unittests/lookup_name_info-selftests.c,
1431         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1432         unittests/mkdir-recursive-selftests.c,
1433         unittests/observable-selftests.c,
1434         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1435         unittests/parse-connection-spec-selftests.c,
1436         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1437         unittests/scoped_fd-selftests.c,
1438         unittests/scoped_mmap-selftests.c,
1439         unittests/scoped_restore-selftests.c,
1440         unittests/string_view-selftests.c, unittests/style-selftests.c,
1441         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1442         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1443         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1444         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1445         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1446         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1447
1448 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1449
1450         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1451         bool value.
1452         (decode_digits_ordinary): Set explicit_line field in sal.
1453         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1454         symtab_and_line that was set on an explicit line number in
1455         assembler code.  Do always update the recorded symtab and line if
1456         we do skip the prologue.
1457
1458 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1459
1460         * breakpoint.c (set_breakpoint_location_function): Remove
1461         explicit_loc parameter.
1462         (momentary_breakpoint_from_master): Update call to
1463         set_breakpoint_location_function.
1464         (add_location_to_breakpoint): Likewise.
1465
1466 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1467
1468         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1469         required features based on default bfd type when no specific bfd
1470         is present.
1471
1472 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1473
1474         * NEWS: Mention that GDB printf and eval commands can now print
1475         C-style and Ada-style convenience var strings without
1476         calling the inferior.
1477         * printcmd.c (printf_c_string): Locally print GDB internal var
1478         instead of transiting via the inferior.
1479         (printf_wide_c_string): Likewise.
1480
1481 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1482
1483         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1484
1485 2019-07-04  Tom Tromey  <tom@tromey.com>
1486
1487         PR tui/24724:
1488         * tui/tui-winsource.c (tui_clear_source_content): Update.
1489         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1490         (tui_update_breakpoint_info): Update.
1491         (tui_set_exec_info_content): Update.
1492         * tui/tui-source.c (tui_set_source_content_nil): Update.
1493         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1494         has_break.
1495         * tui/tui-data.h (enum tui_bp_flag): New.
1496         (tui_bp_flags): New enum flags type.
1497         (struct tui_source_element) <break_mode>: Change type.  Rename
1498         from has_break.
1499         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1500         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1501         constants.
1502         * tui/tui-winsource.h: Fix comment.
1503
1504 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1505
1506         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1507         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1508         (store_fpregs_to_thread)
1509         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1510         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1511         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1512         (IWMMXT_REGS_SIZE): Add define.
1513         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1514         (fetch_vfp_regs, store_vfp_regs)
1515         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1516         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1517
1518 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1519
1520         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1521         defines.
1522         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1523         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1524         (ARM_INT_REGISTER_SIZE): ...to this.
1525         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1526         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1527         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1528         (arm_linux_collect_gregset, supply_nwfpe_register)
1529         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1530         defines.
1531         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1532         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1533         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1534         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1535         (arm_return_in_memory, arm_store_return_value)
1536         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1537         (arm_record_ld_st_multiple): Likewise.
1538         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1539         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1540
1541 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1542
1543         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1544         AARCH64_DISPLACED_MODIFIED_INSNS.
1545         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1546         (aarch64_displaced_step_copy_insn): Likewise.
1547         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1548         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1549         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1550         ARM_DISPLACED_MODIFIED_INSNS.
1551         * arm-tdep.c (arm_gdbarch_init): Likewise.
1552         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1553         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1554         (struct arm_displaced_step_closure): Use
1555         ARM_DISPLACED_MODIFIED_INSNS.
1556
1557 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1558
1559         * features/Makefile: Remove unused xml files.
1560         * features/aarch64.xml: Remove.
1561         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1562         * features/i386/amd64-avx-avx512.xml: Remove.
1563         * features/i386/amd64-avx-linux.xml: Remove.
1564         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1565         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1566         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1567         * features/i386/amd64-avx-mpx.xml: Remove.
1568         * features/i386/amd64-avx.xml: Remove.
1569         * features/i386/amd64-linux.xml: Remove.
1570         * features/i386/amd64-mpx-linux.xml: Remove.
1571         * features/i386/amd64-mpx.xml: Remove.
1572         * features/i386/amd64.xml: Remove.
1573         * features/i386/i386-avx-avx512-linux.xml: Remove.
1574         * features/i386/i386-avx-avx512.xml: Remove.
1575         * features/i386/i386-avx-linux.xml: Remove.
1576         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1577         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1578         * features/i386/i386-avx-mpx-linux.xml: Remove.
1579         * features/i386/i386-avx-mpx.xml: Remove.
1580         * features/i386/i386-avx.xml: Remove.
1581         * features/i386/i386-linux.xml: Remove.
1582         * features/i386/i386-mmx-linux.xml: Remove.
1583         * features/i386/i386-mmx.xml: Remove.
1584         * features/i386/i386-mpx-linux.xml: Remove.
1585         * features/i386/i386-mpx.xml: Remove.
1586         * features/i386/i386.xml: Remove.
1587         * features/i386/x32-avx-avx512-linux.xml: Remove.
1588         * features/i386/x32-avx-linux.xml: Remove.
1589         * features/i386/x32-linux.xml: Remove.
1590
1591 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1592
1593         * regformats/aarch64.dat: Remove.
1594         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1595         * regformats/i386/amd64-avx-linux.dat: Remove.
1596         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1597         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1598         * regformats/i386/amd64-linux.dat: Remove.
1599         * regformats/i386/amd64-mpx-linux.dat: Remove.
1600         * regformats/i386/amd64.dat: Remove.
1601         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1602         * regformats/i386/i386-avx-linux.dat: Remove.
1603         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1604         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1605         * regformats/i386/i386-linux.dat: Remove.
1606         * regformats/i386/i386-mmx-linux.dat: Remove.
1607         * regformats/i386/i386-mpx-linux.dat: Remove.
1608         * regformats/i386/i386.dat: Remove.
1609         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1610         * regformats/i386/x32-avx-linux.dat: Remove.
1611         * regformats/i386/x32-linux.dat: Remove.
1612
1613 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1614
1615         * aarch64-tdep.c: Remove xml self tests.
1616         * amd64-linux-tdep.c: Likewise.
1617         * amd64-tdep.c: Likewise.
1618         * i386-linux-tdep.c: Likewise.
1619         * i386-tdep.c: Likewise.
1620
1621 2019-07-03  Pedro Alves  <palves@redhat.com>
1622
1623         PR cli/24732
1624         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1625         (pipe_cmd_option_defs): New.
1626         (make_pipe_cmd_options_def_group): New.
1627         (pipe_command): Use gdb::option::process_options.
1628         (pipe_command_completer): New function.
1629         (_initialize_cli_cmds): Install completer for "pipe" command.
1630
1631 2019-07-03  Pedro Alves  <palves@redhat.com>
1632
1633         * cli/cli-option.c (union option_value) <string>: New field.
1634         (struct option_def_and_value): Add ctor, move ctor, dtor and
1635         use DISABLE_COPY_AND_ASSIGN.
1636         (option_def_and_value::clear_value): New.
1637         (parse_option, save_option_value_in_ctx, get_val_type_str)
1638         (add_setshow_cmds_for_options): Handle var_string.
1639         * cli-option.h (union option_def::var_address) <string>: New
1640         field.
1641         (struct string_option_def): New.
1642         * maint-test-options.c (struct test_options_opts): Add default
1643         ctor and use DISABLE_COPY_AND_ASSIGN.
1644         <string_opt>: New field.
1645         (test_options_opts::~test_options_opts): New.
1646         (test_options_opts::dump): Also dump "-string".
1647         (test_options_option_defs): Install "string.
1648
1649 2019-07-03  Pedro Alves  <palves@redhat.com>
1650
1651         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1652         option_value with a null enumeration.
1653         (complete_options): Save the option values in the context.
1654         (save_option_value_in_ctx): New, factored out from ...
1655         (process_options): ... here.
1656         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1657         of the function.
1658         * maint-test-options.c (test_options_opts::dump): New, factored
1659         out from ...
1660         (maintenance_test_options_command_mode): ... here.
1661         (maintenance_test_options_command_completion_result): Delete.
1662         (maintenance_test_options_command_completion_text): Update
1663         comment.
1664         (maintenance_show_test_options_completion_result): Change
1665         prototype.  Just print
1666         maintenance_test_options_command_completion_text.
1667         (save_completion_result): New.
1668         (maintenance_test_options_completer_mode): Pass options context to
1669         complete_options, and then save a dump.
1670         (_initialize_maint_test_options): Use add_cmd to install "maint
1671         show test-options-completion-result".
1672
1673 2019-07-03  Pedro Alves  <palves@redhat.com>
1674
1675         * NEWS (New commands): Mention "with" and "maint with".
1676         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1677         (with_command, with_command_completer): New.
1678         (pipe_command): Adjust to new repeat_previous
1679         interface.
1680         (_initialize_cli_cmds): Install the "with" command and its "w"
1681         alias.
1682         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1683         declarations.
1684         * cli/cli-setshow.c (parse_cli_var_uinteger)
1685         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1686         argument strings for all var_types.
1687         (get_setshow_command_value_string): New, factored out from ...
1688         (do_show_command): ... this.
1689         * cli/cli-setshow.h: Include <string>.
1690         (get_setshow_command_value_string): Declare.
1691         * command.h (repeat_previous): Now returns const char *.  Adjust
1692         comment.
1693         * maint.c: Include "cli/cli-cmds.h".
1694         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1695         (_initialize_maint_cmds): Register the "maintenance with" command.
1696         * top.c (repeat_previous): Move bits from pipe_command here:
1697         Return the saved command line, if any; error out if there's no
1698         command to relaunch.
1699
1700 2019-07-03  Pedro Alves  <palves@redhat.com>
1701
1702         * NEWS (New commands): Mention "maint set/show test-settings"
1703         instead of "maint test-settings".
1704         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1705         (maintenance_test_settings_set_list): Rename to ...
1706         (maintenance_set_test_settings_list): ... this.
1707         (maintenance_test_settings_show_list): Rename to  ...
1708         (maintenance_show_test_settings_list): ... this.
1709         (maintenance_test_settings_cmd): Delete.
1710         (maintenance_test_settings_set_cmd): ...
1711         (maintenance_set_test_settings_cmd): ... this.
1712         (maintenance_test_settings_show_cmd): ...
1713         (maintenance_show_test_settings_cmd): ... this.
1714         (maintenance_test_settings_show_value_cmd):
1715         (maintenance_show_test_settings_value_cmd): ... this.
1716         (_initialize_maint_test_settings): No longer install the "maint
1717         test-settings" prefix command.  Rename "maint test-settings set"
1718         to "maint set test-settings", and "maint test-settings show" to
1719         "maint show test-settings".  Adjust all subcommands.
1720
1721 2019-07-03  Pedro Alves  <palves@redhat.com>
1722
1723         * maint-test-settings.c: Fix file's intro comment.  Replace all
1724         references to "test-options" with references to "test-settings",
1725         in comments.
1726
1727 2019-07-03  Pedro Alves  <palves@redhat.com>
1728
1729         * maint-test-settings.c (maintenance_test_settings_xxx)
1730         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1731         New.
1732         (maintenance_test_settings_enums): Use them.
1733         (maintenance_test_settings_enum): Default to
1734         maintenance_test_settings_xxx.
1735         (_initialize_maint_test_settings): Initialize
1736         MAINTENANCE_TEST_SETTINGS_FILENAME.
1737
1738 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1739
1740         * breakpoint.h (remove_breakpoints_inf): Change return type to
1741         void, move function documentation here.
1742         * breakpoint.c (remove_breakpoints_inf): Change return type to
1743         void, move function documentation to header.
1744
1745 2019-07-02  Pedro Alves  <palves@redhat.com>
1746
1747         * NEWS (Completion improvements): Mention "info threads".
1748         * thread.c (struct info_threads_opts, info_threads_option_defs)
1749         (make_info_threads_options_def_group): New.
1750         (info_threads_command): Use gdb::option::process_options.
1751         (info_threads_command_completer): New.
1752         (_initialize_thread): Use gdb::option::build_help to build the
1753         help text for "info threads".
1754
1755 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1756
1757         * defs.h (generic_load): Move from here...
1758         * symfile.h (generic_load): ... to here.  Rename name parameter
1759         to args.
1760         * symfile.c (generic_load): Add comment.
1761
1762 2019-07-01  Tom Tromey  <tromey@adacore.com>
1763
1764         * dwarf2read.c
1765         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1766         declaration of without_params.  Fix formatting.
1767
1768 2019-07-01  Tom Tromey  <tromey@adacore.com>
1769
1770         * ada-exp.y (find_primitive_type): Update.
1771         * ada-lang.h (ada_lookup_symbol): Update.
1772         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1773         parameter.
1774         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1775
1776 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1777
1778         PR breakpoints/24541
1779         * gdbarch.c: Regenerate.
1780         * gdbarch.h: Regenerate.
1781         * gdbarch.sh: Add 'stap_adjust_register'.
1782         * i386-tdep.c: Include '<unordered_set>'.
1783         (i386_stap_adjust_register): New function.
1784         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1785         * stap-probe.c (stap_parse_register_operand): Call
1786         'gdbarch_stap_adjust_register'.
1787
1788 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1789
1790         PR python/24742
1791         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1792         * python/python.c (do_start_initialization): Use 'xmalloc'
1793         instead of 'PyMem_Malloc'.
1794
1795 2019-06-28  Tom Tromey  <tromey@adacore.com>
1796
1797         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1798         for Ada.
1799
1800 2019-06-27  Tom Tromey  <tromey@adacore.com>
1801
1802         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1803         objfile_key.
1804         (arm_find_mapping_symbol, arm_record_special_symbol)
1805         (_initialize_arm_tdep): Update.
1806         (arm_objfile_data_free): Remove.
1807
1808 2019-06-27  Tom Tromey  <tromey@adacore.com>
1809
1810         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1811         to cp_print_static_field.
1812
1813 2019-06-26  Tom Tromey  <tromey@adacore.com>
1814
1815         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1816         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1817         declare.
1818
1819 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1820
1821         * features/aarch64-core.c (create_feature_aarch64_core):
1822         Regenerate.
1823         * features/aarch64-core.xml: Add cpsr flags.
1824
1825 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1826
1827         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1828         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1829
1830 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1831
1832         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1833         field.
1834         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1835         use.
1836         (arm_record_special_symbol): Don't insert new symbol in sorted
1837         position, push it at the end.
1838
1839 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1840
1841         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1842         (arm_mapping_symbol_s): Remove.
1843         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1844         (arm_mapping_symbol_vec): New typedef.
1845         (struct arm_per_objfile): Add constructor.
1846         <section_maps>: Change type to
1847         std::unique_ptr<arm_mapping_symbol_vec[]>.
1848         (arm_compare_mapping_symbols): Remove.
1849         (arm_find_mapping_symbol): Adjust to section_maps type change.
1850         (arm_objfile_data_free): Call delete on arm_per_objfile.
1851         (arm_record_special_symbol): Adjust to section_maps type change.
1852         Allocate arm_per_objfile with new.
1853
1854 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1855
1856         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1857         with the command prefix.
1858
1859 2019-06-25  Tom Tromey  <tom@tromey.com>
1860
1861         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1862         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1863
1864 2019-06-25  Tom Tromey  <tom@tromey.com>
1865
1866         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1867         type.
1868         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1869         protected.
1870
1871 2019-06-25  Tom Tromey  <tom@tromey.com>
1872
1873         * tui/tui-winsource.c
1874         (tui_source_window_base::set_is_exec_point_at): Add check against
1875         LOA_ADDRESS.
1876
1877 2019-06-25  Tom Tromey  <tom@tromey.com>
1878
1879         * tui/tui-source.c (tui_set_source_content): Don't check before
1880         xfree.
1881         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1882
1883 2019-06-25  Tom Tromey  <tom@tromey.com>
1884
1885         * tui/tui-winsource.h (tui_update_source_window_as_is)
1886         (tui_alloc_source_buffer, tui_line_is_displayed)
1887         (tui_addr_is_displayed): Change type of win_info.
1888         * tui/tui-winsource.c (tui_update_source_window_as_is)
1889         (tui_clear_source_content, tui_show_source_line)
1890         (tui_show_source_content, tui_source_window_base::refill)
1891         (tui_source_window_base::set_is_exec_point_at)
1892         (tui_source_window_base::set_is_exec_point_at)
1893         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1894         (tui_alloc_source_buffer, tui_line_is_displayed)
1895         (tui_addr_is_displayed): Change type of win_info.  Update.
1896         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1897         (tui_source_window_base::do_make_visible_with_new_height):
1898         Update.
1899         * tui/tui-source.c (tui_set_source_content)
1900         (tui_set_source_content_nil)
1901         (tui_source_window::do_scroll_vertical): Update.
1902         * tui/tui-layout.c (show_layout): Update.
1903         * tui/tui-disasm.c (tui_set_disassem_content)
1904         (tui_disasm_window::do_scroll_vertical): Update.
1905         * tui/tui-data.h (tui_win_content): Remove.
1906         (struct tui_gen_win_info) <content, content_size>: Remove.
1907         (struct tui_source_element): Add initializers and destructor.
1908         (union tui_which_element, struct tui_win_element): Remove.
1909         (struct tui_source_window_base) <content>: New field.
1910         (struct tui_data_window): Remove destructor.
1911         (tui_alloc_content, tui_free_win_content)
1912         (tui_free_all_source_wins_content): Don't declare.
1913         * tui/tui-data.c (tui_initialize_static_data): Update.
1914         (init_content_element, tui_alloc_content): Remove.
1915         (~tui_gen_win_info): Update.
1916         (~tui_data_window, tui_free_all_source_wins_content)
1917         (tui_free_win_content, free_content, free_content_elements):
1918         Remove.
1919
1920 2019-06-25  Tom Tromey  <tom@tromey.com>
1921
1922         * tui/tui-winsource.h (tui_clear_source_content)
1923         (tui_erase_source_content, tui_show_source_content): Change type
1924         of win_info.
1925         * tui/tui-winsource.c (tui_clear_source_content)
1926         (tui_erase_source_content, tui_show_source_content): Change type
1927         of win_info.
1928         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1929         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1930         win_info.
1931         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1932         win_info.
1933         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1934
1935 2019-06-25  Tom Tromey  <tom@tromey.com>
1936
1937         * tui/tui-winsource.c (tui_clear_source_content)
1938         (tui_source_window_base::set_is_exec_point_at): Update.
1939         * tui/tui-source.c (tui_set_source_content_nil): Update.
1940         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1941         a bool.
1942         * tui/tui-data.c (init_content_element): Update.
1943
1944 2019-06-25  Tom Tromey  <tom@tromey.com>
1945
1946         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1947         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1948         * tui/tui-layout.c (init_and_make_win): Update.
1949         * tui/tui.h (enum tui_win_type): Update.
1950         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1951         tui_win_is_auxillary.
1952         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1953         tui_win_is_auxillary.
1954
1955 2019-06-25  Tom Tromey  <tom@tromey.com>
1956
1957         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1958         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1959         (tui_delete_data_content_windows, tui_display_all_data)
1960         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1961         Update.
1962         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1963         * tui/tui-regs.c (tui_last_regs_line_no)
1964         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1965         (tui_show_registers): Update.
1966         (tui_show_register_group): Return void.  Update.
1967         (tui_display_registers_from, tui_display_reg_element_at_line)
1968         (tui_display_registers_from_line, tui_check_register_values):
1969         Update.
1970         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1971         member.
1972         (struct tui_data_window) <regs_content>: Now a std::vector.
1973         <regs_content_count>: Remove.
1974         (tui_add_content_elements, tui_free_data_content): Don't declare.
1975         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1976         (init_content_element): Remove DATA_WIN case.  Add assert.
1977         (tui_add_content_elements): Remove.
1978         (tui_data_window): Update.
1979         (tui_free_data_content): Remove.
1980         (free_content_elements): Remove DATA_WIN case.
1981
1982 2019-06-25  Tom Tromey  <tom@tromey.com>
1983
1984         * tui/tui-data.c (tui_data_item_window): Update.
1985         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1986         * tui/tui-windata.c (tui_display_all_data)
1987         (tui_display_data_from_line): Update.
1988         (tui_check_data_values): Remove.
1989         * tui/tui-regs.c (tui_show_register_group)
1990         (tui_display_reg_element_at_line): Update.
1991         * tui/tui-hooks.c (tui_register_changed)
1992         (tui_refresh_frame_and_register_information): Call
1993         tui_check_register_values.
1994         * tui/tui-data.h (struct tui_data_window) <data_content,
1995         data_content_count, data_type>: Remove.
1996         (enum tui_data_type): Remove.
1997
1998         * tui/tui-data.c (tui_data_window::clear_detail)
1999         (~tui_data_window): Update.
2000
2001 2019-06-25  Tom Tromey  <tom@tromey.com>
2002
2003         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
2004         declare.
2005         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
2006         Rename from tui_first_data_item_displayed.  Update.
2007         (tui_data_window::refresh_all)
2008         (tui_data_window::do_scroll_vertical): Update.
2009         * tui/tui-data.h (struct tui_data_window)
2010         <first_data_item_displayed>: Declare new method.
2011
2012 2019-06-25  Tom Tromey  <tom@tromey.com>
2013
2014         * tui/tui-data.h (tui_init_generic_part): Don't declare.
2015         * tui/tui-data.c (tui_init_generic_part): Remove, moving
2016         contents...
2017         (tui_initialize_static_data): ...here.
2018
2019 2019-06-25  Tom Tromey  <tom@tromey.com>
2020
2021         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2022         (tui_display_registers_from, tui_check_register_values): Update.
2023         (tui_display_register): Remove win_info parameter; update.
2024         (tui_get_register): Change type of parameters.
2025         * tui/tui-data.h (struct tui_data_element): Remove.
2026         (union tui_which_element) <data>: Remove.
2027         <data_window>: Change type.
2028         (struct tui_data_item_window): New.
2029         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
2030         case.  Add assert.
2031         (~tui_data_item_window): New destructor.
2032         (free_content_elements): Remove DATA_ITEM_WIN case.
2033
2034 2019-06-25  Tom Tromey  <tom@tromey.com>
2035
2036         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
2037         Remove.
2038
2039 2019-06-25  Tom Tromey  <tom@tromey.com>
2040
2041         * tui/tui-data.h (struct tui_command_element): Remove.
2042         (union tui_which_element) <command>: Remove.
2043         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
2044         assert.
2045         (free_content_elements): Remove CMD_WIN case.
2046
2047 2019-06-25  Tom Tromey  <tom@tromey.com>
2048
2049         * tui/tui-layout.c (tui_set_layout): Update.
2050         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
2051         * tui/tui-data.c (layout_def): Update.
2052
2053 2019-06-25  Tom Tromey  <tom@tromey.com>
2054
2055         * tui/tui-wingeneral.c (tui_refresh_all): Update.
2056         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2057         (tui_source_window_base::set_new_height): Update.
2058         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
2059         Update.
2060         (tui_set_locator_fullname, tui_set_locator_info)
2061         (tui_show_frame_info): Update.
2062         * tui/tui-source.c (tui_set_source_content)
2063         (tui_source_is_displayed): Update.
2064         * tui/tui-layout.c (show_source_disasm_command, show_data)
2065         (show_source_or_disasm_and_command): Update.
2066         * tui/tui-disasm.c (tui_set_disassem_content)
2067         (tui_get_begin_asm_address): Update.
2068         * tui/tui-data.h (struct tui_locator_element): Remove.
2069         (union tui_which_element) <locator>: Remove.
2070         (struct tui_locator_window): New.
2071         (tui_locator_win_info_ptr): Change return type.
2072         * tui/tui-data.c (_locator): Change type.
2073         (tui_locator_win_info_ptr): Change return type.
2074         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
2075         (tui_alloc_content): Add assert.
2076
2077 2019-06-25  Tom Tromey  <tom@tromey.com>
2078
2079         * tui/tui-winsource.c
2080         (tui_exec_info_window::maybe_allocate_content): New method.
2081         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
2082         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
2083         (make_source_or_disasm_window): Add cast.
2084         * tui/tui-data.h (union tui_which_element) <simple_string>:
2085         Remove.
2086         (struct tui_source_info): New.
2087         (struct tui_source_window_base) <execution_info>: Change type.
2088         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
2089         case, and add assert.
2090         (tui_alloc_content): Add assert.
2091
2092 2019-06-25  Tom Tromey  <tom@tromey.com>
2093
2094         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
2095         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
2096         * tui/tui-data.c (tui_alloc_win_info): Remove.
2097
2098 2019-06-25  Tom Tromey  <tom@tromey.com>
2099
2100         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
2101         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
2102         can_highlight.
2103
2104 2019-06-25  Tom Tromey  <tom@tromey.com>
2105
2106         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
2107         make_visible_with_new_height method.
2108         (tui_win_info::make_visible_with_new_height): New method.
2109         (tui_source_window_base::do_make_visible_with_new_height)
2110         (tui_data_window::do_make_visible_with_new_height)
2111         (tui_cmd_window::do_make_visible_with_new_height): New methods.
2112         (make_visible_with_new_height): Remove.
2113         (tui_resize_all, tui_adjust_win_heights): Use
2114         make_visible_with_new_height method.
2115         * tui/tui-data.h (struct tui_win_info)
2116         <do_make_visible_with_new_height, make_visible_with_new_height>:
2117         New methods.
2118         (struct tui_source_window_base, struct tui_data_window)
2119         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
2120         methods.
2121
2122 2019-06-25  Tom Tromey  <tom@tromey.com>
2123
2124         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
2125         method.
2126         (update_tab_width): Call update_tab_width method.
2127         * tui/tui-data.h (struct tui_win_info)
2128         (struct tui_source_window_base) <update_tab_width>: New methods.
2129
2130 2019-06-25  Tom Tromey  <tom@tromey.com>
2131
2132         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
2133         parameter.
2134         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
2135         parameter.
2136         (tui_gen_win_info::make_visible): Update.
2137         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
2138         parameter.
2139         * tui/tui-data.h (enum tui_box): New enum.
2140         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
2141
2142 2019-06-25  Tom Tromey  <tom@tromey.com>
2143
2144         * tui/tui-layout.c (make_source_or_disasm_window): Always use
2145         init_and_make_win for EXEC_INFO_WIN.
2146         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
2147         longer inline.
2148         (struct tui_win_info) <~tui_win_info>: Inline.
2149         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2150         Don't declare.
2151         * tui/tui-data.c (source_win, disasm_win): Remove globals.
2152         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2153         Remove.
2154         (tui_initialize_static_data): Update.
2155         (~tui_gen_win_info): Handle more cleanup here.
2156         (~tui_source_window_base): Delete "execution_info".
2157         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
2158
2159 2019-06-25  Tom Tromey  <tom@tromey.com>
2160
2161         * tui/tui-layout.c (make_command_window): Don't set
2162         can_highlight.
2163         (show_source_disasm_command): Call the reset method.
2164         (show_data): Don't set can_highlight.  Call the reset method.
2165         (tui_gen_win_info::reset): Rename from init_gen_win_info
2166         (init_and_make_win): Simplify.  Return tui_gen_win_info.
2167         (show_source_or_disasm_and_command): Call the reset method.
2168         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2169         (struct tui_cmd_window): Set can_highlight.
2170
2171 2019-06-25  Tom Tromey  <tom@tromey.com>
2172
2173         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2174         from make_visible.
2175         (tui_make_visible, tui_make_invisible): Rewrite.
2176         (tui_win_info::make_visible): Remove.
2177         (tui_source_window_base::make_visible): Update.
2178         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2179         method.  Moved from...
2180         (struct tui_win_info) <make_visible>: ...here.
2181
2182 2019-06-25  Tom Tromey  <tom@tromey.com>
2183
2184         * tui/tui-winsource.c
2185         (tui_source_window_base::do_scroll_horizontal): Remove direction
2186         parameter.
2187         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2188         direction parameter.
2189         * tui/tui-win.c (tui_win_info::forward_scroll)
2190         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2191         (tui_win_info::right_scroll): Update.
2192         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2193         direction parameter.
2194         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2195         direction parameter.
2196         * tui/tui-data.h (enum tui_scroll_direction): Remove.
2197         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2198         Remove direction parameter.
2199         (struct tui_source_window_base, struct tui_source_window)
2200         (struct tui_disasm_window, struct tui_data_window)
2201         (struct tui_cmd_window): Update.
2202
2203 2019-06-25  Tom Tromey  <tom@tromey.com>
2204
2205         * tui/tui-winsource.h (tui_set_exec_info_content)
2206         (tui_show_exec_info_content, tui_erase_exec_info_content)
2207         (tui_clear_exec_info_content, tui_update_exec_info): Change
2208         argument to tui_source_window_base.
2209         * tui/tui-winsource.c (tui_set_exec_info_content)
2210         (tui_show_exec_info_content, tui_erase_exec_info_content)
2211         (tui_clear_exec_info_content, tui_update_exec_info): Change
2212         argument to tui_source_window_base.
2213
2214 2019-06-25  Tom Tromey  <tom@tromey.com>
2215
2216         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2217         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2218
2219 2019-06-25  Tom Tromey  <tom@tromey.com>
2220
2221         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2222         check.
2223
2224 2019-06-25  Tom Tromey  <tom@tromey.com>
2225
2226         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2227         type to void.
2228         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2229         type to void.
2230         * tui/tui-source.c (tui_set_source_content): Update.
2231         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2232
2233 2019-06-25  Tom Tromey  <tom@tromey.com>
2234
2235         * tui/tui-win.c (window_name_completer, tui_set_focus)
2236         (tui_all_windows_info): Use name method.
2237         * tui/tui-data.h (struct tui_gen_win_info)
2238         (struct tui_source_window, struct tui_disasm_window)
2239         (struct tui_data_window, struct tui_cmd_window) <name>: New
2240         method.
2241         (tui_win_name): Don't declare.
2242         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2243         (tui_win_name): Remove.
2244
2245 2019-06-25  Tom Tromey  <tom@tromey.com>
2246
2247         * tui/tui-winsource.h (tui_update_source_window)
2248         (tui_update_source_window_as_is): Change parameter type.
2249         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2250         to be a tui_source_window_base.
2251         (tui_update_source_window_as_is): Likewise.
2252         * tui/tui-win.c (make_visible_with_new_height): Update.
2253
2254 2019-06-25  Tom Tromey  <tom@tromey.com>
2255
2256         * tui/tui-winsource.c (tui_erase_source_content)
2257         (tui_show_source_content, tui_show_exec_info_content)
2258         (tui_erase_exec_info_content): Use refresh_window method.
2259         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2260         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2261         from tui_refresh_win.
2262         (tui_data_window::refresh_window): New method.
2263         (tui_win_info::refresh, tui_source_window_base::refresh)
2264         (tui_refresh_all): Use refresh_window method.
2265         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2266         method.
2267         * tui/tui-regs.c (tui_display_register): Call refresh_window
2268         method.
2269         * tui/tui-layout.c (show_source_disasm_command)
2270         (show_source_or_disasm_and_command): Call refresh_window method.
2271         * tui/tui-data.h (struct tui_gen_win_info)
2272         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2273         New method.
2274
2275 2019-06-25  Tom Tromey  <tom@tromey.com>
2276
2277         * tui/tui.c (tui_rl_other_window, tui_enable)
2278         (tui_is_window_visible, tui_get_command_dimension): Update.
2279         * tui/tui-winsource.c (tui_update_source_window_as_is)
2280         (tui_clear_source_content, tui_erase_source_content)
2281         (tui_show_source_line, tui_source_window_base::refill)
2282         (tui_source_window_base::do_scroll_horizontal)
2283         (tui_source_window_base::set_is_exec_point_at)
2284         (tui_update_breakpoint_info, tui_set_exec_info_content)
2285         (tui_alloc_source_buffer, tui_line_is_displayed)
2286         (tui_addr_is_displayed): Update.
2287         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2288         (tui_check_and_display_highlight_if_needed)
2289         (tui_win_info::make_visible, tui_win_info::refresh)
2290         (tui_refresh_all): Update.
2291         * tui/tui-windata.c (tui_first_data_item_displayed)
2292         (tui_delete_data_content_windows, tui_erase_data_content)
2293         (tui_display_all_data, tui_data_window::refresh_all)
2294         (tui_check_data_values): Update.
2295         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2296         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2297         (tui_win_info::backward_scroll, tui_refresh_all_win)
2298         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2299         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2300         (tui_source_window_base::set_new_height)
2301         (tui_data_window::set_new_height)
2302         (make_invisible_and_set_new_height)
2303         (make_visible_with_new_height, new_height_ok)
2304         (parse_scrolling_args): Update.
2305         * tui/tui-stack.c (tui_show_frame_info): Update.
2306         * tui/tui-source.c (tui_set_source_content)
2307         (tui_set_source_content_nil, tui_source_is_displayed)
2308         (tui_source_window::do_scroll_vertical): Update.
2309         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2310         (tui_display_registers_from, tui_display_reg_element_at_line)
2311         (tui_check_register_values, tui_reg_command): Update.
2312         * tui/tui-layout.c (tui_default_win_height)
2313         (show_source_disasm_command, show_data, init_and_make_win)
2314         (show_source_or_disasm_and_command): Update.
2315         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2316         (tui_redisplay_readline, tui_mld_flush)
2317         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2318         (tui_getc): Update.
2319         * tui/tui-disasm.c (tui_set_disassem_content)
2320         (tui_disasm_window::do_scroll_vertical): Update.
2321         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2322         Now virtual.
2323         (struct tui_win_info): Derive from tui_gen_win_info.
2324         <~tui_win_info>: Mark as override.
2325         <generic>: Remove member.
2326         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2327         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2328         (~tui_data_window, ~tui_win_info)
2329         (tui_free_all_source_wins_content): Update.
2330         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2331
2332 2019-06-25  Tom Tromey  <tom@tromey.com>
2333
2334         * tui/tui-layout.c (init_and_make_win): Use new.
2335         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2336         destructor, initializers.
2337         (tui_alloc_generic_win_info): Don't declare.
2338         * tui/tui-data.c (_locator): Add argument to constructor.
2339         (source_win, disasm_win): New globals.
2340         (exec_info): Remove.
2341         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2342         Update.
2343         (tui_alloc_generic_win_info): Remove.
2344         (init_content_element): Use new.
2345         (tui_win_info::tui_win_info): Update.
2346         (free_content_elements) <case DATA_WIN>: Use delete.
2347
2348 2019-06-25  Tom Tromey  <tom@tromey.com>
2349
2350         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2351         * tui/tui-windata.c (tui_first_data_item_displayed)
2352         (tui_delete_data_content_windows): Update.
2353         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2354         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2355         (tui_display_registers_from, tui_check_register_values): Update.
2356         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2357         pointer.
2358         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2359         window.
2360         (tui_free_data_content): Update.
2361         (free_content_elements) <case DATA_WIN>: Free the window.
2362
2363 2019-06-25  Tom Tromey  <tom@tromey.com>
2364
2365         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2366         Update.
2367         * tui/tui-layout.c (make_command_window)
2368         (show_source_disasm_command, show_data, init_and_make_win)
2369         (show_source_or_disasm_and_command): Update.
2370         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2371         method.
2372         <can_highight, is_highlighted>: Now bool.
2373         (tui_set_win_highlight): Don't declare.
2374         * tui/tui-data.c (tui_set_win_highlight): Remove.
2375
2376 2019-06-25  Tom Tromey  <tom@tromey.com>
2377
2378         * tui/tui-wingeneral.c (make_visible): Remove check of window
2379         type.
2380
2381 2019-06-25  Tom Tromey  <tom@tromey.com>
2382
2383         * tui/tui-win.c (tui_win_info::max_height)
2384         (tui_cmd_window::max_height): New methods.
2385         (new_height_ok): Call max_height.
2386         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2387         <max_height>: New method.
2388
2389 2019-06-25  Tom Tromey  <tom@tromey.com>
2390
2391         * tui/tui-win.c (tui_source_window_base::set_new_height)
2392         (tui_data_window::set_new_height): New methods.
2393         (make_invisible_and_set_new_height): Call set_new_height method.
2394         * tui/tui-data.h (struct tui_win_info)
2395         (struct tui_source_window_base, struct tui_data_window)
2396         <set_new_height>: New method.
2397
2398 2019-06-25  Tom Tromey  <tom@tromey.com>
2399
2400         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2401         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2402         tui_refresh_data_win.
2403         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2404         method.
2405         (tui_refresh_all_win): Call the refresh_all method.
2406         (tui_set_focus): Likewise.
2407         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2408         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2409         Likewise.
2410
2411 2019-06-25  Tom Tromey  <tom@tromey.com>
2412
2413         * tui/tui-winsource.h (tui_refill_source_window)
2414         (tui_set_is_exec_point_at): Don't declare.
2415         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2416         (tui_source_window_base::refill): Rename from
2417         tui_refill_source_window.
2418         (tui_source_window_base::do_scroll_horizontal): Update.
2419         (tui_source_window_base::set_is_exec_point_at): Rename from
2420         tui_set_is_exec_point_at.
2421         (tui_update_all_breakpoint_info): Update.
2422         * tui/tui-stack.c (tui_show_frame_info): Update.
2423         * tui/tui-layout.c (show_data): Add cast.
2424         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2425         * tui/tui-data.h (struct tui_source_window_base) <refill,
2426         set_is_exec_point_at>: New methods.
2427         (tui_source_windows, tui_add_to_source_windows): Update types.
2428         (tui_add_to_source_windows): Remove redundant declaration.
2429         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2430         (tui_source_windows): Change return type.
2431         (tui_clear_source_windows_detail): Update.
2432         (tui_add_to_source_windows): Change type of parameter.
2433         (tui_free_all_source_wins_content): Update.
2434
2435 2019-06-25  Tom Tromey  <tom@tromey.com>
2436
2437         * tui/tui-wingeneral.c (tui_win_info::refresh)
2438         (tui_source_window_base::refresh): New methods.
2439         (tui_refresh_all): Call the refresh method.
2440         * tui/tui-data.h (struct tui_win_info)
2441         (struct tui_source_window_base) <refresh>: New method.
2442
2443 2019-06-25  Tom Tromey  <tom@tromey.com>
2444
2445         * tui/tui.h (tui_is_window_visible): Return bool.
2446         * tui/tui.c (tui_is_window_visible): Return bool.
2447         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2448         (tui_make_visible, tui_make_invisible)
2449         (tui_win_info::make_visible)
2450         (tui_source_window_base::make_visible, make_all_visible)
2451         (tui_make_all_visible, tui_make_all_invisible): Update.
2452         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2453         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2454         bool.
2455         (struct tui_win_info, struct tui_source_window_base)
2456         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2457         * tui/tui-data.c (tui_init_generic_part): Update.
2458
2459 2019-06-25  Tom Tromey  <tom@tromey.com>
2460
2461         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2462         (tui_source_window_base::make_visible): New methods.
2463         (make_all_visible): Make method call.
2464         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2465         (struct tui_source_window_base, struct tui_cmd_window): Override
2466         make_visible.
2467         (tui_win_is_source_type): Don't declare.
2468         * tui/tui-data.c (tui_win_is_source_type): Remove.
2469
2470 2019-06-25  Tom Tromey  <tom@tromey.com>
2471
2472         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2473         NULL check.
2474
2475 2019-06-25  Tom Tromey  <tom@tromey.com>
2476
2477         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2478         Inline constructor.  Add initializers for members.
2479         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2480         constructors; now inline in class.
2481
2482 2019-06-25  Tom Tromey  <tom@tromey.com>
2483
2484         * tui/tui-regs.c (tui_show_registers): Update.
2485         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2486         bool.
2487         * tui/tui-data.c (tui_data_window::clear_detail)
2488         (tui_data_window): Update.
2489
2490 2019-06-25  Tom Tromey  <tom@tromey.com>
2491
2492         * tui/tui-windata.c (tui_display_all_data)
2493         (tui_display_data_from_line, tui_display_data_from)
2494         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2495         Update.
2496         * tui/tui-regs.c (tui_last_regs_line_no)
2497         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2498         (tui_show_registers, tui_show_register_group)
2499         (tui_display_registers_from, tui_display_reg_element_at_line)
2500         (tui_display_registers_from_line, tui_check_register_values)
2501         (tui_reg_next, tui_reg_prev): Update.
2502         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2503         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2504         tui_data_window.
2505         (struct tui_win_info) <detail>: Remove.  Add new fields from
2506         tui_data_info.
2507         (TUI_DATA_WIN): Add cast.
2508         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2509         (~tui_data_window): Simplify.
2510
2511 2019-06-25  Tom Tromey  <tom@tromey.com>
2512
2513         * tui/tui-layout.c (show_source_disasm_command)
2514         (show_source_or_disasm_and_command): Update.
2515         * tui/tui-io.c (update_cmdwin_start_line)
2516         (tui_redisplay_readline): Update.
2517         * tui/tui-data.h (struct tui_command_info): Remove.
2518         (struct tui_win_info) <detail>: Remove command_info member.
2519         (struct tui_data_window) <start_line>: New member, from
2520         tui_command_info.
2521         (TUI_CMD_WIN): Add casts.
2522
2523 2019-06-25  Tom Tromey  <tom@tromey.com>
2524
2525         * tui/tui-winsource.c (tui_update_source_window)
2526         (tui_refill_source_window)
2527         (tui_source_window_base::do_scroll_horizontal)
2528         (tui_update_breakpoint_info, tui_set_exec_info_content)
2529         (tui_show_exec_info_content, tui_erase_exec_info_content)
2530         (tui_clear_exec_info_content): Update.
2531         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2532         Update.
2533         * tui/tui-win.c (make_invisible_and_set_new_height)
2534         (make_visible_with_new_height): Update.
2535         * tui/tui-source.c (tui_set_source_content)
2536         (tui_show_symtab_source): Update.
2537         * tui/tui-layout.c (extract_display_start_addr)
2538         (show_source_disasm_command, show_data)
2539         (make_source_or_disasm_window)
2540         (show_source_or_disasm_and_command): Update.
2541         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2542         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2543         "gdbarch".
2544         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2545         to tui_source_window_base.
2546         (struct tui_win_info) <detail>: Remove source_info member.
2547         (struct tui_source_window_base) <has_locator>: Inline.
2548         Move contents from tui_source_info; rename has_locator member to
2549         m_has_locator.
2550         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2551         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2552         header file.
2553         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2554         Simplify.
2555         (tui_free_all_source_wins_content): Cast to
2556         tui_source_window_base.
2557
2558 2019-06-25  Tom Tromey  <tom@tromey.com>
2559
2560         * tui/tui-win.c (make_invisible_and_set_new_height)
2561         (make_visible_with_new_height): Call has_locator method.
2562         * tui/tui-layout.c (show_source_disasm_command, show_data)
2563         (show_source_or_disasm_and_command): Update for bool change.
2564         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2565         (tui_win_info) <has_locator>: New method.
2566         (struct tui_source_window_base) <has_locator>: New method.
2567         (tui_win_has_locator): Don't declare.
2568         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2569         from tui_win_has_locator.
2570         (tui_source_window_base): Use false, not FALSE.
2571
2572 2019-06-25  Tom Tromey  <tom@tromey.com>
2573
2574         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2575         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2576         clear_detail method directly.
2577         (tui_clear_win_detail): Remove.
2578
2579 2019-06-25  Tom Tromey  <tom@tromey.com>
2580
2581         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2582         "this", not TUI_DISASM_WIN.
2583
2584 2019-06-25  Tom Tromey  <tom@tromey.com>
2585
2586         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2587         declare.
2588         * tui/tui-winsource.c
2589         (tui_source_window_base::do_scroll_horizontal): Rename from
2590         tui_horizontal_source_scroll.
2591         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2592         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2593         from tui_vertical_data_scroll.
2594         * tui/tui-win.h (tui_scroll): Don't declare.
2595         * tui/tui-win.c (tui_win_info::forward_scroll)
2596         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2597         (tui_win_info::right_scroll): Rename and update.
2598         (tui_scroll_forward_command, tui_scroll_backward_command)
2599         (tui_scroll_left_command, tui_scroll_right_command): Update.
2600         (tui_scroll): Remove.
2601         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2602         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2603         from tui_vertical_source_scroll.
2604         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2605         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2606         from tui_vertical_disassem_scroll.
2607         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2608         do_scroll_horizontal>: New methods.
2609         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2610         Likewise.
2611         (struct tui_source_window_base): Add do_scroll_horizontal.
2612         (struct tui_source_window, struct tui_disasm_window): Add
2613         do_scroll_vertical.
2614         (struct tui_data_window, struct tui_cmd_window): Add
2615         do_scroll_horizontal and do_scroll_vertical.
2616         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2617
2618 2019-06-25  Tom Tromey  <tom@tromey.com>
2619
2620         * tui/tui-data.h (struct tui_source_window_base): New struct.
2621         (struct tui_source_window): Derive from tui_source_window_base.
2622         (struct tui_disasm_window): New struct.
2623         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2624         from tui_source_window::clear_detail.
2625         (tui_source_window_base): Rename from tui_source_window.
2626         (~tui_source_window_base): Rename from ~tui_source_window.
2627         (tui_alloc_win_info): Create a tui_disasm_window.
2628
2629 2019-06-25  Tom Tromey  <tom@tromey.com>
2630
2631         * tui/tui-data.h (struct tui_source_window)
2632         (struct tui_data_window): Declare destructors.
2633         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2634         destructors.
2635         (tui_win_info): Simplify.
2636
2637 2019-06-25  Tom Tromey  <tom@tromey.com>
2638
2639         * tui/tui-winsource.c (tui_display_main)
2640         (tui_update_source_windows_with_addr)
2641         (tui_update_all_breakpoint_info): Update.
2642         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2643         (new_height_ok, parse_scrolling_args): Update.
2644         * tui/tui-stack.c (tui_show_frame_info): Update.
2645         * tui/tui-data.h (struct tui_list): Remove.
2646         (tui_source_windows): Return a reference to a std::vector.
2647         * tui/tui-data.c (source_windows): Now a std::vector.
2648         (tui_source_windows): Change return type.
2649         (tui_clear_source_windows): Rewrite.
2650         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2651         (tui_free_all_source_wins_content): Rewrite.
2652
2653 2019-06-25  Tom Tromey  <tom@tromey.com>
2654
2655         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2656         (struct tui_data_window, struct tui_cmd_window): Declare
2657         clear_detail method.
2658         * tui/tui-data.c (tui_source_window::clear_detail)
2659         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2660         methods.
2661         (tui_clear_win_detail): Simplify.
2662
2663 2019-06-25  Tom Tromey  <tom@tromey.com>
2664
2665         * tui/tui-layout.c (make_source_window, make_disasm_window)
2666         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2667         Return the new window.
2668         (show_source_disasm_command, show_data)
2669         (show_source_or_disasm_and_command): Update.
2670
2671 2019-06-25  Tom Tromey  <tom@tromey.com>
2672
2673         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2674         parameter.  Return the new window.
2675         (show_source_disasm_command): Update and remove NULL check.
2676         (show_source_or_disasm_and_command): Update.
2677
2678 2019-06-25  Tom Tromey  <tom@tromey.com>
2679
2680         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2681
2682 2019-06-25  Tom Tromey  <tom@tromey.com>
2683
2684         * tui/tui-data.h (struct tui_win_info): Make constructor
2685         protected.  Make destructor virtual.  Add initializers.
2686         (tui_source_window, tui_data_window, tui_cmd_window): New
2687         classes.
2688         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2689         constructor.  Add "type" parameter.
2690         (tui_source_window, tui_data_window, tui_cmd_window): New
2691         constructors.
2692         (tui_alloc_win_info): Instantiate the appropriate subclass.
2693
2694 2019-06-25  Tom Tromey  <tom@tromey.com>
2695
2696         * tui/tui-win.c (tui_resize_all): Use delete.
2697         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2698         destructor.
2699         (tui_free_window): Don't declare.
2700         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2701         Update.
2702
2703 2019-06-25  Tom Tromey  <tom@tromey.com>
2704
2705         * tui/tui-data.h (struct tui_win_info): Add constructor.
2706         * tui/tui-data.c (tui_alloc_win_info): Use new.
2707         (tui_free_window): Use delete.
2708
2709 2019-06-22  Tom Tromey  <tom@tromey.com>
2710
2711         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2712         declare.
2713         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2714
2715 2019-06-22  Tom Tromey  <tom@tromey.com>
2716
2717         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2718         declare.
2719         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2720
2721 2019-06-22  Tom de Vries  <tdevries@suse.de>
2722
2723         * dwarf2read.c (create_addrmap_from_aranges)
2724         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2725         instead of '%zu'.
2726
2727 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2728
2729         * dwarf2read.h (dwarf2_section_info_def): Remove.
2730         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2731         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2732         std::vector<dwarf2_section_info>.
2733         (struct dwo_file) <~dwo_file>: Remove.
2734         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2735         types field.
2736         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2737         (dwarf2_read_debug_names): Likewise.
2738         (create_debug_types_hash_table): Change parameter type to
2739         array_view, adjust code accordingly.
2740         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2741         (partial_die_info::fixup): Likewise.
2742         (determine_prefix): Likewise.
2743         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2744
2745 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2746
2747         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2748         gdb_bfd_ref_ptr.
2749         <~dwo_file>: Remove call to gdb_bfd_unref.
2750         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2751         gdb_bfd_ref_ptr::get.
2752
2753 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2754
2755         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2756         type to htab_up.
2757         * dwarf2read.c (struct dwo_file): Initialize fields.
2758         <~dwo_file>: New.
2759         (free_dwo_file): Remove, move content to ~dwo_file.
2760         (struct dwo_file_deleter): Remove.
2761         (dwo_file_up>: Remove custom deleter.
2762         (free_dwo_files): Remove.
2763         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2764         dwo_files.
2765         (process_skeletonless_type_units): Call unique_ptr::get.
2766         (allocate_dwo_file_hash_table): Add deleter to created hash
2767         table.  Change return type to htab_up.
2768         (lookup_dwo_file_slot): Don't memset dwo_file, call
2769         unique_ptr::get.
2770         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2771         (create_dwo_unit_in_dwp_v2): Likewise.
2772         (open_and_init_dwo_file): Likewise.
2773         (free_dwo_file_from_slot): Remove.
2774
2775 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2776
2777         * dwarf2read.h (struct dwarf2_section_info) <readin,
2778         is_virtual>: Change type to bool.
2779         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2780         true instead of 1.
2781
2782 2019-06-19  Tom Tromey  <tom@tromey.com>
2783
2784         * tui/tui-data.h (tui_init_content_element): Don't declare.
2785
2786 2019-06-19  Tom Tromey  <tom@tromey.com>
2787
2788         * tui/tui-data.h (tui_init_win_info): Don't declare.
2789
2790 2019-06-19  Tom de Vries  <tdevries@suse.de>
2791
2792         * dwarf2read.h (abstract_to_concrete): Change type to
2793         std::unordered_map<sect_offset, std::vector<sect_offset>,
2794         gdb::hash_enum<sect_offset>>.
2795
2796 2019-06-19  Tom Tromey  <tromey@adacore.com>
2797
2798         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2799         EVAL_AVOID_SIDE_EFFECTS specially.
2800
2801 2019-06-19  Tom Tromey  <tromey@adacore.com>
2802
2803         * source-cache.c (highlighter): New global.
2804         (source_cache::get_source_lines): Create a highlighter on demand.
2805
2806 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2807
2808         * defs.h (deprecated_interactive_hook): Delete declaration.
2809         * interps.c (clear_interpreter_hooks): Remove use of
2810         deprecated_interactive_hook.
2811         * top.c (deprecated_interactive_hook): Delete definition.
2812         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2813
2814 2019-06-18  Tom de Vries  <tdevries@suse.de>
2815
2816         PR gdb/24515
2817         * dwarf2read.h (abstract_to_concrete): Change type from
2818         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2819         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2820         * dwarf2read.c (read_variable): Update.
2821         (dwarf2_fetch_die_loc_sect_off): Update.
2822
2823 2019-06-17  Tom de Vries  <tdevries@suse.de>
2824
2825         PR gdb/24617
2826         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2827         accessing parent[parent_len - 1].
2828
2829 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2830
2831         PR gdb/24364
2832         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2833         call dtrace_process_dof with NULL dof.
2834
2835 2019-06-16  Tom de Vries  <tdevries@suse.de>
2836
2837         PR gdb/24445
2838         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2839
2840 2019-06-16  Tom Tromey  <tom@tromey.com>
2841
2842         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2843         (make_all_visible): Use address of member.
2844
2845 2019-06-16  Tom Tromey  <tom@tromey.com>
2846
2847         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2848         (tui_free_window, free_content, free_content_elements): Remove
2849         unnecessary cast.
2850         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2851         cast.
2852         * tui/tui-regs.c (tui_show_register_group)
2853         (tui_display_registers_from, tui_display_reg_element_at_line):
2854         Remove unnecessary cast.
2855
2856 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2857
2858         * linux-nat.c (normal_mask): Delete.
2859         (_initialize_linux_nat): Don't initialise normal_mask.
2860
2861 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2862
2863         PR gdb/24445
2864         * dwarf-index-write.h (write_psymtabs_to_index): Add
2865         dwz_basename parameter.
2866         * dwarf-index-write.c (write_gdbindex): Move file writing to
2867         write_gdbindex_1.  Change return type void.
2868         (assert_file_size): Move up, remove filename parameter.
2869         (write_gdbindex_1): New function.
2870         (write_debug_names): Change return type to void, call
2871         assert_file_size.
2872         (struct index_wip_file): New struct.
2873         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2874         file logic to index_wip_file.  Write index for dwz file if
2875         needed.
2876         (save_gdb_index_command): Pass basename of dwz file, if present.
2877         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2878         build-id of dwz file, if present.
2879         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2880         (dwarf2_get_dwz_file): Likewise.
2881         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2882         (dwarf2_get_dwz_file): Likewise.
2883
2884 2019-06-16  Tom Tromey  <tom@tromey.com>
2885
2886         * coffread.c (process_coff_symbol): Use xstrdup.
2887         * value.c (create_internalvar): Use xstrdup.
2888
2889 2019-06-16  Tom Tromey  <tom@tromey.com>
2890
2891         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2892         * breakpoint.c (stopin_command, stopat_command)
2893         (until_break_command, decode_location_default): Remove unnecessary
2894         cast.
2895         * utils.c (subset_compare): Remove unnecessary cast.
2896         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2897         cast.
2898         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2899         cast.
2900         * infcmd.c (path_command): Remove unnecessary cast.
2901         * coffread.c (decode_type): Remove unnecessary cast.
2902         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2903         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2904         * tui/tui-stack.c (tui_show_locator_content)
2905         (tui_show_frame_info): Remove unnecessary cast.
2906         * tui/tui-win.c (tui_scroll_forward_command)
2907         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2908         (parse_scrolling_args): Remove unnecessary cast.
2909         * tui/tui-data.c (init_win_info, tui_del_window)
2910         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2911         (free_content_elements): Remove unnecessary cast.
2912         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2913         unnecessary cast.
2914         * tui/tui-source.c (tui_set_source_content)
2915         (tui_vertical_source_scroll): Remove unnecessary cast.
2916         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2917         cast.
2918         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2919         * tui/tui-regs.c (tui_display_registers_from)
2920         (tui_display_register): Remove unnecessary cast.
2921         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2922         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2923         (make_visible): Remove unnecessary cast.
2924         * tui/tui-winsource.c (tui_erase_source_content)
2925         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2926         unnecessary cast.
2927         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2928         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2929         * stabsread.c (read_type, read_array_type, read_range_type):
2930         Remove unnecessary cast.
2931         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2932         (parse_symbol, parse_type, upgrade_type, parse_external)
2933         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2934         unnecessary cast.
2935         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2936
2937 2019-06-16  Tom Tromey  <tom@tromey.com>
2938
2939         * tui/tui-data.c (tui_alloc_generic_win_info)
2940         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2941         checks.
2942
2943 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2944             Andrew Burgess  <andrew.burgess@embecosm.com>
2945
2946         * f-typeprint.c (f_print_type): Don't return early for not
2947         associated or not allocated types.
2948         (f_type_print_varspec_suffix): Add print_rank parameter and print
2949         ranks of array types in case they dangling.
2950         (f_type_print_base): Add print_rank parameter.
2951
2952 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2953
2954         * NEWS: Mention new MI commands.
2955         * break-catch-throw.c (enum exception_event_kind): Move to
2956         breakpoint.h.
2957         (print_mention_exception_catchpoint): Output text as a single
2958         message.
2959         (catch_exception_command_1): Rename to...
2960         (catch_exception_event): ...this, make non-static, update header
2961         command, and change some parameter types.
2962         (catch_catch_command): Update for changes to
2963         catch_exception_command_1.
2964         (catch_throw_command): Likewise.
2965         (catch_rethrow_command): Likewise.
2966         * breakpoint.c (enum exception_event_kind): Delete.
2967         * breakpoint.h (enum exception_event_kind): Moved here from
2968         break-catch-throw.c.
2969         (catch_exception_event): Declare.
2970         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2971         (mi_cmd_catch_throw): New function.
2972         (mi_cmd_catch_rethrow): New function.
2973         (mi_cmd_catch_catch): New function.
2974         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2975         'catch-catch' entries.
2976         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2977         (mi_cmd_catch_rethrow): Declare.
2978         (mi_cmd_catch_catch): Declare.
2979
2980 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2981
2982         * annotate.c (annotate_source_line): Change return type to void,
2983         update implementation to match.
2984         * annotate.h (annotate_source_line): Change return type to void,
2985         update header comment.
2986         * stack.c (print_frame_info): Don't change what frame information
2987         is printed based on whether annotations are on or not.
2988
2989 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2990
2991         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2992         (annotate_source): Make static.
2993         (annotate_source_line): Moved from source.c and renamed from
2994         identify_source_line.  Update the return type.
2995         * annotate.h (annotate_source): Delete declaration.
2996         (annotate_source_line): Declaration moved from source.h, and
2997         renamed from identify_source_line.  Return type updated.
2998         * source.c (identify_source_line): Moved to annotate.c and renamed
2999         to annotate_source_line.
3000         (info_line_command): Remove check of annotation_level.
3001         * source.h (identify_source_line): Move declaration to annotate.h
3002         and rename to annotate_source_line.
3003         * stack.c: Add 'annotate.h' include.
3004         (print_frame_info): Remove check of annotation_level before
3005         calling annotate_source_line.
3006
3007 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3008
3009         * source-cache.c (source_cache::get_plain_source_lines): Use
3010         open_source_file_with_line_charpos instead of just
3011         open_source_file, remove call to find_source_lines.
3012         (source_cache::get_source_lines): Likewise.
3013         * source.c (find_source_lines): Make static.
3014         (get_filename_and_charpos): Renamed into...
3015         (open_source_file_with_line_charpos): ..this along with changes to
3016         return a scoped_fd, and some other minor clean ups.
3017         (identify_source_line): Use open_source_file_with_line_charpos.
3018         (search_command_helper): Use open_source_file_with_line_charpos
3019         instead of just open_source_file, remove call to
3020         find_source_lines.
3021         * source.h (open_source_file_with_line_charpos): Declare new
3022         function.
3023         (find_source_lines): Delete declaration.
3024
3025 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3026
3027         * source.c (get_filename_and_charpos): Remove fullname
3028         parameter.
3029         (identify_source_line): Update call to get_filename_and_charpos.
3030
3031 2019-06-14  Tom Tromey  <tromey@adacore.com>
3032
3033         PR gdb/24502:
3034         * ui-style.h (skip_ansi_escape): Update comment.
3035         * ui-file.h (class no_terminal_escape_file): New class.
3036         * ui-file.c (no_terminal_escape_file::write)
3037         (no_terminal_escape_file::puts): New methods.
3038         * cli/cli-logging.c (handle_redirections): Use
3039         no_terminal_escape_file.
3040
3041 2019-06-14  Tom Tromey  <tromey@adacore.com>
3042
3043         * NEWS: Move convenience variable news above Python news.
3044
3045 2019-06-14  Tom Tromey  <tom@tromey.com>
3046
3047         * gnulib: Move directory to top-level.
3048         * configure.ac: Don't configure gnulib.
3049         * configure: Rebuild.
3050         * common/common-defs.h: Use new path to gnulib.
3051         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
3052         (GNULIB_H): Remove.
3053         (INCGNU): Look in new gnulib location.
3054         (HFILES_NO_SRCDIR): Remove gnulib files.
3055         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
3056         (generated_files): Remove GNULIB_H.
3057         ($(LIBGNU), all-lib): Remove targets.
3058         (distclean): Don't mention GNULIB_BUILDDIR.
3059         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
3060
3061 2019-06-14  Tom Tromey  <tromey@adacore.com>
3062
3063         * symfile.c (add_symbol_file_command): Remove obsolete comment.
3064         Warn if symbol file does not provide any symbols.
3065
3066 2019-06-14  Tom Tromey  <tromey@adacore.com>
3067
3068         * source.c (find_and_open_source): Respect basenames_may_differ.
3069
3070 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
3071
3072         * annotate.c (annotate_breakpoints_invalid): Make use of
3073         scoped_restore_terminal_state.
3074         (annotate_frames_invalid): Likewise.
3075
3076 2019-06-14  Tom Tromey  <tromey@adacore.com>
3077
3078         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
3079         allow assignment to an internalvar.
3080
3081 2019-06-14  Tom Tromey  <tromey@adacore.com>
3082
3083         * ada-lex.l: Allow "_" in attribute names.
3084
3085 2019-06-14  Tom Tromey  <tromey@adacore.com>
3086
3087         PR gdb/24653:
3088         * regcache.c (registers_changed): Don't call alloca.
3089         * top.c (execute_command): Don't call alloca.
3090
3091 2019-06-13  Pedro Alves  <palves@redhat.com>
3092
3093         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
3094         'expression'.  When parsing an expression, error out if there's
3095         junk after "unlimited".
3096         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3097         (do_set_command): Adjust calls to is_unlimited_literal.
3098
3099 2019-06-13  Pedro Alves  <palves@redhat.com>
3100
3101         * compile/compile.c (make_compile_options_def_group): Add braces
3102         around array_view initializer.
3103         * thread.c (make_thread_apply_all_options_def_group)
3104         (make_thread_apply_all_options_def_group): Likewise.
3105
3106 2019-06-13  Pedro Alves  <palves@redhat.com>
3107
3108         * NEWS (New commands): Mention "maint test-options
3109         require-delimiter", "maint test-options unknown-is-error", "maint
3110         test-options unknown-is-operand" and "maint show
3111         test-options-completion-result".
3112         (New command options, command completion): New section.
3113         (Completion improvements): New section.
3114         Mention that you can abbreviate "unlimited".
3115
3116 2019-06-13  Pedro Alves  <palves@redhat.com>
3117
3118         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
3119         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
3120         * unittests/cli-utils-selftests.c (test_parse_flags)
3121         (test_parse_flags_qcs): Delete.
3122         (test_cli_utils): Don't call deleted functions.
3123
3124 2019-06-13  Pedro Alves  <palves@redhat.com>
3125
3126         * thread.c: Include "cli/cli-option.h".
3127         (tp_array_compar_ascending): Global.
3128         (tp_array_compar): Delete function.
3129         (tp_array_compar_ascending, tp_array_compar_descending): New
3130         functions.
3131         (ascending_option_def, qcs_flag_option_def)
3132         (thr_qcs_flags_option_defs)
3133         (make_thread_apply_all_options_def_group)
3134         (make_thread_apply_options_def_group): New.
3135         (thread_apply_all_command): Use gdb::option::process_options.
3136         (thread_apply_command_completer)
3137         (thread_apply_all_command_completer): New.
3138         (thread_apply_command): Use gdb::option::process_options.
3139         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
3140         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
3141         to generate help text of "thread apply".  Adjust "taas"'s help.
3142         * tid-parse.c (tid_range_parser::in_thread_range): New method.
3143         * tid-parse.h (tid_range_parser::in_thread_range): New method.
3144
3145 2019-06-13  Pedro Alves  <palves@redhat.com>
3146
3147         * thread.c (thread_apply_command): Check for invalid TID with
3148         isdigit instead of !isalpha.
3149
3150 2019-06-13  Pedro Alves  <palves@redhat.com>
3151
3152         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
3153         (validate_flags_qcs): New.
3154         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
3155         (validate_flags_qcs): Declare.
3156         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
3157         (make_frame_apply_options_def_group): New.
3158         (frame_apply_command_count): Process options with
3159         gdb::option::process_options.
3160         (frame_apply_completer): New.
3161         (frame_apply_level_completer, frame_apply_all_completer)
3162         (frame_apply_completer): New.
3163         (_initialize_stack): Update help of "frame apply", "frame apply
3164         level", "frame apply all" and "faas" to mention supported options
3165         and install command completers.
3166         * stack.h (frame_apply_all_completer): Declare.
3167         * thread.c: Include "stack.h".
3168         (tfaas_command): Add "--".
3169         (_initialize_thread): Update help "tfaas" to mention supported
3170         options and install command completer.
3171
3172 2019-06-13  Pedro Alves  <palves@redhat.com>
3173
3174         * completer.c (complete_nested_command_line): New.
3175         (gdb_completion_word_break_characters_throw): Add assertion.
3176         * completer.h (complete_nested_command_line): Declare.
3177
3178 2019-06-13  Pedro Alves  <palves@redhat.com>
3179
3180         * stack.c (parse_backtrace_qualifiers): New.
3181         (backtrace_command): Use it.
3182         (backtrace_command_completer): Complete on qualifiers.
3183
3184 2019-06-13  Pedro Alves  <palves@redhat.com>
3185
3186         * frame.c: Include "cli/cli-option.h.
3187         (user_set_backtrace_options): New.
3188         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3189         Delete.
3190         (get_prev_frame): Adjust.
3191         (boolean_option_def, uinteger_option_def)
3192         (set_backtrace_option_defs): New.
3193         (_initialize_frame): Adjust and use
3194         gdb::option::add_setshow_cmds_for_options to install "set
3195         backtrace past-main" and "set backtrace past-entry".
3196         * frame.h: Include "cli/cli-option.h".
3197         (struct frame_print_options): Forward declare.
3198         (print_frame_arguments_all, print_frame_arguments_scalars)
3199         (print_frame_arguments_none): Declare.
3200         (print_entry_values): Delete declaration.
3201         (struct frame_print_options, user_frame_print_options): New.
3202         (struct set_backtrace_options): New.
3203         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3204         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3205         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3206         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3207         (list_args_or_locals): Add frame_print_options parameter.
3208         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3209         * python/py-framefilter.c (enumerate_args): Pass down
3210         USER_FRAME_PRINT_OPTIONS.
3211         * stack.c: Include "cli/cli-option.h".
3212         (print_frame_arguments_all, print_frame_arguments_scalars)
3213         (print_frame_arguments_none): Declare.
3214         (print_raw_frame_arguments, print_entry_values): Delete.
3215         (user_frame_print_options): New.
3216         (boolean_option_def, enum_option_def, frame_print_option_defs):
3217         New.
3218         (struct backtrace_cmd_options): New.
3219         (bt_flag_option_def): New.
3220         (backtrace_command_option_defs): New.
3221         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3222         (print_frame_arg, read_frame_arg, print_frame_args)
3223         (print_frame_info, print_frame): Add frame_print_options parameter
3224         and use it.
3225         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3226         (backtrace_command_1): Add frame_print_options and
3227         backtrace_cmd_options parameters and use them.
3228         (make_backtrace_options_def_group): New.
3229         (backtrace_command): Process command options with
3230         gdb::option::process_options.
3231         (backtrace_command_completer): New.
3232         (_initialize_stack): Extend "backtrace"'s help to mention
3233         supported options.  Install completer for "backtrace".
3234         Install some settings commands with add_setshow_cmds_for_options.
3235
3236 2019-06-13  Pedro Alves  <palves@redhat.com>
3237
3238         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3239         and that "set/show print raw frame-arguments" are now deprecated.
3240
3241         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3242         command.
3243         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3244         * stack.c (_initialize_stack): Install "set/show print
3245         raw-frame-arguments", and deprecate "set/show print raw
3246         frame-arguments".
3247         * valprint.c (_initialize_valprint): Deprecate "set/show print
3248         raw".
3249
3250 2019-06-13  Pedro Alves  <palves@redhat.com>
3251
3252         * compile/compile.c (struct compile_options): New.
3253         (compile_flag_option_def, compile_command_option_defs)
3254         (make_compile_options_def_group): New.
3255         (compile_file_command): Handle options with
3256         gdb::option::process_options.
3257         (compile_file_command_completer): New function.
3258         (compile_code_command): Handle options with
3259         gdb::option::process_options.
3260         (compile_code_command_completer): New function.
3261         (_initialize_compiler): Install completers for "compile code" and
3262         "compile file".  Mention available options in "compile code" and
3263         "compile code"'s help.
3264         * completer.c (advance_to_completion_word): New, factored out from
3265         ...
3266         (advance_to_expression_complete_word_point): ... this.
3267         (advance_to_filename_complete_word_point): New.
3268         * completer.h (advance_to_filename_complete_word_point): New
3269         declaration.
3270
3271 2019-06-13  Pedro Alves  <palves@redhat.com>
3272
3273         * compile/compile.c: Include "cli/cli-option.h".
3274         (compile_print_value): Scope data pointer is now a
3275         value_print_options pointer; adjust.
3276         (compile_print_command): Process options.  Scope data pointer is
3277         now a value_print_options pointer; adjust.
3278         (_initialize_compile): Update "compile print"'s help to include
3279         supported options.  Install a completer for "compile print".
3280         * cp-valprint.c (show_vtblprint, show_objectprint)
3281         (show_static_field_print): Delete.
3282         (_initialize_cp_valprint): Don't install "set print
3283         static-members", "set print vtbl", "set print object" here.
3284         * printcmd.c: Include "cli/cli-option.h" and
3285         "common/gdb_optional.h".
3286         (print_command_parse_format): Rework to fill in a
3287         value_print_options instead of a format_data.
3288         (print_value): Change parameter type from format_data pointer to
3289         value_print_options reference.  Adjust.
3290         (print_command_1): Process options.  Adjust to pass down a
3291         value_print_options.
3292         (print_command_completer): New.
3293         (_initialize_printcmd): Install print_command_completer as
3294         handle_brkchars completer for the "print" command.  Update
3295         "print"'s help to include supported options.
3296         * valprint.c: Include "cli/cli-option.h".
3297         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3298         here from cp-valprint.c.
3299         (boolean_option_def, uinteger_option_def)
3300         (value_print_option_defs, make_value_print_options_def_group):
3301         New.  Use gdb::option::add_setshow_cmds_for_options to install
3302         "set print elements", "set print null-stop", "set print repeats",
3303         "set print pretty", "set print union", "set print array", "set
3304         print address", "set print symbol", "set print array-indexes".
3305         * valprint.h: Include <string> and "cli/cli-option.h".
3306         (make_value_print_options_def_group): Declare.
3307         (print_value): Change parameter type from format_data pointer to
3308         value_print_options reference.
3309         (print_command_completer): Declare.
3310
3311 2019-06-13  Pedro Alves  <palves@redhat.com>
3312
3313         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3314         (COMMON_SFILES): Add maint-test-settings.c.
3315         * cli/cli-decode.c (boolean_enums): New global, factored out from
3316         ...
3317         (add_setshow_boolean_cmd): ... here.
3318         * cli/cli-decode.h (boolean_enums): Declare.
3319         * cli/cli-option.c: New file.
3320         * cli/cli-option.h: New file.
3321         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3322         factored out from ...
3323         (parse_cli_boolean_value(const char *)): ... this.
3324         (is_unlimited_literal): Change parameter type to pointer to
3325         pointer.  Adjust and advance ARG pointer.
3326         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3327         (parse_cli_var_enum): New, factored out from ...
3328         (do_set_command): ... this.  Adjust.
3329         * cli/cli-setshow.h (parse_cli_boolean_value)
3330         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3331         (parse_cli_var_enum): Declare.
3332         * cli/cli-utils.c: Include "cli/cli-option.h".
3333         (get_ulongest): New.
3334         * cli/cli-utils.h (get_ulongest): Declare.
3335         (check_for_argument): New overloads.
3336         * maint-test-options.c: New file.
3337
3338 2019-06-13  Pedro Alves  <palves@redhat.com>
3339
3340         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3341         parse a range if "-" is at the end of the string.
3342
3343 2019-06-13  Pedro Alves  <palves@redhat.com>
3344
3345         * cli/cli-setshow.c (parse_auto_binary_operation)
3346         (parse_cli_boolean_value): Don't allow "o".
3347
3348 2019-06-13  Pedro Alves  <palves@redhat.com>
3349
3350         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3351         * NEWS: Mention maint test-settings KIND.
3352         * maint-test-settings.c: New file.
3353
3354 2019-06-13  Pedro Alves  <palves@redhat.com>
3355
3356         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3357         completer.
3358         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3359         "set" completers.
3360
3361 2019-06-13  Pedro Alves  <palves@redhat.com>
3362
3363         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3364         after item.
3365
3366 2019-06-13  Pedro Alves  <palves@redhat.com>
3367
3368         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3369
3370 2019-06-13  Pedro Alves <palves@redhat.com>
3371
3372         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3373         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3374         call.
3375         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3376         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3377         calls.
3378         (check_for_argument): Skip spaces after argument.
3379
3380 2019-06-13  Pedro Alves  <palves@redhat.com>
3381
3382         * thread.c (thread_apply_command): Adjust TID parsing.
3383         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3384         detected before end of string.
3385         (tid_is_in_list): Error out if LIST is invalid.
3386
3387 2019-06-13  Pedro Alves  <palves@redhat.com>
3388
3389         * completer.c (complete_line_internal_1): Rewind completion word
3390         point.
3391         (completion_tracker::advance_custom_word_point_by): Change
3392         parameter type to int.
3393         * completer.h (completion_tracker::advance_custom_word_point_by):
3394         Likewise.
3395
3396 2019-06-13  Pedro Alves  <palves@redhat.com>
3397
3398         * completer.c (advance_to_completion_word): Handle delimiters.
3399
3400 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3401
3402         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3403
3404 2019-06-11  Tom Tromey  <tom@tromey.com>
3405
3406         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3407         (xmalloc_failed): Move to alloc.c.
3408         * alloc.c: New file.
3409         * Makefile.in (COMMON_SFILES): Add alloc.c.
3410
3411 2019-06-11  Tom Tromey  <tom@tromey.com>
3412
3413         * nat/linux-waitpid.c: Don't include server.h.
3414         (linux_debug): Remove.
3415         (my_waitpid): Update.
3416
3417 2019-06-11  Tom Tromey  <tromey@adacore.com>
3418
3419         * infcall.c (_initialize_infcall): Remove trailing newline from
3420         help.
3421         * user-regs.c (_initialize_user_regs): Remove trailing newline
3422         from help.
3423         * typeprint.c (_initialize_typeprint): Remove trailing newline
3424         from help.
3425         * reverse.c (_initialize_reverse): Remove trailing newlines from
3426         help.
3427         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3428         from help.
3429         * language.c (add_set_language_command): Remove trailing newline
3430         from help.
3431         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3432         help.
3433         * disasm.c (_initialize_disasm): Remove trailing newline from
3434         help.
3435         * top.c (init_main): Remove trailing newline from help.
3436         * interps.c (_initialize_interpreter): Remove trailing newline
3437         from help.
3438         * btrace.c (_initialize_btrace): Remove trailing newlines from
3439         help.
3440         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3441         from help.
3442         * python/python.c (_initialize_python): Remove trailing newline
3443         from help.
3444         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3445         help.
3446         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3447         from help.  Reformat some text.
3448         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3449         from help.
3450         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3451         newline from help.
3452
3453 2019-06-11  Tom Tromey  <tromey@adacore.com>
3454
3455         * darwin-nat.c (darwin_decode_exception_message)
3456         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3457
3458 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3459
3460         * valops.c (value_slice): Check for not allocated or not
3461         associated values.
3462
3463 2019-06-10  Tom de Vries  <tdevries@suse.de>
3464
3465         PR gdb/24618
3466         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3467         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3468         invalid.
3469
3470 2019-06-10  Tom de Vries  <tdevries@suse.de>
3471
3472         PR gdb/24611
3473         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3474         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3475
3476 2019-06-10  Tom de Vries  <tdevries@suse.de>
3477
3478         PR symtab/24545
3479         * symtab.c (struct demangled_name_entry): Add language field.
3480         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3481         static minimal symbol".  Set and use language field.
3482
3483 2019-06-10  Tom Tromey  <tromey@adacore.com>
3484
3485         * ada-lang.c (_initialize_ada_language): Update help text.
3486
3487 2019-06-10  Tom Tromey  <tromey@adacore.com>
3488
3489         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3490         with a newline.
3491         * guile/guile.c (handle_boot_error): Don't end warning with a
3492         newline.
3493         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3494         warning with a newline.
3495         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3496         newline.
3497         (s12z_frame_cache): Likewise.
3498         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3499         a newline.
3500         * solib-svr4.c (disable_probes_interface): Don't end warning with
3501         a newline.
3502         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3503         newline.
3504         * python/python.c (do_finish_initialization): Don't end warning
3505         with a newline.
3506
3507 2019-06-10  Tom Tromey  <tom@tromey.com>
3508
3509         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3510         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3511         gdbpy_enter.
3512
3513 2019-06-10  Tom Tromey  <tromey@adacore.com>
3514
3515         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3516         data.
3517         (elf_new_init): Don't call stabsread_new_init.
3518         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3519         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3520         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3521
3522 2019-06-10  Tom de Vries  <tdevries@suse.de>
3523
3524         PR symtab/16264
3525         PR symtab/24517
3526         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3527
3528 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3529
3530         * source.c (find_and_open_source): Also rewrite relative file
3531         names.
3532
3533 2019-04-26  Amos Bird  <amosbird@gmail.com>
3534
3535         * annotate.c (annotate_thread_exited): Add "thread-exited"
3536         annotation.
3537
3538 2019-06-06  Tom Tromey  <tromey@adacore.com>
3539
3540         * maint.h (class scoped_command_stats): Use
3541         DISABLE_COPY_AND_ASSIGN.
3542         <print_time>: New method.
3543         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3544         print_time.
3545         (scoped_command_stats::print_time): New method.
3546
3547 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3548
3549         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3550         instructions of lengths 6 or 8 bytes.
3551
3552 2019-06-04  Pedro Alves  <palves@redhat.com>
3553
3554         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3555
3556         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3557         * breakpoint.c (condition_completer): Likewise.
3558         * cli/cli-dump.c (scan_expression): Likewise.
3559         * common/filestuff.c (mkdir_recursive): Likewise.
3560         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3561         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3562         (gdb_abspath): Likewise.
3563         * compile/compile-cplus-types.c
3564         (compile_cplus_instance::decl_name): Likewise.
3565         * completer.c (complete_explicit_location):
3566         (signal_completer, reg_or_group_completer_1): Likewise.
3567         * cp-support.c (cp_remove_params_if_any): Likewise.
3568         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3569         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3570         * infcmd.c (strip_bg_char): Likewise.
3571         * linespec.c (copy_token_string): Likewise.
3572         * mi/mi-main.c (output_cores): Likewise.
3573         * psymtab.c (psymtab_search_name):
3574         * symfile.c (test_set_ext_lang_command): Likewise.
3575         * target.c (target_fileio_read_stralloc): Likewise.
3576         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3577         * value.c (complete_internalvar): Likewise.
3578
3579 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3580
3581         Add objfile property to gdb.Type.
3582         * NEWS: Mention Python API addition.
3583         * python/py-type.c (typy_get_objfile): New method.
3584
3585 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3586
3587         * NEWS: Mention the new set|show style [title|highlight].
3588         Mention changes to "show style", "help" and "apropos".
3589
3590 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3591
3592         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3593         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3594         instead of print_help_for_command.
3595         (print_doc_of_command): New function.
3596         (help_list): Add 'apropos -v word' suggestion.
3597         (print_help_for_command): Style the command name using title style.
3598         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3599         (_initialize_cli_cmds): Describe -v in apropos_command help.
3600
3601 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3602
3603         * cli/cli-style.h (cli_style_option): Add name in constructor,
3604         add m_name class member, add constructor with intensity,
3605         add name class function.
3606         (cli_style_option::add_setshow_commands): Remove name argument.
3607         (highlight_style, title_style): New styles.
3608         * cli/cli-style.c (do_show): New function that shows a style
3609         characteristic styling the style name with itself.
3610         (set_style_name): New function.
3611         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3612         Update all callers according to the changes in cli/cli-style.h.
3613         * utils.h (fputs_highlighted): New function.
3614         * utils.c (fputs_highlighted): Likewise.
3615
3616 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3617
3618         * NEWS: Mention new pipe command and new convenience variables.
3619
3620 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3621
3622         * cli/cli-cmds.c (pipe_command): New function.
3623         (_initialize_cli_cmds): Call add_com for pipe_command.
3624         Define | as an alias for pipe.
3625         (exit_status_set_internal_vars): New function.
3626         (shell_escape): Call exit_status_set_internal_vars.
3627         cli/cli-decode.c (find_command_name_length): Recognize | as
3628         a single character command.
3629
3630 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3631
3632         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3633         top.c (execute_command_to_ui_file): New function, mostly a copy
3634         of execute_command_to_string.
3635         (execute_command_to_string): Implement by calling
3636         execute_command_to_ui_file.
3637
3638 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3639
3640         * top.h (saved_command_line): Remove declaration.
3641         * top.c (previous_saved_command_line, previous_repeat_arguments):
3642         New variables.
3643         (saved_command_line): Make static, define together with other
3644         'repeat variables'.
3645         (dont_repeat): Clear repeat_arguments.
3646         (repeat_previous, get_saved_command_line, save_command_line):
3647         New functions.
3648         (gdb_init): Initialize saved_command_line
3649         and previous_saved_command_line.
3650         * main.c (captured_main_1): Remove saved_command_line initialization.
3651         * event-top.c (handle_line_of_input): Update to use
3652         the new 'repeat' related functions instead of direct access to
3653         saved_command_line.
3654         * command.h (repeat_previous, get_saved_command_line,
3655         save_command_line): New declarations.
3656         (dont_repeat): Add comment.
3657
3658 2019-05-30  Tom Tromey  <tromey@adacore.com>
3659
3660         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3661         Fix comment.
3662         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3663
3664 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3665
3666         PR cli/24587
3667         * completer.c (complete): Initialize variable word.
3668
3669 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3670
3671         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3672         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3673         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3674         'body' is NULL to the outter 'if', protecting the '!is_define'
3675         situation as well.
3676
3677 2019-05-29  Tom Tromey  <tromey@adacore.com>
3678
3679         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3680         (dwarf_unknown): New function.
3681         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3682         (dwarf_type_encoding_name): Use dwarf_unknown.
3683
3684 2019-05-29  Tom Tromey  <tromey@adacore.com>
3685
3686         PR c++/20020:
3687         * cp-valprint.c (cp_print_value_fields): Call
3688         cp_print_static_field inside "try".
3689
3690 2019-05-29  Tom Tromey  <tromey@adacore.com>
3691
3692         * inflow.c (struct terminal_info): Add default operator=.
3693         * configure: Rebuild.
3694         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3695         -Wdeprecated-copy-dtor, -Wredundant-move.
3696
3697 2019-05-29  Tom Tromey  <tromey@adacore.com>
3698
3699         * NEWS: Add entry.
3700         * infcmd.c (print_return_value_1): Handle finish_print
3701         option.
3702         (show_print_finish): New function.
3703         (_initialize_infcmd): Add "set/show print finish" commands.
3704         * valprint.c (user_print_options): Initialize new member.
3705         * valprint.h (struct value_print_options) <finish_print>: New
3706         member.
3707
3708 2019-05-28  Tom Tromey  <tromey@adacore.com>
3709
3710         * ada-lang.c (ada_remove_Xbn_suffix)
3711         (find_old_style_renaming_symbol)
3712         (parse_old_style_renaming): Remove.
3713         (ada_find_renaming_symbol): Don't call
3714         find_old_style_renaming_symbol.
3715         (ada_is_renaming_symbol): Rename from
3716         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3717         bool.  Now static.
3718         (ada_read_var_value): Update and simplify.
3719         * ada-exp.y (write_var_or_type): Remove old code.
3720
3721 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3722
3723         * event-top.c: Remove include comment.
3724         * inflow.c (class scoped_ignore_sigttou): Move from here...
3725         * inflow.h (class scoped_ignore_sigttou): ...to here.
3726         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3727         * top.c:  Remove include comment.
3728
3729 2019-05-27  Tom Tromey  <tom@tromey.com>
3730
3731         * NEWS: Fix typo.
3732
3733 2019-05-22  Tom Tromey  <tromey@adacore.com>
3734
3735         * target.c (target_follow_exec): Constify parameter.
3736         * target-delegates.c: Rebuild.
3737         * remote.c (remote_target::follow_exec): Constify parameter.
3738         * infrun.c (follow_exec): Constify parameter.
3739         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3740         (target_follow_exec): Likewise.
3741
3742 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3743
3744         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3745         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3746
3747 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3748
3749         * NEWS: Add debugredirect and testsuite sections.
3750
3751 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3752
3753         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3754         target descriptions using exclusively floating point register name
3755         aliases.
3756
3757 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3758
3759         PR gdb/18644:
3760         * f-lang.c (build_fortran_types): Handle the case where
3761         gdbarch_floatformat_for_type returns a nullptr.
3762
3763 2019-05-21  Tom de Vries  <tdevries@suse.de>
3764
3765         PR cli/24587
3766         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3767
3768 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3769
3770         PR gdb/18644:
3771         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3772         16-byte floats.
3773         * i386-tdep.c (i386_floatformat_for_type): Use
3774         floatformats_ia64_quad for the 16-byte floating point component
3775         within a fortran 32-byte complex number.
3776
3777 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3778
3779         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3780         delete default constructor.
3781         (find_partial_die): Update to return const struct.
3782         (partial_die_parent_scope): Move variable declaration into scope
3783         of its use and change its type to auto.
3784         (guess_partial_die_structure_name): Likewise.
3785         (partial_die_info::fixup): Likewise.
3786
3787 2019-05-17  Tom Tromey  <tromey@adacore.com>
3788
3789         * source.c (find_and_open_source): Remove cast.
3790
3791 2019-05-17  Tom Tromey  <tromey@adacore.com>
3792
3793         * annotate.c (annotate_source): Make "filename" const.
3794         * annotate.h (annotate_source): Use const.
3795
3796 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3797
3798         * disasm.c (set_disassembler_options): Send errors to stderr.
3799
3800 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3801
3802         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3803         (cli_interp_base::set_logging): Check debug_redirect.
3804         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3805         * cli/cli-logging.c (debug_redirect): Add static variable.
3806         (pop_output_files): Add default param.
3807         (handle_redirections): Print debug setting.
3808         (show_logging_command): Likewise.
3809         (_initialize_cli_logging): Add debugredirect command.
3810         * interps.c (current_interp_set_logging): Add debug_redirect
3811         parameter.
3812         * interps.h (set_logging): Add debug_redirect parameter.
3813         (current_interp_set_logging): Likewise.
3814         * mi/mi-common.h: Likewise.
3815         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3816
3817 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3818             Tom Tromey  <tromey@adacore.com>
3819
3820         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3821         directly.
3822         * cli/cli-interp.h (make_logging_output): Remove declaration.
3823         * cli/cli-logging.c (make_logging_output): Remove function.
3824         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3825         directly.
3826         * ui-file.c (tee_file::tee_file): Remove bools.
3827         (tee_file::~tee_file): Remove deletes.
3828         * ui-file.h (tee_file): Remove bools.
3829
3830 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3831
3832         * mi/mi-cmds.h (mi_cmd_complete): New function.
3833         * mi/mi-main.c (mi_cmd_complete): Likewise.
3834         * mi/mi-cmds.c: Define new MI command -complete.
3835         * NEWS: Mention new -complete command.
3836
3837 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3838
3839         * completer.h (complete): New function.
3840         * completer.c (complete): Likewise.
3841         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3842         function defined in completer.h.
3843
3844 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3845
3846         * MAINTAINERS (Write After Approval): Add myself.
3847
3848 2019-05-17  Tom de Vries  <tdevries@suse.de>
3849
3850         PR gdb/24094
3851         * dwarf2read.c (struct cu_partial_die_info): New struct.
3852         (find_partial_die): Return cu_partial_die_info.
3853         (partial_die_parent_scope, guess_partial_die_structure_name)
3854         (partial_die_info::fixup): Handle new return type of find_partial_die.
3855
3856 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3857
3858         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3859         "std::string", simplifying the algorithm.
3860
3861 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3862
3863         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3864         (stap_static_probe_ops::get_probes): Likewise.
3865
3866 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3867
3868         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3869         '-')" and "else if".
3870         (stap_parse_single_operand): Join checks for
3871         "gdbarch_stap_parse_special_token_p" and
3872         "gdbarch_stap_parse_special_token" in the same "if" statement.
3873         Invert check when verifying for operation on register
3874         displacement.
3875
3876 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3877
3878         * stap-probe.c (stap_get_opcode): Update comment.
3879         (stap_get_expected_argument_type): Likewise.
3880         (handle_stap_probe): Likewise.
3881
3882 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3883
3884         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3885         return type to 'bool'.  Adjust comment.  Use 'bool' when
3886         appropriate.
3887         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3888         * stap-probe.c (stap_parse_argument_1): Likewise.
3889         (stap_is_operator): Likewise.
3890         (stap_is_generic_prefix): Likewise.
3891         (stap_is_register_prefix): Likewise.
3892         (stap_is_register_indirection_prefix): Likewise.
3893         (stap_is_integer_prefix): Likewise.
3894         (stap_generic_check_suffix): Likewise.
3895         (stap_check_integer_suffix): Likewise.
3896         (stap_check_register_suffix): Likewise.
3897         (stap_check_register_indirection_suffix): Likewise.
3898         (stap_parse_register_operand): Likewise.
3899         (stap_parse_single_operand): Likewise.
3900         (stap_parse_argument_1): Likewise.
3901         (stap_probe::get_argument_count): Likewise.
3902         (stap_is_operator): Likewise.
3903
3904 2019-05-16  Tom Tromey  <tromey@adacore.com>
3905
3906         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3907         keyword to foreach.
3908
3909 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3910
3911         * linux-thread-db.c (try_thread_db_load_1): Change return type
3912         to bool.
3913         (try_thread_db_load): Likewise.
3914         (try_thread_db_load_from_pdir_1): Likewise.
3915         (try_thread_db_load_from_pdir): Likewise.
3916         (try_thread_db_load_from_sdir): Likewise.
3917         (try_thread_db_load_from_dir): Likewise.
3918         (thread_db_load_search): Likewise.
3919         (has_libpthread): Likewise.
3920         (thread_db_load): Likewise.
3921
3922 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3923
3924         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3925         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3926         NULL, and complain/return if that's the case.
3927
3928 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3929
3930         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3931         (advance, posn, abstract_read_memory): New functions.
3932         [struct mem_read_abstraction]: New struct.
3933         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3934
3935 2019-05-14  Tom Tromey  <tromey@adacore.com>
3936
3937         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3938         value is not lval_memory.
3939
3940 2019-05-14  Tom Tromey  <tromey@adacore.com>
3941
3942         * solib.c (info_sharedlibrary_command): Style the file name.
3943
3944 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3945
3946         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3947         (aarch64_vnv_type): Likewise.
3948         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3949         * common/tdesc.c: Likewise.
3950         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3951         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3952         * features/aarch64-fpu.xml: Add ieee half view.
3953         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3954         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3955         * gdbtypes.h (struct builtin_type): Likewise.
3956         (struct objfile_type): Likewise.
3957
3958 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3959
3960         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3961         typo.
3962         * location.h (string_to_event_location): Likewise.
3963
3964 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3965
3966         GDB 8.3 released.
3967
3968 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3969
3970         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3971         New variable declaration.
3972         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3973         New variable.
3974         (print_one_breakpoint): Use ui_out::test_flags and new global
3975         variable to compute use_fixed_output.
3976         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3977         Remove.
3978         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3979         (mi_multi_location_breakpoint_output_fixed): Remove.
3980         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3981         new variable.
3982         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3983         fix_multi_location_breakpoint_output flag if version >= 3.
3984         * ui-out.h (enum ui_out_flag)
3985         <fix_multi_location_breakpoint_output>: New enumerator.
3986
3987 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3988
3989         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3990
3991 2019-05-10  Tom Tromey  <tromey@adacore.com>
3992
3993         * ada-lang.c (catch_ada_completer): New function.
3994         (_initialize_ada_language): Use it.
3995
3996 2019-05-10  Tom Tromey  <tromey@adacore.com>
3997
3998         * thread.c (print_thread_info): Make "requested_threads" const.
3999         * gdbthread.h (print_thread_info): Make "requested_threads"
4000         const.
4001         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
4002         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
4003
4004 2019-05-08  Tom Tromey  <tom@tromey.com>
4005
4006         * gdbtypes.c (objfile_type_data): Change type.
4007         (objfile_type, _initialize_gdbtypes): Update.
4008
4009 2019-05-08  Tom Tromey  <tom@tromey.com>
4010
4011         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
4012         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
4013         (_initialize_dwarf2_frame): Update.
4014
4015 2019-05-08  Tom Tromey  <tom@tromey.com>
4016
4017         * objc-lang.c (objc_objfile_data): Change type.
4018         (find_methods): Update.
4019         (_initialize_objc_lang): Remove.
4020
4021 2019-05-08  Tom Tromey  <tom@tromey.com>
4022
4023         * stabsread.c (rs6000_builtin_type_data): Change type.
4024         (rs6000_builtin_type, _initialize_stabsread): Update.
4025
4026 2019-05-08  Tom Tromey  <tom@tromey.com>
4027
4028         * mips-tdep.c (mips_pdr_data): Remove.
4029         (_initialize_mips_tdep): Update.
4030
4031 2019-05-08  Tom Tromey  <tom@tromey.com>
4032
4033         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
4034         (hppa_init_objfile_priv_data, read_unwind_info)
4035         (find_unwind_entry, _initialize_hppa_tdep): Update.
4036
4037 2019-05-08  Tom Tromey  <tom@tromey.com>
4038
4039         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
4040         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
4041         on obstack.
4042         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
4043
4044 2019-05-08  Tom Tromey  <tom@tromey.com>
4045
4046         * mdebugread.c (basic_type_data): Change type.
4047         (basic_type, _initialize_mdebugread): Update.
4048
4049 2019-05-08  Tom Tromey  <tom@tromey.com>
4050
4051         * common/gdb_unique_ptr.h (struct noop_deleter): New.
4052
4053 2019-05-08  Tom Tromey  <tom@tromey.com>
4054
4055         * nto-tdep.c (nto_inferior_data_reg): Change type.
4056         (nto_inferior_data): Update.
4057         (nto_inferior_data_cleanup, nto_new_inferior_data)
4058         (_initialize_nto_tdep): Remove.
4059         * nto-tdep.h (struct nto_inferior_data): Add initializers.
4060
4061 2019-05-08  Tom Tromey  <tom@tromey.com>
4062
4063         * ada-lang.c (struct ada_inferior_data): Add initializers.
4064         (ada_inferior_data): Change type.
4065         (ada_inferior_data_cleanup): Remove.
4066         (get_ada_inferior_data, ada_inferior_exit)
4067         (struct ada_pspace_data): Add initializers, destructor.
4068         (ada_pspace_data_handle): Change type.
4069         (get_ada_pspace_data): Update.
4070         (ada_pspace_data_cleanup): Remove.
4071
4072 2019-05-08  Tom Tromey  <tom@tromey.com>
4073
4074         * coffread.c (struct coff_symfile_info): Add initializers.
4075         (coff_objfile_data_key): Move lower.  Change type.
4076         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
4077         Update.
4078         (coff_free_info): Remove.
4079
4080 2019-05-08  Tom Tromey  <tom@tromey.com>
4081
4082         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
4083         (fbsd_pspace_data_handle): Move lower.  Change type.
4084         (get_fbsd_pspace_data): Update.
4085         (fbsd_pspace_data_cleanup): Remove.
4086         (_initialize_fbsd_tdep): Update.
4087
4088 2019-05-08  Tom Tromey  <tom@tromey.com>
4089
4090         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
4091         (get_ada_tasks_pspace_data): Update.
4092         (ada_tasks_pspace_data_cleanup): Remove.
4093         (_initialize_tasks): Update.
4094         (ada_tasks_inferior_data_handle): Change type.
4095         (get_ada_tasks_inferior_data): Update.
4096         (ada_tasks_inferior_data_cleanup): Remove.
4097         (struct ada_tasks_pspace_data): Add initializers.
4098
4099 2019-05-08  Tom Tromey  <tom@tromey.com>
4100
4101         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
4102         * symfile-debug.c (debug_sym_get_probes): Change type.
4103         * stap-probe.c (handle_stap_probe):
4104         (stap_static_probe_ops::get_probes): Change type.
4105         * probe.h (class static_probe_ops) <get_probes>: Change type.
4106         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
4107         (parse_probes_in_pspace): Update.
4108         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
4109         Update.
4110         (any_static_probe_ops::get_probes): Change type.
4111         * elfread.c (elfread_data): New typedef.
4112         (probe_key): Change type.
4113         (elf_get_probes): Likewise.  Update.
4114         (probe_key_free): Remove.
4115         (_initialize_elfread): Update.
4116         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
4117         Change type.
4118         (dtrace_process_dof_probe, dtrace_process_dof)
4119         (dtrace_static_probe_ops::get_probe): Change type.
4120
4121 2019-05-08  Tom Tromey  <tom@tromey.com>
4122
4123         * xcoffread.c (struct xcoff_symfile_info): Rename from
4124         coff_symfile_info.  Add initializers.
4125         (xcoff_objfile_data_key): Move lower.  Change type.
4126         (XCOFF_DATA): Rewrite.
4127         (xcoff_free_info): Remove.
4128         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
4129         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
4130         (xcoff_initial_scan): Update.
4131
4132 2019-05-08  Tom Tromey  <tom@tromey.com>
4133
4134         * solib-svr4.c (struct svr4_info): Add initializers and
4135         destructor.
4136         <probes_table>: Now an htab_up.
4137         (solib_svr4_pspace_data): Change type.
4138         (free_probes_table): Simplify.
4139         (~svr4_info): Rename from svr4_pspace_data_cleanup.
4140         (get_svr4_info, probes_table_htab_remove_objfile_probes)
4141         (probes_table_remove_objfile_probes, register_solib_event_probe)
4142         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
4143         (_initialize_svr4_solib): Update.
4144
4145 2019-05-08  Tom Tromey  <tom@tromey.com>
4146
4147         * remote.c (remote_pspace_data): Change type.
4148         (remote_pspace_data_cleanup): Remove.
4149         (get_remote_exec_file, set_pspace_remote_exec_file)
4150         (_initialize_remote): Update.
4151
4152 2019-05-08  Tom Tromey  <tom@tromey.com>
4153
4154         * breakpoint.c (breakpoint_objfile_key): Change type.
4155         (get_breakpoint_objfile_data): Update.
4156         (free_breakpoint_objfile_data): Remove.
4157         (_initialize_breakpoint): Update.
4158
4159 2019-05-08  Tom Tromey  <tom@tromey.com>
4160
4161         * linux-tdep.c (struct linux_info): Add initializers.
4162         (linux_inferior_data): Move.  Change type.
4163         (invalidate_linux_cache_inf): Update.
4164         (linux_inferior_data_cleanup): Remove.
4165         (get_linux_inferior_data, _initialize_linux_tdep): Update.
4166
4167 2019-05-08  Tom Tromey  <tom@tromey.com>
4168
4169         * auxv.c (auxv_inferior_data): Move.  Change type.
4170         (auxv_inferior_data_cleanup): Remove.
4171         (invalidate_auxv_cache_inf): Rewrite.
4172         (get_auxv_inferior_data, _initialize_auxv): Update.
4173
4174 2019-05-08  Tom Tromey  <tom@tromey.com>
4175
4176         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4177         (symfile_debug_objfile_data_key): Change type.
4178         (symfile_debug_installed, debug_qf_has_symbols)
4179         (debug_qf_find_last_source_symtab)
4180         (debug_qf_forget_cached_source_info)
4181         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4182         (debug_qf_print_stats, debug_qf_dump)
4183         (debug_qf_expand_symtabs_for_function)
4184         (debug_qf_expand_all_symtabs)
4185         (debug_qf_expand_symtabs_with_fullname)
4186         (debug_qf_map_matching_symbols)
4187         (debug_qf_expand_symtabs_matching)
4188         (debug_qf_find_pc_sect_compunit_symtab)
4189         (debug_qf_map_symbol_filenames)
4190         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4191         (debug_sym_new_init, debug_sym_init, debug_sym_read)
4192         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4193         (debug_sym_read_linetable, debug_sym_relocate): Update.
4194         (symfile_debug_free_objfile): Remove.
4195         (install_symfile_debug_logging, _initialize_symfile_debug):
4196         Update.
4197
4198 2019-05-08  Tom Tromey  <tom@tromey.com>
4199
4200         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4201         allocate_on_obstack.
4202         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4203         (get_dwarf2_per_objfile): Update.
4204         (set_dwarf2_per_objfile): Remove.
4205         (dwarf2_has_info, dwarf2_get_section_info): Update.
4206         (dwarf2_free_objfile): Remove.
4207         (_initialize_dwarf2_read): Update.
4208
4209 2019-05-08  Tom Tromey  <tom@tromey.com>
4210
4211         * auto-load.c (struct auto_load_pspace_info): Add destructor and
4212         initializers.
4213         <unsupported_script_warning_printed,
4214         script_not_found_warning_printed>: Now bool.
4215         (auto_load_pspace_data): Change type.
4216         (~auto_load_pspace_info): Rename from
4217         auto_load_pspace_data_cleanup.
4218         (get_auto_load_pspace_data, init_loaded_scripts_info)
4219         (clear_section_scripts, maybe_print_unsupported_script_warning)
4220         (maybe_print_script_not_found_warning, _initialize_auto_load):
4221         Update.
4222
4223 2019-05-08  Tom Tromey  <tom@tromey.com>
4224
4225         * objfiles.c (objfile_pspace_info): Add destructor and
4226         initializers.
4227         (objfiles_pspace_data): Change type.
4228         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4229         (get_objfile_pspace_data): Update.
4230         (objfiles_bfd_data): Change type.
4231         (get_objfile_bfd_data): Update.
4232         (objfile_bfd_data_free, _initialize_objfiles): Remove.
4233
4234 2019-05-08  Tom Tromey  <tom@tromey.com>
4235
4236         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4237         Change type.
4238         (get_catch_syscall_inferior_data): Update.
4239         (catch_syscall_inferior_data_cleanup): Remove.
4240         (_initialize_break_catch_syscall): Update.
4241
4242 2019-05-08  Tom Tromey  <tom@tromey.com>
4243
4244         * inflow.c (struct terminal_info): Add destructor and
4245         initializers.
4246         (inflow_inferior_data): Change type.
4247         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4248         (get_inflow_inferior_data, inflow_inferior_exit)
4249         (swap_terminal_info, _initialize_inflow): Update.
4250
4251 2019-05-08  Tom Tromey  <tom@tromey.com>
4252
4253         * target-dcache.c (target_dcache_cleanup): Remove.
4254         (target_dcache_aspace_key): Change type.
4255         (target_dcache_init_p, target_dcache_invalidate)
4256         (target_dcache_get, target_dcache_get_or_init)
4257         (_initialize_target_dcache): Update.
4258         * dcache.h (struct dcache_deleter): New.
4259
4260 2019-05-08  Tom Tromey  <tom@tromey.com>
4261
4262         * symtab.c (struct symbol_cache): Add destructor and
4263         initializers.
4264         (symbol_cache_key): Move.  Change type.
4265         (make_symbol_cache, free_symbol_cache): Remove.
4266         (get_symbol_cache): Update.
4267         (symbol_cache_cleanup): Remove.
4268         (ALL_PSPACES, symbol_cache_flush)
4269         (maintenance_print_symbol_cache)
4270         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4271         Update.
4272
4273 2019-05-08  Tom Tromey  <tom@tromey.com>
4274
4275         * symtab.c (struct main_info): Add destructor and initializers.
4276         (main_progspace_key): Move.  Change type.
4277         (get_main_info): Update.
4278         (main_info_cleanup): Remove.
4279         (_initialize_symtab): Update.
4280
4281 2019-05-08  Tom Tromey  <tom@tromey.com>
4282
4283         * registry.h (DECLARE_REGISTRY): Define the _key class.
4284
4285 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4286
4287         * NEWS: Merge two 'New commands' sections.
4288
4289 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4290
4291         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4292         parameter and use Ada language definition instead.
4293         (ada_val_print_ptr): Remove unused language parameter.
4294         (ada_val_print_num): Remove language parameter and use Ada language
4295         definition instead.
4296         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4297         parameter.
4298         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4299         parameter and use Ada language definition instead.
4300         (ada_val_print_1): Update all ada_val_print_xxx calls.
4301         Remove language parameter.
4302         (ada_val_print): Update ada_val_print_1 call.
4303
4304 2019-05-08  Tom Tromey  <tromey@adacore.com>
4305
4306         * remote.c (remote_hw_watchpoint_limit)
4307         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4308         Now static.
4309
4310 2019-05-08  Tom Tromey  <tromey@adacore.com>
4311
4312         * maint.c (_initialize_maint_cmds): Move initialization code to
4313         remote.c.
4314         (watchdog, show_watchdog): Move to remote.c.
4315         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4316         "watchdog" static.
4317         (_initialize_remote): Move initialization code from maint.c.
4318         * defs.h (watchdog): Don't declare.
4319
4320 2019-05-08  Tom Tromey  <tromey@adacore.com>
4321
4322         * tui/tui-interp.c: Include main.h.
4323         * interps.c: Include main.h.
4324         * main.h (interpreter_p): Declare.
4325         * defs.h (interpreter_p): Don't declare.
4326
4327 2019-05-08  Tom Tromey  <tromey@adacore.com>
4328
4329         * dwarf2loc.c: Include dwarf2read.h.
4330         * defs.h (read_unsigned_leb128): Don't declare.
4331         * dwarf2read.h (read_unsigned_leb128): Declare.
4332
4333 2019-05-08  Tom Tromey  <tromey@adacore.com>
4334
4335         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4336         method.
4337
4338 2019-05-08  Tom Tromey  <tromey@adacore.com>
4339
4340         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4341         when no wrap column is set.
4342
4343 2019-05-08  Tom Tromey  <tromey@adacore.com>
4344
4345         * c-lang.c (c_get_string): Handle non-C-style arrays.
4346
4347 2019-05-08  Tom Tromey  <tromey@adacore.com>
4348
4349         * typeprint.c (print_offset_data::update): Print the bit offset,
4350         not the number of bits remaining.
4351
4352 2019-05-08  Tom Tromey  <tromey@adacore.com>
4353
4354         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4355         padding at end of comment.
4356
4357 2019-05-08  Tom Tromey  <tromey@adacore.com>
4358
4359         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4360         Compare main types.
4361
4362 2019-05-06  Tom Tromey  <tom@tromey.com>
4363
4364         * common/scoped_mmap.c: Include common-defs.h.
4365         * common/scoped_mmap.h: Don't include config.h.
4366
4367 2019-05-04  Tom Tromey  <tom@tromey.com>
4368
4369         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4370         (struct aarch64_call_info): Add initializers.
4371         <si>: Now a std::vector.
4372         (pass_on_stack, aarch64_push_dummy_call): Update.
4373
4374 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4375             Tom Tromey  <tom@tromey.com>
4376
4377         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4378         (ppc_threads): Now a std::vector.  Now static.
4379         (hwdebug_find_thread_points_by_tid)
4380         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4381         Update.
4382
4383 2019-05-04  Tom Tromey  <tom@tromey.com>
4384
4385         * arc-tdep.c (arc_tdesc_init): Return bool.
4386
4387 2019-05-04  Tom Tromey  <tom@tromey.com>
4388
4389         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4390         Use gdb_assert_not_reached.
4391
4392 2019-05-04  Tom Tromey  <tom@tromey.com>
4393
4394         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4395         "false".
4396
4397 2019-05-04  Tom Tromey  <tom@tromey.com>
4398
4399         * arc-tdep.c (arc_tdesc_init): Use bool.
4400
4401 2019-05-04  Tom Tromey  <tom@tromey.com>
4402
4403         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4404
4405 2019-05-04  Tom Tromey  <tom@tromey.com>
4406
4407         * cli/cli-cmds.c (valid_command_p): Return bool.
4408
4409 2019-05-04  Tom Tromey  <tom@tromey.com>
4410
4411         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4412         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4413
4414 2019-05-04  Raul Tambre  <raul@tambre.ee>
4415
4416         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4417         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4418         operator for comparison.
4419
4420 2019-05-04  Tom Tromey  <tom@tromey.com>
4421
4422         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4423         (lookup_partial_symbol, print_partial_symbols)
4424         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4425         (psymbol_compare): Update.
4426         (add_psymbol_to_bcache): Clear the entire psymbol.
4427         (maintenance_check_psymtabs): Update.
4428         * psympriv.h (struct partial_symbol): Don't derive from
4429         general_symbol_info.
4430         <obj_section, unrelocated_address, address,
4431         set_unrelocated_address>: Update.
4432         <ginfo>: New member.
4433         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4434         (debug_names::write_psymbols): Update.
4435
4436 2019-05-04  Tom de Vries  <tdevries@suse.de>
4437
4438         * contrib/cc-with-tweaks.sh: Support -n arg.
4439
4440 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4441
4442         * corelow.c (core_target::detach): Ensure frame cache and
4443         register caches are cleared.
4444         inferior.c (exit_inferior_1): Likewise.
4445
4446 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4447             Tom Tromey  <tom@tromey.com>
4448
4449         * dictionary.c (collate_pending_symbols_by_language): Remove
4450         "struct" from foreach.
4451         * symtab.c (lookup_global_symbol_from_objfile)
4452         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4453         foreach.
4454         * ser-tcp.c (net_open): Remove "struct" from foreach.
4455         * objfiles.c (objfile_relocate, objfile_rebase)
4456         (objfile_has_symbols): Remove "struct" from foreach.
4457         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4458         from foreach.
4459         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4460         foreach.
4461         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4462         "struct" from foreach.
4463         * ada-lang.c (create_excep_cond_exprs)
4464         (ada_exception_catchpoint_cond_string): Remove "struct" from
4465         foreach.
4466
4467 2019-05-03  Tom Tromey  <tromey@adacore.com>
4468
4469         * ada-exp.y (convert_char_literal): Check suffix of each
4470         enumerator.
4471
4472 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4473
4474         PR ada/21406:
4475         * ada-exp.y (yywrap): Don't define.
4476         * ada-lex.l (%option): Add noyywrap
4477         (yywrap): Remove.
4478
4479 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4480
4481         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4482         _WIN32_WINNT to the XP level, unless already defined to a higher
4483         level.
4484
4485         * unittests/parse-connection-spec-selftests.c:
4486         * ser-tcp.c:
4487         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4488         override.
4489
4490         * symfile.c (find_separate_debug_file): Remove colon from the
4491         drive spec of DOS/Windows file names of the target, so that the
4492         file name produced from DEBUGDIR and the target's directory will
4493         be valid on DOS/Windows systems.
4494
4495 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4496
4497         * rust-lang.c (val_print_struct): Handle printing structures
4498         containing strings.
4499
4500 2019-05-02  Tom Tromey  <tromey@adacore.com>
4501
4502         * valarith.c (_initialize_valarith): Remove.
4503
4504 2019-05-01  Tom Tromey  <tromey@adacore.com>
4505
4506         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4507         bitfields.
4508
4509 2019-05-01  Tom Tromey  <tromey@adacore.com>
4510
4511         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4512         for big-endian copies.
4513
4514 2019-04-30  Ali Tamur  <tamur@google.com>
4515         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4516         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4517         (read_3_bytes): New function.
4518
4519 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4520
4521         * windows-nat.c (main_thread_id): Delete.
4522         (handle_output_debug_string): Replace main_thread_id by
4523         current_event.dwThreadId.
4524         (fake_create_process): Likewise.
4525         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4526         Do not set main_thread_id.
4527         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4528         current_event.dwThreadId.
4529         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4530
4531 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4532
4533         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4534         Use current_event.dwThreadId instead of main_thread_id.
4535
4536 2019-04-30  Tom Tromey  <tromey@adacore.com>
4537
4538         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4539         (create_excep_cond_exprs): Iterate over program spaces.
4540         (ada_exception_catchpoint_cond_string): Examine all minimal
4541         symbols for exception types.
4542
4543 2019-04-30  Tom Tromey  <tromey@adacore.com>
4544
4545         PR c++/24470:
4546         * dwarf2read.c (process_structure_scope): Handle case where type
4547         has template parameters but no symbol was created.
4548
4549 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4550             Chris January  <chris.january@arm.com>
4551
4552         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4553         qualifier.
4554         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4555
4556 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4557
4558         * f-typeprint.c (f_print_type): Update rules for printing
4559         whitespace.
4560         (f_type_print_varspec_suffix): Likewise.
4561
4562 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4563             Chris January  <chris.january@arm.com>
4564
4565         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4566         function arguments.
4567
4568 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4569
4570         * f-lang.c (build_fortran_types): Change name of void type to
4571         lower case.
4572         * f-typeprint.c (f_type_print_base): Print the name of the void
4573         type, rather than a fixed string.
4574         * f-valprint.c (f_decorations): Use lower case void string.
4575
4576 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4577             Chris January  <chris.january@arm.com>
4578
4579         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4580         types for Fortran.
4581
4582 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4583             Chris January  <chris.january@arm.com>
4584             David Lecomber  <david.lecomber@arm.com>
4585
4586         * f-exp.y (BINOP_INTRINSIC): New token.
4587         (exp): New parser rule handling BINOP_INTRINSIC.
4588         (f77_keywords): Add new builtin procedures.
4589         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4590         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4591         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4592         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4593         (print_unop_subexp_f): New function.
4594         (print_binop_subexp_f): New function.
4595         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4596         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4597         (dump_subexp_body_f): Likewise.
4598         (operator_check_f): Likewise.
4599         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4600         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4601
4602 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4603
4604         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4605         UNOP_KIND.
4606         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4607         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4608         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4609         (operator_length_f): New fuction.
4610         (print_subexp_f): New function.
4611         (op_name_f): New function.
4612         (dump_subexp_body_f): New function.
4613         (operator_check_f): New function.
4614         (exp_descriptor_f): Replace standard expression handling functions
4615         with new functions.
4616         * gdb/fortran-operator.def: New file.
4617         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4618         * gdb/std-operator.def: Remove UNOP_KIND.
4619
4620 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4621
4622         * std-operator.def: Remove unbalanced, stray double quote
4623         character.
4624
4625 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4626             Chris January  <chris.january@arm.com>
4627             Daniel Everett  <daniel.everett@arm.com>
4628             Nick Forrington  <nick.forrington@arm.com>
4629             Richard Bunt  <richard.bunt@arm.com>
4630
4631         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4632         of depth when printing anonymous structs or unions.
4633         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4634         Don't print either the top-level value, or the children if the
4635         max-depth is exceeded.
4636         (ppscm_print_children): When printing the key of a map, allow one
4637         extra level of depth.
4638         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4639         print either the top-level value, or the children if the max-depth
4640         is exceeded.
4641         (print_children): When printing the key of a map, allow one extra
4642         level of depth.
4643         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4644         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4645         (user_print_options): Initialise max_depth field.
4646         (val_print_scalar_or_string_type_p): New function.
4647         (val_print): Check to see if the max depth has been reached.
4648         (val_print_check_max_depth): Define new function.
4649         (show_print_max_depth): New function.
4650         (_initialize_valprint): Add 'print max-depth' option.
4651         * valprint.h (struct value_print_options) <max_depth>: New field.
4652         (val_print_check_max_depth): Declare new function.
4653         * NEWS: Document new feature.
4654
4655 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4656
4657         * ada-lang.c (ada_language_defn): Initialise new field.
4658         * c-lang.c (c_is_string_type_p): New function.
4659         (c_language_defn): Initialise new field.
4660         (cplus_language_defn): Initialise new field.
4661         (asm_language_defn): Initialise new field.
4662         (minimal_language_defn): Initialise new field.
4663         * c-lang.h (c_is_string_type_p): Declare new function.
4664         * d-lang.c (d_language_defn): Initialise new field.
4665         * f-lang.c (f_is_string_type_p): New function.
4666         (f_language_defn): Initialise new field.
4667         * go-lang.c (go_is_string_type_p): New function.
4668         (go_language_defn): Initialise new field.
4669         * language.c (default_is_string_type_p): New function.
4670         (unknown_language_defn): Initialise new field.
4671         (auto_language_defn): Initialise new field.
4672         * language.h (struct language_defn) <la_is_string_type_p>: New
4673         member variable.
4674         (default_is_string_type_p): Declare new function.
4675         * m2-lang.c (m2_language_defn): Initialise new field.
4676         * objc-lang.c (objc_language_defn): Initialise new field.
4677         * opencl-lang.c (opencl_language_defn): Initialise new field.
4678         * p-lang.c (pascal_is_string_type_p): New function.
4679         (pascal_language_defn): Initialise new field.
4680         * rust-lang.c (rust_is_string_type_p): New function.
4681         (rust_language_defn): Initialise new field.
4682
4683 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4684
4685         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4686         New field.
4687         * ada-lang.c (ada_language_defn): Initialise new field.
4688         * c-lang.c (c_language_defn): Likewise.
4689         (cplus_language_defn): Likewise.
4690         (asm_language_defn): Likewise.
4691         (minimal_language_defn): Likewise.
4692         * d-lang.c (d_language_defn): Likewise.
4693         * f-lang.c (f_language_defn): Likewise.
4694         * go-lang.c (go_language_defn): Likewise.
4695         * language.c (unknown_language_defn): Likewise.
4696         (auto_language_defn): Likewise.
4697         * m2-lang.c (m2_language_defn): Likewise.
4698         * objc-lang.c (objc_language_defn): Likewise.
4699         * opencl-lang.c (opencl_language_defn): Likewise.
4700         * p-lang.c (pascal_language_defn): Likewise.
4701         * rust-lang.c (rust_language_defn): Likewise.
4702
4703 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4704
4705         * ada-lang.c (ada_is_character_type): Change return type to bool.
4706         (ada_is_string_type): Likewise.
4707         * ada-lang.h (ada_is_character_type): Update declaration
4708         (ada_is_string_type): Likewise.
4709
4710 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4711
4712         Support style in 'frame|thread apply'
4713
4714         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4715         * record.c (record_start, record_stop): Update callers of
4716         execute_command_to_string with false.
4717         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4718         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4719         methods.
4720         (class string_file): New constructor with term_out parameter.
4721         Override methods term_out and can_emit_style_escape.  New member
4722         term_out.
4723         (class stdio_file): Override can_emit_style_escape.
4724         (class tee_file): Override term_out and can_emit_style_escape.
4725         * utils.h (can_emit_style_escape): Remove.
4726         * utils.c (can_emit_style_escape): Likewise.
4727         Update all callers of can_emit_style_escape (SOMESTREAM) to
4728         SOMESTREAM->can_emit_style_escape.
4729         * source-cache.c (source_cache::get_source_lines): Likewise.
4730         * stack.c (frame_apply_command_count): Call execute_command_to_string
4731         passing the term_out characteristic of the current gdb_stdout.
4732         * thread.c (thr_try_catch_cmd): Likewise.
4733         * top.c (execute_command_to_string): pass term_out parameter
4734         to construct the string_file for the command output.
4735         * ui-file.c (term_cli_styling): New function (most code moved
4736         from utils.c can_emit_style_escape).
4737         (string_file::string_file, string_file::can_emit_style_escape,
4738         stdio_file::can_emit_style_escape, tee_file::term_out,
4739         tee_file::can_emit_style_escape): New functions.
4740
4741 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4742
4743         * NEWS: Mention the new set|show may-call-functions.
4744         * infcall.c (may_call_functions_p): New variable.
4745         (show_may_call_functions_p): New function.
4746         (call_function_by_hand_dummy): Throws an error if not
4747         may-call-functions.
4748         (_initialize_infcall): Call add_setshow_boolean_cmd for
4749         may-call-functions.
4750
4751 2019-04-25  Keith Seitz  <keiths@redhat.com>
4752
4753         PR c++/24367
4754         * cp-support.c (inspect_type): Don't attempt substitutions
4755         of symbol with the same name.
4756
4757 2019-04-25  Tom Tromey  <tromey@adacore.com>
4758
4759         PR gdb/24475:
4760         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4761         static.
4762
4763 2019-04-25  Tom Tromey  <tromey@adacore.com>
4764
4765         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4766         rvalue reference.
4767         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4768         (gdb_xml_parser::parse): Use std::move.
4769         * python/python-internal.h (gdbpy_convert_exception): Take a const
4770         reference.
4771         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4772         std::move.
4773         * python/py-utils.c (gdbpy_convert_exception): Take a const
4774         reference.
4775         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4776         Use std::move.
4777         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4778         Use std::move.
4779         * mi/mi-main.c (mi_print_exception): Take a const reference.
4780         * main.c (handle_command_errors): Take a const reference.
4781         * linespec.c (parse_linespec): Use std::move.
4782         * infcall.c (run_inferior_call): Use std::move.
4783         (call_function_by_hand_dummy): Use std::move.
4784         * exec.c (try_open_exec_file): Use std::move.
4785         * exceptions.h (exception_print, exception_fprintf)
4786         (exception_print_same): Update.
4787         * exceptions.c (print_exception, exception_print)
4788         (exception_fprintf, exception_print_same): Change parameters to
4789         const reference.
4790         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4791         * common/new-op.c: Use std::move.
4792         * common/common-exceptions.h (struct gdb_exception): Add move
4793         constructor.
4794         (struct gdb_exception_error, struct gdb_exception_quit, struct
4795         gdb_quit_bad_alloc): Change constructor to move constructor.
4796         (throw_exception): Change parameter to rvalue reference.
4797         * common/common-exceptions.c (throw_exception): Take rvalue
4798         reference.
4799         * cli/cli-interp.c (safe_execute_command): Use std::move.
4800         * breakpoint.c (insert_bp_location, location_to_sals): Use
4801         std::move.
4802
4803 2019-04-25  Tom Tromey  <tromey@adacore.com>
4804
4805         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4806         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4807         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4808         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4809         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4810         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4811         guile/scm-value.c: Use unpack.
4812         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4813         gdbscm_gdb_exception.
4814         (gdbscm_throw_gdb_exception): Likewise.
4815         (struct gdbscm_gdb_exception): New.
4816         (unpack): New function.
4817         (gdbscm_wrap): Use unpack.
4818
4819 2019-04-25  Tom Tromey  <tromey@adacore.com>
4820
4821         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4822         (gdb_rl_callback_handler): Use std::move.
4823         * common/common-exceptions.h (struct gdb_exception): Add move
4824         assignment operator.
4825         (throw_exception_sjlj): Change "exception" to const reference.
4826         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4827         (throw_exception_sjlj): Change "exception" to const reference.
4828
4829 2019-04-25  Tom Tromey  <tromey@adacore.com>
4830
4831         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4832         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4833         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4834         Update.
4835         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4836         Update.
4837         * mi/mi-interp.c (mi_interp::exec): Update.
4838         * linespec.c (parse_linespec): Update.
4839         * infcall.c (run_inferior_call): Update.
4840         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4841         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4842         (gdbscm_lookup_global_symbol): Update.
4843         * guile/scm-param.c (gdbscm_parameter_value): Update.
4844         * guile/scm-frame.c (gdbscm_frame_read_register)
4845         (gdbscm_frame_read_var): Update.
4846         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4847         * exec.c (try_open_exec_file): Update.
4848         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4849         (gdb_rl_callback_handler): Update.
4850         * common/common-exceptions.h (exception_none): Don't declare.
4851         * common/common-exceptions.c (exception_none): Don't define.
4852         (struct catcher) <exception>: Update.
4853         * cli/cli-interp.c (safe_execute_command): Update.
4854         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4855
4856 2019-04-25  Ali Tamur  <tamur@google.com>
4857
4858         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4859         (read_attribute_value): Likewise.
4860         (dwarf2_read_addr_index): Update comment.
4861         (read_str_index): Add DW_FORM_strx.
4862         (dwarf2_string_attr): Likewise.
4863         (dwarf2_const_value_attr): Likewise.
4864         (dump_die_shallow): Likewise.
4865         (dwarf2_fetch_constant_bytes): Likewise.
4866         (skip_form_bytes): Likewise.
4867         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4868
4869 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4870
4871         PR corefiles/11608
4872         PR corefiles/18187
4873         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4874         OFFSET.  Verify if current mapping contains an ELF header.
4875         (linux_find_memory_regions_full): Adjust call to
4876         dump_mapping_p.
4877
4878 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4879             Kang Li <kanglictf@gmail.com>
4880
4881         PR gdb/21600
4882
4883         * dwarf2-frame.c (read_initial_length): Be consistent about using
4884         unsigned representation of length.
4885         (decode_frame_entry_1): Likewise.  Check for wraparound of
4886         end pointer as well as buffer overflow.
4887
4888 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4889
4890         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4891         "vq".
4892
4893 2019-04-24  Tom Tromey  <tromey@adacore.com>
4894
4895         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4896
4897 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4898
4899         * s12z-tdep.c (s12z_unwind_pc): Delete.
4900         (s12z_unwind_sp): Delete.
4901         (s12z_gdbarch_init): Don't register deleted functions with
4902         gdbarch.
4903
4904 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4905
4906         * rl78-tdep.c (rl78_unwind_sp): Delete.
4907         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4908
4909 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4910
4911         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4912         (xstormy16_unwind_pc): Delete.
4913         (xstormy16_dummy_id): Delete.
4914         (xstormy16_gdbarch_init): Don't register deleted functions with
4915         gdbarch.
4916
4917 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4918
4919         * vax-tdep.c (vax_unwind_pc): Delete.
4920         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4921
4922 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4923
4924         * v850-tdep.c (v850_unwind_sp): Delete.
4925         (v850_unwind_pc): Delete.
4926         (v850_dummy_id): Delete.
4927         (v850_gdbarch_init): Don't register deleted functions with
4928         gdbarch.
4929
4930 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4931
4932         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4933         (tilegx_unwind_pc): Delete.
4934         (tilegx_unwind_dummy_id): Delete.
4935         (tilegx_gdbarch_init): Don't register deleted functions with
4936         gdbarch.
4937
4938 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4939
4940         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4941         (tic6x_dummy_id): Delete.
4942         (tic6x_gdbarch_init): Don't register deleted functions with
4943         gdbarch.
4944
4945 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4946
4947         * sparc-tdep.c (sparc_unwind_pc): Delete.
4948         (sparc32_gdbarch_init): Don't register deleted function with
4949         gdbarch.
4950
4951 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4952
4953         * sh-tdep.c (sh_unwind_sp): Delete.
4954         (sh_unwind_pc): Delete.
4955         (sh_dummy_id): Delete.
4956         (sh_gdbarch_init): Don't register deleted functions with
4957         gdbarch.
4958
4959 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4960
4961         * score-tdep.c (score_unwind_sp): Delete.
4962         (score_unwind_pc): Delete.
4963         (score_dummy_id): Delete.
4964         (score_gdbarch_init): Don't register deleted functions with
4965         gdbarch.
4966
4967 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4968
4969         * rx-tdep.c (rx_unwind_pc): Delete.
4970         (rx_unwind_sp): Delete.
4971         (rx_dummy_id): Delete.
4972         (rx_gdbarch_init): Don't register deleted functions with
4973         gdbarch.  Update comment.
4974
4975 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4976
4977         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4978         (rs6000_dummy_id): Delete.
4979         (rs6000_gdbarch_init): Don't register deleted functions with
4980         gdbarch.
4981
4982 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4983
4984         * or1k-tdep.c (or1k_dummy_id): Delete.
4985         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4986
4987 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4988
4989         * nios2-tdep.c (nios2_dummy_id): Delete.
4990         (nios2_unwind_sp): Delete.
4991         (nios2_gdbarch_init): Don't register deleted functions with
4992         gdbarch.
4993
4994 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4995
4996         * nds32-tdep.c (nds32_dummy_id): Delete.
4997         (nds32_unwind_pc): Delete.
4998         (nds32_unwind_sp): Delete.
4999         (nds32_gdbarch_init): Don't register deleted functions with
5000         gdbarch.
5001
5002 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5003
5004         * msp430-tdep.c (msp430_unwind_pc): Delete.
5005         (msp430_unwind_sp): Delete.
5006         (msp430_dummy_id): Delete.
5007         (msp430_gdbarch_init): Don't register deleted functions with
5008         gdbarch.
5009
5010 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5011
5012         * moxie-tdep.c (moxie_unwind_sp): Delete.
5013         (moxie_unwind_pc): Delete.
5014         (moxie_dummy_id): Delete.
5015         (moxie_gdbarch_init): Don't register deleted functions with
5016         gdbarch.
5017
5018 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5019
5020         * mn10300-tdep.c (mn10300_dummy_id): Delete.
5021         (mn10300_unwind_pc): Delete.
5022         (mn10300_unwind_sp): Delete.
5023         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
5024         mn10300_unwind_sp.
5025         (mn10300_frame_unwind_init): Don't register deleted functions with
5026         gdbarch.
5027
5028 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5029
5030         * mep-tdep.c (mep_unwind_pc): Delete.
5031         (mep_unwind_sp): Delete.
5032         (mep_dummy_id): Delete.
5033         (mep_gdbarch_init): Don't register deleted functions with
5034         gdbarch.
5035
5036 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5037
5038         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
5039         (m68hc11_unwind_sp): Delete.
5040         (m68hc11_gdbarch_init): Don't register deleted functions with
5041         gdbarch.
5042
5043 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5044
5045         * m32r-tdep.c (m32r_unwind_sp): Delete.
5046         (m32r_unwind_pc): Delete.
5047         (m32r_dummy_id): Delete.
5048         (m32r_gdbarch_init): Don't register deleted functions with
5049         gdbarch.
5050
5051 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5052
5053         * m32c-tdep.c (m32c_unwind_pc): Delete.
5054         (m32c_unwind_sp): Delete.
5055         (m32c_dummy_id): Delete.
5056         (m32c_gdbarch_init): Don't register deleted functions with
5057         gdbarch.
5058
5059 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5060
5061         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
5062         (lm32_unwind_pc): Delete.
5063         (lm32_dummy_id): Delete.
5064         (lm32_gdbarch_init): Don't register deleted functions with
5065         gdbarch.
5066
5067 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5068
5069         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
5070         (iq2000_unwind_pc): Delete.
5071         (iq2000_dummy_id): Delete.
5072         (iq2000_gdbarch_init): Don't register deleted functions with
5073         gdbarch.
5074
5075 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5076
5077         * nds32-tdep.c (nds32_type_align): Delete.
5078         (nds32_push_dummy_call): Use type_align instead.
5079
5080 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5081
5082         * arm-tdep.c (arm_type_align): Only handle vector override case.
5083         (arm_push_dummy_call): Use type_align.
5084         (arm_gdbarch_init): Register arm_type_align gdbarch function.
5085
5086 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5087
5088         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
5089         case.
5090         (pass_on_stack): Use type_align.
5091         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
5092         function.
5093
5094 2019-04-23  Tom Tromey  <tromey@adacore.com>
5095
5096         * dwarf2read.c (line_header::file_name_at): Remove unused
5097         overload.
5098
5099 2019-04-23  Tom de Vries  <tdevries@suse.de>
5100
5101         PR gdb/24438
5102         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
5103         invocation.
5104
5105
5106 2019-03-27  Ali Tamur  <tamur@google.com>
5107
5108         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
5109         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
5110         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
5111         (dwarf_expr_context::get_addr_index): Likewise
5112         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
5113         (symbol_needs_eval_context::get_addr_index): Likewise
5114         (disassemble_dwarf_expression): Add DW_OP_addrx
5115         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
5116         (read_cutu_die_from_dwo): Update comment
5117         (skip_one_die): Add DW_FORM_addrx
5118         (read_attribute_value): Likewise
5119         (var_decode_location): Add DW_OP_addrx
5120         (dwarf2_const_value_attr): Add DW_FORM_addrx
5121         (dump_die_shallow): Likewise
5122         (dwarf2_fetch_constant_bytes): Likewise
5123         (decode_locdesc): Add DW_OP_addrx
5124         (skip_form_bytes): Add DW_FORM_addrx
5125
5126 2019-04-22  Ali Tamur  <tamur@google.com>
5127
5128         * MAINTAINERS (Write After Approval): Add self.
5129
5130 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
5131
5132         * solib-svr4.c (get_svr4_info): Add pspace parameter.
5133         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
5134         (open_symbol_file_object): Likewise.
5135         (svr4_default_sos): Add info parameter.
5136         (svr4_read_so_list): Likewise.
5137         (svr4_current_sos_direct): Adjust functions calls to pass down
5138         info.
5139         (svr4_current_sos_1): Add info parameter.
5140         (svr4_current_sos): Call get_svr4_info, pass info down to
5141         svr4_current_sos_1.
5142         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
5143         get_svr4_info.
5144         (svr4_in_dynsym_resolve_code): Pass current_program_space to
5145         get_svr4_info.
5146         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
5147         to get_svr4_info.
5148         (probes_table_remove_objfile_probes): Likewise.
5149         (register_solib_event_probe): Add info parameter.
5150         (solist_update_incremental): Pass info parameter down to
5151         svr4_read_so_list.
5152         (disable_probes_interface): Add info parameter.
5153         (svr4_handle_solib_event): Pass current_program_space to
5154         get_svr4_info.  Adjust disable_probes_interface cleanup.
5155         (svr4_create_probe_breakpoints): Add info parameter, pass it
5156         down to register_solib_event_probe.
5157         (svr4_create_solib_event_breakpoints): Add info parameter,
5158         pass it down to svr4_create_probe_breakpoints.
5159         (enable_break): Pass info down to
5160         svr4_create_solib_event_breakpoints.
5161         (svr4_solib_create_inferior_hook): Pass current_program_space to
5162         get_svr4_info.
5163         (svr4_clear_solib): Likewise.
5164
5165 2019-04-22  Pedro Alves  <palves@redhat.com>
5166
5167         * solib-svr4.c (svr4_free_objfile_observer): New.
5168         (probe_and_action::objfile): New field.
5169         (probes_table_htab_remove_objfile_probes)
5170         (probes_table_remove_objfile_probes): New functions.
5171         (register_solib_event_probe): Add 'objfile' parameter.  Store it
5172         in the new probe_and_action.  Don't store the probe in 'lookup'.
5173         (svr4_create_probe_breakpoints): Pass objfile to
5174         register_solib_event_probe.
5175         (_initialize_svr4_solib): Register a free_objfile observer.
5176
5177 2019-04-19  Tom Tromey  <tom@tromey.com>
5178
5179         * common/queue.h: Remove.
5180
5181 2019-04-19  Tom Tromey  <tom@tromey.com>
5182
5183         * event-loop.c: Don't include "common/queue.h".
5184
5185 2019-04-19  Tom Tromey  <tom@tromey.com>
5186
5187         * remote.c (remote_target): Use delete.
5188         * remote-notif.h: Include <list>, not "common/queue.h".
5189         (notif_client_p): Remove typedef.
5190         (remote_notif_state): Add constructor, destructor, initializer.
5191         <notif_queue>: Now a std::list.
5192         (remote_notif_state_xfree): Don't declare.
5193         * remote-notif.c (remote_notif_process, handle_notification)
5194         (remote_notif_state_allocate): Update.
5195         (~remote_notif_state): Rename from remote_notif_state_xfree.
5196
5197 2019-04-19  Tom Tromey  <tom@tromey.com>
5198
5199         * symfile.c (reread_symbols): Update.
5200         * objfiles.c (objfile_register_static_link)
5201         (objfile_lookup_static_link): Update
5202         (~objfile) Don't delete static_links.
5203         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5204
5205 2019-04-19  Tom Tromey  <tom@tromey.com>
5206
5207         * type-stack.h (struct type_stack) <insert>: Constify string.
5208         * type-stack.c (type_stack::insert): Constify string.
5209         * gdbtypes.h (lookup_template_type): Update.
5210         (address_space_name_to_int): Update.
5211         * gdbtypes.c (address_space_name_to_int): Make space_identifier
5212         const.
5213         (lookup_template_type): Make name const.
5214         * c-exp.y: Update rules.
5215         (lex_one_token, classify_name, classify_inner_name)
5216         (c_print_token): Update.
5217         * p-exp.y: Update rules.
5218         (yylex): Update.
5219         * f-exp.y: Update rules.
5220         (yylex): Update.
5221         * d-exp.y: Update rules.
5222         (lex_one_token, classify_name, classify_inner_name): Update.
5223         * parse.c (write_dollar_variable, copy_name): Return std::string.
5224         * parser-defs.h (copy_name): Change return type.
5225         * m2-exp.y: Update rules.
5226         (yylex): Update.
5227         * go-exp.y (lex_one_token): Update.
5228         Update rules.
5229         (classify_unsafe_function, classify_packaged_name)
5230         (classify_name, yylex): Update.
5231
5232 2019-04-19  Sergei Trofimovich <siarheit@google.com>
5233
5234         * configure.ac: add --enable-source-highlight switch.
5235         * configure: Regenerate.
5236         * top.c (print_gdb_version): plumb --enable-source-highlight
5237         status to "show configuration".
5238
5239 2019-04-19  Tom Tromey  <tromey@adacore.com>
5240
5241         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5242         Check ADA_TYPE_P.
5243         (empty_record, ada_template_to_fixed_record_type_1)
5244         (template_to_static_fixed_type)
5245         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5246         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5247         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5248         macros.
5249
5250 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5251
5252         PR symtab/24423:
5253         * source.c (print_source_lines_base): Advance "iter" when a
5254         control character is seen.
5255
5256 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5257
5258         * inferior.h (struct infcall_suspend_state_deleter):
5259         Catch exception in destructor to avoid crash.
5260
5261 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5262
5263         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5264         close to the add_com "shell".
5265
5266 2019-04-18  Tom Tromey  <tromey@adacore.com>
5267
5268         * process-stratum-target.h (class process_stratum_target)
5269         <stratum>: Add "final".
5270
5271 2019-04-17  Tom Tromey  <tromey@adacore.com>
5272
5273         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5274         against nullptr before use.
5275
5276 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5277
5278         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5279
5280 2019-04-17  Jim Wilson  <jimw@sifive.com>
5281             Andrew Burgess  <andrew.burgess@embecosm.com>
5282
5283         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5284         code read might fail, assume 4-byte breakpoint in that case.
5285
5286 2019-04-15  Leszek Swirski  <leszeks@google.com>
5287
5288         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5289         rather than a hand-rolled POD check when checking for forced MEMORY
5290         classification.
5291
5292 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5293
5294         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5295         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5296         function.
5297         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5298         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5299         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5300         declaration.
5301
5302 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5303
5304         * aarch64-linux-nat.c
5305         (aarch64_linux_nat_target::thread_architecture): Add override.
5306         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5307         each VQ.
5308
5309 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5310
5311         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5312
5313 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5314
5315         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5316         target types of size 96-bits, add some additional comments, and
5317         check that the builtin type we found was the correct size.
5318
5319 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5320
5321         * utils.c (prompt_for_continue): Don't restore the styling at the
5322         end, as applied_style has the wrong value.  This fixes styling in
5323         long lists of file names that are interrupted by the "Continue?"
5324         prompt.
5325
5326 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5327
5328         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5329         * c-lang.c (c_language_defn): Likewise.
5330         (cplus_language_defn): Likewise.
5331         (asm_language_defn): Likewise.
5332         (minimal_language_defn): Likewise.
5333         * d-lang.c (d_language_defn): Likewise.
5334         * f-lang.c (f_language_defn): Likewise.
5335         * go-lang.c (go_language_defn): Likewise.
5336         * language.c (unknown_language_defn): Likewise.
5337         (auto_language_defn): Likewise.
5338         * language.h (struct language_defn): Remove la_magic field.
5339         (LANG_MAGIC): Delete.
5340         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5341         * objc-lang.c (objc_language_defn): Likewise.
5342         * opencl-lang.c (opencl_language_defn): Likewise.
5343         * p-lang.c (pascal_language_defn): Likewise.
5344         * rust-lang.c (rust_language_defn): Likewise.
5345
5346 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5347
5348         * riscv-tdep.c (riscv_type_align): New function.
5349         (riscv_type_alignment): Delete.
5350         (riscv_arg_location): Use 'type_align'.
5351         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5352
5353 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5354
5355         * gdbtypes.c (type_align): A struct with no non-static fields also
5356         has alignment of 1.
5357
5358 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5359
5360         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5361         component to 0.
5362         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5363         member.
5364         (riscv_struct_info::analyse): New implementation using new
5365         analyse_inner member function.
5366         (riscv_struct_info::field_offset): New member function.
5367         (riscv_struct_info::m_offsets): New member variable.
5368         (riscv_struct_info::analyse_inner): New private member function,
5369         takes the old implementation of riscv_struct_info::analyse but
5370         extended to track field offsets.
5371         (riscv_call_arg_struct): Update the struct folding special cases
5372         to handle cases where empty C++ structs, which are non-zero
5373         length, are found.
5374         (riscv_arg_location): Initialise the length of each location, a
5375         non-zero length now indicates the location is in use.
5376         (riscv_push_dummy_call): Allow for the first location having a
5377         non-zero offset when setting up arguments.
5378         (riscv_return_value): Likewise, but for return values.
5379
5380 2019-04-11  Tom Tromey  <tromey@adacore.com>
5381
5382         * utils.c (internal_vproblem): Make "msg" const.
5383
5384 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5385
5386         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5387         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5388         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5389         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5390
5391 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5392
5393         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5394         function.
5395         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5396         of amd64_collect_native_gregset.
5397         (amd64_linux_nat_target::store_registers): Likewise.
5398
5399 2019-04-10  Tom Tromey  <tom@tromey.com>
5400
5401         * symtab.c (lookup_global_symbol_from_objfile)
5402         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5403         * objfiles.h (class separate_debug_iterator): New.
5404         (class separate_debug_range): New.
5405         (struct objfile) <separate_debug_objfiles>: New method.
5406         (objfile_separate_debug_iterate): Don't declare.
5407         * objfiles.c (separate_debug_iterator::operator++): Rename from
5408         objfile_separate_debug_iterate.
5409         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5410         iterator.
5411         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5412         iterator.
5413
5414 2019-04-10  Tom Tromey  <tom@tromey.com>
5415
5416         * symfile.c (reread_symbols): Remove old comment.
5417         * objfiles.c (free_all_objfiles): Fix a typo.
5418
5419 2019-04-10  Tom Tromey  <tom@tromey.com>
5420
5421         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5422         * minsyms.c (lookup_minimal_symbol): Use foreach.
5423         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5424         (lookup_minimal_symbol_solib_trampoline): Likewise.
5425         * symfile.c (reread_symbols): Use foreach.
5426
5427 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5428             Tom Tromey  <tromey@adacore.com>
5429
5430         PR rust/24414:
5431         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5432         (rust_lex_int_test): Change "value" to be LONGEST.
5433         (rust_lex_tests): Add test for long integer literal.
5434
5435 2019-04-09  Tom Tromey  <tromey@adacore.com>
5436
5437         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5438         to bool.
5439         (extended_remote_target::attach): Update.
5440         (remote_target::remote_notice_new_inferior): Update.
5441         (remote_target::add_current_inferior_and_thread): Update.
5442         * inferior.c (exit_inferior_1): Use "false".
5443         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5444
5445 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5446
5447         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5448         the "start" command.
5449
5450 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5451
5452         * python/py-inferior.c (infpy_thread_from_thread_handle):
5453         Adjust comments to reflect renaming of thread_from_thread_handle
5454         to thread_from_handle.  Adjust keywords.  Fix type error message.
5455         (inferior_object_methods): Add thread_from_handle.  Retain
5456         thread_from_thread_handle, but mark it as deprecated.
5457
5458 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5459
5460         * gdbthread.h (find_thread_by_handle): Revise declaration.
5461         * thread.c (find_thread_by_handle): Likewise.  Adjust
5462         implementation too.
5463         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5464         support for buffer objects as handles.
5465
5466 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5467
5468         * python/py-infthread.c (thpy_thread_handle): New function.
5469         (thread_object_methods): Register thpy_thread_handle.
5470
5471 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5472
5473         * gdbthread.h (thread_to_thread_handle): Declare.
5474         * thread.c (gdbtypes.h): Include.
5475         (thread_to_thread_handle): New function.
5476
5477         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5478         (target_thread_info_to_thread_handle): Declare.
5479         * target.c (target_thread_info_to_thread_handle): New function.
5480         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5481         * target-delegates.c: Regenerate.
5482
5483         * linux-thread-db.c (class thread_db_target): Add method
5484         thread_info_to_thread_handle.
5485         (thread_db_target::thread_info_to_thread_handle): Define.
5486         * remote.c (class remote_target): Add new method
5487         thread_info_to_thread_handle.
5488         (remote_target::thread_info_to_thread_handle): Define.
5489
5490 2019-04-08  Pedro Alves  <palves@redhat.com>
5491
5492         * common/common-exceptions.c (throw_exception): Don't create
5493         named object to throw; throw directly.
5494         (throw_it): Likewise.  Don't initialize gdb_exception::message
5495         here, with new; pass FMT and AP to the ctor instead.
5496         * common/common-exceptions.h: Include <string>.
5497         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5498         const char *, va_list)): New ctor.  Use std::make_shared.
5499         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5500         errors)): Delete.
5501         (gdb_exception_error::gdb_exception_error(enum errors, const char
5502         *, va_list)): New.
5503         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5504         Add assertion.
5505         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5506         errors)): Delete.
5507         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5508         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5509         Add assertion.
5510
5511 2019-04-08  Tom Tromey  <tom@tromey.com>
5512
5513         * valops.c (value_rtti_indirect_type): Replace throw_exception
5514         with throw.
5515         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5516         with throw.
5517         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5518         throw.
5519         * target.c (target_translate_tls_address): Replace throw_exception
5520         with throw.
5521         * stack.c (frame_apply_command_count): Replace throw_exception
5522         with throw.
5523         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5524         throw.
5525         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5526         with throw.
5527         * rs6000-tdep.c (rs6000_frame_cache)
5528         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5529         * remote.c: Replace throw_exception with throw.
5530         * record-full.c (record_full_message, record_full_wait_1)
5531         (record_full_restore): Replace throw_exception with throw.
5532         * record-btrace.c:
5533         (get_thread_current_frame_id, record_btrace_start_replaying)
5534         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5535         (cmd_record_btrace_start): Replace throw_exception with throw.
5536         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5537         throw.
5538         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5539         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5540         * linespec.c:
5541         (find_linespec_symbols): Replace throw_exception with throw.
5542         * infrun.c (displaced_step_prepare, resume): Replace
5543         throw_exception with throw.
5544         * infcmd.c (post_create_inferior): Replace throw_exception with
5545         throw.
5546         * inf-loop.c (inferior_event_handler): Replace throw_exception
5547         with throw.
5548         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5549         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5550         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5551         (get_prev_frame_always, get_frame_pc_if_available)
5552         (get_frame_address_in_block_if_available, get_frame_language):
5553         Replace throw_exception with throw.
5554         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5555         throw_exception with throw.
5556         * eval.c (fetch_subexp_value, evaluate_var_value)
5557         (evaluate_funcall, evaluate_subexp_standard): Replace
5558         throw_exception with throw.
5559         * dwarf2loc.c (call_site_find_chain)
5560         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5561         Replace throw_exception with throw.
5562         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5563         with throw.
5564         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5565         throw.
5566         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5567         * completer.c (complete_line_internal): Replace throw_exception
5568         with throw.
5569         * compile/compile-object-run.c (compile_object_run): Replace
5570         throw_exception with throw.
5571         * cli/cli-script.c (process_next_line): Replace throw_exception
5572         with throw.
5573         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5574         (btrace_enable, btrace_maint_update_pt_packets): Replace
5575         throw_exception with throw.
5576         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5577         throw_exception with throw.
5578         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5579         throw_exception with throw.
5580         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5581         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5582         * aarch64-tdep.c (aarch64_make_prologue_cache)
5583         (aarch64_make_stub_cache): Replace throw_exception with throw.
5584
5585 2019-04-08  Tom Tromey  <tom@tromey.com>
5586
5587         * common/common-exceptions.c (throw_exception): Rename from
5588         throw_exception_cxx.  Remove old copy.  Make argument const.
5589         (throw_it): Create and throw exception objects directly.
5590         * common/common-exceptions.h (throw_exception): Make argument
5591         const.
5592         (struct gdb_exception_error): Add constructor.
5593         (struct gdb_exception_quit): Add constructor.
5594
5595 2019-04-08  Tom Tromey  <tom@tromey.com>
5596
5597         * common/common-exceptions.h (exception_rethrow): Don't declare.
5598         (TRY_SJLJ): Update comment.
5599         (TRY, CATCH, END_CATCH): Remove.
5600         * common/common-exceptions.c (exception_rethrow): Remove.
5601
5602 2019-04-08  Tom Tromey  <tom@tromey.com>
5603
5604         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5605         Remove.
5606         (gdb_exception_error): Rename from
5607         gdb_exception_RETURN_MASK_ERROR.
5608         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5609         (gdb_quit_bad_alloc): Update.
5610         * aarch64-tdep.c: Update.
5611         * ada-lang.c: Update.
5612         * ada-typeprint.c: Update.
5613         * ada-valprint.c: Update.
5614         * amd64-tdep.c: Update.
5615         * arch-utils.c: Update.
5616         * break-catch-throw.c: Update.
5617         * breakpoint.c: Update.
5618         * btrace.c: Update.
5619         * c-varobj.c: Update.
5620         * cli/cli-cmds.c: Update.
5621         * cli/cli-interp.c: Update.
5622         * cli/cli-script.c: Update.
5623         * common/common-exceptions.c: Update.
5624         * common/new-op.c: Update.
5625         * common/selftest.c: Update.
5626         * compile/compile-c-symbols.c: Update.
5627         * compile/compile-cplus-symbols.c: Update.
5628         * compile/compile-object-load.c: Update.
5629         * compile/compile-object-run.c: Update.
5630         * completer.c: Update.
5631         * corelow.c: Update.
5632         * cp-abi.c: Update.
5633         * cp-support.c: Update.
5634         * cp-valprint.c: Update.
5635         * darwin-nat.c: Update.
5636         * disasm-selftests.c: Update.
5637         * dtrace-probe.c: Update.
5638         * dwarf-index-cache.c: Update.
5639         * dwarf-index-write.c: Update.
5640         * dwarf2-frame-tailcall.c: Update.
5641         * dwarf2-frame.c: Update.
5642         * dwarf2loc.c: Update.
5643         * dwarf2read.c: Update.
5644         * eval.c: Update.
5645         * event-loop.c: Update.
5646         * event-top.c: Update.
5647         * exec.c: Update.
5648         * f-valprint.c: Update.
5649         * fbsd-tdep.c: Update.
5650         * frame-unwind.c: Update.
5651         * frame.c: Update.
5652         * gdbtypes.c: Update.
5653         * gnu-v3-abi.c: Update.
5654         * guile/guile-internal.h: Update.
5655         * guile/scm-block.c: Update.
5656         * guile/scm-breakpoint.c: Update.
5657         * guile/scm-cmd.c: Update.
5658         * guile/scm-disasm.c: Update.
5659         * guile/scm-frame.c: Update.
5660         * guile/scm-lazy-string.c: Update.
5661         * guile/scm-math.c: Update.
5662         * guile/scm-param.c: Update.
5663         * guile/scm-ports.c: Update.
5664         * guile/scm-pretty-print.c: Update.
5665         * guile/scm-symbol.c: Update.
5666         * guile/scm-symtab.c: Update.
5667         * guile/scm-type.c: Update.
5668         * guile/scm-value.c: Update.
5669         * i386-linux-tdep.c: Update.
5670         * i386-tdep.c: Update.
5671         * inf-loop.c: Update.
5672         * infcall.c: Update.
5673         * infcmd.c: Update.
5674         * infrun.c: Update.
5675         * jit.c: Update.
5676         * language.c: Update.
5677         * linespec.c: Update.
5678         * linux-fork.c: Update.
5679         * linux-nat.c: Update.
5680         * linux-tdep.c: Update.
5681         * linux-thread-db.c: Update.
5682         * main.c: Update.
5683         * mi/mi-cmd-break.c: Update.
5684         * mi/mi-cmd-stack.c: Update.
5685         * mi/mi-interp.c: Update.
5686         * mi/mi-main.c: Update.
5687         * objc-lang.c: Update.
5688         * p-valprint.c: Update.
5689         * parse.c: Update.
5690         * ppc-linux-tdep.c: Update.
5691         * printcmd.c: Update.
5692         * python/py-arch.c: Update.
5693         * python/py-breakpoint.c: Update.
5694         * python/py-cmd.c: Update.
5695         * python/py-finishbreakpoint.c: Update.
5696         * python/py-frame.c: Update.
5697         * python/py-framefilter.c: Update.
5698         * python/py-gdb-readline.c: Update.
5699         * python/py-inferior.c: Update.
5700         * python/py-infthread.c: Update.
5701         * python/py-lazy-string.c: Update.
5702         * python/py-linetable.c: Update.
5703         * python/py-objfile.c: Update.
5704         * python/py-param.c: Update.
5705         * python/py-prettyprint.c: Update.
5706         * python/py-progspace.c: Update.
5707         * python/py-record-btrace.c: Update.
5708         * python/py-record.c: Update.
5709         * python/py-symbol.c: Update.
5710         * python/py-type.c: Update.
5711         * python/py-unwind.c: Update.
5712         * python/py-utils.c: Update.
5713         * python/py-value.c: Update.
5714         * python/python.c: Update.
5715         * record-btrace.c: Update.
5716         * record-full.c: Update.
5717         * remote-fileio.c: Update.
5718         * remote.c: Update.
5719         * riscv-tdep.c: Update.
5720         * rs6000-aix-tdep.c: Update.
5721         * rs6000-tdep.c: Update.
5722         * rust-exp.y: Update.
5723         * rust-lang.c: Update.
5724         * s390-tdep.c: Update.
5725         * selftest-arch.c: Update.
5726         * solib-dsbt.c: Update.
5727         * solib-frv.c: Update.
5728         * solib-spu.c: Update.
5729         * solib-svr4.c: Update.
5730         * solib.c: Update.
5731         * sparc64-linux-tdep.c: Update.
5732         * stack.c: Update.
5733         * symfile-mem.c: Update.
5734         * symmisc.c: Update.
5735         * target.c: Update.
5736         * thread.c: Update.
5737         * top.c: Update.
5738         * tracefile-tfile.c: Update.
5739         * tui/tui.c: Update.
5740         * typeprint.c: Update.
5741         * unittests/cli-utils-selftests.c: Update.
5742         * unittests/parse-connection-spec-selftests.c: Update.
5743         * valops.c: Update.
5744         * valprint.c: Update.
5745         * value.c: Update.
5746         * varobj.c: Update.
5747         * windows-nat.c: Update.
5748         * x86-linux-nat.c: Update.
5749         * xml-support.c: Update.
5750
5751 2019-04-08  Tom Tromey  <tom@tromey.com>
5752
5753         * xml-support.c: Use C++ exception handling.
5754         * x86-linux-nat.c: Use C++ exception handling.
5755         * windows-nat.c: Use C++ exception handling.
5756         * varobj.c: Use C++ exception handling.
5757         * value.c: Use C++ exception handling.
5758         * valprint.c: Use C++ exception handling.
5759         * valops.c: Use C++ exception handling.
5760         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5761         handling.
5762         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5763         * typeprint.c: Use C++ exception handling.
5764         * tui/tui.c: Use C++ exception handling.
5765         * tracefile-tfile.c: Use C++ exception handling.
5766         * top.c: Use C++ exception handling.
5767         * thread.c: Use C++ exception handling.
5768         * target.c: Use C++ exception handling.
5769         * symmisc.c: Use C++ exception handling.
5770         * symfile-mem.c: Use C++ exception handling.
5771         * stack.c: Use C++ exception handling.
5772         * sparc64-linux-tdep.c: Use C++ exception handling.
5773         * solib.c: Use C++ exception handling.
5774         * solib-svr4.c: Use C++ exception handling.
5775         * solib-spu.c: Use C++ exception handling.
5776         * solib-frv.c: Use C++ exception handling.
5777         * solib-dsbt.c: Use C++ exception handling.
5778         * selftest-arch.c: Use C++ exception handling.
5779         * s390-tdep.c: Use C++ exception handling.
5780         * rust-lang.c: Use C++ exception handling.
5781         * rust-exp.y: Use C++ exception handling.
5782         * rs6000-tdep.c: Use C++ exception handling.
5783         * rs6000-aix-tdep.c: Use C++ exception handling.
5784         * riscv-tdep.c: Use C++ exception handling.
5785         * remote.c: Use C++ exception handling.
5786         * remote-fileio.c: Use C++ exception handling.
5787         * record-full.c: Use C++ exception handling.
5788         * record-btrace.c: Use C++ exception handling.
5789         * python/python.c: Use C++ exception handling.
5790         * python/py-value.c: Use C++ exception handling.
5791         * python/py-utils.c: Use C++ exception handling.
5792         * python/py-unwind.c: Use C++ exception handling.
5793         * python/py-type.c: Use C++ exception handling.
5794         * python/py-symbol.c: Use C++ exception handling.
5795         * python/py-record.c: Use C++ exception handling.
5796         * python/py-record-btrace.c: Use C++ exception handling.
5797         * python/py-progspace.c: Use C++ exception handling.
5798         * python/py-prettyprint.c: Use C++ exception handling.
5799         * python/py-param.c: Use C++ exception handling.
5800         * python/py-objfile.c: Use C++ exception handling.
5801         * python/py-linetable.c: Use C++ exception handling.
5802         * python/py-lazy-string.c: Use C++ exception handling.
5803         * python/py-infthread.c: Use C++ exception handling.
5804         * python/py-inferior.c: Use C++ exception handling.
5805         * python/py-gdb-readline.c: Use C++ exception handling.
5806         * python/py-framefilter.c: Use C++ exception handling.
5807         * python/py-frame.c: Use C++ exception handling.
5808         * python/py-finishbreakpoint.c: Use C++ exception handling.
5809         * python/py-cmd.c: Use C++ exception handling.
5810         * python/py-breakpoint.c: Use C++ exception handling.
5811         * python/py-arch.c: Use C++ exception handling.
5812         * printcmd.c: Use C++ exception handling.
5813         * ppc-linux-tdep.c: Use C++ exception handling.
5814         * parse.c: Use C++ exception handling.
5815         * p-valprint.c: Use C++ exception handling.
5816         * objc-lang.c: Use C++ exception handling.
5817         * mi/mi-main.c: Use C++ exception handling.
5818         * mi/mi-interp.c: Use C++ exception handling.
5819         * mi/mi-cmd-stack.c: Use C++ exception handling.
5820         * mi/mi-cmd-break.c: Use C++ exception handling.
5821         * main.c: Use C++ exception handling.
5822         * linux-thread-db.c: Use C++ exception handling.
5823         * linux-tdep.c: Use C++ exception handling.
5824         * linux-nat.c: Use C++ exception handling.
5825         * linux-fork.c: Use C++ exception handling.
5826         * linespec.c: Use C++ exception handling.
5827         * language.c: Use C++ exception handling.
5828         * jit.c: Use C++ exception handling.
5829         * infrun.c: Use C++ exception handling.
5830         * infcmd.c: Use C++ exception handling.
5831         * infcall.c: Use C++ exception handling.
5832         * inf-loop.c: Use C++ exception handling.
5833         * i386-tdep.c: Use C++ exception handling.
5834         * i386-linux-tdep.c: Use C++ exception handling.
5835         * guile/scm-value.c: Use C++ exception handling.
5836         * guile/scm-type.c: Use C++ exception handling.
5837         * guile/scm-symtab.c: Use C++ exception handling.
5838         * guile/scm-symbol.c: Use C++ exception handling.
5839         * guile/scm-pretty-print.c: Use C++ exception handling.
5840         * guile/scm-ports.c: Use C++ exception handling.
5841         * guile/scm-param.c: Use C++ exception handling.
5842         * guile/scm-math.c: Use C++ exception handling.
5843         * guile/scm-lazy-string.c: Use C++ exception handling.
5844         * guile/scm-frame.c: Use C++ exception handling.
5845         * guile/scm-disasm.c: Use C++ exception handling.
5846         * guile/scm-cmd.c: Use C++ exception handling.
5847         * guile/scm-breakpoint.c: Use C++ exception handling.
5848         * guile/scm-block.c: Use C++ exception handling.
5849         * guile/guile-internal.h: Use C++ exception handling.
5850         * gnu-v3-abi.c: Use C++ exception handling.
5851         * gdbtypes.c: Use C++ exception handling.
5852         * frame.c: Use C++ exception handling.
5853         * frame-unwind.c: Use C++ exception handling.
5854         * fbsd-tdep.c: Use C++ exception handling.
5855         * f-valprint.c: Use C++ exception handling.
5856         * exec.c: Use C++ exception handling.
5857         * event-top.c: Use C++ exception handling.
5858         * event-loop.c: Use C++ exception handling.
5859         * eval.c: Use C++ exception handling.
5860         * dwarf2read.c: Use C++ exception handling.
5861         * dwarf2loc.c: Use C++ exception handling.
5862         * dwarf2-frame.c: Use C++ exception handling.
5863         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5864         * dwarf-index-write.c: Use C++ exception handling.
5865         * dwarf-index-cache.c: Use C++ exception handling.
5866         * dtrace-probe.c: Use C++ exception handling.
5867         * disasm-selftests.c: Use C++ exception handling.
5868         * darwin-nat.c: Use C++ exception handling.
5869         * cp-valprint.c: Use C++ exception handling.
5870         * cp-support.c: Use C++ exception handling.
5871         * cp-abi.c: Use C++ exception handling.
5872         * corelow.c: Use C++ exception handling.
5873         * completer.c: Use C++ exception handling.
5874         * compile/compile-object-run.c: Use C++ exception handling.
5875         * compile/compile-object-load.c: Use C++ exception handling.
5876         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5877         * compile/compile-c-symbols.c: Use C++ exception handling.
5878         * common/selftest.c: Use C++ exception handling.
5879         * common/new-op.c: Use C++ exception handling.
5880         * cli/cli-script.c: Use C++ exception handling.
5881         * cli/cli-interp.c: Use C++ exception handling.
5882         * cli/cli-cmds.c: Use C++ exception handling.
5883         * c-varobj.c: Use C++ exception handling.
5884         * btrace.c: Use C++ exception handling.
5885         * breakpoint.c: Use C++ exception handling.
5886         * break-catch-throw.c: Use C++ exception handling.
5887         * arch-utils.c: Use C++ exception handling.
5888         * amd64-tdep.c: Use C++ exception handling.
5889         * ada-valprint.c: Use C++ exception handling.
5890         * ada-typeprint.c: Use C++ exception handling.
5891         * ada-lang.c: Use C++ exception handling.
5892         * aarch64-tdep.c: Use C++ exception handling.
5893
5894 2019-04-08  Tom Tromey  <tom@tromey.com>
5895
5896         * xml-support.c (gdb_xml_parser::parse): Update.
5897         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5898         * value.c (show_convenience): Update.
5899         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5900         (test_parse_flags_qcs): Update.
5901         * thread.c (thr_try_catch_cmd): Update.
5902         * target.c (target_translate_tls_address): Update.
5903         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5904         (info_frame_command_core, frame_apply_command_count): Update.
5905         * rust-exp.y (rust_lex_exception_test): Update.
5906         * riscv-tdep.c (riscv_print_one_register_info): Update.
5907         * remote.c (remote_target::enable_btrace): Update.
5908         * record-btrace.c (record_btrace_enable_warn): Update.
5909         * python/py-utils.c (gdbpy_convert_exception): Update.
5910         * printcmd.c (do_one_display, print_variable_and_value): Update.
5911         * mi/mi-main.c (mi_print_exception): Update.
5912         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5913         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5914         * linux-nat.c (linux_nat_target::attach): Update.
5915         * linux-fork.c (class scoped_switch_fork_info): Update.
5916         * infrun.c (displaced_step_prepare): Update.
5917         * infcall.c (call_function_by_hand_dummy): Update.
5918         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5919         * gnu-v3-abi.c (print_one_vtable): Update.
5920         * frame.c (get_prev_frame_always): Update.
5921         * f-valprint.c (info_common_command_for_block): Update.
5922         * exec.c (try_open_exec_file): Update.
5923         * exceptions.c (print_exception, exception_print)
5924         (exception_fprintf, exception_print_same): Update.
5925         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5926         * dwarf-index-cache.c (index_cache::store)
5927         (index_cache::lookup_gdb_index): Update.
5928         * darwin-nat.c (maybe_cache_shell): Update.
5929         * cp-valprint.c (cp_print_value_fields): Update.
5930         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5931         (gcc_cplus_symbol_address): Update.
5932         * compile/compile-c-symbols.c (gcc_convert_symbol)
5933         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5934         * common/selftest.c: Update.
5935         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5936         a std::string.
5937         (exception_try_scope_entry, exception_try_scope_exit): Don't
5938         declare.
5939         (struct exception_try_scope): Remove.
5940         (TRY): Don't use exception_try_scope.
5941         (struct gdb_exception): Add constructor, operator=.
5942         <what>: New method.
5943         (struct gdb_exception_RETURN_MASK_ALL)
5944         (struct gdb_exception_RETURN_MASK_ERROR)
5945         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5946         (struct gdb_quit_bad_alloc): Update.
5947         * common/common-exceptions.c (exception_none): Change
5948         initializer.
5949         (struct catcher) <state, exception>: Initialize inline.
5950         <prev>: Remove member.
5951         (current_catcher): Remove.
5952         (catchers): New global.
5953         (exceptions_state_mc_init): Simplify.
5954         (catcher_pop): Remove.
5955         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5956         (try_scope_depth, exception_try_scope_entry)
5957         (exception_try_scope_exit): Remove.
5958         (throw_exception_sjlj): Update.
5959         (exception_messages, exception_messages_size): Remove.
5960         (throw_it): Simplify.
5961         (gdb_exception_sliced_copy): Remove.
5962         (throw_exception_cxx): Update.
5963         * cli/cli-script.c (script_from_file): Update.
5964         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5965         Update.
5966         * ada-valprint.c (ada_val_print): Update.
5967         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5968         (create_excep_cond_exprs): Update.
5969
5970 2019-04-08  Tom Tromey  <tom@tromey.com>
5971
5972         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5973         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5974         (TRY, CATCH, END_CATCH): Remove some definitions.
5975         * common/common-exceptions.c: Don't use GDB_XCPT.
5976         (catcher_list_size): Remove.
5977         (throw_exception, throw_it): Simplify.
5978
5979 2019-04-05  Tom Tromey  <tom@tromey.com>
5980
5981         Revert the header-sorting patch.
5982         * ft32-tdep.c: Revert.
5983         * frv-tdep.c: Revert.
5984         * frv-linux-tdep.c: Revert.
5985         * frame.c: Revert.
5986         * frame-unwind.c: Revert.
5987         * frame-base.c: Revert.
5988         * fork-child.c: Revert.
5989         * findvar.c: Revert.
5990         * findcmd.c: Revert.
5991         * filesystem.c: Revert.
5992         * filename-seen-cache.h: Revert.
5993         * filename-seen-cache.c: Revert.
5994         * fbsd-tdep.c: Revert.
5995         * fbsd-nat.h: Revert.
5996         * fbsd-nat.c: Revert.
5997         * f-valprint.c: Revert.
5998         * f-typeprint.c: Revert.
5999         * f-lang.c: Revert.
6000         * extension.h: Revert.
6001         * extension.c: Revert.
6002         * extension-priv.h: Revert.
6003         * expprint.c: Revert.
6004         * exec.h: Revert.
6005         * exec.c: Revert.
6006         * exceptions.c: Revert.
6007         * event-top.c: Revert.
6008         * event-loop.c: Revert.
6009         * eval.c: Revert.
6010         * elfread.c: Revert.
6011         * dwarf2read.h: Revert.
6012         * dwarf2read.c: Revert.
6013         * dwarf2loc.c: Revert.
6014         * dwarf2expr.h: Revert.
6015         * dwarf2expr.c: Revert.
6016         * dwarf2-frame.c: Revert.
6017         * dwarf2-frame-tailcall.c: Revert.
6018         * dwarf-index-write.h: Revert.
6019         * dwarf-index-write.c: Revert.
6020         * dwarf-index-common.c: Revert.
6021         * dwarf-index-cache.h: Revert.
6022         * dwarf-index-cache.c: Revert.
6023         * dummy-frame.c: Revert.
6024         * dtrace-probe.c: Revert.
6025         * disasm.h: Revert.
6026         * disasm.c: Revert.
6027         * disasm-selftests.c: Revert.
6028         * dictionary.c: Revert.
6029         * dicos-tdep.c: Revert.
6030         * demangle.c: Revert.
6031         * dcache.h: Revert.
6032         * dcache.c: Revert.
6033         * darwin-nat.h: Revert.
6034         * darwin-nat.c: Revert.
6035         * darwin-nat-info.c: Revert.
6036         * d-valprint.c: Revert.
6037         * d-namespace.c: Revert.
6038         * d-lang.c: Revert.
6039         * ctf.c: Revert.
6040         * csky-tdep.c: Revert.
6041         * csky-linux-tdep.c: Revert.
6042         * cris-tdep.c: Revert.
6043         * cris-linux-tdep.c: Revert.
6044         * cp-valprint.c: Revert.
6045         * cp-support.c: Revert.
6046         * cp-namespace.c: Revert.
6047         * cp-abi.c: Revert.
6048         * corelow.c: Revert.
6049         * corefile.c: Revert.
6050         * continuations.c: Revert.
6051         * completer.h: Revert.
6052         * completer.c: Revert.
6053         * complaints.c: Revert.
6054         * coffread.c: Revert.
6055         * coff-pe-read.c: Revert.
6056         * cli-out.h: Revert.
6057         * cli-out.c: Revert.
6058         * charset.c: Revert.
6059         * c-varobj.c: Revert.
6060         * c-valprint.c: Revert.
6061         * c-typeprint.c: Revert.
6062         * c-lang.c: Revert.
6063         * buildsym.c: Revert.
6064         * buildsym-legacy.c: Revert.
6065         * build-id.h: Revert.
6066         * build-id.c: Revert.
6067         * btrace.c: Revert.
6068         * bsd-uthread.c: Revert.
6069         * breakpoint.h: Revert.
6070         * breakpoint.c: Revert.
6071         * break-catch-throw.c: Revert.
6072         * break-catch-syscall.c: Revert.
6073         * break-catch-sig.c: Revert.
6074         * blockframe.c: Revert.
6075         * block.c: Revert.
6076         * bfin-tdep.c: Revert.
6077         * bfin-linux-tdep.c: Revert.
6078         * bfd-target.c: Revert.
6079         * bcache.c: Revert.
6080         * ax-general.c: Revert.
6081         * ax-gdb.h: Revert.
6082         * ax-gdb.c: Revert.
6083         * avr-tdep.c: Revert.
6084         * auxv.c: Revert.
6085         * auto-load.c: Revert.
6086         * arm-wince-tdep.c: Revert.
6087         * arm-tdep.c: Revert.
6088         * arm-symbian-tdep.c: Revert.
6089         * arm-pikeos-tdep.c: Revert.
6090         * arm-obsd-tdep.c: Revert.
6091         * arm-nbsd-tdep.c: Revert.
6092         * arm-nbsd-nat.c: Revert.
6093         * arm-linux-tdep.c: Revert.
6094         * arm-linux-nat.c: Revert.
6095         * arm-fbsd-tdep.c: Revert.
6096         * arm-fbsd-nat.c: Revert.
6097         * arm-bsd-tdep.c: Revert.
6098         * arch-utils.c: Revert.
6099         * arc-tdep.c: Revert.
6100         * arc-newlib-tdep.c: Revert.
6101         * annotate.h: Revert.
6102         * annotate.c: Revert.
6103         * amd64-windows-tdep.c: Revert.
6104         * amd64-windows-nat.c: Revert.
6105         * amd64-tdep.c: Revert.
6106         * amd64-sol2-tdep.c: Revert.
6107         * amd64-obsd-tdep.c: Revert.
6108         * amd64-obsd-nat.c: Revert.
6109         * amd64-nbsd-tdep.c: Revert.
6110         * amd64-nbsd-nat.c: Revert.
6111         * amd64-nat.c: Revert.
6112         * amd64-linux-tdep.c: Revert.
6113         * amd64-linux-nat.c: Revert.
6114         * amd64-fbsd-tdep.c: Revert.
6115         * amd64-fbsd-nat.c: Revert.
6116         * amd64-dicos-tdep.c: Revert.
6117         * amd64-darwin-tdep.c: Revert.
6118         * amd64-bsd-nat.c: Revert.
6119         * alpha-tdep.c: Revert.
6120         * alpha-obsd-tdep.c: Revert.
6121         * alpha-nbsd-tdep.c: Revert.
6122         * alpha-mdebug-tdep.c: Revert.
6123         * alpha-linux-tdep.c: Revert.
6124         * alpha-linux-nat.c: Revert.
6125         * alpha-bsd-tdep.c: Revert.
6126         * alpha-bsd-nat.c: Revert.
6127         * aix-thread.c: Revert.
6128         * agent.c: Revert.
6129         * addrmap.c: Revert.
6130         * ada-varobj.c: Revert.
6131         * ada-valprint.c: Revert.
6132         * ada-typeprint.c: Revert.
6133         * ada-tasks.c: Revert.
6134         * ada-lang.c: Revert.
6135         * aarch64-tdep.c: Revert.
6136         * aarch64-ravenscar-thread.c: Revert.
6137         * aarch64-newlib-tdep.c: Revert.
6138         * aarch64-linux-tdep.c: Revert.
6139         * aarch64-linux-nat.c: Revert.
6140         * aarch64-fbsd-tdep.c: Revert.
6141         * aarch64-fbsd-nat.c: Revert.
6142         * aarch32-linux-nat.c: Revert.
6143
6144 2019-04-05  Tom Tromey  <tom@tromey.com>
6145
6146         * ft32-tdep.c: Sort headers.
6147         * frv-tdep.c: Sort headers.
6148         * frv-linux-tdep.c: Sort headers.
6149         * frame.c: Sort headers.
6150         * frame-unwind.c: Sort headers.
6151         * frame-base.c: Sort headers.
6152         * fork-child.c: Sort headers.
6153         * findvar.c: Sort headers.
6154         * findcmd.c: Sort headers.
6155         * filesystem.c: Sort headers.
6156         * filename-seen-cache.h: Sort headers.
6157         * filename-seen-cache.c: Sort headers.
6158         * fbsd-tdep.c: Sort headers.
6159         * fbsd-nat.h: Sort headers.
6160         * fbsd-nat.c: Sort headers.
6161         * f-valprint.c: Sort headers.
6162         * f-typeprint.c: Sort headers.
6163         * f-lang.c: Sort headers.
6164         * extension.h: Sort headers.
6165         * extension.c: Sort headers.
6166         * extension-priv.h: Sort headers.
6167         * expprint.c: Sort headers.
6168         * exec.h: Sort headers.
6169         * exec.c: Sort headers.
6170         * exceptions.c: Sort headers.
6171         * event-top.c: Sort headers.
6172         * event-loop.c: Sort headers.
6173         * eval.c: Sort headers.
6174         * elfread.c: Sort headers.
6175         * dwarf2read.h: Sort headers.
6176         * dwarf2read.c: Sort headers.
6177         * dwarf2loc.c: Sort headers.
6178         * dwarf2expr.h: Sort headers.
6179         * dwarf2expr.c: Sort headers.
6180         * dwarf2-frame.c: Sort headers.
6181         * dwarf2-frame-tailcall.c: Sort headers.
6182         * dwarf-index-write.h: Sort headers.
6183         * dwarf-index-write.c: Sort headers.
6184         * dwarf-index-common.c: Sort headers.
6185         * dwarf-index-cache.h: Sort headers.
6186         * dwarf-index-cache.c: Sort headers.
6187         * dummy-frame.c: Sort headers.
6188         * dtrace-probe.c: Sort headers.
6189         * disasm.h: Sort headers.
6190         * disasm.c: Sort headers.
6191         * disasm-selftests.c: Sort headers.
6192         * dictionary.c: Sort headers.
6193         * dicos-tdep.c: Sort headers.
6194         * demangle.c: Sort headers.
6195         * dcache.h: Sort headers.
6196         * dcache.c: Sort headers.
6197         * darwin-nat.h: Sort headers.
6198         * darwin-nat.c: Sort headers.
6199         * darwin-nat-info.c: Sort headers.
6200         * d-valprint.c: Sort headers.
6201         * d-namespace.c: Sort headers.
6202         * d-lang.c: Sort headers.
6203         * ctf.c: Sort headers.
6204         * csky-tdep.c: Sort headers.
6205         * csky-linux-tdep.c: Sort headers.
6206         * cris-tdep.c: Sort headers.
6207         * cris-linux-tdep.c: Sort headers.
6208         * cp-valprint.c: Sort headers.
6209         * cp-support.c: Sort headers.
6210         * cp-namespace.c: Sort headers.
6211         * cp-abi.c: Sort headers.
6212         * corelow.c: Sort headers.
6213         * corefile.c: Sort headers.
6214         * continuations.c: Sort headers.
6215         * completer.h: Sort headers.
6216         * completer.c: Sort headers.
6217         * complaints.c: Sort headers.
6218         * coffread.c: Sort headers.
6219         * coff-pe-read.c: Sort headers.
6220         * cli-out.h: Sort headers.
6221         * cli-out.c: Sort headers.
6222         * charset.c: Sort headers.
6223         * c-varobj.c: Sort headers.
6224         * c-valprint.c: Sort headers.
6225         * c-typeprint.c: Sort headers.
6226         * c-lang.c: Sort headers.
6227         * buildsym.c: Sort headers.
6228         * buildsym-legacy.c: Sort headers.
6229         * build-id.h: Sort headers.
6230         * build-id.c: Sort headers.
6231         * btrace.c: Sort headers.
6232         * bsd-uthread.c: Sort headers.
6233         * breakpoint.h: Sort headers.
6234         * breakpoint.c: Sort headers.
6235         * break-catch-throw.c: Sort headers.
6236         * break-catch-syscall.c: Sort headers.
6237         * break-catch-sig.c: Sort headers.
6238         * blockframe.c: Sort headers.
6239         * block.c: Sort headers.
6240         * bfin-tdep.c: Sort headers.
6241         * bfin-linux-tdep.c: Sort headers.
6242         * bfd-target.c: Sort headers.
6243         * bcache.c: Sort headers.
6244         * ax-general.c: Sort headers.
6245         * ax-gdb.h: Sort headers.
6246         * ax-gdb.c: Sort headers.
6247         * avr-tdep.c: Sort headers.
6248         * auxv.c: Sort headers.
6249         * auto-load.c: Sort headers.
6250         * arm-wince-tdep.c: Sort headers.
6251         * arm-tdep.c: Sort headers.
6252         * arm-symbian-tdep.c: Sort headers.
6253         * arm-pikeos-tdep.c: Sort headers.
6254         * arm-obsd-tdep.c: Sort headers.
6255         * arm-nbsd-tdep.c: Sort headers.
6256         * arm-nbsd-nat.c: Sort headers.
6257         * arm-linux-tdep.c: Sort headers.
6258         * arm-linux-nat.c: Sort headers.
6259         * arm-fbsd-tdep.c: Sort headers.
6260         * arm-fbsd-nat.c: Sort headers.
6261         * arm-bsd-tdep.c: Sort headers.
6262         * arch-utils.c: Sort headers.
6263         * arc-tdep.c: Sort headers.
6264         * arc-newlib-tdep.c: Sort headers.
6265         * annotate.h: Sort headers.
6266         * annotate.c: Sort headers.
6267         * amd64-windows-tdep.c: Sort headers.
6268         * amd64-windows-nat.c: Sort headers.
6269         * amd64-tdep.c: Sort headers.
6270         * amd64-sol2-tdep.c: Sort headers.
6271         * amd64-obsd-tdep.c: Sort headers.
6272         * amd64-obsd-nat.c: Sort headers.
6273         * amd64-nbsd-tdep.c: Sort headers.
6274         * amd64-nbsd-nat.c: Sort headers.
6275         * amd64-nat.c: Sort headers.
6276         * amd64-linux-tdep.c: Sort headers.
6277         * amd64-linux-nat.c: Sort headers.
6278         * amd64-fbsd-tdep.c: Sort headers.
6279         * amd64-fbsd-nat.c: Sort headers.
6280         * amd64-dicos-tdep.c: Sort headers.
6281         * amd64-darwin-tdep.c: Sort headers.
6282         * amd64-bsd-nat.c: Sort headers.
6283         * alpha-tdep.c: Sort headers.
6284         * alpha-obsd-tdep.c: Sort headers.
6285         * alpha-nbsd-tdep.c: Sort headers.
6286         * alpha-mdebug-tdep.c: Sort headers.
6287         * alpha-linux-tdep.c: Sort headers.
6288         * alpha-linux-nat.c: Sort headers.
6289         * alpha-bsd-tdep.c: Sort headers.
6290         * alpha-bsd-nat.c: Sort headers.
6291         * aix-thread.c: Sort headers.
6292         * agent.c: Sort headers.
6293         * addrmap.c: Sort headers.
6294         * ada-varobj.c: Sort headers.
6295         * ada-valprint.c: Sort headers.
6296         * ada-typeprint.c: Sort headers.
6297         * ada-tasks.c: Sort headers.
6298         * ada-lang.c: Sort headers.
6299         * aarch64-tdep.c: Sort headers.
6300         * aarch64-ravenscar-thread.c: Sort headers.
6301         * aarch64-newlib-tdep.c: Sort headers.
6302         * aarch64-linux-tdep.c: Sort headers.
6303         * aarch64-linux-nat.c: Sort headers.
6304         * aarch64-fbsd-tdep.c: Sort headers.
6305         * aarch64-fbsd-nat.c: Sort headers.
6306         * aarch32-linux-nat.c: Sort headers.
6307
6308 2019-04-04  Tom Tromey  <tom@tromey.com>
6309
6310         * varobj.c (varobj_create): Update.
6311         * rust-exp.y (struct rust_parser) <update_innermost_block,
6312         lookup_symbol>: New methods.
6313         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6314         Rename.
6315         (rust_parser::rust_lookup_type)
6316         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6317         * printcmd.c (display_command, do_one_display): Update.
6318         * parser-defs.h (struct parser_state) <parser_state>: Add
6319         "tracker" parameter.
6320         (block_tracker): New member.
6321         (class innermost_block_tracker) <innermost_block_tracker>: Add
6322         "types" parameter.
6323         <reset>: Remove method.
6324         (innermost_block): Don't declare.
6325         (null_post_parser): Update.
6326         * parse.c (innermost_block): Remove global.
6327         (write_dollar_variable): Update.
6328         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6329         Remove "tracker_types" parameter.
6330         (parse_expression): Add "tracker" parameter.
6331         (parse_expression_for_completion): Update.
6332         (null_post_parser): Add "tracker" parameter.
6333         * p-exp.y: Update rules.
6334         * m2-exp.y: Update rules.
6335         * language.h (struct language_defn) <la_post_parser>: Add
6336         "tracker" parameter.
6337         * go-exp.y: Update rules.
6338         * f-exp.y: Update rules.
6339         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6340         parameter.
6341         * d-exp.y: Update rules.
6342         * c-exp.y: Update rules.
6343         * breakpoint.c (set_breakpoint_condition): Create an
6344         innermost_block_tracker.
6345         (watch_command_1): Likewise.
6346         * ada-lang.c (resolve): Add "tracker" parameter.
6347         (resolve_subexp): Likewise.
6348         * ada-exp.y (write_var_from_sym): Update.
6349
6350 2019-04-04  Tom Tromey  <tom@tromey.com>
6351
6352         * type-stack.h: New file.
6353         * type-stack.c: New file.
6354         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6355         type-stack.h.
6356         (insert_into_type_stack, insert_type, push_type, push_type_int)
6357         (insert_type_address_space, pop_type, pop_type_int)
6358         (pop_typelist, pop_type_stack, append_type_stack)
6359         (push_type_stack, get_type_stack, push_typelist)
6360         (follow_type_instance_flags, follow_types): Don't declare.
6361         * parse.c (type_stack): Remove global.
6362         (parse_exp_in_context): Update.
6363         (insert_into_type_stack, insert_type, push_type, push_type_int)
6364         (insert_type_address_space, pop_type, pop_type_int)
6365         (pop_typelist, pop_type_stack, append_type_stack)
6366         (push_type_stack, get_type_stack, push_typelist)
6367         (follow_type_instance_flags, follow_types): Remove (moved to
6368         type-stack.c).
6369         * f-exp.y (type_stack): New global.
6370         Update rules.
6371         (push_kind_type, f_parse): Update.
6372         * d-exp.y (type_stack): New global.
6373         Update rules.
6374         (d_parse): Update.
6375         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6376         Update rules.
6377         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6378         (HFILES_NO_SRCDIR): Add type-stack.h.
6379
6380 2019-04-04  Tom Tromey  <tom@tromey.com>
6381
6382         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6383         (rust_parser::convert_ast_to_expression, rust_parse)
6384         (rust_lex_test_completion, rust_lex_tests): Update.
6385         * parser-defs.h (struct expr_completion_state): New.
6386         (struct parser_state) <parser_state>: Add completion parameter.
6387         <mark_struct_expression, mark_completion_tag>: New methods.
6388         <parse_completion, m_completion_state>: New members.
6389         (prefixify_expression, null_post_parser): Update.
6390         (mark_struct_expression, mark_completion_tag): Don't declare.
6391         * parse.c (parse_completion, expout_last_struct)
6392         (expout_tag_completion_type, expout_completion_name): Remove
6393         globals.
6394         (parser_state::mark_struct_expression)
6395         (parser_state::mark_completion_tag): Now methods.
6396         (prefixify_expression): Add last_struct parameter.
6397         (prefixify_subexp): Likewise.
6398         (parse_exp_1): Update.
6399         (parse_exp_in_context): Add cstate parameter.  Update.
6400         (parse_expression_for_completion): Create an
6401         expr_completion_state.
6402         (null_post_parser): Add "completion" parameter.
6403         * p-exp.y: Update rules.
6404         (yylex): Update.
6405         * language.h (struct language_defn) <la_post_parser>: Add
6406         "completing" parameter.
6407         * go-exp.y: Update rules.
6408         (lex_one_token): Update.
6409         * expression.h (parse_completion): Don't declare.
6410         * d-exp.y: Update rules.
6411         (lex_one_token): Update rules.
6412         * c-exp.y: Update rules.
6413         (lex_one_token): Update.
6414         * ada-lang.c (resolve): Add "parse_completion" parameter.
6415         (resolve_subexp): Likewise.
6416         (ada_resolve_function): Likewise.
6417
6418 2019-04-04  Tom Tromey  <tom@tromey.com>
6419
6420         * parser-defs.h (struct parser_state) <start_arglist,
6421         end_arglist>: New methods.
6422         <arglist_len, m_funcall_chain>: New members.
6423         (arglist_len, start_arglist, end_arglist): Don't declare.
6424         * parse.c (arglist_len, funcall_chain): Remove global.
6425         (start_arglist, end_arglist): Remove functions.
6426         (parse_exp_in_context): Update.
6427         * p-exp.y: Update rules.
6428         * m2-exp.y: Update rules.
6429         * go-exp.y: Update rules.
6430         * f-exp.y: Update rules.
6431         * d-exp.y: Update rules.
6432         * c-exp.y: Update rules.
6433
6434 2019-04-04  Tom Tromey  <tom@tromey.com>
6435
6436         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6437         lex_operator, push_back>: New methods.
6438         Update all rules.
6439         (rust_parser::lex_hex, lex_escape): Rename and update.
6440         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6441         (rust_parser::lex_operator): Rename and update.
6442         (rust_parser::lex_number, rustyylex, rustyyerror)
6443         (rust_lex_test_init, rust_lex_test_sequence)
6444         (rust_lex_test_push_back, rust_lex_tests): Update.
6445         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6446         parameter.
6447         <lexptr, prev_lexptr>: New members.
6448         (lexptr, prev_lexptr): Don't declare.
6449         * parse.c (lexptr, prev_lexptr): Remove globals.
6450         (parse_exp_in_context): Update.
6451         * p-exp.y (yylex, yyerror): Update.
6452         * m2-exp.y (parse_number, yylex, yyerror): Update.
6453         * go-exp.y (lex_one_token, yyerror): Update.
6454         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6455         * d-exp.y (lex_one_token, yyerror): Update.
6456         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6457         (lex_one_token, yyerror): Update.
6458         * ada-lex.l (YY_INPUT): Update.
6459         (rewind_to_char): Update.
6460         * ada-exp.y (yyerror): Update.
6461
6462 2019-04-04  Tom Tromey  <tom@tromey.com>
6463
6464         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6465         * parser-defs.h (struct parser_state) <parser_state>: Add new
6466         parameter.
6467         <comma_terminates>: New member.
6468         (comma_terminates): Don't declare global.
6469         * parse.c (comma_terminates): Remove global.
6470         (parse_exp_in_context): Update.
6471         * p-exp.y (yylex): Update.
6472         * m2-exp.y (yylex): Update.
6473         * go-exp.y (lex_one_token): Update.
6474         * f-exp.y (yylex): Update.
6475         * d-exp.y (lex_one_token): Update.
6476         * c-exp.y (lex_one_token): Update.
6477         * ada-lex.l: Update.
6478
6479 2019-04-04  Tom Tromey  <tom@tromey.com>
6480
6481         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6482         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6483         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6484         * parser-defs.h (paren_depth): Don't declare.
6485         * parse.c (paren_depth): Remove global.
6486         (parse_exp_in_context): Update.
6487         * p-exp.y (paren_depth): New global.
6488         (pascal_parse): Initialize it.
6489         * m2-exp.y (paren_depth): New global.
6490         (m2_parse): Initialize it.
6491         * go-exp.y (paren_depth): New global.
6492         (go_parse): Initialize it.
6493         * f-exp.y (paren_depth): New global.
6494         (f_parse): Initialize it.
6495         * d-exp.y (paren_depth): New global.
6496         (d_parse): Initialize it.
6497         * c-exp.y (paren_depth): New global.
6498         (c_parse): Initialize it.
6499         * ada-lex.l (paren_depth): New global.
6500         (lexer_init): Initialize it.
6501
6502 2019-04-04  Tom Tromey  <tom@tromey.com>
6503
6504         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6505         (rust_parser::convert_ast_to_type)
6506         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6507         * parser-defs.h (struct parser_state) <parser_state>: Add
6508         parameters.  Initialize new members.
6509         <expression_context_block, expression_context_pc>: New members.
6510         * parse.c (expression_context_block, expression_context_pc):
6511         Remove globals.
6512         (parse_exp_in_context): Update.
6513         * p-exp.y: Update all rules.
6514         (yylex): Update.
6515         * m2-exp.y: Update all rules.
6516         (yylex): Update.
6517         * go-exp.y (yylex): Update.
6518         * f-exp.y (yylex): Update.
6519         * d-exp.y: Update all rules.
6520         (yylex): Update.
6521         * c-exp.y: Update all rules.
6522         (lex_one_token, classify_name, yylex, c_parse): Update.
6523         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6524
6525 2019-04-04  Tom Tromey  <tom@tromey.com>
6526
6527         * gdbarch.h, gdbarch.c: Rebuild.
6528         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6529         * stap-probe.h: 
6530         (struct stap_parse_info): Replace "parser_state" with
6531         "expr_builder".
6532         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6533         (parser_state): New class.
6534         * parse.c (expr_builder): Rename.
6535         (expr_builder::release): Rename.
6536         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6537         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6538         (write_exp_elt_longcst, write_exp_elt_floatcst)
6539         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6540         (write_exp_string_vector, write_exp_bitstring)
6541         (write_exp_msymbol, mark_struct_expression)
6542         (write_dollar_variable)
6543         (insert_type_address_space, increase_expout_size): Replace
6544         "parser_state" with "expr_builder".
6545         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6546         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6547         "parser_state" with "expr_builder".
6548
6549 2019-04-04  Tom Tromey  <tom@tromey.com>
6550
6551         * rust-exp.y: Replace "parse_language" with method call.
6552         * p-exp.y: 
6553         (yylex): Replace "parse_language" with method call.
6554         * m2-exp.y: 
6555         (yylex): Replace "parse_language" with method call.
6556         * go-exp.y (classify_name): Replace "parse_language" with method
6557         call.
6558         * f-exp.y (yylex): Replace "parse_language" with method call.
6559         * d-exp.y (lex_one_token): Replace "parse_language" with method
6560         call.
6561         * c-exp.y: 
6562         (lex_one_token, classify_name, yylex): Replace "parse_language"
6563         with method call.
6564         * ada-exp.y (find_primitive_type, type_char)
6565         (type_system_address): Replace "parse_language" with method call.
6566
6567 2019-04-04  Tom Tromey  <tom@tromey.com>
6568
6569         * rust-exp.y: Replace "parse_gdbarch" with method call.
6570         * parse.c (write_dollar_variable, insert_type_address_space):
6571         Replace "parse_gdbarch" with method call.
6572         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6573         call.
6574         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6575         call.
6576         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6577         "parse_gdbarch" with method call.
6578         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6579         with method call.
6580         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6581         "parse_gdbarch" with method call.
6582         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6583         "parse_gdbarch" with method call.
6584         * c-exp.y (parse_type, parse_number, classify_name): Replace
6585         "parse_gdbarch" with method call.
6586         * ada-lex.l: Replace "parse_gdbarch" with method call.
6587         * ada-exp.y (parse_type, find_primitive_type, type_char)
6588         (type_system_address): Replace "parse_gdbarch" with method call.
6589
6590 2019-04-04  Tom Tromey  <tom@tromey.com>
6591
6592         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6593         * stap-probe.c (stap_parse_argument): Update.
6594         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6595         initial_size parameter.
6596         * rust-exp.y (rust_lex_tests): Update.
6597         * parse.c (parser_state): Update.
6598         (parse_exp_in_context): Update.
6599         * parser-defs.h (struct parser_state) <parser_state>: Remove
6600         "initial_size" parameter.
6601
6602 2019-04-04  Tom Tromey  <tom@tromey.com>
6603
6604         * parser-defs.h (increase_expout_size): Don't declare.
6605         * parse.c (increase_expout_size): Now static.
6606
6607 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6608
6609         * gnu-nat.c (gnu_nat_target::wait): Fix
6610         target_waitstatus_to_string call.
6611
6612 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6613
6614         * eval.c (evaluate_subexp_standard): Handle internal functions
6615         during Fortran function call handling.
6616
6617 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6618
6619         * NEWS: Mention new internal functions.
6620         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6621         (read_base_type): Use dwarf2_init_complex_target_type.
6622         * value.c (creal_internal_fn): New function.
6623         (cimag_internal_fn): New function.
6624         (_initialize_values): Register new internal functions.
6625
6626 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6627
6628         * infrun.c (stop_all_threads): If debug_infrun, always
6629         trace the wait status after wait_one, using
6630         target_waitstatus_to_string and target_pid_to_str.
6631         (handle_inferior_event): Replace various trace of
6632         wait status kind by a single trace.
6633         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6634         wait status kind image by target_waitstatus_to_string.
6635         * target/waitstatus.c (target_waitstatus_to_string): Fix
6636         obsolete comment.
6637
6638 2019-04-01  Tom Tromey  <tromey@adacore.com>
6639
6640         PR symtab/23331:
6641         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6642
6643 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6644             Pedro Alves  <palves@redhat.com>
6645
6646         * top.c (quit_force): Call 'finalize_values'.
6647         * value.c (finalize_values): New function.
6648         * value.h (finalize_values): Declare.
6649
6650 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6651
6652         * NEWS: Announce $_gdb_major and $_gdb_minor.
6653
6654         * top.c (init_gdb_version_vars): New function.
6655         (gdb_init): Call init_gdb_version_vars.
6656
6657 2019-03-29  Tom Tromey  <tromey@adacore.com>
6658
6659         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6660         help text.  Remove dead code.
6661
6662 2019-03-29  Keith Seitz  <keiths@redhat.com>
6663
6664         From Siddhesh Poyarekar:
6665         * f-lang.h (f77_get_upperbound): Return LONGEST.
6666         (f77_get_lowerbound): Likewise.
6667         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6668         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6669         print them.
6670         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6671         plongest to format print it.
6672         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6673         (f77_get_upperbound): Likewise.
6674         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6675         LOWER_BOUND to LONGEST.
6676         (f77_create_arrayprint_offset_tbl): Likewise.
6677
6678 2019-03-29  Keith Seitz  <keiths@redhat.com>
6679
6680         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6681         %s/pulongest for TYPE_LENGTH instead of %d in format
6682         strings.
6683         * ada-typerint.c (ada_print_type): Likewise.
6684         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6685         * compile/compile-c-support.c (generate_register_struct): Likewise.
6686         * gdbtypes.c (recursive_dump_type): Likewise.
6687         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6688         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6689         instead of %d in format strings.
6690         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6691         to std::min to ULONGEST.
6692         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6693         instead of %d in format strings.
6694         * tracepoint.c (info_scope_command): Likewise.
6695         * typeprint.c (print_offset_data::update)
6696         (print_offset_data::finish): Likewise.
6697         * xtensa-tdep.c (xtensa_store_return_value)
6698         (xtensa_push_dummy_call): Likewise.
6699
6700 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6701
6702         * windows-nat.c (display_selector): Fixed format specifications
6703         for 64-bit Cygwin.
6704
6705 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6706
6707         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6708
6709 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6710
6711         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6712         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6713         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6714         (nios2_linux_init_abi): Install it.
6715
6716 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6717
6718         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6719
6720 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6721
6722         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6723
6724 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6725             Tom Tromey  <tromey@adacore.com>
6726
6727         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6728
6729 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6730
6731         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6732         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6733         method to compute the bounds of range types. Also print "[evaluated]"
6734         if the bounds' values come from a dynamic evaluation.
6735
6736 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6737
6738         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6739         whitespace when pretty printing is on.
6740
6741 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6742
6743         * ppc-linux-nat.c: Add include.
6744
6745 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6746
6747         * NEWS: Mention AArch64 Pointer Authentication.
6748
6749 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6750
6751         * arm-linux-nat.c: Add include.
6752
6753 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6754
6755         * source-cache.c (source_cache::get_source_lines): Re-read
6756         fullname after calling open_source_file.
6757
6758 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6759
6760         * NEWS: Mention TLS support for FreeBSD.
6761
6762 2019-03-25  Tom Tromey  <tromey@adacore.com>
6763
6764         * minsyms.c (BUNCH_SIZE): Update comment.
6765         (~minimal_symbol_reader): Remove old comment.
6766         (compact_minimal_symbols): Update comment.
6767         (minimal_symbol_reader::install): Remove old comment.  Update
6768         other comments.
6769
6770 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6771
6772         * s390-linux-nat.c: Add include.
6773
6774 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6775
6776         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6777         Call linux_get_hwcap.
6778         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6779         Likewise.
6780         (aarch64_linux_get_hwcap): Remove function.
6781         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6782         declaration.
6783         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6784         linux_get_hwcap.
6785         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6786         * linux-tdep.c (linux_get_hwcap): Add function.
6787         (linux_get_hwcap2): Likewise.
6788         * linux-tdep.h (linux_get_hwcap): Add declaration.
6789         (linux_get_hwcap2): Likewise.
6790         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6791         (ppc_linux_get_hwcap2): Likewise.
6792         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6793         linux_get_hwcap.
6794         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6795         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6796         (ppc_linux_nat_target::read_description): Likewise.
6797         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6798         * s390-linux-nat.c: Likewise.
6799         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6800
6801 2019-03-24  Tom Tromey  <tom@tromey.com>
6802
6803         * ada-lang.c (standard_lookup): Simplify initialization.
6804         (ada_lookup_symbol_nonlocal): Simplify return.
6805         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6806         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6807         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6808         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6809         initialization.
6810         * solib.c (solib_global_lookup): Simplify.
6811         * symtab.c (null_block_symbol): Remove.
6812         (symbol_cache_lookup): Simplify returns.
6813         (lookup_language_this): Simplify returns.
6814         (lookup_symbol_aux): Simplify return.
6815         (lookup_local_symbol): Simplify returns.
6816         (lookup_global_symbol_from_objfile): Simplify return.
6817         (lookup_symbol_in_objfile_symtabs)
6818         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6819         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6820         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6821         * cp-namespace.c (cp_lookup_bare_symbol)
6822         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6823         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6824         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6825         (cp_lookup_symbol_via_imports): Simplify initialization.
6826         (find_symbol_in_baseclass): Likewise.
6827         * symtab.h (null_block_symbol): Remove.
6828         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6829         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6830         (d_lookup_symbol_module): Likewise.
6831         (find_symbol_in_baseclass): Simplify initialization.
6832
6833 2019-03-24  Tom Tromey  <tom@tromey.com>
6834
6835         * expression.h: Don't include symtab.h.
6836         (struct block): Forward declare.
6837
6838 2019-03-24  Tom Tromey  <tom@tromey.com>
6839
6840         * c-exp.y (typebase): Remove casts.
6841         * gdbtypes.c (lookup_unsigned_typename, )
6842         (lookup_signed_typename): Remove cast.
6843         * eval.c (parse_to_comma_and_eval): Remove cast.
6844         * parse.c (write_dollar_variable): Remove cast.
6845         * block.h (struct block) <superblock>: Now const.
6846         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6847         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6848         (map_block): Make "block" const.
6849         * symfile.h (struct quick_symbol_functions)
6850         <map_matching_symbols>: Constify block argument to "callback".
6851         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6852         const.
6853         (find_pc_sect_compunit_symtab): Make "b" const.
6854         (find_symbol_at_address): Likewise.
6855         (search_symbols): Likewise.
6856         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6857         (dw2_debug_names_lookup_symbol): Likewise.
6858         (dw2_map_matching_symbols): Update.
6859         * p-valprint.c (pascal_val_print): Remove "block".
6860         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6861         (aux_add_nonlocal_symbols): Make "block" const.
6862         (resolve_subexp): Remove cast.
6863         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6864         const.
6865         (iterate_over_file_blocks): Likewise.
6866         * f-exp.y (%union) <bval>: Remove.
6867         * coffread.c (patch_opaque_types): Make "b" const.
6868         * spu-tdep.c (spu_catch_start): Make "block" const.
6869         * c-valprint.c (print_unpacked_pointer): Remove "block".
6870         * symmisc.c (dump_symtab_1): Make "b" const.
6871         (block_depth): Make "block" const.
6872         * d-exp.y (%union) <bval>: Remove.
6873         * cp-support.h (cp_lookup_rtti_type): Update.
6874         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6875         * psymtab.c (psym_lookup_symbol): Make "block" const.
6876         (maintenance_check_psymtabs): Make "b" const.
6877         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6878         (enumerate_locals, enumerate_args): Update.
6879         * python/py-symtab.c (stpy_global_block): Make "block" const.
6880         (stpy_static_block): Likewise.
6881         * inline-frame.c (block_starting_point_at): Make "new_block"
6882         const.
6883         * block.c (find_block_in_blockvector): Make return type const.
6884         (blockvector_for_pc_sect): Make "b" const.
6885         (find_block_in_blockvector): Make "b" const.
6886
6887 2019-03-23  Tom Tromey  <tom@tromey.com>
6888
6889         * varobj.c (varobj_create): Update.
6890         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6891         * printcmd.c (display_command, do_one_display): Don't reset
6892         innermost_block.
6893         * parser-defs.h (enum innermost_block_tracker_type): Move to
6894         expression.h.
6895         (innermost_block): Update comment.
6896         * parse.c (parse_exp_1): Add tracker_types parameter.
6897         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6898         tracker_types parameter.  Reset innermost_block.
6899         (parse_exp_in_context): Remove.
6900         (parse_expression_for_completion): Update.
6901         * objfiles.c (~objfile): Don't reset expression_context_block or
6902         innermost_block.
6903         * expression.h (enum innermost_block_tracker_type): Move from
6904         parser-defs.h.
6905         (parse_exp_1): Add tracker_types parameter.
6906         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6907         reset innermost_block.
6908
6909 2019-03-23  Tom Tromey  <tom@tromey.com>
6910
6911         * objfiles.h: Include bcache.h.
6912
6913 2019-03-23  Tom Tromey  <tom@tromey.com>
6914
6915         * linespec.c (get_current_search_block): Use
6916         scoped_restore_current_language.
6917         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6918
6919 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6920             Jiong Wang  <jiong.wang@arm.com>
6921
6922         * aarch64-linux-tdep.c
6923         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6924         section.
6925         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6926
6927 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6928             Jiong Wang  <jiong.wang@arm.com>
6929
6930         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6931         instructions.
6932         (aarch64_analyze_prologue_test): Add PACIASP test.
6933         (aarch64_prologue_prev_register): Unmask PC value.
6934
6935 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6936             Jiong Wang  <jiong.wang@arm.com>
6937
6938         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6939         (aarch64_dwarf2_prev_register): Unmask PC value.
6940         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6941         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6942         DW_CFA_AARCH64_negate_ra_state.
6943         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6944
6945 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6946             Jiong Wang  <jiong.wang@arm.com>
6947
6948         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6949         registers.
6950         (aarch64_pseudo_register_name): Likewise.
6951         (aarch64_pseudo_register_type): Likewise.
6952         (aarch64_pseudo_register_reggroup_p): Likewise.
6953         (aarch64_gdbarch_init): Add pauth registers.
6954         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6955         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6956         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6957         (struct gdbarch_tdep): Add regnum for ra_state.
6958
6959 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6960             Jiong Wang  <jiong.wang@arm.com>
6961
6962         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6963
6964 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6965             Jiong Wang  <jiong.wang@arm.com>
6966
6967         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6968         function.
6969         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6970         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6971         (aarch64_gdbarch_init): Add puth registers.
6972         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6973         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6974         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6975
6976 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6977             Jiong Wang  <jiong.wang@arm.com>
6978
6979         * aarch64-linux-nat.c
6980         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6981         * aarch64-linux-tdep.c
6982         (aarch64_linux_core_read_description): Likewise.
6983         (aarch64_linux_get_hwcap): New function.
6984         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6985         (aarch64_linux_get_hwcap): New declaration.
6986
6987 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6988             Jiong Wang  <jiong.wang@arm.com>
6989
6990         * aarch64-linux-nat.c
6991         (aarch64_linux_nat_target::read_description): Add pauth param.
6992         * aarch64-linux-tdep.c
6993         (aarch64_linux_core_read_description): Likewise.
6994         * aarch64-tdep.c (struct target_desc): Add in pauth.
6995         (aarch64_read_description): Add pauth param.
6996         (aarch64_gdbarch_init): Likewise.
6997         * aarch64-tdep.h (aarch64_read_description): Likewise.
6998         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6999         * arch/aarch64.h (aarch64_create_target_description): Likewise.
7000         * features/Makefile: Add new files.
7001         * features/aarch64-pauth.c: New file.
7002         * features/aarch64-pauth.xml: New file.
7003
7004 2019-03-20  Tom Tromey  <tromey@adacore.com>
7005
7006         * infrun.c (handle_inferior_event): Rename from
7007         handle_inferior_event_1.  Create a scoped_value_mark.
7008         (handle_inferior_event): Remove.
7009
7010 2019-03-19  Tom Tromey  <tromey@adacore.com>
7011
7012         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
7013         * infrun.h (print_stop_event): Add "displays" parameter.
7014         * infrun.c (print_stop_event): Add "displays" parameter.
7015
7016 2019-03-19  Pedro Alves  <palves@redhat.com>
7017
7018         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
7019         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
7020         to -1.  Fix TABs vs spaces.
7021         (tui_ui_out::tui_ui_out): Don't initialize fields here.
7022         * tui/tui-out.h (tui_ui_out) Add intro comments.
7023         <m_line, m_start_of_line>: In-class initialize, and add describing
7024         comment.
7025
7026 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
7027
7028         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
7029         variable names.
7030         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
7031
7032 2019-03-18  Pedro Alves  <palves@redhat.com>
7033             Eli Zaretskii <eliz@gnu.org>
7034
7035         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
7036         m_line and m_start_of_line.
7037
7038 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
7039
7040         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
7041         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
7042         it returns a newline.  This fixes a regression in TU mode, whereby
7043         the next line is output on the same screen line as the user input.
7044
7045 2019-03-18  Tom Tromey  <tromey@adacore.com>
7046
7047         * minsyms.c (minimal_symbol_reader::install): Remove call to
7048         obstack_blank.
7049
7050 2019-03-18  Pedro Alves  <palves@redhat.com>
7051
7052         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
7053         New globals.
7054         (apply_style): New, factored out from ...
7055         (apply_ansi_escape): ... this.  Handle reverse video mode.
7056         (tui_set_reverse_mode): New function.
7057         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
7058         * tui/tui-winsource.c (tui_show_source_line): Use
7059         tui_set_reverse_mode instead of setting A_STANDOUT.
7060         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
7061         New setter methods.
7062
7063 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
7064
7065         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
7066         Handle tabs.
7067
7068 2019-03-18  Tom Tromey  <tromey@adacore.com>
7069
7070         * ada-lang.c (empty_array): Add "high" parameter.
7071         (ada_evaluate_subexp): Update.
7072
7073 2019-03-17  Sergei Trofimovich <siarheit@google.com>
7074
7075         * unittests/string_view-selftests.c: Define
7076         _initialize_string_view_selftests unconditionally.
7077
7078 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7079
7080         PR gdb/24350
7081         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
7082
7083 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7084
7085         PR gdb/24351
7086         * windows-nat.c (display_selector): Fix format specifiers.
7087
7088 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
7089
7090         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
7091         tui_refill_source_window instead of tui_refresh_win, to update the
7092         current execution line.  This fixes redisplay of the current line
7093         when stepping through the code with "next" or "step".
7094
7095 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7096
7097         * source-cache.c (source_cache::get_source_lines): Call
7098         find_source_lines to initialize s->nlines.  This fixes vertical
7099         scrolling of TUI source window when the DOWN arrow is pressed.
7100
7101 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7102
7103         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
7104         linux-thread-db.c (_initialize_thread_db): Likewise.
7105
7106 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7107
7108         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
7109         wclrtoeol in tui_show_source_line".  This reverts changes made in
7110         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
7111
7112 2019-03-15  Tom Tromey  <tom@tromey.com>
7113
7114         * symtab.h (struct minimal_symbol): Derive from
7115         general_symbol_info.
7116         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
7117         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
7118         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
7119         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
7120         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
7121         (MSYMBOL_SEARCH_NAME): Update.
7122         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
7123         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
7124         * minsyms.c (minimal_symbol_reader::record_full): Update.
7125
7126 2019-03-15  Tom Tromey  <tom@tromey.com>
7127
7128         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
7129
7130 2019-03-15  Tom Tromey  <tom@tromey.com>
7131
7132         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
7133         unique_xmalloc_ptr.
7134         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
7135         Update.
7136         * minsyms.c (lookup_minimal_symbol_by_pc_section)
7137         (build_minimal_symbol_hash_tables)
7138         (minimal_symbol_reader::install): Update.
7139
7140 2019-03-15  Tom Tromey  <tom@tromey.com>
7141
7142         * symtab.c (create_demangled_names_hash): Update.
7143         (symbol_set_names): Update.
7144         * objfiles.h (struct objfile_per_bfd_storage)
7145         <demangled_names_hash>: Now an htab_up.
7146         * objfiles.c (objfile_per_bfd_storage): Simplify.
7147
7148 2019-03-15  Tom Tromey  <tom@tromey.com>
7149
7150         * objfiles.h (struct objfile_per_bfd_storage): Declare
7151         destructor.
7152         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
7153         New.
7154         (get_objfile_bfd_data): Use new.  Don't initialize
7155         language_of_main.
7156         (free_objfile_per_bfd_storage): Remove.
7157         (objfile_bfd_data_free, objfile::~objfile): Use delete.
7158
7159 2019-03-15  Tom Tromey  <tom@tromey.com>
7160
7161         * symfile.c (reread_symbols): Update.
7162         * objfiles.c (objfile::objfile): Update.
7163         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
7164         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7165         comment.
7166         (minimal_symbol_reader::install): Update.
7167         (terminate_minimal_symbol_table): Remove.
7168         * jit.c (jit_object_close_impl): Update.
7169
7170 2019-03-15  Tom Tromey  <tom@tromey.com>
7171
7172         * minsyms.c (minimal_symbol_reader::record_full): Remove some
7173         initializations.
7174
7175 2019-03-15  Tom Tromey  <tom@tromey.com>
7176
7177         * objfiles.h (struct objfile_per_bfd_storage)
7178         <demangled_hash_languages>: Now a bitset.
7179         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7180         (lookup_minimal_symbol): Update.
7181
7182 2019-03-15  Tom Tromey  <tom@tromey.com>
7183
7184         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7185         Don't return the symbol.
7186         * coffread.c (record_minimal_symbol): Use record_full.
7187
7188 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
7189
7190         The MS-Windows port of ncurses fails to switch to a color pair if
7191         one or both of the colors are the implicit default colors.  This
7192         change records the default colors when TUI is initialized, and
7193         then specifies them explicitly when a color pair uses the default
7194         colors.  This allows color styling in TUI mode on MS-Windows.
7195
7196         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
7197         ncurses_norm_attr.
7198         (tui_initialize_io) [__MINGW32__]: Record the default terminal
7199         colors in ncurses_norm_attr.
7200         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7201         "none", replace it with the default color recorded in
7202         ncurses_norm_attr.
7203
7204 2019-03-14  Tom Tromey  <tromey@adacore.com>
7205
7206         * source-cache.h (class source_cache) <get_source_lines>: Return
7207         std::string.
7208         * source-cache.c (source_cache::extract_lines): Handle case where
7209         first_pos==npos.  Return std::string.
7210         (source_cache::get_source_lines): Update.
7211
7212 2019-03-14  Tom Tromey  <tromey@adacore.com>
7213
7214         * NEWS: Add item for "style sources" commands.
7215         * source-cache.c (source_cache::get_source_lines): Check
7216         source_styling.
7217         * cli/cli-style.c (source_styling): New global.
7218         (_initialize_cli_style): Add "style sources" commands.
7219         (show_style_sources): New function.
7220         * cli/cli-style.h (source_styling): Declare.
7221
7222 2019-03-14  Pedro Alves  <palves@redhat.com>
7223             Tom Tromey  <tromey@adacore.com>
7224
7225         * tui/tui-winsource.h (tui_refill_source_window): Declare.
7226         * tui/tui-winsource.c (tui_refill_source_window): New function,
7227         from...
7228         (tui_horizontal_source_scroll): ... here.  Move some logic.
7229         * cli/cli-style.c (set_style_enabled): Notify new observable.
7230         * tui/tui-hooks.c (tui_redisplay_source): New function.
7231         (tui_attach_detach_observers): Attach or detach
7232         tui_redisplay_source.
7233         * observable.h (source_styling_changed): New observable.
7234         * observable.c: Define source_styling_changed observable.
7235
7236 2019-03-13  Tom Tromey  <tromey@adacore.com>
7237
7238         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7239         (i386_gnu_nat_target::store_registers): Update.
7240         * target-debug.h (target_debug_print_std_string): New macro.
7241         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7242         * windows-tdep.c (display_one_tib): Update.
7243         * tui/tui-stack.c (tui_make_status_line): Update.
7244         * top.c (print_inferior_quit_action): Update.
7245         * thread.c (thr_try_catch_cmd): Update.
7246         (add_thread_with_info): Update.
7247         (thread_target_id_str): Update.
7248         (thr_try_catch_cmd): Update.
7249         (thread_command): Update.
7250         (thread_find_command): Update.
7251         * record-btrace.c (record_btrace_target::info_record)
7252         (record_btrace_resume_thread, record_btrace_target::resume)
7253         (record_btrace_cancel_resume, record_btrace_step_thread)
7254         (record_btrace_target::wait, record_btrace_target::wait)
7255         (record_btrace_target::wait, record_btrace_target::stop): Update.
7256         * progspace.c (print_program_space): Update.
7257         * process-stratum-target.c
7258         (process_stratum_target::thread_address_space): Update.
7259         * linux-fork.c (linux_fork_mourn_inferior)
7260         (detach_checkpoint_command, info_checkpoints_command)
7261         (linux_fork_context): Update.
7262         (linux_fork_detach): Update.
7263         (class scoped_switch_fork_info): Update.
7264         (delete_checkpoint_command): Update.
7265         * infrun.c (follow_fork_inferior): Update.
7266         (follow_fork_inferior): Update.
7267         (proceed_after_vfork_done): Update.
7268         (handle_vfork_child_exec_or_exit): Update.
7269         (follow_exec): Update.
7270         (displaced_step_prepare_throw): Update.
7271         (displaced_step_restore): Update.
7272         (start_step_over): Update.
7273         (resume_1): Update.
7274         (clear_proceed_status_thread): Update.
7275         (proceed): Update.
7276         (print_target_wait_results): Update.
7277         (do_target_wait): Update.
7278         (context_switch): Update.
7279         (stop_all_threads): Update.
7280         (restart_threads): Update.
7281         (finish_step_over): Update.
7282         (handle_signal_stop): Update.
7283         (switch_back_to_stepped_thread): Update.
7284         (keep_going_pass_signal): Update.
7285         (print_exited_reason): Update.
7286         (normal_stop): Update.
7287         * inferior.c (inferior_pid_to_str): Change return type.
7288         (print_selected_inferior): Update.
7289         (add_inferior): Update.
7290         (detach_inferior): Update.
7291         * dummy-frame.c (fprint_dummy_frames): Update.
7292         * dcache.c (dcache_info_1): Update.
7293         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7294         (btrace_fetch, btrace_clear): Update.
7295         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7296         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7297         type.
7298         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7299         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7300         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7301         * gdbarch.c, gdbarch.h: Rebuild.
7302         * gdbarch.sh (core_pid_to_str): Change return type.
7303         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7304         return type.
7305         (windows_nat_target::pid_to_str): Change return type.
7306         (windows_delete_thread): Update.
7307         (windows_nat_target::attach): Update.
7308         (windows_nat_target::files_info): Update.
7309         * target-delegates.c: Rebuild.
7310         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7311         return type.
7312         (sol_thread_target::pid_to_str): Change return type.
7313         * remote.c (class remote_target) <pid_to_str>: Change return
7314         type.
7315         (remote_target::pid_to_str): Change return type.
7316         (extended_remote_target::attach, remote_target::remote_stop_ns)
7317         (remote_target::remote_notif_remove_queued_reply)
7318         (remote_target::push_stop_reply, remote_target::disable_btrace):
7319         Update.
7320         (extended_remote_target::attach): Update.
7321         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7322         type.
7323         (gdbsim_target::pid_to_str): Change return type.
7324         * ravenscar-thread.c (struct ravenscar_thread_target)
7325         <pid_to_str>: Change return type.
7326         (ravenscar_thread_target::pid_to_str): Change return type.
7327         * procfs.c (class procfs_target) <pid_to_str>: Change return
7328         type.
7329         (procfs_target::pid_to_str): Change return type.
7330         (procfs_target::attach): Update.
7331         (procfs_target::detach): Update.
7332         (procfs_target::fetch_registers): Update.
7333         (procfs_target::store_registers): Update.
7334         (procfs_target::wait): Update.
7335         (procfs_target::files_info): Update.
7336         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7337         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7338         return type.
7339         (nto_procfs_target::pid_to_str): Change return type.
7340         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7341         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7342         return type.
7343         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7344         (exit_lwp): Update.
7345         (attach_proc_task_lwp_callback, get_detach_signal)
7346         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7347         (linux_nat_target::resume, wait_lwp, stop_callback)
7348         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7349         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7350         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7351         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7352         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7353         type.
7354         (inf_ptrace_target::attach): Update.
7355         (inf_ptrace_target::files_info): Update.
7356         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7357         type.
7358         (go32_nat_target::pid_to_str): Change return type.
7359         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7360         (gnu_nat_target::wait): Update.
7361         (gnu_nat_target::wait): Update.
7362         (gnu_nat_target::resume): Update.
7363         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7364         (fbsd_nat_target::wait): Update.
7365         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7366         type.
7367         (darwin_nat_target::attach): Update.
7368         * corelow.c (class core_target) <pid_to_str>: Change return type.
7369         (core_target::pid_to_str): Change return type.
7370         * target.c (normal_pid_to_str): Change return type.
7371         (default_pid_to_str): Likewise.
7372         (target_pid_to_str): Change return type.
7373         (target_translate_tls_address): Update.
7374         (target_announce_detach): Update.
7375         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7376         return type.
7377         (bsd_uthread_target::pid_to_str): Change return type.
7378         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7379         type.
7380         (bsd_kvm_target::pid_to_str): Change return type.
7381         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7382         return type.
7383         (aix_thread_target::pid_to_str): Change return type.
7384         * target.h (struct target_ops) <pid_to_str>: Change return type.
7385         (target_pid_to_str, normal_pid_to_str): Likewise.
7386         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7387         type.
7388         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7389         type.
7390         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7391         return type.
7392         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7393         type.
7394         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7395         type.
7396         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7397         return type.
7398
7399 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7400
7401         * NEWS: Mention that the new default MI version is 3.  Mention
7402         changes to the output of commands and events that deal with
7403         multi-location breakpoints.
7404         * breakpoint.c: Include "mi/mi-out.h".
7405         (print_one_breakpoint): Change output syntax if using MI version
7406         >= 3.
7407         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7408         New.
7409         (mi_multi_location_breakpoint_output_fixed): New.
7410         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7411         (mi_cmd_fix_multi_location_breakpoint_output): New.
7412         (mi_multi_location_breakpoint_output_fixed): New.
7413         * mi/mi-cmds.c (mi_cmds): Register command
7414         -fix-multi-location-breakpoint-output.
7415         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7416         interpreter "mi".
7417
7418 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7419
7420         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7421         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7422         instantiate mi_ui_out based on interpreter name.
7423         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7424         * mi/mi-main.c (mi_load_progress): Likewise.
7425
7426 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7427
7428         * NEWS: Combine separate "New targets" sections for 8.3.
7429
7430 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7431
7432         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7433         (ppcfbsd_init_abi): Install gdbarch
7434         "fetch_tls_load_module_address" and "get_thread_local_address"
7435         methods.
7436
7437 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7438
7439         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7440         (riscv_fbsd_init_abi): Install gdbarch
7441         "fetch_tls_load_module_address" and "get_thread_local_address"
7442         methods.
7443
7444 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7445
7446         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7447         (i386fbsd_init_abi): Install gdbarch
7448         "fetch_tls_load_module_address" and "get_thread_local_address"
7449         methods.
7450
7451 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7452
7453         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7454         (amd64fbsd_init_abi): Install gdbarch
7455         "fetch_tls_load_module_address" and "get_thread_local_address"
7456         methods.
7457
7458 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7459
7460         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7461         (struct fbsd_pspace_data): New type.
7462         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7463         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7464         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7465         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7466         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7467
7468 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7469
7470         * gdbtypes.c (lookup_struct_elt): New function.
7471         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7472         * gdbtypes.h (struct struct_elt): New type.
7473         (lookup_struct_elt): New prototype.
7474
7475 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7476
7477         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7478         remove disabled code block.
7479
7480 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7481
7482         * gdbarch.sh (get_thread_local_address): New method.
7483         * gdbarch.h, gdbarch.c: Regenerate.
7484         * target.c (target_translate_tls_address): Use
7485         gdbarch_get_thread_local_address if present instead of
7486         target::get_thread_local_address.
7487
7488 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7489
7490         * target.h (target::get_thread_local_address): Update comment.
7491
7492 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7493
7494         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7495         objfile->separate_debug_objfile_backlink if not NULL.
7496
7497 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7498
7499         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7500         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7501         (amd64bsd_store_inferior_registers): Likewise.
7502         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7503         Enable segment base registers.
7504         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7505         PT_GETFSBASE and PT_GETGSBASE.
7506         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7507         PT_SETGSBASE.
7508         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7509         segment base registers.
7510         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7511
7512 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7513
7514         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7515         Update calls to i386_target_description to add 'segments'
7516         parameter.
7517         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7518         add segment base registers.
7519         * arch/i386.c (i386_create_target_description): Add 'segments'
7520         parameter to enable segment base registers.
7521         * arch/i386.h (i386_create_target_description): Likewise.
7522         * features/i386/32bit-segments.xml: New file.
7523         * features/i386/32bit-segments.c: Generate.
7524         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7525         call to i386_target_description to add 'segments' parameter.
7526         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7527         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7528         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7529         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7530         if feature is present.
7531         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7532         Add 'segments' parameter to call to i386_target_description.
7533         (i386_target_description): Add 'segments' parameter to enable
7534         segment base registers.
7535         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7536         to call to i386_target_description.
7537         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7538         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7539         Define I386_NUM_REGS.
7540         (i386_target_description): Add 'segments' parameter to enable
7541         segment base registers.
7542
7543 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7544
7545         PR/24325
7546         * source-cache.c: #undef open and close, to avoid unresolved
7547         externals during linking.
7548
7549 2019-03-12  Tom Tromey  <tromey@adacore.com>
7550
7551         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7552         const.  Add initializers.
7553         (_initialize_remote): Don't initialize ptid globals.
7554
7555 2019-03-12  Pedro Alves  <palves@redhat.com>
7556
7557         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7558
7559 2019-03-12  Pedro Alves  <palves@redhat.com>
7560
7561         * cp-name-parser.y (main): Remove unused 'len' variable.
7562
7563 2019-03-12  Tom Tromey  <tromey@adacore.com>
7564
7565         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7566         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7567
7568 2019-03-12  Tom Tromey  <tromey@adacore.com>
7569
7570         * linux-nat.c (iterate_over_lwps): Update.
7571         (stop_callback): Remove parameter.
7572         (stop_wait_callback, detach_callback, resume_set_callback)
7573         (select_singlestep_lwp_callback, set_ignore_sigint)
7574         (status_callback, resumed_callback, resume_clear_callback)
7575         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7576         data parameter.
7577         (linux_nat_target::detach, linux_nat_target::resume)
7578         (linux_stop_and_wait_all_lwps, select_event_lwp)
7579         (linux_nat_filter_event, linux_nat_wait_1)
7580         (linux_nat_target::kill, linux_nat_target::stop)
7581         (linux_nat_target::stop): Update.
7582         (linux_nat_resume_callback): Change type.
7583         (resume_stopped_resumed_lwps, count_events_callback)
7584         (select_event_lwp_callback): Likewise.
7585         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7586         * arm-linux-nat.c (struct update_registers_data): Remove.
7587         (update_registers_callback): Change type.
7588         (arm_linux_insert_hw_breakpoint1): Update.
7589         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7590         parameter.
7591         (x86_linux_dr_set_addr): Update.
7592         (x86_linux_dr_set_control): Update.
7593         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7594         (iterate_over_lwps): Use gdb::function_view.
7595         * nat/aarch64-linux-hw-point.c (struct
7596         aarch64_dr_update_callback_param): Remove.
7597         (debug_reg_change_callback): Change type.
7598         (aarch64_notify_debug_reg_change): Update.
7599         * s390-linux-nat.c (s390_refresh_per_info): Update.
7600
7601 2019-03-11  Tom Tromey  <tromey@adacore.com>
7602
7603         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7604         redundant assignment to "this_cu".
7605
7606 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7607
7608         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7609
7610 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7611
7612         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7613         from...
7614         (rank_one_type): ... this.
7615
7616 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7617
7618         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7619         from...
7620         (rank_one_type): ... this.
7621
7622 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7623
7624         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7625         from...
7626         (rank_one_type): ... this.
7627
7628 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7629
7630         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7631         from...
7632         (rank_one_type): ... this.
7633
7634 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7635
7636         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7637         from...
7638         (rank_one_type): ... this.
7639
7640 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7641
7642         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7643         from...
7644         (rank_one_type): ... this.
7645
7646 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7647
7648         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7649         from...
7650         (rank_one_type): ... this.
7651
7652 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7653
7654         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7655         from...
7656         (rank_one_type): ... this.
7657
7658 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7659
7660         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7661         from...
7662         (rank_one_type): ... this.
7663
7664 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7665
7666         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7667         from...
7668         (rank_one_type): ... this.
7669
7670 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7671
7672         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7673         from...
7674         (rank_one_type): ... this.
7675
7676 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7677
7678         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7679         from...
7680         (rank_one_type): ... this.
7681
7682 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7683
7684         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7685         inferior-events' shows the example events.
7686
7687 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7688
7689         Support styling on native MS-Windows console
7690
7691         PR/24315
7692         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7693         on MS-Windows if $TERM is not defined.
7694
7695         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7696
7697         * posix-hdep.c (gdb_console_fputs):
7698         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7699         functions.
7700         * ui-file.h (gdb_console_fputs): Add prototype.
7701
7702         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7703         back to fputs only if the former returns zero.
7704
7705 2019-03-07  Tom Tromey  <tom@tromey.com>
7706
7707         * symmisc.c (print_symbol_bcache_statistics): Update.
7708         (print_objfile_statistics): Update.
7709         * symfile.c (allocate_symtab): Update.
7710         * stabsread.c: Don't include bcache.h.
7711         * psymtab.h (struct psymbol_bcache): Don't declare.
7712         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7713         (psymbol_bcache_init, psymbol_bcache_free)
7714         (psymbol_bcache_get_bcache): Don't declare.
7715         * psymtab.c (struct psymbol_bcache): Remove.
7716         (psymtab_storage::psymtab_storage): Update.
7717         (psymtab_storage::~psymtab_storage): Update.
7718         (psymbol_bcache_init, psymbol_bcache_free)
7719         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7720         (add_psymbol_to_bcache): Update.
7721         (allocate_psymtab): Update.
7722         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7723         macro_cache>: No longer pointers.
7724         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7725         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7726         * macrotab.c (macro_bcache): Update.
7727         * macroexp.c: Don't include bcache.h.
7728         * gdbtypes.c (check_types_worklist): Update.
7729         (types_deeply_equal): Remove TRY/CATCH.  Update.
7730         * elfread.c (elf_symtab_read): Update.
7731         * dwarf2read.c: Don't include bcache.h.
7732         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7733         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7734         (print_bcache_statistics, bcache_memory_used): Don't declare.
7735         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7736         methods.  Rename all data members.
7737         * bcache.c (struct bcache): Move to bcache.h.
7738         (bcache::expand_hash_table): Rename from expand_hash_table.
7739         (bcache): Remove.
7740         (bcache::insert): Rename from bcache_full.
7741         (bcache::compare): Rename from bcache_compare.
7742         (bcache_xmalloc): Remove.
7743         (bcache::~bcache): Rename from bcache_xfree.
7744         (bcache::print_statistics): Rename from print_bcache_statistics.
7745         (bcache::memory_used): Rename from bcache_memory_used.
7746
7747 2019-03-07  Pedro Alves  <palves@redhat.com>
7748
7749         * infrun.c (normal_stop): Also check for
7750         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7751
7752 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7753
7754         * f-lang.c (value_from_host_double): Moved to...
7755         * value.c (value_from_host_double): ...here.
7756         * value.h (value_from_host_double): Declare.
7757         * guile/scm-math.c (vlscm_convert_typed_number): Use
7758         value_from_host_double.
7759         (vlscm_convert_number): Likewise.
7760         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7761         * python/py-value.c (convert_value_from_python): Likewise.
7762
7763 2019-03-06  Tom Tromey  <tom@tromey.com>
7764
7765         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7766
7767 2019-03-06  Tom Tromey  <tom@tromey.com>
7768
7769         * utils.h (free_current_contents): Don't declare.
7770         * utils.c (free_current_contents): Remove.
7771
7772 2019-03-06  Tom Tromey  <tom@tromey.com>
7773
7774         * top.c (quit_force): Update.
7775         * main.c (captured_command_loop): Update.
7776         * common/new-op.c (operator new): Update.
7777         * common/common-exceptions.c (struct catcher)
7778         <save_cleanup_chain>: Remove member.
7779         (exceptions_state_mc_init): Update.
7780         (exception_try_scope_entry): Return nullptr.
7781         (exception_try_scope_exit, exception_rethrow)
7782         (throw_exception_sjlj, throw_exception_cxx): Update.
7783         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7784         (all_cleanups, do_cleanups, discard_cleanups)
7785         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7786         (restore_cleanups, restore_final_cleanups): Don't declare.
7787         (do_final_cleanups): Remove parameter.
7788         * common/cleanups.c (cleanup_chain, make_cleanup)
7789         (make_cleanup_dtor, all_cleanups, do_cleanups)
7790         (discard_my_cleanups, discard_cleanups)
7791         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7792         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7793         (null_cleanup): Remove.
7794         (do_final_cleanups): Remove parameter.
7795
7796 2019-03-06  Tom Tromey  <tom@tromey.com>
7797
7798         * remote.c (remote_target::remote_parse_stop_reply): Use
7799         unique_xmalloc_ptr.
7800
7801 2019-03-06  Tom Tromey  <tom@tromey.com>
7802
7803         * stabsread.c (struct stabs_field_info): Rename from field_info.
7804         <list, fnlist>: Add initializers.
7805         <obstack>: New member.
7806         (read_member_functions, read_struct_fields, read_baseclasses):
7807         Allocate on obstack.  Don't use cleanups.
7808         (read_one_struct_field, read_member_functions, read_struct_fields)
7809         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7810         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7811         (read_struct_type): Update.
7812
7813 2019-03-06  Tom Tromey  <tom@tromey.com>
7814
7815         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7816         * common/filestuff.h (make_cleanup_close): Don't declare.
7817         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7818         Remove.
7819
7820 2019-03-06  Tom Tromey  <tom@tromey.com>
7821
7822         * solib-aix.c: Use make_scope_exit.
7823
7824 2019-03-06  Tom Tromey  <tom@tromey.com>
7825
7826         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7827         Use make_scope_exit.
7828
7829 2019-03-06  Tom Tromey  <tom@tromey.com>
7830
7831         * solib-svr4.c (disable_probes_interface): Remove parameter.
7832         (svr4_handle_solib_event): Use make_scope_exit.
7833
7834 2019-03-06  Tom Tromey  <tom@tromey.com>
7835
7836         * remote.c (struct stop_reply_deleter): Remove.
7837         (stop_reply_up): Update.
7838         (struct stop_reply): Derive from notif_event.  Don't typedef.
7839         <regcache>: Now a std::vector.
7840         (stop_reply_xfree): Remove.
7841         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7842         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7843         (remote_target::discard_pending_stop_replies): Use delete.
7844         (remote_target::remote_parse_stop_reply): Update.
7845         (remote_target::process_stop_reply): Update.
7846         * remote-notif.h (struct notif_event): Add virtual destructor.
7847         Remove "dtr" member.
7848         (struct notif_client) <alloc_event>: Return a unique_ptr.
7849         (notif_event_xfree): Don't declare.
7850         (notif_event_up): New typedef.
7851         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7852         (notif_event_xfree, do_notif_event_xfree): Remove.
7853         (remote_notif_state_xfree): Update.
7854
7855 2019-03-06  Tom Tromey  <tom@tromey.com>
7856
7857         * infrun.c (displaced_step_clear_cleanup): Now a
7858         forward_scope_exit type.
7859         (displaced_step_prepare_throw): Update.
7860         (displaced_step_fixup): Update.
7861
7862 2019-03-06  Tom Tromey  <tom@tromey.com>
7863
7864         * inferior.h (class inferior): Update comment.
7865         * gdbthread.h (class thread_info): Update comment.
7866
7867 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7868             Tom Tromey  <tom@tromey.com>
7869
7870         * stabsread.h (struct stab_section_list): Remove.
7871         (coffstab_build_psymtabs): Update.
7872         * dbxread.c (symbuf_sections): Now a std::vector.
7873         (sect_idx): New global.
7874         (fill_symbuf): Update.
7875         (coffstab_build_psymtabs): Change type of stabsects parameter.
7876         Update.
7877         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7878         std::vector.
7879         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7880         (coff_locate_sections): Update.
7881         (coff_symfile_read): Remove cleanups.  Update.
7882         (init_stringtab): Add storage parameter.
7883         (free_stringtab, free_stringtab_cleanup): Remove.
7884         (init_lineno): Add storage parameter.
7885         (free_linetab, free_linetab_cleanup): Remove.
7886
7887 2019-03-06  Pedro Alves  <palves@redhat.com>
7888
7889         * linux-fork.c (fork_info::clobber_regs): Delete.
7890         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7891         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7892         comment.  Adjust.
7893         (scoped_switch_fork_info::scoped_switch_fork_info)
7894         (checkpoint_command, linux_fork_context): Adjust
7895         fork_save_infrun_state calls.
7896
7897 2019-03-06  Pedro Alves  <palves@redhat.com>
7898
7899         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7900         (inf_has_multiple_threads): Return 'bool' and rewrite using
7901         inferior_info::threads().
7902
7903 2019-03-06  Pedro Alves  <palves@redhat.com>
7904
7905         * linux-fork.c: Include <list>.
7906         (fork_list): Now a std::list instance.
7907         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7908         (forks_exist_p, find_last_fork): Adjust.
7909         (new_fork): Delete.
7910         (one_fork_p): New.
7911         (add_fork): Adjust.
7912         (free_fork): Delete, folded into fork_info::~fork_info().
7913         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7914         Adjust.
7915         (init_fork_list): Delete.
7916         (linux_fork_killall, linux_fork_mourn_inferior)
7917         (linux_fork_detach, info_checkpoints_command): Adjust.
7918         (_initialize_linux_fork): No longer call init_fork_list.
7919
7920 2019-03-06  Pedro Alves  <palves@redhat.com>
7921
7922         * linux-fork.c (new_fork): New, split out of ...
7923         (add_fork): ... this.  Return void.  Move "first fork" special
7924         case from here, to ...
7925         (checkpoint_command): ... here.
7926         * linux-linux.h (add_fork): Return void.
7927
7928 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7929
7930         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7931
7932 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7933             Chris January  <chris.january@arm.com>
7934             David Lecomber  <david.lecomber@arm.com>
7935
7936         * f-exp.y: New token, UNOP_INTRINSIC.
7937         (exp): New pattern using UNOP_INTRINSIC token.
7938         (f77_keywords): Add 'abs' keyword.
7939         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7940         (value_from_host_double): New function.
7941         (evaluate_subexp_f): Support UNOP_ABS.
7942
7943 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7944
7945         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7946         types.
7947
7948 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7949
7950         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7951         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7952         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7953
7954 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7955
7956         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7957
7958 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7959             Chris January  <chris.january@arm.com>
7960
7961         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7962         * f-exp.y: Define 'KIND' token.
7963         (exp): New pattern for KIND expressions.
7964         (ptype): Handle types with a kind extension.
7965         (direct_abs_decl): Extend to spot kind extensions.
7966         (f77_keywords): Add 'kind' to the list.
7967         (push_kind_type): New function.
7968         (convert_to_kind_type): New function.
7969         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7970         * parse.c (operator_length_standard): Likewise.
7971         * parser-defs.h (enum type_pieces): Add tp_kind.
7972         * std-operator.def: Add UNOP_KIND.
7973
7974 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7975
7976         * f-exp.y (f_parse): Set yydebug.
7977
7978 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7979
7980         * f-lang.c (evaluate_subexp_f): New function.
7981         (exp_descriptor_f): New global.
7982         (f_language_defn): Use exp_descriptor_f instead of
7983         exp_descriptor_standard.
7984
7985 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7986
7987         * f-exp.y (struct token): Add comments.
7988         (dot_ops): Remove uppercase versions and the end marker.
7989         (f77_keywords): Likewise.
7990         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7991         entries in the dot_ops array are case insensitive, and use
7992         strncasecmp to compare strings.  Also some whitespace cleanup in
7993         this area.  Similar for the f77_keywords array, except entries in
7994         this list might be case sensitive.
7995
7996 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7997
7998         * f-exp.y (struct f77_boolean_val): Add comments.
7999         (boolean_values): Remove uppercase versions, and end marker.
8000         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
8001         and use strncasecmp to achieve case insensitivity.  Additionally,
8002         perform whitespace cleanup around this code.
8003
8004 2019-03-06  Tom Tromey  <tromey@adacore.com>
8005
8006         * remote-sim.c (gdbsim_target_open): Use result of
8007         gdb_argv::release.
8008
8009 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
8010         Dirk Schubert  <dirk.schubert@arm.com>
8011         Chris January  <chris.january@arm.com>
8012
8013         * eval.c (evaluate_subexp_standard): Call Fortran argument
8014         wrapping logic.
8015         * f-lang.c (struct value): A value which can be passed into a
8016         Fortran function call.
8017         (fortran_argument_convert): Wrap Fortran arguments in a pointer
8018         where appropriate.
8019         (struct type): Value ready for a Fortran function call.
8020         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
8021         is needed.
8022         * f-lang.h (fortran_argument_convert): Declaration.
8023         (fortran_preserve_arg_pointer): Declaration.
8024         * infcall.c (value_arg_coerce): Call Fortran argument logic.
8025
8026 2019-03-05  Tom Tromey  <tromey@adacore.com>
8027
8028         * python/py-prettyprint.c (print_string_repr): Remove #if.
8029         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
8030
8031 2019-03-05  Tom Tromey  <tromey@adacore.com>
8032
8033         * target.c (the_dummy_target): Move later.  Change type to
8034         "dummy_target".
8035         (initialize_targets): Don't initialize the_dummy_target.
8036
8037 2019-03-05  Tom Tromey  <tromey@adacore.com>
8038
8039         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
8040         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
8041
8042 2019-03-05  Tom Tromey  <tromey@adacore.com>
8043
8044         * windows-nat.c (windows_nat_target::attach)
8045         (windows_nat_target::detach): Don't call gdb_flush.
8046         * valprint.c (generic_val_print, val_print, val_print_string):
8047         Don't call gdb_flush.
8048         * utils.c (defaulted_query): Don't call gdb_flush.
8049         * typeprint.c (print_type_scalar): Don't call gdb_flush.
8050         * target.c (target_announce_detach): Don't call gdb_flush.
8051         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
8052         * remote.c (extended_remote_target::attach): Don't call
8053         gdb_flush.
8054         * procfs.c (procfs_target::detach): Don't call gdb_flush.
8055         * printcmd.c (do_examine): Don't call gdb_flush.
8056         (info_display_command): Don't call gdb_flush.
8057         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
8058         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
8059         * memattr.c (info_mem_command): Don't call gdb_flush.
8060         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
8061         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
8062         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
8063         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
8064         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
8065         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
8066         (gnu_nat_target::detach): Don't call gdb_flush.
8067         * f-valprint.c (f_val_print): Don't call gdb_flush.
8068         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
8069         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
8070         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
8071         gdb_flush.
8072         * c-valprint.c (c_val_print): Don't call gdb_flush.
8073         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
8074
8075 2019-03-05  Tom Tromey  <tromey@adacore.com>
8076
8077         * varobj.c (update_dynamic_varobj_children): Update.
8078         (install_default_visualizer): Use reset, not release.
8079         * value.c (set_internalvar): Update.
8080         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
8081         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
8082         ATTRIBUTE_UNUSED_RESULT.
8083
8084 2019-03-05  Tom Tromey  <tromey@adacore.com>
8085
8086         * remote.c (class scoped_remote_fd) <release>: Add
8087         ATTRIBUTE_UNUSED_RESULT.
8088
8089 2019-03-05  Tom Tromey  <tromey@adacore.com>
8090
8091         * macroexp.c (struct macro_buffer) <release>: Add
8092         ATTRIBUTE_UNUSED_RESULT.
8093
8094 2019-03-05  Tom Tromey  <tromey@adacore.com>
8095
8096         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
8097         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
8098         ATTRIBUTE_UNUSED_RESULT.
8099
8100 2019-03-05  Tom Tromey  <tromey@adacore.com>
8101
8102         * common/scoped_fd.h (class scoped_fd) <release>: Add
8103         ATTRIBUTE_UNUSED_RESULT.
8104
8105 2019-03-05  Tom Tromey  <tromey@adacore.com>
8106
8107         * parser-defs.h (struct parser_state) <release>: Add
8108         ATTRIBUTE_UNUSED_RESULT.
8109
8110 2019-03-05  Tom Tromey  <tromey@adacore.com>
8111
8112         * utils.h (class gdb_argv) <release>: Add
8113         ATTRIBUTE_UNUSED_RESULT.
8114         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
8115
8116 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
8117
8118         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
8119         for-loop range, to avoid compiler warnings.
8120
8121         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
8122         avoid compiler warnings about unused variables.
8123
8124         * NEWS: Mention end of support for native debugging on MS-Windows
8125         before XP.
8126
8127         PR gdb/24292
8128         * common/netstuff.c:
8129         * gdbserver/gdbreplay.c
8130         * gdbserver/remote-utils.c:
8131         * ser-tcp.c:
8132         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
8133         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
8134         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
8135         'getaddrinfo' and 'freeaddrinfo' were not available before
8136         Windows XP, and mingw.org's MinGW headers by default define
8137         _WIN32_WINNT to 0x500.
8138
8139 2019-03-01  Gary Benson <gbenson@redhat.com>
8140
8141         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
8142
8143 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
8144             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
8145
8146         PR gdb/8527
8147         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
8148         set_sigint_trap, clear_sigint_trap.
8149
8150 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8151
8152         * target.c (target_detach): Clear the regcache and the
8153         frame cache.
8154
8155 2019-02-27  Pedro Alves  <palves@redhat.com>
8156
8157         * utils.c (set_screen_size): When we cap the height/width sizes,
8158         tweak the corresponding command variable to show "unlimited":
8159
8160 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
8161             Pedro Alves  <palves@redhat.com>
8162
8163         * utils.c (set_screen_size): Reduce "infinite" rows and columns
8164         before calling rl_set_screen_size.
8165
8166 2019-02-27  Tom Tromey  <tromey@adacore.com>
8167
8168         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8169         define.
8170         * python/py-value.c: Remove Python 2.4 workaround.
8171         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8172         workaround.
8173         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8174         Python 2.4 workaround.
8175         * python/python-internal.h: Remove Python 2.4 comment.
8176         (Py_ssize_t): Don't define.
8177         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8178         (gdb_Py_DECREF): Remove Python 2.4 workaround.
8179         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8180         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8181         * python/python.c (do_start_initialization): Remove Python 2.4
8182         workaround.
8183         * python/py-prettyprint.c (class dummy_python_frame): Remove.
8184         (print_children): Remove Python 2.4 workaround.
8185         * python/py-inferior.c (buffer_procs): Remove Python 2.4
8186         workaround.
8187         (CHARBUFFERPROC_NAME): Remove.
8188         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8189         Python 2.4 workaround.
8190
8191 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8192
8193         * NEWS: Note minimum Python version.
8194
8195 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8196
8197         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8198         code from these functions.  Remove corresponding ifdefs.  Use
8199         Py_buffer_up instead of explicit calls to PyBuffer_Release.
8200         Remove gotos and target of gotos.
8201         (infpy_search_memory): Likewise.
8202
8203 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8204
8205         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8206         (hppa_gdbarch_init): Don't register deleted functions with
8207         gdbarch.
8208
8209 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8210
8211         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8212         (h8300_unwind_sp): Delete.
8213         (h8300_dummy_id): Delete.
8214         (h8300_gdbarch_init): Don't register deleted functions with
8215         gdbarch.
8216
8217 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8218
8219         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8220         (ft32_unwind_pc): Delete.
8221         (ft32_unwind_sp): Delete.
8222         (ft32_gdbarch_init): Don't register deleted functions with
8223         gdbarch.
8224
8225 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8226
8227         * gdb/frv-tdep.c (frv_dummy_id): Delete.
8228         (frv_unwind_pc): Delete.
8229         (frv_unwind_sp): Delete.
8230         (frv_gdbarch_init): Don't register deleted functions with
8231         gdbarch.
8232
8233 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8234
8235         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8236         (riscv_unwind_pc): Delete.
8237         (riscv_unwind_sp): Delete.
8238         (riscv_gdbarch_init): Don't register deleted functions with
8239         gdbarch.
8240
8241 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8242
8243         * gdb/csky-tdep.c (csky_dummy_id): Delete.
8244         (csky_unwind_pc): Delete.
8245         (csky_unwind_sp): Delete.
8246         (csky_gdbarch_init): Don't register deleted functions with
8247         gdbarch.
8248
8249 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8250
8251         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8252         (cris_unwind_pc): Delete.
8253         (cris_unwind_sp): Delete.
8254         (cris_gdbarch_init): Don't register deleted functions with
8255         gdbarch.
8256
8257 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8258
8259         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8260         (bfin_unwind_pc): Delete.
8261         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8262
8263 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8264
8265         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8266         (arm_unwind_pc): Delete.
8267         (arm_unwind_sp): Delete.
8268         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8269
8270 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8271
8272         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8273         (arc_unwind_pc): Delete.
8274         (arc_unwind_sp): Delete.
8275         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8276
8277 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8278
8279         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8280         (alpha_unwind_pc): Delete.
8281         (alpha_gdbarch_init): Don't register deleted functions with
8282         gdbarch.
8283
8284 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8285
8286         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8287         (aarch64_unwind_pc): Delete.
8288         (aarch64_unwind_sp): Delete.
8289         (aarch64_gdbarch_init): Don't register deleted functions with
8290         gdbarch.
8291
8292 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8293
8294         * gdbtypes.c (type_align): Don't consider static members when
8295         computing structure alignment.
8296
8297 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8298
8299         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8300         return 0 for other types.
8301         * arch-utils.c (default_type_align): Always return 0.
8302         * gdbarch.h: Regenerate.
8303         * gdbarch.sh (type_align): Extend comment.
8304         * gdbtypes.c (type_align): Add additional comments, always call
8305         gdbarch_type_align before applying the default rules.
8306         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8307         generic code will then apply a suitable default.
8308         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8309         types, return 0 for other types.
8310
8311 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8312
8313         * NEWS: Create a new section for the next release branch.
8314         Rename the section of the current branch, now that it has
8315         been cut.
8316
8317 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8318
8319         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8320         * version.in: Bump version to 8.3.50.DATE-git.
8321
8322 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8323
8324         * aix-thread.c (ptid_cmp): Remove unused variable.
8325         (get_signaled_thread): Likewise.
8326         (store_regs_user_thread): Likewise.
8327         (store_regs_kernel_thread): Likewise.
8328         (fetch_regs_kernel_thread): Remove shadowed variable.
8329
8330 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8331
8332         * features/riscv/32bit-cpu.xml: Add register numbers.
8333         * features/riscv/32bit-fpu.c: Regenerate.
8334         * features/riscv/32bit-fpu.xml: Add register numbers.
8335         * features/riscv/64bit-cpu.xml: Add register numbers.
8336         * features/riscv/64bit-fpu.c: Regenerate.
8337         * features/riscv/64bit-fpu.xml: Add register numbers.
8338
8339 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8340
8341         * NEWS: Mention two argument form of gdb.Value constructor.
8342         * python/py-value.c (convert_buffer_and_type_to_value): New
8343         function.
8344         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8345         Add support for handling an optional second argument.  Call
8346         convert_buffer_and_type_to_value as appropriate.
8347         * python/python-internal.h (Py_buffer_deleter): New struct.
8348         (Py_buffer_up): New typedef.
8349
8350 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8351
8352         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8353         instead of releasing ownership.
8354
8355 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8356
8357         * dwarf2read.c (open_and_init_dwp_file): Call
8358         elf_numsections instead of bfd_count_sections to initialize
8359         dwp_file->num_sections.
8360
8361 2019-02-25  Tom Tromey  <tromey@adacore.com>
8362
8363         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8364
8365 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8366
8367         * gcore.in: Add '--readnever' option when invoking GDB.
8368
8369 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8370
8371         * MAINTAINERS: Update my email address.
8372
8373 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8374
8375         * build-id.c (build_id_to_debug_bfd_1): New function.
8376         (build_id_to_debug_bfd): Look for separate debug file in
8377         sysroot.
8378
8379 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8380
8381         * gdbarch.sh: Update the copyright year range that is placed into
8382         generated files.
8383
8384 2019-02-22  Keith Seitz  <keiths@redhat.com>
8385
8386         PR symtab/23853
8387         * linespec.c (create_sals_line_offset): Search for the default
8388         symtab's filename instead of its fullname.
8389
8390 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8391
8392         * NEWS: Update style defaults.
8393
8394 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8395
8396         * main.c (captured_main_1): Disable styling in batch mode.
8397
8398 2019-02-20  Tom Tromey  <tom@tromey.com>
8399
8400         * symtab.c (symtab_symbol_info): Fix typos.
8401
8402 2019-02-20  Tom Tromey  <tromey@adacore.com>
8403
8404         * findcmd.c (_initialize_mem_search): Use upper case for
8405         metasyntactic variables.
8406
8407 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8408
8409         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8410         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8411
8412 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8413
8414         * top.h (source_file_name): Change to std::string.
8415         * top.c (source_file_name): Likewise.
8416         (command_line_input): Adjust.
8417         * cli/cli-script.c (script_from_file): Adjust.
8418
8419 2019-02-19  Tom Tromey  <tromey@adacore.com>
8420
8421         * ravenscar-thread.c
8422         (ravenscar_thread_target::update_thread_list): Don't call
8423         ada_build_task_list.
8424         * ada-lang.h (ada_build_task_list): Don't declare.
8425         * ada-tasks.c (struct ada_tasks_inferior_data)
8426         <task_list_valid_p>: Now bool.
8427         (read_known_tasks, ada_task_list_changed)
8428         (ada_tasks_invalidate_inferior_data): Update.
8429         (read_known_tasks_array): Return bool.
8430         (read_known_tasks_list): Likewise.
8431         (read_known_tasks): Return void.
8432         (ada_build_task_list): Now static.
8433
8434 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8435
8436         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8437         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8438
8439 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8440
8441         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8442         variant for ada_tasks_pspace_data_handle and
8443         ada_tasks_inferior_data_handle.
8444         (ada_tasks_pspace_data_cleanup): New function.
8445         (ada_tasks_inferior_data_cleanup): New function.
8446
8447 2019-02-17  Tom Tromey  <tom@tromey.com>
8448
8449         * macrotab.h (macro_source_fullname): Return a std::string.
8450         * macrotab.c (macro_include, check_for_redefinition)
8451         (macro_undef, macro_lookup_definition, foreach_macro)
8452         (foreach_macro_in_scope): Update.
8453         (macro_source_fullname): Return a std::string.
8454         * macrocmd.c (show_pp_source_pos): Update.
8455
8456 2019-02-17  Tom Tromey  <tom@tromey.com>
8457
8458         * macrocmd.c (show_pp_source_pos): Style the file names.
8459
8460 2019-02-17  Tom Tromey  <tom@tromey.com>
8461
8462         PR tui/24197:
8463         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8464
8465 2019-02-17  Tom Tromey  <tom@tromey.com>
8466
8467         * ada-lang.c (user_select_syms): Use filtered printing.
8468         * utils.c (wrap_style): New global.
8469         (desired_style): Remove.
8470         (emit_style_escape): Add stream parameter.
8471         (set_output_style, reset_terminal_style, prompt_for_continue):
8472         Update.
8473         (flush_wrap_buffer): Only flush gdb_stdout.
8474         (wrap_here): Set wrap_style.
8475         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8476         treat escape sequences as a character.  Change when wrap buffer is
8477         flushed.
8478         (fputs_styled): Do not set the output style when the default is
8479         requested.
8480         * ui-style.h (struct ui_file_style) <is_default>: New method.
8481         * source.c (print_source_lines_base): Emit escape sequences in one
8482         piece.
8483
8484 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8485
8486         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8487         integers and enumeration types.
8488
8489 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8490
8491         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8492         instead of lookup_symbol_in_language
8493         (do_exact_match): New function.
8494         (ada_get_symbol_name_matcher): Return do_exact_match when
8495         doing a verbatim match.
8496
8497 2019-02-15  Tom Tromey  <tromey@adacore.com>
8498
8499         * ravenscar-thread.c (ravenscar_thread_target::resume)
8500         (ravenscar_thread_target::wait): Special case wildcard requests.
8501
8502 2019-02-15  Tom Tromey  <tromey@adacore.com>
8503
8504         * ravenscar-thread.c (base_ptid): Remove.
8505         (struct ravenscar_thread_target) <close>: New method.
8506         <m_base_ptid>: New member.
8507         <update_inferior_ptid, active_task, task_is_currently_active,
8508         runtime_initialized>: Declare methods.
8509         <ravenscar_thread_target>: Add constructor.
8510         (ravenscar_thread_target::task_is_currently_active)
8511         (ravenscar_thread_target::update_inferior_ptid)
8512         (ravenscar_runtime_initialized): Rename.  Now methods.
8513         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8514         (ravenscar_thread_target::update_thread_list): Update.
8515         (ravenscar_thread_target::active_task): Now method.
8516         (ravenscar_thread_target::store_registers)
8517         (ravenscar_thread_target::prepare_to_store)
8518         (ravenscar_thread_target::prepare_to_store)
8519         (ravenscar_thread_target::mourn_inferior): Update.
8520         (ravenscar_inferior_created): Use "new" to create target.
8521         (ravenscar_thread_target::get_ada_task_ptid): Update.
8522         (_initialize_ravenscar): Don't initialize base_ptid.
8523         (ravenscar_ops): Remove global.
8524
8525 2019-02-15  Tom Tromey  <tromey@adacore.com>
8526
8527         * target.h (push_target): Declare new overload.
8528         * target.c (push_target): New overload, taking an rvalue reference.
8529         * remote.c (remote_target::open_1): Use push_target overload.
8530         * corelow.c (core_target_open): Use push_target overload.
8531
8532 2019-02-15  Tom Tromey  <tromey@adacore.com>
8533
8534         * ravenscar-thread.c (is_ravenscar_task)
8535         (ravenscar_task_is_currently_active): Return bool.
8536         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8537         (_initialize_ravenscar): Remove "(void)".
8538         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8539         Return bool.
8540
8541 2019-02-15  Tom Tromey  <tromey@adacore.com>
8542
8543         * ravenscar-thread.c (ravenscar_runtime_initializer)
8544         (has_ravenscar_runtime, get_running_thread_id)
8545         (ravenscar_thread_target::resume): Fix indentation.
8546
8547 2019-02-15  Tom Tromey  <tromey@adacore.com>
8548
8549         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8550         from ravenscar_arch_ops.
8551         (sparc_ravenscar_ops::fetch_registers)
8552         (sparc_ravenscar_ops::store_registers): Now methods.
8553         (sparc_ravenscar_prepare_to_store): Remove.
8554         (sparc_ravenscar_ops): Redefine.
8555         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8556         methods and destructor.  Remove members.
8557         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8558         (ravenscar_thread_target::store_registers)
8559         (ravenscar_thread_target::prepare_to_store): Update.
8560         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8561         Remove.
8562         (struct ppc_ravenscar_powerpc_ops): Derive from
8563         ravenscar_arch_ops.
8564         (ppc_ravenscar_powerpc_ops::fetch_registers)
8565         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8566         (ppc_ravenscar_powerpc_ops): Redefine.
8567         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8568         (ppc_ravenscar_e500_ops::fetch_registers)
8569         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8570         (ppc_ravenscar_e500_ops): Redefine.
8571         * aarch64-ravenscar-thread.c
8572         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8573         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8574         (aarch64_ravenscar_fetch_registers)
8575         (aarch64_ravenscar_store_registers): Now methods.
8576         (aarch64_ravenscar_ops): Redefine.
8577
8578 2019-02-15  Tom Tromey  <tromey@adacore.com>
8579
8580         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8581         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8582         (ravenscar_thread_target::stopped_by_watchpoint)
8583         (ravenscar_thread_target::stopped_data_address)
8584         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8585
8586 2019-02-15  Tom Tromey  <tromey@adacore.com>
8587
8588         * ravenscar-thread.c: Fix some typos.
8589
8590 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8591             Tom Tromey  <tromey@adacore.com>
8592
8593         * ada-lang.c (ada_exception_sal): Change addr_string to a
8594         std::string.
8595         (create_ada_exception_catchpoint): Update.
8596
8597 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8598             Tom Tromey  <tromey@adacore.com>
8599
8600         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8601         (bp_location_ops): Remove.
8602         (base_breakpoint_allocate_location): Update.
8603         (free_bp_location): Update.
8604         * ada-lang.c (class ada_catchpoint_location)
8605         <ada_catchpoint_location>: Remove ops parameter.
8606         (ada_catchpoint_location_dtor): Remove.
8607         (ada_catchpoint_location_ops): Remove.
8608         (allocate_location_exception): Update.
8609         * breakpoint.h (struct bp_location_ops): Remove.
8610         (class bp_location) <bp_location>: Remove bp_location_ops
8611         parameter.
8612         <~bp_location>: Add destructor.
8613         <ops>: Remove.
8614
8615 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8616             Pedro Alves  <palves@redhat.com>
8617
8618         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8619         'PATH_MAX'.
8620
8621 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8622             Samuel Thibault  <samuel.thibault@gnu.org>
8623             Thomas Schwinge  <thomas@codesourcery.com>
8624
8625         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8626         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8627
8628 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8629
8630         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8631         (check_empty): Use "const char *".
8632
8633         * gnu-nat.c (gnu_nat_target::detach): Instead of
8634         'detach_inferior (pid)' call
8635         'detach_inferior (find_inferior_pid (pid))'.
8636
8637         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8638         'nat/fork-inferior.o'.
8639         * gnu-nat.c: #include "nat/fork-inferior.h".
8640
8641         * gnu-nat.c (gnu_nat_target::detach): Instead of
8642         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8643         * gnu-nat.h: #include "inf-child.h".
8644         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8645         'i386_gnu_nat_target::fetch_registers'.
8646         (gnu_store_registers): Rename/move to
8647         'i386_gnu_nat_target::store_registers'.
8648
8649         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8650         * gnu-nat.h (mach_thread_info): New function.
8651         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8652
8653         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8654
8655 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8656
8657         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8658
8659 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8660
8661         * windows-nat.c (windows_add_thread): Add new parameter
8662         "main_thread_p" with default value set to false.  Update
8663         function documentation as well as all callers.
8664         (windows_delete_thread): Likewise.
8665         (fake_create_process): Update call to windows_add_thread.
8666         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8667         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8668         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8669         call to windows_delete_thread.
8670
8671 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8672
8673         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8674
8675 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8676
8677         * symfile.c (find_separate_debug_file): Use canonical path of
8678         sysroot with child_path instead of gdb_sysroot if it is valid.
8679
8680 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8681
8682         * symfile.c (find_separate_debug_file): Use child_path to
8683         determine if an object file is under a sysroot.
8684
8685 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8686
8687         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8688         unittests/child-path-selftests.c.
8689         * common/pathstuff.c (child_path): New function.
8690         * common/pathstuff.h (child_path): New prototype.
8691         * unittests/child-path-selftests.c: New file.
8692
8693 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8694
8695         * symfile.c (find_separate_debug_file): Look for separate debug
8696         files in debug directories under the sysroot.
8697
8698 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8699
8700         * symtab.h (struct minimal_symbol data_p): New const method.
8701         (struct minimal_symbol text_p): Likewise.
8702         * symtab.c (output_source_filename): Use file name style
8703         to print file name.
8704         (print_symbol_info): Likewise.
8705         (print_msymbol_info): Use address style to print addresses.
8706         Use function name style to print executable text symbols.
8707         (expand_symtab_containing_pc): Use data_p.
8708         (find_pc_sect_compunit_symtab): Likewise.
8709
8710 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8711
8712         * breakpoint.c (describe_other_breakpoints): Use address style
8713         to print addresses.
8714         (say_where): Likewise.
8715
8716 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8717
8718         * ada-typeprint.c (print_func_type): Print function name
8719         style to print function name.
8720         * c-typeprint.c (c_print_type_1): Likewise.
8721
8722 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8723
8724         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8725         for execve.
8726
8727 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8728
8729         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8730         type_stack.
8731
8732 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8733
8734         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8735         TYPE_CODE_REF types.
8736
8737 2019-02-08  Jim Wilson  <jimw@sifive.com>
8738
8739         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8740         (riscv_linux_fregset): New.
8741         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8742
8743 2019-02-07  Tom Tromey  <tom@tromey.com>
8744
8745         * thread.c (thread_cancel_execution_command): Update.
8746         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8747         methods.
8748         (struct thread_fsm_ops): Remove.
8749         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8750         (thread_fsm_should_stop, thread_fsm_return_value)
8751         (thread_fsm_set_finished, thread_fsm_finished_p)
8752         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8753         Don't declare.
8754         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8755         * infrun.c (clear_proceed_status_thread)
8756         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8757         (print_stop_event): Update.
8758         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8759         Add constructor.
8760         (step_command_fsm_ops): Remove.
8761         (new_step_command_fsm): Remove.
8762         (step_1): Update.
8763         (step_command_fsm::should_stop): Rename from
8764         step_command_fsm_should_stop.
8765         (step_command_fsm::clean_up): Rename from
8766         step_command_fsm_clean_up.
8767         (step_command_fsm::do_async_reply_reason): Rename from
8768         step_command_fsm_async_reply_reason.
8769         (struct until_next_fsm): Inherit from thread_fsm.  Add
8770         constructor.
8771         (until_next_fsm_ops): Remove.
8772         (new_until_next_fsm): Remove.
8773         (until_next_fsm::should_stop): Rename from
8774         until_next_fsm_should_stop.
8775         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8776         (until_next_fsm::do_async_reply_reason): Rename from
8777         until_next_fsm_async_reply_reason.
8778         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8779         constructor.  Change type of breakpoint.
8780         (finish_command_fsm_ops): Remove.
8781         (new_finish_command_fsm): Remove.
8782         (finish_command_fsm::should_stop): Rename from
8783         finish_command_fsm_should_stop.
8784         (finish_command_fsm::clean_up): Rename from
8785         finish_command_fsm_clean_up.
8786         (finish_command_fsm::return_value): Rename from
8787         finish_command_fsm_return_value.
8788         (finish_command_fsm::do_async_reply_reason): Rename from
8789         finish_command_fsm_async_reply_reason.
8790         (finish_command): Update.
8791         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8792         Add constructor.
8793         (call_thread_fsm_ops): Remove.
8794         (call_thread_fsm::call_thread_fsm): Rename from
8795         new_call_thread_fsm.
8796         (call_thread_fsm::should_stop): Rename from
8797         call_thread_fsm_should_stop.
8798         (call_thread_fsm::should_notify_stop): Rename from
8799         call_thread_fsm_should_notify_stop.
8800         (run_inferior_call, call_function_by_hand_dummy): Update.
8801         * cli/cli-interp.c (should_print_stop_to_console): Update.
8802         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8803         Add constructor.  Change type of location_breakpoint,
8804         caller_breakpoint.
8805         (until_break_fsm_ops): Remove.
8806         (new_until_break_fsm): Remove.
8807         (until_break_fsm::should_stop): Rename from
8808         until_break_fsm_should_stop.
8809         (until_break_fsm::clean_up): Rename from
8810         until_break_fsm_clean_up.
8811         (until_break_fsm::do_async_reply_reason): Rename from
8812         until_break_fsm_async_reply_reason.
8813         (until_break_command): Update.
8814         * thread-fsm.c: Remove.
8815         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8816
8817 2019-02-07  Tom Tromey  <tom@tromey.com>
8818
8819         * yy-remap.h: Add include guard.
8820         * xtensa-tdep.h: Add include guard.
8821         * xcoffread.h: Rename include guard.
8822         * varobj-iter.h: Add include guard.
8823         * tui/tui.h: Rename include guard.
8824         * tui/tui-winsource.h: Rename include guard.
8825         * tui/tui-wingeneral.h: Rename include guard.
8826         * tui/tui-windata.h: Rename include guard.
8827         * tui/tui-win.h: Rename include guard.
8828         * tui/tui-stack.h: Rename include guard.
8829         * tui/tui-source.h: Rename include guard.
8830         * tui/tui-regs.h: Rename include guard.
8831         * tui/tui-out.h: Rename include guard.
8832         * tui/tui-layout.h: Rename include guard.
8833         * tui/tui-io.h: Rename include guard.
8834         * tui/tui-hooks.h: Rename include guard.
8835         * tui/tui-file.h: Rename include guard.
8836         * tui/tui-disasm.h: Rename include guard.
8837         * tui/tui-data.h: Rename include guard.
8838         * tui/tui-command.h: Rename include guard.
8839         * tic6x-tdep.h: Add include guard.
8840         * target/waitstatus.h: Rename include guard.
8841         * target/wait.h: Rename include guard.
8842         * target/target.h: Rename include guard.
8843         * target/resume.h: Rename include guard.
8844         * target-float.h: Rename include guard.
8845         * stabsread.h: Add include guard.
8846         * rs6000-tdep.h: Add include guard.
8847         * riscv-fbsd-tdep.h: Add include guard.
8848         * regformats/regdef.h: Rename include guard.
8849         * record.h: Rename include guard.
8850         * python/python.h: Rename include guard.
8851         * python/python-internal.h: Rename include guard.
8852         * python/py-stopevent.h: Rename include guard.
8853         * python/py-ref.h: Rename include guard.
8854         * python/py-record.h: Rename include guard.
8855         * python/py-record-full.h: Rename include guard.
8856         * python/py-record-btrace.h: Rename include guard.
8857         * python/py-instruction.h: Rename include guard.
8858         * python/py-events.h: Rename include guard.
8859         * python/py-event.h: Rename include guard.
8860         * procfs.h: Add include guard.
8861         * proc-utils.h: Add include guard.
8862         * p-lang.h: Add include guard.
8863         * or1k-tdep.h: Rename include guard.
8864         * observable.h: Rename include guard.
8865         * nto-tdep.h: Rename include guard.
8866         * nat/x86-linux.h: Rename include guard.
8867         * nat/x86-linux-dregs.h: Rename include guard.
8868         * nat/x86-gcc-cpuid.h: Add include guard.
8869         * nat/x86-dregs.h: Rename include guard.
8870         * nat/x86-cpuid.h: Rename include guard.
8871         * nat/ppc-linux.h: Rename include guard.
8872         * nat/mips-linux-watch.h: Rename include guard.
8873         * nat/linux-waitpid.h: Rename include guard.
8874         * nat/linux-ptrace.h: Rename include guard.
8875         * nat/linux-procfs.h: Rename include guard.
8876         * nat/linux-osdata.h: Rename include guard.
8877         * nat/linux-nat.h: Rename include guard.
8878         * nat/linux-namespaces.h: Rename include guard.
8879         * nat/linux-btrace.h: Rename include guard.
8880         * nat/glibc_thread_db.h: Rename include guard.
8881         * nat/gdb_thread_db.h: Rename include guard.
8882         * nat/gdb_ptrace.h: Rename include guard.
8883         * nat/fork-inferior.h: Rename include guard.
8884         * nat/amd64-linux-siginfo.h: Rename include guard.
8885         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8886         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8887         * nat/aarch64-linux.h: Rename include guard.
8888         * nat/aarch64-linux-hw-point.h: Rename include guard.
8889         * mn10300-tdep.h: Add include guard.
8890         * mips-linux-tdep.h: Add include guard.
8891         * mi/mi-parse.h: Rename include guard.
8892         * mi/mi-out.h: Rename include guard.
8893         * mi/mi-main.h: Rename include guard.
8894         * mi/mi-interp.h: Rename include guard.
8895         * mi/mi-getopt.h: Rename include guard.
8896         * mi/mi-console.h: Rename include guard.
8897         * mi/mi-common.h: Rename include guard.
8898         * mi/mi-cmds.h: Rename include guard.
8899         * mi/mi-cmd-break.h: Rename include guard.
8900         * m2-lang.h: Add include guard.
8901         * location.h: Rename include guard.
8902         * linux-record.h: Rename include guard.
8903         * linux-nat.h: Add include guard.
8904         * linux-fork.h: Add include guard.
8905         * i386-darwin-tdep.h: Rename include guard.
8906         * hppa-linux-offsets.h: Add include guard.
8907         * guile/guile.h: Rename include guard.
8908         * guile/guile-internal.h: Rename include guard.
8909         * gnu-nat.h: Rename include guard.
8910         * gdb-stabs.h: Rename include guard.
8911         * frv-tdep.h: Add include guard.
8912         * f-lang.h: Add include guard.
8913         * event-loop.h: Add include guard.
8914         * darwin-nat.h: Rename include guard.
8915         * cp-abi.h: Rename include guard.
8916         * config/sparc/nm-sol2.h: Rename include guard.
8917         * config/nm-nto.h: Rename include guard.
8918         * config/nm-linux.h: Add include guard.
8919         * config/i386/nm-i386gnu.h: Rename include guard.
8920         * config/djgpp/nl_types.h: Rename include guard.
8921         * config/djgpp/langinfo.h: Rename include guard.
8922         * compile/gcc-cp-plugin.h: Add include guard.
8923         * compile/gcc-c-plugin.h: Add include guard.
8924         * compile/compile.h: Rename include guard.
8925         * compile/compile-object-run.h: Rename include guard.
8926         * compile/compile-object-load.h: Rename include guard.
8927         * compile/compile-internal.h: Rename include guard.
8928         * compile/compile-cplus.h: Rename include guard.
8929         * compile/compile-c.h: Rename include guard.
8930         * common/xml-utils.h: Rename include guard.
8931         * common/x86-xstate.h: Rename include guard.
8932         * common/version.h: Rename include guard.
8933         * common/vec.h: Rename include guard.
8934         * common/tdesc.h: Rename include guard.
8935         * common/selftest.h: Rename include guard.
8936         * common/scoped_restore.h: Rename include guard.
8937         * common/scoped_mmap.h: Rename include guard.
8938         * common/scoped_fd.h: Rename include guard.
8939         * common/safe-iterator.h: Rename include guard.
8940         * common/run-time-clock.h: Rename include guard.
8941         * common/refcounted-object.h: Rename include guard.
8942         * common/queue.h: Rename include guard.
8943         * common/ptid.h: Rename include guard.
8944         * common/print-utils.h: Rename include guard.
8945         * common/preprocessor.h: Rename include guard.
8946         * common/pathstuff.h: Rename include guard.
8947         * common/observable.h: Rename include guard.
8948         * common/netstuff.h: Rename include guard.
8949         * common/job-control.h: Rename include guard.
8950         * common/host-defs.h: Rename include guard.
8951         * common/gdb_wait.h: Rename include guard.
8952         * common/gdb_vecs.h: Rename include guard.
8953         * common/gdb_unlinker.h: Rename include guard.
8954         * common/gdb_unique_ptr.h: Rename include guard.
8955         * common/gdb_tilde_expand.h: Rename include guard.
8956         * common/gdb_sys_time.h: Rename include guard.
8957         * common/gdb_string_view.h: Rename include guard.
8958         * common/gdb_splay_tree.h: Rename include guard.
8959         * common/gdb_setjmp.h: Rename include guard.
8960         * common/gdb_ref_ptr.h: Rename include guard.
8961         * common/gdb_optional.h: Rename include guard.
8962         * common/gdb_locale.h: Rename include guard.
8963         * common/gdb_assert.h: Rename include guard.
8964         * common/filtered-iterator.h: Rename include guard.
8965         * common/filestuff.h: Rename include guard.
8966         * common/fileio.h: Rename include guard.
8967         * common/environ.h: Rename include guard.
8968         * common/common-utils.h: Rename include guard.
8969         * common/common-types.h: Rename include guard.
8970         * common/common-regcache.h: Rename include guard.
8971         * common/common-inferior.h: Rename include guard.
8972         * common/common-gdbthread.h: Rename include guard.
8973         * common/common-exceptions.h: Rename include guard.
8974         * common/common-defs.h: Rename include guard.
8975         * common/common-debug.h: Rename include guard.
8976         * common/cleanups.h: Rename include guard.
8977         * common/buffer.h: Rename include guard.
8978         * common/btrace-common.h: Rename include guard.
8979         * common/break-common.h: Rename include guard.
8980         * cli/cli-utils.h: Rename include guard.
8981         * cli/cli-style.h: Rename include guard.
8982         * cli/cli-setshow.h: Rename include guard.
8983         * cli/cli-script.h: Rename include guard.
8984         * cli/cli-interp.h: Rename include guard.
8985         * cli/cli-decode.h: Rename include guard.
8986         * cli/cli-cmds.h: Rename include guard.
8987         * charset-list.h: Add include guard.
8988         * buildsym-legacy.h: Rename include guard.
8989         * bfin-tdep.h: Add include guard.
8990         * ax.h: Rename include guard.
8991         * arm-linux-tdep.h: Add include guard.
8992         * arm-fbsd-tdep.h: Add include guard.
8993         * arch/xtensa.h: Rename include guard.
8994         * arch/tic6x.h: Add include guard.
8995         * arch/i386.h: Add include guard.
8996         * arch/arm.h: Rename include guard.
8997         * arch/arm-linux.h: Rename include guard.
8998         * arch/arm-get-next-pcs.h: Rename include guard.
8999         * arch/amd64.h: Add include guard.
9000         * arch/aarch64-insn.h: Rename include guard.
9001         * arch-utils.h: Rename include guard.
9002         * annotate.h: Add include guard.
9003         * amd64-darwin-tdep.h: Rename include guard.
9004         * aarch64-linux-tdep.h: Add include guard.
9005         * aarch64-fbsd-tdep.h: Add include guard.
9006         * aarch32-linux-nat.h: Add include guard.
9007
9008 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9009
9010         * macrotab.c (macro_define_internal): New function that
9011         factorizes macro_define_object_internal and macro_define_function
9012         code.
9013         (macro_define_object_internal): Use macro_define_internal.
9014         (macro_define_function): Likewise.
9015
9016 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9017
9018         * macrocmd.c (extract_identifier): Return
9019         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
9020         callers.
9021
9022 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
9023
9024         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
9025
9026 2019-02-05  Tom Tromey  <tom@tromey.com>
9027
9028         * target.c (target_stack::unpush): Move assertion earlier.
9029
9030 2019-01-30  Tom Tromey  <tom@tromey.com>
9031
9032         PR python/23615:
9033         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
9034         (gdbpy_parse_and_eval): Likewise.
9035         * python/python-internal.h (gdbpy_allow_threads): New class.
9036
9037 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
9038
9039         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
9040         (aarch64_fbsd_fpregmap): Move earlier.
9041         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
9042         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9043         instead of individual calls to trad_frame_set_reg_addr.
9044         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
9045         earlier.
9046         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
9047         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9048         instead of individual calls to trad_frame_set_reg_addr.
9049
9050 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
9051
9052         * CONTRIBUTE: Replace contribution list with wiki link.
9053
9054 2019-01-25  Tom Tromey  <tom@tromey.com>
9055
9056         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
9057
9058 2019-01-25  Tom Tromey  <tom@tromey.com>
9059
9060         * xtensa-linux-nat.c: Fix common/ includes.
9061         * xml-support.h: Fix common/ includes.
9062         * xml-support.c: Fix common/ includes.
9063         * x86-linux-nat.c: Fix common/ includes.
9064         * windows-nat.c: Fix common/ includes.
9065         * varobj.h: Fix common/ includes.
9066         * varobj.c: Fix common/ includes.
9067         * value.c: Fix common/ includes.
9068         * valops.c: Fix common/ includes.
9069         * utils.c: Fix common/ includes.
9070         * unittests/xml-utils-selftests.c: Fix common/ includes.
9071         * unittests/utils-selftests.c: Fix common/ includes.
9072         * unittests/unpack-selftests.c: Fix common/ includes.
9073         * unittests/tracepoint-selftests.c: Fix common/ includes.
9074         * unittests/style-selftests.c: Fix common/ includes.
9075         * unittests/string_view-selftests.c: Fix common/ includes.
9076         * unittests/scoped_restore-selftests.c: Fix common/ includes.
9077         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
9078         * unittests/scoped_fd-selftests.c: Fix common/ includes.
9079         * unittests/rsp-low-selftests.c: Fix common/ includes.
9080         * unittests/parse-connection-spec-selftests.c: Fix common/
9081         includes.
9082         * unittests/optional-selftests.c: Fix common/ includes.
9083         * unittests/offset-type-selftests.c: Fix common/ includes.
9084         * unittests/observable-selftests.c: Fix common/ includes.
9085         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
9086         * unittests/memrange-selftests.c: Fix common/ includes.
9087         * unittests/memory-map-selftests.c: Fix common/ includes.
9088         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
9089         * unittests/function-view-selftests.c: Fix common/ includes.
9090         * unittests/environ-selftests.c: Fix common/ includes.
9091         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
9092         * unittests/common-utils-selftests.c: Fix common/ includes.
9093         * unittests/cli-utils-selftests.c: Fix common/ includes.
9094         * unittests/array-view-selftests.c: Fix common/ includes.
9095         * ui-file.c: Fix common/ includes.
9096         * tui/tui-io.c: Fix common/ includes.
9097         * tracepoint.h: Fix common/ includes.
9098         * tracepoint.c: Fix common/ includes.
9099         * tracefile-tfile.c: Fix common/ includes.
9100         * top.h: Fix common/ includes.
9101         * top.c: Fix common/ includes.
9102         * thread.c: Fix common/ includes.
9103         * target/waitstatus.h: Fix common/ includes.
9104         * target/waitstatus.c: Fix common/ includes.
9105         * target.h: Fix common/ includes.
9106         * target.c: Fix common/ includes.
9107         * target-memory.c: Fix common/ includes.
9108         * target-descriptions.c: Fix common/ includes.
9109         * symtab.h: Fix common/ includes.
9110         * symfile.c: Fix common/ includes.
9111         * stap-probe.c: Fix common/ includes.
9112         * spu-linux-nat.c: Fix common/ includes.
9113         * sparc-nat.c: Fix common/ includes.
9114         * source.c: Fix common/ includes.
9115         * solib.c: Fix common/ includes.
9116         * solib-target.c: Fix common/ includes.
9117         * ser-unix.c: Fix common/ includes.
9118         * ser-tcp.c: Fix common/ includes.
9119         * ser-pipe.c: Fix common/ includes.
9120         * ser-base.c: Fix common/ includes.
9121         * selftest-arch.c: Fix common/ includes.
9122         * s12z-tdep.c: Fix common/ includes.
9123         * rust-exp.y: Fix common/ includes.
9124         * rs6000-aix-tdep.c: Fix common/ includes.
9125         * riscv-tdep.c: Fix common/ includes.
9126         * remote.c: Fix common/ includes.
9127         * remote-notif.h: Fix common/ includes.
9128         * remote-fileio.h: Fix common/ includes.
9129         * remote-fileio.c: Fix common/ includes.
9130         * regcache.h: Fix common/ includes.
9131         * regcache.c: Fix common/ includes.
9132         * record-btrace.c: Fix common/ includes.
9133         * python/python.c: Fix common/ includes.
9134         * python/py-type.c: Fix common/ includes.
9135         * python/py-inferior.c: Fix common/ includes.
9136         * progspace.h: Fix common/ includes.
9137         * producer.c: Fix common/ includes.
9138         * procfs.c: Fix common/ includes.
9139         * proc-api.c: Fix common/ includes.
9140         * printcmd.c: Fix common/ includes.
9141         * ppc-linux-nat.c: Fix common/ includes.
9142         * parser-defs.h: Fix common/ includes.
9143         * osdata.c: Fix common/ includes.
9144         * obsd-nat.c: Fix common/ includes.
9145         * nat/x86-linux.c: Fix common/ includes.
9146         * nat/x86-linux-dregs.c: Fix common/ includes.
9147         * nat/x86-dregs.h: Fix common/ includes.
9148         * nat/x86-dregs.c: Fix common/ includes.
9149         * nat/ppc-linux.c: Fix common/ includes.
9150         * nat/mips-linux-watch.h: Fix common/ includes.
9151         * nat/mips-linux-watch.c: Fix common/ includes.
9152         * nat/linux-waitpid.c: Fix common/ includes.
9153         * nat/linux-ptrace.h: Fix common/ includes.
9154         * nat/linux-ptrace.c: Fix common/ includes.
9155         * nat/linux-procfs.c: Fix common/ includes.
9156         * nat/linux-personality.c: Fix common/ includes.
9157         * nat/linux-osdata.c: Fix common/ includes.
9158         * nat/linux-namespaces.c: Fix common/ includes.
9159         * nat/linux-btrace.h: Fix common/ includes.
9160         * nat/linux-btrace.c: Fix common/ includes.
9161         * nat/fork-inferior.c: Fix common/ includes.
9162         * nat/amd64-linux-siginfo.c: Fix common/ includes.
9163         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
9164         * nat/aarch64-linux.c: Fix common/ includes.
9165         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9166         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9167         * namespace.h: Fix common/ includes.
9168         * mips-linux-tdep.c: Fix common/ includes.
9169         * minsyms.c: Fix common/ includes.
9170         * mi/mi-parse.h: Fix common/ includes.
9171         * mi/mi-main.c: Fix common/ includes.
9172         * mi/mi-cmd-env.c: Fix common/ includes.
9173         * memrange.h: Fix common/ includes.
9174         * memattr.c: Fix common/ includes.
9175         * maint.h: Fix common/ includes.
9176         * maint.c: Fix common/ includes.
9177         * main.c: Fix common/ includes.
9178         * machoread.c: Fix common/ includes.
9179         * location.c: Fix common/ includes.
9180         * linux-thread-db.c: Fix common/ includes.
9181         * linux-nat.c: Fix common/ includes.
9182         * linux-fork.c: Fix common/ includes.
9183         * inline-frame.c: Fix common/ includes.
9184         * infrun.c: Fix common/ includes.
9185         * inflow.c: Fix common/ includes.
9186         * inferior.h: Fix common/ includes.
9187         * inferior.c: Fix common/ includes.
9188         * infcmd.c: Fix common/ includes.
9189         * inf-ptrace.c: Fix common/ includes.
9190         * inf-child.c: Fix common/ includes.
9191         * ia64-linux-nat.c: Fix common/ includes.
9192         * i387-tdep.c: Fix common/ includes.
9193         * i386-tdep.c: Fix common/ includes.
9194         * i386-linux-tdep.c: Fix common/ includes.
9195         * i386-linux-nat.c: Fix common/ includes.
9196         * i386-go32-tdep.c: Fix common/ includes.
9197         * i386-fbsd-tdep.c: Fix common/ includes.
9198         * i386-fbsd-nat.c: Fix common/ includes.
9199         * guile/scm-type.c: Fix common/ includes.
9200         * guile/guile.c: Fix common/ includes.
9201         * go32-nat.c: Fix common/ includes.
9202         * gnu-nat.c: Fix common/ includes.
9203         * gdbthread.h: Fix common/ includes.
9204         * gdbarch-selftests.c: Fix common/ includes.
9205         * gdb_usleep.c: Fix common/ includes.
9206         * gdb_select.h: Fix common/ includes.
9207         * gdb_bfd.c: Fix common/ includes.
9208         * gcore.c: Fix common/ includes.
9209         * fork-child.c: Fix common/ includes.
9210         * findvar.c: Fix common/ includes.
9211         * fbsd-nat.c: Fix common/ includes.
9212         * event-top.c: Fix common/ includes.
9213         * event-loop.c: Fix common/ includes.
9214         * dwarf2read.c: Fix common/ includes.
9215         * dwarf2loc.c: Fix common/ includes.
9216         * dwarf2-frame.c: Fix common/ includes.
9217         * dwarf-index-cache.c: Fix common/ includes.
9218         * dtrace-probe.c: Fix common/ includes.
9219         * disasm-selftests.c: Fix common/ includes.
9220         * defs.h: Fix common/ includes.
9221         * csky-tdep.c: Fix common/ includes.
9222         * cp-valprint.c: Fix common/ includes.
9223         * cp-support.h: Fix common/ includes.
9224         * cp-support.c: Fix common/ includes.
9225         * corelow.c: Fix common/ includes.
9226         * completer.h: Fix common/ includes.
9227         * completer.c: Fix common/ includes.
9228         * compile/compile.c: Fix common/ includes.
9229         * compile/compile-loc2c.c: Fix common/ includes.
9230         * compile/compile-cplus-types.c: Fix common/ includes.
9231         * compile/compile-cplus-symbols.c: Fix common/ includes.
9232         * command.h: Fix common/ includes.
9233         * cli/cli-dump.c: Fix common/ includes.
9234         * cli/cli-cmds.c: Fix common/ includes.
9235         * charset.c: Fix common/ includes.
9236         * build-id.c: Fix common/ includes.
9237         * btrace.h: Fix common/ includes.
9238         * btrace.c: Fix common/ includes.
9239         * breakpoint.h: Fix common/ includes.
9240         * breakpoint.c: Fix common/ includes.
9241         * ax.h: 
9242         (enum agent_op): Fix common/ includes.
9243         * ax-general.c (struct aop_map): Fix common/ includes.
9244         * ax-gdb.c: Fix common/ includes.
9245         * auxv.c: Fix common/ includes.
9246         * auto-load.c: Fix common/ includes.
9247         * arm-tdep.c: Fix common/ includes.
9248         * arch/riscv.c: Fix common/ includes.
9249         * arch/ppc-linux-common.c: Fix common/ includes.
9250         * arch/i386.c: Fix common/ includes.
9251         * arch/arm.c: Fix common/ includes.
9252         * arch/arm-linux.c: Fix common/ includes.
9253         * arch/arm-get-next-pcs.c: Fix common/ includes.
9254         * arch/amd64.c: Fix common/ includes.
9255         * arch/aarch64.c: Fix common/ includes.
9256         * arch/aarch64-insn.c: Fix common/ includes.
9257         * arch-utils.c: Fix common/ includes.
9258         * amd64-windows-tdep.c: Fix common/ includes.
9259         * amd64-tdep.c: Fix common/ includes.
9260         * amd64-sol2-tdep.c: Fix common/ includes.
9261         * amd64-obsd-tdep.c: Fix common/ includes.
9262         * amd64-nbsd-tdep.c: Fix common/ includes.
9263         * amd64-linux-tdep.c: Fix common/ includes.
9264         * amd64-linux-nat.c: Fix common/ includes.
9265         * amd64-fbsd-tdep.c: Fix common/ includes.
9266         * amd64-fbsd-nat.c: Fix common/ includes.
9267         * amd64-dicos-tdep.c: Fix common/ includes.
9268         * amd64-darwin-tdep.c: Fix common/ includes.
9269         * agent.c: Fix common/ includes.
9270         * ada-lang.h: Fix common/ includes.
9271         * ada-lang.c: Fix common/ includes.
9272         * aarch64-tdep.c: Fix common/ includes.
9273
9274 2019-01-25  Tom Tromey  <tom@tromey.com>
9275
9276         * common/create-version.sh: Use common/version.h.
9277
9278 2019-01-24  Pedro Alves  <palves@redhat.com>
9279
9280         * infrun.c (signal_stop, signal_print, signal_program)
9281         (signal_catch, signal_pass): Now arrays instead of pointers.
9282         (update_signals_program_target, do_target_resume)
9283         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9284         * linux-nat.c (linux_nat_target::pass_signals)
9285         (linux_nat_target::create_inferior, linux_nat_target::attach):
9286         Adjust.
9287         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9288         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9289         * procfs.c (procfs_target::pass_signals): Adjust.
9290         * record-full.c (record_full_target::resume): Adjust.
9291         * remote.c (remote_target::pass_signals)
9292         (remote_target::program_signals): Adjust.
9293         * target-debug.h (target_debug_print_signals): Now takes a
9294         gdb::array_view as parameter.  Adjust.
9295         * target.h (target_ops) <pass_signals, program_signals>: Replace
9296         pointer and length parameters with gdb::array_view.
9297         (target_pass_signals, target_program_signals): Likewise.
9298         * target-delegates.c: Regenerate.
9299
9300 2019-01-24  Pedro Alves  <palves@redhat.com>
9301
9302         * common/forward-scope-exit.h
9303         (forward_scope_exit::forward_scope_exit): Pass arguments to
9304         m_bind_function directly, instead of creating a std::bind and
9305         copying that.
9306
9307 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9308
9309         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9310         for static members.
9311         (pass_in_v_vfp_candidate): Likewise.
9312
9313 2019-01-23  Tom Tromey  <tom@tromey.com>
9314             Pedro Alves  <palves@redhat.com>
9315
9316         * regcache.c (class regcache_invalidator): Remove.
9317         (regcache::raw_write): Use make_scope_exit.
9318
9319 2019-01-23  Tom Tromey  <tom@tromey.com>
9320
9321         * ui-out.h (class ui_out_emit_type): Update comment.
9322
9323 2019-01-23  Tom Tromey  <tom@tromey.com>
9324
9325         * infrun.c (fetch_inferior_event): Update comment.
9326
9327 2019-01-23  Tom Tromey  <tom@tromey.com>
9328             Pedro Alves  <palves@redhat.com>
9329
9330         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9331         parameter.
9332         (fetch_inferior_event): Use SCOPE_EXIT.
9333
9334
9335 2019-01-23  Tom Tromey  <tom@tromey.com>
9336             Pedro Alves  <palves@redhat.com>
9337
9338         * infrun.c (disable_thread_events): Delete.
9339         (stop_all_threads): Use SCOPE_EXIT.
9340
9341 2019-01-23  Tom Tromey  <tom@tromey.com>
9342             Pedro Alves  <palves@redhat.com>
9343
9344         * symfile.c: Include forward-scope-exit.h.
9345         (clear_symtab_users_cleanup): Replace forward declaration with
9346         a FORWARD_SCOPE_EXIT.
9347         (syms_from_objfile_1): Use the forward_scope_exit and
9348         gdb::optional instead of cleanup_function.
9349         (reread_symbols): Use the forward_scope_exit instead of
9350         cleanup_function.
9351         (clear_symtab_users_cleanup): Remove function.
9352
9353 2019-01-23  Tom Tromey  <tom@tromey.com>
9354             Pedro Alves  <palves@redhat.com>
9355
9356         * linux-nat.c: Include scope-exit.h.
9357         (cleanup_target_stop): Remove.
9358         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9359         SCOPE_EXIT.
9360
9361 2019-01-23  Tom Tromey  <tom@tromey.com>
9362             Pedro Alves  <palves@redhat.com>
9363
9364         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9365         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9366
9367 2019-01-23  Tom Tromey  <tom@tromey.com>
9368             Andrew Burgess  <andrew.burgess@embecosm.com>
9369             Pedro Alves  <palves@redhat.com>
9370
9371         * infrun.c (fetch_inferior_event): Use scope_exit.
9372         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9373         * top.c (execute_command): Use scope_exit.
9374         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9375         * utils.c (do_bpstat_clear_actions_cleanup)
9376         (make_bpstat_clear_actions_cleanup): Remove.
9377
9378 2019-01-23  Tom Tromey  <tom@tromey.com>
9379             Pedro Alves  <palves@redhat.com>
9380
9381         * infrun.c: Include "common/scope-exit.h"
9382         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9383         (wait_for_inferior): Use SCOPE_EXIT.
9384         (fetch_inferior_event): Use scope_exit.
9385
9386 2019-01-23  Tom Tromey  <tom@tromey.com>
9387             Pedro Alves  <palves@redhat.com>
9388
9389         * breakpoint.c (create_breakpoint): Remove cleanup.
9390
9391 2019-01-23  Tom Tromey  <tom@tromey.com>
9392             Andrew Burgess  <andrew.burgess@embecosm.com>
9393             Pedro Alves  <palves@redhat.com>
9394
9395 2019-01-23  Pedro Alves  <palves@redhat.com>
9396
9397         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9398
9399 2019-01-23  Pedro Alves  <palves@redhat.com>
9400             Andrew Burgess  <andrew.burgess@embecosm.com>
9401
9402         * gdbthread.h: Include "common/forward-scope-exit.h".
9403         (scoped_finish_thread_state): Redefine custom class in terms of
9404         forward_scope_exit.
9405
9406 2019-01-23  Pedro Alves  <palves@redhat.com>
9407             Andrew Burgess  <andrew.burgess@embecosm.com>
9408
9409         * common/forward-scope-exit.h: New file.
9410
9411 2019-01-23  Pedro Alves  <palves@redhat.com>
9412             Andrew Burgess  <andrew.burgess@embecosm.com>
9413             Tom Tromey  <tom@tromey.com>
9414
9415         * common/scope-exit.h: New file.
9416
9417 2019-01-23  Pedro Alves  <palves@redhat.com>
9418
9419         * common/preprocessor.h (ESC): Rename to ...
9420         (ESC_PARENS): ... this.
9421         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9422         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9423
9424 2019-01-23  Tom Tromey  <tom@tromey.com>
9425
9426         * language.h (class scoped_switch_to_sym_language_if_auto):
9427         Initialize m_lang in both cases.
9428
9429 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9430
9431         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9432         with XCNEW.
9433
9434 2019-01-22  Tom Tromey  <tom@tromey.com>
9435
9436         * corelow.c: Do not include sys/file.h.
9437
9438 2019-01-22  Tom Tromey  <tom@tromey.com>
9439
9440         * tui/tui-wingeneral.h: Include gdb_curses.h.
9441
9442 2019-01-22  Tom Tromey  <tom@tromey.com>
9443
9444         * source-cache.h (class source_cache) <get_source_lines,
9445         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9446
9447 2019-01-22  Tom Tromey  <tom@tromey.com>
9448
9449         * remote-fileio.h (struct remote_target): Declare.
9450
9451 2019-01-22  Tom Tromey  <tom@tromey.com>
9452
9453         * python/py-arch.c: Do not include py-ref.h.
9454         * python/py-bpevent.c: Do not include py-ref.h.
9455         * python/py-cmd.c: Do not include py-ref.h.
9456         * python/py-continueevent.c: Do not include py-ref.h.
9457         * python/py-event.h: Do not include py-ref.h.
9458         * python/py-evtregistry.c: Do not include py-ref.h.
9459         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9460         * python/py-frame.c: Do not include py-ref.h.
9461         * python/py-framefilter.c: Do not include py-ref.h.
9462         * python/py-function.c: Do not include py-ref.h.
9463         * python/py-infevents.c: Do not include py-ref.h.
9464         * python/py-linetable.c: Do not include py-ref.h.
9465         * python/py-objfile.c: Do not include py-ref.h.
9466         * python/py-param.c: Do not include py-ref.h.
9467         * python/py-prettyprint.c: Do not include py-ref.h.
9468         * python/py-progspace.c: Do not include py-ref.h.
9469         * python/py-symbol.c: Do not include py-ref.h.
9470         * python/py-symtab.c: Do not include py-ref.h.
9471         * python/py-type.c: Do not include py-ref.h.
9472         * python/py-unwind.c: Do not include py-ref.h.
9473         * python/py-utils.c: Do not include py-ref.h.
9474         * python/py-value.c: Do not include py-ref.h.
9475         * python/py-varobj.c: Do not include py-ref.h.
9476         * python/py-xmethods.c: Do not include py-ref.h.
9477         * python/python.c: Do not include py-ref.h.
9478         * varobj.c: Do not include py-ref.h.
9479
9480 2019-01-22  Tom Tromey  <tom@tromey.com>
9481
9482         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9483         keyword for bcache.
9484
9485 2019-01-22  Tom Tromey  <tom@tromey.com>
9486
9487         * compile/compile-cplus-types.c: Remove a comment by #include.
9488
9489 2019-01-22  Tom Tromey  <tom@tromey.com>
9490
9491         * compile/gcc-c-plugin.h: Include compile-internal.h.
9492
9493 2019-01-22  Tom Tromey  <tom@tromey.com>
9494
9495         * stabsread.c (EXTERN): Do not define.
9496         (symnum, next_symbol_text_func, processing_gcc_compilation)
9497         (within_function, global_sym_chain, global_stabs)
9498         (previous_stab_code, this_object_header_files)
9499         (n_this_object_header_files)
9500         (n_allocated_this_object_header_files): Define.
9501         * stabsread.h (EXTERN): Never define.  Use "extern".
9502
9503 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9504
9505         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9506         history_value.
9507
9508 2019-01-21  Tom Tromey  <tom@tromey.com>
9509
9510         * ui-out.c: Fix includes.
9511         * tui/tui-source.c: Fix includes.
9512         * target.c: Fix includes.
9513         * remote.c: Fix includes.
9514         * regcache.c: Fix includes.
9515         * python/py-block.c: Fix includes.
9516         * printcmd.c: Fix includes.
9517         * or1k-tdep.c: Fix includes.
9518         * mi/mi-main.c: Fix includes.
9519         * m32r-tdep.c: Fix includes.
9520         * csky-tdep.c: Fix includes.
9521         * compile/compile-cplus-types.c: Fix includes.
9522         * cli/cli-interp.c: Fix includes.
9523
9524 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9525
9526         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9527         for padding.
9528
9529 2019-01-16  Tom Tromey  <tom@tromey.com>
9530
9531         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9532         earlier.
9533         (struct objfile) <msymbols_range>: Move from top level.
9534         <msymbols>: New method.
9535         (class objfile_msymbols): Remove.
9536         * symtab.c (default_collect_symbol_completion_matches_break_on):
9537         Update.
9538         * symmisc.c (dump_msymbols): Update.
9539         * stabsread.c (scan_file_globals): Update.
9540         * objc-lang.c (info_selectors_command, info_classes_command)
9541         (find_methods): Update.
9542         * minsyms.c (find_solib_trampoline_target): Update.
9543         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9544         * coffread.c (coff_symfile_read): Update.
9545         * ada-lang.c (ada_lookup_simple_minsym)
9546         (ada_collect_symbol_completion_matches): Update.
9547
9548 2019-01-16  Tom Tromey  <tom@tromey.com>
9549
9550         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9551         type.  Remove no-argument constructor.
9552         <iterator::operator++>: Simplify.
9553         <begin>: Update.
9554         <end>: Use minimal_symbol_count.
9555
9556 2019-01-16  Tom Tromey  <tom@tromey.com>
9557
9558         * objfiles.h (struct objfile) <psymtabs>: New method.
9559         (class objfile_psymtabs): Remove.
9560         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9561         typedef.
9562         <range>: New method.
9563         (require_partial_symbols): Change return type.
9564         * psymtab.c (require_partial_symbols)
9565         (psym_expand_symtabs_matching): Update.
9566         * mdebugread.c (parse_partial_symbols): Update.
9567         * dbxread.c (dbx_end_psymtab): Update.
9568
9569 2019-01-15  Tom Tromey  <tom@tromey.com>
9570
9571         * symtab.c (lookup_objfile_from_block)
9572         (lookup_symbol_in_objfile_symtabs)
9573         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9574         (find_line_symtab, info_sources_command)
9575         (default_collect_symbol_completion_matches_break_on)
9576         (make_source_files_completion_list): Update.
9577         * symmisc.c (print_objfile_statistics, dump_objfile)
9578         (maintenance_print_symbols, maintenance_info_symtabs)
9579         (maintenance_check_symtabs, maintenance_info_line_tables):
9580         Update.
9581         * source.c (select_source_symtab)
9582         (forget_cached_source_info_for_objfile): Update.
9583         * objfiles.h (class objfile_compunits): Remove.
9584         (struct objfile) <compunits_range>: New typedef.
9585         (compunits): New method.
9586         * objfiles.c (objfile_relocate1): Update.
9587         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9588         * maint.c (count_symtabs_and_blocks): Update.
9589         * linespec.c (iterate_over_all_matching_symtabs): Update.
9590         * cp-support.c (add_symbol_overload_list_qualified): Update.
9591         * coffread.c (coff_symtab_read): Update.
9592         * ada-lang.c (add_nonlocal_symbols)
9593         (ada_collect_symbol_completion_matches)
9594         (ada_add_global_exceptions): Update.
9595
9596 2019-01-15  Tom Tromey  <tom@tromey.com>
9597
9598         * progspace.h (program_space) <objfiles_safe_range>: New
9599         typedef.
9600         <objfiles_safe>: New method.
9601         * objfiles.h (class all_objfiles_safe): Remove.
9602         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9603         * jit.c (jit_inferior_exit_hook): Update.
9604
9605 2019-01-17  Tom Tromey  <tom@tromey.com>
9606
9607         * progspace.h (program_space) <objfiles_range>: New typedef.
9608         <objfiles>: New method.
9609         <objfiles_head>: Rename from objfiles.
9610         (object_files): Update.
9611         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9612         * guile/scm-pretty-print.c
9613         (ppscm_find_pretty_printer_from_objfiles): Update.
9614         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9615         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9616         Update.
9617         * python/py-progspace.c (pspy_get_objfiles): Update.
9618         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9619         Update.
9620         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9621         (objfpy_lookup_objfile_by_build_id): Update.
9622         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9623         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9624         Update.
9625         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9626         (expand_symtab_containing_pc, lookup_objfile_from_block)
9627         (lookup_static_symbol, basic_lookup_transparent_type)
9628         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9629         (find_line_symtab, info_sources_command)
9630         (default_collect_symbol_completion_matches_break_on)
9631         (make_source_files_completion_list, find_main_name): Update.
9632         * symmisc.c (print_symbol_bcache_statistics)
9633         (print_objfile_statistics, maintenance_print_symbols)
9634         (maintenance_print_msymbols, maintenance_print_objfiles)
9635         (maintenance_info_symtabs, maintenance_check_symtabs)
9636         (maintenance_expand_symtabs, maintenance_info_line_tables):
9637         Update.
9638         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9639         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9640         (map_overlay_command, unmap_overlay_command)
9641         (simple_overlay_update, expand_symtabs_matching)
9642         (map_symbol_filenames): Update.
9643         * symfile-debug.c (set_debug_symfile): Update.
9644         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9645         Update.
9646         * source.c (select_source_symtab, forget_cached_source_info):
9647         Update.
9648         * solib.c (solib_read_symbols): Update.
9649         * solib-spu.c (append_ocl_sos): Update.
9650         * psymtab.c (maintenance_print_psymbols)
9651         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9652         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9653         * printcmd.c (info_symbol_command): Update.
9654         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9655         Update.
9656         * objfiles.h (class all_objfiles): Remove.
9657         * objfiles.c (have_partial_symbols, have_full_symbols)
9658         (have_minimal_symbols, qsort_cmp, update_section_map)
9659         (shared_objfile_contains_address_p)
9660         (default_iterate_over_objfiles_in_search_order): Update.
9661         * objc-lang.c (info_selectors_command, info_classes_command)
9662         (find_methods): Update.
9663         * minsyms.c (find_solib_trampoline_target): Update.
9664         * maint.c (maintenance_info_sections)
9665         (maintenance_translate_address, count_symtabs_and_blocks):
9666         Update.
9667         * main.c (captured_main_1): Update.
9668         * linux-thread-db.c (try_thread_db_load_from_pdir)
9669         (has_libpthread): Update.
9670         * linespec.c (iterate_over_all_matching_symtabs)
9671         (search_minsyms_for_name): Update.
9672         * jit.c (jit_find_objf_with_entry_addr): Update.
9673         * hppa-tdep.c (find_unwind_entry)
9674         (hppa_lookup_stub_minimal_symbol): Update.
9675         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9676         Update.
9677         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9678         (elf_gnu_ifunc_resolve_by_got): Update.
9679         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9680         * dwarf-index-write.c (save_gdb_index_command): Update.
9681         * cp-support.c (add_symbol_overload_list_qualified): Update.
9682         * breakpoint.c (create_overlay_event_breakpoint)
9683         (create_longjmp_master_breakpoint)
9684         (create_std_terminate_master_breakpoint)
9685         (create_exception_master_breakpoint): Update.
9686         * blockframe.c (find_pc_partial_function): Update.
9687         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9688         (ada_collect_symbol_completion_matches)
9689         (ada_add_global_exceptions): Update.
9690
9691 2019-01-17  Tom Tromey  <tom@tromey.com>
9692
9693         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9694         declare VEC.
9695         (solib_target_parse_libraries): Change return type.
9696         (library_list_start_segment, library_list_start_section)
9697         (library_list_end_library, library_list_start_library); Update.
9698         (solib_target_free_library_list): Remove.
9699         (solib_target_parse_libraries): Remove cleanup.  Change return
9700         type.
9701         (solib_target_current_sos): Update.
9702
9703 2019-01-17  Tom Tromey  <tromey@bapiya>
9704
9705         * valprint.c: Replace "the the" with "the".
9706         * symtab.c: Replace "the the" with "the".
9707         * solib.c: Replace "the the" with "the".
9708         * solib-dsbt.c: Replace "the the" with "the".
9709         * linespec.c: Replace "the the" with "the".
9710         * dwarf2loc.h: Replace "the the" with "the".
9711         * amd64-windows-tdep.c: Replace "the the" with "the".
9712         * aarch64-tdep.c: Replace "the the" with "the".
9713
9714 2019-01-16  Keith Seitz  <keiths@redhat.com>
9715
9716         PR gdb/23773
9717         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9718         <builder>: Rename to ..
9719         <m_builder>: ... this and make private.
9720         (dwarf2_cu::get_builder): New method.  Change all users of
9721         `builder' to use this method.
9722         (dwarf2_start_symtab): Move to ...
9723         (dwarf2_cu::start_symtab): ... here.  Update all callers
9724         (setup_type_unit_groups): Move to ...
9725         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9726         callers.
9727         (dwarf2_cu::reset_builder): New method.
9728         (process_full_compunit, process_full_type_unit): Use
9729         dwarf2_cu::reset_builder.
9730         (follow_die_offset): Record the ancestor CU if it is different
9731         from the followed DIE's CU.
9732         (follow_die_sig_1): Likewise.
9733
9734 2019-01-15  Tom Tromey  <tom@tromey.com>
9735
9736         * remote.c (class remote_state) <buf>: Now a char_vector.
9737         <buf_size>: Remove.
9738         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9739         parameter.
9740         (remote_target::getpkt_or_notif_sane_1)
9741         (remote_target::getpkt_sane)
9742         (remote_target::getpkt_or_notif_sane): Likewise.
9743         (class remote_target) <putpkt>: New overload.
9744         (remote_target::read_frame): Change type of "buf_p".  Remove
9745         sizeof_p parameter.
9746         (packet_ok): New overload.
9747         (packet_check_result): New overload.
9748         Update all uses.
9749
9750 2019-01-14  Tom Tromey  <tom@tromey.com>
9751
9752         * remote-notif.c (handle_notification, remote_notif_ack)
9753         (remote_notif_parse): Make "buf" const.
9754         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9755         const.
9756         (remote_notif_parse, remote_notif_ack, handle_notification):
9757         Likewise.
9758         * remote.c (remote_notif_stop_parse): Make "buf" const.
9759         (remote_target::remote_parse_stop_reply): Make "buf" const.
9760         (remote_notif_stop_ack): Make "buf" const.
9761
9762 2019-01-14  Tom Tromey  <tom@tromey.com>
9763
9764         * remote.c (remote_console_output): Make parameter const.
9765
9766 2019-01-14  Tom Tromey  <tom@tromey.com>
9767
9768         * target-debug.h (target_debug_print_signals): Constify.
9769         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9770         * procfs.c (procfs_target::pass_signals): Update.
9771         * linux-nat.c (linux_nat_target::pass_signals): Update.
9772         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9773         * target-delegates.c: Rebuild.
9774         * remote.c (remote_target::program_signals): Update.
9775         (remote_target::pass_signals): Update.
9776         * target.c (target_pass_signals): Constify argument.
9777         (target_program_signals): Likewise.
9778         * target.h (struct target_ops) <pass_signals, program_signals>:
9779         Constify argument.
9780         (target_pass_signals, target_program_signals): Constify argument.
9781
9782 2019-01-14  Tom Tromey  <tom@tromey.com>
9783
9784         PR tui/28819:
9785         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9786
9787 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9788
9789         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9790         field.
9791         * rs6000-tdep.c: Include reggroups.h.
9792         (IS_V_ALIAS_PSEUDOREG): Define.
9793         (rs6000_register_name): Return names for the "vX" aliases.
9794         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9795         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9796         aliases.  Call default_register_reggroup_p for all other
9797         pseudo-registers.
9798         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9799         New functions.
9800         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9801         Handle "vX" aliases.
9802         (v_alias_pseudo_register_collect): New function.
9803         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9804         (rs6000_gdbarch_init): Initialize "vX" aliases as
9805         pseudo-registers.  Restore registration of
9806         rs6000_pseudo_register_reggroup_p with
9807         set_tdesc_pseudo_register_reggroup_p.
9808
9809 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9810
9811         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9812         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9813         set_gdbarch_num_pseudo_regs.
9814
9815 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9816
9817         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9818         Remove arg prefixname, add do_set and do_show.
9819         Add member functions set_list and show_list.
9820         * cli/cli-style.c (class cli_style_option): Update accordingly.
9821         (style_set_list): Move to file scope.
9822         (style_show_list): Likewise.
9823         (set_style): Call help_list.
9824         (show_style): Call cmd_show_list.
9825         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9826         Update to use the new macro.
9827
9828 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9829
9830         * ada-lang.c (_initialize_ada_language): Expand the help text
9831         for the "catch exception" command.
9832
9833 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9834
9835         * symtab.c (matching_obj_sections): Initialize obj,
9836         declare it closer to its usage.
9837
9838 2019-01-10  Tom Tromey  <tom@tromey.com>
9839
9840         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9841         (basic_inf_threads_range): Remove.
9842         (inf_threads_range, inf_non_exited_threads_range)
9843         (safe_inf_threads_range): Use next_adapter.
9844
9845 2019-01-10  Keith Seitz  <keiths@redhat.com>
9846
9847         PR gdb/23712
9848         PR symtab/23010
9849         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9850         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9851
9852 2019-01-10  Keith Seitz  <keiths@redhat.com>
9853
9854         PR gdb/23712
9855         PR symtab/23010
9856         * dictionary.c (pending_to_vector): Remove.
9857         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9858         Remove _1 suffix, replacing functions of the same name.  Update
9859         all callers.
9860         (dict_create_hashed, dict_create_hashed_expandable)
9861         (dict_create_linear, dict_create_linear_expandable, dict_free)
9862         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9863         Make functions static.
9864
9865 2019-01-10  Keith Seitz  <keiths@redhat.com>
9866
9867         PR gdb/23712
9868         PR symtab/23010
9869         * dictionary.h (struct dictionary): Replace declaration with
9870         multidictionary.
9871         (dict_create_hashed, dict_create_hashed_expandable)
9872         (dict_create_linear, dict_create_linear_expandable)
9873         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9874         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9875         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9876         taking multidictionary argument.
9877         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9878         * block.h (struct block) <dict>: Change to multidictionary
9879         and rename `multidict'.
9880         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9881         symmisc.c: Update all dictionary references to multidictionary.
9882
9883 2019-01-10  Keith Seitz  <keiths@redhat.com>
9884
9885         PR gdb/23712
9886         PR symtab/23010
9887         * dictionary.c: Include unordered_map.
9888         (pending_to_vector): New function.
9889         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9890         Rewrite the non-"_1" functions to take vector instead
9891         of linked list.
9892         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9893         "new" _1 versions of the same name.
9894         (multidictionary): Define.
9895         (std::hash<enum language): New definition.
9896         (collate_pending_symbols_by_language, mdict_create_hashed)
9897         (mdict_create_hashed_expandable, mdict_create_linear)
9898         (mdict_create_linear_expandable, mdict_free)
9899         (find_language_dictionary, create_new_language_dictionary)
9900         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9901         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9902         (mdict_size, mdict_empty): New functions.
9903         * dictionary.h (mdict_iterator): Define.
9904
9905 2019-01-10  Pedro Alves  <palves@redhat.com>
9906
9907         * breakpoint.c (read_uploaded_action)
9908         (create_tracepoint_from_upload): Adjust to use
9909         gdb::unique_xmalloc_ptr.
9910         * ctf.c (ctf_write_uploaded_tp):
9911         (SET_ARRAY_FIELD): Use emplace_back.
9912         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9913         * tracefile-tfile.c (tfile_write_uploaded_tp):
9914         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9915         gdb::unique_xmalloc_ptr.
9916         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9917         at_string, cond_string, cmd_strings>: Replace char pointers
9918         with gdb::unique_xmalloc_ptr.
9919
9920 2019-01-10  Pedro Alves  <palves@redhat.com>
9921
9922         * solib-target.c (library_list_start_library): Don't xstrdup name.
9923
9924 2019-01-10  Pedro Alves  <palves@redhat.com>
9925
9926         * mdebugread.c (parse_partial_symbols): Use
9927         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9928
9929 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9930
9931         * linux-fork.c (scoped_switch_fork_info)
9932         <~scoped_switch_fork_info>: Fix incorrect variable name.
9933
9934 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9935
9936         * linux-fork.c (scoped_switch_fork_info)
9937         <scoped_switch_fork_info>: Make explicit.
9938         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9939
9940 2019-01-10  Tom Tromey  <tom@tromey.com>
9941
9942         * objfiles.h (objfile::reset_psymtabs): Update.
9943         * objfiles.c (objfile::objfile): Update.
9944         * psymtab.h (psymtab_storage::obstack): Update.
9945         (psymtab_storage::m_obstack): Use gdb::optional.
9946         (class psymtab_storage): Update comment.  Remove objfile
9947         parameter.
9948         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9949
9950 2019-01-10  Tom Tromey  <tom@tromey.com>
9951
9952         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9953         <free_psymtabs>: Now private.
9954         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9955         (allocate_psymtab): Use new method.
9956
9957 2019-01-10  Tom Tromey  <tom@tromey.com>
9958
9959         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9960         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9961         * mdebugread.c (parse_partial_symbols): Use
9962         allocate_dependencies.
9963         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9964         allocate_dependencies.
9965         (process_psymtab_comp_unit_reader)
9966         (build_type_psymtab_dependencies): Likewise.
9967         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9968
9969 2019-01-10  Tom Tromey  <tom@tromey.com>
9970
9971         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9972         PSYMBOL_SET_LANGUAGE.
9973         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9974
9975 2019-01-10  Tom Tromey  <tom@tromey.com>
9976
9977         * psymtab.h (psymtab_storage::obstack): New method.
9978         <m_obstack>: Rename from obstack; now private.
9979         * psymtab.c (psymtab_storage): Update.
9980         * dwarf2read.c (create_addrmap_from_index)
9981         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9982         Update.
9983
9984 2019-01-10  Tom Tromey  <tom@tromey.com>
9985
9986         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9987         * objfiles.h (objfile::reset_psymtabs): New method.
9988
9989 2019-01-10  Tom Tromey  <tom@tromey.com>
9990
9991         * symmisc.c (print_symbol_bcache_statistics): Update.
9992         (print_objfile_statistics): Update.
9993         * symfile.c (reread_symbols): Update.
9994         * psymtab.h (class psymtab_storage): New.
9995         * psymtab.c (psymtab_storage): New constructor.
9996         (~psymtab_storage): New destructor.
9997         (require_partial_symbols): Update.
9998         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9999         (find_pc_sect_psymtab, find_pc_sect_psymbol)
10000         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
10001         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
10002         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
10003         (start_psymtab_common, end_psymtab_common)
10004         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
10005         (allocate_psymtab): Update.
10006         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
10007         Update.
10008         (dump_psymtab_addrmap, maintenance_print_psymbols)
10009         (maintenance_check_psymtabs): Update.
10010         (class objfile_psymtabs): Move to objfiles.h.
10011         * psympriv.h (discard_psymtab): Now inline.
10012         (psymtab_discarder::psymtab_discarder): Update.
10013         (psymtab_discarder::~psymtab_discarder): Update.
10014         (ALL_OBJFILE_PSYMTABS): Rewrite.
10015         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
10016         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
10017         Remove fields.
10018         <partial_symtabs>: New field.
10019         (class objfile_psymtabs): Move from psymtab.h.  Update.
10020         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
10021         psymbol_cache.
10022         (objfile::~objfile): Don't destroy psymbol_cache.
10023         * mdebugread.c (parse_partial_symbols): Update.
10024         * dwarf2read.c (create_addrmap_from_index)
10025         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10026         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
10027         (add_partial_subprogram, dwarf2_ranges_read): Update.
10028         * dwarf-index-write.c (write_address_map)
10029         (write_one_signatured_type, recursively_write_psymbols)
10030         (class debug_names, class debug_names, write_psymtabs_to_index):
10031         Update.
10032
10033 2019-01-10  Tom Tromey  <tom@tromey.com>
10034
10035         * symtab.h (SYMBOL_SET_NAMES): Update.
10036         (symbol_set_names): Update.
10037         (MSYMBOL_SET_NAMES): Update.
10038         * symtab.c (symbol_set_names): Change argument to be an
10039         objfile_per_bfd_storage.
10040         * psymtab.c (add_psymbol_to_bcache): Update.
10041         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
10042
10043 2019-01-10  Tom Tromey  <tom@tromey.com>
10044
10045         * symtab.c (create_demangled_names_hash): Change argument to be an
10046         objfile_per_bfd_storage.
10047         (symbol_set_names): Update.
10048
10049 2019-01-10  Tom Tromey  <tom@tromey.com>
10050
10051         * xcoffread.c (xcoff_initial_scan): Unconditionally call
10052         init_psymbol_list.
10053         * psymtab.c (init_psymbol_list): Do nothing if already called.
10054         * psympriv.h (init_psymbol_list): Add comment.
10055         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
10056         init_psymbol_list.
10057         * dbxread.c (dbx_symfile_read): Unconditionally call
10058         init_psymbol_list.
10059
10060 2019-01-10  Tom Tromey  <tom@tromey.com>
10061
10062         * xcoffread.c (scan_xcoff_symtab): Update.
10063         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
10064         "where".
10065         * mdebugread.c (parse_partial_symbols)
10066         (handle_psymbol_enumerators): Update.
10067         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
10068         * dbxread.c (read_dbx_symtab): Update.
10069         * psympriv.h (psymbol_placement): New enum.
10070         (add_psymbol_to_list): Update.
10071
10072 2019-01-10  Tom Tromey  <tom@tromey.com>
10073
10074         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
10075         static_psymbols parameters.
10076         (scan_xcoff_symtab): Update.
10077         * psymtab.c (start_psymtab_common): Remove global_psymbols and
10078         static_psymbols parameters.
10079         * psympriv.h (start_psymtab_common): Update.
10080         * mdebugread.c (parse_partial_symbols): Update.
10081         * dwarf2read.c (create_partial_symtab): Update.
10082         * dbxread.c (read_dbx_symtab): Update.
10083         (start_psymtab): Remove global_psymbols and static_psymbols
10084         parameters.
10085
10086 2019-01-10  Tom Tromey  <tom@tromey.com>
10087
10088         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
10089         * psymtab.c (allocate_psymtab): Add comment.
10090         * psympriv.h (allocate_psymtab): Add comment.
10091         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
10092         initializations.
10093         * dbxread.c (dbx_end_psymtab): Remove some initializations.
10094
10095 2019-01-10  Tom Tromey  <tom@tromey.com>
10096
10097         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10098         Don't declare.
10099         * mipsread.c: Include mdebugread.h.
10100         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10101         Declare.
10102         * elfread.c: Include mdebugread.h.
10103
10104 2019-01-09  Tom Tromey  <tom@tromey.com>
10105
10106         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
10107         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
10108         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
10109         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
10110         (psym_lookup_symbol, psym_find_last_source_symtab)
10111         (psym_forget_cached_source_info, psym_print_stats)
10112         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
10113         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
10114         (psym_map_matching_symbols, psym_expand_symtabs_matching)
10115         (psym_find_compunit_symtab_by_address)
10116         (maintenance_print_psymbols, maintenance_info_psymtabs)
10117         (maintenance_check_psymtabs): Use ranged for.
10118         * psymtab.h (class objfile_psymtabs): New.
10119         (require_partial_symbols): Return objfile_psymtabs.
10120         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
10121
10122 2019-01-09  Tom Tromey  <tom@tromey.com>
10123
10124         * symfile.c (overlay_invalidate_all, find_pc_overlay)
10125         (find_pc_mapped_section, list_overlays_command)
10126         (map_overlay_command, unmap_overlay_command)
10127         (simple_overlay_update): Use all_objfiles.
10128         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
10129         * printcmd.c (info_symbol_command): Use all_objfiles.
10130         * objfiles.h (ALL_OBJSECTIONS): Remove.
10131         * maint.c (maintenance_translate_address): Use all_objfiles.
10132         * gcore.c (gcore_create_callback): Use all_objfiles.
10133         (objfile_find_memory_regions): Likewise.
10134
10135 2019-01-09  Tom Tromey  <tom@tromey.com>
10136
10137         * symtab.c (find_line_symtab, info_sources_command)
10138         (make_source_files_completion_list): Use objfile_compunits.
10139         * source.c (select_source_symtab): Use objfile_compunits.
10140         * objfiles.h (struct objfile): Update comment.
10141         (ALL_OBJFILES): Remove.
10142         (ALL_FILETABS): Remove.
10143         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
10144         objfile_compunits.
10145
10146 2019-01-09  Tom Tromey  <tom@tromey.com>
10147
10148         * symmisc.c (print_objfile_statistics, dump_objfile)
10149         (maintenance_print_symbols): Use compunit_filetabs.
10150         * source.c (forget_cached_source_info_for_objfile): Use
10151         compunit_filetabs.
10152         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
10153         (ALL_FILETABS): Use compunit_filetabs.
10154         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
10155         * coffread.c (coff_symtab_read): Use compunit_filetabs.
10156
10157 2019-01-09  Tom Tromey  <tom@tromey.com>
10158
10159         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
10160         (compunit_filetabs): New.
10161         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
10162         compunit_filetabs.
10163         (info_sources_command, make_source_files_completion_list): Remove
10164         declaration.
10165         * symmisc.c (print_objfile_statistics, dump_objfile)
10166         (maintenance_print_symbols): Remove declaration.
10167         (maintenance_info_symtabs): Use compunit_filetabs.
10168         (maintenance_info_line_tables): Likewise.
10169         * source.c (select_source_symtab): Change local variable name.
10170         (forget_cached_source_info_for_objfile): Remove declaration.
10171         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10172         * objfiles.c (objfile_relocate1): Remove declaration.
10173         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10174         declaration.
10175         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10176         * coffread.c (coff_symtab_read): Remove declaration.
10177         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10178         compunit_filetabs.
10179
10180 2019-01-09  Tom Tromey  <tom@tromey.com>
10181
10182         * symtab.c (lookup_objfile_from_block)
10183         (find_pc_sect_compunit_symtab, search_symbols)
10184         (default_collect_symbol_completion_matches_break_on): Use
10185         objfile_compunits.
10186         * objfiles.h (ALL_COMPUNITS): Remove.
10187         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10188         * cp-support.c (add_symbol_overload_list_qualified): Use
10189         objfile_compunits.
10190         * ada-lang.c (ada_collect_symbol_completion_matches)
10191         (ada_add_global_exceptions): Use objfile_compunits.
10192
10193 2019-01-09  Tom Tromey  <tom@tromey.com>
10194
10195         * source.c (select_source_symtab)
10196         (forget_cached_source_info_for_objfile): Remove declaration.
10197         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10198         declaration.
10199         * maint.c (count_symtabs_and_blocks): Remove declaration.
10200         * cp-support.c (add_symbol_overload_list_qualified): Remove
10201         declaration.
10202         * coffread.c (coff_symtab_read): Remove declaration.
10203         * symtab.c (lookup_symbol_in_objfile_symtabs)
10204         (basic_lookup_transparent_type_1): Use objfile_compunits.
10205         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10206         (info_sources_command, search_symbols)
10207         (default_collect_symbol_completion_matches_break_on)
10208         (make_source_files_completion_list): Remove declaration.
10209         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10210         (ada_collect_symbol_completion_matches)
10211         (ada_add_global_exceptions): Remove declaration.
10212         * linespec.c (iterate_over_all_matching_symtabs): Use
10213         objfile_compunits.
10214         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10215         (class objfile_compunits): New.
10216         (ALL_COMPUNITS): Use objfile_compunits.
10217         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10218         (maintenance_check_symtabs, maintenance_info_line_tables): Use
10219         objfile_compunits.
10220         * objfiles.c (objfile_relocate1): Use objfile_compunits.
10221
10222 2019-01-09  Tom Tromey  <tom@tromey.com>
10223
10224         * symtab.c (search_symbols)
10225         (default_collect_symbol_completion_matches_break_on): Use
10226         objfile_msymbols.
10227         * ada-lang.c (ada_lookup_simple_minsym)
10228         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10229         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10230         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10231         objfile_msymbols.
10232         * coffread.c (coff_symfile_read): Use objfile_msymbols.
10233         * symmisc.c (dump_msymbols): Use objfile_msymbols.
10234         * objc-lang.c (find_methods): Use objfile_msymbols.
10235         (info_selectors_command, info_classes_command): Likewise.
10236         * stabsread.c (scan_file_globals): Use objfile_msymbols.
10237         * objfiles.h (class objfile_msymbols): New.
10238         (ALL_OBJFILE_MSYMBOLS): Remove.
10239         (ALL_MSYMBOLS): Remove.
10240
10241 2019-01-09  Tom Tromey  <tom@tromey.com>
10242
10243         * common/next-iterator.h (next_adapter): Add Iterator template
10244         parameter.
10245         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10246         (class all_objfiles_safe): New.
10247         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10248         * objfiles.c (put_objfile_before): Update comment.
10249         (add_separate_debug_objfile): Likewise.
10250         (free_all_objfiles): Use all_objfiles_safe.
10251         (objfile_purge_solibs): Likewise.
10252
10253 2019-01-09  Tom Tromey  <tom@tromey.com>
10254
10255         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10256         (expand_symtab_containing_pc, lookup_static_symbol)
10257         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10258         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10259         all_objfiles.
10260         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10261         * breakpoint.c (create_overlay_event_breakpoint)
10262         (create_longjmp_master_breakpoint)
10263         (create_std_terminate_master_breakpoint)
10264         (create_exception_master_breakpoint): Use all_objfiles.
10265         * linux-thread-db.c (try_thread_db_load_from_pdir)
10266         (has_libpthread): Use all_objfiles.
10267         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10268         * linespec.c (iterate_over_all_matching_symtabs)
10269         (search_minsyms_for_name): Use all_objfiles.
10270         * maint.c (maintenance_info_sections): Use all_objfiles.
10271         * main.c (captured_main_1): Use all_objfiles.
10272         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10273         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10274         * guile/scm-pretty-print.c
10275         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10276         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10277         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10278         (maintenance_print_msymbols): Use all_objfiles.
10279         * source.c (select_source_symtab): Use all_objfiles.
10280         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10281         * symfile.c (remove_symbol_file_command)
10282         (expand_symtabs_matching, map_symbol_filenames): Use
10283         all_objfiles.
10284         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10285         all_objfiles.
10286         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10287         * objc-lang.c (find_methods): Use all_objfiles.
10288         * objfiles.c (have_partial_symbols, have_full_symbols)
10289         (have_minimal_symbols, qsort_cmp)
10290         (default_iterate_over_objfiles_in_search_order): Use
10291         all_objfiles.
10292         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10293         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10294         (maintenance_check_psymtabs): Use all_objfiles.
10295         (ALL_PSYMTABS): Remove.
10296         * compile/compile-object-run.c (do_module_cleanup): Use
10297         all_objfiles.
10298         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10299         * cp-support.c (add_symbol_overload_list_qualified): Use
10300         all_objfiles.
10301         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10302         Use all_objfiles.
10303         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10304         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10305         all_objfiles.
10306         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10307         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10308         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10309         Uses all_objfiles.
10310         * solib.c (solib_read_symbols): Use all_objfiles
10311
10312 2019-01-09  Tom Tromey  <tom@tromey.com>
10313
10314         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10315         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10316         all_objfiles.
10317         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10318         * symmisc.c (print_symbol_bcache_statistics)
10319         (print_objfile_statistics, maintenance_print_objfiles)
10320         (maintenance_info_symtabs, maintenance_check_symtabs)
10321         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10322         all_objfiles.
10323         * source.c (forget_cached_source_info): Use all_objfiles.
10324         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10325         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10326         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10327         * objfiles.c (update_section_map): Use all_objfiles.
10328         (shared_objfile_contains_address_p): Likewise.
10329         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10330         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10331
10332 2019-01-09  Tom Tromey  <tom@tromey.com>
10333
10334         * common/next-iterator.h: New file.
10335         * objfiles.h (class all_objfiles): New.
10336         (struct objfile_iterator): New.
10337
10338 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10339
10340         * NEWS: Move the description of the changed "frame", "select-frame",
10341          and "info frame" commands to the Changed commands section.
10342
10343 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10344
10345         * gdbtypes.c (check_stub_method_group): Remove handling of old
10346         mangling schemes.
10347         * linespec.c (find_methods): Likewise.
10348         * stabsread.c (read_member_functions): Likewise.
10349         * valops.c (search_struct_method): Likewise.
10350         (value_struct_elt_for_reference): Likewise.
10351         * NEWS: Mention this change.
10352
10353 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10354
10355         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10356         print_source_lines.
10357         * source.c (print_source_lines_base): Update line number check.
10358         (print_source_lines): New function.
10359         (source_lines_range::source_lines_range): New function.
10360         * source.h (class source_lines_range): New class.
10361         (print_source_lines): New declaration.
10362
10363 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10364
10365         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10366
10367 2019-01-08  Tom Tromey  <tom@tromey.com>
10368             Simon Marchi  <simon.marchi@ericsson.com>
10369
10370         PR gdb/24060
10371         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10372         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10373         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10374         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10375         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10376         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10377
10378 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10379
10380         * source.c (select_source_symtab): Move header comment to
10381         declaration in source.h.
10382         (forget_cached_source_info_for_objfile): Likewise.
10383         (forget_cached_source_info): Likewise.
10384         (identify_source_line): Likewise.
10385         * source.h (identify_source_line): Move declaration from symtab.h
10386         and add comment from source.c
10387         (print_source_lines): Likewise.
10388         (forget_cached_source_info_for_objfile): Likewise.
10389         (forget_cached_source_info): Likewise.
10390         (select_source_symtab): Likewise.
10391         (enum print_source_lines_flag): Move definition from symtab.h.
10392         * symtab.h (identify_source_line): Move declaration to source.h.
10393         (print_source_lines): Likewise.
10394         (forget_cached_source_info_for_objfile): Likewise.
10395         (forget_cached_source_info): Likewise.
10396         (select_source_symtab): Likewise.
10397         (enum print_source_lines_flag): Move definition to source.h.
10398         * tui/tui-hooks.c: Add 'source.h' include.
10399
10400 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10401
10402         * source.c (print_source_lines_base): Handle requests to print
10403         reverse line number sequences, and guard against empty lines
10404         string.
10405
10406 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10407
10408         * source.c (print_source_lines_base): Fix skip of '\r' if next
10409         character is '\n'.
10410
10411 2019-01-06  Tom Tromey  <tom@tromey.com>
10412
10413         * c-exp.y (struct c_parse_state) <macro_original_text,
10414         expansion_obstack>: New member.
10415         (macro_original_text, expansion_obstack): Remove globals.
10416         (scan_macro_expansion, scanning_macro_expansion)
10417         (finished_macro_expansion): Update.
10418         (scan_macro_cleanup): Remove.
10419         (yylex, c_parse): Update.
10420
10421 2019-01-06  Tom Tromey  <tom@tromey.com>
10422
10423         * c-exp.y (struct c_parse_state) <strings>: New member.
10424         (operator_stoken): Update.
10425
10426 2019-01-06  Tom Tromey  <tom@tromey.com>
10427
10428         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10429         (union type_stack_elt) <typelist_val>: Now a pointer to
10430         std::vector.
10431         (type_stack_cleanup): Don't declare.
10432         (push_typelist): Update.
10433         * parse.c (pop_typelist): Return a std::vector.
10434         (push_typelist): Take a std::vector.
10435         (follow_types): Update.  Do not free args.
10436         (type_stack_cleanup): Remove.
10437         * c-exp.y (struct c_parse_state): New.
10438         (cpstate): New global.
10439         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10440         (nonempty_typelist): Update.
10441         (func_mod): Create a new vector.
10442         (c_parse): Create a c_parse_state.
10443         (check_parameter_typelist): Do not delete params.
10444         (function_method): Update.  Do not delete type_list.
10445
10446 2019-01-06  Tom Tromey  <tom@tromey.com>
10447
10448         PR gdb/28155:
10449         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10450         check_typedef.
10451         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10452         (print_return_value): Likewise.
10453
10454 2019-01-05  Tom Tromey  <tom@tromey.com>
10455
10456         * contrib/cleanup_check.py: Remove.
10457         * contrib/gcc-with-excheck: Remove.
10458         * contrib/exsummary.py: Remove.
10459         * contrib/excheck.py: Remove.
10460
10461 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10462
10463         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10464         NULL. Initialize tpprev to NULL instead of assigning it
10465         to NULL on the next statement.
10466         * windows-nat.c (windows_delete_thread): Remove check for
10467         main_thread_id before printing thread exit notifications.
10468         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10469         Remove thread ID check against main_thread_id.
10470         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10471         windows_delete_thread.
10472         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10473
10474 2019-01-04  Tom Tromey  <tom@tromey.com>
10475
10476         * compile/compile.c (_initialize_compile): Use upper case for
10477         metasyntactic variables.
10478         * symmisc.c (_initialize_symmisc): Use upper case for
10479         metasyntactic variables.
10480         * psymtab.c (_initialize_psymtab): Use upper case for
10481         metasyntactic variables.
10482         * demangle.c (demangle_command): Use upper case for metasyntactic
10483         variables.
10484         (_initialize_demangler): Likewise.
10485         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10486         variables.
10487
10488 2019-01-03  Tom Tromey  <tom@tromey.com>
10489
10490         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10491
10492 2019-01-03  Tom Tromey  <tom@tromey.com>
10493
10494         * python/py-symtab.c (salpy_str): Update.
10495         (struct salpy_sal_object) <symtab>: Now a PyObject.
10496         (salpy_dealloc): Update.
10497         (del_objfile_sal): Use gdbpy_ref.
10498
10499 2019-01-03  Tom Tromey  <tom@tromey.com>
10500
10501         * python/py-type.c (convert_field): Use new_reference.  Return
10502         gdbpy_ref.
10503         (make_fielditem): Return gdbpy_ref.
10504         (typy_fields): Update.
10505         (typy_getitem): Update.
10506         (field_name): Return gdbpy_ref.  Use new_reference.
10507         (typy_iterator_iternext): Update.
10508
10509 2019-01-03  Tom Tromey  <tom@tromey.com>
10510
10511         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10512
10513 2019-01-03  Tom Tromey  <tom@tromey.com>
10514
10515         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10516         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10517         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10518         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10519         (pspy_set_type_printers): Likewise.
10520         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10521         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10522         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10523         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10524         (objfpy_set_type_printers): Likewise.
10525
10526 2019-01-03  Tom Tromey  <tom@tromey.com>
10527
10528         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10529         (gdbpy_print_stack): Use gdbpy_err_fetch.
10530         * python/python-internal.h (class gdbpy_err_fetch): New class.
10531         (class gdbpy_enter) <m_error_type, m_error_value,
10532         m_error_traceback>: Remove.
10533         <m_error>: New member.
10534         (gdbpy_exception_to_string): Don't declare.
10535         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10536         * python/py-value.c (convert_value_from_python): Use
10537         gdbpy_err_fetch.
10538         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10539         gdbpy_exception_to_string.
10540         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10541         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10542         gdbpy_err_fetch.
10543
10544 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10545
10546         * linux-nat.c (delete_lwp_cleanup): Delete.
10547         (struct lwp_deleter): New struct.
10548         (lwp_info_up): New typedef.
10549         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10550         lwp_info_up.
10551
10552 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10553
10554         * linux-fork.c (class scoped_switch_fork_info): New class.
10555         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10556
10557 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10558
10559         * valops.c (find_overload_match): Remove use of null_cleanup, and
10560         calls to do_cleanups.
10561
10562 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10563
10564         * compile/compile-cplus-types.c
10565         (compile_cplus_instance::decl_name): Handle changes to
10566         cp_func_name.
10567         * cp-support.c (cp_func_name): Update header comment, update
10568         return type.
10569         * cp-support.h (cp_func_name): Update return type in declaration.
10570         * valops.c (find_overload_match): Move temp_func local to top
10571         level of function and change its type.  Use temp_func to hold and
10572         delete temporary string obtained from cp_func_name.
10573
10574 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10575
10576         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10577         gdb::char_vector, remove cleanup, and update uses of `msg`.
10578
10579 2019-01-03  Jim Wilson  <jimw@sifive.com>
10580
10581         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10582
10583 2019-01-02  Tom Tromey  <tom@tromey.com>
10584
10585         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10586         (tdesc_parse_xml): Remove cleanups.
10587         * target-descriptions.h (make_cleanup_free_target_description):
10588         Don't declare.
10589         (target_desc_deleter): New struct.
10590         (target_desc_up): New typedef.
10591         * target-descriptions.c (target_desc_deleter::operator()): Rename
10592         from free_target_description.
10593         (make_cleanup_free_target_description): Remove.
10594
10595 2019-01-02  Tom Tromey  <tom@tromey.com>
10596
10597         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10598         constructor, destructor.
10599         (linespec_parser): Remove typedef.
10600         (~linespec_parser): Rename from linespec_parser_delete.
10601         (linespec_lex_to_end, linespec_complete_label)
10602         (linespec_complete): Update.
10603         (decode_line_full): Remove cleanups.
10604         (decode_line_1): Update.
10605
10606 2019-01-02  Tom Tromey  <tom@tromey.com>
10607
10608         * python/python-internal.h (inferior_to_inferior_object): Change
10609         return type.
10610         * python/py-exitedevent.c (create_exited_event_object): Update.
10611         * python/py-inferior.c (inferior_to_inferior_object): Return
10612         gdbpy_ref.
10613         (python_new_inferior, python_inferior_deleted)
10614         (thread_to_thread_object, delete_thread_object)
10615         (build_inferior_list, gdbpy_selected_inferior): Update.
10616         * python/py-infthread.c (create_thread_object): Update.  Also fail
10617         if inferior_to_inferior_object fails.
10618
10619 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10620
10621         * inferior.h (class inferior) <displaced_step_state>: New field.
10622         * infrun.h (struct displaced_step_state): Move here from
10623         infrun.c.  Initialize fields, add constructor.
10624         <inf>: Remove field.
10625         <reset>: New method.
10626         * infrun.c (struct displaced_step_inferior_state): Move to
10627         infrun.h.
10628         (displaced_step_inferior_states): Remove.
10629         (get_displaced_stepping_state): Adust.
10630         (displaced_step_in_progress_any_inferior): Adjust.
10631         (displaced_step_in_progress_thread): Adjust.
10632         (displaced_step_in_progress): Adjust.
10633         (add_displaced_stepping_state): Remove.
10634         (get_displaced_step_closure_by_addr): Adjust.
10635         (remove_displaced_stepping_state): Remove.
10636         (infrun_inferior_exit): Call displaced_step_state.reset.
10637         (use_displaced_stepping): Don't check for NULL.
10638         (displaced_step_prepare_throw): Call
10639         get_displaced_stepping_state.
10640         (displaced_step_fixup): Don't check for NULL.
10641         (prepare_for_detach): Don't check for NULL.
10642
10643 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10644
10645         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10646          in case of call that did not complete.
10647
10648 2019-01-02  Andrey Utkin  <autkin@undo.io>
10649
10650         * symfile.c (find_separate_debug_file): Fix search of debug files for
10651         remote debuggee.
10652
10653 2019-01-02  Tom Tromey  <tom@tromey.com>
10654
10655         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10656         indentation.
10657         * python/py-frame.c (frapy_older): Remove cast.
10658         (frapy_newer): Likewise.
10659         * python/py-breakpoint.c (local_setattro): Remove cast.
10660         * python/py-arch.c (archpy_name): Remove local variable.
10661         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10662
10663 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10664
10665         * unittests/basic_string_view/element_access/char/empty.cc:
10666         Fix year range in copyright header.
10667
10668 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10669
10670         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10671         Delete.
10672         <operator==>: Update with for removed field.
10673         <hash>: Likewise.
10674         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10675         <isa_features>: ...this.
10676         <abi_features>: New field.
10677         (riscv_isa_flen): Update comment.
10678         (riscv_abi_xlen): New declaration.
10679         (riscv_abi_flen): New declaration.
10680         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10681         isa_features.
10682         (riscv_abi_xlen): New function.
10683         (riscv_isa_flen): Update to get answer from isa_features.
10684         (riscv_abi_flen): New function.
10685         (riscv_has_fp_abi): Update to get answer from abi_features.
10686         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10687         xlen and flen.
10688         (riscv_call_info) <xlen, flen>: Update comment.
10689         (riscv_call_arg_struct): Remove invalid assertions
10690         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10691         is removed.
10692         (riscv_gdbarch_init): Gather isa features and abi features
10693         separately, ensure both match on the gdbarch when reusing an old
10694         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10695         a target with 64-bit float hardware.
10696
10697 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10698
10699         * source.c (search_command_helper): Stop reverse search
10700         when line 1 has been searched.
10701
10702 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10703
10704         * record-full.c (record_full_base_target::close): Rewrite
10705         record_full_core_buf_list free logic.
10706
10707 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10708
10709         * break-catch-syscall.c (print_one_catch_syscall): xfree
10710         the last text.
10711
10712 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10713
10714         * top.c (print_gdb_version): Update Copyright year in version
10715         message.
10716
10717 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10718
10719         Update copyright year range in all GDB files.
10720
10721 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10722
10723         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10724
10725 For older changes see ChangeLog-2018.
10726 \f
10727 Local Variables:
10728 mode: change-log
10729 left-margin: 8
10730 fill-column: 74
10731 version-control: never
10732 coding: utf-8
10733 End:
10734