Avoid crash in dwarf2_init_complex_target_type
[external/binutils.git] / gdb / ChangeLog
1 2019-04-17  Tom Tromey  <tromey@adacore.com>
2
3         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4         against nullptr before use.
5
6 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
7
8         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
9
10 2019-04-17  Jim Wilson  <jimw@sifive.com>
11             Andrew Burgess  <andrew.burgess@embecosm.com>
12
13         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
14         code read might fail, assume 4-byte breakpoint in that case.
15
16 2019-04-15  Leszek Swirski  <leszeks@google.com>
17
18         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
19         rather than a hand-rolled POD check when checking for forced MEMORY
20         classification.
21
22 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
23
24         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
25         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
26         function.
27         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
28         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
29         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
30         declaration.
31
32 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
33
34         * aarch64-linux-nat.c
35         (aarch64_linux_nat_target::thread_architecture): Add override.
36         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
37         each VQ.
38
39 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
40
41         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
42
43 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
44
45         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
46         target types of size 96-bits, add some additional comments, and
47         check that the builtin type we found was the correct size.
48
49 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
50
51         * utils.c (prompt_for_continue): Don't restore the styling at the
52         end, as applied_style has the wrong value.  This fixes styling in
53         long lists of file names that are interrupted by the "Continue?"
54         prompt.
55
56 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
57
58         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
59         * c-lang.c (c_language_defn): Likewise.
60         (cplus_language_defn): Likewise.
61         (asm_language_defn): Likewise.
62         (minimal_language_defn): Likewise.
63         * d-lang.c (d_language_defn): Likewise.
64         * f-lang.c (f_language_defn): Likewise.
65         * go-lang.c (go_language_defn): Likewise.
66         * language.c (unknown_language_defn): Likewise.
67         (auto_language_defn): Likewise.
68         * language.h (struct language_defn): Remove la_magic field.
69         (LANG_MAGIC): Delete.
70         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
71         * objc-lang.c (objc_language_defn): Likewise.
72         * opencl-lang.c (opencl_language_defn): Likewise.
73         * p-lang.c (pascal_language_defn): Likewise.
74         * rust-lang.c (rust_language_defn): Likewise.
75
76 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
77
78         * riscv-tdep.c (riscv_type_align): New function.
79         (riscv_type_alignment): Delete.
80         (riscv_arg_location): Use 'type_align'.
81         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
82
83 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
84
85         * gdbtypes.c (type_align): A struct with no non-static fields also
86         has alignment of 1.
87
88 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
89
90         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
91         component to 0.
92         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
93         member.
94         (riscv_struct_info::analyse): New implementation using new
95         analyse_inner member function.
96         (riscv_struct_info::field_offset): New member function.
97         (riscv_struct_info::m_offsets): New member variable.
98         (riscv_struct_info::analyse_inner): New private member function,
99         takes the old implementation of riscv_struct_info::analyse but
100         extended to track field offsets.
101         (riscv_call_arg_struct): Update the struct folding special cases
102         to handle cases where empty C++ structs, which are non-zero
103         length, are found.
104         (riscv_arg_location): Initialise the length of each location, a
105         non-zero length now indicates the location is in use.
106         (riscv_push_dummy_call): Allow for the first location having a
107         non-zero offset when setting up arguments.
108         (riscv_return_value): Likewise, but for return values.
109
110 2019-04-11  Tom Tromey  <tromey@adacore.com>
111
112         * utils.c (internal_vproblem): Make "msg" const.
113
114 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
115
116         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
117         * trad-frame.c (trad_frame_reset_saved_regs): New function.
118         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
119         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
120
121 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
122
123         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
124         function.
125         (fill_gregset): Call amd64_linux_collect_native_gregset instead
126         of amd64_collect_native_gregset.
127         (amd64_linux_nat_target::store_registers): Likewise.
128
129 2019-04-10  Tom Tromey  <tom@tromey.com>
130
131         * symtab.c (lookup_global_symbol_from_objfile)
132         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
133         * objfiles.h (class separate_debug_iterator): New.
134         (class separate_debug_range): New.
135         (struct objfile) <separate_debug_objfiles>: New method.
136         (objfile_separate_debug_iterate): Don't declare.
137         * objfiles.c (separate_debug_iterator::operator++): Rename from
138         objfile_separate_debug_iterate.
139         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
140         iterator.
141         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
142         iterator.
143
144 2019-04-10  Tom Tromey  <tom@tromey.com>
145
146         * symfile.c (reread_symbols): Remove old comment.
147         * objfiles.c (free_all_objfiles): Fix a typo.
148
149 2019-04-10  Tom Tromey  <tom@tromey.com>
150
151         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
152         * minsyms.c (lookup_minimal_symbol): Use foreach.
153         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
154         (lookup_minimal_symbol_solib_trampoline): Likewise.
155         * symfile.c (reread_symbols): Use foreach.
156
157 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
158             Tom Tromey  <tromey@adacore.com>
159
160         PR rust/24414:
161         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
162         (rust_lex_int_test): Change "value" to be LONGEST.
163         (rust_lex_tests): Add test for long integer literal.
164
165 2019-04-09  Tom Tromey  <tromey@adacore.com>
166
167         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
168         to bool.
169         (extended_remote_target::attach): Update.
170         (remote_target::remote_notice_new_inferior): Update.
171         (remote_target::add_current_inferior_and_thread): Update.
172         * inferior.c (exit_inferior_1): Use "false".
173         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
174
175 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
176
177         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
178         the "start" command.
179
180 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
181
182         * python/py-inferior.c (infpy_thread_from_thread_handle):
183         Adjust comments to reflect renaming of thread_from_thread_handle
184         to thread_from_handle.  Adjust keywords.  Fix type error message.
185         (inferior_object_methods): Add thread_from_handle.  Retain
186         thread_from_thread_handle, but mark it as deprecated.
187
188 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
189
190         * gdbthread.h (find_thread_by_handle): Revise declaration.
191         * thread.c (find_thread_by_handle): Likewise.  Adjust
192         implementation too.
193         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
194         support for buffer objects as handles.
195
196 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
197
198         * python/py-infthread.c (thpy_thread_handle): New function.
199         (thread_object_methods): Register thpy_thread_handle.
200
201 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
202
203         * gdbthread.h (thread_to_thread_handle): Declare.
204         * thread.c (gdbtypes.h): Include.
205         (thread_to_thread_handle): New function.
206
207         * target.h (struct target_ops): Add thread_info_to_thread_handle.
208         (target_thread_info_to_thread_handle): Declare.
209         * target.c (target_thread_info_to_thread_handle): New function.
210         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
211         * target-delegates.c: Regenerate.
212
213         * linux-thread-db.c (class thread_db_target): Add method
214         thread_info_to_thread_handle.
215         (thread_db_target::thread_info_to_thread_handle): Define.
216         * remote.c (class remote_target): Add new method
217         thread_info_to_thread_handle.
218         (remote_target::thread_info_to_thread_handle): Define.
219
220 2019-04-08  Pedro Alves  <palves@redhat.com>
221
222         * common/common-exceptions.c (throw_exception): Don't create
223         named object to throw; throw directly.
224         (throw_it): Likewise.  Don't initialize gdb_exception::message
225         here, with new; pass FMT and AP to the ctor instead.
226         * common/common-exceptions.h: Include <string>.
227         (gdb_exception::gdb_exception(enum return_reason, enum errors,
228         const char *, va_list)): New ctor.  Use std::make_shared.
229         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
230         errors)): Delete.
231         (gdb_exception_error::gdb_exception_error(enum errors, const char
232         *, va_list)): New.
233         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
234         Add assertion.
235         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
236         errors)): Delete.
237         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
238         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
239         Add assertion.
240
241 2019-04-08  Tom Tromey  <tom@tromey.com>
242
243         * valops.c (value_rtti_indirect_type): Replace throw_exception
244         with throw.
245         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
246         with throw.
247         * thread.c (thr_try_catch_cmd): Replace throw_exception with
248         throw.
249         * target.c (target_translate_tls_address): Replace throw_exception
250         with throw.
251         * stack.c (frame_apply_command_count): Replace throw_exception
252         with throw.
253         * solib-spu.c (append_ocl_sos): Replace throw_exception with
254         throw.
255         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
256         with throw.
257         * rs6000-tdep.c (rs6000_frame_cache)
258         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
259         * remote.c: Replace throw_exception with throw.
260         * record-full.c (record_full_message, record_full_wait_1)
261         (record_full_restore): Replace throw_exception with throw.
262         * record-btrace.c:
263         (get_thread_current_frame_id, record_btrace_start_replaying)
264         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
265         (cmd_record_btrace_start): Replace throw_exception with throw.
266         * parse.c (parse_exp_in_context_1): Replace throw_exception with
267         throw.
268         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
269         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
270         * linespec.c:
271         (find_linespec_symbols): Replace throw_exception with throw.
272         * infrun.c (displaced_step_prepare, resume): Replace
273         throw_exception with throw.
274         * infcmd.c (post_create_inferior): Replace throw_exception with
275         throw.
276         * inf-loop.c (inferior_event_handler): Replace throw_exception
277         with throw.
278         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
279         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
280         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
281         (get_prev_frame_always, get_frame_pc_if_available)
282         (get_frame_address_in_block_if_available, get_frame_language):
283         Replace throw_exception with throw.
284         * frame-unwind.c (frame_unwind_try_unwinder): Replace
285         throw_exception with throw.
286         * eval.c (fetch_subexp_value, evaluate_var_value)
287         (evaluate_funcall, evaluate_subexp_standard): Replace
288         throw_exception with throw.
289         * dwarf2loc.c (call_site_find_chain)
290         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
291         Replace throw_exception with throw.
292         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
293         with throw.
294         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
295         throw.
296         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
297         * completer.c (complete_line_internal): Replace throw_exception
298         with throw.
299         * compile/compile-object-run.c (compile_object_run): Replace
300         throw_exception with throw.
301         * cli/cli-script.c (process_next_line): Replace throw_exception
302         with throw.
303         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
304         (btrace_enable, btrace_maint_update_pt_packets): Replace
305         throw_exception with throw.
306         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
307         throw_exception with throw.
308         * break-catch-throw.c (re_set_exception_catchpoint): Replace
309         throw_exception with throw.
310         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
311         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
312         * aarch64-tdep.c (aarch64_make_prologue_cache)
313         (aarch64_make_stub_cache): Replace throw_exception with throw.
314
315 2019-04-08  Tom Tromey  <tom@tromey.com>
316
317         * common/common-exceptions.c (throw_exception): Rename from
318         throw_exception_cxx.  Remove old copy.  Make argument const.
319         (throw_it): Create and throw exception objects directly.
320         * common/common-exceptions.h (throw_exception): Make argument
321         const.
322         (struct gdb_exception_error): Add constructor.
323         (struct gdb_exception_quit): Add constructor.
324
325 2019-04-08  Tom Tromey  <tom@tromey.com>
326
327         * common/common-exceptions.h (exception_rethrow): Don't declare.
328         (TRY_SJLJ): Update comment.
329         (TRY, CATCH, END_CATCH): Remove.
330         * common/common-exceptions.c (exception_rethrow): Remove.
331
332 2019-04-08  Tom Tromey  <tom@tromey.com>
333
334         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
335         Remove.
336         (gdb_exception_error): Rename from
337         gdb_exception_RETURN_MASK_ERROR.
338         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
339         (gdb_quit_bad_alloc): Update.
340         * aarch64-tdep.c: Update.
341         * ada-lang.c: Update.
342         * ada-typeprint.c: Update.
343         * ada-valprint.c: Update.
344         * amd64-tdep.c: Update.
345         * arch-utils.c: Update.
346         * break-catch-throw.c: Update.
347         * breakpoint.c: Update.
348         * btrace.c: Update.
349         * c-varobj.c: Update.
350         * cli/cli-cmds.c: Update.
351         * cli/cli-interp.c: Update.
352         * cli/cli-script.c: Update.
353         * common/common-exceptions.c: Update.
354         * common/new-op.c: Update.
355         * common/selftest.c: Update.
356         * compile/compile-c-symbols.c: Update.
357         * compile/compile-cplus-symbols.c: Update.
358         * compile/compile-object-load.c: Update.
359         * compile/compile-object-run.c: Update.
360         * completer.c: Update.
361         * corelow.c: Update.
362         * cp-abi.c: Update.
363         * cp-support.c: Update.
364         * cp-valprint.c: Update.
365         * darwin-nat.c: Update.
366         * disasm-selftests.c: Update.
367         * dtrace-probe.c: Update.
368         * dwarf-index-cache.c: Update.
369         * dwarf-index-write.c: Update.
370         * dwarf2-frame-tailcall.c: Update.
371         * dwarf2-frame.c: Update.
372         * dwarf2loc.c: Update.
373         * dwarf2read.c: Update.
374         * eval.c: Update.
375         * event-loop.c: Update.
376         * event-top.c: Update.
377         * exec.c: Update.
378         * f-valprint.c: Update.
379         * fbsd-tdep.c: Update.
380         * frame-unwind.c: Update.
381         * frame.c: Update.
382         * gdbtypes.c: Update.
383         * gnu-v3-abi.c: Update.
384         * guile/guile-internal.h: Update.
385         * guile/scm-block.c: Update.
386         * guile/scm-breakpoint.c: Update.
387         * guile/scm-cmd.c: Update.
388         * guile/scm-disasm.c: Update.
389         * guile/scm-frame.c: Update.
390         * guile/scm-lazy-string.c: Update.
391         * guile/scm-math.c: Update.
392         * guile/scm-param.c: Update.
393         * guile/scm-ports.c: Update.
394         * guile/scm-pretty-print.c: Update.
395         * guile/scm-symbol.c: Update.
396         * guile/scm-symtab.c: Update.
397         * guile/scm-type.c: Update.
398         * guile/scm-value.c: Update.
399         * i386-linux-tdep.c: Update.
400         * i386-tdep.c: Update.
401         * inf-loop.c: Update.
402         * infcall.c: Update.
403         * infcmd.c: Update.
404         * infrun.c: Update.
405         * jit.c: Update.
406         * language.c: Update.
407         * linespec.c: Update.
408         * linux-fork.c: Update.
409         * linux-nat.c: Update.
410         * linux-tdep.c: Update.
411         * linux-thread-db.c: Update.
412         * main.c: Update.
413         * mi/mi-cmd-break.c: Update.
414         * mi/mi-cmd-stack.c: Update.
415         * mi/mi-interp.c: Update.
416         * mi/mi-main.c: Update.
417         * objc-lang.c: Update.
418         * p-valprint.c: Update.
419         * parse.c: Update.
420         * ppc-linux-tdep.c: Update.
421         * printcmd.c: Update.
422         * python/py-arch.c: Update.
423         * python/py-breakpoint.c: Update.
424         * python/py-cmd.c: Update.
425         * python/py-finishbreakpoint.c: Update.
426         * python/py-frame.c: Update.
427         * python/py-framefilter.c: Update.
428         * python/py-gdb-readline.c: Update.
429         * python/py-inferior.c: Update.
430         * python/py-infthread.c: Update.
431         * python/py-lazy-string.c: Update.
432         * python/py-linetable.c: Update.
433         * python/py-objfile.c: Update.
434         * python/py-param.c: Update.
435         * python/py-prettyprint.c: Update.
436         * python/py-progspace.c: Update.
437         * python/py-record-btrace.c: Update.
438         * python/py-record.c: Update.
439         * python/py-symbol.c: Update.
440         * python/py-type.c: Update.
441         * python/py-unwind.c: Update.
442         * python/py-utils.c: Update.
443         * python/py-value.c: Update.
444         * python/python.c: Update.
445         * record-btrace.c: Update.
446         * record-full.c: Update.
447         * remote-fileio.c: Update.
448         * remote.c: Update.
449         * riscv-tdep.c: Update.
450         * rs6000-aix-tdep.c: Update.
451         * rs6000-tdep.c: Update.
452         * rust-exp.y: Update.
453         * rust-lang.c: Update.
454         * s390-tdep.c: Update.
455         * selftest-arch.c: Update.
456         * solib-dsbt.c: Update.
457         * solib-frv.c: Update.
458         * solib-spu.c: Update.
459         * solib-svr4.c: Update.
460         * solib.c: Update.
461         * sparc64-linux-tdep.c: Update.
462         * stack.c: Update.
463         * symfile-mem.c: Update.
464         * symmisc.c: Update.
465         * target.c: Update.
466         * thread.c: Update.
467         * top.c: Update.
468         * tracefile-tfile.c: Update.
469         * tui/tui.c: Update.
470         * typeprint.c: Update.
471         * unittests/cli-utils-selftests.c: Update.
472         * unittests/parse-connection-spec-selftests.c: Update.
473         * valops.c: Update.
474         * valprint.c: Update.
475         * value.c: Update.
476         * varobj.c: Update.
477         * windows-nat.c: Update.
478         * x86-linux-nat.c: Update.
479         * xml-support.c: Update.
480
481 2019-04-08  Tom Tromey  <tom@tromey.com>
482
483         * xml-support.c: Use C++ exception handling.
484         * x86-linux-nat.c: Use C++ exception handling.
485         * windows-nat.c: Use C++ exception handling.
486         * varobj.c: Use C++ exception handling.
487         * value.c: Use C++ exception handling.
488         * valprint.c: Use C++ exception handling.
489         * valops.c: Use C++ exception handling.
490         * unittests/parse-connection-spec-selftests.c: Use C++ exception
491         handling.
492         * unittests/cli-utils-selftests.c: Use C++ exception handling.
493         * typeprint.c: Use C++ exception handling.
494         * tui/tui.c: Use C++ exception handling.
495         * tracefile-tfile.c: Use C++ exception handling.
496         * top.c: Use C++ exception handling.
497         * thread.c: Use C++ exception handling.
498         * target.c: Use C++ exception handling.
499         * symmisc.c: Use C++ exception handling.
500         * symfile-mem.c: Use C++ exception handling.
501         * stack.c: Use C++ exception handling.
502         * sparc64-linux-tdep.c: Use C++ exception handling.
503         * solib.c: Use C++ exception handling.
504         * solib-svr4.c: Use C++ exception handling.
505         * solib-spu.c: Use C++ exception handling.
506         * solib-frv.c: Use C++ exception handling.
507         * solib-dsbt.c: Use C++ exception handling.
508         * selftest-arch.c: Use C++ exception handling.
509         * s390-tdep.c: Use C++ exception handling.
510         * rust-lang.c: Use C++ exception handling.
511         * rust-exp.y: Use C++ exception handling.
512         * rs6000-tdep.c: Use C++ exception handling.
513         * rs6000-aix-tdep.c: Use C++ exception handling.
514         * riscv-tdep.c: Use C++ exception handling.
515         * remote.c: Use C++ exception handling.
516         * remote-fileio.c: Use C++ exception handling.
517         * record-full.c: Use C++ exception handling.
518         * record-btrace.c: Use C++ exception handling.
519         * python/python.c: Use C++ exception handling.
520         * python/py-value.c: Use C++ exception handling.
521         * python/py-utils.c: Use C++ exception handling.
522         * python/py-unwind.c: Use C++ exception handling.
523         * python/py-type.c: Use C++ exception handling.
524         * python/py-symbol.c: Use C++ exception handling.
525         * python/py-record.c: Use C++ exception handling.
526         * python/py-record-btrace.c: Use C++ exception handling.
527         * python/py-progspace.c: Use C++ exception handling.
528         * python/py-prettyprint.c: Use C++ exception handling.
529         * python/py-param.c: Use C++ exception handling.
530         * python/py-objfile.c: Use C++ exception handling.
531         * python/py-linetable.c: Use C++ exception handling.
532         * python/py-lazy-string.c: Use C++ exception handling.
533         * python/py-infthread.c: Use C++ exception handling.
534         * python/py-inferior.c: Use C++ exception handling.
535         * python/py-gdb-readline.c: Use C++ exception handling.
536         * python/py-framefilter.c: Use C++ exception handling.
537         * python/py-frame.c: Use C++ exception handling.
538         * python/py-finishbreakpoint.c: Use C++ exception handling.
539         * python/py-cmd.c: Use C++ exception handling.
540         * python/py-breakpoint.c: Use C++ exception handling.
541         * python/py-arch.c: Use C++ exception handling.
542         * printcmd.c: Use C++ exception handling.
543         * ppc-linux-tdep.c: Use C++ exception handling.
544         * parse.c: Use C++ exception handling.
545         * p-valprint.c: Use C++ exception handling.
546         * objc-lang.c: Use C++ exception handling.
547         * mi/mi-main.c: Use C++ exception handling.
548         * mi/mi-interp.c: Use C++ exception handling.
549         * mi/mi-cmd-stack.c: Use C++ exception handling.
550         * mi/mi-cmd-break.c: Use C++ exception handling.
551         * main.c: Use C++ exception handling.
552         * linux-thread-db.c: Use C++ exception handling.
553         * linux-tdep.c: Use C++ exception handling.
554         * linux-nat.c: Use C++ exception handling.
555         * linux-fork.c: Use C++ exception handling.
556         * linespec.c: Use C++ exception handling.
557         * language.c: Use C++ exception handling.
558         * jit.c: Use C++ exception handling.
559         * infrun.c: Use C++ exception handling.
560         * infcmd.c: Use C++ exception handling.
561         * infcall.c: Use C++ exception handling.
562         * inf-loop.c: Use C++ exception handling.
563         * i386-tdep.c: Use C++ exception handling.
564         * i386-linux-tdep.c: Use C++ exception handling.
565         * guile/scm-value.c: Use C++ exception handling.
566         * guile/scm-type.c: Use C++ exception handling.
567         * guile/scm-symtab.c: Use C++ exception handling.
568         * guile/scm-symbol.c: Use C++ exception handling.
569         * guile/scm-pretty-print.c: Use C++ exception handling.
570         * guile/scm-ports.c: Use C++ exception handling.
571         * guile/scm-param.c: Use C++ exception handling.
572         * guile/scm-math.c: Use C++ exception handling.
573         * guile/scm-lazy-string.c: Use C++ exception handling.
574         * guile/scm-frame.c: Use C++ exception handling.
575         * guile/scm-disasm.c: Use C++ exception handling.
576         * guile/scm-cmd.c: Use C++ exception handling.
577         * guile/scm-breakpoint.c: Use C++ exception handling.
578         * guile/scm-block.c: Use C++ exception handling.
579         * guile/guile-internal.h: Use C++ exception handling.
580         * gnu-v3-abi.c: Use C++ exception handling.
581         * gdbtypes.c: Use C++ exception handling.
582         * frame.c: Use C++ exception handling.
583         * frame-unwind.c: Use C++ exception handling.
584         * fbsd-tdep.c: Use C++ exception handling.
585         * f-valprint.c: Use C++ exception handling.
586         * exec.c: Use C++ exception handling.
587         * event-top.c: Use C++ exception handling.
588         * event-loop.c: Use C++ exception handling.
589         * eval.c: Use C++ exception handling.
590         * dwarf2read.c: Use C++ exception handling.
591         * dwarf2loc.c: Use C++ exception handling.
592         * dwarf2-frame.c: Use C++ exception handling.
593         * dwarf2-frame-tailcall.c: Use C++ exception handling.
594         * dwarf-index-write.c: Use C++ exception handling.
595         * dwarf-index-cache.c: Use C++ exception handling.
596         * dtrace-probe.c: Use C++ exception handling.
597         * disasm-selftests.c: Use C++ exception handling.
598         * darwin-nat.c: Use C++ exception handling.
599         * cp-valprint.c: Use C++ exception handling.
600         * cp-support.c: Use C++ exception handling.
601         * cp-abi.c: Use C++ exception handling.
602         * corelow.c: Use C++ exception handling.
603         * completer.c: Use C++ exception handling.
604         * compile/compile-object-run.c: Use C++ exception handling.
605         * compile/compile-object-load.c: Use C++ exception handling.
606         * compile/compile-cplus-symbols.c: Use C++ exception handling.
607         * compile/compile-c-symbols.c: Use C++ exception handling.
608         * common/selftest.c: Use C++ exception handling.
609         * common/new-op.c: Use C++ exception handling.
610         * cli/cli-script.c: Use C++ exception handling.
611         * cli/cli-interp.c: Use C++ exception handling.
612         * cli/cli-cmds.c: Use C++ exception handling.
613         * c-varobj.c: Use C++ exception handling.
614         * btrace.c: Use C++ exception handling.
615         * breakpoint.c: Use C++ exception handling.
616         * break-catch-throw.c: Use C++ exception handling.
617         * arch-utils.c: Use C++ exception handling.
618         * amd64-tdep.c: Use C++ exception handling.
619         * ada-valprint.c: Use C++ exception handling.
620         * ada-typeprint.c: Use C++ exception handling.
621         * ada-lang.c: Use C++ exception handling.
622         * aarch64-tdep.c: Use C++ exception handling.
623
624 2019-04-08  Tom Tromey  <tom@tromey.com>
625
626         * xml-support.c (gdb_xml_parser::parse): Update.
627         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
628         * value.c (show_convenience): Update.
629         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
630         (test_parse_flags_qcs): Update.
631         * thread.c (thr_try_catch_cmd): Update.
632         * target.c (target_translate_tls_address): Update.
633         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
634         (info_frame_command_core, frame_apply_command_count): Update.
635         * rust-exp.y (rust_lex_exception_test): Update.
636         * riscv-tdep.c (riscv_print_one_register_info): Update.
637         * remote.c (remote_target::enable_btrace): Update.
638         * record-btrace.c (record_btrace_enable_warn): Update.
639         * python/py-utils.c (gdbpy_convert_exception): Update.
640         * printcmd.c (do_one_display, print_variable_and_value): Update.
641         * mi/mi-main.c (mi_print_exception): Update.
642         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
643         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
644         * linux-nat.c (linux_nat_target::attach): Update.
645         * linux-fork.c (class scoped_switch_fork_info): Update.
646         * infrun.c (displaced_step_prepare): Update.
647         * infcall.c (call_function_by_hand_dummy): Update.
648         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
649         * gnu-v3-abi.c (print_one_vtable): Update.
650         * frame.c (get_prev_frame_always): Update.
651         * f-valprint.c (info_common_command_for_block): Update.
652         * exec.c (try_open_exec_file): Update.
653         * exceptions.c (print_exception, exception_print)
654         (exception_fprintf, exception_print_same): Update.
655         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
656         * dwarf-index-cache.c (index_cache::store)
657         (index_cache::lookup_gdb_index): Update.
658         * darwin-nat.c (maybe_cache_shell): Update.
659         * cp-valprint.c (cp_print_value_fields): Update.
660         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
661         (gcc_cplus_symbol_address): Update.
662         * compile/compile-c-symbols.c (gcc_convert_symbol)
663         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
664         * common/selftest.c: Update.
665         * common/common-exceptions.h (struct gdb_exception) <message>: Now
666         a std::string.
667         (exception_try_scope_entry, exception_try_scope_exit): Don't
668         declare.
669         (struct exception_try_scope): Remove.
670         (TRY): Don't use exception_try_scope.
671         (struct gdb_exception): Add constructor, operator=.
672         <what>: New method.
673         (struct gdb_exception_RETURN_MASK_ALL)
674         (struct gdb_exception_RETURN_MASK_ERROR)
675         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
676         (struct gdb_quit_bad_alloc): Update.
677         * common/common-exceptions.c (exception_none): Change
678         initializer.
679         (struct catcher) <state, exception>: Initialize inline.
680         <prev>: Remove member.
681         (current_catcher): Remove.
682         (catchers): New global.
683         (exceptions_state_mc_init): Simplify.
684         (catcher_pop): Remove.
685         (exceptions_state_mc, exceptions_state_mc_catch): Update.
686         (try_scope_depth, exception_try_scope_entry)
687         (exception_try_scope_exit): Remove.
688         (throw_exception_sjlj): Update.
689         (exception_messages, exception_messages_size): Remove.
690         (throw_it): Simplify.
691         (gdb_exception_sliced_copy): Remove.
692         (throw_exception_cxx): Update.
693         * cli/cli-script.c (script_from_file): Update.
694         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
695         Update.
696         * ada-valprint.c (ada_val_print): Update.
697         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
698         (create_excep_cond_exprs): Update.
699
700 2019-04-08  Tom Tromey  <tom@tromey.com>
701
702         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
703         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
704         (TRY, CATCH, END_CATCH): Remove some definitions.
705         * common/common-exceptions.c: Don't use GDB_XCPT.
706         (catcher_list_size): Remove.
707         (throw_exception, throw_it): Simplify.
708
709 2019-04-05  Tom Tromey  <tom@tromey.com>
710
711         Revert the header-sorting patch.
712         * ft32-tdep.c: Revert.
713         * frv-tdep.c: Revert.
714         * frv-linux-tdep.c: Revert.
715         * frame.c: Revert.
716         * frame-unwind.c: Revert.
717         * frame-base.c: Revert.
718         * fork-child.c: Revert.
719         * findvar.c: Revert.
720         * findcmd.c: Revert.
721         * filesystem.c: Revert.
722         * filename-seen-cache.h: Revert.
723         * filename-seen-cache.c: Revert.
724         * fbsd-tdep.c: Revert.
725         * fbsd-nat.h: Revert.
726         * fbsd-nat.c: Revert.
727         * f-valprint.c: Revert.
728         * f-typeprint.c: Revert.
729         * f-lang.c: Revert.
730         * extension.h: Revert.
731         * extension.c: Revert.
732         * extension-priv.h: Revert.
733         * expprint.c: Revert.
734         * exec.h: Revert.
735         * exec.c: Revert.
736         * exceptions.c: Revert.
737         * event-top.c: Revert.
738         * event-loop.c: Revert.
739         * eval.c: Revert.
740         * elfread.c: Revert.
741         * dwarf2read.h: Revert.
742         * dwarf2read.c: Revert.
743         * dwarf2loc.c: Revert.
744         * dwarf2expr.h: Revert.
745         * dwarf2expr.c: Revert.
746         * dwarf2-frame.c: Revert.
747         * dwarf2-frame-tailcall.c: Revert.
748         * dwarf-index-write.h: Revert.
749         * dwarf-index-write.c: Revert.
750         * dwarf-index-common.c: Revert.
751         * dwarf-index-cache.h: Revert.
752         * dwarf-index-cache.c: Revert.
753         * dummy-frame.c: Revert.
754         * dtrace-probe.c: Revert.
755         * disasm.h: Revert.
756         * disasm.c: Revert.
757         * disasm-selftests.c: Revert.
758         * dictionary.c: Revert.
759         * dicos-tdep.c: Revert.
760         * demangle.c: Revert.
761         * dcache.h: Revert.
762         * dcache.c: Revert.
763         * darwin-nat.h: Revert.
764         * darwin-nat.c: Revert.
765         * darwin-nat-info.c: Revert.
766         * d-valprint.c: Revert.
767         * d-namespace.c: Revert.
768         * d-lang.c: Revert.
769         * ctf.c: Revert.
770         * csky-tdep.c: Revert.
771         * csky-linux-tdep.c: Revert.
772         * cris-tdep.c: Revert.
773         * cris-linux-tdep.c: Revert.
774         * cp-valprint.c: Revert.
775         * cp-support.c: Revert.
776         * cp-namespace.c: Revert.
777         * cp-abi.c: Revert.
778         * corelow.c: Revert.
779         * corefile.c: Revert.
780         * continuations.c: Revert.
781         * completer.h: Revert.
782         * completer.c: Revert.
783         * complaints.c: Revert.
784         * coffread.c: Revert.
785         * coff-pe-read.c: Revert.
786         * cli-out.h: Revert.
787         * cli-out.c: Revert.
788         * charset.c: Revert.
789         * c-varobj.c: Revert.
790         * c-valprint.c: Revert.
791         * c-typeprint.c: Revert.
792         * c-lang.c: Revert.
793         * buildsym.c: Revert.
794         * buildsym-legacy.c: Revert.
795         * build-id.h: Revert.
796         * build-id.c: Revert.
797         * btrace.c: Revert.
798         * bsd-uthread.c: Revert.
799         * breakpoint.h: Revert.
800         * breakpoint.c: Revert.
801         * break-catch-throw.c: Revert.
802         * break-catch-syscall.c: Revert.
803         * break-catch-sig.c: Revert.
804         * blockframe.c: Revert.
805         * block.c: Revert.
806         * bfin-tdep.c: Revert.
807         * bfin-linux-tdep.c: Revert.
808         * bfd-target.c: Revert.
809         * bcache.c: Revert.
810         * ax-general.c: Revert.
811         * ax-gdb.h: Revert.
812         * ax-gdb.c: Revert.
813         * avr-tdep.c: Revert.
814         * auxv.c: Revert.
815         * auto-load.c: Revert.
816         * arm-wince-tdep.c: Revert.
817         * arm-tdep.c: Revert.
818         * arm-symbian-tdep.c: Revert.
819         * arm-pikeos-tdep.c: Revert.
820         * arm-obsd-tdep.c: Revert.
821         * arm-nbsd-tdep.c: Revert.
822         * arm-nbsd-nat.c: Revert.
823         * arm-linux-tdep.c: Revert.
824         * arm-linux-nat.c: Revert.
825         * arm-fbsd-tdep.c: Revert.
826         * arm-fbsd-nat.c: Revert.
827         * arm-bsd-tdep.c: Revert.
828         * arch-utils.c: Revert.
829         * arc-tdep.c: Revert.
830         * arc-newlib-tdep.c: Revert.
831         * annotate.h: Revert.
832         * annotate.c: Revert.
833         * amd64-windows-tdep.c: Revert.
834         * amd64-windows-nat.c: Revert.
835         * amd64-tdep.c: Revert.
836         * amd64-sol2-tdep.c: Revert.
837         * amd64-obsd-tdep.c: Revert.
838         * amd64-obsd-nat.c: Revert.
839         * amd64-nbsd-tdep.c: Revert.
840         * amd64-nbsd-nat.c: Revert.
841         * amd64-nat.c: Revert.
842         * amd64-linux-tdep.c: Revert.
843         * amd64-linux-nat.c: Revert.
844         * amd64-fbsd-tdep.c: Revert.
845         * amd64-fbsd-nat.c: Revert.
846         * amd64-dicos-tdep.c: Revert.
847         * amd64-darwin-tdep.c: Revert.
848         * amd64-bsd-nat.c: Revert.
849         * alpha-tdep.c: Revert.
850         * alpha-obsd-tdep.c: Revert.
851         * alpha-nbsd-tdep.c: Revert.
852         * alpha-mdebug-tdep.c: Revert.
853         * alpha-linux-tdep.c: Revert.
854         * alpha-linux-nat.c: Revert.
855         * alpha-bsd-tdep.c: Revert.
856         * alpha-bsd-nat.c: Revert.
857         * aix-thread.c: Revert.
858         * agent.c: Revert.
859         * addrmap.c: Revert.
860         * ada-varobj.c: Revert.
861         * ada-valprint.c: Revert.
862         * ada-typeprint.c: Revert.
863         * ada-tasks.c: Revert.
864         * ada-lang.c: Revert.
865         * aarch64-tdep.c: Revert.
866         * aarch64-ravenscar-thread.c: Revert.
867         * aarch64-newlib-tdep.c: Revert.
868         * aarch64-linux-tdep.c: Revert.
869         * aarch64-linux-nat.c: Revert.
870         * aarch64-fbsd-tdep.c: Revert.
871         * aarch64-fbsd-nat.c: Revert.
872         * aarch32-linux-nat.c: Revert.
873
874 2019-04-05  Tom Tromey  <tom@tromey.com>
875
876         * ft32-tdep.c: Sort headers.
877         * frv-tdep.c: Sort headers.
878         * frv-linux-tdep.c: Sort headers.
879         * frame.c: Sort headers.
880         * frame-unwind.c: Sort headers.
881         * frame-base.c: Sort headers.
882         * fork-child.c: Sort headers.
883         * findvar.c: Sort headers.
884         * findcmd.c: Sort headers.
885         * filesystem.c: Sort headers.
886         * filename-seen-cache.h: Sort headers.
887         * filename-seen-cache.c: Sort headers.
888         * fbsd-tdep.c: Sort headers.
889         * fbsd-nat.h: Sort headers.
890         * fbsd-nat.c: Sort headers.
891         * f-valprint.c: Sort headers.
892         * f-typeprint.c: Sort headers.
893         * f-lang.c: Sort headers.
894         * extension.h: Sort headers.
895         * extension.c: Sort headers.
896         * extension-priv.h: Sort headers.
897         * expprint.c: Sort headers.
898         * exec.h: Sort headers.
899         * exec.c: Sort headers.
900         * exceptions.c: Sort headers.
901         * event-top.c: Sort headers.
902         * event-loop.c: Sort headers.
903         * eval.c: Sort headers.
904         * elfread.c: Sort headers.
905         * dwarf2read.h: Sort headers.
906         * dwarf2read.c: Sort headers.
907         * dwarf2loc.c: Sort headers.
908         * dwarf2expr.h: Sort headers.
909         * dwarf2expr.c: Sort headers.
910         * dwarf2-frame.c: Sort headers.
911         * dwarf2-frame-tailcall.c: Sort headers.
912         * dwarf-index-write.h: Sort headers.
913         * dwarf-index-write.c: Sort headers.
914         * dwarf-index-common.c: Sort headers.
915         * dwarf-index-cache.h: Sort headers.
916         * dwarf-index-cache.c: Sort headers.
917         * dummy-frame.c: Sort headers.
918         * dtrace-probe.c: Sort headers.
919         * disasm.h: Sort headers.
920         * disasm.c: Sort headers.
921         * disasm-selftests.c: Sort headers.
922         * dictionary.c: Sort headers.
923         * dicos-tdep.c: Sort headers.
924         * demangle.c: Sort headers.
925         * dcache.h: Sort headers.
926         * dcache.c: Sort headers.
927         * darwin-nat.h: Sort headers.
928         * darwin-nat.c: Sort headers.
929         * darwin-nat-info.c: Sort headers.
930         * d-valprint.c: Sort headers.
931         * d-namespace.c: Sort headers.
932         * d-lang.c: Sort headers.
933         * ctf.c: Sort headers.
934         * csky-tdep.c: Sort headers.
935         * csky-linux-tdep.c: Sort headers.
936         * cris-tdep.c: Sort headers.
937         * cris-linux-tdep.c: Sort headers.
938         * cp-valprint.c: Sort headers.
939         * cp-support.c: Sort headers.
940         * cp-namespace.c: Sort headers.
941         * cp-abi.c: Sort headers.
942         * corelow.c: Sort headers.
943         * corefile.c: Sort headers.
944         * continuations.c: Sort headers.
945         * completer.h: Sort headers.
946         * completer.c: Sort headers.
947         * complaints.c: Sort headers.
948         * coffread.c: Sort headers.
949         * coff-pe-read.c: Sort headers.
950         * cli-out.h: Sort headers.
951         * cli-out.c: Sort headers.
952         * charset.c: Sort headers.
953         * c-varobj.c: Sort headers.
954         * c-valprint.c: Sort headers.
955         * c-typeprint.c: Sort headers.
956         * c-lang.c: Sort headers.
957         * buildsym.c: Sort headers.
958         * buildsym-legacy.c: Sort headers.
959         * build-id.h: Sort headers.
960         * build-id.c: Sort headers.
961         * btrace.c: Sort headers.
962         * bsd-uthread.c: Sort headers.
963         * breakpoint.h: Sort headers.
964         * breakpoint.c: Sort headers.
965         * break-catch-throw.c: Sort headers.
966         * break-catch-syscall.c: Sort headers.
967         * break-catch-sig.c: Sort headers.
968         * blockframe.c: Sort headers.
969         * block.c: Sort headers.
970         * bfin-tdep.c: Sort headers.
971         * bfin-linux-tdep.c: Sort headers.
972         * bfd-target.c: Sort headers.
973         * bcache.c: Sort headers.
974         * ax-general.c: Sort headers.
975         * ax-gdb.h: Sort headers.
976         * ax-gdb.c: Sort headers.
977         * avr-tdep.c: Sort headers.
978         * auxv.c: Sort headers.
979         * auto-load.c: Sort headers.
980         * arm-wince-tdep.c: Sort headers.
981         * arm-tdep.c: Sort headers.
982         * arm-symbian-tdep.c: Sort headers.
983         * arm-pikeos-tdep.c: Sort headers.
984         * arm-obsd-tdep.c: Sort headers.
985         * arm-nbsd-tdep.c: Sort headers.
986         * arm-nbsd-nat.c: Sort headers.
987         * arm-linux-tdep.c: Sort headers.
988         * arm-linux-nat.c: Sort headers.
989         * arm-fbsd-tdep.c: Sort headers.
990         * arm-fbsd-nat.c: Sort headers.
991         * arm-bsd-tdep.c: Sort headers.
992         * arch-utils.c: Sort headers.
993         * arc-tdep.c: Sort headers.
994         * arc-newlib-tdep.c: Sort headers.
995         * annotate.h: Sort headers.
996         * annotate.c: Sort headers.
997         * amd64-windows-tdep.c: Sort headers.
998         * amd64-windows-nat.c: Sort headers.
999         * amd64-tdep.c: Sort headers.
1000         * amd64-sol2-tdep.c: Sort headers.
1001         * amd64-obsd-tdep.c: Sort headers.
1002         * amd64-obsd-nat.c: Sort headers.
1003         * amd64-nbsd-tdep.c: Sort headers.
1004         * amd64-nbsd-nat.c: Sort headers.
1005         * amd64-nat.c: Sort headers.
1006         * amd64-linux-tdep.c: Sort headers.
1007         * amd64-linux-nat.c: Sort headers.
1008         * amd64-fbsd-tdep.c: Sort headers.
1009         * amd64-fbsd-nat.c: Sort headers.
1010         * amd64-dicos-tdep.c: Sort headers.
1011         * amd64-darwin-tdep.c: Sort headers.
1012         * amd64-bsd-nat.c: Sort headers.
1013         * alpha-tdep.c: Sort headers.
1014         * alpha-obsd-tdep.c: Sort headers.
1015         * alpha-nbsd-tdep.c: Sort headers.
1016         * alpha-mdebug-tdep.c: Sort headers.
1017         * alpha-linux-tdep.c: Sort headers.
1018         * alpha-linux-nat.c: Sort headers.
1019         * alpha-bsd-tdep.c: Sort headers.
1020         * alpha-bsd-nat.c: Sort headers.
1021         * aix-thread.c: Sort headers.
1022         * agent.c: Sort headers.
1023         * addrmap.c: Sort headers.
1024         * ada-varobj.c: Sort headers.
1025         * ada-valprint.c: Sort headers.
1026         * ada-typeprint.c: Sort headers.
1027         * ada-tasks.c: Sort headers.
1028         * ada-lang.c: Sort headers.
1029         * aarch64-tdep.c: Sort headers.
1030         * aarch64-ravenscar-thread.c: Sort headers.
1031         * aarch64-newlib-tdep.c: Sort headers.
1032         * aarch64-linux-tdep.c: Sort headers.
1033         * aarch64-linux-nat.c: Sort headers.
1034         * aarch64-fbsd-tdep.c: Sort headers.
1035         * aarch64-fbsd-nat.c: Sort headers.
1036         * aarch32-linux-nat.c: Sort headers.
1037
1038 2019-04-04  Tom Tromey  <tom@tromey.com>
1039
1040         * varobj.c (varobj_create): Update.
1041         * rust-exp.y (struct rust_parser) <update_innermost_block,
1042         lookup_symbol>: New methods.
1043         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
1044         Rename.
1045         (rust_parser::rust_lookup_type)
1046         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1047         * printcmd.c (display_command, do_one_display): Update.
1048         * parser-defs.h (struct parser_state) <parser_state>: Add
1049         "tracker" parameter.
1050         (block_tracker): New member.
1051         (class innermost_block_tracker) <innermost_block_tracker>: Add
1052         "types" parameter.
1053         <reset>: Remove method.
1054         (innermost_block): Don't declare.
1055         (null_post_parser): Update.
1056         * parse.c (innermost_block): Remove global.
1057         (write_dollar_variable): Update.
1058         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
1059         Remove "tracker_types" parameter.
1060         (parse_expression): Add "tracker" parameter.
1061         (parse_expression_for_completion): Update.
1062         (null_post_parser): Add "tracker" parameter.
1063         * p-exp.y: Update rules.
1064         * m2-exp.y: Update rules.
1065         * language.h (struct language_defn) <la_post_parser>: Add
1066         "tracker" parameter.
1067         * go-exp.y: Update rules.
1068         * f-exp.y: Update rules.
1069         * expression.h (parse_expression, parse_exp_1): Add "tracker"
1070         parameter.
1071         * d-exp.y: Update rules.
1072         * c-exp.y: Update rules.
1073         * breakpoint.c (set_breakpoint_condition): Create an
1074         innermost_block_tracker.
1075         (watch_command_1): Likewise.
1076         * ada-lang.c (resolve): Add "tracker" parameter.
1077         (resolve_subexp): Likewise.
1078         * ada-exp.y (write_var_from_sym): Update.
1079
1080 2019-04-04  Tom Tromey  <tom@tromey.com>
1081
1082         * type-stack.h: New file.
1083         * type-stack.c: New file.
1084         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
1085         type-stack.h.
1086         (insert_into_type_stack, insert_type, push_type, push_type_int)
1087         (insert_type_address_space, pop_type, pop_type_int)
1088         (pop_typelist, pop_type_stack, append_type_stack)
1089         (push_type_stack, get_type_stack, push_typelist)
1090         (follow_type_instance_flags, follow_types): Don't declare.
1091         * parse.c (type_stack): Remove global.
1092         (parse_exp_in_context): Update.
1093         (insert_into_type_stack, insert_type, push_type, push_type_int)
1094         (insert_type_address_space, pop_type, pop_type_int)
1095         (pop_typelist, pop_type_stack, append_type_stack)
1096         (push_type_stack, get_type_stack, push_typelist)
1097         (follow_type_instance_flags, follow_types): Remove (moved to
1098         type-stack.c).
1099         * f-exp.y (type_stack): New global.
1100         Update rules.
1101         (push_kind_type, f_parse): Update.
1102         * d-exp.y (type_stack): New global.
1103         Update rules.
1104         (d_parse): Update.
1105         * c-exp.y (struct c_parse_state) <type_stack>: New member.
1106         Update rules.
1107         * Makefile.in (COMMON_SFILES): Add type-stack.c.
1108         (HFILES_NO_SRCDIR): Add type-stack.h.
1109
1110 2019-04-04  Tom Tromey  <tom@tromey.com>
1111
1112         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
1113         (rust_parser::convert_ast_to_expression, rust_parse)
1114         (rust_lex_test_completion, rust_lex_tests): Update.
1115         * parser-defs.h (struct expr_completion_state): New.
1116         (struct parser_state) <parser_state>: Add completion parameter.
1117         <mark_struct_expression, mark_completion_tag>: New methods.
1118         <parse_completion, m_completion_state>: New members.
1119         (prefixify_expression, null_post_parser): Update.
1120         (mark_struct_expression, mark_completion_tag): Don't declare.
1121         * parse.c (parse_completion, expout_last_struct)
1122         (expout_tag_completion_type, expout_completion_name): Remove
1123         globals.
1124         (parser_state::mark_struct_expression)
1125         (parser_state::mark_completion_tag): Now methods.
1126         (prefixify_expression): Add last_struct parameter.
1127         (prefixify_subexp): Likewise.
1128         (parse_exp_1): Update.
1129         (parse_exp_in_context): Add cstate parameter.  Update.
1130         (parse_expression_for_completion): Create an
1131         expr_completion_state.
1132         (null_post_parser): Add "completion" parameter.
1133         * p-exp.y: Update rules.
1134         (yylex): Update.
1135         * language.h (struct language_defn) <la_post_parser>: Add
1136         "completing" parameter.
1137         * go-exp.y: Update rules.
1138         (lex_one_token): Update.
1139         * expression.h (parse_completion): Don't declare.
1140         * d-exp.y: Update rules.
1141         (lex_one_token): Update rules.
1142         * c-exp.y: Update rules.
1143         (lex_one_token): Update.
1144         * ada-lang.c (resolve): Add "parse_completion" parameter.
1145         (resolve_subexp): Likewise.
1146         (ada_resolve_function): Likewise.
1147
1148 2019-04-04  Tom Tromey  <tom@tromey.com>
1149
1150         * parser-defs.h (struct parser_state) <start_arglist,
1151         end_arglist>: New methods.
1152         <arglist_len, m_funcall_chain>: New members.
1153         (arglist_len, start_arglist, end_arglist): Don't declare.
1154         * parse.c (arglist_len, funcall_chain): Remove global.
1155         (start_arglist, end_arglist): Remove functions.
1156         (parse_exp_in_context): Update.
1157         * p-exp.y: Update rules.
1158         * m2-exp.y: Update rules.
1159         * go-exp.y: Update rules.
1160         * f-exp.y: Update rules.
1161         * d-exp.y: Update rules.
1162         * c-exp.y: Update rules.
1163
1164 2019-04-04  Tom Tromey  <tom@tromey.com>
1165
1166         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
1167         lex_operator, push_back>: New methods.
1168         Update all rules.
1169         (rust_parser::lex_hex, lex_escape): Rename and update.
1170         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
1171         (rust_parser::lex_operator): Rename and update.
1172         (rust_parser::lex_number, rustyylex, rustyyerror)
1173         (rust_lex_test_init, rust_lex_test_sequence)
1174         (rust_lex_test_push_back, rust_lex_tests): Update.
1175         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
1176         parameter.
1177         <lexptr, prev_lexptr>: New members.
1178         (lexptr, prev_lexptr): Don't declare.
1179         * parse.c (lexptr, prev_lexptr): Remove globals.
1180         (parse_exp_in_context): Update.
1181         * p-exp.y (yylex, yyerror): Update.
1182         * m2-exp.y (parse_number, yylex, yyerror): Update.
1183         * go-exp.y (lex_one_token, yyerror): Update.
1184         * f-exp.y (match_string_literal, yylex, yyerror): Update.
1185         * d-exp.y (lex_one_token, yyerror): Update.
1186         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
1187         (lex_one_token, yyerror): Update.
1188         * ada-lex.l (YY_INPUT): Update.
1189         (rewind_to_char): Update.
1190         * ada-exp.y (yyerror): Update.
1191
1192 2019-04-04  Tom Tromey  <tom@tromey.com>
1193
1194         * rust-exp.y (rustyylex, rust_lex_tests): Update.
1195         * parser-defs.h (struct parser_state) <parser_state>: Add new
1196         parameter.
1197         <comma_terminates>: New member.
1198         (comma_terminates): Don't declare global.
1199         * parse.c (comma_terminates): Remove global.
1200         (parse_exp_in_context): Update.
1201         * p-exp.y (yylex): Update.
1202         * m2-exp.y (yylex): Update.
1203         * go-exp.y (lex_one_token): Update.
1204         * f-exp.y (yylex): Update.
1205         * d-exp.y (lex_one_token): Update.
1206         * c-exp.y (lex_one_token): Update.
1207         * ada-lex.l: Update.
1208
1209 2019-04-04  Tom Tromey  <tom@tromey.com>
1210
1211         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
1212         (rustyylex, rust_lex_test_init, rust_lex_test_one)
1213         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
1214         * parser-defs.h (paren_depth): Don't declare.
1215         * parse.c (paren_depth): Remove global.
1216         (parse_exp_in_context): Update.
1217         * p-exp.y (paren_depth): New global.
1218         (pascal_parse): Initialize it.
1219         * m2-exp.y (paren_depth): New global.
1220         (m2_parse): Initialize it.
1221         * go-exp.y (paren_depth): New global.
1222         (go_parse): Initialize it.
1223         * f-exp.y (paren_depth): New global.
1224         (f_parse): Initialize it.
1225         * d-exp.y (paren_depth): New global.
1226         (d_parse): Initialize it.
1227         * c-exp.y (paren_depth): New global.
1228         (c_parse): Initialize it.
1229         * ada-lex.l (paren_depth): New global.
1230         (lexer_init): Initialize it.
1231
1232 2019-04-04  Tom Tromey  <tom@tromey.com>
1233
1234         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
1235         (rust_parser::convert_ast_to_type)
1236         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1237         * parser-defs.h (struct parser_state) <parser_state>: Add
1238         parameters.  Initialize new members.
1239         <expression_context_block, expression_context_pc>: New members.
1240         * parse.c (expression_context_block, expression_context_pc):
1241         Remove globals.
1242         (parse_exp_in_context): Update.
1243         * p-exp.y: Update all rules.
1244         (yylex): Update.
1245         * m2-exp.y: Update all rules.
1246         (yylex): Update.
1247         * go-exp.y (yylex): Update.
1248         * f-exp.y (yylex): Update.
1249         * d-exp.y: Update all rules.
1250         (yylex): Update.
1251         * c-exp.y: Update all rules.
1252         (lex_one_token, classify_name, yylex, c_parse): Update.
1253         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
1254
1255 2019-04-04  Tom Tromey  <tom@tromey.com>
1256
1257         * gdbarch.h, gdbarch.c: Rebuild.
1258         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
1259         * stap-probe.h: 
1260         (struct stap_parse_info): Replace "parser_state" with
1261         "expr_builder".
1262         * parser-defs.h (struct expr_builder): Rename from "parser_state".
1263         (parser_state): New class.
1264         * parse.c (expr_builder): Rename.
1265         (expr_builder::release): Rename.
1266         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
1267         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
1268         (write_exp_elt_longcst, write_exp_elt_floatcst)
1269         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
1270         (write_exp_string_vector, write_exp_bitstring)
1271         (write_exp_msymbol, mark_struct_expression)
1272         (write_dollar_variable)
1273         (insert_type_address_space, increase_expout_size): Replace
1274         "parser_state" with "expr_builder".
1275         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
1276         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
1277         "parser_state" with "expr_builder".
1278
1279 2019-04-04  Tom Tromey  <tom@tromey.com>
1280
1281         * rust-exp.y: Replace "parse_language" with method call.
1282         * p-exp.y: 
1283         (yylex): Replace "parse_language" with method call.
1284         * m2-exp.y: 
1285         (yylex): Replace "parse_language" with method call.
1286         * go-exp.y (classify_name): Replace "parse_language" with method
1287         call.
1288         * f-exp.y (yylex): Replace "parse_language" with method call.
1289         * d-exp.y (lex_one_token): Replace "parse_language" with method
1290         call.
1291         * c-exp.y: 
1292         (lex_one_token, classify_name, yylex): Replace "parse_language"
1293         with method call.
1294         * ada-exp.y (find_primitive_type, type_char)
1295         (type_system_address): Replace "parse_language" with method call.
1296
1297 2019-04-04  Tom Tromey  <tom@tromey.com>
1298
1299         * rust-exp.y: Replace "parse_gdbarch" with method call.
1300         * parse.c (write_dollar_variable, insert_type_address_space):
1301         Replace "parse_gdbarch" with method call.
1302         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
1303         call.
1304         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
1305         call.
1306         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
1307         "parse_gdbarch" with method call.
1308         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
1309         with method call.
1310         * f-exp.y (parse_type, parse_f_type, yylex): Replace
1311         "parse_gdbarch" with method call.
1312         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
1313         "parse_gdbarch" with method call.
1314         * c-exp.y (parse_type, parse_number, classify_name): Replace
1315         "parse_gdbarch" with method call.
1316         * ada-lex.l: Replace "parse_gdbarch" with method call.
1317         * ada-exp.y (parse_type, find_primitive_type, type_char)
1318         (type_system_address): Replace "parse_gdbarch" with method call.
1319
1320 2019-04-04  Tom Tromey  <tom@tromey.com>
1321
1322         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
1323         * stap-probe.c (stap_parse_argument): Update.
1324         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
1325         initial_size parameter.
1326         * rust-exp.y (rust_lex_tests): Update.
1327         * parse.c (parser_state): Update.
1328         (parse_exp_in_context): Update.
1329         * parser-defs.h (struct parser_state) <parser_state>: Remove
1330         "initial_size" parameter.
1331
1332 2019-04-04  Tom Tromey  <tom@tromey.com>
1333
1334         * parser-defs.h (increase_expout_size): Don't declare.
1335         * parse.c (increase_expout_size): Now static.
1336
1337 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
1338
1339         * gnu-nat.c (gnu_nat_target::wait): Fix
1340         target_waitstatus_to_string call.
1341
1342 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1343
1344         * eval.c (evaluate_subexp_standard): Handle internal functions
1345         during Fortran function call handling.
1346
1347 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1348
1349         * NEWS: Mention new internal functions.
1350         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
1351         (read_base_type): Use dwarf2_init_complex_target_type.
1352         * value.c (creal_internal_fn): New function.
1353         (cimag_internal_fn): New function.
1354         (_initialize_values): Register new internal functions.
1355
1356 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1357
1358         * infrun.c (stop_all_threads): If debug_infrun, always
1359         trace the wait status after wait_one, using
1360         target_waitstatus_to_string and target_pid_to_str.
1361         (handle_inferior_event): Replace various trace of
1362         wait status kind by a single trace.
1363         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
1364         wait status kind image by target_waitstatus_to_string.
1365         * target/waitstatus.c (target_waitstatus_to_string): Fix
1366         obsolete comment.
1367
1368 2019-04-01  Tom Tromey  <tromey@adacore.com>
1369
1370         PR symtab/23331:
1371         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
1372
1373 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
1374             Pedro Alves  <palves@redhat.com>
1375
1376         * top.c (quit_force): Call 'finalize_values'.
1377         * value.c (finalize_values): New function.
1378         * value.h (finalize_values): Declare.
1379
1380 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
1381
1382         * NEWS: Announce $_gdb_major and $_gdb_minor.
1383
1384         * top.c (init_gdb_version_vars): New function.
1385         (gdb_init): Call init_gdb_version_vars.
1386
1387 2019-03-29  Tom Tromey  <tromey@adacore.com>
1388
1389         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
1390         help text.  Remove dead code.
1391
1392 2019-03-29  Keith Seitz  <keiths@redhat.com>
1393
1394         From Siddhesh Poyarekar:
1395         * f-lang.h (f77_get_upperbound): Return LONGEST.
1396         (f77_get_lowerbound): Likewise.
1397         * f-typeprint.c (f_type_print_varspec_suffix): Expand
1398         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
1399         print them.
1400         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
1401         plongest to format print it.
1402         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
1403         (f77_get_upperbound): Likewise.
1404         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
1405         LOWER_BOUND to LONGEST.
1406         (f77_create_arrayprint_offset_tbl): Likewise.
1407
1408 2019-03-29  Keith Seitz  <keiths@redhat.com>
1409
1410         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
1411         %s/pulongest for TYPE_LENGTH instead of %d in format
1412         strings.
1413         * ada-typerint.c (ada_print_type): Likewise.
1414         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
1415         * compile/compile-c-support.c (generate_register_struct): Likewise.
1416         * gdbtypes.c (recursive_dump_type): Likewise.
1417         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
1418         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
1419         instead of %d in format strings.
1420         * riscv-tdep.c (riscv_type_alignment): Cast second argument
1421         to std::min to ULONGEST.
1422         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
1423         instead of %d in format strings.
1424         * tracepoint.c (info_scope_command): Likewise.
1425         * typeprint.c (print_offset_data::update)
1426         (print_offset_data::finish): Likewise.
1427         * xtensa-tdep.c (xtensa_store_return_value)
1428         (xtensa_push_dummy_call): Likewise.
1429
1430 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
1431
1432         * windows-nat.c (display_selector): Fixed format specifications
1433         for 64-bit Cygwin.
1434
1435 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1436
1437         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
1438
1439 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
1440
1441         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
1442         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
1443         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
1444         (nios2_linux_init_abi): Install it.
1445
1446 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1447
1448         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
1449
1450 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1451
1452         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
1453
1454 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1455             Tom Tromey  <tromey@adacore.com>
1456
1457         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
1458
1459 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
1460
1461         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
1462         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
1463         method to compute the bounds of range types. Also print "[evaluated]"
1464         if the bounds' values come from a dynamic evaluation.
1465
1466 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1467
1468         * cp-valprint.c (cp_print_value_fields): Don't print trailing
1469         whitespace when pretty printing is on.
1470
1471 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1472
1473         * ppc-linux-nat.c: Add include.
1474
1475 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1476
1477         * NEWS: Mention AArch64 Pointer Authentication.
1478
1479 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1480
1481         * arm-linux-nat.c: Add include.
1482
1483 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
1484
1485         * source-cache.c (source_cache::get_source_lines): Re-read
1486         fullname after calling open_source_file.
1487
1488 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
1489
1490         * NEWS: Mention TLS support for FreeBSD.
1491
1492 2019-03-25  Tom Tromey  <tromey@adacore.com>
1493
1494         * minsyms.c (BUNCH_SIZE): Update comment.
1495         (~minimal_symbol_reader): Remove old comment.
1496         (compact_minimal_symbols): Update comment.
1497         (minimal_symbol_reader::install): Remove old comment.  Update
1498         other comments.
1499
1500 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1501
1502         * s390-linux-nat.c: Add include.
1503
1504 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1505
1506         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1507         Call linux_get_hwcap.
1508         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
1509         Likewise.
1510         (aarch64_linux_get_hwcap): Remove function.
1511         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
1512         declaration.
1513         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
1514         linux_get_hwcap.
1515         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1516         * linux-tdep.c (linux_get_hwcap): Add function.
1517         (linux_get_hwcap2): Likewise.
1518         * linux-tdep.h (linux_get_hwcap): Add declaration.
1519         (linux_get_hwcap2): Likewise.
1520         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
1521         (ppc_linux_get_hwcap2): Likewise.
1522         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
1523         linux_get_hwcap.
1524         (ppc_linux_nat_target::insert_watchpoint): Likewise.
1525         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
1526         (ppc_linux_nat_target::read_description): Likewise.
1527         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
1528         * s390-linux-nat.c: Likewise.
1529         * s390-linux-tdep.c (s390_core_read_description): Likewise.
1530
1531 2019-03-24  Tom Tromey  <tom@tromey.com>
1532
1533         * ada-lang.c (standard_lookup): Simplify initialization.
1534         (ada_lookup_symbol_nonlocal): Simplify return.
1535         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
1536         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
1537         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
1538         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
1539         initialization.
1540         * solib.c (solib_global_lookup): Simplify.
1541         * symtab.c (null_block_symbol): Remove.
1542         (symbol_cache_lookup): Simplify returns.
1543         (lookup_language_this): Simplify returns.
1544         (lookup_symbol_aux): Simplify return.
1545         (lookup_local_symbol): Simplify returns.
1546         (lookup_global_symbol_from_objfile): Simplify return.
1547         (lookup_symbol_in_objfile_symtabs)
1548         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
1549         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
1550         (lookup_static_symbol, lookup_global_symbol): Simplify return.
1551         * cp-namespace.c (cp_lookup_bare_symbol)
1552         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
1553         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
1554         (cp_lookup_nested_symbol): Don't use null_block_symbol.
1555         (cp_lookup_symbol_via_imports): Simplify initialization.
1556         (find_symbol_in_baseclass): Likewise.
1557         * symtab.h (null_block_symbol): Remove.
1558         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
1559         (d_lookup_nested_symbol, d_lookup_symbol_imports)
1560         (d_lookup_symbol_module): Likewise.
1561         (find_symbol_in_baseclass): Simplify initialization.
1562
1563 2019-03-24  Tom Tromey  <tom@tromey.com>
1564
1565         * expression.h: Don't include symtab.h.
1566         (struct block): Forward declare.
1567
1568 2019-03-24  Tom Tromey  <tom@tromey.com>
1569
1570         * c-exp.y (typebase): Remove casts.
1571         * gdbtypes.c (lookup_unsigned_typename, )
1572         (lookup_signed_typename): Remove cast.
1573         * eval.c (parse_to_comma_and_eval): Remove cast.
1574         * parse.c (write_dollar_variable): Remove cast.
1575         * block.h (struct block) <superblock>: Now const.
1576         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
1577         * psymtab.c (psym_map_matching_symbols): Make "block" const.
1578         (map_block): Make "block" const.
1579         * symfile.h (struct quick_symbol_functions)
1580         <map_matching_symbols>: Constify block argument to "callback".
1581         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
1582         const.
1583         (find_pc_sect_compunit_symtab): Make "b" const.
1584         (find_symbol_at_address): Likewise.
1585         (search_symbols): Likewise.
1586         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
1587         (dw2_debug_names_lookup_symbol): Likewise.
1588         (dw2_map_matching_symbols): Update.
1589         * p-valprint.c (pascal_val_print): Remove "block".
1590         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
1591         (aux_add_nonlocal_symbols): Make "block" const.
1592         (resolve_subexp): Remove cast.
1593         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
1594         const.
1595         (iterate_over_file_blocks): Likewise.
1596         * f-exp.y (%union) <bval>: Remove.
1597         * coffread.c (patch_opaque_types): Make "b" const.
1598         * spu-tdep.c (spu_catch_start): Make "block" const.
1599         * c-valprint.c (print_unpacked_pointer): Remove "block".
1600         * symmisc.c (dump_symtab_1): Make "b" const.
1601         (block_depth): Make "block" const.
1602         * d-exp.y (%union) <bval>: Remove.
1603         * cp-support.h (cp_lookup_rtti_type): Update.
1604         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
1605         * psymtab.c (psym_lookup_symbol): Make "block" const.
1606         (maintenance_check_psymtabs): Make "b" const.
1607         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
1608         (enumerate_locals, enumerate_args): Update.
1609         * python/py-symtab.c (stpy_global_block): Make "block" const.
1610         (stpy_static_block): Likewise.
1611         * inline-frame.c (block_starting_point_at): Make "new_block"
1612         const.
1613         * block.c (find_block_in_blockvector): Make return type const.
1614         (blockvector_for_pc_sect): Make "b" const.
1615         (find_block_in_blockvector): Make "b" const.
1616
1617 2019-03-23  Tom Tromey  <tom@tromey.com>
1618
1619         * varobj.c (varobj_create): Update.
1620         * symfile.c (clear_symtab_users): Don't reset innermost_block.
1621         * printcmd.c (display_command, do_one_display): Don't reset
1622         innermost_block.
1623         * parser-defs.h (enum innermost_block_tracker_type): Move to
1624         expression.h.
1625         (innermost_block): Update comment.
1626         * parse.c (parse_exp_1): Add tracker_types parameter.
1627         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
1628         tracker_types parameter.  Reset innermost_block.
1629         (parse_exp_in_context): Remove.
1630         (parse_expression_for_completion): Update.
1631         * objfiles.c (~objfile): Don't reset expression_context_block or
1632         innermost_block.
1633         * expression.h (enum innermost_block_tracker_type): Move from
1634         parser-defs.h.
1635         (parse_exp_1): Add tracker_types parameter.
1636         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
1637         reset innermost_block.
1638
1639 2019-03-23  Tom Tromey  <tom@tromey.com>
1640
1641         * objfiles.h: Include bcache.h.
1642
1643 2019-03-23  Tom Tromey  <tom@tromey.com>
1644
1645         * linespec.c (get_current_search_block): Use
1646         scoped_restore_current_language.
1647         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
1648
1649 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1650             Jiong Wang  <jiong.wang@arm.com>
1651
1652         * aarch64-linux-tdep.c
1653         (aarch64_linux_iterate_over_regset_sections): Check for pauth
1654         section.
1655         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
1656
1657 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1658             Jiong Wang  <jiong.wang@arm.com>
1659
1660         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
1661         instructions.
1662         (aarch64_analyze_prologue_test): Add PACIASP test.
1663         (aarch64_prologue_prev_register): Unmask PC value.
1664
1665 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1666             Jiong Wang  <jiong.wang@arm.com>
1667
1668         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
1669         (aarch64_dwarf2_prev_register): Unmask PC value.
1670         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
1671         (aarch64_execute_dwarf_cfa_vendor_op): Check for
1672         DW_CFA_AARCH64_negate_ra_state.
1673         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
1674
1675 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1676             Jiong Wang  <jiong.wang@arm.com>
1677
1678         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
1679         registers.
1680         (aarch64_pseudo_register_name): Likewise.
1681         (aarch64_pseudo_register_type): Likewise.
1682         (aarch64_pseudo_register_reggroup_p): Likewise.
1683         (aarch64_gdbarch_init): Add pauth registers.
1684         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
1685         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
1686         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
1687         (struct gdbarch_tdep): Add regnum for ra_state.
1688
1689 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1690             Jiong Wang  <jiong.wang@arm.com>
1691
1692         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
1693
1694 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1695             Jiong Wang  <jiong.wang@arm.com>
1696
1697         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
1698         function.
1699         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
1700         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
1701         (aarch64_gdbarch_init): Add puth registers.
1702         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
1703         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
1704         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
1705
1706 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1707             Jiong Wang  <jiong.wang@arm.com>
1708
1709         * aarch64-linux-nat.c
1710         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
1711         * aarch64-linux-tdep.c
1712         (aarch64_linux_core_read_description): Likewise.
1713         (aarch64_linux_get_hwcap): New function.
1714         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
1715         (aarch64_linux_get_hwcap): New declaration.
1716
1717 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1718             Jiong Wang  <jiong.wang@arm.com>
1719
1720         * aarch64-linux-nat.c
1721         (aarch64_linux_nat_target::read_description): Add pauth param.
1722         * aarch64-linux-tdep.c
1723         (aarch64_linux_core_read_description): Likewise.
1724         * aarch64-tdep.c (struct target_desc): Add in pauth.
1725         (aarch64_read_description): Add pauth param.
1726         (aarch64_gdbarch_init): Likewise.
1727         * aarch64-tdep.h (aarch64_read_description): Likewise.
1728         * arch/aarch64.c (aarch64_create_target_description): Likewise.
1729         * arch/aarch64.h (aarch64_create_target_description): Likewise.
1730         * features/Makefile: Add new files.
1731         * features/aarch64-pauth.c: New file.
1732         * features/aarch64-pauth.xml: New file.
1733
1734 2019-03-20  Tom Tromey  <tromey@adacore.com>
1735
1736         * infrun.c (handle_inferior_event): Rename from
1737         handle_inferior_event_1.  Create a scoped_value_mark.
1738         (handle_inferior_event): Remove.
1739
1740 2019-03-19  Tom Tromey  <tromey@adacore.com>
1741
1742         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
1743         * infrun.h (print_stop_event): Add "displays" parameter.
1744         * infrun.c (print_stop_event): Add "displays" parameter.
1745
1746 2019-03-19  Pedro Alves  <palves@redhat.com>
1747
1748         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
1749         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
1750         to -1.  Fix TABs vs spaces.
1751         (tui_ui_out::tui_ui_out): Don't initialize fields here.
1752         * tui/tui-out.h (tui_ui_out) Add intro comments.
1753         <m_line, m_start_of_line>: In-class initialize, and add describing
1754         comment.
1755
1756 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
1757
1758         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
1759         variable names.
1760         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
1761
1762 2019-03-18  Pedro Alves  <palves@redhat.com>
1763             Eli Zaretskii <eliz@gnu.org>
1764
1765         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
1766         m_line and m_start_of_line.
1767
1768 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
1769
1770         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
1771         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
1772         it returns a newline.  This fixes a regression in TU mode, whereby
1773         the next line is output on the same screen line as the user input.
1774
1775 2019-03-18  Tom Tromey  <tromey@adacore.com>
1776
1777         * minsyms.c (minimal_symbol_reader::install): Remove call to
1778         obstack_blank.
1779
1780 2019-03-18  Pedro Alves  <palves@redhat.com>
1781
1782         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
1783         New globals.
1784         (apply_style): New, factored out from ...
1785         (apply_ansi_escape): ... this.  Handle reverse video mode.
1786         (tui_set_reverse_mode): New function.
1787         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
1788         * tui/tui-winsource.c (tui_show_source_line): Use
1789         tui_set_reverse_mode instead of setting A_STANDOUT.
1790         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
1791         New setter methods.
1792
1793 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
1794
1795         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
1796         Handle tabs.
1797
1798 2019-03-18  Tom Tromey  <tromey@adacore.com>
1799
1800         * ada-lang.c (empty_array): Add "high" parameter.
1801         (ada_evaluate_subexp): Update.
1802
1803 2019-03-17  Sergei Trofimovich <siarheit@google.com>
1804
1805         * unittests/string_view-selftests.c: Define
1806         _initialize_string_view_selftests unconditionally.
1807
1808 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
1809
1810         PR gdb/24350
1811         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
1812
1813 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
1814
1815         PR gdb/24351
1816         * windows-nat.c (display_selector): Fix format specifiers.
1817
1818 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
1819
1820         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
1821         tui_refill_source_window instead of tui_refresh_win, to update the
1822         current execution line.  This fixes redisplay of the current line
1823         when stepping through the code with "next" or "step".
1824
1825 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
1826
1827         * source-cache.c (source_cache::get_source_lines): Call
1828         find_source_lines to initialize s->nlines.  This fixes vertical
1829         scrolling of TUI source window when the DOWN arrow is pressed.
1830
1831 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1832
1833         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
1834         linux-thread-db.c (_initialize_thread_db): Likewise.
1835
1836 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
1837
1838         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
1839         wclrtoeol in tui_show_source_line".  This reverts changes made in
1840         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
1841
1842 2019-03-15  Tom Tromey  <tom@tromey.com>
1843
1844         * symtab.h (struct minimal_symbol): Derive from
1845         general_symbol_info.
1846         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
1847         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
1848         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
1849         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
1850         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
1851         (MSYMBOL_SEARCH_NAME): Update.
1852         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
1853         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
1854         * minsyms.c (minimal_symbol_reader::record_full): Update.
1855
1856 2019-03-15  Tom Tromey  <tom@tromey.com>
1857
1858         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
1859
1860 2019-03-15  Tom Tromey  <tom@tromey.com>
1861
1862         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
1863         unique_xmalloc_ptr.
1864         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
1865         Update.
1866         * minsyms.c (lookup_minimal_symbol_by_pc_section)
1867         (build_minimal_symbol_hash_tables)
1868         (minimal_symbol_reader::install): Update.
1869
1870 2019-03-15  Tom Tromey  <tom@tromey.com>
1871
1872         * symtab.c (create_demangled_names_hash): Update.
1873         (symbol_set_names): Update.
1874         * objfiles.h (struct objfile_per_bfd_storage)
1875         <demangled_names_hash>: Now an htab_up.
1876         * objfiles.c (objfile_per_bfd_storage): Simplify.
1877
1878 2019-03-15  Tom Tromey  <tom@tromey.com>
1879
1880         * objfiles.h (struct objfile_per_bfd_storage): Declare
1881         destructor.
1882         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
1883         New.
1884         (get_objfile_bfd_data): Use new.  Don't initialize
1885         language_of_main.
1886         (free_objfile_per_bfd_storage): Remove.
1887         (objfile_bfd_data_free, objfile::~objfile): Use delete.
1888
1889 2019-03-15  Tom Tromey  <tom@tromey.com>
1890
1891         * symfile.c (reread_symbols): Update.
1892         * objfiles.c (objfile::objfile): Update.
1893         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
1894         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
1895         comment.
1896         (minimal_symbol_reader::install): Update.
1897         (terminate_minimal_symbol_table): Remove.
1898         * jit.c (jit_object_close_impl): Update.
1899
1900 2019-03-15  Tom Tromey  <tom@tromey.com>
1901
1902         * minsyms.c (minimal_symbol_reader::record_full): Remove some
1903         initializations.
1904
1905 2019-03-15  Tom Tromey  <tom@tromey.com>
1906
1907         * objfiles.h (struct objfile_per_bfd_storage)
1908         <demangled_hash_languages>: Now a bitset.
1909         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
1910         (lookup_minimal_symbol): Update.
1911
1912 2019-03-15  Tom Tromey  <tom@tromey.com>
1913
1914         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
1915         Don't return the symbol.
1916         * coffread.c (record_minimal_symbol): Use record_full.
1917
1918 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
1919
1920         The MS-Windows port of ncurses fails to switch to a color pair if
1921         one or both of the colors are the implicit default colors.  This
1922         change records the default colors when TUI is initialized, and
1923         then specifies them explicitly when a color pair uses the default
1924         colors.  This allows color styling in TUI mode on MS-Windows.
1925
1926         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
1927         ncurses_norm_attr.
1928         (tui_initialize_io) [__MINGW32__]: Record the default terminal
1929         colors in ncurses_norm_attr.
1930         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
1931         "none", replace it with the default color recorded in
1932         ncurses_norm_attr.
1933
1934 2019-03-14  Tom Tromey  <tromey@adacore.com>
1935
1936         * source-cache.h (class source_cache) <get_source_lines>: Return
1937         std::string.
1938         * source-cache.c (source_cache::extract_lines): Handle case where
1939         first_pos==npos.  Return std::string.
1940         (source_cache::get_source_lines): Update.
1941
1942 2019-03-14  Tom Tromey  <tromey@adacore.com>
1943
1944         * NEWS: Add item for "style sources" commands.
1945         * source-cache.c (source_cache::get_source_lines): Check
1946         source_styling.
1947         * cli/cli-style.c (source_styling): New global.
1948         (_initialize_cli_style): Add "style sources" commands.
1949         (show_style_sources): New function.
1950         * cli/cli-style.h (source_styling): Declare.
1951
1952 2019-03-14  Pedro Alves  <palves@redhat.com>
1953             Tom Tromey  <tromey@adacore.com>
1954
1955         * tui/tui-winsource.h (tui_refill_source_window): Declare.
1956         * tui/tui-winsource.c (tui_refill_source_window): New function,
1957         from...
1958         (tui_horizontal_source_scroll): ... here.  Move some logic.
1959         * cli/cli-style.c (set_style_enabled): Notify new observable.
1960         * tui/tui-hooks.c (tui_redisplay_source): New function.
1961         (tui_attach_detach_observers): Attach or detach
1962         tui_redisplay_source.
1963         * observable.h (source_styling_changed): New observable.
1964         * observable.c: Define source_styling_changed observable.
1965
1966 2019-03-13  Tom Tromey  <tromey@adacore.com>
1967
1968         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
1969         (i386_gnu_nat_target::store_registers): Update.
1970         * target-debug.h (target_debug_print_std_string): New macro.
1971         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1972         * windows-tdep.c (display_one_tib): Update.
1973         * tui/tui-stack.c (tui_make_status_line): Update.
1974         * top.c (print_inferior_quit_action): Update.
1975         * thread.c (thr_try_catch_cmd): Update.
1976         (add_thread_with_info): Update.
1977         (thread_target_id_str): Update.
1978         (thr_try_catch_cmd): Update.
1979         (thread_command): Update.
1980         (thread_find_command): Update.
1981         * record-btrace.c (record_btrace_target::info_record)
1982         (record_btrace_resume_thread, record_btrace_target::resume)
1983         (record_btrace_cancel_resume, record_btrace_step_thread)
1984         (record_btrace_target::wait, record_btrace_target::wait)
1985         (record_btrace_target::wait, record_btrace_target::stop): Update.
1986         * progspace.c (print_program_space): Update.
1987         * process-stratum-target.c
1988         (process_stratum_target::thread_address_space): Update.
1989         * linux-fork.c (linux_fork_mourn_inferior)
1990         (detach_checkpoint_command, info_checkpoints_command)
1991         (linux_fork_context): Update.
1992         (linux_fork_detach): Update.
1993         (class scoped_switch_fork_info): Update.
1994         (delete_checkpoint_command): Update.
1995         * infrun.c (follow_fork_inferior): Update.
1996         (follow_fork_inferior): Update.
1997         (proceed_after_vfork_done): Update.
1998         (handle_vfork_child_exec_or_exit): Update.
1999         (follow_exec): Update.
2000         (displaced_step_prepare_throw): Update.
2001         (displaced_step_restore): Update.
2002         (start_step_over): Update.
2003         (resume_1): Update.
2004         (clear_proceed_status_thread): Update.
2005         (proceed): Update.
2006         (print_target_wait_results): Update.
2007         (do_target_wait): Update.
2008         (context_switch): Update.
2009         (stop_all_threads): Update.
2010         (restart_threads): Update.
2011         (finish_step_over): Update.
2012         (handle_signal_stop): Update.
2013         (switch_back_to_stepped_thread): Update.
2014         (keep_going_pass_signal): Update.
2015         (print_exited_reason): Update.
2016         (normal_stop): Update.
2017         * inferior.c (inferior_pid_to_str): Change return type.
2018         (print_selected_inferior): Update.
2019         (add_inferior): Update.
2020         (detach_inferior): Update.
2021         * dummy-frame.c (fprint_dummy_frames): Update.
2022         * dcache.c (dcache_info_1): Update.
2023         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
2024         (btrace_fetch, btrace_clear): Update.
2025         * linux-tdep.c (linux_core_pid_to_str): Change return type.
2026         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
2027         type.
2028         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
2029         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
2030         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
2031         * gdbarch.c, gdbarch.h: Rebuild.
2032         * gdbarch.sh (core_pid_to_str): Change return type.
2033         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
2034         return type.
2035         (windows_nat_target::pid_to_str): Change return type.
2036         (windows_delete_thread): Update.
2037         (windows_nat_target::attach): Update.
2038         (windows_nat_target::files_info): Update.
2039         * target-delegates.c: Rebuild.
2040         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
2041         return type.
2042         (sol_thread_target::pid_to_str): Change return type.
2043         * remote.c (class remote_target) <pid_to_str>: Change return
2044         type.
2045         (remote_target::pid_to_str): Change return type.
2046         (extended_remote_target::attach, remote_target::remote_stop_ns)
2047         (remote_target::remote_notif_remove_queued_reply)
2048         (remote_target::push_stop_reply, remote_target::disable_btrace):
2049         Update.
2050         (extended_remote_target::attach): Update.
2051         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
2052         type.
2053         (gdbsim_target::pid_to_str): Change return type.
2054         * ravenscar-thread.c (struct ravenscar_thread_target)
2055         <pid_to_str>: Change return type.
2056         (ravenscar_thread_target::pid_to_str): Change return type.
2057         * procfs.c (class procfs_target) <pid_to_str>: Change return
2058         type.
2059         (procfs_target::pid_to_str): Change return type.
2060         (procfs_target::attach): Update.
2061         (procfs_target::detach): Update.
2062         (procfs_target::fetch_registers): Update.
2063         (procfs_target::store_registers): Update.
2064         (procfs_target::wait): Update.
2065         (procfs_target::files_info): Update.
2066         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
2067         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
2068         return type.
2069         (nto_procfs_target::pid_to_str): Change return type.
2070         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
2071         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
2072         return type.
2073         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
2074         (exit_lwp): Update.
2075         (attach_proc_task_lwp_callback, get_detach_signal)
2076         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
2077         (linux_nat_target::resume, wait_lwp, stop_callback)
2078         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
2079         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
2080         (linux_nat_wait_1, resume_stopped_resumed_lwps)
2081         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
2082         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
2083         type.
2084         (inf_ptrace_target::attach): Update.
2085         (inf_ptrace_target::files_info): Update.
2086         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
2087         type.
2088         (go32_nat_target::pid_to_str): Change return type.
2089         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
2090         (gnu_nat_target::wait): Update.
2091         (gnu_nat_target::wait): Update.
2092         (gnu_nat_target::resume): Update.
2093         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
2094         (fbsd_nat_target::wait): Update.
2095         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
2096         type.
2097         (darwin_nat_target::attach): Update.
2098         * corelow.c (class core_target) <pid_to_str>: Change return type.
2099         (core_target::pid_to_str): Change return type.
2100         * target.c (normal_pid_to_str): Change return type.
2101         (default_pid_to_str): Likewise.
2102         (target_pid_to_str): Change return type.
2103         (target_translate_tls_address): Update.
2104         (target_announce_detach): Update.
2105         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
2106         return type.
2107         (bsd_uthread_target::pid_to_str): Change return type.
2108         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
2109         type.
2110         (bsd_kvm_target::pid_to_str): Change return type.
2111         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
2112         return type.
2113         (aix_thread_target::pid_to_str): Change return type.
2114         * target.h (struct target_ops) <pid_to_str>: Change return type.
2115         (target_pid_to_str, normal_pid_to_str): Likewise.
2116         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
2117         type.
2118         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
2119         type.
2120         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
2121         return type.
2122         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
2123         type.
2124         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
2125         type.
2126         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
2127         return type.
2128
2129 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
2130
2131         * NEWS: Mention that the new default MI version is 3.  Mention
2132         changes to the output of commands and events that deal with
2133         multi-location breakpoints.
2134         * breakpoint.c: Include "mi/mi-out.h".
2135         (print_one_breakpoint): Change output syntax if using MI version
2136         >= 3.
2137         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
2138         New.
2139         (mi_multi_location_breakpoint_output_fixed): New.
2140         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
2141         (mi_cmd_fix_multi_location_breakpoint_output): New.
2142         (mi_multi_location_breakpoint_output_fixed): New.
2143         * mi/mi-cmds.c (mi_cmds): Register command
2144         -fix-multi-location-breakpoint-output.
2145         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
2146         interpreter "mi".
2147
2148 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
2149
2150         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
2151         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
2152         instantiate mi_ui_out based on interpreter name.
2153         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
2154         * mi/mi-main.c (mi_load_progress): Likewise.
2155
2156 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2157
2158         * NEWS: Combine separate "New targets" sections for 8.3.
2159
2160 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2161
2162         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
2163         (ppcfbsd_init_abi): Install gdbarch
2164         "fetch_tls_load_module_address" and "get_thread_local_address"
2165         methods.
2166
2167 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2168
2169         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
2170         (riscv_fbsd_init_abi): Install gdbarch
2171         "fetch_tls_load_module_address" and "get_thread_local_address"
2172         methods.
2173
2174 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2175
2176         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
2177         (i386fbsd_init_abi): Install gdbarch
2178         "fetch_tls_load_module_address" and "get_thread_local_address"
2179         methods.
2180
2181 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2182
2183         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
2184         (amd64fbsd_init_abi): Install gdbarch
2185         "fetch_tls_load_module_address" and "get_thread_local_address"
2186         methods.
2187
2188 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2189
2190         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
2191         (struct fbsd_pspace_data): New type.
2192         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
2193         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
2194         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
2195         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
2196         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
2197
2198 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2199
2200         * gdbtypes.c (lookup_struct_elt): New function.
2201         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
2202         * gdbtypes.h (struct struct_elt): New type.
2203         (lookup_struct_elt): New prototype.
2204
2205 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2206
2207         * gdbtypes.c (lookup_struct_elt_type): Update comment and
2208         remove disabled code block.
2209
2210 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2211
2212         * gdbarch.sh (get_thread_local_address): New method.
2213         * gdbarch.h, gdbarch.c: Regenerate.
2214         * target.c (target_translate_tls_address): Use
2215         gdbarch_get_thread_local_address if present instead of
2216         target::get_thread_local_address.
2217
2218 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2219
2220         * target.h (target::get_thread_local_address): Update comment.
2221
2222 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2223
2224         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
2225         objfile->separate_debug_objfile_backlink if not NULL.
2226
2227 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2228
2229         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
2230         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
2231         (amd64bsd_store_inferior_registers): Likewise.
2232         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2233         Enable segment base registers.
2234         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
2235         PT_GETFSBASE and PT_GETGSBASE.
2236         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
2237         PT_SETGSBASE.
2238         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
2239         segment base registers.
2240         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2241
2242 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2243
2244         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2245         Update calls to i386_target_description to add 'segments'
2246         parameter.
2247         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
2248         add segment base registers.
2249         * arch/i386.c (i386_create_target_description): Add 'segments'
2250         parameter to enable segment base registers.
2251         * arch/i386.h (i386_create_target_description): Likewise.
2252         * features/i386/32bit-segments.xml: New file.
2253         * features/i386/32bit-segments.c: Generate.
2254         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
2255         call to i386_target_description to add 'segments' parameter.
2256         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2257         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
2258         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
2259         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
2260         if feature is present.
2261         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
2262         Add 'segments' parameter to call to i386_target_description.
2263         (i386_target_description): Add 'segments' parameter to enable
2264         segment base registers.
2265         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
2266         to call to i386_target_description.
2267         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
2268         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
2269         Define I386_NUM_REGS.
2270         (i386_target_description): Add 'segments' parameter to enable
2271         segment base registers.
2272
2273 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
2274
2275         PR/24325
2276         * source-cache.c: #undef open and close, to avoid unresolved
2277         externals during linking.
2278
2279 2019-03-12  Tom Tromey  <tromey@adacore.com>
2280
2281         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
2282         const.  Add initializers.
2283         (_initialize_remote): Don't initialize ptid globals.
2284
2285 2019-03-12  Pedro Alves  <palves@redhat.com>
2286
2287         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
2288
2289 2019-03-12  Pedro Alves  <palves@redhat.com>
2290
2291         * cp-name-parser.y (main): Remove unused 'len' variable.
2292
2293 2019-03-12  Tom Tromey  <tromey@adacore.com>
2294
2295         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
2296         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
2297
2298 2019-03-12  Tom Tromey  <tromey@adacore.com>
2299
2300         * linux-nat.c (iterate_over_lwps): Update.
2301         (stop_callback): Remove parameter.
2302         (stop_wait_callback, detach_callback, resume_set_callback)
2303         (select_singlestep_lwp_callback, set_ignore_sigint)
2304         (status_callback, resumed_callback, resume_clear_callback)
2305         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
2306         data parameter.
2307         (linux_nat_target::detach, linux_nat_target::resume)
2308         (linux_stop_and_wait_all_lwps, select_event_lwp)
2309         (linux_nat_filter_event, linux_nat_wait_1)
2310         (linux_nat_target::kill, linux_nat_target::stop)
2311         (linux_nat_target::stop): Update.
2312         (linux_nat_resume_callback): Change type.
2313         (resume_stopped_resumed_lwps, count_events_callback)
2314         (select_event_lwp_callback): Likewise.
2315         (linux_stop_lwp, linux_nat_stop_lwp): Update.
2316         * arm-linux-nat.c (struct update_registers_data): Remove.
2317         (update_registers_callback): Change type.
2318         (arm_linux_insert_hw_breakpoint1): Update.
2319         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
2320         parameter.
2321         (x86_linux_dr_set_addr): Update.
2322         (x86_linux_dr_set_control): Update.
2323         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
2324         (iterate_over_lwps): Use gdb::function_view.
2325         * nat/aarch64-linux-hw-point.c (struct
2326         aarch64_dr_update_callback_param): Remove.
2327         (debug_reg_change_callback): Change type.
2328         (aarch64_notify_debug_reg_change): Update.
2329         * s390-linux-nat.c (s390_refresh_per_info): Update.
2330
2331 2019-03-11  Tom Tromey  <tromey@adacore.com>
2332
2333         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
2334         redundant assignment to "this_cu".
2335
2336 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2337
2338         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
2339
2340 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2341
2342         * gdbtypes.c (rank_one_type_parm_set): New function extracted
2343         from...
2344         (rank_one_type): ... this.
2345
2346 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2347
2348         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
2349         from...
2350         (rank_one_type): ... this.
2351
2352 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2353
2354         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
2355         from...
2356         (rank_one_type): ... this.
2357
2358 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2359
2360         * gdbtypes.c (rank_one_type_parm_float): New function extracted
2361         from...
2362         (rank_one_type): ... this.
2363
2364 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2365
2366         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
2367         from...
2368         (rank_one_type): ... this.
2369
2370 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2371
2372         * gdbtypes.c (rank_one_type_parm_range): New function extracted
2373         from...
2374         (rank_one_type): ... this.
2375
2376 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2377
2378         * gdbtypes.c (rank_one_type_parm_char): New function extracted
2379         from...
2380         (rank_one_type): ... this.
2381
2382 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2383
2384         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
2385         from...
2386         (rank_one_type): ... this.
2387
2388 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2389
2390         * gdbtypes.c (rank_one_type_parm_int): New function extracted
2391         from...
2392         (rank_one_type): ... this.
2393
2394 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2395
2396         * gdbtypes.c (rank_one_type_parm_func): New function extracted
2397         from...
2398         (rank_one_type): ... this.
2399
2400 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2401
2402         * gdbtypes.c (rank_one_type_parm_array): New function extracted
2403         from...
2404         (rank_one_type): ... this.
2405
2406 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2407
2408         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
2409         from...
2410         (rank_one_type): ... this.
2411
2412 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2413
2414         * inferior.c (initialize_inferiors): Ensure 'help set/show print
2415         inferior-events' shows the example events.
2416
2417 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
2418
2419         Support styling on native MS-Windows console
2420
2421         PR/24315
2422         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
2423         on MS-Windows if $TERM is not defined.
2424
2425         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
2426
2427         * posix-hdep.c (gdb_console_fputs):
2428         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
2429         functions.
2430         * ui-file.h (gdb_console_fputs): Add prototype.
2431
2432         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
2433         back to fputs only if the former returns zero.
2434
2435 2019-03-07  Tom Tromey  <tom@tromey.com>
2436
2437         * symmisc.c (print_symbol_bcache_statistics): Update.
2438         (print_objfile_statistics): Update.
2439         * symfile.c (allocate_symtab): Update.
2440         * stabsread.c: Don't include bcache.h.
2441         * psymtab.h (struct psymbol_bcache): Don't declare.
2442         (class psymtab_storage) <psymbol_cache>: Now a bcache.
2443         (psymbol_bcache_init, psymbol_bcache_free)
2444         (psymbol_bcache_get_bcache): Don't declare.
2445         * psymtab.c (struct psymbol_bcache): Remove.
2446         (psymtab_storage::psymtab_storage): Update.
2447         (psymtab_storage::~psymtab_storage): Update.
2448         (psymbol_bcache_init, psymbol_bcache_free)
2449         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
2450         (add_psymbol_to_bcache): Update.
2451         (allocate_psymtab): Update.
2452         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
2453         macro_cache>: No longer pointers.
2454         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
2455         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
2456         * macrotab.c (macro_bcache): Update.
2457         * macroexp.c: Don't include bcache.h.
2458         * gdbtypes.c (check_types_worklist): Update.
2459         (types_deeply_equal): Remove TRY/CATCH.  Update.
2460         * elfread.c (elf_symtab_read): Update.
2461         * dwarf2read.c: Don't include bcache.h.
2462         * buildsym.c (buildsym_compunit::get_macro_table): Update.
2463         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
2464         (print_bcache_statistics, bcache_memory_used): Don't declare.
2465         (struct bcache): Move from bcache.c.  Add constructor, destructor,
2466         methods.  Rename all data members.
2467         * bcache.c (struct bcache): Move to bcache.h.
2468         (bcache::expand_hash_table): Rename from expand_hash_table.
2469         (bcache): Remove.
2470         (bcache::insert): Rename from bcache_full.
2471         (bcache::compare): Rename from bcache_compare.
2472         (bcache_xmalloc): Remove.
2473         (bcache::~bcache): Rename from bcache_xfree.
2474         (bcache::print_statistics): Rename from print_bcache_statistics.
2475         (bcache::memory_used): Rename from bcache_memory_used.
2476
2477 2019-03-07  Pedro Alves  <palves@redhat.com>
2478
2479         * infrun.c (normal_stop): Also check for
2480         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
2481
2482 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
2483
2484         * f-lang.c (value_from_host_double): Moved to...
2485         * value.c (value_from_host_double): ...here.
2486         * value.h (value_from_host_double): Declare.
2487         * guile/scm-math.c (vlscm_convert_typed_number): Use
2488         value_from_host_double.
2489         (vlscm_convert_number): Likewise.
2490         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
2491         * python/py-value.c (convert_value_from_python): Likewise.
2492
2493 2019-03-06  Tom Tromey  <tom@tromey.com>
2494
2495         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
2496
2497 2019-03-06  Tom Tromey  <tom@tromey.com>
2498
2499         * utils.h (free_current_contents): Don't declare.
2500         * utils.c (free_current_contents): Remove.
2501
2502 2019-03-06  Tom Tromey  <tom@tromey.com>
2503
2504         * top.c (quit_force): Update.
2505         * main.c (captured_command_loop): Update.
2506         * common/new-op.c (operator new): Update.
2507         * common/common-exceptions.c (struct catcher)
2508         <save_cleanup_chain>: Remove member.
2509         (exceptions_state_mc_init): Update.
2510         (exception_try_scope_entry): Return nullptr.
2511         (exception_try_scope_exit, exception_rethrow)
2512         (throw_exception_sjlj, throw_exception_cxx): Update.
2513         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
2514         (all_cleanups, do_cleanups, discard_cleanups)
2515         (discard_final_cleanups, save_cleanups, save_final_cleanups)
2516         (restore_cleanups, restore_final_cleanups): Don't declare.
2517         (do_final_cleanups): Remove parameter.
2518         * common/cleanups.c (cleanup_chain, make_cleanup)
2519         (make_cleanup_dtor, all_cleanups, do_cleanups)
2520         (discard_my_cleanups, discard_cleanups)
2521         (discard_final_cleanups, save_my_cleanups, save_cleanups)
2522         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
2523         (null_cleanup): Remove.
2524         (do_final_cleanups): Remove parameter.
2525
2526 2019-03-06  Tom Tromey  <tom@tromey.com>
2527
2528         * remote.c (remote_target::remote_parse_stop_reply): Use
2529         unique_xmalloc_ptr.
2530
2531 2019-03-06  Tom Tromey  <tom@tromey.com>
2532
2533         * stabsread.c (struct stabs_field_info): Rename from field_info.
2534         <list, fnlist>: Add initializers.
2535         <obstack>: New member.
2536         (read_member_functions, read_struct_fields, read_baseclasses):
2537         Allocate on obstack.  Don't use cleanups.
2538         (read_one_struct_field, read_member_functions, read_struct_fields)
2539         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
2540         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
2541         (read_struct_type): Update.
2542
2543 2019-03-06  Tom Tromey  <tom@tromey.com>
2544
2545         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
2546         * common/filestuff.h (make_cleanup_close): Don't declare.
2547         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
2548         Remove.
2549
2550 2019-03-06  Tom Tromey  <tom@tromey.com>
2551
2552         * solib-aix.c: Use make_scope_exit.
2553
2554 2019-03-06  Tom Tromey  <tom@tromey.com>
2555
2556         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
2557         Use make_scope_exit.
2558
2559 2019-03-06  Tom Tromey  <tom@tromey.com>
2560
2561         * solib-svr4.c (disable_probes_interface): Remove parameter.
2562         (svr4_handle_solib_event): Use make_scope_exit.
2563
2564 2019-03-06  Tom Tromey  <tom@tromey.com>
2565
2566         * remote.c (struct stop_reply_deleter): Remove.
2567         (stop_reply_up): Update.
2568         (struct stop_reply): Derive from notif_event.  Don't typedef.
2569         <regcache>: Now a std::vector.
2570         (stop_reply_xfree): Remove.
2571         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
2572         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
2573         (remote_target::discard_pending_stop_replies): Use delete.
2574         (remote_target::remote_parse_stop_reply): Update.
2575         (remote_target::process_stop_reply): Update.
2576         * remote-notif.h (struct notif_event): Add virtual destructor.
2577         Remove "dtr" member.
2578         (struct notif_client) <alloc_event>: Return a unique_ptr.
2579         (notif_event_xfree): Don't declare.
2580         (notif_event_up): New typedef.
2581         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
2582         (notif_event_xfree, do_notif_event_xfree): Remove.
2583         (remote_notif_state_xfree): Update.
2584
2585 2019-03-06  Tom Tromey  <tom@tromey.com>
2586
2587         * infrun.c (displaced_step_clear_cleanup): Now a
2588         forward_scope_exit type.
2589         (displaced_step_prepare_throw): Update.
2590         (displaced_step_fixup): Update.
2591
2592 2019-03-06  Tom Tromey  <tom@tromey.com>
2593
2594         * inferior.h (class inferior): Update comment.
2595         * gdbthread.h (class thread_info): Update comment.
2596
2597 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
2598             Tom Tromey  <tom@tromey.com>
2599
2600         * stabsread.h (struct stab_section_list): Remove.
2601         (coffstab_build_psymtabs): Update.
2602         * dbxread.c (symbuf_sections): Now a std::vector.
2603         (sect_idx): New global.
2604         (fill_symbuf): Update.
2605         (coffstab_build_psymtabs): Change type of stabsects parameter.
2606         Update.
2607         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
2608         std::vector.
2609         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
2610         (coff_locate_sections): Update.
2611         (coff_symfile_read): Remove cleanups.  Update.
2612         (init_stringtab): Add storage parameter.
2613         (free_stringtab, free_stringtab_cleanup): Remove.
2614         (init_lineno): Add storage parameter.
2615         (free_linetab, free_linetab_cleanup): Remove.
2616
2617 2019-03-06  Pedro Alves  <palves@redhat.com>
2618
2619         * linux-fork.c (fork_info::clobber_regs): Delete.
2620         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
2621         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
2622         comment.  Adjust.
2623         (scoped_switch_fork_info::scoped_switch_fork_info)
2624         (checkpoint_command, linux_fork_context): Adjust
2625         fork_save_infrun_state calls.
2626
2627 2019-03-06  Pedro Alves  <palves@redhat.com>
2628
2629         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
2630         (inf_has_multiple_threads): Return 'bool' and rewrite using
2631         inferior_info::threads().
2632
2633 2019-03-06  Pedro Alves  <palves@redhat.com>
2634
2635         * linux-fork.c: Include <list>.
2636         (fork_list): Now a std::list instance.
2637         (fork_info): Add ctor, dtor, and in-class initialize all fields.
2638         (forks_exist_p, find_last_fork): Adjust.
2639         (new_fork): Delete.
2640         (one_fork_p): New.
2641         (add_fork): Adjust.
2642         (free_fork): Delete, folded into fork_info::~fork_info().
2643         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
2644         Adjust.
2645         (init_fork_list): Delete.
2646         (linux_fork_killall, linux_fork_mourn_inferior)
2647         (linux_fork_detach, info_checkpoints_command): Adjust.
2648         (_initialize_linux_fork): No longer call init_fork_list.
2649
2650 2019-03-06  Pedro Alves  <palves@redhat.com>
2651
2652         * linux-fork.c (new_fork): New, split out of ...
2653         (add_fork): ... this.  Return void.  Move "first fork" special
2654         case from here, to ...
2655         (checkpoint_command): ... here.
2656         * linux-linux.h (add_fork): Return void.
2657
2658 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2659
2660         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
2661
2662 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2663             Chris January  <chris.january@arm.com>
2664             David Lecomber  <david.lecomber@arm.com>
2665
2666         * f-exp.y: New token, UNOP_INTRINSIC.
2667         (exp): New pattern using UNOP_INTRINSIC token.
2668         (f77_keywords): Add 'abs' keyword.
2669         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
2670         (value_from_host_double): New function.
2671         (evaluate_subexp_f): Support UNOP_ABS.
2672
2673 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2674
2675         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
2676         types.
2677
2678 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2679
2680         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
2681         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
2682         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
2683
2684 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2685
2686         * f-exp.y (convert_to_kind_type): Handle more type kinds.
2687
2688 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2689             Chris January  <chris.january@arm.com>
2690
2691         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
2692         * f-exp.y: Define 'KIND' token.
2693         (exp): New pattern for KIND expressions.
2694         (ptype): Handle types with a kind extension.
2695         (direct_abs_decl): Extend to spot kind extensions.
2696         (f77_keywords): Add 'kind' to the list.
2697         (push_kind_type): New function.
2698         (convert_to_kind_type): New function.
2699         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
2700         * parse.c (operator_length_standard): Likewise.
2701         * parser-defs.h (enum type_pieces): Add tp_kind.
2702         * std-operator.def: Add UNOP_KIND.
2703
2704 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2705
2706         * f-exp.y (f_parse): Set yydebug.
2707
2708 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2709
2710         * f-lang.c (evaluate_subexp_f): New function.
2711         (exp_descriptor_f): New global.
2712         (f_language_defn): Use exp_descriptor_f instead of
2713         exp_descriptor_standard.
2714
2715 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2716
2717         * f-exp.y (struct token): Add comments.
2718         (dot_ops): Remove uppercase versions and the end marker.
2719         (f77_keywords): Likewise.
2720         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
2721         entries in the dot_ops array are case insensitive, and use
2722         strncasecmp to compare strings.  Also some whitespace cleanup in
2723         this area.  Similar for the f77_keywords array, except entries in
2724         this list might be case sensitive.
2725
2726 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2727
2728         * f-exp.y (struct f77_boolean_val): Add comments.
2729         (boolean_values): Remove uppercase versions, and end marker.
2730         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
2731         and use strncasecmp to achieve case insensitivity.  Additionally,
2732         perform whitespace cleanup around this code.
2733
2734 2019-03-06  Tom Tromey  <tromey@adacore.com>
2735
2736         * remote-sim.c (gdbsim_target_open): Use result of
2737         gdb_argv::release.
2738
2739 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
2740         Dirk Schubert  <dirk.schubert@arm.com>
2741         Chris January  <chris.january@arm.com>
2742
2743         * eval.c (evaluate_subexp_standard): Call Fortran argument
2744         wrapping logic.
2745         * f-lang.c (struct value): A value which can be passed into a
2746         Fortran function call.
2747         (fortran_argument_convert): Wrap Fortran arguments in a pointer
2748         where appropriate.
2749         (struct type): Value ready for a Fortran function call.
2750         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
2751         is needed.
2752         * f-lang.h (fortran_argument_convert): Declaration.
2753         (fortran_preserve_arg_pointer): Declaration.
2754         * infcall.c (value_arg_coerce): Call Fortran argument logic.
2755
2756 2019-03-05  Tom Tromey  <tromey@adacore.com>
2757
2758         * python/py-prettyprint.c (print_string_repr): Remove #if.
2759         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
2760
2761 2019-03-05  Tom Tromey  <tromey@adacore.com>
2762
2763         * target.c (the_dummy_target): Move later.  Change type to
2764         "dummy_target".
2765         (initialize_targets): Don't initialize the_dummy_target.
2766
2767 2019-03-05  Tom Tromey  <tromey@adacore.com>
2768
2769         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
2770         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
2771
2772 2019-03-05  Tom Tromey  <tromey@adacore.com>
2773
2774         * windows-nat.c (windows_nat_target::attach)
2775         (windows_nat_target::detach): Don't call gdb_flush.
2776         * valprint.c (generic_val_print, val_print, val_print_string):
2777         Don't call gdb_flush.
2778         * utils.c (defaulted_query): Don't call gdb_flush.
2779         * typeprint.c (print_type_scalar): Don't call gdb_flush.
2780         * target.c (target_announce_detach): Don't call gdb_flush.
2781         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
2782         * remote.c (extended_remote_target::attach): Don't call
2783         gdb_flush.
2784         * procfs.c (procfs_target::detach): Don't call gdb_flush.
2785         * printcmd.c (do_examine): Don't call gdb_flush.
2786         (info_display_command): Don't call gdb_flush.
2787         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
2788         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
2789         * memattr.c (info_mem_command): Don't call gdb_flush.
2790         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
2791         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
2792         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
2793         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
2794         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
2795         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
2796         (gnu_nat_target::detach): Don't call gdb_flush.
2797         * f-valprint.c (f_val_print): Don't call gdb_flush.
2798         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
2799         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
2800         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
2801         gdb_flush.
2802         * c-valprint.c (c_val_print): Don't call gdb_flush.
2803         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
2804
2805 2019-03-05  Tom Tromey  <tromey@adacore.com>
2806
2807         * varobj.c (update_dynamic_varobj_children): Update.
2808         (install_default_visualizer): Use reset, not release.
2809         * value.c (set_internalvar): Update.
2810         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
2811         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
2812         ATTRIBUTE_UNUSED_RESULT.
2813
2814 2019-03-05  Tom Tromey  <tromey@adacore.com>
2815
2816         * remote.c (class scoped_remote_fd) <release>: Add
2817         ATTRIBUTE_UNUSED_RESULT.
2818
2819 2019-03-05  Tom Tromey  <tromey@adacore.com>
2820
2821         * macroexp.c (struct macro_buffer) <release>: Add
2822         ATTRIBUTE_UNUSED_RESULT.
2823
2824 2019-03-05  Tom Tromey  <tromey@adacore.com>
2825
2826         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
2827         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
2828         ATTRIBUTE_UNUSED_RESULT.
2829
2830 2019-03-05  Tom Tromey  <tromey@adacore.com>
2831
2832         * common/scoped_fd.h (class scoped_fd) <release>: Add
2833         ATTRIBUTE_UNUSED_RESULT.
2834
2835 2019-03-05  Tom Tromey  <tromey@adacore.com>
2836
2837         * parser-defs.h (struct parser_state) <release>: Add
2838         ATTRIBUTE_UNUSED_RESULT.
2839
2840 2019-03-05  Tom Tromey  <tromey@adacore.com>
2841
2842         * utils.h (class gdb_argv) <release>: Add
2843         ATTRIBUTE_UNUSED_RESULT.
2844         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
2845
2846 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
2847
2848         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
2849         for-loop range, to avoid compiler warnings.
2850
2851         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
2852         avoid compiler warnings about unused variables.
2853
2854         * NEWS: Mention end of support for native debugging on MS-Windows
2855         before XP.
2856
2857         PR gdb/24292
2858         * common/netstuff.c:
2859         * gdbserver/gdbreplay.c
2860         * gdbserver/remote-utils.c:
2861         * ser-tcp.c:
2862         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
2863         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
2864         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
2865         'getaddrinfo' and 'freeaddrinfo' were not available before
2866         Windows XP, and mingw.org's MinGW headers by default define
2867         _WIN32_WINNT to 0x500.
2868
2869 2019-03-01  Gary Benson <gbenson@redhat.com>
2870
2871         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
2872
2873 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
2874             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2875
2876         PR gdb/8527
2877         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
2878         set_sigint_trap, clear_sigint_trap.
2879
2880 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2881
2882         * target.c (target_detach): Clear the regcache and the
2883         frame cache.
2884
2885 2019-02-27  Pedro Alves  <palves@redhat.com>
2886
2887         * utils.c (set_screen_size): When we cap the height/width sizes,
2888         tweak the corresponding command variable to show "unlimited":
2889
2890 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
2891             Pedro Alves  <palves@redhat.com>
2892
2893         * utils.c (set_screen_size): Reduce "infinite" rows and columns
2894         before calling rl_set_screen_size.
2895
2896 2019-02-27  Tom Tromey  <tromey@adacore.com>
2897
2898         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
2899         define.
2900         * python/py-value.c: Remove Python 2.4 workaround.
2901         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
2902         workaround.
2903         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
2904         Python 2.4 workaround.
2905         * python/python-internal.h: Remove Python 2.4 comment.
2906         (Py_ssize_t): Don't define.
2907         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
2908         (gdb_Py_DECREF): Remove Python 2.4 workaround.
2909         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
2910         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
2911         * python/python.c (do_start_initialization): Remove Python 2.4
2912         workaround.
2913         * python/py-prettyprint.c (class dummy_python_frame): Remove.
2914         (print_children): Remove Python 2.4 workaround.
2915         * python/py-inferior.c (buffer_procs): Remove Python 2.4
2916         workaround.
2917         (CHARBUFFERPROC_NAME): Remove.
2918         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
2919         Python 2.4 workaround.
2920
2921 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
2922
2923         * NEWS: Note minimum Python version.
2924
2925 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
2926
2927         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
2928         code from these functions.  Remove corresponding ifdefs.  Use
2929         Py_buffer_up instead of explicit calls to PyBuffer_Release.
2930         Remove gotos and target of gotos.
2931         (infpy_search_memory): Likewise.
2932
2933 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2934
2935         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
2936         (hppa_gdbarch_init): Don't register deleted functions with
2937         gdbarch.
2938
2939 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2940
2941         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
2942         (h8300_unwind_sp): Delete.
2943         (h8300_dummy_id): Delete.
2944         (h8300_gdbarch_init): Don't register deleted functions with
2945         gdbarch.
2946
2947 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2948
2949         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
2950         (ft32_unwind_pc): Delete.
2951         (ft32_unwind_sp): Delete.
2952         (ft32_gdbarch_init): Don't register deleted functions with
2953         gdbarch.
2954
2955 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2956
2957         * gdb/frv-tdep.c (frv_dummy_id): Delete.
2958         (frv_unwind_pc): Delete.
2959         (frv_unwind_sp): Delete.
2960         (frv_gdbarch_init): Don't register deleted functions with
2961         gdbarch.
2962
2963 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2964
2965         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
2966         (riscv_unwind_pc): Delete.
2967         (riscv_unwind_sp): Delete.
2968         (riscv_gdbarch_init): Don't register deleted functions with
2969         gdbarch.
2970
2971 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2972
2973         * gdb/csky-tdep.c (csky_dummy_id): Delete.
2974         (csky_unwind_pc): Delete.
2975         (csky_unwind_sp): Delete.
2976         (csky_gdbarch_init): Don't register deleted functions with
2977         gdbarch.
2978
2979 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2980
2981         * gdb/cris-tdep.c (cris_dummy_id): Delete.
2982         (cris_unwind_pc): Delete.
2983         (cris_unwind_sp): Delete.
2984         (cris_gdbarch_init): Don't register deleted functions with
2985         gdbarch.
2986
2987 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2988
2989         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
2990         (bfin_unwind_pc): Delete.
2991         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
2992
2993 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2994
2995         * gdb/arm-tdep.c (arm_dummy_id): Delete.
2996         (arm_unwind_pc): Delete.
2997         (arm_unwind_sp): Delete.
2998         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
2999
3000 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3001
3002         * gdb/arc-tdep.c (arc_dummy_id): Delete.
3003         (arc_unwind_pc): Delete.
3004         (arc_unwind_sp): Delete.
3005         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
3006
3007 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3008
3009         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
3010         (alpha_unwind_pc): Delete.
3011         (alpha_gdbarch_init): Don't register deleted functions with
3012         gdbarch.
3013
3014 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3015
3016         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
3017         (aarch64_unwind_pc): Delete.
3018         (aarch64_unwind_sp): Delete.
3019         (aarch64_gdbarch_init): Don't register deleted functions with
3020         gdbarch.
3021
3022 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3023
3024         * gdbtypes.c (type_align): Don't consider static members when
3025         computing structure alignment.
3026
3027 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3028
3029         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
3030         return 0 for other types.
3031         * arch-utils.c (default_type_align): Always return 0.
3032         * gdbarch.h: Regenerate.
3033         * gdbarch.sh (type_align): Extend comment.
3034         * gdbtypes.c (type_align): Add additional comments, always call
3035         gdbarch_type_align before applying the default rules.
3036         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
3037         generic code will then apply a suitable default.
3038         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
3039         types, return 0 for other types.
3040
3041 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3042
3043         * NEWS: Create a new section for the next release branch.
3044         Rename the section of the current branch, now that it has
3045         been cut.
3046
3047 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3048
3049         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
3050         * version.in: Bump version to 8.3.50.DATE-git.
3051
3052 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
3053
3054         * aix-thread.c (ptid_cmp): Remove unused variable.
3055         (get_signaled_thread): Likewise.
3056         (store_regs_user_thread): Likewise.
3057         (store_regs_kernel_thread): Likewise.
3058         (fetch_regs_kernel_thread): Remove shadowed variable.
3059
3060 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3061
3062         * features/riscv/32bit-cpu.xml: Add register numbers.
3063         * features/riscv/32bit-fpu.c: Regenerate.
3064         * features/riscv/32bit-fpu.xml: Add register numbers.
3065         * features/riscv/64bit-cpu.xml: Add register numbers.
3066         * features/riscv/64bit-fpu.c: Regenerate.
3067         * features/riscv/64bit-fpu.xml: Add register numbers.
3068
3069 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
3070
3071         * NEWS: Mention two argument form of gdb.Value constructor.
3072         * python/py-value.c (convert_buffer_and_type_to_value): New
3073         function.
3074         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
3075         Add support for handling an optional second argument.  Call
3076         convert_buffer_and_type_to_value as appropriate.
3077         * python/python-internal.h (Py_buffer_deleter): New struct.
3078         (Py_buffer_up): New typedef.
3079
3080 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
3081
3082         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
3083         instead of releasing ownership.
3084
3085 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
3086
3087         * dwarf2read.c (open_and_init_dwp_file): Call
3088         elf_numsections instead of bfd_count_sections to initialize
3089         dwp_file->num_sections.
3090
3091 2019-02-25  Tom Tromey  <tromey@adacore.com>
3092
3093         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
3094
3095 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
3096
3097         * gcore.in: Add '--readnever' option when invoking GDB.
3098
3099 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3100
3101         * MAINTAINERS: Update my email address.
3102
3103 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3104
3105         * build-id.c (build_id_to_debug_bfd_1): New function.
3106         (build_id_to_debug_bfd): Look for separate debug file in
3107         sysroot.
3108
3109 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3110
3111         * gdbarch.sh: Update the copyright year range that is placed into
3112         generated files.
3113
3114 2019-02-22  Keith Seitz  <keiths@redhat.com>
3115
3116         PR symtab/23853
3117         * linespec.c (create_sals_line_offset): Search for the default
3118         symtab's filename instead of its fullname.
3119
3120 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3121
3122         * NEWS: Update style defaults.
3123
3124 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3125
3126         * main.c (captured_main_1): Disable styling in batch mode.
3127
3128 2019-02-20  Tom Tromey  <tom@tromey.com>
3129
3130         * symtab.c (symtab_symbol_info): Fix typos.
3131
3132 2019-02-20  Tom Tromey  <tromey@adacore.com>
3133
3134         * findcmd.c (_initialize_mem_search): Use upper case for
3135         metasyntactic variables.
3136
3137 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
3138
3139         * aarch64-tdep.c (aarch64_add_reggroups): New function.
3140         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
3141
3142 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
3143
3144         * top.h (source_file_name): Change to std::string.
3145         * top.c (source_file_name): Likewise.
3146         (command_line_input): Adjust.
3147         * cli/cli-script.c (script_from_file): Adjust.
3148
3149 2019-02-19  Tom Tromey  <tromey@adacore.com>
3150
3151         * ravenscar-thread.c
3152         (ravenscar_thread_target::update_thread_list): Don't call
3153         ada_build_task_list.
3154         * ada-lang.h (ada_build_task_list): Don't declare.
3155         * ada-tasks.c (struct ada_tasks_inferior_data)
3156         <task_list_valid_p>: Now bool.
3157         (read_known_tasks, ada_task_list_changed)
3158         (ada_tasks_invalidate_inferior_data): Update.
3159         (read_known_tasks_array): Return bool.
3160         (read_known_tasks_list): Likewise.
3161         (read_known_tasks): Return void.
3162         (ada_build_task_list): Now static.
3163
3164 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3165
3166         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
3167         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
3168
3169 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3170
3171         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
3172         variant for ada_tasks_pspace_data_handle and
3173         ada_tasks_inferior_data_handle.
3174         (ada_tasks_pspace_data_cleanup): New function.
3175         (ada_tasks_inferior_data_cleanup): New function.
3176
3177 2019-02-17  Tom Tromey  <tom@tromey.com>
3178
3179         * macrotab.h (macro_source_fullname): Return a std::string.
3180         * macrotab.c (macro_include, check_for_redefinition)
3181         (macro_undef, macro_lookup_definition, foreach_macro)
3182         (foreach_macro_in_scope): Update.
3183         (macro_source_fullname): Return a std::string.
3184         * macrocmd.c (show_pp_source_pos): Update.
3185
3186 2019-02-17  Tom Tromey  <tom@tromey.com>
3187
3188         * macrocmd.c (show_pp_source_pos): Style the file names.
3189
3190 2019-02-17  Tom Tromey  <tom@tromey.com>
3191
3192         PR tui/24197:
3193         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
3194
3195 2019-02-17  Tom Tromey  <tom@tromey.com>
3196
3197         * ada-lang.c (user_select_syms): Use filtered printing.
3198         * utils.c (wrap_style): New global.
3199         (desired_style): Remove.
3200         (emit_style_escape): Add stream parameter.
3201         (set_output_style, reset_terminal_style, prompt_for_continue):
3202         Update.
3203         (flush_wrap_buffer): Only flush gdb_stdout.
3204         (wrap_here): Set wrap_style.
3205         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
3206         treat escape sequences as a character.  Change when wrap buffer is
3207         flushed.
3208         (fputs_styled): Do not set the output style when the default is
3209         requested.
3210         * ui-style.h (struct ui_file_style) <is_default>: New method.
3211         * source.c (print_source_lines_base): Emit escape sequences in one
3212         piece.
3213
3214 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3215
3216         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
3217         integers and enumeration types.
3218
3219 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3220
3221         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
3222         instead of lookup_symbol_in_language
3223         (do_exact_match): New function.
3224         (ada_get_symbol_name_matcher): Return do_exact_match when
3225         doing a verbatim match.
3226
3227 2019-02-15  Tom Tromey  <tromey@adacore.com>
3228
3229         * ravenscar-thread.c (ravenscar_thread_target::resume)
3230         (ravenscar_thread_target::wait): Special case wildcard requests.
3231
3232 2019-02-15  Tom Tromey  <tromey@adacore.com>
3233
3234         * ravenscar-thread.c (base_ptid): Remove.
3235         (struct ravenscar_thread_target) <close>: New method.
3236         <m_base_ptid>: New member.
3237         <update_inferior_ptid, active_task, task_is_currently_active,
3238         runtime_initialized>: Declare methods.
3239         <ravenscar_thread_target>: Add constructor.
3240         (ravenscar_thread_target::task_is_currently_active)
3241         (ravenscar_thread_target::update_inferior_ptid)
3242         (ravenscar_runtime_initialized): Rename.  Now methods.
3243         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
3244         (ravenscar_thread_target::update_thread_list): Update.
3245         (ravenscar_thread_target::active_task): Now method.
3246         (ravenscar_thread_target::store_registers)
3247         (ravenscar_thread_target::prepare_to_store)
3248         (ravenscar_thread_target::prepare_to_store)
3249         (ravenscar_thread_target::mourn_inferior): Update.
3250         (ravenscar_inferior_created): Use "new" to create target.
3251         (ravenscar_thread_target::get_ada_task_ptid): Update.
3252         (_initialize_ravenscar): Don't initialize base_ptid.
3253         (ravenscar_ops): Remove global.
3254
3255 2019-02-15  Tom Tromey  <tromey@adacore.com>
3256
3257         * target.h (push_target): Declare new overload.
3258         * target.c (push_target): New overload, taking an rvalue reference.
3259         * remote.c (remote_target::open_1): Use push_target overload.
3260         * corelow.c (core_target_open): Use push_target overload.
3261
3262 2019-02-15  Tom Tromey  <tromey@adacore.com>
3263
3264         * ravenscar-thread.c (is_ravenscar_task)
3265         (ravenscar_task_is_currently_active): Return bool.
3266         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
3267         (_initialize_ravenscar): Remove "(void)".
3268         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
3269         Return bool.
3270
3271 2019-02-15  Tom Tromey  <tromey@adacore.com>
3272
3273         * ravenscar-thread.c (ravenscar_runtime_initializer)
3274         (has_ravenscar_runtime, get_running_thread_id)
3275         (ravenscar_thread_target::resume): Fix indentation.
3276
3277 2019-02-15  Tom Tromey  <tromey@adacore.com>
3278
3279         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
3280         from ravenscar_arch_ops.
3281         (sparc_ravenscar_ops::fetch_registers)
3282         (sparc_ravenscar_ops::store_registers): Now methods.
3283         (sparc_ravenscar_prepare_to_store): Remove.
3284         (sparc_ravenscar_ops): Redefine.
3285         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
3286         methods and destructor.  Remove members.
3287         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
3288         (ravenscar_thread_target::store_registers)
3289         (ravenscar_thread_target::prepare_to_store): Update.
3290         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
3291         Remove.
3292         (struct ppc_ravenscar_powerpc_ops): Derive from
3293         ravenscar_arch_ops.
3294         (ppc_ravenscar_powerpc_ops::fetch_registers)
3295         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
3296         (ppc_ravenscar_powerpc_ops): Redefine.
3297         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
3298         (ppc_ravenscar_e500_ops::fetch_registers)
3299         (ppc_ravenscar_e500_ops::store_registers): Now methods.
3300         (ppc_ravenscar_e500_ops): Redefine.
3301         * aarch64-ravenscar-thread.c
3302         (aarch64_ravenscar_generic_prepare_to_store): Remove.
3303         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
3304         (aarch64_ravenscar_fetch_registers)
3305         (aarch64_ravenscar_store_registers): Now methods.
3306         (aarch64_ravenscar_ops): Redefine.
3307
3308 2019-02-15  Tom Tromey  <tromey@adacore.com>
3309
3310         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
3311         (ravenscar_thread_target::stopped_by_hw_breakpoint)
3312         (ravenscar_thread_target::stopped_by_watchpoint)
3313         (ravenscar_thread_target::stopped_data_address)
3314         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
3315
3316 2019-02-15  Tom Tromey  <tromey@adacore.com>
3317
3318         * ravenscar-thread.c: Fix some typos.
3319
3320 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3321             Tom Tromey  <tromey@adacore.com>
3322
3323         * ada-lang.c (ada_exception_sal): Change addr_string to a
3324         std::string.
3325         (create_ada_exception_catchpoint): Update.
3326
3327 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3328             Tom Tromey  <tromey@adacore.com>
3329
3330         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
3331         (bp_location_ops): Remove.
3332         (base_breakpoint_allocate_location): Update.
3333         (free_bp_location): Update.
3334         * ada-lang.c (class ada_catchpoint_location)
3335         <ada_catchpoint_location>: Remove ops parameter.
3336         (ada_catchpoint_location_dtor): Remove.
3337         (ada_catchpoint_location_ops): Remove.
3338         (allocate_location_exception): Update.
3339         * breakpoint.h (struct bp_location_ops): Remove.
3340         (class bp_location) <bp_location>: Remove bp_location_ops
3341         parameter.
3342         <~bp_location>: Add destructor.
3343         <ops>: Remove.
3344
3345 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3346             Pedro Alves  <palves@redhat.com>
3347
3348         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
3349         'PATH_MAX'.
3350
3351 2019-02-14  David Michael  <fedora.dm0@gmail.com>
3352             Samuel Thibault  <samuel.thibault@gnu.org>
3353             Thomas Schwinge  <thomas@codesourcery.com>
3354
3355         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
3356         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
3357
3358 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3359
3360         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
3361         (check_empty): Use "const char *".
3362
3363         * gnu-nat.c (gnu_nat_target::detach): Instead of
3364         'detach_inferior (pid)' call
3365         'detach_inferior (find_inferior_pid (pid))'.
3366
3367         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
3368         'nat/fork-inferior.o'.
3369         * gnu-nat.c: #include "nat/fork-inferior.h".
3370
3371         * gnu-nat.c (gnu_nat_target::detach): Instead of
3372         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
3373         * gnu-nat.h: #include "inf-child.h".
3374         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
3375         'i386_gnu_nat_target::fetch_registers'.
3376         (gnu_store_registers): Rename/move to
3377         'i386_gnu_nat_target::store_registers'.
3378
3379         * config/i386/nm-i386gnu.h: Don't "#include" any files.
3380         * gnu-nat.h (mach_thread_info): New function.
3381         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
3382
3383         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
3384
3385 2019-02-14  Frederic Konrad  <konrad@adacore.com>
3386
3387         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
3388
3389 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
3390
3391         * windows-nat.c (windows_add_thread): Add new parameter
3392         "main_thread_p" with default value set to false.  Update
3393         function documentation as well as all callers.
3394         (windows_delete_thread): Likewise.
3395         (fake_create_process): Update call to windows_add_thread.
3396         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
3397         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
3398         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
3399         call to windows_delete_thread.
3400
3401 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
3402
3403         * MAINTAINERS: Add Andrew Burgess as global maintainer.
3404
3405 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3406
3407         * symfile.c (find_separate_debug_file): Use canonical path of
3408         sysroot with child_path instead of gdb_sysroot if it is valid.
3409
3410 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3411
3412         * symfile.c (find_separate_debug_file): Use child_path to
3413         determine if an object file is under a sysroot.
3414
3415 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3416
3417         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
3418         unittests/child-path-selftests.c.
3419         * common/pathstuff.c (child_path): New function.
3420         * common/pathstuff.h (child_path): New prototype.
3421         * unittests/child-path-selftests.c: New file.
3422
3423 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3424
3425         * symfile.c (find_separate_debug_file): Look for separate debug
3426         files in debug directories under the sysroot.
3427
3428 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3429
3430         * symtab.h (struct minimal_symbol data_p): New const method.
3431         (struct minimal_symbol text_p): Likewise.
3432         * symtab.c (output_source_filename): Use file name style
3433         to print file name.
3434         (print_symbol_info): Likewise.
3435         (print_msymbol_info): Use address style to print addresses.
3436         Use function name style to print executable text symbols.
3437         (expand_symtab_containing_pc): Use data_p.
3438         (find_pc_sect_compunit_symtab): Likewise.
3439
3440 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3441
3442         * breakpoint.c (describe_other_breakpoints): Use address style
3443         to print addresses.
3444         (say_where): Likewise.
3445
3446 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3447
3448         * ada-typeprint.c (print_func_type): Print function name
3449         style to print function name.
3450         * c-typeprint.c (c_print_type_1): Likewise.
3451
3452 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
3453
3454         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
3455         for execve.
3456
3457 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3458
3459         * c-exp.y (direct_abs_decl): Use emplace_back to record the
3460         type_stack.
3461
3462 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
3463
3464         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
3465         TYPE_CODE_REF types.
3466
3467 2019-02-08  Jim Wilson  <jimw@sifive.com>
3468
3469         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
3470         (riscv_linux_fregset): New.
3471         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
3472
3473 2019-02-07  Tom Tromey  <tom@tromey.com>
3474
3475         * thread.c (thread_cancel_execution_command): Update.
3476         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
3477         methods.
3478         (struct thread_fsm_ops): Remove.
3479         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
3480         (thread_fsm_should_stop, thread_fsm_return_value)
3481         (thread_fsm_set_finished, thread_fsm_finished_p)
3482         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
3483         Don't declare.
3484         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
3485         * infrun.c (clear_proceed_status_thread)
3486         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
3487         (print_stop_event): Update.
3488         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
3489         Add constructor.
3490         (step_command_fsm_ops): Remove.
3491         (new_step_command_fsm): Remove.
3492         (step_1): Update.
3493         (step_command_fsm::should_stop): Rename from
3494         step_command_fsm_should_stop.
3495         (step_command_fsm::clean_up): Rename from
3496         step_command_fsm_clean_up.
3497         (step_command_fsm::do_async_reply_reason): Rename from
3498         step_command_fsm_async_reply_reason.
3499         (struct until_next_fsm): Inherit from thread_fsm.  Add
3500         constructor.
3501         (until_next_fsm_ops): Remove.
3502         (new_until_next_fsm): Remove.
3503         (until_next_fsm::should_stop): Rename from
3504         until_next_fsm_should_stop.
3505         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
3506         (until_next_fsm::do_async_reply_reason): Rename from
3507         until_next_fsm_async_reply_reason.
3508         (struct finish_command_fsm): Inherit from thread_fsm.  Add
3509         constructor.  Change type of breakpoint.
3510         (finish_command_fsm_ops): Remove.
3511         (new_finish_command_fsm): Remove.
3512         (finish_command_fsm::should_stop): Rename from
3513         finish_command_fsm_should_stop.
3514         (finish_command_fsm::clean_up): Rename from
3515         finish_command_fsm_clean_up.
3516         (finish_command_fsm::return_value): Rename from
3517         finish_command_fsm_return_value.
3518         (finish_command_fsm::do_async_reply_reason): Rename from
3519         finish_command_fsm_async_reply_reason.
3520         (finish_command): Update.
3521         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
3522         Add constructor.
3523         (call_thread_fsm_ops): Remove.
3524         (call_thread_fsm::call_thread_fsm): Rename from
3525         new_call_thread_fsm.
3526         (call_thread_fsm::should_stop): Rename from
3527         call_thread_fsm_should_stop.
3528         (call_thread_fsm::should_notify_stop): Rename from
3529         call_thread_fsm_should_notify_stop.
3530         (run_inferior_call, call_function_by_hand_dummy): Update.
3531         * cli/cli-interp.c (should_print_stop_to_console): Update.
3532         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
3533         Add constructor.  Change type of location_breakpoint,
3534         caller_breakpoint.
3535         (until_break_fsm_ops): Remove.
3536         (new_until_break_fsm): Remove.
3537         (until_break_fsm::should_stop): Rename from
3538         until_break_fsm_should_stop.
3539         (until_break_fsm::clean_up): Rename from
3540         until_break_fsm_clean_up.
3541         (until_break_fsm::do_async_reply_reason): Rename from
3542         until_break_fsm_async_reply_reason.
3543         (until_break_command): Update.
3544         * thread-fsm.c: Remove.
3545         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
3546
3547 2019-02-07  Tom Tromey  <tom@tromey.com>
3548
3549         * yy-remap.h: Add include guard.
3550         * xtensa-tdep.h: Add include guard.
3551         * xcoffread.h: Rename include guard.
3552         * varobj-iter.h: Add include guard.
3553         * tui/tui.h: Rename include guard.
3554         * tui/tui-winsource.h: Rename include guard.
3555         * tui/tui-wingeneral.h: Rename include guard.
3556         * tui/tui-windata.h: Rename include guard.
3557         * tui/tui-win.h: Rename include guard.
3558         * tui/tui-stack.h: Rename include guard.
3559         * tui/tui-source.h: Rename include guard.
3560         * tui/tui-regs.h: Rename include guard.
3561         * tui/tui-out.h: Rename include guard.
3562         * tui/tui-layout.h: Rename include guard.
3563         * tui/tui-io.h: Rename include guard.
3564         * tui/tui-hooks.h: Rename include guard.
3565         * tui/tui-file.h: Rename include guard.
3566         * tui/tui-disasm.h: Rename include guard.
3567         * tui/tui-data.h: Rename include guard.
3568         * tui/tui-command.h: Rename include guard.
3569         * tic6x-tdep.h: Add include guard.
3570         * target/waitstatus.h: Rename include guard.
3571         * target/wait.h: Rename include guard.
3572         * target/target.h: Rename include guard.
3573         * target/resume.h: Rename include guard.
3574         * target-float.h: Rename include guard.
3575         * stabsread.h: Add include guard.
3576         * rs6000-tdep.h: Add include guard.
3577         * riscv-fbsd-tdep.h: Add include guard.
3578         * regformats/regdef.h: Rename include guard.
3579         * record.h: Rename include guard.
3580         * python/python.h: Rename include guard.
3581         * python/python-internal.h: Rename include guard.
3582         * python/py-stopevent.h: Rename include guard.
3583         * python/py-ref.h: Rename include guard.
3584         * python/py-record.h: Rename include guard.
3585         * python/py-record-full.h: Rename include guard.
3586         * python/py-record-btrace.h: Rename include guard.
3587         * python/py-instruction.h: Rename include guard.
3588         * python/py-events.h: Rename include guard.
3589         * python/py-event.h: Rename include guard.
3590         * procfs.h: Add include guard.
3591         * proc-utils.h: Add include guard.
3592         * p-lang.h: Add include guard.
3593         * or1k-tdep.h: Rename include guard.
3594         * observable.h: Rename include guard.
3595         * nto-tdep.h: Rename include guard.
3596         * nat/x86-linux.h: Rename include guard.
3597         * nat/x86-linux-dregs.h: Rename include guard.
3598         * nat/x86-gcc-cpuid.h: Add include guard.
3599         * nat/x86-dregs.h: Rename include guard.
3600         * nat/x86-cpuid.h: Rename include guard.
3601         * nat/ppc-linux.h: Rename include guard.
3602         * nat/mips-linux-watch.h: Rename include guard.
3603         * nat/linux-waitpid.h: Rename include guard.
3604         * nat/linux-ptrace.h: Rename include guard.
3605         * nat/linux-procfs.h: Rename include guard.
3606         * nat/linux-osdata.h: Rename include guard.
3607         * nat/linux-nat.h: Rename include guard.
3608         * nat/linux-namespaces.h: Rename include guard.
3609         * nat/linux-btrace.h: Rename include guard.
3610         * nat/glibc_thread_db.h: Rename include guard.
3611         * nat/gdb_thread_db.h: Rename include guard.
3612         * nat/gdb_ptrace.h: Rename include guard.
3613         * nat/fork-inferior.h: Rename include guard.
3614         * nat/amd64-linux-siginfo.h: Rename include guard.
3615         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
3616         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
3617         * nat/aarch64-linux.h: Rename include guard.
3618         * nat/aarch64-linux-hw-point.h: Rename include guard.
3619         * mn10300-tdep.h: Add include guard.
3620         * mips-linux-tdep.h: Add include guard.
3621         * mi/mi-parse.h: Rename include guard.
3622         * mi/mi-out.h: Rename include guard.
3623         * mi/mi-main.h: Rename include guard.
3624         * mi/mi-interp.h: Rename include guard.
3625         * mi/mi-getopt.h: Rename include guard.
3626         * mi/mi-console.h: Rename include guard.
3627         * mi/mi-common.h: Rename include guard.
3628         * mi/mi-cmds.h: Rename include guard.
3629         * mi/mi-cmd-break.h: Rename include guard.
3630         * m2-lang.h: Add include guard.
3631         * location.h: Rename include guard.
3632         * linux-record.h: Rename include guard.
3633         * linux-nat.h: Add include guard.
3634         * linux-fork.h: Add include guard.
3635         * i386-darwin-tdep.h: Rename include guard.
3636         * hppa-linux-offsets.h: Add include guard.
3637         * guile/guile.h: Rename include guard.
3638         * guile/guile-internal.h: Rename include guard.
3639         * gnu-nat.h: Rename include guard.
3640         * gdb-stabs.h: Rename include guard.
3641         * frv-tdep.h: Add include guard.
3642         * f-lang.h: Add include guard.
3643         * event-loop.h: Add include guard.
3644         * darwin-nat.h: Rename include guard.
3645         * cp-abi.h: Rename include guard.
3646         * config/sparc/nm-sol2.h: Rename include guard.
3647         * config/nm-nto.h: Rename include guard.
3648         * config/nm-linux.h: Add include guard.
3649         * config/i386/nm-i386gnu.h: Rename include guard.
3650         * config/djgpp/nl_types.h: Rename include guard.
3651         * config/djgpp/langinfo.h: Rename include guard.
3652         * compile/gcc-cp-plugin.h: Add include guard.
3653         * compile/gcc-c-plugin.h: Add include guard.
3654         * compile/compile.h: Rename include guard.
3655         * compile/compile-object-run.h: Rename include guard.
3656         * compile/compile-object-load.h: Rename include guard.
3657         * compile/compile-internal.h: Rename include guard.
3658         * compile/compile-cplus.h: Rename include guard.
3659         * compile/compile-c.h: Rename include guard.
3660         * common/xml-utils.h: Rename include guard.
3661         * common/x86-xstate.h: Rename include guard.
3662         * common/version.h: Rename include guard.
3663         * common/vec.h: Rename include guard.
3664         * common/tdesc.h: Rename include guard.
3665         * common/selftest.h: Rename include guard.
3666         * common/scoped_restore.h: Rename include guard.
3667         * common/scoped_mmap.h: Rename include guard.
3668         * common/scoped_fd.h: Rename include guard.
3669         * common/safe-iterator.h: Rename include guard.
3670         * common/run-time-clock.h: Rename include guard.
3671         * common/refcounted-object.h: Rename include guard.
3672         * common/queue.h: Rename include guard.
3673         * common/ptid.h: Rename include guard.
3674         * common/print-utils.h: Rename include guard.
3675         * common/preprocessor.h: Rename include guard.
3676         * common/pathstuff.h: Rename include guard.
3677         * common/observable.h: Rename include guard.
3678         * common/netstuff.h: Rename include guard.
3679         * common/job-control.h: Rename include guard.
3680         * common/host-defs.h: Rename include guard.
3681         * common/gdb_wait.h: Rename include guard.
3682         * common/gdb_vecs.h: Rename include guard.
3683         * common/gdb_unlinker.h: Rename include guard.
3684         * common/gdb_unique_ptr.h: Rename include guard.
3685         * common/gdb_tilde_expand.h: Rename include guard.
3686         * common/gdb_sys_time.h: Rename include guard.
3687         * common/gdb_string_view.h: Rename include guard.
3688         * common/gdb_splay_tree.h: Rename include guard.
3689         * common/gdb_setjmp.h: Rename include guard.
3690         * common/gdb_ref_ptr.h: Rename include guard.
3691         * common/gdb_optional.h: Rename include guard.
3692         * common/gdb_locale.h: Rename include guard.
3693         * common/gdb_assert.h: Rename include guard.
3694         * common/filtered-iterator.h: Rename include guard.
3695         * common/filestuff.h: Rename include guard.
3696         * common/fileio.h: Rename include guard.
3697         * common/environ.h: Rename include guard.
3698         * common/common-utils.h: Rename include guard.
3699         * common/common-types.h: Rename include guard.
3700         * common/common-regcache.h: Rename include guard.
3701         * common/common-inferior.h: Rename include guard.
3702         * common/common-gdbthread.h: Rename include guard.
3703         * common/common-exceptions.h: Rename include guard.
3704         * common/common-defs.h: Rename include guard.
3705         * common/common-debug.h: Rename include guard.
3706         * common/cleanups.h: Rename include guard.
3707         * common/buffer.h: Rename include guard.
3708         * common/btrace-common.h: Rename include guard.
3709         * common/break-common.h: Rename include guard.
3710         * cli/cli-utils.h: Rename include guard.
3711         * cli/cli-style.h: Rename include guard.
3712         * cli/cli-setshow.h: Rename include guard.
3713         * cli/cli-script.h: Rename include guard.
3714         * cli/cli-interp.h: Rename include guard.
3715         * cli/cli-decode.h: Rename include guard.
3716         * cli/cli-cmds.h: Rename include guard.
3717         * charset-list.h: Add include guard.
3718         * buildsym-legacy.h: Rename include guard.
3719         * bfin-tdep.h: Add include guard.
3720         * ax.h: Rename include guard.
3721         * arm-linux-tdep.h: Add include guard.
3722         * arm-fbsd-tdep.h: Add include guard.
3723         * arch/xtensa.h: Rename include guard.
3724         * arch/tic6x.h: Add include guard.
3725         * arch/i386.h: Add include guard.
3726         * arch/arm.h: Rename include guard.
3727         * arch/arm-linux.h: Rename include guard.
3728         * arch/arm-get-next-pcs.h: Rename include guard.
3729         * arch/amd64.h: Add include guard.
3730         * arch/aarch64-insn.h: Rename include guard.
3731         * arch-utils.h: Rename include guard.
3732         * annotate.h: Add include guard.
3733         * amd64-darwin-tdep.h: Rename include guard.
3734         * aarch64-linux-tdep.h: Add include guard.
3735         * aarch64-fbsd-tdep.h: Add include guard.
3736         * aarch32-linux-nat.h: Add include guard.
3737
3738 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3739
3740         * macrotab.c (macro_define_internal): New function that
3741         factorizes macro_define_object_internal and macro_define_function
3742         code.
3743         (macro_define_object_internal): Use macro_define_internal.
3744         (macro_define_function): Likewise.
3745
3746 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3747
3748         * macrocmd.c (extract_identifier): Return
3749         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
3750         callers.
3751
3752 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
3753
3754         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
3755
3756 2019-02-05  Tom Tromey  <tom@tromey.com>
3757
3758         * target.c (target_stack::unpush): Move assertion earlier.
3759
3760 2019-01-30  Tom Tromey  <tom@tromey.com>
3761
3762         PR python/23615:
3763         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
3764         (gdbpy_parse_and_eval): Likewise.
3765         * python/python-internal.h (gdbpy_allow_threads): New class.
3766
3767 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
3768
3769         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
3770         (aarch64_fbsd_fpregmap): Move earlier.
3771         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
3772         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3773         instead of individual calls to trad_frame_set_reg_addr.
3774         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
3775         earlier.
3776         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
3777         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3778         instead of individual calls to trad_frame_set_reg_addr.
3779
3780 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
3781
3782         * CONTRIBUTE: Replace contribution list with wiki link.
3783
3784 2019-01-25  Tom Tromey  <tom@tromey.com>
3785
3786         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
3787
3788 2019-01-25  Tom Tromey  <tom@tromey.com>
3789
3790         * xtensa-linux-nat.c: Fix common/ includes.
3791         * xml-support.h: Fix common/ includes.
3792         * xml-support.c: Fix common/ includes.
3793         * x86-linux-nat.c: Fix common/ includes.
3794         * windows-nat.c: Fix common/ includes.
3795         * varobj.h: Fix common/ includes.
3796         * varobj.c: Fix common/ includes.
3797         * value.c: Fix common/ includes.
3798         * valops.c: Fix common/ includes.
3799         * utils.c: Fix common/ includes.
3800         * unittests/xml-utils-selftests.c: Fix common/ includes.
3801         * unittests/utils-selftests.c: Fix common/ includes.
3802         * unittests/unpack-selftests.c: Fix common/ includes.
3803         * unittests/tracepoint-selftests.c: Fix common/ includes.
3804         * unittests/style-selftests.c: Fix common/ includes.
3805         * unittests/string_view-selftests.c: Fix common/ includes.
3806         * unittests/scoped_restore-selftests.c: Fix common/ includes.
3807         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
3808         * unittests/scoped_fd-selftests.c: Fix common/ includes.
3809         * unittests/rsp-low-selftests.c: Fix common/ includes.
3810         * unittests/parse-connection-spec-selftests.c: Fix common/
3811         includes.
3812         * unittests/optional-selftests.c: Fix common/ includes.
3813         * unittests/offset-type-selftests.c: Fix common/ includes.
3814         * unittests/observable-selftests.c: Fix common/ includes.
3815         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
3816         * unittests/memrange-selftests.c: Fix common/ includes.
3817         * unittests/memory-map-selftests.c: Fix common/ includes.
3818         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
3819         * unittests/function-view-selftests.c: Fix common/ includes.
3820         * unittests/environ-selftests.c: Fix common/ includes.
3821         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
3822         * unittests/common-utils-selftests.c: Fix common/ includes.
3823         * unittests/cli-utils-selftests.c: Fix common/ includes.
3824         * unittests/array-view-selftests.c: Fix common/ includes.
3825         * ui-file.c: Fix common/ includes.
3826         * tui/tui-io.c: Fix common/ includes.
3827         * tracepoint.h: Fix common/ includes.
3828         * tracepoint.c: Fix common/ includes.
3829         * tracefile-tfile.c: Fix common/ includes.
3830         * top.h: Fix common/ includes.
3831         * top.c: Fix common/ includes.
3832         * thread.c: Fix common/ includes.
3833         * target/waitstatus.h: Fix common/ includes.
3834         * target/waitstatus.c: Fix common/ includes.
3835         * target.h: Fix common/ includes.
3836         * target.c: Fix common/ includes.
3837         * target-memory.c: Fix common/ includes.
3838         * target-descriptions.c: Fix common/ includes.
3839         * symtab.h: Fix common/ includes.
3840         * symfile.c: Fix common/ includes.
3841         * stap-probe.c: Fix common/ includes.
3842         * spu-linux-nat.c: Fix common/ includes.
3843         * sparc-nat.c: Fix common/ includes.
3844         * source.c: Fix common/ includes.
3845         * solib.c: Fix common/ includes.
3846         * solib-target.c: Fix common/ includes.
3847         * ser-unix.c: Fix common/ includes.
3848         * ser-tcp.c: Fix common/ includes.
3849         * ser-pipe.c: Fix common/ includes.
3850         * ser-base.c: Fix common/ includes.
3851         * selftest-arch.c: Fix common/ includes.
3852         * s12z-tdep.c: Fix common/ includes.
3853         * rust-exp.y: Fix common/ includes.
3854         * rs6000-aix-tdep.c: Fix common/ includes.
3855         * riscv-tdep.c: Fix common/ includes.
3856         * remote.c: Fix common/ includes.
3857         * remote-notif.h: Fix common/ includes.
3858         * remote-fileio.h: Fix common/ includes.
3859         * remote-fileio.c: Fix common/ includes.
3860         * regcache.h: Fix common/ includes.
3861         * regcache.c: Fix common/ includes.
3862         * record-btrace.c: Fix common/ includes.
3863         * python/python.c: Fix common/ includes.
3864         * python/py-type.c: Fix common/ includes.
3865         * python/py-inferior.c: Fix common/ includes.
3866         * progspace.h: Fix common/ includes.
3867         * producer.c: Fix common/ includes.
3868         * procfs.c: Fix common/ includes.
3869         * proc-api.c: Fix common/ includes.
3870         * printcmd.c: Fix common/ includes.
3871         * ppc-linux-nat.c: Fix common/ includes.
3872         * parser-defs.h: Fix common/ includes.
3873         * osdata.c: Fix common/ includes.
3874         * obsd-nat.c: Fix common/ includes.
3875         * nat/x86-linux.c: Fix common/ includes.
3876         * nat/x86-linux-dregs.c: Fix common/ includes.
3877         * nat/x86-dregs.h: Fix common/ includes.
3878         * nat/x86-dregs.c: Fix common/ includes.
3879         * nat/ppc-linux.c: Fix common/ includes.
3880         * nat/mips-linux-watch.h: Fix common/ includes.
3881         * nat/mips-linux-watch.c: Fix common/ includes.
3882         * nat/linux-waitpid.c: Fix common/ includes.
3883         * nat/linux-ptrace.h: Fix common/ includes.
3884         * nat/linux-ptrace.c: Fix common/ includes.
3885         * nat/linux-procfs.c: Fix common/ includes.
3886         * nat/linux-personality.c: Fix common/ includes.
3887         * nat/linux-osdata.c: Fix common/ includes.
3888         * nat/linux-namespaces.c: Fix common/ includes.
3889         * nat/linux-btrace.h: Fix common/ includes.
3890         * nat/linux-btrace.c: Fix common/ includes.
3891         * nat/fork-inferior.c: Fix common/ includes.
3892         * nat/amd64-linux-siginfo.c: Fix common/ includes.
3893         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
3894         * nat/aarch64-linux.c: Fix common/ includes.
3895         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
3896         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
3897         * namespace.h: Fix common/ includes.
3898         * mips-linux-tdep.c: Fix common/ includes.
3899         * minsyms.c: Fix common/ includes.
3900         * mi/mi-parse.h: Fix common/ includes.
3901         * mi/mi-main.c: Fix common/ includes.
3902         * mi/mi-cmd-env.c: Fix common/ includes.
3903         * memrange.h: Fix common/ includes.
3904         * memattr.c: Fix common/ includes.
3905         * maint.h: Fix common/ includes.
3906         * maint.c: Fix common/ includes.
3907         * main.c: Fix common/ includes.
3908         * machoread.c: Fix common/ includes.
3909         * location.c: Fix common/ includes.
3910         * linux-thread-db.c: Fix common/ includes.
3911         * linux-nat.c: Fix common/ includes.
3912         * linux-fork.c: Fix common/ includes.
3913         * inline-frame.c: Fix common/ includes.
3914         * infrun.c: Fix common/ includes.
3915         * inflow.c: Fix common/ includes.
3916         * inferior.h: Fix common/ includes.
3917         * inferior.c: Fix common/ includes.
3918         * infcmd.c: Fix common/ includes.
3919         * inf-ptrace.c: Fix common/ includes.
3920         * inf-child.c: Fix common/ includes.
3921         * ia64-linux-nat.c: Fix common/ includes.
3922         * i387-tdep.c: Fix common/ includes.
3923         * i386-tdep.c: Fix common/ includes.
3924         * i386-linux-tdep.c: Fix common/ includes.
3925         * i386-linux-nat.c: Fix common/ includes.
3926         * i386-go32-tdep.c: Fix common/ includes.
3927         * i386-fbsd-tdep.c: Fix common/ includes.
3928         * i386-fbsd-nat.c: Fix common/ includes.
3929         * guile/scm-type.c: Fix common/ includes.
3930         * guile/guile.c: Fix common/ includes.
3931         * go32-nat.c: Fix common/ includes.
3932         * gnu-nat.c: Fix common/ includes.
3933         * gdbthread.h: Fix common/ includes.
3934         * gdbarch-selftests.c: Fix common/ includes.
3935         * gdb_usleep.c: Fix common/ includes.
3936         * gdb_select.h: Fix common/ includes.
3937         * gdb_bfd.c: Fix common/ includes.
3938         * gcore.c: Fix common/ includes.
3939         * fork-child.c: Fix common/ includes.
3940         * findvar.c: Fix common/ includes.
3941         * fbsd-nat.c: Fix common/ includes.
3942         * event-top.c: Fix common/ includes.
3943         * event-loop.c: Fix common/ includes.
3944         * dwarf2read.c: Fix common/ includes.
3945         * dwarf2loc.c: Fix common/ includes.
3946         * dwarf2-frame.c: Fix common/ includes.
3947         * dwarf-index-cache.c: Fix common/ includes.
3948         * dtrace-probe.c: Fix common/ includes.
3949         * disasm-selftests.c: Fix common/ includes.
3950         * defs.h: Fix common/ includes.
3951         * csky-tdep.c: Fix common/ includes.
3952         * cp-valprint.c: Fix common/ includes.
3953         * cp-support.h: Fix common/ includes.
3954         * cp-support.c: Fix common/ includes.
3955         * corelow.c: Fix common/ includes.
3956         * completer.h: Fix common/ includes.
3957         * completer.c: Fix common/ includes.
3958         * compile/compile.c: Fix common/ includes.
3959         * compile/compile-loc2c.c: Fix common/ includes.
3960         * compile/compile-cplus-types.c: Fix common/ includes.
3961         * compile/compile-cplus-symbols.c: Fix common/ includes.
3962         * command.h: Fix common/ includes.
3963         * cli/cli-dump.c: Fix common/ includes.
3964         * cli/cli-cmds.c: Fix common/ includes.
3965         * charset.c: Fix common/ includes.
3966         * build-id.c: Fix common/ includes.
3967         * btrace.h: Fix common/ includes.
3968         * btrace.c: Fix common/ includes.
3969         * breakpoint.h: Fix common/ includes.
3970         * breakpoint.c: Fix common/ includes.
3971         * ax.h: 
3972         (enum agent_op): Fix common/ includes.
3973         * ax-general.c (struct aop_map): Fix common/ includes.
3974         * ax-gdb.c: Fix common/ includes.
3975         * auxv.c: Fix common/ includes.
3976         * auto-load.c: Fix common/ includes.
3977         * arm-tdep.c: Fix common/ includes.
3978         * arch/riscv.c: Fix common/ includes.
3979         * arch/ppc-linux-common.c: Fix common/ includes.
3980         * arch/i386.c: Fix common/ includes.
3981         * arch/arm.c: Fix common/ includes.
3982         * arch/arm-linux.c: Fix common/ includes.
3983         * arch/arm-get-next-pcs.c: Fix common/ includes.
3984         * arch/amd64.c: Fix common/ includes.
3985         * arch/aarch64.c: Fix common/ includes.
3986         * arch/aarch64-insn.c: Fix common/ includes.
3987         * arch-utils.c: Fix common/ includes.
3988         * amd64-windows-tdep.c: Fix common/ includes.
3989         * amd64-tdep.c: Fix common/ includes.
3990         * amd64-sol2-tdep.c: Fix common/ includes.
3991         * amd64-obsd-tdep.c: Fix common/ includes.
3992         * amd64-nbsd-tdep.c: Fix common/ includes.
3993         * amd64-linux-tdep.c: Fix common/ includes.
3994         * amd64-linux-nat.c: Fix common/ includes.
3995         * amd64-fbsd-tdep.c: Fix common/ includes.
3996         * amd64-fbsd-nat.c: Fix common/ includes.
3997         * amd64-dicos-tdep.c: Fix common/ includes.
3998         * amd64-darwin-tdep.c: Fix common/ includes.
3999         * agent.c: Fix common/ includes.
4000         * ada-lang.h: Fix common/ includes.
4001         * ada-lang.c: Fix common/ includes.
4002         * aarch64-tdep.c: Fix common/ includes.
4003
4004 2019-01-25  Tom Tromey  <tom@tromey.com>
4005
4006         * common/create-version.sh: Use common/version.h.
4007
4008 2019-01-24  Pedro Alves  <palves@redhat.com>
4009
4010         * infrun.c (signal_stop, signal_print, signal_program)
4011         (signal_catch, signal_pass): Now arrays instead of pointers.
4012         (update_signals_program_target, do_target_resume)
4013         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
4014         * linux-nat.c (linux_nat_target::pass_signals)
4015         (linux_nat_target::create_inferior, linux_nat_target::attach):
4016         Adjust.
4017         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
4018         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
4019         * procfs.c (procfs_target::pass_signals): Adjust.
4020         * record-full.c (record_full_target::resume): Adjust.
4021         * remote.c (remote_target::pass_signals)
4022         (remote_target::program_signals): Adjust.
4023         * target-debug.h (target_debug_print_signals): Now takes a
4024         gdb::array_view as parameter.  Adjust.
4025         * target.h (target_ops) <pass_signals, program_signals>: Replace
4026         pointer and length parameters with gdb::array_view.
4027         (target_pass_signals, target_program_signals): Likewise.
4028         * target-delegates.c: Regenerate.
4029
4030 2019-01-24  Pedro Alves  <palves@redhat.com>
4031
4032         * common/forward-scope-exit.h
4033         (forward_scope_exit::forward_scope_exit): Pass arguments to
4034         m_bind_function directly, instead of creating a std::bind and
4035         copying that.
4036
4037 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
4038
4039         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4040         for static members.
4041         (pass_in_v_vfp_candidate): Likewise.
4042
4043 2019-01-23  Tom Tromey  <tom@tromey.com>
4044             Pedro Alves  <palves@redhat.com>
4045
4046         * regcache.c (class regcache_invalidator): Remove.
4047         (regcache::raw_write): Use make_scope_exit.
4048
4049 2019-01-23  Tom Tromey  <tom@tromey.com>
4050
4051         * ui-out.h (class ui_out_emit_type): Update comment.
4052
4053 2019-01-23  Tom Tromey  <tom@tromey.com>
4054
4055         * infrun.c (fetch_inferior_event): Update comment.
4056
4057 2019-01-23  Tom Tromey  <tom@tromey.com>
4058             Pedro Alves  <palves@redhat.com>
4059
4060         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
4061         parameter.
4062         (fetch_inferior_event): Use SCOPE_EXIT.
4063
4064
4065 2019-01-23  Tom Tromey  <tom@tromey.com>
4066             Pedro Alves  <palves@redhat.com>
4067
4068         * infrun.c (disable_thread_events): Delete.
4069         (stop_all_threads): Use SCOPE_EXIT.
4070
4071 2019-01-23  Tom Tromey  <tom@tromey.com>
4072             Pedro Alves  <palves@redhat.com>
4073
4074         * symfile.c: Include forward-scope-exit.h.
4075         (clear_symtab_users_cleanup): Replace forward declaration with
4076         a FORWARD_SCOPE_EXIT.
4077         (syms_from_objfile_1): Use the forward_scope_exit and
4078         gdb::optional instead of cleanup_function.
4079         (reread_symbols): Use the forward_scope_exit instead of
4080         cleanup_function.
4081         (clear_symtab_users_cleanup): Remove function.
4082
4083 2019-01-23  Tom Tromey  <tom@tromey.com>
4084             Pedro Alves  <palves@redhat.com>
4085
4086         * linux-nat.c: Include scope-exit.h.
4087         (cleanup_target_stop): Remove.
4088         (linux_nat_target::static_tracepoint_markers_by_strid): Use
4089         SCOPE_EXIT.
4090
4091 2019-01-23  Tom Tromey  <tom@tromey.com>
4092             Pedro Alves  <palves@redhat.com>
4093
4094         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
4095         (call_function_by_hand_dummy): Use SCOPE_EXIT.
4096
4097 2019-01-23  Tom Tromey  <tom@tromey.com>
4098             Andrew Burgess  <andrew.burgess@embecosm.com>
4099             Pedro Alves  <palves@redhat.com>
4100
4101         * infrun.c (fetch_inferior_event): Use scope_exit.
4102         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
4103         * top.c (execute_command): Use scope_exit.
4104         * breakpoint.c (bpstat_do_actions): Use scope_exit.
4105         * utils.c (do_bpstat_clear_actions_cleanup)
4106         (make_bpstat_clear_actions_cleanup): Remove.
4107
4108 2019-01-23  Tom Tromey  <tom@tromey.com>
4109             Pedro Alves  <palves@redhat.com>
4110
4111         * infrun.c: Include "common/scope-exit.h"
4112         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
4113         (wait_for_inferior): Use SCOPE_EXIT.
4114         (fetch_inferior_event): Use scope_exit.
4115
4116 2019-01-23  Tom Tromey  <tom@tromey.com>
4117             Pedro Alves  <palves@redhat.com>
4118
4119         * breakpoint.c (create_breakpoint): Remove cleanup.
4120
4121 2019-01-23  Tom Tromey  <tom@tromey.com>
4122             Andrew Burgess  <andrew.burgess@embecosm.com>
4123             Pedro Alves  <palves@redhat.com>
4124
4125 2019-01-23  Pedro Alves  <palves@redhat.com>
4126
4127         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
4128
4129 2019-01-23  Pedro Alves  <palves@redhat.com>
4130             Andrew Burgess  <andrew.burgess@embecosm.com>
4131
4132         * gdbthread.h: Include "common/forward-scope-exit.h".
4133         (scoped_finish_thread_state): Redefine custom class in terms of
4134         forward_scope_exit.
4135
4136 2019-01-23  Pedro Alves  <palves@redhat.com>
4137             Andrew Burgess  <andrew.burgess@embecosm.com>
4138
4139         * common/forward-scope-exit.h: New file.
4140
4141 2019-01-23  Pedro Alves  <palves@redhat.com>
4142             Andrew Burgess  <andrew.burgess@embecosm.com>
4143             Tom Tromey  <tom@tromey.com>
4144
4145         * common/scope-exit.h: New file.
4146
4147 2019-01-23  Pedro Alves  <palves@redhat.com>
4148
4149         * common/preprocessor.h (ESC): Rename to ...
4150         (ESC_PARENS): ... this.
4151         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
4152         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
4153
4154 2019-01-23  Tom Tromey  <tom@tromey.com>
4155
4156         * language.h (class scoped_switch_to_sym_language_if_auto):
4157         Initialize m_lang in both cases.
4158
4159 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
4160
4161         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
4162         with XCNEW.
4163
4164 2019-01-22  Tom Tromey  <tom@tromey.com>
4165
4166         * corelow.c: Do not include sys/file.h.
4167
4168 2019-01-22  Tom Tromey  <tom@tromey.com>
4169
4170         * tui/tui-wingeneral.h: Include gdb_curses.h.
4171
4172 2019-01-22  Tom Tromey  <tom@tromey.com>
4173
4174         * source-cache.h (class source_cache) <get_source_lines,
4175         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
4176
4177 2019-01-22  Tom Tromey  <tom@tromey.com>
4178
4179         * remote-fileio.h (struct remote_target): Declare.
4180
4181 2019-01-22  Tom Tromey  <tom@tromey.com>
4182
4183         * python/py-arch.c: Do not include py-ref.h.
4184         * python/py-bpevent.c: Do not include py-ref.h.
4185         * python/py-cmd.c: Do not include py-ref.h.
4186         * python/py-continueevent.c: Do not include py-ref.h.
4187         * python/py-event.h: Do not include py-ref.h.
4188         * python/py-evtregistry.c: Do not include py-ref.h.
4189         * python/py-finishbreakpoint.c: Do not include py-ref.h.
4190         * python/py-frame.c: Do not include py-ref.h.
4191         * python/py-framefilter.c: Do not include py-ref.h.
4192         * python/py-function.c: Do not include py-ref.h.
4193         * python/py-infevents.c: Do not include py-ref.h.
4194         * python/py-linetable.c: Do not include py-ref.h.
4195         * python/py-objfile.c: Do not include py-ref.h.
4196         * python/py-param.c: Do not include py-ref.h.
4197         * python/py-prettyprint.c: Do not include py-ref.h.
4198         * python/py-progspace.c: Do not include py-ref.h.
4199         * python/py-symbol.c: Do not include py-ref.h.
4200         * python/py-symtab.c: Do not include py-ref.h.
4201         * python/py-type.c: Do not include py-ref.h.
4202         * python/py-unwind.c: Do not include py-ref.h.
4203         * python/py-utils.c: Do not include py-ref.h.
4204         * python/py-value.c: Do not include py-ref.h.
4205         * python/py-varobj.c: Do not include py-ref.h.
4206         * python/py-xmethods.c: Do not include py-ref.h.
4207         * python/python.c: Do not include py-ref.h.
4208         * varobj.c: Do not include py-ref.h.
4209
4210 2019-01-22  Tom Tromey  <tom@tromey.com>
4211
4212         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
4213         keyword for bcache.
4214
4215 2019-01-22  Tom Tromey  <tom@tromey.com>
4216
4217         * compile/compile-cplus-types.c: Remove a comment by #include.
4218
4219 2019-01-22  Tom Tromey  <tom@tromey.com>
4220
4221         * compile/gcc-c-plugin.h: Include compile-internal.h.
4222
4223 2019-01-22  Tom Tromey  <tom@tromey.com>
4224
4225         * stabsread.c (EXTERN): Do not define.
4226         (symnum, next_symbol_text_func, processing_gcc_compilation)
4227         (within_function, global_sym_chain, global_stabs)
4228         (previous_stab_code, this_object_header_files)
4229         (n_this_object_header_files)
4230         (n_allocated_this_object_header_files): Define.
4231         * stabsread.h (EXTERN): Never define.  Use "extern".
4232
4233 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4234
4235         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
4236         history_value.
4237
4238 2019-01-21  Tom Tromey  <tom@tromey.com>
4239
4240         * ui-out.c: Fix includes.
4241         * tui/tui-source.c: Fix includes.
4242         * target.c: Fix includes.
4243         * remote.c: Fix includes.
4244         * regcache.c: Fix includes.
4245         * python/py-block.c: Fix includes.
4246         * printcmd.c: Fix includes.
4247         * or1k-tdep.c: Fix includes.
4248         * mi/mi-main.c: Fix includes.
4249         * m32r-tdep.c: Fix includes.
4250         * csky-tdep.c: Fix includes.
4251         * compile/compile-cplus-types.c: Fix includes.
4252         * cli/cli-interp.c: Fix includes.
4253
4254 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
4255
4256         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4257         for padding.
4258
4259 2019-01-16  Tom Tromey  <tom@tromey.com>
4260
4261         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
4262         earlier.
4263         (struct objfile) <msymbols_range>: Move from top level.
4264         <msymbols>: New method.
4265         (class objfile_msymbols): Remove.
4266         * symtab.c (default_collect_symbol_completion_matches_break_on):
4267         Update.
4268         * symmisc.c (dump_msymbols): Update.
4269         * stabsread.c (scan_file_globals): Update.
4270         * objc-lang.c (info_selectors_command, info_classes_command)
4271         (find_methods): Update.
4272         * minsyms.c (find_solib_trampoline_target): Update.
4273         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
4274         * coffread.c (coff_symfile_read): Update.
4275         * ada-lang.c (ada_lookup_simple_minsym)
4276         (ada_collect_symbol_completion_matches): Update.
4277
4278 2019-01-16  Tom Tromey  <tom@tromey.com>
4279
4280         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
4281         type.  Remove no-argument constructor.
4282         <iterator::operator++>: Simplify.
4283         <begin>: Update.
4284         <end>: Use minimal_symbol_count.
4285
4286 2019-01-16  Tom Tromey  <tom@tromey.com>
4287
4288         * objfiles.h (struct objfile) <psymtabs>: New method.
4289         (class objfile_psymtabs): Remove.
4290         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
4291         typedef.
4292         <range>: New method.
4293         (require_partial_symbols): Change return type.
4294         * psymtab.c (require_partial_symbols)
4295         (psym_expand_symtabs_matching): Update.
4296         * mdebugread.c (parse_partial_symbols): Update.
4297         * dbxread.c (dbx_end_psymtab): Update.
4298
4299 2019-01-15  Tom Tromey  <tom@tromey.com>
4300
4301         * symtab.c (lookup_objfile_from_block)
4302         (lookup_symbol_in_objfile_symtabs)
4303         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
4304         (find_line_symtab, info_sources_command)
4305         (default_collect_symbol_completion_matches_break_on)
4306         (make_source_files_completion_list): Update.
4307         * symmisc.c (print_objfile_statistics, dump_objfile)
4308         (maintenance_print_symbols, maintenance_info_symtabs)
4309         (maintenance_check_symtabs, maintenance_info_line_tables):
4310         Update.
4311         * source.c (select_source_symtab)
4312         (forget_cached_source_info_for_objfile): Update.
4313         * objfiles.h (class objfile_compunits): Remove.
4314         (struct objfile) <compunits_range>: New typedef.
4315         (compunits): New method.
4316         * objfiles.c (objfile_relocate1): Update.
4317         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4318         * maint.c (count_symtabs_and_blocks): Update.
4319         * linespec.c (iterate_over_all_matching_symtabs): Update.
4320         * cp-support.c (add_symbol_overload_list_qualified): Update.
4321         * coffread.c (coff_symtab_read): Update.
4322         * ada-lang.c (add_nonlocal_symbols)
4323         (ada_collect_symbol_completion_matches)
4324         (ada_add_global_exceptions): Update.
4325
4326 2019-01-15  Tom Tromey  <tom@tromey.com>
4327
4328         * progspace.h (program_space) <objfiles_safe_range>: New
4329         typedef.
4330         <objfiles_safe>: New method.
4331         * objfiles.h (class all_objfiles_safe): Remove.
4332         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
4333         * jit.c (jit_inferior_exit_hook): Update.
4334
4335 2019-01-17  Tom Tromey  <tom@tromey.com>
4336
4337         * progspace.h (program_space) <objfiles_range>: New typedef.
4338         <objfiles>: New method.
4339         <objfiles_head>: Rename from objfiles.
4340         (object_files): Update.
4341         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
4342         * guile/scm-pretty-print.c
4343         (ppscm_find_pretty_printer_from_objfiles): Update.
4344         * guile/scm-objfile.c (gdbscm_objfiles): Update.
4345         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
4346         Update.
4347         * python/py-progspace.c (pspy_get_objfiles): Update.
4348         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
4349         Update.
4350         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
4351         (objfpy_lookup_objfile_by_build_id): Update.
4352         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4353         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
4354         Update.
4355         * symtab.c (iterate_over_symtabs, matching_obj_sections)
4356         (expand_symtab_containing_pc, lookup_objfile_from_block)
4357         (lookup_static_symbol, basic_lookup_transparent_type)
4358         (find_pc_sect_compunit_symtab, find_symbol_at_address)
4359         (find_line_symtab, info_sources_command)
4360         (default_collect_symbol_completion_matches_break_on)
4361         (make_source_files_completion_list, find_main_name): Update.
4362         * symmisc.c (print_symbol_bcache_statistics)
4363         (print_objfile_statistics, maintenance_print_symbols)
4364         (maintenance_print_msymbols, maintenance_print_objfiles)
4365         (maintenance_info_symtabs, maintenance_check_symtabs)
4366         (maintenance_expand_symtabs, maintenance_info_line_tables):
4367         Update.
4368         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
4369         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
4370         (map_overlay_command, unmap_overlay_command)
4371         (simple_overlay_update, expand_symtabs_matching)
4372         (map_symbol_filenames): Update.
4373         * symfile-debug.c (set_debug_symfile): Update.
4374         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
4375         Update.
4376         * source.c (select_source_symtab, forget_cached_source_info):
4377         Update.
4378         * solib.c (solib_read_symbols): Update.
4379         * solib-spu.c (append_ocl_sos): Update.
4380         * psymtab.c (maintenance_print_psymbols)
4381         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
4382         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
4383         * printcmd.c (info_symbol_command): Update.
4384         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
4385         Update.
4386         * objfiles.h (class all_objfiles): Remove.
4387         * objfiles.c (have_partial_symbols, have_full_symbols)
4388         (have_minimal_symbols, qsort_cmp, update_section_map)
4389         (shared_objfile_contains_address_p)
4390         (default_iterate_over_objfiles_in_search_order): Update.
4391         * objc-lang.c (info_selectors_command, info_classes_command)
4392         (find_methods): Update.
4393         * minsyms.c (find_solib_trampoline_target): Update.
4394         * maint.c (maintenance_info_sections)
4395         (maintenance_translate_address, count_symtabs_and_blocks):
4396         Update.
4397         * main.c (captured_main_1): Update.
4398         * linux-thread-db.c (try_thread_db_load_from_pdir)
4399         (has_libpthread): Update.
4400         * linespec.c (iterate_over_all_matching_symtabs)
4401         (search_minsyms_for_name): Update.
4402         * jit.c (jit_find_objf_with_entry_addr): Update.
4403         * hppa-tdep.c (find_unwind_entry)
4404         (hppa_lookup_stub_minimal_symbol): Update.
4405         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
4406         Update.
4407         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
4408         (elf_gnu_ifunc_resolve_by_got): Update.
4409         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
4410         * dwarf-index-write.c (save_gdb_index_command): Update.
4411         * cp-support.c (add_symbol_overload_list_qualified): Update.
4412         * breakpoint.c (create_overlay_event_breakpoint)
4413         (create_longjmp_master_breakpoint)
4414         (create_std_terminate_master_breakpoint)
4415         (create_exception_master_breakpoint): Update.
4416         * blockframe.c (find_pc_partial_function): Update.
4417         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
4418         (ada_collect_symbol_completion_matches)
4419         (ada_add_global_exceptions): Update.
4420
4421 2019-01-17  Tom Tromey  <tom@tromey.com>
4422
4423         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
4424         declare VEC.
4425         (solib_target_parse_libraries): Change return type.
4426         (library_list_start_segment, library_list_start_section)
4427         (library_list_end_library, library_list_start_library); Update.
4428         (solib_target_free_library_list): Remove.
4429         (solib_target_parse_libraries): Remove cleanup.  Change return
4430         type.
4431         (solib_target_current_sos): Update.
4432
4433 2019-01-17  Tom Tromey  <tromey@bapiya>
4434
4435         * valprint.c: Replace "the the" with "the".
4436         * symtab.c: Replace "the the" with "the".
4437         * solib.c: Replace "the the" with "the".
4438         * solib-dsbt.c: Replace "the the" with "the".
4439         * linespec.c: Replace "the the" with "the".
4440         * dwarf2loc.h: Replace "the the" with "the".
4441         * amd64-windows-tdep.c: Replace "the the" with "the".
4442         * aarch64-tdep.c: Replace "the the" with "the".
4443
4444 2019-01-16  Keith Seitz  <keiths@redhat.com>
4445
4446         PR gdb/23773
4447         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
4448         <builder>: Rename to ..
4449         <m_builder>: ... this and make private.
4450         (dwarf2_cu::get_builder): New method.  Change all users of
4451         `builder' to use this method.
4452         (dwarf2_start_symtab): Move to ...
4453         (dwarf2_cu::start_symtab): ... here.  Update all callers
4454         (setup_type_unit_groups): Move to ...
4455         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
4456         callers.
4457         (dwarf2_cu::reset_builder): New method.
4458         (process_full_compunit, process_full_type_unit): Use
4459         dwarf2_cu::reset_builder.
4460         (follow_die_offset): Record the ancestor CU if it is different
4461         from the followed DIE's CU.
4462         (follow_die_sig_1): Likewise.
4463
4464 2019-01-15  Tom Tromey  <tom@tromey.com>
4465
4466         * remote.c (class remote_state) <buf>: Now a char_vector.
4467         <buf_size>: Remove.
4468         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
4469         parameter.
4470         (remote_target::getpkt_or_notif_sane_1)
4471         (remote_target::getpkt_sane)
4472         (remote_target::getpkt_or_notif_sane): Likewise.
4473         (class remote_target) <putpkt>: New overload.
4474         (remote_target::read_frame): Change type of "buf_p".  Remove
4475         sizeof_p parameter.
4476         (packet_ok): New overload.
4477         (packet_check_result): New overload.
4478         Update all uses.
4479
4480 2019-01-14  Tom Tromey  <tom@tromey.com>
4481
4482         * remote-notif.c (handle_notification, remote_notif_ack)
4483         (remote_notif_parse): Make "buf" const.
4484         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
4485         const.
4486         (remote_notif_parse, remote_notif_ack, handle_notification):
4487         Likewise.
4488         * remote.c (remote_notif_stop_parse): Make "buf" const.
4489         (remote_target::remote_parse_stop_reply): Make "buf" const.
4490         (remote_notif_stop_ack): Make "buf" const.
4491
4492 2019-01-14  Tom Tromey  <tom@tromey.com>
4493
4494         * remote.c (remote_console_output): Make parameter const.
4495
4496 2019-01-14  Tom Tromey  <tom@tromey.com>
4497
4498         * target-debug.h (target_debug_print_signals): Constify.
4499         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
4500         * procfs.c (procfs_target::pass_signals): Update.
4501         * linux-nat.c (linux_nat_target::pass_signals): Update.
4502         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
4503         * target-delegates.c: Rebuild.
4504         * remote.c (remote_target::program_signals): Update.
4505         (remote_target::pass_signals): Update.
4506         * target.c (target_pass_signals): Constify argument.
4507         (target_program_signals): Likewise.
4508         * target.h (struct target_ops) <pass_signals, program_signals>:
4509         Constify argument.
4510         (target_pass_signals, target_program_signals): Constify argument.
4511
4512 2019-01-14  Tom Tromey  <tom@tromey.com>
4513
4514         PR tui/28819:
4515         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
4516
4517 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
4518
4519         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
4520         field.
4521         * rs6000-tdep.c: Include reggroups.h.
4522         (IS_V_ALIAS_PSEUDOREG): Define.
4523         (rs6000_register_name): Return names for the "vX" aliases.
4524         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
4525         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
4526         aliases.  Call default_register_reggroup_p for all other
4527         pseudo-registers.
4528         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
4529         New functions.
4530         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
4531         Handle "vX" aliases.
4532         (v_alias_pseudo_register_collect): New function.
4533         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
4534         (rs6000_gdbarch_init): Initialize "vX" aliases as
4535         pseudo-registers.  Restore registration of
4536         rs6000_pseudo_register_reggroup_p with
4537         set_tdesc_pseudo_register_reggroup_p.
4538
4539 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
4540
4541         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
4542         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
4543         set_gdbarch_num_pseudo_regs.
4544
4545 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4546
4547         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
4548         Remove arg prefixname, add do_set and do_show.
4549         Add member functions set_list and show_list.
4550         * cli/cli-style.c (class cli_style_option): Update accordingly.
4551         (style_set_list): Move to file scope.
4552         (style_show_list): Likewise.
4553         (set_style): Call help_list.
4554         (show_style): Call cmd_show_list.
4555         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
4556         Update to use the new macro.
4557
4558 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
4559
4560         * ada-lang.c (_initialize_ada_language): Expand the help text
4561         for the "catch exception" command.
4562
4563 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4564
4565         * symtab.c (matching_obj_sections): Initialize obj,
4566         declare it closer to its usage.
4567
4568 2019-01-10  Tom Tromey  <tom@tromey.com>
4569
4570         * thread-iter.h (inf_threads_iterator): Use next_iterator.
4571         (basic_inf_threads_range): Remove.
4572         (inf_threads_range, inf_non_exited_threads_range)
4573         (safe_inf_threads_range): Use next_adapter.
4574
4575 2019-01-10  Keith Seitz  <keiths@redhat.com>
4576
4577         PR gdb/23712
4578         PR symtab/23010
4579         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
4580         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
4581
4582 2019-01-10  Keith Seitz  <keiths@redhat.com>
4583
4584         PR gdb/23712
4585         PR symtab/23010
4586         * dictionary.c (pending_to_vector): Remove.
4587         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4588         Remove _1 suffix, replacing functions of the same name.  Update
4589         all callers.
4590         (dict_create_hashed, dict_create_hashed_expandable)
4591         (dict_create_linear, dict_create_linear_expandable, dict_free)
4592         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
4593         Make functions static.
4594
4595 2019-01-10  Keith Seitz  <keiths@redhat.com>
4596
4597         PR gdb/23712
4598         PR symtab/23010
4599         * dictionary.h (struct dictionary): Replace declaration with
4600         multidictionary.
4601         (dict_create_hashed, dict_create_hashed_expandable)
4602         (dict_create_linear, dict_create_linear_expandable)
4603         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
4604         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
4605         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
4606         taking multidictionary argument.
4607         [ALL_DICT_SYMBOLS]: Update for multidictionary.
4608         * block.h (struct block) <dict>: Change to multidictionary
4609         and rename `multidict'.
4610         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
4611         symmisc.c: Update all dictionary references to multidictionary.
4612
4613 2019-01-10  Keith Seitz  <keiths@redhat.com>
4614
4615         PR gdb/23712
4616         PR symtab/23010
4617         * dictionary.c: Include unordered_map.
4618         (pending_to_vector): New function.
4619         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4620         Rewrite the non-"_1" functions to take vector instead
4621         of linked list.
4622         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
4623         "new" _1 versions of the same name.
4624         (multidictionary): Define.
4625         (std::hash<enum language): New definition.
4626         (collate_pending_symbols_by_language, mdict_create_hashed)
4627         (mdict_create_hashed_expandable, mdict_create_linear)
4628         (mdict_create_linear_expandable, mdict_free)
4629         (find_language_dictionary, create_new_language_dictionary)
4630         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
4631         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
4632         (mdict_size, mdict_empty): New functions.
4633         * dictionary.h (mdict_iterator): Define.
4634
4635 2019-01-10  Pedro Alves  <palves@redhat.com>
4636
4637         * breakpoint.c (read_uploaded_action)
4638         (create_tracepoint_from_upload): Adjust to use
4639         gdb::unique_xmalloc_ptr.
4640         * ctf.c (ctf_write_uploaded_tp):
4641         (SET_ARRAY_FIELD): Use emplace_back.
4642         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
4643         * tracefile-tfile.c (tfile_write_uploaded_tp):
4644         * tracepoint.c (parse_tracepoint_definition): Adjust to use
4645         gdb::unique_xmalloc_ptr.
4646         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
4647         at_string, cond_string, cmd_strings>: Replace char pointers
4648         with gdb::unique_xmalloc_ptr.
4649
4650 2019-01-10  Pedro Alves  <palves@redhat.com>
4651
4652         * solib-target.c (library_list_start_library): Don't xstrdup name.
4653
4654 2019-01-10  Pedro Alves  <palves@redhat.com>
4655
4656         * mdebugread.c (parse_partial_symbols): Use
4657         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
4658
4659 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4660
4661         * linux-fork.c (scoped_switch_fork_info)
4662         <~scoped_switch_fork_info>: Fix incorrect variable name.
4663
4664 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4665
4666         * linux-fork.c (scoped_switch_fork_info)
4667         <scoped_switch_fork_info>: Make explicit.
4668         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
4669
4670 2019-01-10  Tom Tromey  <tom@tromey.com>
4671
4672         * objfiles.h (objfile::reset_psymtabs): Update.
4673         * objfiles.c (objfile::objfile): Update.
4674         * psymtab.h (psymtab_storage::obstack): Update.
4675         (psymtab_storage::m_obstack): Use gdb::optional.
4676         (class psymtab_storage): Update comment.  Remove objfile
4677         parameter.
4678         * psymtab.c (psymtab_storage::psymtab_storage): Update.
4679
4680 2019-01-10  Tom Tromey  <tom@tromey.com>
4681
4682         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
4683         <free_psymtabs>: Now private.
4684         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
4685         (allocate_psymtab): Use new method.
4686
4687 2019-01-10  Tom Tromey  <tom@tromey.com>
4688
4689         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
4690         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
4691         * mdebugread.c (parse_partial_symbols): Use
4692         allocate_dependencies.
4693         * dwarf2read.c (dwarf2_create_include_psymtab): Use
4694         allocate_dependencies.
4695         (process_psymtab_comp_unit_reader)
4696         (build_type_psymtab_dependencies): Likewise.
4697         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
4698
4699 2019-01-10  Tom Tromey  <tom@tromey.com>
4700
4701         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
4702         PSYMBOL_SET_LANGUAGE.
4703         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
4704
4705 2019-01-10  Tom Tromey  <tom@tromey.com>
4706
4707         * psymtab.h (psymtab_storage::obstack): New method.
4708         <m_obstack>: Rename from obstack; now private.
4709         * psymtab.c (psymtab_storage): Update.
4710         * dwarf2read.c (create_addrmap_from_index)
4711         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
4712         Update.
4713
4714 2019-01-10  Tom Tromey  <tom@tromey.com>
4715
4716         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
4717         * objfiles.h (objfile::reset_psymtabs): New method.
4718
4719 2019-01-10  Tom Tromey  <tom@tromey.com>
4720
4721         * symmisc.c (print_symbol_bcache_statistics): Update.
4722         (print_objfile_statistics): Update.
4723         * symfile.c (reread_symbols): Update.
4724         * psymtab.h (class psymtab_storage): New.
4725         * psymtab.c (psymtab_storage): New constructor.
4726         (~psymtab_storage): New destructor.
4727         (require_partial_symbols): Update.
4728         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
4729         (find_pc_sect_psymtab, find_pc_sect_psymbol)
4730         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
4731         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
4732         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
4733         (start_psymtab_common, end_psymtab_common)
4734         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
4735         (allocate_psymtab): Update.
4736         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
4737         Update.
4738         (dump_psymtab_addrmap, maintenance_print_psymbols)
4739         (maintenance_check_psymtabs): Update.
4740         (class objfile_psymtabs): Move to objfiles.h.
4741         * psympriv.h (discard_psymtab): Now inline.
4742         (psymtab_discarder::psymtab_discarder): Update.
4743         (psymtab_discarder::~psymtab_discarder): Update.
4744         (ALL_OBJFILE_PSYMTABS): Rewrite.
4745         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
4746         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
4747         Remove fields.
4748         <partial_symtabs>: New field.
4749         (class objfile_psymtabs): Move from psymtab.h.  Update.
4750         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
4751         psymbol_cache.
4752         (objfile::~objfile): Don't destroy psymbol_cache.
4753         * mdebugread.c (parse_partial_symbols): Update.
4754         * dwarf2read.c (create_addrmap_from_index)
4755         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
4756         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
4757         (add_partial_subprogram, dwarf2_ranges_read): Update.
4758         * dwarf-index-write.c (write_address_map)
4759         (write_one_signatured_type, recursively_write_psymbols)
4760         (class debug_names, class debug_names, write_psymtabs_to_index):
4761         Update.
4762
4763 2019-01-10  Tom Tromey  <tom@tromey.com>
4764
4765         * symtab.h (SYMBOL_SET_NAMES): Update.
4766         (symbol_set_names): Update.
4767         (MSYMBOL_SET_NAMES): Update.
4768         * symtab.c (symbol_set_names): Change argument to be an
4769         objfile_per_bfd_storage.
4770         * psymtab.c (add_psymbol_to_bcache): Update.
4771         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
4772
4773 2019-01-10  Tom Tromey  <tom@tromey.com>
4774
4775         * symtab.c (create_demangled_names_hash): Change argument to be an
4776         objfile_per_bfd_storage.
4777         (symbol_set_names): Update.
4778
4779 2019-01-10  Tom Tromey  <tom@tromey.com>
4780
4781         * xcoffread.c (xcoff_initial_scan): Unconditionally call
4782         init_psymbol_list.
4783         * psymtab.c (init_psymbol_list): Do nothing if already called.
4784         * psympriv.h (init_psymbol_list): Add comment.
4785         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
4786         init_psymbol_list.
4787         * dbxread.c (dbx_symfile_read): Unconditionally call
4788         init_psymbol_list.
4789
4790 2019-01-10  Tom Tromey  <tom@tromey.com>
4791
4792         * xcoffread.c (scan_xcoff_symtab): Update.
4793         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
4794         "where".
4795         * mdebugread.c (parse_partial_symbols)
4796         (handle_psymbol_enumerators): Update.
4797         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
4798         * dbxread.c (read_dbx_symtab): Update.
4799         * psympriv.h (psymbol_placement): New enum.
4800         (add_psymbol_to_list): Update.
4801
4802 2019-01-10  Tom Tromey  <tom@tromey.com>
4803
4804         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
4805         static_psymbols parameters.
4806         (scan_xcoff_symtab): Update.
4807         * psymtab.c (start_psymtab_common): Remove global_psymbols and
4808         static_psymbols parameters.
4809         * psympriv.h (start_psymtab_common): Update.
4810         * mdebugread.c (parse_partial_symbols): Update.
4811         * dwarf2read.c (create_partial_symtab): Update.
4812         * dbxread.c (read_dbx_symtab): Update.
4813         (start_psymtab): Remove global_psymbols and static_psymbols
4814         parameters.
4815
4816 2019-01-10  Tom Tromey  <tom@tromey.com>
4817
4818         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
4819         * psymtab.c (allocate_psymtab): Add comment.
4820         * psympriv.h (allocate_psymtab): Add comment.
4821         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
4822         initializations.
4823         * dbxread.c (dbx_end_psymtab): Remove some initializations.
4824
4825 2019-01-10  Tom Tromey  <tom@tromey.com>
4826
4827         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
4828         Don't declare.
4829         * mipsread.c: Include mdebugread.h.
4830         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
4831         Declare.
4832         * elfread.c: Include mdebugread.h.
4833
4834 2019-01-09  Tom Tromey  <tom@tromey.com>
4835
4836         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
4837         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
4838         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
4839         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
4840         (psym_lookup_symbol, psym_find_last_source_symtab)
4841         (psym_forget_cached_source_info, psym_print_stats)
4842         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
4843         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
4844         (psym_map_matching_symbols, psym_expand_symtabs_matching)
4845         (psym_find_compunit_symtab_by_address)
4846         (maintenance_print_psymbols, maintenance_info_psymtabs)
4847         (maintenance_check_psymtabs): Use ranged for.
4848         * psymtab.h (class objfile_psymtabs): New.
4849         (require_partial_symbols): Return objfile_psymtabs.
4850         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
4851
4852 2019-01-09  Tom Tromey  <tom@tromey.com>
4853
4854         * symfile.c (overlay_invalidate_all, find_pc_overlay)
4855         (find_pc_mapped_section, list_overlays_command)
4856         (map_overlay_command, unmap_overlay_command)
4857         (simple_overlay_update): Use all_objfiles.
4858         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
4859         * printcmd.c (info_symbol_command): Use all_objfiles.
4860         * objfiles.h (ALL_OBJSECTIONS): Remove.
4861         * maint.c (maintenance_translate_address): Use all_objfiles.
4862         * gcore.c (gcore_create_callback): Use all_objfiles.
4863         (objfile_find_memory_regions): Likewise.
4864
4865 2019-01-09  Tom Tromey  <tom@tromey.com>
4866
4867         * symtab.c (find_line_symtab, info_sources_command)
4868         (make_source_files_completion_list): Use objfile_compunits.
4869         * source.c (select_source_symtab): Use objfile_compunits.
4870         * objfiles.h (struct objfile): Update comment.
4871         (ALL_OBJFILES): Remove.
4872         (ALL_FILETABS): Remove.
4873         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
4874         objfile_compunits.
4875
4876 2019-01-09  Tom Tromey  <tom@tromey.com>
4877
4878         * symmisc.c (print_objfile_statistics, dump_objfile)
4879         (maintenance_print_symbols): Use compunit_filetabs.
4880         * source.c (forget_cached_source_info_for_objfile): Use
4881         compunit_filetabs.
4882         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
4883         (ALL_FILETABS): Use compunit_filetabs.
4884         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
4885         * coffread.c (coff_symtab_read): Use compunit_filetabs.
4886
4887 2019-01-09  Tom Tromey  <tom@tromey.com>
4888
4889         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
4890         (compunit_filetabs): New.
4891         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
4892         compunit_filetabs.
4893         (info_sources_command, make_source_files_completion_list): Remove
4894         declaration.
4895         * symmisc.c (print_objfile_statistics, dump_objfile)
4896         (maintenance_print_symbols): Remove declaration.
4897         (maintenance_info_symtabs): Use compunit_filetabs.
4898         (maintenance_info_line_tables): Likewise.
4899         * source.c (select_source_symtab): Change local variable name.
4900         (forget_cached_source_info_for_objfile): Remove declaration.
4901         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
4902         * objfiles.c (objfile_relocate1): Remove declaration.
4903         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
4904         declaration.
4905         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
4906         * coffread.c (coff_symtab_read): Remove declaration.
4907         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
4908         compunit_filetabs.
4909
4910 2019-01-09  Tom Tromey  <tom@tromey.com>
4911
4912         * symtab.c (lookup_objfile_from_block)
4913         (find_pc_sect_compunit_symtab, search_symbols)
4914         (default_collect_symbol_completion_matches_break_on): Use
4915         objfile_compunits.
4916         * objfiles.h (ALL_COMPUNITS): Remove.
4917         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
4918         * cp-support.c (add_symbol_overload_list_qualified): Use
4919         objfile_compunits.
4920         * ada-lang.c (ada_collect_symbol_completion_matches)
4921         (ada_add_global_exceptions): Use objfile_compunits.
4922
4923 2019-01-09  Tom Tromey  <tom@tromey.com>
4924
4925         * source.c (select_source_symtab)
4926         (forget_cached_source_info_for_objfile): Remove declaration.
4927         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
4928         declaration.
4929         * maint.c (count_symtabs_and_blocks): Remove declaration.
4930         * cp-support.c (add_symbol_overload_list_qualified): Remove
4931         declaration.
4932         * coffread.c (coff_symtab_read): Remove declaration.
4933         * symtab.c (lookup_symbol_in_objfile_symtabs)
4934         (basic_lookup_transparent_type_1): Use objfile_compunits.
4935         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
4936         (info_sources_command, search_symbols)
4937         (default_collect_symbol_completion_matches_break_on)
4938         (make_source_files_completion_list): Remove declaration.
4939         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
4940         (ada_collect_symbol_completion_matches)
4941         (ada_add_global_exceptions): Remove declaration.
4942         * linespec.c (iterate_over_all_matching_symtabs): Use
4943         objfile_compunits.
4944         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
4945         (class objfile_compunits): New.
4946         (ALL_COMPUNITS): Use objfile_compunits.
4947         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
4948         (maintenance_check_symtabs, maintenance_info_line_tables): Use
4949         objfile_compunits.
4950         * objfiles.c (objfile_relocate1): Use objfile_compunits.
4951
4952 2019-01-09  Tom Tromey  <tom@tromey.com>
4953
4954         * symtab.c (search_symbols)
4955         (default_collect_symbol_completion_matches_break_on): Use
4956         objfile_msymbols.
4957         * ada-lang.c (ada_lookup_simple_minsym)
4958         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
4959         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
4960         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
4961         objfile_msymbols.
4962         * coffread.c (coff_symfile_read): Use objfile_msymbols.
4963         * symmisc.c (dump_msymbols): Use objfile_msymbols.
4964         * objc-lang.c (find_methods): Use objfile_msymbols.
4965         (info_selectors_command, info_classes_command): Likewise.
4966         * stabsread.c (scan_file_globals): Use objfile_msymbols.
4967         * objfiles.h (class objfile_msymbols): New.
4968         (ALL_OBJFILE_MSYMBOLS): Remove.
4969         (ALL_MSYMBOLS): Remove.
4970
4971 2019-01-09  Tom Tromey  <tom@tromey.com>
4972
4973         * common/next-iterator.h (next_adapter): Add Iterator template
4974         parameter.
4975         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
4976         (class all_objfiles_safe): New.
4977         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
4978         * objfiles.c (put_objfile_before): Update comment.
4979         (add_separate_debug_objfile): Likewise.
4980         (free_all_objfiles): Use all_objfiles_safe.
4981         (objfile_purge_solibs): Likewise.
4982
4983 2019-01-09  Tom Tromey  <tom@tromey.com>
4984
4985         * symtab.c (iterate_over_symtabs, matching_obj_sections)
4986         (expand_symtab_containing_pc, lookup_static_symbol)
4987         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
4988         (find_symbol_at_address, find_line_symtab, find_main_name): Use
4989         all_objfiles.
4990         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
4991         * breakpoint.c (create_overlay_event_breakpoint)
4992         (create_longjmp_master_breakpoint)
4993         (create_std_terminate_master_breakpoint)
4994         (create_exception_master_breakpoint): Use all_objfiles.
4995         * linux-thread-db.c (try_thread_db_load_from_pdir)
4996         (has_libpthread): Use all_objfiles.
4997         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
4998         * linespec.c (iterate_over_all_matching_symtabs)
4999         (search_minsyms_for_name): Use all_objfiles.
5000         * maint.c (maintenance_info_sections): Use all_objfiles.
5001         * main.c (captured_main_1): Use all_objfiles.
5002         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
5003         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
5004         * guile/scm-pretty-print.c
5005         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
5006         * solib-spu.c (append_ocl_sos): Use all_objfiles.
5007         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
5008         (maintenance_print_msymbols): Use all_objfiles.
5009         * source.c (select_source_symtab): Use all_objfiles.
5010         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
5011         * symfile.c (remove_symbol_file_command)
5012         (expand_symtabs_matching, map_symbol_filenames): Use
5013         all_objfiles.
5014         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
5015         all_objfiles.
5016         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
5017         * objc-lang.c (find_methods): Use all_objfiles.
5018         * objfiles.c (have_partial_symbols, have_full_symbols)
5019         (have_minimal_symbols, qsort_cmp)
5020         (default_iterate_over_objfiles_in_search_order): Use
5021         all_objfiles.
5022         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
5023         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
5024         (maintenance_check_psymtabs): Use all_objfiles.
5025         (ALL_PSYMTABS): Remove.
5026         * compile/compile-object-run.c (do_module_cleanup): Use
5027         all_objfiles.
5028         * blockframe.c (find_pc_partial_function): Use all_objfiles.
5029         * cp-support.c (add_symbol_overload_list_qualified): Use
5030         all_objfiles.
5031         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5032         Use all_objfiles.
5033         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
5034         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
5035         all_objfiles.
5036         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5037         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
5038         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5039         Uses all_objfiles.
5040         * solib.c (solib_read_symbols): Use all_objfiles
5041
5042 2019-01-09  Tom Tromey  <tom@tromey.com>
5043
5044         * probe.c (parse_probes_in_pspace): Use all_objfiles.
5045         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
5046         all_objfiles.
5047         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
5048         * symmisc.c (print_symbol_bcache_statistics)
5049         (print_objfile_statistics, maintenance_print_objfiles)
5050         (maintenance_info_symtabs, maintenance_check_symtabs)
5051         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
5052         all_objfiles.
5053         * source.c (forget_cached_source_info): Use all_objfiles.
5054         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
5055         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5056         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
5057         * objfiles.c (update_section_map): Use all_objfiles.
5058         (shared_objfile_contains_address_p): Likewise.
5059         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
5060         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
5061
5062 2019-01-09  Tom Tromey  <tom@tromey.com>
5063
5064         * common/next-iterator.h: New file.
5065         * objfiles.h (class all_objfiles): New.
5066         (struct objfile_iterator): New.
5067
5068 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5069
5070         * NEWS: Move the description of the changed "frame", "select-frame",
5071          and "info frame" commands to the Changed commands section.
5072
5073 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
5074
5075         * gdbtypes.c (check_stub_method_group): Remove handling of old
5076         mangling schemes.
5077         * linespec.c (find_methods): Likewise.
5078         * stabsread.c (read_member_functions): Likewise.
5079         * valops.c (search_struct_method): Likewise.
5080         (value_struct_elt_for_reference): Likewise.
5081         * NEWS: Mention this change.
5082
5083 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5084
5085         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
5086         print_source_lines.
5087         * source.c (print_source_lines_base): Update line number check.
5088         (print_source_lines): New function.
5089         (source_lines_range::source_lines_range): New function.
5090         * source.h (class source_lines_range): New class.
5091         (print_source_lines): New declaration.
5092
5093 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5094
5095         * linespec.c (linespec_state_destructor): Free self->canonical_names.
5096
5097 2019-01-08  Tom Tromey  <tom@tromey.com>
5098             Simon Marchi  <simon.marchi@ericsson.com>
5099
5100         PR gdb/24060
5101         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
5102         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
5103         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5104         * f-exp.y (DOLLAR_VARIABLE): Likewise.
5105         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
5106         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5107
5108 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5109
5110         * source.c (select_source_symtab): Move header comment to
5111         declaration in source.h.
5112         (forget_cached_source_info_for_objfile): Likewise.
5113         (forget_cached_source_info): Likewise.
5114         (identify_source_line): Likewise.
5115         * source.h (identify_source_line): Move declaration from symtab.h
5116         and add comment from source.c
5117         (print_source_lines): Likewise.
5118         (forget_cached_source_info_for_objfile): Likewise.
5119         (forget_cached_source_info): Likewise.
5120         (select_source_symtab): Likewise.
5121         (enum print_source_lines_flag): Move definition from symtab.h.
5122         * symtab.h (identify_source_line): Move declaration to source.h.
5123         (print_source_lines): Likewise.
5124         (forget_cached_source_info_for_objfile): Likewise.
5125         (forget_cached_source_info): Likewise.
5126         (select_source_symtab): Likewise.
5127         (enum print_source_lines_flag): Move definition to source.h.
5128         * tui/tui-hooks.c: Add 'source.h' include.
5129
5130 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5131
5132         * source.c (print_source_lines_base): Handle requests to print
5133         reverse line number sequences, and guard against empty lines
5134         string.
5135
5136 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5137
5138         * source.c (print_source_lines_base): Fix skip of '\r' if next
5139         character is '\n'.
5140
5141 2019-01-06  Tom Tromey  <tom@tromey.com>
5142
5143         * c-exp.y (struct c_parse_state) <macro_original_text,
5144         expansion_obstack>: New member.
5145         (macro_original_text, expansion_obstack): Remove globals.
5146         (scan_macro_expansion, scanning_macro_expansion)
5147         (finished_macro_expansion): Update.
5148         (scan_macro_cleanup): Remove.
5149         (yylex, c_parse): Update.
5150
5151 2019-01-06  Tom Tromey  <tom@tromey.com>
5152
5153         * c-exp.y (struct c_parse_state) <strings>: New member.
5154         (operator_stoken): Update.
5155
5156 2019-01-06  Tom Tromey  <tom@tromey.com>
5157
5158         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
5159         (union type_stack_elt) <typelist_val>: Now a pointer to
5160         std::vector.
5161         (type_stack_cleanup): Don't declare.
5162         (push_typelist): Update.
5163         * parse.c (pop_typelist): Return a std::vector.
5164         (push_typelist): Take a std::vector.
5165         (follow_types): Update.  Do not free args.
5166         (type_stack_cleanup): Remove.
5167         * c-exp.y (struct c_parse_state): New.
5168         (cpstate): New global.
5169         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
5170         (nonempty_typelist): Update.
5171         (func_mod): Create a new vector.
5172         (c_parse): Create a c_parse_state.
5173         (check_parameter_typelist): Do not delete params.
5174         (function_method): Update.  Do not delete type_list.
5175
5176 2019-01-06  Tom Tromey  <tom@tromey.com>
5177
5178         PR gdb/28155:
5179         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
5180         check_typedef.
5181         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
5182         (print_return_value): Likewise.
5183
5184 2019-01-05  Tom Tromey  <tom@tromey.com>
5185
5186         * contrib/cleanup_check.py: Remove.
5187         * contrib/gcc-with-excheck: Remove.
5188         * contrib/exsummary.py: Remove.
5189         * contrib/excheck.py: Remove.
5190
5191 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
5192
5193         * thread.c (delete_thread_1): Add gdb_assert that THR is not
5194         NULL. Initialize tpprev to NULL instead of assigning it
5195         to NULL on the next statement.
5196         * windows-nat.c (windows_delete_thread): Remove check for
5197         main_thread_id before printing thread exit notifications.
5198         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
5199         Remove thread ID check against main_thread_id.
5200         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
5201         windows_delete_thread.
5202         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
5203
5204 2019-01-04  Tom Tromey  <tom@tromey.com>
5205
5206         * compile/compile.c (_initialize_compile): Use upper case for
5207         metasyntactic variables.
5208         * symmisc.c (_initialize_symmisc): Use upper case for
5209         metasyntactic variables.
5210         * psymtab.c (_initialize_psymtab): Use upper case for
5211         metasyntactic variables.
5212         * demangle.c (demangle_command): Use upper case for metasyntactic
5213         variables.
5214         (_initialize_demangler): Likewise.
5215         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
5216         variables.
5217
5218 2019-01-03  Tom Tromey  <tom@tromey.com>
5219
5220         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
5221
5222 2019-01-03  Tom Tromey  <tom@tromey.com>
5223
5224         * python/py-symtab.c (salpy_str): Update.
5225         (struct salpy_sal_object) <symtab>: Now a PyObject.
5226         (salpy_dealloc): Update.
5227         (del_objfile_sal): Use gdbpy_ref.
5228
5229 2019-01-03  Tom Tromey  <tom@tromey.com>
5230
5231         * python/py-type.c (convert_field): Use new_reference.  Return
5232         gdbpy_ref.
5233         (make_fielditem): Return gdbpy_ref.
5234         (typy_fields): Update.
5235         (typy_getitem): Update.
5236         (field_name): Return gdbpy_ref.  Use new_reference.
5237         (typy_iterator_iternext): Update.
5238
5239 2019-01-03  Tom Tromey  <tom@tromey.com>
5240
5241         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
5242
5243 2019-01-03  Tom Tromey  <tom@tromey.com>
5244
5245         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
5246         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
5247         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
5248         (pspy_set_frame_filters, pspy_set_frame_unwinders)
5249         (pspy_set_type_printers): Likewise.
5250         * python/py-function.c (fnpy_init): Use gdbpy_ref.
5251         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
5252         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
5253         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
5254         (objfpy_set_type_printers): Likewise.
5255
5256 2019-01-03  Tom Tromey  <tom@tromey.com>
5257
5258         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
5259         (gdbpy_print_stack): Use gdbpy_err_fetch.
5260         * python/python-internal.h (class gdbpy_err_fetch): New class.
5261         (class gdbpy_enter) <m_error_type, m_error_value,
5262         m_error_traceback>: Remove.
5263         <m_error>: New member.
5264         (gdbpy_exception_to_string): Don't declare.
5265         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
5266         * python/py-value.c (convert_value_from_python): Use
5267         gdbpy_err_fetch.
5268         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
5269         gdbpy_exception_to_string.
5270         (gdbpy_handle_exception): Use gdbpy_err_fetch.
5271         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
5272         gdbpy_err_fetch.
5273
5274 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5275
5276         * linux-nat.c (delete_lwp_cleanup): Delete.
5277         (struct lwp_deleter): New struct.
5278         (lwp_info_up): New typedef.
5279         (linux_nat_target::follow_fork): Delete cleanup, and make use of
5280         lwp_info_up.
5281
5282 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5283
5284         * linux-fork.c (class scoped_switch_fork_info): New class.
5285         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
5286
5287 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5288
5289         * valops.c (find_overload_match): Remove use of null_cleanup, and
5290         calls to do_cleanups.
5291
5292 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5293
5294         * compile/compile-cplus-types.c
5295         (compile_cplus_instance::decl_name): Handle changes to
5296         cp_func_name.
5297         * cp-support.c (cp_func_name): Update header comment, update
5298         return type.
5299         * cp-support.h (cp_func_name): Update return type in declaration.
5300         * valops.c (find_overload_match): Move temp_func local to top
5301         level of function and change its type.  Use temp_func to hold and
5302         delete temporary string obtained from cp_func_name.
5303
5304 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5305
5306         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
5307         gdb::char_vector, remove cleanup, and update uses of `msg`.
5308
5309 2019-01-03  Jim Wilson  <jimw@sifive.com>
5310
5311         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
5312
5313 2019-01-02  Tom Tromey  <tom@tromey.com>
5314
5315         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
5316         (tdesc_parse_xml): Remove cleanups.
5317         * target-descriptions.h (make_cleanup_free_target_description):
5318         Don't declare.
5319         (target_desc_deleter): New struct.
5320         (target_desc_up): New typedef.
5321         * target-descriptions.c (target_desc_deleter::operator()): Rename
5322         from free_target_description.
5323         (make_cleanup_free_target_description): Remove.
5324
5325 2019-01-02  Tom Tromey  <tom@tromey.com>
5326
5327         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
5328         constructor, destructor.
5329         (linespec_parser): Remove typedef.
5330         (~linespec_parser): Rename from linespec_parser_delete.
5331         (linespec_lex_to_end, linespec_complete_label)
5332         (linespec_complete): Update.
5333         (decode_line_full): Remove cleanups.
5334         (decode_line_1): Update.
5335
5336 2019-01-02  Tom Tromey  <tom@tromey.com>
5337
5338         * python/python-internal.h (inferior_to_inferior_object): Change
5339         return type.
5340         * python/py-exitedevent.c (create_exited_event_object): Update.
5341         * python/py-inferior.c (inferior_to_inferior_object): Return
5342         gdbpy_ref.
5343         (python_new_inferior, python_inferior_deleted)
5344         (thread_to_thread_object, delete_thread_object)
5345         (build_inferior_list, gdbpy_selected_inferior): Update.
5346         * python/py-infthread.c (create_thread_object): Update.  Also fail
5347         if inferior_to_inferior_object fails.
5348
5349 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
5350
5351         * inferior.h (class inferior) <displaced_step_state>: New field.
5352         * infrun.h (struct displaced_step_state): Move here from
5353         infrun.c.  Initialize fields, add constructor.
5354         <inf>: Remove field.
5355         <reset>: New method.
5356         * infrun.c (struct displaced_step_inferior_state): Move to
5357         infrun.h.
5358         (displaced_step_inferior_states): Remove.
5359         (get_displaced_stepping_state): Adust.
5360         (displaced_step_in_progress_any_inferior): Adjust.
5361         (displaced_step_in_progress_thread): Adjust.
5362         (displaced_step_in_progress): Adjust.
5363         (add_displaced_stepping_state): Remove.
5364         (get_displaced_step_closure_by_addr): Adjust.
5365         (remove_displaced_stepping_state): Remove.
5366         (infrun_inferior_exit): Call displaced_step_state.reset.
5367         (use_displaced_stepping): Don't check for NULL.
5368         (displaced_step_prepare_throw): Call
5369         get_displaced_stepping_state.
5370         (displaced_step_fixup): Don't check for NULL.
5371         (prepare_for_detach): Don't check for NULL.
5372
5373 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5374
5375         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
5376          in case of call that did not complete.
5377
5378 2019-01-02  Andrey Utkin  <autkin@undo.io>
5379
5380         * symfile.c (find_separate_debug_file): Fix search of debug files for
5381         remote debuggee.
5382
5383 2019-01-02  Tom Tromey  <tom@tromey.com>
5384
5385         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
5386         indentation.
5387         * python/py-frame.c (frapy_older): Remove cast.
5388         (frapy_newer): Likewise.
5389         * python/py-breakpoint.c (local_setattro): Remove cast.
5390         * python/py-arch.c (archpy_name): Remove local variable.
5391         * python/py-type.c (gdbpy_lookup_type): Remove cast.
5392
5393 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
5394
5395         * unittests/basic_string_view/element_access/char/empty.cc:
5396         Fix year range in copyright header.
5397
5398 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5399
5400         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
5401         Delete.
5402         <operator==>: Update with for removed field.
5403         <hash>: Likewise.
5404         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
5405         <isa_features>: ...this.
5406         <abi_features>: New field.
5407         (riscv_isa_flen): Update comment.
5408         (riscv_abi_xlen): New declaration.
5409         (riscv_abi_flen): New declaration.
5410         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
5411         isa_features.
5412         (riscv_abi_xlen): New function.
5413         (riscv_isa_flen): Update to get answer from isa_features.
5414         (riscv_abi_flen): New function.
5415         (riscv_has_fp_abi): Update to get answer from abi_features.
5416         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
5417         xlen and flen.
5418         (riscv_call_info) <xlen, flen>: Update comment.
5419         (riscv_call_arg_struct): Remove invalid assertions
5420         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
5421         is removed.
5422         (riscv_gdbarch_init): Gather isa features and abi features
5423         separately, ensure both match on the gdbarch when reusing an old
5424         gdbarch.  Relax an error check to allow 32-bit abi float to run on
5425         a target with 64-bit float hardware.
5426
5427 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5428
5429         * source.c (search_command_helper): Stop reverse search
5430         when line 1 has been searched.
5431
5432 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5433
5434         * record-full.c (record_full_base_target::close): Rewrite
5435         record_full_core_buf_list free logic.
5436
5437 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5438
5439         * break-catch-syscall.c (print_one_catch_syscall): xfree
5440         the last text.
5441
5442 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5443
5444         * top.c (print_gdb_version): Update Copyright year in version
5445         message.
5446
5447 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5448
5449         Update copyright year range in all GDB files.
5450
5451 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
5452
5453         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
5454
5455 For older changes see ChangeLog-2018.
5456 \f
5457 Local Variables:
5458 mode: change-log
5459 left-margin: 8
5460 fill-column: 74
5461 version-control: never
5462 coding: utf-8
5463 End:
5464