gdb/ChangeLog

   1 2019-01-25  Tom Tromey  <tom@tromey.com>
   2
   3         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
   4
   5 2019-01-25  Tom Tromey  <tom@tromey.com>
   6
   7         * xtensa-linux-nat.c: Fix common/ includes.
   8         * xml-support.h: Fix common/ includes.
   9         * xml-support.c: Fix common/ includes.
  10         * x86-linux-nat.c: Fix common/ includes.
  11         * windows-nat.c: Fix common/ includes.
  12         * varobj.h: Fix common/ includes.
  13         * varobj.c: Fix common/ includes.
  14         * value.c: Fix common/ includes.
  15         * valops.c: Fix common/ includes.
  16         * utils.c: Fix common/ includes.
  17         * unittests/xml-utils-selftests.c: Fix common/ includes.
  18         * unittests/utils-selftests.c: Fix common/ includes.
  19         * unittests/unpack-selftests.c: Fix common/ includes.
  20         * unittests/tracepoint-selftests.c: Fix common/ includes.
  21         * unittests/style-selftests.c: Fix common/ includes.
  22         * unittests/string_view-selftests.c: Fix common/ includes.
  23         * unittests/scoped_restore-selftests.c: Fix common/ includes.
  24         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
  25         * unittests/scoped_fd-selftests.c: Fix common/ includes.
  26         * unittests/rsp-low-selftests.c: Fix common/ includes.
  27         * unittests/parse-connection-spec-selftests.c: Fix common/
  28         includes.
  29         * unittests/optional-selftests.c: Fix common/ includes.
  30         * unittests/offset-type-selftests.c: Fix common/ includes.
  31         * unittests/observable-selftests.c: Fix common/ includes.
  32         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
  33         * unittests/memrange-selftests.c: Fix common/ includes.
  34         * unittests/memory-map-selftests.c: Fix common/ includes.
  35         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
  36         * unittests/function-view-selftests.c: Fix common/ includes.
  37         * unittests/environ-selftests.c: Fix common/ includes.
  38         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
  39         * unittests/common-utils-selftests.c: Fix common/ includes.
  40         * unittests/cli-utils-selftests.c: Fix common/ includes.
  41         * unittests/array-view-selftests.c: Fix common/ includes.
  42         * ui-file.c: Fix common/ includes.
  43         * tui/tui-io.c: Fix common/ includes.
  44         * tracepoint.h: Fix common/ includes.
  45         * tracepoint.c: Fix common/ includes.
  46         * tracefile-tfile.c: Fix common/ includes.
  47         * top.h: Fix common/ includes.
  48         * top.c: Fix common/ includes.
  49         * thread.c: Fix common/ includes.
  50         * target/waitstatus.h: Fix common/ includes.
  51         * target/waitstatus.c: Fix common/ includes.
  52         * target.h: Fix common/ includes.
  53         * target.c: Fix common/ includes.
  54         * target-memory.c: Fix common/ includes.
  55         * target-descriptions.c: Fix common/ includes.
  56         * symtab.h: Fix common/ includes.
  57         * symfile.c: Fix common/ includes.
  58         * stap-probe.c: Fix common/ includes.
  59         * spu-linux-nat.c: Fix common/ includes.
  60         * sparc-nat.c: Fix common/ includes.
  61         * source.c: Fix common/ includes.
  62         * solib.c: Fix common/ includes.
  63         * solib-target.c: Fix common/ includes.
  64         * ser-unix.c: Fix common/ includes.
  65         * ser-tcp.c: Fix common/ includes.
  66         * ser-pipe.c: Fix common/ includes.
  67         * ser-base.c: Fix common/ includes.
  68         * selftest-arch.c: Fix common/ includes.
  69         * s12z-tdep.c: Fix common/ includes.
  70         * rust-exp.y: Fix common/ includes.
  71         * rs6000-aix-tdep.c: Fix common/ includes.
  72         * riscv-tdep.c: Fix common/ includes.
  73         * remote.c: Fix common/ includes.
  74         * remote-notif.h: Fix common/ includes.
  75         * remote-fileio.h: Fix common/ includes.
  76         * remote-fileio.c: Fix common/ includes.
  77         * regcache.h: Fix common/ includes.
  78         * regcache.c: Fix common/ includes.
  79         * record-btrace.c: Fix common/ includes.
  80         * python/python.c: Fix common/ includes.
  81         * python/py-type.c: Fix common/ includes.
  82         * python/py-inferior.c: Fix common/ includes.
  83         * progspace.h: Fix common/ includes.
  84         * producer.c: Fix common/ includes.
  85         * procfs.c: Fix common/ includes.
  86         * proc-api.c: Fix common/ includes.
  87         * printcmd.c: Fix common/ includes.
  88         * ppc-linux-nat.c: Fix common/ includes.
  89         * parser-defs.h: Fix common/ includes.
  90         * osdata.c: Fix common/ includes.
  91         * obsd-nat.c: Fix common/ includes.
  92         * nat/x86-linux.c: Fix common/ includes.
  93         * nat/x86-linux-dregs.c: Fix common/ includes.
  94         * nat/x86-dregs.h: Fix common/ includes.
  95         * nat/x86-dregs.c: Fix common/ includes.
  96         * nat/ppc-linux.c: Fix common/ includes.
  97         * nat/mips-linux-watch.h: Fix common/ includes.
  98         * nat/mips-linux-watch.c: Fix common/ includes.
  99         * nat/linux-waitpid.c: Fix common/ includes.
 100         * nat/linux-ptrace.h: Fix common/ includes.
 101         * nat/linux-ptrace.c: Fix common/ includes.
 102         * nat/linux-procfs.c: Fix common/ includes.
 103         * nat/linux-personality.c: Fix common/ includes.
 104         * nat/linux-osdata.c: Fix common/ includes.
 105         * nat/linux-namespaces.c: Fix common/ includes.
 106         * nat/linux-btrace.h: Fix common/ includes.
 107         * nat/linux-btrace.c: Fix common/ includes.
 108         * nat/fork-inferior.c: Fix common/ includes.
 109         * nat/amd64-linux-siginfo.c: Fix common/ includes.
 110         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
 111         * nat/aarch64-linux.c: Fix common/ includes.
 112         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
 113         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
 114         * namespace.h: Fix common/ includes.
 115         * mips-linux-tdep.c: Fix common/ includes.
 116         * minsyms.c: Fix common/ includes.
 117         * mi/mi-parse.h: Fix common/ includes.
 118         * mi/mi-main.c: Fix common/ includes.
 119         * mi/mi-cmd-env.c: Fix common/ includes.
 120         * memrange.h: Fix common/ includes.
 121         * memattr.c: Fix common/ includes.
 122         * maint.h: Fix common/ includes.
 123         * maint.c: Fix common/ includes.
 124         * main.c: Fix common/ includes.
 125         * machoread.c: Fix common/ includes.
 126         * location.c: Fix common/ includes.
 127         * linux-thread-db.c: Fix common/ includes.
 128         * linux-nat.c: Fix common/ includes.
 129         * linux-fork.c: Fix common/ includes.
 130         * inline-frame.c: Fix common/ includes.
 131         * infrun.c: Fix common/ includes.
 132         * inflow.c: Fix common/ includes.
 133         * inferior.h: Fix common/ includes.
 134         * inferior.c: Fix common/ includes.
 135         * infcmd.c: Fix common/ includes.
 136         * inf-ptrace.c: Fix common/ includes.
 137         * inf-child.c: Fix common/ includes.
 138         * ia64-linux-nat.c: Fix common/ includes.
 139         * i387-tdep.c: Fix common/ includes.
 140         * i386-tdep.c: Fix common/ includes.
 141         * i386-linux-tdep.c: Fix common/ includes.
 142         * i386-linux-nat.c: Fix common/ includes.
 143         * i386-go32-tdep.c: Fix common/ includes.
 144         * i386-fbsd-tdep.c: Fix common/ includes.
 145         * i386-fbsd-nat.c: Fix common/ includes.
 146         * guile/scm-type.c: Fix common/ includes.
 147         * guile/guile.c: Fix common/ includes.
 148         * go32-nat.c: Fix common/ includes.
 149         * gnu-nat.c: Fix common/ includes.
 150         * gdbthread.h: Fix common/ includes.
 151         * gdbarch-selftests.c: Fix common/ includes.
 152         * gdb_usleep.c: Fix common/ includes.
 153         * gdb_select.h: Fix common/ includes.
 154         * gdb_bfd.c: Fix common/ includes.
 155         * gcore.c: Fix common/ includes.
 156         * fork-child.c: Fix common/ includes.
 157         * findvar.c: Fix common/ includes.
 158         * fbsd-nat.c: Fix common/ includes.
 159         * event-top.c: Fix common/ includes.
 160         * event-loop.c: Fix common/ includes.
 161         * dwarf2read.c: Fix common/ includes.
 162         * dwarf2loc.c: Fix common/ includes.
 163         * dwarf2-frame.c: Fix common/ includes.
 164         * dwarf-index-cache.c: Fix common/ includes.
 165         * dtrace-probe.c: Fix common/ includes.
 166         * disasm-selftests.c: Fix common/ includes.
 167         * defs.h: Fix common/ includes.
 168         * csky-tdep.c: Fix common/ includes.
 169         * cp-valprint.c: Fix common/ includes.
 170         * cp-support.h: Fix common/ includes.
 171         * cp-support.c: Fix common/ includes.
 172         * corelow.c: Fix common/ includes.
 173         * completer.h: Fix common/ includes.
 174         * completer.c: Fix common/ includes.
 175         * compile/compile.c: Fix common/ includes.
 176         * compile/compile-loc2c.c: Fix common/ includes.
 177         * compile/compile-cplus-types.c: Fix common/ includes.
 178         * compile/compile-cplus-symbols.c: Fix common/ includes.
 179         * command.h: Fix common/ includes.
 180         * cli/cli-dump.c: Fix common/ includes.
 181         * cli/cli-cmds.c: Fix common/ includes.
 182         * charset.c: Fix common/ includes.
 183         * build-id.c: Fix common/ includes.
 184         * btrace.h: Fix common/ includes.
 185         * btrace.c: Fix common/ includes.
 186         * breakpoint.h: Fix common/ includes.
 187         * breakpoint.c: Fix common/ includes.
 188         * ax.h:
 189         (enum agent_op): Fix common/ includes.
 190         * ax-general.c (struct aop_map): Fix common/ includes.
 191         * ax-gdb.c: Fix common/ includes.
 192         * auxv.c: Fix common/ includes.
 193         * auto-load.c: Fix common/ includes.
 194         * arm-tdep.c: Fix common/ includes.
 195         * arch/riscv.c: Fix common/ includes.
 196         * arch/ppc-linux-common.c: Fix common/ includes.
 197         * arch/i386.c: Fix common/ includes.
 198         * arch/arm.c: Fix common/ includes.
 199         * arch/arm-linux.c: Fix common/ includes.
 200         * arch/arm-get-next-pcs.c: Fix common/ includes.
 201         * arch/amd64.c: Fix common/ includes.
 202         * arch/aarch64.c: Fix common/ includes.
 203         * arch/aarch64-insn.c: Fix common/ includes.
 204         * arch-utils.c: Fix common/ includes.
 205         * amd64-windows-tdep.c: Fix common/ includes.
 206         * amd64-tdep.c: Fix common/ includes.
 207         * amd64-sol2-tdep.c: Fix common/ includes.
 208         * amd64-obsd-tdep.c: Fix common/ includes.
 209         * amd64-nbsd-tdep.c: Fix common/ includes.
 210         * amd64-linux-tdep.c: Fix common/ includes.
 211         * amd64-linux-nat.c: Fix common/ includes.
 212         * amd64-fbsd-tdep.c: Fix common/ includes.
 213         * amd64-fbsd-nat.c: Fix common/ includes.
 214         * amd64-dicos-tdep.c: Fix common/ includes.
 215         * amd64-darwin-tdep.c: Fix common/ includes.
 216         * agent.c: Fix common/ includes.
 217         * ada-lang.h: Fix common/ includes.
 218         * ada-lang.c: Fix common/ includes.
 219         * aarch64-tdep.c: Fix common/ includes.
 220
 221 2019-01-25  Tom Tromey  <tom@tromey.com>
 222
 223         * common/create-version.sh: Use common/version.h.
 224
 225 2019-01-24  Pedro Alves  <palves@redhat.com>
 226
 227         * infrun.c (signal_stop, signal_print, signal_program)
 228         (signal_catch, signal_pass): Now arrays instead of pointers.
 229         (update_signals_program_target, do_target_resume)
 230         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
 231         * linux-nat.c (linux_nat_target::pass_signals)
 232         (linux_nat_target::create_inferior, linux_nat_target::attach):
 233         Adjust.
 234         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
 235         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
 236         * procfs.c (procfs_target::pass_signals): Adjust.
 237         * record-full.c (record_full_target::resume): Adjust.
 238         * remote.c (remote_target::pass_signals)
 239         (remote_target::program_signals): Adjust.
 240         * target-debug.h (target_debug_print_signals): Now takes a
 241         gdb::array_view as parameter.  Adjust.
 242         * target.h (target_ops) <pass_signals, program_signals>: Replace
 243         pointer and length parameters with gdb::array_view.
 244         (target_pass_signals, target_program_signals): Likewise.
 245         * target-delegates.c: Regenerate.
 246
 247 2019-01-24  Pedro Alves  <palves@redhat.com>
 248
 249         * common/forward-scope-exit.h
 250         (forward_scope_exit::forward_scope_exit): Pass arguments to
 251         m_bind_function directly, instead of creating a std::bind and
 252         copying that.
 253
 254 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
 255
 256         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 257         for static members.
 258         (pass_in_v_vfp_candidate): Likewise.
 259
 260 2019-01-23  Tom Tromey  <tom@tromey.com>
 261             Pedro Alves  <palves@redhat.com>
 262
 263         * regcache.c (class regcache_invalidator): Remove.
 264         (regcache::raw_write): Use make_scope_exit.
 265
 266 2019-01-23  Tom Tromey  <tom@tromey.com>
 267
 268         * ui-out.h (class ui_out_emit_type): Update comment.
 269
 270 2019-01-23  Tom Tromey  <tom@tromey.com>
 271
 272         * infrun.c (fetch_inferior_event): Update comment.
 273
 274 2019-01-23  Tom Tromey  <tom@tromey.com>
 275             Pedro Alves  <palves@redhat.com>
 276
 277         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
 278         parameter.
 279         (fetch_inferior_event): Use SCOPE_EXIT.
 280
 281
 282 2019-01-23  Tom Tromey  <tom@tromey.com>
 283             Pedro Alves  <palves@redhat.com>
 284
 285         * infrun.c (disable_thread_events): Delete.
 286         (stop_all_threads): Use SCOPE_EXIT.
 287
 288 2019-01-23  Tom Tromey  <tom@tromey.com>
 289             Pedro Alves  <palves@redhat.com>
 290
 291         * symfile.c: Include forward-scope-exit.h.
 292         (clear_symtab_users_cleanup): Replace forward declaration with
 293         a FORWARD_SCOPE_EXIT.
 294         (syms_from_objfile_1): Use the forward_scope_exit and
 295         gdb::optional instead of cleanup_function.
 296         (reread_symbols): Use the forward_scope_exit instead of
 297         cleanup_function.
 298         (clear_symtab_users_cleanup): Remove function.
 299
 300 2019-01-23  Tom Tromey  <tom@tromey.com>
 301             Pedro Alves  <palves@redhat.com>
 302
 303         * linux-nat.c: Include scope-exit.h.
 304         (cleanup_target_stop): Remove.
 305         (linux_nat_target::static_tracepoint_markers_by_strid): Use
 306         SCOPE_EXIT.
 307
 308 2019-01-23  Tom Tromey  <tom@tromey.com>
 309             Pedro Alves  <palves@redhat.com>
 310
 311         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
 312         (call_function_by_hand_dummy): Use SCOPE_EXIT.
 313
 314 2019-01-23  Tom Tromey  <tom@tromey.com>
 315             Andrew Burgess  <andrew.burgess@embecosm.com>
 316             Pedro Alves  <palves@redhat.com>
 317
 318         * infrun.c (fetch_inferior_event): Use scope_exit.
 319         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
 320         * top.c (execute_command): Use scope_exit.
 321         * breakpoint.c (bpstat_do_actions): Use scope_exit.
 322         * utils.c (do_bpstat_clear_actions_cleanup)
 323         (make_bpstat_clear_actions_cleanup): Remove.
 324
 325 2019-01-23  Tom Tromey  <tom@tromey.com>
 326             Pedro Alves  <palves@redhat.com>
 327
 328         * infrun.c: Include "common/scope-exit.h"
 329         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
 330         (wait_for_inferior): Use SCOPE_EXIT.
 331         (fetch_inferior_event): Use scope_exit.
 332
 333 2019-01-23  Tom Tromey  <tom@tromey.com>
 334             Pedro Alves  <palves@redhat.com>
 335
 336         * breakpoint.c (create_breakpoint): Remove cleanup.
 337
 338 2019-01-23  Tom Tromey  <tom@tromey.com>
 339             Andrew Burgess  <andrew.burgess@embecosm.com>
 340             Pedro Alves  <palves@redhat.com>
 341
 342 2019-01-23  Pedro Alves  <palves@redhat.com>
 343
 344         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
 345
 346 2019-01-23  Pedro Alves  <palves@redhat.com>
 347             Andrew Burgess  <andrew.burgess@embecosm.com>
 348
 349         * gdbthread.h: Include "common/forward-scope-exit.h".
 350         (scoped_finish_thread_state): Redefine custom class in terms of
 351         forward_scope_exit.
 352
 353 2019-01-23  Pedro Alves  <palves@redhat.com>
 354             Andrew Burgess  <andrew.burgess@embecosm.com>
 355
 356         * common/forward-scope-exit.h: New file.
 357
 358 2019-01-23  Pedro Alves  <palves@redhat.com>
 359             Andrew Burgess  <andrew.burgess@embecosm.com>
 360             Tom Tromey  <tom@tromey.com>
 361
 362         * common/scope-exit.h: New file.
 363
 364 2019-01-23  Pedro Alves  <palves@redhat.com>
 365
 366         * common/preprocessor.h (ESC): Rename to ...
 367         (ESC_PARENS): ... this.
 368         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
 369         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
 370
 371 2019-01-23  Tom Tromey  <tom@tromey.com>
 372
 373         * language.h (class scoped_switch_to_sym_language_if_auto):
 374         Initialize m_lang in both cases.
 375
 376 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
 377
 378         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
 379         with XCNEW.
 380
 381 2019-01-22  Tom Tromey  <tom@tromey.com>
 382
 383         * corelow.c: Do not include sys/file.h.
 384
 385 2019-01-22  Tom Tromey  <tom@tromey.com>
 386
 387         * tui/tui-wingeneral.h: Include gdb_curses.h.
 388
 389 2019-01-22  Tom Tromey  <tom@tromey.com>
 390
 391         * source-cache.h (class source_cache) <get_source_lines,
 392         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
 393
 394 2019-01-22  Tom Tromey  <tom@tromey.com>
 395
 396         * remote-fileio.h (struct remote_target): Declare.
 397
 398 2019-01-22  Tom Tromey  <tom@tromey.com>
 399
 400         * python/py-arch.c: Do not include py-ref.h.
 401         * python/py-bpevent.c: Do not include py-ref.h.
 402         * python/py-cmd.c: Do not include py-ref.h.
 403         * python/py-continueevent.c: Do not include py-ref.h.
 404         * python/py-event.h: Do not include py-ref.h.
 405         * python/py-evtregistry.c: Do not include py-ref.h.
 406         * python/py-finishbreakpoint.c: Do not include py-ref.h.
 407         * python/py-frame.c: Do not include py-ref.h.
 408         * python/py-framefilter.c: Do not include py-ref.h.
 409         * python/py-function.c: Do not include py-ref.h.
 410         * python/py-infevents.c: Do not include py-ref.h.
 411         * python/py-linetable.c: Do not include py-ref.h.
 412         * python/py-objfile.c: Do not include py-ref.h.
 413         * python/py-param.c: Do not include py-ref.h.
 414         * python/py-prettyprint.c: Do not include py-ref.h.
 415         * python/py-progspace.c: Do not include py-ref.h.
 416         * python/py-symbol.c: Do not include py-ref.h.
 417         * python/py-symtab.c: Do not include py-ref.h.
 418         * python/py-type.c: Do not include py-ref.h.
 419         * python/py-unwind.c: Do not include py-ref.h.
 420         * python/py-utils.c: Do not include py-ref.h.
 421         * python/py-value.c: Do not include py-ref.h.
 422         * python/py-varobj.c: Do not include py-ref.h.
 423         * python/py-xmethods.c: Do not include py-ref.h.
 424         * python/python.c: Do not include py-ref.h.
 425         * varobj.c: Do not include py-ref.h.
 426
 427 2019-01-22  Tom Tromey  <tom@tromey.com>
 428
 429         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
 430         keyword for bcache.
 431
 432 2019-01-22  Tom Tromey  <tom@tromey.com>
 433
 434         * compile/compile-cplus-types.c: Remove a comment by #include.
 435
 436 2019-01-22  Tom Tromey  <tom@tromey.com>
 437
 438         * compile/gcc-c-plugin.h: Include compile-internal.h.
 439
 440 2019-01-22  Tom Tromey  <tom@tromey.com>
 441
 442         * stabsread.c (EXTERN): Do not define.
 443         (symnum, next_symbol_text_func, processing_gcc_compilation)
 444         (within_function, global_sym_chain, global_stabs)
 445         (previous_stab_code, this_object_header_files)
 446         (n_this_object_header_files)
 447         (n_allocated_this_object_header_files): Define.
 448         * stabsread.h (EXTERN): Never define.  Use "extern".
 449
 450 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 451
 452         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
 453         history_value.
 454
 455 2019-01-21  Tom Tromey  <tom@tromey.com>
 456
 457         * ui-out.c: Fix includes.
 458         * tui/tui-source.c: Fix includes.
 459         * target.c: Fix includes.
 460         * remote.c: Fix includes.
 461         * regcache.c: Fix includes.
 462         * python/py-block.c: Fix includes.
 463         * printcmd.c: Fix includes.
 464         * or1k-tdep.c: Fix includes.
 465         * mi/mi-main.c: Fix includes.
 466         * m32r-tdep.c: Fix includes.
 467         * csky-tdep.c: Fix includes.
 468         * compile/compile-cplus-types.c: Fix includes.
 469         * cli/cli-interp.c: Fix includes.
 470
 471 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
 472
 473         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 474         for padding.
 475
 476 2019-01-16  Tom Tromey  <tom@tromey.com>
 477
 478         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
 479         earlier.
 480         (struct objfile) <msymbols_range>: Move from top level.
 481         <msymbols>: New method.
 482         (class objfile_msymbols): Remove.
 483         * symtab.c (default_collect_symbol_completion_matches_break_on):
 484         Update.
 485         * symmisc.c (dump_msymbols): Update.
 486         * stabsread.c (scan_file_globals): Update.
 487         * objc-lang.c (info_selectors_command, info_classes_command)
 488         (find_methods): Update.
 489         * minsyms.c (find_solib_trampoline_target): Update.
 490         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
 491         * coffread.c (coff_symfile_read): Update.
 492         * ada-lang.c (ada_lookup_simple_minsym)
 493         (ada_collect_symbol_completion_matches): Update.
 494
 495 2019-01-16  Tom Tromey  <tom@tromey.com>
 496
 497         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
 498         type.  Remove no-argument constructor.
 499         <iterator::operator++>: Simplify.
 500         <begin>: Update.
 501         <end>: Use minimal_symbol_count.
 502
 503 2019-01-16  Tom Tromey  <tom@tromey.com>
 504
 505         * objfiles.h (struct objfile) <psymtabs>: New method.
 506         (class objfile_psymtabs): Remove.
 507         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
 508         typedef.
 509         <range>: New method.
 510         (require_partial_symbols): Change return type.
 511         * psymtab.c (require_partial_symbols)
 512         (psym_expand_symtabs_matching): Update.
 513         * mdebugread.c (parse_partial_symbols): Update.
 514         * dbxread.c (dbx_end_psymtab): Update.
 515
 516 2019-01-15  Tom Tromey  <tom@tromey.com>
 517
 518         * symtab.c (lookup_objfile_from_block)
 519         (lookup_symbol_in_objfile_symtabs)
 520         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
 521         (find_line_symtab, info_sources_command)
 522         (default_collect_symbol_completion_matches_break_on)
 523         (make_source_files_completion_list): Update.
 524         * symmisc.c (print_objfile_statistics, dump_objfile)
 525         (maintenance_print_symbols, maintenance_info_symtabs)
 526         (maintenance_check_symtabs, maintenance_info_line_tables):
 527         Update.
 528         * source.c (select_source_symtab)
 529         (forget_cached_source_info_for_objfile): Update.
 530         * objfiles.h (class objfile_compunits): Remove.
 531         (struct objfile) <compunits_range>: New typedef.
 532         (compunits): New method.
 533         * objfiles.c (objfile_relocate1): Update.
 534         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
 535         * maint.c (count_symtabs_and_blocks): Update.
 536         * linespec.c (iterate_over_all_matching_symtabs): Update.
 537         * cp-support.c (add_symbol_overload_list_qualified): Update.
 538         * coffread.c (coff_symtab_read): Update.
 539         * ada-lang.c (add_nonlocal_symbols)
 540         (ada_collect_symbol_completion_matches)
 541         (ada_add_global_exceptions): Update.
 542
 543 2019-01-15  Tom Tromey  <tom@tromey.com>
 544
 545         * progspace.h (program_space) <objfiles_safe_range>: New
 546         typedef.
 547         <objfiles_safe>: New method.
 548         * objfiles.h (class all_objfiles_safe): Remove.
 549         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
 550         * jit.c (jit_inferior_exit_hook): Update.
 551
 552 2019-01-17  Tom Tromey  <tom@tromey.com>
 553
 554         * progspace.h (program_space) <objfiles_range>: New typedef.
 555         <objfiles>: New method.
 556         <objfiles_head>: Rename from objfiles.
 557         (object_files): Update.
 558         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
 559         * guile/scm-pretty-print.c
 560         (ppscm_find_pretty_printer_from_objfiles): Update.
 561         * guile/scm-objfile.c (gdbscm_objfiles): Update.
 562         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
 563         Update.
 564         * python/py-progspace.c (pspy_get_objfiles): Update.
 565         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
 566         Update.
 567         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
 568         (objfpy_lookup_objfile_by_build_id): Update.
 569         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
 570         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
 571         Update.
 572         * symtab.c (iterate_over_symtabs, matching_obj_sections)
 573         (expand_symtab_containing_pc, lookup_objfile_from_block)
 574         (lookup_static_symbol, basic_lookup_transparent_type)
 575         (find_pc_sect_compunit_symtab, find_symbol_at_address)
 576         (find_line_symtab, info_sources_command)
 577         (default_collect_symbol_completion_matches_break_on)
 578         (make_source_files_completion_list, find_main_name): Update.
 579         * symmisc.c (print_symbol_bcache_statistics)
 580         (print_objfile_statistics, maintenance_print_symbols)
 581         (maintenance_print_msymbols, maintenance_print_objfiles)
 582         (maintenance_info_symtabs, maintenance_check_symtabs)
 583         (maintenance_expand_symtabs, maintenance_info_line_tables):
 584         Update.
 585         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
 586         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
 587         (map_overlay_command, unmap_overlay_command)
 588         (simple_overlay_update, expand_symtabs_matching)
 589         (map_symbol_filenames): Update.
 590         * symfile-debug.c (set_debug_symfile): Update.
 591         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
 592         Update.
 593         * source.c (select_source_symtab, forget_cached_source_info):
 594         Update.
 595         * solib.c (solib_read_symbols): Update.
 596         * solib-spu.c (append_ocl_sos): Update.
 597         * psymtab.c (maintenance_print_psymbols)
 598         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
 599         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
 600         * printcmd.c (info_symbol_command): Update.
 601         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
 602         Update.
 603         * objfiles.h (class all_objfiles): Remove.
 604         * objfiles.c (have_partial_symbols, have_full_symbols)
 605         (have_minimal_symbols, qsort_cmp, update_section_map)
 606         (shared_objfile_contains_address_p)
 607         (default_iterate_over_objfiles_in_search_order): Update.
 608         * objc-lang.c (info_selectors_command, info_classes_command)
 609         (find_methods): Update.
 610         * minsyms.c (find_solib_trampoline_target): Update.
 611         * maint.c (maintenance_info_sections)
 612         (maintenance_translate_address, count_symtabs_and_blocks):
 613         Update.
 614         * main.c (captured_main_1): Update.
 615         * linux-thread-db.c (try_thread_db_load_from_pdir)
 616         (has_libpthread): Update.
 617         * linespec.c (iterate_over_all_matching_symtabs)
 618         (search_minsyms_for_name): Update.
 619         * jit.c (jit_find_objf_with_entry_addr): Update.
 620         * hppa-tdep.c (find_unwind_entry)
 621         (hppa_lookup_stub_minimal_symbol): Update.
 622         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
 623         Update.
 624         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
 625         (elf_gnu_ifunc_resolve_by_got): Update.
 626         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
 627         * dwarf-index-write.c (save_gdb_index_command): Update.
 628         * cp-support.c (add_symbol_overload_list_qualified): Update.
 629         * breakpoint.c (create_overlay_event_breakpoint)
 630         (create_longjmp_master_breakpoint)
 631         (create_std_terminate_master_breakpoint)
 632         (create_exception_master_breakpoint): Update.
 633         * blockframe.c (find_pc_partial_function): Update.
 634         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
 635         (ada_collect_symbol_completion_matches)
 636         (ada_add_global_exceptions): Update.
 637
 638 2019-01-17  Tom Tromey  <tom@tromey.com>
 639
 640         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
 641         declare VEC.
 642         (solib_target_parse_libraries): Change return type.
 643         (library_list_start_segment, library_list_start_section)
 644         (library_list_end_library, library_list_start_library); Update.
 645         (solib_target_free_library_list): Remove.
 646         (solib_target_parse_libraries): Remove cleanup.  Change return
 647         type.
 648         (solib_target_current_sos): Update.
 649
 650 2019-01-17  Tom Tromey  <tromey@bapiya>
 651
 652         * valprint.c: Replace "the the" with "the".
 653         * symtab.c: Replace "the the" with "the".
 654         * solib.c: Replace "the the" with "the".
 655         * solib-dsbt.c: Replace "the the" with "the".
 656         * linespec.c: Replace "the the" with "the".
 657         * dwarf2loc.h: Replace "the the" with "the".
 658         * amd64-windows-tdep.c: Replace "the the" with "the".
 659         * aarch64-tdep.c: Replace "the the" with "the".
 660
 661 2019-01-16  Keith Seitz  <keiths@redhat.com>
 662
 663         PR gdb/23773
 664         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
 665         <builder>: Rename to ..
 666         <m_builder>: ... this and make private.
 667         (dwarf2_cu::get_builder): New method.  Change all users of
 668         `builder' to use this method.
 669         (dwarf2_start_symtab): Move to ...
 670         (dwarf2_cu::start_symtab): ... here.  Update all callers
 671         (setup_type_unit_groups): Move to ...
 672         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
 673         callers.
 674         (dwarf2_cu::reset_builder): New method.
 675         (process_full_compunit, process_full_type_unit): Use
 676         dwarf2_cu::reset_builder.
 677         (follow_die_offset): Record the ancestor CU if it is different
 678         from the followed DIE's CU.
 679         (follow_die_sig_1): Likewise.
 680
 681 2019-01-15  Tom Tromey  <tom@tromey.com>
 682
 683         * remote.c (class remote_state) <buf>: Now a char_vector.
 684         <buf_size>: Remove.
 685         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
 686         parameter.
 687         (remote_target::getpkt_or_notif_sane_1)
 688         (remote_target::getpkt_sane)
 689         (remote_target::getpkt_or_notif_sane): Likewise.
 690         (class remote_target) <putpkt>: New overload.
 691         (remote_target::read_frame): Change type of "buf_p".  Remove
 692         sizeof_p parameter.
 693         (packet_ok): New overload.
 694         (packet_check_result): New overload.
 695         Update all uses.
 696
 697 2019-01-14  Tom Tromey  <tom@tromey.com>
 698
 699         * remote-notif.c (handle_notification, remote_notif_ack)
 700         (remote_notif_parse): Make "buf" const.
 701         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
 702         const.
 703         (remote_notif_parse, remote_notif_ack, handle_notification):
 704         Likewise.
 705         * remote.c (remote_notif_stop_parse): Make "buf" const.
 706         (remote_target::remote_parse_stop_reply): Make "buf" const.
 707         (remote_notif_stop_ack): Make "buf" const.
 708
 709 2019-01-14  Tom Tromey  <tom@tromey.com>
 710
 711         * remote.c (remote_console_output): Make parameter const.
 712
 713 2019-01-14  Tom Tromey  <tom@tromey.com>
 714
 715         * target-debug.h (target_debug_print_signals): Constify.
 716         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
 717         * procfs.c (procfs_target::pass_signals): Update.
 718         * linux-nat.c (linux_nat_target::pass_signals): Update.
 719         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
 720         * target-delegates.c: Rebuild.
 721         * remote.c (remote_target::program_signals): Update.
 722         (remote_target::pass_signals): Update.
 723         * target.c (target_pass_signals): Constify argument.
 724         (target_program_signals): Likewise.
 725         * target.h (struct target_ops) <pass_signals, program_signals>:
 726         Constify argument.
 727         (target_pass_signals, target_program_signals): Constify argument.
 728
 729 2019-01-14  Tom Tromey  <tom@tromey.com>
 730
 731         PR tui/28819:
 732         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
 733
 734 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 735
 736         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
 737         field.
 738         * rs6000-tdep.c: Include reggroups.h.
 739         (IS_V_ALIAS_PSEUDOREG): Define.
 740         (rs6000_register_name): Return names for the "vX" aliases.
 741         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
 742         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
 743         aliases.  Call default_register_reggroup_p for all other
 744         pseudo-registers.
 745         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
 746         New functions.
 747         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
 748         Handle "vX" aliases.
 749         (v_alias_pseudo_register_collect): New function.
 750         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
 751         (rs6000_gdbarch_init): Initialize "vX" aliases as
 752         pseudo-registers.  Restore registration of
 753         rs6000_pseudo_register_reggroup_p with
 754         set_tdesc_pseudo_register_reggroup_p.
 755
 756 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
 757
 758         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
 759         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
 760         set_gdbarch_num_pseudo_regs.
 761
 762 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 763
 764         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
 765         Remove arg prefixname, add do_set and do_show.
 766         Add member functions set_list and show_list.
 767         * cli/cli-style.c (class cli_style_option): Update accordingly.
 768         (style_set_list): Move to file scope.
 769         (style_show_list): Likewise.
 770         (set_style): Call help_list.
 771         (show_style): Call cmd_show_list.
 772         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
 773         Update to use the new macro.
 774
 775 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
 776
 777         * ada-lang.c (_initialize_ada_language): Expand the help text
 778         for the "catch exception" command.
 779
 780 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 781
 782         * symtab.c (matching_obj_sections): Initialize obj,
 783         declare it closer to its usage.
 784
 785 2019-01-10  Tom Tromey  <tom@tromey.com>
 786
 787         * thread-iter.h (inf_threads_iterator): Use next_iterator.
 788         (basic_inf_threads_range): Remove.
 789         (inf_threads_range, inf_non_exited_threads_range)
 790         (safe_inf_threads_range): Use next_adapter.
 791
 792 2019-01-10  Keith Seitz  <keiths@redhat.com>
 793
 794         PR gdb/23712
 795         PR symtab/23010
 796         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
 797         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
 798
 799 2019-01-10  Keith Seitz  <keiths@redhat.com>
 800
 801         PR gdb/23712
 802         PR symtab/23010
 803         * dictionary.c (pending_to_vector): Remove.
 804         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 805         Remove _1 suffix, replacing functions of the same name.  Update
 806         all callers.
 807         (dict_create_hashed, dict_create_hashed_expandable)
 808         (dict_create_linear, dict_create_linear_expandable, dict_free)
 809         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
 810         Make functions static.
 811
 812 2019-01-10  Keith Seitz  <keiths@redhat.com>
 813
 814         PR gdb/23712
 815         PR symtab/23010
 816         * dictionary.h (struct dictionary): Replace declaration with
 817         multidictionary.
 818         (dict_create_hashed, dict_create_hashed_expandable)
 819         (dict_create_linear, dict_create_linear_expandable)
 820         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
 821         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
 822         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
 823         taking multidictionary argument.
 824         [ALL_DICT_SYMBOLS]: Update for multidictionary.
 825         * block.h (struct block) <dict>: Change to multidictionary
 826         and rename `multidict'.
 827         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
 828         symmisc.c: Update all dictionary references to multidictionary.
 829
 830 2019-01-10  Keith Seitz  <keiths@redhat.com>
 831
 832         PR gdb/23712
 833         PR symtab/23010
 834         * dictionary.c: Include unordered_map.
 835         (pending_to_vector): New function.
 836         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 837         Rewrite the non-"_1" functions to take vector instead
 838         of linked list.
 839         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
 840         "new" _1 versions of the same name.
 841         (multidictionary): Define.
 842         (std::hash<enum language): New definition.
 843         (collate_pending_symbols_by_language, mdict_create_hashed)
 844         (mdict_create_hashed_expandable, mdict_create_linear)
 845         (mdict_create_linear_expandable, mdict_free)
 846         (find_language_dictionary, create_new_language_dictionary)
 847         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
 848         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
 849         (mdict_size, mdict_empty): New functions.
 850         * dictionary.h (mdict_iterator): Define.
 851
 852 2019-01-10  Pedro Alves  <palves@redhat.com>
 853
 854         * breakpoint.c (read_uploaded_action)
 855         (create_tracepoint_from_upload): Adjust to use
 856         gdb::unique_xmalloc_ptr.
 857         * ctf.c (ctf_write_uploaded_tp):
 858         (SET_ARRAY_FIELD): Use emplace_back.
 859         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
 860         * tracefile-tfile.c (tfile_write_uploaded_tp):
 861         * tracepoint.c (parse_tracepoint_definition): Adjust to use
 862         gdb::unique_xmalloc_ptr.
 863         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
 864         at_string, cond_string, cmd_strings>: Replace char pointers
 865         with gdb::unique_xmalloc_ptr.
 866
 867 2019-01-10  Pedro Alves  <palves@redhat.com>
 868
 869         * solib-target.c (library_list_start_library): Don't xstrdup name.
 870
 871 2019-01-10  Pedro Alves  <palves@redhat.com>
 872
 873         * mdebugread.c (parse_partial_symbols): Use
 874         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
 875
 876 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 877
 878         * linux-fork.c (scoped_switch_fork_info)
 879         <~scoped_switch_fork_info>: Fix incorrect variable name.
 880
 881 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 882
 883         * linux-fork.c (scoped_switch_fork_info)
 884         <scoped_switch_fork_info>: Make explicit.
 885         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
 886
 887 2019-01-10  Tom Tromey  <tom@tromey.com>
 888
 889         * objfiles.h (objfile::reset_psymtabs): Update.
 890         * objfiles.c (objfile::objfile): Update.
 891         * psymtab.h (psymtab_storage::obstack): Update.
 892         (psymtab_storage::m_obstack): Use gdb::optional.
 893         (class psymtab_storage): Update comment.  Remove objfile
 894         parameter.
 895         * psymtab.c (psymtab_storage::psymtab_storage): Update.
 896
 897 2019-01-10  Tom Tromey  <tom@tromey.com>
 898
 899         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
 900         <free_psymtabs>: Now private.
 901         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
 902         (allocate_psymtab): Use new method.
 903
 904 2019-01-10  Tom Tromey  <tom@tromey.com>
 905
 906         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
 907         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
 908         * mdebugread.c (parse_partial_symbols): Use
 909         allocate_dependencies.
 910         * dwarf2read.c (dwarf2_create_include_psymtab): Use
 911         allocate_dependencies.
 912         (process_psymtab_comp_unit_reader)
 913         (build_type_psymtab_dependencies): Likewise.
 914         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
 915
 916 2019-01-10  Tom Tromey  <tom@tromey.com>
 917
 918         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
 919         PSYMBOL_SET_LANGUAGE.
 920         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
 921
 922 2019-01-10  Tom Tromey  <tom@tromey.com>
 923
 924         * psymtab.h (psymtab_storage::obstack): New method.
 925         <m_obstack>: Rename from obstack; now private.
 926         * psymtab.c (psymtab_storage): Update.
 927         * dwarf2read.c (create_addrmap_from_index)
 928         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
 929         Update.
 930
 931 2019-01-10  Tom Tromey  <tom@tromey.com>
 932
 933         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
 934         * objfiles.h (objfile::reset_psymtabs): New method.
 935
 936 2019-01-10  Tom Tromey  <tom@tromey.com>
 937
 938         * symmisc.c (print_symbol_bcache_statistics): Update.
 939         (print_objfile_statistics): Update.
 940         * symfile.c (reread_symbols): Update.
 941         * psymtab.h (class psymtab_storage): New.
 942         * psymtab.c (psymtab_storage): New constructor.
 943         (~psymtab_storage): New destructor.
 944         (require_partial_symbols): Update.
 945         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
 946         (find_pc_sect_psymtab, find_pc_sect_psymbol)
 947         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
 948         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
 949         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
 950         (start_psymtab_common, end_psymtab_common)
 951         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
 952         (allocate_psymtab): Update.
 953         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
 954         Update.
 955         (dump_psymtab_addrmap, maintenance_print_psymbols)
 956         (maintenance_check_psymtabs): Update.
 957         (class objfile_psymtabs): Move to objfiles.h.
 958         * psympriv.h (discard_psymtab): Now inline.
 959         (psymtab_discarder::psymtab_discarder): Update.
 960         (psymtab_discarder::~psymtab_discarder): Update.
 961         (ALL_OBJFILE_PSYMTABS): Rewrite.
 962         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
 963         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
 964         Remove fields.
 965         <partial_symtabs>: New field.
 966         (class objfile_psymtabs): Move from psymtab.h.  Update.
 967         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
 968         psymbol_cache.
 969         (objfile::~objfile): Don't destroy psymbol_cache.
 970         * mdebugread.c (parse_partial_symbols): Update.
 971         * dwarf2read.c (create_addrmap_from_index)
 972         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
 973         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
 974         (add_partial_subprogram, dwarf2_ranges_read): Update.
 975         * dwarf-index-write.c (write_address_map)
 976         (write_one_signatured_type, recursively_write_psymbols)
 977         (class debug_names, class debug_names, write_psymtabs_to_index):
 978         Update.
 979
 980 2019-01-10  Tom Tromey  <tom@tromey.com>
 981
 982         * symtab.h (SYMBOL_SET_NAMES): Update.
 983         (symbol_set_names): Update.
 984         (MSYMBOL_SET_NAMES): Update.
 985         * symtab.c (symbol_set_names): Change argument to be an
 986         objfile_per_bfd_storage.
 987         * psymtab.c (add_psymbol_to_bcache): Update.
 988         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
 989
 990 2019-01-10  Tom Tromey  <tom@tromey.com>
 991
 992         * symtab.c (create_demangled_names_hash): Change argument to be an
 993         objfile_per_bfd_storage.
 994         (symbol_set_names): Update.
 995
 996 2019-01-10  Tom Tromey  <tom@tromey.com>
 997
 998         * xcoffread.c (xcoff_initial_scan): Unconditionally call
 999         init_psymbol_list.
1000         * psymtab.c (init_psymbol_list): Do nothing if already called.
1001         * psympriv.h (init_psymbol_list): Add comment.
1002         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1003         init_psymbol_list.
1004         * dbxread.c (dbx_symfile_read): Unconditionally call
1005         init_psymbol_list.
1006
1007 2019-01-10  Tom Tromey  <tom@tromey.com>
1008
1009         * xcoffread.c (scan_xcoff_symtab): Update.
1010         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1011         "where".
1012         * mdebugread.c (parse_partial_symbols)
1013         (handle_psymbol_enumerators): Update.
1014         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1015         * dbxread.c (read_dbx_symtab): Update.
1016         * psympriv.h (psymbol_placement): New enum.
1017         (add_psymbol_to_list): Update.
1018
1019 2019-01-10  Tom Tromey  <tom@tromey.com>
1020
1021         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1022         static_psymbols parameters.
1023         (scan_xcoff_symtab): Update.
1024         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1025         static_psymbols parameters.
1026         * psympriv.h (start_psymtab_common): Update.
1027         * mdebugread.c (parse_partial_symbols): Update.
1028         * dwarf2read.c (create_partial_symtab): Update.
1029         * dbxread.c (read_dbx_symtab): Update.
1030         (start_psymtab): Remove global_psymbols and static_psymbols
1031         parameters.
1032
1033 2019-01-10  Tom Tromey  <tom@tromey.com>
1034
1035         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1036         * psymtab.c (allocate_psymtab): Add comment.
1037         * psympriv.h (allocate_psymtab): Add comment.
1038         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1039         initializations.
1040         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1041
1042 2019-01-10  Tom Tromey  <tom@tromey.com>
1043
1044         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1045         Don't declare.
1046         * mipsread.c: Include mdebugread.h.
1047         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1048         Declare.
1049         * elfread.c: Include mdebugread.h.
1050
1051 2019-01-09  Tom Tromey  <tom@tromey.com>
1052
1053         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1054         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1055         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1056         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1057         (psym_lookup_symbol, psym_find_last_source_symtab)
1058         (psym_forget_cached_source_info, psym_print_stats)
1059         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1060         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1061         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1062         (psym_find_compunit_symtab_by_address)
1063         (maintenance_print_psymbols, maintenance_info_psymtabs)
1064         (maintenance_check_psymtabs): Use ranged for.
1065         * psymtab.h (class objfile_psymtabs): New.
1066         (require_partial_symbols): Return objfile_psymtabs.
1067         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1068
1069 2019-01-09  Tom Tromey  <tom@tromey.com>
1070
1071         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1072         (find_pc_mapped_section, list_overlays_command)
1073         (map_overlay_command, unmap_overlay_command)
1074         (simple_overlay_update): Use all_objfiles.
1075         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1076         * printcmd.c (info_symbol_command): Use all_objfiles.
1077         * objfiles.h (ALL_OBJSECTIONS): Remove.
1078         * maint.c (maintenance_translate_address): Use all_objfiles.
1079         * gcore.c (gcore_create_callback): Use all_objfiles.
1080         (objfile_find_memory_regions): Likewise.
1081
1082 2019-01-09  Tom Tromey  <tom@tromey.com>
1083
1084         * symtab.c (find_line_symtab, info_sources_command)
1085         (make_source_files_completion_list): Use objfile_compunits.
1086         * source.c (select_source_symtab): Use objfile_compunits.
1087         * objfiles.h (struct objfile): Update comment.
1088         (ALL_OBJFILES): Remove.
1089         (ALL_FILETABS): Remove.
1090         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
1091         objfile_compunits.
1092
1093 2019-01-09  Tom Tromey  <tom@tromey.com>
1094
1095         * symmisc.c (print_objfile_statistics, dump_objfile)
1096         (maintenance_print_symbols): Use compunit_filetabs.
1097         * source.c (forget_cached_source_info_for_objfile): Use
1098         compunit_filetabs.
1099         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
1100         (ALL_FILETABS): Use compunit_filetabs.
1101         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
1102         * coffread.c (coff_symtab_read): Use compunit_filetabs.
1103
1104 2019-01-09  Tom Tromey  <tom@tromey.com>
1105
1106         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
1107         (compunit_filetabs): New.
1108         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
1109         compunit_filetabs.
1110         (info_sources_command, make_source_files_completion_list): Remove
1111         declaration.
1112         * symmisc.c (print_objfile_statistics, dump_objfile)
1113         (maintenance_print_symbols): Remove declaration.
1114         (maintenance_info_symtabs): Use compunit_filetabs.
1115         (maintenance_info_line_tables): Likewise.
1116         * source.c (select_source_symtab): Change local variable name.
1117         (forget_cached_source_info_for_objfile): Remove declaration.
1118         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
1119         * objfiles.c (objfile_relocate1): Remove declaration.
1120         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1121         declaration.
1122         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
1123         * coffread.c (coff_symtab_read): Remove declaration.
1124         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1125         compunit_filetabs.
1126
1127 2019-01-09  Tom Tromey  <tom@tromey.com>
1128
1129         * symtab.c (lookup_objfile_from_block)
1130         (find_pc_sect_compunit_symtab, search_symbols)
1131         (default_collect_symbol_completion_matches_break_on): Use
1132         objfile_compunits.
1133         * objfiles.h (ALL_COMPUNITS): Remove.
1134         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
1135         * cp-support.c (add_symbol_overload_list_qualified): Use
1136         objfile_compunits.
1137         * ada-lang.c (ada_collect_symbol_completion_matches)
1138         (ada_add_global_exceptions): Use objfile_compunits.
1139
1140 2019-01-09  Tom Tromey  <tom@tromey.com>
1141
1142         * source.c (select_source_symtab)
1143         (forget_cached_source_info_for_objfile): Remove declaration.
1144         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1145         declaration.
1146         * maint.c (count_symtabs_and_blocks): Remove declaration.
1147         * cp-support.c (add_symbol_overload_list_qualified): Remove
1148         declaration.
1149         * coffread.c (coff_symtab_read): Remove declaration.
1150         * symtab.c (lookup_symbol_in_objfile_symtabs)
1151         (basic_lookup_transparent_type_1): Use objfile_compunits.
1152         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
1153         (info_sources_command, search_symbols)
1154         (default_collect_symbol_completion_matches_break_on)
1155         (make_source_files_completion_list): Remove declaration.
1156         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
1157         (ada_collect_symbol_completion_matches)
1158         (ada_add_global_exceptions): Remove declaration.
1159         * linespec.c (iterate_over_all_matching_symtabs): Use
1160         objfile_compunits.
1161         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
1162         (class objfile_compunits): New.
1163         (ALL_COMPUNITS): Use objfile_compunits.
1164         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
1165         (maintenance_check_symtabs, maintenance_info_line_tables): Use
1166         objfile_compunits.
1167         * objfiles.c (objfile_relocate1): Use objfile_compunits.
1168
1169 2019-01-09  Tom Tromey  <tom@tromey.com>
1170
1171         * symtab.c (search_symbols)
1172         (default_collect_symbol_completion_matches_break_on): Use
1173         objfile_msymbols.
1174         * ada-lang.c (ada_lookup_simple_minsym)
1175         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
1176         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
1177         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
1178         objfile_msymbols.
1179         * coffread.c (coff_symfile_read): Use objfile_msymbols.
1180         * symmisc.c (dump_msymbols): Use objfile_msymbols.
1181         * objc-lang.c (find_methods): Use objfile_msymbols.
1182         (info_selectors_command, info_classes_command): Likewise.
1183         * stabsread.c (scan_file_globals): Use objfile_msymbols.
1184         * objfiles.h (class objfile_msymbols): New.
1185         (ALL_OBJFILE_MSYMBOLS): Remove.
1186         (ALL_MSYMBOLS): Remove.
1187
1188 2019-01-09  Tom Tromey  <tom@tromey.com>
1189
1190         * common/next-iterator.h (next_adapter): Add Iterator template
1191         parameter.
1192         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
1193         (class all_objfiles_safe): New.
1194         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
1195         * objfiles.c (put_objfile_before): Update comment.
1196         (add_separate_debug_objfile): Likewise.
1197         (free_all_objfiles): Use all_objfiles_safe.
1198         (objfile_purge_solibs): Likewise.
1199
1200 2019-01-09  Tom Tromey  <tom@tromey.com>
1201
1202         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1203         (expand_symtab_containing_pc, lookup_static_symbol)
1204         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
1205         (find_symbol_at_address, find_line_symtab, find_main_name): Use
1206         all_objfiles.
1207         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
1208         * breakpoint.c (create_overlay_event_breakpoint)
1209         (create_longjmp_master_breakpoint)
1210         (create_std_terminate_master_breakpoint)
1211         (create_exception_master_breakpoint): Use all_objfiles.
1212         * linux-thread-db.c (try_thread_db_load_from_pdir)
1213         (has_libpthread): Use all_objfiles.
1214         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
1215         * linespec.c (iterate_over_all_matching_symtabs)
1216         (search_minsyms_for_name): Use all_objfiles.
1217         * maint.c (maintenance_info_sections): Use all_objfiles.
1218         * main.c (captured_main_1): Use all_objfiles.
1219         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
1220         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
1221         * guile/scm-pretty-print.c
1222         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
1223         * solib-spu.c (append_ocl_sos): Use all_objfiles.
1224         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
1225         (maintenance_print_msymbols): Use all_objfiles.
1226         * source.c (select_source_symtab): Use all_objfiles.
1227         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
1228         * symfile.c (remove_symbol_file_command)
1229         (expand_symtabs_matching, map_symbol_filenames): Use
1230         all_objfiles.
1231         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
1232         all_objfiles.
1233         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
1234         * objc-lang.c (find_methods): Use all_objfiles.
1235         * objfiles.c (have_partial_symbols, have_full_symbols)
1236         (have_minimal_symbols, qsort_cmp)
1237         (default_iterate_over_objfiles_in_search_order): Use
1238         all_objfiles.
1239         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
1240         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
1241         (maintenance_check_psymtabs): Use all_objfiles.
1242         (ALL_PSYMTABS): Remove.
1243         * compile/compile-object-run.c (do_module_cleanup): Use
1244         all_objfiles.
1245         * blockframe.c (find_pc_partial_function): Use all_objfiles.
1246         * cp-support.c (add_symbol_overload_list_qualified): Use
1247         all_objfiles.
1248         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1249         Use all_objfiles.
1250         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
1251         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
1252         all_objfiles.
1253         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1254         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
1255         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1256         Uses all_objfiles.
1257         * solib.c (solib_read_symbols): Use all_objfiles
1258
1259 2019-01-09  Tom Tromey  <tom@tromey.com>
1260
1261         * probe.c (parse_probes_in_pspace): Use all_objfiles.
1262         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
1263         all_objfiles.
1264         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
1265         * symmisc.c (print_symbol_bcache_statistics)
1266         (print_objfile_statistics, maintenance_print_objfiles)
1267         (maintenance_info_symtabs, maintenance_check_symtabs)
1268         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
1269         all_objfiles.
1270         * source.c (forget_cached_source_info): Use all_objfiles.
1271         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
1272         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1273         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
1274         * objfiles.c (update_section_map): Use all_objfiles.
1275         (shared_objfile_contains_address_p): Likewise.
1276         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
1277         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
1278
1279 2019-01-09  Tom Tromey  <tom@tromey.com>
1280
1281         * common/next-iterator.h: New file.
1282         * objfiles.h (class all_objfiles): New.
1283         (struct objfile_iterator): New.
1284
1285 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1286
1287         * NEWS: Move the description of the changed "frame", "select-frame",
1288          and "info frame" commands to the Changed commands section.
1289
1290 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
1291
1292         * gdbtypes.c (check_stub_method_group): Remove handling of old
1293         mangling schemes.
1294         * linespec.c (find_methods): Likewise.
1295         * stabsread.c (read_member_functions): Likewise.
1296         * valops.c (search_struct_method): Likewise.
1297         (value_struct_elt_for_reference): Likewise.
1298         * NEWS: Mention this change.
1299
1300 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1301
1302         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
1303         print_source_lines.
1304         * source.c (print_source_lines_base): Update line number check.
1305         (print_source_lines): New function.
1306         (source_lines_range::source_lines_range): New function.
1307         * source.h (class source_lines_range): New class.
1308         (print_source_lines): New declaration.
1309
1310 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1311
1312         * linespec.c (linespec_state_destructor): Free self->canonical_names.
1313
1314 2019-01-08  Tom Tromey  <tom@tromey.com>
1315             Simon Marchi  <simon.marchi@ericsson.com>
1316
1317         PR gdb/24060
1318         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
1319         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
1320         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1321         * f-exp.y (DOLLAR_VARIABLE): Likewise.
1322         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
1323         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1324
1325 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1326
1327         * source.c (select_source_symtab): Move header comment to
1328         declaration in source.h.
1329         (forget_cached_source_info_for_objfile): Likewise.
1330         (forget_cached_source_info): Likewise.
1331         (identify_source_line): Likewise.
1332         * source.h (identify_source_line): Move declaration from symtab.h
1333         and add comment from source.c
1334         (print_source_lines): Likewise.
1335         (forget_cached_source_info_for_objfile): Likewise.
1336         (forget_cached_source_info): Likewise.
1337         (select_source_symtab): Likewise.
1338         (enum print_source_lines_flag): Move definition from symtab.h.
1339         * symtab.h (identify_source_line): Move declaration to source.h.
1340         (print_source_lines): Likewise.
1341         (forget_cached_source_info_for_objfile): Likewise.
1342         (forget_cached_source_info): Likewise.
1343         (select_source_symtab): Likewise.
1344         (enum print_source_lines_flag): Move definition to source.h.
1345         * tui/tui-hooks.c: Add 'source.h' include.
1346
1347 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1348
1349         * source.c (print_source_lines_base): Handle requests to print
1350         reverse line number sequences, and guard against empty lines
1351         string.
1352
1353 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1354
1355         * source.c (print_source_lines_base): Fix skip of '\r' if next
1356         character is '\n'.
1357
1358 2019-01-06  Tom Tromey  <tom@tromey.com>
1359
1360         * c-exp.y (struct c_parse_state) <macro_original_text,
1361         expansion_obstack>: New member.
1362         (macro_original_text, expansion_obstack): Remove globals.
1363         (scan_macro_expansion, scanning_macro_expansion)
1364         (finished_macro_expansion): Update.
1365         (scan_macro_cleanup): Remove.
1366         (yylex, c_parse): Update.
1367
1368 2019-01-06  Tom Tromey  <tom@tromey.com>
1369
1370         * c-exp.y (struct c_parse_state) <strings>: New member.
1371         (operator_stoken): Update.
1372
1373 2019-01-06  Tom Tromey  <tom@tromey.com>
1374
1375         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
1376         (union type_stack_elt) <typelist_val>: Now a pointer to
1377         std::vector.
1378         (type_stack_cleanup): Don't declare.
1379         (push_typelist): Update.
1380         * parse.c (pop_typelist): Return a std::vector.
1381         (push_typelist): Take a std::vector.
1382         (follow_types): Update.  Do not free args.
1383         (type_stack_cleanup): Remove.
1384         * c-exp.y (struct c_parse_state): New.
1385         (cpstate): New global.
1386         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
1387         (nonempty_typelist): Update.
1388         (func_mod): Create a new vector.
1389         (c_parse): Create a c_parse_state.
1390         (check_parameter_typelist): Do not delete params.
1391         (function_method): Update.  Do not delete type_list.
1392
1393 2019-01-06  Tom Tromey  <tom@tromey.com>
1394
1395         PR gdb/28155:
1396         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
1397         check_typedef.
1398         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
1399         (print_return_value): Likewise.
1400
1401 2019-01-05  Tom Tromey  <tom@tromey.com>
1402
1403         * contrib/cleanup_check.py: Remove.
1404         * contrib/gcc-with-excheck: Remove.
1405         * contrib/exsummary.py: Remove.
1406         * contrib/excheck.py: Remove.
1407
1408 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
1409
1410         * thread.c (delete_thread_1): Add gdb_assert that THR is not
1411         NULL. Initialize tpprev to NULL instead of assigning it
1412         to NULL on the next statement.
1413         * windows-nat.c (windows_delete_thread): Remove check for
1414         main_thread_id before printing thread exit notifications.
1415         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
1416         Remove thread ID check against main_thread_id.
1417         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
1418         windows_delete_thread.
1419         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
1420
1421 2019-01-04  Tom Tromey  <tom@tromey.com>
1422
1423         * compile/compile.c (_initialize_compile): Use upper case for
1424         metasyntactic variables.
1425         * symmisc.c (_initialize_symmisc): Use upper case for
1426         metasyntactic variables.
1427         * psymtab.c (_initialize_psymtab): Use upper case for
1428         metasyntactic variables.
1429         * demangle.c (demangle_command): Use upper case for metasyntactic
1430         variables.
1431         (_initialize_demangler): Likewise.
1432         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
1433         variables.
1434
1435 2019-01-03  Tom Tromey  <tom@tromey.com>
1436
1437         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
1438
1439 2019-01-03  Tom Tromey  <tom@tromey.com>
1440
1441         * python/py-symtab.c (salpy_str): Update.
1442         (struct salpy_sal_object) <symtab>: Now a PyObject.
1443         (salpy_dealloc): Update.
1444         (del_objfile_sal): Use gdbpy_ref.
1445
1446 2019-01-03  Tom Tromey  <tom@tromey.com>
1447
1448         * python/py-type.c (convert_field): Use new_reference.  Return
1449         gdbpy_ref.
1450         (make_fielditem): Return gdbpy_ref.
1451         (typy_fields): Update.
1452         (typy_getitem): Update.
1453         (field_name): Return gdbpy_ref.  Use new_reference.
1454         (typy_iterator_iternext): Update.
1455
1456 2019-01-03  Tom Tromey  <tom@tromey.com>
1457
1458         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
1459
1460 2019-01-03  Tom Tromey  <tom@tromey.com>
1461
1462         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
1463         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
1464         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
1465         (pspy_set_frame_filters, pspy_set_frame_unwinders)
1466         (pspy_set_type_printers): Likewise.
1467         * python/py-function.c (fnpy_init): Use gdbpy_ref.
1468         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
1469         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
1470         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
1471         (objfpy_set_type_printers): Likewise.
1472
1473 2019-01-03  Tom Tromey  <tom@tromey.com>
1474
1475         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
1476         (gdbpy_print_stack): Use gdbpy_err_fetch.
1477         * python/python-internal.h (class gdbpy_err_fetch): New class.
1478         (class gdbpy_enter) <m_error_type, m_error_value,
1479         m_error_traceback>: Remove.
1480         <m_error>: New member.
1481         (gdbpy_exception_to_string): Don't declare.
1482         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
1483         * python/py-value.c (convert_value_from_python): Use
1484         gdbpy_err_fetch.
1485         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
1486         gdbpy_exception_to_string.
1487         (gdbpy_handle_exception): Use gdbpy_err_fetch.
1488         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1489         gdbpy_err_fetch.
1490
1491 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1492
1493         * linux-nat.c (delete_lwp_cleanup): Delete.
1494         (struct lwp_deleter): New struct.
1495         (lwp_info_up): New typedef.
1496         (linux_nat_target::follow_fork): Delete cleanup, and make use of
1497         lwp_info_up.
1498
1499 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1500
1501         * linux-fork.c (class scoped_switch_fork_info): New class.
1502         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
1503
1504 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1505
1506         * valops.c (find_overload_match): Remove use of null_cleanup, and
1507         calls to do_cleanups.
1508
1509 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1510
1511         * compile/compile-cplus-types.c
1512         (compile_cplus_instance::decl_name): Handle changes to
1513         cp_func_name.
1514         * cp-support.c (cp_func_name): Update header comment, update
1515         return type.
1516         * cp-support.h (cp_func_name): Update return type in declaration.
1517         * valops.c (find_overload_match): Move temp_func local to top
1518         level of function and change its type.  Use temp_func to hold and
1519         delete temporary string obtained from cp_func_name.
1520
1521 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1522
1523         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
1524         gdb::char_vector, remove cleanup, and update uses of `msg`.
1525
1526 2019-01-03  Jim Wilson  <jimw@sifive.com>
1527
1528         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
1529
1530 2019-01-02  Tom Tromey  <tom@tromey.com>
1531
1532         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
1533         (tdesc_parse_xml): Remove cleanups.
1534         * target-descriptions.h (make_cleanup_free_target_description):
1535         Don't declare.
1536         (target_desc_deleter): New struct.
1537         (target_desc_up): New typedef.
1538         * target-descriptions.c (target_desc_deleter::operator()): Rename
1539         from free_target_description.
1540         (make_cleanup_free_target_description): Remove.
1541
1542 2019-01-02  Tom Tromey  <tom@tromey.com>
1543
1544         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
1545         constructor, destructor.
1546         (linespec_parser): Remove typedef.
1547         (~linespec_parser): Rename from linespec_parser_delete.
1548         (linespec_lex_to_end, linespec_complete_label)
1549         (linespec_complete): Update.
1550         (decode_line_full): Remove cleanups.
1551         (decode_line_1): Update.
1552
1553 2019-01-02  Tom Tromey  <tom@tromey.com>
1554
1555         * python/python-internal.h (inferior_to_inferior_object): Change
1556         return type.
1557         * python/py-exitedevent.c (create_exited_event_object): Update.
1558         * python/py-inferior.c (inferior_to_inferior_object): Return
1559         gdbpy_ref.
1560         (python_new_inferior, python_inferior_deleted)
1561         (thread_to_thread_object, delete_thread_object)
1562         (build_inferior_list, gdbpy_selected_inferior): Update.
1563         * python/py-infthread.c (create_thread_object): Update.  Also fail
1564         if inferior_to_inferior_object fails.
1565
1566 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
1567
1568         * inferior.h (class inferior) <displaced_step_state>: New field.
1569         * infrun.h (struct displaced_step_state): Move here from
1570         infrun.c.  Initialize fields, add constructor.
1571         <inf>: Remove field.
1572         <reset>: New method.
1573         * infrun.c (struct displaced_step_inferior_state): Move to
1574         infrun.h.
1575         (displaced_step_inferior_states): Remove.
1576         (get_displaced_stepping_state): Adust.
1577         (displaced_step_in_progress_any_inferior): Adjust.
1578         (displaced_step_in_progress_thread): Adjust.
1579         (displaced_step_in_progress): Adjust.
1580         (add_displaced_stepping_state): Remove.
1581         (get_displaced_step_closure_by_addr): Adjust.
1582         (remove_displaced_stepping_state): Remove.
1583         (infrun_inferior_exit): Call displaced_step_state.reset.
1584         (use_displaced_stepping): Don't check for NULL.
1585         (displaced_step_prepare_throw): Call
1586         get_displaced_stepping_state.
1587         (displaced_step_fixup): Don't check for NULL.
1588         (prepare_for_detach): Don't check for NULL.
1589
1590 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1591
1592         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
1593          in case of call that did not complete.
1594
1595 2019-01-02  Andrey Utkin  <autkin@undo.io>
1596
1597         * symfile.c (find_separate_debug_file): Fix search of debug files for
1598         remote debuggee.
1599
1600 2019-01-02  Tom Tromey  <tom@tromey.com>
1601
1602         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
1603         indentation.
1604         * python/py-frame.c (frapy_older): Remove cast.
1605         (frapy_newer): Likewise.
1606         * python/py-breakpoint.c (local_setattro): Remove cast.
1607         * python/py-arch.c (archpy_name): Remove local variable.
1608         * python/py-type.c (gdbpy_lookup_type): Remove cast.
1609
1610 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
1611
1612         * unittests/basic_string_view/element_access/char/empty.cc:
1613         Fix year range in copyright header.
1614
1615 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1616
1617         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
1618         Delete.
1619         <operator==>: Update with for removed field.
1620         <hash>: Likewise.
1621         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
1622         <isa_features>: ...this.
1623         <abi_features>: New field.
1624         (riscv_isa_flen): Update comment.
1625         (riscv_abi_xlen): New declaration.
1626         (riscv_abi_flen): New declaration.
1627         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
1628         isa_features.
1629         (riscv_abi_xlen): New function.
1630         (riscv_isa_flen): Update to get answer from isa_features.
1631         (riscv_abi_flen): New function.
1632         (riscv_has_fp_abi): Update to get answer from abi_features.
1633         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
1634         xlen and flen.
1635         (riscv_call_info) <xlen, flen>: Update comment.
1636         (riscv_call_arg_struct): Remove invalid assertions
1637         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
1638         is removed.
1639         (riscv_gdbarch_init): Gather isa features and abi features
1640         separately, ensure both match on the gdbarch when reusing an old
1641         gdbarch.  Relax an error check to allow 32-bit abi float to run on
1642         a target with 64-bit float hardware.
1643
1644 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1645
1646         * source.c (search_command_helper): Stop reverse search
1647         when line 1 has been searched.
1648
1649 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1650
1651         * record-full.c (record_full_base_target::close): Rewrite
1652         record_full_core_buf_list free logic.
1653
1654 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1655
1656         * break-catch-syscall.c (print_one_catch_syscall): xfree
1657         the last text.
1658
1659 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1660
1661         * top.c (print_gdb_version): Update Copyright year in version
1662         message.
1663
1664 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1665
1666         Update copyright year range in all GDB files.
1667
1668 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
1669
1670         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
1671
1672 For older changes see ChangeLog-2018.
1673 \f
1674 Local Variables:
1675 mode: change-log
1676 left-margin: 8
1677 fill-column: 74
1678 version-control: never
1679 coding: utf-8
1680 End:
1681