gdb/ChangeLog

   1 2019-03-13  Tom Tromey  <tromey@adacore.com>
   2
   3         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
   4         (i386_gnu_nat_target::store_registers): Update.
   5         * target-debug.h (target_debug_print_std_string): New macro.
   6         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
   7         * windows-tdep.c (display_one_tib): Update.
   8         * tui/tui-stack.c (tui_make_status_line): Update.
   9         * top.c (print_inferior_quit_action): Update.
  10         * thread.c (thr_try_catch_cmd): Update.
  11         (add_thread_with_info): Update.
  12         (thread_target_id_str): Update.
  13         (thr_try_catch_cmd): Update.
  14         (thread_command): Update.
  15         (thread_find_command): Update.
  16         * record-btrace.c (record_btrace_target::info_record)
  17         (record_btrace_resume_thread, record_btrace_target::resume)
  18         (record_btrace_cancel_resume, record_btrace_step_thread)
  19         (record_btrace_target::wait, record_btrace_target::wait)
  20         (record_btrace_target::wait, record_btrace_target::stop): Update.
  21         * progspace.c (print_program_space): Update.
  22         * process-stratum-target.c
  23         (process_stratum_target::thread_address_space): Update.
  24         * linux-fork.c (linux_fork_mourn_inferior)
  25         (detach_checkpoint_command, info_checkpoints_command)
  26         (linux_fork_context): Update.
  27         (linux_fork_detach): Update.
  28         (class scoped_switch_fork_info): Update.
  29         (delete_checkpoint_command): Update.
  30         * infrun.c (follow_fork_inferior): Update.
  31         (follow_fork_inferior): Update.
  32         (proceed_after_vfork_done): Update.
  33         (handle_vfork_child_exec_or_exit): Update.
  34         (follow_exec): Update.
  35         (displaced_step_prepare_throw): Update.
  36         (displaced_step_restore): Update.
  37         (start_step_over): Update.
  38         (resume_1): Update.
  39         (clear_proceed_status_thread): Update.
  40         (proceed): Update.
  41         (print_target_wait_results): Update.
  42         (do_target_wait): Update.
  43         (context_switch): Update.
  44         (stop_all_threads): Update.
  45         (restart_threads): Update.
  46         (finish_step_over): Update.
  47         (handle_signal_stop): Update.
  48         (switch_back_to_stepped_thread): Update.
  49         (keep_going_pass_signal): Update.
  50         (print_exited_reason): Update.
  51         (normal_stop): Update.
  52         * inferior.c (inferior_pid_to_str): Change return type.
  53         (print_selected_inferior): Update.
  54         (add_inferior): Update.
  55         (detach_inferior): Update.
  56         * dummy-frame.c (fprint_dummy_frames): Update.
  57         * dcache.c (dcache_info_1): Update.
  58         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
  59         (btrace_fetch, btrace_clear): Update.
  60         * linux-tdep.c (linux_core_pid_to_str): Change return type.
  61         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
  62         type.
  63         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
  64         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
  65         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
  66         * gdbarch.c, gdbarch.h: Rebuild.
  67         * gdbarch.sh (core_pid_to_str): Change return type.
  68         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
  69         return type.
  70         (windows_nat_target::pid_to_str): Change return type.
  71         (windows_delete_thread): Update.
  72         (windows_nat_target::attach): Update.
  73         (windows_nat_target::files_info): Update.
  74         * target-delegates.c: Rebuild.
  75         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
  76         return type.
  77         (sol_thread_target::pid_to_str): Change return type.
  78         * remote.c (class remote_target) <pid_to_str>: Change return
  79         type.
  80         (remote_target::pid_to_str): Change return type.
  81         (extended_remote_target::attach, remote_target::remote_stop_ns)
  82         (remote_target::remote_notif_remove_queued_reply)
  83         (remote_target::push_stop_reply, remote_target::disable_btrace):
  84         Update.
  85         (extended_remote_target::attach): Update.
  86         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
  87         type.
  88         (gdbsim_target::pid_to_str): Change return type.
  89         * ravenscar-thread.c (struct ravenscar_thread_target)
  90         <pid_to_str>: Change return type.
  91         (ravenscar_thread_target::pid_to_str): Change return type.
  92         * procfs.c (class procfs_target) <pid_to_str>: Change return
  93         type.
  94         (procfs_target::pid_to_str): Change return type.
  95         (procfs_target::attach): Update.
  96         (procfs_target::detach): Update.
  97         (procfs_target::fetch_registers): Update.
  98         (procfs_target::store_registers): Update.
  99         (procfs_target::wait): Update.
 100         (procfs_target::files_info): Update.
 101         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
 102         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
 103         return type.
 104         (nto_procfs_target::pid_to_str): Change return type.
 105         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
 106         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
 107         return type.
 108         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
 109         (exit_lwp): Update.
 110         (attach_proc_task_lwp_callback, get_detach_signal)
 111         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
 112         (linux_nat_target::resume, wait_lwp, stop_callback)
 113         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
 114         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
 115         (linux_nat_wait_1, resume_stopped_resumed_lwps)
 116         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
 117         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
 118         type.
 119         (inf_ptrace_target::attach): Update.
 120         (inf_ptrace_target::files_info): Update.
 121         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
 122         type.
 123         (go32_nat_target::pid_to_str): Change return type.
 124         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
 125         (gnu_nat_target::wait): Update.
 126         (gnu_nat_target::wait): Update.
 127         (gnu_nat_target::resume): Update.
 128         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
 129         (fbsd_nat_target::wait): Update.
 130         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
 131         type.
 132         (darwin_nat_target::attach): Update.
 133         * corelow.c (class core_target) <pid_to_str>: Change return type.
 134         (core_target::pid_to_str): Change return type.
 135         * target.c (normal_pid_to_str): Change return type.
 136         (default_pid_to_str): Likewise.
 137         (target_pid_to_str): Change return type.
 138         (target_translate_tls_address): Update.
 139         (target_announce_detach): Update.
 140         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
 141         return type.
 142         (bsd_uthread_target::pid_to_str): Change return type.
 143         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
 144         type.
 145         (bsd_kvm_target::pid_to_str): Change return type.
 146         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
 147         return type.
 148         (aix_thread_target::pid_to_str): Change return type.
 149         * target.h (struct target_ops) <pid_to_str>: Change return type.
 150         (target_pid_to_str, normal_pid_to_str): Likewise.
 151         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
 152         type.
 153         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
 154         type.
 155         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
 156         return type.
 157         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
 158         type.
 159         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
 160         type.
 161         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
 162         return type.
 163
 164 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
 165
 166         * NEWS: Mention that the new default MI version is 3.  Mention
 167         changes to the output of commands and events that deal with
 168         multi-location breakpoints.
 169         * breakpoint.c: Include "mi/mi-out.h".
 170         (print_one_breakpoint): Change output syntax if using MI version
 171         >= 3.
 172         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
 173         New.
 174         (mi_multi_location_breakpoint_output_fixed): New.
 175         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
 176         (mi_cmd_fix_multi_location_breakpoint_output): New.
 177         (mi_multi_location_breakpoint_output_fixed): New.
 178         * mi/mi-cmds.c (mi_cmds): Register command
 179         -fix-multi-location-breakpoint-output.
 180         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
 181         interpreter "mi".
 182
 183 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
 184
 185         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
 186         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
 187         instantiate mi_ui_out based on interpreter name.
 188         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
 189         * mi/mi-main.c (mi_load_progress): Likewise.
 190
 191 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 192
 193         * NEWS: Combine separate "New targets" sections for 8.3.
 194
 195 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 196
 197         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
 198         (ppcfbsd_init_abi): Install gdbarch
 199         "fetch_tls_load_module_address" and "get_thread_local_address"
 200         methods.
 201
 202 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 203
 204         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
 205         (riscv_fbsd_init_abi): Install gdbarch
 206         "fetch_tls_load_module_address" and "get_thread_local_address"
 207         methods.
 208
 209 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 210
 211         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
 212         (i386fbsd_init_abi): Install gdbarch
 213         "fetch_tls_load_module_address" and "get_thread_local_address"
 214         methods.
 215
 216 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 217
 218         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
 219         (amd64fbsd_init_abi): Install gdbarch
 220         "fetch_tls_load_module_address" and "get_thread_local_address"
 221         methods.
 222
 223 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 224
 225         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
 226         (struct fbsd_pspace_data): New type.
 227         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
 228         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
 229         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
 230         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
 231         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
 232
 233 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 234
 235         * gdbtypes.c (lookup_struct_elt): New function.
 236         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
 237         * gdbtypes.h (struct struct_elt): New type.
 238         (lookup_struct_elt): New prototype.
 239
 240 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 241
 242         * gdbtypes.c (lookup_struct_elt_type): Update comment and
 243         remove disabled code block.
 244
 245 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 246
 247         * gdbarch.sh (get_thread_local_address): New method.
 248         * gdbarch.h, gdbarch.c: Regenerate.
 249         * target.c (target_translate_tls_address): Use
 250         gdbarch_get_thread_local_address if present instead of
 251         target::get_thread_local_address.
 252
 253 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 254
 255         * target.h (target::get_thread_local_address): Update comment.
 256
 257 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 258
 259         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
 260         objfile->separate_debug_objfile_backlink if not NULL.
 261
 262 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 263
 264         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
 265         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
 266         (amd64bsd_store_inferior_registers): Likewise.
 267         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 268         Enable segment base registers.
 269         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
 270         PT_GETFSBASE and PT_GETGSBASE.
 271         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
 272         PT_SETGSBASE.
 273         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
 274         segment base registers.
 275         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 276
 277 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 278
 279         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 280         Update calls to i386_target_description to add 'segments'
 281         parameter.
 282         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
 283         add segment base registers.
 284         * arch/i386.c (i386_create_target_description): Add 'segments'
 285         parameter to enable segment base registers.
 286         * arch/i386.h (i386_create_target_description): Likewise.
 287         * features/i386/32bit-segments.xml: New file.
 288         * features/i386/32bit-segments.c: Generate.
 289         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
 290         call to i386_target_description to add 'segments' parameter.
 291         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 292         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
 293         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
 294         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
 295         if feature is present.
 296         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
 297         Add 'segments' parameter to call to i386_target_description.
 298         (i386_target_description): Add 'segments' parameter to enable
 299         segment base registers.
 300         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
 301         to call to i386_target_description.
 302         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
 303         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
 304         Define I386_NUM_REGS.
 305         (i386_target_description): Add 'segments' parameter to enable
 306         segment base registers.
 307
 308 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
 309
 310         PR/24325
 311         * source-cache.c: #undef open and close, to avoid unresolved
 312         externals during linking.
 313
 314 2019-03-12  Tom Tromey  <tromey@adacore.com>
 315
 316         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
 317         const.  Add initializers.
 318         (_initialize_remote): Don't initialize ptid globals.
 319
 320 2019-03-12  Pedro Alves  <palves@redhat.com>
 321
 322         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
 323
 324 2019-03-12  Pedro Alves  <palves@redhat.com>
 325
 326         * cp-name-parser.y (main): Remove unused 'len' variable.
 327
 328 2019-03-12  Tom Tromey  <tromey@adacore.com>
 329
 330         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
 331         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
 332
 333 2019-03-12  Tom Tromey  <tromey@adacore.com>
 334
 335         * linux-nat.c (iterate_over_lwps): Update.
 336         (stop_callback): Remove parameter.
 337         (stop_wait_callback, detach_callback, resume_set_callback)
 338         (select_singlestep_lwp_callback, set_ignore_sigint)
 339         (status_callback, resumed_callback, resume_clear_callback)
 340         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
 341         data parameter.
 342         (linux_nat_target::detach, linux_nat_target::resume)
 343         (linux_stop_and_wait_all_lwps, select_event_lwp)
 344         (linux_nat_filter_event, linux_nat_wait_1)
 345         (linux_nat_target::kill, linux_nat_target::stop)
 346         (linux_nat_target::stop): Update.
 347         (linux_nat_resume_callback): Change type.
 348         (resume_stopped_resumed_lwps, count_events_callback)
 349         (select_event_lwp_callback): Likewise.
 350         (linux_stop_lwp, linux_nat_stop_lwp): Update.
 351         * arm-linux-nat.c (struct update_registers_data): Remove.
 352         (update_registers_callback): Change type.
 353         (arm_linux_insert_hw_breakpoint1): Update.
 354         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
 355         parameter.
 356         (x86_linux_dr_set_addr): Update.
 357         (x86_linux_dr_set_control): Update.
 358         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
 359         (iterate_over_lwps): Use gdb::function_view.
 360         * nat/aarch64-linux-hw-point.c (struct
 361         aarch64_dr_update_callback_param): Remove.
 362         (debug_reg_change_callback): Change type.
 363         (aarch64_notify_debug_reg_change): Update.
 364         * s390-linux-nat.c (s390_refresh_per_info): Update.
 365
 366 2019-03-11  Tom Tromey  <tromey@adacore.com>
 367
 368         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
 369         redundant assignment to "this_cu".
 370
 371 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 372
 373         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
 374
 375 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 376
 377         * gdbtypes.c (rank_one_type_parm_set): New function extracted
 378         from...
 379         (rank_one_type): ... this.
 380
 381 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 382
 383         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
 384         from...
 385         (rank_one_type): ... this.
 386
 387 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 388
 389         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
 390         from...
 391         (rank_one_type): ... this.
 392
 393 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 394
 395         * gdbtypes.c (rank_one_type_parm_float): New function extracted
 396         from...
 397         (rank_one_type): ... this.
 398
 399 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 400
 401         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
 402         from...
 403         (rank_one_type): ... this.
 404
 405 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 406
 407         * gdbtypes.c (rank_one_type_parm_range): New function extracted
 408         from...
 409         (rank_one_type): ... this.
 410
 411 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 412
 413         * gdbtypes.c (rank_one_type_parm_char): New function extracted
 414         from...
 415         (rank_one_type): ... this.
 416
 417 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 418
 419         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
 420         from...
 421         (rank_one_type): ... this.
 422
 423 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 424
 425         * gdbtypes.c (rank_one_type_parm_int): New function extracted
 426         from...
 427         (rank_one_type): ... this.
 428
 429 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 430
 431         * gdbtypes.c (rank_one_type_parm_func): New function extracted
 432         from...
 433         (rank_one_type): ... this.
 434
 435 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 436
 437         * gdbtypes.c (rank_one_type_parm_array): New function extracted
 438         from...
 439         (rank_one_type): ... this.
 440
 441 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 442
 443         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
 444         from...
 445         (rank_one_type): ... this.
 446
 447 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 448
 449         * inferior.c (initialize_inferiors): Ensure 'help set/show print
 450         inferior-events' shows the example events.
 451
 452 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
 453
 454         Support styling on native MS-Windows console
 455
 456         PR/24315
 457         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
 458         on MS-Windows if $TERM is not defined.
 459
 460         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
 461
 462         * posix-hdep.c (gdb_console_fputs):
 463         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
 464         functions.
 465         * ui-file.h (gdb_console_fputs): Add prototype.
 466
 467         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
 468         back to fputs only if the former returns zero.
 469
 470 2019-03-07  Tom Tromey  <tom@tromey.com>
 471
 472         * symmisc.c (print_symbol_bcache_statistics): Update.
 473         (print_objfile_statistics): Update.
 474         * symfile.c (allocate_symtab): Update.
 475         * stabsread.c: Don't include bcache.h.
 476         * psymtab.h (struct psymbol_bcache): Don't declare.
 477         (class psymtab_storage) <psymbol_cache>: Now a bcache.
 478         (psymbol_bcache_init, psymbol_bcache_free)
 479         (psymbol_bcache_get_bcache): Don't declare.
 480         * psymtab.c (struct psymbol_bcache): Remove.
 481         (psymtab_storage::psymtab_storage): Update.
 482         (psymtab_storage::~psymtab_storage): Update.
 483         (psymbol_bcache_init, psymbol_bcache_free)
 484         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
 485         (add_psymbol_to_bcache): Update.
 486         (allocate_psymtab): Update.
 487         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
 488         macro_cache>: No longer pointers.
 489         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
 490         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
 491         * macrotab.c (macro_bcache): Update.
 492         * macroexp.c: Don't include bcache.h.
 493         * gdbtypes.c (check_types_worklist): Update.
 494         (types_deeply_equal): Remove TRY/CATCH.  Update.
 495         * elfread.c (elf_symtab_read): Update.
 496         * dwarf2read.c: Don't include bcache.h.
 497         * buildsym.c (buildsym_compunit::get_macro_table): Update.
 498         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
 499         (print_bcache_statistics, bcache_memory_used): Don't declare.
 500         (struct bcache): Move from bcache.c.  Add constructor, destructor,
 501         methods.  Rename all data members.
 502         * bcache.c (struct bcache): Move to bcache.h.
 503         (bcache::expand_hash_table): Rename from expand_hash_table.
 504         (bcache): Remove.
 505         (bcache::insert): Rename from bcache_full.
 506         (bcache::compare): Rename from bcache_compare.
 507         (bcache_xmalloc): Remove.
 508         (bcache::~bcache): Rename from bcache_xfree.
 509         (bcache::print_statistics): Rename from print_bcache_statistics.
 510         (bcache::memory_used): Rename from bcache_memory_used.
 511
 512 2019-03-07  Pedro Alves  <palves@redhat.com>
 513
 514         * infrun.c (normal_stop): Also check for
 515         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
 516
 517 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
 518
 519         * f-lang.c (value_from_host_double): Moved to...
 520         * value.c (value_from_host_double): ...here.
 521         * value.h (value_from_host_double): Declare.
 522         * guile/scm-math.c (vlscm_convert_typed_number): Use
 523         value_from_host_double.
 524         (vlscm_convert_number): Likewise.
 525         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
 526         * python/py-value.c (convert_value_from_python): Likewise.
 527
 528 2019-03-06  Tom Tromey  <tom@tromey.com>
 529
 530         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
 531
 532 2019-03-06  Tom Tromey  <tom@tromey.com>
 533
 534         * utils.h (free_current_contents): Don't declare.
 535         * utils.c (free_current_contents): Remove.
 536
 537 2019-03-06  Tom Tromey  <tom@tromey.com>
 538
 539         * top.c (quit_force): Update.
 540         * main.c (captured_command_loop): Update.
 541         * common/new-op.c (operator new): Update.
 542         * common/common-exceptions.c (struct catcher)
 543         <save_cleanup_chain>: Remove member.
 544         (exceptions_state_mc_init): Update.
 545         (exception_try_scope_entry): Return nullptr.
 546         (exception_try_scope_exit, exception_rethrow)
 547         (throw_exception_sjlj, throw_exception_cxx): Update.
 548         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
 549         (all_cleanups, do_cleanups, discard_cleanups)
 550         (discard_final_cleanups, save_cleanups, save_final_cleanups)
 551         (restore_cleanups, restore_final_cleanups): Don't declare.
 552         (do_final_cleanups): Remove parameter.
 553         * common/cleanups.c (cleanup_chain, make_cleanup)
 554         (make_cleanup_dtor, all_cleanups, do_cleanups)
 555         (discard_my_cleanups, discard_cleanups)
 556         (discard_final_cleanups, save_my_cleanups, save_cleanups)
 557         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
 558         (null_cleanup): Remove.
 559         (do_final_cleanups): Remove parameter.
 560
 561 2019-03-06  Tom Tromey  <tom@tromey.com>
 562
 563         * remote.c (remote_target::remote_parse_stop_reply): Use
 564         unique_xmalloc_ptr.
 565
 566 2019-03-06  Tom Tromey  <tom@tromey.com>
 567
 568         * stabsread.c (struct stabs_field_info): Rename from field_info.
 569         <list, fnlist>: Add initializers.
 570         <obstack>: New member.
 571         (read_member_functions, read_struct_fields, read_baseclasses):
 572         Allocate on obstack.  Don't use cleanups.
 573         (read_one_struct_field, read_member_functions, read_struct_fields)
 574         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
 575         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
 576         (read_struct_type): Update.
 577
 578 2019-03-06  Tom Tromey  <tom@tromey.com>
 579
 580         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
 581         * common/filestuff.h (make_cleanup_close): Don't declare.
 582         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
 583         Remove.
 584
 585 2019-03-06  Tom Tromey  <tom@tromey.com>
 586
 587         * solib-aix.c: Use make_scope_exit.
 588
 589 2019-03-06  Tom Tromey  <tom@tromey.com>
 590
 591         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
 592         Use make_scope_exit.
 593
 594 2019-03-06  Tom Tromey  <tom@tromey.com>
 595
 596         * solib-svr4.c (disable_probes_interface): Remove parameter.
 597         (svr4_handle_solib_event): Use make_scope_exit.
 598
 599 2019-03-06  Tom Tromey  <tom@tromey.com>
 600
 601         * remote.c (struct stop_reply_deleter): Remove.
 602         (stop_reply_up): Update.
 603         (struct stop_reply): Derive from notif_event.  Don't typedef.
 604         <regcache>: Now a std::vector.
 605         (stop_reply_xfree): Remove.
 606         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
 607         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
 608         (remote_target::discard_pending_stop_replies): Use delete.
 609         (remote_target::remote_parse_stop_reply): Update.
 610         (remote_target::process_stop_reply): Update.
 611         * remote-notif.h (struct notif_event): Add virtual destructor.
 612         Remove "dtr" member.
 613         (struct notif_client) <alloc_event>: Return a unique_ptr.
 614         (notif_event_xfree): Don't declare.
 615         (notif_event_up): New typedef.
 616         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
 617         (notif_event_xfree, do_notif_event_xfree): Remove.
 618         (remote_notif_state_xfree): Update.
 619
 620 2019-03-06  Tom Tromey  <tom@tromey.com>
 621
 622         * infrun.c (displaced_step_clear_cleanup): Now a
 623         forward_scope_exit type.
 624         (displaced_step_prepare_throw): Update.
 625         (displaced_step_fixup): Update.
 626
 627 2019-03-06  Tom Tromey  <tom@tromey.com>
 628
 629         * inferior.h (class inferior): Update comment.
 630         * gdbthread.h (class thread_info): Update comment.
 631
 632 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
 633             Tom Tromey  <tom@tromey.com>
 634
 635         * stabsread.h (struct stab_section_list): Remove.
 636         (coffstab_build_psymtabs): Update.
 637         * dbxread.c (symbuf_sections): Now a std::vector.
 638         (sect_idx): New global.
 639         (fill_symbuf): Update.
 640         (coffstab_build_psymtabs): Change type of stabsects parameter.
 641         Update.
 642         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
 643         std::vector.
 644         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
 645         (coff_locate_sections): Update.
 646         (coff_symfile_read): Remove cleanups.  Update.
 647         (init_stringtab): Add storage parameter.
 648         (free_stringtab, free_stringtab_cleanup): Remove.
 649         (init_lineno): Add storage parameter.
 650         (free_linetab, free_linetab_cleanup): Remove.
 651
 652 2019-03-06  Pedro Alves  <palves@redhat.com>
 653
 654         * linux-fork.c (fork_info::clobber_regs): Delete.
 655         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
 656         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
 657         comment.  Adjust.
 658         (scoped_switch_fork_info::scoped_switch_fork_info)
 659         (checkpoint_command, linux_fork_context): Adjust
 660         fork_save_infrun_state calls.
 661
 662 2019-03-06  Pedro Alves  <palves@redhat.com>
 663
 664         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
 665         (inf_has_multiple_threads): Return 'bool' and rewrite using
 666         inferior_info::threads().
 667
 668 2019-03-06  Pedro Alves  <palves@redhat.com>
 669
 670         * linux-fork.c: Include <list>.
 671         (fork_list): Now a std::list instance.
 672         (fork_info): Add ctor, dtor, and in-class initialize all fields.
 673         (forks_exist_p, find_last_fork): Adjust.
 674         (new_fork): Delete.
 675         (one_fork_p): New.
 676         (add_fork): Adjust.
 677         (free_fork): Delete, folded into fork_info::~fork_info().
 678         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
 679         Adjust.
 680         (init_fork_list): Delete.
 681         (linux_fork_killall, linux_fork_mourn_inferior)
 682         (linux_fork_detach, info_checkpoints_command): Adjust.
 683         (_initialize_linux_fork): No longer call init_fork_list.
 684
 685 2019-03-06  Pedro Alves  <palves@redhat.com>
 686
 687         * linux-fork.c (new_fork): New, split out of ...
 688         (add_fork): ... this.  Return void.  Move "first fork" special
 689         case from here, to ...
 690         (checkpoint_command): ... here.
 691         * linux-linux.h (add_fork): Return void.
 692
 693 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 694
 695         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
 696
 697 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 698             Chris January  <chris.january@arm.com>
 699             David Lecomber  <david.lecomber@arm.com>
 700
 701         * f-exp.y: New token, UNOP_INTRINSIC.
 702         (exp): New pattern using UNOP_INTRINSIC token.
 703         (f77_keywords): Add 'abs' keyword.
 704         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
 705         (value_from_host_double): New function.
 706         (evaluate_subexp_f): Support UNOP_ABS.
 707
 708 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 709
 710         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
 711         types.
 712
 713 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 714
 715         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
 716         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
 717         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
 718
 719 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 720
 721         * f-exp.y (convert_to_kind_type): Handle more type kinds.
 722
 723 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 724             Chris January  <chris.january@arm.com>
 725
 726         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
 727         * f-exp.y: Define 'KIND' token.
 728         (exp): New pattern for KIND expressions.
 729         (ptype): Handle types with a kind extension.
 730         (direct_abs_decl): Extend to spot kind extensions.
 731         (f77_keywords): Add 'kind' to the list.
 732         (push_kind_type): New function.
 733         (convert_to_kind_type): New function.
 734         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
 735         * parse.c (operator_length_standard): Likewise.
 736         * parser-defs.h (enum type_pieces): Add tp_kind.
 737         * std-operator.def: Add UNOP_KIND.
 738
 739 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 740
 741         * f-exp.y (f_parse): Set yydebug.
 742
 743 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 744
 745         * f-lang.c (evaluate_subexp_f): New function.
 746         (exp_descriptor_f): New global.
 747         (f_language_defn): Use exp_descriptor_f instead of
 748         exp_descriptor_standard.
 749
 750 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 751
 752         * f-exp.y (struct token): Add comments.
 753         (dot_ops): Remove uppercase versions and the end marker.
 754         (f77_keywords): Likewise.
 755         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
 756         entries in the dot_ops array are case insensitive, and use
 757         strncasecmp to compare strings.  Also some whitespace cleanup in
 758         this area.  Similar for the f77_keywords array, except entries in
 759         this list might be case sensitive.
 760
 761 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 762
 763         * f-exp.y (struct f77_boolean_val): Add comments.
 764         (boolean_values): Remove uppercase versions, and end marker.
 765         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
 766         and use strncasecmp to achieve case insensitivity.  Additionally,
 767         perform whitespace cleanup around this code.
 768
 769 2019-03-06  Tom Tromey  <tromey@adacore.com>
 770
 771         * remote-sim.c (gdbsim_target_open): Use result of
 772         gdb_argv::release.
 773
 774 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
 775         Dirk Schubert  <dirk.schubert@arm.com>
 776         Chris January  <chris.january@arm.com>
 777
 778         * eval.c (evaluate_subexp_standard): Call Fortran argument
 779         wrapping logic.
 780         * f-lang.c (struct value): A value which can be passed into a
 781         Fortran function call.
 782         (fortran_argument_convert): Wrap Fortran arguments in a pointer
 783         where appropriate.
 784         (struct type): Value ready for a Fortran function call.
 785         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
 786         is needed.
 787         * f-lang.h (fortran_argument_convert): Declaration.
 788         (fortran_preserve_arg_pointer): Declaration.
 789         * infcall.c (value_arg_coerce): Call Fortran argument logic.
 790
 791 2019-03-05  Tom Tromey  <tromey@adacore.com>
 792
 793         * python/py-prettyprint.c (print_string_repr): Remove #if.
 794         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
 795
 796 2019-03-05  Tom Tromey  <tromey@adacore.com>
 797
 798         * target.c (the_dummy_target): Move later.  Change type to
 799         "dummy_target".
 800         (initialize_targets): Don't initialize the_dummy_target.
 801
 802 2019-03-05  Tom Tromey  <tromey@adacore.com>
 803
 804         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
 805         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
 806
 807 2019-03-05  Tom Tromey  <tromey@adacore.com>
 808
 809         * windows-nat.c (windows_nat_target::attach)
 810         (windows_nat_target::detach): Don't call gdb_flush.
 811         * valprint.c (generic_val_print, val_print, val_print_string):
 812         Don't call gdb_flush.
 813         * utils.c (defaulted_query): Don't call gdb_flush.
 814         * typeprint.c (print_type_scalar): Don't call gdb_flush.
 815         * target.c (target_announce_detach): Don't call gdb_flush.
 816         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
 817         * remote.c (extended_remote_target::attach): Don't call
 818         gdb_flush.
 819         * procfs.c (procfs_target::detach): Don't call gdb_flush.
 820         * printcmd.c (do_examine): Don't call gdb_flush.
 821         (info_display_command): Don't call gdb_flush.
 822         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
 823         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
 824         * memattr.c (info_mem_command): Don't call gdb_flush.
 825         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
 826         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
 827         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
 828         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
 829         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
 830         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
 831         (gnu_nat_target::detach): Don't call gdb_flush.
 832         * f-valprint.c (f_val_print): Don't call gdb_flush.
 833         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
 834         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
 835         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
 836         gdb_flush.
 837         * c-valprint.c (c_val_print): Don't call gdb_flush.
 838         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
 839
 840 2019-03-05  Tom Tromey  <tromey@adacore.com>
 841
 842         * varobj.c (update_dynamic_varobj_children): Update.
 843         (install_default_visualizer): Use reset, not release.
 844         * value.c (set_internalvar): Update.
 845         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
 846         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
 847         ATTRIBUTE_UNUSED_RESULT.
 848
 849 2019-03-05  Tom Tromey  <tromey@adacore.com>
 850
 851         * remote.c (class scoped_remote_fd) <release>: Add
 852         ATTRIBUTE_UNUSED_RESULT.
 853
 854 2019-03-05  Tom Tromey  <tromey@adacore.com>
 855
 856         * macroexp.c (struct macro_buffer) <release>: Add
 857         ATTRIBUTE_UNUSED_RESULT.
 858
 859 2019-03-05  Tom Tromey  <tromey@adacore.com>
 860
 861         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
 862         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
 863         ATTRIBUTE_UNUSED_RESULT.
 864
 865 2019-03-05  Tom Tromey  <tromey@adacore.com>
 866
 867         * common/scoped_fd.h (class scoped_fd) <release>: Add
 868         ATTRIBUTE_UNUSED_RESULT.
 869
 870 2019-03-05  Tom Tromey  <tromey@adacore.com>
 871
 872         * parser-defs.h (struct parser_state) <release>: Add
 873         ATTRIBUTE_UNUSED_RESULT.
 874
 875 2019-03-05  Tom Tromey  <tromey@adacore.com>
 876
 877         * utils.h (class gdb_argv) <release>: Add
 878         ATTRIBUTE_UNUSED_RESULT.
 879         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
 880
 881 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
 882
 883         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
 884         for-loop range, to avoid compiler warnings.
 885
 886         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
 887         avoid compiler warnings about unused variables.
 888
 889         * NEWS: Mention end of support for native debugging on MS-Windows
 890         before XP.
 891
 892         PR gdb/24292
 893         * common/netstuff.c:
 894         * gdbserver/gdbreplay.c
 895         * gdbserver/remote-utils.c:
 896         * ser-tcp.c:
 897         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
 898         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
 899         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
 900         'getaddrinfo' and 'freeaddrinfo' were not available before
 901         Windows XP, and mingw.org's MinGW headers by default define
 902         _WIN32_WINNT to 0x500.
 903
 904 2019-03-01  Gary Benson <gbenson@redhat.com>
 905
 906         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
 907
 908 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
 909             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 910
 911         PR gdb/8527
 912         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
 913         set_sigint_trap, clear_sigint_trap.
 914
 915 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 916
 917         * target.c (target_detach): Clear the regcache and the
 918         frame cache.
 919
 920 2019-02-27  Pedro Alves  <palves@redhat.com>
 921
 922         * utils.c (set_screen_size): When we cap the height/width sizes,
 923         tweak the corresponding command variable to show "unlimited":
 924
 925 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
 926             Pedro Alves  <palves@redhat.com>
 927
 928         * utils.c (set_screen_size): Reduce "infinite" rows and columns
 929         before calling rl_set_screen_size.
 930
 931 2019-02-27  Tom Tromey  <tromey@adacore.com>
 932
 933         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
 934         define.
 935         * python/py-value.c: Remove Python 2.4 workaround.
 936         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
 937         workaround.
 938         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
 939         Python 2.4 workaround.
 940         * python/python-internal.h: Remove Python 2.4 comment.
 941         (Py_ssize_t): Don't define.
 942         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
 943         (gdb_Py_DECREF): Remove Python 2.4 workaround.
 944         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
 945         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
 946         * python/python.c (do_start_initialization): Remove Python 2.4
 947         workaround.
 948         * python/py-prettyprint.c (class dummy_python_frame): Remove.
 949         (print_children): Remove Python 2.4 workaround.
 950         * python/py-inferior.c (buffer_procs): Remove Python 2.4
 951         workaround.
 952         (CHARBUFFERPROC_NAME): Remove.
 953         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
 954         Python 2.4 workaround.
 955
 956 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
 957
 958         * NEWS: Note minimum Python version.
 959
 960 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
 961
 962         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
 963         code from these functions.  Remove corresponding ifdefs.  Use
 964         Py_buffer_up instead of explicit calls to PyBuffer_Release.
 965         Remove gotos and target of gotos.
 966         (infpy_search_memory): Likewise.
 967
 968 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 969
 970         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
 971         (hppa_gdbarch_init): Don't register deleted functions with
 972         gdbarch.
 973
 974 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 975
 976         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
 977         (h8300_unwind_sp): Delete.
 978         (h8300_dummy_id): Delete.
 979         (h8300_gdbarch_init): Don't register deleted functions with
 980         gdbarch.
 981
 982 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 983
 984         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
 985         (ft32_unwind_pc): Delete.
 986         (ft32_unwind_sp): Delete.
 987         (ft32_gdbarch_init): Don't register deleted functions with
 988         gdbarch.
 989
 990 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 991
 992         * gdb/frv-tdep.c (frv_dummy_id): Delete.
 993         (frv_unwind_pc): Delete.
 994         (frv_unwind_sp): Delete.
 995         (frv_gdbarch_init): Don't register deleted functions with
 996         gdbarch.
 997
 998 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 999
1000         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
1001         (riscv_unwind_pc): Delete.
1002         (riscv_unwind_sp): Delete.
1003         (riscv_gdbarch_init): Don't register deleted functions with
1004         gdbarch.
1005
1006 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1007
1008         * gdb/csky-tdep.c (csky_dummy_id): Delete.
1009         (csky_unwind_pc): Delete.
1010         (csky_unwind_sp): Delete.
1011         (csky_gdbarch_init): Don't register deleted functions with
1012         gdbarch.
1013
1014 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1015
1016         * gdb/cris-tdep.c (cris_dummy_id): Delete.
1017         (cris_unwind_pc): Delete.
1018         (cris_unwind_sp): Delete.
1019         (cris_gdbarch_init): Don't register deleted functions with
1020         gdbarch.
1021
1022 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1023
1024         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
1025         (bfin_unwind_pc): Delete.
1026         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
1027
1028 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1029
1030         * gdb/arm-tdep.c (arm_dummy_id): Delete.
1031         (arm_unwind_pc): Delete.
1032         (arm_unwind_sp): Delete.
1033         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
1034
1035 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1036
1037         * gdb/arc-tdep.c (arc_dummy_id): Delete.
1038         (arc_unwind_pc): Delete.
1039         (arc_unwind_sp): Delete.
1040         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
1041
1042 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1043
1044         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
1045         (alpha_unwind_pc): Delete.
1046         (alpha_gdbarch_init): Don't register deleted functions with
1047         gdbarch.
1048
1049 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1050
1051         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
1052         (aarch64_unwind_pc): Delete.
1053         (aarch64_unwind_sp): Delete.
1054         (aarch64_gdbarch_init): Don't register deleted functions with
1055         gdbarch.
1056
1057 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1058
1059         * gdbtypes.c (type_align): Don't consider static members when
1060         computing structure alignment.
1061
1062 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1063
1064         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
1065         return 0 for other types.
1066         * arch-utils.c (default_type_align): Always return 0.
1067         * gdbarch.h: Regenerate.
1068         * gdbarch.sh (type_align): Extend comment.
1069         * gdbtypes.c (type_align): Add additional comments, always call
1070         gdbarch_type_align before applying the default rules.
1071         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
1072         generic code will then apply a suitable default.
1073         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
1074         types, return 0 for other types.
1075
1076 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1077
1078         * NEWS: Create a new section for the next release branch.
1079         Rename the section of the current branch, now that it has
1080         been cut.
1081
1082 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1083
1084         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
1085         * version.in: Bump version to 8.3.50.DATE-git.
1086
1087 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
1088
1089         * aix-thread.c (ptid_cmp): Remove unused variable.
1090         (get_signaled_thread): Likewise.
1091         (store_regs_user_thread): Likewise.
1092         (store_regs_kernel_thread): Likewise.
1093         (fetch_regs_kernel_thread): Remove shadowed variable.
1094
1095 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1096
1097         * features/riscv/32bit-cpu.xml: Add register numbers.
1098         * features/riscv/32bit-fpu.c: Regenerate.
1099         * features/riscv/32bit-fpu.xml: Add register numbers.
1100         * features/riscv/64bit-cpu.xml: Add register numbers.
1101         * features/riscv/64bit-fpu.c: Regenerate.
1102         * features/riscv/64bit-fpu.xml: Add register numbers.
1103
1104 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
1105
1106         * NEWS: Mention two argument form of gdb.Value constructor.
1107         * python/py-value.c (convert_buffer_and_type_to_value): New
1108         function.
1109         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
1110         Add support for handling an optional second argument.  Call
1111         convert_buffer_and_type_to_value as appropriate.
1112         * python/python-internal.h (Py_buffer_deleter): New struct.
1113         (Py_buffer_up): New typedef.
1114
1115 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
1116
1117         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
1118         instead of releasing ownership.
1119
1120 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
1121
1122         * dwarf2read.c (open_and_init_dwp_file): Call
1123         elf_numsections instead of bfd_count_sections to initialize
1124         dwp_file->num_sections.
1125
1126 2019-02-25  Tom Tromey  <tromey@adacore.com>
1127
1128         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
1129
1130 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1131
1132         * gcore.in: Add '--readnever' option when invoking GDB.
1133
1134 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1135
1136         * MAINTAINERS: Update my email address.
1137
1138 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1139
1140         * build-id.c (build_id_to_debug_bfd_1): New function.
1141         (build_id_to_debug_bfd): Look for separate debug file in
1142         sysroot.
1143
1144 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1145
1146         * gdbarch.sh: Update the copyright year range that is placed into
1147         generated files.
1148
1149 2019-02-22  Keith Seitz  <keiths@redhat.com>
1150
1151         PR symtab/23853
1152         * linespec.c (create_sals_line_offset): Search for the default
1153         symtab's filename instead of its fullname.
1154
1155 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1156
1157         * NEWS: Update style defaults.
1158
1159 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1160
1161         * main.c (captured_main_1): Disable styling in batch mode.
1162
1163 2019-02-20  Tom Tromey  <tom@tromey.com>
1164
1165         * symtab.c (symtab_symbol_info): Fix typos.
1166
1167 2019-02-20  Tom Tromey  <tromey@adacore.com>
1168
1169         * findcmd.c (_initialize_mem_search): Use upper case for
1170         metasyntactic variables.
1171
1172 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
1173
1174         * aarch64-tdep.c (aarch64_add_reggroups): New function.
1175         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
1176
1177 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
1178
1179         * top.h (source_file_name): Change to std::string.
1180         * top.c (source_file_name): Likewise.
1181         (command_line_input): Adjust.
1182         * cli/cli-script.c (script_from_file): Adjust.
1183
1184 2019-02-19  Tom Tromey  <tromey@adacore.com>
1185
1186         * ravenscar-thread.c
1187         (ravenscar_thread_target::update_thread_list): Don't call
1188         ada_build_task_list.
1189         * ada-lang.h (ada_build_task_list): Don't declare.
1190         * ada-tasks.c (struct ada_tasks_inferior_data)
1191         <task_list_valid_p>: Now bool.
1192         (read_known_tasks, ada_task_list_changed)
1193         (ada_tasks_invalidate_inferior_data): Update.
1194         (read_known_tasks_array): Return bool.
1195         (read_known_tasks_list): Likewise.
1196         (read_known_tasks): Return void.
1197         (ada_build_task_list): Now static.
1198
1199 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1200
1201         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
1202         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
1203
1204 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1205
1206         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
1207         variant for ada_tasks_pspace_data_handle and
1208         ada_tasks_inferior_data_handle.
1209         (ada_tasks_pspace_data_cleanup): New function.
1210         (ada_tasks_inferior_data_cleanup): New function.
1211
1212 2019-02-17  Tom Tromey  <tom@tromey.com>
1213
1214         * macrotab.h (macro_source_fullname): Return a std::string.
1215         * macrotab.c (macro_include, check_for_redefinition)
1216         (macro_undef, macro_lookup_definition, foreach_macro)
1217         (foreach_macro_in_scope): Update.
1218         (macro_source_fullname): Return a std::string.
1219         * macrocmd.c (show_pp_source_pos): Update.
1220
1221 2019-02-17  Tom Tromey  <tom@tromey.com>
1222
1223         * macrocmd.c (show_pp_source_pos): Style the file names.
1224
1225 2019-02-17  Tom Tromey  <tom@tromey.com>
1226
1227         PR tui/24197:
1228         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
1229
1230 2019-02-17  Tom Tromey  <tom@tromey.com>
1231
1232         * ada-lang.c (user_select_syms): Use filtered printing.
1233         * utils.c (wrap_style): New global.
1234         (desired_style): Remove.
1235         (emit_style_escape): Add stream parameter.
1236         (set_output_style, reset_terminal_style, prompt_for_continue):
1237         Update.
1238         (flush_wrap_buffer): Only flush gdb_stdout.
1239         (wrap_here): Set wrap_style.
1240         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
1241         treat escape sequences as a character.  Change when wrap buffer is
1242         flushed.
1243         (fputs_styled): Do not set the output style when the default is
1244         requested.
1245         * ui-style.h (struct ui_file_style) <is_default>: New method.
1246         * source.c (print_source_lines_base): Emit escape sequences in one
1247         piece.
1248
1249 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1250
1251         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
1252         integers and enumeration types.
1253
1254 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1255
1256         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
1257         instead of lookup_symbol_in_language
1258         (do_exact_match): New function.
1259         (ada_get_symbol_name_matcher): Return do_exact_match when
1260         doing a verbatim match.
1261
1262 2019-02-15  Tom Tromey  <tromey@adacore.com>
1263
1264         * ravenscar-thread.c (ravenscar_thread_target::resume)
1265         (ravenscar_thread_target::wait): Special case wildcard requests.
1266
1267 2019-02-15  Tom Tromey  <tromey@adacore.com>
1268
1269         * ravenscar-thread.c (base_ptid): Remove.
1270         (struct ravenscar_thread_target) <close>: New method.
1271         <m_base_ptid>: New member.
1272         <update_inferior_ptid, active_task, task_is_currently_active,
1273         runtime_initialized>: Declare methods.
1274         <ravenscar_thread_target>: Add constructor.
1275         (ravenscar_thread_target::task_is_currently_active)
1276         (ravenscar_thread_target::update_inferior_ptid)
1277         (ravenscar_runtime_initialized): Rename.  Now methods.
1278         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
1279         (ravenscar_thread_target::update_thread_list): Update.
1280         (ravenscar_thread_target::active_task): Now method.
1281         (ravenscar_thread_target::store_registers)
1282         (ravenscar_thread_target::prepare_to_store)
1283         (ravenscar_thread_target::prepare_to_store)
1284         (ravenscar_thread_target::mourn_inferior): Update.
1285         (ravenscar_inferior_created): Use "new" to create target.
1286         (ravenscar_thread_target::get_ada_task_ptid): Update.
1287         (_initialize_ravenscar): Don't initialize base_ptid.
1288         (ravenscar_ops): Remove global.
1289
1290 2019-02-15  Tom Tromey  <tromey@adacore.com>
1291
1292         * target.h (push_target): Declare new overload.
1293         * target.c (push_target): New overload, taking an rvalue reference.
1294         * remote.c (remote_target::open_1): Use push_target overload.
1295         * corelow.c (core_target_open): Use push_target overload.
1296
1297 2019-02-15  Tom Tromey  <tromey@adacore.com>
1298
1299         * ravenscar-thread.c (is_ravenscar_task)
1300         (ravenscar_task_is_currently_active): Return bool.
1301         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
1302         (_initialize_ravenscar): Remove "(void)".
1303         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
1304         Return bool.
1305
1306 2019-02-15  Tom Tromey  <tromey@adacore.com>
1307
1308         * ravenscar-thread.c (ravenscar_runtime_initializer)
1309         (has_ravenscar_runtime, get_running_thread_id)
1310         (ravenscar_thread_target::resume): Fix indentation.
1311
1312 2019-02-15  Tom Tromey  <tromey@adacore.com>
1313
1314         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
1315         from ravenscar_arch_ops.
1316         (sparc_ravenscar_ops::fetch_registers)
1317         (sparc_ravenscar_ops::store_registers): Now methods.
1318         (sparc_ravenscar_prepare_to_store): Remove.
1319         (sparc_ravenscar_ops): Redefine.
1320         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
1321         methods and destructor.  Remove members.
1322         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
1323         (ravenscar_thread_target::store_registers)
1324         (ravenscar_thread_target::prepare_to_store): Update.
1325         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
1326         Remove.
1327         (struct ppc_ravenscar_powerpc_ops): Derive from
1328         ravenscar_arch_ops.
1329         (ppc_ravenscar_powerpc_ops::fetch_registers)
1330         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
1331         (ppc_ravenscar_powerpc_ops): Redefine.
1332         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
1333         (ppc_ravenscar_e500_ops::fetch_registers)
1334         (ppc_ravenscar_e500_ops::store_registers): Now methods.
1335         (ppc_ravenscar_e500_ops): Redefine.
1336         * aarch64-ravenscar-thread.c
1337         (aarch64_ravenscar_generic_prepare_to_store): Remove.
1338         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
1339         (aarch64_ravenscar_fetch_registers)
1340         (aarch64_ravenscar_store_registers): Now methods.
1341         (aarch64_ravenscar_ops): Redefine.
1342
1343 2019-02-15  Tom Tromey  <tromey@adacore.com>
1344
1345         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
1346         (ravenscar_thread_target::stopped_by_hw_breakpoint)
1347         (ravenscar_thread_target::stopped_by_watchpoint)
1348         (ravenscar_thread_target::stopped_data_address)
1349         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
1350
1351 2019-02-15  Tom Tromey  <tromey@adacore.com>
1352
1353         * ravenscar-thread.c: Fix some typos.
1354
1355 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1356             Tom Tromey  <tromey@adacore.com>
1357
1358         * ada-lang.c (ada_exception_sal): Change addr_string to a
1359         std::string.
1360         (create_ada_exception_catchpoint): Update.
1361
1362 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1363             Tom Tromey  <tromey@adacore.com>
1364
1365         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
1366         (bp_location_ops): Remove.
1367         (base_breakpoint_allocate_location): Update.
1368         (free_bp_location): Update.
1369         * ada-lang.c (class ada_catchpoint_location)
1370         <ada_catchpoint_location>: Remove ops parameter.
1371         (ada_catchpoint_location_dtor): Remove.
1372         (ada_catchpoint_location_ops): Remove.
1373         (allocate_location_exception): Update.
1374         * breakpoint.h (struct bp_location_ops): Remove.
1375         (class bp_location) <bp_location>: Remove bp_location_ops
1376         parameter.
1377         <~bp_location>: Add destructor.
1378         <ops>: Remove.
1379
1380 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1381             Pedro Alves  <palves@redhat.com>
1382
1383         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
1384         'PATH_MAX'.
1385
1386 2019-02-14  David Michael  <fedora.dm0@gmail.com>
1387             Samuel Thibault  <samuel.thibault@gnu.org>
1388             Thomas Schwinge  <thomas@codesourcery.com>
1389
1390         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
1391         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
1392
1393 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1394
1395         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
1396         (check_empty): Use "const char *".
1397
1398         * gnu-nat.c (gnu_nat_target::detach): Instead of
1399         'detach_inferior (pid)' call
1400         'detach_inferior (find_inferior_pid (pid))'.
1401
1402         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
1403         'nat/fork-inferior.o'.
1404         * gnu-nat.c: #include "nat/fork-inferior.h".
1405
1406         * gnu-nat.c (gnu_nat_target::detach): Instead of
1407         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
1408         * gnu-nat.h: #include "inf-child.h".
1409         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
1410         'i386_gnu_nat_target::fetch_registers'.
1411         (gnu_store_registers): Rename/move to
1412         'i386_gnu_nat_target::store_registers'.
1413
1414         * config/i386/nm-i386gnu.h: Don't "#include" any files.
1415         * gnu-nat.h (mach_thread_info): New function.
1416         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
1417
1418         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
1419
1420 2019-02-14  Frederic Konrad  <konrad@adacore.com>
1421
1422         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
1423
1424 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
1425
1426         * windows-nat.c (windows_add_thread): Add new parameter
1427         "main_thread_p" with default value set to false.  Update
1428         function documentation as well as all callers.
1429         (windows_delete_thread): Likewise.
1430         (fake_create_process): Update call to windows_add_thread.
1431         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
1432         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
1433         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
1434         call to windows_delete_thread.
1435
1436 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
1437
1438         * MAINTAINERS: Add Andrew Burgess as global maintainer.
1439
1440 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1441
1442         * symfile.c (find_separate_debug_file): Use canonical path of
1443         sysroot with child_path instead of gdb_sysroot if it is valid.
1444
1445 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1446
1447         * symfile.c (find_separate_debug_file): Use child_path to
1448         determine if an object file is under a sysroot.
1449
1450 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1451
1452         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1453         unittests/child-path-selftests.c.
1454         * common/pathstuff.c (child_path): New function.
1455         * common/pathstuff.h (child_path): New prototype.
1456         * unittests/child-path-selftests.c: New file.
1457
1458 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1459
1460         * symfile.c (find_separate_debug_file): Look for separate debug
1461         files in debug directories under the sysroot.
1462
1463 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1464
1465         * symtab.h (struct minimal_symbol data_p): New const method.
1466         (struct minimal_symbol text_p): Likewise.
1467         * symtab.c (output_source_filename): Use file name style
1468         to print file name.
1469         (print_symbol_info): Likewise.
1470         (print_msymbol_info): Use address style to print addresses.
1471         Use function name style to print executable text symbols.
1472         (expand_symtab_containing_pc): Use data_p.
1473         (find_pc_sect_compunit_symtab): Likewise.
1474
1475 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1476
1477         * breakpoint.c (describe_other_breakpoints): Use address style
1478         to print addresses.
1479         (say_where): Likewise.
1480
1481 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1482
1483         * ada-typeprint.c (print_func_type): Print function name
1484         style to print function name.
1485         * c-typeprint.c (c_print_type_1): Likewise.
1486
1487 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
1488
1489         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
1490         for execve.
1491
1492 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1493
1494         * c-exp.y (direct_abs_decl): Use emplace_back to record the
1495         type_stack.
1496
1497 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
1498
1499         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
1500         TYPE_CODE_REF types.
1501
1502 2019-02-08  Jim Wilson  <jimw@sifive.com>
1503
1504         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
1505         (riscv_linux_fregset): New.
1506         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
1507
1508 2019-02-07  Tom Tromey  <tom@tromey.com>
1509
1510         * thread.c (thread_cancel_execution_command): Update.
1511         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
1512         methods.
1513         (struct thread_fsm_ops): Remove.
1514         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
1515         (thread_fsm_should_stop, thread_fsm_return_value)
1516         (thread_fsm_set_finished, thread_fsm_finished_p)
1517         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
1518         Don't declare.
1519         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
1520         * infrun.c (clear_proceed_status_thread)
1521         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
1522         (print_stop_event): Update.
1523         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
1524         Add constructor.
1525         (step_command_fsm_ops): Remove.
1526         (new_step_command_fsm): Remove.
1527         (step_1): Update.
1528         (step_command_fsm::should_stop): Rename from
1529         step_command_fsm_should_stop.
1530         (step_command_fsm::clean_up): Rename from
1531         step_command_fsm_clean_up.
1532         (step_command_fsm::do_async_reply_reason): Rename from
1533         step_command_fsm_async_reply_reason.
1534         (struct until_next_fsm): Inherit from thread_fsm.  Add
1535         constructor.
1536         (until_next_fsm_ops): Remove.
1537         (new_until_next_fsm): Remove.
1538         (until_next_fsm::should_stop): Rename from
1539         until_next_fsm_should_stop.
1540         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
1541         (until_next_fsm::do_async_reply_reason): Rename from
1542         until_next_fsm_async_reply_reason.
1543         (struct finish_command_fsm): Inherit from thread_fsm.  Add
1544         constructor.  Change type of breakpoint.
1545         (finish_command_fsm_ops): Remove.
1546         (new_finish_command_fsm): Remove.
1547         (finish_command_fsm::should_stop): Rename from
1548         finish_command_fsm_should_stop.
1549         (finish_command_fsm::clean_up): Rename from
1550         finish_command_fsm_clean_up.
1551         (finish_command_fsm::return_value): Rename from
1552         finish_command_fsm_return_value.
1553         (finish_command_fsm::do_async_reply_reason): Rename from
1554         finish_command_fsm_async_reply_reason.
1555         (finish_command): Update.
1556         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
1557         Add constructor.
1558         (call_thread_fsm_ops): Remove.
1559         (call_thread_fsm::call_thread_fsm): Rename from
1560         new_call_thread_fsm.
1561         (call_thread_fsm::should_stop): Rename from
1562         call_thread_fsm_should_stop.
1563         (call_thread_fsm::should_notify_stop): Rename from
1564         call_thread_fsm_should_notify_stop.
1565         (run_inferior_call, call_function_by_hand_dummy): Update.
1566         * cli/cli-interp.c (should_print_stop_to_console): Update.
1567         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
1568         Add constructor.  Change type of location_breakpoint,
1569         caller_breakpoint.
1570         (until_break_fsm_ops): Remove.
1571         (new_until_break_fsm): Remove.
1572         (until_break_fsm::should_stop): Rename from
1573         until_break_fsm_should_stop.
1574         (until_break_fsm::clean_up): Rename from
1575         until_break_fsm_clean_up.
1576         (until_break_fsm::do_async_reply_reason): Rename from
1577         until_break_fsm_async_reply_reason.
1578         (until_break_command): Update.
1579         * thread-fsm.c: Remove.
1580         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
1581
1582 2019-02-07  Tom Tromey  <tom@tromey.com>
1583
1584         * yy-remap.h: Add include guard.
1585         * xtensa-tdep.h: Add include guard.
1586         * xcoffread.h: Rename include guard.
1587         * varobj-iter.h: Add include guard.
1588         * tui/tui.h: Rename include guard.
1589         * tui/tui-winsource.h: Rename include guard.
1590         * tui/tui-wingeneral.h: Rename include guard.
1591         * tui/tui-windata.h: Rename include guard.
1592         * tui/tui-win.h: Rename include guard.
1593         * tui/tui-stack.h: Rename include guard.
1594         * tui/tui-source.h: Rename include guard.
1595         * tui/tui-regs.h: Rename include guard.
1596         * tui/tui-out.h: Rename include guard.
1597         * tui/tui-layout.h: Rename include guard.
1598         * tui/tui-io.h: Rename include guard.
1599         * tui/tui-hooks.h: Rename include guard.
1600         * tui/tui-file.h: Rename include guard.
1601         * tui/tui-disasm.h: Rename include guard.
1602         * tui/tui-data.h: Rename include guard.
1603         * tui/tui-command.h: Rename include guard.
1604         * tic6x-tdep.h: Add include guard.
1605         * target/waitstatus.h: Rename include guard.
1606         * target/wait.h: Rename include guard.
1607         * target/target.h: Rename include guard.
1608         * target/resume.h: Rename include guard.
1609         * target-float.h: Rename include guard.
1610         * stabsread.h: Add include guard.
1611         * rs6000-tdep.h: Add include guard.
1612         * riscv-fbsd-tdep.h: Add include guard.
1613         * regformats/regdef.h: Rename include guard.
1614         * record.h: Rename include guard.
1615         * python/python.h: Rename include guard.
1616         * python/python-internal.h: Rename include guard.
1617         * python/py-stopevent.h: Rename include guard.
1618         * python/py-ref.h: Rename include guard.
1619         * python/py-record.h: Rename include guard.
1620         * python/py-record-full.h: Rename include guard.
1621         * python/py-record-btrace.h: Rename include guard.
1622         * python/py-instruction.h: Rename include guard.
1623         * python/py-events.h: Rename include guard.
1624         * python/py-event.h: Rename include guard.
1625         * procfs.h: Add include guard.
1626         * proc-utils.h: Add include guard.
1627         * p-lang.h: Add include guard.
1628         * or1k-tdep.h: Rename include guard.
1629         * observable.h: Rename include guard.
1630         * nto-tdep.h: Rename include guard.
1631         * nat/x86-linux.h: Rename include guard.
1632         * nat/x86-linux-dregs.h: Rename include guard.
1633         * nat/x86-gcc-cpuid.h: Add include guard.
1634         * nat/x86-dregs.h: Rename include guard.
1635         * nat/x86-cpuid.h: Rename include guard.
1636         * nat/ppc-linux.h: Rename include guard.
1637         * nat/mips-linux-watch.h: Rename include guard.
1638         * nat/linux-waitpid.h: Rename include guard.
1639         * nat/linux-ptrace.h: Rename include guard.
1640         * nat/linux-procfs.h: Rename include guard.
1641         * nat/linux-osdata.h: Rename include guard.
1642         * nat/linux-nat.h: Rename include guard.
1643         * nat/linux-namespaces.h: Rename include guard.
1644         * nat/linux-btrace.h: Rename include guard.
1645         * nat/glibc_thread_db.h: Rename include guard.
1646         * nat/gdb_thread_db.h: Rename include guard.
1647         * nat/gdb_ptrace.h: Rename include guard.
1648         * nat/fork-inferior.h: Rename include guard.
1649         * nat/amd64-linux-siginfo.h: Rename include guard.
1650         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
1651         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
1652         * nat/aarch64-linux.h: Rename include guard.
1653         * nat/aarch64-linux-hw-point.h: Rename include guard.
1654         * mn10300-tdep.h: Add include guard.
1655         * mips-linux-tdep.h: Add include guard.
1656         * mi/mi-parse.h: Rename include guard.
1657         * mi/mi-out.h: Rename include guard.
1658         * mi/mi-main.h: Rename include guard.
1659         * mi/mi-interp.h: Rename include guard.
1660         * mi/mi-getopt.h: Rename include guard.
1661         * mi/mi-console.h: Rename include guard.
1662         * mi/mi-common.h: Rename include guard.
1663         * mi/mi-cmds.h: Rename include guard.
1664         * mi/mi-cmd-break.h: Rename include guard.
1665         * m2-lang.h: Add include guard.
1666         * location.h: Rename include guard.
1667         * linux-record.h: Rename include guard.
1668         * linux-nat.h: Add include guard.
1669         * linux-fork.h: Add include guard.
1670         * i386-darwin-tdep.h: Rename include guard.
1671         * hppa-linux-offsets.h: Add include guard.
1672         * guile/guile.h: Rename include guard.
1673         * guile/guile-internal.h: Rename include guard.
1674         * gnu-nat.h: Rename include guard.
1675         * gdb-stabs.h: Rename include guard.
1676         * frv-tdep.h: Add include guard.
1677         * f-lang.h: Add include guard.
1678         * event-loop.h: Add include guard.
1679         * darwin-nat.h: Rename include guard.
1680         * cp-abi.h: Rename include guard.
1681         * config/sparc/nm-sol2.h: Rename include guard.
1682         * config/nm-nto.h: Rename include guard.
1683         * config/nm-linux.h: Add include guard.
1684         * config/i386/nm-i386gnu.h: Rename include guard.
1685         * config/djgpp/nl_types.h: Rename include guard.
1686         * config/djgpp/langinfo.h: Rename include guard.
1687         * compile/gcc-cp-plugin.h: Add include guard.
1688         * compile/gcc-c-plugin.h: Add include guard.
1689         * compile/compile.h: Rename include guard.
1690         * compile/compile-object-run.h: Rename include guard.
1691         * compile/compile-object-load.h: Rename include guard.
1692         * compile/compile-internal.h: Rename include guard.
1693         * compile/compile-cplus.h: Rename include guard.
1694         * compile/compile-c.h: Rename include guard.
1695         * common/xml-utils.h: Rename include guard.
1696         * common/x86-xstate.h: Rename include guard.
1697         * common/version.h: Rename include guard.
1698         * common/vec.h: Rename include guard.
1699         * common/tdesc.h: Rename include guard.
1700         * common/selftest.h: Rename include guard.
1701         * common/scoped_restore.h: Rename include guard.
1702         * common/scoped_mmap.h: Rename include guard.
1703         * common/scoped_fd.h: Rename include guard.
1704         * common/safe-iterator.h: Rename include guard.
1705         * common/run-time-clock.h: Rename include guard.
1706         * common/refcounted-object.h: Rename include guard.
1707         * common/queue.h: Rename include guard.
1708         * common/ptid.h: Rename include guard.
1709         * common/print-utils.h: Rename include guard.
1710         * common/preprocessor.h: Rename include guard.
1711         * common/pathstuff.h: Rename include guard.
1712         * common/observable.h: Rename include guard.
1713         * common/netstuff.h: Rename include guard.
1714         * common/job-control.h: Rename include guard.
1715         * common/host-defs.h: Rename include guard.
1716         * common/gdb_wait.h: Rename include guard.
1717         * common/gdb_vecs.h: Rename include guard.
1718         * common/gdb_unlinker.h: Rename include guard.
1719         * common/gdb_unique_ptr.h: Rename include guard.
1720         * common/gdb_tilde_expand.h: Rename include guard.
1721         * common/gdb_sys_time.h: Rename include guard.
1722         * common/gdb_string_view.h: Rename include guard.
1723         * common/gdb_splay_tree.h: Rename include guard.
1724         * common/gdb_setjmp.h: Rename include guard.
1725         * common/gdb_ref_ptr.h: Rename include guard.
1726         * common/gdb_optional.h: Rename include guard.
1727         * common/gdb_locale.h: Rename include guard.
1728         * common/gdb_assert.h: Rename include guard.
1729         * common/filtered-iterator.h: Rename include guard.
1730         * common/filestuff.h: Rename include guard.
1731         * common/fileio.h: Rename include guard.
1732         * common/environ.h: Rename include guard.
1733         * common/common-utils.h: Rename include guard.
1734         * common/common-types.h: Rename include guard.
1735         * common/common-regcache.h: Rename include guard.
1736         * common/common-inferior.h: Rename include guard.
1737         * common/common-gdbthread.h: Rename include guard.
1738         * common/common-exceptions.h: Rename include guard.
1739         * common/common-defs.h: Rename include guard.
1740         * common/common-debug.h: Rename include guard.
1741         * common/cleanups.h: Rename include guard.
1742         * common/buffer.h: Rename include guard.
1743         * common/btrace-common.h: Rename include guard.
1744         * common/break-common.h: Rename include guard.
1745         * cli/cli-utils.h: Rename include guard.
1746         * cli/cli-style.h: Rename include guard.
1747         * cli/cli-setshow.h: Rename include guard.
1748         * cli/cli-script.h: Rename include guard.
1749         * cli/cli-interp.h: Rename include guard.
1750         * cli/cli-decode.h: Rename include guard.
1751         * cli/cli-cmds.h: Rename include guard.
1752         * charset-list.h: Add include guard.
1753         * buildsym-legacy.h: Rename include guard.
1754         * bfin-tdep.h: Add include guard.
1755         * ax.h: Rename include guard.
1756         * arm-linux-tdep.h: Add include guard.
1757         * arm-fbsd-tdep.h: Add include guard.
1758         * arch/xtensa.h: Rename include guard.
1759         * arch/tic6x.h: Add include guard.
1760         * arch/i386.h: Add include guard.
1761         * arch/arm.h: Rename include guard.
1762         * arch/arm-linux.h: Rename include guard.
1763         * arch/arm-get-next-pcs.h: Rename include guard.
1764         * arch/amd64.h: Add include guard.
1765         * arch/aarch64-insn.h: Rename include guard.
1766         * arch-utils.h: Rename include guard.
1767         * annotate.h: Add include guard.
1768         * amd64-darwin-tdep.h: Rename include guard.
1769         * aarch64-linux-tdep.h: Add include guard.
1770         * aarch64-fbsd-tdep.h: Add include guard.
1771         * aarch32-linux-nat.h: Add include guard.
1772
1773 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1774
1775         * macrotab.c (macro_define_internal): New function that
1776         factorizes macro_define_object_internal and macro_define_function
1777         code.
1778         (macro_define_object_internal): Use macro_define_internal.
1779         (macro_define_function): Likewise.
1780
1781 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1782
1783         * macrocmd.c (extract_identifier): Return
1784         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
1785         callers.
1786
1787 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
1788
1789         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
1790
1791 2019-02-05  Tom Tromey  <tom@tromey.com>
1792
1793         * target.c (target_stack::unpush): Move assertion earlier.
1794
1795 2019-01-30  Tom Tromey  <tom@tromey.com>
1796
1797         PR python/23615:
1798         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
1799         (gdbpy_parse_and_eval): Likewise.
1800         * python/python-internal.h (gdbpy_allow_threads): New class.
1801
1802 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
1803
1804         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
1805         (aarch64_fbsd_fpregmap): Move earlier.
1806         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
1807         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1808         instead of individual calls to trad_frame_set_reg_addr.
1809         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
1810         earlier.
1811         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
1812         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1813         instead of individual calls to trad_frame_set_reg_addr.
1814
1815 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
1816
1817         * CONTRIBUTE: Replace contribution list with wiki link.
1818
1819 2019-01-25  Tom Tromey  <tom@tromey.com>
1820
1821         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
1822
1823 2019-01-25  Tom Tromey  <tom@tromey.com>
1824
1825         * xtensa-linux-nat.c: Fix common/ includes.
1826         * xml-support.h: Fix common/ includes.
1827         * xml-support.c: Fix common/ includes.
1828         * x86-linux-nat.c: Fix common/ includes.
1829         * windows-nat.c: Fix common/ includes.
1830         * varobj.h: Fix common/ includes.
1831         * varobj.c: Fix common/ includes.
1832         * value.c: Fix common/ includes.
1833         * valops.c: Fix common/ includes.
1834         * utils.c: Fix common/ includes.
1835         * unittests/xml-utils-selftests.c: Fix common/ includes.
1836         * unittests/utils-selftests.c: Fix common/ includes.
1837         * unittests/unpack-selftests.c: Fix common/ includes.
1838         * unittests/tracepoint-selftests.c: Fix common/ includes.
1839         * unittests/style-selftests.c: Fix common/ includes.
1840         * unittests/string_view-selftests.c: Fix common/ includes.
1841         * unittests/scoped_restore-selftests.c: Fix common/ includes.
1842         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
1843         * unittests/scoped_fd-selftests.c: Fix common/ includes.
1844         * unittests/rsp-low-selftests.c: Fix common/ includes.
1845         * unittests/parse-connection-spec-selftests.c: Fix common/
1846         includes.
1847         * unittests/optional-selftests.c: Fix common/ includes.
1848         * unittests/offset-type-selftests.c: Fix common/ includes.
1849         * unittests/observable-selftests.c: Fix common/ includes.
1850         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
1851         * unittests/memrange-selftests.c: Fix common/ includes.
1852         * unittests/memory-map-selftests.c: Fix common/ includes.
1853         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
1854         * unittests/function-view-selftests.c: Fix common/ includes.
1855         * unittests/environ-selftests.c: Fix common/ includes.
1856         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
1857         * unittests/common-utils-selftests.c: Fix common/ includes.
1858         * unittests/cli-utils-selftests.c: Fix common/ includes.
1859         * unittests/array-view-selftests.c: Fix common/ includes.
1860         * ui-file.c: Fix common/ includes.
1861         * tui/tui-io.c: Fix common/ includes.
1862         * tracepoint.h: Fix common/ includes.
1863         * tracepoint.c: Fix common/ includes.
1864         * tracefile-tfile.c: Fix common/ includes.
1865         * top.h: Fix common/ includes.
1866         * top.c: Fix common/ includes.
1867         * thread.c: Fix common/ includes.
1868         * target/waitstatus.h: Fix common/ includes.
1869         * target/waitstatus.c: Fix common/ includes.
1870         * target.h: Fix common/ includes.
1871         * target.c: Fix common/ includes.
1872         * target-memory.c: Fix common/ includes.
1873         * target-descriptions.c: Fix common/ includes.
1874         * symtab.h: Fix common/ includes.
1875         * symfile.c: Fix common/ includes.
1876         * stap-probe.c: Fix common/ includes.
1877         * spu-linux-nat.c: Fix common/ includes.
1878         * sparc-nat.c: Fix common/ includes.
1879         * source.c: Fix common/ includes.
1880         * solib.c: Fix common/ includes.
1881         * solib-target.c: Fix common/ includes.
1882         * ser-unix.c: Fix common/ includes.
1883         * ser-tcp.c: Fix common/ includes.
1884         * ser-pipe.c: Fix common/ includes.
1885         * ser-base.c: Fix common/ includes.
1886         * selftest-arch.c: Fix common/ includes.
1887         * s12z-tdep.c: Fix common/ includes.
1888         * rust-exp.y: Fix common/ includes.
1889         * rs6000-aix-tdep.c: Fix common/ includes.
1890         * riscv-tdep.c: Fix common/ includes.
1891         * remote.c: Fix common/ includes.
1892         * remote-notif.h: Fix common/ includes.
1893         * remote-fileio.h: Fix common/ includes.
1894         * remote-fileio.c: Fix common/ includes.
1895         * regcache.h: Fix common/ includes.
1896         * regcache.c: Fix common/ includes.
1897         * record-btrace.c: Fix common/ includes.
1898         * python/python.c: Fix common/ includes.
1899         * python/py-type.c: Fix common/ includes.
1900         * python/py-inferior.c: Fix common/ includes.
1901         * progspace.h: Fix common/ includes.
1902         * producer.c: Fix common/ includes.
1903         * procfs.c: Fix common/ includes.
1904         * proc-api.c: Fix common/ includes.
1905         * printcmd.c: Fix common/ includes.
1906         * ppc-linux-nat.c: Fix common/ includes.
1907         * parser-defs.h: Fix common/ includes.
1908         * osdata.c: Fix common/ includes.
1909         * obsd-nat.c: Fix common/ includes.
1910         * nat/x86-linux.c: Fix common/ includes.
1911         * nat/x86-linux-dregs.c: Fix common/ includes.
1912         * nat/x86-dregs.h: Fix common/ includes.
1913         * nat/x86-dregs.c: Fix common/ includes.
1914         * nat/ppc-linux.c: Fix common/ includes.
1915         * nat/mips-linux-watch.h: Fix common/ includes.
1916         * nat/mips-linux-watch.c: Fix common/ includes.
1917         * nat/linux-waitpid.c: Fix common/ includes.
1918         * nat/linux-ptrace.h: Fix common/ includes.
1919         * nat/linux-ptrace.c: Fix common/ includes.
1920         * nat/linux-procfs.c: Fix common/ includes.
1921         * nat/linux-personality.c: Fix common/ includes.
1922         * nat/linux-osdata.c: Fix common/ includes.
1923         * nat/linux-namespaces.c: Fix common/ includes.
1924         * nat/linux-btrace.h: Fix common/ includes.
1925         * nat/linux-btrace.c: Fix common/ includes.
1926         * nat/fork-inferior.c: Fix common/ includes.
1927         * nat/amd64-linux-siginfo.c: Fix common/ includes.
1928         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
1929         * nat/aarch64-linux.c: Fix common/ includes.
1930         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
1931         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
1932         * namespace.h: Fix common/ includes.
1933         * mips-linux-tdep.c: Fix common/ includes.
1934         * minsyms.c: Fix common/ includes.
1935         * mi/mi-parse.h: Fix common/ includes.
1936         * mi/mi-main.c: Fix common/ includes.
1937         * mi/mi-cmd-env.c: Fix common/ includes.
1938         * memrange.h: Fix common/ includes.
1939         * memattr.c: Fix common/ includes.
1940         * maint.h: Fix common/ includes.
1941         * maint.c: Fix common/ includes.
1942         * main.c: Fix common/ includes.
1943         * machoread.c: Fix common/ includes.
1944         * location.c: Fix common/ includes.
1945         * linux-thread-db.c: Fix common/ includes.
1946         * linux-nat.c: Fix common/ includes.
1947         * linux-fork.c: Fix common/ includes.
1948         * inline-frame.c: Fix common/ includes.
1949         * infrun.c: Fix common/ includes.
1950         * inflow.c: Fix common/ includes.
1951         * inferior.h: Fix common/ includes.
1952         * inferior.c: Fix common/ includes.
1953         * infcmd.c: Fix common/ includes.
1954         * inf-ptrace.c: Fix common/ includes.
1955         * inf-child.c: Fix common/ includes.
1956         * ia64-linux-nat.c: Fix common/ includes.
1957         * i387-tdep.c: Fix common/ includes.
1958         * i386-tdep.c: Fix common/ includes.
1959         * i386-linux-tdep.c: Fix common/ includes.
1960         * i386-linux-nat.c: Fix common/ includes.
1961         * i386-go32-tdep.c: Fix common/ includes.
1962         * i386-fbsd-tdep.c: Fix common/ includes.
1963         * i386-fbsd-nat.c: Fix common/ includes.
1964         * guile/scm-type.c: Fix common/ includes.
1965         * guile/guile.c: Fix common/ includes.
1966         * go32-nat.c: Fix common/ includes.
1967         * gnu-nat.c: Fix common/ includes.
1968         * gdbthread.h: Fix common/ includes.
1969         * gdbarch-selftests.c: Fix common/ includes.
1970         * gdb_usleep.c: Fix common/ includes.
1971         * gdb_select.h: Fix common/ includes.
1972         * gdb_bfd.c: Fix common/ includes.
1973         * gcore.c: Fix common/ includes.
1974         * fork-child.c: Fix common/ includes.
1975         * findvar.c: Fix common/ includes.
1976         * fbsd-nat.c: Fix common/ includes.
1977         * event-top.c: Fix common/ includes.
1978         * event-loop.c: Fix common/ includes.
1979         * dwarf2read.c: Fix common/ includes.
1980         * dwarf2loc.c: Fix common/ includes.
1981         * dwarf2-frame.c: Fix common/ includes.
1982         * dwarf-index-cache.c: Fix common/ includes.
1983         * dtrace-probe.c: Fix common/ includes.
1984         * disasm-selftests.c: Fix common/ includes.
1985         * defs.h: Fix common/ includes.
1986         * csky-tdep.c: Fix common/ includes.
1987         * cp-valprint.c: Fix common/ includes.
1988         * cp-support.h: Fix common/ includes.
1989         * cp-support.c: Fix common/ includes.
1990         * corelow.c: Fix common/ includes.
1991         * completer.h: Fix common/ includes.
1992         * completer.c: Fix common/ includes.
1993         * compile/compile.c: Fix common/ includes.
1994         * compile/compile-loc2c.c: Fix common/ includes.
1995         * compile/compile-cplus-types.c: Fix common/ includes.
1996         * compile/compile-cplus-symbols.c: Fix common/ includes.
1997         * command.h: Fix common/ includes.
1998         * cli/cli-dump.c: Fix common/ includes.
1999         * cli/cli-cmds.c: Fix common/ includes.
2000         * charset.c: Fix common/ includes.
2001         * build-id.c: Fix common/ includes.
2002         * btrace.h: Fix common/ includes.
2003         * btrace.c: Fix common/ includes.
2004         * breakpoint.h: Fix common/ includes.
2005         * breakpoint.c: Fix common/ includes.
2006         * ax.h:
2007         (enum agent_op): Fix common/ includes.
2008         * ax-general.c (struct aop_map): Fix common/ includes.
2009         * ax-gdb.c: Fix common/ includes.
2010         * auxv.c: Fix common/ includes.
2011         * auto-load.c: Fix common/ includes.
2012         * arm-tdep.c: Fix common/ includes.
2013         * arch/riscv.c: Fix common/ includes.
2014         * arch/ppc-linux-common.c: Fix common/ includes.
2015         * arch/i386.c: Fix common/ includes.
2016         * arch/arm.c: Fix common/ includes.
2017         * arch/arm-linux.c: Fix common/ includes.
2018         * arch/arm-get-next-pcs.c: Fix common/ includes.
2019         * arch/amd64.c: Fix common/ includes.
2020         * arch/aarch64.c: Fix common/ includes.
2021         * arch/aarch64-insn.c: Fix common/ includes.
2022         * arch-utils.c: Fix common/ includes.
2023         * amd64-windows-tdep.c: Fix common/ includes.
2024         * amd64-tdep.c: Fix common/ includes.
2025         * amd64-sol2-tdep.c: Fix common/ includes.
2026         * amd64-obsd-tdep.c: Fix common/ includes.
2027         * amd64-nbsd-tdep.c: Fix common/ includes.
2028         * amd64-linux-tdep.c: Fix common/ includes.
2029         * amd64-linux-nat.c: Fix common/ includes.
2030         * amd64-fbsd-tdep.c: Fix common/ includes.
2031         * amd64-fbsd-nat.c: Fix common/ includes.
2032         * amd64-dicos-tdep.c: Fix common/ includes.
2033         * amd64-darwin-tdep.c: Fix common/ includes.
2034         * agent.c: Fix common/ includes.
2035         * ada-lang.h: Fix common/ includes.
2036         * ada-lang.c: Fix common/ includes.
2037         * aarch64-tdep.c: Fix common/ includes.
2038
2039 2019-01-25  Tom Tromey  <tom@tromey.com>
2040
2041         * common/create-version.sh: Use common/version.h.
2042
2043 2019-01-24  Pedro Alves  <palves@redhat.com>
2044
2045         * infrun.c (signal_stop, signal_print, signal_program)
2046         (signal_catch, signal_pass): Now arrays instead of pointers.
2047         (update_signals_program_target, do_target_resume)
2048         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
2049         * linux-nat.c (linux_nat_target::pass_signals)
2050         (linux_nat_target::create_inferior, linux_nat_target::attach):
2051         Adjust.
2052         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
2053         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
2054         * procfs.c (procfs_target::pass_signals): Adjust.
2055         * record-full.c (record_full_target::resume): Adjust.
2056         * remote.c (remote_target::pass_signals)
2057         (remote_target::program_signals): Adjust.
2058         * target-debug.h (target_debug_print_signals): Now takes a
2059         gdb::array_view as parameter.  Adjust.
2060         * target.h (target_ops) <pass_signals, program_signals>: Replace
2061         pointer and length parameters with gdb::array_view.
2062         (target_pass_signals, target_program_signals): Likewise.
2063         * target-delegates.c: Regenerate.
2064
2065 2019-01-24  Pedro Alves  <palves@redhat.com>
2066
2067         * common/forward-scope-exit.h
2068         (forward_scope_exit::forward_scope_exit): Pass arguments to
2069         m_bind_function directly, instead of creating a std::bind and
2070         copying that.
2071
2072 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
2073
2074         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2075         for static members.
2076         (pass_in_v_vfp_candidate): Likewise.
2077
2078 2019-01-23  Tom Tromey  <tom@tromey.com>
2079             Pedro Alves  <palves@redhat.com>
2080
2081         * regcache.c (class regcache_invalidator): Remove.
2082         (regcache::raw_write): Use make_scope_exit.
2083
2084 2019-01-23  Tom Tromey  <tom@tromey.com>
2085
2086         * ui-out.h (class ui_out_emit_type): Update comment.
2087
2088 2019-01-23  Tom Tromey  <tom@tromey.com>
2089
2090         * infrun.c (fetch_inferior_event): Update comment.
2091
2092 2019-01-23  Tom Tromey  <tom@tromey.com>
2093             Pedro Alves  <palves@redhat.com>
2094
2095         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
2096         parameter.
2097         (fetch_inferior_event): Use SCOPE_EXIT.
2098
2099
2100 2019-01-23  Tom Tromey  <tom@tromey.com>
2101             Pedro Alves  <palves@redhat.com>
2102
2103         * infrun.c (disable_thread_events): Delete.
2104         (stop_all_threads): Use SCOPE_EXIT.
2105
2106 2019-01-23  Tom Tromey  <tom@tromey.com>
2107             Pedro Alves  <palves@redhat.com>
2108
2109         * symfile.c: Include forward-scope-exit.h.
2110         (clear_symtab_users_cleanup): Replace forward declaration with
2111         a FORWARD_SCOPE_EXIT.
2112         (syms_from_objfile_1): Use the forward_scope_exit and
2113         gdb::optional instead of cleanup_function.
2114         (reread_symbols): Use the forward_scope_exit instead of
2115         cleanup_function.
2116         (clear_symtab_users_cleanup): Remove function.
2117
2118 2019-01-23  Tom Tromey  <tom@tromey.com>
2119             Pedro Alves  <palves@redhat.com>
2120
2121         * linux-nat.c: Include scope-exit.h.
2122         (cleanup_target_stop): Remove.
2123         (linux_nat_target::static_tracepoint_markers_by_strid): Use
2124         SCOPE_EXIT.
2125
2126 2019-01-23  Tom Tromey  <tom@tromey.com>
2127             Pedro Alves  <palves@redhat.com>
2128
2129         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
2130         (call_function_by_hand_dummy): Use SCOPE_EXIT.
2131
2132 2019-01-23  Tom Tromey  <tom@tromey.com>
2133             Andrew Burgess  <andrew.burgess@embecosm.com>
2134             Pedro Alves  <palves@redhat.com>
2135
2136         * infrun.c (fetch_inferior_event): Use scope_exit.
2137         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
2138         * top.c (execute_command): Use scope_exit.
2139         * breakpoint.c (bpstat_do_actions): Use scope_exit.
2140         * utils.c (do_bpstat_clear_actions_cleanup)
2141         (make_bpstat_clear_actions_cleanup): Remove.
2142
2143 2019-01-23  Tom Tromey  <tom@tromey.com>
2144             Pedro Alves  <palves@redhat.com>
2145
2146         * infrun.c: Include "common/scope-exit.h"
2147         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
2148         (wait_for_inferior): Use SCOPE_EXIT.
2149         (fetch_inferior_event): Use scope_exit.
2150
2151 2019-01-23  Tom Tromey  <tom@tromey.com>
2152             Pedro Alves  <palves@redhat.com>
2153
2154         * breakpoint.c (create_breakpoint): Remove cleanup.
2155
2156 2019-01-23  Tom Tromey  <tom@tromey.com>
2157             Andrew Burgess  <andrew.burgess@embecosm.com>
2158             Pedro Alves  <palves@redhat.com>
2159
2160 2019-01-23  Pedro Alves  <palves@redhat.com>
2161
2162         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
2163
2164 2019-01-23  Pedro Alves  <palves@redhat.com>
2165             Andrew Burgess  <andrew.burgess@embecosm.com>
2166
2167         * gdbthread.h: Include "common/forward-scope-exit.h".
2168         (scoped_finish_thread_state): Redefine custom class in terms of
2169         forward_scope_exit.
2170
2171 2019-01-23  Pedro Alves  <palves@redhat.com>
2172             Andrew Burgess  <andrew.burgess@embecosm.com>
2173
2174         * common/forward-scope-exit.h: New file.
2175
2176 2019-01-23  Pedro Alves  <palves@redhat.com>
2177             Andrew Burgess  <andrew.burgess@embecosm.com>
2178             Tom Tromey  <tom@tromey.com>
2179
2180         * common/scope-exit.h: New file.
2181
2182 2019-01-23  Pedro Alves  <palves@redhat.com>
2183
2184         * common/preprocessor.h (ESC): Rename to ...
2185         (ESC_PARENS): ... this.
2186         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
2187         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
2188
2189 2019-01-23  Tom Tromey  <tom@tromey.com>
2190
2191         * language.h (class scoped_switch_to_sym_language_if_auto):
2192         Initialize m_lang in both cases.
2193
2194 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
2195
2196         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
2197         with XCNEW.
2198
2199 2019-01-22  Tom Tromey  <tom@tromey.com>
2200
2201         * corelow.c: Do not include sys/file.h.
2202
2203 2019-01-22  Tom Tromey  <tom@tromey.com>
2204
2205         * tui/tui-wingeneral.h: Include gdb_curses.h.
2206
2207 2019-01-22  Tom Tromey  <tom@tromey.com>
2208
2209         * source-cache.h (class source_cache) <get_source_lines,
2210         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
2211
2212 2019-01-22  Tom Tromey  <tom@tromey.com>
2213
2214         * remote-fileio.h (struct remote_target): Declare.
2215
2216 2019-01-22  Tom Tromey  <tom@tromey.com>
2217
2218         * python/py-arch.c: Do not include py-ref.h.
2219         * python/py-bpevent.c: Do not include py-ref.h.
2220         * python/py-cmd.c: Do not include py-ref.h.
2221         * python/py-continueevent.c: Do not include py-ref.h.
2222         * python/py-event.h: Do not include py-ref.h.
2223         * python/py-evtregistry.c: Do not include py-ref.h.
2224         * python/py-finishbreakpoint.c: Do not include py-ref.h.
2225         * python/py-frame.c: Do not include py-ref.h.
2226         * python/py-framefilter.c: Do not include py-ref.h.
2227         * python/py-function.c: Do not include py-ref.h.
2228         * python/py-infevents.c: Do not include py-ref.h.
2229         * python/py-linetable.c: Do not include py-ref.h.
2230         * python/py-objfile.c: Do not include py-ref.h.
2231         * python/py-param.c: Do not include py-ref.h.
2232         * python/py-prettyprint.c: Do not include py-ref.h.
2233         * python/py-progspace.c: Do not include py-ref.h.
2234         * python/py-symbol.c: Do not include py-ref.h.
2235         * python/py-symtab.c: Do not include py-ref.h.
2236         * python/py-type.c: Do not include py-ref.h.
2237         * python/py-unwind.c: Do not include py-ref.h.
2238         * python/py-utils.c: Do not include py-ref.h.
2239         * python/py-value.c: Do not include py-ref.h.
2240         * python/py-varobj.c: Do not include py-ref.h.
2241         * python/py-xmethods.c: Do not include py-ref.h.
2242         * python/python.c: Do not include py-ref.h.
2243         * varobj.c: Do not include py-ref.h.
2244
2245 2019-01-22  Tom Tromey  <tom@tromey.com>
2246
2247         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
2248         keyword for bcache.
2249
2250 2019-01-22  Tom Tromey  <tom@tromey.com>
2251
2252         * compile/compile-cplus-types.c: Remove a comment by #include.
2253
2254 2019-01-22  Tom Tromey  <tom@tromey.com>
2255
2256         * compile/gcc-c-plugin.h: Include compile-internal.h.
2257
2258 2019-01-22  Tom Tromey  <tom@tromey.com>
2259
2260         * stabsread.c (EXTERN): Do not define.
2261         (symnum, next_symbol_text_func, processing_gcc_compilation)
2262         (within_function, global_sym_chain, global_stabs)
2263         (previous_stab_code, this_object_header_files)
2264         (n_this_object_header_files)
2265         (n_allocated_this_object_header_files): Define.
2266         * stabsread.h (EXTERN): Never define.  Use "extern".
2267
2268 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2269
2270         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
2271         history_value.
2272
2273 2019-01-21  Tom Tromey  <tom@tromey.com>
2274
2275         * ui-out.c: Fix includes.
2276         * tui/tui-source.c: Fix includes.
2277         * target.c: Fix includes.
2278         * remote.c: Fix includes.
2279         * regcache.c: Fix includes.
2280         * python/py-block.c: Fix includes.
2281         * printcmd.c: Fix includes.
2282         * or1k-tdep.c: Fix includes.
2283         * mi/mi-main.c: Fix includes.
2284         * m32r-tdep.c: Fix includes.
2285         * csky-tdep.c: Fix includes.
2286         * compile/compile-cplus-types.c: Fix includes.
2287         * cli/cli-interp.c: Fix includes.
2288
2289 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
2290
2291         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2292         for padding.
2293
2294 2019-01-16  Tom Tromey  <tom@tromey.com>
2295
2296         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
2297         earlier.
2298         (struct objfile) <msymbols_range>: Move from top level.
2299         <msymbols>: New method.
2300         (class objfile_msymbols): Remove.
2301         * symtab.c (default_collect_symbol_completion_matches_break_on):
2302         Update.
2303         * symmisc.c (dump_msymbols): Update.
2304         * stabsread.c (scan_file_globals): Update.
2305         * objc-lang.c (info_selectors_command, info_classes_command)
2306         (find_methods): Update.
2307         * minsyms.c (find_solib_trampoline_target): Update.
2308         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
2309         * coffread.c (coff_symfile_read): Update.
2310         * ada-lang.c (ada_lookup_simple_minsym)
2311         (ada_collect_symbol_completion_matches): Update.
2312
2313 2019-01-16  Tom Tromey  <tom@tromey.com>
2314
2315         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
2316         type.  Remove no-argument constructor.
2317         <iterator::operator++>: Simplify.
2318         <begin>: Update.
2319         <end>: Use minimal_symbol_count.
2320
2321 2019-01-16  Tom Tromey  <tom@tromey.com>
2322
2323         * objfiles.h (struct objfile) <psymtabs>: New method.
2324         (class objfile_psymtabs): Remove.
2325         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
2326         typedef.
2327         <range>: New method.
2328         (require_partial_symbols): Change return type.
2329         * psymtab.c (require_partial_symbols)
2330         (psym_expand_symtabs_matching): Update.
2331         * mdebugread.c (parse_partial_symbols): Update.
2332         * dbxread.c (dbx_end_psymtab): Update.
2333
2334 2019-01-15  Tom Tromey  <tom@tromey.com>
2335
2336         * symtab.c (lookup_objfile_from_block)
2337         (lookup_symbol_in_objfile_symtabs)
2338         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
2339         (find_line_symtab, info_sources_command)
2340         (default_collect_symbol_completion_matches_break_on)
2341         (make_source_files_completion_list): Update.
2342         * symmisc.c (print_objfile_statistics, dump_objfile)
2343         (maintenance_print_symbols, maintenance_info_symtabs)
2344         (maintenance_check_symtabs, maintenance_info_line_tables):
2345         Update.
2346         * source.c (select_source_symtab)
2347         (forget_cached_source_info_for_objfile): Update.
2348         * objfiles.h (class objfile_compunits): Remove.
2349         (struct objfile) <compunits_range>: New typedef.
2350         (compunits): New method.
2351         * objfiles.c (objfile_relocate1): Update.
2352         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2353         * maint.c (count_symtabs_and_blocks): Update.
2354         * linespec.c (iterate_over_all_matching_symtabs): Update.
2355         * cp-support.c (add_symbol_overload_list_qualified): Update.
2356         * coffread.c (coff_symtab_read): Update.
2357         * ada-lang.c (add_nonlocal_symbols)
2358         (ada_collect_symbol_completion_matches)
2359         (ada_add_global_exceptions): Update.
2360
2361 2019-01-15  Tom Tromey  <tom@tromey.com>
2362
2363         * progspace.h (program_space) <objfiles_safe_range>: New
2364         typedef.
2365         <objfiles_safe>: New method.
2366         * objfiles.h (class all_objfiles_safe): Remove.
2367         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
2368         * jit.c (jit_inferior_exit_hook): Update.
2369
2370 2019-01-17  Tom Tromey  <tom@tromey.com>
2371
2372         * progspace.h (program_space) <objfiles_range>: New typedef.
2373         <objfiles>: New method.
2374         <objfiles_head>: Rename from objfiles.
2375         (object_files): Update.
2376         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
2377         * guile/scm-pretty-print.c
2378         (ppscm_find_pretty_printer_from_objfiles): Update.
2379         * guile/scm-objfile.c (gdbscm_objfiles): Update.
2380         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
2381         Update.
2382         * python/py-progspace.c (pspy_get_objfiles): Update.
2383         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2384         Update.
2385         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2386         (objfpy_lookup_objfile_by_build_id): Update.
2387         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2388         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2389         Update.
2390         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2391         (expand_symtab_containing_pc, lookup_objfile_from_block)
2392         (lookup_static_symbol, basic_lookup_transparent_type)
2393         (find_pc_sect_compunit_symtab, find_symbol_at_address)
2394         (find_line_symtab, info_sources_command)
2395         (default_collect_symbol_completion_matches_break_on)
2396         (make_source_files_completion_list, find_main_name): Update.
2397         * symmisc.c (print_symbol_bcache_statistics)
2398         (print_objfile_statistics, maintenance_print_symbols)
2399         (maintenance_print_msymbols, maintenance_print_objfiles)
2400         (maintenance_info_symtabs, maintenance_check_symtabs)
2401         (maintenance_expand_symtabs, maintenance_info_line_tables):
2402         Update.
2403         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
2404         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
2405         (map_overlay_command, unmap_overlay_command)
2406         (simple_overlay_update, expand_symtabs_matching)
2407         (map_symbol_filenames): Update.
2408         * symfile-debug.c (set_debug_symfile): Update.
2409         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
2410         Update.
2411         * source.c (select_source_symtab, forget_cached_source_info):
2412         Update.
2413         * solib.c (solib_read_symbols): Update.
2414         * solib-spu.c (append_ocl_sos): Update.
2415         * psymtab.c (maintenance_print_psymbols)
2416         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
2417         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
2418         * printcmd.c (info_symbol_command): Update.
2419         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
2420         Update.
2421         * objfiles.h (class all_objfiles): Remove.
2422         * objfiles.c (have_partial_symbols, have_full_symbols)
2423         (have_minimal_symbols, qsort_cmp, update_section_map)
2424         (shared_objfile_contains_address_p)
2425         (default_iterate_over_objfiles_in_search_order): Update.
2426         * objc-lang.c (info_selectors_command, info_classes_command)
2427         (find_methods): Update.
2428         * minsyms.c (find_solib_trampoline_target): Update.
2429         * maint.c (maintenance_info_sections)
2430         (maintenance_translate_address, count_symtabs_and_blocks):
2431         Update.
2432         * main.c (captured_main_1): Update.
2433         * linux-thread-db.c (try_thread_db_load_from_pdir)
2434         (has_libpthread): Update.
2435         * linespec.c (iterate_over_all_matching_symtabs)
2436         (search_minsyms_for_name): Update.
2437         * jit.c (jit_find_objf_with_entry_addr): Update.
2438         * hppa-tdep.c (find_unwind_entry)
2439         (hppa_lookup_stub_minimal_symbol): Update.
2440         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
2441         Update.
2442         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2443         (elf_gnu_ifunc_resolve_by_got): Update.
2444         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
2445         * dwarf-index-write.c (save_gdb_index_command): Update.
2446         * cp-support.c (add_symbol_overload_list_qualified): Update.
2447         * breakpoint.c (create_overlay_event_breakpoint)
2448         (create_longjmp_master_breakpoint)
2449         (create_std_terminate_master_breakpoint)
2450         (create_exception_master_breakpoint): Update.
2451         * blockframe.c (find_pc_partial_function): Update.
2452         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
2453         (ada_collect_symbol_completion_matches)
2454         (ada_add_global_exceptions): Update.
2455
2456 2019-01-17  Tom Tromey  <tom@tromey.com>
2457
2458         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
2459         declare VEC.
2460         (solib_target_parse_libraries): Change return type.
2461         (library_list_start_segment, library_list_start_section)
2462         (library_list_end_library, library_list_start_library); Update.
2463         (solib_target_free_library_list): Remove.
2464         (solib_target_parse_libraries): Remove cleanup.  Change return
2465         type.
2466         (solib_target_current_sos): Update.
2467
2468 2019-01-17  Tom Tromey  <tromey@bapiya>
2469
2470         * valprint.c: Replace "the the" with "the".
2471         * symtab.c: Replace "the the" with "the".
2472         * solib.c: Replace "the the" with "the".
2473         * solib-dsbt.c: Replace "the the" with "the".
2474         * linespec.c: Replace "the the" with "the".
2475         * dwarf2loc.h: Replace "the the" with "the".
2476         * amd64-windows-tdep.c: Replace "the the" with "the".
2477         * aarch64-tdep.c: Replace "the the" with "the".
2478
2479 2019-01-16  Keith Seitz  <keiths@redhat.com>
2480
2481         PR gdb/23773
2482         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
2483         <builder>: Rename to ..
2484         <m_builder>: ... this and make private.
2485         (dwarf2_cu::get_builder): New method.  Change all users of
2486         `builder' to use this method.
2487         (dwarf2_start_symtab): Move to ...
2488         (dwarf2_cu::start_symtab): ... here.  Update all callers
2489         (setup_type_unit_groups): Move to ...
2490         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
2491         callers.
2492         (dwarf2_cu::reset_builder): New method.
2493         (process_full_compunit, process_full_type_unit): Use
2494         dwarf2_cu::reset_builder.
2495         (follow_die_offset): Record the ancestor CU if it is different
2496         from the followed DIE's CU.
2497         (follow_die_sig_1): Likewise.
2498
2499 2019-01-15  Tom Tromey  <tom@tromey.com>
2500
2501         * remote.c (class remote_state) <buf>: Now a char_vector.
2502         <buf_size>: Remove.
2503         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
2504         parameter.
2505         (remote_target::getpkt_or_notif_sane_1)
2506         (remote_target::getpkt_sane)
2507         (remote_target::getpkt_or_notif_sane): Likewise.
2508         (class remote_target) <putpkt>: New overload.
2509         (remote_target::read_frame): Change type of "buf_p".  Remove
2510         sizeof_p parameter.
2511         (packet_ok): New overload.
2512         (packet_check_result): New overload.
2513         Update all uses.
2514
2515 2019-01-14  Tom Tromey  <tom@tromey.com>
2516
2517         * remote-notif.c (handle_notification, remote_notif_ack)
2518         (remote_notif_parse): Make "buf" const.
2519         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
2520         const.
2521         (remote_notif_parse, remote_notif_ack, handle_notification):
2522         Likewise.
2523         * remote.c (remote_notif_stop_parse): Make "buf" const.
2524         (remote_target::remote_parse_stop_reply): Make "buf" const.
2525         (remote_notif_stop_ack): Make "buf" const.
2526
2527 2019-01-14  Tom Tromey  <tom@tromey.com>
2528
2529         * remote.c (remote_console_output): Make parameter const.
2530
2531 2019-01-14  Tom Tromey  <tom@tromey.com>
2532
2533         * target-debug.h (target_debug_print_signals): Constify.
2534         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
2535         * procfs.c (procfs_target::pass_signals): Update.
2536         * linux-nat.c (linux_nat_target::pass_signals): Update.
2537         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
2538         * target-delegates.c: Rebuild.
2539         * remote.c (remote_target::program_signals): Update.
2540         (remote_target::pass_signals): Update.
2541         * target.c (target_pass_signals): Constify argument.
2542         (target_program_signals): Likewise.
2543         * target.h (struct target_ops) <pass_signals, program_signals>:
2544         Constify argument.
2545         (target_pass_signals, target_program_signals): Constify argument.
2546
2547 2019-01-14  Tom Tromey  <tom@tromey.com>
2548
2549         PR tui/28819:
2550         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
2551
2552 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2553
2554         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
2555         field.
2556         * rs6000-tdep.c: Include reggroups.h.
2557         (IS_V_ALIAS_PSEUDOREG): Define.
2558         (rs6000_register_name): Return names for the "vX" aliases.
2559         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
2560         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
2561         aliases.  Call default_register_reggroup_p for all other
2562         pseudo-registers.
2563         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
2564         New functions.
2565         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
2566         Handle "vX" aliases.
2567         (v_alias_pseudo_register_collect): New function.
2568         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
2569         (rs6000_gdbarch_init): Initialize "vX" aliases as
2570         pseudo-registers.  Restore registration of
2571         rs6000_pseudo_register_reggroup_p with
2572         set_tdesc_pseudo_register_reggroup_p.
2573
2574 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
2575
2576         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
2577         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
2578         set_gdbarch_num_pseudo_regs.
2579
2580 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2581
2582         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
2583         Remove arg prefixname, add do_set and do_show.
2584         Add member functions set_list and show_list.
2585         * cli/cli-style.c (class cli_style_option): Update accordingly.
2586         (style_set_list): Move to file scope.
2587         (style_show_list): Likewise.
2588         (set_style): Call help_list.
2589         (show_style): Call cmd_show_list.
2590         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
2591         Update to use the new macro.
2592
2593 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
2594
2595         * ada-lang.c (_initialize_ada_language): Expand the help text
2596         for the "catch exception" command.
2597
2598 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2599
2600         * symtab.c (matching_obj_sections): Initialize obj,
2601         declare it closer to its usage.
2602
2603 2019-01-10  Tom Tromey  <tom@tromey.com>
2604
2605         * thread-iter.h (inf_threads_iterator): Use next_iterator.
2606         (basic_inf_threads_range): Remove.
2607         (inf_threads_range, inf_non_exited_threads_range)
2608         (safe_inf_threads_range): Use next_adapter.
2609
2610 2019-01-10  Keith Seitz  <keiths@redhat.com>
2611
2612         PR gdb/23712
2613         PR symtab/23010
2614         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
2615         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
2616
2617 2019-01-10  Keith Seitz  <keiths@redhat.com>
2618
2619         PR gdb/23712
2620         PR symtab/23010
2621         * dictionary.c (pending_to_vector): Remove.
2622         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2623         Remove _1 suffix, replacing functions of the same name.  Update
2624         all callers.
2625         (dict_create_hashed, dict_create_hashed_expandable)
2626         (dict_create_linear, dict_create_linear_expandable, dict_free)
2627         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
2628         Make functions static.
2629
2630 2019-01-10  Keith Seitz  <keiths@redhat.com>
2631
2632         PR gdb/23712
2633         PR symtab/23010
2634         * dictionary.h (struct dictionary): Replace declaration with
2635         multidictionary.
2636         (dict_create_hashed, dict_create_hashed_expandable)
2637         (dict_create_linear, dict_create_linear_expandable)
2638         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
2639         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
2640         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
2641         taking multidictionary argument.
2642         [ALL_DICT_SYMBOLS]: Update for multidictionary.
2643         * block.h (struct block) <dict>: Change to multidictionary
2644         and rename `multidict'.
2645         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
2646         symmisc.c: Update all dictionary references to multidictionary.
2647
2648 2019-01-10  Keith Seitz  <keiths@redhat.com>
2649
2650         PR gdb/23712
2651         PR symtab/23010
2652         * dictionary.c: Include unordered_map.
2653         (pending_to_vector): New function.
2654         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2655         Rewrite the non-"_1" functions to take vector instead
2656         of linked list.
2657         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
2658         "new" _1 versions of the same name.
2659         (multidictionary): Define.
2660         (std::hash<enum language): New definition.
2661         (collate_pending_symbols_by_language, mdict_create_hashed)
2662         (mdict_create_hashed_expandable, mdict_create_linear)
2663         (mdict_create_linear_expandable, mdict_free)
2664         (find_language_dictionary, create_new_language_dictionary)
2665         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
2666         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
2667         (mdict_size, mdict_empty): New functions.
2668         * dictionary.h (mdict_iterator): Define.
2669
2670 2019-01-10  Pedro Alves  <palves@redhat.com>
2671
2672         * breakpoint.c (read_uploaded_action)
2673         (create_tracepoint_from_upload): Adjust to use
2674         gdb::unique_xmalloc_ptr.
2675         * ctf.c (ctf_write_uploaded_tp):
2676         (SET_ARRAY_FIELD): Use emplace_back.
2677         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
2678         * tracefile-tfile.c (tfile_write_uploaded_tp):
2679         * tracepoint.c (parse_tracepoint_definition): Adjust to use
2680         gdb::unique_xmalloc_ptr.
2681         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
2682         at_string, cond_string, cmd_strings>: Replace char pointers
2683         with gdb::unique_xmalloc_ptr.
2684
2685 2019-01-10  Pedro Alves  <palves@redhat.com>
2686
2687         * solib-target.c (library_list_start_library): Don't xstrdup name.
2688
2689 2019-01-10  Pedro Alves  <palves@redhat.com>
2690
2691         * mdebugread.c (parse_partial_symbols): Use
2692         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
2693
2694 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2695
2696         * linux-fork.c (scoped_switch_fork_info)
2697         <~scoped_switch_fork_info>: Fix incorrect variable name.
2698
2699 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2700
2701         * linux-fork.c (scoped_switch_fork_info)
2702         <scoped_switch_fork_info>: Make explicit.
2703         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
2704
2705 2019-01-10  Tom Tromey  <tom@tromey.com>
2706
2707         * objfiles.h (objfile::reset_psymtabs): Update.
2708         * objfiles.c (objfile::objfile): Update.
2709         * psymtab.h (psymtab_storage::obstack): Update.
2710         (psymtab_storage::m_obstack): Use gdb::optional.
2711         (class psymtab_storage): Update comment.  Remove objfile
2712         parameter.
2713         * psymtab.c (psymtab_storage::psymtab_storage): Update.
2714
2715 2019-01-10  Tom Tromey  <tom@tromey.com>
2716
2717         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
2718         <free_psymtabs>: Now private.
2719         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
2720         (allocate_psymtab): Use new method.
2721
2722 2019-01-10  Tom Tromey  <tom@tromey.com>
2723
2724         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
2725         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
2726         * mdebugread.c (parse_partial_symbols): Use
2727         allocate_dependencies.
2728         * dwarf2read.c (dwarf2_create_include_psymtab): Use
2729         allocate_dependencies.
2730         (process_psymtab_comp_unit_reader)
2731         (build_type_psymtab_dependencies): Likewise.
2732         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
2733
2734 2019-01-10  Tom Tromey  <tom@tromey.com>
2735
2736         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
2737         PSYMBOL_SET_LANGUAGE.
2738         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
2739
2740 2019-01-10  Tom Tromey  <tom@tromey.com>
2741
2742         * psymtab.h (psymtab_storage::obstack): New method.
2743         <m_obstack>: Rename from obstack; now private.
2744         * psymtab.c (psymtab_storage): Update.
2745         * dwarf2read.c (create_addrmap_from_index)
2746         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
2747         Update.
2748
2749 2019-01-10  Tom Tromey  <tom@tromey.com>
2750
2751         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
2752         * objfiles.h (objfile::reset_psymtabs): New method.
2753
2754 2019-01-10  Tom Tromey  <tom@tromey.com>
2755
2756         * symmisc.c (print_symbol_bcache_statistics): Update.
2757         (print_objfile_statistics): Update.
2758         * symfile.c (reread_symbols): Update.
2759         * psymtab.h (class psymtab_storage): New.
2760         * psymtab.c (psymtab_storage): New constructor.
2761         (~psymtab_storage): New destructor.
2762         (require_partial_symbols): Update.
2763         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
2764         (find_pc_sect_psymtab, find_pc_sect_psymbol)
2765         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
2766         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
2767         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
2768         (start_psymtab_common, end_psymtab_common)
2769         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
2770         (allocate_psymtab): Update.
2771         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
2772         Update.
2773         (dump_psymtab_addrmap, maintenance_print_psymbols)
2774         (maintenance_check_psymtabs): Update.
2775         (class objfile_psymtabs): Move to objfiles.h.
2776         * psympriv.h (discard_psymtab): Now inline.
2777         (psymtab_discarder::psymtab_discarder): Update.
2778         (psymtab_discarder::~psymtab_discarder): Update.
2779         (ALL_OBJFILE_PSYMTABS): Rewrite.
2780         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
2781         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
2782         Remove fields.
2783         <partial_symtabs>: New field.
2784         (class objfile_psymtabs): Move from psymtab.h.  Update.
2785         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
2786         psymbol_cache.
2787         (objfile::~objfile): Don't destroy psymbol_cache.
2788         * mdebugread.c (parse_partial_symbols): Update.
2789         * dwarf2read.c (create_addrmap_from_index)
2790         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
2791         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
2792         (add_partial_subprogram, dwarf2_ranges_read): Update.
2793         * dwarf-index-write.c (write_address_map)
2794         (write_one_signatured_type, recursively_write_psymbols)
2795         (class debug_names, class debug_names, write_psymtabs_to_index):
2796         Update.
2797
2798 2019-01-10  Tom Tromey  <tom@tromey.com>
2799
2800         * symtab.h (SYMBOL_SET_NAMES): Update.
2801         (symbol_set_names): Update.
2802         (MSYMBOL_SET_NAMES): Update.
2803         * symtab.c (symbol_set_names): Change argument to be an
2804         objfile_per_bfd_storage.
2805         * psymtab.c (add_psymbol_to_bcache): Update.
2806         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
2807
2808 2019-01-10  Tom Tromey  <tom@tromey.com>
2809
2810         * symtab.c (create_demangled_names_hash): Change argument to be an
2811         objfile_per_bfd_storage.
2812         (symbol_set_names): Update.
2813
2814 2019-01-10  Tom Tromey  <tom@tromey.com>
2815
2816         * xcoffread.c (xcoff_initial_scan): Unconditionally call
2817         init_psymbol_list.
2818         * psymtab.c (init_psymbol_list): Do nothing if already called.
2819         * psympriv.h (init_psymbol_list): Add comment.
2820         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
2821         init_psymbol_list.
2822         * dbxread.c (dbx_symfile_read): Unconditionally call
2823         init_psymbol_list.
2824
2825 2019-01-10  Tom Tromey  <tom@tromey.com>
2826
2827         * xcoffread.c (scan_xcoff_symtab): Update.
2828         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
2829         "where".
2830         * mdebugread.c (parse_partial_symbols)
2831         (handle_psymbol_enumerators): Update.
2832         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
2833         * dbxread.c (read_dbx_symtab): Update.
2834         * psympriv.h (psymbol_placement): New enum.
2835         (add_psymbol_to_list): Update.
2836
2837 2019-01-10  Tom Tromey  <tom@tromey.com>
2838
2839         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
2840         static_psymbols parameters.
2841         (scan_xcoff_symtab): Update.
2842         * psymtab.c (start_psymtab_common): Remove global_psymbols and
2843         static_psymbols parameters.
2844         * psympriv.h (start_psymtab_common): Update.
2845         * mdebugread.c (parse_partial_symbols): Update.
2846         * dwarf2read.c (create_partial_symtab): Update.
2847         * dbxread.c (read_dbx_symtab): Update.
2848         (start_psymtab): Remove global_psymbols and static_psymbols
2849         parameters.
2850
2851 2019-01-10  Tom Tromey  <tom@tromey.com>
2852
2853         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
2854         * psymtab.c (allocate_psymtab): Add comment.
2855         * psympriv.h (allocate_psymtab): Add comment.
2856         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
2857         initializations.
2858         * dbxread.c (dbx_end_psymtab): Remove some initializations.
2859
2860 2019-01-10  Tom Tromey  <tom@tromey.com>
2861
2862         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2863         Don't declare.
2864         * mipsread.c: Include mdebugread.h.
2865         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2866         Declare.
2867         * elfread.c: Include mdebugread.h.
2868
2869 2019-01-09  Tom Tromey  <tom@tromey.com>
2870
2871         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
2872         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
2873         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
2874         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
2875         (psym_lookup_symbol, psym_find_last_source_symtab)
2876         (psym_forget_cached_source_info, psym_print_stats)
2877         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
2878         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
2879         (psym_map_matching_symbols, psym_expand_symtabs_matching)
2880         (psym_find_compunit_symtab_by_address)
2881         (maintenance_print_psymbols, maintenance_info_psymtabs)
2882         (maintenance_check_psymtabs): Use ranged for.
2883         * psymtab.h (class objfile_psymtabs): New.
2884         (require_partial_symbols): Return objfile_psymtabs.
2885         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
2886
2887 2019-01-09  Tom Tromey  <tom@tromey.com>
2888
2889         * symfile.c (overlay_invalidate_all, find_pc_overlay)
2890         (find_pc_mapped_section, list_overlays_command)
2891         (map_overlay_command, unmap_overlay_command)
2892         (simple_overlay_update): Use all_objfiles.
2893         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
2894         * printcmd.c (info_symbol_command): Use all_objfiles.
2895         * objfiles.h (ALL_OBJSECTIONS): Remove.
2896         * maint.c (maintenance_translate_address): Use all_objfiles.
2897         * gcore.c (gcore_create_callback): Use all_objfiles.
2898         (objfile_find_memory_regions): Likewise.
2899
2900 2019-01-09  Tom Tromey  <tom@tromey.com>
2901
2902         * symtab.c (find_line_symtab, info_sources_command)
2903         (make_source_files_completion_list): Use objfile_compunits.
2904         * source.c (select_source_symtab): Use objfile_compunits.
2905         * objfiles.h (struct objfile): Update comment.
2906         (ALL_OBJFILES): Remove.
2907         (ALL_FILETABS): Remove.
2908         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
2909         objfile_compunits.
2910
2911 2019-01-09  Tom Tromey  <tom@tromey.com>
2912
2913         * symmisc.c (print_objfile_statistics, dump_objfile)
2914         (maintenance_print_symbols): Use compunit_filetabs.
2915         * source.c (forget_cached_source_info_for_objfile): Use
2916         compunit_filetabs.
2917         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
2918         (ALL_FILETABS): Use compunit_filetabs.
2919         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
2920         * coffread.c (coff_symtab_read): Use compunit_filetabs.
2921
2922 2019-01-09  Tom Tromey  <tom@tromey.com>
2923
2924         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
2925         (compunit_filetabs): New.
2926         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
2927         compunit_filetabs.
2928         (info_sources_command, make_source_files_completion_list): Remove
2929         declaration.
2930         * symmisc.c (print_objfile_statistics, dump_objfile)
2931         (maintenance_print_symbols): Remove declaration.
2932         (maintenance_info_symtabs): Use compunit_filetabs.
2933         (maintenance_info_line_tables): Likewise.
2934         * source.c (select_source_symtab): Change local variable name.
2935         (forget_cached_source_info_for_objfile): Remove declaration.
2936         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
2937         * objfiles.c (objfile_relocate1): Remove declaration.
2938         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2939         declaration.
2940         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
2941         * coffread.c (coff_symtab_read): Remove declaration.
2942         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2943         compunit_filetabs.
2944
2945 2019-01-09  Tom Tromey  <tom@tromey.com>
2946
2947         * symtab.c (lookup_objfile_from_block)
2948         (find_pc_sect_compunit_symtab, search_symbols)
2949         (default_collect_symbol_completion_matches_break_on): Use
2950         objfile_compunits.
2951         * objfiles.h (ALL_COMPUNITS): Remove.
2952         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
2953         * cp-support.c (add_symbol_overload_list_qualified): Use
2954         objfile_compunits.
2955         * ada-lang.c (ada_collect_symbol_completion_matches)
2956         (ada_add_global_exceptions): Use objfile_compunits.
2957
2958 2019-01-09  Tom Tromey  <tom@tromey.com>
2959
2960         * source.c (select_source_symtab)
2961         (forget_cached_source_info_for_objfile): Remove declaration.
2962         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2963         declaration.
2964         * maint.c (count_symtabs_and_blocks): Remove declaration.
2965         * cp-support.c (add_symbol_overload_list_qualified): Remove
2966         declaration.
2967         * coffread.c (coff_symtab_read): Remove declaration.
2968         * symtab.c (lookup_symbol_in_objfile_symtabs)
2969         (basic_lookup_transparent_type_1): Use objfile_compunits.
2970         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
2971         (info_sources_command, search_symbols)
2972         (default_collect_symbol_completion_matches_break_on)
2973         (make_source_files_completion_list): Remove declaration.
2974         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
2975         (ada_collect_symbol_completion_matches)
2976         (ada_add_global_exceptions): Remove declaration.
2977         * linespec.c (iterate_over_all_matching_symtabs): Use
2978         objfile_compunits.
2979         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
2980         (class objfile_compunits): New.
2981         (ALL_COMPUNITS): Use objfile_compunits.
2982         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
2983         (maintenance_check_symtabs, maintenance_info_line_tables): Use
2984         objfile_compunits.
2985         * objfiles.c (objfile_relocate1): Use objfile_compunits.
2986
2987 2019-01-09  Tom Tromey  <tom@tromey.com>
2988
2989         * symtab.c (search_symbols)
2990         (default_collect_symbol_completion_matches_break_on): Use
2991         objfile_msymbols.
2992         * ada-lang.c (ada_lookup_simple_minsym)
2993         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
2994         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
2995         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
2996         objfile_msymbols.
2997         * coffread.c (coff_symfile_read): Use objfile_msymbols.
2998         * symmisc.c (dump_msymbols): Use objfile_msymbols.
2999         * objc-lang.c (find_methods): Use objfile_msymbols.
3000         (info_selectors_command, info_classes_command): Likewise.
3001         * stabsread.c (scan_file_globals): Use objfile_msymbols.
3002         * objfiles.h (class objfile_msymbols): New.
3003         (ALL_OBJFILE_MSYMBOLS): Remove.
3004         (ALL_MSYMBOLS): Remove.
3005
3006 2019-01-09  Tom Tromey  <tom@tromey.com>
3007
3008         * common/next-iterator.h (next_adapter): Add Iterator template
3009         parameter.
3010         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
3011         (class all_objfiles_safe): New.
3012         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
3013         * objfiles.c (put_objfile_before): Update comment.
3014         (add_separate_debug_objfile): Likewise.
3015         (free_all_objfiles): Use all_objfiles_safe.
3016         (objfile_purge_solibs): Likewise.
3017
3018 2019-01-09  Tom Tromey  <tom@tromey.com>
3019
3020         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3021         (expand_symtab_containing_pc, lookup_static_symbol)
3022         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
3023         (find_symbol_at_address, find_line_symtab, find_main_name): Use
3024         all_objfiles.
3025         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
3026         * breakpoint.c (create_overlay_event_breakpoint)
3027         (create_longjmp_master_breakpoint)
3028         (create_std_terminate_master_breakpoint)
3029         (create_exception_master_breakpoint): Use all_objfiles.
3030         * linux-thread-db.c (try_thread_db_load_from_pdir)
3031         (has_libpthread): Use all_objfiles.
3032         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
3033         * linespec.c (iterate_over_all_matching_symtabs)
3034         (search_minsyms_for_name): Use all_objfiles.
3035         * maint.c (maintenance_info_sections): Use all_objfiles.
3036         * main.c (captured_main_1): Use all_objfiles.
3037         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
3038         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
3039         * guile/scm-pretty-print.c
3040         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
3041         * solib-spu.c (append_ocl_sos): Use all_objfiles.
3042         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
3043         (maintenance_print_msymbols): Use all_objfiles.
3044         * source.c (select_source_symtab): Use all_objfiles.
3045         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
3046         * symfile.c (remove_symbol_file_command)
3047         (expand_symtabs_matching, map_symbol_filenames): Use
3048         all_objfiles.
3049         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
3050         all_objfiles.
3051         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
3052         * objc-lang.c (find_methods): Use all_objfiles.
3053         * objfiles.c (have_partial_symbols, have_full_symbols)
3054         (have_minimal_symbols, qsort_cmp)
3055         (default_iterate_over_objfiles_in_search_order): Use
3056         all_objfiles.
3057         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
3058         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
3059         (maintenance_check_psymtabs): Use all_objfiles.
3060         (ALL_PSYMTABS): Remove.
3061         * compile/compile-object-run.c (do_module_cleanup): Use
3062         all_objfiles.
3063         * blockframe.c (find_pc_partial_function): Use all_objfiles.
3064         * cp-support.c (add_symbol_overload_list_qualified): Use
3065         all_objfiles.
3066         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3067         Use all_objfiles.
3068         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
3069         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
3070         all_objfiles.
3071         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3072         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
3073         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3074         Uses all_objfiles.
3075         * solib.c (solib_read_symbols): Use all_objfiles
3076
3077 2019-01-09  Tom Tromey  <tom@tromey.com>
3078
3079         * probe.c (parse_probes_in_pspace): Use all_objfiles.
3080         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
3081         all_objfiles.
3082         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
3083         * symmisc.c (print_symbol_bcache_statistics)
3084         (print_objfile_statistics, maintenance_print_objfiles)
3085         (maintenance_info_symtabs, maintenance_check_symtabs)
3086         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
3087         all_objfiles.
3088         * source.c (forget_cached_source_info): Use all_objfiles.
3089         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
3090         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3091         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
3092         * objfiles.c (update_section_map): Use all_objfiles.
3093         (shared_objfile_contains_address_p): Likewise.
3094         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
3095         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
3096
3097 2019-01-09  Tom Tromey  <tom@tromey.com>
3098
3099         * common/next-iterator.h: New file.
3100         * objfiles.h (class all_objfiles): New.
3101         (struct objfile_iterator): New.
3102
3103 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3104
3105         * NEWS: Move the description of the changed "frame", "select-frame",
3106          and "info frame" commands to the Changed commands section.
3107
3108 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
3109
3110         * gdbtypes.c (check_stub_method_group): Remove handling of old
3111         mangling schemes.
3112         * linespec.c (find_methods): Likewise.
3113         * stabsread.c (read_member_functions): Likewise.
3114         * valops.c (search_struct_method): Likewise.
3115         (value_struct_elt_for_reference): Likewise.
3116         * NEWS: Mention this change.
3117
3118 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3119
3120         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
3121         print_source_lines.
3122         * source.c (print_source_lines_base): Update line number check.
3123         (print_source_lines): New function.
3124         (source_lines_range::source_lines_range): New function.
3125         * source.h (class source_lines_range): New class.
3126         (print_source_lines): New declaration.
3127
3128 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3129
3130         * linespec.c (linespec_state_destructor): Free self->canonical_names.
3131
3132 2019-01-08  Tom Tromey  <tom@tromey.com>
3133             Simon Marchi  <simon.marchi@ericsson.com>
3134
3135         PR gdb/24060
3136         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
3137         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
3138         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3139         * f-exp.y (DOLLAR_VARIABLE): Likewise.
3140         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
3141         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3142
3143 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3144
3145         * source.c (select_source_symtab): Move header comment to
3146         declaration in source.h.
3147         (forget_cached_source_info_for_objfile): Likewise.
3148         (forget_cached_source_info): Likewise.
3149         (identify_source_line): Likewise.
3150         * source.h (identify_source_line): Move declaration from symtab.h
3151         and add comment from source.c
3152         (print_source_lines): Likewise.
3153         (forget_cached_source_info_for_objfile): Likewise.
3154         (forget_cached_source_info): Likewise.
3155         (select_source_symtab): Likewise.
3156         (enum print_source_lines_flag): Move definition from symtab.h.
3157         * symtab.h (identify_source_line): Move declaration to source.h.
3158         (print_source_lines): Likewise.
3159         (forget_cached_source_info_for_objfile): Likewise.
3160         (forget_cached_source_info): Likewise.
3161         (select_source_symtab): Likewise.
3162         (enum print_source_lines_flag): Move definition to source.h.
3163         * tui/tui-hooks.c: Add 'source.h' include.
3164
3165 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3166
3167         * source.c (print_source_lines_base): Handle requests to print
3168         reverse line number sequences, and guard against empty lines
3169         string.
3170
3171 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3172
3173         * source.c (print_source_lines_base): Fix skip of '\r' if next
3174         character is '\n'.
3175
3176 2019-01-06  Tom Tromey  <tom@tromey.com>
3177
3178         * c-exp.y (struct c_parse_state) <macro_original_text,
3179         expansion_obstack>: New member.
3180         (macro_original_text, expansion_obstack): Remove globals.
3181         (scan_macro_expansion, scanning_macro_expansion)
3182         (finished_macro_expansion): Update.
3183         (scan_macro_cleanup): Remove.
3184         (yylex, c_parse): Update.
3185
3186 2019-01-06  Tom Tromey  <tom@tromey.com>
3187
3188         * c-exp.y (struct c_parse_state) <strings>: New member.
3189         (operator_stoken): Update.
3190
3191 2019-01-06  Tom Tromey  <tom@tromey.com>
3192
3193         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
3194         (union type_stack_elt) <typelist_val>: Now a pointer to
3195         std::vector.
3196         (type_stack_cleanup): Don't declare.
3197         (push_typelist): Update.
3198         * parse.c (pop_typelist): Return a std::vector.
3199         (push_typelist): Take a std::vector.
3200         (follow_types): Update.  Do not free args.
3201         (type_stack_cleanup): Remove.
3202         * c-exp.y (struct c_parse_state): New.
3203         (cpstate): New global.
3204         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
3205         (nonempty_typelist): Update.
3206         (func_mod): Create a new vector.
3207         (c_parse): Create a c_parse_state.
3208         (check_parameter_typelist): Do not delete params.
3209         (function_method): Update.  Do not delete type_list.
3210
3211 2019-01-06  Tom Tromey  <tom@tromey.com>
3212
3213         PR gdb/28155:
3214         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
3215         check_typedef.
3216         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
3217         (print_return_value): Likewise.
3218
3219 2019-01-05  Tom Tromey  <tom@tromey.com>
3220
3221         * contrib/cleanup_check.py: Remove.
3222         * contrib/gcc-with-excheck: Remove.
3223         * contrib/exsummary.py: Remove.
3224         * contrib/excheck.py: Remove.
3225
3226 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
3227
3228         * thread.c (delete_thread_1): Add gdb_assert that THR is not
3229         NULL. Initialize tpprev to NULL instead of assigning it
3230         to NULL on the next statement.
3231         * windows-nat.c (windows_delete_thread): Remove check for
3232         main_thread_id before printing thread exit notifications.
3233         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
3234         Remove thread ID check against main_thread_id.
3235         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
3236         windows_delete_thread.
3237         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
3238
3239 2019-01-04  Tom Tromey  <tom@tromey.com>
3240
3241         * compile/compile.c (_initialize_compile): Use upper case for
3242         metasyntactic variables.
3243         * symmisc.c (_initialize_symmisc): Use upper case for
3244         metasyntactic variables.
3245         * psymtab.c (_initialize_psymtab): Use upper case for
3246         metasyntactic variables.
3247         * demangle.c (demangle_command): Use upper case for metasyntactic
3248         variables.
3249         (_initialize_demangler): Likewise.
3250         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
3251         variables.
3252
3253 2019-01-03  Tom Tromey  <tom@tromey.com>
3254
3255         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
3256
3257 2019-01-03  Tom Tromey  <tom@tromey.com>
3258
3259         * python/py-symtab.c (salpy_str): Update.
3260         (struct salpy_sal_object) <symtab>: Now a PyObject.
3261         (salpy_dealloc): Update.
3262         (del_objfile_sal): Use gdbpy_ref.
3263
3264 2019-01-03  Tom Tromey  <tom@tromey.com>
3265
3266         * python/py-type.c (convert_field): Use new_reference.  Return
3267         gdbpy_ref.
3268         (make_fielditem): Return gdbpy_ref.
3269         (typy_fields): Update.
3270         (typy_getitem): Update.
3271         (field_name): Return gdbpy_ref.  Use new_reference.
3272         (typy_iterator_iternext): Update.
3273
3274 2019-01-03  Tom Tromey  <tom@tromey.com>
3275
3276         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
3277
3278 2019-01-03  Tom Tromey  <tom@tromey.com>
3279
3280         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
3281         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
3282         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
3283         (pspy_set_frame_filters, pspy_set_frame_unwinders)
3284         (pspy_set_type_printers): Likewise.
3285         * python/py-function.c (fnpy_init): Use gdbpy_ref.
3286         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
3287         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
3288         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
3289         (objfpy_set_type_printers): Likewise.
3290
3291 2019-01-03  Tom Tromey  <tom@tromey.com>
3292
3293         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
3294         (gdbpy_print_stack): Use gdbpy_err_fetch.
3295         * python/python-internal.h (class gdbpy_err_fetch): New class.
3296         (class gdbpy_enter) <m_error_type, m_error_value,
3297         m_error_traceback>: Remove.
3298         <m_error>: New member.
3299         (gdbpy_exception_to_string): Don't declare.
3300         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
3301         * python/py-value.c (convert_value_from_python): Use
3302         gdbpy_err_fetch.
3303         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
3304         gdbpy_exception_to_string.
3305         (gdbpy_handle_exception): Use gdbpy_err_fetch.
3306         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3307         gdbpy_err_fetch.
3308
3309 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3310
3311         * linux-nat.c (delete_lwp_cleanup): Delete.
3312         (struct lwp_deleter): New struct.
3313         (lwp_info_up): New typedef.
3314         (linux_nat_target::follow_fork): Delete cleanup, and make use of
3315         lwp_info_up.
3316
3317 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3318
3319         * linux-fork.c (class scoped_switch_fork_info): New class.
3320         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
3321
3322 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3323
3324         * valops.c (find_overload_match): Remove use of null_cleanup, and
3325         calls to do_cleanups.
3326
3327 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3328
3329         * compile/compile-cplus-types.c
3330         (compile_cplus_instance::decl_name): Handle changes to
3331         cp_func_name.
3332         * cp-support.c (cp_func_name): Update header comment, update
3333         return type.
3334         * cp-support.h (cp_func_name): Update return type in declaration.
3335         * valops.c (find_overload_match): Move temp_func local to top
3336         level of function and change its type.  Use temp_func to hold and
3337         delete temporary string obtained from cp_func_name.
3338
3339 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3340
3341         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
3342         gdb::char_vector, remove cleanup, and update uses of `msg`.
3343
3344 2019-01-03  Jim Wilson  <jimw@sifive.com>
3345
3346         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
3347
3348 2019-01-02  Tom Tromey  <tom@tromey.com>
3349
3350         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
3351         (tdesc_parse_xml): Remove cleanups.
3352         * target-descriptions.h (make_cleanup_free_target_description):
3353         Don't declare.
3354         (target_desc_deleter): New struct.
3355         (target_desc_up): New typedef.
3356         * target-descriptions.c (target_desc_deleter::operator()): Rename
3357         from free_target_description.
3358         (make_cleanup_free_target_description): Remove.
3359
3360 2019-01-02  Tom Tromey  <tom@tromey.com>
3361
3362         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
3363         constructor, destructor.
3364         (linespec_parser): Remove typedef.
3365         (~linespec_parser): Rename from linespec_parser_delete.
3366         (linespec_lex_to_end, linespec_complete_label)
3367         (linespec_complete): Update.
3368         (decode_line_full): Remove cleanups.
3369         (decode_line_1): Update.
3370
3371 2019-01-02  Tom Tromey  <tom@tromey.com>
3372
3373         * python/python-internal.h (inferior_to_inferior_object): Change
3374         return type.
3375         * python/py-exitedevent.c (create_exited_event_object): Update.
3376         * python/py-inferior.c (inferior_to_inferior_object): Return
3377         gdbpy_ref.
3378         (python_new_inferior, python_inferior_deleted)
3379         (thread_to_thread_object, delete_thread_object)
3380         (build_inferior_list, gdbpy_selected_inferior): Update.
3381         * python/py-infthread.c (create_thread_object): Update.  Also fail
3382         if inferior_to_inferior_object fails.
3383
3384 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
3385
3386         * inferior.h (class inferior) <displaced_step_state>: New field.
3387         * infrun.h (struct displaced_step_state): Move here from
3388         infrun.c.  Initialize fields, add constructor.
3389         <inf>: Remove field.
3390         <reset>: New method.
3391         * infrun.c (struct displaced_step_inferior_state): Move to
3392         infrun.h.
3393         (displaced_step_inferior_states): Remove.
3394         (get_displaced_stepping_state): Adust.
3395         (displaced_step_in_progress_any_inferior): Adjust.
3396         (displaced_step_in_progress_thread): Adjust.
3397         (displaced_step_in_progress): Adjust.
3398         (add_displaced_stepping_state): Remove.
3399         (get_displaced_step_closure_by_addr): Adjust.
3400         (remove_displaced_stepping_state): Remove.
3401         (infrun_inferior_exit): Call displaced_step_state.reset.
3402         (use_displaced_stepping): Don't check for NULL.
3403         (displaced_step_prepare_throw): Call
3404         get_displaced_stepping_state.
3405         (displaced_step_fixup): Don't check for NULL.
3406         (prepare_for_detach): Don't check for NULL.
3407
3408 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3409
3410         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
3411          in case of call that did not complete.
3412
3413 2019-01-02  Andrey Utkin  <autkin@undo.io>
3414
3415         * symfile.c (find_separate_debug_file): Fix search of debug files for
3416         remote debuggee.
3417
3418 2019-01-02  Tom Tromey  <tom@tromey.com>
3419
3420         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
3421         indentation.
3422         * python/py-frame.c (frapy_older): Remove cast.
3423         (frapy_newer): Likewise.
3424         * python/py-breakpoint.c (local_setattro): Remove cast.
3425         * python/py-arch.c (archpy_name): Remove local variable.
3426         * python/py-type.c (gdbpy_lookup_type): Remove cast.
3427
3428 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
3429
3430         * unittests/basic_string_view/element_access/char/empty.cc:
3431         Fix year range in copyright header.
3432
3433 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3434
3435         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
3436         Delete.
3437         <operator==>: Update with for removed field.
3438         <hash>: Likewise.
3439         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
3440         <isa_features>: ...this.
3441         <abi_features>: New field.
3442         (riscv_isa_flen): Update comment.
3443         (riscv_abi_xlen): New declaration.
3444         (riscv_abi_flen): New declaration.
3445         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
3446         isa_features.
3447         (riscv_abi_xlen): New function.
3448         (riscv_isa_flen): Update to get answer from isa_features.
3449         (riscv_abi_flen): New function.
3450         (riscv_has_fp_abi): Update to get answer from abi_features.
3451         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
3452         xlen and flen.
3453         (riscv_call_info) <xlen, flen>: Update comment.
3454         (riscv_call_arg_struct): Remove invalid assertions
3455         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
3456         is removed.
3457         (riscv_gdbarch_init): Gather isa features and abi features
3458         separately, ensure both match on the gdbarch when reusing an old
3459         gdbarch.  Relax an error check to allow 32-bit abi float to run on
3460         a target with 64-bit float hardware.
3461
3462 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3463
3464         * source.c (search_command_helper): Stop reverse search
3465         when line 1 has been searched.
3466
3467 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3468
3469         * record-full.c (record_full_base_target::close): Rewrite
3470         record_full_core_buf_list free logic.
3471
3472 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3473
3474         * break-catch-syscall.c (print_one_catch_syscall): xfree
3475         the last text.
3476
3477 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3478
3479         * top.c (print_gdb_version): Update Copyright year in version
3480         message.
3481
3482 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3483
3484         Update copyright year range in all GDB files.
3485
3486 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
3487
3488         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
3489
3490 For older changes see ChangeLog-2018.
3491 \f
3492 Local Variables:
3493 mode: change-log
3494 left-margin: 8
3495 fill-column: 74
3496 version-control: never
3497 coding: utf-8
3498 End:
3499