gdb/ChangeLog

   1 2019-02-17  Tom Tromey  <tom@tromey.com>
   2
   3         * ada-lang.c (user_select_syms): Use filtered printing.
   4         * utils.c (wrap_style): New global.
   5         (desired_style): Remove.
   6         (emit_style_escape): Add stream parameter.
   7         (set_output_style, reset_terminal_style, prompt_for_continue):
   8         Update.
   9         (flush_wrap_buffer): Only flush gdb_stdout.
  10         (wrap_here): Set wrap_style.
  11         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
  12         treat escape sequences as a character.  Change when wrap buffer is
  13         flushed.
  14         (fputs_styled): Do not set the output style when the default is
  15         requested.
  16         * ui-style.h (struct ui_file_style) <is_default>: New method.
  17         * source.c (print_source_lines_base): Emit escape sequences in one
  18         piece.
  19
  20 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
  21
  22         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
  23         integers and enumeration types.
  24
  25 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
  26
  27         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
  28         instead of lookup_symbol_in_language
  29         (do_exact_match): New function.
  30         (ada_get_symbol_name_matcher): Return do_exact_match when
  31         doing a verbatim match.
  32
  33 2019-02-15  Tom Tromey  <tromey@adacore.com>
  34
  35         * ravenscar-thread.c (ravenscar_thread_target::resume)
  36         (ravenscar_thread_target::wait): Special case wildcard requests.
  37
  38 2019-02-15  Tom Tromey  <tromey@adacore.com>
  39
  40         * ravenscar-thread.c (base_ptid): Remove.
  41         (struct ravenscar_thread_target) <close>: New method.
  42         <m_base_ptid>: New member.
  43         <update_inferior_ptid, active_task, task_is_currently_active,
  44         runtime_initialized>: Declare methods.
  45         <ravenscar_thread_target>: Add constructor.
  46         (ravenscar_thread_target::task_is_currently_active)
  47         (ravenscar_thread_target::update_inferior_ptid)
  48         (ravenscar_runtime_initialized): Rename.  Now methods.
  49         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
  50         (ravenscar_thread_target::update_thread_list): Update.
  51         (ravenscar_thread_target::active_task): Now method.
  52         (ravenscar_thread_target::store_registers)
  53         (ravenscar_thread_target::prepare_to_store)
  54         (ravenscar_thread_target::prepare_to_store)
  55         (ravenscar_thread_target::mourn_inferior): Update.
  56         (ravenscar_inferior_created): Use "new" to create target.
  57         (ravenscar_thread_target::get_ada_task_ptid): Update.
  58         (_initialize_ravenscar): Don't initialize base_ptid.
  59         (ravenscar_ops): Remove global.
  60
  61 2019-02-15  Tom Tromey  <tromey@adacore.com>
  62
  63         * target.h (push_target): Declare new overload.
  64         * target.c (push_target): New overload, taking an rvalue reference.
  65         * remote.c (remote_target::open_1): Use push_target overload.
  66         * corelow.c (core_target_open): Use push_target overload.
  67
  68 2019-02-15  Tom Tromey  <tromey@adacore.com>
  69
  70         * ravenscar-thread.c (is_ravenscar_task)
  71         (ravenscar_task_is_currently_active): Return bool.
  72         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
  73         (_initialize_ravenscar): Remove "(void)".
  74         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
  75         Return bool.
  76
  77 2019-02-15  Tom Tromey  <tromey@adacore.com>
  78
  79         * ravenscar-thread.c (ravenscar_runtime_initializer)
  80         (has_ravenscar_runtime, get_running_thread_id)
  81         (ravenscar_thread_target::resume): Fix indentation.
  82
  83 2019-02-15  Tom Tromey  <tromey@adacore.com>
  84
  85         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
  86         from ravenscar_arch_ops.
  87         (sparc_ravenscar_ops::fetch_registers)
  88         (sparc_ravenscar_ops::store_registers): Now methods.
  89         (sparc_ravenscar_prepare_to_store): Remove.
  90         (sparc_ravenscar_ops): Redefine.
  91         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
  92         methods and destructor.  Remove members.
  93         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
  94         (ravenscar_thread_target::store_registers)
  95         (ravenscar_thread_target::prepare_to_store): Update.
  96         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
  97         Remove.
  98         (struct ppc_ravenscar_powerpc_ops): Derive from
  99         ravenscar_arch_ops.
 100         (ppc_ravenscar_powerpc_ops::fetch_registers)
 101         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
 102         (ppc_ravenscar_powerpc_ops): Redefine.
 103         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
 104         (ppc_ravenscar_e500_ops::fetch_registers)
 105         (ppc_ravenscar_e500_ops::store_registers): Now methods.
 106         (ppc_ravenscar_e500_ops): Redefine.
 107         * aarch64-ravenscar-thread.c
 108         (aarch64_ravenscar_generic_prepare_to_store): Remove.
 109         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
 110         (aarch64_ravenscar_fetch_registers)
 111         (aarch64_ravenscar_store_registers): Now methods.
 112         (aarch64_ravenscar_ops): Redefine.
 113
 114 2019-02-15  Tom Tromey  <tromey@adacore.com>
 115
 116         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
 117         (ravenscar_thread_target::stopped_by_hw_breakpoint)
 118         (ravenscar_thread_target::stopped_by_watchpoint)
 119         (ravenscar_thread_target::stopped_data_address)
 120         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
 121
 122 2019-02-15  Tom Tromey  <tromey@adacore.com>
 123
 124         * ravenscar-thread.c: Fix some typos.
 125
 126 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 127             Tom Tromey  <tromey@adacore.com>
 128
 129         * ada-lang.c (ada_exception_sal): Change addr_string to a
 130         std::string.
 131         (create_ada_exception_catchpoint): Update.
 132
 133 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 134             Tom Tromey  <tromey@adacore.com>
 135
 136         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
 137         (bp_location_ops): Remove.
 138         (base_breakpoint_allocate_location): Update.
 139         (free_bp_location): Update.
 140         * ada-lang.c (class ada_catchpoint_location)
 141         <ada_catchpoint_location>: Remove ops parameter.
 142         (ada_catchpoint_location_dtor): Remove.
 143         (ada_catchpoint_location_ops): Remove.
 144         (allocate_location_exception): Update.
 145         * breakpoint.h (struct bp_location_ops): Remove.
 146         (class bp_location) <bp_location>: Remove bp_location_ops
 147         parameter.
 148         <~bp_location>: Add destructor.
 149         <ops>: Remove.
 150
 151 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 152             Pedro Alves  <palves@redhat.com>
 153
 154         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
 155         'PATH_MAX'.
 156
 157 2019-02-14  David Michael  <fedora.dm0@gmail.com>
 158             Samuel Thibault  <samuel.thibault@gnu.org>
 159             Thomas Schwinge  <thomas@codesourcery.com>
 160
 161         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
 162         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
 163
 164 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 165
 166         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
 167         (check_empty): Use "const char *".
 168
 169         * gnu-nat.c (gnu_nat_target::detach): Instead of
 170         'detach_inferior (pid)' call
 171         'detach_inferior (find_inferior_pid (pid))'.
 172
 173         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
 174         'nat/fork-inferior.o'.
 175         * gnu-nat.c: #include "nat/fork-inferior.h".
 176
 177         * gnu-nat.c (gnu_nat_target::detach): Instead of
 178         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
 179         * gnu-nat.h: #include "inf-child.h".
 180         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
 181         'i386_gnu_nat_target::fetch_registers'.
 182         (gnu_store_registers): Rename/move to
 183         'i386_gnu_nat_target::store_registers'.
 184
 185         * config/i386/nm-i386gnu.h: Don't "#include" any files.
 186         * gnu-nat.h (mach_thread_info): New function.
 187         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
 188
 189         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
 190
 191 2019-02-14  Frederic Konrad  <konrad@adacore.com>
 192
 193         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
 194
 195 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
 196
 197         * windows-nat.c (windows_add_thread): Add new parameter
 198         "main_thread_p" with default value set to false.  Update
 199         function documentation as well as all callers.
 200         (windows_delete_thread): Likewise.
 201         (fake_create_process): Update call to windows_add_thread.
 202         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
 203         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
 204         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
 205         call to windows_delete_thread.
 206
 207 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
 208
 209         * MAINTAINERS: Add Andrew Burgess as global maintainer.
 210
 211 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 212
 213         * symfile.c (find_separate_debug_file): Use canonical path of
 214         sysroot with child_path instead of gdb_sysroot if it is valid.
 215
 216 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 217
 218         * symfile.c (find_separate_debug_file): Use child_path to
 219         determine if an object file is under a sysroot.
 220
 221 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 222
 223         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 224         unittests/child-path-selftests.c.
 225         * common/pathstuff.c (child_path): New function.
 226         * common/pathstuff.h (child_path): New prototype.
 227         * unittests/child-path-selftests.c: New file.
 228
 229 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 230
 231         * symfile.c (find_separate_debug_file): Look for separate debug
 232         files in debug directories under the sysroot.
 233
 234 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 235
 236         * symtab.h (struct minimal_symbol data_p): New const method.
 237         (struct minimal_symbol text_p): Likewise.
 238         * symtab.c (output_source_filename): Use file name style
 239         to print file name.
 240         (print_symbol_info): Likewise.
 241         (print_msymbol_info): Use address style to print addresses.
 242         Use function name style to print executable text symbols.
 243         (expand_symtab_containing_pc): Use data_p.
 244         (find_pc_sect_compunit_symtab): Likewise.
 245
 246 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 247
 248         * breakpoint.c (describe_other_breakpoints): Use address style
 249         to print addresses.
 250         (say_where): Likewise.
 251
 252 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 253
 254         * ada-typeprint.c (print_func_type): Print function name
 255         style to print function name.
 256         * c-typeprint.c (c_print_type_1): Likewise.
 257
 258 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
 259
 260         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
 261         for execve.
 262
 263 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 264
 265         * c-exp.y (direct_abs_decl): Use emplace_back to record the
 266         type_stack.
 267
 268 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
 269
 270         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
 271         TYPE_CODE_REF types.
 272
 273 2019-02-08  Jim Wilson  <jimw@sifive.com>
 274
 275         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
 276         (riscv_linux_fregset): New.
 277         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
 278
 279 2019-02-07  Tom Tromey  <tom@tromey.com>
 280
 281         * thread.c (thread_cancel_execution_command): Update.
 282         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
 283         methods.
 284         (struct thread_fsm_ops): Remove.
 285         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
 286         (thread_fsm_should_stop, thread_fsm_return_value)
 287         (thread_fsm_set_finished, thread_fsm_finished_p)
 288         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
 289         Don't declare.
 290         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
 291         * infrun.c (clear_proceed_status_thread)
 292         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
 293         (print_stop_event): Update.
 294         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
 295         Add constructor.
 296         (step_command_fsm_ops): Remove.
 297         (new_step_command_fsm): Remove.
 298         (step_1): Update.
 299         (step_command_fsm::should_stop): Rename from
 300         step_command_fsm_should_stop.
 301         (step_command_fsm::clean_up): Rename from
 302         step_command_fsm_clean_up.
 303         (step_command_fsm::do_async_reply_reason): Rename from
 304         step_command_fsm_async_reply_reason.
 305         (struct until_next_fsm): Inherit from thread_fsm.  Add
 306         constructor.
 307         (until_next_fsm_ops): Remove.
 308         (new_until_next_fsm): Remove.
 309         (until_next_fsm::should_stop): Rename from
 310         until_next_fsm_should_stop.
 311         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
 312         (until_next_fsm::do_async_reply_reason): Rename from
 313         until_next_fsm_async_reply_reason.
 314         (struct finish_command_fsm): Inherit from thread_fsm.  Add
 315         constructor.  Change type of breakpoint.
 316         (finish_command_fsm_ops): Remove.
 317         (new_finish_command_fsm): Remove.
 318         (finish_command_fsm::should_stop): Rename from
 319         finish_command_fsm_should_stop.
 320         (finish_command_fsm::clean_up): Rename from
 321         finish_command_fsm_clean_up.
 322         (finish_command_fsm::return_value): Rename from
 323         finish_command_fsm_return_value.
 324         (finish_command_fsm::do_async_reply_reason): Rename from
 325         finish_command_fsm_async_reply_reason.
 326         (finish_command): Update.
 327         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
 328         Add constructor.
 329         (call_thread_fsm_ops): Remove.
 330         (call_thread_fsm::call_thread_fsm): Rename from
 331         new_call_thread_fsm.
 332         (call_thread_fsm::should_stop): Rename from
 333         call_thread_fsm_should_stop.
 334         (call_thread_fsm::should_notify_stop): Rename from
 335         call_thread_fsm_should_notify_stop.
 336         (run_inferior_call, call_function_by_hand_dummy): Update.
 337         * cli/cli-interp.c (should_print_stop_to_console): Update.
 338         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
 339         Add constructor.  Change type of location_breakpoint,
 340         caller_breakpoint.
 341         (until_break_fsm_ops): Remove.
 342         (new_until_break_fsm): Remove.
 343         (until_break_fsm::should_stop): Rename from
 344         until_break_fsm_should_stop.
 345         (until_break_fsm::clean_up): Rename from
 346         until_break_fsm_clean_up.
 347         (until_break_fsm::do_async_reply_reason): Rename from
 348         until_break_fsm_async_reply_reason.
 349         (until_break_command): Update.
 350         * thread-fsm.c: Remove.
 351         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
 352
 353 2019-02-07  Tom Tromey  <tom@tromey.com>
 354
 355         * yy-remap.h: Add include guard.
 356         * xtensa-tdep.h: Add include guard.
 357         * xcoffread.h: Rename include guard.
 358         * varobj-iter.h: Add include guard.
 359         * tui/tui.h: Rename include guard.
 360         * tui/tui-winsource.h: Rename include guard.
 361         * tui/tui-wingeneral.h: Rename include guard.
 362         * tui/tui-windata.h: Rename include guard.
 363         * tui/tui-win.h: Rename include guard.
 364         * tui/tui-stack.h: Rename include guard.
 365         * tui/tui-source.h: Rename include guard.
 366         * tui/tui-regs.h: Rename include guard.
 367         * tui/tui-out.h: Rename include guard.
 368         * tui/tui-layout.h: Rename include guard.
 369         * tui/tui-io.h: Rename include guard.
 370         * tui/tui-hooks.h: Rename include guard.
 371         * tui/tui-file.h: Rename include guard.
 372         * tui/tui-disasm.h: Rename include guard.
 373         * tui/tui-data.h: Rename include guard.
 374         * tui/tui-command.h: Rename include guard.
 375         * tic6x-tdep.h: Add include guard.
 376         * target/waitstatus.h: Rename include guard.
 377         * target/wait.h: Rename include guard.
 378         * target/target.h: Rename include guard.
 379         * target/resume.h: Rename include guard.
 380         * target-float.h: Rename include guard.
 381         * stabsread.h: Add include guard.
 382         * rs6000-tdep.h: Add include guard.
 383         * riscv-fbsd-tdep.h: Add include guard.
 384         * regformats/regdef.h: Rename include guard.
 385         * record.h: Rename include guard.
 386         * python/python.h: Rename include guard.
 387         * python/python-internal.h: Rename include guard.
 388         * python/py-stopevent.h: Rename include guard.
 389         * python/py-ref.h: Rename include guard.
 390         * python/py-record.h: Rename include guard.
 391         * python/py-record-full.h: Rename include guard.
 392         * python/py-record-btrace.h: Rename include guard.
 393         * python/py-instruction.h: Rename include guard.
 394         * python/py-events.h: Rename include guard.
 395         * python/py-event.h: Rename include guard.
 396         * procfs.h: Add include guard.
 397         * proc-utils.h: Add include guard.
 398         * p-lang.h: Add include guard.
 399         * or1k-tdep.h: Rename include guard.
 400         * observable.h: Rename include guard.
 401         * nto-tdep.h: Rename include guard.
 402         * nat/x86-linux.h: Rename include guard.
 403         * nat/x86-linux-dregs.h: Rename include guard.
 404         * nat/x86-gcc-cpuid.h: Add include guard.
 405         * nat/x86-dregs.h: Rename include guard.
 406         * nat/x86-cpuid.h: Rename include guard.
 407         * nat/ppc-linux.h: Rename include guard.
 408         * nat/mips-linux-watch.h: Rename include guard.
 409         * nat/linux-waitpid.h: Rename include guard.
 410         * nat/linux-ptrace.h: Rename include guard.
 411         * nat/linux-procfs.h: Rename include guard.
 412         * nat/linux-osdata.h: Rename include guard.
 413         * nat/linux-nat.h: Rename include guard.
 414         * nat/linux-namespaces.h: Rename include guard.
 415         * nat/linux-btrace.h: Rename include guard.
 416         * nat/glibc_thread_db.h: Rename include guard.
 417         * nat/gdb_thread_db.h: Rename include guard.
 418         * nat/gdb_ptrace.h: Rename include guard.
 419         * nat/fork-inferior.h: Rename include guard.
 420         * nat/amd64-linux-siginfo.h: Rename include guard.
 421         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
 422         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
 423         * nat/aarch64-linux.h: Rename include guard.
 424         * nat/aarch64-linux-hw-point.h: Rename include guard.
 425         * mn10300-tdep.h: Add include guard.
 426         * mips-linux-tdep.h: Add include guard.
 427         * mi/mi-parse.h: Rename include guard.
 428         * mi/mi-out.h: Rename include guard.
 429         * mi/mi-main.h: Rename include guard.
 430         * mi/mi-interp.h: Rename include guard.
 431         * mi/mi-getopt.h: Rename include guard.
 432         * mi/mi-console.h: Rename include guard.
 433         * mi/mi-common.h: Rename include guard.
 434         * mi/mi-cmds.h: Rename include guard.
 435         * mi/mi-cmd-break.h: Rename include guard.
 436         * m2-lang.h: Add include guard.
 437         * location.h: Rename include guard.
 438         * linux-record.h: Rename include guard.
 439         * linux-nat.h: Add include guard.
 440         * linux-fork.h: Add include guard.
 441         * i386-darwin-tdep.h: Rename include guard.
 442         * hppa-linux-offsets.h: Add include guard.
 443         * guile/guile.h: Rename include guard.
 444         * guile/guile-internal.h: Rename include guard.
 445         * gnu-nat.h: Rename include guard.
 446         * gdb-stabs.h: Rename include guard.
 447         * frv-tdep.h: Add include guard.
 448         * f-lang.h: Add include guard.
 449         * event-loop.h: Add include guard.
 450         * darwin-nat.h: Rename include guard.
 451         * cp-abi.h: Rename include guard.
 452         * config/sparc/nm-sol2.h: Rename include guard.
 453         * config/nm-nto.h: Rename include guard.
 454         * config/nm-linux.h: Add include guard.
 455         * config/i386/nm-i386gnu.h: Rename include guard.
 456         * config/djgpp/nl_types.h: Rename include guard.
 457         * config/djgpp/langinfo.h: Rename include guard.
 458         * compile/gcc-cp-plugin.h: Add include guard.
 459         * compile/gcc-c-plugin.h: Add include guard.
 460         * compile/compile.h: Rename include guard.
 461         * compile/compile-object-run.h: Rename include guard.
 462         * compile/compile-object-load.h: Rename include guard.
 463         * compile/compile-internal.h: Rename include guard.
 464         * compile/compile-cplus.h: Rename include guard.
 465         * compile/compile-c.h: Rename include guard.
 466         * common/xml-utils.h: Rename include guard.
 467         * common/x86-xstate.h: Rename include guard.
 468         * common/version.h: Rename include guard.
 469         * common/vec.h: Rename include guard.
 470         * common/tdesc.h: Rename include guard.
 471         * common/selftest.h: Rename include guard.
 472         * common/scoped_restore.h: Rename include guard.
 473         * common/scoped_mmap.h: Rename include guard.
 474         * common/scoped_fd.h: Rename include guard.
 475         * common/safe-iterator.h: Rename include guard.
 476         * common/run-time-clock.h: Rename include guard.
 477         * common/refcounted-object.h: Rename include guard.
 478         * common/queue.h: Rename include guard.
 479         * common/ptid.h: Rename include guard.
 480         * common/print-utils.h: Rename include guard.
 481         * common/preprocessor.h: Rename include guard.
 482         * common/pathstuff.h: Rename include guard.
 483         * common/observable.h: Rename include guard.
 484         * common/netstuff.h: Rename include guard.
 485         * common/job-control.h: Rename include guard.
 486         * common/host-defs.h: Rename include guard.
 487         * common/gdb_wait.h: Rename include guard.
 488         * common/gdb_vecs.h: Rename include guard.
 489         * common/gdb_unlinker.h: Rename include guard.
 490         * common/gdb_unique_ptr.h: Rename include guard.
 491         * common/gdb_tilde_expand.h: Rename include guard.
 492         * common/gdb_sys_time.h: Rename include guard.
 493         * common/gdb_string_view.h: Rename include guard.
 494         * common/gdb_splay_tree.h: Rename include guard.
 495         * common/gdb_setjmp.h: Rename include guard.
 496         * common/gdb_ref_ptr.h: Rename include guard.
 497         * common/gdb_optional.h: Rename include guard.
 498         * common/gdb_locale.h: Rename include guard.
 499         * common/gdb_assert.h: Rename include guard.
 500         * common/filtered-iterator.h: Rename include guard.
 501         * common/filestuff.h: Rename include guard.
 502         * common/fileio.h: Rename include guard.
 503         * common/environ.h: Rename include guard.
 504         * common/common-utils.h: Rename include guard.
 505         * common/common-types.h: Rename include guard.
 506         * common/common-regcache.h: Rename include guard.
 507         * common/common-inferior.h: Rename include guard.
 508         * common/common-gdbthread.h: Rename include guard.
 509         * common/common-exceptions.h: Rename include guard.
 510         * common/common-defs.h: Rename include guard.
 511         * common/common-debug.h: Rename include guard.
 512         * common/cleanups.h: Rename include guard.
 513         * common/buffer.h: Rename include guard.
 514         * common/btrace-common.h: Rename include guard.
 515         * common/break-common.h: Rename include guard.
 516         * cli/cli-utils.h: Rename include guard.
 517         * cli/cli-style.h: Rename include guard.
 518         * cli/cli-setshow.h: Rename include guard.
 519         * cli/cli-script.h: Rename include guard.
 520         * cli/cli-interp.h: Rename include guard.
 521         * cli/cli-decode.h: Rename include guard.
 522         * cli/cli-cmds.h: Rename include guard.
 523         * charset-list.h: Add include guard.
 524         * buildsym-legacy.h: Rename include guard.
 525         * bfin-tdep.h: Add include guard.
 526         * ax.h: Rename include guard.
 527         * arm-linux-tdep.h: Add include guard.
 528         * arm-fbsd-tdep.h: Add include guard.
 529         * arch/xtensa.h: Rename include guard.
 530         * arch/tic6x.h: Add include guard.
 531         * arch/i386.h: Add include guard.
 532         * arch/arm.h: Rename include guard.
 533         * arch/arm-linux.h: Rename include guard.
 534         * arch/arm-get-next-pcs.h: Rename include guard.
 535         * arch/amd64.h: Add include guard.
 536         * arch/aarch64-insn.h: Rename include guard.
 537         * arch-utils.h: Rename include guard.
 538         * annotate.h: Add include guard.
 539         * amd64-darwin-tdep.h: Rename include guard.
 540         * aarch64-linux-tdep.h: Add include guard.
 541         * aarch64-fbsd-tdep.h: Add include guard.
 542         * aarch32-linux-nat.h: Add include guard.
 543
 544 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 545
 546         * macrotab.c (macro_define_internal): New function that
 547         factorizes macro_define_object_internal and macro_define_function
 548         code.
 549         (macro_define_object_internal): Use macro_define_internal.
 550         (macro_define_function): Likewise.
 551
 552 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 553
 554         * macrocmd.c (extract_identifier): Return
 555         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
 556         callers.
 557
 558 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
 559
 560         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
 561
 562 2019-02-05  Tom Tromey  <tom@tromey.com>
 563
 564         * target.c (target_stack::unpush): Move assertion earlier.
 565
 566 2019-01-30  Tom Tromey  <tom@tromey.com>
 567
 568         PR python/23615:
 569         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
 570         (gdbpy_parse_and_eval): Likewise.
 571         * python/python-internal.h (gdbpy_allow_threads): New class.
 572
 573 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
 574
 575         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
 576         (aarch64_fbsd_fpregmap): Move earlier.
 577         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
 578         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 579         instead of individual calls to trad_frame_set_reg_addr.
 580         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
 581         earlier.
 582         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
 583         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 584         instead of individual calls to trad_frame_set_reg_addr.
 585
 586 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
 587
 588         * CONTRIBUTE: Replace contribution list with wiki link.
 589
 590 2019-01-25  Tom Tromey  <tom@tromey.com>
 591
 592         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
 593
 594 2019-01-25  Tom Tromey  <tom@tromey.com>
 595
 596         * xtensa-linux-nat.c: Fix common/ includes.
 597         * xml-support.h: Fix common/ includes.
 598         * xml-support.c: Fix common/ includes.
 599         * x86-linux-nat.c: Fix common/ includes.
 600         * windows-nat.c: Fix common/ includes.
 601         * varobj.h: Fix common/ includes.
 602         * varobj.c: Fix common/ includes.
 603         * value.c: Fix common/ includes.
 604         * valops.c: Fix common/ includes.
 605         * utils.c: Fix common/ includes.
 606         * unittests/xml-utils-selftests.c: Fix common/ includes.
 607         * unittests/utils-selftests.c: Fix common/ includes.
 608         * unittests/unpack-selftests.c: Fix common/ includes.
 609         * unittests/tracepoint-selftests.c: Fix common/ includes.
 610         * unittests/style-selftests.c: Fix common/ includes.
 611         * unittests/string_view-selftests.c: Fix common/ includes.
 612         * unittests/scoped_restore-selftests.c: Fix common/ includes.
 613         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
 614         * unittests/scoped_fd-selftests.c: Fix common/ includes.
 615         * unittests/rsp-low-selftests.c: Fix common/ includes.
 616         * unittests/parse-connection-spec-selftests.c: Fix common/
 617         includes.
 618         * unittests/optional-selftests.c: Fix common/ includes.
 619         * unittests/offset-type-selftests.c: Fix common/ includes.
 620         * unittests/observable-selftests.c: Fix common/ includes.
 621         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
 622         * unittests/memrange-selftests.c: Fix common/ includes.
 623         * unittests/memory-map-selftests.c: Fix common/ includes.
 624         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
 625         * unittests/function-view-selftests.c: Fix common/ includes.
 626         * unittests/environ-selftests.c: Fix common/ includes.
 627         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
 628         * unittests/common-utils-selftests.c: Fix common/ includes.
 629         * unittests/cli-utils-selftests.c: Fix common/ includes.
 630         * unittests/array-view-selftests.c: Fix common/ includes.
 631         * ui-file.c: Fix common/ includes.
 632         * tui/tui-io.c: Fix common/ includes.
 633         * tracepoint.h: Fix common/ includes.
 634         * tracepoint.c: Fix common/ includes.
 635         * tracefile-tfile.c: Fix common/ includes.
 636         * top.h: Fix common/ includes.
 637         * top.c: Fix common/ includes.
 638         * thread.c: Fix common/ includes.
 639         * target/waitstatus.h: Fix common/ includes.
 640         * target/waitstatus.c: Fix common/ includes.
 641         * target.h: Fix common/ includes.
 642         * target.c: Fix common/ includes.
 643         * target-memory.c: Fix common/ includes.
 644         * target-descriptions.c: Fix common/ includes.
 645         * symtab.h: Fix common/ includes.
 646         * symfile.c: Fix common/ includes.
 647         * stap-probe.c: Fix common/ includes.
 648         * spu-linux-nat.c: Fix common/ includes.
 649         * sparc-nat.c: Fix common/ includes.
 650         * source.c: Fix common/ includes.
 651         * solib.c: Fix common/ includes.
 652         * solib-target.c: Fix common/ includes.
 653         * ser-unix.c: Fix common/ includes.
 654         * ser-tcp.c: Fix common/ includes.
 655         * ser-pipe.c: Fix common/ includes.
 656         * ser-base.c: Fix common/ includes.
 657         * selftest-arch.c: Fix common/ includes.
 658         * s12z-tdep.c: Fix common/ includes.
 659         * rust-exp.y: Fix common/ includes.
 660         * rs6000-aix-tdep.c: Fix common/ includes.
 661         * riscv-tdep.c: Fix common/ includes.
 662         * remote.c: Fix common/ includes.
 663         * remote-notif.h: Fix common/ includes.
 664         * remote-fileio.h: Fix common/ includes.
 665         * remote-fileio.c: Fix common/ includes.
 666         * regcache.h: Fix common/ includes.
 667         * regcache.c: Fix common/ includes.
 668         * record-btrace.c: Fix common/ includes.
 669         * python/python.c: Fix common/ includes.
 670         * python/py-type.c: Fix common/ includes.
 671         * python/py-inferior.c: Fix common/ includes.
 672         * progspace.h: Fix common/ includes.
 673         * producer.c: Fix common/ includes.
 674         * procfs.c: Fix common/ includes.
 675         * proc-api.c: Fix common/ includes.
 676         * printcmd.c: Fix common/ includes.
 677         * ppc-linux-nat.c: Fix common/ includes.
 678         * parser-defs.h: Fix common/ includes.
 679         * osdata.c: Fix common/ includes.
 680         * obsd-nat.c: Fix common/ includes.
 681         * nat/x86-linux.c: Fix common/ includes.
 682         * nat/x86-linux-dregs.c: Fix common/ includes.
 683         * nat/x86-dregs.h: Fix common/ includes.
 684         * nat/x86-dregs.c: Fix common/ includes.
 685         * nat/ppc-linux.c: Fix common/ includes.
 686         * nat/mips-linux-watch.h: Fix common/ includes.
 687         * nat/mips-linux-watch.c: Fix common/ includes.
 688         * nat/linux-waitpid.c: Fix common/ includes.
 689         * nat/linux-ptrace.h: Fix common/ includes.
 690         * nat/linux-ptrace.c: Fix common/ includes.
 691         * nat/linux-procfs.c: Fix common/ includes.
 692         * nat/linux-personality.c: Fix common/ includes.
 693         * nat/linux-osdata.c: Fix common/ includes.
 694         * nat/linux-namespaces.c: Fix common/ includes.
 695         * nat/linux-btrace.h: Fix common/ includes.
 696         * nat/linux-btrace.c: Fix common/ includes.
 697         * nat/fork-inferior.c: Fix common/ includes.
 698         * nat/amd64-linux-siginfo.c: Fix common/ includes.
 699         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
 700         * nat/aarch64-linux.c: Fix common/ includes.
 701         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
 702         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
 703         * namespace.h: Fix common/ includes.
 704         * mips-linux-tdep.c: Fix common/ includes.
 705         * minsyms.c: Fix common/ includes.
 706         * mi/mi-parse.h: Fix common/ includes.
 707         * mi/mi-main.c: Fix common/ includes.
 708         * mi/mi-cmd-env.c: Fix common/ includes.
 709         * memrange.h: Fix common/ includes.
 710         * memattr.c: Fix common/ includes.
 711         * maint.h: Fix common/ includes.
 712         * maint.c: Fix common/ includes.
 713         * main.c: Fix common/ includes.
 714         * machoread.c: Fix common/ includes.
 715         * location.c: Fix common/ includes.
 716         * linux-thread-db.c: Fix common/ includes.
 717         * linux-nat.c: Fix common/ includes.
 718         * linux-fork.c: Fix common/ includes.
 719         * inline-frame.c: Fix common/ includes.
 720         * infrun.c: Fix common/ includes.
 721         * inflow.c: Fix common/ includes.
 722         * inferior.h: Fix common/ includes.
 723         * inferior.c: Fix common/ includes.
 724         * infcmd.c: Fix common/ includes.
 725         * inf-ptrace.c: Fix common/ includes.
 726         * inf-child.c: Fix common/ includes.
 727         * ia64-linux-nat.c: Fix common/ includes.
 728         * i387-tdep.c: Fix common/ includes.
 729         * i386-tdep.c: Fix common/ includes.
 730         * i386-linux-tdep.c: Fix common/ includes.
 731         * i386-linux-nat.c: Fix common/ includes.
 732         * i386-go32-tdep.c: Fix common/ includes.
 733         * i386-fbsd-tdep.c: Fix common/ includes.
 734         * i386-fbsd-nat.c: Fix common/ includes.
 735         * guile/scm-type.c: Fix common/ includes.
 736         * guile/guile.c: Fix common/ includes.
 737         * go32-nat.c: Fix common/ includes.
 738         * gnu-nat.c: Fix common/ includes.
 739         * gdbthread.h: Fix common/ includes.
 740         * gdbarch-selftests.c: Fix common/ includes.
 741         * gdb_usleep.c: Fix common/ includes.
 742         * gdb_select.h: Fix common/ includes.
 743         * gdb_bfd.c: Fix common/ includes.
 744         * gcore.c: Fix common/ includes.
 745         * fork-child.c: Fix common/ includes.
 746         * findvar.c: Fix common/ includes.
 747         * fbsd-nat.c: Fix common/ includes.
 748         * event-top.c: Fix common/ includes.
 749         * event-loop.c: Fix common/ includes.
 750         * dwarf2read.c: Fix common/ includes.
 751         * dwarf2loc.c: Fix common/ includes.
 752         * dwarf2-frame.c: Fix common/ includes.
 753         * dwarf-index-cache.c: Fix common/ includes.
 754         * dtrace-probe.c: Fix common/ includes.
 755         * disasm-selftests.c: Fix common/ includes.
 756         * defs.h: Fix common/ includes.
 757         * csky-tdep.c: Fix common/ includes.
 758         * cp-valprint.c: Fix common/ includes.
 759         * cp-support.h: Fix common/ includes.
 760         * cp-support.c: Fix common/ includes.
 761         * corelow.c: Fix common/ includes.
 762         * completer.h: Fix common/ includes.
 763         * completer.c: Fix common/ includes.
 764         * compile/compile.c: Fix common/ includes.
 765         * compile/compile-loc2c.c: Fix common/ includes.
 766         * compile/compile-cplus-types.c: Fix common/ includes.
 767         * compile/compile-cplus-symbols.c: Fix common/ includes.
 768         * command.h: Fix common/ includes.
 769         * cli/cli-dump.c: Fix common/ includes.
 770         * cli/cli-cmds.c: Fix common/ includes.
 771         * charset.c: Fix common/ includes.
 772         * build-id.c: Fix common/ includes.
 773         * btrace.h: Fix common/ includes.
 774         * btrace.c: Fix common/ includes.
 775         * breakpoint.h: Fix common/ includes.
 776         * breakpoint.c: Fix common/ includes.
 777         * ax.h:
 778         (enum agent_op): Fix common/ includes.
 779         * ax-general.c (struct aop_map): Fix common/ includes.
 780         * ax-gdb.c: Fix common/ includes.
 781         * auxv.c: Fix common/ includes.
 782         * auto-load.c: Fix common/ includes.
 783         * arm-tdep.c: Fix common/ includes.
 784         * arch/riscv.c: Fix common/ includes.
 785         * arch/ppc-linux-common.c: Fix common/ includes.
 786         * arch/i386.c: Fix common/ includes.
 787         * arch/arm.c: Fix common/ includes.
 788         * arch/arm-linux.c: Fix common/ includes.
 789         * arch/arm-get-next-pcs.c: Fix common/ includes.
 790         * arch/amd64.c: Fix common/ includes.
 791         * arch/aarch64.c: Fix common/ includes.
 792         * arch/aarch64-insn.c: Fix common/ includes.
 793         * arch-utils.c: Fix common/ includes.
 794         * amd64-windows-tdep.c: Fix common/ includes.
 795         * amd64-tdep.c: Fix common/ includes.
 796         * amd64-sol2-tdep.c: Fix common/ includes.
 797         * amd64-obsd-tdep.c: Fix common/ includes.
 798         * amd64-nbsd-tdep.c: Fix common/ includes.
 799         * amd64-linux-tdep.c: Fix common/ includes.
 800         * amd64-linux-nat.c: Fix common/ includes.
 801         * amd64-fbsd-tdep.c: Fix common/ includes.
 802         * amd64-fbsd-nat.c: Fix common/ includes.
 803         * amd64-dicos-tdep.c: Fix common/ includes.
 804         * amd64-darwin-tdep.c: Fix common/ includes.
 805         * agent.c: Fix common/ includes.
 806         * ada-lang.h: Fix common/ includes.
 807         * ada-lang.c: Fix common/ includes.
 808         * aarch64-tdep.c: Fix common/ includes.
 809
 810 2019-01-25  Tom Tromey  <tom@tromey.com>
 811
 812         * common/create-version.sh: Use common/version.h.
 813
 814 2019-01-24  Pedro Alves  <palves@redhat.com>
 815
 816         * infrun.c (signal_stop, signal_print, signal_program)
 817         (signal_catch, signal_pass): Now arrays instead of pointers.
 818         (update_signals_program_target, do_target_resume)
 819         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
 820         * linux-nat.c (linux_nat_target::pass_signals)
 821         (linux_nat_target::create_inferior, linux_nat_target::attach):
 822         Adjust.
 823         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
 824         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
 825         * procfs.c (procfs_target::pass_signals): Adjust.
 826         * record-full.c (record_full_target::resume): Adjust.
 827         * remote.c (remote_target::pass_signals)
 828         (remote_target::program_signals): Adjust.
 829         * target-debug.h (target_debug_print_signals): Now takes a
 830         gdb::array_view as parameter.  Adjust.
 831         * target.h (target_ops) <pass_signals, program_signals>: Replace
 832         pointer and length parameters with gdb::array_view.
 833         (target_pass_signals, target_program_signals): Likewise.
 834         * target-delegates.c: Regenerate.
 835
 836 2019-01-24  Pedro Alves  <palves@redhat.com>
 837
 838         * common/forward-scope-exit.h
 839         (forward_scope_exit::forward_scope_exit): Pass arguments to
 840         m_bind_function directly, instead of creating a std::bind and
 841         copying that.
 842
 843 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
 844
 845         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 846         for static members.
 847         (pass_in_v_vfp_candidate): Likewise.
 848
 849 2019-01-23  Tom Tromey  <tom@tromey.com>
 850             Pedro Alves  <palves@redhat.com>
 851
 852         * regcache.c (class regcache_invalidator): Remove.
 853         (regcache::raw_write): Use make_scope_exit.
 854
 855 2019-01-23  Tom Tromey  <tom@tromey.com>
 856
 857         * ui-out.h (class ui_out_emit_type): Update comment.
 858
 859 2019-01-23  Tom Tromey  <tom@tromey.com>
 860
 861         * infrun.c (fetch_inferior_event): Update comment.
 862
 863 2019-01-23  Tom Tromey  <tom@tromey.com>
 864             Pedro Alves  <palves@redhat.com>
 865
 866         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
 867         parameter.
 868         (fetch_inferior_event): Use SCOPE_EXIT.
 869
 870
 871 2019-01-23  Tom Tromey  <tom@tromey.com>
 872             Pedro Alves  <palves@redhat.com>
 873
 874         * infrun.c (disable_thread_events): Delete.
 875         (stop_all_threads): Use SCOPE_EXIT.
 876
 877 2019-01-23  Tom Tromey  <tom@tromey.com>
 878             Pedro Alves  <palves@redhat.com>
 879
 880         * symfile.c: Include forward-scope-exit.h.
 881         (clear_symtab_users_cleanup): Replace forward declaration with
 882         a FORWARD_SCOPE_EXIT.
 883         (syms_from_objfile_1): Use the forward_scope_exit and
 884         gdb::optional instead of cleanup_function.
 885         (reread_symbols): Use the forward_scope_exit instead of
 886         cleanup_function.
 887         (clear_symtab_users_cleanup): Remove function.
 888
 889 2019-01-23  Tom Tromey  <tom@tromey.com>
 890             Pedro Alves  <palves@redhat.com>
 891
 892         * linux-nat.c: Include scope-exit.h.
 893         (cleanup_target_stop): Remove.
 894         (linux_nat_target::static_tracepoint_markers_by_strid): Use
 895         SCOPE_EXIT.
 896
 897 2019-01-23  Tom Tromey  <tom@tromey.com>
 898             Pedro Alves  <palves@redhat.com>
 899
 900         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
 901         (call_function_by_hand_dummy): Use SCOPE_EXIT.
 902
 903 2019-01-23  Tom Tromey  <tom@tromey.com>
 904             Andrew Burgess  <andrew.burgess@embecosm.com>
 905             Pedro Alves  <palves@redhat.com>
 906
 907         * infrun.c (fetch_inferior_event): Use scope_exit.
 908         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
 909         * top.c (execute_command): Use scope_exit.
 910         * breakpoint.c (bpstat_do_actions): Use scope_exit.
 911         * utils.c (do_bpstat_clear_actions_cleanup)
 912         (make_bpstat_clear_actions_cleanup): Remove.
 913
 914 2019-01-23  Tom Tromey  <tom@tromey.com>
 915             Pedro Alves  <palves@redhat.com>
 916
 917         * infrun.c: Include "common/scope-exit.h"
 918         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
 919         (wait_for_inferior): Use SCOPE_EXIT.
 920         (fetch_inferior_event): Use scope_exit.
 921
 922 2019-01-23  Tom Tromey  <tom@tromey.com>
 923             Pedro Alves  <palves@redhat.com>
 924
 925         * breakpoint.c (create_breakpoint): Remove cleanup.
 926
 927 2019-01-23  Tom Tromey  <tom@tromey.com>
 928             Andrew Burgess  <andrew.burgess@embecosm.com>
 929             Pedro Alves  <palves@redhat.com>
 930
 931 2019-01-23  Pedro Alves  <palves@redhat.com>
 932
 933         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
 934
 935 2019-01-23  Pedro Alves  <palves@redhat.com>
 936             Andrew Burgess  <andrew.burgess@embecosm.com>
 937
 938         * gdbthread.h: Include "common/forward-scope-exit.h".
 939         (scoped_finish_thread_state): Redefine custom class in terms of
 940         forward_scope_exit.
 941
 942 2019-01-23  Pedro Alves  <palves@redhat.com>
 943             Andrew Burgess  <andrew.burgess@embecosm.com>
 944
 945         * common/forward-scope-exit.h: New file.
 946
 947 2019-01-23  Pedro Alves  <palves@redhat.com>
 948             Andrew Burgess  <andrew.burgess@embecosm.com>
 949             Tom Tromey  <tom@tromey.com>
 950
 951         * common/scope-exit.h: New file.
 952
 953 2019-01-23  Pedro Alves  <palves@redhat.com>
 954
 955         * common/preprocessor.h (ESC): Rename to ...
 956         (ESC_PARENS): ... this.
 957         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
 958         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
 959
 960 2019-01-23  Tom Tromey  <tom@tromey.com>
 961
 962         * language.h (class scoped_switch_to_sym_language_if_auto):
 963         Initialize m_lang in both cases.
 964
 965 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
 966
 967         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
 968         with XCNEW.
 969
 970 2019-01-22  Tom Tromey  <tom@tromey.com>
 971
 972         * corelow.c: Do not include sys/file.h.
 973
 974 2019-01-22  Tom Tromey  <tom@tromey.com>
 975
 976         * tui/tui-wingeneral.h: Include gdb_curses.h.
 977
 978 2019-01-22  Tom Tromey  <tom@tromey.com>
 979
 980         * source-cache.h (class source_cache) <get_source_lines,
 981         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
 982
 983 2019-01-22  Tom Tromey  <tom@tromey.com>
 984
 985         * remote-fileio.h (struct remote_target): Declare.
 986
 987 2019-01-22  Tom Tromey  <tom@tromey.com>
 988
 989         * python/py-arch.c: Do not include py-ref.h.
 990         * python/py-bpevent.c: Do not include py-ref.h.
 991         * python/py-cmd.c: Do not include py-ref.h.
 992         * python/py-continueevent.c: Do not include py-ref.h.
 993         * python/py-event.h: Do not include py-ref.h.
 994         * python/py-evtregistry.c: Do not include py-ref.h.
 995         * python/py-finishbreakpoint.c: Do not include py-ref.h.
 996         * python/py-frame.c: Do not include py-ref.h.
 997         * python/py-framefilter.c: Do not include py-ref.h.
 998         * python/py-function.c: Do not include py-ref.h.
 999         * python/py-infevents.c: Do not include py-ref.h.
1000         * python/py-linetable.c: Do not include py-ref.h.
1001         * python/py-objfile.c: Do not include py-ref.h.
1002         * python/py-param.c: Do not include py-ref.h.
1003         * python/py-prettyprint.c: Do not include py-ref.h.
1004         * python/py-progspace.c: Do not include py-ref.h.
1005         * python/py-symbol.c: Do not include py-ref.h.
1006         * python/py-symtab.c: Do not include py-ref.h.
1007         * python/py-type.c: Do not include py-ref.h.
1008         * python/py-unwind.c: Do not include py-ref.h.
1009         * python/py-utils.c: Do not include py-ref.h.
1010         * python/py-value.c: Do not include py-ref.h.
1011         * python/py-varobj.c: Do not include py-ref.h.
1012         * python/py-xmethods.c: Do not include py-ref.h.
1013         * python/python.c: Do not include py-ref.h.
1014         * varobj.c: Do not include py-ref.h.
1015
1016 2019-01-22  Tom Tromey  <tom@tromey.com>
1017
1018         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1019         keyword for bcache.
1020
1021 2019-01-22  Tom Tromey  <tom@tromey.com>
1022
1023         * compile/compile-cplus-types.c: Remove a comment by #include.
1024
1025 2019-01-22  Tom Tromey  <tom@tromey.com>
1026
1027         * compile/gcc-c-plugin.h: Include compile-internal.h.
1028
1029 2019-01-22  Tom Tromey  <tom@tromey.com>
1030
1031         * stabsread.c (EXTERN): Do not define.
1032         (symnum, next_symbol_text_func, processing_gcc_compilation)
1033         (within_function, global_sym_chain, global_stabs)
1034         (previous_stab_code, this_object_header_files)
1035         (n_this_object_header_files)
1036         (n_allocated_this_object_header_files): Define.
1037         * stabsread.h (EXTERN): Never define.  Use "extern".
1038
1039 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1040
1041         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1042         history_value.
1043
1044 2019-01-21  Tom Tromey  <tom@tromey.com>
1045
1046         * ui-out.c: Fix includes.
1047         * tui/tui-source.c: Fix includes.
1048         * target.c: Fix includes.
1049         * remote.c: Fix includes.
1050         * regcache.c: Fix includes.
1051         * python/py-block.c: Fix includes.
1052         * printcmd.c: Fix includes.
1053         * or1k-tdep.c: Fix includes.
1054         * mi/mi-main.c: Fix includes.
1055         * m32r-tdep.c: Fix includes.
1056         * csky-tdep.c: Fix includes.
1057         * compile/compile-cplus-types.c: Fix includes.
1058         * cli/cli-interp.c: Fix includes.
1059
1060 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1061
1062         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1063         for padding.
1064
1065 2019-01-16  Tom Tromey  <tom@tromey.com>
1066
1067         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1068         earlier.
1069         (struct objfile) <msymbols_range>: Move from top level.
1070         <msymbols>: New method.
1071         (class objfile_msymbols): Remove.
1072         * symtab.c (default_collect_symbol_completion_matches_break_on):
1073         Update.
1074         * symmisc.c (dump_msymbols): Update.
1075         * stabsread.c (scan_file_globals): Update.
1076         * objc-lang.c (info_selectors_command, info_classes_command)
1077         (find_methods): Update.
1078         * minsyms.c (find_solib_trampoline_target): Update.
1079         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1080         * coffread.c (coff_symfile_read): Update.
1081         * ada-lang.c (ada_lookup_simple_minsym)
1082         (ada_collect_symbol_completion_matches): Update.
1083
1084 2019-01-16  Tom Tromey  <tom@tromey.com>
1085
1086         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1087         type.  Remove no-argument constructor.
1088         <iterator::operator++>: Simplify.
1089         <begin>: Update.
1090         <end>: Use minimal_symbol_count.
1091
1092 2019-01-16  Tom Tromey  <tom@tromey.com>
1093
1094         * objfiles.h (struct objfile) <psymtabs>: New method.
1095         (class objfile_psymtabs): Remove.
1096         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1097         typedef.
1098         <range>: New method.
1099         (require_partial_symbols): Change return type.
1100         * psymtab.c (require_partial_symbols)
1101         (psym_expand_symtabs_matching): Update.
1102         * mdebugread.c (parse_partial_symbols): Update.
1103         * dbxread.c (dbx_end_psymtab): Update.
1104
1105 2019-01-15  Tom Tromey  <tom@tromey.com>
1106
1107         * symtab.c (lookup_objfile_from_block)
1108         (lookup_symbol_in_objfile_symtabs)
1109         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1110         (find_line_symtab, info_sources_command)
1111         (default_collect_symbol_completion_matches_break_on)
1112         (make_source_files_completion_list): Update.
1113         * symmisc.c (print_objfile_statistics, dump_objfile)
1114         (maintenance_print_symbols, maintenance_info_symtabs)
1115         (maintenance_check_symtabs, maintenance_info_line_tables):
1116         Update.
1117         * source.c (select_source_symtab)
1118         (forget_cached_source_info_for_objfile): Update.
1119         * objfiles.h (class objfile_compunits): Remove.
1120         (struct objfile) <compunits_range>: New typedef.
1121         (compunits): New method.
1122         * objfiles.c (objfile_relocate1): Update.
1123         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1124         * maint.c (count_symtabs_and_blocks): Update.
1125         * linespec.c (iterate_over_all_matching_symtabs): Update.
1126         * cp-support.c (add_symbol_overload_list_qualified): Update.
1127         * coffread.c (coff_symtab_read): Update.
1128         * ada-lang.c (add_nonlocal_symbols)
1129         (ada_collect_symbol_completion_matches)
1130         (ada_add_global_exceptions): Update.
1131
1132 2019-01-15  Tom Tromey  <tom@tromey.com>
1133
1134         * progspace.h (program_space) <objfiles_safe_range>: New
1135         typedef.
1136         <objfiles_safe>: New method.
1137         * objfiles.h (class all_objfiles_safe): Remove.
1138         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1139         * jit.c (jit_inferior_exit_hook): Update.
1140
1141 2019-01-17  Tom Tromey  <tom@tromey.com>
1142
1143         * progspace.h (program_space) <objfiles_range>: New typedef.
1144         <objfiles>: New method.
1145         <objfiles_head>: Rename from objfiles.
1146         (object_files): Update.
1147         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1148         * guile/scm-pretty-print.c
1149         (ppscm_find_pretty_printer_from_objfiles): Update.
1150         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1151         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1152         Update.
1153         * python/py-progspace.c (pspy_get_objfiles): Update.
1154         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1155         Update.
1156         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1157         (objfpy_lookup_objfile_by_build_id): Update.
1158         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1159         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1160         Update.
1161         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1162         (expand_symtab_containing_pc, lookup_objfile_from_block)
1163         (lookup_static_symbol, basic_lookup_transparent_type)
1164         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1165         (find_line_symtab, info_sources_command)
1166         (default_collect_symbol_completion_matches_break_on)
1167         (make_source_files_completion_list, find_main_name): Update.
1168         * symmisc.c (print_symbol_bcache_statistics)
1169         (print_objfile_statistics, maintenance_print_symbols)
1170         (maintenance_print_msymbols, maintenance_print_objfiles)
1171         (maintenance_info_symtabs, maintenance_check_symtabs)
1172         (maintenance_expand_symtabs, maintenance_info_line_tables):
1173         Update.
1174         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1175         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1176         (map_overlay_command, unmap_overlay_command)
1177         (simple_overlay_update, expand_symtabs_matching)
1178         (map_symbol_filenames): Update.
1179         * symfile-debug.c (set_debug_symfile): Update.
1180         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1181         Update.
1182         * source.c (select_source_symtab, forget_cached_source_info):
1183         Update.
1184         * solib.c (solib_read_symbols): Update.
1185         * solib-spu.c (append_ocl_sos): Update.
1186         * psymtab.c (maintenance_print_psymbols)
1187         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1188         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1189         * printcmd.c (info_symbol_command): Update.
1190         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1191         Update.
1192         * objfiles.h (class all_objfiles): Remove.
1193         * objfiles.c (have_partial_symbols, have_full_symbols)
1194         (have_minimal_symbols, qsort_cmp, update_section_map)
1195         (shared_objfile_contains_address_p)
1196         (default_iterate_over_objfiles_in_search_order): Update.
1197         * objc-lang.c (info_selectors_command, info_classes_command)
1198         (find_methods): Update.
1199         * minsyms.c (find_solib_trampoline_target): Update.
1200         * maint.c (maintenance_info_sections)
1201         (maintenance_translate_address, count_symtabs_and_blocks):
1202         Update.
1203         * main.c (captured_main_1): Update.
1204         * linux-thread-db.c (try_thread_db_load_from_pdir)
1205         (has_libpthread): Update.
1206         * linespec.c (iterate_over_all_matching_symtabs)
1207         (search_minsyms_for_name): Update.
1208         * jit.c (jit_find_objf_with_entry_addr): Update.
1209         * hppa-tdep.c (find_unwind_entry)
1210         (hppa_lookup_stub_minimal_symbol): Update.
1211         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1212         Update.
1213         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1214         (elf_gnu_ifunc_resolve_by_got): Update.
1215         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1216         * dwarf-index-write.c (save_gdb_index_command): Update.
1217         * cp-support.c (add_symbol_overload_list_qualified): Update.
1218         * breakpoint.c (create_overlay_event_breakpoint)
1219         (create_longjmp_master_breakpoint)
1220         (create_std_terminate_master_breakpoint)
1221         (create_exception_master_breakpoint): Update.
1222         * blockframe.c (find_pc_partial_function): Update.
1223         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1224         (ada_collect_symbol_completion_matches)
1225         (ada_add_global_exceptions): Update.
1226
1227 2019-01-17  Tom Tromey  <tom@tromey.com>
1228
1229         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1230         declare VEC.
1231         (solib_target_parse_libraries): Change return type.
1232         (library_list_start_segment, library_list_start_section)
1233         (library_list_end_library, library_list_start_library); Update.
1234         (solib_target_free_library_list): Remove.
1235         (solib_target_parse_libraries): Remove cleanup.  Change return
1236         type.
1237         (solib_target_current_sos): Update.
1238
1239 2019-01-17  Tom Tromey  <tromey@bapiya>
1240
1241         * valprint.c: Replace "the the" with "the".
1242         * symtab.c: Replace "the the" with "the".
1243         * solib.c: Replace "the the" with "the".
1244         * solib-dsbt.c: Replace "the the" with "the".
1245         * linespec.c: Replace "the the" with "the".
1246         * dwarf2loc.h: Replace "the the" with "the".
1247         * amd64-windows-tdep.c: Replace "the the" with "the".
1248         * aarch64-tdep.c: Replace "the the" with "the".
1249
1250 2019-01-16  Keith Seitz  <keiths@redhat.com>
1251
1252         PR gdb/23773
1253         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1254         <builder>: Rename to ..
1255         <m_builder>: ... this and make private.
1256         (dwarf2_cu::get_builder): New method.  Change all users of
1257         `builder' to use this method.
1258         (dwarf2_start_symtab): Move to ...
1259         (dwarf2_cu::start_symtab): ... here.  Update all callers
1260         (setup_type_unit_groups): Move to ...
1261         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1262         callers.
1263         (dwarf2_cu::reset_builder): New method.
1264         (process_full_compunit, process_full_type_unit): Use
1265         dwarf2_cu::reset_builder.
1266         (follow_die_offset): Record the ancestor CU if it is different
1267         from the followed DIE's CU.
1268         (follow_die_sig_1): Likewise.
1269
1270 2019-01-15  Tom Tromey  <tom@tromey.com>
1271
1272         * remote.c (class remote_state) <buf>: Now a char_vector.
1273         <buf_size>: Remove.
1274         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1275         parameter.
1276         (remote_target::getpkt_or_notif_sane_1)
1277         (remote_target::getpkt_sane)
1278         (remote_target::getpkt_or_notif_sane): Likewise.
1279         (class remote_target) <putpkt>: New overload.
1280         (remote_target::read_frame): Change type of "buf_p".  Remove
1281         sizeof_p parameter.
1282         (packet_ok): New overload.
1283         (packet_check_result): New overload.
1284         Update all uses.
1285
1286 2019-01-14  Tom Tromey  <tom@tromey.com>
1287
1288         * remote-notif.c (handle_notification, remote_notif_ack)
1289         (remote_notif_parse): Make "buf" const.
1290         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1291         const.
1292         (remote_notif_parse, remote_notif_ack, handle_notification):
1293         Likewise.
1294         * remote.c (remote_notif_stop_parse): Make "buf" const.
1295         (remote_target::remote_parse_stop_reply): Make "buf" const.
1296         (remote_notif_stop_ack): Make "buf" const.
1297
1298 2019-01-14  Tom Tromey  <tom@tromey.com>
1299
1300         * remote.c (remote_console_output): Make parameter const.
1301
1302 2019-01-14  Tom Tromey  <tom@tromey.com>
1303
1304         * target-debug.h (target_debug_print_signals): Constify.
1305         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1306         * procfs.c (procfs_target::pass_signals): Update.
1307         * linux-nat.c (linux_nat_target::pass_signals): Update.
1308         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1309         * target-delegates.c: Rebuild.
1310         * remote.c (remote_target::program_signals): Update.
1311         (remote_target::pass_signals): Update.
1312         * target.c (target_pass_signals): Constify argument.
1313         (target_program_signals): Likewise.
1314         * target.h (struct target_ops) <pass_signals, program_signals>:
1315         Constify argument.
1316         (target_pass_signals, target_program_signals): Constify argument.
1317
1318 2019-01-14  Tom Tromey  <tom@tromey.com>
1319
1320         PR tui/28819:
1321         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1322
1323 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1324
1325         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1326         field.
1327         * rs6000-tdep.c: Include reggroups.h.
1328         (IS_V_ALIAS_PSEUDOREG): Define.
1329         (rs6000_register_name): Return names for the "vX" aliases.
1330         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1331         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1332         aliases.  Call default_register_reggroup_p for all other
1333         pseudo-registers.
1334         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1335         New functions.
1336         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1337         Handle "vX" aliases.
1338         (v_alias_pseudo_register_collect): New function.
1339         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1340         (rs6000_gdbarch_init): Initialize "vX" aliases as
1341         pseudo-registers.  Restore registration of
1342         rs6000_pseudo_register_reggroup_p with
1343         set_tdesc_pseudo_register_reggroup_p.
1344
1345 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1346
1347         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1348         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1349         set_gdbarch_num_pseudo_regs.
1350
1351 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1352
1353         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1354         Remove arg prefixname, add do_set and do_show.
1355         Add member functions set_list and show_list.
1356         * cli/cli-style.c (class cli_style_option): Update accordingly.
1357         (style_set_list): Move to file scope.
1358         (style_show_list): Likewise.
1359         (set_style): Call help_list.
1360         (show_style): Call cmd_show_list.
1361         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1362         Update to use the new macro.
1363
1364 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1365
1366         * ada-lang.c (_initialize_ada_language): Expand the help text
1367         for the "catch exception" command.
1368
1369 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1370
1371         * symtab.c (matching_obj_sections): Initialize obj,
1372         declare it closer to its usage.
1373
1374 2019-01-10  Tom Tromey  <tom@tromey.com>
1375
1376         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1377         (basic_inf_threads_range): Remove.
1378         (inf_threads_range, inf_non_exited_threads_range)
1379         (safe_inf_threads_range): Use next_adapter.
1380
1381 2019-01-10  Keith Seitz  <keiths@redhat.com>
1382
1383         PR gdb/23712
1384         PR symtab/23010
1385         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1386         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1387
1388 2019-01-10  Keith Seitz  <keiths@redhat.com>
1389
1390         PR gdb/23712
1391         PR symtab/23010
1392         * dictionary.c (pending_to_vector): Remove.
1393         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1394         Remove _1 suffix, replacing functions of the same name.  Update
1395         all callers.
1396         (dict_create_hashed, dict_create_hashed_expandable)
1397         (dict_create_linear, dict_create_linear_expandable, dict_free)
1398         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1399         Make functions static.
1400
1401 2019-01-10  Keith Seitz  <keiths@redhat.com>
1402
1403         PR gdb/23712
1404         PR symtab/23010
1405         * dictionary.h (struct dictionary): Replace declaration with
1406         multidictionary.
1407         (dict_create_hashed, dict_create_hashed_expandable)
1408         (dict_create_linear, dict_create_linear_expandable)
1409         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1410         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1411         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1412         taking multidictionary argument.
1413         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1414         * block.h (struct block) <dict>: Change to multidictionary
1415         and rename `multidict'.
1416         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1417         symmisc.c: Update all dictionary references to multidictionary.
1418
1419 2019-01-10  Keith Seitz  <keiths@redhat.com>
1420
1421         PR gdb/23712
1422         PR symtab/23010
1423         * dictionary.c: Include unordered_map.
1424         (pending_to_vector): New function.
1425         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1426         Rewrite the non-"_1" functions to take vector instead
1427         of linked list.
1428         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1429         "new" _1 versions of the same name.
1430         (multidictionary): Define.
1431         (std::hash<enum language): New definition.
1432         (collate_pending_symbols_by_language, mdict_create_hashed)
1433         (mdict_create_hashed_expandable, mdict_create_linear)
1434         (mdict_create_linear_expandable, mdict_free)
1435         (find_language_dictionary, create_new_language_dictionary)
1436         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1437         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1438         (mdict_size, mdict_empty): New functions.
1439         * dictionary.h (mdict_iterator): Define.
1440
1441 2019-01-10  Pedro Alves  <palves@redhat.com>
1442
1443         * breakpoint.c (read_uploaded_action)
1444         (create_tracepoint_from_upload): Adjust to use
1445         gdb::unique_xmalloc_ptr.
1446         * ctf.c (ctf_write_uploaded_tp):
1447         (SET_ARRAY_FIELD): Use emplace_back.
1448         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1449         * tracefile-tfile.c (tfile_write_uploaded_tp):
1450         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1451         gdb::unique_xmalloc_ptr.
1452         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1453         at_string, cond_string, cmd_strings>: Replace char pointers
1454         with gdb::unique_xmalloc_ptr.
1455
1456 2019-01-10  Pedro Alves  <palves@redhat.com>
1457
1458         * solib-target.c (library_list_start_library): Don't xstrdup name.
1459
1460 2019-01-10  Pedro Alves  <palves@redhat.com>
1461
1462         * mdebugread.c (parse_partial_symbols): Use
1463         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1464
1465 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1466
1467         * linux-fork.c (scoped_switch_fork_info)
1468         <~scoped_switch_fork_info>: Fix incorrect variable name.
1469
1470 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1471
1472         * linux-fork.c (scoped_switch_fork_info)
1473         <scoped_switch_fork_info>: Make explicit.
1474         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1475
1476 2019-01-10  Tom Tromey  <tom@tromey.com>
1477
1478         * objfiles.h (objfile::reset_psymtabs): Update.
1479         * objfiles.c (objfile::objfile): Update.
1480         * psymtab.h (psymtab_storage::obstack): Update.
1481         (psymtab_storage::m_obstack): Use gdb::optional.
1482         (class psymtab_storage): Update comment.  Remove objfile
1483         parameter.
1484         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1485
1486 2019-01-10  Tom Tromey  <tom@tromey.com>
1487
1488         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1489         <free_psymtabs>: Now private.
1490         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1491         (allocate_psymtab): Use new method.
1492
1493 2019-01-10  Tom Tromey  <tom@tromey.com>
1494
1495         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1496         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1497         * mdebugread.c (parse_partial_symbols): Use
1498         allocate_dependencies.
1499         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1500         allocate_dependencies.
1501         (process_psymtab_comp_unit_reader)
1502         (build_type_psymtab_dependencies): Likewise.
1503         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1504
1505 2019-01-10  Tom Tromey  <tom@tromey.com>
1506
1507         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1508         PSYMBOL_SET_LANGUAGE.
1509         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1510
1511 2019-01-10  Tom Tromey  <tom@tromey.com>
1512
1513         * psymtab.h (psymtab_storage::obstack): New method.
1514         <m_obstack>: Rename from obstack; now private.
1515         * psymtab.c (psymtab_storage): Update.
1516         * dwarf2read.c (create_addrmap_from_index)
1517         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1518         Update.
1519
1520 2019-01-10  Tom Tromey  <tom@tromey.com>
1521
1522         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1523         * objfiles.h (objfile::reset_psymtabs): New method.
1524
1525 2019-01-10  Tom Tromey  <tom@tromey.com>
1526
1527         * symmisc.c (print_symbol_bcache_statistics): Update.
1528         (print_objfile_statistics): Update.
1529         * symfile.c (reread_symbols): Update.
1530         * psymtab.h (class psymtab_storage): New.
1531         * psymtab.c (psymtab_storage): New constructor.
1532         (~psymtab_storage): New destructor.
1533         (require_partial_symbols): Update.
1534         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1535         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1536         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1537         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1538         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1539         (start_psymtab_common, end_psymtab_common)
1540         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1541         (allocate_psymtab): Update.
1542         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1543         Update.
1544         (dump_psymtab_addrmap, maintenance_print_psymbols)
1545         (maintenance_check_psymtabs): Update.
1546         (class objfile_psymtabs): Move to objfiles.h.
1547         * psympriv.h (discard_psymtab): Now inline.
1548         (psymtab_discarder::psymtab_discarder): Update.
1549         (psymtab_discarder::~psymtab_discarder): Update.
1550         (ALL_OBJFILE_PSYMTABS): Rewrite.
1551         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1552         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1553         Remove fields.
1554         <partial_symtabs>: New field.
1555         (class objfile_psymtabs): Move from psymtab.h.  Update.
1556         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1557         psymbol_cache.
1558         (objfile::~objfile): Don't destroy psymbol_cache.
1559         * mdebugread.c (parse_partial_symbols): Update.
1560         * dwarf2read.c (create_addrmap_from_index)
1561         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1562         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1563         (add_partial_subprogram, dwarf2_ranges_read): Update.
1564         * dwarf-index-write.c (write_address_map)
1565         (write_one_signatured_type, recursively_write_psymbols)
1566         (class debug_names, class debug_names, write_psymtabs_to_index):
1567         Update.
1568
1569 2019-01-10  Tom Tromey  <tom@tromey.com>
1570
1571         * symtab.h (SYMBOL_SET_NAMES): Update.
1572         (symbol_set_names): Update.
1573         (MSYMBOL_SET_NAMES): Update.
1574         * symtab.c (symbol_set_names): Change argument to be an
1575         objfile_per_bfd_storage.
1576         * psymtab.c (add_psymbol_to_bcache): Update.
1577         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1578
1579 2019-01-10  Tom Tromey  <tom@tromey.com>
1580
1581         * symtab.c (create_demangled_names_hash): Change argument to be an
1582         objfile_per_bfd_storage.
1583         (symbol_set_names): Update.
1584
1585 2019-01-10  Tom Tromey  <tom@tromey.com>
1586
1587         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1588         init_psymbol_list.
1589         * psymtab.c (init_psymbol_list): Do nothing if already called.
1590         * psympriv.h (init_psymbol_list): Add comment.
1591         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1592         init_psymbol_list.
1593         * dbxread.c (dbx_symfile_read): Unconditionally call
1594         init_psymbol_list.
1595
1596 2019-01-10  Tom Tromey  <tom@tromey.com>
1597
1598         * xcoffread.c (scan_xcoff_symtab): Update.
1599         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1600         "where".
1601         * mdebugread.c (parse_partial_symbols)
1602         (handle_psymbol_enumerators): Update.
1603         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1604         * dbxread.c (read_dbx_symtab): Update.
1605         * psympriv.h (psymbol_placement): New enum.
1606         (add_psymbol_to_list): Update.
1607
1608 2019-01-10  Tom Tromey  <tom@tromey.com>
1609
1610         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1611         static_psymbols parameters.
1612         (scan_xcoff_symtab): Update.
1613         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1614         static_psymbols parameters.
1615         * psympriv.h (start_psymtab_common): Update.
1616         * mdebugread.c (parse_partial_symbols): Update.
1617         * dwarf2read.c (create_partial_symtab): Update.
1618         * dbxread.c (read_dbx_symtab): Update.
1619         (start_psymtab): Remove global_psymbols and static_psymbols
1620         parameters.
1621
1622 2019-01-10  Tom Tromey  <tom@tromey.com>
1623
1624         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1625         * psymtab.c (allocate_psymtab): Add comment.
1626         * psympriv.h (allocate_psymtab): Add comment.
1627         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1628         initializations.
1629         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1630
1631 2019-01-10  Tom Tromey  <tom@tromey.com>
1632
1633         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1634         Don't declare.
1635         * mipsread.c: Include mdebugread.h.
1636         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1637         Declare.
1638         * elfread.c: Include mdebugread.h.
1639
1640 2019-01-09  Tom Tromey  <tom@tromey.com>
1641
1642         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1643         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1644         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1645         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1646         (psym_lookup_symbol, psym_find_last_source_symtab)
1647         (psym_forget_cached_source_info, psym_print_stats)
1648         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1649         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1650         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1651         (psym_find_compunit_symtab_by_address)
1652         (maintenance_print_psymbols, maintenance_info_psymtabs)
1653         (maintenance_check_psymtabs): Use ranged for.
1654         * psymtab.h (class objfile_psymtabs): New.
1655         (require_partial_symbols): Return objfile_psymtabs.
1656         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1657
1658 2019-01-09  Tom Tromey  <tom@tromey.com>
1659
1660         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1661         (find_pc_mapped_section, list_overlays_command)
1662         (map_overlay_command, unmap_overlay_command)
1663         (simple_overlay_update): Use all_objfiles.
1664         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1665         * printcmd.c (info_symbol_command): Use all_objfiles.
1666         * objfiles.h (ALL_OBJSECTIONS): Remove.
1667         * maint.c (maintenance_translate_address): Use all_objfiles.
1668         * gcore.c (gcore_create_callback): Use all_objfiles.
1669         (objfile_find_memory_regions): Likewise.
1670
1671 2019-01-09  Tom Tromey  <tom@tromey.com>
1672
1673         * symtab.c (find_line_symtab, info_sources_command)
1674         (make_source_files_completion_list): Use objfile_compunits.
1675         * source.c (select_source_symtab): Use objfile_compunits.
1676         * objfiles.h (struct objfile): Update comment.
1677         (ALL_OBJFILES): Remove.
1678         (ALL_FILETABS): Remove.
1679         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
1680         objfile_compunits.
1681
1682 2019-01-09  Tom Tromey  <tom@tromey.com>
1683
1684         * symmisc.c (print_objfile_statistics, dump_objfile)
1685         (maintenance_print_symbols): Use compunit_filetabs.
1686         * source.c (forget_cached_source_info_for_objfile): Use
1687         compunit_filetabs.
1688         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
1689         (ALL_FILETABS): Use compunit_filetabs.
1690         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
1691         * coffread.c (coff_symtab_read): Use compunit_filetabs.
1692
1693 2019-01-09  Tom Tromey  <tom@tromey.com>
1694
1695         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
1696         (compunit_filetabs): New.
1697         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
1698         compunit_filetabs.
1699         (info_sources_command, make_source_files_completion_list): Remove
1700         declaration.
1701         * symmisc.c (print_objfile_statistics, dump_objfile)
1702         (maintenance_print_symbols): Remove declaration.
1703         (maintenance_info_symtabs): Use compunit_filetabs.
1704         (maintenance_info_line_tables): Likewise.
1705         * source.c (select_source_symtab): Change local variable name.
1706         (forget_cached_source_info_for_objfile): Remove declaration.
1707         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
1708         * objfiles.c (objfile_relocate1): Remove declaration.
1709         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1710         declaration.
1711         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
1712         * coffread.c (coff_symtab_read): Remove declaration.
1713         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1714         compunit_filetabs.
1715
1716 2019-01-09  Tom Tromey  <tom@tromey.com>
1717
1718         * symtab.c (lookup_objfile_from_block)
1719         (find_pc_sect_compunit_symtab, search_symbols)
1720         (default_collect_symbol_completion_matches_break_on): Use
1721         objfile_compunits.
1722         * objfiles.h (ALL_COMPUNITS): Remove.
1723         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
1724         * cp-support.c (add_symbol_overload_list_qualified): Use
1725         objfile_compunits.
1726         * ada-lang.c (ada_collect_symbol_completion_matches)
1727         (ada_add_global_exceptions): Use objfile_compunits.
1728
1729 2019-01-09  Tom Tromey  <tom@tromey.com>
1730
1731         * source.c (select_source_symtab)
1732         (forget_cached_source_info_for_objfile): Remove declaration.
1733         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1734         declaration.
1735         * maint.c (count_symtabs_and_blocks): Remove declaration.
1736         * cp-support.c (add_symbol_overload_list_qualified): Remove
1737         declaration.
1738         * coffread.c (coff_symtab_read): Remove declaration.
1739         * symtab.c (lookup_symbol_in_objfile_symtabs)
1740         (basic_lookup_transparent_type_1): Use objfile_compunits.
1741         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
1742         (info_sources_command, search_symbols)
1743         (default_collect_symbol_completion_matches_break_on)
1744         (make_source_files_completion_list): Remove declaration.
1745         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
1746         (ada_collect_symbol_completion_matches)
1747         (ada_add_global_exceptions): Remove declaration.
1748         * linespec.c (iterate_over_all_matching_symtabs): Use
1749         objfile_compunits.
1750         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
1751         (class objfile_compunits): New.
1752         (ALL_COMPUNITS): Use objfile_compunits.
1753         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
1754         (maintenance_check_symtabs, maintenance_info_line_tables): Use
1755         objfile_compunits.
1756         * objfiles.c (objfile_relocate1): Use objfile_compunits.
1757
1758 2019-01-09  Tom Tromey  <tom@tromey.com>
1759
1760         * symtab.c (search_symbols)
1761         (default_collect_symbol_completion_matches_break_on): Use
1762         objfile_msymbols.
1763         * ada-lang.c (ada_lookup_simple_minsym)
1764         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
1765         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
1766         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
1767         objfile_msymbols.
1768         * coffread.c (coff_symfile_read): Use objfile_msymbols.
1769         * symmisc.c (dump_msymbols): Use objfile_msymbols.
1770         * objc-lang.c (find_methods): Use objfile_msymbols.
1771         (info_selectors_command, info_classes_command): Likewise.
1772         * stabsread.c (scan_file_globals): Use objfile_msymbols.
1773         * objfiles.h (class objfile_msymbols): New.
1774         (ALL_OBJFILE_MSYMBOLS): Remove.
1775         (ALL_MSYMBOLS): Remove.
1776
1777 2019-01-09  Tom Tromey  <tom@tromey.com>
1778
1779         * common/next-iterator.h (next_adapter): Add Iterator template
1780         parameter.
1781         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
1782         (class all_objfiles_safe): New.
1783         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
1784         * objfiles.c (put_objfile_before): Update comment.
1785         (add_separate_debug_objfile): Likewise.
1786         (free_all_objfiles): Use all_objfiles_safe.
1787         (objfile_purge_solibs): Likewise.
1788
1789 2019-01-09  Tom Tromey  <tom@tromey.com>
1790
1791         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1792         (expand_symtab_containing_pc, lookup_static_symbol)
1793         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
1794         (find_symbol_at_address, find_line_symtab, find_main_name): Use
1795         all_objfiles.
1796         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
1797         * breakpoint.c (create_overlay_event_breakpoint)
1798         (create_longjmp_master_breakpoint)
1799         (create_std_terminate_master_breakpoint)
1800         (create_exception_master_breakpoint): Use all_objfiles.
1801         * linux-thread-db.c (try_thread_db_load_from_pdir)
1802         (has_libpthread): Use all_objfiles.
1803         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
1804         * linespec.c (iterate_over_all_matching_symtabs)
1805         (search_minsyms_for_name): Use all_objfiles.
1806         * maint.c (maintenance_info_sections): Use all_objfiles.
1807         * main.c (captured_main_1): Use all_objfiles.
1808         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
1809         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
1810         * guile/scm-pretty-print.c
1811         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
1812         * solib-spu.c (append_ocl_sos): Use all_objfiles.
1813         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
1814         (maintenance_print_msymbols): Use all_objfiles.
1815         * source.c (select_source_symtab): Use all_objfiles.
1816         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
1817         * symfile.c (remove_symbol_file_command)
1818         (expand_symtabs_matching, map_symbol_filenames): Use
1819         all_objfiles.
1820         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
1821         all_objfiles.
1822         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
1823         * objc-lang.c (find_methods): Use all_objfiles.
1824         * objfiles.c (have_partial_symbols, have_full_symbols)
1825         (have_minimal_symbols, qsort_cmp)
1826         (default_iterate_over_objfiles_in_search_order): Use
1827         all_objfiles.
1828         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
1829         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
1830         (maintenance_check_psymtabs): Use all_objfiles.
1831         (ALL_PSYMTABS): Remove.
1832         * compile/compile-object-run.c (do_module_cleanup): Use
1833         all_objfiles.
1834         * blockframe.c (find_pc_partial_function): Use all_objfiles.
1835         * cp-support.c (add_symbol_overload_list_qualified): Use
1836         all_objfiles.
1837         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1838         Use all_objfiles.
1839         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
1840         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
1841         all_objfiles.
1842         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1843         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
1844         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1845         Uses all_objfiles.
1846         * solib.c (solib_read_symbols): Use all_objfiles
1847
1848 2019-01-09  Tom Tromey  <tom@tromey.com>
1849
1850         * probe.c (parse_probes_in_pspace): Use all_objfiles.
1851         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
1852         all_objfiles.
1853         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
1854         * symmisc.c (print_symbol_bcache_statistics)
1855         (print_objfile_statistics, maintenance_print_objfiles)
1856         (maintenance_info_symtabs, maintenance_check_symtabs)
1857         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
1858         all_objfiles.
1859         * source.c (forget_cached_source_info): Use all_objfiles.
1860         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
1861         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1862         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
1863         * objfiles.c (update_section_map): Use all_objfiles.
1864         (shared_objfile_contains_address_p): Likewise.
1865         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
1866         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
1867
1868 2019-01-09  Tom Tromey  <tom@tromey.com>
1869
1870         * common/next-iterator.h: New file.
1871         * objfiles.h (class all_objfiles): New.
1872         (struct objfile_iterator): New.
1873
1874 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1875
1876         * NEWS: Move the description of the changed "frame", "select-frame",
1877          and "info frame" commands to the Changed commands section.
1878
1879 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
1880
1881         * gdbtypes.c (check_stub_method_group): Remove handling of old
1882         mangling schemes.
1883         * linespec.c (find_methods): Likewise.
1884         * stabsread.c (read_member_functions): Likewise.
1885         * valops.c (search_struct_method): Likewise.
1886         (value_struct_elt_for_reference): Likewise.
1887         * NEWS: Mention this change.
1888
1889 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1890
1891         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
1892         print_source_lines.
1893         * source.c (print_source_lines_base): Update line number check.
1894         (print_source_lines): New function.
1895         (source_lines_range::source_lines_range): New function.
1896         * source.h (class source_lines_range): New class.
1897         (print_source_lines): New declaration.
1898
1899 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1900
1901         * linespec.c (linespec_state_destructor): Free self->canonical_names.
1902
1903 2019-01-08  Tom Tromey  <tom@tromey.com>
1904             Simon Marchi  <simon.marchi@ericsson.com>
1905
1906         PR gdb/24060
1907         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
1908         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
1909         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1910         * f-exp.y (DOLLAR_VARIABLE): Likewise.
1911         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
1912         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1913
1914 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1915
1916         * source.c (select_source_symtab): Move header comment to
1917         declaration in source.h.
1918         (forget_cached_source_info_for_objfile): Likewise.
1919         (forget_cached_source_info): Likewise.
1920         (identify_source_line): Likewise.
1921         * source.h (identify_source_line): Move declaration from symtab.h
1922         and add comment from source.c
1923         (print_source_lines): Likewise.
1924         (forget_cached_source_info_for_objfile): Likewise.
1925         (forget_cached_source_info): Likewise.
1926         (select_source_symtab): Likewise.
1927         (enum print_source_lines_flag): Move definition from symtab.h.
1928         * symtab.h (identify_source_line): Move declaration to source.h.
1929         (print_source_lines): Likewise.
1930         (forget_cached_source_info_for_objfile): Likewise.
1931         (forget_cached_source_info): Likewise.
1932         (select_source_symtab): Likewise.
1933         (enum print_source_lines_flag): Move definition to source.h.
1934         * tui/tui-hooks.c: Add 'source.h' include.
1935
1936 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1937
1938         * source.c (print_source_lines_base): Handle requests to print
1939         reverse line number sequences, and guard against empty lines
1940         string.
1941
1942 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1943
1944         * source.c (print_source_lines_base): Fix skip of '\r' if next
1945         character is '\n'.
1946
1947 2019-01-06  Tom Tromey  <tom@tromey.com>
1948
1949         * c-exp.y (struct c_parse_state) <macro_original_text,
1950         expansion_obstack>: New member.
1951         (macro_original_text, expansion_obstack): Remove globals.
1952         (scan_macro_expansion, scanning_macro_expansion)
1953         (finished_macro_expansion): Update.
1954         (scan_macro_cleanup): Remove.
1955         (yylex, c_parse): Update.
1956
1957 2019-01-06  Tom Tromey  <tom@tromey.com>
1958
1959         * c-exp.y (struct c_parse_state) <strings>: New member.
1960         (operator_stoken): Update.
1961
1962 2019-01-06  Tom Tromey  <tom@tromey.com>
1963
1964         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
1965         (union type_stack_elt) <typelist_val>: Now a pointer to
1966         std::vector.
1967         (type_stack_cleanup): Don't declare.
1968         (push_typelist): Update.
1969         * parse.c (pop_typelist): Return a std::vector.
1970         (push_typelist): Take a std::vector.
1971         (follow_types): Update.  Do not free args.
1972         (type_stack_cleanup): Remove.
1973         * c-exp.y (struct c_parse_state): New.
1974         (cpstate): New global.
1975         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
1976         (nonempty_typelist): Update.
1977         (func_mod): Create a new vector.
1978         (c_parse): Create a c_parse_state.
1979         (check_parameter_typelist): Do not delete params.
1980         (function_method): Update.  Do not delete type_list.
1981
1982 2019-01-06  Tom Tromey  <tom@tromey.com>
1983
1984         PR gdb/28155:
1985         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
1986         check_typedef.
1987         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
1988         (print_return_value): Likewise.
1989
1990 2019-01-05  Tom Tromey  <tom@tromey.com>
1991
1992         * contrib/cleanup_check.py: Remove.
1993         * contrib/gcc-with-excheck: Remove.
1994         * contrib/exsummary.py: Remove.
1995         * contrib/excheck.py: Remove.
1996
1997 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
1998
1999         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2000         NULL. Initialize tpprev to NULL instead of assigning it
2001         to NULL on the next statement.
2002         * windows-nat.c (windows_delete_thread): Remove check for
2003         main_thread_id before printing thread exit notifications.
2004         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2005         Remove thread ID check against main_thread_id.
2006         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2007         windows_delete_thread.
2008         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2009
2010 2019-01-04  Tom Tromey  <tom@tromey.com>
2011
2012         * compile/compile.c (_initialize_compile): Use upper case for
2013         metasyntactic variables.
2014         * symmisc.c (_initialize_symmisc): Use upper case for
2015         metasyntactic variables.
2016         * psymtab.c (_initialize_psymtab): Use upper case for
2017         metasyntactic variables.
2018         * demangle.c (demangle_command): Use upper case for metasyntactic
2019         variables.
2020         (_initialize_demangler): Likewise.
2021         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2022         variables.
2023
2024 2019-01-03  Tom Tromey  <tom@tromey.com>
2025
2026         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2027
2028 2019-01-03  Tom Tromey  <tom@tromey.com>
2029
2030         * python/py-symtab.c (salpy_str): Update.
2031         (struct salpy_sal_object) <symtab>: Now a PyObject.
2032         (salpy_dealloc): Update.
2033         (del_objfile_sal): Use gdbpy_ref.
2034
2035 2019-01-03  Tom Tromey  <tom@tromey.com>
2036
2037         * python/py-type.c (convert_field): Use new_reference.  Return
2038         gdbpy_ref.
2039         (make_fielditem): Return gdbpy_ref.
2040         (typy_fields): Update.
2041         (typy_getitem): Update.
2042         (field_name): Return gdbpy_ref.  Use new_reference.
2043         (typy_iterator_iternext): Update.
2044
2045 2019-01-03  Tom Tromey  <tom@tromey.com>
2046
2047         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2048
2049 2019-01-03  Tom Tromey  <tom@tromey.com>
2050
2051         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2052         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2053         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2054         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2055         (pspy_set_type_printers): Likewise.
2056         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2057         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2058         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2059         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2060         (objfpy_set_type_printers): Likewise.
2061
2062 2019-01-03  Tom Tromey  <tom@tromey.com>
2063
2064         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2065         (gdbpy_print_stack): Use gdbpy_err_fetch.
2066         * python/python-internal.h (class gdbpy_err_fetch): New class.
2067         (class gdbpy_enter) <m_error_type, m_error_value,
2068         m_error_traceback>: Remove.
2069         <m_error>: New member.
2070         (gdbpy_exception_to_string): Don't declare.
2071         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2072         * python/py-value.c (convert_value_from_python): Use
2073         gdbpy_err_fetch.
2074         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2075         gdbpy_exception_to_string.
2076         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2077         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2078         gdbpy_err_fetch.
2079
2080 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2081
2082         * linux-nat.c (delete_lwp_cleanup): Delete.
2083         (struct lwp_deleter): New struct.
2084         (lwp_info_up): New typedef.
2085         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2086         lwp_info_up.
2087
2088 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2089
2090         * linux-fork.c (class scoped_switch_fork_info): New class.
2091         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2092
2093 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2094
2095         * valops.c (find_overload_match): Remove use of null_cleanup, and
2096         calls to do_cleanups.
2097
2098 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2099
2100         * compile/compile-cplus-types.c
2101         (compile_cplus_instance::decl_name): Handle changes to
2102         cp_func_name.
2103         * cp-support.c (cp_func_name): Update header comment, update
2104         return type.
2105         * cp-support.h (cp_func_name): Update return type in declaration.
2106         * valops.c (find_overload_match): Move temp_func local to top
2107         level of function and change its type.  Use temp_func to hold and
2108         delete temporary string obtained from cp_func_name.
2109
2110 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2111
2112         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2113         gdb::char_vector, remove cleanup, and update uses of `msg`.
2114
2115 2019-01-03  Jim Wilson  <jimw@sifive.com>
2116
2117         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2118
2119 2019-01-02  Tom Tromey  <tom@tromey.com>
2120
2121         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2122         (tdesc_parse_xml): Remove cleanups.
2123         * target-descriptions.h (make_cleanup_free_target_description):
2124         Don't declare.
2125         (target_desc_deleter): New struct.
2126         (target_desc_up): New typedef.
2127         * target-descriptions.c (target_desc_deleter::operator()): Rename
2128         from free_target_description.
2129         (make_cleanup_free_target_description): Remove.
2130
2131 2019-01-02  Tom Tromey  <tom@tromey.com>
2132
2133         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2134         constructor, destructor.
2135         (linespec_parser): Remove typedef.
2136         (~linespec_parser): Rename from linespec_parser_delete.
2137         (linespec_lex_to_end, linespec_complete_label)
2138         (linespec_complete): Update.
2139         (decode_line_full): Remove cleanups.
2140         (decode_line_1): Update.
2141
2142 2019-01-02  Tom Tromey  <tom@tromey.com>
2143
2144         * python/python-internal.h (inferior_to_inferior_object): Change
2145         return type.
2146         * python/py-exitedevent.c (create_exited_event_object): Update.
2147         * python/py-inferior.c (inferior_to_inferior_object): Return
2148         gdbpy_ref.
2149         (python_new_inferior, python_inferior_deleted)
2150         (thread_to_thread_object, delete_thread_object)
2151         (build_inferior_list, gdbpy_selected_inferior): Update.
2152         * python/py-infthread.c (create_thread_object): Update.  Also fail
2153         if inferior_to_inferior_object fails.
2154
2155 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2156
2157         * inferior.h (class inferior) <displaced_step_state>: New field.
2158         * infrun.h (struct displaced_step_state): Move here from
2159         infrun.c.  Initialize fields, add constructor.
2160         <inf>: Remove field.
2161         <reset>: New method.
2162         * infrun.c (struct displaced_step_inferior_state): Move to
2163         infrun.h.
2164         (displaced_step_inferior_states): Remove.
2165         (get_displaced_stepping_state): Adust.
2166         (displaced_step_in_progress_any_inferior): Adjust.
2167         (displaced_step_in_progress_thread): Adjust.
2168         (displaced_step_in_progress): Adjust.
2169         (add_displaced_stepping_state): Remove.
2170         (get_displaced_step_closure_by_addr): Adjust.
2171         (remove_displaced_stepping_state): Remove.
2172         (infrun_inferior_exit): Call displaced_step_state.reset.
2173         (use_displaced_stepping): Don't check for NULL.
2174         (displaced_step_prepare_throw): Call
2175         get_displaced_stepping_state.
2176         (displaced_step_fixup): Don't check for NULL.
2177         (prepare_for_detach): Don't check for NULL.
2178
2179 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2180
2181         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2182          in case of call that did not complete.
2183
2184 2019-01-02  Andrey Utkin  <autkin@undo.io>
2185
2186         * symfile.c (find_separate_debug_file): Fix search of debug files for
2187         remote debuggee.
2188
2189 2019-01-02  Tom Tromey  <tom@tromey.com>
2190
2191         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2192         indentation.
2193         * python/py-frame.c (frapy_older): Remove cast.
2194         (frapy_newer): Likewise.
2195         * python/py-breakpoint.c (local_setattro): Remove cast.
2196         * python/py-arch.c (archpy_name): Remove local variable.
2197         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2198
2199 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2200
2201         * unittests/basic_string_view/element_access/char/empty.cc:
2202         Fix year range in copyright header.
2203
2204 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2205
2206         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2207         Delete.
2208         <operator==>: Update with for removed field.
2209         <hash>: Likewise.
2210         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2211         <isa_features>: ...this.
2212         <abi_features>: New field.
2213         (riscv_isa_flen): Update comment.
2214         (riscv_abi_xlen): New declaration.
2215         (riscv_abi_flen): New declaration.
2216         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2217         isa_features.
2218         (riscv_abi_xlen): New function.
2219         (riscv_isa_flen): Update to get answer from isa_features.
2220         (riscv_abi_flen): New function.
2221         (riscv_has_fp_abi): Update to get answer from abi_features.
2222         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2223         xlen and flen.
2224         (riscv_call_info) <xlen, flen>: Update comment.
2225         (riscv_call_arg_struct): Remove invalid assertions
2226         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2227         is removed.
2228         (riscv_gdbarch_init): Gather isa features and abi features
2229         separately, ensure both match on the gdbarch when reusing an old
2230         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2231         a target with 64-bit float hardware.
2232
2233 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2234
2235         * source.c (search_command_helper): Stop reverse search
2236         when line 1 has been searched.
2237
2238 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2239
2240         * record-full.c (record_full_base_target::close): Rewrite
2241         record_full_core_buf_list free logic.
2242
2243 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2244
2245         * break-catch-syscall.c (print_one_catch_syscall): xfree
2246         the last text.
2247
2248 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2249
2250         * top.c (print_gdb_version): Update Copyright year in version
2251         message.
2252
2253 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2254
2255         Update copyright year range in all GDB files.
2256
2257 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2258
2259         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2260
2261 For older changes see ChangeLog-2018.
2262 \f
2263 Local Variables:
2264 mode: change-log
2265 left-margin: 8
2266 fill-column: 74
2267 version-control: never
2268 coding: utf-8
2269 End:
2270