gdb/ChangeLog

   1 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
   2
   3         * features/aarch64-pauth.c: Regenerate.
   4
   5 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
   6
   7         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
   8         bool.
   9         (bpstat_what): Use false instead of 0.
  10
  11 2019-07-09  Pedro Alves  <palves@redhat.com>
  12
  13         * break-catch-throw.c (is_exception_catchpoint): New.
  14         * breakpoint.c (print_one_breakpoint_location): New parameter
  15         'raw_loc'.  Handle it.  Use
  16         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
  17         looking at the breakpoint's type.
  18         (print_one_breakpoint): If handling "maint info breakpoints", also
  19         print locations of exception catchpoints.
  20         * breakpoint.h (is_exception_catchpoint): Declare.
  21
  22 2019-07-09  Pedro Alves  <palves@redhat.com>
  23
  24         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
  25         "addr" field.
  26         (allocate_location_exception_catchpoint): New.
  27         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
  28         (initialize_throw_catchpoint_ops): Install
  29         allocate_location_exception_catchpoint as allocate_location
  30         method.
  31         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
  32         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
  33         bp_loc_other.
  34         (breakpoint_address_is_meaningful): Delete.
  35         (bl_address_is_meaningful): New.
  36         (breakpoint_locations_match): Adjust comment.
  37         (bp_location_from_bp_type): New, factored out of...
  38         (bp_location::bp_location(breakpoint *)): ... this.
  39         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
  40         factored out of...
  41         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
  42         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
  43         breakpoint_address_is_meaningful.
  44         (bp_locations_compare): Adjust comment.
  45         (update_global_location_list): Use bl_address_is_meaningful
  46         instead of breakpoint_address_is_meaningful.
  47         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
  48         explicit.
  49         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
  50         * python/py-breakpoint.c (bppy_get_location): No longer check
  51         whether location is null.
  52
  53 2019-07-09  Pedro Alves  <palves@redhat.com>
  54
  55         PR c++/15468
  56         * breakpoint.c (print_one_breakpoint_location): Remove
  57         single-location assert.
  58
  59 2019-07-09  Tom Tromey  <tom@tromey.com>
  60
  61         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
  62         * configure: Rebuild.
  63         * configure.ac: Change common to gdbsupport.
  64         * gdbsupport: Rename from common.
  65         * acinclude.m4: Change common to gdbsupport.
  66         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
  67         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
  68         gdbsupport.
  69         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
  70         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
  71         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
  72         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
  73         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
  74         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
  75         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
  76         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
  77         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
  78         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
  79         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
  80         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
  81         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
  82         coff-pe-read.c, command.h, compile/compile-c-support.c,
  83         compile/compile-c.h, compile/compile-cplus-symbols.c,
  84         compile/compile-cplus-types.c, compile/compile-cplus.h,
  85         compile/compile-loc2c.c, compile/compile.c, completer.c,
  86         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
  87         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
  88         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
  89         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
  90         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
  91         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
  92         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
  93         features/aarch64-core.c, features/aarch64-fpu.c,
  94         features/aarch64-pauth.c, features/aarch64-sve.c,
  95         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
  96         features/i386/32bit-core.c, features/i386/32bit-linux.c,
  97         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
  98         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
  99         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 100         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 101         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 102         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 103         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 104         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 105         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 106         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 107         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 108         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 109         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 110         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 111         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 112         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 113         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 114         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 115         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 116         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 117         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 118         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 119         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 120         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 121         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 122         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 123         minsyms.c, mips-linux-tdep.c, namespace.h,
 124         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 125         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 126         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 127         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 128         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 129         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 130         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 131         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 132         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 133         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 134         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 135         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 136         procfs.c, producer.c, progspace.h, psymtab.h,
 137         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 138         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 139         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 140         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 141         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
 142         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
 143         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
 144         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
 145         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
 146         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
 147         target-memory.c, target.c, target.h, target/waitstatus.c,
 148         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
 149         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
 150         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
 151         unittests/array-view-selftests.c,
 152         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
 153         unittests/common-utils-selftests.c,
 154         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
 155         unittests/format_pieces-selftests.c,
 156         unittests/function-view-selftests.c,
 157         unittests/lookup_name_info-selftests.c,
 158         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
 159         unittests/mkdir-recursive-selftests.c,
 160         unittests/observable-selftests.c,
 161         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
 162         unittests/parse-connection-spec-selftests.c,
 163         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
 164         unittests/scoped_fd-selftests.c,
 165         unittests/scoped_mmap-selftests.c,
 166         unittests/scoped_restore-selftests.c,
 167         unittests/string_view-selftests.c, unittests/style-selftests.c,
 168         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
 169         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
 170         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
 171         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
 172         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
 173         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
 174
 175 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 176
 177         * linespec.c (decode_digits_list_mode): Set explicit_line to a
 178         bool value.
 179         (decode_digits_ordinary): Set explicit_line field in sal.
 180         * symtab.c (skip_prologue_sal): Don't skip prologue for a
 181         symtab_and_line that was set on an explicit line number in
 182         assembler code.  Do always update the recorded symtab and line if
 183         we do skip the prologue.
 184
 185 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 186
 187         * breakpoint.c (set_breakpoint_location_function): Remove
 188         explicit_loc parameter.
 189         (momentary_breakpoint_from_master): Update call to
 190         set_breakpoint_location_function.
 191         (add_location_to_breakpoint): Likewise.
 192
 193 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 194
 195         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
 196         required features based on default bfd type when no specific bfd
 197         is present.
 198
 199 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 200
 201         * NEWS: Mention that GDB printf and eval commands can now print
 202         C-style and Ada-style convenience var strings without
 203         calling the inferior.
 204         * printcmd.c (printf_c_string): Locally print GDB internal var
 205         instead of transiting via the inferior.
 206         (printf_wide_c_string): Likewise.
 207
 208 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 209
 210         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
 211
 212 2019-07-04  Tom Tromey  <tom@tromey.com>
 213
 214         PR tui/24724:
 215         * tui/tui-winsource.c (tui_clear_source_content): Update.
 216         (tui_source_window_base::set_is_exec_point_at): Fix comment.
 217         (tui_update_breakpoint_info): Update.
 218         (tui_set_exec_info_content): Update.
 219         * tui/tui-source.c (tui_set_source_content_nil): Update.
 220         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
 221         has_break.
 222         * tui/tui-data.h (enum tui_bp_flag): New.
 223         (tui_bp_flags): New enum flags type.
 224         (struct tui_source_element) <break_mode>: Change type.  Rename
 225         from has_break.
 226         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
 227         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
 228         constants.
 229         * tui/tui-winsource.h: Fix comment.
 230
 231 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 232
 233         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
 234         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
 235         (store_fpregs_to_thread)
 236         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 237         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
 238         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
 239         (IWMMXT_REGS_SIZE): Add define.
 240         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
 241         (fetch_vfp_regs, store_vfp_regs)
 242         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 243         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
 244
 245 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 246
 247         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
 248         defines.
 249         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
 250         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
 251         (ARM_INT_REGISTER_SIZE): ...to this.
 252         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
 253         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
 254         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
 255         (arm_linux_collect_gregset, supply_nwfpe_register)
 256         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
 257         defines.
 258         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
 259         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
 260         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
 261         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
 262         (arm_return_in_memory, arm_store_return_value)
 263         (arm_get_longjmp_target, arm_register_g_packet_guesses)
 264         (arm_record_ld_st_multiple): Likewise.
 265         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
 266         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
 267
 268 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 269
 270         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
 271         AARCH64_DISPLACED_MODIFIED_INSNS.
 272         * aarch64-tdep.c (struct aarch64_displaced_step_data)
 273         (aarch64_displaced_step_copy_insn): Likewise.
 274         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 275         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
 276         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
 277         ARM_DISPLACED_MODIFIED_INSNS.
 278         * arm-tdep.c (arm_gdbarch_init): Likewise.
 279         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 280         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
 281         (struct arm_displaced_step_closure): Use
 282         ARM_DISPLACED_MODIFIED_INSNS.
 283
 284 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 285
 286         * features/Makefile: Remove unused xml files.
 287         * features/aarch64.xml: Remove.
 288         * features/i386/amd64-avx-avx512-linux.xml: Remove.
 289         * features/i386/amd64-avx-avx512.xml: Remove.
 290         * features/i386/amd64-avx-linux.xml: Remove.
 291         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
 292         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
 293         * features/i386/amd64-avx-mpx-linux.xml: Remove.
 294         * features/i386/amd64-avx-mpx.xml: Remove.
 295         * features/i386/amd64-avx.xml: Remove.
 296         * features/i386/amd64-linux.xml: Remove.
 297         * features/i386/amd64-mpx-linux.xml: Remove.
 298         * features/i386/amd64-mpx.xml: Remove.
 299         * features/i386/amd64.xml: Remove.
 300         * features/i386/i386-avx-avx512-linux.xml: Remove.
 301         * features/i386/i386-avx-avx512.xml: Remove.
 302         * features/i386/i386-avx-linux.xml: Remove.
 303         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
 304         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
 305         * features/i386/i386-avx-mpx-linux.xml: Remove.
 306         * features/i386/i386-avx-mpx.xml: Remove.
 307         * features/i386/i386-avx.xml: Remove.
 308         * features/i386/i386-linux.xml: Remove.
 309         * features/i386/i386-mmx-linux.xml: Remove.
 310         * features/i386/i386-mmx.xml: Remove.
 311         * features/i386/i386-mpx-linux.xml: Remove.
 312         * features/i386/i386-mpx.xml: Remove.
 313         * features/i386/i386.xml: Remove.
 314         * features/i386/x32-avx-avx512-linux.xml: Remove.
 315         * features/i386/x32-avx-linux.xml: Remove.
 316         * features/i386/x32-linux.xml: Remove.
 317
 318 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 319
 320         * regformats/aarch64.dat: Remove.
 321         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
 322         * regformats/i386/amd64-avx-linux.dat: Remove.
 323         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
 324         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
 325         * regformats/i386/amd64-linux.dat: Remove.
 326         * regformats/i386/amd64-mpx-linux.dat: Remove.
 327         * regformats/i386/amd64.dat: Remove.
 328         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
 329         * regformats/i386/i386-avx-linux.dat: Remove.
 330         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
 331         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
 332         * regformats/i386/i386-linux.dat: Remove.
 333         * regformats/i386/i386-mmx-linux.dat: Remove.
 334         * regformats/i386/i386-mpx-linux.dat: Remove.
 335         * regformats/i386/i386.dat: Remove.
 336         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
 337         * regformats/i386/x32-avx-linux.dat: Remove.
 338         * regformats/i386/x32-linux.dat: Remove.
 339
 340 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 341
 342         * aarch64-tdep.c: Remove xml self tests.
 343         * amd64-linux-tdep.c: Likewise.
 344         * amd64-tdep.c: Likewise.
 345         * i386-linux-tdep.c: Likewise.
 346         * i386-tdep.c: Likewise.
 347
 348 2019-07-03  Pedro Alves  <palves@redhat.com>
 349
 350         PR cli/24732
 351         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
 352         (pipe_cmd_option_defs): New.
 353         (make_pipe_cmd_options_def_group): New.
 354         (pipe_command): Use gdb::option::process_options.
 355         (pipe_command_completer): New function.
 356         (_initialize_cli_cmds): Install completer for "pipe" command.
 357
 358 2019-07-03  Pedro Alves  <palves@redhat.com>
 359
 360         * cli/cli-option.c (union option_value) <string>: New field.
 361         (struct option_def_and_value): Add ctor, move ctor, dtor and
 362         use DISABLE_COPY_AND_ASSIGN.
 363         (option_def_and_value::clear_value): New.
 364         (parse_option, save_option_value_in_ctx, get_val_type_str)
 365         (add_setshow_cmds_for_options): Handle var_string.
 366         * cli-option.h (union option_def::var_address) <string>: New
 367         field.
 368         (struct string_option_def): New.
 369         * maint-test-options.c (struct test_options_opts): Add default
 370         ctor and use DISABLE_COPY_AND_ASSIGN.
 371         <string_opt>: New field.
 372         (test_options_opts::~test_options_opts): New.
 373         (test_options_opts::dump): Also dump "-string".
 374         (test_options_option_defs): Install "string.
 375
 376 2019-07-03  Pedro Alves  <palves@redhat.com>
 377
 378         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
 379         option_value with a null enumeration.
 380         (complete_options): Save the option values in the context.
 381         (save_option_value_in_ctx): New, factored out from ...
 382         (process_options): ... here.
 383         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
 384         of the function.
 385         * maint-test-options.c (test_options_opts::dump): New, factored
 386         out from ...
 387         (maintenance_test_options_command_mode): ... here.
 388         (maintenance_test_options_command_completion_result): Delete.
 389         (maintenance_test_options_command_completion_text): Update
 390         comment.
 391         (maintenance_show_test_options_completion_result): Change
 392         prototype.  Just print
 393         maintenance_test_options_command_completion_text.
 394         (save_completion_result): New.
 395         (maintenance_test_options_completer_mode): Pass options context to
 396         complete_options, and then save a dump.
 397         (_initialize_maint_test_options): Use add_cmd to install "maint
 398         show test-options-completion-result".
 399
 400 2019-07-03  Pedro Alves  <palves@redhat.com>
 401
 402         * NEWS (New commands): Mention "with" and "maint with".
 403         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
 404         (with_command, with_command_completer): New.
 405         (pipe_command): Adjust to new repeat_previous
 406         interface.
 407         (_initialize_cli_cmds): Install the "with" command and its "w"
 408         alias.
 409         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
 410         declarations.
 411         * cli/cli-setshow.c (parse_cli_var_uinteger)
 412         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
 413         argument strings for all var_types.
 414         (get_setshow_command_value_string): New, factored out from ...
 415         (do_show_command): ... this.
 416         * cli/cli-setshow.h: Include <string>.
 417         (get_setshow_command_value_string): Declare.
 418         * command.h (repeat_previous): Now returns const char *.  Adjust
 419         comment.
 420         * maint.c: Include "cli/cli-cmds.h".
 421         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
 422         (_initialize_maint_cmds): Register the "maintenance with" command.
 423         * top.c (repeat_previous): Move bits from pipe_command here:
 424         Return the saved command line, if any; error out if there's no
 425         command to relaunch.
 426
 427 2019-07-03  Pedro Alves  <palves@redhat.com>
 428
 429         * NEWS (New commands): Mention "maint set/show test-settings"
 430         instead of "maint test-settings".
 431         * maint-test-settings.c (maintenance_test_settings_list): Delete.
 432         (maintenance_test_settings_set_list): Rename to ...
 433         (maintenance_set_test_settings_list): ... this.
 434         (maintenance_test_settings_show_list): Rename to  ...
 435         (maintenance_show_test_settings_list): ... this.
 436         (maintenance_test_settings_cmd): Delete.
 437         (maintenance_test_settings_set_cmd): ...
 438         (maintenance_set_test_settings_cmd): ... this.
 439         (maintenance_test_settings_show_cmd): ...
 440         (maintenance_show_test_settings_cmd): ... this.
 441         (maintenance_test_settings_show_value_cmd):
 442         (maintenance_show_test_settings_value_cmd): ... this.
 443         (_initialize_maint_test_settings): No longer install the "maint
 444         test-settings" prefix command.  Rename "maint test-settings set"
 445         to "maint set test-settings", and "maint test-settings show" to
 446         "maint show test-settings".  Adjust all subcommands.
 447
 448 2019-07-03  Pedro Alves  <palves@redhat.com>
 449
 450         * maint-test-settings.c: Fix file's intro comment.  Replace all
 451         references to "test-options" with references to "test-settings",
 452         in comments.
 453
 454 2019-07-03  Pedro Alves  <palves@redhat.com>
 455
 456         * maint-test-settings.c (maintenance_test_settings_xxx)
 457         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
 458         New.
 459         (maintenance_test_settings_enums): Use them.
 460         (maintenance_test_settings_enum): Default to
 461         maintenance_test_settings_xxx.
 462         (_initialize_maint_test_settings): Initialize
 463         MAINTENANCE_TEST_SETTINGS_FILENAME.
 464
 465 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 466
 467         * breakpoint.h (remove_breakpoints_inf): Change return type to
 468         void, move function documentation here.
 469         * breakpoint.c (remove_breakpoints_inf): Change return type to
 470         void, move function documentation to header.
 471
 472 2019-07-02  Pedro Alves  <palves@redhat.com>
 473
 474         * NEWS (Completion improvements): Mention "info threads".
 475         * thread.c (struct info_threads_opts, info_threads_option_defs)
 476         (make_info_threads_options_def_group): New.
 477         (info_threads_command): Use gdb::option::process_options.
 478         (info_threads_command_completer): New.
 479         (_initialize_thread): Use gdb::option::build_help to build the
 480         help text for "info threads".
 481
 482 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 483
 484         * defs.h (generic_load): Move from here...
 485         * symfile.h (generic_load): ... to here.  Rename name parameter
 486         to args.
 487         * symfile.c (generic_load): Add comment.
 488
 489 2019-07-01  Tom Tromey  <tromey@adacore.com>
 490
 491         * dwarf2read.c
 492         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
 493         declaration of without_params.  Fix formatting.
 494
 495 2019-07-01  Tom Tromey  <tromey@adacore.com>
 496
 497         * ada-exp.y (find_primitive_type): Update.
 498         * ada-lang.h (ada_lookup_symbol): Update.
 499         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
 500         parameter.
 501         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
 502
 503 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 504
 505         PR breakpoints/24541
 506         * gdbarch.c: Regenerate.
 507         * gdbarch.h: Regenerate.
 508         * gdbarch.sh: Add 'stap_adjust_register'.
 509         * i386-tdep.c: Include '<unordered_set>'.
 510         (i386_stap_adjust_register): New function.
 511         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
 512         * stap-probe.c (stap_parse_register_operand): Call
 513         'gdbarch_stap_adjust_register'.
 514
 515 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 516
 517         PR python/24742
 518         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
 519         * python/python.c (do_start_initialization): Use 'xmalloc'
 520         instead of 'PyMem_Malloc'.
 521
 522 2019-06-28  Tom Tromey  <tromey@adacore.com>
 523
 524         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
 525         for Ada.
 526
 527 2019-06-27  Tom Tromey  <tromey@adacore.com>
 528
 529         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
 530         objfile_key.
 531         (arm_find_mapping_symbol, arm_record_special_symbol)
 532         (_initialize_arm_tdep): Update.
 533         (arm_objfile_data_free): Remove.
 534
 535 2019-06-27  Tom Tromey  <tromey@adacore.com>
 536
 537         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
 538         to cp_print_static_field.
 539
 540 2019-06-26  Tom Tromey  <tromey@adacore.com>
 541
 542         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
 543         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
 544         declare.
 545
 546 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 547
 548         * features/aarch64-core.c (create_feature_aarch64_core):
 549         Regenerate.
 550         * features/aarch64-core.xml: Add cpsr flags.
 551
 552 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 553
 554         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
 555         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
 556
 557 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 558
 559         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
 560         field.
 561         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
 562         use.
 563         (arm_record_special_symbol): Don't insert new symbol in sorted
 564         position, push it at the end.
 565
 566 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 567
 568         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
 569         (arm_mapping_symbol_s): Remove.
 570         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
 571         (arm_mapping_symbol_vec): New typedef.
 572         (struct arm_per_objfile): Add constructor.
 573         <section_maps>: Change type to
 574         std::unique_ptr<arm_mapping_symbol_vec[]>.
 575         (arm_compare_mapping_symbols): Remove.
 576         (arm_find_mapping_symbol): Adjust to section_maps type change.
 577         (arm_objfile_data_free): Call delete on arm_per_objfile.
 578         (arm_record_special_symbol): Adjust to section_maps type change.
 579         Allocate arm_per_objfile with new.
 580
 581 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 582
 583         * cli/cli-cmds.c (alias_command): Compare the alias prefix
 584         with the command prefix.
 585
 586 2019-06-25  Tom Tromey  <tom@tromey.com>
 587
 588         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
 589         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
 590
 591 2019-06-25  Tom Tromey  <tom@tromey.com>
 592
 593         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
 594         type.
 595         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
 596         protected.
 597
 598 2019-06-25  Tom Tromey  <tom@tromey.com>
 599
 600         * tui/tui-winsource.c
 601         (tui_source_window_base::set_is_exec_point_at): Add check against
 602         LOA_ADDRESS.
 603
 604 2019-06-25  Tom Tromey  <tom@tromey.com>
 605
 606         * tui/tui-source.c (tui_set_source_content): Don't check before
 607         xfree.
 608         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
 609
 610 2019-06-25  Tom Tromey  <tom@tromey.com>
 611
 612         * tui/tui-winsource.h (tui_update_source_window_as_is)
 613         (tui_alloc_source_buffer, tui_line_is_displayed)
 614         (tui_addr_is_displayed): Change type of win_info.
 615         * tui/tui-winsource.c (tui_update_source_window_as_is)
 616         (tui_clear_source_content, tui_show_source_line)
 617         (tui_show_source_content, tui_source_window_base::refill)
 618         (tui_source_window_base::set_is_exec_point_at)
 619         (tui_source_window_base::set_is_exec_point_at)
 620         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
 621         (tui_alloc_source_buffer, tui_line_is_displayed)
 622         (tui_addr_is_displayed): Change type of win_info.  Update.
 623         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 624         (tui_source_window_base::do_make_visible_with_new_height):
 625         Update.
 626         * tui/tui-source.c (tui_set_source_content)
 627         (tui_set_source_content_nil)
 628         (tui_source_window::do_scroll_vertical): Update.
 629         * tui/tui-layout.c (show_layout): Update.
 630         * tui/tui-disasm.c (tui_set_disassem_content)
 631         (tui_disasm_window::do_scroll_vertical): Update.
 632         * tui/tui-data.h (tui_win_content): Remove.
 633         (struct tui_gen_win_info) <content, content_size>: Remove.
 634         (struct tui_source_element): Add initializers and destructor.
 635         (union tui_which_element, struct tui_win_element): Remove.
 636         (struct tui_source_window_base) <content>: New field.
 637         (struct tui_data_window): Remove destructor.
 638         (tui_alloc_content, tui_free_win_content)
 639         (tui_free_all_source_wins_content): Don't declare.
 640         * tui/tui-data.c (tui_initialize_static_data): Update.
 641         (init_content_element, tui_alloc_content): Remove.
 642         (~tui_gen_win_info): Update.
 643         (~tui_data_window, tui_free_all_source_wins_content)
 644         (tui_free_win_content, free_content, free_content_elements):
 645         Remove.
 646
 647 2019-06-25  Tom Tromey  <tom@tromey.com>
 648
 649         * tui/tui-winsource.h (tui_clear_source_content)
 650         (tui_erase_source_content, tui_show_source_content): Change type
 651         of win_info.
 652         * tui/tui-winsource.c (tui_clear_source_content)
 653         (tui_erase_source_content, tui_show_source_content): Change type
 654         of win_info.
 655         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 656         * tui/tui-source.h (tui_set_source_content_nil): Change type of
 657         win_info.
 658         * tui/tui-source.c (tui_set_source_content_nil): Change type of
 659         win_info.
 660         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
 661
 662 2019-06-25  Tom Tromey  <tom@tromey.com>
 663
 664         * tui/tui-winsource.c (tui_clear_source_content)
 665         (tui_source_window_base::set_is_exec_point_at): Update.
 666         * tui/tui-source.c (tui_set_source_content_nil): Update.
 667         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
 668         a bool.
 669         * tui/tui-data.c (init_content_element): Update.
 670
 671 2019-06-25  Tom Tromey  <tom@tromey.com>
 672
 673         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
 674         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
 675         * tui/tui-layout.c (init_and_make_win): Update.
 676         * tui/tui.h (enum tui_win_type): Update.
 677         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
 678         tui_win_is_auxillary.
 679         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
 680         tui_win_is_auxillary.
 681
 682 2019-06-25  Tom Tromey  <tom@tromey.com>
 683
 684         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
 685         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
 686         (tui_delete_data_content_windows, tui_display_all_data)
 687         (tui_data_window::do_scroll_vertical, tui_display_data_from):
 688         Update.
 689         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
 690         * tui/tui-regs.c (tui_last_regs_line_no)
 691         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 692         (tui_show_registers): Update.
 693         (tui_show_register_group): Return void.  Update.
 694         (tui_display_registers_from, tui_display_reg_element_at_line)
 695         (tui_display_registers_from_line, tui_check_register_values):
 696         Update.
 697         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
 698         member.
 699         (struct tui_data_window) <regs_content>: Now a std::vector.
 700         <regs_content_count>: Remove.
 701         (tui_add_content_elements, tui_free_data_content): Don't declare.
 702         * tui/tui-data.c (tui_data_window::clear_detail): Update.
 703         (init_content_element): Remove DATA_WIN case.  Add assert.
 704         (tui_add_content_elements): Remove.
 705         (tui_data_window): Update.
 706         (tui_free_data_content): Remove.
 707         (free_content_elements): Remove DATA_WIN case.
 708
 709 2019-06-25  Tom Tromey  <tom@tromey.com>
 710
 711         * tui/tui-data.c (tui_data_item_window): Update.
 712         * tui/tui-windata.h (tui_check_data_values): Don't declare.
 713         * tui/tui-windata.c (tui_display_all_data)
 714         (tui_display_data_from_line): Update.
 715         (tui_check_data_values): Remove.
 716         * tui/tui-regs.c (tui_show_register_group)
 717         (tui_display_reg_element_at_line): Update.
 718         * tui/tui-hooks.c (tui_register_changed)
 719         (tui_refresh_frame_and_register_information): Call
 720         tui_check_register_values.
 721         * tui/tui-data.h (struct tui_data_window) <data_content,
 722         data_content_count, data_type>: Remove.
 723         (enum tui_data_type): Remove.
 724
 725         * tui/tui-data.c (tui_data_window::clear_detail)
 726         (~tui_data_window): Update.
 727
 728 2019-06-25  Tom Tromey  <tom@tromey.com>
 729
 730         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
 731         declare.
 732         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
 733         Rename from tui_first_data_item_displayed.  Update.
 734         (tui_data_window::refresh_all)
 735         (tui_data_window::do_scroll_vertical): Update.
 736         * tui/tui-data.h (struct tui_data_window)
 737         <first_data_item_displayed>: Declare new method.
 738
 739 2019-06-25  Tom Tromey  <tom@tromey.com>
 740
 741         * tui/tui-data.h (tui_init_generic_part): Don't declare.
 742         * tui/tui-data.c (tui_init_generic_part): Remove, moving
 743         contents...
 744         (tui_initialize_static_data): ...here.
 745
 746 2019-06-25  Tom Tromey  <tom@tromey.com>
 747
 748         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 749         (tui_display_registers_from, tui_check_register_values): Update.
 750         (tui_display_register): Remove win_info parameter; update.
 751         (tui_get_register): Change type of parameters.
 752         * tui/tui-data.h (struct tui_data_element): Remove.
 753         (union tui_which_element) <data>: Remove.
 754         <data_window>: Change type.
 755         (struct tui_data_item_window): New.
 756         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
 757         case.  Add assert.
 758         (~tui_data_item_window): New destructor.
 759         (free_content_elements): Remove DATA_ITEM_WIN case.
 760
 761 2019-06-25  Tom Tromey  <tom@tromey.com>
 762
 763         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
 764         Remove.
 765
 766 2019-06-25  Tom Tromey  <tom@tromey.com>
 767
 768         * tui/tui-data.h (struct tui_command_element): Remove.
 769         (union tui_which_element) <command>: Remove.
 770         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
 771         assert.
 772         (free_content_elements): Remove CMD_WIN case.
 773
 774 2019-06-25  Tom Tromey  <tom@tromey.com>
 775
 776         * tui/tui-layout.c (tui_set_layout): Update.
 777         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
 778         * tui/tui-data.c (layout_def): Update.
 779
 780 2019-06-25  Tom Tromey  <tom@tromey.com>
 781
 782         * tui/tui-wingeneral.c (tui_refresh_all): Update.
 783         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 784         (tui_source_window_base::set_new_height): Update.
 785         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
 786         Update.
 787         (tui_set_locator_fullname, tui_set_locator_info)
 788         (tui_show_frame_info): Update.
 789         * tui/tui-source.c (tui_set_source_content)
 790         (tui_source_is_displayed): Update.
 791         * tui/tui-layout.c (show_source_disasm_command, show_data)
 792         (show_source_or_disasm_and_command): Update.
 793         * tui/tui-disasm.c (tui_set_disassem_content)
 794         (tui_get_begin_asm_address): Update.
 795         * tui/tui-data.h (struct tui_locator_element): Remove.
 796         (union tui_which_element) <locator>: Remove.
 797         (struct tui_locator_window): New.
 798         (tui_locator_win_info_ptr): Change return type.
 799         * tui/tui-data.c (_locator): Change type.
 800         (tui_locator_win_info_ptr): Change return type.
 801         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
 802         (tui_alloc_content): Add assert.
 803
 804 2019-06-25  Tom Tromey  <tom@tromey.com>
 805
 806         * tui/tui-winsource.c
 807         (tui_exec_info_window::maybe_allocate_content): New method.
 808         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
 809         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
 810         (make_source_or_disasm_window): Add cast.
 811         * tui/tui-data.h (union tui_which_element) <simple_string>:
 812         Remove.
 813         (struct tui_source_info): New.
 814         (struct tui_source_window_base) <execution_info>: Change type.
 815         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
 816         case, and add assert.
 817         (tui_alloc_content): Add assert.
 818
 819 2019-06-25  Tom Tromey  <tom@tromey.com>
 820
 821         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
 822         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
 823         * tui/tui-data.c (tui_alloc_win_info): Remove.
 824
 825 2019-06-25  Tom Tromey  <tom@tromey.com>
 826
 827         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
 828         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
 829         can_highlight.
 830
 831 2019-06-25  Tom Tromey  <tom@tromey.com>
 832
 833         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
 834         make_visible_with_new_height method.
 835         (tui_win_info::make_visible_with_new_height): New method.
 836         (tui_source_window_base::do_make_visible_with_new_height)
 837         (tui_data_window::do_make_visible_with_new_height)
 838         (tui_cmd_window::do_make_visible_with_new_height): New methods.
 839         (make_visible_with_new_height): Remove.
 840         (tui_resize_all, tui_adjust_win_heights): Use
 841         make_visible_with_new_height method.
 842         * tui/tui-data.h (struct tui_win_info)
 843         <do_make_visible_with_new_height, make_visible_with_new_height>:
 844         New methods.
 845         (struct tui_source_window_base, struct tui_data_window)
 846         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
 847         methods.
 848
 849 2019-06-25  Tom Tromey  <tom@tromey.com>
 850
 851         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
 852         method.
 853         (update_tab_width): Call update_tab_width method.
 854         * tui/tui-data.h (struct tui_win_info)
 855         (struct tui_source_window_base) <update_tab_width>: New methods.
 856
 857 2019-06-25  Tom Tromey  <tom@tromey.com>
 858
 859         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
 860         parameter.
 861         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
 862         parameter.
 863         (tui_gen_win_info::make_visible): Update.
 864         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
 865         parameter.
 866         * tui/tui-data.h (enum tui_box): New enum.
 867         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
 868
 869 2019-06-25  Tom Tromey  <tom@tromey.com>
 870
 871         * tui/tui-layout.c (make_source_or_disasm_window): Always use
 872         init_and_make_win for EXEC_INFO_WIN.
 873         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
 874         longer inline.
 875         (struct tui_win_info) <~tui_win_info>: Inline.
 876         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 877         Don't declare.
 878         * tui/tui-data.c (source_win, disasm_win): Remove globals.
 879         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 880         Remove.
 881         (tui_initialize_static_data): Update.
 882         (~tui_gen_win_info): Handle more cleanup here.
 883         (~tui_source_window_base): Delete "execution_info".
 884         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
 885
 886 2019-06-25  Tom Tromey  <tom@tromey.com>
 887
 888         * tui/tui-layout.c (make_command_window): Don't set
 889         can_highlight.
 890         (show_source_disasm_command): Call the reset method.
 891         (show_data): Don't set can_highlight.  Call the reset method.
 892         (tui_gen_win_info::reset): Rename from init_gen_win_info
 893         (init_and_make_win): Simplify.  Return tui_gen_win_info.
 894         (show_source_or_disasm_and_command): Call the reset method.
 895         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
 896         (struct tui_cmd_window): Set can_highlight.
 897
 898 2019-06-25  Tom Tromey  <tom@tromey.com>
 899
 900         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
 901         from make_visible.
 902         (tui_make_visible, tui_make_invisible): Rewrite.
 903         (tui_win_info::make_visible): Remove.
 904         (tui_source_window_base::make_visible): Update.
 905         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
 906         method.  Moved from...
 907         (struct tui_win_info) <make_visible>: ...here.
 908
 909 2019-06-25  Tom Tromey  <tom@tromey.com>
 910
 911         * tui/tui-winsource.c
 912         (tui_source_window_base::do_scroll_horizontal): Remove direction
 913         parameter.
 914         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
 915         direction parameter.
 916         * tui/tui-win.c (tui_win_info::forward_scroll)
 917         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 918         (tui_win_info::right_scroll): Update.
 919         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
 920         direction parameter.
 921         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
 922         direction parameter.
 923         * tui/tui-data.h (enum tui_scroll_direction): Remove.
 924         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
 925         Remove direction parameter.
 926         (struct tui_source_window_base, struct tui_source_window)
 927         (struct tui_disasm_window, struct tui_data_window)
 928         (struct tui_cmd_window): Update.
 929
 930 2019-06-25  Tom Tromey  <tom@tromey.com>
 931
 932         * tui/tui-winsource.h (tui_set_exec_info_content)
 933         (tui_show_exec_info_content, tui_erase_exec_info_content)
 934         (tui_clear_exec_info_content, tui_update_exec_info): Change
 935         argument to tui_source_window_base.
 936         * tui/tui-winsource.c (tui_set_exec_info_content)
 937         (tui_show_exec_info_content, tui_erase_exec_info_content)
 938         (tui_clear_exec_info_content, tui_update_exec_info): Change
 939         argument to tui_source_window_base.
 940
 941 2019-06-25  Tom Tromey  <tom@tromey.com>
 942
 943         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
 944         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
 945
 946 2019-06-25  Tom Tromey  <tom@tromey.com>
 947
 948         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
 949         check.
 950
 951 2019-06-25  Tom Tromey  <tom@tromey.com>
 952
 953         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
 954         type to void.
 955         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
 956         type to void.
 957         * tui/tui-source.c (tui_set_source_content): Update.
 958         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 959
 960 2019-06-25  Tom Tromey  <tom@tromey.com>
 961
 962         * tui/tui-win.c (window_name_completer, tui_set_focus)
 963         (tui_all_windows_info): Use name method.
 964         * tui/tui-data.h (struct tui_gen_win_info)
 965         (struct tui_source_window, struct tui_disasm_window)
 966         (struct tui_data_window, struct tui_cmd_window) <name>: New
 967         method.
 968         (tui_win_name): Don't declare.
 969         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
 970         (tui_win_name): Remove.
 971
 972 2019-06-25  Tom Tromey  <tom@tromey.com>
 973
 974         * tui/tui-winsource.h (tui_update_source_window)
 975         (tui_update_source_window_as_is): Change parameter type.
 976         * tui/tui-winsource.c (tui_update_source_window): Change win_info
 977         to be a tui_source_window_base.
 978         (tui_update_source_window_as_is): Likewise.
 979         * tui/tui-win.c (make_visible_with_new_height): Update.
 980
 981 2019-06-25  Tom Tromey  <tom@tromey.com>
 982
 983         * tui/tui-winsource.c (tui_erase_source_content)
 984         (tui_show_source_content, tui_show_exec_info_content)
 985         (tui_erase_exec_info_content): Use refresh_window method.
 986         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
 987         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
 988         from tui_refresh_win.
 989         (tui_data_window::refresh_window): New method.
 990         (tui_win_info::refresh, tui_source_window_base::refresh)
 991         (tui_refresh_all): Use refresh_window method.
 992         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
 993         method.
 994         * tui/tui-regs.c (tui_display_register): Call refresh_window
 995         method.
 996         * tui/tui-layout.c (show_source_disasm_command)
 997         (show_source_or_disasm_and_command): Call refresh_window method.
 998         * tui/tui-data.h (struct tui_gen_win_info)
 999         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1000         New method.
1001
1002 2019-06-25  Tom Tromey  <tom@tromey.com>
1003
1004         * tui/tui.c (tui_rl_other_window, tui_enable)
1005         (tui_is_window_visible, tui_get_command_dimension): Update.
1006         * tui/tui-winsource.c (tui_update_source_window_as_is)
1007         (tui_clear_source_content, tui_erase_source_content)
1008         (tui_show_source_line, tui_source_window_base::refill)
1009         (tui_source_window_base::do_scroll_horizontal)
1010         (tui_source_window_base::set_is_exec_point_at)
1011         (tui_update_breakpoint_info, tui_set_exec_info_content)
1012         (tui_alloc_source_buffer, tui_line_is_displayed)
1013         (tui_addr_is_displayed): Update.
1014         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1015         (tui_check_and_display_highlight_if_needed)
1016         (tui_win_info::make_visible, tui_win_info::refresh)
1017         (tui_refresh_all): Update.
1018         * tui/tui-windata.c (tui_first_data_item_displayed)
1019         (tui_delete_data_content_windows, tui_erase_data_content)
1020         (tui_display_all_data, tui_data_window::refresh_all)
1021         (tui_check_data_values): Update.
1022         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1023         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1024         (tui_win_info::backward_scroll, tui_refresh_all_win)
1025         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1026         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1027         (tui_source_window_base::set_new_height)
1028         (tui_data_window::set_new_height)
1029         (make_invisible_and_set_new_height)
1030         (make_visible_with_new_height, new_height_ok)
1031         (parse_scrolling_args): Update.
1032         * tui/tui-stack.c (tui_show_frame_info): Update.
1033         * tui/tui-source.c (tui_set_source_content)
1034         (tui_set_source_content_nil, tui_source_is_displayed)
1035         (tui_source_window::do_scroll_vertical): Update.
1036         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1037         (tui_display_registers_from, tui_display_reg_element_at_line)
1038         (tui_check_register_values, tui_reg_command): Update.
1039         * tui/tui-layout.c (tui_default_win_height)
1040         (show_source_disasm_command, show_data, init_and_make_win)
1041         (show_source_or_disasm_and_command): Update.
1042         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1043         (tui_redisplay_readline, tui_mld_flush)
1044         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1045         (tui_getc): Update.
1046         * tui/tui-disasm.c (tui_set_disassem_content)
1047         (tui_disasm_window::do_scroll_vertical): Update.
1048         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1049         Now virtual.
1050         (struct tui_win_info): Derive from tui_gen_win_info.
1051         <~tui_win_info>: Mark as override.
1052         <generic>: Remove member.
1053         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1054         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1055         (~tui_data_window, ~tui_win_info)
1056         (tui_free_all_source_wins_content): Update.
1057         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1058
1059 2019-06-25  Tom Tromey  <tom@tromey.com>
1060
1061         * tui/tui-layout.c (init_and_make_win): Use new.
1062         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1063         destructor, initializers.
1064         (tui_alloc_generic_win_info): Don't declare.
1065         * tui/tui-data.c (_locator): Add argument to constructor.
1066         (source_win, disasm_win): New globals.
1067         (exec_info): Remove.
1068         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1069         Update.
1070         (tui_alloc_generic_win_info): Remove.
1071         (init_content_element): Use new.
1072         (tui_win_info::tui_win_info): Update.
1073         (free_content_elements) <case DATA_WIN>: Use delete.
1074
1075 2019-06-25  Tom Tromey  <tom@tromey.com>
1076
1077         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1078         * tui/tui-windata.c (tui_first_data_item_displayed)
1079         (tui_delete_data_content_windows): Update.
1080         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1081         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1082         (tui_display_registers_from, tui_check_register_values): Update.
1083         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1084         pointer.
1085         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1086         window.
1087         (tui_free_data_content): Update.
1088         (free_content_elements) <case DATA_WIN>: Free the window.
1089
1090 2019-06-25  Tom Tromey  <tom@tromey.com>
1091
1092         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1093         Update.
1094         * tui/tui-layout.c (make_command_window)
1095         (show_source_disasm_command, show_data, init_and_make_win)
1096         (show_source_or_disasm_and_command): Update.
1097         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1098         method.
1099         <can_highight, is_highlighted>: Now bool.
1100         (tui_set_win_highlight): Don't declare.
1101         * tui/tui-data.c (tui_set_win_highlight): Remove.
1102
1103 2019-06-25  Tom Tromey  <tom@tromey.com>
1104
1105         * tui/tui-wingeneral.c (make_visible): Remove check of window
1106         type.
1107
1108 2019-06-25  Tom Tromey  <tom@tromey.com>
1109
1110         * tui/tui-win.c (tui_win_info::max_height)
1111         (tui_cmd_window::max_height): New methods.
1112         (new_height_ok): Call max_height.
1113         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1114         <max_height>: New method.
1115
1116 2019-06-25  Tom Tromey  <tom@tromey.com>
1117
1118         * tui/tui-win.c (tui_source_window_base::set_new_height)
1119         (tui_data_window::set_new_height): New methods.
1120         (make_invisible_and_set_new_height): Call set_new_height method.
1121         * tui/tui-data.h (struct tui_win_info)
1122         (struct tui_source_window_base, struct tui_data_window)
1123         <set_new_height>: New method.
1124
1125 2019-06-25  Tom Tromey  <tom@tromey.com>
1126
1127         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1128         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1129         tui_refresh_data_win.
1130         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1131         method.
1132         (tui_refresh_all_win): Call the refresh_all method.
1133         (tui_set_focus): Likewise.
1134         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1135         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1136         Likewise.
1137
1138 2019-06-25  Tom Tromey  <tom@tromey.com>
1139
1140         * tui/tui-winsource.h (tui_refill_source_window)
1141         (tui_set_is_exec_point_at): Don't declare.
1142         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1143         (tui_source_window_base::refill): Rename from
1144         tui_refill_source_window.
1145         (tui_source_window_base::do_scroll_horizontal): Update.
1146         (tui_source_window_base::set_is_exec_point_at): Rename from
1147         tui_set_is_exec_point_at.
1148         (tui_update_all_breakpoint_info): Update.
1149         * tui/tui-stack.c (tui_show_frame_info): Update.
1150         * tui/tui-layout.c (show_data): Add cast.
1151         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1152         * tui/tui-data.h (struct tui_source_window_base) <refill,
1153         set_is_exec_point_at>: New methods.
1154         (tui_source_windows, tui_add_to_source_windows): Update types.
1155         (tui_add_to_source_windows): Remove redundant declaration.
1156         * tui/tui-data.c (source_windows): Store tui_source_window_base.
1157         (tui_source_windows): Change return type.
1158         (tui_clear_source_windows_detail): Update.
1159         (tui_add_to_source_windows): Change type of parameter.
1160         (tui_free_all_source_wins_content): Update.
1161
1162 2019-06-25  Tom Tromey  <tom@tromey.com>
1163
1164         * tui/tui-wingeneral.c (tui_win_info::refresh)
1165         (tui_source_window_base::refresh): New methods.
1166         (tui_refresh_all): Call the refresh method.
1167         * tui/tui-data.h (struct tui_win_info)
1168         (struct tui_source_window_base) <refresh>: New method.
1169
1170 2019-06-25  Tom Tromey  <tom@tromey.com>
1171
1172         * tui/tui.h (tui_is_window_visible): Return bool.
1173         * tui/tui.c (tui_is_window_visible): Return bool.
1174         * tui/tui-wingeneral.c (tui_make_window, make_visible)
1175         (tui_make_visible, tui_make_invisible)
1176         (tui_win_info::make_visible)
1177         (tui_source_window_base::make_visible, make_all_visible)
1178         (tui_make_all_visible, tui_make_all_invisible): Update.
1179         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
1180         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
1181         bool.
1182         (struct tui_win_info, struct tui_source_window_base)
1183         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
1184         * tui/tui-data.c (tui_init_generic_part): Update.
1185
1186 2019-06-25  Tom Tromey  <tom@tromey.com>
1187
1188         * tui/tui-wingeneral.c (tui_win_info::make_visible)
1189         (tui_source_window_base::make_visible): New methods.
1190         (make_all_visible): Make method call.
1191         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
1192         (struct tui_source_window_base, struct tui_cmd_window): Override
1193         make_visible.
1194         (tui_win_is_source_type): Don't declare.
1195         * tui/tui-data.c (tui_win_is_source_type): Remove.
1196
1197 2019-06-25  Tom Tromey  <tom@tromey.com>
1198
1199         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
1200         NULL check.
1201
1202 2019-06-25  Tom Tromey  <tom@tromey.com>
1203
1204         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
1205         Inline constructor.  Add initializers for members.
1206         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
1207         constructors; now inline in class.
1208
1209 2019-06-25  Tom Tromey  <tom@tromey.com>
1210
1211         * tui/tui-regs.c (tui_show_registers): Update.
1212         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
1213         bool.
1214         * tui/tui-data.c (tui_data_window::clear_detail)
1215         (tui_data_window): Update.
1216
1217 2019-06-25  Tom Tromey  <tom@tromey.com>
1218
1219         * tui/tui-windata.c (tui_display_all_data)
1220         (tui_display_data_from_line, tui_display_data_from)
1221         (tui_check_data_values, tui_data_window::do_scroll_vertical):
1222         Update.
1223         * tui/tui-regs.c (tui_last_regs_line_no)
1224         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1225         (tui_show_registers, tui_show_register_group)
1226         (tui_display_registers_from, tui_display_reg_element_at_line)
1227         (tui_display_registers_from_line, tui_check_register_values)
1228         (tui_reg_next, tui_reg_prev): Update.
1229         * tui/tui-layout.c (tui_set_layout, show_data): Update.
1230         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
1231         tui_data_window.
1232         (struct tui_win_info) <detail>: Remove.  Add new fields from
1233         tui_data_info.
1234         (TUI_DATA_WIN): Add cast.
1235         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
1236         (~tui_data_window): Simplify.
1237
1238 2019-06-25  Tom Tromey  <tom@tromey.com>
1239
1240         * tui/tui-layout.c (show_source_disasm_command)
1241         (show_source_or_disasm_and_command): Update.
1242         * tui/tui-io.c (update_cmdwin_start_line)
1243         (tui_redisplay_readline): Update.
1244         * tui/tui-data.h (struct tui_command_info): Remove.
1245         (struct tui_win_info) <detail>: Remove command_info member.
1246         (struct tui_data_window) <start_line>: New member, from
1247         tui_command_info.
1248         (TUI_CMD_WIN): Add casts.
1249
1250 2019-06-25  Tom Tromey  <tom@tromey.com>
1251
1252         * tui/tui-winsource.c (tui_update_source_window)
1253         (tui_refill_source_window)
1254         (tui_source_window_base::do_scroll_horizontal)
1255         (tui_update_breakpoint_info, tui_set_exec_info_content)
1256         (tui_show_exec_info_content, tui_erase_exec_info_content)
1257         (tui_clear_exec_info_content): Update.
1258         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
1259         Update.
1260         * tui/tui-win.c (make_invisible_and_set_new_height)
1261         (make_visible_with_new_height): Update.
1262         * tui/tui-source.c (tui_set_source_content)
1263         (tui_show_symtab_source): Update.
1264         * tui/tui-layout.c (extract_display_start_addr)
1265         (show_source_disasm_command, show_data)
1266         (make_source_or_disasm_window)
1267         (show_source_or_disasm_and_command): Update.
1268         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
1269         (tui_disasm_window::do_scroll_vertical): Remove shadowing
1270         "gdbarch".
1271         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
1272         to tui_source_window_base.
1273         (struct tui_win_info) <detail>: Remove source_info member.
1274         (struct tui_source_window_base) <has_locator>: Inline.
1275         Move contents from tui_source_info; rename has_locator member to
1276         m_has_locator.
1277         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
1278         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
1279         header file.
1280         (tui_source_window_base::clear_detail, ~tui_source_window_base):
1281         Simplify.
1282         (tui_free_all_source_wins_content): Cast to
1283         tui_source_window_base.
1284
1285 2019-06-25  Tom Tromey  <tom@tromey.com>
1286
1287         * tui/tui-win.c (make_invisible_and_set_new_height)
1288         (make_visible_with_new_height): Call has_locator method.
1289         * tui/tui-layout.c (show_source_disasm_command, show_data)
1290         (show_source_or_disasm_and_command): Update for bool change.
1291         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
1292         (tui_win_info) <has_locator>: New method.
1293         (struct tui_source_window_base) <has_locator>: New method.
1294         (tui_win_has_locator): Don't declare.
1295         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
1296         from tui_win_has_locator.
1297         (tui_source_window_base): Use false, not FALSE.
1298
1299 2019-06-25  Tom Tromey  <tom@tromey.com>
1300
1301         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
1302         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
1303         clear_detail method directly.
1304         (tui_clear_win_detail): Remove.
1305
1306 2019-06-25  Tom Tromey  <tom@tromey.com>
1307
1308         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
1309         "this", not TUI_DISASM_WIN.
1310
1311 2019-06-25  Tom Tromey  <tom@tromey.com>
1312
1313         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
1314         declare.
1315         * tui/tui-winsource.c
1316         (tui_source_window_base::do_scroll_horizontal): Rename from
1317         tui_horizontal_source_scroll.
1318         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
1319         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
1320         from tui_vertical_data_scroll.
1321         * tui/tui-win.h (tui_scroll): Don't declare.
1322         * tui/tui-win.c (tui_win_info::forward_scroll)
1323         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1324         (tui_win_info::right_scroll): Rename and update.
1325         (tui_scroll_forward_command, tui_scroll_backward_command)
1326         (tui_scroll_left_command, tui_scroll_right_command): Update.
1327         (tui_scroll): Remove.
1328         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
1329         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
1330         from tui_vertical_source_scroll.
1331         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
1332         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
1333         from tui_vertical_disassem_scroll.
1334         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
1335         do_scroll_horizontal>: New methods.
1336         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
1337         Likewise.
1338         (struct tui_source_window_base): Add do_scroll_horizontal.
1339         (struct tui_source_window, struct tui_disasm_window): Add
1340         do_scroll_vertical.
1341         (struct tui_data_window, struct tui_cmd_window): Add
1342         do_scroll_horizontal and do_scroll_vertical.
1343         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
1344
1345 2019-06-25  Tom Tromey  <tom@tromey.com>
1346
1347         * tui/tui-data.h (struct tui_source_window_base): New struct.
1348         (struct tui_source_window): Derive from tui_source_window_base.
1349         (struct tui_disasm_window): New struct.
1350         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
1351         from tui_source_window::clear_detail.
1352         (tui_source_window_base): Rename from tui_source_window.
1353         (~tui_source_window_base): Rename from ~tui_source_window.
1354         (tui_alloc_win_info): Create a tui_disasm_window.
1355
1356 2019-06-25  Tom Tromey  <tom@tromey.com>
1357
1358         * tui/tui-data.h (struct tui_source_window)
1359         (struct tui_data_window): Declare destructors.
1360         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
1361         destructors.
1362         (tui_win_info): Simplify.
1363
1364 2019-06-25  Tom Tromey  <tom@tromey.com>
1365
1366         * tui/tui-winsource.c (tui_display_main)
1367         (tui_update_source_windows_with_addr)
1368         (tui_update_all_breakpoint_info): Update.
1369         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1370         (new_height_ok, parse_scrolling_args): Update.
1371         * tui/tui-stack.c (tui_show_frame_info): Update.
1372         * tui/tui-data.h (struct tui_list): Remove.
1373         (tui_source_windows): Return a reference to a std::vector.
1374         * tui/tui-data.c (source_windows): Now a std::vector.
1375         (tui_source_windows): Change return type.
1376         (tui_clear_source_windows): Rewrite.
1377         (tui_clear_source_windows_detail, tui_add_to_source_windows)
1378         (tui_free_all_source_wins_content): Rewrite.
1379
1380 2019-06-25  Tom Tromey  <tom@tromey.com>
1381
1382         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
1383         (struct tui_data_window, struct tui_cmd_window): Declare
1384         clear_detail method.
1385         * tui/tui-data.c (tui_source_window::clear_detail)
1386         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
1387         methods.
1388         (tui_clear_win_detail): Simplify.
1389
1390 2019-06-25  Tom Tromey  <tom@tromey.com>
1391
1392         * tui/tui-layout.c (make_source_window, make_disasm_window)
1393         (make_source_or_disasm_window): Remove win_info_ptr parameter.
1394         Return the new window.
1395         (show_source_disasm_command, show_data)
1396         (show_source_or_disasm_and_command): Update.
1397
1398 2019-06-25  Tom Tromey  <tom@tromey.com>
1399
1400         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
1401         parameter.  Return the new window.
1402         (show_source_disasm_command): Update and remove NULL check.
1403         (show_source_or_disasm_and_command): Update.
1404
1405 2019-06-25  Tom Tromey  <tom@tromey.com>
1406
1407         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
1408
1409 2019-06-25  Tom Tromey  <tom@tromey.com>
1410
1411         * tui/tui-data.h (struct tui_win_info): Make constructor
1412         protected.  Make destructor virtual.  Add initializers.
1413         (tui_source_window, tui_data_window, tui_cmd_window): New
1414         classes.
1415         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
1416         constructor.  Add "type" parameter.
1417         (tui_source_window, tui_data_window, tui_cmd_window): New
1418         constructors.
1419         (tui_alloc_win_info): Instantiate the appropriate subclass.
1420
1421 2019-06-25  Tom Tromey  <tom@tromey.com>
1422
1423         * tui/tui-win.c (tui_resize_all): Use delete.
1424         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
1425         destructor.
1426         (tui_free_window): Don't declare.
1427         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
1428         Update.
1429
1430 2019-06-25  Tom Tromey  <tom@tromey.com>
1431
1432         * tui/tui-data.h (struct tui_win_info): Add constructor.
1433         * tui/tui-data.c (tui_alloc_win_info): Use new.
1434         (tui_free_window): Use delete.
1435
1436 2019-06-22  Tom Tromey  <tom@tromey.com>
1437
1438         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
1439         declare.
1440         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
1441
1442 2019-06-22  Tom Tromey  <tom@tromey.com>
1443
1444         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
1445         declare.
1446         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
1447
1448 2019-06-22  Tom de Vries  <tdevries@suse.de>
1449
1450         * dwarf2read.c (create_addrmap_from_aranges)
1451         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
1452         instead of '%zu'.
1453
1454 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
1455
1456         * dwarf2read.h (dwarf2_section_info_def): Remove.
1457         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
1458         * dwarf2read.c (struct dwo_sections) <types>: Change type to
1459         std::vector<dwarf2_section_info>.
1460         (struct dwo_file) <~dwo_file>: Remove.
1461         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
1462         types field.
1463         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
1464         (dwarf2_read_debug_names): Likewise.
1465         (create_debug_types_hash_table): Change parameter type to
1466         array_view, adjust code accordingly.
1467         (dwarf2_locate_dwo_sections): Adjust to std::vector.
1468         (partial_die_info::fixup): Likewise.
1469         (determine_prefix): Likewise.
1470         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
1471
1472 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1473
1474         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
1475         gdb_bfd_ref_ptr.
1476         <~dwo_file>: Remove call to gdb_bfd_unref.
1477         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
1478         gdb_bfd_ref_ptr::get.
1479
1480 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1481
1482         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
1483         type to htab_up.
1484         * dwarf2read.c (struct dwo_file): Initialize fields.
1485         <~dwo_file>: New.
1486         (free_dwo_file): Remove, move content to ~dwo_file.
1487         (struct dwo_file_deleter): Remove.
1488         (dwo_file_up>: Remove custom deleter.
1489         (free_dwo_files): Remove.
1490         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
1491         dwo_files.
1492         (process_skeletonless_type_units): Call unique_ptr::get.
1493         (allocate_dwo_file_hash_table): Add deleter to created hash
1494         table.  Change return type to htab_up.
1495         (lookup_dwo_file_slot): Don't memset dwo_file, call
1496         unique_ptr::get.
1497         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
1498         (create_dwo_unit_in_dwp_v2): Likewise.
1499         (open_and_init_dwo_file): Likewise.
1500         (free_dwo_file_from_slot): Remove.
1501
1502 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1503
1504         * dwarf2read.h (struct dwarf2_section_info) <readin,
1505         is_virtual>: Change type to bool.
1506         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
1507         true instead of 1.
1508
1509 2019-06-19  Tom Tromey  <tom@tromey.com>
1510
1511         * tui/tui-data.h (tui_init_content_element): Don't declare.
1512
1513 2019-06-19  Tom Tromey  <tom@tromey.com>
1514
1515         * tui/tui-data.h (tui_init_win_info): Don't declare.
1516
1517 2019-06-19  Tom de Vries  <tdevries@suse.de>
1518
1519         * dwarf2read.h (abstract_to_concrete): Change type to
1520         std::unordered_map<sect_offset, std::vector<sect_offset>,
1521         gdb::hash_enum<sect_offset>>.
1522
1523 2019-06-19  Tom Tromey  <tromey@adacore.com>
1524
1525         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
1526         EVAL_AVOID_SIDE_EFFECTS specially.
1527
1528 2019-06-19  Tom Tromey  <tromey@adacore.com>
1529
1530         * source-cache.c (highlighter): New global.
1531         (source_cache::get_source_lines): Create a highlighter on demand.
1532
1533 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1534
1535         * defs.h (deprecated_interactive_hook): Delete declaration.
1536         * interps.c (clear_interpreter_hooks): Remove use of
1537         deprecated_interactive_hook.
1538         * top.c (deprecated_interactive_hook): Delete definition.
1539         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
1540
1541 2019-06-18  Tom de Vries  <tdevries@suse.de>
1542
1543         PR gdb/24515
1544         * dwarf2read.h (abstract_to_concrete): Change type from
1545         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
1546         std::unordered_map<sect_offset, std::vector<sect_offset>>.
1547         * dwarf2read.c (read_variable): Update.
1548         (dwarf2_fetch_die_loc_sect_off): Update.
1549
1550 2019-06-17  Tom de Vries  <tdevries@suse.de>
1551
1552         PR gdb/24617
1553         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
1554         accessing parent[parent_len - 1].
1555
1556 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
1557
1558         PR gdb/24364
1559         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
1560         call dtrace_process_dof with NULL dof.
1561
1562 2019-06-16  Tom de Vries  <tdevries@suse.de>
1563
1564         PR gdb/24445
1565         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
1566
1567 2019-06-16  Tom Tromey  <tom@tromey.com>
1568
1569         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1570         (make_all_visible): Use address of member.
1571
1572 2019-06-16  Tom Tromey  <tom@tromey.com>
1573
1574         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
1575         (tui_free_window, free_content, free_content_elements): Remove
1576         unnecessary cast.
1577         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
1578         cast.
1579         * tui/tui-regs.c (tui_show_register_group)
1580         (tui_display_registers_from, tui_display_reg_element_at_line):
1581         Remove unnecessary cast.
1582
1583 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
1584
1585         * linux-nat.c (normal_mask): Delete.
1586         (_initialize_linux_nat): Don't initialise normal_mask.
1587
1588 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
1589
1590         PR gdb/24445
1591         * dwarf-index-write.h (write_psymtabs_to_index): Add
1592         dwz_basename parameter.
1593         * dwarf-index-write.c (write_gdbindex): Move file writing to
1594         write_gdbindex_1.  Change return type void.
1595         (assert_file_size): Move up, remove filename parameter.
1596         (write_gdbindex_1): New function.
1597         (write_debug_names): Change return type to void, call
1598         assert_file_size.
1599         (struct index_wip_file): New struct.
1600         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
1601         file logic to index_wip_file.  Write index for dwz file if
1602         needed.
1603         (save_gdb_index_command): Pass basename of dwz file, if present.
1604         * dwarf-index-cache.c (index_cache::store): Obtain and pass
1605         build-id of dwz file, if present.
1606         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
1607         (dwarf2_get_dwz_file): Likewise.
1608         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
1609         (dwarf2_get_dwz_file): Likewise.
1610
1611 2019-06-16  Tom Tromey  <tom@tromey.com>
1612
1613         * coffread.c (process_coff_symbol): Use xstrdup.
1614         * value.c (create_internalvar): Use xstrdup.
1615
1616 2019-06-16  Tom Tromey  <tom@tromey.com>
1617
1618         * valops.c (value_cast, value_slice): Remove unnecessary cast.
1619         * breakpoint.c (stopin_command, stopat_command)
1620         (until_break_command, decode_location_default): Remove unnecessary
1621         cast.
1622         * utils.c (subset_compare): Remove unnecessary cast.
1623         * ada-lang.c (ada_update_initial_language): Remove unnecessary
1624         cast.
1625         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
1626         cast.
1627         * infcmd.c (path_command): Remove unnecessary cast.
1628         * coffread.c (decode_type): Remove unnecessary cast.
1629         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
1630         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
1631         * tui/tui-stack.c (tui_show_locator_content)
1632         (tui_show_frame_info): Remove unnecessary cast.
1633         * tui/tui-win.c (tui_scroll_forward_command)
1634         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
1635         (parse_scrolling_args): Remove unnecessary cast.
1636         * tui/tui-data.c (init_win_info, tui_del_window)
1637         (tui_free_window, tui_del_data_windows, tui_free_data_content)
1638         (free_content_elements): Remove unnecessary cast.
1639         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
1640         unnecessary cast.
1641         * tui/tui-source.c (tui_set_source_content)
1642         (tui_vertical_source_scroll): Remove unnecessary cast.
1643         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
1644         cast.
1645         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
1646         * tui/tui-regs.c (tui_display_registers_from)
1647         (tui_display_register): Remove unnecessary cast.
1648         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
1649         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
1650         (make_visible): Remove unnecessary cast.
1651         * tui/tui-winsource.c (tui_erase_source_content)
1652         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
1653         unnecessary cast.
1654         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
1655         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
1656         * stabsread.c (read_type, read_array_type, read_range_type):
1657         Remove unnecessary cast.
1658         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
1659         (parse_symbol, parse_type, upgrade_type, parse_external)
1660         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
1661         unnecessary cast.
1662         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
1663
1664 2019-06-16  Tom Tromey  <tom@tromey.com>
1665
1666         * tui/tui-data.c (tui_alloc_generic_win_info)
1667         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
1668         checks.
1669
1670 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
1671             Andrew Burgess  <andrew.burgess@embecosm.com>
1672
1673         * f-typeprint.c (f_print_type): Don't return early for not
1674         associated or not allocated types.
1675         (f_type_print_varspec_suffix): Add print_rank parameter and print
1676         ranks of array types in case they dangling.
1677         (f_type_print_base): Add print_rank parameter.
1678
1679 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1680
1681         * NEWS: Mention new MI commands.
1682         * break-catch-throw.c (enum exception_event_kind): Move to
1683         breakpoint.h.
1684         (print_mention_exception_catchpoint): Output text as a single
1685         message.
1686         (catch_exception_command_1): Rename to...
1687         (catch_exception_event): ...this, make non-static, update header
1688         command, and change some parameter types.
1689         (catch_catch_command): Update for changes to
1690         catch_exception_command_1.
1691         (catch_throw_command): Likewise.
1692         (catch_rethrow_command): Likewise.
1693         * breakpoint.c (enum exception_event_kind): Delete.
1694         * breakpoint.h (enum exception_event_kind): Moved here from
1695         break-catch-throw.c.
1696         (catch_exception_event): Declare.
1697         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
1698         (mi_cmd_catch_throw): New function.
1699         (mi_cmd_catch_rethrow): New function.
1700         (mi_cmd_catch_catch): New function.
1701         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
1702         'catch-catch' entries.
1703         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
1704         (mi_cmd_catch_rethrow): Declare.
1705         (mi_cmd_catch_catch): Declare.
1706
1707 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1708
1709         * annotate.c (annotate_source_line): Change return type to void,
1710         update implementation to match.
1711         * annotate.h (annotate_source_line): Change return type to void,
1712         update header comment.
1713         * stack.c (print_frame_info): Don't change what frame information
1714         is printed based on whether annotations are on or not.
1715
1716 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1717
1718         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
1719         (annotate_source): Make static.
1720         (annotate_source_line): Moved from source.c and renamed from
1721         identify_source_line.  Update the return type.
1722         * annotate.h (annotate_source): Delete declaration.
1723         (annotate_source_line): Declaration moved from source.h, and
1724         renamed from identify_source_line.  Return type updated.
1725         * source.c (identify_source_line): Moved to annotate.c and renamed
1726         to annotate_source_line.
1727         (info_line_command): Remove check of annotation_level.
1728         * source.h (identify_source_line): Move declaration to annotate.h
1729         and rename to annotate_source_line.
1730         * stack.c: Add 'annotate.h' include.
1731         (print_frame_info): Remove check of annotation_level before
1732         calling annotate_source_line.
1733
1734 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1735
1736         * source-cache.c (source_cache::get_plain_source_lines): Use
1737         open_source_file_with_line_charpos instead of just
1738         open_source_file, remove call to find_source_lines.
1739         (source_cache::get_source_lines): Likewise.
1740         * source.c (find_source_lines): Make static.
1741         (get_filename_and_charpos): Renamed into...
1742         (open_source_file_with_line_charpos): ..this along with changes to
1743         return a scoped_fd, and some other minor clean ups.
1744         (identify_source_line): Use open_source_file_with_line_charpos.
1745         (search_command_helper): Use open_source_file_with_line_charpos
1746         instead of just open_source_file, remove call to
1747         find_source_lines.
1748         * source.h (open_source_file_with_line_charpos): Declare new
1749         function.
1750         (find_source_lines): Delete declaration.
1751
1752 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1753
1754         * source.c (get_filename_and_charpos): Remove fullname
1755         parameter.
1756         (identify_source_line): Update call to get_filename_and_charpos.
1757
1758 2019-06-14  Tom Tromey  <tromey@adacore.com>
1759
1760         PR gdb/24502:
1761         * ui-style.h (skip_ansi_escape): Update comment.
1762         * ui-file.h (class no_terminal_escape_file): New class.
1763         * ui-file.c (no_terminal_escape_file::write)
1764         (no_terminal_escape_file::puts): New methods.
1765         * cli/cli-logging.c (handle_redirections): Use
1766         no_terminal_escape_file.
1767
1768 2019-06-14  Tom Tromey  <tromey@adacore.com>
1769
1770         * NEWS: Move convenience variable news above Python news.
1771
1772 2019-06-14  Tom Tromey  <tom@tromey.com>
1773
1774         * gnulib: Move directory to top-level.
1775         * configure.ac: Don't configure gnulib.
1776         * configure: Rebuild.
1777         * common/common-defs.h: Use new path to gnulib.
1778         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
1779         (GNULIB_H): Remove.
1780         (INCGNU): Look in new gnulib location.
1781         (HFILES_NO_SRCDIR): Remove gnulib files.
1782         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
1783         (generated_files): Remove GNULIB_H.
1784         ($(LIBGNU), all-lib): Remove targets.
1785         (distclean): Don't mention GNULIB_BUILDDIR.
1786         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
1787
1788 2019-06-14  Tom Tromey  <tromey@adacore.com>
1789
1790         * symfile.c (add_symbol_file_command): Remove obsolete comment.
1791         Warn if symbol file does not provide any symbols.
1792
1793 2019-06-14  Tom Tromey  <tromey@adacore.com>
1794
1795         * source.c (find_and_open_source): Respect basenames_may_differ.
1796
1797 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
1798
1799         * annotate.c (annotate_breakpoints_invalid): Make use of
1800         scoped_restore_terminal_state.
1801         (annotate_frames_invalid): Likewise.
1802
1803 2019-06-14  Tom Tromey  <tromey@adacore.com>
1804
1805         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
1806         allow assignment to an internalvar.
1807
1808 2019-06-14  Tom Tromey  <tromey@adacore.com>
1809
1810         * ada-lex.l: Allow "_" in attribute names.
1811
1812 2019-06-14  Tom Tromey  <tromey@adacore.com>
1813
1814         PR gdb/24653:
1815         * regcache.c (registers_changed): Don't call alloca.
1816         * top.c (execute_command): Don't call alloca.
1817
1818 2019-06-13  Pedro Alves  <palves@redhat.com>
1819
1820         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
1821         'expression'.  When parsing an expression, error out if there's
1822         junk after "unlimited".
1823         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1824         (do_set_command): Adjust calls to is_unlimited_literal.
1825
1826 2019-06-13  Pedro Alves  <palves@redhat.com>
1827
1828         * compile/compile.c (make_compile_options_def_group): Add braces
1829         around array_view initializer.
1830         * thread.c (make_thread_apply_all_options_def_group)
1831         (make_thread_apply_all_options_def_group): Likewise.
1832
1833 2019-06-13  Pedro Alves  <palves@redhat.com>
1834
1835         * NEWS (New commands): Mention "maint test-options
1836         require-delimiter", "maint test-options unknown-is-error", "maint
1837         test-options unknown-is-operand" and "maint show
1838         test-options-completion-result".
1839         (New command options, command completion): New section.
1840         (Completion improvements): New section.
1841         Mention that you can abbreviate "unlimited".
1842
1843 2019-06-13  Pedro Alves  <palves@redhat.com>
1844
1845         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
1846         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
1847         * unittests/cli-utils-selftests.c (test_parse_flags)
1848         (test_parse_flags_qcs): Delete.
1849         (test_cli_utils): Don't call deleted functions.
1850
1851 2019-06-13  Pedro Alves  <palves@redhat.com>
1852
1853         * thread.c: Include "cli/cli-option.h".
1854         (tp_array_compar_ascending): Global.
1855         (tp_array_compar): Delete function.
1856         (tp_array_compar_ascending, tp_array_compar_descending): New
1857         functions.
1858         (ascending_option_def, qcs_flag_option_def)
1859         (thr_qcs_flags_option_defs)
1860         (make_thread_apply_all_options_def_group)
1861         (make_thread_apply_options_def_group): New.
1862         (thread_apply_all_command): Use gdb::option::process_options.
1863         (thread_apply_command_completer)
1864         (thread_apply_all_command_completer): New.
1865         (thread_apply_command): Use gdb::option::process_options.
1866         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
1867         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
1868         to generate help text of "thread apply".  Adjust "taas"'s help.
1869         * tid-parse.c (tid_range_parser::in_thread_range): New method.
1870         * tid-parse.h (tid_range_parser::in_thread_range): New method.
1871
1872 2019-06-13  Pedro Alves  <palves@redhat.com>
1873
1874         * thread.c (thread_apply_command): Check for invalid TID with
1875         isdigit instead of !isalpha.
1876
1877 2019-06-13  Pedro Alves  <palves@redhat.com>
1878
1879         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
1880         (validate_flags_qcs): New.
1881         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
1882         (validate_flags_qcs): Declare.
1883         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
1884         (make_frame_apply_options_def_group): New.
1885         (frame_apply_command_count): Process options with
1886         gdb::option::process_options.
1887         (frame_apply_completer): New.
1888         (frame_apply_level_completer, frame_apply_all_completer)
1889         (frame_apply_completer): New.
1890         (_initialize_stack): Update help of "frame apply", "frame apply
1891         level", "frame apply all" and "faas" to mention supported options
1892         and install command completers.
1893         * stack.h (frame_apply_all_completer): Declare.
1894         * thread.c: Include "stack.h".
1895         (tfaas_command): Add "--".
1896         (_initialize_thread): Update help "tfaas" to mention supported
1897         options and install command completer.
1898
1899 2019-06-13  Pedro Alves  <palves@redhat.com>
1900
1901         * completer.c (complete_nested_command_line): New.
1902         (gdb_completion_word_break_characters_throw): Add assertion.
1903         * completer.h (complete_nested_command_line): Declare.
1904
1905 2019-06-13  Pedro Alves  <palves@redhat.com>
1906
1907         * stack.c (parse_backtrace_qualifiers): New.
1908         (backtrace_command): Use it.
1909         (backtrace_command_completer): Complete on qualifiers.
1910
1911 2019-06-13  Pedro Alves  <palves@redhat.com>
1912
1913         * frame.c: Include "cli/cli-option.h.
1914         (user_set_backtrace_options): New.
1915         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
1916         Delete.
1917         (get_prev_frame): Adjust.
1918         (boolean_option_def, uinteger_option_def)
1919         (set_backtrace_option_defs): New.
1920         (_initialize_frame): Adjust and use
1921         gdb::option::add_setshow_cmds_for_options to install "set
1922         backtrace past-main" and "set backtrace past-entry".
1923         * frame.h: Include "cli/cli-option.h".
1924         (struct frame_print_options): Forward declare.
1925         (print_frame_arguments_all, print_frame_arguments_scalars)
1926         (print_frame_arguments_none): Declare.
1927         (print_entry_values): Delete declaration.
1928         (struct frame_print_options, user_frame_print_options): New.
1929         (struct set_backtrace_options): New.
1930         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
1931         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
1932         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
1933         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
1934         (list_args_or_locals): Add frame_print_options parameter.
1935         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1936         * python/py-framefilter.c (enumerate_args): Pass down
1937         USER_FRAME_PRINT_OPTIONS.
1938         * stack.c: Include "cli/cli-option.h".
1939         (print_frame_arguments_all, print_frame_arguments_scalars)
1940         (print_frame_arguments_none): Declare.
1941         (print_raw_frame_arguments, print_entry_values): Delete.
1942         (user_frame_print_options): New.
1943         (boolean_option_def, enum_option_def, frame_print_option_defs):
1944         New.
1945         (struct backtrace_cmd_options): New.
1946         (bt_flag_option_def): New.
1947         (backtrace_command_option_defs): New.
1948         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1949         (print_frame_arg, read_frame_arg, print_frame_args)
1950         (print_frame_info, print_frame): Add frame_print_options parameter
1951         and use it.
1952         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
1953         (backtrace_command_1): Add frame_print_options and
1954         backtrace_cmd_options parameters and use them.
1955         (make_backtrace_options_def_group): New.
1956         (backtrace_command): Process command options with
1957         gdb::option::process_options.
1958         (backtrace_command_completer): New.
1959         (_initialize_stack): Extend "backtrace"'s help to mention
1960         supported options.  Install completer for "backtrace".
1961         Install some settings commands with add_setshow_cmds_for_options.
1962
1963 2019-06-13  Pedro Alves  <palves@redhat.com>
1964
1965         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
1966         and that "set/show print raw frame-arguments" are now deprecated.
1967
1968         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
1969         command.
1970         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
1971         * stack.c (_initialize_stack): Install "set/show print
1972         raw-frame-arguments", and deprecate "set/show print raw
1973         frame-arguments".
1974         * valprint.c (_initialize_valprint): Deprecate "set/show print
1975         raw".
1976
1977 2019-06-13  Pedro Alves  <palves@redhat.com>
1978
1979         * compile/compile.c (struct compile_options): New.
1980         (compile_flag_option_def, compile_command_option_defs)
1981         (make_compile_options_def_group): New.
1982         (compile_file_command): Handle options with
1983         gdb::option::process_options.
1984         (compile_file_command_completer): New function.
1985         (compile_code_command): Handle options with
1986         gdb::option::process_options.
1987         (compile_code_command_completer): New function.
1988         (_initialize_compiler): Install completers for "compile code" and
1989         "compile file".  Mention available options in "compile code" and
1990         "compile code"'s help.
1991         * completer.c (advance_to_completion_word): New, factored out from
1992         ...
1993         (advance_to_expression_complete_word_point): ... this.
1994         (advance_to_filename_complete_word_point): New.
1995         * completer.h (advance_to_filename_complete_word_point): New
1996         declaration.
1997
1998 2019-06-13  Pedro Alves  <palves@redhat.com>
1999
2000         * compile/compile.c: Include "cli/cli-option.h".
2001         (compile_print_value): Scope data pointer is now a
2002         value_print_options pointer; adjust.
2003         (compile_print_command): Process options.  Scope data pointer is
2004         now a value_print_options pointer; adjust.
2005         (_initialize_compile): Update "compile print"'s help to include
2006         supported options.  Install a completer for "compile print".
2007         * cp-valprint.c (show_vtblprint, show_objectprint)
2008         (show_static_field_print): Delete.
2009         (_initialize_cp_valprint): Don't install "set print
2010         static-members", "set print vtbl", "set print object" here.
2011         * printcmd.c: Include "cli/cli-option.h" and
2012         "common/gdb_optional.h".
2013         (print_command_parse_format): Rework to fill in a
2014         value_print_options instead of a format_data.
2015         (print_value): Change parameter type from format_data pointer to
2016         value_print_options reference.  Adjust.
2017         (print_command_1): Process options.  Adjust to pass down a
2018         value_print_options.
2019         (print_command_completer): New.
2020         (_initialize_printcmd): Install print_command_completer as
2021         handle_brkchars completer for the "print" command.  Update
2022         "print"'s help to include supported options.
2023         * valprint.c: Include "cli/cli-option.h".
2024         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2025         here from cp-valprint.c.
2026         (boolean_option_def, uinteger_option_def)
2027         (value_print_option_defs, make_value_print_options_def_group):
2028         New.  Use gdb::option::add_setshow_cmds_for_options to install
2029         "set print elements", "set print null-stop", "set print repeats",
2030         "set print pretty", "set print union", "set print array", "set
2031         print address", "set print symbol", "set print array-indexes".
2032         * valprint.h: Include <string> and "cli/cli-option.h".
2033         (make_value_print_options_def_group): Declare.
2034         (print_value): Change parameter type from format_data pointer to
2035         value_print_options reference.
2036         (print_command_completer): Declare.
2037
2038 2019-06-13  Pedro Alves  <palves@redhat.com>
2039
2040         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2041         (COMMON_SFILES): Add maint-test-settings.c.
2042         * cli/cli-decode.c (boolean_enums): New global, factored out from
2043         ...
2044         (add_setshow_boolean_cmd): ... here.
2045         * cli/cli-decode.h (boolean_enums): Declare.
2046         * cli/cli-option.c: New file.
2047         * cli/cli-option.h: New file.
2048         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2049         factored out from ...
2050         (parse_cli_boolean_value(const char *)): ... this.
2051         (is_unlimited_literal): Change parameter type to pointer to
2052         pointer.  Adjust and advance ARG pointer.
2053         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2054         (parse_cli_var_enum): New, factored out from ...
2055         (do_set_command): ... this.  Adjust.
2056         * cli/cli-setshow.h (parse_cli_boolean_value)
2057         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2058         (parse_cli_var_enum): Declare.
2059         * cli/cli-utils.c: Include "cli/cli-option.h".
2060         (get_ulongest): New.
2061         * cli/cli-utils.h (get_ulongest): Declare.
2062         (check_for_argument): New overloads.
2063         * maint-test-options.c: New file.
2064
2065 2019-06-13  Pedro Alves  <palves@redhat.com>
2066
2067         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2068         parse a range if "-" is at the end of the string.
2069
2070 2019-06-13  Pedro Alves  <palves@redhat.com>
2071
2072         * cli/cli-setshow.c (parse_auto_binary_operation)
2073         (parse_cli_boolean_value): Don't allow "o".
2074
2075 2019-06-13  Pedro Alves  <palves@redhat.com>
2076
2077         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2078         * NEWS: Mention maint test-settings KIND.
2079         * maint-test-settings.c: New file.
2080
2081 2019-06-13  Pedro Alves  <palves@redhat.com>
2082
2083         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2084         completer.
2085         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2086         "set" completers.
2087
2088 2019-06-13  Pedro Alves  <palves@redhat.com>
2089
2090         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2091         after item.
2092
2093 2019-06-13  Pedro Alves  <palves@redhat.com>
2094
2095         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2096
2097 2019-06-13  Pedro Alves <palves@redhat.com>
2098
2099         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2100         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2101         call.
2102         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2103         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2104         calls.
2105         (check_for_argument): Skip spaces after argument.
2106
2107 2019-06-13  Pedro Alves  <palves@redhat.com>
2108
2109         * thread.c (thread_apply_command): Adjust TID parsing.
2110         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2111         detected before end of string.
2112         (tid_is_in_list): Error out if LIST is invalid.
2113
2114 2019-06-13  Pedro Alves  <palves@redhat.com>
2115
2116         * completer.c (complete_line_internal_1): Rewind completion word
2117         point.
2118         (completion_tracker::advance_custom_word_point_by): Change
2119         parameter type to int.
2120         * completer.h (completion_tracker::advance_custom_word_point_by):
2121         Likewise.
2122
2123 2019-06-13  Pedro Alves  <palves@redhat.com>
2124
2125         * completer.c (advance_to_completion_word): Handle delimiters.
2126
2127 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2128
2129         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2130
2131 2019-06-11  Tom Tromey  <tom@tromey.com>
2132
2133         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2134         (xmalloc_failed): Move to alloc.c.
2135         * alloc.c: New file.
2136         * Makefile.in (COMMON_SFILES): Add alloc.c.
2137
2138 2019-06-11  Tom Tromey  <tom@tromey.com>
2139
2140         * nat/linux-waitpid.c: Don't include server.h.
2141         (linux_debug): Remove.
2142         (my_waitpid): Update.
2143
2144 2019-06-11  Tom Tromey  <tromey@adacore.com>
2145
2146         * infcall.c (_initialize_infcall): Remove trailing newline from
2147         help.
2148         * user-regs.c (_initialize_user_regs): Remove trailing newline
2149         from help.
2150         * typeprint.c (_initialize_typeprint): Remove trailing newline
2151         from help.
2152         * reverse.c (_initialize_reverse): Remove trailing newlines from
2153         help.
2154         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2155         from help.
2156         * language.c (add_set_language_command): Remove trailing newline
2157         from help.
2158         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2159         help.
2160         * disasm.c (_initialize_disasm): Remove trailing newline from
2161         help.
2162         * top.c (init_main): Remove trailing newline from help.
2163         * interps.c (_initialize_interpreter): Remove trailing newline
2164         from help.
2165         * btrace.c (_initialize_btrace): Remove trailing newlines from
2166         help.
2167         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
2168         from help.
2169         * python/python.c (_initialize_python): Remove trailing newline
2170         from help.
2171         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
2172         help.
2173         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
2174         from help.  Reformat some text.
2175         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
2176         from help.
2177         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
2178         newline from help.
2179
2180 2019-06-11  Tom Tromey  <tromey@adacore.com>
2181
2182         * darwin-nat.c (darwin_decode_exception_message)
2183         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
2184
2185 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2186
2187         * valops.c (value_slice): Check for not allocated or not
2188         associated values.
2189
2190 2019-06-10  Tom de Vries  <tdevries@suse.de>
2191
2192         PR gdb/24618
2193         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
2194         sure an empty slot (defined by a 32-bit zero pair) is recognized as
2195         invalid.
2196
2197 2019-06-10  Tom de Vries  <tdevries@suse.de>
2198
2199         PR gdb/24611
2200         * linespec.c (linespec_lexer_lex_string): Remove incorrect
2201         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
2202
2203 2019-06-10  Tom de Vries  <tdevries@suse.de>
2204
2205         PR symtab/24545
2206         * symtab.c (struct demangled_name_entry): Add language field.
2207         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
2208         static minimal symbol".  Set and use language field.
2209
2210 2019-06-10  Tom Tromey  <tromey@adacore.com>
2211
2212         * ada-lang.c (_initialize_ada_language): Update help text.
2213
2214 2019-06-10  Tom Tromey  <tromey@adacore.com>
2215
2216         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
2217         with a newline.
2218         * guile/guile.c (handle_boot_error): Don't end warning with a
2219         newline.
2220         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
2221         warning with a newline.
2222         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
2223         newline.
2224         (s12z_frame_cache): Likewise.
2225         * dwarf-index-cache.c (index_cache::store): Don't end warning with
2226         a newline.
2227         * solib-svr4.c (disable_probes_interface): Don't end warning with
2228         a newline.
2229         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2230         newline.
2231         * python/python.c (do_finish_initialization): Don't end warning
2232         with a newline.
2233
2234 2019-06-10  Tom Tromey  <tom@tromey.com>
2235
2236         * python/py-breakpoint.c (gdbpy_breakpoint_created)
2237         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
2238         gdbpy_enter.
2239
2240 2019-06-10  Tom Tromey  <tromey@adacore.com>
2241
2242         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
2243         data.
2244         (elf_new_init): Don't call stabsread_new_init.
2245         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
2246         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
2247         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
2248
2249 2019-06-10  Tom de Vries  <tdevries@suse.de>
2250
2251         PR symtab/16264
2252         PR symtab/24517
2253         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
2254
2255 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
2256
2257         * source.c (find_and_open_source): Also rewrite relative file
2258         names.
2259
2260 2019-04-26  Amos Bird  <amosbird@gmail.com>
2261
2262         * annotate.c (annotate_thread_exited): Add "thread-exited"
2263         annotation.
2264
2265 2019-06-06  Tom Tromey  <tromey@adacore.com>
2266
2267         * maint.h (class scoped_command_stats): Use
2268         DISABLE_COPY_AND_ASSIGN.
2269         <print_time>: New method.
2270         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
2271         print_time.
2272         (scoped_command_stats::print_time): New method.
2273
2274 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2275
2276         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
2277         instructions of lengths 6 or 8 bytes.
2278
2279 2019-06-04  Pedro Alves  <palves@redhat.com>
2280
2281         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
2282
2283         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
2284         * breakpoint.c (condition_completer): Likewise.
2285         * cli/cli-dump.c (scan_expression): Likewise.
2286         * common/filestuff.c (mkdir_recursive): Likewise.
2287         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
2288         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
2289         (gdb_abspath): Likewise.
2290         * compile/compile-cplus-types.c
2291         (compile_cplus_instance::decl_name): Likewise.
2292         * completer.c (complete_explicit_location):
2293         (signal_completer, reg_or_group_completer_1): Likewise.
2294         * cp-support.c (cp_remove_params_if_any): Likewise.
2295         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
2296         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
2297         * infcmd.c (strip_bg_char): Likewise.
2298         * linespec.c (copy_token_string): Likewise.
2299         * mi/mi-main.c (output_cores): Likewise.
2300         * psymtab.c (psymtab_search_name):
2301         * symfile.c (test_set_ext_lang_command): Likewise.
2302         * target.c (target_fileio_read_stralloc): Likewise.
2303         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
2304         * value.c (complete_internalvar): Likewise.
2305
2306 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
2307
2308         Add objfile property to gdb.Type.
2309         * NEWS: Mention Python API addition.
2310         * python/py-type.c (typy_get_objfile): New method.
2311
2312 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2313
2314         * NEWS: Mention the new set|show style [title|highlight].
2315         Mention changes to "show style", "help" and "apropos".
2316
2317 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2318
2319         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
2320         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
2321         instead of print_help_for_command.
2322         (print_doc_of_command): New function.
2323         (help_list): Add 'apropos -v word' suggestion.
2324         (print_help_for_command): Style the command name using title style.
2325         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
2326         (_initialize_cli_cmds): Describe -v in apropos_command help.
2327
2328 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2329
2330         * cli/cli-style.h (cli_style_option): Add name in constructor,
2331         add m_name class member, add constructor with intensity,
2332         add name class function.
2333         (cli_style_option::add_setshow_commands): Remove name argument.
2334         (highlight_style, title_style): New styles.
2335         * cli/cli-style.c (do_show): New function that shows a style
2336         characteristic styling the style name with itself.
2337         (set_style_name): New function.
2338         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
2339         Update all callers according to the changes in cli/cli-style.h.
2340         * utils.h (fputs_highlighted): New function.
2341         * utils.c (fputs_highlighted): Likewise.
2342
2343 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2344
2345         * NEWS: Mention new pipe command and new convenience variables.
2346
2347 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2348
2349         * cli/cli-cmds.c (pipe_command): New function.
2350         (_initialize_cli_cmds): Call add_com for pipe_command.
2351         Define | as an alias for pipe.
2352         (exit_status_set_internal_vars): New function.
2353         (shell_escape): Call exit_status_set_internal_vars.
2354         cli/cli-decode.c (find_command_name_length): Recognize | as
2355         a single character command.
2356
2357 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2358
2359         * gdbcmd.h (execute_command_to_ui_file): New declaration.
2360         top.c (execute_command_to_ui_file): New function, mostly a copy
2361         of execute_command_to_string.
2362         (execute_command_to_string): Implement by calling
2363         execute_command_to_ui_file.
2364
2365 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2366
2367         * top.h (saved_command_line): Remove declaration.
2368         * top.c (previous_saved_command_line, previous_repeat_arguments):
2369         New variables.
2370         (saved_command_line): Make static, define together with other
2371         'repeat variables'.
2372         (dont_repeat): Clear repeat_arguments.
2373         (repeat_previous, get_saved_command_line, save_command_line):
2374         New functions.
2375         (gdb_init): Initialize saved_command_line
2376         and previous_saved_command_line.
2377         * main.c (captured_main_1): Remove saved_command_line initialization.
2378         * event-top.c (handle_line_of_input): Update to use
2379         the new 'repeat' related functions instead of direct access to
2380         saved_command_line.
2381         * command.h (repeat_previous, get_saved_command_line,
2382         save_command_line): New declarations.
2383         (dont_repeat): Add comment.
2384
2385 2019-05-30  Tom Tromey  <tromey@adacore.com>
2386
2387         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
2388         Fix comment.
2389         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
2390
2391 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
2392
2393         PR cli/24587
2394         * completer.c (complete): Initialize variable word.
2395
2396 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
2397
2398         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2399         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
2400         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
2401         'body' is NULL to the outter 'if', protecting the '!is_define'
2402         situation as well.
2403
2404 2019-05-29  Tom Tromey  <tromey@adacore.com>
2405
2406         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
2407         (dwarf_unknown): New function.
2408         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
2409         (dwarf_type_encoding_name): Use dwarf_unknown.
2410
2411 2019-05-29  Tom Tromey  <tromey@adacore.com>
2412
2413         PR c++/20020:
2414         * cp-valprint.c (cp_print_value_fields): Call
2415         cp_print_static_field inside "try".
2416
2417 2019-05-29  Tom Tromey  <tromey@adacore.com>
2418
2419         * inflow.c (struct terminal_info): Add default operator=.
2420         * configure: Rebuild.
2421         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
2422         -Wdeprecated-copy-dtor, -Wredundant-move.
2423
2424 2019-05-29  Tom Tromey  <tromey@adacore.com>
2425
2426         * NEWS: Add entry.
2427         * infcmd.c (print_return_value_1): Handle finish_print
2428         option.
2429         (show_print_finish): New function.
2430         (_initialize_infcmd): Add "set/show print finish" commands.
2431         * valprint.c (user_print_options): Initialize new member.
2432         * valprint.h (struct value_print_options) <finish_print>: New
2433         member.
2434
2435 2019-05-28  Tom Tromey  <tromey@adacore.com>
2436
2437         * ada-lang.c (ada_remove_Xbn_suffix)
2438         (find_old_style_renaming_symbol)
2439         (parse_old_style_renaming): Remove.
2440         (ada_find_renaming_symbol): Don't call
2441         find_old_style_renaming_symbol.
2442         (ada_is_renaming_symbol): Rename from
2443         ada_find_renaming_symbol.  Remove "block" parameter.  Return
2444         bool.  Now static.
2445         (ada_read_var_value): Update and simplify.
2446         * ada-exp.y (write_var_or_type): Remove old code.
2447
2448 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
2449
2450         * event-top.c: Remove include comment.
2451         * inflow.c (class scoped_ignore_sigttou): Move from here...
2452         * inflow.h (class scoped_ignore_sigttou): ...to here.
2453         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
2454         * top.c:  Remove include comment.
2455
2456 2019-05-27  Tom Tromey  <tom@tromey.com>
2457
2458         * NEWS: Fix typo.
2459
2460 2019-05-22  Tom Tromey  <tromey@adacore.com>
2461
2462         * target.c (target_follow_exec): Constify parameter.
2463         * target-delegates.c: Rebuild.
2464         * remote.c (remote_target::follow_exec): Constify parameter.
2465         * infrun.c (follow_exec): Constify parameter.
2466         * target.h (struct target_ops) <follow_exec>: Constify parameter.
2467         (target_follow_exec): Likewise.
2468
2469 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2470
2471         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
2472         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
2473
2474 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2475
2476         * NEWS: Add debugredirect and testsuite sections.
2477
2478 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
2479
2480         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
2481         target descriptions using exclusively floating point register name
2482         aliases.
2483
2484 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2485
2486         PR gdb/18644:
2487         * f-lang.c (build_fortran_types): Handle the case where
2488         gdbarch_floatformat_for_type returns a nullptr.
2489
2490 2019-05-21  Tom de Vries  <tdevries@suse.de>
2491
2492         PR cli/24587
2493         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
2494
2495 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2496
2497         PR gdb/18644:
2498         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
2499         16-byte floats.
2500         * i386-tdep.c (i386_floatformat_for_type): Use
2501         floatformats_ia64_quad for the 16-byte floating point component
2502         within a fortran 32-byte complex number.
2503
2504 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2505
2506         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
2507         delete default constructor.
2508         (find_partial_die): Update to return const struct.
2509         (partial_die_parent_scope): Move variable declaration into scope
2510         of its use and change its type to auto.
2511         (guess_partial_die_structure_name): Likewise.
2512         (partial_die_info::fixup): Likewise.
2513
2514 2019-05-17  Tom Tromey  <tromey@adacore.com>
2515
2516         * source.c (find_and_open_source): Remove cast.
2517
2518 2019-05-17  Tom Tromey  <tromey@adacore.com>
2519
2520         * annotate.c (annotate_source): Make "filename" const.
2521         * annotate.h (annotate_source): Use const.
2522
2523 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2524
2525         * disasm.c (set_disassembler_options): Send errors to stderr.
2526
2527 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2528
2529         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
2530         (cli_interp_base::set_logging): Check debug_redirect.
2531         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
2532         * cli/cli-logging.c (debug_redirect): Add static variable.
2533         (pop_output_files): Add default param.
2534         (handle_redirections): Print debug setting.
2535         (show_logging_command): Likewise.
2536         (_initialize_cli_logging): Add debugredirect command.
2537         * interps.c (current_interp_set_logging): Add debug_redirect
2538         parameter.
2539         * interps.h (set_logging): Add debug_redirect parameter.
2540         (current_interp_set_logging): Likewise.
2541         * mi/mi-common.h: Likewise.
2542         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
2543
2544 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2545             Tom Tromey  <tromey@adacore.com>
2546
2547         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
2548         directly.
2549         * cli/cli-interp.h (make_logging_output): Remove declaration.
2550         * cli/cli-logging.c (make_logging_output): Remove function.
2551         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
2552         directly.
2553         * ui-file.c (tee_file::tee_file): Remove bools.
2554         (tee_file::~tee_file): Remove deletes.
2555         * ui-file.h (tee_file): Remove bools.
2556
2557 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
2558
2559         * mi/mi-cmds.h (mi_cmd_complete): New function.
2560         * mi/mi-main.c (mi_cmd_complete): Likewise.
2561         * mi/mi-cmds.c: Define new MI command -complete.
2562         * NEWS: Mention new -complete command.
2563
2564 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
2565
2566         * completer.h (complete): New function.
2567         * completer.c (complete): Likewise.
2568         * cli/cli-cmds.c: (complete_command): Update to use new complete()
2569         function defined in completer.h.
2570
2571 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
2572
2573         * MAINTAINERS (Write After Approval): Add myself.
2574
2575 2019-05-17  Tom de Vries  <tdevries@suse.de>
2576
2577         PR gdb/24094
2578         * dwarf2read.c (struct cu_partial_die_info): New struct.
2579         (find_partial_die): Return cu_partial_die_info.
2580         (partial_die_parent_scope, guess_partial_die_structure_name)
2581         (partial_die_info::fixup): Handle new return type of find_partial_die.
2582
2583 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2584
2585         * stap-probe.c (stap_parse_register_operand): Make "regname" an
2586         "std::string", simplifying the algorithm.
2587
2588 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2589
2590         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
2591         (stap_static_probe_ops::get_probes): Likewise.
2592
2593 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2594
2595         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
2596         '-')" and "else if".
2597         (stap_parse_single_operand): Join checks for
2598         "gdbarch_stap_parse_special_token_p" and
2599         "gdbarch_stap_parse_special_token" in the same "if" statement.
2600         Invert check when verifying for operation on register
2601         displacement.
2602
2603 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2604
2605         * stap-probe.c (stap_get_opcode): Update comment.
2606         (stap_get_expected_argument_type): Likewise.
2607         (handle_stap_probe): Likewise.
2608
2609 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2610
2611         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
2612         return type to 'bool'.  Adjust comment.  Use 'bool' when
2613         appropriate.
2614         (i386_stap_parse_special_token_three_arg_disp): Likewise.
2615         * stap-probe.c (stap_parse_argument_1): Likewise.
2616         (stap_is_operator): Likewise.
2617         (stap_is_generic_prefix): Likewise.
2618         (stap_is_register_prefix): Likewise.
2619         (stap_is_register_indirection_prefix): Likewise.
2620         (stap_is_integer_prefix): Likewise.
2621         (stap_generic_check_suffix): Likewise.
2622         (stap_check_integer_suffix): Likewise.
2623         (stap_check_register_suffix): Likewise.
2624         (stap_check_register_indirection_suffix): Likewise.
2625         (stap_parse_register_operand): Likewise.
2626         (stap_parse_single_operand): Likewise.
2627         (stap_parse_argument_1): Likewise.
2628         (stap_probe::get_argument_count): Likewise.
2629         (stap_is_operator): Likewise.
2630
2631 2019-05-16  Tom Tromey  <tromey@adacore.com>
2632
2633         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
2634         keyword to foreach.
2635
2636 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
2637
2638         * linux-thread-db.c (try_thread_db_load_1): Change return type
2639         to bool.
2640         (try_thread_db_load): Likewise.
2641         (try_thread_db_load_from_pdir_1): Likewise.
2642         (try_thread_db_load_from_pdir): Likewise.
2643         (try_thread_db_load_from_sdir): Likewise.
2644         (try_thread_db_load_from_dir): Likewise.
2645         (thread_db_load_search): Likewise.
2646         (has_libpthread): Likewise.
2647         (thread_db_load): Likewise.
2648
2649 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
2650
2651         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2652         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
2653         NULL, and complain/return if that's the case.
2654
2655 2019-05-15  John Darrington <john@darrington.wattle.id.au>
2656
2657         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
2658         (advance, posn, abstract_read_memory): New functions.
2659         [struct mem_read_abstraction]: New struct.
2660         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
2661
2662 2019-05-14  Tom Tromey  <tromey@adacore.com>
2663
2664         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
2665         value is not lval_memory.
2666
2667 2019-05-14  Tom Tromey  <tromey@adacore.com>
2668
2669         * solib.c (info_sharedlibrary_command): Style the file name.
2670
2671 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
2672
2673         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
2674         (aarch64_vnv_type): Likewise.
2675         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
2676         * common/tdesc.c: Likewise.
2677         * common/tdesc.h (enum tdesc_type_kind): Likewise.
2678         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
2679         * features/aarch64-fpu.xml: Add ieee half view.
2680         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
2681         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
2682         * gdbtypes.h (struct builtin_type): Likewise.
2683         (struct objfile_type): Likewise.
2684
2685 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
2686
2687         * language.c (language_sniff_from_mangled_name): Fix "langauge"
2688         typo.
2689         * location.h (string_to_event_location): Likewise.
2690
2691 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
2692
2693         GDB 8.3 released.
2694
2695 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2696
2697         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
2698         New variable declaration.
2699         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
2700         New variable.
2701         (print_one_breakpoint): Use ui_out::test_flags and new global
2702         variable to compute use_fixed_output.
2703         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
2704         Remove.
2705         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
2706         (mi_multi_location_breakpoint_output_fixed): Remove.
2707         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
2708         new variable.
2709         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
2710         fix_multi_location_breakpoint_output flag if version >= 3.
2711         * ui-out.h (enum ui_out_flag)
2712         <fix_multi_location_breakpoint_output>: New enumerator.
2713
2714 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2715
2716         * contrib/cc-with-tweaks.sh: Validate dwz's work.
2717
2718 2019-05-10  Tom Tromey  <tromey@adacore.com>
2719
2720         * ada-lang.c (catch_ada_completer): New function.
2721         (_initialize_ada_language): Use it.
2722
2723 2019-05-10  Tom Tromey  <tromey@adacore.com>
2724
2725         * thread.c (print_thread_info): Make "requested_threads" const.
2726         * gdbthread.h (print_thread_info): Make "requested_threads"
2727         const.
2728         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
2729         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
2730
2731 2019-05-08  Tom Tromey  <tom@tromey.com>
2732
2733         * gdbtypes.c (objfile_type_data): Change type.
2734         (objfile_type, _initialize_gdbtypes): Update.
2735
2736 2019-05-08  Tom Tromey  <tom@tromey.com>
2737
2738         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
2739         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
2740         (_initialize_dwarf2_frame): Update.
2741
2742 2019-05-08  Tom Tromey  <tom@tromey.com>
2743
2744         * objc-lang.c (objc_objfile_data): Change type.
2745         (find_methods): Update.
2746         (_initialize_objc_lang): Remove.
2747
2748 2019-05-08  Tom Tromey  <tom@tromey.com>
2749
2750         * stabsread.c (rs6000_builtin_type_data): Change type.
2751         (rs6000_builtin_type, _initialize_stabsread): Update.
2752
2753 2019-05-08  Tom Tromey  <tom@tromey.com>
2754
2755         * mips-tdep.c (mips_pdr_data): Remove.
2756         (_initialize_mips_tdep): Update.
2757
2758 2019-05-08  Tom Tromey  <tom@tromey.com>
2759
2760         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
2761         (hppa_init_objfile_priv_data, read_unwind_info)
2762         (find_unwind_entry, _initialize_hppa_tdep): Update.
2763
2764 2019-05-08  Tom Tromey  <tom@tromey.com>
2765
2766         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
2767         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
2768         on obstack.
2769         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
2770
2771 2019-05-08  Tom Tromey  <tom@tromey.com>
2772
2773         * mdebugread.c (basic_type_data): Change type.
2774         (basic_type, _initialize_mdebugread): Update.
2775
2776 2019-05-08  Tom Tromey  <tom@tromey.com>
2777
2778         * common/gdb_unique_ptr.h (struct noop_deleter): New.
2779
2780 2019-05-08  Tom Tromey  <tom@tromey.com>
2781
2782         * nto-tdep.c (nto_inferior_data_reg): Change type.
2783         (nto_inferior_data): Update.
2784         (nto_inferior_data_cleanup, nto_new_inferior_data)
2785         (_initialize_nto_tdep): Remove.
2786         * nto-tdep.h (struct nto_inferior_data): Add initializers.
2787
2788 2019-05-08  Tom Tromey  <tom@tromey.com>
2789
2790         * ada-lang.c (struct ada_inferior_data): Add initializers.
2791         (ada_inferior_data): Change type.
2792         (ada_inferior_data_cleanup): Remove.
2793         (get_ada_inferior_data, ada_inferior_exit)
2794         (struct ada_pspace_data): Add initializers, destructor.
2795         (ada_pspace_data_handle): Change type.
2796         (get_ada_pspace_data): Update.
2797         (ada_pspace_data_cleanup): Remove.
2798
2799 2019-05-08  Tom Tromey  <tom@tromey.com>
2800
2801         * coffread.c (struct coff_symfile_info): Add initializers.
2802         (coff_objfile_data_key): Move lower.  Change type.
2803         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
2804         Update.
2805         (coff_free_info): Remove.
2806
2807 2019-05-08  Tom Tromey  <tom@tromey.com>
2808
2809         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
2810         (fbsd_pspace_data_handle): Move lower.  Change type.
2811         (get_fbsd_pspace_data): Update.
2812         (fbsd_pspace_data_cleanup): Remove.
2813         (_initialize_fbsd_tdep): Update.
2814
2815 2019-05-08  Tom Tromey  <tom@tromey.com>
2816
2817         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
2818         (get_ada_tasks_pspace_data): Update.
2819         (ada_tasks_pspace_data_cleanup): Remove.
2820         (_initialize_tasks): Update.
2821         (ada_tasks_inferior_data_handle): Change type.
2822         (get_ada_tasks_inferior_data): Update.
2823         (ada_tasks_inferior_data_cleanup): Remove.
2824         (struct ada_tasks_pspace_data): Add initializers.
2825
2826 2019-05-08  Tom Tromey  <tom@tromey.com>
2827
2828         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
2829         * symfile-debug.c (debug_sym_get_probes): Change type.
2830         * stap-probe.c (handle_stap_probe):
2831         (stap_static_probe_ops::get_probes): Change type.
2832         * probe.h (class static_probe_ops) <get_probes>: Change type.
2833         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
2834         (parse_probes_in_pspace): Update.
2835         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
2836         Update.
2837         (any_static_probe_ops::get_probes): Change type.
2838         * elfread.c (elfread_data): New typedef.
2839         (probe_key): Change type.
2840         (elf_get_probes): Likewise.  Update.
2841         (probe_key_free): Remove.
2842         (_initialize_elfread): Update.
2843         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
2844         Change type.
2845         (dtrace_process_dof_probe, dtrace_process_dof)
2846         (dtrace_static_probe_ops::get_probe): Change type.
2847
2848 2019-05-08  Tom Tromey  <tom@tromey.com>
2849
2850         * xcoffread.c (struct xcoff_symfile_info): Rename from
2851         coff_symfile_info.  Add initializers.
2852         (xcoff_objfile_data_key): Move lower.  Change type.
2853         (XCOFF_DATA): Rewrite.
2854         (xcoff_free_info): Remove.
2855         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
2856         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
2857         (xcoff_initial_scan): Update.
2858
2859 2019-05-08  Tom Tromey  <tom@tromey.com>
2860
2861         * solib-svr4.c (struct svr4_info): Add initializers and
2862         destructor.
2863         <probes_table>: Now an htab_up.
2864         (solib_svr4_pspace_data): Change type.
2865         (free_probes_table): Simplify.
2866         (~svr4_info): Rename from svr4_pspace_data_cleanup.
2867         (get_svr4_info, probes_table_htab_remove_objfile_probes)
2868         (probes_table_remove_objfile_probes, register_solib_event_probe)
2869         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
2870         (_initialize_svr4_solib): Update.
2871
2872 2019-05-08  Tom Tromey  <tom@tromey.com>
2873
2874         * remote.c (remote_pspace_data): Change type.
2875         (remote_pspace_data_cleanup): Remove.
2876         (get_remote_exec_file, set_pspace_remote_exec_file)
2877         (_initialize_remote): Update.
2878
2879 2019-05-08  Tom Tromey  <tom@tromey.com>
2880
2881         * breakpoint.c (breakpoint_objfile_key): Change type.
2882         (get_breakpoint_objfile_data): Update.
2883         (free_breakpoint_objfile_data): Remove.
2884         (_initialize_breakpoint): Update.
2885
2886 2019-05-08  Tom Tromey  <tom@tromey.com>
2887
2888         * linux-tdep.c (struct linux_info): Add initializers.
2889         (linux_inferior_data): Move.  Change type.
2890         (invalidate_linux_cache_inf): Update.
2891         (linux_inferior_data_cleanup): Remove.
2892         (get_linux_inferior_data, _initialize_linux_tdep): Update.
2893
2894 2019-05-08  Tom Tromey  <tom@tromey.com>
2895
2896         * auxv.c (auxv_inferior_data): Move.  Change type.
2897         (auxv_inferior_data_cleanup): Remove.
2898         (invalidate_auxv_cache_inf): Rewrite.
2899         (get_auxv_inferior_data, _initialize_auxv): Update.
2900
2901 2019-05-08  Tom Tromey  <tom@tromey.com>
2902
2903         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
2904         (symfile_debug_objfile_data_key): Change type.
2905         (symfile_debug_installed, debug_qf_has_symbols)
2906         (debug_qf_find_last_source_symtab)
2907         (debug_qf_forget_cached_source_info)
2908         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
2909         (debug_qf_print_stats, debug_qf_dump)
2910         (debug_qf_expand_symtabs_for_function)
2911         (debug_qf_expand_all_symtabs)
2912         (debug_qf_expand_symtabs_with_fullname)
2913         (debug_qf_map_matching_symbols)
2914         (debug_qf_expand_symtabs_matching)
2915         (debug_qf_find_pc_sect_compunit_symtab)
2916         (debug_qf_map_symbol_filenames)
2917         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
2918         (debug_sym_new_init, debug_sym_init, debug_sym_read)
2919         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
2920         (debug_sym_read_linetable, debug_sym_relocate): Update.
2921         (symfile_debug_free_objfile): Remove.
2922         (install_symfile_debug_logging, _initialize_symfile_debug):
2923         Update.
2924
2925 2019-05-08  Tom Tromey  <tom@tromey.com>
2926
2927         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
2928         allocate_on_obstack.
2929         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
2930         (get_dwarf2_per_objfile): Update.
2931         (set_dwarf2_per_objfile): Remove.
2932         (dwarf2_has_info, dwarf2_get_section_info): Update.
2933         (dwarf2_free_objfile): Remove.
2934         (_initialize_dwarf2_read): Update.
2935
2936 2019-05-08  Tom Tromey  <tom@tromey.com>
2937
2938         * auto-load.c (struct auto_load_pspace_info): Add destructor and
2939         initializers.
2940         <unsupported_script_warning_printed,
2941         script_not_found_warning_printed>: Now bool.
2942         (auto_load_pspace_data): Change type.
2943         (~auto_load_pspace_info): Rename from
2944         auto_load_pspace_data_cleanup.
2945         (get_auto_load_pspace_data, init_loaded_scripts_info)
2946         (clear_section_scripts, maybe_print_unsupported_script_warning)
2947         (maybe_print_script_not_found_warning, _initialize_auto_load):
2948         Update.
2949
2950 2019-05-08  Tom Tromey  <tom@tromey.com>
2951
2952         * objfiles.c (objfile_pspace_info): Add destructor and
2953         initializers.
2954         (objfiles_pspace_data): Change type.
2955         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
2956         (get_objfile_pspace_data): Update.
2957         (objfiles_bfd_data): Change type.
2958         (get_objfile_bfd_data): Update.
2959         (objfile_bfd_data_free, _initialize_objfiles): Remove.
2960
2961 2019-05-08  Tom Tromey  <tom@tromey.com>
2962
2963         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
2964         Change type.
2965         (get_catch_syscall_inferior_data): Update.
2966         (catch_syscall_inferior_data_cleanup): Remove.
2967         (_initialize_break_catch_syscall): Update.
2968
2969 2019-05-08  Tom Tromey  <tom@tromey.com>
2970
2971         * inflow.c (struct terminal_info): Add destructor and
2972         initializers.
2973         (inflow_inferior_data): Change type.
2974         (~terminal_info): Rename from inflow_inferior_data_cleanup.
2975         (get_inflow_inferior_data, inflow_inferior_exit)
2976         (swap_terminal_info, _initialize_inflow): Update.
2977
2978 2019-05-08  Tom Tromey  <tom@tromey.com>
2979
2980         * target-dcache.c (target_dcache_cleanup): Remove.
2981         (target_dcache_aspace_key): Change type.
2982         (target_dcache_init_p, target_dcache_invalidate)
2983         (target_dcache_get, target_dcache_get_or_init)
2984         (_initialize_target_dcache): Update.
2985         * dcache.h (struct dcache_deleter): New.
2986
2987 2019-05-08  Tom Tromey  <tom@tromey.com>
2988
2989         * symtab.c (struct symbol_cache): Add destructor and
2990         initializers.
2991         (symbol_cache_key): Move.  Change type.
2992         (make_symbol_cache, free_symbol_cache): Remove.
2993         (get_symbol_cache): Update.
2994         (symbol_cache_cleanup): Remove.
2995         (ALL_PSPACES, symbol_cache_flush)
2996         (maintenance_print_symbol_cache)
2997         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
2998         Update.
2999
3000 2019-05-08  Tom Tromey  <tom@tromey.com>
3001
3002         * symtab.c (struct main_info): Add destructor and initializers.
3003         (main_progspace_key): Move.  Change type.
3004         (get_main_info): Update.
3005         (main_info_cleanup): Remove.
3006         (_initialize_symtab): Update.
3007
3008 2019-05-08  Tom Tromey  <tom@tromey.com>
3009
3010         * registry.h (DECLARE_REGISTRY): Define the _key class.
3011
3012 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3013
3014         * NEWS: Merge two 'New commands' sections.
3015
3016 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3017
3018         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3019         parameter and use Ada language definition instead.
3020         (ada_val_print_ptr): Remove unused language parameter.
3021         (ada_val_print_num): Remove language parameter and use Ada language
3022         definition instead.
3023         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3024         parameter.
3025         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3026         parameter and use Ada language definition instead.
3027         (ada_val_print_1): Update all ada_val_print_xxx calls.
3028         Remove language parameter.
3029         (ada_val_print): Update ada_val_print_1 call.
3030
3031 2019-05-08  Tom Tromey  <tromey@adacore.com>
3032
3033         * remote.c (remote_hw_watchpoint_limit)
3034         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3035         Now static.
3036
3037 2019-05-08  Tom Tromey  <tromey@adacore.com>
3038
3039         * maint.c (_initialize_maint_cmds): Move initialization code to
3040         remote.c.
3041         (watchdog, show_watchdog): Move to remote.c.
3042         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3043         "watchdog" static.
3044         (_initialize_remote): Move initialization code from maint.c.
3045         * defs.h (watchdog): Don't declare.
3046
3047 2019-05-08  Tom Tromey  <tromey@adacore.com>
3048
3049         * tui/tui-interp.c: Include main.h.
3050         * interps.c: Include main.h.
3051         * main.h (interpreter_p): Declare.
3052         * defs.h (interpreter_p): Don't declare.
3053
3054 2019-05-08  Tom Tromey  <tromey@adacore.com>
3055
3056         * dwarf2loc.c: Include dwarf2read.h.
3057         * defs.h (read_unsigned_leb128): Don't declare.
3058         * dwarf2read.h (read_unsigned_leb128): Declare.
3059
3060 2019-05-08  Tom Tromey  <tromey@adacore.com>
3061
3062         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3063         method.
3064
3065 2019-05-08  Tom Tromey  <tromey@adacore.com>
3066
3067         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3068         when no wrap column is set.
3069
3070 2019-05-08  Tom Tromey  <tromey@adacore.com>
3071
3072         * c-lang.c (c_get_string): Handle non-C-style arrays.
3073
3074 2019-05-08  Tom Tromey  <tromey@adacore.com>
3075
3076         * typeprint.c (print_offset_data::update): Print the bit offset,
3077         not the number of bits remaining.
3078
3079 2019-05-08  Tom Tromey  <tromey@adacore.com>
3080
3081         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3082         padding at end of comment.
3083
3084 2019-05-08  Tom Tromey  <tromey@adacore.com>
3085
3086         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3087         Compare main types.
3088
3089 2019-05-06  Tom Tromey  <tom@tromey.com>
3090
3091         * common/scoped_mmap.c: Include common-defs.h.
3092         * common/scoped_mmap.h: Don't include config.h.
3093
3094 2019-05-04  Tom Tromey  <tom@tromey.com>
3095
3096         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3097         (struct aarch64_call_info): Add initializers.
3098         <si>: Now a std::vector.
3099         (pass_on_stack, aarch64_push_dummy_call): Update.
3100
3101 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3102             Tom Tromey  <tom@tromey.com>
3103
3104         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3105         (ppc_threads): Now a std::vector.  Now static.
3106         (hwdebug_find_thread_points_by_tid)
3107         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3108         Update.
3109
3110 2019-05-04  Tom Tromey  <tom@tromey.com>
3111
3112         * arc-tdep.c (arc_tdesc_init): Return bool.
3113
3114 2019-05-04  Tom Tromey  <tom@tromey.com>
3115
3116         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3117         Use gdb_assert_not_reached.
3118
3119 2019-05-04  Tom Tromey  <tom@tromey.com>
3120
3121         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3122         "false".
3123
3124 2019-05-04  Tom Tromey  <tom@tromey.com>
3125
3126         * arc-tdep.c (arc_tdesc_init): Use bool.
3127
3128 2019-05-04  Tom Tromey  <tom@tromey.com>
3129
3130         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3131
3132 2019-05-04  Tom Tromey  <tom@tromey.com>
3133
3134         * cli/cli-cmds.c (valid_command_p): Return bool.
3135
3136 2019-05-04  Tom Tromey  <tom@tromey.com>
3137
3138         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3139         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3140
3141 2019-05-04  Raul Tambre  <raul@tambre.ee>
3142
3143         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3144         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3145         operator for comparison.
3146
3147 2019-05-04  Tom Tromey  <tom@tromey.com>
3148
3149         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3150         (lookup_partial_symbol, print_partial_symbols)
3151         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3152         (psymbol_compare): Update.
3153         (add_psymbol_to_bcache): Clear the entire psymbol.
3154         (maintenance_check_psymtabs): Update.
3155         * psympriv.h (struct partial_symbol): Don't derive from
3156         general_symbol_info.
3157         <obj_section, unrelocated_address, address,
3158         set_unrelocated_address>: Update.
3159         <ginfo>: New member.
3160         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3161         (debug_names::write_psymbols): Update.
3162
3163 2019-05-04  Tom de Vries  <tdevries@suse.de>
3164
3165         * contrib/cc-with-tweaks.sh: Support -n arg.
3166
3167 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3168
3169         * corelow.c (core_target::detach): Ensure frame cache and
3170         register caches are cleared.
3171         inferior.c (exit_inferior_1): Likewise.
3172
3173 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
3174             Tom Tromey  <tom@tromey.com>
3175
3176         * dictionary.c (collate_pending_symbols_by_language): Remove
3177         "struct" from foreach.
3178         * symtab.c (lookup_global_symbol_from_objfile)
3179         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
3180         foreach.
3181         * ser-tcp.c (net_open): Remove "struct" from foreach.
3182         * objfiles.c (objfile_relocate, objfile_rebase)
3183         (objfile_has_symbols): Remove "struct" from foreach.
3184         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
3185         from foreach.
3186         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
3187         foreach.
3188         * darwin-nat.c (thread_info_from_private_thread_info): Remove
3189         "struct" from foreach.
3190         * ada-lang.c (create_excep_cond_exprs)
3191         (ada_exception_catchpoint_cond_string): Remove "struct" from
3192         foreach.
3193
3194 2019-05-03  Tom Tromey  <tromey@adacore.com>
3195
3196         * ada-exp.y (convert_char_literal): Check suffix of each
3197         enumerator.
3198
3199 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
3200
3201         PR ada/21406:
3202         * ada-exp.y (yywrap): Don't define.
3203         * ada-lex.l (%option): Add noyywrap
3204         (yywrap): Remove.
3205
3206 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
3207
3208         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
3209         _WIN32_WINNT to the XP level, unless already defined to a higher
3210         level.
3211
3212         * unittests/parse-connection-spec-selftests.c:
3213         * ser-tcp.c:
3214         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
3215         override.
3216
3217         * symfile.c (find_separate_debug_file): Remove colon from the
3218         drive spec of DOS/Windows file names of the target, so that the
3219         file name produced from DEBUGDIR and the target's directory will
3220         be valid on DOS/Windows systems.
3221
3222 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3223
3224         * rust-lang.c (val_print_struct): Handle printing structures
3225         containing strings.
3226
3227 2019-05-02  Tom Tromey  <tromey@adacore.com>
3228
3229         * valarith.c (_initialize_valarith): Remove.
3230
3231 2019-05-01  Tom Tromey  <tromey@adacore.com>
3232
3233         * ada-lang.c (ada_value_primitive_field): Treat more fields as
3234         bitfields.
3235
3236 2019-05-01  Tom Tromey  <tromey@adacore.com>
3237
3238         * ada-lang.c (ada_value_assign): Correctly compute starting offset
3239         for big-endian copies.
3240
3241 2019-04-30  Ali Tamur  <tamur@google.com>
3242         * gdb/dwarf2read.c (read_3_bytes): New declaration.
3243         (read_attribute_value): Added DW_FORM_strx1-4 cases.
3244         (read_3_bytes): New function.
3245
3246 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3247
3248         * windows-nat.c (main_thread_id): Delete.
3249         (handle_output_debug_string): Replace main_thread_id by
3250         current_event.dwThreadId.
3251         (fake_create_process): Likewise.
3252         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
3253         Do not set main_thread_id.
3254         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
3255         current_event.dwThreadId.
3256         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
3257
3258 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3259
3260         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
3261         Use current_event.dwThreadId instead of main_thread_id.
3262
3263 2019-04-30  Tom Tromey  <tromey@adacore.com>
3264
3265         * ada-lang.c (ada_lookup_simple_minsyms): New function.
3266         (create_excep_cond_exprs): Iterate over program spaces.
3267         (ada_exception_catchpoint_cond_string): Examine all minimal
3268         symbols for exception types.
3269
3270 2019-04-30  Tom Tromey  <tromey@adacore.com>
3271
3272         PR c++/24470:
3273         * dwarf2read.c (process_structure_scope): Handle case where type
3274         has template parameters but no symbol was created.
3275
3276 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3277             Chris January  <chris.january@arm.com>
3278
3279         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
3280         qualifier.
3281         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
3282
3283 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3284
3285         * f-typeprint.c (f_print_type): Update rules for printing
3286         whitespace.
3287         (f_type_print_varspec_suffix): Likewise.
3288
3289 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3290             Chris January  <chris.january@arm.com>
3291
3292         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
3293         function arguments.
3294
3295 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3296
3297         * f-lang.c (build_fortran_types): Change name of void type to
3298         lower case.
3299         * f-typeprint.c (f_type_print_base): Print the name of the void
3300         type, rather than a fixed string.
3301         * f-valprint.c (f_decorations): Use lower case void string.
3302
3303 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3304             Chris January  <chris.january@arm.com>
3305
3306         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
3307         types for Fortran.
3308
3309 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3310             Chris January  <chris.january@arm.com>
3311             David Lecomber  <david.lecomber@arm.com>
3312
3313         * f-exp.y (BINOP_INTRINSIC): New token.
3314         (exp): New parser rule handling BINOP_INTRINSIC.
3315         (f77_keywords): Add new builtin procedures.
3316         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
3317         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3318         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
3319         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3320         (print_unop_subexp_f): New function.
3321         (print_binop_subexp_f): New function.
3322         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3323         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3324         (dump_subexp_body_f): Likewise.
3325         (operator_check_f): Likewise.
3326         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3327         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
3328
3329 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3330
3331         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
3332         UNOP_KIND.
3333         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
3334         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
3335         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
3336         (operator_length_f): New fuction.
3337         (print_subexp_f): New function.
3338         (op_name_f): New function.
3339         (dump_subexp_body_f): New function.
3340         (operator_check_f): New function.
3341         (exp_descriptor_f): Replace standard expression handling functions
3342         with new functions.
3343         * gdb/fortran-operator.def: New file.
3344         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
3345         * gdb/std-operator.def: Remove UNOP_KIND.
3346
3347 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3348
3349         * std-operator.def: Remove unbalanced, stray double quote
3350         character.
3351
3352 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3353             Chris January  <chris.january@arm.com>
3354             Daniel Everett  <daniel.everett@arm.com>
3355             Nick Forrington  <nick.forrington@arm.com>
3356             Richard Bunt  <richard.bunt@arm.com>
3357
3358         * cp-valprint.c (cp_print_value_fields): Allow an additional level
3359         of depth when printing anonymous structs or unions.
3360         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
3361         Don't print either the top-level value, or the children if the
3362         max-depth is exceeded.
3363         (ppscm_print_children): When printing the key of a map, allow one
3364         extra level of depth.
3365         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
3366         print either the top-level value, or the children if the max-depth
3367         is exceeded.
3368         (print_children): When printing the key of a map, allow one extra
3369         level of depth.
3370         * python/py-value.c (valpy_format_string): Add max_depth keyword.
3371         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
3372         (user_print_options): Initialise max_depth field.
3373         (val_print_scalar_or_string_type_p): New function.
3374         (val_print): Check to see if the max depth has been reached.
3375         (val_print_check_max_depth): Define new function.
3376         (show_print_max_depth): New function.
3377         (_initialize_valprint): Add 'print max-depth' option.
3378         * valprint.h (struct value_print_options) <max_depth>: New field.
3379         (val_print_check_max_depth): Declare new function.
3380         * NEWS: Document new feature.
3381
3382 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3383
3384         * ada-lang.c (ada_language_defn): Initialise new field.
3385         * c-lang.c (c_is_string_type_p): New function.
3386         (c_language_defn): Initialise new field.
3387         (cplus_language_defn): Initialise new field.
3388         (asm_language_defn): Initialise new field.
3389         (minimal_language_defn): Initialise new field.
3390         * c-lang.h (c_is_string_type_p): Declare new function.
3391         * d-lang.c (d_language_defn): Initialise new field.
3392         * f-lang.c (f_is_string_type_p): New function.
3393         (f_language_defn): Initialise new field.
3394         * go-lang.c (go_is_string_type_p): New function.
3395         (go_language_defn): Initialise new field.
3396         * language.c (default_is_string_type_p): New function.
3397         (unknown_language_defn): Initialise new field.
3398         (auto_language_defn): Initialise new field.
3399         * language.h (struct language_defn) <la_is_string_type_p>: New
3400         member variable.
3401         (default_is_string_type_p): Declare new function.
3402         * m2-lang.c (m2_language_defn): Initialise new field.
3403         * objc-lang.c (objc_language_defn): Initialise new field.
3404         * opencl-lang.c (opencl_language_defn): Initialise new field.
3405         * p-lang.c (pascal_is_string_type_p): New function.
3406         (pascal_language_defn): Initialise new field.
3407         * rust-lang.c (rust_is_string_type_p): New function.
3408         (rust_language_defn): Initialise new field.
3409
3410 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3411
3412         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
3413         New field.
3414         * ada-lang.c (ada_language_defn): Initialise new field.
3415         * c-lang.c (c_language_defn): Likewise.
3416         (cplus_language_defn): Likewise.
3417         (asm_language_defn): Likewise.
3418         (minimal_language_defn): Likewise.
3419         * d-lang.c (d_language_defn): Likewise.
3420         * f-lang.c (f_language_defn): Likewise.
3421         * go-lang.c (go_language_defn): Likewise.
3422         * language.c (unknown_language_defn): Likewise.
3423         (auto_language_defn): Likewise.
3424         * m2-lang.c (m2_language_defn): Likewise.
3425         * objc-lang.c (objc_language_defn): Likewise.
3426         * opencl-lang.c (opencl_language_defn): Likewise.
3427         * p-lang.c (pascal_language_defn): Likewise.
3428         * rust-lang.c (rust_language_defn): Likewise.
3429
3430 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3431
3432         * ada-lang.c (ada_is_character_type): Change return type to bool.
3433         (ada_is_string_type): Likewise.
3434         * ada-lang.h (ada_is_character_type): Update declaration
3435         (ada_is_string_type): Likewise.
3436
3437 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3438
3439         Support style in 'frame|thread apply'
3440
3441         * gdbcmd.h (execute_command_to_string): New term_out parameter.
3442         * record.c (record_start, record_stop): Update callers of
3443         execute_command_to_string with false.
3444         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
3445         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
3446         methods.
3447         (class string_file): New constructor with term_out parameter.
3448         Override methods term_out and can_emit_style_escape.  New member
3449         term_out.
3450         (class stdio_file): Override can_emit_style_escape.
3451         (class tee_file): Override term_out and can_emit_style_escape.
3452         * utils.h (can_emit_style_escape): Remove.
3453         * utils.c (can_emit_style_escape): Likewise.
3454         Update all callers of can_emit_style_escape (SOMESTREAM) to
3455         SOMESTREAM->can_emit_style_escape.
3456         * source-cache.c (source_cache::get_source_lines): Likewise.
3457         * stack.c (frame_apply_command_count): Call execute_command_to_string
3458         passing the term_out characteristic of the current gdb_stdout.
3459         * thread.c (thr_try_catch_cmd): Likewise.
3460         * top.c (execute_command_to_string): pass term_out parameter
3461         to construct the string_file for the command output.
3462         * ui-file.c (term_cli_styling): New function (most code moved
3463         from utils.c can_emit_style_escape).
3464         (string_file::string_file, string_file::can_emit_style_escape,
3465         stdio_file::can_emit_style_escape, tee_file::term_out,
3466         tee_file::can_emit_style_escape): New functions.
3467
3468 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3469
3470         * NEWS: Mention the new set|show may-call-functions.
3471         * infcall.c (may_call_functions_p): New variable.
3472         (show_may_call_functions_p): New function.
3473         (call_function_by_hand_dummy): Throws an error if not
3474         may-call-functions.
3475         (_initialize_infcall): Call add_setshow_boolean_cmd for
3476         may-call-functions.
3477
3478 2019-04-25  Keith Seitz  <keiths@redhat.com>
3479
3480         PR c++/24367
3481         * cp-support.c (inspect_type): Don't attempt substitutions
3482         of symbol with the same name.
3483
3484 2019-04-25  Tom Tromey  <tromey@adacore.com>
3485
3486         PR gdb/24475:
3487         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
3488         static.
3489
3490 2019-04-25  Tom Tromey  <tromey@adacore.com>
3491
3492         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
3493         rvalue reference.
3494         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
3495         (gdb_xml_parser::parse): Use std::move.
3496         * python/python-internal.h (gdbpy_convert_exception): Take a const
3497         reference.
3498         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
3499         std::move.
3500         * python/py-utils.c (gdbpy_convert_exception): Take a const
3501         reference.
3502         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3503         Use std::move.
3504         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3505         Use std::move.
3506         * mi/mi-main.c (mi_print_exception): Take a const reference.
3507         * main.c (handle_command_errors): Take a const reference.
3508         * linespec.c (parse_linespec): Use std::move.
3509         * infcall.c (run_inferior_call): Use std::move.
3510         (call_function_by_hand_dummy): Use std::move.
3511         * exec.c (try_open_exec_file): Use std::move.
3512         * exceptions.h (exception_print, exception_fprintf)
3513         (exception_print_same): Update.
3514         * exceptions.c (print_exception, exception_print)
3515         (exception_fprintf, exception_print_same): Change parameters to
3516         const reference.
3517         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
3518         * common/new-op.c: Use std::move.
3519         * common/common-exceptions.h (struct gdb_exception): Add move
3520         constructor.
3521         (struct gdb_exception_error, struct gdb_exception_quit, struct
3522         gdb_quit_bad_alloc): Change constructor to move constructor.
3523         (throw_exception): Change parameter to rvalue reference.
3524         * common/common-exceptions.c (throw_exception): Take rvalue
3525         reference.
3526         * cli/cli-interp.c (safe_execute_command): Use std::move.
3527         * breakpoint.c (insert_bp_location, location_to_sals): Use
3528         std::move.
3529
3530 2019-04-25  Tom Tromey  <tromey@adacore.com>
3531
3532         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
3533         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
3534         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
3535         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
3536         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
3537         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
3538         guile/scm-value.c: Use unpack.
3539         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
3540         gdbscm_gdb_exception.
3541         (gdbscm_throw_gdb_exception): Likewise.
3542         (struct gdbscm_gdb_exception): New.
3543         (unpack): New function.
3544         (gdbscm_wrap): Use unpack.
3545
3546 2019-04-25  Tom Tromey  <tromey@adacore.com>
3547
3548         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3549         (gdb_rl_callback_handler): Use std::move.
3550         * common/common-exceptions.h (struct gdb_exception): Add move
3551         assignment operator.
3552         (throw_exception_sjlj): Change "exception" to const reference.
3553         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
3554         (throw_exception_sjlj): Change "exception" to const reference.
3555
3556 2019-04-25  Tom Tromey  <tromey@adacore.com>
3557
3558         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
3559         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
3560         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3561         Update.
3562         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3563         Update.
3564         * mi/mi-interp.c (mi_interp::exec): Update.
3565         * linespec.c (parse_linespec): Update.
3566         * infcall.c (run_inferior_call): Update.
3567         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
3568         * guile/scm-symbol.c (gdbscm_lookup_symbol)
3569         (gdbscm_lookup_global_symbol): Update.
3570         * guile/scm-param.c (gdbscm_parameter_value): Update.
3571         * guile/scm-frame.c (gdbscm_frame_read_register)
3572         (gdbscm_frame_read_var): Update.
3573         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
3574         * exec.c (try_open_exec_file): Update.
3575         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3576         (gdb_rl_callback_handler): Update.
3577         * common/common-exceptions.h (exception_none): Don't declare.
3578         * common/common-exceptions.c (exception_none): Don't define.
3579         (struct catcher) <exception>: Update.
3580         * cli/cli-interp.c (safe_execute_command): Update.
3581         * breakpoint.c (insert_bp_location, location_to_sals): Update.
3582
3583 2019-04-25  Ali Tamur  <tamur@google.com>
3584
3585         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
3586         (read_attribute_value): Likewise.
3587         (dwarf2_read_addr_index): Update comment.
3588         (read_str_index): Add DW_FORM_strx.
3589         (dwarf2_string_attr): Likewise.
3590         (dwarf2_const_value_attr): Likewise.
3591         (dump_die_shallow): Likewise.
3592         (dwarf2_fetch_constant_bytes): Likewise.
3593         (skip_form_bytes): Likewise.
3594         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
3595
3596 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
3597
3598         PR corefiles/11608
3599         PR corefiles/18187
3600         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
3601         OFFSET.  Verify if current mapping contains an ELF header.
3602         (linux_find_memory_regions_full): Adjust call to
3603         dump_mapping_p.
3604
3605 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
3606             Kang Li <kanglictf@gmail.com>
3607
3608         PR gdb/21600
3609
3610         * dwarf2-frame.c (read_initial_length): Be consistent about using
3611         unsigned representation of length.
3612         (decode_frame_entry_1): Likewise.  Check for wraparound of
3613         end pointer as well as buffer overflow.
3614
3615 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
3616
3617         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
3618         "vq".
3619
3620 2019-04-24  Tom Tromey  <tromey@adacore.com>
3621
3622         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
3623
3624 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3625
3626         * s12z-tdep.c (s12z_unwind_pc): Delete.
3627         (s12z_unwind_sp): Delete.
3628         (s12z_gdbarch_init): Don't register deleted functions with
3629         gdbarch.
3630
3631 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3632
3633         * rl78-tdep.c (rl78_unwind_sp): Delete.
3634         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
3635
3636 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3637
3638         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
3639         (xstormy16_unwind_pc): Delete.
3640         (xstormy16_dummy_id): Delete.
3641         (xstormy16_gdbarch_init): Don't register deleted functions with
3642         gdbarch.
3643
3644 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3645
3646         * vax-tdep.c (vax_unwind_pc): Delete.
3647         (vax_gdbarch_init): Don't register deleted function with gdbarch.
3648
3649 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3650
3651         * v850-tdep.c (v850_unwind_sp): Delete.
3652         (v850_unwind_pc): Delete.
3653         (v850_dummy_id): Delete.
3654         (v850_gdbarch_init): Don't register deleted functions with
3655         gdbarch.
3656
3657 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3658
3659         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
3660         (tilegx_unwind_pc): Delete.
3661         (tilegx_unwind_dummy_id): Delete.
3662         (tilegx_gdbarch_init): Don't register deleted functions with
3663         gdbarch.
3664
3665 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3666
3667         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
3668         (tic6x_dummy_id): Delete.
3669         (tic6x_gdbarch_init): Don't register deleted functions with
3670         gdbarch.
3671
3672 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3673
3674         * sparc-tdep.c (sparc_unwind_pc): Delete.
3675         (sparc32_gdbarch_init): Don't register deleted function with
3676         gdbarch.
3677
3678 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3679
3680         * sh-tdep.c (sh_unwind_sp): Delete.
3681         (sh_unwind_pc): Delete.
3682         (sh_dummy_id): Delete.
3683         (sh_gdbarch_init): Don't register deleted functions with
3684         gdbarch.
3685
3686 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3687
3688         * score-tdep.c (score_unwind_sp): Delete.
3689         (score_unwind_pc): Delete.
3690         (score_dummy_id): Delete.
3691         (score_gdbarch_init): Don't register deleted functions with
3692         gdbarch.
3693
3694 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3695
3696         * rx-tdep.c (rx_unwind_pc): Delete.
3697         (rx_unwind_sp): Delete.
3698         (rx_dummy_id): Delete.
3699         (rx_gdbarch_init): Don't register deleted functions with
3700         gdbarch.  Update comment.
3701
3702 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3703
3704         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
3705         (rs6000_dummy_id): Delete.
3706         (rs6000_gdbarch_init): Don't register deleted functions with
3707         gdbarch.
3708
3709 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3710
3711         * or1k-tdep.c (or1k_dummy_id): Delete.
3712         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
3713
3714 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3715
3716         * nios2-tdep.c (nios2_dummy_id): Delete.
3717         (nios2_unwind_sp): Delete.
3718         (nios2_gdbarch_init): Don't register deleted functions with
3719         gdbarch.
3720
3721 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3722
3723         * nds32-tdep.c (nds32_dummy_id): Delete.
3724         (nds32_unwind_pc): Delete.
3725         (nds32_unwind_sp): Delete.
3726         (nds32_gdbarch_init): Don't register deleted functions with
3727         gdbarch.
3728
3729 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3730
3731         * msp430-tdep.c (msp430_unwind_pc): Delete.
3732         (msp430_unwind_sp): Delete.
3733         (msp430_dummy_id): Delete.
3734         (msp430_gdbarch_init): Don't register deleted functions with
3735         gdbarch.
3736
3737 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3738
3739         * moxie-tdep.c (moxie_unwind_sp): Delete.
3740         (moxie_unwind_pc): Delete.
3741         (moxie_dummy_id): Delete.
3742         (moxie_gdbarch_init): Don't register deleted functions with
3743         gdbarch.
3744
3745 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3746
3747         * mn10300-tdep.c (mn10300_dummy_id): Delete.
3748         (mn10300_unwind_pc): Delete.
3749         (mn10300_unwind_sp): Delete.
3750         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
3751         mn10300_unwind_sp.
3752         (mn10300_frame_unwind_init): Don't register deleted functions with
3753         gdbarch.
3754
3755 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3756
3757         * mep-tdep.c (mep_unwind_pc): Delete.
3758         (mep_unwind_sp): Delete.
3759         (mep_dummy_id): Delete.
3760         (mep_gdbarch_init): Don't register deleted functions with
3761         gdbarch.
3762
3763 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3764
3765         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
3766         (m68hc11_unwind_sp): Delete.
3767         (m68hc11_gdbarch_init): Don't register deleted functions with
3768         gdbarch.
3769
3770 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3771
3772         * m32r-tdep.c (m32r_unwind_sp): Delete.
3773         (m32r_unwind_pc): Delete.
3774         (m32r_dummy_id): Delete.
3775         (m32r_gdbarch_init): Don't register deleted functions with
3776         gdbarch.
3777
3778 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3779
3780         * m32c-tdep.c (m32c_unwind_pc): Delete.
3781         (m32c_unwind_sp): Delete.
3782         (m32c_dummy_id): Delete.
3783         (m32c_gdbarch_init): Don't register deleted functions with
3784         gdbarch.
3785
3786 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3787
3788         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
3789         (lm32_unwind_pc): Delete.
3790         (lm32_dummy_id): Delete.
3791         (lm32_gdbarch_init): Don't register deleted functions with
3792         gdbarch.
3793
3794 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3795
3796         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
3797         (iq2000_unwind_pc): Delete.
3798         (iq2000_dummy_id): Delete.
3799         (iq2000_gdbarch_init): Don't register deleted functions with
3800         gdbarch.
3801
3802 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3803
3804         * nds32-tdep.c (nds32_type_align): Delete.
3805         (nds32_push_dummy_call): Use type_align instead.
3806
3807 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3808
3809         * arm-tdep.c (arm_type_align): Only handle vector override case.
3810         (arm_push_dummy_call): Use type_align.
3811         (arm_gdbarch_init): Register arm_type_align gdbarch function.
3812
3813 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3814
3815         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
3816         case.
3817         (pass_on_stack): Use type_align.
3818         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
3819         function.
3820
3821 2019-04-23  Tom Tromey  <tromey@adacore.com>
3822
3823         * dwarf2read.c (line_header::file_name_at): Remove unused
3824         overload.
3825
3826 2019-04-23  Tom de Vries  <tdevries@suse.de>
3827
3828         PR gdb/24438
3829         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
3830         invocation.
3831
3832
3833 2019-03-27  Ali Tamur  <tamur@google.com>
3834
3835         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
3836         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
3837         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
3838         (dwarf_expr_context::get_addr_index): Likewise
3839         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
3840         (symbol_needs_eval_context::get_addr_index): Likewise
3841         (disassemble_dwarf_expression): Add DW_OP_addrx
3842         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
3843         (read_cutu_die_from_dwo): Update comment
3844         (skip_one_die): Add DW_FORM_addrx
3845         (read_attribute_value): Likewise
3846         (var_decode_location): Add DW_OP_addrx
3847         (dwarf2_const_value_attr): Add DW_FORM_addrx
3848         (dump_die_shallow): Likewise
3849         (dwarf2_fetch_constant_bytes): Likewise
3850         (decode_locdesc): Add DW_OP_addrx
3851         (skip_form_bytes): Add DW_FORM_addrx
3852
3853 2019-04-22  Ali Tamur  <tamur@google.com>
3854
3855         * MAINTAINERS (Write After Approval): Add self.
3856
3857 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
3858
3859         * solib-svr4.c (get_svr4_info): Add pspace parameter.
3860         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
3861         (open_symbol_file_object): Likewise.
3862         (svr4_default_sos): Add info parameter.
3863         (svr4_read_so_list): Likewise.
3864         (svr4_current_sos_direct): Adjust functions calls to pass down
3865         info.
3866         (svr4_current_sos_1): Add info parameter.
3867         (svr4_current_sos): Call get_svr4_info, pass info down to
3868         svr4_current_sos_1.
3869         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
3870         get_svr4_info.
3871         (svr4_in_dynsym_resolve_code): Pass current_program_space to
3872         get_svr4_info.
3873         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
3874         to get_svr4_info.
3875         (probes_table_remove_objfile_probes): Likewise.
3876         (register_solib_event_probe): Add info parameter.
3877         (solist_update_incremental): Pass info parameter down to
3878         svr4_read_so_list.
3879         (disable_probes_interface): Add info parameter.
3880         (svr4_handle_solib_event): Pass current_program_space to
3881         get_svr4_info.  Adjust disable_probes_interface cleanup.
3882         (svr4_create_probe_breakpoints): Add info parameter, pass it
3883         down to register_solib_event_probe.
3884         (svr4_create_solib_event_breakpoints): Add info parameter,
3885         pass it down to svr4_create_probe_breakpoints.
3886         (enable_break): Pass info down to
3887         svr4_create_solib_event_breakpoints.
3888         (svr4_solib_create_inferior_hook): Pass current_program_space to
3889         get_svr4_info.
3890         (svr4_clear_solib): Likewise.
3891
3892 2019-04-22  Pedro Alves  <palves@redhat.com>
3893
3894         * solib-svr4.c (svr4_free_objfile_observer): New.
3895         (probe_and_action::objfile): New field.
3896         (probes_table_htab_remove_objfile_probes)
3897         (probes_table_remove_objfile_probes): New functions.
3898         (register_solib_event_probe): Add 'objfile' parameter.  Store it
3899         in the new probe_and_action.  Don't store the probe in 'lookup'.
3900         (svr4_create_probe_breakpoints): Pass objfile to
3901         register_solib_event_probe.
3902         (_initialize_svr4_solib): Register a free_objfile observer.
3903
3904 2019-04-19  Tom Tromey  <tom@tromey.com>
3905
3906         * common/queue.h: Remove.
3907
3908 2019-04-19  Tom Tromey  <tom@tromey.com>
3909
3910         * event-loop.c: Don't include "common/queue.h".
3911
3912 2019-04-19  Tom Tromey  <tom@tromey.com>
3913
3914         * remote.c (remote_target): Use delete.
3915         * remote-notif.h: Include <list>, not "common/queue.h".
3916         (notif_client_p): Remove typedef.
3917         (remote_notif_state): Add constructor, destructor, initializer.
3918         <notif_queue>: Now a std::list.
3919         (remote_notif_state_xfree): Don't declare.
3920         * remote-notif.c (remote_notif_process, handle_notification)
3921         (remote_notif_state_allocate): Update.
3922         (~remote_notif_state): Rename from remote_notif_state_xfree.
3923
3924 2019-04-19  Tom Tromey  <tom@tromey.com>
3925
3926         * symfile.c (reread_symbols): Update.
3927         * objfiles.c (objfile_register_static_link)
3928         (objfile_lookup_static_link): Update
3929         (~objfile) Don't delete static_links.
3930         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
3931
3932 2019-04-19  Tom Tromey  <tom@tromey.com>
3933
3934         * type-stack.h (struct type_stack) <insert>: Constify string.
3935         * type-stack.c (type_stack::insert): Constify string.
3936         * gdbtypes.h (lookup_template_type): Update.
3937         (address_space_name_to_int): Update.
3938         * gdbtypes.c (address_space_name_to_int): Make space_identifier
3939         const.
3940         (lookup_template_type): Make name const.
3941         * c-exp.y: Update rules.
3942         (lex_one_token, classify_name, classify_inner_name)
3943         (c_print_token): Update.
3944         * p-exp.y: Update rules.
3945         (yylex): Update.
3946         * f-exp.y: Update rules.
3947         (yylex): Update.
3948         * d-exp.y: Update rules.
3949         (lex_one_token, classify_name, classify_inner_name): Update.
3950         * parse.c (write_dollar_variable, copy_name): Return std::string.
3951         * parser-defs.h (copy_name): Change return type.
3952         * m2-exp.y: Update rules.
3953         (yylex): Update.
3954         * go-exp.y (lex_one_token): Update.
3955         Update rules.
3956         (classify_unsafe_function, classify_packaged_name)
3957         (classify_name, yylex): Update.
3958
3959 2019-04-19  Sergei Trofimovich <siarheit@google.com>
3960
3961         * configure.ac: add --enable-source-highlight switch.
3962         * configure: Regenerate.
3963         * top.c (print_gdb_version): plumb --enable-source-highlight
3964         status to "show configuration".
3965
3966 2019-04-19  Tom Tromey  <tromey@adacore.com>
3967
3968         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
3969         Check ADA_TYPE_P.
3970         (empty_record, ada_template_to_fixed_record_type_1)
3971         (template_to_static_fixed_type)
3972         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
3973         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
3974         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
3975         macros.
3976
3977 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
3978
3979         PR symtab/24423:
3980         * source.c (print_source_lines_base): Advance "iter" when a
3981         control character is seen.
3982
3983 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3984
3985         * inferior.h (struct infcall_suspend_state_deleter):
3986         Catch exception in destructor to avoid crash.
3987
3988 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3989
3990         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
3991         close to the add_com "shell".
3992
3993 2019-04-18  Tom Tromey  <tromey@adacore.com>
3994
3995         * process-stratum-target.h (class process_stratum_target)
3996         <stratum>: Add "final".
3997
3998 2019-04-17  Tom Tromey  <tromey@adacore.com>
3999
4000         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4001         against nullptr before use.
4002
4003 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4004
4005         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4006
4007 2019-04-17  Jim Wilson  <jimw@sifive.com>
4008             Andrew Burgess  <andrew.burgess@embecosm.com>
4009
4010         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4011         code read might fail, assume 4-byte breakpoint in that case.
4012
4013 2019-04-15  Leszek Swirski  <leszeks@google.com>
4014
4015         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4016         rather than a hand-rolled POD check when checking for forced MEMORY
4017         classification.
4018
4019 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4020
4021         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4022         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4023         function.
4024         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4025         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4026         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4027         declaration.
4028
4029 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4030
4031         * aarch64-linux-nat.c
4032         (aarch64_linux_nat_target::thread_architecture): Add override.
4033         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4034         each VQ.
4035
4036 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4037
4038         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4039
4040 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4041
4042         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4043         target types of size 96-bits, add some additional comments, and
4044         check that the builtin type we found was the correct size.
4045
4046 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4047
4048         * utils.c (prompt_for_continue): Don't restore the styling at the
4049         end, as applied_style has the wrong value.  This fixes styling in
4050         long lists of file names that are interrupted by the "Continue?"
4051         prompt.
4052
4053 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4054
4055         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4056         * c-lang.c (c_language_defn): Likewise.
4057         (cplus_language_defn): Likewise.
4058         (asm_language_defn): Likewise.
4059         (minimal_language_defn): Likewise.
4060         * d-lang.c (d_language_defn): Likewise.
4061         * f-lang.c (f_language_defn): Likewise.
4062         * go-lang.c (go_language_defn): Likewise.
4063         * language.c (unknown_language_defn): Likewise.
4064         (auto_language_defn): Likewise.
4065         * language.h (struct language_defn): Remove la_magic field.
4066         (LANG_MAGIC): Delete.
4067         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4068         * objc-lang.c (objc_language_defn): Likewise.
4069         * opencl-lang.c (opencl_language_defn): Likewise.
4070         * p-lang.c (pascal_language_defn): Likewise.
4071         * rust-lang.c (rust_language_defn): Likewise.
4072
4073 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4074
4075         * riscv-tdep.c (riscv_type_align): New function.
4076         (riscv_type_alignment): Delete.
4077         (riscv_arg_location): Use 'type_align'.
4078         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4079
4080 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4081
4082         * gdbtypes.c (type_align): A struct with no non-static fields also
4083         has alignment of 1.
4084
4085 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4086
4087         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4088         component to 0.
4089         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4090         member.
4091         (riscv_struct_info::analyse): New implementation using new
4092         analyse_inner member function.
4093         (riscv_struct_info::field_offset): New member function.
4094         (riscv_struct_info::m_offsets): New member variable.
4095         (riscv_struct_info::analyse_inner): New private member function,
4096         takes the old implementation of riscv_struct_info::analyse but
4097         extended to track field offsets.
4098         (riscv_call_arg_struct): Update the struct folding special cases
4099         to handle cases where empty C++ structs, which are non-zero
4100         length, are found.
4101         (riscv_arg_location): Initialise the length of each location, a
4102         non-zero length now indicates the location is in use.
4103         (riscv_push_dummy_call): Allow for the first location having a
4104         non-zero offset when setting up arguments.
4105         (riscv_return_value): Likewise, but for return values.
4106
4107 2019-04-11  Tom Tromey  <tromey@adacore.com>
4108
4109         * utils.c (internal_vproblem): Make "msg" const.
4110
4111 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4112
4113         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4114         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4115         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4116         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4117
4118 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4119
4120         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4121         function.
4122         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4123         of amd64_collect_native_gregset.
4124         (amd64_linux_nat_target::store_registers): Likewise.
4125
4126 2019-04-10  Tom Tromey  <tom@tromey.com>
4127
4128         * symtab.c (lookup_global_symbol_from_objfile)
4129         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4130         * objfiles.h (class separate_debug_iterator): New.
4131         (class separate_debug_range): New.
4132         (struct objfile) <separate_debug_objfiles>: New method.
4133         (objfile_separate_debug_iterate): Don't declare.
4134         * objfiles.c (separate_debug_iterator::operator++): Rename from
4135         objfile_separate_debug_iterate.
4136         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4137         iterator.
4138         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4139         iterator.
4140
4141 2019-04-10  Tom Tromey  <tom@tromey.com>
4142
4143         * symfile.c (reread_symbols): Remove old comment.
4144         * objfiles.c (free_all_objfiles): Fix a typo.
4145
4146 2019-04-10  Tom Tromey  <tom@tromey.com>
4147
4148         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4149         * minsyms.c (lookup_minimal_symbol): Use foreach.
4150         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4151         (lookup_minimal_symbol_solib_trampoline): Likewise.
4152         * symfile.c (reread_symbols): Use foreach.
4153
4154 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4155             Tom Tromey  <tromey@adacore.com>
4156
4157         PR rust/24414:
4158         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4159         (rust_lex_int_test): Change "value" to be LONGEST.
4160         (rust_lex_tests): Add test for long integer literal.
4161
4162 2019-04-09  Tom Tromey  <tromey@adacore.com>
4163
4164         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
4165         to bool.
4166         (extended_remote_target::attach): Update.
4167         (remote_target::remote_notice_new_inferior): Update.
4168         (remote_target::add_current_inferior_and_thread): Update.
4169         * inferior.c (exit_inferior_1): Use "false".
4170         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
4171
4172 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
4173
4174         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
4175         the "start" command.
4176
4177 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4178
4179         * python/py-inferior.c (infpy_thread_from_thread_handle):
4180         Adjust comments to reflect renaming of thread_from_thread_handle
4181         to thread_from_handle.  Adjust keywords.  Fix type error message.
4182         (inferior_object_methods): Add thread_from_handle.  Retain
4183         thread_from_thread_handle, but mark it as deprecated.
4184
4185 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4186
4187         * gdbthread.h (find_thread_by_handle): Revise declaration.
4188         * thread.c (find_thread_by_handle): Likewise.  Adjust
4189         implementation too.
4190         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
4191         support for buffer objects as handles.
4192
4193 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4194
4195         * python/py-infthread.c (thpy_thread_handle): New function.
4196         (thread_object_methods): Register thpy_thread_handle.
4197
4198 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4199
4200         * gdbthread.h (thread_to_thread_handle): Declare.
4201         * thread.c (gdbtypes.h): Include.
4202         (thread_to_thread_handle): New function.
4203
4204         * target.h (struct target_ops): Add thread_info_to_thread_handle.
4205         (target_thread_info_to_thread_handle): Declare.
4206         * target.c (target_thread_info_to_thread_handle): New function.
4207         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
4208         * target-delegates.c: Regenerate.
4209
4210         * linux-thread-db.c (class thread_db_target): Add method
4211         thread_info_to_thread_handle.
4212         (thread_db_target::thread_info_to_thread_handle): Define.
4213         * remote.c (class remote_target): Add new method
4214         thread_info_to_thread_handle.
4215         (remote_target::thread_info_to_thread_handle): Define.
4216
4217 2019-04-08  Pedro Alves  <palves@redhat.com>
4218
4219         * common/common-exceptions.c (throw_exception): Don't create
4220         named object to throw; throw directly.
4221         (throw_it): Likewise.  Don't initialize gdb_exception::message
4222         here, with new; pass FMT and AP to the ctor instead.
4223         * common/common-exceptions.h: Include <string>.
4224         (gdb_exception::gdb_exception(enum return_reason, enum errors,
4225         const char *, va_list)): New ctor.  Use std::make_shared.
4226         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
4227         errors)): Delete.
4228         (gdb_exception_error::gdb_exception_error(enum errors, const char
4229         *, va_list)): New.
4230         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
4231         Add assertion.
4232         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
4233         errors)): Delete.
4234         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
4235         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
4236         Add assertion.
4237
4238 2019-04-08  Tom Tromey  <tom@tromey.com>
4239
4240         * valops.c (value_rtti_indirect_type): Replace throw_exception
4241         with throw.
4242         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
4243         with throw.
4244         * thread.c (thr_try_catch_cmd): Replace throw_exception with
4245         throw.
4246         * target.c (target_translate_tls_address): Replace throw_exception
4247         with throw.
4248         * stack.c (frame_apply_command_count): Replace throw_exception
4249         with throw.
4250         * solib-spu.c (append_ocl_sos): Replace throw_exception with
4251         throw.
4252         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
4253         with throw.
4254         * rs6000-tdep.c (rs6000_frame_cache)
4255         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
4256         * remote.c: Replace throw_exception with throw.
4257         * record-full.c (record_full_message, record_full_wait_1)
4258         (record_full_restore): Replace throw_exception with throw.
4259         * record-btrace.c:
4260         (get_thread_current_frame_id, record_btrace_start_replaying)
4261         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
4262         (cmd_record_btrace_start): Replace throw_exception with throw.
4263         * parse.c (parse_exp_in_context_1): Replace throw_exception with
4264         throw.
4265         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
4266         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
4267         * linespec.c:
4268         (find_linespec_symbols): Replace throw_exception with throw.
4269         * infrun.c (displaced_step_prepare, resume): Replace
4270         throw_exception with throw.
4271         * infcmd.c (post_create_inferior): Replace throw_exception with
4272         throw.
4273         * inf-loop.c (inferior_event_handler): Replace throw_exception
4274         with throw.
4275         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
4276         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
4277         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
4278         (get_prev_frame_always, get_frame_pc_if_available)
4279         (get_frame_address_in_block_if_available, get_frame_language):
4280         Replace throw_exception with throw.
4281         * frame-unwind.c (frame_unwind_try_unwinder): Replace
4282         throw_exception with throw.
4283         * eval.c (fetch_subexp_value, evaluate_var_value)
4284         (evaluate_funcall, evaluate_subexp_standard): Replace
4285         throw_exception with throw.
4286         * dwarf2loc.c (call_site_find_chain)
4287         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
4288         Replace throw_exception with throw.
4289         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
4290         with throw.
4291         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
4292         throw.
4293         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
4294         * completer.c (complete_line_internal): Replace throw_exception
4295         with throw.
4296         * compile/compile-object-run.c (compile_object_run): Replace
4297         throw_exception with throw.
4298         * cli/cli-script.c (process_next_line): Replace throw_exception
4299         with throw.
4300         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
4301         (btrace_enable, btrace_maint_update_pt_packets): Replace
4302         throw_exception with throw.
4303         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
4304         throw_exception with throw.
4305         * break-catch-throw.c (re_set_exception_catchpoint): Replace
4306         throw_exception with throw.
4307         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
4308         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
4309         * aarch64-tdep.c (aarch64_make_prologue_cache)
4310         (aarch64_make_stub_cache): Replace throw_exception with throw.
4311
4312 2019-04-08  Tom Tromey  <tom@tromey.com>
4313
4314         * common/common-exceptions.c (throw_exception): Rename from
4315         throw_exception_cxx.  Remove old copy.  Make argument const.
4316         (throw_it): Create and throw exception objects directly.
4317         * common/common-exceptions.h (throw_exception): Make argument
4318         const.
4319         (struct gdb_exception_error): Add constructor.
4320         (struct gdb_exception_quit): Add constructor.
4321
4322 2019-04-08  Tom Tromey  <tom@tromey.com>
4323
4324         * common/common-exceptions.h (exception_rethrow): Don't declare.
4325         (TRY_SJLJ): Update comment.
4326         (TRY, CATCH, END_CATCH): Remove.
4327         * common/common-exceptions.c (exception_rethrow): Remove.
4328
4329 2019-04-08  Tom Tromey  <tom@tromey.com>
4330
4331         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
4332         Remove.
4333         (gdb_exception_error): Rename from
4334         gdb_exception_RETURN_MASK_ERROR.
4335         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
4336         (gdb_quit_bad_alloc): Update.
4337         * aarch64-tdep.c: Update.
4338         * ada-lang.c: Update.
4339         * ada-typeprint.c: Update.
4340         * ada-valprint.c: Update.
4341         * amd64-tdep.c: Update.
4342         * arch-utils.c: Update.
4343         * break-catch-throw.c: Update.
4344         * breakpoint.c: Update.
4345         * btrace.c: Update.
4346         * c-varobj.c: Update.
4347         * cli/cli-cmds.c: Update.
4348         * cli/cli-interp.c: Update.
4349         * cli/cli-script.c: Update.
4350         * common/common-exceptions.c: Update.
4351         * common/new-op.c: Update.
4352         * common/selftest.c: Update.
4353         * compile/compile-c-symbols.c: Update.
4354         * compile/compile-cplus-symbols.c: Update.
4355         * compile/compile-object-load.c: Update.
4356         * compile/compile-object-run.c: Update.
4357         * completer.c: Update.
4358         * corelow.c: Update.
4359         * cp-abi.c: Update.
4360         * cp-support.c: Update.
4361         * cp-valprint.c: Update.
4362         * darwin-nat.c: Update.
4363         * disasm-selftests.c: Update.
4364         * dtrace-probe.c: Update.
4365         * dwarf-index-cache.c: Update.
4366         * dwarf-index-write.c: Update.
4367         * dwarf2-frame-tailcall.c: Update.
4368         * dwarf2-frame.c: Update.
4369         * dwarf2loc.c: Update.
4370         * dwarf2read.c: Update.
4371         * eval.c: Update.
4372         * event-loop.c: Update.
4373         * event-top.c: Update.
4374         * exec.c: Update.
4375         * f-valprint.c: Update.
4376         * fbsd-tdep.c: Update.
4377         * frame-unwind.c: Update.
4378         * frame.c: Update.
4379         * gdbtypes.c: Update.
4380         * gnu-v3-abi.c: Update.
4381         * guile/guile-internal.h: Update.
4382         * guile/scm-block.c: Update.
4383         * guile/scm-breakpoint.c: Update.
4384         * guile/scm-cmd.c: Update.
4385         * guile/scm-disasm.c: Update.
4386         * guile/scm-frame.c: Update.
4387         * guile/scm-lazy-string.c: Update.
4388         * guile/scm-math.c: Update.
4389         * guile/scm-param.c: Update.
4390         * guile/scm-ports.c: Update.
4391         * guile/scm-pretty-print.c: Update.
4392         * guile/scm-symbol.c: Update.
4393         * guile/scm-symtab.c: Update.
4394         * guile/scm-type.c: Update.
4395         * guile/scm-value.c: Update.
4396         * i386-linux-tdep.c: Update.
4397         * i386-tdep.c: Update.
4398         * inf-loop.c: Update.
4399         * infcall.c: Update.
4400         * infcmd.c: Update.
4401         * infrun.c: Update.
4402         * jit.c: Update.
4403         * language.c: Update.
4404         * linespec.c: Update.
4405         * linux-fork.c: Update.
4406         * linux-nat.c: Update.
4407         * linux-tdep.c: Update.
4408         * linux-thread-db.c: Update.
4409         * main.c: Update.
4410         * mi/mi-cmd-break.c: Update.
4411         * mi/mi-cmd-stack.c: Update.
4412         * mi/mi-interp.c: Update.
4413         * mi/mi-main.c: Update.
4414         * objc-lang.c: Update.
4415         * p-valprint.c: Update.
4416         * parse.c: Update.
4417         * ppc-linux-tdep.c: Update.
4418         * printcmd.c: Update.
4419         * python/py-arch.c: Update.
4420         * python/py-breakpoint.c: Update.
4421         * python/py-cmd.c: Update.
4422         * python/py-finishbreakpoint.c: Update.
4423         * python/py-frame.c: Update.
4424         * python/py-framefilter.c: Update.
4425         * python/py-gdb-readline.c: Update.
4426         * python/py-inferior.c: Update.
4427         * python/py-infthread.c: Update.
4428         * python/py-lazy-string.c: Update.
4429         * python/py-linetable.c: Update.
4430         * python/py-objfile.c: Update.
4431         * python/py-param.c: Update.
4432         * python/py-prettyprint.c: Update.
4433         * python/py-progspace.c: Update.
4434         * python/py-record-btrace.c: Update.
4435         * python/py-record.c: Update.
4436         * python/py-symbol.c: Update.
4437         * python/py-type.c: Update.
4438         * python/py-unwind.c: Update.
4439         * python/py-utils.c: Update.
4440         * python/py-value.c: Update.
4441         * python/python.c: Update.
4442         * record-btrace.c: Update.
4443         * record-full.c: Update.
4444         * remote-fileio.c: Update.
4445         * remote.c: Update.
4446         * riscv-tdep.c: Update.
4447         * rs6000-aix-tdep.c: Update.
4448         * rs6000-tdep.c: Update.
4449         * rust-exp.y: Update.
4450         * rust-lang.c: Update.
4451         * s390-tdep.c: Update.
4452         * selftest-arch.c: Update.
4453         * solib-dsbt.c: Update.
4454         * solib-frv.c: Update.
4455         * solib-spu.c: Update.
4456         * solib-svr4.c: Update.
4457         * solib.c: Update.
4458         * sparc64-linux-tdep.c: Update.
4459         * stack.c: Update.
4460         * symfile-mem.c: Update.
4461         * symmisc.c: Update.
4462         * target.c: Update.
4463         * thread.c: Update.
4464         * top.c: Update.
4465         * tracefile-tfile.c: Update.
4466         * tui/tui.c: Update.
4467         * typeprint.c: Update.
4468         * unittests/cli-utils-selftests.c: Update.
4469         * unittests/parse-connection-spec-selftests.c: Update.
4470         * valops.c: Update.
4471         * valprint.c: Update.
4472         * value.c: Update.
4473         * varobj.c: Update.
4474         * windows-nat.c: Update.
4475         * x86-linux-nat.c: Update.
4476         * xml-support.c: Update.
4477
4478 2019-04-08  Tom Tromey  <tom@tromey.com>
4479
4480         * xml-support.c: Use C++ exception handling.
4481         * x86-linux-nat.c: Use C++ exception handling.
4482         * windows-nat.c: Use C++ exception handling.
4483         * varobj.c: Use C++ exception handling.
4484         * value.c: Use C++ exception handling.
4485         * valprint.c: Use C++ exception handling.
4486         * valops.c: Use C++ exception handling.
4487         * unittests/parse-connection-spec-selftests.c: Use C++ exception
4488         handling.
4489         * unittests/cli-utils-selftests.c: Use C++ exception handling.
4490         * typeprint.c: Use C++ exception handling.
4491         * tui/tui.c: Use C++ exception handling.
4492         * tracefile-tfile.c: Use C++ exception handling.
4493         * top.c: Use C++ exception handling.
4494         * thread.c: Use C++ exception handling.
4495         * target.c: Use C++ exception handling.
4496         * symmisc.c: Use C++ exception handling.
4497         * symfile-mem.c: Use C++ exception handling.
4498         * stack.c: Use C++ exception handling.
4499         * sparc64-linux-tdep.c: Use C++ exception handling.
4500         * solib.c: Use C++ exception handling.
4501         * solib-svr4.c: Use C++ exception handling.
4502         * solib-spu.c: Use C++ exception handling.
4503         * solib-frv.c: Use C++ exception handling.
4504         * solib-dsbt.c: Use C++ exception handling.
4505         * selftest-arch.c: Use C++ exception handling.
4506         * s390-tdep.c: Use C++ exception handling.
4507         * rust-lang.c: Use C++ exception handling.
4508         * rust-exp.y: Use C++ exception handling.
4509         * rs6000-tdep.c: Use C++ exception handling.
4510         * rs6000-aix-tdep.c: Use C++ exception handling.
4511         * riscv-tdep.c: Use C++ exception handling.
4512         * remote.c: Use C++ exception handling.
4513         * remote-fileio.c: Use C++ exception handling.
4514         * record-full.c: Use C++ exception handling.
4515         * record-btrace.c: Use C++ exception handling.
4516         * python/python.c: Use C++ exception handling.
4517         * python/py-value.c: Use C++ exception handling.
4518         * python/py-utils.c: Use C++ exception handling.
4519         * python/py-unwind.c: Use C++ exception handling.
4520         * python/py-type.c: Use C++ exception handling.
4521         * python/py-symbol.c: Use C++ exception handling.
4522         * python/py-record.c: Use C++ exception handling.
4523         * python/py-record-btrace.c: Use C++ exception handling.
4524         * python/py-progspace.c: Use C++ exception handling.
4525         * python/py-prettyprint.c: Use C++ exception handling.
4526         * python/py-param.c: Use C++ exception handling.
4527         * python/py-objfile.c: Use C++ exception handling.
4528         * python/py-linetable.c: Use C++ exception handling.
4529         * python/py-lazy-string.c: Use C++ exception handling.
4530         * python/py-infthread.c: Use C++ exception handling.
4531         * python/py-inferior.c: Use C++ exception handling.
4532         * python/py-gdb-readline.c: Use C++ exception handling.
4533         * python/py-framefilter.c: Use C++ exception handling.
4534         * python/py-frame.c: Use C++ exception handling.
4535         * python/py-finishbreakpoint.c: Use C++ exception handling.
4536         * python/py-cmd.c: Use C++ exception handling.
4537         * python/py-breakpoint.c: Use C++ exception handling.
4538         * python/py-arch.c: Use C++ exception handling.
4539         * printcmd.c: Use C++ exception handling.
4540         * ppc-linux-tdep.c: Use C++ exception handling.
4541         * parse.c: Use C++ exception handling.
4542         * p-valprint.c: Use C++ exception handling.
4543         * objc-lang.c: Use C++ exception handling.
4544         * mi/mi-main.c: Use C++ exception handling.
4545         * mi/mi-interp.c: Use C++ exception handling.
4546         * mi/mi-cmd-stack.c: Use C++ exception handling.
4547         * mi/mi-cmd-break.c: Use C++ exception handling.
4548         * main.c: Use C++ exception handling.
4549         * linux-thread-db.c: Use C++ exception handling.
4550         * linux-tdep.c: Use C++ exception handling.
4551         * linux-nat.c: Use C++ exception handling.
4552         * linux-fork.c: Use C++ exception handling.
4553         * linespec.c: Use C++ exception handling.
4554         * language.c: Use C++ exception handling.
4555         * jit.c: Use C++ exception handling.
4556         * infrun.c: Use C++ exception handling.
4557         * infcmd.c: Use C++ exception handling.
4558         * infcall.c: Use C++ exception handling.
4559         * inf-loop.c: Use C++ exception handling.
4560         * i386-tdep.c: Use C++ exception handling.
4561         * i386-linux-tdep.c: Use C++ exception handling.
4562         * guile/scm-value.c: Use C++ exception handling.
4563         * guile/scm-type.c: Use C++ exception handling.
4564         * guile/scm-symtab.c: Use C++ exception handling.
4565         * guile/scm-symbol.c: Use C++ exception handling.
4566         * guile/scm-pretty-print.c: Use C++ exception handling.
4567         * guile/scm-ports.c: Use C++ exception handling.
4568         * guile/scm-param.c: Use C++ exception handling.
4569         * guile/scm-math.c: Use C++ exception handling.
4570         * guile/scm-lazy-string.c: Use C++ exception handling.
4571         * guile/scm-frame.c: Use C++ exception handling.
4572         * guile/scm-disasm.c: Use C++ exception handling.
4573         * guile/scm-cmd.c: Use C++ exception handling.
4574         * guile/scm-breakpoint.c: Use C++ exception handling.
4575         * guile/scm-block.c: Use C++ exception handling.
4576         * guile/guile-internal.h: Use C++ exception handling.
4577         * gnu-v3-abi.c: Use C++ exception handling.
4578         * gdbtypes.c: Use C++ exception handling.
4579         * frame.c: Use C++ exception handling.
4580         * frame-unwind.c: Use C++ exception handling.
4581         * fbsd-tdep.c: Use C++ exception handling.
4582         * f-valprint.c: Use C++ exception handling.
4583         * exec.c: Use C++ exception handling.
4584         * event-top.c: Use C++ exception handling.
4585         * event-loop.c: Use C++ exception handling.
4586         * eval.c: Use C++ exception handling.
4587         * dwarf2read.c: Use C++ exception handling.
4588         * dwarf2loc.c: Use C++ exception handling.
4589         * dwarf2-frame.c: Use C++ exception handling.
4590         * dwarf2-frame-tailcall.c: Use C++ exception handling.
4591         * dwarf-index-write.c: Use C++ exception handling.
4592         * dwarf-index-cache.c: Use C++ exception handling.
4593         * dtrace-probe.c: Use C++ exception handling.
4594         * disasm-selftests.c: Use C++ exception handling.
4595         * darwin-nat.c: Use C++ exception handling.
4596         * cp-valprint.c: Use C++ exception handling.
4597         * cp-support.c: Use C++ exception handling.
4598         * cp-abi.c: Use C++ exception handling.
4599         * corelow.c: Use C++ exception handling.
4600         * completer.c: Use C++ exception handling.
4601         * compile/compile-object-run.c: Use C++ exception handling.
4602         * compile/compile-object-load.c: Use C++ exception handling.
4603         * compile/compile-cplus-symbols.c: Use C++ exception handling.
4604         * compile/compile-c-symbols.c: Use C++ exception handling.
4605         * common/selftest.c: Use C++ exception handling.
4606         * common/new-op.c: Use C++ exception handling.
4607         * cli/cli-script.c: Use C++ exception handling.
4608         * cli/cli-interp.c: Use C++ exception handling.
4609         * cli/cli-cmds.c: Use C++ exception handling.
4610         * c-varobj.c: Use C++ exception handling.
4611         * btrace.c: Use C++ exception handling.
4612         * breakpoint.c: Use C++ exception handling.
4613         * break-catch-throw.c: Use C++ exception handling.
4614         * arch-utils.c: Use C++ exception handling.
4615         * amd64-tdep.c: Use C++ exception handling.
4616         * ada-valprint.c: Use C++ exception handling.
4617         * ada-typeprint.c: Use C++ exception handling.
4618         * ada-lang.c: Use C++ exception handling.
4619         * aarch64-tdep.c: Use C++ exception handling.
4620
4621 2019-04-08  Tom Tromey  <tom@tromey.com>
4622
4623         * xml-support.c (gdb_xml_parser::parse): Update.
4624         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4625         * value.c (show_convenience): Update.
4626         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
4627         (test_parse_flags_qcs): Update.
4628         * thread.c (thr_try_catch_cmd): Update.
4629         * target.c (target_translate_tls_address): Update.
4630         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4631         (info_frame_command_core, frame_apply_command_count): Update.
4632         * rust-exp.y (rust_lex_exception_test): Update.
4633         * riscv-tdep.c (riscv_print_one_register_info): Update.
4634         * remote.c (remote_target::enable_btrace): Update.
4635         * record-btrace.c (record_btrace_enable_warn): Update.
4636         * python/py-utils.c (gdbpy_convert_exception): Update.
4637         * printcmd.c (do_one_display, print_variable_and_value): Update.
4638         * mi/mi-main.c (mi_print_exception): Update.
4639         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
4640         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4641         * linux-nat.c (linux_nat_target::attach): Update.
4642         * linux-fork.c (class scoped_switch_fork_info): Update.
4643         * infrun.c (displaced_step_prepare): Update.
4644         * infcall.c (call_function_by_hand_dummy): Update.
4645         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
4646         * gnu-v3-abi.c (print_one_vtable): Update.
4647         * frame.c (get_prev_frame_always): Update.
4648         * f-valprint.c (info_common_command_for_block): Update.
4649         * exec.c (try_open_exec_file): Update.
4650         * exceptions.c (print_exception, exception_print)
4651         (exception_fprintf, exception_print_same): Update.
4652         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
4653         * dwarf-index-cache.c (index_cache::store)
4654         (index_cache::lookup_gdb_index): Update.
4655         * darwin-nat.c (maybe_cache_shell): Update.
4656         * cp-valprint.c (cp_print_value_fields): Update.
4657         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
4658         (gcc_cplus_symbol_address): Update.
4659         * compile/compile-c-symbols.c (gcc_convert_symbol)
4660         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
4661         * common/selftest.c: Update.
4662         * common/common-exceptions.h (struct gdb_exception) <message>: Now
4663         a std::string.
4664         (exception_try_scope_entry, exception_try_scope_exit): Don't
4665         declare.
4666         (struct exception_try_scope): Remove.
4667         (TRY): Don't use exception_try_scope.
4668         (struct gdb_exception): Add constructor, operator=.
4669         <what>: New method.
4670         (struct gdb_exception_RETURN_MASK_ALL)
4671         (struct gdb_exception_RETURN_MASK_ERROR)
4672         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
4673         (struct gdb_quit_bad_alloc): Update.
4674         * common/common-exceptions.c (exception_none): Change
4675         initializer.
4676         (struct catcher) <state, exception>: Initialize inline.
4677         <prev>: Remove member.
4678         (current_catcher): Remove.
4679         (catchers): New global.
4680         (exceptions_state_mc_init): Simplify.
4681         (catcher_pop): Remove.
4682         (exceptions_state_mc, exceptions_state_mc_catch): Update.
4683         (try_scope_depth, exception_try_scope_entry)
4684         (exception_try_scope_exit): Remove.
4685         (throw_exception_sjlj): Update.
4686         (exception_messages, exception_messages_size): Remove.
4687         (throw_it): Simplify.
4688         (gdb_exception_sliced_copy): Remove.
4689         (throw_exception_cxx): Update.
4690         * cli/cli-script.c (script_from_file): Update.
4691         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
4692         Update.
4693         * ada-valprint.c (ada_val_print): Update.
4694         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
4695         (create_excep_cond_exprs): Update.
4696
4697 2019-04-08  Tom Tromey  <tom@tromey.com>
4698
4699         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
4700         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
4701         (TRY, CATCH, END_CATCH): Remove some definitions.
4702         * common/common-exceptions.c: Don't use GDB_XCPT.
4703         (catcher_list_size): Remove.
4704         (throw_exception, throw_it): Simplify.
4705
4706 2019-04-05  Tom Tromey  <tom@tromey.com>
4707
4708         Revert the header-sorting patch.
4709         * ft32-tdep.c: Revert.
4710         * frv-tdep.c: Revert.
4711         * frv-linux-tdep.c: Revert.
4712         * frame.c: Revert.
4713         * frame-unwind.c: Revert.
4714         * frame-base.c: Revert.
4715         * fork-child.c: Revert.
4716         * findvar.c: Revert.
4717         * findcmd.c: Revert.
4718         * filesystem.c: Revert.
4719         * filename-seen-cache.h: Revert.
4720         * filename-seen-cache.c: Revert.
4721         * fbsd-tdep.c: Revert.
4722         * fbsd-nat.h: Revert.
4723         * fbsd-nat.c: Revert.
4724         * f-valprint.c: Revert.
4725         * f-typeprint.c: Revert.
4726         * f-lang.c: Revert.
4727         * extension.h: Revert.
4728         * extension.c: Revert.
4729         * extension-priv.h: Revert.
4730         * expprint.c: Revert.
4731         * exec.h: Revert.
4732         * exec.c: Revert.
4733         * exceptions.c: Revert.
4734         * event-top.c: Revert.
4735         * event-loop.c: Revert.
4736         * eval.c: Revert.
4737         * elfread.c: Revert.
4738         * dwarf2read.h: Revert.
4739         * dwarf2read.c: Revert.
4740         * dwarf2loc.c: Revert.
4741         * dwarf2expr.h: Revert.
4742         * dwarf2expr.c: Revert.
4743         * dwarf2-frame.c: Revert.
4744         * dwarf2-frame-tailcall.c: Revert.
4745         * dwarf-index-write.h: Revert.
4746         * dwarf-index-write.c: Revert.
4747         * dwarf-index-common.c: Revert.
4748         * dwarf-index-cache.h: Revert.
4749         * dwarf-index-cache.c: Revert.
4750         * dummy-frame.c: Revert.
4751         * dtrace-probe.c: Revert.
4752         * disasm.h: Revert.
4753         * disasm.c: Revert.
4754         * disasm-selftests.c: Revert.
4755         * dictionary.c: Revert.
4756         * dicos-tdep.c: Revert.
4757         * demangle.c: Revert.
4758         * dcache.h: Revert.
4759         * dcache.c: Revert.
4760         * darwin-nat.h: Revert.
4761         * darwin-nat.c: Revert.
4762         * darwin-nat-info.c: Revert.
4763         * d-valprint.c: Revert.
4764         * d-namespace.c: Revert.
4765         * d-lang.c: Revert.
4766         * ctf.c: Revert.
4767         * csky-tdep.c: Revert.
4768         * csky-linux-tdep.c: Revert.
4769         * cris-tdep.c: Revert.
4770         * cris-linux-tdep.c: Revert.
4771         * cp-valprint.c: Revert.
4772         * cp-support.c: Revert.
4773         * cp-namespace.c: Revert.
4774         * cp-abi.c: Revert.
4775         * corelow.c: Revert.
4776         * corefile.c: Revert.
4777         * continuations.c: Revert.
4778         * completer.h: Revert.
4779         * completer.c: Revert.
4780         * complaints.c: Revert.
4781         * coffread.c: Revert.
4782         * coff-pe-read.c: Revert.
4783         * cli-out.h: Revert.
4784         * cli-out.c: Revert.
4785         * charset.c: Revert.
4786         * c-varobj.c: Revert.
4787         * c-valprint.c: Revert.
4788         * c-typeprint.c: Revert.
4789         * c-lang.c: Revert.
4790         * buildsym.c: Revert.
4791         * buildsym-legacy.c: Revert.
4792         * build-id.h: Revert.
4793         * build-id.c: Revert.
4794         * btrace.c: Revert.
4795         * bsd-uthread.c: Revert.
4796         * breakpoint.h: Revert.
4797         * breakpoint.c: Revert.
4798         * break-catch-throw.c: Revert.
4799         * break-catch-syscall.c: Revert.
4800         * break-catch-sig.c: Revert.
4801         * blockframe.c: Revert.
4802         * block.c: Revert.
4803         * bfin-tdep.c: Revert.
4804         * bfin-linux-tdep.c: Revert.
4805         * bfd-target.c: Revert.
4806         * bcache.c: Revert.
4807         * ax-general.c: Revert.
4808         * ax-gdb.h: Revert.
4809         * ax-gdb.c: Revert.
4810         * avr-tdep.c: Revert.
4811         * auxv.c: Revert.
4812         * auto-load.c: Revert.
4813         * arm-wince-tdep.c: Revert.
4814         * arm-tdep.c: Revert.
4815         * arm-symbian-tdep.c: Revert.
4816         * arm-pikeos-tdep.c: Revert.
4817         * arm-obsd-tdep.c: Revert.
4818         * arm-nbsd-tdep.c: Revert.
4819         * arm-nbsd-nat.c: Revert.
4820         * arm-linux-tdep.c: Revert.
4821         * arm-linux-nat.c: Revert.
4822         * arm-fbsd-tdep.c: Revert.
4823         * arm-fbsd-nat.c: Revert.
4824         * arm-bsd-tdep.c: Revert.
4825         * arch-utils.c: Revert.
4826         * arc-tdep.c: Revert.
4827         * arc-newlib-tdep.c: Revert.
4828         * annotate.h: Revert.
4829         * annotate.c: Revert.
4830         * amd64-windows-tdep.c: Revert.
4831         * amd64-windows-nat.c: Revert.
4832         * amd64-tdep.c: Revert.
4833         * amd64-sol2-tdep.c: Revert.
4834         * amd64-obsd-tdep.c: Revert.
4835         * amd64-obsd-nat.c: Revert.
4836         * amd64-nbsd-tdep.c: Revert.
4837         * amd64-nbsd-nat.c: Revert.
4838         * amd64-nat.c: Revert.
4839         * amd64-linux-tdep.c: Revert.
4840         * amd64-linux-nat.c: Revert.
4841         * amd64-fbsd-tdep.c: Revert.
4842         * amd64-fbsd-nat.c: Revert.
4843         * amd64-dicos-tdep.c: Revert.
4844         * amd64-darwin-tdep.c: Revert.
4845         * amd64-bsd-nat.c: Revert.
4846         * alpha-tdep.c: Revert.
4847         * alpha-obsd-tdep.c: Revert.
4848         * alpha-nbsd-tdep.c: Revert.
4849         * alpha-mdebug-tdep.c: Revert.
4850         * alpha-linux-tdep.c: Revert.
4851         * alpha-linux-nat.c: Revert.
4852         * alpha-bsd-tdep.c: Revert.
4853         * alpha-bsd-nat.c: Revert.
4854         * aix-thread.c: Revert.
4855         * agent.c: Revert.
4856         * addrmap.c: Revert.
4857         * ada-varobj.c: Revert.
4858         * ada-valprint.c: Revert.
4859         * ada-typeprint.c: Revert.
4860         * ada-tasks.c: Revert.
4861         * ada-lang.c: Revert.
4862         * aarch64-tdep.c: Revert.
4863         * aarch64-ravenscar-thread.c: Revert.
4864         * aarch64-newlib-tdep.c: Revert.
4865         * aarch64-linux-tdep.c: Revert.
4866         * aarch64-linux-nat.c: Revert.
4867         * aarch64-fbsd-tdep.c: Revert.
4868         * aarch64-fbsd-nat.c: Revert.
4869         * aarch32-linux-nat.c: Revert.
4870
4871 2019-04-05  Tom Tromey  <tom@tromey.com>
4872
4873         * ft32-tdep.c: Sort headers.
4874         * frv-tdep.c: Sort headers.
4875         * frv-linux-tdep.c: Sort headers.
4876         * frame.c: Sort headers.
4877         * frame-unwind.c: Sort headers.
4878         * frame-base.c: Sort headers.
4879         * fork-child.c: Sort headers.
4880         * findvar.c: Sort headers.
4881         * findcmd.c: Sort headers.
4882         * filesystem.c: Sort headers.
4883         * filename-seen-cache.h: Sort headers.
4884         * filename-seen-cache.c: Sort headers.
4885         * fbsd-tdep.c: Sort headers.
4886         * fbsd-nat.h: Sort headers.
4887         * fbsd-nat.c: Sort headers.
4888         * f-valprint.c: Sort headers.
4889         * f-typeprint.c: Sort headers.
4890         * f-lang.c: Sort headers.
4891         * extension.h: Sort headers.
4892         * extension.c: Sort headers.
4893         * extension-priv.h: Sort headers.
4894         * expprint.c: Sort headers.
4895         * exec.h: Sort headers.
4896         * exec.c: Sort headers.
4897         * exceptions.c: Sort headers.
4898         * event-top.c: Sort headers.
4899         * event-loop.c: Sort headers.
4900         * eval.c: Sort headers.
4901         * elfread.c: Sort headers.
4902         * dwarf2read.h: Sort headers.
4903         * dwarf2read.c: Sort headers.
4904         * dwarf2loc.c: Sort headers.
4905         * dwarf2expr.h: Sort headers.
4906         * dwarf2expr.c: Sort headers.
4907         * dwarf2-frame.c: Sort headers.
4908         * dwarf2-frame-tailcall.c: Sort headers.
4909         * dwarf-index-write.h: Sort headers.
4910         * dwarf-index-write.c: Sort headers.
4911         * dwarf-index-common.c: Sort headers.
4912         * dwarf-index-cache.h: Sort headers.
4913         * dwarf-index-cache.c: Sort headers.
4914         * dummy-frame.c: Sort headers.
4915         * dtrace-probe.c: Sort headers.
4916         * disasm.h: Sort headers.
4917         * disasm.c: Sort headers.
4918         * disasm-selftests.c: Sort headers.
4919         * dictionary.c: Sort headers.
4920         * dicos-tdep.c: Sort headers.
4921         * demangle.c: Sort headers.
4922         * dcache.h: Sort headers.
4923         * dcache.c: Sort headers.
4924         * darwin-nat.h: Sort headers.
4925         * darwin-nat.c: Sort headers.
4926         * darwin-nat-info.c: Sort headers.
4927         * d-valprint.c: Sort headers.
4928         * d-namespace.c: Sort headers.
4929         * d-lang.c: Sort headers.
4930         * ctf.c: Sort headers.
4931         * csky-tdep.c: Sort headers.
4932         * csky-linux-tdep.c: Sort headers.
4933         * cris-tdep.c: Sort headers.
4934         * cris-linux-tdep.c: Sort headers.
4935         * cp-valprint.c: Sort headers.
4936         * cp-support.c: Sort headers.
4937         * cp-namespace.c: Sort headers.
4938         * cp-abi.c: Sort headers.
4939         * corelow.c: Sort headers.
4940         * corefile.c: Sort headers.
4941         * continuations.c: Sort headers.
4942         * completer.h: Sort headers.
4943         * completer.c: Sort headers.
4944         * complaints.c: Sort headers.
4945         * coffread.c: Sort headers.
4946         * coff-pe-read.c: Sort headers.
4947         * cli-out.h: Sort headers.
4948         * cli-out.c: Sort headers.
4949         * charset.c: Sort headers.
4950         * c-varobj.c: Sort headers.
4951         * c-valprint.c: Sort headers.
4952         * c-typeprint.c: Sort headers.
4953         * c-lang.c: Sort headers.
4954         * buildsym.c: Sort headers.
4955         * buildsym-legacy.c: Sort headers.
4956         * build-id.h: Sort headers.
4957         * build-id.c: Sort headers.
4958         * btrace.c: Sort headers.
4959         * bsd-uthread.c: Sort headers.
4960         * breakpoint.h: Sort headers.
4961         * breakpoint.c: Sort headers.
4962         * break-catch-throw.c: Sort headers.
4963         * break-catch-syscall.c: Sort headers.
4964         * break-catch-sig.c: Sort headers.
4965         * blockframe.c: Sort headers.
4966         * block.c: Sort headers.
4967         * bfin-tdep.c: Sort headers.
4968         * bfin-linux-tdep.c: Sort headers.
4969         * bfd-target.c: Sort headers.
4970         * bcache.c: Sort headers.
4971         * ax-general.c: Sort headers.
4972         * ax-gdb.h: Sort headers.
4973         * ax-gdb.c: Sort headers.
4974         * avr-tdep.c: Sort headers.
4975         * auxv.c: Sort headers.
4976         * auto-load.c: Sort headers.
4977         * arm-wince-tdep.c: Sort headers.
4978         * arm-tdep.c: Sort headers.
4979         * arm-symbian-tdep.c: Sort headers.
4980         * arm-pikeos-tdep.c: Sort headers.
4981         * arm-obsd-tdep.c: Sort headers.
4982         * arm-nbsd-tdep.c: Sort headers.
4983         * arm-nbsd-nat.c: Sort headers.
4984         * arm-linux-tdep.c: Sort headers.
4985         * arm-linux-nat.c: Sort headers.
4986         * arm-fbsd-tdep.c: Sort headers.
4987         * arm-fbsd-nat.c: Sort headers.
4988         * arm-bsd-tdep.c: Sort headers.
4989         * arch-utils.c: Sort headers.
4990         * arc-tdep.c: Sort headers.
4991         * arc-newlib-tdep.c: Sort headers.
4992         * annotate.h: Sort headers.
4993         * annotate.c: Sort headers.
4994         * amd64-windows-tdep.c: Sort headers.
4995         * amd64-windows-nat.c: Sort headers.
4996         * amd64-tdep.c: Sort headers.
4997         * amd64-sol2-tdep.c: Sort headers.
4998         * amd64-obsd-tdep.c: Sort headers.
4999         * amd64-obsd-nat.c: Sort headers.
5000         * amd64-nbsd-tdep.c: Sort headers.
5001         * amd64-nbsd-nat.c: Sort headers.
5002         * amd64-nat.c: Sort headers.
5003         * amd64-linux-tdep.c: Sort headers.
5004         * amd64-linux-nat.c: Sort headers.
5005         * amd64-fbsd-tdep.c: Sort headers.
5006         * amd64-fbsd-nat.c: Sort headers.
5007         * amd64-dicos-tdep.c: Sort headers.
5008         * amd64-darwin-tdep.c: Sort headers.
5009         * amd64-bsd-nat.c: Sort headers.
5010         * alpha-tdep.c: Sort headers.
5011         * alpha-obsd-tdep.c: Sort headers.
5012         * alpha-nbsd-tdep.c: Sort headers.
5013         * alpha-mdebug-tdep.c: Sort headers.
5014         * alpha-linux-tdep.c: Sort headers.
5015         * alpha-linux-nat.c: Sort headers.
5016         * alpha-bsd-tdep.c: Sort headers.
5017         * alpha-bsd-nat.c: Sort headers.
5018         * aix-thread.c: Sort headers.
5019         * agent.c: Sort headers.
5020         * addrmap.c: Sort headers.
5021         * ada-varobj.c: Sort headers.
5022         * ada-valprint.c: Sort headers.
5023         * ada-typeprint.c: Sort headers.
5024         * ada-tasks.c: Sort headers.
5025         * ada-lang.c: Sort headers.
5026         * aarch64-tdep.c: Sort headers.
5027         * aarch64-ravenscar-thread.c: Sort headers.
5028         * aarch64-newlib-tdep.c: Sort headers.
5029         * aarch64-linux-tdep.c: Sort headers.
5030         * aarch64-linux-nat.c: Sort headers.
5031         * aarch64-fbsd-tdep.c: Sort headers.
5032         * aarch64-fbsd-nat.c: Sort headers.
5033         * aarch32-linux-nat.c: Sort headers.
5034
5035 2019-04-04  Tom Tromey  <tom@tromey.com>
5036
5037         * varobj.c (varobj_create): Update.
5038         * rust-exp.y (struct rust_parser) <update_innermost_block,
5039         lookup_symbol>: New methods.
5040         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5041         Rename.
5042         (rust_parser::rust_lookup_type)
5043         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5044         * printcmd.c (display_command, do_one_display): Update.
5045         * parser-defs.h (struct parser_state) <parser_state>: Add
5046         "tracker" parameter.
5047         (block_tracker): New member.
5048         (class innermost_block_tracker) <innermost_block_tracker>: Add
5049         "types" parameter.
5050         <reset>: Remove method.
5051         (innermost_block): Don't declare.
5052         (null_post_parser): Update.
5053         * parse.c (innermost_block): Remove global.
5054         (write_dollar_variable): Update.
5055         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5056         Remove "tracker_types" parameter.
5057         (parse_expression): Add "tracker" parameter.
5058         (parse_expression_for_completion): Update.
5059         (null_post_parser): Add "tracker" parameter.
5060         * p-exp.y: Update rules.
5061         * m2-exp.y: Update rules.
5062         * language.h (struct language_defn) <la_post_parser>: Add
5063         "tracker" parameter.
5064         * go-exp.y: Update rules.
5065         * f-exp.y: Update rules.
5066         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5067         parameter.
5068         * d-exp.y: Update rules.
5069         * c-exp.y: Update rules.
5070         * breakpoint.c (set_breakpoint_condition): Create an
5071         innermost_block_tracker.
5072         (watch_command_1): Likewise.
5073         * ada-lang.c (resolve): Add "tracker" parameter.
5074         (resolve_subexp): Likewise.
5075         * ada-exp.y (write_var_from_sym): Update.
5076
5077 2019-04-04  Tom Tromey  <tom@tromey.com>
5078
5079         * type-stack.h: New file.
5080         * type-stack.c: New file.
5081         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5082         type-stack.h.
5083         (insert_into_type_stack, insert_type, push_type, push_type_int)
5084         (insert_type_address_space, pop_type, pop_type_int)
5085         (pop_typelist, pop_type_stack, append_type_stack)
5086         (push_type_stack, get_type_stack, push_typelist)
5087         (follow_type_instance_flags, follow_types): Don't declare.
5088         * parse.c (type_stack): Remove global.
5089         (parse_exp_in_context): Update.
5090         (insert_into_type_stack, insert_type, push_type, push_type_int)
5091         (insert_type_address_space, pop_type, pop_type_int)
5092         (pop_typelist, pop_type_stack, append_type_stack)
5093         (push_type_stack, get_type_stack, push_typelist)
5094         (follow_type_instance_flags, follow_types): Remove (moved to
5095         type-stack.c).
5096         * f-exp.y (type_stack): New global.
5097         Update rules.
5098         (push_kind_type, f_parse): Update.
5099         * d-exp.y (type_stack): New global.
5100         Update rules.
5101         (d_parse): Update.
5102         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5103         Update rules.
5104         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5105         (HFILES_NO_SRCDIR): Add type-stack.h.
5106
5107 2019-04-04  Tom Tromey  <tom@tromey.com>
5108
5109         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5110         (rust_parser::convert_ast_to_expression, rust_parse)
5111         (rust_lex_test_completion, rust_lex_tests): Update.
5112         * parser-defs.h (struct expr_completion_state): New.
5113         (struct parser_state) <parser_state>: Add completion parameter.
5114         <mark_struct_expression, mark_completion_tag>: New methods.
5115         <parse_completion, m_completion_state>: New members.
5116         (prefixify_expression, null_post_parser): Update.
5117         (mark_struct_expression, mark_completion_tag): Don't declare.
5118         * parse.c (parse_completion, expout_last_struct)
5119         (expout_tag_completion_type, expout_completion_name): Remove
5120         globals.
5121         (parser_state::mark_struct_expression)
5122         (parser_state::mark_completion_tag): Now methods.
5123         (prefixify_expression): Add last_struct parameter.
5124         (prefixify_subexp): Likewise.
5125         (parse_exp_1): Update.
5126         (parse_exp_in_context): Add cstate parameter.  Update.
5127         (parse_expression_for_completion): Create an
5128         expr_completion_state.
5129         (null_post_parser): Add "completion" parameter.
5130         * p-exp.y: Update rules.
5131         (yylex): Update.
5132         * language.h (struct language_defn) <la_post_parser>: Add
5133         "completing" parameter.
5134         * go-exp.y: Update rules.
5135         (lex_one_token): Update.
5136         * expression.h (parse_completion): Don't declare.
5137         * d-exp.y: Update rules.
5138         (lex_one_token): Update rules.
5139         * c-exp.y: Update rules.
5140         (lex_one_token): Update.
5141         * ada-lang.c (resolve): Add "parse_completion" parameter.
5142         (resolve_subexp): Likewise.
5143         (ada_resolve_function): Likewise.
5144
5145 2019-04-04  Tom Tromey  <tom@tromey.com>
5146
5147         * parser-defs.h (struct parser_state) <start_arglist,
5148         end_arglist>: New methods.
5149         <arglist_len, m_funcall_chain>: New members.
5150         (arglist_len, start_arglist, end_arglist): Don't declare.
5151         * parse.c (arglist_len, funcall_chain): Remove global.
5152         (start_arglist, end_arglist): Remove functions.
5153         (parse_exp_in_context): Update.
5154         * p-exp.y: Update rules.
5155         * m2-exp.y: Update rules.
5156         * go-exp.y: Update rules.
5157         * f-exp.y: Update rules.
5158         * d-exp.y: Update rules.
5159         * c-exp.y: Update rules.
5160
5161 2019-04-04  Tom Tromey  <tom@tromey.com>
5162
5163         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
5164         lex_operator, push_back>: New methods.
5165         Update all rules.
5166         (rust_parser::lex_hex, lex_escape): Rename and update.
5167         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
5168         (rust_parser::lex_operator): Rename and update.
5169         (rust_parser::lex_number, rustyylex, rustyyerror)
5170         (rust_lex_test_init, rust_lex_test_sequence)
5171         (rust_lex_test_push_back, rust_lex_tests): Update.
5172         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
5173         parameter.
5174         <lexptr, prev_lexptr>: New members.
5175         (lexptr, prev_lexptr): Don't declare.
5176         * parse.c (lexptr, prev_lexptr): Remove globals.
5177         (parse_exp_in_context): Update.
5178         * p-exp.y (yylex, yyerror): Update.
5179         * m2-exp.y (parse_number, yylex, yyerror): Update.
5180         * go-exp.y (lex_one_token, yyerror): Update.
5181         * f-exp.y (match_string_literal, yylex, yyerror): Update.
5182         * d-exp.y (lex_one_token, yyerror): Update.
5183         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
5184         (lex_one_token, yyerror): Update.
5185         * ada-lex.l (YY_INPUT): Update.
5186         (rewind_to_char): Update.
5187         * ada-exp.y (yyerror): Update.
5188
5189 2019-04-04  Tom Tromey  <tom@tromey.com>
5190
5191         * rust-exp.y (rustyylex, rust_lex_tests): Update.
5192         * parser-defs.h (struct parser_state) <parser_state>: Add new
5193         parameter.
5194         <comma_terminates>: New member.
5195         (comma_terminates): Don't declare global.
5196         * parse.c (comma_terminates): Remove global.
5197         (parse_exp_in_context): Update.
5198         * p-exp.y (yylex): Update.
5199         * m2-exp.y (yylex): Update.
5200         * go-exp.y (lex_one_token): Update.
5201         * f-exp.y (yylex): Update.
5202         * d-exp.y (lex_one_token): Update.
5203         * c-exp.y (lex_one_token): Update.
5204         * ada-lex.l: Update.
5205
5206 2019-04-04  Tom Tromey  <tom@tromey.com>
5207
5208         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
5209         (rustyylex, rust_lex_test_init, rust_lex_test_one)
5210         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
5211         * parser-defs.h (paren_depth): Don't declare.
5212         * parse.c (paren_depth): Remove global.
5213         (parse_exp_in_context): Update.
5214         * p-exp.y (paren_depth): New global.
5215         (pascal_parse): Initialize it.
5216         * m2-exp.y (paren_depth): New global.
5217         (m2_parse): Initialize it.
5218         * go-exp.y (paren_depth): New global.
5219         (go_parse): Initialize it.
5220         * f-exp.y (paren_depth): New global.
5221         (f_parse): Initialize it.
5222         * d-exp.y (paren_depth): New global.
5223         (d_parse): Initialize it.
5224         * c-exp.y (paren_depth): New global.
5225         (c_parse): Initialize it.
5226         * ada-lex.l (paren_depth): New global.
5227         (lexer_init): Initialize it.
5228
5229 2019-04-04  Tom Tromey  <tom@tromey.com>
5230
5231         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
5232         (rust_parser::convert_ast_to_type)
5233         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5234         * parser-defs.h (struct parser_state) <parser_state>: Add
5235         parameters.  Initialize new members.
5236         <expression_context_block, expression_context_pc>: New members.
5237         * parse.c (expression_context_block, expression_context_pc):
5238         Remove globals.
5239         (parse_exp_in_context): Update.
5240         * p-exp.y: Update all rules.
5241         (yylex): Update.
5242         * m2-exp.y: Update all rules.
5243         (yylex): Update.
5244         * go-exp.y (yylex): Update.
5245         * f-exp.y (yylex): Update.
5246         * d-exp.y: Update all rules.
5247         (yylex): Update.
5248         * c-exp.y: Update all rules.
5249         (lex_one_token, classify_name, yylex, c_parse): Update.
5250         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
5251
5252 2019-04-04  Tom Tromey  <tom@tromey.com>
5253
5254         * gdbarch.h, gdbarch.c: Rebuild.
5255         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
5256         * stap-probe.h:
5257         (struct stap_parse_info): Replace "parser_state" with
5258         "expr_builder".
5259         * parser-defs.h (struct expr_builder): Rename from "parser_state".
5260         (parser_state): New class.
5261         * parse.c (expr_builder): Rename.
5262         (expr_builder::release): Rename.
5263         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
5264         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
5265         (write_exp_elt_longcst, write_exp_elt_floatcst)
5266         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
5267         (write_exp_string_vector, write_exp_bitstring)
5268         (write_exp_msymbol, mark_struct_expression)
5269         (write_dollar_variable)
5270         (insert_type_address_space, increase_expout_size): Replace
5271         "parser_state" with "expr_builder".
5272         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
5273         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
5274         "parser_state" with "expr_builder".
5275
5276 2019-04-04  Tom Tromey  <tom@tromey.com>
5277
5278         * rust-exp.y: Replace "parse_language" with method call.
5279         * p-exp.y:
5280         (yylex): Replace "parse_language" with method call.
5281         * m2-exp.y:
5282         (yylex): Replace "parse_language" with method call.
5283         * go-exp.y (classify_name): Replace "parse_language" with method
5284         call.
5285         * f-exp.y (yylex): Replace "parse_language" with method call.
5286         * d-exp.y (lex_one_token): Replace "parse_language" with method
5287         call.
5288         * c-exp.y:
5289         (lex_one_token, classify_name, yylex): Replace "parse_language"
5290         with method call.
5291         * ada-exp.y (find_primitive_type, type_char)
5292         (type_system_address): Replace "parse_language" with method call.
5293
5294 2019-04-04  Tom Tromey  <tom@tromey.com>
5295
5296         * rust-exp.y: Replace "parse_gdbarch" with method call.
5297         * parse.c (write_dollar_variable, insert_type_address_space):
5298         Replace "parse_gdbarch" with method call.
5299         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
5300         call.
5301         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
5302         call.
5303         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
5304         "parse_gdbarch" with method call.
5305         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
5306         with method call.
5307         * f-exp.y (parse_type, parse_f_type, yylex): Replace
5308         "parse_gdbarch" with method call.
5309         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
5310         "parse_gdbarch" with method call.
5311         * c-exp.y (parse_type, parse_number, classify_name): Replace
5312         "parse_gdbarch" with method call.
5313         * ada-lex.l: Replace "parse_gdbarch" with method call.
5314         * ada-exp.y (parse_type, find_primitive_type, type_char)
5315         (type_system_address): Replace "parse_gdbarch" with method call.
5316
5317 2019-04-04  Tom Tromey  <tom@tromey.com>
5318
5319         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
5320         * stap-probe.c (stap_parse_argument): Update.
5321         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
5322         initial_size parameter.
5323         * rust-exp.y (rust_lex_tests): Update.
5324         * parse.c (parser_state): Update.
5325         (parse_exp_in_context): Update.
5326         * parser-defs.h (struct parser_state) <parser_state>: Remove
5327         "initial_size" parameter.
5328
5329 2019-04-04  Tom Tromey  <tom@tromey.com>
5330
5331         * parser-defs.h (increase_expout_size): Don't declare.
5332         * parse.c (increase_expout_size): Now static.
5333
5334 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
5335
5336         * gnu-nat.c (gnu_nat_target::wait): Fix
5337         target_waitstatus_to_string call.
5338
5339 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5340
5341         * eval.c (evaluate_subexp_standard): Handle internal functions
5342         during Fortran function call handling.
5343
5344 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5345
5346         * NEWS: Mention new internal functions.
5347         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
5348         (read_base_type): Use dwarf2_init_complex_target_type.
5349         * value.c (creal_internal_fn): New function.
5350         (cimag_internal_fn): New function.
5351         (_initialize_values): Register new internal functions.
5352
5353 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5354
5355         * infrun.c (stop_all_threads): If debug_infrun, always
5356         trace the wait status after wait_one, using
5357         target_waitstatus_to_string and target_pid_to_str.
5358         (handle_inferior_event): Replace various trace of
5359         wait status kind by a single trace.
5360         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
5361         wait status kind image by target_waitstatus_to_string.
5362         * target/waitstatus.c (target_waitstatus_to_string): Fix
5363         obsolete comment.
5364
5365 2019-04-01  Tom Tromey  <tromey@adacore.com>
5366
5367         PR symtab/23331:
5368         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
5369
5370 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5371             Pedro Alves  <palves@redhat.com>
5372
5373         * top.c (quit_force): Call 'finalize_values'.
5374         * value.c (finalize_values): New function.
5375         * value.h (finalize_values): Declare.
5376
5377 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
5378
5379         * NEWS: Announce $_gdb_major and $_gdb_minor.
5380
5381         * top.c (init_gdb_version_vars): New function.
5382         (gdb_init): Call init_gdb_version_vars.
5383
5384 2019-03-29  Tom Tromey  <tromey@adacore.com>
5385
5386         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
5387         help text.  Remove dead code.
5388
5389 2019-03-29  Keith Seitz  <keiths@redhat.com>
5390
5391         From Siddhesh Poyarekar:
5392         * f-lang.h (f77_get_upperbound): Return LONGEST.
5393         (f77_get_lowerbound): Likewise.
5394         * f-typeprint.c (f_type_print_varspec_suffix): Expand
5395         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
5396         print them.
5397         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
5398         plongest to format print it.
5399         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
5400         (f77_get_upperbound): Likewise.
5401         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
5402         LOWER_BOUND to LONGEST.
5403         (f77_create_arrayprint_offset_tbl): Likewise.
5404
5405 2019-03-29  Keith Seitz  <keiths@redhat.com>
5406
5407         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
5408         %s/pulongest for TYPE_LENGTH instead of %d in format
5409         strings.
5410         * ada-typerint.c (ada_print_type): Likewise.
5411         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
5412         * compile/compile-c-support.c (generate_register_struct): Likewise.
5413         * gdbtypes.c (recursive_dump_type): Likewise.
5414         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
5415         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
5416         instead of %d in format strings.
5417         * riscv-tdep.c (riscv_type_alignment): Cast second argument
5418         to std::min to ULONGEST.
5419         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
5420         instead of %d in format strings.
5421         * tracepoint.c (info_scope_command): Likewise.
5422         * typeprint.c (print_offset_data::update)
5423         (print_offset_data::finish): Likewise.
5424         * xtensa-tdep.c (xtensa_store_return_value)
5425         (xtensa_push_dummy_call): Likewise.
5426
5427 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
5428
5429         * windows-nat.c (display_selector): Fixed format specifications
5430         for 64-bit Cygwin.
5431
5432 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5433
5434         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
5435
5436 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
5437
5438         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
5439         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
5440         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
5441         (nios2_linux_init_abi): Install it.
5442
5443 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5444
5445         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
5446
5447 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5448
5449         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
5450
5451 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5452             Tom Tromey  <tromey@adacore.com>
5453
5454         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
5455
5456 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
5457
5458         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
5459         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
5460         method to compute the bounds of range types. Also print "[evaluated]"
5461         if the bounds' values come from a dynamic evaluation.
5462
5463 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5464
5465         * cp-valprint.c (cp_print_value_fields): Don't print trailing
5466         whitespace when pretty printing is on.
5467
5468 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5469
5470         * ppc-linux-nat.c: Add include.
5471
5472 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5473
5474         * NEWS: Mention AArch64 Pointer Authentication.
5475
5476 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5477
5478         * arm-linux-nat.c: Add include.
5479
5480 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
5481
5482         * source-cache.c (source_cache::get_source_lines): Re-read
5483         fullname after calling open_source_file.
5484
5485 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
5486
5487         * NEWS: Mention TLS support for FreeBSD.
5488
5489 2019-03-25  Tom Tromey  <tromey@adacore.com>
5490
5491         * minsyms.c (BUNCH_SIZE): Update comment.
5492         (~minimal_symbol_reader): Remove old comment.
5493         (compact_minimal_symbols): Update comment.
5494         (minimal_symbol_reader::install): Remove old comment.  Update
5495         other comments.
5496
5497 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5498
5499         * s390-linux-nat.c: Add include.
5500
5501 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5502
5503         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5504         Call linux_get_hwcap.
5505         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
5506         Likewise.
5507         (aarch64_linux_get_hwcap): Remove function.
5508         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
5509         declaration.
5510         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
5511         linux_get_hwcap.
5512         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5513         * linux-tdep.c (linux_get_hwcap): Add function.
5514         (linux_get_hwcap2): Likewise.
5515         * linux-tdep.h (linux_get_hwcap): Add declaration.
5516         (linux_get_hwcap2): Likewise.
5517         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
5518         (ppc_linux_get_hwcap2): Likewise.
5519         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
5520         linux_get_hwcap.
5521         (ppc_linux_nat_target::insert_watchpoint): Likewise.
5522         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
5523         (ppc_linux_nat_target::read_description): Likewise.
5524         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
5525         * s390-linux-nat.c: Likewise.
5526         * s390-linux-tdep.c (s390_core_read_description): Likewise.
5527
5528 2019-03-24  Tom Tromey  <tom@tromey.com>
5529
5530         * ada-lang.c (standard_lookup): Simplify initialization.
5531         (ada_lookup_symbol_nonlocal): Simplify return.
5532         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
5533         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
5534         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
5535         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
5536         initialization.
5537         * solib.c (solib_global_lookup): Simplify.
5538         * symtab.c (null_block_symbol): Remove.
5539         (symbol_cache_lookup): Simplify returns.
5540         (lookup_language_this): Simplify returns.
5541         (lookup_symbol_aux): Simplify return.
5542         (lookup_local_symbol): Simplify returns.
5543         (lookup_global_symbol_from_objfile): Simplify return.
5544         (lookup_symbol_in_objfile_symtabs)
5545         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
5546         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
5547         (lookup_static_symbol, lookup_global_symbol): Simplify return.
5548         * cp-namespace.c (cp_lookup_bare_symbol)
5549         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
5550         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
5551         (cp_lookup_nested_symbol): Don't use null_block_symbol.
5552         (cp_lookup_symbol_via_imports): Simplify initialization.
5553         (find_symbol_in_baseclass): Likewise.
5554         * symtab.h (null_block_symbol): Remove.
5555         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
5556         (d_lookup_nested_symbol, d_lookup_symbol_imports)
5557         (d_lookup_symbol_module): Likewise.
5558         (find_symbol_in_baseclass): Simplify initialization.
5559
5560 2019-03-24  Tom Tromey  <tom@tromey.com>
5561
5562         * expression.h: Don't include symtab.h.
5563         (struct block): Forward declare.
5564
5565 2019-03-24  Tom Tromey  <tom@tromey.com>
5566
5567         * c-exp.y (typebase): Remove casts.
5568         * gdbtypes.c (lookup_unsigned_typename, )
5569         (lookup_signed_typename): Remove cast.
5570         * eval.c (parse_to_comma_and_eval): Remove cast.
5571         * parse.c (write_dollar_variable): Remove cast.
5572         * block.h (struct block) <superblock>: Now const.
5573         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
5574         * psymtab.c (psym_map_matching_symbols): Make "block" const.
5575         (map_block): Make "block" const.
5576         * symfile.h (struct quick_symbol_functions)
5577         <map_matching_symbols>: Constify block argument to "callback".
5578         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
5579         const.
5580         (find_pc_sect_compunit_symtab): Make "b" const.
5581         (find_symbol_at_address): Likewise.
5582         (search_symbols): Likewise.
5583         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
5584         (dw2_debug_names_lookup_symbol): Likewise.
5585         (dw2_map_matching_symbols): Update.
5586         * p-valprint.c (pascal_val_print): Remove "block".
5587         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
5588         (aux_add_nonlocal_symbols): Make "block" const.
5589         (resolve_subexp): Remove cast.
5590         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
5591         const.
5592         (iterate_over_file_blocks): Likewise.
5593         * f-exp.y (%union) <bval>: Remove.
5594         * coffread.c (patch_opaque_types): Make "b" const.
5595         * spu-tdep.c (spu_catch_start): Make "block" const.
5596         * c-valprint.c (print_unpacked_pointer): Remove "block".
5597         * symmisc.c (dump_symtab_1): Make "b" const.
5598         (block_depth): Make "block" const.
5599         * d-exp.y (%union) <bval>: Remove.
5600         * cp-support.h (cp_lookup_rtti_type): Update.
5601         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
5602         * psymtab.c (psym_lookup_symbol): Make "block" const.
5603         (maintenance_check_psymtabs): Make "b" const.
5604         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
5605         (enumerate_locals, enumerate_args): Update.
5606         * python/py-symtab.c (stpy_global_block): Make "block" const.
5607         (stpy_static_block): Likewise.
5608         * inline-frame.c (block_starting_point_at): Make "new_block"
5609         const.
5610         * block.c (find_block_in_blockvector): Make return type const.
5611         (blockvector_for_pc_sect): Make "b" const.
5612         (find_block_in_blockvector): Make "b" const.
5613
5614 2019-03-23  Tom Tromey  <tom@tromey.com>
5615
5616         * varobj.c (varobj_create): Update.
5617         * symfile.c (clear_symtab_users): Don't reset innermost_block.
5618         * printcmd.c (display_command, do_one_display): Don't reset
5619         innermost_block.
5620         * parser-defs.h (enum innermost_block_tracker_type): Move to
5621         expression.h.
5622         (innermost_block): Update comment.
5623         * parse.c (parse_exp_1): Add tracker_types parameter.
5624         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
5625         tracker_types parameter.  Reset innermost_block.
5626         (parse_exp_in_context): Remove.
5627         (parse_expression_for_completion): Update.
5628         * objfiles.c (~objfile): Don't reset expression_context_block or
5629         innermost_block.
5630         * expression.h (enum innermost_block_tracker_type): Move from
5631         parser-defs.h.
5632         (parse_exp_1): Add tracker_types parameter.
5633         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
5634         reset innermost_block.
5635
5636 2019-03-23  Tom Tromey  <tom@tromey.com>
5637
5638         * objfiles.h: Include bcache.h.
5639
5640 2019-03-23  Tom Tromey  <tom@tromey.com>
5641
5642         * linespec.c (get_current_search_block): Use
5643         scoped_restore_current_language.
5644         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
5645
5646 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5647             Jiong Wang  <jiong.wang@arm.com>
5648
5649         * aarch64-linux-tdep.c
5650         (aarch64_linux_iterate_over_regset_sections): Check for pauth
5651         section.
5652         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
5653
5654 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5655             Jiong Wang  <jiong.wang@arm.com>
5656
5657         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
5658         instructions.
5659         (aarch64_analyze_prologue_test): Add PACIASP test.
5660         (aarch64_prologue_prev_register): Unmask PC value.
5661
5662 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5663             Jiong Wang  <jiong.wang@arm.com>
5664
5665         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
5666         (aarch64_dwarf2_prev_register): Unmask PC value.
5667         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
5668         (aarch64_execute_dwarf_cfa_vendor_op): Check for
5669         DW_CFA_AARCH64_negate_ra_state.
5670         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
5671
5672 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5673             Jiong Wang  <jiong.wang@arm.com>
5674
5675         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
5676         registers.
5677         (aarch64_pseudo_register_name): Likewise.
5678         (aarch64_pseudo_register_type): Likewise.
5679         (aarch64_pseudo_register_reggroup_p): Likewise.
5680         (aarch64_gdbarch_init): Add pauth registers.
5681         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
5682         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
5683         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
5684         (struct gdbarch_tdep): Add regnum for ra_state.
5685
5686 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5687             Jiong Wang  <jiong.wang@arm.com>
5688
5689         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
5690
5691 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5692             Jiong Wang  <jiong.wang@arm.com>
5693
5694         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
5695         function.
5696         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
5697         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
5698         (aarch64_gdbarch_init): Add puth registers.
5699         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
5700         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
5701         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
5702
5703 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5704             Jiong Wang  <jiong.wang@arm.com>
5705
5706         * aarch64-linux-nat.c
5707         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
5708         * aarch64-linux-tdep.c
5709         (aarch64_linux_core_read_description): Likewise.
5710         (aarch64_linux_get_hwcap): New function.
5711         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
5712         (aarch64_linux_get_hwcap): New declaration.
5713
5714 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5715             Jiong Wang  <jiong.wang@arm.com>
5716
5717         * aarch64-linux-nat.c
5718         (aarch64_linux_nat_target::read_description): Add pauth param.
5719         * aarch64-linux-tdep.c
5720         (aarch64_linux_core_read_description): Likewise.
5721         * aarch64-tdep.c (struct target_desc): Add in pauth.
5722         (aarch64_read_description): Add pauth param.
5723         (aarch64_gdbarch_init): Likewise.
5724         * aarch64-tdep.h (aarch64_read_description): Likewise.
5725         * arch/aarch64.c (aarch64_create_target_description): Likewise.
5726         * arch/aarch64.h (aarch64_create_target_description): Likewise.
5727         * features/Makefile: Add new files.
5728         * features/aarch64-pauth.c: New file.
5729         * features/aarch64-pauth.xml: New file.
5730
5731 2019-03-20  Tom Tromey  <tromey@adacore.com>
5732
5733         * infrun.c (handle_inferior_event): Rename from
5734         handle_inferior_event_1.  Create a scoped_value_mark.
5735         (handle_inferior_event): Remove.
5736
5737 2019-03-19  Tom Tromey  <tromey@adacore.com>
5738
5739         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
5740         * infrun.h (print_stop_event): Add "displays" parameter.
5741         * infrun.c (print_stop_event): Add "displays" parameter.
5742
5743 2019-03-19  Pedro Alves  <palves@redhat.com>
5744
5745         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
5746         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
5747         to -1.  Fix TABs vs spaces.
5748         (tui_ui_out::tui_ui_out): Don't initialize fields here.
5749         * tui/tui-out.h (tui_ui_out) Add intro comments.
5750         <m_line, m_start_of_line>: In-class initialize, and add describing
5751         comment.
5752
5753 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
5754
5755         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
5756         variable names.
5757         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
5758
5759 2019-03-18  Pedro Alves  <palves@redhat.com>
5760             Eli Zaretskii <eliz@gnu.org>
5761
5762         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
5763         m_line and m_start_of_line.
5764
5765 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
5766
5767         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
5768         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
5769         it returns a newline.  This fixes a regression in TU mode, whereby
5770         the next line is output on the same screen line as the user input.
5771
5772 2019-03-18  Tom Tromey  <tromey@adacore.com>
5773
5774         * minsyms.c (minimal_symbol_reader::install): Remove call to
5775         obstack_blank.
5776
5777 2019-03-18  Pedro Alves  <palves@redhat.com>
5778
5779         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
5780         New globals.
5781         (apply_style): New, factored out from ...
5782         (apply_ansi_escape): ... this.  Handle reverse video mode.
5783         (tui_set_reverse_mode): New function.
5784         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
5785         * tui/tui-winsource.c (tui_show_source_line): Use
5786         tui_set_reverse_mode instead of setting A_STANDOUT.
5787         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
5788         New setter methods.
5789
5790 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
5791
5792         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
5793         Handle tabs.
5794
5795 2019-03-18  Tom Tromey  <tromey@adacore.com>
5796
5797         * ada-lang.c (empty_array): Add "high" parameter.
5798         (ada_evaluate_subexp): Update.
5799
5800 2019-03-17  Sergei Trofimovich <siarheit@google.com>
5801
5802         * unittests/string_view-selftests.c: Define
5803         _initialize_string_view_selftests unconditionally.
5804
5805 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5806
5807         PR gdb/24350
5808         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
5809
5810 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5811
5812         PR gdb/24351
5813         * windows-nat.c (display_selector): Fix format specifiers.
5814
5815 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
5816
5817         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
5818         tui_refill_source_window instead of tui_refresh_win, to update the
5819         current execution line.  This fixes redisplay of the current line
5820         when stepping through the code with "next" or "step".
5821
5822 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5823
5824         * source-cache.c (source_cache::get_source_lines): Call
5825         find_source_lines to initialize s->nlines.  This fixes vertical
5826         scrolling of TUI source window when the DOWN arrow is pressed.
5827
5828 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5829
5830         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
5831         linux-thread-db.c (_initialize_thread_db): Likewise.
5832
5833 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5834
5835         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
5836         wclrtoeol in tui_show_source_line".  This reverts changes made in
5837         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
5838
5839 2019-03-15  Tom Tromey  <tom@tromey.com>
5840
5841         * symtab.h (struct minimal_symbol): Derive from
5842         general_symbol_info.
5843         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
5844         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
5845         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
5846         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
5847         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
5848         (MSYMBOL_SEARCH_NAME): Update.
5849         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
5850         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
5851         * minsyms.c (minimal_symbol_reader::record_full): Update.
5852
5853 2019-03-15  Tom Tromey  <tom@tromey.com>
5854
5855         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
5856
5857 2019-03-15  Tom Tromey  <tom@tromey.com>
5858
5859         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
5860         unique_xmalloc_ptr.
5861         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
5862         Update.
5863         * minsyms.c (lookup_minimal_symbol_by_pc_section)
5864         (build_minimal_symbol_hash_tables)
5865         (minimal_symbol_reader::install): Update.
5866
5867 2019-03-15  Tom Tromey  <tom@tromey.com>
5868
5869         * symtab.c (create_demangled_names_hash): Update.
5870         (symbol_set_names): Update.
5871         * objfiles.h (struct objfile_per_bfd_storage)
5872         <demangled_names_hash>: Now an htab_up.
5873         * objfiles.c (objfile_per_bfd_storage): Simplify.
5874
5875 2019-03-15  Tom Tromey  <tom@tromey.com>
5876
5877         * objfiles.h (struct objfile_per_bfd_storage): Declare
5878         destructor.
5879         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
5880         New.
5881         (get_objfile_bfd_data): Use new.  Don't initialize
5882         language_of_main.
5883         (free_objfile_per_bfd_storage): Remove.
5884         (objfile_bfd_data_free, objfile::~objfile): Use delete.
5885
5886 2019-03-15  Tom Tromey  <tom@tromey.com>
5887
5888         * symfile.c (reread_symbols): Update.
5889         * objfiles.c (objfile::objfile): Update.
5890         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
5891         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
5892         comment.
5893         (minimal_symbol_reader::install): Update.
5894         (terminate_minimal_symbol_table): Remove.
5895         * jit.c (jit_object_close_impl): Update.
5896
5897 2019-03-15  Tom Tromey  <tom@tromey.com>
5898
5899         * minsyms.c (minimal_symbol_reader::record_full): Remove some
5900         initializations.
5901
5902 2019-03-15  Tom Tromey  <tom@tromey.com>
5903
5904         * objfiles.h (struct objfile_per_bfd_storage)
5905         <demangled_hash_languages>: Now a bitset.
5906         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
5907         (lookup_minimal_symbol): Update.
5908
5909 2019-03-15  Tom Tromey  <tom@tromey.com>
5910
5911         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
5912         Don't return the symbol.
5913         * coffread.c (record_minimal_symbol): Use record_full.
5914
5915 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
5916
5917         The MS-Windows port of ncurses fails to switch to a color pair if
5918         one or both of the colors are the implicit default colors.  This
5919         change records the default colors when TUI is initialized, and
5920         then specifies them explicitly when a color pair uses the default
5921         colors.  This allows color styling in TUI mode on MS-Windows.
5922
5923         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
5924         ncurses_norm_attr.
5925         (tui_initialize_io) [__MINGW32__]: Record the default terminal
5926         colors in ncurses_norm_attr.
5927         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
5928         "none", replace it with the default color recorded in
5929         ncurses_norm_attr.
5930
5931 2019-03-14  Tom Tromey  <tromey@adacore.com>
5932
5933         * source-cache.h (class source_cache) <get_source_lines>: Return
5934         std::string.
5935         * source-cache.c (source_cache::extract_lines): Handle case where
5936         first_pos==npos.  Return std::string.
5937         (source_cache::get_source_lines): Update.
5938
5939 2019-03-14  Tom Tromey  <tromey@adacore.com>
5940
5941         * NEWS: Add item for "style sources" commands.
5942         * source-cache.c (source_cache::get_source_lines): Check
5943         source_styling.
5944         * cli/cli-style.c (source_styling): New global.
5945         (_initialize_cli_style): Add "style sources" commands.
5946         (show_style_sources): New function.
5947         * cli/cli-style.h (source_styling): Declare.
5948
5949 2019-03-14  Pedro Alves  <palves@redhat.com>
5950             Tom Tromey  <tromey@adacore.com>
5951
5952         * tui/tui-winsource.h (tui_refill_source_window): Declare.
5953         * tui/tui-winsource.c (tui_refill_source_window): New function,
5954         from...
5955         (tui_horizontal_source_scroll): ... here.  Move some logic.
5956         * cli/cli-style.c (set_style_enabled): Notify new observable.
5957         * tui/tui-hooks.c (tui_redisplay_source): New function.
5958         (tui_attach_detach_observers): Attach or detach
5959         tui_redisplay_source.
5960         * observable.h (source_styling_changed): New observable.
5961         * observable.c: Define source_styling_changed observable.
5962
5963 2019-03-13  Tom Tromey  <tromey@adacore.com>
5964
5965         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
5966         (i386_gnu_nat_target::store_registers): Update.
5967         * target-debug.h (target_debug_print_std_string): New macro.
5968         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5969         * windows-tdep.c (display_one_tib): Update.
5970         * tui/tui-stack.c (tui_make_status_line): Update.
5971         * top.c (print_inferior_quit_action): Update.
5972         * thread.c (thr_try_catch_cmd): Update.
5973         (add_thread_with_info): Update.
5974         (thread_target_id_str): Update.
5975         (thr_try_catch_cmd): Update.
5976         (thread_command): Update.
5977         (thread_find_command): Update.
5978         * record-btrace.c (record_btrace_target::info_record)
5979         (record_btrace_resume_thread, record_btrace_target::resume)
5980         (record_btrace_cancel_resume, record_btrace_step_thread)
5981         (record_btrace_target::wait, record_btrace_target::wait)
5982         (record_btrace_target::wait, record_btrace_target::stop): Update.
5983         * progspace.c (print_program_space): Update.
5984         * process-stratum-target.c
5985         (process_stratum_target::thread_address_space): Update.
5986         * linux-fork.c (linux_fork_mourn_inferior)
5987         (detach_checkpoint_command, info_checkpoints_command)
5988         (linux_fork_context): Update.
5989         (linux_fork_detach): Update.
5990         (class scoped_switch_fork_info): Update.
5991         (delete_checkpoint_command): Update.
5992         * infrun.c (follow_fork_inferior): Update.
5993         (follow_fork_inferior): Update.
5994         (proceed_after_vfork_done): Update.
5995         (handle_vfork_child_exec_or_exit): Update.
5996         (follow_exec): Update.
5997         (displaced_step_prepare_throw): Update.
5998         (displaced_step_restore): Update.
5999         (start_step_over): Update.
6000         (resume_1): Update.
6001         (clear_proceed_status_thread): Update.
6002         (proceed): Update.
6003         (print_target_wait_results): Update.
6004         (do_target_wait): Update.
6005         (context_switch): Update.
6006         (stop_all_threads): Update.
6007         (restart_threads): Update.
6008         (finish_step_over): Update.
6009         (handle_signal_stop): Update.
6010         (switch_back_to_stepped_thread): Update.
6011         (keep_going_pass_signal): Update.
6012         (print_exited_reason): Update.
6013         (normal_stop): Update.
6014         * inferior.c (inferior_pid_to_str): Change return type.
6015         (print_selected_inferior): Update.
6016         (add_inferior): Update.
6017         (detach_inferior): Update.
6018         * dummy-frame.c (fprint_dummy_frames): Update.
6019         * dcache.c (dcache_info_1): Update.
6020         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6021         (btrace_fetch, btrace_clear): Update.
6022         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6023         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6024         type.
6025         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6026         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6027         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6028         * gdbarch.c, gdbarch.h: Rebuild.
6029         * gdbarch.sh (core_pid_to_str): Change return type.
6030         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6031         return type.
6032         (windows_nat_target::pid_to_str): Change return type.
6033         (windows_delete_thread): Update.
6034         (windows_nat_target::attach): Update.
6035         (windows_nat_target::files_info): Update.
6036         * target-delegates.c: Rebuild.
6037         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6038         return type.
6039         (sol_thread_target::pid_to_str): Change return type.
6040         * remote.c (class remote_target) <pid_to_str>: Change return
6041         type.
6042         (remote_target::pid_to_str): Change return type.
6043         (extended_remote_target::attach, remote_target::remote_stop_ns)
6044         (remote_target::remote_notif_remove_queued_reply)
6045         (remote_target::push_stop_reply, remote_target::disable_btrace):
6046         Update.
6047         (extended_remote_target::attach): Update.
6048         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6049         type.
6050         (gdbsim_target::pid_to_str): Change return type.
6051         * ravenscar-thread.c (struct ravenscar_thread_target)
6052         <pid_to_str>: Change return type.
6053         (ravenscar_thread_target::pid_to_str): Change return type.
6054         * procfs.c (class procfs_target) <pid_to_str>: Change return
6055         type.
6056         (procfs_target::pid_to_str): Change return type.
6057         (procfs_target::attach): Update.
6058         (procfs_target::detach): Update.
6059         (procfs_target::fetch_registers): Update.
6060         (procfs_target::store_registers): Update.
6061         (procfs_target::wait): Update.
6062         (procfs_target::files_info): Update.
6063         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6064         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6065         return type.
6066         (nto_procfs_target::pid_to_str): Change return type.
6067         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6068         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6069         return type.
6070         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6071         (exit_lwp): Update.
6072         (attach_proc_task_lwp_callback, get_detach_signal)
6073         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6074         (linux_nat_target::resume, wait_lwp, stop_callback)
6075         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6076         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6077         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6078         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6079         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6080         type.
6081         (inf_ptrace_target::attach): Update.
6082         (inf_ptrace_target::files_info): Update.
6083         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6084         type.
6085         (go32_nat_target::pid_to_str): Change return type.
6086         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6087         (gnu_nat_target::wait): Update.
6088         (gnu_nat_target::wait): Update.
6089         (gnu_nat_target::resume): Update.
6090         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6091         (fbsd_nat_target::wait): Update.
6092         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6093         type.
6094         (darwin_nat_target::attach): Update.
6095         * corelow.c (class core_target) <pid_to_str>: Change return type.
6096         (core_target::pid_to_str): Change return type.
6097         * target.c (normal_pid_to_str): Change return type.
6098         (default_pid_to_str): Likewise.
6099         (target_pid_to_str): Change return type.
6100         (target_translate_tls_address): Update.
6101         (target_announce_detach): Update.
6102         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6103         return type.
6104         (bsd_uthread_target::pid_to_str): Change return type.
6105         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6106         type.
6107         (bsd_kvm_target::pid_to_str): Change return type.
6108         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6109         return type.
6110         (aix_thread_target::pid_to_str): Change return type.
6111         * target.h (struct target_ops) <pid_to_str>: Change return type.
6112         (target_pid_to_str, normal_pid_to_str): Likewise.
6113         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6114         type.
6115         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6116         type.
6117         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6118         return type.
6119         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6120         type.
6121         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6122         type.
6123         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6124         return type.
6125
6126 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6127
6128         * NEWS: Mention that the new default MI version is 3.  Mention
6129         changes to the output of commands and events that deal with
6130         multi-location breakpoints.
6131         * breakpoint.c: Include "mi/mi-out.h".
6132         (print_one_breakpoint): Change output syntax if using MI version
6133         >= 3.
6134         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6135         New.
6136         (mi_multi_location_breakpoint_output_fixed): New.
6137         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6138         (mi_cmd_fix_multi_location_breakpoint_output): New.
6139         (mi_multi_location_breakpoint_output_fixed): New.
6140         * mi/mi-cmds.c (mi_cmds): Register command
6141         -fix-multi-location-breakpoint-output.
6142         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6143         interpreter "mi".
6144
6145 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6146
6147         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6148         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6149         instantiate mi_ui_out based on interpreter name.
6150         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6151         * mi/mi-main.c (mi_load_progress): Likewise.
6152
6153 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6154
6155         * NEWS: Combine separate "New targets" sections for 8.3.
6156
6157 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6158
6159         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6160         (ppcfbsd_init_abi): Install gdbarch
6161         "fetch_tls_load_module_address" and "get_thread_local_address"
6162         methods.
6163
6164 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6165
6166         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
6167         (riscv_fbsd_init_abi): Install gdbarch
6168         "fetch_tls_load_module_address" and "get_thread_local_address"
6169         methods.
6170
6171 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6172
6173         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
6174         (i386fbsd_init_abi): Install gdbarch
6175         "fetch_tls_load_module_address" and "get_thread_local_address"
6176         methods.
6177
6178 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6179
6180         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
6181         (amd64fbsd_init_abi): Install gdbarch
6182         "fetch_tls_load_module_address" and "get_thread_local_address"
6183         methods.
6184
6185 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6186
6187         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
6188         (struct fbsd_pspace_data): New type.
6189         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
6190         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
6191         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
6192         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
6193         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
6194
6195 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6196
6197         * gdbtypes.c (lookup_struct_elt): New function.
6198         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
6199         * gdbtypes.h (struct struct_elt): New type.
6200         (lookup_struct_elt): New prototype.
6201
6202 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6203
6204         * gdbtypes.c (lookup_struct_elt_type): Update comment and
6205         remove disabled code block.
6206
6207 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6208
6209         * gdbarch.sh (get_thread_local_address): New method.
6210         * gdbarch.h, gdbarch.c: Regenerate.
6211         * target.c (target_translate_tls_address): Use
6212         gdbarch_get_thread_local_address if present instead of
6213         target::get_thread_local_address.
6214
6215 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6216
6217         * target.h (target::get_thread_local_address): Update comment.
6218
6219 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6220
6221         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
6222         objfile->separate_debug_objfile_backlink if not NULL.
6223
6224 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6225
6226         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6227         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
6228         (amd64bsd_store_inferior_registers): Likewise.
6229         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6230         Enable segment base registers.
6231         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
6232         PT_GETFSBASE and PT_GETGSBASE.
6233         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
6234         PT_SETGSBASE.
6235         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
6236         segment base registers.
6237         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6238
6239 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6240
6241         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6242         Update calls to i386_target_description to add 'segments'
6243         parameter.
6244         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
6245         add segment base registers.
6246         * arch/i386.c (i386_create_target_description): Add 'segments'
6247         parameter to enable segment base registers.
6248         * arch/i386.h (i386_create_target_description): Likewise.
6249         * features/i386/32bit-segments.xml: New file.
6250         * features/i386/32bit-segments.c: Generate.
6251         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
6252         call to i386_target_description to add 'segments' parameter.
6253         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6254         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
6255         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
6256         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
6257         if feature is present.
6258         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
6259         Add 'segments' parameter to call to i386_target_description.
6260         (i386_target_description): Add 'segments' parameter to enable
6261         segment base registers.
6262         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
6263         to call to i386_target_description.
6264         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
6265         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
6266         Define I386_NUM_REGS.
6267         (i386_target_description): Add 'segments' parameter to enable
6268         segment base registers.
6269
6270 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
6271
6272         PR/24325
6273         * source-cache.c: #undef open and close, to avoid unresolved
6274         externals during linking.
6275
6276 2019-03-12  Tom Tromey  <tromey@adacore.com>
6277
6278         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
6279         const.  Add initializers.
6280         (_initialize_remote): Don't initialize ptid globals.
6281
6282 2019-03-12  Pedro Alves  <palves@redhat.com>
6283
6284         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
6285
6286 2019-03-12  Pedro Alves  <palves@redhat.com>
6287
6288         * cp-name-parser.y (main): Remove unused 'len' variable.
6289
6290 2019-03-12  Tom Tromey  <tromey@adacore.com>
6291
6292         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
6293         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
6294
6295 2019-03-12  Tom Tromey  <tromey@adacore.com>
6296
6297         * linux-nat.c (iterate_over_lwps): Update.
6298         (stop_callback): Remove parameter.
6299         (stop_wait_callback, detach_callback, resume_set_callback)
6300         (select_singlestep_lwp_callback, set_ignore_sigint)
6301         (status_callback, resumed_callback, resume_clear_callback)
6302         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
6303         data parameter.
6304         (linux_nat_target::detach, linux_nat_target::resume)
6305         (linux_stop_and_wait_all_lwps, select_event_lwp)
6306         (linux_nat_filter_event, linux_nat_wait_1)
6307         (linux_nat_target::kill, linux_nat_target::stop)
6308         (linux_nat_target::stop): Update.
6309         (linux_nat_resume_callback): Change type.
6310         (resume_stopped_resumed_lwps, count_events_callback)
6311         (select_event_lwp_callback): Likewise.
6312         (linux_stop_lwp, linux_nat_stop_lwp): Update.
6313         * arm-linux-nat.c (struct update_registers_data): Remove.
6314         (update_registers_callback): Change type.
6315         (arm_linux_insert_hw_breakpoint1): Update.
6316         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
6317         parameter.
6318         (x86_linux_dr_set_addr): Update.
6319         (x86_linux_dr_set_control): Update.
6320         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
6321         (iterate_over_lwps): Use gdb::function_view.
6322         * nat/aarch64-linux-hw-point.c (struct
6323         aarch64_dr_update_callback_param): Remove.
6324         (debug_reg_change_callback): Change type.
6325         (aarch64_notify_debug_reg_change): Update.
6326         * s390-linux-nat.c (s390_refresh_per_info): Update.
6327
6328 2019-03-11  Tom Tromey  <tromey@adacore.com>
6329
6330         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
6331         redundant assignment to "this_cu".
6332
6333 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6334
6335         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
6336
6337 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6338
6339         * gdbtypes.c (rank_one_type_parm_set): New function extracted
6340         from...
6341         (rank_one_type): ... this.
6342
6343 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6344
6345         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
6346         from...
6347         (rank_one_type): ... this.
6348
6349 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6350
6351         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
6352         from...
6353         (rank_one_type): ... this.
6354
6355 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6356
6357         * gdbtypes.c (rank_one_type_parm_float): New function extracted
6358         from...
6359         (rank_one_type): ... this.
6360
6361 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6362
6363         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
6364         from...
6365         (rank_one_type): ... this.
6366
6367 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6368
6369         * gdbtypes.c (rank_one_type_parm_range): New function extracted
6370         from...
6371         (rank_one_type): ... this.
6372
6373 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6374
6375         * gdbtypes.c (rank_one_type_parm_char): New function extracted
6376         from...
6377         (rank_one_type): ... this.
6378
6379 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6380
6381         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
6382         from...
6383         (rank_one_type): ... this.
6384
6385 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6386
6387         * gdbtypes.c (rank_one_type_parm_int): New function extracted
6388         from...
6389         (rank_one_type): ... this.
6390
6391 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6392
6393         * gdbtypes.c (rank_one_type_parm_func): New function extracted
6394         from...
6395         (rank_one_type): ... this.
6396
6397 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6398
6399         * gdbtypes.c (rank_one_type_parm_array): New function extracted
6400         from...
6401         (rank_one_type): ... this.
6402
6403 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6404
6405         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
6406         from...
6407         (rank_one_type): ... this.
6408
6409 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6410
6411         * inferior.c (initialize_inferiors): Ensure 'help set/show print
6412         inferior-events' shows the example events.
6413
6414 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
6415
6416         Support styling on native MS-Windows console
6417
6418         PR/24315
6419         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
6420         on MS-Windows if $TERM is not defined.
6421
6422         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
6423
6424         * posix-hdep.c (gdb_console_fputs):
6425         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
6426         functions.
6427         * ui-file.h (gdb_console_fputs): Add prototype.
6428
6429         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
6430         back to fputs only if the former returns zero.
6431
6432 2019-03-07  Tom Tromey  <tom@tromey.com>
6433
6434         * symmisc.c (print_symbol_bcache_statistics): Update.
6435         (print_objfile_statistics): Update.
6436         * symfile.c (allocate_symtab): Update.
6437         * stabsread.c: Don't include bcache.h.
6438         * psymtab.h (struct psymbol_bcache): Don't declare.
6439         (class psymtab_storage) <psymbol_cache>: Now a bcache.
6440         (psymbol_bcache_init, psymbol_bcache_free)
6441         (psymbol_bcache_get_bcache): Don't declare.
6442         * psymtab.c (struct psymbol_bcache): Remove.
6443         (psymtab_storage::psymtab_storage): Update.
6444         (psymtab_storage::~psymtab_storage): Update.
6445         (psymbol_bcache_init, psymbol_bcache_free)
6446         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
6447         (add_psymbol_to_bcache): Update.
6448         (allocate_psymtab): Update.
6449         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
6450         macro_cache>: No longer pointers.
6451         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
6452         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
6453         * macrotab.c (macro_bcache): Update.
6454         * macroexp.c: Don't include bcache.h.
6455         * gdbtypes.c (check_types_worklist): Update.
6456         (types_deeply_equal): Remove TRY/CATCH.  Update.
6457         * elfread.c (elf_symtab_read): Update.
6458         * dwarf2read.c: Don't include bcache.h.
6459         * buildsym.c (buildsym_compunit::get_macro_table): Update.
6460         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
6461         (print_bcache_statistics, bcache_memory_used): Don't declare.
6462         (struct bcache): Move from bcache.c.  Add constructor, destructor,
6463         methods.  Rename all data members.
6464         * bcache.c (struct bcache): Move to bcache.h.
6465         (bcache::expand_hash_table): Rename from expand_hash_table.
6466         (bcache): Remove.
6467         (bcache::insert): Rename from bcache_full.
6468         (bcache::compare): Rename from bcache_compare.
6469         (bcache_xmalloc): Remove.
6470         (bcache::~bcache): Rename from bcache_xfree.
6471         (bcache::print_statistics): Rename from print_bcache_statistics.
6472         (bcache::memory_used): Rename from bcache_memory_used.
6473
6474 2019-03-07  Pedro Alves  <palves@redhat.com>
6475
6476         * infrun.c (normal_stop): Also check for
6477         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
6478
6479 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
6480
6481         * f-lang.c (value_from_host_double): Moved to...
6482         * value.c (value_from_host_double): ...here.
6483         * value.h (value_from_host_double): Declare.
6484         * guile/scm-math.c (vlscm_convert_typed_number): Use
6485         value_from_host_double.
6486         (vlscm_convert_number): Likewise.
6487         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
6488         * python/py-value.c (convert_value_from_python): Likewise.
6489
6490 2019-03-06  Tom Tromey  <tom@tromey.com>
6491
6492         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
6493
6494 2019-03-06  Tom Tromey  <tom@tromey.com>
6495
6496         * utils.h (free_current_contents): Don't declare.
6497         * utils.c (free_current_contents): Remove.
6498
6499 2019-03-06  Tom Tromey  <tom@tromey.com>
6500
6501         * top.c (quit_force): Update.
6502         * main.c (captured_command_loop): Update.
6503         * common/new-op.c (operator new): Update.
6504         * common/common-exceptions.c (struct catcher)
6505         <save_cleanup_chain>: Remove member.
6506         (exceptions_state_mc_init): Update.
6507         (exception_try_scope_entry): Return nullptr.
6508         (exception_try_scope_exit, exception_rethrow)
6509         (throw_exception_sjlj, throw_exception_cxx): Update.
6510         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
6511         (all_cleanups, do_cleanups, discard_cleanups)
6512         (discard_final_cleanups, save_cleanups, save_final_cleanups)
6513         (restore_cleanups, restore_final_cleanups): Don't declare.
6514         (do_final_cleanups): Remove parameter.
6515         * common/cleanups.c (cleanup_chain, make_cleanup)
6516         (make_cleanup_dtor, all_cleanups, do_cleanups)
6517         (discard_my_cleanups, discard_cleanups)
6518         (discard_final_cleanups, save_my_cleanups, save_cleanups)
6519         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
6520         (null_cleanup): Remove.
6521         (do_final_cleanups): Remove parameter.
6522
6523 2019-03-06  Tom Tromey  <tom@tromey.com>
6524
6525         * remote.c (remote_target::remote_parse_stop_reply): Use
6526         unique_xmalloc_ptr.
6527
6528 2019-03-06  Tom Tromey  <tom@tromey.com>
6529
6530         * stabsread.c (struct stabs_field_info): Rename from field_info.
6531         <list, fnlist>: Add initializers.
6532         <obstack>: New member.
6533         (read_member_functions, read_struct_fields, read_baseclasses):
6534         Allocate on obstack.  Don't use cleanups.
6535         (read_one_struct_field, read_member_functions, read_struct_fields)
6536         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
6537         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
6538         (read_struct_type): Update.
6539
6540 2019-03-06  Tom Tromey  <tom@tromey.com>
6541
6542         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
6543         * common/filestuff.h (make_cleanup_close): Don't declare.
6544         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
6545         Remove.
6546
6547 2019-03-06  Tom Tromey  <tom@tromey.com>
6548
6549         * solib-aix.c: Use make_scope_exit.
6550
6551 2019-03-06  Tom Tromey  <tom@tromey.com>
6552
6553         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
6554         Use make_scope_exit.
6555
6556 2019-03-06  Tom Tromey  <tom@tromey.com>
6557
6558         * solib-svr4.c (disable_probes_interface): Remove parameter.
6559         (svr4_handle_solib_event): Use make_scope_exit.
6560
6561 2019-03-06  Tom Tromey  <tom@tromey.com>
6562
6563         * remote.c (struct stop_reply_deleter): Remove.
6564         (stop_reply_up): Update.
6565         (struct stop_reply): Derive from notif_event.  Don't typedef.
6566         <regcache>: Now a std::vector.
6567         (stop_reply_xfree): Remove.
6568         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
6569         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
6570         (remote_target::discard_pending_stop_replies): Use delete.
6571         (remote_target::remote_parse_stop_reply): Update.
6572         (remote_target::process_stop_reply): Update.
6573         * remote-notif.h (struct notif_event): Add virtual destructor.
6574         Remove "dtr" member.
6575         (struct notif_client) <alloc_event>: Return a unique_ptr.
6576         (notif_event_xfree): Don't declare.
6577         (notif_event_up): New typedef.
6578         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
6579         (notif_event_xfree, do_notif_event_xfree): Remove.
6580         (remote_notif_state_xfree): Update.
6581
6582 2019-03-06  Tom Tromey  <tom@tromey.com>
6583
6584         * infrun.c (displaced_step_clear_cleanup): Now a
6585         forward_scope_exit type.
6586         (displaced_step_prepare_throw): Update.
6587         (displaced_step_fixup): Update.
6588
6589 2019-03-06  Tom Tromey  <tom@tromey.com>
6590
6591         * inferior.h (class inferior): Update comment.
6592         * gdbthread.h (class thread_info): Update comment.
6593
6594 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
6595             Tom Tromey  <tom@tromey.com>
6596
6597         * stabsread.h (struct stab_section_list): Remove.
6598         (coffstab_build_psymtabs): Update.
6599         * dbxread.c (symbuf_sections): Now a std::vector.
6600         (sect_idx): New global.
6601         (fill_symbuf): Update.
6602         (coffstab_build_psymtabs): Change type of stabsects parameter.
6603         Update.
6604         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
6605         std::vector.
6606         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
6607         (coff_locate_sections): Update.
6608         (coff_symfile_read): Remove cleanups.  Update.
6609         (init_stringtab): Add storage parameter.
6610         (free_stringtab, free_stringtab_cleanup): Remove.
6611         (init_lineno): Add storage parameter.
6612         (free_linetab, free_linetab_cleanup): Remove.
6613
6614 2019-03-06  Pedro Alves  <palves@redhat.com>
6615
6616         * linux-fork.c (fork_info::clobber_regs): Delete.
6617         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
6618         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
6619         comment.  Adjust.
6620         (scoped_switch_fork_info::scoped_switch_fork_info)
6621         (checkpoint_command, linux_fork_context): Adjust
6622         fork_save_infrun_state calls.
6623
6624 2019-03-06  Pedro Alves  <palves@redhat.com>
6625
6626         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
6627         (inf_has_multiple_threads): Return 'bool' and rewrite using
6628         inferior_info::threads().
6629
6630 2019-03-06  Pedro Alves  <palves@redhat.com>
6631
6632         * linux-fork.c: Include <list>.
6633         (fork_list): Now a std::list instance.
6634         (fork_info): Add ctor, dtor, and in-class initialize all fields.
6635         (forks_exist_p, find_last_fork): Adjust.
6636         (new_fork): Delete.
6637         (one_fork_p): New.
6638         (add_fork): Adjust.
6639         (free_fork): Delete, folded into fork_info::~fork_info().
6640         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
6641         Adjust.
6642         (init_fork_list): Delete.
6643         (linux_fork_killall, linux_fork_mourn_inferior)
6644         (linux_fork_detach, info_checkpoints_command): Adjust.
6645         (_initialize_linux_fork): No longer call init_fork_list.
6646
6647 2019-03-06  Pedro Alves  <palves@redhat.com>
6648
6649         * linux-fork.c (new_fork): New, split out of ...
6650         (add_fork): ... this.  Return void.  Move "first fork" special
6651         case from here, to ...
6652         (checkpoint_command): ... here.
6653         * linux-linux.h (add_fork): Return void.
6654
6655 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6656
6657         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
6658
6659 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6660             Chris January  <chris.january@arm.com>
6661             David Lecomber  <david.lecomber@arm.com>
6662
6663         * f-exp.y: New token, UNOP_INTRINSIC.
6664         (exp): New pattern using UNOP_INTRINSIC token.
6665         (f77_keywords): Add 'abs' keyword.
6666         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
6667         (value_from_host_double): New function.
6668         (evaluate_subexp_f): Support UNOP_ABS.
6669
6670 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6671
6672         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
6673         types.
6674
6675 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6676
6677         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
6678         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
6679         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
6680
6681 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6682
6683         * f-exp.y (convert_to_kind_type): Handle more type kinds.
6684
6685 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6686             Chris January  <chris.january@arm.com>
6687
6688         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
6689         * f-exp.y: Define 'KIND' token.
6690         (exp): New pattern for KIND expressions.
6691         (ptype): Handle types with a kind extension.
6692         (direct_abs_decl): Extend to spot kind extensions.
6693         (f77_keywords): Add 'kind' to the list.
6694         (push_kind_type): New function.
6695         (convert_to_kind_type): New function.
6696         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
6697         * parse.c (operator_length_standard): Likewise.
6698         * parser-defs.h (enum type_pieces): Add tp_kind.
6699         * std-operator.def: Add UNOP_KIND.
6700
6701 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6702
6703         * f-exp.y (f_parse): Set yydebug.
6704
6705 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6706
6707         * f-lang.c (evaluate_subexp_f): New function.
6708         (exp_descriptor_f): New global.
6709         (f_language_defn): Use exp_descriptor_f instead of
6710         exp_descriptor_standard.
6711
6712 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6713
6714         * f-exp.y (struct token): Add comments.
6715         (dot_ops): Remove uppercase versions and the end marker.
6716         (f77_keywords): Likewise.
6717         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
6718         entries in the dot_ops array are case insensitive, and use
6719         strncasecmp to compare strings.  Also some whitespace cleanup in
6720         this area.  Similar for the f77_keywords array, except entries in
6721         this list might be case sensitive.
6722
6723 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6724
6725         * f-exp.y (struct f77_boolean_val): Add comments.
6726         (boolean_values): Remove uppercase versions, and end marker.
6727         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
6728         and use strncasecmp to achieve case insensitivity.  Additionally,
6729         perform whitespace cleanup around this code.
6730
6731 2019-03-06  Tom Tromey  <tromey@adacore.com>
6732
6733         * remote-sim.c (gdbsim_target_open): Use result of
6734         gdb_argv::release.
6735
6736 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
6737         Dirk Schubert  <dirk.schubert@arm.com>
6738         Chris January  <chris.january@arm.com>
6739
6740         * eval.c (evaluate_subexp_standard): Call Fortran argument
6741         wrapping logic.
6742         * f-lang.c (struct value): A value which can be passed into a
6743         Fortran function call.
6744         (fortran_argument_convert): Wrap Fortran arguments in a pointer
6745         where appropriate.
6746         (struct type): Value ready for a Fortran function call.
6747         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
6748         is needed.
6749         * f-lang.h (fortran_argument_convert): Declaration.
6750         (fortran_preserve_arg_pointer): Declaration.
6751         * infcall.c (value_arg_coerce): Call Fortran argument logic.
6752
6753 2019-03-05  Tom Tromey  <tromey@adacore.com>
6754
6755         * python/py-prettyprint.c (print_string_repr): Remove #if.
6756         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
6757
6758 2019-03-05  Tom Tromey  <tromey@adacore.com>
6759
6760         * target.c (the_dummy_target): Move later.  Change type to
6761         "dummy_target".
6762         (initialize_targets): Don't initialize the_dummy_target.
6763
6764 2019-03-05  Tom Tromey  <tromey@adacore.com>
6765
6766         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
6767         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
6768
6769 2019-03-05  Tom Tromey  <tromey@adacore.com>
6770
6771         * windows-nat.c (windows_nat_target::attach)
6772         (windows_nat_target::detach): Don't call gdb_flush.
6773         * valprint.c (generic_val_print, val_print, val_print_string):
6774         Don't call gdb_flush.
6775         * utils.c (defaulted_query): Don't call gdb_flush.
6776         * typeprint.c (print_type_scalar): Don't call gdb_flush.
6777         * target.c (target_announce_detach): Don't call gdb_flush.
6778         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
6779         * remote.c (extended_remote_target::attach): Don't call
6780         gdb_flush.
6781         * procfs.c (procfs_target::detach): Don't call gdb_flush.
6782         * printcmd.c (do_examine): Don't call gdb_flush.
6783         (info_display_command): Don't call gdb_flush.
6784         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
6785         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
6786         * memattr.c (info_mem_command): Don't call gdb_flush.
6787         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
6788         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
6789         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
6790         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
6791         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
6792         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
6793         (gnu_nat_target::detach): Don't call gdb_flush.
6794         * f-valprint.c (f_val_print): Don't call gdb_flush.
6795         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
6796         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
6797         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
6798         gdb_flush.
6799         * c-valprint.c (c_val_print): Don't call gdb_flush.
6800         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
6801
6802 2019-03-05  Tom Tromey  <tromey@adacore.com>
6803
6804         * varobj.c (update_dynamic_varobj_children): Update.
6805         (install_default_visualizer): Use reset, not release.
6806         * value.c (set_internalvar): Update.
6807         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
6808         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
6809         ATTRIBUTE_UNUSED_RESULT.
6810
6811 2019-03-05  Tom Tromey  <tromey@adacore.com>
6812
6813         * remote.c (class scoped_remote_fd) <release>: Add
6814         ATTRIBUTE_UNUSED_RESULT.
6815
6816 2019-03-05  Tom Tromey  <tromey@adacore.com>
6817
6818         * macroexp.c (struct macro_buffer) <release>: Add
6819         ATTRIBUTE_UNUSED_RESULT.
6820
6821 2019-03-05  Tom Tromey  <tromey@adacore.com>
6822
6823         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
6824         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
6825         ATTRIBUTE_UNUSED_RESULT.
6826
6827 2019-03-05  Tom Tromey  <tromey@adacore.com>
6828
6829         * common/scoped_fd.h (class scoped_fd) <release>: Add
6830         ATTRIBUTE_UNUSED_RESULT.
6831
6832 2019-03-05  Tom Tromey  <tromey@adacore.com>
6833
6834         * parser-defs.h (struct parser_state) <release>: Add
6835         ATTRIBUTE_UNUSED_RESULT.
6836
6837 2019-03-05  Tom Tromey  <tromey@adacore.com>
6838
6839         * utils.h (class gdb_argv) <release>: Add
6840         ATTRIBUTE_UNUSED_RESULT.
6841         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
6842
6843 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
6844
6845         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
6846         for-loop range, to avoid compiler warnings.
6847
6848         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
6849         avoid compiler warnings about unused variables.
6850
6851         * NEWS: Mention end of support for native debugging on MS-Windows
6852         before XP.
6853
6854         PR gdb/24292
6855         * common/netstuff.c:
6856         * gdbserver/gdbreplay.c
6857         * gdbserver/remote-utils.c:
6858         * ser-tcp.c:
6859         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
6860         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
6861         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
6862         'getaddrinfo' and 'freeaddrinfo' were not available before
6863         Windows XP, and mingw.org's MinGW headers by default define
6864         _WIN32_WINNT to 0x500.
6865
6866 2019-03-01  Gary Benson <gbenson@redhat.com>
6867
6868         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
6869
6870 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
6871             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
6872
6873         PR gdb/8527
6874         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
6875         set_sigint_trap, clear_sigint_trap.
6876
6877 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6878
6879         * target.c (target_detach): Clear the regcache and the
6880         frame cache.
6881
6882 2019-02-27  Pedro Alves  <palves@redhat.com>
6883
6884         * utils.c (set_screen_size): When we cap the height/width sizes,
6885         tweak the corresponding command variable to show "unlimited":
6886
6887 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
6888             Pedro Alves  <palves@redhat.com>
6889
6890         * utils.c (set_screen_size): Reduce "infinite" rows and columns
6891         before calling rl_set_screen_size.
6892
6893 2019-02-27  Tom Tromey  <tromey@adacore.com>
6894
6895         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
6896         define.
6897         * python/py-value.c: Remove Python 2.4 workaround.
6898         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
6899         workaround.
6900         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
6901         Python 2.4 workaround.
6902         * python/python-internal.h: Remove Python 2.4 comment.
6903         (Py_ssize_t): Don't define.
6904         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
6905         (gdb_Py_DECREF): Remove Python 2.4 workaround.
6906         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
6907         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
6908         * python/python.c (do_start_initialization): Remove Python 2.4
6909         workaround.
6910         * python/py-prettyprint.c (class dummy_python_frame): Remove.
6911         (print_children): Remove Python 2.4 workaround.
6912         * python/py-inferior.c (buffer_procs): Remove Python 2.4
6913         workaround.
6914         (CHARBUFFERPROC_NAME): Remove.
6915         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
6916         Python 2.4 workaround.
6917
6918 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6919
6920         * NEWS: Note minimum Python version.
6921
6922 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6923
6924         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
6925         code from these functions.  Remove corresponding ifdefs.  Use
6926         Py_buffer_up instead of explicit calls to PyBuffer_Release.
6927         Remove gotos and target of gotos.
6928         (infpy_search_memory): Likewise.
6929
6930 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6931
6932         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
6933         (hppa_gdbarch_init): Don't register deleted functions with
6934         gdbarch.
6935
6936 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6937
6938         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
6939         (h8300_unwind_sp): Delete.
6940         (h8300_dummy_id): Delete.
6941         (h8300_gdbarch_init): Don't register deleted functions with
6942         gdbarch.
6943
6944 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6945
6946         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
6947         (ft32_unwind_pc): Delete.
6948         (ft32_unwind_sp): Delete.
6949         (ft32_gdbarch_init): Don't register deleted functions with
6950         gdbarch.
6951
6952 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6953
6954         * gdb/frv-tdep.c (frv_dummy_id): Delete.
6955         (frv_unwind_pc): Delete.
6956         (frv_unwind_sp): Delete.
6957         (frv_gdbarch_init): Don't register deleted functions with
6958         gdbarch.
6959
6960 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6961
6962         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
6963         (riscv_unwind_pc): Delete.
6964         (riscv_unwind_sp): Delete.
6965         (riscv_gdbarch_init): Don't register deleted functions with
6966         gdbarch.
6967
6968 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6969
6970         * gdb/csky-tdep.c (csky_dummy_id): Delete.
6971         (csky_unwind_pc): Delete.
6972         (csky_unwind_sp): Delete.
6973         (csky_gdbarch_init): Don't register deleted functions with
6974         gdbarch.
6975
6976 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6977
6978         * gdb/cris-tdep.c (cris_dummy_id): Delete.
6979         (cris_unwind_pc): Delete.
6980         (cris_unwind_sp): Delete.
6981         (cris_gdbarch_init): Don't register deleted functions with
6982         gdbarch.
6983
6984 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6985
6986         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
6987         (bfin_unwind_pc): Delete.
6988         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
6989
6990 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6991
6992         * gdb/arm-tdep.c (arm_dummy_id): Delete.
6993         (arm_unwind_pc): Delete.
6994         (arm_unwind_sp): Delete.
6995         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
6996
6997 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6998
6999         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7000         (arc_unwind_pc): Delete.
7001         (arc_unwind_sp): Delete.
7002         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7003
7004 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7005
7006         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7007         (alpha_unwind_pc): Delete.
7008         (alpha_gdbarch_init): Don't register deleted functions with
7009         gdbarch.
7010
7011 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7012
7013         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7014         (aarch64_unwind_pc): Delete.
7015         (aarch64_unwind_sp): Delete.
7016         (aarch64_gdbarch_init): Don't register deleted functions with
7017         gdbarch.
7018
7019 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7020
7021         * gdbtypes.c (type_align): Don't consider static members when
7022         computing structure alignment.
7023
7024 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7025
7026         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7027         return 0 for other types.
7028         * arch-utils.c (default_type_align): Always return 0.
7029         * gdbarch.h: Regenerate.
7030         * gdbarch.sh (type_align): Extend comment.
7031         * gdbtypes.c (type_align): Add additional comments, always call
7032         gdbarch_type_align before applying the default rules.
7033         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7034         generic code will then apply a suitable default.
7035         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7036         types, return 0 for other types.
7037
7038 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7039
7040         * NEWS: Create a new section for the next release branch.
7041         Rename the section of the current branch, now that it has
7042         been cut.
7043
7044 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7045
7046         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7047         * version.in: Bump version to 8.3.50.DATE-git.
7048
7049 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7050
7051         * aix-thread.c (ptid_cmp): Remove unused variable.
7052         (get_signaled_thread): Likewise.
7053         (store_regs_user_thread): Likewise.
7054         (store_regs_kernel_thread): Likewise.
7055         (fetch_regs_kernel_thread): Remove shadowed variable.
7056
7057 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7058
7059         * features/riscv/32bit-cpu.xml: Add register numbers.
7060         * features/riscv/32bit-fpu.c: Regenerate.
7061         * features/riscv/32bit-fpu.xml: Add register numbers.
7062         * features/riscv/64bit-cpu.xml: Add register numbers.
7063         * features/riscv/64bit-fpu.c: Regenerate.
7064         * features/riscv/64bit-fpu.xml: Add register numbers.
7065
7066 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7067
7068         * NEWS: Mention two argument form of gdb.Value constructor.
7069         * python/py-value.c (convert_buffer_and_type_to_value): New
7070         function.
7071         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7072         Add support for handling an optional second argument.  Call
7073         convert_buffer_and_type_to_value as appropriate.
7074         * python/python-internal.h (Py_buffer_deleter): New struct.
7075         (Py_buffer_up): New typedef.
7076
7077 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7078
7079         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7080         instead of releasing ownership.
7081
7082 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7083
7084         * dwarf2read.c (open_and_init_dwp_file): Call
7085         elf_numsections instead of bfd_count_sections to initialize
7086         dwp_file->num_sections.
7087
7088 2019-02-25  Tom Tromey  <tromey@adacore.com>
7089
7090         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7091
7092 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7093
7094         * gcore.in: Add '--readnever' option when invoking GDB.
7095
7096 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7097
7098         * MAINTAINERS: Update my email address.
7099
7100 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7101
7102         * build-id.c (build_id_to_debug_bfd_1): New function.
7103         (build_id_to_debug_bfd): Look for separate debug file in
7104         sysroot.
7105
7106 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7107
7108         * gdbarch.sh: Update the copyright year range that is placed into
7109         generated files.
7110
7111 2019-02-22  Keith Seitz  <keiths@redhat.com>
7112
7113         PR symtab/23853
7114         * linespec.c (create_sals_line_offset): Search for the default
7115         symtab's filename instead of its fullname.
7116
7117 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7118
7119         * NEWS: Update style defaults.
7120
7121 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7122
7123         * main.c (captured_main_1): Disable styling in batch mode.
7124
7125 2019-02-20  Tom Tromey  <tom@tromey.com>
7126
7127         * symtab.c (symtab_symbol_info): Fix typos.
7128
7129 2019-02-20  Tom Tromey  <tromey@adacore.com>
7130
7131         * findcmd.c (_initialize_mem_search): Use upper case for
7132         metasyntactic variables.
7133
7134 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7135
7136         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7137         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7138
7139 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7140
7141         * top.h (source_file_name): Change to std::string.
7142         * top.c (source_file_name): Likewise.
7143         (command_line_input): Adjust.
7144         * cli/cli-script.c (script_from_file): Adjust.
7145
7146 2019-02-19  Tom Tromey  <tromey@adacore.com>
7147
7148         * ravenscar-thread.c
7149         (ravenscar_thread_target::update_thread_list): Don't call
7150         ada_build_task_list.
7151         * ada-lang.h (ada_build_task_list): Don't declare.
7152         * ada-tasks.c (struct ada_tasks_inferior_data)
7153         <task_list_valid_p>: Now bool.
7154         (read_known_tasks, ada_task_list_changed)
7155         (ada_tasks_invalidate_inferior_data): Update.
7156         (read_known_tasks_array): Return bool.
7157         (read_known_tasks_list): Likewise.
7158         (read_known_tasks): Return void.
7159         (ada_build_task_list): Now static.
7160
7161 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7162
7163         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
7164         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
7165
7166 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7167
7168         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
7169         variant for ada_tasks_pspace_data_handle and
7170         ada_tasks_inferior_data_handle.
7171         (ada_tasks_pspace_data_cleanup): New function.
7172         (ada_tasks_inferior_data_cleanup): New function.
7173
7174 2019-02-17  Tom Tromey  <tom@tromey.com>
7175
7176         * macrotab.h (macro_source_fullname): Return a std::string.
7177         * macrotab.c (macro_include, check_for_redefinition)
7178         (macro_undef, macro_lookup_definition, foreach_macro)
7179         (foreach_macro_in_scope): Update.
7180         (macro_source_fullname): Return a std::string.
7181         * macrocmd.c (show_pp_source_pos): Update.
7182
7183 2019-02-17  Tom Tromey  <tom@tromey.com>
7184
7185         * macrocmd.c (show_pp_source_pos): Style the file names.
7186
7187 2019-02-17  Tom Tromey  <tom@tromey.com>
7188
7189         PR tui/24197:
7190         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
7191
7192 2019-02-17  Tom Tromey  <tom@tromey.com>
7193
7194         * ada-lang.c (user_select_syms): Use filtered printing.
7195         * utils.c (wrap_style): New global.
7196         (desired_style): Remove.
7197         (emit_style_escape): Add stream parameter.
7198         (set_output_style, reset_terminal_style, prompt_for_continue):
7199         Update.
7200         (flush_wrap_buffer): Only flush gdb_stdout.
7201         (wrap_here): Set wrap_style.
7202         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
7203         treat escape sequences as a character.  Change when wrap buffer is
7204         flushed.
7205         (fputs_styled): Do not set the output style when the default is
7206         requested.
7207         * ui-style.h (struct ui_file_style) <is_default>: New method.
7208         * source.c (print_source_lines_base): Emit escape sequences in one
7209         piece.
7210
7211 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7212
7213         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
7214         integers and enumeration types.
7215
7216 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7217
7218         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
7219         instead of lookup_symbol_in_language
7220         (do_exact_match): New function.
7221         (ada_get_symbol_name_matcher): Return do_exact_match when
7222         doing a verbatim match.
7223
7224 2019-02-15  Tom Tromey  <tromey@adacore.com>
7225
7226         * ravenscar-thread.c (ravenscar_thread_target::resume)
7227         (ravenscar_thread_target::wait): Special case wildcard requests.
7228
7229 2019-02-15  Tom Tromey  <tromey@adacore.com>
7230
7231         * ravenscar-thread.c (base_ptid): Remove.
7232         (struct ravenscar_thread_target) <close>: New method.
7233         <m_base_ptid>: New member.
7234         <update_inferior_ptid, active_task, task_is_currently_active,
7235         runtime_initialized>: Declare methods.
7236         <ravenscar_thread_target>: Add constructor.
7237         (ravenscar_thread_target::task_is_currently_active)
7238         (ravenscar_thread_target::update_inferior_ptid)
7239         (ravenscar_runtime_initialized): Rename.  Now methods.
7240         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
7241         (ravenscar_thread_target::update_thread_list): Update.
7242         (ravenscar_thread_target::active_task): Now method.
7243         (ravenscar_thread_target::store_registers)
7244         (ravenscar_thread_target::prepare_to_store)
7245         (ravenscar_thread_target::prepare_to_store)
7246         (ravenscar_thread_target::mourn_inferior): Update.
7247         (ravenscar_inferior_created): Use "new" to create target.
7248         (ravenscar_thread_target::get_ada_task_ptid): Update.
7249         (_initialize_ravenscar): Don't initialize base_ptid.
7250         (ravenscar_ops): Remove global.
7251
7252 2019-02-15  Tom Tromey  <tromey@adacore.com>
7253
7254         * target.h (push_target): Declare new overload.
7255         * target.c (push_target): New overload, taking an rvalue reference.
7256         * remote.c (remote_target::open_1): Use push_target overload.
7257         * corelow.c (core_target_open): Use push_target overload.
7258
7259 2019-02-15  Tom Tromey  <tromey@adacore.com>
7260
7261         * ravenscar-thread.c (is_ravenscar_task)
7262         (ravenscar_task_is_currently_active): Return bool.
7263         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
7264         (_initialize_ravenscar): Remove "(void)".
7265         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
7266         Return bool.
7267
7268 2019-02-15  Tom Tromey  <tromey@adacore.com>
7269
7270         * ravenscar-thread.c (ravenscar_runtime_initializer)
7271         (has_ravenscar_runtime, get_running_thread_id)
7272         (ravenscar_thread_target::resume): Fix indentation.
7273
7274 2019-02-15  Tom Tromey  <tromey@adacore.com>
7275
7276         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
7277         from ravenscar_arch_ops.
7278         (sparc_ravenscar_ops::fetch_registers)
7279         (sparc_ravenscar_ops::store_registers): Now methods.
7280         (sparc_ravenscar_prepare_to_store): Remove.
7281         (sparc_ravenscar_ops): Redefine.
7282         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
7283         methods and destructor.  Remove members.
7284         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
7285         (ravenscar_thread_target::store_registers)
7286         (ravenscar_thread_target::prepare_to_store): Update.
7287         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
7288         Remove.
7289         (struct ppc_ravenscar_powerpc_ops): Derive from
7290         ravenscar_arch_ops.
7291         (ppc_ravenscar_powerpc_ops::fetch_registers)
7292         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
7293         (ppc_ravenscar_powerpc_ops): Redefine.
7294         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
7295         (ppc_ravenscar_e500_ops::fetch_registers)
7296         (ppc_ravenscar_e500_ops::store_registers): Now methods.
7297         (ppc_ravenscar_e500_ops): Redefine.
7298         * aarch64-ravenscar-thread.c
7299         (aarch64_ravenscar_generic_prepare_to_store): Remove.
7300         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
7301         (aarch64_ravenscar_fetch_registers)
7302         (aarch64_ravenscar_store_registers): Now methods.
7303         (aarch64_ravenscar_ops): Redefine.
7304
7305 2019-02-15  Tom Tromey  <tromey@adacore.com>
7306
7307         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
7308         (ravenscar_thread_target::stopped_by_hw_breakpoint)
7309         (ravenscar_thread_target::stopped_by_watchpoint)
7310         (ravenscar_thread_target::stopped_data_address)
7311         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
7312
7313 2019-02-15  Tom Tromey  <tromey@adacore.com>
7314
7315         * ravenscar-thread.c: Fix some typos.
7316
7317 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7318             Tom Tromey  <tromey@adacore.com>
7319
7320         * ada-lang.c (ada_exception_sal): Change addr_string to a
7321         std::string.
7322         (create_ada_exception_catchpoint): Update.
7323
7324 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7325             Tom Tromey  <tromey@adacore.com>
7326
7327         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
7328         (bp_location_ops): Remove.
7329         (base_breakpoint_allocate_location): Update.
7330         (free_bp_location): Update.
7331         * ada-lang.c (class ada_catchpoint_location)
7332         <ada_catchpoint_location>: Remove ops parameter.
7333         (ada_catchpoint_location_dtor): Remove.
7334         (ada_catchpoint_location_ops): Remove.
7335         (allocate_location_exception): Update.
7336         * breakpoint.h (struct bp_location_ops): Remove.
7337         (class bp_location) <bp_location>: Remove bp_location_ops
7338         parameter.
7339         <~bp_location>: Add destructor.
7340         <ops>: Remove.
7341
7342 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7343             Pedro Alves  <palves@redhat.com>
7344
7345         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
7346         'PATH_MAX'.
7347
7348 2019-02-14  David Michael  <fedora.dm0@gmail.com>
7349             Samuel Thibault  <samuel.thibault@gnu.org>
7350             Thomas Schwinge  <thomas@codesourcery.com>
7351
7352         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
7353         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
7354
7355 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7356
7357         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
7358         (check_empty): Use "const char *".
7359
7360         * gnu-nat.c (gnu_nat_target::detach): Instead of
7361         'detach_inferior (pid)' call
7362         'detach_inferior (find_inferior_pid (pid))'.
7363
7364         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
7365         'nat/fork-inferior.o'.
7366         * gnu-nat.c: #include "nat/fork-inferior.h".
7367
7368         * gnu-nat.c (gnu_nat_target::detach): Instead of
7369         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
7370         * gnu-nat.h: #include "inf-child.h".
7371         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
7372         'i386_gnu_nat_target::fetch_registers'.
7373         (gnu_store_registers): Rename/move to
7374         'i386_gnu_nat_target::store_registers'.
7375
7376         * config/i386/nm-i386gnu.h: Don't "#include" any files.
7377         * gnu-nat.h (mach_thread_info): New function.
7378         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
7379
7380         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
7381
7382 2019-02-14  Frederic Konrad  <konrad@adacore.com>
7383
7384         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
7385
7386 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
7387
7388         * windows-nat.c (windows_add_thread): Add new parameter
7389         "main_thread_p" with default value set to false.  Update
7390         function documentation as well as all callers.
7391         (windows_delete_thread): Likewise.
7392         (fake_create_process): Update call to windows_add_thread.
7393         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
7394         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
7395         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
7396         call to windows_delete_thread.
7397
7398 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
7399
7400         * MAINTAINERS: Add Andrew Burgess as global maintainer.
7401
7402 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7403
7404         * symfile.c (find_separate_debug_file): Use canonical path of
7405         sysroot with child_path instead of gdb_sysroot if it is valid.
7406
7407 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7408
7409         * symfile.c (find_separate_debug_file): Use child_path to
7410         determine if an object file is under a sysroot.
7411
7412 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7413
7414         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
7415         unittests/child-path-selftests.c.
7416         * common/pathstuff.c (child_path): New function.
7417         * common/pathstuff.h (child_path): New prototype.
7418         * unittests/child-path-selftests.c: New file.
7419
7420 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7421
7422         * symfile.c (find_separate_debug_file): Look for separate debug
7423         files in debug directories under the sysroot.
7424
7425 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7426
7427         * symtab.h (struct minimal_symbol data_p): New const method.
7428         (struct minimal_symbol text_p): Likewise.
7429         * symtab.c (output_source_filename): Use file name style
7430         to print file name.
7431         (print_symbol_info): Likewise.
7432         (print_msymbol_info): Use address style to print addresses.
7433         Use function name style to print executable text symbols.
7434         (expand_symtab_containing_pc): Use data_p.
7435         (find_pc_sect_compunit_symtab): Likewise.
7436
7437 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7438
7439         * breakpoint.c (describe_other_breakpoints): Use address style
7440         to print addresses.
7441         (say_where): Likewise.
7442
7443 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7444
7445         * ada-typeprint.c (print_func_type): Print function name
7446         style to print function name.
7447         * c-typeprint.c (c_print_type_1): Likewise.
7448
7449 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
7450
7451         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
7452         for execve.
7453
7454 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7455
7456         * c-exp.y (direct_abs_decl): Use emplace_back to record the
7457         type_stack.
7458
7459 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
7460
7461         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
7462         TYPE_CODE_REF types.
7463
7464 2019-02-08  Jim Wilson  <jimw@sifive.com>
7465
7466         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
7467         (riscv_linux_fregset): New.
7468         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
7469
7470 2019-02-07  Tom Tromey  <tom@tromey.com>
7471
7472         * thread.c (thread_cancel_execution_command): Update.
7473         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
7474         methods.
7475         (struct thread_fsm_ops): Remove.
7476         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
7477         (thread_fsm_should_stop, thread_fsm_return_value)
7478         (thread_fsm_set_finished, thread_fsm_finished_p)
7479         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
7480         Don't declare.
7481         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
7482         * infrun.c (clear_proceed_status_thread)
7483         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
7484         (print_stop_event): Update.
7485         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
7486         Add constructor.
7487         (step_command_fsm_ops): Remove.
7488         (new_step_command_fsm): Remove.
7489         (step_1): Update.
7490         (step_command_fsm::should_stop): Rename from
7491         step_command_fsm_should_stop.
7492         (step_command_fsm::clean_up): Rename from
7493         step_command_fsm_clean_up.
7494         (step_command_fsm::do_async_reply_reason): Rename from
7495         step_command_fsm_async_reply_reason.
7496         (struct until_next_fsm): Inherit from thread_fsm.  Add
7497         constructor.
7498         (until_next_fsm_ops): Remove.
7499         (new_until_next_fsm): Remove.
7500         (until_next_fsm::should_stop): Rename from
7501         until_next_fsm_should_stop.
7502         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
7503         (until_next_fsm::do_async_reply_reason): Rename from
7504         until_next_fsm_async_reply_reason.
7505         (struct finish_command_fsm): Inherit from thread_fsm.  Add
7506         constructor.  Change type of breakpoint.
7507         (finish_command_fsm_ops): Remove.
7508         (new_finish_command_fsm): Remove.
7509         (finish_command_fsm::should_stop): Rename from
7510         finish_command_fsm_should_stop.
7511         (finish_command_fsm::clean_up): Rename from
7512         finish_command_fsm_clean_up.
7513         (finish_command_fsm::return_value): Rename from
7514         finish_command_fsm_return_value.
7515         (finish_command_fsm::do_async_reply_reason): Rename from
7516         finish_command_fsm_async_reply_reason.
7517         (finish_command): Update.
7518         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
7519         Add constructor.
7520         (call_thread_fsm_ops): Remove.
7521         (call_thread_fsm::call_thread_fsm): Rename from
7522         new_call_thread_fsm.
7523         (call_thread_fsm::should_stop): Rename from
7524         call_thread_fsm_should_stop.
7525         (call_thread_fsm::should_notify_stop): Rename from
7526         call_thread_fsm_should_notify_stop.
7527         (run_inferior_call, call_function_by_hand_dummy): Update.
7528         * cli/cli-interp.c (should_print_stop_to_console): Update.
7529         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
7530         Add constructor.  Change type of location_breakpoint,
7531         caller_breakpoint.
7532         (until_break_fsm_ops): Remove.
7533         (new_until_break_fsm): Remove.
7534         (until_break_fsm::should_stop): Rename from
7535         until_break_fsm_should_stop.
7536         (until_break_fsm::clean_up): Rename from
7537         until_break_fsm_clean_up.
7538         (until_break_fsm::do_async_reply_reason): Rename from
7539         until_break_fsm_async_reply_reason.
7540         (until_break_command): Update.
7541         * thread-fsm.c: Remove.
7542         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
7543
7544 2019-02-07  Tom Tromey  <tom@tromey.com>
7545
7546         * yy-remap.h: Add include guard.
7547         * xtensa-tdep.h: Add include guard.
7548         * xcoffread.h: Rename include guard.
7549         * varobj-iter.h: Add include guard.
7550         * tui/tui.h: Rename include guard.
7551         * tui/tui-winsource.h: Rename include guard.
7552         * tui/tui-wingeneral.h: Rename include guard.
7553         * tui/tui-windata.h: Rename include guard.
7554         * tui/tui-win.h: Rename include guard.
7555         * tui/tui-stack.h: Rename include guard.
7556         * tui/tui-source.h: Rename include guard.
7557         * tui/tui-regs.h: Rename include guard.
7558         * tui/tui-out.h: Rename include guard.
7559         * tui/tui-layout.h: Rename include guard.
7560         * tui/tui-io.h: Rename include guard.
7561         * tui/tui-hooks.h: Rename include guard.
7562         * tui/tui-file.h: Rename include guard.
7563         * tui/tui-disasm.h: Rename include guard.
7564         * tui/tui-data.h: Rename include guard.
7565         * tui/tui-command.h: Rename include guard.
7566         * tic6x-tdep.h: Add include guard.
7567         * target/waitstatus.h: Rename include guard.
7568         * target/wait.h: Rename include guard.
7569         * target/target.h: Rename include guard.
7570         * target/resume.h: Rename include guard.
7571         * target-float.h: Rename include guard.
7572         * stabsread.h: Add include guard.
7573         * rs6000-tdep.h: Add include guard.
7574         * riscv-fbsd-tdep.h: Add include guard.
7575         * regformats/regdef.h: Rename include guard.
7576         * record.h: Rename include guard.
7577         * python/python.h: Rename include guard.
7578         * python/python-internal.h: Rename include guard.
7579         * python/py-stopevent.h: Rename include guard.
7580         * python/py-ref.h: Rename include guard.
7581         * python/py-record.h: Rename include guard.
7582         * python/py-record-full.h: Rename include guard.
7583         * python/py-record-btrace.h: Rename include guard.
7584         * python/py-instruction.h: Rename include guard.
7585         * python/py-events.h: Rename include guard.
7586         * python/py-event.h: Rename include guard.
7587         * procfs.h: Add include guard.
7588         * proc-utils.h: Add include guard.
7589         * p-lang.h: Add include guard.
7590         * or1k-tdep.h: Rename include guard.
7591         * observable.h: Rename include guard.
7592         * nto-tdep.h: Rename include guard.
7593         * nat/x86-linux.h: Rename include guard.
7594         * nat/x86-linux-dregs.h: Rename include guard.
7595         * nat/x86-gcc-cpuid.h: Add include guard.
7596         * nat/x86-dregs.h: Rename include guard.
7597         * nat/x86-cpuid.h: Rename include guard.
7598         * nat/ppc-linux.h: Rename include guard.
7599         * nat/mips-linux-watch.h: Rename include guard.
7600         * nat/linux-waitpid.h: Rename include guard.
7601         * nat/linux-ptrace.h: Rename include guard.
7602         * nat/linux-procfs.h: Rename include guard.
7603         * nat/linux-osdata.h: Rename include guard.
7604         * nat/linux-nat.h: Rename include guard.
7605         * nat/linux-namespaces.h: Rename include guard.
7606         * nat/linux-btrace.h: Rename include guard.
7607         * nat/glibc_thread_db.h: Rename include guard.
7608         * nat/gdb_thread_db.h: Rename include guard.
7609         * nat/gdb_ptrace.h: Rename include guard.
7610         * nat/fork-inferior.h: Rename include guard.
7611         * nat/amd64-linux-siginfo.h: Rename include guard.
7612         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
7613         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
7614         * nat/aarch64-linux.h: Rename include guard.
7615         * nat/aarch64-linux-hw-point.h: Rename include guard.
7616         * mn10300-tdep.h: Add include guard.
7617         * mips-linux-tdep.h: Add include guard.
7618         * mi/mi-parse.h: Rename include guard.
7619         * mi/mi-out.h: Rename include guard.
7620         * mi/mi-main.h: Rename include guard.
7621         * mi/mi-interp.h: Rename include guard.
7622         * mi/mi-getopt.h: Rename include guard.
7623         * mi/mi-console.h: Rename include guard.
7624         * mi/mi-common.h: Rename include guard.
7625         * mi/mi-cmds.h: Rename include guard.
7626         * mi/mi-cmd-break.h: Rename include guard.
7627         * m2-lang.h: Add include guard.
7628         * location.h: Rename include guard.
7629         * linux-record.h: Rename include guard.
7630         * linux-nat.h: Add include guard.
7631         * linux-fork.h: Add include guard.
7632         * i386-darwin-tdep.h: Rename include guard.
7633         * hppa-linux-offsets.h: Add include guard.
7634         * guile/guile.h: Rename include guard.
7635         * guile/guile-internal.h: Rename include guard.
7636         * gnu-nat.h: Rename include guard.
7637         * gdb-stabs.h: Rename include guard.
7638         * frv-tdep.h: Add include guard.
7639         * f-lang.h: Add include guard.
7640         * event-loop.h: Add include guard.
7641         * darwin-nat.h: Rename include guard.
7642         * cp-abi.h: Rename include guard.
7643         * config/sparc/nm-sol2.h: Rename include guard.
7644         * config/nm-nto.h: Rename include guard.
7645         * config/nm-linux.h: Add include guard.
7646         * config/i386/nm-i386gnu.h: Rename include guard.
7647         * config/djgpp/nl_types.h: Rename include guard.
7648         * config/djgpp/langinfo.h: Rename include guard.
7649         * compile/gcc-cp-plugin.h: Add include guard.
7650         * compile/gcc-c-plugin.h: Add include guard.
7651         * compile/compile.h: Rename include guard.
7652         * compile/compile-object-run.h: Rename include guard.
7653         * compile/compile-object-load.h: Rename include guard.
7654         * compile/compile-internal.h: Rename include guard.
7655         * compile/compile-cplus.h: Rename include guard.
7656         * compile/compile-c.h: Rename include guard.
7657         * common/xml-utils.h: Rename include guard.
7658         * common/x86-xstate.h: Rename include guard.
7659         * common/version.h: Rename include guard.
7660         * common/vec.h: Rename include guard.
7661         * common/tdesc.h: Rename include guard.
7662         * common/selftest.h: Rename include guard.
7663         * common/scoped_restore.h: Rename include guard.
7664         * common/scoped_mmap.h: Rename include guard.
7665         * common/scoped_fd.h: Rename include guard.
7666         * common/safe-iterator.h: Rename include guard.
7667         * common/run-time-clock.h: Rename include guard.
7668         * common/refcounted-object.h: Rename include guard.
7669         * common/queue.h: Rename include guard.
7670         * common/ptid.h: Rename include guard.
7671         * common/print-utils.h: Rename include guard.
7672         * common/preprocessor.h: Rename include guard.
7673         * common/pathstuff.h: Rename include guard.
7674         * common/observable.h: Rename include guard.
7675         * common/netstuff.h: Rename include guard.
7676         * common/job-control.h: Rename include guard.
7677         * common/host-defs.h: Rename include guard.
7678         * common/gdb_wait.h: Rename include guard.
7679         * common/gdb_vecs.h: Rename include guard.
7680         * common/gdb_unlinker.h: Rename include guard.
7681         * common/gdb_unique_ptr.h: Rename include guard.
7682         * common/gdb_tilde_expand.h: Rename include guard.
7683         * common/gdb_sys_time.h: Rename include guard.
7684         * common/gdb_string_view.h: Rename include guard.
7685         * common/gdb_splay_tree.h: Rename include guard.
7686         * common/gdb_setjmp.h: Rename include guard.
7687         * common/gdb_ref_ptr.h: Rename include guard.
7688         * common/gdb_optional.h: Rename include guard.
7689         * common/gdb_locale.h: Rename include guard.
7690         * common/gdb_assert.h: Rename include guard.
7691         * common/filtered-iterator.h: Rename include guard.
7692         * common/filestuff.h: Rename include guard.
7693         * common/fileio.h: Rename include guard.
7694         * common/environ.h: Rename include guard.
7695         * common/common-utils.h: Rename include guard.
7696         * common/common-types.h: Rename include guard.
7697         * common/common-regcache.h: Rename include guard.
7698         * common/common-inferior.h: Rename include guard.
7699         * common/common-gdbthread.h: Rename include guard.
7700         * common/common-exceptions.h: Rename include guard.
7701         * common/common-defs.h: Rename include guard.
7702         * common/common-debug.h: Rename include guard.
7703         * common/cleanups.h: Rename include guard.
7704         * common/buffer.h: Rename include guard.
7705         * common/btrace-common.h: Rename include guard.
7706         * common/break-common.h: Rename include guard.
7707         * cli/cli-utils.h: Rename include guard.
7708         * cli/cli-style.h: Rename include guard.
7709         * cli/cli-setshow.h: Rename include guard.
7710         * cli/cli-script.h: Rename include guard.
7711         * cli/cli-interp.h: Rename include guard.
7712         * cli/cli-decode.h: Rename include guard.
7713         * cli/cli-cmds.h: Rename include guard.
7714         * charset-list.h: Add include guard.
7715         * buildsym-legacy.h: Rename include guard.
7716         * bfin-tdep.h: Add include guard.
7717         * ax.h: Rename include guard.
7718         * arm-linux-tdep.h: Add include guard.
7719         * arm-fbsd-tdep.h: Add include guard.
7720         * arch/xtensa.h: Rename include guard.
7721         * arch/tic6x.h: Add include guard.
7722         * arch/i386.h: Add include guard.
7723         * arch/arm.h: Rename include guard.
7724         * arch/arm-linux.h: Rename include guard.
7725         * arch/arm-get-next-pcs.h: Rename include guard.
7726         * arch/amd64.h: Add include guard.
7727         * arch/aarch64-insn.h: Rename include guard.
7728         * arch-utils.h: Rename include guard.
7729         * annotate.h: Add include guard.
7730         * amd64-darwin-tdep.h: Rename include guard.
7731         * aarch64-linux-tdep.h: Add include guard.
7732         * aarch64-fbsd-tdep.h: Add include guard.
7733         * aarch32-linux-nat.h: Add include guard.
7734
7735 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7736
7737         * macrotab.c (macro_define_internal): New function that
7738         factorizes macro_define_object_internal and macro_define_function
7739         code.
7740         (macro_define_object_internal): Use macro_define_internal.
7741         (macro_define_function): Likewise.
7742
7743 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7744
7745         * macrocmd.c (extract_identifier): Return
7746         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
7747         callers.
7748
7749 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
7750
7751         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
7752
7753 2019-02-05  Tom Tromey  <tom@tromey.com>
7754
7755         * target.c (target_stack::unpush): Move assertion earlier.
7756
7757 2019-01-30  Tom Tromey  <tom@tromey.com>
7758
7759         PR python/23615:
7760         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
7761         (gdbpy_parse_and_eval): Likewise.
7762         * python/python-internal.h (gdbpy_allow_threads): New class.
7763
7764 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
7765
7766         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
7767         (aarch64_fbsd_fpregmap): Move earlier.
7768         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
7769         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7770         instead of individual calls to trad_frame_set_reg_addr.
7771         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
7772         earlier.
7773         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
7774         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7775         instead of individual calls to trad_frame_set_reg_addr.
7776
7777 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
7778
7779         * CONTRIBUTE: Replace contribution list with wiki link.
7780
7781 2019-01-25  Tom Tromey  <tom@tromey.com>
7782
7783         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
7784
7785 2019-01-25  Tom Tromey  <tom@tromey.com>
7786
7787         * xtensa-linux-nat.c: Fix common/ includes.
7788         * xml-support.h: Fix common/ includes.
7789         * xml-support.c: Fix common/ includes.
7790         * x86-linux-nat.c: Fix common/ includes.
7791         * windows-nat.c: Fix common/ includes.
7792         * varobj.h: Fix common/ includes.
7793         * varobj.c: Fix common/ includes.
7794         * value.c: Fix common/ includes.
7795         * valops.c: Fix common/ includes.
7796         * utils.c: Fix common/ includes.
7797         * unittests/xml-utils-selftests.c: Fix common/ includes.
7798         * unittests/utils-selftests.c: Fix common/ includes.
7799         * unittests/unpack-selftests.c: Fix common/ includes.
7800         * unittests/tracepoint-selftests.c: Fix common/ includes.
7801         * unittests/style-selftests.c: Fix common/ includes.
7802         * unittests/string_view-selftests.c: Fix common/ includes.
7803         * unittests/scoped_restore-selftests.c: Fix common/ includes.
7804         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
7805         * unittests/scoped_fd-selftests.c: Fix common/ includes.
7806         * unittests/rsp-low-selftests.c: Fix common/ includes.
7807         * unittests/parse-connection-spec-selftests.c: Fix common/
7808         includes.
7809         * unittests/optional-selftests.c: Fix common/ includes.
7810         * unittests/offset-type-selftests.c: Fix common/ includes.
7811         * unittests/observable-selftests.c: Fix common/ includes.
7812         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
7813         * unittests/memrange-selftests.c: Fix common/ includes.
7814         * unittests/memory-map-selftests.c: Fix common/ includes.
7815         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
7816         * unittests/function-view-selftests.c: Fix common/ includes.
7817         * unittests/environ-selftests.c: Fix common/ includes.
7818         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
7819         * unittests/common-utils-selftests.c: Fix common/ includes.
7820         * unittests/cli-utils-selftests.c: Fix common/ includes.
7821         * unittests/array-view-selftests.c: Fix common/ includes.
7822         * ui-file.c: Fix common/ includes.
7823         * tui/tui-io.c: Fix common/ includes.
7824         * tracepoint.h: Fix common/ includes.
7825         * tracepoint.c: Fix common/ includes.
7826         * tracefile-tfile.c: Fix common/ includes.
7827         * top.h: Fix common/ includes.
7828         * top.c: Fix common/ includes.
7829         * thread.c: Fix common/ includes.
7830         * target/waitstatus.h: Fix common/ includes.
7831         * target/waitstatus.c: Fix common/ includes.
7832         * target.h: Fix common/ includes.
7833         * target.c: Fix common/ includes.
7834         * target-memory.c: Fix common/ includes.
7835         * target-descriptions.c: Fix common/ includes.
7836         * symtab.h: Fix common/ includes.
7837         * symfile.c: Fix common/ includes.
7838         * stap-probe.c: Fix common/ includes.
7839         * spu-linux-nat.c: Fix common/ includes.
7840         * sparc-nat.c: Fix common/ includes.
7841         * source.c: Fix common/ includes.
7842         * solib.c: Fix common/ includes.
7843         * solib-target.c: Fix common/ includes.
7844         * ser-unix.c: Fix common/ includes.
7845         * ser-tcp.c: Fix common/ includes.
7846         * ser-pipe.c: Fix common/ includes.
7847         * ser-base.c: Fix common/ includes.
7848         * selftest-arch.c: Fix common/ includes.
7849         * s12z-tdep.c: Fix common/ includes.
7850         * rust-exp.y: Fix common/ includes.
7851         * rs6000-aix-tdep.c: Fix common/ includes.
7852         * riscv-tdep.c: Fix common/ includes.
7853         * remote.c: Fix common/ includes.
7854         * remote-notif.h: Fix common/ includes.
7855         * remote-fileio.h: Fix common/ includes.
7856         * remote-fileio.c: Fix common/ includes.
7857         * regcache.h: Fix common/ includes.
7858         * regcache.c: Fix common/ includes.
7859         * record-btrace.c: Fix common/ includes.
7860         * python/python.c: Fix common/ includes.
7861         * python/py-type.c: Fix common/ includes.
7862         * python/py-inferior.c: Fix common/ includes.
7863         * progspace.h: Fix common/ includes.
7864         * producer.c: Fix common/ includes.
7865         * procfs.c: Fix common/ includes.
7866         * proc-api.c: Fix common/ includes.
7867         * printcmd.c: Fix common/ includes.
7868         * ppc-linux-nat.c: Fix common/ includes.
7869         * parser-defs.h: Fix common/ includes.
7870         * osdata.c: Fix common/ includes.
7871         * obsd-nat.c: Fix common/ includes.
7872         * nat/x86-linux.c: Fix common/ includes.
7873         * nat/x86-linux-dregs.c: Fix common/ includes.
7874         * nat/x86-dregs.h: Fix common/ includes.
7875         * nat/x86-dregs.c: Fix common/ includes.
7876         * nat/ppc-linux.c: Fix common/ includes.
7877         * nat/mips-linux-watch.h: Fix common/ includes.
7878         * nat/mips-linux-watch.c: Fix common/ includes.
7879         * nat/linux-waitpid.c: Fix common/ includes.
7880         * nat/linux-ptrace.h: Fix common/ includes.
7881         * nat/linux-ptrace.c: Fix common/ includes.
7882         * nat/linux-procfs.c: Fix common/ includes.
7883         * nat/linux-personality.c: Fix common/ includes.
7884         * nat/linux-osdata.c: Fix common/ includes.
7885         * nat/linux-namespaces.c: Fix common/ includes.
7886         * nat/linux-btrace.h: Fix common/ includes.
7887         * nat/linux-btrace.c: Fix common/ includes.
7888         * nat/fork-inferior.c: Fix common/ includes.
7889         * nat/amd64-linux-siginfo.c: Fix common/ includes.
7890         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
7891         * nat/aarch64-linux.c: Fix common/ includes.
7892         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
7893         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
7894         * namespace.h: Fix common/ includes.
7895         * mips-linux-tdep.c: Fix common/ includes.
7896         * minsyms.c: Fix common/ includes.
7897         * mi/mi-parse.h: Fix common/ includes.
7898         * mi/mi-main.c: Fix common/ includes.
7899         * mi/mi-cmd-env.c: Fix common/ includes.
7900         * memrange.h: Fix common/ includes.
7901         * memattr.c: Fix common/ includes.
7902         * maint.h: Fix common/ includes.
7903         * maint.c: Fix common/ includes.
7904         * main.c: Fix common/ includes.
7905         * machoread.c: Fix common/ includes.
7906         * location.c: Fix common/ includes.
7907         * linux-thread-db.c: Fix common/ includes.
7908         * linux-nat.c: Fix common/ includes.
7909         * linux-fork.c: Fix common/ includes.
7910         * inline-frame.c: Fix common/ includes.
7911         * infrun.c: Fix common/ includes.
7912         * inflow.c: Fix common/ includes.
7913         * inferior.h: Fix common/ includes.
7914         * inferior.c: Fix common/ includes.
7915         * infcmd.c: Fix common/ includes.
7916         * inf-ptrace.c: Fix common/ includes.
7917         * inf-child.c: Fix common/ includes.
7918         * ia64-linux-nat.c: Fix common/ includes.
7919         * i387-tdep.c: Fix common/ includes.
7920         * i386-tdep.c: Fix common/ includes.
7921         * i386-linux-tdep.c: Fix common/ includes.
7922         * i386-linux-nat.c: Fix common/ includes.
7923         * i386-go32-tdep.c: Fix common/ includes.
7924         * i386-fbsd-tdep.c: Fix common/ includes.
7925         * i386-fbsd-nat.c: Fix common/ includes.
7926         * guile/scm-type.c: Fix common/ includes.
7927         * guile/guile.c: Fix common/ includes.
7928         * go32-nat.c: Fix common/ includes.
7929         * gnu-nat.c: Fix common/ includes.
7930         * gdbthread.h: Fix common/ includes.
7931         * gdbarch-selftests.c: Fix common/ includes.
7932         * gdb_usleep.c: Fix common/ includes.
7933         * gdb_select.h: Fix common/ includes.
7934         * gdb_bfd.c: Fix common/ includes.
7935         * gcore.c: Fix common/ includes.
7936         * fork-child.c: Fix common/ includes.
7937         * findvar.c: Fix common/ includes.
7938         * fbsd-nat.c: Fix common/ includes.
7939         * event-top.c: Fix common/ includes.
7940         * event-loop.c: Fix common/ includes.
7941         * dwarf2read.c: Fix common/ includes.
7942         * dwarf2loc.c: Fix common/ includes.
7943         * dwarf2-frame.c: Fix common/ includes.
7944         * dwarf-index-cache.c: Fix common/ includes.
7945         * dtrace-probe.c: Fix common/ includes.
7946         * disasm-selftests.c: Fix common/ includes.
7947         * defs.h: Fix common/ includes.
7948         * csky-tdep.c: Fix common/ includes.
7949         * cp-valprint.c: Fix common/ includes.
7950         * cp-support.h: Fix common/ includes.
7951         * cp-support.c: Fix common/ includes.
7952         * corelow.c: Fix common/ includes.
7953         * completer.h: Fix common/ includes.
7954         * completer.c: Fix common/ includes.
7955         * compile/compile.c: Fix common/ includes.
7956         * compile/compile-loc2c.c: Fix common/ includes.
7957         * compile/compile-cplus-types.c: Fix common/ includes.
7958         * compile/compile-cplus-symbols.c: Fix common/ includes.
7959         * command.h: Fix common/ includes.
7960         * cli/cli-dump.c: Fix common/ includes.
7961         * cli/cli-cmds.c: Fix common/ includes.
7962         * charset.c: Fix common/ includes.
7963         * build-id.c: Fix common/ includes.
7964         * btrace.h: Fix common/ includes.
7965         * btrace.c: Fix common/ includes.
7966         * breakpoint.h: Fix common/ includes.
7967         * breakpoint.c: Fix common/ includes.
7968         * ax.h:
7969         (enum agent_op): Fix common/ includes.
7970         * ax-general.c (struct aop_map): Fix common/ includes.
7971         * ax-gdb.c: Fix common/ includes.
7972         * auxv.c: Fix common/ includes.
7973         * auto-load.c: Fix common/ includes.
7974         * arm-tdep.c: Fix common/ includes.
7975         * arch/riscv.c: Fix common/ includes.
7976         * arch/ppc-linux-common.c: Fix common/ includes.
7977         * arch/i386.c: Fix common/ includes.
7978         * arch/arm.c: Fix common/ includes.
7979         * arch/arm-linux.c: Fix common/ includes.
7980         * arch/arm-get-next-pcs.c: Fix common/ includes.
7981         * arch/amd64.c: Fix common/ includes.
7982         * arch/aarch64.c: Fix common/ includes.
7983         * arch/aarch64-insn.c: Fix common/ includes.
7984         * arch-utils.c: Fix common/ includes.
7985         * amd64-windows-tdep.c: Fix common/ includes.
7986         * amd64-tdep.c: Fix common/ includes.
7987         * amd64-sol2-tdep.c: Fix common/ includes.
7988         * amd64-obsd-tdep.c: Fix common/ includes.
7989         * amd64-nbsd-tdep.c: Fix common/ includes.
7990         * amd64-linux-tdep.c: Fix common/ includes.
7991         * amd64-linux-nat.c: Fix common/ includes.
7992         * amd64-fbsd-tdep.c: Fix common/ includes.
7993         * amd64-fbsd-nat.c: Fix common/ includes.
7994         * amd64-dicos-tdep.c: Fix common/ includes.
7995         * amd64-darwin-tdep.c: Fix common/ includes.
7996         * agent.c: Fix common/ includes.
7997         * ada-lang.h: Fix common/ includes.
7998         * ada-lang.c: Fix common/ includes.
7999         * aarch64-tdep.c: Fix common/ includes.
8000
8001 2019-01-25  Tom Tromey  <tom@tromey.com>
8002
8003         * common/create-version.sh: Use common/version.h.
8004
8005 2019-01-24  Pedro Alves  <palves@redhat.com>
8006
8007         * infrun.c (signal_stop, signal_print, signal_program)
8008         (signal_catch, signal_pass): Now arrays instead of pointers.
8009         (update_signals_program_target, do_target_resume)
8010         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8011         * linux-nat.c (linux_nat_target::pass_signals)
8012         (linux_nat_target::create_inferior, linux_nat_target::attach):
8013         Adjust.
8014         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8015         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8016         * procfs.c (procfs_target::pass_signals): Adjust.
8017         * record-full.c (record_full_target::resume): Adjust.
8018         * remote.c (remote_target::pass_signals)
8019         (remote_target::program_signals): Adjust.
8020         * target-debug.h (target_debug_print_signals): Now takes a
8021         gdb::array_view as parameter.  Adjust.
8022         * target.h (target_ops) <pass_signals, program_signals>: Replace
8023         pointer and length parameters with gdb::array_view.
8024         (target_pass_signals, target_program_signals): Likewise.
8025         * target-delegates.c: Regenerate.
8026
8027 2019-01-24  Pedro Alves  <palves@redhat.com>
8028
8029         * common/forward-scope-exit.h
8030         (forward_scope_exit::forward_scope_exit): Pass arguments to
8031         m_bind_function directly, instead of creating a std::bind and
8032         copying that.
8033
8034 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8035
8036         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8037         for static members.
8038         (pass_in_v_vfp_candidate): Likewise.
8039
8040 2019-01-23  Tom Tromey  <tom@tromey.com>
8041             Pedro Alves  <palves@redhat.com>
8042
8043         * regcache.c (class regcache_invalidator): Remove.
8044         (regcache::raw_write): Use make_scope_exit.
8045
8046 2019-01-23  Tom Tromey  <tom@tromey.com>
8047
8048         * ui-out.h (class ui_out_emit_type): Update comment.
8049
8050 2019-01-23  Tom Tromey  <tom@tromey.com>
8051
8052         * infrun.c (fetch_inferior_event): Update comment.
8053
8054 2019-01-23  Tom Tromey  <tom@tromey.com>
8055             Pedro Alves  <palves@redhat.com>
8056
8057         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8058         parameter.
8059         (fetch_inferior_event): Use SCOPE_EXIT.
8060
8061
8062 2019-01-23  Tom Tromey  <tom@tromey.com>
8063             Pedro Alves  <palves@redhat.com>
8064
8065         * infrun.c (disable_thread_events): Delete.
8066         (stop_all_threads): Use SCOPE_EXIT.
8067
8068 2019-01-23  Tom Tromey  <tom@tromey.com>
8069             Pedro Alves  <palves@redhat.com>
8070
8071         * symfile.c: Include forward-scope-exit.h.
8072         (clear_symtab_users_cleanup): Replace forward declaration with
8073         a FORWARD_SCOPE_EXIT.
8074         (syms_from_objfile_1): Use the forward_scope_exit and
8075         gdb::optional instead of cleanup_function.
8076         (reread_symbols): Use the forward_scope_exit instead of
8077         cleanup_function.
8078         (clear_symtab_users_cleanup): Remove function.
8079
8080 2019-01-23  Tom Tromey  <tom@tromey.com>
8081             Pedro Alves  <palves@redhat.com>
8082
8083         * linux-nat.c: Include scope-exit.h.
8084         (cleanup_target_stop): Remove.
8085         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8086         SCOPE_EXIT.
8087
8088 2019-01-23  Tom Tromey  <tom@tromey.com>
8089             Pedro Alves  <palves@redhat.com>
8090
8091         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8092         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8093
8094 2019-01-23  Tom Tromey  <tom@tromey.com>
8095             Andrew Burgess  <andrew.burgess@embecosm.com>
8096             Pedro Alves  <palves@redhat.com>
8097
8098         * infrun.c (fetch_inferior_event): Use scope_exit.
8099         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8100         * top.c (execute_command): Use scope_exit.
8101         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8102         * utils.c (do_bpstat_clear_actions_cleanup)
8103         (make_bpstat_clear_actions_cleanup): Remove.
8104
8105 2019-01-23  Tom Tromey  <tom@tromey.com>
8106             Pedro Alves  <palves@redhat.com>
8107
8108         * infrun.c: Include "common/scope-exit.h"
8109         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8110         (wait_for_inferior): Use SCOPE_EXIT.
8111         (fetch_inferior_event): Use scope_exit.
8112
8113 2019-01-23  Tom Tromey  <tom@tromey.com>
8114             Pedro Alves  <palves@redhat.com>
8115
8116         * breakpoint.c (create_breakpoint): Remove cleanup.
8117
8118 2019-01-23  Tom Tromey  <tom@tromey.com>
8119             Andrew Burgess  <andrew.burgess@embecosm.com>
8120             Pedro Alves  <palves@redhat.com>
8121
8122 2019-01-23  Pedro Alves  <palves@redhat.com>
8123
8124         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8125
8126 2019-01-23  Pedro Alves  <palves@redhat.com>
8127             Andrew Burgess  <andrew.burgess@embecosm.com>
8128
8129         * gdbthread.h: Include "common/forward-scope-exit.h".
8130         (scoped_finish_thread_state): Redefine custom class in terms of
8131         forward_scope_exit.
8132
8133 2019-01-23  Pedro Alves  <palves@redhat.com>
8134             Andrew Burgess  <andrew.burgess@embecosm.com>
8135
8136         * common/forward-scope-exit.h: New file.
8137
8138 2019-01-23  Pedro Alves  <palves@redhat.com>
8139             Andrew Burgess  <andrew.burgess@embecosm.com>
8140             Tom Tromey  <tom@tromey.com>
8141
8142         * common/scope-exit.h: New file.
8143
8144 2019-01-23  Pedro Alves  <palves@redhat.com>
8145
8146         * common/preprocessor.h (ESC): Rename to ...
8147         (ESC_PARENS): ... this.
8148         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8149         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8150
8151 2019-01-23  Tom Tromey  <tom@tromey.com>
8152
8153         * language.h (class scoped_switch_to_sym_language_if_auto):
8154         Initialize m_lang in both cases.
8155
8156 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
8157
8158         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8159         with XCNEW.
8160
8161 2019-01-22  Tom Tromey  <tom@tromey.com>
8162
8163         * corelow.c: Do not include sys/file.h.
8164
8165 2019-01-22  Tom Tromey  <tom@tromey.com>
8166
8167         * tui/tui-wingeneral.h: Include gdb_curses.h.
8168
8169 2019-01-22  Tom Tromey  <tom@tromey.com>
8170
8171         * source-cache.h (class source_cache) <get_source_lines,
8172         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
8173
8174 2019-01-22  Tom Tromey  <tom@tromey.com>
8175
8176         * remote-fileio.h (struct remote_target): Declare.
8177
8178 2019-01-22  Tom Tromey  <tom@tromey.com>
8179
8180         * python/py-arch.c: Do not include py-ref.h.
8181         * python/py-bpevent.c: Do not include py-ref.h.
8182         * python/py-cmd.c: Do not include py-ref.h.
8183         * python/py-continueevent.c: Do not include py-ref.h.
8184         * python/py-event.h: Do not include py-ref.h.
8185         * python/py-evtregistry.c: Do not include py-ref.h.
8186         * python/py-finishbreakpoint.c: Do not include py-ref.h.
8187         * python/py-frame.c: Do not include py-ref.h.
8188         * python/py-framefilter.c: Do not include py-ref.h.
8189         * python/py-function.c: Do not include py-ref.h.
8190         * python/py-infevents.c: Do not include py-ref.h.
8191         * python/py-linetable.c: Do not include py-ref.h.
8192         * python/py-objfile.c: Do not include py-ref.h.
8193         * python/py-param.c: Do not include py-ref.h.
8194         * python/py-prettyprint.c: Do not include py-ref.h.
8195         * python/py-progspace.c: Do not include py-ref.h.
8196         * python/py-symbol.c: Do not include py-ref.h.
8197         * python/py-symtab.c: Do not include py-ref.h.
8198         * python/py-type.c: Do not include py-ref.h.
8199         * python/py-unwind.c: Do not include py-ref.h.
8200         * python/py-utils.c: Do not include py-ref.h.
8201         * python/py-value.c: Do not include py-ref.h.
8202         * python/py-varobj.c: Do not include py-ref.h.
8203         * python/py-xmethods.c: Do not include py-ref.h.
8204         * python/python.c: Do not include py-ref.h.
8205         * varobj.c: Do not include py-ref.h.
8206
8207 2019-01-22  Tom Tromey  <tom@tromey.com>
8208
8209         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
8210         keyword for bcache.
8211
8212 2019-01-22  Tom Tromey  <tom@tromey.com>
8213
8214         * compile/compile-cplus-types.c: Remove a comment by #include.
8215
8216 2019-01-22  Tom Tromey  <tom@tromey.com>
8217
8218         * compile/gcc-c-plugin.h: Include compile-internal.h.
8219
8220 2019-01-22  Tom Tromey  <tom@tromey.com>
8221
8222         * stabsread.c (EXTERN): Do not define.
8223         (symnum, next_symbol_text_func, processing_gcc_compilation)
8224         (within_function, global_sym_chain, global_stabs)
8225         (previous_stab_code, this_object_header_files)
8226         (n_this_object_header_files)
8227         (n_allocated_this_object_header_files): Define.
8228         * stabsread.h (EXTERN): Never define.  Use "extern".
8229
8230 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8231
8232         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
8233         history_value.
8234
8235 2019-01-21  Tom Tromey  <tom@tromey.com>
8236
8237         * ui-out.c: Fix includes.
8238         * tui/tui-source.c: Fix includes.
8239         * target.c: Fix includes.
8240         * remote.c: Fix includes.
8241         * regcache.c: Fix includes.
8242         * python/py-block.c: Fix includes.
8243         * printcmd.c: Fix includes.
8244         * or1k-tdep.c: Fix includes.
8245         * mi/mi-main.c: Fix includes.
8246         * m32r-tdep.c: Fix includes.
8247         * csky-tdep.c: Fix includes.
8248         * compile/compile-cplus-types.c: Fix includes.
8249         * cli/cli-interp.c: Fix includes.
8250
8251 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
8252
8253         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8254         for padding.
8255
8256 2019-01-16  Tom Tromey  <tom@tromey.com>
8257
8258         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
8259         earlier.
8260         (struct objfile) <msymbols_range>: Move from top level.
8261         <msymbols>: New method.
8262         (class objfile_msymbols): Remove.
8263         * symtab.c (default_collect_symbol_completion_matches_break_on):
8264         Update.
8265         * symmisc.c (dump_msymbols): Update.
8266         * stabsread.c (scan_file_globals): Update.
8267         * objc-lang.c (info_selectors_command, info_classes_command)
8268         (find_methods): Update.
8269         * minsyms.c (find_solib_trampoline_target): Update.
8270         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
8271         * coffread.c (coff_symfile_read): Update.
8272         * ada-lang.c (ada_lookup_simple_minsym)
8273         (ada_collect_symbol_completion_matches): Update.
8274
8275 2019-01-16  Tom Tromey  <tom@tromey.com>
8276
8277         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
8278         type.  Remove no-argument constructor.
8279         <iterator::operator++>: Simplify.
8280         <begin>: Update.
8281         <end>: Use minimal_symbol_count.
8282
8283 2019-01-16  Tom Tromey  <tom@tromey.com>
8284
8285         * objfiles.h (struct objfile) <psymtabs>: New method.
8286         (class objfile_psymtabs): Remove.
8287         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
8288         typedef.
8289         <range>: New method.
8290         (require_partial_symbols): Change return type.
8291         * psymtab.c (require_partial_symbols)
8292         (psym_expand_symtabs_matching): Update.
8293         * mdebugread.c (parse_partial_symbols): Update.
8294         * dbxread.c (dbx_end_psymtab): Update.
8295
8296 2019-01-15  Tom Tromey  <tom@tromey.com>
8297
8298         * symtab.c (lookup_objfile_from_block)
8299         (lookup_symbol_in_objfile_symtabs)
8300         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
8301         (find_line_symtab, info_sources_command)
8302         (default_collect_symbol_completion_matches_break_on)
8303         (make_source_files_completion_list): Update.
8304         * symmisc.c (print_objfile_statistics, dump_objfile)
8305         (maintenance_print_symbols, maintenance_info_symtabs)
8306         (maintenance_check_symtabs, maintenance_info_line_tables):
8307         Update.
8308         * source.c (select_source_symtab)
8309         (forget_cached_source_info_for_objfile): Update.
8310         * objfiles.h (class objfile_compunits): Remove.
8311         (struct objfile) <compunits_range>: New typedef.
8312         (compunits): New method.
8313         * objfiles.c (objfile_relocate1): Update.
8314         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8315         * maint.c (count_symtabs_and_blocks): Update.
8316         * linespec.c (iterate_over_all_matching_symtabs): Update.
8317         * cp-support.c (add_symbol_overload_list_qualified): Update.
8318         * coffread.c (coff_symtab_read): Update.
8319         * ada-lang.c (add_nonlocal_symbols)
8320         (ada_collect_symbol_completion_matches)
8321         (ada_add_global_exceptions): Update.
8322
8323 2019-01-15  Tom Tromey  <tom@tromey.com>
8324
8325         * progspace.h (program_space) <objfiles_safe_range>: New
8326         typedef.
8327         <objfiles_safe>: New method.
8328         * objfiles.h (class all_objfiles_safe): Remove.
8329         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
8330         * jit.c (jit_inferior_exit_hook): Update.
8331
8332 2019-01-17  Tom Tromey  <tom@tromey.com>
8333
8334         * progspace.h (program_space) <objfiles_range>: New typedef.
8335         <objfiles>: New method.
8336         <objfiles_head>: Rename from objfiles.
8337         (object_files): Update.
8338         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
8339         * guile/scm-pretty-print.c
8340         (ppscm_find_pretty_printer_from_objfiles): Update.
8341         * guile/scm-objfile.c (gdbscm_objfiles): Update.
8342         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
8343         Update.
8344         * python/py-progspace.c (pspy_get_objfiles): Update.
8345         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8346         Update.
8347         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8348         (objfpy_lookup_objfile_by_build_id): Update.
8349         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8350         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8351         Update.
8352         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8353         (expand_symtab_containing_pc, lookup_objfile_from_block)
8354         (lookup_static_symbol, basic_lookup_transparent_type)
8355         (find_pc_sect_compunit_symtab, find_symbol_at_address)
8356         (find_line_symtab, info_sources_command)
8357         (default_collect_symbol_completion_matches_break_on)
8358         (make_source_files_completion_list, find_main_name): Update.
8359         * symmisc.c (print_symbol_bcache_statistics)
8360         (print_objfile_statistics, maintenance_print_symbols)
8361         (maintenance_print_msymbols, maintenance_print_objfiles)
8362         (maintenance_info_symtabs, maintenance_check_symtabs)
8363         (maintenance_expand_symtabs, maintenance_info_line_tables):
8364         Update.
8365         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
8366         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
8367         (map_overlay_command, unmap_overlay_command)
8368         (simple_overlay_update, expand_symtabs_matching)
8369         (map_symbol_filenames): Update.
8370         * symfile-debug.c (set_debug_symfile): Update.
8371         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
8372         Update.
8373         * source.c (select_source_symtab, forget_cached_source_info):
8374         Update.
8375         * solib.c (solib_read_symbols): Update.
8376         * solib-spu.c (append_ocl_sos): Update.
8377         * psymtab.c (maintenance_print_psymbols)
8378         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
8379         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
8380         * printcmd.c (info_symbol_command): Update.
8381         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
8382         Update.
8383         * objfiles.h (class all_objfiles): Remove.
8384         * objfiles.c (have_partial_symbols, have_full_symbols)
8385         (have_minimal_symbols, qsort_cmp, update_section_map)
8386         (shared_objfile_contains_address_p)
8387         (default_iterate_over_objfiles_in_search_order): Update.
8388         * objc-lang.c (info_selectors_command, info_classes_command)
8389         (find_methods): Update.
8390         * minsyms.c (find_solib_trampoline_target): Update.
8391         * maint.c (maintenance_info_sections)
8392         (maintenance_translate_address, count_symtabs_and_blocks):
8393         Update.
8394         * main.c (captured_main_1): Update.
8395         * linux-thread-db.c (try_thread_db_load_from_pdir)
8396         (has_libpthread): Update.
8397         * linespec.c (iterate_over_all_matching_symtabs)
8398         (search_minsyms_for_name): Update.
8399         * jit.c (jit_find_objf_with_entry_addr): Update.
8400         * hppa-tdep.c (find_unwind_entry)
8401         (hppa_lookup_stub_minimal_symbol): Update.
8402         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
8403         Update.
8404         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8405         (elf_gnu_ifunc_resolve_by_got): Update.
8406         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
8407         * dwarf-index-write.c (save_gdb_index_command): Update.
8408         * cp-support.c (add_symbol_overload_list_qualified): Update.
8409         * breakpoint.c (create_overlay_event_breakpoint)
8410         (create_longjmp_master_breakpoint)
8411         (create_std_terminate_master_breakpoint)
8412         (create_exception_master_breakpoint): Update.
8413         * blockframe.c (find_pc_partial_function): Update.
8414         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
8415         (ada_collect_symbol_completion_matches)
8416         (ada_add_global_exceptions): Update.
8417
8418 2019-01-17  Tom Tromey  <tom@tromey.com>
8419
8420         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
8421         declare VEC.
8422         (solib_target_parse_libraries): Change return type.
8423         (library_list_start_segment, library_list_start_section)
8424         (library_list_end_library, library_list_start_library); Update.
8425         (solib_target_free_library_list): Remove.
8426         (solib_target_parse_libraries): Remove cleanup.  Change return
8427         type.
8428         (solib_target_current_sos): Update.
8429
8430 2019-01-17  Tom Tromey  <tromey@bapiya>
8431
8432         * valprint.c: Replace "the the" with "the".
8433         * symtab.c: Replace "the the" with "the".
8434         * solib.c: Replace "the the" with "the".
8435         * solib-dsbt.c: Replace "the the" with "the".
8436         * linespec.c: Replace "the the" with "the".
8437         * dwarf2loc.h: Replace "the the" with "the".
8438         * amd64-windows-tdep.c: Replace "the the" with "the".
8439         * aarch64-tdep.c: Replace "the the" with "the".
8440
8441 2019-01-16  Keith Seitz  <keiths@redhat.com>
8442
8443         PR gdb/23773
8444         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
8445         <builder>: Rename to ..
8446         <m_builder>: ... this and make private.
8447         (dwarf2_cu::get_builder): New method.  Change all users of
8448         `builder' to use this method.
8449         (dwarf2_start_symtab): Move to ...
8450         (dwarf2_cu::start_symtab): ... here.  Update all callers
8451         (setup_type_unit_groups): Move to ...
8452         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
8453         callers.
8454         (dwarf2_cu::reset_builder): New method.
8455         (process_full_compunit, process_full_type_unit): Use
8456         dwarf2_cu::reset_builder.
8457         (follow_die_offset): Record the ancestor CU if it is different
8458         from the followed DIE's CU.
8459         (follow_die_sig_1): Likewise.
8460
8461 2019-01-15  Tom Tromey  <tom@tromey.com>
8462
8463         * remote.c (class remote_state) <buf>: Now a char_vector.
8464         <buf_size>: Remove.
8465         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
8466         parameter.
8467         (remote_target::getpkt_or_notif_sane_1)
8468         (remote_target::getpkt_sane)
8469         (remote_target::getpkt_or_notif_sane): Likewise.
8470         (class remote_target) <putpkt>: New overload.
8471         (remote_target::read_frame): Change type of "buf_p".  Remove
8472         sizeof_p parameter.
8473         (packet_ok): New overload.
8474         (packet_check_result): New overload.
8475         Update all uses.
8476
8477 2019-01-14  Tom Tromey  <tom@tromey.com>
8478
8479         * remote-notif.c (handle_notification, remote_notif_ack)
8480         (remote_notif_parse): Make "buf" const.
8481         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
8482         const.
8483         (remote_notif_parse, remote_notif_ack, handle_notification):
8484         Likewise.
8485         * remote.c (remote_notif_stop_parse): Make "buf" const.
8486         (remote_target::remote_parse_stop_reply): Make "buf" const.
8487         (remote_notif_stop_ack): Make "buf" const.
8488
8489 2019-01-14  Tom Tromey  <tom@tromey.com>
8490
8491         * remote.c (remote_console_output): Make parameter const.
8492
8493 2019-01-14  Tom Tromey  <tom@tromey.com>
8494
8495         * target-debug.h (target_debug_print_signals): Constify.
8496         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
8497         * procfs.c (procfs_target::pass_signals): Update.
8498         * linux-nat.c (linux_nat_target::pass_signals): Update.
8499         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
8500         * target-delegates.c: Rebuild.
8501         * remote.c (remote_target::program_signals): Update.
8502         (remote_target::pass_signals): Update.
8503         * target.c (target_pass_signals): Constify argument.
8504         (target_program_signals): Likewise.
8505         * target.h (struct target_ops) <pass_signals, program_signals>:
8506         Constify argument.
8507         (target_pass_signals, target_program_signals): Constify argument.
8508
8509 2019-01-14  Tom Tromey  <tom@tromey.com>
8510
8511         PR tui/28819:
8512         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
8513
8514 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
8515
8516         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
8517         field.
8518         * rs6000-tdep.c: Include reggroups.h.
8519         (IS_V_ALIAS_PSEUDOREG): Define.
8520         (rs6000_register_name): Return names for the "vX" aliases.
8521         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
8522         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
8523         aliases.  Call default_register_reggroup_p for all other
8524         pseudo-registers.
8525         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
8526         New functions.
8527         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
8528         Handle "vX" aliases.
8529         (v_alias_pseudo_register_collect): New function.
8530         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
8531         (rs6000_gdbarch_init): Initialize "vX" aliases as
8532         pseudo-registers.  Restore registration of
8533         rs6000_pseudo_register_reggroup_p with
8534         set_tdesc_pseudo_register_reggroup_p.
8535
8536 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
8537
8538         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
8539         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
8540         set_gdbarch_num_pseudo_regs.
8541
8542 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8543
8544         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
8545         Remove arg prefixname, add do_set and do_show.
8546         Add member functions set_list and show_list.
8547         * cli/cli-style.c (class cli_style_option): Update accordingly.
8548         (style_set_list): Move to file scope.
8549         (style_show_list): Likewise.
8550         (set_style): Call help_list.
8551         (show_style): Call cmd_show_list.
8552         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
8553         Update to use the new macro.
8554
8555 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
8556
8557         * ada-lang.c (_initialize_ada_language): Expand the help text
8558         for the "catch exception" command.
8559
8560 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8561
8562         * symtab.c (matching_obj_sections): Initialize obj,
8563         declare it closer to its usage.
8564
8565 2019-01-10  Tom Tromey  <tom@tromey.com>
8566
8567         * thread-iter.h (inf_threads_iterator): Use next_iterator.
8568         (basic_inf_threads_range): Remove.
8569         (inf_threads_range, inf_non_exited_threads_range)
8570         (safe_inf_threads_range): Use next_adapter.
8571
8572 2019-01-10  Keith Seitz  <keiths@redhat.com>
8573
8574         PR gdb/23712
8575         PR symtab/23010
8576         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
8577         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
8578
8579 2019-01-10  Keith Seitz  <keiths@redhat.com>
8580
8581         PR gdb/23712
8582         PR symtab/23010
8583         * dictionary.c (pending_to_vector): Remove.
8584         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8585         Remove _1 suffix, replacing functions of the same name.  Update
8586         all callers.
8587         (dict_create_hashed, dict_create_hashed_expandable)
8588         (dict_create_linear, dict_create_linear_expandable, dict_free)
8589         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
8590         Make functions static.
8591
8592 2019-01-10  Keith Seitz  <keiths@redhat.com>
8593
8594         PR gdb/23712
8595         PR symtab/23010
8596         * dictionary.h (struct dictionary): Replace declaration with
8597         multidictionary.
8598         (dict_create_hashed, dict_create_hashed_expandable)
8599         (dict_create_linear, dict_create_linear_expandable)
8600         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
8601         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
8602         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
8603         taking multidictionary argument.
8604         [ALL_DICT_SYMBOLS]: Update for multidictionary.
8605         * block.h (struct block) <dict>: Change to multidictionary
8606         and rename `multidict'.
8607         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
8608         symmisc.c: Update all dictionary references to multidictionary.
8609
8610 2019-01-10  Keith Seitz  <keiths@redhat.com>
8611
8612         PR gdb/23712
8613         PR symtab/23010
8614         * dictionary.c: Include unordered_map.
8615         (pending_to_vector): New function.
8616         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8617         Rewrite the non-"_1" functions to take vector instead
8618         of linked list.
8619         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
8620         "new" _1 versions of the same name.
8621         (multidictionary): Define.
8622         (std::hash<enum language): New definition.
8623         (collate_pending_symbols_by_language, mdict_create_hashed)
8624         (mdict_create_hashed_expandable, mdict_create_linear)
8625         (mdict_create_linear_expandable, mdict_free)
8626         (find_language_dictionary, create_new_language_dictionary)
8627         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
8628         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
8629         (mdict_size, mdict_empty): New functions.
8630         * dictionary.h (mdict_iterator): Define.
8631
8632 2019-01-10  Pedro Alves  <palves@redhat.com>
8633
8634         * breakpoint.c (read_uploaded_action)
8635         (create_tracepoint_from_upload): Adjust to use
8636         gdb::unique_xmalloc_ptr.
8637         * ctf.c (ctf_write_uploaded_tp):
8638         (SET_ARRAY_FIELD): Use emplace_back.
8639         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
8640         * tracefile-tfile.c (tfile_write_uploaded_tp):
8641         * tracepoint.c (parse_tracepoint_definition): Adjust to use
8642         gdb::unique_xmalloc_ptr.
8643         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
8644         at_string, cond_string, cmd_strings>: Replace char pointers
8645         with gdb::unique_xmalloc_ptr.
8646
8647 2019-01-10  Pedro Alves  <palves@redhat.com>
8648
8649         * solib-target.c (library_list_start_library): Don't xstrdup name.
8650
8651 2019-01-10  Pedro Alves  <palves@redhat.com>
8652
8653         * mdebugread.c (parse_partial_symbols): Use
8654         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
8655
8656 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8657
8658         * linux-fork.c (scoped_switch_fork_info)
8659         <~scoped_switch_fork_info>: Fix incorrect variable name.
8660
8661 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8662
8663         * linux-fork.c (scoped_switch_fork_info)
8664         <scoped_switch_fork_info>: Make explicit.
8665         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
8666
8667 2019-01-10  Tom Tromey  <tom@tromey.com>
8668
8669         * objfiles.h (objfile::reset_psymtabs): Update.
8670         * objfiles.c (objfile::objfile): Update.
8671         * psymtab.h (psymtab_storage::obstack): Update.
8672         (psymtab_storage::m_obstack): Use gdb::optional.
8673         (class psymtab_storage): Update comment.  Remove objfile
8674         parameter.
8675         * psymtab.c (psymtab_storage::psymtab_storage): Update.
8676
8677 2019-01-10  Tom Tromey  <tom@tromey.com>
8678
8679         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
8680         <free_psymtabs>: Now private.
8681         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
8682         (allocate_psymtab): Use new method.
8683
8684 2019-01-10  Tom Tromey  <tom@tromey.com>
8685
8686         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
8687         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
8688         * mdebugread.c (parse_partial_symbols): Use
8689         allocate_dependencies.
8690         * dwarf2read.c (dwarf2_create_include_psymtab): Use
8691         allocate_dependencies.
8692         (process_psymtab_comp_unit_reader)
8693         (build_type_psymtab_dependencies): Likewise.
8694         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
8695
8696 2019-01-10  Tom Tromey  <tom@tromey.com>
8697
8698         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
8699         PSYMBOL_SET_LANGUAGE.
8700         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
8701
8702 2019-01-10  Tom Tromey  <tom@tromey.com>
8703
8704         * psymtab.h (psymtab_storage::obstack): New method.
8705         <m_obstack>: Rename from obstack; now private.
8706         * psymtab.c (psymtab_storage): Update.
8707         * dwarf2read.c (create_addrmap_from_index)
8708         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
8709         Update.
8710
8711 2019-01-10  Tom Tromey  <tom@tromey.com>
8712
8713         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
8714         * objfiles.h (objfile::reset_psymtabs): New method.
8715
8716 2019-01-10  Tom Tromey  <tom@tromey.com>
8717
8718         * symmisc.c (print_symbol_bcache_statistics): Update.
8719         (print_objfile_statistics): Update.
8720         * symfile.c (reread_symbols): Update.
8721         * psymtab.h (class psymtab_storage): New.
8722         * psymtab.c (psymtab_storage): New constructor.
8723         (~psymtab_storage): New destructor.
8724         (require_partial_symbols): Update.
8725         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
8726         (find_pc_sect_psymtab, find_pc_sect_psymbol)
8727         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
8728         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
8729         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
8730         (start_psymtab_common, end_psymtab_common)
8731         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
8732         (allocate_psymtab): Update.
8733         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
8734         Update.
8735         (dump_psymtab_addrmap, maintenance_print_psymbols)
8736         (maintenance_check_psymtabs): Update.
8737         (class objfile_psymtabs): Move to objfiles.h.
8738         * psympriv.h (discard_psymtab): Now inline.
8739         (psymtab_discarder::psymtab_discarder): Update.
8740         (psymtab_discarder::~psymtab_discarder): Update.
8741         (ALL_OBJFILE_PSYMTABS): Rewrite.
8742         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
8743         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
8744         Remove fields.
8745         <partial_symtabs>: New field.
8746         (class objfile_psymtabs): Move from psymtab.h.  Update.
8747         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
8748         psymbol_cache.
8749         (objfile::~objfile): Don't destroy psymbol_cache.
8750         * mdebugread.c (parse_partial_symbols): Update.
8751         * dwarf2read.c (create_addrmap_from_index)
8752         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
8753         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
8754         (add_partial_subprogram, dwarf2_ranges_read): Update.
8755         * dwarf-index-write.c (write_address_map)
8756         (write_one_signatured_type, recursively_write_psymbols)
8757         (class debug_names, class debug_names, write_psymtabs_to_index):
8758         Update.
8759
8760 2019-01-10  Tom Tromey  <tom@tromey.com>
8761
8762         * symtab.h (SYMBOL_SET_NAMES): Update.
8763         (symbol_set_names): Update.
8764         (MSYMBOL_SET_NAMES): Update.
8765         * symtab.c (symbol_set_names): Change argument to be an
8766         objfile_per_bfd_storage.
8767         * psymtab.c (add_psymbol_to_bcache): Update.
8768         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
8769
8770 2019-01-10  Tom Tromey  <tom@tromey.com>
8771
8772         * symtab.c (create_demangled_names_hash): Change argument to be an
8773         objfile_per_bfd_storage.
8774         (symbol_set_names): Update.
8775
8776 2019-01-10  Tom Tromey  <tom@tromey.com>
8777
8778         * xcoffread.c (xcoff_initial_scan): Unconditionally call
8779         init_psymbol_list.
8780         * psymtab.c (init_psymbol_list): Do nothing if already called.
8781         * psympriv.h (init_psymbol_list): Add comment.
8782         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
8783         init_psymbol_list.
8784         * dbxread.c (dbx_symfile_read): Unconditionally call
8785         init_psymbol_list.
8786
8787 2019-01-10  Tom Tromey  <tom@tromey.com>
8788
8789         * xcoffread.c (scan_xcoff_symtab): Update.
8790         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
8791         "where".
8792         * mdebugread.c (parse_partial_symbols)
8793         (handle_psymbol_enumerators): Update.
8794         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
8795         * dbxread.c (read_dbx_symtab): Update.
8796         * psympriv.h (psymbol_placement): New enum.
8797         (add_psymbol_to_list): Update.
8798
8799 2019-01-10  Tom Tromey  <tom@tromey.com>
8800
8801         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
8802         static_psymbols parameters.
8803         (scan_xcoff_symtab): Update.
8804         * psymtab.c (start_psymtab_common): Remove global_psymbols and
8805         static_psymbols parameters.
8806         * psympriv.h (start_psymtab_common): Update.
8807         * mdebugread.c (parse_partial_symbols): Update.
8808         * dwarf2read.c (create_partial_symtab): Update.
8809         * dbxread.c (read_dbx_symtab): Update.
8810         (start_psymtab): Remove global_psymbols and static_psymbols
8811         parameters.
8812
8813 2019-01-10  Tom Tromey  <tom@tromey.com>
8814
8815         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
8816         * psymtab.c (allocate_psymtab): Add comment.
8817         * psympriv.h (allocate_psymtab): Add comment.
8818         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
8819         initializations.
8820         * dbxread.c (dbx_end_psymtab): Remove some initializations.
8821
8822 2019-01-10  Tom Tromey  <tom@tromey.com>
8823
8824         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8825         Don't declare.
8826         * mipsread.c: Include mdebugread.h.
8827         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8828         Declare.
8829         * elfread.c: Include mdebugread.h.
8830
8831 2019-01-09  Tom Tromey  <tom@tromey.com>
8832
8833         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
8834         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
8835         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
8836         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
8837         (psym_lookup_symbol, psym_find_last_source_symtab)
8838         (psym_forget_cached_source_info, psym_print_stats)
8839         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
8840         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
8841         (psym_map_matching_symbols, psym_expand_symtabs_matching)
8842         (psym_find_compunit_symtab_by_address)
8843         (maintenance_print_psymbols, maintenance_info_psymtabs)
8844         (maintenance_check_psymtabs): Use ranged for.
8845         * psymtab.h (class objfile_psymtabs): New.
8846         (require_partial_symbols): Return objfile_psymtabs.
8847         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
8848
8849 2019-01-09  Tom Tromey  <tom@tromey.com>
8850
8851         * symfile.c (overlay_invalidate_all, find_pc_overlay)
8852         (find_pc_mapped_section, list_overlays_command)
8853         (map_overlay_command, unmap_overlay_command)
8854         (simple_overlay_update): Use all_objfiles.
8855         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
8856         * printcmd.c (info_symbol_command): Use all_objfiles.
8857         * objfiles.h (ALL_OBJSECTIONS): Remove.
8858         * maint.c (maintenance_translate_address): Use all_objfiles.
8859         * gcore.c (gcore_create_callback): Use all_objfiles.
8860         (objfile_find_memory_regions): Likewise.
8861
8862 2019-01-09  Tom Tromey  <tom@tromey.com>
8863
8864         * symtab.c (find_line_symtab, info_sources_command)
8865         (make_source_files_completion_list): Use objfile_compunits.
8866         * source.c (select_source_symtab): Use objfile_compunits.
8867         * objfiles.h (struct objfile): Update comment.
8868         (ALL_OBJFILES): Remove.
8869         (ALL_FILETABS): Remove.
8870         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
8871         objfile_compunits.
8872
8873 2019-01-09  Tom Tromey  <tom@tromey.com>
8874
8875         * symmisc.c (print_objfile_statistics, dump_objfile)
8876         (maintenance_print_symbols): Use compunit_filetabs.
8877         * source.c (forget_cached_source_info_for_objfile): Use
8878         compunit_filetabs.
8879         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
8880         (ALL_FILETABS): Use compunit_filetabs.
8881         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
8882         * coffread.c (coff_symtab_read): Use compunit_filetabs.
8883
8884 2019-01-09  Tom Tromey  <tom@tromey.com>
8885
8886         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
8887         (compunit_filetabs): New.
8888         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
8889         compunit_filetabs.
8890         (info_sources_command, make_source_files_completion_list): Remove
8891         declaration.
8892         * symmisc.c (print_objfile_statistics, dump_objfile)
8893         (maintenance_print_symbols): Remove declaration.
8894         (maintenance_info_symtabs): Use compunit_filetabs.
8895         (maintenance_info_line_tables): Likewise.
8896         * source.c (select_source_symtab): Change local variable name.
8897         (forget_cached_source_info_for_objfile): Remove declaration.
8898         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
8899         * objfiles.c (objfile_relocate1): Remove declaration.
8900         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8901         declaration.
8902         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
8903         * coffread.c (coff_symtab_read): Remove declaration.
8904         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
8905         compunit_filetabs.
8906
8907 2019-01-09  Tom Tromey  <tom@tromey.com>
8908
8909         * symtab.c (lookup_objfile_from_block)
8910         (find_pc_sect_compunit_symtab, search_symbols)
8911         (default_collect_symbol_completion_matches_break_on): Use
8912         objfile_compunits.
8913         * objfiles.h (ALL_COMPUNITS): Remove.
8914         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
8915         * cp-support.c (add_symbol_overload_list_qualified): Use
8916         objfile_compunits.
8917         * ada-lang.c (ada_collect_symbol_completion_matches)
8918         (ada_add_global_exceptions): Use objfile_compunits.
8919
8920 2019-01-09  Tom Tromey  <tom@tromey.com>
8921
8922         * source.c (select_source_symtab)
8923         (forget_cached_source_info_for_objfile): Remove declaration.
8924         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8925         declaration.
8926         * maint.c (count_symtabs_and_blocks): Remove declaration.
8927         * cp-support.c (add_symbol_overload_list_qualified): Remove
8928         declaration.
8929         * coffread.c (coff_symtab_read): Remove declaration.
8930         * symtab.c (lookup_symbol_in_objfile_symtabs)
8931         (basic_lookup_transparent_type_1): Use objfile_compunits.
8932         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
8933         (info_sources_command, search_symbols)
8934         (default_collect_symbol_completion_matches_break_on)
8935         (make_source_files_completion_list): Remove declaration.
8936         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
8937         (ada_collect_symbol_completion_matches)
8938         (ada_add_global_exceptions): Remove declaration.
8939         * linespec.c (iterate_over_all_matching_symtabs): Use
8940         objfile_compunits.
8941         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
8942         (class objfile_compunits): New.
8943         (ALL_COMPUNITS): Use objfile_compunits.
8944         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
8945         (maintenance_check_symtabs, maintenance_info_line_tables): Use
8946         objfile_compunits.
8947         * objfiles.c (objfile_relocate1): Use objfile_compunits.
8948
8949 2019-01-09  Tom Tromey  <tom@tromey.com>
8950
8951         * symtab.c (search_symbols)
8952         (default_collect_symbol_completion_matches_break_on): Use
8953         objfile_msymbols.
8954         * ada-lang.c (ada_lookup_simple_minsym)
8955         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
8956         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
8957         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
8958         objfile_msymbols.
8959         * coffread.c (coff_symfile_read): Use objfile_msymbols.
8960         * symmisc.c (dump_msymbols): Use objfile_msymbols.
8961         * objc-lang.c (find_methods): Use objfile_msymbols.
8962         (info_selectors_command, info_classes_command): Likewise.
8963         * stabsread.c (scan_file_globals): Use objfile_msymbols.
8964         * objfiles.h (class objfile_msymbols): New.
8965         (ALL_OBJFILE_MSYMBOLS): Remove.
8966         (ALL_MSYMBOLS): Remove.
8967
8968 2019-01-09  Tom Tromey  <tom@tromey.com>
8969
8970         * common/next-iterator.h (next_adapter): Add Iterator template
8971         parameter.
8972         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
8973         (class all_objfiles_safe): New.
8974         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
8975         * objfiles.c (put_objfile_before): Update comment.
8976         (add_separate_debug_objfile): Likewise.
8977         (free_all_objfiles): Use all_objfiles_safe.
8978         (objfile_purge_solibs): Likewise.
8979
8980 2019-01-09  Tom Tromey  <tom@tromey.com>
8981
8982         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8983         (expand_symtab_containing_pc, lookup_static_symbol)
8984         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
8985         (find_symbol_at_address, find_line_symtab, find_main_name): Use
8986         all_objfiles.
8987         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
8988         * breakpoint.c (create_overlay_event_breakpoint)
8989         (create_longjmp_master_breakpoint)
8990         (create_std_terminate_master_breakpoint)
8991         (create_exception_master_breakpoint): Use all_objfiles.
8992         * linux-thread-db.c (try_thread_db_load_from_pdir)
8993         (has_libpthread): Use all_objfiles.
8994         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
8995         * linespec.c (iterate_over_all_matching_symtabs)
8996         (search_minsyms_for_name): Use all_objfiles.
8997         * maint.c (maintenance_info_sections): Use all_objfiles.
8998         * main.c (captured_main_1): Use all_objfiles.
8999         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9000         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9001         * guile/scm-pretty-print.c
9002         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9003         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9004         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9005         (maintenance_print_msymbols): Use all_objfiles.
9006         * source.c (select_source_symtab): Use all_objfiles.
9007         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9008         * symfile.c (remove_symbol_file_command)
9009         (expand_symtabs_matching, map_symbol_filenames): Use
9010         all_objfiles.
9011         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9012         all_objfiles.
9013         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9014         * objc-lang.c (find_methods): Use all_objfiles.
9015         * objfiles.c (have_partial_symbols, have_full_symbols)
9016         (have_minimal_symbols, qsort_cmp)
9017         (default_iterate_over_objfiles_in_search_order): Use
9018         all_objfiles.
9019         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9020         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9021         (maintenance_check_psymtabs): Use all_objfiles.
9022         (ALL_PSYMTABS): Remove.
9023         * compile/compile-object-run.c (do_module_cleanup): Use
9024         all_objfiles.
9025         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9026         * cp-support.c (add_symbol_overload_list_qualified): Use
9027         all_objfiles.
9028         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9029         Use all_objfiles.
9030         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9031         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9032         all_objfiles.
9033         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9034         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9035         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9036         Uses all_objfiles.
9037         * solib.c (solib_read_symbols): Use all_objfiles
9038
9039 2019-01-09  Tom Tromey  <tom@tromey.com>
9040
9041         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9042         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9043         all_objfiles.
9044         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9045         * symmisc.c (print_symbol_bcache_statistics)
9046         (print_objfile_statistics, maintenance_print_objfiles)
9047         (maintenance_info_symtabs, maintenance_check_symtabs)
9048         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9049         all_objfiles.
9050         * source.c (forget_cached_source_info): Use all_objfiles.
9051         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9052         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9053         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9054         * objfiles.c (update_section_map): Use all_objfiles.
9055         (shared_objfile_contains_address_p): Likewise.
9056         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9057         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9058
9059 2019-01-09  Tom Tromey  <tom@tromey.com>
9060
9061         * common/next-iterator.h: New file.
9062         * objfiles.h (class all_objfiles): New.
9063         (struct objfile_iterator): New.
9064
9065 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9066
9067         * NEWS: Move the description of the changed "frame", "select-frame",
9068          and "info frame" commands to the Changed commands section.
9069
9070 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9071
9072         * gdbtypes.c (check_stub_method_group): Remove handling of old
9073         mangling schemes.
9074         * linespec.c (find_methods): Likewise.
9075         * stabsread.c (read_member_functions): Likewise.
9076         * valops.c (search_struct_method): Likewise.
9077         (value_struct_elt_for_reference): Likewise.
9078         * NEWS: Mention this change.
9079
9080 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9081
9082         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9083         print_source_lines.
9084         * source.c (print_source_lines_base): Update line number check.
9085         (print_source_lines): New function.
9086         (source_lines_range::source_lines_range): New function.
9087         * source.h (class source_lines_range): New class.
9088         (print_source_lines): New declaration.
9089
9090 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9091
9092         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9093
9094 2019-01-08  Tom Tromey  <tom@tromey.com>
9095             Simon Marchi  <simon.marchi@ericsson.com>
9096
9097         PR gdb/24060
9098         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9099         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9100         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9101         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9102         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9103         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9104
9105 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9106
9107         * source.c (select_source_symtab): Move header comment to
9108         declaration in source.h.
9109         (forget_cached_source_info_for_objfile): Likewise.
9110         (forget_cached_source_info): Likewise.
9111         (identify_source_line): Likewise.
9112         * source.h (identify_source_line): Move declaration from symtab.h
9113         and add comment from source.c
9114         (print_source_lines): Likewise.
9115         (forget_cached_source_info_for_objfile): Likewise.
9116         (forget_cached_source_info): Likewise.
9117         (select_source_symtab): Likewise.
9118         (enum print_source_lines_flag): Move definition from symtab.h.
9119         * symtab.h (identify_source_line): Move declaration to source.h.
9120         (print_source_lines): Likewise.
9121         (forget_cached_source_info_for_objfile): Likewise.
9122         (forget_cached_source_info): Likewise.
9123         (select_source_symtab): Likewise.
9124         (enum print_source_lines_flag): Move definition to source.h.
9125         * tui/tui-hooks.c: Add 'source.h' include.
9126
9127 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9128
9129         * source.c (print_source_lines_base): Handle requests to print
9130         reverse line number sequences, and guard against empty lines
9131         string.
9132
9133 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9134
9135         * source.c (print_source_lines_base): Fix skip of '\r' if next
9136         character is '\n'.
9137
9138 2019-01-06  Tom Tromey  <tom@tromey.com>
9139
9140         * c-exp.y (struct c_parse_state) <macro_original_text,
9141         expansion_obstack>: New member.
9142         (macro_original_text, expansion_obstack): Remove globals.
9143         (scan_macro_expansion, scanning_macro_expansion)
9144         (finished_macro_expansion): Update.
9145         (scan_macro_cleanup): Remove.
9146         (yylex, c_parse): Update.
9147
9148 2019-01-06  Tom Tromey  <tom@tromey.com>
9149
9150         * c-exp.y (struct c_parse_state) <strings>: New member.
9151         (operator_stoken): Update.
9152
9153 2019-01-06  Tom Tromey  <tom@tromey.com>
9154
9155         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9156         (union type_stack_elt) <typelist_val>: Now a pointer to
9157         std::vector.
9158         (type_stack_cleanup): Don't declare.
9159         (push_typelist): Update.
9160         * parse.c (pop_typelist): Return a std::vector.
9161         (push_typelist): Take a std::vector.
9162         (follow_types): Update.  Do not free args.
9163         (type_stack_cleanup): Remove.
9164         * c-exp.y (struct c_parse_state): New.
9165         (cpstate): New global.
9166         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
9167         (nonempty_typelist): Update.
9168         (func_mod): Create a new vector.
9169         (c_parse): Create a c_parse_state.
9170         (check_parameter_typelist): Do not delete params.
9171         (function_method): Update.  Do not delete type_list.
9172
9173 2019-01-06  Tom Tromey  <tom@tromey.com>
9174
9175         PR gdb/28155:
9176         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
9177         check_typedef.
9178         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
9179         (print_return_value): Likewise.
9180
9181 2019-01-05  Tom Tromey  <tom@tromey.com>
9182
9183         * contrib/cleanup_check.py: Remove.
9184         * contrib/gcc-with-excheck: Remove.
9185         * contrib/exsummary.py: Remove.
9186         * contrib/excheck.py: Remove.
9187
9188 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
9189
9190         * thread.c (delete_thread_1): Add gdb_assert that THR is not
9191         NULL. Initialize tpprev to NULL instead of assigning it
9192         to NULL on the next statement.
9193         * windows-nat.c (windows_delete_thread): Remove check for
9194         main_thread_id before printing thread exit notifications.
9195         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
9196         Remove thread ID check against main_thread_id.
9197         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
9198         windows_delete_thread.
9199         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
9200
9201 2019-01-04  Tom Tromey  <tom@tromey.com>
9202
9203         * compile/compile.c (_initialize_compile): Use upper case for
9204         metasyntactic variables.
9205         * symmisc.c (_initialize_symmisc): Use upper case for
9206         metasyntactic variables.
9207         * psymtab.c (_initialize_psymtab): Use upper case for
9208         metasyntactic variables.
9209         * demangle.c (demangle_command): Use upper case for metasyntactic
9210         variables.
9211         (_initialize_demangler): Likewise.
9212         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
9213         variables.
9214
9215 2019-01-03  Tom Tromey  <tom@tromey.com>
9216
9217         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
9218
9219 2019-01-03  Tom Tromey  <tom@tromey.com>
9220
9221         * python/py-symtab.c (salpy_str): Update.
9222         (struct salpy_sal_object) <symtab>: Now a PyObject.
9223         (salpy_dealloc): Update.
9224         (del_objfile_sal): Use gdbpy_ref.
9225
9226 2019-01-03  Tom Tromey  <tom@tromey.com>
9227
9228         * python/py-type.c (convert_field): Use new_reference.  Return
9229         gdbpy_ref.
9230         (make_fielditem): Return gdbpy_ref.
9231         (typy_fields): Update.
9232         (typy_getitem): Update.
9233         (field_name): Return gdbpy_ref.  Use new_reference.
9234         (typy_iterator_iternext): Update.
9235
9236 2019-01-03  Tom Tromey  <tom@tromey.com>
9237
9238         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
9239
9240 2019-01-03  Tom Tromey  <tom@tromey.com>
9241
9242         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
9243         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
9244         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
9245         (pspy_set_frame_filters, pspy_set_frame_unwinders)
9246         (pspy_set_type_printers): Likewise.
9247         * python/py-function.c (fnpy_init): Use gdbpy_ref.
9248         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
9249         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
9250         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
9251         (objfpy_set_type_printers): Likewise.
9252
9253 2019-01-03  Tom Tromey  <tom@tromey.com>
9254
9255         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
9256         (gdbpy_print_stack): Use gdbpy_err_fetch.
9257         * python/python-internal.h (class gdbpy_err_fetch): New class.
9258         (class gdbpy_enter) <m_error_type, m_error_value,
9259         m_error_traceback>: Remove.
9260         <m_error>: New member.
9261         (gdbpy_exception_to_string): Don't declare.
9262         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
9263         * python/py-value.c (convert_value_from_python): Use
9264         gdbpy_err_fetch.
9265         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
9266         gdbpy_exception_to_string.
9267         (gdbpy_handle_exception): Use gdbpy_err_fetch.
9268         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
9269         gdbpy_err_fetch.
9270
9271 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9272
9273         * linux-nat.c (delete_lwp_cleanup): Delete.
9274         (struct lwp_deleter): New struct.
9275         (lwp_info_up): New typedef.
9276         (linux_nat_target::follow_fork): Delete cleanup, and make use of
9277         lwp_info_up.
9278
9279 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9280
9281         * linux-fork.c (class scoped_switch_fork_info): New class.
9282         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
9283
9284 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9285
9286         * valops.c (find_overload_match): Remove use of null_cleanup, and
9287         calls to do_cleanups.
9288
9289 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9290
9291         * compile/compile-cplus-types.c
9292         (compile_cplus_instance::decl_name): Handle changes to
9293         cp_func_name.
9294         * cp-support.c (cp_func_name): Update header comment, update
9295         return type.
9296         * cp-support.h (cp_func_name): Update return type in declaration.
9297         * valops.c (find_overload_match): Move temp_func local to top
9298         level of function and change its type.  Use temp_func to hold and
9299         delete temporary string obtained from cp_func_name.
9300
9301 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9302
9303         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
9304         gdb::char_vector, remove cleanup, and update uses of `msg`.
9305
9306 2019-01-03  Jim Wilson  <jimw@sifive.com>
9307
9308         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
9309
9310 2019-01-02  Tom Tromey  <tom@tromey.com>
9311
9312         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
9313         (tdesc_parse_xml): Remove cleanups.
9314         * target-descriptions.h (make_cleanup_free_target_description):
9315         Don't declare.
9316         (target_desc_deleter): New struct.
9317         (target_desc_up): New typedef.
9318         * target-descriptions.c (target_desc_deleter::operator()): Rename
9319         from free_target_description.
9320         (make_cleanup_free_target_description): Remove.
9321
9322 2019-01-02  Tom Tromey  <tom@tromey.com>
9323
9324         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
9325         constructor, destructor.
9326         (linespec_parser): Remove typedef.
9327         (~linespec_parser): Rename from linespec_parser_delete.
9328         (linespec_lex_to_end, linespec_complete_label)
9329         (linespec_complete): Update.
9330         (decode_line_full): Remove cleanups.
9331         (decode_line_1): Update.
9332
9333 2019-01-02  Tom Tromey  <tom@tromey.com>
9334
9335         * python/python-internal.h (inferior_to_inferior_object): Change
9336         return type.
9337         * python/py-exitedevent.c (create_exited_event_object): Update.
9338         * python/py-inferior.c (inferior_to_inferior_object): Return
9339         gdbpy_ref.
9340         (python_new_inferior, python_inferior_deleted)
9341         (thread_to_thread_object, delete_thread_object)
9342         (build_inferior_list, gdbpy_selected_inferior): Update.
9343         * python/py-infthread.c (create_thread_object): Update.  Also fail
9344         if inferior_to_inferior_object fails.
9345
9346 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
9347
9348         * inferior.h (class inferior) <displaced_step_state>: New field.
9349         * infrun.h (struct displaced_step_state): Move here from
9350         infrun.c.  Initialize fields, add constructor.
9351         <inf>: Remove field.
9352         <reset>: New method.
9353         * infrun.c (struct displaced_step_inferior_state): Move to
9354         infrun.h.
9355         (displaced_step_inferior_states): Remove.
9356         (get_displaced_stepping_state): Adust.
9357         (displaced_step_in_progress_any_inferior): Adjust.
9358         (displaced_step_in_progress_thread): Adjust.
9359         (displaced_step_in_progress): Adjust.
9360         (add_displaced_stepping_state): Remove.
9361         (get_displaced_step_closure_by_addr): Adjust.
9362         (remove_displaced_stepping_state): Remove.
9363         (infrun_inferior_exit): Call displaced_step_state.reset.
9364         (use_displaced_stepping): Don't check for NULL.
9365         (displaced_step_prepare_throw): Call
9366         get_displaced_stepping_state.
9367         (displaced_step_fixup): Don't check for NULL.
9368         (prepare_for_detach): Don't check for NULL.
9369
9370 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9371
9372         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
9373          in case of call that did not complete.
9374
9375 2019-01-02  Andrey Utkin  <autkin@undo.io>
9376
9377         * symfile.c (find_separate_debug_file): Fix search of debug files for
9378         remote debuggee.
9379
9380 2019-01-02  Tom Tromey  <tom@tromey.com>
9381
9382         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
9383         indentation.
9384         * python/py-frame.c (frapy_older): Remove cast.
9385         (frapy_newer): Likewise.
9386         * python/py-breakpoint.c (local_setattro): Remove cast.
9387         * python/py-arch.c (archpy_name): Remove local variable.
9388         * python/py-type.c (gdbpy_lookup_type): Remove cast.
9389
9390 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
9391
9392         * unittests/basic_string_view/element_access/char/empty.cc:
9393         Fix year range in copyright header.
9394
9395 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9396
9397         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
9398         Delete.
9399         <operator==>: Update with for removed field.
9400         <hash>: Likewise.
9401         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
9402         <isa_features>: ...this.
9403         <abi_features>: New field.
9404         (riscv_isa_flen): Update comment.
9405         (riscv_abi_xlen): New declaration.
9406         (riscv_abi_flen): New declaration.
9407         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
9408         isa_features.
9409         (riscv_abi_xlen): New function.
9410         (riscv_isa_flen): Update to get answer from isa_features.
9411         (riscv_abi_flen): New function.
9412         (riscv_has_fp_abi): Update to get answer from abi_features.
9413         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
9414         xlen and flen.
9415         (riscv_call_info) <xlen, flen>: Update comment.
9416         (riscv_call_arg_struct): Remove invalid assertions
9417         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
9418         is removed.
9419         (riscv_gdbarch_init): Gather isa features and abi features
9420         separately, ensure both match on the gdbarch when reusing an old
9421         gdbarch.  Relax an error check to allow 32-bit abi float to run on
9422         a target with 64-bit float hardware.
9423
9424 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9425
9426         * source.c (search_command_helper): Stop reverse search
9427         when line 1 has been searched.
9428
9429 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9430
9431         * record-full.c (record_full_base_target::close): Rewrite
9432         record_full_core_buf_list free logic.
9433
9434 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9435
9436         * break-catch-syscall.c (print_one_catch_syscall): xfree
9437         the last text.
9438
9439 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9440
9441         * top.c (print_gdb_version): Update Copyright year in version
9442         message.
9443
9444 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9445
9446         Update copyright year range in all GDB files.
9447
9448 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
9449
9450         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
9451
9452 For older changes see ChangeLog-2018.
9453 \f
9454 Local Variables:
9455 mode: change-log
9456 left-margin: 8
9457 fill-column: 74
9458 version-control: never
9459 coding: utf-8
9460 End:
9461