gdb/riscv: Handle empty C++ structs during argument passing
[external/binutils.git] / gdb / ChangeLog
1 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2
3         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4         component to 0.
5         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6         member.
7         (riscv_struct_info::analyse): New implementation using new
8         analyse_inner member function.
9         (riscv_struct_info::field_offset): New member function.
10         (riscv_struct_info::m_offsets): New member variable.
11         (riscv_struct_info::analyse_inner): New private member function,
12         takes the old implementation of riscv_struct_info::analyse but
13         extended to track field offsets.
14         (riscv_call_arg_struct): Update the struct folding special cases
15         to handle cases where empty C++ structs, which are non-zero
16         length, are found.
17         (riscv_arg_location): Initialise the length of each location, a
18         non-zero length now indicates the location is in use.
19         (riscv_push_dummy_call): Allow for the first location having a
20         non-zero offset when setting up arguments.
21         (riscv_return_value): Likewise, but for return values.
22
23 2019-04-11  Tom Tromey  <tromey@adacore.com>
24
25         * utils.c (internal_vproblem): Make "msg" const.
26
27 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
28
29         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
30         * trad-frame.c (trad_frame_reset_saved_regs): New function.
31         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
32         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
33
34 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
35
36         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
37         function.
38         (fill_gregset): Call amd64_linux_collect_native_gregset instead
39         of amd64_collect_native_gregset.
40         (amd64_linux_nat_target::store_registers): Likewise.
41
42 2019-04-10  Tom Tromey  <tom@tromey.com>
43
44         * symtab.c (lookup_global_symbol_from_objfile)
45         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
46         * objfiles.h (class separate_debug_iterator): New.
47         (class separate_debug_range): New.
48         (struct objfile) <separate_debug_objfiles>: New method.
49         (objfile_separate_debug_iterate): Don't declare.
50         * objfiles.c (separate_debug_iterator::operator++): Rename from
51         objfile_separate_debug_iterate.
52         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
53         iterator.
54         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
55         iterator.
56
57 2019-04-10  Tom Tromey  <tom@tromey.com>
58
59         * symfile.c (reread_symbols): Remove old comment.
60         * objfiles.c (free_all_objfiles): Fix a typo.
61
62 2019-04-10  Tom Tromey  <tom@tromey.com>
63
64         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
65         * minsyms.c (lookup_minimal_symbol): Use foreach.
66         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
67         (lookup_minimal_symbol_solib_trampoline): Likewise.
68         * symfile.c (reread_symbols): Use foreach.
69
70 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
71             Tom Tromey  <tromey@adacore.com>
72
73         PR rust/24414:
74         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
75         (rust_lex_int_test): Change "value" to be LONGEST.
76         (rust_lex_tests): Add test for long integer literal.
77
78 2019-04-09  Tom Tromey  <tromey@adacore.com>
79
80         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
81         to bool.
82         (extended_remote_target::attach): Update.
83         (remote_target::remote_notice_new_inferior): Update.
84         (remote_target::add_current_inferior_and_thread): Update.
85         * inferior.c (exit_inferior_1): Use "false".
86         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
87
88 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
89
90         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
91         the "start" command.
92
93 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
94
95         * python/py-inferior.c (infpy_thread_from_thread_handle):
96         Adjust comments to reflect renaming of thread_from_thread_handle
97         to thread_from_handle.  Adjust keywords.  Fix type error message.
98         (inferior_object_methods): Add thread_from_handle.  Retain
99         thread_from_thread_handle, but mark it as deprecated.
100
101 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
102
103         * gdbthread.h (find_thread_by_handle): Revise declaration.
104         * thread.c (find_thread_by_handle): Likewise.  Adjust
105         implementation too.
106         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
107         support for buffer objects as handles.
108
109 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
110
111         * python/py-infthread.c (thpy_thread_handle): New function.
112         (thread_object_methods): Register thpy_thread_handle.
113
114 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
115
116         * gdbthread.h (thread_to_thread_handle): Declare.
117         * thread.c (gdbtypes.h): Include.
118         (thread_to_thread_handle): New function.
119
120         * target.h (struct target_ops): Add thread_info_to_thread_handle.
121         (target_thread_info_to_thread_handle): Declare.
122         * target.c (target_thread_info_to_thread_handle): New function.
123         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
124         * target-delegates.c: Regenerate.
125
126         * linux-thread-db.c (class thread_db_target): Add method
127         thread_info_to_thread_handle.
128         (thread_db_target::thread_info_to_thread_handle): Define.
129         * remote.c (class remote_target): Add new method
130         thread_info_to_thread_handle.
131         (remote_target::thread_info_to_thread_handle): Define.
132
133 2019-04-08  Pedro Alves  <palves@redhat.com>
134
135         * common/common-exceptions.c (throw_exception): Don't create
136         named object to throw; throw directly.
137         (throw_it): Likewise.  Don't initialize gdb_exception::message
138         here, with new; pass FMT and AP to the ctor instead.
139         * common/common-exceptions.h: Include <string>.
140         (gdb_exception::gdb_exception(enum return_reason, enum errors,
141         const char *, va_list)): New ctor.  Use std::make_shared.
142         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
143         errors)): Delete.
144         (gdb_exception_error::gdb_exception_error(enum errors, const char
145         *, va_list)): New.
146         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
147         Add assertion.
148         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
149         errors)): Delete.
150         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
151         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
152         Add assertion.
153
154 2019-04-08  Tom Tromey  <tom@tromey.com>
155
156         * valops.c (value_rtti_indirect_type): Replace throw_exception
157         with throw.
158         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
159         with throw.
160         * thread.c (thr_try_catch_cmd): Replace throw_exception with
161         throw.
162         * target.c (target_translate_tls_address): Replace throw_exception
163         with throw.
164         * stack.c (frame_apply_command_count): Replace throw_exception
165         with throw.
166         * solib-spu.c (append_ocl_sos): Replace throw_exception with
167         throw.
168         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
169         with throw.
170         * rs6000-tdep.c (rs6000_frame_cache)
171         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
172         * remote.c: Replace throw_exception with throw.
173         * record-full.c (record_full_message, record_full_wait_1)
174         (record_full_restore): Replace throw_exception with throw.
175         * record-btrace.c:
176         (get_thread_current_frame_id, record_btrace_start_replaying)
177         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
178         (cmd_record_btrace_start): Replace throw_exception with throw.
179         * parse.c (parse_exp_in_context_1): Replace throw_exception with
180         throw.
181         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
182         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
183         * linespec.c:
184         (find_linespec_symbols): Replace throw_exception with throw.
185         * infrun.c (displaced_step_prepare, resume): Replace
186         throw_exception with throw.
187         * infcmd.c (post_create_inferior): Replace throw_exception with
188         throw.
189         * inf-loop.c (inferior_event_handler): Replace throw_exception
190         with throw.
191         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
192         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
193         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
194         (get_prev_frame_always, get_frame_pc_if_available)
195         (get_frame_address_in_block_if_available, get_frame_language):
196         Replace throw_exception with throw.
197         * frame-unwind.c (frame_unwind_try_unwinder): Replace
198         throw_exception with throw.
199         * eval.c (fetch_subexp_value, evaluate_var_value)
200         (evaluate_funcall, evaluate_subexp_standard): Replace
201         throw_exception with throw.
202         * dwarf2loc.c (call_site_find_chain)
203         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
204         Replace throw_exception with throw.
205         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
206         with throw.
207         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
208         throw.
209         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
210         * completer.c (complete_line_internal): Replace throw_exception
211         with throw.
212         * compile/compile-object-run.c (compile_object_run): Replace
213         throw_exception with throw.
214         * cli/cli-script.c (process_next_line): Replace throw_exception
215         with throw.
216         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
217         (btrace_enable, btrace_maint_update_pt_packets): Replace
218         throw_exception with throw.
219         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
220         throw_exception with throw.
221         * break-catch-throw.c (re_set_exception_catchpoint): Replace
222         throw_exception with throw.
223         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
224         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
225         * aarch64-tdep.c (aarch64_make_prologue_cache)
226         (aarch64_make_stub_cache): Replace throw_exception with throw.
227
228 2019-04-08  Tom Tromey  <tom@tromey.com>
229
230         * common/common-exceptions.c (throw_exception): Rename from
231         throw_exception_cxx.  Remove old copy.  Make argument const.
232         (throw_it): Create and throw exception objects directly.
233         * common/common-exceptions.h (throw_exception): Make argument
234         const.
235         (struct gdb_exception_error): Add constructor.
236         (struct gdb_exception_quit): Add constructor.
237
238 2019-04-08  Tom Tromey  <tom@tromey.com>
239
240         * common/common-exceptions.h (exception_rethrow): Don't declare.
241         (TRY_SJLJ): Update comment.
242         (TRY, CATCH, END_CATCH): Remove.
243         * common/common-exceptions.c (exception_rethrow): Remove.
244
245 2019-04-08  Tom Tromey  <tom@tromey.com>
246
247         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
248         Remove.
249         (gdb_exception_error): Rename from
250         gdb_exception_RETURN_MASK_ERROR.
251         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
252         (gdb_quit_bad_alloc): Update.
253         * aarch64-tdep.c: Update.
254         * ada-lang.c: Update.
255         * ada-typeprint.c: Update.
256         * ada-valprint.c: Update.
257         * amd64-tdep.c: Update.
258         * arch-utils.c: Update.
259         * break-catch-throw.c: Update.
260         * breakpoint.c: Update.
261         * btrace.c: Update.
262         * c-varobj.c: Update.
263         * cli/cli-cmds.c: Update.
264         * cli/cli-interp.c: Update.
265         * cli/cli-script.c: Update.
266         * common/common-exceptions.c: Update.
267         * common/new-op.c: Update.
268         * common/selftest.c: Update.
269         * compile/compile-c-symbols.c: Update.
270         * compile/compile-cplus-symbols.c: Update.
271         * compile/compile-object-load.c: Update.
272         * compile/compile-object-run.c: Update.
273         * completer.c: Update.
274         * corelow.c: Update.
275         * cp-abi.c: Update.
276         * cp-support.c: Update.
277         * cp-valprint.c: Update.
278         * darwin-nat.c: Update.
279         * disasm-selftests.c: Update.
280         * dtrace-probe.c: Update.
281         * dwarf-index-cache.c: Update.
282         * dwarf-index-write.c: Update.
283         * dwarf2-frame-tailcall.c: Update.
284         * dwarf2-frame.c: Update.
285         * dwarf2loc.c: Update.
286         * dwarf2read.c: Update.
287         * eval.c: Update.
288         * event-loop.c: Update.
289         * event-top.c: Update.
290         * exec.c: Update.
291         * f-valprint.c: Update.
292         * fbsd-tdep.c: Update.
293         * frame-unwind.c: Update.
294         * frame.c: Update.
295         * gdbtypes.c: Update.
296         * gnu-v3-abi.c: Update.
297         * guile/guile-internal.h: Update.
298         * guile/scm-block.c: Update.
299         * guile/scm-breakpoint.c: Update.
300         * guile/scm-cmd.c: Update.
301         * guile/scm-disasm.c: Update.
302         * guile/scm-frame.c: Update.
303         * guile/scm-lazy-string.c: Update.
304         * guile/scm-math.c: Update.
305         * guile/scm-param.c: Update.
306         * guile/scm-ports.c: Update.
307         * guile/scm-pretty-print.c: Update.
308         * guile/scm-symbol.c: Update.
309         * guile/scm-symtab.c: Update.
310         * guile/scm-type.c: Update.
311         * guile/scm-value.c: Update.
312         * i386-linux-tdep.c: Update.
313         * i386-tdep.c: Update.
314         * inf-loop.c: Update.
315         * infcall.c: Update.
316         * infcmd.c: Update.
317         * infrun.c: Update.
318         * jit.c: Update.
319         * language.c: Update.
320         * linespec.c: Update.
321         * linux-fork.c: Update.
322         * linux-nat.c: Update.
323         * linux-tdep.c: Update.
324         * linux-thread-db.c: Update.
325         * main.c: Update.
326         * mi/mi-cmd-break.c: Update.
327         * mi/mi-cmd-stack.c: Update.
328         * mi/mi-interp.c: Update.
329         * mi/mi-main.c: Update.
330         * objc-lang.c: Update.
331         * p-valprint.c: Update.
332         * parse.c: Update.
333         * ppc-linux-tdep.c: Update.
334         * printcmd.c: Update.
335         * python/py-arch.c: Update.
336         * python/py-breakpoint.c: Update.
337         * python/py-cmd.c: Update.
338         * python/py-finishbreakpoint.c: Update.
339         * python/py-frame.c: Update.
340         * python/py-framefilter.c: Update.
341         * python/py-gdb-readline.c: Update.
342         * python/py-inferior.c: Update.
343         * python/py-infthread.c: Update.
344         * python/py-lazy-string.c: Update.
345         * python/py-linetable.c: Update.
346         * python/py-objfile.c: Update.
347         * python/py-param.c: Update.
348         * python/py-prettyprint.c: Update.
349         * python/py-progspace.c: Update.
350         * python/py-record-btrace.c: Update.
351         * python/py-record.c: Update.
352         * python/py-symbol.c: Update.
353         * python/py-type.c: Update.
354         * python/py-unwind.c: Update.
355         * python/py-utils.c: Update.
356         * python/py-value.c: Update.
357         * python/python.c: Update.
358         * record-btrace.c: Update.
359         * record-full.c: Update.
360         * remote-fileio.c: Update.
361         * remote.c: Update.
362         * riscv-tdep.c: Update.
363         * rs6000-aix-tdep.c: Update.
364         * rs6000-tdep.c: Update.
365         * rust-exp.y: Update.
366         * rust-lang.c: Update.
367         * s390-tdep.c: Update.
368         * selftest-arch.c: Update.
369         * solib-dsbt.c: Update.
370         * solib-frv.c: Update.
371         * solib-spu.c: Update.
372         * solib-svr4.c: Update.
373         * solib.c: Update.
374         * sparc64-linux-tdep.c: Update.
375         * stack.c: Update.
376         * symfile-mem.c: Update.
377         * symmisc.c: Update.
378         * target.c: Update.
379         * thread.c: Update.
380         * top.c: Update.
381         * tracefile-tfile.c: Update.
382         * tui/tui.c: Update.
383         * typeprint.c: Update.
384         * unittests/cli-utils-selftests.c: Update.
385         * unittests/parse-connection-spec-selftests.c: Update.
386         * valops.c: Update.
387         * valprint.c: Update.
388         * value.c: Update.
389         * varobj.c: Update.
390         * windows-nat.c: Update.
391         * x86-linux-nat.c: Update.
392         * xml-support.c: Update.
393
394 2019-04-08  Tom Tromey  <tom@tromey.com>
395
396         * xml-support.c: Use C++ exception handling.
397         * x86-linux-nat.c: Use C++ exception handling.
398         * windows-nat.c: Use C++ exception handling.
399         * varobj.c: Use C++ exception handling.
400         * value.c: Use C++ exception handling.
401         * valprint.c: Use C++ exception handling.
402         * valops.c: Use C++ exception handling.
403         * unittests/parse-connection-spec-selftests.c: Use C++ exception
404         handling.
405         * unittests/cli-utils-selftests.c: Use C++ exception handling.
406         * typeprint.c: Use C++ exception handling.
407         * tui/tui.c: Use C++ exception handling.
408         * tracefile-tfile.c: Use C++ exception handling.
409         * top.c: Use C++ exception handling.
410         * thread.c: Use C++ exception handling.
411         * target.c: Use C++ exception handling.
412         * symmisc.c: Use C++ exception handling.
413         * symfile-mem.c: Use C++ exception handling.
414         * stack.c: Use C++ exception handling.
415         * sparc64-linux-tdep.c: Use C++ exception handling.
416         * solib.c: Use C++ exception handling.
417         * solib-svr4.c: Use C++ exception handling.
418         * solib-spu.c: Use C++ exception handling.
419         * solib-frv.c: Use C++ exception handling.
420         * solib-dsbt.c: Use C++ exception handling.
421         * selftest-arch.c: Use C++ exception handling.
422         * s390-tdep.c: Use C++ exception handling.
423         * rust-lang.c: Use C++ exception handling.
424         * rust-exp.y: Use C++ exception handling.
425         * rs6000-tdep.c: Use C++ exception handling.
426         * rs6000-aix-tdep.c: Use C++ exception handling.
427         * riscv-tdep.c: Use C++ exception handling.
428         * remote.c: Use C++ exception handling.
429         * remote-fileio.c: Use C++ exception handling.
430         * record-full.c: Use C++ exception handling.
431         * record-btrace.c: Use C++ exception handling.
432         * python/python.c: Use C++ exception handling.
433         * python/py-value.c: Use C++ exception handling.
434         * python/py-utils.c: Use C++ exception handling.
435         * python/py-unwind.c: Use C++ exception handling.
436         * python/py-type.c: Use C++ exception handling.
437         * python/py-symbol.c: Use C++ exception handling.
438         * python/py-record.c: Use C++ exception handling.
439         * python/py-record-btrace.c: Use C++ exception handling.
440         * python/py-progspace.c: Use C++ exception handling.
441         * python/py-prettyprint.c: Use C++ exception handling.
442         * python/py-param.c: Use C++ exception handling.
443         * python/py-objfile.c: Use C++ exception handling.
444         * python/py-linetable.c: Use C++ exception handling.
445         * python/py-lazy-string.c: Use C++ exception handling.
446         * python/py-infthread.c: Use C++ exception handling.
447         * python/py-inferior.c: Use C++ exception handling.
448         * python/py-gdb-readline.c: Use C++ exception handling.
449         * python/py-framefilter.c: Use C++ exception handling.
450         * python/py-frame.c: Use C++ exception handling.
451         * python/py-finishbreakpoint.c: Use C++ exception handling.
452         * python/py-cmd.c: Use C++ exception handling.
453         * python/py-breakpoint.c: Use C++ exception handling.
454         * python/py-arch.c: Use C++ exception handling.
455         * printcmd.c: Use C++ exception handling.
456         * ppc-linux-tdep.c: Use C++ exception handling.
457         * parse.c: Use C++ exception handling.
458         * p-valprint.c: Use C++ exception handling.
459         * objc-lang.c: Use C++ exception handling.
460         * mi/mi-main.c: Use C++ exception handling.
461         * mi/mi-interp.c: Use C++ exception handling.
462         * mi/mi-cmd-stack.c: Use C++ exception handling.
463         * mi/mi-cmd-break.c: Use C++ exception handling.
464         * main.c: Use C++ exception handling.
465         * linux-thread-db.c: Use C++ exception handling.
466         * linux-tdep.c: Use C++ exception handling.
467         * linux-nat.c: Use C++ exception handling.
468         * linux-fork.c: Use C++ exception handling.
469         * linespec.c: Use C++ exception handling.
470         * language.c: Use C++ exception handling.
471         * jit.c: Use C++ exception handling.
472         * infrun.c: Use C++ exception handling.
473         * infcmd.c: Use C++ exception handling.
474         * infcall.c: Use C++ exception handling.
475         * inf-loop.c: Use C++ exception handling.
476         * i386-tdep.c: Use C++ exception handling.
477         * i386-linux-tdep.c: Use C++ exception handling.
478         * guile/scm-value.c: Use C++ exception handling.
479         * guile/scm-type.c: Use C++ exception handling.
480         * guile/scm-symtab.c: Use C++ exception handling.
481         * guile/scm-symbol.c: Use C++ exception handling.
482         * guile/scm-pretty-print.c: Use C++ exception handling.
483         * guile/scm-ports.c: Use C++ exception handling.
484         * guile/scm-param.c: Use C++ exception handling.
485         * guile/scm-math.c: Use C++ exception handling.
486         * guile/scm-lazy-string.c: Use C++ exception handling.
487         * guile/scm-frame.c: Use C++ exception handling.
488         * guile/scm-disasm.c: Use C++ exception handling.
489         * guile/scm-cmd.c: Use C++ exception handling.
490         * guile/scm-breakpoint.c: Use C++ exception handling.
491         * guile/scm-block.c: Use C++ exception handling.
492         * guile/guile-internal.h: Use C++ exception handling.
493         * gnu-v3-abi.c: Use C++ exception handling.
494         * gdbtypes.c: Use C++ exception handling.
495         * frame.c: Use C++ exception handling.
496         * frame-unwind.c: Use C++ exception handling.
497         * fbsd-tdep.c: Use C++ exception handling.
498         * f-valprint.c: Use C++ exception handling.
499         * exec.c: Use C++ exception handling.
500         * event-top.c: Use C++ exception handling.
501         * event-loop.c: Use C++ exception handling.
502         * eval.c: Use C++ exception handling.
503         * dwarf2read.c: Use C++ exception handling.
504         * dwarf2loc.c: Use C++ exception handling.
505         * dwarf2-frame.c: Use C++ exception handling.
506         * dwarf2-frame-tailcall.c: Use C++ exception handling.
507         * dwarf-index-write.c: Use C++ exception handling.
508         * dwarf-index-cache.c: Use C++ exception handling.
509         * dtrace-probe.c: Use C++ exception handling.
510         * disasm-selftests.c: Use C++ exception handling.
511         * darwin-nat.c: Use C++ exception handling.
512         * cp-valprint.c: Use C++ exception handling.
513         * cp-support.c: Use C++ exception handling.
514         * cp-abi.c: Use C++ exception handling.
515         * corelow.c: Use C++ exception handling.
516         * completer.c: Use C++ exception handling.
517         * compile/compile-object-run.c: Use C++ exception handling.
518         * compile/compile-object-load.c: Use C++ exception handling.
519         * compile/compile-cplus-symbols.c: Use C++ exception handling.
520         * compile/compile-c-symbols.c: Use C++ exception handling.
521         * common/selftest.c: Use C++ exception handling.
522         * common/new-op.c: Use C++ exception handling.
523         * cli/cli-script.c: Use C++ exception handling.
524         * cli/cli-interp.c: Use C++ exception handling.
525         * cli/cli-cmds.c: Use C++ exception handling.
526         * c-varobj.c: Use C++ exception handling.
527         * btrace.c: Use C++ exception handling.
528         * breakpoint.c: Use C++ exception handling.
529         * break-catch-throw.c: Use C++ exception handling.
530         * arch-utils.c: Use C++ exception handling.
531         * amd64-tdep.c: Use C++ exception handling.
532         * ada-valprint.c: Use C++ exception handling.
533         * ada-typeprint.c: Use C++ exception handling.
534         * ada-lang.c: Use C++ exception handling.
535         * aarch64-tdep.c: Use C++ exception handling.
536
537 2019-04-08  Tom Tromey  <tom@tromey.com>
538
539         * xml-support.c (gdb_xml_parser::parse): Update.
540         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
541         * value.c (show_convenience): Update.
542         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
543         (test_parse_flags_qcs): Update.
544         * thread.c (thr_try_catch_cmd): Update.
545         * target.c (target_translate_tls_address): Update.
546         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
547         (info_frame_command_core, frame_apply_command_count): Update.
548         * rust-exp.y (rust_lex_exception_test): Update.
549         * riscv-tdep.c (riscv_print_one_register_info): Update.
550         * remote.c (remote_target::enable_btrace): Update.
551         * record-btrace.c (record_btrace_enable_warn): Update.
552         * python/py-utils.c (gdbpy_convert_exception): Update.
553         * printcmd.c (do_one_display, print_variable_and_value): Update.
554         * mi/mi-main.c (mi_print_exception): Update.
555         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
556         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
557         * linux-nat.c (linux_nat_target::attach): Update.
558         * linux-fork.c (class scoped_switch_fork_info): Update.
559         * infrun.c (displaced_step_prepare): Update.
560         * infcall.c (call_function_by_hand_dummy): Update.
561         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
562         * gnu-v3-abi.c (print_one_vtable): Update.
563         * frame.c (get_prev_frame_always): Update.
564         * f-valprint.c (info_common_command_for_block): Update.
565         * exec.c (try_open_exec_file): Update.
566         * exceptions.c (print_exception, exception_print)
567         (exception_fprintf, exception_print_same): Update.
568         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
569         * dwarf-index-cache.c (index_cache::store)
570         (index_cache::lookup_gdb_index): Update.
571         * darwin-nat.c (maybe_cache_shell): Update.
572         * cp-valprint.c (cp_print_value_fields): Update.
573         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
574         (gcc_cplus_symbol_address): Update.
575         * compile/compile-c-symbols.c (gcc_convert_symbol)
576         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
577         * common/selftest.c: Update.
578         * common/common-exceptions.h (struct gdb_exception) <message>: Now
579         a std::string.
580         (exception_try_scope_entry, exception_try_scope_exit): Don't
581         declare.
582         (struct exception_try_scope): Remove.
583         (TRY): Don't use exception_try_scope.
584         (struct gdb_exception): Add constructor, operator=.
585         <what>: New method.
586         (struct gdb_exception_RETURN_MASK_ALL)
587         (struct gdb_exception_RETURN_MASK_ERROR)
588         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
589         (struct gdb_quit_bad_alloc): Update.
590         * common/common-exceptions.c (exception_none): Change
591         initializer.
592         (struct catcher) <state, exception>: Initialize inline.
593         <prev>: Remove member.
594         (current_catcher): Remove.
595         (catchers): New global.
596         (exceptions_state_mc_init): Simplify.
597         (catcher_pop): Remove.
598         (exceptions_state_mc, exceptions_state_mc_catch): Update.
599         (try_scope_depth, exception_try_scope_entry)
600         (exception_try_scope_exit): Remove.
601         (throw_exception_sjlj): Update.
602         (exception_messages, exception_messages_size): Remove.
603         (throw_it): Simplify.
604         (gdb_exception_sliced_copy): Remove.
605         (throw_exception_cxx): Update.
606         * cli/cli-script.c (script_from_file): Update.
607         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
608         Update.
609         * ada-valprint.c (ada_val_print): Update.
610         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
611         (create_excep_cond_exprs): Update.
612
613 2019-04-08  Tom Tromey  <tom@tromey.com>
614
615         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
616         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
617         (TRY, CATCH, END_CATCH): Remove some definitions.
618         * common/common-exceptions.c: Don't use GDB_XCPT.
619         (catcher_list_size): Remove.
620         (throw_exception, throw_it): Simplify.
621
622 2019-04-05  Tom Tromey  <tom@tromey.com>
623
624         Revert the header-sorting patch.
625         * ft32-tdep.c: Revert.
626         * frv-tdep.c: Revert.
627         * frv-linux-tdep.c: Revert.
628         * frame.c: Revert.
629         * frame-unwind.c: Revert.
630         * frame-base.c: Revert.
631         * fork-child.c: Revert.
632         * findvar.c: Revert.
633         * findcmd.c: Revert.
634         * filesystem.c: Revert.
635         * filename-seen-cache.h: Revert.
636         * filename-seen-cache.c: Revert.
637         * fbsd-tdep.c: Revert.
638         * fbsd-nat.h: Revert.
639         * fbsd-nat.c: Revert.
640         * f-valprint.c: Revert.
641         * f-typeprint.c: Revert.
642         * f-lang.c: Revert.
643         * extension.h: Revert.
644         * extension.c: Revert.
645         * extension-priv.h: Revert.
646         * expprint.c: Revert.
647         * exec.h: Revert.
648         * exec.c: Revert.
649         * exceptions.c: Revert.
650         * event-top.c: Revert.
651         * event-loop.c: Revert.
652         * eval.c: Revert.
653         * elfread.c: Revert.
654         * dwarf2read.h: Revert.
655         * dwarf2read.c: Revert.
656         * dwarf2loc.c: Revert.
657         * dwarf2expr.h: Revert.
658         * dwarf2expr.c: Revert.
659         * dwarf2-frame.c: Revert.
660         * dwarf2-frame-tailcall.c: Revert.
661         * dwarf-index-write.h: Revert.
662         * dwarf-index-write.c: Revert.
663         * dwarf-index-common.c: Revert.
664         * dwarf-index-cache.h: Revert.
665         * dwarf-index-cache.c: Revert.
666         * dummy-frame.c: Revert.
667         * dtrace-probe.c: Revert.
668         * disasm.h: Revert.
669         * disasm.c: Revert.
670         * disasm-selftests.c: Revert.
671         * dictionary.c: Revert.
672         * dicos-tdep.c: Revert.
673         * demangle.c: Revert.
674         * dcache.h: Revert.
675         * dcache.c: Revert.
676         * darwin-nat.h: Revert.
677         * darwin-nat.c: Revert.
678         * darwin-nat-info.c: Revert.
679         * d-valprint.c: Revert.
680         * d-namespace.c: Revert.
681         * d-lang.c: Revert.
682         * ctf.c: Revert.
683         * csky-tdep.c: Revert.
684         * csky-linux-tdep.c: Revert.
685         * cris-tdep.c: Revert.
686         * cris-linux-tdep.c: Revert.
687         * cp-valprint.c: Revert.
688         * cp-support.c: Revert.
689         * cp-namespace.c: Revert.
690         * cp-abi.c: Revert.
691         * corelow.c: Revert.
692         * corefile.c: Revert.
693         * continuations.c: Revert.
694         * completer.h: Revert.
695         * completer.c: Revert.
696         * complaints.c: Revert.
697         * coffread.c: Revert.
698         * coff-pe-read.c: Revert.
699         * cli-out.h: Revert.
700         * cli-out.c: Revert.
701         * charset.c: Revert.
702         * c-varobj.c: Revert.
703         * c-valprint.c: Revert.
704         * c-typeprint.c: Revert.
705         * c-lang.c: Revert.
706         * buildsym.c: Revert.
707         * buildsym-legacy.c: Revert.
708         * build-id.h: Revert.
709         * build-id.c: Revert.
710         * btrace.c: Revert.
711         * bsd-uthread.c: Revert.
712         * breakpoint.h: Revert.
713         * breakpoint.c: Revert.
714         * break-catch-throw.c: Revert.
715         * break-catch-syscall.c: Revert.
716         * break-catch-sig.c: Revert.
717         * blockframe.c: Revert.
718         * block.c: Revert.
719         * bfin-tdep.c: Revert.
720         * bfin-linux-tdep.c: Revert.
721         * bfd-target.c: Revert.
722         * bcache.c: Revert.
723         * ax-general.c: Revert.
724         * ax-gdb.h: Revert.
725         * ax-gdb.c: Revert.
726         * avr-tdep.c: Revert.
727         * auxv.c: Revert.
728         * auto-load.c: Revert.
729         * arm-wince-tdep.c: Revert.
730         * arm-tdep.c: Revert.
731         * arm-symbian-tdep.c: Revert.
732         * arm-pikeos-tdep.c: Revert.
733         * arm-obsd-tdep.c: Revert.
734         * arm-nbsd-tdep.c: Revert.
735         * arm-nbsd-nat.c: Revert.
736         * arm-linux-tdep.c: Revert.
737         * arm-linux-nat.c: Revert.
738         * arm-fbsd-tdep.c: Revert.
739         * arm-fbsd-nat.c: Revert.
740         * arm-bsd-tdep.c: Revert.
741         * arch-utils.c: Revert.
742         * arc-tdep.c: Revert.
743         * arc-newlib-tdep.c: Revert.
744         * annotate.h: Revert.
745         * annotate.c: Revert.
746         * amd64-windows-tdep.c: Revert.
747         * amd64-windows-nat.c: Revert.
748         * amd64-tdep.c: Revert.
749         * amd64-sol2-tdep.c: Revert.
750         * amd64-obsd-tdep.c: Revert.
751         * amd64-obsd-nat.c: Revert.
752         * amd64-nbsd-tdep.c: Revert.
753         * amd64-nbsd-nat.c: Revert.
754         * amd64-nat.c: Revert.
755         * amd64-linux-tdep.c: Revert.
756         * amd64-linux-nat.c: Revert.
757         * amd64-fbsd-tdep.c: Revert.
758         * amd64-fbsd-nat.c: Revert.
759         * amd64-dicos-tdep.c: Revert.
760         * amd64-darwin-tdep.c: Revert.
761         * amd64-bsd-nat.c: Revert.
762         * alpha-tdep.c: Revert.
763         * alpha-obsd-tdep.c: Revert.
764         * alpha-nbsd-tdep.c: Revert.
765         * alpha-mdebug-tdep.c: Revert.
766         * alpha-linux-tdep.c: Revert.
767         * alpha-linux-nat.c: Revert.
768         * alpha-bsd-tdep.c: Revert.
769         * alpha-bsd-nat.c: Revert.
770         * aix-thread.c: Revert.
771         * agent.c: Revert.
772         * addrmap.c: Revert.
773         * ada-varobj.c: Revert.
774         * ada-valprint.c: Revert.
775         * ada-typeprint.c: Revert.
776         * ada-tasks.c: Revert.
777         * ada-lang.c: Revert.
778         * aarch64-tdep.c: Revert.
779         * aarch64-ravenscar-thread.c: Revert.
780         * aarch64-newlib-tdep.c: Revert.
781         * aarch64-linux-tdep.c: Revert.
782         * aarch64-linux-nat.c: Revert.
783         * aarch64-fbsd-tdep.c: Revert.
784         * aarch64-fbsd-nat.c: Revert.
785         * aarch32-linux-nat.c: Revert.
786
787 2019-04-05  Tom Tromey  <tom@tromey.com>
788
789         * ft32-tdep.c: Sort headers.
790         * frv-tdep.c: Sort headers.
791         * frv-linux-tdep.c: Sort headers.
792         * frame.c: Sort headers.
793         * frame-unwind.c: Sort headers.
794         * frame-base.c: Sort headers.
795         * fork-child.c: Sort headers.
796         * findvar.c: Sort headers.
797         * findcmd.c: Sort headers.
798         * filesystem.c: Sort headers.
799         * filename-seen-cache.h: Sort headers.
800         * filename-seen-cache.c: Sort headers.
801         * fbsd-tdep.c: Sort headers.
802         * fbsd-nat.h: Sort headers.
803         * fbsd-nat.c: Sort headers.
804         * f-valprint.c: Sort headers.
805         * f-typeprint.c: Sort headers.
806         * f-lang.c: Sort headers.
807         * extension.h: Sort headers.
808         * extension.c: Sort headers.
809         * extension-priv.h: Sort headers.
810         * expprint.c: Sort headers.
811         * exec.h: Sort headers.
812         * exec.c: Sort headers.
813         * exceptions.c: Sort headers.
814         * event-top.c: Sort headers.
815         * event-loop.c: Sort headers.
816         * eval.c: Sort headers.
817         * elfread.c: Sort headers.
818         * dwarf2read.h: Sort headers.
819         * dwarf2read.c: Sort headers.
820         * dwarf2loc.c: Sort headers.
821         * dwarf2expr.h: Sort headers.
822         * dwarf2expr.c: Sort headers.
823         * dwarf2-frame.c: Sort headers.
824         * dwarf2-frame-tailcall.c: Sort headers.
825         * dwarf-index-write.h: Sort headers.
826         * dwarf-index-write.c: Sort headers.
827         * dwarf-index-common.c: Sort headers.
828         * dwarf-index-cache.h: Sort headers.
829         * dwarf-index-cache.c: Sort headers.
830         * dummy-frame.c: Sort headers.
831         * dtrace-probe.c: Sort headers.
832         * disasm.h: Sort headers.
833         * disasm.c: Sort headers.
834         * disasm-selftests.c: Sort headers.
835         * dictionary.c: Sort headers.
836         * dicos-tdep.c: Sort headers.
837         * demangle.c: Sort headers.
838         * dcache.h: Sort headers.
839         * dcache.c: Sort headers.
840         * darwin-nat.h: Sort headers.
841         * darwin-nat.c: Sort headers.
842         * darwin-nat-info.c: Sort headers.
843         * d-valprint.c: Sort headers.
844         * d-namespace.c: Sort headers.
845         * d-lang.c: Sort headers.
846         * ctf.c: Sort headers.
847         * csky-tdep.c: Sort headers.
848         * csky-linux-tdep.c: Sort headers.
849         * cris-tdep.c: Sort headers.
850         * cris-linux-tdep.c: Sort headers.
851         * cp-valprint.c: Sort headers.
852         * cp-support.c: Sort headers.
853         * cp-namespace.c: Sort headers.
854         * cp-abi.c: Sort headers.
855         * corelow.c: Sort headers.
856         * corefile.c: Sort headers.
857         * continuations.c: Sort headers.
858         * completer.h: Sort headers.
859         * completer.c: Sort headers.
860         * complaints.c: Sort headers.
861         * coffread.c: Sort headers.
862         * coff-pe-read.c: Sort headers.
863         * cli-out.h: Sort headers.
864         * cli-out.c: Sort headers.
865         * charset.c: Sort headers.
866         * c-varobj.c: Sort headers.
867         * c-valprint.c: Sort headers.
868         * c-typeprint.c: Sort headers.
869         * c-lang.c: Sort headers.
870         * buildsym.c: Sort headers.
871         * buildsym-legacy.c: Sort headers.
872         * build-id.h: Sort headers.
873         * build-id.c: Sort headers.
874         * btrace.c: Sort headers.
875         * bsd-uthread.c: Sort headers.
876         * breakpoint.h: Sort headers.
877         * breakpoint.c: Sort headers.
878         * break-catch-throw.c: Sort headers.
879         * break-catch-syscall.c: Sort headers.
880         * break-catch-sig.c: Sort headers.
881         * blockframe.c: Sort headers.
882         * block.c: Sort headers.
883         * bfin-tdep.c: Sort headers.
884         * bfin-linux-tdep.c: Sort headers.
885         * bfd-target.c: Sort headers.
886         * bcache.c: Sort headers.
887         * ax-general.c: Sort headers.
888         * ax-gdb.h: Sort headers.
889         * ax-gdb.c: Sort headers.
890         * avr-tdep.c: Sort headers.
891         * auxv.c: Sort headers.
892         * auto-load.c: Sort headers.
893         * arm-wince-tdep.c: Sort headers.
894         * arm-tdep.c: Sort headers.
895         * arm-symbian-tdep.c: Sort headers.
896         * arm-pikeos-tdep.c: Sort headers.
897         * arm-obsd-tdep.c: Sort headers.
898         * arm-nbsd-tdep.c: Sort headers.
899         * arm-nbsd-nat.c: Sort headers.
900         * arm-linux-tdep.c: Sort headers.
901         * arm-linux-nat.c: Sort headers.
902         * arm-fbsd-tdep.c: Sort headers.
903         * arm-fbsd-nat.c: Sort headers.
904         * arm-bsd-tdep.c: Sort headers.
905         * arch-utils.c: Sort headers.
906         * arc-tdep.c: Sort headers.
907         * arc-newlib-tdep.c: Sort headers.
908         * annotate.h: Sort headers.
909         * annotate.c: Sort headers.
910         * amd64-windows-tdep.c: Sort headers.
911         * amd64-windows-nat.c: Sort headers.
912         * amd64-tdep.c: Sort headers.
913         * amd64-sol2-tdep.c: Sort headers.
914         * amd64-obsd-tdep.c: Sort headers.
915         * amd64-obsd-nat.c: Sort headers.
916         * amd64-nbsd-tdep.c: Sort headers.
917         * amd64-nbsd-nat.c: Sort headers.
918         * amd64-nat.c: Sort headers.
919         * amd64-linux-tdep.c: Sort headers.
920         * amd64-linux-nat.c: Sort headers.
921         * amd64-fbsd-tdep.c: Sort headers.
922         * amd64-fbsd-nat.c: Sort headers.
923         * amd64-dicos-tdep.c: Sort headers.
924         * amd64-darwin-tdep.c: Sort headers.
925         * amd64-bsd-nat.c: Sort headers.
926         * alpha-tdep.c: Sort headers.
927         * alpha-obsd-tdep.c: Sort headers.
928         * alpha-nbsd-tdep.c: Sort headers.
929         * alpha-mdebug-tdep.c: Sort headers.
930         * alpha-linux-tdep.c: Sort headers.
931         * alpha-linux-nat.c: Sort headers.
932         * alpha-bsd-tdep.c: Sort headers.
933         * alpha-bsd-nat.c: Sort headers.
934         * aix-thread.c: Sort headers.
935         * agent.c: Sort headers.
936         * addrmap.c: Sort headers.
937         * ada-varobj.c: Sort headers.
938         * ada-valprint.c: Sort headers.
939         * ada-typeprint.c: Sort headers.
940         * ada-tasks.c: Sort headers.
941         * ada-lang.c: Sort headers.
942         * aarch64-tdep.c: Sort headers.
943         * aarch64-ravenscar-thread.c: Sort headers.
944         * aarch64-newlib-tdep.c: Sort headers.
945         * aarch64-linux-tdep.c: Sort headers.
946         * aarch64-linux-nat.c: Sort headers.
947         * aarch64-fbsd-tdep.c: Sort headers.
948         * aarch64-fbsd-nat.c: Sort headers.
949         * aarch32-linux-nat.c: Sort headers.
950
951 2019-04-04  Tom Tromey  <tom@tromey.com>
952
953         * varobj.c (varobj_create): Update.
954         * rust-exp.y (struct rust_parser) <update_innermost_block,
955         lookup_symbol>: New methods.
956         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
957         Rename.
958         (rust_parser::rust_lookup_type)
959         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
960         * printcmd.c (display_command, do_one_display): Update.
961         * parser-defs.h (struct parser_state) <parser_state>: Add
962         "tracker" parameter.
963         (block_tracker): New member.
964         (class innermost_block_tracker) <innermost_block_tracker>: Add
965         "types" parameter.
966         <reset>: Remove method.
967         (innermost_block): Don't declare.
968         (null_post_parser): Update.
969         * parse.c (innermost_block): Remove global.
970         (write_dollar_variable): Update.
971         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
972         Remove "tracker_types" parameter.
973         (parse_expression): Add "tracker" parameter.
974         (parse_expression_for_completion): Update.
975         (null_post_parser): Add "tracker" parameter.
976         * p-exp.y: Update rules.
977         * m2-exp.y: Update rules.
978         * language.h (struct language_defn) <la_post_parser>: Add
979         "tracker" parameter.
980         * go-exp.y: Update rules.
981         * f-exp.y: Update rules.
982         * expression.h (parse_expression, parse_exp_1): Add "tracker"
983         parameter.
984         * d-exp.y: Update rules.
985         * c-exp.y: Update rules.
986         * breakpoint.c (set_breakpoint_condition): Create an
987         innermost_block_tracker.
988         (watch_command_1): Likewise.
989         * ada-lang.c (resolve): Add "tracker" parameter.
990         (resolve_subexp): Likewise.
991         * ada-exp.y (write_var_from_sym): Update.
992
993 2019-04-04  Tom Tromey  <tom@tromey.com>
994
995         * type-stack.h: New file.
996         * type-stack.c: New file.
997         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
998         type-stack.h.
999         (insert_into_type_stack, insert_type, push_type, push_type_int)
1000         (insert_type_address_space, pop_type, pop_type_int)
1001         (pop_typelist, pop_type_stack, append_type_stack)
1002         (push_type_stack, get_type_stack, push_typelist)
1003         (follow_type_instance_flags, follow_types): Don't declare.
1004         * parse.c (type_stack): Remove global.
1005         (parse_exp_in_context): Update.
1006         (insert_into_type_stack, insert_type, push_type, push_type_int)
1007         (insert_type_address_space, pop_type, pop_type_int)
1008         (pop_typelist, pop_type_stack, append_type_stack)
1009         (push_type_stack, get_type_stack, push_typelist)
1010         (follow_type_instance_flags, follow_types): Remove (moved to
1011         type-stack.c).
1012         * f-exp.y (type_stack): New global.
1013         Update rules.
1014         (push_kind_type, f_parse): Update.
1015         * d-exp.y (type_stack): New global.
1016         Update rules.
1017         (d_parse): Update.
1018         * c-exp.y (struct c_parse_state) <type_stack>: New member.
1019         Update rules.
1020         * Makefile.in (COMMON_SFILES): Add type-stack.c.
1021         (HFILES_NO_SRCDIR): Add type-stack.h.
1022
1023 2019-04-04  Tom Tromey  <tom@tromey.com>
1024
1025         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
1026         (rust_parser::convert_ast_to_expression, rust_parse)
1027         (rust_lex_test_completion, rust_lex_tests): Update.
1028         * parser-defs.h (struct expr_completion_state): New.
1029         (struct parser_state) <parser_state>: Add completion parameter.
1030         <mark_struct_expression, mark_completion_tag>: New methods.
1031         <parse_completion, m_completion_state>: New members.
1032         (prefixify_expression, null_post_parser): Update.
1033         (mark_struct_expression, mark_completion_tag): Don't declare.
1034         * parse.c (parse_completion, expout_last_struct)
1035         (expout_tag_completion_type, expout_completion_name): Remove
1036         globals.
1037         (parser_state::mark_struct_expression)
1038         (parser_state::mark_completion_tag): Now methods.
1039         (prefixify_expression): Add last_struct parameter.
1040         (prefixify_subexp): Likewise.
1041         (parse_exp_1): Update.
1042         (parse_exp_in_context): Add cstate parameter.  Update.
1043         (parse_expression_for_completion): Create an
1044         expr_completion_state.
1045         (null_post_parser): Add "completion" parameter.
1046         * p-exp.y: Update rules.
1047         (yylex): Update.
1048         * language.h (struct language_defn) <la_post_parser>: Add
1049         "completing" parameter.
1050         * go-exp.y: Update rules.
1051         (lex_one_token): Update.
1052         * expression.h (parse_completion): Don't declare.
1053         * d-exp.y: Update rules.
1054         (lex_one_token): Update rules.
1055         * c-exp.y: Update rules.
1056         (lex_one_token): Update.
1057         * ada-lang.c (resolve): Add "parse_completion" parameter.
1058         (resolve_subexp): Likewise.
1059         (ada_resolve_function): Likewise.
1060
1061 2019-04-04  Tom Tromey  <tom@tromey.com>
1062
1063         * parser-defs.h (struct parser_state) <start_arglist,
1064         end_arglist>: New methods.
1065         <arglist_len, m_funcall_chain>: New members.
1066         (arglist_len, start_arglist, end_arglist): Don't declare.
1067         * parse.c (arglist_len, funcall_chain): Remove global.
1068         (start_arglist, end_arglist): Remove functions.
1069         (parse_exp_in_context): Update.
1070         * p-exp.y: Update rules.
1071         * m2-exp.y: Update rules.
1072         * go-exp.y: Update rules.
1073         * f-exp.y: Update rules.
1074         * d-exp.y: Update rules.
1075         * c-exp.y: Update rules.
1076
1077 2019-04-04  Tom Tromey  <tom@tromey.com>
1078
1079         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
1080         lex_operator, push_back>: New methods.
1081         Update all rules.
1082         (rust_parser::lex_hex, lex_escape): Rename and update.
1083         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
1084         (rust_parser::lex_operator): Rename and update.
1085         (rust_parser::lex_number, rustyylex, rustyyerror)
1086         (rust_lex_test_init, rust_lex_test_sequence)
1087         (rust_lex_test_push_back, rust_lex_tests): Update.
1088         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
1089         parameter.
1090         <lexptr, prev_lexptr>: New members.
1091         (lexptr, prev_lexptr): Don't declare.
1092         * parse.c (lexptr, prev_lexptr): Remove globals.
1093         (parse_exp_in_context): Update.
1094         * p-exp.y (yylex, yyerror): Update.
1095         * m2-exp.y (parse_number, yylex, yyerror): Update.
1096         * go-exp.y (lex_one_token, yyerror): Update.
1097         * f-exp.y (match_string_literal, yylex, yyerror): Update.
1098         * d-exp.y (lex_one_token, yyerror): Update.
1099         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
1100         (lex_one_token, yyerror): Update.
1101         * ada-lex.l (YY_INPUT): Update.
1102         (rewind_to_char): Update.
1103         * ada-exp.y (yyerror): Update.
1104
1105 2019-04-04  Tom Tromey  <tom@tromey.com>
1106
1107         * rust-exp.y (rustyylex, rust_lex_tests): Update.
1108         * parser-defs.h (struct parser_state) <parser_state>: Add new
1109         parameter.
1110         <comma_terminates>: New member.
1111         (comma_terminates): Don't declare global.
1112         * parse.c (comma_terminates): Remove global.
1113         (parse_exp_in_context): Update.
1114         * p-exp.y (yylex): Update.
1115         * m2-exp.y (yylex): Update.
1116         * go-exp.y (lex_one_token): Update.
1117         * f-exp.y (yylex): Update.
1118         * d-exp.y (lex_one_token): Update.
1119         * c-exp.y (lex_one_token): Update.
1120         * ada-lex.l: Update.
1121
1122 2019-04-04  Tom Tromey  <tom@tromey.com>
1123
1124         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
1125         (rustyylex, rust_lex_test_init, rust_lex_test_one)
1126         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
1127         * parser-defs.h (paren_depth): Don't declare.
1128         * parse.c (paren_depth): Remove global.
1129         (parse_exp_in_context): Update.
1130         * p-exp.y (paren_depth): New global.
1131         (pascal_parse): Initialize it.
1132         * m2-exp.y (paren_depth): New global.
1133         (m2_parse): Initialize it.
1134         * go-exp.y (paren_depth): New global.
1135         (go_parse): Initialize it.
1136         * f-exp.y (paren_depth): New global.
1137         (f_parse): Initialize it.
1138         * d-exp.y (paren_depth): New global.
1139         (d_parse): Initialize it.
1140         * c-exp.y (paren_depth): New global.
1141         (c_parse): Initialize it.
1142         * ada-lex.l (paren_depth): New global.
1143         (lexer_init): Initialize it.
1144
1145 2019-04-04  Tom Tromey  <tom@tromey.com>
1146
1147         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
1148         (rust_parser::convert_ast_to_type)
1149         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1150         * parser-defs.h (struct parser_state) <parser_state>: Add
1151         parameters.  Initialize new members.
1152         <expression_context_block, expression_context_pc>: New members.
1153         * parse.c (expression_context_block, expression_context_pc):
1154         Remove globals.
1155         (parse_exp_in_context): Update.
1156         * p-exp.y: Update all rules.
1157         (yylex): Update.
1158         * m2-exp.y: Update all rules.
1159         (yylex): Update.
1160         * go-exp.y (yylex): Update.
1161         * f-exp.y (yylex): Update.
1162         * d-exp.y: Update all rules.
1163         (yylex): Update.
1164         * c-exp.y: Update all rules.
1165         (lex_one_token, classify_name, yylex, c_parse): Update.
1166         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
1167
1168 2019-04-04  Tom Tromey  <tom@tromey.com>
1169
1170         * gdbarch.h, gdbarch.c: Rebuild.
1171         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
1172         * stap-probe.h: 
1173         (struct stap_parse_info): Replace "parser_state" with
1174         "expr_builder".
1175         * parser-defs.h (struct expr_builder): Rename from "parser_state".
1176         (parser_state): New class.
1177         * parse.c (expr_builder): Rename.
1178         (expr_builder::release): Rename.
1179         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
1180         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
1181         (write_exp_elt_longcst, write_exp_elt_floatcst)
1182         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
1183         (write_exp_string_vector, write_exp_bitstring)
1184         (write_exp_msymbol, mark_struct_expression)
1185         (write_dollar_variable)
1186         (insert_type_address_space, increase_expout_size): Replace
1187         "parser_state" with "expr_builder".
1188         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
1189         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
1190         "parser_state" with "expr_builder".
1191
1192 2019-04-04  Tom Tromey  <tom@tromey.com>
1193
1194         * rust-exp.y: Replace "parse_language" with method call.
1195         * p-exp.y: 
1196         (yylex): Replace "parse_language" with method call.
1197         * m2-exp.y: 
1198         (yylex): Replace "parse_language" with method call.
1199         * go-exp.y (classify_name): Replace "parse_language" with method
1200         call.
1201         * f-exp.y (yylex): Replace "parse_language" with method call.
1202         * d-exp.y (lex_one_token): Replace "parse_language" with method
1203         call.
1204         * c-exp.y: 
1205         (lex_one_token, classify_name, yylex): Replace "parse_language"
1206         with method call.
1207         * ada-exp.y (find_primitive_type, type_char)
1208         (type_system_address): Replace "parse_language" with method call.
1209
1210 2019-04-04  Tom Tromey  <tom@tromey.com>
1211
1212         * rust-exp.y: Replace "parse_gdbarch" with method call.
1213         * parse.c (write_dollar_variable, insert_type_address_space):
1214         Replace "parse_gdbarch" with method call.
1215         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
1216         call.
1217         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
1218         call.
1219         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
1220         "parse_gdbarch" with method call.
1221         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
1222         with method call.
1223         * f-exp.y (parse_type, parse_f_type, yylex): Replace
1224         "parse_gdbarch" with method call.
1225         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
1226         "parse_gdbarch" with method call.
1227         * c-exp.y (parse_type, parse_number, classify_name): Replace
1228         "parse_gdbarch" with method call.
1229         * ada-lex.l: Replace "parse_gdbarch" with method call.
1230         * ada-exp.y (parse_type, find_primitive_type, type_char)
1231         (type_system_address): Replace "parse_gdbarch" with method call.
1232
1233 2019-04-04  Tom Tromey  <tom@tromey.com>
1234
1235         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
1236         * stap-probe.c (stap_parse_argument): Update.
1237         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
1238         initial_size parameter.
1239         * rust-exp.y (rust_lex_tests): Update.
1240         * parse.c (parser_state): Update.
1241         (parse_exp_in_context): Update.
1242         * parser-defs.h (struct parser_state) <parser_state>: Remove
1243         "initial_size" parameter.
1244
1245 2019-04-04  Tom Tromey  <tom@tromey.com>
1246
1247         * parser-defs.h (increase_expout_size): Don't declare.
1248         * parse.c (increase_expout_size): Now static.
1249
1250 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
1251
1252         * gnu-nat.c (gnu_nat_target::wait): Fix
1253         target_waitstatus_to_string call.
1254
1255 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1256
1257         * eval.c (evaluate_subexp_standard): Handle internal functions
1258         during Fortran function call handling.
1259
1260 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1261
1262         * NEWS: Mention new internal functions.
1263         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
1264         (read_base_type): Use dwarf2_init_complex_target_type.
1265         * value.c (creal_internal_fn): New function.
1266         (cimag_internal_fn): New function.
1267         (_initialize_values): Register new internal functions.
1268
1269 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1270
1271         * infrun.c (stop_all_threads): If debug_infrun, always
1272         trace the wait status after wait_one, using
1273         target_waitstatus_to_string and target_pid_to_str.
1274         (handle_inferior_event): Replace various trace of
1275         wait status kind by a single trace.
1276         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
1277         wait status kind image by target_waitstatus_to_string.
1278         * target/waitstatus.c (target_waitstatus_to_string): Fix
1279         obsolete comment.
1280
1281 2019-04-01  Tom Tromey  <tromey@adacore.com>
1282
1283         PR symtab/23331:
1284         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
1285
1286 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
1287             Pedro Alves  <palves@redhat.com>
1288
1289         * top.c (quit_force): Call 'finalize_values'.
1290         * value.c (finalize_values): New function.
1291         * value.h (finalize_values): Declare.
1292
1293 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
1294
1295         * NEWS: Announce $_gdb_major and $_gdb_minor.
1296
1297         * top.c (init_gdb_version_vars): New function.
1298         (gdb_init): Call init_gdb_version_vars.
1299
1300 2019-03-29  Tom Tromey  <tromey@adacore.com>
1301
1302         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
1303         help text.  Remove dead code.
1304
1305 2019-03-29  Keith Seitz  <keiths@redhat.com>
1306
1307         From Siddhesh Poyarekar:
1308         * f-lang.h (f77_get_upperbound): Return LONGEST.
1309         (f77_get_lowerbound): Likewise.
1310         * f-typeprint.c (f_type_print_varspec_suffix): Expand
1311         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
1312         print them.
1313         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
1314         plongest to format print it.
1315         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
1316         (f77_get_upperbound): Likewise.
1317         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
1318         LOWER_BOUND to LONGEST.
1319         (f77_create_arrayprint_offset_tbl): Likewise.
1320
1321 2019-03-29  Keith Seitz  <keiths@redhat.com>
1322
1323         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
1324         %s/pulongest for TYPE_LENGTH instead of %d in format
1325         strings.
1326         * ada-typerint.c (ada_print_type): Likewise.
1327         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
1328         * compile/compile-c-support.c (generate_register_struct): Likewise.
1329         * gdbtypes.c (recursive_dump_type): Likewise.
1330         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
1331         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
1332         instead of %d in format strings.
1333         * riscv-tdep.c (riscv_type_alignment): Cast second argument
1334         to std::min to ULONGEST.
1335         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
1336         instead of %d in format strings.
1337         * tracepoint.c (info_scope_command): Likewise.
1338         * typeprint.c (print_offset_data::update)
1339         (print_offset_data::finish): Likewise.
1340         * xtensa-tdep.c (xtensa_store_return_value)
1341         (xtensa_push_dummy_call): Likewise.
1342
1343 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
1344
1345         * windows-nat.c (display_selector): Fixed format specifications
1346         for 64-bit Cygwin.
1347
1348 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1349
1350         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
1351
1352 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
1353
1354         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
1355         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
1356         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
1357         (nios2_linux_init_abi): Install it.
1358
1359 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1360
1361         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
1362
1363 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1364
1365         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
1366
1367 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1368             Tom Tromey  <tromey@adacore.com>
1369
1370         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
1371
1372 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
1373
1374         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
1375         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
1376         method to compute the bounds of range types. Also print "[evaluated]"
1377         if the bounds' values come from a dynamic evaluation.
1378
1379 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1380
1381         * cp-valprint.c (cp_print_value_fields): Don't print trailing
1382         whitespace when pretty printing is on.
1383
1384 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1385
1386         * ppc-linux-nat.c: Add include.
1387
1388 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1389
1390         * NEWS: Mention AArch64 Pointer Authentication.
1391
1392 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1393
1394         * arm-linux-nat.c: Add include.
1395
1396 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
1397
1398         * source-cache.c (source_cache::get_source_lines): Re-read
1399         fullname after calling open_source_file.
1400
1401 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
1402
1403         * NEWS: Mention TLS support for FreeBSD.
1404
1405 2019-03-25  Tom Tromey  <tromey@adacore.com>
1406
1407         * minsyms.c (BUNCH_SIZE): Update comment.
1408         (~minimal_symbol_reader): Remove old comment.
1409         (compact_minimal_symbols): Update comment.
1410         (minimal_symbol_reader::install): Remove old comment.  Update
1411         other comments.
1412
1413 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1414
1415         * s390-linux-nat.c: Add include.
1416
1417 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1418
1419         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1420         Call linux_get_hwcap.
1421         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
1422         Likewise.
1423         (aarch64_linux_get_hwcap): Remove function.
1424         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
1425         declaration.
1426         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
1427         linux_get_hwcap.
1428         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1429         * linux-tdep.c (linux_get_hwcap): Add function.
1430         (linux_get_hwcap2): Likewise.
1431         * linux-tdep.h (linux_get_hwcap): Add declaration.
1432         (linux_get_hwcap2): Likewise.
1433         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
1434         (ppc_linux_get_hwcap2): Likewise.
1435         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
1436         linux_get_hwcap.
1437         (ppc_linux_nat_target::insert_watchpoint): Likewise.
1438         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
1439         (ppc_linux_nat_target::read_description): Likewise.
1440         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
1441         * s390-linux-nat.c: Likewise.
1442         * s390-linux-tdep.c (s390_core_read_description): Likewise.
1443
1444 2019-03-24  Tom Tromey  <tom@tromey.com>
1445
1446         * ada-lang.c (standard_lookup): Simplify initialization.
1447         (ada_lookup_symbol_nonlocal): Simplify return.
1448         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
1449         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
1450         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
1451         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
1452         initialization.
1453         * solib.c (solib_global_lookup): Simplify.
1454         * symtab.c (null_block_symbol): Remove.
1455         (symbol_cache_lookup): Simplify returns.
1456         (lookup_language_this): Simplify returns.
1457         (lookup_symbol_aux): Simplify return.
1458         (lookup_local_symbol): Simplify returns.
1459         (lookup_global_symbol_from_objfile): Simplify return.
1460         (lookup_symbol_in_objfile_symtabs)
1461         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
1462         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
1463         (lookup_static_symbol, lookup_global_symbol): Simplify return.
1464         * cp-namespace.c (cp_lookup_bare_symbol)
1465         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
1466         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
1467         (cp_lookup_nested_symbol): Don't use null_block_symbol.
1468         (cp_lookup_symbol_via_imports): Simplify initialization.
1469         (find_symbol_in_baseclass): Likewise.
1470         * symtab.h (null_block_symbol): Remove.
1471         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
1472         (d_lookup_nested_symbol, d_lookup_symbol_imports)
1473         (d_lookup_symbol_module): Likewise.
1474         (find_symbol_in_baseclass): Simplify initialization.
1475
1476 2019-03-24  Tom Tromey  <tom@tromey.com>
1477
1478         * expression.h: Don't include symtab.h.
1479         (struct block): Forward declare.
1480
1481 2019-03-24  Tom Tromey  <tom@tromey.com>
1482
1483         * c-exp.y (typebase): Remove casts.
1484         * gdbtypes.c (lookup_unsigned_typename, )
1485         (lookup_signed_typename): Remove cast.
1486         * eval.c (parse_to_comma_and_eval): Remove cast.
1487         * parse.c (write_dollar_variable): Remove cast.
1488         * block.h (struct block) <superblock>: Now const.
1489         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
1490         * psymtab.c (psym_map_matching_symbols): Make "block" const.
1491         (map_block): Make "block" const.
1492         * symfile.h (struct quick_symbol_functions)
1493         <map_matching_symbols>: Constify block argument to "callback".
1494         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
1495         const.
1496         (find_pc_sect_compunit_symtab): Make "b" const.
1497         (find_symbol_at_address): Likewise.
1498         (search_symbols): Likewise.
1499         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
1500         (dw2_debug_names_lookup_symbol): Likewise.
1501         (dw2_map_matching_symbols): Update.
1502         * p-valprint.c (pascal_val_print): Remove "block".
1503         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
1504         (aux_add_nonlocal_symbols): Make "block" const.
1505         (resolve_subexp): Remove cast.
1506         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
1507         const.
1508         (iterate_over_file_blocks): Likewise.
1509         * f-exp.y (%union) <bval>: Remove.
1510         * coffread.c (patch_opaque_types): Make "b" const.
1511         * spu-tdep.c (spu_catch_start): Make "block" const.
1512         * c-valprint.c (print_unpacked_pointer): Remove "block".
1513         * symmisc.c (dump_symtab_1): Make "b" const.
1514         (block_depth): Make "block" const.
1515         * d-exp.y (%union) <bval>: Remove.
1516         * cp-support.h (cp_lookup_rtti_type): Update.
1517         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
1518         * psymtab.c (psym_lookup_symbol): Make "block" const.
1519         (maintenance_check_psymtabs): Make "b" const.
1520         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
1521         (enumerate_locals, enumerate_args): Update.
1522         * python/py-symtab.c (stpy_global_block): Make "block" const.
1523         (stpy_static_block): Likewise.
1524         * inline-frame.c (block_starting_point_at): Make "new_block"
1525         const.
1526         * block.c (find_block_in_blockvector): Make return type const.
1527         (blockvector_for_pc_sect): Make "b" const.
1528         (find_block_in_blockvector): Make "b" const.
1529
1530 2019-03-23  Tom Tromey  <tom@tromey.com>
1531
1532         * varobj.c (varobj_create): Update.
1533         * symfile.c (clear_symtab_users): Don't reset innermost_block.
1534         * printcmd.c (display_command, do_one_display): Don't reset
1535         innermost_block.
1536         * parser-defs.h (enum innermost_block_tracker_type): Move to
1537         expression.h.
1538         (innermost_block): Update comment.
1539         * parse.c (parse_exp_1): Add tracker_types parameter.
1540         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
1541         tracker_types parameter.  Reset innermost_block.
1542         (parse_exp_in_context): Remove.
1543         (parse_expression_for_completion): Update.
1544         * objfiles.c (~objfile): Don't reset expression_context_block or
1545         innermost_block.
1546         * expression.h (enum innermost_block_tracker_type): Move from
1547         parser-defs.h.
1548         (parse_exp_1): Add tracker_types parameter.
1549         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
1550         reset innermost_block.
1551
1552 2019-03-23  Tom Tromey  <tom@tromey.com>
1553
1554         * objfiles.h: Include bcache.h.
1555
1556 2019-03-23  Tom Tromey  <tom@tromey.com>
1557
1558         * linespec.c (get_current_search_block): Use
1559         scoped_restore_current_language.
1560         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
1561
1562 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1563             Jiong Wang  <jiong.wang@arm.com>
1564
1565         * aarch64-linux-tdep.c
1566         (aarch64_linux_iterate_over_regset_sections): Check for pauth
1567         section.
1568         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
1569
1570 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1571             Jiong Wang  <jiong.wang@arm.com>
1572
1573         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
1574         instructions.
1575         (aarch64_analyze_prologue_test): Add PACIASP test.
1576         (aarch64_prologue_prev_register): Unmask PC value.
1577
1578 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1579             Jiong Wang  <jiong.wang@arm.com>
1580
1581         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
1582         (aarch64_dwarf2_prev_register): Unmask PC value.
1583         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
1584         (aarch64_execute_dwarf_cfa_vendor_op): Check for
1585         DW_CFA_AARCH64_negate_ra_state.
1586         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
1587
1588 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1589             Jiong Wang  <jiong.wang@arm.com>
1590
1591         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
1592         registers.
1593         (aarch64_pseudo_register_name): Likewise.
1594         (aarch64_pseudo_register_type): Likewise.
1595         (aarch64_pseudo_register_reggroup_p): Likewise.
1596         (aarch64_gdbarch_init): Add pauth registers.
1597         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
1598         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
1599         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
1600         (struct gdbarch_tdep): Add regnum for ra_state.
1601
1602 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1603             Jiong Wang  <jiong.wang@arm.com>
1604
1605         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
1606
1607 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1608             Jiong Wang  <jiong.wang@arm.com>
1609
1610         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
1611         function.
1612         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
1613         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
1614         (aarch64_gdbarch_init): Add puth registers.
1615         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
1616         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
1617         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
1618
1619 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1620             Jiong Wang  <jiong.wang@arm.com>
1621
1622         * aarch64-linux-nat.c
1623         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
1624         * aarch64-linux-tdep.c
1625         (aarch64_linux_core_read_description): Likewise.
1626         (aarch64_linux_get_hwcap): New function.
1627         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
1628         (aarch64_linux_get_hwcap): New declaration.
1629
1630 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1631             Jiong Wang  <jiong.wang@arm.com>
1632
1633         * aarch64-linux-nat.c
1634         (aarch64_linux_nat_target::read_description): Add pauth param.
1635         * aarch64-linux-tdep.c
1636         (aarch64_linux_core_read_description): Likewise.
1637         * aarch64-tdep.c (struct target_desc): Add in pauth.
1638         (aarch64_read_description): Add pauth param.
1639         (aarch64_gdbarch_init): Likewise.
1640         * aarch64-tdep.h (aarch64_read_description): Likewise.
1641         * arch/aarch64.c (aarch64_create_target_description): Likewise.
1642         * arch/aarch64.h (aarch64_create_target_description): Likewise.
1643         * features/Makefile: Add new files.
1644         * features/aarch64-pauth.c: New file.
1645         * features/aarch64-pauth.xml: New file.
1646
1647 2019-03-20  Tom Tromey  <tromey@adacore.com>
1648
1649         * infrun.c (handle_inferior_event): Rename from
1650         handle_inferior_event_1.  Create a scoped_value_mark.
1651         (handle_inferior_event): Remove.
1652
1653 2019-03-19  Tom Tromey  <tromey@adacore.com>
1654
1655         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
1656         * infrun.h (print_stop_event): Add "displays" parameter.
1657         * infrun.c (print_stop_event): Add "displays" parameter.
1658
1659 2019-03-19  Pedro Alves  <palves@redhat.com>
1660
1661         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
1662         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
1663         to -1.  Fix TABs vs spaces.
1664         (tui_ui_out::tui_ui_out): Don't initialize fields here.
1665         * tui/tui-out.h (tui_ui_out) Add intro comments.
1666         <m_line, m_start_of_line>: In-class initialize, and add describing
1667         comment.
1668
1669 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
1670
1671         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
1672         variable names.
1673         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
1674
1675 2019-03-18  Pedro Alves  <palves@redhat.com>
1676             Eli Zaretskii <eliz@gnu.org>
1677
1678         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
1679         m_line and m_start_of_line.
1680
1681 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
1682
1683         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
1684         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
1685         it returns a newline.  This fixes a regression in TU mode, whereby
1686         the next line is output on the same screen line as the user input.
1687
1688 2019-03-18  Tom Tromey  <tromey@adacore.com>
1689
1690         * minsyms.c (minimal_symbol_reader::install): Remove call to
1691         obstack_blank.
1692
1693 2019-03-18  Pedro Alves  <palves@redhat.com>
1694
1695         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
1696         New globals.
1697         (apply_style): New, factored out from ...
1698         (apply_ansi_escape): ... this.  Handle reverse video mode.
1699         (tui_set_reverse_mode): New function.
1700         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
1701         * tui/tui-winsource.c (tui_show_source_line): Use
1702         tui_set_reverse_mode instead of setting A_STANDOUT.
1703         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
1704         New setter methods.
1705
1706 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
1707
1708         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
1709         Handle tabs.
1710
1711 2019-03-18  Tom Tromey  <tromey@adacore.com>
1712
1713         * ada-lang.c (empty_array): Add "high" parameter.
1714         (ada_evaluate_subexp): Update.
1715
1716 2019-03-17  Sergei Trofimovich <siarheit@google.com>
1717
1718         * unittests/string_view-selftests.c: Define
1719         _initialize_string_view_selftests unconditionally.
1720
1721 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
1722
1723         PR gdb/24350
1724         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
1725
1726 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
1727
1728         PR gdb/24351
1729         * windows-nat.c (display_selector): Fix format specifiers.
1730
1731 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
1732
1733         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
1734         tui_refill_source_window instead of tui_refresh_win, to update the
1735         current execution line.  This fixes redisplay of the current line
1736         when stepping through the code with "next" or "step".
1737
1738 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
1739
1740         * source-cache.c (source_cache::get_source_lines): Call
1741         find_source_lines to initialize s->nlines.  This fixes vertical
1742         scrolling of TUI source window when the DOWN arrow is pressed.
1743
1744 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1745
1746         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
1747         linux-thread-db.c (_initialize_thread_db): Likewise.
1748
1749 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
1750
1751         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
1752         wclrtoeol in tui_show_source_line".  This reverts changes made in
1753         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
1754
1755 2019-03-15  Tom Tromey  <tom@tromey.com>
1756
1757         * symtab.h (struct minimal_symbol): Derive from
1758         general_symbol_info.
1759         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
1760         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
1761         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
1762         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
1763         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
1764         (MSYMBOL_SEARCH_NAME): Update.
1765         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
1766         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
1767         * minsyms.c (minimal_symbol_reader::record_full): Update.
1768
1769 2019-03-15  Tom Tromey  <tom@tromey.com>
1770
1771         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
1772
1773 2019-03-15  Tom Tromey  <tom@tromey.com>
1774
1775         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
1776         unique_xmalloc_ptr.
1777         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
1778         Update.
1779         * minsyms.c (lookup_minimal_symbol_by_pc_section)
1780         (build_minimal_symbol_hash_tables)
1781         (minimal_symbol_reader::install): Update.
1782
1783 2019-03-15  Tom Tromey  <tom@tromey.com>
1784
1785         * symtab.c (create_demangled_names_hash): Update.
1786         (symbol_set_names): Update.
1787         * objfiles.h (struct objfile_per_bfd_storage)
1788         <demangled_names_hash>: Now an htab_up.
1789         * objfiles.c (objfile_per_bfd_storage): Simplify.
1790
1791 2019-03-15  Tom Tromey  <tom@tromey.com>
1792
1793         * objfiles.h (struct objfile_per_bfd_storage): Declare
1794         destructor.
1795         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
1796         New.
1797         (get_objfile_bfd_data): Use new.  Don't initialize
1798         language_of_main.
1799         (free_objfile_per_bfd_storage): Remove.
1800         (objfile_bfd_data_free, objfile::~objfile): Use delete.
1801
1802 2019-03-15  Tom Tromey  <tom@tromey.com>
1803
1804         * symfile.c (reread_symbols): Update.
1805         * objfiles.c (objfile::objfile): Update.
1806         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
1807         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
1808         comment.
1809         (minimal_symbol_reader::install): Update.
1810         (terminate_minimal_symbol_table): Remove.
1811         * jit.c (jit_object_close_impl): Update.
1812
1813 2019-03-15  Tom Tromey  <tom@tromey.com>
1814
1815         * minsyms.c (minimal_symbol_reader::record_full): Remove some
1816         initializations.
1817
1818 2019-03-15  Tom Tromey  <tom@tromey.com>
1819
1820         * objfiles.h (struct objfile_per_bfd_storage)
1821         <demangled_hash_languages>: Now a bitset.
1822         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
1823         (lookup_minimal_symbol): Update.
1824
1825 2019-03-15  Tom Tromey  <tom@tromey.com>
1826
1827         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
1828         Don't return the symbol.
1829         * coffread.c (record_minimal_symbol): Use record_full.
1830
1831 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
1832
1833         The MS-Windows port of ncurses fails to switch to a color pair if
1834         one or both of the colors are the implicit default colors.  This
1835         change records the default colors when TUI is initialized, and
1836         then specifies them explicitly when a color pair uses the default
1837         colors.  This allows color styling in TUI mode on MS-Windows.
1838
1839         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
1840         ncurses_norm_attr.
1841         (tui_initialize_io) [__MINGW32__]: Record the default terminal
1842         colors in ncurses_norm_attr.
1843         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
1844         "none", replace it with the default color recorded in
1845         ncurses_norm_attr.
1846
1847 2019-03-14  Tom Tromey  <tromey@adacore.com>
1848
1849         * source-cache.h (class source_cache) <get_source_lines>: Return
1850         std::string.
1851         * source-cache.c (source_cache::extract_lines): Handle case where
1852         first_pos==npos.  Return std::string.
1853         (source_cache::get_source_lines): Update.
1854
1855 2019-03-14  Tom Tromey  <tromey@adacore.com>
1856
1857         * NEWS: Add item for "style sources" commands.
1858         * source-cache.c (source_cache::get_source_lines): Check
1859         source_styling.
1860         * cli/cli-style.c (source_styling): New global.
1861         (_initialize_cli_style): Add "style sources" commands.
1862         (show_style_sources): New function.
1863         * cli/cli-style.h (source_styling): Declare.
1864
1865 2019-03-14  Pedro Alves  <palves@redhat.com>
1866             Tom Tromey  <tromey@adacore.com>
1867
1868         * tui/tui-winsource.h (tui_refill_source_window): Declare.
1869         * tui/tui-winsource.c (tui_refill_source_window): New function,
1870         from...
1871         (tui_horizontal_source_scroll): ... here.  Move some logic.
1872         * cli/cli-style.c (set_style_enabled): Notify new observable.
1873         * tui/tui-hooks.c (tui_redisplay_source): New function.
1874         (tui_attach_detach_observers): Attach or detach
1875         tui_redisplay_source.
1876         * observable.h (source_styling_changed): New observable.
1877         * observable.c: Define source_styling_changed observable.
1878
1879 2019-03-13  Tom Tromey  <tromey@adacore.com>
1880
1881         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
1882         (i386_gnu_nat_target::store_registers): Update.
1883         * target-debug.h (target_debug_print_std_string): New macro.
1884         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1885         * windows-tdep.c (display_one_tib): Update.
1886         * tui/tui-stack.c (tui_make_status_line): Update.
1887         * top.c (print_inferior_quit_action): Update.
1888         * thread.c (thr_try_catch_cmd): Update.
1889         (add_thread_with_info): Update.
1890         (thread_target_id_str): Update.
1891         (thr_try_catch_cmd): Update.
1892         (thread_command): Update.
1893         (thread_find_command): Update.
1894         * record-btrace.c (record_btrace_target::info_record)
1895         (record_btrace_resume_thread, record_btrace_target::resume)
1896         (record_btrace_cancel_resume, record_btrace_step_thread)
1897         (record_btrace_target::wait, record_btrace_target::wait)
1898         (record_btrace_target::wait, record_btrace_target::stop): Update.
1899         * progspace.c (print_program_space): Update.
1900         * process-stratum-target.c
1901         (process_stratum_target::thread_address_space): Update.
1902         * linux-fork.c (linux_fork_mourn_inferior)
1903         (detach_checkpoint_command, info_checkpoints_command)
1904         (linux_fork_context): Update.
1905         (linux_fork_detach): Update.
1906         (class scoped_switch_fork_info): Update.
1907         (delete_checkpoint_command): Update.
1908         * infrun.c (follow_fork_inferior): Update.
1909         (follow_fork_inferior): Update.
1910         (proceed_after_vfork_done): Update.
1911         (handle_vfork_child_exec_or_exit): Update.
1912         (follow_exec): Update.
1913         (displaced_step_prepare_throw): Update.
1914         (displaced_step_restore): Update.
1915         (start_step_over): Update.
1916         (resume_1): Update.
1917         (clear_proceed_status_thread): Update.
1918         (proceed): Update.
1919         (print_target_wait_results): Update.
1920         (do_target_wait): Update.
1921         (context_switch): Update.
1922         (stop_all_threads): Update.
1923         (restart_threads): Update.
1924         (finish_step_over): Update.
1925         (handle_signal_stop): Update.
1926         (switch_back_to_stepped_thread): Update.
1927         (keep_going_pass_signal): Update.
1928         (print_exited_reason): Update.
1929         (normal_stop): Update.
1930         * inferior.c (inferior_pid_to_str): Change return type.
1931         (print_selected_inferior): Update.
1932         (add_inferior): Update.
1933         (detach_inferior): Update.
1934         * dummy-frame.c (fprint_dummy_frames): Update.
1935         * dcache.c (dcache_info_1): Update.
1936         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
1937         (btrace_fetch, btrace_clear): Update.
1938         * linux-tdep.c (linux_core_pid_to_str): Change return type.
1939         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
1940         type.
1941         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
1942         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
1943         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
1944         * gdbarch.c, gdbarch.h: Rebuild.
1945         * gdbarch.sh (core_pid_to_str): Change return type.
1946         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
1947         return type.
1948         (windows_nat_target::pid_to_str): Change return type.
1949         (windows_delete_thread): Update.
1950         (windows_nat_target::attach): Update.
1951         (windows_nat_target::files_info): Update.
1952         * target-delegates.c: Rebuild.
1953         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
1954         return type.
1955         (sol_thread_target::pid_to_str): Change return type.
1956         * remote.c (class remote_target) <pid_to_str>: Change return
1957         type.
1958         (remote_target::pid_to_str): Change return type.
1959         (extended_remote_target::attach, remote_target::remote_stop_ns)
1960         (remote_target::remote_notif_remove_queued_reply)
1961         (remote_target::push_stop_reply, remote_target::disable_btrace):
1962         Update.
1963         (extended_remote_target::attach): Update.
1964         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
1965         type.
1966         (gdbsim_target::pid_to_str): Change return type.
1967         * ravenscar-thread.c (struct ravenscar_thread_target)
1968         <pid_to_str>: Change return type.
1969         (ravenscar_thread_target::pid_to_str): Change return type.
1970         * procfs.c (class procfs_target) <pid_to_str>: Change return
1971         type.
1972         (procfs_target::pid_to_str): Change return type.
1973         (procfs_target::attach): Update.
1974         (procfs_target::detach): Update.
1975         (procfs_target::fetch_registers): Update.
1976         (procfs_target::store_registers): Update.
1977         (procfs_target::wait): Update.
1978         (procfs_target::files_info): Update.
1979         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
1980         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
1981         return type.
1982         (nto_procfs_target::pid_to_str): Change return type.
1983         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
1984         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
1985         return type.
1986         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
1987         (exit_lwp): Update.
1988         (attach_proc_task_lwp_callback, get_detach_signal)
1989         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
1990         (linux_nat_target::resume, wait_lwp, stop_callback)
1991         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
1992         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
1993         (linux_nat_wait_1, resume_stopped_resumed_lwps)
1994         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
1995         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
1996         type.
1997         (inf_ptrace_target::attach): Update.
1998         (inf_ptrace_target::files_info): Update.
1999         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
2000         type.
2001         (go32_nat_target::pid_to_str): Change return type.
2002         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
2003         (gnu_nat_target::wait): Update.
2004         (gnu_nat_target::wait): Update.
2005         (gnu_nat_target::resume): Update.
2006         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
2007         (fbsd_nat_target::wait): Update.
2008         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
2009         type.
2010         (darwin_nat_target::attach): Update.
2011         * corelow.c (class core_target) <pid_to_str>: Change return type.
2012         (core_target::pid_to_str): Change return type.
2013         * target.c (normal_pid_to_str): Change return type.
2014         (default_pid_to_str): Likewise.
2015         (target_pid_to_str): Change return type.
2016         (target_translate_tls_address): Update.
2017         (target_announce_detach): Update.
2018         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
2019         return type.
2020         (bsd_uthread_target::pid_to_str): Change return type.
2021         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
2022         type.
2023         (bsd_kvm_target::pid_to_str): Change return type.
2024         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
2025         return type.
2026         (aix_thread_target::pid_to_str): Change return type.
2027         * target.h (struct target_ops) <pid_to_str>: Change return type.
2028         (target_pid_to_str, normal_pid_to_str): Likewise.
2029         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
2030         type.
2031         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
2032         type.
2033         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
2034         return type.
2035         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
2036         type.
2037         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
2038         type.
2039         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
2040         return type.
2041
2042 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
2043
2044         * NEWS: Mention that the new default MI version is 3.  Mention
2045         changes to the output of commands and events that deal with
2046         multi-location breakpoints.
2047         * breakpoint.c: Include "mi/mi-out.h".
2048         (print_one_breakpoint): Change output syntax if using MI version
2049         >= 3.
2050         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
2051         New.
2052         (mi_multi_location_breakpoint_output_fixed): New.
2053         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
2054         (mi_cmd_fix_multi_location_breakpoint_output): New.
2055         (mi_multi_location_breakpoint_output_fixed): New.
2056         * mi/mi-cmds.c (mi_cmds): Register command
2057         -fix-multi-location-breakpoint-output.
2058         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
2059         interpreter "mi".
2060
2061 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
2062
2063         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
2064         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
2065         instantiate mi_ui_out based on interpreter name.
2066         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
2067         * mi/mi-main.c (mi_load_progress): Likewise.
2068
2069 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2070
2071         * NEWS: Combine separate "New targets" sections for 8.3.
2072
2073 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2074
2075         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
2076         (ppcfbsd_init_abi): Install gdbarch
2077         "fetch_tls_load_module_address" and "get_thread_local_address"
2078         methods.
2079
2080 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2081
2082         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
2083         (riscv_fbsd_init_abi): Install gdbarch
2084         "fetch_tls_load_module_address" and "get_thread_local_address"
2085         methods.
2086
2087 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2088
2089         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
2090         (i386fbsd_init_abi): Install gdbarch
2091         "fetch_tls_load_module_address" and "get_thread_local_address"
2092         methods.
2093
2094 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2095
2096         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
2097         (amd64fbsd_init_abi): Install gdbarch
2098         "fetch_tls_load_module_address" and "get_thread_local_address"
2099         methods.
2100
2101 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2102
2103         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
2104         (struct fbsd_pspace_data): New type.
2105         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
2106         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
2107         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
2108         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
2109         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
2110
2111 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2112
2113         * gdbtypes.c (lookup_struct_elt): New function.
2114         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
2115         * gdbtypes.h (struct struct_elt): New type.
2116         (lookup_struct_elt): New prototype.
2117
2118 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2119
2120         * gdbtypes.c (lookup_struct_elt_type): Update comment and
2121         remove disabled code block.
2122
2123 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2124
2125         * gdbarch.sh (get_thread_local_address): New method.
2126         * gdbarch.h, gdbarch.c: Regenerate.
2127         * target.c (target_translate_tls_address): Use
2128         gdbarch_get_thread_local_address if present instead of
2129         target::get_thread_local_address.
2130
2131 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2132
2133         * target.h (target::get_thread_local_address): Update comment.
2134
2135 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2136
2137         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
2138         objfile->separate_debug_objfile_backlink if not NULL.
2139
2140 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2141
2142         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
2143         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
2144         (amd64bsd_store_inferior_registers): Likewise.
2145         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2146         Enable segment base registers.
2147         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
2148         PT_GETFSBASE and PT_GETGSBASE.
2149         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
2150         PT_SETGSBASE.
2151         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
2152         segment base registers.
2153         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2154
2155 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2156
2157         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2158         Update calls to i386_target_description to add 'segments'
2159         parameter.
2160         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
2161         add segment base registers.
2162         * arch/i386.c (i386_create_target_description): Add 'segments'
2163         parameter to enable segment base registers.
2164         * arch/i386.h (i386_create_target_description): Likewise.
2165         * features/i386/32bit-segments.xml: New file.
2166         * features/i386/32bit-segments.c: Generate.
2167         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
2168         call to i386_target_description to add 'segments' parameter.
2169         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2170         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
2171         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
2172         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
2173         if feature is present.
2174         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
2175         Add 'segments' parameter to call to i386_target_description.
2176         (i386_target_description): Add 'segments' parameter to enable
2177         segment base registers.
2178         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
2179         to call to i386_target_description.
2180         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
2181         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
2182         Define I386_NUM_REGS.
2183         (i386_target_description): Add 'segments' parameter to enable
2184         segment base registers.
2185
2186 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
2187
2188         PR/24325
2189         * source-cache.c: #undef open and close, to avoid unresolved
2190         externals during linking.
2191
2192 2019-03-12  Tom Tromey  <tromey@adacore.com>
2193
2194         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
2195         const.  Add initializers.
2196         (_initialize_remote): Don't initialize ptid globals.
2197
2198 2019-03-12  Pedro Alves  <palves@redhat.com>
2199
2200         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
2201
2202 2019-03-12  Pedro Alves  <palves@redhat.com>
2203
2204         * cp-name-parser.y (main): Remove unused 'len' variable.
2205
2206 2019-03-12  Tom Tromey  <tromey@adacore.com>
2207
2208         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
2209         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
2210
2211 2019-03-12  Tom Tromey  <tromey@adacore.com>
2212
2213         * linux-nat.c (iterate_over_lwps): Update.
2214         (stop_callback): Remove parameter.
2215         (stop_wait_callback, detach_callback, resume_set_callback)
2216         (select_singlestep_lwp_callback, set_ignore_sigint)
2217         (status_callback, resumed_callback, resume_clear_callback)
2218         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
2219         data parameter.
2220         (linux_nat_target::detach, linux_nat_target::resume)
2221         (linux_stop_and_wait_all_lwps, select_event_lwp)
2222         (linux_nat_filter_event, linux_nat_wait_1)
2223         (linux_nat_target::kill, linux_nat_target::stop)
2224         (linux_nat_target::stop): Update.
2225         (linux_nat_resume_callback): Change type.
2226         (resume_stopped_resumed_lwps, count_events_callback)
2227         (select_event_lwp_callback): Likewise.
2228         (linux_stop_lwp, linux_nat_stop_lwp): Update.
2229         * arm-linux-nat.c (struct update_registers_data): Remove.
2230         (update_registers_callback): Change type.
2231         (arm_linux_insert_hw_breakpoint1): Update.
2232         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
2233         parameter.
2234         (x86_linux_dr_set_addr): Update.
2235         (x86_linux_dr_set_control): Update.
2236         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
2237         (iterate_over_lwps): Use gdb::function_view.
2238         * nat/aarch64-linux-hw-point.c (struct
2239         aarch64_dr_update_callback_param): Remove.
2240         (debug_reg_change_callback): Change type.
2241         (aarch64_notify_debug_reg_change): Update.
2242         * s390-linux-nat.c (s390_refresh_per_info): Update.
2243
2244 2019-03-11  Tom Tromey  <tromey@adacore.com>
2245
2246         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
2247         redundant assignment to "this_cu".
2248
2249 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2250
2251         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
2252
2253 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2254
2255         * gdbtypes.c (rank_one_type_parm_set): New function extracted
2256         from...
2257         (rank_one_type): ... this.
2258
2259 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2260
2261         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
2262         from...
2263         (rank_one_type): ... this.
2264
2265 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2266
2267         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
2268         from...
2269         (rank_one_type): ... this.
2270
2271 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2272
2273         * gdbtypes.c (rank_one_type_parm_float): New function extracted
2274         from...
2275         (rank_one_type): ... this.
2276
2277 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2278
2279         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
2280         from...
2281         (rank_one_type): ... this.
2282
2283 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2284
2285         * gdbtypes.c (rank_one_type_parm_range): New function extracted
2286         from...
2287         (rank_one_type): ... this.
2288
2289 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2290
2291         * gdbtypes.c (rank_one_type_parm_char): New function extracted
2292         from...
2293         (rank_one_type): ... this.
2294
2295 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2296
2297         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
2298         from...
2299         (rank_one_type): ... this.
2300
2301 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2302
2303         * gdbtypes.c (rank_one_type_parm_int): New function extracted
2304         from...
2305         (rank_one_type): ... this.
2306
2307 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2308
2309         * gdbtypes.c (rank_one_type_parm_func): New function extracted
2310         from...
2311         (rank_one_type): ... this.
2312
2313 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2314
2315         * gdbtypes.c (rank_one_type_parm_array): New function extracted
2316         from...
2317         (rank_one_type): ... this.
2318
2319 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2320
2321         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
2322         from...
2323         (rank_one_type): ... this.
2324
2325 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2326
2327         * inferior.c (initialize_inferiors): Ensure 'help set/show print
2328         inferior-events' shows the example events.
2329
2330 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
2331
2332         Support styling on native MS-Windows console
2333
2334         PR/24315
2335         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
2336         on MS-Windows if $TERM is not defined.
2337
2338         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
2339
2340         * posix-hdep.c (gdb_console_fputs):
2341         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
2342         functions.
2343         * ui-file.h (gdb_console_fputs): Add prototype.
2344
2345         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
2346         back to fputs only if the former returns zero.
2347
2348 2019-03-07  Tom Tromey  <tom@tromey.com>
2349
2350         * symmisc.c (print_symbol_bcache_statistics): Update.
2351         (print_objfile_statistics): Update.
2352         * symfile.c (allocate_symtab): Update.
2353         * stabsread.c: Don't include bcache.h.
2354         * psymtab.h (struct psymbol_bcache): Don't declare.
2355         (class psymtab_storage) <psymbol_cache>: Now a bcache.
2356         (psymbol_bcache_init, psymbol_bcache_free)
2357         (psymbol_bcache_get_bcache): Don't declare.
2358         * psymtab.c (struct psymbol_bcache): Remove.
2359         (psymtab_storage::psymtab_storage): Update.
2360         (psymtab_storage::~psymtab_storage): Update.
2361         (psymbol_bcache_init, psymbol_bcache_free)
2362         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
2363         (add_psymbol_to_bcache): Update.
2364         (allocate_psymtab): Update.
2365         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
2366         macro_cache>: No longer pointers.
2367         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
2368         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
2369         * macrotab.c (macro_bcache): Update.
2370         * macroexp.c: Don't include bcache.h.
2371         * gdbtypes.c (check_types_worklist): Update.
2372         (types_deeply_equal): Remove TRY/CATCH.  Update.
2373         * elfread.c (elf_symtab_read): Update.
2374         * dwarf2read.c: Don't include bcache.h.
2375         * buildsym.c (buildsym_compunit::get_macro_table): Update.
2376         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
2377         (print_bcache_statistics, bcache_memory_used): Don't declare.
2378         (struct bcache): Move from bcache.c.  Add constructor, destructor,
2379         methods.  Rename all data members.
2380         * bcache.c (struct bcache): Move to bcache.h.
2381         (bcache::expand_hash_table): Rename from expand_hash_table.
2382         (bcache): Remove.
2383         (bcache::insert): Rename from bcache_full.
2384         (bcache::compare): Rename from bcache_compare.
2385         (bcache_xmalloc): Remove.
2386         (bcache::~bcache): Rename from bcache_xfree.
2387         (bcache::print_statistics): Rename from print_bcache_statistics.
2388         (bcache::memory_used): Rename from bcache_memory_used.
2389
2390 2019-03-07  Pedro Alves  <palves@redhat.com>
2391
2392         * infrun.c (normal_stop): Also check for
2393         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
2394
2395 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
2396
2397         * f-lang.c (value_from_host_double): Moved to...
2398         * value.c (value_from_host_double): ...here.
2399         * value.h (value_from_host_double): Declare.
2400         * guile/scm-math.c (vlscm_convert_typed_number): Use
2401         value_from_host_double.
2402         (vlscm_convert_number): Likewise.
2403         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
2404         * python/py-value.c (convert_value_from_python): Likewise.
2405
2406 2019-03-06  Tom Tromey  <tom@tromey.com>
2407
2408         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
2409
2410 2019-03-06  Tom Tromey  <tom@tromey.com>
2411
2412         * utils.h (free_current_contents): Don't declare.
2413         * utils.c (free_current_contents): Remove.
2414
2415 2019-03-06  Tom Tromey  <tom@tromey.com>
2416
2417         * top.c (quit_force): Update.
2418         * main.c (captured_command_loop): Update.
2419         * common/new-op.c (operator new): Update.
2420         * common/common-exceptions.c (struct catcher)
2421         <save_cleanup_chain>: Remove member.
2422         (exceptions_state_mc_init): Update.
2423         (exception_try_scope_entry): Return nullptr.
2424         (exception_try_scope_exit, exception_rethrow)
2425         (throw_exception_sjlj, throw_exception_cxx): Update.
2426         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
2427         (all_cleanups, do_cleanups, discard_cleanups)
2428         (discard_final_cleanups, save_cleanups, save_final_cleanups)
2429         (restore_cleanups, restore_final_cleanups): Don't declare.
2430         (do_final_cleanups): Remove parameter.
2431         * common/cleanups.c (cleanup_chain, make_cleanup)
2432         (make_cleanup_dtor, all_cleanups, do_cleanups)
2433         (discard_my_cleanups, discard_cleanups)
2434         (discard_final_cleanups, save_my_cleanups, save_cleanups)
2435         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
2436         (null_cleanup): Remove.
2437         (do_final_cleanups): Remove parameter.
2438
2439 2019-03-06  Tom Tromey  <tom@tromey.com>
2440
2441         * remote.c (remote_target::remote_parse_stop_reply): Use
2442         unique_xmalloc_ptr.
2443
2444 2019-03-06  Tom Tromey  <tom@tromey.com>
2445
2446         * stabsread.c (struct stabs_field_info): Rename from field_info.
2447         <list, fnlist>: Add initializers.
2448         <obstack>: New member.
2449         (read_member_functions, read_struct_fields, read_baseclasses):
2450         Allocate on obstack.  Don't use cleanups.
2451         (read_one_struct_field, read_member_functions, read_struct_fields)
2452         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
2453         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
2454         (read_struct_type): Update.
2455
2456 2019-03-06  Tom Tromey  <tom@tromey.com>
2457
2458         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
2459         * common/filestuff.h (make_cleanup_close): Don't declare.
2460         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
2461         Remove.
2462
2463 2019-03-06  Tom Tromey  <tom@tromey.com>
2464
2465         * solib-aix.c: Use make_scope_exit.
2466
2467 2019-03-06  Tom Tromey  <tom@tromey.com>
2468
2469         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
2470         Use make_scope_exit.
2471
2472 2019-03-06  Tom Tromey  <tom@tromey.com>
2473
2474         * solib-svr4.c (disable_probes_interface): Remove parameter.
2475         (svr4_handle_solib_event): Use make_scope_exit.
2476
2477 2019-03-06  Tom Tromey  <tom@tromey.com>
2478
2479         * remote.c (struct stop_reply_deleter): Remove.
2480         (stop_reply_up): Update.
2481         (struct stop_reply): Derive from notif_event.  Don't typedef.
2482         <regcache>: Now a std::vector.
2483         (stop_reply_xfree): Remove.
2484         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
2485         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
2486         (remote_target::discard_pending_stop_replies): Use delete.
2487         (remote_target::remote_parse_stop_reply): Update.
2488         (remote_target::process_stop_reply): Update.
2489         * remote-notif.h (struct notif_event): Add virtual destructor.
2490         Remove "dtr" member.
2491         (struct notif_client) <alloc_event>: Return a unique_ptr.
2492         (notif_event_xfree): Don't declare.
2493         (notif_event_up): New typedef.
2494         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
2495         (notif_event_xfree, do_notif_event_xfree): Remove.
2496         (remote_notif_state_xfree): Update.
2497
2498 2019-03-06  Tom Tromey  <tom@tromey.com>
2499
2500         * infrun.c (displaced_step_clear_cleanup): Now a
2501         forward_scope_exit type.
2502         (displaced_step_prepare_throw): Update.
2503         (displaced_step_fixup): Update.
2504
2505 2019-03-06  Tom Tromey  <tom@tromey.com>
2506
2507         * inferior.h (class inferior): Update comment.
2508         * gdbthread.h (class thread_info): Update comment.
2509
2510 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
2511             Tom Tromey  <tom@tromey.com>
2512
2513         * stabsread.h (struct stab_section_list): Remove.
2514         (coffstab_build_psymtabs): Update.
2515         * dbxread.c (symbuf_sections): Now a std::vector.
2516         (sect_idx): New global.
2517         (fill_symbuf): Update.
2518         (coffstab_build_psymtabs): Change type of stabsects parameter.
2519         Update.
2520         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
2521         std::vector.
2522         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
2523         (coff_locate_sections): Update.
2524         (coff_symfile_read): Remove cleanups.  Update.
2525         (init_stringtab): Add storage parameter.
2526         (free_stringtab, free_stringtab_cleanup): Remove.
2527         (init_lineno): Add storage parameter.
2528         (free_linetab, free_linetab_cleanup): Remove.
2529
2530 2019-03-06  Pedro Alves  <palves@redhat.com>
2531
2532         * linux-fork.c (fork_info::clobber_regs): Delete.
2533         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
2534         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
2535         comment.  Adjust.
2536         (scoped_switch_fork_info::scoped_switch_fork_info)
2537         (checkpoint_command, linux_fork_context): Adjust
2538         fork_save_infrun_state calls.
2539
2540 2019-03-06  Pedro Alves  <palves@redhat.com>
2541
2542         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
2543         (inf_has_multiple_threads): Return 'bool' and rewrite using
2544         inferior_info::threads().
2545
2546 2019-03-06  Pedro Alves  <palves@redhat.com>
2547
2548         * linux-fork.c: Include <list>.
2549         (fork_list): Now a std::list instance.
2550         (fork_info): Add ctor, dtor, and in-class initialize all fields.
2551         (forks_exist_p, find_last_fork): Adjust.
2552         (new_fork): Delete.
2553         (one_fork_p): New.
2554         (add_fork): Adjust.
2555         (free_fork): Delete, folded into fork_info::~fork_info().
2556         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
2557         Adjust.
2558         (init_fork_list): Delete.
2559         (linux_fork_killall, linux_fork_mourn_inferior)
2560         (linux_fork_detach, info_checkpoints_command): Adjust.
2561         (_initialize_linux_fork): No longer call init_fork_list.
2562
2563 2019-03-06  Pedro Alves  <palves@redhat.com>
2564
2565         * linux-fork.c (new_fork): New, split out of ...
2566         (add_fork): ... this.  Return void.  Move "first fork" special
2567         case from here, to ...
2568         (checkpoint_command): ... here.
2569         * linux-linux.h (add_fork): Return void.
2570
2571 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2572
2573         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
2574
2575 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2576             Chris January  <chris.january@arm.com>
2577             David Lecomber  <david.lecomber@arm.com>
2578
2579         * f-exp.y: New token, UNOP_INTRINSIC.
2580         (exp): New pattern using UNOP_INTRINSIC token.
2581         (f77_keywords): Add 'abs' keyword.
2582         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
2583         (value_from_host_double): New function.
2584         (evaluate_subexp_f): Support UNOP_ABS.
2585
2586 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2587
2588         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
2589         types.
2590
2591 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2592
2593         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
2594         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
2595         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
2596
2597 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2598
2599         * f-exp.y (convert_to_kind_type): Handle more type kinds.
2600
2601 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2602             Chris January  <chris.january@arm.com>
2603
2604         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
2605         * f-exp.y: Define 'KIND' token.
2606         (exp): New pattern for KIND expressions.
2607         (ptype): Handle types with a kind extension.
2608         (direct_abs_decl): Extend to spot kind extensions.
2609         (f77_keywords): Add 'kind' to the list.
2610         (push_kind_type): New function.
2611         (convert_to_kind_type): New function.
2612         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
2613         * parse.c (operator_length_standard): Likewise.
2614         * parser-defs.h (enum type_pieces): Add tp_kind.
2615         * std-operator.def: Add UNOP_KIND.
2616
2617 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2618
2619         * f-exp.y (f_parse): Set yydebug.
2620
2621 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2622
2623         * f-lang.c (evaluate_subexp_f): New function.
2624         (exp_descriptor_f): New global.
2625         (f_language_defn): Use exp_descriptor_f instead of
2626         exp_descriptor_standard.
2627
2628 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2629
2630         * f-exp.y (struct token): Add comments.
2631         (dot_ops): Remove uppercase versions and the end marker.
2632         (f77_keywords): Likewise.
2633         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
2634         entries in the dot_ops array are case insensitive, and use
2635         strncasecmp to compare strings.  Also some whitespace cleanup in
2636         this area.  Similar for the f77_keywords array, except entries in
2637         this list might be case sensitive.
2638
2639 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2640
2641         * f-exp.y (struct f77_boolean_val): Add comments.
2642         (boolean_values): Remove uppercase versions, and end marker.
2643         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
2644         and use strncasecmp to achieve case insensitivity.  Additionally,
2645         perform whitespace cleanup around this code.
2646
2647 2019-03-06  Tom Tromey  <tromey@adacore.com>
2648
2649         * remote-sim.c (gdbsim_target_open): Use result of
2650         gdb_argv::release.
2651
2652 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
2653         Dirk Schubert  <dirk.schubert@arm.com>
2654         Chris January  <chris.january@arm.com>
2655
2656         * eval.c (evaluate_subexp_standard): Call Fortran argument
2657         wrapping logic.
2658         * f-lang.c (struct value): A value which can be passed into a
2659         Fortran function call.
2660         (fortran_argument_convert): Wrap Fortran arguments in a pointer
2661         where appropriate.
2662         (struct type): Value ready for a Fortran function call.
2663         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
2664         is needed.
2665         * f-lang.h (fortran_argument_convert): Declaration.
2666         (fortran_preserve_arg_pointer): Declaration.
2667         * infcall.c (value_arg_coerce): Call Fortran argument logic.
2668
2669 2019-03-05  Tom Tromey  <tromey@adacore.com>
2670
2671         * python/py-prettyprint.c (print_string_repr): Remove #if.
2672         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
2673
2674 2019-03-05  Tom Tromey  <tromey@adacore.com>
2675
2676         * target.c (the_dummy_target): Move later.  Change type to
2677         "dummy_target".
2678         (initialize_targets): Don't initialize the_dummy_target.
2679
2680 2019-03-05  Tom Tromey  <tromey@adacore.com>
2681
2682         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
2683         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
2684
2685 2019-03-05  Tom Tromey  <tromey@adacore.com>
2686
2687         * windows-nat.c (windows_nat_target::attach)
2688         (windows_nat_target::detach): Don't call gdb_flush.
2689         * valprint.c (generic_val_print, val_print, val_print_string):
2690         Don't call gdb_flush.
2691         * utils.c (defaulted_query): Don't call gdb_flush.
2692         * typeprint.c (print_type_scalar): Don't call gdb_flush.
2693         * target.c (target_announce_detach): Don't call gdb_flush.
2694         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
2695         * remote.c (extended_remote_target::attach): Don't call
2696         gdb_flush.
2697         * procfs.c (procfs_target::detach): Don't call gdb_flush.
2698         * printcmd.c (do_examine): Don't call gdb_flush.
2699         (info_display_command): Don't call gdb_flush.
2700         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
2701         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
2702         * memattr.c (info_mem_command): Don't call gdb_flush.
2703         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
2704         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
2705         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
2706         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
2707         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
2708         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
2709         (gnu_nat_target::detach): Don't call gdb_flush.
2710         * f-valprint.c (f_val_print): Don't call gdb_flush.
2711         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
2712         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
2713         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
2714         gdb_flush.
2715         * c-valprint.c (c_val_print): Don't call gdb_flush.
2716         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
2717
2718 2019-03-05  Tom Tromey  <tromey@adacore.com>
2719
2720         * varobj.c (update_dynamic_varobj_children): Update.
2721         (install_default_visualizer): Use reset, not release.
2722         * value.c (set_internalvar): Update.
2723         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
2724         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
2725         ATTRIBUTE_UNUSED_RESULT.
2726
2727 2019-03-05  Tom Tromey  <tromey@adacore.com>
2728
2729         * remote.c (class scoped_remote_fd) <release>: Add
2730         ATTRIBUTE_UNUSED_RESULT.
2731
2732 2019-03-05  Tom Tromey  <tromey@adacore.com>
2733
2734         * macroexp.c (struct macro_buffer) <release>: Add
2735         ATTRIBUTE_UNUSED_RESULT.
2736
2737 2019-03-05  Tom Tromey  <tromey@adacore.com>
2738
2739         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
2740         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
2741         ATTRIBUTE_UNUSED_RESULT.
2742
2743 2019-03-05  Tom Tromey  <tromey@adacore.com>
2744
2745         * common/scoped_fd.h (class scoped_fd) <release>: Add
2746         ATTRIBUTE_UNUSED_RESULT.
2747
2748 2019-03-05  Tom Tromey  <tromey@adacore.com>
2749
2750         * parser-defs.h (struct parser_state) <release>: Add
2751         ATTRIBUTE_UNUSED_RESULT.
2752
2753 2019-03-05  Tom Tromey  <tromey@adacore.com>
2754
2755         * utils.h (class gdb_argv) <release>: Add
2756         ATTRIBUTE_UNUSED_RESULT.
2757         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
2758
2759 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
2760
2761         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
2762         for-loop range, to avoid compiler warnings.
2763
2764         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
2765         avoid compiler warnings about unused variables.
2766
2767         * NEWS: Mention end of support for native debugging on MS-Windows
2768         before XP.
2769
2770         PR gdb/24292
2771         * common/netstuff.c:
2772         * gdbserver/gdbreplay.c
2773         * gdbserver/remote-utils.c:
2774         * ser-tcp.c:
2775         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
2776         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
2777         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
2778         'getaddrinfo' and 'freeaddrinfo' were not available before
2779         Windows XP, and mingw.org's MinGW headers by default define
2780         _WIN32_WINNT to 0x500.
2781
2782 2019-03-01  Gary Benson <gbenson@redhat.com>
2783
2784         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
2785
2786 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
2787             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2788
2789         PR gdb/8527
2790         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
2791         set_sigint_trap, clear_sigint_trap.
2792
2793 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2794
2795         * target.c (target_detach): Clear the regcache and the
2796         frame cache.
2797
2798 2019-02-27  Pedro Alves  <palves@redhat.com>
2799
2800         * utils.c (set_screen_size): When we cap the height/width sizes,
2801         tweak the corresponding command variable to show "unlimited":
2802
2803 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
2804             Pedro Alves  <palves@redhat.com>
2805
2806         * utils.c (set_screen_size): Reduce "infinite" rows and columns
2807         before calling rl_set_screen_size.
2808
2809 2019-02-27  Tom Tromey  <tromey@adacore.com>
2810
2811         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
2812         define.
2813         * python/py-value.c: Remove Python 2.4 workaround.
2814         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
2815         workaround.
2816         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
2817         Python 2.4 workaround.
2818         * python/python-internal.h: Remove Python 2.4 comment.
2819         (Py_ssize_t): Don't define.
2820         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
2821         (gdb_Py_DECREF): Remove Python 2.4 workaround.
2822         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
2823         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
2824         * python/python.c (do_start_initialization): Remove Python 2.4
2825         workaround.
2826         * python/py-prettyprint.c (class dummy_python_frame): Remove.
2827         (print_children): Remove Python 2.4 workaround.
2828         * python/py-inferior.c (buffer_procs): Remove Python 2.4
2829         workaround.
2830         (CHARBUFFERPROC_NAME): Remove.
2831         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
2832         Python 2.4 workaround.
2833
2834 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
2835
2836         * NEWS: Note minimum Python version.
2837
2838 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
2839
2840         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
2841         code from these functions.  Remove corresponding ifdefs.  Use
2842         Py_buffer_up instead of explicit calls to PyBuffer_Release.
2843         Remove gotos and target of gotos.
2844         (infpy_search_memory): Likewise.
2845
2846 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2847
2848         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
2849         (hppa_gdbarch_init): Don't register deleted functions with
2850         gdbarch.
2851
2852 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2853
2854         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
2855         (h8300_unwind_sp): Delete.
2856         (h8300_dummy_id): Delete.
2857         (h8300_gdbarch_init): Don't register deleted functions with
2858         gdbarch.
2859
2860 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2861
2862         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
2863         (ft32_unwind_pc): Delete.
2864         (ft32_unwind_sp): Delete.
2865         (ft32_gdbarch_init): Don't register deleted functions with
2866         gdbarch.
2867
2868 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2869
2870         * gdb/frv-tdep.c (frv_dummy_id): Delete.
2871         (frv_unwind_pc): Delete.
2872         (frv_unwind_sp): Delete.
2873         (frv_gdbarch_init): Don't register deleted functions with
2874         gdbarch.
2875
2876 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2877
2878         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
2879         (riscv_unwind_pc): Delete.
2880         (riscv_unwind_sp): Delete.
2881         (riscv_gdbarch_init): Don't register deleted functions with
2882         gdbarch.
2883
2884 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2885
2886         * gdb/csky-tdep.c (csky_dummy_id): Delete.
2887         (csky_unwind_pc): Delete.
2888         (csky_unwind_sp): Delete.
2889         (csky_gdbarch_init): Don't register deleted functions with
2890         gdbarch.
2891
2892 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2893
2894         * gdb/cris-tdep.c (cris_dummy_id): Delete.
2895         (cris_unwind_pc): Delete.
2896         (cris_unwind_sp): Delete.
2897         (cris_gdbarch_init): Don't register deleted functions with
2898         gdbarch.
2899
2900 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2901
2902         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
2903         (bfin_unwind_pc): Delete.
2904         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
2905
2906 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2907
2908         * gdb/arm-tdep.c (arm_dummy_id): Delete.
2909         (arm_unwind_pc): Delete.
2910         (arm_unwind_sp): Delete.
2911         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
2912
2913 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2914
2915         * gdb/arc-tdep.c (arc_dummy_id): Delete.
2916         (arc_unwind_pc): Delete.
2917         (arc_unwind_sp): Delete.
2918         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
2919
2920 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2921
2922         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
2923         (alpha_unwind_pc): Delete.
2924         (alpha_gdbarch_init): Don't register deleted functions with
2925         gdbarch.
2926
2927 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2928
2929         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
2930         (aarch64_unwind_pc): Delete.
2931         (aarch64_unwind_sp): Delete.
2932         (aarch64_gdbarch_init): Don't register deleted functions with
2933         gdbarch.
2934
2935 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2936
2937         * gdbtypes.c (type_align): Don't consider static members when
2938         computing structure alignment.
2939
2940 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2941
2942         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
2943         return 0 for other types.
2944         * arch-utils.c (default_type_align): Always return 0.
2945         * gdbarch.h: Regenerate.
2946         * gdbarch.sh (type_align): Extend comment.
2947         * gdbtypes.c (type_align): Add additional comments, always call
2948         gdbarch_type_align before applying the default rules.
2949         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
2950         generic code will then apply a suitable default.
2951         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
2952         types, return 0 for other types.
2953
2954 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
2955
2956         * NEWS: Create a new section for the next release branch.
2957         Rename the section of the current branch, now that it has
2958         been cut.
2959
2960 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
2961
2962         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
2963         * version.in: Bump version to 8.3.50.DATE-git.
2964
2965 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
2966
2967         * aix-thread.c (ptid_cmp): Remove unused variable.
2968         (get_signaled_thread): Likewise.
2969         (store_regs_user_thread): Likewise.
2970         (store_regs_kernel_thread): Likewise.
2971         (fetch_regs_kernel_thread): Remove shadowed variable.
2972
2973 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2974
2975         * features/riscv/32bit-cpu.xml: Add register numbers.
2976         * features/riscv/32bit-fpu.c: Regenerate.
2977         * features/riscv/32bit-fpu.xml: Add register numbers.
2978         * features/riscv/64bit-cpu.xml: Add register numbers.
2979         * features/riscv/64bit-fpu.c: Regenerate.
2980         * features/riscv/64bit-fpu.xml: Add register numbers.
2981
2982 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
2983
2984         * NEWS: Mention two argument form of gdb.Value constructor.
2985         * python/py-value.c (convert_buffer_and_type_to_value): New
2986         function.
2987         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
2988         Add support for handling an optional second argument.  Call
2989         convert_buffer_and_type_to_value as appropriate.
2990         * python/python-internal.h (Py_buffer_deleter): New struct.
2991         (Py_buffer_up): New typedef.
2992
2993 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
2994
2995         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
2996         instead of releasing ownership.
2997
2998 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
2999
3000         * dwarf2read.c (open_and_init_dwp_file): Call
3001         elf_numsections instead of bfd_count_sections to initialize
3002         dwp_file->num_sections.
3003
3004 2019-02-25  Tom Tromey  <tromey@adacore.com>
3005
3006         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
3007
3008 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
3009
3010         * gcore.in: Add '--readnever' option when invoking GDB.
3011
3012 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3013
3014         * MAINTAINERS: Update my email address.
3015
3016 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3017
3018         * build-id.c (build_id_to_debug_bfd_1): New function.
3019         (build_id_to_debug_bfd): Look for separate debug file in
3020         sysroot.
3021
3022 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3023
3024         * gdbarch.sh: Update the copyright year range that is placed into
3025         generated files.
3026
3027 2019-02-22  Keith Seitz  <keiths@redhat.com>
3028
3029         PR symtab/23853
3030         * linespec.c (create_sals_line_offset): Search for the default
3031         symtab's filename instead of its fullname.
3032
3033 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3034
3035         * NEWS: Update style defaults.
3036
3037 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3038
3039         * main.c (captured_main_1): Disable styling in batch mode.
3040
3041 2019-02-20  Tom Tromey  <tom@tromey.com>
3042
3043         * symtab.c (symtab_symbol_info): Fix typos.
3044
3045 2019-02-20  Tom Tromey  <tromey@adacore.com>
3046
3047         * findcmd.c (_initialize_mem_search): Use upper case for
3048         metasyntactic variables.
3049
3050 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
3051
3052         * aarch64-tdep.c (aarch64_add_reggroups): New function.
3053         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
3054
3055 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
3056
3057         * top.h (source_file_name): Change to std::string.
3058         * top.c (source_file_name): Likewise.
3059         (command_line_input): Adjust.
3060         * cli/cli-script.c (script_from_file): Adjust.
3061
3062 2019-02-19  Tom Tromey  <tromey@adacore.com>
3063
3064         * ravenscar-thread.c
3065         (ravenscar_thread_target::update_thread_list): Don't call
3066         ada_build_task_list.
3067         * ada-lang.h (ada_build_task_list): Don't declare.
3068         * ada-tasks.c (struct ada_tasks_inferior_data)
3069         <task_list_valid_p>: Now bool.
3070         (read_known_tasks, ada_task_list_changed)
3071         (ada_tasks_invalidate_inferior_data): Update.
3072         (read_known_tasks_array): Return bool.
3073         (read_known_tasks_list): Likewise.
3074         (read_known_tasks): Return void.
3075         (ada_build_task_list): Now static.
3076
3077 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3078
3079         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
3080         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
3081
3082 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3083
3084         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
3085         variant for ada_tasks_pspace_data_handle and
3086         ada_tasks_inferior_data_handle.
3087         (ada_tasks_pspace_data_cleanup): New function.
3088         (ada_tasks_inferior_data_cleanup): New function.
3089
3090 2019-02-17  Tom Tromey  <tom@tromey.com>
3091
3092         * macrotab.h (macro_source_fullname): Return a std::string.
3093         * macrotab.c (macro_include, check_for_redefinition)
3094         (macro_undef, macro_lookup_definition, foreach_macro)
3095         (foreach_macro_in_scope): Update.
3096         (macro_source_fullname): Return a std::string.
3097         * macrocmd.c (show_pp_source_pos): Update.
3098
3099 2019-02-17  Tom Tromey  <tom@tromey.com>
3100
3101         * macrocmd.c (show_pp_source_pos): Style the file names.
3102
3103 2019-02-17  Tom Tromey  <tom@tromey.com>
3104
3105         PR tui/24197:
3106         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
3107
3108 2019-02-17  Tom Tromey  <tom@tromey.com>
3109
3110         * ada-lang.c (user_select_syms): Use filtered printing.
3111         * utils.c (wrap_style): New global.
3112         (desired_style): Remove.
3113         (emit_style_escape): Add stream parameter.
3114         (set_output_style, reset_terminal_style, prompt_for_continue):
3115         Update.
3116         (flush_wrap_buffer): Only flush gdb_stdout.
3117         (wrap_here): Set wrap_style.
3118         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
3119         treat escape sequences as a character.  Change when wrap buffer is
3120         flushed.
3121         (fputs_styled): Do not set the output style when the default is
3122         requested.
3123         * ui-style.h (struct ui_file_style) <is_default>: New method.
3124         * source.c (print_source_lines_base): Emit escape sequences in one
3125         piece.
3126
3127 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3128
3129         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
3130         integers and enumeration types.
3131
3132 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3133
3134         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
3135         instead of lookup_symbol_in_language
3136         (do_exact_match): New function.
3137         (ada_get_symbol_name_matcher): Return do_exact_match when
3138         doing a verbatim match.
3139
3140 2019-02-15  Tom Tromey  <tromey@adacore.com>
3141
3142         * ravenscar-thread.c (ravenscar_thread_target::resume)
3143         (ravenscar_thread_target::wait): Special case wildcard requests.
3144
3145 2019-02-15  Tom Tromey  <tromey@adacore.com>
3146
3147         * ravenscar-thread.c (base_ptid): Remove.
3148         (struct ravenscar_thread_target) <close>: New method.
3149         <m_base_ptid>: New member.
3150         <update_inferior_ptid, active_task, task_is_currently_active,
3151         runtime_initialized>: Declare methods.
3152         <ravenscar_thread_target>: Add constructor.
3153         (ravenscar_thread_target::task_is_currently_active)
3154         (ravenscar_thread_target::update_inferior_ptid)
3155         (ravenscar_runtime_initialized): Rename.  Now methods.
3156         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
3157         (ravenscar_thread_target::update_thread_list): Update.
3158         (ravenscar_thread_target::active_task): Now method.
3159         (ravenscar_thread_target::store_registers)
3160         (ravenscar_thread_target::prepare_to_store)
3161         (ravenscar_thread_target::prepare_to_store)
3162         (ravenscar_thread_target::mourn_inferior): Update.
3163         (ravenscar_inferior_created): Use "new" to create target.
3164         (ravenscar_thread_target::get_ada_task_ptid): Update.
3165         (_initialize_ravenscar): Don't initialize base_ptid.
3166         (ravenscar_ops): Remove global.
3167
3168 2019-02-15  Tom Tromey  <tromey@adacore.com>
3169
3170         * target.h (push_target): Declare new overload.
3171         * target.c (push_target): New overload, taking an rvalue reference.
3172         * remote.c (remote_target::open_1): Use push_target overload.
3173         * corelow.c (core_target_open): Use push_target overload.
3174
3175 2019-02-15  Tom Tromey  <tromey@adacore.com>
3176
3177         * ravenscar-thread.c (is_ravenscar_task)
3178         (ravenscar_task_is_currently_active): Return bool.
3179         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
3180         (_initialize_ravenscar): Remove "(void)".
3181         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
3182         Return bool.
3183
3184 2019-02-15  Tom Tromey  <tromey@adacore.com>
3185
3186         * ravenscar-thread.c (ravenscar_runtime_initializer)
3187         (has_ravenscar_runtime, get_running_thread_id)
3188         (ravenscar_thread_target::resume): Fix indentation.
3189
3190 2019-02-15  Tom Tromey  <tromey@adacore.com>
3191
3192         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
3193         from ravenscar_arch_ops.
3194         (sparc_ravenscar_ops::fetch_registers)
3195         (sparc_ravenscar_ops::store_registers): Now methods.
3196         (sparc_ravenscar_prepare_to_store): Remove.
3197         (sparc_ravenscar_ops): Redefine.
3198         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
3199         methods and destructor.  Remove members.
3200         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
3201         (ravenscar_thread_target::store_registers)
3202         (ravenscar_thread_target::prepare_to_store): Update.
3203         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
3204         Remove.
3205         (struct ppc_ravenscar_powerpc_ops): Derive from
3206         ravenscar_arch_ops.
3207         (ppc_ravenscar_powerpc_ops::fetch_registers)
3208         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
3209         (ppc_ravenscar_powerpc_ops): Redefine.
3210         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
3211         (ppc_ravenscar_e500_ops::fetch_registers)
3212         (ppc_ravenscar_e500_ops::store_registers): Now methods.
3213         (ppc_ravenscar_e500_ops): Redefine.
3214         * aarch64-ravenscar-thread.c
3215         (aarch64_ravenscar_generic_prepare_to_store): Remove.
3216         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
3217         (aarch64_ravenscar_fetch_registers)
3218         (aarch64_ravenscar_store_registers): Now methods.
3219         (aarch64_ravenscar_ops): Redefine.
3220
3221 2019-02-15  Tom Tromey  <tromey@adacore.com>
3222
3223         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
3224         (ravenscar_thread_target::stopped_by_hw_breakpoint)
3225         (ravenscar_thread_target::stopped_by_watchpoint)
3226         (ravenscar_thread_target::stopped_data_address)
3227         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
3228
3229 2019-02-15  Tom Tromey  <tromey@adacore.com>
3230
3231         * ravenscar-thread.c: Fix some typos.
3232
3233 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3234             Tom Tromey  <tromey@adacore.com>
3235
3236         * ada-lang.c (ada_exception_sal): Change addr_string to a
3237         std::string.
3238         (create_ada_exception_catchpoint): Update.
3239
3240 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3241             Tom Tromey  <tromey@adacore.com>
3242
3243         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
3244         (bp_location_ops): Remove.
3245         (base_breakpoint_allocate_location): Update.
3246         (free_bp_location): Update.
3247         * ada-lang.c (class ada_catchpoint_location)
3248         <ada_catchpoint_location>: Remove ops parameter.
3249         (ada_catchpoint_location_dtor): Remove.
3250         (ada_catchpoint_location_ops): Remove.
3251         (allocate_location_exception): Update.
3252         * breakpoint.h (struct bp_location_ops): Remove.
3253         (class bp_location) <bp_location>: Remove bp_location_ops
3254         parameter.
3255         <~bp_location>: Add destructor.
3256         <ops>: Remove.
3257
3258 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3259             Pedro Alves  <palves@redhat.com>
3260
3261         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
3262         'PATH_MAX'.
3263
3264 2019-02-14  David Michael  <fedora.dm0@gmail.com>
3265             Samuel Thibault  <samuel.thibault@gnu.org>
3266             Thomas Schwinge  <thomas@codesourcery.com>
3267
3268         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
3269         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
3270
3271 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3272
3273         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
3274         (check_empty): Use "const char *".
3275
3276         * gnu-nat.c (gnu_nat_target::detach): Instead of
3277         'detach_inferior (pid)' call
3278         'detach_inferior (find_inferior_pid (pid))'.
3279
3280         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
3281         'nat/fork-inferior.o'.
3282         * gnu-nat.c: #include "nat/fork-inferior.h".
3283
3284         * gnu-nat.c (gnu_nat_target::detach): Instead of
3285         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
3286         * gnu-nat.h: #include "inf-child.h".
3287         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
3288         'i386_gnu_nat_target::fetch_registers'.
3289         (gnu_store_registers): Rename/move to
3290         'i386_gnu_nat_target::store_registers'.
3291
3292         * config/i386/nm-i386gnu.h: Don't "#include" any files.
3293         * gnu-nat.h (mach_thread_info): New function.
3294         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
3295
3296         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
3297
3298 2019-02-14  Frederic Konrad  <konrad@adacore.com>
3299
3300         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
3301
3302 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
3303
3304         * windows-nat.c (windows_add_thread): Add new parameter
3305         "main_thread_p" with default value set to false.  Update
3306         function documentation as well as all callers.
3307         (windows_delete_thread): Likewise.
3308         (fake_create_process): Update call to windows_add_thread.
3309         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
3310         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
3311         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
3312         call to windows_delete_thread.
3313
3314 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
3315
3316         * MAINTAINERS: Add Andrew Burgess as global maintainer.
3317
3318 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3319
3320         * symfile.c (find_separate_debug_file): Use canonical path of
3321         sysroot with child_path instead of gdb_sysroot if it is valid.
3322
3323 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3324
3325         * symfile.c (find_separate_debug_file): Use child_path to
3326         determine if an object file is under a sysroot.
3327
3328 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3329
3330         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
3331         unittests/child-path-selftests.c.
3332         * common/pathstuff.c (child_path): New function.
3333         * common/pathstuff.h (child_path): New prototype.
3334         * unittests/child-path-selftests.c: New file.
3335
3336 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3337
3338         * symfile.c (find_separate_debug_file): Look for separate debug
3339         files in debug directories under the sysroot.
3340
3341 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3342
3343         * symtab.h (struct minimal_symbol data_p): New const method.
3344         (struct minimal_symbol text_p): Likewise.
3345         * symtab.c (output_source_filename): Use file name style
3346         to print file name.
3347         (print_symbol_info): Likewise.
3348         (print_msymbol_info): Use address style to print addresses.
3349         Use function name style to print executable text symbols.
3350         (expand_symtab_containing_pc): Use data_p.
3351         (find_pc_sect_compunit_symtab): Likewise.
3352
3353 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3354
3355         * breakpoint.c (describe_other_breakpoints): Use address style
3356         to print addresses.
3357         (say_where): Likewise.
3358
3359 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3360
3361         * ada-typeprint.c (print_func_type): Print function name
3362         style to print function name.
3363         * c-typeprint.c (c_print_type_1): Likewise.
3364
3365 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
3366
3367         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
3368         for execve.
3369
3370 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3371
3372         * c-exp.y (direct_abs_decl): Use emplace_back to record the
3373         type_stack.
3374
3375 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
3376
3377         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
3378         TYPE_CODE_REF types.
3379
3380 2019-02-08  Jim Wilson  <jimw@sifive.com>
3381
3382         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
3383         (riscv_linux_fregset): New.
3384         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
3385
3386 2019-02-07  Tom Tromey  <tom@tromey.com>
3387
3388         * thread.c (thread_cancel_execution_command): Update.
3389         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
3390         methods.
3391         (struct thread_fsm_ops): Remove.
3392         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
3393         (thread_fsm_should_stop, thread_fsm_return_value)
3394         (thread_fsm_set_finished, thread_fsm_finished_p)
3395         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
3396         Don't declare.
3397         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
3398         * infrun.c (clear_proceed_status_thread)
3399         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
3400         (print_stop_event): Update.
3401         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
3402         Add constructor.
3403         (step_command_fsm_ops): Remove.
3404         (new_step_command_fsm): Remove.
3405         (step_1): Update.
3406         (step_command_fsm::should_stop): Rename from
3407         step_command_fsm_should_stop.
3408         (step_command_fsm::clean_up): Rename from
3409         step_command_fsm_clean_up.
3410         (step_command_fsm::do_async_reply_reason): Rename from
3411         step_command_fsm_async_reply_reason.
3412         (struct until_next_fsm): Inherit from thread_fsm.  Add
3413         constructor.
3414         (until_next_fsm_ops): Remove.
3415         (new_until_next_fsm): Remove.
3416         (until_next_fsm::should_stop): Rename from
3417         until_next_fsm_should_stop.
3418         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
3419         (until_next_fsm::do_async_reply_reason): Rename from
3420         until_next_fsm_async_reply_reason.
3421         (struct finish_command_fsm): Inherit from thread_fsm.  Add
3422         constructor.  Change type of breakpoint.
3423         (finish_command_fsm_ops): Remove.
3424         (new_finish_command_fsm): Remove.
3425         (finish_command_fsm::should_stop): Rename from
3426         finish_command_fsm_should_stop.
3427         (finish_command_fsm::clean_up): Rename from
3428         finish_command_fsm_clean_up.
3429         (finish_command_fsm::return_value): Rename from
3430         finish_command_fsm_return_value.
3431         (finish_command_fsm::do_async_reply_reason): Rename from
3432         finish_command_fsm_async_reply_reason.
3433         (finish_command): Update.
3434         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
3435         Add constructor.
3436         (call_thread_fsm_ops): Remove.
3437         (call_thread_fsm::call_thread_fsm): Rename from
3438         new_call_thread_fsm.
3439         (call_thread_fsm::should_stop): Rename from
3440         call_thread_fsm_should_stop.
3441         (call_thread_fsm::should_notify_stop): Rename from
3442         call_thread_fsm_should_notify_stop.
3443         (run_inferior_call, call_function_by_hand_dummy): Update.
3444         * cli/cli-interp.c (should_print_stop_to_console): Update.
3445         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
3446         Add constructor.  Change type of location_breakpoint,
3447         caller_breakpoint.
3448         (until_break_fsm_ops): Remove.
3449         (new_until_break_fsm): Remove.
3450         (until_break_fsm::should_stop): Rename from
3451         until_break_fsm_should_stop.
3452         (until_break_fsm::clean_up): Rename from
3453         until_break_fsm_clean_up.
3454         (until_break_fsm::do_async_reply_reason): Rename from
3455         until_break_fsm_async_reply_reason.
3456         (until_break_command): Update.
3457         * thread-fsm.c: Remove.
3458         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
3459
3460 2019-02-07  Tom Tromey  <tom@tromey.com>
3461
3462         * yy-remap.h: Add include guard.
3463         * xtensa-tdep.h: Add include guard.
3464         * xcoffread.h: Rename include guard.
3465         * varobj-iter.h: Add include guard.
3466         * tui/tui.h: Rename include guard.
3467         * tui/tui-winsource.h: Rename include guard.
3468         * tui/tui-wingeneral.h: Rename include guard.
3469         * tui/tui-windata.h: Rename include guard.
3470         * tui/tui-win.h: Rename include guard.
3471         * tui/tui-stack.h: Rename include guard.
3472         * tui/tui-source.h: Rename include guard.
3473         * tui/tui-regs.h: Rename include guard.
3474         * tui/tui-out.h: Rename include guard.
3475         * tui/tui-layout.h: Rename include guard.
3476         * tui/tui-io.h: Rename include guard.
3477         * tui/tui-hooks.h: Rename include guard.
3478         * tui/tui-file.h: Rename include guard.
3479         * tui/tui-disasm.h: Rename include guard.
3480         * tui/tui-data.h: Rename include guard.
3481         * tui/tui-command.h: Rename include guard.
3482         * tic6x-tdep.h: Add include guard.
3483         * target/waitstatus.h: Rename include guard.
3484         * target/wait.h: Rename include guard.
3485         * target/target.h: Rename include guard.
3486         * target/resume.h: Rename include guard.
3487         * target-float.h: Rename include guard.
3488         * stabsread.h: Add include guard.
3489         * rs6000-tdep.h: Add include guard.
3490         * riscv-fbsd-tdep.h: Add include guard.
3491         * regformats/regdef.h: Rename include guard.
3492         * record.h: Rename include guard.
3493         * python/python.h: Rename include guard.
3494         * python/python-internal.h: Rename include guard.
3495         * python/py-stopevent.h: Rename include guard.
3496         * python/py-ref.h: Rename include guard.
3497         * python/py-record.h: Rename include guard.
3498         * python/py-record-full.h: Rename include guard.
3499         * python/py-record-btrace.h: Rename include guard.
3500         * python/py-instruction.h: Rename include guard.
3501         * python/py-events.h: Rename include guard.
3502         * python/py-event.h: Rename include guard.
3503         * procfs.h: Add include guard.
3504         * proc-utils.h: Add include guard.
3505         * p-lang.h: Add include guard.
3506         * or1k-tdep.h: Rename include guard.
3507         * observable.h: Rename include guard.
3508         * nto-tdep.h: Rename include guard.
3509         * nat/x86-linux.h: Rename include guard.
3510         * nat/x86-linux-dregs.h: Rename include guard.
3511         * nat/x86-gcc-cpuid.h: Add include guard.
3512         * nat/x86-dregs.h: Rename include guard.
3513         * nat/x86-cpuid.h: Rename include guard.
3514         * nat/ppc-linux.h: Rename include guard.
3515         * nat/mips-linux-watch.h: Rename include guard.
3516         * nat/linux-waitpid.h: Rename include guard.
3517         * nat/linux-ptrace.h: Rename include guard.
3518         * nat/linux-procfs.h: Rename include guard.
3519         * nat/linux-osdata.h: Rename include guard.
3520         * nat/linux-nat.h: Rename include guard.
3521         * nat/linux-namespaces.h: Rename include guard.
3522         * nat/linux-btrace.h: Rename include guard.
3523         * nat/glibc_thread_db.h: Rename include guard.
3524         * nat/gdb_thread_db.h: Rename include guard.
3525         * nat/gdb_ptrace.h: Rename include guard.
3526         * nat/fork-inferior.h: Rename include guard.
3527         * nat/amd64-linux-siginfo.h: Rename include guard.
3528         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
3529         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
3530         * nat/aarch64-linux.h: Rename include guard.
3531         * nat/aarch64-linux-hw-point.h: Rename include guard.
3532         * mn10300-tdep.h: Add include guard.
3533         * mips-linux-tdep.h: Add include guard.
3534         * mi/mi-parse.h: Rename include guard.
3535         * mi/mi-out.h: Rename include guard.
3536         * mi/mi-main.h: Rename include guard.
3537         * mi/mi-interp.h: Rename include guard.
3538         * mi/mi-getopt.h: Rename include guard.
3539         * mi/mi-console.h: Rename include guard.
3540         * mi/mi-common.h: Rename include guard.
3541         * mi/mi-cmds.h: Rename include guard.
3542         * mi/mi-cmd-break.h: Rename include guard.
3543         * m2-lang.h: Add include guard.
3544         * location.h: Rename include guard.
3545         * linux-record.h: Rename include guard.
3546         * linux-nat.h: Add include guard.
3547         * linux-fork.h: Add include guard.
3548         * i386-darwin-tdep.h: Rename include guard.
3549         * hppa-linux-offsets.h: Add include guard.
3550         * guile/guile.h: Rename include guard.
3551         * guile/guile-internal.h: Rename include guard.
3552         * gnu-nat.h: Rename include guard.
3553         * gdb-stabs.h: Rename include guard.
3554         * frv-tdep.h: Add include guard.
3555         * f-lang.h: Add include guard.
3556         * event-loop.h: Add include guard.
3557         * darwin-nat.h: Rename include guard.
3558         * cp-abi.h: Rename include guard.
3559         * config/sparc/nm-sol2.h: Rename include guard.
3560         * config/nm-nto.h: Rename include guard.
3561         * config/nm-linux.h: Add include guard.
3562         * config/i386/nm-i386gnu.h: Rename include guard.
3563         * config/djgpp/nl_types.h: Rename include guard.
3564         * config/djgpp/langinfo.h: Rename include guard.
3565         * compile/gcc-cp-plugin.h: Add include guard.
3566         * compile/gcc-c-plugin.h: Add include guard.
3567         * compile/compile.h: Rename include guard.
3568         * compile/compile-object-run.h: Rename include guard.
3569         * compile/compile-object-load.h: Rename include guard.
3570         * compile/compile-internal.h: Rename include guard.
3571         * compile/compile-cplus.h: Rename include guard.
3572         * compile/compile-c.h: Rename include guard.
3573         * common/xml-utils.h: Rename include guard.
3574         * common/x86-xstate.h: Rename include guard.
3575         * common/version.h: Rename include guard.
3576         * common/vec.h: Rename include guard.
3577         * common/tdesc.h: Rename include guard.
3578         * common/selftest.h: Rename include guard.
3579         * common/scoped_restore.h: Rename include guard.
3580         * common/scoped_mmap.h: Rename include guard.
3581         * common/scoped_fd.h: Rename include guard.
3582         * common/safe-iterator.h: Rename include guard.
3583         * common/run-time-clock.h: Rename include guard.
3584         * common/refcounted-object.h: Rename include guard.
3585         * common/queue.h: Rename include guard.
3586         * common/ptid.h: Rename include guard.
3587         * common/print-utils.h: Rename include guard.
3588         * common/preprocessor.h: Rename include guard.
3589         * common/pathstuff.h: Rename include guard.
3590         * common/observable.h: Rename include guard.
3591         * common/netstuff.h: Rename include guard.
3592         * common/job-control.h: Rename include guard.
3593         * common/host-defs.h: Rename include guard.
3594         * common/gdb_wait.h: Rename include guard.
3595         * common/gdb_vecs.h: Rename include guard.
3596         * common/gdb_unlinker.h: Rename include guard.
3597         * common/gdb_unique_ptr.h: Rename include guard.
3598         * common/gdb_tilde_expand.h: Rename include guard.
3599         * common/gdb_sys_time.h: Rename include guard.
3600         * common/gdb_string_view.h: Rename include guard.
3601         * common/gdb_splay_tree.h: Rename include guard.
3602         * common/gdb_setjmp.h: Rename include guard.
3603         * common/gdb_ref_ptr.h: Rename include guard.
3604         * common/gdb_optional.h: Rename include guard.
3605         * common/gdb_locale.h: Rename include guard.
3606         * common/gdb_assert.h: Rename include guard.
3607         * common/filtered-iterator.h: Rename include guard.
3608         * common/filestuff.h: Rename include guard.
3609         * common/fileio.h: Rename include guard.
3610         * common/environ.h: Rename include guard.
3611         * common/common-utils.h: Rename include guard.
3612         * common/common-types.h: Rename include guard.
3613         * common/common-regcache.h: Rename include guard.
3614         * common/common-inferior.h: Rename include guard.
3615         * common/common-gdbthread.h: Rename include guard.
3616         * common/common-exceptions.h: Rename include guard.
3617         * common/common-defs.h: Rename include guard.
3618         * common/common-debug.h: Rename include guard.
3619         * common/cleanups.h: Rename include guard.
3620         * common/buffer.h: Rename include guard.
3621         * common/btrace-common.h: Rename include guard.
3622         * common/break-common.h: Rename include guard.
3623         * cli/cli-utils.h: Rename include guard.
3624         * cli/cli-style.h: Rename include guard.
3625         * cli/cli-setshow.h: Rename include guard.
3626         * cli/cli-script.h: Rename include guard.
3627         * cli/cli-interp.h: Rename include guard.
3628         * cli/cli-decode.h: Rename include guard.
3629         * cli/cli-cmds.h: Rename include guard.
3630         * charset-list.h: Add include guard.
3631         * buildsym-legacy.h: Rename include guard.
3632         * bfin-tdep.h: Add include guard.
3633         * ax.h: Rename include guard.
3634         * arm-linux-tdep.h: Add include guard.
3635         * arm-fbsd-tdep.h: Add include guard.
3636         * arch/xtensa.h: Rename include guard.
3637         * arch/tic6x.h: Add include guard.
3638         * arch/i386.h: Add include guard.
3639         * arch/arm.h: Rename include guard.
3640         * arch/arm-linux.h: Rename include guard.
3641         * arch/arm-get-next-pcs.h: Rename include guard.
3642         * arch/amd64.h: Add include guard.
3643         * arch/aarch64-insn.h: Rename include guard.
3644         * arch-utils.h: Rename include guard.
3645         * annotate.h: Add include guard.
3646         * amd64-darwin-tdep.h: Rename include guard.
3647         * aarch64-linux-tdep.h: Add include guard.
3648         * aarch64-fbsd-tdep.h: Add include guard.
3649         * aarch32-linux-nat.h: Add include guard.
3650
3651 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3652
3653         * macrotab.c (macro_define_internal): New function that
3654         factorizes macro_define_object_internal and macro_define_function
3655         code.
3656         (macro_define_object_internal): Use macro_define_internal.
3657         (macro_define_function): Likewise.
3658
3659 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3660
3661         * macrocmd.c (extract_identifier): Return
3662         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
3663         callers.
3664
3665 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
3666
3667         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
3668
3669 2019-02-05  Tom Tromey  <tom@tromey.com>
3670
3671         * target.c (target_stack::unpush): Move assertion earlier.
3672
3673 2019-01-30  Tom Tromey  <tom@tromey.com>
3674
3675         PR python/23615:
3676         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
3677         (gdbpy_parse_and_eval): Likewise.
3678         * python/python-internal.h (gdbpy_allow_threads): New class.
3679
3680 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
3681
3682         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
3683         (aarch64_fbsd_fpregmap): Move earlier.
3684         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
3685         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3686         instead of individual calls to trad_frame_set_reg_addr.
3687         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
3688         earlier.
3689         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
3690         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3691         instead of individual calls to trad_frame_set_reg_addr.
3692
3693 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
3694
3695         * CONTRIBUTE: Replace contribution list with wiki link.
3696
3697 2019-01-25  Tom Tromey  <tom@tromey.com>
3698
3699         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
3700
3701 2019-01-25  Tom Tromey  <tom@tromey.com>
3702
3703         * xtensa-linux-nat.c: Fix common/ includes.
3704         * xml-support.h: Fix common/ includes.
3705         * xml-support.c: Fix common/ includes.
3706         * x86-linux-nat.c: Fix common/ includes.
3707         * windows-nat.c: Fix common/ includes.
3708         * varobj.h: Fix common/ includes.
3709         * varobj.c: Fix common/ includes.
3710         * value.c: Fix common/ includes.
3711         * valops.c: Fix common/ includes.
3712         * utils.c: Fix common/ includes.
3713         * unittests/xml-utils-selftests.c: Fix common/ includes.
3714         * unittests/utils-selftests.c: Fix common/ includes.
3715         * unittests/unpack-selftests.c: Fix common/ includes.
3716         * unittests/tracepoint-selftests.c: Fix common/ includes.
3717         * unittests/style-selftests.c: Fix common/ includes.
3718         * unittests/string_view-selftests.c: Fix common/ includes.
3719         * unittests/scoped_restore-selftests.c: Fix common/ includes.
3720         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
3721         * unittests/scoped_fd-selftests.c: Fix common/ includes.
3722         * unittests/rsp-low-selftests.c: Fix common/ includes.
3723         * unittests/parse-connection-spec-selftests.c: Fix common/
3724         includes.
3725         * unittests/optional-selftests.c: Fix common/ includes.
3726         * unittests/offset-type-selftests.c: Fix common/ includes.
3727         * unittests/observable-selftests.c: Fix common/ includes.
3728         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
3729         * unittests/memrange-selftests.c: Fix common/ includes.
3730         * unittests/memory-map-selftests.c: Fix common/ includes.
3731         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
3732         * unittests/function-view-selftests.c: Fix common/ includes.
3733         * unittests/environ-selftests.c: Fix common/ includes.
3734         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
3735         * unittests/common-utils-selftests.c: Fix common/ includes.
3736         * unittests/cli-utils-selftests.c: Fix common/ includes.
3737         * unittests/array-view-selftests.c: Fix common/ includes.
3738         * ui-file.c: Fix common/ includes.
3739         * tui/tui-io.c: Fix common/ includes.
3740         * tracepoint.h: Fix common/ includes.
3741         * tracepoint.c: Fix common/ includes.
3742         * tracefile-tfile.c: Fix common/ includes.
3743         * top.h: Fix common/ includes.
3744         * top.c: Fix common/ includes.
3745         * thread.c: Fix common/ includes.
3746         * target/waitstatus.h: Fix common/ includes.
3747         * target/waitstatus.c: Fix common/ includes.
3748         * target.h: Fix common/ includes.
3749         * target.c: Fix common/ includes.
3750         * target-memory.c: Fix common/ includes.
3751         * target-descriptions.c: Fix common/ includes.
3752         * symtab.h: Fix common/ includes.
3753         * symfile.c: Fix common/ includes.
3754         * stap-probe.c: Fix common/ includes.
3755         * spu-linux-nat.c: Fix common/ includes.
3756         * sparc-nat.c: Fix common/ includes.
3757         * source.c: Fix common/ includes.
3758         * solib.c: Fix common/ includes.
3759         * solib-target.c: Fix common/ includes.
3760         * ser-unix.c: Fix common/ includes.
3761         * ser-tcp.c: Fix common/ includes.
3762         * ser-pipe.c: Fix common/ includes.
3763         * ser-base.c: Fix common/ includes.
3764         * selftest-arch.c: Fix common/ includes.
3765         * s12z-tdep.c: Fix common/ includes.
3766         * rust-exp.y: Fix common/ includes.
3767         * rs6000-aix-tdep.c: Fix common/ includes.
3768         * riscv-tdep.c: Fix common/ includes.
3769         * remote.c: Fix common/ includes.
3770         * remote-notif.h: Fix common/ includes.
3771         * remote-fileio.h: Fix common/ includes.
3772         * remote-fileio.c: Fix common/ includes.
3773         * regcache.h: Fix common/ includes.
3774         * regcache.c: Fix common/ includes.
3775         * record-btrace.c: Fix common/ includes.
3776         * python/python.c: Fix common/ includes.
3777         * python/py-type.c: Fix common/ includes.
3778         * python/py-inferior.c: Fix common/ includes.
3779         * progspace.h: Fix common/ includes.
3780         * producer.c: Fix common/ includes.
3781         * procfs.c: Fix common/ includes.
3782         * proc-api.c: Fix common/ includes.
3783         * printcmd.c: Fix common/ includes.
3784         * ppc-linux-nat.c: Fix common/ includes.
3785         * parser-defs.h: Fix common/ includes.
3786         * osdata.c: Fix common/ includes.
3787         * obsd-nat.c: Fix common/ includes.
3788         * nat/x86-linux.c: Fix common/ includes.
3789         * nat/x86-linux-dregs.c: Fix common/ includes.
3790         * nat/x86-dregs.h: Fix common/ includes.
3791         * nat/x86-dregs.c: Fix common/ includes.
3792         * nat/ppc-linux.c: Fix common/ includes.
3793         * nat/mips-linux-watch.h: Fix common/ includes.
3794         * nat/mips-linux-watch.c: Fix common/ includes.
3795         * nat/linux-waitpid.c: Fix common/ includes.
3796         * nat/linux-ptrace.h: Fix common/ includes.
3797         * nat/linux-ptrace.c: Fix common/ includes.
3798         * nat/linux-procfs.c: Fix common/ includes.
3799         * nat/linux-personality.c: Fix common/ includes.
3800         * nat/linux-osdata.c: Fix common/ includes.
3801         * nat/linux-namespaces.c: Fix common/ includes.
3802         * nat/linux-btrace.h: Fix common/ includes.
3803         * nat/linux-btrace.c: Fix common/ includes.
3804         * nat/fork-inferior.c: Fix common/ includes.
3805         * nat/amd64-linux-siginfo.c: Fix common/ includes.
3806         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
3807         * nat/aarch64-linux.c: Fix common/ includes.
3808         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
3809         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
3810         * namespace.h: Fix common/ includes.
3811         * mips-linux-tdep.c: Fix common/ includes.
3812         * minsyms.c: Fix common/ includes.
3813         * mi/mi-parse.h: Fix common/ includes.
3814         * mi/mi-main.c: Fix common/ includes.
3815         * mi/mi-cmd-env.c: Fix common/ includes.
3816         * memrange.h: Fix common/ includes.
3817         * memattr.c: Fix common/ includes.
3818         * maint.h: Fix common/ includes.
3819         * maint.c: Fix common/ includes.
3820         * main.c: Fix common/ includes.
3821         * machoread.c: Fix common/ includes.
3822         * location.c: Fix common/ includes.
3823         * linux-thread-db.c: Fix common/ includes.
3824         * linux-nat.c: Fix common/ includes.
3825         * linux-fork.c: Fix common/ includes.
3826         * inline-frame.c: Fix common/ includes.
3827         * infrun.c: Fix common/ includes.
3828         * inflow.c: Fix common/ includes.
3829         * inferior.h: Fix common/ includes.
3830         * inferior.c: Fix common/ includes.
3831         * infcmd.c: Fix common/ includes.
3832         * inf-ptrace.c: Fix common/ includes.
3833         * inf-child.c: Fix common/ includes.
3834         * ia64-linux-nat.c: Fix common/ includes.
3835         * i387-tdep.c: Fix common/ includes.
3836         * i386-tdep.c: Fix common/ includes.
3837         * i386-linux-tdep.c: Fix common/ includes.
3838         * i386-linux-nat.c: Fix common/ includes.
3839         * i386-go32-tdep.c: Fix common/ includes.
3840         * i386-fbsd-tdep.c: Fix common/ includes.
3841         * i386-fbsd-nat.c: Fix common/ includes.
3842         * guile/scm-type.c: Fix common/ includes.
3843         * guile/guile.c: Fix common/ includes.
3844         * go32-nat.c: Fix common/ includes.
3845         * gnu-nat.c: Fix common/ includes.
3846         * gdbthread.h: Fix common/ includes.
3847         * gdbarch-selftests.c: Fix common/ includes.
3848         * gdb_usleep.c: Fix common/ includes.
3849         * gdb_select.h: Fix common/ includes.
3850         * gdb_bfd.c: Fix common/ includes.
3851         * gcore.c: Fix common/ includes.
3852         * fork-child.c: Fix common/ includes.
3853         * findvar.c: Fix common/ includes.
3854         * fbsd-nat.c: Fix common/ includes.
3855         * event-top.c: Fix common/ includes.
3856         * event-loop.c: Fix common/ includes.
3857         * dwarf2read.c: Fix common/ includes.
3858         * dwarf2loc.c: Fix common/ includes.
3859         * dwarf2-frame.c: Fix common/ includes.
3860         * dwarf-index-cache.c: Fix common/ includes.
3861         * dtrace-probe.c: Fix common/ includes.
3862         * disasm-selftests.c: Fix common/ includes.
3863         * defs.h: Fix common/ includes.
3864         * csky-tdep.c: Fix common/ includes.
3865         * cp-valprint.c: Fix common/ includes.
3866         * cp-support.h: Fix common/ includes.
3867         * cp-support.c: Fix common/ includes.
3868         * corelow.c: Fix common/ includes.
3869         * completer.h: Fix common/ includes.
3870         * completer.c: Fix common/ includes.
3871         * compile/compile.c: Fix common/ includes.
3872         * compile/compile-loc2c.c: Fix common/ includes.
3873         * compile/compile-cplus-types.c: Fix common/ includes.
3874         * compile/compile-cplus-symbols.c: Fix common/ includes.
3875         * command.h: Fix common/ includes.
3876         * cli/cli-dump.c: Fix common/ includes.
3877         * cli/cli-cmds.c: Fix common/ includes.
3878         * charset.c: Fix common/ includes.
3879         * build-id.c: Fix common/ includes.
3880         * btrace.h: Fix common/ includes.
3881         * btrace.c: Fix common/ includes.
3882         * breakpoint.h: Fix common/ includes.
3883         * breakpoint.c: Fix common/ includes.
3884         * ax.h: 
3885         (enum agent_op): Fix common/ includes.
3886         * ax-general.c (struct aop_map): Fix common/ includes.
3887         * ax-gdb.c: Fix common/ includes.
3888         * auxv.c: Fix common/ includes.
3889         * auto-load.c: Fix common/ includes.
3890         * arm-tdep.c: Fix common/ includes.
3891         * arch/riscv.c: Fix common/ includes.
3892         * arch/ppc-linux-common.c: Fix common/ includes.
3893         * arch/i386.c: Fix common/ includes.
3894         * arch/arm.c: Fix common/ includes.
3895         * arch/arm-linux.c: Fix common/ includes.
3896         * arch/arm-get-next-pcs.c: Fix common/ includes.
3897         * arch/amd64.c: Fix common/ includes.
3898         * arch/aarch64.c: Fix common/ includes.
3899         * arch/aarch64-insn.c: Fix common/ includes.
3900         * arch-utils.c: Fix common/ includes.
3901         * amd64-windows-tdep.c: Fix common/ includes.
3902         * amd64-tdep.c: Fix common/ includes.
3903         * amd64-sol2-tdep.c: Fix common/ includes.
3904         * amd64-obsd-tdep.c: Fix common/ includes.
3905         * amd64-nbsd-tdep.c: Fix common/ includes.
3906         * amd64-linux-tdep.c: Fix common/ includes.
3907         * amd64-linux-nat.c: Fix common/ includes.
3908         * amd64-fbsd-tdep.c: Fix common/ includes.
3909         * amd64-fbsd-nat.c: Fix common/ includes.
3910         * amd64-dicos-tdep.c: Fix common/ includes.
3911         * amd64-darwin-tdep.c: Fix common/ includes.
3912         * agent.c: Fix common/ includes.
3913         * ada-lang.h: Fix common/ includes.
3914         * ada-lang.c: Fix common/ includes.
3915         * aarch64-tdep.c: Fix common/ includes.
3916
3917 2019-01-25  Tom Tromey  <tom@tromey.com>
3918
3919         * common/create-version.sh: Use common/version.h.
3920
3921 2019-01-24  Pedro Alves  <palves@redhat.com>
3922
3923         * infrun.c (signal_stop, signal_print, signal_program)
3924         (signal_catch, signal_pass): Now arrays instead of pointers.
3925         (update_signals_program_target, do_target_resume)
3926         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
3927         * linux-nat.c (linux_nat_target::pass_signals)
3928         (linux_nat_target::create_inferior, linux_nat_target::attach):
3929         Adjust.
3930         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
3931         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
3932         * procfs.c (procfs_target::pass_signals): Adjust.
3933         * record-full.c (record_full_target::resume): Adjust.
3934         * remote.c (remote_target::pass_signals)
3935         (remote_target::program_signals): Adjust.
3936         * target-debug.h (target_debug_print_signals): Now takes a
3937         gdb::array_view as parameter.  Adjust.
3938         * target.h (target_ops) <pass_signals, program_signals>: Replace
3939         pointer and length parameters with gdb::array_view.
3940         (target_pass_signals, target_program_signals): Likewise.
3941         * target-delegates.c: Regenerate.
3942
3943 2019-01-24  Pedro Alves  <palves@redhat.com>
3944
3945         * common/forward-scope-exit.h
3946         (forward_scope_exit::forward_scope_exit): Pass arguments to
3947         m_bind_function directly, instead of creating a std::bind and
3948         copying that.
3949
3950 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
3951
3952         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
3953         for static members.
3954         (pass_in_v_vfp_candidate): Likewise.
3955
3956 2019-01-23  Tom Tromey  <tom@tromey.com>
3957             Pedro Alves  <palves@redhat.com>
3958
3959         * regcache.c (class regcache_invalidator): Remove.
3960         (regcache::raw_write): Use make_scope_exit.
3961
3962 2019-01-23  Tom Tromey  <tom@tromey.com>
3963
3964         * ui-out.h (class ui_out_emit_type): Update comment.
3965
3966 2019-01-23  Tom Tromey  <tom@tromey.com>
3967
3968         * infrun.c (fetch_inferior_event): Update comment.
3969
3970 2019-01-23  Tom Tromey  <tom@tromey.com>
3971             Pedro Alves  <palves@redhat.com>
3972
3973         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
3974         parameter.
3975         (fetch_inferior_event): Use SCOPE_EXIT.
3976
3977
3978 2019-01-23  Tom Tromey  <tom@tromey.com>
3979             Pedro Alves  <palves@redhat.com>
3980
3981         * infrun.c (disable_thread_events): Delete.
3982         (stop_all_threads): Use SCOPE_EXIT.
3983
3984 2019-01-23  Tom Tromey  <tom@tromey.com>
3985             Pedro Alves  <palves@redhat.com>
3986
3987         * symfile.c: Include forward-scope-exit.h.
3988         (clear_symtab_users_cleanup): Replace forward declaration with
3989         a FORWARD_SCOPE_EXIT.
3990         (syms_from_objfile_1): Use the forward_scope_exit and
3991         gdb::optional instead of cleanup_function.
3992         (reread_symbols): Use the forward_scope_exit instead of
3993         cleanup_function.
3994         (clear_symtab_users_cleanup): Remove function.
3995
3996 2019-01-23  Tom Tromey  <tom@tromey.com>
3997             Pedro Alves  <palves@redhat.com>
3998
3999         * linux-nat.c: Include scope-exit.h.
4000         (cleanup_target_stop): Remove.
4001         (linux_nat_target::static_tracepoint_markers_by_strid): Use
4002         SCOPE_EXIT.
4003
4004 2019-01-23  Tom Tromey  <tom@tromey.com>
4005             Pedro Alves  <palves@redhat.com>
4006
4007         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
4008         (call_function_by_hand_dummy): Use SCOPE_EXIT.
4009
4010 2019-01-23  Tom Tromey  <tom@tromey.com>
4011             Andrew Burgess  <andrew.burgess@embecosm.com>
4012             Pedro Alves  <palves@redhat.com>
4013
4014         * infrun.c (fetch_inferior_event): Use scope_exit.
4015         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
4016         * top.c (execute_command): Use scope_exit.
4017         * breakpoint.c (bpstat_do_actions): Use scope_exit.
4018         * utils.c (do_bpstat_clear_actions_cleanup)
4019         (make_bpstat_clear_actions_cleanup): Remove.
4020
4021 2019-01-23  Tom Tromey  <tom@tromey.com>
4022             Pedro Alves  <palves@redhat.com>
4023
4024         * infrun.c: Include "common/scope-exit.h"
4025         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
4026         (wait_for_inferior): Use SCOPE_EXIT.
4027         (fetch_inferior_event): Use scope_exit.
4028
4029 2019-01-23  Tom Tromey  <tom@tromey.com>
4030             Pedro Alves  <palves@redhat.com>
4031
4032         * breakpoint.c (create_breakpoint): Remove cleanup.
4033
4034 2019-01-23  Tom Tromey  <tom@tromey.com>
4035             Andrew Burgess  <andrew.burgess@embecosm.com>
4036             Pedro Alves  <palves@redhat.com>
4037
4038 2019-01-23  Pedro Alves  <palves@redhat.com>
4039
4040         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
4041
4042 2019-01-23  Pedro Alves  <palves@redhat.com>
4043             Andrew Burgess  <andrew.burgess@embecosm.com>
4044
4045         * gdbthread.h: Include "common/forward-scope-exit.h".
4046         (scoped_finish_thread_state): Redefine custom class in terms of
4047         forward_scope_exit.
4048
4049 2019-01-23  Pedro Alves  <palves@redhat.com>
4050             Andrew Burgess  <andrew.burgess@embecosm.com>
4051
4052         * common/forward-scope-exit.h: New file.
4053
4054 2019-01-23  Pedro Alves  <palves@redhat.com>
4055             Andrew Burgess  <andrew.burgess@embecosm.com>
4056             Tom Tromey  <tom@tromey.com>
4057
4058         * common/scope-exit.h: New file.
4059
4060 2019-01-23  Pedro Alves  <palves@redhat.com>
4061
4062         * common/preprocessor.h (ESC): Rename to ...
4063         (ESC_PARENS): ... this.
4064         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
4065         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
4066
4067 2019-01-23  Tom Tromey  <tom@tromey.com>
4068
4069         * language.h (class scoped_switch_to_sym_language_if_auto):
4070         Initialize m_lang in both cases.
4071
4072 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
4073
4074         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
4075         with XCNEW.
4076
4077 2019-01-22  Tom Tromey  <tom@tromey.com>
4078
4079         * corelow.c: Do not include sys/file.h.
4080
4081 2019-01-22  Tom Tromey  <tom@tromey.com>
4082
4083         * tui/tui-wingeneral.h: Include gdb_curses.h.
4084
4085 2019-01-22  Tom Tromey  <tom@tromey.com>
4086
4087         * source-cache.h (class source_cache) <get_source_lines,
4088         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
4089
4090 2019-01-22  Tom Tromey  <tom@tromey.com>
4091
4092         * remote-fileio.h (struct remote_target): Declare.
4093
4094 2019-01-22  Tom Tromey  <tom@tromey.com>
4095
4096         * python/py-arch.c: Do not include py-ref.h.
4097         * python/py-bpevent.c: Do not include py-ref.h.
4098         * python/py-cmd.c: Do not include py-ref.h.
4099         * python/py-continueevent.c: Do not include py-ref.h.
4100         * python/py-event.h: Do not include py-ref.h.
4101         * python/py-evtregistry.c: Do not include py-ref.h.
4102         * python/py-finishbreakpoint.c: Do not include py-ref.h.
4103         * python/py-frame.c: Do not include py-ref.h.
4104         * python/py-framefilter.c: Do not include py-ref.h.
4105         * python/py-function.c: Do not include py-ref.h.
4106         * python/py-infevents.c: Do not include py-ref.h.
4107         * python/py-linetable.c: Do not include py-ref.h.
4108         * python/py-objfile.c: Do not include py-ref.h.
4109         * python/py-param.c: Do not include py-ref.h.
4110         * python/py-prettyprint.c: Do not include py-ref.h.
4111         * python/py-progspace.c: Do not include py-ref.h.
4112         * python/py-symbol.c: Do not include py-ref.h.
4113         * python/py-symtab.c: Do not include py-ref.h.
4114         * python/py-type.c: Do not include py-ref.h.
4115         * python/py-unwind.c: Do not include py-ref.h.
4116         * python/py-utils.c: Do not include py-ref.h.
4117         * python/py-value.c: Do not include py-ref.h.
4118         * python/py-varobj.c: Do not include py-ref.h.
4119         * python/py-xmethods.c: Do not include py-ref.h.
4120         * python/python.c: Do not include py-ref.h.
4121         * varobj.c: Do not include py-ref.h.
4122
4123 2019-01-22  Tom Tromey  <tom@tromey.com>
4124
4125         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
4126         keyword for bcache.
4127
4128 2019-01-22  Tom Tromey  <tom@tromey.com>
4129
4130         * compile/compile-cplus-types.c: Remove a comment by #include.
4131
4132 2019-01-22  Tom Tromey  <tom@tromey.com>
4133
4134         * compile/gcc-c-plugin.h: Include compile-internal.h.
4135
4136 2019-01-22  Tom Tromey  <tom@tromey.com>
4137
4138         * stabsread.c (EXTERN): Do not define.
4139         (symnum, next_symbol_text_func, processing_gcc_compilation)
4140         (within_function, global_sym_chain, global_stabs)
4141         (previous_stab_code, this_object_header_files)
4142         (n_this_object_header_files)
4143         (n_allocated_this_object_header_files): Define.
4144         * stabsread.h (EXTERN): Never define.  Use "extern".
4145
4146 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4147
4148         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
4149         history_value.
4150
4151 2019-01-21  Tom Tromey  <tom@tromey.com>
4152
4153         * ui-out.c: Fix includes.
4154         * tui/tui-source.c: Fix includes.
4155         * target.c: Fix includes.
4156         * remote.c: Fix includes.
4157         * regcache.c: Fix includes.
4158         * python/py-block.c: Fix includes.
4159         * printcmd.c: Fix includes.
4160         * or1k-tdep.c: Fix includes.
4161         * mi/mi-main.c: Fix includes.
4162         * m32r-tdep.c: Fix includes.
4163         * csky-tdep.c: Fix includes.
4164         * compile/compile-cplus-types.c: Fix includes.
4165         * cli/cli-interp.c: Fix includes.
4166
4167 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
4168
4169         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4170         for padding.
4171
4172 2019-01-16  Tom Tromey  <tom@tromey.com>
4173
4174         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
4175         earlier.
4176         (struct objfile) <msymbols_range>: Move from top level.
4177         <msymbols>: New method.
4178         (class objfile_msymbols): Remove.
4179         * symtab.c (default_collect_symbol_completion_matches_break_on):
4180         Update.
4181         * symmisc.c (dump_msymbols): Update.
4182         * stabsread.c (scan_file_globals): Update.
4183         * objc-lang.c (info_selectors_command, info_classes_command)
4184         (find_methods): Update.
4185         * minsyms.c (find_solib_trampoline_target): Update.
4186         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
4187         * coffread.c (coff_symfile_read): Update.
4188         * ada-lang.c (ada_lookup_simple_minsym)
4189         (ada_collect_symbol_completion_matches): Update.
4190
4191 2019-01-16  Tom Tromey  <tom@tromey.com>
4192
4193         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
4194         type.  Remove no-argument constructor.
4195         <iterator::operator++>: Simplify.
4196         <begin>: Update.
4197         <end>: Use minimal_symbol_count.
4198
4199 2019-01-16  Tom Tromey  <tom@tromey.com>
4200
4201         * objfiles.h (struct objfile) <psymtabs>: New method.
4202         (class objfile_psymtabs): Remove.
4203         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
4204         typedef.
4205         <range>: New method.
4206         (require_partial_symbols): Change return type.
4207         * psymtab.c (require_partial_symbols)
4208         (psym_expand_symtabs_matching): Update.
4209         * mdebugread.c (parse_partial_symbols): Update.
4210         * dbxread.c (dbx_end_psymtab): Update.
4211
4212 2019-01-15  Tom Tromey  <tom@tromey.com>
4213
4214         * symtab.c (lookup_objfile_from_block)
4215         (lookup_symbol_in_objfile_symtabs)
4216         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
4217         (find_line_symtab, info_sources_command)
4218         (default_collect_symbol_completion_matches_break_on)
4219         (make_source_files_completion_list): Update.
4220         * symmisc.c (print_objfile_statistics, dump_objfile)
4221         (maintenance_print_symbols, maintenance_info_symtabs)
4222         (maintenance_check_symtabs, maintenance_info_line_tables):
4223         Update.
4224         * source.c (select_source_symtab)
4225         (forget_cached_source_info_for_objfile): Update.
4226         * objfiles.h (class objfile_compunits): Remove.
4227         (struct objfile) <compunits_range>: New typedef.
4228         (compunits): New method.
4229         * objfiles.c (objfile_relocate1): Update.
4230         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4231         * maint.c (count_symtabs_and_blocks): Update.
4232         * linespec.c (iterate_over_all_matching_symtabs): Update.
4233         * cp-support.c (add_symbol_overload_list_qualified): Update.
4234         * coffread.c (coff_symtab_read): Update.
4235         * ada-lang.c (add_nonlocal_symbols)
4236         (ada_collect_symbol_completion_matches)
4237         (ada_add_global_exceptions): Update.
4238
4239 2019-01-15  Tom Tromey  <tom@tromey.com>
4240
4241         * progspace.h (program_space) <objfiles_safe_range>: New
4242         typedef.
4243         <objfiles_safe>: New method.
4244         * objfiles.h (class all_objfiles_safe): Remove.
4245         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
4246         * jit.c (jit_inferior_exit_hook): Update.
4247
4248 2019-01-17  Tom Tromey  <tom@tromey.com>
4249
4250         * progspace.h (program_space) <objfiles_range>: New typedef.
4251         <objfiles>: New method.
4252         <objfiles_head>: Rename from objfiles.
4253         (object_files): Update.
4254         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
4255         * guile/scm-pretty-print.c
4256         (ppscm_find_pretty_printer_from_objfiles): Update.
4257         * guile/scm-objfile.c (gdbscm_objfiles): Update.
4258         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
4259         Update.
4260         * python/py-progspace.c (pspy_get_objfiles): Update.
4261         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
4262         Update.
4263         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
4264         (objfpy_lookup_objfile_by_build_id): Update.
4265         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4266         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
4267         Update.
4268         * symtab.c (iterate_over_symtabs, matching_obj_sections)
4269         (expand_symtab_containing_pc, lookup_objfile_from_block)
4270         (lookup_static_symbol, basic_lookup_transparent_type)
4271         (find_pc_sect_compunit_symtab, find_symbol_at_address)
4272         (find_line_symtab, info_sources_command)
4273         (default_collect_symbol_completion_matches_break_on)
4274         (make_source_files_completion_list, find_main_name): Update.
4275         * symmisc.c (print_symbol_bcache_statistics)
4276         (print_objfile_statistics, maintenance_print_symbols)
4277         (maintenance_print_msymbols, maintenance_print_objfiles)
4278         (maintenance_info_symtabs, maintenance_check_symtabs)
4279         (maintenance_expand_symtabs, maintenance_info_line_tables):
4280         Update.
4281         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
4282         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
4283         (map_overlay_command, unmap_overlay_command)
4284         (simple_overlay_update, expand_symtabs_matching)
4285         (map_symbol_filenames): Update.
4286         * symfile-debug.c (set_debug_symfile): Update.
4287         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
4288         Update.
4289         * source.c (select_source_symtab, forget_cached_source_info):
4290         Update.
4291         * solib.c (solib_read_symbols): Update.
4292         * solib-spu.c (append_ocl_sos): Update.
4293         * psymtab.c (maintenance_print_psymbols)
4294         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
4295         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
4296         * printcmd.c (info_symbol_command): Update.
4297         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
4298         Update.
4299         * objfiles.h (class all_objfiles): Remove.
4300         * objfiles.c (have_partial_symbols, have_full_symbols)
4301         (have_minimal_symbols, qsort_cmp, update_section_map)
4302         (shared_objfile_contains_address_p)
4303         (default_iterate_over_objfiles_in_search_order): Update.
4304         * objc-lang.c (info_selectors_command, info_classes_command)
4305         (find_methods): Update.
4306         * minsyms.c (find_solib_trampoline_target): Update.
4307         * maint.c (maintenance_info_sections)
4308         (maintenance_translate_address, count_symtabs_and_blocks):
4309         Update.
4310         * main.c (captured_main_1): Update.
4311         * linux-thread-db.c (try_thread_db_load_from_pdir)
4312         (has_libpthread): Update.
4313         * linespec.c (iterate_over_all_matching_symtabs)
4314         (search_minsyms_for_name): Update.
4315         * jit.c (jit_find_objf_with_entry_addr): Update.
4316         * hppa-tdep.c (find_unwind_entry)
4317         (hppa_lookup_stub_minimal_symbol): Update.
4318         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
4319         Update.
4320         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
4321         (elf_gnu_ifunc_resolve_by_got): Update.
4322         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
4323         * dwarf-index-write.c (save_gdb_index_command): Update.
4324         * cp-support.c (add_symbol_overload_list_qualified): Update.
4325         * breakpoint.c (create_overlay_event_breakpoint)
4326         (create_longjmp_master_breakpoint)
4327         (create_std_terminate_master_breakpoint)
4328         (create_exception_master_breakpoint): Update.
4329         * blockframe.c (find_pc_partial_function): Update.
4330         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
4331         (ada_collect_symbol_completion_matches)
4332         (ada_add_global_exceptions): Update.
4333
4334 2019-01-17  Tom Tromey  <tom@tromey.com>
4335
4336         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
4337         declare VEC.
4338         (solib_target_parse_libraries): Change return type.
4339         (library_list_start_segment, library_list_start_section)
4340         (library_list_end_library, library_list_start_library); Update.
4341         (solib_target_free_library_list): Remove.
4342         (solib_target_parse_libraries): Remove cleanup.  Change return
4343         type.
4344         (solib_target_current_sos): Update.
4345
4346 2019-01-17  Tom Tromey  <tromey@bapiya>
4347
4348         * valprint.c: Replace "the the" with "the".
4349         * symtab.c: Replace "the the" with "the".
4350         * solib.c: Replace "the the" with "the".
4351         * solib-dsbt.c: Replace "the the" with "the".
4352         * linespec.c: Replace "the the" with "the".
4353         * dwarf2loc.h: Replace "the the" with "the".
4354         * amd64-windows-tdep.c: Replace "the the" with "the".
4355         * aarch64-tdep.c: Replace "the the" with "the".
4356
4357 2019-01-16  Keith Seitz  <keiths@redhat.com>
4358
4359         PR gdb/23773
4360         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
4361         <builder>: Rename to ..
4362         <m_builder>: ... this and make private.
4363         (dwarf2_cu::get_builder): New method.  Change all users of
4364         `builder' to use this method.
4365         (dwarf2_start_symtab): Move to ...
4366         (dwarf2_cu::start_symtab): ... here.  Update all callers
4367         (setup_type_unit_groups): Move to ...
4368         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
4369         callers.
4370         (dwarf2_cu::reset_builder): New method.
4371         (process_full_compunit, process_full_type_unit): Use
4372         dwarf2_cu::reset_builder.
4373         (follow_die_offset): Record the ancestor CU if it is different
4374         from the followed DIE's CU.
4375         (follow_die_sig_1): Likewise.
4376
4377 2019-01-15  Tom Tromey  <tom@tromey.com>
4378
4379         * remote.c (class remote_state) <buf>: Now a char_vector.
4380         <buf_size>: Remove.
4381         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
4382         parameter.
4383         (remote_target::getpkt_or_notif_sane_1)
4384         (remote_target::getpkt_sane)
4385         (remote_target::getpkt_or_notif_sane): Likewise.
4386         (class remote_target) <putpkt>: New overload.
4387         (remote_target::read_frame): Change type of "buf_p".  Remove
4388         sizeof_p parameter.
4389         (packet_ok): New overload.
4390         (packet_check_result): New overload.
4391         Update all uses.
4392
4393 2019-01-14  Tom Tromey  <tom@tromey.com>
4394
4395         * remote-notif.c (handle_notification, remote_notif_ack)
4396         (remote_notif_parse): Make "buf" const.
4397         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
4398         const.
4399         (remote_notif_parse, remote_notif_ack, handle_notification):
4400         Likewise.
4401         * remote.c (remote_notif_stop_parse): Make "buf" const.
4402         (remote_target::remote_parse_stop_reply): Make "buf" const.
4403         (remote_notif_stop_ack): Make "buf" const.
4404
4405 2019-01-14  Tom Tromey  <tom@tromey.com>
4406
4407         * remote.c (remote_console_output): Make parameter const.
4408
4409 2019-01-14  Tom Tromey  <tom@tromey.com>
4410
4411         * target-debug.h (target_debug_print_signals): Constify.
4412         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
4413         * procfs.c (procfs_target::pass_signals): Update.
4414         * linux-nat.c (linux_nat_target::pass_signals): Update.
4415         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
4416         * target-delegates.c: Rebuild.
4417         * remote.c (remote_target::program_signals): Update.
4418         (remote_target::pass_signals): Update.
4419         * target.c (target_pass_signals): Constify argument.
4420         (target_program_signals): Likewise.
4421         * target.h (struct target_ops) <pass_signals, program_signals>:
4422         Constify argument.
4423         (target_pass_signals, target_program_signals): Constify argument.
4424
4425 2019-01-14  Tom Tromey  <tom@tromey.com>
4426
4427         PR tui/28819:
4428         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
4429
4430 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
4431
4432         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
4433         field.
4434         * rs6000-tdep.c: Include reggroups.h.
4435         (IS_V_ALIAS_PSEUDOREG): Define.
4436         (rs6000_register_name): Return names for the "vX" aliases.
4437         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
4438         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
4439         aliases.  Call default_register_reggroup_p for all other
4440         pseudo-registers.
4441         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
4442         New functions.
4443         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
4444         Handle "vX" aliases.
4445         (v_alias_pseudo_register_collect): New function.
4446         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
4447         (rs6000_gdbarch_init): Initialize "vX" aliases as
4448         pseudo-registers.  Restore registration of
4449         rs6000_pseudo_register_reggroup_p with
4450         set_tdesc_pseudo_register_reggroup_p.
4451
4452 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
4453
4454         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
4455         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
4456         set_gdbarch_num_pseudo_regs.
4457
4458 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4459
4460         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
4461         Remove arg prefixname, add do_set and do_show.
4462         Add member functions set_list and show_list.
4463         * cli/cli-style.c (class cli_style_option): Update accordingly.
4464         (style_set_list): Move to file scope.
4465         (style_show_list): Likewise.
4466         (set_style): Call help_list.
4467         (show_style): Call cmd_show_list.
4468         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
4469         Update to use the new macro.
4470
4471 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
4472
4473         * ada-lang.c (_initialize_ada_language): Expand the help text
4474         for the "catch exception" command.
4475
4476 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4477
4478         * symtab.c (matching_obj_sections): Initialize obj,
4479         declare it closer to its usage.
4480
4481 2019-01-10  Tom Tromey  <tom@tromey.com>
4482
4483         * thread-iter.h (inf_threads_iterator): Use next_iterator.
4484         (basic_inf_threads_range): Remove.
4485         (inf_threads_range, inf_non_exited_threads_range)
4486         (safe_inf_threads_range): Use next_adapter.
4487
4488 2019-01-10  Keith Seitz  <keiths@redhat.com>
4489
4490         PR gdb/23712
4491         PR symtab/23010
4492         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
4493         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
4494
4495 2019-01-10  Keith Seitz  <keiths@redhat.com>
4496
4497         PR gdb/23712
4498         PR symtab/23010
4499         * dictionary.c (pending_to_vector): Remove.
4500         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4501         Remove _1 suffix, replacing functions of the same name.  Update
4502         all callers.
4503         (dict_create_hashed, dict_create_hashed_expandable)
4504         (dict_create_linear, dict_create_linear_expandable, dict_free)
4505         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
4506         Make functions static.
4507
4508 2019-01-10  Keith Seitz  <keiths@redhat.com>
4509
4510         PR gdb/23712
4511         PR symtab/23010
4512         * dictionary.h (struct dictionary): Replace declaration with
4513         multidictionary.
4514         (dict_create_hashed, dict_create_hashed_expandable)
4515         (dict_create_linear, dict_create_linear_expandable)
4516         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
4517         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
4518         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
4519         taking multidictionary argument.
4520         [ALL_DICT_SYMBOLS]: Update for multidictionary.
4521         * block.h (struct block) <dict>: Change to multidictionary
4522         and rename `multidict'.
4523         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
4524         symmisc.c: Update all dictionary references to multidictionary.
4525
4526 2019-01-10  Keith Seitz  <keiths@redhat.com>
4527
4528         PR gdb/23712
4529         PR symtab/23010
4530         * dictionary.c: Include unordered_map.
4531         (pending_to_vector): New function.
4532         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4533         Rewrite the non-"_1" functions to take vector instead
4534         of linked list.
4535         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
4536         "new" _1 versions of the same name.
4537         (multidictionary): Define.
4538         (std::hash<enum language): New definition.
4539         (collate_pending_symbols_by_language, mdict_create_hashed)
4540         (mdict_create_hashed_expandable, mdict_create_linear)
4541         (mdict_create_linear_expandable, mdict_free)
4542         (find_language_dictionary, create_new_language_dictionary)
4543         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
4544         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
4545         (mdict_size, mdict_empty): New functions.
4546         * dictionary.h (mdict_iterator): Define.
4547
4548 2019-01-10  Pedro Alves  <palves@redhat.com>
4549
4550         * breakpoint.c (read_uploaded_action)
4551         (create_tracepoint_from_upload): Adjust to use
4552         gdb::unique_xmalloc_ptr.
4553         * ctf.c (ctf_write_uploaded_tp):
4554         (SET_ARRAY_FIELD): Use emplace_back.
4555         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
4556         * tracefile-tfile.c (tfile_write_uploaded_tp):
4557         * tracepoint.c (parse_tracepoint_definition): Adjust to use
4558         gdb::unique_xmalloc_ptr.
4559         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
4560         at_string, cond_string, cmd_strings>: Replace char pointers
4561         with gdb::unique_xmalloc_ptr.
4562
4563 2019-01-10  Pedro Alves  <palves@redhat.com>
4564
4565         * solib-target.c (library_list_start_library): Don't xstrdup name.
4566
4567 2019-01-10  Pedro Alves  <palves@redhat.com>
4568
4569         * mdebugread.c (parse_partial_symbols): Use
4570         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
4571
4572 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4573
4574         * linux-fork.c (scoped_switch_fork_info)
4575         <~scoped_switch_fork_info>: Fix incorrect variable name.
4576
4577 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4578
4579         * linux-fork.c (scoped_switch_fork_info)
4580         <scoped_switch_fork_info>: Make explicit.
4581         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
4582
4583 2019-01-10  Tom Tromey  <tom@tromey.com>
4584
4585         * objfiles.h (objfile::reset_psymtabs): Update.
4586         * objfiles.c (objfile::objfile): Update.
4587         * psymtab.h (psymtab_storage::obstack): Update.
4588         (psymtab_storage::m_obstack): Use gdb::optional.
4589         (class psymtab_storage): Update comment.  Remove objfile
4590         parameter.
4591         * psymtab.c (psymtab_storage::psymtab_storage): Update.
4592
4593 2019-01-10  Tom Tromey  <tom@tromey.com>
4594
4595         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
4596         <free_psymtabs>: Now private.
4597         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
4598         (allocate_psymtab): Use new method.
4599
4600 2019-01-10  Tom Tromey  <tom@tromey.com>
4601
4602         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
4603         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
4604         * mdebugread.c (parse_partial_symbols): Use
4605         allocate_dependencies.
4606         * dwarf2read.c (dwarf2_create_include_psymtab): Use
4607         allocate_dependencies.
4608         (process_psymtab_comp_unit_reader)
4609         (build_type_psymtab_dependencies): Likewise.
4610         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
4611
4612 2019-01-10  Tom Tromey  <tom@tromey.com>
4613
4614         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
4615         PSYMBOL_SET_LANGUAGE.
4616         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
4617
4618 2019-01-10  Tom Tromey  <tom@tromey.com>
4619
4620         * psymtab.h (psymtab_storage::obstack): New method.
4621         <m_obstack>: Rename from obstack; now private.
4622         * psymtab.c (psymtab_storage): Update.
4623         * dwarf2read.c (create_addrmap_from_index)
4624         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
4625         Update.
4626
4627 2019-01-10  Tom Tromey  <tom@tromey.com>
4628
4629         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
4630         * objfiles.h (objfile::reset_psymtabs): New method.
4631
4632 2019-01-10  Tom Tromey  <tom@tromey.com>
4633
4634         * symmisc.c (print_symbol_bcache_statistics): Update.
4635         (print_objfile_statistics): Update.
4636         * symfile.c (reread_symbols): Update.
4637         * psymtab.h (class psymtab_storage): New.
4638         * psymtab.c (psymtab_storage): New constructor.
4639         (~psymtab_storage): New destructor.
4640         (require_partial_symbols): Update.
4641         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
4642         (find_pc_sect_psymtab, find_pc_sect_psymbol)
4643         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
4644         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
4645         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
4646         (start_psymtab_common, end_psymtab_common)
4647         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
4648         (allocate_psymtab): Update.
4649         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
4650         Update.
4651         (dump_psymtab_addrmap, maintenance_print_psymbols)
4652         (maintenance_check_psymtabs): Update.
4653         (class objfile_psymtabs): Move to objfiles.h.
4654         * psympriv.h (discard_psymtab): Now inline.
4655         (psymtab_discarder::psymtab_discarder): Update.
4656         (psymtab_discarder::~psymtab_discarder): Update.
4657         (ALL_OBJFILE_PSYMTABS): Rewrite.
4658         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
4659         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
4660         Remove fields.
4661         <partial_symtabs>: New field.
4662         (class objfile_psymtabs): Move from psymtab.h.  Update.
4663         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
4664         psymbol_cache.
4665         (objfile::~objfile): Don't destroy psymbol_cache.
4666         * mdebugread.c (parse_partial_symbols): Update.
4667         * dwarf2read.c (create_addrmap_from_index)
4668         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
4669         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
4670         (add_partial_subprogram, dwarf2_ranges_read): Update.
4671         * dwarf-index-write.c (write_address_map)
4672         (write_one_signatured_type, recursively_write_psymbols)
4673         (class debug_names, class debug_names, write_psymtabs_to_index):
4674         Update.
4675
4676 2019-01-10  Tom Tromey  <tom@tromey.com>
4677
4678         * symtab.h (SYMBOL_SET_NAMES): Update.
4679         (symbol_set_names): Update.
4680         (MSYMBOL_SET_NAMES): Update.
4681         * symtab.c (symbol_set_names): Change argument to be an
4682         objfile_per_bfd_storage.
4683         * psymtab.c (add_psymbol_to_bcache): Update.
4684         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
4685
4686 2019-01-10  Tom Tromey  <tom@tromey.com>
4687
4688         * symtab.c (create_demangled_names_hash): Change argument to be an
4689         objfile_per_bfd_storage.
4690         (symbol_set_names): Update.
4691
4692 2019-01-10  Tom Tromey  <tom@tromey.com>
4693
4694         * xcoffread.c (xcoff_initial_scan): Unconditionally call
4695         init_psymbol_list.
4696         * psymtab.c (init_psymbol_list): Do nothing if already called.
4697         * psympriv.h (init_psymbol_list): Add comment.
4698         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
4699         init_psymbol_list.
4700         * dbxread.c (dbx_symfile_read): Unconditionally call
4701         init_psymbol_list.
4702
4703 2019-01-10  Tom Tromey  <tom@tromey.com>
4704
4705         * xcoffread.c (scan_xcoff_symtab): Update.
4706         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
4707         "where".
4708         * mdebugread.c (parse_partial_symbols)
4709         (handle_psymbol_enumerators): Update.
4710         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
4711         * dbxread.c (read_dbx_symtab): Update.
4712         * psympriv.h (psymbol_placement): New enum.
4713         (add_psymbol_to_list): Update.
4714
4715 2019-01-10  Tom Tromey  <tom@tromey.com>
4716
4717         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
4718         static_psymbols parameters.
4719         (scan_xcoff_symtab): Update.
4720         * psymtab.c (start_psymtab_common): Remove global_psymbols and
4721         static_psymbols parameters.
4722         * psympriv.h (start_psymtab_common): Update.
4723         * mdebugread.c (parse_partial_symbols): Update.
4724         * dwarf2read.c (create_partial_symtab): Update.
4725         * dbxread.c (read_dbx_symtab): Update.
4726         (start_psymtab): Remove global_psymbols and static_psymbols
4727         parameters.
4728
4729 2019-01-10  Tom Tromey  <tom@tromey.com>
4730
4731         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
4732         * psymtab.c (allocate_psymtab): Add comment.
4733         * psympriv.h (allocate_psymtab): Add comment.
4734         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
4735         initializations.
4736         * dbxread.c (dbx_end_psymtab): Remove some initializations.
4737
4738 2019-01-10  Tom Tromey  <tom@tromey.com>
4739
4740         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
4741         Don't declare.
4742         * mipsread.c: Include mdebugread.h.
4743         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
4744         Declare.
4745         * elfread.c: Include mdebugread.h.
4746
4747 2019-01-09  Tom Tromey  <tom@tromey.com>
4748
4749         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
4750         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
4751         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
4752         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
4753         (psym_lookup_symbol, psym_find_last_source_symtab)
4754         (psym_forget_cached_source_info, psym_print_stats)
4755         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
4756         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
4757         (psym_map_matching_symbols, psym_expand_symtabs_matching)
4758         (psym_find_compunit_symtab_by_address)
4759         (maintenance_print_psymbols, maintenance_info_psymtabs)
4760         (maintenance_check_psymtabs): Use ranged for.
4761         * psymtab.h (class objfile_psymtabs): New.
4762         (require_partial_symbols): Return objfile_psymtabs.
4763         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
4764
4765 2019-01-09  Tom Tromey  <tom@tromey.com>
4766
4767         * symfile.c (overlay_invalidate_all, find_pc_overlay)
4768         (find_pc_mapped_section, list_overlays_command)
4769         (map_overlay_command, unmap_overlay_command)
4770         (simple_overlay_update): Use all_objfiles.
4771         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
4772         * printcmd.c (info_symbol_command): Use all_objfiles.
4773         * objfiles.h (ALL_OBJSECTIONS): Remove.
4774         * maint.c (maintenance_translate_address): Use all_objfiles.
4775         * gcore.c (gcore_create_callback): Use all_objfiles.
4776         (objfile_find_memory_regions): Likewise.
4777
4778 2019-01-09  Tom Tromey  <tom@tromey.com>
4779
4780         * symtab.c (find_line_symtab, info_sources_command)
4781         (make_source_files_completion_list): Use objfile_compunits.
4782         * source.c (select_source_symtab): Use objfile_compunits.
4783         * objfiles.h (struct objfile): Update comment.
4784         (ALL_OBJFILES): Remove.
4785         (ALL_FILETABS): Remove.
4786         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
4787         objfile_compunits.
4788
4789 2019-01-09  Tom Tromey  <tom@tromey.com>
4790
4791         * symmisc.c (print_objfile_statistics, dump_objfile)
4792         (maintenance_print_symbols): Use compunit_filetabs.
4793         * source.c (forget_cached_source_info_for_objfile): Use
4794         compunit_filetabs.
4795         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
4796         (ALL_FILETABS): Use compunit_filetabs.
4797         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
4798         * coffread.c (coff_symtab_read): Use compunit_filetabs.
4799
4800 2019-01-09  Tom Tromey  <tom@tromey.com>
4801
4802         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
4803         (compunit_filetabs): New.
4804         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
4805         compunit_filetabs.
4806         (info_sources_command, make_source_files_completion_list): Remove
4807         declaration.
4808         * symmisc.c (print_objfile_statistics, dump_objfile)
4809         (maintenance_print_symbols): Remove declaration.
4810         (maintenance_info_symtabs): Use compunit_filetabs.
4811         (maintenance_info_line_tables): Likewise.
4812         * source.c (select_source_symtab): Change local variable name.
4813         (forget_cached_source_info_for_objfile): Remove declaration.
4814         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
4815         * objfiles.c (objfile_relocate1): Remove declaration.
4816         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
4817         declaration.
4818         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
4819         * coffread.c (coff_symtab_read): Remove declaration.
4820         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
4821         compunit_filetabs.
4822
4823 2019-01-09  Tom Tromey  <tom@tromey.com>
4824
4825         * symtab.c (lookup_objfile_from_block)
4826         (find_pc_sect_compunit_symtab, search_symbols)
4827         (default_collect_symbol_completion_matches_break_on): Use
4828         objfile_compunits.
4829         * objfiles.h (ALL_COMPUNITS): Remove.
4830         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
4831         * cp-support.c (add_symbol_overload_list_qualified): Use
4832         objfile_compunits.
4833         * ada-lang.c (ada_collect_symbol_completion_matches)
4834         (ada_add_global_exceptions): Use objfile_compunits.
4835
4836 2019-01-09  Tom Tromey  <tom@tromey.com>
4837
4838         * source.c (select_source_symtab)
4839         (forget_cached_source_info_for_objfile): Remove declaration.
4840         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
4841         declaration.
4842         * maint.c (count_symtabs_and_blocks): Remove declaration.
4843         * cp-support.c (add_symbol_overload_list_qualified): Remove
4844         declaration.
4845         * coffread.c (coff_symtab_read): Remove declaration.
4846         * symtab.c (lookup_symbol_in_objfile_symtabs)
4847         (basic_lookup_transparent_type_1): Use objfile_compunits.
4848         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
4849         (info_sources_command, search_symbols)
4850         (default_collect_symbol_completion_matches_break_on)
4851         (make_source_files_completion_list): Remove declaration.
4852         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
4853         (ada_collect_symbol_completion_matches)
4854         (ada_add_global_exceptions): Remove declaration.
4855         * linespec.c (iterate_over_all_matching_symtabs): Use
4856         objfile_compunits.
4857         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
4858         (class objfile_compunits): New.
4859         (ALL_COMPUNITS): Use objfile_compunits.
4860         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
4861         (maintenance_check_symtabs, maintenance_info_line_tables): Use
4862         objfile_compunits.
4863         * objfiles.c (objfile_relocate1): Use objfile_compunits.
4864
4865 2019-01-09  Tom Tromey  <tom@tromey.com>
4866
4867         * symtab.c (search_symbols)
4868         (default_collect_symbol_completion_matches_break_on): Use
4869         objfile_msymbols.
4870         * ada-lang.c (ada_lookup_simple_minsym)
4871         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
4872         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
4873         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
4874         objfile_msymbols.
4875         * coffread.c (coff_symfile_read): Use objfile_msymbols.
4876         * symmisc.c (dump_msymbols): Use objfile_msymbols.
4877         * objc-lang.c (find_methods): Use objfile_msymbols.
4878         (info_selectors_command, info_classes_command): Likewise.
4879         * stabsread.c (scan_file_globals): Use objfile_msymbols.
4880         * objfiles.h (class objfile_msymbols): New.
4881         (ALL_OBJFILE_MSYMBOLS): Remove.
4882         (ALL_MSYMBOLS): Remove.
4883
4884 2019-01-09  Tom Tromey  <tom@tromey.com>
4885
4886         * common/next-iterator.h (next_adapter): Add Iterator template
4887         parameter.
4888         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
4889         (class all_objfiles_safe): New.
4890         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
4891         * objfiles.c (put_objfile_before): Update comment.
4892         (add_separate_debug_objfile): Likewise.
4893         (free_all_objfiles): Use all_objfiles_safe.
4894         (objfile_purge_solibs): Likewise.
4895
4896 2019-01-09  Tom Tromey  <tom@tromey.com>
4897
4898         * symtab.c (iterate_over_symtabs, matching_obj_sections)
4899         (expand_symtab_containing_pc, lookup_static_symbol)
4900         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
4901         (find_symbol_at_address, find_line_symtab, find_main_name): Use
4902         all_objfiles.
4903         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
4904         * breakpoint.c (create_overlay_event_breakpoint)
4905         (create_longjmp_master_breakpoint)
4906         (create_std_terminate_master_breakpoint)
4907         (create_exception_master_breakpoint): Use all_objfiles.
4908         * linux-thread-db.c (try_thread_db_load_from_pdir)
4909         (has_libpthread): Use all_objfiles.
4910         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
4911         * linespec.c (iterate_over_all_matching_symtabs)
4912         (search_minsyms_for_name): Use all_objfiles.
4913         * maint.c (maintenance_info_sections): Use all_objfiles.
4914         * main.c (captured_main_1): Use all_objfiles.
4915         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
4916         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
4917         * guile/scm-pretty-print.c
4918         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
4919         * solib-spu.c (append_ocl_sos): Use all_objfiles.
4920         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
4921         (maintenance_print_msymbols): Use all_objfiles.
4922         * source.c (select_source_symtab): Use all_objfiles.
4923         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
4924         * symfile.c (remove_symbol_file_command)
4925         (expand_symtabs_matching, map_symbol_filenames): Use
4926         all_objfiles.
4927         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
4928         all_objfiles.
4929         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
4930         * objc-lang.c (find_methods): Use all_objfiles.
4931         * objfiles.c (have_partial_symbols, have_full_symbols)
4932         (have_minimal_symbols, qsort_cmp)
4933         (default_iterate_over_objfiles_in_search_order): Use
4934         all_objfiles.
4935         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
4936         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
4937         (maintenance_check_psymtabs): Use all_objfiles.
4938         (ALL_PSYMTABS): Remove.
4939         * compile/compile-object-run.c (do_module_cleanup): Use
4940         all_objfiles.
4941         * blockframe.c (find_pc_partial_function): Use all_objfiles.
4942         * cp-support.c (add_symbol_overload_list_qualified): Use
4943         all_objfiles.
4944         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
4945         Use all_objfiles.
4946         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
4947         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
4948         all_objfiles.
4949         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
4950         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
4951         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
4952         Uses all_objfiles.
4953         * solib.c (solib_read_symbols): Use all_objfiles
4954
4955 2019-01-09  Tom Tromey  <tom@tromey.com>
4956
4957         * probe.c (parse_probes_in_pspace): Use all_objfiles.
4958         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
4959         all_objfiles.
4960         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
4961         * symmisc.c (print_symbol_bcache_statistics)
4962         (print_objfile_statistics, maintenance_print_objfiles)
4963         (maintenance_info_symtabs, maintenance_check_symtabs)
4964         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
4965         all_objfiles.
4966         * source.c (forget_cached_source_info): Use all_objfiles.
4967         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
4968         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
4969         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
4970         * objfiles.c (update_section_map): Use all_objfiles.
4971         (shared_objfile_contains_address_p): Likewise.
4972         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
4973         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
4974
4975 2019-01-09  Tom Tromey  <tom@tromey.com>
4976
4977         * common/next-iterator.h: New file.
4978         * objfiles.h (class all_objfiles): New.
4979         (struct objfile_iterator): New.
4980
4981 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4982
4983         * NEWS: Move the description of the changed "frame", "select-frame",
4984          and "info frame" commands to the Changed commands section.
4985
4986 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
4987
4988         * gdbtypes.c (check_stub_method_group): Remove handling of old
4989         mangling schemes.
4990         * linespec.c (find_methods): Likewise.
4991         * stabsread.c (read_member_functions): Likewise.
4992         * valops.c (search_struct_method): Likewise.
4993         (value_struct_elt_for_reference): Likewise.
4994         * NEWS: Mention this change.
4995
4996 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4997
4998         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
4999         print_source_lines.
5000         * source.c (print_source_lines_base): Update line number check.
5001         (print_source_lines): New function.
5002         (source_lines_range::source_lines_range): New function.
5003         * source.h (class source_lines_range): New class.
5004         (print_source_lines): New declaration.
5005
5006 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5007
5008         * linespec.c (linespec_state_destructor): Free self->canonical_names.
5009
5010 2019-01-08  Tom Tromey  <tom@tromey.com>
5011             Simon Marchi  <simon.marchi@ericsson.com>
5012
5013         PR gdb/24060
5014         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
5015         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
5016         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5017         * f-exp.y (DOLLAR_VARIABLE): Likewise.
5018         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
5019         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5020
5021 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5022
5023         * source.c (select_source_symtab): Move header comment to
5024         declaration in source.h.
5025         (forget_cached_source_info_for_objfile): Likewise.
5026         (forget_cached_source_info): Likewise.
5027         (identify_source_line): Likewise.
5028         * source.h (identify_source_line): Move declaration from symtab.h
5029         and add comment from source.c
5030         (print_source_lines): Likewise.
5031         (forget_cached_source_info_for_objfile): Likewise.
5032         (forget_cached_source_info): Likewise.
5033         (select_source_symtab): Likewise.
5034         (enum print_source_lines_flag): Move definition from symtab.h.
5035         * symtab.h (identify_source_line): Move declaration to source.h.
5036         (print_source_lines): Likewise.
5037         (forget_cached_source_info_for_objfile): Likewise.
5038         (forget_cached_source_info): Likewise.
5039         (select_source_symtab): Likewise.
5040         (enum print_source_lines_flag): Move definition to source.h.
5041         * tui/tui-hooks.c: Add 'source.h' include.
5042
5043 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5044
5045         * source.c (print_source_lines_base): Handle requests to print
5046         reverse line number sequences, and guard against empty lines
5047         string.
5048
5049 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5050
5051         * source.c (print_source_lines_base): Fix skip of '\r' if next
5052         character is '\n'.
5053
5054 2019-01-06  Tom Tromey  <tom@tromey.com>
5055
5056         * c-exp.y (struct c_parse_state) <macro_original_text,
5057         expansion_obstack>: New member.
5058         (macro_original_text, expansion_obstack): Remove globals.
5059         (scan_macro_expansion, scanning_macro_expansion)
5060         (finished_macro_expansion): Update.
5061         (scan_macro_cleanup): Remove.
5062         (yylex, c_parse): Update.
5063
5064 2019-01-06  Tom Tromey  <tom@tromey.com>
5065
5066         * c-exp.y (struct c_parse_state) <strings>: New member.
5067         (operator_stoken): Update.
5068
5069 2019-01-06  Tom Tromey  <tom@tromey.com>
5070
5071         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
5072         (union type_stack_elt) <typelist_val>: Now a pointer to
5073         std::vector.
5074         (type_stack_cleanup): Don't declare.
5075         (push_typelist): Update.
5076         * parse.c (pop_typelist): Return a std::vector.
5077         (push_typelist): Take a std::vector.
5078         (follow_types): Update.  Do not free args.
5079         (type_stack_cleanup): Remove.
5080         * c-exp.y (struct c_parse_state): New.
5081         (cpstate): New global.
5082         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
5083         (nonempty_typelist): Update.
5084         (func_mod): Create a new vector.
5085         (c_parse): Create a c_parse_state.
5086         (check_parameter_typelist): Do not delete params.
5087         (function_method): Update.  Do not delete type_list.
5088
5089 2019-01-06  Tom Tromey  <tom@tromey.com>
5090
5091         PR gdb/28155:
5092         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
5093         check_typedef.
5094         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
5095         (print_return_value): Likewise.
5096
5097 2019-01-05  Tom Tromey  <tom@tromey.com>
5098
5099         * contrib/cleanup_check.py: Remove.
5100         * contrib/gcc-with-excheck: Remove.
5101         * contrib/exsummary.py: Remove.
5102         * contrib/excheck.py: Remove.
5103
5104 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
5105
5106         * thread.c (delete_thread_1): Add gdb_assert that THR is not
5107         NULL. Initialize tpprev to NULL instead of assigning it
5108         to NULL on the next statement.
5109         * windows-nat.c (windows_delete_thread): Remove check for
5110         main_thread_id before printing thread exit notifications.
5111         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
5112         Remove thread ID check against main_thread_id.
5113         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
5114         windows_delete_thread.
5115         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
5116
5117 2019-01-04  Tom Tromey  <tom@tromey.com>
5118
5119         * compile/compile.c (_initialize_compile): Use upper case for
5120         metasyntactic variables.
5121         * symmisc.c (_initialize_symmisc): Use upper case for
5122         metasyntactic variables.
5123         * psymtab.c (_initialize_psymtab): Use upper case for
5124         metasyntactic variables.
5125         * demangle.c (demangle_command): Use upper case for metasyntactic
5126         variables.
5127         (_initialize_demangler): Likewise.
5128         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
5129         variables.
5130
5131 2019-01-03  Tom Tromey  <tom@tromey.com>
5132
5133         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
5134
5135 2019-01-03  Tom Tromey  <tom@tromey.com>
5136
5137         * python/py-symtab.c (salpy_str): Update.
5138         (struct salpy_sal_object) <symtab>: Now a PyObject.
5139         (salpy_dealloc): Update.
5140         (del_objfile_sal): Use gdbpy_ref.
5141
5142 2019-01-03  Tom Tromey  <tom@tromey.com>
5143
5144         * python/py-type.c (convert_field): Use new_reference.  Return
5145         gdbpy_ref.
5146         (make_fielditem): Return gdbpy_ref.
5147         (typy_fields): Update.
5148         (typy_getitem): Update.
5149         (field_name): Return gdbpy_ref.  Use new_reference.
5150         (typy_iterator_iternext): Update.
5151
5152 2019-01-03  Tom Tromey  <tom@tromey.com>
5153
5154         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
5155
5156 2019-01-03  Tom Tromey  <tom@tromey.com>
5157
5158         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
5159         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
5160         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
5161         (pspy_set_frame_filters, pspy_set_frame_unwinders)
5162         (pspy_set_type_printers): Likewise.
5163         * python/py-function.c (fnpy_init): Use gdbpy_ref.
5164         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
5165         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
5166         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
5167         (objfpy_set_type_printers): Likewise.
5168
5169 2019-01-03  Tom Tromey  <tom@tromey.com>
5170
5171         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
5172         (gdbpy_print_stack): Use gdbpy_err_fetch.
5173         * python/python-internal.h (class gdbpy_err_fetch): New class.
5174         (class gdbpy_enter) <m_error_type, m_error_value,
5175         m_error_traceback>: Remove.
5176         <m_error>: New member.
5177         (gdbpy_exception_to_string): Don't declare.
5178         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
5179         * python/py-value.c (convert_value_from_python): Use
5180         gdbpy_err_fetch.
5181         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
5182         gdbpy_exception_to_string.
5183         (gdbpy_handle_exception): Use gdbpy_err_fetch.
5184         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
5185         gdbpy_err_fetch.
5186
5187 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5188
5189         * linux-nat.c (delete_lwp_cleanup): Delete.
5190         (struct lwp_deleter): New struct.
5191         (lwp_info_up): New typedef.
5192         (linux_nat_target::follow_fork): Delete cleanup, and make use of
5193         lwp_info_up.
5194
5195 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5196
5197         * linux-fork.c (class scoped_switch_fork_info): New class.
5198         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
5199
5200 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5201
5202         * valops.c (find_overload_match): Remove use of null_cleanup, and
5203         calls to do_cleanups.
5204
5205 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5206
5207         * compile/compile-cplus-types.c
5208         (compile_cplus_instance::decl_name): Handle changes to
5209         cp_func_name.
5210         * cp-support.c (cp_func_name): Update header comment, update
5211         return type.
5212         * cp-support.h (cp_func_name): Update return type in declaration.
5213         * valops.c (find_overload_match): Move temp_func local to top
5214         level of function and change its type.  Use temp_func to hold and
5215         delete temporary string obtained from cp_func_name.
5216
5217 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5218
5219         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
5220         gdb::char_vector, remove cleanup, and update uses of `msg`.
5221
5222 2019-01-03  Jim Wilson  <jimw@sifive.com>
5223
5224         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
5225
5226 2019-01-02  Tom Tromey  <tom@tromey.com>
5227
5228         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
5229         (tdesc_parse_xml): Remove cleanups.
5230         * target-descriptions.h (make_cleanup_free_target_description):
5231         Don't declare.
5232         (target_desc_deleter): New struct.
5233         (target_desc_up): New typedef.
5234         * target-descriptions.c (target_desc_deleter::operator()): Rename
5235         from free_target_description.
5236         (make_cleanup_free_target_description): Remove.
5237
5238 2019-01-02  Tom Tromey  <tom@tromey.com>
5239
5240         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
5241         constructor, destructor.
5242         (linespec_parser): Remove typedef.
5243         (~linespec_parser): Rename from linespec_parser_delete.
5244         (linespec_lex_to_end, linespec_complete_label)
5245         (linespec_complete): Update.
5246         (decode_line_full): Remove cleanups.
5247         (decode_line_1): Update.
5248
5249 2019-01-02  Tom Tromey  <tom@tromey.com>
5250
5251         * python/python-internal.h (inferior_to_inferior_object): Change
5252         return type.
5253         * python/py-exitedevent.c (create_exited_event_object): Update.
5254         * python/py-inferior.c (inferior_to_inferior_object): Return
5255         gdbpy_ref.
5256         (python_new_inferior, python_inferior_deleted)
5257         (thread_to_thread_object, delete_thread_object)
5258         (build_inferior_list, gdbpy_selected_inferior): Update.
5259         * python/py-infthread.c (create_thread_object): Update.  Also fail
5260         if inferior_to_inferior_object fails.
5261
5262 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
5263
5264         * inferior.h (class inferior) <displaced_step_state>: New field.
5265         * infrun.h (struct displaced_step_state): Move here from
5266         infrun.c.  Initialize fields, add constructor.
5267         <inf>: Remove field.
5268         <reset>: New method.
5269         * infrun.c (struct displaced_step_inferior_state): Move to
5270         infrun.h.
5271         (displaced_step_inferior_states): Remove.
5272         (get_displaced_stepping_state): Adust.
5273         (displaced_step_in_progress_any_inferior): Adjust.
5274         (displaced_step_in_progress_thread): Adjust.
5275         (displaced_step_in_progress): Adjust.
5276         (add_displaced_stepping_state): Remove.
5277         (get_displaced_step_closure_by_addr): Adjust.
5278         (remove_displaced_stepping_state): Remove.
5279         (infrun_inferior_exit): Call displaced_step_state.reset.
5280         (use_displaced_stepping): Don't check for NULL.
5281         (displaced_step_prepare_throw): Call
5282         get_displaced_stepping_state.
5283         (displaced_step_fixup): Don't check for NULL.
5284         (prepare_for_detach): Don't check for NULL.
5285
5286 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5287
5288         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
5289          in case of call that did not complete.
5290
5291 2019-01-02  Andrey Utkin  <autkin@undo.io>
5292
5293         * symfile.c (find_separate_debug_file): Fix search of debug files for
5294         remote debuggee.
5295
5296 2019-01-02  Tom Tromey  <tom@tromey.com>
5297
5298         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
5299         indentation.
5300         * python/py-frame.c (frapy_older): Remove cast.
5301         (frapy_newer): Likewise.
5302         * python/py-breakpoint.c (local_setattro): Remove cast.
5303         * python/py-arch.c (archpy_name): Remove local variable.
5304         * python/py-type.c (gdbpy_lookup_type): Remove cast.
5305
5306 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
5307
5308         * unittests/basic_string_view/element_access/char/empty.cc:
5309         Fix year range in copyright header.
5310
5311 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5312
5313         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
5314         Delete.
5315         <operator==>: Update with for removed field.
5316         <hash>: Likewise.
5317         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
5318         <isa_features>: ...this.
5319         <abi_features>: New field.
5320         (riscv_isa_flen): Update comment.
5321         (riscv_abi_xlen): New declaration.
5322         (riscv_abi_flen): New declaration.
5323         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
5324         isa_features.
5325         (riscv_abi_xlen): New function.
5326         (riscv_isa_flen): Update to get answer from isa_features.
5327         (riscv_abi_flen): New function.
5328         (riscv_has_fp_abi): Update to get answer from abi_features.
5329         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
5330         xlen and flen.
5331         (riscv_call_info) <xlen, flen>: Update comment.
5332         (riscv_call_arg_struct): Remove invalid assertions
5333         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
5334         is removed.
5335         (riscv_gdbarch_init): Gather isa features and abi features
5336         separately, ensure both match on the gdbarch when reusing an old
5337         gdbarch.  Relax an error check to allow 32-bit abi float to run on
5338         a target with 64-bit float hardware.
5339
5340 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5341
5342         * source.c (search_command_helper): Stop reverse search
5343         when line 1 has been searched.
5344
5345 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5346
5347         * record-full.c (record_full_base_target::close): Rewrite
5348         record_full_core_buf_list free logic.
5349
5350 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5351
5352         * break-catch-syscall.c (print_one_catch_syscall): xfree
5353         the last text.
5354
5355 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5356
5357         * top.c (print_gdb_version): Update Copyright year in version
5358         message.
5359
5360 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5361
5362         Update copyright year range in all GDB files.
5363
5364 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
5365
5366         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
5367
5368 For older changes see ChangeLog-2018.
5369 \f
5370 Local Variables:
5371 mode: change-log
5372 left-margin: 8
5373 fill-column: 74
5374 version-control: never
5375 coding: utf-8
5376 End:
5377