gdb/ChangeLog

   1 2019-07-10  Tom Tromey  <tromey@adacore.com>
   2
   3         * spu-tdep.c (spu_overlay_data): Change type.
   4         (spu_get_overlay_table, spu_overlay_new_objfile)
   5         (_initialize_spu_tdep): Update.
   6
   7 2019-07-10  Tom Tromey  <tromey@adacore.com>
   8
   9         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
  10         destructor.
  11         (dbx_objfile_data_key): Change type and declare later.
  12         (DBX_SYMFILE_INFO): Rewrite.
  13         * dbxread.c (dbx_objfile_data_key): Change type.
  14         (dbx_symfile_init): Update.
  15         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
  16         (coffstab_build_psymtabs, elfstab_build_psymtabs)
  17         (stabsect_build_psymtabs, _initialize_dbxread): Update.
  18
  19 2019-07-10  Tom Tromey  <tromey@adacore.com>
  20
  21         * jit.c (jit_program_space_key): Change type.  Move lower.
  22         (get_jit_program_space_data): Update.
  23         (jit_program_space_data_cleanup): Remove.
  24         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
  25         Update.
  26         (struct jit_program_space_data): Add initializers.
  27
  28 2019-07-10  Tom Tromey  <tromey@adacore.com>
  29
  30         * solib-darwin.c (struct darwin_info): Add initializers.
  31         (solib_darwin_pspace_data): Change type.
  32         (darwin_pspace_data_cleanup): Remove.
  33         (get_darwin_info, _initialize_darwin_solib): Update.
  34
  35 2019-07-10  Tom Tromey  <tromey@adacore.com>
  36
  37         * remote-sim.c (struct sim_inferior_data): Add initializers,
  38         constructor, and destructor.
  39         (sim_inferior_data_key): Change type.  Move lower.
  40         (check_for_duplicate_sim_descriptor): Update.
  41         (get_sim_inferior_data): Use new.  Update.
  42         (~sim_inferior_data_cleanup): Rename from
  43         sim_inferior_data_cleanup.  Simplify.
  44         (gdbsim_close_inferior, simulator_command)
  45         (sim_command_completer, _initialize_remote_sim): Update.
  46         (next_pid, INITIAL_PID): Move earlier.
  47
  48 2019-07-10  Tom Tromey  <tromey@adacore.com>
  49
  50         * python/python-internal.h (create_thread_object): Return
  51         gdbpy_ref.
  52         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
  53         * python/py-inferior.c (struct threadlist_entry): Add
  54         constructor.
  55         <thread_obj>: Now a gdbpy_ref.
  56         (thread_to_thread_object): Update.
  57         (add_thread_object): Use new.
  58         (delete_thread_object): Use delete.
  59         (infpy_threads): Update.
  60         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
  61         GIL.
  62
  63 2019-07-10  Tom Tromey  <tromey@adacore.com>
  64
  65         * valops.c (value_cast): Specialize error message for Ada.
  66
  67 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
  68
  69         * breakpoint.c (breakpoint_1): Update doc and parameter names.
  70
  71 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
  72
  73         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
  74         bpstat_should_step): Return bool, adjust comments.
  75         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
  76         bpstat_should_step): Likewise.
  77
  78 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
  79
  80         * features/Makefile: Use feature target descriptions for Arm.
  81         * features/arm/arm-core.c: Generate new file.
  82         * features/arm/arm-fpa.c: Likewise.
  83         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
  84         * features/arm/arm-m-profile.c: Likewise.
  85         * features/arm/arm-vfpv2.c: Likewise.
  86         * features/arm/arm-vfpv3.c: Likewise.
  87         * features/arm/xscale-iwmmxt.c: Likewise.
  88         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
  89
  90 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
  91
  92         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
  93         ptrace earlier.
  94
  95 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
  96
  97         * features/aarch64-pauth.c: Regenerate.
  98
  99 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
 100
 101         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
 102         bool.
 103         (bpstat_what): Use false instead of 0.
 104
 105 2019-07-09  Pedro Alves  <palves@redhat.com>
 106
 107         * break-catch-throw.c (is_exception_catchpoint): New.
 108         * breakpoint.c (print_one_breakpoint_location): New parameter
 109         'raw_loc'.  Handle it.  Use
 110         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
 111         looking at the breakpoint's type.
 112         (print_one_breakpoint): If handling "maint info breakpoints", also
 113         print locations of exception catchpoints.
 114         * breakpoint.h (is_exception_catchpoint): Declare.
 115
 116 2019-07-09  Pedro Alves  <palves@redhat.com>
 117
 118         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
 119         "addr" field.
 120         (allocate_location_exception_catchpoint): New.
 121         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
 122         (initialize_throw_catchpoint_ops): Install
 123         allocate_location_exception_catchpoint as allocate_location
 124         method.
 125         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
 126         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
 127         bp_loc_other.
 128         (breakpoint_address_is_meaningful): Delete.
 129         (bl_address_is_meaningful): New.
 130         (breakpoint_locations_match): Adjust comment.
 131         (bp_location_from_bp_type): New, factored out of...
 132         (bp_location::bp_location(breakpoint *)): ... this.
 133         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
 134         factored out of...
 135         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
 136         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
 137         breakpoint_address_is_meaningful.
 138         (bp_locations_compare): Adjust comment.
 139         (update_global_location_list): Use bl_address_is_meaningful
 140         instead of breakpoint_address_is_meaningful.
 141         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
 142         explicit.
 143         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
 144         * python/py-breakpoint.c (bppy_get_location): No longer check
 145         whether location is null.
 146
 147 2019-07-09  Pedro Alves  <palves@redhat.com>
 148
 149         PR c++/15468
 150         * breakpoint.c (print_one_breakpoint_location): Remove
 151         single-location assert.
 152
 153 2019-07-09  Tom Tromey  <tom@tromey.com>
 154
 155         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
 156         * configure: Rebuild.
 157         * configure.ac: Change common to gdbsupport.
 158         * gdbsupport: Rename from common.
 159         * acinclude.m4: Change common to gdbsupport.
 160         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
 161         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
 162         gdbsupport.
 163         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
 164         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
 165         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
 166         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
 167         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
 168         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
 169         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
 170         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
 171         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
 172         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
 173         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
 174         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
 175         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
 176         coff-pe-read.c, command.h, compile/compile-c-support.c,
 177         compile/compile-c.h, compile/compile-cplus-symbols.c,
 178         compile/compile-cplus-types.c, compile/compile-cplus.h,
 179         compile/compile-loc2c.c, compile/compile.c, completer.c,
 180         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 181         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 182         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 183         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 184         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 185         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 186         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 187         features/aarch64-core.c, features/aarch64-fpu.c,
 188         features/aarch64-pauth.c, features/aarch64-sve.c,
 189         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 190         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 191         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 192         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 193         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 194         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 195         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 196         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 197         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 198         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 199         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 200         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 201         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 202         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 203         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 204         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 205         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 206         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 207         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 208         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 209         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 210         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 211         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 212         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 213         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 214         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 215         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 216         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 217         minsyms.c, mips-linux-tdep.c, namespace.h,
 218         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 219         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 220         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 221         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 222         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 223         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 224         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 225         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 226         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 227         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 228         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 229         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 230         procfs.c, producer.c, progspace.h, psymtab.h,
 231         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 232         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 233         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 234         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 235         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
 236         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
 237         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
 238         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
 239         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
 240         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
 241         target-memory.c, target.c, target.h, target/waitstatus.c,
 242         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
 243         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
 244         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
 245         unittests/array-view-selftests.c,
 246         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
 247         unittests/common-utils-selftests.c,
 248         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
 249         unittests/format_pieces-selftests.c,
 250         unittests/function-view-selftests.c,
 251         unittests/lookup_name_info-selftests.c,
 252         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
 253         unittests/mkdir-recursive-selftests.c,
 254         unittests/observable-selftests.c,
 255         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
 256         unittests/parse-connection-spec-selftests.c,
 257         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
 258         unittests/scoped_fd-selftests.c,
 259         unittests/scoped_mmap-selftests.c,
 260         unittests/scoped_restore-selftests.c,
 261         unittests/string_view-selftests.c, unittests/style-selftests.c,
 262         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
 263         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
 264         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
 265         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
 266         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
 267         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
 268
 269 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 270
 271         * linespec.c (decode_digits_list_mode): Set explicit_line to a
 272         bool value.
 273         (decode_digits_ordinary): Set explicit_line field in sal.
 274         * symtab.c (skip_prologue_sal): Don't skip prologue for a
 275         symtab_and_line that was set on an explicit line number in
 276         assembler code.  Do always update the recorded symtab and line if
 277         we do skip the prologue.
 278
 279 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 280
 281         * breakpoint.c (set_breakpoint_location_function): Remove
 282         explicit_loc parameter.
 283         (momentary_breakpoint_from_master): Update call to
 284         set_breakpoint_location_function.
 285         (add_location_to_breakpoint): Likewise.
 286
 287 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 288
 289         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
 290         required features based on default bfd type when no specific bfd
 291         is present.
 292
 293 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 294
 295         * NEWS: Mention that GDB printf and eval commands can now print
 296         C-style and Ada-style convenience var strings without
 297         calling the inferior.
 298         * printcmd.c (printf_c_string): Locally print GDB internal var
 299         instead of transiting via the inferior.
 300         (printf_wide_c_string): Likewise.
 301
 302 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 303
 304         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
 305
 306 2019-07-04  Tom Tromey  <tom@tromey.com>
 307
 308         PR tui/24724:
 309         * tui/tui-winsource.c (tui_clear_source_content): Update.
 310         (tui_source_window_base::set_is_exec_point_at): Fix comment.
 311         (tui_update_breakpoint_info): Update.
 312         (tui_set_exec_info_content): Update.
 313         * tui/tui-source.c (tui_set_source_content_nil): Update.
 314         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
 315         has_break.
 316         * tui/tui-data.h (enum tui_bp_flag): New.
 317         (tui_bp_flags): New enum flags type.
 318         (struct tui_source_element) <break_mode>: Change type.  Rename
 319         from has_break.
 320         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
 321         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
 322         constants.
 323         * tui/tui-winsource.h: Fix comment.
 324
 325 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 326
 327         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
 328         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
 329         (store_fpregs_to_thread)
 330         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 331         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
 332         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
 333         (IWMMXT_REGS_SIZE): Add define.
 334         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
 335         (fetch_vfp_regs, store_vfp_regs)
 336         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 337         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
 338
 339 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 340
 341         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
 342         defines.
 343         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
 344         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
 345         (ARM_INT_REGISTER_SIZE): ...to this.
 346         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
 347         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
 348         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
 349         (arm_linux_collect_gregset, supply_nwfpe_register)
 350         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
 351         defines.
 352         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
 353         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
 354         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
 355         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
 356         (arm_return_in_memory, arm_store_return_value)
 357         (arm_get_longjmp_target, arm_register_g_packet_guesses)
 358         (arm_record_ld_st_multiple): Likewise.
 359         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
 360         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
 361
 362 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 363
 364         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
 365         AARCH64_DISPLACED_MODIFIED_INSNS.
 366         * aarch64-tdep.c (struct aarch64_displaced_step_data)
 367         (aarch64_displaced_step_copy_insn): Likewise.
 368         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 369         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
 370         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
 371         ARM_DISPLACED_MODIFIED_INSNS.
 372         * arm-tdep.c (arm_gdbarch_init): Likewise.
 373         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 374         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
 375         (struct arm_displaced_step_closure): Use
 376         ARM_DISPLACED_MODIFIED_INSNS.
 377
 378 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 379
 380         * features/Makefile: Remove unused xml files.
 381         * features/aarch64.xml: Remove.
 382         * features/i386/amd64-avx-avx512-linux.xml: Remove.
 383         * features/i386/amd64-avx-avx512.xml: Remove.
 384         * features/i386/amd64-avx-linux.xml: Remove.
 385         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
 386         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
 387         * features/i386/amd64-avx-mpx-linux.xml: Remove.
 388         * features/i386/amd64-avx-mpx.xml: Remove.
 389         * features/i386/amd64-avx.xml: Remove.
 390         * features/i386/amd64-linux.xml: Remove.
 391         * features/i386/amd64-mpx-linux.xml: Remove.
 392         * features/i386/amd64-mpx.xml: Remove.
 393         * features/i386/amd64.xml: Remove.
 394         * features/i386/i386-avx-avx512-linux.xml: Remove.
 395         * features/i386/i386-avx-avx512.xml: Remove.
 396         * features/i386/i386-avx-linux.xml: Remove.
 397         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
 398         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
 399         * features/i386/i386-avx-mpx-linux.xml: Remove.
 400         * features/i386/i386-avx-mpx.xml: Remove.
 401         * features/i386/i386-avx.xml: Remove.
 402         * features/i386/i386-linux.xml: Remove.
 403         * features/i386/i386-mmx-linux.xml: Remove.
 404         * features/i386/i386-mmx.xml: Remove.
 405         * features/i386/i386-mpx-linux.xml: Remove.
 406         * features/i386/i386-mpx.xml: Remove.
 407         * features/i386/i386.xml: Remove.
 408         * features/i386/x32-avx-avx512-linux.xml: Remove.
 409         * features/i386/x32-avx-linux.xml: Remove.
 410         * features/i386/x32-linux.xml: Remove.
 411
 412 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 413
 414         * regformats/aarch64.dat: Remove.
 415         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
 416         * regformats/i386/amd64-avx-linux.dat: Remove.
 417         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
 418         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
 419         * regformats/i386/amd64-linux.dat: Remove.
 420         * regformats/i386/amd64-mpx-linux.dat: Remove.
 421         * regformats/i386/amd64.dat: Remove.
 422         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
 423         * regformats/i386/i386-avx-linux.dat: Remove.
 424         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
 425         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
 426         * regformats/i386/i386-linux.dat: Remove.
 427         * regformats/i386/i386-mmx-linux.dat: Remove.
 428         * regformats/i386/i386-mpx-linux.dat: Remove.
 429         * regformats/i386/i386.dat: Remove.
 430         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
 431         * regformats/i386/x32-avx-linux.dat: Remove.
 432         * regformats/i386/x32-linux.dat: Remove.
 433
 434 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 435
 436         * aarch64-tdep.c: Remove xml self tests.
 437         * amd64-linux-tdep.c: Likewise.
 438         * amd64-tdep.c: Likewise.
 439         * i386-linux-tdep.c: Likewise.
 440         * i386-tdep.c: Likewise.
 441
 442 2019-07-03  Pedro Alves  <palves@redhat.com>
 443
 444         PR cli/24732
 445         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
 446         (pipe_cmd_option_defs): New.
 447         (make_pipe_cmd_options_def_group): New.
 448         (pipe_command): Use gdb::option::process_options.
 449         (pipe_command_completer): New function.
 450         (_initialize_cli_cmds): Install completer for "pipe" command.
 451
 452 2019-07-03  Pedro Alves  <palves@redhat.com>
 453
 454         * cli/cli-option.c (union option_value) <string>: New field.
 455         (struct option_def_and_value): Add ctor, move ctor, dtor and
 456         use DISABLE_COPY_AND_ASSIGN.
 457         (option_def_and_value::clear_value): New.
 458         (parse_option, save_option_value_in_ctx, get_val_type_str)
 459         (add_setshow_cmds_for_options): Handle var_string.
 460         * cli-option.h (union option_def::var_address) <string>: New
 461         field.
 462         (struct string_option_def): New.
 463         * maint-test-options.c (struct test_options_opts): Add default
 464         ctor and use DISABLE_COPY_AND_ASSIGN.
 465         <string_opt>: New field.
 466         (test_options_opts::~test_options_opts): New.
 467         (test_options_opts::dump): Also dump "-string".
 468         (test_options_option_defs): Install "string.
 469
 470 2019-07-03  Pedro Alves  <palves@redhat.com>
 471
 472         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
 473         option_value with a null enumeration.
 474         (complete_options): Save the option values in the context.
 475         (save_option_value_in_ctx): New, factored out from ...
 476         (process_options): ... here.
 477         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
 478         of the function.
 479         * maint-test-options.c (test_options_opts::dump): New, factored
 480         out from ...
 481         (maintenance_test_options_command_mode): ... here.
 482         (maintenance_test_options_command_completion_result): Delete.
 483         (maintenance_test_options_command_completion_text): Update
 484         comment.
 485         (maintenance_show_test_options_completion_result): Change
 486         prototype.  Just print
 487         maintenance_test_options_command_completion_text.
 488         (save_completion_result): New.
 489         (maintenance_test_options_completer_mode): Pass options context to
 490         complete_options, and then save a dump.
 491         (_initialize_maint_test_options): Use add_cmd to install "maint
 492         show test-options-completion-result".
 493
 494 2019-07-03  Pedro Alves  <palves@redhat.com>
 495
 496         * NEWS (New commands): Mention "with" and "maint with".
 497         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
 498         (with_command, with_command_completer): New.
 499         (pipe_command): Adjust to new repeat_previous
 500         interface.
 501         (_initialize_cli_cmds): Install the "with" command and its "w"
 502         alias.
 503         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
 504         declarations.
 505         * cli/cli-setshow.c (parse_cli_var_uinteger)
 506         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
 507         argument strings for all var_types.
 508         (get_setshow_command_value_string): New, factored out from ...
 509         (do_show_command): ... this.
 510         * cli/cli-setshow.h: Include <string>.
 511         (get_setshow_command_value_string): Declare.
 512         * command.h (repeat_previous): Now returns const char *.  Adjust
 513         comment.
 514         * maint.c: Include "cli/cli-cmds.h".
 515         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
 516         (_initialize_maint_cmds): Register the "maintenance with" command.
 517         * top.c (repeat_previous): Move bits from pipe_command here:
 518         Return the saved command line, if any; error out if there's no
 519         command to relaunch.
 520
 521 2019-07-03  Pedro Alves  <palves@redhat.com>
 522
 523         * NEWS (New commands): Mention "maint set/show test-settings"
 524         instead of "maint test-settings".
 525         * maint-test-settings.c (maintenance_test_settings_list): Delete.
 526         (maintenance_test_settings_set_list): Rename to ...
 527         (maintenance_set_test_settings_list): ... this.
 528         (maintenance_test_settings_show_list): Rename to  ...
 529         (maintenance_show_test_settings_list): ... this.
 530         (maintenance_test_settings_cmd): Delete.
 531         (maintenance_test_settings_set_cmd): ...
 532         (maintenance_set_test_settings_cmd): ... this.
 533         (maintenance_test_settings_show_cmd): ...
 534         (maintenance_show_test_settings_cmd): ... this.
 535         (maintenance_test_settings_show_value_cmd):
 536         (maintenance_show_test_settings_value_cmd): ... this.
 537         (_initialize_maint_test_settings): No longer install the "maint
 538         test-settings" prefix command.  Rename "maint test-settings set"
 539         to "maint set test-settings", and "maint test-settings show" to
 540         "maint show test-settings".  Adjust all subcommands.
 541
 542 2019-07-03  Pedro Alves  <palves@redhat.com>
 543
 544         * maint-test-settings.c: Fix file's intro comment.  Replace all
 545         references to "test-options" with references to "test-settings",
 546         in comments.
 547
 548 2019-07-03  Pedro Alves  <palves@redhat.com>
 549
 550         * maint-test-settings.c (maintenance_test_settings_xxx)
 551         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
 552         New.
 553         (maintenance_test_settings_enums): Use them.
 554         (maintenance_test_settings_enum): Default to
 555         maintenance_test_settings_xxx.
 556         (_initialize_maint_test_settings): Initialize
 557         MAINTENANCE_TEST_SETTINGS_FILENAME.
 558
 559 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 560
 561         * breakpoint.h (remove_breakpoints_inf): Change return type to
 562         void, move function documentation here.
 563         * breakpoint.c (remove_breakpoints_inf): Change return type to
 564         void, move function documentation to header.
 565
 566 2019-07-02  Pedro Alves  <palves@redhat.com>
 567
 568         * NEWS (Completion improvements): Mention "info threads".
 569         * thread.c (struct info_threads_opts, info_threads_option_defs)
 570         (make_info_threads_options_def_group): New.
 571         (info_threads_command): Use gdb::option::process_options.
 572         (info_threads_command_completer): New.
 573         (_initialize_thread): Use gdb::option::build_help to build the
 574         help text for "info threads".
 575
 576 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 577
 578         * defs.h (generic_load): Move from here...
 579         * symfile.h (generic_load): ... to here.  Rename name parameter
 580         to args.
 581         * symfile.c (generic_load): Add comment.
 582
 583 2019-07-01  Tom Tromey  <tromey@adacore.com>
 584
 585         * dwarf2read.c
 586         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
 587         declaration of without_params.  Fix formatting.
 588
 589 2019-07-01  Tom Tromey  <tromey@adacore.com>
 590
 591         * ada-exp.y (find_primitive_type): Update.
 592         * ada-lang.h (ada_lookup_symbol): Update.
 593         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
 594         parameter.
 595         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
 596
 597 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 598
 599         PR breakpoints/24541
 600         * gdbarch.c: Regenerate.
 601         * gdbarch.h: Regenerate.
 602         * gdbarch.sh: Add 'stap_adjust_register'.
 603         * i386-tdep.c: Include '<unordered_set>'.
 604         (i386_stap_adjust_register): New function.
 605         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
 606         * stap-probe.c (stap_parse_register_operand): Call
 607         'gdbarch_stap_adjust_register'.
 608
 609 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 610
 611         PR python/24742
 612         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
 613         * python/python.c (do_start_initialization): Use 'xmalloc'
 614         instead of 'PyMem_Malloc'.
 615
 616 2019-06-28  Tom Tromey  <tromey@adacore.com>
 617
 618         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
 619         for Ada.
 620
 621 2019-06-27  Tom Tromey  <tromey@adacore.com>
 622
 623         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
 624         objfile_key.
 625         (arm_find_mapping_symbol, arm_record_special_symbol)
 626         (_initialize_arm_tdep): Update.
 627         (arm_objfile_data_free): Remove.
 628
 629 2019-06-27  Tom Tromey  <tromey@adacore.com>
 630
 631         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
 632         to cp_print_static_field.
 633
 634 2019-06-26  Tom Tromey  <tromey@adacore.com>
 635
 636         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
 637         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
 638         declare.
 639
 640 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 641
 642         * features/aarch64-core.c (create_feature_aarch64_core):
 643         Regenerate.
 644         * features/aarch64-core.xml: Add cpsr flags.
 645
 646 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 647
 648         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
 649         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
 650
 651 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 652
 653         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
 654         field.
 655         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
 656         use.
 657         (arm_record_special_symbol): Don't insert new symbol in sorted
 658         position, push it at the end.
 659
 660 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 661
 662         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
 663         (arm_mapping_symbol_s): Remove.
 664         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
 665         (arm_mapping_symbol_vec): New typedef.
 666         (struct arm_per_objfile): Add constructor.
 667         <section_maps>: Change type to
 668         std::unique_ptr<arm_mapping_symbol_vec[]>.
 669         (arm_compare_mapping_symbols): Remove.
 670         (arm_find_mapping_symbol): Adjust to section_maps type change.
 671         (arm_objfile_data_free): Call delete on arm_per_objfile.
 672         (arm_record_special_symbol): Adjust to section_maps type change.
 673         Allocate arm_per_objfile with new.
 674
 675 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 676
 677         * cli/cli-cmds.c (alias_command): Compare the alias prefix
 678         with the command prefix.
 679
 680 2019-06-25  Tom Tromey  <tom@tromey.com>
 681
 682         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
 683         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
 684
 685 2019-06-25  Tom Tromey  <tom@tromey.com>
 686
 687         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
 688         type.
 689         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
 690         protected.
 691
 692 2019-06-25  Tom Tromey  <tom@tromey.com>
 693
 694         * tui/tui-winsource.c
 695         (tui_source_window_base::set_is_exec_point_at): Add check against
 696         LOA_ADDRESS.
 697
 698 2019-06-25  Tom Tromey  <tom@tromey.com>
 699
 700         * tui/tui-source.c (tui_set_source_content): Don't check before
 701         xfree.
 702         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
 703
 704 2019-06-25  Tom Tromey  <tom@tromey.com>
 705
 706         * tui/tui-winsource.h (tui_update_source_window_as_is)
 707         (tui_alloc_source_buffer, tui_line_is_displayed)
 708         (tui_addr_is_displayed): Change type of win_info.
 709         * tui/tui-winsource.c (tui_update_source_window_as_is)
 710         (tui_clear_source_content, tui_show_source_line)
 711         (tui_show_source_content, tui_source_window_base::refill)
 712         (tui_source_window_base::set_is_exec_point_at)
 713         (tui_source_window_base::set_is_exec_point_at)
 714         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
 715         (tui_alloc_source_buffer, tui_line_is_displayed)
 716         (tui_addr_is_displayed): Change type of win_info.  Update.
 717         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 718         (tui_source_window_base::do_make_visible_with_new_height):
 719         Update.
 720         * tui/tui-source.c (tui_set_source_content)
 721         (tui_set_source_content_nil)
 722         (tui_source_window::do_scroll_vertical): Update.
 723         * tui/tui-layout.c (show_layout): Update.
 724         * tui/tui-disasm.c (tui_set_disassem_content)
 725         (tui_disasm_window::do_scroll_vertical): Update.
 726         * tui/tui-data.h (tui_win_content): Remove.
 727         (struct tui_gen_win_info) <content, content_size>: Remove.
 728         (struct tui_source_element): Add initializers and destructor.
 729         (union tui_which_element, struct tui_win_element): Remove.
 730         (struct tui_source_window_base) <content>: New field.
 731         (struct tui_data_window): Remove destructor.
 732         (tui_alloc_content, tui_free_win_content)
 733         (tui_free_all_source_wins_content): Don't declare.
 734         * tui/tui-data.c (tui_initialize_static_data): Update.
 735         (init_content_element, tui_alloc_content): Remove.
 736         (~tui_gen_win_info): Update.
 737         (~tui_data_window, tui_free_all_source_wins_content)
 738         (tui_free_win_content, free_content, free_content_elements):
 739         Remove.
 740
 741 2019-06-25  Tom Tromey  <tom@tromey.com>
 742
 743         * tui/tui-winsource.h (tui_clear_source_content)
 744         (tui_erase_source_content, tui_show_source_content): Change type
 745         of win_info.
 746         * tui/tui-winsource.c (tui_clear_source_content)
 747         (tui_erase_source_content, tui_show_source_content): Change type
 748         of win_info.
 749         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 750         * tui/tui-source.h (tui_set_source_content_nil): Change type of
 751         win_info.
 752         * tui/tui-source.c (tui_set_source_content_nil): Change type of
 753         win_info.
 754         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
 755
 756 2019-06-25  Tom Tromey  <tom@tromey.com>
 757
 758         * tui/tui-winsource.c (tui_clear_source_content)
 759         (tui_source_window_base::set_is_exec_point_at): Update.
 760         * tui/tui-source.c (tui_set_source_content_nil): Update.
 761         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
 762         a bool.
 763         * tui/tui-data.c (init_content_element): Update.
 764
 765 2019-06-25  Tom Tromey  <tom@tromey.com>
 766
 767         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
 768         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
 769         * tui/tui-layout.c (init_and_make_win): Update.
 770         * tui/tui.h (enum tui_win_type): Update.
 771         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
 772         tui_win_is_auxillary.
 773         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
 774         tui_win_is_auxillary.
 775
 776 2019-06-25  Tom Tromey  <tom@tromey.com>
 777
 778         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
 779         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
 780         (tui_delete_data_content_windows, tui_display_all_data)
 781         (tui_data_window::do_scroll_vertical, tui_display_data_from):
 782         Update.
 783         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
 784         * tui/tui-regs.c (tui_last_regs_line_no)
 785         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 786         (tui_show_registers): Update.
 787         (tui_show_register_group): Return void.  Update.
 788         (tui_display_registers_from, tui_display_reg_element_at_line)
 789         (tui_display_registers_from_line, tui_check_register_values):
 790         Update.
 791         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
 792         member.
 793         (struct tui_data_window) <regs_content>: Now a std::vector.
 794         <regs_content_count>: Remove.
 795         (tui_add_content_elements, tui_free_data_content): Don't declare.
 796         * tui/tui-data.c (tui_data_window::clear_detail): Update.
 797         (init_content_element): Remove DATA_WIN case.  Add assert.
 798         (tui_add_content_elements): Remove.
 799         (tui_data_window): Update.
 800         (tui_free_data_content): Remove.
 801         (free_content_elements): Remove DATA_WIN case.
 802
 803 2019-06-25  Tom Tromey  <tom@tromey.com>
 804
 805         * tui/tui-data.c (tui_data_item_window): Update.
 806         * tui/tui-windata.h (tui_check_data_values): Don't declare.
 807         * tui/tui-windata.c (tui_display_all_data)
 808         (tui_display_data_from_line): Update.
 809         (tui_check_data_values): Remove.
 810         * tui/tui-regs.c (tui_show_register_group)
 811         (tui_display_reg_element_at_line): Update.
 812         * tui/tui-hooks.c (tui_register_changed)
 813         (tui_refresh_frame_and_register_information): Call
 814         tui_check_register_values.
 815         * tui/tui-data.h (struct tui_data_window) <data_content,
 816         data_content_count, data_type>: Remove.
 817         (enum tui_data_type): Remove.
 818
 819         * tui/tui-data.c (tui_data_window::clear_detail)
 820         (~tui_data_window): Update.
 821
 822 2019-06-25  Tom Tromey  <tom@tromey.com>
 823
 824         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
 825         declare.
 826         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
 827         Rename from tui_first_data_item_displayed.  Update.
 828         (tui_data_window::refresh_all)
 829         (tui_data_window::do_scroll_vertical): Update.
 830         * tui/tui-data.h (struct tui_data_window)
 831         <first_data_item_displayed>: Declare new method.
 832
 833 2019-06-25  Tom Tromey  <tom@tromey.com>
 834
 835         * tui/tui-data.h (tui_init_generic_part): Don't declare.
 836         * tui/tui-data.c (tui_init_generic_part): Remove, moving
 837         contents...
 838         (tui_initialize_static_data): ...here.
 839
 840 2019-06-25  Tom Tromey  <tom@tromey.com>
 841
 842         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 843         (tui_display_registers_from, tui_check_register_values): Update.
 844         (tui_display_register): Remove win_info parameter; update.
 845         (tui_get_register): Change type of parameters.
 846         * tui/tui-data.h (struct tui_data_element): Remove.
 847         (union tui_which_element) <data>: Remove.
 848         <data_window>: Change type.
 849         (struct tui_data_item_window): New.
 850         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
 851         case.  Add assert.
 852         (~tui_data_item_window): New destructor.
 853         (free_content_elements): Remove DATA_ITEM_WIN case.
 854
 855 2019-06-25  Tom Tromey  <tom@tromey.com>
 856
 857         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
 858         Remove.
 859
 860 2019-06-25  Tom Tromey  <tom@tromey.com>
 861
 862         * tui/tui-data.h (struct tui_command_element): Remove.
 863         (union tui_which_element) <command>: Remove.
 864         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
 865         assert.
 866         (free_content_elements): Remove CMD_WIN case.
 867
 868 2019-06-25  Tom Tromey  <tom@tromey.com>
 869
 870         * tui/tui-layout.c (tui_set_layout): Update.
 871         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
 872         * tui/tui-data.c (layout_def): Update.
 873
 874 2019-06-25  Tom Tromey  <tom@tromey.com>
 875
 876         * tui/tui-wingeneral.c (tui_refresh_all): Update.
 877         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 878         (tui_source_window_base::set_new_height): Update.
 879         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
 880         Update.
 881         (tui_set_locator_fullname, tui_set_locator_info)
 882         (tui_show_frame_info): Update.
 883         * tui/tui-source.c (tui_set_source_content)
 884         (tui_source_is_displayed): Update.
 885         * tui/tui-layout.c (show_source_disasm_command, show_data)
 886         (show_source_or_disasm_and_command): Update.
 887         * tui/tui-disasm.c (tui_set_disassem_content)
 888         (tui_get_begin_asm_address): Update.
 889         * tui/tui-data.h (struct tui_locator_element): Remove.
 890         (union tui_which_element) <locator>: Remove.
 891         (struct tui_locator_window): New.
 892         (tui_locator_win_info_ptr): Change return type.
 893         * tui/tui-data.c (_locator): Change type.
 894         (tui_locator_win_info_ptr): Change return type.
 895         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
 896         (tui_alloc_content): Add assert.
 897
 898 2019-06-25  Tom Tromey  <tom@tromey.com>
 899
 900         * tui/tui-winsource.c
 901         (tui_exec_info_window::maybe_allocate_content): New method.
 902         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
 903         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
 904         (make_source_or_disasm_window): Add cast.
 905         * tui/tui-data.h (union tui_which_element) <simple_string>:
 906         Remove.
 907         (struct tui_source_info): New.
 908         (struct tui_source_window_base) <execution_info>: Change type.
 909         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
 910         case, and add assert.
 911         (tui_alloc_content): Add assert.
 912
 913 2019-06-25  Tom Tromey  <tom@tromey.com>
 914
 915         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
 916         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
 917         * tui/tui-data.c (tui_alloc_win_info): Remove.
 918
 919 2019-06-25  Tom Tromey  <tom@tromey.com>
 920
 921         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
 922         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
 923         can_highlight.
 924
 925 2019-06-25  Tom Tromey  <tom@tromey.com>
 926
 927         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
 928         make_visible_with_new_height method.
 929         (tui_win_info::make_visible_with_new_height): New method.
 930         (tui_source_window_base::do_make_visible_with_new_height)
 931         (tui_data_window::do_make_visible_with_new_height)
 932         (tui_cmd_window::do_make_visible_with_new_height): New methods.
 933         (make_visible_with_new_height): Remove.
 934         (tui_resize_all, tui_adjust_win_heights): Use
 935         make_visible_with_new_height method.
 936         * tui/tui-data.h (struct tui_win_info)
 937         <do_make_visible_with_new_height, make_visible_with_new_height>:
 938         New methods.
 939         (struct tui_source_window_base, struct tui_data_window)
 940         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
 941         methods.
 942
 943 2019-06-25  Tom Tromey  <tom@tromey.com>
 944
 945         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
 946         method.
 947         (update_tab_width): Call update_tab_width method.
 948         * tui/tui-data.h (struct tui_win_info)
 949         (struct tui_source_window_base) <update_tab_width>: New methods.
 950
 951 2019-06-25  Tom Tromey  <tom@tromey.com>
 952
 953         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
 954         parameter.
 955         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
 956         parameter.
 957         (tui_gen_win_info::make_visible): Update.
 958         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
 959         parameter.
 960         * tui/tui-data.h (enum tui_box): New enum.
 961         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
 962
 963 2019-06-25  Tom Tromey  <tom@tromey.com>
 964
 965         * tui/tui-layout.c (make_source_or_disasm_window): Always use
 966         init_and_make_win for EXEC_INFO_WIN.
 967         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
 968         longer inline.
 969         (struct tui_win_info) <~tui_win_info>: Inline.
 970         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 971         Don't declare.
 972         * tui/tui-data.c (source_win, disasm_win): Remove globals.
 973         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 974         Remove.
 975         (tui_initialize_static_data): Update.
 976         (~tui_gen_win_info): Handle more cleanup here.
 977         (~tui_source_window_base): Delete "execution_info".
 978         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
 979
 980 2019-06-25  Tom Tromey  <tom@tromey.com>
 981
 982         * tui/tui-layout.c (make_command_window): Don't set
 983         can_highlight.
 984         (show_source_disasm_command): Call the reset method.
 985         (show_data): Don't set can_highlight.  Call the reset method.
 986         (tui_gen_win_info::reset): Rename from init_gen_win_info
 987         (init_and_make_win): Simplify.  Return tui_gen_win_info.
 988         (show_source_or_disasm_and_command): Call the reset method.
 989         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
 990         (struct tui_cmd_window): Set can_highlight.
 991
 992 2019-06-25  Tom Tromey  <tom@tromey.com>
 993
 994         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
 995         from make_visible.
 996         (tui_make_visible, tui_make_invisible): Rewrite.
 997         (tui_win_info::make_visible): Remove.
 998         (tui_source_window_base::make_visible): Update.
 999         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1000         method.  Moved from...
1001         (struct tui_win_info) <make_visible>: ...here.
1002
1003 2019-06-25  Tom Tromey  <tom@tromey.com>
1004
1005         * tui/tui-winsource.c
1006         (tui_source_window_base::do_scroll_horizontal): Remove direction
1007         parameter.
1008         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1009         direction parameter.
1010         * tui/tui-win.c (tui_win_info::forward_scroll)
1011         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1012         (tui_win_info::right_scroll): Update.
1013         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1014         direction parameter.
1015         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1016         direction parameter.
1017         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1018         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1019         Remove direction parameter.
1020         (struct tui_source_window_base, struct tui_source_window)
1021         (struct tui_disasm_window, struct tui_data_window)
1022         (struct tui_cmd_window): Update.
1023
1024 2019-06-25  Tom Tromey  <tom@tromey.com>
1025
1026         * tui/tui-winsource.h (tui_set_exec_info_content)
1027         (tui_show_exec_info_content, tui_erase_exec_info_content)
1028         (tui_clear_exec_info_content, tui_update_exec_info): Change
1029         argument to tui_source_window_base.
1030         * tui/tui-winsource.c (tui_set_exec_info_content)
1031         (tui_show_exec_info_content, tui_erase_exec_info_content)
1032         (tui_clear_exec_info_content, tui_update_exec_info): Change
1033         argument to tui_source_window_base.
1034
1035 2019-06-25  Tom Tromey  <tom@tromey.com>
1036
1037         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1038         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1039
1040 2019-06-25  Tom Tromey  <tom@tromey.com>
1041
1042         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1043         check.
1044
1045 2019-06-25  Tom Tromey  <tom@tromey.com>
1046
1047         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1048         type to void.
1049         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1050         type to void.
1051         * tui/tui-source.c (tui_set_source_content): Update.
1052         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1053
1054 2019-06-25  Tom Tromey  <tom@tromey.com>
1055
1056         * tui/tui-win.c (window_name_completer, tui_set_focus)
1057         (tui_all_windows_info): Use name method.
1058         * tui/tui-data.h (struct tui_gen_win_info)
1059         (struct tui_source_window, struct tui_disasm_window)
1060         (struct tui_data_window, struct tui_cmd_window) <name>: New
1061         method.
1062         (tui_win_name): Don't declare.
1063         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1064         (tui_win_name): Remove.
1065
1066 2019-06-25  Tom Tromey  <tom@tromey.com>
1067
1068         * tui/tui-winsource.h (tui_update_source_window)
1069         (tui_update_source_window_as_is): Change parameter type.
1070         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1071         to be a tui_source_window_base.
1072         (tui_update_source_window_as_is): Likewise.
1073         * tui/tui-win.c (make_visible_with_new_height): Update.
1074
1075 2019-06-25  Tom Tromey  <tom@tromey.com>
1076
1077         * tui/tui-winsource.c (tui_erase_source_content)
1078         (tui_show_source_content, tui_show_exec_info_content)
1079         (tui_erase_exec_info_content): Use refresh_window method.
1080         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1081         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1082         from tui_refresh_win.
1083         (tui_data_window::refresh_window): New method.
1084         (tui_win_info::refresh, tui_source_window_base::refresh)
1085         (tui_refresh_all): Use refresh_window method.
1086         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1087         method.
1088         * tui/tui-regs.c (tui_display_register): Call refresh_window
1089         method.
1090         * tui/tui-layout.c (show_source_disasm_command)
1091         (show_source_or_disasm_and_command): Call refresh_window method.
1092         * tui/tui-data.h (struct tui_gen_win_info)
1093         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1094         New method.
1095
1096 2019-06-25  Tom Tromey  <tom@tromey.com>
1097
1098         * tui/tui.c (tui_rl_other_window, tui_enable)
1099         (tui_is_window_visible, tui_get_command_dimension): Update.
1100         * tui/tui-winsource.c (tui_update_source_window_as_is)
1101         (tui_clear_source_content, tui_erase_source_content)
1102         (tui_show_source_line, tui_source_window_base::refill)
1103         (tui_source_window_base::do_scroll_horizontal)
1104         (tui_source_window_base::set_is_exec_point_at)
1105         (tui_update_breakpoint_info, tui_set_exec_info_content)
1106         (tui_alloc_source_buffer, tui_line_is_displayed)
1107         (tui_addr_is_displayed): Update.
1108         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1109         (tui_check_and_display_highlight_if_needed)
1110         (tui_win_info::make_visible, tui_win_info::refresh)
1111         (tui_refresh_all): Update.
1112         * tui/tui-windata.c (tui_first_data_item_displayed)
1113         (tui_delete_data_content_windows, tui_erase_data_content)
1114         (tui_display_all_data, tui_data_window::refresh_all)
1115         (tui_check_data_values): Update.
1116         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1117         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1118         (tui_win_info::backward_scroll, tui_refresh_all_win)
1119         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1120         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1121         (tui_source_window_base::set_new_height)
1122         (tui_data_window::set_new_height)
1123         (make_invisible_and_set_new_height)
1124         (make_visible_with_new_height, new_height_ok)
1125         (parse_scrolling_args): Update.
1126         * tui/tui-stack.c (tui_show_frame_info): Update.
1127         * tui/tui-source.c (tui_set_source_content)
1128         (tui_set_source_content_nil, tui_source_is_displayed)
1129         (tui_source_window::do_scroll_vertical): Update.
1130         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1131         (tui_display_registers_from, tui_display_reg_element_at_line)
1132         (tui_check_register_values, tui_reg_command): Update.
1133         * tui/tui-layout.c (tui_default_win_height)
1134         (show_source_disasm_command, show_data, init_and_make_win)
1135         (show_source_or_disasm_and_command): Update.
1136         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1137         (tui_redisplay_readline, tui_mld_flush)
1138         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1139         (tui_getc): Update.
1140         * tui/tui-disasm.c (tui_set_disassem_content)
1141         (tui_disasm_window::do_scroll_vertical): Update.
1142         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1143         Now virtual.
1144         (struct tui_win_info): Derive from tui_gen_win_info.
1145         <~tui_win_info>: Mark as override.
1146         <generic>: Remove member.
1147         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1148         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1149         (~tui_data_window, ~tui_win_info)
1150         (tui_free_all_source_wins_content): Update.
1151         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1152
1153 2019-06-25  Tom Tromey  <tom@tromey.com>
1154
1155         * tui/tui-layout.c (init_and_make_win): Use new.
1156         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1157         destructor, initializers.
1158         (tui_alloc_generic_win_info): Don't declare.
1159         * tui/tui-data.c (_locator): Add argument to constructor.
1160         (source_win, disasm_win): New globals.
1161         (exec_info): Remove.
1162         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1163         Update.
1164         (tui_alloc_generic_win_info): Remove.
1165         (init_content_element): Use new.
1166         (tui_win_info::tui_win_info): Update.
1167         (free_content_elements) <case DATA_WIN>: Use delete.
1168
1169 2019-06-25  Tom Tromey  <tom@tromey.com>
1170
1171         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1172         * tui/tui-windata.c (tui_first_data_item_displayed)
1173         (tui_delete_data_content_windows): Update.
1174         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1175         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1176         (tui_display_registers_from, tui_check_register_values): Update.
1177         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1178         pointer.
1179         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1180         window.
1181         (tui_free_data_content): Update.
1182         (free_content_elements) <case DATA_WIN>: Free the window.
1183
1184 2019-06-25  Tom Tromey  <tom@tromey.com>
1185
1186         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1187         Update.
1188         * tui/tui-layout.c (make_command_window)
1189         (show_source_disasm_command, show_data, init_and_make_win)
1190         (show_source_or_disasm_and_command): Update.
1191         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1192         method.
1193         <can_highight, is_highlighted>: Now bool.
1194         (tui_set_win_highlight): Don't declare.
1195         * tui/tui-data.c (tui_set_win_highlight): Remove.
1196
1197 2019-06-25  Tom Tromey  <tom@tromey.com>
1198
1199         * tui/tui-wingeneral.c (make_visible): Remove check of window
1200         type.
1201
1202 2019-06-25  Tom Tromey  <tom@tromey.com>
1203
1204         * tui/tui-win.c (tui_win_info::max_height)
1205         (tui_cmd_window::max_height): New methods.
1206         (new_height_ok): Call max_height.
1207         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1208         <max_height>: New method.
1209
1210 2019-06-25  Tom Tromey  <tom@tromey.com>
1211
1212         * tui/tui-win.c (tui_source_window_base::set_new_height)
1213         (tui_data_window::set_new_height): New methods.
1214         (make_invisible_and_set_new_height): Call set_new_height method.
1215         * tui/tui-data.h (struct tui_win_info)
1216         (struct tui_source_window_base, struct tui_data_window)
1217         <set_new_height>: New method.
1218
1219 2019-06-25  Tom Tromey  <tom@tromey.com>
1220
1221         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1222         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1223         tui_refresh_data_win.
1224         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1225         method.
1226         (tui_refresh_all_win): Call the refresh_all method.
1227         (tui_set_focus): Likewise.
1228         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1229         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1230         Likewise.
1231
1232 2019-06-25  Tom Tromey  <tom@tromey.com>
1233
1234         * tui/tui-winsource.h (tui_refill_source_window)
1235         (tui_set_is_exec_point_at): Don't declare.
1236         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1237         (tui_source_window_base::refill): Rename from
1238         tui_refill_source_window.
1239         (tui_source_window_base::do_scroll_horizontal): Update.
1240         (tui_source_window_base::set_is_exec_point_at): Rename from
1241         tui_set_is_exec_point_at.
1242         (tui_update_all_breakpoint_info): Update.
1243         * tui/tui-stack.c (tui_show_frame_info): Update.
1244         * tui/tui-layout.c (show_data): Add cast.
1245         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1246         * tui/tui-data.h (struct tui_source_window_base) <refill,
1247         set_is_exec_point_at>: New methods.
1248         (tui_source_windows, tui_add_to_source_windows): Update types.
1249         (tui_add_to_source_windows): Remove redundant declaration.
1250         * tui/tui-data.c (source_windows): Store tui_source_window_base.
1251         (tui_source_windows): Change return type.
1252         (tui_clear_source_windows_detail): Update.
1253         (tui_add_to_source_windows): Change type of parameter.
1254         (tui_free_all_source_wins_content): Update.
1255
1256 2019-06-25  Tom Tromey  <tom@tromey.com>
1257
1258         * tui/tui-wingeneral.c (tui_win_info::refresh)
1259         (tui_source_window_base::refresh): New methods.
1260         (tui_refresh_all): Call the refresh method.
1261         * tui/tui-data.h (struct tui_win_info)
1262         (struct tui_source_window_base) <refresh>: New method.
1263
1264 2019-06-25  Tom Tromey  <tom@tromey.com>
1265
1266         * tui/tui.h (tui_is_window_visible): Return bool.
1267         * tui/tui.c (tui_is_window_visible): Return bool.
1268         * tui/tui-wingeneral.c (tui_make_window, make_visible)
1269         (tui_make_visible, tui_make_invisible)
1270         (tui_win_info::make_visible)
1271         (tui_source_window_base::make_visible, make_all_visible)
1272         (tui_make_all_visible, tui_make_all_invisible): Update.
1273         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
1274         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
1275         bool.
1276         (struct tui_win_info, struct tui_source_window_base)
1277         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
1278         * tui/tui-data.c (tui_init_generic_part): Update.
1279
1280 2019-06-25  Tom Tromey  <tom@tromey.com>
1281
1282         * tui/tui-wingeneral.c (tui_win_info::make_visible)
1283         (tui_source_window_base::make_visible): New methods.
1284         (make_all_visible): Make method call.
1285         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
1286         (struct tui_source_window_base, struct tui_cmd_window): Override
1287         make_visible.
1288         (tui_win_is_source_type): Don't declare.
1289         * tui/tui-data.c (tui_win_is_source_type): Remove.
1290
1291 2019-06-25  Tom Tromey  <tom@tromey.com>
1292
1293         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
1294         NULL check.
1295
1296 2019-06-25  Tom Tromey  <tom@tromey.com>
1297
1298         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
1299         Inline constructor.  Add initializers for members.
1300         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
1301         constructors; now inline in class.
1302
1303 2019-06-25  Tom Tromey  <tom@tromey.com>
1304
1305         * tui/tui-regs.c (tui_show_registers): Update.
1306         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
1307         bool.
1308         * tui/tui-data.c (tui_data_window::clear_detail)
1309         (tui_data_window): Update.
1310
1311 2019-06-25  Tom Tromey  <tom@tromey.com>
1312
1313         * tui/tui-windata.c (tui_display_all_data)
1314         (tui_display_data_from_line, tui_display_data_from)
1315         (tui_check_data_values, tui_data_window::do_scroll_vertical):
1316         Update.
1317         * tui/tui-regs.c (tui_last_regs_line_no)
1318         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1319         (tui_show_registers, tui_show_register_group)
1320         (tui_display_registers_from, tui_display_reg_element_at_line)
1321         (tui_display_registers_from_line, tui_check_register_values)
1322         (tui_reg_next, tui_reg_prev): Update.
1323         * tui/tui-layout.c (tui_set_layout, show_data): Update.
1324         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
1325         tui_data_window.
1326         (struct tui_win_info) <detail>: Remove.  Add new fields from
1327         tui_data_info.
1328         (TUI_DATA_WIN): Add cast.
1329         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
1330         (~tui_data_window): Simplify.
1331
1332 2019-06-25  Tom Tromey  <tom@tromey.com>
1333
1334         * tui/tui-layout.c (show_source_disasm_command)
1335         (show_source_or_disasm_and_command): Update.
1336         * tui/tui-io.c (update_cmdwin_start_line)
1337         (tui_redisplay_readline): Update.
1338         * tui/tui-data.h (struct tui_command_info): Remove.
1339         (struct tui_win_info) <detail>: Remove command_info member.
1340         (struct tui_data_window) <start_line>: New member, from
1341         tui_command_info.
1342         (TUI_CMD_WIN): Add casts.
1343
1344 2019-06-25  Tom Tromey  <tom@tromey.com>
1345
1346         * tui/tui-winsource.c (tui_update_source_window)
1347         (tui_refill_source_window)
1348         (tui_source_window_base::do_scroll_horizontal)
1349         (tui_update_breakpoint_info, tui_set_exec_info_content)
1350         (tui_show_exec_info_content, tui_erase_exec_info_content)
1351         (tui_clear_exec_info_content): Update.
1352         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
1353         Update.
1354         * tui/tui-win.c (make_invisible_and_set_new_height)
1355         (make_visible_with_new_height): Update.
1356         * tui/tui-source.c (tui_set_source_content)
1357         (tui_show_symtab_source): Update.
1358         * tui/tui-layout.c (extract_display_start_addr)
1359         (show_source_disasm_command, show_data)
1360         (make_source_or_disasm_window)
1361         (show_source_or_disasm_and_command): Update.
1362         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
1363         (tui_disasm_window::do_scroll_vertical): Remove shadowing
1364         "gdbarch".
1365         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
1366         to tui_source_window_base.
1367         (struct tui_win_info) <detail>: Remove source_info member.
1368         (struct tui_source_window_base) <has_locator>: Inline.
1369         Move contents from tui_source_info; rename has_locator member to
1370         m_has_locator.
1371         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
1372         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
1373         header file.
1374         (tui_source_window_base::clear_detail, ~tui_source_window_base):
1375         Simplify.
1376         (tui_free_all_source_wins_content): Cast to
1377         tui_source_window_base.
1378
1379 2019-06-25  Tom Tromey  <tom@tromey.com>
1380
1381         * tui/tui-win.c (make_invisible_and_set_new_height)
1382         (make_visible_with_new_height): Call has_locator method.
1383         * tui/tui-layout.c (show_source_disasm_command, show_data)
1384         (show_source_or_disasm_and_command): Update for bool change.
1385         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
1386         (tui_win_info) <has_locator>: New method.
1387         (struct tui_source_window_base) <has_locator>: New method.
1388         (tui_win_has_locator): Don't declare.
1389         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
1390         from tui_win_has_locator.
1391         (tui_source_window_base): Use false, not FALSE.
1392
1393 2019-06-25  Tom Tromey  <tom@tromey.com>
1394
1395         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
1396         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
1397         clear_detail method directly.
1398         (tui_clear_win_detail): Remove.
1399
1400 2019-06-25  Tom Tromey  <tom@tromey.com>
1401
1402         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
1403         "this", not TUI_DISASM_WIN.
1404
1405 2019-06-25  Tom Tromey  <tom@tromey.com>
1406
1407         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
1408         declare.
1409         * tui/tui-winsource.c
1410         (tui_source_window_base::do_scroll_horizontal): Rename from
1411         tui_horizontal_source_scroll.
1412         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
1413         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
1414         from tui_vertical_data_scroll.
1415         * tui/tui-win.h (tui_scroll): Don't declare.
1416         * tui/tui-win.c (tui_win_info::forward_scroll)
1417         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1418         (tui_win_info::right_scroll): Rename and update.
1419         (tui_scroll_forward_command, tui_scroll_backward_command)
1420         (tui_scroll_left_command, tui_scroll_right_command): Update.
1421         (tui_scroll): Remove.
1422         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
1423         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
1424         from tui_vertical_source_scroll.
1425         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
1426         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
1427         from tui_vertical_disassem_scroll.
1428         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
1429         do_scroll_horizontal>: New methods.
1430         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
1431         Likewise.
1432         (struct tui_source_window_base): Add do_scroll_horizontal.
1433         (struct tui_source_window, struct tui_disasm_window): Add
1434         do_scroll_vertical.
1435         (struct tui_data_window, struct tui_cmd_window): Add
1436         do_scroll_horizontal and do_scroll_vertical.
1437         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
1438
1439 2019-06-25  Tom Tromey  <tom@tromey.com>
1440
1441         * tui/tui-data.h (struct tui_source_window_base): New struct.
1442         (struct tui_source_window): Derive from tui_source_window_base.
1443         (struct tui_disasm_window): New struct.
1444         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
1445         from tui_source_window::clear_detail.
1446         (tui_source_window_base): Rename from tui_source_window.
1447         (~tui_source_window_base): Rename from ~tui_source_window.
1448         (tui_alloc_win_info): Create a tui_disasm_window.
1449
1450 2019-06-25  Tom Tromey  <tom@tromey.com>
1451
1452         * tui/tui-data.h (struct tui_source_window)
1453         (struct tui_data_window): Declare destructors.
1454         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
1455         destructors.
1456         (tui_win_info): Simplify.
1457
1458 2019-06-25  Tom Tromey  <tom@tromey.com>
1459
1460         * tui/tui-winsource.c (tui_display_main)
1461         (tui_update_source_windows_with_addr)
1462         (tui_update_all_breakpoint_info): Update.
1463         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1464         (new_height_ok, parse_scrolling_args): Update.
1465         * tui/tui-stack.c (tui_show_frame_info): Update.
1466         * tui/tui-data.h (struct tui_list): Remove.
1467         (tui_source_windows): Return a reference to a std::vector.
1468         * tui/tui-data.c (source_windows): Now a std::vector.
1469         (tui_source_windows): Change return type.
1470         (tui_clear_source_windows): Rewrite.
1471         (tui_clear_source_windows_detail, tui_add_to_source_windows)
1472         (tui_free_all_source_wins_content): Rewrite.
1473
1474 2019-06-25  Tom Tromey  <tom@tromey.com>
1475
1476         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
1477         (struct tui_data_window, struct tui_cmd_window): Declare
1478         clear_detail method.
1479         * tui/tui-data.c (tui_source_window::clear_detail)
1480         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
1481         methods.
1482         (tui_clear_win_detail): Simplify.
1483
1484 2019-06-25  Tom Tromey  <tom@tromey.com>
1485
1486         * tui/tui-layout.c (make_source_window, make_disasm_window)
1487         (make_source_or_disasm_window): Remove win_info_ptr parameter.
1488         Return the new window.
1489         (show_source_disasm_command, show_data)
1490         (show_source_or_disasm_and_command): Update.
1491
1492 2019-06-25  Tom Tromey  <tom@tromey.com>
1493
1494         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
1495         parameter.  Return the new window.
1496         (show_source_disasm_command): Update and remove NULL check.
1497         (show_source_or_disasm_and_command): Update.
1498
1499 2019-06-25  Tom Tromey  <tom@tromey.com>
1500
1501         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
1502
1503 2019-06-25  Tom Tromey  <tom@tromey.com>
1504
1505         * tui/tui-data.h (struct tui_win_info): Make constructor
1506         protected.  Make destructor virtual.  Add initializers.
1507         (tui_source_window, tui_data_window, tui_cmd_window): New
1508         classes.
1509         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
1510         constructor.  Add "type" parameter.
1511         (tui_source_window, tui_data_window, tui_cmd_window): New
1512         constructors.
1513         (tui_alloc_win_info): Instantiate the appropriate subclass.
1514
1515 2019-06-25  Tom Tromey  <tom@tromey.com>
1516
1517         * tui/tui-win.c (tui_resize_all): Use delete.
1518         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
1519         destructor.
1520         (tui_free_window): Don't declare.
1521         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
1522         Update.
1523
1524 2019-06-25  Tom Tromey  <tom@tromey.com>
1525
1526         * tui/tui-data.h (struct tui_win_info): Add constructor.
1527         * tui/tui-data.c (tui_alloc_win_info): Use new.
1528         (tui_free_window): Use delete.
1529
1530 2019-06-22  Tom Tromey  <tom@tromey.com>
1531
1532         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
1533         declare.
1534         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
1535
1536 2019-06-22  Tom Tromey  <tom@tromey.com>
1537
1538         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
1539         declare.
1540         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
1541
1542 2019-06-22  Tom de Vries  <tdevries@suse.de>
1543
1544         * dwarf2read.c (create_addrmap_from_aranges)
1545         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
1546         instead of '%zu'.
1547
1548 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
1549
1550         * dwarf2read.h (dwarf2_section_info_def): Remove.
1551         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
1552         * dwarf2read.c (struct dwo_sections) <types>: Change type to
1553         std::vector<dwarf2_section_info>.
1554         (struct dwo_file) <~dwo_file>: Remove.
1555         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
1556         types field.
1557         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
1558         (dwarf2_read_debug_names): Likewise.
1559         (create_debug_types_hash_table): Change parameter type to
1560         array_view, adjust code accordingly.
1561         (dwarf2_locate_dwo_sections): Adjust to std::vector.
1562         (partial_die_info::fixup): Likewise.
1563         (determine_prefix): Likewise.
1564         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
1565
1566 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1567
1568         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
1569         gdb_bfd_ref_ptr.
1570         <~dwo_file>: Remove call to gdb_bfd_unref.
1571         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
1572         gdb_bfd_ref_ptr::get.
1573
1574 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1575
1576         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
1577         type to htab_up.
1578         * dwarf2read.c (struct dwo_file): Initialize fields.
1579         <~dwo_file>: New.
1580         (free_dwo_file): Remove, move content to ~dwo_file.
1581         (struct dwo_file_deleter): Remove.
1582         (dwo_file_up>: Remove custom deleter.
1583         (free_dwo_files): Remove.
1584         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
1585         dwo_files.
1586         (process_skeletonless_type_units): Call unique_ptr::get.
1587         (allocate_dwo_file_hash_table): Add deleter to created hash
1588         table.  Change return type to htab_up.
1589         (lookup_dwo_file_slot): Don't memset dwo_file, call
1590         unique_ptr::get.
1591         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
1592         (create_dwo_unit_in_dwp_v2): Likewise.
1593         (open_and_init_dwo_file): Likewise.
1594         (free_dwo_file_from_slot): Remove.
1595
1596 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1597
1598         * dwarf2read.h (struct dwarf2_section_info) <readin,
1599         is_virtual>: Change type to bool.
1600         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
1601         true instead of 1.
1602
1603 2019-06-19  Tom Tromey  <tom@tromey.com>
1604
1605         * tui/tui-data.h (tui_init_content_element): Don't declare.
1606
1607 2019-06-19  Tom Tromey  <tom@tromey.com>
1608
1609         * tui/tui-data.h (tui_init_win_info): Don't declare.
1610
1611 2019-06-19  Tom de Vries  <tdevries@suse.de>
1612
1613         * dwarf2read.h (abstract_to_concrete): Change type to
1614         std::unordered_map<sect_offset, std::vector<sect_offset>,
1615         gdb::hash_enum<sect_offset>>.
1616
1617 2019-06-19  Tom Tromey  <tromey@adacore.com>
1618
1619         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
1620         EVAL_AVOID_SIDE_EFFECTS specially.
1621
1622 2019-06-19  Tom Tromey  <tromey@adacore.com>
1623
1624         * source-cache.c (highlighter): New global.
1625         (source_cache::get_source_lines): Create a highlighter on demand.
1626
1627 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1628
1629         * defs.h (deprecated_interactive_hook): Delete declaration.
1630         * interps.c (clear_interpreter_hooks): Remove use of
1631         deprecated_interactive_hook.
1632         * top.c (deprecated_interactive_hook): Delete definition.
1633         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
1634
1635 2019-06-18  Tom de Vries  <tdevries@suse.de>
1636
1637         PR gdb/24515
1638         * dwarf2read.h (abstract_to_concrete): Change type from
1639         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
1640         std::unordered_map<sect_offset, std::vector<sect_offset>>.
1641         * dwarf2read.c (read_variable): Update.
1642         (dwarf2_fetch_die_loc_sect_off): Update.
1643
1644 2019-06-17  Tom de Vries  <tdevries@suse.de>
1645
1646         PR gdb/24617
1647         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
1648         accessing parent[parent_len - 1].
1649
1650 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
1651
1652         PR gdb/24364
1653         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
1654         call dtrace_process_dof with NULL dof.
1655
1656 2019-06-16  Tom de Vries  <tdevries@suse.de>
1657
1658         PR gdb/24445
1659         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
1660
1661 2019-06-16  Tom Tromey  <tom@tromey.com>
1662
1663         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1664         (make_all_visible): Use address of member.
1665
1666 2019-06-16  Tom Tromey  <tom@tromey.com>
1667
1668         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
1669         (tui_free_window, free_content, free_content_elements): Remove
1670         unnecessary cast.
1671         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
1672         cast.
1673         * tui/tui-regs.c (tui_show_register_group)
1674         (tui_display_registers_from, tui_display_reg_element_at_line):
1675         Remove unnecessary cast.
1676
1677 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
1678
1679         * linux-nat.c (normal_mask): Delete.
1680         (_initialize_linux_nat): Don't initialise normal_mask.
1681
1682 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
1683
1684         PR gdb/24445
1685         * dwarf-index-write.h (write_psymtabs_to_index): Add
1686         dwz_basename parameter.
1687         * dwarf-index-write.c (write_gdbindex): Move file writing to
1688         write_gdbindex_1.  Change return type void.
1689         (assert_file_size): Move up, remove filename parameter.
1690         (write_gdbindex_1): New function.
1691         (write_debug_names): Change return type to void, call
1692         assert_file_size.
1693         (struct index_wip_file): New struct.
1694         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
1695         file logic to index_wip_file.  Write index for dwz file if
1696         needed.
1697         (save_gdb_index_command): Pass basename of dwz file, if present.
1698         * dwarf-index-cache.c (index_cache::store): Obtain and pass
1699         build-id of dwz file, if present.
1700         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
1701         (dwarf2_get_dwz_file): Likewise.
1702         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
1703         (dwarf2_get_dwz_file): Likewise.
1704
1705 2019-06-16  Tom Tromey  <tom@tromey.com>
1706
1707         * coffread.c (process_coff_symbol): Use xstrdup.
1708         * value.c (create_internalvar): Use xstrdup.
1709
1710 2019-06-16  Tom Tromey  <tom@tromey.com>
1711
1712         * valops.c (value_cast, value_slice): Remove unnecessary cast.
1713         * breakpoint.c (stopin_command, stopat_command)
1714         (until_break_command, decode_location_default): Remove unnecessary
1715         cast.
1716         * utils.c (subset_compare): Remove unnecessary cast.
1717         * ada-lang.c (ada_update_initial_language): Remove unnecessary
1718         cast.
1719         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
1720         cast.
1721         * infcmd.c (path_command): Remove unnecessary cast.
1722         * coffread.c (decode_type): Remove unnecessary cast.
1723         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
1724         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
1725         * tui/tui-stack.c (tui_show_locator_content)
1726         (tui_show_frame_info): Remove unnecessary cast.
1727         * tui/tui-win.c (tui_scroll_forward_command)
1728         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
1729         (parse_scrolling_args): Remove unnecessary cast.
1730         * tui/tui-data.c (init_win_info, tui_del_window)
1731         (tui_free_window, tui_del_data_windows, tui_free_data_content)
1732         (free_content_elements): Remove unnecessary cast.
1733         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
1734         unnecessary cast.
1735         * tui/tui-source.c (tui_set_source_content)
1736         (tui_vertical_source_scroll): Remove unnecessary cast.
1737         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
1738         cast.
1739         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
1740         * tui/tui-regs.c (tui_display_registers_from)
1741         (tui_display_register): Remove unnecessary cast.
1742         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
1743         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
1744         (make_visible): Remove unnecessary cast.
1745         * tui/tui-winsource.c (tui_erase_source_content)
1746         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
1747         unnecessary cast.
1748         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
1749         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
1750         * stabsread.c (read_type, read_array_type, read_range_type):
1751         Remove unnecessary cast.
1752         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
1753         (parse_symbol, parse_type, upgrade_type, parse_external)
1754         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
1755         unnecessary cast.
1756         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
1757
1758 2019-06-16  Tom Tromey  <tom@tromey.com>
1759
1760         * tui/tui-data.c (tui_alloc_generic_win_info)
1761         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
1762         checks.
1763
1764 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
1765             Andrew Burgess  <andrew.burgess@embecosm.com>
1766
1767         * f-typeprint.c (f_print_type): Don't return early for not
1768         associated or not allocated types.
1769         (f_type_print_varspec_suffix): Add print_rank parameter and print
1770         ranks of array types in case they dangling.
1771         (f_type_print_base): Add print_rank parameter.
1772
1773 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1774
1775         * NEWS: Mention new MI commands.
1776         * break-catch-throw.c (enum exception_event_kind): Move to
1777         breakpoint.h.
1778         (print_mention_exception_catchpoint): Output text as a single
1779         message.
1780         (catch_exception_command_1): Rename to...
1781         (catch_exception_event): ...this, make non-static, update header
1782         command, and change some parameter types.
1783         (catch_catch_command): Update for changes to
1784         catch_exception_command_1.
1785         (catch_throw_command): Likewise.
1786         (catch_rethrow_command): Likewise.
1787         * breakpoint.c (enum exception_event_kind): Delete.
1788         * breakpoint.h (enum exception_event_kind): Moved here from
1789         break-catch-throw.c.
1790         (catch_exception_event): Declare.
1791         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
1792         (mi_cmd_catch_throw): New function.
1793         (mi_cmd_catch_rethrow): New function.
1794         (mi_cmd_catch_catch): New function.
1795         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
1796         'catch-catch' entries.
1797         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
1798         (mi_cmd_catch_rethrow): Declare.
1799         (mi_cmd_catch_catch): Declare.
1800
1801 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1802
1803         * annotate.c (annotate_source_line): Change return type to void,
1804         update implementation to match.
1805         * annotate.h (annotate_source_line): Change return type to void,
1806         update header comment.
1807         * stack.c (print_frame_info): Don't change what frame information
1808         is printed based on whether annotations are on or not.
1809
1810 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1811
1812         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
1813         (annotate_source): Make static.
1814         (annotate_source_line): Moved from source.c and renamed from
1815         identify_source_line.  Update the return type.
1816         * annotate.h (annotate_source): Delete declaration.
1817         (annotate_source_line): Declaration moved from source.h, and
1818         renamed from identify_source_line.  Return type updated.
1819         * source.c (identify_source_line): Moved to annotate.c and renamed
1820         to annotate_source_line.
1821         (info_line_command): Remove check of annotation_level.
1822         * source.h (identify_source_line): Move declaration to annotate.h
1823         and rename to annotate_source_line.
1824         * stack.c: Add 'annotate.h' include.
1825         (print_frame_info): Remove check of annotation_level before
1826         calling annotate_source_line.
1827
1828 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1829
1830         * source-cache.c (source_cache::get_plain_source_lines): Use
1831         open_source_file_with_line_charpos instead of just
1832         open_source_file, remove call to find_source_lines.
1833         (source_cache::get_source_lines): Likewise.
1834         * source.c (find_source_lines): Make static.
1835         (get_filename_and_charpos): Renamed into...
1836         (open_source_file_with_line_charpos): ..this along with changes to
1837         return a scoped_fd, and some other minor clean ups.
1838         (identify_source_line): Use open_source_file_with_line_charpos.
1839         (search_command_helper): Use open_source_file_with_line_charpos
1840         instead of just open_source_file, remove call to
1841         find_source_lines.
1842         * source.h (open_source_file_with_line_charpos): Declare new
1843         function.
1844         (find_source_lines): Delete declaration.
1845
1846 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1847
1848         * source.c (get_filename_and_charpos): Remove fullname
1849         parameter.
1850         (identify_source_line): Update call to get_filename_and_charpos.
1851
1852 2019-06-14  Tom Tromey  <tromey@adacore.com>
1853
1854         PR gdb/24502:
1855         * ui-style.h (skip_ansi_escape): Update comment.
1856         * ui-file.h (class no_terminal_escape_file): New class.
1857         * ui-file.c (no_terminal_escape_file::write)
1858         (no_terminal_escape_file::puts): New methods.
1859         * cli/cli-logging.c (handle_redirections): Use
1860         no_terminal_escape_file.
1861
1862 2019-06-14  Tom Tromey  <tromey@adacore.com>
1863
1864         * NEWS: Move convenience variable news above Python news.
1865
1866 2019-06-14  Tom Tromey  <tom@tromey.com>
1867
1868         * gnulib: Move directory to top-level.
1869         * configure.ac: Don't configure gnulib.
1870         * configure: Rebuild.
1871         * common/common-defs.h: Use new path to gnulib.
1872         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
1873         (GNULIB_H): Remove.
1874         (INCGNU): Look in new gnulib location.
1875         (HFILES_NO_SRCDIR): Remove gnulib files.
1876         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
1877         (generated_files): Remove GNULIB_H.
1878         ($(LIBGNU), all-lib): Remove targets.
1879         (distclean): Don't mention GNULIB_BUILDDIR.
1880         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
1881
1882 2019-06-14  Tom Tromey  <tromey@adacore.com>
1883
1884         * symfile.c (add_symbol_file_command): Remove obsolete comment.
1885         Warn if symbol file does not provide any symbols.
1886
1887 2019-06-14  Tom Tromey  <tromey@adacore.com>
1888
1889         * source.c (find_and_open_source): Respect basenames_may_differ.
1890
1891 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
1892
1893         * annotate.c (annotate_breakpoints_invalid): Make use of
1894         scoped_restore_terminal_state.
1895         (annotate_frames_invalid): Likewise.
1896
1897 2019-06-14  Tom Tromey  <tromey@adacore.com>
1898
1899         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
1900         allow assignment to an internalvar.
1901
1902 2019-06-14  Tom Tromey  <tromey@adacore.com>
1903
1904         * ada-lex.l: Allow "_" in attribute names.
1905
1906 2019-06-14  Tom Tromey  <tromey@adacore.com>
1907
1908         PR gdb/24653:
1909         * regcache.c (registers_changed): Don't call alloca.
1910         * top.c (execute_command): Don't call alloca.
1911
1912 2019-06-13  Pedro Alves  <palves@redhat.com>
1913
1914         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
1915         'expression'.  When parsing an expression, error out if there's
1916         junk after "unlimited".
1917         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1918         (do_set_command): Adjust calls to is_unlimited_literal.
1919
1920 2019-06-13  Pedro Alves  <palves@redhat.com>
1921
1922         * compile/compile.c (make_compile_options_def_group): Add braces
1923         around array_view initializer.
1924         * thread.c (make_thread_apply_all_options_def_group)
1925         (make_thread_apply_all_options_def_group): Likewise.
1926
1927 2019-06-13  Pedro Alves  <palves@redhat.com>
1928
1929         * NEWS (New commands): Mention "maint test-options
1930         require-delimiter", "maint test-options unknown-is-error", "maint
1931         test-options unknown-is-operand" and "maint show
1932         test-options-completion-result".
1933         (New command options, command completion): New section.
1934         (Completion improvements): New section.
1935         Mention that you can abbreviate "unlimited".
1936
1937 2019-06-13  Pedro Alves  <palves@redhat.com>
1938
1939         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
1940         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
1941         * unittests/cli-utils-selftests.c (test_parse_flags)
1942         (test_parse_flags_qcs): Delete.
1943         (test_cli_utils): Don't call deleted functions.
1944
1945 2019-06-13  Pedro Alves  <palves@redhat.com>
1946
1947         * thread.c: Include "cli/cli-option.h".
1948         (tp_array_compar_ascending): Global.
1949         (tp_array_compar): Delete function.
1950         (tp_array_compar_ascending, tp_array_compar_descending): New
1951         functions.
1952         (ascending_option_def, qcs_flag_option_def)
1953         (thr_qcs_flags_option_defs)
1954         (make_thread_apply_all_options_def_group)
1955         (make_thread_apply_options_def_group): New.
1956         (thread_apply_all_command): Use gdb::option::process_options.
1957         (thread_apply_command_completer)
1958         (thread_apply_all_command_completer): New.
1959         (thread_apply_command): Use gdb::option::process_options.
1960         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
1961         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
1962         to generate help text of "thread apply".  Adjust "taas"'s help.
1963         * tid-parse.c (tid_range_parser::in_thread_range): New method.
1964         * tid-parse.h (tid_range_parser::in_thread_range): New method.
1965
1966 2019-06-13  Pedro Alves  <palves@redhat.com>
1967
1968         * thread.c (thread_apply_command): Check for invalid TID with
1969         isdigit instead of !isalpha.
1970
1971 2019-06-13  Pedro Alves  <palves@redhat.com>
1972
1973         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
1974         (validate_flags_qcs): New.
1975         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
1976         (validate_flags_qcs): Declare.
1977         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
1978         (make_frame_apply_options_def_group): New.
1979         (frame_apply_command_count): Process options with
1980         gdb::option::process_options.
1981         (frame_apply_completer): New.
1982         (frame_apply_level_completer, frame_apply_all_completer)
1983         (frame_apply_completer): New.
1984         (_initialize_stack): Update help of "frame apply", "frame apply
1985         level", "frame apply all" and "faas" to mention supported options
1986         and install command completers.
1987         * stack.h (frame_apply_all_completer): Declare.
1988         * thread.c: Include "stack.h".
1989         (tfaas_command): Add "--".
1990         (_initialize_thread): Update help "tfaas" to mention supported
1991         options and install command completer.
1992
1993 2019-06-13  Pedro Alves  <palves@redhat.com>
1994
1995         * completer.c (complete_nested_command_line): New.
1996         (gdb_completion_word_break_characters_throw): Add assertion.
1997         * completer.h (complete_nested_command_line): Declare.
1998
1999 2019-06-13  Pedro Alves  <palves@redhat.com>
2000
2001         * stack.c (parse_backtrace_qualifiers): New.
2002         (backtrace_command): Use it.
2003         (backtrace_command_completer): Complete on qualifiers.
2004
2005 2019-06-13  Pedro Alves  <palves@redhat.com>
2006
2007         * frame.c: Include "cli/cli-option.h.
2008         (user_set_backtrace_options): New.
2009         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2010         Delete.
2011         (get_prev_frame): Adjust.
2012         (boolean_option_def, uinteger_option_def)
2013         (set_backtrace_option_defs): New.
2014         (_initialize_frame): Adjust and use
2015         gdb::option::add_setshow_cmds_for_options to install "set
2016         backtrace past-main" and "set backtrace past-entry".
2017         * frame.h: Include "cli/cli-option.h".
2018         (struct frame_print_options): Forward declare.
2019         (print_frame_arguments_all, print_frame_arguments_scalars)
2020         (print_frame_arguments_none): Declare.
2021         (print_entry_values): Delete declaration.
2022         (struct frame_print_options, user_frame_print_options): New.
2023         (struct set_backtrace_options): New.
2024         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2025         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2026         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2027         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2028         (list_args_or_locals): Add frame_print_options parameter.
2029         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2030         * python/py-framefilter.c (enumerate_args): Pass down
2031         USER_FRAME_PRINT_OPTIONS.
2032         * stack.c: Include "cli/cli-option.h".
2033         (print_frame_arguments_all, print_frame_arguments_scalars)
2034         (print_frame_arguments_none): Declare.
2035         (print_raw_frame_arguments, print_entry_values): Delete.
2036         (user_frame_print_options): New.
2037         (boolean_option_def, enum_option_def, frame_print_option_defs):
2038         New.
2039         (struct backtrace_cmd_options): New.
2040         (bt_flag_option_def): New.
2041         (backtrace_command_option_defs): New.
2042         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2043         (print_frame_arg, read_frame_arg, print_frame_args)
2044         (print_frame_info, print_frame): Add frame_print_options parameter
2045         and use it.
2046         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2047         (backtrace_command_1): Add frame_print_options and
2048         backtrace_cmd_options parameters and use them.
2049         (make_backtrace_options_def_group): New.
2050         (backtrace_command): Process command options with
2051         gdb::option::process_options.
2052         (backtrace_command_completer): New.
2053         (_initialize_stack): Extend "backtrace"'s help to mention
2054         supported options.  Install completer for "backtrace".
2055         Install some settings commands with add_setshow_cmds_for_options.
2056
2057 2019-06-13  Pedro Alves  <palves@redhat.com>
2058
2059         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2060         and that "set/show print raw frame-arguments" are now deprecated.
2061
2062         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2063         command.
2064         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2065         * stack.c (_initialize_stack): Install "set/show print
2066         raw-frame-arguments", and deprecate "set/show print raw
2067         frame-arguments".
2068         * valprint.c (_initialize_valprint): Deprecate "set/show print
2069         raw".
2070
2071 2019-06-13  Pedro Alves  <palves@redhat.com>
2072
2073         * compile/compile.c (struct compile_options): New.
2074         (compile_flag_option_def, compile_command_option_defs)
2075         (make_compile_options_def_group): New.
2076         (compile_file_command): Handle options with
2077         gdb::option::process_options.
2078         (compile_file_command_completer): New function.
2079         (compile_code_command): Handle options with
2080         gdb::option::process_options.
2081         (compile_code_command_completer): New function.
2082         (_initialize_compiler): Install completers for "compile code" and
2083         "compile file".  Mention available options in "compile code" and
2084         "compile code"'s help.
2085         * completer.c (advance_to_completion_word): New, factored out from
2086         ...
2087         (advance_to_expression_complete_word_point): ... this.
2088         (advance_to_filename_complete_word_point): New.
2089         * completer.h (advance_to_filename_complete_word_point): New
2090         declaration.
2091
2092 2019-06-13  Pedro Alves  <palves@redhat.com>
2093
2094         * compile/compile.c: Include "cli/cli-option.h".
2095         (compile_print_value): Scope data pointer is now a
2096         value_print_options pointer; adjust.
2097         (compile_print_command): Process options.  Scope data pointer is
2098         now a value_print_options pointer; adjust.
2099         (_initialize_compile): Update "compile print"'s help to include
2100         supported options.  Install a completer for "compile print".
2101         * cp-valprint.c (show_vtblprint, show_objectprint)
2102         (show_static_field_print): Delete.
2103         (_initialize_cp_valprint): Don't install "set print
2104         static-members", "set print vtbl", "set print object" here.
2105         * printcmd.c: Include "cli/cli-option.h" and
2106         "common/gdb_optional.h".
2107         (print_command_parse_format): Rework to fill in a
2108         value_print_options instead of a format_data.
2109         (print_value): Change parameter type from format_data pointer to
2110         value_print_options reference.  Adjust.
2111         (print_command_1): Process options.  Adjust to pass down a
2112         value_print_options.
2113         (print_command_completer): New.
2114         (_initialize_printcmd): Install print_command_completer as
2115         handle_brkchars completer for the "print" command.  Update
2116         "print"'s help to include supported options.
2117         * valprint.c: Include "cli/cli-option.h".
2118         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2119         here from cp-valprint.c.
2120         (boolean_option_def, uinteger_option_def)
2121         (value_print_option_defs, make_value_print_options_def_group):
2122         New.  Use gdb::option::add_setshow_cmds_for_options to install
2123         "set print elements", "set print null-stop", "set print repeats",
2124         "set print pretty", "set print union", "set print array", "set
2125         print address", "set print symbol", "set print array-indexes".
2126         * valprint.h: Include <string> and "cli/cli-option.h".
2127         (make_value_print_options_def_group): Declare.
2128         (print_value): Change parameter type from format_data pointer to
2129         value_print_options reference.
2130         (print_command_completer): Declare.
2131
2132 2019-06-13  Pedro Alves  <palves@redhat.com>
2133
2134         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2135         (COMMON_SFILES): Add maint-test-settings.c.
2136         * cli/cli-decode.c (boolean_enums): New global, factored out from
2137         ...
2138         (add_setshow_boolean_cmd): ... here.
2139         * cli/cli-decode.h (boolean_enums): Declare.
2140         * cli/cli-option.c: New file.
2141         * cli/cli-option.h: New file.
2142         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2143         factored out from ...
2144         (parse_cli_boolean_value(const char *)): ... this.
2145         (is_unlimited_literal): Change parameter type to pointer to
2146         pointer.  Adjust and advance ARG pointer.
2147         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2148         (parse_cli_var_enum): New, factored out from ...
2149         (do_set_command): ... this.  Adjust.
2150         * cli/cli-setshow.h (parse_cli_boolean_value)
2151         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2152         (parse_cli_var_enum): Declare.
2153         * cli/cli-utils.c: Include "cli/cli-option.h".
2154         (get_ulongest): New.
2155         * cli/cli-utils.h (get_ulongest): Declare.
2156         (check_for_argument): New overloads.
2157         * maint-test-options.c: New file.
2158
2159 2019-06-13  Pedro Alves  <palves@redhat.com>
2160
2161         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2162         parse a range if "-" is at the end of the string.
2163
2164 2019-06-13  Pedro Alves  <palves@redhat.com>
2165
2166         * cli/cli-setshow.c (parse_auto_binary_operation)
2167         (parse_cli_boolean_value): Don't allow "o".
2168
2169 2019-06-13  Pedro Alves  <palves@redhat.com>
2170
2171         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2172         * NEWS: Mention maint test-settings KIND.
2173         * maint-test-settings.c: New file.
2174
2175 2019-06-13  Pedro Alves  <palves@redhat.com>
2176
2177         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2178         completer.
2179         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2180         "set" completers.
2181
2182 2019-06-13  Pedro Alves  <palves@redhat.com>
2183
2184         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2185         after item.
2186
2187 2019-06-13  Pedro Alves  <palves@redhat.com>
2188
2189         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2190
2191 2019-06-13  Pedro Alves <palves@redhat.com>
2192
2193         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2194         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2195         call.
2196         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2197         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2198         calls.
2199         (check_for_argument): Skip spaces after argument.
2200
2201 2019-06-13  Pedro Alves  <palves@redhat.com>
2202
2203         * thread.c (thread_apply_command): Adjust TID parsing.
2204         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2205         detected before end of string.
2206         (tid_is_in_list): Error out if LIST is invalid.
2207
2208 2019-06-13  Pedro Alves  <palves@redhat.com>
2209
2210         * completer.c (complete_line_internal_1): Rewind completion word
2211         point.
2212         (completion_tracker::advance_custom_word_point_by): Change
2213         parameter type to int.
2214         * completer.h (completion_tracker::advance_custom_word_point_by):
2215         Likewise.
2216
2217 2019-06-13  Pedro Alves  <palves@redhat.com>
2218
2219         * completer.c (advance_to_completion_word): Handle delimiters.
2220
2221 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2222
2223         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2224
2225 2019-06-11  Tom Tromey  <tom@tromey.com>
2226
2227         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2228         (xmalloc_failed): Move to alloc.c.
2229         * alloc.c: New file.
2230         * Makefile.in (COMMON_SFILES): Add alloc.c.
2231
2232 2019-06-11  Tom Tromey  <tom@tromey.com>
2233
2234         * nat/linux-waitpid.c: Don't include server.h.
2235         (linux_debug): Remove.
2236         (my_waitpid): Update.
2237
2238 2019-06-11  Tom Tromey  <tromey@adacore.com>
2239
2240         * infcall.c (_initialize_infcall): Remove trailing newline from
2241         help.
2242         * user-regs.c (_initialize_user_regs): Remove trailing newline
2243         from help.
2244         * typeprint.c (_initialize_typeprint): Remove trailing newline
2245         from help.
2246         * reverse.c (_initialize_reverse): Remove trailing newlines from
2247         help.
2248         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2249         from help.
2250         * language.c (add_set_language_command): Remove trailing newline
2251         from help.
2252         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2253         help.
2254         * disasm.c (_initialize_disasm): Remove trailing newline from
2255         help.
2256         * top.c (init_main): Remove trailing newline from help.
2257         * interps.c (_initialize_interpreter): Remove trailing newline
2258         from help.
2259         * btrace.c (_initialize_btrace): Remove trailing newlines from
2260         help.
2261         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
2262         from help.
2263         * python/python.c (_initialize_python): Remove trailing newline
2264         from help.
2265         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
2266         help.
2267         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
2268         from help.  Reformat some text.
2269         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
2270         from help.
2271         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
2272         newline from help.
2273
2274 2019-06-11  Tom Tromey  <tromey@adacore.com>
2275
2276         * darwin-nat.c (darwin_decode_exception_message)
2277         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
2278
2279 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2280
2281         * valops.c (value_slice): Check for not allocated or not
2282         associated values.
2283
2284 2019-06-10  Tom de Vries  <tdevries@suse.de>
2285
2286         PR gdb/24618
2287         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
2288         sure an empty slot (defined by a 32-bit zero pair) is recognized as
2289         invalid.
2290
2291 2019-06-10  Tom de Vries  <tdevries@suse.de>
2292
2293         PR gdb/24611
2294         * linespec.c (linespec_lexer_lex_string): Remove incorrect
2295         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
2296
2297 2019-06-10  Tom de Vries  <tdevries@suse.de>
2298
2299         PR symtab/24545
2300         * symtab.c (struct demangled_name_entry): Add language field.
2301         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
2302         static minimal symbol".  Set and use language field.
2303
2304 2019-06-10  Tom Tromey  <tromey@adacore.com>
2305
2306         * ada-lang.c (_initialize_ada_language): Update help text.
2307
2308 2019-06-10  Tom Tromey  <tromey@adacore.com>
2309
2310         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
2311         with a newline.
2312         * guile/guile.c (handle_boot_error): Don't end warning with a
2313         newline.
2314         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
2315         warning with a newline.
2316         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
2317         newline.
2318         (s12z_frame_cache): Likewise.
2319         * dwarf-index-cache.c (index_cache::store): Don't end warning with
2320         a newline.
2321         * solib-svr4.c (disable_probes_interface): Don't end warning with
2322         a newline.
2323         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2324         newline.
2325         * python/python.c (do_finish_initialization): Don't end warning
2326         with a newline.
2327
2328 2019-06-10  Tom Tromey  <tom@tromey.com>
2329
2330         * python/py-breakpoint.c (gdbpy_breakpoint_created)
2331         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
2332         gdbpy_enter.
2333
2334 2019-06-10  Tom Tromey  <tromey@adacore.com>
2335
2336         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
2337         data.
2338         (elf_new_init): Don't call stabsread_new_init.
2339         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
2340         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
2341         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
2342
2343 2019-06-10  Tom de Vries  <tdevries@suse.de>
2344
2345         PR symtab/16264
2346         PR symtab/24517
2347         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
2348
2349 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
2350
2351         * source.c (find_and_open_source): Also rewrite relative file
2352         names.
2353
2354 2019-04-26  Amos Bird  <amosbird@gmail.com>
2355
2356         * annotate.c (annotate_thread_exited): Add "thread-exited"
2357         annotation.
2358
2359 2019-06-06  Tom Tromey  <tromey@adacore.com>
2360
2361         * maint.h (class scoped_command_stats): Use
2362         DISABLE_COPY_AND_ASSIGN.
2363         <print_time>: New method.
2364         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
2365         print_time.
2366         (scoped_command_stats::print_time): New method.
2367
2368 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2369
2370         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
2371         instructions of lengths 6 or 8 bytes.
2372
2373 2019-06-04  Pedro Alves  <palves@redhat.com>
2374
2375         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
2376
2377         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
2378         * breakpoint.c (condition_completer): Likewise.
2379         * cli/cli-dump.c (scan_expression): Likewise.
2380         * common/filestuff.c (mkdir_recursive): Likewise.
2381         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
2382         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
2383         (gdb_abspath): Likewise.
2384         * compile/compile-cplus-types.c
2385         (compile_cplus_instance::decl_name): Likewise.
2386         * completer.c (complete_explicit_location):
2387         (signal_completer, reg_or_group_completer_1): Likewise.
2388         * cp-support.c (cp_remove_params_if_any): Likewise.
2389         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
2390         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
2391         * infcmd.c (strip_bg_char): Likewise.
2392         * linespec.c (copy_token_string): Likewise.
2393         * mi/mi-main.c (output_cores): Likewise.
2394         * psymtab.c (psymtab_search_name):
2395         * symfile.c (test_set_ext_lang_command): Likewise.
2396         * target.c (target_fileio_read_stralloc): Likewise.
2397         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
2398         * value.c (complete_internalvar): Likewise.
2399
2400 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
2401
2402         Add objfile property to gdb.Type.
2403         * NEWS: Mention Python API addition.
2404         * python/py-type.c (typy_get_objfile): New method.
2405
2406 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2407
2408         * NEWS: Mention the new set|show style [title|highlight].
2409         Mention changes to "show style", "help" and "apropos".
2410
2411 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2412
2413         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
2414         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
2415         instead of print_help_for_command.
2416         (print_doc_of_command): New function.
2417         (help_list): Add 'apropos -v word' suggestion.
2418         (print_help_for_command): Style the command name using title style.
2419         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
2420         (_initialize_cli_cmds): Describe -v in apropos_command help.
2421
2422 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2423
2424         * cli/cli-style.h (cli_style_option): Add name in constructor,
2425         add m_name class member, add constructor with intensity,
2426         add name class function.
2427         (cli_style_option::add_setshow_commands): Remove name argument.
2428         (highlight_style, title_style): New styles.
2429         * cli/cli-style.c (do_show): New function that shows a style
2430         characteristic styling the style name with itself.
2431         (set_style_name): New function.
2432         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
2433         Update all callers according to the changes in cli/cli-style.h.
2434         * utils.h (fputs_highlighted): New function.
2435         * utils.c (fputs_highlighted): Likewise.
2436
2437 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2438
2439         * NEWS: Mention new pipe command and new convenience variables.
2440
2441 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2442
2443         * cli/cli-cmds.c (pipe_command): New function.
2444         (_initialize_cli_cmds): Call add_com for pipe_command.
2445         Define | as an alias for pipe.
2446         (exit_status_set_internal_vars): New function.
2447         (shell_escape): Call exit_status_set_internal_vars.
2448         cli/cli-decode.c (find_command_name_length): Recognize | as
2449         a single character command.
2450
2451 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2452
2453         * gdbcmd.h (execute_command_to_ui_file): New declaration.
2454         top.c (execute_command_to_ui_file): New function, mostly a copy
2455         of execute_command_to_string.
2456         (execute_command_to_string): Implement by calling
2457         execute_command_to_ui_file.
2458
2459 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2460
2461         * top.h (saved_command_line): Remove declaration.
2462         * top.c (previous_saved_command_line, previous_repeat_arguments):
2463         New variables.
2464         (saved_command_line): Make static, define together with other
2465         'repeat variables'.
2466         (dont_repeat): Clear repeat_arguments.
2467         (repeat_previous, get_saved_command_line, save_command_line):
2468         New functions.
2469         (gdb_init): Initialize saved_command_line
2470         and previous_saved_command_line.
2471         * main.c (captured_main_1): Remove saved_command_line initialization.
2472         * event-top.c (handle_line_of_input): Update to use
2473         the new 'repeat' related functions instead of direct access to
2474         saved_command_line.
2475         * command.h (repeat_previous, get_saved_command_line,
2476         save_command_line): New declarations.
2477         (dont_repeat): Add comment.
2478
2479 2019-05-30  Tom Tromey  <tromey@adacore.com>
2480
2481         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
2482         Fix comment.
2483         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
2484
2485 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
2486
2487         PR cli/24587
2488         * completer.c (complete): Initialize variable word.
2489
2490 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
2491
2492         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2493         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
2494         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
2495         'body' is NULL to the outter 'if', protecting the '!is_define'
2496         situation as well.
2497
2498 2019-05-29  Tom Tromey  <tromey@adacore.com>
2499
2500         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
2501         (dwarf_unknown): New function.
2502         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
2503         (dwarf_type_encoding_name): Use dwarf_unknown.
2504
2505 2019-05-29  Tom Tromey  <tromey@adacore.com>
2506
2507         PR c++/20020:
2508         * cp-valprint.c (cp_print_value_fields): Call
2509         cp_print_static_field inside "try".
2510
2511 2019-05-29  Tom Tromey  <tromey@adacore.com>
2512
2513         * inflow.c (struct terminal_info): Add default operator=.
2514         * configure: Rebuild.
2515         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
2516         -Wdeprecated-copy-dtor, -Wredundant-move.
2517
2518 2019-05-29  Tom Tromey  <tromey@adacore.com>
2519
2520         * NEWS: Add entry.
2521         * infcmd.c (print_return_value_1): Handle finish_print
2522         option.
2523         (show_print_finish): New function.
2524         (_initialize_infcmd): Add "set/show print finish" commands.
2525         * valprint.c (user_print_options): Initialize new member.
2526         * valprint.h (struct value_print_options) <finish_print>: New
2527         member.
2528
2529 2019-05-28  Tom Tromey  <tromey@adacore.com>
2530
2531         * ada-lang.c (ada_remove_Xbn_suffix)
2532         (find_old_style_renaming_symbol)
2533         (parse_old_style_renaming): Remove.
2534         (ada_find_renaming_symbol): Don't call
2535         find_old_style_renaming_symbol.
2536         (ada_is_renaming_symbol): Rename from
2537         ada_find_renaming_symbol.  Remove "block" parameter.  Return
2538         bool.  Now static.
2539         (ada_read_var_value): Update and simplify.
2540         * ada-exp.y (write_var_or_type): Remove old code.
2541
2542 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
2543
2544         * event-top.c: Remove include comment.
2545         * inflow.c (class scoped_ignore_sigttou): Move from here...
2546         * inflow.h (class scoped_ignore_sigttou): ...to here.
2547         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
2548         * top.c:  Remove include comment.
2549
2550 2019-05-27  Tom Tromey  <tom@tromey.com>
2551
2552         * NEWS: Fix typo.
2553
2554 2019-05-22  Tom Tromey  <tromey@adacore.com>
2555
2556         * target.c (target_follow_exec): Constify parameter.
2557         * target-delegates.c: Rebuild.
2558         * remote.c (remote_target::follow_exec): Constify parameter.
2559         * infrun.c (follow_exec): Constify parameter.
2560         * target.h (struct target_ops) <follow_exec>: Constify parameter.
2561         (target_follow_exec): Likewise.
2562
2563 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2564
2565         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
2566         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
2567
2568 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2569
2570         * NEWS: Add debugredirect and testsuite sections.
2571
2572 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
2573
2574         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
2575         target descriptions using exclusively floating point register name
2576         aliases.
2577
2578 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2579
2580         PR gdb/18644:
2581         * f-lang.c (build_fortran_types): Handle the case where
2582         gdbarch_floatformat_for_type returns a nullptr.
2583
2584 2019-05-21  Tom de Vries  <tdevries@suse.de>
2585
2586         PR cli/24587
2587         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
2588
2589 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2590
2591         PR gdb/18644:
2592         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
2593         16-byte floats.
2594         * i386-tdep.c (i386_floatformat_for_type): Use
2595         floatformats_ia64_quad for the 16-byte floating point component
2596         within a fortran 32-byte complex number.
2597
2598 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2599
2600         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
2601         delete default constructor.
2602         (find_partial_die): Update to return const struct.
2603         (partial_die_parent_scope): Move variable declaration into scope
2604         of its use and change its type to auto.
2605         (guess_partial_die_structure_name): Likewise.
2606         (partial_die_info::fixup): Likewise.
2607
2608 2019-05-17  Tom Tromey  <tromey@adacore.com>
2609
2610         * source.c (find_and_open_source): Remove cast.
2611
2612 2019-05-17  Tom Tromey  <tromey@adacore.com>
2613
2614         * annotate.c (annotate_source): Make "filename" const.
2615         * annotate.h (annotate_source): Use const.
2616
2617 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2618
2619         * disasm.c (set_disassembler_options): Send errors to stderr.
2620
2621 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2622
2623         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
2624         (cli_interp_base::set_logging): Check debug_redirect.
2625         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
2626         * cli/cli-logging.c (debug_redirect): Add static variable.
2627         (pop_output_files): Add default param.
2628         (handle_redirections): Print debug setting.
2629         (show_logging_command): Likewise.
2630         (_initialize_cli_logging): Add debugredirect command.
2631         * interps.c (current_interp_set_logging): Add debug_redirect
2632         parameter.
2633         * interps.h (set_logging): Add debug_redirect parameter.
2634         (current_interp_set_logging): Likewise.
2635         * mi/mi-common.h: Likewise.
2636         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
2637
2638 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2639             Tom Tromey  <tromey@adacore.com>
2640
2641         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
2642         directly.
2643         * cli/cli-interp.h (make_logging_output): Remove declaration.
2644         * cli/cli-logging.c (make_logging_output): Remove function.
2645         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
2646         directly.
2647         * ui-file.c (tee_file::tee_file): Remove bools.
2648         (tee_file::~tee_file): Remove deletes.
2649         * ui-file.h (tee_file): Remove bools.
2650
2651 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
2652
2653         * mi/mi-cmds.h (mi_cmd_complete): New function.
2654         * mi/mi-main.c (mi_cmd_complete): Likewise.
2655         * mi/mi-cmds.c: Define new MI command -complete.
2656         * NEWS: Mention new -complete command.
2657
2658 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
2659
2660         * completer.h (complete): New function.
2661         * completer.c (complete): Likewise.
2662         * cli/cli-cmds.c: (complete_command): Update to use new complete()
2663         function defined in completer.h.
2664
2665 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
2666
2667         * MAINTAINERS (Write After Approval): Add myself.
2668
2669 2019-05-17  Tom de Vries  <tdevries@suse.de>
2670
2671         PR gdb/24094
2672         * dwarf2read.c (struct cu_partial_die_info): New struct.
2673         (find_partial_die): Return cu_partial_die_info.
2674         (partial_die_parent_scope, guess_partial_die_structure_name)
2675         (partial_die_info::fixup): Handle new return type of find_partial_die.
2676
2677 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2678
2679         * stap-probe.c (stap_parse_register_operand): Make "regname" an
2680         "std::string", simplifying the algorithm.
2681
2682 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2683
2684         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
2685         (stap_static_probe_ops::get_probes): Likewise.
2686
2687 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2688
2689         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
2690         '-')" and "else if".
2691         (stap_parse_single_operand): Join checks for
2692         "gdbarch_stap_parse_special_token_p" and
2693         "gdbarch_stap_parse_special_token" in the same "if" statement.
2694         Invert check when verifying for operation on register
2695         displacement.
2696
2697 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2698
2699         * stap-probe.c (stap_get_opcode): Update comment.
2700         (stap_get_expected_argument_type): Likewise.
2701         (handle_stap_probe): Likewise.
2702
2703 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2704
2705         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
2706         return type to 'bool'.  Adjust comment.  Use 'bool' when
2707         appropriate.
2708         (i386_stap_parse_special_token_three_arg_disp): Likewise.
2709         * stap-probe.c (stap_parse_argument_1): Likewise.
2710         (stap_is_operator): Likewise.
2711         (stap_is_generic_prefix): Likewise.
2712         (stap_is_register_prefix): Likewise.
2713         (stap_is_register_indirection_prefix): Likewise.
2714         (stap_is_integer_prefix): Likewise.
2715         (stap_generic_check_suffix): Likewise.
2716         (stap_check_integer_suffix): Likewise.
2717         (stap_check_register_suffix): Likewise.
2718         (stap_check_register_indirection_suffix): Likewise.
2719         (stap_parse_register_operand): Likewise.
2720         (stap_parse_single_operand): Likewise.
2721         (stap_parse_argument_1): Likewise.
2722         (stap_probe::get_argument_count): Likewise.
2723         (stap_is_operator): Likewise.
2724
2725 2019-05-16  Tom Tromey  <tromey@adacore.com>
2726
2727         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
2728         keyword to foreach.
2729
2730 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
2731
2732         * linux-thread-db.c (try_thread_db_load_1): Change return type
2733         to bool.
2734         (try_thread_db_load): Likewise.
2735         (try_thread_db_load_from_pdir_1): Likewise.
2736         (try_thread_db_load_from_pdir): Likewise.
2737         (try_thread_db_load_from_sdir): Likewise.
2738         (try_thread_db_load_from_dir): Likewise.
2739         (thread_db_load_search): Likewise.
2740         (has_libpthread): Likewise.
2741         (thread_db_load): Likewise.
2742
2743 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
2744
2745         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2746         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
2747         NULL, and complain/return if that's the case.
2748
2749 2019-05-15  John Darrington <john@darrington.wattle.id.au>
2750
2751         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
2752         (advance, posn, abstract_read_memory): New functions.
2753         [struct mem_read_abstraction]: New struct.
2754         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
2755
2756 2019-05-14  Tom Tromey  <tromey@adacore.com>
2757
2758         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
2759         value is not lval_memory.
2760
2761 2019-05-14  Tom Tromey  <tromey@adacore.com>
2762
2763         * solib.c (info_sharedlibrary_command): Style the file name.
2764
2765 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
2766
2767         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
2768         (aarch64_vnv_type): Likewise.
2769         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
2770         * common/tdesc.c: Likewise.
2771         * common/tdesc.h (enum tdesc_type_kind): Likewise.
2772         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
2773         * features/aarch64-fpu.xml: Add ieee half view.
2774         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
2775         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
2776         * gdbtypes.h (struct builtin_type): Likewise.
2777         (struct objfile_type): Likewise.
2778
2779 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
2780
2781         * language.c (language_sniff_from_mangled_name): Fix "langauge"
2782         typo.
2783         * location.h (string_to_event_location): Likewise.
2784
2785 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
2786
2787         GDB 8.3 released.
2788
2789 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2790
2791         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
2792         New variable declaration.
2793         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
2794         New variable.
2795         (print_one_breakpoint): Use ui_out::test_flags and new global
2796         variable to compute use_fixed_output.
2797         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
2798         Remove.
2799         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
2800         (mi_multi_location_breakpoint_output_fixed): Remove.
2801         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
2802         new variable.
2803         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
2804         fix_multi_location_breakpoint_output flag if version >= 3.
2805         * ui-out.h (enum ui_out_flag)
2806         <fix_multi_location_breakpoint_output>: New enumerator.
2807
2808 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2809
2810         * contrib/cc-with-tweaks.sh: Validate dwz's work.
2811
2812 2019-05-10  Tom Tromey  <tromey@adacore.com>
2813
2814         * ada-lang.c (catch_ada_completer): New function.
2815         (_initialize_ada_language): Use it.
2816
2817 2019-05-10  Tom Tromey  <tromey@adacore.com>
2818
2819         * thread.c (print_thread_info): Make "requested_threads" const.
2820         * gdbthread.h (print_thread_info): Make "requested_threads"
2821         const.
2822         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
2823         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
2824
2825 2019-05-08  Tom Tromey  <tom@tromey.com>
2826
2827         * gdbtypes.c (objfile_type_data): Change type.
2828         (objfile_type, _initialize_gdbtypes): Update.
2829
2830 2019-05-08  Tom Tromey  <tom@tromey.com>
2831
2832         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
2833         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
2834         (_initialize_dwarf2_frame): Update.
2835
2836 2019-05-08  Tom Tromey  <tom@tromey.com>
2837
2838         * objc-lang.c (objc_objfile_data): Change type.
2839         (find_methods): Update.
2840         (_initialize_objc_lang): Remove.
2841
2842 2019-05-08  Tom Tromey  <tom@tromey.com>
2843
2844         * stabsread.c (rs6000_builtin_type_data): Change type.
2845         (rs6000_builtin_type, _initialize_stabsread): Update.
2846
2847 2019-05-08  Tom Tromey  <tom@tromey.com>
2848
2849         * mips-tdep.c (mips_pdr_data): Remove.
2850         (_initialize_mips_tdep): Update.
2851
2852 2019-05-08  Tom Tromey  <tom@tromey.com>
2853
2854         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
2855         (hppa_init_objfile_priv_data, read_unwind_info)
2856         (find_unwind_entry, _initialize_hppa_tdep): Update.
2857
2858 2019-05-08  Tom Tromey  <tom@tromey.com>
2859
2860         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
2861         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
2862         on obstack.
2863         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
2864
2865 2019-05-08  Tom Tromey  <tom@tromey.com>
2866
2867         * mdebugread.c (basic_type_data): Change type.
2868         (basic_type, _initialize_mdebugread): Update.
2869
2870 2019-05-08  Tom Tromey  <tom@tromey.com>
2871
2872         * common/gdb_unique_ptr.h (struct noop_deleter): New.
2873
2874 2019-05-08  Tom Tromey  <tom@tromey.com>
2875
2876         * nto-tdep.c (nto_inferior_data_reg): Change type.
2877         (nto_inferior_data): Update.
2878         (nto_inferior_data_cleanup, nto_new_inferior_data)
2879         (_initialize_nto_tdep): Remove.
2880         * nto-tdep.h (struct nto_inferior_data): Add initializers.
2881
2882 2019-05-08  Tom Tromey  <tom@tromey.com>
2883
2884         * ada-lang.c (struct ada_inferior_data): Add initializers.
2885         (ada_inferior_data): Change type.
2886         (ada_inferior_data_cleanup): Remove.
2887         (get_ada_inferior_data, ada_inferior_exit)
2888         (struct ada_pspace_data): Add initializers, destructor.
2889         (ada_pspace_data_handle): Change type.
2890         (get_ada_pspace_data): Update.
2891         (ada_pspace_data_cleanup): Remove.
2892
2893 2019-05-08  Tom Tromey  <tom@tromey.com>
2894
2895         * coffread.c (struct coff_symfile_info): Add initializers.
2896         (coff_objfile_data_key): Move lower.  Change type.
2897         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
2898         Update.
2899         (coff_free_info): Remove.
2900
2901 2019-05-08  Tom Tromey  <tom@tromey.com>
2902
2903         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
2904         (fbsd_pspace_data_handle): Move lower.  Change type.
2905         (get_fbsd_pspace_data): Update.
2906         (fbsd_pspace_data_cleanup): Remove.
2907         (_initialize_fbsd_tdep): Update.
2908
2909 2019-05-08  Tom Tromey  <tom@tromey.com>
2910
2911         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
2912         (get_ada_tasks_pspace_data): Update.
2913         (ada_tasks_pspace_data_cleanup): Remove.
2914         (_initialize_tasks): Update.
2915         (ada_tasks_inferior_data_handle): Change type.
2916         (get_ada_tasks_inferior_data): Update.
2917         (ada_tasks_inferior_data_cleanup): Remove.
2918         (struct ada_tasks_pspace_data): Add initializers.
2919
2920 2019-05-08  Tom Tromey  <tom@tromey.com>
2921
2922         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
2923         * symfile-debug.c (debug_sym_get_probes): Change type.
2924         * stap-probe.c (handle_stap_probe):
2925         (stap_static_probe_ops::get_probes): Change type.
2926         * probe.h (class static_probe_ops) <get_probes>: Change type.
2927         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
2928         (parse_probes_in_pspace): Update.
2929         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
2930         Update.
2931         (any_static_probe_ops::get_probes): Change type.
2932         * elfread.c (elfread_data): New typedef.
2933         (probe_key): Change type.
2934         (elf_get_probes): Likewise.  Update.
2935         (probe_key_free): Remove.
2936         (_initialize_elfread): Update.
2937         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
2938         Change type.
2939         (dtrace_process_dof_probe, dtrace_process_dof)
2940         (dtrace_static_probe_ops::get_probe): Change type.
2941
2942 2019-05-08  Tom Tromey  <tom@tromey.com>
2943
2944         * xcoffread.c (struct xcoff_symfile_info): Rename from
2945         coff_symfile_info.  Add initializers.
2946         (xcoff_objfile_data_key): Move lower.  Change type.
2947         (XCOFF_DATA): Rewrite.
2948         (xcoff_free_info): Remove.
2949         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
2950         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
2951         (xcoff_initial_scan): Update.
2952
2953 2019-05-08  Tom Tromey  <tom@tromey.com>
2954
2955         * solib-svr4.c (struct svr4_info): Add initializers and
2956         destructor.
2957         <probes_table>: Now an htab_up.
2958         (solib_svr4_pspace_data): Change type.
2959         (free_probes_table): Simplify.
2960         (~svr4_info): Rename from svr4_pspace_data_cleanup.
2961         (get_svr4_info, probes_table_htab_remove_objfile_probes)
2962         (probes_table_remove_objfile_probes, register_solib_event_probe)
2963         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
2964         (_initialize_svr4_solib): Update.
2965
2966 2019-05-08  Tom Tromey  <tom@tromey.com>
2967
2968         * remote.c (remote_pspace_data): Change type.
2969         (remote_pspace_data_cleanup): Remove.
2970         (get_remote_exec_file, set_pspace_remote_exec_file)
2971         (_initialize_remote): Update.
2972
2973 2019-05-08  Tom Tromey  <tom@tromey.com>
2974
2975         * breakpoint.c (breakpoint_objfile_key): Change type.
2976         (get_breakpoint_objfile_data): Update.
2977         (free_breakpoint_objfile_data): Remove.
2978         (_initialize_breakpoint): Update.
2979
2980 2019-05-08  Tom Tromey  <tom@tromey.com>
2981
2982         * linux-tdep.c (struct linux_info): Add initializers.
2983         (linux_inferior_data): Move.  Change type.
2984         (invalidate_linux_cache_inf): Update.
2985         (linux_inferior_data_cleanup): Remove.
2986         (get_linux_inferior_data, _initialize_linux_tdep): Update.
2987
2988 2019-05-08  Tom Tromey  <tom@tromey.com>
2989
2990         * auxv.c (auxv_inferior_data): Move.  Change type.
2991         (auxv_inferior_data_cleanup): Remove.
2992         (invalidate_auxv_cache_inf): Rewrite.
2993         (get_auxv_inferior_data, _initialize_auxv): Update.
2994
2995 2019-05-08  Tom Tromey  <tom@tromey.com>
2996
2997         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
2998         (symfile_debug_objfile_data_key): Change type.
2999         (symfile_debug_installed, debug_qf_has_symbols)
3000         (debug_qf_find_last_source_symtab)
3001         (debug_qf_forget_cached_source_info)
3002         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3003         (debug_qf_print_stats, debug_qf_dump)
3004         (debug_qf_expand_symtabs_for_function)
3005         (debug_qf_expand_all_symtabs)
3006         (debug_qf_expand_symtabs_with_fullname)
3007         (debug_qf_map_matching_symbols)
3008         (debug_qf_expand_symtabs_matching)
3009         (debug_qf_find_pc_sect_compunit_symtab)
3010         (debug_qf_map_symbol_filenames)
3011         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3012         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3013         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3014         (debug_sym_read_linetable, debug_sym_relocate): Update.
3015         (symfile_debug_free_objfile): Remove.
3016         (install_symfile_debug_logging, _initialize_symfile_debug):
3017         Update.
3018
3019 2019-05-08  Tom Tromey  <tom@tromey.com>
3020
3021         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3022         allocate_on_obstack.
3023         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3024         (get_dwarf2_per_objfile): Update.
3025         (set_dwarf2_per_objfile): Remove.
3026         (dwarf2_has_info, dwarf2_get_section_info): Update.
3027         (dwarf2_free_objfile): Remove.
3028         (_initialize_dwarf2_read): Update.
3029
3030 2019-05-08  Tom Tromey  <tom@tromey.com>
3031
3032         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3033         initializers.
3034         <unsupported_script_warning_printed,
3035         script_not_found_warning_printed>: Now bool.
3036         (auto_load_pspace_data): Change type.
3037         (~auto_load_pspace_info): Rename from
3038         auto_load_pspace_data_cleanup.
3039         (get_auto_load_pspace_data, init_loaded_scripts_info)
3040         (clear_section_scripts, maybe_print_unsupported_script_warning)
3041         (maybe_print_script_not_found_warning, _initialize_auto_load):
3042         Update.
3043
3044 2019-05-08  Tom Tromey  <tom@tromey.com>
3045
3046         * objfiles.c (objfile_pspace_info): Add destructor and
3047         initializers.
3048         (objfiles_pspace_data): Change type.
3049         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3050         (get_objfile_pspace_data): Update.
3051         (objfiles_bfd_data): Change type.
3052         (get_objfile_bfd_data): Update.
3053         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3054
3055 2019-05-08  Tom Tromey  <tom@tromey.com>
3056
3057         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3058         Change type.
3059         (get_catch_syscall_inferior_data): Update.
3060         (catch_syscall_inferior_data_cleanup): Remove.
3061         (_initialize_break_catch_syscall): Update.
3062
3063 2019-05-08  Tom Tromey  <tom@tromey.com>
3064
3065         * inflow.c (struct terminal_info): Add destructor and
3066         initializers.
3067         (inflow_inferior_data): Change type.
3068         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3069         (get_inflow_inferior_data, inflow_inferior_exit)
3070         (swap_terminal_info, _initialize_inflow): Update.
3071
3072 2019-05-08  Tom Tromey  <tom@tromey.com>
3073
3074         * target-dcache.c (target_dcache_cleanup): Remove.
3075         (target_dcache_aspace_key): Change type.
3076         (target_dcache_init_p, target_dcache_invalidate)
3077         (target_dcache_get, target_dcache_get_or_init)
3078         (_initialize_target_dcache): Update.
3079         * dcache.h (struct dcache_deleter): New.
3080
3081 2019-05-08  Tom Tromey  <tom@tromey.com>
3082
3083         * symtab.c (struct symbol_cache): Add destructor and
3084         initializers.
3085         (symbol_cache_key): Move.  Change type.
3086         (make_symbol_cache, free_symbol_cache): Remove.
3087         (get_symbol_cache): Update.
3088         (symbol_cache_cleanup): Remove.
3089         (ALL_PSPACES, symbol_cache_flush)
3090         (maintenance_print_symbol_cache)
3091         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3092         Update.
3093
3094 2019-05-08  Tom Tromey  <tom@tromey.com>
3095
3096         * symtab.c (struct main_info): Add destructor and initializers.
3097         (main_progspace_key): Move.  Change type.
3098         (get_main_info): Update.
3099         (main_info_cleanup): Remove.
3100         (_initialize_symtab): Update.
3101
3102 2019-05-08  Tom Tromey  <tom@tromey.com>
3103
3104         * registry.h (DECLARE_REGISTRY): Define the _key class.
3105
3106 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3107
3108         * NEWS: Merge two 'New commands' sections.
3109
3110 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3111
3112         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3113         parameter and use Ada language definition instead.
3114         (ada_val_print_ptr): Remove unused language parameter.
3115         (ada_val_print_num): Remove language parameter and use Ada language
3116         definition instead.
3117         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3118         parameter.
3119         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3120         parameter and use Ada language definition instead.
3121         (ada_val_print_1): Update all ada_val_print_xxx calls.
3122         Remove language parameter.
3123         (ada_val_print): Update ada_val_print_1 call.
3124
3125 2019-05-08  Tom Tromey  <tromey@adacore.com>
3126
3127         * remote.c (remote_hw_watchpoint_limit)
3128         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3129         Now static.
3130
3131 2019-05-08  Tom Tromey  <tromey@adacore.com>
3132
3133         * maint.c (_initialize_maint_cmds): Move initialization code to
3134         remote.c.
3135         (watchdog, show_watchdog): Move to remote.c.
3136         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3137         "watchdog" static.
3138         (_initialize_remote): Move initialization code from maint.c.
3139         * defs.h (watchdog): Don't declare.
3140
3141 2019-05-08  Tom Tromey  <tromey@adacore.com>
3142
3143         * tui/tui-interp.c: Include main.h.
3144         * interps.c: Include main.h.
3145         * main.h (interpreter_p): Declare.
3146         * defs.h (interpreter_p): Don't declare.
3147
3148 2019-05-08  Tom Tromey  <tromey@adacore.com>
3149
3150         * dwarf2loc.c: Include dwarf2read.h.
3151         * defs.h (read_unsigned_leb128): Don't declare.
3152         * dwarf2read.h (read_unsigned_leb128): Declare.
3153
3154 2019-05-08  Tom Tromey  <tromey@adacore.com>
3155
3156         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3157         method.
3158
3159 2019-05-08  Tom Tromey  <tromey@adacore.com>
3160
3161         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3162         when no wrap column is set.
3163
3164 2019-05-08  Tom Tromey  <tromey@adacore.com>
3165
3166         * c-lang.c (c_get_string): Handle non-C-style arrays.
3167
3168 2019-05-08  Tom Tromey  <tromey@adacore.com>
3169
3170         * typeprint.c (print_offset_data::update): Print the bit offset,
3171         not the number of bits remaining.
3172
3173 2019-05-08  Tom Tromey  <tromey@adacore.com>
3174
3175         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3176         padding at end of comment.
3177
3178 2019-05-08  Tom Tromey  <tromey@adacore.com>
3179
3180         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3181         Compare main types.
3182
3183 2019-05-06  Tom Tromey  <tom@tromey.com>
3184
3185         * common/scoped_mmap.c: Include common-defs.h.
3186         * common/scoped_mmap.h: Don't include config.h.
3187
3188 2019-05-04  Tom Tromey  <tom@tromey.com>
3189
3190         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3191         (struct aarch64_call_info): Add initializers.
3192         <si>: Now a std::vector.
3193         (pass_on_stack, aarch64_push_dummy_call): Update.
3194
3195 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3196             Tom Tromey  <tom@tromey.com>
3197
3198         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3199         (ppc_threads): Now a std::vector.  Now static.
3200         (hwdebug_find_thread_points_by_tid)
3201         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3202         Update.
3203
3204 2019-05-04  Tom Tromey  <tom@tromey.com>
3205
3206         * arc-tdep.c (arc_tdesc_init): Return bool.
3207
3208 2019-05-04  Tom Tromey  <tom@tromey.com>
3209
3210         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3211         Use gdb_assert_not_reached.
3212
3213 2019-05-04  Tom Tromey  <tom@tromey.com>
3214
3215         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3216         "false".
3217
3218 2019-05-04  Tom Tromey  <tom@tromey.com>
3219
3220         * arc-tdep.c (arc_tdesc_init): Use bool.
3221
3222 2019-05-04  Tom Tromey  <tom@tromey.com>
3223
3224         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3225
3226 2019-05-04  Tom Tromey  <tom@tromey.com>
3227
3228         * cli/cli-cmds.c (valid_command_p): Return bool.
3229
3230 2019-05-04  Tom Tromey  <tom@tromey.com>
3231
3232         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3233         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3234
3235 2019-05-04  Raul Tambre  <raul@tambre.ee>
3236
3237         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3238         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3239         operator for comparison.
3240
3241 2019-05-04  Tom Tromey  <tom@tromey.com>
3242
3243         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3244         (lookup_partial_symbol, print_partial_symbols)
3245         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3246         (psymbol_compare): Update.
3247         (add_psymbol_to_bcache): Clear the entire psymbol.
3248         (maintenance_check_psymtabs): Update.
3249         * psympriv.h (struct partial_symbol): Don't derive from
3250         general_symbol_info.
3251         <obj_section, unrelocated_address, address,
3252         set_unrelocated_address>: Update.
3253         <ginfo>: New member.
3254         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3255         (debug_names::write_psymbols): Update.
3256
3257 2019-05-04  Tom de Vries  <tdevries@suse.de>
3258
3259         * contrib/cc-with-tweaks.sh: Support -n arg.
3260
3261 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3262
3263         * corelow.c (core_target::detach): Ensure frame cache and
3264         register caches are cleared.
3265         inferior.c (exit_inferior_1): Likewise.
3266
3267 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
3268             Tom Tromey  <tom@tromey.com>
3269
3270         * dictionary.c (collate_pending_symbols_by_language): Remove
3271         "struct" from foreach.
3272         * symtab.c (lookup_global_symbol_from_objfile)
3273         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
3274         foreach.
3275         * ser-tcp.c (net_open): Remove "struct" from foreach.
3276         * objfiles.c (objfile_relocate, objfile_rebase)
3277         (objfile_has_symbols): Remove "struct" from foreach.
3278         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
3279         from foreach.
3280         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
3281         foreach.
3282         * darwin-nat.c (thread_info_from_private_thread_info): Remove
3283         "struct" from foreach.
3284         * ada-lang.c (create_excep_cond_exprs)
3285         (ada_exception_catchpoint_cond_string): Remove "struct" from
3286         foreach.
3287
3288 2019-05-03  Tom Tromey  <tromey@adacore.com>
3289
3290         * ada-exp.y (convert_char_literal): Check suffix of each
3291         enumerator.
3292
3293 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
3294
3295         PR ada/21406:
3296         * ada-exp.y (yywrap): Don't define.
3297         * ada-lex.l (%option): Add noyywrap
3298         (yywrap): Remove.
3299
3300 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
3301
3302         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
3303         _WIN32_WINNT to the XP level, unless already defined to a higher
3304         level.
3305
3306         * unittests/parse-connection-spec-selftests.c:
3307         * ser-tcp.c:
3308         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
3309         override.
3310
3311         * symfile.c (find_separate_debug_file): Remove colon from the
3312         drive spec of DOS/Windows file names of the target, so that the
3313         file name produced from DEBUGDIR and the target's directory will
3314         be valid on DOS/Windows systems.
3315
3316 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3317
3318         * rust-lang.c (val_print_struct): Handle printing structures
3319         containing strings.
3320
3321 2019-05-02  Tom Tromey  <tromey@adacore.com>
3322
3323         * valarith.c (_initialize_valarith): Remove.
3324
3325 2019-05-01  Tom Tromey  <tromey@adacore.com>
3326
3327         * ada-lang.c (ada_value_primitive_field): Treat more fields as
3328         bitfields.
3329
3330 2019-05-01  Tom Tromey  <tromey@adacore.com>
3331
3332         * ada-lang.c (ada_value_assign): Correctly compute starting offset
3333         for big-endian copies.
3334
3335 2019-04-30  Ali Tamur  <tamur@google.com>
3336         * gdb/dwarf2read.c (read_3_bytes): New declaration.
3337         (read_attribute_value): Added DW_FORM_strx1-4 cases.
3338         (read_3_bytes): New function.
3339
3340 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3341
3342         * windows-nat.c (main_thread_id): Delete.
3343         (handle_output_debug_string): Replace main_thread_id by
3344         current_event.dwThreadId.
3345         (fake_create_process): Likewise.
3346         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
3347         Do not set main_thread_id.
3348         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
3349         current_event.dwThreadId.
3350         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
3351
3352 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3353
3354         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
3355         Use current_event.dwThreadId instead of main_thread_id.
3356
3357 2019-04-30  Tom Tromey  <tromey@adacore.com>
3358
3359         * ada-lang.c (ada_lookup_simple_minsyms): New function.
3360         (create_excep_cond_exprs): Iterate over program spaces.
3361         (ada_exception_catchpoint_cond_string): Examine all minimal
3362         symbols for exception types.
3363
3364 2019-04-30  Tom Tromey  <tromey@adacore.com>
3365
3366         PR c++/24470:
3367         * dwarf2read.c (process_structure_scope): Handle case where type
3368         has template parameters but no symbol was created.
3369
3370 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3371             Chris January  <chris.january@arm.com>
3372
3373         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
3374         qualifier.
3375         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
3376
3377 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3378
3379         * f-typeprint.c (f_print_type): Update rules for printing
3380         whitespace.
3381         (f_type_print_varspec_suffix): Likewise.
3382
3383 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3384             Chris January  <chris.january@arm.com>
3385
3386         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
3387         function arguments.
3388
3389 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3390
3391         * f-lang.c (build_fortran_types): Change name of void type to
3392         lower case.
3393         * f-typeprint.c (f_type_print_base): Print the name of the void
3394         type, rather than a fixed string.
3395         * f-valprint.c (f_decorations): Use lower case void string.
3396
3397 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3398             Chris January  <chris.january@arm.com>
3399
3400         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
3401         types for Fortran.
3402
3403 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3404             Chris January  <chris.january@arm.com>
3405             David Lecomber  <david.lecomber@arm.com>
3406
3407         * f-exp.y (BINOP_INTRINSIC): New token.
3408         (exp): New parser rule handling BINOP_INTRINSIC.
3409         (f77_keywords): Add new builtin procedures.
3410         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
3411         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3412         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
3413         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3414         (print_unop_subexp_f): New function.
3415         (print_binop_subexp_f): New function.
3416         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3417         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3418         (dump_subexp_body_f): Likewise.
3419         (operator_check_f): Likewise.
3420         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3421         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
3422
3423 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3424
3425         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
3426         UNOP_KIND.
3427         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
3428         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
3429         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
3430         (operator_length_f): New fuction.
3431         (print_subexp_f): New function.
3432         (op_name_f): New function.
3433         (dump_subexp_body_f): New function.
3434         (operator_check_f): New function.
3435         (exp_descriptor_f): Replace standard expression handling functions
3436         with new functions.
3437         * gdb/fortran-operator.def: New file.
3438         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
3439         * gdb/std-operator.def: Remove UNOP_KIND.
3440
3441 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3442
3443         * std-operator.def: Remove unbalanced, stray double quote
3444         character.
3445
3446 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3447             Chris January  <chris.january@arm.com>
3448             Daniel Everett  <daniel.everett@arm.com>
3449             Nick Forrington  <nick.forrington@arm.com>
3450             Richard Bunt  <richard.bunt@arm.com>
3451
3452         * cp-valprint.c (cp_print_value_fields): Allow an additional level
3453         of depth when printing anonymous structs or unions.
3454         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
3455         Don't print either the top-level value, or the children if the
3456         max-depth is exceeded.
3457         (ppscm_print_children): When printing the key of a map, allow one
3458         extra level of depth.
3459         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
3460         print either the top-level value, or the children if the max-depth
3461         is exceeded.
3462         (print_children): When printing the key of a map, allow one extra
3463         level of depth.
3464         * python/py-value.c (valpy_format_string): Add max_depth keyword.
3465         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
3466         (user_print_options): Initialise max_depth field.
3467         (val_print_scalar_or_string_type_p): New function.
3468         (val_print): Check to see if the max depth has been reached.
3469         (val_print_check_max_depth): Define new function.
3470         (show_print_max_depth): New function.
3471         (_initialize_valprint): Add 'print max-depth' option.
3472         * valprint.h (struct value_print_options) <max_depth>: New field.
3473         (val_print_check_max_depth): Declare new function.
3474         * NEWS: Document new feature.
3475
3476 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3477
3478         * ada-lang.c (ada_language_defn): Initialise new field.
3479         * c-lang.c (c_is_string_type_p): New function.
3480         (c_language_defn): Initialise new field.
3481         (cplus_language_defn): Initialise new field.
3482         (asm_language_defn): Initialise new field.
3483         (minimal_language_defn): Initialise new field.
3484         * c-lang.h (c_is_string_type_p): Declare new function.
3485         * d-lang.c (d_language_defn): Initialise new field.
3486         * f-lang.c (f_is_string_type_p): New function.
3487         (f_language_defn): Initialise new field.
3488         * go-lang.c (go_is_string_type_p): New function.
3489         (go_language_defn): Initialise new field.
3490         * language.c (default_is_string_type_p): New function.
3491         (unknown_language_defn): Initialise new field.
3492         (auto_language_defn): Initialise new field.
3493         * language.h (struct language_defn) <la_is_string_type_p>: New
3494         member variable.
3495         (default_is_string_type_p): Declare new function.
3496         * m2-lang.c (m2_language_defn): Initialise new field.
3497         * objc-lang.c (objc_language_defn): Initialise new field.
3498         * opencl-lang.c (opencl_language_defn): Initialise new field.
3499         * p-lang.c (pascal_is_string_type_p): New function.
3500         (pascal_language_defn): Initialise new field.
3501         * rust-lang.c (rust_is_string_type_p): New function.
3502         (rust_language_defn): Initialise new field.
3503
3504 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3505
3506         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
3507         New field.
3508         * ada-lang.c (ada_language_defn): Initialise new field.
3509         * c-lang.c (c_language_defn): Likewise.
3510         (cplus_language_defn): Likewise.
3511         (asm_language_defn): Likewise.
3512         (minimal_language_defn): Likewise.
3513         * d-lang.c (d_language_defn): Likewise.
3514         * f-lang.c (f_language_defn): Likewise.
3515         * go-lang.c (go_language_defn): Likewise.
3516         * language.c (unknown_language_defn): Likewise.
3517         (auto_language_defn): Likewise.
3518         * m2-lang.c (m2_language_defn): Likewise.
3519         * objc-lang.c (objc_language_defn): Likewise.
3520         * opencl-lang.c (opencl_language_defn): Likewise.
3521         * p-lang.c (pascal_language_defn): Likewise.
3522         * rust-lang.c (rust_language_defn): Likewise.
3523
3524 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3525
3526         * ada-lang.c (ada_is_character_type): Change return type to bool.
3527         (ada_is_string_type): Likewise.
3528         * ada-lang.h (ada_is_character_type): Update declaration
3529         (ada_is_string_type): Likewise.
3530
3531 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3532
3533         Support style in 'frame|thread apply'
3534
3535         * gdbcmd.h (execute_command_to_string): New term_out parameter.
3536         * record.c (record_start, record_stop): Update callers of
3537         execute_command_to_string with false.
3538         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
3539         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
3540         methods.
3541         (class string_file): New constructor with term_out parameter.
3542         Override methods term_out and can_emit_style_escape.  New member
3543         term_out.
3544         (class stdio_file): Override can_emit_style_escape.
3545         (class tee_file): Override term_out and can_emit_style_escape.
3546         * utils.h (can_emit_style_escape): Remove.
3547         * utils.c (can_emit_style_escape): Likewise.
3548         Update all callers of can_emit_style_escape (SOMESTREAM) to
3549         SOMESTREAM->can_emit_style_escape.
3550         * source-cache.c (source_cache::get_source_lines): Likewise.
3551         * stack.c (frame_apply_command_count): Call execute_command_to_string
3552         passing the term_out characteristic of the current gdb_stdout.
3553         * thread.c (thr_try_catch_cmd): Likewise.
3554         * top.c (execute_command_to_string): pass term_out parameter
3555         to construct the string_file for the command output.
3556         * ui-file.c (term_cli_styling): New function (most code moved
3557         from utils.c can_emit_style_escape).
3558         (string_file::string_file, string_file::can_emit_style_escape,
3559         stdio_file::can_emit_style_escape, tee_file::term_out,
3560         tee_file::can_emit_style_escape): New functions.
3561
3562 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3563
3564         * NEWS: Mention the new set|show may-call-functions.
3565         * infcall.c (may_call_functions_p): New variable.
3566         (show_may_call_functions_p): New function.
3567         (call_function_by_hand_dummy): Throws an error if not
3568         may-call-functions.
3569         (_initialize_infcall): Call add_setshow_boolean_cmd for
3570         may-call-functions.
3571
3572 2019-04-25  Keith Seitz  <keiths@redhat.com>
3573
3574         PR c++/24367
3575         * cp-support.c (inspect_type): Don't attempt substitutions
3576         of symbol with the same name.
3577
3578 2019-04-25  Tom Tromey  <tromey@adacore.com>
3579
3580         PR gdb/24475:
3581         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
3582         static.
3583
3584 2019-04-25  Tom Tromey  <tromey@adacore.com>
3585
3586         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
3587         rvalue reference.
3588         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
3589         (gdb_xml_parser::parse): Use std::move.
3590         * python/python-internal.h (gdbpy_convert_exception): Take a const
3591         reference.
3592         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
3593         std::move.
3594         * python/py-utils.c (gdbpy_convert_exception): Take a const
3595         reference.
3596         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3597         Use std::move.
3598         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3599         Use std::move.
3600         * mi/mi-main.c (mi_print_exception): Take a const reference.
3601         * main.c (handle_command_errors): Take a const reference.
3602         * linespec.c (parse_linespec): Use std::move.
3603         * infcall.c (run_inferior_call): Use std::move.
3604         (call_function_by_hand_dummy): Use std::move.
3605         * exec.c (try_open_exec_file): Use std::move.
3606         * exceptions.h (exception_print, exception_fprintf)
3607         (exception_print_same): Update.
3608         * exceptions.c (print_exception, exception_print)
3609         (exception_fprintf, exception_print_same): Change parameters to
3610         const reference.
3611         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
3612         * common/new-op.c: Use std::move.
3613         * common/common-exceptions.h (struct gdb_exception): Add move
3614         constructor.
3615         (struct gdb_exception_error, struct gdb_exception_quit, struct
3616         gdb_quit_bad_alloc): Change constructor to move constructor.
3617         (throw_exception): Change parameter to rvalue reference.
3618         * common/common-exceptions.c (throw_exception): Take rvalue
3619         reference.
3620         * cli/cli-interp.c (safe_execute_command): Use std::move.
3621         * breakpoint.c (insert_bp_location, location_to_sals): Use
3622         std::move.
3623
3624 2019-04-25  Tom Tromey  <tromey@adacore.com>
3625
3626         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
3627         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
3628         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
3629         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
3630         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
3631         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
3632         guile/scm-value.c: Use unpack.
3633         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
3634         gdbscm_gdb_exception.
3635         (gdbscm_throw_gdb_exception): Likewise.
3636         (struct gdbscm_gdb_exception): New.
3637         (unpack): New function.
3638         (gdbscm_wrap): Use unpack.
3639
3640 2019-04-25  Tom Tromey  <tromey@adacore.com>
3641
3642         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3643         (gdb_rl_callback_handler): Use std::move.
3644         * common/common-exceptions.h (struct gdb_exception): Add move
3645         assignment operator.
3646         (throw_exception_sjlj): Change "exception" to const reference.
3647         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
3648         (throw_exception_sjlj): Change "exception" to const reference.
3649
3650 2019-04-25  Tom Tromey  <tromey@adacore.com>
3651
3652         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
3653         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
3654         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3655         Update.
3656         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3657         Update.
3658         * mi/mi-interp.c (mi_interp::exec): Update.
3659         * linespec.c (parse_linespec): Update.
3660         * infcall.c (run_inferior_call): Update.
3661         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
3662         * guile/scm-symbol.c (gdbscm_lookup_symbol)
3663         (gdbscm_lookup_global_symbol): Update.
3664         * guile/scm-param.c (gdbscm_parameter_value): Update.
3665         * guile/scm-frame.c (gdbscm_frame_read_register)
3666         (gdbscm_frame_read_var): Update.
3667         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
3668         * exec.c (try_open_exec_file): Update.
3669         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3670         (gdb_rl_callback_handler): Update.
3671         * common/common-exceptions.h (exception_none): Don't declare.
3672         * common/common-exceptions.c (exception_none): Don't define.
3673         (struct catcher) <exception>: Update.
3674         * cli/cli-interp.c (safe_execute_command): Update.
3675         * breakpoint.c (insert_bp_location, location_to_sals): Update.
3676
3677 2019-04-25  Ali Tamur  <tamur@google.com>
3678
3679         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
3680         (read_attribute_value): Likewise.
3681         (dwarf2_read_addr_index): Update comment.
3682         (read_str_index): Add DW_FORM_strx.
3683         (dwarf2_string_attr): Likewise.
3684         (dwarf2_const_value_attr): Likewise.
3685         (dump_die_shallow): Likewise.
3686         (dwarf2_fetch_constant_bytes): Likewise.
3687         (skip_form_bytes): Likewise.
3688         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
3689
3690 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
3691
3692         PR corefiles/11608
3693         PR corefiles/18187
3694         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
3695         OFFSET.  Verify if current mapping contains an ELF header.
3696         (linux_find_memory_regions_full): Adjust call to
3697         dump_mapping_p.
3698
3699 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
3700             Kang Li <kanglictf@gmail.com>
3701
3702         PR gdb/21600
3703
3704         * dwarf2-frame.c (read_initial_length): Be consistent about using
3705         unsigned representation of length.
3706         (decode_frame_entry_1): Likewise.  Check for wraparound of
3707         end pointer as well as buffer overflow.
3708
3709 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
3710
3711         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
3712         "vq".
3713
3714 2019-04-24  Tom Tromey  <tromey@adacore.com>
3715
3716         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
3717
3718 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3719
3720         * s12z-tdep.c (s12z_unwind_pc): Delete.
3721         (s12z_unwind_sp): Delete.
3722         (s12z_gdbarch_init): Don't register deleted functions with
3723         gdbarch.
3724
3725 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3726
3727         * rl78-tdep.c (rl78_unwind_sp): Delete.
3728         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
3729
3730 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3731
3732         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
3733         (xstormy16_unwind_pc): Delete.
3734         (xstormy16_dummy_id): Delete.
3735         (xstormy16_gdbarch_init): Don't register deleted functions with
3736         gdbarch.
3737
3738 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3739
3740         * vax-tdep.c (vax_unwind_pc): Delete.
3741         (vax_gdbarch_init): Don't register deleted function with gdbarch.
3742
3743 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3744
3745         * v850-tdep.c (v850_unwind_sp): Delete.
3746         (v850_unwind_pc): Delete.
3747         (v850_dummy_id): Delete.
3748         (v850_gdbarch_init): Don't register deleted functions with
3749         gdbarch.
3750
3751 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3752
3753         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
3754         (tilegx_unwind_pc): Delete.
3755         (tilegx_unwind_dummy_id): Delete.
3756         (tilegx_gdbarch_init): Don't register deleted functions with
3757         gdbarch.
3758
3759 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3760
3761         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
3762         (tic6x_dummy_id): Delete.
3763         (tic6x_gdbarch_init): Don't register deleted functions with
3764         gdbarch.
3765
3766 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3767
3768         * sparc-tdep.c (sparc_unwind_pc): Delete.
3769         (sparc32_gdbarch_init): Don't register deleted function with
3770         gdbarch.
3771
3772 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3773
3774         * sh-tdep.c (sh_unwind_sp): Delete.
3775         (sh_unwind_pc): Delete.
3776         (sh_dummy_id): Delete.
3777         (sh_gdbarch_init): Don't register deleted functions with
3778         gdbarch.
3779
3780 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3781
3782         * score-tdep.c (score_unwind_sp): Delete.
3783         (score_unwind_pc): Delete.
3784         (score_dummy_id): Delete.
3785         (score_gdbarch_init): Don't register deleted functions with
3786         gdbarch.
3787
3788 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3789
3790         * rx-tdep.c (rx_unwind_pc): Delete.
3791         (rx_unwind_sp): Delete.
3792         (rx_dummy_id): Delete.
3793         (rx_gdbarch_init): Don't register deleted functions with
3794         gdbarch.  Update comment.
3795
3796 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3797
3798         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
3799         (rs6000_dummy_id): Delete.
3800         (rs6000_gdbarch_init): Don't register deleted functions with
3801         gdbarch.
3802
3803 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3804
3805         * or1k-tdep.c (or1k_dummy_id): Delete.
3806         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
3807
3808 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3809
3810         * nios2-tdep.c (nios2_dummy_id): Delete.
3811         (nios2_unwind_sp): Delete.
3812         (nios2_gdbarch_init): Don't register deleted functions with
3813         gdbarch.
3814
3815 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3816
3817         * nds32-tdep.c (nds32_dummy_id): Delete.
3818         (nds32_unwind_pc): Delete.
3819         (nds32_unwind_sp): Delete.
3820         (nds32_gdbarch_init): Don't register deleted functions with
3821         gdbarch.
3822
3823 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3824
3825         * msp430-tdep.c (msp430_unwind_pc): Delete.
3826         (msp430_unwind_sp): Delete.
3827         (msp430_dummy_id): Delete.
3828         (msp430_gdbarch_init): Don't register deleted functions with
3829         gdbarch.
3830
3831 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3832
3833         * moxie-tdep.c (moxie_unwind_sp): Delete.
3834         (moxie_unwind_pc): Delete.
3835         (moxie_dummy_id): Delete.
3836         (moxie_gdbarch_init): Don't register deleted functions with
3837         gdbarch.
3838
3839 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3840
3841         * mn10300-tdep.c (mn10300_dummy_id): Delete.
3842         (mn10300_unwind_pc): Delete.
3843         (mn10300_unwind_sp): Delete.
3844         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
3845         mn10300_unwind_sp.
3846         (mn10300_frame_unwind_init): Don't register deleted functions with
3847         gdbarch.
3848
3849 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3850
3851         * mep-tdep.c (mep_unwind_pc): Delete.
3852         (mep_unwind_sp): Delete.
3853         (mep_dummy_id): Delete.
3854         (mep_gdbarch_init): Don't register deleted functions with
3855         gdbarch.
3856
3857 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3858
3859         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
3860         (m68hc11_unwind_sp): Delete.
3861         (m68hc11_gdbarch_init): Don't register deleted functions with
3862         gdbarch.
3863
3864 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3865
3866         * m32r-tdep.c (m32r_unwind_sp): Delete.
3867         (m32r_unwind_pc): Delete.
3868         (m32r_dummy_id): Delete.
3869         (m32r_gdbarch_init): Don't register deleted functions with
3870         gdbarch.
3871
3872 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3873
3874         * m32c-tdep.c (m32c_unwind_pc): Delete.
3875         (m32c_unwind_sp): Delete.
3876         (m32c_dummy_id): Delete.
3877         (m32c_gdbarch_init): Don't register deleted functions with
3878         gdbarch.
3879
3880 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3881
3882         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
3883         (lm32_unwind_pc): Delete.
3884         (lm32_dummy_id): Delete.
3885         (lm32_gdbarch_init): Don't register deleted functions with
3886         gdbarch.
3887
3888 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3889
3890         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
3891         (iq2000_unwind_pc): Delete.
3892         (iq2000_dummy_id): Delete.
3893         (iq2000_gdbarch_init): Don't register deleted functions with
3894         gdbarch.
3895
3896 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3897
3898         * nds32-tdep.c (nds32_type_align): Delete.
3899         (nds32_push_dummy_call): Use type_align instead.
3900
3901 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3902
3903         * arm-tdep.c (arm_type_align): Only handle vector override case.
3904         (arm_push_dummy_call): Use type_align.
3905         (arm_gdbarch_init): Register arm_type_align gdbarch function.
3906
3907 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3908
3909         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
3910         case.
3911         (pass_on_stack): Use type_align.
3912         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
3913         function.
3914
3915 2019-04-23  Tom Tromey  <tromey@adacore.com>
3916
3917         * dwarf2read.c (line_header::file_name_at): Remove unused
3918         overload.
3919
3920 2019-04-23  Tom de Vries  <tdevries@suse.de>
3921
3922         PR gdb/24438
3923         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
3924         invocation.
3925
3926
3927 2019-03-27  Ali Tamur  <tamur@google.com>
3928
3929         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
3930         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
3931         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
3932         (dwarf_expr_context::get_addr_index): Likewise
3933         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
3934         (symbol_needs_eval_context::get_addr_index): Likewise
3935         (disassemble_dwarf_expression): Add DW_OP_addrx
3936         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
3937         (read_cutu_die_from_dwo): Update comment
3938         (skip_one_die): Add DW_FORM_addrx
3939         (read_attribute_value): Likewise
3940         (var_decode_location): Add DW_OP_addrx
3941         (dwarf2_const_value_attr): Add DW_FORM_addrx
3942         (dump_die_shallow): Likewise
3943         (dwarf2_fetch_constant_bytes): Likewise
3944         (decode_locdesc): Add DW_OP_addrx
3945         (skip_form_bytes): Add DW_FORM_addrx
3946
3947 2019-04-22  Ali Tamur  <tamur@google.com>
3948
3949         * MAINTAINERS (Write After Approval): Add self.
3950
3951 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
3952
3953         * solib-svr4.c (get_svr4_info): Add pspace parameter.
3954         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
3955         (open_symbol_file_object): Likewise.
3956         (svr4_default_sos): Add info parameter.
3957         (svr4_read_so_list): Likewise.
3958         (svr4_current_sos_direct): Adjust functions calls to pass down
3959         info.
3960         (svr4_current_sos_1): Add info parameter.
3961         (svr4_current_sos): Call get_svr4_info, pass info down to
3962         svr4_current_sos_1.
3963         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
3964         get_svr4_info.
3965         (svr4_in_dynsym_resolve_code): Pass current_program_space to
3966         get_svr4_info.
3967         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
3968         to get_svr4_info.
3969         (probes_table_remove_objfile_probes): Likewise.
3970         (register_solib_event_probe): Add info parameter.
3971         (solist_update_incremental): Pass info parameter down to
3972         svr4_read_so_list.
3973         (disable_probes_interface): Add info parameter.
3974         (svr4_handle_solib_event): Pass current_program_space to
3975         get_svr4_info.  Adjust disable_probes_interface cleanup.
3976         (svr4_create_probe_breakpoints): Add info parameter, pass it
3977         down to register_solib_event_probe.
3978         (svr4_create_solib_event_breakpoints): Add info parameter,
3979         pass it down to svr4_create_probe_breakpoints.
3980         (enable_break): Pass info down to
3981         svr4_create_solib_event_breakpoints.
3982         (svr4_solib_create_inferior_hook): Pass current_program_space to
3983         get_svr4_info.
3984         (svr4_clear_solib): Likewise.
3985
3986 2019-04-22  Pedro Alves  <palves@redhat.com>
3987
3988         * solib-svr4.c (svr4_free_objfile_observer): New.
3989         (probe_and_action::objfile): New field.
3990         (probes_table_htab_remove_objfile_probes)
3991         (probes_table_remove_objfile_probes): New functions.
3992         (register_solib_event_probe): Add 'objfile' parameter.  Store it
3993         in the new probe_and_action.  Don't store the probe in 'lookup'.
3994         (svr4_create_probe_breakpoints): Pass objfile to
3995         register_solib_event_probe.
3996         (_initialize_svr4_solib): Register a free_objfile observer.
3997
3998 2019-04-19  Tom Tromey  <tom@tromey.com>
3999
4000         * common/queue.h: Remove.
4001
4002 2019-04-19  Tom Tromey  <tom@tromey.com>
4003
4004         * event-loop.c: Don't include "common/queue.h".
4005
4006 2019-04-19  Tom Tromey  <tom@tromey.com>
4007
4008         * remote.c (remote_target): Use delete.
4009         * remote-notif.h: Include <list>, not "common/queue.h".
4010         (notif_client_p): Remove typedef.
4011         (remote_notif_state): Add constructor, destructor, initializer.
4012         <notif_queue>: Now a std::list.
4013         (remote_notif_state_xfree): Don't declare.
4014         * remote-notif.c (remote_notif_process, handle_notification)
4015         (remote_notif_state_allocate): Update.
4016         (~remote_notif_state): Rename from remote_notif_state_xfree.
4017
4018 2019-04-19  Tom Tromey  <tom@tromey.com>
4019
4020         * symfile.c (reread_symbols): Update.
4021         * objfiles.c (objfile_register_static_link)
4022         (objfile_lookup_static_link): Update
4023         (~objfile) Don't delete static_links.
4024         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4025
4026 2019-04-19  Tom Tromey  <tom@tromey.com>
4027
4028         * type-stack.h (struct type_stack) <insert>: Constify string.
4029         * type-stack.c (type_stack::insert): Constify string.
4030         * gdbtypes.h (lookup_template_type): Update.
4031         (address_space_name_to_int): Update.
4032         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4033         const.
4034         (lookup_template_type): Make name const.
4035         * c-exp.y: Update rules.
4036         (lex_one_token, classify_name, classify_inner_name)
4037         (c_print_token): Update.
4038         * p-exp.y: Update rules.
4039         (yylex): Update.
4040         * f-exp.y: Update rules.
4041         (yylex): Update.
4042         * d-exp.y: Update rules.
4043         (lex_one_token, classify_name, classify_inner_name): Update.
4044         * parse.c (write_dollar_variable, copy_name): Return std::string.
4045         * parser-defs.h (copy_name): Change return type.
4046         * m2-exp.y: Update rules.
4047         (yylex): Update.
4048         * go-exp.y (lex_one_token): Update.
4049         Update rules.
4050         (classify_unsafe_function, classify_packaged_name)
4051         (classify_name, yylex): Update.
4052
4053 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4054
4055         * configure.ac: add --enable-source-highlight switch.
4056         * configure: Regenerate.
4057         * top.c (print_gdb_version): plumb --enable-source-highlight
4058         status to "show configuration".
4059
4060 2019-04-19  Tom Tromey  <tromey@adacore.com>
4061
4062         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4063         Check ADA_TYPE_P.
4064         (empty_record, ada_template_to_fixed_record_type_1)
4065         (template_to_static_fixed_type)
4066         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4067         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4068         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4069         macros.
4070
4071 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4072
4073         PR symtab/24423:
4074         * source.c (print_source_lines_base): Advance "iter" when a
4075         control character is seen.
4076
4077 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4078
4079         * inferior.h (struct infcall_suspend_state_deleter):
4080         Catch exception in destructor to avoid crash.
4081
4082 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4083
4084         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4085         close to the add_com "shell".
4086
4087 2019-04-18  Tom Tromey  <tromey@adacore.com>
4088
4089         * process-stratum-target.h (class process_stratum_target)
4090         <stratum>: Add "final".
4091
4092 2019-04-17  Tom Tromey  <tromey@adacore.com>
4093
4094         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4095         against nullptr before use.
4096
4097 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4098
4099         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4100
4101 2019-04-17  Jim Wilson  <jimw@sifive.com>
4102             Andrew Burgess  <andrew.burgess@embecosm.com>
4103
4104         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4105         code read might fail, assume 4-byte breakpoint in that case.
4106
4107 2019-04-15  Leszek Swirski  <leszeks@google.com>
4108
4109         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4110         rather than a hand-rolled POD check when checking for forced MEMORY
4111         classification.
4112
4113 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4114
4115         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4116         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4117         function.
4118         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4119         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4120         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4121         declaration.
4122
4123 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4124
4125         * aarch64-linux-nat.c
4126         (aarch64_linux_nat_target::thread_architecture): Add override.
4127         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4128         each VQ.
4129
4130 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4131
4132         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4133
4134 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4135
4136         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4137         target types of size 96-bits, add some additional comments, and
4138         check that the builtin type we found was the correct size.
4139
4140 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4141
4142         * utils.c (prompt_for_continue): Don't restore the styling at the
4143         end, as applied_style has the wrong value.  This fixes styling in
4144         long lists of file names that are interrupted by the "Continue?"
4145         prompt.
4146
4147 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4148
4149         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4150         * c-lang.c (c_language_defn): Likewise.
4151         (cplus_language_defn): Likewise.
4152         (asm_language_defn): Likewise.
4153         (minimal_language_defn): Likewise.
4154         * d-lang.c (d_language_defn): Likewise.
4155         * f-lang.c (f_language_defn): Likewise.
4156         * go-lang.c (go_language_defn): Likewise.
4157         * language.c (unknown_language_defn): Likewise.
4158         (auto_language_defn): Likewise.
4159         * language.h (struct language_defn): Remove la_magic field.
4160         (LANG_MAGIC): Delete.
4161         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4162         * objc-lang.c (objc_language_defn): Likewise.
4163         * opencl-lang.c (opencl_language_defn): Likewise.
4164         * p-lang.c (pascal_language_defn): Likewise.
4165         * rust-lang.c (rust_language_defn): Likewise.
4166
4167 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4168
4169         * riscv-tdep.c (riscv_type_align): New function.
4170         (riscv_type_alignment): Delete.
4171         (riscv_arg_location): Use 'type_align'.
4172         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4173
4174 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4175
4176         * gdbtypes.c (type_align): A struct with no non-static fields also
4177         has alignment of 1.
4178
4179 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4180
4181         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4182         component to 0.
4183         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4184         member.
4185         (riscv_struct_info::analyse): New implementation using new
4186         analyse_inner member function.
4187         (riscv_struct_info::field_offset): New member function.
4188         (riscv_struct_info::m_offsets): New member variable.
4189         (riscv_struct_info::analyse_inner): New private member function,
4190         takes the old implementation of riscv_struct_info::analyse but
4191         extended to track field offsets.
4192         (riscv_call_arg_struct): Update the struct folding special cases
4193         to handle cases where empty C++ structs, which are non-zero
4194         length, are found.
4195         (riscv_arg_location): Initialise the length of each location, a
4196         non-zero length now indicates the location is in use.
4197         (riscv_push_dummy_call): Allow for the first location having a
4198         non-zero offset when setting up arguments.
4199         (riscv_return_value): Likewise, but for return values.
4200
4201 2019-04-11  Tom Tromey  <tromey@adacore.com>
4202
4203         * utils.c (internal_vproblem): Make "msg" const.
4204
4205 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4206
4207         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4208         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4209         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4210         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4211
4212 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4213
4214         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4215         function.
4216         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4217         of amd64_collect_native_gregset.
4218         (amd64_linux_nat_target::store_registers): Likewise.
4219
4220 2019-04-10  Tom Tromey  <tom@tromey.com>
4221
4222         * symtab.c (lookup_global_symbol_from_objfile)
4223         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4224         * objfiles.h (class separate_debug_iterator): New.
4225         (class separate_debug_range): New.
4226         (struct objfile) <separate_debug_objfiles>: New method.
4227         (objfile_separate_debug_iterate): Don't declare.
4228         * objfiles.c (separate_debug_iterator::operator++): Rename from
4229         objfile_separate_debug_iterate.
4230         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4231         iterator.
4232         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4233         iterator.
4234
4235 2019-04-10  Tom Tromey  <tom@tromey.com>
4236
4237         * symfile.c (reread_symbols): Remove old comment.
4238         * objfiles.c (free_all_objfiles): Fix a typo.
4239
4240 2019-04-10  Tom Tromey  <tom@tromey.com>
4241
4242         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4243         * minsyms.c (lookup_minimal_symbol): Use foreach.
4244         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4245         (lookup_minimal_symbol_solib_trampoline): Likewise.
4246         * symfile.c (reread_symbols): Use foreach.
4247
4248 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4249             Tom Tromey  <tromey@adacore.com>
4250
4251         PR rust/24414:
4252         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4253         (rust_lex_int_test): Change "value" to be LONGEST.
4254         (rust_lex_tests): Add test for long integer literal.
4255
4256 2019-04-09  Tom Tromey  <tromey@adacore.com>
4257
4258         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
4259         to bool.
4260         (extended_remote_target::attach): Update.
4261         (remote_target::remote_notice_new_inferior): Update.
4262         (remote_target::add_current_inferior_and_thread): Update.
4263         * inferior.c (exit_inferior_1): Use "false".
4264         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
4265
4266 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
4267
4268         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
4269         the "start" command.
4270
4271 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4272
4273         * python/py-inferior.c (infpy_thread_from_thread_handle):
4274         Adjust comments to reflect renaming of thread_from_thread_handle
4275         to thread_from_handle.  Adjust keywords.  Fix type error message.
4276         (inferior_object_methods): Add thread_from_handle.  Retain
4277         thread_from_thread_handle, but mark it as deprecated.
4278
4279 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4280
4281         * gdbthread.h (find_thread_by_handle): Revise declaration.
4282         * thread.c (find_thread_by_handle): Likewise.  Adjust
4283         implementation too.
4284         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
4285         support for buffer objects as handles.
4286
4287 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4288
4289         * python/py-infthread.c (thpy_thread_handle): New function.
4290         (thread_object_methods): Register thpy_thread_handle.
4291
4292 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4293
4294         * gdbthread.h (thread_to_thread_handle): Declare.
4295         * thread.c (gdbtypes.h): Include.
4296         (thread_to_thread_handle): New function.
4297
4298         * target.h (struct target_ops): Add thread_info_to_thread_handle.
4299         (target_thread_info_to_thread_handle): Declare.
4300         * target.c (target_thread_info_to_thread_handle): New function.
4301         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
4302         * target-delegates.c: Regenerate.
4303
4304         * linux-thread-db.c (class thread_db_target): Add method
4305         thread_info_to_thread_handle.
4306         (thread_db_target::thread_info_to_thread_handle): Define.
4307         * remote.c (class remote_target): Add new method
4308         thread_info_to_thread_handle.
4309         (remote_target::thread_info_to_thread_handle): Define.
4310
4311 2019-04-08  Pedro Alves  <palves@redhat.com>
4312
4313         * common/common-exceptions.c (throw_exception): Don't create
4314         named object to throw; throw directly.
4315         (throw_it): Likewise.  Don't initialize gdb_exception::message
4316         here, with new; pass FMT and AP to the ctor instead.
4317         * common/common-exceptions.h: Include <string>.
4318         (gdb_exception::gdb_exception(enum return_reason, enum errors,
4319         const char *, va_list)): New ctor.  Use std::make_shared.
4320         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
4321         errors)): Delete.
4322         (gdb_exception_error::gdb_exception_error(enum errors, const char
4323         *, va_list)): New.
4324         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
4325         Add assertion.
4326         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
4327         errors)): Delete.
4328         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
4329         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
4330         Add assertion.
4331
4332 2019-04-08  Tom Tromey  <tom@tromey.com>
4333
4334         * valops.c (value_rtti_indirect_type): Replace throw_exception
4335         with throw.
4336         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
4337         with throw.
4338         * thread.c (thr_try_catch_cmd): Replace throw_exception with
4339         throw.
4340         * target.c (target_translate_tls_address): Replace throw_exception
4341         with throw.
4342         * stack.c (frame_apply_command_count): Replace throw_exception
4343         with throw.
4344         * solib-spu.c (append_ocl_sos): Replace throw_exception with
4345         throw.
4346         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
4347         with throw.
4348         * rs6000-tdep.c (rs6000_frame_cache)
4349         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
4350         * remote.c: Replace throw_exception with throw.
4351         * record-full.c (record_full_message, record_full_wait_1)
4352         (record_full_restore): Replace throw_exception with throw.
4353         * record-btrace.c:
4354         (get_thread_current_frame_id, record_btrace_start_replaying)
4355         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
4356         (cmd_record_btrace_start): Replace throw_exception with throw.
4357         * parse.c (parse_exp_in_context_1): Replace throw_exception with
4358         throw.
4359         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
4360         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
4361         * linespec.c:
4362         (find_linespec_symbols): Replace throw_exception with throw.
4363         * infrun.c (displaced_step_prepare, resume): Replace
4364         throw_exception with throw.
4365         * infcmd.c (post_create_inferior): Replace throw_exception with
4366         throw.
4367         * inf-loop.c (inferior_event_handler): Replace throw_exception
4368         with throw.
4369         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
4370         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
4371         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
4372         (get_prev_frame_always, get_frame_pc_if_available)
4373         (get_frame_address_in_block_if_available, get_frame_language):
4374         Replace throw_exception with throw.
4375         * frame-unwind.c (frame_unwind_try_unwinder): Replace
4376         throw_exception with throw.
4377         * eval.c (fetch_subexp_value, evaluate_var_value)
4378         (evaluate_funcall, evaluate_subexp_standard): Replace
4379         throw_exception with throw.
4380         * dwarf2loc.c (call_site_find_chain)
4381         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
4382         Replace throw_exception with throw.
4383         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
4384         with throw.
4385         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
4386         throw.
4387         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
4388         * completer.c (complete_line_internal): Replace throw_exception
4389         with throw.
4390         * compile/compile-object-run.c (compile_object_run): Replace
4391         throw_exception with throw.
4392         * cli/cli-script.c (process_next_line): Replace throw_exception
4393         with throw.
4394         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
4395         (btrace_enable, btrace_maint_update_pt_packets): Replace
4396         throw_exception with throw.
4397         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
4398         throw_exception with throw.
4399         * break-catch-throw.c (re_set_exception_catchpoint): Replace
4400         throw_exception with throw.
4401         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
4402         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
4403         * aarch64-tdep.c (aarch64_make_prologue_cache)
4404         (aarch64_make_stub_cache): Replace throw_exception with throw.
4405
4406 2019-04-08  Tom Tromey  <tom@tromey.com>
4407
4408         * common/common-exceptions.c (throw_exception): Rename from
4409         throw_exception_cxx.  Remove old copy.  Make argument const.
4410         (throw_it): Create and throw exception objects directly.
4411         * common/common-exceptions.h (throw_exception): Make argument
4412         const.
4413         (struct gdb_exception_error): Add constructor.
4414         (struct gdb_exception_quit): Add constructor.
4415
4416 2019-04-08  Tom Tromey  <tom@tromey.com>
4417
4418         * common/common-exceptions.h (exception_rethrow): Don't declare.
4419         (TRY_SJLJ): Update comment.
4420         (TRY, CATCH, END_CATCH): Remove.
4421         * common/common-exceptions.c (exception_rethrow): Remove.
4422
4423 2019-04-08  Tom Tromey  <tom@tromey.com>
4424
4425         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
4426         Remove.
4427         (gdb_exception_error): Rename from
4428         gdb_exception_RETURN_MASK_ERROR.
4429         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
4430         (gdb_quit_bad_alloc): Update.
4431         * aarch64-tdep.c: Update.
4432         * ada-lang.c: Update.
4433         * ada-typeprint.c: Update.
4434         * ada-valprint.c: Update.
4435         * amd64-tdep.c: Update.
4436         * arch-utils.c: Update.
4437         * break-catch-throw.c: Update.
4438         * breakpoint.c: Update.
4439         * btrace.c: Update.
4440         * c-varobj.c: Update.
4441         * cli/cli-cmds.c: Update.
4442         * cli/cli-interp.c: Update.
4443         * cli/cli-script.c: Update.
4444         * common/common-exceptions.c: Update.
4445         * common/new-op.c: Update.
4446         * common/selftest.c: Update.
4447         * compile/compile-c-symbols.c: Update.
4448         * compile/compile-cplus-symbols.c: Update.
4449         * compile/compile-object-load.c: Update.
4450         * compile/compile-object-run.c: Update.
4451         * completer.c: Update.
4452         * corelow.c: Update.
4453         * cp-abi.c: Update.
4454         * cp-support.c: Update.
4455         * cp-valprint.c: Update.
4456         * darwin-nat.c: Update.
4457         * disasm-selftests.c: Update.
4458         * dtrace-probe.c: Update.
4459         * dwarf-index-cache.c: Update.
4460         * dwarf-index-write.c: Update.
4461         * dwarf2-frame-tailcall.c: Update.
4462         * dwarf2-frame.c: Update.
4463         * dwarf2loc.c: Update.
4464         * dwarf2read.c: Update.
4465         * eval.c: Update.
4466         * event-loop.c: Update.
4467         * event-top.c: Update.
4468         * exec.c: Update.
4469         * f-valprint.c: Update.
4470         * fbsd-tdep.c: Update.
4471         * frame-unwind.c: Update.
4472         * frame.c: Update.
4473         * gdbtypes.c: Update.
4474         * gnu-v3-abi.c: Update.
4475         * guile/guile-internal.h: Update.
4476         * guile/scm-block.c: Update.
4477         * guile/scm-breakpoint.c: Update.
4478         * guile/scm-cmd.c: Update.
4479         * guile/scm-disasm.c: Update.
4480         * guile/scm-frame.c: Update.
4481         * guile/scm-lazy-string.c: Update.
4482         * guile/scm-math.c: Update.
4483         * guile/scm-param.c: Update.
4484         * guile/scm-ports.c: Update.
4485         * guile/scm-pretty-print.c: Update.
4486         * guile/scm-symbol.c: Update.
4487         * guile/scm-symtab.c: Update.
4488         * guile/scm-type.c: Update.
4489         * guile/scm-value.c: Update.
4490         * i386-linux-tdep.c: Update.
4491         * i386-tdep.c: Update.
4492         * inf-loop.c: Update.
4493         * infcall.c: Update.
4494         * infcmd.c: Update.
4495         * infrun.c: Update.
4496         * jit.c: Update.
4497         * language.c: Update.
4498         * linespec.c: Update.
4499         * linux-fork.c: Update.
4500         * linux-nat.c: Update.
4501         * linux-tdep.c: Update.
4502         * linux-thread-db.c: Update.
4503         * main.c: Update.
4504         * mi/mi-cmd-break.c: Update.
4505         * mi/mi-cmd-stack.c: Update.
4506         * mi/mi-interp.c: Update.
4507         * mi/mi-main.c: Update.
4508         * objc-lang.c: Update.
4509         * p-valprint.c: Update.
4510         * parse.c: Update.
4511         * ppc-linux-tdep.c: Update.
4512         * printcmd.c: Update.
4513         * python/py-arch.c: Update.
4514         * python/py-breakpoint.c: Update.
4515         * python/py-cmd.c: Update.
4516         * python/py-finishbreakpoint.c: Update.
4517         * python/py-frame.c: Update.
4518         * python/py-framefilter.c: Update.
4519         * python/py-gdb-readline.c: Update.
4520         * python/py-inferior.c: Update.
4521         * python/py-infthread.c: Update.
4522         * python/py-lazy-string.c: Update.
4523         * python/py-linetable.c: Update.
4524         * python/py-objfile.c: Update.
4525         * python/py-param.c: Update.
4526         * python/py-prettyprint.c: Update.
4527         * python/py-progspace.c: Update.
4528         * python/py-record-btrace.c: Update.
4529         * python/py-record.c: Update.
4530         * python/py-symbol.c: Update.
4531         * python/py-type.c: Update.
4532         * python/py-unwind.c: Update.
4533         * python/py-utils.c: Update.
4534         * python/py-value.c: Update.
4535         * python/python.c: Update.
4536         * record-btrace.c: Update.
4537         * record-full.c: Update.
4538         * remote-fileio.c: Update.
4539         * remote.c: Update.
4540         * riscv-tdep.c: Update.
4541         * rs6000-aix-tdep.c: Update.
4542         * rs6000-tdep.c: Update.
4543         * rust-exp.y: Update.
4544         * rust-lang.c: Update.
4545         * s390-tdep.c: Update.
4546         * selftest-arch.c: Update.
4547         * solib-dsbt.c: Update.
4548         * solib-frv.c: Update.
4549         * solib-spu.c: Update.
4550         * solib-svr4.c: Update.
4551         * solib.c: Update.
4552         * sparc64-linux-tdep.c: Update.
4553         * stack.c: Update.
4554         * symfile-mem.c: Update.
4555         * symmisc.c: Update.
4556         * target.c: Update.
4557         * thread.c: Update.
4558         * top.c: Update.
4559         * tracefile-tfile.c: Update.
4560         * tui/tui.c: Update.
4561         * typeprint.c: Update.
4562         * unittests/cli-utils-selftests.c: Update.
4563         * unittests/parse-connection-spec-selftests.c: Update.
4564         * valops.c: Update.
4565         * valprint.c: Update.
4566         * value.c: Update.
4567         * varobj.c: Update.
4568         * windows-nat.c: Update.
4569         * x86-linux-nat.c: Update.
4570         * xml-support.c: Update.
4571
4572 2019-04-08  Tom Tromey  <tom@tromey.com>
4573
4574         * xml-support.c: Use C++ exception handling.
4575         * x86-linux-nat.c: Use C++ exception handling.
4576         * windows-nat.c: Use C++ exception handling.
4577         * varobj.c: Use C++ exception handling.
4578         * value.c: Use C++ exception handling.
4579         * valprint.c: Use C++ exception handling.
4580         * valops.c: Use C++ exception handling.
4581         * unittests/parse-connection-spec-selftests.c: Use C++ exception
4582         handling.
4583         * unittests/cli-utils-selftests.c: Use C++ exception handling.
4584         * typeprint.c: Use C++ exception handling.
4585         * tui/tui.c: Use C++ exception handling.
4586         * tracefile-tfile.c: Use C++ exception handling.
4587         * top.c: Use C++ exception handling.
4588         * thread.c: Use C++ exception handling.
4589         * target.c: Use C++ exception handling.
4590         * symmisc.c: Use C++ exception handling.
4591         * symfile-mem.c: Use C++ exception handling.
4592         * stack.c: Use C++ exception handling.
4593         * sparc64-linux-tdep.c: Use C++ exception handling.
4594         * solib.c: Use C++ exception handling.
4595         * solib-svr4.c: Use C++ exception handling.
4596         * solib-spu.c: Use C++ exception handling.
4597         * solib-frv.c: Use C++ exception handling.
4598         * solib-dsbt.c: Use C++ exception handling.
4599         * selftest-arch.c: Use C++ exception handling.
4600         * s390-tdep.c: Use C++ exception handling.
4601         * rust-lang.c: Use C++ exception handling.
4602         * rust-exp.y: Use C++ exception handling.
4603         * rs6000-tdep.c: Use C++ exception handling.
4604         * rs6000-aix-tdep.c: Use C++ exception handling.
4605         * riscv-tdep.c: Use C++ exception handling.
4606         * remote.c: Use C++ exception handling.
4607         * remote-fileio.c: Use C++ exception handling.
4608         * record-full.c: Use C++ exception handling.
4609         * record-btrace.c: Use C++ exception handling.
4610         * python/python.c: Use C++ exception handling.
4611         * python/py-value.c: Use C++ exception handling.
4612         * python/py-utils.c: Use C++ exception handling.
4613         * python/py-unwind.c: Use C++ exception handling.
4614         * python/py-type.c: Use C++ exception handling.
4615         * python/py-symbol.c: Use C++ exception handling.
4616         * python/py-record.c: Use C++ exception handling.
4617         * python/py-record-btrace.c: Use C++ exception handling.
4618         * python/py-progspace.c: Use C++ exception handling.
4619         * python/py-prettyprint.c: Use C++ exception handling.
4620         * python/py-param.c: Use C++ exception handling.
4621         * python/py-objfile.c: Use C++ exception handling.
4622         * python/py-linetable.c: Use C++ exception handling.
4623         * python/py-lazy-string.c: Use C++ exception handling.
4624         * python/py-infthread.c: Use C++ exception handling.
4625         * python/py-inferior.c: Use C++ exception handling.
4626         * python/py-gdb-readline.c: Use C++ exception handling.
4627         * python/py-framefilter.c: Use C++ exception handling.
4628         * python/py-frame.c: Use C++ exception handling.
4629         * python/py-finishbreakpoint.c: Use C++ exception handling.
4630         * python/py-cmd.c: Use C++ exception handling.
4631         * python/py-breakpoint.c: Use C++ exception handling.
4632         * python/py-arch.c: Use C++ exception handling.
4633         * printcmd.c: Use C++ exception handling.
4634         * ppc-linux-tdep.c: Use C++ exception handling.
4635         * parse.c: Use C++ exception handling.
4636         * p-valprint.c: Use C++ exception handling.
4637         * objc-lang.c: Use C++ exception handling.
4638         * mi/mi-main.c: Use C++ exception handling.
4639         * mi/mi-interp.c: Use C++ exception handling.
4640         * mi/mi-cmd-stack.c: Use C++ exception handling.
4641         * mi/mi-cmd-break.c: Use C++ exception handling.
4642         * main.c: Use C++ exception handling.
4643         * linux-thread-db.c: Use C++ exception handling.
4644         * linux-tdep.c: Use C++ exception handling.
4645         * linux-nat.c: Use C++ exception handling.
4646         * linux-fork.c: Use C++ exception handling.
4647         * linespec.c: Use C++ exception handling.
4648         * language.c: Use C++ exception handling.
4649         * jit.c: Use C++ exception handling.
4650         * infrun.c: Use C++ exception handling.
4651         * infcmd.c: Use C++ exception handling.
4652         * infcall.c: Use C++ exception handling.
4653         * inf-loop.c: Use C++ exception handling.
4654         * i386-tdep.c: Use C++ exception handling.
4655         * i386-linux-tdep.c: Use C++ exception handling.
4656         * guile/scm-value.c: Use C++ exception handling.
4657         * guile/scm-type.c: Use C++ exception handling.
4658         * guile/scm-symtab.c: Use C++ exception handling.
4659         * guile/scm-symbol.c: Use C++ exception handling.
4660         * guile/scm-pretty-print.c: Use C++ exception handling.
4661         * guile/scm-ports.c: Use C++ exception handling.
4662         * guile/scm-param.c: Use C++ exception handling.
4663         * guile/scm-math.c: Use C++ exception handling.
4664         * guile/scm-lazy-string.c: Use C++ exception handling.
4665         * guile/scm-frame.c: Use C++ exception handling.
4666         * guile/scm-disasm.c: Use C++ exception handling.
4667         * guile/scm-cmd.c: Use C++ exception handling.
4668         * guile/scm-breakpoint.c: Use C++ exception handling.
4669         * guile/scm-block.c: Use C++ exception handling.
4670         * guile/guile-internal.h: Use C++ exception handling.
4671         * gnu-v3-abi.c: Use C++ exception handling.
4672         * gdbtypes.c: Use C++ exception handling.
4673         * frame.c: Use C++ exception handling.
4674         * frame-unwind.c: Use C++ exception handling.
4675         * fbsd-tdep.c: Use C++ exception handling.
4676         * f-valprint.c: Use C++ exception handling.
4677         * exec.c: Use C++ exception handling.
4678         * event-top.c: Use C++ exception handling.
4679         * event-loop.c: Use C++ exception handling.
4680         * eval.c: Use C++ exception handling.
4681         * dwarf2read.c: Use C++ exception handling.
4682         * dwarf2loc.c: Use C++ exception handling.
4683         * dwarf2-frame.c: Use C++ exception handling.
4684         * dwarf2-frame-tailcall.c: Use C++ exception handling.
4685         * dwarf-index-write.c: Use C++ exception handling.
4686         * dwarf-index-cache.c: Use C++ exception handling.
4687         * dtrace-probe.c: Use C++ exception handling.
4688         * disasm-selftests.c: Use C++ exception handling.
4689         * darwin-nat.c: Use C++ exception handling.
4690         * cp-valprint.c: Use C++ exception handling.
4691         * cp-support.c: Use C++ exception handling.
4692         * cp-abi.c: Use C++ exception handling.
4693         * corelow.c: Use C++ exception handling.
4694         * completer.c: Use C++ exception handling.
4695         * compile/compile-object-run.c: Use C++ exception handling.
4696         * compile/compile-object-load.c: Use C++ exception handling.
4697         * compile/compile-cplus-symbols.c: Use C++ exception handling.
4698         * compile/compile-c-symbols.c: Use C++ exception handling.
4699         * common/selftest.c: Use C++ exception handling.
4700         * common/new-op.c: Use C++ exception handling.
4701         * cli/cli-script.c: Use C++ exception handling.
4702         * cli/cli-interp.c: Use C++ exception handling.
4703         * cli/cli-cmds.c: Use C++ exception handling.
4704         * c-varobj.c: Use C++ exception handling.
4705         * btrace.c: Use C++ exception handling.
4706         * breakpoint.c: Use C++ exception handling.
4707         * break-catch-throw.c: Use C++ exception handling.
4708         * arch-utils.c: Use C++ exception handling.
4709         * amd64-tdep.c: Use C++ exception handling.
4710         * ada-valprint.c: Use C++ exception handling.
4711         * ada-typeprint.c: Use C++ exception handling.
4712         * ada-lang.c: Use C++ exception handling.
4713         * aarch64-tdep.c: Use C++ exception handling.
4714
4715 2019-04-08  Tom Tromey  <tom@tromey.com>
4716
4717         * xml-support.c (gdb_xml_parser::parse): Update.
4718         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4719         * value.c (show_convenience): Update.
4720         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
4721         (test_parse_flags_qcs): Update.
4722         * thread.c (thr_try_catch_cmd): Update.
4723         * target.c (target_translate_tls_address): Update.
4724         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4725         (info_frame_command_core, frame_apply_command_count): Update.
4726         * rust-exp.y (rust_lex_exception_test): Update.
4727         * riscv-tdep.c (riscv_print_one_register_info): Update.
4728         * remote.c (remote_target::enable_btrace): Update.
4729         * record-btrace.c (record_btrace_enable_warn): Update.
4730         * python/py-utils.c (gdbpy_convert_exception): Update.
4731         * printcmd.c (do_one_display, print_variable_and_value): Update.
4732         * mi/mi-main.c (mi_print_exception): Update.
4733         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
4734         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4735         * linux-nat.c (linux_nat_target::attach): Update.
4736         * linux-fork.c (class scoped_switch_fork_info): Update.
4737         * infrun.c (displaced_step_prepare): Update.
4738         * infcall.c (call_function_by_hand_dummy): Update.
4739         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
4740         * gnu-v3-abi.c (print_one_vtable): Update.
4741         * frame.c (get_prev_frame_always): Update.
4742         * f-valprint.c (info_common_command_for_block): Update.
4743         * exec.c (try_open_exec_file): Update.
4744         * exceptions.c (print_exception, exception_print)
4745         (exception_fprintf, exception_print_same): Update.
4746         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
4747         * dwarf-index-cache.c (index_cache::store)
4748         (index_cache::lookup_gdb_index): Update.
4749         * darwin-nat.c (maybe_cache_shell): Update.
4750         * cp-valprint.c (cp_print_value_fields): Update.
4751         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
4752         (gcc_cplus_symbol_address): Update.
4753         * compile/compile-c-symbols.c (gcc_convert_symbol)
4754         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
4755         * common/selftest.c: Update.
4756         * common/common-exceptions.h (struct gdb_exception) <message>: Now
4757         a std::string.
4758         (exception_try_scope_entry, exception_try_scope_exit): Don't
4759         declare.
4760         (struct exception_try_scope): Remove.
4761         (TRY): Don't use exception_try_scope.
4762         (struct gdb_exception): Add constructor, operator=.
4763         <what>: New method.
4764         (struct gdb_exception_RETURN_MASK_ALL)
4765         (struct gdb_exception_RETURN_MASK_ERROR)
4766         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
4767         (struct gdb_quit_bad_alloc): Update.
4768         * common/common-exceptions.c (exception_none): Change
4769         initializer.
4770         (struct catcher) <state, exception>: Initialize inline.
4771         <prev>: Remove member.
4772         (current_catcher): Remove.
4773         (catchers): New global.
4774         (exceptions_state_mc_init): Simplify.
4775         (catcher_pop): Remove.
4776         (exceptions_state_mc, exceptions_state_mc_catch): Update.
4777         (try_scope_depth, exception_try_scope_entry)
4778         (exception_try_scope_exit): Remove.
4779         (throw_exception_sjlj): Update.
4780         (exception_messages, exception_messages_size): Remove.
4781         (throw_it): Simplify.
4782         (gdb_exception_sliced_copy): Remove.
4783         (throw_exception_cxx): Update.
4784         * cli/cli-script.c (script_from_file): Update.
4785         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
4786         Update.
4787         * ada-valprint.c (ada_val_print): Update.
4788         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
4789         (create_excep_cond_exprs): Update.
4790
4791 2019-04-08  Tom Tromey  <tom@tromey.com>
4792
4793         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
4794         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
4795         (TRY, CATCH, END_CATCH): Remove some definitions.
4796         * common/common-exceptions.c: Don't use GDB_XCPT.
4797         (catcher_list_size): Remove.
4798         (throw_exception, throw_it): Simplify.
4799
4800 2019-04-05  Tom Tromey  <tom@tromey.com>
4801
4802         Revert the header-sorting patch.
4803         * ft32-tdep.c: Revert.
4804         * frv-tdep.c: Revert.
4805         * frv-linux-tdep.c: Revert.
4806         * frame.c: Revert.
4807         * frame-unwind.c: Revert.
4808         * frame-base.c: Revert.
4809         * fork-child.c: Revert.
4810         * findvar.c: Revert.
4811         * findcmd.c: Revert.
4812         * filesystem.c: Revert.
4813         * filename-seen-cache.h: Revert.
4814         * filename-seen-cache.c: Revert.
4815         * fbsd-tdep.c: Revert.
4816         * fbsd-nat.h: Revert.
4817         * fbsd-nat.c: Revert.
4818         * f-valprint.c: Revert.
4819         * f-typeprint.c: Revert.
4820         * f-lang.c: Revert.
4821         * extension.h: Revert.
4822         * extension.c: Revert.
4823         * extension-priv.h: Revert.
4824         * expprint.c: Revert.
4825         * exec.h: Revert.
4826         * exec.c: Revert.
4827         * exceptions.c: Revert.
4828         * event-top.c: Revert.
4829         * event-loop.c: Revert.
4830         * eval.c: Revert.
4831         * elfread.c: Revert.
4832         * dwarf2read.h: Revert.
4833         * dwarf2read.c: Revert.
4834         * dwarf2loc.c: Revert.
4835         * dwarf2expr.h: Revert.
4836         * dwarf2expr.c: Revert.
4837         * dwarf2-frame.c: Revert.
4838         * dwarf2-frame-tailcall.c: Revert.
4839         * dwarf-index-write.h: Revert.
4840         * dwarf-index-write.c: Revert.
4841         * dwarf-index-common.c: Revert.
4842         * dwarf-index-cache.h: Revert.
4843         * dwarf-index-cache.c: Revert.
4844         * dummy-frame.c: Revert.
4845         * dtrace-probe.c: Revert.
4846         * disasm.h: Revert.
4847         * disasm.c: Revert.
4848         * disasm-selftests.c: Revert.
4849         * dictionary.c: Revert.
4850         * dicos-tdep.c: Revert.
4851         * demangle.c: Revert.
4852         * dcache.h: Revert.
4853         * dcache.c: Revert.
4854         * darwin-nat.h: Revert.
4855         * darwin-nat.c: Revert.
4856         * darwin-nat-info.c: Revert.
4857         * d-valprint.c: Revert.
4858         * d-namespace.c: Revert.
4859         * d-lang.c: Revert.
4860         * ctf.c: Revert.
4861         * csky-tdep.c: Revert.
4862         * csky-linux-tdep.c: Revert.
4863         * cris-tdep.c: Revert.
4864         * cris-linux-tdep.c: Revert.
4865         * cp-valprint.c: Revert.
4866         * cp-support.c: Revert.
4867         * cp-namespace.c: Revert.
4868         * cp-abi.c: Revert.
4869         * corelow.c: Revert.
4870         * corefile.c: Revert.
4871         * continuations.c: Revert.
4872         * completer.h: Revert.
4873         * completer.c: Revert.
4874         * complaints.c: Revert.
4875         * coffread.c: Revert.
4876         * coff-pe-read.c: Revert.
4877         * cli-out.h: Revert.
4878         * cli-out.c: Revert.
4879         * charset.c: Revert.
4880         * c-varobj.c: Revert.
4881         * c-valprint.c: Revert.
4882         * c-typeprint.c: Revert.
4883         * c-lang.c: Revert.
4884         * buildsym.c: Revert.
4885         * buildsym-legacy.c: Revert.
4886         * build-id.h: Revert.
4887         * build-id.c: Revert.
4888         * btrace.c: Revert.
4889         * bsd-uthread.c: Revert.
4890         * breakpoint.h: Revert.
4891         * breakpoint.c: Revert.
4892         * break-catch-throw.c: Revert.
4893         * break-catch-syscall.c: Revert.
4894         * break-catch-sig.c: Revert.
4895         * blockframe.c: Revert.
4896         * block.c: Revert.
4897         * bfin-tdep.c: Revert.
4898         * bfin-linux-tdep.c: Revert.
4899         * bfd-target.c: Revert.
4900         * bcache.c: Revert.
4901         * ax-general.c: Revert.
4902         * ax-gdb.h: Revert.
4903         * ax-gdb.c: Revert.
4904         * avr-tdep.c: Revert.
4905         * auxv.c: Revert.
4906         * auto-load.c: Revert.
4907         * arm-wince-tdep.c: Revert.
4908         * arm-tdep.c: Revert.
4909         * arm-symbian-tdep.c: Revert.
4910         * arm-pikeos-tdep.c: Revert.
4911         * arm-obsd-tdep.c: Revert.
4912         * arm-nbsd-tdep.c: Revert.
4913         * arm-nbsd-nat.c: Revert.
4914         * arm-linux-tdep.c: Revert.
4915         * arm-linux-nat.c: Revert.
4916         * arm-fbsd-tdep.c: Revert.
4917         * arm-fbsd-nat.c: Revert.
4918         * arm-bsd-tdep.c: Revert.
4919         * arch-utils.c: Revert.
4920         * arc-tdep.c: Revert.
4921         * arc-newlib-tdep.c: Revert.
4922         * annotate.h: Revert.
4923         * annotate.c: Revert.
4924         * amd64-windows-tdep.c: Revert.
4925         * amd64-windows-nat.c: Revert.
4926         * amd64-tdep.c: Revert.
4927         * amd64-sol2-tdep.c: Revert.
4928         * amd64-obsd-tdep.c: Revert.
4929         * amd64-obsd-nat.c: Revert.
4930         * amd64-nbsd-tdep.c: Revert.
4931         * amd64-nbsd-nat.c: Revert.
4932         * amd64-nat.c: Revert.
4933         * amd64-linux-tdep.c: Revert.
4934         * amd64-linux-nat.c: Revert.
4935         * amd64-fbsd-tdep.c: Revert.
4936         * amd64-fbsd-nat.c: Revert.
4937         * amd64-dicos-tdep.c: Revert.
4938         * amd64-darwin-tdep.c: Revert.
4939         * amd64-bsd-nat.c: Revert.
4940         * alpha-tdep.c: Revert.
4941         * alpha-obsd-tdep.c: Revert.
4942         * alpha-nbsd-tdep.c: Revert.
4943         * alpha-mdebug-tdep.c: Revert.
4944         * alpha-linux-tdep.c: Revert.
4945         * alpha-linux-nat.c: Revert.
4946         * alpha-bsd-tdep.c: Revert.
4947         * alpha-bsd-nat.c: Revert.
4948         * aix-thread.c: Revert.
4949         * agent.c: Revert.
4950         * addrmap.c: Revert.
4951         * ada-varobj.c: Revert.
4952         * ada-valprint.c: Revert.
4953         * ada-typeprint.c: Revert.
4954         * ada-tasks.c: Revert.
4955         * ada-lang.c: Revert.
4956         * aarch64-tdep.c: Revert.
4957         * aarch64-ravenscar-thread.c: Revert.
4958         * aarch64-newlib-tdep.c: Revert.
4959         * aarch64-linux-tdep.c: Revert.
4960         * aarch64-linux-nat.c: Revert.
4961         * aarch64-fbsd-tdep.c: Revert.
4962         * aarch64-fbsd-nat.c: Revert.
4963         * aarch32-linux-nat.c: Revert.
4964
4965 2019-04-05  Tom Tromey  <tom@tromey.com>
4966
4967         * ft32-tdep.c: Sort headers.
4968         * frv-tdep.c: Sort headers.
4969         * frv-linux-tdep.c: Sort headers.
4970         * frame.c: Sort headers.
4971         * frame-unwind.c: Sort headers.
4972         * frame-base.c: Sort headers.
4973         * fork-child.c: Sort headers.
4974         * findvar.c: Sort headers.
4975         * findcmd.c: Sort headers.
4976         * filesystem.c: Sort headers.
4977         * filename-seen-cache.h: Sort headers.
4978         * filename-seen-cache.c: Sort headers.
4979         * fbsd-tdep.c: Sort headers.
4980         * fbsd-nat.h: Sort headers.
4981         * fbsd-nat.c: Sort headers.
4982         * f-valprint.c: Sort headers.
4983         * f-typeprint.c: Sort headers.
4984         * f-lang.c: Sort headers.
4985         * extension.h: Sort headers.
4986         * extension.c: Sort headers.
4987         * extension-priv.h: Sort headers.
4988         * expprint.c: Sort headers.
4989         * exec.h: Sort headers.
4990         * exec.c: Sort headers.
4991         * exceptions.c: Sort headers.
4992         * event-top.c: Sort headers.
4993         * event-loop.c: Sort headers.
4994         * eval.c: Sort headers.
4995         * elfread.c: Sort headers.
4996         * dwarf2read.h: Sort headers.
4997         * dwarf2read.c: Sort headers.
4998         * dwarf2loc.c: Sort headers.
4999         * dwarf2expr.h: Sort headers.
5000         * dwarf2expr.c: Sort headers.
5001         * dwarf2-frame.c: Sort headers.
5002         * dwarf2-frame-tailcall.c: Sort headers.
5003         * dwarf-index-write.h: Sort headers.
5004         * dwarf-index-write.c: Sort headers.
5005         * dwarf-index-common.c: Sort headers.
5006         * dwarf-index-cache.h: Sort headers.
5007         * dwarf-index-cache.c: Sort headers.
5008         * dummy-frame.c: Sort headers.
5009         * dtrace-probe.c: Sort headers.
5010         * disasm.h: Sort headers.
5011         * disasm.c: Sort headers.
5012         * disasm-selftests.c: Sort headers.
5013         * dictionary.c: Sort headers.
5014         * dicos-tdep.c: Sort headers.
5015         * demangle.c: Sort headers.
5016         * dcache.h: Sort headers.
5017         * dcache.c: Sort headers.
5018         * darwin-nat.h: Sort headers.
5019         * darwin-nat.c: Sort headers.
5020         * darwin-nat-info.c: Sort headers.
5021         * d-valprint.c: Sort headers.
5022         * d-namespace.c: Sort headers.
5023         * d-lang.c: Sort headers.
5024         * ctf.c: Sort headers.
5025         * csky-tdep.c: Sort headers.
5026         * csky-linux-tdep.c: Sort headers.
5027         * cris-tdep.c: Sort headers.
5028         * cris-linux-tdep.c: Sort headers.
5029         * cp-valprint.c: Sort headers.
5030         * cp-support.c: Sort headers.
5031         * cp-namespace.c: Sort headers.
5032         * cp-abi.c: Sort headers.
5033         * corelow.c: Sort headers.
5034         * corefile.c: Sort headers.
5035         * continuations.c: Sort headers.
5036         * completer.h: Sort headers.
5037         * completer.c: Sort headers.
5038         * complaints.c: Sort headers.
5039         * coffread.c: Sort headers.
5040         * coff-pe-read.c: Sort headers.
5041         * cli-out.h: Sort headers.
5042         * cli-out.c: Sort headers.
5043         * charset.c: Sort headers.
5044         * c-varobj.c: Sort headers.
5045         * c-valprint.c: Sort headers.
5046         * c-typeprint.c: Sort headers.
5047         * c-lang.c: Sort headers.
5048         * buildsym.c: Sort headers.
5049         * buildsym-legacy.c: Sort headers.
5050         * build-id.h: Sort headers.
5051         * build-id.c: Sort headers.
5052         * btrace.c: Sort headers.
5053         * bsd-uthread.c: Sort headers.
5054         * breakpoint.h: Sort headers.
5055         * breakpoint.c: Sort headers.
5056         * break-catch-throw.c: Sort headers.
5057         * break-catch-syscall.c: Sort headers.
5058         * break-catch-sig.c: Sort headers.
5059         * blockframe.c: Sort headers.
5060         * block.c: Sort headers.
5061         * bfin-tdep.c: Sort headers.
5062         * bfin-linux-tdep.c: Sort headers.
5063         * bfd-target.c: Sort headers.
5064         * bcache.c: Sort headers.
5065         * ax-general.c: Sort headers.
5066         * ax-gdb.h: Sort headers.
5067         * ax-gdb.c: Sort headers.
5068         * avr-tdep.c: Sort headers.
5069         * auxv.c: Sort headers.
5070         * auto-load.c: Sort headers.
5071         * arm-wince-tdep.c: Sort headers.
5072         * arm-tdep.c: Sort headers.
5073         * arm-symbian-tdep.c: Sort headers.
5074         * arm-pikeos-tdep.c: Sort headers.
5075         * arm-obsd-tdep.c: Sort headers.
5076         * arm-nbsd-tdep.c: Sort headers.
5077         * arm-nbsd-nat.c: Sort headers.
5078         * arm-linux-tdep.c: Sort headers.
5079         * arm-linux-nat.c: Sort headers.
5080         * arm-fbsd-tdep.c: Sort headers.
5081         * arm-fbsd-nat.c: Sort headers.
5082         * arm-bsd-tdep.c: Sort headers.
5083         * arch-utils.c: Sort headers.
5084         * arc-tdep.c: Sort headers.
5085         * arc-newlib-tdep.c: Sort headers.
5086         * annotate.h: Sort headers.
5087         * annotate.c: Sort headers.
5088         * amd64-windows-tdep.c: Sort headers.
5089         * amd64-windows-nat.c: Sort headers.
5090         * amd64-tdep.c: Sort headers.
5091         * amd64-sol2-tdep.c: Sort headers.
5092         * amd64-obsd-tdep.c: Sort headers.
5093         * amd64-obsd-nat.c: Sort headers.
5094         * amd64-nbsd-tdep.c: Sort headers.
5095         * amd64-nbsd-nat.c: Sort headers.
5096         * amd64-nat.c: Sort headers.
5097         * amd64-linux-tdep.c: Sort headers.
5098         * amd64-linux-nat.c: Sort headers.
5099         * amd64-fbsd-tdep.c: Sort headers.
5100         * amd64-fbsd-nat.c: Sort headers.
5101         * amd64-dicos-tdep.c: Sort headers.
5102         * amd64-darwin-tdep.c: Sort headers.
5103         * amd64-bsd-nat.c: Sort headers.
5104         * alpha-tdep.c: Sort headers.
5105         * alpha-obsd-tdep.c: Sort headers.
5106         * alpha-nbsd-tdep.c: Sort headers.
5107         * alpha-mdebug-tdep.c: Sort headers.
5108         * alpha-linux-tdep.c: Sort headers.
5109         * alpha-linux-nat.c: Sort headers.
5110         * alpha-bsd-tdep.c: Sort headers.
5111         * alpha-bsd-nat.c: Sort headers.
5112         * aix-thread.c: Sort headers.
5113         * agent.c: Sort headers.
5114         * addrmap.c: Sort headers.
5115         * ada-varobj.c: Sort headers.
5116         * ada-valprint.c: Sort headers.
5117         * ada-typeprint.c: Sort headers.
5118         * ada-tasks.c: Sort headers.
5119         * ada-lang.c: Sort headers.
5120         * aarch64-tdep.c: Sort headers.
5121         * aarch64-ravenscar-thread.c: Sort headers.
5122         * aarch64-newlib-tdep.c: Sort headers.
5123         * aarch64-linux-tdep.c: Sort headers.
5124         * aarch64-linux-nat.c: Sort headers.
5125         * aarch64-fbsd-tdep.c: Sort headers.
5126         * aarch64-fbsd-nat.c: Sort headers.
5127         * aarch32-linux-nat.c: Sort headers.
5128
5129 2019-04-04  Tom Tromey  <tom@tromey.com>
5130
5131         * varobj.c (varobj_create): Update.
5132         * rust-exp.y (struct rust_parser) <update_innermost_block,
5133         lookup_symbol>: New methods.
5134         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5135         Rename.
5136         (rust_parser::rust_lookup_type)
5137         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5138         * printcmd.c (display_command, do_one_display): Update.
5139         * parser-defs.h (struct parser_state) <parser_state>: Add
5140         "tracker" parameter.
5141         (block_tracker): New member.
5142         (class innermost_block_tracker) <innermost_block_tracker>: Add
5143         "types" parameter.
5144         <reset>: Remove method.
5145         (innermost_block): Don't declare.
5146         (null_post_parser): Update.
5147         * parse.c (innermost_block): Remove global.
5148         (write_dollar_variable): Update.
5149         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5150         Remove "tracker_types" parameter.
5151         (parse_expression): Add "tracker" parameter.
5152         (parse_expression_for_completion): Update.
5153         (null_post_parser): Add "tracker" parameter.
5154         * p-exp.y: Update rules.
5155         * m2-exp.y: Update rules.
5156         * language.h (struct language_defn) <la_post_parser>: Add
5157         "tracker" parameter.
5158         * go-exp.y: Update rules.
5159         * f-exp.y: Update rules.
5160         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5161         parameter.
5162         * d-exp.y: Update rules.
5163         * c-exp.y: Update rules.
5164         * breakpoint.c (set_breakpoint_condition): Create an
5165         innermost_block_tracker.
5166         (watch_command_1): Likewise.
5167         * ada-lang.c (resolve): Add "tracker" parameter.
5168         (resolve_subexp): Likewise.
5169         * ada-exp.y (write_var_from_sym): Update.
5170
5171 2019-04-04  Tom Tromey  <tom@tromey.com>
5172
5173         * type-stack.h: New file.
5174         * type-stack.c: New file.
5175         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5176         type-stack.h.
5177         (insert_into_type_stack, insert_type, push_type, push_type_int)
5178         (insert_type_address_space, pop_type, pop_type_int)
5179         (pop_typelist, pop_type_stack, append_type_stack)
5180         (push_type_stack, get_type_stack, push_typelist)
5181         (follow_type_instance_flags, follow_types): Don't declare.
5182         * parse.c (type_stack): Remove global.
5183         (parse_exp_in_context): Update.
5184         (insert_into_type_stack, insert_type, push_type, push_type_int)
5185         (insert_type_address_space, pop_type, pop_type_int)
5186         (pop_typelist, pop_type_stack, append_type_stack)
5187         (push_type_stack, get_type_stack, push_typelist)
5188         (follow_type_instance_flags, follow_types): Remove (moved to
5189         type-stack.c).
5190         * f-exp.y (type_stack): New global.
5191         Update rules.
5192         (push_kind_type, f_parse): Update.
5193         * d-exp.y (type_stack): New global.
5194         Update rules.
5195         (d_parse): Update.
5196         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5197         Update rules.
5198         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5199         (HFILES_NO_SRCDIR): Add type-stack.h.
5200
5201 2019-04-04  Tom Tromey  <tom@tromey.com>
5202
5203         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5204         (rust_parser::convert_ast_to_expression, rust_parse)
5205         (rust_lex_test_completion, rust_lex_tests): Update.
5206         * parser-defs.h (struct expr_completion_state): New.
5207         (struct parser_state) <parser_state>: Add completion parameter.
5208         <mark_struct_expression, mark_completion_tag>: New methods.
5209         <parse_completion, m_completion_state>: New members.
5210         (prefixify_expression, null_post_parser): Update.
5211         (mark_struct_expression, mark_completion_tag): Don't declare.
5212         * parse.c (parse_completion, expout_last_struct)
5213         (expout_tag_completion_type, expout_completion_name): Remove
5214         globals.
5215         (parser_state::mark_struct_expression)
5216         (parser_state::mark_completion_tag): Now methods.
5217         (prefixify_expression): Add last_struct parameter.
5218         (prefixify_subexp): Likewise.
5219         (parse_exp_1): Update.
5220         (parse_exp_in_context): Add cstate parameter.  Update.
5221         (parse_expression_for_completion): Create an
5222         expr_completion_state.
5223         (null_post_parser): Add "completion" parameter.
5224         * p-exp.y: Update rules.
5225         (yylex): Update.
5226         * language.h (struct language_defn) <la_post_parser>: Add
5227         "completing" parameter.
5228         * go-exp.y: Update rules.
5229         (lex_one_token): Update.
5230         * expression.h (parse_completion): Don't declare.
5231         * d-exp.y: Update rules.
5232         (lex_one_token): Update rules.
5233         * c-exp.y: Update rules.
5234         (lex_one_token): Update.
5235         * ada-lang.c (resolve): Add "parse_completion" parameter.
5236         (resolve_subexp): Likewise.
5237         (ada_resolve_function): Likewise.
5238
5239 2019-04-04  Tom Tromey  <tom@tromey.com>
5240
5241         * parser-defs.h (struct parser_state) <start_arglist,
5242         end_arglist>: New methods.
5243         <arglist_len, m_funcall_chain>: New members.
5244         (arglist_len, start_arglist, end_arglist): Don't declare.
5245         * parse.c (arglist_len, funcall_chain): Remove global.
5246         (start_arglist, end_arglist): Remove functions.
5247         (parse_exp_in_context): Update.
5248         * p-exp.y: Update rules.
5249         * m2-exp.y: Update rules.
5250         * go-exp.y: Update rules.
5251         * f-exp.y: Update rules.
5252         * d-exp.y: Update rules.
5253         * c-exp.y: Update rules.
5254
5255 2019-04-04  Tom Tromey  <tom@tromey.com>
5256
5257         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
5258         lex_operator, push_back>: New methods.
5259         Update all rules.
5260         (rust_parser::lex_hex, lex_escape): Rename and update.
5261         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
5262         (rust_parser::lex_operator): Rename and update.
5263         (rust_parser::lex_number, rustyylex, rustyyerror)
5264         (rust_lex_test_init, rust_lex_test_sequence)
5265         (rust_lex_test_push_back, rust_lex_tests): Update.
5266         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
5267         parameter.
5268         <lexptr, prev_lexptr>: New members.
5269         (lexptr, prev_lexptr): Don't declare.
5270         * parse.c (lexptr, prev_lexptr): Remove globals.
5271         (parse_exp_in_context): Update.
5272         * p-exp.y (yylex, yyerror): Update.
5273         * m2-exp.y (parse_number, yylex, yyerror): Update.
5274         * go-exp.y (lex_one_token, yyerror): Update.
5275         * f-exp.y (match_string_literal, yylex, yyerror): Update.
5276         * d-exp.y (lex_one_token, yyerror): Update.
5277         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
5278         (lex_one_token, yyerror): Update.
5279         * ada-lex.l (YY_INPUT): Update.
5280         (rewind_to_char): Update.
5281         * ada-exp.y (yyerror): Update.
5282
5283 2019-04-04  Tom Tromey  <tom@tromey.com>
5284
5285         * rust-exp.y (rustyylex, rust_lex_tests): Update.
5286         * parser-defs.h (struct parser_state) <parser_state>: Add new
5287         parameter.
5288         <comma_terminates>: New member.
5289         (comma_terminates): Don't declare global.
5290         * parse.c (comma_terminates): Remove global.
5291         (parse_exp_in_context): Update.
5292         * p-exp.y (yylex): Update.
5293         * m2-exp.y (yylex): Update.
5294         * go-exp.y (lex_one_token): Update.
5295         * f-exp.y (yylex): Update.
5296         * d-exp.y (lex_one_token): Update.
5297         * c-exp.y (lex_one_token): Update.
5298         * ada-lex.l: Update.
5299
5300 2019-04-04  Tom Tromey  <tom@tromey.com>
5301
5302         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
5303         (rustyylex, rust_lex_test_init, rust_lex_test_one)
5304         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
5305         * parser-defs.h (paren_depth): Don't declare.
5306         * parse.c (paren_depth): Remove global.
5307         (parse_exp_in_context): Update.
5308         * p-exp.y (paren_depth): New global.
5309         (pascal_parse): Initialize it.
5310         * m2-exp.y (paren_depth): New global.
5311         (m2_parse): Initialize it.
5312         * go-exp.y (paren_depth): New global.
5313         (go_parse): Initialize it.
5314         * f-exp.y (paren_depth): New global.
5315         (f_parse): Initialize it.
5316         * d-exp.y (paren_depth): New global.
5317         (d_parse): Initialize it.
5318         * c-exp.y (paren_depth): New global.
5319         (c_parse): Initialize it.
5320         * ada-lex.l (paren_depth): New global.
5321         (lexer_init): Initialize it.
5322
5323 2019-04-04  Tom Tromey  <tom@tromey.com>
5324
5325         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
5326         (rust_parser::convert_ast_to_type)
5327         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5328         * parser-defs.h (struct parser_state) <parser_state>: Add
5329         parameters.  Initialize new members.
5330         <expression_context_block, expression_context_pc>: New members.
5331         * parse.c (expression_context_block, expression_context_pc):
5332         Remove globals.
5333         (parse_exp_in_context): Update.
5334         * p-exp.y: Update all rules.
5335         (yylex): Update.
5336         * m2-exp.y: Update all rules.
5337         (yylex): Update.
5338         * go-exp.y (yylex): Update.
5339         * f-exp.y (yylex): Update.
5340         * d-exp.y: Update all rules.
5341         (yylex): Update.
5342         * c-exp.y: Update all rules.
5343         (lex_one_token, classify_name, yylex, c_parse): Update.
5344         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
5345
5346 2019-04-04  Tom Tromey  <tom@tromey.com>
5347
5348         * gdbarch.h, gdbarch.c: Rebuild.
5349         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
5350         * stap-probe.h:
5351         (struct stap_parse_info): Replace "parser_state" with
5352         "expr_builder".
5353         * parser-defs.h (struct expr_builder): Rename from "parser_state".
5354         (parser_state): New class.
5355         * parse.c (expr_builder): Rename.
5356         (expr_builder::release): Rename.
5357         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
5358         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
5359         (write_exp_elt_longcst, write_exp_elt_floatcst)
5360         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
5361         (write_exp_string_vector, write_exp_bitstring)
5362         (write_exp_msymbol, mark_struct_expression)
5363         (write_dollar_variable)
5364         (insert_type_address_space, increase_expout_size): Replace
5365         "parser_state" with "expr_builder".
5366         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
5367         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
5368         "parser_state" with "expr_builder".
5369
5370 2019-04-04  Tom Tromey  <tom@tromey.com>
5371
5372         * rust-exp.y: Replace "parse_language" with method call.
5373         * p-exp.y:
5374         (yylex): Replace "parse_language" with method call.
5375         * m2-exp.y:
5376         (yylex): Replace "parse_language" with method call.
5377         * go-exp.y (classify_name): Replace "parse_language" with method
5378         call.
5379         * f-exp.y (yylex): Replace "parse_language" with method call.
5380         * d-exp.y (lex_one_token): Replace "parse_language" with method
5381         call.
5382         * c-exp.y:
5383         (lex_one_token, classify_name, yylex): Replace "parse_language"
5384         with method call.
5385         * ada-exp.y (find_primitive_type, type_char)
5386         (type_system_address): Replace "parse_language" with method call.
5387
5388 2019-04-04  Tom Tromey  <tom@tromey.com>
5389
5390         * rust-exp.y: Replace "parse_gdbarch" with method call.
5391         * parse.c (write_dollar_variable, insert_type_address_space):
5392         Replace "parse_gdbarch" with method call.
5393         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
5394         call.
5395         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
5396         call.
5397         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
5398         "parse_gdbarch" with method call.
5399         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
5400         with method call.
5401         * f-exp.y (parse_type, parse_f_type, yylex): Replace
5402         "parse_gdbarch" with method call.
5403         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
5404         "parse_gdbarch" with method call.
5405         * c-exp.y (parse_type, parse_number, classify_name): Replace
5406         "parse_gdbarch" with method call.
5407         * ada-lex.l: Replace "parse_gdbarch" with method call.
5408         * ada-exp.y (parse_type, find_primitive_type, type_char)
5409         (type_system_address): Replace "parse_gdbarch" with method call.
5410
5411 2019-04-04  Tom Tromey  <tom@tromey.com>
5412
5413         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
5414         * stap-probe.c (stap_parse_argument): Update.
5415         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
5416         initial_size parameter.
5417         * rust-exp.y (rust_lex_tests): Update.
5418         * parse.c (parser_state): Update.
5419         (parse_exp_in_context): Update.
5420         * parser-defs.h (struct parser_state) <parser_state>: Remove
5421         "initial_size" parameter.
5422
5423 2019-04-04  Tom Tromey  <tom@tromey.com>
5424
5425         * parser-defs.h (increase_expout_size): Don't declare.
5426         * parse.c (increase_expout_size): Now static.
5427
5428 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
5429
5430         * gnu-nat.c (gnu_nat_target::wait): Fix
5431         target_waitstatus_to_string call.
5432
5433 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5434
5435         * eval.c (evaluate_subexp_standard): Handle internal functions
5436         during Fortran function call handling.
5437
5438 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5439
5440         * NEWS: Mention new internal functions.
5441         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
5442         (read_base_type): Use dwarf2_init_complex_target_type.
5443         * value.c (creal_internal_fn): New function.
5444         (cimag_internal_fn): New function.
5445         (_initialize_values): Register new internal functions.
5446
5447 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5448
5449         * infrun.c (stop_all_threads): If debug_infrun, always
5450         trace the wait status after wait_one, using
5451         target_waitstatus_to_string and target_pid_to_str.
5452         (handle_inferior_event): Replace various trace of
5453         wait status kind by a single trace.
5454         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
5455         wait status kind image by target_waitstatus_to_string.
5456         * target/waitstatus.c (target_waitstatus_to_string): Fix
5457         obsolete comment.
5458
5459 2019-04-01  Tom Tromey  <tromey@adacore.com>
5460
5461         PR symtab/23331:
5462         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
5463
5464 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5465             Pedro Alves  <palves@redhat.com>
5466
5467         * top.c (quit_force): Call 'finalize_values'.
5468         * value.c (finalize_values): New function.
5469         * value.h (finalize_values): Declare.
5470
5471 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
5472
5473         * NEWS: Announce $_gdb_major and $_gdb_minor.
5474
5475         * top.c (init_gdb_version_vars): New function.
5476         (gdb_init): Call init_gdb_version_vars.
5477
5478 2019-03-29  Tom Tromey  <tromey@adacore.com>
5479
5480         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
5481         help text.  Remove dead code.
5482
5483 2019-03-29  Keith Seitz  <keiths@redhat.com>
5484
5485         From Siddhesh Poyarekar:
5486         * f-lang.h (f77_get_upperbound): Return LONGEST.
5487         (f77_get_lowerbound): Likewise.
5488         * f-typeprint.c (f_type_print_varspec_suffix): Expand
5489         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
5490         print them.
5491         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
5492         plongest to format print it.
5493         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
5494         (f77_get_upperbound): Likewise.
5495         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
5496         LOWER_BOUND to LONGEST.
5497         (f77_create_arrayprint_offset_tbl): Likewise.
5498
5499 2019-03-29  Keith Seitz  <keiths@redhat.com>
5500
5501         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
5502         %s/pulongest for TYPE_LENGTH instead of %d in format
5503         strings.
5504         * ada-typerint.c (ada_print_type): Likewise.
5505         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
5506         * compile/compile-c-support.c (generate_register_struct): Likewise.
5507         * gdbtypes.c (recursive_dump_type): Likewise.
5508         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
5509         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
5510         instead of %d in format strings.
5511         * riscv-tdep.c (riscv_type_alignment): Cast second argument
5512         to std::min to ULONGEST.
5513         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
5514         instead of %d in format strings.
5515         * tracepoint.c (info_scope_command): Likewise.
5516         * typeprint.c (print_offset_data::update)
5517         (print_offset_data::finish): Likewise.
5518         * xtensa-tdep.c (xtensa_store_return_value)
5519         (xtensa_push_dummy_call): Likewise.
5520
5521 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
5522
5523         * windows-nat.c (display_selector): Fixed format specifications
5524         for 64-bit Cygwin.
5525
5526 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5527
5528         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
5529
5530 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
5531
5532         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
5533         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
5534         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
5535         (nios2_linux_init_abi): Install it.
5536
5537 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5538
5539         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
5540
5541 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5542
5543         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
5544
5545 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5546             Tom Tromey  <tromey@adacore.com>
5547
5548         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
5549
5550 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
5551
5552         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
5553         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
5554         method to compute the bounds of range types. Also print "[evaluated]"
5555         if the bounds' values come from a dynamic evaluation.
5556
5557 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5558
5559         * cp-valprint.c (cp_print_value_fields): Don't print trailing
5560         whitespace when pretty printing is on.
5561
5562 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5563
5564         * ppc-linux-nat.c: Add include.
5565
5566 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5567
5568         * NEWS: Mention AArch64 Pointer Authentication.
5569
5570 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5571
5572         * arm-linux-nat.c: Add include.
5573
5574 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
5575
5576         * source-cache.c (source_cache::get_source_lines): Re-read
5577         fullname after calling open_source_file.
5578
5579 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
5580
5581         * NEWS: Mention TLS support for FreeBSD.
5582
5583 2019-03-25  Tom Tromey  <tromey@adacore.com>
5584
5585         * minsyms.c (BUNCH_SIZE): Update comment.
5586         (~minimal_symbol_reader): Remove old comment.
5587         (compact_minimal_symbols): Update comment.
5588         (minimal_symbol_reader::install): Remove old comment.  Update
5589         other comments.
5590
5591 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5592
5593         * s390-linux-nat.c: Add include.
5594
5595 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5596
5597         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5598         Call linux_get_hwcap.
5599         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
5600         Likewise.
5601         (aarch64_linux_get_hwcap): Remove function.
5602         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
5603         declaration.
5604         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
5605         linux_get_hwcap.
5606         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5607         * linux-tdep.c (linux_get_hwcap): Add function.
5608         (linux_get_hwcap2): Likewise.
5609         * linux-tdep.h (linux_get_hwcap): Add declaration.
5610         (linux_get_hwcap2): Likewise.
5611         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
5612         (ppc_linux_get_hwcap2): Likewise.
5613         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
5614         linux_get_hwcap.
5615         (ppc_linux_nat_target::insert_watchpoint): Likewise.
5616         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
5617         (ppc_linux_nat_target::read_description): Likewise.
5618         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
5619         * s390-linux-nat.c: Likewise.
5620         * s390-linux-tdep.c (s390_core_read_description): Likewise.
5621
5622 2019-03-24  Tom Tromey  <tom@tromey.com>
5623
5624         * ada-lang.c (standard_lookup): Simplify initialization.
5625         (ada_lookup_symbol_nonlocal): Simplify return.
5626         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
5627         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
5628         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
5629         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
5630         initialization.
5631         * solib.c (solib_global_lookup): Simplify.
5632         * symtab.c (null_block_symbol): Remove.
5633         (symbol_cache_lookup): Simplify returns.
5634         (lookup_language_this): Simplify returns.
5635         (lookup_symbol_aux): Simplify return.
5636         (lookup_local_symbol): Simplify returns.
5637         (lookup_global_symbol_from_objfile): Simplify return.
5638         (lookup_symbol_in_objfile_symtabs)
5639         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
5640         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
5641         (lookup_static_symbol, lookup_global_symbol): Simplify return.
5642         * cp-namespace.c (cp_lookup_bare_symbol)
5643         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
5644         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
5645         (cp_lookup_nested_symbol): Don't use null_block_symbol.
5646         (cp_lookup_symbol_via_imports): Simplify initialization.
5647         (find_symbol_in_baseclass): Likewise.
5648         * symtab.h (null_block_symbol): Remove.
5649         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
5650         (d_lookup_nested_symbol, d_lookup_symbol_imports)
5651         (d_lookup_symbol_module): Likewise.
5652         (find_symbol_in_baseclass): Simplify initialization.
5653
5654 2019-03-24  Tom Tromey  <tom@tromey.com>
5655
5656         * expression.h: Don't include symtab.h.
5657         (struct block): Forward declare.
5658
5659 2019-03-24  Tom Tromey  <tom@tromey.com>
5660
5661         * c-exp.y (typebase): Remove casts.
5662         * gdbtypes.c (lookup_unsigned_typename, )
5663         (lookup_signed_typename): Remove cast.
5664         * eval.c (parse_to_comma_and_eval): Remove cast.
5665         * parse.c (write_dollar_variable): Remove cast.
5666         * block.h (struct block) <superblock>: Now const.
5667         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
5668         * psymtab.c (psym_map_matching_symbols): Make "block" const.
5669         (map_block): Make "block" const.
5670         * symfile.h (struct quick_symbol_functions)
5671         <map_matching_symbols>: Constify block argument to "callback".
5672         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
5673         const.
5674         (find_pc_sect_compunit_symtab): Make "b" const.
5675         (find_symbol_at_address): Likewise.
5676         (search_symbols): Likewise.
5677         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
5678         (dw2_debug_names_lookup_symbol): Likewise.
5679         (dw2_map_matching_symbols): Update.
5680         * p-valprint.c (pascal_val_print): Remove "block".
5681         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
5682         (aux_add_nonlocal_symbols): Make "block" const.
5683         (resolve_subexp): Remove cast.
5684         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
5685         const.
5686         (iterate_over_file_blocks): Likewise.
5687         * f-exp.y (%union) <bval>: Remove.
5688         * coffread.c (patch_opaque_types): Make "b" const.
5689         * spu-tdep.c (spu_catch_start): Make "block" const.
5690         * c-valprint.c (print_unpacked_pointer): Remove "block".
5691         * symmisc.c (dump_symtab_1): Make "b" const.
5692         (block_depth): Make "block" const.
5693         * d-exp.y (%union) <bval>: Remove.
5694         * cp-support.h (cp_lookup_rtti_type): Update.
5695         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
5696         * psymtab.c (psym_lookup_symbol): Make "block" const.
5697         (maintenance_check_psymtabs): Make "b" const.
5698         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
5699         (enumerate_locals, enumerate_args): Update.
5700         * python/py-symtab.c (stpy_global_block): Make "block" const.
5701         (stpy_static_block): Likewise.
5702         * inline-frame.c (block_starting_point_at): Make "new_block"
5703         const.
5704         * block.c (find_block_in_blockvector): Make return type const.
5705         (blockvector_for_pc_sect): Make "b" const.
5706         (find_block_in_blockvector): Make "b" const.
5707
5708 2019-03-23  Tom Tromey  <tom@tromey.com>
5709
5710         * varobj.c (varobj_create): Update.
5711         * symfile.c (clear_symtab_users): Don't reset innermost_block.
5712         * printcmd.c (display_command, do_one_display): Don't reset
5713         innermost_block.
5714         * parser-defs.h (enum innermost_block_tracker_type): Move to
5715         expression.h.
5716         (innermost_block): Update comment.
5717         * parse.c (parse_exp_1): Add tracker_types parameter.
5718         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
5719         tracker_types parameter.  Reset innermost_block.
5720         (parse_exp_in_context): Remove.
5721         (parse_expression_for_completion): Update.
5722         * objfiles.c (~objfile): Don't reset expression_context_block or
5723         innermost_block.
5724         * expression.h (enum innermost_block_tracker_type): Move from
5725         parser-defs.h.
5726         (parse_exp_1): Add tracker_types parameter.
5727         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
5728         reset innermost_block.
5729
5730 2019-03-23  Tom Tromey  <tom@tromey.com>
5731
5732         * objfiles.h: Include bcache.h.
5733
5734 2019-03-23  Tom Tromey  <tom@tromey.com>
5735
5736         * linespec.c (get_current_search_block): Use
5737         scoped_restore_current_language.
5738         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
5739
5740 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5741             Jiong Wang  <jiong.wang@arm.com>
5742
5743         * aarch64-linux-tdep.c
5744         (aarch64_linux_iterate_over_regset_sections): Check for pauth
5745         section.
5746         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
5747
5748 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5749             Jiong Wang  <jiong.wang@arm.com>
5750
5751         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
5752         instructions.
5753         (aarch64_analyze_prologue_test): Add PACIASP test.
5754         (aarch64_prologue_prev_register): Unmask PC value.
5755
5756 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5757             Jiong Wang  <jiong.wang@arm.com>
5758
5759         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
5760         (aarch64_dwarf2_prev_register): Unmask PC value.
5761         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
5762         (aarch64_execute_dwarf_cfa_vendor_op): Check for
5763         DW_CFA_AARCH64_negate_ra_state.
5764         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
5765
5766 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5767             Jiong Wang  <jiong.wang@arm.com>
5768
5769         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
5770         registers.
5771         (aarch64_pseudo_register_name): Likewise.
5772         (aarch64_pseudo_register_type): Likewise.
5773         (aarch64_pseudo_register_reggroup_p): Likewise.
5774         (aarch64_gdbarch_init): Add pauth registers.
5775         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
5776         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
5777         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
5778         (struct gdbarch_tdep): Add regnum for ra_state.
5779
5780 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5781             Jiong Wang  <jiong.wang@arm.com>
5782
5783         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
5784
5785 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5786             Jiong Wang  <jiong.wang@arm.com>
5787
5788         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
5789         function.
5790         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
5791         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
5792         (aarch64_gdbarch_init): Add puth registers.
5793         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
5794         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
5795         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
5796
5797 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5798             Jiong Wang  <jiong.wang@arm.com>
5799
5800         * aarch64-linux-nat.c
5801         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
5802         * aarch64-linux-tdep.c
5803         (aarch64_linux_core_read_description): Likewise.
5804         (aarch64_linux_get_hwcap): New function.
5805         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
5806         (aarch64_linux_get_hwcap): New declaration.
5807
5808 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5809             Jiong Wang  <jiong.wang@arm.com>
5810
5811         * aarch64-linux-nat.c
5812         (aarch64_linux_nat_target::read_description): Add pauth param.
5813         * aarch64-linux-tdep.c
5814         (aarch64_linux_core_read_description): Likewise.
5815         * aarch64-tdep.c (struct target_desc): Add in pauth.
5816         (aarch64_read_description): Add pauth param.
5817         (aarch64_gdbarch_init): Likewise.
5818         * aarch64-tdep.h (aarch64_read_description): Likewise.
5819         * arch/aarch64.c (aarch64_create_target_description): Likewise.
5820         * arch/aarch64.h (aarch64_create_target_description): Likewise.
5821         * features/Makefile: Add new files.
5822         * features/aarch64-pauth.c: New file.
5823         * features/aarch64-pauth.xml: New file.
5824
5825 2019-03-20  Tom Tromey  <tromey@adacore.com>
5826
5827         * infrun.c (handle_inferior_event): Rename from
5828         handle_inferior_event_1.  Create a scoped_value_mark.
5829         (handle_inferior_event): Remove.
5830
5831 2019-03-19  Tom Tromey  <tromey@adacore.com>
5832
5833         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
5834         * infrun.h (print_stop_event): Add "displays" parameter.
5835         * infrun.c (print_stop_event): Add "displays" parameter.
5836
5837 2019-03-19  Pedro Alves  <palves@redhat.com>
5838
5839         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
5840         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
5841         to -1.  Fix TABs vs spaces.
5842         (tui_ui_out::tui_ui_out): Don't initialize fields here.
5843         * tui/tui-out.h (tui_ui_out) Add intro comments.
5844         <m_line, m_start_of_line>: In-class initialize, and add describing
5845         comment.
5846
5847 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
5848
5849         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
5850         variable names.
5851         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
5852
5853 2019-03-18  Pedro Alves  <palves@redhat.com>
5854             Eli Zaretskii <eliz@gnu.org>
5855
5856         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
5857         m_line and m_start_of_line.
5858
5859 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
5860
5861         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
5862         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
5863         it returns a newline.  This fixes a regression in TU mode, whereby
5864         the next line is output on the same screen line as the user input.
5865
5866 2019-03-18  Tom Tromey  <tromey@adacore.com>
5867
5868         * minsyms.c (minimal_symbol_reader::install): Remove call to
5869         obstack_blank.
5870
5871 2019-03-18  Pedro Alves  <palves@redhat.com>
5872
5873         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
5874         New globals.
5875         (apply_style): New, factored out from ...
5876         (apply_ansi_escape): ... this.  Handle reverse video mode.
5877         (tui_set_reverse_mode): New function.
5878         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
5879         * tui/tui-winsource.c (tui_show_source_line): Use
5880         tui_set_reverse_mode instead of setting A_STANDOUT.
5881         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
5882         New setter methods.
5883
5884 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
5885
5886         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
5887         Handle tabs.
5888
5889 2019-03-18  Tom Tromey  <tromey@adacore.com>
5890
5891         * ada-lang.c (empty_array): Add "high" parameter.
5892         (ada_evaluate_subexp): Update.
5893
5894 2019-03-17  Sergei Trofimovich <siarheit@google.com>
5895
5896         * unittests/string_view-selftests.c: Define
5897         _initialize_string_view_selftests unconditionally.
5898
5899 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5900
5901         PR gdb/24350
5902         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
5903
5904 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5905
5906         PR gdb/24351
5907         * windows-nat.c (display_selector): Fix format specifiers.
5908
5909 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
5910
5911         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
5912         tui_refill_source_window instead of tui_refresh_win, to update the
5913         current execution line.  This fixes redisplay of the current line
5914         when stepping through the code with "next" or "step".
5915
5916 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5917
5918         * source-cache.c (source_cache::get_source_lines): Call
5919         find_source_lines to initialize s->nlines.  This fixes vertical
5920         scrolling of TUI source window when the DOWN arrow is pressed.
5921
5922 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5923
5924         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
5925         linux-thread-db.c (_initialize_thread_db): Likewise.
5926
5927 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5928
5929         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
5930         wclrtoeol in tui_show_source_line".  This reverts changes made in
5931         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
5932
5933 2019-03-15  Tom Tromey  <tom@tromey.com>
5934
5935         * symtab.h (struct minimal_symbol): Derive from
5936         general_symbol_info.
5937         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
5938         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
5939         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
5940         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
5941         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
5942         (MSYMBOL_SEARCH_NAME): Update.
5943         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
5944         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
5945         * minsyms.c (minimal_symbol_reader::record_full): Update.
5946
5947 2019-03-15  Tom Tromey  <tom@tromey.com>
5948
5949         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
5950
5951 2019-03-15  Tom Tromey  <tom@tromey.com>
5952
5953         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
5954         unique_xmalloc_ptr.
5955         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
5956         Update.
5957         * minsyms.c (lookup_minimal_symbol_by_pc_section)
5958         (build_minimal_symbol_hash_tables)
5959         (minimal_symbol_reader::install): Update.
5960
5961 2019-03-15  Tom Tromey  <tom@tromey.com>
5962
5963         * symtab.c (create_demangled_names_hash): Update.
5964         (symbol_set_names): Update.
5965         * objfiles.h (struct objfile_per_bfd_storage)
5966         <demangled_names_hash>: Now an htab_up.
5967         * objfiles.c (objfile_per_bfd_storage): Simplify.
5968
5969 2019-03-15  Tom Tromey  <tom@tromey.com>
5970
5971         * objfiles.h (struct objfile_per_bfd_storage): Declare
5972         destructor.
5973         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
5974         New.
5975         (get_objfile_bfd_data): Use new.  Don't initialize
5976         language_of_main.
5977         (free_objfile_per_bfd_storage): Remove.
5978         (objfile_bfd_data_free, objfile::~objfile): Use delete.
5979
5980 2019-03-15  Tom Tromey  <tom@tromey.com>
5981
5982         * symfile.c (reread_symbols): Update.
5983         * objfiles.c (objfile::objfile): Update.
5984         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
5985         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
5986         comment.
5987         (minimal_symbol_reader::install): Update.
5988         (terminate_minimal_symbol_table): Remove.
5989         * jit.c (jit_object_close_impl): Update.
5990
5991 2019-03-15  Tom Tromey  <tom@tromey.com>
5992
5993         * minsyms.c (minimal_symbol_reader::record_full): Remove some
5994         initializations.
5995
5996 2019-03-15  Tom Tromey  <tom@tromey.com>
5997
5998         * objfiles.h (struct objfile_per_bfd_storage)
5999         <demangled_hash_languages>: Now a bitset.
6000         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6001         (lookup_minimal_symbol): Update.
6002
6003 2019-03-15  Tom Tromey  <tom@tromey.com>
6004
6005         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6006         Don't return the symbol.
6007         * coffread.c (record_minimal_symbol): Use record_full.
6008
6009 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6010
6011         The MS-Windows port of ncurses fails to switch to a color pair if
6012         one or both of the colors are the implicit default colors.  This
6013         change records the default colors when TUI is initialized, and
6014         then specifies them explicitly when a color pair uses the default
6015         colors.  This allows color styling in TUI mode on MS-Windows.
6016
6017         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6018         ncurses_norm_attr.
6019         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6020         colors in ncurses_norm_attr.
6021         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6022         "none", replace it with the default color recorded in
6023         ncurses_norm_attr.
6024
6025 2019-03-14  Tom Tromey  <tromey@adacore.com>
6026
6027         * source-cache.h (class source_cache) <get_source_lines>: Return
6028         std::string.
6029         * source-cache.c (source_cache::extract_lines): Handle case where
6030         first_pos==npos.  Return std::string.
6031         (source_cache::get_source_lines): Update.
6032
6033 2019-03-14  Tom Tromey  <tromey@adacore.com>
6034
6035         * NEWS: Add item for "style sources" commands.
6036         * source-cache.c (source_cache::get_source_lines): Check
6037         source_styling.
6038         * cli/cli-style.c (source_styling): New global.
6039         (_initialize_cli_style): Add "style sources" commands.
6040         (show_style_sources): New function.
6041         * cli/cli-style.h (source_styling): Declare.
6042
6043 2019-03-14  Pedro Alves  <palves@redhat.com>
6044             Tom Tromey  <tromey@adacore.com>
6045
6046         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6047         * tui/tui-winsource.c (tui_refill_source_window): New function,
6048         from...
6049         (tui_horizontal_source_scroll): ... here.  Move some logic.
6050         * cli/cli-style.c (set_style_enabled): Notify new observable.
6051         * tui/tui-hooks.c (tui_redisplay_source): New function.
6052         (tui_attach_detach_observers): Attach or detach
6053         tui_redisplay_source.
6054         * observable.h (source_styling_changed): New observable.
6055         * observable.c: Define source_styling_changed observable.
6056
6057 2019-03-13  Tom Tromey  <tromey@adacore.com>
6058
6059         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6060         (i386_gnu_nat_target::store_registers): Update.
6061         * target-debug.h (target_debug_print_std_string): New macro.
6062         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6063         * windows-tdep.c (display_one_tib): Update.
6064         * tui/tui-stack.c (tui_make_status_line): Update.
6065         * top.c (print_inferior_quit_action): Update.
6066         * thread.c (thr_try_catch_cmd): Update.
6067         (add_thread_with_info): Update.
6068         (thread_target_id_str): Update.
6069         (thr_try_catch_cmd): Update.
6070         (thread_command): Update.
6071         (thread_find_command): Update.
6072         * record-btrace.c (record_btrace_target::info_record)
6073         (record_btrace_resume_thread, record_btrace_target::resume)
6074         (record_btrace_cancel_resume, record_btrace_step_thread)
6075         (record_btrace_target::wait, record_btrace_target::wait)
6076         (record_btrace_target::wait, record_btrace_target::stop): Update.
6077         * progspace.c (print_program_space): Update.
6078         * process-stratum-target.c
6079         (process_stratum_target::thread_address_space): Update.
6080         * linux-fork.c (linux_fork_mourn_inferior)
6081         (detach_checkpoint_command, info_checkpoints_command)
6082         (linux_fork_context): Update.
6083         (linux_fork_detach): Update.
6084         (class scoped_switch_fork_info): Update.
6085         (delete_checkpoint_command): Update.
6086         * infrun.c (follow_fork_inferior): Update.
6087         (follow_fork_inferior): Update.
6088         (proceed_after_vfork_done): Update.
6089         (handle_vfork_child_exec_or_exit): Update.
6090         (follow_exec): Update.
6091         (displaced_step_prepare_throw): Update.
6092         (displaced_step_restore): Update.
6093         (start_step_over): Update.
6094         (resume_1): Update.
6095         (clear_proceed_status_thread): Update.
6096         (proceed): Update.
6097         (print_target_wait_results): Update.
6098         (do_target_wait): Update.
6099         (context_switch): Update.
6100         (stop_all_threads): Update.
6101         (restart_threads): Update.
6102         (finish_step_over): Update.
6103         (handle_signal_stop): Update.
6104         (switch_back_to_stepped_thread): Update.
6105         (keep_going_pass_signal): Update.
6106         (print_exited_reason): Update.
6107         (normal_stop): Update.
6108         * inferior.c (inferior_pid_to_str): Change return type.
6109         (print_selected_inferior): Update.
6110         (add_inferior): Update.
6111         (detach_inferior): Update.
6112         * dummy-frame.c (fprint_dummy_frames): Update.
6113         * dcache.c (dcache_info_1): Update.
6114         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6115         (btrace_fetch, btrace_clear): Update.
6116         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6117         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6118         type.
6119         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6120         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6121         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6122         * gdbarch.c, gdbarch.h: Rebuild.
6123         * gdbarch.sh (core_pid_to_str): Change return type.
6124         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6125         return type.
6126         (windows_nat_target::pid_to_str): Change return type.
6127         (windows_delete_thread): Update.
6128         (windows_nat_target::attach): Update.
6129         (windows_nat_target::files_info): Update.
6130         * target-delegates.c: Rebuild.
6131         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6132         return type.
6133         (sol_thread_target::pid_to_str): Change return type.
6134         * remote.c (class remote_target) <pid_to_str>: Change return
6135         type.
6136         (remote_target::pid_to_str): Change return type.
6137         (extended_remote_target::attach, remote_target::remote_stop_ns)
6138         (remote_target::remote_notif_remove_queued_reply)
6139         (remote_target::push_stop_reply, remote_target::disable_btrace):
6140         Update.
6141         (extended_remote_target::attach): Update.
6142         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6143         type.
6144         (gdbsim_target::pid_to_str): Change return type.
6145         * ravenscar-thread.c (struct ravenscar_thread_target)
6146         <pid_to_str>: Change return type.
6147         (ravenscar_thread_target::pid_to_str): Change return type.
6148         * procfs.c (class procfs_target) <pid_to_str>: Change return
6149         type.
6150         (procfs_target::pid_to_str): Change return type.
6151         (procfs_target::attach): Update.
6152         (procfs_target::detach): Update.
6153         (procfs_target::fetch_registers): Update.
6154         (procfs_target::store_registers): Update.
6155         (procfs_target::wait): Update.
6156         (procfs_target::files_info): Update.
6157         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6158         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6159         return type.
6160         (nto_procfs_target::pid_to_str): Change return type.
6161         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6162         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6163         return type.
6164         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6165         (exit_lwp): Update.
6166         (attach_proc_task_lwp_callback, get_detach_signal)
6167         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6168         (linux_nat_target::resume, wait_lwp, stop_callback)
6169         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6170         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6171         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6172         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6173         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6174         type.
6175         (inf_ptrace_target::attach): Update.
6176         (inf_ptrace_target::files_info): Update.
6177         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6178         type.
6179         (go32_nat_target::pid_to_str): Change return type.
6180         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6181         (gnu_nat_target::wait): Update.
6182         (gnu_nat_target::wait): Update.
6183         (gnu_nat_target::resume): Update.
6184         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6185         (fbsd_nat_target::wait): Update.
6186         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6187         type.
6188         (darwin_nat_target::attach): Update.
6189         * corelow.c (class core_target) <pid_to_str>: Change return type.
6190         (core_target::pid_to_str): Change return type.
6191         * target.c (normal_pid_to_str): Change return type.
6192         (default_pid_to_str): Likewise.
6193         (target_pid_to_str): Change return type.
6194         (target_translate_tls_address): Update.
6195         (target_announce_detach): Update.
6196         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6197         return type.
6198         (bsd_uthread_target::pid_to_str): Change return type.
6199         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6200         type.
6201         (bsd_kvm_target::pid_to_str): Change return type.
6202         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6203         return type.
6204         (aix_thread_target::pid_to_str): Change return type.
6205         * target.h (struct target_ops) <pid_to_str>: Change return type.
6206         (target_pid_to_str, normal_pid_to_str): Likewise.
6207         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6208         type.
6209         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6210         type.
6211         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6212         return type.
6213         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6214         type.
6215         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6216         type.
6217         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6218         return type.
6219
6220 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6221
6222         * NEWS: Mention that the new default MI version is 3.  Mention
6223         changes to the output of commands and events that deal with
6224         multi-location breakpoints.
6225         * breakpoint.c: Include "mi/mi-out.h".
6226         (print_one_breakpoint): Change output syntax if using MI version
6227         >= 3.
6228         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6229         New.
6230         (mi_multi_location_breakpoint_output_fixed): New.
6231         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6232         (mi_cmd_fix_multi_location_breakpoint_output): New.
6233         (mi_multi_location_breakpoint_output_fixed): New.
6234         * mi/mi-cmds.c (mi_cmds): Register command
6235         -fix-multi-location-breakpoint-output.
6236         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6237         interpreter "mi".
6238
6239 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6240
6241         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6242         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6243         instantiate mi_ui_out based on interpreter name.
6244         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6245         * mi/mi-main.c (mi_load_progress): Likewise.
6246
6247 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6248
6249         * NEWS: Combine separate "New targets" sections for 8.3.
6250
6251 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6252
6253         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6254         (ppcfbsd_init_abi): Install gdbarch
6255         "fetch_tls_load_module_address" and "get_thread_local_address"
6256         methods.
6257
6258 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6259
6260         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
6261         (riscv_fbsd_init_abi): Install gdbarch
6262         "fetch_tls_load_module_address" and "get_thread_local_address"
6263         methods.
6264
6265 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6266
6267         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
6268         (i386fbsd_init_abi): Install gdbarch
6269         "fetch_tls_load_module_address" and "get_thread_local_address"
6270         methods.
6271
6272 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6273
6274         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
6275         (amd64fbsd_init_abi): Install gdbarch
6276         "fetch_tls_load_module_address" and "get_thread_local_address"
6277         methods.
6278
6279 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6280
6281         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
6282         (struct fbsd_pspace_data): New type.
6283         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
6284         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
6285         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
6286         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
6287         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
6288
6289 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6290
6291         * gdbtypes.c (lookup_struct_elt): New function.
6292         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
6293         * gdbtypes.h (struct struct_elt): New type.
6294         (lookup_struct_elt): New prototype.
6295
6296 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6297
6298         * gdbtypes.c (lookup_struct_elt_type): Update comment and
6299         remove disabled code block.
6300
6301 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6302
6303         * gdbarch.sh (get_thread_local_address): New method.
6304         * gdbarch.h, gdbarch.c: Regenerate.
6305         * target.c (target_translate_tls_address): Use
6306         gdbarch_get_thread_local_address if present instead of
6307         target::get_thread_local_address.
6308
6309 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6310
6311         * target.h (target::get_thread_local_address): Update comment.
6312
6313 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6314
6315         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
6316         objfile->separate_debug_objfile_backlink if not NULL.
6317
6318 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6319
6320         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6321         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
6322         (amd64bsd_store_inferior_registers): Likewise.
6323         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6324         Enable segment base registers.
6325         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
6326         PT_GETFSBASE and PT_GETGSBASE.
6327         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
6328         PT_SETGSBASE.
6329         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
6330         segment base registers.
6331         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6332
6333 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6334
6335         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6336         Update calls to i386_target_description to add 'segments'
6337         parameter.
6338         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
6339         add segment base registers.
6340         * arch/i386.c (i386_create_target_description): Add 'segments'
6341         parameter to enable segment base registers.
6342         * arch/i386.h (i386_create_target_description): Likewise.
6343         * features/i386/32bit-segments.xml: New file.
6344         * features/i386/32bit-segments.c: Generate.
6345         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
6346         call to i386_target_description to add 'segments' parameter.
6347         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6348         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
6349         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
6350         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
6351         if feature is present.
6352         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
6353         Add 'segments' parameter to call to i386_target_description.
6354         (i386_target_description): Add 'segments' parameter to enable
6355         segment base registers.
6356         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
6357         to call to i386_target_description.
6358         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
6359         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
6360         Define I386_NUM_REGS.
6361         (i386_target_description): Add 'segments' parameter to enable
6362         segment base registers.
6363
6364 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
6365
6366         PR/24325
6367         * source-cache.c: #undef open and close, to avoid unresolved
6368         externals during linking.
6369
6370 2019-03-12  Tom Tromey  <tromey@adacore.com>
6371
6372         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
6373         const.  Add initializers.
6374         (_initialize_remote): Don't initialize ptid globals.
6375
6376 2019-03-12  Pedro Alves  <palves@redhat.com>
6377
6378         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
6379
6380 2019-03-12  Pedro Alves  <palves@redhat.com>
6381
6382         * cp-name-parser.y (main): Remove unused 'len' variable.
6383
6384 2019-03-12  Tom Tromey  <tromey@adacore.com>
6385
6386         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
6387         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
6388
6389 2019-03-12  Tom Tromey  <tromey@adacore.com>
6390
6391         * linux-nat.c (iterate_over_lwps): Update.
6392         (stop_callback): Remove parameter.
6393         (stop_wait_callback, detach_callback, resume_set_callback)
6394         (select_singlestep_lwp_callback, set_ignore_sigint)
6395         (status_callback, resumed_callback, resume_clear_callback)
6396         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
6397         data parameter.
6398         (linux_nat_target::detach, linux_nat_target::resume)
6399         (linux_stop_and_wait_all_lwps, select_event_lwp)
6400         (linux_nat_filter_event, linux_nat_wait_1)
6401         (linux_nat_target::kill, linux_nat_target::stop)
6402         (linux_nat_target::stop): Update.
6403         (linux_nat_resume_callback): Change type.
6404         (resume_stopped_resumed_lwps, count_events_callback)
6405         (select_event_lwp_callback): Likewise.
6406         (linux_stop_lwp, linux_nat_stop_lwp): Update.
6407         * arm-linux-nat.c (struct update_registers_data): Remove.
6408         (update_registers_callback): Change type.
6409         (arm_linux_insert_hw_breakpoint1): Update.
6410         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
6411         parameter.
6412         (x86_linux_dr_set_addr): Update.
6413         (x86_linux_dr_set_control): Update.
6414         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
6415         (iterate_over_lwps): Use gdb::function_view.
6416         * nat/aarch64-linux-hw-point.c (struct
6417         aarch64_dr_update_callback_param): Remove.
6418         (debug_reg_change_callback): Change type.
6419         (aarch64_notify_debug_reg_change): Update.
6420         * s390-linux-nat.c (s390_refresh_per_info): Update.
6421
6422 2019-03-11  Tom Tromey  <tromey@adacore.com>
6423
6424         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
6425         redundant assignment to "this_cu".
6426
6427 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6428
6429         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
6430
6431 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6432
6433         * gdbtypes.c (rank_one_type_parm_set): New function extracted
6434         from...
6435         (rank_one_type): ... this.
6436
6437 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6438
6439         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
6440         from...
6441         (rank_one_type): ... this.
6442
6443 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6444
6445         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
6446         from...
6447         (rank_one_type): ... this.
6448
6449 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6450
6451         * gdbtypes.c (rank_one_type_parm_float): New function extracted
6452         from...
6453         (rank_one_type): ... this.
6454
6455 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6456
6457         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
6458         from...
6459         (rank_one_type): ... this.
6460
6461 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6462
6463         * gdbtypes.c (rank_one_type_parm_range): New function extracted
6464         from...
6465         (rank_one_type): ... this.
6466
6467 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6468
6469         * gdbtypes.c (rank_one_type_parm_char): New function extracted
6470         from...
6471         (rank_one_type): ... this.
6472
6473 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6474
6475         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
6476         from...
6477         (rank_one_type): ... this.
6478
6479 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6480
6481         * gdbtypes.c (rank_one_type_parm_int): New function extracted
6482         from...
6483         (rank_one_type): ... this.
6484
6485 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6486
6487         * gdbtypes.c (rank_one_type_parm_func): New function extracted
6488         from...
6489         (rank_one_type): ... this.
6490
6491 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6492
6493         * gdbtypes.c (rank_one_type_parm_array): New function extracted
6494         from...
6495         (rank_one_type): ... this.
6496
6497 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6498
6499         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
6500         from...
6501         (rank_one_type): ... this.
6502
6503 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6504
6505         * inferior.c (initialize_inferiors): Ensure 'help set/show print
6506         inferior-events' shows the example events.
6507
6508 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
6509
6510         Support styling on native MS-Windows console
6511
6512         PR/24315
6513         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
6514         on MS-Windows if $TERM is not defined.
6515
6516         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
6517
6518         * posix-hdep.c (gdb_console_fputs):
6519         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
6520         functions.
6521         * ui-file.h (gdb_console_fputs): Add prototype.
6522
6523         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
6524         back to fputs only if the former returns zero.
6525
6526 2019-03-07  Tom Tromey  <tom@tromey.com>
6527
6528         * symmisc.c (print_symbol_bcache_statistics): Update.
6529         (print_objfile_statistics): Update.
6530         * symfile.c (allocate_symtab): Update.
6531         * stabsread.c: Don't include bcache.h.
6532         * psymtab.h (struct psymbol_bcache): Don't declare.
6533         (class psymtab_storage) <psymbol_cache>: Now a bcache.
6534         (psymbol_bcache_init, psymbol_bcache_free)
6535         (psymbol_bcache_get_bcache): Don't declare.
6536         * psymtab.c (struct psymbol_bcache): Remove.
6537         (psymtab_storage::psymtab_storage): Update.
6538         (psymtab_storage::~psymtab_storage): Update.
6539         (psymbol_bcache_init, psymbol_bcache_free)
6540         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
6541         (add_psymbol_to_bcache): Update.
6542         (allocate_psymtab): Update.
6543         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
6544         macro_cache>: No longer pointers.
6545         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
6546         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
6547         * macrotab.c (macro_bcache): Update.
6548         * macroexp.c: Don't include bcache.h.
6549         * gdbtypes.c (check_types_worklist): Update.
6550         (types_deeply_equal): Remove TRY/CATCH.  Update.
6551         * elfread.c (elf_symtab_read): Update.
6552         * dwarf2read.c: Don't include bcache.h.
6553         * buildsym.c (buildsym_compunit::get_macro_table): Update.
6554         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
6555         (print_bcache_statistics, bcache_memory_used): Don't declare.
6556         (struct bcache): Move from bcache.c.  Add constructor, destructor,
6557         methods.  Rename all data members.
6558         * bcache.c (struct bcache): Move to bcache.h.
6559         (bcache::expand_hash_table): Rename from expand_hash_table.
6560         (bcache): Remove.
6561         (bcache::insert): Rename from bcache_full.
6562         (bcache::compare): Rename from bcache_compare.
6563         (bcache_xmalloc): Remove.
6564         (bcache::~bcache): Rename from bcache_xfree.
6565         (bcache::print_statistics): Rename from print_bcache_statistics.
6566         (bcache::memory_used): Rename from bcache_memory_used.
6567
6568 2019-03-07  Pedro Alves  <palves@redhat.com>
6569
6570         * infrun.c (normal_stop): Also check for
6571         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
6572
6573 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
6574
6575         * f-lang.c (value_from_host_double): Moved to...
6576         * value.c (value_from_host_double): ...here.
6577         * value.h (value_from_host_double): Declare.
6578         * guile/scm-math.c (vlscm_convert_typed_number): Use
6579         value_from_host_double.
6580         (vlscm_convert_number): Likewise.
6581         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
6582         * python/py-value.c (convert_value_from_python): Likewise.
6583
6584 2019-03-06  Tom Tromey  <tom@tromey.com>
6585
6586         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
6587
6588 2019-03-06  Tom Tromey  <tom@tromey.com>
6589
6590         * utils.h (free_current_contents): Don't declare.
6591         * utils.c (free_current_contents): Remove.
6592
6593 2019-03-06  Tom Tromey  <tom@tromey.com>
6594
6595         * top.c (quit_force): Update.
6596         * main.c (captured_command_loop): Update.
6597         * common/new-op.c (operator new): Update.
6598         * common/common-exceptions.c (struct catcher)
6599         <save_cleanup_chain>: Remove member.
6600         (exceptions_state_mc_init): Update.
6601         (exception_try_scope_entry): Return nullptr.
6602         (exception_try_scope_exit, exception_rethrow)
6603         (throw_exception_sjlj, throw_exception_cxx): Update.
6604         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
6605         (all_cleanups, do_cleanups, discard_cleanups)
6606         (discard_final_cleanups, save_cleanups, save_final_cleanups)
6607         (restore_cleanups, restore_final_cleanups): Don't declare.
6608         (do_final_cleanups): Remove parameter.
6609         * common/cleanups.c (cleanup_chain, make_cleanup)
6610         (make_cleanup_dtor, all_cleanups, do_cleanups)
6611         (discard_my_cleanups, discard_cleanups)
6612         (discard_final_cleanups, save_my_cleanups, save_cleanups)
6613         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
6614         (null_cleanup): Remove.
6615         (do_final_cleanups): Remove parameter.
6616
6617 2019-03-06  Tom Tromey  <tom@tromey.com>
6618
6619         * remote.c (remote_target::remote_parse_stop_reply): Use
6620         unique_xmalloc_ptr.
6621
6622 2019-03-06  Tom Tromey  <tom@tromey.com>
6623
6624         * stabsread.c (struct stabs_field_info): Rename from field_info.
6625         <list, fnlist>: Add initializers.
6626         <obstack>: New member.
6627         (read_member_functions, read_struct_fields, read_baseclasses):
6628         Allocate on obstack.  Don't use cleanups.
6629         (read_one_struct_field, read_member_functions, read_struct_fields)
6630         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
6631         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
6632         (read_struct_type): Update.
6633
6634 2019-03-06  Tom Tromey  <tom@tromey.com>
6635
6636         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
6637         * common/filestuff.h (make_cleanup_close): Don't declare.
6638         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
6639         Remove.
6640
6641 2019-03-06  Tom Tromey  <tom@tromey.com>
6642
6643         * solib-aix.c: Use make_scope_exit.
6644
6645 2019-03-06  Tom Tromey  <tom@tromey.com>
6646
6647         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
6648         Use make_scope_exit.
6649
6650 2019-03-06  Tom Tromey  <tom@tromey.com>
6651
6652         * solib-svr4.c (disable_probes_interface): Remove parameter.
6653         (svr4_handle_solib_event): Use make_scope_exit.
6654
6655 2019-03-06  Tom Tromey  <tom@tromey.com>
6656
6657         * remote.c (struct stop_reply_deleter): Remove.
6658         (stop_reply_up): Update.
6659         (struct stop_reply): Derive from notif_event.  Don't typedef.
6660         <regcache>: Now a std::vector.
6661         (stop_reply_xfree): Remove.
6662         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
6663         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
6664         (remote_target::discard_pending_stop_replies): Use delete.
6665         (remote_target::remote_parse_stop_reply): Update.
6666         (remote_target::process_stop_reply): Update.
6667         * remote-notif.h (struct notif_event): Add virtual destructor.
6668         Remove "dtr" member.
6669         (struct notif_client) <alloc_event>: Return a unique_ptr.
6670         (notif_event_xfree): Don't declare.
6671         (notif_event_up): New typedef.
6672         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
6673         (notif_event_xfree, do_notif_event_xfree): Remove.
6674         (remote_notif_state_xfree): Update.
6675
6676 2019-03-06  Tom Tromey  <tom@tromey.com>
6677
6678         * infrun.c (displaced_step_clear_cleanup): Now a
6679         forward_scope_exit type.
6680         (displaced_step_prepare_throw): Update.
6681         (displaced_step_fixup): Update.
6682
6683 2019-03-06  Tom Tromey  <tom@tromey.com>
6684
6685         * inferior.h (class inferior): Update comment.
6686         * gdbthread.h (class thread_info): Update comment.
6687
6688 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
6689             Tom Tromey  <tom@tromey.com>
6690
6691         * stabsread.h (struct stab_section_list): Remove.
6692         (coffstab_build_psymtabs): Update.
6693         * dbxread.c (symbuf_sections): Now a std::vector.
6694         (sect_idx): New global.
6695         (fill_symbuf): Update.
6696         (coffstab_build_psymtabs): Change type of stabsects parameter.
6697         Update.
6698         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
6699         std::vector.
6700         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
6701         (coff_locate_sections): Update.
6702         (coff_symfile_read): Remove cleanups.  Update.
6703         (init_stringtab): Add storage parameter.
6704         (free_stringtab, free_stringtab_cleanup): Remove.
6705         (init_lineno): Add storage parameter.
6706         (free_linetab, free_linetab_cleanup): Remove.
6707
6708 2019-03-06  Pedro Alves  <palves@redhat.com>
6709
6710         * linux-fork.c (fork_info::clobber_regs): Delete.
6711         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
6712         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
6713         comment.  Adjust.
6714         (scoped_switch_fork_info::scoped_switch_fork_info)
6715         (checkpoint_command, linux_fork_context): Adjust
6716         fork_save_infrun_state calls.
6717
6718 2019-03-06  Pedro Alves  <palves@redhat.com>
6719
6720         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
6721         (inf_has_multiple_threads): Return 'bool' and rewrite using
6722         inferior_info::threads().
6723
6724 2019-03-06  Pedro Alves  <palves@redhat.com>
6725
6726         * linux-fork.c: Include <list>.
6727         (fork_list): Now a std::list instance.
6728         (fork_info): Add ctor, dtor, and in-class initialize all fields.
6729         (forks_exist_p, find_last_fork): Adjust.
6730         (new_fork): Delete.
6731         (one_fork_p): New.
6732         (add_fork): Adjust.
6733         (free_fork): Delete, folded into fork_info::~fork_info().
6734         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
6735         Adjust.
6736         (init_fork_list): Delete.
6737         (linux_fork_killall, linux_fork_mourn_inferior)
6738         (linux_fork_detach, info_checkpoints_command): Adjust.
6739         (_initialize_linux_fork): No longer call init_fork_list.
6740
6741 2019-03-06  Pedro Alves  <palves@redhat.com>
6742
6743         * linux-fork.c (new_fork): New, split out of ...
6744         (add_fork): ... this.  Return void.  Move "first fork" special
6745         case from here, to ...
6746         (checkpoint_command): ... here.
6747         * linux-linux.h (add_fork): Return void.
6748
6749 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6750
6751         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
6752
6753 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6754             Chris January  <chris.january@arm.com>
6755             David Lecomber  <david.lecomber@arm.com>
6756
6757         * f-exp.y: New token, UNOP_INTRINSIC.
6758         (exp): New pattern using UNOP_INTRINSIC token.
6759         (f77_keywords): Add 'abs' keyword.
6760         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
6761         (value_from_host_double): New function.
6762         (evaluate_subexp_f): Support UNOP_ABS.
6763
6764 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6765
6766         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
6767         types.
6768
6769 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6770
6771         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
6772         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
6773         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
6774
6775 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6776
6777         * f-exp.y (convert_to_kind_type): Handle more type kinds.
6778
6779 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6780             Chris January  <chris.january@arm.com>
6781
6782         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
6783         * f-exp.y: Define 'KIND' token.
6784         (exp): New pattern for KIND expressions.
6785         (ptype): Handle types with a kind extension.
6786         (direct_abs_decl): Extend to spot kind extensions.
6787         (f77_keywords): Add 'kind' to the list.
6788         (push_kind_type): New function.
6789         (convert_to_kind_type): New function.
6790         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
6791         * parse.c (operator_length_standard): Likewise.
6792         * parser-defs.h (enum type_pieces): Add tp_kind.
6793         * std-operator.def: Add UNOP_KIND.
6794
6795 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6796
6797         * f-exp.y (f_parse): Set yydebug.
6798
6799 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6800
6801         * f-lang.c (evaluate_subexp_f): New function.
6802         (exp_descriptor_f): New global.
6803         (f_language_defn): Use exp_descriptor_f instead of
6804         exp_descriptor_standard.
6805
6806 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6807
6808         * f-exp.y (struct token): Add comments.
6809         (dot_ops): Remove uppercase versions and the end marker.
6810         (f77_keywords): Likewise.
6811         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
6812         entries in the dot_ops array are case insensitive, and use
6813         strncasecmp to compare strings.  Also some whitespace cleanup in
6814         this area.  Similar for the f77_keywords array, except entries in
6815         this list might be case sensitive.
6816
6817 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6818
6819         * f-exp.y (struct f77_boolean_val): Add comments.
6820         (boolean_values): Remove uppercase versions, and end marker.
6821         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
6822         and use strncasecmp to achieve case insensitivity.  Additionally,
6823         perform whitespace cleanup around this code.
6824
6825 2019-03-06  Tom Tromey  <tromey@adacore.com>
6826
6827         * remote-sim.c (gdbsim_target_open): Use result of
6828         gdb_argv::release.
6829
6830 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
6831         Dirk Schubert  <dirk.schubert@arm.com>
6832         Chris January  <chris.january@arm.com>
6833
6834         * eval.c (evaluate_subexp_standard): Call Fortran argument
6835         wrapping logic.
6836         * f-lang.c (struct value): A value which can be passed into a
6837         Fortran function call.
6838         (fortran_argument_convert): Wrap Fortran arguments in a pointer
6839         where appropriate.
6840         (struct type): Value ready for a Fortran function call.
6841         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
6842         is needed.
6843         * f-lang.h (fortran_argument_convert): Declaration.
6844         (fortran_preserve_arg_pointer): Declaration.
6845         * infcall.c (value_arg_coerce): Call Fortran argument logic.
6846
6847 2019-03-05  Tom Tromey  <tromey@adacore.com>
6848
6849         * python/py-prettyprint.c (print_string_repr): Remove #if.
6850         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
6851
6852 2019-03-05  Tom Tromey  <tromey@adacore.com>
6853
6854         * target.c (the_dummy_target): Move later.  Change type to
6855         "dummy_target".
6856         (initialize_targets): Don't initialize the_dummy_target.
6857
6858 2019-03-05  Tom Tromey  <tromey@adacore.com>
6859
6860         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
6861         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
6862
6863 2019-03-05  Tom Tromey  <tromey@adacore.com>
6864
6865         * windows-nat.c (windows_nat_target::attach)
6866         (windows_nat_target::detach): Don't call gdb_flush.
6867         * valprint.c (generic_val_print, val_print, val_print_string):
6868         Don't call gdb_flush.
6869         * utils.c (defaulted_query): Don't call gdb_flush.
6870         * typeprint.c (print_type_scalar): Don't call gdb_flush.
6871         * target.c (target_announce_detach): Don't call gdb_flush.
6872         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
6873         * remote.c (extended_remote_target::attach): Don't call
6874         gdb_flush.
6875         * procfs.c (procfs_target::detach): Don't call gdb_flush.
6876         * printcmd.c (do_examine): Don't call gdb_flush.
6877         (info_display_command): Don't call gdb_flush.
6878         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
6879         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
6880         * memattr.c (info_mem_command): Don't call gdb_flush.
6881         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
6882         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
6883         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
6884         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
6885         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
6886         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
6887         (gnu_nat_target::detach): Don't call gdb_flush.
6888         * f-valprint.c (f_val_print): Don't call gdb_flush.
6889         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
6890         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
6891         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
6892         gdb_flush.
6893         * c-valprint.c (c_val_print): Don't call gdb_flush.
6894         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
6895
6896 2019-03-05  Tom Tromey  <tromey@adacore.com>
6897
6898         * varobj.c (update_dynamic_varobj_children): Update.
6899         (install_default_visualizer): Use reset, not release.
6900         * value.c (set_internalvar): Update.
6901         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
6902         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
6903         ATTRIBUTE_UNUSED_RESULT.
6904
6905 2019-03-05  Tom Tromey  <tromey@adacore.com>
6906
6907         * remote.c (class scoped_remote_fd) <release>: Add
6908         ATTRIBUTE_UNUSED_RESULT.
6909
6910 2019-03-05  Tom Tromey  <tromey@adacore.com>
6911
6912         * macroexp.c (struct macro_buffer) <release>: Add
6913         ATTRIBUTE_UNUSED_RESULT.
6914
6915 2019-03-05  Tom Tromey  <tromey@adacore.com>
6916
6917         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
6918         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
6919         ATTRIBUTE_UNUSED_RESULT.
6920
6921 2019-03-05  Tom Tromey  <tromey@adacore.com>
6922
6923         * common/scoped_fd.h (class scoped_fd) <release>: Add
6924         ATTRIBUTE_UNUSED_RESULT.
6925
6926 2019-03-05  Tom Tromey  <tromey@adacore.com>
6927
6928         * parser-defs.h (struct parser_state) <release>: Add
6929         ATTRIBUTE_UNUSED_RESULT.
6930
6931 2019-03-05  Tom Tromey  <tromey@adacore.com>
6932
6933         * utils.h (class gdb_argv) <release>: Add
6934         ATTRIBUTE_UNUSED_RESULT.
6935         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
6936
6937 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
6938
6939         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
6940         for-loop range, to avoid compiler warnings.
6941
6942         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
6943         avoid compiler warnings about unused variables.
6944
6945         * NEWS: Mention end of support for native debugging on MS-Windows
6946         before XP.
6947
6948         PR gdb/24292
6949         * common/netstuff.c:
6950         * gdbserver/gdbreplay.c
6951         * gdbserver/remote-utils.c:
6952         * ser-tcp.c:
6953         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
6954         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
6955         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
6956         'getaddrinfo' and 'freeaddrinfo' were not available before
6957         Windows XP, and mingw.org's MinGW headers by default define
6958         _WIN32_WINNT to 0x500.
6959
6960 2019-03-01  Gary Benson <gbenson@redhat.com>
6961
6962         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
6963
6964 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
6965             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
6966
6967         PR gdb/8527
6968         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
6969         set_sigint_trap, clear_sigint_trap.
6970
6971 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6972
6973         * target.c (target_detach): Clear the regcache and the
6974         frame cache.
6975
6976 2019-02-27  Pedro Alves  <palves@redhat.com>
6977
6978         * utils.c (set_screen_size): When we cap the height/width sizes,
6979         tweak the corresponding command variable to show "unlimited":
6980
6981 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
6982             Pedro Alves  <palves@redhat.com>
6983
6984         * utils.c (set_screen_size): Reduce "infinite" rows and columns
6985         before calling rl_set_screen_size.
6986
6987 2019-02-27  Tom Tromey  <tromey@adacore.com>
6988
6989         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
6990         define.
6991         * python/py-value.c: Remove Python 2.4 workaround.
6992         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
6993         workaround.
6994         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
6995         Python 2.4 workaround.
6996         * python/python-internal.h: Remove Python 2.4 comment.
6997         (Py_ssize_t): Don't define.
6998         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
6999         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7000         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7001         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7002         * python/python.c (do_start_initialization): Remove Python 2.4
7003         workaround.
7004         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7005         (print_children): Remove Python 2.4 workaround.
7006         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7007         workaround.
7008         (CHARBUFFERPROC_NAME): Remove.
7009         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7010         Python 2.4 workaround.
7011
7012 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7013
7014         * NEWS: Note minimum Python version.
7015
7016 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7017
7018         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7019         code from these functions.  Remove corresponding ifdefs.  Use
7020         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7021         Remove gotos and target of gotos.
7022         (infpy_search_memory): Likewise.
7023
7024 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7025
7026         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7027         (hppa_gdbarch_init): Don't register deleted functions with
7028         gdbarch.
7029
7030 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7031
7032         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7033         (h8300_unwind_sp): Delete.
7034         (h8300_dummy_id): Delete.
7035         (h8300_gdbarch_init): Don't register deleted functions with
7036         gdbarch.
7037
7038 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7039
7040         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7041         (ft32_unwind_pc): Delete.
7042         (ft32_unwind_sp): Delete.
7043         (ft32_gdbarch_init): Don't register deleted functions with
7044         gdbarch.
7045
7046 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7047
7048         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7049         (frv_unwind_pc): Delete.
7050         (frv_unwind_sp): Delete.
7051         (frv_gdbarch_init): Don't register deleted functions with
7052         gdbarch.
7053
7054 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7055
7056         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7057         (riscv_unwind_pc): Delete.
7058         (riscv_unwind_sp): Delete.
7059         (riscv_gdbarch_init): Don't register deleted functions with
7060         gdbarch.
7061
7062 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7063
7064         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7065         (csky_unwind_pc): Delete.
7066         (csky_unwind_sp): Delete.
7067         (csky_gdbarch_init): Don't register deleted functions with
7068         gdbarch.
7069
7070 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7071
7072         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7073         (cris_unwind_pc): Delete.
7074         (cris_unwind_sp): Delete.
7075         (cris_gdbarch_init): Don't register deleted functions with
7076         gdbarch.
7077
7078 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7079
7080         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7081         (bfin_unwind_pc): Delete.
7082         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7083
7084 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7085
7086         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7087         (arm_unwind_pc): Delete.
7088         (arm_unwind_sp): Delete.
7089         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7090
7091 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7092
7093         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7094         (arc_unwind_pc): Delete.
7095         (arc_unwind_sp): Delete.
7096         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7097
7098 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7099
7100         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7101         (alpha_unwind_pc): Delete.
7102         (alpha_gdbarch_init): Don't register deleted functions with
7103         gdbarch.
7104
7105 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7106
7107         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7108         (aarch64_unwind_pc): Delete.
7109         (aarch64_unwind_sp): Delete.
7110         (aarch64_gdbarch_init): Don't register deleted functions with
7111         gdbarch.
7112
7113 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7114
7115         * gdbtypes.c (type_align): Don't consider static members when
7116         computing structure alignment.
7117
7118 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7119
7120         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7121         return 0 for other types.
7122         * arch-utils.c (default_type_align): Always return 0.
7123         * gdbarch.h: Regenerate.
7124         * gdbarch.sh (type_align): Extend comment.
7125         * gdbtypes.c (type_align): Add additional comments, always call
7126         gdbarch_type_align before applying the default rules.
7127         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7128         generic code will then apply a suitable default.
7129         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7130         types, return 0 for other types.
7131
7132 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7133
7134         * NEWS: Create a new section for the next release branch.
7135         Rename the section of the current branch, now that it has
7136         been cut.
7137
7138 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7139
7140         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7141         * version.in: Bump version to 8.3.50.DATE-git.
7142
7143 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7144
7145         * aix-thread.c (ptid_cmp): Remove unused variable.
7146         (get_signaled_thread): Likewise.
7147         (store_regs_user_thread): Likewise.
7148         (store_regs_kernel_thread): Likewise.
7149         (fetch_regs_kernel_thread): Remove shadowed variable.
7150
7151 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7152
7153         * features/riscv/32bit-cpu.xml: Add register numbers.
7154         * features/riscv/32bit-fpu.c: Regenerate.
7155         * features/riscv/32bit-fpu.xml: Add register numbers.
7156         * features/riscv/64bit-cpu.xml: Add register numbers.
7157         * features/riscv/64bit-fpu.c: Regenerate.
7158         * features/riscv/64bit-fpu.xml: Add register numbers.
7159
7160 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7161
7162         * NEWS: Mention two argument form of gdb.Value constructor.
7163         * python/py-value.c (convert_buffer_and_type_to_value): New
7164         function.
7165         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7166         Add support for handling an optional second argument.  Call
7167         convert_buffer_and_type_to_value as appropriate.
7168         * python/python-internal.h (Py_buffer_deleter): New struct.
7169         (Py_buffer_up): New typedef.
7170
7171 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7172
7173         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7174         instead of releasing ownership.
7175
7176 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7177
7178         * dwarf2read.c (open_and_init_dwp_file): Call
7179         elf_numsections instead of bfd_count_sections to initialize
7180         dwp_file->num_sections.
7181
7182 2019-02-25  Tom Tromey  <tromey@adacore.com>
7183
7184         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7185
7186 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7187
7188         * gcore.in: Add '--readnever' option when invoking GDB.
7189
7190 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7191
7192         * MAINTAINERS: Update my email address.
7193
7194 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7195
7196         * build-id.c (build_id_to_debug_bfd_1): New function.
7197         (build_id_to_debug_bfd): Look for separate debug file in
7198         sysroot.
7199
7200 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7201
7202         * gdbarch.sh: Update the copyright year range that is placed into
7203         generated files.
7204
7205 2019-02-22  Keith Seitz  <keiths@redhat.com>
7206
7207         PR symtab/23853
7208         * linespec.c (create_sals_line_offset): Search for the default
7209         symtab's filename instead of its fullname.
7210
7211 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7212
7213         * NEWS: Update style defaults.
7214
7215 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7216
7217         * main.c (captured_main_1): Disable styling in batch mode.
7218
7219 2019-02-20  Tom Tromey  <tom@tromey.com>
7220
7221         * symtab.c (symtab_symbol_info): Fix typos.
7222
7223 2019-02-20  Tom Tromey  <tromey@adacore.com>
7224
7225         * findcmd.c (_initialize_mem_search): Use upper case for
7226         metasyntactic variables.
7227
7228 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7229
7230         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7231         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7232
7233 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7234
7235         * top.h (source_file_name): Change to std::string.
7236         * top.c (source_file_name): Likewise.
7237         (command_line_input): Adjust.
7238         * cli/cli-script.c (script_from_file): Adjust.
7239
7240 2019-02-19  Tom Tromey  <tromey@adacore.com>
7241
7242         * ravenscar-thread.c
7243         (ravenscar_thread_target::update_thread_list): Don't call
7244         ada_build_task_list.
7245         * ada-lang.h (ada_build_task_list): Don't declare.
7246         * ada-tasks.c (struct ada_tasks_inferior_data)
7247         <task_list_valid_p>: Now bool.
7248         (read_known_tasks, ada_task_list_changed)
7249         (ada_tasks_invalidate_inferior_data): Update.
7250         (read_known_tasks_array): Return bool.
7251         (read_known_tasks_list): Likewise.
7252         (read_known_tasks): Return void.
7253         (ada_build_task_list): Now static.
7254
7255 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7256
7257         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
7258         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
7259
7260 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7261
7262         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
7263         variant for ada_tasks_pspace_data_handle and
7264         ada_tasks_inferior_data_handle.
7265         (ada_tasks_pspace_data_cleanup): New function.
7266         (ada_tasks_inferior_data_cleanup): New function.
7267
7268 2019-02-17  Tom Tromey  <tom@tromey.com>
7269
7270         * macrotab.h (macro_source_fullname): Return a std::string.
7271         * macrotab.c (macro_include, check_for_redefinition)
7272         (macro_undef, macro_lookup_definition, foreach_macro)
7273         (foreach_macro_in_scope): Update.
7274         (macro_source_fullname): Return a std::string.
7275         * macrocmd.c (show_pp_source_pos): Update.
7276
7277 2019-02-17  Tom Tromey  <tom@tromey.com>
7278
7279         * macrocmd.c (show_pp_source_pos): Style the file names.
7280
7281 2019-02-17  Tom Tromey  <tom@tromey.com>
7282
7283         PR tui/24197:
7284         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
7285
7286 2019-02-17  Tom Tromey  <tom@tromey.com>
7287
7288         * ada-lang.c (user_select_syms): Use filtered printing.
7289         * utils.c (wrap_style): New global.
7290         (desired_style): Remove.
7291         (emit_style_escape): Add stream parameter.
7292         (set_output_style, reset_terminal_style, prompt_for_continue):
7293         Update.
7294         (flush_wrap_buffer): Only flush gdb_stdout.
7295         (wrap_here): Set wrap_style.
7296         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
7297         treat escape sequences as a character.  Change when wrap buffer is
7298         flushed.
7299         (fputs_styled): Do not set the output style when the default is
7300         requested.
7301         * ui-style.h (struct ui_file_style) <is_default>: New method.
7302         * source.c (print_source_lines_base): Emit escape sequences in one
7303         piece.
7304
7305 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7306
7307         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
7308         integers and enumeration types.
7309
7310 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7311
7312         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
7313         instead of lookup_symbol_in_language
7314         (do_exact_match): New function.
7315         (ada_get_symbol_name_matcher): Return do_exact_match when
7316         doing a verbatim match.
7317
7318 2019-02-15  Tom Tromey  <tromey@adacore.com>
7319
7320         * ravenscar-thread.c (ravenscar_thread_target::resume)
7321         (ravenscar_thread_target::wait): Special case wildcard requests.
7322
7323 2019-02-15  Tom Tromey  <tromey@adacore.com>
7324
7325         * ravenscar-thread.c (base_ptid): Remove.
7326         (struct ravenscar_thread_target) <close>: New method.
7327         <m_base_ptid>: New member.
7328         <update_inferior_ptid, active_task, task_is_currently_active,
7329         runtime_initialized>: Declare methods.
7330         <ravenscar_thread_target>: Add constructor.
7331         (ravenscar_thread_target::task_is_currently_active)
7332         (ravenscar_thread_target::update_inferior_ptid)
7333         (ravenscar_runtime_initialized): Rename.  Now methods.
7334         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
7335         (ravenscar_thread_target::update_thread_list): Update.
7336         (ravenscar_thread_target::active_task): Now method.
7337         (ravenscar_thread_target::store_registers)
7338         (ravenscar_thread_target::prepare_to_store)
7339         (ravenscar_thread_target::prepare_to_store)
7340         (ravenscar_thread_target::mourn_inferior): Update.
7341         (ravenscar_inferior_created): Use "new" to create target.
7342         (ravenscar_thread_target::get_ada_task_ptid): Update.
7343         (_initialize_ravenscar): Don't initialize base_ptid.
7344         (ravenscar_ops): Remove global.
7345
7346 2019-02-15  Tom Tromey  <tromey@adacore.com>
7347
7348         * target.h (push_target): Declare new overload.
7349         * target.c (push_target): New overload, taking an rvalue reference.
7350         * remote.c (remote_target::open_1): Use push_target overload.
7351         * corelow.c (core_target_open): Use push_target overload.
7352
7353 2019-02-15  Tom Tromey  <tromey@adacore.com>
7354
7355         * ravenscar-thread.c (is_ravenscar_task)
7356         (ravenscar_task_is_currently_active): Return bool.
7357         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
7358         (_initialize_ravenscar): Remove "(void)".
7359         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
7360         Return bool.
7361
7362 2019-02-15  Tom Tromey  <tromey@adacore.com>
7363
7364         * ravenscar-thread.c (ravenscar_runtime_initializer)
7365         (has_ravenscar_runtime, get_running_thread_id)
7366         (ravenscar_thread_target::resume): Fix indentation.
7367
7368 2019-02-15  Tom Tromey  <tromey@adacore.com>
7369
7370         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
7371         from ravenscar_arch_ops.
7372         (sparc_ravenscar_ops::fetch_registers)
7373         (sparc_ravenscar_ops::store_registers): Now methods.
7374         (sparc_ravenscar_prepare_to_store): Remove.
7375         (sparc_ravenscar_ops): Redefine.
7376         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
7377         methods and destructor.  Remove members.
7378         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
7379         (ravenscar_thread_target::store_registers)
7380         (ravenscar_thread_target::prepare_to_store): Update.
7381         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
7382         Remove.
7383         (struct ppc_ravenscar_powerpc_ops): Derive from
7384         ravenscar_arch_ops.
7385         (ppc_ravenscar_powerpc_ops::fetch_registers)
7386         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
7387         (ppc_ravenscar_powerpc_ops): Redefine.
7388         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
7389         (ppc_ravenscar_e500_ops::fetch_registers)
7390         (ppc_ravenscar_e500_ops::store_registers): Now methods.
7391         (ppc_ravenscar_e500_ops): Redefine.
7392         * aarch64-ravenscar-thread.c
7393         (aarch64_ravenscar_generic_prepare_to_store): Remove.
7394         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
7395         (aarch64_ravenscar_fetch_registers)
7396         (aarch64_ravenscar_store_registers): Now methods.
7397         (aarch64_ravenscar_ops): Redefine.
7398
7399 2019-02-15  Tom Tromey  <tromey@adacore.com>
7400
7401         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
7402         (ravenscar_thread_target::stopped_by_hw_breakpoint)
7403         (ravenscar_thread_target::stopped_by_watchpoint)
7404         (ravenscar_thread_target::stopped_data_address)
7405         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
7406
7407 2019-02-15  Tom Tromey  <tromey@adacore.com>
7408
7409         * ravenscar-thread.c: Fix some typos.
7410
7411 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7412             Tom Tromey  <tromey@adacore.com>
7413
7414         * ada-lang.c (ada_exception_sal): Change addr_string to a
7415         std::string.
7416         (create_ada_exception_catchpoint): Update.
7417
7418 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7419             Tom Tromey  <tromey@adacore.com>
7420
7421         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
7422         (bp_location_ops): Remove.
7423         (base_breakpoint_allocate_location): Update.
7424         (free_bp_location): Update.
7425         * ada-lang.c (class ada_catchpoint_location)
7426         <ada_catchpoint_location>: Remove ops parameter.
7427         (ada_catchpoint_location_dtor): Remove.
7428         (ada_catchpoint_location_ops): Remove.
7429         (allocate_location_exception): Update.
7430         * breakpoint.h (struct bp_location_ops): Remove.
7431         (class bp_location) <bp_location>: Remove bp_location_ops
7432         parameter.
7433         <~bp_location>: Add destructor.
7434         <ops>: Remove.
7435
7436 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7437             Pedro Alves  <palves@redhat.com>
7438
7439         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
7440         'PATH_MAX'.
7441
7442 2019-02-14  David Michael  <fedora.dm0@gmail.com>
7443             Samuel Thibault  <samuel.thibault@gnu.org>
7444             Thomas Schwinge  <thomas@codesourcery.com>
7445
7446         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
7447         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
7448
7449 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7450
7451         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
7452         (check_empty): Use "const char *".
7453
7454         * gnu-nat.c (gnu_nat_target::detach): Instead of
7455         'detach_inferior (pid)' call
7456         'detach_inferior (find_inferior_pid (pid))'.
7457
7458         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
7459         'nat/fork-inferior.o'.
7460         * gnu-nat.c: #include "nat/fork-inferior.h".
7461
7462         * gnu-nat.c (gnu_nat_target::detach): Instead of
7463         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
7464         * gnu-nat.h: #include "inf-child.h".
7465         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
7466         'i386_gnu_nat_target::fetch_registers'.
7467         (gnu_store_registers): Rename/move to
7468         'i386_gnu_nat_target::store_registers'.
7469
7470         * config/i386/nm-i386gnu.h: Don't "#include" any files.
7471         * gnu-nat.h (mach_thread_info): New function.
7472         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
7473
7474         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
7475
7476 2019-02-14  Frederic Konrad  <konrad@adacore.com>
7477
7478         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
7479
7480 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
7481
7482         * windows-nat.c (windows_add_thread): Add new parameter
7483         "main_thread_p" with default value set to false.  Update
7484         function documentation as well as all callers.
7485         (windows_delete_thread): Likewise.
7486         (fake_create_process): Update call to windows_add_thread.
7487         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
7488         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
7489         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
7490         call to windows_delete_thread.
7491
7492 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
7493
7494         * MAINTAINERS: Add Andrew Burgess as global maintainer.
7495
7496 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7497
7498         * symfile.c (find_separate_debug_file): Use canonical path of
7499         sysroot with child_path instead of gdb_sysroot if it is valid.
7500
7501 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7502
7503         * symfile.c (find_separate_debug_file): Use child_path to
7504         determine if an object file is under a sysroot.
7505
7506 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7507
7508         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
7509         unittests/child-path-selftests.c.
7510         * common/pathstuff.c (child_path): New function.
7511         * common/pathstuff.h (child_path): New prototype.
7512         * unittests/child-path-selftests.c: New file.
7513
7514 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7515
7516         * symfile.c (find_separate_debug_file): Look for separate debug
7517         files in debug directories under the sysroot.
7518
7519 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7520
7521         * symtab.h (struct minimal_symbol data_p): New const method.
7522         (struct minimal_symbol text_p): Likewise.
7523         * symtab.c (output_source_filename): Use file name style
7524         to print file name.
7525         (print_symbol_info): Likewise.
7526         (print_msymbol_info): Use address style to print addresses.
7527         Use function name style to print executable text symbols.
7528         (expand_symtab_containing_pc): Use data_p.
7529         (find_pc_sect_compunit_symtab): Likewise.
7530
7531 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7532
7533         * breakpoint.c (describe_other_breakpoints): Use address style
7534         to print addresses.
7535         (say_where): Likewise.
7536
7537 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7538
7539         * ada-typeprint.c (print_func_type): Print function name
7540         style to print function name.
7541         * c-typeprint.c (c_print_type_1): Likewise.
7542
7543 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
7544
7545         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
7546         for execve.
7547
7548 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7549
7550         * c-exp.y (direct_abs_decl): Use emplace_back to record the
7551         type_stack.
7552
7553 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
7554
7555         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
7556         TYPE_CODE_REF types.
7557
7558 2019-02-08  Jim Wilson  <jimw@sifive.com>
7559
7560         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
7561         (riscv_linux_fregset): New.
7562         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
7563
7564 2019-02-07  Tom Tromey  <tom@tromey.com>
7565
7566         * thread.c (thread_cancel_execution_command): Update.
7567         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
7568         methods.
7569         (struct thread_fsm_ops): Remove.
7570         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
7571         (thread_fsm_should_stop, thread_fsm_return_value)
7572         (thread_fsm_set_finished, thread_fsm_finished_p)
7573         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
7574         Don't declare.
7575         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
7576         * infrun.c (clear_proceed_status_thread)
7577         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
7578         (print_stop_event): Update.
7579         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
7580         Add constructor.
7581         (step_command_fsm_ops): Remove.
7582         (new_step_command_fsm): Remove.
7583         (step_1): Update.
7584         (step_command_fsm::should_stop): Rename from
7585         step_command_fsm_should_stop.
7586         (step_command_fsm::clean_up): Rename from
7587         step_command_fsm_clean_up.
7588         (step_command_fsm::do_async_reply_reason): Rename from
7589         step_command_fsm_async_reply_reason.
7590         (struct until_next_fsm): Inherit from thread_fsm.  Add
7591         constructor.
7592         (until_next_fsm_ops): Remove.
7593         (new_until_next_fsm): Remove.
7594         (until_next_fsm::should_stop): Rename from
7595         until_next_fsm_should_stop.
7596         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
7597         (until_next_fsm::do_async_reply_reason): Rename from
7598         until_next_fsm_async_reply_reason.
7599         (struct finish_command_fsm): Inherit from thread_fsm.  Add
7600         constructor.  Change type of breakpoint.
7601         (finish_command_fsm_ops): Remove.
7602         (new_finish_command_fsm): Remove.
7603         (finish_command_fsm::should_stop): Rename from
7604         finish_command_fsm_should_stop.
7605         (finish_command_fsm::clean_up): Rename from
7606         finish_command_fsm_clean_up.
7607         (finish_command_fsm::return_value): Rename from
7608         finish_command_fsm_return_value.
7609         (finish_command_fsm::do_async_reply_reason): Rename from
7610         finish_command_fsm_async_reply_reason.
7611         (finish_command): Update.
7612         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
7613         Add constructor.
7614         (call_thread_fsm_ops): Remove.
7615         (call_thread_fsm::call_thread_fsm): Rename from
7616         new_call_thread_fsm.
7617         (call_thread_fsm::should_stop): Rename from
7618         call_thread_fsm_should_stop.
7619         (call_thread_fsm::should_notify_stop): Rename from
7620         call_thread_fsm_should_notify_stop.
7621         (run_inferior_call, call_function_by_hand_dummy): Update.
7622         * cli/cli-interp.c (should_print_stop_to_console): Update.
7623         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
7624         Add constructor.  Change type of location_breakpoint,
7625         caller_breakpoint.
7626         (until_break_fsm_ops): Remove.
7627         (new_until_break_fsm): Remove.
7628         (until_break_fsm::should_stop): Rename from
7629         until_break_fsm_should_stop.
7630         (until_break_fsm::clean_up): Rename from
7631         until_break_fsm_clean_up.
7632         (until_break_fsm::do_async_reply_reason): Rename from
7633         until_break_fsm_async_reply_reason.
7634         (until_break_command): Update.
7635         * thread-fsm.c: Remove.
7636         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
7637
7638 2019-02-07  Tom Tromey  <tom@tromey.com>
7639
7640         * yy-remap.h: Add include guard.
7641         * xtensa-tdep.h: Add include guard.
7642         * xcoffread.h: Rename include guard.
7643         * varobj-iter.h: Add include guard.
7644         * tui/tui.h: Rename include guard.
7645         * tui/tui-winsource.h: Rename include guard.
7646         * tui/tui-wingeneral.h: Rename include guard.
7647         * tui/tui-windata.h: Rename include guard.
7648         * tui/tui-win.h: Rename include guard.
7649         * tui/tui-stack.h: Rename include guard.
7650         * tui/tui-source.h: Rename include guard.
7651         * tui/tui-regs.h: Rename include guard.
7652         * tui/tui-out.h: Rename include guard.
7653         * tui/tui-layout.h: Rename include guard.
7654         * tui/tui-io.h: Rename include guard.
7655         * tui/tui-hooks.h: Rename include guard.
7656         * tui/tui-file.h: Rename include guard.
7657         * tui/tui-disasm.h: Rename include guard.
7658         * tui/tui-data.h: Rename include guard.
7659         * tui/tui-command.h: Rename include guard.
7660         * tic6x-tdep.h: Add include guard.
7661         * target/waitstatus.h: Rename include guard.
7662         * target/wait.h: Rename include guard.
7663         * target/target.h: Rename include guard.
7664         * target/resume.h: Rename include guard.
7665         * target-float.h: Rename include guard.
7666         * stabsread.h: Add include guard.
7667         * rs6000-tdep.h: Add include guard.
7668         * riscv-fbsd-tdep.h: Add include guard.
7669         * regformats/regdef.h: Rename include guard.
7670         * record.h: Rename include guard.
7671         * python/python.h: Rename include guard.
7672         * python/python-internal.h: Rename include guard.
7673         * python/py-stopevent.h: Rename include guard.
7674         * python/py-ref.h: Rename include guard.
7675         * python/py-record.h: Rename include guard.
7676         * python/py-record-full.h: Rename include guard.
7677         * python/py-record-btrace.h: Rename include guard.
7678         * python/py-instruction.h: Rename include guard.
7679         * python/py-events.h: Rename include guard.
7680         * python/py-event.h: Rename include guard.
7681         * procfs.h: Add include guard.
7682         * proc-utils.h: Add include guard.
7683         * p-lang.h: Add include guard.
7684         * or1k-tdep.h: Rename include guard.
7685         * observable.h: Rename include guard.
7686         * nto-tdep.h: Rename include guard.
7687         * nat/x86-linux.h: Rename include guard.
7688         * nat/x86-linux-dregs.h: Rename include guard.
7689         * nat/x86-gcc-cpuid.h: Add include guard.
7690         * nat/x86-dregs.h: Rename include guard.
7691         * nat/x86-cpuid.h: Rename include guard.
7692         * nat/ppc-linux.h: Rename include guard.
7693         * nat/mips-linux-watch.h: Rename include guard.
7694         * nat/linux-waitpid.h: Rename include guard.
7695         * nat/linux-ptrace.h: Rename include guard.
7696         * nat/linux-procfs.h: Rename include guard.
7697         * nat/linux-osdata.h: Rename include guard.
7698         * nat/linux-nat.h: Rename include guard.
7699         * nat/linux-namespaces.h: Rename include guard.
7700         * nat/linux-btrace.h: Rename include guard.
7701         * nat/glibc_thread_db.h: Rename include guard.
7702         * nat/gdb_thread_db.h: Rename include guard.
7703         * nat/gdb_ptrace.h: Rename include guard.
7704         * nat/fork-inferior.h: Rename include guard.
7705         * nat/amd64-linux-siginfo.h: Rename include guard.
7706         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
7707         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
7708         * nat/aarch64-linux.h: Rename include guard.
7709         * nat/aarch64-linux-hw-point.h: Rename include guard.
7710         * mn10300-tdep.h: Add include guard.
7711         * mips-linux-tdep.h: Add include guard.
7712         * mi/mi-parse.h: Rename include guard.
7713         * mi/mi-out.h: Rename include guard.
7714         * mi/mi-main.h: Rename include guard.
7715         * mi/mi-interp.h: Rename include guard.
7716         * mi/mi-getopt.h: Rename include guard.
7717         * mi/mi-console.h: Rename include guard.
7718         * mi/mi-common.h: Rename include guard.
7719         * mi/mi-cmds.h: Rename include guard.
7720         * mi/mi-cmd-break.h: Rename include guard.
7721         * m2-lang.h: Add include guard.
7722         * location.h: Rename include guard.
7723         * linux-record.h: Rename include guard.
7724         * linux-nat.h: Add include guard.
7725         * linux-fork.h: Add include guard.
7726         * i386-darwin-tdep.h: Rename include guard.
7727         * hppa-linux-offsets.h: Add include guard.
7728         * guile/guile.h: Rename include guard.
7729         * guile/guile-internal.h: Rename include guard.
7730         * gnu-nat.h: Rename include guard.
7731         * gdb-stabs.h: Rename include guard.
7732         * frv-tdep.h: Add include guard.
7733         * f-lang.h: Add include guard.
7734         * event-loop.h: Add include guard.
7735         * darwin-nat.h: Rename include guard.
7736         * cp-abi.h: Rename include guard.
7737         * config/sparc/nm-sol2.h: Rename include guard.
7738         * config/nm-nto.h: Rename include guard.
7739         * config/nm-linux.h: Add include guard.
7740         * config/i386/nm-i386gnu.h: Rename include guard.
7741         * config/djgpp/nl_types.h: Rename include guard.
7742         * config/djgpp/langinfo.h: Rename include guard.
7743         * compile/gcc-cp-plugin.h: Add include guard.
7744         * compile/gcc-c-plugin.h: Add include guard.
7745         * compile/compile.h: Rename include guard.
7746         * compile/compile-object-run.h: Rename include guard.
7747         * compile/compile-object-load.h: Rename include guard.
7748         * compile/compile-internal.h: Rename include guard.
7749         * compile/compile-cplus.h: Rename include guard.
7750         * compile/compile-c.h: Rename include guard.
7751         * common/xml-utils.h: Rename include guard.
7752         * common/x86-xstate.h: Rename include guard.
7753         * common/version.h: Rename include guard.
7754         * common/vec.h: Rename include guard.
7755         * common/tdesc.h: Rename include guard.
7756         * common/selftest.h: Rename include guard.
7757         * common/scoped_restore.h: Rename include guard.
7758         * common/scoped_mmap.h: Rename include guard.
7759         * common/scoped_fd.h: Rename include guard.
7760         * common/safe-iterator.h: Rename include guard.
7761         * common/run-time-clock.h: Rename include guard.
7762         * common/refcounted-object.h: Rename include guard.
7763         * common/queue.h: Rename include guard.
7764         * common/ptid.h: Rename include guard.
7765         * common/print-utils.h: Rename include guard.
7766         * common/preprocessor.h: Rename include guard.
7767         * common/pathstuff.h: Rename include guard.
7768         * common/observable.h: Rename include guard.
7769         * common/netstuff.h: Rename include guard.
7770         * common/job-control.h: Rename include guard.
7771         * common/host-defs.h: Rename include guard.
7772         * common/gdb_wait.h: Rename include guard.
7773         * common/gdb_vecs.h: Rename include guard.
7774         * common/gdb_unlinker.h: Rename include guard.
7775         * common/gdb_unique_ptr.h: Rename include guard.
7776         * common/gdb_tilde_expand.h: Rename include guard.
7777         * common/gdb_sys_time.h: Rename include guard.
7778         * common/gdb_string_view.h: Rename include guard.
7779         * common/gdb_splay_tree.h: Rename include guard.
7780         * common/gdb_setjmp.h: Rename include guard.
7781         * common/gdb_ref_ptr.h: Rename include guard.
7782         * common/gdb_optional.h: Rename include guard.
7783         * common/gdb_locale.h: Rename include guard.
7784         * common/gdb_assert.h: Rename include guard.
7785         * common/filtered-iterator.h: Rename include guard.
7786         * common/filestuff.h: Rename include guard.
7787         * common/fileio.h: Rename include guard.
7788         * common/environ.h: Rename include guard.
7789         * common/common-utils.h: Rename include guard.
7790         * common/common-types.h: Rename include guard.
7791         * common/common-regcache.h: Rename include guard.
7792         * common/common-inferior.h: Rename include guard.
7793         * common/common-gdbthread.h: Rename include guard.
7794         * common/common-exceptions.h: Rename include guard.
7795         * common/common-defs.h: Rename include guard.
7796         * common/common-debug.h: Rename include guard.
7797         * common/cleanups.h: Rename include guard.
7798         * common/buffer.h: Rename include guard.
7799         * common/btrace-common.h: Rename include guard.
7800         * common/break-common.h: Rename include guard.
7801         * cli/cli-utils.h: Rename include guard.
7802         * cli/cli-style.h: Rename include guard.
7803         * cli/cli-setshow.h: Rename include guard.
7804         * cli/cli-script.h: Rename include guard.
7805         * cli/cli-interp.h: Rename include guard.
7806         * cli/cli-decode.h: Rename include guard.
7807         * cli/cli-cmds.h: Rename include guard.
7808         * charset-list.h: Add include guard.
7809         * buildsym-legacy.h: Rename include guard.
7810         * bfin-tdep.h: Add include guard.
7811         * ax.h: Rename include guard.
7812         * arm-linux-tdep.h: Add include guard.
7813         * arm-fbsd-tdep.h: Add include guard.
7814         * arch/xtensa.h: Rename include guard.
7815         * arch/tic6x.h: Add include guard.
7816         * arch/i386.h: Add include guard.
7817         * arch/arm.h: Rename include guard.
7818         * arch/arm-linux.h: Rename include guard.
7819         * arch/arm-get-next-pcs.h: Rename include guard.
7820         * arch/amd64.h: Add include guard.
7821         * arch/aarch64-insn.h: Rename include guard.
7822         * arch-utils.h: Rename include guard.
7823         * annotate.h: Add include guard.
7824         * amd64-darwin-tdep.h: Rename include guard.
7825         * aarch64-linux-tdep.h: Add include guard.
7826         * aarch64-fbsd-tdep.h: Add include guard.
7827         * aarch32-linux-nat.h: Add include guard.
7828
7829 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7830
7831         * macrotab.c (macro_define_internal): New function that
7832         factorizes macro_define_object_internal and macro_define_function
7833         code.
7834         (macro_define_object_internal): Use macro_define_internal.
7835         (macro_define_function): Likewise.
7836
7837 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7838
7839         * macrocmd.c (extract_identifier): Return
7840         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
7841         callers.
7842
7843 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
7844
7845         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
7846
7847 2019-02-05  Tom Tromey  <tom@tromey.com>
7848
7849         * target.c (target_stack::unpush): Move assertion earlier.
7850
7851 2019-01-30  Tom Tromey  <tom@tromey.com>
7852
7853         PR python/23615:
7854         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
7855         (gdbpy_parse_and_eval): Likewise.
7856         * python/python-internal.h (gdbpy_allow_threads): New class.
7857
7858 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
7859
7860         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
7861         (aarch64_fbsd_fpregmap): Move earlier.
7862         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
7863         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7864         instead of individual calls to trad_frame_set_reg_addr.
7865         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
7866         earlier.
7867         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
7868         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7869         instead of individual calls to trad_frame_set_reg_addr.
7870
7871 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
7872
7873         * CONTRIBUTE: Replace contribution list with wiki link.
7874
7875 2019-01-25  Tom Tromey  <tom@tromey.com>
7876
7877         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
7878
7879 2019-01-25  Tom Tromey  <tom@tromey.com>
7880
7881         * xtensa-linux-nat.c: Fix common/ includes.
7882         * xml-support.h: Fix common/ includes.
7883         * xml-support.c: Fix common/ includes.
7884         * x86-linux-nat.c: Fix common/ includes.
7885         * windows-nat.c: Fix common/ includes.
7886         * varobj.h: Fix common/ includes.
7887         * varobj.c: Fix common/ includes.
7888         * value.c: Fix common/ includes.
7889         * valops.c: Fix common/ includes.
7890         * utils.c: Fix common/ includes.
7891         * unittests/xml-utils-selftests.c: Fix common/ includes.
7892         * unittests/utils-selftests.c: Fix common/ includes.
7893         * unittests/unpack-selftests.c: Fix common/ includes.
7894         * unittests/tracepoint-selftests.c: Fix common/ includes.
7895         * unittests/style-selftests.c: Fix common/ includes.
7896         * unittests/string_view-selftests.c: Fix common/ includes.
7897         * unittests/scoped_restore-selftests.c: Fix common/ includes.
7898         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
7899         * unittests/scoped_fd-selftests.c: Fix common/ includes.
7900         * unittests/rsp-low-selftests.c: Fix common/ includes.
7901         * unittests/parse-connection-spec-selftests.c: Fix common/
7902         includes.
7903         * unittests/optional-selftests.c: Fix common/ includes.
7904         * unittests/offset-type-selftests.c: Fix common/ includes.
7905         * unittests/observable-selftests.c: Fix common/ includes.
7906         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
7907         * unittests/memrange-selftests.c: Fix common/ includes.
7908         * unittests/memory-map-selftests.c: Fix common/ includes.
7909         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
7910         * unittests/function-view-selftests.c: Fix common/ includes.
7911         * unittests/environ-selftests.c: Fix common/ includes.
7912         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
7913         * unittests/common-utils-selftests.c: Fix common/ includes.
7914         * unittests/cli-utils-selftests.c: Fix common/ includes.
7915         * unittests/array-view-selftests.c: Fix common/ includes.
7916         * ui-file.c: Fix common/ includes.
7917         * tui/tui-io.c: Fix common/ includes.
7918         * tracepoint.h: Fix common/ includes.
7919         * tracepoint.c: Fix common/ includes.
7920         * tracefile-tfile.c: Fix common/ includes.
7921         * top.h: Fix common/ includes.
7922         * top.c: Fix common/ includes.
7923         * thread.c: Fix common/ includes.
7924         * target/waitstatus.h: Fix common/ includes.
7925         * target/waitstatus.c: Fix common/ includes.
7926         * target.h: Fix common/ includes.
7927         * target.c: Fix common/ includes.
7928         * target-memory.c: Fix common/ includes.
7929         * target-descriptions.c: Fix common/ includes.
7930         * symtab.h: Fix common/ includes.
7931         * symfile.c: Fix common/ includes.
7932         * stap-probe.c: Fix common/ includes.
7933         * spu-linux-nat.c: Fix common/ includes.
7934         * sparc-nat.c: Fix common/ includes.
7935         * source.c: Fix common/ includes.
7936         * solib.c: Fix common/ includes.
7937         * solib-target.c: Fix common/ includes.
7938         * ser-unix.c: Fix common/ includes.
7939         * ser-tcp.c: Fix common/ includes.
7940         * ser-pipe.c: Fix common/ includes.
7941         * ser-base.c: Fix common/ includes.
7942         * selftest-arch.c: Fix common/ includes.
7943         * s12z-tdep.c: Fix common/ includes.
7944         * rust-exp.y: Fix common/ includes.
7945         * rs6000-aix-tdep.c: Fix common/ includes.
7946         * riscv-tdep.c: Fix common/ includes.
7947         * remote.c: Fix common/ includes.
7948         * remote-notif.h: Fix common/ includes.
7949         * remote-fileio.h: Fix common/ includes.
7950         * remote-fileio.c: Fix common/ includes.
7951         * regcache.h: Fix common/ includes.
7952         * regcache.c: Fix common/ includes.
7953         * record-btrace.c: Fix common/ includes.
7954         * python/python.c: Fix common/ includes.
7955         * python/py-type.c: Fix common/ includes.
7956         * python/py-inferior.c: Fix common/ includes.
7957         * progspace.h: Fix common/ includes.
7958         * producer.c: Fix common/ includes.
7959         * procfs.c: Fix common/ includes.
7960         * proc-api.c: Fix common/ includes.
7961         * printcmd.c: Fix common/ includes.
7962         * ppc-linux-nat.c: Fix common/ includes.
7963         * parser-defs.h: Fix common/ includes.
7964         * osdata.c: Fix common/ includes.
7965         * obsd-nat.c: Fix common/ includes.
7966         * nat/x86-linux.c: Fix common/ includes.
7967         * nat/x86-linux-dregs.c: Fix common/ includes.
7968         * nat/x86-dregs.h: Fix common/ includes.
7969         * nat/x86-dregs.c: Fix common/ includes.
7970         * nat/ppc-linux.c: Fix common/ includes.
7971         * nat/mips-linux-watch.h: Fix common/ includes.
7972         * nat/mips-linux-watch.c: Fix common/ includes.
7973         * nat/linux-waitpid.c: Fix common/ includes.
7974         * nat/linux-ptrace.h: Fix common/ includes.
7975         * nat/linux-ptrace.c: Fix common/ includes.
7976         * nat/linux-procfs.c: Fix common/ includes.
7977         * nat/linux-personality.c: Fix common/ includes.
7978         * nat/linux-osdata.c: Fix common/ includes.
7979         * nat/linux-namespaces.c: Fix common/ includes.
7980         * nat/linux-btrace.h: Fix common/ includes.
7981         * nat/linux-btrace.c: Fix common/ includes.
7982         * nat/fork-inferior.c: Fix common/ includes.
7983         * nat/amd64-linux-siginfo.c: Fix common/ includes.
7984         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
7985         * nat/aarch64-linux.c: Fix common/ includes.
7986         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
7987         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
7988         * namespace.h: Fix common/ includes.
7989         * mips-linux-tdep.c: Fix common/ includes.
7990         * minsyms.c: Fix common/ includes.
7991         * mi/mi-parse.h: Fix common/ includes.
7992         * mi/mi-main.c: Fix common/ includes.
7993         * mi/mi-cmd-env.c: Fix common/ includes.
7994         * memrange.h: Fix common/ includes.
7995         * memattr.c: Fix common/ includes.
7996         * maint.h: Fix common/ includes.
7997         * maint.c: Fix common/ includes.
7998         * main.c: Fix common/ includes.
7999         * machoread.c: Fix common/ includes.
8000         * location.c: Fix common/ includes.
8001         * linux-thread-db.c: Fix common/ includes.
8002         * linux-nat.c: Fix common/ includes.
8003         * linux-fork.c: Fix common/ includes.
8004         * inline-frame.c: Fix common/ includes.
8005         * infrun.c: Fix common/ includes.
8006         * inflow.c: Fix common/ includes.
8007         * inferior.h: Fix common/ includes.
8008         * inferior.c: Fix common/ includes.
8009         * infcmd.c: Fix common/ includes.
8010         * inf-ptrace.c: Fix common/ includes.
8011         * inf-child.c: Fix common/ includes.
8012         * ia64-linux-nat.c: Fix common/ includes.
8013         * i387-tdep.c: Fix common/ includes.
8014         * i386-tdep.c: Fix common/ includes.
8015         * i386-linux-tdep.c: Fix common/ includes.
8016         * i386-linux-nat.c: Fix common/ includes.
8017         * i386-go32-tdep.c: Fix common/ includes.
8018         * i386-fbsd-tdep.c: Fix common/ includes.
8019         * i386-fbsd-nat.c: Fix common/ includes.
8020         * guile/scm-type.c: Fix common/ includes.
8021         * guile/guile.c: Fix common/ includes.
8022         * go32-nat.c: Fix common/ includes.
8023         * gnu-nat.c: Fix common/ includes.
8024         * gdbthread.h: Fix common/ includes.
8025         * gdbarch-selftests.c: Fix common/ includes.
8026         * gdb_usleep.c: Fix common/ includes.
8027         * gdb_select.h: Fix common/ includes.
8028         * gdb_bfd.c: Fix common/ includes.
8029         * gcore.c: Fix common/ includes.
8030         * fork-child.c: Fix common/ includes.
8031         * findvar.c: Fix common/ includes.
8032         * fbsd-nat.c: Fix common/ includes.
8033         * event-top.c: Fix common/ includes.
8034         * event-loop.c: Fix common/ includes.
8035         * dwarf2read.c: Fix common/ includes.
8036         * dwarf2loc.c: Fix common/ includes.
8037         * dwarf2-frame.c: Fix common/ includes.
8038         * dwarf-index-cache.c: Fix common/ includes.
8039         * dtrace-probe.c: Fix common/ includes.
8040         * disasm-selftests.c: Fix common/ includes.
8041         * defs.h: Fix common/ includes.
8042         * csky-tdep.c: Fix common/ includes.
8043         * cp-valprint.c: Fix common/ includes.
8044         * cp-support.h: Fix common/ includes.
8045         * cp-support.c: Fix common/ includes.
8046         * corelow.c: Fix common/ includes.
8047         * completer.h: Fix common/ includes.
8048         * completer.c: Fix common/ includes.
8049         * compile/compile.c: Fix common/ includes.
8050         * compile/compile-loc2c.c: Fix common/ includes.
8051         * compile/compile-cplus-types.c: Fix common/ includes.
8052         * compile/compile-cplus-symbols.c: Fix common/ includes.
8053         * command.h: Fix common/ includes.
8054         * cli/cli-dump.c: Fix common/ includes.
8055         * cli/cli-cmds.c: Fix common/ includes.
8056         * charset.c: Fix common/ includes.
8057         * build-id.c: Fix common/ includes.
8058         * btrace.h: Fix common/ includes.
8059         * btrace.c: Fix common/ includes.
8060         * breakpoint.h: Fix common/ includes.
8061         * breakpoint.c: Fix common/ includes.
8062         * ax.h:
8063         (enum agent_op): Fix common/ includes.
8064         * ax-general.c (struct aop_map): Fix common/ includes.
8065         * ax-gdb.c: Fix common/ includes.
8066         * auxv.c: Fix common/ includes.
8067         * auto-load.c: Fix common/ includes.
8068         * arm-tdep.c: Fix common/ includes.
8069         * arch/riscv.c: Fix common/ includes.
8070         * arch/ppc-linux-common.c: Fix common/ includes.
8071         * arch/i386.c: Fix common/ includes.
8072         * arch/arm.c: Fix common/ includes.
8073         * arch/arm-linux.c: Fix common/ includes.
8074         * arch/arm-get-next-pcs.c: Fix common/ includes.
8075         * arch/amd64.c: Fix common/ includes.
8076         * arch/aarch64.c: Fix common/ includes.
8077         * arch/aarch64-insn.c: Fix common/ includes.
8078         * arch-utils.c: Fix common/ includes.
8079         * amd64-windows-tdep.c: Fix common/ includes.
8080         * amd64-tdep.c: Fix common/ includes.
8081         * amd64-sol2-tdep.c: Fix common/ includes.
8082         * amd64-obsd-tdep.c: Fix common/ includes.
8083         * amd64-nbsd-tdep.c: Fix common/ includes.
8084         * amd64-linux-tdep.c: Fix common/ includes.
8085         * amd64-linux-nat.c: Fix common/ includes.
8086         * amd64-fbsd-tdep.c: Fix common/ includes.
8087         * amd64-fbsd-nat.c: Fix common/ includes.
8088         * amd64-dicos-tdep.c: Fix common/ includes.
8089         * amd64-darwin-tdep.c: Fix common/ includes.
8090         * agent.c: Fix common/ includes.
8091         * ada-lang.h: Fix common/ includes.
8092         * ada-lang.c: Fix common/ includes.
8093         * aarch64-tdep.c: Fix common/ includes.
8094
8095 2019-01-25  Tom Tromey  <tom@tromey.com>
8096
8097         * common/create-version.sh: Use common/version.h.
8098
8099 2019-01-24  Pedro Alves  <palves@redhat.com>
8100
8101         * infrun.c (signal_stop, signal_print, signal_program)
8102         (signal_catch, signal_pass): Now arrays instead of pointers.
8103         (update_signals_program_target, do_target_resume)
8104         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8105         * linux-nat.c (linux_nat_target::pass_signals)
8106         (linux_nat_target::create_inferior, linux_nat_target::attach):
8107         Adjust.
8108         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8109         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8110         * procfs.c (procfs_target::pass_signals): Adjust.
8111         * record-full.c (record_full_target::resume): Adjust.
8112         * remote.c (remote_target::pass_signals)
8113         (remote_target::program_signals): Adjust.
8114         * target-debug.h (target_debug_print_signals): Now takes a
8115         gdb::array_view as parameter.  Adjust.
8116         * target.h (target_ops) <pass_signals, program_signals>: Replace
8117         pointer and length parameters with gdb::array_view.
8118         (target_pass_signals, target_program_signals): Likewise.
8119         * target-delegates.c: Regenerate.
8120
8121 2019-01-24  Pedro Alves  <palves@redhat.com>
8122
8123         * common/forward-scope-exit.h
8124         (forward_scope_exit::forward_scope_exit): Pass arguments to
8125         m_bind_function directly, instead of creating a std::bind and
8126         copying that.
8127
8128 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8129
8130         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8131         for static members.
8132         (pass_in_v_vfp_candidate): Likewise.
8133
8134 2019-01-23  Tom Tromey  <tom@tromey.com>
8135             Pedro Alves  <palves@redhat.com>
8136
8137         * regcache.c (class regcache_invalidator): Remove.
8138         (regcache::raw_write): Use make_scope_exit.
8139
8140 2019-01-23  Tom Tromey  <tom@tromey.com>
8141
8142         * ui-out.h (class ui_out_emit_type): Update comment.
8143
8144 2019-01-23  Tom Tromey  <tom@tromey.com>
8145
8146         * infrun.c (fetch_inferior_event): Update comment.
8147
8148 2019-01-23  Tom Tromey  <tom@tromey.com>
8149             Pedro Alves  <palves@redhat.com>
8150
8151         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8152         parameter.
8153         (fetch_inferior_event): Use SCOPE_EXIT.
8154
8155
8156 2019-01-23  Tom Tromey  <tom@tromey.com>
8157             Pedro Alves  <palves@redhat.com>
8158
8159         * infrun.c (disable_thread_events): Delete.
8160         (stop_all_threads): Use SCOPE_EXIT.
8161
8162 2019-01-23  Tom Tromey  <tom@tromey.com>
8163             Pedro Alves  <palves@redhat.com>
8164
8165         * symfile.c: Include forward-scope-exit.h.
8166         (clear_symtab_users_cleanup): Replace forward declaration with
8167         a FORWARD_SCOPE_EXIT.
8168         (syms_from_objfile_1): Use the forward_scope_exit and
8169         gdb::optional instead of cleanup_function.
8170         (reread_symbols): Use the forward_scope_exit instead of
8171         cleanup_function.
8172         (clear_symtab_users_cleanup): Remove function.
8173
8174 2019-01-23  Tom Tromey  <tom@tromey.com>
8175             Pedro Alves  <palves@redhat.com>
8176
8177         * linux-nat.c: Include scope-exit.h.
8178         (cleanup_target_stop): Remove.
8179         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8180         SCOPE_EXIT.
8181
8182 2019-01-23  Tom Tromey  <tom@tromey.com>
8183             Pedro Alves  <palves@redhat.com>
8184
8185         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8186         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8187
8188 2019-01-23  Tom Tromey  <tom@tromey.com>
8189             Andrew Burgess  <andrew.burgess@embecosm.com>
8190             Pedro Alves  <palves@redhat.com>
8191
8192         * infrun.c (fetch_inferior_event): Use scope_exit.
8193         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8194         * top.c (execute_command): Use scope_exit.
8195         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8196         * utils.c (do_bpstat_clear_actions_cleanup)
8197         (make_bpstat_clear_actions_cleanup): Remove.
8198
8199 2019-01-23  Tom Tromey  <tom@tromey.com>
8200             Pedro Alves  <palves@redhat.com>
8201
8202         * infrun.c: Include "common/scope-exit.h"
8203         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8204         (wait_for_inferior): Use SCOPE_EXIT.
8205         (fetch_inferior_event): Use scope_exit.
8206
8207 2019-01-23  Tom Tromey  <tom@tromey.com>
8208             Pedro Alves  <palves@redhat.com>
8209
8210         * breakpoint.c (create_breakpoint): Remove cleanup.
8211
8212 2019-01-23  Tom Tromey  <tom@tromey.com>
8213             Andrew Burgess  <andrew.burgess@embecosm.com>
8214             Pedro Alves  <palves@redhat.com>
8215
8216 2019-01-23  Pedro Alves  <palves@redhat.com>
8217
8218         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8219
8220 2019-01-23  Pedro Alves  <palves@redhat.com>
8221             Andrew Burgess  <andrew.burgess@embecosm.com>
8222
8223         * gdbthread.h: Include "common/forward-scope-exit.h".
8224         (scoped_finish_thread_state): Redefine custom class in terms of
8225         forward_scope_exit.
8226
8227 2019-01-23  Pedro Alves  <palves@redhat.com>
8228             Andrew Burgess  <andrew.burgess@embecosm.com>
8229
8230         * common/forward-scope-exit.h: New file.
8231
8232 2019-01-23  Pedro Alves  <palves@redhat.com>
8233             Andrew Burgess  <andrew.burgess@embecosm.com>
8234             Tom Tromey  <tom@tromey.com>
8235
8236         * common/scope-exit.h: New file.
8237
8238 2019-01-23  Pedro Alves  <palves@redhat.com>
8239
8240         * common/preprocessor.h (ESC): Rename to ...
8241         (ESC_PARENS): ... this.
8242         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8243         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8244
8245 2019-01-23  Tom Tromey  <tom@tromey.com>
8246
8247         * language.h (class scoped_switch_to_sym_language_if_auto):
8248         Initialize m_lang in both cases.
8249
8250 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
8251
8252         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8253         with XCNEW.
8254
8255 2019-01-22  Tom Tromey  <tom@tromey.com>
8256
8257         * corelow.c: Do not include sys/file.h.
8258
8259 2019-01-22  Tom Tromey  <tom@tromey.com>
8260
8261         * tui/tui-wingeneral.h: Include gdb_curses.h.
8262
8263 2019-01-22  Tom Tromey  <tom@tromey.com>
8264
8265         * source-cache.h (class source_cache) <get_source_lines,
8266         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
8267
8268 2019-01-22  Tom Tromey  <tom@tromey.com>
8269
8270         * remote-fileio.h (struct remote_target): Declare.
8271
8272 2019-01-22  Tom Tromey  <tom@tromey.com>
8273
8274         * python/py-arch.c: Do not include py-ref.h.
8275         * python/py-bpevent.c: Do not include py-ref.h.
8276         * python/py-cmd.c: Do not include py-ref.h.
8277         * python/py-continueevent.c: Do not include py-ref.h.
8278         * python/py-event.h: Do not include py-ref.h.
8279         * python/py-evtregistry.c: Do not include py-ref.h.
8280         * python/py-finishbreakpoint.c: Do not include py-ref.h.
8281         * python/py-frame.c: Do not include py-ref.h.
8282         * python/py-framefilter.c: Do not include py-ref.h.
8283         * python/py-function.c: Do not include py-ref.h.
8284         * python/py-infevents.c: Do not include py-ref.h.
8285         * python/py-linetable.c: Do not include py-ref.h.
8286         * python/py-objfile.c: Do not include py-ref.h.
8287         * python/py-param.c: Do not include py-ref.h.
8288         * python/py-prettyprint.c: Do not include py-ref.h.
8289         * python/py-progspace.c: Do not include py-ref.h.
8290         * python/py-symbol.c: Do not include py-ref.h.
8291         * python/py-symtab.c: Do not include py-ref.h.
8292         * python/py-type.c: Do not include py-ref.h.
8293         * python/py-unwind.c: Do not include py-ref.h.
8294         * python/py-utils.c: Do not include py-ref.h.
8295         * python/py-value.c: Do not include py-ref.h.
8296         * python/py-varobj.c: Do not include py-ref.h.
8297         * python/py-xmethods.c: Do not include py-ref.h.
8298         * python/python.c: Do not include py-ref.h.
8299         * varobj.c: Do not include py-ref.h.
8300
8301 2019-01-22  Tom Tromey  <tom@tromey.com>
8302
8303         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
8304         keyword for bcache.
8305
8306 2019-01-22  Tom Tromey  <tom@tromey.com>
8307
8308         * compile/compile-cplus-types.c: Remove a comment by #include.
8309
8310 2019-01-22  Tom Tromey  <tom@tromey.com>
8311
8312         * compile/gcc-c-plugin.h: Include compile-internal.h.
8313
8314 2019-01-22  Tom Tromey  <tom@tromey.com>
8315
8316         * stabsread.c (EXTERN): Do not define.
8317         (symnum, next_symbol_text_func, processing_gcc_compilation)
8318         (within_function, global_sym_chain, global_stabs)
8319         (previous_stab_code, this_object_header_files)
8320         (n_this_object_header_files)
8321         (n_allocated_this_object_header_files): Define.
8322         * stabsread.h (EXTERN): Never define.  Use "extern".
8323
8324 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8325
8326         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
8327         history_value.
8328
8329 2019-01-21  Tom Tromey  <tom@tromey.com>
8330
8331         * ui-out.c: Fix includes.
8332         * tui/tui-source.c: Fix includes.
8333         * target.c: Fix includes.
8334         * remote.c: Fix includes.
8335         * regcache.c: Fix includes.
8336         * python/py-block.c: Fix includes.
8337         * printcmd.c: Fix includes.
8338         * or1k-tdep.c: Fix includes.
8339         * mi/mi-main.c: Fix includes.
8340         * m32r-tdep.c: Fix includes.
8341         * csky-tdep.c: Fix includes.
8342         * compile/compile-cplus-types.c: Fix includes.
8343         * cli/cli-interp.c: Fix includes.
8344
8345 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
8346
8347         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8348         for padding.
8349
8350 2019-01-16  Tom Tromey  <tom@tromey.com>
8351
8352         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
8353         earlier.
8354         (struct objfile) <msymbols_range>: Move from top level.
8355         <msymbols>: New method.
8356         (class objfile_msymbols): Remove.
8357         * symtab.c (default_collect_symbol_completion_matches_break_on):
8358         Update.
8359         * symmisc.c (dump_msymbols): Update.
8360         * stabsread.c (scan_file_globals): Update.
8361         * objc-lang.c (info_selectors_command, info_classes_command)
8362         (find_methods): Update.
8363         * minsyms.c (find_solib_trampoline_target): Update.
8364         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
8365         * coffread.c (coff_symfile_read): Update.
8366         * ada-lang.c (ada_lookup_simple_minsym)
8367         (ada_collect_symbol_completion_matches): Update.
8368
8369 2019-01-16  Tom Tromey  <tom@tromey.com>
8370
8371         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
8372         type.  Remove no-argument constructor.
8373         <iterator::operator++>: Simplify.
8374         <begin>: Update.
8375         <end>: Use minimal_symbol_count.
8376
8377 2019-01-16  Tom Tromey  <tom@tromey.com>
8378
8379         * objfiles.h (struct objfile) <psymtabs>: New method.
8380         (class objfile_psymtabs): Remove.
8381         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
8382         typedef.
8383         <range>: New method.
8384         (require_partial_symbols): Change return type.
8385         * psymtab.c (require_partial_symbols)
8386         (psym_expand_symtabs_matching): Update.
8387         * mdebugread.c (parse_partial_symbols): Update.
8388         * dbxread.c (dbx_end_psymtab): Update.
8389
8390 2019-01-15  Tom Tromey  <tom@tromey.com>
8391
8392         * symtab.c (lookup_objfile_from_block)
8393         (lookup_symbol_in_objfile_symtabs)
8394         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
8395         (find_line_symtab, info_sources_command)
8396         (default_collect_symbol_completion_matches_break_on)
8397         (make_source_files_completion_list): Update.
8398         * symmisc.c (print_objfile_statistics, dump_objfile)
8399         (maintenance_print_symbols, maintenance_info_symtabs)
8400         (maintenance_check_symtabs, maintenance_info_line_tables):
8401         Update.
8402         * source.c (select_source_symtab)
8403         (forget_cached_source_info_for_objfile): Update.
8404         * objfiles.h (class objfile_compunits): Remove.
8405         (struct objfile) <compunits_range>: New typedef.
8406         (compunits): New method.
8407         * objfiles.c (objfile_relocate1): Update.
8408         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8409         * maint.c (count_symtabs_and_blocks): Update.
8410         * linespec.c (iterate_over_all_matching_symtabs): Update.
8411         * cp-support.c (add_symbol_overload_list_qualified): Update.
8412         * coffread.c (coff_symtab_read): Update.
8413         * ada-lang.c (add_nonlocal_symbols)
8414         (ada_collect_symbol_completion_matches)
8415         (ada_add_global_exceptions): Update.
8416
8417 2019-01-15  Tom Tromey  <tom@tromey.com>
8418
8419         * progspace.h (program_space) <objfiles_safe_range>: New
8420         typedef.
8421         <objfiles_safe>: New method.
8422         * objfiles.h (class all_objfiles_safe): Remove.
8423         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
8424         * jit.c (jit_inferior_exit_hook): Update.
8425
8426 2019-01-17  Tom Tromey  <tom@tromey.com>
8427
8428         * progspace.h (program_space) <objfiles_range>: New typedef.
8429         <objfiles>: New method.
8430         <objfiles_head>: Rename from objfiles.
8431         (object_files): Update.
8432         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
8433         * guile/scm-pretty-print.c
8434         (ppscm_find_pretty_printer_from_objfiles): Update.
8435         * guile/scm-objfile.c (gdbscm_objfiles): Update.
8436         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
8437         Update.
8438         * python/py-progspace.c (pspy_get_objfiles): Update.
8439         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8440         Update.
8441         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8442         (objfpy_lookup_objfile_by_build_id): Update.
8443         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8444         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8445         Update.
8446         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8447         (expand_symtab_containing_pc, lookup_objfile_from_block)
8448         (lookup_static_symbol, basic_lookup_transparent_type)
8449         (find_pc_sect_compunit_symtab, find_symbol_at_address)
8450         (find_line_symtab, info_sources_command)
8451         (default_collect_symbol_completion_matches_break_on)
8452         (make_source_files_completion_list, find_main_name): Update.
8453         * symmisc.c (print_symbol_bcache_statistics)
8454         (print_objfile_statistics, maintenance_print_symbols)
8455         (maintenance_print_msymbols, maintenance_print_objfiles)
8456         (maintenance_info_symtabs, maintenance_check_symtabs)
8457         (maintenance_expand_symtabs, maintenance_info_line_tables):
8458         Update.
8459         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
8460         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
8461         (map_overlay_command, unmap_overlay_command)
8462         (simple_overlay_update, expand_symtabs_matching)
8463         (map_symbol_filenames): Update.
8464         * symfile-debug.c (set_debug_symfile): Update.
8465         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
8466         Update.
8467         * source.c (select_source_symtab, forget_cached_source_info):
8468         Update.
8469         * solib.c (solib_read_symbols): Update.
8470         * solib-spu.c (append_ocl_sos): Update.
8471         * psymtab.c (maintenance_print_psymbols)
8472         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
8473         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
8474         * printcmd.c (info_symbol_command): Update.
8475         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
8476         Update.
8477         * objfiles.h (class all_objfiles): Remove.
8478         * objfiles.c (have_partial_symbols, have_full_symbols)
8479         (have_minimal_symbols, qsort_cmp, update_section_map)
8480         (shared_objfile_contains_address_p)
8481         (default_iterate_over_objfiles_in_search_order): Update.
8482         * objc-lang.c (info_selectors_command, info_classes_command)
8483         (find_methods): Update.
8484         * minsyms.c (find_solib_trampoline_target): Update.
8485         * maint.c (maintenance_info_sections)
8486         (maintenance_translate_address, count_symtabs_and_blocks):
8487         Update.
8488         * main.c (captured_main_1): Update.
8489         * linux-thread-db.c (try_thread_db_load_from_pdir)
8490         (has_libpthread): Update.
8491         * linespec.c (iterate_over_all_matching_symtabs)
8492         (search_minsyms_for_name): Update.
8493         * jit.c (jit_find_objf_with_entry_addr): Update.
8494         * hppa-tdep.c (find_unwind_entry)
8495         (hppa_lookup_stub_minimal_symbol): Update.
8496         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
8497         Update.
8498         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8499         (elf_gnu_ifunc_resolve_by_got): Update.
8500         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
8501         * dwarf-index-write.c (save_gdb_index_command): Update.
8502         * cp-support.c (add_symbol_overload_list_qualified): Update.
8503         * breakpoint.c (create_overlay_event_breakpoint)
8504         (create_longjmp_master_breakpoint)
8505         (create_std_terminate_master_breakpoint)
8506         (create_exception_master_breakpoint): Update.
8507         * blockframe.c (find_pc_partial_function): Update.
8508         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
8509         (ada_collect_symbol_completion_matches)
8510         (ada_add_global_exceptions): Update.
8511
8512 2019-01-17  Tom Tromey  <tom@tromey.com>
8513
8514         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
8515         declare VEC.
8516         (solib_target_parse_libraries): Change return type.
8517         (library_list_start_segment, library_list_start_section)
8518         (library_list_end_library, library_list_start_library); Update.
8519         (solib_target_free_library_list): Remove.
8520         (solib_target_parse_libraries): Remove cleanup.  Change return
8521         type.
8522         (solib_target_current_sos): Update.
8523
8524 2019-01-17  Tom Tromey  <tromey@bapiya>
8525
8526         * valprint.c: Replace "the the" with "the".
8527         * symtab.c: Replace "the the" with "the".
8528         * solib.c: Replace "the the" with "the".
8529         * solib-dsbt.c: Replace "the the" with "the".
8530         * linespec.c: Replace "the the" with "the".
8531         * dwarf2loc.h: Replace "the the" with "the".
8532         * amd64-windows-tdep.c: Replace "the the" with "the".
8533         * aarch64-tdep.c: Replace "the the" with "the".
8534
8535 2019-01-16  Keith Seitz  <keiths@redhat.com>
8536
8537         PR gdb/23773
8538         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
8539         <builder>: Rename to ..
8540         <m_builder>: ... this and make private.
8541         (dwarf2_cu::get_builder): New method.  Change all users of
8542         `builder' to use this method.
8543         (dwarf2_start_symtab): Move to ...
8544         (dwarf2_cu::start_symtab): ... here.  Update all callers
8545         (setup_type_unit_groups): Move to ...
8546         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
8547         callers.
8548         (dwarf2_cu::reset_builder): New method.
8549         (process_full_compunit, process_full_type_unit): Use
8550         dwarf2_cu::reset_builder.
8551         (follow_die_offset): Record the ancestor CU if it is different
8552         from the followed DIE's CU.
8553         (follow_die_sig_1): Likewise.
8554
8555 2019-01-15  Tom Tromey  <tom@tromey.com>
8556
8557         * remote.c (class remote_state) <buf>: Now a char_vector.
8558         <buf_size>: Remove.
8559         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
8560         parameter.
8561         (remote_target::getpkt_or_notif_sane_1)
8562         (remote_target::getpkt_sane)
8563         (remote_target::getpkt_or_notif_sane): Likewise.
8564         (class remote_target) <putpkt>: New overload.
8565         (remote_target::read_frame): Change type of "buf_p".  Remove
8566         sizeof_p parameter.
8567         (packet_ok): New overload.
8568         (packet_check_result): New overload.
8569         Update all uses.
8570
8571 2019-01-14  Tom Tromey  <tom@tromey.com>
8572
8573         * remote-notif.c (handle_notification, remote_notif_ack)
8574         (remote_notif_parse): Make "buf" const.
8575         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
8576         const.
8577         (remote_notif_parse, remote_notif_ack, handle_notification):
8578         Likewise.
8579         * remote.c (remote_notif_stop_parse): Make "buf" const.
8580         (remote_target::remote_parse_stop_reply): Make "buf" const.
8581         (remote_notif_stop_ack): Make "buf" const.
8582
8583 2019-01-14  Tom Tromey  <tom@tromey.com>
8584
8585         * remote.c (remote_console_output): Make parameter const.
8586
8587 2019-01-14  Tom Tromey  <tom@tromey.com>
8588
8589         * target-debug.h (target_debug_print_signals): Constify.
8590         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
8591         * procfs.c (procfs_target::pass_signals): Update.
8592         * linux-nat.c (linux_nat_target::pass_signals): Update.
8593         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
8594         * target-delegates.c: Rebuild.
8595         * remote.c (remote_target::program_signals): Update.
8596         (remote_target::pass_signals): Update.
8597         * target.c (target_pass_signals): Constify argument.
8598         (target_program_signals): Likewise.
8599         * target.h (struct target_ops) <pass_signals, program_signals>:
8600         Constify argument.
8601         (target_pass_signals, target_program_signals): Constify argument.
8602
8603 2019-01-14  Tom Tromey  <tom@tromey.com>
8604
8605         PR tui/28819:
8606         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
8607
8608 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
8609
8610         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
8611         field.
8612         * rs6000-tdep.c: Include reggroups.h.
8613         (IS_V_ALIAS_PSEUDOREG): Define.
8614         (rs6000_register_name): Return names for the "vX" aliases.
8615         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
8616         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
8617         aliases.  Call default_register_reggroup_p for all other
8618         pseudo-registers.
8619         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
8620         New functions.
8621         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
8622         Handle "vX" aliases.
8623         (v_alias_pseudo_register_collect): New function.
8624         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
8625         (rs6000_gdbarch_init): Initialize "vX" aliases as
8626         pseudo-registers.  Restore registration of
8627         rs6000_pseudo_register_reggroup_p with
8628         set_tdesc_pseudo_register_reggroup_p.
8629
8630 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
8631
8632         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
8633         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
8634         set_gdbarch_num_pseudo_regs.
8635
8636 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8637
8638         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
8639         Remove arg prefixname, add do_set and do_show.
8640         Add member functions set_list and show_list.
8641         * cli/cli-style.c (class cli_style_option): Update accordingly.
8642         (style_set_list): Move to file scope.
8643         (style_show_list): Likewise.
8644         (set_style): Call help_list.
8645         (show_style): Call cmd_show_list.
8646         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
8647         Update to use the new macro.
8648
8649 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
8650
8651         * ada-lang.c (_initialize_ada_language): Expand the help text
8652         for the "catch exception" command.
8653
8654 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8655
8656         * symtab.c (matching_obj_sections): Initialize obj,
8657         declare it closer to its usage.
8658
8659 2019-01-10  Tom Tromey  <tom@tromey.com>
8660
8661         * thread-iter.h (inf_threads_iterator): Use next_iterator.
8662         (basic_inf_threads_range): Remove.
8663         (inf_threads_range, inf_non_exited_threads_range)
8664         (safe_inf_threads_range): Use next_adapter.
8665
8666 2019-01-10  Keith Seitz  <keiths@redhat.com>
8667
8668         PR gdb/23712
8669         PR symtab/23010
8670         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
8671         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
8672
8673 2019-01-10  Keith Seitz  <keiths@redhat.com>
8674
8675         PR gdb/23712
8676         PR symtab/23010
8677         * dictionary.c (pending_to_vector): Remove.
8678         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8679         Remove _1 suffix, replacing functions of the same name.  Update
8680         all callers.
8681         (dict_create_hashed, dict_create_hashed_expandable)
8682         (dict_create_linear, dict_create_linear_expandable, dict_free)
8683         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
8684         Make functions static.
8685
8686 2019-01-10  Keith Seitz  <keiths@redhat.com>
8687
8688         PR gdb/23712
8689         PR symtab/23010
8690         * dictionary.h (struct dictionary): Replace declaration with
8691         multidictionary.
8692         (dict_create_hashed, dict_create_hashed_expandable)
8693         (dict_create_linear, dict_create_linear_expandable)
8694         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
8695         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
8696         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
8697         taking multidictionary argument.
8698         [ALL_DICT_SYMBOLS]: Update for multidictionary.
8699         * block.h (struct block) <dict>: Change to multidictionary
8700         and rename `multidict'.
8701         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
8702         symmisc.c: Update all dictionary references to multidictionary.
8703
8704 2019-01-10  Keith Seitz  <keiths@redhat.com>
8705
8706         PR gdb/23712
8707         PR symtab/23010
8708         * dictionary.c: Include unordered_map.
8709         (pending_to_vector): New function.
8710         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8711         Rewrite the non-"_1" functions to take vector instead
8712         of linked list.
8713         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
8714         "new" _1 versions of the same name.
8715         (multidictionary): Define.
8716         (std::hash<enum language): New definition.
8717         (collate_pending_symbols_by_language, mdict_create_hashed)
8718         (mdict_create_hashed_expandable, mdict_create_linear)
8719         (mdict_create_linear_expandable, mdict_free)
8720         (find_language_dictionary, create_new_language_dictionary)
8721         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
8722         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
8723         (mdict_size, mdict_empty): New functions.
8724         * dictionary.h (mdict_iterator): Define.
8725
8726 2019-01-10  Pedro Alves  <palves@redhat.com>
8727
8728         * breakpoint.c (read_uploaded_action)
8729         (create_tracepoint_from_upload): Adjust to use
8730         gdb::unique_xmalloc_ptr.
8731         * ctf.c (ctf_write_uploaded_tp):
8732         (SET_ARRAY_FIELD): Use emplace_back.
8733         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
8734         * tracefile-tfile.c (tfile_write_uploaded_tp):
8735         * tracepoint.c (parse_tracepoint_definition): Adjust to use
8736         gdb::unique_xmalloc_ptr.
8737         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
8738         at_string, cond_string, cmd_strings>: Replace char pointers
8739         with gdb::unique_xmalloc_ptr.
8740
8741 2019-01-10  Pedro Alves  <palves@redhat.com>
8742
8743         * solib-target.c (library_list_start_library): Don't xstrdup name.
8744
8745 2019-01-10  Pedro Alves  <palves@redhat.com>
8746
8747         * mdebugread.c (parse_partial_symbols): Use
8748         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
8749
8750 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8751
8752         * linux-fork.c (scoped_switch_fork_info)
8753         <~scoped_switch_fork_info>: Fix incorrect variable name.
8754
8755 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8756
8757         * linux-fork.c (scoped_switch_fork_info)
8758         <scoped_switch_fork_info>: Make explicit.
8759         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
8760
8761 2019-01-10  Tom Tromey  <tom@tromey.com>
8762
8763         * objfiles.h (objfile::reset_psymtabs): Update.
8764         * objfiles.c (objfile::objfile): Update.
8765         * psymtab.h (psymtab_storage::obstack): Update.
8766         (psymtab_storage::m_obstack): Use gdb::optional.
8767         (class psymtab_storage): Update comment.  Remove objfile
8768         parameter.
8769         * psymtab.c (psymtab_storage::psymtab_storage): Update.
8770
8771 2019-01-10  Tom Tromey  <tom@tromey.com>
8772
8773         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
8774         <free_psymtabs>: Now private.
8775         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
8776         (allocate_psymtab): Use new method.
8777
8778 2019-01-10  Tom Tromey  <tom@tromey.com>
8779
8780         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
8781         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
8782         * mdebugread.c (parse_partial_symbols): Use
8783         allocate_dependencies.
8784         * dwarf2read.c (dwarf2_create_include_psymtab): Use
8785         allocate_dependencies.
8786         (process_psymtab_comp_unit_reader)
8787         (build_type_psymtab_dependencies): Likewise.
8788         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
8789
8790 2019-01-10  Tom Tromey  <tom@tromey.com>
8791
8792         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
8793         PSYMBOL_SET_LANGUAGE.
8794         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
8795
8796 2019-01-10  Tom Tromey  <tom@tromey.com>
8797
8798         * psymtab.h (psymtab_storage::obstack): New method.
8799         <m_obstack>: Rename from obstack; now private.
8800         * psymtab.c (psymtab_storage): Update.
8801         * dwarf2read.c (create_addrmap_from_index)
8802         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
8803         Update.
8804
8805 2019-01-10  Tom Tromey  <tom@tromey.com>
8806
8807         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
8808         * objfiles.h (objfile::reset_psymtabs): New method.
8809
8810 2019-01-10  Tom Tromey  <tom@tromey.com>
8811
8812         * symmisc.c (print_symbol_bcache_statistics): Update.
8813         (print_objfile_statistics): Update.
8814         * symfile.c (reread_symbols): Update.
8815         * psymtab.h (class psymtab_storage): New.
8816         * psymtab.c (psymtab_storage): New constructor.
8817         (~psymtab_storage): New destructor.
8818         (require_partial_symbols): Update.
8819         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
8820         (find_pc_sect_psymtab, find_pc_sect_psymbol)
8821         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
8822         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
8823         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
8824         (start_psymtab_common, end_psymtab_common)
8825         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
8826         (allocate_psymtab): Update.
8827         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
8828         Update.
8829         (dump_psymtab_addrmap, maintenance_print_psymbols)
8830         (maintenance_check_psymtabs): Update.
8831         (class objfile_psymtabs): Move to objfiles.h.
8832         * psympriv.h (discard_psymtab): Now inline.
8833         (psymtab_discarder::psymtab_discarder): Update.
8834         (psymtab_discarder::~psymtab_discarder): Update.
8835         (ALL_OBJFILE_PSYMTABS): Rewrite.
8836         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
8837         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
8838         Remove fields.
8839         <partial_symtabs>: New field.
8840         (class objfile_psymtabs): Move from psymtab.h.  Update.
8841         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
8842         psymbol_cache.
8843         (objfile::~objfile): Don't destroy psymbol_cache.
8844         * mdebugread.c (parse_partial_symbols): Update.
8845         * dwarf2read.c (create_addrmap_from_index)
8846         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
8847         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
8848         (add_partial_subprogram, dwarf2_ranges_read): Update.
8849         * dwarf-index-write.c (write_address_map)
8850         (write_one_signatured_type, recursively_write_psymbols)
8851         (class debug_names, class debug_names, write_psymtabs_to_index):
8852         Update.
8853
8854 2019-01-10  Tom Tromey  <tom@tromey.com>
8855
8856         * symtab.h (SYMBOL_SET_NAMES): Update.
8857         (symbol_set_names): Update.
8858         (MSYMBOL_SET_NAMES): Update.
8859         * symtab.c (symbol_set_names): Change argument to be an
8860         objfile_per_bfd_storage.
8861         * psymtab.c (add_psymbol_to_bcache): Update.
8862         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
8863
8864 2019-01-10  Tom Tromey  <tom@tromey.com>
8865
8866         * symtab.c (create_demangled_names_hash): Change argument to be an
8867         objfile_per_bfd_storage.
8868         (symbol_set_names): Update.
8869
8870 2019-01-10  Tom Tromey  <tom@tromey.com>
8871
8872         * xcoffread.c (xcoff_initial_scan): Unconditionally call
8873         init_psymbol_list.
8874         * psymtab.c (init_psymbol_list): Do nothing if already called.
8875         * psympriv.h (init_psymbol_list): Add comment.
8876         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
8877         init_psymbol_list.
8878         * dbxread.c (dbx_symfile_read): Unconditionally call
8879         init_psymbol_list.
8880
8881 2019-01-10  Tom Tromey  <tom@tromey.com>
8882
8883         * xcoffread.c (scan_xcoff_symtab): Update.
8884         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
8885         "where".
8886         * mdebugread.c (parse_partial_symbols)
8887         (handle_psymbol_enumerators): Update.
8888         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
8889         * dbxread.c (read_dbx_symtab): Update.
8890         * psympriv.h (psymbol_placement): New enum.
8891         (add_psymbol_to_list): Update.
8892
8893 2019-01-10  Tom Tromey  <tom@tromey.com>
8894
8895         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
8896         static_psymbols parameters.
8897         (scan_xcoff_symtab): Update.
8898         * psymtab.c (start_psymtab_common): Remove global_psymbols and
8899         static_psymbols parameters.
8900         * psympriv.h (start_psymtab_common): Update.
8901         * mdebugread.c (parse_partial_symbols): Update.
8902         * dwarf2read.c (create_partial_symtab): Update.
8903         * dbxread.c (read_dbx_symtab): Update.
8904         (start_psymtab): Remove global_psymbols and static_psymbols
8905         parameters.
8906
8907 2019-01-10  Tom Tromey  <tom@tromey.com>
8908
8909         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
8910         * psymtab.c (allocate_psymtab): Add comment.
8911         * psympriv.h (allocate_psymtab): Add comment.
8912         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
8913         initializations.
8914         * dbxread.c (dbx_end_psymtab): Remove some initializations.
8915
8916 2019-01-10  Tom Tromey  <tom@tromey.com>
8917
8918         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8919         Don't declare.
8920         * mipsread.c: Include mdebugread.h.
8921         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8922         Declare.
8923         * elfread.c: Include mdebugread.h.
8924
8925 2019-01-09  Tom Tromey  <tom@tromey.com>
8926
8927         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
8928         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
8929         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
8930         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
8931         (psym_lookup_symbol, psym_find_last_source_symtab)
8932         (psym_forget_cached_source_info, psym_print_stats)
8933         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
8934         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
8935         (psym_map_matching_symbols, psym_expand_symtabs_matching)
8936         (psym_find_compunit_symtab_by_address)
8937         (maintenance_print_psymbols, maintenance_info_psymtabs)
8938         (maintenance_check_psymtabs): Use ranged for.
8939         * psymtab.h (class objfile_psymtabs): New.
8940         (require_partial_symbols): Return objfile_psymtabs.
8941         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
8942
8943 2019-01-09  Tom Tromey  <tom@tromey.com>
8944
8945         * symfile.c (overlay_invalidate_all, find_pc_overlay)
8946         (find_pc_mapped_section, list_overlays_command)
8947         (map_overlay_command, unmap_overlay_command)
8948         (simple_overlay_update): Use all_objfiles.
8949         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
8950         * printcmd.c (info_symbol_command): Use all_objfiles.
8951         * objfiles.h (ALL_OBJSECTIONS): Remove.
8952         * maint.c (maintenance_translate_address): Use all_objfiles.
8953         * gcore.c (gcore_create_callback): Use all_objfiles.
8954         (objfile_find_memory_regions): Likewise.
8955
8956 2019-01-09  Tom Tromey  <tom@tromey.com>
8957
8958         * symtab.c (find_line_symtab, info_sources_command)
8959         (make_source_files_completion_list): Use objfile_compunits.
8960         * source.c (select_source_symtab): Use objfile_compunits.
8961         * objfiles.h (struct objfile): Update comment.
8962         (ALL_OBJFILES): Remove.
8963         (ALL_FILETABS): Remove.
8964         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
8965         objfile_compunits.
8966
8967 2019-01-09  Tom Tromey  <tom@tromey.com>
8968
8969         * symmisc.c (print_objfile_statistics, dump_objfile)
8970         (maintenance_print_symbols): Use compunit_filetabs.
8971         * source.c (forget_cached_source_info_for_objfile): Use
8972         compunit_filetabs.
8973         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
8974         (ALL_FILETABS): Use compunit_filetabs.
8975         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
8976         * coffread.c (coff_symtab_read): Use compunit_filetabs.
8977
8978 2019-01-09  Tom Tromey  <tom@tromey.com>
8979
8980         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
8981         (compunit_filetabs): New.
8982         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
8983         compunit_filetabs.
8984         (info_sources_command, make_source_files_completion_list): Remove
8985         declaration.
8986         * symmisc.c (print_objfile_statistics, dump_objfile)
8987         (maintenance_print_symbols): Remove declaration.
8988         (maintenance_info_symtabs): Use compunit_filetabs.
8989         (maintenance_info_line_tables): Likewise.
8990         * source.c (select_source_symtab): Change local variable name.
8991         (forget_cached_source_info_for_objfile): Remove declaration.
8992         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
8993         * objfiles.c (objfile_relocate1): Remove declaration.
8994         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8995         declaration.
8996         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
8997         * coffread.c (coff_symtab_read): Remove declaration.
8998         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
8999         compunit_filetabs.
9000
9001 2019-01-09  Tom Tromey  <tom@tromey.com>
9002
9003         * symtab.c (lookup_objfile_from_block)
9004         (find_pc_sect_compunit_symtab, search_symbols)
9005         (default_collect_symbol_completion_matches_break_on): Use
9006         objfile_compunits.
9007         * objfiles.h (ALL_COMPUNITS): Remove.
9008         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9009         * cp-support.c (add_symbol_overload_list_qualified): Use
9010         objfile_compunits.
9011         * ada-lang.c (ada_collect_symbol_completion_matches)
9012         (ada_add_global_exceptions): Use objfile_compunits.
9013
9014 2019-01-09  Tom Tromey  <tom@tromey.com>
9015
9016         * source.c (select_source_symtab)
9017         (forget_cached_source_info_for_objfile): Remove declaration.
9018         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9019         declaration.
9020         * maint.c (count_symtabs_and_blocks): Remove declaration.
9021         * cp-support.c (add_symbol_overload_list_qualified): Remove
9022         declaration.
9023         * coffread.c (coff_symtab_read): Remove declaration.
9024         * symtab.c (lookup_symbol_in_objfile_symtabs)
9025         (basic_lookup_transparent_type_1): Use objfile_compunits.
9026         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9027         (info_sources_command, search_symbols)
9028         (default_collect_symbol_completion_matches_break_on)
9029         (make_source_files_completion_list): Remove declaration.
9030         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9031         (ada_collect_symbol_completion_matches)
9032         (ada_add_global_exceptions): Remove declaration.
9033         * linespec.c (iterate_over_all_matching_symtabs): Use
9034         objfile_compunits.
9035         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9036         (class objfile_compunits): New.
9037         (ALL_COMPUNITS): Use objfile_compunits.
9038         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9039         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9040         objfile_compunits.
9041         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9042
9043 2019-01-09  Tom Tromey  <tom@tromey.com>
9044
9045         * symtab.c (search_symbols)
9046         (default_collect_symbol_completion_matches_break_on): Use
9047         objfile_msymbols.
9048         * ada-lang.c (ada_lookup_simple_minsym)
9049         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9050         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9051         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9052         objfile_msymbols.
9053         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9054         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9055         * objc-lang.c (find_methods): Use objfile_msymbols.
9056         (info_selectors_command, info_classes_command): Likewise.
9057         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9058         * objfiles.h (class objfile_msymbols): New.
9059         (ALL_OBJFILE_MSYMBOLS): Remove.
9060         (ALL_MSYMBOLS): Remove.
9061
9062 2019-01-09  Tom Tromey  <tom@tromey.com>
9063
9064         * common/next-iterator.h (next_adapter): Add Iterator template
9065         parameter.
9066         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9067         (class all_objfiles_safe): New.
9068         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9069         * objfiles.c (put_objfile_before): Update comment.
9070         (add_separate_debug_objfile): Likewise.
9071         (free_all_objfiles): Use all_objfiles_safe.
9072         (objfile_purge_solibs): Likewise.
9073
9074 2019-01-09  Tom Tromey  <tom@tromey.com>
9075
9076         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9077         (expand_symtab_containing_pc, lookup_static_symbol)
9078         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9079         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9080         all_objfiles.
9081         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9082         * breakpoint.c (create_overlay_event_breakpoint)
9083         (create_longjmp_master_breakpoint)
9084         (create_std_terminate_master_breakpoint)
9085         (create_exception_master_breakpoint): Use all_objfiles.
9086         * linux-thread-db.c (try_thread_db_load_from_pdir)
9087         (has_libpthread): Use all_objfiles.
9088         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9089         * linespec.c (iterate_over_all_matching_symtabs)
9090         (search_minsyms_for_name): Use all_objfiles.
9091         * maint.c (maintenance_info_sections): Use all_objfiles.
9092         * main.c (captured_main_1): Use all_objfiles.
9093         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9094         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9095         * guile/scm-pretty-print.c
9096         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9097         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9098         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9099         (maintenance_print_msymbols): Use all_objfiles.
9100         * source.c (select_source_symtab): Use all_objfiles.
9101         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9102         * symfile.c (remove_symbol_file_command)
9103         (expand_symtabs_matching, map_symbol_filenames): Use
9104         all_objfiles.
9105         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9106         all_objfiles.
9107         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9108         * objc-lang.c (find_methods): Use all_objfiles.
9109         * objfiles.c (have_partial_symbols, have_full_symbols)
9110         (have_minimal_symbols, qsort_cmp)
9111         (default_iterate_over_objfiles_in_search_order): Use
9112         all_objfiles.
9113         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9114         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9115         (maintenance_check_psymtabs): Use all_objfiles.
9116         (ALL_PSYMTABS): Remove.
9117         * compile/compile-object-run.c (do_module_cleanup): Use
9118         all_objfiles.
9119         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9120         * cp-support.c (add_symbol_overload_list_qualified): Use
9121         all_objfiles.
9122         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9123         Use all_objfiles.
9124         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9125         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9126         all_objfiles.
9127         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9128         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9129         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9130         Uses all_objfiles.
9131         * solib.c (solib_read_symbols): Use all_objfiles
9132
9133 2019-01-09  Tom Tromey  <tom@tromey.com>
9134
9135         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9136         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9137         all_objfiles.
9138         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9139         * symmisc.c (print_symbol_bcache_statistics)
9140         (print_objfile_statistics, maintenance_print_objfiles)
9141         (maintenance_info_symtabs, maintenance_check_symtabs)
9142         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9143         all_objfiles.
9144         * source.c (forget_cached_source_info): Use all_objfiles.
9145         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9146         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9147         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9148         * objfiles.c (update_section_map): Use all_objfiles.
9149         (shared_objfile_contains_address_p): Likewise.
9150         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9151         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9152
9153 2019-01-09  Tom Tromey  <tom@tromey.com>
9154
9155         * common/next-iterator.h: New file.
9156         * objfiles.h (class all_objfiles): New.
9157         (struct objfile_iterator): New.
9158
9159 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9160
9161         * NEWS: Move the description of the changed "frame", "select-frame",
9162          and "info frame" commands to the Changed commands section.
9163
9164 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9165
9166         * gdbtypes.c (check_stub_method_group): Remove handling of old
9167         mangling schemes.
9168         * linespec.c (find_methods): Likewise.
9169         * stabsread.c (read_member_functions): Likewise.
9170         * valops.c (search_struct_method): Likewise.
9171         (value_struct_elt_for_reference): Likewise.
9172         * NEWS: Mention this change.
9173
9174 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9175
9176         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9177         print_source_lines.
9178         * source.c (print_source_lines_base): Update line number check.
9179         (print_source_lines): New function.
9180         (source_lines_range::source_lines_range): New function.
9181         * source.h (class source_lines_range): New class.
9182         (print_source_lines): New declaration.
9183
9184 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9185
9186         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9187
9188 2019-01-08  Tom Tromey  <tom@tromey.com>
9189             Simon Marchi  <simon.marchi@ericsson.com>
9190
9191         PR gdb/24060
9192         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9193         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9194         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9195         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9196         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9197         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9198
9199 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9200
9201         * source.c (select_source_symtab): Move header comment to
9202         declaration in source.h.
9203         (forget_cached_source_info_for_objfile): Likewise.
9204         (forget_cached_source_info): Likewise.
9205         (identify_source_line): Likewise.
9206         * source.h (identify_source_line): Move declaration from symtab.h
9207         and add comment from source.c
9208         (print_source_lines): Likewise.
9209         (forget_cached_source_info_for_objfile): Likewise.
9210         (forget_cached_source_info): Likewise.
9211         (select_source_symtab): Likewise.
9212         (enum print_source_lines_flag): Move definition from symtab.h.
9213         * symtab.h (identify_source_line): Move declaration to source.h.
9214         (print_source_lines): Likewise.
9215         (forget_cached_source_info_for_objfile): Likewise.
9216         (forget_cached_source_info): Likewise.
9217         (select_source_symtab): Likewise.
9218         (enum print_source_lines_flag): Move definition to source.h.
9219         * tui/tui-hooks.c: Add 'source.h' include.
9220
9221 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9222
9223         * source.c (print_source_lines_base): Handle requests to print
9224         reverse line number sequences, and guard against empty lines
9225         string.
9226
9227 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9228
9229         * source.c (print_source_lines_base): Fix skip of '\r' if next
9230         character is '\n'.
9231
9232 2019-01-06  Tom Tromey  <tom@tromey.com>
9233
9234         * c-exp.y (struct c_parse_state) <macro_original_text,
9235         expansion_obstack>: New member.
9236         (macro_original_text, expansion_obstack): Remove globals.
9237         (scan_macro_expansion, scanning_macro_expansion)
9238         (finished_macro_expansion): Update.
9239         (scan_macro_cleanup): Remove.
9240         (yylex, c_parse): Update.
9241
9242 2019-01-06  Tom Tromey  <tom@tromey.com>
9243
9244         * c-exp.y (struct c_parse_state) <strings>: New member.
9245         (operator_stoken): Update.
9246
9247 2019-01-06  Tom Tromey  <tom@tromey.com>
9248
9249         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9250         (union type_stack_elt) <typelist_val>: Now a pointer to
9251         std::vector.
9252         (type_stack_cleanup): Don't declare.
9253         (push_typelist): Update.
9254         * parse.c (pop_typelist): Return a std::vector.
9255         (push_typelist): Take a std::vector.
9256         (follow_types): Update.  Do not free args.
9257         (type_stack_cleanup): Remove.
9258         * c-exp.y (struct c_parse_state): New.
9259         (cpstate): New global.
9260         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
9261         (nonempty_typelist): Update.
9262         (func_mod): Create a new vector.
9263         (c_parse): Create a c_parse_state.
9264         (check_parameter_typelist): Do not delete params.
9265         (function_method): Update.  Do not delete type_list.
9266
9267 2019-01-06  Tom Tromey  <tom@tromey.com>
9268
9269         PR gdb/28155:
9270         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
9271         check_typedef.
9272         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
9273         (print_return_value): Likewise.
9274
9275 2019-01-05  Tom Tromey  <tom@tromey.com>
9276
9277         * contrib/cleanup_check.py: Remove.
9278         * contrib/gcc-with-excheck: Remove.
9279         * contrib/exsummary.py: Remove.
9280         * contrib/excheck.py: Remove.
9281
9282 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
9283
9284         * thread.c (delete_thread_1): Add gdb_assert that THR is not
9285         NULL. Initialize tpprev to NULL instead of assigning it
9286         to NULL on the next statement.
9287         * windows-nat.c (windows_delete_thread): Remove check for
9288         main_thread_id before printing thread exit notifications.
9289         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
9290         Remove thread ID check against main_thread_id.
9291         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
9292         windows_delete_thread.
9293         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
9294
9295 2019-01-04  Tom Tromey  <tom@tromey.com>
9296
9297         * compile/compile.c (_initialize_compile): Use upper case for
9298         metasyntactic variables.
9299         * symmisc.c (_initialize_symmisc): Use upper case for
9300         metasyntactic variables.
9301         * psymtab.c (_initialize_psymtab): Use upper case for
9302         metasyntactic variables.
9303         * demangle.c (demangle_command): Use upper case for metasyntactic
9304         variables.
9305         (_initialize_demangler): Likewise.
9306         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
9307         variables.
9308
9309 2019-01-03  Tom Tromey  <tom@tromey.com>
9310
9311         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
9312
9313 2019-01-03  Tom Tromey  <tom@tromey.com>
9314
9315         * python/py-symtab.c (salpy_str): Update.
9316         (struct salpy_sal_object) <symtab>: Now a PyObject.
9317         (salpy_dealloc): Update.
9318         (del_objfile_sal): Use gdbpy_ref.
9319
9320 2019-01-03  Tom Tromey  <tom@tromey.com>
9321
9322         * python/py-type.c (convert_field): Use new_reference.  Return
9323         gdbpy_ref.
9324         (make_fielditem): Return gdbpy_ref.
9325         (typy_fields): Update.
9326         (typy_getitem): Update.
9327         (field_name): Return gdbpy_ref.  Use new_reference.
9328         (typy_iterator_iternext): Update.
9329
9330 2019-01-03  Tom Tromey  <tom@tromey.com>
9331
9332         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
9333
9334 2019-01-03  Tom Tromey  <tom@tromey.com>
9335
9336         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
9337         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
9338         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
9339         (pspy_set_frame_filters, pspy_set_frame_unwinders)
9340         (pspy_set_type_printers): Likewise.
9341         * python/py-function.c (fnpy_init): Use gdbpy_ref.
9342         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
9343         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
9344         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
9345         (objfpy_set_type_printers): Likewise.
9346
9347 2019-01-03  Tom Tromey  <tom@tromey.com>
9348
9349         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
9350         (gdbpy_print_stack): Use gdbpy_err_fetch.
9351         * python/python-internal.h (class gdbpy_err_fetch): New class.
9352         (class gdbpy_enter) <m_error_type, m_error_value,
9353         m_error_traceback>: Remove.
9354         <m_error>: New member.
9355         (gdbpy_exception_to_string): Don't declare.
9356         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
9357         * python/py-value.c (convert_value_from_python): Use
9358         gdbpy_err_fetch.
9359         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
9360         gdbpy_exception_to_string.
9361         (gdbpy_handle_exception): Use gdbpy_err_fetch.
9362         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
9363         gdbpy_err_fetch.
9364
9365 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9366
9367         * linux-nat.c (delete_lwp_cleanup): Delete.
9368         (struct lwp_deleter): New struct.
9369         (lwp_info_up): New typedef.
9370         (linux_nat_target::follow_fork): Delete cleanup, and make use of
9371         lwp_info_up.
9372
9373 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9374
9375         * linux-fork.c (class scoped_switch_fork_info): New class.
9376         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
9377
9378 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9379
9380         * valops.c (find_overload_match): Remove use of null_cleanup, and
9381         calls to do_cleanups.
9382
9383 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9384
9385         * compile/compile-cplus-types.c
9386         (compile_cplus_instance::decl_name): Handle changes to
9387         cp_func_name.
9388         * cp-support.c (cp_func_name): Update header comment, update
9389         return type.
9390         * cp-support.h (cp_func_name): Update return type in declaration.
9391         * valops.c (find_overload_match): Move temp_func local to top
9392         level of function and change its type.  Use temp_func to hold and
9393         delete temporary string obtained from cp_func_name.
9394
9395 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9396
9397         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
9398         gdb::char_vector, remove cleanup, and update uses of `msg`.
9399
9400 2019-01-03  Jim Wilson  <jimw@sifive.com>
9401
9402         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
9403
9404 2019-01-02  Tom Tromey  <tom@tromey.com>
9405
9406         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
9407         (tdesc_parse_xml): Remove cleanups.
9408         * target-descriptions.h (make_cleanup_free_target_description):
9409         Don't declare.
9410         (target_desc_deleter): New struct.
9411         (target_desc_up): New typedef.
9412         * target-descriptions.c (target_desc_deleter::operator()): Rename
9413         from free_target_description.
9414         (make_cleanup_free_target_description): Remove.
9415
9416 2019-01-02  Tom Tromey  <tom@tromey.com>
9417
9418         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
9419         constructor, destructor.
9420         (linespec_parser): Remove typedef.
9421         (~linespec_parser): Rename from linespec_parser_delete.
9422         (linespec_lex_to_end, linespec_complete_label)
9423         (linespec_complete): Update.
9424         (decode_line_full): Remove cleanups.
9425         (decode_line_1): Update.
9426
9427 2019-01-02  Tom Tromey  <tom@tromey.com>
9428
9429         * python/python-internal.h (inferior_to_inferior_object): Change
9430         return type.
9431         * python/py-exitedevent.c (create_exited_event_object): Update.
9432         * python/py-inferior.c (inferior_to_inferior_object): Return
9433         gdbpy_ref.
9434         (python_new_inferior, python_inferior_deleted)
9435         (thread_to_thread_object, delete_thread_object)
9436         (build_inferior_list, gdbpy_selected_inferior): Update.
9437         * python/py-infthread.c (create_thread_object): Update.  Also fail
9438         if inferior_to_inferior_object fails.
9439
9440 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
9441
9442         * inferior.h (class inferior) <displaced_step_state>: New field.
9443         * infrun.h (struct displaced_step_state): Move here from
9444         infrun.c.  Initialize fields, add constructor.
9445         <inf>: Remove field.
9446         <reset>: New method.
9447         * infrun.c (struct displaced_step_inferior_state): Move to
9448         infrun.h.
9449         (displaced_step_inferior_states): Remove.
9450         (get_displaced_stepping_state): Adust.
9451         (displaced_step_in_progress_any_inferior): Adjust.
9452         (displaced_step_in_progress_thread): Adjust.
9453         (displaced_step_in_progress): Adjust.
9454         (add_displaced_stepping_state): Remove.
9455         (get_displaced_step_closure_by_addr): Adjust.
9456         (remove_displaced_stepping_state): Remove.
9457         (infrun_inferior_exit): Call displaced_step_state.reset.
9458         (use_displaced_stepping): Don't check for NULL.
9459         (displaced_step_prepare_throw): Call
9460         get_displaced_stepping_state.
9461         (displaced_step_fixup): Don't check for NULL.
9462         (prepare_for_detach): Don't check for NULL.
9463
9464 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9465
9466         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
9467          in case of call that did not complete.
9468
9469 2019-01-02  Andrey Utkin  <autkin@undo.io>
9470
9471         * symfile.c (find_separate_debug_file): Fix search of debug files for
9472         remote debuggee.
9473
9474 2019-01-02  Tom Tromey  <tom@tromey.com>
9475
9476         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
9477         indentation.
9478         * python/py-frame.c (frapy_older): Remove cast.
9479         (frapy_newer): Likewise.
9480         * python/py-breakpoint.c (local_setattro): Remove cast.
9481         * python/py-arch.c (archpy_name): Remove local variable.
9482         * python/py-type.c (gdbpy_lookup_type): Remove cast.
9483
9484 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
9485
9486         * unittests/basic_string_view/element_access/char/empty.cc:
9487         Fix year range in copyright header.
9488
9489 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9490
9491         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
9492         Delete.
9493         <operator==>: Update with for removed field.
9494         <hash>: Likewise.
9495         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
9496         <isa_features>: ...this.
9497         <abi_features>: New field.
9498         (riscv_isa_flen): Update comment.
9499         (riscv_abi_xlen): New declaration.
9500         (riscv_abi_flen): New declaration.
9501         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
9502         isa_features.
9503         (riscv_abi_xlen): New function.
9504         (riscv_isa_flen): Update to get answer from isa_features.
9505         (riscv_abi_flen): New function.
9506         (riscv_has_fp_abi): Update to get answer from abi_features.
9507         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
9508         xlen and flen.
9509         (riscv_call_info) <xlen, flen>: Update comment.
9510         (riscv_call_arg_struct): Remove invalid assertions
9511         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
9512         is removed.
9513         (riscv_gdbarch_init): Gather isa features and abi features
9514         separately, ensure both match on the gdbarch when reusing an old
9515         gdbarch.  Relax an error check to allow 32-bit abi float to run on
9516         a target with 64-bit float hardware.
9517
9518 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9519
9520         * source.c (search_command_helper): Stop reverse search
9521         when line 1 has been searched.
9522
9523 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9524
9525         * record-full.c (record_full_base_target::close): Rewrite
9526         record_full_core_buf_list free logic.
9527
9528 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9529
9530         * break-catch-syscall.c (print_one_catch_syscall): xfree
9531         the last text.
9532
9533 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9534
9535         * top.c (print_gdb_version): Update Copyright year in version
9536         message.
9537
9538 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9539
9540         Update copyright year range in all GDB files.
9541
9542 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
9543
9544         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
9545
9546 For older changes see ChangeLog-2018.
9547 \f
9548 Local Variables:
9549 mode: change-log
9550 left-margin: 8
9551 fill-column: 74
9552 version-control: never
9553 coding: utf-8
9554 End:
9555