gdb/ChangeLog

   1 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
   2             Pedro Alves  <palves@redhat.com>
   3
   4         * top.c (quit_force): Call 'finalize_values'.
   5         * value.c (finalize_values): New function.
   6         * value.h (finalize_values): Declare.
   7
   8 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
   9
  10         * NEWS: Announce $_gdb_major and $_gdb_minor.
  11
  12         * top.c (init_gdb_version_vars): New function.
  13         (gdb_init): Call init_gdb_version_vars.
  14
  15 2019-03-29  Tom Tromey  <tromey@adacore.com>
  16
  17         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
  18         help text.  Remove dead code.
  19
  20 2019-03-29  Keith Seitz  <keiths@redhat.com>
  21
  22         From Siddhesh Poyarekar:
  23         * f-lang.h (f77_get_upperbound): Return LONGEST.
  24         (f77_get_lowerbound): Likewise.
  25         * f-typeprint.c (f_type_print_varspec_suffix): Expand
  26         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
  27         print them.
  28         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
  29         plongest to format print it.
  30         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
  31         (f77_get_upperbound): Likewise.
  32         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
  33         LOWER_BOUND to LONGEST.
  34         (f77_create_arrayprint_offset_tbl): Likewise.
  35
  36 2019-03-29  Keith Seitz  <keiths@redhat.com>
  37
  38         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
  39         %s/pulongest for TYPE_LENGTH instead of %d in format
  40         strings.
  41         * ada-typerint.c (ada_print_type): Likewise.
  42         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
  43         * compile/compile-c-support.c (generate_register_struct): Likewise.
  44         * gdbtypes.c (recursive_dump_type): Likewise.
  45         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
  46         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
  47         instead of %d in format strings.
  48         * riscv-tdep.c (riscv_type_alignment): Cast second argument
  49         to std::min to ULONGEST.
  50         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
  51         instead of %d in format strings.
  52         * tracepoint.c (info_scope_command): Likewise.
  53         * typeprint.c (print_offset_data::update)
  54         (print_offset_data::finish): Likewise.
  55         * xtensa-tdep.c (xtensa_store_return_value)
  56         (xtensa_push_dummy_call): Likewise.
  57
  58 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
  59
  60         * windows-nat.c (display_selector): Fixed format specifications
  61         for 64-bit Cygwin.
  62
  63 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  64
  65         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
  66
  67 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
  68
  69         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
  70         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
  71         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
  72         (nios2_linux_init_abi): Install it.
  73
  74 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
  75
  76         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
  77
  78 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
  79
  80         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
  81
  82 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  83             Tom Tromey  <tromey@adacore.com>
  84
  85         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
  86
  87 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
  88
  89         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
  90         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
  91         method to compute the bounds of range types. Also print "[evaluated]"
  92         if the bounds' values come from a dynamic evaluation.
  93
  94 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
  95
  96         * cp-valprint.c (cp_print_value_fields): Don't print trailing
  97         whitespace when pretty printing is on.
  98
  99 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
 100
 101         * ppc-linux-nat.c: Add include.
 102
 103 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
 104
 105         * NEWS: Mention AArch64 Pointer Authentication.
 106
 107 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
 108
 109         * arm-linux-nat.c: Add include.
 110
 111 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
 112
 113         * source-cache.c (source_cache::get_source_lines): Re-read
 114         fullname after calling open_source_file.
 115
 116 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
 117
 118         * NEWS: Mention TLS support for FreeBSD.
 119
 120 2019-03-25  Tom Tromey  <tromey@adacore.com>
 121
 122         * minsyms.c (BUNCH_SIZE): Update comment.
 123         (~minimal_symbol_reader): Remove old comment.
 124         (compact_minimal_symbols): Update comment.
 125         (minimal_symbol_reader::install): Remove old comment.  Update
 126         other comments.
 127
 128 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
 129
 130         * s390-linux-nat.c: Add include.
 131
 132 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
 133
 134         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 135         Call linux_get_hwcap.
 136         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
 137         Likewise.
 138         (aarch64_linux_get_hwcap): Remove function.
 139         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
 140         declaration.
 141         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
 142         linux_get_hwcap.
 143         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 144         * linux-tdep.c (linux_get_hwcap): Add function.
 145         (linux_get_hwcap2): Likewise.
 146         * linux-tdep.h (linux_get_hwcap): Add declaration.
 147         (linux_get_hwcap2): Likewise.
 148         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
 149         (ppc_linux_get_hwcap2): Likewise.
 150         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
 151         linux_get_hwcap.
 152         (ppc_linux_nat_target::insert_watchpoint): Likewise.
 153         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
 154         (ppc_linux_nat_target::read_description): Likewise.
 155         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
 156         * s390-linux-nat.c: Likewise.
 157         * s390-linux-tdep.c (s390_core_read_description): Likewise.
 158
 159 2019-03-24  Tom Tromey  <tom@tromey.com>
 160
 161         * ada-lang.c (standard_lookup): Simplify initialization.
 162         (ada_lookup_symbol_nonlocal): Simplify return.
 163         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
 164         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
 165         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
 166         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
 167         initialization.
 168         * solib.c (solib_global_lookup): Simplify.
 169         * symtab.c (null_block_symbol): Remove.
 170         (symbol_cache_lookup): Simplify returns.
 171         (lookup_language_this): Simplify returns.
 172         (lookup_symbol_aux): Simplify return.
 173         (lookup_local_symbol): Simplify returns.
 174         (lookup_global_symbol_from_objfile): Simplify return.
 175         (lookup_symbol_in_objfile_symtabs)
 176         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
 177         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
 178         (lookup_static_symbol, lookup_global_symbol): Simplify return.
 179         * cp-namespace.c (cp_lookup_bare_symbol)
 180         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
 181         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
 182         (cp_lookup_nested_symbol): Don't use null_block_symbol.
 183         (cp_lookup_symbol_via_imports): Simplify initialization.
 184         (find_symbol_in_baseclass): Likewise.
 185         * symtab.h (null_block_symbol): Remove.
 186         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
 187         (d_lookup_nested_symbol, d_lookup_symbol_imports)
 188         (d_lookup_symbol_module): Likewise.
 189         (find_symbol_in_baseclass): Simplify initialization.
 190
 191 2019-03-24  Tom Tromey  <tom@tromey.com>
 192
 193         * expression.h: Don't include symtab.h.
 194         (struct block): Forward declare.
 195
 196 2019-03-24  Tom Tromey  <tom@tromey.com>
 197
 198         * c-exp.y (typebase): Remove casts.
 199         * gdbtypes.c (lookup_unsigned_typename, )
 200         (lookup_signed_typename): Remove cast.
 201         * eval.c (parse_to_comma_and_eval): Remove cast.
 202         * parse.c (write_dollar_variable): Remove cast.
 203         * block.h (struct block) <superblock>: Now const.
 204         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
 205         * psymtab.c (psym_map_matching_symbols): Make "block" const.
 206         (map_block): Make "block" const.
 207         * symfile.h (struct quick_symbol_functions)
 208         <map_matching_symbols>: Constify block argument to "callback".
 209         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
 210         const.
 211         (find_pc_sect_compunit_symtab): Make "b" const.
 212         (find_symbol_at_address): Likewise.
 213         (search_symbols): Likewise.
 214         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
 215         (dw2_debug_names_lookup_symbol): Likewise.
 216         (dw2_map_matching_symbols): Update.
 217         * p-valprint.c (pascal_val_print): Remove "block".
 218         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
 219         (aux_add_nonlocal_symbols): Make "block" const.
 220         (resolve_subexp): Remove cast.
 221         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
 222         const.
 223         (iterate_over_file_blocks): Likewise.
 224         * f-exp.y (%union) <bval>: Remove.
 225         * coffread.c (patch_opaque_types): Make "b" const.
 226         * spu-tdep.c (spu_catch_start): Make "block" const.
 227         * c-valprint.c (print_unpacked_pointer): Remove "block".
 228         * symmisc.c (dump_symtab_1): Make "b" const.
 229         (block_depth): Make "block" const.
 230         * d-exp.y (%union) <bval>: Remove.
 231         * cp-support.h (cp_lookup_rtti_type): Update.
 232         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
 233         * psymtab.c (psym_lookup_symbol): Make "block" const.
 234         (maintenance_check_psymtabs): Make "b" const.
 235         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
 236         (enumerate_locals, enumerate_args): Update.
 237         * python/py-symtab.c (stpy_global_block): Make "block" const.
 238         (stpy_static_block): Likewise.
 239         * inline-frame.c (block_starting_point_at): Make "new_block"
 240         const.
 241         * block.c (find_block_in_blockvector): Make return type const.
 242         (blockvector_for_pc_sect): Make "b" const.
 243         (find_block_in_blockvector): Make "b" const.
 244
 245 2019-03-23  Tom Tromey  <tom@tromey.com>
 246
 247         * varobj.c (varobj_create): Update.
 248         * symfile.c (clear_symtab_users): Don't reset innermost_block.
 249         * printcmd.c (display_command, do_one_display): Don't reset
 250         innermost_block.
 251         * parser-defs.h (enum innermost_block_tracker_type): Move to
 252         expression.h.
 253         (innermost_block): Update comment.
 254         * parse.c (parse_exp_1): Add tracker_types parameter.
 255         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
 256         tracker_types parameter.  Reset innermost_block.
 257         (parse_exp_in_context): Remove.
 258         (parse_expression_for_completion): Update.
 259         * objfiles.c (~objfile): Don't reset expression_context_block or
 260         innermost_block.
 261         * expression.h (enum innermost_block_tracker_type): Move from
 262         parser-defs.h.
 263         (parse_exp_1): Add tracker_types parameter.
 264         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
 265         reset innermost_block.
 266
 267 2019-03-23  Tom Tromey  <tom@tromey.com>
 268
 269         * objfiles.h: Include bcache.h.
 270
 271 2019-03-23  Tom Tromey  <tom@tromey.com>
 272
 273         * linespec.c (get_current_search_block): Use
 274         scoped_restore_current_language.
 275         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
 276
 277 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 278             Jiong Wang  <jiong.wang@arm.com>
 279
 280         * aarch64-linux-tdep.c
 281         (aarch64_linux_iterate_over_regset_sections): Check for pauth
 282         section.
 283         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
 284
 285 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 286             Jiong Wang  <jiong.wang@arm.com>
 287
 288         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
 289         instructions.
 290         (aarch64_analyze_prologue_test): Add PACIASP test.
 291         (aarch64_prologue_prev_register): Unmask PC value.
 292
 293 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 294             Jiong Wang  <jiong.wang@arm.com>
 295
 296         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
 297         (aarch64_dwarf2_prev_register): Unmask PC value.
 298         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
 299         (aarch64_execute_dwarf_cfa_vendor_op): Check for
 300         DW_CFA_AARCH64_negate_ra_state.
 301         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
 302
 303 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 304             Jiong Wang  <jiong.wang@arm.com>
 305
 306         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
 307         registers.
 308         (aarch64_pseudo_register_name): Likewise.
 309         (aarch64_pseudo_register_type): Likewise.
 310         (aarch64_pseudo_register_reggroup_p): Likewise.
 311         (aarch64_gdbarch_init): Add pauth registers.
 312         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
 313         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
 314         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
 315         (struct gdbarch_tdep): Add regnum for ra_state.
 316
 317 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 318             Jiong Wang  <jiong.wang@arm.com>
 319
 320         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
 321
 322 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 323             Jiong Wang  <jiong.wang@arm.com>
 324
 325         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
 326         function.
 327         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
 328         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
 329         (aarch64_gdbarch_init): Add puth registers.
 330         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
 331         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
 332         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
 333
 334 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 335             Jiong Wang  <jiong.wang@arm.com>
 336
 337         * aarch64-linux-nat.c
 338         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
 339         * aarch64-linux-tdep.c
 340         (aarch64_linux_core_read_description): Likewise.
 341         (aarch64_linux_get_hwcap): New function.
 342         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
 343         (aarch64_linux_get_hwcap): New declaration.
 344
 345 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 346             Jiong Wang  <jiong.wang@arm.com>
 347
 348         * aarch64-linux-nat.c
 349         (aarch64_linux_nat_target::read_description): Add pauth param.
 350         * aarch64-linux-tdep.c
 351         (aarch64_linux_core_read_description): Likewise.
 352         * aarch64-tdep.c (struct target_desc): Add in pauth.
 353         (aarch64_read_description): Add pauth param.
 354         (aarch64_gdbarch_init): Likewise.
 355         * aarch64-tdep.h (aarch64_read_description): Likewise.
 356         * arch/aarch64.c (aarch64_create_target_description): Likewise.
 357         * arch/aarch64.h (aarch64_create_target_description): Likewise.
 358         * features/Makefile: Add new files.
 359         * features/aarch64-pauth.c: New file.
 360         * features/aarch64-pauth.xml: New file.
 361
 362 2019-03-20  Tom Tromey  <tromey@adacore.com>
 363
 364         * infrun.c (handle_inferior_event): Rename from
 365         handle_inferior_event_1.  Create a scoped_value_mark.
 366         (handle_inferior_event): Remove.
 367
 368 2019-03-19  Tom Tromey  <tromey@adacore.com>
 369
 370         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
 371         * infrun.h (print_stop_event): Add "displays" parameter.
 372         * infrun.c (print_stop_event): Add "displays" parameter.
 373
 374 2019-03-19  Pedro Alves  <palves@redhat.com>
 375
 376         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
 377         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
 378         to -1.  Fix TABs vs spaces.
 379         (tui_ui_out::tui_ui_out): Don't initialize fields here.
 380         * tui/tui-out.h (tui_ui_out) Add intro comments.
 381         <m_line, m_start_of_line>: In-class initialize, and add describing
 382         comment.
 383
 384 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
 385
 386         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
 387         variable names.
 388         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
 389
 390 2019-03-18  Pedro Alves  <palves@redhat.com>
 391             Eli Zaretskii <eliz@gnu.org>
 392
 393         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
 394         m_line and m_start_of_line.
 395
 396 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
 397
 398         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
 399         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
 400         it returns a newline.  This fixes a regression in TU mode, whereby
 401         the next line is output on the same screen line as the user input.
 402
 403 2019-03-18  Tom Tromey  <tromey@adacore.com>
 404
 405         * minsyms.c (minimal_symbol_reader::install): Remove call to
 406         obstack_blank.
 407
 408 2019-03-18  Pedro Alves  <palves@redhat.com>
 409
 410         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
 411         New globals.
 412         (apply_style): New, factored out from ...
 413         (apply_ansi_escape): ... this.  Handle reverse video mode.
 414         (tui_set_reverse_mode): New function.
 415         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
 416         * tui/tui-winsource.c (tui_show_source_line): Use
 417         tui_set_reverse_mode instead of setting A_STANDOUT.
 418         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
 419         New setter methods.
 420
 421 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
 422
 423         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
 424         Handle tabs.
 425
 426 2019-03-18  Tom Tromey  <tromey@adacore.com>
 427
 428         * ada-lang.c (empty_array): Add "high" parameter.
 429         (ada_evaluate_subexp): Update.
 430
 431 2019-03-17  Sergei Trofimovich <siarheit@google.com>
 432
 433         * unittests/string_view-selftests.c: Define
 434         _initialize_string_view_selftests unconditionally.
 435
 436 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 437
 438         PR gdb/24350
 439         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
 440
 441 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 442
 443         PR gdb/24351
 444         * windows-nat.c (display_selector): Fix format specifiers.
 445
 446 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
 447
 448         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
 449         tui_refill_source_window instead of tui_refresh_win, to update the
 450         current execution line.  This fixes redisplay of the current line
 451         when stepping through the code with "next" or "step".
 452
 453 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 454
 455         * source-cache.c (source_cache::get_source_lines): Call
 456         find_source_lines to initialize s->nlines.  This fixes vertical
 457         scrolling of TUI source window when the DOWN arrow is pressed.
 458
 459 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 460
 461         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
 462         linux-thread-db.c (_initialize_thread_db): Likewise.
 463
 464 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 465
 466         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
 467         wclrtoeol in tui_show_source_line".  This reverts changes made in
 468         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
 469
 470 2019-03-15  Tom Tromey  <tom@tromey.com>
 471
 472         * symtab.h (struct minimal_symbol): Derive from
 473         general_symbol_info.
 474         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
 475         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
 476         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
 477         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
 478         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
 479         (MSYMBOL_SEARCH_NAME): Update.
 480         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
 481         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
 482         * minsyms.c (minimal_symbol_reader::record_full): Update.
 483
 484 2019-03-15  Tom Tromey  <tom@tromey.com>
 485
 486         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
 487
 488 2019-03-15  Tom Tromey  <tom@tromey.com>
 489
 490         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
 491         unique_xmalloc_ptr.
 492         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
 493         Update.
 494         * minsyms.c (lookup_minimal_symbol_by_pc_section)
 495         (build_minimal_symbol_hash_tables)
 496         (minimal_symbol_reader::install): Update.
 497
 498 2019-03-15  Tom Tromey  <tom@tromey.com>
 499
 500         * symtab.c (create_demangled_names_hash): Update.
 501         (symbol_set_names): Update.
 502         * objfiles.h (struct objfile_per_bfd_storage)
 503         <demangled_names_hash>: Now an htab_up.
 504         * objfiles.c (objfile_per_bfd_storage): Simplify.
 505
 506 2019-03-15  Tom Tromey  <tom@tromey.com>
 507
 508         * objfiles.h (struct objfile_per_bfd_storage): Declare
 509         destructor.
 510         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
 511         New.
 512         (get_objfile_bfd_data): Use new.  Don't initialize
 513         language_of_main.
 514         (free_objfile_per_bfd_storage): Remove.
 515         (objfile_bfd_data_free, objfile::~objfile): Use delete.
 516
 517 2019-03-15  Tom Tromey  <tom@tromey.com>
 518
 519         * symfile.c (reread_symbols): Update.
 520         * objfiles.c (objfile::objfile): Update.
 521         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
 522         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
 523         comment.
 524         (minimal_symbol_reader::install): Update.
 525         (terminate_minimal_symbol_table): Remove.
 526         * jit.c (jit_object_close_impl): Update.
 527
 528 2019-03-15  Tom Tromey  <tom@tromey.com>
 529
 530         * minsyms.c (minimal_symbol_reader::record_full): Remove some
 531         initializations.
 532
 533 2019-03-15  Tom Tromey  <tom@tromey.com>
 534
 535         * objfiles.h (struct objfile_per_bfd_storage)
 536         <demangled_hash_languages>: Now a bitset.
 537         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
 538         (lookup_minimal_symbol): Update.
 539
 540 2019-03-15  Tom Tromey  <tom@tromey.com>
 541
 542         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
 543         Don't return the symbol.
 544         * coffread.c (record_minimal_symbol): Use record_full.
 545
 546 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
 547
 548         The MS-Windows port of ncurses fails to switch to a color pair if
 549         one or both of the colors are the implicit default colors.  This
 550         change records the default colors when TUI is initialized, and
 551         then specifies them explicitly when a color pair uses the default
 552         colors.  This allows color styling in TUI mode on MS-Windows.
 553
 554         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
 555         ncurses_norm_attr.
 556         (tui_initialize_io) [__MINGW32__]: Record the default terminal
 557         colors in ncurses_norm_attr.
 558         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
 559         "none", replace it with the default color recorded in
 560         ncurses_norm_attr.
 561
 562 2019-03-14  Tom Tromey  <tromey@adacore.com>
 563
 564         * source-cache.h (class source_cache) <get_source_lines>: Return
 565         std::string.
 566         * source-cache.c (source_cache::extract_lines): Handle case where
 567         first_pos==npos.  Return std::string.
 568         (source_cache::get_source_lines): Update.
 569
 570 2019-03-14  Tom Tromey  <tromey@adacore.com>
 571
 572         * NEWS: Add item for "style sources" commands.
 573         * source-cache.c (source_cache::get_source_lines): Check
 574         source_styling.
 575         * cli/cli-style.c (source_styling): New global.
 576         (_initialize_cli_style): Add "style sources" commands.
 577         (show_style_sources): New function.
 578         * cli/cli-style.h (source_styling): Declare.
 579
 580 2019-03-14  Pedro Alves  <palves@redhat.com>
 581             Tom Tromey  <tromey@adacore.com>
 582
 583         * tui/tui-winsource.h (tui_refill_source_window): Declare.
 584         * tui/tui-winsource.c (tui_refill_source_window): New function,
 585         from...
 586         (tui_horizontal_source_scroll): ... here.  Move some logic.
 587         * cli/cli-style.c (set_style_enabled): Notify new observable.
 588         * tui/tui-hooks.c (tui_redisplay_source): New function.
 589         (tui_attach_detach_observers): Attach or detach
 590         tui_redisplay_source.
 591         * observable.h (source_styling_changed): New observable.
 592         * observable.c: Define source_styling_changed observable.
 593
 594 2019-03-13  Tom Tromey  <tromey@adacore.com>
 595
 596         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
 597         (i386_gnu_nat_target::store_registers): Update.
 598         * target-debug.h (target_debug_print_std_string): New macro.
 599         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
 600         * windows-tdep.c (display_one_tib): Update.
 601         * tui/tui-stack.c (tui_make_status_line): Update.
 602         * top.c (print_inferior_quit_action): Update.
 603         * thread.c (thr_try_catch_cmd): Update.
 604         (add_thread_with_info): Update.
 605         (thread_target_id_str): Update.
 606         (thr_try_catch_cmd): Update.
 607         (thread_command): Update.
 608         (thread_find_command): Update.
 609         * record-btrace.c (record_btrace_target::info_record)
 610         (record_btrace_resume_thread, record_btrace_target::resume)
 611         (record_btrace_cancel_resume, record_btrace_step_thread)
 612         (record_btrace_target::wait, record_btrace_target::wait)
 613         (record_btrace_target::wait, record_btrace_target::stop): Update.
 614         * progspace.c (print_program_space): Update.
 615         * process-stratum-target.c
 616         (process_stratum_target::thread_address_space): Update.
 617         * linux-fork.c (linux_fork_mourn_inferior)
 618         (detach_checkpoint_command, info_checkpoints_command)
 619         (linux_fork_context): Update.
 620         (linux_fork_detach): Update.
 621         (class scoped_switch_fork_info): Update.
 622         (delete_checkpoint_command): Update.
 623         * infrun.c (follow_fork_inferior): Update.
 624         (follow_fork_inferior): Update.
 625         (proceed_after_vfork_done): Update.
 626         (handle_vfork_child_exec_or_exit): Update.
 627         (follow_exec): Update.
 628         (displaced_step_prepare_throw): Update.
 629         (displaced_step_restore): Update.
 630         (start_step_over): Update.
 631         (resume_1): Update.
 632         (clear_proceed_status_thread): Update.
 633         (proceed): Update.
 634         (print_target_wait_results): Update.
 635         (do_target_wait): Update.
 636         (context_switch): Update.
 637         (stop_all_threads): Update.
 638         (restart_threads): Update.
 639         (finish_step_over): Update.
 640         (handle_signal_stop): Update.
 641         (switch_back_to_stepped_thread): Update.
 642         (keep_going_pass_signal): Update.
 643         (print_exited_reason): Update.
 644         (normal_stop): Update.
 645         * inferior.c (inferior_pid_to_str): Change return type.
 646         (print_selected_inferior): Update.
 647         (add_inferior): Update.
 648         (detach_inferior): Update.
 649         * dummy-frame.c (fprint_dummy_frames): Update.
 650         * dcache.c (dcache_info_1): Update.
 651         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
 652         (btrace_fetch, btrace_clear): Update.
 653         * linux-tdep.c (linux_core_pid_to_str): Change return type.
 654         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
 655         type.
 656         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
 657         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
 658         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
 659         * gdbarch.c, gdbarch.h: Rebuild.
 660         * gdbarch.sh (core_pid_to_str): Change return type.
 661         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
 662         return type.
 663         (windows_nat_target::pid_to_str): Change return type.
 664         (windows_delete_thread): Update.
 665         (windows_nat_target::attach): Update.
 666         (windows_nat_target::files_info): Update.
 667         * target-delegates.c: Rebuild.
 668         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
 669         return type.
 670         (sol_thread_target::pid_to_str): Change return type.
 671         * remote.c (class remote_target) <pid_to_str>: Change return
 672         type.
 673         (remote_target::pid_to_str): Change return type.
 674         (extended_remote_target::attach, remote_target::remote_stop_ns)
 675         (remote_target::remote_notif_remove_queued_reply)
 676         (remote_target::push_stop_reply, remote_target::disable_btrace):
 677         Update.
 678         (extended_remote_target::attach): Update.
 679         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
 680         type.
 681         (gdbsim_target::pid_to_str): Change return type.
 682         * ravenscar-thread.c (struct ravenscar_thread_target)
 683         <pid_to_str>: Change return type.
 684         (ravenscar_thread_target::pid_to_str): Change return type.
 685         * procfs.c (class procfs_target) <pid_to_str>: Change return
 686         type.
 687         (procfs_target::pid_to_str): Change return type.
 688         (procfs_target::attach): Update.
 689         (procfs_target::detach): Update.
 690         (procfs_target::fetch_registers): Update.
 691         (procfs_target::store_registers): Update.
 692         (procfs_target::wait): Update.
 693         (procfs_target::files_info): Update.
 694         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
 695         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
 696         return type.
 697         (nto_procfs_target::pid_to_str): Change return type.
 698         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
 699         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
 700         return type.
 701         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
 702         (exit_lwp): Update.
 703         (attach_proc_task_lwp_callback, get_detach_signal)
 704         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
 705         (linux_nat_target::resume, wait_lwp, stop_callback)
 706         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
 707         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
 708         (linux_nat_wait_1, resume_stopped_resumed_lwps)
 709         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
 710         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
 711         type.
 712         (inf_ptrace_target::attach): Update.
 713         (inf_ptrace_target::files_info): Update.
 714         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
 715         type.
 716         (go32_nat_target::pid_to_str): Change return type.
 717         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
 718         (gnu_nat_target::wait): Update.
 719         (gnu_nat_target::wait): Update.
 720         (gnu_nat_target::resume): Update.
 721         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
 722         (fbsd_nat_target::wait): Update.
 723         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
 724         type.
 725         (darwin_nat_target::attach): Update.
 726         * corelow.c (class core_target) <pid_to_str>: Change return type.
 727         (core_target::pid_to_str): Change return type.
 728         * target.c (normal_pid_to_str): Change return type.
 729         (default_pid_to_str): Likewise.
 730         (target_pid_to_str): Change return type.
 731         (target_translate_tls_address): Update.
 732         (target_announce_detach): Update.
 733         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
 734         return type.
 735         (bsd_uthread_target::pid_to_str): Change return type.
 736         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
 737         type.
 738         (bsd_kvm_target::pid_to_str): Change return type.
 739         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
 740         return type.
 741         (aix_thread_target::pid_to_str): Change return type.
 742         * target.h (struct target_ops) <pid_to_str>: Change return type.
 743         (target_pid_to_str, normal_pid_to_str): Likewise.
 744         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
 745         type.
 746         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
 747         type.
 748         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
 749         return type.
 750         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
 751         type.
 752         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
 753         type.
 754         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
 755         return type.
 756
 757 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
 758
 759         * NEWS: Mention that the new default MI version is 3.  Mention
 760         changes to the output of commands and events that deal with
 761         multi-location breakpoints.
 762         * breakpoint.c: Include "mi/mi-out.h".
 763         (print_one_breakpoint): Change output syntax if using MI version
 764         >= 3.
 765         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
 766         New.
 767         (mi_multi_location_breakpoint_output_fixed): New.
 768         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
 769         (mi_cmd_fix_multi_location_breakpoint_output): New.
 770         (mi_multi_location_breakpoint_output_fixed): New.
 771         * mi/mi-cmds.c (mi_cmds): Register command
 772         -fix-multi-location-breakpoint-output.
 773         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
 774         interpreter "mi".
 775
 776 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
 777
 778         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
 779         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
 780         instantiate mi_ui_out based on interpreter name.
 781         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
 782         * mi/mi-main.c (mi_load_progress): Likewise.
 783
 784 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 785
 786         * NEWS: Combine separate "New targets" sections for 8.3.
 787
 788 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 789
 790         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
 791         (ppcfbsd_init_abi): Install gdbarch
 792         "fetch_tls_load_module_address" and "get_thread_local_address"
 793         methods.
 794
 795 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 796
 797         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
 798         (riscv_fbsd_init_abi): Install gdbarch
 799         "fetch_tls_load_module_address" and "get_thread_local_address"
 800         methods.
 801
 802 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 803
 804         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
 805         (i386fbsd_init_abi): Install gdbarch
 806         "fetch_tls_load_module_address" and "get_thread_local_address"
 807         methods.
 808
 809 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 810
 811         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
 812         (amd64fbsd_init_abi): Install gdbarch
 813         "fetch_tls_load_module_address" and "get_thread_local_address"
 814         methods.
 815
 816 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 817
 818         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
 819         (struct fbsd_pspace_data): New type.
 820         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
 821         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
 822         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
 823         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
 824         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
 825
 826 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 827
 828         * gdbtypes.c (lookup_struct_elt): New function.
 829         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
 830         * gdbtypes.h (struct struct_elt): New type.
 831         (lookup_struct_elt): New prototype.
 832
 833 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 834
 835         * gdbtypes.c (lookup_struct_elt_type): Update comment and
 836         remove disabled code block.
 837
 838 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 839
 840         * gdbarch.sh (get_thread_local_address): New method.
 841         * gdbarch.h, gdbarch.c: Regenerate.
 842         * target.c (target_translate_tls_address): Use
 843         gdbarch_get_thread_local_address if present instead of
 844         target::get_thread_local_address.
 845
 846 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 847
 848         * target.h (target::get_thread_local_address): Update comment.
 849
 850 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 851
 852         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
 853         objfile->separate_debug_objfile_backlink if not NULL.
 854
 855 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 856
 857         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
 858         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
 859         (amd64bsd_store_inferior_registers): Likewise.
 860         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 861         Enable segment base registers.
 862         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
 863         PT_GETFSBASE and PT_GETGSBASE.
 864         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
 865         PT_SETGSBASE.
 866         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
 867         segment base registers.
 868         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 869
 870 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 871
 872         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 873         Update calls to i386_target_description to add 'segments'
 874         parameter.
 875         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
 876         add segment base registers.
 877         * arch/i386.c (i386_create_target_description): Add 'segments'
 878         parameter to enable segment base registers.
 879         * arch/i386.h (i386_create_target_description): Likewise.
 880         * features/i386/32bit-segments.xml: New file.
 881         * features/i386/32bit-segments.c: Generate.
 882         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
 883         call to i386_target_description to add 'segments' parameter.
 884         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 885         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
 886         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
 887         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
 888         if feature is present.
 889         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
 890         Add 'segments' parameter to call to i386_target_description.
 891         (i386_target_description): Add 'segments' parameter to enable
 892         segment base registers.
 893         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
 894         to call to i386_target_description.
 895         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
 896         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
 897         Define I386_NUM_REGS.
 898         (i386_target_description): Add 'segments' parameter to enable
 899         segment base registers.
 900
 901 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
 902
 903         PR/24325
 904         * source-cache.c: #undef open and close, to avoid unresolved
 905         externals during linking.
 906
 907 2019-03-12  Tom Tromey  <tromey@adacore.com>
 908
 909         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
 910         const.  Add initializers.
 911         (_initialize_remote): Don't initialize ptid globals.
 912
 913 2019-03-12  Pedro Alves  <palves@redhat.com>
 914
 915         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
 916
 917 2019-03-12  Pedro Alves  <palves@redhat.com>
 918
 919         * cp-name-parser.y (main): Remove unused 'len' variable.
 920
 921 2019-03-12  Tom Tromey  <tromey@adacore.com>
 922
 923         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
 924         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
 925
 926 2019-03-12  Tom Tromey  <tromey@adacore.com>
 927
 928         * linux-nat.c (iterate_over_lwps): Update.
 929         (stop_callback): Remove parameter.
 930         (stop_wait_callback, detach_callback, resume_set_callback)
 931         (select_singlestep_lwp_callback, set_ignore_sigint)
 932         (status_callback, resumed_callback, resume_clear_callback)
 933         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
 934         data parameter.
 935         (linux_nat_target::detach, linux_nat_target::resume)
 936         (linux_stop_and_wait_all_lwps, select_event_lwp)
 937         (linux_nat_filter_event, linux_nat_wait_1)
 938         (linux_nat_target::kill, linux_nat_target::stop)
 939         (linux_nat_target::stop): Update.
 940         (linux_nat_resume_callback): Change type.
 941         (resume_stopped_resumed_lwps, count_events_callback)
 942         (select_event_lwp_callback): Likewise.
 943         (linux_stop_lwp, linux_nat_stop_lwp): Update.
 944         * arm-linux-nat.c (struct update_registers_data): Remove.
 945         (update_registers_callback): Change type.
 946         (arm_linux_insert_hw_breakpoint1): Update.
 947         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
 948         parameter.
 949         (x86_linux_dr_set_addr): Update.
 950         (x86_linux_dr_set_control): Update.
 951         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
 952         (iterate_over_lwps): Use gdb::function_view.
 953         * nat/aarch64-linux-hw-point.c (struct
 954         aarch64_dr_update_callback_param): Remove.
 955         (debug_reg_change_callback): Change type.
 956         (aarch64_notify_debug_reg_change): Update.
 957         * s390-linux-nat.c (s390_refresh_per_info): Update.
 958
 959 2019-03-11  Tom Tromey  <tromey@adacore.com>
 960
 961         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
 962         redundant assignment to "this_cu".
 963
 964 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 965
 966         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
 967
 968 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 969
 970         * gdbtypes.c (rank_one_type_parm_set): New function extracted
 971         from...
 972         (rank_one_type): ... this.
 973
 974 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 975
 976         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
 977         from...
 978         (rank_one_type): ... this.
 979
 980 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 981
 982         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
 983         from...
 984         (rank_one_type): ... this.
 985
 986 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 987
 988         * gdbtypes.c (rank_one_type_parm_float): New function extracted
 989         from...
 990         (rank_one_type): ... this.
 991
 992 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 993
 994         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
 995         from...
 996         (rank_one_type): ... this.
 997
 998 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 999
1000         * gdbtypes.c (rank_one_type_parm_range): New function extracted
1001         from...
1002         (rank_one_type): ... this.
1003
1004 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1005
1006         * gdbtypes.c (rank_one_type_parm_char): New function extracted
1007         from...
1008         (rank_one_type): ... this.
1009
1010 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1011
1012         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
1013         from...
1014         (rank_one_type): ... this.
1015
1016 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1017
1018         * gdbtypes.c (rank_one_type_parm_int): New function extracted
1019         from...
1020         (rank_one_type): ... this.
1021
1022 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1023
1024         * gdbtypes.c (rank_one_type_parm_func): New function extracted
1025         from...
1026         (rank_one_type): ... this.
1027
1028 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1029
1030         * gdbtypes.c (rank_one_type_parm_array): New function extracted
1031         from...
1032         (rank_one_type): ... this.
1033
1034 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1035
1036         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
1037         from...
1038         (rank_one_type): ... this.
1039
1040 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1041
1042         * inferior.c (initialize_inferiors): Ensure 'help set/show print
1043         inferior-events' shows the example events.
1044
1045 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
1046
1047         Support styling on native MS-Windows console
1048
1049         PR/24315
1050         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
1051         on MS-Windows if $TERM is not defined.
1052
1053         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
1054
1055         * posix-hdep.c (gdb_console_fputs):
1056         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
1057         functions.
1058         * ui-file.h (gdb_console_fputs): Add prototype.
1059
1060         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
1061         back to fputs only if the former returns zero.
1062
1063 2019-03-07  Tom Tromey  <tom@tromey.com>
1064
1065         * symmisc.c (print_symbol_bcache_statistics): Update.
1066         (print_objfile_statistics): Update.
1067         * symfile.c (allocate_symtab): Update.
1068         * stabsread.c: Don't include bcache.h.
1069         * psymtab.h (struct psymbol_bcache): Don't declare.
1070         (class psymtab_storage) <psymbol_cache>: Now a bcache.
1071         (psymbol_bcache_init, psymbol_bcache_free)
1072         (psymbol_bcache_get_bcache): Don't declare.
1073         * psymtab.c (struct psymbol_bcache): Remove.
1074         (psymtab_storage::psymtab_storage): Update.
1075         (psymtab_storage::~psymtab_storage): Update.
1076         (psymbol_bcache_init, psymbol_bcache_free)
1077         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
1078         (add_psymbol_to_bcache): Update.
1079         (allocate_psymtab): Update.
1080         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
1081         macro_cache>: No longer pointers.
1082         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
1083         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
1084         * macrotab.c (macro_bcache): Update.
1085         * macroexp.c: Don't include bcache.h.
1086         * gdbtypes.c (check_types_worklist): Update.
1087         (types_deeply_equal): Remove TRY/CATCH.  Update.
1088         * elfread.c (elf_symtab_read): Update.
1089         * dwarf2read.c: Don't include bcache.h.
1090         * buildsym.c (buildsym_compunit::get_macro_table): Update.
1091         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
1092         (print_bcache_statistics, bcache_memory_used): Don't declare.
1093         (struct bcache): Move from bcache.c.  Add constructor, destructor,
1094         methods.  Rename all data members.
1095         * bcache.c (struct bcache): Move to bcache.h.
1096         (bcache::expand_hash_table): Rename from expand_hash_table.
1097         (bcache): Remove.
1098         (bcache::insert): Rename from bcache_full.
1099         (bcache::compare): Rename from bcache_compare.
1100         (bcache_xmalloc): Remove.
1101         (bcache::~bcache): Rename from bcache_xfree.
1102         (bcache::print_statistics): Rename from print_bcache_statistics.
1103         (bcache::memory_used): Rename from bcache_memory_used.
1104
1105 2019-03-07  Pedro Alves  <palves@redhat.com>
1106
1107         * infrun.c (normal_stop): Also check for
1108         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
1109
1110 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
1111
1112         * f-lang.c (value_from_host_double): Moved to...
1113         * value.c (value_from_host_double): ...here.
1114         * value.h (value_from_host_double): Declare.
1115         * guile/scm-math.c (vlscm_convert_typed_number): Use
1116         value_from_host_double.
1117         (vlscm_convert_number): Likewise.
1118         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
1119         * python/py-value.c (convert_value_from_python): Likewise.
1120
1121 2019-03-06  Tom Tromey  <tom@tromey.com>
1122
1123         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
1124
1125 2019-03-06  Tom Tromey  <tom@tromey.com>
1126
1127         * utils.h (free_current_contents): Don't declare.
1128         * utils.c (free_current_contents): Remove.
1129
1130 2019-03-06  Tom Tromey  <tom@tromey.com>
1131
1132         * top.c (quit_force): Update.
1133         * main.c (captured_command_loop): Update.
1134         * common/new-op.c (operator new): Update.
1135         * common/common-exceptions.c (struct catcher)
1136         <save_cleanup_chain>: Remove member.
1137         (exceptions_state_mc_init): Update.
1138         (exception_try_scope_entry): Return nullptr.
1139         (exception_try_scope_exit, exception_rethrow)
1140         (throw_exception_sjlj, throw_exception_cxx): Update.
1141         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
1142         (all_cleanups, do_cleanups, discard_cleanups)
1143         (discard_final_cleanups, save_cleanups, save_final_cleanups)
1144         (restore_cleanups, restore_final_cleanups): Don't declare.
1145         (do_final_cleanups): Remove parameter.
1146         * common/cleanups.c (cleanup_chain, make_cleanup)
1147         (make_cleanup_dtor, all_cleanups, do_cleanups)
1148         (discard_my_cleanups, discard_cleanups)
1149         (discard_final_cleanups, save_my_cleanups, save_cleanups)
1150         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
1151         (null_cleanup): Remove.
1152         (do_final_cleanups): Remove parameter.
1153
1154 2019-03-06  Tom Tromey  <tom@tromey.com>
1155
1156         * remote.c (remote_target::remote_parse_stop_reply): Use
1157         unique_xmalloc_ptr.
1158
1159 2019-03-06  Tom Tromey  <tom@tromey.com>
1160
1161         * stabsread.c (struct stabs_field_info): Rename from field_info.
1162         <list, fnlist>: Add initializers.
1163         <obstack>: New member.
1164         (read_member_functions, read_struct_fields, read_baseclasses):
1165         Allocate on obstack.  Don't use cleanups.
1166         (read_one_struct_field, read_member_functions, read_struct_fields)
1167         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
1168         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
1169         (read_struct_type): Update.
1170
1171 2019-03-06  Tom Tromey  <tom@tromey.com>
1172
1173         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
1174         * common/filestuff.h (make_cleanup_close): Don't declare.
1175         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
1176         Remove.
1177
1178 2019-03-06  Tom Tromey  <tom@tromey.com>
1179
1180         * solib-aix.c: Use make_scope_exit.
1181
1182 2019-03-06  Tom Tromey  <tom@tromey.com>
1183
1184         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
1185         Use make_scope_exit.
1186
1187 2019-03-06  Tom Tromey  <tom@tromey.com>
1188
1189         * solib-svr4.c (disable_probes_interface): Remove parameter.
1190         (svr4_handle_solib_event): Use make_scope_exit.
1191
1192 2019-03-06  Tom Tromey  <tom@tromey.com>
1193
1194         * remote.c (struct stop_reply_deleter): Remove.
1195         (stop_reply_up): Update.
1196         (struct stop_reply): Derive from notif_event.  Don't typedef.
1197         <regcache>: Now a std::vector.
1198         (stop_reply_xfree): Remove.
1199         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
1200         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
1201         (remote_target::discard_pending_stop_replies): Use delete.
1202         (remote_target::remote_parse_stop_reply): Update.
1203         (remote_target::process_stop_reply): Update.
1204         * remote-notif.h (struct notif_event): Add virtual destructor.
1205         Remove "dtr" member.
1206         (struct notif_client) <alloc_event>: Return a unique_ptr.
1207         (notif_event_xfree): Don't declare.
1208         (notif_event_up): New typedef.
1209         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
1210         (notif_event_xfree, do_notif_event_xfree): Remove.
1211         (remote_notif_state_xfree): Update.
1212
1213 2019-03-06  Tom Tromey  <tom@tromey.com>
1214
1215         * infrun.c (displaced_step_clear_cleanup): Now a
1216         forward_scope_exit type.
1217         (displaced_step_prepare_throw): Update.
1218         (displaced_step_fixup): Update.
1219
1220 2019-03-06  Tom Tromey  <tom@tromey.com>
1221
1222         * inferior.h (class inferior): Update comment.
1223         * gdbthread.h (class thread_info): Update comment.
1224
1225 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
1226             Tom Tromey  <tom@tromey.com>
1227
1228         * stabsread.h (struct stab_section_list): Remove.
1229         (coffstab_build_psymtabs): Update.
1230         * dbxread.c (symbuf_sections): Now a std::vector.
1231         (sect_idx): New global.
1232         (fill_symbuf): Update.
1233         (coffstab_build_psymtabs): Change type of stabsects parameter.
1234         Update.
1235         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
1236         std::vector.
1237         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
1238         (coff_locate_sections): Update.
1239         (coff_symfile_read): Remove cleanups.  Update.
1240         (init_stringtab): Add storage parameter.
1241         (free_stringtab, free_stringtab_cleanup): Remove.
1242         (init_lineno): Add storage parameter.
1243         (free_linetab, free_linetab_cleanup): Remove.
1244
1245 2019-03-06  Pedro Alves  <palves@redhat.com>
1246
1247         * linux-fork.c (fork_info::clobber_regs): Delete.
1248         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
1249         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
1250         comment.  Adjust.
1251         (scoped_switch_fork_info::scoped_switch_fork_info)
1252         (checkpoint_command, linux_fork_context): Adjust
1253         fork_save_infrun_state calls.
1254
1255 2019-03-06  Pedro Alves  <palves@redhat.com>
1256
1257         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
1258         (inf_has_multiple_threads): Return 'bool' and rewrite using
1259         inferior_info::threads().
1260
1261 2019-03-06  Pedro Alves  <palves@redhat.com>
1262
1263         * linux-fork.c: Include <list>.
1264         (fork_list): Now a std::list instance.
1265         (fork_info): Add ctor, dtor, and in-class initialize all fields.
1266         (forks_exist_p, find_last_fork): Adjust.
1267         (new_fork): Delete.
1268         (one_fork_p): New.
1269         (add_fork): Adjust.
1270         (free_fork): Delete, folded into fork_info::~fork_info().
1271         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
1272         Adjust.
1273         (init_fork_list): Delete.
1274         (linux_fork_killall, linux_fork_mourn_inferior)
1275         (linux_fork_detach, info_checkpoints_command): Adjust.
1276         (_initialize_linux_fork): No longer call init_fork_list.
1277
1278 2019-03-06  Pedro Alves  <palves@redhat.com>
1279
1280         * linux-fork.c (new_fork): New, split out of ...
1281         (add_fork): ... this.  Return void.  Move "first fork" special
1282         case from here, to ...
1283         (checkpoint_command): ... here.
1284         * linux-linux.h (add_fork): Return void.
1285
1286 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1287
1288         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
1289
1290 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1291             Chris January  <chris.january@arm.com>
1292             David Lecomber  <david.lecomber@arm.com>
1293
1294         * f-exp.y: New token, UNOP_INTRINSIC.
1295         (exp): New pattern using UNOP_INTRINSIC token.
1296         (f77_keywords): Add 'abs' keyword.
1297         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
1298         (value_from_host_double): New function.
1299         (evaluate_subexp_f): Support UNOP_ABS.
1300
1301 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1302
1303         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
1304         types.
1305
1306 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1307
1308         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
1309         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
1310         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
1311
1312 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1313
1314         * f-exp.y (convert_to_kind_type): Handle more type kinds.
1315
1316 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1317             Chris January  <chris.january@arm.com>
1318
1319         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
1320         * f-exp.y: Define 'KIND' token.
1321         (exp): New pattern for KIND expressions.
1322         (ptype): Handle types with a kind extension.
1323         (direct_abs_decl): Extend to spot kind extensions.
1324         (f77_keywords): Add 'kind' to the list.
1325         (push_kind_type): New function.
1326         (convert_to_kind_type): New function.
1327         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
1328         * parse.c (operator_length_standard): Likewise.
1329         * parser-defs.h (enum type_pieces): Add tp_kind.
1330         * std-operator.def: Add UNOP_KIND.
1331
1332 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1333
1334         * f-exp.y (f_parse): Set yydebug.
1335
1336 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1337
1338         * f-lang.c (evaluate_subexp_f): New function.
1339         (exp_descriptor_f): New global.
1340         (f_language_defn): Use exp_descriptor_f instead of
1341         exp_descriptor_standard.
1342
1343 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1344
1345         * f-exp.y (struct token): Add comments.
1346         (dot_ops): Remove uppercase versions and the end marker.
1347         (f77_keywords): Likewise.
1348         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
1349         entries in the dot_ops array are case insensitive, and use
1350         strncasecmp to compare strings.  Also some whitespace cleanup in
1351         this area.  Similar for the f77_keywords array, except entries in
1352         this list might be case sensitive.
1353
1354 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1355
1356         * f-exp.y (struct f77_boolean_val): Add comments.
1357         (boolean_values): Remove uppercase versions, and end marker.
1358         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
1359         and use strncasecmp to achieve case insensitivity.  Additionally,
1360         perform whitespace cleanup around this code.
1361
1362 2019-03-06  Tom Tromey  <tromey@adacore.com>
1363
1364         * remote-sim.c (gdbsim_target_open): Use result of
1365         gdb_argv::release.
1366
1367 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
1368         Dirk Schubert  <dirk.schubert@arm.com>
1369         Chris January  <chris.january@arm.com>
1370
1371         * eval.c (evaluate_subexp_standard): Call Fortran argument
1372         wrapping logic.
1373         * f-lang.c (struct value): A value which can be passed into a
1374         Fortran function call.
1375         (fortran_argument_convert): Wrap Fortran arguments in a pointer
1376         where appropriate.
1377         (struct type): Value ready for a Fortran function call.
1378         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
1379         is needed.
1380         * f-lang.h (fortran_argument_convert): Declaration.
1381         (fortran_preserve_arg_pointer): Declaration.
1382         * infcall.c (value_arg_coerce): Call Fortran argument logic.
1383
1384 2019-03-05  Tom Tromey  <tromey@adacore.com>
1385
1386         * python/py-prettyprint.c (print_string_repr): Remove #if.
1387         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
1388
1389 2019-03-05  Tom Tromey  <tromey@adacore.com>
1390
1391         * target.c (the_dummy_target): Move later.  Change type to
1392         "dummy_target".
1393         (initialize_targets): Don't initialize the_dummy_target.
1394
1395 2019-03-05  Tom Tromey  <tromey@adacore.com>
1396
1397         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
1398         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
1399
1400 2019-03-05  Tom Tromey  <tromey@adacore.com>
1401
1402         * windows-nat.c (windows_nat_target::attach)
1403         (windows_nat_target::detach): Don't call gdb_flush.
1404         * valprint.c (generic_val_print, val_print, val_print_string):
1405         Don't call gdb_flush.
1406         * utils.c (defaulted_query): Don't call gdb_flush.
1407         * typeprint.c (print_type_scalar): Don't call gdb_flush.
1408         * target.c (target_announce_detach): Don't call gdb_flush.
1409         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
1410         * remote.c (extended_remote_target::attach): Don't call
1411         gdb_flush.
1412         * procfs.c (procfs_target::detach): Don't call gdb_flush.
1413         * printcmd.c (do_examine): Don't call gdb_flush.
1414         (info_display_command): Don't call gdb_flush.
1415         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
1416         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
1417         * memattr.c (info_mem_command): Don't call gdb_flush.
1418         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
1419         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
1420         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
1421         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
1422         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
1423         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
1424         (gnu_nat_target::detach): Don't call gdb_flush.
1425         * f-valprint.c (f_val_print): Don't call gdb_flush.
1426         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
1427         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
1428         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
1429         gdb_flush.
1430         * c-valprint.c (c_val_print): Don't call gdb_flush.
1431         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
1432
1433 2019-03-05  Tom Tromey  <tromey@adacore.com>
1434
1435         * varobj.c (update_dynamic_varobj_children): Update.
1436         (install_default_visualizer): Use reset, not release.
1437         * value.c (set_internalvar): Update.
1438         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
1439         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
1440         ATTRIBUTE_UNUSED_RESULT.
1441
1442 2019-03-05  Tom Tromey  <tromey@adacore.com>
1443
1444         * remote.c (class scoped_remote_fd) <release>: Add
1445         ATTRIBUTE_UNUSED_RESULT.
1446
1447 2019-03-05  Tom Tromey  <tromey@adacore.com>
1448
1449         * macroexp.c (struct macro_buffer) <release>: Add
1450         ATTRIBUTE_UNUSED_RESULT.
1451
1452 2019-03-05  Tom Tromey  <tromey@adacore.com>
1453
1454         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
1455         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
1456         ATTRIBUTE_UNUSED_RESULT.
1457
1458 2019-03-05  Tom Tromey  <tromey@adacore.com>
1459
1460         * common/scoped_fd.h (class scoped_fd) <release>: Add
1461         ATTRIBUTE_UNUSED_RESULT.
1462
1463 2019-03-05  Tom Tromey  <tromey@adacore.com>
1464
1465         * parser-defs.h (struct parser_state) <release>: Add
1466         ATTRIBUTE_UNUSED_RESULT.
1467
1468 2019-03-05  Tom Tromey  <tromey@adacore.com>
1469
1470         * utils.h (class gdb_argv) <release>: Add
1471         ATTRIBUTE_UNUSED_RESULT.
1472         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
1473
1474 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
1475
1476         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
1477         for-loop range, to avoid compiler warnings.
1478
1479         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
1480         avoid compiler warnings about unused variables.
1481
1482         * NEWS: Mention end of support for native debugging on MS-Windows
1483         before XP.
1484
1485         PR gdb/24292
1486         * common/netstuff.c:
1487         * gdbserver/gdbreplay.c
1488         * gdbserver/remote-utils.c:
1489         * ser-tcp.c:
1490         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
1491         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
1492         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
1493         'getaddrinfo' and 'freeaddrinfo' were not available before
1494         Windows XP, and mingw.org's MinGW headers by default define
1495         _WIN32_WINNT to 0x500.
1496
1497 2019-03-01  Gary Benson <gbenson@redhat.com>
1498
1499         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
1500
1501 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
1502             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1503
1504         PR gdb/8527
1505         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
1506         set_sigint_trap, clear_sigint_trap.
1507
1508 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1509
1510         * target.c (target_detach): Clear the regcache and the
1511         frame cache.
1512
1513 2019-02-27  Pedro Alves  <palves@redhat.com>
1514
1515         * utils.c (set_screen_size): When we cap the height/width sizes,
1516         tweak the corresponding command variable to show "unlimited":
1517
1518 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
1519             Pedro Alves  <palves@redhat.com>
1520
1521         * utils.c (set_screen_size): Reduce "infinite" rows and columns
1522         before calling rl_set_screen_size.
1523
1524 2019-02-27  Tom Tromey  <tromey@adacore.com>
1525
1526         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
1527         define.
1528         * python/py-value.c: Remove Python 2.4 workaround.
1529         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
1530         workaround.
1531         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
1532         Python 2.4 workaround.
1533         * python/python-internal.h: Remove Python 2.4 comment.
1534         (Py_ssize_t): Don't define.
1535         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
1536         (gdb_Py_DECREF): Remove Python 2.4 workaround.
1537         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
1538         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
1539         * python/python.c (do_start_initialization): Remove Python 2.4
1540         workaround.
1541         * python/py-prettyprint.c (class dummy_python_frame): Remove.
1542         (print_children): Remove Python 2.4 workaround.
1543         * python/py-inferior.c (buffer_procs): Remove Python 2.4
1544         workaround.
1545         (CHARBUFFERPROC_NAME): Remove.
1546         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
1547         Python 2.4 workaround.
1548
1549 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1550
1551         * NEWS: Note minimum Python version.
1552
1553 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1554
1555         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
1556         code from these functions.  Remove corresponding ifdefs.  Use
1557         Py_buffer_up instead of explicit calls to PyBuffer_Release.
1558         Remove gotos and target of gotos.
1559         (infpy_search_memory): Likewise.
1560
1561 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1562
1563         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
1564         (hppa_gdbarch_init): Don't register deleted functions with
1565         gdbarch.
1566
1567 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1568
1569         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
1570         (h8300_unwind_sp): Delete.
1571         (h8300_dummy_id): Delete.
1572         (h8300_gdbarch_init): Don't register deleted functions with
1573         gdbarch.
1574
1575 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1576
1577         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
1578         (ft32_unwind_pc): Delete.
1579         (ft32_unwind_sp): Delete.
1580         (ft32_gdbarch_init): Don't register deleted functions with
1581         gdbarch.
1582
1583 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1584
1585         * gdb/frv-tdep.c (frv_dummy_id): Delete.
1586         (frv_unwind_pc): Delete.
1587         (frv_unwind_sp): Delete.
1588         (frv_gdbarch_init): Don't register deleted functions with
1589         gdbarch.
1590
1591 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1592
1593         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
1594         (riscv_unwind_pc): Delete.
1595         (riscv_unwind_sp): Delete.
1596         (riscv_gdbarch_init): Don't register deleted functions with
1597         gdbarch.
1598
1599 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1600
1601         * gdb/csky-tdep.c (csky_dummy_id): Delete.
1602         (csky_unwind_pc): Delete.
1603         (csky_unwind_sp): Delete.
1604         (csky_gdbarch_init): Don't register deleted functions with
1605         gdbarch.
1606
1607 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1608
1609         * gdb/cris-tdep.c (cris_dummy_id): Delete.
1610         (cris_unwind_pc): Delete.
1611         (cris_unwind_sp): Delete.
1612         (cris_gdbarch_init): Don't register deleted functions with
1613         gdbarch.
1614
1615 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1616
1617         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
1618         (bfin_unwind_pc): Delete.
1619         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
1620
1621 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1622
1623         * gdb/arm-tdep.c (arm_dummy_id): Delete.
1624         (arm_unwind_pc): Delete.
1625         (arm_unwind_sp): Delete.
1626         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
1627
1628 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1629
1630         * gdb/arc-tdep.c (arc_dummy_id): Delete.
1631         (arc_unwind_pc): Delete.
1632         (arc_unwind_sp): Delete.
1633         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
1634
1635 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1636
1637         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
1638         (alpha_unwind_pc): Delete.
1639         (alpha_gdbarch_init): Don't register deleted functions with
1640         gdbarch.
1641
1642 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1643
1644         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
1645         (aarch64_unwind_pc): Delete.
1646         (aarch64_unwind_sp): Delete.
1647         (aarch64_gdbarch_init): Don't register deleted functions with
1648         gdbarch.
1649
1650 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1651
1652         * gdbtypes.c (type_align): Don't consider static members when
1653         computing structure alignment.
1654
1655 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1656
1657         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
1658         return 0 for other types.
1659         * arch-utils.c (default_type_align): Always return 0.
1660         * gdbarch.h: Regenerate.
1661         * gdbarch.sh (type_align): Extend comment.
1662         * gdbtypes.c (type_align): Add additional comments, always call
1663         gdbarch_type_align before applying the default rules.
1664         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
1665         generic code will then apply a suitable default.
1666         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
1667         types, return 0 for other types.
1668
1669 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1670
1671         * NEWS: Create a new section for the next release branch.
1672         Rename the section of the current branch, now that it has
1673         been cut.
1674
1675 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1676
1677         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
1678         * version.in: Bump version to 8.3.50.DATE-git.
1679
1680 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
1681
1682         * aix-thread.c (ptid_cmp): Remove unused variable.
1683         (get_signaled_thread): Likewise.
1684         (store_regs_user_thread): Likewise.
1685         (store_regs_kernel_thread): Likewise.
1686         (fetch_regs_kernel_thread): Remove shadowed variable.
1687
1688 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1689
1690         * features/riscv/32bit-cpu.xml: Add register numbers.
1691         * features/riscv/32bit-fpu.c: Regenerate.
1692         * features/riscv/32bit-fpu.xml: Add register numbers.
1693         * features/riscv/64bit-cpu.xml: Add register numbers.
1694         * features/riscv/64bit-fpu.c: Regenerate.
1695         * features/riscv/64bit-fpu.xml: Add register numbers.
1696
1697 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
1698
1699         * NEWS: Mention two argument form of gdb.Value constructor.
1700         * python/py-value.c (convert_buffer_and_type_to_value): New
1701         function.
1702         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
1703         Add support for handling an optional second argument.  Call
1704         convert_buffer_and_type_to_value as appropriate.
1705         * python/python-internal.h (Py_buffer_deleter): New struct.
1706         (Py_buffer_up): New typedef.
1707
1708 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
1709
1710         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
1711         instead of releasing ownership.
1712
1713 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
1714
1715         * dwarf2read.c (open_and_init_dwp_file): Call
1716         elf_numsections instead of bfd_count_sections to initialize
1717         dwp_file->num_sections.
1718
1719 2019-02-25  Tom Tromey  <tromey@adacore.com>
1720
1721         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
1722
1723 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1724
1725         * gcore.in: Add '--readnever' option when invoking GDB.
1726
1727 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1728
1729         * MAINTAINERS: Update my email address.
1730
1731 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1732
1733         * build-id.c (build_id_to_debug_bfd_1): New function.
1734         (build_id_to_debug_bfd): Look for separate debug file in
1735         sysroot.
1736
1737 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1738
1739         * gdbarch.sh: Update the copyright year range that is placed into
1740         generated files.
1741
1742 2019-02-22  Keith Seitz  <keiths@redhat.com>
1743
1744         PR symtab/23853
1745         * linespec.c (create_sals_line_offset): Search for the default
1746         symtab's filename instead of its fullname.
1747
1748 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1749
1750         * NEWS: Update style defaults.
1751
1752 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1753
1754         * main.c (captured_main_1): Disable styling in batch mode.
1755
1756 2019-02-20  Tom Tromey  <tom@tromey.com>
1757
1758         * symtab.c (symtab_symbol_info): Fix typos.
1759
1760 2019-02-20  Tom Tromey  <tromey@adacore.com>
1761
1762         * findcmd.c (_initialize_mem_search): Use upper case for
1763         metasyntactic variables.
1764
1765 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
1766
1767         * aarch64-tdep.c (aarch64_add_reggroups): New function.
1768         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
1769
1770 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
1771
1772         * top.h (source_file_name): Change to std::string.
1773         * top.c (source_file_name): Likewise.
1774         (command_line_input): Adjust.
1775         * cli/cli-script.c (script_from_file): Adjust.
1776
1777 2019-02-19  Tom Tromey  <tromey@adacore.com>
1778
1779         * ravenscar-thread.c
1780         (ravenscar_thread_target::update_thread_list): Don't call
1781         ada_build_task_list.
1782         * ada-lang.h (ada_build_task_list): Don't declare.
1783         * ada-tasks.c (struct ada_tasks_inferior_data)
1784         <task_list_valid_p>: Now bool.
1785         (read_known_tasks, ada_task_list_changed)
1786         (ada_tasks_invalidate_inferior_data): Update.
1787         (read_known_tasks_array): Return bool.
1788         (read_known_tasks_list): Likewise.
1789         (read_known_tasks): Return void.
1790         (ada_build_task_list): Now static.
1791
1792 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1793
1794         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
1795         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
1796
1797 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1798
1799         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
1800         variant for ada_tasks_pspace_data_handle and
1801         ada_tasks_inferior_data_handle.
1802         (ada_tasks_pspace_data_cleanup): New function.
1803         (ada_tasks_inferior_data_cleanup): New function.
1804
1805 2019-02-17  Tom Tromey  <tom@tromey.com>
1806
1807         * macrotab.h (macro_source_fullname): Return a std::string.
1808         * macrotab.c (macro_include, check_for_redefinition)
1809         (macro_undef, macro_lookup_definition, foreach_macro)
1810         (foreach_macro_in_scope): Update.
1811         (macro_source_fullname): Return a std::string.
1812         * macrocmd.c (show_pp_source_pos): Update.
1813
1814 2019-02-17  Tom Tromey  <tom@tromey.com>
1815
1816         * macrocmd.c (show_pp_source_pos): Style the file names.
1817
1818 2019-02-17  Tom Tromey  <tom@tromey.com>
1819
1820         PR tui/24197:
1821         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
1822
1823 2019-02-17  Tom Tromey  <tom@tromey.com>
1824
1825         * ada-lang.c (user_select_syms): Use filtered printing.
1826         * utils.c (wrap_style): New global.
1827         (desired_style): Remove.
1828         (emit_style_escape): Add stream parameter.
1829         (set_output_style, reset_terminal_style, prompt_for_continue):
1830         Update.
1831         (flush_wrap_buffer): Only flush gdb_stdout.
1832         (wrap_here): Set wrap_style.
1833         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
1834         treat escape sequences as a character.  Change when wrap buffer is
1835         flushed.
1836         (fputs_styled): Do not set the output style when the default is
1837         requested.
1838         * ui-style.h (struct ui_file_style) <is_default>: New method.
1839         * source.c (print_source_lines_base): Emit escape sequences in one
1840         piece.
1841
1842 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1843
1844         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
1845         integers and enumeration types.
1846
1847 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1848
1849         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
1850         instead of lookup_symbol_in_language
1851         (do_exact_match): New function.
1852         (ada_get_symbol_name_matcher): Return do_exact_match when
1853         doing a verbatim match.
1854
1855 2019-02-15  Tom Tromey  <tromey@adacore.com>
1856
1857         * ravenscar-thread.c (ravenscar_thread_target::resume)
1858         (ravenscar_thread_target::wait): Special case wildcard requests.
1859
1860 2019-02-15  Tom Tromey  <tromey@adacore.com>
1861
1862         * ravenscar-thread.c (base_ptid): Remove.
1863         (struct ravenscar_thread_target) <close>: New method.
1864         <m_base_ptid>: New member.
1865         <update_inferior_ptid, active_task, task_is_currently_active,
1866         runtime_initialized>: Declare methods.
1867         <ravenscar_thread_target>: Add constructor.
1868         (ravenscar_thread_target::task_is_currently_active)
1869         (ravenscar_thread_target::update_inferior_ptid)
1870         (ravenscar_runtime_initialized): Rename.  Now methods.
1871         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
1872         (ravenscar_thread_target::update_thread_list): Update.
1873         (ravenscar_thread_target::active_task): Now method.
1874         (ravenscar_thread_target::store_registers)
1875         (ravenscar_thread_target::prepare_to_store)
1876         (ravenscar_thread_target::prepare_to_store)
1877         (ravenscar_thread_target::mourn_inferior): Update.
1878         (ravenscar_inferior_created): Use "new" to create target.
1879         (ravenscar_thread_target::get_ada_task_ptid): Update.
1880         (_initialize_ravenscar): Don't initialize base_ptid.
1881         (ravenscar_ops): Remove global.
1882
1883 2019-02-15  Tom Tromey  <tromey@adacore.com>
1884
1885         * target.h (push_target): Declare new overload.
1886         * target.c (push_target): New overload, taking an rvalue reference.
1887         * remote.c (remote_target::open_1): Use push_target overload.
1888         * corelow.c (core_target_open): Use push_target overload.
1889
1890 2019-02-15  Tom Tromey  <tromey@adacore.com>
1891
1892         * ravenscar-thread.c (is_ravenscar_task)
1893         (ravenscar_task_is_currently_active): Return bool.
1894         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
1895         (_initialize_ravenscar): Remove "(void)".
1896         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
1897         Return bool.
1898
1899 2019-02-15  Tom Tromey  <tromey@adacore.com>
1900
1901         * ravenscar-thread.c (ravenscar_runtime_initializer)
1902         (has_ravenscar_runtime, get_running_thread_id)
1903         (ravenscar_thread_target::resume): Fix indentation.
1904
1905 2019-02-15  Tom Tromey  <tromey@adacore.com>
1906
1907         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
1908         from ravenscar_arch_ops.
1909         (sparc_ravenscar_ops::fetch_registers)
1910         (sparc_ravenscar_ops::store_registers): Now methods.
1911         (sparc_ravenscar_prepare_to_store): Remove.
1912         (sparc_ravenscar_ops): Redefine.
1913         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
1914         methods and destructor.  Remove members.
1915         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
1916         (ravenscar_thread_target::store_registers)
1917         (ravenscar_thread_target::prepare_to_store): Update.
1918         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
1919         Remove.
1920         (struct ppc_ravenscar_powerpc_ops): Derive from
1921         ravenscar_arch_ops.
1922         (ppc_ravenscar_powerpc_ops::fetch_registers)
1923         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
1924         (ppc_ravenscar_powerpc_ops): Redefine.
1925         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
1926         (ppc_ravenscar_e500_ops::fetch_registers)
1927         (ppc_ravenscar_e500_ops::store_registers): Now methods.
1928         (ppc_ravenscar_e500_ops): Redefine.
1929         * aarch64-ravenscar-thread.c
1930         (aarch64_ravenscar_generic_prepare_to_store): Remove.
1931         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
1932         (aarch64_ravenscar_fetch_registers)
1933         (aarch64_ravenscar_store_registers): Now methods.
1934         (aarch64_ravenscar_ops): Redefine.
1935
1936 2019-02-15  Tom Tromey  <tromey@adacore.com>
1937
1938         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
1939         (ravenscar_thread_target::stopped_by_hw_breakpoint)
1940         (ravenscar_thread_target::stopped_by_watchpoint)
1941         (ravenscar_thread_target::stopped_data_address)
1942         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
1943
1944 2019-02-15  Tom Tromey  <tromey@adacore.com>
1945
1946         * ravenscar-thread.c: Fix some typos.
1947
1948 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1949             Tom Tromey  <tromey@adacore.com>
1950
1951         * ada-lang.c (ada_exception_sal): Change addr_string to a
1952         std::string.
1953         (create_ada_exception_catchpoint): Update.
1954
1955 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1956             Tom Tromey  <tromey@adacore.com>
1957
1958         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
1959         (bp_location_ops): Remove.
1960         (base_breakpoint_allocate_location): Update.
1961         (free_bp_location): Update.
1962         * ada-lang.c (class ada_catchpoint_location)
1963         <ada_catchpoint_location>: Remove ops parameter.
1964         (ada_catchpoint_location_dtor): Remove.
1965         (ada_catchpoint_location_ops): Remove.
1966         (allocate_location_exception): Update.
1967         * breakpoint.h (struct bp_location_ops): Remove.
1968         (class bp_location) <bp_location>: Remove bp_location_ops
1969         parameter.
1970         <~bp_location>: Add destructor.
1971         <ops>: Remove.
1972
1973 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1974             Pedro Alves  <palves@redhat.com>
1975
1976         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
1977         'PATH_MAX'.
1978
1979 2019-02-14  David Michael  <fedora.dm0@gmail.com>
1980             Samuel Thibault  <samuel.thibault@gnu.org>
1981             Thomas Schwinge  <thomas@codesourcery.com>
1982
1983         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
1984         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
1985
1986 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1987
1988         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
1989         (check_empty): Use "const char *".
1990
1991         * gnu-nat.c (gnu_nat_target::detach): Instead of
1992         'detach_inferior (pid)' call
1993         'detach_inferior (find_inferior_pid (pid))'.
1994
1995         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
1996         'nat/fork-inferior.o'.
1997         * gnu-nat.c: #include "nat/fork-inferior.h".
1998
1999         * gnu-nat.c (gnu_nat_target::detach): Instead of
2000         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
2001         * gnu-nat.h: #include "inf-child.h".
2002         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
2003         'i386_gnu_nat_target::fetch_registers'.
2004         (gnu_store_registers): Rename/move to
2005         'i386_gnu_nat_target::store_registers'.
2006
2007         * config/i386/nm-i386gnu.h: Don't "#include" any files.
2008         * gnu-nat.h (mach_thread_info): New function.
2009         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
2010
2011         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
2012
2013 2019-02-14  Frederic Konrad  <konrad@adacore.com>
2014
2015         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
2016
2017 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
2018
2019         * windows-nat.c (windows_add_thread): Add new parameter
2020         "main_thread_p" with default value set to false.  Update
2021         function documentation as well as all callers.
2022         (windows_delete_thread): Likewise.
2023         (fake_create_process): Update call to windows_add_thread.
2024         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
2025         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
2026         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
2027         call to windows_delete_thread.
2028
2029 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
2030
2031         * MAINTAINERS: Add Andrew Burgess as global maintainer.
2032
2033 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2034
2035         * symfile.c (find_separate_debug_file): Use canonical path of
2036         sysroot with child_path instead of gdb_sysroot if it is valid.
2037
2038 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2039
2040         * symfile.c (find_separate_debug_file): Use child_path to
2041         determine if an object file is under a sysroot.
2042
2043 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2044
2045         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
2046         unittests/child-path-selftests.c.
2047         * common/pathstuff.c (child_path): New function.
2048         * common/pathstuff.h (child_path): New prototype.
2049         * unittests/child-path-selftests.c: New file.
2050
2051 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2052
2053         * symfile.c (find_separate_debug_file): Look for separate debug
2054         files in debug directories under the sysroot.
2055
2056 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2057
2058         * symtab.h (struct minimal_symbol data_p): New const method.
2059         (struct minimal_symbol text_p): Likewise.
2060         * symtab.c (output_source_filename): Use file name style
2061         to print file name.
2062         (print_symbol_info): Likewise.
2063         (print_msymbol_info): Use address style to print addresses.
2064         Use function name style to print executable text symbols.
2065         (expand_symtab_containing_pc): Use data_p.
2066         (find_pc_sect_compunit_symtab): Likewise.
2067
2068 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2069
2070         * breakpoint.c (describe_other_breakpoints): Use address style
2071         to print addresses.
2072         (say_where): Likewise.
2073
2074 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2075
2076         * ada-typeprint.c (print_func_type): Print function name
2077         style to print function name.
2078         * c-typeprint.c (c_print_type_1): Likewise.
2079
2080 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
2081
2082         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
2083         for execve.
2084
2085 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2086
2087         * c-exp.y (direct_abs_decl): Use emplace_back to record the
2088         type_stack.
2089
2090 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
2091
2092         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
2093         TYPE_CODE_REF types.
2094
2095 2019-02-08  Jim Wilson  <jimw@sifive.com>
2096
2097         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
2098         (riscv_linux_fregset): New.
2099         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
2100
2101 2019-02-07  Tom Tromey  <tom@tromey.com>
2102
2103         * thread.c (thread_cancel_execution_command): Update.
2104         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
2105         methods.
2106         (struct thread_fsm_ops): Remove.
2107         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
2108         (thread_fsm_should_stop, thread_fsm_return_value)
2109         (thread_fsm_set_finished, thread_fsm_finished_p)
2110         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
2111         Don't declare.
2112         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
2113         * infrun.c (clear_proceed_status_thread)
2114         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
2115         (print_stop_event): Update.
2116         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
2117         Add constructor.
2118         (step_command_fsm_ops): Remove.
2119         (new_step_command_fsm): Remove.
2120         (step_1): Update.
2121         (step_command_fsm::should_stop): Rename from
2122         step_command_fsm_should_stop.
2123         (step_command_fsm::clean_up): Rename from
2124         step_command_fsm_clean_up.
2125         (step_command_fsm::do_async_reply_reason): Rename from
2126         step_command_fsm_async_reply_reason.
2127         (struct until_next_fsm): Inherit from thread_fsm.  Add
2128         constructor.
2129         (until_next_fsm_ops): Remove.
2130         (new_until_next_fsm): Remove.
2131         (until_next_fsm::should_stop): Rename from
2132         until_next_fsm_should_stop.
2133         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
2134         (until_next_fsm::do_async_reply_reason): Rename from
2135         until_next_fsm_async_reply_reason.
2136         (struct finish_command_fsm): Inherit from thread_fsm.  Add
2137         constructor.  Change type of breakpoint.
2138         (finish_command_fsm_ops): Remove.
2139         (new_finish_command_fsm): Remove.
2140         (finish_command_fsm::should_stop): Rename from
2141         finish_command_fsm_should_stop.
2142         (finish_command_fsm::clean_up): Rename from
2143         finish_command_fsm_clean_up.
2144         (finish_command_fsm::return_value): Rename from
2145         finish_command_fsm_return_value.
2146         (finish_command_fsm::do_async_reply_reason): Rename from
2147         finish_command_fsm_async_reply_reason.
2148         (finish_command): Update.
2149         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
2150         Add constructor.
2151         (call_thread_fsm_ops): Remove.
2152         (call_thread_fsm::call_thread_fsm): Rename from
2153         new_call_thread_fsm.
2154         (call_thread_fsm::should_stop): Rename from
2155         call_thread_fsm_should_stop.
2156         (call_thread_fsm::should_notify_stop): Rename from
2157         call_thread_fsm_should_notify_stop.
2158         (run_inferior_call, call_function_by_hand_dummy): Update.
2159         * cli/cli-interp.c (should_print_stop_to_console): Update.
2160         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
2161         Add constructor.  Change type of location_breakpoint,
2162         caller_breakpoint.
2163         (until_break_fsm_ops): Remove.
2164         (new_until_break_fsm): Remove.
2165         (until_break_fsm::should_stop): Rename from
2166         until_break_fsm_should_stop.
2167         (until_break_fsm::clean_up): Rename from
2168         until_break_fsm_clean_up.
2169         (until_break_fsm::do_async_reply_reason): Rename from
2170         until_break_fsm_async_reply_reason.
2171         (until_break_command): Update.
2172         * thread-fsm.c: Remove.
2173         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
2174
2175 2019-02-07  Tom Tromey  <tom@tromey.com>
2176
2177         * yy-remap.h: Add include guard.
2178         * xtensa-tdep.h: Add include guard.
2179         * xcoffread.h: Rename include guard.
2180         * varobj-iter.h: Add include guard.
2181         * tui/tui.h: Rename include guard.
2182         * tui/tui-winsource.h: Rename include guard.
2183         * tui/tui-wingeneral.h: Rename include guard.
2184         * tui/tui-windata.h: Rename include guard.
2185         * tui/tui-win.h: Rename include guard.
2186         * tui/tui-stack.h: Rename include guard.
2187         * tui/tui-source.h: Rename include guard.
2188         * tui/tui-regs.h: Rename include guard.
2189         * tui/tui-out.h: Rename include guard.
2190         * tui/tui-layout.h: Rename include guard.
2191         * tui/tui-io.h: Rename include guard.
2192         * tui/tui-hooks.h: Rename include guard.
2193         * tui/tui-file.h: Rename include guard.
2194         * tui/tui-disasm.h: Rename include guard.
2195         * tui/tui-data.h: Rename include guard.
2196         * tui/tui-command.h: Rename include guard.
2197         * tic6x-tdep.h: Add include guard.
2198         * target/waitstatus.h: Rename include guard.
2199         * target/wait.h: Rename include guard.
2200         * target/target.h: Rename include guard.
2201         * target/resume.h: Rename include guard.
2202         * target-float.h: Rename include guard.
2203         * stabsread.h: Add include guard.
2204         * rs6000-tdep.h: Add include guard.
2205         * riscv-fbsd-tdep.h: Add include guard.
2206         * regformats/regdef.h: Rename include guard.
2207         * record.h: Rename include guard.
2208         * python/python.h: Rename include guard.
2209         * python/python-internal.h: Rename include guard.
2210         * python/py-stopevent.h: Rename include guard.
2211         * python/py-ref.h: Rename include guard.
2212         * python/py-record.h: Rename include guard.
2213         * python/py-record-full.h: Rename include guard.
2214         * python/py-record-btrace.h: Rename include guard.
2215         * python/py-instruction.h: Rename include guard.
2216         * python/py-events.h: Rename include guard.
2217         * python/py-event.h: Rename include guard.
2218         * procfs.h: Add include guard.
2219         * proc-utils.h: Add include guard.
2220         * p-lang.h: Add include guard.
2221         * or1k-tdep.h: Rename include guard.
2222         * observable.h: Rename include guard.
2223         * nto-tdep.h: Rename include guard.
2224         * nat/x86-linux.h: Rename include guard.
2225         * nat/x86-linux-dregs.h: Rename include guard.
2226         * nat/x86-gcc-cpuid.h: Add include guard.
2227         * nat/x86-dregs.h: Rename include guard.
2228         * nat/x86-cpuid.h: Rename include guard.
2229         * nat/ppc-linux.h: Rename include guard.
2230         * nat/mips-linux-watch.h: Rename include guard.
2231         * nat/linux-waitpid.h: Rename include guard.
2232         * nat/linux-ptrace.h: Rename include guard.
2233         * nat/linux-procfs.h: Rename include guard.
2234         * nat/linux-osdata.h: Rename include guard.
2235         * nat/linux-nat.h: Rename include guard.
2236         * nat/linux-namespaces.h: Rename include guard.
2237         * nat/linux-btrace.h: Rename include guard.
2238         * nat/glibc_thread_db.h: Rename include guard.
2239         * nat/gdb_thread_db.h: Rename include guard.
2240         * nat/gdb_ptrace.h: Rename include guard.
2241         * nat/fork-inferior.h: Rename include guard.
2242         * nat/amd64-linux-siginfo.h: Rename include guard.
2243         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
2244         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
2245         * nat/aarch64-linux.h: Rename include guard.
2246         * nat/aarch64-linux-hw-point.h: Rename include guard.
2247         * mn10300-tdep.h: Add include guard.
2248         * mips-linux-tdep.h: Add include guard.
2249         * mi/mi-parse.h: Rename include guard.
2250         * mi/mi-out.h: Rename include guard.
2251         * mi/mi-main.h: Rename include guard.
2252         * mi/mi-interp.h: Rename include guard.
2253         * mi/mi-getopt.h: Rename include guard.
2254         * mi/mi-console.h: Rename include guard.
2255         * mi/mi-common.h: Rename include guard.
2256         * mi/mi-cmds.h: Rename include guard.
2257         * mi/mi-cmd-break.h: Rename include guard.
2258         * m2-lang.h: Add include guard.
2259         * location.h: Rename include guard.
2260         * linux-record.h: Rename include guard.
2261         * linux-nat.h: Add include guard.
2262         * linux-fork.h: Add include guard.
2263         * i386-darwin-tdep.h: Rename include guard.
2264         * hppa-linux-offsets.h: Add include guard.
2265         * guile/guile.h: Rename include guard.
2266         * guile/guile-internal.h: Rename include guard.
2267         * gnu-nat.h: Rename include guard.
2268         * gdb-stabs.h: Rename include guard.
2269         * frv-tdep.h: Add include guard.
2270         * f-lang.h: Add include guard.
2271         * event-loop.h: Add include guard.
2272         * darwin-nat.h: Rename include guard.
2273         * cp-abi.h: Rename include guard.
2274         * config/sparc/nm-sol2.h: Rename include guard.
2275         * config/nm-nto.h: Rename include guard.
2276         * config/nm-linux.h: Add include guard.
2277         * config/i386/nm-i386gnu.h: Rename include guard.
2278         * config/djgpp/nl_types.h: Rename include guard.
2279         * config/djgpp/langinfo.h: Rename include guard.
2280         * compile/gcc-cp-plugin.h: Add include guard.
2281         * compile/gcc-c-plugin.h: Add include guard.
2282         * compile/compile.h: Rename include guard.
2283         * compile/compile-object-run.h: Rename include guard.
2284         * compile/compile-object-load.h: Rename include guard.
2285         * compile/compile-internal.h: Rename include guard.
2286         * compile/compile-cplus.h: Rename include guard.
2287         * compile/compile-c.h: Rename include guard.
2288         * common/xml-utils.h: Rename include guard.
2289         * common/x86-xstate.h: Rename include guard.
2290         * common/version.h: Rename include guard.
2291         * common/vec.h: Rename include guard.
2292         * common/tdesc.h: Rename include guard.
2293         * common/selftest.h: Rename include guard.
2294         * common/scoped_restore.h: Rename include guard.
2295         * common/scoped_mmap.h: Rename include guard.
2296         * common/scoped_fd.h: Rename include guard.
2297         * common/safe-iterator.h: Rename include guard.
2298         * common/run-time-clock.h: Rename include guard.
2299         * common/refcounted-object.h: Rename include guard.
2300         * common/queue.h: Rename include guard.
2301         * common/ptid.h: Rename include guard.
2302         * common/print-utils.h: Rename include guard.
2303         * common/preprocessor.h: Rename include guard.
2304         * common/pathstuff.h: Rename include guard.
2305         * common/observable.h: Rename include guard.
2306         * common/netstuff.h: Rename include guard.
2307         * common/job-control.h: Rename include guard.
2308         * common/host-defs.h: Rename include guard.
2309         * common/gdb_wait.h: Rename include guard.
2310         * common/gdb_vecs.h: Rename include guard.
2311         * common/gdb_unlinker.h: Rename include guard.
2312         * common/gdb_unique_ptr.h: Rename include guard.
2313         * common/gdb_tilde_expand.h: Rename include guard.
2314         * common/gdb_sys_time.h: Rename include guard.
2315         * common/gdb_string_view.h: Rename include guard.
2316         * common/gdb_splay_tree.h: Rename include guard.
2317         * common/gdb_setjmp.h: Rename include guard.
2318         * common/gdb_ref_ptr.h: Rename include guard.
2319         * common/gdb_optional.h: Rename include guard.
2320         * common/gdb_locale.h: Rename include guard.
2321         * common/gdb_assert.h: Rename include guard.
2322         * common/filtered-iterator.h: Rename include guard.
2323         * common/filestuff.h: Rename include guard.
2324         * common/fileio.h: Rename include guard.
2325         * common/environ.h: Rename include guard.
2326         * common/common-utils.h: Rename include guard.
2327         * common/common-types.h: Rename include guard.
2328         * common/common-regcache.h: Rename include guard.
2329         * common/common-inferior.h: Rename include guard.
2330         * common/common-gdbthread.h: Rename include guard.
2331         * common/common-exceptions.h: Rename include guard.
2332         * common/common-defs.h: Rename include guard.
2333         * common/common-debug.h: Rename include guard.
2334         * common/cleanups.h: Rename include guard.
2335         * common/buffer.h: Rename include guard.
2336         * common/btrace-common.h: Rename include guard.
2337         * common/break-common.h: Rename include guard.
2338         * cli/cli-utils.h: Rename include guard.
2339         * cli/cli-style.h: Rename include guard.
2340         * cli/cli-setshow.h: Rename include guard.
2341         * cli/cli-script.h: Rename include guard.
2342         * cli/cli-interp.h: Rename include guard.
2343         * cli/cli-decode.h: Rename include guard.
2344         * cli/cli-cmds.h: Rename include guard.
2345         * charset-list.h: Add include guard.
2346         * buildsym-legacy.h: Rename include guard.
2347         * bfin-tdep.h: Add include guard.
2348         * ax.h: Rename include guard.
2349         * arm-linux-tdep.h: Add include guard.
2350         * arm-fbsd-tdep.h: Add include guard.
2351         * arch/xtensa.h: Rename include guard.
2352         * arch/tic6x.h: Add include guard.
2353         * arch/i386.h: Add include guard.
2354         * arch/arm.h: Rename include guard.
2355         * arch/arm-linux.h: Rename include guard.
2356         * arch/arm-get-next-pcs.h: Rename include guard.
2357         * arch/amd64.h: Add include guard.
2358         * arch/aarch64-insn.h: Rename include guard.
2359         * arch-utils.h: Rename include guard.
2360         * annotate.h: Add include guard.
2361         * amd64-darwin-tdep.h: Rename include guard.
2362         * aarch64-linux-tdep.h: Add include guard.
2363         * aarch64-fbsd-tdep.h: Add include guard.
2364         * aarch32-linux-nat.h: Add include guard.
2365
2366 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2367
2368         * macrotab.c (macro_define_internal): New function that
2369         factorizes macro_define_object_internal and macro_define_function
2370         code.
2371         (macro_define_object_internal): Use macro_define_internal.
2372         (macro_define_function): Likewise.
2373
2374 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2375
2376         * macrocmd.c (extract_identifier): Return
2377         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
2378         callers.
2379
2380 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
2381
2382         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
2383
2384 2019-02-05  Tom Tromey  <tom@tromey.com>
2385
2386         * target.c (target_stack::unpush): Move assertion earlier.
2387
2388 2019-01-30  Tom Tromey  <tom@tromey.com>
2389
2390         PR python/23615:
2391         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
2392         (gdbpy_parse_and_eval): Likewise.
2393         * python/python-internal.h (gdbpy_allow_threads): New class.
2394
2395 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
2396
2397         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
2398         (aarch64_fbsd_fpregmap): Move earlier.
2399         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
2400         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2401         instead of individual calls to trad_frame_set_reg_addr.
2402         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
2403         earlier.
2404         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
2405         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2406         instead of individual calls to trad_frame_set_reg_addr.
2407
2408 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
2409
2410         * CONTRIBUTE: Replace contribution list with wiki link.
2411
2412 2019-01-25  Tom Tromey  <tom@tromey.com>
2413
2414         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
2415
2416 2019-01-25  Tom Tromey  <tom@tromey.com>
2417
2418         * xtensa-linux-nat.c: Fix common/ includes.
2419         * xml-support.h: Fix common/ includes.
2420         * xml-support.c: Fix common/ includes.
2421         * x86-linux-nat.c: Fix common/ includes.
2422         * windows-nat.c: Fix common/ includes.
2423         * varobj.h: Fix common/ includes.
2424         * varobj.c: Fix common/ includes.
2425         * value.c: Fix common/ includes.
2426         * valops.c: Fix common/ includes.
2427         * utils.c: Fix common/ includes.
2428         * unittests/xml-utils-selftests.c: Fix common/ includes.
2429         * unittests/utils-selftests.c: Fix common/ includes.
2430         * unittests/unpack-selftests.c: Fix common/ includes.
2431         * unittests/tracepoint-selftests.c: Fix common/ includes.
2432         * unittests/style-selftests.c: Fix common/ includes.
2433         * unittests/string_view-selftests.c: Fix common/ includes.
2434         * unittests/scoped_restore-selftests.c: Fix common/ includes.
2435         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
2436         * unittests/scoped_fd-selftests.c: Fix common/ includes.
2437         * unittests/rsp-low-selftests.c: Fix common/ includes.
2438         * unittests/parse-connection-spec-selftests.c: Fix common/
2439         includes.
2440         * unittests/optional-selftests.c: Fix common/ includes.
2441         * unittests/offset-type-selftests.c: Fix common/ includes.
2442         * unittests/observable-selftests.c: Fix common/ includes.
2443         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
2444         * unittests/memrange-selftests.c: Fix common/ includes.
2445         * unittests/memory-map-selftests.c: Fix common/ includes.
2446         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
2447         * unittests/function-view-selftests.c: Fix common/ includes.
2448         * unittests/environ-selftests.c: Fix common/ includes.
2449         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
2450         * unittests/common-utils-selftests.c: Fix common/ includes.
2451         * unittests/cli-utils-selftests.c: Fix common/ includes.
2452         * unittests/array-view-selftests.c: Fix common/ includes.
2453         * ui-file.c: Fix common/ includes.
2454         * tui/tui-io.c: Fix common/ includes.
2455         * tracepoint.h: Fix common/ includes.
2456         * tracepoint.c: Fix common/ includes.
2457         * tracefile-tfile.c: Fix common/ includes.
2458         * top.h: Fix common/ includes.
2459         * top.c: Fix common/ includes.
2460         * thread.c: Fix common/ includes.
2461         * target/waitstatus.h: Fix common/ includes.
2462         * target/waitstatus.c: Fix common/ includes.
2463         * target.h: Fix common/ includes.
2464         * target.c: Fix common/ includes.
2465         * target-memory.c: Fix common/ includes.
2466         * target-descriptions.c: Fix common/ includes.
2467         * symtab.h: Fix common/ includes.
2468         * symfile.c: Fix common/ includes.
2469         * stap-probe.c: Fix common/ includes.
2470         * spu-linux-nat.c: Fix common/ includes.
2471         * sparc-nat.c: Fix common/ includes.
2472         * source.c: Fix common/ includes.
2473         * solib.c: Fix common/ includes.
2474         * solib-target.c: Fix common/ includes.
2475         * ser-unix.c: Fix common/ includes.
2476         * ser-tcp.c: Fix common/ includes.
2477         * ser-pipe.c: Fix common/ includes.
2478         * ser-base.c: Fix common/ includes.
2479         * selftest-arch.c: Fix common/ includes.
2480         * s12z-tdep.c: Fix common/ includes.
2481         * rust-exp.y: Fix common/ includes.
2482         * rs6000-aix-tdep.c: Fix common/ includes.
2483         * riscv-tdep.c: Fix common/ includes.
2484         * remote.c: Fix common/ includes.
2485         * remote-notif.h: Fix common/ includes.
2486         * remote-fileio.h: Fix common/ includes.
2487         * remote-fileio.c: Fix common/ includes.
2488         * regcache.h: Fix common/ includes.
2489         * regcache.c: Fix common/ includes.
2490         * record-btrace.c: Fix common/ includes.
2491         * python/python.c: Fix common/ includes.
2492         * python/py-type.c: Fix common/ includes.
2493         * python/py-inferior.c: Fix common/ includes.
2494         * progspace.h: Fix common/ includes.
2495         * producer.c: Fix common/ includes.
2496         * procfs.c: Fix common/ includes.
2497         * proc-api.c: Fix common/ includes.
2498         * printcmd.c: Fix common/ includes.
2499         * ppc-linux-nat.c: Fix common/ includes.
2500         * parser-defs.h: Fix common/ includes.
2501         * osdata.c: Fix common/ includes.
2502         * obsd-nat.c: Fix common/ includes.
2503         * nat/x86-linux.c: Fix common/ includes.
2504         * nat/x86-linux-dregs.c: Fix common/ includes.
2505         * nat/x86-dregs.h: Fix common/ includes.
2506         * nat/x86-dregs.c: Fix common/ includes.
2507         * nat/ppc-linux.c: Fix common/ includes.
2508         * nat/mips-linux-watch.h: Fix common/ includes.
2509         * nat/mips-linux-watch.c: Fix common/ includes.
2510         * nat/linux-waitpid.c: Fix common/ includes.
2511         * nat/linux-ptrace.h: Fix common/ includes.
2512         * nat/linux-ptrace.c: Fix common/ includes.
2513         * nat/linux-procfs.c: Fix common/ includes.
2514         * nat/linux-personality.c: Fix common/ includes.
2515         * nat/linux-osdata.c: Fix common/ includes.
2516         * nat/linux-namespaces.c: Fix common/ includes.
2517         * nat/linux-btrace.h: Fix common/ includes.
2518         * nat/linux-btrace.c: Fix common/ includes.
2519         * nat/fork-inferior.c: Fix common/ includes.
2520         * nat/amd64-linux-siginfo.c: Fix common/ includes.
2521         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
2522         * nat/aarch64-linux.c: Fix common/ includes.
2523         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
2524         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
2525         * namespace.h: Fix common/ includes.
2526         * mips-linux-tdep.c: Fix common/ includes.
2527         * minsyms.c: Fix common/ includes.
2528         * mi/mi-parse.h: Fix common/ includes.
2529         * mi/mi-main.c: Fix common/ includes.
2530         * mi/mi-cmd-env.c: Fix common/ includes.
2531         * memrange.h: Fix common/ includes.
2532         * memattr.c: Fix common/ includes.
2533         * maint.h: Fix common/ includes.
2534         * maint.c: Fix common/ includes.
2535         * main.c: Fix common/ includes.
2536         * machoread.c: Fix common/ includes.
2537         * location.c: Fix common/ includes.
2538         * linux-thread-db.c: Fix common/ includes.
2539         * linux-nat.c: Fix common/ includes.
2540         * linux-fork.c: Fix common/ includes.
2541         * inline-frame.c: Fix common/ includes.
2542         * infrun.c: Fix common/ includes.
2543         * inflow.c: Fix common/ includes.
2544         * inferior.h: Fix common/ includes.
2545         * inferior.c: Fix common/ includes.
2546         * infcmd.c: Fix common/ includes.
2547         * inf-ptrace.c: Fix common/ includes.
2548         * inf-child.c: Fix common/ includes.
2549         * ia64-linux-nat.c: Fix common/ includes.
2550         * i387-tdep.c: Fix common/ includes.
2551         * i386-tdep.c: Fix common/ includes.
2552         * i386-linux-tdep.c: Fix common/ includes.
2553         * i386-linux-nat.c: Fix common/ includes.
2554         * i386-go32-tdep.c: Fix common/ includes.
2555         * i386-fbsd-tdep.c: Fix common/ includes.
2556         * i386-fbsd-nat.c: Fix common/ includes.
2557         * guile/scm-type.c: Fix common/ includes.
2558         * guile/guile.c: Fix common/ includes.
2559         * go32-nat.c: Fix common/ includes.
2560         * gnu-nat.c: Fix common/ includes.
2561         * gdbthread.h: Fix common/ includes.
2562         * gdbarch-selftests.c: Fix common/ includes.
2563         * gdb_usleep.c: Fix common/ includes.
2564         * gdb_select.h: Fix common/ includes.
2565         * gdb_bfd.c: Fix common/ includes.
2566         * gcore.c: Fix common/ includes.
2567         * fork-child.c: Fix common/ includes.
2568         * findvar.c: Fix common/ includes.
2569         * fbsd-nat.c: Fix common/ includes.
2570         * event-top.c: Fix common/ includes.
2571         * event-loop.c: Fix common/ includes.
2572         * dwarf2read.c: Fix common/ includes.
2573         * dwarf2loc.c: Fix common/ includes.
2574         * dwarf2-frame.c: Fix common/ includes.
2575         * dwarf-index-cache.c: Fix common/ includes.
2576         * dtrace-probe.c: Fix common/ includes.
2577         * disasm-selftests.c: Fix common/ includes.
2578         * defs.h: Fix common/ includes.
2579         * csky-tdep.c: Fix common/ includes.
2580         * cp-valprint.c: Fix common/ includes.
2581         * cp-support.h: Fix common/ includes.
2582         * cp-support.c: Fix common/ includes.
2583         * corelow.c: Fix common/ includes.
2584         * completer.h: Fix common/ includes.
2585         * completer.c: Fix common/ includes.
2586         * compile/compile.c: Fix common/ includes.
2587         * compile/compile-loc2c.c: Fix common/ includes.
2588         * compile/compile-cplus-types.c: Fix common/ includes.
2589         * compile/compile-cplus-symbols.c: Fix common/ includes.
2590         * command.h: Fix common/ includes.
2591         * cli/cli-dump.c: Fix common/ includes.
2592         * cli/cli-cmds.c: Fix common/ includes.
2593         * charset.c: Fix common/ includes.
2594         * build-id.c: Fix common/ includes.
2595         * btrace.h: Fix common/ includes.
2596         * btrace.c: Fix common/ includes.
2597         * breakpoint.h: Fix common/ includes.
2598         * breakpoint.c: Fix common/ includes.
2599         * ax.h:
2600         (enum agent_op): Fix common/ includes.
2601         * ax-general.c (struct aop_map): Fix common/ includes.
2602         * ax-gdb.c: Fix common/ includes.
2603         * auxv.c: Fix common/ includes.
2604         * auto-load.c: Fix common/ includes.
2605         * arm-tdep.c: Fix common/ includes.
2606         * arch/riscv.c: Fix common/ includes.
2607         * arch/ppc-linux-common.c: Fix common/ includes.
2608         * arch/i386.c: Fix common/ includes.
2609         * arch/arm.c: Fix common/ includes.
2610         * arch/arm-linux.c: Fix common/ includes.
2611         * arch/arm-get-next-pcs.c: Fix common/ includes.
2612         * arch/amd64.c: Fix common/ includes.
2613         * arch/aarch64.c: Fix common/ includes.
2614         * arch/aarch64-insn.c: Fix common/ includes.
2615         * arch-utils.c: Fix common/ includes.
2616         * amd64-windows-tdep.c: Fix common/ includes.
2617         * amd64-tdep.c: Fix common/ includes.
2618         * amd64-sol2-tdep.c: Fix common/ includes.
2619         * amd64-obsd-tdep.c: Fix common/ includes.
2620         * amd64-nbsd-tdep.c: Fix common/ includes.
2621         * amd64-linux-tdep.c: Fix common/ includes.
2622         * amd64-linux-nat.c: Fix common/ includes.
2623         * amd64-fbsd-tdep.c: Fix common/ includes.
2624         * amd64-fbsd-nat.c: Fix common/ includes.
2625         * amd64-dicos-tdep.c: Fix common/ includes.
2626         * amd64-darwin-tdep.c: Fix common/ includes.
2627         * agent.c: Fix common/ includes.
2628         * ada-lang.h: Fix common/ includes.
2629         * ada-lang.c: Fix common/ includes.
2630         * aarch64-tdep.c: Fix common/ includes.
2631
2632 2019-01-25  Tom Tromey  <tom@tromey.com>
2633
2634         * common/create-version.sh: Use common/version.h.
2635
2636 2019-01-24  Pedro Alves  <palves@redhat.com>
2637
2638         * infrun.c (signal_stop, signal_print, signal_program)
2639         (signal_catch, signal_pass): Now arrays instead of pointers.
2640         (update_signals_program_target, do_target_resume)
2641         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
2642         * linux-nat.c (linux_nat_target::pass_signals)
2643         (linux_nat_target::create_inferior, linux_nat_target::attach):
2644         Adjust.
2645         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
2646         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
2647         * procfs.c (procfs_target::pass_signals): Adjust.
2648         * record-full.c (record_full_target::resume): Adjust.
2649         * remote.c (remote_target::pass_signals)
2650         (remote_target::program_signals): Adjust.
2651         * target-debug.h (target_debug_print_signals): Now takes a
2652         gdb::array_view as parameter.  Adjust.
2653         * target.h (target_ops) <pass_signals, program_signals>: Replace
2654         pointer and length parameters with gdb::array_view.
2655         (target_pass_signals, target_program_signals): Likewise.
2656         * target-delegates.c: Regenerate.
2657
2658 2019-01-24  Pedro Alves  <palves@redhat.com>
2659
2660         * common/forward-scope-exit.h
2661         (forward_scope_exit::forward_scope_exit): Pass arguments to
2662         m_bind_function directly, instead of creating a std::bind and
2663         copying that.
2664
2665 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
2666
2667         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2668         for static members.
2669         (pass_in_v_vfp_candidate): Likewise.
2670
2671 2019-01-23  Tom Tromey  <tom@tromey.com>
2672             Pedro Alves  <palves@redhat.com>
2673
2674         * regcache.c (class regcache_invalidator): Remove.
2675         (regcache::raw_write): Use make_scope_exit.
2676
2677 2019-01-23  Tom Tromey  <tom@tromey.com>
2678
2679         * ui-out.h (class ui_out_emit_type): Update comment.
2680
2681 2019-01-23  Tom Tromey  <tom@tromey.com>
2682
2683         * infrun.c (fetch_inferior_event): Update comment.
2684
2685 2019-01-23  Tom Tromey  <tom@tromey.com>
2686             Pedro Alves  <palves@redhat.com>
2687
2688         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
2689         parameter.
2690         (fetch_inferior_event): Use SCOPE_EXIT.
2691
2692
2693 2019-01-23  Tom Tromey  <tom@tromey.com>
2694             Pedro Alves  <palves@redhat.com>
2695
2696         * infrun.c (disable_thread_events): Delete.
2697         (stop_all_threads): Use SCOPE_EXIT.
2698
2699 2019-01-23  Tom Tromey  <tom@tromey.com>
2700             Pedro Alves  <palves@redhat.com>
2701
2702         * symfile.c: Include forward-scope-exit.h.
2703         (clear_symtab_users_cleanup): Replace forward declaration with
2704         a FORWARD_SCOPE_EXIT.
2705         (syms_from_objfile_1): Use the forward_scope_exit and
2706         gdb::optional instead of cleanup_function.
2707         (reread_symbols): Use the forward_scope_exit instead of
2708         cleanup_function.
2709         (clear_symtab_users_cleanup): Remove function.
2710
2711 2019-01-23  Tom Tromey  <tom@tromey.com>
2712             Pedro Alves  <palves@redhat.com>
2713
2714         * linux-nat.c: Include scope-exit.h.
2715         (cleanup_target_stop): Remove.
2716         (linux_nat_target::static_tracepoint_markers_by_strid): Use
2717         SCOPE_EXIT.
2718
2719 2019-01-23  Tom Tromey  <tom@tromey.com>
2720             Pedro Alves  <palves@redhat.com>
2721
2722         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
2723         (call_function_by_hand_dummy): Use SCOPE_EXIT.
2724
2725 2019-01-23  Tom Tromey  <tom@tromey.com>
2726             Andrew Burgess  <andrew.burgess@embecosm.com>
2727             Pedro Alves  <palves@redhat.com>
2728
2729         * infrun.c (fetch_inferior_event): Use scope_exit.
2730         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
2731         * top.c (execute_command): Use scope_exit.
2732         * breakpoint.c (bpstat_do_actions): Use scope_exit.
2733         * utils.c (do_bpstat_clear_actions_cleanup)
2734         (make_bpstat_clear_actions_cleanup): Remove.
2735
2736 2019-01-23  Tom Tromey  <tom@tromey.com>
2737             Pedro Alves  <palves@redhat.com>
2738
2739         * infrun.c: Include "common/scope-exit.h"
2740         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
2741         (wait_for_inferior): Use SCOPE_EXIT.
2742         (fetch_inferior_event): Use scope_exit.
2743
2744 2019-01-23  Tom Tromey  <tom@tromey.com>
2745             Pedro Alves  <palves@redhat.com>
2746
2747         * breakpoint.c (create_breakpoint): Remove cleanup.
2748
2749 2019-01-23  Tom Tromey  <tom@tromey.com>
2750             Andrew Burgess  <andrew.burgess@embecosm.com>
2751             Pedro Alves  <palves@redhat.com>
2752
2753 2019-01-23  Pedro Alves  <palves@redhat.com>
2754
2755         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
2756
2757 2019-01-23  Pedro Alves  <palves@redhat.com>
2758             Andrew Burgess  <andrew.burgess@embecosm.com>
2759
2760         * gdbthread.h: Include "common/forward-scope-exit.h".
2761         (scoped_finish_thread_state): Redefine custom class in terms of
2762         forward_scope_exit.
2763
2764 2019-01-23  Pedro Alves  <palves@redhat.com>
2765             Andrew Burgess  <andrew.burgess@embecosm.com>
2766
2767         * common/forward-scope-exit.h: New file.
2768
2769 2019-01-23  Pedro Alves  <palves@redhat.com>
2770             Andrew Burgess  <andrew.burgess@embecosm.com>
2771             Tom Tromey  <tom@tromey.com>
2772
2773         * common/scope-exit.h: New file.
2774
2775 2019-01-23  Pedro Alves  <palves@redhat.com>
2776
2777         * common/preprocessor.h (ESC): Rename to ...
2778         (ESC_PARENS): ... this.
2779         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
2780         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
2781
2782 2019-01-23  Tom Tromey  <tom@tromey.com>
2783
2784         * language.h (class scoped_switch_to_sym_language_if_auto):
2785         Initialize m_lang in both cases.
2786
2787 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
2788
2789         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
2790         with XCNEW.
2791
2792 2019-01-22  Tom Tromey  <tom@tromey.com>
2793
2794         * corelow.c: Do not include sys/file.h.
2795
2796 2019-01-22  Tom Tromey  <tom@tromey.com>
2797
2798         * tui/tui-wingeneral.h: Include gdb_curses.h.
2799
2800 2019-01-22  Tom Tromey  <tom@tromey.com>
2801
2802         * source-cache.h (class source_cache) <get_source_lines,
2803         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
2804
2805 2019-01-22  Tom Tromey  <tom@tromey.com>
2806
2807         * remote-fileio.h (struct remote_target): Declare.
2808
2809 2019-01-22  Tom Tromey  <tom@tromey.com>
2810
2811         * python/py-arch.c: Do not include py-ref.h.
2812         * python/py-bpevent.c: Do not include py-ref.h.
2813         * python/py-cmd.c: Do not include py-ref.h.
2814         * python/py-continueevent.c: Do not include py-ref.h.
2815         * python/py-event.h: Do not include py-ref.h.
2816         * python/py-evtregistry.c: Do not include py-ref.h.
2817         * python/py-finishbreakpoint.c: Do not include py-ref.h.
2818         * python/py-frame.c: Do not include py-ref.h.
2819         * python/py-framefilter.c: Do not include py-ref.h.
2820         * python/py-function.c: Do not include py-ref.h.
2821         * python/py-infevents.c: Do not include py-ref.h.
2822         * python/py-linetable.c: Do not include py-ref.h.
2823         * python/py-objfile.c: Do not include py-ref.h.
2824         * python/py-param.c: Do not include py-ref.h.
2825         * python/py-prettyprint.c: Do not include py-ref.h.
2826         * python/py-progspace.c: Do not include py-ref.h.
2827         * python/py-symbol.c: Do not include py-ref.h.
2828         * python/py-symtab.c: Do not include py-ref.h.
2829         * python/py-type.c: Do not include py-ref.h.
2830         * python/py-unwind.c: Do not include py-ref.h.
2831         * python/py-utils.c: Do not include py-ref.h.
2832         * python/py-value.c: Do not include py-ref.h.
2833         * python/py-varobj.c: Do not include py-ref.h.
2834         * python/py-xmethods.c: Do not include py-ref.h.
2835         * python/python.c: Do not include py-ref.h.
2836         * varobj.c: Do not include py-ref.h.
2837
2838 2019-01-22  Tom Tromey  <tom@tromey.com>
2839
2840         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
2841         keyword for bcache.
2842
2843 2019-01-22  Tom Tromey  <tom@tromey.com>
2844
2845         * compile/compile-cplus-types.c: Remove a comment by #include.
2846
2847 2019-01-22  Tom Tromey  <tom@tromey.com>
2848
2849         * compile/gcc-c-plugin.h: Include compile-internal.h.
2850
2851 2019-01-22  Tom Tromey  <tom@tromey.com>
2852
2853         * stabsread.c (EXTERN): Do not define.
2854         (symnum, next_symbol_text_func, processing_gcc_compilation)
2855         (within_function, global_sym_chain, global_stabs)
2856         (previous_stab_code, this_object_header_files)
2857         (n_this_object_header_files)
2858         (n_allocated_this_object_header_files): Define.
2859         * stabsread.h (EXTERN): Never define.  Use "extern".
2860
2861 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2862
2863         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
2864         history_value.
2865
2866 2019-01-21  Tom Tromey  <tom@tromey.com>
2867
2868         * ui-out.c: Fix includes.
2869         * tui/tui-source.c: Fix includes.
2870         * target.c: Fix includes.
2871         * remote.c: Fix includes.
2872         * regcache.c: Fix includes.
2873         * python/py-block.c: Fix includes.
2874         * printcmd.c: Fix includes.
2875         * or1k-tdep.c: Fix includes.
2876         * mi/mi-main.c: Fix includes.
2877         * m32r-tdep.c: Fix includes.
2878         * csky-tdep.c: Fix includes.
2879         * compile/compile-cplus-types.c: Fix includes.
2880         * cli/cli-interp.c: Fix includes.
2881
2882 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
2883
2884         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2885         for padding.
2886
2887 2019-01-16  Tom Tromey  <tom@tromey.com>
2888
2889         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
2890         earlier.
2891         (struct objfile) <msymbols_range>: Move from top level.
2892         <msymbols>: New method.
2893         (class objfile_msymbols): Remove.
2894         * symtab.c (default_collect_symbol_completion_matches_break_on):
2895         Update.
2896         * symmisc.c (dump_msymbols): Update.
2897         * stabsread.c (scan_file_globals): Update.
2898         * objc-lang.c (info_selectors_command, info_classes_command)
2899         (find_methods): Update.
2900         * minsyms.c (find_solib_trampoline_target): Update.
2901         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
2902         * coffread.c (coff_symfile_read): Update.
2903         * ada-lang.c (ada_lookup_simple_minsym)
2904         (ada_collect_symbol_completion_matches): Update.
2905
2906 2019-01-16  Tom Tromey  <tom@tromey.com>
2907
2908         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
2909         type.  Remove no-argument constructor.
2910         <iterator::operator++>: Simplify.
2911         <begin>: Update.
2912         <end>: Use minimal_symbol_count.
2913
2914 2019-01-16  Tom Tromey  <tom@tromey.com>
2915
2916         * objfiles.h (struct objfile) <psymtabs>: New method.
2917         (class objfile_psymtabs): Remove.
2918         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
2919         typedef.
2920         <range>: New method.
2921         (require_partial_symbols): Change return type.
2922         * psymtab.c (require_partial_symbols)
2923         (psym_expand_symtabs_matching): Update.
2924         * mdebugread.c (parse_partial_symbols): Update.
2925         * dbxread.c (dbx_end_psymtab): Update.
2926
2927 2019-01-15  Tom Tromey  <tom@tromey.com>
2928
2929         * symtab.c (lookup_objfile_from_block)
2930         (lookup_symbol_in_objfile_symtabs)
2931         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
2932         (find_line_symtab, info_sources_command)
2933         (default_collect_symbol_completion_matches_break_on)
2934         (make_source_files_completion_list): Update.
2935         * symmisc.c (print_objfile_statistics, dump_objfile)
2936         (maintenance_print_symbols, maintenance_info_symtabs)
2937         (maintenance_check_symtabs, maintenance_info_line_tables):
2938         Update.
2939         * source.c (select_source_symtab)
2940         (forget_cached_source_info_for_objfile): Update.
2941         * objfiles.h (class objfile_compunits): Remove.
2942         (struct objfile) <compunits_range>: New typedef.
2943         (compunits): New method.
2944         * objfiles.c (objfile_relocate1): Update.
2945         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2946         * maint.c (count_symtabs_and_blocks): Update.
2947         * linespec.c (iterate_over_all_matching_symtabs): Update.
2948         * cp-support.c (add_symbol_overload_list_qualified): Update.
2949         * coffread.c (coff_symtab_read): Update.
2950         * ada-lang.c (add_nonlocal_symbols)
2951         (ada_collect_symbol_completion_matches)
2952         (ada_add_global_exceptions): Update.
2953
2954 2019-01-15  Tom Tromey  <tom@tromey.com>
2955
2956         * progspace.h (program_space) <objfiles_safe_range>: New
2957         typedef.
2958         <objfiles_safe>: New method.
2959         * objfiles.h (class all_objfiles_safe): Remove.
2960         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
2961         * jit.c (jit_inferior_exit_hook): Update.
2962
2963 2019-01-17  Tom Tromey  <tom@tromey.com>
2964
2965         * progspace.h (program_space) <objfiles_range>: New typedef.
2966         <objfiles>: New method.
2967         <objfiles_head>: Rename from objfiles.
2968         (object_files): Update.
2969         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
2970         * guile/scm-pretty-print.c
2971         (ppscm_find_pretty_printer_from_objfiles): Update.
2972         * guile/scm-objfile.c (gdbscm_objfiles): Update.
2973         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
2974         Update.
2975         * python/py-progspace.c (pspy_get_objfiles): Update.
2976         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2977         Update.
2978         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2979         (objfpy_lookup_objfile_by_build_id): Update.
2980         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2981         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2982         Update.
2983         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2984         (expand_symtab_containing_pc, lookup_objfile_from_block)
2985         (lookup_static_symbol, basic_lookup_transparent_type)
2986         (find_pc_sect_compunit_symtab, find_symbol_at_address)
2987         (find_line_symtab, info_sources_command)
2988         (default_collect_symbol_completion_matches_break_on)
2989         (make_source_files_completion_list, find_main_name): Update.
2990         * symmisc.c (print_symbol_bcache_statistics)
2991         (print_objfile_statistics, maintenance_print_symbols)
2992         (maintenance_print_msymbols, maintenance_print_objfiles)
2993         (maintenance_info_symtabs, maintenance_check_symtabs)
2994         (maintenance_expand_symtabs, maintenance_info_line_tables):
2995         Update.
2996         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
2997         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
2998         (map_overlay_command, unmap_overlay_command)
2999         (simple_overlay_update, expand_symtabs_matching)
3000         (map_symbol_filenames): Update.
3001         * symfile-debug.c (set_debug_symfile): Update.
3002         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
3003         Update.
3004         * source.c (select_source_symtab, forget_cached_source_info):
3005         Update.
3006         * solib.c (solib_read_symbols): Update.
3007         * solib-spu.c (append_ocl_sos): Update.
3008         * psymtab.c (maintenance_print_psymbols)
3009         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
3010         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
3011         * printcmd.c (info_symbol_command): Update.
3012         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
3013         Update.
3014         * objfiles.h (class all_objfiles): Remove.
3015         * objfiles.c (have_partial_symbols, have_full_symbols)
3016         (have_minimal_symbols, qsort_cmp, update_section_map)
3017         (shared_objfile_contains_address_p)
3018         (default_iterate_over_objfiles_in_search_order): Update.
3019         * objc-lang.c (info_selectors_command, info_classes_command)
3020         (find_methods): Update.
3021         * minsyms.c (find_solib_trampoline_target): Update.
3022         * maint.c (maintenance_info_sections)
3023         (maintenance_translate_address, count_symtabs_and_blocks):
3024         Update.
3025         * main.c (captured_main_1): Update.
3026         * linux-thread-db.c (try_thread_db_load_from_pdir)
3027         (has_libpthread): Update.
3028         * linespec.c (iterate_over_all_matching_symtabs)
3029         (search_minsyms_for_name): Update.
3030         * jit.c (jit_find_objf_with_entry_addr): Update.
3031         * hppa-tdep.c (find_unwind_entry)
3032         (hppa_lookup_stub_minimal_symbol): Update.
3033         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
3034         Update.
3035         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3036         (elf_gnu_ifunc_resolve_by_got): Update.
3037         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
3038         * dwarf-index-write.c (save_gdb_index_command): Update.
3039         * cp-support.c (add_symbol_overload_list_qualified): Update.
3040         * breakpoint.c (create_overlay_event_breakpoint)
3041         (create_longjmp_master_breakpoint)
3042         (create_std_terminate_master_breakpoint)
3043         (create_exception_master_breakpoint): Update.
3044         * blockframe.c (find_pc_partial_function): Update.
3045         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
3046         (ada_collect_symbol_completion_matches)
3047         (ada_add_global_exceptions): Update.
3048
3049 2019-01-17  Tom Tromey  <tom@tromey.com>
3050
3051         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
3052         declare VEC.
3053         (solib_target_parse_libraries): Change return type.
3054         (library_list_start_segment, library_list_start_section)
3055         (library_list_end_library, library_list_start_library); Update.
3056         (solib_target_free_library_list): Remove.
3057         (solib_target_parse_libraries): Remove cleanup.  Change return
3058         type.
3059         (solib_target_current_sos): Update.
3060
3061 2019-01-17  Tom Tromey  <tromey@bapiya>
3062
3063         * valprint.c: Replace "the the" with "the".
3064         * symtab.c: Replace "the the" with "the".
3065         * solib.c: Replace "the the" with "the".
3066         * solib-dsbt.c: Replace "the the" with "the".
3067         * linespec.c: Replace "the the" with "the".
3068         * dwarf2loc.h: Replace "the the" with "the".
3069         * amd64-windows-tdep.c: Replace "the the" with "the".
3070         * aarch64-tdep.c: Replace "the the" with "the".
3071
3072 2019-01-16  Keith Seitz  <keiths@redhat.com>
3073
3074         PR gdb/23773
3075         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
3076         <builder>: Rename to ..
3077         <m_builder>: ... this and make private.
3078         (dwarf2_cu::get_builder): New method.  Change all users of
3079         `builder' to use this method.
3080         (dwarf2_start_symtab): Move to ...
3081         (dwarf2_cu::start_symtab): ... here.  Update all callers
3082         (setup_type_unit_groups): Move to ...
3083         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
3084         callers.
3085         (dwarf2_cu::reset_builder): New method.
3086         (process_full_compunit, process_full_type_unit): Use
3087         dwarf2_cu::reset_builder.
3088         (follow_die_offset): Record the ancestor CU if it is different
3089         from the followed DIE's CU.
3090         (follow_die_sig_1): Likewise.
3091
3092 2019-01-15  Tom Tromey  <tom@tromey.com>
3093
3094         * remote.c (class remote_state) <buf>: Now a char_vector.
3095         <buf_size>: Remove.
3096         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
3097         parameter.
3098         (remote_target::getpkt_or_notif_sane_1)
3099         (remote_target::getpkt_sane)
3100         (remote_target::getpkt_or_notif_sane): Likewise.
3101         (class remote_target) <putpkt>: New overload.
3102         (remote_target::read_frame): Change type of "buf_p".  Remove
3103         sizeof_p parameter.
3104         (packet_ok): New overload.
3105         (packet_check_result): New overload.
3106         Update all uses.
3107
3108 2019-01-14  Tom Tromey  <tom@tromey.com>
3109
3110         * remote-notif.c (handle_notification, remote_notif_ack)
3111         (remote_notif_parse): Make "buf" const.
3112         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
3113         const.
3114         (remote_notif_parse, remote_notif_ack, handle_notification):
3115         Likewise.
3116         * remote.c (remote_notif_stop_parse): Make "buf" const.
3117         (remote_target::remote_parse_stop_reply): Make "buf" const.
3118         (remote_notif_stop_ack): Make "buf" const.
3119
3120 2019-01-14  Tom Tromey  <tom@tromey.com>
3121
3122         * remote.c (remote_console_output): Make parameter const.
3123
3124 2019-01-14  Tom Tromey  <tom@tromey.com>
3125
3126         * target-debug.h (target_debug_print_signals): Constify.
3127         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
3128         * procfs.c (procfs_target::pass_signals): Update.
3129         * linux-nat.c (linux_nat_target::pass_signals): Update.
3130         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
3131         * target-delegates.c: Rebuild.
3132         * remote.c (remote_target::program_signals): Update.
3133         (remote_target::pass_signals): Update.
3134         * target.c (target_pass_signals): Constify argument.
3135         (target_program_signals): Likewise.
3136         * target.h (struct target_ops) <pass_signals, program_signals>:
3137         Constify argument.
3138         (target_pass_signals, target_program_signals): Constify argument.
3139
3140 2019-01-14  Tom Tromey  <tom@tromey.com>
3141
3142         PR tui/28819:
3143         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
3144
3145 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3146
3147         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
3148         field.
3149         * rs6000-tdep.c: Include reggroups.h.
3150         (IS_V_ALIAS_PSEUDOREG): Define.
3151         (rs6000_register_name): Return names for the "vX" aliases.
3152         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
3153         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
3154         aliases.  Call default_register_reggroup_p for all other
3155         pseudo-registers.
3156         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
3157         New functions.
3158         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
3159         Handle "vX" aliases.
3160         (v_alias_pseudo_register_collect): New function.
3161         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
3162         (rs6000_gdbarch_init): Initialize "vX" aliases as
3163         pseudo-registers.  Restore registration of
3164         rs6000_pseudo_register_reggroup_p with
3165         set_tdesc_pseudo_register_reggroup_p.
3166
3167 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
3168
3169         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
3170         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
3171         set_gdbarch_num_pseudo_regs.
3172
3173 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3174
3175         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
3176         Remove arg prefixname, add do_set and do_show.
3177         Add member functions set_list and show_list.
3178         * cli/cli-style.c (class cli_style_option): Update accordingly.
3179         (style_set_list): Move to file scope.
3180         (style_show_list): Likewise.
3181         (set_style): Call help_list.
3182         (show_style): Call cmd_show_list.
3183         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
3184         Update to use the new macro.
3185
3186 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
3187
3188         * ada-lang.c (_initialize_ada_language): Expand the help text
3189         for the "catch exception" command.
3190
3191 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3192
3193         * symtab.c (matching_obj_sections): Initialize obj,
3194         declare it closer to its usage.
3195
3196 2019-01-10  Tom Tromey  <tom@tromey.com>
3197
3198         * thread-iter.h (inf_threads_iterator): Use next_iterator.
3199         (basic_inf_threads_range): Remove.
3200         (inf_threads_range, inf_non_exited_threads_range)
3201         (safe_inf_threads_range): Use next_adapter.
3202
3203 2019-01-10  Keith Seitz  <keiths@redhat.com>
3204
3205         PR gdb/23712
3206         PR symtab/23010
3207         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
3208         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
3209
3210 2019-01-10  Keith Seitz  <keiths@redhat.com>
3211
3212         PR gdb/23712
3213         PR symtab/23010
3214         * dictionary.c (pending_to_vector): Remove.
3215         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3216         Remove _1 suffix, replacing functions of the same name.  Update
3217         all callers.
3218         (dict_create_hashed, dict_create_hashed_expandable)
3219         (dict_create_linear, dict_create_linear_expandable, dict_free)
3220         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
3221         Make functions static.
3222
3223 2019-01-10  Keith Seitz  <keiths@redhat.com>
3224
3225         PR gdb/23712
3226         PR symtab/23010
3227         * dictionary.h (struct dictionary): Replace declaration with
3228         multidictionary.
3229         (dict_create_hashed, dict_create_hashed_expandable)
3230         (dict_create_linear, dict_create_linear_expandable)
3231         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
3232         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
3233         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
3234         taking multidictionary argument.
3235         [ALL_DICT_SYMBOLS]: Update for multidictionary.
3236         * block.h (struct block) <dict>: Change to multidictionary
3237         and rename `multidict'.
3238         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
3239         symmisc.c: Update all dictionary references to multidictionary.
3240
3241 2019-01-10  Keith Seitz  <keiths@redhat.com>
3242
3243         PR gdb/23712
3244         PR symtab/23010
3245         * dictionary.c: Include unordered_map.
3246         (pending_to_vector): New function.
3247         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3248         Rewrite the non-"_1" functions to take vector instead
3249         of linked list.
3250         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
3251         "new" _1 versions of the same name.
3252         (multidictionary): Define.
3253         (std::hash<enum language): New definition.
3254         (collate_pending_symbols_by_language, mdict_create_hashed)
3255         (mdict_create_hashed_expandable, mdict_create_linear)
3256         (mdict_create_linear_expandable, mdict_free)
3257         (find_language_dictionary, create_new_language_dictionary)
3258         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
3259         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
3260         (mdict_size, mdict_empty): New functions.
3261         * dictionary.h (mdict_iterator): Define.
3262
3263 2019-01-10  Pedro Alves  <palves@redhat.com>
3264
3265         * breakpoint.c (read_uploaded_action)
3266         (create_tracepoint_from_upload): Adjust to use
3267         gdb::unique_xmalloc_ptr.
3268         * ctf.c (ctf_write_uploaded_tp):
3269         (SET_ARRAY_FIELD): Use emplace_back.
3270         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
3271         * tracefile-tfile.c (tfile_write_uploaded_tp):
3272         * tracepoint.c (parse_tracepoint_definition): Adjust to use
3273         gdb::unique_xmalloc_ptr.
3274         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
3275         at_string, cond_string, cmd_strings>: Replace char pointers
3276         with gdb::unique_xmalloc_ptr.
3277
3278 2019-01-10  Pedro Alves  <palves@redhat.com>
3279
3280         * solib-target.c (library_list_start_library): Don't xstrdup name.
3281
3282 2019-01-10  Pedro Alves  <palves@redhat.com>
3283
3284         * mdebugread.c (parse_partial_symbols): Use
3285         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
3286
3287 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3288
3289         * linux-fork.c (scoped_switch_fork_info)
3290         <~scoped_switch_fork_info>: Fix incorrect variable name.
3291
3292 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3293
3294         * linux-fork.c (scoped_switch_fork_info)
3295         <scoped_switch_fork_info>: Make explicit.
3296         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
3297
3298 2019-01-10  Tom Tromey  <tom@tromey.com>
3299
3300         * objfiles.h (objfile::reset_psymtabs): Update.
3301         * objfiles.c (objfile::objfile): Update.
3302         * psymtab.h (psymtab_storage::obstack): Update.
3303         (psymtab_storage::m_obstack): Use gdb::optional.
3304         (class psymtab_storage): Update comment.  Remove objfile
3305         parameter.
3306         * psymtab.c (psymtab_storage::psymtab_storage): Update.
3307
3308 2019-01-10  Tom Tromey  <tom@tromey.com>
3309
3310         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
3311         <free_psymtabs>: Now private.
3312         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
3313         (allocate_psymtab): Use new method.
3314
3315 2019-01-10  Tom Tromey  <tom@tromey.com>
3316
3317         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
3318         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
3319         * mdebugread.c (parse_partial_symbols): Use
3320         allocate_dependencies.
3321         * dwarf2read.c (dwarf2_create_include_psymtab): Use
3322         allocate_dependencies.
3323         (process_psymtab_comp_unit_reader)
3324         (build_type_psymtab_dependencies): Likewise.
3325         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
3326
3327 2019-01-10  Tom Tromey  <tom@tromey.com>
3328
3329         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
3330         PSYMBOL_SET_LANGUAGE.
3331         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
3332
3333 2019-01-10  Tom Tromey  <tom@tromey.com>
3334
3335         * psymtab.h (psymtab_storage::obstack): New method.
3336         <m_obstack>: Rename from obstack; now private.
3337         * psymtab.c (psymtab_storage): Update.
3338         * dwarf2read.c (create_addrmap_from_index)
3339         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
3340         Update.
3341
3342 2019-01-10  Tom Tromey  <tom@tromey.com>
3343
3344         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
3345         * objfiles.h (objfile::reset_psymtabs): New method.
3346
3347 2019-01-10  Tom Tromey  <tom@tromey.com>
3348
3349         * symmisc.c (print_symbol_bcache_statistics): Update.
3350         (print_objfile_statistics): Update.
3351         * symfile.c (reread_symbols): Update.
3352         * psymtab.h (class psymtab_storage): New.
3353         * psymtab.c (psymtab_storage): New constructor.
3354         (~psymtab_storage): New destructor.
3355         (require_partial_symbols): Update.
3356         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
3357         (find_pc_sect_psymtab, find_pc_sect_psymbol)
3358         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
3359         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
3360         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
3361         (start_psymtab_common, end_psymtab_common)
3362         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
3363         (allocate_psymtab): Update.
3364         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
3365         Update.
3366         (dump_psymtab_addrmap, maintenance_print_psymbols)
3367         (maintenance_check_psymtabs): Update.
3368         (class objfile_psymtabs): Move to objfiles.h.
3369         * psympriv.h (discard_psymtab): Now inline.
3370         (psymtab_discarder::psymtab_discarder): Update.
3371         (psymtab_discarder::~psymtab_discarder): Update.
3372         (ALL_OBJFILE_PSYMTABS): Rewrite.
3373         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
3374         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
3375         Remove fields.
3376         <partial_symtabs>: New field.
3377         (class objfile_psymtabs): Move from psymtab.h.  Update.
3378         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
3379         psymbol_cache.
3380         (objfile::~objfile): Don't destroy psymbol_cache.
3381         * mdebugread.c (parse_partial_symbols): Update.
3382         * dwarf2read.c (create_addrmap_from_index)
3383         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
3384         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
3385         (add_partial_subprogram, dwarf2_ranges_read): Update.
3386         * dwarf-index-write.c (write_address_map)
3387         (write_one_signatured_type, recursively_write_psymbols)
3388         (class debug_names, class debug_names, write_psymtabs_to_index):
3389         Update.
3390
3391 2019-01-10  Tom Tromey  <tom@tromey.com>
3392
3393         * symtab.h (SYMBOL_SET_NAMES): Update.
3394         (symbol_set_names): Update.
3395         (MSYMBOL_SET_NAMES): Update.
3396         * symtab.c (symbol_set_names): Change argument to be an
3397         objfile_per_bfd_storage.
3398         * psymtab.c (add_psymbol_to_bcache): Update.
3399         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
3400
3401 2019-01-10  Tom Tromey  <tom@tromey.com>
3402
3403         * symtab.c (create_demangled_names_hash): Change argument to be an
3404         objfile_per_bfd_storage.
3405         (symbol_set_names): Update.
3406
3407 2019-01-10  Tom Tromey  <tom@tromey.com>
3408
3409         * xcoffread.c (xcoff_initial_scan): Unconditionally call
3410         init_psymbol_list.
3411         * psymtab.c (init_psymbol_list): Do nothing if already called.
3412         * psympriv.h (init_psymbol_list): Add comment.
3413         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
3414         init_psymbol_list.
3415         * dbxread.c (dbx_symfile_read): Unconditionally call
3416         init_psymbol_list.
3417
3418 2019-01-10  Tom Tromey  <tom@tromey.com>
3419
3420         * xcoffread.c (scan_xcoff_symtab): Update.
3421         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
3422         "where".
3423         * mdebugread.c (parse_partial_symbols)
3424         (handle_psymbol_enumerators): Update.
3425         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
3426         * dbxread.c (read_dbx_symtab): Update.
3427         * psympriv.h (psymbol_placement): New enum.
3428         (add_psymbol_to_list): Update.
3429
3430 2019-01-10  Tom Tromey  <tom@tromey.com>
3431
3432         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
3433         static_psymbols parameters.
3434         (scan_xcoff_symtab): Update.
3435         * psymtab.c (start_psymtab_common): Remove global_psymbols and
3436         static_psymbols parameters.
3437         * psympriv.h (start_psymtab_common): Update.
3438         * mdebugread.c (parse_partial_symbols): Update.
3439         * dwarf2read.c (create_partial_symtab): Update.
3440         * dbxread.c (read_dbx_symtab): Update.
3441         (start_psymtab): Remove global_psymbols and static_psymbols
3442         parameters.
3443
3444 2019-01-10  Tom Tromey  <tom@tromey.com>
3445
3446         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
3447         * psymtab.c (allocate_psymtab): Add comment.
3448         * psympriv.h (allocate_psymtab): Add comment.
3449         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
3450         initializations.
3451         * dbxread.c (dbx_end_psymtab): Remove some initializations.
3452
3453 2019-01-10  Tom Tromey  <tom@tromey.com>
3454
3455         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3456         Don't declare.
3457         * mipsread.c: Include mdebugread.h.
3458         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3459         Declare.
3460         * elfread.c: Include mdebugread.h.
3461
3462 2019-01-09  Tom Tromey  <tom@tromey.com>
3463
3464         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
3465         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
3466         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
3467         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
3468         (psym_lookup_symbol, psym_find_last_source_symtab)
3469         (psym_forget_cached_source_info, psym_print_stats)
3470         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
3471         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
3472         (psym_map_matching_symbols, psym_expand_symtabs_matching)
3473         (psym_find_compunit_symtab_by_address)
3474         (maintenance_print_psymbols, maintenance_info_psymtabs)
3475         (maintenance_check_psymtabs): Use ranged for.
3476         * psymtab.h (class objfile_psymtabs): New.
3477         (require_partial_symbols): Return objfile_psymtabs.
3478         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
3479
3480 2019-01-09  Tom Tromey  <tom@tromey.com>
3481
3482         * symfile.c (overlay_invalidate_all, find_pc_overlay)
3483         (find_pc_mapped_section, list_overlays_command)
3484         (map_overlay_command, unmap_overlay_command)
3485         (simple_overlay_update): Use all_objfiles.
3486         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
3487         * printcmd.c (info_symbol_command): Use all_objfiles.
3488         * objfiles.h (ALL_OBJSECTIONS): Remove.
3489         * maint.c (maintenance_translate_address): Use all_objfiles.
3490         * gcore.c (gcore_create_callback): Use all_objfiles.
3491         (objfile_find_memory_regions): Likewise.
3492
3493 2019-01-09  Tom Tromey  <tom@tromey.com>
3494
3495         * symtab.c (find_line_symtab, info_sources_command)
3496         (make_source_files_completion_list): Use objfile_compunits.
3497         * source.c (select_source_symtab): Use objfile_compunits.
3498         * objfiles.h (struct objfile): Update comment.
3499         (ALL_OBJFILES): Remove.
3500         (ALL_FILETABS): Remove.
3501         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
3502         objfile_compunits.
3503
3504 2019-01-09  Tom Tromey  <tom@tromey.com>
3505
3506         * symmisc.c (print_objfile_statistics, dump_objfile)
3507         (maintenance_print_symbols): Use compunit_filetabs.
3508         * source.c (forget_cached_source_info_for_objfile): Use
3509         compunit_filetabs.
3510         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
3511         (ALL_FILETABS): Use compunit_filetabs.
3512         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
3513         * coffread.c (coff_symtab_read): Use compunit_filetabs.
3514
3515 2019-01-09  Tom Tromey  <tom@tromey.com>
3516
3517         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
3518         (compunit_filetabs): New.
3519         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
3520         compunit_filetabs.
3521         (info_sources_command, make_source_files_completion_list): Remove
3522         declaration.
3523         * symmisc.c (print_objfile_statistics, dump_objfile)
3524         (maintenance_print_symbols): Remove declaration.
3525         (maintenance_info_symtabs): Use compunit_filetabs.
3526         (maintenance_info_line_tables): Likewise.
3527         * source.c (select_source_symtab): Change local variable name.
3528         (forget_cached_source_info_for_objfile): Remove declaration.
3529         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
3530         * objfiles.c (objfile_relocate1): Remove declaration.
3531         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3532         declaration.
3533         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
3534         * coffread.c (coff_symtab_read): Remove declaration.
3535         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3536         compunit_filetabs.
3537
3538 2019-01-09  Tom Tromey  <tom@tromey.com>
3539
3540         * symtab.c (lookup_objfile_from_block)
3541         (find_pc_sect_compunit_symtab, search_symbols)
3542         (default_collect_symbol_completion_matches_break_on): Use
3543         objfile_compunits.
3544         * objfiles.h (ALL_COMPUNITS): Remove.
3545         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
3546         * cp-support.c (add_symbol_overload_list_qualified): Use
3547         objfile_compunits.
3548         * ada-lang.c (ada_collect_symbol_completion_matches)
3549         (ada_add_global_exceptions): Use objfile_compunits.
3550
3551 2019-01-09  Tom Tromey  <tom@tromey.com>
3552
3553         * source.c (select_source_symtab)
3554         (forget_cached_source_info_for_objfile): Remove declaration.
3555         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3556         declaration.
3557         * maint.c (count_symtabs_and_blocks): Remove declaration.
3558         * cp-support.c (add_symbol_overload_list_qualified): Remove
3559         declaration.
3560         * coffread.c (coff_symtab_read): Remove declaration.
3561         * symtab.c (lookup_symbol_in_objfile_symtabs)
3562         (basic_lookup_transparent_type_1): Use objfile_compunits.
3563         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
3564         (info_sources_command, search_symbols)
3565         (default_collect_symbol_completion_matches_break_on)
3566         (make_source_files_completion_list): Remove declaration.
3567         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
3568         (ada_collect_symbol_completion_matches)
3569         (ada_add_global_exceptions): Remove declaration.
3570         * linespec.c (iterate_over_all_matching_symtabs): Use
3571         objfile_compunits.
3572         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
3573         (class objfile_compunits): New.
3574         (ALL_COMPUNITS): Use objfile_compunits.
3575         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
3576         (maintenance_check_symtabs, maintenance_info_line_tables): Use
3577         objfile_compunits.
3578         * objfiles.c (objfile_relocate1): Use objfile_compunits.
3579
3580 2019-01-09  Tom Tromey  <tom@tromey.com>
3581
3582         * symtab.c (search_symbols)
3583         (default_collect_symbol_completion_matches_break_on): Use
3584         objfile_msymbols.
3585         * ada-lang.c (ada_lookup_simple_minsym)
3586         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
3587         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
3588         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
3589         objfile_msymbols.
3590         * coffread.c (coff_symfile_read): Use objfile_msymbols.
3591         * symmisc.c (dump_msymbols): Use objfile_msymbols.
3592         * objc-lang.c (find_methods): Use objfile_msymbols.
3593         (info_selectors_command, info_classes_command): Likewise.
3594         * stabsread.c (scan_file_globals): Use objfile_msymbols.
3595         * objfiles.h (class objfile_msymbols): New.
3596         (ALL_OBJFILE_MSYMBOLS): Remove.
3597         (ALL_MSYMBOLS): Remove.
3598
3599 2019-01-09  Tom Tromey  <tom@tromey.com>
3600
3601         * common/next-iterator.h (next_adapter): Add Iterator template
3602         parameter.
3603         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
3604         (class all_objfiles_safe): New.
3605         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
3606         * objfiles.c (put_objfile_before): Update comment.
3607         (add_separate_debug_objfile): Likewise.
3608         (free_all_objfiles): Use all_objfiles_safe.
3609         (objfile_purge_solibs): Likewise.
3610
3611 2019-01-09  Tom Tromey  <tom@tromey.com>
3612
3613         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3614         (expand_symtab_containing_pc, lookup_static_symbol)
3615         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
3616         (find_symbol_at_address, find_line_symtab, find_main_name): Use
3617         all_objfiles.
3618         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
3619         * breakpoint.c (create_overlay_event_breakpoint)
3620         (create_longjmp_master_breakpoint)
3621         (create_std_terminate_master_breakpoint)
3622         (create_exception_master_breakpoint): Use all_objfiles.
3623         * linux-thread-db.c (try_thread_db_load_from_pdir)
3624         (has_libpthread): Use all_objfiles.
3625         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
3626         * linespec.c (iterate_over_all_matching_symtabs)
3627         (search_minsyms_for_name): Use all_objfiles.
3628         * maint.c (maintenance_info_sections): Use all_objfiles.
3629         * main.c (captured_main_1): Use all_objfiles.
3630         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
3631         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
3632         * guile/scm-pretty-print.c
3633         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
3634         * solib-spu.c (append_ocl_sos): Use all_objfiles.
3635         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
3636         (maintenance_print_msymbols): Use all_objfiles.
3637         * source.c (select_source_symtab): Use all_objfiles.
3638         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
3639         * symfile.c (remove_symbol_file_command)
3640         (expand_symtabs_matching, map_symbol_filenames): Use
3641         all_objfiles.
3642         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
3643         all_objfiles.
3644         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
3645         * objc-lang.c (find_methods): Use all_objfiles.
3646         * objfiles.c (have_partial_symbols, have_full_symbols)
3647         (have_minimal_symbols, qsort_cmp)
3648         (default_iterate_over_objfiles_in_search_order): Use
3649         all_objfiles.
3650         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
3651         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
3652         (maintenance_check_psymtabs): Use all_objfiles.
3653         (ALL_PSYMTABS): Remove.
3654         * compile/compile-object-run.c (do_module_cleanup): Use
3655         all_objfiles.
3656         * blockframe.c (find_pc_partial_function): Use all_objfiles.
3657         * cp-support.c (add_symbol_overload_list_qualified): Use
3658         all_objfiles.
3659         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3660         Use all_objfiles.
3661         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
3662         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
3663         all_objfiles.
3664         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3665         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
3666         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3667         Uses all_objfiles.
3668         * solib.c (solib_read_symbols): Use all_objfiles
3669
3670 2019-01-09  Tom Tromey  <tom@tromey.com>
3671
3672         * probe.c (parse_probes_in_pspace): Use all_objfiles.
3673         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
3674         all_objfiles.
3675         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
3676         * symmisc.c (print_symbol_bcache_statistics)
3677         (print_objfile_statistics, maintenance_print_objfiles)
3678         (maintenance_info_symtabs, maintenance_check_symtabs)
3679         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
3680         all_objfiles.
3681         * source.c (forget_cached_source_info): Use all_objfiles.
3682         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
3683         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3684         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
3685         * objfiles.c (update_section_map): Use all_objfiles.
3686         (shared_objfile_contains_address_p): Likewise.
3687         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
3688         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
3689
3690 2019-01-09  Tom Tromey  <tom@tromey.com>
3691
3692         * common/next-iterator.h: New file.
3693         * objfiles.h (class all_objfiles): New.
3694         (struct objfile_iterator): New.
3695
3696 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3697
3698         * NEWS: Move the description of the changed "frame", "select-frame",
3699          and "info frame" commands to the Changed commands section.
3700
3701 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
3702
3703         * gdbtypes.c (check_stub_method_group): Remove handling of old
3704         mangling schemes.
3705         * linespec.c (find_methods): Likewise.
3706         * stabsread.c (read_member_functions): Likewise.
3707         * valops.c (search_struct_method): Likewise.
3708         (value_struct_elt_for_reference): Likewise.
3709         * NEWS: Mention this change.
3710
3711 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3712
3713         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
3714         print_source_lines.
3715         * source.c (print_source_lines_base): Update line number check.
3716         (print_source_lines): New function.
3717         (source_lines_range::source_lines_range): New function.
3718         * source.h (class source_lines_range): New class.
3719         (print_source_lines): New declaration.
3720
3721 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3722
3723         * linespec.c (linespec_state_destructor): Free self->canonical_names.
3724
3725 2019-01-08  Tom Tromey  <tom@tromey.com>
3726             Simon Marchi  <simon.marchi@ericsson.com>
3727
3728         PR gdb/24060
3729         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
3730         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
3731         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3732         * f-exp.y (DOLLAR_VARIABLE): Likewise.
3733         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
3734         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3735
3736 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3737
3738         * source.c (select_source_symtab): Move header comment to
3739         declaration in source.h.
3740         (forget_cached_source_info_for_objfile): Likewise.
3741         (forget_cached_source_info): Likewise.
3742         (identify_source_line): Likewise.
3743         * source.h (identify_source_line): Move declaration from symtab.h
3744         and add comment from source.c
3745         (print_source_lines): Likewise.
3746         (forget_cached_source_info_for_objfile): Likewise.
3747         (forget_cached_source_info): Likewise.
3748         (select_source_symtab): Likewise.
3749         (enum print_source_lines_flag): Move definition from symtab.h.
3750         * symtab.h (identify_source_line): Move declaration to source.h.
3751         (print_source_lines): Likewise.
3752         (forget_cached_source_info_for_objfile): Likewise.
3753         (forget_cached_source_info): Likewise.
3754         (select_source_symtab): Likewise.
3755         (enum print_source_lines_flag): Move definition to source.h.
3756         * tui/tui-hooks.c: Add 'source.h' include.
3757
3758 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3759
3760         * source.c (print_source_lines_base): Handle requests to print
3761         reverse line number sequences, and guard against empty lines
3762         string.
3763
3764 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3765
3766         * source.c (print_source_lines_base): Fix skip of '\r' if next
3767         character is '\n'.
3768
3769 2019-01-06  Tom Tromey  <tom@tromey.com>
3770
3771         * c-exp.y (struct c_parse_state) <macro_original_text,
3772         expansion_obstack>: New member.
3773         (macro_original_text, expansion_obstack): Remove globals.
3774         (scan_macro_expansion, scanning_macro_expansion)
3775         (finished_macro_expansion): Update.
3776         (scan_macro_cleanup): Remove.
3777         (yylex, c_parse): Update.
3778
3779 2019-01-06  Tom Tromey  <tom@tromey.com>
3780
3781         * c-exp.y (struct c_parse_state) <strings>: New member.
3782         (operator_stoken): Update.
3783
3784 2019-01-06  Tom Tromey  <tom@tromey.com>
3785
3786         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
3787         (union type_stack_elt) <typelist_val>: Now a pointer to
3788         std::vector.
3789         (type_stack_cleanup): Don't declare.
3790         (push_typelist): Update.
3791         * parse.c (pop_typelist): Return a std::vector.
3792         (push_typelist): Take a std::vector.
3793         (follow_types): Update.  Do not free args.
3794         (type_stack_cleanup): Remove.
3795         * c-exp.y (struct c_parse_state): New.
3796         (cpstate): New global.
3797         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
3798         (nonempty_typelist): Update.
3799         (func_mod): Create a new vector.
3800         (c_parse): Create a c_parse_state.
3801         (check_parameter_typelist): Do not delete params.
3802         (function_method): Update.  Do not delete type_list.
3803
3804 2019-01-06  Tom Tromey  <tom@tromey.com>
3805
3806         PR gdb/28155:
3807         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
3808         check_typedef.
3809         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
3810         (print_return_value): Likewise.
3811
3812 2019-01-05  Tom Tromey  <tom@tromey.com>
3813
3814         * contrib/cleanup_check.py: Remove.
3815         * contrib/gcc-with-excheck: Remove.
3816         * contrib/exsummary.py: Remove.
3817         * contrib/excheck.py: Remove.
3818
3819 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
3820
3821         * thread.c (delete_thread_1): Add gdb_assert that THR is not
3822         NULL. Initialize tpprev to NULL instead of assigning it
3823         to NULL on the next statement.
3824         * windows-nat.c (windows_delete_thread): Remove check for
3825         main_thread_id before printing thread exit notifications.
3826         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
3827         Remove thread ID check against main_thread_id.
3828         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
3829         windows_delete_thread.
3830         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
3831
3832 2019-01-04  Tom Tromey  <tom@tromey.com>
3833
3834         * compile/compile.c (_initialize_compile): Use upper case for
3835         metasyntactic variables.
3836         * symmisc.c (_initialize_symmisc): Use upper case for
3837         metasyntactic variables.
3838         * psymtab.c (_initialize_psymtab): Use upper case for
3839         metasyntactic variables.
3840         * demangle.c (demangle_command): Use upper case for metasyntactic
3841         variables.
3842         (_initialize_demangler): Likewise.
3843         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
3844         variables.
3845
3846 2019-01-03  Tom Tromey  <tom@tromey.com>
3847
3848         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
3849
3850 2019-01-03  Tom Tromey  <tom@tromey.com>
3851
3852         * python/py-symtab.c (salpy_str): Update.
3853         (struct salpy_sal_object) <symtab>: Now a PyObject.
3854         (salpy_dealloc): Update.
3855         (del_objfile_sal): Use gdbpy_ref.
3856
3857 2019-01-03  Tom Tromey  <tom@tromey.com>
3858
3859         * python/py-type.c (convert_field): Use new_reference.  Return
3860         gdbpy_ref.
3861         (make_fielditem): Return gdbpy_ref.
3862         (typy_fields): Update.
3863         (typy_getitem): Update.
3864         (field_name): Return gdbpy_ref.  Use new_reference.
3865         (typy_iterator_iternext): Update.
3866
3867 2019-01-03  Tom Tromey  <tom@tromey.com>
3868
3869         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
3870
3871 2019-01-03  Tom Tromey  <tom@tromey.com>
3872
3873         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
3874         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
3875         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
3876         (pspy_set_frame_filters, pspy_set_frame_unwinders)
3877         (pspy_set_type_printers): Likewise.
3878         * python/py-function.c (fnpy_init): Use gdbpy_ref.
3879         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
3880         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
3881         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
3882         (objfpy_set_type_printers): Likewise.
3883
3884 2019-01-03  Tom Tromey  <tom@tromey.com>
3885
3886         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
3887         (gdbpy_print_stack): Use gdbpy_err_fetch.
3888         * python/python-internal.h (class gdbpy_err_fetch): New class.
3889         (class gdbpy_enter) <m_error_type, m_error_value,
3890         m_error_traceback>: Remove.
3891         <m_error>: New member.
3892         (gdbpy_exception_to_string): Don't declare.
3893         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
3894         * python/py-value.c (convert_value_from_python): Use
3895         gdbpy_err_fetch.
3896         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
3897         gdbpy_exception_to_string.
3898         (gdbpy_handle_exception): Use gdbpy_err_fetch.
3899         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3900         gdbpy_err_fetch.
3901
3902 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3903
3904         * linux-nat.c (delete_lwp_cleanup): Delete.
3905         (struct lwp_deleter): New struct.
3906         (lwp_info_up): New typedef.
3907         (linux_nat_target::follow_fork): Delete cleanup, and make use of
3908         lwp_info_up.
3909
3910 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3911
3912         * linux-fork.c (class scoped_switch_fork_info): New class.
3913         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
3914
3915 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3916
3917         * valops.c (find_overload_match): Remove use of null_cleanup, and
3918         calls to do_cleanups.
3919
3920 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3921
3922         * compile/compile-cplus-types.c
3923         (compile_cplus_instance::decl_name): Handle changes to
3924         cp_func_name.
3925         * cp-support.c (cp_func_name): Update header comment, update
3926         return type.
3927         * cp-support.h (cp_func_name): Update return type in declaration.
3928         * valops.c (find_overload_match): Move temp_func local to top
3929         level of function and change its type.  Use temp_func to hold and
3930         delete temporary string obtained from cp_func_name.
3931
3932 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3933
3934         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
3935         gdb::char_vector, remove cleanup, and update uses of `msg`.
3936
3937 2019-01-03  Jim Wilson  <jimw@sifive.com>
3938
3939         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
3940
3941 2019-01-02  Tom Tromey  <tom@tromey.com>
3942
3943         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
3944         (tdesc_parse_xml): Remove cleanups.
3945         * target-descriptions.h (make_cleanup_free_target_description):
3946         Don't declare.
3947         (target_desc_deleter): New struct.
3948         (target_desc_up): New typedef.
3949         * target-descriptions.c (target_desc_deleter::operator()): Rename
3950         from free_target_description.
3951         (make_cleanup_free_target_description): Remove.
3952
3953 2019-01-02  Tom Tromey  <tom@tromey.com>
3954
3955         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
3956         constructor, destructor.
3957         (linespec_parser): Remove typedef.
3958         (~linespec_parser): Rename from linespec_parser_delete.
3959         (linespec_lex_to_end, linespec_complete_label)
3960         (linespec_complete): Update.
3961         (decode_line_full): Remove cleanups.
3962         (decode_line_1): Update.
3963
3964 2019-01-02  Tom Tromey  <tom@tromey.com>
3965
3966         * python/python-internal.h (inferior_to_inferior_object): Change
3967         return type.
3968         * python/py-exitedevent.c (create_exited_event_object): Update.
3969         * python/py-inferior.c (inferior_to_inferior_object): Return
3970         gdbpy_ref.
3971         (python_new_inferior, python_inferior_deleted)
3972         (thread_to_thread_object, delete_thread_object)
3973         (build_inferior_list, gdbpy_selected_inferior): Update.
3974         * python/py-infthread.c (create_thread_object): Update.  Also fail
3975         if inferior_to_inferior_object fails.
3976
3977 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
3978
3979         * inferior.h (class inferior) <displaced_step_state>: New field.
3980         * infrun.h (struct displaced_step_state): Move here from
3981         infrun.c.  Initialize fields, add constructor.
3982         <inf>: Remove field.
3983         <reset>: New method.
3984         * infrun.c (struct displaced_step_inferior_state): Move to
3985         infrun.h.
3986         (displaced_step_inferior_states): Remove.
3987         (get_displaced_stepping_state): Adust.
3988         (displaced_step_in_progress_any_inferior): Adjust.
3989         (displaced_step_in_progress_thread): Adjust.
3990         (displaced_step_in_progress): Adjust.
3991         (add_displaced_stepping_state): Remove.
3992         (get_displaced_step_closure_by_addr): Adjust.
3993         (remove_displaced_stepping_state): Remove.
3994         (infrun_inferior_exit): Call displaced_step_state.reset.
3995         (use_displaced_stepping): Don't check for NULL.
3996         (displaced_step_prepare_throw): Call
3997         get_displaced_stepping_state.
3998         (displaced_step_fixup): Don't check for NULL.
3999         (prepare_for_detach): Don't check for NULL.
4000
4001 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4002
4003         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
4004          in case of call that did not complete.
4005
4006 2019-01-02  Andrey Utkin  <autkin@undo.io>
4007
4008         * symfile.c (find_separate_debug_file): Fix search of debug files for
4009         remote debuggee.
4010
4011 2019-01-02  Tom Tromey  <tom@tromey.com>
4012
4013         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
4014         indentation.
4015         * python/py-frame.c (frapy_older): Remove cast.
4016         (frapy_newer): Likewise.
4017         * python/py-breakpoint.c (local_setattro): Remove cast.
4018         * python/py-arch.c (archpy_name): Remove local variable.
4019         * python/py-type.c (gdbpy_lookup_type): Remove cast.
4020
4021 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
4022
4023         * unittests/basic_string_view/element_access/char/empty.cc:
4024         Fix year range in copyright header.
4025
4026 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4027
4028         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
4029         Delete.
4030         <operator==>: Update with for removed field.
4031         <hash>: Likewise.
4032         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
4033         <isa_features>: ...this.
4034         <abi_features>: New field.
4035         (riscv_isa_flen): Update comment.
4036         (riscv_abi_xlen): New declaration.
4037         (riscv_abi_flen): New declaration.
4038         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
4039         isa_features.
4040         (riscv_abi_xlen): New function.
4041         (riscv_isa_flen): Update to get answer from isa_features.
4042         (riscv_abi_flen): New function.
4043         (riscv_has_fp_abi): Update to get answer from abi_features.
4044         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
4045         xlen and flen.
4046         (riscv_call_info) <xlen, flen>: Update comment.
4047         (riscv_call_arg_struct): Remove invalid assertions
4048         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
4049         is removed.
4050         (riscv_gdbarch_init): Gather isa features and abi features
4051         separately, ensure both match on the gdbarch when reusing an old
4052         gdbarch.  Relax an error check to allow 32-bit abi float to run on
4053         a target with 64-bit float hardware.
4054
4055 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4056
4057         * source.c (search_command_helper): Stop reverse search
4058         when line 1 has been searched.
4059
4060 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4061
4062         * record-full.c (record_full_base_target::close): Rewrite
4063         record_full_core_buf_list free logic.
4064
4065 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4066
4067         * break-catch-syscall.c (print_one_catch_syscall): xfree
4068         the last text.
4069
4070 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
4071
4072         * top.c (print_gdb_version): Update Copyright year in version
4073         message.
4074
4075 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
4076
4077         Update copyright year range in all GDB files.
4078
4079 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
4080
4081         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
4082
4083 For older changes see ChangeLog-2018.
4084 \f
4085 Local Variables:
4086 mode: change-log
4087 left-margin: 8
4088 fill-column: 74
4089 version-control: never
4090 coding: utf-8
4091 End:
4092