gdb/ChangeLog

   1 2019-07-17  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
   4
   5 2019-07-17  Tom Tromey  <tom@tromey.com>
   6
   7         * tui/tui-winsource.c (tui_update_source_window_as_is)
   8         (tui_update_source_windows_with_addr): Update.
   9         * tui/tui-source.h (tui_set_source_content)
  10         (tui_show_symtab_source): Add "win_info" parameter.
  11         * tui/tui-source.c (tui_set_source_content): Add "win_info"
  12         parameter.
  13         (tui_show_symtab_source): Likewise.
  14
  15 2019-07-17  Tom Tromey  <tom@tromey.com>
  16
  17         * tui/tui-wingeneral.c
  18         (tui_check_and_display_highlight_if_needed): Check can_highlight.
  19
  20 2019-07-17  Tom Tromey  <tom@tromey.com>
  21
  22         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
  23         (struct tui_cmd_window) <can_scroll>: New method.
  24         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
  25         method.
  26
  27 2019-07-17  Tom Tromey  <tromey@adacore.com>
  28
  29         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
  30         do_field_signed>: Rename.  Change type of "value".
  31         * ui-out.c (ui_out::field_signed): Rename from field_int.
  32         Change type of "value".
  33         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
  34         type of "value".
  35         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
  36         do_field_int.  Change type of "value".
  37         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
  38         do_field_int.  Change type of "value".
  39         * tracepoint.c (trace_status_mi, tfind_1)
  40         (print_one_static_tracepoint_marker): Update.
  41         * thread.c (print_thread_info_1, print_selected_thread_frame):
  42         Update.
  43         * stack.c (print_frame, print_frame_info): Update.
  44         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
  45         Update.
  46         * source.c (print_source_lines_base): Update.
  47         * skip.c (info_skip_command): Update.
  48         * record-btrace.c (btrace_ui_out_decode_error)
  49         (btrace_call_history_src_line): Update.
  50         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
  51         Update.
  52         * progspace.c (print_program_space): Update.
  53         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
  54         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
  55         do_field_int.  Change type of "value".
  56         * mi/mi-out.c (mi_ui_out::do_table_begin)
  57         (mi_ui_out::do_table_header): Update.
  58         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
  59         type of "value".
  60         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
  61         (mi_cmd_data_list_changed_registers, output_register)
  62         (mi_cmd_data_read_memory, mi_load_progress)
  63         (mi_cmd_trace_frame_collected): Update.
  64         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
  65         Update.
  66         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
  67         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
  68         (mi_cmd_var_list_children, varobj_update_one): Update.
  69         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
  70         (mi_cmd_stack_list_args, list_arg_or_local): Update.
  71         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
  72         * inferior.c (print_inferior): Update.
  73         * gdb_bfd.c (print_one_bfd): Update.
  74         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
  75         Update.
  76         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
  77         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
  78         do_field_int.  Change type of "value".
  79         * cli-out.c (cli_ui_out::do_field_signed): Rename from
  80         do_field_int.  Change type of "value".
  81         * breakpoint.c (watchpoint_check, print_breakpoint_location)
  82         (print_one_breakpoint_location, print_it_catch_fork)
  83         (print_one_catch_fork, print_it_catch_vfork)
  84         (print_one_catch_vfork, print_it_catch_solib)
  85         (print_it_catch_exec, print_it_ranged_breakpoint)
  86         (print_mention_watchpoint, print_mention_masked_watchpoint)
  87         (bkpt_print_it, update_static_tracepoint): Update.
  88         * break-catch-throw.c (print_it_exception_catchpoint): Update.
  89         * break-catch-syscall.c (print_it_catch_syscall): Update.
  90         * ada-tasks.c (print_ada_task_info): Update.
  91         * ada-lang.c (print_it_exception, print_mention_exception):
  92         Update.
  93
  94 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
  95
  96         PR breakpoints/24541
  97         * gdbarch.c: Regenerate.
  98         * gdbarch.h: Regenerate.
  99         * gdbarch.sh: Adjust return type and parameter types for
 100         'stap_adjust_register'.
 101         (i386_stap_adjust_register): Adjust signature and return new
 102         register name.
 103         * stap-probe.c (stap_parse_register_operand): Adjust use of
 104         'gdbarch_stap_adjust_register'.
 105
 106 2019-07-17  Tom Tromey  <tromey@adacore.com>
 107
 108         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 109         declare VEC.
 110         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 111         std::vector.
 112         (struct s390_process_info): Add initializers.
 113         (s390_add_process): Use new.
 114         (s390_linux_nat_target::low_forget_process): Use delete.
 115         (s390_linux_nat_target::low_new_fork)
 116         (s390_linux_nat_target::stopped_by_watchpoint)
 117         (s390_linux_nat_target::low_prepare_to_resume)
 118         (s390_linux_nat_target::insert_watchpoint)
 119         (s390_linux_nat_target::insert_hw_breakpoint)
 120         (s390_linux_nat_target::remove_watchpoint)
 121         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 122
 123 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 124
 125         * aarch64-fbsd-nat.c: Include regcache.h.
 126         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 127         argument.
 128         (aarch64_fbsd_nat_target::fetch_registers)
 129         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 130         variable.
 131         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 132
 133 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 134
 135         * fbsd-nat.c: Include gdbarch.h.
 136
 137 2019-07-15  Tom Tromey  <tromey@adacore.com>
 138
 139         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 140
 141 2019-07-15  Tom Tromey  <tromey@adacore.com>
 142
 143         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 144         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 145         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 146         * cli-out.c (cli_ui_out::do_field_int): New method.
 147         * ui-out.c (ui_out::field_unsigned): New method.
 148         * symfile.c (generic_load): Use field_unsigned.
 149         (print_transfer_performance): Likewise.
 150         * record-btrace.c (ui_out_field_uint): Remove.
 151         (btrace_call_history_insn_range, btrace_call_history): Use
 152         field_unsigned.
 153         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 154         field_unsigned.
 155         * ui-out.h (class ui_out) <field_unsigned>: New method.
 156         <do_field_unsigned>: Likewise.
 157
 158 2019-07-15  Tom Tromey  <tromey@adacore.com>
 159
 160         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 161         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 162         * target.c (flash_erase_command): Use field_string.
 163         * infrun.c (print_signal_received_reason): Use field_string.
 164         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 165         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 166         field_string.
 167         * ada-tasks.c (print_ada_task_info): Use field_string.
 168
 169 2019-07-15  Tom Tromey  <tromey@adacore.com>
 170
 171         * target.c (flash_erase_command): Use field_core_addr.
 172         * symfile.c (generic_load): Use field_core_addr.
 173         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 174         Use field_core_addr.
 175         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 176         field_core_addr.
 177
 178 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 179
 180         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 181         value if its desired type is smaller than a CORE_ADDR and signed.
 182
 183 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 184
 185         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 186         of changes to field names, and use new is_reference field to
 187         decide if a property is a reference or not.
 188         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 189         field.
 190         (struct dwarf2_property_baton): Update header comment, rename
 191         'referenced_type' to 'property_type' and update comments.
 192         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 193         default property type, store in property baton, update to take
 194         accound of renamed field.
 195         (read_func_scope): Update call to attr_to_dynamic_prop.
 196         (read_array_type): Likewise.
 197         (dwarf2_per_cu_addr_sized_int_type): New function.
 198         (read_subrange_index_type): Move type finding code to
 199         dwarf2_per_cu_addr_sized_int_type.
 200         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 201         (dwarf2_per_cu_addr_type): New function.
 202         (set_die_type): Update calls to attr_to_dynamic_prop.
 203
 204 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 205
 206         * dwarf2read.c (read_subrange_index_type): New function.
 207         (read_subrange_type): Move code into new function and call it.
 208         * gdbtypes.c (create_range_type): Add some asserts.
 209
 210 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 211
 212         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 213         update return statements.
 214         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 215         declaration, and update comment to match.
 216         * gdbtypes.c (resolve_dynamic_array): Update call to
 217         dwarf2_evaluate_property to match new return type.
 218
 219 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 220
 221         * valarith.c (value_subscripted_rvalue): Change lowerbound
 222         parameter type from int to LONGEST.
 223         * value.h (value_subscripted_rvalue): Likewise in declaration.
 224
 225 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 226
 227         * cli/cli-utils.c (info_print_command_completer): New function.
 228         * cli/cli-utils.h: Add 'completer.h' include, and forward
 229         declaration for 'struct cmd_list_element'.
 230         (info_print_command_completer): Declare.
 231         * stack.c (_initialize_stack): Add completer for 'info locals' and
 232         'info args'.
 233         * symtab.c (_initialize_symtab): Add completer for 'info
 234         variables' and 'info functions'.
 235         * NEWS: Mention completion for additional info commands.
 236
 237 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 238
 239         * cli/cli-utils.c (extract_info_print_args): Delete.
 240         (extract_arg_maybe_quoted): Delete.
 241         (info_print_options_defs): New variable.
 242         (make_info_print_options_def_group): New function.
 243         (extract_info_print_options): Define new function.
 244         * cli/cli-utils.h (extract_info_print_args): Delete.
 245         (struct info_print_options): New structure.
 246         (extract_info_print_options): Declare new function.
 247         * stack.c (info_locals_command): Update to use new
 248         extract_info_print_options, also add a header comment.
 249         (info_args_command): Likewise.
 250         * symtab.c (info_variables_command): Likewise.
 251         (info_functions_command): Likewise.
 252
 253 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 254
 255         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 256         to extract string arguments.
 257         * common/common-utils.c (extract_string_maybe_quoted): New function.
 258         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 259
 260 2019-07-11  Tom Tromey  <tromey@adacore.com>
 261
 262         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 263         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 264         * top.h (gdbinit): Don't declare.
 265         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 266         into...
 267         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 268         * top.c (gdb_init): Don't call init_cli_cmds.
 269         (gdbinit): Remove.
 270         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 271
 272 2019-07-11  Tom Tromey  <tromey@adacore.com>
 273
 274         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 275         after it has been moved.
 276
 277 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 278
 279         * valops.c (value_must_coerce_to_target): Change return type to
 280         bool.
 281         * value.h (value_must_coerce_to_target): Likewise.
 282
 283 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 284
 285         * breakpoint.c (is_hardware_watchpoint): Remove
 286         forward-declaration.
 287         (is_masked_watchpoint): Change return type to bool.
 288         (is_tracepoint): Likewise.
 289         (is_breakpoint): Likewise.
 290         (is_hardware_watchpoint): Likewise.
 291         (is_watchpoint): Likewise.
 292         (is_no_memory_software_watchpoint): Likewise.
 293         (is_catchpoint): Likewise.
 294         (breakpoint_1): Make FILTER parameter's return type bool.
 295         is_masked_watchpoint): Change return type to bool.
 296         (save_breakpoints): Make FILTER parameter's return type bool.
 297         * breakpoint.h (is_breakpoint): Change return type to bool.
 298         (is_watchpoint): Likewise.
 299         (is_catchpoint): Likewise.
 300         (is_tracepoint): Likewise.
 301
 302 2019-07-10  Tom Tromey  <tom@tromey.com>
 303
 304         * defs.h: Don't include gdbarch.h.
 305         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 306         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 307         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 308         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 309         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 310         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 311         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 312         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 313         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 314         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 315         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 316         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 317         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 318         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 319         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 320         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 321         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 322         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 323         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 324         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 325         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 326         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 327         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 328         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 329         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 330         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 331         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 332
 333 2019-07-10  Tom Tromey  <tromey@adacore.com>
 334
 335         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 336         * breakpoint.c (init_ada_exception_breakpoint): Register as
 337         bp_catchpoint.
 338         (print_one_breakpoint_location, print_one_breakpoint): Use
 339         is_ada_exception_catchpoint.
 340         * ada-lang.c (class ada_catchpoint_location): Pass
 341         bp_loc_software_breakpoint to bp_location constructor.
 342         (is_ada_exception_catchpoint): New function.
 343
 344 2019-07-10  Tom Tromey  <tromey@adacore.com>
 345
 346         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 347         VEC.
 348         (struct arm_exidx_entry): New method operator<.
 349         (struct arm_exidx_data) <section_maps>: Change type.
 350         (arm_exidx_data_free): Remove.
 351         (arm_exidx_data_key): Change type.  Move lower.
 352         (arm_exidx_new_objfile): Update.
 353         (arm_compare_exidx_entries): Remove.
 354         (arm_find_exidx_entry, _initialize_arm_tdep)
 355
 356 2019-07-10  Tom Tromey  <tromey@adacore.com>
 357
 358         * solib-spu.c (ocl_program_data_key): Change type.
 359         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 360         Update.
 361
 362 2019-07-10  Tom Tromey  <tromey@adacore.com>
 363
 364         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 365         (struct solib_aix_inferior_data) <library_list>: Change type.
 366         (solib_aix_inferior_data_handle): Change type.
 367         (get_solib_aix_inferior_data): Update.
 368         (solib_aix_free_library_list): Remove.
 369         (library_list_start_library): Update.
 370         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 371         return type.
 372         (solib_aix_get_library_list)
 373         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 374         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 375
 376 2019-07-10  Tom Tromey  <tromey@adacore.com>
 377
 378         * solib-dsbt.c (struct dsbt_info): Add initializers.
 379         (solib_dsbt_pspace_data): Change type.
 380         (dsbt_pspace_data_cleanup): Remove.
 381         (get_dsbt_info, _initialize_dsbt_solib): Update.
 382
 383 2019-07-10  Tom Tromey  <tromey@adacore.com>
 384
 385         * spu-tdep.c (spu_overlay_data): Change type.
 386         (spu_get_overlay_table, spu_overlay_new_objfile)
 387         (_initialize_spu_tdep): Update.
 388
 389 2019-07-10  Tom Tromey  <tromey@adacore.com>
 390
 391         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 392         destructor.
 393         (dbx_objfile_data_key): Change type and declare later.
 394         (DBX_SYMFILE_INFO): Rewrite.
 395         * dbxread.c (dbx_objfile_data_key): Change type.
 396         (dbx_symfile_init): Update.
 397         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 398         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 399         (stabsect_build_psymtabs, _initialize_dbxread): Update.
 400
 401 2019-07-10  Tom Tromey  <tromey@adacore.com>
 402
 403         * jit.c (jit_program_space_key): Change type.  Move lower.
 404         (get_jit_program_space_data): Update.
 405         (jit_program_space_data_cleanup): Remove.
 406         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
 407         Update.
 408         (struct jit_program_space_data): Add initializers.
 409
 410 2019-07-10  Tom Tromey  <tromey@adacore.com>
 411
 412         * solib-darwin.c (struct darwin_info): Add initializers.
 413         (solib_darwin_pspace_data): Change type.
 414         (darwin_pspace_data_cleanup): Remove.
 415         (get_darwin_info, _initialize_darwin_solib): Update.
 416
 417 2019-07-10  Tom Tromey  <tromey@adacore.com>
 418
 419         * remote-sim.c (struct sim_inferior_data): Add initializers,
 420         constructor, and destructor.
 421         (sim_inferior_data_key): Change type.  Move lower.
 422         (check_for_duplicate_sim_descriptor): Update.
 423         (get_sim_inferior_data): Use new.  Update.
 424         (~sim_inferior_data_cleanup): Rename from
 425         sim_inferior_data_cleanup.  Simplify.
 426         (gdbsim_close_inferior, simulator_command)
 427         (sim_command_completer, _initialize_remote_sim): Update.
 428         (next_pid, INITIAL_PID): Move earlier.
 429
 430 2019-07-10  Tom Tromey  <tromey@adacore.com>
 431
 432         * python/python-internal.h (create_thread_object): Return
 433         gdbpy_ref.
 434         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
 435         * python/py-inferior.c (struct threadlist_entry): Add
 436         constructor.
 437         <thread_obj>: Now a gdbpy_ref.
 438         (thread_to_thread_object): Update.
 439         (add_thread_object): Use new.
 440         (delete_thread_object): Use delete.
 441         (infpy_threads): Update.
 442         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
 443         GIL.
 444
 445 2019-07-10  Tom Tromey  <tromey@adacore.com>
 446
 447         * valops.c (value_cast): Specialize error message for Ada.
 448
 449 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 450
 451         * breakpoint.c (breakpoint_1): Update doc and parameter names.
 452
 453 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 454
 455         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
 456         bpstat_should_step): Return bool, adjust comments.
 457         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
 458         bpstat_should_step): Likewise.
 459
 460 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 461
 462         * features/Makefile: Use feature target descriptions for Arm.
 463         * features/arm/arm-core.c: Generate new file.
 464         * features/arm/arm-fpa.c: Likewise.
 465         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
 466         * features/arm/arm-m-profile.c: Likewise.
 467         * features/arm/arm-vfpv2.c: Likewise.
 468         * features/arm/arm-vfpv3.c: Likewise.
 469         * features/arm/xscale-iwmmxt.c: Likewise.
 470         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
 471
 472 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 473
 474         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
 475         ptrace earlier.
 476
 477 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 478
 479         * features/aarch64-pauth.c: Regenerate.
 480
 481 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
 482
 483         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
 484         bool.
 485         (bpstat_what): Use false instead of 0.
 486
 487 2019-07-09  Pedro Alves  <palves@redhat.com>
 488
 489         * break-catch-throw.c (is_exception_catchpoint): New.
 490         * breakpoint.c (print_one_breakpoint_location): New parameter
 491         'raw_loc'.  Handle it.  Use
 492         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
 493         looking at the breakpoint's type.
 494         (print_one_breakpoint): If handling "maint info breakpoints", also
 495         print locations of exception catchpoints.
 496         * breakpoint.h (is_exception_catchpoint): Declare.
 497
 498 2019-07-09  Pedro Alves  <palves@redhat.com>
 499
 500         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
 501         "addr" field.
 502         (allocate_location_exception_catchpoint): New.
 503         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
 504         (initialize_throw_catchpoint_ops): Install
 505         allocate_location_exception_catchpoint as allocate_location
 506         method.
 507         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
 508         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
 509         bp_loc_other.
 510         (breakpoint_address_is_meaningful): Delete.
 511         (bl_address_is_meaningful): New.
 512         (breakpoint_locations_match): Adjust comment.
 513         (bp_location_from_bp_type): New, factored out of...
 514         (bp_location::bp_location(breakpoint *)): ... this.
 515         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
 516         factored out of...
 517         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
 518         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
 519         breakpoint_address_is_meaningful.
 520         (bp_locations_compare): Adjust comment.
 521         (update_global_location_list): Use bl_address_is_meaningful
 522         instead of breakpoint_address_is_meaningful.
 523         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
 524         explicit.
 525         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
 526         * python/py-breakpoint.c (bppy_get_location): No longer check
 527         whether location is null.
 528
 529 2019-07-09  Pedro Alves  <palves@redhat.com>
 530
 531         PR c++/15468
 532         * breakpoint.c (print_one_breakpoint_location): Remove
 533         single-location assert.
 534
 535 2019-07-09  Tom Tromey  <tom@tromey.com>
 536
 537         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
 538         * configure: Rebuild.
 539         * configure.ac: Change common to gdbsupport.
 540         * gdbsupport: Rename from common.
 541         * acinclude.m4: Change common to gdbsupport.
 542         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
 543         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
 544         gdbsupport.
 545         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
 546         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
 547         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
 548         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
 549         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
 550         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
 551         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
 552         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
 553         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
 554         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
 555         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
 556         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
 557         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
 558         coff-pe-read.c, command.h, compile/compile-c-support.c,
 559         compile/compile-c.h, compile/compile-cplus-symbols.c,
 560         compile/compile-cplus-types.c, compile/compile-cplus.h,
 561         compile/compile-loc2c.c, compile/compile.c, completer.c,
 562         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 563         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 564         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 565         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 566         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 567         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 568         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 569         features/aarch64-core.c, features/aarch64-fpu.c,
 570         features/aarch64-pauth.c, features/aarch64-sve.c,
 571         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 572         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 573         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 574         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 575         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 576         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 577         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 578         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 579         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 580         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 581         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 582         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 583         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 584         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 585         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 586         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 587         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 588         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 589         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 590         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 591         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 592         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 593         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 594         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 595         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 596         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 597         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 598         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 599         minsyms.c, mips-linux-tdep.c, namespace.h,
 600         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 601         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 602         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 603         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 604         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 605         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 606         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 607         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 608         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 609         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 610         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 611         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 612         procfs.c, producer.c, progspace.h, psymtab.h,
 613         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 614         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 615         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 616         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 617         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
 618         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
 619         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
 620         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
 621         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
 622         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
 623         target-memory.c, target.c, target.h, target/waitstatus.c,
 624         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
 625         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
 626         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
 627         unittests/array-view-selftests.c,
 628         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
 629         unittests/common-utils-selftests.c,
 630         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
 631         unittests/format_pieces-selftests.c,
 632         unittests/function-view-selftests.c,
 633         unittests/lookup_name_info-selftests.c,
 634         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
 635         unittests/mkdir-recursive-selftests.c,
 636         unittests/observable-selftests.c,
 637         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
 638         unittests/parse-connection-spec-selftests.c,
 639         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
 640         unittests/scoped_fd-selftests.c,
 641         unittests/scoped_mmap-selftests.c,
 642         unittests/scoped_restore-selftests.c,
 643         unittests/string_view-selftests.c, unittests/style-selftests.c,
 644         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
 645         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
 646         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
 647         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
 648         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
 649         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
 650
 651 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 652
 653         * linespec.c (decode_digits_list_mode): Set explicit_line to a
 654         bool value.
 655         (decode_digits_ordinary): Set explicit_line field in sal.
 656         * symtab.c (skip_prologue_sal): Don't skip prologue for a
 657         symtab_and_line that was set on an explicit line number in
 658         assembler code.  Do always update the recorded symtab and line if
 659         we do skip the prologue.
 660
 661 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 662
 663         * breakpoint.c (set_breakpoint_location_function): Remove
 664         explicit_loc parameter.
 665         (momentary_breakpoint_from_master): Update call to
 666         set_breakpoint_location_function.
 667         (add_location_to_breakpoint): Likewise.
 668
 669 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 670
 671         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
 672         required features based on default bfd type when no specific bfd
 673         is present.
 674
 675 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 676
 677         * NEWS: Mention that GDB printf and eval commands can now print
 678         C-style and Ada-style convenience var strings without
 679         calling the inferior.
 680         * printcmd.c (printf_c_string): Locally print GDB internal var
 681         instead of transiting via the inferior.
 682         (printf_wide_c_string): Likewise.
 683
 684 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 685
 686         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
 687
 688 2019-07-04  Tom Tromey  <tom@tromey.com>
 689
 690         PR tui/24724:
 691         * tui/tui-winsource.c (tui_clear_source_content): Update.
 692         (tui_source_window_base::set_is_exec_point_at): Fix comment.
 693         (tui_update_breakpoint_info): Update.
 694         (tui_set_exec_info_content): Update.
 695         * tui/tui-source.c (tui_set_source_content_nil): Update.
 696         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
 697         has_break.
 698         * tui/tui-data.h (enum tui_bp_flag): New.
 699         (tui_bp_flags): New enum flags type.
 700         (struct tui_source_element) <break_mode>: Change type.  Rename
 701         from has_break.
 702         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
 703         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
 704         constants.
 705         * tui/tui-winsource.h: Fix comment.
 706
 707 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 708
 709         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
 710         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
 711         (store_fpregs_to_thread)
 712         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 713         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
 714         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
 715         (IWMMXT_REGS_SIZE): Add define.
 716         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
 717         (fetch_vfp_regs, store_vfp_regs)
 718         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 719         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
 720
 721 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 722
 723         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
 724         defines.
 725         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
 726         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
 727         (ARM_INT_REGISTER_SIZE): ...to this.
 728         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
 729         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
 730         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
 731         (arm_linux_collect_gregset, supply_nwfpe_register)
 732         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
 733         defines.
 734         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
 735         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
 736         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
 737         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
 738         (arm_return_in_memory, arm_store_return_value)
 739         (arm_get_longjmp_target, arm_register_g_packet_guesses)
 740         (arm_record_ld_st_multiple): Likewise.
 741         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
 742         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
 743
 744 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 745
 746         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
 747         AARCH64_DISPLACED_MODIFIED_INSNS.
 748         * aarch64-tdep.c (struct aarch64_displaced_step_data)
 749         (aarch64_displaced_step_copy_insn): Likewise.
 750         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 751         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
 752         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
 753         ARM_DISPLACED_MODIFIED_INSNS.
 754         * arm-tdep.c (arm_gdbarch_init): Likewise.
 755         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 756         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
 757         (struct arm_displaced_step_closure): Use
 758         ARM_DISPLACED_MODIFIED_INSNS.
 759
 760 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 761
 762         * features/Makefile: Remove unused xml files.
 763         * features/aarch64.xml: Remove.
 764         * features/i386/amd64-avx-avx512-linux.xml: Remove.
 765         * features/i386/amd64-avx-avx512.xml: Remove.
 766         * features/i386/amd64-avx-linux.xml: Remove.
 767         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
 768         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
 769         * features/i386/amd64-avx-mpx-linux.xml: Remove.
 770         * features/i386/amd64-avx-mpx.xml: Remove.
 771         * features/i386/amd64-avx.xml: Remove.
 772         * features/i386/amd64-linux.xml: Remove.
 773         * features/i386/amd64-mpx-linux.xml: Remove.
 774         * features/i386/amd64-mpx.xml: Remove.
 775         * features/i386/amd64.xml: Remove.
 776         * features/i386/i386-avx-avx512-linux.xml: Remove.
 777         * features/i386/i386-avx-avx512.xml: Remove.
 778         * features/i386/i386-avx-linux.xml: Remove.
 779         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
 780         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
 781         * features/i386/i386-avx-mpx-linux.xml: Remove.
 782         * features/i386/i386-avx-mpx.xml: Remove.
 783         * features/i386/i386-avx.xml: Remove.
 784         * features/i386/i386-linux.xml: Remove.
 785         * features/i386/i386-mmx-linux.xml: Remove.
 786         * features/i386/i386-mmx.xml: Remove.
 787         * features/i386/i386-mpx-linux.xml: Remove.
 788         * features/i386/i386-mpx.xml: Remove.
 789         * features/i386/i386.xml: Remove.
 790         * features/i386/x32-avx-avx512-linux.xml: Remove.
 791         * features/i386/x32-avx-linux.xml: Remove.
 792         * features/i386/x32-linux.xml: Remove.
 793
 794 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 795
 796         * regformats/aarch64.dat: Remove.
 797         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
 798         * regformats/i386/amd64-avx-linux.dat: Remove.
 799         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
 800         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
 801         * regformats/i386/amd64-linux.dat: Remove.
 802         * regformats/i386/amd64-mpx-linux.dat: Remove.
 803         * regformats/i386/amd64.dat: Remove.
 804         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
 805         * regformats/i386/i386-avx-linux.dat: Remove.
 806         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
 807         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
 808         * regformats/i386/i386-linux.dat: Remove.
 809         * regformats/i386/i386-mmx-linux.dat: Remove.
 810         * regformats/i386/i386-mpx-linux.dat: Remove.
 811         * regformats/i386/i386.dat: Remove.
 812         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
 813         * regformats/i386/x32-avx-linux.dat: Remove.
 814         * regformats/i386/x32-linux.dat: Remove.
 815
 816 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 817
 818         * aarch64-tdep.c: Remove xml self tests.
 819         * amd64-linux-tdep.c: Likewise.
 820         * amd64-tdep.c: Likewise.
 821         * i386-linux-tdep.c: Likewise.
 822         * i386-tdep.c: Likewise.
 823
 824 2019-07-03  Pedro Alves  <palves@redhat.com>
 825
 826         PR cli/24732
 827         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
 828         (pipe_cmd_option_defs): New.
 829         (make_pipe_cmd_options_def_group): New.
 830         (pipe_command): Use gdb::option::process_options.
 831         (pipe_command_completer): New function.
 832         (_initialize_cli_cmds): Install completer for "pipe" command.
 833
 834 2019-07-03  Pedro Alves  <palves@redhat.com>
 835
 836         * cli/cli-option.c (union option_value) <string>: New field.
 837         (struct option_def_and_value): Add ctor, move ctor, dtor and
 838         use DISABLE_COPY_AND_ASSIGN.
 839         (option_def_and_value::clear_value): New.
 840         (parse_option, save_option_value_in_ctx, get_val_type_str)
 841         (add_setshow_cmds_for_options): Handle var_string.
 842         * cli-option.h (union option_def::var_address) <string>: New
 843         field.
 844         (struct string_option_def): New.
 845         * maint-test-options.c (struct test_options_opts): Add default
 846         ctor and use DISABLE_COPY_AND_ASSIGN.
 847         <string_opt>: New field.
 848         (test_options_opts::~test_options_opts): New.
 849         (test_options_opts::dump): Also dump "-string".
 850         (test_options_option_defs): Install "string.
 851
 852 2019-07-03  Pedro Alves  <palves@redhat.com>
 853
 854         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
 855         option_value with a null enumeration.
 856         (complete_options): Save the option values in the context.
 857         (save_option_value_in_ctx): New, factored out from ...
 858         (process_options): ... here.
 859         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
 860         of the function.
 861         * maint-test-options.c (test_options_opts::dump): New, factored
 862         out from ...
 863         (maintenance_test_options_command_mode): ... here.
 864         (maintenance_test_options_command_completion_result): Delete.
 865         (maintenance_test_options_command_completion_text): Update
 866         comment.
 867         (maintenance_show_test_options_completion_result): Change
 868         prototype.  Just print
 869         maintenance_test_options_command_completion_text.
 870         (save_completion_result): New.
 871         (maintenance_test_options_completer_mode): Pass options context to
 872         complete_options, and then save a dump.
 873         (_initialize_maint_test_options): Use add_cmd to install "maint
 874         show test-options-completion-result".
 875
 876 2019-07-03  Pedro Alves  <palves@redhat.com>
 877
 878         * NEWS (New commands): Mention "with" and "maint with".
 879         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
 880         (with_command, with_command_completer): New.
 881         (pipe_command): Adjust to new repeat_previous
 882         interface.
 883         (_initialize_cli_cmds): Install the "with" command and its "w"
 884         alias.
 885         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
 886         declarations.
 887         * cli/cli-setshow.c (parse_cli_var_uinteger)
 888         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
 889         argument strings for all var_types.
 890         (get_setshow_command_value_string): New, factored out from ...
 891         (do_show_command): ... this.
 892         * cli/cli-setshow.h: Include <string>.
 893         (get_setshow_command_value_string): Declare.
 894         * command.h (repeat_previous): Now returns const char *.  Adjust
 895         comment.
 896         * maint.c: Include "cli/cli-cmds.h".
 897         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
 898         (_initialize_maint_cmds): Register the "maintenance with" command.
 899         * top.c (repeat_previous): Move bits from pipe_command here:
 900         Return the saved command line, if any; error out if there's no
 901         command to relaunch.
 902
 903 2019-07-03  Pedro Alves  <palves@redhat.com>
 904
 905         * NEWS (New commands): Mention "maint set/show test-settings"
 906         instead of "maint test-settings".
 907         * maint-test-settings.c (maintenance_test_settings_list): Delete.
 908         (maintenance_test_settings_set_list): Rename to ...
 909         (maintenance_set_test_settings_list): ... this.
 910         (maintenance_test_settings_show_list): Rename to  ...
 911         (maintenance_show_test_settings_list): ... this.
 912         (maintenance_test_settings_cmd): Delete.
 913         (maintenance_test_settings_set_cmd): ...
 914         (maintenance_set_test_settings_cmd): ... this.
 915         (maintenance_test_settings_show_cmd): ...
 916         (maintenance_show_test_settings_cmd): ... this.
 917         (maintenance_test_settings_show_value_cmd):
 918         (maintenance_show_test_settings_value_cmd): ... this.
 919         (_initialize_maint_test_settings): No longer install the "maint
 920         test-settings" prefix command.  Rename "maint test-settings set"
 921         to "maint set test-settings", and "maint test-settings show" to
 922         "maint show test-settings".  Adjust all subcommands.
 923
 924 2019-07-03  Pedro Alves  <palves@redhat.com>
 925
 926         * maint-test-settings.c: Fix file's intro comment.  Replace all
 927         references to "test-options" with references to "test-settings",
 928         in comments.
 929
 930 2019-07-03  Pedro Alves  <palves@redhat.com>
 931
 932         * maint-test-settings.c (maintenance_test_settings_xxx)
 933         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
 934         New.
 935         (maintenance_test_settings_enums): Use them.
 936         (maintenance_test_settings_enum): Default to
 937         maintenance_test_settings_xxx.
 938         (_initialize_maint_test_settings): Initialize
 939         MAINTENANCE_TEST_SETTINGS_FILENAME.
 940
 941 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 942
 943         * breakpoint.h (remove_breakpoints_inf): Change return type to
 944         void, move function documentation here.
 945         * breakpoint.c (remove_breakpoints_inf): Change return type to
 946         void, move function documentation to header.
 947
 948 2019-07-02  Pedro Alves  <palves@redhat.com>
 949
 950         * NEWS (Completion improvements): Mention "info threads".
 951         * thread.c (struct info_threads_opts, info_threads_option_defs)
 952         (make_info_threads_options_def_group): New.
 953         (info_threads_command): Use gdb::option::process_options.
 954         (info_threads_command_completer): New.
 955         (_initialize_thread): Use gdb::option::build_help to build the
 956         help text for "info threads".
 957
 958 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 959
 960         * defs.h (generic_load): Move from here...
 961         * symfile.h (generic_load): ... to here.  Rename name parameter
 962         to args.
 963         * symfile.c (generic_load): Add comment.
 964
 965 2019-07-01  Tom Tromey  <tromey@adacore.com>
 966
 967         * dwarf2read.c
 968         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
 969         declaration of without_params.  Fix formatting.
 970
 971 2019-07-01  Tom Tromey  <tromey@adacore.com>
 972
 973         * ada-exp.y (find_primitive_type): Update.
 974         * ada-lang.h (ada_lookup_symbol): Update.
 975         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
 976         parameter.
 977         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
 978
 979 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 980
 981         PR breakpoints/24541
 982         * gdbarch.c: Regenerate.
 983         * gdbarch.h: Regenerate.
 984         * gdbarch.sh: Add 'stap_adjust_register'.
 985         * i386-tdep.c: Include '<unordered_set>'.
 986         (i386_stap_adjust_register): New function.
 987         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
 988         * stap-probe.c (stap_parse_register_operand): Call
 989         'gdbarch_stap_adjust_register'.
 990
 991 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 992
 993         PR python/24742
 994         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
 995         * python/python.c (do_start_initialization): Use 'xmalloc'
 996         instead of 'PyMem_Malloc'.
 997
 998 2019-06-28  Tom Tromey  <tromey@adacore.com>
 999
1000         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1001         for Ada.
1002
1003 2019-06-27  Tom Tromey  <tromey@adacore.com>
1004
1005         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1006         objfile_key.
1007         (arm_find_mapping_symbol, arm_record_special_symbol)
1008         (_initialize_arm_tdep): Update.
1009         (arm_objfile_data_free): Remove.
1010
1011 2019-06-27  Tom Tromey  <tromey@adacore.com>
1012
1013         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1014         to cp_print_static_field.
1015
1016 2019-06-26  Tom Tromey  <tromey@adacore.com>
1017
1018         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1019         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1020         declare.
1021
1022 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1023
1024         * features/aarch64-core.c (create_feature_aarch64_core):
1025         Regenerate.
1026         * features/aarch64-core.xml: Add cpsr flags.
1027
1028 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1029
1030         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1031         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1032
1033 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1034
1035         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1036         field.
1037         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1038         use.
1039         (arm_record_special_symbol): Don't insert new symbol in sorted
1040         position, push it at the end.
1041
1042 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1043
1044         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1045         (arm_mapping_symbol_s): Remove.
1046         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1047         (arm_mapping_symbol_vec): New typedef.
1048         (struct arm_per_objfile): Add constructor.
1049         <section_maps>: Change type to
1050         std::unique_ptr<arm_mapping_symbol_vec[]>.
1051         (arm_compare_mapping_symbols): Remove.
1052         (arm_find_mapping_symbol): Adjust to section_maps type change.
1053         (arm_objfile_data_free): Call delete on arm_per_objfile.
1054         (arm_record_special_symbol): Adjust to section_maps type change.
1055         Allocate arm_per_objfile with new.
1056
1057 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1058
1059         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1060         with the command prefix.
1061
1062 2019-06-25  Tom Tromey  <tom@tromey.com>
1063
1064         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1065         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1066
1067 2019-06-25  Tom Tromey  <tom@tromey.com>
1068
1069         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1070         type.
1071         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1072         protected.
1073
1074 2019-06-25  Tom Tromey  <tom@tromey.com>
1075
1076         * tui/tui-winsource.c
1077         (tui_source_window_base::set_is_exec_point_at): Add check against
1078         LOA_ADDRESS.
1079
1080 2019-06-25  Tom Tromey  <tom@tromey.com>
1081
1082         * tui/tui-source.c (tui_set_source_content): Don't check before
1083         xfree.
1084         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1085
1086 2019-06-25  Tom Tromey  <tom@tromey.com>
1087
1088         * tui/tui-winsource.h (tui_update_source_window_as_is)
1089         (tui_alloc_source_buffer, tui_line_is_displayed)
1090         (tui_addr_is_displayed): Change type of win_info.
1091         * tui/tui-winsource.c (tui_update_source_window_as_is)
1092         (tui_clear_source_content, tui_show_source_line)
1093         (tui_show_source_content, tui_source_window_base::refill)
1094         (tui_source_window_base::set_is_exec_point_at)
1095         (tui_source_window_base::set_is_exec_point_at)
1096         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1097         (tui_alloc_source_buffer, tui_line_is_displayed)
1098         (tui_addr_is_displayed): Change type of win_info.  Update.
1099         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1100         (tui_source_window_base::do_make_visible_with_new_height):
1101         Update.
1102         * tui/tui-source.c (tui_set_source_content)
1103         (tui_set_source_content_nil)
1104         (tui_source_window::do_scroll_vertical): Update.
1105         * tui/tui-layout.c (show_layout): Update.
1106         * tui/tui-disasm.c (tui_set_disassem_content)
1107         (tui_disasm_window::do_scroll_vertical): Update.
1108         * tui/tui-data.h (tui_win_content): Remove.
1109         (struct tui_gen_win_info) <content, content_size>: Remove.
1110         (struct tui_source_element): Add initializers and destructor.
1111         (union tui_which_element, struct tui_win_element): Remove.
1112         (struct tui_source_window_base) <content>: New field.
1113         (struct tui_data_window): Remove destructor.
1114         (tui_alloc_content, tui_free_win_content)
1115         (tui_free_all_source_wins_content): Don't declare.
1116         * tui/tui-data.c (tui_initialize_static_data): Update.
1117         (init_content_element, tui_alloc_content): Remove.
1118         (~tui_gen_win_info): Update.
1119         (~tui_data_window, tui_free_all_source_wins_content)
1120         (tui_free_win_content, free_content, free_content_elements):
1121         Remove.
1122
1123 2019-06-25  Tom Tromey  <tom@tromey.com>
1124
1125         * tui/tui-winsource.h (tui_clear_source_content)
1126         (tui_erase_source_content, tui_show_source_content): Change type
1127         of win_info.
1128         * tui/tui-winsource.c (tui_clear_source_content)
1129         (tui_erase_source_content, tui_show_source_content): Change type
1130         of win_info.
1131         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1132         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1133         win_info.
1134         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1135         win_info.
1136         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1137
1138 2019-06-25  Tom Tromey  <tom@tromey.com>
1139
1140         * tui/tui-winsource.c (tui_clear_source_content)
1141         (tui_source_window_base::set_is_exec_point_at): Update.
1142         * tui/tui-source.c (tui_set_source_content_nil): Update.
1143         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1144         a bool.
1145         * tui/tui-data.c (init_content_element): Update.
1146
1147 2019-06-25  Tom Tromey  <tom@tromey.com>
1148
1149         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1150         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1151         * tui/tui-layout.c (init_and_make_win): Update.
1152         * tui/tui.h (enum tui_win_type): Update.
1153         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1154         tui_win_is_auxillary.
1155         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1156         tui_win_is_auxillary.
1157
1158 2019-06-25  Tom Tromey  <tom@tromey.com>
1159
1160         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1161         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1162         (tui_delete_data_content_windows, tui_display_all_data)
1163         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1164         Update.
1165         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1166         * tui/tui-regs.c (tui_last_regs_line_no)
1167         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1168         (tui_show_registers): Update.
1169         (tui_show_register_group): Return void.  Update.
1170         (tui_display_registers_from, tui_display_reg_element_at_line)
1171         (tui_display_registers_from_line, tui_check_register_values):
1172         Update.
1173         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1174         member.
1175         (struct tui_data_window) <regs_content>: Now a std::vector.
1176         <regs_content_count>: Remove.
1177         (tui_add_content_elements, tui_free_data_content): Don't declare.
1178         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1179         (init_content_element): Remove DATA_WIN case.  Add assert.
1180         (tui_add_content_elements): Remove.
1181         (tui_data_window): Update.
1182         (tui_free_data_content): Remove.
1183         (free_content_elements): Remove DATA_WIN case.
1184
1185 2019-06-25  Tom Tromey  <tom@tromey.com>
1186
1187         * tui/tui-data.c (tui_data_item_window): Update.
1188         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1189         * tui/tui-windata.c (tui_display_all_data)
1190         (tui_display_data_from_line): Update.
1191         (tui_check_data_values): Remove.
1192         * tui/tui-regs.c (tui_show_register_group)
1193         (tui_display_reg_element_at_line): Update.
1194         * tui/tui-hooks.c (tui_register_changed)
1195         (tui_refresh_frame_and_register_information): Call
1196         tui_check_register_values.
1197         * tui/tui-data.h (struct tui_data_window) <data_content,
1198         data_content_count, data_type>: Remove.
1199         (enum tui_data_type): Remove.
1200
1201         * tui/tui-data.c (tui_data_window::clear_detail)
1202         (~tui_data_window): Update.
1203
1204 2019-06-25  Tom Tromey  <tom@tromey.com>
1205
1206         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1207         declare.
1208         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1209         Rename from tui_first_data_item_displayed.  Update.
1210         (tui_data_window::refresh_all)
1211         (tui_data_window::do_scroll_vertical): Update.
1212         * tui/tui-data.h (struct tui_data_window)
1213         <first_data_item_displayed>: Declare new method.
1214
1215 2019-06-25  Tom Tromey  <tom@tromey.com>
1216
1217         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1218         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1219         contents...
1220         (tui_initialize_static_data): ...here.
1221
1222 2019-06-25  Tom Tromey  <tom@tromey.com>
1223
1224         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1225         (tui_display_registers_from, tui_check_register_values): Update.
1226         (tui_display_register): Remove win_info parameter; update.
1227         (tui_get_register): Change type of parameters.
1228         * tui/tui-data.h (struct tui_data_element): Remove.
1229         (union tui_which_element) <data>: Remove.
1230         <data_window>: Change type.
1231         (struct tui_data_item_window): New.
1232         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1233         case.  Add assert.
1234         (~tui_data_item_window): New destructor.
1235         (free_content_elements): Remove DATA_ITEM_WIN case.
1236
1237 2019-06-25  Tom Tromey  <tom@tromey.com>
1238
1239         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1240         Remove.
1241
1242 2019-06-25  Tom Tromey  <tom@tromey.com>
1243
1244         * tui/tui-data.h (struct tui_command_element): Remove.
1245         (union tui_which_element) <command>: Remove.
1246         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1247         assert.
1248         (free_content_elements): Remove CMD_WIN case.
1249
1250 2019-06-25  Tom Tromey  <tom@tromey.com>
1251
1252         * tui/tui-layout.c (tui_set_layout): Update.
1253         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1254         * tui/tui-data.c (layout_def): Update.
1255
1256 2019-06-25  Tom Tromey  <tom@tromey.com>
1257
1258         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1259         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1260         (tui_source_window_base::set_new_height): Update.
1261         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1262         Update.
1263         (tui_set_locator_fullname, tui_set_locator_info)
1264         (tui_show_frame_info): Update.
1265         * tui/tui-source.c (tui_set_source_content)
1266         (tui_source_is_displayed): Update.
1267         * tui/tui-layout.c (show_source_disasm_command, show_data)
1268         (show_source_or_disasm_and_command): Update.
1269         * tui/tui-disasm.c (tui_set_disassem_content)
1270         (tui_get_begin_asm_address): Update.
1271         * tui/tui-data.h (struct tui_locator_element): Remove.
1272         (union tui_which_element) <locator>: Remove.
1273         (struct tui_locator_window): New.
1274         (tui_locator_win_info_ptr): Change return type.
1275         * tui/tui-data.c (_locator): Change type.
1276         (tui_locator_win_info_ptr): Change return type.
1277         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1278         (tui_alloc_content): Add assert.
1279
1280 2019-06-25  Tom Tromey  <tom@tromey.com>
1281
1282         * tui/tui-winsource.c
1283         (tui_exec_info_window::maybe_allocate_content): New method.
1284         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1285         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1286         (make_source_or_disasm_window): Add cast.
1287         * tui/tui-data.h (union tui_which_element) <simple_string>:
1288         Remove.
1289         (struct tui_source_info): New.
1290         (struct tui_source_window_base) <execution_info>: Change type.
1291         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1292         case, and add assert.
1293         (tui_alloc_content): Add assert.
1294
1295 2019-06-25  Tom Tromey  <tom@tromey.com>
1296
1297         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1298         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1299         * tui/tui-data.c (tui_alloc_win_info): Remove.
1300
1301 2019-06-25  Tom Tromey  <tom@tromey.com>
1302
1303         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1304         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1305         can_highlight.
1306
1307 2019-06-25  Tom Tromey  <tom@tromey.com>
1308
1309         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1310         make_visible_with_new_height method.
1311         (tui_win_info::make_visible_with_new_height): New method.
1312         (tui_source_window_base::do_make_visible_with_new_height)
1313         (tui_data_window::do_make_visible_with_new_height)
1314         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1315         (make_visible_with_new_height): Remove.
1316         (tui_resize_all, tui_adjust_win_heights): Use
1317         make_visible_with_new_height method.
1318         * tui/tui-data.h (struct tui_win_info)
1319         <do_make_visible_with_new_height, make_visible_with_new_height>:
1320         New methods.
1321         (struct tui_source_window_base, struct tui_data_window)
1322         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1323         methods.
1324
1325 2019-06-25  Tom Tromey  <tom@tromey.com>
1326
1327         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1328         method.
1329         (update_tab_width): Call update_tab_width method.
1330         * tui/tui-data.h (struct tui_win_info)
1331         (struct tui_source_window_base) <update_tab_width>: New methods.
1332
1333 2019-06-25  Tom Tromey  <tom@tromey.com>
1334
1335         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1336         parameter.
1337         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1338         parameter.
1339         (tui_gen_win_info::make_visible): Update.
1340         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1341         parameter.
1342         * tui/tui-data.h (enum tui_box): New enum.
1343         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1344
1345 2019-06-25  Tom Tromey  <tom@tromey.com>
1346
1347         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1348         init_and_make_win for EXEC_INFO_WIN.
1349         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1350         longer inline.
1351         (struct tui_win_info) <~tui_win_info>: Inline.
1352         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1353         Don't declare.
1354         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1355         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1356         Remove.
1357         (tui_initialize_static_data): Update.
1358         (~tui_gen_win_info): Handle more cleanup here.
1359         (~tui_source_window_base): Delete "execution_info".
1360         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1361
1362 2019-06-25  Tom Tromey  <tom@tromey.com>
1363
1364         * tui/tui-layout.c (make_command_window): Don't set
1365         can_highlight.
1366         (show_source_disasm_command): Call the reset method.
1367         (show_data): Don't set can_highlight.  Call the reset method.
1368         (tui_gen_win_info::reset): Rename from init_gen_win_info
1369         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1370         (show_source_or_disasm_and_command): Call the reset method.
1371         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1372         (struct tui_cmd_window): Set can_highlight.
1373
1374 2019-06-25  Tom Tromey  <tom@tromey.com>
1375
1376         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1377         from make_visible.
1378         (tui_make_visible, tui_make_invisible): Rewrite.
1379         (tui_win_info::make_visible): Remove.
1380         (tui_source_window_base::make_visible): Update.
1381         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1382         method.  Moved from...
1383         (struct tui_win_info) <make_visible>: ...here.
1384
1385 2019-06-25  Tom Tromey  <tom@tromey.com>
1386
1387         * tui/tui-winsource.c
1388         (tui_source_window_base::do_scroll_horizontal): Remove direction
1389         parameter.
1390         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1391         direction parameter.
1392         * tui/tui-win.c (tui_win_info::forward_scroll)
1393         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1394         (tui_win_info::right_scroll): Update.
1395         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1396         direction parameter.
1397         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1398         direction parameter.
1399         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1400         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1401         Remove direction parameter.
1402         (struct tui_source_window_base, struct tui_source_window)
1403         (struct tui_disasm_window, struct tui_data_window)
1404         (struct tui_cmd_window): Update.
1405
1406 2019-06-25  Tom Tromey  <tom@tromey.com>
1407
1408         * tui/tui-winsource.h (tui_set_exec_info_content)
1409         (tui_show_exec_info_content, tui_erase_exec_info_content)
1410         (tui_clear_exec_info_content, tui_update_exec_info): Change
1411         argument to tui_source_window_base.
1412         * tui/tui-winsource.c (tui_set_exec_info_content)
1413         (tui_show_exec_info_content, tui_erase_exec_info_content)
1414         (tui_clear_exec_info_content, tui_update_exec_info): Change
1415         argument to tui_source_window_base.
1416
1417 2019-06-25  Tom Tromey  <tom@tromey.com>
1418
1419         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1420         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1421
1422 2019-06-25  Tom Tromey  <tom@tromey.com>
1423
1424         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1425         check.
1426
1427 2019-06-25  Tom Tromey  <tom@tromey.com>
1428
1429         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1430         type to void.
1431         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1432         type to void.
1433         * tui/tui-source.c (tui_set_source_content): Update.
1434         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1435
1436 2019-06-25  Tom Tromey  <tom@tromey.com>
1437
1438         * tui/tui-win.c (window_name_completer, tui_set_focus)
1439         (tui_all_windows_info): Use name method.
1440         * tui/tui-data.h (struct tui_gen_win_info)
1441         (struct tui_source_window, struct tui_disasm_window)
1442         (struct tui_data_window, struct tui_cmd_window) <name>: New
1443         method.
1444         (tui_win_name): Don't declare.
1445         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1446         (tui_win_name): Remove.
1447
1448 2019-06-25  Tom Tromey  <tom@tromey.com>
1449
1450         * tui/tui-winsource.h (tui_update_source_window)
1451         (tui_update_source_window_as_is): Change parameter type.
1452         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1453         to be a tui_source_window_base.
1454         (tui_update_source_window_as_is): Likewise.
1455         * tui/tui-win.c (make_visible_with_new_height): Update.
1456
1457 2019-06-25  Tom Tromey  <tom@tromey.com>
1458
1459         * tui/tui-winsource.c (tui_erase_source_content)
1460         (tui_show_source_content, tui_show_exec_info_content)
1461         (tui_erase_exec_info_content): Use refresh_window method.
1462         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1463         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1464         from tui_refresh_win.
1465         (tui_data_window::refresh_window): New method.
1466         (tui_win_info::refresh, tui_source_window_base::refresh)
1467         (tui_refresh_all): Use refresh_window method.
1468         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1469         method.
1470         * tui/tui-regs.c (tui_display_register): Call refresh_window
1471         method.
1472         * tui/tui-layout.c (show_source_disasm_command)
1473         (show_source_or_disasm_and_command): Call refresh_window method.
1474         * tui/tui-data.h (struct tui_gen_win_info)
1475         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1476         New method.
1477
1478 2019-06-25  Tom Tromey  <tom@tromey.com>
1479
1480         * tui/tui.c (tui_rl_other_window, tui_enable)
1481         (tui_is_window_visible, tui_get_command_dimension): Update.
1482         * tui/tui-winsource.c (tui_update_source_window_as_is)
1483         (tui_clear_source_content, tui_erase_source_content)
1484         (tui_show_source_line, tui_source_window_base::refill)
1485         (tui_source_window_base::do_scroll_horizontal)
1486         (tui_source_window_base::set_is_exec_point_at)
1487         (tui_update_breakpoint_info, tui_set_exec_info_content)
1488         (tui_alloc_source_buffer, tui_line_is_displayed)
1489         (tui_addr_is_displayed): Update.
1490         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1491         (tui_check_and_display_highlight_if_needed)
1492         (tui_win_info::make_visible, tui_win_info::refresh)
1493         (tui_refresh_all): Update.
1494         * tui/tui-windata.c (tui_first_data_item_displayed)
1495         (tui_delete_data_content_windows, tui_erase_data_content)
1496         (tui_display_all_data, tui_data_window::refresh_all)
1497         (tui_check_data_values): Update.
1498         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1499         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1500         (tui_win_info::backward_scroll, tui_refresh_all_win)
1501         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1502         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1503         (tui_source_window_base::set_new_height)
1504         (tui_data_window::set_new_height)
1505         (make_invisible_and_set_new_height)
1506         (make_visible_with_new_height, new_height_ok)
1507         (parse_scrolling_args): Update.
1508         * tui/tui-stack.c (tui_show_frame_info): Update.
1509         * tui/tui-source.c (tui_set_source_content)
1510         (tui_set_source_content_nil, tui_source_is_displayed)
1511         (tui_source_window::do_scroll_vertical): Update.
1512         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1513         (tui_display_registers_from, tui_display_reg_element_at_line)
1514         (tui_check_register_values, tui_reg_command): Update.
1515         * tui/tui-layout.c (tui_default_win_height)
1516         (show_source_disasm_command, show_data, init_and_make_win)
1517         (show_source_or_disasm_and_command): Update.
1518         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1519         (tui_redisplay_readline, tui_mld_flush)
1520         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1521         (tui_getc): Update.
1522         * tui/tui-disasm.c (tui_set_disassem_content)
1523         (tui_disasm_window::do_scroll_vertical): Update.
1524         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1525         Now virtual.
1526         (struct tui_win_info): Derive from tui_gen_win_info.
1527         <~tui_win_info>: Mark as override.
1528         <generic>: Remove member.
1529         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1530         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1531         (~tui_data_window, ~tui_win_info)
1532         (tui_free_all_source_wins_content): Update.
1533         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1534
1535 2019-06-25  Tom Tromey  <tom@tromey.com>
1536
1537         * tui/tui-layout.c (init_and_make_win): Use new.
1538         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1539         destructor, initializers.
1540         (tui_alloc_generic_win_info): Don't declare.
1541         * tui/tui-data.c (_locator): Add argument to constructor.
1542         (source_win, disasm_win): New globals.
1543         (exec_info): Remove.
1544         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1545         Update.
1546         (tui_alloc_generic_win_info): Remove.
1547         (init_content_element): Use new.
1548         (tui_win_info::tui_win_info): Update.
1549         (free_content_elements) <case DATA_WIN>: Use delete.
1550
1551 2019-06-25  Tom Tromey  <tom@tromey.com>
1552
1553         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1554         * tui/tui-windata.c (tui_first_data_item_displayed)
1555         (tui_delete_data_content_windows): Update.
1556         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1557         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1558         (tui_display_registers_from, tui_check_register_values): Update.
1559         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1560         pointer.
1561         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1562         window.
1563         (tui_free_data_content): Update.
1564         (free_content_elements) <case DATA_WIN>: Free the window.
1565
1566 2019-06-25  Tom Tromey  <tom@tromey.com>
1567
1568         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1569         Update.
1570         * tui/tui-layout.c (make_command_window)
1571         (show_source_disasm_command, show_data, init_and_make_win)
1572         (show_source_or_disasm_and_command): Update.
1573         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1574         method.
1575         <can_highight, is_highlighted>: Now bool.
1576         (tui_set_win_highlight): Don't declare.
1577         * tui/tui-data.c (tui_set_win_highlight): Remove.
1578
1579 2019-06-25  Tom Tromey  <tom@tromey.com>
1580
1581         * tui/tui-wingeneral.c (make_visible): Remove check of window
1582         type.
1583
1584 2019-06-25  Tom Tromey  <tom@tromey.com>
1585
1586         * tui/tui-win.c (tui_win_info::max_height)
1587         (tui_cmd_window::max_height): New methods.
1588         (new_height_ok): Call max_height.
1589         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1590         <max_height>: New method.
1591
1592 2019-06-25  Tom Tromey  <tom@tromey.com>
1593
1594         * tui/tui-win.c (tui_source_window_base::set_new_height)
1595         (tui_data_window::set_new_height): New methods.
1596         (make_invisible_and_set_new_height): Call set_new_height method.
1597         * tui/tui-data.h (struct tui_win_info)
1598         (struct tui_source_window_base, struct tui_data_window)
1599         <set_new_height>: New method.
1600
1601 2019-06-25  Tom Tromey  <tom@tromey.com>
1602
1603         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1604         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1605         tui_refresh_data_win.
1606         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1607         method.
1608         (tui_refresh_all_win): Call the refresh_all method.
1609         (tui_set_focus): Likewise.
1610         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1611         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1612         Likewise.
1613
1614 2019-06-25  Tom Tromey  <tom@tromey.com>
1615
1616         * tui/tui-winsource.h (tui_refill_source_window)
1617         (tui_set_is_exec_point_at): Don't declare.
1618         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1619         (tui_source_window_base::refill): Rename from
1620         tui_refill_source_window.
1621         (tui_source_window_base::do_scroll_horizontal): Update.
1622         (tui_source_window_base::set_is_exec_point_at): Rename from
1623         tui_set_is_exec_point_at.
1624         (tui_update_all_breakpoint_info): Update.
1625         * tui/tui-stack.c (tui_show_frame_info): Update.
1626         * tui/tui-layout.c (show_data): Add cast.
1627         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1628         * tui/tui-data.h (struct tui_source_window_base) <refill,
1629         set_is_exec_point_at>: New methods.
1630         (tui_source_windows, tui_add_to_source_windows): Update types.
1631         (tui_add_to_source_windows): Remove redundant declaration.
1632         * tui/tui-data.c (source_windows): Store tui_source_window_base.
1633         (tui_source_windows): Change return type.
1634         (tui_clear_source_windows_detail): Update.
1635         (tui_add_to_source_windows): Change type of parameter.
1636         (tui_free_all_source_wins_content): Update.
1637
1638 2019-06-25  Tom Tromey  <tom@tromey.com>
1639
1640         * tui/tui-wingeneral.c (tui_win_info::refresh)
1641         (tui_source_window_base::refresh): New methods.
1642         (tui_refresh_all): Call the refresh method.
1643         * tui/tui-data.h (struct tui_win_info)
1644         (struct tui_source_window_base) <refresh>: New method.
1645
1646 2019-06-25  Tom Tromey  <tom@tromey.com>
1647
1648         * tui/tui.h (tui_is_window_visible): Return bool.
1649         * tui/tui.c (tui_is_window_visible): Return bool.
1650         * tui/tui-wingeneral.c (tui_make_window, make_visible)
1651         (tui_make_visible, tui_make_invisible)
1652         (tui_win_info::make_visible)
1653         (tui_source_window_base::make_visible, make_all_visible)
1654         (tui_make_all_visible, tui_make_all_invisible): Update.
1655         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
1656         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
1657         bool.
1658         (struct tui_win_info, struct tui_source_window_base)
1659         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
1660         * tui/tui-data.c (tui_init_generic_part): Update.
1661
1662 2019-06-25  Tom Tromey  <tom@tromey.com>
1663
1664         * tui/tui-wingeneral.c (tui_win_info::make_visible)
1665         (tui_source_window_base::make_visible): New methods.
1666         (make_all_visible): Make method call.
1667         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
1668         (struct tui_source_window_base, struct tui_cmd_window): Override
1669         make_visible.
1670         (tui_win_is_source_type): Don't declare.
1671         * tui/tui-data.c (tui_win_is_source_type): Remove.
1672
1673 2019-06-25  Tom Tromey  <tom@tromey.com>
1674
1675         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
1676         NULL check.
1677
1678 2019-06-25  Tom Tromey  <tom@tromey.com>
1679
1680         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
1681         Inline constructor.  Add initializers for members.
1682         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
1683         constructors; now inline in class.
1684
1685 2019-06-25  Tom Tromey  <tom@tromey.com>
1686
1687         * tui/tui-regs.c (tui_show_registers): Update.
1688         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
1689         bool.
1690         * tui/tui-data.c (tui_data_window::clear_detail)
1691         (tui_data_window): Update.
1692
1693 2019-06-25  Tom Tromey  <tom@tromey.com>
1694
1695         * tui/tui-windata.c (tui_display_all_data)
1696         (tui_display_data_from_line, tui_display_data_from)
1697         (tui_check_data_values, tui_data_window::do_scroll_vertical):
1698         Update.
1699         * tui/tui-regs.c (tui_last_regs_line_no)
1700         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1701         (tui_show_registers, tui_show_register_group)
1702         (tui_display_registers_from, tui_display_reg_element_at_line)
1703         (tui_display_registers_from_line, tui_check_register_values)
1704         (tui_reg_next, tui_reg_prev): Update.
1705         * tui/tui-layout.c (tui_set_layout, show_data): Update.
1706         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
1707         tui_data_window.
1708         (struct tui_win_info) <detail>: Remove.  Add new fields from
1709         tui_data_info.
1710         (TUI_DATA_WIN): Add cast.
1711         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
1712         (~tui_data_window): Simplify.
1713
1714 2019-06-25  Tom Tromey  <tom@tromey.com>
1715
1716         * tui/tui-layout.c (show_source_disasm_command)
1717         (show_source_or_disasm_and_command): Update.
1718         * tui/tui-io.c (update_cmdwin_start_line)
1719         (tui_redisplay_readline): Update.
1720         * tui/tui-data.h (struct tui_command_info): Remove.
1721         (struct tui_win_info) <detail>: Remove command_info member.
1722         (struct tui_data_window) <start_line>: New member, from
1723         tui_command_info.
1724         (TUI_CMD_WIN): Add casts.
1725
1726 2019-06-25  Tom Tromey  <tom@tromey.com>
1727
1728         * tui/tui-winsource.c (tui_update_source_window)
1729         (tui_refill_source_window)
1730         (tui_source_window_base::do_scroll_horizontal)
1731         (tui_update_breakpoint_info, tui_set_exec_info_content)
1732         (tui_show_exec_info_content, tui_erase_exec_info_content)
1733         (tui_clear_exec_info_content): Update.
1734         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
1735         Update.
1736         * tui/tui-win.c (make_invisible_and_set_new_height)
1737         (make_visible_with_new_height): Update.
1738         * tui/tui-source.c (tui_set_source_content)
1739         (tui_show_symtab_source): Update.
1740         * tui/tui-layout.c (extract_display_start_addr)
1741         (show_source_disasm_command, show_data)
1742         (make_source_or_disasm_window)
1743         (show_source_or_disasm_and_command): Update.
1744         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
1745         (tui_disasm_window::do_scroll_vertical): Remove shadowing
1746         "gdbarch".
1747         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
1748         to tui_source_window_base.
1749         (struct tui_win_info) <detail>: Remove source_info member.
1750         (struct tui_source_window_base) <has_locator>: Inline.
1751         Move contents from tui_source_info; rename has_locator member to
1752         m_has_locator.
1753         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
1754         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
1755         header file.
1756         (tui_source_window_base::clear_detail, ~tui_source_window_base):
1757         Simplify.
1758         (tui_free_all_source_wins_content): Cast to
1759         tui_source_window_base.
1760
1761 2019-06-25  Tom Tromey  <tom@tromey.com>
1762
1763         * tui/tui-win.c (make_invisible_and_set_new_height)
1764         (make_visible_with_new_height): Call has_locator method.
1765         * tui/tui-layout.c (show_source_disasm_command, show_data)
1766         (show_source_or_disasm_and_command): Update for bool change.
1767         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
1768         (tui_win_info) <has_locator>: New method.
1769         (struct tui_source_window_base) <has_locator>: New method.
1770         (tui_win_has_locator): Don't declare.
1771         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
1772         from tui_win_has_locator.
1773         (tui_source_window_base): Use false, not FALSE.
1774
1775 2019-06-25  Tom Tromey  <tom@tromey.com>
1776
1777         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
1778         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
1779         clear_detail method directly.
1780         (tui_clear_win_detail): Remove.
1781
1782 2019-06-25  Tom Tromey  <tom@tromey.com>
1783
1784         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
1785         "this", not TUI_DISASM_WIN.
1786
1787 2019-06-25  Tom Tromey  <tom@tromey.com>
1788
1789         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
1790         declare.
1791         * tui/tui-winsource.c
1792         (tui_source_window_base::do_scroll_horizontal): Rename from
1793         tui_horizontal_source_scroll.
1794         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
1795         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
1796         from tui_vertical_data_scroll.
1797         * tui/tui-win.h (tui_scroll): Don't declare.
1798         * tui/tui-win.c (tui_win_info::forward_scroll)
1799         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1800         (tui_win_info::right_scroll): Rename and update.
1801         (tui_scroll_forward_command, tui_scroll_backward_command)
1802         (tui_scroll_left_command, tui_scroll_right_command): Update.
1803         (tui_scroll): Remove.
1804         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
1805         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
1806         from tui_vertical_source_scroll.
1807         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
1808         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
1809         from tui_vertical_disassem_scroll.
1810         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
1811         do_scroll_horizontal>: New methods.
1812         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
1813         Likewise.
1814         (struct tui_source_window_base): Add do_scroll_horizontal.
1815         (struct tui_source_window, struct tui_disasm_window): Add
1816         do_scroll_vertical.
1817         (struct tui_data_window, struct tui_cmd_window): Add
1818         do_scroll_horizontal and do_scroll_vertical.
1819         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
1820
1821 2019-06-25  Tom Tromey  <tom@tromey.com>
1822
1823         * tui/tui-data.h (struct tui_source_window_base): New struct.
1824         (struct tui_source_window): Derive from tui_source_window_base.
1825         (struct tui_disasm_window): New struct.
1826         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
1827         from tui_source_window::clear_detail.
1828         (tui_source_window_base): Rename from tui_source_window.
1829         (~tui_source_window_base): Rename from ~tui_source_window.
1830         (tui_alloc_win_info): Create a tui_disasm_window.
1831
1832 2019-06-25  Tom Tromey  <tom@tromey.com>
1833
1834         * tui/tui-data.h (struct tui_source_window)
1835         (struct tui_data_window): Declare destructors.
1836         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
1837         destructors.
1838         (tui_win_info): Simplify.
1839
1840 2019-06-25  Tom Tromey  <tom@tromey.com>
1841
1842         * tui/tui-winsource.c (tui_display_main)
1843         (tui_update_source_windows_with_addr)
1844         (tui_update_all_breakpoint_info): Update.
1845         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1846         (new_height_ok, parse_scrolling_args): Update.
1847         * tui/tui-stack.c (tui_show_frame_info): Update.
1848         * tui/tui-data.h (struct tui_list): Remove.
1849         (tui_source_windows): Return a reference to a std::vector.
1850         * tui/tui-data.c (source_windows): Now a std::vector.
1851         (tui_source_windows): Change return type.
1852         (tui_clear_source_windows): Rewrite.
1853         (tui_clear_source_windows_detail, tui_add_to_source_windows)
1854         (tui_free_all_source_wins_content): Rewrite.
1855
1856 2019-06-25  Tom Tromey  <tom@tromey.com>
1857
1858         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
1859         (struct tui_data_window, struct tui_cmd_window): Declare
1860         clear_detail method.
1861         * tui/tui-data.c (tui_source_window::clear_detail)
1862         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
1863         methods.
1864         (tui_clear_win_detail): Simplify.
1865
1866 2019-06-25  Tom Tromey  <tom@tromey.com>
1867
1868         * tui/tui-layout.c (make_source_window, make_disasm_window)
1869         (make_source_or_disasm_window): Remove win_info_ptr parameter.
1870         Return the new window.
1871         (show_source_disasm_command, show_data)
1872         (show_source_or_disasm_and_command): Update.
1873
1874 2019-06-25  Tom Tromey  <tom@tromey.com>
1875
1876         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
1877         parameter.  Return the new window.
1878         (show_source_disasm_command): Update and remove NULL check.
1879         (show_source_or_disasm_and_command): Update.
1880
1881 2019-06-25  Tom Tromey  <tom@tromey.com>
1882
1883         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
1884
1885 2019-06-25  Tom Tromey  <tom@tromey.com>
1886
1887         * tui/tui-data.h (struct tui_win_info): Make constructor
1888         protected.  Make destructor virtual.  Add initializers.
1889         (tui_source_window, tui_data_window, tui_cmd_window): New
1890         classes.
1891         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
1892         constructor.  Add "type" parameter.
1893         (tui_source_window, tui_data_window, tui_cmd_window): New
1894         constructors.
1895         (tui_alloc_win_info): Instantiate the appropriate subclass.
1896
1897 2019-06-25  Tom Tromey  <tom@tromey.com>
1898
1899         * tui/tui-win.c (tui_resize_all): Use delete.
1900         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
1901         destructor.
1902         (tui_free_window): Don't declare.
1903         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
1904         Update.
1905
1906 2019-06-25  Tom Tromey  <tom@tromey.com>
1907
1908         * tui/tui-data.h (struct tui_win_info): Add constructor.
1909         * tui/tui-data.c (tui_alloc_win_info): Use new.
1910         (tui_free_window): Use delete.
1911
1912 2019-06-22  Tom Tromey  <tom@tromey.com>
1913
1914         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
1915         declare.
1916         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
1917
1918 2019-06-22  Tom Tromey  <tom@tromey.com>
1919
1920         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
1921         declare.
1922         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
1923
1924 2019-06-22  Tom de Vries  <tdevries@suse.de>
1925
1926         * dwarf2read.c (create_addrmap_from_aranges)
1927         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
1928         instead of '%zu'.
1929
1930 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
1931
1932         * dwarf2read.h (dwarf2_section_info_def): Remove.
1933         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
1934         * dwarf2read.c (struct dwo_sections) <types>: Change type to
1935         std::vector<dwarf2_section_info>.
1936         (struct dwo_file) <~dwo_file>: Remove.
1937         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
1938         types field.
1939         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
1940         (dwarf2_read_debug_names): Likewise.
1941         (create_debug_types_hash_table): Change parameter type to
1942         array_view, adjust code accordingly.
1943         (dwarf2_locate_dwo_sections): Adjust to std::vector.
1944         (partial_die_info::fixup): Likewise.
1945         (determine_prefix): Likewise.
1946         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
1947
1948 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1949
1950         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
1951         gdb_bfd_ref_ptr.
1952         <~dwo_file>: Remove call to gdb_bfd_unref.
1953         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
1954         gdb_bfd_ref_ptr::get.
1955
1956 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1957
1958         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
1959         type to htab_up.
1960         * dwarf2read.c (struct dwo_file): Initialize fields.
1961         <~dwo_file>: New.
1962         (free_dwo_file): Remove, move content to ~dwo_file.
1963         (struct dwo_file_deleter): Remove.
1964         (dwo_file_up>: Remove custom deleter.
1965         (free_dwo_files): Remove.
1966         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
1967         dwo_files.
1968         (process_skeletonless_type_units): Call unique_ptr::get.
1969         (allocate_dwo_file_hash_table): Add deleter to created hash
1970         table.  Change return type to htab_up.
1971         (lookup_dwo_file_slot): Don't memset dwo_file, call
1972         unique_ptr::get.
1973         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
1974         (create_dwo_unit_in_dwp_v2): Likewise.
1975         (open_and_init_dwo_file): Likewise.
1976         (free_dwo_file_from_slot): Remove.
1977
1978 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1979
1980         * dwarf2read.h (struct dwarf2_section_info) <readin,
1981         is_virtual>: Change type to bool.
1982         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
1983         true instead of 1.
1984
1985 2019-06-19  Tom Tromey  <tom@tromey.com>
1986
1987         * tui/tui-data.h (tui_init_content_element): Don't declare.
1988
1989 2019-06-19  Tom Tromey  <tom@tromey.com>
1990
1991         * tui/tui-data.h (tui_init_win_info): Don't declare.
1992
1993 2019-06-19  Tom de Vries  <tdevries@suse.de>
1994
1995         * dwarf2read.h (abstract_to_concrete): Change type to
1996         std::unordered_map<sect_offset, std::vector<sect_offset>,
1997         gdb::hash_enum<sect_offset>>.
1998
1999 2019-06-19  Tom Tromey  <tromey@adacore.com>
2000
2001         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2002         EVAL_AVOID_SIDE_EFFECTS specially.
2003
2004 2019-06-19  Tom Tromey  <tromey@adacore.com>
2005
2006         * source-cache.c (highlighter): New global.
2007         (source_cache::get_source_lines): Create a highlighter on demand.
2008
2009 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2010
2011         * defs.h (deprecated_interactive_hook): Delete declaration.
2012         * interps.c (clear_interpreter_hooks): Remove use of
2013         deprecated_interactive_hook.
2014         * top.c (deprecated_interactive_hook): Delete definition.
2015         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2016
2017 2019-06-18  Tom de Vries  <tdevries@suse.de>
2018
2019         PR gdb/24515
2020         * dwarf2read.h (abstract_to_concrete): Change type from
2021         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2022         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2023         * dwarf2read.c (read_variable): Update.
2024         (dwarf2_fetch_die_loc_sect_off): Update.
2025
2026 2019-06-17  Tom de Vries  <tdevries@suse.de>
2027
2028         PR gdb/24617
2029         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2030         accessing parent[parent_len - 1].
2031
2032 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2033
2034         PR gdb/24364
2035         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2036         call dtrace_process_dof with NULL dof.
2037
2038 2019-06-16  Tom de Vries  <tdevries@suse.de>
2039
2040         PR gdb/24445
2041         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2042
2043 2019-06-16  Tom Tromey  <tom@tromey.com>
2044
2045         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2046         (make_all_visible): Use address of member.
2047
2048 2019-06-16  Tom Tromey  <tom@tromey.com>
2049
2050         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2051         (tui_free_window, free_content, free_content_elements): Remove
2052         unnecessary cast.
2053         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2054         cast.
2055         * tui/tui-regs.c (tui_show_register_group)
2056         (tui_display_registers_from, tui_display_reg_element_at_line):
2057         Remove unnecessary cast.
2058
2059 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2060
2061         * linux-nat.c (normal_mask): Delete.
2062         (_initialize_linux_nat): Don't initialise normal_mask.
2063
2064 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2065
2066         PR gdb/24445
2067         * dwarf-index-write.h (write_psymtabs_to_index): Add
2068         dwz_basename parameter.
2069         * dwarf-index-write.c (write_gdbindex): Move file writing to
2070         write_gdbindex_1.  Change return type void.
2071         (assert_file_size): Move up, remove filename parameter.
2072         (write_gdbindex_1): New function.
2073         (write_debug_names): Change return type to void, call
2074         assert_file_size.
2075         (struct index_wip_file): New struct.
2076         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2077         file logic to index_wip_file.  Write index for dwz file if
2078         needed.
2079         (save_gdb_index_command): Pass basename of dwz file, if present.
2080         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2081         build-id of dwz file, if present.
2082         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2083         (dwarf2_get_dwz_file): Likewise.
2084         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2085         (dwarf2_get_dwz_file): Likewise.
2086
2087 2019-06-16  Tom Tromey  <tom@tromey.com>
2088
2089         * coffread.c (process_coff_symbol): Use xstrdup.
2090         * value.c (create_internalvar): Use xstrdup.
2091
2092 2019-06-16  Tom Tromey  <tom@tromey.com>
2093
2094         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2095         * breakpoint.c (stopin_command, stopat_command)
2096         (until_break_command, decode_location_default): Remove unnecessary
2097         cast.
2098         * utils.c (subset_compare): Remove unnecessary cast.
2099         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2100         cast.
2101         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2102         cast.
2103         * infcmd.c (path_command): Remove unnecessary cast.
2104         * coffread.c (decode_type): Remove unnecessary cast.
2105         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2106         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2107         * tui/tui-stack.c (tui_show_locator_content)
2108         (tui_show_frame_info): Remove unnecessary cast.
2109         * tui/tui-win.c (tui_scroll_forward_command)
2110         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2111         (parse_scrolling_args): Remove unnecessary cast.
2112         * tui/tui-data.c (init_win_info, tui_del_window)
2113         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2114         (free_content_elements): Remove unnecessary cast.
2115         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2116         unnecessary cast.
2117         * tui/tui-source.c (tui_set_source_content)
2118         (tui_vertical_source_scroll): Remove unnecessary cast.
2119         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2120         cast.
2121         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2122         * tui/tui-regs.c (tui_display_registers_from)
2123         (tui_display_register): Remove unnecessary cast.
2124         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2125         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2126         (make_visible): Remove unnecessary cast.
2127         * tui/tui-winsource.c (tui_erase_source_content)
2128         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2129         unnecessary cast.
2130         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2131         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2132         * stabsread.c (read_type, read_array_type, read_range_type):
2133         Remove unnecessary cast.
2134         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2135         (parse_symbol, parse_type, upgrade_type, parse_external)
2136         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2137         unnecessary cast.
2138         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2139
2140 2019-06-16  Tom Tromey  <tom@tromey.com>
2141
2142         * tui/tui-data.c (tui_alloc_generic_win_info)
2143         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2144         checks.
2145
2146 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2147             Andrew Burgess  <andrew.burgess@embecosm.com>
2148
2149         * f-typeprint.c (f_print_type): Don't return early for not
2150         associated or not allocated types.
2151         (f_type_print_varspec_suffix): Add print_rank parameter and print
2152         ranks of array types in case they dangling.
2153         (f_type_print_base): Add print_rank parameter.
2154
2155 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2156
2157         * NEWS: Mention new MI commands.
2158         * break-catch-throw.c (enum exception_event_kind): Move to
2159         breakpoint.h.
2160         (print_mention_exception_catchpoint): Output text as a single
2161         message.
2162         (catch_exception_command_1): Rename to...
2163         (catch_exception_event): ...this, make non-static, update header
2164         command, and change some parameter types.
2165         (catch_catch_command): Update for changes to
2166         catch_exception_command_1.
2167         (catch_throw_command): Likewise.
2168         (catch_rethrow_command): Likewise.
2169         * breakpoint.c (enum exception_event_kind): Delete.
2170         * breakpoint.h (enum exception_event_kind): Moved here from
2171         break-catch-throw.c.
2172         (catch_exception_event): Declare.
2173         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2174         (mi_cmd_catch_throw): New function.
2175         (mi_cmd_catch_rethrow): New function.
2176         (mi_cmd_catch_catch): New function.
2177         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2178         'catch-catch' entries.
2179         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2180         (mi_cmd_catch_rethrow): Declare.
2181         (mi_cmd_catch_catch): Declare.
2182
2183 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2184
2185         * annotate.c (annotate_source_line): Change return type to void,
2186         update implementation to match.
2187         * annotate.h (annotate_source_line): Change return type to void,
2188         update header comment.
2189         * stack.c (print_frame_info): Don't change what frame information
2190         is printed based on whether annotations are on or not.
2191
2192 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2193
2194         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2195         (annotate_source): Make static.
2196         (annotate_source_line): Moved from source.c and renamed from
2197         identify_source_line.  Update the return type.
2198         * annotate.h (annotate_source): Delete declaration.
2199         (annotate_source_line): Declaration moved from source.h, and
2200         renamed from identify_source_line.  Return type updated.
2201         * source.c (identify_source_line): Moved to annotate.c and renamed
2202         to annotate_source_line.
2203         (info_line_command): Remove check of annotation_level.
2204         * source.h (identify_source_line): Move declaration to annotate.h
2205         and rename to annotate_source_line.
2206         * stack.c: Add 'annotate.h' include.
2207         (print_frame_info): Remove check of annotation_level before
2208         calling annotate_source_line.
2209
2210 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2211
2212         * source-cache.c (source_cache::get_plain_source_lines): Use
2213         open_source_file_with_line_charpos instead of just
2214         open_source_file, remove call to find_source_lines.
2215         (source_cache::get_source_lines): Likewise.
2216         * source.c (find_source_lines): Make static.
2217         (get_filename_and_charpos): Renamed into...
2218         (open_source_file_with_line_charpos): ..this along with changes to
2219         return a scoped_fd, and some other minor clean ups.
2220         (identify_source_line): Use open_source_file_with_line_charpos.
2221         (search_command_helper): Use open_source_file_with_line_charpos
2222         instead of just open_source_file, remove call to
2223         find_source_lines.
2224         * source.h (open_source_file_with_line_charpos): Declare new
2225         function.
2226         (find_source_lines): Delete declaration.
2227
2228 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2229
2230         * source.c (get_filename_and_charpos): Remove fullname
2231         parameter.
2232         (identify_source_line): Update call to get_filename_and_charpos.
2233
2234 2019-06-14  Tom Tromey  <tromey@adacore.com>
2235
2236         PR gdb/24502:
2237         * ui-style.h (skip_ansi_escape): Update comment.
2238         * ui-file.h (class no_terminal_escape_file): New class.
2239         * ui-file.c (no_terminal_escape_file::write)
2240         (no_terminal_escape_file::puts): New methods.
2241         * cli/cli-logging.c (handle_redirections): Use
2242         no_terminal_escape_file.
2243
2244 2019-06-14  Tom Tromey  <tromey@adacore.com>
2245
2246         * NEWS: Move convenience variable news above Python news.
2247
2248 2019-06-14  Tom Tromey  <tom@tromey.com>
2249
2250         * gnulib: Move directory to top-level.
2251         * configure.ac: Don't configure gnulib.
2252         * configure: Rebuild.
2253         * common/common-defs.h: Use new path to gnulib.
2254         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2255         (GNULIB_H): Remove.
2256         (INCGNU): Look in new gnulib location.
2257         (HFILES_NO_SRCDIR): Remove gnulib files.
2258         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2259         (generated_files): Remove GNULIB_H.
2260         ($(LIBGNU), all-lib): Remove targets.
2261         (distclean): Don't mention GNULIB_BUILDDIR.
2262         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2263
2264 2019-06-14  Tom Tromey  <tromey@adacore.com>
2265
2266         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2267         Warn if symbol file does not provide any symbols.
2268
2269 2019-06-14  Tom Tromey  <tromey@adacore.com>
2270
2271         * source.c (find_and_open_source): Respect basenames_may_differ.
2272
2273 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2274
2275         * annotate.c (annotate_breakpoints_invalid): Make use of
2276         scoped_restore_terminal_state.
2277         (annotate_frames_invalid): Likewise.
2278
2279 2019-06-14  Tom Tromey  <tromey@adacore.com>
2280
2281         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2282         allow assignment to an internalvar.
2283
2284 2019-06-14  Tom Tromey  <tromey@adacore.com>
2285
2286         * ada-lex.l: Allow "_" in attribute names.
2287
2288 2019-06-14  Tom Tromey  <tromey@adacore.com>
2289
2290         PR gdb/24653:
2291         * regcache.c (registers_changed): Don't call alloca.
2292         * top.c (execute_command): Don't call alloca.
2293
2294 2019-06-13  Pedro Alves  <palves@redhat.com>
2295
2296         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2297         'expression'.  When parsing an expression, error out if there's
2298         junk after "unlimited".
2299         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2300         (do_set_command): Adjust calls to is_unlimited_literal.
2301
2302 2019-06-13  Pedro Alves  <palves@redhat.com>
2303
2304         * compile/compile.c (make_compile_options_def_group): Add braces
2305         around array_view initializer.
2306         * thread.c (make_thread_apply_all_options_def_group)
2307         (make_thread_apply_all_options_def_group): Likewise.
2308
2309 2019-06-13  Pedro Alves  <palves@redhat.com>
2310
2311         * NEWS (New commands): Mention "maint test-options
2312         require-delimiter", "maint test-options unknown-is-error", "maint
2313         test-options unknown-is-operand" and "maint show
2314         test-options-completion-result".
2315         (New command options, command completion): New section.
2316         (Completion improvements): New section.
2317         Mention that you can abbreviate "unlimited".
2318
2319 2019-06-13  Pedro Alves  <palves@redhat.com>
2320
2321         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2322         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2323         * unittests/cli-utils-selftests.c (test_parse_flags)
2324         (test_parse_flags_qcs): Delete.
2325         (test_cli_utils): Don't call deleted functions.
2326
2327 2019-06-13  Pedro Alves  <palves@redhat.com>
2328
2329         * thread.c: Include "cli/cli-option.h".
2330         (tp_array_compar_ascending): Global.
2331         (tp_array_compar): Delete function.
2332         (tp_array_compar_ascending, tp_array_compar_descending): New
2333         functions.
2334         (ascending_option_def, qcs_flag_option_def)
2335         (thr_qcs_flags_option_defs)
2336         (make_thread_apply_all_options_def_group)
2337         (make_thread_apply_options_def_group): New.
2338         (thread_apply_all_command): Use gdb::option::process_options.
2339         (thread_apply_command_completer)
2340         (thread_apply_all_command_completer): New.
2341         (thread_apply_command): Use gdb::option::process_options.
2342         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2343         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2344         to generate help text of "thread apply".  Adjust "taas"'s help.
2345         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2346         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2347
2348 2019-06-13  Pedro Alves  <palves@redhat.com>
2349
2350         * thread.c (thread_apply_command): Check for invalid TID with
2351         isdigit instead of !isalpha.
2352
2353 2019-06-13  Pedro Alves  <palves@redhat.com>
2354
2355         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2356         (validate_flags_qcs): New.
2357         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2358         (validate_flags_qcs): Declare.
2359         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2360         (make_frame_apply_options_def_group): New.
2361         (frame_apply_command_count): Process options with
2362         gdb::option::process_options.
2363         (frame_apply_completer): New.
2364         (frame_apply_level_completer, frame_apply_all_completer)
2365         (frame_apply_completer): New.
2366         (_initialize_stack): Update help of "frame apply", "frame apply
2367         level", "frame apply all" and "faas" to mention supported options
2368         and install command completers.
2369         * stack.h (frame_apply_all_completer): Declare.
2370         * thread.c: Include "stack.h".
2371         (tfaas_command): Add "--".
2372         (_initialize_thread): Update help "tfaas" to mention supported
2373         options and install command completer.
2374
2375 2019-06-13  Pedro Alves  <palves@redhat.com>
2376
2377         * completer.c (complete_nested_command_line): New.
2378         (gdb_completion_word_break_characters_throw): Add assertion.
2379         * completer.h (complete_nested_command_line): Declare.
2380
2381 2019-06-13  Pedro Alves  <palves@redhat.com>
2382
2383         * stack.c (parse_backtrace_qualifiers): New.
2384         (backtrace_command): Use it.
2385         (backtrace_command_completer): Complete on qualifiers.
2386
2387 2019-06-13  Pedro Alves  <palves@redhat.com>
2388
2389         * frame.c: Include "cli/cli-option.h.
2390         (user_set_backtrace_options): New.
2391         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2392         Delete.
2393         (get_prev_frame): Adjust.
2394         (boolean_option_def, uinteger_option_def)
2395         (set_backtrace_option_defs): New.
2396         (_initialize_frame): Adjust and use
2397         gdb::option::add_setshow_cmds_for_options to install "set
2398         backtrace past-main" and "set backtrace past-entry".
2399         * frame.h: Include "cli/cli-option.h".
2400         (struct frame_print_options): Forward declare.
2401         (print_frame_arguments_all, print_frame_arguments_scalars)
2402         (print_frame_arguments_none): Declare.
2403         (print_entry_values): Delete declaration.
2404         (struct frame_print_options, user_frame_print_options): New.
2405         (struct set_backtrace_options): New.
2406         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2407         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2408         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2409         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2410         (list_args_or_locals): Add frame_print_options parameter.
2411         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2412         * python/py-framefilter.c (enumerate_args): Pass down
2413         USER_FRAME_PRINT_OPTIONS.
2414         * stack.c: Include "cli/cli-option.h".
2415         (print_frame_arguments_all, print_frame_arguments_scalars)
2416         (print_frame_arguments_none): Declare.
2417         (print_raw_frame_arguments, print_entry_values): Delete.
2418         (user_frame_print_options): New.
2419         (boolean_option_def, enum_option_def, frame_print_option_defs):
2420         New.
2421         (struct backtrace_cmd_options): New.
2422         (bt_flag_option_def): New.
2423         (backtrace_command_option_defs): New.
2424         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2425         (print_frame_arg, read_frame_arg, print_frame_args)
2426         (print_frame_info, print_frame): Add frame_print_options parameter
2427         and use it.
2428         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2429         (backtrace_command_1): Add frame_print_options and
2430         backtrace_cmd_options parameters and use them.
2431         (make_backtrace_options_def_group): New.
2432         (backtrace_command): Process command options with
2433         gdb::option::process_options.
2434         (backtrace_command_completer): New.
2435         (_initialize_stack): Extend "backtrace"'s help to mention
2436         supported options.  Install completer for "backtrace".
2437         Install some settings commands with add_setshow_cmds_for_options.
2438
2439 2019-06-13  Pedro Alves  <palves@redhat.com>
2440
2441         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2442         and that "set/show print raw frame-arguments" are now deprecated.
2443
2444         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2445         command.
2446         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2447         * stack.c (_initialize_stack): Install "set/show print
2448         raw-frame-arguments", and deprecate "set/show print raw
2449         frame-arguments".
2450         * valprint.c (_initialize_valprint): Deprecate "set/show print
2451         raw".
2452
2453 2019-06-13  Pedro Alves  <palves@redhat.com>
2454
2455         * compile/compile.c (struct compile_options): New.
2456         (compile_flag_option_def, compile_command_option_defs)
2457         (make_compile_options_def_group): New.
2458         (compile_file_command): Handle options with
2459         gdb::option::process_options.
2460         (compile_file_command_completer): New function.
2461         (compile_code_command): Handle options with
2462         gdb::option::process_options.
2463         (compile_code_command_completer): New function.
2464         (_initialize_compiler): Install completers for "compile code" and
2465         "compile file".  Mention available options in "compile code" and
2466         "compile code"'s help.
2467         * completer.c (advance_to_completion_word): New, factored out from
2468         ...
2469         (advance_to_expression_complete_word_point): ... this.
2470         (advance_to_filename_complete_word_point): New.
2471         * completer.h (advance_to_filename_complete_word_point): New
2472         declaration.
2473
2474 2019-06-13  Pedro Alves  <palves@redhat.com>
2475
2476         * compile/compile.c: Include "cli/cli-option.h".
2477         (compile_print_value): Scope data pointer is now a
2478         value_print_options pointer; adjust.
2479         (compile_print_command): Process options.  Scope data pointer is
2480         now a value_print_options pointer; adjust.
2481         (_initialize_compile): Update "compile print"'s help to include
2482         supported options.  Install a completer for "compile print".
2483         * cp-valprint.c (show_vtblprint, show_objectprint)
2484         (show_static_field_print): Delete.
2485         (_initialize_cp_valprint): Don't install "set print
2486         static-members", "set print vtbl", "set print object" here.
2487         * printcmd.c: Include "cli/cli-option.h" and
2488         "common/gdb_optional.h".
2489         (print_command_parse_format): Rework to fill in a
2490         value_print_options instead of a format_data.
2491         (print_value): Change parameter type from format_data pointer to
2492         value_print_options reference.  Adjust.
2493         (print_command_1): Process options.  Adjust to pass down a
2494         value_print_options.
2495         (print_command_completer): New.
2496         (_initialize_printcmd): Install print_command_completer as
2497         handle_brkchars completer for the "print" command.  Update
2498         "print"'s help to include supported options.
2499         * valprint.c: Include "cli/cli-option.h".
2500         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2501         here from cp-valprint.c.
2502         (boolean_option_def, uinteger_option_def)
2503         (value_print_option_defs, make_value_print_options_def_group):
2504         New.  Use gdb::option::add_setshow_cmds_for_options to install
2505         "set print elements", "set print null-stop", "set print repeats",
2506         "set print pretty", "set print union", "set print array", "set
2507         print address", "set print symbol", "set print array-indexes".
2508         * valprint.h: Include <string> and "cli/cli-option.h".
2509         (make_value_print_options_def_group): Declare.
2510         (print_value): Change parameter type from format_data pointer to
2511         value_print_options reference.
2512         (print_command_completer): Declare.
2513
2514 2019-06-13  Pedro Alves  <palves@redhat.com>
2515
2516         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2517         (COMMON_SFILES): Add maint-test-settings.c.
2518         * cli/cli-decode.c (boolean_enums): New global, factored out from
2519         ...
2520         (add_setshow_boolean_cmd): ... here.
2521         * cli/cli-decode.h (boolean_enums): Declare.
2522         * cli/cli-option.c: New file.
2523         * cli/cli-option.h: New file.
2524         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2525         factored out from ...
2526         (parse_cli_boolean_value(const char *)): ... this.
2527         (is_unlimited_literal): Change parameter type to pointer to
2528         pointer.  Adjust and advance ARG pointer.
2529         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2530         (parse_cli_var_enum): New, factored out from ...
2531         (do_set_command): ... this.  Adjust.
2532         * cli/cli-setshow.h (parse_cli_boolean_value)
2533         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2534         (parse_cli_var_enum): Declare.
2535         * cli/cli-utils.c: Include "cli/cli-option.h".
2536         (get_ulongest): New.
2537         * cli/cli-utils.h (get_ulongest): Declare.
2538         (check_for_argument): New overloads.
2539         * maint-test-options.c: New file.
2540
2541 2019-06-13  Pedro Alves  <palves@redhat.com>
2542
2543         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2544         parse a range if "-" is at the end of the string.
2545
2546 2019-06-13  Pedro Alves  <palves@redhat.com>
2547
2548         * cli/cli-setshow.c (parse_auto_binary_operation)
2549         (parse_cli_boolean_value): Don't allow "o".
2550
2551 2019-06-13  Pedro Alves  <palves@redhat.com>
2552
2553         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2554         * NEWS: Mention maint test-settings KIND.
2555         * maint-test-settings.c: New file.
2556
2557 2019-06-13  Pedro Alves  <palves@redhat.com>
2558
2559         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2560         completer.
2561         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2562         "set" completers.
2563
2564 2019-06-13  Pedro Alves  <palves@redhat.com>
2565
2566         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2567         after item.
2568
2569 2019-06-13  Pedro Alves  <palves@redhat.com>
2570
2571         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2572
2573 2019-06-13  Pedro Alves <palves@redhat.com>
2574
2575         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2576         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2577         call.
2578         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2579         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2580         calls.
2581         (check_for_argument): Skip spaces after argument.
2582
2583 2019-06-13  Pedro Alves  <palves@redhat.com>
2584
2585         * thread.c (thread_apply_command): Adjust TID parsing.
2586         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2587         detected before end of string.
2588         (tid_is_in_list): Error out if LIST is invalid.
2589
2590 2019-06-13  Pedro Alves  <palves@redhat.com>
2591
2592         * completer.c (complete_line_internal_1): Rewind completion word
2593         point.
2594         (completion_tracker::advance_custom_word_point_by): Change
2595         parameter type to int.
2596         * completer.h (completion_tracker::advance_custom_word_point_by):
2597         Likewise.
2598
2599 2019-06-13  Pedro Alves  <palves@redhat.com>
2600
2601         * completer.c (advance_to_completion_word): Handle delimiters.
2602
2603 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2604
2605         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2606
2607 2019-06-11  Tom Tromey  <tom@tromey.com>
2608
2609         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2610         (xmalloc_failed): Move to alloc.c.
2611         * alloc.c: New file.
2612         * Makefile.in (COMMON_SFILES): Add alloc.c.
2613
2614 2019-06-11  Tom Tromey  <tom@tromey.com>
2615
2616         * nat/linux-waitpid.c: Don't include server.h.
2617         (linux_debug): Remove.
2618         (my_waitpid): Update.
2619
2620 2019-06-11  Tom Tromey  <tromey@adacore.com>
2621
2622         * infcall.c (_initialize_infcall): Remove trailing newline from
2623         help.
2624         * user-regs.c (_initialize_user_regs): Remove trailing newline
2625         from help.
2626         * typeprint.c (_initialize_typeprint): Remove trailing newline
2627         from help.
2628         * reverse.c (_initialize_reverse): Remove trailing newlines from
2629         help.
2630         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2631         from help.
2632         * language.c (add_set_language_command): Remove trailing newline
2633         from help.
2634         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2635         help.
2636         * disasm.c (_initialize_disasm): Remove trailing newline from
2637         help.
2638         * top.c (init_main): Remove trailing newline from help.
2639         * interps.c (_initialize_interpreter): Remove trailing newline
2640         from help.
2641         * btrace.c (_initialize_btrace): Remove trailing newlines from
2642         help.
2643         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
2644         from help.
2645         * python/python.c (_initialize_python): Remove trailing newline
2646         from help.
2647         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
2648         help.
2649         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
2650         from help.  Reformat some text.
2651         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
2652         from help.
2653         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
2654         newline from help.
2655
2656 2019-06-11  Tom Tromey  <tromey@adacore.com>
2657
2658         * darwin-nat.c (darwin_decode_exception_message)
2659         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
2660
2661 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2662
2663         * valops.c (value_slice): Check for not allocated or not
2664         associated values.
2665
2666 2019-06-10  Tom de Vries  <tdevries@suse.de>
2667
2668         PR gdb/24618
2669         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
2670         sure an empty slot (defined by a 32-bit zero pair) is recognized as
2671         invalid.
2672
2673 2019-06-10  Tom de Vries  <tdevries@suse.de>
2674
2675         PR gdb/24611
2676         * linespec.c (linespec_lexer_lex_string): Remove incorrect
2677         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
2678
2679 2019-06-10  Tom de Vries  <tdevries@suse.de>
2680
2681         PR symtab/24545
2682         * symtab.c (struct demangled_name_entry): Add language field.
2683         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
2684         static minimal symbol".  Set and use language field.
2685
2686 2019-06-10  Tom Tromey  <tromey@adacore.com>
2687
2688         * ada-lang.c (_initialize_ada_language): Update help text.
2689
2690 2019-06-10  Tom Tromey  <tromey@adacore.com>
2691
2692         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
2693         with a newline.
2694         * guile/guile.c (handle_boot_error): Don't end warning with a
2695         newline.
2696         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
2697         warning with a newline.
2698         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
2699         newline.
2700         (s12z_frame_cache): Likewise.
2701         * dwarf-index-cache.c (index_cache::store): Don't end warning with
2702         a newline.
2703         * solib-svr4.c (disable_probes_interface): Don't end warning with
2704         a newline.
2705         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2706         newline.
2707         * python/python.c (do_finish_initialization): Don't end warning
2708         with a newline.
2709
2710 2019-06-10  Tom Tromey  <tom@tromey.com>
2711
2712         * python/py-breakpoint.c (gdbpy_breakpoint_created)
2713         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
2714         gdbpy_enter.
2715
2716 2019-06-10  Tom Tromey  <tromey@adacore.com>
2717
2718         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
2719         data.
2720         (elf_new_init): Don't call stabsread_new_init.
2721         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
2722         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
2723         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
2724
2725 2019-06-10  Tom de Vries  <tdevries@suse.de>
2726
2727         PR symtab/16264
2728         PR symtab/24517
2729         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
2730
2731 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
2732
2733         * source.c (find_and_open_source): Also rewrite relative file
2734         names.
2735
2736 2019-04-26  Amos Bird  <amosbird@gmail.com>
2737
2738         * annotate.c (annotate_thread_exited): Add "thread-exited"
2739         annotation.
2740
2741 2019-06-06  Tom Tromey  <tromey@adacore.com>
2742
2743         * maint.h (class scoped_command_stats): Use
2744         DISABLE_COPY_AND_ASSIGN.
2745         <print_time>: New method.
2746         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
2747         print_time.
2748         (scoped_command_stats::print_time): New method.
2749
2750 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2751
2752         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
2753         instructions of lengths 6 or 8 bytes.
2754
2755 2019-06-04  Pedro Alves  <palves@redhat.com>
2756
2757         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
2758
2759         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
2760         * breakpoint.c (condition_completer): Likewise.
2761         * cli/cli-dump.c (scan_expression): Likewise.
2762         * common/filestuff.c (mkdir_recursive): Likewise.
2763         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
2764         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
2765         (gdb_abspath): Likewise.
2766         * compile/compile-cplus-types.c
2767         (compile_cplus_instance::decl_name): Likewise.
2768         * completer.c (complete_explicit_location):
2769         (signal_completer, reg_or_group_completer_1): Likewise.
2770         * cp-support.c (cp_remove_params_if_any): Likewise.
2771         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
2772         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
2773         * infcmd.c (strip_bg_char): Likewise.
2774         * linespec.c (copy_token_string): Likewise.
2775         * mi/mi-main.c (output_cores): Likewise.
2776         * psymtab.c (psymtab_search_name):
2777         * symfile.c (test_set_ext_lang_command): Likewise.
2778         * target.c (target_fileio_read_stralloc): Likewise.
2779         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
2780         * value.c (complete_internalvar): Likewise.
2781
2782 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
2783
2784         Add objfile property to gdb.Type.
2785         * NEWS: Mention Python API addition.
2786         * python/py-type.c (typy_get_objfile): New method.
2787
2788 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2789
2790         * NEWS: Mention the new set|show style [title|highlight].
2791         Mention changes to "show style", "help" and "apropos".
2792
2793 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2794
2795         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
2796         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
2797         instead of print_help_for_command.
2798         (print_doc_of_command): New function.
2799         (help_list): Add 'apropos -v word' suggestion.
2800         (print_help_for_command): Style the command name using title style.
2801         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
2802         (_initialize_cli_cmds): Describe -v in apropos_command help.
2803
2804 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2805
2806         * cli/cli-style.h (cli_style_option): Add name in constructor,
2807         add m_name class member, add constructor with intensity,
2808         add name class function.
2809         (cli_style_option::add_setshow_commands): Remove name argument.
2810         (highlight_style, title_style): New styles.
2811         * cli/cli-style.c (do_show): New function that shows a style
2812         characteristic styling the style name with itself.
2813         (set_style_name): New function.
2814         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
2815         Update all callers according to the changes in cli/cli-style.h.
2816         * utils.h (fputs_highlighted): New function.
2817         * utils.c (fputs_highlighted): Likewise.
2818
2819 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2820
2821         * NEWS: Mention new pipe command and new convenience variables.
2822
2823 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2824
2825         * cli/cli-cmds.c (pipe_command): New function.
2826         (_initialize_cli_cmds): Call add_com for pipe_command.
2827         Define | as an alias for pipe.
2828         (exit_status_set_internal_vars): New function.
2829         (shell_escape): Call exit_status_set_internal_vars.
2830         cli/cli-decode.c (find_command_name_length): Recognize | as
2831         a single character command.
2832
2833 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2834
2835         * gdbcmd.h (execute_command_to_ui_file): New declaration.
2836         top.c (execute_command_to_ui_file): New function, mostly a copy
2837         of execute_command_to_string.
2838         (execute_command_to_string): Implement by calling
2839         execute_command_to_ui_file.
2840
2841 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2842
2843         * top.h (saved_command_line): Remove declaration.
2844         * top.c (previous_saved_command_line, previous_repeat_arguments):
2845         New variables.
2846         (saved_command_line): Make static, define together with other
2847         'repeat variables'.
2848         (dont_repeat): Clear repeat_arguments.
2849         (repeat_previous, get_saved_command_line, save_command_line):
2850         New functions.
2851         (gdb_init): Initialize saved_command_line
2852         and previous_saved_command_line.
2853         * main.c (captured_main_1): Remove saved_command_line initialization.
2854         * event-top.c (handle_line_of_input): Update to use
2855         the new 'repeat' related functions instead of direct access to
2856         saved_command_line.
2857         * command.h (repeat_previous, get_saved_command_line,
2858         save_command_line): New declarations.
2859         (dont_repeat): Add comment.
2860
2861 2019-05-30  Tom Tromey  <tromey@adacore.com>
2862
2863         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
2864         Fix comment.
2865         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
2866
2867 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
2868
2869         PR cli/24587
2870         * completer.c (complete): Initialize variable word.
2871
2872 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
2873
2874         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2875         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
2876         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
2877         'body' is NULL to the outter 'if', protecting the '!is_define'
2878         situation as well.
2879
2880 2019-05-29  Tom Tromey  <tromey@adacore.com>
2881
2882         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
2883         (dwarf_unknown): New function.
2884         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
2885         (dwarf_type_encoding_name): Use dwarf_unknown.
2886
2887 2019-05-29  Tom Tromey  <tromey@adacore.com>
2888
2889         PR c++/20020:
2890         * cp-valprint.c (cp_print_value_fields): Call
2891         cp_print_static_field inside "try".
2892
2893 2019-05-29  Tom Tromey  <tromey@adacore.com>
2894
2895         * inflow.c (struct terminal_info): Add default operator=.
2896         * configure: Rebuild.
2897         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
2898         -Wdeprecated-copy-dtor, -Wredundant-move.
2899
2900 2019-05-29  Tom Tromey  <tromey@adacore.com>
2901
2902         * NEWS: Add entry.
2903         * infcmd.c (print_return_value_1): Handle finish_print
2904         option.
2905         (show_print_finish): New function.
2906         (_initialize_infcmd): Add "set/show print finish" commands.
2907         * valprint.c (user_print_options): Initialize new member.
2908         * valprint.h (struct value_print_options) <finish_print>: New
2909         member.
2910
2911 2019-05-28  Tom Tromey  <tromey@adacore.com>
2912
2913         * ada-lang.c (ada_remove_Xbn_suffix)
2914         (find_old_style_renaming_symbol)
2915         (parse_old_style_renaming): Remove.
2916         (ada_find_renaming_symbol): Don't call
2917         find_old_style_renaming_symbol.
2918         (ada_is_renaming_symbol): Rename from
2919         ada_find_renaming_symbol.  Remove "block" parameter.  Return
2920         bool.  Now static.
2921         (ada_read_var_value): Update and simplify.
2922         * ada-exp.y (write_var_or_type): Remove old code.
2923
2924 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
2925
2926         * event-top.c: Remove include comment.
2927         * inflow.c (class scoped_ignore_sigttou): Move from here...
2928         * inflow.h (class scoped_ignore_sigttou): ...to here.
2929         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
2930         * top.c:  Remove include comment.
2931
2932 2019-05-27  Tom Tromey  <tom@tromey.com>
2933
2934         * NEWS: Fix typo.
2935
2936 2019-05-22  Tom Tromey  <tromey@adacore.com>
2937
2938         * target.c (target_follow_exec): Constify parameter.
2939         * target-delegates.c: Rebuild.
2940         * remote.c (remote_target::follow_exec): Constify parameter.
2941         * infrun.c (follow_exec): Constify parameter.
2942         * target.h (struct target_ops) <follow_exec>: Constify parameter.
2943         (target_follow_exec): Likewise.
2944
2945 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2946
2947         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
2948         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
2949
2950 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2951
2952         * NEWS: Add debugredirect and testsuite sections.
2953
2954 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
2955
2956         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
2957         target descriptions using exclusively floating point register name
2958         aliases.
2959
2960 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2961
2962         PR gdb/18644:
2963         * f-lang.c (build_fortran_types): Handle the case where
2964         gdbarch_floatformat_for_type returns a nullptr.
2965
2966 2019-05-21  Tom de Vries  <tdevries@suse.de>
2967
2968         PR cli/24587
2969         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
2970
2971 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2972
2973         PR gdb/18644:
2974         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
2975         16-byte floats.
2976         * i386-tdep.c (i386_floatformat_for_type): Use
2977         floatformats_ia64_quad for the 16-byte floating point component
2978         within a fortran 32-byte complex number.
2979
2980 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2981
2982         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
2983         delete default constructor.
2984         (find_partial_die): Update to return const struct.
2985         (partial_die_parent_scope): Move variable declaration into scope
2986         of its use and change its type to auto.
2987         (guess_partial_die_structure_name): Likewise.
2988         (partial_die_info::fixup): Likewise.
2989
2990 2019-05-17  Tom Tromey  <tromey@adacore.com>
2991
2992         * source.c (find_and_open_source): Remove cast.
2993
2994 2019-05-17  Tom Tromey  <tromey@adacore.com>
2995
2996         * annotate.c (annotate_source): Make "filename" const.
2997         * annotate.h (annotate_source): Use const.
2998
2999 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3000
3001         * disasm.c (set_disassembler_options): Send errors to stderr.
3002
3003 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3004
3005         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3006         (cli_interp_base::set_logging): Check debug_redirect.
3007         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3008         * cli/cli-logging.c (debug_redirect): Add static variable.
3009         (pop_output_files): Add default param.
3010         (handle_redirections): Print debug setting.
3011         (show_logging_command): Likewise.
3012         (_initialize_cli_logging): Add debugredirect command.
3013         * interps.c (current_interp_set_logging): Add debug_redirect
3014         parameter.
3015         * interps.h (set_logging): Add debug_redirect parameter.
3016         (current_interp_set_logging): Likewise.
3017         * mi/mi-common.h: Likewise.
3018         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3019
3020 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3021             Tom Tromey  <tromey@adacore.com>
3022
3023         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3024         directly.
3025         * cli/cli-interp.h (make_logging_output): Remove declaration.
3026         * cli/cli-logging.c (make_logging_output): Remove function.
3027         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3028         directly.
3029         * ui-file.c (tee_file::tee_file): Remove bools.
3030         (tee_file::~tee_file): Remove deletes.
3031         * ui-file.h (tee_file): Remove bools.
3032
3033 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3034
3035         * mi/mi-cmds.h (mi_cmd_complete): New function.
3036         * mi/mi-main.c (mi_cmd_complete): Likewise.
3037         * mi/mi-cmds.c: Define new MI command -complete.
3038         * NEWS: Mention new -complete command.
3039
3040 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3041
3042         * completer.h (complete): New function.
3043         * completer.c (complete): Likewise.
3044         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3045         function defined in completer.h.
3046
3047 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3048
3049         * MAINTAINERS (Write After Approval): Add myself.
3050
3051 2019-05-17  Tom de Vries  <tdevries@suse.de>
3052
3053         PR gdb/24094
3054         * dwarf2read.c (struct cu_partial_die_info): New struct.
3055         (find_partial_die): Return cu_partial_die_info.
3056         (partial_die_parent_scope, guess_partial_die_structure_name)
3057         (partial_die_info::fixup): Handle new return type of find_partial_die.
3058
3059 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3060
3061         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3062         "std::string", simplifying the algorithm.
3063
3064 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3065
3066         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3067         (stap_static_probe_ops::get_probes): Likewise.
3068
3069 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3070
3071         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3072         '-')" and "else if".
3073         (stap_parse_single_operand): Join checks for
3074         "gdbarch_stap_parse_special_token_p" and
3075         "gdbarch_stap_parse_special_token" in the same "if" statement.
3076         Invert check when verifying for operation on register
3077         displacement.
3078
3079 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3080
3081         * stap-probe.c (stap_get_opcode): Update comment.
3082         (stap_get_expected_argument_type): Likewise.
3083         (handle_stap_probe): Likewise.
3084
3085 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3086
3087         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3088         return type to 'bool'.  Adjust comment.  Use 'bool' when
3089         appropriate.
3090         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3091         * stap-probe.c (stap_parse_argument_1): Likewise.
3092         (stap_is_operator): Likewise.
3093         (stap_is_generic_prefix): Likewise.
3094         (stap_is_register_prefix): Likewise.
3095         (stap_is_register_indirection_prefix): Likewise.
3096         (stap_is_integer_prefix): Likewise.
3097         (stap_generic_check_suffix): Likewise.
3098         (stap_check_integer_suffix): Likewise.
3099         (stap_check_register_suffix): Likewise.
3100         (stap_check_register_indirection_suffix): Likewise.
3101         (stap_parse_register_operand): Likewise.
3102         (stap_parse_single_operand): Likewise.
3103         (stap_parse_argument_1): Likewise.
3104         (stap_probe::get_argument_count): Likewise.
3105         (stap_is_operator): Likewise.
3106
3107 2019-05-16  Tom Tromey  <tromey@adacore.com>
3108
3109         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3110         keyword to foreach.
3111
3112 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3113
3114         * linux-thread-db.c (try_thread_db_load_1): Change return type
3115         to bool.
3116         (try_thread_db_load): Likewise.
3117         (try_thread_db_load_from_pdir_1): Likewise.
3118         (try_thread_db_load_from_pdir): Likewise.
3119         (try_thread_db_load_from_sdir): Likewise.
3120         (try_thread_db_load_from_dir): Likewise.
3121         (thread_db_load_search): Likewise.
3122         (has_libpthread): Likewise.
3123         (thread_db_load): Likewise.
3124
3125 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3126
3127         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3128         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3129         NULL, and complain/return if that's the case.
3130
3131 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3132
3133         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3134         (advance, posn, abstract_read_memory): New functions.
3135         [struct mem_read_abstraction]: New struct.
3136         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3137
3138 2019-05-14  Tom Tromey  <tromey@adacore.com>
3139
3140         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3141         value is not lval_memory.
3142
3143 2019-05-14  Tom Tromey  <tromey@adacore.com>
3144
3145         * solib.c (info_sharedlibrary_command): Style the file name.
3146
3147 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3148
3149         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3150         (aarch64_vnv_type): Likewise.
3151         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3152         * common/tdesc.c: Likewise.
3153         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3154         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3155         * features/aarch64-fpu.xml: Add ieee half view.
3156         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3157         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3158         * gdbtypes.h (struct builtin_type): Likewise.
3159         (struct objfile_type): Likewise.
3160
3161 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3162
3163         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3164         typo.
3165         * location.h (string_to_event_location): Likewise.
3166
3167 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3168
3169         GDB 8.3 released.
3170
3171 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3172
3173         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3174         New variable declaration.
3175         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3176         New variable.
3177         (print_one_breakpoint): Use ui_out::test_flags and new global
3178         variable to compute use_fixed_output.
3179         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3180         Remove.
3181         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3182         (mi_multi_location_breakpoint_output_fixed): Remove.
3183         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3184         new variable.
3185         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3186         fix_multi_location_breakpoint_output flag if version >= 3.
3187         * ui-out.h (enum ui_out_flag)
3188         <fix_multi_location_breakpoint_output>: New enumerator.
3189
3190 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3191
3192         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3193
3194 2019-05-10  Tom Tromey  <tromey@adacore.com>
3195
3196         * ada-lang.c (catch_ada_completer): New function.
3197         (_initialize_ada_language): Use it.
3198
3199 2019-05-10  Tom Tromey  <tromey@adacore.com>
3200
3201         * thread.c (print_thread_info): Make "requested_threads" const.
3202         * gdbthread.h (print_thread_info): Make "requested_threads"
3203         const.
3204         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3205         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3206
3207 2019-05-08  Tom Tromey  <tom@tromey.com>
3208
3209         * gdbtypes.c (objfile_type_data): Change type.
3210         (objfile_type, _initialize_gdbtypes): Update.
3211
3212 2019-05-08  Tom Tromey  <tom@tromey.com>
3213
3214         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3215         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3216         (_initialize_dwarf2_frame): Update.
3217
3218 2019-05-08  Tom Tromey  <tom@tromey.com>
3219
3220         * objc-lang.c (objc_objfile_data): Change type.
3221         (find_methods): Update.
3222         (_initialize_objc_lang): Remove.
3223
3224 2019-05-08  Tom Tromey  <tom@tromey.com>
3225
3226         * stabsread.c (rs6000_builtin_type_data): Change type.
3227         (rs6000_builtin_type, _initialize_stabsread): Update.
3228
3229 2019-05-08  Tom Tromey  <tom@tromey.com>
3230
3231         * mips-tdep.c (mips_pdr_data): Remove.
3232         (_initialize_mips_tdep): Update.
3233
3234 2019-05-08  Tom Tromey  <tom@tromey.com>
3235
3236         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3237         (hppa_init_objfile_priv_data, read_unwind_info)
3238         (find_unwind_entry, _initialize_hppa_tdep): Update.
3239
3240 2019-05-08  Tom Tromey  <tom@tromey.com>
3241
3242         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3243         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3244         on obstack.
3245         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3246
3247 2019-05-08  Tom Tromey  <tom@tromey.com>
3248
3249         * mdebugread.c (basic_type_data): Change type.
3250         (basic_type, _initialize_mdebugread): Update.
3251
3252 2019-05-08  Tom Tromey  <tom@tromey.com>
3253
3254         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3255
3256 2019-05-08  Tom Tromey  <tom@tromey.com>
3257
3258         * nto-tdep.c (nto_inferior_data_reg): Change type.
3259         (nto_inferior_data): Update.
3260         (nto_inferior_data_cleanup, nto_new_inferior_data)
3261         (_initialize_nto_tdep): Remove.
3262         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3263
3264 2019-05-08  Tom Tromey  <tom@tromey.com>
3265
3266         * ada-lang.c (struct ada_inferior_data): Add initializers.
3267         (ada_inferior_data): Change type.
3268         (ada_inferior_data_cleanup): Remove.
3269         (get_ada_inferior_data, ada_inferior_exit)
3270         (struct ada_pspace_data): Add initializers, destructor.
3271         (ada_pspace_data_handle): Change type.
3272         (get_ada_pspace_data): Update.
3273         (ada_pspace_data_cleanup): Remove.
3274
3275 2019-05-08  Tom Tromey  <tom@tromey.com>
3276
3277         * coffread.c (struct coff_symfile_info): Add initializers.
3278         (coff_objfile_data_key): Move lower.  Change type.
3279         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3280         Update.
3281         (coff_free_info): Remove.
3282
3283 2019-05-08  Tom Tromey  <tom@tromey.com>
3284
3285         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3286         (fbsd_pspace_data_handle): Move lower.  Change type.
3287         (get_fbsd_pspace_data): Update.
3288         (fbsd_pspace_data_cleanup): Remove.
3289         (_initialize_fbsd_tdep): Update.
3290
3291 2019-05-08  Tom Tromey  <tom@tromey.com>
3292
3293         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3294         (get_ada_tasks_pspace_data): Update.
3295         (ada_tasks_pspace_data_cleanup): Remove.
3296         (_initialize_tasks): Update.
3297         (ada_tasks_inferior_data_handle): Change type.
3298         (get_ada_tasks_inferior_data): Update.
3299         (ada_tasks_inferior_data_cleanup): Remove.
3300         (struct ada_tasks_pspace_data): Add initializers.
3301
3302 2019-05-08  Tom Tromey  <tom@tromey.com>
3303
3304         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3305         * symfile-debug.c (debug_sym_get_probes): Change type.
3306         * stap-probe.c (handle_stap_probe):
3307         (stap_static_probe_ops::get_probes): Change type.
3308         * probe.h (class static_probe_ops) <get_probes>: Change type.
3309         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3310         (parse_probes_in_pspace): Update.
3311         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3312         Update.
3313         (any_static_probe_ops::get_probes): Change type.
3314         * elfread.c (elfread_data): New typedef.
3315         (probe_key): Change type.
3316         (elf_get_probes): Likewise.  Update.
3317         (probe_key_free): Remove.
3318         (_initialize_elfread): Update.
3319         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3320         Change type.
3321         (dtrace_process_dof_probe, dtrace_process_dof)
3322         (dtrace_static_probe_ops::get_probe): Change type.
3323
3324 2019-05-08  Tom Tromey  <tom@tromey.com>
3325
3326         * xcoffread.c (struct xcoff_symfile_info): Rename from
3327         coff_symfile_info.  Add initializers.
3328         (xcoff_objfile_data_key): Move lower.  Change type.
3329         (XCOFF_DATA): Rewrite.
3330         (xcoff_free_info): Remove.
3331         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3332         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3333         (xcoff_initial_scan): Update.
3334
3335 2019-05-08  Tom Tromey  <tom@tromey.com>
3336
3337         * solib-svr4.c (struct svr4_info): Add initializers and
3338         destructor.
3339         <probes_table>: Now an htab_up.
3340         (solib_svr4_pspace_data): Change type.
3341         (free_probes_table): Simplify.
3342         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3343         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3344         (probes_table_remove_objfile_probes, register_solib_event_probe)
3345         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3346         (_initialize_svr4_solib): Update.
3347
3348 2019-05-08  Tom Tromey  <tom@tromey.com>
3349
3350         * remote.c (remote_pspace_data): Change type.
3351         (remote_pspace_data_cleanup): Remove.
3352         (get_remote_exec_file, set_pspace_remote_exec_file)
3353         (_initialize_remote): Update.
3354
3355 2019-05-08  Tom Tromey  <tom@tromey.com>
3356
3357         * breakpoint.c (breakpoint_objfile_key): Change type.
3358         (get_breakpoint_objfile_data): Update.
3359         (free_breakpoint_objfile_data): Remove.
3360         (_initialize_breakpoint): Update.
3361
3362 2019-05-08  Tom Tromey  <tom@tromey.com>
3363
3364         * linux-tdep.c (struct linux_info): Add initializers.
3365         (linux_inferior_data): Move.  Change type.
3366         (invalidate_linux_cache_inf): Update.
3367         (linux_inferior_data_cleanup): Remove.
3368         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3369
3370 2019-05-08  Tom Tromey  <tom@tromey.com>
3371
3372         * auxv.c (auxv_inferior_data): Move.  Change type.
3373         (auxv_inferior_data_cleanup): Remove.
3374         (invalidate_auxv_cache_inf): Rewrite.
3375         (get_auxv_inferior_data, _initialize_auxv): Update.
3376
3377 2019-05-08  Tom Tromey  <tom@tromey.com>
3378
3379         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3380         (symfile_debug_objfile_data_key): Change type.
3381         (symfile_debug_installed, debug_qf_has_symbols)
3382         (debug_qf_find_last_source_symtab)
3383         (debug_qf_forget_cached_source_info)
3384         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3385         (debug_qf_print_stats, debug_qf_dump)
3386         (debug_qf_expand_symtabs_for_function)
3387         (debug_qf_expand_all_symtabs)
3388         (debug_qf_expand_symtabs_with_fullname)
3389         (debug_qf_map_matching_symbols)
3390         (debug_qf_expand_symtabs_matching)
3391         (debug_qf_find_pc_sect_compunit_symtab)
3392         (debug_qf_map_symbol_filenames)
3393         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3394         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3395         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3396         (debug_sym_read_linetable, debug_sym_relocate): Update.
3397         (symfile_debug_free_objfile): Remove.
3398         (install_symfile_debug_logging, _initialize_symfile_debug):
3399         Update.
3400
3401 2019-05-08  Tom Tromey  <tom@tromey.com>
3402
3403         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3404         allocate_on_obstack.
3405         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3406         (get_dwarf2_per_objfile): Update.
3407         (set_dwarf2_per_objfile): Remove.
3408         (dwarf2_has_info, dwarf2_get_section_info): Update.
3409         (dwarf2_free_objfile): Remove.
3410         (_initialize_dwarf2_read): Update.
3411
3412 2019-05-08  Tom Tromey  <tom@tromey.com>
3413
3414         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3415         initializers.
3416         <unsupported_script_warning_printed,
3417         script_not_found_warning_printed>: Now bool.
3418         (auto_load_pspace_data): Change type.
3419         (~auto_load_pspace_info): Rename from
3420         auto_load_pspace_data_cleanup.
3421         (get_auto_load_pspace_data, init_loaded_scripts_info)
3422         (clear_section_scripts, maybe_print_unsupported_script_warning)
3423         (maybe_print_script_not_found_warning, _initialize_auto_load):
3424         Update.
3425
3426 2019-05-08  Tom Tromey  <tom@tromey.com>
3427
3428         * objfiles.c (objfile_pspace_info): Add destructor and
3429         initializers.
3430         (objfiles_pspace_data): Change type.
3431         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3432         (get_objfile_pspace_data): Update.
3433         (objfiles_bfd_data): Change type.
3434         (get_objfile_bfd_data): Update.
3435         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3436
3437 2019-05-08  Tom Tromey  <tom@tromey.com>
3438
3439         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3440         Change type.
3441         (get_catch_syscall_inferior_data): Update.
3442         (catch_syscall_inferior_data_cleanup): Remove.
3443         (_initialize_break_catch_syscall): Update.
3444
3445 2019-05-08  Tom Tromey  <tom@tromey.com>
3446
3447         * inflow.c (struct terminal_info): Add destructor and
3448         initializers.
3449         (inflow_inferior_data): Change type.
3450         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3451         (get_inflow_inferior_data, inflow_inferior_exit)
3452         (swap_terminal_info, _initialize_inflow): Update.
3453
3454 2019-05-08  Tom Tromey  <tom@tromey.com>
3455
3456         * target-dcache.c (target_dcache_cleanup): Remove.
3457         (target_dcache_aspace_key): Change type.
3458         (target_dcache_init_p, target_dcache_invalidate)
3459         (target_dcache_get, target_dcache_get_or_init)
3460         (_initialize_target_dcache): Update.
3461         * dcache.h (struct dcache_deleter): New.
3462
3463 2019-05-08  Tom Tromey  <tom@tromey.com>
3464
3465         * symtab.c (struct symbol_cache): Add destructor and
3466         initializers.
3467         (symbol_cache_key): Move.  Change type.
3468         (make_symbol_cache, free_symbol_cache): Remove.
3469         (get_symbol_cache): Update.
3470         (symbol_cache_cleanup): Remove.
3471         (ALL_PSPACES, symbol_cache_flush)
3472         (maintenance_print_symbol_cache)
3473         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3474         Update.
3475
3476 2019-05-08  Tom Tromey  <tom@tromey.com>
3477
3478         * symtab.c (struct main_info): Add destructor and initializers.
3479         (main_progspace_key): Move.  Change type.
3480         (get_main_info): Update.
3481         (main_info_cleanup): Remove.
3482         (_initialize_symtab): Update.
3483
3484 2019-05-08  Tom Tromey  <tom@tromey.com>
3485
3486         * registry.h (DECLARE_REGISTRY): Define the _key class.
3487
3488 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3489
3490         * NEWS: Merge two 'New commands' sections.
3491
3492 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3493
3494         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3495         parameter and use Ada language definition instead.
3496         (ada_val_print_ptr): Remove unused language parameter.
3497         (ada_val_print_num): Remove language parameter and use Ada language
3498         definition instead.
3499         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3500         parameter.
3501         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3502         parameter and use Ada language definition instead.
3503         (ada_val_print_1): Update all ada_val_print_xxx calls.
3504         Remove language parameter.
3505         (ada_val_print): Update ada_val_print_1 call.
3506
3507 2019-05-08  Tom Tromey  <tromey@adacore.com>
3508
3509         * remote.c (remote_hw_watchpoint_limit)
3510         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3511         Now static.
3512
3513 2019-05-08  Tom Tromey  <tromey@adacore.com>
3514
3515         * maint.c (_initialize_maint_cmds): Move initialization code to
3516         remote.c.
3517         (watchdog, show_watchdog): Move to remote.c.
3518         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3519         "watchdog" static.
3520         (_initialize_remote): Move initialization code from maint.c.
3521         * defs.h (watchdog): Don't declare.
3522
3523 2019-05-08  Tom Tromey  <tromey@adacore.com>
3524
3525         * tui/tui-interp.c: Include main.h.
3526         * interps.c: Include main.h.
3527         * main.h (interpreter_p): Declare.
3528         * defs.h (interpreter_p): Don't declare.
3529
3530 2019-05-08  Tom Tromey  <tromey@adacore.com>
3531
3532         * dwarf2loc.c: Include dwarf2read.h.
3533         * defs.h (read_unsigned_leb128): Don't declare.
3534         * dwarf2read.h (read_unsigned_leb128): Declare.
3535
3536 2019-05-08  Tom Tromey  <tromey@adacore.com>
3537
3538         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3539         method.
3540
3541 2019-05-08  Tom Tromey  <tromey@adacore.com>
3542
3543         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3544         when no wrap column is set.
3545
3546 2019-05-08  Tom Tromey  <tromey@adacore.com>
3547
3548         * c-lang.c (c_get_string): Handle non-C-style arrays.
3549
3550 2019-05-08  Tom Tromey  <tromey@adacore.com>
3551
3552         * typeprint.c (print_offset_data::update): Print the bit offset,
3553         not the number of bits remaining.
3554
3555 2019-05-08  Tom Tromey  <tromey@adacore.com>
3556
3557         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3558         padding at end of comment.
3559
3560 2019-05-08  Tom Tromey  <tromey@adacore.com>
3561
3562         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3563         Compare main types.
3564
3565 2019-05-06  Tom Tromey  <tom@tromey.com>
3566
3567         * common/scoped_mmap.c: Include common-defs.h.
3568         * common/scoped_mmap.h: Don't include config.h.
3569
3570 2019-05-04  Tom Tromey  <tom@tromey.com>
3571
3572         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3573         (struct aarch64_call_info): Add initializers.
3574         <si>: Now a std::vector.
3575         (pass_on_stack, aarch64_push_dummy_call): Update.
3576
3577 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3578             Tom Tromey  <tom@tromey.com>
3579
3580         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3581         (ppc_threads): Now a std::vector.  Now static.
3582         (hwdebug_find_thread_points_by_tid)
3583         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3584         Update.
3585
3586 2019-05-04  Tom Tromey  <tom@tromey.com>
3587
3588         * arc-tdep.c (arc_tdesc_init): Return bool.
3589
3590 2019-05-04  Tom Tromey  <tom@tromey.com>
3591
3592         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3593         Use gdb_assert_not_reached.
3594
3595 2019-05-04  Tom Tromey  <tom@tromey.com>
3596
3597         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3598         "false".
3599
3600 2019-05-04  Tom Tromey  <tom@tromey.com>
3601
3602         * arc-tdep.c (arc_tdesc_init): Use bool.
3603
3604 2019-05-04  Tom Tromey  <tom@tromey.com>
3605
3606         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3607
3608 2019-05-04  Tom Tromey  <tom@tromey.com>
3609
3610         * cli/cli-cmds.c (valid_command_p): Return bool.
3611
3612 2019-05-04  Tom Tromey  <tom@tromey.com>
3613
3614         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3615         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3616
3617 2019-05-04  Raul Tambre  <raul@tambre.ee>
3618
3619         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3620         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3621         operator for comparison.
3622
3623 2019-05-04  Tom Tromey  <tom@tromey.com>
3624
3625         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3626         (lookup_partial_symbol, print_partial_symbols)
3627         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3628         (psymbol_compare): Update.
3629         (add_psymbol_to_bcache): Clear the entire psymbol.
3630         (maintenance_check_psymtabs): Update.
3631         * psympriv.h (struct partial_symbol): Don't derive from
3632         general_symbol_info.
3633         <obj_section, unrelocated_address, address,
3634         set_unrelocated_address>: Update.
3635         <ginfo>: New member.
3636         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3637         (debug_names::write_psymbols): Update.
3638
3639 2019-05-04  Tom de Vries  <tdevries@suse.de>
3640
3641         * contrib/cc-with-tweaks.sh: Support -n arg.
3642
3643 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3644
3645         * corelow.c (core_target::detach): Ensure frame cache and
3646         register caches are cleared.
3647         inferior.c (exit_inferior_1): Likewise.
3648
3649 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
3650             Tom Tromey  <tom@tromey.com>
3651
3652         * dictionary.c (collate_pending_symbols_by_language): Remove
3653         "struct" from foreach.
3654         * symtab.c (lookup_global_symbol_from_objfile)
3655         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
3656         foreach.
3657         * ser-tcp.c (net_open): Remove "struct" from foreach.
3658         * objfiles.c (objfile_relocate, objfile_rebase)
3659         (objfile_has_symbols): Remove "struct" from foreach.
3660         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
3661         from foreach.
3662         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
3663         foreach.
3664         * darwin-nat.c (thread_info_from_private_thread_info): Remove
3665         "struct" from foreach.
3666         * ada-lang.c (create_excep_cond_exprs)
3667         (ada_exception_catchpoint_cond_string): Remove "struct" from
3668         foreach.
3669
3670 2019-05-03  Tom Tromey  <tromey@adacore.com>
3671
3672         * ada-exp.y (convert_char_literal): Check suffix of each
3673         enumerator.
3674
3675 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
3676
3677         PR ada/21406:
3678         * ada-exp.y (yywrap): Don't define.
3679         * ada-lex.l (%option): Add noyywrap
3680         (yywrap): Remove.
3681
3682 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
3683
3684         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
3685         _WIN32_WINNT to the XP level, unless already defined to a higher
3686         level.
3687
3688         * unittests/parse-connection-spec-selftests.c:
3689         * ser-tcp.c:
3690         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
3691         override.
3692
3693         * symfile.c (find_separate_debug_file): Remove colon from the
3694         drive spec of DOS/Windows file names of the target, so that the
3695         file name produced from DEBUGDIR and the target's directory will
3696         be valid on DOS/Windows systems.
3697
3698 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3699
3700         * rust-lang.c (val_print_struct): Handle printing structures
3701         containing strings.
3702
3703 2019-05-02  Tom Tromey  <tromey@adacore.com>
3704
3705         * valarith.c (_initialize_valarith): Remove.
3706
3707 2019-05-01  Tom Tromey  <tromey@adacore.com>
3708
3709         * ada-lang.c (ada_value_primitive_field): Treat more fields as
3710         bitfields.
3711
3712 2019-05-01  Tom Tromey  <tromey@adacore.com>
3713
3714         * ada-lang.c (ada_value_assign): Correctly compute starting offset
3715         for big-endian copies.
3716
3717 2019-04-30  Ali Tamur  <tamur@google.com>
3718         * gdb/dwarf2read.c (read_3_bytes): New declaration.
3719         (read_attribute_value): Added DW_FORM_strx1-4 cases.
3720         (read_3_bytes): New function.
3721
3722 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3723
3724         * windows-nat.c (main_thread_id): Delete.
3725         (handle_output_debug_string): Replace main_thread_id by
3726         current_event.dwThreadId.
3727         (fake_create_process): Likewise.
3728         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
3729         Do not set main_thread_id.
3730         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
3731         current_event.dwThreadId.
3732         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
3733
3734 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3735
3736         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
3737         Use current_event.dwThreadId instead of main_thread_id.
3738
3739 2019-04-30  Tom Tromey  <tromey@adacore.com>
3740
3741         * ada-lang.c (ada_lookup_simple_minsyms): New function.
3742         (create_excep_cond_exprs): Iterate over program spaces.
3743         (ada_exception_catchpoint_cond_string): Examine all minimal
3744         symbols for exception types.
3745
3746 2019-04-30  Tom Tromey  <tromey@adacore.com>
3747
3748         PR c++/24470:
3749         * dwarf2read.c (process_structure_scope): Handle case where type
3750         has template parameters but no symbol was created.
3751
3752 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3753             Chris January  <chris.january@arm.com>
3754
3755         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
3756         qualifier.
3757         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
3758
3759 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3760
3761         * f-typeprint.c (f_print_type): Update rules for printing
3762         whitespace.
3763         (f_type_print_varspec_suffix): Likewise.
3764
3765 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3766             Chris January  <chris.january@arm.com>
3767
3768         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
3769         function arguments.
3770
3771 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3772
3773         * f-lang.c (build_fortran_types): Change name of void type to
3774         lower case.
3775         * f-typeprint.c (f_type_print_base): Print the name of the void
3776         type, rather than a fixed string.
3777         * f-valprint.c (f_decorations): Use lower case void string.
3778
3779 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3780             Chris January  <chris.january@arm.com>
3781
3782         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
3783         types for Fortran.
3784
3785 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3786             Chris January  <chris.january@arm.com>
3787             David Lecomber  <david.lecomber@arm.com>
3788
3789         * f-exp.y (BINOP_INTRINSIC): New token.
3790         (exp): New parser rule handling BINOP_INTRINSIC.
3791         (f77_keywords): Add new builtin procedures.
3792         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
3793         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3794         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
3795         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3796         (print_unop_subexp_f): New function.
3797         (print_binop_subexp_f): New function.
3798         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3799         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3800         (dump_subexp_body_f): Likewise.
3801         (operator_check_f): Likewise.
3802         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3803         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
3804
3805 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3806
3807         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
3808         UNOP_KIND.
3809         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
3810         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
3811         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
3812         (operator_length_f): New fuction.
3813         (print_subexp_f): New function.
3814         (op_name_f): New function.
3815         (dump_subexp_body_f): New function.
3816         (operator_check_f): New function.
3817         (exp_descriptor_f): Replace standard expression handling functions
3818         with new functions.
3819         * gdb/fortran-operator.def: New file.
3820         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
3821         * gdb/std-operator.def: Remove UNOP_KIND.
3822
3823 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3824
3825         * std-operator.def: Remove unbalanced, stray double quote
3826         character.
3827
3828 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3829             Chris January  <chris.january@arm.com>
3830             Daniel Everett  <daniel.everett@arm.com>
3831             Nick Forrington  <nick.forrington@arm.com>
3832             Richard Bunt  <richard.bunt@arm.com>
3833
3834         * cp-valprint.c (cp_print_value_fields): Allow an additional level
3835         of depth when printing anonymous structs or unions.
3836         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
3837         Don't print either the top-level value, or the children if the
3838         max-depth is exceeded.
3839         (ppscm_print_children): When printing the key of a map, allow one
3840         extra level of depth.
3841         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
3842         print either the top-level value, or the children if the max-depth
3843         is exceeded.
3844         (print_children): When printing the key of a map, allow one extra
3845         level of depth.
3846         * python/py-value.c (valpy_format_string): Add max_depth keyword.
3847         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
3848         (user_print_options): Initialise max_depth field.
3849         (val_print_scalar_or_string_type_p): New function.
3850         (val_print): Check to see if the max depth has been reached.
3851         (val_print_check_max_depth): Define new function.
3852         (show_print_max_depth): New function.
3853         (_initialize_valprint): Add 'print max-depth' option.
3854         * valprint.h (struct value_print_options) <max_depth>: New field.
3855         (val_print_check_max_depth): Declare new function.
3856         * NEWS: Document new feature.
3857
3858 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3859
3860         * ada-lang.c (ada_language_defn): Initialise new field.
3861         * c-lang.c (c_is_string_type_p): New function.
3862         (c_language_defn): Initialise new field.
3863         (cplus_language_defn): Initialise new field.
3864         (asm_language_defn): Initialise new field.
3865         (minimal_language_defn): Initialise new field.
3866         * c-lang.h (c_is_string_type_p): Declare new function.
3867         * d-lang.c (d_language_defn): Initialise new field.
3868         * f-lang.c (f_is_string_type_p): New function.
3869         (f_language_defn): Initialise new field.
3870         * go-lang.c (go_is_string_type_p): New function.
3871         (go_language_defn): Initialise new field.
3872         * language.c (default_is_string_type_p): New function.
3873         (unknown_language_defn): Initialise new field.
3874         (auto_language_defn): Initialise new field.
3875         * language.h (struct language_defn) <la_is_string_type_p>: New
3876         member variable.
3877         (default_is_string_type_p): Declare new function.
3878         * m2-lang.c (m2_language_defn): Initialise new field.
3879         * objc-lang.c (objc_language_defn): Initialise new field.
3880         * opencl-lang.c (opencl_language_defn): Initialise new field.
3881         * p-lang.c (pascal_is_string_type_p): New function.
3882         (pascal_language_defn): Initialise new field.
3883         * rust-lang.c (rust_is_string_type_p): New function.
3884         (rust_language_defn): Initialise new field.
3885
3886 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3887
3888         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
3889         New field.
3890         * ada-lang.c (ada_language_defn): Initialise new field.
3891         * c-lang.c (c_language_defn): Likewise.
3892         (cplus_language_defn): Likewise.
3893         (asm_language_defn): Likewise.
3894         (minimal_language_defn): Likewise.
3895         * d-lang.c (d_language_defn): Likewise.
3896         * f-lang.c (f_language_defn): Likewise.
3897         * go-lang.c (go_language_defn): Likewise.
3898         * language.c (unknown_language_defn): Likewise.
3899         (auto_language_defn): Likewise.
3900         * m2-lang.c (m2_language_defn): Likewise.
3901         * objc-lang.c (objc_language_defn): Likewise.
3902         * opencl-lang.c (opencl_language_defn): Likewise.
3903         * p-lang.c (pascal_language_defn): Likewise.
3904         * rust-lang.c (rust_language_defn): Likewise.
3905
3906 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3907
3908         * ada-lang.c (ada_is_character_type): Change return type to bool.
3909         (ada_is_string_type): Likewise.
3910         * ada-lang.h (ada_is_character_type): Update declaration
3911         (ada_is_string_type): Likewise.
3912
3913 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3914
3915         Support style in 'frame|thread apply'
3916
3917         * gdbcmd.h (execute_command_to_string): New term_out parameter.
3918         * record.c (record_start, record_stop): Update callers of
3919         execute_command_to_string with false.
3920         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
3921         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
3922         methods.
3923         (class string_file): New constructor with term_out parameter.
3924         Override methods term_out and can_emit_style_escape.  New member
3925         term_out.
3926         (class stdio_file): Override can_emit_style_escape.
3927         (class tee_file): Override term_out and can_emit_style_escape.
3928         * utils.h (can_emit_style_escape): Remove.
3929         * utils.c (can_emit_style_escape): Likewise.
3930         Update all callers of can_emit_style_escape (SOMESTREAM) to
3931         SOMESTREAM->can_emit_style_escape.
3932         * source-cache.c (source_cache::get_source_lines): Likewise.
3933         * stack.c (frame_apply_command_count): Call execute_command_to_string
3934         passing the term_out characteristic of the current gdb_stdout.
3935         * thread.c (thr_try_catch_cmd): Likewise.
3936         * top.c (execute_command_to_string): pass term_out parameter
3937         to construct the string_file for the command output.
3938         * ui-file.c (term_cli_styling): New function (most code moved
3939         from utils.c can_emit_style_escape).
3940         (string_file::string_file, string_file::can_emit_style_escape,
3941         stdio_file::can_emit_style_escape, tee_file::term_out,
3942         tee_file::can_emit_style_escape): New functions.
3943
3944 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3945
3946         * NEWS: Mention the new set|show may-call-functions.
3947         * infcall.c (may_call_functions_p): New variable.
3948         (show_may_call_functions_p): New function.
3949         (call_function_by_hand_dummy): Throws an error if not
3950         may-call-functions.
3951         (_initialize_infcall): Call add_setshow_boolean_cmd for
3952         may-call-functions.
3953
3954 2019-04-25  Keith Seitz  <keiths@redhat.com>
3955
3956         PR c++/24367
3957         * cp-support.c (inspect_type): Don't attempt substitutions
3958         of symbol with the same name.
3959
3960 2019-04-25  Tom Tromey  <tromey@adacore.com>
3961
3962         PR gdb/24475:
3963         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
3964         static.
3965
3966 2019-04-25  Tom Tromey  <tromey@adacore.com>
3967
3968         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
3969         rvalue reference.
3970         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
3971         (gdb_xml_parser::parse): Use std::move.
3972         * python/python-internal.h (gdbpy_convert_exception): Take a const
3973         reference.
3974         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
3975         std::move.
3976         * python/py-utils.c (gdbpy_convert_exception): Take a const
3977         reference.
3978         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3979         Use std::move.
3980         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3981         Use std::move.
3982         * mi/mi-main.c (mi_print_exception): Take a const reference.
3983         * main.c (handle_command_errors): Take a const reference.
3984         * linespec.c (parse_linespec): Use std::move.
3985         * infcall.c (run_inferior_call): Use std::move.
3986         (call_function_by_hand_dummy): Use std::move.
3987         * exec.c (try_open_exec_file): Use std::move.
3988         * exceptions.h (exception_print, exception_fprintf)
3989         (exception_print_same): Update.
3990         * exceptions.c (print_exception, exception_print)
3991         (exception_fprintf, exception_print_same): Change parameters to
3992         const reference.
3993         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
3994         * common/new-op.c: Use std::move.
3995         * common/common-exceptions.h (struct gdb_exception): Add move
3996         constructor.
3997         (struct gdb_exception_error, struct gdb_exception_quit, struct
3998         gdb_quit_bad_alloc): Change constructor to move constructor.
3999         (throw_exception): Change parameter to rvalue reference.
4000         * common/common-exceptions.c (throw_exception): Take rvalue
4001         reference.
4002         * cli/cli-interp.c (safe_execute_command): Use std::move.
4003         * breakpoint.c (insert_bp_location, location_to_sals): Use
4004         std::move.
4005
4006 2019-04-25  Tom Tromey  <tromey@adacore.com>
4007
4008         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4009         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4010         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4011         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4012         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4013         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4014         guile/scm-value.c: Use unpack.
4015         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4016         gdbscm_gdb_exception.
4017         (gdbscm_throw_gdb_exception): Likewise.
4018         (struct gdbscm_gdb_exception): New.
4019         (unpack): New function.
4020         (gdbscm_wrap): Use unpack.
4021
4022 2019-04-25  Tom Tromey  <tromey@adacore.com>
4023
4024         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4025         (gdb_rl_callback_handler): Use std::move.
4026         * common/common-exceptions.h (struct gdb_exception): Add move
4027         assignment operator.
4028         (throw_exception_sjlj): Change "exception" to const reference.
4029         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4030         (throw_exception_sjlj): Change "exception" to const reference.
4031
4032 2019-04-25  Tom Tromey  <tromey@adacore.com>
4033
4034         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4035         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4036         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4037         Update.
4038         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4039         Update.
4040         * mi/mi-interp.c (mi_interp::exec): Update.
4041         * linespec.c (parse_linespec): Update.
4042         * infcall.c (run_inferior_call): Update.
4043         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4044         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4045         (gdbscm_lookup_global_symbol): Update.
4046         * guile/scm-param.c (gdbscm_parameter_value): Update.
4047         * guile/scm-frame.c (gdbscm_frame_read_register)
4048         (gdbscm_frame_read_var): Update.
4049         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4050         * exec.c (try_open_exec_file): Update.
4051         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4052         (gdb_rl_callback_handler): Update.
4053         * common/common-exceptions.h (exception_none): Don't declare.
4054         * common/common-exceptions.c (exception_none): Don't define.
4055         (struct catcher) <exception>: Update.
4056         * cli/cli-interp.c (safe_execute_command): Update.
4057         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4058
4059 2019-04-25  Ali Tamur  <tamur@google.com>
4060
4061         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4062         (read_attribute_value): Likewise.
4063         (dwarf2_read_addr_index): Update comment.
4064         (read_str_index): Add DW_FORM_strx.
4065         (dwarf2_string_attr): Likewise.
4066         (dwarf2_const_value_attr): Likewise.
4067         (dump_die_shallow): Likewise.
4068         (dwarf2_fetch_constant_bytes): Likewise.
4069         (skip_form_bytes): Likewise.
4070         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4071
4072 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4073
4074         PR corefiles/11608
4075         PR corefiles/18187
4076         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4077         OFFSET.  Verify if current mapping contains an ELF header.
4078         (linux_find_memory_regions_full): Adjust call to
4079         dump_mapping_p.
4080
4081 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4082             Kang Li <kanglictf@gmail.com>
4083
4084         PR gdb/21600
4085
4086         * dwarf2-frame.c (read_initial_length): Be consistent about using
4087         unsigned representation of length.
4088         (decode_frame_entry_1): Likewise.  Check for wraparound of
4089         end pointer as well as buffer overflow.
4090
4091 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4092
4093         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4094         "vq".
4095
4096 2019-04-24  Tom Tromey  <tromey@adacore.com>
4097
4098         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4099
4100 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4101
4102         * s12z-tdep.c (s12z_unwind_pc): Delete.
4103         (s12z_unwind_sp): Delete.
4104         (s12z_gdbarch_init): Don't register deleted functions with
4105         gdbarch.
4106
4107 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4108
4109         * rl78-tdep.c (rl78_unwind_sp): Delete.
4110         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4111
4112 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4113
4114         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4115         (xstormy16_unwind_pc): Delete.
4116         (xstormy16_dummy_id): Delete.
4117         (xstormy16_gdbarch_init): Don't register deleted functions with
4118         gdbarch.
4119
4120 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4121
4122         * vax-tdep.c (vax_unwind_pc): Delete.
4123         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4124
4125 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4126
4127         * v850-tdep.c (v850_unwind_sp): Delete.
4128         (v850_unwind_pc): Delete.
4129         (v850_dummy_id): Delete.
4130         (v850_gdbarch_init): Don't register deleted functions with
4131         gdbarch.
4132
4133 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4134
4135         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4136         (tilegx_unwind_pc): Delete.
4137         (tilegx_unwind_dummy_id): Delete.
4138         (tilegx_gdbarch_init): Don't register deleted functions with
4139         gdbarch.
4140
4141 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4142
4143         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4144         (tic6x_dummy_id): Delete.
4145         (tic6x_gdbarch_init): Don't register deleted functions with
4146         gdbarch.
4147
4148 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4149
4150         * sparc-tdep.c (sparc_unwind_pc): Delete.
4151         (sparc32_gdbarch_init): Don't register deleted function with
4152         gdbarch.
4153
4154 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4155
4156         * sh-tdep.c (sh_unwind_sp): Delete.
4157         (sh_unwind_pc): Delete.
4158         (sh_dummy_id): Delete.
4159         (sh_gdbarch_init): Don't register deleted functions with
4160         gdbarch.
4161
4162 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4163
4164         * score-tdep.c (score_unwind_sp): Delete.
4165         (score_unwind_pc): Delete.
4166         (score_dummy_id): Delete.
4167         (score_gdbarch_init): Don't register deleted functions with
4168         gdbarch.
4169
4170 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4171
4172         * rx-tdep.c (rx_unwind_pc): Delete.
4173         (rx_unwind_sp): Delete.
4174         (rx_dummy_id): Delete.
4175         (rx_gdbarch_init): Don't register deleted functions with
4176         gdbarch.  Update comment.
4177
4178 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4179
4180         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4181         (rs6000_dummy_id): Delete.
4182         (rs6000_gdbarch_init): Don't register deleted functions with
4183         gdbarch.
4184
4185 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4186
4187         * or1k-tdep.c (or1k_dummy_id): Delete.
4188         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4189
4190 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4191
4192         * nios2-tdep.c (nios2_dummy_id): Delete.
4193         (nios2_unwind_sp): Delete.
4194         (nios2_gdbarch_init): Don't register deleted functions with
4195         gdbarch.
4196
4197 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4198
4199         * nds32-tdep.c (nds32_dummy_id): Delete.
4200         (nds32_unwind_pc): Delete.
4201         (nds32_unwind_sp): Delete.
4202         (nds32_gdbarch_init): Don't register deleted functions with
4203         gdbarch.
4204
4205 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4206
4207         * msp430-tdep.c (msp430_unwind_pc): Delete.
4208         (msp430_unwind_sp): Delete.
4209         (msp430_dummy_id): Delete.
4210         (msp430_gdbarch_init): Don't register deleted functions with
4211         gdbarch.
4212
4213 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4214
4215         * moxie-tdep.c (moxie_unwind_sp): Delete.
4216         (moxie_unwind_pc): Delete.
4217         (moxie_dummy_id): Delete.
4218         (moxie_gdbarch_init): Don't register deleted functions with
4219         gdbarch.
4220
4221 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4222
4223         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4224         (mn10300_unwind_pc): Delete.
4225         (mn10300_unwind_sp): Delete.
4226         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4227         mn10300_unwind_sp.
4228         (mn10300_frame_unwind_init): Don't register deleted functions with
4229         gdbarch.
4230
4231 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4232
4233         * mep-tdep.c (mep_unwind_pc): Delete.
4234         (mep_unwind_sp): Delete.
4235         (mep_dummy_id): Delete.
4236         (mep_gdbarch_init): Don't register deleted functions with
4237         gdbarch.
4238
4239 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4240
4241         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4242         (m68hc11_unwind_sp): Delete.
4243         (m68hc11_gdbarch_init): Don't register deleted functions with
4244         gdbarch.
4245
4246 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4247
4248         * m32r-tdep.c (m32r_unwind_sp): Delete.
4249         (m32r_unwind_pc): Delete.
4250         (m32r_dummy_id): Delete.
4251         (m32r_gdbarch_init): Don't register deleted functions with
4252         gdbarch.
4253
4254 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4255
4256         * m32c-tdep.c (m32c_unwind_pc): Delete.
4257         (m32c_unwind_sp): Delete.
4258         (m32c_dummy_id): Delete.
4259         (m32c_gdbarch_init): Don't register deleted functions with
4260         gdbarch.
4261
4262 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4263
4264         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4265         (lm32_unwind_pc): Delete.
4266         (lm32_dummy_id): Delete.
4267         (lm32_gdbarch_init): Don't register deleted functions with
4268         gdbarch.
4269
4270 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4271
4272         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4273         (iq2000_unwind_pc): Delete.
4274         (iq2000_dummy_id): Delete.
4275         (iq2000_gdbarch_init): Don't register deleted functions with
4276         gdbarch.
4277
4278 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4279
4280         * nds32-tdep.c (nds32_type_align): Delete.
4281         (nds32_push_dummy_call): Use type_align instead.
4282
4283 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4284
4285         * arm-tdep.c (arm_type_align): Only handle vector override case.
4286         (arm_push_dummy_call): Use type_align.
4287         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4288
4289 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4290
4291         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4292         case.
4293         (pass_on_stack): Use type_align.
4294         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4295         function.
4296
4297 2019-04-23  Tom Tromey  <tromey@adacore.com>
4298
4299         * dwarf2read.c (line_header::file_name_at): Remove unused
4300         overload.
4301
4302 2019-04-23  Tom de Vries  <tdevries@suse.de>
4303
4304         PR gdb/24438
4305         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4306         invocation.
4307
4308
4309 2019-03-27  Ali Tamur  <tamur@google.com>
4310
4311         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4312         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4313         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4314         (dwarf_expr_context::get_addr_index): Likewise
4315         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4316         (symbol_needs_eval_context::get_addr_index): Likewise
4317         (disassemble_dwarf_expression): Add DW_OP_addrx
4318         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4319         (read_cutu_die_from_dwo): Update comment
4320         (skip_one_die): Add DW_FORM_addrx
4321         (read_attribute_value): Likewise
4322         (var_decode_location): Add DW_OP_addrx
4323         (dwarf2_const_value_attr): Add DW_FORM_addrx
4324         (dump_die_shallow): Likewise
4325         (dwarf2_fetch_constant_bytes): Likewise
4326         (decode_locdesc): Add DW_OP_addrx
4327         (skip_form_bytes): Add DW_FORM_addrx
4328
4329 2019-04-22  Ali Tamur  <tamur@google.com>
4330
4331         * MAINTAINERS (Write After Approval): Add self.
4332
4333 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4334
4335         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4336         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4337         (open_symbol_file_object): Likewise.
4338         (svr4_default_sos): Add info parameter.
4339         (svr4_read_so_list): Likewise.
4340         (svr4_current_sos_direct): Adjust functions calls to pass down
4341         info.
4342         (svr4_current_sos_1): Add info parameter.
4343         (svr4_current_sos): Call get_svr4_info, pass info down to
4344         svr4_current_sos_1.
4345         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4346         get_svr4_info.
4347         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4348         get_svr4_info.
4349         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4350         to get_svr4_info.
4351         (probes_table_remove_objfile_probes): Likewise.
4352         (register_solib_event_probe): Add info parameter.
4353         (solist_update_incremental): Pass info parameter down to
4354         svr4_read_so_list.
4355         (disable_probes_interface): Add info parameter.
4356         (svr4_handle_solib_event): Pass current_program_space to
4357         get_svr4_info.  Adjust disable_probes_interface cleanup.
4358         (svr4_create_probe_breakpoints): Add info parameter, pass it
4359         down to register_solib_event_probe.
4360         (svr4_create_solib_event_breakpoints): Add info parameter,
4361         pass it down to svr4_create_probe_breakpoints.
4362         (enable_break): Pass info down to
4363         svr4_create_solib_event_breakpoints.
4364         (svr4_solib_create_inferior_hook): Pass current_program_space to
4365         get_svr4_info.
4366         (svr4_clear_solib): Likewise.
4367
4368 2019-04-22  Pedro Alves  <palves@redhat.com>
4369
4370         * solib-svr4.c (svr4_free_objfile_observer): New.
4371         (probe_and_action::objfile): New field.
4372         (probes_table_htab_remove_objfile_probes)
4373         (probes_table_remove_objfile_probes): New functions.
4374         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4375         in the new probe_and_action.  Don't store the probe in 'lookup'.
4376         (svr4_create_probe_breakpoints): Pass objfile to
4377         register_solib_event_probe.
4378         (_initialize_svr4_solib): Register a free_objfile observer.
4379
4380 2019-04-19  Tom Tromey  <tom@tromey.com>
4381
4382         * common/queue.h: Remove.
4383
4384 2019-04-19  Tom Tromey  <tom@tromey.com>
4385
4386         * event-loop.c: Don't include "common/queue.h".
4387
4388 2019-04-19  Tom Tromey  <tom@tromey.com>
4389
4390         * remote.c (remote_target): Use delete.
4391         * remote-notif.h: Include <list>, not "common/queue.h".
4392         (notif_client_p): Remove typedef.
4393         (remote_notif_state): Add constructor, destructor, initializer.
4394         <notif_queue>: Now a std::list.
4395         (remote_notif_state_xfree): Don't declare.
4396         * remote-notif.c (remote_notif_process, handle_notification)
4397         (remote_notif_state_allocate): Update.
4398         (~remote_notif_state): Rename from remote_notif_state_xfree.
4399
4400 2019-04-19  Tom Tromey  <tom@tromey.com>
4401
4402         * symfile.c (reread_symbols): Update.
4403         * objfiles.c (objfile_register_static_link)
4404         (objfile_lookup_static_link): Update
4405         (~objfile) Don't delete static_links.
4406         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4407
4408 2019-04-19  Tom Tromey  <tom@tromey.com>
4409
4410         * type-stack.h (struct type_stack) <insert>: Constify string.
4411         * type-stack.c (type_stack::insert): Constify string.
4412         * gdbtypes.h (lookup_template_type): Update.
4413         (address_space_name_to_int): Update.
4414         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4415         const.
4416         (lookup_template_type): Make name const.
4417         * c-exp.y: Update rules.
4418         (lex_one_token, classify_name, classify_inner_name)
4419         (c_print_token): Update.
4420         * p-exp.y: Update rules.
4421         (yylex): Update.
4422         * f-exp.y: Update rules.
4423         (yylex): Update.
4424         * d-exp.y: Update rules.
4425         (lex_one_token, classify_name, classify_inner_name): Update.
4426         * parse.c (write_dollar_variable, copy_name): Return std::string.
4427         * parser-defs.h (copy_name): Change return type.
4428         * m2-exp.y: Update rules.
4429         (yylex): Update.
4430         * go-exp.y (lex_one_token): Update.
4431         Update rules.
4432         (classify_unsafe_function, classify_packaged_name)
4433         (classify_name, yylex): Update.
4434
4435 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4436
4437         * configure.ac: add --enable-source-highlight switch.
4438         * configure: Regenerate.
4439         * top.c (print_gdb_version): plumb --enable-source-highlight
4440         status to "show configuration".
4441
4442 2019-04-19  Tom Tromey  <tromey@adacore.com>
4443
4444         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4445         Check ADA_TYPE_P.
4446         (empty_record, ada_template_to_fixed_record_type_1)
4447         (template_to_static_fixed_type)
4448         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4449         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4450         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4451         macros.
4452
4453 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4454
4455         PR symtab/24423:
4456         * source.c (print_source_lines_base): Advance "iter" when a
4457         control character is seen.
4458
4459 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4460
4461         * inferior.h (struct infcall_suspend_state_deleter):
4462         Catch exception in destructor to avoid crash.
4463
4464 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4465
4466         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4467         close to the add_com "shell".
4468
4469 2019-04-18  Tom Tromey  <tromey@adacore.com>
4470
4471         * process-stratum-target.h (class process_stratum_target)
4472         <stratum>: Add "final".
4473
4474 2019-04-17  Tom Tromey  <tromey@adacore.com>
4475
4476         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4477         against nullptr before use.
4478
4479 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4480
4481         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4482
4483 2019-04-17  Jim Wilson  <jimw@sifive.com>
4484             Andrew Burgess  <andrew.burgess@embecosm.com>
4485
4486         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4487         code read might fail, assume 4-byte breakpoint in that case.
4488
4489 2019-04-15  Leszek Swirski  <leszeks@google.com>
4490
4491         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4492         rather than a hand-rolled POD check when checking for forced MEMORY
4493         classification.
4494
4495 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4496
4497         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4498         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4499         function.
4500         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4501         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4502         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4503         declaration.
4504
4505 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4506
4507         * aarch64-linux-nat.c
4508         (aarch64_linux_nat_target::thread_architecture): Add override.
4509         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4510         each VQ.
4511
4512 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4513
4514         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4515
4516 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4517
4518         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4519         target types of size 96-bits, add some additional comments, and
4520         check that the builtin type we found was the correct size.
4521
4522 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4523
4524         * utils.c (prompt_for_continue): Don't restore the styling at the
4525         end, as applied_style has the wrong value.  This fixes styling in
4526         long lists of file names that are interrupted by the "Continue?"
4527         prompt.
4528
4529 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4530
4531         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4532         * c-lang.c (c_language_defn): Likewise.
4533         (cplus_language_defn): Likewise.
4534         (asm_language_defn): Likewise.
4535         (minimal_language_defn): Likewise.
4536         * d-lang.c (d_language_defn): Likewise.
4537         * f-lang.c (f_language_defn): Likewise.
4538         * go-lang.c (go_language_defn): Likewise.
4539         * language.c (unknown_language_defn): Likewise.
4540         (auto_language_defn): Likewise.
4541         * language.h (struct language_defn): Remove la_magic field.
4542         (LANG_MAGIC): Delete.
4543         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4544         * objc-lang.c (objc_language_defn): Likewise.
4545         * opencl-lang.c (opencl_language_defn): Likewise.
4546         * p-lang.c (pascal_language_defn): Likewise.
4547         * rust-lang.c (rust_language_defn): Likewise.
4548
4549 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4550
4551         * riscv-tdep.c (riscv_type_align): New function.
4552         (riscv_type_alignment): Delete.
4553         (riscv_arg_location): Use 'type_align'.
4554         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4555
4556 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4557
4558         * gdbtypes.c (type_align): A struct with no non-static fields also
4559         has alignment of 1.
4560
4561 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4562
4563         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4564         component to 0.
4565         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4566         member.
4567         (riscv_struct_info::analyse): New implementation using new
4568         analyse_inner member function.
4569         (riscv_struct_info::field_offset): New member function.
4570         (riscv_struct_info::m_offsets): New member variable.
4571         (riscv_struct_info::analyse_inner): New private member function,
4572         takes the old implementation of riscv_struct_info::analyse but
4573         extended to track field offsets.
4574         (riscv_call_arg_struct): Update the struct folding special cases
4575         to handle cases where empty C++ structs, which are non-zero
4576         length, are found.
4577         (riscv_arg_location): Initialise the length of each location, a
4578         non-zero length now indicates the location is in use.
4579         (riscv_push_dummy_call): Allow for the first location having a
4580         non-zero offset when setting up arguments.
4581         (riscv_return_value): Likewise, but for return values.
4582
4583 2019-04-11  Tom Tromey  <tromey@adacore.com>
4584
4585         * utils.c (internal_vproblem): Make "msg" const.
4586
4587 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4588
4589         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4590         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4591         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4592         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4593
4594 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4595
4596         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4597         function.
4598         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4599         of amd64_collect_native_gregset.
4600         (amd64_linux_nat_target::store_registers): Likewise.
4601
4602 2019-04-10  Tom Tromey  <tom@tromey.com>
4603
4604         * symtab.c (lookup_global_symbol_from_objfile)
4605         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4606         * objfiles.h (class separate_debug_iterator): New.
4607         (class separate_debug_range): New.
4608         (struct objfile) <separate_debug_objfiles>: New method.
4609         (objfile_separate_debug_iterate): Don't declare.
4610         * objfiles.c (separate_debug_iterator::operator++): Rename from
4611         objfile_separate_debug_iterate.
4612         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4613         iterator.
4614         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4615         iterator.
4616
4617 2019-04-10  Tom Tromey  <tom@tromey.com>
4618
4619         * symfile.c (reread_symbols): Remove old comment.
4620         * objfiles.c (free_all_objfiles): Fix a typo.
4621
4622 2019-04-10  Tom Tromey  <tom@tromey.com>
4623
4624         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4625         * minsyms.c (lookup_minimal_symbol): Use foreach.
4626         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4627         (lookup_minimal_symbol_solib_trampoline): Likewise.
4628         * symfile.c (reread_symbols): Use foreach.
4629
4630 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4631             Tom Tromey  <tromey@adacore.com>
4632
4633         PR rust/24414:
4634         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4635         (rust_lex_int_test): Change "value" to be LONGEST.
4636         (rust_lex_tests): Add test for long integer literal.
4637
4638 2019-04-09  Tom Tromey  <tromey@adacore.com>
4639
4640         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
4641         to bool.
4642         (extended_remote_target::attach): Update.
4643         (remote_target::remote_notice_new_inferior): Update.
4644         (remote_target::add_current_inferior_and_thread): Update.
4645         * inferior.c (exit_inferior_1): Use "false".
4646         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
4647
4648 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
4649
4650         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
4651         the "start" command.
4652
4653 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4654
4655         * python/py-inferior.c (infpy_thread_from_thread_handle):
4656         Adjust comments to reflect renaming of thread_from_thread_handle
4657         to thread_from_handle.  Adjust keywords.  Fix type error message.
4658         (inferior_object_methods): Add thread_from_handle.  Retain
4659         thread_from_thread_handle, but mark it as deprecated.
4660
4661 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4662
4663         * gdbthread.h (find_thread_by_handle): Revise declaration.
4664         * thread.c (find_thread_by_handle): Likewise.  Adjust
4665         implementation too.
4666         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
4667         support for buffer objects as handles.
4668
4669 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4670
4671         * python/py-infthread.c (thpy_thread_handle): New function.
4672         (thread_object_methods): Register thpy_thread_handle.
4673
4674 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4675
4676         * gdbthread.h (thread_to_thread_handle): Declare.
4677         * thread.c (gdbtypes.h): Include.
4678         (thread_to_thread_handle): New function.
4679
4680         * target.h (struct target_ops): Add thread_info_to_thread_handle.
4681         (target_thread_info_to_thread_handle): Declare.
4682         * target.c (target_thread_info_to_thread_handle): New function.
4683         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
4684         * target-delegates.c: Regenerate.
4685
4686         * linux-thread-db.c (class thread_db_target): Add method
4687         thread_info_to_thread_handle.
4688         (thread_db_target::thread_info_to_thread_handle): Define.
4689         * remote.c (class remote_target): Add new method
4690         thread_info_to_thread_handle.
4691         (remote_target::thread_info_to_thread_handle): Define.
4692
4693 2019-04-08  Pedro Alves  <palves@redhat.com>
4694
4695         * common/common-exceptions.c (throw_exception): Don't create
4696         named object to throw; throw directly.
4697         (throw_it): Likewise.  Don't initialize gdb_exception::message
4698         here, with new; pass FMT and AP to the ctor instead.
4699         * common/common-exceptions.h: Include <string>.
4700         (gdb_exception::gdb_exception(enum return_reason, enum errors,
4701         const char *, va_list)): New ctor.  Use std::make_shared.
4702         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
4703         errors)): Delete.
4704         (gdb_exception_error::gdb_exception_error(enum errors, const char
4705         *, va_list)): New.
4706         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
4707         Add assertion.
4708         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
4709         errors)): Delete.
4710         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
4711         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
4712         Add assertion.
4713
4714 2019-04-08  Tom Tromey  <tom@tromey.com>
4715
4716         * valops.c (value_rtti_indirect_type): Replace throw_exception
4717         with throw.
4718         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
4719         with throw.
4720         * thread.c (thr_try_catch_cmd): Replace throw_exception with
4721         throw.
4722         * target.c (target_translate_tls_address): Replace throw_exception
4723         with throw.
4724         * stack.c (frame_apply_command_count): Replace throw_exception
4725         with throw.
4726         * solib-spu.c (append_ocl_sos): Replace throw_exception with
4727         throw.
4728         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
4729         with throw.
4730         * rs6000-tdep.c (rs6000_frame_cache)
4731         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
4732         * remote.c: Replace throw_exception with throw.
4733         * record-full.c (record_full_message, record_full_wait_1)
4734         (record_full_restore): Replace throw_exception with throw.
4735         * record-btrace.c:
4736         (get_thread_current_frame_id, record_btrace_start_replaying)
4737         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
4738         (cmd_record_btrace_start): Replace throw_exception with throw.
4739         * parse.c (parse_exp_in_context_1): Replace throw_exception with
4740         throw.
4741         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
4742         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
4743         * linespec.c:
4744         (find_linespec_symbols): Replace throw_exception with throw.
4745         * infrun.c (displaced_step_prepare, resume): Replace
4746         throw_exception with throw.
4747         * infcmd.c (post_create_inferior): Replace throw_exception with
4748         throw.
4749         * inf-loop.c (inferior_event_handler): Replace throw_exception
4750         with throw.
4751         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
4752         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
4753         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
4754         (get_prev_frame_always, get_frame_pc_if_available)
4755         (get_frame_address_in_block_if_available, get_frame_language):
4756         Replace throw_exception with throw.
4757         * frame-unwind.c (frame_unwind_try_unwinder): Replace
4758         throw_exception with throw.
4759         * eval.c (fetch_subexp_value, evaluate_var_value)
4760         (evaluate_funcall, evaluate_subexp_standard): Replace
4761         throw_exception with throw.
4762         * dwarf2loc.c (call_site_find_chain)
4763         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
4764         Replace throw_exception with throw.
4765         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
4766         with throw.
4767         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
4768         throw.
4769         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
4770         * completer.c (complete_line_internal): Replace throw_exception
4771         with throw.
4772         * compile/compile-object-run.c (compile_object_run): Replace
4773         throw_exception with throw.
4774         * cli/cli-script.c (process_next_line): Replace throw_exception
4775         with throw.
4776         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
4777         (btrace_enable, btrace_maint_update_pt_packets): Replace
4778         throw_exception with throw.
4779         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
4780         throw_exception with throw.
4781         * break-catch-throw.c (re_set_exception_catchpoint): Replace
4782         throw_exception with throw.
4783         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
4784         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
4785         * aarch64-tdep.c (aarch64_make_prologue_cache)
4786         (aarch64_make_stub_cache): Replace throw_exception with throw.
4787
4788 2019-04-08  Tom Tromey  <tom@tromey.com>
4789
4790         * common/common-exceptions.c (throw_exception): Rename from
4791         throw_exception_cxx.  Remove old copy.  Make argument const.
4792         (throw_it): Create and throw exception objects directly.
4793         * common/common-exceptions.h (throw_exception): Make argument
4794         const.
4795         (struct gdb_exception_error): Add constructor.
4796         (struct gdb_exception_quit): Add constructor.
4797
4798 2019-04-08  Tom Tromey  <tom@tromey.com>
4799
4800         * common/common-exceptions.h (exception_rethrow): Don't declare.
4801         (TRY_SJLJ): Update comment.
4802         (TRY, CATCH, END_CATCH): Remove.
4803         * common/common-exceptions.c (exception_rethrow): Remove.
4804
4805 2019-04-08  Tom Tromey  <tom@tromey.com>
4806
4807         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
4808         Remove.
4809         (gdb_exception_error): Rename from
4810         gdb_exception_RETURN_MASK_ERROR.
4811         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
4812         (gdb_quit_bad_alloc): Update.
4813         * aarch64-tdep.c: Update.
4814         * ada-lang.c: Update.
4815         * ada-typeprint.c: Update.
4816         * ada-valprint.c: Update.
4817         * amd64-tdep.c: Update.
4818         * arch-utils.c: Update.
4819         * break-catch-throw.c: Update.
4820         * breakpoint.c: Update.
4821         * btrace.c: Update.
4822         * c-varobj.c: Update.
4823         * cli/cli-cmds.c: Update.
4824         * cli/cli-interp.c: Update.
4825         * cli/cli-script.c: Update.
4826         * common/common-exceptions.c: Update.
4827         * common/new-op.c: Update.
4828         * common/selftest.c: Update.
4829         * compile/compile-c-symbols.c: Update.
4830         * compile/compile-cplus-symbols.c: Update.
4831         * compile/compile-object-load.c: Update.
4832         * compile/compile-object-run.c: Update.
4833         * completer.c: Update.
4834         * corelow.c: Update.
4835         * cp-abi.c: Update.
4836         * cp-support.c: Update.
4837         * cp-valprint.c: Update.
4838         * darwin-nat.c: Update.
4839         * disasm-selftests.c: Update.
4840         * dtrace-probe.c: Update.
4841         * dwarf-index-cache.c: Update.
4842         * dwarf-index-write.c: Update.
4843         * dwarf2-frame-tailcall.c: Update.
4844         * dwarf2-frame.c: Update.
4845         * dwarf2loc.c: Update.
4846         * dwarf2read.c: Update.
4847         * eval.c: Update.
4848         * event-loop.c: Update.
4849         * event-top.c: Update.
4850         * exec.c: Update.
4851         * f-valprint.c: Update.
4852         * fbsd-tdep.c: Update.
4853         * frame-unwind.c: Update.
4854         * frame.c: Update.
4855         * gdbtypes.c: Update.
4856         * gnu-v3-abi.c: Update.
4857         * guile/guile-internal.h: Update.
4858         * guile/scm-block.c: Update.
4859         * guile/scm-breakpoint.c: Update.
4860         * guile/scm-cmd.c: Update.
4861         * guile/scm-disasm.c: Update.
4862         * guile/scm-frame.c: Update.
4863         * guile/scm-lazy-string.c: Update.
4864         * guile/scm-math.c: Update.
4865         * guile/scm-param.c: Update.
4866         * guile/scm-ports.c: Update.
4867         * guile/scm-pretty-print.c: Update.
4868         * guile/scm-symbol.c: Update.
4869         * guile/scm-symtab.c: Update.
4870         * guile/scm-type.c: Update.
4871         * guile/scm-value.c: Update.
4872         * i386-linux-tdep.c: Update.
4873         * i386-tdep.c: Update.
4874         * inf-loop.c: Update.
4875         * infcall.c: Update.
4876         * infcmd.c: Update.
4877         * infrun.c: Update.
4878         * jit.c: Update.
4879         * language.c: Update.
4880         * linespec.c: Update.
4881         * linux-fork.c: Update.
4882         * linux-nat.c: Update.
4883         * linux-tdep.c: Update.
4884         * linux-thread-db.c: Update.
4885         * main.c: Update.
4886         * mi/mi-cmd-break.c: Update.
4887         * mi/mi-cmd-stack.c: Update.
4888         * mi/mi-interp.c: Update.
4889         * mi/mi-main.c: Update.
4890         * objc-lang.c: Update.
4891         * p-valprint.c: Update.
4892         * parse.c: Update.
4893         * ppc-linux-tdep.c: Update.
4894         * printcmd.c: Update.
4895         * python/py-arch.c: Update.
4896         * python/py-breakpoint.c: Update.
4897         * python/py-cmd.c: Update.
4898         * python/py-finishbreakpoint.c: Update.
4899         * python/py-frame.c: Update.
4900         * python/py-framefilter.c: Update.
4901         * python/py-gdb-readline.c: Update.
4902         * python/py-inferior.c: Update.
4903         * python/py-infthread.c: Update.
4904         * python/py-lazy-string.c: Update.
4905         * python/py-linetable.c: Update.
4906         * python/py-objfile.c: Update.
4907         * python/py-param.c: Update.
4908         * python/py-prettyprint.c: Update.
4909         * python/py-progspace.c: Update.
4910         * python/py-record-btrace.c: Update.
4911         * python/py-record.c: Update.
4912         * python/py-symbol.c: Update.
4913         * python/py-type.c: Update.
4914         * python/py-unwind.c: Update.
4915         * python/py-utils.c: Update.
4916         * python/py-value.c: Update.
4917         * python/python.c: Update.
4918         * record-btrace.c: Update.
4919         * record-full.c: Update.
4920         * remote-fileio.c: Update.
4921         * remote.c: Update.
4922         * riscv-tdep.c: Update.
4923         * rs6000-aix-tdep.c: Update.
4924         * rs6000-tdep.c: Update.
4925         * rust-exp.y: Update.
4926         * rust-lang.c: Update.
4927         * s390-tdep.c: Update.
4928         * selftest-arch.c: Update.
4929         * solib-dsbt.c: Update.
4930         * solib-frv.c: Update.
4931         * solib-spu.c: Update.
4932         * solib-svr4.c: Update.
4933         * solib.c: Update.
4934         * sparc64-linux-tdep.c: Update.
4935         * stack.c: Update.
4936         * symfile-mem.c: Update.
4937         * symmisc.c: Update.
4938         * target.c: Update.
4939         * thread.c: Update.
4940         * top.c: Update.
4941         * tracefile-tfile.c: Update.
4942         * tui/tui.c: Update.
4943         * typeprint.c: Update.
4944         * unittests/cli-utils-selftests.c: Update.
4945         * unittests/parse-connection-spec-selftests.c: Update.
4946         * valops.c: Update.
4947         * valprint.c: Update.
4948         * value.c: Update.
4949         * varobj.c: Update.
4950         * windows-nat.c: Update.
4951         * x86-linux-nat.c: Update.
4952         * xml-support.c: Update.
4953
4954 2019-04-08  Tom Tromey  <tom@tromey.com>
4955
4956         * xml-support.c: Use C++ exception handling.
4957         * x86-linux-nat.c: Use C++ exception handling.
4958         * windows-nat.c: Use C++ exception handling.
4959         * varobj.c: Use C++ exception handling.
4960         * value.c: Use C++ exception handling.
4961         * valprint.c: Use C++ exception handling.
4962         * valops.c: Use C++ exception handling.
4963         * unittests/parse-connection-spec-selftests.c: Use C++ exception
4964         handling.
4965         * unittests/cli-utils-selftests.c: Use C++ exception handling.
4966         * typeprint.c: Use C++ exception handling.
4967         * tui/tui.c: Use C++ exception handling.
4968         * tracefile-tfile.c: Use C++ exception handling.
4969         * top.c: Use C++ exception handling.
4970         * thread.c: Use C++ exception handling.
4971         * target.c: Use C++ exception handling.
4972         * symmisc.c: Use C++ exception handling.
4973         * symfile-mem.c: Use C++ exception handling.
4974         * stack.c: Use C++ exception handling.
4975         * sparc64-linux-tdep.c: Use C++ exception handling.
4976         * solib.c: Use C++ exception handling.
4977         * solib-svr4.c: Use C++ exception handling.
4978         * solib-spu.c: Use C++ exception handling.
4979         * solib-frv.c: Use C++ exception handling.
4980         * solib-dsbt.c: Use C++ exception handling.
4981         * selftest-arch.c: Use C++ exception handling.
4982         * s390-tdep.c: Use C++ exception handling.
4983         * rust-lang.c: Use C++ exception handling.
4984         * rust-exp.y: Use C++ exception handling.
4985         * rs6000-tdep.c: Use C++ exception handling.
4986         * rs6000-aix-tdep.c: Use C++ exception handling.
4987         * riscv-tdep.c: Use C++ exception handling.
4988         * remote.c: Use C++ exception handling.
4989         * remote-fileio.c: Use C++ exception handling.
4990         * record-full.c: Use C++ exception handling.
4991         * record-btrace.c: Use C++ exception handling.
4992         * python/python.c: Use C++ exception handling.
4993         * python/py-value.c: Use C++ exception handling.
4994         * python/py-utils.c: Use C++ exception handling.
4995         * python/py-unwind.c: Use C++ exception handling.
4996         * python/py-type.c: Use C++ exception handling.
4997         * python/py-symbol.c: Use C++ exception handling.
4998         * python/py-record.c: Use C++ exception handling.
4999         * python/py-record-btrace.c: Use C++ exception handling.
5000         * python/py-progspace.c: Use C++ exception handling.
5001         * python/py-prettyprint.c: Use C++ exception handling.
5002         * python/py-param.c: Use C++ exception handling.
5003         * python/py-objfile.c: Use C++ exception handling.
5004         * python/py-linetable.c: Use C++ exception handling.
5005         * python/py-lazy-string.c: Use C++ exception handling.
5006         * python/py-infthread.c: Use C++ exception handling.
5007         * python/py-inferior.c: Use C++ exception handling.
5008         * python/py-gdb-readline.c: Use C++ exception handling.
5009         * python/py-framefilter.c: Use C++ exception handling.
5010         * python/py-frame.c: Use C++ exception handling.
5011         * python/py-finishbreakpoint.c: Use C++ exception handling.
5012         * python/py-cmd.c: Use C++ exception handling.
5013         * python/py-breakpoint.c: Use C++ exception handling.
5014         * python/py-arch.c: Use C++ exception handling.
5015         * printcmd.c: Use C++ exception handling.
5016         * ppc-linux-tdep.c: Use C++ exception handling.
5017         * parse.c: Use C++ exception handling.
5018         * p-valprint.c: Use C++ exception handling.
5019         * objc-lang.c: Use C++ exception handling.
5020         * mi/mi-main.c: Use C++ exception handling.
5021         * mi/mi-interp.c: Use C++ exception handling.
5022         * mi/mi-cmd-stack.c: Use C++ exception handling.
5023         * mi/mi-cmd-break.c: Use C++ exception handling.
5024         * main.c: Use C++ exception handling.
5025         * linux-thread-db.c: Use C++ exception handling.
5026         * linux-tdep.c: Use C++ exception handling.
5027         * linux-nat.c: Use C++ exception handling.
5028         * linux-fork.c: Use C++ exception handling.
5029         * linespec.c: Use C++ exception handling.
5030         * language.c: Use C++ exception handling.
5031         * jit.c: Use C++ exception handling.
5032         * infrun.c: Use C++ exception handling.
5033         * infcmd.c: Use C++ exception handling.
5034         * infcall.c: Use C++ exception handling.
5035         * inf-loop.c: Use C++ exception handling.
5036         * i386-tdep.c: Use C++ exception handling.
5037         * i386-linux-tdep.c: Use C++ exception handling.
5038         * guile/scm-value.c: Use C++ exception handling.
5039         * guile/scm-type.c: Use C++ exception handling.
5040         * guile/scm-symtab.c: Use C++ exception handling.
5041         * guile/scm-symbol.c: Use C++ exception handling.
5042         * guile/scm-pretty-print.c: Use C++ exception handling.
5043         * guile/scm-ports.c: Use C++ exception handling.
5044         * guile/scm-param.c: Use C++ exception handling.
5045         * guile/scm-math.c: Use C++ exception handling.
5046         * guile/scm-lazy-string.c: Use C++ exception handling.
5047         * guile/scm-frame.c: Use C++ exception handling.
5048         * guile/scm-disasm.c: Use C++ exception handling.
5049         * guile/scm-cmd.c: Use C++ exception handling.
5050         * guile/scm-breakpoint.c: Use C++ exception handling.
5051         * guile/scm-block.c: Use C++ exception handling.
5052         * guile/guile-internal.h: Use C++ exception handling.
5053         * gnu-v3-abi.c: Use C++ exception handling.
5054         * gdbtypes.c: Use C++ exception handling.
5055         * frame.c: Use C++ exception handling.
5056         * frame-unwind.c: Use C++ exception handling.
5057         * fbsd-tdep.c: Use C++ exception handling.
5058         * f-valprint.c: Use C++ exception handling.
5059         * exec.c: Use C++ exception handling.
5060         * event-top.c: Use C++ exception handling.
5061         * event-loop.c: Use C++ exception handling.
5062         * eval.c: Use C++ exception handling.
5063         * dwarf2read.c: Use C++ exception handling.
5064         * dwarf2loc.c: Use C++ exception handling.
5065         * dwarf2-frame.c: Use C++ exception handling.
5066         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5067         * dwarf-index-write.c: Use C++ exception handling.
5068         * dwarf-index-cache.c: Use C++ exception handling.
5069         * dtrace-probe.c: Use C++ exception handling.
5070         * disasm-selftests.c: Use C++ exception handling.
5071         * darwin-nat.c: Use C++ exception handling.
5072         * cp-valprint.c: Use C++ exception handling.
5073         * cp-support.c: Use C++ exception handling.
5074         * cp-abi.c: Use C++ exception handling.
5075         * corelow.c: Use C++ exception handling.
5076         * completer.c: Use C++ exception handling.
5077         * compile/compile-object-run.c: Use C++ exception handling.
5078         * compile/compile-object-load.c: Use C++ exception handling.
5079         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5080         * compile/compile-c-symbols.c: Use C++ exception handling.
5081         * common/selftest.c: Use C++ exception handling.
5082         * common/new-op.c: Use C++ exception handling.
5083         * cli/cli-script.c: Use C++ exception handling.
5084         * cli/cli-interp.c: Use C++ exception handling.
5085         * cli/cli-cmds.c: Use C++ exception handling.
5086         * c-varobj.c: Use C++ exception handling.
5087         * btrace.c: Use C++ exception handling.
5088         * breakpoint.c: Use C++ exception handling.
5089         * break-catch-throw.c: Use C++ exception handling.
5090         * arch-utils.c: Use C++ exception handling.
5091         * amd64-tdep.c: Use C++ exception handling.
5092         * ada-valprint.c: Use C++ exception handling.
5093         * ada-typeprint.c: Use C++ exception handling.
5094         * ada-lang.c: Use C++ exception handling.
5095         * aarch64-tdep.c: Use C++ exception handling.
5096
5097 2019-04-08  Tom Tromey  <tom@tromey.com>
5098
5099         * xml-support.c (gdb_xml_parser::parse): Update.
5100         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5101         * value.c (show_convenience): Update.
5102         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5103         (test_parse_flags_qcs): Update.
5104         * thread.c (thr_try_catch_cmd): Update.
5105         * target.c (target_translate_tls_address): Update.
5106         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5107         (info_frame_command_core, frame_apply_command_count): Update.
5108         * rust-exp.y (rust_lex_exception_test): Update.
5109         * riscv-tdep.c (riscv_print_one_register_info): Update.
5110         * remote.c (remote_target::enable_btrace): Update.
5111         * record-btrace.c (record_btrace_enable_warn): Update.
5112         * python/py-utils.c (gdbpy_convert_exception): Update.
5113         * printcmd.c (do_one_display, print_variable_and_value): Update.
5114         * mi/mi-main.c (mi_print_exception): Update.
5115         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5116         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5117         * linux-nat.c (linux_nat_target::attach): Update.
5118         * linux-fork.c (class scoped_switch_fork_info): Update.
5119         * infrun.c (displaced_step_prepare): Update.
5120         * infcall.c (call_function_by_hand_dummy): Update.
5121         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5122         * gnu-v3-abi.c (print_one_vtable): Update.
5123         * frame.c (get_prev_frame_always): Update.
5124         * f-valprint.c (info_common_command_for_block): Update.
5125         * exec.c (try_open_exec_file): Update.
5126         * exceptions.c (print_exception, exception_print)
5127         (exception_fprintf, exception_print_same): Update.
5128         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5129         * dwarf-index-cache.c (index_cache::store)
5130         (index_cache::lookup_gdb_index): Update.
5131         * darwin-nat.c (maybe_cache_shell): Update.
5132         * cp-valprint.c (cp_print_value_fields): Update.
5133         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5134         (gcc_cplus_symbol_address): Update.
5135         * compile/compile-c-symbols.c (gcc_convert_symbol)
5136         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5137         * common/selftest.c: Update.
5138         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5139         a std::string.
5140         (exception_try_scope_entry, exception_try_scope_exit): Don't
5141         declare.
5142         (struct exception_try_scope): Remove.
5143         (TRY): Don't use exception_try_scope.
5144         (struct gdb_exception): Add constructor, operator=.
5145         <what>: New method.
5146         (struct gdb_exception_RETURN_MASK_ALL)
5147         (struct gdb_exception_RETURN_MASK_ERROR)
5148         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5149         (struct gdb_quit_bad_alloc): Update.
5150         * common/common-exceptions.c (exception_none): Change
5151         initializer.
5152         (struct catcher) <state, exception>: Initialize inline.
5153         <prev>: Remove member.
5154         (current_catcher): Remove.
5155         (catchers): New global.
5156         (exceptions_state_mc_init): Simplify.
5157         (catcher_pop): Remove.
5158         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5159         (try_scope_depth, exception_try_scope_entry)
5160         (exception_try_scope_exit): Remove.
5161         (throw_exception_sjlj): Update.
5162         (exception_messages, exception_messages_size): Remove.
5163         (throw_it): Simplify.
5164         (gdb_exception_sliced_copy): Remove.
5165         (throw_exception_cxx): Update.
5166         * cli/cli-script.c (script_from_file): Update.
5167         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5168         Update.
5169         * ada-valprint.c (ada_val_print): Update.
5170         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5171         (create_excep_cond_exprs): Update.
5172
5173 2019-04-08  Tom Tromey  <tom@tromey.com>
5174
5175         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5176         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5177         (TRY, CATCH, END_CATCH): Remove some definitions.
5178         * common/common-exceptions.c: Don't use GDB_XCPT.
5179         (catcher_list_size): Remove.
5180         (throw_exception, throw_it): Simplify.
5181
5182 2019-04-05  Tom Tromey  <tom@tromey.com>
5183
5184         Revert the header-sorting patch.
5185         * ft32-tdep.c: Revert.
5186         * frv-tdep.c: Revert.
5187         * frv-linux-tdep.c: Revert.
5188         * frame.c: Revert.
5189         * frame-unwind.c: Revert.
5190         * frame-base.c: Revert.
5191         * fork-child.c: Revert.
5192         * findvar.c: Revert.
5193         * findcmd.c: Revert.
5194         * filesystem.c: Revert.
5195         * filename-seen-cache.h: Revert.
5196         * filename-seen-cache.c: Revert.
5197         * fbsd-tdep.c: Revert.
5198         * fbsd-nat.h: Revert.
5199         * fbsd-nat.c: Revert.
5200         * f-valprint.c: Revert.
5201         * f-typeprint.c: Revert.
5202         * f-lang.c: Revert.
5203         * extension.h: Revert.
5204         * extension.c: Revert.
5205         * extension-priv.h: Revert.
5206         * expprint.c: Revert.
5207         * exec.h: Revert.
5208         * exec.c: Revert.
5209         * exceptions.c: Revert.
5210         * event-top.c: Revert.
5211         * event-loop.c: Revert.
5212         * eval.c: Revert.
5213         * elfread.c: Revert.
5214         * dwarf2read.h: Revert.
5215         * dwarf2read.c: Revert.
5216         * dwarf2loc.c: Revert.
5217         * dwarf2expr.h: Revert.
5218         * dwarf2expr.c: Revert.
5219         * dwarf2-frame.c: Revert.
5220         * dwarf2-frame-tailcall.c: Revert.
5221         * dwarf-index-write.h: Revert.
5222         * dwarf-index-write.c: Revert.
5223         * dwarf-index-common.c: Revert.
5224         * dwarf-index-cache.h: Revert.
5225         * dwarf-index-cache.c: Revert.
5226         * dummy-frame.c: Revert.
5227         * dtrace-probe.c: Revert.
5228         * disasm.h: Revert.
5229         * disasm.c: Revert.
5230         * disasm-selftests.c: Revert.
5231         * dictionary.c: Revert.
5232         * dicos-tdep.c: Revert.
5233         * demangle.c: Revert.
5234         * dcache.h: Revert.
5235         * dcache.c: Revert.
5236         * darwin-nat.h: Revert.
5237         * darwin-nat.c: Revert.
5238         * darwin-nat-info.c: Revert.
5239         * d-valprint.c: Revert.
5240         * d-namespace.c: Revert.
5241         * d-lang.c: Revert.
5242         * ctf.c: Revert.
5243         * csky-tdep.c: Revert.
5244         * csky-linux-tdep.c: Revert.
5245         * cris-tdep.c: Revert.
5246         * cris-linux-tdep.c: Revert.
5247         * cp-valprint.c: Revert.
5248         * cp-support.c: Revert.
5249         * cp-namespace.c: Revert.
5250         * cp-abi.c: Revert.
5251         * corelow.c: Revert.
5252         * corefile.c: Revert.
5253         * continuations.c: Revert.
5254         * completer.h: Revert.
5255         * completer.c: Revert.
5256         * complaints.c: Revert.
5257         * coffread.c: Revert.
5258         * coff-pe-read.c: Revert.
5259         * cli-out.h: Revert.
5260         * cli-out.c: Revert.
5261         * charset.c: Revert.
5262         * c-varobj.c: Revert.
5263         * c-valprint.c: Revert.
5264         * c-typeprint.c: Revert.
5265         * c-lang.c: Revert.
5266         * buildsym.c: Revert.
5267         * buildsym-legacy.c: Revert.
5268         * build-id.h: Revert.
5269         * build-id.c: Revert.
5270         * btrace.c: Revert.
5271         * bsd-uthread.c: Revert.
5272         * breakpoint.h: Revert.
5273         * breakpoint.c: Revert.
5274         * break-catch-throw.c: Revert.
5275         * break-catch-syscall.c: Revert.
5276         * break-catch-sig.c: Revert.
5277         * blockframe.c: Revert.
5278         * block.c: Revert.
5279         * bfin-tdep.c: Revert.
5280         * bfin-linux-tdep.c: Revert.
5281         * bfd-target.c: Revert.
5282         * bcache.c: Revert.
5283         * ax-general.c: Revert.
5284         * ax-gdb.h: Revert.
5285         * ax-gdb.c: Revert.
5286         * avr-tdep.c: Revert.
5287         * auxv.c: Revert.
5288         * auto-load.c: Revert.
5289         * arm-wince-tdep.c: Revert.
5290         * arm-tdep.c: Revert.
5291         * arm-symbian-tdep.c: Revert.
5292         * arm-pikeos-tdep.c: Revert.
5293         * arm-obsd-tdep.c: Revert.
5294         * arm-nbsd-tdep.c: Revert.
5295         * arm-nbsd-nat.c: Revert.
5296         * arm-linux-tdep.c: Revert.
5297         * arm-linux-nat.c: Revert.
5298         * arm-fbsd-tdep.c: Revert.
5299         * arm-fbsd-nat.c: Revert.
5300         * arm-bsd-tdep.c: Revert.
5301         * arch-utils.c: Revert.
5302         * arc-tdep.c: Revert.
5303         * arc-newlib-tdep.c: Revert.
5304         * annotate.h: Revert.
5305         * annotate.c: Revert.
5306         * amd64-windows-tdep.c: Revert.
5307         * amd64-windows-nat.c: Revert.
5308         * amd64-tdep.c: Revert.
5309         * amd64-sol2-tdep.c: Revert.
5310         * amd64-obsd-tdep.c: Revert.
5311         * amd64-obsd-nat.c: Revert.
5312         * amd64-nbsd-tdep.c: Revert.
5313         * amd64-nbsd-nat.c: Revert.
5314         * amd64-nat.c: Revert.
5315         * amd64-linux-tdep.c: Revert.
5316         * amd64-linux-nat.c: Revert.
5317         * amd64-fbsd-tdep.c: Revert.
5318         * amd64-fbsd-nat.c: Revert.
5319         * amd64-dicos-tdep.c: Revert.
5320         * amd64-darwin-tdep.c: Revert.
5321         * amd64-bsd-nat.c: Revert.
5322         * alpha-tdep.c: Revert.
5323         * alpha-obsd-tdep.c: Revert.
5324         * alpha-nbsd-tdep.c: Revert.
5325         * alpha-mdebug-tdep.c: Revert.
5326         * alpha-linux-tdep.c: Revert.
5327         * alpha-linux-nat.c: Revert.
5328         * alpha-bsd-tdep.c: Revert.
5329         * alpha-bsd-nat.c: Revert.
5330         * aix-thread.c: Revert.
5331         * agent.c: Revert.
5332         * addrmap.c: Revert.
5333         * ada-varobj.c: Revert.
5334         * ada-valprint.c: Revert.
5335         * ada-typeprint.c: Revert.
5336         * ada-tasks.c: Revert.
5337         * ada-lang.c: Revert.
5338         * aarch64-tdep.c: Revert.
5339         * aarch64-ravenscar-thread.c: Revert.
5340         * aarch64-newlib-tdep.c: Revert.
5341         * aarch64-linux-tdep.c: Revert.
5342         * aarch64-linux-nat.c: Revert.
5343         * aarch64-fbsd-tdep.c: Revert.
5344         * aarch64-fbsd-nat.c: Revert.
5345         * aarch32-linux-nat.c: Revert.
5346
5347 2019-04-05  Tom Tromey  <tom@tromey.com>
5348
5349         * ft32-tdep.c: Sort headers.
5350         * frv-tdep.c: Sort headers.
5351         * frv-linux-tdep.c: Sort headers.
5352         * frame.c: Sort headers.
5353         * frame-unwind.c: Sort headers.
5354         * frame-base.c: Sort headers.
5355         * fork-child.c: Sort headers.
5356         * findvar.c: Sort headers.
5357         * findcmd.c: Sort headers.
5358         * filesystem.c: Sort headers.
5359         * filename-seen-cache.h: Sort headers.
5360         * filename-seen-cache.c: Sort headers.
5361         * fbsd-tdep.c: Sort headers.
5362         * fbsd-nat.h: Sort headers.
5363         * fbsd-nat.c: Sort headers.
5364         * f-valprint.c: Sort headers.
5365         * f-typeprint.c: Sort headers.
5366         * f-lang.c: Sort headers.
5367         * extension.h: Sort headers.
5368         * extension.c: Sort headers.
5369         * extension-priv.h: Sort headers.
5370         * expprint.c: Sort headers.
5371         * exec.h: Sort headers.
5372         * exec.c: Sort headers.
5373         * exceptions.c: Sort headers.
5374         * event-top.c: Sort headers.
5375         * event-loop.c: Sort headers.
5376         * eval.c: Sort headers.
5377         * elfread.c: Sort headers.
5378         * dwarf2read.h: Sort headers.
5379         * dwarf2read.c: Sort headers.
5380         * dwarf2loc.c: Sort headers.
5381         * dwarf2expr.h: Sort headers.
5382         * dwarf2expr.c: Sort headers.
5383         * dwarf2-frame.c: Sort headers.
5384         * dwarf2-frame-tailcall.c: Sort headers.
5385         * dwarf-index-write.h: Sort headers.
5386         * dwarf-index-write.c: Sort headers.
5387         * dwarf-index-common.c: Sort headers.
5388         * dwarf-index-cache.h: Sort headers.
5389         * dwarf-index-cache.c: Sort headers.
5390         * dummy-frame.c: Sort headers.
5391         * dtrace-probe.c: Sort headers.
5392         * disasm.h: Sort headers.
5393         * disasm.c: Sort headers.
5394         * disasm-selftests.c: Sort headers.
5395         * dictionary.c: Sort headers.
5396         * dicos-tdep.c: Sort headers.
5397         * demangle.c: Sort headers.
5398         * dcache.h: Sort headers.
5399         * dcache.c: Sort headers.
5400         * darwin-nat.h: Sort headers.
5401         * darwin-nat.c: Sort headers.
5402         * darwin-nat-info.c: Sort headers.
5403         * d-valprint.c: Sort headers.
5404         * d-namespace.c: Sort headers.
5405         * d-lang.c: Sort headers.
5406         * ctf.c: Sort headers.
5407         * csky-tdep.c: Sort headers.
5408         * csky-linux-tdep.c: Sort headers.
5409         * cris-tdep.c: Sort headers.
5410         * cris-linux-tdep.c: Sort headers.
5411         * cp-valprint.c: Sort headers.
5412         * cp-support.c: Sort headers.
5413         * cp-namespace.c: Sort headers.
5414         * cp-abi.c: Sort headers.
5415         * corelow.c: Sort headers.
5416         * corefile.c: Sort headers.
5417         * continuations.c: Sort headers.
5418         * completer.h: Sort headers.
5419         * completer.c: Sort headers.
5420         * complaints.c: Sort headers.
5421         * coffread.c: Sort headers.
5422         * coff-pe-read.c: Sort headers.
5423         * cli-out.h: Sort headers.
5424         * cli-out.c: Sort headers.
5425         * charset.c: Sort headers.
5426         * c-varobj.c: Sort headers.
5427         * c-valprint.c: Sort headers.
5428         * c-typeprint.c: Sort headers.
5429         * c-lang.c: Sort headers.
5430         * buildsym.c: Sort headers.
5431         * buildsym-legacy.c: Sort headers.
5432         * build-id.h: Sort headers.
5433         * build-id.c: Sort headers.
5434         * btrace.c: Sort headers.
5435         * bsd-uthread.c: Sort headers.
5436         * breakpoint.h: Sort headers.
5437         * breakpoint.c: Sort headers.
5438         * break-catch-throw.c: Sort headers.
5439         * break-catch-syscall.c: Sort headers.
5440         * break-catch-sig.c: Sort headers.
5441         * blockframe.c: Sort headers.
5442         * block.c: Sort headers.
5443         * bfin-tdep.c: Sort headers.
5444         * bfin-linux-tdep.c: Sort headers.
5445         * bfd-target.c: Sort headers.
5446         * bcache.c: Sort headers.
5447         * ax-general.c: Sort headers.
5448         * ax-gdb.h: Sort headers.
5449         * ax-gdb.c: Sort headers.
5450         * avr-tdep.c: Sort headers.
5451         * auxv.c: Sort headers.
5452         * auto-load.c: Sort headers.
5453         * arm-wince-tdep.c: Sort headers.
5454         * arm-tdep.c: Sort headers.
5455         * arm-symbian-tdep.c: Sort headers.
5456         * arm-pikeos-tdep.c: Sort headers.
5457         * arm-obsd-tdep.c: Sort headers.
5458         * arm-nbsd-tdep.c: Sort headers.
5459         * arm-nbsd-nat.c: Sort headers.
5460         * arm-linux-tdep.c: Sort headers.
5461         * arm-linux-nat.c: Sort headers.
5462         * arm-fbsd-tdep.c: Sort headers.
5463         * arm-fbsd-nat.c: Sort headers.
5464         * arm-bsd-tdep.c: Sort headers.
5465         * arch-utils.c: Sort headers.
5466         * arc-tdep.c: Sort headers.
5467         * arc-newlib-tdep.c: Sort headers.
5468         * annotate.h: Sort headers.
5469         * annotate.c: Sort headers.
5470         * amd64-windows-tdep.c: Sort headers.
5471         * amd64-windows-nat.c: Sort headers.
5472         * amd64-tdep.c: Sort headers.
5473         * amd64-sol2-tdep.c: Sort headers.
5474         * amd64-obsd-tdep.c: Sort headers.
5475         * amd64-obsd-nat.c: Sort headers.
5476         * amd64-nbsd-tdep.c: Sort headers.
5477         * amd64-nbsd-nat.c: Sort headers.
5478         * amd64-nat.c: Sort headers.
5479         * amd64-linux-tdep.c: Sort headers.
5480         * amd64-linux-nat.c: Sort headers.
5481         * amd64-fbsd-tdep.c: Sort headers.
5482         * amd64-fbsd-nat.c: Sort headers.
5483         * amd64-dicos-tdep.c: Sort headers.
5484         * amd64-darwin-tdep.c: Sort headers.
5485         * amd64-bsd-nat.c: Sort headers.
5486         * alpha-tdep.c: Sort headers.
5487         * alpha-obsd-tdep.c: Sort headers.
5488         * alpha-nbsd-tdep.c: Sort headers.
5489         * alpha-mdebug-tdep.c: Sort headers.
5490         * alpha-linux-tdep.c: Sort headers.
5491         * alpha-linux-nat.c: Sort headers.
5492         * alpha-bsd-tdep.c: Sort headers.
5493         * alpha-bsd-nat.c: Sort headers.
5494         * aix-thread.c: Sort headers.
5495         * agent.c: Sort headers.
5496         * addrmap.c: Sort headers.
5497         * ada-varobj.c: Sort headers.
5498         * ada-valprint.c: Sort headers.
5499         * ada-typeprint.c: Sort headers.
5500         * ada-tasks.c: Sort headers.
5501         * ada-lang.c: Sort headers.
5502         * aarch64-tdep.c: Sort headers.
5503         * aarch64-ravenscar-thread.c: Sort headers.
5504         * aarch64-newlib-tdep.c: Sort headers.
5505         * aarch64-linux-tdep.c: Sort headers.
5506         * aarch64-linux-nat.c: Sort headers.
5507         * aarch64-fbsd-tdep.c: Sort headers.
5508         * aarch64-fbsd-nat.c: Sort headers.
5509         * aarch32-linux-nat.c: Sort headers.
5510
5511 2019-04-04  Tom Tromey  <tom@tromey.com>
5512
5513         * varobj.c (varobj_create): Update.
5514         * rust-exp.y (struct rust_parser) <update_innermost_block,
5515         lookup_symbol>: New methods.
5516         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5517         Rename.
5518         (rust_parser::rust_lookup_type)
5519         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5520         * printcmd.c (display_command, do_one_display): Update.
5521         * parser-defs.h (struct parser_state) <parser_state>: Add
5522         "tracker" parameter.
5523         (block_tracker): New member.
5524         (class innermost_block_tracker) <innermost_block_tracker>: Add
5525         "types" parameter.
5526         <reset>: Remove method.
5527         (innermost_block): Don't declare.
5528         (null_post_parser): Update.
5529         * parse.c (innermost_block): Remove global.
5530         (write_dollar_variable): Update.
5531         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5532         Remove "tracker_types" parameter.
5533         (parse_expression): Add "tracker" parameter.
5534         (parse_expression_for_completion): Update.
5535         (null_post_parser): Add "tracker" parameter.
5536         * p-exp.y: Update rules.
5537         * m2-exp.y: Update rules.
5538         * language.h (struct language_defn) <la_post_parser>: Add
5539         "tracker" parameter.
5540         * go-exp.y: Update rules.
5541         * f-exp.y: Update rules.
5542         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5543         parameter.
5544         * d-exp.y: Update rules.
5545         * c-exp.y: Update rules.
5546         * breakpoint.c (set_breakpoint_condition): Create an
5547         innermost_block_tracker.
5548         (watch_command_1): Likewise.
5549         * ada-lang.c (resolve): Add "tracker" parameter.
5550         (resolve_subexp): Likewise.
5551         * ada-exp.y (write_var_from_sym): Update.
5552
5553 2019-04-04  Tom Tromey  <tom@tromey.com>
5554
5555         * type-stack.h: New file.
5556         * type-stack.c: New file.
5557         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5558         type-stack.h.
5559         (insert_into_type_stack, insert_type, push_type, push_type_int)
5560         (insert_type_address_space, pop_type, pop_type_int)
5561         (pop_typelist, pop_type_stack, append_type_stack)
5562         (push_type_stack, get_type_stack, push_typelist)
5563         (follow_type_instance_flags, follow_types): Don't declare.
5564         * parse.c (type_stack): Remove global.
5565         (parse_exp_in_context): Update.
5566         (insert_into_type_stack, insert_type, push_type, push_type_int)
5567         (insert_type_address_space, pop_type, pop_type_int)
5568         (pop_typelist, pop_type_stack, append_type_stack)
5569         (push_type_stack, get_type_stack, push_typelist)
5570         (follow_type_instance_flags, follow_types): Remove (moved to
5571         type-stack.c).
5572         * f-exp.y (type_stack): New global.
5573         Update rules.
5574         (push_kind_type, f_parse): Update.
5575         * d-exp.y (type_stack): New global.
5576         Update rules.
5577         (d_parse): Update.
5578         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5579         Update rules.
5580         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5581         (HFILES_NO_SRCDIR): Add type-stack.h.
5582
5583 2019-04-04  Tom Tromey  <tom@tromey.com>
5584
5585         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5586         (rust_parser::convert_ast_to_expression, rust_parse)
5587         (rust_lex_test_completion, rust_lex_tests): Update.
5588         * parser-defs.h (struct expr_completion_state): New.
5589         (struct parser_state) <parser_state>: Add completion parameter.
5590         <mark_struct_expression, mark_completion_tag>: New methods.
5591         <parse_completion, m_completion_state>: New members.
5592         (prefixify_expression, null_post_parser): Update.
5593         (mark_struct_expression, mark_completion_tag): Don't declare.
5594         * parse.c (parse_completion, expout_last_struct)
5595         (expout_tag_completion_type, expout_completion_name): Remove
5596         globals.
5597         (parser_state::mark_struct_expression)
5598         (parser_state::mark_completion_tag): Now methods.
5599         (prefixify_expression): Add last_struct parameter.
5600         (prefixify_subexp): Likewise.
5601         (parse_exp_1): Update.
5602         (parse_exp_in_context): Add cstate parameter.  Update.
5603         (parse_expression_for_completion): Create an
5604         expr_completion_state.
5605         (null_post_parser): Add "completion" parameter.
5606         * p-exp.y: Update rules.
5607         (yylex): Update.
5608         * language.h (struct language_defn) <la_post_parser>: Add
5609         "completing" parameter.
5610         * go-exp.y: Update rules.
5611         (lex_one_token): Update.
5612         * expression.h (parse_completion): Don't declare.
5613         * d-exp.y: Update rules.
5614         (lex_one_token): Update rules.
5615         * c-exp.y: Update rules.
5616         (lex_one_token): Update.
5617         * ada-lang.c (resolve): Add "parse_completion" parameter.
5618         (resolve_subexp): Likewise.
5619         (ada_resolve_function): Likewise.
5620
5621 2019-04-04  Tom Tromey  <tom@tromey.com>
5622
5623         * parser-defs.h (struct parser_state) <start_arglist,
5624         end_arglist>: New methods.
5625         <arglist_len, m_funcall_chain>: New members.
5626         (arglist_len, start_arglist, end_arglist): Don't declare.
5627         * parse.c (arglist_len, funcall_chain): Remove global.
5628         (start_arglist, end_arglist): Remove functions.
5629         (parse_exp_in_context): Update.
5630         * p-exp.y: Update rules.
5631         * m2-exp.y: Update rules.
5632         * go-exp.y: Update rules.
5633         * f-exp.y: Update rules.
5634         * d-exp.y: Update rules.
5635         * c-exp.y: Update rules.
5636
5637 2019-04-04  Tom Tromey  <tom@tromey.com>
5638
5639         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
5640         lex_operator, push_back>: New methods.
5641         Update all rules.
5642         (rust_parser::lex_hex, lex_escape): Rename and update.
5643         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
5644         (rust_parser::lex_operator): Rename and update.
5645         (rust_parser::lex_number, rustyylex, rustyyerror)
5646         (rust_lex_test_init, rust_lex_test_sequence)
5647         (rust_lex_test_push_back, rust_lex_tests): Update.
5648         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
5649         parameter.
5650         <lexptr, prev_lexptr>: New members.
5651         (lexptr, prev_lexptr): Don't declare.
5652         * parse.c (lexptr, prev_lexptr): Remove globals.
5653         (parse_exp_in_context): Update.
5654         * p-exp.y (yylex, yyerror): Update.
5655         * m2-exp.y (parse_number, yylex, yyerror): Update.
5656         * go-exp.y (lex_one_token, yyerror): Update.
5657         * f-exp.y (match_string_literal, yylex, yyerror): Update.
5658         * d-exp.y (lex_one_token, yyerror): Update.
5659         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
5660         (lex_one_token, yyerror): Update.
5661         * ada-lex.l (YY_INPUT): Update.
5662         (rewind_to_char): Update.
5663         * ada-exp.y (yyerror): Update.
5664
5665 2019-04-04  Tom Tromey  <tom@tromey.com>
5666
5667         * rust-exp.y (rustyylex, rust_lex_tests): Update.
5668         * parser-defs.h (struct parser_state) <parser_state>: Add new
5669         parameter.
5670         <comma_terminates>: New member.
5671         (comma_terminates): Don't declare global.
5672         * parse.c (comma_terminates): Remove global.
5673         (parse_exp_in_context): Update.
5674         * p-exp.y (yylex): Update.
5675         * m2-exp.y (yylex): Update.
5676         * go-exp.y (lex_one_token): Update.
5677         * f-exp.y (yylex): Update.
5678         * d-exp.y (lex_one_token): Update.
5679         * c-exp.y (lex_one_token): Update.
5680         * ada-lex.l: Update.
5681
5682 2019-04-04  Tom Tromey  <tom@tromey.com>
5683
5684         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
5685         (rustyylex, rust_lex_test_init, rust_lex_test_one)
5686         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
5687         * parser-defs.h (paren_depth): Don't declare.
5688         * parse.c (paren_depth): Remove global.
5689         (parse_exp_in_context): Update.
5690         * p-exp.y (paren_depth): New global.
5691         (pascal_parse): Initialize it.
5692         * m2-exp.y (paren_depth): New global.
5693         (m2_parse): Initialize it.
5694         * go-exp.y (paren_depth): New global.
5695         (go_parse): Initialize it.
5696         * f-exp.y (paren_depth): New global.
5697         (f_parse): Initialize it.
5698         * d-exp.y (paren_depth): New global.
5699         (d_parse): Initialize it.
5700         * c-exp.y (paren_depth): New global.
5701         (c_parse): Initialize it.
5702         * ada-lex.l (paren_depth): New global.
5703         (lexer_init): Initialize it.
5704
5705 2019-04-04  Tom Tromey  <tom@tromey.com>
5706
5707         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
5708         (rust_parser::convert_ast_to_type)
5709         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5710         * parser-defs.h (struct parser_state) <parser_state>: Add
5711         parameters.  Initialize new members.
5712         <expression_context_block, expression_context_pc>: New members.
5713         * parse.c (expression_context_block, expression_context_pc):
5714         Remove globals.
5715         (parse_exp_in_context): Update.
5716         * p-exp.y: Update all rules.
5717         (yylex): Update.
5718         * m2-exp.y: Update all rules.
5719         (yylex): Update.
5720         * go-exp.y (yylex): Update.
5721         * f-exp.y (yylex): Update.
5722         * d-exp.y: Update all rules.
5723         (yylex): Update.
5724         * c-exp.y: Update all rules.
5725         (lex_one_token, classify_name, yylex, c_parse): Update.
5726         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
5727
5728 2019-04-04  Tom Tromey  <tom@tromey.com>
5729
5730         * gdbarch.h, gdbarch.c: Rebuild.
5731         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
5732         * stap-probe.h:
5733         (struct stap_parse_info): Replace "parser_state" with
5734         "expr_builder".
5735         * parser-defs.h (struct expr_builder): Rename from "parser_state".
5736         (parser_state): New class.
5737         * parse.c (expr_builder): Rename.
5738         (expr_builder::release): Rename.
5739         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
5740         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
5741         (write_exp_elt_longcst, write_exp_elt_floatcst)
5742         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
5743         (write_exp_string_vector, write_exp_bitstring)
5744         (write_exp_msymbol, mark_struct_expression)
5745         (write_dollar_variable)
5746         (insert_type_address_space, increase_expout_size): Replace
5747         "parser_state" with "expr_builder".
5748         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
5749         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
5750         "parser_state" with "expr_builder".
5751
5752 2019-04-04  Tom Tromey  <tom@tromey.com>
5753
5754         * rust-exp.y: Replace "parse_language" with method call.
5755         * p-exp.y:
5756         (yylex): Replace "parse_language" with method call.
5757         * m2-exp.y:
5758         (yylex): Replace "parse_language" with method call.
5759         * go-exp.y (classify_name): Replace "parse_language" with method
5760         call.
5761         * f-exp.y (yylex): Replace "parse_language" with method call.
5762         * d-exp.y (lex_one_token): Replace "parse_language" with method
5763         call.
5764         * c-exp.y:
5765         (lex_one_token, classify_name, yylex): Replace "parse_language"
5766         with method call.
5767         * ada-exp.y (find_primitive_type, type_char)
5768         (type_system_address): Replace "parse_language" with method call.
5769
5770 2019-04-04  Tom Tromey  <tom@tromey.com>
5771
5772         * rust-exp.y: Replace "parse_gdbarch" with method call.
5773         * parse.c (write_dollar_variable, insert_type_address_space):
5774         Replace "parse_gdbarch" with method call.
5775         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
5776         call.
5777         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
5778         call.
5779         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
5780         "parse_gdbarch" with method call.
5781         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
5782         with method call.
5783         * f-exp.y (parse_type, parse_f_type, yylex): Replace
5784         "parse_gdbarch" with method call.
5785         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
5786         "parse_gdbarch" with method call.
5787         * c-exp.y (parse_type, parse_number, classify_name): Replace
5788         "parse_gdbarch" with method call.
5789         * ada-lex.l: Replace "parse_gdbarch" with method call.
5790         * ada-exp.y (parse_type, find_primitive_type, type_char)
5791         (type_system_address): Replace "parse_gdbarch" with method call.
5792
5793 2019-04-04  Tom Tromey  <tom@tromey.com>
5794
5795         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
5796         * stap-probe.c (stap_parse_argument): Update.
5797         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
5798         initial_size parameter.
5799         * rust-exp.y (rust_lex_tests): Update.
5800         * parse.c (parser_state): Update.
5801         (parse_exp_in_context): Update.
5802         * parser-defs.h (struct parser_state) <parser_state>: Remove
5803         "initial_size" parameter.
5804
5805 2019-04-04  Tom Tromey  <tom@tromey.com>
5806
5807         * parser-defs.h (increase_expout_size): Don't declare.
5808         * parse.c (increase_expout_size): Now static.
5809
5810 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
5811
5812         * gnu-nat.c (gnu_nat_target::wait): Fix
5813         target_waitstatus_to_string call.
5814
5815 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5816
5817         * eval.c (evaluate_subexp_standard): Handle internal functions
5818         during Fortran function call handling.
5819
5820 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5821
5822         * NEWS: Mention new internal functions.
5823         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
5824         (read_base_type): Use dwarf2_init_complex_target_type.
5825         * value.c (creal_internal_fn): New function.
5826         (cimag_internal_fn): New function.
5827         (_initialize_values): Register new internal functions.
5828
5829 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5830
5831         * infrun.c (stop_all_threads): If debug_infrun, always
5832         trace the wait status after wait_one, using
5833         target_waitstatus_to_string and target_pid_to_str.
5834         (handle_inferior_event): Replace various trace of
5835         wait status kind by a single trace.
5836         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
5837         wait status kind image by target_waitstatus_to_string.
5838         * target/waitstatus.c (target_waitstatus_to_string): Fix
5839         obsolete comment.
5840
5841 2019-04-01  Tom Tromey  <tromey@adacore.com>
5842
5843         PR symtab/23331:
5844         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
5845
5846 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5847             Pedro Alves  <palves@redhat.com>
5848
5849         * top.c (quit_force): Call 'finalize_values'.
5850         * value.c (finalize_values): New function.
5851         * value.h (finalize_values): Declare.
5852
5853 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
5854
5855         * NEWS: Announce $_gdb_major and $_gdb_minor.
5856
5857         * top.c (init_gdb_version_vars): New function.
5858         (gdb_init): Call init_gdb_version_vars.
5859
5860 2019-03-29  Tom Tromey  <tromey@adacore.com>
5861
5862         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
5863         help text.  Remove dead code.
5864
5865 2019-03-29  Keith Seitz  <keiths@redhat.com>
5866
5867         From Siddhesh Poyarekar:
5868         * f-lang.h (f77_get_upperbound): Return LONGEST.
5869         (f77_get_lowerbound): Likewise.
5870         * f-typeprint.c (f_type_print_varspec_suffix): Expand
5871         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
5872         print them.
5873         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
5874         plongest to format print it.
5875         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
5876         (f77_get_upperbound): Likewise.
5877         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
5878         LOWER_BOUND to LONGEST.
5879         (f77_create_arrayprint_offset_tbl): Likewise.
5880
5881 2019-03-29  Keith Seitz  <keiths@redhat.com>
5882
5883         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
5884         %s/pulongest for TYPE_LENGTH instead of %d in format
5885         strings.
5886         * ada-typerint.c (ada_print_type): Likewise.
5887         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
5888         * compile/compile-c-support.c (generate_register_struct): Likewise.
5889         * gdbtypes.c (recursive_dump_type): Likewise.
5890         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
5891         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
5892         instead of %d in format strings.
5893         * riscv-tdep.c (riscv_type_alignment): Cast second argument
5894         to std::min to ULONGEST.
5895         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
5896         instead of %d in format strings.
5897         * tracepoint.c (info_scope_command): Likewise.
5898         * typeprint.c (print_offset_data::update)
5899         (print_offset_data::finish): Likewise.
5900         * xtensa-tdep.c (xtensa_store_return_value)
5901         (xtensa_push_dummy_call): Likewise.
5902
5903 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
5904
5905         * windows-nat.c (display_selector): Fixed format specifications
5906         for 64-bit Cygwin.
5907
5908 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5909
5910         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
5911
5912 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
5913
5914         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
5915         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
5916         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
5917         (nios2_linux_init_abi): Install it.
5918
5919 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5920
5921         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
5922
5923 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5924
5925         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
5926
5927 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5928             Tom Tromey  <tromey@adacore.com>
5929
5930         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
5931
5932 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
5933
5934         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
5935         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
5936         method to compute the bounds of range types. Also print "[evaluated]"
5937         if the bounds' values come from a dynamic evaluation.
5938
5939 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5940
5941         * cp-valprint.c (cp_print_value_fields): Don't print trailing
5942         whitespace when pretty printing is on.
5943
5944 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5945
5946         * ppc-linux-nat.c: Add include.
5947
5948 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5949
5950         * NEWS: Mention AArch64 Pointer Authentication.
5951
5952 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5953
5954         * arm-linux-nat.c: Add include.
5955
5956 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
5957
5958         * source-cache.c (source_cache::get_source_lines): Re-read
5959         fullname after calling open_source_file.
5960
5961 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
5962
5963         * NEWS: Mention TLS support for FreeBSD.
5964
5965 2019-03-25  Tom Tromey  <tromey@adacore.com>
5966
5967         * minsyms.c (BUNCH_SIZE): Update comment.
5968         (~minimal_symbol_reader): Remove old comment.
5969         (compact_minimal_symbols): Update comment.
5970         (minimal_symbol_reader::install): Remove old comment.  Update
5971         other comments.
5972
5973 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5974
5975         * s390-linux-nat.c: Add include.
5976
5977 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5978
5979         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5980         Call linux_get_hwcap.
5981         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
5982         Likewise.
5983         (aarch64_linux_get_hwcap): Remove function.
5984         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
5985         declaration.
5986         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
5987         linux_get_hwcap.
5988         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5989         * linux-tdep.c (linux_get_hwcap): Add function.
5990         (linux_get_hwcap2): Likewise.
5991         * linux-tdep.h (linux_get_hwcap): Add declaration.
5992         (linux_get_hwcap2): Likewise.
5993         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
5994         (ppc_linux_get_hwcap2): Likewise.
5995         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
5996         linux_get_hwcap.
5997         (ppc_linux_nat_target::insert_watchpoint): Likewise.
5998         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
5999         (ppc_linux_nat_target::read_description): Likewise.
6000         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6001         * s390-linux-nat.c: Likewise.
6002         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6003
6004 2019-03-24  Tom Tromey  <tom@tromey.com>
6005
6006         * ada-lang.c (standard_lookup): Simplify initialization.
6007         (ada_lookup_symbol_nonlocal): Simplify return.
6008         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6009         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6010         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6011         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6012         initialization.
6013         * solib.c (solib_global_lookup): Simplify.
6014         * symtab.c (null_block_symbol): Remove.
6015         (symbol_cache_lookup): Simplify returns.
6016         (lookup_language_this): Simplify returns.
6017         (lookup_symbol_aux): Simplify return.
6018         (lookup_local_symbol): Simplify returns.
6019         (lookup_global_symbol_from_objfile): Simplify return.
6020         (lookup_symbol_in_objfile_symtabs)
6021         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6022         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6023         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6024         * cp-namespace.c (cp_lookup_bare_symbol)
6025         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6026         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6027         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6028         (cp_lookup_symbol_via_imports): Simplify initialization.
6029         (find_symbol_in_baseclass): Likewise.
6030         * symtab.h (null_block_symbol): Remove.
6031         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6032         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6033         (d_lookup_symbol_module): Likewise.
6034         (find_symbol_in_baseclass): Simplify initialization.
6035
6036 2019-03-24  Tom Tromey  <tom@tromey.com>
6037
6038         * expression.h: Don't include symtab.h.
6039         (struct block): Forward declare.
6040
6041 2019-03-24  Tom Tromey  <tom@tromey.com>
6042
6043         * c-exp.y (typebase): Remove casts.
6044         * gdbtypes.c (lookup_unsigned_typename, )
6045         (lookup_signed_typename): Remove cast.
6046         * eval.c (parse_to_comma_and_eval): Remove cast.
6047         * parse.c (write_dollar_variable): Remove cast.
6048         * block.h (struct block) <superblock>: Now const.
6049         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6050         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6051         (map_block): Make "block" const.
6052         * symfile.h (struct quick_symbol_functions)
6053         <map_matching_symbols>: Constify block argument to "callback".
6054         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6055         const.
6056         (find_pc_sect_compunit_symtab): Make "b" const.
6057         (find_symbol_at_address): Likewise.
6058         (search_symbols): Likewise.
6059         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6060         (dw2_debug_names_lookup_symbol): Likewise.
6061         (dw2_map_matching_symbols): Update.
6062         * p-valprint.c (pascal_val_print): Remove "block".
6063         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6064         (aux_add_nonlocal_symbols): Make "block" const.
6065         (resolve_subexp): Remove cast.
6066         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6067         const.
6068         (iterate_over_file_blocks): Likewise.
6069         * f-exp.y (%union) <bval>: Remove.
6070         * coffread.c (patch_opaque_types): Make "b" const.
6071         * spu-tdep.c (spu_catch_start): Make "block" const.
6072         * c-valprint.c (print_unpacked_pointer): Remove "block".
6073         * symmisc.c (dump_symtab_1): Make "b" const.
6074         (block_depth): Make "block" const.
6075         * d-exp.y (%union) <bval>: Remove.
6076         * cp-support.h (cp_lookup_rtti_type): Update.
6077         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6078         * psymtab.c (psym_lookup_symbol): Make "block" const.
6079         (maintenance_check_psymtabs): Make "b" const.
6080         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6081         (enumerate_locals, enumerate_args): Update.
6082         * python/py-symtab.c (stpy_global_block): Make "block" const.
6083         (stpy_static_block): Likewise.
6084         * inline-frame.c (block_starting_point_at): Make "new_block"
6085         const.
6086         * block.c (find_block_in_blockvector): Make return type const.
6087         (blockvector_for_pc_sect): Make "b" const.
6088         (find_block_in_blockvector): Make "b" const.
6089
6090 2019-03-23  Tom Tromey  <tom@tromey.com>
6091
6092         * varobj.c (varobj_create): Update.
6093         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6094         * printcmd.c (display_command, do_one_display): Don't reset
6095         innermost_block.
6096         * parser-defs.h (enum innermost_block_tracker_type): Move to
6097         expression.h.
6098         (innermost_block): Update comment.
6099         * parse.c (parse_exp_1): Add tracker_types parameter.
6100         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6101         tracker_types parameter.  Reset innermost_block.
6102         (parse_exp_in_context): Remove.
6103         (parse_expression_for_completion): Update.
6104         * objfiles.c (~objfile): Don't reset expression_context_block or
6105         innermost_block.
6106         * expression.h (enum innermost_block_tracker_type): Move from
6107         parser-defs.h.
6108         (parse_exp_1): Add tracker_types parameter.
6109         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6110         reset innermost_block.
6111
6112 2019-03-23  Tom Tromey  <tom@tromey.com>
6113
6114         * objfiles.h: Include bcache.h.
6115
6116 2019-03-23  Tom Tromey  <tom@tromey.com>
6117
6118         * linespec.c (get_current_search_block): Use
6119         scoped_restore_current_language.
6120         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6121
6122 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6123             Jiong Wang  <jiong.wang@arm.com>
6124
6125         * aarch64-linux-tdep.c
6126         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6127         section.
6128         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6129
6130 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6131             Jiong Wang  <jiong.wang@arm.com>
6132
6133         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6134         instructions.
6135         (aarch64_analyze_prologue_test): Add PACIASP test.
6136         (aarch64_prologue_prev_register): Unmask PC value.
6137
6138 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6139             Jiong Wang  <jiong.wang@arm.com>
6140
6141         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6142         (aarch64_dwarf2_prev_register): Unmask PC value.
6143         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6144         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6145         DW_CFA_AARCH64_negate_ra_state.
6146         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6147
6148 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6149             Jiong Wang  <jiong.wang@arm.com>
6150
6151         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6152         registers.
6153         (aarch64_pseudo_register_name): Likewise.
6154         (aarch64_pseudo_register_type): Likewise.
6155         (aarch64_pseudo_register_reggroup_p): Likewise.
6156         (aarch64_gdbarch_init): Add pauth registers.
6157         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6158         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6159         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6160         (struct gdbarch_tdep): Add regnum for ra_state.
6161
6162 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6163             Jiong Wang  <jiong.wang@arm.com>
6164
6165         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6166
6167 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6168             Jiong Wang  <jiong.wang@arm.com>
6169
6170         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6171         function.
6172         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6173         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6174         (aarch64_gdbarch_init): Add puth registers.
6175         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6176         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6177         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6178
6179 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6180             Jiong Wang  <jiong.wang@arm.com>
6181
6182         * aarch64-linux-nat.c
6183         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6184         * aarch64-linux-tdep.c
6185         (aarch64_linux_core_read_description): Likewise.
6186         (aarch64_linux_get_hwcap): New function.
6187         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6188         (aarch64_linux_get_hwcap): New declaration.
6189
6190 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6191             Jiong Wang  <jiong.wang@arm.com>
6192
6193         * aarch64-linux-nat.c
6194         (aarch64_linux_nat_target::read_description): Add pauth param.
6195         * aarch64-linux-tdep.c
6196         (aarch64_linux_core_read_description): Likewise.
6197         * aarch64-tdep.c (struct target_desc): Add in pauth.
6198         (aarch64_read_description): Add pauth param.
6199         (aarch64_gdbarch_init): Likewise.
6200         * aarch64-tdep.h (aarch64_read_description): Likewise.
6201         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6202         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6203         * features/Makefile: Add new files.
6204         * features/aarch64-pauth.c: New file.
6205         * features/aarch64-pauth.xml: New file.
6206
6207 2019-03-20  Tom Tromey  <tromey@adacore.com>
6208
6209         * infrun.c (handle_inferior_event): Rename from
6210         handle_inferior_event_1.  Create a scoped_value_mark.
6211         (handle_inferior_event): Remove.
6212
6213 2019-03-19  Tom Tromey  <tromey@adacore.com>
6214
6215         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6216         * infrun.h (print_stop_event): Add "displays" parameter.
6217         * infrun.c (print_stop_event): Add "displays" parameter.
6218
6219 2019-03-19  Pedro Alves  <palves@redhat.com>
6220
6221         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6222         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6223         to -1.  Fix TABs vs spaces.
6224         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6225         * tui/tui-out.h (tui_ui_out) Add intro comments.
6226         <m_line, m_start_of_line>: In-class initialize, and add describing
6227         comment.
6228
6229 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6230
6231         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6232         variable names.
6233         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6234
6235 2019-03-18  Pedro Alves  <palves@redhat.com>
6236             Eli Zaretskii <eliz@gnu.org>
6237
6238         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6239         m_line and m_start_of_line.
6240
6241 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6242
6243         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6244         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6245         it returns a newline.  This fixes a regression in TU mode, whereby
6246         the next line is output on the same screen line as the user input.
6247
6248 2019-03-18  Tom Tromey  <tromey@adacore.com>
6249
6250         * minsyms.c (minimal_symbol_reader::install): Remove call to
6251         obstack_blank.
6252
6253 2019-03-18  Pedro Alves  <palves@redhat.com>
6254
6255         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6256         New globals.
6257         (apply_style): New, factored out from ...
6258         (apply_ansi_escape): ... this.  Handle reverse video mode.
6259         (tui_set_reverse_mode): New function.
6260         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6261         * tui/tui-winsource.c (tui_show_source_line): Use
6262         tui_set_reverse_mode instead of setting A_STANDOUT.
6263         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6264         New setter methods.
6265
6266 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6267
6268         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6269         Handle tabs.
6270
6271 2019-03-18  Tom Tromey  <tromey@adacore.com>
6272
6273         * ada-lang.c (empty_array): Add "high" parameter.
6274         (ada_evaluate_subexp): Update.
6275
6276 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6277
6278         * unittests/string_view-selftests.c: Define
6279         _initialize_string_view_selftests unconditionally.
6280
6281 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6282
6283         PR gdb/24350
6284         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6285
6286 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6287
6288         PR gdb/24351
6289         * windows-nat.c (display_selector): Fix format specifiers.
6290
6291 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6292
6293         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6294         tui_refill_source_window instead of tui_refresh_win, to update the
6295         current execution line.  This fixes redisplay of the current line
6296         when stepping through the code with "next" or "step".
6297
6298 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6299
6300         * source-cache.c (source_cache::get_source_lines): Call
6301         find_source_lines to initialize s->nlines.  This fixes vertical
6302         scrolling of TUI source window when the DOWN arrow is pressed.
6303
6304 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6305
6306         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6307         linux-thread-db.c (_initialize_thread_db): Likewise.
6308
6309 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6310
6311         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6312         wclrtoeol in tui_show_source_line".  This reverts changes made in
6313         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6314
6315 2019-03-15  Tom Tromey  <tom@tromey.com>
6316
6317         * symtab.h (struct minimal_symbol): Derive from
6318         general_symbol_info.
6319         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6320         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6321         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6322         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6323         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6324         (MSYMBOL_SEARCH_NAME): Update.
6325         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6326         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6327         * minsyms.c (minimal_symbol_reader::record_full): Update.
6328
6329 2019-03-15  Tom Tromey  <tom@tromey.com>
6330
6331         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6332
6333 2019-03-15  Tom Tromey  <tom@tromey.com>
6334
6335         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6336         unique_xmalloc_ptr.
6337         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6338         Update.
6339         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6340         (build_minimal_symbol_hash_tables)
6341         (minimal_symbol_reader::install): Update.
6342
6343 2019-03-15  Tom Tromey  <tom@tromey.com>
6344
6345         * symtab.c (create_demangled_names_hash): Update.
6346         (symbol_set_names): Update.
6347         * objfiles.h (struct objfile_per_bfd_storage)
6348         <demangled_names_hash>: Now an htab_up.
6349         * objfiles.c (objfile_per_bfd_storage): Simplify.
6350
6351 2019-03-15  Tom Tromey  <tom@tromey.com>
6352
6353         * objfiles.h (struct objfile_per_bfd_storage): Declare
6354         destructor.
6355         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6356         New.
6357         (get_objfile_bfd_data): Use new.  Don't initialize
6358         language_of_main.
6359         (free_objfile_per_bfd_storage): Remove.
6360         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6361
6362 2019-03-15  Tom Tromey  <tom@tromey.com>
6363
6364         * symfile.c (reread_symbols): Update.
6365         * objfiles.c (objfile::objfile): Update.
6366         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6367         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6368         comment.
6369         (minimal_symbol_reader::install): Update.
6370         (terminate_minimal_symbol_table): Remove.
6371         * jit.c (jit_object_close_impl): Update.
6372
6373 2019-03-15  Tom Tromey  <tom@tromey.com>
6374
6375         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6376         initializations.
6377
6378 2019-03-15  Tom Tromey  <tom@tromey.com>
6379
6380         * objfiles.h (struct objfile_per_bfd_storage)
6381         <demangled_hash_languages>: Now a bitset.
6382         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6383         (lookup_minimal_symbol): Update.
6384
6385 2019-03-15  Tom Tromey  <tom@tromey.com>
6386
6387         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6388         Don't return the symbol.
6389         * coffread.c (record_minimal_symbol): Use record_full.
6390
6391 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6392
6393         The MS-Windows port of ncurses fails to switch to a color pair if
6394         one or both of the colors are the implicit default colors.  This
6395         change records the default colors when TUI is initialized, and
6396         then specifies them explicitly when a color pair uses the default
6397         colors.  This allows color styling in TUI mode on MS-Windows.
6398
6399         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6400         ncurses_norm_attr.
6401         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6402         colors in ncurses_norm_attr.
6403         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6404         "none", replace it with the default color recorded in
6405         ncurses_norm_attr.
6406
6407 2019-03-14  Tom Tromey  <tromey@adacore.com>
6408
6409         * source-cache.h (class source_cache) <get_source_lines>: Return
6410         std::string.
6411         * source-cache.c (source_cache::extract_lines): Handle case where
6412         first_pos==npos.  Return std::string.
6413         (source_cache::get_source_lines): Update.
6414
6415 2019-03-14  Tom Tromey  <tromey@adacore.com>
6416
6417         * NEWS: Add item for "style sources" commands.
6418         * source-cache.c (source_cache::get_source_lines): Check
6419         source_styling.
6420         * cli/cli-style.c (source_styling): New global.
6421         (_initialize_cli_style): Add "style sources" commands.
6422         (show_style_sources): New function.
6423         * cli/cli-style.h (source_styling): Declare.
6424
6425 2019-03-14  Pedro Alves  <palves@redhat.com>
6426             Tom Tromey  <tromey@adacore.com>
6427
6428         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6429         * tui/tui-winsource.c (tui_refill_source_window): New function,
6430         from...
6431         (tui_horizontal_source_scroll): ... here.  Move some logic.
6432         * cli/cli-style.c (set_style_enabled): Notify new observable.
6433         * tui/tui-hooks.c (tui_redisplay_source): New function.
6434         (tui_attach_detach_observers): Attach or detach
6435         tui_redisplay_source.
6436         * observable.h (source_styling_changed): New observable.
6437         * observable.c: Define source_styling_changed observable.
6438
6439 2019-03-13  Tom Tromey  <tromey@adacore.com>
6440
6441         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6442         (i386_gnu_nat_target::store_registers): Update.
6443         * target-debug.h (target_debug_print_std_string): New macro.
6444         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6445         * windows-tdep.c (display_one_tib): Update.
6446         * tui/tui-stack.c (tui_make_status_line): Update.
6447         * top.c (print_inferior_quit_action): Update.
6448         * thread.c (thr_try_catch_cmd): Update.
6449         (add_thread_with_info): Update.
6450         (thread_target_id_str): Update.
6451         (thr_try_catch_cmd): Update.
6452         (thread_command): Update.
6453         (thread_find_command): Update.
6454         * record-btrace.c (record_btrace_target::info_record)
6455         (record_btrace_resume_thread, record_btrace_target::resume)
6456         (record_btrace_cancel_resume, record_btrace_step_thread)
6457         (record_btrace_target::wait, record_btrace_target::wait)
6458         (record_btrace_target::wait, record_btrace_target::stop): Update.
6459         * progspace.c (print_program_space): Update.
6460         * process-stratum-target.c
6461         (process_stratum_target::thread_address_space): Update.
6462         * linux-fork.c (linux_fork_mourn_inferior)
6463         (detach_checkpoint_command, info_checkpoints_command)
6464         (linux_fork_context): Update.
6465         (linux_fork_detach): Update.
6466         (class scoped_switch_fork_info): Update.
6467         (delete_checkpoint_command): Update.
6468         * infrun.c (follow_fork_inferior): Update.
6469         (follow_fork_inferior): Update.
6470         (proceed_after_vfork_done): Update.
6471         (handle_vfork_child_exec_or_exit): Update.
6472         (follow_exec): Update.
6473         (displaced_step_prepare_throw): Update.
6474         (displaced_step_restore): Update.
6475         (start_step_over): Update.
6476         (resume_1): Update.
6477         (clear_proceed_status_thread): Update.
6478         (proceed): Update.
6479         (print_target_wait_results): Update.
6480         (do_target_wait): Update.
6481         (context_switch): Update.
6482         (stop_all_threads): Update.
6483         (restart_threads): Update.
6484         (finish_step_over): Update.
6485         (handle_signal_stop): Update.
6486         (switch_back_to_stepped_thread): Update.
6487         (keep_going_pass_signal): Update.
6488         (print_exited_reason): Update.
6489         (normal_stop): Update.
6490         * inferior.c (inferior_pid_to_str): Change return type.
6491         (print_selected_inferior): Update.
6492         (add_inferior): Update.
6493         (detach_inferior): Update.
6494         * dummy-frame.c (fprint_dummy_frames): Update.
6495         * dcache.c (dcache_info_1): Update.
6496         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6497         (btrace_fetch, btrace_clear): Update.
6498         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6499         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6500         type.
6501         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6502         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6503         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6504         * gdbarch.c, gdbarch.h: Rebuild.
6505         * gdbarch.sh (core_pid_to_str): Change return type.
6506         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6507         return type.
6508         (windows_nat_target::pid_to_str): Change return type.
6509         (windows_delete_thread): Update.
6510         (windows_nat_target::attach): Update.
6511         (windows_nat_target::files_info): Update.
6512         * target-delegates.c: Rebuild.
6513         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6514         return type.
6515         (sol_thread_target::pid_to_str): Change return type.
6516         * remote.c (class remote_target) <pid_to_str>: Change return
6517         type.
6518         (remote_target::pid_to_str): Change return type.
6519         (extended_remote_target::attach, remote_target::remote_stop_ns)
6520         (remote_target::remote_notif_remove_queued_reply)
6521         (remote_target::push_stop_reply, remote_target::disable_btrace):
6522         Update.
6523         (extended_remote_target::attach): Update.
6524         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6525         type.
6526         (gdbsim_target::pid_to_str): Change return type.
6527         * ravenscar-thread.c (struct ravenscar_thread_target)
6528         <pid_to_str>: Change return type.
6529         (ravenscar_thread_target::pid_to_str): Change return type.
6530         * procfs.c (class procfs_target) <pid_to_str>: Change return
6531         type.
6532         (procfs_target::pid_to_str): Change return type.
6533         (procfs_target::attach): Update.
6534         (procfs_target::detach): Update.
6535         (procfs_target::fetch_registers): Update.
6536         (procfs_target::store_registers): Update.
6537         (procfs_target::wait): Update.
6538         (procfs_target::files_info): Update.
6539         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6540         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6541         return type.
6542         (nto_procfs_target::pid_to_str): Change return type.
6543         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6544         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6545         return type.
6546         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6547         (exit_lwp): Update.
6548         (attach_proc_task_lwp_callback, get_detach_signal)
6549         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6550         (linux_nat_target::resume, wait_lwp, stop_callback)
6551         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6552         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6553         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6554         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6555         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6556         type.
6557         (inf_ptrace_target::attach): Update.
6558         (inf_ptrace_target::files_info): Update.
6559         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6560         type.
6561         (go32_nat_target::pid_to_str): Change return type.
6562         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6563         (gnu_nat_target::wait): Update.
6564         (gnu_nat_target::wait): Update.
6565         (gnu_nat_target::resume): Update.
6566         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6567         (fbsd_nat_target::wait): Update.
6568         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6569         type.
6570         (darwin_nat_target::attach): Update.
6571         * corelow.c (class core_target) <pid_to_str>: Change return type.
6572         (core_target::pid_to_str): Change return type.
6573         * target.c (normal_pid_to_str): Change return type.
6574         (default_pid_to_str): Likewise.
6575         (target_pid_to_str): Change return type.
6576         (target_translate_tls_address): Update.
6577         (target_announce_detach): Update.
6578         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6579         return type.
6580         (bsd_uthread_target::pid_to_str): Change return type.
6581         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6582         type.
6583         (bsd_kvm_target::pid_to_str): Change return type.
6584         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6585         return type.
6586         (aix_thread_target::pid_to_str): Change return type.
6587         * target.h (struct target_ops) <pid_to_str>: Change return type.
6588         (target_pid_to_str, normal_pid_to_str): Likewise.
6589         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6590         type.
6591         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6592         type.
6593         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6594         return type.
6595         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6596         type.
6597         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6598         type.
6599         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6600         return type.
6601
6602 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6603
6604         * NEWS: Mention that the new default MI version is 3.  Mention
6605         changes to the output of commands and events that deal with
6606         multi-location breakpoints.
6607         * breakpoint.c: Include "mi/mi-out.h".
6608         (print_one_breakpoint): Change output syntax if using MI version
6609         >= 3.
6610         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6611         New.
6612         (mi_multi_location_breakpoint_output_fixed): New.
6613         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6614         (mi_cmd_fix_multi_location_breakpoint_output): New.
6615         (mi_multi_location_breakpoint_output_fixed): New.
6616         * mi/mi-cmds.c (mi_cmds): Register command
6617         -fix-multi-location-breakpoint-output.
6618         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6619         interpreter "mi".
6620
6621 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6622
6623         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6624         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6625         instantiate mi_ui_out based on interpreter name.
6626         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6627         * mi/mi-main.c (mi_load_progress): Likewise.
6628
6629 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6630
6631         * NEWS: Combine separate "New targets" sections for 8.3.
6632
6633 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6634
6635         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6636         (ppcfbsd_init_abi): Install gdbarch
6637         "fetch_tls_load_module_address" and "get_thread_local_address"
6638         methods.
6639
6640 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6641
6642         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
6643         (riscv_fbsd_init_abi): Install gdbarch
6644         "fetch_tls_load_module_address" and "get_thread_local_address"
6645         methods.
6646
6647 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6648
6649         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
6650         (i386fbsd_init_abi): Install gdbarch
6651         "fetch_tls_load_module_address" and "get_thread_local_address"
6652         methods.
6653
6654 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6655
6656         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
6657         (amd64fbsd_init_abi): Install gdbarch
6658         "fetch_tls_load_module_address" and "get_thread_local_address"
6659         methods.
6660
6661 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6662
6663         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
6664         (struct fbsd_pspace_data): New type.
6665         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
6666         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
6667         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
6668         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
6669         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
6670
6671 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6672
6673         * gdbtypes.c (lookup_struct_elt): New function.
6674         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
6675         * gdbtypes.h (struct struct_elt): New type.
6676         (lookup_struct_elt): New prototype.
6677
6678 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6679
6680         * gdbtypes.c (lookup_struct_elt_type): Update comment and
6681         remove disabled code block.
6682
6683 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6684
6685         * gdbarch.sh (get_thread_local_address): New method.
6686         * gdbarch.h, gdbarch.c: Regenerate.
6687         * target.c (target_translate_tls_address): Use
6688         gdbarch_get_thread_local_address if present instead of
6689         target::get_thread_local_address.
6690
6691 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6692
6693         * target.h (target::get_thread_local_address): Update comment.
6694
6695 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6696
6697         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
6698         objfile->separate_debug_objfile_backlink if not NULL.
6699
6700 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6701
6702         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6703         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
6704         (amd64bsd_store_inferior_registers): Likewise.
6705         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6706         Enable segment base registers.
6707         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
6708         PT_GETFSBASE and PT_GETGSBASE.
6709         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
6710         PT_SETGSBASE.
6711         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
6712         segment base registers.
6713         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6714
6715 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6716
6717         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6718         Update calls to i386_target_description to add 'segments'
6719         parameter.
6720         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
6721         add segment base registers.
6722         * arch/i386.c (i386_create_target_description): Add 'segments'
6723         parameter to enable segment base registers.
6724         * arch/i386.h (i386_create_target_description): Likewise.
6725         * features/i386/32bit-segments.xml: New file.
6726         * features/i386/32bit-segments.c: Generate.
6727         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
6728         call to i386_target_description to add 'segments' parameter.
6729         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6730         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
6731         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
6732         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
6733         if feature is present.
6734         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
6735         Add 'segments' parameter to call to i386_target_description.
6736         (i386_target_description): Add 'segments' parameter to enable
6737         segment base registers.
6738         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
6739         to call to i386_target_description.
6740         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
6741         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
6742         Define I386_NUM_REGS.
6743         (i386_target_description): Add 'segments' parameter to enable
6744         segment base registers.
6745
6746 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
6747
6748         PR/24325
6749         * source-cache.c: #undef open and close, to avoid unresolved
6750         externals during linking.
6751
6752 2019-03-12  Tom Tromey  <tromey@adacore.com>
6753
6754         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
6755         const.  Add initializers.
6756         (_initialize_remote): Don't initialize ptid globals.
6757
6758 2019-03-12  Pedro Alves  <palves@redhat.com>
6759
6760         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
6761
6762 2019-03-12  Pedro Alves  <palves@redhat.com>
6763
6764         * cp-name-parser.y (main): Remove unused 'len' variable.
6765
6766 2019-03-12  Tom Tromey  <tromey@adacore.com>
6767
6768         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
6769         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
6770
6771 2019-03-12  Tom Tromey  <tromey@adacore.com>
6772
6773         * linux-nat.c (iterate_over_lwps): Update.
6774         (stop_callback): Remove parameter.
6775         (stop_wait_callback, detach_callback, resume_set_callback)
6776         (select_singlestep_lwp_callback, set_ignore_sigint)
6777         (status_callback, resumed_callback, resume_clear_callback)
6778         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
6779         data parameter.
6780         (linux_nat_target::detach, linux_nat_target::resume)
6781         (linux_stop_and_wait_all_lwps, select_event_lwp)
6782         (linux_nat_filter_event, linux_nat_wait_1)
6783         (linux_nat_target::kill, linux_nat_target::stop)
6784         (linux_nat_target::stop): Update.
6785         (linux_nat_resume_callback): Change type.
6786         (resume_stopped_resumed_lwps, count_events_callback)
6787         (select_event_lwp_callback): Likewise.
6788         (linux_stop_lwp, linux_nat_stop_lwp): Update.
6789         * arm-linux-nat.c (struct update_registers_data): Remove.
6790         (update_registers_callback): Change type.
6791         (arm_linux_insert_hw_breakpoint1): Update.
6792         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
6793         parameter.
6794         (x86_linux_dr_set_addr): Update.
6795         (x86_linux_dr_set_control): Update.
6796         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
6797         (iterate_over_lwps): Use gdb::function_view.
6798         * nat/aarch64-linux-hw-point.c (struct
6799         aarch64_dr_update_callback_param): Remove.
6800         (debug_reg_change_callback): Change type.
6801         (aarch64_notify_debug_reg_change): Update.
6802         * s390-linux-nat.c (s390_refresh_per_info): Update.
6803
6804 2019-03-11  Tom Tromey  <tromey@adacore.com>
6805
6806         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
6807         redundant assignment to "this_cu".
6808
6809 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6810
6811         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
6812
6813 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6814
6815         * gdbtypes.c (rank_one_type_parm_set): New function extracted
6816         from...
6817         (rank_one_type): ... this.
6818
6819 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6820
6821         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
6822         from...
6823         (rank_one_type): ... this.
6824
6825 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6826
6827         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
6828         from...
6829         (rank_one_type): ... this.
6830
6831 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6832
6833         * gdbtypes.c (rank_one_type_parm_float): New function extracted
6834         from...
6835         (rank_one_type): ... this.
6836
6837 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6838
6839         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
6840         from...
6841         (rank_one_type): ... this.
6842
6843 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6844
6845         * gdbtypes.c (rank_one_type_parm_range): New function extracted
6846         from...
6847         (rank_one_type): ... this.
6848
6849 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6850
6851         * gdbtypes.c (rank_one_type_parm_char): New function extracted
6852         from...
6853         (rank_one_type): ... this.
6854
6855 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6856
6857         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
6858         from...
6859         (rank_one_type): ... this.
6860
6861 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6862
6863         * gdbtypes.c (rank_one_type_parm_int): New function extracted
6864         from...
6865         (rank_one_type): ... this.
6866
6867 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6868
6869         * gdbtypes.c (rank_one_type_parm_func): New function extracted
6870         from...
6871         (rank_one_type): ... this.
6872
6873 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6874
6875         * gdbtypes.c (rank_one_type_parm_array): New function extracted
6876         from...
6877         (rank_one_type): ... this.
6878
6879 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6880
6881         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
6882         from...
6883         (rank_one_type): ... this.
6884
6885 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6886
6887         * inferior.c (initialize_inferiors): Ensure 'help set/show print
6888         inferior-events' shows the example events.
6889
6890 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
6891
6892         Support styling on native MS-Windows console
6893
6894         PR/24315
6895         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
6896         on MS-Windows if $TERM is not defined.
6897
6898         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
6899
6900         * posix-hdep.c (gdb_console_fputs):
6901         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
6902         functions.
6903         * ui-file.h (gdb_console_fputs): Add prototype.
6904
6905         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
6906         back to fputs only if the former returns zero.
6907
6908 2019-03-07  Tom Tromey  <tom@tromey.com>
6909
6910         * symmisc.c (print_symbol_bcache_statistics): Update.
6911         (print_objfile_statistics): Update.
6912         * symfile.c (allocate_symtab): Update.
6913         * stabsread.c: Don't include bcache.h.
6914         * psymtab.h (struct psymbol_bcache): Don't declare.
6915         (class psymtab_storage) <psymbol_cache>: Now a bcache.
6916         (psymbol_bcache_init, psymbol_bcache_free)
6917         (psymbol_bcache_get_bcache): Don't declare.
6918         * psymtab.c (struct psymbol_bcache): Remove.
6919         (psymtab_storage::psymtab_storage): Update.
6920         (psymtab_storage::~psymtab_storage): Update.
6921         (psymbol_bcache_init, psymbol_bcache_free)
6922         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
6923         (add_psymbol_to_bcache): Update.
6924         (allocate_psymtab): Update.
6925         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
6926         macro_cache>: No longer pointers.
6927         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
6928         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
6929         * macrotab.c (macro_bcache): Update.
6930         * macroexp.c: Don't include bcache.h.
6931         * gdbtypes.c (check_types_worklist): Update.
6932         (types_deeply_equal): Remove TRY/CATCH.  Update.
6933         * elfread.c (elf_symtab_read): Update.
6934         * dwarf2read.c: Don't include bcache.h.
6935         * buildsym.c (buildsym_compunit::get_macro_table): Update.
6936         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
6937         (print_bcache_statistics, bcache_memory_used): Don't declare.
6938         (struct bcache): Move from bcache.c.  Add constructor, destructor,
6939         methods.  Rename all data members.
6940         * bcache.c (struct bcache): Move to bcache.h.
6941         (bcache::expand_hash_table): Rename from expand_hash_table.
6942         (bcache): Remove.
6943         (bcache::insert): Rename from bcache_full.
6944         (bcache::compare): Rename from bcache_compare.
6945         (bcache_xmalloc): Remove.
6946         (bcache::~bcache): Rename from bcache_xfree.
6947         (bcache::print_statistics): Rename from print_bcache_statistics.
6948         (bcache::memory_used): Rename from bcache_memory_used.
6949
6950 2019-03-07  Pedro Alves  <palves@redhat.com>
6951
6952         * infrun.c (normal_stop): Also check for
6953         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
6954
6955 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
6956
6957         * f-lang.c (value_from_host_double): Moved to...
6958         * value.c (value_from_host_double): ...here.
6959         * value.h (value_from_host_double): Declare.
6960         * guile/scm-math.c (vlscm_convert_typed_number): Use
6961         value_from_host_double.
6962         (vlscm_convert_number): Likewise.
6963         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
6964         * python/py-value.c (convert_value_from_python): Likewise.
6965
6966 2019-03-06  Tom Tromey  <tom@tromey.com>
6967
6968         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
6969
6970 2019-03-06  Tom Tromey  <tom@tromey.com>
6971
6972         * utils.h (free_current_contents): Don't declare.
6973         * utils.c (free_current_contents): Remove.
6974
6975 2019-03-06  Tom Tromey  <tom@tromey.com>
6976
6977         * top.c (quit_force): Update.
6978         * main.c (captured_command_loop): Update.
6979         * common/new-op.c (operator new): Update.
6980         * common/common-exceptions.c (struct catcher)
6981         <save_cleanup_chain>: Remove member.
6982         (exceptions_state_mc_init): Update.
6983         (exception_try_scope_entry): Return nullptr.
6984         (exception_try_scope_exit, exception_rethrow)
6985         (throw_exception_sjlj, throw_exception_cxx): Update.
6986         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
6987         (all_cleanups, do_cleanups, discard_cleanups)
6988         (discard_final_cleanups, save_cleanups, save_final_cleanups)
6989         (restore_cleanups, restore_final_cleanups): Don't declare.
6990         (do_final_cleanups): Remove parameter.
6991         * common/cleanups.c (cleanup_chain, make_cleanup)
6992         (make_cleanup_dtor, all_cleanups, do_cleanups)
6993         (discard_my_cleanups, discard_cleanups)
6994         (discard_final_cleanups, save_my_cleanups, save_cleanups)
6995         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
6996         (null_cleanup): Remove.
6997         (do_final_cleanups): Remove parameter.
6998
6999 2019-03-06  Tom Tromey  <tom@tromey.com>
7000
7001         * remote.c (remote_target::remote_parse_stop_reply): Use
7002         unique_xmalloc_ptr.
7003
7004 2019-03-06  Tom Tromey  <tom@tromey.com>
7005
7006         * stabsread.c (struct stabs_field_info): Rename from field_info.
7007         <list, fnlist>: Add initializers.
7008         <obstack>: New member.
7009         (read_member_functions, read_struct_fields, read_baseclasses):
7010         Allocate on obstack.  Don't use cleanups.
7011         (read_one_struct_field, read_member_functions, read_struct_fields)
7012         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7013         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7014         (read_struct_type): Update.
7015
7016 2019-03-06  Tom Tromey  <tom@tromey.com>
7017
7018         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7019         * common/filestuff.h (make_cleanup_close): Don't declare.
7020         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7021         Remove.
7022
7023 2019-03-06  Tom Tromey  <tom@tromey.com>
7024
7025         * solib-aix.c: Use make_scope_exit.
7026
7027 2019-03-06  Tom Tromey  <tom@tromey.com>
7028
7029         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7030         Use make_scope_exit.
7031
7032 2019-03-06  Tom Tromey  <tom@tromey.com>
7033
7034         * solib-svr4.c (disable_probes_interface): Remove parameter.
7035         (svr4_handle_solib_event): Use make_scope_exit.
7036
7037 2019-03-06  Tom Tromey  <tom@tromey.com>
7038
7039         * remote.c (struct stop_reply_deleter): Remove.
7040         (stop_reply_up): Update.
7041         (struct stop_reply): Derive from notif_event.  Don't typedef.
7042         <regcache>: Now a std::vector.
7043         (stop_reply_xfree): Remove.
7044         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7045         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7046         (remote_target::discard_pending_stop_replies): Use delete.
7047         (remote_target::remote_parse_stop_reply): Update.
7048         (remote_target::process_stop_reply): Update.
7049         * remote-notif.h (struct notif_event): Add virtual destructor.
7050         Remove "dtr" member.
7051         (struct notif_client) <alloc_event>: Return a unique_ptr.
7052         (notif_event_xfree): Don't declare.
7053         (notif_event_up): New typedef.
7054         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7055         (notif_event_xfree, do_notif_event_xfree): Remove.
7056         (remote_notif_state_xfree): Update.
7057
7058 2019-03-06  Tom Tromey  <tom@tromey.com>
7059
7060         * infrun.c (displaced_step_clear_cleanup): Now a
7061         forward_scope_exit type.
7062         (displaced_step_prepare_throw): Update.
7063         (displaced_step_fixup): Update.
7064
7065 2019-03-06  Tom Tromey  <tom@tromey.com>
7066
7067         * inferior.h (class inferior): Update comment.
7068         * gdbthread.h (class thread_info): Update comment.
7069
7070 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7071             Tom Tromey  <tom@tromey.com>
7072
7073         * stabsread.h (struct stab_section_list): Remove.
7074         (coffstab_build_psymtabs): Update.
7075         * dbxread.c (symbuf_sections): Now a std::vector.
7076         (sect_idx): New global.
7077         (fill_symbuf): Update.
7078         (coffstab_build_psymtabs): Change type of stabsects parameter.
7079         Update.
7080         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7081         std::vector.
7082         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7083         (coff_locate_sections): Update.
7084         (coff_symfile_read): Remove cleanups.  Update.
7085         (init_stringtab): Add storage parameter.
7086         (free_stringtab, free_stringtab_cleanup): Remove.
7087         (init_lineno): Add storage parameter.
7088         (free_linetab, free_linetab_cleanup): Remove.
7089
7090 2019-03-06  Pedro Alves  <palves@redhat.com>
7091
7092         * linux-fork.c (fork_info::clobber_regs): Delete.
7093         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7094         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7095         comment.  Adjust.
7096         (scoped_switch_fork_info::scoped_switch_fork_info)
7097         (checkpoint_command, linux_fork_context): Adjust
7098         fork_save_infrun_state calls.
7099
7100 2019-03-06  Pedro Alves  <palves@redhat.com>
7101
7102         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7103         (inf_has_multiple_threads): Return 'bool' and rewrite using
7104         inferior_info::threads().
7105
7106 2019-03-06  Pedro Alves  <palves@redhat.com>
7107
7108         * linux-fork.c: Include <list>.
7109         (fork_list): Now a std::list instance.
7110         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7111         (forks_exist_p, find_last_fork): Adjust.
7112         (new_fork): Delete.
7113         (one_fork_p): New.
7114         (add_fork): Adjust.
7115         (free_fork): Delete, folded into fork_info::~fork_info().
7116         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7117         Adjust.
7118         (init_fork_list): Delete.
7119         (linux_fork_killall, linux_fork_mourn_inferior)
7120         (linux_fork_detach, info_checkpoints_command): Adjust.
7121         (_initialize_linux_fork): No longer call init_fork_list.
7122
7123 2019-03-06  Pedro Alves  <palves@redhat.com>
7124
7125         * linux-fork.c (new_fork): New, split out of ...
7126         (add_fork): ... this.  Return void.  Move "first fork" special
7127         case from here, to ...
7128         (checkpoint_command): ... here.
7129         * linux-linux.h (add_fork): Return void.
7130
7131 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7132
7133         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7134
7135 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7136             Chris January  <chris.january@arm.com>
7137             David Lecomber  <david.lecomber@arm.com>
7138
7139         * f-exp.y: New token, UNOP_INTRINSIC.
7140         (exp): New pattern using UNOP_INTRINSIC token.
7141         (f77_keywords): Add 'abs' keyword.
7142         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7143         (value_from_host_double): New function.
7144         (evaluate_subexp_f): Support UNOP_ABS.
7145
7146 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7147
7148         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7149         types.
7150
7151 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7152
7153         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7154         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7155         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7156
7157 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7158
7159         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7160
7161 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7162             Chris January  <chris.january@arm.com>
7163
7164         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7165         * f-exp.y: Define 'KIND' token.
7166         (exp): New pattern for KIND expressions.
7167         (ptype): Handle types with a kind extension.
7168         (direct_abs_decl): Extend to spot kind extensions.
7169         (f77_keywords): Add 'kind' to the list.
7170         (push_kind_type): New function.
7171         (convert_to_kind_type): New function.
7172         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7173         * parse.c (operator_length_standard): Likewise.
7174         * parser-defs.h (enum type_pieces): Add tp_kind.
7175         * std-operator.def: Add UNOP_KIND.
7176
7177 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7178
7179         * f-exp.y (f_parse): Set yydebug.
7180
7181 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7182
7183         * f-lang.c (evaluate_subexp_f): New function.
7184         (exp_descriptor_f): New global.
7185         (f_language_defn): Use exp_descriptor_f instead of
7186         exp_descriptor_standard.
7187
7188 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7189
7190         * f-exp.y (struct token): Add comments.
7191         (dot_ops): Remove uppercase versions and the end marker.
7192         (f77_keywords): Likewise.
7193         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7194         entries in the dot_ops array are case insensitive, and use
7195         strncasecmp to compare strings.  Also some whitespace cleanup in
7196         this area.  Similar for the f77_keywords array, except entries in
7197         this list might be case sensitive.
7198
7199 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7200
7201         * f-exp.y (struct f77_boolean_val): Add comments.
7202         (boolean_values): Remove uppercase versions, and end marker.
7203         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7204         and use strncasecmp to achieve case insensitivity.  Additionally,
7205         perform whitespace cleanup around this code.
7206
7207 2019-03-06  Tom Tromey  <tromey@adacore.com>
7208
7209         * remote-sim.c (gdbsim_target_open): Use result of
7210         gdb_argv::release.
7211
7212 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7213         Dirk Schubert  <dirk.schubert@arm.com>
7214         Chris January  <chris.january@arm.com>
7215
7216         * eval.c (evaluate_subexp_standard): Call Fortran argument
7217         wrapping logic.
7218         * f-lang.c (struct value): A value which can be passed into a
7219         Fortran function call.
7220         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7221         where appropriate.
7222         (struct type): Value ready for a Fortran function call.
7223         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7224         is needed.
7225         * f-lang.h (fortran_argument_convert): Declaration.
7226         (fortran_preserve_arg_pointer): Declaration.
7227         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7228
7229 2019-03-05  Tom Tromey  <tromey@adacore.com>
7230
7231         * python/py-prettyprint.c (print_string_repr): Remove #if.
7232         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7233
7234 2019-03-05  Tom Tromey  <tromey@adacore.com>
7235
7236         * target.c (the_dummy_target): Move later.  Change type to
7237         "dummy_target".
7238         (initialize_targets): Don't initialize the_dummy_target.
7239
7240 2019-03-05  Tom Tromey  <tromey@adacore.com>
7241
7242         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7243         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7244
7245 2019-03-05  Tom Tromey  <tromey@adacore.com>
7246
7247         * windows-nat.c (windows_nat_target::attach)
7248         (windows_nat_target::detach): Don't call gdb_flush.
7249         * valprint.c (generic_val_print, val_print, val_print_string):
7250         Don't call gdb_flush.
7251         * utils.c (defaulted_query): Don't call gdb_flush.
7252         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7253         * target.c (target_announce_detach): Don't call gdb_flush.
7254         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7255         * remote.c (extended_remote_target::attach): Don't call
7256         gdb_flush.
7257         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7258         * printcmd.c (do_examine): Don't call gdb_flush.
7259         (info_display_command): Don't call gdb_flush.
7260         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7261         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7262         * memattr.c (info_mem_command): Don't call gdb_flush.
7263         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7264         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7265         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7266         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7267         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7268         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7269         (gnu_nat_target::detach): Don't call gdb_flush.
7270         * f-valprint.c (f_val_print): Don't call gdb_flush.
7271         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7272         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7273         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7274         gdb_flush.
7275         * c-valprint.c (c_val_print): Don't call gdb_flush.
7276         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7277
7278 2019-03-05  Tom Tromey  <tromey@adacore.com>
7279
7280         * varobj.c (update_dynamic_varobj_children): Update.
7281         (install_default_visualizer): Use reset, not release.
7282         * value.c (set_internalvar): Update.
7283         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7284         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7285         ATTRIBUTE_UNUSED_RESULT.
7286
7287 2019-03-05  Tom Tromey  <tromey@adacore.com>
7288
7289         * remote.c (class scoped_remote_fd) <release>: Add
7290         ATTRIBUTE_UNUSED_RESULT.
7291
7292 2019-03-05  Tom Tromey  <tromey@adacore.com>
7293
7294         * macroexp.c (struct macro_buffer) <release>: Add
7295         ATTRIBUTE_UNUSED_RESULT.
7296
7297 2019-03-05  Tom Tromey  <tromey@adacore.com>
7298
7299         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7300         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7301         ATTRIBUTE_UNUSED_RESULT.
7302
7303 2019-03-05  Tom Tromey  <tromey@adacore.com>
7304
7305         * common/scoped_fd.h (class scoped_fd) <release>: Add
7306         ATTRIBUTE_UNUSED_RESULT.
7307
7308 2019-03-05  Tom Tromey  <tromey@adacore.com>
7309
7310         * parser-defs.h (struct parser_state) <release>: Add
7311         ATTRIBUTE_UNUSED_RESULT.
7312
7313 2019-03-05  Tom Tromey  <tromey@adacore.com>
7314
7315         * utils.h (class gdb_argv) <release>: Add
7316         ATTRIBUTE_UNUSED_RESULT.
7317         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7318
7319 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7320
7321         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7322         for-loop range, to avoid compiler warnings.
7323
7324         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7325         avoid compiler warnings about unused variables.
7326
7327         * NEWS: Mention end of support for native debugging on MS-Windows
7328         before XP.
7329
7330         PR gdb/24292
7331         * common/netstuff.c:
7332         * gdbserver/gdbreplay.c
7333         * gdbserver/remote-utils.c:
7334         * ser-tcp.c:
7335         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7336         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7337         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7338         'getaddrinfo' and 'freeaddrinfo' were not available before
7339         Windows XP, and mingw.org's MinGW headers by default define
7340         _WIN32_WINNT to 0x500.
7341
7342 2019-03-01  Gary Benson <gbenson@redhat.com>
7343
7344         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7345
7346 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7347             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7348
7349         PR gdb/8527
7350         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7351         set_sigint_trap, clear_sigint_trap.
7352
7353 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7354
7355         * target.c (target_detach): Clear the regcache and the
7356         frame cache.
7357
7358 2019-02-27  Pedro Alves  <palves@redhat.com>
7359
7360         * utils.c (set_screen_size): When we cap the height/width sizes,
7361         tweak the corresponding command variable to show "unlimited":
7362
7363 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7364             Pedro Alves  <palves@redhat.com>
7365
7366         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7367         before calling rl_set_screen_size.
7368
7369 2019-02-27  Tom Tromey  <tromey@adacore.com>
7370
7371         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7372         define.
7373         * python/py-value.c: Remove Python 2.4 workaround.
7374         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7375         workaround.
7376         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7377         Python 2.4 workaround.
7378         * python/python-internal.h: Remove Python 2.4 comment.
7379         (Py_ssize_t): Don't define.
7380         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7381         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7382         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7383         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7384         * python/python.c (do_start_initialization): Remove Python 2.4
7385         workaround.
7386         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7387         (print_children): Remove Python 2.4 workaround.
7388         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7389         workaround.
7390         (CHARBUFFERPROC_NAME): Remove.
7391         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7392         Python 2.4 workaround.
7393
7394 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7395
7396         * NEWS: Note minimum Python version.
7397
7398 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7399
7400         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7401         code from these functions.  Remove corresponding ifdefs.  Use
7402         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7403         Remove gotos and target of gotos.
7404         (infpy_search_memory): Likewise.
7405
7406 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7407
7408         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7409         (hppa_gdbarch_init): Don't register deleted functions with
7410         gdbarch.
7411
7412 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7413
7414         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7415         (h8300_unwind_sp): Delete.
7416         (h8300_dummy_id): Delete.
7417         (h8300_gdbarch_init): Don't register deleted functions with
7418         gdbarch.
7419
7420 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7421
7422         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7423         (ft32_unwind_pc): Delete.
7424         (ft32_unwind_sp): Delete.
7425         (ft32_gdbarch_init): Don't register deleted functions with
7426         gdbarch.
7427
7428 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7429
7430         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7431         (frv_unwind_pc): Delete.
7432         (frv_unwind_sp): Delete.
7433         (frv_gdbarch_init): Don't register deleted functions with
7434         gdbarch.
7435
7436 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7437
7438         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7439         (riscv_unwind_pc): Delete.
7440         (riscv_unwind_sp): Delete.
7441         (riscv_gdbarch_init): Don't register deleted functions with
7442         gdbarch.
7443
7444 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7445
7446         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7447         (csky_unwind_pc): Delete.
7448         (csky_unwind_sp): Delete.
7449         (csky_gdbarch_init): Don't register deleted functions with
7450         gdbarch.
7451
7452 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7453
7454         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7455         (cris_unwind_pc): Delete.
7456         (cris_unwind_sp): Delete.
7457         (cris_gdbarch_init): Don't register deleted functions with
7458         gdbarch.
7459
7460 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7461
7462         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7463         (bfin_unwind_pc): Delete.
7464         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7465
7466 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7467
7468         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7469         (arm_unwind_pc): Delete.
7470         (arm_unwind_sp): Delete.
7471         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7472
7473 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7474
7475         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7476         (arc_unwind_pc): Delete.
7477         (arc_unwind_sp): Delete.
7478         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7479
7480 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7481
7482         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7483         (alpha_unwind_pc): Delete.
7484         (alpha_gdbarch_init): Don't register deleted functions with
7485         gdbarch.
7486
7487 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7488
7489         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7490         (aarch64_unwind_pc): Delete.
7491         (aarch64_unwind_sp): Delete.
7492         (aarch64_gdbarch_init): Don't register deleted functions with
7493         gdbarch.
7494
7495 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7496
7497         * gdbtypes.c (type_align): Don't consider static members when
7498         computing structure alignment.
7499
7500 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7501
7502         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7503         return 0 for other types.
7504         * arch-utils.c (default_type_align): Always return 0.
7505         * gdbarch.h: Regenerate.
7506         * gdbarch.sh (type_align): Extend comment.
7507         * gdbtypes.c (type_align): Add additional comments, always call
7508         gdbarch_type_align before applying the default rules.
7509         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7510         generic code will then apply a suitable default.
7511         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7512         types, return 0 for other types.
7513
7514 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7515
7516         * NEWS: Create a new section for the next release branch.
7517         Rename the section of the current branch, now that it has
7518         been cut.
7519
7520 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7521
7522         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7523         * version.in: Bump version to 8.3.50.DATE-git.
7524
7525 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7526
7527         * aix-thread.c (ptid_cmp): Remove unused variable.
7528         (get_signaled_thread): Likewise.
7529         (store_regs_user_thread): Likewise.
7530         (store_regs_kernel_thread): Likewise.
7531         (fetch_regs_kernel_thread): Remove shadowed variable.
7532
7533 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7534
7535         * features/riscv/32bit-cpu.xml: Add register numbers.
7536         * features/riscv/32bit-fpu.c: Regenerate.
7537         * features/riscv/32bit-fpu.xml: Add register numbers.
7538         * features/riscv/64bit-cpu.xml: Add register numbers.
7539         * features/riscv/64bit-fpu.c: Regenerate.
7540         * features/riscv/64bit-fpu.xml: Add register numbers.
7541
7542 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7543
7544         * NEWS: Mention two argument form of gdb.Value constructor.
7545         * python/py-value.c (convert_buffer_and_type_to_value): New
7546         function.
7547         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7548         Add support for handling an optional second argument.  Call
7549         convert_buffer_and_type_to_value as appropriate.
7550         * python/python-internal.h (Py_buffer_deleter): New struct.
7551         (Py_buffer_up): New typedef.
7552
7553 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7554
7555         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7556         instead of releasing ownership.
7557
7558 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7559
7560         * dwarf2read.c (open_and_init_dwp_file): Call
7561         elf_numsections instead of bfd_count_sections to initialize
7562         dwp_file->num_sections.
7563
7564 2019-02-25  Tom Tromey  <tromey@adacore.com>
7565
7566         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7567
7568 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7569
7570         * gcore.in: Add '--readnever' option when invoking GDB.
7571
7572 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7573
7574         * MAINTAINERS: Update my email address.
7575
7576 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7577
7578         * build-id.c (build_id_to_debug_bfd_1): New function.
7579         (build_id_to_debug_bfd): Look for separate debug file in
7580         sysroot.
7581
7582 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7583
7584         * gdbarch.sh: Update the copyright year range that is placed into
7585         generated files.
7586
7587 2019-02-22  Keith Seitz  <keiths@redhat.com>
7588
7589         PR symtab/23853
7590         * linespec.c (create_sals_line_offset): Search for the default
7591         symtab's filename instead of its fullname.
7592
7593 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7594
7595         * NEWS: Update style defaults.
7596
7597 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7598
7599         * main.c (captured_main_1): Disable styling in batch mode.
7600
7601 2019-02-20  Tom Tromey  <tom@tromey.com>
7602
7603         * symtab.c (symtab_symbol_info): Fix typos.
7604
7605 2019-02-20  Tom Tromey  <tromey@adacore.com>
7606
7607         * findcmd.c (_initialize_mem_search): Use upper case for
7608         metasyntactic variables.
7609
7610 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7611
7612         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7613         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7614
7615 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7616
7617         * top.h (source_file_name): Change to std::string.
7618         * top.c (source_file_name): Likewise.
7619         (command_line_input): Adjust.
7620         * cli/cli-script.c (script_from_file): Adjust.
7621
7622 2019-02-19  Tom Tromey  <tromey@adacore.com>
7623
7624         * ravenscar-thread.c
7625         (ravenscar_thread_target::update_thread_list): Don't call
7626         ada_build_task_list.
7627         * ada-lang.h (ada_build_task_list): Don't declare.
7628         * ada-tasks.c (struct ada_tasks_inferior_data)
7629         <task_list_valid_p>: Now bool.
7630         (read_known_tasks, ada_task_list_changed)
7631         (ada_tasks_invalidate_inferior_data): Update.
7632         (read_known_tasks_array): Return bool.
7633         (read_known_tasks_list): Likewise.
7634         (read_known_tasks): Return void.
7635         (ada_build_task_list): Now static.
7636
7637 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7638
7639         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
7640         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
7641
7642 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7643
7644         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
7645         variant for ada_tasks_pspace_data_handle and
7646         ada_tasks_inferior_data_handle.
7647         (ada_tasks_pspace_data_cleanup): New function.
7648         (ada_tasks_inferior_data_cleanup): New function.
7649
7650 2019-02-17  Tom Tromey  <tom@tromey.com>
7651
7652         * macrotab.h (macro_source_fullname): Return a std::string.
7653         * macrotab.c (macro_include, check_for_redefinition)
7654         (macro_undef, macro_lookup_definition, foreach_macro)
7655         (foreach_macro_in_scope): Update.
7656         (macro_source_fullname): Return a std::string.
7657         * macrocmd.c (show_pp_source_pos): Update.
7658
7659 2019-02-17  Tom Tromey  <tom@tromey.com>
7660
7661         * macrocmd.c (show_pp_source_pos): Style the file names.
7662
7663 2019-02-17  Tom Tromey  <tom@tromey.com>
7664
7665         PR tui/24197:
7666         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
7667
7668 2019-02-17  Tom Tromey  <tom@tromey.com>
7669
7670         * ada-lang.c (user_select_syms): Use filtered printing.
7671         * utils.c (wrap_style): New global.
7672         (desired_style): Remove.
7673         (emit_style_escape): Add stream parameter.
7674         (set_output_style, reset_terminal_style, prompt_for_continue):
7675         Update.
7676         (flush_wrap_buffer): Only flush gdb_stdout.
7677         (wrap_here): Set wrap_style.
7678         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
7679         treat escape sequences as a character.  Change when wrap buffer is
7680         flushed.
7681         (fputs_styled): Do not set the output style when the default is
7682         requested.
7683         * ui-style.h (struct ui_file_style) <is_default>: New method.
7684         * source.c (print_source_lines_base): Emit escape sequences in one
7685         piece.
7686
7687 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7688
7689         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
7690         integers and enumeration types.
7691
7692 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7693
7694         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
7695         instead of lookup_symbol_in_language
7696         (do_exact_match): New function.
7697         (ada_get_symbol_name_matcher): Return do_exact_match when
7698         doing a verbatim match.
7699
7700 2019-02-15  Tom Tromey  <tromey@adacore.com>
7701
7702         * ravenscar-thread.c (ravenscar_thread_target::resume)
7703         (ravenscar_thread_target::wait): Special case wildcard requests.
7704
7705 2019-02-15  Tom Tromey  <tromey@adacore.com>
7706
7707         * ravenscar-thread.c (base_ptid): Remove.
7708         (struct ravenscar_thread_target) <close>: New method.
7709         <m_base_ptid>: New member.
7710         <update_inferior_ptid, active_task, task_is_currently_active,
7711         runtime_initialized>: Declare methods.
7712         <ravenscar_thread_target>: Add constructor.
7713         (ravenscar_thread_target::task_is_currently_active)
7714         (ravenscar_thread_target::update_inferior_ptid)
7715         (ravenscar_runtime_initialized): Rename.  Now methods.
7716         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
7717         (ravenscar_thread_target::update_thread_list): Update.
7718         (ravenscar_thread_target::active_task): Now method.
7719         (ravenscar_thread_target::store_registers)
7720         (ravenscar_thread_target::prepare_to_store)
7721         (ravenscar_thread_target::prepare_to_store)
7722         (ravenscar_thread_target::mourn_inferior): Update.
7723         (ravenscar_inferior_created): Use "new" to create target.
7724         (ravenscar_thread_target::get_ada_task_ptid): Update.
7725         (_initialize_ravenscar): Don't initialize base_ptid.
7726         (ravenscar_ops): Remove global.
7727
7728 2019-02-15  Tom Tromey  <tromey@adacore.com>
7729
7730         * target.h (push_target): Declare new overload.
7731         * target.c (push_target): New overload, taking an rvalue reference.
7732         * remote.c (remote_target::open_1): Use push_target overload.
7733         * corelow.c (core_target_open): Use push_target overload.
7734
7735 2019-02-15  Tom Tromey  <tromey@adacore.com>
7736
7737         * ravenscar-thread.c (is_ravenscar_task)
7738         (ravenscar_task_is_currently_active): Return bool.
7739         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
7740         (_initialize_ravenscar): Remove "(void)".
7741         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
7742         Return bool.
7743
7744 2019-02-15  Tom Tromey  <tromey@adacore.com>
7745
7746         * ravenscar-thread.c (ravenscar_runtime_initializer)
7747         (has_ravenscar_runtime, get_running_thread_id)
7748         (ravenscar_thread_target::resume): Fix indentation.
7749
7750 2019-02-15  Tom Tromey  <tromey@adacore.com>
7751
7752         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
7753         from ravenscar_arch_ops.
7754         (sparc_ravenscar_ops::fetch_registers)
7755         (sparc_ravenscar_ops::store_registers): Now methods.
7756         (sparc_ravenscar_prepare_to_store): Remove.
7757         (sparc_ravenscar_ops): Redefine.
7758         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
7759         methods and destructor.  Remove members.
7760         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
7761         (ravenscar_thread_target::store_registers)
7762         (ravenscar_thread_target::prepare_to_store): Update.
7763         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
7764         Remove.
7765         (struct ppc_ravenscar_powerpc_ops): Derive from
7766         ravenscar_arch_ops.
7767         (ppc_ravenscar_powerpc_ops::fetch_registers)
7768         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
7769         (ppc_ravenscar_powerpc_ops): Redefine.
7770         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
7771         (ppc_ravenscar_e500_ops::fetch_registers)
7772         (ppc_ravenscar_e500_ops::store_registers): Now methods.
7773         (ppc_ravenscar_e500_ops): Redefine.
7774         * aarch64-ravenscar-thread.c
7775         (aarch64_ravenscar_generic_prepare_to_store): Remove.
7776         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
7777         (aarch64_ravenscar_fetch_registers)
7778         (aarch64_ravenscar_store_registers): Now methods.
7779         (aarch64_ravenscar_ops): Redefine.
7780
7781 2019-02-15  Tom Tromey  <tromey@adacore.com>
7782
7783         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
7784         (ravenscar_thread_target::stopped_by_hw_breakpoint)
7785         (ravenscar_thread_target::stopped_by_watchpoint)
7786         (ravenscar_thread_target::stopped_data_address)
7787         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
7788
7789 2019-02-15  Tom Tromey  <tromey@adacore.com>
7790
7791         * ravenscar-thread.c: Fix some typos.
7792
7793 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7794             Tom Tromey  <tromey@adacore.com>
7795
7796         * ada-lang.c (ada_exception_sal): Change addr_string to a
7797         std::string.
7798         (create_ada_exception_catchpoint): Update.
7799
7800 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7801             Tom Tromey  <tromey@adacore.com>
7802
7803         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
7804         (bp_location_ops): Remove.
7805         (base_breakpoint_allocate_location): Update.
7806         (free_bp_location): Update.
7807         * ada-lang.c (class ada_catchpoint_location)
7808         <ada_catchpoint_location>: Remove ops parameter.
7809         (ada_catchpoint_location_dtor): Remove.
7810         (ada_catchpoint_location_ops): Remove.
7811         (allocate_location_exception): Update.
7812         * breakpoint.h (struct bp_location_ops): Remove.
7813         (class bp_location) <bp_location>: Remove bp_location_ops
7814         parameter.
7815         <~bp_location>: Add destructor.
7816         <ops>: Remove.
7817
7818 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7819             Pedro Alves  <palves@redhat.com>
7820
7821         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
7822         'PATH_MAX'.
7823
7824 2019-02-14  David Michael  <fedora.dm0@gmail.com>
7825             Samuel Thibault  <samuel.thibault@gnu.org>
7826             Thomas Schwinge  <thomas@codesourcery.com>
7827
7828         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
7829         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
7830
7831 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7832
7833         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
7834         (check_empty): Use "const char *".
7835
7836         * gnu-nat.c (gnu_nat_target::detach): Instead of
7837         'detach_inferior (pid)' call
7838         'detach_inferior (find_inferior_pid (pid))'.
7839
7840         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
7841         'nat/fork-inferior.o'.
7842         * gnu-nat.c: #include "nat/fork-inferior.h".
7843
7844         * gnu-nat.c (gnu_nat_target::detach): Instead of
7845         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
7846         * gnu-nat.h: #include "inf-child.h".
7847         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
7848         'i386_gnu_nat_target::fetch_registers'.
7849         (gnu_store_registers): Rename/move to
7850         'i386_gnu_nat_target::store_registers'.
7851
7852         * config/i386/nm-i386gnu.h: Don't "#include" any files.
7853         * gnu-nat.h (mach_thread_info): New function.
7854         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
7855
7856         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
7857
7858 2019-02-14  Frederic Konrad  <konrad@adacore.com>
7859
7860         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
7861
7862 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
7863
7864         * windows-nat.c (windows_add_thread): Add new parameter
7865         "main_thread_p" with default value set to false.  Update
7866         function documentation as well as all callers.
7867         (windows_delete_thread): Likewise.
7868         (fake_create_process): Update call to windows_add_thread.
7869         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
7870         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
7871         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
7872         call to windows_delete_thread.
7873
7874 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
7875
7876         * MAINTAINERS: Add Andrew Burgess as global maintainer.
7877
7878 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7879
7880         * symfile.c (find_separate_debug_file): Use canonical path of
7881         sysroot with child_path instead of gdb_sysroot if it is valid.
7882
7883 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7884
7885         * symfile.c (find_separate_debug_file): Use child_path to
7886         determine if an object file is under a sysroot.
7887
7888 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7889
7890         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
7891         unittests/child-path-selftests.c.
7892         * common/pathstuff.c (child_path): New function.
7893         * common/pathstuff.h (child_path): New prototype.
7894         * unittests/child-path-selftests.c: New file.
7895
7896 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7897
7898         * symfile.c (find_separate_debug_file): Look for separate debug
7899         files in debug directories under the sysroot.
7900
7901 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7902
7903         * symtab.h (struct minimal_symbol data_p): New const method.
7904         (struct minimal_symbol text_p): Likewise.
7905         * symtab.c (output_source_filename): Use file name style
7906         to print file name.
7907         (print_symbol_info): Likewise.
7908         (print_msymbol_info): Use address style to print addresses.
7909         Use function name style to print executable text symbols.
7910         (expand_symtab_containing_pc): Use data_p.
7911         (find_pc_sect_compunit_symtab): Likewise.
7912
7913 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7914
7915         * breakpoint.c (describe_other_breakpoints): Use address style
7916         to print addresses.
7917         (say_where): Likewise.
7918
7919 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7920
7921         * ada-typeprint.c (print_func_type): Print function name
7922         style to print function name.
7923         * c-typeprint.c (c_print_type_1): Likewise.
7924
7925 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
7926
7927         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
7928         for execve.
7929
7930 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7931
7932         * c-exp.y (direct_abs_decl): Use emplace_back to record the
7933         type_stack.
7934
7935 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
7936
7937         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
7938         TYPE_CODE_REF types.
7939
7940 2019-02-08  Jim Wilson  <jimw@sifive.com>
7941
7942         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
7943         (riscv_linux_fregset): New.
7944         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
7945
7946 2019-02-07  Tom Tromey  <tom@tromey.com>
7947
7948         * thread.c (thread_cancel_execution_command): Update.
7949         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
7950         methods.
7951         (struct thread_fsm_ops): Remove.
7952         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
7953         (thread_fsm_should_stop, thread_fsm_return_value)
7954         (thread_fsm_set_finished, thread_fsm_finished_p)
7955         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
7956         Don't declare.
7957         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
7958         * infrun.c (clear_proceed_status_thread)
7959         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
7960         (print_stop_event): Update.
7961         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
7962         Add constructor.
7963         (step_command_fsm_ops): Remove.
7964         (new_step_command_fsm): Remove.
7965         (step_1): Update.
7966         (step_command_fsm::should_stop): Rename from
7967         step_command_fsm_should_stop.
7968         (step_command_fsm::clean_up): Rename from
7969         step_command_fsm_clean_up.
7970         (step_command_fsm::do_async_reply_reason): Rename from
7971         step_command_fsm_async_reply_reason.
7972         (struct until_next_fsm): Inherit from thread_fsm.  Add
7973         constructor.
7974         (until_next_fsm_ops): Remove.
7975         (new_until_next_fsm): Remove.
7976         (until_next_fsm::should_stop): Rename from
7977         until_next_fsm_should_stop.
7978         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
7979         (until_next_fsm::do_async_reply_reason): Rename from
7980         until_next_fsm_async_reply_reason.
7981         (struct finish_command_fsm): Inherit from thread_fsm.  Add
7982         constructor.  Change type of breakpoint.
7983         (finish_command_fsm_ops): Remove.
7984         (new_finish_command_fsm): Remove.
7985         (finish_command_fsm::should_stop): Rename from
7986         finish_command_fsm_should_stop.
7987         (finish_command_fsm::clean_up): Rename from
7988         finish_command_fsm_clean_up.
7989         (finish_command_fsm::return_value): Rename from
7990         finish_command_fsm_return_value.
7991         (finish_command_fsm::do_async_reply_reason): Rename from
7992         finish_command_fsm_async_reply_reason.
7993         (finish_command): Update.
7994         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
7995         Add constructor.
7996         (call_thread_fsm_ops): Remove.
7997         (call_thread_fsm::call_thread_fsm): Rename from
7998         new_call_thread_fsm.
7999         (call_thread_fsm::should_stop): Rename from
8000         call_thread_fsm_should_stop.
8001         (call_thread_fsm::should_notify_stop): Rename from
8002         call_thread_fsm_should_notify_stop.
8003         (run_inferior_call, call_function_by_hand_dummy): Update.
8004         * cli/cli-interp.c (should_print_stop_to_console): Update.
8005         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8006         Add constructor.  Change type of location_breakpoint,
8007         caller_breakpoint.
8008         (until_break_fsm_ops): Remove.
8009         (new_until_break_fsm): Remove.
8010         (until_break_fsm::should_stop): Rename from
8011         until_break_fsm_should_stop.
8012         (until_break_fsm::clean_up): Rename from
8013         until_break_fsm_clean_up.
8014         (until_break_fsm::do_async_reply_reason): Rename from
8015         until_break_fsm_async_reply_reason.
8016         (until_break_command): Update.
8017         * thread-fsm.c: Remove.
8018         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8019
8020 2019-02-07  Tom Tromey  <tom@tromey.com>
8021
8022         * yy-remap.h: Add include guard.
8023         * xtensa-tdep.h: Add include guard.
8024         * xcoffread.h: Rename include guard.
8025         * varobj-iter.h: Add include guard.
8026         * tui/tui.h: Rename include guard.
8027         * tui/tui-winsource.h: Rename include guard.
8028         * tui/tui-wingeneral.h: Rename include guard.
8029         * tui/tui-windata.h: Rename include guard.
8030         * tui/tui-win.h: Rename include guard.
8031         * tui/tui-stack.h: Rename include guard.
8032         * tui/tui-source.h: Rename include guard.
8033         * tui/tui-regs.h: Rename include guard.
8034         * tui/tui-out.h: Rename include guard.
8035         * tui/tui-layout.h: Rename include guard.
8036         * tui/tui-io.h: Rename include guard.
8037         * tui/tui-hooks.h: Rename include guard.
8038         * tui/tui-file.h: Rename include guard.
8039         * tui/tui-disasm.h: Rename include guard.
8040         * tui/tui-data.h: Rename include guard.
8041         * tui/tui-command.h: Rename include guard.
8042         * tic6x-tdep.h: Add include guard.
8043         * target/waitstatus.h: Rename include guard.
8044         * target/wait.h: Rename include guard.
8045         * target/target.h: Rename include guard.
8046         * target/resume.h: Rename include guard.
8047         * target-float.h: Rename include guard.
8048         * stabsread.h: Add include guard.
8049         * rs6000-tdep.h: Add include guard.
8050         * riscv-fbsd-tdep.h: Add include guard.
8051         * regformats/regdef.h: Rename include guard.
8052         * record.h: Rename include guard.
8053         * python/python.h: Rename include guard.
8054         * python/python-internal.h: Rename include guard.
8055         * python/py-stopevent.h: Rename include guard.
8056         * python/py-ref.h: Rename include guard.
8057         * python/py-record.h: Rename include guard.
8058         * python/py-record-full.h: Rename include guard.
8059         * python/py-record-btrace.h: Rename include guard.
8060         * python/py-instruction.h: Rename include guard.
8061         * python/py-events.h: Rename include guard.
8062         * python/py-event.h: Rename include guard.
8063         * procfs.h: Add include guard.
8064         * proc-utils.h: Add include guard.
8065         * p-lang.h: Add include guard.
8066         * or1k-tdep.h: Rename include guard.
8067         * observable.h: Rename include guard.
8068         * nto-tdep.h: Rename include guard.
8069         * nat/x86-linux.h: Rename include guard.
8070         * nat/x86-linux-dregs.h: Rename include guard.
8071         * nat/x86-gcc-cpuid.h: Add include guard.
8072         * nat/x86-dregs.h: Rename include guard.
8073         * nat/x86-cpuid.h: Rename include guard.
8074         * nat/ppc-linux.h: Rename include guard.
8075         * nat/mips-linux-watch.h: Rename include guard.
8076         * nat/linux-waitpid.h: Rename include guard.
8077         * nat/linux-ptrace.h: Rename include guard.
8078         * nat/linux-procfs.h: Rename include guard.
8079         * nat/linux-osdata.h: Rename include guard.
8080         * nat/linux-nat.h: Rename include guard.
8081         * nat/linux-namespaces.h: Rename include guard.
8082         * nat/linux-btrace.h: Rename include guard.
8083         * nat/glibc_thread_db.h: Rename include guard.
8084         * nat/gdb_thread_db.h: Rename include guard.
8085         * nat/gdb_ptrace.h: Rename include guard.
8086         * nat/fork-inferior.h: Rename include guard.
8087         * nat/amd64-linux-siginfo.h: Rename include guard.
8088         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8089         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8090         * nat/aarch64-linux.h: Rename include guard.
8091         * nat/aarch64-linux-hw-point.h: Rename include guard.
8092         * mn10300-tdep.h: Add include guard.
8093         * mips-linux-tdep.h: Add include guard.
8094         * mi/mi-parse.h: Rename include guard.
8095         * mi/mi-out.h: Rename include guard.
8096         * mi/mi-main.h: Rename include guard.
8097         * mi/mi-interp.h: Rename include guard.
8098         * mi/mi-getopt.h: Rename include guard.
8099         * mi/mi-console.h: Rename include guard.
8100         * mi/mi-common.h: Rename include guard.
8101         * mi/mi-cmds.h: Rename include guard.
8102         * mi/mi-cmd-break.h: Rename include guard.
8103         * m2-lang.h: Add include guard.
8104         * location.h: Rename include guard.
8105         * linux-record.h: Rename include guard.
8106         * linux-nat.h: Add include guard.
8107         * linux-fork.h: Add include guard.
8108         * i386-darwin-tdep.h: Rename include guard.
8109         * hppa-linux-offsets.h: Add include guard.
8110         * guile/guile.h: Rename include guard.
8111         * guile/guile-internal.h: Rename include guard.
8112         * gnu-nat.h: Rename include guard.
8113         * gdb-stabs.h: Rename include guard.
8114         * frv-tdep.h: Add include guard.
8115         * f-lang.h: Add include guard.
8116         * event-loop.h: Add include guard.
8117         * darwin-nat.h: Rename include guard.
8118         * cp-abi.h: Rename include guard.
8119         * config/sparc/nm-sol2.h: Rename include guard.
8120         * config/nm-nto.h: Rename include guard.
8121         * config/nm-linux.h: Add include guard.
8122         * config/i386/nm-i386gnu.h: Rename include guard.
8123         * config/djgpp/nl_types.h: Rename include guard.
8124         * config/djgpp/langinfo.h: Rename include guard.
8125         * compile/gcc-cp-plugin.h: Add include guard.
8126         * compile/gcc-c-plugin.h: Add include guard.
8127         * compile/compile.h: Rename include guard.
8128         * compile/compile-object-run.h: Rename include guard.
8129         * compile/compile-object-load.h: Rename include guard.
8130         * compile/compile-internal.h: Rename include guard.
8131         * compile/compile-cplus.h: Rename include guard.
8132         * compile/compile-c.h: Rename include guard.
8133         * common/xml-utils.h: Rename include guard.
8134         * common/x86-xstate.h: Rename include guard.
8135         * common/version.h: Rename include guard.
8136         * common/vec.h: Rename include guard.
8137         * common/tdesc.h: Rename include guard.
8138         * common/selftest.h: Rename include guard.
8139         * common/scoped_restore.h: Rename include guard.
8140         * common/scoped_mmap.h: Rename include guard.
8141         * common/scoped_fd.h: Rename include guard.
8142         * common/safe-iterator.h: Rename include guard.
8143         * common/run-time-clock.h: Rename include guard.
8144         * common/refcounted-object.h: Rename include guard.
8145         * common/queue.h: Rename include guard.
8146         * common/ptid.h: Rename include guard.
8147         * common/print-utils.h: Rename include guard.
8148         * common/preprocessor.h: Rename include guard.
8149         * common/pathstuff.h: Rename include guard.
8150         * common/observable.h: Rename include guard.
8151         * common/netstuff.h: Rename include guard.
8152         * common/job-control.h: Rename include guard.
8153         * common/host-defs.h: Rename include guard.
8154         * common/gdb_wait.h: Rename include guard.
8155         * common/gdb_vecs.h: Rename include guard.
8156         * common/gdb_unlinker.h: Rename include guard.
8157         * common/gdb_unique_ptr.h: Rename include guard.
8158         * common/gdb_tilde_expand.h: Rename include guard.
8159         * common/gdb_sys_time.h: Rename include guard.
8160         * common/gdb_string_view.h: Rename include guard.
8161         * common/gdb_splay_tree.h: Rename include guard.
8162         * common/gdb_setjmp.h: Rename include guard.
8163         * common/gdb_ref_ptr.h: Rename include guard.
8164         * common/gdb_optional.h: Rename include guard.
8165         * common/gdb_locale.h: Rename include guard.
8166         * common/gdb_assert.h: Rename include guard.
8167         * common/filtered-iterator.h: Rename include guard.
8168         * common/filestuff.h: Rename include guard.
8169         * common/fileio.h: Rename include guard.
8170         * common/environ.h: Rename include guard.
8171         * common/common-utils.h: Rename include guard.
8172         * common/common-types.h: Rename include guard.
8173         * common/common-regcache.h: Rename include guard.
8174         * common/common-inferior.h: Rename include guard.
8175         * common/common-gdbthread.h: Rename include guard.
8176         * common/common-exceptions.h: Rename include guard.
8177         * common/common-defs.h: Rename include guard.
8178         * common/common-debug.h: Rename include guard.
8179         * common/cleanups.h: Rename include guard.
8180         * common/buffer.h: Rename include guard.
8181         * common/btrace-common.h: Rename include guard.
8182         * common/break-common.h: Rename include guard.
8183         * cli/cli-utils.h: Rename include guard.
8184         * cli/cli-style.h: Rename include guard.
8185         * cli/cli-setshow.h: Rename include guard.
8186         * cli/cli-script.h: Rename include guard.
8187         * cli/cli-interp.h: Rename include guard.
8188         * cli/cli-decode.h: Rename include guard.
8189         * cli/cli-cmds.h: Rename include guard.
8190         * charset-list.h: Add include guard.
8191         * buildsym-legacy.h: Rename include guard.
8192         * bfin-tdep.h: Add include guard.
8193         * ax.h: Rename include guard.
8194         * arm-linux-tdep.h: Add include guard.
8195         * arm-fbsd-tdep.h: Add include guard.
8196         * arch/xtensa.h: Rename include guard.
8197         * arch/tic6x.h: Add include guard.
8198         * arch/i386.h: Add include guard.
8199         * arch/arm.h: Rename include guard.
8200         * arch/arm-linux.h: Rename include guard.
8201         * arch/arm-get-next-pcs.h: Rename include guard.
8202         * arch/amd64.h: Add include guard.
8203         * arch/aarch64-insn.h: Rename include guard.
8204         * arch-utils.h: Rename include guard.
8205         * annotate.h: Add include guard.
8206         * amd64-darwin-tdep.h: Rename include guard.
8207         * aarch64-linux-tdep.h: Add include guard.
8208         * aarch64-fbsd-tdep.h: Add include guard.
8209         * aarch32-linux-nat.h: Add include guard.
8210
8211 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8212
8213         * macrotab.c (macro_define_internal): New function that
8214         factorizes macro_define_object_internal and macro_define_function
8215         code.
8216         (macro_define_object_internal): Use macro_define_internal.
8217         (macro_define_function): Likewise.
8218
8219 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8220
8221         * macrocmd.c (extract_identifier): Return
8222         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8223         callers.
8224
8225 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8226
8227         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8228
8229 2019-02-05  Tom Tromey  <tom@tromey.com>
8230
8231         * target.c (target_stack::unpush): Move assertion earlier.
8232
8233 2019-01-30  Tom Tromey  <tom@tromey.com>
8234
8235         PR python/23615:
8236         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8237         (gdbpy_parse_and_eval): Likewise.
8238         * python/python-internal.h (gdbpy_allow_threads): New class.
8239
8240 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8241
8242         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8243         (aarch64_fbsd_fpregmap): Move earlier.
8244         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8245         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8246         instead of individual calls to trad_frame_set_reg_addr.
8247         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8248         earlier.
8249         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8250         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8251         instead of individual calls to trad_frame_set_reg_addr.
8252
8253 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8254
8255         * CONTRIBUTE: Replace contribution list with wiki link.
8256
8257 2019-01-25  Tom Tromey  <tom@tromey.com>
8258
8259         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8260
8261 2019-01-25  Tom Tromey  <tom@tromey.com>
8262
8263         * xtensa-linux-nat.c: Fix common/ includes.
8264         * xml-support.h: Fix common/ includes.
8265         * xml-support.c: Fix common/ includes.
8266         * x86-linux-nat.c: Fix common/ includes.
8267         * windows-nat.c: Fix common/ includes.
8268         * varobj.h: Fix common/ includes.
8269         * varobj.c: Fix common/ includes.
8270         * value.c: Fix common/ includes.
8271         * valops.c: Fix common/ includes.
8272         * utils.c: Fix common/ includes.
8273         * unittests/xml-utils-selftests.c: Fix common/ includes.
8274         * unittests/utils-selftests.c: Fix common/ includes.
8275         * unittests/unpack-selftests.c: Fix common/ includes.
8276         * unittests/tracepoint-selftests.c: Fix common/ includes.
8277         * unittests/style-selftests.c: Fix common/ includes.
8278         * unittests/string_view-selftests.c: Fix common/ includes.
8279         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8280         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8281         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8282         * unittests/rsp-low-selftests.c: Fix common/ includes.
8283         * unittests/parse-connection-spec-selftests.c: Fix common/
8284         includes.
8285         * unittests/optional-selftests.c: Fix common/ includes.
8286         * unittests/offset-type-selftests.c: Fix common/ includes.
8287         * unittests/observable-selftests.c: Fix common/ includes.
8288         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8289         * unittests/memrange-selftests.c: Fix common/ includes.
8290         * unittests/memory-map-selftests.c: Fix common/ includes.
8291         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8292         * unittests/function-view-selftests.c: Fix common/ includes.
8293         * unittests/environ-selftests.c: Fix common/ includes.
8294         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8295         * unittests/common-utils-selftests.c: Fix common/ includes.
8296         * unittests/cli-utils-selftests.c: Fix common/ includes.
8297         * unittests/array-view-selftests.c: Fix common/ includes.
8298         * ui-file.c: Fix common/ includes.
8299         * tui/tui-io.c: Fix common/ includes.
8300         * tracepoint.h: Fix common/ includes.
8301         * tracepoint.c: Fix common/ includes.
8302         * tracefile-tfile.c: Fix common/ includes.
8303         * top.h: Fix common/ includes.
8304         * top.c: Fix common/ includes.
8305         * thread.c: Fix common/ includes.
8306         * target/waitstatus.h: Fix common/ includes.
8307         * target/waitstatus.c: Fix common/ includes.
8308         * target.h: Fix common/ includes.
8309         * target.c: Fix common/ includes.
8310         * target-memory.c: Fix common/ includes.
8311         * target-descriptions.c: Fix common/ includes.
8312         * symtab.h: Fix common/ includes.
8313         * symfile.c: Fix common/ includes.
8314         * stap-probe.c: Fix common/ includes.
8315         * spu-linux-nat.c: Fix common/ includes.
8316         * sparc-nat.c: Fix common/ includes.
8317         * source.c: Fix common/ includes.
8318         * solib.c: Fix common/ includes.
8319         * solib-target.c: Fix common/ includes.
8320         * ser-unix.c: Fix common/ includes.
8321         * ser-tcp.c: Fix common/ includes.
8322         * ser-pipe.c: Fix common/ includes.
8323         * ser-base.c: Fix common/ includes.
8324         * selftest-arch.c: Fix common/ includes.
8325         * s12z-tdep.c: Fix common/ includes.
8326         * rust-exp.y: Fix common/ includes.
8327         * rs6000-aix-tdep.c: Fix common/ includes.
8328         * riscv-tdep.c: Fix common/ includes.
8329         * remote.c: Fix common/ includes.
8330         * remote-notif.h: Fix common/ includes.
8331         * remote-fileio.h: Fix common/ includes.
8332         * remote-fileio.c: Fix common/ includes.
8333         * regcache.h: Fix common/ includes.
8334         * regcache.c: Fix common/ includes.
8335         * record-btrace.c: Fix common/ includes.
8336         * python/python.c: Fix common/ includes.
8337         * python/py-type.c: Fix common/ includes.
8338         * python/py-inferior.c: Fix common/ includes.
8339         * progspace.h: Fix common/ includes.
8340         * producer.c: Fix common/ includes.
8341         * procfs.c: Fix common/ includes.
8342         * proc-api.c: Fix common/ includes.
8343         * printcmd.c: Fix common/ includes.
8344         * ppc-linux-nat.c: Fix common/ includes.
8345         * parser-defs.h: Fix common/ includes.
8346         * osdata.c: Fix common/ includes.
8347         * obsd-nat.c: Fix common/ includes.
8348         * nat/x86-linux.c: Fix common/ includes.
8349         * nat/x86-linux-dregs.c: Fix common/ includes.
8350         * nat/x86-dregs.h: Fix common/ includes.
8351         * nat/x86-dregs.c: Fix common/ includes.
8352         * nat/ppc-linux.c: Fix common/ includes.
8353         * nat/mips-linux-watch.h: Fix common/ includes.
8354         * nat/mips-linux-watch.c: Fix common/ includes.
8355         * nat/linux-waitpid.c: Fix common/ includes.
8356         * nat/linux-ptrace.h: Fix common/ includes.
8357         * nat/linux-ptrace.c: Fix common/ includes.
8358         * nat/linux-procfs.c: Fix common/ includes.
8359         * nat/linux-personality.c: Fix common/ includes.
8360         * nat/linux-osdata.c: Fix common/ includes.
8361         * nat/linux-namespaces.c: Fix common/ includes.
8362         * nat/linux-btrace.h: Fix common/ includes.
8363         * nat/linux-btrace.c: Fix common/ includes.
8364         * nat/fork-inferior.c: Fix common/ includes.
8365         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8366         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8367         * nat/aarch64-linux.c: Fix common/ includes.
8368         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8369         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8370         * namespace.h: Fix common/ includes.
8371         * mips-linux-tdep.c: Fix common/ includes.
8372         * minsyms.c: Fix common/ includes.
8373         * mi/mi-parse.h: Fix common/ includes.
8374         * mi/mi-main.c: Fix common/ includes.
8375         * mi/mi-cmd-env.c: Fix common/ includes.
8376         * memrange.h: Fix common/ includes.
8377         * memattr.c: Fix common/ includes.
8378         * maint.h: Fix common/ includes.
8379         * maint.c: Fix common/ includes.
8380         * main.c: Fix common/ includes.
8381         * machoread.c: Fix common/ includes.
8382         * location.c: Fix common/ includes.
8383         * linux-thread-db.c: Fix common/ includes.
8384         * linux-nat.c: Fix common/ includes.
8385         * linux-fork.c: Fix common/ includes.
8386         * inline-frame.c: Fix common/ includes.
8387         * infrun.c: Fix common/ includes.
8388         * inflow.c: Fix common/ includes.
8389         * inferior.h: Fix common/ includes.
8390         * inferior.c: Fix common/ includes.
8391         * infcmd.c: Fix common/ includes.
8392         * inf-ptrace.c: Fix common/ includes.
8393         * inf-child.c: Fix common/ includes.
8394         * ia64-linux-nat.c: Fix common/ includes.
8395         * i387-tdep.c: Fix common/ includes.
8396         * i386-tdep.c: Fix common/ includes.
8397         * i386-linux-tdep.c: Fix common/ includes.
8398         * i386-linux-nat.c: Fix common/ includes.
8399         * i386-go32-tdep.c: Fix common/ includes.
8400         * i386-fbsd-tdep.c: Fix common/ includes.
8401         * i386-fbsd-nat.c: Fix common/ includes.
8402         * guile/scm-type.c: Fix common/ includes.
8403         * guile/guile.c: Fix common/ includes.
8404         * go32-nat.c: Fix common/ includes.
8405         * gnu-nat.c: Fix common/ includes.
8406         * gdbthread.h: Fix common/ includes.
8407         * gdbarch-selftests.c: Fix common/ includes.
8408         * gdb_usleep.c: Fix common/ includes.
8409         * gdb_select.h: Fix common/ includes.
8410         * gdb_bfd.c: Fix common/ includes.
8411         * gcore.c: Fix common/ includes.
8412         * fork-child.c: Fix common/ includes.
8413         * findvar.c: Fix common/ includes.
8414         * fbsd-nat.c: Fix common/ includes.
8415         * event-top.c: Fix common/ includes.
8416         * event-loop.c: Fix common/ includes.
8417         * dwarf2read.c: Fix common/ includes.
8418         * dwarf2loc.c: Fix common/ includes.
8419         * dwarf2-frame.c: Fix common/ includes.
8420         * dwarf-index-cache.c: Fix common/ includes.
8421         * dtrace-probe.c: Fix common/ includes.
8422         * disasm-selftests.c: Fix common/ includes.
8423         * defs.h: Fix common/ includes.
8424         * csky-tdep.c: Fix common/ includes.
8425         * cp-valprint.c: Fix common/ includes.
8426         * cp-support.h: Fix common/ includes.
8427         * cp-support.c: Fix common/ includes.
8428         * corelow.c: Fix common/ includes.
8429         * completer.h: Fix common/ includes.
8430         * completer.c: Fix common/ includes.
8431         * compile/compile.c: Fix common/ includes.
8432         * compile/compile-loc2c.c: Fix common/ includes.
8433         * compile/compile-cplus-types.c: Fix common/ includes.
8434         * compile/compile-cplus-symbols.c: Fix common/ includes.
8435         * command.h: Fix common/ includes.
8436         * cli/cli-dump.c: Fix common/ includes.
8437         * cli/cli-cmds.c: Fix common/ includes.
8438         * charset.c: Fix common/ includes.
8439         * build-id.c: Fix common/ includes.
8440         * btrace.h: Fix common/ includes.
8441         * btrace.c: Fix common/ includes.
8442         * breakpoint.h: Fix common/ includes.
8443         * breakpoint.c: Fix common/ includes.
8444         * ax.h:
8445         (enum agent_op): Fix common/ includes.
8446         * ax-general.c (struct aop_map): Fix common/ includes.
8447         * ax-gdb.c: Fix common/ includes.
8448         * auxv.c: Fix common/ includes.
8449         * auto-load.c: Fix common/ includes.
8450         * arm-tdep.c: Fix common/ includes.
8451         * arch/riscv.c: Fix common/ includes.
8452         * arch/ppc-linux-common.c: Fix common/ includes.
8453         * arch/i386.c: Fix common/ includes.
8454         * arch/arm.c: Fix common/ includes.
8455         * arch/arm-linux.c: Fix common/ includes.
8456         * arch/arm-get-next-pcs.c: Fix common/ includes.
8457         * arch/amd64.c: Fix common/ includes.
8458         * arch/aarch64.c: Fix common/ includes.
8459         * arch/aarch64-insn.c: Fix common/ includes.
8460         * arch-utils.c: Fix common/ includes.
8461         * amd64-windows-tdep.c: Fix common/ includes.
8462         * amd64-tdep.c: Fix common/ includes.
8463         * amd64-sol2-tdep.c: Fix common/ includes.
8464         * amd64-obsd-tdep.c: Fix common/ includes.
8465         * amd64-nbsd-tdep.c: Fix common/ includes.
8466         * amd64-linux-tdep.c: Fix common/ includes.
8467         * amd64-linux-nat.c: Fix common/ includes.
8468         * amd64-fbsd-tdep.c: Fix common/ includes.
8469         * amd64-fbsd-nat.c: Fix common/ includes.
8470         * amd64-dicos-tdep.c: Fix common/ includes.
8471         * amd64-darwin-tdep.c: Fix common/ includes.
8472         * agent.c: Fix common/ includes.
8473         * ada-lang.h: Fix common/ includes.
8474         * ada-lang.c: Fix common/ includes.
8475         * aarch64-tdep.c: Fix common/ includes.
8476
8477 2019-01-25  Tom Tromey  <tom@tromey.com>
8478
8479         * common/create-version.sh: Use common/version.h.
8480
8481 2019-01-24  Pedro Alves  <palves@redhat.com>
8482
8483         * infrun.c (signal_stop, signal_print, signal_program)
8484         (signal_catch, signal_pass): Now arrays instead of pointers.
8485         (update_signals_program_target, do_target_resume)
8486         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8487         * linux-nat.c (linux_nat_target::pass_signals)
8488         (linux_nat_target::create_inferior, linux_nat_target::attach):
8489         Adjust.
8490         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8491         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8492         * procfs.c (procfs_target::pass_signals): Adjust.
8493         * record-full.c (record_full_target::resume): Adjust.
8494         * remote.c (remote_target::pass_signals)
8495         (remote_target::program_signals): Adjust.
8496         * target-debug.h (target_debug_print_signals): Now takes a
8497         gdb::array_view as parameter.  Adjust.
8498         * target.h (target_ops) <pass_signals, program_signals>: Replace
8499         pointer and length parameters with gdb::array_view.
8500         (target_pass_signals, target_program_signals): Likewise.
8501         * target-delegates.c: Regenerate.
8502
8503 2019-01-24  Pedro Alves  <palves@redhat.com>
8504
8505         * common/forward-scope-exit.h
8506         (forward_scope_exit::forward_scope_exit): Pass arguments to
8507         m_bind_function directly, instead of creating a std::bind and
8508         copying that.
8509
8510 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8511
8512         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8513         for static members.
8514         (pass_in_v_vfp_candidate): Likewise.
8515
8516 2019-01-23  Tom Tromey  <tom@tromey.com>
8517             Pedro Alves  <palves@redhat.com>
8518
8519         * regcache.c (class regcache_invalidator): Remove.
8520         (regcache::raw_write): Use make_scope_exit.
8521
8522 2019-01-23  Tom Tromey  <tom@tromey.com>
8523
8524         * ui-out.h (class ui_out_emit_type): Update comment.
8525
8526 2019-01-23  Tom Tromey  <tom@tromey.com>
8527
8528         * infrun.c (fetch_inferior_event): Update comment.
8529
8530 2019-01-23  Tom Tromey  <tom@tromey.com>
8531             Pedro Alves  <palves@redhat.com>
8532
8533         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8534         parameter.
8535         (fetch_inferior_event): Use SCOPE_EXIT.
8536
8537
8538 2019-01-23  Tom Tromey  <tom@tromey.com>
8539             Pedro Alves  <palves@redhat.com>
8540
8541         * infrun.c (disable_thread_events): Delete.
8542         (stop_all_threads): Use SCOPE_EXIT.
8543
8544 2019-01-23  Tom Tromey  <tom@tromey.com>
8545             Pedro Alves  <palves@redhat.com>
8546
8547         * symfile.c: Include forward-scope-exit.h.
8548         (clear_symtab_users_cleanup): Replace forward declaration with
8549         a FORWARD_SCOPE_EXIT.
8550         (syms_from_objfile_1): Use the forward_scope_exit and
8551         gdb::optional instead of cleanup_function.
8552         (reread_symbols): Use the forward_scope_exit instead of
8553         cleanup_function.
8554         (clear_symtab_users_cleanup): Remove function.
8555
8556 2019-01-23  Tom Tromey  <tom@tromey.com>
8557             Pedro Alves  <palves@redhat.com>
8558
8559         * linux-nat.c: Include scope-exit.h.
8560         (cleanup_target_stop): Remove.
8561         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8562         SCOPE_EXIT.
8563
8564 2019-01-23  Tom Tromey  <tom@tromey.com>
8565             Pedro Alves  <palves@redhat.com>
8566
8567         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8568         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8569
8570 2019-01-23  Tom Tromey  <tom@tromey.com>
8571             Andrew Burgess  <andrew.burgess@embecosm.com>
8572             Pedro Alves  <palves@redhat.com>
8573
8574         * infrun.c (fetch_inferior_event): Use scope_exit.
8575         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8576         * top.c (execute_command): Use scope_exit.
8577         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8578         * utils.c (do_bpstat_clear_actions_cleanup)
8579         (make_bpstat_clear_actions_cleanup): Remove.
8580
8581 2019-01-23  Tom Tromey  <tom@tromey.com>
8582             Pedro Alves  <palves@redhat.com>
8583
8584         * infrun.c: Include "common/scope-exit.h"
8585         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8586         (wait_for_inferior): Use SCOPE_EXIT.
8587         (fetch_inferior_event): Use scope_exit.
8588
8589 2019-01-23  Tom Tromey  <tom@tromey.com>
8590             Pedro Alves  <palves@redhat.com>
8591
8592         * breakpoint.c (create_breakpoint): Remove cleanup.
8593
8594 2019-01-23  Tom Tromey  <tom@tromey.com>
8595             Andrew Burgess  <andrew.burgess@embecosm.com>
8596             Pedro Alves  <palves@redhat.com>
8597
8598 2019-01-23  Pedro Alves  <palves@redhat.com>
8599
8600         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8601
8602 2019-01-23  Pedro Alves  <palves@redhat.com>
8603             Andrew Burgess  <andrew.burgess@embecosm.com>
8604
8605         * gdbthread.h: Include "common/forward-scope-exit.h".
8606         (scoped_finish_thread_state): Redefine custom class in terms of
8607         forward_scope_exit.
8608
8609 2019-01-23  Pedro Alves  <palves@redhat.com>
8610             Andrew Burgess  <andrew.burgess@embecosm.com>
8611
8612         * common/forward-scope-exit.h: New file.
8613
8614 2019-01-23  Pedro Alves  <palves@redhat.com>
8615             Andrew Burgess  <andrew.burgess@embecosm.com>
8616             Tom Tromey  <tom@tromey.com>
8617
8618         * common/scope-exit.h: New file.
8619
8620 2019-01-23  Pedro Alves  <palves@redhat.com>
8621
8622         * common/preprocessor.h (ESC): Rename to ...
8623         (ESC_PARENS): ... this.
8624         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8625         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8626
8627 2019-01-23  Tom Tromey  <tom@tromey.com>
8628
8629         * language.h (class scoped_switch_to_sym_language_if_auto):
8630         Initialize m_lang in both cases.
8631
8632 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
8633
8634         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8635         with XCNEW.
8636
8637 2019-01-22  Tom Tromey  <tom@tromey.com>
8638
8639         * corelow.c: Do not include sys/file.h.
8640
8641 2019-01-22  Tom Tromey  <tom@tromey.com>
8642
8643         * tui/tui-wingeneral.h: Include gdb_curses.h.
8644
8645 2019-01-22  Tom Tromey  <tom@tromey.com>
8646
8647         * source-cache.h (class source_cache) <get_source_lines,
8648         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
8649
8650 2019-01-22  Tom Tromey  <tom@tromey.com>
8651
8652         * remote-fileio.h (struct remote_target): Declare.
8653
8654 2019-01-22  Tom Tromey  <tom@tromey.com>
8655
8656         * python/py-arch.c: Do not include py-ref.h.
8657         * python/py-bpevent.c: Do not include py-ref.h.
8658         * python/py-cmd.c: Do not include py-ref.h.
8659         * python/py-continueevent.c: Do not include py-ref.h.
8660         * python/py-event.h: Do not include py-ref.h.
8661         * python/py-evtregistry.c: Do not include py-ref.h.
8662         * python/py-finishbreakpoint.c: Do not include py-ref.h.
8663         * python/py-frame.c: Do not include py-ref.h.
8664         * python/py-framefilter.c: Do not include py-ref.h.
8665         * python/py-function.c: Do not include py-ref.h.
8666         * python/py-infevents.c: Do not include py-ref.h.
8667         * python/py-linetable.c: Do not include py-ref.h.
8668         * python/py-objfile.c: Do not include py-ref.h.
8669         * python/py-param.c: Do not include py-ref.h.
8670         * python/py-prettyprint.c: Do not include py-ref.h.
8671         * python/py-progspace.c: Do not include py-ref.h.
8672         * python/py-symbol.c: Do not include py-ref.h.
8673         * python/py-symtab.c: Do not include py-ref.h.
8674         * python/py-type.c: Do not include py-ref.h.
8675         * python/py-unwind.c: Do not include py-ref.h.
8676         * python/py-utils.c: Do not include py-ref.h.
8677         * python/py-value.c: Do not include py-ref.h.
8678         * python/py-varobj.c: Do not include py-ref.h.
8679         * python/py-xmethods.c: Do not include py-ref.h.
8680         * python/python.c: Do not include py-ref.h.
8681         * varobj.c: Do not include py-ref.h.
8682
8683 2019-01-22  Tom Tromey  <tom@tromey.com>
8684
8685         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
8686         keyword for bcache.
8687
8688 2019-01-22  Tom Tromey  <tom@tromey.com>
8689
8690         * compile/compile-cplus-types.c: Remove a comment by #include.
8691
8692 2019-01-22  Tom Tromey  <tom@tromey.com>
8693
8694         * compile/gcc-c-plugin.h: Include compile-internal.h.
8695
8696 2019-01-22  Tom Tromey  <tom@tromey.com>
8697
8698         * stabsread.c (EXTERN): Do not define.
8699         (symnum, next_symbol_text_func, processing_gcc_compilation)
8700         (within_function, global_sym_chain, global_stabs)
8701         (previous_stab_code, this_object_header_files)
8702         (n_this_object_header_files)
8703         (n_allocated_this_object_header_files): Define.
8704         * stabsread.h (EXTERN): Never define.  Use "extern".
8705
8706 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8707
8708         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
8709         history_value.
8710
8711 2019-01-21  Tom Tromey  <tom@tromey.com>
8712
8713         * ui-out.c: Fix includes.
8714         * tui/tui-source.c: Fix includes.
8715         * target.c: Fix includes.
8716         * remote.c: Fix includes.
8717         * regcache.c: Fix includes.
8718         * python/py-block.c: Fix includes.
8719         * printcmd.c: Fix includes.
8720         * or1k-tdep.c: Fix includes.
8721         * mi/mi-main.c: Fix includes.
8722         * m32r-tdep.c: Fix includes.
8723         * csky-tdep.c: Fix includes.
8724         * compile/compile-cplus-types.c: Fix includes.
8725         * cli/cli-interp.c: Fix includes.
8726
8727 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
8728
8729         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8730         for padding.
8731
8732 2019-01-16  Tom Tromey  <tom@tromey.com>
8733
8734         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
8735         earlier.
8736         (struct objfile) <msymbols_range>: Move from top level.
8737         <msymbols>: New method.
8738         (class objfile_msymbols): Remove.
8739         * symtab.c (default_collect_symbol_completion_matches_break_on):
8740         Update.
8741         * symmisc.c (dump_msymbols): Update.
8742         * stabsread.c (scan_file_globals): Update.
8743         * objc-lang.c (info_selectors_command, info_classes_command)
8744         (find_methods): Update.
8745         * minsyms.c (find_solib_trampoline_target): Update.
8746         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
8747         * coffread.c (coff_symfile_read): Update.
8748         * ada-lang.c (ada_lookup_simple_minsym)
8749         (ada_collect_symbol_completion_matches): Update.
8750
8751 2019-01-16  Tom Tromey  <tom@tromey.com>
8752
8753         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
8754         type.  Remove no-argument constructor.
8755         <iterator::operator++>: Simplify.
8756         <begin>: Update.
8757         <end>: Use minimal_symbol_count.
8758
8759 2019-01-16  Tom Tromey  <tom@tromey.com>
8760
8761         * objfiles.h (struct objfile) <psymtabs>: New method.
8762         (class objfile_psymtabs): Remove.
8763         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
8764         typedef.
8765         <range>: New method.
8766         (require_partial_symbols): Change return type.
8767         * psymtab.c (require_partial_symbols)
8768         (psym_expand_symtabs_matching): Update.
8769         * mdebugread.c (parse_partial_symbols): Update.
8770         * dbxread.c (dbx_end_psymtab): Update.
8771
8772 2019-01-15  Tom Tromey  <tom@tromey.com>
8773
8774         * symtab.c (lookup_objfile_from_block)
8775         (lookup_symbol_in_objfile_symtabs)
8776         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
8777         (find_line_symtab, info_sources_command)
8778         (default_collect_symbol_completion_matches_break_on)
8779         (make_source_files_completion_list): Update.
8780         * symmisc.c (print_objfile_statistics, dump_objfile)
8781         (maintenance_print_symbols, maintenance_info_symtabs)
8782         (maintenance_check_symtabs, maintenance_info_line_tables):
8783         Update.
8784         * source.c (select_source_symtab)
8785         (forget_cached_source_info_for_objfile): Update.
8786         * objfiles.h (class objfile_compunits): Remove.
8787         (struct objfile) <compunits_range>: New typedef.
8788         (compunits): New method.
8789         * objfiles.c (objfile_relocate1): Update.
8790         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8791         * maint.c (count_symtabs_and_blocks): Update.
8792         * linespec.c (iterate_over_all_matching_symtabs): Update.
8793         * cp-support.c (add_symbol_overload_list_qualified): Update.
8794         * coffread.c (coff_symtab_read): Update.
8795         * ada-lang.c (add_nonlocal_symbols)
8796         (ada_collect_symbol_completion_matches)
8797         (ada_add_global_exceptions): Update.
8798
8799 2019-01-15  Tom Tromey  <tom@tromey.com>
8800
8801         * progspace.h (program_space) <objfiles_safe_range>: New
8802         typedef.
8803         <objfiles_safe>: New method.
8804         * objfiles.h (class all_objfiles_safe): Remove.
8805         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
8806         * jit.c (jit_inferior_exit_hook): Update.
8807
8808 2019-01-17  Tom Tromey  <tom@tromey.com>
8809
8810         * progspace.h (program_space) <objfiles_range>: New typedef.
8811         <objfiles>: New method.
8812         <objfiles_head>: Rename from objfiles.
8813         (object_files): Update.
8814         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
8815         * guile/scm-pretty-print.c
8816         (ppscm_find_pretty_printer_from_objfiles): Update.
8817         * guile/scm-objfile.c (gdbscm_objfiles): Update.
8818         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
8819         Update.
8820         * python/py-progspace.c (pspy_get_objfiles): Update.
8821         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8822         Update.
8823         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8824         (objfpy_lookup_objfile_by_build_id): Update.
8825         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8826         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8827         Update.
8828         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8829         (expand_symtab_containing_pc, lookup_objfile_from_block)
8830         (lookup_static_symbol, basic_lookup_transparent_type)
8831         (find_pc_sect_compunit_symtab, find_symbol_at_address)
8832         (find_line_symtab, info_sources_command)
8833         (default_collect_symbol_completion_matches_break_on)
8834         (make_source_files_completion_list, find_main_name): Update.
8835         * symmisc.c (print_symbol_bcache_statistics)
8836         (print_objfile_statistics, maintenance_print_symbols)
8837         (maintenance_print_msymbols, maintenance_print_objfiles)
8838         (maintenance_info_symtabs, maintenance_check_symtabs)
8839         (maintenance_expand_symtabs, maintenance_info_line_tables):
8840         Update.
8841         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
8842         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
8843         (map_overlay_command, unmap_overlay_command)
8844         (simple_overlay_update, expand_symtabs_matching)
8845         (map_symbol_filenames): Update.
8846         * symfile-debug.c (set_debug_symfile): Update.
8847         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
8848         Update.
8849         * source.c (select_source_symtab, forget_cached_source_info):
8850         Update.
8851         * solib.c (solib_read_symbols): Update.
8852         * solib-spu.c (append_ocl_sos): Update.
8853         * psymtab.c (maintenance_print_psymbols)
8854         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
8855         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
8856         * printcmd.c (info_symbol_command): Update.
8857         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
8858         Update.
8859         * objfiles.h (class all_objfiles): Remove.
8860         * objfiles.c (have_partial_symbols, have_full_symbols)
8861         (have_minimal_symbols, qsort_cmp, update_section_map)
8862         (shared_objfile_contains_address_p)
8863         (default_iterate_over_objfiles_in_search_order): Update.
8864         * objc-lang.c (info_selectors_command, info_classes_command)
8865         (find_methods): Update.
8866         * minsyms.c (find_solib_trampoline_target): Update.
8867         * maint.c (maintenance_info_sections)
8868         (maintenance_translate_address, count_symtabs_and_blocks):
8869         Update.
8870         * main.c (captured_main_1): Update.
8871         * linux-thread-db.c (try_thread_db_load_from_pdir)
8872         (has_libpthread): Update.
8873         * linespec.c (iterate_over_all_matching_symtabs)
8874         (search_minsyms_for_name): Update.
8875         * jit.c (jit_find_objf_with_entry_addr): Update.
8876         * hppa-tdep.c (find_unwind_entry)
8877         (hppa_lookup_stub_minimal_symbol): Update.
8878         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
8879         Update.
8880         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8881         (elf_gnu_ifunc_resolve_by_got): Update.
8882         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
8883         * dwarf-index-write.c (save_gdb_index_command): Update.
8884         * cp-support.c (add_symbol_overload_list_qualified): Update.
8885         * breakpoint.c (create_overlay_event_breakpoint)
8886         (create_longjmp_master_breakpoint)
8887         (create_std_terminate_master_breakpoint)
8888         (create_exception_master_breakpoint): Update.
8889         * blockframe.c (find_pc_partial_function): Update.
8890         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
8891         (ada_collect_symbol_completion_matches)
8892         (ada_add_global_exceptions): Update.
8893
8894 2019-01-17  Tom Tromey  <tom@tromey.com>
8895
8896         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
8897         declare VEC.
8898         (solib_target_parse_libraries): Change return type.
8899         (library_list_start_segment, library_list_start_section)
8900         (library_list_end_library, library_list_start_library); Update.
8901         (solib_target_free_library_list): Remove.
8902         (solib_target_parse_libraries): Remove cleanup.  Change return
8903         type.
8904         (solib_target_current_sos): Update.
8905
8906 2019-01-17  Tom Tromey  <tromey@bapiya>
8907
8908         * valprint.c: Replace "the the" with "the".
8909         * symtab.c: Replace "the the" with "the".
8910         * solib.c: Replace "the the" with "the".
8911         * solib-dsbt.c: Replace "the the" with "the".
8912         * linespec.c: Replace "the the" with "the".
8913         * dwarf2loc.h: Replace "the the" with "the".
8914         * amd64-windows-tdep.c: Replace "the the" with "the".
8915         * aarch64-tdep.c: Replace "the the" with "the".
8916
8917 2019-01-16  Keith Seitz  <keiths@redhat.com>
8918
8919         PR gdb/23773
8920         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
8921         <builder>: Rename to ..
8922         <m_builder>: ... this and make private.
8923         (dwarf2_cu::get_builder): New method.  Change all users of
8924         `builder' to use this method.
8925         (dwarf2_start_symtab): Move to ...
8926         (dwarf2_cu::start_symtab): ... here.  Update all callers
8927         (setup_type_unit_groups): Move to ...
8928         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
8929         callers.
8930         (dwarf2_cu::reset_builder): New method.
8931         (process_full_compunit, process_full_type_unit): Use
8932         dwarf2_cu::reset_builder.
8933         (follow_die_offset): Record the ancestor CU if it is different
8934         from the followed DIE's CU.
8935         (follow_die_sig_1): Likewise.
8936
8937 2019-01-15  Tom Tromey  <tom@tromey.com>
8938
8939         * remote.c (class remote_state) <buf>: Now a char_vector.
8940         <buf_size>: Remove.
8941         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
8942         parameter.
8943         (remote_target::getpkt_or_notif_sane_1)
8944         (remote_target::getpkt_sane)
8945         (remote_target::getpkt_or_notif_sane): Likewise.
8946         (class remote_target) <putpkt>: New overload.
8947         (remote_target::read_frame): Change type of "buf_p".  Remove
8948         sizeof_p parameter.
8949         (packet_ok): New overload.
8950         (packet_check_result): New overload.
8951         Update all uses.
8952
8953 2019-01-14  Tom Tromey  <tom@tromey.com>
8954
8955         * remote-notif.c (handle_notification, remote_notif_ack)
8956         (remote_notif_parse): Make "buf" const.
8957         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
8958         const.
8959         (remote_notif_parse, remote_notif_ack, handle_notification):
8960         Likewise.
8961         * remote.c (remote_notif_stop_parse): Make "buf" const.
8962         (remote_target::remote_parse_stop_reply): Make "buf" const.
8963         (remote_notif_stop_ack): Make "buf" const.
8964
8965 2019-01-14  Tom Tromey  <tom@tromey.com>
8966
8967         * remote.c (remote_console_output): Make parameter const.
8968
8969 2019-01-14  Tom Tromey  <tom@tromey.com>
8970
8971         * target-debug.h (target_debug_print_signals): Constify.
8972         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
8973         * procfs.c (procfs_target::pass_signals): Update.
8974         * linux-nat.c (linux_nat_target::pass_signals): Update.
8975         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
8976         * target-delegates.c: Rebuild.
8977         * remote.c (remote_target::program_signals): Update.
8978         (remote_target::pass_signals): Update.
8979         * target.c (target_pass_signals): Constify argument.
8980         (target_program_signals): Likewise.
8981         * target.h (struct target_ops) <pass_signals, program_signals>:
8982         Constify argument.
8983         (target_pass_signals, target_program_signals): Constify argument.
8984
8985 2019-01-14  Tom Tromey  <tom@tromey.com>
8986
8987         PR tui/28819:
8988         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
8989
8990 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
8991
8992         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
8993         field.
8994         * rs6000-tdep.c: Include reggroups.h.
8995         (IS_V_ALIAS_PSEUDOREG): Define.
8996         (rs6000_register_name): Return names for the "vX" aliases.
8997         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
8998         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
8999         aliases.  Call default_register_reggroup_p for all other
9000         pseudo-registers.
9001         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9002         New functions.
9003         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9004         Handle "vX" aliases.
9005         (v_alias_pseudo_register_collect): New function.
9006         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9007         (rs6000_gdbarch_init): Initialize "vX" aliases as
9008         pseudo-registers.  Restore registration of
9009         rs6000_pseudo_register_reggroup_p with
9010         set_tdesc_pseudo_register_reggroup_p.
9011
9012 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9013
9014         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9015         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9016         set_gdbarch_num_pseudo_regs.
9017
9018 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9019
9020         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9021         Remove arg prefixname, add do_set and do_show.
9022         Add member functions set_list and show_list.
9023         * cli/cli-style.c (class cli_style_option): Update accordingly.
9024         (style_set_list): Move to file scope.
9025         (style_show_list): Likewise.
9026         (set_style): Call help_list.
9027         (show_style): Call cmd_show_list.
9028         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9029         Update to use the new macro.
9030
9031 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9032
9033         * ada-lang.c (_initialize_ada_language): Expand the help text
9034         for the "catch exception" command.
9035
9036 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9037
9038         * symtab.c (matching_obj_sections): Initialize obj,
9039         declare it closer to its usage.
9040
9041 2019-01-10  Tom Tromey  <tom@tromey.com>
9042
9043         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9044         (basic_inf_threads_range): Remove.
9045         (inf_threads_range, inf_non_exited_threads_range)
9046         (safe_inf_threads_range): Use next_adapter.
9047
9048 2019-01-10  Keith Seitz  <keiths@redhat.com>
9049
9050         PR gdb/23712
9051         PR symtab/23010
9052         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9053         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9054
9055 2019-01-10  Keith Seitz  <keiths@redhat.com>
9056
9057         PR gdb/23712
9058         PR symtab/23010
9059         * dictionary.c (pending_to_vector): Remove.
9060         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9061         Remove _1 suffix, replacing functions of the same name.  Update
9062         all callers.
9063         (dict_create_hashed, dict_create_hashed_expandable)
9064         (dict_create_linear, dict_create_linear_expandable, dict_free)
9065         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9066         Make functions static.
9067
9068 2019-01-10  Keith Seitz  <keiths@redhat.com>
9069
9070         PR gdb/23712
9071         PR symtab/23010
9072         * dictionary.h (struct dictionary): Replace declaration with
9073         multidictionary.
9074         (dict_create_hashed, dict_create_hashed_expandable)
9075         (dict_create_linear, dict_create_linear_expandable)
9076         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9077         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9078         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9079         taking multidictionary argument.
9080         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9081         * block.h (struct block) <dict>: Change to multidictionary
9082         and rename `multidict'.
9083         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9084         symmisc.c: Update all dictionary references to multidictionary.
9085
9086 2019-01-10  Keith Seitz  <keiths@redhat.com>
9087
9088         PR gdb/23712
9089         PR symtab/23010
9090         * dictionary.c: Include unordered_map.
9091         (pending_to_vector): New function.
9092         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9093         Rewrite the non-"_1" functions to take vector instead
9094         of linked list.
9095         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9096         "new" _1 versions of the same name.
9097         (multidictionary): Define.
9098         (std::hash<enum language): New definition.
9099         (collate_pending_symbols_by_language, mdict_create_hashed)
9100         (mdict_create_hashed_expandable, mdict_create_linear)
9101         (mdict_create_linear_expandable, mdict_free)
9102         (find_language_dictionary, create_new_language_dictionary)
9103         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9104         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9105         (mdict_size, mdict_empty): New functions.
9106         * dictionary.h (mdict_iterator): Define.
9107
9108 2019-01-10  Pedro Alves  <palves@redhat.com>
9109
9110         * breakpoint.c (read_uploaded_action)
9111         (create_tracepoint_from_upload): Adjust to use
9112         gdb::unique_xmalloc_ptr.
9113         * ctf.c (ctf_write_uploaded_tp):
9114         (SET_ARRAY_FIELD): Use emplace_back.
9115         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9116         * tracefile-tfile.c (tfile_write_uploaded_tp):
9117         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9118         gdb::unique_xmalloc_ptr.
9119         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9120         at_string, cond_string, cmd_strings>: Replace char pointers
9121         with gdb::unique_xmalloc_ptr.
9122
9123 2019-01-10  Pedro Alves  <palves@redhat.com>
9124
9125         * solib-target.c (library_list_start_library): Don't xstrdup name.
9126
9127 2019-01-10  Pedro Alves  <palves@redhat.com>
9128
9129         * mdebugread.c (parse_partial_symbols): Use
9130         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9131
9132 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9133
9134         * linux-fork.c (scoped_switch_fork_info)
9135         <~scoped_switch_fork_info>: Fix incorrect variable name.
9136
9137 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9138
9139         * linux-fork.c (scoped_switch_fork_info)
9140         <scoped_switch_fork_info>: Make explicit.
9141         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9142
9143 2019-01-10  Tom Tromey  <tom@tromey.com>
9144
9145         * objfiles.h (objfile::reset_psymtabs): Update.
9146         * objfiles.c (objfile::objfile): Update.
9147         * psymtab.h (psymtab_storage::obstack): Update.
9148         (psymtab_storage::m_obstack): Use gdb::optional.
9149         (class psymtab_storage): Update comment.  Remove objfile
9150         parameter.
9151         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9152
9153 2019-01-10  Tom Tromey  <tom@tromey.com>
9154
9155         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9156         <free_psymtabs>: Now private.
9157         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9158         (allocate_psymtab): Use new method.
9159
9160 2019-01-10  Tom Tromey  <tom@tromey.com>
9161
9162         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9163         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9164         * mdebugread.c (parse_partial_symbols): Use
9165         allocate_dependencies.
9166         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9167         allocate_dependencies.
9168         (process_psymtab_comp_unit_reader)
9169         (build_type_psymtab_dependencies): Likewise.
9170         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9171
9172 2019-01-10  Tom Tromey  <tom@tromey.com>
9173
9174         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9175         PSYMBOL_SET_LANGUAGE.
9176         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9177
9178 2019-01-10  Tom Tromey  <tom@tromey.com>
9179
9180         * psymtab.h (psymtab_storage::obstack): New method.
9181         <m_obstack>: Rename from obstack; now private.
9182         * psymtab.c (psymtab_storage): Update.
9183         * dwarf2read.c (create_addrmap_from_index)
9184         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9185         Update.
9186
9187 2019-01-10  Tom Tromey  <tom@tromey.com>
9188
9189         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9190         * objfiles.h (objfile::reset_psymtabs): New method.
9191
9192 2019-01-10  Tom Tromey  <tom@tromey.com>
9193
9194         * symmisc.c (print_symbol_bcache_statistics): Update.
9195         (print_objfile_statistics): Update.
9196         * symfile.c (reread_symbols): Update.
9197         * psymtab.h (class psymtab_storage): New.
9198         * psymtab.c (psymtab_storage): New constructor.
9199         (~psymtab_storage): New destructor.
9200         (require_partial_symbols): Update.
9201         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9202         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9203         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9204         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9205         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9206         (start_psymtab_common, end_psymtab_common)
9207         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9208         (allocate_psymtab): Update.
9209         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9210         Update.
9211         (dump_psymtab_addrmap, maintenance_print_psymbols)
9212         (maintenance_check_psymtabs): Update.
9213         (class objfile_psymtabs): Move to objfiles.h.
9214         * psympriv.h (discard_psymtab): Now inline.
9215         (psymtab_discarder::psymtab_discarder): Update.
9216         (psymtab_discarder::~psymtab_discarder): Update.
9217         (ALL_OBJFILE_PSYMTABS): Rewrite.
9218         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9219         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9220         Remove fields.
9221         <partial_symtabs>: New field.
9222         (class objfile_psymtabs): Move from psymtab.h.  Update.
9223         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9224         psymbol_cache.
9225         (objfile::~objfile): Don't destroy psymbol_cache.
9226         * mdebugread.c (parse_partial_symbols): Update.
9227         * dwarf2read.c (create_addrmap_from_index)
9228         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9229         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9230         (add_partial_subprogram, dwarf2_ranges_read): Update.
9231         * dwarf-index-write.c (write_address_map)
9232         (write_one_signatured_type, recursively_write_psymbols)
9233         (class debug_names, class debug_names, write_psymtabs_to_index):
9234         Update.
9235
9236 2019-01-10  Tom Tromey  <tom@tromey.com>
9237
9238         * symtab.h (SYMBOL_SET_NAMES): Update.
9239         (symbol_set_names): Update.
9240         (MSYMBOL_SET_NAMES): Update.
9241         * symtab.c (symbol_set_names): Change argument to be an
9242         objfile_per_bfd_storage.
9243         * psymtab.c (add_psymbol_to_bcache): Update.
9244         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9245
9246 2019-01-10  Tom Tromey  <tom@tromey.com>
9247
9248         * symtab.c (create_demangled_names_hash): Change argument to be an
9249         objfile_per_bfd_storage.
9250         (symbol_set_names): Update.
9251
9252 2019-01-10  Tom Tromey  <tom@tromey.com>
9253
9254         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9255         init_psymbol_list.
9256         * psymtab.c (init_psymbol_list): Do nothing if already called.
9257         * psympriv.h (init_psymbol_list): Add comment.
9258         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9259         init_psymbol_list.
9260         * dbxread.c (dbx_symfile_read): Unconditionally call
9261         init_psymbol_list.
9262
9263 2019-01-10  Tom Tromey  <tom@tromey.com>
9264
9265         * xcoffread.c (scan_xcoff_symtab): Update.
9266         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9267         "where".
9268         * mdebugread.c (parse_partial_symbols)
9269         (handle_psymbol_enumerators): Update.
9270         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9271         * dbxread.c (read_dbx_symtab): Update.
9272         * psympriv.h (psymbol_placement): New enum.
9273         (add_psymbol_to_list): Update.
9274
9275 2019-01-10  Tom Tromey  <tom@tromey.com>
9276
9277         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9278         static_psymbols parameters.
9279         (scan_xcoff_symtab): Update.
9280         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9281         static_psymbols parameters.
9282         * psympriv.h (start_psymtab_common): Update.
9283         * mdebugread.c (parse_partial_symbols): Update.
9284         * dwarf2read.c (create_partial_symtab): Update.
9285         * dbxread.c (read_dbx_symtab): Update.
9286         (start_psymtab): Remove global_psymbols and static_psymbols
9287         parameters.
9288
9289 2019-01-10  Tom Tromey  <tom@tromey.com>
9290
9291         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9292         * psymtab.c (allocate_psymtab): Add comment.
9293         * psympriv.h (allocate_psymtab): Add comment.
9294         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9295         initializations.
9296         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9297
9298 2019-01-10  Tom Tromey  <tom@tromey.com>
9299
9300         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9301         Don't declare.
9302         * mipsread.c: Include mdebugread.h.
9303         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9304         Declare.
9305         * elfread.c: Include mdebugread.h.
9306
9307 2019-01-09  Tom Tromey  <tom@tromey.com>
9308
9309         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9310         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9311         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9312         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9313         (psym_lookup_symbol, psym_find_last_source_symtab)
9314         (psym_forget_cached_source_info, psym_print_stats)
9315         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9316         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9317         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9318         (psym_find_compunit_symtab_by_address)
9319         (maintenance_print_psymbols, maintenance_info_psymtabs)
9320         (maintenance_check_psymtabs): Use ranged for.
9321         * psymtab.h (class objfile_psymtabs): New.
9322         (require_partial_symbols): Return objfile_psymtabs.
9323         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9324
9325 2019-01-09  Tom Tromey  <tom@tromey.com>
9326
9327         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9328         (find_pc_mapped_section, list_overlays_command)
9329         (map_overlay_command, unmap_overlay_command)
9330         (simple_overlay_update): Use all_objfiles.
9331         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9332         * printcmd.c (info_symbol_command): Use all_objfiles.
9333         * objfiles.h (ALL_OBJSECTIONS): Remove.
9334         * maint.c (maintenance_translate_address): Use all_objfiles.
9335         * gcore.c (gcore_create_callback): Use all_objfiles.
9336         (objfile_find_memory_regions): Likewise.
9337
9338 2019-01-09  Tom Tromey  <tom@tromey.com>
9339
9340         * symtab.c (find_line_symtab, info_sources_command)
9341         (make_source_files_completion_list): Use objfile_compunits.
9342         * source.c (select_source_symtab): Use objfile_compunits.
9343         * objfiles.h (struct objfile): Update comment.
9344         (ALL_OBJFILES): Remove.
9345         (ALL_FILETABS): Remove.
9346         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9347         objfile_compunits.
9348
9349 2019-01-09  Tom Tromey  <tom@tromey.com>
9350
9351         * symmisc.c (print_objfile_statistics, dump_objfile)
9352         (maintenance_print_symbols): Use compunit_filetabs.
9353         * source.c (forget_cached_source_info_for_objfile): Use
9354         compunit_filetabs.
9355         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9356         (ALL_FILETABS): Use compunit_filetabs.
9357         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9358         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9359
9360 2019-01-09  Tom Tromey  <tom@tromey.com>
9361
9362         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9363         (compunit_filetabs): New.
9364         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9365         compunit_filetabs.
9366         (info_sources_command, make_source_files_completion_list): Remove
9367         declaration.
9368         * symmisc.c (print_objfile_statistics, dump_objfile)
9369         (maintenance_print_symbols): Remove declaration.
9370         (maintenance_info_symtabs): Use compunit_filetabs.
9371         (maintenance_info_line_tables): Likewise.
9372         * source.c (select_source_symtab): Change local variable name.
9373         (forget_cached_source_info_for_objfile): Remove declaration.
9374         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9375         * objfiles.c (objfile_relocate1): Remove declaration.
9376         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9377         declaration.
9378         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9379         * coffread.c (coff_symtab_read): Remove declaration.
9380         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9381         compunit_filetabs.
9382
9383 2019-01-09  Tom Tromey  <tom@tromey.com>
9384
9385         * symtab.c (lookup_objfile_from_block)
9386         (find_pc_sect_compunit_symtab, search_symbols)
9387         (default_collect_symbol_completion_matches_break_on): Use
9388         objfile_compunits.
9389         * objfiles.h (ALL_COMPUNITS): Remove.
9390         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9391         * cp-support.c (add_symbol_overload_list_qualified): Use
9392         objfile_compunits.
9393         * ada-lang.c (ada_collect_symbol_completion_matches)
9394         (ada_add_global_exceptions): Use objfile_compunits.
9395
9396 2019-01-09  Tom Tromey  <tom@tromey.com>
9397
9398         * source.c (select_source_symtab)
9399         (forget_cached_source_info_for_objfile): Remove declaration.
9400         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9401         declaration.
9402         * maint.c (count_symtabs_and_blocks): Remove declaration.
9403         * cp-support.c (add_symbol_overload_list_qualified): Remove
9404         declaration.
9405         * coffread.c (coff_symtab_read): Remove declaration.
9406         * symtab.c (lookup_symbol_in_objfile_symtabs)
9407         (basic_lookup_transparent_type_1): Use objfile_compunits.
9408         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9409         (info_sources_command, search_symbols)
9410         (default_collect_symbol_completion_matches_break_on)
9411         (make_source_files_completion_list): Remove declaration.
9412         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9413         (ada_collect_symbol_completion_matches)
9414         (ada_add_global_exceptions): Remove declaration.
9415         * linespec.c (iterate_over_all_matching_symtabs): Use
9416         objfile_compunits.
9417         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9418         (class objfile_compunits): New.
9419         (ALL_COMPUNITS): Use objfile_compunits.
9420         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9421         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9422         objfile_compunits.
9423         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9424
9425 2019-01-09  Tom Tromey  <tom@tromey.com>
9426
9427         * symtab.c (search_symbols)
9428         (default_collect_symbol_completion_matches_break_on): Use
9429         objfile_msymbols.
9430         * ada-lang.c (ada_lookup_simple_minsym)
9431         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9432         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9433         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9434         objfile_msymbols.
9435         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9436         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9437         * objc-lang.c (find_methods): Use objfile_msymbols.
9438         (info_selectors_command, info_classes_command): Likewise.
9439         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9440         * objfiles.h (class objfile_msymbols): New.
9441         (ALL_OBJFILE_MSYMBOLS): Remove.
9442         (ALL_MSYMBOLS): Remove.
9443
9444 2019-01-09  Tom Tromey  <tom@tromey.com>
9445
9446         * common/next-iterator.h (next_adapter): Add Iterator template
9447         parameter.
9448         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9449         (class all_objfiles_safe): New.
9450         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9451         * objfiles.c (put_objfile_before): Update comment.
9452         (add_separate_debug_objfile): Likewise.
9453         (free_all_objfiles): Use all_objfiles_safe.
9454         (objfile_purge_solibs): Likewise.
9455
9456 2019-01-09  Tom Tromey  <tom@tromey.com>
9457
9458         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9459         (expand_symtab_containing_pc, lookup_static_symbol)
9460         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9461         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9462         all_objfiles.
9463         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9464         * breakpoint.c (create_overlay_event_breakpoint)
9465         (create_longjmp_master_breakpoint)
9466         (create_std_terminate_master_breakpoint)
9467         (create_exception_master_breakpoint): Use all_objfiles.
9468         * linux-thread-db.c (try_thread_db_load_from_pdir)
9469         (has_libpthread): Use all_objfiles.
9470         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9471         * linespec.c (iterate_over_all_matching_symtabs)
9472         (search_minsyms_for_name): Use all_objfiles.
9473         * maint.c (maintenance_info_sections): Use all_objfiles.
9474         * main.c (captured_main_1): Use all_objfiles.
9475         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9476         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9477         * guile/scm-pretty-print.c
9478         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9479         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9480         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9481         (maintenance_print_msymbols): Use all_objfiles.
9482         * source.c (select_source_symtab): Use all_objfiles.
9483         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9484         * symfile.c (remove_symbol_file_command)
9485         (expand_symtabs_matching, map_symbol_filenames): Use
9486         all_objfiles.
9487         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9488         all_objfiles.
9489         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9490         * objc-lang.c (find_methods): Use all_objfiles.
9491         * objfiles.c (have_partial_symbols, have_full_symbols)
9492         (have_minimal_symbols, qsort_cmp)
9493         (default_iterate_over_objfiles_in_search_order): Use
9494         all_objfiles.
9495         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9496         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9497         (maintenance_check_psymtabs): Use all_objfiles.
9498         (ALL_PSYMTABS): Remove.
9499         * compile/compile-object-run.c (do_module_cleanup): Use
9500         all_objfiles.
9501         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9502         * cp-support.c (add_symbol_overload_list_qualified): Use
9503         all_objfiles.
9504         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9505         Use all_objfiles.
9506         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9507         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9508         all_objfiles.
9509         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9510         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9511         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9512         Uses all_objfiles.
9513         * solib.c (solib_read_symbols): Use all_objfiles
9514
9515 2019-01-09  Tom Tromey  <tom@tromey.com>
9516
9517         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9518         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9519         all_objfiles.
9520         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9521         * symmisc.c (print_symbol_bcache_statistics)
9522         (print_objfile_statistics, maintenance_print_objfiles)
9523         (maintenance_info_symtabs, maintenance_check_symtabs)
9524         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9525         all_objfiles.
9526         * source.c (forget_cached_source_info): Use all_objfiles.
9527         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9528         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9529         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9530         * objfiles.c (update_section_map): Use all_objfiles.
9531         (shared_objfile_contains_address_p): Likewise.
9532         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9533         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9534
9535 2019-01-09  Tom Tromey  <tom@tromey.com>
9536
9537         * common/next-iterator.h: New file.
9538         * objfiles.h (class all_objfiles): New.
9539         (struct objfile_iterator): New.
9540
9541 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9542
9543         * NEWS: Move the description of the changed "frame", "select-frame",
9544          and "info frame" commands to the Changed commands section.
9545
9546 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9547
9548         * gdbtypes.c (check_stub_method_group): Remove handling of old
9549         mangling schemes.
9550         * linespec.c (find_methods): Likewise.
9551         * stabsread.c (read_member_functions): Likewise.
9552         * valops.c (search_struct_method): Likewise.
9553         (value_struct_elt_for_reference): Likewise.
9554         * NEWS: Mention this change.
9555
9556 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9557
9558         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9559         print_source_lines.
9560         * source.c (print_source_lines_base): Update line number check.
9561         (print_source_lines): New function.
9562         (source_lines_range::source_lines_range): New function.
9563         * source.h (class source_lines_range): New class.
9564         (print_source_lines): New declaration.
9565
9566 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9567
9568         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9569
9570 2019-01-08  Tom Tromey  <tom@tromey.com>
9571             Simon Marchi  <simon.marchi@ericsson.com>
9572
9573         PR gdb/24060
9574         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9575         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9576         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9577         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9578         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9579         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9580
9581 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9582
9583         * source.c (select_source_symtab): Move header comment to
9584         declaration in source.h.
9585         (forget_cached_source_info_for_objfile): Likewise.
9586         (forget_cached_source_info): Likewise.
9587         (identify_source_line): Likewise.
9588         * source.h (identify_source_line): Move declaration from symtab.h
9589         and add comment from source.c
9590         (print_source_lines): Likewise.
9591         (forget_cached_source_info_for_objfile): Likewise.
9592         (forget_cached_source_info): Likewise.
9593         (select_source_symtab): Likewise.
9594         (enum print_source_lines_flag): Move definition from symtab.h.
9595         * symtab.h (identify_source_line): Move declaration to source.h.
9596         (print_source_lines): Likewise.
9597         (forget_cached_source_info_for_objfile): Likewise.
9598         (forget_cached_source_info): Likewise.
9599         (select_source_symtab): Likewise.
9600         (enum print_source_lines_flag): Move definition to source.h.
9601         * tui/tui-hooks.c: Add 'source.h' include.
9602
9603 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9604
9605         * source.c (print_source_lines_base): Handle requests to print
9606         reverse line number sequences, and guard against empty lines
9607         string.
9608
9609 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9610
9611         * source.c (print_source_lines_base): Fix skip of '\r' if next
9612         character is '\n'.
9613
9614 2019-01-06  Tom Tromey  <tom@tromey.com>
9615
9616         * c-exp.y (struct c_parse_state) <macro_original_text,
9617         expansion_obstack>: New member.
9618         (macro_original_text, expansion_obstack): Remove globals.
9619         (scan_macro_expansion, scanning_macro_expansion)
9620         (finished_macro_expansion): Update.
9621         (scan_macro_cleanup): Remove.
9622         (yylex, c_parse): Update.
9623
9624 2019-01-06  Tom Tromey  <tom@tromey.com>
9625
9626         * c-exp.y (struct c_parse_state) <strings>: New member.
9627         (operator_stoken): Update.
9628
9629 2019-01-06  Tom Tromey  <tom@tromey.com>
9630
9631         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9632         (union type_stack_elt) <typelist_val>: Now a pointer to
9633         std::vector.
9634         (type_stack_cleanup): Don't declare.
9635         (push_typelist): Update.
9636         * parse.c (pop_typelist): Return a std::vector.
9637         (push_typelist): Take a std::vector.
9638         (follow_types): Update.  Do not free args.
9639         (type_stack_cleanup): Remove.
9640         * c-exp.y (struct c_parse_state): New.
9641         (cpstate): New global.
9642         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
9643         (nonempty_typelist): Update.
9644         (func_mod): Create a new vector.
9645         (c_parse): Create a c_parse_state.
9646         (check_parameter_typelist): Do not delete params.
9647         (function_method): Update.  Do not delete type_list.
9648
9649 2019-01-06  Tom Tromey  <tom@tromey.com>
9650
9651         PR gdb/28155:
9652         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
9653         check_typedef.
9654         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
9655         (print_return_value): Likewise.
9656
9657 2019-01-05  Tom Tromey  <tom@tromey.com>
9658
9659         * contrib/cleanup_check.py: Remove.
9660         * contrib/gcc-with-excheck: Remove.
9661         * contrib/exsummary.py: Remove.
9662         * contrib/excheck.py: Remove.
9663
9664 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
9665
9666         * thread.c (delete_thread_1): Add gdb_assert that THR is not
9667         NULL. Initialize tpprev to NULL instead of assigning it
9668         to NULL on the next statement.
9669         * windows-nat.c (windows_delete_thread): Remove check for
9670         main_thread_id before printing thread exit notifications.
9671         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
9672         Remove thread ID check against main_thread_id.
9673         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
9674         windows_delete_thread.
9675         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
9676
9677 2019-01-04  Tom Tromey  <tom@tromey.com>
9678
9679         * compile/compile.c (_initialize_compile): Use upper case for
9680         metasyntactic variables.
9681         * symmisc.c (_initialize_symmisc): Use upper case for
9682         metasyntactic variables.
9683         * psymtab.c (_initialize_psymtab): Use upper case for
9684         metasyntactic variables.
9685         * demangle.c (demangle_command): Use upper case for metasyntactic
9686         variables.
9687         (_initialize_demangler): Likewise.
9688         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
9689         variables.
9690
9691 2019-01-03  Tom Tromey  <tom@tromey.com>
9692
9693         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
9694
9695 2019-01-03  Tom Tromey  <tom@tromey.com>
9696
9697         * python/py-symtab.c (salpy_str): Update.
9698         (struct salpy_sal_object) <symtab>: Now a PyObject.
9699         (salpy_dealloc): Update.
9700         (del_objfile_sal): Use gdbpy_ref.
9701
9702 2019-01-03  Tom Tromey  <tom@tromey.com>
9703
9704         * python/py-type.c (convert_field): Use new_reference.  Return
9705         gdbpy_ref.
9706         (make_fielditem): Return gdbpy_ref.
9707         (typy_fields): Update.
9708         (typy_getitem): Update.
9709         (field_name): Return gdbpy_ref.  Use new_reference.
9710         (typy_iterator_iternext): Update.
9711
9712 2019-01-03  Tom Tromey  <tom@tromey.com>
9713
9714         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
9715
9716 2019-01-03  Tom Tromey  <tom@tromey.com>
9717
9718         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
9719         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
9720         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
9721         (pspy_set_frame_filters, pspy_set_frame_unwinders)
9722         (pspy_set_type_printers): Likewise.
9723         * python/py-function.c (fnpy_init): Use gdbpy_ref.
9724         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
9725         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
9726         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
9727         (objfpy_set_type_printers): Likewise.
9728
9729 2019-01-03  Tom Tromey  <tom@tromey.com>
9730
9731         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
9732         (gdbpy_print_stack): Use gdbpy_err_fetch.
9733         * python/python-internal.h (class gdbpy_err_fetch): New class.
9734         (class gdbpy_enter) <m_error_type, m_error_value,
9735         m_error_traceback>: Remove.
9736         <m_error>: New member.
9737         (gdbpy_exception_to_string): Don't declare.
9738         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
9739         * python/py-value.c (convert_value_from_python): Use
9740         gdbpy_err_fetch.
9741         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
9742         gdbpy_exception_to_string.
9743         (gdbpy_handle_exception): Use gdbpy_err_fetch.
9744         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
9745         gdbpy_err_fetch.
9746
9747 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9748
9749         * linux-nat.c (delete_lwp_cleanup): Delete.
9750         (struct lwp_deleter): New struct.
9751         (lwp_info_up): New typedef.
9752         (linux_nat_target::follow_fork): Delete cleanup, and make use of
9753         lwp_info_up.
9754
9755 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9756
9757         * linux-fork.c (class scoped_switch_fork_info): New class.
9758         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
9759
9760 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9761
9762         * valops.c (find_overload_match): Remove use of null_cleanup, and
9763         calls to do_cleanups.
9764
9765 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9766
9767         * compile/compile-cplus-types.c
9768         (compile_cplus_instance::decl_name): Handle changes to
9769         cp_func_name.
9770         * cp-support.c (cp_func_name): Update header comment, update
9771         return type.
9772         * cp-support.h (cp_func_name): Update return type in declaration.
9773         * valops.c (find_overload_match): Move temp_func local to top
9774         level of function and change its type.  Use temp_func to hold and
9775         delete temporary string obtained from cp_func_name.
9776
9777 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9778
9779         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
9780         gdb::char_vector, remove cleanup, and update uses of `msg`.
9781
9782 2019-01-03  Jim Wilson  <jimw@sifive.com>
9783
9784         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
9785
9786 2019-01-02  Tom Tromey  <tom@tromey.com>
9787
9788         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
9789         (tdesc_parse_xml): Remove cleanups.
9790         * target-descriptions.h (make_cleanup_free_target_description):
9791         Don't declare.
9792         (target_desc_deleter): New struct.
9793         (target_desc_up): New typedef.
9794         * target-descriptions.c (target_desc_deleter::operator()): Rename
9795         from free_target_description.
9796         (make_cleanup_free_target_description): Remove.
9797
9798 2019-01-02  Tom Tromey  <tom@tromey.com>
9799
9800         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
9801         constructor, destructor.
9802         (linespec_parser): Remove typedef.
9803         (~linespec_parser): Rename from linespec_parser_delete.
9804         (linespec_lex_to_end, linespec_complete_label)
9805         (linespec_complete): Update.
9806         (decode_line_full): Remove cleanups.
9807         (decode_line_1): Update.
9808
9809 2019-01-02  Tom Tromey  <tom@tromey.com>
9810
9811         * python/python-internal.h (inferior_to_inferior_object): Change
9812         return type.
9813         * python/py-exitedevent.c (create_exited_event_object): Update.
9814         * python/py-inferior.c (inferior_to_inferior_object): Return
9815         gdbpy_ref.
9816         (python_new_inferior, python_inferior_deleted)
9817         (thread_to_thread_object, delete_thread_object)
9818         (build_inferior_list, gdbpy_selected_inferior): Update.
9819         * python/py-infthread.c (create_thread_object): Update.  Also fail
9820         if inferior_to_inferior_object fails.
9821
9822 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
9823
9824         * inferior.h (class inferior) <displaced_step_state>: New field.
9825         * infrun.h (struct displaced_step_state): Move here from
9826         infrun.c.  Initialize fields, add constructor.
9827         <inf>: Remove field.
9828         <reset>: New method.
9829         * infrun.c (struct displaced_step_inferior_state): Move to
9830         infrun.h.
9831         (displaced_step_inferior_states): Remove.
9832         (get_displaced_stepping_state): Adust.
9833         (displaced_step_in_progress_any_inferior): Adjust.
9834         (displaced_step_in_progress_thread): Adjust.
9835         (displaced_step_in_progress): Adjust.
9836         (add_displaced_stepping_state): Remove.
9837         (get_displaced_step_closure_by_addr): Adjust.
9838         (remove_displaced_stepping_state): Remove.
9839         (infrun_inferior_exit): Call displaced_step_state.reset.
9840         (use_displaced_stepping): Don't check for NULL.
9841         (displaced_step_prepare_throw): Call
9842         get_displaced_stepping_state.
9843         (displaced_step_fixup): Don't check for NULL.
9844         (prepare_for_detach): Don't check for NULL.
9845
9846 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9847
9848         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
9849          in case of call that did not complete.
9850
9851 2019-01-02  Andrey Utkin  <autkin@undo.io>
9852
9853         * symfile.c (find_separate_debug_file): Fix search of debug files for
9854         remote debuggee.
9855
9856 2019-01-02  Tom Tromey  <tom@tromey.com>
9857
9858         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
9859         indentation.
9860         * python/py-frame.c (frapy_older): Remove cast.
9861         (frapy_newer): Likewise.
9862         * python/py-breakpoint.c (local_setattro): Remove cast.
9863         * python/py-arch.c (archpy_name): Remove local variable.
9864         * python/py-type.c (gdbpy_lookup_type): Remove cast.
9865
9866 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
9867
9868         * unittests/basic_string_view/element_access/char/empty.cc:
9869         Fix year range in copyright header.
9870
9871 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9872
9873         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
9874         Delete.
9875         <operator==>: Update with for removed field.
9876         <hash>: Likewise.
9877         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
9878         <isa_features>: ...this.
9879         <abi_features>: New field.
9880         (riscv_isa_flen): Update comment.
9881         (riscv_abi_xlen): New declaration.
9882         (riscv_abi_flen): New declaration.
9883         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
9884         isa_features.
9885         (riscv_abi_xlen): New function.
9886         (riscv_isa_flen): Update to get answer from isa_features.
9887         (riscv_abi_flen): New function.
9888         (riscv_has_fp_abi): Update to get answer from abi_features.
9889         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
9890         xlen and flen.
9891         (riscv_call_info) <xlen, flen>: Update comment.
9892         (riscv_call_arg_struct): Remove invalid assertions
9893         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
9894         is removed.
9895         (riscv_gdbarch_init): Gather isa features and abi features
9896         separately, ensure both match on the gdbarch when reusing an old
9897         gdbarch.  Relax an error check to allow 32-bit abi float to run on
9898         a target with 64-bit float hardware.
9899
9900 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9901
9902         * source.c (search_command_helper): Stop reverse search
9903         when line 1 has been searched.
9904
9905 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9906
9907         * record-full.c (record_full_base_target::close): Rewrite
9908         record_full_core_buf_list free logic.
9909
9910 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9911
9912         * break-catch-syscall.c (print_one_catch_syscall): xfree
9913         the last text.
9914
9915 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9916
9917         * top.c (print_gdb_version): Update Copyright year in version
9918         message.
9919
9920 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9921
9922         Update copyright year range in all GDB files.
9923
9924 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
9925
9926         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
9927
9928 For older changes see ChangeLog-2018.
9929 \f
9930 Local Variables:
9931 mode: change-log
9932 left-margin: 8
9933 fill-column: 74
9934 version-control: never
9935 coding: utf-8
9936 End:
9937