gdb/ChangeLog

   1 2019-02-19  Tom Tromey  <tromey@adacore.com>
   2
   3         * ravenscar-thread.c
   4         (ravenscar_thread_target::update_thread_list): Don't call
   5         ada_build_task_list.
   6         * ada-lang.h (ada_build_task_list): Don't declare.
   7         * ada-tasks.c (struct ada_tasks_inferior_data)
   8         <task_list_valid_p>: Now bool.
   9         (read_known_tasks, ada_task_list_changed)
  10         (ada_tasks_invalidate_inferior_data): Update.
  11         (read_known_tasks_array): Return bool.
  12         (read_known_tasks_list): Likewise.
  13         (read_known_tasks): Return void.
  14         (ada_build_task_list): Now static.
  15
  16 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
  17
  18         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
  19         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
  20
  21 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  22
  23         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
  24         variant for ada_tasks_pspace_data_handle and
  25         ada_tasks_inferior_data_handle.
  26         (ada_tasks_pspace_data_cleanup): New function.
  27         (ada_tasks_inferior_data_cleanup): New function.
  28
  29 2019-02-17  Tom Tromey  <tom@tromey.com>
  30
  31         * macrotab.h (macro_source_fullname): Return a std::string.
  32         * macrotab.c (macro_include, check_for_redefinition)
  33         (macro_undef, macro_lookup_definition, foreach_macro)
  34         (foreach_macro_in_scope): Update.
  35         (macro_source_fullname): Return a std::string.
  36         * macrocmd.c (show_pp_source_pos): Update.
  37
  38 2019-02-17  Tom Tromey  <tom@tromey.com>
  39
  40         * macrocmd.c (show_pp_source_pos): Style the file names.
  41
  42 2019-02-17  Tom Tromey  <tom@tromey.com>
  43
  44         PR tui/24197:
  45         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
  46
  47 2019-02-17  Tom Tromey  <tom@tromey.com>
  48
  49         * ada-lang.c (user_select_syms): Use filtered printing.
  50         * utils.c (wrap_style): New global.
  51         (desired_style): Remove.
  52         (emit_style_escape): Add stream parameter.
  53         (set_output_style, reset_terminal_style, prompt_for_continue):
  54         Update.
  55         (flush_wrap_buffer): Only flush gdb_stdout.
  56         (wrap_here): Set wrap_style.
  57         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
  58         treat escape sequences as a character.  Change when wrap buffer is
  59         flushed.
  60         (fputs_styled): Do not set the output style when the default is
  61         requested.
  62         * ui-style.h (struct ui_file_style) <is_default>: New method.
  63         * source.c (print_source_lines_base): Emit escape sequences in one
  64         piece.
  65
  66 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
  67
  68         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
  69         integers and enumeration types.
  70
  71 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
  72
  73         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
  74         instead of lookup_symbol_in_language
  75         (do_exact_match): New function.
  76         (ada_get_symbol_name_matcher): Return do_exact_match when
  77         doing a verbatim match.
  78
  79 2019-02-15  Tom Tromey  <tromey@adacore.com>
  80
  81         * ravenscar-thread.c (ravenscar_thread_target::resume)
  82         (ravenscar_thread_target::wait): Special case wildcard requests.
  83
  84 2019-02-15  Tom Tromey  <tromey@adacore.com>
  85
  86         * ravenscar-thread.c (base_ptid): Remove.
  87         (struct ravenscar_thread_target) <close>: New method.
  88         <m_base_ptid>: New member.
  89         <update_inferior_ptid, active_task, task_is_currently_active,
  90         runtime_initialized>: Declare methods.
  91         <ravenscar_thread_target>: Add constructor.
  92         (ravenscar_thread_target::task_is_currently_active)
  93         (ravenscar_thread_target::update_inferior_ptid)
  94         (ravenscar_runtime_initialized): Rename.  Now methods.
  95         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
  96         (ravenscar_thread_target::update_thread_list): Update.
  97         (ravenscar_thread_target::active_task): Now method.
  98         (ravenscar_thread_target::store_registers)
  99         (ravenscar_thread_target::prepare_to_store)
 100         (ravenscar_thread_target::prepare_to_store)
 101         (ravenscar_thread_target::mourn_inferior): Update.
 102         (ravenscar_inferior_created): Use "new" to create target.
 103         (ravenscar_thread_target::get_ada_task_ptid): Update.
 104         (_initialize_ravenscar): Don't initialize base_ptid.
 105         (ravenscar_ops): Remove global.
 106
 107 2019-02-15  Tom Tromey  <tromey@adacore.com>
 108
 109         * target.h (push_target): Declare new overload.
 110         * target.c (push_target): New overload, taking an rvalue reference.
 111         * remote.c (remote_target::open_1): Use push_target overload.
 112         * corelow.c (core_target_open): Use push_target overload.
 113
 114 2019-02-15  Tom Tromey  <tromey@adacore.com>
 115
 116         * ravenscar-thread.c (is_ravenscar_task)
 117         (ravenscar_task_is_currently_active): Return bool.
 118         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
 119         (_initialize_ravenscar): Remove "(void)".
 120         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
 121         Return bool.
 122
 123 2019-02-15  Tom Tromey  <tromey@adacore.com>
 124
 125         * ravenscar-thread.c (ravenscar_runtime_initializer)
 126         (has_ravenscar_runtime, get_running_thread_id)
 127         (ravenscar_thread_target::resume): Fix indentation.
 128
 129 2019-02-15  Tom Tromey  <tromey@adacore.com>
 130
 131         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
 132         from ravenscar_arch_ops.
 133         (sparc_ravenscar_ops::fetch_registers)
 134         (sparc_ravenscar_ops::store_registers): Now methods.
 135         (sparc_ravenscar_prepare_to_store): Remove.
 136         (sparc_ravenscar_ops): Redefine.
 137         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
 138         methods and destructor.  Remove members.
 139         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
 140         (ravenscar_thread_target::store_registers)
 141         (ravenscar_thread_target::prepare_to_store): Update.
 142         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
 143         Remove.
 144         (struct ppc_ravenscar_powerpc_ops): Derive from
 145         ravenscar_arch_ops.
 146         (ppc_ravenscar_powerpc_ops::fetch_registers)
 147         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
 148         (ppc_ravenscar_powerpc_ops): Redefine.
 149         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
 150         (ppc_ravenscar_e500_ops::fetch_registers)
 151         (ppc_ravenscar_e500_ops::store_registers): Now methods.
 152         (ppc_ravenscar_e500_ops): Redefine.
 153         * aarch64-ravenscar-thread.c
 154         (aarch64_ravenscar_generic_prepare_to_store): Remove.
 155         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
 156         (aarch64_ravenscar_fetch_registers)
 157         (aarch64_ravenscar_store_registers): Now methods.
 158         (aarch64_ravenscar_ops): Redefine.
 159
 160 2019-02-15  Tom Tromey  <tromey@adacore.com>
 161
 162         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
 163         (ravenscar_thread_target::stopped_by_hw_breakpoint)
 164         (ravenscar_thread_target::stopped_by_watchpoint)
 165         (ravenscar_thread_target::stopped_data_address)
 166         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
 167
 168 2019-02-15  Tom Tromey  <tromey@adacore.com>
 169
 170         * ravenscar-thread.c: Fix some typos.
 171
 172 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 173             Tom Tromey  <tromey@adacore.com>
 174
 175         * ada-lang.c (ada_exception_sal): Change addr_string to a
 176         std::string.
 177         (create_ada_exception_catchpoint): Update.
 178
 179 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 180             Tom Tromey  <tromey@adacore.com>
 181
 182         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
 183         (bp_location_ops): Remove.
 184         (base_breakpoint_allocate_location): Update.
 185         (free_bp_location): Update.
 186         * ada-lang.c (class ada_catchpoint_location)
 187         <ada_catchpoint_location>: Remove ops parameter.
 188         (ada_catchpoint_location_dtor): Remove.
 189         (ada_catchpoint_location_ops): Remove.
 190         (allocate_location_exception): Update.
 191         * breakpoint.h (struct bp_location_ops): Remove.
 192         (class bp_location) <bp_location>: Remove bp_location_ops
 193         parameter.
 194         <~bp_location>: Add destructor.
 195         <ops>: Remove.
 196
 197 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 198             Pedro Alves  <palves@redhat.com>
 199
 200         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
 201         'PATH_MAX'.
 202
 203 2019-02-14  David Michael  <fedora.dm0@gmail.com>
 204             Samuel Thibault  <samuel.thibault@gnu.org>
 205             Thomas Schwinge  <thomas@codesourcery.com>
 206
 207         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
 208         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
 209
 210 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 211
 212         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
 213         (check_empty): Use "const char *".
 214
 215         * gnu-nat.c (gnu_nat_target::detach): Instead of
 216         'detach_inferior (pid)' call
 217         'detach_inferior (find_inferior_pid (pid))'.
 218
 219         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
 220         'nat/fork-inferior.o'.
 221         * gnu-nat.c: #include "nat/fork-inferior.h".
 222
 223         * gnu-nat.c (gnu_nat_target::detach): Instead of
 224         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
 225         * gnu-nat.h: #include "inf-child.h".
 226         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
 227         'i386_gnu_nat_target::fetch_registers'.
 228         (gnu_store_registers): Rename/move to
 229         'i386_gnu_nat_target::store_registers'.
 230
 231         * config/i386/nm-i386gnu.h: Don't "#include" any files.
 232         * gnu-nat.h (mach_thread_info): New function.
 233         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
 234
 235         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
 236
 237 2019-02-14  Frederic Konrad  <konrad@adacore.com>
 238
 239         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
 240
 241 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
 242
 243         * windows-nat.c (windows_add_thread): Add new parameter
 244         "main_thread_p" with default value set to false.  Update
 245         function documentation as well as all callers.
 246         (windows_delete_thread): Likewise.
 247         (fake_create_process): Update call to windows_add_thread.
 248         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
 249         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
 250         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
 251         call to windows_delete_thread.
 252
 253 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
 254
 255         * MAINTAINERS: Add Andrew Burgess as global maintainer.
 256
 257 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 258
 259         * symfile.c (find_separate_debug_file): Use canonical path of
 260         sysroot with child_path instead of gdb_sysroot if it is valid.
 261
 262 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 263
 264         * symfile.c (find_separate_debug_file): Use child_path to
 265         determine if an object file is under a sysroot.
 266
 267 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 268
 269         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 270         unittests/child-path-selftests.c.
 271         * common/pathstuff.c (child_path): New function.
 272         * common/pathstuff.h (child_path): New prototype.
 273         * unittests/child-path-selftests.c: New file.
 274
 275 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 276
 277         * symfile.c (find_separate_debug_file): Look for separate debug
 278         files in debug directories under the sysroot.
 279
 280 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 281
 282         * symtab.h (struct minimal_symbol data_p): New const method.
 283         (struct minimal_symbol text_p): Likewise.
 284         * symtab.c (output_source_filename): Use file name style
 285         to print file name.
 286         (print_symbol_info): Likewise.
 287         (print_msymbol_info): Use address style to print addresses.
 288         Use function name style to print executable text symbols.
 289         (expand_symtab_containing_pc): Use data_p.
 290         (find_pc_sect_compunit_symtab): Likewise.
 291
 292 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 293
 294         * breakpoint.c (describe_other_breakpoints): Use address style
 295         to print addresses.
 296         (say_where): Likewise.
 297
 298 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 299
 300         * ada-typeprint.c (print_func_type): Print function name
 301         style to print function name.
 302         * c-typeprint.c (c_print_type_1): Likewise.
 303
 304 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
 305
 306         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
 307         for execve.
 308
 309 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 310
 311         * c-exp.y (direct_abs_decl): Use emplace_back to record the
 312         type_stack.
 313
 314 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
 315
 316         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
 317         TYPE_CODE_REF types.
 318
 319 2019-02-08  Jim Wilson  <jimw@sifive.com>
 320
 321         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
 322         (riscv_linux_fregset): New.
 323         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
 324
 325 2019-02-07  Tom Tromey  <tom@tromey.com>
 326
 327         * thread.c (thread_cancel_execution_command): Update.
 328         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
 329         methods.
 330         (struct thread_fsm_ops): Remove.
 331         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
 332         (thread_fsm_should_stop, thread_fsm_return_value)
 333         (thread_fsm_set_finished, thread_fsm_finished_p)
 334         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
 335         Don't declare.
 336         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
 337         * infrun.c (clear_proceed_status_thread)
 338         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
 339         (print_stop_event): Update.
 340         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
 341         Add constructor.
 342         (step_command_fsm_ops): Remove.
 343         (new_step_command_fsm): Remove.
 344         (step_1): Update.
 345         (step_command_fsm::should_stop): Rename from
 346         step_command_fsm_should_stop.
 347         (step_command_fsm::clean_up): Rename from
 348         step_command_fsm_clean_up.
 349         (step_command_fsm::do_async_reply_reason): Rename from
 350         step_command_fsm_async_reply_reason.
 351         (struct until_next_fsm): Inherit from thread_fsm.  Add
 352         constructor.
 353         (until_next_fsm_ops): Remove.
 354         (new_until_next_fsm): Remove.
 355         (until_next_fsm::should_stop): Rename from
 356         until_next_fsm_should_stop.
 357         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
 358         (until_next_fsm::do_async_reply_reason): Rename from
 359         until_next_fsm_async_reply_reason.
 360         (struct finish_command_fsm): Inherit from thread_fsm.  Add
 361         constructor.  Change type of breakpoint.
 362         (finish_command_fsm_ops): Remove.
 363         (new_finish_command_fsm): Remove.
 364         (finish_command_fsm::should_stop): Rename from
 365         finish_command_fsm_should_stop.
 366         (finish_command_fsm::clean_up): Rename from
 367         finish_command_fsm_clean_up.
 368         (finish_command_fsm::return_value): Rename from
 369         finish_command_fsm_return_value.
 370         (finish_command_fsm::do_async_reply_reason): Rename from
 371         finish_command_fsm_async_reply_reason.
 372         (finish_command): Update.
 373         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
 374         Add constructor.
 375         (call_thread_fsm_ops): Remove.
 376         (call_thread_fsm::call_thread_fsm): Rename from
 377         new_call_thread_fsm.
 378         (call_thread_fsm::should_stop): Rename from
 379         call_thread_fsm_should_stop.
 380         (call_thread_fsm::should_notify_stop): Rename from
 381         call_thread_fsm_should_notify_stop.
 382         (run_inferior_call, call_function_by_hand_dummy): Update.
 383         * cli/cli-interp.c (should_print_stop_to_console): Update.
 384         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
 385         Add constructor.  Change type of location_breakpoint,
 386         caller_breakpoint.
 387         (until_break_fsm_ops): Remove.
 388         (new_until_break_fsm): Remove.
 389         (until_break_fsm::should_stop): Rename from
 390         until_break_fsm_should_stop.
 391         (until_break_fsm::clean_up): Rename from
 392         until_break_fsm_clean_up.
 393         (until_break_fsm::do_async_reply_reason): Rename from
 394         until_break_fsm_async_reply_reason.
 395         (until_break_command): Update.
 396         * thread-fsm.c: Remove.
 397         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
 398
 399 2019-02-07  Tom Tromey  <tom@tromey.com>
 400
 401         * yy-remap.h: Add include guard.
 402         * xtensa-tdep.h: Add include guard.
 403         * xcoffread.h: Rename include guard.
 404         * varobj-iter.h: Add include guard.
 405         * tui/tui.h: Rename include guard.
 406         * tui/tui-winsource.h: Rename include guard.
 407         * tui/tui-wingeneral.h: Rename include guard.
 408         * tui/tui-windata.h: Rename include guard.
 409         * tui/tui-win.h: Rename include guard.
 410         * tui/tui-stack.h: Rename include guard.
 411         * tui/tui-source.h: Rename include guard.
 412         * tui/tui-regs.h: Rename include guard.
 413         * tui/tui-out.h: Rename include guard.
 414         * tui/tui-layout.h: Rename include guard.
 415         * tui/tui-io.h: Rename include guard.
 416         * tui/tui-hooks.h: Rename include guard.
 417         * tui/tui-file.h: Rename include guard.
 418         * tui/tui-disasm.h: Rename include guard.
 419         * tui/tui-data.h: Rename include guard.
 420         * tui/tui-command.h: Rename include guard.
 421         * tic6x-tdep.h: Add include guard.
 422         * target/waitstatus.h: Rename include guard.
 423         * target/wait.h: Rename include guard.
 424         * target/target.h: Rename include guard.
 425         * target/resume.h: Rename include guard.
 426         * target-float.h: Rename include guard.
 427         * stabsread.h: Add include guard.
 428         * rs6000-tdep.h: Add include guard.
 429         * riscv-fbsd-tdep.h: Add include guard.
 430         * regformats/regdef.h: Rename include guard.
 431         * record.h: Rename include guard.
 432         * python/python.h: Rename include guard.
 433         * python/python-internal.h: Rename include guard.
 434         * python/py-stopevent.h: Rename include guard.
 435         * python/py-ref.h: Rename include guard.
 436         * python/py-record.h: Rename include guard.
 437         * python/py-record-full.h: Rename include guard.
 438         * python/py-record-btrace.h: Rename include guard.
 439         * python/py-instruction.h: Rename include guard.
 440         * python/py-events.h: Rename include guard.
 441         * python/py-event.h: Rename include guard.
 442         * procfs.h: Add include guard.
 443         * proc-utils.h: Add include guard.
 444         * p-lang.h: Add include guard.
 445         * or1k-tdep.h: Rename include guard.
 446         * observable.h: Rename include guard.
 447         * nto-tdep.h: Rename include guard.
 448         * nat/x86-linux.h: Rename include guard.
 449         * nat/x86-linux-dregs.h: Rename include guard.
 450         * nat/x86-gcc-cpuid.h: Add include guard.
 451         * nat/x86-dregs.h: Rename include guard.
 452         * nat/x86-cpuid.h: Rename include guard.
 453         * nat/ppc-linux.h: Rename include guard.
 454         * nat/mips-linux-watch.h: Rename include guard.
 455         * nat/linux-waitpid.h: Rename include guard.
 456         * nat/linux-ptrace.h: Rename include guard.
 457         * nat/linux-procfs.h: Rename include guard.
 458         * nat/linux-osdata.h: Rename include guard.
 459         * nat/linux-nat.h: Rename include guard.
 460         * nat/linux-namespaces.h: Rename include guard.
 461         * nat/linux-btrace.h: Rename include guard.
 462         * nat/glibc_thread_db.h: Rename include guard.
 463         * nat/gdb_thread_db.h: Rename include guard.
 464         * nat/gdb_ptrace.h: Rename include guard.
 465         * nat/fork-inferior.h: Rename include guard.
 466         * nat/amd64-linux-siginfo.h: Rename include guard.
 467         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
 468         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
 469         * nat/aarch64-linux.h: Rename include guard.
 470         * nat/aarch64-linux-hw-point.h: Rename include guard.
 471         * mn10300-tdep.h: Add include guard.
 472         * mips-linux-tdep.h: Add include guard.
 473         * mi/mi-parse.h: Rename include guard.
 474         * mi/mi-out.h: Rename include guard.
 475         * mi/mi-main.h: Rename include guard.
 476         * mi/mi-interp.h: Rename include guard.
 477         * mi/mi-getopt.h: Rename include guard.
 478         * mi/mi-console.h: Rename include guard.
 479         * mi/mi-common.h: Rename include guard.
 480         * mi/mi-cmds.h: Rename include guard.
 481         * mi/mi-cmd-break.h: Rename include guard.
 482         * m2-lang.h: Add include guard.
 483         * location.h: Rename include guard.
 484         * linux-record.h: Rename include guard.
 485         * linux-nat.h: Add include guard.
 486         * linux-fork.h: Add include guard.
 487         * i386-darwin-tdep.h: Rename include guard.
 488         * hppa-linux-offsets.h: Add include guard.
 489         * guile/guile.h: Rename include guard.
 490         * guile/guile-internal.h: Rename include guard.
 491         * gnu-nat.h: Rename include guard.
 492         * gdb-stabs.h: Rename include guard.
 493         * frv-tdep.h: Add include guard.
 494         * f-lang.h: Add include guard.
 495         * event-loop.h: Add include guard.
 496         * darwin-nat.h: Rename include guard.
 497         * cp-abi.h: Rename include guard.
 498         * config/sparc/nm-sol2.h: Rename include guard.
 499         * config/nm-nto.h: Rename include guard.
 500         * config/nm-linux.h: Add include guard.
 501         * config/i386/nm-i386gnu.h: Rename include guard.
 502         * config/djgpp/nl_types.h: Rename include guard.
 503         * config/djgpp/langinfo.h: Rename include guard.
 504         * compile/gcc-cp-plugin.h: Add include guard.
 505         * compile/gcc-c-plugin.h: Add include guard.
 506         * compile/compile.h: Rename include guard.
 507         * compile/compile-object-run.h: Rename include guard.
 508         * compile/compile-object-load.h: Rename include guard.
 509         * compile/compile-internal.h: Rename include guard.
 510         * compile/compile-cplus.h: Rename include guard.
 511         * compile/compile-c.h: Rename include guard.
 512         * common/xml-utils.h: Rename include guard.
 513         * common/x86-xstate.h: Rename include guard.
 514         * common/version.h: Rename include guard.
 515         * common/vec.h: Rename include guard.
 516         * common/tdesc.h: Rename include guard.
 517         * common/selftest.h: Rename include guard.
 518         * common/scoped_restore.h: Rename include guard.
 519         * common/scoped_mmap.h: Rename include guard.
 520         * common/scoped_fd.h: Rename include guard.
 521         * common/safe-iterator.h: Rename include guard.
 522         * common/run-time-clock.h: Rename include guard.
 523         * common/refcounted-object.h: Rename include guard.
 524         * common/queue.h: Rename include guard.
 525         * common/ptid.h: Rename include guard.
 526         * common/print-utils.h: Rename include guard.
 527         * common/preprocessor.h: Rename include guard.
 528         * common/pathstuff.h: Rename include guard.
 529         * common/observable.h: Rename include guard.
 530         * common/netstuff.h: Rename include guard.
 531         * common/job-control.h: Rename include guard.
 532         * common/host-defs.h: Rename include guard.
 533         * common/gdb_wait.h: Rename include guard.
 534         * common/gdb_vecs.h: Rename include guard.
 535         * common/gdb_unlinker.h: Rename include guard.
 536         * common/gdb_unique_ptr.h: Rename include guard.
 537         * common/gdb_tilde_expand.h: Rename include guard.
 538         * common/gdb_sys_time.h: Rename include guard.
 539         * common/gdb_string_view.h: Rename include guard.
 540         * common/gdb_splay_tree.h: Rename include guard.
 541         * common/gdb_setjmp.h: Rename include guard.
 542         * common/gdb_ref_ptr.h: Rename include guard.
 543         * common/gdb_optional.h: Rename include guard.
 544         * common/gdb_locale.h: Rename include guard.
 545         * common/gdb_assert.h: Rename include guard.
 546         * common/filtered-iterator.h: Rename include guard.
 547         * common/filestuff.h: Rename include guard.
 548         * common/fileio.h: Rename include guard.
 549         * common/environ.h: Rename include guard.
 550         * common/common-utils.h: Rename include guard.
 551         * common/common-types.h: Rename include guard.
 552         * common/common-regcache.h: Rename include guard.
 553         * common/common-inferior.h: Rename include guard.
 554         * common/common-gdbthread.h: Rename include guard.
 555         * common/common-exceptions.h: Rename include guard.
 556         * common/common-defs.h: Rename include guard.
 557         * common/common-debug.h: Rename include guard.
 558         * common/cleanups.h: Rename include guard.
 559         * common/buffer.h: Rename include guard.
 560         * common/btrace-common.h: Rename include guard.
 561         * common/break-common.h: Rename include guard.
 562         * cli/cli-utils.h: Rename include guard.
 563         * cli/cli-style.h: Rename include guard.
 564         * cli/cli-setshow.h: Rename include guard.
 565         * cli/cli-script.h: Rename include guard.
 566         * cli/cli-interp.h: Rename include guard.
 567         * cli/cli-decode.h: Rename include guard.
 568         * cli/cli-cmds.h: Rename include guard.
 569         * charset-list.h: Add include guard.
 570         * buildsym-legacy.h: Rename include guard.
 571         * bfin-tdep.h: Add include guard.
 572         * ax.h: Rename include guard.
 573         * arm-linux-tdep.h: Add include guard.
 574         * arm-fbsd-tdep.h: Add include guard.
 575         * arch/xtensa.h: Rename include guard.
 576         * arch/tic6x.h: Add include guard.
 577         * arch/i386.h: Add include guard.
 578         * arch/arm.h: Rename include guard.
 579         * arch/arm-linux.h: Rename include guard.
 580         * arch/arm-get-next-pcs.h: Rename include guard.
 581         * arch/amd64.h: Add include guard.
 582         * arch/aarch64-insn.h: Rename include guard.
 583         * arch-utils.h: Rename include guard.
 584         * annotate.h: Add include guard.
 585         * amd64-darwin-tdep.h: Rename include guard.
 586         * aarch64-linux-tdep.h: Add include guard.
 587         * aarch64-fbsd-tdep.h: Add include guard.
 588         * aarch32-linux-nat.h: Add include guard.
 589
 590 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 591
 592         * macrotab.c (macro_define_internal): New function that
 593         factorizes macro_define_object_internal and macro_define_function
 594         code.
 595         (macro_define_object_internal): Use macro_define_internal.
 596         (macro_define_function): Likewise.
 597
 598 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 599
 600         * macrocmd.c (extract_identifier): Return
 601         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
 602         callers.
 603
 604 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
 605
 606         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
 607
 608 2019-02-05  Tom Tromey  <tom@tromey.com>
 609
 610         * target.c (target_stack::unpush): Move assertion earlier.
 611
 612 2019-01-30  Tom Tromey  <tom@tromey.com>
 613
 614         PR python/23615:
 615         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
 616         (gdbpy_parse_and_eval): Likewise.
 617         * python/python-internal.h (gdbpy_allow_threads): New class.
 618
 619 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
 620
 621         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
 622         (aarch64_fbsd_fpregmap): Move earlier.
 623         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
 624         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 625         instead of individual calls to trad_frame_set_reg_addr.
 626         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
 627         earlier.
 628         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
 629         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 630         instead of individual calls to trad_frame_set_reg_addr.
 631
 632 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
 633
 634         * CONTRIBUTE: Replace contribution list with wiki link.
 635
 636 2019-01-25  Tom Tromey  <tom@tromey.com>
 637
 638         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
 639
 640 2019-01-25  Tom Tromey  <tom@tromey.com>
 641
 642         * xtensa-linux-nat.c: Fix common/ includes.
 643         * xml-support.h: Fix common/ includes.
 644         * xml-support.c: Fix common/ includes.
 645         * x86-linux-nat.c: Fix common/ includes.
 646         * windows-nat.c: Fix common/ includes.
 647         * varobj.h: Fix common/ includes.
 648         * varobj.c: Fix common/ includes.
 649         * value.c: Fix common/ includes.
 650         * valops.c: Fix common/ includes.
 651         * utils.c: Fix common/ includes.
 652         * unittests/xml-utils-selftests.c: Fix common/ includes.
 653         * unittests/utils-selftests.c: Fix common/ includes.
 654         * unittests/unpack-selftests.c: Fix common/ includes.
 655         * unittests/tracepoint-selftests.c: Fix common/ includes.
 656         * unittests/style-selftests.c: Fix common/ includes.
 657         * unittests/string_view-selftests.c: Fix common/ includes.
 658         * unittests/scoped_restore-selftests.c: Fix common/ includes.
 659         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
 660         * unittests/scoped_fd-selftests.c: Fix common/ includes.
 661         * unittests/rsp-low-selftests.c: Fix common/ includes.
 662         * unittests/parse-connection-spec-selftests.c: Fix common/
 663         includes.
 664         * unittests/optional-selftests.c: Fix common/ includes.
 665         * unittests/offset-type-selftests.c: Fix common/ includes.
 666         * unittests/observable-selftests.c: Fix common/ includes.
 667         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
 668         * unittests/memrange-selftests.c: Fix common/ includes.
 669         * unittests/memory-map-selftests.c: Fix common/ includes.
 670         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
 671         * unittests/function-view-selftests.c: Fix common/ includes.
 672         * unittests/environ-selftests.c: Fix common/ includes.
 673         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
 674         * unittests/common-utils-selftests.c: Fix common/ includes.
 675         * unittests/cli-utils-selftests.c: Fix common/ includes.
 676         * unittests/array-view-selftests.c: Fix common/ includes.
 677         * ui-file.c: Fix common/ includes.
 678         * tui/tui-io.c: Fix common/ includes.
 679         * tracepoint.h: Fix common/ includes.
 680         * tracepoint.c: Fix common/ includes.
 681         * tracefile-tfile.c: Fix common/ includes.
 682         * top.h: Fix common/ includes.
 683         * top.c: Fix common/ includes.
 684         * thread.c: Fix common/ includes.
 685         * target/waitstatus.h: Fix common/ includes.
 686         * target/waitstatus.c: Fix common/ includes.
 687         * target.h: Fix common/ includes.
 688         * target.c: Fix common/ includes.
 689         * target-memory.c: Fix common/ includes.
 690         * target-descriptions.c: Fix common/ includes.
 691         * symtab.h: Fix common/ includes.
 692         * symfile.c: Fix common/ includes.
 693         * stap-probe.c: Fix common/ includes.
 694         * spu-linux-nat.c: Fix common/ includes.
 695         * sparc-nat.c: Fix common/ includes.
 696         * source.c: Fix common/ includes.
 697         * solib.c: Fix common/ includes.
 698         * solib-target.c: Fix common/ includes.
 699         * ser-unix.c: Fix common/ includes.
 700         * ser-tcp.c: Fix common/ includes.
 701         * ser-pipe.c: Fix common/ includes.
 702         * ser-base.c: Fix common/ includes.
 703         * selftest-arch.c: Fix common/ includes.
 704         * s12z-tdep.c: Fix common/ includes.
 705         * rust-exp.y: Fix common/ includes.
 706         * rs6000-aix-tdep.c: Fix common/ includes.
 707         * riscv-tdep.c: Fix common/ includes.
 708         * remote.c: Fix common/ includes.
 709         * remote-notif.h: Fix common/ includes.
 710         * remote-fileio.h: Fix common/ includes.
 711         * remote-fileio.c: Fix common/ includes.
 712         * regcache.h: Fix common/ includes.
 713         * regcache.c: Fix common/ includes.
 714         * record-btrace.c: Fix common/ includes.
 715         * python/python.c: Fix common/ includes.
 716         * python/py-type.c: Fix common/ includes.
 717         * python/py-inferior.c: Fix common/ includes.
 718         * progspace.h: Fix common/ includes.
 719         * producer.c: Fix common/ includes.
 720         * procfs.c: Fix common/ includes.
 721         * proc-api.c: Fix common/ includes.
 722         * printcmd.c: Fix common/ includes.
 723         * ppc-linux-nat.c: Fix common/ includes.
 724         * parser-defs.h: Fix common/ includes.
 725         * osdata.c: Fix common/ includes.
 726         * obsd-nat.c: Fix common/ includes.
 727         * nat/x86-linux.c: Fix common/ includes.
 728         * nat/x86-linux-dregs.c: Fix common/ includes.
 729         * nat/x86-dregs.h: Fix common/ includes.
 730         * nat/x86-dregs.c: Fix common/ includes.
 731         * nat/ppc-linux.c: Fix common/ includes.
 732         * nat/mips-linux-watch.h: Fix common/ includes.
 733         * nat/mips-linux-watch.c: Fix common/ includes.
 734         * nat/linux-waitpid.c: Fix common/ includes.
 735         * nat/linux-ptrace.h: Fix common/ includes.
 736         * nat/linux-ptrace.c: Fix common/ includes.
 737         * nat/linux-procfs.c: Fix common/ includes.
 738         * nat/linux-personality.c: Fix common/ includes.
 739         * nat/linux-osdata.c: Fix common/ includes.
 740         * nat/linux-namespaces.c: Fix common/ includes.
 741         * nat/linux-btrace.h: Fix common/ includes.
 742         * nat/linux-btrace.c: Fix common/ includes.
 743         * nat/fork-inferior.c: Fix common/ includes.
 744         * nat/amd64-linux-siginfo.c: Fix common/ includes.
 745         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
 746         * nat/aarch64-linux.c: Fix common/ includes.
 747         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
 748         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
 749         * namespace.h: Fix common/ includes.
 750         * mips-linux-tdep.c: Fix common/ includes.
 751         * minsyms.c: Fix common/ includes.
 752         * mi/mi-parse.h: Fix common/ includes.
 753         * mi/mi-main.c: Fix common/ includes.
 754         * mi/mi-cmd-env.c: Fix common/ includes.
 755         * memrange.h: Fix common/ includes.
 756         * memattr.c: Fix common/ includes.
 757         * maint.h: Fix common/ includes.
 758         * maint.c: Fix common/ includes.
 759         * main.c: Fix common/ includes.
 760         * machoread.c: Fix common/ includes.
 761         * location.c: Fix common/ includes.
 762         * linux-thread-db.c: Fix common/ includes.
 763         * linux-nat.c: Fix common/ includes.
 764         * linux-fork.c: Fix common/ includes.
 765         * inline-frame.c: Fix common/ includes.
 766         * infrun.c: Fix common/ includes.
 767         * inflow.c: Fix common/ includes.
 768         * inferior.h: Fix common/ includes.
 769         * inferior.c: Fix common/ includes.
 770         * infcmd.c: Fix common/ includes.
 771         * inf-ptrace.c: Fix common/ includes.
 772         * inf-child.c: Fix common/ includes.
 773         * ia64-linux-nat.c: Fix common/ includes.
 774         * i387-tdep.c: Fix common/ includes.
 775         * i386-tdep.c: Fix common/ includes.
 776         * i386-linux-tdep.c: Fix common/ includes.
 777         * i386-linux-nat.c: Fix common/ includes.
 778         * i386-go32-tdep.c: Fix common/ includes.
 779         * i386-fbsd-tdep.c: Fix common/ includes.
 780         * i386-fbsd-nat.c: Fix common/ includes.
 781         * guile/scm-type.c: Fix common/ includes.
 782         * guile/guile.c: Fix common/ includes.
 783         * go32-nat.c: Fix common/ includes.
 784         * gnu-nat.c: Fix common/ includes.
 785         * gdbthread.h: Fix common/ includes.
 786         * gdbarch-selftests.c: Fix common/ includes.
 787         * gdb_usleep.c: Fix common/ includes.
 788         * gdb_select.h: Fix common/ includes.
 789         * gdb_bfd.c: Fix common/ includes.
 790         * gcore.c: Fix common/ includes.
 791         * fork-child.c: Fix common/ includes.
 792         * findvar.c: Fix common/ includes.
 793         * fbsd-nat.c: Fix common/ includes.
 794         * event-top.c: Fix common/ includes.
 795         * event-loop.c: Fix common/ includes.
 796         * dwarf2read.c: Fix common/ includes.
 797         * dwarf2loc.c: Fix common/ includes.
 798         * dwarf2-frame.c: Fix common/ includes.
 799         * dwarf-index-cache.c: Fix common/ includes.
 800         * dtrace-probe.c: Fix common/ includes.
 801         * disasm-selftests.c: Fix common/ includes.
 802         * defs.h: Fix common/ includes.
 803         * csky-tdep.c: Fix common/ includes.
 804         * cp-valprint.c: Fix common/ includes.
 805         * cp-support.h: Fix common/ includes.
 806         * cp-support.c: Fix common/ includes.
 807         * corelow.c: Fix common/ includes.
 808         * completer.h: Fix common/ includes.
 809         * completer.c: Fix common/ includes.
 810         * compile/compile.c: Fix common/ includes.
 811         * compile/compile-loc2c.c: Fix common/ includes.
 812         * compile/compile-cplus-types.c: Fix common/ includes.
 813         * compile/compile-cplus-symbols.c: Fix common/ includes.
 814         * command.h: Fix common/ includes.
 815         * cli/cli-dump.c: Fix common/ includes.
 816         * cli/cli-cmds.c: Fix common/ includes.
 817         * charset.c: Fix common/ includes.
 818         * build-id.c: Fix common/ includes.
 819         * btrace.h: Fix common/ includes.
 820         * btrace.c: Fix common/ includes.
 821         * breakpoint.h: Fix common/ includes.
 822         * breakpoint.c: Fix common/ includes.
 823         * ax.h:
 824         (enum agent_op): Fix common/ includes.
 825         * ax-general.c (struct aop_map): Fix common/ includes.
 826         * ax-gdb.c: Fix common/ includes.
 827         * auxv.c: Fix common/ includes.
 828         * auto-load.c: Fix common/ includes.
 829         * arm-tdep.c: Fix common/ includes.
 830         * arch/riscv.c: Fix common/ includes.
 831         * arch/ppc-linux-common.c: Fix common/ includes.
 832         * arch/i386.c: Fix common/ includes.
 833         * arch/arm.c: Fix common/ includes.
 834         * arch/arm-linux.c: Fix common/ includes.
 835         * arch/arm-get-next-pcs.c: Fix common/ includes.
 836         * arch/amd64.c: Fix common/ includes.
 837         * arch/aarch64.c: Fix common/ includes.
 838         * arch/aarch64-insn.c: Fix common/ includes.
 839         * arch-utils.c: Fix common/ includes.
 840         * amd64-windows-tdep.c: Fix common/ includes.
 841         * amd64-tdep.c: Fix common/ includes.
 842         * amd64-sol2-tdep.c: Fix common/ includes.
 843         * amd64-obsd-tdep.c: Fix common/ includes.
 844         * amd64-nbsd-tdep.c: Fix common/ includes.
 845         * amd64-linux-tdep.c: Fix common/ includes.
 846         * amd64-linux-nat.c: Fix common/ includes.
 847         * amd64-fbsd-tdep.c: Fix common/ includes.
 848         * amd64-fbsd-nat.c: Fix common/ includes.
 849         * amd64-dicos-tdep.c: Fix common/ includes.
 850         * amd64-darwin-tdep.c: Fix common/ includes.
 851         * agent.c: Fix common/ includes.
 852         * ada-lang.h: Fix common/ includes.
 853         * ada-lang.c: Fix common/ includes.
 854         * aarch64-tdep.c: Fix common/ includes.
 855
 856 2019-01-25  Tom Tromey  <tom@tromey.com>
 857
 858         * common/create-version.sh: Use common/version.h.
 859
 860 2019-01-24  Pedro Alves  <palves@redhat.com>
 861
 862         * infrun.c (signal_stop, signal_print, signal_program)
 863         (signal_catch, signal_pass): Now arrays instead of pointers.
 864         (update_signals_program_target, do_target_resume)
 865         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
 866         * linux-nat.c (linux_nat_target::pass_signals)
 867         (linux_nat_target::create_inferior, linux_nat_target::attach):
 868         Adjust.
 869         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
 870         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
 871         * procfs.c (procfs_target::pass_signals): Adjust.
 872         * record-full.c (record_full_target::resume): Adjust.
 873         * remote.c (remote_target::pass_signals)
 874         (remote_target::program_signals): Adjust.
 875         * target-debug.h (target_debug_print_signals): Now takes a
 876         gdb::array_view as parameter.  Adjust.
 877         * target.h (target_ops) <pass_signals, program_signals>: Replace
 878         pointer and length parameters with gdb::array_view.
 879         (target_pass_signals, target_program_signals): Likewise.
 880         * target-delegates.c: Regenerate.
 881
 882 2019-01-24  Pedro Alves  <palves@redhat.com>
 883
 884         * common/forward-scope-exit.h
 885         (forward_scope_exit::forward_scope_exit): Pass arguments to
 886         m_bind_function directly, instead of creating a std::bind and
 887         copying that.
 888
 889 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
 890
 891         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 892         for static members.
 893         (pass_in_v_vfp_candidate): Likewise.
 894
 895 2019-01-23  Tom Tromey  <tom@tromey.com>
 896             Pedro Alves  <palves@redhat.com>
 897
 898         * regcache.c (class regcache_invalidator): Remove.
 899         (regcache::raw_write): Use make_scope_exit.
 900
 901 2019-01-23  Tom Tromey  <tom@tromey.com>
 902
 903         * ui-out.h (class ui_out_emit_type): Update comment.
 904
 905 2019-01-23  Tom Tromey  <tom@tromey.com>
 906
 907         * infrun.c (fetch_inferior_event): Update comment.
 908
 909 2019-01-23  Tom Tromey  <tom@tromey.com>
 910             Pedro Alves  <palves@redhat.com>
 911
 912         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
 913         parameter.
 914         (fetch_inferior_event): Use SCOPE_EXIT.
 915
 916
 917 2019-01-23  Tom Tromey  <tom@tromey.com>
 918             Pedro Alves  <palves@redhat.com>
 919
 920         * infrun.c (disable_thread_events): Delete.
 921         (stop_all_threads): Use SCOPE_EXIT.
 922
 923 2019-01-23  Tom Tromey  <tom@tromey.com>
 924             Pedro Alves  <palves@redhat.com>
 925
 926         * symfile.c: Include forward-scope-exit.h.
 927         (clear_symtab_users_cleanup): Replace forward declaration with
 928         a FORWARD_SCOPE_EXIT.
 929         (syms_from_objfile_1): Use the forward_scope_exit and
 930         gdb::optional instead of cleanup_function.
 931         (reread_symbols): Use the forward_scope_exit instead of
 932         cleanup_function.
 933         (clear_symtab_users_cleanup): Remove function.
 934
 935 2019-01-23  Tom Tromey  <tom@tromey.com>
 936             Pedro Alves  <palves@redhat.com>
 937
 938         * linux-nat.c: Include scope-exit.h.
 939         (cleanup_target_stop): Remove.
 940         (linux_nat_target::static_tracepoint_markers_by_strid): Use
 941         SCOPE_EXIT.
 942
 943 2019-01-23  Tom Tromey  <tom@tromey.com>
 944             Pedro Alves  <palves@redhat.com>
 945
 946         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
 947         (call_function_by_hand_dummy): Use SCOPE_EXIT.
 948
 949 2019-01-23  Tom Tromey  <tom@tromey.com>
 950             Andrew Burgess  <andrew.burgess@embecosm.com>
 951             Pedro Alves  <palves@redhat.com>
 952
 953         * infrun.c (fetch_inferior_event): Use scope_exit.
 954         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
 955         * top.c (execute_command): Use scope_exit.
 956         * breakpoint.c (bpstat_do_actions): Use scope_exit.
 957         * utils.c (do_bpstat_clear_actions_cleanup)
 958         (make_bpstat_clear_actions_cleanup): Remove.
 959
 960 2019-01-23  Tom Tromey  <tom@tromey.com>
 961             Pedro Alves  <palves@redhat.com>
 962
 963         * infrun.c: Include "common/scope-exit.h"
 964         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
 965         (wait_for_inferior): Use SCOPE_EXIT.
 966         (fetch_inferior_event): Use scope_exit.
 967
 968 2019-01-23  Tom Tromey  <tom@tromey.com>
 969             Pedro Alves  <palves@redhat.com>
 970
 971         * breakpoint.c (create_breakpoint): Remove cleanup.
 972
 973 2019-01-23  Tom Tromey  <tom@tromey.com>
 974             Andrew Burgess  <andrew.burgess@embecosm.com>
 975             Pedro Alves  <palves@redhat.com>
 976
 977 2019-01-23  Pedro Alves  <palves@redhat.com>
 978
 979         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
 980
 981 2019-01-23  Pedro Alves  <palves@redhat.com>
 982             Andrew Burgess  <andrew.burgess@embecosm.com>
 983
 984         * gdbthread.h: Include "common/forward-scope-exit.h".
 985         (scoped_finish_thread_state): Redefine custom class in terms of
 986         forward_scope_exit.
 987
 988 2019-01-23  Pedro Alves  <palves@redhat.com>
 989             Andrew Burgess  <andrew.burgess@embecosm.com>
 990
 991         * common/forward-scope-exit.h: New file.
 992
 993 2019-01-23  Pedro Alves  <palves@redhat.com>
 994             Andrew Burgess  <andrew.burgess@embecosm.com>
 995             Tom Tromey  <tom@tromey.com>
 996
 997         * common/scope-exit.h: New file.
 998
 999 2019-01-23  Pedro Alves  <palves@redhat.com>
1000
1001         * common/preprocessor.h (ESC): Rename to ...
1002         (ESC_PARENS): ... this.
1003         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1004         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1005
1006 2019-01-23  Tom Tromey  <tom@tromey.com>
1007
1008         * language.h (class scoped_switch_to_sym_language_if_auto):
1009         Initialize m_lang in both cases.
1010
1011 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1012
1013         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1014         with XCNEW.
1015
1016 2019-01-22  Tom Tromey  <tom@tromey.com>
1017
1018         * corelow.c: Do not include sys/file.h.
1019
1020 2019-01-22  Tom Tromey  <tom@tromey.com>
1021
1022         * tui/tui-wingeneral.h: Include gdb_curses.h.
1023
1024 2019-01-22  Tom Tromey  <tom@tromey.com>
1025
1026         * source-cache.h (class source_cache) <get_source_lines,
1027         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1028
1029 2019-01-22  Tom Tromey  <tom@tromey.com>
1030
1031         * remote-fileio.h (struct remote_target): Declare.
1032
1033 2019-01-22  Tom Tromey  <tom@tromey.com>
1034
1035         * python/py-arch.c: Do not include py-ref.h.
1036         * python/py-bpevent.c: Do not include py-ref.h.
1037         * python/py-cmd.c: Do not include py-ref.h.
1038         * python/py-continueevent.c: Do not include py-ref.h.
1039         * python/py-event.h: Do not include py-ref.h.
1040         * python/py-evtregistry.c: Do not include py-ref.h.
1041         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1042         * python/py-frame.c: Do not include py-ref.h.
1043         * python/py-framefilter.c: Do not include py-ref.h.
1044         * python/py-function.c: Do not include py-ref.h.
1045         * python/py-infevents.c: Do not include py-ref.h.
1046         * python/py-linetable.c: Do not include py-ref.h.
1047         * python/py-objfile.c: Do not include py-ref.h.
1048         * python/py-param.c: Do not include py-ref.h.
1049         * python/py-prettyprint.c: Do not include py-ref.h.
1050         * python/py-progspace.c: Do not include py-ref.h.
1051         * python/py-symbol.c: Do not include py-ref.h.
1052         * python/py-symtab.c: Do not include py-ref.h.
1053         * python/py-type.c: Do not include py-ref.h.
1054         * python/py-unwind.c: Do not include py-ref.h.
1055         * python/py-utils.c: Do not include py-ref.h.
1056         * python/py-value.c: Do not include py-ref.h.
1057         * python/py-varobj.c: Do not include py-ref.h.
1058         * python/py-xmethods.c: Do not include py-ref.h.
1059         * python/python.c: Do not include py-ref.h.
1060         * varobj.c: Do not include py-ref.h.
1061
1062 2019-01-22  Tom Tromey  <tom@tromey.com>
1063
1064         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1065         keyword for bcache.
1066
1067 2019-01-22  Tom Tromey  <tom@tromey.com>
1068
1069         * compile/compile-cplus-types.c: Remove a comment by #include.
1070
1071 2019-01-22  Tom Tromey  <tom@tromey.com>
1072
1073         * compile/gcc-c-plugin.h: Include compile-internal.h.
1074
1075 2019-01-22  Tom Tromey  <tom@tromey.com>
1076
1077         * stabsread.c (EXTERN): Do not define.
1078         (symnum, next_symbol_text_func, processing_gcc_compilation)
1079         (within_function, global_sym_chain, global_stabs)
1080         (previous_stab_code, this_object_header_files)
1081         (n_this_object_header_files)
1082         (n_allocated_this_object_header_files): Define.
1083         * stabsread.h (EXTERN): Never define.  Use "extern".
1084
1085 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1086
1087         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1088         history_value.
1089
1090 2019-01-21  Tom Tromey  <tom@tromey.com>
1091
1092         * ui-out.c: Fix includes.
1093         * tui/tui-source.c: Fix includes.
1094         * target.c: Fix includes.
1095         * remote.c: Fix includes.
1096         * regcache.c: Fix includes.
1097         * python/py-block.c: Fix includes.
1098         * printcmd.c: Fix includes.
1099         * or1k-tdep.c: Fix includes.
1100         * mi/mi-main.c: Fix includes.
1101         * m32r-tdep.c: Fix includes.
1102         * csky-tdep.c: Fix includes.
1103         * compile/compile-cplus-types.c: Fix includes.
1104         * cli/cli-interp.c: Fix includes.
1105
1106 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1107
1108         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1109         for padding.
1110
1111 2019-01-16  Tom Tromey  <tom@tromey.com>
1112
1113         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1114         earlier.
1115         (struct objfile) <msymbols_range>: Move from top level.
1116         <msymbols>: New method.
1117         (class objfile_msymbols): Remove.
1118         * symtab.c (default_collect_symbol_completion_matches_break_on):
1119         Update.
1120         * symmisc.c (dump_msymbols): Update.
1121         * stabsread.c (scan_file_globals): Update.
1122         * objc-lang.c (info_selectors_command, info_classes_command)
1123         (find_methods): Update.
1124         * minsyms.c (find_solib_trampoline_target): Update.
1125         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1126         * coffread.c (coff_symfile_read): Update.
1127         * ada-lang.c (ada_lookup_simple_minsym)
1128         (ada_collect_symbol_completion_matches): Update.
1129
1130 2019-01-16  Tom Tromey  <tom@tromey.com>
1131
1132         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1133         type.  Remove no-argument constructor.
1134         <iterator::operator++>: Simplify.
1135         <begin>: Update.
1136         <end>: Use minimal_symbol_count.
1137
1138 2019-01-16  Tom Tromey  <tom@tromey.com>
1139
1140         * objfiles.h (struct objfile) <psymtabs>: New method.
1141         (class objfile_psymtabs): Remove.
1142         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1143         typedef.
1144         <range>: New method.
1145         (require_partial_symbols): Change return type.
1146         * psymtab.c (require_partial_symbols)
1147         (psym_expand_symtabs_matching): Update.
1148         * mdebugread.c (parse_partial_symbols): Update.
1149         * dbxread.c (dbx_end_psymtab): Update.
1150
1151 2019-01-15  Tom Tromey  <tom@tromey.com>
1152
1153         * symtab.c (lookup_objfile_from_block)
1154         (lookup_symbol_in_objfile_symtabs)
1155         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1156         (find_line_symtab, info_sources_command)
1157         (default_collect_symbol_completion_matches_break_on)
1158         (make_source_files_completion_list): Update.
1159         * symmisc.c (print_objfile_statistics, dump_objfile)
1160         (maintenance_print_symbols, maintenance_info_symtabs)
1161         (maintenance_check_symtabs, maintenance_info_line_tables):
1162         Update.
1163         * source.c (select_source_symtab)
1164         (forget_cached_source_info_for_objfile): Update.
1165         * objfiles.h (class objfile_compunits): Remove.
1166         (struct objfile) <compunits_range>: New typedef.
1167         (compunits): New method.
1168         * objfiles.c (objfile_relocate1): Update.
1169         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1170         * maint.c (count_symtabs_and_blocks): Update.
1171         * linespec.c (iterate_over_all_matching_symtabs): Update.
1172         * cp-support.c (add_symbol_overload_list_qualified): Update.
1173         * coffread.c (coff_symtab_read): Update.
1174         * ada-lang.c (add_nonlocal_symbols)
1175         (ada_collect_symbol_completion_matches)
1176         (ada_add_global_exceptions): Update.
1177
1178 2019-01-15  Tom Tromey  <tom@tromey.com>
1179
1180         * progspace.h (program_space) <objfiles_safe_range>: New
1181         typedef.
1182         <objfiles_safe>: New method.
1183         * objfiles.h (class all_objfiles_safe): Remove.
1184         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1185         * jit.c (jit_inferior_exit_hook): Update.
1186
1187 2019-01-17  Tom Tromey  <tom@tromey.com>
1188
1189         * progspace.h (program_space) <objfiles_range>: New typedef.
1190         <objfiles>: New method.
1191         <objfiles_head>: Rename from objfiles.
1192         (object_files): Update.
1193         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1194         * guile/scm-pretty-print.c
1195         (ppscm_find_pretty_printer_from_objfiles): Update.
1196         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1197         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1198         Update.
1199         * python/py-progspace.c (pspy_get_objfiles): Update.
1200         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1201         Update.
1202         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1203         (objfpy_lookup_objfile_by_build_id): Update.
1204         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1205         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1206         Update.
1207         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1208         (expand_symtab_containing_pc, lookup_objfile_from_block)
1209         (lookup_static_symbol, basic_lookup_transparent_type)
1210         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1211         (find_line_symtab, info_sources_command)
1212         (default_collect_symbol_completion_matches_break_on)
1213         (make_source_files_completion_list, find_main_name): Update.
1214         * symmisc.c (print_symbol_bcache_statistics)
1215         (print_objfile_statistics, maintenance_print_symbols)
1216         (maintenance_print_msymbols, maintenance_print_objfiles)
1217         (maintenance_info_symtabs, maintenance_check_symtabs)
1218         (maintenance_expand_symtabs, maintenance_info_line_tables):
1219         Update.
1220         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1221         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1222         (map_overlay_command, unmap_overlay_command)
1223         (simple_overlay_update, expand_symtabs_matching)
1224         (map_symbol_filenames): Update.
1225         * symfile-debug.c (set_debug_symfile): Update.
1226         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1227         Update.
1228         * source.c (select_source_symtab, forget_cached_source_info):
1229         Update.
1230         * solib.c (solib_read_symbols): Update.
1231         * solib-spu.c (append_ocl_sos): Update.
1232         * psymtab.c (maintenance_print_psymbols)
1233         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1234         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1235         * printcmd.c (info_symbol_command): Update.
1236         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1237         Update.
1238         * objfiles.h (class all_objfiles): Remove.
1239         * objfiles.c (have_partial_symbols, have_full_symbols)
1240         (have_minimal_symbols, qsort_cmp, update_section_map)
1241         (shared_objfile_contains_address_p)
1242         (default_iterate_over_objfiles_in_search_order): Update.
1243         * objc-lang.c (info_selectors_command, info_classes_command)
1244         (find_methods): Update.
1245         * minsyms.c (find_solib_trampoline_target): Update.
1246         * maint.c (maintenance_info_sections)
1247         (maintenance_translate_address, count_symtabs_and_blocks):
1248         Update.
1249         * main.c (captured_main_1): Update.
1250         * linux-thread-db.c (try_thread_db_load_from_pdir)
1251         (has_libpthread): Update.
1252         * linespec.c (iterate_over_all_matching_symtabs)
1253         (search_minsyms_for_name): Update.
1254         * jit.c (jit_find_objf_with_entry_addr): Update.
1255         * hppa-tdep.c (find_unwind_entry)
1256         (hppa_lookup_stub_minimal_symbol): Update.
1257         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1258         Update.
1259         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1260         (elf_gnu_ifunc_resolve_by_got): Update.
1261         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1262         * dwarf-index-write.c (save_gdb_index_command): Update.
1263         * cp-support.c (add_symbol_overload_list_qualified): Update.
1264         * breakpoint.c (create_overlay_event_breakpoint)
1265         (create_longjmp_master_breakpoint)
1266         (create_std_terminate_master_breakpoint)
1267         (create_exception_master_breakpoint): Update.
1268         * blockframe.c (find_pc_partial_function): Update.
1269         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1270         (ada_collect_symbol_completion_matches)
1271         (ada_add_global_exceptions): Update.
1272
1273 2019-01-17  Tom Tromey  <tom@tromey.com>
1274
1275         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1276         declare VEC.
1277         (solib_target_parse_libraries): Change return type.
1278         (library_list_start_segment, library_list_start_section)
1279         (library_list_end_library, library_list_start_library); Update.
1280         (solib_target_free_library_list): Remove.
1281         (solib_target_parse_libraries): Remove cleanup.  Change return
1282         type.
1283         (solib_target_current_sos): Update.
1284
1285 2019-01-17  Tom Tromey  <tromey@bapiya>
1286
1287         * valprint.c: Replace "the the" with "the".
1288         * symtab.c: Replace "the the" with "the".
1289         * solib.c: Replace "the the" with "the".
1290         * solib-dsbt.c: Replace "the the" with "the".
1291         * linespec.c: Replace "the the" with "the".
1292         * dwarf2loc.h: Replace "the the" with "the".
1293         * amd64-windows-tdep.c: Replace "the the" with "the".
1294         * aarch64-tdep.c: Replace "the the" with "the".
1295
1296 2019-01-16  Keith Seitz  <keiths@redhat.com>
1297
1298         PR gdb/23773
1299         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1300         <builder>: Rename to ..
1301         <m_builder>: ... this and make private.
1302         (dwarf2_cu::get_builder): New method.  Change all users of
1303         `builder' to use this method.
1304         (dwarf2_start_symtab): Move to ...
1305         (dwarf2_cu::start_symtab): ... here.  Update all callers
1306         (setup_type_unit_groups): Move to ...
1307         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1308         callers.
1309         (dwarf2_cu::reset_builder): New method.
1310         (process_full_compunit, process_full_type_unit): Use
1311         dwarf2_cu::reset_builder.
1312         (follow_die_offset): Record the ancestor CU if it is different
1313         from the followed DIE's CU.
1314         (follow_die_sig_1): Likewise.
1315
1316 2019-01-15  Tom Tromey  <tom@tromey.com>
1317
1318         * remote.c (class remote_state) <buf>: Now a char_vector.
1319         <buf_size>: Remove.
1320         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1321         parameter.
1322         (remote_target::getpkt_or_notif_sane_1)
1323         (remote_target::getpkt_sane)
1324         (remote_target::getpkt_or_notif_sane): Likewise.
1325         (class remote_target) <putpkt>: New overload.
1326         (remote_target::read_frame): Change type of "buf_p".  Remove
1327         sizeof_p parameter.
1328         (packet_ok): New overload.
1329         (packet_check_result): New overload.
1330         Update all uses.
1331
1332 2019-01-14  Tom Tromey  <tom@tromey.com>
1333
1334         * remote-notif.c (handle_notification, remote_notif_ack)
1335         (remote_notif_parse): Make "buf" const.
1336         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1337         const.
1338         (remote_notif_parse, remote_notif_ack, handle_notification):
1339         Likewise.
1340         * remote.c (remote_notif_stop_parse): Make "buf" const.
1341         (remote_target::remote_parse_stop_reply): Make "buf" const.
1342         (remote_notif_stop_ack): Make "buf" const.
1343
1344 2019-01-14  Tom Tromey  <tom@tromey.com>
1345
1346         * remote.c (remote_console_output): Make parameter const.
1347
1348 2019-01-14  Tom Tromey  <tom@tromey.com>
1349
1350         * target-debug.h (target_debug_print_signals): Constify.
1351         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1352         * procfs.c (procfs_target::pass_signals): Update.
1353         * linux-nat.c (linux_nat_target::pass_signals): Update.
1354         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1355         * target-delegates.c: Rebuild.
1356         * remote.c (remote_target::program_signals): Update.
1357         (remote_target::pass_signals): Update.
1358         * target.c (target_pass_signals): Constify argument.
1359         (target_program_signals): Likewise.
1360         * target.h (struct target_ops) <pass_signals, program_signals>:
1361         Constify argument.
1362         (target_pass_signals, target_program_signals): Constify argument.
1363
1364 2019-01-14  Tom Tromey  <tom@tromey.com>
1365
1366         PR tui/28819:
1367         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1368
1369 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1370
1371         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1372         field.
1373         * rs6000-tdep.c: Include reggroups.h.
1374         (IS_V_ALIAS_PSEUDOREG): Define.
1375         (rs6000_register_name): Return names for the "vX" aliases.
1376         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1377         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1378         aliases.  Call default_register_reggroup_p for all other
1379         pseudo-registers.
1380         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1381         New functions.
1382         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1383         Handle "vX" aliases.
1384         (v_alias_pseudo_register_collect): New function.
1385         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1386         (rs6000_gdbarch_init): Initialize "vX" aliases as
1387         pseudo-registers.  Restore registration of
1388         rs6000_pseudo_register_reggroup_p with
1389         set_tdesc_pseudo_register_reggroup_p.
1390
1391 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1392
1393         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1394         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1395         set_gdbarch_num_pseudo_regs.
1396
1397 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1398
1399         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1400         Remove arg prefixname, add do_set and do_show.
1401         Add member functions set_list and show_list.
1402         * cli/cli-style.c (class cli_style_option): Update accordingly.
1403         (style_set_list): Move to file scope.
1404         (style_show_list): Likewise.
1405         (set_style): Call help_list.
1406         (show_style): Call cmd_show_list.
1407         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1408         Update to use the new macro.
1409
1410 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1411
1412         * ada-lang.c (_initialize_ada_language): Expand the help text
1413         for the "catch exception" command.
1414
1415 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1416
1417         * symtab.c (matching_obj_sections): Initialize obj,
1418         declare it closer to its usage.
1419
1420 2019-01-10  Tom Tromey  <tom@tromey.com>
1421
1422         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1423         (basic_inf_threads_range): Remove.
1424         (inf_threads_range, inf_non_exited_threads_range)
1425         (safe_inf_threads_range): Use next_adapter.
1426
1427 2019-01-10  Keith Seitz  <keiths@redhat.com>
1428
1429         PR gdb/23712
1430         PR symtab/23010
1431         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1432         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1433
1434 2019-01-10  Keith Seitz  <keiths@redhat.com>
1435
1436         PR gdb/23712
1437         PR symtab/23010
1438         * dictionary.c (pending_to_vector): Remove.
1439         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1440         Remove _1 suffix, replacing functions of the same name.  Update
1441         all callers.
1442         (dict_create_hashed, dict_create_hashed_expandable)
1443         (dict_create_linear, dict_create_linear_expandable, dict_free)
1444         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1445         Make functions static.
1446
1447 2019-01-10  Keith Seitz  <keiths@redhat.com>
1448
1449         PR gdb/23712
1450         PR symtab/23010
1451         * dictionary.h (struct dictionary): Replace declaration with
1452         multidictionary.
1453         (dict_create_hashed, dict_create_hashed_expandable)
1454         (dict_create_linear, dict_create_linear_expandable)
1455         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1456         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1457         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1458         taking multidictionary argument.
1459         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1460         * block.h (struct block) <dict>: Change to multidictionary
1461         and rename `multidict'.
1462         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1463         symmisc.c: Update all dictionary references to multidictionary.
1464
1465 2019-01-10  Keith Seitz  <keiths@redhat.com>
1466
1467         PR gdb/23712
1468         PR symtab/23010
1469         * dictionary.c: Include unordered_map.
1470         (pending_to_vector): New function.
1471         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1472         Rewrite the non-"_1" functions to take vector instead
1473         of linked list.
1474         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1475         "new" _1 versions of the same name.
1476         (multidictionary): Define.
1477         (std::hash<enum language): New definition.
1478         (collate_pending_symbols_by_language, mdict_create_hashed)
1479         (mdict_create_hashed_expandable, mdict_create_linear)
1480         (mdict_create_linear_expandable, mdict_free)
1481         (find_language_dictionary, create_new_language_dictionary)
1482         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1483         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1484         (mdict_size, mdict_empty): New functions.
1485         * dictionary.h (mdict_iterator): Define.
1486
1487 2019-01-10  Pedro Alves  <palves@redhat.com>
1488
1489         * breakpoint.c (read_uploaded_action)
1490         (create_tracepoint_from_upload): Adjust to use
1491         gdb::unique_xmalloc_ptr.
1492         * ctf.c (ctf_write_uploaded_tp):
1493         (SET_ARRAY_FIELD): Use emplace_back.
1494         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1495         * tracefile-tfile.c (tfile_write_uploaded_tp):
1496         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1497         gdb::unique_xmalloc_ptr.
1498         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1499         at_string, cond_string, cmd_strings>: Replace char pointers
1500         with gdb::unique_xmalloc_ptr.
1501
1502 2019-01-10  Pedro Alves  <palves@redhat.com>
1503
1504         * solib-target.c (library_list_start_library): Don't xstrdup name.
1505
1506 2019-01-10  Pedro Alves  <palves@redhat.com>
1507
1508         * mdebugread.c (parse_partial_symbols): Use
1509         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1510
1511 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1512
1513         * linux-fork.c (scoped_switch_fork_info)
1514         <~scoped_switch_fork_info>: Fix incorrect variable name.
1515
1516 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1517
1518         * linux-fork.c (scoped_switch_fork_info)
1519         <scoped_switch_fork_info>: Make explicit.
1520         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1521
1522 2019-01-10  Tom Tromey  <tom@tromey.com>
1523
1524         * objfiles.h (objfile::reset_psymtabs): Update.
1525         * objfiles.c (objfile::objfile): Update.
1526         * psymtab.h (psymtab_storage::obstack): Update.
1527         (psymtab_storage::m_obstack): Use gdb::optional.
1528         (class psymtab_storage): Update comment.  Remove objfile
1529         parameter.
1530         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1531
1532 2019-01-10  Tom Tromey  <tom@tromey.com>
1533
1534         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1535         <free_psymtabs>: Now private.
1536         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1537         (allocate_psymtab): Use new method.
1538
1539 2019-01-10  Tom Tromey  <tom@tromey.com>
1540
1541         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1542         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1543         * mdebugread.c (parse_partial_symbols): Use
1544         allocate_dependencies.
1545         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1546         allocate_dependencies.
1547         (process_psymtab_comp_unit_reader)
1548         (build_type_psymtab_dependencies): Likewise.
1549         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1550
1551 2019-01-10  Tom Tromey  <tom@tromey.com>
1552
1553         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1554         PSYMBOL_SET_LANGUAGE.
1555         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1556
1557 2019-01-10  Tom Tromey  <tom@tromey.com>
1558
1559         * psymtab.h (psymtab_storage::obstack): New method.
1560         <m_obstack>: Rename from obstack; now private.
1561         * psymtab.c (psymtab_storage): Update.
1562         * dwarf2read.c (create_addrmap_from_index)
1563         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1564         Update.
1565
1566 2019-01-10  Tom Tromey  <tom@tromey.com>
1567
1568         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1569         * objfiles.h (objfile::reset_psymtabs): New method.
1570
1571 2019-01-10  Tom Tromey  <tom@tromey.com>
1572
1573         * symmisc.c (print_symbol_bcache_statistics): Update.
1574         (print_objfile_statistics): Update.
1575         * symfile.c (reread_symbols): Update.
1576         * psymtab.h (class psymtab_storage): New.
1577         * psymtab.c (psymtab_storage): New constructor.
1578         (~psymtab_storage): New destructor.
1579         (require_partial_symbols): Update.
1580         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1581         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1582         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1583         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1584         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1585         (start_psymtab_common, end_psymtab_common)
1586         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1587         (allocate_psymtab): Update.
1588         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1589         Update.
1590         (dump_psymtab_addrmap, maintenance_print_psymbols)
1591         (maintenance_check_psymtabs): Update.
1592         (class objfile_psymtabs): Move to objfiles.h.
1593         * psympriv.h (discard_psymtab): Now inline.
1594         (psymtab_discarder::psymtab_discarder): Update.
1595         (psymtab_discarder::~psymtab_discarder): Update.
1596         (ALL_OBJFILE_PSYMTABS): Rewrite.
1597         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1598         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1599         Remove fields.
1600         <partial_symtabs>: New field.
1601         (class objfile_psymtabs): Move from psymtab.h.  Update.
1602         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1603         psymbol_cache.
1604         (objfile::~objfile): Don't destroy psymbol_cache.
1605         * mdebugread.c (parse_partial_symbols): Update.
1606         * dwarf2read.c (create_addrmap_from_index)
1607         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1608         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1609         (add_partial_subprogram, dwarf2_ranges_read): Update.
1610         * dwarf-index-write.c (write_address_map)
1611         (write_one_signatured_type, recursively_write_psymbols)
1612         (class debug_names, class debug_names, write_psymtabs_to_index):
1613         Update.
1614
1615 2019-01-10  Tom Tromey  <tom@tromey.com>
1616
1617         * symtab.h (SYMBOL_SET_NAMES): Update.
1618         (symbol_set_names): Update.
1619         (MSYMBOL_SET_NAMES): Update.
1620         * symtab.c (symbol_set_names): Change argument to be an
1621         objfile_per_bfd_storage.
1622         * psymtab.c (add_psymbol_to_bcache): Update.
1623         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1624
1625 2019-01-10  Tom Tromey  <tom@tromey.com>
1626
1627         * symtab.c (create_demangled_names_hash): Change argument to be an
1628         objfile_per_bfd_storage.
1629         (symbol_set_names): Update.
1630
1631 2019-01-10  Tom Tromey  <tom@tromey.com>
1632
1633         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1634         init_psymbol_list.
1635         * psymtab.c (init_psymbol_list): Do nothing if already called.
1636         * psympriv.h (init_psymbol_list): Add comment.
1637         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1638         init_psymbol_list.
1639         * dbxread.c (dbx_symfile_read): Unconditionally call
1640         init_psymbol_list.
1641
1642 2019-01-10  Tom Tromey  <tom@tromey.com>
1643
1644         * xcoffread.c (scan_xcoff_symtab): Update.
1645         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1646         "where".
1647         * mdebugread.c (parse_partial_symbols)
1648         (handle_psymbol_enumerators): Update.
1649         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1650         * dbxread.c (read_dbx_symtab): Update.
1651         * psympriv.h (psymbol_placement): New enum.
1652         (add_psymbol_to_list): Update.
1653
1654 2019-01-10  Tom Tromey  <tom@tromey.com>
1655
1656         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1657         static_psymbols parameters.
1658         (scan_xcoff_symtab): Update.
1659         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1660         static_psymbols parameters.
1661         * psympriv.h (start_psymtab_common): Update.
1662         * mdebugread.c (parse_partial_symbols): Update.
1663         * dwarf2read.c (create_partial_symtab): Update.
1664         * dbxread.c (read_dbx_symtab): Update.
1665         (start_psymtab): Remove global_psymbols and static_psymbols
1666         parameters.
1667
1668 2019-01-10  Tom Tromey  <tom@tromey.com>
1669
1670         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1671         * psymtab.c (allocate_psymtab): Add comment.
1672         * psympriv.h (allocate_psymtab): Add comment.
1673         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1674         initializations.
1675         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1676
1677 2019-01-10  Tom Tromey  <tom@tromey.com>
1678
1679         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1680         Don't declare.
1681         * mipsread.c: Include mdebugread.h.
1682         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1683         Declare.
1684         * elfread.c: Include mdebugread.h.
1685
1686 2019-01-09  Tom Tromey  <tom@tromey.com>
1687
1688         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1689         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1690         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1691         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1692         (psym_lookup_symbol, psym_find_last_source_symtab)
1693         (psym_forget_cached_source_info, psym_print_stats)
1694         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1695         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1696         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1697         (psym_find_compunit_symtab_by_address)
1698         (maintenance_print_psymbols, maintenance_info_psymtabs)
1699         (maintenance_check_psymtabs): Use ranged for.
1700         * psymtab.h (class objfile_psymtabs): New.
1701         (require_partial_symbols): Return objfile_psymtabs.
1702         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1703
1704 2019-01-09  Tom Tromey  <tom@tromey.com>
1705
1706         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1707         (find_pc_mapped_section, list_overlays_command)
1708         (map_overlay_command, unmap_overlay_command)
1709         (simple_overlay_update): Use all_objfiles.
1710         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1711         * printcmd.c (info_symbol_command): Use all_objfiles.
1712         * objfiles.h (ALL_OBJSECTIONS): Remove.
1713         * maint.c (maintenance_translate_address): Use all_objfiles.
1714         * gcore.c (gcore_create_callback): Use all_objfiles.
1715         (objfile_find_memory_regions): Likewise.
1716
1717 2019-01-09  Tom Tromey  <tom@tromey.com>
1718
1719         * symtab.c (find_line_symtab, info_sources_command)
1720         (make_source_files_completion_list): Use objfile_compunits.
1721         * source.c (select_source_symtab): Use objfile_compunits.
1722         * objfiles.h (struct objfile): Update comment.
1723         (ALL_OBJFILES): Remove.
1724         (ALL_FILETABS): Remove.
1725         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
1726         objfile_compunits.
1727
1728 2019-01-09  Tom Tromey  <tom@tromey.com>
1729
1730         * symmisc.c (print_objfile_statistics, dump_objfile)
1731         (maintenance_print_symbols): Use compunit_filetabs.
1732         * source.c (forget_cached_source_info_for_objfile): Use
1733         compunit_filetabs.
1734         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
1735         (ALL_FILETABS): Use compunit_filetabs.
1736         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
1737         * coffread.c (coff_symtab_read): Use compunit_filetabs.
1738
1739 2019-01-09  Tom Tromey  <tom@tromey.com>
1740
1741         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
1742         (compunit_filetabs): New.
1743         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
1744         compunit_filetabs.
1745         (info_sources_command, make_source_files_completion_list): Remove
1746         declaration.
1747         * symmisc.c (print_objfile_statistics, dump_objfile)
1748         (maintenance_print_symbols): Remove declaration.
1749         (maintenance_info_symtabs): Use compunit_filetabs.
1750         (maintenance_info_line_tables): Likewise.
1751         * source.c (select_source_symtab): Change local variable name.
1752         (forget_cached_source_info_for_objfile): Remove declaration.
1753         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
1754         * objfiles.c (objfile_relocate1): Remove declaration.
1755         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1756         declaration.
1757         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
1758         * coffread.c (coff_symtab_read): Remove declaration.
1759         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1760         compunit_filetabs.
1761
1762 2019-01-09  Tom Tromey  <tom@tromey.com>
1763
1764         * symtab.c (lookup_objfile_from_block)
1765         (find_pc_sect_compunit_symtab, search_symbols)
1766         (default_collect_symbol_completion_matches_break_on): Use
1767         objfile_compunits.
1768         * objfiles.h (ALL_COMPUNITS): Remove.
1769         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
1770         * cp-support.c (add_symbol_overload_list_qualified): Use
1771         objfile_compunits.
1772         * ada-lang.c (ada_collect_symbol_completion_matches)
1773         (ada_add_global_exceptions): Use objfile_compunits.
1774
1775 2019-01-09  Tom Tromey  <tom@tromey.com>
1776
1777         * source.c (select_source_symtab)
1778         (forget_cached_source_info_for_objfile): Remove declaration.
1779         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1780         declaration.
1781         * maint.c (count_symtabs_and_blocks): Remove declaration.
1782         * cp-support.c (add_symbol_overload_list_qualified): Remove
1783         declaration.
1784         * coffread.c (coff_symtab_read): Remove declaration.
1785         * symtab.c (lookup_symbol_in_objfile_symtabs)
1786         (basic_lookup_transparent_type_1): Use objfile_compunits.
1787         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
1788         (info_sources_command, search_symbols)
1789         (default_collect_symbol_completion_matches_break_on)
1790         (make_source_files_completion_list): Remove declaration.
1791         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
1792         (ada_collect_symbol_completion_matches)
1793         (ada_add_global_exceptions): Remove declaration.
1794         * linespec.c (iterate_over_all_matching_symtabs): Use
1795         objfile_compunits.
1796         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
1797         (class objfile_compunits): New.
1798         (ALL_COMPUNITS): Use objfile_compunits.
1799         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
1800         (maintenance_check_symtabs, maintenance_info_line_tables): Use
1801         objfile_compunits.
1802         * objfiles.c (objfile_relocate1): Use objfile_compunits.
1803
1804 2019-01-09  Tom Tromey  <tom@tromey.com>
1805
1806         * symtab.c (search_symbols)
1807         (default_collect_symbol_completion_matches_break_on): Use
1808         objfile_msymbols.
1809         * ada-lang.c (ada_lookup_simple_minsym)
1810         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
1811         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
1812         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
1813         objfile_msymbols.
1814         * coffread.c (coff_symfile_read): Use objfile_msymbols.
1815         * symmisc.c (dump_msymbols): Use objfile_msymbols.
1816         * objc-lang.c (find_methods): Use objfile_msymbols.
1817         (info_selectors_command, info_classes_command): Likewise.
1818         * stabsread.c (scan_file_globals): Use objfile_msymbols.
1819         * objfiles.h (class objfile_msymbols): New.
1820         (ALL_OBJFILE_MSYMBOLS): Remove.
1821         (ALL_MSYMBOLS): Remove.
1822
1823 2019-01-09  Tom Tromey  <tom@tromey.com>
1824
1825         * common/next-iterator.h (next_adapter): Add Iterator template
1826         parameter.
1827         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
1828         (class all_objfiles_safe): New.
1829         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
1830         * objfiles.c (put_objfile_before): Update comment.
1831         (add_separate_debug_objfile): Likewise.
1832         (free_all_objfiles): Use all_objfiles_safe.
1833         (objfile_purge_solibs): Likewise.
1834
1835 2019-01-09  Tom Tromey  <tom@tromey.com>
1836
1837         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1838         (expand_symtab_containing_pc, lookup_static_symbol)
1839         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
1840         (find_symbol_at_address, find_line_symtab, find_main_name): Use
1841         all_objfiles.
1842         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
1843         * breakpoint.c (create_overlay_event_breakpoint)
1844         (create_longjmp_master_breakpoint)
1845         (create_std_terminate_master_breakpoint)
1846         (create_exception_master_breakpoint): Use all_objfiles.
1847         * linux-thread-db.c (try_thread_db_load_from_pdir)
1848         (has_libpthread): Use all_objfiles.
1849         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
1850         * linespec.c (iterate_over_all_matching_symtabs)
1851         (search_minsyms_for_name): Use all_objfiles.
1852         * maint.c (maintenance_info_sections): Use all_objfiles.
1853         * main.c (captured_main_1): Use all_objfiles.
1854         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
1855         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
1856         * guile/scm-pretty-print.c
1857         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
1858         * solib-spu.c (append_ocl_sos): Use all_objfiles.
1859         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
1860         (maintenance_print_msymbols): Use all_objfiles.
1861         * source.c (select_source_symtab): Use all_objfiles.
1862         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
1863         * symfile.c (remove_symbol_file_command)
1864         (expand_symtabs_matching, map_symbol_filenames): Use
1865         all_objfiles.
1866         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
1867         all_objfiles.
1868         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
1869         * objc-lang.c (find_methods): Use all_objfiles.
1870         * objfiles.c (have_partial_symbols, have_full_symbols)
1871         (have_minimal_symbols, qsort_cmp)
1872         (default_iterate_over_objfiles_in_search_order): Use
1873         all_objfiles.
1874         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
1875         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
1876         (maintenance_check_psymtabs): Use all_objfiles.
1877         (ALL_PSYMTABS): Remove.
1878         * compile/compile-object-run.c (do_module_cleanup): Use
1879         all_objfiles.
1880         * blockframe.c (find_pc_partial_function): Use all_objfiles.
1881         * cp-support.c (add_symbol_overload_list_qualified): Use
1882         all_objfiles.
1883         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1884         Use all_objfiles.
1885         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
1886         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
1887         all_objfiles.
1888         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1889         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
1890         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1891         Uses all_objfiles.
1892         * solib.c (solib_read_symbols): Use all_objfiles
1893
1894 2019-01-09  Tom Tromey  <tom@tromey.com>
1895
1896         * probe.c (parse_probes_in_pspace): Use all_objfiles.
1897         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
1898         all_objfiles.
1899         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
1900         * symmisc.c (print_symbol_bcache_statistics)
1901         (print_objfile_statistics, maintenance_print_objfiles)
1902         (maintenance_info_symtabs, maintenance_check_symtabs)
1903         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
1904         all_objfiles.
1905         * source.c (forget_cached_source_info): Use all_objfiles.
1906         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
1907         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1908         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
1909         * objfiles.c (update_section_map): Use all_objfiles.
1910         (shared_objfile_contains_address_p): Likewise.
1911         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
1912         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
1913
1914 2019-01-09  Tom Tromey  <tom@tromey.com>
1915
1916         * common/next-iterator.h: New file.
1917         * objfiles.h (class all_objfiles): New.
1918         (struct objfile_iterator): New.
1919
1920 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1921
1922         * NEWS: Move the description of the changed "frame", "select-frame",
1923          and "info frame" commands to the Changed commands section.
1924
1925 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
1926
1927         * gdbtypes.c (check_stub_method_group): Remove handling of old
1928         mangling schemes.
1929         * linespec.c (find_methods): Likewise.
1930         * stabsread.c (read_member_functions): Likewise.
1931         * valops.c (search_struct_method): Likewise.
1932         (value_struct_elt_for_reference): Likewise.
1933         * NEWS: Mention this change.
1934
1935 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1936
1937         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
1938         print_source_lines.
1939         * source.c (print_source_lines_base): Update line number check.
1940         (print_source_lines): New function.
1941         (source_lines_range::source_lines_range): New function.
1942         * source.h (class source_lines_range): New class.
1943         (print_source_lines): New declaration.
1944
1945 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1946
1947         * linespec.c (linespec_state_destructor): Free self->canonical_names.
1948
1949 2019-01-08  Tom Tromey  <tom@tromey.com>
1950             Simon Marchi  <simon.marchi@ericsson.com>
1951
1952         PR gdb/24060
1953         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
1954         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
1955         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1956         * f-exp.y (DOLLAR_VARIABLE): Likewise.
1957         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
1958         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1959
1960 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1961
1962         * source.c (select_source_symtab): Move header comment to
1963         declaration in source.h.
1964         (forget_cached_source_info_for_objfile): Likewise.
1965         (forget_cached_source_info): Likewise.
1966         (identify_source_line): Likewise.
1967         * source.h (identify_source_line): Move declaration from symtab.h
1968         and add comment from source.c
1969         (print_source_lines): Likewise.
1970         (forget_cached_source_info_for_objfile): Likewise.
1971         (forget_cached_source_info): Likewise.
1972         (select_source_symtab): Likewise.
1973         (enum print_source_lines_flag): Move definition from symtab.h.
1974         * symtab.h (identify_source_line): Move declaration to source.h.
1975         (print_source_lines): Likewise.
1976         (forget_cached_source_info_for_objfile): Likewise.
1977         (forget_cached_source_info): Likewise.
1978         (select_source_symtab): Likewise.
1979         (enum print_source_lines_flag): Move definition to source.h.
1980         * tui/tui-hooks.c: Add 'source.h' include.
1981
1982 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1983
1984         * source.c (print_source_lines_base): Handle requests to print
1985         reverse line number sequences, and guard against empty lines
1986         string.
1987
1988 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1989
1990         * source.c (print_source_lines_base): Fix skip of '\r' if next
1991         character is '\n'.
1992
1993 2019-01-06  Tom Tromey  <tom@tromey.com>
1994
1995         * c-exp.y (struct c_parse_state) <macro_original_text,
1996         expansion_obstack>: New member.
1997         (macro_original_text, expansion_obstack): Remove globals.
1998         (scan_macro_expansion, scanning_macro_expansion)
1999         (finished_macro_expansion): Update.
2000         (scan_macro_cleanup): Remove.
2001         (yylex, c_parse): Update.
2002
2003 2019-01-06  Tom Tromey  <tom@tromey.com>
2004
2005         * c-exp.y (struct c_parse_state) <strings>: New member.
2006         (operator_stoken): Update.
2007
2008 2019-01-06  Tom Tromey  <tom@tromey.com>
2009
2010         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2011         (union type_stack_elt) <typelist_val>: Now a pointer to
2012         std::vector.
2013         (type_stack_cleanup): Don't declare.
2014         (push_typelist): Update.
2015         * parse.c (pop_typelist): Return a std::vector.
2016         (push_typelist): Take a std::vector.
2017         (follow_types): Update.  Do not free args.
2018         (type_stack_cleanup): Remove.
2019         * c-exp.y (struct c_parse_state): New.
2020         (cpstate): New global.
2021         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2022         (nonempty_typelist): Update.
2023         (func_mod): Create a new vector.
2024         (c_parse): Create a c_parse_state.
2025         (check_parameter_typelist): Do not delete params.
2026         (function_method): Update.  Do not delete type_list.
2027
2028 2019-01-06  Tom Tromey  <tom@tromey.com>
2029
2030         PR gdb/28155:
2031         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2032         check_typedef.
2033         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2034         (print_return_value): Likewise.
2035
2036 2019-01-05  Tom Tromey  <tom@tromey.com>
2037
2038         * contrib/cleanup_check.py: Remove.
2039         * contrib/gcc-with-excheck: Remove.
2040         * contrib/exsummary.py: Remove.
2041         * contrib/excheck.py: Remove.
2042
2043 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2044
2045         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2046         NULL. Initialize tpprev to NULL instead of assigning it
2047         to NULL on the next statement.
2048         * windows-nat.c (windows_delete_thread): Remove check for
2049         main_thread_id before printing thread exit notifications.
2050         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2051         Remove thread ID check against main_thread_id.
2052         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2053         windows_delete_thread.
2054         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2055
2056 2019-01-04  Tom Tromey  <tom@tromey.com>
2057
2058         * compile/compile.c (_initialize_compile): Use upper case for
2059         metasyntactic variables.
2060         * symmisc.c (_initialize_symmisc): Use upper case for
2061         metasyntactic variables.
2062         * psymtab.c (_initialize_psymtab): Use upper case for
2063         metasyntactic variables.
2064         * demangle.c (demangle_command): Use upper case for metasyntactic
2065         variables.
2066         (_initialize_demangler): Likewise.
2067         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2068         variables.
2069
2070 2019-01-03  Tom Tromey  <tom@tromey.com>
2071
2072         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2073
2074 2019-01-03  Tom Tromey  <tom@tromey.com>
2075
2076         * python/py-symtab.c (salpy_str): Update.
2077         (struct salpy_sal_object) <symtab>: Now a PyObject.
2078         (salpy_dealloc): Update.
2079         (del_objfile_sal): Use gdbpy_ref.
2080
2081 2019-01-03  Tom Tromey  <tom@tromey.com>
2082
2083         * python/py-type.c (convert_field): Use new_reference.  Return
2084         gdbpy_ref.
2085         (make_fielditem): Return gdbpy_ref.
2086         (typy_fields): Update.
2087         (typy_getitem): Update.
2088         (field_name): Return gdbpy_ref.  Use new_reference.
2089         (typy_iterator_iternext): Update.
2090
2091 2019-01-03  Tom Tromey  <tom@tromey.com>
2092
2093         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2094
2095 2019-01-03  Tom Tromey  <tom@tromey.com>
2096
2097         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2098         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2099         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2100         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2101         (pspy_set_type_printers): Likewise.
2102         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2103         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2104         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2105         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2106         (objfpy_set_type_printers): Likewise.
2107
2108 2019-01-03  Tom Tromey  <tom@tromey.com>
2109
2110         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2111         (gdbpy_print_stack): Use gdbpy_err_fetch.
2112         * python/python-internal.h (class gdbpy_err_fetch): New class.
2113         (class gdbpy_enter) <m_error_type, m_error_value,
2114         m_error_traceback>: Remove.
2115         <m_error>: New member.
2116         (gdbpy_exception_to_string): Don't declare.
2117         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2118         * python/py-value.c (convert_value_from_python): Use
2119         gdbpy_err_fetch.
2120         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2121         gdbpy_exception_to_string.
2122         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2123         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2124         gdbpy_err_fetch.
2125
2126 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2127
2128         * linux-nat.c (delete_lwp_cleanup): Delete.
2129         (struct lwp_deleter): New struct.
2130         (lwp_info_up): New typedef.
2131         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2132         lwp_info_up.
2133
2134 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2135
2136         * linux-fork.c (class scoped_switch_fork_info): New class.
2137         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2138
2139 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2140
2141         * valops.c (find_overload_match): Remove use of null_cleanup, and
2142         calls to do_cleanups.
2143
2144 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2145
2146         * compile/compile-cplus-types.c
2147         (compile_cplus_instance::decl_name): Handle changes to
2148         cp_func_name.
2149         * cp-support.c (cp_func_name): Update header comment, update
2150         return type.
2151         * cp-support.h (cp_func_name): Update return type in declaration.
2152         * valops.c (find_overload_match): Move temp_func local to top
2153         level of function and change its type.  Use temp_func to hold and
2154         delete temporary string obtained from cp_func_name.
2155
2156 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2157
2158         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2159         gdb::char_vector, remove cleanup, and update uses of `msg`.
2160
2161 2019-01-03  Jim Wilson  <jimw@sifive.com>
2162
2163         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2164
2165 2019-01-02  Tom Tromey  <tom@tromey.com>
2166
2167         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2168         (tdesc_parse_xml): Remove cleanups.
2169         * target-descriptions.h (make_cleanup_free_target_description):
2170         Don't declare.
2171         (target_desc_deleter): New struct.
2172         (target_desc_up): New typedef.
2173         * target-descriptions.c (target_desc_deleter::operator()): Rename
2174         from free_target_description.
2175         (make_cleanup_free_target_description): Remove.
2176
2177 2019-01-02  Tom Tromey  <tom@tromey.com>
2178
2179         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2180         constructor, destructor.
2181         (linespec_parser): Remove typedef.
2182         (~linespec_parser): Rename from linespec_parser_delete.
2183         (linespec_lex_to_end, linespec_complete_label)
2184         (linespec_complete): Update.
2185         (decode_line_full): Remove cleanups.
2186         (decode_line_1): Update.
2187
2188 2019-01-02  Tom Tromey  <tom@tromey.com>
2189
2190         * python/python-internal.h (inferior_to_inferior_object): Change
2191         return type.
2192         * python/py-exitedevent.c (create_exited_event_object): Update.
2193         * python/py-inferior.c (inferior_to_inferior_object): Return
2194         gdbpy_ref.
2195         (python_new_inferior, python_inferior_deleted)
2196         (thread_to_thread_object, delete_thread_object)
2197         (build_inferior_list, gdbpy_selected_inferior): Update.
2198         * python/py-infthread.c (create_thread_object): Update.  Also fail
2199         if inferior_to_inferior_object fails.
2200
2201 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2202
2203         * inferior.h (class inferior) <displaced_step_state>: New field.
2204         * infrun.h (struct displaced_step_state): Move here from
2205         infrun.c.  Initialize fields, add constructor.
2206         <inf>: Remove field.
2207         <reset>: New method.
2208         * infrun.c (struct displaced_step_inferior_state): Move to
2209         infrun.h.
2210         (displaced_step_inferior_states): Remove.
2211         (get_displaced_stepping_state): Adust.
2212         (displaced_step_in_progress_any_inferior): Adjust.
2213         (displaced_step_in_progress_thread): Adjust.
2214         (displaced_step_in_progress): Adjust.
2215         (add_displaced_stepping_state): Remove.
2216         (get_displaced_step_closure_by_addr): Adjust.
2217         (remove_displaced_stepping_state): Remove.
2218         (infrun_inferior_exit): Call displaced_step_state.reset.
2219         (use_displaced_stepping): Don't check for NULL.
2220         (displaced_step_prepare_throw): Call
2221         get_displaced_stepping_state.
2222         (displaced_step_fixup): Don't check for NULL.
2223         (prepare_for_detach): Don't check for NULL.
2224
2225 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2226
2227         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2228          in case of call that did not complete.
2229
2230 2019-01-02  Andrey Utkin  <autkin@undo.io>
2231
2232         * symfile.c (find_separate_debug_file): Fix search of debug files for
2233         remote debuggee.
2234
2235 2019-01-02  Tom Tromey  <tom@tromey.com>
2236
2237         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2238         indentation.
2239         * python/py-frame.c (frapy_older): Remove cast.
2240         (frapy_newer): Likewise.
2241         * python/py-breakpoint.c (local_setattro): Remove cast.
2242         * python/py-arch.c (archpy_name): Remove local variable.
2243         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2244
2245 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2246
2247         * unittests/basic_string_view/element_access/char/empty.cc:
2248         Fix year range in copyright header.
2249
2250 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2251
2252         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2253         Delete.
2254         <operator==>: Update with for removed field.
2255         <hash>: Likewise.
2256         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2257         <isa_features>: ...this.
2258         <abi_features>: New field.
2259         (riscv_isa_flen): Update comment.
2260         (riscv_abi_xlen): New declaration.
2261         (riscv_abi_flen): New declaration.
2262         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2263         isa_features.
2264         (riscv_abi_xlen): New function.
2265         (riscv_isa_flen): Update to get answer from isa_features.
2266         (riscv_abi_flen): New function.
2267         (riscv_has_fp_abi): Update to get answer from abi_features.
2268         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2269         xlen and flen.
2270         (riscv_call_info) <xlen, flen>: Update comment.
2271         (riscv_call_arg_struct): Remove invalid assertions
2272         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2273         is removed.
2274         (riscv_gdbarch_init): Gather isa features and abi features
2275         separately, ensure both match on the gdbarch when reusing an old
2276         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2277         a target with 64-bit float hardware.
2278
2279 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2280
2281         * source.c (search_command_helper): Stop reverse search
2282         when line 1 has been searched.
2283
2284 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2285
2286         * record-full.c (record_full_base_target::close): Rewrite
2287         record_full_core_buf_list free logic.
2288
2289 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2290
2291         * break-catch-syscall.c (print_one_catch_syscall): xfree
2292         the last text.
2293
2294 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2295
2296         * top.c (print_gdb_version): Update Copyright year in version
2297         message.
2298
2299 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2300
2301         Update copyright year range in all GDB files.
2302
2303 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2304
2305         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2306
2307 For older changes see ChangeLog-2018.
2308 \f
2309 Local Variables:
2310 mode: change-log
2311 left-margin: 8
2312 fill-column: 74
2313 version-control: never
2314 coding: utf-8
2315 End:
2316