Use std::list for remote_notif_state::notif_queue
[external/binutils.git] / gdb / ChangeLog
1 2019-04-19  Tom Tromey  <tom@tromey.com>
2
3         * remote.c (remote_target): Use delete.
4         * remote-notif.h: Include <list>, not "common/queue.h".
5         (notif_client_p): Remove typedef.
6         (remote_notif_state): Add constructor, destructor, initializer.
7         <notif_queue>: Now a std::list.
8         (remote_notif_state_xfree): Don't declare.
9         * remote-notif.c (remote_notif_process, handle_notification)
10         (remote_notif_state_allocate): Update.
11         (~remote_notif_state): Rename from remote_notif_state_xfree.
12
13 2019-04-19  Tom Tromey  <tom@tromey.com>
14
15         * symfile.c (reread_symbols): Update.
16         * objfiles.c (objfile_register_static_link)
17         (objfile_lookup_static_link): Update
18         (~objfile) Don't delete static_links.
19         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
20
21 2019-04-19  Tom Tromey  <tom@tromey.com>
22
23         * type-stack.h (struct type_stack) <insert>: Constify string.
24         * type-stack.c (type_stack::insert): Constify string.
25         * gdbtypes.h (lookup_template_type): Update.
26         (address_space_name_to_int): Update.
27         * gdbtypes.c (address_space_name_to_int): Make space_identifier
28         const.
29         (lookup_template_type): Make name const.
30         * c-exp.y: Update rules.
31         (lex_one_token, classify_name, classify_inner_name)
32         (c_print_token): Update.
33         * p-exp.y: Update rules.
34         (yylex): Update.
35         * f-exp.y: Update rules.
36         (yylex): Update.
37         * d-exp.y: Update rules.
38         (lex_one_token, classify_name, classify_inner_name): Update.
39         * parse.c (write_dollar_variable, copy_name): Return std::string.
40         * parser-defs.h (copy_name): Change return type.
41         * m2-exp.y: Update rules.
42         (yylex): Update.
43         * go-exp.y (lex_one_token): Update.
44         Update rules.
45         (classify_unsafe_function, classify_packaged_name)
46         (classify_name, yylex): Update.
47
48 2019-04-19  Sergei Trofimovich <siarheit@google.com>
49
50         * configure.ac: add --enable-source-highlight switch.
51         * configure: Regenerate.
52         * top.c (print_gdb_version): plumb --enable-source-highlight
53         status to "show configuration".
54
55 2019-04-19  Tom Tromey  <tromey@adacore.com>
56
57         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
58         Check ADA_TYPE_P.
59         (empty_record, ada_template_to_fixed_record_type_1)
60         (template_to_static_fixed_type)
61         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
62         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
63         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
64         macros.
65
66 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
67
68         PR symtab/24423:
69         * source.c (print_source_lines_base): Advance "iter" when a
70         control character is seen.
71
72 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
73
74         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
75         close to the add_com "shell".
76
77 2019-04-18  Tom Tromey  <tromey@adacore.com>
78
79         * process-stratum-target.h (class process_stratum_target)
80         <stratum>: Add "final".
81
82 2019-04-17  Tom Tromey  <tromey@adacore.com>
83
84         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
85         against nullptr before use.
86
87 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
88
89         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
90
91 2019-04-17  Jim Wilson  <jimw@sifive.com>
92             Andrew Burgess  <andrew.burgess@embecosm.com>
93
94         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
95         code read might fail, assume 4-byte breakpoint in that case.
96
97 2019-04-15  Leszek Swirski  <leszeks@google.com>
98
99         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
100         rather than a hand-rolled POD check when checking for forced MEMORY
101         classification.
102
103 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
104
105         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
106         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
107         function.
108         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
109         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
110         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
111         declaration.
112
113 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
114
115         * aarch64-linux-nat.c
116         (aarch64_linux_nat_target::thread_architecture): Add override.
117         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
118         each VQ.
119
120 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
121
122         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
123
124 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
125
126         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
127         target types of size 96-bits, add some additional comments, and
128         check that the builtin type we found was the correct size.
129
130 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
131
132         * utils.c (prompt_for_continue): Don't restore the styling at the
133         end, as applied_style has the wrong value.  This fixes styling in
134         long lists of file names that are interrupted by the "Continue?"
135         prompt.
136
137 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
138
139         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
140         * c-lang.c (c_language_defn): Likewise.
141         (cplus_language_defn): Likewise.
142         (asm_language_defn): Likewise.
143         (minimal_language_defn): Likewise.
144         * d-lang.c (d_language_defn): Likewise.
145         * f-lang.c (f_language_defn): Likewise.
146         * go-lang.c (go_language_defn): Likewise.
147         * language.c (unknown_language_defn): Likewise.
148         (auto_language_defn): Likewise.
149         * language.h (struct language_defn): Remove la_magic field.
150         (LANG_MAGIC): Delete.
151         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
152         * objc-lang.c (objc_language_defn): Likewise.
153         * opencl-lang.c (opencl_language_defn): Likewise.
154         * p-lang.c (pascal_language_defn): Likewise.
155         * rust-lang.c (rust_language_defn): Likewise.
156
157 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
158
159         * riscv-tdep.c (riscv_type_align): New function.
160         (riscv_type_alignment): Delete.
161         (riscv_arg_location): Use 'type_align'.
162         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
163
164 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
165
166         * gdbtypes.c (type_align): A struct with no non-static fields also
167         has alignment of 1.
168
169 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
170
171         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
172         component to 0.
173         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
174         member.
175         (riscv_struct_info::analyse): New implementation using new
176         analyse_inner member function.
177         (riscv_struct_info::field_offset): New member function.
178         (riscv_struct_info::m_offsets): New member variable.
179         (riscv_struct_info::analyse_inner): New private member function,
180         takes the old implementation of riscv_struct_info::analyse but
181         extended to track field offsets.
182         (riscv_call_arg_struct): Update the struct folding special cases
183         to handle cases where empty C++ structs, which are non-zero
184         length, are found.
185         (riscv_arg_location): Initialise the length of each location, a
186         non-zero length now indicates the location is in use.
187         (riscv_push_dummy_call): Allow for the first location having a
188         non-zero offset when setting up arguments.
189         (riscv_return_value): Likewise, but for return values.
190
191 2019-04-11  Tom Tromey  <tromey@adacore.com>
192
193         * utils.c (internal_vproblem): Make "msg" const.
194
195 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
196
197         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
198         * trad-frame.c (trad_frame_reset_saved_regs): New function.
199         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
200         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
201
202 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
203
204         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
205         function.
206         (fill_gregset): Call amd64_linux_collect_native_gregset instead
207         of amd64_collect_native_gregset.
208         (amd64_linux_nat_target::store_registers): Likewise.
209
210 2019-04-10  Tom Tromey  <tom@tromey.com>
211
212         * symtab.c (lookup_global_symbol_from_objfile)
213         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
214         * objfiles.h (class separate_debug_iterator): New.
215         (class separate_debug_range): New.
216         (struct objfile) <separate_debug_objfiles>: New method.
217         (objfile_separate_debug_iterate): Don't declare.
218         * objfiles.c (separate_debug_iterator::operator++): Rename from
219         objfile_separate_debug_iterate.
220         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
221         iterator.
222         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
223         iterator.
224
225 2019-04-10  Tom Tromey  <tom@tromey.com>
226
227         * symfile.c (reread_symbols): Remove old comment.
228         * objfiles.c (free_all_objfiles): Fix a typo.
229
230 2019-04-10  Tom Tromey  <tom@tromey.com>
231
232         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
233         * minsyms.c (lookup_minimal_symbol): Use foreach.
234         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
235         (lookup_minimal_symbol_solib_trampoline): Likewise.
236         * symfile.c (reread_symbols): Use foreach.
237
238 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
239             Tom Tromey  <tromey@adacore.com>
240
241         PR rust/24414:
242         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
243         (rust_lex_int_test): Change "value" to be LONGEST.
244         (rust_lex_tests): Add test for long integer literal.
245
246 2019-04-09  Tom Tromey  <tromey@adacore.com>
247
248         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
249         to bool.
250         (extended_remote_target::attach): Update.
251         (remote_target::remote_notice_new_inferior): Update.
252         (remote_target::add_current_inferior_and_thread): Update.
253         * inferior.c (exit_inferior_1): Use "false".
254         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
255
256 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
257
258         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
259         the "start" command.
260
261 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
262
263         * python/py-inferior.c (infpy_thread_from_thread_handle):
264         Adjust comments to reflect renaming of thread_from_thread_handle
265         to thread_from_handle.  Adjust keywords.  Fix type error message.
266         (inferior_object_methods): Add thread_from_handle.  Retain
267         thread_from_thread_handle, but mark it as deprecated.
268
269 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
270
271         * gdbthread.h (find_thread_by_handle): Revise declaration.
272         * thread.c (find_thread_by_handle): Likewise.  Adjust
273         implementation too.
274         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
275         support for buffer objects as handles.
276
277 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
278
279         * python/py-infthread.c (thpy_thread_handle): New function.
280         (thread_object_methods): Register thpy_thread_handle.
281
282 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
283
284         * gdbthread.h (thread_to_thread_handle): Declare.
285         * thread.c (gdbtypes.h): Include.
286         (thread_to_thread_handle): New function.
287
288         * target.h (struct target_ops): Add thread_info_to_thread_handle.
289         (target_thread_info_to_thread_handle): Declare.
290         * target.c (target_thread_info_to_thread_handle): New function.
291         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
292         * target-delegates.c: Regenerate.
293
294         * linux-thread-db.c (class thread_db_target): Add method
295         thread_info_to_thread_handle.
296         (thread_db_target::thread_info_to_thread_handle): Define.
297         * remote.c (class remote_target): Add new method
298         thread_info_to_thread_handle.
299         (remote_target::thread_info_to_thread_handle): Define.
300
301 2019-04-08  Pedro Alves  <palves@redhat.com>
302
303         * common/common-exceptions.c (throw_exception): Don't create
304         named object to throw; throw directly.
305         (throw_it): Likewise.  Don't initialize gdb_exception::message
306         here, with new; pass FMT and AP to the ctor instead.
307         * common/common-exceptions.h: Include <string>.
308         (gdb_exception::gdb_exception(enum return_reason, enum errors,
309         const char *, va_list)): New ctor.  Use std::make_shared.
310         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
311         errors)): Delete.
312         (gdb_exception_error::gdb_exception_error(enum errors, const char
313         *, va_list)): New.
314         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
315         Add assertion.
316         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
317         errors)): Delete.
318         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
319         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
320         Add assertion.
321
322 2019-04-08  Tom Tromey  <tom@tromey.com>
323
324         * valops.c (value_rtti_indirect_type): Replace throw_exception
325         with throw.
326         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
327         with throw.
328         * thread.c (thr_try_catch_cmd): Replace throw_exception with
329         throw.
330         * target.c (target_translate_tls_address): Replace throw_exception
331         with throw.
332         * stack.c (frame_apply_command_count): Replace throw_exception
333         with throw.
334         * solib-spu.c (append_ocl_sos): Replace throw_exception with
335         throw.
336         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
337         with throw.
338         * rs6000-tdep.c (rs6000_frame_cache)
339         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
340         * remote.c: Replace throw_exception with throw.
341         * record-full.c (record_full_message, record_full_wait_1)
342         (record_full_restore): Replace throw_exception with throw.
343         * record-btrace.c:
344         (get_thread_current_frame_id, record_btrace_start_replaying)
345         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
346         (cmd_record_btrace_start): Replace throw_exception with throw.
347         * parse.c (parse_exp_in_context_1): Replace throw_exception with
348         throw.
349         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
350         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
351         * linespec.c:
352         (find_linespec_symbols): Replace throw_exception with throw.
353         * infrun.c (displaced_step_prepare, resume): Replace
354         throw_exception with throw.
355         * infcmd.c (post_create_inferior): Replace throw_exception with
356         throw.
357         * inf-loop.c (inferior_event_handler): Replace throw_exception
358         with throw.
359         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
360         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
361         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
362         (get_prev_frame_always, get_frame_pc_if_available)
363         (get_frame_address_in_block_if_available, get_frame_language):
364         Replace throw_exception with throw.
365         * frame-unwind.c (frame_unwind_try_unwinder): Replace
366         throw_exception with throw.
367         * eval.c (fetch_subexp_value, evaluate_var_value)
368         (evaluate_funcall, evaluate_subexp_standard): Replace
369         throw_exception with throw.
370         * dwarf2loc.c (call_site_find_chain)
371         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
372         Replace throw_exception with throw.
373         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
374         with throw.
375         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
376         throw.
377         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
378         * completer.c (complete_line_internal): Replace throw_exception
379         with throw.
380         * compile/compile-object-run.c (compile_object_run): Replace
381         throw_exception with throw.
382         * cli/cli-script.c (process_next_line): Replace throw_exception
383         with throw.
384         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
385         (btrace_enable, btrace_maint_update_pt_packets): Replace
386         throw_exception with throw.
387         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
388         throw_exception with throw.
389         * break-catch-throw.c (re_set_exception_catchpoint): Replace
390         throw_exception with throw.
391         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
392         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
393         * aarch64-tdep.c (aarch64_make_prologue_cache)
394         (aarch64_make_stub_cache): Replace throw_exception with throw.
395
396 2019-04-08  Tom Tromey  <tom@tromey.com>
397
398         * common/common-exceptions.c (throw_exception): Rename from
399         throw_exception_cxx.  Remove old copy.  Make argument const.
400         (throw_it): Create and throw exception objects directly.
401         * common/common-exceptions.h (throw_exception): Make argument
402         const.
403         (struct gdb_exception_error): Add constructor.
404         (struct gdb_exception_quit): Add constructor.
405
406 2019-04-08  Tom Tromey  <tom@tromey.com>
407
408         * common/common-exceptions.h (exception_rethrow): Don't declare.
409         (TRY_SJLJ): Update comment.
410         (TRY, CATCH, END_CATCH): Remove.
411         * common/common-exceptions.c (exception_rethrow): Remove.
412
413 2019-04-08  Tom Tromey  <tom@tromey.com>
414
415         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
416         Remove.
417         (gdb_exception_error): Rename from
418         gdb_exception_RETURN_MASK_ERROR.
419         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
420         (gdb_quit_bad_alloc): Update.
421         * aarch64-tdep.c: Update.
422         * ada-lang.c: Update.
423         * ada-typeprint.c: Update.
424         * ada-valprint.c: Update.
425         * amd64-tdep.c: Update.
426         * arch-utils.c: Update.
427         * break-catch-throw.c: Update.
428         * breakpoint.c: Update.
429         * btrace.c: Update.
430         * c-varobj.c: Update.
431         * cli/cli-cmds.c: Update.
432         * cli/cli-interp.c: Update.
433         * cli/cli-script.c: Update.
434         * common/common-exceptions.c: Update.
435         * common/new-op.c: Update.
436         * common/selftest.c: Update.
437         * compile/compile-c-symbols.c: Update.
438         * compile/compile-cplus-symbols.c: Update.
439         * compile/compile-object-load.c: Update.
440         * compile/compile-object-run.c: Update.
441         * completer.c: Update.
442         * corelow.c: Update.
443         * cp-abi.c: Update.
444         * cp-support.c: Update.
445         * cp-valprint.c: Update.
446         * darwin-nat.c: Update.
447         * disasm-selftests.c: Update.
448         * dtrace-probe.c: Update.
449         * dwarf-index-cache.c: Update.
450         * dwarf-index-write.c: Update.
451         * dwarf2-frame-tailcall.c: Update.
452         * dwarf2-frame.c: Update.
453         * dwarf2loc.c: Update.
454         * dwarf2read.c: Update.
455         * eval.c: Update.
456         * event-loop.c: Update.
457         * event-top.c: Update.
458         * exec.c: Update.
459         * f-valprint.c: Update.
460         * fbsd-tdep.c: Update.
461         * frame-unwind.c: Update.
462         * frame.c: Update.
463         * gdbtypes.c: Update.
464         * gnu-v3-abi.c: Update.
465         * guile/guile-internal.h: Update.
466         * guile/scm-block.c: Update.
467         * guile/scm-breakpoint.c: Update.
468         * guile/scm-cmd.c: Update.
469         * guile/scm-disasm.c: Update.
470         * guile/scm-frame.c: Update.
471         * guile/scm-lazy-string.c: Update.
472         * guile/scm-math.c: Update.
473         * guile/scm-param.c: Update.
474         * guile/scm-ports.c: Update.
475         * guile/scm-pretty-print.c: Update.
476         * guile/scm-symbol.c: Update.
477         * guile/scm-symtab.c: Update.
478         * guile/scm-type.c: Update.
479         * guile/scm-value.c: Update.
480         * i386-linux-tdep.c: Update.
481         * i386-tdep.c: Update.
482         * inf-loop.c: Update.
483         * infcall.c: Update.
484         * infcmd.c: Update.
485         * infrun.c: Update.
486         * jit.c: Update.
487         * language.c: Update.
488         * linespec.c: Update.
489         * linux-fork.c: Update.
490         * linux-nat.c: Update.
491         * linux-tdep.c: Update.
492         * linux-thread-db.c: Update.
493         * main.c: Update.
494         * mi/mi-cmd-break.c: Update.
495         * mi/mi-cmd-stack.c: Update.
496         * mi/mi-interp.c: Update.
497         * mi/mi-main.c: Update.
498         * objc-lang.c: Update.
499         * p-valprint.c: Update.
500         * parse.c: Update.
501         * ppc-linux-tdep.c: Update.
502         * printcmd.c: Update.
503         * python/py-arch.c: Update.
504         * python/py-breakpoint.c: Update.
505         * python/py-cmd.c: Update.
506         * python/py-finishbreakpoint.c: Update.
507         * python/py-frame.c: Update.
508         * python/py-framefilter.c: Update.
509         * python/py-gdb-readline.c: Update.
510         * python/py-inferior.c: Update.
511         * python/py-infthread.c: Update.
512         * python/py-lazy-string.c: Update.
513         * python/py-linetable.c: Update.
514         * python/py-objfile.c: Update.
515         * python/py-param.c: Update.
516         * python/py-prettyprint.c: Update.
517         * python/py-progspace.c: Update.
518         * python/py-record-btrace.c: Update.
519         * python/py-record.c: Update.
520         * python/py-symbol.c: Update.
521         * python/py-type.c: Update.
522         * python/py-unwind.c: Update.
523         * python/py-utils.c: Update.
524         * python/py-value.c: Update.
525         * python/python.c: Update.
526         * record-btrace.c: Update.
527         * record-full.c: Update.
528         * remote-fileio.c: Update.
529         * remote.c: Update.
530         * riscv-tdep.c: Update.
531         * rs6000-aix-tdep.c: Update.
532         * rs6000-tdep.c: Update.
533         * rust-exp.y: Update.
534         * rust-lang.c: Update.
535         * s390-tdep.c: Update.
536         * selftest-arch.c: Update.
537         * solib-dsbt.c: Update.
538         * solib-frv.c: Update.
539         * solib-spu.c: Update.
540         * solib-svr4.c: Update.
541         * solib.c: Update.
542         * sparc64-linux-tdep.c: Update.
543         * stack.c: Update.
544         * symfile-mem.c: Update.
545         * symmisc.c: Update.
546         * target.c: Update.
547         * thread.c: Update.
548         * top.c: Update.
549         * tracefile-tfile.c: Update.
550         * tui/tui.c: Update.
551         * typeprint.c: Update.
552         * unittests/cli-utils-selftests.c: Update.
553         * unittests/parse-connection-spec-selftests.c: Update.
554         * valops.c: Update.
555         * valprint.c: Update.
556         * value.c: Update.
557         * varobj.c: Update.
558         * windows-nat.c: Update.
559         * x86-linux-nat.c: Update.
560         * xml-support.c: Update.
561
562 2019-04-08  Tom Tromey  <tom@tromey.com>
563
564         * xml-support.c: Use C++ exception handling.
565         * x86-linux-nat.c: Use C++ exception handling.
566         * windows-nat.c: Use C++ exception handling.
567         * varobj.c: Use C++ exception handling.
568         * value.c: Use C++ exception handling.
569         * valprint.c: Use C++ exception handling.
570         * valops.c: Use C++ exception handling.
571         * unittests/parse-connection-spec-selftests.c: Use C++ exception
572         handling.
573         * unittests/cli-utils-selftests.c: Use C++ exception handling.
574         * typeprint.c: Use C++ exception handling.
575         * tui/tui.c: Use C++ exception handling.
576         * tracefile-tfile.c: Use C++ exception handling.
577         * top.c: Use C++ exception handling.
578         * thread.c: Use C++ exception handling.
579         * target.c: Use C++ exception handling.
580         * symmisc.c: Use C++ exception handling.
581         * symfile-mem.c: Use C++ exception handling.
582         * stack.c: Use C++ exception handling.
583         * sparc64-linux-tdep.c: Use C++ exception handling.
584         * solib.c: Use C++ exception handling.
585         * solib-svr4.c: Use C++ exception handling.
586         * solib-spu.c: Use C++ exception handling.
587         * solib-frv.c: Use C++ exception handling.
588         * solib-dsbt.c: Use C++ exception handling.
589         * selftest-arch.c: Use C++ exception handling.
590         * s390-tdep.c: Use C++ exception handling.
591         * rust-lang.c: Use C++ exception handling.
592         * rust-exp.y: Use C++ exception handling.
593         * rs6000-tdep.c: Use C++ exception handling.
594         * rs6000-aix-tdep.c: Use C++ exception handling.
595         * riscv-tdep.c: Use C++ exception handling.
596         * remote.c: Use C++ exception handling.
597         * remote-fileio.c: Use C++ exception handling.
598         * record-full.c: Use C++ exception handling.
599         * record-btrace.c: Use C++ exception handling.
600         * python/python.c: Use C++ exception handling.
601         * python/py-value.c: Use C++ exception handling.
602         * python/py-utils.c: Use C++ exception handling.
603         * python/py-unwind.c: Use C++ exception handling.
604         * python/py-type.c: Use C++ exception handling.
605         * python/py-symbol.c: Use C++ exception handling.
606         * python/py-record.c: Use C++ exception handling.
607         * python/py-record-btrace.c: Use C++ exception handling.
608         * python/py-progspace.c: Use C++ exception handling.
609         * python/py-prettyprint.c: Use C++ exception handling.
610         * python/py-param.c: Use C++ exception handling.
611         * python/py-objfile.c: Use C++ exception handling.
612         * python/py-linetable.c: Use C++ exception handling.
613         * python/py-lazy-string.c: Use C++ exception handling.
614         * python/py-infthread.c: Use C++ exception handling.
615         * python/py-inferior.c: Use C++ exception handling.
616         * python/py-gdb-readline.c: Use C++ exception handling.
617         * python/py-framefilter.c: Use C++ exception handling.
618         * python/py-frame.c: Use C++ exception handling.
619         * python/py-finishbreakpoint.c: Use C++ exception handling.
620         * python/py-cmd.c: Use C++ exception handling.
621         * python/py-breakpoint.c: Use C++ exception handling.
622         * python/py-arch.c: Use C++ exception handling.
623         * printcmd.c: Use C++ exception handling.
624         * ppc-linux-tdep.c: Use C++ exception handling.
625         * parse.c: Use C++ exception handling.
626         * p-valprint.c: Use C++ exception handling.
627         * objc-lang.c: Use C++ exception handling.
628         * mi/mi-main.c: Use C++ exception handling.
629         * mi/mi-interp.c: Use C++ exception handling.
630         * mi/mi-cmd-stack.c: Use C++ exception handling.
631         * mi/mi-cmd-break.c: Use C++ exception handling.
632         * main.c: Use C++ exception handling.
633         * linux-thread-db.c: Use C++ exception handling.
634         * linux-tdep.c: Use C++ exception handling.
635         * linux-nat.c: Use C++ exception handling.
636         * linux-fork.c: Use C++ exception handling.
637         * linespec.c: Use C++ exception handling.
638         * language.c: Use C++ exception handling.
639         * jit.c: Use C++ exception handling.
640         * infrun.c: Use C++ exception handling.
641         * infcmd.c: Use C++ exception handling.
642         * infcall.c: Use C++ exception handling.
643         * inf-loop.c: Use C++ exception handling.
644         * i386-tdep.c: Use C++ exception handling.
645         * i386-linux-tdep.c: Use C++ exception handling.
646         * guile/scm-value.c: Use C++ exception handling.
647         * guile/scm-type.c: Use C++ exception handling.
648         * guile/scm-symtab.c: Use C++ exception handling.
649         * guile/scm-symbol.c: Use C++ exception handling.
650         * guile/scm-pretty-print.c: Use C++ exception handling.
651         * guile/scm-ports.c: Use C++ exception handling.
652         * guile/scm-param.c: Use C++ exception handling.
653         * guile/scm-math.c: Use C++ exception handling.
654         * guile/scm-lazy-string.c: Use C++ exception handling.
655         * guile/scm-frame.c: Use C++ exception handling.
656         * guile/scm-disasm.c: Use C++ exception handling.
657         * guile/scm-cmd.c: Use C++ exception handling.
658         * guile/scm-breakpoint.c: Use C++ exception handling.
659         * guile/scm-block.c: Use C++ exception handling.
660         * guile/guile-internal.h: Use C++ exception handling.
661         * gnu-v3-abi.c: Use C++ exception handling.
662         * gdbtypes.c: Use C++ exception handling.
663         * frame.c: Use C++ exception handling.
664         * frame-unwind.c: Use C++ exception handling.
665         * fbsd-tdep.c: Use C++ exception handling.
666         * f-valprint.c: Use C++ exception handling.
667         * exec.c: Use C++ exception handling.
668         * event-top.c: Use C++ exception handling.
669         * event-loop.c: Use C++ exception handling.
670         * eval.c: Use C++ exception handling.
671         * dwarf2read.c: Use C++ exception handling.
672         * dwarf2loc.c: Use C++ exception handling.
673         * dwarf2-frame.c: Use C++ exception handling.
674         * dwarf2-frame-tailcall.c: Use C++ exception handling.
675         * dwarf-index-write.c: Use C++ exception handling.
676         * dwarf-index-cache.c: Use C++ exception handling.
677         * dtrace-probe.c: Use C++ exception handling.
678         * disasm-selftests.c: Use C++ exception handling.
679         * darwin-nat.c: Use C++ exception handling.
680         * cp-valprint.c: Use C++ exception handling.
681         * cp-support.c: Use C++ exception handling.
682         * cp-abi.c: Use C++ exception handling.
683         * corelow.c: Use C++ exception handling.
684         * completer.c: Use C++ exception handling.
685         * compile/compile-object-run.c: Use C++ exception handling.
686         * compile/compile-object-load.c: Use C++ exception handling.
687         * compile/compile-cplus-symbols.c: Use C++ exception handling.
688         * compile/compile-c-symbols.c: Use C++ exception handling.
689         * common/selftest.c: Use C++ exception handling.
690         * common/new-op.c: Use C++ exception handling.
691         * cli/cli-script.c: Use C++ exception handling.
692         * cli/cli-interp.c: Use C++ exception handling.
693         * cli/cli-cmds.c: Use C++ exception handling.
694         * c-varobj.c: Use C++ exception handling.
695         * btrace.c: Use C++ exception handling.
696         * breakpoint.c: Use C++ exception handling.
697         * break-catch-throw.c: Use C++ exception handling.
698         * arch-utils.c: Use C++ exception handling.
699         * amd64-tdep.c: Use C++ exception handling.
700         * ada-valprint.c: Use C++ exception handling.
701         * ada-typeprint.c: Use C++ exception handling.
702         * ada-lang.c: Use C++ exception handling.
703         * aarch64-tdep.c: Use C++ exception handling.
704
705 2019-04-08  Tom Tromey  <tom@tromey.com>
706
707         * xml-support.c (gdb_xml_parser::parse): Update.
708         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
709         * value.c (show_convenience): Update.
710         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
711         (test_parse_flags_qcs): Update.
712         * thread.c (thr_try_catch_cmd): Update.
713         * target.c (target_translate_tls_address): Update.
714         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
715         (info_frame_command_core, frame_apply_command_count): Update.
716         * rust-exp.y (rust_lex_exception_test): Update.
717         * riscv-tdep.c (riscv_print_one_register_info): Update.
718         * remote.c (remote_target::enable_btrace): Update.
719         * record-btrace.c (record_btrace_enable_warn): Update.
720         * python/py-utils.c (gdbpy_convert_exception): Update.
721         * printcmd.c (do_one_display, print_variable_and_value): Update.
722         * mi/mi-main.c (mi_print_exception): Update.
723         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
724         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
725         * linux-nat.c (linux_nat_target::attach): Update.
726         * linux-fork.c (class scoped_switch_fork_info): Update.
727         * infrun.c (displaced_step_prepare): Update.
728         * infcall.c (call_function_by_hand_dummy): Update.
729         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
730         * gnu-v3-abi.c (print_one_vtable): Update.
731         * frame.c (get_prev_frame_always): Update.
732         * f-valprint.c (info_common_command_for_block): Update.
733         * exec.c (try_open_exec_file): Update.
734         * exceptions.c (print_exception, exception_print)
735         (exception_fprintf, exception_print_same): Update.
736         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
737         * dwarf-index-cache.c (index_cache::store)
738         (index_cache::lookup_gdb_index): Update.
739         * darwin-nat.c (maybe_cache_shell): Update.
740         * cp-valprint.c (cp_print_value_fields): Update.
741         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
742         (gcc_cplus_symbol_address): Update.
743         * compile/compile-c-symbols.c (gcc_convert_symbol)
744         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
745         * common/selftest.c: Update.
746         * common/common-exceptions.h (struct gdb_exception) <message>: Now
747         a std::string.
748         (exception_try_scope_entry, exception_try_scope_exit): Don't
749         declare.
750         (struct exception_try_scope): Remove.
751         (TRY): Don't use exception_try_scope.
752         (struct gdb_exception): Add constructor, operator=.
753         <what>: New method.
754         (struct gdb_exception_RETURN_MASK_ALL)
755         (struct gdb_exception_RETURN_MASK_ERROR)
756         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
757         (struct gdb_quit_bad_alloc): Update.
758         * common/common-exceptions.c (exception_none): Change
759         initializer.
760         (struct catcher) <state, exception>: Initialize inline.
761         <prev>: Remove member.
762         (current_catcher): Remove.
763         (catchers): New global.
764         (exceptions_state_mc_init): Simplify.
765         (catcher_pop): Remove.
766         (exceptions_state_mc, exceptions_state_mc_catch): Update.
767         (try_scope_depth, exception_try_scope_entry)
768         (exception_try_scope_exit): Remove.
769         (throw_exception_sjlj): Update.
770         (exception_messages, exception_messages_size): Remove.
771         (throw_it): Simplify.
772         (gdb_exception_sliced_copy): Remove.
773         (throw_exception_cxx): Update.
774         * cli/cli-script.c (script_from_file): Update.
775         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
776         Update.
777         * ada-valprint.c (ada_val_print): Update.
778         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
779         (create_excep_cond_exprs): Update.
780
781 2019-04-08  Tom Tromey  <tom@tromey.com>
782
783         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
784         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
785         (TRY, CATCH, END_CATCH): Remove some definitions.
786         * common/common-exceptions.c: Don't use GDB_XCPT.
787         (catcher_list_size): Remove.
788         (throw_exception, throw_it): Simplify.
789
790 2019-04-05  Tom Tromey  <tom@tromey.com>
791
792         Revert the header-sorting patch.
793         * ft32-tdep.c: Revert.
794         * frv-tdep.c: Revert.
795         * frv-linux-tdep.c: Revert.
796         * frame.c: Revert.
797         * frame-unwind.c: Revert.
798         * frame-base.c: Revert.
799         * fork-child.c: Revert.
800         * findvar.c: Revert.
801         * findcmd.c: Revert.
802         * filesystem.c: Revert.
803         * filename-seen-cache.h: Revert.
804         * filename-seen-cache.c: Revert.
805         * fbsd-tdep.c: Revert.
806         * fbsd-nat.h: Revert.
807         * fbsd-nat.c: Revert.
808         * f-valprint.c: Revert.
809         * f-typeprint.c: Revert.
810         * f-lang.c: Revert.
811         * extension.h: Revert.
812         * extension.c: Revert.
813         * extension-priv.h: Revert.
814         * expprint.c: Revert.
815         * exec.h: Revert.
816         * exec.c: Revert.
817         * exceptions.c: Revert.
818         * event-top.c: Revert.
819         * event-loop.c: Revert.
820         * eval.c: Revert.
821         * elfread.c: Revert.
822         * dwarf2read.h: Revert.
823         * dwarf2read.c: Revert.
824         * dwarf2loc.c: Revert.
825         * dwarf2expr.h: Revert.
826         * dwarf2expr.c: Revert.
827         * dwarf2-frame.c: Revert.
828         * dwarf2-frame-tailcall.c: Revert.
829         * dwarf-index-write.h: Revert.
830         * dwarf-index-write.c: Revert.
831         * dwarf-index-common.c: Revert.
832         * dwarf-index-cache.h: Revert.
833         * dwarf-index-cache.c: Revert.
834         * dummy-frame.c: Revert.
835         * dtrace-probe.c: Revert.
836         * disasm.h: Revert.
837         * disasm.c: Revert.
838         * disasm-selftests.c: Revert.
839         * dictionary.c: Revert.
840         * dicos-tdep.c: Revert.
841         * demangle.c: Revert.
842         * dcache.h: Revert.
843         * dcache.c: Revert.
844         * darwin-nat.h: Revert.
845         * darwin-nat.c: Revert.
846         * darwin-nat-info.c: Revert.
847         * d-valprint.c: Revert.
848         * d-namespace.c: Revert.
849         * d-lang.c: Revert.
850         * ctf.c: Revert.
851         * csky-tdep.c: Revert.
852         * csky-linux-tdep.c: Revert.
853         * cris-tdep.c: Revert.
854         * cris-linux-tdep.c: Revert.
855         * cp-valprint.c: Revert.
856         * cp-support.c: Revert.
857         * cp-namespace.c: Revert.
858         * cp-abi.c: Revert.
859         * corelow.c: Revert.
860         * corefile.c: Revert.
861         * continuations.c: Revert.
862         * completer.h: Revert.
863         * completer.c: Revert.
864         * complaints.c: Revert.
865         * coffread.c: Revert.
866         * coff-pe-read.c: Revert.
867         * cli-out.h: Revert.
868         * cli-out.c: Revert.
869         * charset.c: Revert.
870         * c-varobj.c: Revert.
871         * c-valprint.c: Revert.
872         * c-typeprint.c: Revert.
873         * c-lang.c: Revert.
874         * buildsym.c: Revert.
875         * buildsym-legacy.c: Revert.
876         * build-id.h: Revert.
877         * build-id.c: Revert.
878         * btrace.c: Revert.
879         * bsd-uthread.c: Revert.
880         * breakpoint.h: Revert.
881         * breakpoint.c: Revert.
882         * break-catch-throw.c: Revert.
883         * break-catch-syscall.c: Revert.
884         * break-catch-sig.c: Revert.
885         * blockframe.c: Revert.
886         * block.c: Revert.
887         * bfin-tdep.c: Revert.
888         * bfin-linux-tdep.c: Revert.
889         * bfd-target.c: Revert.
890         * bcache.c: Revert.
891         * ax-general.c: Revert.
892         * ax-gdb.h: Revert.
893         * ax-gdb.c: Revert.
894         * avr-tdep.c: Revert.
895         * auxv.c: Revert.
896         * auto-load.c: Revert.
897         * arm-wince-tdep.c: Revert.
898         * arm-tdep.c: Revert.
899         * arm-symbian-tdep.c: Revert.
900         * arm-pikeos-tdep.c: Revert.
901         * arm-obsd-tdep.c: Revert.
902         * arm-nbsd-tdep.c: Revert.
903         * arm-nbsd-nat.c: Revert.
904         * arm-linux-tdep.c: Revert.
905         * arm-linux-nat.c: Revert.
906         * arm-fbsd-tdep.c: Revert.
907         * arm-fbsd-nat.c: Revert.
908         * arm-bsd-tdep.c: Revert.
909         * arch-utils.c: Revert.
910         * arc-tdep.c: Revert.
911         * arc-newlib-tdep.c: Revert.
912         * annotate.h: Revert.
913         * annotate.c: Revert.
914         * amd64-windows-tdep.c: Revert.
915         * amd64-windows-nat.c: Revert.
916         * amd64-tdep.c: Revert.
917         * amd64-sol2-tdep.c: Revert.
918         * amd64-obsd-tdep.c: Revert.
919         * amd64-obsd-nat.c: Revert.
920         * amd64-nbsd-tdep.c: Revert.
921         * amd64-nbsd-nat.c: Revert.
922         * amd64-nat.c: Revert.
923         * amd64-linux-tdep.c: Revert.
924         * amd64-linux-nat.c: Revert.
925         * amd64-fbsd-tdep.c: Revert.
926         * amd64-fbsd-nat.c: Revert.
927         * amd64-dicos-tdep.c: Revert.
928         * amd64-darwin-tdep.c: Revert.
929         * amd64-bsd-nat.c: Revert.
930         * alpha-tdep.c: Revert.
931         * alpha-obsd-tdep.c: Revert.
932         * alpha-nbsd-tdep.c: Revert.
933         * alpha-mdebug-tdep.c: Revert.
934         * alpha-linux-tdep.c: Revert.
935         * alpha-linux-nat.c: Revert.
936         * alpha-bsd-tdep.c: Revert.
937         * alpha-bsd-nat.c: Revert.
938         * aix-thread.c: Revert.
939         * agent.c: Revert.
940         * addrmap.c: Revert.
941         * ada-varobj.c: Revert.
942         * ada-valprint.c: Revert.
943         * ada-typeprint.c: Revert.
944         * ada-tasks.c: Revert.
945         * ada-lang.c: Revert.
946         * aarch64-tdep.c: Revert.
947         * aarch64-ravenscar-thread.c: Revert.
948         * aarch64-newlib-tdep.c: Revert.
949         * aarch64-linux-tdep.c: Revert.
950         * aarch64-linux-nat.c: Revert.
951         * aarch64-fbsd-tdep.c: Revert.
952         * aarch64-fbsd-nat.c: Revert.
953         * aarch32-linux-nat.c: Revert.
954
955 2019-04-05  Tom Tromey  <tom@tromey.com>
956
957         * ft32-tdep.c: Sort headers.
958         * frv-tdep.c: Sort headers.
959         * frv-linux-tdep.c: Sort headers.
960         * frame.c: Sort headers.
961         * frame-unwind.c: Sort headers.
962         * frame-base.c: Sort headers.
963         * fork-child.c: Sort headers.
964         * findvar.c: Sort headers.
965         * findcmd.c: Sort headers.
966         * filesystem.c: Sort headers.
967         * filename-seen-cache.h: Sort headers.
968         * filename-seen-cache.c: Sort headers.
969         * fbsd-tdep.c: Sort headers.
970         * fbsd-nat.h: Sort headers.
971         * fbsd-nat.c: Sort headers.
972         * f-valprint.c: Sort headers.
973         * f-typeprint.c: Sort headers.
974         * f-lang.c: Sort headers.
975         * extension.h: Sort headers.
976         * extension.c: Sort headers.
977         * extension-priv.h: Sort headers.
978         * expprint.c: Sort headers.
979         * exec.h: Sort headers.
980         * exec.c: Sort headers.
981         * exceptions.c: Sort headers.
982         * event-top.c: Sort headers.
983         * event-loop.c: Sort headers.
984         * eval.c: Sort headers.
985         * elfread.c: Sort headers.
986         * dwarf2read.h: Sort headers.
987         * dwarf2read.c: Sort headers.
988         * dwarf2loc.c: Sort headers.
989         * dwarf2expr.h: Sort headers.
990         * dwarf2expr.c: Sort headers.
991         * dwarf2-frame.c: Sort headers.
992         * dwarf2-frame-tailcall.c: Sort headers.
993         * dwarf-index-write.h: Sort headers.
994         * dwarf-index-write.c: Sort headers.
995         * dwarf-index-common.c: Sort headers.
996         * dwarf-index-cache.h: Sort headers.
997         * dwarf-index-cache.c: Sort headers.
998         * dummy-frame.c: Sort headers.
999         * dtrace-probe.c: Sort headers.
1000         * disasm.h: Sort headers.
1001         * disasm.c: Sort headers.
1002         * disasm-selftests.c: Sort headers.
1003         * dictionary.c: Sort headers.
1004         * dicos-tdep.c: Sort headers.
1005         * demangle.c: Sort headers.
1006         * dcache.h: Sort headers.
1007         * dcache.c: Sort headers.
1008         * darwin-nat.h: Sort headers.
1009         * darwin-nat.c: Sort headers.
1010         * darwin-nat-info.c: Sort headers.
1011         * d-valprint.c: Sort headers.
1012         * d-namespace.c: Sort headers.
1013         * d-lang.c: Sort headers.
1014         * ctf.c: Sort headers.
1015         * csky-tdep.c: Sort headers.
1016         * csky-linux-tdep.c: Sort headers.
1017         * cris-tdep.c: Sort headers.
1018         * cris-linux-tdep.c: Sort headers.
1019         * cp-valprint.c: Sort headers.
1020         * cp-support.c: Sort headers.
1021         * cp-namespace.c: Sort headers.
1022         * cp-abi.c: Sort headers.
1023         * corelow.c: Sort headers.
1024         * corefile.c: Sort headers.
1025         * continuations.c: Sort headers.
1026         * completer.h: Sort headers.
1027         * completer.c: Sort headers.
1028         * complaints.c: Sort headers.
1029         * coffread.c: Sort headers.
1030         * coff-pe-read.c: Sort headers.
1031         * cli-out.h: Sort headers.
1032         * cli-out.c: Sort headers.
1033         * charset.c: Sort headers.
1034         * c-varobj.c: Sort headers.
1035         * c-valprint.c: Sort headers.
1036         * c-typeprint.c: Sort headers.
1037         * c-lang.c: Sort headers.
1038         * buildsym.c: Sort headers.
1039         * buildsym-legacy.c: Sort headers.
1040         * build-id.h: Sort headers.
1041         * build-id.c: Sort headers.
1042         * btrace.c: Sort headers.
1043         * bsd-uthread.c: Sort headers.
1044         * breakpoint.h: Sort headers.
1045         * breakpoint.c: Sort headers.
1046         * break-catch-throw.c: Sort headers.
1047         * break-catch-syscall.c: Sort headers.
1048         * break-catch-sig.c: Sort headers.
1049         * blockframe.c: Sort headers.
1050         * block.c: Sort headers.
1051         * bfin-tdep.c: Sort headers.
1052         * bfin-linux-tdep.c: Sort headers.
1053         * bfd-target.c: Sort headers.
1054         * bcache.c: Sort headers.
1055         * ax-general.c: Sort headers.
1056         * ax-gdb.h: Sort headers.
1057         * ax-gdb.c: Sort headers.
1058         * avr-tdep.c: Sort headers.
1059         * auxv.c: Sort headers.
1060         * auto-load.c: Sort headers.
1061         * arm-wince-tdep.c: Sort headers.
1062         * arm-tdep.c: Sort headers.
1063         * arm-symbian-tdep.c: Sort headers.
1064         * arm-pikeos-tdep.c: Sort headers.
1065         * arm-obsd-tdep.c: Sort headers.
1066         * arm-nbsd-tdep.c: Sort headers.
1067         * arm-nbsd-nat.c: Sort headers.
1068         * arm-linux-tdep.c: Sort headers.
1069         * arm-linux-nat.c: Sort headers.
1070         * arm-fbsd-tdep.c: Sort headers.
1071         * arm-fbsd-nat.c: Sort headers.
1072         * arm-bsd-tdep.c: Sort headers.
1073         * arch-utils.c: Sort headers.
1074         * arc-tdep.c: Sort headers.
1075         * arc-newlib-tdep.c: Sort headers.
1076         * annotate.h: Sort headers.
1077         * annotate.c: Sort headers.
1078         * amd64-windows-tdep.c: Sort headers.
1079         * amd64-windows-nat.c: Sort headers.
1080         * amd64-tdep.c: Sort headers.
1081         * amd64-sol2-tdep.c: Sort headers.
1082         * amd64-obsd-tdep.c: Sort headers.
1083         * amd64-obsd-nat.c: Sort headers.
1084         * amd64-nbsd-tdep.c: Sort headers.
1085         * amd64-nbsd-nat.c: Sort headers.
1086         * amd64-nat.c: Sort headers.
1087         * amd64-linux-tdep.c: Sort headers.
1088         * amd64-linux-nat.c: Sort headers.
1089         * amd64-fbsd-tdep.c: Sort headers.
1090         * amd64-fbsd-nat.c: Sort headers.
1091         * amd64-dicos-tdep.c: Sort headers.
1092         * amd64-darwin-tdep.c: Sort headers.
1093         * amd64-bsd-nat.c: Sort headers.
1094         * alpha-tdep.c: Sort headers.
1095         * alpha-obsd-tdep.c: Sort headers.
1096         * alpha-nbsd-tdep.c: Sort headers.
1097         * alpha-mdebug-tdep.c: Sort headers.
1098         * alpha-linux-tdep.c: Sort headers.
1099         * alpha-linux-nat.c: Sort headers.
1100         * alpha-bsd-tdep.c: Sort headers.
1101         * alpha-bsd-nat.c: Sort headers.
1102         * aix-thread.c: Sort headers.
1103         * agent.c: Sort headers.
1104         * addrmap.c: Sort headers.
1105         * ada-varobj.c: Sort headers.
1106         * ada-valprint.c: Sort headers.
1107         * ada-typeprint.c: Sort headers.
1108         * ada-tasks.c: Sort headers.
1109         * ada-lang.c: Sort headers.
1110         * aarch64-tdep.c: Sort headers.
1111         * aarch64-ravenscar-thread.c: Sort headers.
1112         * aarch64-newlib-tdep.c: Sort headers.
1113         * aarch64-linux-tdep.c: Sort headers.
1114         * aarch64-linux-nat.c: Sort headers.
1115         * aarch64-fbsd-tdep.c: Sort headers.
1116         * aarch64-fbsd-nat.c: Sort headers.
1117         * aarch32-linux-nat.c: Sort headers.
1118
1119 2019-04-04  Tom Tromey  <tom@tromey.com>
1120
1121         * varobj.c (varobj_create): Update.
1122         * rust-exp.y (struct rust_parser) <update_innermost_block,
1123         lookup_symbol>: New methods.
1124         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
1125         Rename.
1126         (rust_parser::rust_lookup_type)
1127         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1128         * printcmd.c (display_command, do_one_display): Update.
1129         * parser-defs.h (struct parser_state) <parser_state>: Add
1130         "tracker" parameter.
1131         (block_tracker): New member.
1132         (class innermost_block_tracker) <innermost_block_tracker>: Add
1133         "types" parameter.
1134         <reset>: Remove method.
1135         (innermost_block): Don't declare.
1136         (null_post_parser): Update.
1137         * parse.c (innermost_block): Remove global.
1138         (write_dollar_variable): Update.
1139         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
1140         Remove "tracker_types" parameter.
1141         (parse_expression): Add "tracker" parameter.
1142         (parse_expression_for_completion): Update.
1143         (null_post_parser): Add "tracker" parameter.
1144         * p-exp.y: Update rules.
1145         * m2-exp.y: Update rules.
1146         * language.h (struct language_defn) <la_post_parser>: Add
1147         "tracker" parameter.
1148         * go-exp.y: Update rules.
1149         * f-exp.y: Update rules.
1150         * expression.h (parse_expression, parse_exp_1): Add "tracker"
1151         parameter.
1152         * d-exp.y: Update rules.
1153         * c-exp.y: Update rules.
1154         * breakpoint.c (set_breakpoint_condition): Create an
1155         innermost_block_tracker.
1156         (watch_command_1): Likewise.
1157         * ada-lang.c (resolve): Add "tracker" parameter.
1158         (resolve_subexp): Likewise.
1159         * ada-exp.y (write_var_from_sym): Update.
1160
1161 2019-04-04  Tom Tromey  <tom@tromey.com>
1162
1163         * type-stack.h: New file.
1164         * type-stack.c: New file.
1165         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
1166         type-stack.h.
1167         (insert_into_type_stack, insert_type, push_type, push_type_int)
1168         (insert_type_address_space, pop_type, pop_type_int)
1169         (pop_typelist, pop_type_stack, append_type_stack)
1170         (push_type_stack, get_type_stack, push_typelist)
1171         (follow_type_instance_flags, follow_types): Don't declare.
1172         * parse.c (type_stack): Remove global.
1173         (parse_exp_in_context): Update.
1174         (insert_into_type_stack, insert_type, push_type, push_type_int)
1175         (insert_type_address_space, pop_type, pop_type_int)
1176         (pop_typelist, pop_type_stack, append_type_stack)
1177         (push_type_stack, get_type_stack, push_typelist)
1178         (follow_type_instance_flags, follow_types): Remove (moved to
1179         type-stack.c).
1180         * f-exp.y (type_stack): New global.
1181         Update rules.
1182         (push_kind_type, f_parse): Update.
1183         * d-exp.y (type_stack): New global.
1184         Update rules.
1185         (d_parse): Update.
1186         * c-exp.y (struct c_parse_state) <type_stack>: New member.
1187         Update rules.
1188         * Makefile.in (COMMON_SFILES): Add type-stack.c.
1189         (HFILES_NO_SRCDIR): Add type-stack.h.
1190
1191 2019-04-04  Tom Tromey  <tom@tromey.com>
1192
1193         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
1194         (rust_parser::convert_ast_to_expression, rust_parse)
1195         (rust_lex_test_completion, rust_lex_tests): Update.
1196         * parser-defs.h (struct expr_completion_state): New.
1197         (struct parser_state) <parser_state>: Add completion parameter.
1198         <mark_struct_expression, mark_completion_tag>: New methods.
1199         <parse_completion, m_completion_state>: New members.
1200         (prefixify_expression, null_post_parser): Update.
1201         (mark_struct_expression, mark_completion_tag): Don't declare.
1202         * parse.c (parse_completion, expout_last_struct)
1203         (expout_tag_completion_type, expout_completion_name): Remove
1204         globals.
1205         (parser_state::mark_struct_expression)
1206         (parser_state::mark_completion_tag): Now methods.
1207         (prefixify_expression): Add last_struct parameter.
1208         (prefixify_subexp): Likewise.
1209         (parse_exp_1): Update.
1210         (parse_exp_in_context): Add cstate parameter.  Update.
1211         (parse_expression_for_completion): Create an
1212         expr_completion_state.
1213         (null_post_parser): Add "completion" parameter.
1214         * p-exp.y: Update rules.
1215         (yylex): Update.
1216         * language.h (struct language_defn) <la_post_parser>: Add
1217         "completing" parameter.
1218         * go-exp.y: Update rules.
1219         (lex_one_token): Update.
1220         * expression.h (parse_completion): Don't declare.
1221         * d-exp.y: Update rules.
1222         (lex_one_token): Update rules.
1223         * c-exp.y: Update rules.
1224         (lex_one_token): Update.
1225         * ada-lang.c (resolve): Add "parse_completion" parameter.
1226         (resolve_subexp): Likewise.
1227         (ada_resolve_function): Likewise.
1228
1229 2019-04-04  Tom Tromey  <tom@tromey.com>
1230
1231         * parser-defs.h (struct parser_state) <start_arglist,
1232         end_arglist>: New methods.
1233         <arglist_len, m_funcall_chain>: New members.
1234         (arglist_len, start_arglist, end_arglist): Don't declare.
1235         * parse.c (arglist_len, funcall_chain): Remove global.
1236         (start_arglist, end_arglist): Remove functions.
1237         (parse_exp_in_context): Update.
1238         * p-exp.y: Update rules.
1239         * m2-exp.y: Update rules.
1240         * go-exp.y: Update rules.
1241         * f-exp.y: Update rules.
1242         * d-exp.y: Update rules.
1243         * c-exp.y: Update rules.
1244
1245 2019-04-04  Tom Tromey  <tom@tromey.com>
1246
1247         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
1248         lex_operator, push_back>: New methods.
1249         Update all rules.
1250         (rust_parser::lex_hex, lex_escape): Rename and update.
1251         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
1252         (rust_parser::lex_operator): Rename and update.
1253         (rust_parser::lex_number, rustyylex, rustyyerror)
1254         (rust_lex_test_init, rust_lex_test_sequence)
1255         (rust_lex_test_push_back, rust_lex_tests): Update.
1256         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
1257         parameter.
1258         <lexptr, prev_lexptr>: New members.
1259         (lexptr, prev_lexptr): Don't declare.
1260         * parse.c (lexptr, prev_lexptr): Remove globals.
1261         (parse_exp_in_context): Update.
1262         * p-exp.y (yylex, yyerror): Update.
1263         * m2-exp.y (parse_number, yylex, yyerror): Update.
1264         * go-exp.y (lex_one_token, yyerror): Update.
1265         * f-exp.y (match_string_literal, yylex, yyerror): Update.
1266         * d-exp.y (lex_one_token, yyerror): Update.
1267         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
1268         (lex_one_token, yyerror): Update.
1269         * ada-lex.l (YY_INPUT): Update.
1270         (rewind_to_char): Update.
1271         * ada-exp.y (yyerror): Update.
1272
1273 2019-04-04  Tom Tromey  <tom@tromey.com>
1274
1275         * rust-exp.y (rustyylex, rust_lex_tests): Update.
1276         * parser-defs.h (struct parser_state) <parser_state>: Add new
1277         parameter.
1278         <comma_terminates>: New member.
1279         (comma_terminates): Don't declare global.
1280         * parse.c (comma_terminates): Remove global.
1281         (parse_exp_in_context): Update.
1282         * p-exp.y (yylex): Update.
1283         * m2-exp.y (yylex): Update.
1284         * go-exp.y (lex_one_token): Update.
1285         * f-exp.y (yylex): Update.
1286         * d-exp.y (lex_one_token): Update.
1287         * c-exp.y (lex_one_token): Update.
1288         * ada-lex.l: Update.
1289
1290 2019-04-04  Tom Tromey  <tom@tromey.com>
1291
1292         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
1293         (rustyylex, rust_lex_test_init, rust_lex_test_one)
1294         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
1295         * parser-defs.h (paren_depth): Don't declare.
1296         * parse.c (paren_depth): Remove global.
1297         (parse_exp_in_context): Update.
1298         * p-exp.y (paren_depth): New global.
1299         (pascal_parse): Initialize it.
1300         * m2-exp.y (paren_depth): New global.
1301         (m2_parse): Initialize it.
1302         * go-exp.y (paren_depth): New global.
1303         (go_parse): Initialize it.
1304         * f-exp.y (paren_depth): New global.
1305         (f_parse): Initialize it.
1306         * d-exp.y (paren_depth): New global.
1307         (d_parse): Initialize it.
1308         * c-exp.y (paren_depth): New global.
1309         (c_parse): Initialize it.
1310         * ada-lex.l (paren_depth): New global.
1311         (lexer_init): Initialize it.
1312
1313 2019-04-04  Tom Tromey  <tom@tromey.com>
1314
1315         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
1316         (rust_parser::convert_ast_to_type)
1317         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1318         * parser-defs.h (struct parser_state) <parser_state>: Add
1319         parameters.  Initialize new members.
1320         <expression_context_block, expression_context_pc>: New members.
1321         * parse.c (expression_context_block, expression_context_pc):
1322         Remove globals.
1323         (parse_exp_in_context): Update.
1324         * p-exp.y: Update all rules.
1325         (yylex): Update.
1326         * m2-exp.y: Update all rules.
1327         (yylex): Update.
1328         * go-exp.y (yylex): Update.
1329         * f-exp.y (yylex): Update.
1330         * d-exp.y: Update all rules.
1331         (yylex): Update.
1332         * c-exp.y: Update all rules.
1333         (lex_one_token, classify_name, yylex, c_parse): Update.
1334         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
1335
1336 2019-04-04  Tom Tromey  <tom@tromey.com>
1337
1338         * gdbarch.h, gdbarch.c: Rebuild.
1339         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
1340         * stap-probe.h: 
1341         (struct stap_parse_info): Replace "parser_state" with
1342         "expr_builder".
1343         * parser-defs.h (struct expr_builder): Rename from "parser_state".
1344         (parser_state): New class.
1345         * parse.c (expr_builder): Rename.
1346         (expr_builder::release): Rename.
1347         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
1348         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
1349         (write_exp_elt_longcst, write_exp_elt_floatcst)
1350         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
1351         (write_exp_string_vector, write_exp_bitstring)
1352         (write_exp_msymbol, mark_struct_expression)
1353         (write_dollar_variable)
1354         (insert_type_address_space, increase_expout_size): Replace
1355         "parser_state" with "expr_builder".
1356         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
1357         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
1358         "parser_state" with "expr_builder".
1359
1360 2019-04-04  Tom Tromey  <tom@tromey.com>
1361
1362         * rust-exp.y: Replace "parse_language" with method call.
1363         * p-exp.y: 
1364         (yylex): Replace "parse_language" with method call.
1365         * m2-exp.y: 
1366         (yylex): Replace "parse_language" with method call.
1367         * go-exp.y (classify_name): Replace "parse_language" with method
1368         call.
1369         * f-exp.y (yylex): Replace "parse_language" with method call.
1370         * d-exp.y (lex_one_token): Replace "parse_language" with method
1371         call.
1372         * c-exp.y: 
1373         (lex_one_token, classify_name, yylex): Replace "parse_language"
1374         with method call.
1375         * ada-exp.y (find_primitive_type, type_char)
1376         (type_system_address): Replace "parse_language" with method call.
1377
1378 2019-04-04  Tom Tromey  <tom@tromey.com>
1379
1380         * rust-exp.y: Replace "parse_gdbarch" with method call.
1381         * parse.c (write_dollar_variable, insert_type_address_space):
1382         Replace "parse_gdbarch" with method call.
1383         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
1384         call.
1385         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
1386         call.
1387         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
1388         "parse_gdbarch" with method call.
1389         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
1390         with method call.
1391         * f-exp.y (parse_type, parse_f_type, yylex): Replace
1392         "parse_gdbarch" with method call.
1393         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
1394         "parse_gdbarch" with method call.
1395         * c-exp.y (parse_type, parse_number, classify_name): Replace
1396         "parse_gdbarch" with method call.
1397         * ada-lex.l: Replace "parse_gdbarch" with method call.
1398         * ada-exp.y (parse_type, find_primitive_type, type_char)
1399         (type_system_address): Replace "parse_gdbarch" with method call.
1400
1401 2019-04-04  Tom Tromey  <tom@tromey.com>
1402
1403         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
1404         * stap-probe.c (stap_parse_argument): Update.
1405         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
1406         initial_size parameter.
1407         * rust-exp.y (rust_lex_tests): Update.
1408         * parse.c (parser_state): Update.
1409         (parse_exp_in_context): Update.
1410         * parser-defs.h (struct parser_state) <parser_state>: Remove
1411         "initial_size" parameter.
1412
1413 2019-04-04  Tom Tromey  <tom@tromey.com>
1414
1415         * parser-defs.h (increase_expout_size): Don't declare.
1416         * parse.c (increase_expout_size): Now static.
1417
1418 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
1419
1420         * gnu-nat.c (gnu_nat_target::wait): Fix
1421         target_waitstatus_to_string call.
1422
1423 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1424
1425         * eval.c (evaluate_subexp_standard): Handle internal functions
1426         during Fortran function call handling.
1427
1428 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1429
1430         * NEWS: Mention new internal functions.
1431         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
1432         (read_base_type): Use dwarf2_init_complex_target_type.
1433         * value.c (creal_internal_fn): New function.
1434         (cimag_internal_fn): New function.
1435         (_initialize_values): Register new internal functions.
1436
1437 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1438
1439         * infrun.c (stop_all_threads): If debug_infrun, always
1440         trace the wait status after wait_one, using
1441         target_waitstatus_to_string and target_pid_to_str.
1442         (handle_inferior_event): Replace various trace of
1443         wait status kind by a single trace.
1444         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
1445         wait status kind image by target_waitstatus_to_string.
1446         * target/waitstatus.c (target_waitstatus_to_string): Fix
1447         obsolete comment.
1448
1449 2019-04-01  Tom Tromey  <tromey@adacore.com>
1450
1451         PR symtab/23331:
1452         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
1453
1454 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
1455             Pedro Alves  <palves@redhat.com>
1456
1457         * top.c (quit_force): Call 'finalize_values'.
1458         * value.c (finalize_values): New function.
1459         * value.h (finalize_values): Declare.
1460
1461 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
1462
1463         * NEWS: Announce $_gdb_major and $_gdb_minor.
1464
1465         * top.c (init_gdb_version_vars): New function.
1466         (gdb_init): Call init_gdb_version_vars.
1467
1468 2019-03-29  Tom Tromey  <tromey@adacore.com>
1469
1470         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
1471         help text.  Remove dead code.
1472
1473 2019-03-29  Keith Seitz  <keiths@redhat.com>
1474
1475         From Siddhesh Poyarekar:
1476         * f-lang.h (f77_get_upperbound): Return LONGEST.
1477         (f77_get_lowerbound): Likewise.
1478         * f-typeprint.c (f_type_print_varspec_suffix): Expand
1479         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
1480         print them.
1481         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
1482         plongest to format print it.
1483         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
1484         (f77_get_upperbound): Likewise.
1485         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
1486         LOWER_BOUND to LONGEST.
1487         (f77_create_arrayprint_offset_tbl): Likewise.
1488
1489 2019-03-29  Keith Seitz  <keiths@redhat.com>
1490
1491         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
1492         %s/pulongest for TYPE_LENGTH instead of %d in format
1493         strings.
1494         * ada-typerint.c (ada_print_type): Likewise.
1495         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
1496         * compile/compile-c-support.c (generate_register_struct): Likewise.
1497         * gdbtypes.c (recursive_dump_type): Likewise.
1498         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
1499         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
1500         instead of %d in format strings.
1501         * riscv-tdep.c (riscv_type_alignment): Cast second argument
1502         to std::min to ULONGEST.
1503         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
1504         instead of %d in format strings.
1505         * tracepoint.c (info_scope_command): Likewise.
1506         * typeprint.c (print_offset_data::update)
1507         (print_offset_data::finish): Likewise.
1508         * xtensa-tdep.c (xtensa_store_return_value)
1509         (xtensa_push_dummy_call): Likewise.
1510
1511 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
1512
1513         * windows-nat.c (display_selector): Fixed format specifications
1514         for 64-bit Cygwin.
1515
1516 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1517
1518         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
1519
1520 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
1521
1522         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
1523         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
1524         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
1525         (nios2_linux_init_abi): Install it.
1526
1527 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1528
1529         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
1530
1531 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1532
1533         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
1534
1535 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1536             Tom Tromey  <tromey@adacore.com>
1537
1538         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
1539
1540 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
1541
1542         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
1543         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
1544         method to compute the bounds of range types. Also print "[evaluated]"
1545         if the bounds' values come from a dynamic evaluation.
1546
1547 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1548
1549         * cp-valprint.c (cp_print_value_fields): Don't print trailing
1550         whitespace when pretty printing is on.
1551
1552 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1553
1554         * ppc-linux-nat.c: Add include.
1555
1556 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1557
1558         * NEWS: Mention AArch64 Pointer Authentication.
1559
1560 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1561
1562         * arm-linux-nat.c: Add include.
1563
1564 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
1565
1566         * source-cache.c (source_cache::get_source_lines): Re-read
1567         fullname after calling open_source_file.
1568
1569 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
1570
1571         * NEWS: Mention TLS support for FreeBSD.
1572
1573 2019-03-25  Tom Tromey  <tromey@adacore.com>
1574
1575         * minsyms.c (BUNCH_SIZE): Update comment.
1576         (~minimal_symbol_reader): Remove old comment.
1577         (compact_minimal_symbols): Update comment.
1578         (minimal_symbol_reader::install): Remove old comment.  Update
1579         other comments.
1580
1581 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1582
1583         * s390-linux-nat.c: Add include.
1584
1585 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1586
1587         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1588         Call linux_get_hwcap.
1589         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
1590         Likewise.
1591         (aarch64_linux_get_hwcap): Remove function.
1592         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
1593         declaration.
1594         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
1595         linux_get_hwcap.
1596         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1597         * linux-tdep.c (linux_get_hwcap): Add function.
1598         (linux_get_hwcap2): Likewise.
1599         * linux-tdep.h (linux_get_hwcap): Add declaration.
1600         (linux_get_hwcap2): Likewise.
1601         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
1602         (ppc_linux_get_hwcap2): Likewise.
1603         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
1604         linux_get_hwcap.
1605         (ppc_linux_nat_target::insert_watchpoint): Likewise.
1606         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
1607         (ppc_linux_nat_target::read_description): Likewise.
1608         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
1609         * s390-linux-nat.c: Likewise.
1610         * s390-linux-tdep.c (s390_core_read_description): Likewise.
1611
1612 2019-03-24  Tom Tromey  <tom@tromey.com>
1613
1614         * ada-lang.c (standard_lookup): Simplify initialization.
1615         (ada_lookup_symbol_nonlocal): Simplify return.
1616         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
1617         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
1618         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
1619         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
1620         initialization.
1621         * solib.c (solib_global_lookup): Simplify.
1622         * symtab.c (null_block_symbol): Remove.
1623         (symbol_cache_lookup): Simplify returns.
1624         (lookup_language_this): Simplify returns.
1625         (lookup_symbol_aux): Simplify return.
1626         (lookup_local_symbol): Simplify returns.
1627         (lookup_global_symbol_from_objfile): Simplify return.
1628         (lookup_symbol_in_objfile_symtabs)
1629         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
1630         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
1631         (lookup_static_symbol, lookup_global_symbol): Simplify return.
1632         * cp-namespace.c (cp_lookup_bare_symbol)
1633         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
1634         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
1635         (cp_lookup_nested_symbol): Don't use null_block_symbol.
1636         (cp_lookup_symbol_via_imports): Simplify initialization.
1637         (find_symbol_in_baseclass): Likewise.
1638         * symtab.h (null_block_symbol): Remove.
1639         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
1640         (d_lookup_nested_symbol, d_lookup_symbol_imports)
1641         (d_lookup_symbol_module): Likewise.
1642         (find_symbol_in_baseclass): Simplify initialization.
1643
1644 2019-03-24  Tom Tromey  <tom@tromey.com>
1645
1646         * expression.h: Don't include symtab.h.
1647         (struct block): Forward declare.
1648
1649 2019-03-24  Tom Tromey  <tom@tromey.com>
1650
1651         * c-exp.y (typebase): Remove casts.
1652         * gdbtypes.c (lookup_unsigned_typename, )
1653         (lookup_signed_typename): Remove cast.
1654         * eval.c (parse_to_comma_and_eval): Remove cast.
1655         * parse.c (write_dollar_variable): Remove cast.
1656         * block.h (struct block) <superblock>: Now const.
1657         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
1658         * psymtab.c (psym_map_matching_symbols): Make "block" const.
1659         (map_block): Make "block" const.
1660         * symfile.h (struct quick_symbol_functions)
1661         <map_matching_symbols>: Constify block argument to "callback".
1662         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
1663         const.
1664         (find_pc_sect_compunit_symtab): Make "b" const.
1665         (find_symbol_at_address): Likewise.
1666         (search_symbols): Likewise.
1667         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
1668         (dw2_debug_names_lookup_symbol): Likewise.
1669         (dw2_map_matching_symbols): Update.
1670         * p-valprint.c (pascal_val_print): Remove "block".
1671         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
1672         (aux_add_nonlocal_symbols): Make "block" const.
1673         (resolve_subexp): Remove cast.
1674         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
1675         const.
1676         (iterate_over_file_blocks): Likewise.
1677         * f-exp.y (%union) <bval>: Remove.
1678         * coffread.c (patch_opaque_types): Make "b" const.
1679         * spu-tdep.c (spu_catch_start): Make "block" const.
1680         * c-valprint.c (print_unpacked_pointer): Remove "block".
1681         * symmisc.c (dump_symtab_1): Make "b" const.
1682         (block_depth): Make "block" const.
1683         * d-exp.y (%union) <bval>: Remove.
1684         * cp-support.h (cp_lookup_rtti_type): Update.
1685         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
1686         * psymtab.c (psym_lookup_symbol): Make "block" const.
1687         (maintenance_check_psymtabs): Make "b" const.
1688         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
1689         (enumerate_locals, enumerate_args): Update.
1690         * python/py-symtab.c (stpy_global_block): Make "block" const.
1691         (stpy_static_block): Likewise.
1692         * inline-frame.c (block_starting_point_at): Make "new_block"
1693         const.
1694         * block.c (find_block_in_blockvector): Make return type const.
1695         (blockvector_for_pc_sect): Make "b" const.
1696         (find_block_in_blockvector): Make "b" const.
1697
1698 2019-03-23  Tom Tromey  <tom@tromey.com>
1699
1700         * varobj.c (varobj_create): Update.
1701         * symfile.c (clear_symtab_users): Don't reset innermost_block.
1702         * printcmd.c (display_command, do_one_display): Don't reset
1703         innermost_block.
1704         * parser-defs.h (enum innermost_block_tracker_type): Move to
1705         expression.h.
1706         (innermost_block): Update comment.
1707         * parse.c (parse_exp_1): Add tracker_types parameter.
1708         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
1709         tracker_types parameter.  Reset innermost_block.
1710         (parse_exp_in_context): Remove.
1711         (parse_expression_for_completion): Update.
1712         * objfiles.c (~objfile): Don't reset expression_context_block or
1713         innermost_block.
1714         * expression.h (enum innermost_block_tracker_type): Move from
1715         parser-defs.h.
1716         (parse_exp_1): Add tracker_types parameter.
1717         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
1718         reset innermost_block.
1719
1720 2019-03-23  Tom Tromey  <tom@tromey.com>
1721
1722         * objfiles.h: Include bcache.h.
1723
1724 2019-03-23  Tom Tromey  <tom@tromey.com>
1725
1726         * linespec.c (get_current_search_block): Use
1727         scoped_restore_current_language.
1728         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
1729
1730 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1731             Jiong Wang  <jiong.wang@arm.com>
1732
1733         * aarch64-linux-tdep.c
1734         (aarch64_linux_iterate_over_regset_sections): Check for pauth
1735         section.
1736         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
1737
1738 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1739             Jiong Wang  <jiong.wang@arm.com>
1740
1741         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
1742         instructions.
1743         (aarch64_analyze_prologue_test): Add PACIASP test.
1744         (aarch64_prologue_prev_register): Unmask PC value.
1745
1746 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1747             Jiong Wang  <jiong.wang@arm.com>
1748
1749         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
1750         (aarch64_dwarf2_prev_register): Unmask PC value.
1751         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
1752         (aarch64_execute_dwarf_cfa_vendor_op): Check for
1753         DW_CFA_AARCH64_negate_ra_state.
1754         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
1755
1756 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1757             Jiong Wang  <jiong.wang@arm.com>
1758
1759         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
1760         registers.
1761         (aarch64_pseudo_register_name): Likewise.
1762         (aarch64_pseudo_register_type): Likewise.
1763         (aarch64_pseudo_register_reggroup_p): Likewise.
1764         (aarch64_gdbarch_init): Add pauth registers.
1765         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
1766         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
1767         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
1768         (struct gdbarch_tdep): Add regnum for ra_state.
1769
1770 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1771             Jiong Wang  <jiong.wang@arm.com>
1772
1773         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
1774
1775 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1776             Jiong Wang  <jiong.wang@arm.com>
1777
1778         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
1779         function.
1780         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
1781         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
1782         (aarch64_gdbarch_init): Add puth registers.
1783         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
1784         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
1785         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
1786
1787 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1788             Jiong Wang  <jiong.wang@arm.com>
1789
1790         * aarch64-linux-nat.c
1791         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
1792         * aarch64-linux-tdep.c
1793         (aarch64_linux_core_read_description): Likewise.
1794         (aarch64_linux_get_hwcap): New function.
1795         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
1796         (aarch64_linux_get_hwcap): New declaration.
1797
1798 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1799             Jiong Wang  <jiong.wang@arm.com>
1800
1801         * aarch64-linux-nat.c
1802         (aarch64_linux_nat_target::read_description): Add pauth param.
1803         * aarch64-linux-tdep.c
1804         (aarch64_linux_core_read_description): Likewise.
1805         * aarch64-tdep.c (struct target_desc): Add in pauth.
1806         (aarch64_read_description): Add pauth param.
1807         (aarch64_gdbarch_init): Likewise.
1808         * aarch64-tdep.h (aarch64_read_description): Likewise.
1809         * arch/aarch64.c (aarch64_create_target_description): Likewise.
1810         * arch/aarch64.h (aarch64_create_target_description): Likewise.
1811         * features/Makefile: Add new files.
1812         * features/aarch64-pauth.c: New file.
1813         * features/aarch64-pauth.xml: New file.
1814
1815 2019-03-20  Tom Tromey  <tromey@adacore.com>
1816
1817         * infrun.c (handle_inferior_event): Rename from
1818         handle_inferior_event_1.  Create a scoped_value_mark.
1819         (handle_inferior_event): Remove.
1820
1821 2019-03-19  Tom Tromey  <tromey@adacore.com>
1822
1823         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
1824         * infrun.h (print_stop_event): Add "displays" parameter.
1825         * infrun.c (print_stop_event): Add "displays" parameter.
1826
1827 2019-03-19  Pedro Alves  <palves@redhat.com>
1828
1829         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
1830         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
1831         to -1.  Fix TABs vs spaces.
1832         (tui_ui_out::tui_ui_out): Don't initialize fields here.
1833         * tui/tui-out.h (tui_ui_out) Add intro comments.
1834         <m_line, m_start_of_line>: In-class initialize, and add describing
1835         comment.
1836
1837 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
1838
1839         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
1840         variable names.
1841         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
1842
1843 2019-03-18  Pedro Alves  <palves@redhat.com>
1844             Eli Zaretskii <eliz@gnu.org>
1845
1846         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
1847         m_line and m_start_of_line.
1848
1849 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
1850
1851         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
1852         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
1853         it returns a newline.  This fixes a regression in TU mode, whereby
1854         the next line is output on the same screen line as the user input.
1855
1856 2019-03-18  Tom Tromey  <tromey@adacore.com>
1857
1858         * minsyms.c (minimal_symbol_reader::install): Remove call to
1859         obstack_blank.
1860
1861 2019-03-18  Pedro Alves  <palves@redhat.com>
1862
1863         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
1864         New globals.
1865         (apply_style): New, factored out from ...
1866         (apply_ansi_escape): ... this.  Handle reverse video mode.
1867         (tui_set_reverse_mode): New function.
1868         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
1869         * tui/tui-winsource.c (tui_show_source_line): Use
1870         tui_set_reverse_mode instead of setting A_STANDOUT.
1871         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
1872         New setter methods.
1873
1874 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
1875
1876         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
1877         Handle tabs.
1878
1879 2019-03-18  Tom Tromey  <tromey@adacore.com>
1880
1881         * ada-lang.c (empty_array): Add "high" parameter.
1882         (ada_evaluate_subexp): Update.
1883
1884 2019-03-17  Sergei Trofimovich <siarheit@google.com>
1885
1886         * unittests/string_view-selftests.c: Define
1887         _initialize_string_view_selftests unconditionally.
1888
1889 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
1890
1891         PR gdb/24350
1892         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
1893
1894 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
1895
1896         PR gdb/24351
1897         * windows-nat.c (display_selector): Fix format specifiers.
1898
1899 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
1900
1901         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
1902         tui_refill_source_window instead of tui_refresh_win, to update the
1903         current execution line.  This fixes redisplay of the current line
1904         when stepping through the code with "next" or "step".
1905
1906 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
1907
1908         * source-cache.c (source_cache::get_source_lines): Call
1909         find_source_lines to initialize s->nlines.  This fixes vertical
1910         scrolling of TUI source window when the DOWN arrow is pressed.
1911
1912 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1913
1914         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
1915         linux-thread-db.c (_initialize_thread_db): Likewise.
1916
1917 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
1918
1919         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
1920         wclrtoeol in tui_show_source_line".  This reverts changes made in
1921         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
1922
1923 2019-03-15  Tom Tromey  <tom@tromey.com>
1924
1925         * symtab.h (struct minimal_symbol): Derive from
1926         general_symbol_info.
1927         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
1928         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
1929         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
1930         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
1931         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
1932         (MSYMBOL_SEARCH_NAME): Update.
1933         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
1934         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
1935         * minsyms.c (minimal_symbol_reader::record_full): Update.
1936
1937 2019-03-15  Tom Tromey  <tom@tromey.com>
1938
1939         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
1940
1941 2019-03-15  Tom Tromey  <tom@tromey.com>
1942
1943         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
1944         unique_xmalloc_ptr.
1945         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
1946         Update.
1947         * minsyms.c (lookup_minimal_symbol_by_pc_section)
1948         (build_minimal_symbol_hash_tables)
1949         (minimal_symbol_reader::install): Update.
1950
1951 2019-03-15  Tom Tromey  <tom@tromey.com>
1952
1953         * symtab.c (create_demangled_names_hash): Update.
1954         (symbol_set_names): Update.
1955         * objfiles.h (struct objfile_per_bfd_storage)
1956         <demangled_names_hash>: Now an htab_up.
1957         * objfiles.c (objfile_per_bfd_storage): Simplify.
1958
1959 2019-03-15  Tom Tromey  <tom@tromey.com>
1960
1961         * objfiles.h (struct objfile_per_bfd_storage): Declare
1962         destructor.
1963         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
1964         New.
1965         (get_objfile_bfd_data): Use new.  Don't initialize
1966         language_of_main.
1967         (free_objfile_per_bfd_storage): Remove.
1968         (objfile_bfd_data_free, objfile::~objfile): Use delete.
1969
1970 2019-03-15  Tom Tromey  <tom@tromey.com>
1971
1972         * symfile.c (reread_symbols): Update.
1973         * objfiles.c (objfile::objfile): Update.
1974         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
1975         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
1976         comment.
1977         (minimal_symbol_reader::install): Update.
1978         (terminate_minimal_symbol_table): Remove.
1979         * jit.c (jit_object_close_impl): Update.
1980
1981 2019-03-15  Tom Tromey  <tom@tromey.com>
1982
1983         * minsyms.c (minimal_symbol_reader::record_full): Remove some
1984         initializations.
1985
1986 2019-03-15  Tom Tromey  <tom@tromey.com>
1987
1988         * objfiles.h (struct objfile_per_bfd_storage)
1989         <demangled_hash_languages>: Now a bitset.
1990         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
1991         (lookup_minimal_symbol): Update.
1992
1993 2019-03-15  Tom Tromey  <tom@tromey.com>
1994
1995         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
1996         Don't return the symbol.
1997         * coffread.c (record_minimal_symbol): Use record_full.
1998
1999 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
2000
2001         The MS-Windows port of ncurses fails to switch to a color pair if
2002         one or both of the colors are the implicit default colors.  This
2003         change records the default colors when TUI is initialized, and
2004         then specifies them explicitly when a color pair uses the default
2005         colors.  This allows color styling in TUI mode on MS-Windows.
2006
2007         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
2008         ncurses_norm_attr.
2009         (tui_initialize_io) [__MINGW32__]: Record the default terminal
2010         colors in ncurses_norm_attr.
2011         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
2012         "none", replace it with the default color recorded in
2013         ncurses_norm_attr.
2014
2015 2019-03-14  Tom Tromey  <tromey@adacore.com>
2016
2017         * source-cache.h (class source_cache) <get_source_lines>: Return
2018         std::string.
2019         * source-cache.c (source_cache::extract_lines): Handle case where
2020         first_pos==npos.  Return std::string.
2021         (source_cache::get_source_lines): Update.
2022
2023 2019-03-14  Tom Tromey  <tromey@adacore.com>
2024
2025         * NEWS: Add item for "style sources" commands.
2026         * source-cache.c (source_cache::get_source_lines): Check
2027         source_styling.
2028         * cli/cli-style.c (source_styling): New global.
2029         (_initialize_cli_style): Add "style sources" commands.
2030         (show_style_sources): New function.
2031         * cli/cli-style.h (source_styling): Declare.
2032
2033 2019-03-14  Pedro Alves  <palves@redhat.com>
2034             Tom Tromey  <tromey@adacore.com>
2035
2036         * tui/tui-winsource.h (tui_refill_source_window): Declare.
2037         * tui/tui-winsource.c (tui_refill_source_window): New function,
2038         from...
2039         (tui_horizontal_source_scroll): ... here.  Move some logic.
2040         * cli/cli-style.c (set_style_enabled): Notify new observable.
2041         * tui/tui-hooks.c (tui_redisplay_source): New function.
2042         (tui_attach_detach_observers): Attach or detach
2043         tui_redisplay_source.
2044         * observable.h (source_styling_changed): New observable.
2045         * observable.c: Define source_styling_changed observable.
2046
2047 2019-03-13  Tom Tromey  <tromey@adacore.com>
2048
2049         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
2050         (i386_gnu_nat_target::store_registers): Update.
2051         * target-debug.h (target_debug_print_std_string): New macro.
2052         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2053         * windows-tdep.c (display_one_tib): Update.
2054         * tui/tui-stack.c (tui_make_status_line): Update.
2055         * top.c (print_inferior_quit_action): Update.
2056         * thread.c (thr_try_catch_cmd): Update.
2057         (add_thread_with_info): Update.
2058         (thread_target_id_str): Update.
2059         (thr_try_catch_cmd): Update.
2060         (thread_command): Update.
2061         (thread_find_command): Update.
2062         * record-btrace.c (record_btrace_target::info_record)
2063         (record_btrace_resume_thread, record_btrace_target::resume)
2064         (record_btrace_cancel_resume, record_btrace_step_thread)
2065         (record_btrace_target::wait, record_btrace_target::wait)
2066         (record_btrace_target::wait, record_btrace_target::stop): Update.
2067         * progspace.c (print_program_space): Update.
2068         * process-stratum-target.c
2069         (process_stratum_target::thread_address_space): Update.
2070         * linux-fork.c (linux_fork_mourn_inferior)
2071         (detach_checkpoint_command, info_checkpoints_command)
2072         (linux_fork_context): Update.
2073         (linux_fork_detach): Update.
2074         (class scoped_switch_fork_info): Update.
2075         (delete_checkpoint_command): Update.
2076         * infrun.c (follow_fork_inferior): Update.
2077         (follow_fork_inferior): Update.
2078         (proceed_after_vfork_done): Update.
2079         (handle_vfork_child_exec_or_exit): Update.
2080         (follow_exec): Update.
2081         (displaced_step_prepare_throw): Update.
2082         (displaced_step_restore): Update.
2083         (start_step_over): Update.
2084         (resume_1): Update.
2085         (clear_proceed_status_thread): Update.
2086         (proceed): Update.
2087         (print_target_wait_results): Update.
2088         (do_target_wait): Update.
2089         (context_switch): Update.
2090         (stop_all_threads): Update.
2091         (restart_threads): Update.
2092         (finish_step_over): Update.
2093         (handle_signal_stop): Update.
2094         (switch_back_to_stepped_thread): Update.
2095         (keep_going_pass_signal): Update.
2096         (print_exited_reason): Update.
2097         (normal_stop): Update.
2098         * inferior.c (inferior_pid_to_str): Change return type.
2099         (print_selected_inferior): Update.
2100         (add_inferior): Update.
2101         (detach_inferior): Update.
2102         * dummy-frame.c (fprint_dummy_frames): Update.
2103         * dcache.c (dcache_info_1): Update.
2104         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
2105         (btrace_fetch, btrace_clear): Update.
2106         * linux-tdep.c (linux_core_pid_to_str): Change return type.
2107         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
2108         type.
2109         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
2110         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
2111         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
2112         * gdbarch.c, gdbarch.h: Rebuild.
2113         * gdbarch.sh (core_pid_to_str): Change return type.
2114         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
2115         return type.
2116         (windows_nat_target::pid_to_str): Change return type.
2117         (windows_delete_thread): Update.
2118         (windows_nat_target::attach): Update.
2119         (windows_nat_target::files_info): Update.
2120         * target-delegates.c: Rebuild.
2121         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
2122         return type.
2123         (sol_thread_target::pid_to_str): Change return type.
2124         * remote.c (class remote_target) <pid_to_str>: Change return
2125         type.
2126         (remote_target::pid_to_str): Change return type.
2127         (extended_remote_target::attach, remote_target::remote_stop_ns)
2128         (remote_target::remote_notif_remove_queued_reply)
2129         (remote_target::push_stop_reply, remote_target::disable_btrace):
2130         Update.
2131         (extended_remote_target::attach): Update.
2132         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
2133         type.
2134         (gdbsim_target::pid_to_str): Change return type.
2135         * ravenscar-thread.c (struct ravenscar_thread_target)
2136         <pid_to_str>: Change return type.
2137         (ravenscar_thread_target::pid_to_str): Change return type.
2138         * procfs.c (class procfs_target) <pid_to_str>: Change return
2139         type.
2140         (procfs_target::pid_to_str): Change return type.
2141         (procfs_target::attach): Update.
2142         (procfs_target::detach): Update.
2143         (procfs_target::fetch_registers): Update.
2144         (procfs_target::store_registers): Update.
2145         (procfs_target::wait): Update.
2146         (procfs_target::files_info): Update.
2147         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
2148         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
2149         return type.
2150         (nto_procfs_target::pid_to_str): Change return type.
2151         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
2152         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
2153         return type.
2154         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
2155         (exit_lwp): Update.
2156         (attach_proc_task_lwp_callback, get_detach_signal)
2157         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
2158         (linux_nat_target::resume, wait_lwp, stop_callback)
2159         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
2160         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
2161         (linux_nat_wait_1, resume_stopped_resumed_lwps)
2162         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
2163         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
2164         type.
2165         (inf_ptrace_target::attach): Update.
2166         (inf_ptrace_target::files_info): Update.
2167         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
2168         type.
2169         (go32_nat_target::pid_to_str): Change return type.
2170         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
2171         (gnu_nat_target::wait): Update.
2172         (gnu_nat_target::wait): Update.
2173         (gnu_nat_target::resume): Update.
2174         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
2175         (fbsd_nat_target::wait): Update.
2176         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
2177         type.
2178         (darwin_nat_target::attach): Update.
2179         * corelow.c (class core_target) <pid_to_str>: Change return type.
2180         (core_target::pid_to_str): Change return type.
2181         * target.c (normal_pid_to_str): Change return type.
2182         (default_pid_to_str): Likewise.
2183         (target_pid_to_str): Change return type.
2184         (target_translate_tls_address): Update.
2185         (target_announce_detach): Update.
2186         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
2187         return type.
2188         (bsd_uthread_target::pid_to_str): Change return type.
2189         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
2190         type.
2191         (bsd_kvm_target::pid_to_str): Change return type.
2192         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
2193         return type.
2194         (aix_thread_target::pid_to_str): Change return type.
2195         * target.h (struct target_ops) <pid_to_str>: Change return type.
2196         (target_pid_to_str, normal_pid_to_str): Likewise.
2197         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
2198         type.
2199         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
2200         type.
2201         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
2202         return type.
2203         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
2204         type.
2205         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
2206         type.
2207         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
2208         return type.
2209
2210 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
2211
2212         * NEWS: Mention that the new default MI version is 3.  Mention
2213         changes to the output of commands and events that deal with
2214         multi-location breakpoints.
2215         * breakpoint.c: Include "mi/mi-out.h".
2216         (print_one_breakpoint): Change output syntax if using MI version
2217         >= 3.
2218         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
2219         New.
2220         (mi_multi_location_breakpoint_output_fixed): New.
2221         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
2222         (mi_cmd_fix_multi_location_breakpoint_output): New.
2223         (mi_multi_location_breakpoint_output_fixed): New.
2224         * mi/mi-cmds.c (mi_cmds): Register command
2225         -fix-multi-location-breakpoint-output.
2226         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
2227         interpreter "mi".
2228
2229 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
2230
2231         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
2232         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
2233         instantiate mi_ui_out based on interpreter name.
2234         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
2235         * mi/mi-main.c (mi_load_progress): Likewise.
2236
2237 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2238
2239         * NEWS: Combine separate "New targets" sections for 8.3.
2240
2241 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2242
2243         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
2244         (ppcfbsd_init_abi): Install gdbarch
2245         "fetch_tls_load_module_address" and "get_thread_local_address"
2246         methods.
2247
2248 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2249
2250         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
2251         (riscv_fbsd_init_abi): Install gdbarch
2252         "fetch_tls_load_module_address" and "get_thread_local_address"
2253         methods.
2254
2255 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2256
2257         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
2258         (i386fbsd_init_abi): Install gdbarch
2259         "fetch_tls_load_module_address" and "get_thread_local_address"
2260         methods.
2261
2262 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2263
2264         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
2265         (amd64fbsd_init_abi): Install gdbarch
2266         "fetch_tls_load_module_address" and "get_thread_local_address"
2267         methods.
2268
2269 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2270
2271         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
2272         (struct fbsd_pspace_data): New type.
2273         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
2274         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
2275         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
2276         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
2277         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
2278
2279 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2280
2281         * gdbtypes.c (lookup_struct_elt): New function.
2282         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
2283         * gdbtypes.h (struct struct_elt): New type.
2284         (lookup_struct_elt): New prototype.
2285
2286 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2287
2288         * gdbtypes.c (lookup_struct_elt_type): Update comment and
2289         remove disabled code block.
2290
2291 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2292
2293         * gdbarch.sh (get_thread_local_address): New method.
2294         * gdbarch.h, gdbarch.c: Regenerate.
2295         * target.c (target_translate_tls_address): Use
2296         gdbarch_get_thread_local_address if present instead of
2297         target::get_thread_local_address.
2298
2299 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2300
2301         * target.h (target::get_thread_local_address): Update comment.
2302
2303 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2304
2305         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
2306         objfile->separate_debug_objfile_backlink if not NULL.
2307
2308 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2309
2310         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
2311         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
2312         (amd64bsd_store_inferior_registers): Likewise.
2313         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2314         Enable segment base registers.
2315         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
2316         PT_GETFSBASE and PT_GETGSBASE.
2317         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
2318         PT_SETGSBASE.
2319         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
2320         segment base registers.
2321         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2322
2323 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2324
2325         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2326         Update calls to i386_target_description to add 'segments'
2327         parameter.
2328         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
2329         add segment base registers.
2330         * arch/i386.c (i386_create_target_description): Add 'segments'
2331         parameter to enable segment base registers.
2332         * arch/i386.h (i386_create_target_description): Likewise.
2333         * features/i386/32bit-segments.xml: New file.
2334         * features/i386/32bit-segments.c: Generate.
2335         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
2336         call to i386_target_description to add 'segments' parameter.
2337         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2338         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
2339         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
2340         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
2341         if feature is present.
2342         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
2343         Add 'segments' parameter to call to i386_target_description.
2344         (i386_target_description): Add 'segments' parameter to enable
2345         segment base registers.
2346         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
2347         to call to i386_target_description.
2348         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
2349         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
2350         Define I386_NUM_REGS.
2351         (i386_target_description): Add 'segments' parameter to enable
2352         segment base registers.
2353
2354 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
2355
2356         PR/24325
2357         * source-cache.c: #undef open and close, to avoid unresolved
2358         externals during linking.
2359
2360 2019-03-12  Tom Tromey  <tromey@adacore.com>
2361
2362         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
2363         const.  Add initializers.
2364         (_initialize_remote): Don't initialize ptid globals.
2365
2366 2019-03-12  Pedro Alves  <palves@redhat.com>
2367
2368         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
2369
2370 2019-03-12  Pedro Alves  <palves@redhat.com>
2371
2372         * cp-name-parser.y (main): Remove unused 'len' variable.
2373
2374 2019-03-12  Tom Tromey  <tromey@adacore.com>
2375
2376         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
2377         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
2378
2379 2019-03-12  Tom Tromey  <tromey@adacore.com>
2380
2381         * linux-nat.c (iterate_over_lwps): Update.
2382         (stop_callback): Remove parameter.
2383         (stop_wait_callback, detach_callback, resume_set_callback)
2384         (select_singlestep_lwp_callback, set_ignore_sigint)
2385         (status_callback, resumed_callback, resume_clear_callback)
2386         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
2387         data parameter.
2388         (linux_nat_target::detach, linux_nat_target::resume)
2389         (linux_stop_and_wait_all_lwps, select_event_lwp)
2390         (linux_nat_filter_event, linux_nat_wait_1)
2391         (linux_nat_target::kill, linux_nat_target::stop)
2392         (linux_nat_target::stop): Update.
2393         (linux_nat_resume_callback): Change type.
2394         (resume_stopped_resumed_lwps, count_events_callback)
2395         (select_event_lwp_callback): Likewise.
2396         (linux_stop_lwp, linux_nat_stop_lwp): Update.
2397         * arm-linux-nat.c (struct update_registers_data): Remove.
2398         (update_registers_callback): Change type.
2399         (arm_linux_insert_hw_breakpoint1): Update.
2400         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
2401         parameter.
2402         (x86_linux_dr_set_addr): Update.
2403         (x86_linux_dr_set_control): Update.
2404         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
2405         (iterate_over_lwps): Use gdb::function_view.
2406         * nat/aarch64-linux-hw-point.c (struct
2407         aarch64_dr_update_callback_param): Remove.
2408         (debug_reg_change_callback): Change type.
2409         (aarch64_notify_debug_reg_change): Update.
2410         * s390-linux-nat.c (s390_refresh_per_info): Update.
2411
2412 2019-03-11  Tom Tromey  <tromey@adacore.com>
2413
2414         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
2415         redundant assignment to "this_cu".
2416
2417 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2418
2419         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
2420
2421 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2422
2423         * gdbtypes.c (rank_one_type_parm_set): New function extracted
2424         from...
2425         (rank_one_type): ... this.
2426
2427 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2428
2429         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
2430         from...
2431         (rank_one_type): ... this.
2432
2433 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2434
2435         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
2436         from...
2437         (rank_one_type): ... this.
2438
2439 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2440
2441         * gdbtypes.c (rank_one_type_parm_float): New function extracted
2442         from...
2443         (rank_one_type): ... this.
2444
2445 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2446
2447         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
2448         from...
2449         (rank_one_type): ... this.
2450
2451 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2452
2453         * gdbtypes.c (rank_one_type_parm_range): New function extracted
2454         from...
2455         (rank_one_type): ... this.
2456
2457 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2458
2459         * gdbtypes.c (rank_one_type_parm_char): New function extracted
2460         from...
2461         (rank_one_type): ... this.
2462
2463 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2464
2465         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
2466         from...
2467         (rank_one_type): ... this.
2468
2469 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2470
2471         * gdbtypes.c (rank_one_type_parm_int): New function extracted
2472         from...
2473         (rank_one_type): ... this.
2474
2475 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2476
2477         * gdbtypes.c (rank_one_type_parm_func): New function extracted
2478         from...
2479         (rank_one_type): ... this.
2480
2481 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2482
2483         * gdbtypes.c (rank_one_type_parm_array): New function extracted
2484         from...
2485         (rank_one_type): ... this.
2486
2487 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2488
2489         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
2490         from...
2491         (rank_one_type): ... this.
2492
2493 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2494
2495         * inferior.c (initialize_inferiors): Ensure 'help set/show print
2496         inferior-events' shows the example events.
2497
2498 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
2499
2500         Support styling on native MS-Windows console
2501
2502         PR/24315
2503         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
2504         on MS-Windows if $TERM is not defined.
2505
2506         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
2507
2508         * posix-hdep.c (gdb_console_fputs):
2509         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
2510         functions.
2511         * ui-file.h (gdb_console_fputs): Add prototype.
2512
2513         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
2514         back to fputs only if the former returns zero.
2515
2516 2019-03-07  Tom Tromey  <tom@tromey.com>
2517
2518         * symmisc.c (print_symbol_bcache_statistics): Update.
2519         (print_objfile_statistics): Update.
2520         * symfile.c (allocate_symtab): Update.
2521         * stabsread.c: Don't include bcache.h.
2522         * psymtab.h (struct psymbol_bcache): Don't declare.
2523         (class psymtab_storage) <psymbol_cache>: Now a bcache.
2524         (psymbol_bcache_init, psymbol_bcache_free)
2525         (psymbol_bcache_get_bcache): Don't declare.
2526         * psymtab.c (struct psymbol_bcache): Remove.
2527         (psymtab_storage::psymtab_storage): Update.
2528         (psymtab_storage::~psymtab_storage): Update.
2529         (psymbol_bcache_init, psymbol_bcache_free)
2530         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
2531         (add_psymbol_to_bcache): Update.
2532         (allocate_psymtab): Update.
2533         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
2534         macro_cache>: No longer pointers.
2535         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
2536         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
2537         * macrotab.c (macro_bcache): Update.
2538         * macroexp.c: Don't include bcache.h.
2539         * gdbtypes.c (check_types_worklist): Update.
2540         (types_deeply_equal): Remove TRY/CATCH.  Update.
2541         * elfread.c (elf_symtab_read): Update.
2542         * dwarf2read.c: Don't include bcache.h.
2543         * buildsym.c (buildsym_compunit::get_macro_table): Update.
2544         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
2545         (print_bcache_statistics, bcache_memory_used): Don't declare.
2546         (struct bcache): Move from bcache.c.  Add constructor, destructor,
2547         methods.  Rename all data members.
2548         * bcache.c (struct bcache): Move to bcache.h.
2549         (bcache::expand_hash_table): Rename from expand_hash_table.
2550         (bcache): Remove.
2551         (bcache::insert): Rename from bcache_full.
2552         (bcache::compare): Rename from bcache_compare.
2553         (bcache_xmalloc): Remove.
2554         (bcache::~bcache): Rename from bcache_xfree.
2555         (bcache::print_statistics): Rename from print_bcache_statistics.
2556         (bcache::memory_used): Rename from bcache_memory_used.
2557
2558 2019-03-07  Pedro Alves  <palves@redhat.com>
2559
2560         * infrun.c (normal_stop): Also check for
2561         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
2562
2563 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
2564
2565         * f-lang.c (value_from_host_double): Moved to...
2566         * value.c (value_from_host_double): ...here.
2567         * value.h (value_from_host_double): Declare.
2568         * guile/scm-math.c (vlscm_convert_typed_number): Use
2569         value_from_host_double.
2570         (vlscm_convert_number): Likewise.
2571         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
2572         * python/py-value.c (convert_value_from_python): Likewise.
2573
2574 2019-03-06  Tom Tromey  <tom@tromey.com>
2575
2576         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
2577
2578 2019-03-06  Tom Tromey  <tom@tromey.com>
2579
2580         * utils.h (free_current_contents): Don't declare.
2581         * utils.c (free_current_contents): Remove.
2582
2583 2019-03-06  Tom Tromey  <tom@tromey.com>
2584
2585         * top.c (quit_force): Update.
2586         * main.c (captured_command_loop): Update.
2587         * common/new-op.c (operator new): Update.
2588         * common/common-exceptions.c (struct catcher)
2589         <save_cleanup_chain>: Remove member.
2590         (exceptions_state_mc_init): Update.
2591         (exception_try_scope_entry): Return nullptr.
2592         (exception_try_scope_exit, exception_rethrow)
2593         (throw_exception_sjlj, throw_exception_cxx): Update.
2594         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
2595         (all_cleanups, do_cleanups, discard_cleanups)
2596         (discard_final_cleanups, save_cleanups, save_final_cleanups)
2597         (restore_cleanups, restore_final_cleanups): Don't declare.
2598         (do_final_cleanups): Remove parameter.
2599         * common/cleanups.c (cleanup_chain, make_cleanup)
2600         (make_cleanup_dtor, all_cleanups, do_cleanups)
2601         (discard_my_cleanups, discard_cleanups)
2602         (discard_final_cleanups, save_my_cleanups, save_cleanups)
2603         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
2604         (null_cleanup): Remove.
2605         (do_final_cleanups): Remove parameter.
2606
2607 2019-03-06  Tom Tromey  <tom@tromey.com>
2608
2609         * remote.c (remote_target::remote_parse_stop_reply): Use
2610         unique_xmalloc_ptr.
2611
2612 2019-03-06  Tom Tromey  <tom@tromey.com>
2613
2614         * stabsread.c (struct stabs_field_info): Rename from field_info.
2615         <list, fnlist>: Add initializers.
2616         <obstack>: New member.
2617         (read_member_functions, read_struct_fields, read_baseclasses):
2618         Allocate on obstack.  Don't use cleanups.
2619         (read_one_struct_field, read_member_functions, read_struct_fields)
2620         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
2621         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
2622         (read_struct_type): Update.
2623
2624 2019-03-06  Tom Tromey  <tom@tromey.com>
2625
2626         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
2627         * common/filestuff.h (make_cleanup_close): Don't declare.
2628         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
2629         Remove.
2630
2631 2019-03-06  Tom Tromey  <tom@tromey.com>
2632
2633         * solib-aix.c: Use make_scope_exit.
2634
2635 2019-03-06  Tom Tromey  <tom@tromey.com>
2636
2637         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
2638         Use make_scope_exit.
2639
2640 2019-03-06  Tom Tromey  <tom@tromey.com>
2641
2642         * solib-svr4.c (disable_probes_interface): Remove parameter.
2643         (svr4_handle_solib_event): Use make_scope_exit.
2644
2645 2019-03-06  Tom Tromey  <tom@tromey.com>
2646
2647         * remote.c (struct stop_reply_deleter): Remove.
2648         (stop_reply_up): Update.
2649         (struct stop_reply): Derive from notif_event.  Don't typedef.
2650         <regcache>: Now a std::vector.
2651         (stop_reply_xfree): Remove.
2652         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
2653         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
2654         (remote_target::discard_pending_stop_replies): Use delete.
2655         (remote_target::remote_parse_stop_reply): Update.
2656         (remote_target::process_stop_reply): Update.
2657         * remote-notif.h (struct notif_event): Add virtual destructor.
2658         Remove "dtr" member.
2659         (struct notif_client) <alloc_event>: Return a unique_ptr.
2660         (notif_event_xfree): Don't declare.
2661         (notif_event_up): New typedef.
2662         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
2663         (notif_event_xfree, do_notif_event_xfree): Remove.
2664         (remote_notif_state_xfree): Update.
2665
2666 2019-03-06  Tom Tromey  <tom@tromey.com>
2667
2668         * infrun.c (displaced_step_clear_cleanup): Now a
2669         forward_scope_exit type.
2670         (displaced_step_prepare_throw): Update.
2671         (displaced_step_fixup): Update.
2672
2673 2019-03-06  Tom Tromey  <tom@tromey.com>
2674
2675         * inferior.h (class inferior): Update comment.
2676         * gdbthread.h (class thread_info): Update comment.
2677
2678 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
2679             Tom Tromey  <tom@tromey.com>
2680
2681         * stabsread.h (struct stab_section_list): Remove.
2682         (coffstab_build_psymtabs): Update.
2683         * dbxread.c (symbuf_sections): Now a std::vector.
2684         (sect_idx): New global.
2685         (fill_symbuf): Update.
2686         (coffstab_build_psymtabs): Change type of stabsects parameter.
2687         Update.
2688         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
2689         std::vector.
2690         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
2691         (coff_locate_sections): Update.
2692         (coff_symfile_read): Remove cleanups.  Update.
2693         (init_stringtab): Add storage parameter.
2694         (free_stringtab, free_stringtab_cleanup): Remove.
2695         (init_lineno): Add storage parameter.
2696         (free_linetab, free_linetab_cleanup): Remove.
2697
2698 2019-03-06  Pedro Alves  <palves@redhat.com>
2699
2700         * linux-fork.c (fork_info::clobber_regs): Delete.
2701         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
2702         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
2703         comment.  Adjust.
2704         (scoped_switch_fork_info::scoped_switch_fork_info)
2705         (checkpoint_command, linux_fork_context): Adjust
2706         fork_save_infrun_state calls.
2707
2708 2019-03-06  Pedro Alves  <palves@redhat.com>
2709
2710         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
2711         (inf_has_multiple_threads): Return 'bool' and rewrite using
2712         inferior_info::threads().
2713
2714 2019-03-06  Pedro Alves  <palves@redhat.com>
2715
2716         * linux-fork.c: Include <list>.
2717         (fork_list): Now a std::list instance.
2718         (fork_info): Add ctor, dtor, and in-class initialize all fields.
2719         (forks_exist_p, find_last_fork): Adjust.
2720         (new_fork): Delete.
2721         (one_fork_p): New.
2722         (add_fork): Adjust.
2723         (free_fork): Delete, folded into fork_info::~fork_info().
2724         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
2725         Adjust.
2726         (init_fork_list): Delete.
2727         (linux_fork_killall, linux_fork_mourn_inferior)
2728         (linux_fork_detach, info_checkpoints_command): Adjust.
2729         (_initialize_linux_fork): No longer call init_fork_list.
2730
2731 2019-03-06  Pedro Alves  <palves@redhat.com>
2732
2733         * linux-fork.c (new_fork): New, split out of ...
2734         (add_fork): ... this.  Return void.  Move "first fork" special
2735         case from here, to ...
2736         (checkpoint_command): ... here.
2737         * linux-linux.h (add_fork): Return void.
2738
2739 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2740
2741         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
2742
2743 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2744             Chris January  <chris.january@arm.com>
2745             David Lecomber  <david.lecomber@arm.com>
2746
2747         * f-exp.y: New token, UNOP_INTRINSIC.
2748         (exp): New pattern using UNOP_INTRINSIC token.
2749         (f77_keywords): Add 'abs' keyword.
2750         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
2751         (value_from_host_double): New function.
2752         (evaluate_subexp_f): Support UNOP_ABS.
2753
2754 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2755
2756         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
2757         types.
2758
2759 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2760
2761         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
2762         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
2763         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
2764
2765 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2766
2767         * f-exp.y (convert_to_kind_type): Handle more type kinds.
2768
2769 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2770             Chris January  <chris.january@arm.com>
2771
2772         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
2773         * f-exp.y: Define 'KIND' token.
2774         (exp): New pattern for KIND expressions.
2775         (ptype): Handle types with a kind extension.
2776         (direct_abs_decl): Extend to spot kind extensions.
2777         (f77_keywords): Add 'kind' to the list.
2778         (push_kind_type): New function.
2779         (convert_to_kind_type): New function.
2780         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
2781         * parse.c (operator_length_standard): Likewise.
2782         * parser-defs.h (enum type_pieces): Add tp_kind.
2783         * std-operator.def: Add UNOP_KIND.
2784
2785 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2786
2787         * f-exp.y (f_parse): Set yydebug.
2788
2789 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2790
2791         * f-lang.c (evaluate_subexp_f): New function.
2792         (exp_descriptor_f): New global.
2793         (f_language_defn): Use exp_descriptor_f instead of
2794         exp_descriptor_standard.
2795
2796 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2797
2798         * f-exp.y (struct token): Add comments.
2799         (dot_ops): Remove uppercase versions and the end marker.
2800         (f77_keywords): Likewise.
2801         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
2802         entries in the dot_ops array are case insensitive, and use
2803         strncasecmp to compare strings.  Also some whitespace cleanup in
2804         this area.  Similar for the f77_keywords array, except entries in
2805         this list might be case sensitive.
2806
2807 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2808
2809         * f-exp.y (struct f77_boolean_val): Add comments.
2810         (boolean_values): Remove uppercase versions, and end marker.
2811         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
2812         and use strncasecmp to achieve case insensitivity.  Additionally,
2813         perform whitespace cleanup around this code.
2814
2815 2019-03-06  Tom Tromey  <tromey@adacore.com>
2816
2817         * remote-sim.c (gdbsim_target_open): Use result of
2818         gdb_argv::release.
2819
2820 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
2821         Dirk Schubert  <dirk.schubert@arm.com>
2822         Chris January  <chris.january@arm.com>
2823
2824         * eval.c (evaluate_subexp_standard): Call Fortran argument
2825         wrapping logic.
2826         * f-lang.c (struct value): A value which can be passed into a
2827         Fortran function call.
2828         (fortran_argument_convert): Wrap Fortran arguments in a pointer
2829         where appropriate.
2830         (struct type): Value ready for a Fortran function call.
2831         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
2832         is needed.
2833         * f-lang.h (fortran_argument_convert): Declaration.
2834         (fortran_preserve_arg_pointer): Declaration.
2835         * infcall.c (value_arg_coerce): Call Fortran argument logic.
2836
2837 2019-03-05  Tom Tromey  <tromey@adacore.com>
2838
2839         * python/py-prettyprint.c (print_string_repr): Remove #if.
2840         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
2841
2842 2019-03-05  Tom Tromey  <tromey@adacore.com>
2843
2844         * target.c (the_dummy_target): Move later.  Change type to
2845         "dummy_target".
2846         (initialize_targets): Don't initialize the_dummy_target.
2847
2848 2019-03-05  Tom Tromey  <tromey@adacore.com>
2849
2850         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
2851         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
2852
2853 2019-03-05  Tom Tromey  <tromey@adacore.com>
2854
2855         * windows-nat.c (windows_nat_target::attach)
2856         (windows_nat_target::detach): Don't call gdb_flush.
2857         * valprint.c (generic_val_print, val_print, val_print_string):
2858         Don't call gdb_flush.
2859         * utils.c (defaulted_query): Don't call gdb_flush.
2860         * typeprint.c (print_type_scalar): Don't call gdb_flush.
2861         * target.c (target_announce_detach): Don't call gdb_flush.
2862         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
2863         * remote.c (extended_remote_target::attach): Don't call
2864         gdb_flush.
2865         * procfs.c (procfs_target::detach): Don't call gdb_flush.
2866         * printcmd.c (do_examine): Don't call gdb_flush.
2867         (info_display_command): Don't call gdb_flush.
2868         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
2869         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
2870         * memattr.c (info_mem_command): Don't call gdb_flush.
2871         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
2872         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
2873         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
2874         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
2875         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
2876         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
2877         (gnu_nat_target::detach): Don't call gdb_flush.
2878         * f-valprint.c (f_val_print): Don't call gdb_flush.
2879         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
2880         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
2881         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
2882         gdb_flush.
2883         * c-valprint.c (c_val_print): Don't call gdb_flush.
2884         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
2885
2886 2019-03-05  Tom Tromey  <tromey@adacore.com>
2887
2888         * varobj.c (update_dynamic_varobj_children): Update.
2889         (install_default_visualizer): Use reset, not release.
2890         * value.c (set_internalvar): Update.
2891         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
2892         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
2893         ATTRIBUTE_UNUSED_RESULT.
2894
2895 2019-03-05  Tom Tromey  <tromey@adacore.com>
2896
2897         * remote.c (class scoped_remote_fd) <release>: Add
2898         ATTRIBUTE_UNUSED_RESULT.
2899
2900 2019-03-05  Tom Tromey  <tromey@adacore.com>
2901
2902         * macroexp.c (struct macro_buffer) <release>: Add
2903         ATTRIBUTE_UNUSED_RESULT.
2904
2905 2019-03-05  Tom Tromey  <tromey@adacore.com>
2906
2907         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
2908         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
2909         ATTRIBUTE_UNUSED_RESULT.
2910
2911 2019-03-05  Tom Tromey  <tromey@adacore.com>
2912
2913         * common/scoped_fd.h (class scoped_fd) <release>: Add
2914         ATTRIBUTE_UNUSED_RESULT.
2915
2916 2019-03-05  Tom Tromey  <tromey@adacore.com>
2917
2918         * parser-defs.h (struct parser_state) <release>: Add
2919         ATTRIBUTE_UNUSED_RESULT.
2920
2921 2019-03-05  Tom Tromey  <tromey@adacore.com>
2922
2923         * utils.h (class gdb_argv) <release>: Add
2924         ATTRIBUTE_UNUSED_RESULT.
2925         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
2926
2927 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
2928
2929         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
2930         for-loop range, to avoid compiler warnings.
2931
2932         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
2933         avoid compiler warnings about unused variables.
2934
2935         * NEWS: Mention end of support for native debugging on MS-Windows
2936         before XP.
2937
2938         PR gdb/24292
2939         * common/netstuff.c:
2940         * gdbserver/gdbreplay.c
2941         * gdbserver/remote-utils.c:
2942         * ser-tcp.c:
2943         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
2944         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
2945         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
2946         'getaddrinfo' and 'freeaddrinfo' were not available before
2947         Windows XP, and mingw.org's MinGW headers by default define
2948         _WIN32_WINNT to 0x500.
2949
2950 2019-03-01  Gary Benson <gbenson@redhat.com>
2951
2952         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
2953
2954 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
2955             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2956
2957         PR gdb/8527
2958         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
2959         set_sigint_trap, clear_sigint_trap.
2960
2961 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2962
2963         * target.c (target_detach): Clear the regcache and the
2964         frame cache.
2965
2966 2019-02-27  Pedro Alves  <palves@redhat.com>
2967
2968         * utils.c (set_screen_size): When we cap the height/width sizes,
2969         tweak the corresponding command variable to show "unlimited":
2970
2971 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
2972             Pedro Alves  <palves@redhat.com>
2973
2974         * utils.c (set_screen_size): Reduce "infinite" rows and columns
2975         before calling rl_set_screen_size.
2976
2977 2019-02-27  Tom Tromey  <tromey@adacore.com>
2978
2979         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
2980         define.
2981         * python/py-value.c: Remove Python 2.4 workaround.
2982         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
2983         workaround.
2984         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
2985         Python 2.4 workaround.
2986         * python/python-internal.h: Remove Python 2.4 comment.
2987         (Py_ssize_t): Don't define.
2988         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
2989         (gdb_Py_DECREF): Remove Python 2.4 workaround.
2990         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
2991         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
2992         * python/python.c (do_start_initialization): Remove Python 2.4
2993         workaround.
2994         * python/py-prettyprint.c (class dummy_python_frame): Remove.
2995         (print_children): Remove Python 2.4 workaround.
2996         * python/py-inferior.c (buffer_procs): Remove Python 2.4
2997         workaround.
2998         (CHARBUFFERPROC_NAME): Remove.
2999         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
3000         Python 2.4 workaround.
3001
3002 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3003
3004         * NEWS: Note minimum Python version.
3005
3006 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3007
3008         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
3009         code from these functions.  Remove corresponding ifdefs.  Use
3010         Py_buffer_up instead of explicit calls to PyBuffer_Release.
3011         Remove gotos and target of gotos.
3012         (infpy_search_memory): Likewise.
3013
3014 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3015
3016         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
3017         (hppa_gdbarch_init): Don't register deleted functions with
3018         gdbarch.
3019
3020 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3021
3022         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
3023         (h8300_unwind_sp): Delete.
3024         (h8300_dummy_id): Delete.
3025         (h8300_gdbarch_init): Don't register deleted functions with
3026         gdbarch.
3027
3028 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3029
3030         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
3031         (ft32_unwind_pc): Delete.
3032         (ft32_unwind_sp): Delete.
3033         (ft32_gdbarch_init): Don't register deleted functions with
3034         gdbarch.
3035
3036 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3037
3038         * gdb/frv-tdep.c (frv_dummy_id): Delete.
3039         (frv_unwind_pc): Delete.
3040         (frv_unwind_sp): Delete.
3041         (frv_gdbarch_init): Don't register deleted functions with
3042         gdbarch.
3043
3044 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3045
3046         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
3047         (riscv_unwind_pc): Delete.
3048         (riscv_unwind_sp): Delete.
3049         (riscv_gdbarch_init): Don't register deleted functions with
3050         gdbarch.
3051
3052 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3053
3054         * gdb/csky-tdep.c (csky_dummy_id): Delete.
3055         (csky_unwind_pc): Delete.
3056         (csky_unwind_sp): Delete.
3057         (csky_gdbarch_init): Don't register deleted functions with
3058         gdbarch.
3059
3060 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3061
3062         * gdb/cris-tdep.c (cris_dummy_id): Delete.
3063         (cris_unwind_pc): Delete.
3064         (cris_unwind_sp): Delete.
3065         (cris_gdbarch_init): Don't register deleted functions with
3066         gdbarch.
3067
3068 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3069
3070         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
3071         (bfin_unwind_pc): Delete.
3072         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
3073
3074 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3075
3076         * gdb/arm-tdep.c (arm_dummy_id): Delete.
3077         (arm_unwind_pc): Delete.
3078         (arm_unwind_sp): Delete.
3079         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
3080
3081 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3082
3083         * gdb/arc-tdep.c (arc_dummy_id): Delete.
3084         (arc_unwind_pc): Delete.
3085         (arc_unwind_sp): Delete.
3086         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
3087
3088 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3089
3090         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
3091         (alpha_unwind_pc): Delete.
3092         (alpha_gdbarch_init): Don't register deleted functions with
3093         gdbarch.
3094
3095 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3096
3097         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
3098         (aarch64_unwind_pc): Delete.
3099         (aarch64_unwind_sp): Delete.
3100         (aarch64_gdbarch_init): Don't register deleted functions with
3101         gdbarch.
3102
3103 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3104
3105         * gdbtypes.c (type_align): Don't consider static members when
3106         computing structure alignment.
3107
3108 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3109
3110         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
3111         return 0 for other types.
3112         * arch-utils.c (default_type_align): Always return 0.
3113         * gdbarch.h: Regenerate.
3114         * gdbarch.sh (type_align): Extend comment.
3115         * gdbtypes.c (type_align): Add additional comments, always call
3116         gdbarch_type_align before applying the default rules.
3117         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
3118         generic code will then apply a suitable default.
3119         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
3120         types, return 0 for other types.
3121
3122 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3123
3124         * NEWS: Create a new section for the next release branch.
3125         Rename the section of the current branch, now that it has
3126         been cut.
3127
3128 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3129
3130         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
3131         * version.in: Bump version to 8.3.50.DATE-git.
3132
3133 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
3134
3135         * aix-thread.c (ptid_cmp): Remove unused variable.
3136         (get_signaled_thread): Likewise.
3137         (store_regs_user_thread): Likewise.
3138         (store_regs_kernel_thread): Likewise.
3139         (fetch_regs_kernel_thread): Remove shadowed variable.
3140
3141 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3142
3143         * features/riscv/32bit-cpu.xml: Add register numbers.
3144         * features/riscv/32bit-fpu.c: Regenerate.
3145         * features/riscv/32bit-fpu.xml: Add register numbers.
3146         * features/riscv/64bit-cpu.xml: Add register numbers.
3147         * features/riscv/64bit-fpu.c: Regenerate.
3148         * features/riscv/64bit-fpu.xml: Add register numbers.
3149
3150 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
3151
3152         * NEWS: Mention two argument form of gdb.Value constructor.
3153         * python/py-value.c (convert_buffer_and_type_to_value): New
3154         function.
3155         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
3156         Add support for handling an optional second argument.  Call
3157         convert_buffer_and_type_to_value as appropriate.
3158         * python/python-internal.h (Py_buffer_deleter): New struct.
3159         (Py_buffer_up): New typedef.
3160
3161 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
3162
3163         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
3164         instead of releasing ownership.
3165
3166 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
3167
3168         * dwarf2read.c (open_and_init_dwp_file): Call
3169         elf_numsections instead of bfd_count_sections to initialize
3170         dwp_file->num_sections.
3171
3172 2019-02-25  Tom Tromey  <tromey@adacore.com>
3173
3174         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
3175
3176 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
3177
3178         * gcore.in: Add '--readnever' option when invoking GDB.
3179
3180 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3181
3182         * MAINTAINERS: Update my email address.
3183
3184 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3185
3186         * build-id.c (build_id_to_debug_bfd_1): New function.
3187         (build_id_to_debug_bfd): Look for separate debug file in
3188         sysroot.
3189
3190 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3191
3192         * gdbarch.sh: Update the copyright year range that is placed into
3193         generated files.
3194
3195 2019-02-22  Keith Seitz  <keiths@redhat.com>
3196
3197         PR symtab/23853
3198         * linespec.c (create_sals_line_offset): Search for the default
3199         symtab's filename instead of its fullname.
3200
3201 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3202
3203         * NEWS: Update style defaults.
3204
3205 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3206
3207         * main.c (captured_main_1): Disable styling in batch mode.
3208
3209 2019-02-20  Tom Tromey  <tom@tromey.com>
3210
3211         * symtab.c (symtab_symbol_info): Fix typos.
3212
3213 2019-02-20  Tom Tromey  <tromey@adacore.com>
3214
3215         * findcmd.c (_initialize_mem_search): Use upper case for
3216         metasyntactic variables.
3217
3218 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
3219
3220         * aarch64-tdep.c (aarch64_add_reggroups): New function.
3221         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
3222
3223 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
3224
3225         * top.h (source_file_name): Change to std::string.
3226         * top.c (source_file_name): Likewise.
3227         (command_line_input): Adjust.
3228         * cli/cli-script.c (script_from_file): Adjust.
3229
3230 2019-02-19  Tom Tromey  <tromey@adacore.com>
3231
3232         * ravenscar-thread.c
3233         (ravenscar_thread_target::update_thread_list): Don't call
3234         ada_build_task_list.
3235         * ada-lang.h (ada_build_task_list): Don't declare.
3236         * ada-tasks.c (struct ada_tasks_inferior_data)
3237         <task_list_valid_p>: Now bool.
3238         (read_known_tasks, ada_task_list_changed)
3239         (ada_tasks_invalidate_inferior_data): Update.
3240         (read_known_tasks_array): Return bool.
3241         (read_known_tasks_list): Likewise.
3242         (read_known_tasks): Return void.
3243         (ada_build_task_list): Now static.
3244
3245 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3246
3247         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
3248         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
3249
3250 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3251
3252         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
3253         variant for ada_tasks_pspace_data_handle and
3254         ada_tasks_inferior_data_handle.
3255         (ada_tasks_pspace_data_cleanup): New function.
3256         (ada_tasks_inferior_data_cleanup): New function.
3257
3258 2019-02-17  Tom Tromey  <tom@tromey.com>
3259
3260         * macrotab.h (macro_source_fullname): Return a std::string.
3261         * macrotab.c (macro_include, check_for_redefinition)
3262         (macro_undef, macro_lookup_definition, foreach_macro)
3263         (foreach_macro_in_scope): Update.
3264         (macro_source_fullname): Return a std::string.
3265         * macrocmd.c (show_pp_source_pos): Update.
3266
3267 2019-02-17  Tom Tromey  <tom@tromey.com>
3268
3269         * macrocmd.c (show_pp_source_pos): Style the file names.
3270
3271 2019-02-17  Tom Tromey  <tom@tromey.com>
3272
3273         PR tui/24197:
3274         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
3275
3276 2019-02-17  Tom Tromey  <tom@tromey.com>
3277
3278         * ada-lang.c (user_select_syms): Use filtered printing.
3279         * utils.c (wrap_style): New global.
3280         (desired_style): Remove.
3281         (emit_style_escape): Add stream parameter.
3282         (set_output_style, reset_terminal_style, prompt_for_continue):
3283         Update.
3284         (flush_wrap_buffer): Only flush gdb_stdout.
3285         (wrap_here): Set wrap_style.
3286         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
3287         treat escape sequences as a character.  Change when wrap buffer is
3288         flushed.
3289         (fputs_styled): Do not set the output style when the default is
3290         requested.
3291         * ui-style.h (struct ui_file_style) <is_default>: New method.
3292         * source.c (print_source_lines_base): Emit escape sequences in one
3293         piece.
3294
3295 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3296
3297         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
3298         integers and enumeration types.
3299
3300 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3301
3302         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
3303         instead of lookup_symbol_in_language
3304         (do_exact_match): New function.
3305         (ada_get_symbol_name_matcher): Return do_exact_match when
3306         doing a verbatim match.
3307
3308 2019-02-15  Tom Tromey  <tromey@adacore.com>
3309
3310         * ravenscar-thread.c (ravenscar_thread_target::resume)
3311         (ravenscar_thread_target::wait): Special case wildcard requests.
3312
3313 2019-02-15  Tom Tromey  <tromey@adacore.com>
3314
3315         * ravenscar-thread.c (base_ptid): Remove.
3316         (struct ravenscar_thread_target) <close>: New method.
3317         <m_base_ptid>: New member.
3318         <update_inferior_ptid, active_task, task_is_currently_active,
3319         runtime_initialized>: Declare methods.
3320         <ravenscar_thread_target>: Add constructor.
3321         (ravenscar_thread_target::task_is_currently_active)
3322         (ravenscar_thread_target::update_inferior_ptid)
3323         (ravenscar_runtime_initialized): Rename.  Now methods.
3324         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
3325         (ravenscar_thread_target::update_thread_list): Update.
3326         (ravenscar_thread_target::active_task): Now method.
3327         (ravenscar_thread_target::store_registers)
3328         (ravenscar_thread_target::prepare_to_store)
3329         (ravenscar_thread_target::prepare_to_store)
3330         (ravenscar_thread_target::mourn_inferior): Update.
3331         (ravenscar_inferior_created): Use "new" to create target.
3332         (ravenscar_thread_target::get_ada_task_ptid): Update.
3333         (_initialize_ravenscar): Don't initialize base_ptid.
3334         (ravenscar_ops): Remove global.
3335
3336 2019-02-15  Tom Tromey  <tromey@adacore.com>
3337
3338         * target.h (push_target): Declare new overload.
3339         * target.c (push_target): New overload, taking an rvalue reference.
3340         * remote.c (remote_target::open_1): Use push_target overload.
3341         * corelow.c (core_target_open): Use push_target overload.
3342
3343 2019-02-15  Tom Tromey  <tromey@adacore.com>
3344
3345         * ravenscar-thread.c (is_ravenscar_task)
3346         (ravenscar_task_is_currently_active): Return bool.
3347         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
3348         (_initialize_ravenscar): Remove "(void)".
3349         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
3350         Return bool.
3351
3352 2019-02-15  Tom Tromey  <tromey@adacore.com>
3353
3354         * ravenscar-thread.c (ravenscar_runtime_initializer)
3355         (has_ravenscar_runtime, get_running_thread_id)
3356         (ravenscar_thread_target::resume): Fix indentation.
3357
3358 2019-02-15  Tom Tromey  <tromey@adacore.com>
3359
3360         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
3361         from ravenscar_arch_ops.
3362         (sparc_ravenscar_ops::fetch_registers)
3363         (sparc_ravenscar_ops::store_registers): Now methods.
3364         (sparc_ravenscar_prepare_to_store): Remove.
3365         (sparc_ravenscar_ops): Redefine.
3366         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
3367         methods and destructor.  Remove members.
3368         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
3369         (ravenscar_thread_target::store_registers)
3370         (ravenscar_thread_target::prepare_to_store): Update.
3371         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
3372         Remove.
3373         (struct ppc_ravenscar_powerpc_ops): Derive from
3374         ravenscar_arch_ops.
3375         (ppc_ravenscar_powerpc_ops::fetch_registers)
3376         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
3377         (ppc_ravenscar_powerpc_ops): Redefine.
3378         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
3379         (ppc_ravenscar_e500_ops::fetch_registers)
3380         (ppc_ravenscar_e500_ops::store_registers): Now methods.
3381         (ppc_ravenscar_e500_ops): Redefine.
3382         * aarch64-ravenscar-thread.c
3383         (aarch64_ravenscar_generic_prepare_to_store): Remove.
3384         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
3385         (aarch64_ravenscar_fetch_registers)
3386         (aarch64_ravenscar_store_registers): Now methods.
3387         (aarch64_ravenscar_ops): Redefine.
3388
3389 2019-02-15  Tom Tromey  <tromey@adacore.com>
3390
3391         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
3392         (ravenscar_thread_target::stopped_by_hw_breakpoint)
3393         (ravenscar_thread_target::stopped_by_watchpoint)
3394         (ravenscar_thread_target::stopped_data_address)
3395         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
3396
3397 2019-02-15  Tom Tromey  <tromey@adacore.com>
3398
3399         * ravenscar-thread.c: Fix some typos.
3400
3401 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3402             Tom Tromey  <tromey@adacore.com>
3403
3404         * ada-lang.c (ada_exception_sal): Change addr_string to a
3405         std::string.
3406         (create_ada_exception_catchpoint): Update.
3407
3408 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3409             Tom Tromey  <tromey@adacore.com>
3410
3411         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
3412         (bp_location_ops): Remove.
3413         (base_breakpoint_allocate_location): Update.
3414         (free_bp_location): Update.
3415         * ada-lang.c (class ada_catchpoint_location)
3416         <ada_catchpoint_location>: Remove ops parameter.
3417         (ada_catchpoint_location_dtor): Remove.
3418         (ada_catchpoint_location_ops): Remove.
3419         (allocate_location_exception): Update.
3420         * breakpoint.h (struct bp_location_ops): Remove.
3421         (class bp_location) <bp_location>: Remove bp_location_ops
3422         parameter.
3423         <~bp_location>: Add destructor.
3424         <ops>: Remove.
3425
3426 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3427             Pedro Alves  <palves@redhat.com>
3428
3429         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
3430         'PATH_MAX'.
3431
3432 2019-02-14  David Michael  <fedora.dm0@gmail.com>
3433             Samuel Thibault  <samuel.thibault@gnu.org>
3434             Thomas Schwinge  <thomas@codesourcery.com>
3435
3436         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
3437         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
3438
3439 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3440
3441         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
3442         (check_empty): Use "const char *".
3443
3444         * gnu-nat.c (gnu_nat_target::detach): Instead of
3445         'detach_inferior (pid)' call
3446         'detach_inferior (find_inferior_pid (pid))'.
3447
3448         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
3449         'nat/fork-inferior.o'.
3450         * gnu-nat.c: #include "nat/fork-inferior.h".
3451
3452         * gnu-nat.c (gnu_nat_target::detach): Instead of
3453         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
3454         * gnu-nat.h: #include "inf-child.h".
3455         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
3456         'i386_gnu_nat_target::fetch_registers'.
3457         (gnu_store_registers): Rename/move to
3458         'i386_gnu_nat_target::store_registers'.
3459
3460         * config/i386/nm-i386gnu.h: Don't "#include" any files.
3461         * gnu-nat.h (mach_thread_info): New function.
3462         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
3463
3464         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
3465
3466 2019-02-14  Frederic Konrad  <konrad@adacore.com>
3467
3468         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
3469
3470 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
3471
3472         * windows-nat.c (windows_add_thread): Add new parameter
3473         "main_thread_p" with default value set to false.  Update
3474         function documentation as well as all callers.
3475         (windows_delete_thread): Likewise.
3476         (fake_create_process): Update call to windows_add_thread.
3477         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
3478         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
3479         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
3480         call to windows_delete_thread.
3481
3482 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
3483
3484         * MAINTAINERS: Add Andrew Burgess as global maintainer.
3485
3486 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3487
3488         * symfile.c (find_separate_debug_file): Use canonical path of
3489         sysroot with child_path instead of gdb_sysroot if it is valid.
3490
3491 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3492
3493         * symfile.c (find_separate_debug_file): Use child_path to
3494         determine if an object file is under a sysroot.
3495
3496 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3497
3498         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
3499         unittests/child-path-selftests.c.
3500         * common/pathstuff.c (child_path): New function.
3501         * common/pathstuff.h (child_path): New prototype.
3502         * unittests/child-path-selftests.c: New file.
3503
3504 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3505
3506         * symfile.c (find_separate_debug_file): Look for separate debug
3507         files in debug directories under the sysroot.
3508
3509 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3510
3511         * symtab.h (struct minimal_symbol data_p): New const method.
3512         (struct minimal_symbol text_p): Likewise.
3513         * symtab.c (output_source_filename): Use file name style
3514         to print file name.
3515         (print_symbol_info): Likewise.
3516         (print_msymbol_info): Use address style to print addresses.
3517         Use function name style to print executable text symbols.
3518         (expand_symtab_containing_pc): Use data_p.
3519         (find_pc_sect_compunit_symtab): Likewise.
3520
3521 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3522
3523         * breakpoint.c (describe_other_breakpoints): Use address style
3524         to print addresses.
3525         (say_where): Likewise.
3526
3527 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3528
3529         * ada-typeprint.c (print_func_type): Print function name
3530         style to print function name.
3531         * c-typeprint.c (c_print_type_1): Likewise.
3532
3533 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
3534
3535         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
3536         for execve.
3537
3538 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3539
3540         * c-exp.y (direct_abs_decl): Use emplace_back to record the
3541         type_stack.
3542
3543 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
3544
3545         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
3546         TYPE_CODE_REF types.
3547
3548 2019-02-08  Jim Wilson  <jimw@sifive.com>
3549
3550         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
3551         (riscv_linux_fregset): New.
3552         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
3553
3554 2019-02-07  Tom Tromey  <tom@tromey.com>
3555
3556         * thread.c (thread_cancel_execution_command): Update.
3557         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
3558         methods.
3559         (struct thread_fsm_ops): Remove.
3560         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
3561         (thread_fsm_should_stop, thread_fsm_return_value)
3562         (thread_fsm_set_finished, thread_fsm_finished_p)
3563         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
3564         Don't declare.
3565         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
3566         * infrun.c (clear_proceed_status_thread)
3567         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
3568         (print_stop_event): Update.
3569         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
3570         Add constructor.
3571         (step_command_fsm_ops): Remove.
3572         (new_step_command_fsm): Remove.
3573         (step_1): Update.
3574         (step_command_fsm::should_stop): Rename from
3575         step_command_fsm_should_stop.
3576         (step_command_fsm::clean_up): Rename from
3577         step_command_fsm_clean_up.
3578         (step_command_fsm::do_async_reply_reason): Rename from
3579         step_command_fsm_async_reply_reason.
3580         (struct until_next_fsm): Inherit from thread_fsm.  Add
3581         constructor.
3582         (until_next_fsm_ops): Remove.
3583         (new_until_next_fsm): Remove.
3584         (until_next_fsm::should_stop): Rename from
3585         until_next_fsm_should_stop.
3586         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
3587         (until_next_fsm::do_async_reply_reason): Rename from
3588         until_next_fsm_async_reply_reason.
3589         (struct finish_command_fsm): Inherit from thread_fsm.  Add
3590         constructor.  Change type of breakpoint.
3591         (finish_command_fsm_ops): Remove.
3592         (new_finish_command_fsm): Remove.
3593         (finish_command_fsm::should_stop): Rename from
3594         finish_command_fsm_should_stop.
3595         (finish_command_fsm::clean_up): Rename from
3596         finish_command_fsm_clean_up.
3597         (finish_command_fsm::return_value): Rename from
3598         finish_command_fsm_return_value.
3599         (finish_command_fsm::do_async_reply_reason): Rename from
3600         finish_command_fsm_async_reply_reason.
3601         (finish_command): Update.
3602         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
3603         Add constructor.
3604         (call_thread_fsm_ops): Remove.
3605         (call_thread_fsm::call_thread_fsm): Rename from
3606         new_call_thread_fsm.
3607         (call_thread_fsm::should_stop): Rename from
3608         call_thread_fsm_should_stop.
3609         (call_thread_fsm::should_notify_stop): Rename from
3610         call_thread_fsm_should_notify_stop.
3611         (run_inferior_call, call_function_by_hand_dummy): Update.
3612         * cli/cli-interp.c (should_print_stop_to_console): Update.
3613         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
3614         Add constructor.  Change type of location_breakpoint,
3615         caller_breakpoint.
3616         (until_break_fsm_ops): Remove.
3617         (new_until_break_fsm): Remove.
3618         (until_break_fsm::should_stop): Rename from
3619         until_break_fsm_should_stop.
3620         (until_break_fsm::clean_up): Rename from
3621         until_break_fsm_clean_up.
3622         (until_break_fsm::do_async_reply_reason): Rename from
3623         until_break_fsm_async_reply_reason.
3624         (until_break_command): Update.
3625         * thread-fsm.c: Remove.
3626         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
3627
3628 2019-02-07  Tom Tromey  <tom@tromey.com>
3629
3630         * yy-remap.h: Add include guard.
3631         * xtensa-tdep.h: Add include guard.
3632         * xcoffread.h: Rename include guard.
3633         * varobj-iter.h: Add include guard.
3634         * tui/tui.h: Rename include guard.
3635         * tui/tui-winsource.h: Rename include guard.
3636         * tui/tui-wingeneral.h: Rename include guard.
3637         * tui/tui-windata.h: Rename include guard.
3638         * tui/tui-win.h: Rename include guard.
3639         * tui/tui-stack.h: Rename include guard.
3640         * tui/tui-source.h: Rename include guard.
3641         * tui/tui-regs.h: Rename include guard.
3642         * tui/tui-out.h: Rename include guard.
3643         * tui/tui-layout.h: Rename include guard.
3644         * tui/tui-io.h: Rename include guard.
3645         * tui/tui-hooks.h: Rename include guard.
3646         * tui/tui-file.h: Rename include guard.
3647         * tui/tui-disasm.h: Rename include guard.
3648         * tui/tui-data.h: Rename include guard.
3649         * tui/tui-command.h: Rename include guard.
3650         * tic6x-tdep.h: Add include guard.
3651         * target/waitstatus.h: Rename include guard.
3652         * target/wait.h: Rename include guard.
3653         * target/target.h: Rename include guard.
3654         * target/resume.h: Rename include guard.
3655         * target-float.h: Rename include guard.
3656         * stabsread.h: Add include guard.
3657         * rs6000-tdep.h: Add include guard.
3658         * riscv-fbsd-tdep.h: Add include guard.
3659         * regformats/regdef.h: Rename include guard.
3660         * record.h: Rename include guard.
3661         * python/python.h: Rename include guard.
3662         * python/python-internal.h: Rename include guard.
3663         * python/py-stopevent.h: Rename include guard.
3664         * python/py-ref.h: Rename include guard.
3665         * python/py-record.h: Rename include guard.
3666         * python/py-record-full.h: Rename include guard.
3667         * python/py-record-btrace.h: Rename include guard.
3668         * python/py-instruction.h: Rename include guard.
3669         * python/py-events.h: Rename include guard.
3670         * python/py-event.h: Rename include guard.
3671         * procfs.h: Add include guard.
3672         * proc-utils.h: Add include guard.
3673         * p-lang.h: Add include guard.
3674         * or1k-tdep.h: Rename include guard.
3675         * observable.h: Rename include guard.
3676         * nto-tdep.h: Rename include guard.
3677         * nat/x86-linux.h: Rename include guard.
3678         * nat/x86-linux-dregs.h: Rename include guard.
3679         * nat/x86-gcc-cpuid.h: Add include guard.
3680         * nat/x86-dregs.h: Rename include guard.
3681         * nat/x86-cpuid.h: Rename include guard.
3682         * nat/ppc-linux.h: Rename include guard.
3683         * nat/mips-linux-watch.h: Rename include guard.
3684         * nat/linux-waitpid.h: Rename include guard.
3685         * nat/linux-ptrace.h: Rename include guard.
3686         * nat/linux-procfs.h: Rename include guard.
3687         * nat/linux-osdata.h: Rename include guard.
3688         * nat/linux-nat.h: Rename include guard.
3689         * nat/linux-namespaces.h: Rename include guard.
3690         * nat/linux-btrace.h: Rename include guard.
3691         * nat/glibc_thread_db.h: Rename include guard.
3692         * nat/gdb_thread_db.h: Rename include guard.
3693         * nat/gdb_ptrace.h: Rename include guard.
3694         * nat/fork-inferior.h: Rename include guard.
3695         * nat/amd64-linux-siginfo.h: Rename include guard.
3696         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
3697         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
3698         * nat/aarch64-linux.h: Rename include guard.
3699         * nat/aarch64-linux-hw-point.h: Rename include guard.
3700         * mn10300-tdep.h: Add include guard.
3701         * mips-linux-tdep.h: Add include guard.
3702         * mi/mi-parse.h: Rename include guard.
3703         * mi/mi-out.h: Rename include guard.
3704         * mi/mi-main.h: Rename include guard.
3705         * mi/mi-interp.h: Rename include guard.
3706         * mi/mi-getopt.h: Rename include guard.
3707         * mi/mi-console.h: Rename include guard.
3708         * mi/mi-common.h: Rename include guard.
3709         * mi/mi-cmds.h: Rename include guard.
3710         * mi/mi-cmd-break.h: Rename include guard.
3711         * m2-lang.h: Add include guard.
3712         * location.h: Rename include guard.
3713         * linux-record.h: Rename include guard.
3714         * linux-nat.h: Add include guard.
3715         * linux-fork.h: Add include guard.
3716         * i386-darwin-tdep.h: Rename include guard.
3717         * hppa-linux-offsets.h: Add include guard.
3718         * guile/guile.h: Rename include guard.
3719         * guile/guile-internal.h: Rename include guard.
3720         * gnu-nat.h: Rename include guard.
3721         * gdb-stabs.h: Rename include guard.
3722         * frv-tdep.h: Add include guard.
3723         * f-lang.h: Add include guard.
3724         * event-loop.h: Add include guard.
3725         * darwin-nat.h: Rename include guard.
3726         * cp-abi.h: Rename include guard.
3727         * config/sparc/nm-sol2.h: Rename include guard.
3728         * config/nm-nto.h: Rename include guard.
3729         * config/nm-linux.h: Add include guard.
3730         * config/i386/nm-i386gnu.h: Rename include guard.
3731         * config/djgpp/nl_types.h: Rename include guard.
3732         * config/djgpp/langinfo.h: Rename include guard.
3733         * compile/gcc-cp-plugin.h: Add include guard.
3734         * compile/gcc-c-plugin.h: Add include guard.
3735         * compile/compile.h: Rename include guard.
3736         * compile/compile-object-run.h: Rename include guard.
3737         * compile/compile-object-load.h: Rename include guard.
3738         * compile/compile-internal.h: Rename include guard.
3739         * compile/compile-cplus.h: Rename include guard.
3740         * compile/compile-c.h: Rename include guard.
3741         * common/xml-utils.h: Rename include guard.
3742         * common/x86-xstate.h: Rename include guard.
3743         * common/version.h: Rename include guard.
3744         * common/vec.h: Rename include guard.
3745         * common/tdesc.h: Rename include guard.
3746         * common/selftest.h: Rename include guard.
3747         * common/scoped_restore.h: Rename include guard.
3748         * common/scoped_mmap.h: Rename include guard.
3749         * common/scoped_fd.h: Rename include guard.
3750         * common/safe-iterator.h: Rename include guard.
3751         * common/run-time-clock.h: Rename include guard.
3752         * common/refcounted-object.h: Rename include guard.
3753         * common/queue.h: Rename include guard.
3754         * common/ptid.h: Rename include guard.
3755         * common/print-utils.h: Rename include guard.
3756         * common/preprocessor.h: Rename include guard.
3757         * common/pathstuff.h: Rename include guard.
3758         * common/observable.h: Rename include guard.
3759         * common/netstuff.h: Rename include guard.
3760         * common/job-control.h: Rename include guard.
3761         * common/host-defs.h: Rename include guard.
3762         * common/gdb_wait.h: Rename include guard.
3763         * common/gdb_vecs.h: Rename include guard.
3764         * common/gdb_unlinker.h: Rename include guard.
3765         * common/gdb_unique_ptr.h: Rename include guard.
3766         * common/gdb_tilde_expand.h: Rename include guard.
3767         * common/gdb_sys_time.h: Rename include guard.
3768         * common/gdb_string_view.h: Rename include guard.
3769         * common/gdb_splay_tree.h: Rename include guard.
3770         * common/gdb_setjmp.h: Rename include guard.
3771         * common/gdb_ref_ptr.h: Rename include guard.
3772         * common/gdb_optional.h: Rename include guard.
3773         * common/gdb_locale.h: Rename include guard.
3774         * common/gdb_assert.h: Rename include guard.
3775         * common/filtered-iterator.h: Rename include guard.
3776         * common/filestuff.h: Rename include guard.
3777         * common/fileio.h: Rename include guard.
3778         * common/environ.h: Rename include guard.
3779         * common/common-utils.h: Rename include guard.
3780         * common/common-types.h: Rename include guard.
3781         * common/common-regcache.h: Rename include guard.
3782         * common/common-inferior.h: Rename include guard.
3783         * common/common-gdbthread.h: Rename include guard.
3784         * common/common-exceptions.h: Rename include guard.
3785         * common/common-defs.h: Rename include guard.
3786         * common/common-debug.h: Rename include guard.
3787         * common/cleanups.h: Rename include guard.
3788         * common/buffer.h: Rename include guard.
3789         * common/btrace-common.h: Rename include guard.
3790         * common/break-common.h: Rename include guard.
3791         * cli/cli-utils.h: Rename include guard.
3792         * cli/cli-style.h: Rename include guard.
3793         * cli/cli-setshow.h: Rename include guard.
3794         * cli/cli-script.h: Rename include guard.
3795         * cli/cli-interp.h: Rename include guard.
3796         * cli/cli-decode.h: Rename include guard.
3797         * cli/cli-cmds.h: Rename include guard.
3798         * charset-list.h: Add include guard.
3799         * buildsym-legacy.h: Rename include guard.
3800         * bfin-tdep.h: Add include guard.
3801         * ax.h: Rename include guard.
3802         * arm-linux-tdep.h: Add include guard.
3803         * arm-fbsd-tdep.h: Add include guard.
3804         * arch/xtensa.h: Rename include guard.
3805         * arch/tic6x.h: Add include guard.
3806         * arch/i386.h: Add include guard.
3807         * arch/arm.h: Rename include guard.
3808         * arch/arm-linux.h: Rename include guard.
3809         * arch/arm-get-next-pcs.h: Rename include guard.
3810         * arch/amd64.h: Add include guard.
3811         * arch/aarch64-insn.h: Rename include guard.
3812         * arch-utils.h: Rename include guard.
3813         * annotate.h: Add include guard.
3814         * amd64-darwin-tdep.h: Rename include guard.
3815         * aarch64-linux-tdep.h: Add include guard.
3816         * aarch64-fbsd-tdep.h: Add include guard.
3817         * aarch32-linux-nat.h: Add include guard.
3818
3819 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3820
3821         * macrotab.c (macro_define_internal): New function that
3822         factorizes macro_define_object_internal and macro_define_function
3823         code.
3824         (macro_define_object_internal): Use macro_define_internal.
3825         (macro_define_function): Likewise.
3826
3827 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3828
3829         * macrocmd.c (extract_identifier): Return
3830         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
3831         callers.
3832
3833 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
3834
3835         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
3836
3837 2019-02-05  Tom Tromey  <tom@tromey.com>
3838
3839         * target.c (target_stack::unpush): Move assertion earlier.
3840
3841 2019-01-30  Tom Tromey  <tom@tromey.com>
3842
3843         PR python/23615:
3844         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
3845         (gdbpy_parse_and_eval): Likewise.
3846         * python/python-internal.h (gdbpy_allow_threads): New class.
3847
3848 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
3849
3850         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
3851         (aarch64_fbsd_fpregmap): Move earlier.
3852         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
3853         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3854         instead of individual calls to trad_frame_set_reg_addr.
3855         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
3856         earlier.
3857         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
3858         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3859         instead of individual calls to trad_frame_set_reg_addr.
3860
3861 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
3862
3863         * CONTRIBUTE: Replace contribution list with wiki link.
3864
3865 2019-01-25  Tom Tromey  <tom@tromey.com>
3866
3867         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
3868
3869 2019-01-25  Tom Tromey  <tom@tromey.com>
3870
3871         * xtensa-linux-nat.c: Fix common/ includes.
3872         * xml-support.h: Fix common/ includes.
3873         * xml-support.c: Fix common/ includes.
3874         * x86-linux-nat.c: Fix common/ includes.
3875         * windows-nat.c: Fix common/ includes.
3876         * varobj.h: Fix common/ includes.
3877         * varobj.c: Fix common/ includes.
3878         * value.c: Fix common/ includes.
3879         * valops.c: Fix common/ includes.
3880         * utils.c: Fix common/ includes.
3881         * unittests/xml-utils-selftests.c: Fix common/ includes.
3882         * unittests/utils-selftests.c: Fix common/ includes.
3883         * unittests/unpack-selftests.c: Fix common/ includes.
3884         * unittests/tracepoint-selftests.c: Fix common/ includes.
3885         * unittests/style-selftests.c: Fix common/ includes.
3886         * unittests/string_view-selftests.c: Fix common/ includes.
3887         * unittests/scoped_restore-selftests.c: Fix common/ includes.
3888         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
3889         * unittests/scoped_fd-selftests.c: Fix common/ includes.
3890         * unittests/rsp-low-selftests.c: Fix common/ includes.
3891         * unittests/parse-connection-spec-selftests.c: Fix common/
3892         includes.
3893         * unittests/optional-selftests.c: Fix common/ includes.
3894         * unittests/offset-type-selftests.c: Fix common/ includes.
3895         * unittests/observable-selftests.c: Fix common/ includes.
3896         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
3897         * unittests/memrange-selftests.c: Fix common/ includes.
3898         * unittests/memory-map-selftests.c: Fix common/ includes.
3899         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
3900         * unittests/function-view-selftests.c: Fix common/ includes.
3901         * unittests/environ-selftests.c: Fix common/ includes.
3902         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
3903         * unittests/common-utils-selftests.c: Fix common/ includes.
3904         * unittests/cli-utils-selftests.c: Fix common/ includes.
3905         * unittests/array-view-selftests.c: Fix common/ includes.
3906         * ui-file.c: Fix common/ includes.
3907         * tui/tui-io.c: Fix common/ includes.
3908         * tracepoint.h: Fix common/ includes.
3909         * tracepoint.c: Fix common/ includes.
3910         * tracefile-tfile.c: Fix common/ includes.
3911         * top.h: Fix common/ includes.
3912         * top.c: Fix common/ includes.
3913         * thread.c: Fix common/ includes.
3914         * target/waitstatus.h: Fix common/ includes.
3915         * target/waitstatus.c: Fix common/ includes.
3916         * target.h: Fix common/ includes.
3917         * target.c: Fix common/ includes.
3918         * target-memory.c: Fix common/ includes.
3919         * target-descriptions.c: Fix common/ includes.
3920         * symtab.h: Fix common/ includes.
3921         * symfile.c: Fix common/ includes.
3922         * stap-probe.c: Fix common/ includes.
3923         * spu-linux-nat.c: Fix common/ includes.
3924         * sparc-nat.c: Fix common/ includes.
3925         * source.c: Fix common/ includes.
3926         * solib.c: Fix common/ includes.
3927         * solib-target.c: Fix common/ includes.
3928         * ser-unix.c: Fix common/ includes.
3929         * ser-tcp.c: Fix common/ includes.
3930         * ser-pipe.c: Fix common/ includes.
3931         * ser-base.c: Fix common/ includes.
3932         * selftest-arch.c: Fix common/ includes.
3933         * s12z-tdep.c: Fix common/ includes.
3934         * rust-exp.y: Fix common/ includes.
3935         * rs6000-aix-tdep.c: Fix common/ includes.
3936         * riscv-tdep.c: Fix common/ includes.
3937         * remote.c: Fix common/ includes.
3938         * remote-notif.h: Fix common/ includes.
3939         * remote-fileio.h: Fix common/ includes.
3940         * remote-fileio.c: Fix common/ includes.
3941         * regcache.h: Fix common/ includes.
3942         * regcache.c: Fix common/ includes.
3943         * record-btrace.c: Fix common/ includes.
3944         * python/python.c: Fix common/ includes.
3945         * python/py-type.c: Fix common/ includes.
3946         * python/py-inferior.c: Fix common/ includes.
3947         * progspace.h: Fix common/ includes.
3948         * producer.c: Fix common/ includes.
3949         * procfs.c: Fix common/ includes.
3950         * proc-api.c: Fix common/ includes.
3951         * printcmd.c: Fix common/ includes.
3952         * ppc-linux-nat.c: Fix common/ includes.
3953         * parser-defs.h: Fix common/ includes.
3954         * osdata.c: Fix common/ includes.
3955         * obsd-nat.c: Fix common/ includes.
3956         * nat/x86-linux.c: Fix common/ includes.
3957         * nat/x86-linux-dregs.c: Fix common/ includes.
3958         * nat/x86-dregs.h: Fix common/ includes.
3959         * nat/x86-dregs.c: Fix common/ includes.
3960         * nat/ppc-linux.c: Fix common/ includes.
3961         * nat/mips-linux-watch.h: Fix common/ includes.
3962         * nat/mips-linux-watch.c: Fix common/ includes.
3963         * nat/linux-waitpid.c: Fix common/ includes.
3964         * nat/linux-ptrace.h: Fix common/ includes.
3965         * nat/linux-ptrace.c: Fix common/ includes.
3966         * nat/linux-procfs.c: Fix common/ includes.
3967         * nat/linux-personality.c: Fix common/ includes.
3968         * nat/linux-osdata.c: Fix common/ includes.
3969         * nat/linux-namespaces.c: Fix common/ includes.
3970         * nat/linux-btrace.h: Fix common/ includes.
3971         * nat/linux-btrace.c: Fix common/ includes.
3972         * nat/fork-inferior.c: Fix common/ includes.
3973         * nat/amd64-linux-siginfo.c: Fix common/ includes.
3974         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
3975         * nat/aarch64-linux.c: Fix common/ includes.
3976         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
3977         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
3978         * namespace.h: Fix common/ includes.
3979         * mips-linux-tdep.c: Fix common/ includes.
3980         * minsyms.c: Fix common/ includes.
3981         * mi/mi-parse.h: Fix common/ includes.
3982         * mi/mi-main.c: Fix common/ includes.
3983         * mi/mi-cmd-env.c: Fix common/ includes.
3984         * memrange.h: Fix common/ includes.
3985         * memattr.c: Fix common/ includes.
3986         * maint.h: Fix common/ includes.
3987         * maint.c: Fix common/ includes.
3988         * main.c: Fix common/ includes.
3989         * machoread.c: Fix common/ includes.
3990         * location.c: Fix common/ includes.
3991         * linux-thread-db.c: Fix common/ includes.
3992         * linux-nat.c: Fix common/ includes.
3993         * linux-fork.c: Fix common/ includes.
3994         * inline-frame.c: Fix common/ includes.
3995         * infrun.c: Fix common/ includes.
3996         * inflow.c: Fix common/ includes.
3997         * inferior.h: Fix common/ includes.
3998         * inferior.c: Fix common/ includes.
3999         * infcmd.c: Fix common/ includes.
4000         * inf-ptrace.c: Fix common/ includes.
4001         * inf-child.c: Fix common/ includes.
4002         * ia64-linux-nat.c: Fix common/ includes.
4003         * i387-tdep.c: Fix common/ includes.
4004         * i386-tdep.c: Fix common/ includes.
4005         * i386-linux-tdep.c: Fix common/ includes.
4006         * i386-linux-nat.c: Fix common/ includes.
4007         * i386-go32-tdep.c: Fix common/ includes.
4008         * i386-fbsd-tdep.c: Fix common/ includes.
4009         * i386-fbsd-nat.c: Fix common/ includes.
4010         * guile/scm-type.c: Fix common/ includes.
4011         * guile/guile.c: Fix common/ includes.
4012         * go32-nat.c: Fix common/ includes.
4013         * gnu-nat.c: Fix common/ includes.
4014         * gdbthread.h: Fix common/ includes.
4015         * gdbarch-selftests.c: Fix common/ includes.
4016         * gdb_usleep.c: Fix common/ includes.
4017         * gdb_select.h: Fix common/ includes.
4018         * gdb_bfd.c: Fix common/ includes.
4019         * gcore.c: Fix common/ includes.
4020         * fork-child.c: Fix common/ includes.
4021         * findvar.c: Fix common/ includes.
4022         * fbsd-nat.c: Fix common/ includes.
4023         * event-top.c: Fix common/ includes.
4024         * event-loop.c: Fix common/ includes.
4025         * dwarf2read.c: Fix common/ includes.
4026         * dwarf2loc.c: Fix common/ includes.
4027         * dwarf2-frame.c: Fix common/ includes.
4028         * dwarf-index-cache.c: Fix common/ includes.
4029         * dtrace-probe.c: Fix common/ includes.
4030         * disasm-selftests.c: Fix common/ includes.
4031         * defs.h: Fix common/ includes.
4032         * csky-tdep.c: Fix common/ includes.
4033         * cp-valprint.c: Fix common/ includes.
4034         * cp-support.h: Fix common/ includes.
4035         * cp-support.c: Fix common/ includes.
4036         * corelow.c: Fix common/ includes.
4037         * completer.h: Fix common/ includes.
4038         * completer.c: Fix common/ includes.
4039         * compile/compile.c: Fix common/ includes.
4040         * compile/compile-loc2c.c: Fix common/ includes.
4041         * compile/compile-cplus-types.c: Fix common/ includes.
4042         * compile/compile-cplus-symbols.c: Fix common/ includes.
4043         * command.h: Fix common/ includes.
4044         * cli/cli-dump.c: Fix common/ includes.
4045         * cli/cli-cmds.c: Fix common/ includes.
4046         * charset.c: Fix common/ includes.
4047         * build-id.c: Fix common/ includes.
4048         * btrace.h: Fix common/ includes.
4049         * btrace.c: Fix common/ includes.
4050         * breakpoint.h: Fix common/ includes.
4051         * breakpoint.c: Fix common/ includes.
4052         * ax.h: 
4053         (enum agent_op): Fix common/ includes.
4054         * ax-general.c (struct aop_map): Fix common/ includes.
4055         * ax-gdb.c: Fix common/ includes.
4056         * auxv.c: Fix common/ includes.
4057         * auto-load.c: Fix common/ includes.
4058         * arm-tdep.c: Fix common/ includes.
4059         * arch/riscv.c: Fix common/ includes.
4060         * arch/ppc-linux-common.c: Fix common/ includes.
4061         * arch/i386.c: Fix common/ includes.
4062         * arch/arm.c: Fix common/ includes.
4063         * arch/arm-linux.c: Fix common/ includes.
4064         * arch/arm-get-next-pcs.c: Fix common/ includes.
4065         * arch/amd64.c: Fix common/ includes.
4066         * arch/aarch64.c: Fix common/ includes.
4067         * arch/aarch64-insn.c: Fix common/ includes.
4068         * arch-utils.c: Fix common/ includes.
4069         * amd64-windows-tdep.c: Fix common/ includes.
4070         * amd64-tdep.c: Fix common/ includes.
4071         * amd64-sol2-tdep.c: Fix common/ includes.
4072         * amd64-obsd-tdep.c: Fix common/ includes.
4073         * amd64-nbsd-tdep.c: Fix common/ includes.
4074         * amd64-linux-tdep.c: Fix common/ includes.
4075         * amd64-linux-nat.c: Fix common/ includes.
4076         * amd64-fbsd-tdep.c: Fix common/ includes.
4077         * amd64-fbsd-nat.c: Fix common/ includes.
4078         * amd64-dicos-tdep.c: Fix common/ includes.
4079         * amd64-darwin-tdep.c: Fix common/ includes.
4080         * agent.c: Fix common/ includes.
4081         * ada-lang.h: Fix common/ includes.
4082         * ada-lang.c: Fix common/ includes.
4083         * aarch64-tdep.c: Fix common/ includes.
4084
4085 2019-01-25  Tom Tromey  <tom@tromey.com>
4086
4087         * common/create-version.sh: Use common/version.h.
4088
4089 2019-01-24  Pedro Alves  <palves@redhat.com>
4090
4091         * infrun.c (signal_stop, signal_print, signal_program)
4092         (signal_catch, signal_pass): Now arrays instead of pointers.
4093         (update_signals_program_target, do_target_resume)
4094         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
4095         * linux-nat.c (linux_nat_target::pass_signals)
4096         (linux_nat_target::create_inferior, linux_nat_target::attach):
4097         Adjust.
4098         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
4099         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
4100         * procfs.c (procfs_target::pass_signals): Adjust.
4101         * record-full.c (record_full_target::resume): Adjust.
4102         * remote.c (remote_target::pass_signals)
4103         (remote_target::program_signals): Adjust.
4104         * target-debug.h (target_debug_print_signals): Now takes a
4105         gdb::array_view as parameter.  Adjust.
4106         * target.h (target_ops) <pass_signals, program_signals>: Replace
4107         pointer and length parameters with gdb::array_view.
4108         (target_pass_signals, target_program_signals): Likewise.
4109         * target-delegates.c: Regenerate.
4110
4111 2019-01-24  Pedro Alves  <palves@redhat.com>
4112
4113         * common/forward-scope-exit.h
4114         (forward_scope_exit::forward_scope_exit): Pass arguments to
4115         m_bind_function directly, instead of creating a std::bind and
4116         copying that.
4117
4118 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
4119
4120         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4121         for static members.
4122         (pass_in_v_vfp_candidate): Likewise.
4123
4124 2019-01-23  Tom Tromey  <tom@tromey.com>
4125             Pedro Alves  <palves@redhat.com>
4126
4127         * regcache.c (class regcache_invalidator): Remove.
4128         (regcache::raw_write): Use make_scope_exit.
4129
4130 2019-01-23  Tom Tromey  <tom@tromey.com>
4131
4132         * ui-out.h (class ui_out_emit_type): Update comment.
4133
4134 2019-01-23  Tom Tromey  <tom@tromey.com>
4135
4136         * infrun.c (fetch_inferior_event): Update comment.
4137
4138 2019-01-23  Tom Tromey  <tom@tromey.com>
4139             Pedro Alves  <palves@redhat.com>
4140
4141         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
4142         parameter.
4143         (fetch_inferior_event): Use SCOPE_EXIT.
4144
4145
4146 2019-01-23  Tom Tromey  <tom@tromey.com>
4147             Pedro Alves  <palves@redhat.com>
4148
4149         * infrun.c (disable_thread_events): Delete.
4150         (stop_all_threads): Use SCOPE_EXIT.
4151
4152 2019-01-23  Tom Tromey  <tom@tromey.com>
4153             Pedro Alves  <palves@redhat.com>
4154
4155         * symfile.c: Include forward-scope-exit.h.
4156         (clear_symtab_users_cleanup): Replace forward declaration with
4157         a FORWARD_SCOPE_EXIT.
4158         (syms_from_objfile_1): Use the forward_scope_exit and
4159         gdb::optional instead of cleanup_function.
4160         (reread_symbols): Use the forward_scope_exit instead of
4161         cleanup_function.
4162         (clear_symtab_users_cleanup): Remove function.
4163
4164 2019-01-23  Tom Tromey  <tom@tromey.com>
4165             Pedro Alves  <palves@redhat.com>
4166
4167         * linux-nat.c: Include scope-exit.h.
4168         (cleanup_target_stop): Remove.
4169         (linux_nat_target::static_tracepoint_markers_by_strid): Use
4170         SCOPE_EXIT.
4171
4172 2019-01-23  Tom Tromey  <tom@tromey.com>
4173             Pedro Alves  <palves@redhat.com>
4174
4175         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
4176         (call_function_by_hand_dummy): Use SCOPE_EXIT.
4177
4178 2019-01-23  Tom Tromey  <tom@tromey.com>
4179             Andrew Burgess  <andrew.burgess@embecosm.com>
4180             Pedro Alves  <palves@redhat.com>
4181
4182         * infrun.c (fetch_inferior_event): Use scope_exit.
4183         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
4184         * top.c (execute_command): Use scope_exit.
4185         * breakpoint.c (bpstat_do_actions): Use scope_exit.
4186         * utils.c (do_bpstat_clear_actions_cleanup)
4187         (make_bpstat_clear_actions_cleanup): Remove.
4188
4189 2019-01-23  Tom Tromey  <tom@tromey.com>
4190             Pedro Alves  <palves@redhat.com>
4191
4192         * infrun.c: Include "common/scope-exit.h"
4193         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
4194         (wait_for_inferior): Use SCOPE_EXIT.
4195         (fetch_inferior_event): Use scope_exit.
4196
4197 2019-01-23  Tom Tromey  <tom@tromey.com>
4198             Pedro Alves  <palves@redhat.com>
4199
4200         * breakpoint.c (create_breakpoint): Remove cleanup.
4201
4202 2019-01-23  Tom Tromey  <tom@tromey.com>
4203             Andrew Burgess  <andrew.burgess@embecosm.com>
4204             Pedro Alves  <palves@redhat.com>
4205
4206 2019-01-23  Pedro Alves  <palves@redhat.com>
4207
4208         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
4209
4210 2019-01-23  Pedro Alves  <palves@redhat.com>
4211             Andrew Burgess  <andrew.burgess@embecosm.com>
4212
4213         * gdbthread.h: Include "common/forward-scope-exit.h".
4214         (scoped_finish_thread_state): Redefine custom class in terms of
4215         forward_scope_exit.
4216
4217 2019-01-23  Pedro Alves  <palves@redhat.com>
4218             Andrew Burgess  <andrew.burgess@embecosm.com>
4219
4220         * common/forward-scope-exit.h: New file.
4221
4222 2019-01-23  Pedro Alves  <palves@redhat.com>
4223             Andrew Burgess  <andrew.burgess@embecosm.com>
4224             Tom Tromey  <tom@tromey.com>
4225
4226         * common/scope-exit.h: New file.
4227
4228 2019-01-23  Pedro Alves  <palves@redhat.com>
4229
4230         * common/preprocessor.h (ESC): Rename to ...
4231         (ESC_PARENS): ... this.
4232         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
4233         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
4234
4235 2019-01-23  Tom Tromey  <tom@tromey.com>
4236
4237         * language.h (class scoped_switch_to_sym_language_if_auto):
4238         Initialize m_lang in both cases.
4239
4240 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
4241
4242         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
4243         with XCNEW.
4244
4245 2019-01-22  Tom Tromey  <tom@tromey.com>
4246
4247         * corelow.c: Do not include sys/file.h.
4248
4249 2019-01-22  Tom Tromey  <tom@tromey.com>
4250
4251         * tui/tui-wingeneral.h: Include gdb_curses.h.
4252
4253 2019-01-22  Tom Tromey  <tom@tromey.com>
4254
4255         * source-cache.h (class source_cache) <get_source_lines,
4256         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
4257
4258 2019-01-22  Tom Tromey  <tom@tromey.com>
4259
4260         * remote-fileio.h (struct remote_target): Declare.
4261
4262 2019-01-22  Tom Tromey  <tom@tromey.com>
4263
4264         * python/py-arch.c: Do not include py-ref.h.
4265         * python/py-bpevent.c: Do not include py-ref.h.
4266         * python/py-cmd.c: Do not include py-ref.h.
4267         * python/py-continueevent.c: Do not include py-ref.h.
4268         * python/py-event.h: Do not include py-ref.h.
4269         * python/py-evtregistry.c: Do not include py-ref.h.
4270         * python/py-finishbreakpoint.c: Do not include py-ref.h.
4271         * python/py-frame.c: Do not include py-ref.h.
4272         * python/py-framefilter.c: Do not include py-ref.h.
4273         * python/py-function.c: Do not include py-ref.h.
4274         * python/py-infevents.c: Do not include py-ref.h.
4275         * python/py-linetable.c: Do not include py-ref.h.
4276         * python/py-objfile.c: Do not include py-ref.h.
4277         * python/py-param.c: Do not include py-ref.h.
4278         * python/py-prettyprint.c: Do not include py-ref.h.
4279         * python/py-progspace.c: Do not include py-ref.h.
4280         * python/py-symbol.c: Do not include py-ref.h.
4281         * python/py-symtab.c: Do not include py-ref.h.
4282         * python/py-type.c: Do not include py-ref.h.
4283         * python/py-unwind.c: Do not include py-ref.h.
4284         * python/py-utils.c: Do not include py-ref.h.
4285         * python/py-value.c: Do not include py-ref.h.
4286         * python/py-varobj.c: Do not include py-ref.h.
4287         * python/py-xmethods.c: Do not include py-ref.h.
4288         * python/python.c: Do not include py-ref.h.
4289         * varobj.c: Do not include py-ref.h.
4290
4291 2019-01-22  Tom Tromey  <tom@tromey.com>
4292
4293         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
4294         keyword for bcache.
4295
4296 2019-01-22  Tom Tromey  <tom@tromey.com>
4297
4298         * compile/compile-cplus-types.c: Remove a comment by #include.
4299
4300 2019-01-22  Tom Tromey  <tom@tromey.com>
4301
4302         * compile/gcc-c-plugin.h: Include compile-internal.h.
4303
4304 2019-01-22  Tom Tromey  <tom@tromey.com>
4305
4306         * stabsread.c (EXTERN): Do not define.
4307         (symnum, next_symbol_text_func, processing_gcc_compilation)
4308         (within_function, global_sym_chain, global_stabs)
4309         (previous_stab_code, this_object_header_files)
4310         (n_this_object_header_files)
4311         (n_allocated_this_object_header_files): Define.
4312         * stabsread.h (EXTERN): Never define.  Use "extern".
4313
4314 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4315
4316         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
4317         history_value.
4318
4319 2019-01-21  Tom Tromey  <tom@tromey.com>
4320
4321         * ui-out.c: Fix includes.
4322         * tui/tui-source.c: Fix includes.
4323         * target.c: Fix includes.
4324         * remote.c: Fix includes.
4325         * regcache.c: Fix includes.
4326         * python/py-block.c: Fix includes.
4327         * printcmd.c: Fix includes.
4328         * or1k-tdep.c: Fix includes.
4329         * mi/mi-main.c: Fix includes.
4330         * m32r-tdep.c: Fix includes.
4331         * csky-tdep.c: Fix includes.
4332         * compile/compile-cplus-types.c: Fix includes.
4333         * cli/cli-interp.c: Fix includes.
4334
4335 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
4336
4337         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4338         for padding.
4339
4340 2019-01-16  Tom Tromey  <tom@tromey.com>
4341
4342         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
4343         earlier.
4344         (struct objfile) <msymbols_range>: Move from top level.
4345         <msymbols>: New method.
4346         (class objfile_msymbols): Remove.
4347         * symtab.c (default_collect_symbol_completion_matches_break_on):
4348         Update.
4349         * symmisc.c (dump_msymbols): Update.
4350         * stabsread.c (scan_file_globals): Update.
4351         * objc-lang.c (info_selectors_command, info_classes_command)
4352         (find_methods): Update.
4353         * minsyms.c (find_solib_trampoline_target): Update.
4354         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
4355         * coffread.c (coff_symfile_read): Update.
4356         * ada-lang.c (ada_lookup_simple_minsym)
4357         (ada_collect_symbol_completion_matches): Update.
4358
4359 2019-01-16  Tom Tromey  <tom@tromey.com>
4360
4361         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
4362         type.  Remove no-argument constructor.
4363         <iterator::operator++>: Simplify.
4364         <begin>: Update.
4365         <end>: Use minimal_symbol_count.
4366
4367 2019-01-16  Tom Tromey  <tom@tromey.com>
4368
4369         * objfiles.h (struct objfile) <psymtabs>: New method.
4370         (class objfile_psymtabs): Remove.
4371         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
4372         typedef.
4373         <range>: New method.
4374         (require_partial_symbols): Change return type.
4375         * psymtab.c (require_partial_symbols)
4376         (psym_expand_symtabs_matching): Update.
4377         * mdebugread.c (parse_partial_symbols): Update.
4378         * dbxread.c (dbx_end_psymtab): Update.
4379
4380 2019-01-15  Tom Tromey  <tom@tromey.com>
4381
4382         * symtab.c (lookup_objfile_from_block)
4383         (lookup_symbol_in_objfile_symtabs)
4384         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
4385         (find_line_symtab, info_sources_command)
4386         (default_collect_symbol_completion_matches_break_on)
4387         (make_source_files_completion_list): Update.
4388         * symmisc.c (print_objfile_statistics, dump_objfile)
4389         (maintenance_print_symbols, maintenance_info_symtabs)
4390         (maintenance_check_symtabs, maintenance_info_line_tables):
4391         Update.
4392         * source.c (select_source_symtab)
4393         (forget_cached_source_info_for_objfile): Update.
4394         * objfiles.h (class objfile_compunits): Remove.
4395         (struct objfile) <compunits_range>: New typedef.
4396         (compunits): New method.
4397         * objfiles.c (objfile_relocate1): Update.
4398         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4399         * maint.c (count_symtabs_and_blocks): Update.
4400         * linespec.c (iterate_over_all_matching_symtabs): Update.
4401         * cp-support.c (add_symbol_overload_list_qualified): Update.
4402         * coffread.c (coff_symtab_read): Update.
4403         * ada-lang.c (add_nonlocal_symbols)
4404         (ada_collect_symbol_completion_matches)
4405         (ada_add_global_exceptions): Update.
4406
4407 2019-01-15  Tom Tromey  <tom@tromey.com>
4408
4409         * progspace.h (program_space) <objfiles_safe_range>: New
4410         typedef.
4411         <objfiles_safe>: New method.
4412         * objfiles.h (class all_objfiles_safe): Remove.
4413         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
4414         * jit.c (jit_inferior_exit_hook): Update.
4415
4416 2019-01-17  Tom Tromey  <tom@tromey.com>
4417
4418         * progspace.h (program_space) <objfiles_range>: New typedef.
4419         <objfiles>: New method.
4420         <objfiles_head>: Rename from objfiles.
4421         (object_files): Update.
4422         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
4423         * guile/scm-pretty-print.c
4424         (ppscm_find_pretty_printer_from_objfiles): Update.
4425         * guile/scm-objfile.c (gdbscm_objfiles): Update.
4426         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
4427         Update.
4428         * python/py-progspace.c (pspy_get_objfiles): Update.
4429         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
4430         Update.
4431         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
4432         (objfpy_lookup_objfile_by_build_id): Update.
4433         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4434         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
4435         Update.
4436         * symtab.c (iterate_over_symtabs, matching_obj_sections)
4437         (expand_symtab_containing_pc, lookup_objfile_from_block)
4438         (lookup_static_symbol, basic_lookup_transparent_type)
4439         (find_pc_sect_compunit_symtab, find_symbol_at_address)
4440         (find_line_symtab, info_sources_command)
4441         (default_collect_symbol_completion_matches_break_on)
4442         (make_source_files_completion_list, find_main_name): Update.
4443         * symmisc.c (print_symbol_bcache_statistics)
4444         (print_objfile_statistics, maintenance_print_symbols)
4445         (maintenance_print_msymbols, maintenance_print_objfiles)
4446         (maintenance_info_symtabs, maintenance_check_symtabs)
4447         (maintenance_expand_symtabs, maintenance_info_line_tables):
4448         Update.
4449         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
4450         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
4451         (map_overlay_command, unmap_overlay_command)
4452         (simple_overlay_update, expand_symtabs_matching)
4453         (map_symbol_filenames): Update.
4454         * symfile-debug.c (set_debug_symfile): Update.
4455         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
4456         Update.
4457         * source.c (select_source_symtab, forget_cached_source_info):
4458         Update.
4459         * solib.c (solib_read_symbols): Update.
4460         * solib-spu.c (append_ocl_sos): Update.
4461         * psymtab.c (maintenance_print_psymbols)
4462         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
4463         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
4464         * printcmd.c (info_symbol_command): Update.
4465         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
4466         Update.
4467         * objfiles.h (class all_objfiles): Remove.
4468         * objfiles.c (have_partial_symbols, have_full_symbols)
4469         (have_minimal_symbols, qsort_cmp, update_section_map)
4470         (shared_objfile_contains_address_p)
4471         (default_iterate_over_objfiles_in_search_order): Update.
4472         * objc-lang.c (info_selectors_command, info_classes_command)
4473         (find_methods): Update.
4474         * minsyms.c (find_solib_trampoline_target): Update.
4475         * maint.c (maintenance_info_sections)
4476         (maintenance_translate_address, count_symtabs_and_blocks):
4477         Update.
4478         * main.c (captured_main_1): Update.
4479         * linux-thread-db.c (try_thread_db_load_from_pdir)
4480         (has_libpthread): Update.
4481         * linespec.c (iterate_over_all_matching_symtabs)
4482         (search_minsyms_for_name): Update.
4483         * jit.c (jit_find_objf_with_entry_addr): Update.
4484         * hppa-tdep.c (find_unwind_entry)
4485         (hppa_lookup_stub_minimal_symbol): Update.
4486         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
4487         Update.
4488         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
4489         (elf_gnu_ifunc_resolve_by_got): Update.
4490         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
4491         * dwarf-index-write.c (save_gdb_index_command): Update.
4492         * cp-support.c (add_symbol_overload_list_qualified): Update.
4493         * breakpoint.c (create_overlay_event_breakpoint)
4494         (create_longjmp_master_breakpoint)
4495         (create_std_terminate_master_breakpoint)
4496         (create_exception_master_breakpoint): Update.
4497         * blockframe.c (find_pc_partial_function): Update.
4498         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
4499         (ada_collect_symbol_completion_matches)
4500         (ada_add_global_exceptions): Update.
4501
4502 2019-01-17  Tom Tromey  <tom@tromey.com>
4503
4504         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
4505         declare VEC.
4506         (solib_target_parse_libraries): Change return type.
4507         (library_list_start_segment, library_list_start_section)
4508         (library_list_end_library, library_list_start_library); Update.
4509         (solib_target_free_library_list): Remove.
4510         (solib_target_parse_libraries): Remove cleanup.  Change return
4511         type.
4512         (solib_target_current_sos): Update.
4513
4514 2019-01-17  Tom Tromey  <tromey@bapiya>
4515
4516         * valprint.c: Replace "the the" with "the".
4517         * symtab.c: Replace "the the" with "the".
4518         * solib.c: Replace "the the" with "the".
4519         * solib-dsbt.c: Replace "the the" with "the".
4520         * linespec.c: Replace "the the" with "the".
4521         * dwarf2loc.h: Replace "the the" with "the".
4522         * amd64-windows-tdep.c: Replace "the the" with "the".
4523         * aarch64-tdep.c: Replace "the the" with "the".
4524
4525 2019-01-16  Keith Seitz  <keiths@redhat.com>
4526
4527         PR gdb/23773
4528         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
4529         <builder>: Rename to ..
4530         <m_builder>: ... this and make private.
4531         (dwarf2_cu::get_builder): New method.  Change all users of
4532         `builder' to use this method.
4533         (dwarf2_start_symtab): Move to ...
4534         (dwarf2_cu::start_symtab): ... here.  Update all callers
4535         (setup_type_unit_groups): Move to ...
4536         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
4537         callers.
4538         (dwarf2_cu::reset_builder): New method.
4539         (process_full_compunit, process_full_type_unit): Use
4540         dwarf2_cu::reset_builder.
4541         (follow_die_offset): Record the ancestor CU if it is different
4542         from the followed DIE's CU.
4543         (follow_die_sig_1): Likewise.
4544
4545 2019-01-15  Tom Tromey  <tom@tromey.com>
4546
4547         * remote.c (class remote_state) <buf>: Now a char_vector.
4548         <buf_size>: Remove.
4549         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
4550         parameter.
4551         (remote_target::getpkt_or_notif_sane_1)
4552         (remote_target::getpkt_sane)
4553         (remote_target::getpkt_or_notif_sane): Likewise.
4554         (class remote_target) <putpkt>: New overload.
4555         (remote_target::read_frame): Change type of "buf_p".  Remove
4556         sizeof_p parameter.
4557         (packet_ok): New overload.
4558         (packet_check_result): New overload.
4559         Update all uses.
4560
4561 2019-01-14  Tom Tromey  <tom@tromey.com>
4562
4563         * remote-notif.c (handle_notification, remote_notif_ack)
4564         (remote_notif_parse): Make "buf" const.
4565         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
4566         const.
4567         (remote_notif_parse, remote_notif_ack, handle_notification):
4568         Likewise.
4569         * remote.c (remote_notif_stop_parse): Make "buf" const.
4570         (remote_target::remote_parse_stop_reply): Make "buf" const.
4571         (remote_notif_stop_ack): Make "buf" const.
4572
4573 2019-01-14  Tom Tromey  <tom@tromey.com>
4574
4575         * remote.c (remote_console_output): Make parameter const.
4576
4577 2019-01-14  Tom Tromey  <tom@tromey.com>
4578
4579         * target-debug.h (target_debug_print_signals): Constify.
4580         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
4581         * procfs.c (procfs_target::pass_signals): Update.
4582         * linux-nat.c (linux_nat_target::pass_signals): Update.
4583         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
4584         * target-delegates.c: Rebuild.
4585         * remote.c (remote_target::program_signals): Update.
4586         (remote_target::pass_signals): Update.
4587         * target.c (target_pass_signals): Constify argument.
4588         (target_program_signals): Likewise.
4589         * target.h (struct target_ops) <pass_signals, program_signals>:
4590         Constify argument.
4591         (target_pass_signals, target_program_signals): Constify argument.
4592
4593 2019-01-14  Tom Tromey  <tom@tromey.com>
4594
4595         PR tui/28819:
4596         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
4597
4598 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
4599
4600         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
4601         field.
4602         * rs6000-tdep.c: Include reggroups.h.
4603         (IS_V_ALIAS_PSEUDOREG): Define.
4604         (rs6000_register_name): Return names for the "vX" aliases.
4605         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
4606         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
4607         aliases.  Call default_register_reggroup_p for all other
4608         pseudo-registers.
4609         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
4610         New functions.
4611         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
4612         Handle "vX" aliases.
4613         (v_alias_pseudo_register_collect): New function.
4614         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
4615         (rs6000_gdbarch_init): Initialize "vX" aliases as
4616         pseudo-registers.  Restore registration of
4617         rs6000_pseudo_register_reggroup_p with
4618         set_tdesc_pseudo_register_reggroup_p.
4619
4620 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
4621
4622         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
4623         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
4624         set_gdbarch_num_pseudo_regs.
4625
4626 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4627
4628         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
4629         Remove arg prefixname, add do_set and do_show.
4630         Add member functions set_list and show_list.
4631         * cli/cli-style.c (class cli_style_option): Update accordingly.
4632         (style_set_list): Move to file scope.
4633         (style_show_list): Likewise.
4634         (set_style): Call help_list.
4635         (show_style): Call cmd_show_list.
4636         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
4637         Update to use the new macro.
4638
4639 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
4640
4641         * ada-lang.c (_initialize_ada_language): Expand the help text
4642         for the "catch exception" command.
4643
4644 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4645
4646         * symtab.c (matching_obj_sections): Initialize obj,
4647         declare it closer to its usage.
4648
4649 2019-01-10  Tom Tromey  <tom@tromey.com>
4650
4651         * thread-iter.h (inf_threads_iterator): Use next_iterator.
4652         (basic_inf_threads_range): Remove.
4653         (inf_threads_range, inf_non_exited_threads_range)
4654         (safe_inf_threads_range): Use next_adapter.
4655
4656 2019-01-10  Keith Seitz  <keiths@redhat.com>
4657
4658         PR gdb/23712
4659         PR symtab/23010
4660         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
4661         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
4662
4663 2019-01-10  Keith Seitz  <keiths@redhat.com>
4664
4665         PR gdb/23712
4666         PR symtab/23010
4667         * dictionary.c (pending_to_vector): Remove.
4668         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4669         Remove _1 suffix, replacing functions of the same name.  Update
4670         all callers.
4671         (dict_create_hashed, dict_create_hashed_expandable)
4672         (dict_create_linear, dict_create_linear_expandable, dict_free)
4673         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
4674         Make functions static.
4675
4676 2019-01-10  Keith Seitz  <keiths@redhat.com>
4677
4678         PR gdb/23712
4679         PR symtab/23010
4680         * dictionary.h (struct dictionary): Replace declaration with
4681         multidictionary.
4682         (dict_create_hashed, dict_create_hashed_expandable)
4683         (dict_create_linear, dict_create_linear_expandable)
4684         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
4685         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
4686         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
4687         taking multidictionary argument.
4688         [ALL_DICT_SYMBOLS]: Update for multidictionary.
4689         * block.h (struct block) <dict>: Change to multidictionary
4690         and rename `multidict'.
4691         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
4692         symmisc.c: Update all dictionary references to multidictionary.
4693
4694 2019-01-10  Keith Seitz  <keiths@redhat.com>
4695
4696         PR gdb/23712
4697         PR symtab/23010
4698         * dictionary.c: Include unordered_map.
4699         (pending_to_vector): New function.
4700         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4701         Rewrite the non-"_1" functions to take vector instead
4702         of linked list.
4703         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
4704         "new" _1 versions of the same name.
4705         (multidictionary): Define.
4706         (std::hash<enum language): New definition.
4707         (collate_pending_symbols_by_language, mdict_create_hashed)
4708         (mdict_create_hashed_expandable, mdict_create_linear)
4709         (mdict_create_linear_expandable, mdict_free)
4710         (find_language_dictionary, create_new_language_dictionary)
4711         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
4712         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
4713         (mdict_size, mdict_empty): New functions.
4714         * dictionary.h (mdict_iterator): Define.
4715
4716 2019-01-10  Pedro Alves  <palves@redhat.com>
4717
4718         * breakpoint.c (read_uploaded_action)
4719         (create_tracepoint_from_upload): Adjust to use
4720         gdb::unique_xmalloc_ptr.
4721         * ctf.c (ctf_write_uploaded_tp):
4722         (SET_ARRAY_FIELD): Use emplace_back.
4723         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
4724         * tracefile-tfile.c (tfile_write_uploaded_tp):
4725         * tracepoint.c (parse_tracepoint_definition): Adjust to use
4726         gdb::unique_xmalloc_ptr.
4727         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
4728         at_string, cond_string, cmd_strings>: Replace char pointers
4729         with gdb::unique_xmalloc_ptr.
4730
4731 2019-01-10  Pedro Alves  <palves@redhat.com>
4732
4733         * solib-target.c (library_list_start_library): Don't xstrdup name.
4734
4735 2019-01-10  Pedro Alves  <palves@redhat.com>
4736
4737         * mdebugread.c (parse_partial_symbols): Use
4738         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
4739
4740 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4741
4742         * linux-fork.c (scoped_switch_fork_info)
4743         <~scoped_switch_fork_info>: Fix incorrect variable name.
4744
4745 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4746
4747         * linux-fork.c (scoped_switch_fork_info)
4748         <scoped_switch_fork_info>: Make explicit.
4749         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
4750
4751 2019-01-10  Tom Tromey  <tom@tromey.com>
4752
4753         * objfiles.h (objfile::reset_psymtabs): Update.
4754         * objfiles.c (objfile::objfile): Update.
4755         * psymtab.h (psymtab_storage::obstack): Update.
4756         (psymtab_storage::m_obstack): Use gdb::optional.
4757         (class psymtab_storage): Update comment.  Remove objfile
4758         parameter.
4759         * psymtab.c (psymtab_storage::psymtab_storage): Update.
4760
4761 2019-01-10  Tom Tromey  <tom@tromey.com>
4762
4763         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
4764         <free_psymtabs>: Now private.
4765         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
4766         (allocate_psymtab): Use new method.
4767
4768 2019-01-10  Tom Tromey  <tom@tromey.com>
4769
4770         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
4771         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
4772         * mdebugread.c (parse_partial_symbols): Use
4773         allocate_dependencies.
4774         * dwarf2read.c (dwarf2_create_include_psymtab): Use
4775         allocate_dependencies.
4776         (process_psymtab_comp_unit_reader)
4777         (build_type_psymtab_dependencies): Likewise.
4778         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
4779
4780 2019-01-10  Tom Tromey  <tom@tromey.com>
4781
4782         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
4783         PSYMBOL_SET_LANGUAGE.
4784         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
4785
4786 2019-01-10  Tom Tromey  <tom@tromey.com>
4787
4788         * psymtab.h (psymtab_storage::obstack): New method.
4789         <m_obstack>: Rename from obstack; now private.
4790         * psymtab.c (psymtab_storage): Update.
4791         * dwarf2read.c (create_addrmap_from_index)
4792         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
4793         Update.
4794
4795 2019-01-10  Tom Tromey  <tom@tromey.com>
4796
4797         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
4798         * objfiles.h (objfile::reset_psymtabs): New method.
4799
4800 2019-01-10  Tom Tromey  <tom@tromey.com>
4801
4802         * symmisc.c (print_symbol_bcache_statistics): Update.
4803         (print_objfile_statistics): Update.
4804         * symfile.c (reread_symbols): Update.
4805         * psymtab.h (class psymtab_storage): New.
4806         * psymtab.c (psymtab_storage): New constructor.
4807         (~psymtab_storage): New destructor.
4808         (require_partial_symbols): Update.
4809         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
4810         (find_pc_sect_psymtab, find_pc_sect_psymbol)
4811         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
4812         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
4813         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
4814         (start_psymtab_common, end_psymtab_common)
4815         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
4816         (allocate_psymtab): Update.
4817         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
4818         Update.
4819         (dump_psymtab_addrmap, maintenance_print_psymbols)
4820         (maintenance_check_psymtabs): Update.
4821         (class objfile_psymtabs): Move to objfiles.h.
4822         * psympriv.h (discard_psymtab): Now inline.
4823         (psymtab_discarder::psymtab_discarder): Update.
4824         (psymtab_discarder::~psymtab_discarder): Update.
4825         (ALL_OBJFILE_PSYMTABS): Rewrite.
4826         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
4827         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
4828         Remove fields.
4829         <partial_symtabs>: New field.
4830         (class objfile_psymtabs): Move from psymtab.h.  Update.
4831         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
4832         psymbol_cache.
4833         (objfile::~objfile): Don't destroy psymbol_cache.
4834         * mdebugread.c (parse_partial_symbols): Update.
4835         * dwarf2read.c (create_addrmap_from_index)
4836         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
4837         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
4838         (add_partial_subprogram, dwarf2_ranges_read): Update.
4839         * dwarf-index-write.c (write_address_map)
4840         (write_one_signatured_type, recursively_write_psymbols)
4841         (class debug_names, class debug_names, write_psymtabs_to_index):
4842         Update.
4843
4844 2019-01-10  Tom Tromey  <tom@tromey.com>
4845
4846         * symtab.h (SYMBOL_SET_NAMES): Update.
4847         (symbol_set_names): Update.
4848         (MSYMBOL_SET_NAMES): Update.
4849         * symtab.c (symbol_set_names): Change argument to be an
4850         objfile_per_bfd_storage.
4851         * psymtab.c (add_psymbol_to_bcache): Update.
4852         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
4853
4854 2019-01-10  Tom Tromey  <tom@tromey.com>
4855
4856         * symtab.c (create_demangled_names_hash): Change argument to be an
4857         objfile_per_bfd_storage.
4858         (symbol_set_names): Update.
4859
4860 2019-01-10  Tom Tromey  <tom@tromey.com>
4861
4862         * xcoffread.c (xcoff_initial_scan): Unconditionally call
4863         init_psymbol_list.
4864         * psymtab.c (init_psymbol_list): Do nothing if already called.
4865         * psympriv.h (init_psymbol_list): Add comment.
4866         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
4867         init_psymbol_list.
4868         * dbxread.c (dbx_symfile_read): Unconditionally call
4869         init_psymbol_list.
4870
4871 2019-01-10  Tom Tromey  <tom@tromey.com>
4872
4873         * xcoffread.c (scan_xcoff_symtab): Update.
4874         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
4875         "where".
4876         * mdebugread.c (parse_partial_symbols)
4877         (handle_psymbol_enumerators): Update.
4878         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
4879         * dbxread.c (read_dbx_symtab): Update.
4880         * psympriv.h (psymbol_placement): New enum.
4881         (add_psymbol_to_list): Update.
4882
4883 2019-01-10  Tom Tromey  <tom@tromey.com>
4884
4885         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
4886         static_psymbols parameters.
4887         (scan_xcoff_symtab): Update.
4888         * psymtab.c (start_psymtab_common): Remove global_psymbols and
4889         static_psymbols parameters.
4890         * psympriv.h (start_psymtab_common): Update.
4891         * mdebugread.c (parse_partial_symbols): Update.
4892         * dwarf2read.c (create_partial_symtab): Update.
4893         * dbxread.c (read_dbx_symtab): Update.
4894         (start_psymtab): Remove global_psymbols and static_psymbols
4895         parameters.
4896
4897 2019-01-10  Tom Tromey  <tom@tromey.com>
4898
4899         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
4900         * psymtab.c (allocate_psymtab): Add comment.
4901         * psympriv.h (allocate_psymtab): Add comment.
4902         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
4903         initializations.
4904         * dbxread.c (dbx_end_psymtab): Remove some initializations.
4905
4906 2019-01-10  Tom Tromey  <tom@tromey.com>
4907
4908         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
4909         Don't declare.
4910         * mipsread.c: Include mdebugread.h.
4911         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
4912         Declare.
4913         * elfread.c: Include mdebugread.h.
4914
4915 2019-01-09  Tom Tromey  <tom@tromey.com>
4916
4917         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
4918         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
4919         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
4920         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
4921         (psym_lookup_symbol, psym_find_last_source_symtab)
4922         (psym_forget_cached_source_info, psym_print_stats)
4923         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
4924         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
4925         (psym_map_matching_symbols, psym_expand_symtabs_matching)
4926         (psym_find_compunit_symtab_by_address)
4927         (maintenance_print_psymbols, maintenance_info_psymtabs)
4928         (maintenance_check_psymtabs): Use ranged for.
4929         * psymtab.h (class objfile_psymtabs): New.
4930         (require_partial_symbols): Return objfile_psymtabs.
4931         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
4932
4933 2019-01-09  Tom Tromey  <tom@tromey.com>
4934
4935         * symfile.c (overlay_invalidate_all, find_pc_overlay)
4936         (find_pc_mapped_section, list_overlays_command)
4937         (map_overlay_command, unmap_overlay_command)
4938         (simple_overlay_update): Use all_objfiles.
4939         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
4940         * printcmd.c (info_symbol_command): Use all_objfiles.
4941         * objfiles.h (ALL_OBJSECTIONS): Remove.
4942         * maint.c (maintenance_translate_address): Use all_objfiles.
4943         * gcore.c (gcore_create_callback): Use all_objfiles.
4944         (objfile_find_memory_regions): Likewise.
4945
4946 2019-01-09  Tom Tromey  <tom@tromey.com>
4947
4948         * symtab.c (find_line_symtab, info_sources_command)
4949         (make_source_files_completion_list): Use objfile_compunits.
4950         * source.c (select_source_symtab): Use objfile_compunits.
4951         * objfiles.h (struct objfile): Update comment.
4952         (ALL_OBJFILES): Remove.
4953         (ALL_FILETABS): Remove.
4954         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
4955         objfile_compunits.
4956
4957 2019-01-09  Tom Tromey  <tom@tromey.com>
4958
4959         * symmisc.c (print_objfile_statistics, dump_objfile)
4960         (maintenance_print_symbols): Use compunit_filetabs.
4961         * source.c (forget_cached_source_info_for_objfile): Use
4962         compunit_filetabs.
4963         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
4964         (ALL_FILETABS): Use compunit_filetabs.
4965         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
4966         * coffread.c (coff_symtab_read): Use compunit_filetabs.
4967
4968 2019-01-09  Tom Tromey  <tom@tromey.com>
4969
4970         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
4971         (compunit_filetabs): New.
4972         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
4973         compunit_filetabs.
4974         (info_sources_command, make_source_files_completion_list): Remove
4975         declaration.
4976         * symmisc.c (print_objfile_statistics, dump_objfile)
4977         (maintenance_print_symbols): Remove declaration.
4978         (maintenance_info_symtabs): Use compunit_filetabs.
4979         (maintenance_info_line_tables): Likewise.
4980         * source.c (select_source_symtab): Change local variable name.
4981         (forget_cached_source_info_for_objfile): Remove declaration.
4982         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
4983         * objfiles.c (objfile_relocate1): Remove declaration.
4984         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
4985         declaration.
4986         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
4987         * coffread.c (coff_symtab_read): Remove declaration.
4988         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
4989         compunit_filetabs.
4990
4991 2019-01-09  Tom Tromey  <tom@tromey.com>
4992
4993         * symtab.c (lookup_objfile_from_block)
4994         (find_pc_sect_compunit_symtab, search_symbols)
4995         (default_collect_symbol_completion_matches_break_on): Use
4996         objfile_compunits.
4997         * objfiles.h (ALL_COMPUNITS): Remove.
4998         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
4999         * cp-support.c (add_symbol_overload_list_qualified): Use
5000         objfile_compunits.
5001         * ada-lang.c (ada_collect_symbol_completion_matches)
5002         (ada_add_global_exceptions): Use objfile_compunits.
5003
5004 2019-01-09  Tom Tromey  <tom@tromey.com>
5005
5006         * source.c (select_source_symtab)
5007         (forget_cached_source_info_for_objfile): Remove declaration.
5008         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5009         declaration.
5010         * maint.c (count_symtabs_and_blocks): Remove declaration.
5011         * cp-support.c (add_symbol_overload_list_qualified): Remove
5012         declaration.
5013         * coffread.c (coff_symtab_read): Remove declaration.
5014         * symtab.c (lookup_symbol_in_objfile_symtabs)
5015         (basic_lookup_transparent_type_1): Use objfile_compunits.
5016         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
5017         (info_sources_command, search_symbols)
5018         (default_collect_symbol_completion_matches_break_on)
5019         (make_source_files_completion_list): Remove declaration.
5020         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
5021         (ada_collect_symbol_completion_matches)
5022         (ada_add_global_exceptions): Remove declaration.
5023         * linespec.c (iterate_over_all_matching_symtabs): Use
5024         objfile_compunits.
5025         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
5026         (class objfile_compunits): New.
5027         (ALL_COMPUNITS): Use objfile_compunits.
5028         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
5029         (maintenance_check_symtabs, maintenance_info_line_tables): Use
5030         objfile_compunits.
5031         * objfiles.c (objfile_relocate1): Use objfile_compunits.
5032
5033 2019-01-09  Tom Tromey  <tom@tromey.com>
5034
5035         * symtab.c (search_symbols)
5036         (default_collect_symbol_completion_matches_break_on): Use
5037         objfile_msymbols.
5038         * ada-lang.c (ada_lookup_simple_minsym)
5039         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
5040         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
5041         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
5042         objfile_msymbols.
5043         * coffread.c (coff_symfile_read): Use objfile_msymbols.
5044         * symmisc.c (dump_msymbols): Use objfile_msymbols.
5045         * objc-lang.c (find_methods): Use objfile_msymbols.
5046         (info_selectors_command, info_classes_command): Likewise.
5047         * stabsread.c (scan_file_globals): Use objfile_msymbols.
5048         * objfiles.h (class objfile_msymbols): New.
5049         (ALL_OBJFILE_MSYMBOLS): Remove.
5050         (ALL_MSYMBOLS): Remove.
5051
5052 2019-01-09  Tom Tromey  <tom@tromey.com>
5053
5054         * common/next-iterator.h (next_adapter): Add Iterator template
5055         parameter.
5056         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
5057         (class all_objfiles_safe): New.
5058         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
5059         * objfiles.c (put_objfile_before): Update comment.
5060         (add_separate_debug_objfile): Likewise.
5061         (free_all_objfiles): Use all_objfiles_safe.
5062         (objfile_purge_solibs): Likewise.
5063
5064 2019-01-09  Tom Tromey  <tom@tromey.com>
5065
5066         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5067         (expand_symtab_containing_pc, lookup_static_symbol)
5068         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
5069         (find_symbol_at_address, find_line_symtab, find_main_name): Use
5070         all_objfiles.
5071         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
5072         * breakpoint.c (create_overlay_event_breakpoint)
5073         (create_longjmp_master_breakpoint)
5074         (create_std_terminate_master_breakpoint)
5075         (create_exception_master_breakpoint): Use all_objfiles.
5076         * linux-thread-db.c (try_thread_db_load_from_pdir)
5077         (has_libpthread): Use all_objfiles.
5078         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
5079         * linespec.c (iterate_over_all_matching_symtabs)
5080         (search_minsyms_for_name): Use all_objfiles.
5081         * maint.c (maintenance_info_sections): Use all_objfiles.
5082         * main.c (captured_main_1): Use all_objfiles.
5083         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
5084         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
5085         * guile/scm-pretty-print.c
5086         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
5087         * solib-spu.c (append_ocl_sos): Use all_objfiles.
5088         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
5089         (maintenance_print_msymbols): Use all_objfiles.
5090         * source.c (select_source_symtab): Use all_objfiles.
5091         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
5092         * symfile.c (remove_symbol_file_command)
5093         (expand_symtabs_matching, map_symbol_filenames): Use
5094         all_objfiles.
5095         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
5096         all_objfiles.
5097         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
5098         * objc-lang.c (find_methods): Use all_objfiles.
5099         * objfiles.c (have_partial_symbols, have_full_symbols)
5100         (have_minimal_symbols, qsort_cmp)
5101         (default_iterate_over_objfiles_in_search_order): Use
5102         all_objfiles.
5103         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
5104         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
5105         (maintenance_check_psymtabs): Use all_objfiles.
5106         (ALL_PSYMTABS): Remove.
5107         * compile/compile-object-run.c (do_module_cleanup): Use
5108         all_objfiles.
5109         * blockframe.c (find_pc_partial_function): Use all_objfiles.
5110         * cp-support.c (add_symbol_overload_list_qualified): Use
5111         all_objfiles.
5112         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5113         Use all_objfiles.
5114         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
5115         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
5116         all_objfiles.
5117         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5118         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
5119         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5120         Uses all_objfiles.
5121         * solib.c (solib_read_symbols): Use all_objfiles
5122
5123 2019-01-09  Tom Tromey  <tom@tromey.com>
5124
5125         * probe.c (parse_probes_in_pspace): Use all_objfiles.
5126         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
5127         all_objfiles.
5128         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
5129         * symmisc.c (print_symbol_bcache_statistics)
5130         (print_objfile_statistics, maintenance_print_objfiles)
5131         (maintenance_info_symtabs, maintenance_check_symtabs)
5132         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
5133         all_objfiles.
5134         * source.c (forget_cached_source_info): Use all_objfiles.
5135         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
5136         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5137         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
5138         * objfiles.c (update_section_map): Use all_objfiles.
5139         (shared_objfile_contains_address_p): Likewise.
5140         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
5141         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
5142
5143 2019-01-09  Tom Tromey  <tom@tromey.com>
5144
5145         * common/next-iterator.h: New file.
5146         * objfiles.h (class all_objfiles): New.
5147         (struct objfile_iterator): New.
5148
5149 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5150
5151         * NEWS: Move the description of the changed "frame", "select-frame",
5152          and "info frame" commands to the Changed commands section.
5153
5154 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
5155
5156         * gdbtypes.c (check_stub_method_group): Remove handling of old
5157         mangling schemes.
5158         * linespec.c (find_methods): Likewise.
5159         * stabsread.c (read_member_functions): Likewise.
5160         * valops.c (search_struct_method): Likewise.
5161         (value_struct_elt_for_reference): Likewise.
5162         * NEWS: Mention this change.
5163
5164 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5165
5166         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
5167         print_source_lines.
5168         * source.c (print_source_lines_base): Update line number check.
5169         (print_source_lines): New function.
5170         (source_lines_range::source_lines_range): New function.
5171         * source.h (class source_lines_range): New class.
5172         (print_source_lines): New declaration.
5173
5174 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5175
5176         * linespec.c (linespec_state_destructor): Free self->canonical_names.
5177
5178 2019-01-08  Tom Tromey  <tom@tromey.com>
5179             Simon Marchi  <simon.marchi@ericsson.com>
5180
5181         PR gdb/24060
5182         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
5183         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
5184         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5185         * f-exp.y (DOLLAR_VARIABLE): Likewise.
5186         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
5187         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5188
5189 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5190
5191         * source.c (select_source_symtab): Move header comment to
5192         declaration in source.h.
5193         (forget_cached_source_info_for_objfile): Likewise.
5194         (forget_cached_source_info): Likewise.
5195         (identify_source_line): Likewise.
5196         * source.h (identify_source_line): Move declaration from symtab.h
5197         and add comment from source.c
5198         (print_source_lines): Likewise.
5199         (forget_cached_source_info_for_objfile): Likewise.
5200         (forget_cached_source_info): Likewise.
5201         (select_source_symtab): Likewise.
5202         (enum print_source_lines_flag): Move definition from symtab.h.
5203         * symtab.h (identify_source_line): Move declaration to source.h.
5204         (print_source_lines): Likewise.
5205         (forget_cached_source_info_for_objfile): Likewise.
5206         (forget_cached_source_info): Likewise.
5207         (select_source_symtab): Likewise.
5208         (enum print_source_lines_flag): Move definition to source.h.
5209         * tui/tui-hooks.c: Add 'source.h' include.
5210
5211 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5212
5213         * source.c (print_source_lines_base): Handle requests to print
5214         reverse line number sequences, and guard against empty lines
5215         string.
5216
5217 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5218
5219         * source.c (print_source_lines_base): Fix skip of '\r' if next
5220         character is '\n'.
5221
5222 2019-01-06  Tom Tromey  <tom@tromey.com>
5223
5224         * c-exp.y (struct c_parse_state) <macro_original_text,
5225         expansion_obstack>: New member.
5226         (macro_original_text, expansion_obstack): Remove globals.
5227         (scan_macro_expansion, scanning_macro_expansion)
5228         (finished_macro_expansion): Update.
5229         (scan_macro_cleanup): Remove.
5230         (yylex, c_parse): Update.
5231
5232 2019-01-06  Tom Tromey  <tom@tromey.com>
5233
5234         * c-exp.y (struct c_parse_state) <strings>: New member.
5235         (operator_stoken): Update.
5236
5237 2019-01-06  Tom Tromey  <tom@tromey.com>
5238
5239         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
5240         (union type_stack_elt) <typelist_val>: Now a pointer to
5241         std::vector.
5242         (type_stack_cleanup): Don't declare.
5243         (push_typelist): Update.
5244         * parse.c (pop_typelist): Return a std::vector.
5245         (push_typelist): Take a std::vector.
5246         (follow_types): Update.  Do not free args.
5247         (type_stack_cleanup): Remove.
5248         * c-exp.y (struct c_parse_state): New.
5249         (cpstate): New global.
5250         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
5251         (nonempty_typelist): Update.
5252         (func_mod): Create a new vector.
5253         (c_parse): Create a c_parse_state.
5254         (check_parameter_typelist): Do not delete params.
5255         (function_method): Update.  Do not delete type_list.
5256
5257 2019-01-06  Tom Tromey  <tom@tromey.com>
5258
5259         PR gdb/28155:
5260         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
5261         check_typedef.
5262         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
5263         (print_return_value): Likewise.
5264
5265 2019-01-05  Tom Tromey  <tom@tromey.com>
5266
5267         * contrib/cleanup_check.py: Remove.
5268         * contrib/gcc-with-excheck: Remove.
5269         * contrib/exsummary.py: Remove.
5270         * contrib/excheck.py: Remove.
5271
5272 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
5273
5274         * thread.c (delete_thread_1): Add gdb_assert that THR is not
5275         NULL. Initialize tpprev to NULL instead of assigning it
5276         to NULL on the next statement.
5277         * windows-nat.c (windows_delete_thread): Remove check for
5278         main_thread_id before printing thread exit notifications.
5279         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
5280         Remove thread ID check against main_thread_id.
5281         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
5282         windows_delete_thread.
5283         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
5284
5285 2019-01-04  Tom Tromey  <tom@tromey.com>
5286
5287         * compile/compile.c (_initialize_compile): Use upper case for
5288         metasyntactic variables.
5289         * symmisc.c (_initialize_symmisc): Use upper case for
5290         metasyntactic variables.
5291         * psymtab.c (_initialize_psymtab): Use upper case for
5292         metasyntactic variables.
5293         * demangle.c (demangle_command): Use upper case for metasyntactic
5294         variables.
5295         (_initialize_demangler): Likewise.
5296         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
5297         variables.
5298
5299 2019-01-03  Tom Tromey  <tom@tromey.com>
5300
5301         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
5302
5303 2019-01-03  Tom Tromey  <tom@tromey.com>
5304
5305         * python/py-symtab.c (salpy_str): Update.
5306         (struct salpy_sal_object) <symtab>: Now a PyObject.
5307         (salpy_dealloc): Update.
5308         (del_objfile_sal): Use gdbpy_ref.
5309
5310 2019-01-03  Tom Tromey  <tom@tromey.com>
5311
5312         * python/py-type.c (convert_field): Use new_reference.  Return
5313         gdbpy_ref.
5314         (make_fielditem): Return gdbpy_ref.
5315         (typy_fields): Update.
5316         (typy_getitem): Update.
5317         (field_name): Return gdbpy_ref.  Use new_reference.
5318         (typy_iterator_iternext): Update.
5319
5320 2019-01-03  Tom Tromey  <tom@tromey.com>
5321
5322         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
5323
5324 2019-01-03  Tom Tromey  <tom@tromey.com>
5325
5326         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
5327         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
5328         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
5329         (pspy_set_frame_filters, pspy_set_frame_unwinders)
5330         (pspy_set_type_printers): Likewise.
5331         * python/py-function.c (fnpy_init): Use gdbpy_ref.
5332         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
5333         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
5334         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
5335         (objfpy_set_type_printers): Likewise.
5336
5337 2019-01-03  Tom Tromey  <tom@tromey.com>
5338
5339         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
5340         (gdbpy_print_stack): Use gdbpy_err_fetch.
5341         * python/python-internal.h (class gdbpy_err_fetch): New class.
5342         (class gdbpy_enter) <m_error_type, m_error_value,
5343         m_error_traceback>: Remove.
5344         <m_error>: New member.
5345         (gdbpy_exception_to_string): Don't declare.
5346         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
5347         * python/py-value.c (convert_value_from_python): Use
5348         gdbpy_err_fetch.
5349         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
5350         gdbpy_exception_to_string.
5351         (gdbpy_handle_exception): Use gdbpy_err_fetch.
5352         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
5353         gdbpy_err_fetch.
5354
5355 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5356
5357         * linux-nat.c (delete_lwp_cleanup): Delete.
5358         (struct lwp_deleter): New struct.
5359         (lwp_info_up): New typedef.
5360         (linux_nat_target::follow_fork): Delete cleanup, and make use of
5361         lwp_info_up.
5362
5363 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5364
5365         * linux-fork.c (class scoped_switch_fork_info): New class.
5366         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
5367
5368 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5369
5370         * valops.c (find_overload_match): Remove use of null_cleanup, and
5371         calls to do_cleanups.
5372
5373 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5374
5375         * compile/compile-cplus-types.c
5376         (compile_cplus_instance::decl_name): Handle changes to
5377         cp_func_name.
5378         * cp-support.c (cp_func_name): Update header comment, update
5379         return type.
5380         * cp-support.h (cp_func_name): Update return type in declaration.
5381         * valops.c (find_overload_match): Move temp_func local to top
5382         level of function and change its type.  Use temp_func to hold and
5383         delete temporary string obtained from cp_func_name.
5384
5385 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5386
5387         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
5388         gdb::char_vector, remove cleanup, and update uses of `msg`.
5389
5390 2019-01-03  Jim Wilson  <jimw@sifive.com>
5391
5392         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
5393
5394 2019-01-02  Tom Tromey  <tom@tromey.com>
5395
5396         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
5397         (tdesc_parse_xml): Remove cleanups.
5398         * target-descriptions.h (make_cleanup_free_target_description):
5399         Don't declare.
5400         (target_desc_deleter): New struct.
5401         (target_desc_up): New typedef.
5402         * target-descriptions.c (target_desc_deleter::operator()): Rename
5403         from free_target_description.
5404         (make_cleanup_free_target_description): Remove.
5405
5406 2019-01-02  Tom Tromey  <tom@tromey.com>
5407
5408         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
5409         constructor, destructor.
5410         (linespec_parser): Remove typedef.
5411         (~linespec_parser): Rename from linespec_parser_delete.
5412         (linespec_lex_to_end, linespec_complete_label)
5413         (linespec_complete): Update.
5414         (decode_line_full): Remove cleanups.
5415         (decode_line_1): Update.
5416
5417 2019-01-02  Tom Tromey  <tom@tromey.com>
5418
5419         * python/python-internal.h (inferior_to_inferior_object): Change
5420         return type.
5421         * python/py-exitedevent.c (create_exited_event_object): Update.
5422         * python/py-inferior.c (inferior_to_inferior_object): Return
5423         gdbpy_ref.
5424         (python_new_inferior, python_inferior_deleted)
5425         (thread_to_thread_object, delete_thread_object)
5426         (build_inferior_list, gdbpy_selected_inferior): Update.
5427         * python/py-infthread.c (create_thread_object): Update.  Also fail
5428         if inferior_to_inferior_object fails.
5429
5430 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
5431
5432         * inferior.h (class inferior) <displaced_step_state>: New field.
5433         * infrun.h (struct displaced_step_state): Move here from
5434         infrun.c.  Initialize fields, add constructor.
5435         <inf>: Remove field.
5436         <reset>: New method.
5437         * infrun.c (struct displaced_step_inferior_state): Move to
5438         infrun.h.
5439         (displaced_step_inferior_states): Remove.
5440         (get_displaced_stepping_state): Adust.
5441         (displaced_step_in_progress_any_inferior): Adjust.
5442         (displaced_step_in_progress_thread): Adjust.
5443         (displaced_step_in_progress): Adjust.
5444         (add_displaced_stepping_state): Remove.
5445         (get_displaced_step_closure_by_addr): Adjust.
5446         (remove_displaced_stepping_state): Remove.
5447         (infrun_inferior_exit): Call displaced_step_state.reset.
5448         (use_displaced_stepping): Don't check for NULL.
5449         (displaced_step_prepare_throw): Call
5450         get_displaced_stepping_state.
5451         (displaced_step_fixup): Don't check for NULL.
5452         (prepare_for_detach): Don't check for NULL.
5453
5454 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5455
5456         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
5457          in case of call that did not complete.
5458
5459 2019-01-02  Andrey Utkin  <autkin@undo.io>
5460
5461         * symfile.c (find_separate_debug_file): Fix search of debug files for
5462         remote debuggee.
5463
5464 2019-01-02  Tom Tromey  <tom@tromey.com>
5465
5466         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
5467         indentation.
5468         * python/py-frame.c (frapy_older): Remove cast.
5469         (frapy_newer): Likewise.
5470         * python/py-breakpoint.c (local_setattro): Remove cast.
5471         * python/py-arch.c (archpy_name): Remove local variable.
5472         * python/py-type.c (gdbpy_lookup_type): Remove cast.
5473
5474 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
5475
5476         * unittests/basic_string_view/element_access/char/empty.cc:
5477         Fix year range in copyright header.
5478
5479 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5480
5481         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
5482         Delete.
5483         <operator==>: Update with for removed field.
5484         <hash>: Likewise.
5485         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
5486         <isa_features>: ...this.
5487         <abi_features>: New field.
5488         (riscv_isa_flen): Update comment.
5489         (riscv_abi_xlen): New declaration.
5490         (riscv_abi_flen): New declaration.
5491         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
5492         isa_features.
5493         (riscv_abi_xlen): New function.
5494         (riscv_isa_flen): Update to get answer from isa_features.
5495         (riscv_abi_flen): New function.
5496         (riscv_has_fp_abi): Update to get answer from abi_features.
5497         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
5498         xlen and flen.
5499         (riscv_call_info) <xlen, flen>: Update comment.
5500         (riscv_call_arg_struct): Remove invalid assertions
5501         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
5502         is removed.
5503         (riscv_gdbarch_init): Gather isa features and abi features
5504         separately, ensure both match on the gdbarch when reusing an old
5505         gdbarch.  Relax an error check to allow 32-bit abi float to run on
5506         a target with 64-bit float hardware.
5507
5508 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5509
5510         * source.c (search_command_helper): Stop reverse search
5511         when line 1 has been searched.
5512
5513 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5514
5515         * record-full.c (record_full_base_target::close): Rewrite
5516         record_full_core_buf_list free logic.
5517
5518 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5519
5520         * break-catch-syscall.c (print_one_catch_syscall): xfree
5521         the last text.
5522
5523 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5524
5525         * top.c (print_gdb_version): Update Copyright year in version
5526         message.
5527
5528 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5529
5530         Update copyright year range in all GDB files.
5531
5532 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
5533
5534         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
5535
5536 For older changes see ChangeLog-2018.
5537 \f
5538 Local Variables:
5539 mode: change-log
5540 left-margin: 8
5541 fill-column: 74
5542 version-control: never
5543 coding: utf-8
5544 End:
5545