gdb/ChangeLog

   1 2019-01-23  Tom Tromey  <tom@tromey.com>
   2
   3         * infrun.c (fetch_inferior_event): Update comment.
   4
   5 2019-01-23  Tom Tromey  <tom@tromey.com>
   6             Pedro Alves  <palves@redhat.com>
   7
   8         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
   9         parameter.
  10         (fetch_inferior_event): Use SCOPE_EXIT.
  11
  12
  13 2019-01-23  Tom Tromey  <tom@tromey.com>
  14             Pedro Alves  <palves@redhat.com>
  15
  16         * infrun.c (disable_thread_events): Delete.
  17         (stop_all_threads): Use SCOPE_EXIT.
  18
  19 2019-01-23  Tom Tromey  <tom@tromey.com>
  20             Pedro Alves  <palves@redhat.com>
  21
  22         * symfile.c: Include forward-scope-exit.h.
  23         (clear_symtab_users_cleanup): Replace forward declaration with
  24         a FORWARD_SCOPE_EXIT.
  25         (syms_from_objfile_1): Use the forward_scope_exit and
  26         gdb::optional instead of cleanup_function.
  27         (reread_symbols): Use the forward_scope_exit instead of
  28         cleanup_function.
  29         (clear_symtab_users_cleanup): Remove function.
  30
  31 2019-01-23  Tom Tromey  <tom@tromey.com>
  32             Pedro Alves  <palves@redhat.com>
  33
  34         * linux-nat.c: Include scope-exit.h.
  35         (cleanup_target_stop): Remove.
  36         (linux_nat_target::static_tracepoint_markers_by_strid): Use
  37         SCOPE_EXIT.
  38
  39 2019-01-23  Tom Tromey  <tom@tromey.com>
  40             Pedro Alves  <palves@redhat.com>
  41
  42         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
  43         (call_function_by_hand_dummy): Use SCOPE_EXIT.
  44
  45 2019-01-23  Tom Tromey  <tom@tromey.com>
  46             Andrew Burgess  <andrew.burgess@embecosm.com>
  47             Pedro Alves  <palves@redhat.com>
  48
  49         * infrun.c (fetch_inferior_event): Use scope_exit.
  50         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
  51         * top.c (execute_command): Use scope_exit.
  52         * breakpoint.c (bpstat_do_actions): Use scope_exit.
  53         * utils.c (do_bpstat_clear_actions_cleanup)
  54         (make_bpstat_clear_actions_cleanup): Remove.
  55
  56 2019-01-23  Tom Tromey  <tom@tromey.com>
  57             Pedro Alves  <palves@redhat.com>
  58
  59         * infrun.c: Include "common/scope-exit.h"
  60         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
  61         (wait_for_inferior): Use SCOPE_EXIT.
  62         (fetch_inferior_event): Use scope_exit.
  63
  64 2019-01-23  Tom Tromey  <tom@tromey.com>
  65             Pedro Alves  <palves@redhat.com>
  66
  67         * breakpoint.c (create_breakpoint): Remove cleanup.
  68
  69 2019-01-23  Tom Tromey  <tom@tromey.com>
  70             Andrew Burgess  <andrew.burgess@embecosm.com>
  71             Pedro Alves  <palves@redhat.com>
  72
  73 2019-01-23  Pedro Alves  <palves@redhat.com>
  74
  75         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
  76
  77 2019-01-23  Pedro Alves  <palves@redhat.com>
  78             Andrew Burgess  <andrew.burgess@embecosm.com>
  79
  80         * gdbthread.h: Include "common/forward-scope-exit.h".
  81         (scoped_finish_thread_state): Redefine custom class in terms of
  82         forward_scope_exit.
  83
  84 2019-01-23  Pedro Alves  <palves@redhat.com>
  85             Andrew Burgess  <andrew.burgess@embecosm.com>
  86
  87         * common/forward-scope-exit.h: New file.
  88
  89 2019-01-23  Pedro Alves  <palves@redhat.com>
  90             Andrew Burgess  <andrew.burgess@embecosm.com>
  91             Tom Tromey  <tom@tromey.com>
  92
  93         * common/scope-exit.h: New file.
  94
  95 2019-01-23  Pedro Alves  <palves@redhat.com>
  96
  97         * common/preprocessor.h (ESC): Rename to ...
  98         (ESC_PARENS): ... this.
  99         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
 100         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
 101
 102 2019-01-23  Tom Tromey  <tom@tromey.com>
 103
 104         * language.h (class scoped_switch_to_sym_language_if_auto):
 105         Initialize m_lang in both cases.
 106
 107 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
 108
 109         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
 110         with XCNEW.
 111
 112 2019-01-22  Tom Tromey  <tom@tromey.com>
 113
 114         * corelow.c: Do not include sys/file.h.
 115
 116 2019-01-22  Tom Tromey  <tom@tromey.com>
 117
 118         * tui/tui-wingeneral.h: Include gdb_curses.h.
 119
 120 2019-01-22  Tom Tromey  <tom@tromey.com>
 121
 122         * source-cache.h (class source_cache) <get_source_lines,
 123         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
 124
 125 2019-01-22  Tom Tromey  <tom@tromey.com>
 126
 127         * remote-fileio.h (struct remote_target): Declare.
 128
 129 2019-01-22  Tom Tromey  <tom@tromey.com>
 130
 131         * python/py-arch.c: Do not include py-ref.h.
 132         * python/py-bpevent.c: Do not include py-ref.h.
 133         * python/py-cmd.c: Do not include py-ref.h.
 134         * python/py-continueevent.c: Do not include py-ref.h.
 135         * python/py-event.h: Do not include py-ref.h.
 136         * python/py-evtregistry.c: Do not include py-ref.h.
 137         * python/py-finishbreakpoint.c: Do not include py-ref.h.
 138         * python/py-frame.c: Do not include py-ref.h.
 139         * python/py-framefilter.c: Do not include py-ref.h.
 140         * python/py-function.c: Do not include py-ref.h.
 141         * python/py-infevents.c: Do not include py-ref.h.
 142         * python/py-linetable.c: Do not include py-ref.h.
 143         * python/py-objfile.c: Do not include py-ref.h.
 144         * python/py-param.c: Do not include py-ref.h.
 145         * python/py-prettyprint.c: Do not include py-ref.h.
 146         * python/py-progspace.c: Do not include py-ref.h.
 147         * python/py-symbol.c: Do not include py-ref.h.
 148         * python/py-symtab.c: Do not include py-ref.h.
 149         * python/py-type.c: Do not include py-ref.h.
 150         * python/py-unwind.c: Do not include py-ref.h.
 151         * python/py-utils.c: Do not include py-ref.h.
 152         * python/py-value.c: Do not include py-ref.h.
 153         * python/py-varobj.c: Do not include py-ref.h.
 154         * python/py-xmethods.c: Do not include py-ref.h.
 155         * python/python.c: Do not include py-ref.h.
 156         * varobj.c: Do not include py-ref.h.
 157
 158 2019-01-22  Tom Tromey  <tom@tromey.com>
 159
 160         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
 161         keyword for bcache.
 162
 163 2019-01-22  Tom Tromey  <tom@tromey.com>
 164
 165         * compile/compile-cplus-types.c: Remove a comment by #include.
 166
 167 2019-01-22  Tom Tromey  <tom@tromey.com>
 168
 169         * compile/gcc-c-plugin.h: Include compile-internal.h.
 170
 171 2019-01-22  Tom Tromey  <tom@tromey.com>
 172
 173         * stabsread.c (EXTERN): Do not define.
 174         (symnum, next_symbol_text_func, processing_gcc_compilation)
 175         (within_function, global_sym_chain, global_stabs)
 176         (previous_stab_code, this_object_header_files)
 177         (n_this_object_header_files)
 178         (n_allocated_this_object_header_files): Define.
 179         * stabsread.h (EXTERN): Never define.  Use "extern".
 180
 181 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 182
 183         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
 184         history_value.
 185
 186 2019-01-21  Tom Tromey  <tom@tromey.com>
 187
 188         * ui-out.c: Fix includes.
 189         * tui/tui-source.c: Fix includes.
 190         * target.c: Fix includes.
 191         * remote.c: Fix includes.
 192         * regcache.c: Fix includes.
 193         * python/py-block.c: Fix includes.
 194         * printcmd.c: Fix includes.
 195         * or1k-tdep.c: Fix includes.
 196         * mi/mi-main.c: Fix includes.
 197         * m32r-tdep.c: Fix includes.
 198         * csky-tdep.c: Fix includes.
 199         * compile/compile-cplus-types.c: Fix includes.
 200         * cli/cli-interp.c: Fix includes.
 201
 202 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
 203
 204         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 205         for padding.
 206
 207 2019-01-16  Tom Tromey  <tom@tromey.com>
 208
 209         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
 210         earlier.
 211         (struct objfile) <msymbols_range>: Move from top level.
 212         <msymbols>: New method.
 213         (class objfile_msymbols): Remove.
 214         * symtab.c (default_collect_symbol_completion_matches_break_on):
 215         Update.
 216         * symmisc.c (dump_msymbols): Update.
 217         * stabsread.c (scan_file_globals): Update.
 218         * objc-lang.c (info_selectors_command, info_classes_command)
 219         (find_methods): Update.
 220         * minsyms.c (find_solib_trampoline_target): Update.
 221         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
 222         * coffread.c (coff_symfile_read): Update.
 223         * ada-lang.c (ada_lookup_simple_minsym)
 224         (ada_collect_symbol_completion_matches): Update.
 225
 226 2019-01-16  Tom Tromey  <tom@tromey.com>
 227
 228         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
 229         type.  Remove no-argument constructor.
 230         <iterator::operator++>: Simplify.
 231         <begin>: Update.
 232         <end>: Use minimal_symbol_count.
 233
 234 2019-01-16  Tom Tromey  <tom@tromey.com>
 235
 236         * objfiles.h (struct objfile) <psymtabs>: New method.
 237         (class objfile_psymtabs): Remove.
 238         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
 239         typedef.
 240         <range>: New method.
 241         (require_partial_symbols): Change return type.
 242         * psymtab.c (require_partial_symbols)
 243         (psym_expand_symtabs_matching): Update.
 244         * mdebugread.c (parse_partial_symbols): Update.
 245         * dbxread.c (dbx_end_psymtab): Update.
 246
 247 2019-01-15  Tom Tromey  <tom@tromey.com>
 248
 249         * symtab.c (lookup_objfile_from_block)
 250         (lookup_symbol_in_objfile_symtabs)
 251         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
 252         (find_line_symtab, info_sources_command)
 253         (default_collect_symbol_completion_matches_break_on)
 254         (make_source_files_completion_list): Update.
 255         * symmisc.c (print_objfile_statistics, dump_objfile)
 256         (maintenance_print_symbols, maintenance_info_symtabs)
 257         (maintenance_check_symtabs, maintenance_info_line_tables):
 258         Update.
 259         * source.c (select_source_symtab)
 260         (forget_cached_source_info_for_objfile): Update.
 261         * objfiles.h (class objfile_compunits): Remove.
 262         (struct objfile) <compunits_range>: New typedef.
 263         (compunits): New method.
 264         * objfiles.c (objfile_relocate1): Update.
 265         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
 266         * maint.c (count_symtabs_and_blocks): Update.
 267         * linespec.c (iterate_over_all_matching_symtabs): Update.
 268         * cp-support.c (add_symbol_overload_list_qualified): Update.
 269         * coffread.c (coff_symtab_read): Update.
 270         * ada-lang.c (add_nonlocal_symbols)
 271         (ada_collect_symbol_completion_matches)
 272         (ada_add_global_exceptions): Update.
 273
 274 2019-01-15  Tom Tromey  <tom@tromey.com>
 275
 276         * progspace.h (program_space) <objfiles_safe_range>: New
 277         typedef.
 278         <objfiles_safe>: New method.
 279         * objfiles.h (class all_objfiles_safe): Remove.
 280         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
 281         * jit.c (jit_inferior_exit_hook): Update.
 282
 283 2019-01-17  Tom Tromey  <tom@tromey.com>
 284
 285         * progspace.h (program_space) <objfiles_range>: New typedef.
 286         <objfiles>: New method.
 287         <objfiles_head>: Rename from objfiles.
 288         (object_files): Update.
 289         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
 290         * guile/scm-pretty-print.c
 291         (ppscm_find_pretty_printer_from_objfiles): Update.
 292         * guile/scm-objfile.c (gdbscm_objfiles): Update.
 293         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
 294         Update.
 295         * python/py-progspace.c (pspy_get_objfiles): Update.
 296         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
 297         Update.
 298         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
 299         (objfpy_lookup_objfile_by_build_id): Update.
 300         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
 301         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
 302         Update.
 303         * symtab.c (iterate_over_symtabs, matching_obj_sections)
 304         (expand_symtab_containing_pc, lookup_objfile_from_block)
 305         (lookup_static_symbol, basic_lookup_transparent_type)
 306         (find_pc_sect_compunit_symtab, find_symbol_at_address)
 307         (find_line_symtab, info_sources_command)
 308         (default_collect_symbol_completion_matches_break_on)
 309         (make_source_files_completion_list, find_main_name): Update.
 310         * symmisc.c (print_symbol_bcache_statistics)
 311         (print_objfile_statistics, maintenance_print_symbols)
 312         (maintenance_print_msymbols, maintenance_print_objfiles)
 313         (maintenance_info_symtabs, maintenance_check_symtabs)
 314         (maintenance_expand_symtabs, maintenance_info_line_tables):
 315         Update.
 316         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
 317         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
 318         (map_overlay_command, unmap_overlay_command)
 319         (simple_overlay_update, expand_symtabs_matching)
 320         (map_symbol_filenames): Update.
 321         * symfile-debug.c (set_debug_symfile): Update.
 322         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
 323         Update.
 324         * source.c (select_source_symtab, forget_cached_source_info):
 325         Update.
 326         * solib.c (solib_read_symbols): Update.
 327         * solib-spu.c (append_ocl_sos): Update.
 328         * psymtab.c (maintenance_print_psymbols)
 329         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
 330         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
 331         * printcmd.c (info_symbol_command): Update.
 332         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
 333         Update.
 334         * objfiles.h (class all_objfiles): Remove.
 335         * objfiles.c (have_partial_symbols, have_full_symbols)
 336         (have_minimal_symbols, qsort_cmp, update_section_map)
 337         (shared_objfile_contains_address_p)
 338         (default_iterate_over_objfiles_in_search_order): Update.
 339         * objc-lang.c (info_selectors_command, info_classes_command)
 340         (find_methods): Update.
 341         * minsyms.c (find_solib_trampoline_target): Update.
 342         * maint.c (maintenance_info_sections)
 343         (maintenance_translate_address, count_symtabs_and_blocks):
 344         Update.
 345         * main.c (captured_main_1): Update.
 346         * linux-thread-db.c (try_thread_db_load_from_pdir)
 347         (has_libpthread): Update.
 348         * linespec.c (iterate_over_all_matching_symtabs)
 349         (search_minsyms_for_name): Update.
 350         * jit.c (jit_find_objf_with_entry_addr): Update.
 351         * hppa-tdep.c (find_unwind_entry)
 352         (hppa_lookup_stub_minimal_symbol): Update.
 353         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
 354         Update.
 355         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
 356         (elf_gnu_ifunc_resolve_by_got): Update.
 357         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
 358         * dwarf-index-write.c (save_gdb_index_command): Update.
 359         * cp-support.c (add_symbol_overload_list_qualified): Update.
 360         * breakpoint.c (create_overlay_event_breakpoint)
 361         (create_longjmp_master_breakpoint)
 362         (create_std_terminate_master_breakpoint)
 363         (create_exception_master_breakpoint): Update.
 364         * blockframe.c (find_pc_partial_function): Update.
 365         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
 366         (ada_collect_symbol_completion_matches)
 367         (ada_add_global_exceptions): Update.
 368
 369 2019-01-17  Tom Tromey  <tom@tromey.com>
 370
 371         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
 372         declare VEC.
 373         (solib_target_parse_libraries): Change return type.
 374         (library_list_start_segment, library_list_start_section)
 375         (library_list_end_library, library_list_start_library); Update.
 376         (solib_target_free_library_list): Remove.
 377         (solib_target_parse_libraries): Remove cleanup.  Change return
 378         type.
 379         (solib_target_current_sos): Update.
 380
 381 2019-01-17  Tom Tromey  <tromey@bapiya>
 382
 383         * valprint.c: Replace "the the" with "the".
 384         * symtab.c: Replace "the the" with "the".
 385         * solib.c: Replace "the the" with "the".
 386         * solib-dsbt.c: Replace "the the" with "the".
 387         * linespec.c: Replace "the the" with "the".
 388         * dwarf2loc.h: Replace "the the" with "the".
 389         * amd64-windows-tdep.c: Replace "the the" with "the".
 390         * aarch64-tdep.c: Replace "the the" with "the".
 391
 392 2019-01-16  Keith Seitz  <keiths@redhat.com>
 393
 394         PR gdb/23773
 395         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
 396         <builder>: Rename to ..
 397         <m_builder>: ... this and make private.
 398         (dwarf2_cu::get_builder): New method.  Change all users of
 399         `builder' to use this method.
 400         (dwarf2_start_symtab): Move to ...
 401         (dwarf2_cu::start_symtab): ... here.  Update all callers
 402         (setup_type_unit_groups): Move to ...
 403         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
 404         callers.
 405         (dwarf2_cu::reset_builder): New method.
 406         (process_full_compunit, process_full_type_unit): Use
 407         dwarf2_cu::reset_builder.
 408         (follow_die_offset): Record the ancestor CU if it is different
 409         from the followed DIE's CU.
 410         (follow_die_sig_1): Likewise.
 411
 412 2019-01-15  Tom Tromey  <tom@tromey.com>
 413
 414         * remote.c (class remote_state) <buf>: Now a char_vector.
 415         <buf_size>: Remove.
 416         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
 417         parameter.
 418         (remote_target::getpkt_or_notif_sane_1)
 419         (remote_target::getpkt_sane)
 420         (remote_target::getpkt_or_notif_sane): Likewise.
 421         (class remote_target) <putpkt>: New overload.
 422         (remote_target::read_frame): Change type of "buf_p".  Remove
 423         sizeof_p parameter.
 424         (packet_ok): New overload.
 425         (packet_check_result): New overload.
 426         Update all uses.
 427
 428 2019-01-14  Tom Tromey  <tom@tromey.com>
 429
 430         * remote-notif.c (handle_notification, remote_notif_ack)
 431         (remote_notif_parse): Make "buf" const.
 432         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
 433         const.
 434         (remote_notif_parse, remote_notif_ack, handle_notification):
 435         Likewise.
 436         * remote.c (remote_notif_stop_parse): Make "buf" const.
 437         (remote_target::remote_parse_stop_reply): Make "buf" const.
 438         (remote_notif_stop_ack): Make "buf" const.
 439
 440 2019-01-14  Tom Tromey  <tom@tromey.com>
 441
 442         * remote.c (remote_console_output): Make parameter const.
 443
 444 2019-01-14  Tom Tromey  <tom@tromey.com>
 445
 446         * target-debug.h (target_debug_print_signals): Constify.
 447         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
 448         * procfs.c (procfs_target::pass_signals): Update.
 449         * linux-nat.c (linux_nat_target::pass_signals): Update.
 450         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
 451         * target-delegates.c: Rebuild.
 452         * remote.c (remote_target::program_signals): Update.
 453         (remote_target::pass_signals): Update.
 454         * target.c (target_pass_signals): Constify argument.
 455         (target_program_signals): Likewise.
 456         * target.h (struct target_ops) <pass_signals, program_signals>:
 457         Constify argument.
 458         (target_pass_signals, target_program_signals): Constify argument.
 459
 460 2019-01-14  Tom Tromey  <tom@tromey.com>
 461
 462         PR tui/28819:
 463         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
 464
 465 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 466
 467         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
 468         field.
 469         * rs6000-tdep.c: Include reggroups.h.
 470         (IS_V_ALIAS_PSEUDOREG): Define.
 471         (rs6000_register_name): Return names for the "vX" aliases.
 472         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
 473         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
 474         aliases.  Call default_register_reggroup_p for all other
 475         pseudo-registers.
 476         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
 477         New functions.
 478         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
 479         Handle "vX" aliases.
 480         (v_alias_pseudo_register_collect): New function.
 481         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
 482         (rs6000_gdbarch_init): Initialize "vX" aliases as
 483         pseudo-registers.  Restore registration of
 484         rs6000_pseudo_register_reggroup_p with
 485         set_tdesc_pseudo_register_reggroup_p.
 486
 487 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
 488
 489         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
 490         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
 491         set_gdbarch_num_pseudo_regs.
 492
 493 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 494
 495         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
 496         Remove arg prefixname, add do_set and do_show.
 497         Add member functions set_list and show_list.
 498         * cli/cli-style.c (class cli_style_option): Update accordingly.
 499         (style_set_list): Move to file scope.
 500         (style_show_list): Likewise.
 501         (set_style): Call help_list.
 502         (show_style): Call cmd_show_list.
 503         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
 504         Update to use the new macro.
 505
 506 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
 507
 508         * ada-lang.c (_initialize_ada_language): Expand the help text
 509         for the "catch exception" command.
 510
 511 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 512
 513         * symtab.c (matching_obj_sections): Initialize obj,
 514         declare it closer to its usage.
 515
 516 2019-01-10  Tom Tromey  <tom@tromey.com>
 517
 518         * thread-iter.h (inf_threads_iterator): Use next_iterator.
 519         (basic_inf_threads_range): Remove.
 520         (inf_threads_range, inf_non_exited_threads_range)
 521         (safe_inf_threads_range): Use next_adapter.
 522
 523 2019-01-10  Keith Seitz  <keiths@redhat.com>
 524
 525         PR gdb/23712
 526         PR symtab/23010
 527         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
 528         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
 529
 530 2019-01-10  Keith Seitz  <keiths@redhat.com>
 531
 532         PR gdb/23712
 533         PR symtab/23010
 534         * dictionary.c (pending_to_vector): Remove.
 535         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 536         Remove _1 suffix, replacing functions of the same name.  Update
 537         all callers.
 538         (dict_create_hashed, dict_create_hashed_expandable)
 539         (dict_create_linear, dict_create_linear_expandable, dict_free)
 540         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
 541         Make functions static.
 542
 543 2019-01-10  Keith Seitz  <keiths@redhat.com>
 544
 545         PR gdb/23712
 546         PR symtab/23010
 547         * dictionary.h (struct dictionary): Replace declaration with
 548         multidictionary.
 549         (dict_create_hashed, dict_create_hashed_expandable)
 550         (dict_create_linear, dict_create_linear_expandable)
 551         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
 552         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
 553         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
 554         taking multidictionary argument.
 555         [ALL_DICT_SYMBOLS]: Update for multidictionary.
 556         * block.h (struct block) <dict>: Change to multidictionary
 557         and rename `multidict'.
 558         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
 559         symmisc.c: Update all dictionary references to multidictionary.
 560
 561 2019-01-10  Keith Seitz  <keiths@redhat.com>
 562
 563         PR gdb/23712
 564         PR symtab/23010
 565         * dictionary.c: Include unordered_map.
 566         (pending_to_vector): New function.
 567         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 568         Rewrite the non-"_1" functions to take vector instead
 569         of linked list.
 570         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
 571         "new" _1 versions of the same name.
 572         (multidictionary): Define.
 573         (std::hash<enum language): New definition.
 574         (collate_pending_symbols_by_language, mdict_create_hashed)
 575         (mdict_create_hashed_expandable, mdict_create_linear)
 576         (mdict_create_linear_expandable, mdict_free)
 577         (find_language_dictionary, create_new_language_dictionary)
 578         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
 579         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
 580         (mdict_size, mdict_empty): New functions.
 581         * dictionary.h (mdict_iterator): Define.
 582
 583 2019-01-10  Pedro Alves  <palves@redhat.com>
 584
 585         * breakpoint.c (read_uploaded_action)
 586         (create_tracepoint_from_upload): Adjust to use
 587         gdb::unique_xmalloc_ptr.
 588         * ctf.c (ctf_write_uploaded_tp):
 589         (SET_ARRAY_FIELD): Use emplace_back.
 590         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
 591         * tracefile-tfile.c (tfile_write_uploaded_tp):
 592         * tracepoint.c (parse_tracepoint_definition): Adjust to use
 593         gdb::unique_xmalloc_ptr.
 594         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
 595         at_string, cond_string, cmd_strings>: Replace char pointers
 596         with gdb::unique_xmalloc_ptr.
 597
 598 2019-01-10  Pedro Alves  <palves@redhat.com>
 599
 600         * solib-target.c (library_list_start_library): Don't xstrdup name.
 601
 602 2019-01-10  Pedro Alves  <palves@redhat.com>
 603
 604         * mdebugread.c (parse_partial_symbols): Use
 605         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
 606
 607 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 608
 609         * linux-fork.c (scoped_switch_fork_info)
 610         <~scoped_switch_fork_info>: Fix incorrect variable name.
 611
 612 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 613
 614         * linux-fork.c (scoped_switch_fork_info)
 615         <scoped_switch_fork_info>: Make explicit.
 616         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
 617
 618 2019-01-10  Tom Tromey  <tom@tromey.com>
 619
 620         * objfiles.h (objfile::reset_psymtabs): Update.
 621         * objfiles.c (objfile::objfile): Update.
 622         * psymtab.h (psymtab_storage::obstack): Update.
 623         (psymtab_storage::m_obstack): Use gdb::optional.
 624         (class psymtab_storage): Update comment.  Remove objfile
 625         parameter.
 626         * psymtab.c (psymtab_storage::psymtab_storage): Update.
 627
 628 2019-01-10  Tom Tromey  <tom@tromey.com>
 629
 630         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
 631         <free_psymtabs>: Now private.
 632         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
 633         (allocate_psymtab): Use new method.
 634
 635 2019-01-10  Tom Tromey  <tom@tromey.com>
 636
 637         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
 638         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
 639         * mdebugread.c (parse_partial_symbols): Use
 640         allocate_dependencies.
 641         * dwarf2read.c (dwarf2_create_include_psymtab): Use
 642         allocate_dependencies.
 643         (process_psymtab_comp_unit_reader)
 644         (build_type_psymtab_dependencies): Likewise.
 645         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
 646
 647 2019-01-10  Tom Tromey  <tom@tromey.com>
 648
 649         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
 650         PSYMBOL_SET_LANGUAGE.
 651         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
 652
 653 2019-01-10  Tom Tromey  <tom@tromey.com>
 654
 655         * psymtab.h (psymtab_storage::obstack): New method.
 656         <m_obstack>: Rename from obstack; now private.
 657         * psymtab.c (psymtab_storage): Update.
 658         * dwarf2read.c (create_addrmap_from_index)
 659         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
 660         Update.
 661
 662 2019-01-10  Tom Tromey  <tom@tromey.com>
 663
 664         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
 665         * objfiles.h (objfile::reset_psymtabs): New method.
 666
 667 2019-01-10  Tom Tromey  <tom@tromey.com>
 668
 669         * symmisc.c (print_symbol_bcache_statistics): Update.
 670         (print_objfile_statistics): Update.
 671         * symfile.c (reread_symbols): Update.
 672         * psymtab.h (class psymtab_storage): New.
 673         * psymtab.c (psymtab_storage): New constructor.
 674         (~psymtab_storage): New destructor.
 675         (require_partial_symbols): Update.
 676         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
 677         (find_pc_sect_psymtab, find_pc_sect_psymbol)
 678         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
 679         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
 680         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
 681         (start_psymtab_common, end_psymtab_common)
 682         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
 683         (allocate_psymtab): Update.
 684         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
 685         Update.
 686         (dump_psymtab_addrmap, maintenance_print_psymbols)
 687         (maintenance_check_psymtabs): Update.
 688         (class objfile_psymtabs): Move to objfiles.h.
 689         * psympriv.h (discard_psymtab): Now inline.
 690         (psymtab_discarder::psymtab_discarder): Update.
 691         (psymtab_discarder::~psymtab_discarder): Update.
 692         (ALL_OBJFILE_PSYMTABS): Rewrite.
 693         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
 694         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
 695         Remove fields.
 696         <partial_symtabs>: New field.
 697         (class objfile_psymtabs): Move from psymtab.h.  Update.
 698         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
 699         psymbol_cache.
 700         (objfile::~objfile): Don't destroy psymbol_cache.
 701         * mdebugread.c (parse_partial_symbols): Update.
 702         * dwarf2read.c (create_addrmap_from_index)
 703         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
 704         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
 705         (add_partial_subprogram, dwarf2_ranges_read): Update.
 706         * dwarf-index-write.c (write_address_map)
 707         (write_one_signatured_type, recursively_write_psymbols)
 708         (class debug_names, class debug_names, write_psymtabs_to_index):
 709         Update.
 710
 711 2019-01-10  Tom Tromey  <tom@tromey.com>
 712
 713         * symtab.h (SYMBOL_SET_NAMES): Update.
 714         (symbol_set_names): Update.
 715         (MSYMBOL_SET_NAMES): Update.
 716         * symtab.c (symbol_set_names): Change argument to be an
 717         objfile_per_bfd_storage.
 718         * psymtab.c (add_psymbol_to_bcache): Update.
 719         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
 720
 721 2019-01-10  Tom Tromey  <tom@tromey.com>
 722
 723         * symtab.c (create_demangled_names_hash): Change argument to be an
 724         objfile_per_bfd_storage.
 725         (symbol_set_names): Update.
 726
 727 2019-01-10  Tom Tromey  <tom@tromey.com>
 728
 729         * xcoffread.c (xcoff_initial_scan): Unconditionally call
 730         init_psymbol_list.
 731         * psymtab.c (init_psymbol_list): Do nothing if already called.
 732         * psympriv.h (init_psymbol_list): Add comment.
 733         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
 734         init_psymbol_list.
 735         * dbxread.c (dbx_symfile_read): Unconditionally call
 736         init_psymbol_list.
 737
 738 2019-01-10  Tom Tromey  <tom@tromey.com>
 739
 740         * xcoffread.c (scan_xcoff_symtab): Update.
 741         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
 742         "where".
 743         * mdebugread.c (parse_partial_symbols)
 744         (handle_psymbol_enumerators): Update.
 745         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
 746         * dbxread.c (read_dbx_symtab): Update.
 747         * psympriv.h (psymbol_placement): New enum.
 748         (add_psymbol_to_list): Update.
 749
 750 2019-01-10  Tom Tromey  <tom@tromey.com>
 751
 752         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
 753         static_psymbols parameters.
 754         (scan_xcoff_symtab): Update.
 755         * psymtab.c (start_psymtab_common): Remove global_psymbols and
 756         static_psymbols parameters.
 757         * psympriv.h (start_psymtab_common): Update.
 758         * mdebugread.c (parse_partial_symbols): Update.
 759         * dwarf2read.c (create_partial_symtab): Update.
 760         * dbxread.c (read_dbx_symtab): Update.
 761         (start_psymtab): Remove global_psymbols and static_psymbols
 762         parameters.
 763
 764 2019-01-10  Tom Tromey  <tom@tromey.com>
 765
 766         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
 767         * psymtab.c (allocate_psymtab): Add comment.
 768         * psympriv.h (allocate_psymtab): Add comment.
 769         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
 770         initializations.
 771         * dbxread.c (dbx_end_psymtab): Remove some initializations.
 772
 773 2019-01-10  Tom Tromey  <tom@tromey.com>
 774
 775         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
 776         Don't declare.
 777         * mipsread.c: Include mdebugread.h.
 778         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
 779         Declare.
 780         * elfread.c: Include mdebugread.h.
 781
 782 2019-01-09  Tom Tromey  <tom@tromey.com>
 783
 784         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
 785         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
 786         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
 787         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
 788         (psym_lookup_symbol, psym_find_last_source_symtab)
 789         (psym_forget_cached_source_info, psym_print_stats)
 790         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
 791         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
 792         (psym_map_matching_symbols, psym_expand_symtabs_matching)
 793         (psym_find_compunit_symtab_by_address)
 794         (maintenance_print_psymbols, maintenance_info_psymtabs)
 795         (maintenance_check_psymtabs): Use ranged for.
 796         * psymtab.h (class objfile_psymtabs): New.
 797         (require_partial_symbols): Return objfile_psymtabs.
 798         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
 799
 800 2019-01-09  Tom Tromey  <tom@tromey.com>
 801
 802         * symfile.c (overlay_invalidate_all, find_pc_overlay)
 803         (find_pc_mapped_section, list_overlays_command)
 804         (map_overlay_command, unmap_overlay_command)
 805         (simple_overlay_update): Use all_objfiles.
 806         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
 807         * printcmd.c (info_symbol_command): Use all_objfiles.
 808         * objfiles.h (ALL_OBJSECTIONS): Remove.
 809         * maint.c (maintenance_translate_address): Use all_objfiles.
 810         * gcore.c (gcore_create_callback): Use all_objfiles.
 811         (objfile_find_memory_regions): Likewise.
 812
 813 2019-01-09  Tom Tromey  <tom@tromey.com>
 814
 815         * symtab.c (find_line_symtab, info_sources_command)
 816         (make_source_files_completion_list): Use objfile_compunits.
 817         * source.c (select_source_symtab): Use objfile_compunits.
 818         * objfiles.h (struct objfile): Update comment.
 819         (ALL_OBJFILES): Remove.
 820         (ALL_FILETABS): Remove.
 821         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
 822         objfile_compunits.
 823
 824 2019-01-09  Tom Tromey  <tom@tromey.com>
 825
 826         * symmisc.c (print_objfile_statistics, dump_objfile)
 827         (maintenance_print_symbols): Use compunit_filetabs.
 828         * source.c (forget_cached_source_info_for_objfile): Use
 829         compunit_filetabs.
 830         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
 831         (ALL_FILETABS): Use compunit_filetabs.
 832         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
 833         * coffread.c (coff_symtab_read): Use compunit_filetabs.
 834
 835 2019-01-09  Tom Tromey  <tom@tromey.com>
 836
 837         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
 838         (compunit_filetabs): New.
 839         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
 840         compunit_filetabs.
 841         (info_sources_command, make_source_files_completion_list): Remove
 842         declaration.
 843         * symmisc.c (print_objfile_statistics, dump_objfile)
 844         (maintenance_print_symbols): Remove declaration.
 845         (maintenance_info_symtabs): Use compunit_filetabs.
 846         (maintenance_info_line_tables): Likewise.
 847         * source.c (select_source_symtab): Change local variable name.
 848         (forget_cached_source_info_for_objfile): Remove declaration.
 849         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
 850         * objfiles.c (objfile_relocate1): Remove declaration.
 851         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
 852         declaration.
 853         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
 854         * coffread.c (coff_symtab_read): Remove declaration.
 855         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 856         compunit_filetabs.
 857
 858 2019-01-09  Tom Tromey  <tom@tromey.com>
 859
 860         * symtab.c (lookup_objfile_from_block)
 861         (find_pc_sect_compunit_symtab, search_symbols)
 862         (default_collect_symbol_completion_matches_break_on): Use
 863         objfile_compunits.
 864         * objfiles.h (ALL_COMPUNITS): Remove.
 865         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
 866         * cp-support.c (add_symbol_overload_list_qualified): Use
 867         objfile_compunits.
 868         * ada-lang.c (ada_collect_symbol_completion_matches)
 869         (ada_add_global_exceptions): Use objfile_compunits.
 870
 871 2019-01-09  Tom Tromey  <tom@tromey.com>
 872
 873         * source.c (select_source_symtab)
 874         (forget_cached_source_info_for_objfile): Remove declaration.
 875         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
 876         declaration.
 877         * maint.c (count_symtabs_and_blocks): Remove declaration.
 878         * cp-support.c (add_symbol_overload_list_qualified): Remove
 879         declaration.
 880         * coffread.c (coff_symtab_read): Remove declaration.
 881         * symtab.c (lookup_symbol_in_objfile_symtabs)
 882         (basic_lookup_transparent_type_1): Use objfile_compunits.
 883         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
 884         (info_sources_command, search_symbols)
 885         (default_collect_symbol_completion_matches_break_on)
 886         (make_source_files_completion_list): Remove declaration.
 887         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
 888         (ada_collect_symbol_completion_matches)
 889         (ada_add_global_exceptions): Remove declaration.
 890         * linespec.c (iterate_over_all_matching_symtabs): Use
 891         objfile_compunits.
 892         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
 893         (class objfile_compunits): New.
 894         (ALL_COMPUNITS): Use objfile_compunits.
 895         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
 896         (maintenance_check_symtabs, maintenance_info_line_tables): Use
 897         objfile_compunits.
 898         * objfiles.c (objfile_relocate1): Use objfile_compunits.
 899
 900 2019-01-09  Tom Tromey  <tom@tromey.com>
 901
 902         * symtab.c (search_symbols)
 903         (default_collect_symbol_completion_matches_break_on): Use
 904         objfile_msymbols.
 905         * ada-lang.c (ada_lookup_simple_minsym)
 906         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
 907         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
 908         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
 909         objfile_msymbols.
 910         * coffread.c (coff_symfile_read): Use objfile_msymbols.
 911         * symmisc.c (dump_msymbols): Use objfile_msymbols.
 912         * objc-lang.c (find_methods): Use objfile_msymbols.
 913         (info_selectors_command, info_classes_command): Likewise.
 914         * stabsread.c (scan_file_globals): Use objfile_msymbols.
 915         * objfiles.h (class objfile_msymbols): New.
 916         (ALL_OBJFILE_MSYMBOLS): Remove.
 917         (ALL_MSYMBOLS): Remove.
 918
 919 2019-01-09  Tom Tromey  <tom@tromey.com>
 920
 921         * common/next-iterator.h (next_adapter): Add Iterator template
 922         parameter.
 923         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
 924         (class all_objfiles_safe): New.
 925         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
 926         * objfiles.c (put_objfile_before): Update comment.
 927         (add_separate_debug_objfile): Likewise.
 928         (free_all_objfiles): Use all_objfiles_safe.
 929         (objfile_purge_solibs): Likewise.
 930
 931 2019-01-09  Tom Tromey  <tom@tromey.com>
 932
 933         * symtab.c (iterate_over_symtabs, matching_obj_sections)
 934         (expand_symtab_containing_pc, lookup_static_symbol)
 935         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
 936         (find_symbol_at_address, find_line_symtab, find_main_name): Use
 937         all_objfiles.
 938         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
 939         * breakpoint.c (create_overlay_event_breakpoint)
 940         (create_longjmp_master_breakpoint)
 941         (create_std_terminate_master_breakpoint)
 942         (create_exception_master_breakpoint): Use all_objfiles.
 943         * linux-thread-db.c (try_thread_db_load_from_pdir)
 944         (has_libpthread): Use all_objfiles.
 945         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
 946         * linespec.c (iterate_over_all_matching_symtabs)
 947         (search_minsyms_for_name): Use all_objfiles.
 948         * maint.c (maintenance_info_sections): Use all_objfiles.
 949         * main.c (captured_main_1): Use all_objfiles.
 950         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
 951         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
 952         * guile/scm-pretty-print.c
 953         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
 954         * solib-spu.c (append_ocl_sos): Use all_objfiles.
 955         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
 956         (maintenance_print_msymbols): Use all_objfiles.
 957         * source.c (select_source_symtab): Use all_objfiles.
 958         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
 959         * symfile.c (remove_symbol_file_command)
 960         (expand_symtabs_matching, map_symbol_filenames): Use
 961         all_objfiles.
 962         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
 963         all_objfiles.
 964         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
 965         * objc-lang.c (find_methods): Use all_objfiles.
 966         * objfiles.c (have_partial_symbols, have_full_symbols)
 967         (have_minimal_symbols, qsort_cmp)
 968         (default_iterate_over_objfiles_in_search_order): Use
 969         all_objfiles.
 970         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
 971         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
 972         (maintenance_check_psymtabs): Use all_objfiles.
 973         (ALL_PSYMTABS): Remove.
 974         * compile/compile-object-run.c (do_module_cleanup): Use
 975         all_objfiles.
 976         * blockframe.c (find_pc_partial_function): Use all_objfiles.
 977         * cp-support.c (add_symbol_overload_list_qualified): Use
 978         all_objfiles.
 979         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
 980         Use all_objfiles.
 981         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
 982         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
 983         all_objfiles.
 984         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
 985         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
 986         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
 987         Uses all_objfiles.
 988         * solib.c (solib_read_symbols): Use all_objfiles
 989
 990 2019-01-09  Tom Tromey  <tom@tromey.com>
 991
 992         * probe.c (parse_probes_in_pspace): Use all_objfiles.
 993         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
 994         all_objfiles.
 995         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
 996         * symmisc.c (print_symbol_bcache_statistics)
 997         (print_objfile_statistics, maintenance_print_objfiles)
 998         (maintenance_info_symtabs, maintenance_check_symtabs)
 999         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
1000         all_objfiles.
1001         * source.c (forget_cached_source_info): Use all_objfiles.
1002         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
1003         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1004         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
1005         * objfiles.c (update_section_map): Use all_objfiles.
1006         (shared_objfile_contains_address_p): Likewise.
1007         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
1008         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
1009
1010 2019-01-09  Tom Tromey  <tom@tromey.com>
1011
1012         * common/next-iterator.h: New file.
1013         * objfiles.h (class all_objfiles): New.
1014         (struct objfile_iterator): New.
1015
1016 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1017
1018         * NEWS: Move the description of the changed "frame", "select-frame",
1019          and "info frame" commands to the Changed commands section.
1020
1021 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
1022
1023         * gdbtypes.c (check_stub_method_group): Remove handling of old
1024         mangling schemes.
1025         * linespec.c (find_methods): Likewise.
1026         * stabsread.c (read_member_functions): Likewise.
1027         * valops.c (search_struct_method): Likewise.
1028         (value_struct_elt_for_reference): Likewise.
1029         * NEWS: Mention this change.
1030
1031 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1032
1033         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
1034         print_source_lines.
1035         * source.c (print_source_lines_base): Update line number check.
1036         (print_source_lines): New function.
1037         (source_lines_range::source_lines_range): New function.
1038         * source.h (class source_lines_range): New class.
1039         (print_source_lines): New declaration.
1040
1041 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1042
1043         * linespec.c (linespec_state_destructor): Free self->canonical_names.
1044
1045 2019-01-08  Tom Tromey  <tom@tromey.com>
1046             Simon Marchi  <simon.marchi@ericsson.com>
1047
1048         PR gdb/24060
1049         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
1050         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
1051         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1052         * f-exp.y (DOLLAR_VARIABLE): Likewise.
1053         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
1054         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1055
1056 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1057
1058         * source.c (select_source_symtab): Move header comment to
1059         declaration in source.h.
1060         (forget_cached_source_info_for_objfile): Likewise.
1061         (forget_cached_source_info): Likewise.
1062         (identify_source_line): Likewise.
1063         * source.h (identify_source_line): Move declaration from symtab.h
1064         and add comment from source.c
1065         (print_source_lines): Likewise.
1066         (forget_cached_source_info_for_objfile): Likewise.
1067         (forget_cached_source_info): Likewise.
1068         (select_source_symtab): Likewise.
1069         (enum print_source_lines_flag): Move definition from symtab.h.
1070         * symtab.h (identify_source_line): Move declaration to source.h.
1071         (print_source_lines): Likewise.
1072         (forget_cached_source_info_for_objfile): Likewise.
1073         (forget_cached_source_info): Likewise.
1074         (select_source_symtab): Likewise.
1075         (enum print_source_lines_flag): Move definition to source.h.
1076         * tui/tui-hooks.c: Add 'source.h' include.
1077
1078 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1079
1080         * source.c (print_source_lines_base): Handle requests to print
1081         reverse line number sequences, and guard against empty lines
1082         string.
1083
1084 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1085
1086         * source.c (print_source_lines_base): Fix skip of '\r' if next
1087         character is '\n'.
1088
1089 2019-01-06  Tom Tromey  <tom@tromey.com>
1090
1091         * c-exp.y (struct c_parse_state) <macro_original_text,
1092         expansion_obstack>: New member.
1093         (macro_original_text, expansion_obstack): Remove globals.
1094         (scan_macro_expansion, scanning_macro_expansion)
1095         (finished_macro_expansion): Update.
1096         (scan_macro_cleanup): Remove.
1097         (yylex, c_parse): Update.
1098
1099 2019-01-06  Tom Tromey  <tom@tromey.com>
1100
1101         * c-exp.y (struct c_parse_state) <strings>: New member.
1102         (operator_stoken): Update.
1103
1104 2019-01-06  Tom Tromey  <tom@tromey.com>
1105
1106         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
1107         (union type_stack_elt) <typelist_val>: Now a pointer to
1108         std::vector.
1109         (type_stack_cleanup): Don't declare.
1110         (push_typelist): Update.
1111         * parse.c (pop_typelist): Return a std::vector.
1112         (push_typelist): Take a std::vector.
1113         (follow_types): Update.  Do not free args.
1114         (type_stack_cleanup): Remove.
1115         * c-exp.y (struct c_parse_state): New.
1116         (cpstate): New global.
1117         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
1118         (nonempty_typelist): Update.
1119         (func_mod): Create a new vector.
1120         (c_parse): Create a c_parse_state.
1121         (check_parameter_typelist): Do not delete params.
1122         (function_method): Update.  Do not delete type_list.
1123
1124 2019-01-06  Tom Tromey  <tom@tromey.com>
1125
1126         PR gdb/28155:
1127         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
1128         check_typedef.
1129         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
1130         (print_return_value): Likewise.
1131
1132 2019-01-05  Tom Tromey  <tom@tromey.com>
1133
1134         * contrib/cleanup_check.py: Remove.
1135         * contrib/gcc-with-excheck: Remove.
1136         * contrib/exsummary.py: Remove.
1137         * contrib/excheck.py: Remove.
1138
1139 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
1140
1141         * thread.c (delete_thread_1): Add gdb_assert that THR is not
1142         NULL. Initialize tpprev to NULL instead of assigning it
1143         to NULL on the next statement.
1144         * windows-nat.c (windows_delete_thread): Remove check for
1145         main_thread_id before printing thread exit notifications.
1146         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
1147         Remove thread ID check against main_thread_id.
1148         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
1149         windows_delete_thread.
1150         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
1151
1152 2019-01-04  Tom Tromey  <tom@tromey.com>
1153
1154         * compile/compile.c (_initialize_compile): Use upper case for
1155         metasyntactic variables.
1156         * symmisc.c (_initialize_symmisc): Use upper case for
1157         metasyntactic variables.
1158         * psymtab.c (_initialize_psymtab): Use upper case for
1159         metasyntactic variables.
1160         * demangle.c (demangle_command): Use upper case for metasyntactic
1161         variables.
1162         (_initialize_demangler): Likewise.
1163         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
1164         variables.
1165
1166 2019-01-03  Tom Tromey  <tom@tromey.com>
1167
1168         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
1169
1170 2019-01-03  Tom Tromey  <tom@tromey.com>
1171
1172         * python/py-symtab.c (salpy_str): Update.
1173         (struct salpy_sal_object) <symtab>: Now a PyObject.
1174         (salpy_dealloc): Update.
1175         (del_objfile_sal): Use gdbpy_ref.
1176
1177 2019-01-03  Tom Tromey  <tom@tromey.com>
1178
1179         * python/py-type.c (convert_field): Use new_reference.  Return
1180         gdbpy_ref.
1181         (make_fielditem): Return gdbpy_ref.
1182         (typy_fields): Update.
1183         (typy_getitem): Update.
1184         (field_name): Return gdbpy_ref.  Use new_reference.
1185         (typy_iterator_iternext): Update.
1186
1187 2019-01-03  Tom Tromey  <tom@tromey.com>
1188
1189         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
1190
1191 2019-01-03  Tom Tromey  <tom@tromey.com>
1192
1193         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
1194         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
1195         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
1196         (pspy_set_frame_filters, pspy_set_frame_unwinders)
1197         (pspy_set_type_printers): Likewise.
1198         * python/py-function.c (fnpy_init): Use gdbpy_ref.
1199         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
1200         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
1201         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
1202         (objfpy_set_type_printers): Likewise.
1203
1204 2019-01-03  Tom Tromey  <tom@tromey.com>
1205
1206         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
1207         (gdbpy_print_stack): Use gdbpy_err_fetch.
1208         * python/python-internal.h (class gdbpy_err_fetch): New class.
1209         (class gdbpy_enter) <m_error_type, m_error_value,
1210         m_error_traceback>: Remove.
1211         <m_error>: New member.
1212         (gdbpy_exception_to_string): Don't declare.
1213         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
1214         * python/py-value.c (convert_value_from_python): Use
1215         gdbpy_err_fetch.
1216         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
1217         gdbpy_exception_to_string.
1218         (gdbpy_handle_exception): Use gdbpy_err_fetch.
1219         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1220         gdbpy_err_fetch.
1221
1222 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1223
1224         * linux-nat.c (delete_lwp_cleanup): Delete.
1225         (struct lwp_deleter): New struct.
1226         (lwp_info_up): New typedef.
1227         (linux_nat_target::follow_fork): Delete cleanup, and make use of
1228         lwp_info_up.
1229
1230 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1231
1232         * linux-fork.c (class scoped_switch_fork_info): New class.
1233         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
1234
1235 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1236
1237         * valops.c (find_overload_match): Remove use of null_cleanup, and
1238         calls to do_cleanups.
1239
1240 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1241
1242         * compile/compile-cplus-types.c
1243         (compile_cplus_instance::decl_name): Handle changes to
1244         cp_func_name.
1245         * cp-support.c (cp_func_name): Update header comment, update
1246         return type.
1247         * cp-support.h (cp_func_name): Update return type in declaration.
1248         * valops.c (find_overload_match): Move temp_func local to top
1249         level of function and change its type.  Use temp_func to hold and
1250         delete temporary string obtained from cp_func_name.
1251
1252 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1253
1254         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
1255         gdb::char_vector, remove cleanup, and update uses of `msg`.
1256
1257 2019-01-03  Jim Wilson  <jimw@sifive.com>
1258
1259         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
1260
1261 2019-01-02  Tom Tromey  <tom@tromey.com>
1262
1263         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
1264         (tdesc_parse_xml): Remove cleanups.
1265         * target-descriptions.h (make_cleanup_free_target_description):
1266         Don't declare.
1267         (target_desc_deleter): New struct.
1268         (target_desc_up): New typedef.
1269         * target-descriptions.c (target_desc_deleter::operator()): Rename
1270         from free_target_description.
1271         (make_cleanup_free_target_description): Remove.
1272
1273 2019-01-02  Tom Tromey  <tom@tromey.com>
1274
1275         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
1276         constructor, destructor.
1277         (linespec_parser): Remove typedef.
1278         (~linespec_parser): Rename from linespec_parser_delete.
1279         (linespec_lex_to_end, linespec_complete_label)
1280         (linespec_complete): Update.
1281         (decode_line_full): Remove cleanups.
1282         (decode_line_1): Update.
1283
1284 2019-01-02  Tom Tromey  <tom@tromey.com>
1285
1286         * python/python-internal.h (inferior_to_inferior_object): Change
1287         return type.
1288         * python/py-exitedevent.c (create_exited_event_object): Update.
1289         * python/py-inferior.c (inferior_to_inferior_object): Return
1290         gdbpy_ref.
1291         (python_new_inferior, python_inferior_deleted)
1292         (thread_to_thread_object, delete_thread_object)
1293         (build_inferior_list, gdbpy_selected_inferior): Update.
1294         * python/py-infthread.c (create_thread_object): Update.  Also fail
1295         if inferior_to_inferior_object fails.
1296
1297 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
1298
1299         * inferior.h (class inferior) <displaced_step_state>: New field.
1300         * infrun.h (struct displaced_step_state): Move here from
1301         infrun.c.  Initialize fields, add constructor.
1302         <inf>: Remove field.
1303         <reset>: New method.
1304         * infrun.c (struct displaced_step_inferior_state): Move to
1305         infrun.h.
1306         (displaced_step_inferior_states): Remove.
1307         (get_displaced_stepping_state): Adust.
1308         (displaced_step_in_progress_any_inferior): Adjust.
1309         (displaced_step_in_progress_thread): Adjust.
1310         (displaced_step_in_progress): Adjust.
1311         (add_displaced_stepping_state): Remove.
1312         (get_displaced_step_closure_by_addr): Adjust.
1313         (remove_displaced_stepping_state): Remove.
1314         (infrun_inferior_exit): Call displaced_step_state.reset.
1315         (use_displaced_stepping): Don't check for NULL.
1316         (displaced_step_prepare_throw): Call
1317         get_displaced_stepping_state.
1318         (displaced_step_fixup): Don't check for NULL.
1319         (prepare_for_detach): Don't check for NULL.
1320
1321 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1322
1323         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
1324          in case of call that did not complete.
1325
1326 2019-01-02  Andrey Utkin  <autkin@undo.io>
1327
1328         * symfile.c (find_separate_debug_file): Fix search of debug files for
1329         remote debuggee.
1330
1331 2019-01-02  Tom Tromey  <tom@tromey.com>
1332
1333         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
1334         indentation.
1335         * python/py-frame.c (frapy_older): Remove cast.
1336         (frapy_newer): Likewise.
1337         * python/py-breakpoint.c (local_setattro): Remove cast.
1338         * python/py-arch.c (archpy_name): Remove local variable.
1339         * python/py-type.c (gdbpy_lookup_type): Remove cast.
1340
1341 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
1342
1343         * unittests/basic_string_view/element_access/char/empty.cc:
1344         Fix year range in copyright header.
1345
1346 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1347
1348         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
1349         Delete.
1350         <operator==>: Update with for removed field.
1351         <hash>: Likewise.
1352         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
1353         <isa_features>: ...this.
1354         <abi_features>: New field.
1355         (riscv_isa_flen): Update comment.
1356         (riscv_abi_xlen): New declaration.
1357         (riscv_abi_flen): New declaration.
1358         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
1359         isa_features.
1360         (riscv_abi_xlen): New function.
1361         (riscv_isa_flen): Update to get answer from isa_features.
1362         (riscv_abi_flen): New function.
1363         (riscv_has_fp_abi): Update to get answer from abi_features.
1364         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
1365         xlen and flen.
1366         (riscv_call_info) <xlen, flen>: Update comment.
1367         (riscv_call_arg_struct): Remove invalid assertions
1368         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
1369         is removed.
1370         (riscv_gdbarch_init): Gather isa features and abi features
1371         separately, ensure both match on the gdbarch when reusing an old
1372         gdbarch.  Relax an error check to allow 32-bit abi float to run on
1373         a target with 64-bit float hardware.
1374
1375 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1376
1377         * source.c (search_command_helper): Stop reverse search
1378         when line 1 has been searched.
1379
1380 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1381
1382         * record-full.c (record_full_base_target::close): Rewrite
1383         record_full_core_buf_list free logic.
1384
1385 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1386
1387         * break-catch-syscall.c (print_one_catch_syscall): xfree
1388         the last text.
1389
1390 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1391
1392         * top.c (print_gdb_version): Update Copyright year in version
1393         message.
1394
1395 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1396
1397         Update copyright year range in all GDB files.
1398
1399 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
1400
1401         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
1402
1403 For older changes see ChangeLog-2018.
1404 \f
1405 Local Variables:
1406 mode: change-log
1407 left-margin: 8
1408 fill-column: 74
1409 version-control: never
1410 coding: utf-8
1411 End:
1412