gdb/ChangeLog

   1 2019-02-22  Keith Seitz  <keiths@redhat.com>
   2
   3         PR symtab/23853
   4         * linespec.c (create_sals_line_offset): Search for the default
   5         symtab's filename instead of its fullname.
   6
   7 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
   8
   9         * NEWS: Update style defaults.
  10
  11 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
  12
  13         * main.c (captured_main_1): Disable styling in batch mode.
  14
  15 2019-02-20  Tom Tromey  <tom@tromey.com>
  16
  17         * symtab.c (symtab_symbol_info): Fix typos.
  18
  19 2019-02-20  Tom Tromey  <tromey@adacore.com>
  20
  21         * findcmd.c (_initialize_mem_search): Use upper case for
  22         metasyntactic variables.
  23
  24 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
  25
  26         * aarch64-tdep.c (aarch64_add_reggroups): New function.
  27         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
  28
  29 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
  30
  31         * top.h (source_file_name): Change to std::string.
  32         * top.c (source_file_name): Likewise.
  33         (command_line_input): Adjust.
  34         * cli/cli-script.c (script_from_file): Adjust.
  35
  36 2019-02-19  Tom Tromey  <tromey@adacore.com>
  37
  38         * ravenscar-thread.c
  39         (ravenscar_thread_target::update_thread_list): Don't call
  40         ada_build_task_list.
  41         * ada-lang.h (ada_build_task_list): Don't declare.
  42         * ada-tasks.c (struct ada_tasks_inferior_data)
  43         <task_list_valid_p>: Now bool.
  44         (read_known_tasks, ada_task_list_changed)
  45         (ada_tasks_invalidate_inferior_data): Update.
  46         (read_known_tasks_array): Return bool.
  47         (read_known_tasks_list): Likewise.
  48         (read_known_tasks): Return void.
  49         (ada_build_task_list): Now static.
  50
  51 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
  52
  53         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
  54         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
  55
  56 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  57
  58         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
  59         variant for ada_tasks_pspace_data_handle and
  60         ada_tasks_inferior_data_handle.
  61         (ada_tasks_pspace_data_cleanup): New function.
  62         (ada_tasks_inferior_data_cleanup): New function.
  63
  64 2019-02-17  Tom Tromey  <tom@tromey.com>
  65
  66         * macrotab.h (macro_source_fullname): Return a std::string.
  67         * macrotab.c (macro_include, check_for_redefinition)
  68         (macro_undef, macro_lookup_definition, foreach_macro)
  69         (foreach_macro_in_scope): Update.
  70         (macro_source_fullname): Return a std::string.
  71         * macrocmd.c (show_pp_source_pos): Update.
  72
  73 2019-02-17  Tom Tromey  <tom@tromey.com>
  74
  75         * macrocmd.c (show_pp_source_pos): Style the file names.
  76
  77 2019-02-17  Tom Tromey  <tom@tromey.com>
  78
  79         PR tui/24197:
  80         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
  81
  82 2019-02-17  Tom Tromey  <tom@tromey.com>
  83
  84         * ada-lang.c (user_select_syms): Use filtered printing.
  85         * utils.c (wrap_style): New global.
  86         (desired_style): Remove.
  87         (emit_style_escape): Add stream parameter.
  88         (set_output_style, reset_terminal_style, prompt_for_continue):
  89         Update.
  90         (flush_wrap_buffer): Only flush gdb_stdout.
  91         (wrap_here): Set wrap_style.
  92         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
  93         treat escape sequences as a character.  Change when wrap buffer is
  94         flushed.
  95         (fputs_styled): Do not set the output style when the default is
  96         requested.
  97         * ui-style.h (struct ui_file_style) <is_default>: New method.
  98         * source.c (print_source_lines_base): Emit escape sequences in one
  99         piece.
 100
 101 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 102
 103         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
 104         integers and enumeration types.
 105
 106 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 107
 108         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
 109         instead of lookup_symbol_in_language
 110         (do_exact_match): New function.
 111         (ada_get_symbol_name_matcher): Return do_exact_match when
 112         doing a verbatim match.
 113
 114 2019-02-15  Tom Tromey  <tromey@adacore.com>
 115
 116         * ravenscar-thread.c (ravenscar_thread_target::resume)
 117         (ravenscar_thread_target::wait): Special case wildcard requests.
 118
 119 2019-02-15  Tom Tromey  <tromey@adacore.com>
 120
 121         * ravenscar-thread.c (base_ptid): Remove.
 122         (struct ravenscar_thread_target) <close>: New method.
 123         <m_base_ptid>: New member.
 124         <update_inferior_ptid, active_task, task_is_currently_active,
 125         runtime_initialized>: Declare methods.
 126         <ravenscar_thread_target>: Add constructor.
 127         (ravenscar_thread_target::task_is_currently_active)
 128         (ravenscar_thread_target::update_inferior_ptid)
 129         (ravenscar_runtime_initialized): Rename.  Now methods.
 130         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
 131         (ravenscar_thread_target::update_thread_list): Update.
 132         (ravenscar_thread_target::active_task): Now method.
 133         (ravenscar_thread_target::store_registers)
 134         (ravenscar_thread_target::prepare_to_store)
 135         (ravenscar_thread_target::prepare_to_store)
 136         (ravenscar_thread_target::mourn_inferior): Update.
 137         (ravenscar_inferior_created): Use "new" to create target.
 138         (ravenscar_thread_target::get_ada_task_ptid): Update.
 139         (_initialize_ravenscar): Don't initialize base_ptid.
 140         (ravenscar_ops): Remove global.
 141
 142 2019-02-15  Tom Tromey  <tromey@adacore.com>
 143
 144         * target.h (push_target): Declare new overload.
 145         * target.c (push_target): New overload, taking an rvalue reference.
 146         * remote.c (remote_target::open_1): Use push_target overload.
 147         * corelow.c (core_target_open): Use push_target overload.
 148
 149 2019-02-15  Tom Tromey  <tromey@adacore.com>
 150
 151         * ravenscar-thread.c (is_ravenscar_task)
 152         (ravenscar_task_is_currently_active): Return bool.
 153         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
 154         (_initialize_ravenscar): Remove "(void)".
 155         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
 156         Return bool.
 157
 158 2019-02-15  Tom Tromey  <tromey@adacore.com>
 159
 160         * ravenscar-thread.c (ravenscar_runtime_initializer)
 161         (has_ravenscar_runtime, get_running_thread_id)
 162         (ravenscar_thread_target::resume): Fix indentation.
 163
 164 2019-02-15  Tom Tromey  <tromey@adacore.com>
 165
 166         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
 167         from ravenscar_arch_ops.
 168         (sparc_ravenscar_ops::fetch_registers)
 169         (sparc_ravenscar_ops::store_registers): Now methods.
 170         (sparc_ravenscar_prepare_to_store): Remove.
 171         (sparc_ravenscar_ops): Redefine.
 172         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
 173         methods and destructor.  Remove members.
 174         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
 175         (ravenscar_thread_target::store_registers)
 176         (ravenscar_thread_target::prepare_to_store): Update.
 177         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
 178         Remove.
 179         (struct ppc_ravenscar_powerpc_ops): Derive from
 180         ravenscar_arch_ops.
 181         (ppc_ravenscar_powerpc_ops::fetch_registers)
 182         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
 183         (ppc_ravenscar_powerpc_ops): Redefine.
 184         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
 185         (ppc_ravenscar_e500_ops::fetch_registers)
 186         (ppc_ravenscar_e500_ops::store_registers): Now methods.
 187         (ppc_ravenscar_e500_ops): Redefine.
 188         * aarch64-ravenscar-thread.c
 189         (aarch64_ravenscar_generic_prepare_to_store): Remove.
 190         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
 191         (aarch64_ravenscar_fetch_registers)
 192         (aarch64_ravenscar_store_registers): Now methods.
 193         (aarch64_ravenscar_ops): Redefine.
 194
 195 2019-02-15  Tom Tromey  <tromey@adacore.com>
 196
 197         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
 198         (ravenscar_thread_target::stopped_by_hw_breakpoint)
 199         (ravenscar_thread_target::stopped_by_watchpoint)
 200         (ravenscar_thread_target::stopped_data_address)
 201         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
 202
 203 2019-02-15  Tom Tromey  <tromey@adacore.com>
 204
 205         * ravenscar-thread.c: Fix some typos.
 206
 207 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 208             Tom Tromey  <tromey@adacore.com>
 209
 210         * ada-lang.c (ada_exception_sal): Change addr_string to a
 211         std::string.
 212         (create_ada_exception_catchpoint): Update.
 213
 214 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 215             Tom Tromey  <tromey@adacore.com>
 216
 217         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
 218         (bp_location_ops): Remove.
 219         (base_breakpoint_allocate_location): Update.
 220         (free_bp_location): Update.
 221         * ada-lang.c (class ada_catchpoint_location)
 222         <ada_catchpoint_location>: Remove ops parameter.
 223         (ada_catchpoint_location_dtor): Remove.
 224         (ada_catchpoint_location_ops): Remove.
 225         (allocate_location_exception): Update.
 226         * breakpoint.h (struct bp_location_ops): Remove.
 227         (class bp_location) <bp_location>: Remove bp_location_ops
 228         parameter.
 229         <~bp_location>: Add destructor.
 230         <ops>: Remove.
 231
 232 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 233             Pedro Alves  <palves@redhat.com>
 234
 235         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
 236         'PATH_MAX'.
 237
 238 2019-02-14  David Michael  <fedora.dm0@gmail.com>
 239             Samuel Thibault  <samuel.thibault@gnu.org>
 240             Thomas Schwinge  <thomas@codesourcery.com>
 241
 242         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
 243         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
 244
 245 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 246
 247         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
 248         (check_empty): Use "const char *".
 249
 250         * gnu-nat.c (gnu_nat_target::detach): Instead of
 251         'detach_inferior (pid)' call
 252         'detach_inferior (find_inferior_pid (pid))'.
 253
 254         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
 255         'nat/fork-inferior.o'.
 256         * gnu-nat.c: #include "nat/fork-inferior.h".
 257
 258         * gnu-nat.c (gnu_nat_target::detach): Instead of
 259         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
 260         * gnu-nat.h: #include "inf-child.h".
 261         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
 262         'i386_gnu_nat_target::fetch_registers'.
 263         (gnu_store_registers): Rename/move to
 264         'i386_gnu_nat_target::store_registers'.
 265
 266         * config/i386/nm-i386gnu.h: Don't "#include" any files.
 267         * gnu-nat.h (mach_thread_info): New function.
 268         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
 269
 270         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
 271
 272 2019-02-14  Frederic Konrad  <konrad@adacore.com>
 273
 274         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
 275
 276 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
 277
 278         * windows-nat.c (windows_add_thread): Add new parameter
 279         "main_thread_p" with default value set to false.  Update
 280         function documentation as well as all callers.
 281         (windows_delete_thread): Likewise.
 282         (fake_create_process): Update call to windows_add_thread.
 283         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
 284         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
 285         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
 286         call to windows_delete_thread.
 287
 288 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
 289
 290         * MAINTAINERS: Add Andrew Burgess as global maintainer.
 291
 292 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 293
 294         * symfile.c (find_separate_debug_file): Use canonical path of
 295         sysroot with child_path instead of gdb_sysroot if it is valid.
 296
 297 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 298
 299         * symfile.c (find_separate_debug_file): Use child_path to
 300         determine if an object file is under a sysroot.
 301
 302 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 303
 304         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 305         unittests/child-path-selftests.c.
 306         * common/pathstuff.c (child_path): New function.
 307         * common/pathstuff.h (child_path): New prototype.
 308         * unittests/child-path-selftests.c: New file.
 309
 310 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 311
 312         * symfile.c (find_separate_debug_file): Look for separate debug
 313         files in debug directories under the sysroot.
 314
 315 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 316
 317         * symtab.h (struct minimal_symbol data_p): New const method.
 318         (struct minimal_symbol text_p): Likewise.
 319         * symtab.c (output_source_filename): Use file name style
 320         to print file name.
 321         (print_symbol_info): Likewise.
 322         (print_msymbol_info): Use address style to print addresses.
 323         Use function name style to print executable text symbols.
 324         (expand_symtab_containing_pc): Use data_p.
 325         (find_pc_sect_compunit_symtab): Likewise.
 326
 327 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 328
 329         * breakpoint.c (describe_other_breakpoints): Use address style
 330         to print addresses.
 331         (say_where): Likewise.
 332
 333 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 334
 335         * ada-typeprint.c (print_func_type): Print function name
 336         style to print function name.
 337         * c-typeprint.c (c_print_type_1): Likewise.
 338
 339 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
 340
 341         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
 342         for execve.
 343
 344 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 345
 346         * c-exp.y (direct_abs_decl): Use emplace_back to record the
 347         type_stack.
 348
 349 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
 350
 351         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
 352         TYPE_CODE_REF types.
 353
 354 2019-02-08  Jim Wilson  <jimw@sifive.com>
 355
 356         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
 357         (riscv_linux_fregset): New.
 358         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
 359
 360 2019-02-07  Tom Tromey  <tom@tromey.com>
 361
 362         * thread.c (thread_cancel_execution_command): Update.
 363         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
 364         methods.
 365         (struct thread_fsm_ops): Remove.
 366         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
 367         (thread_fsm_should_stop, thread_fsm_return_value)
 368         (thread_fsm_set_finished, thread_fsm_finished_p)
 369         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
 370         Don't declare.
 371         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
 372         * infrun.c (clear_proceed_status_thread)
 373         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
 374         (print_stop_event): Update.
 375         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
 376         Add constructor.
 377         (step_command_fsm_ops): Remove.
 378         (new_step_command_fsm): Remove.
 379         (step_1): Update.
 380         (step_command_fsm::should_stop): Rename from
 381         step_command_fsm_should_stop.
 382         (step_command_fsm::clean_up): Rename from
 383         step_command_fsm_clean_up.
 384         (step_command_fsm::do_async_reply_reason): Rename from
 385         step_command_fsm_async_reply_reason.
 386         (struct until_next_fsm): Inherit from thread_fsm.  Add
 387         constructor.
 388         (until_next_fsm_ops): Remove.
 389         (new_until_next_fsm): Remove.
 390         (until_next_fsm::should_stop): Rename from
 391         until_next_fsm_should_stop.
 392         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
 393         (until_next_fsm::do_async_reply_reason): Rename from
 394         until_next_fsm_async_reply_reason.
 395         (struct finish_command_fsm): Inherit from thread_fsm.  Add
 396         constructor.  Change type of breakpoint.
 397         (finish_command_fsm_ops): Remove.
 398         (new_finish_command_fsm): Remove.
 399         (finish_command_fsm::should_stop): Rename from
 400         finish_command_fsm_should_stop.
 401         (finish_command_fsm::clean_up): Rename from
 402         finish_command_fsm_clean_up.
 403         (finish_command_fsm::return_value): Rename from
 404         finish_command_fsm_return_value.
 405         (finish_command_fsm::do_async_reply_reason): Rename from
 406         finish_command_fsm_async_reply_reason.
 407         (finish_command): Update.
 408         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
 409         Add constructor.
 410         (call_thread_fsm_ops): Remove.
 411         (call_thread_fsm::call_thread_fsm): Rename from
 412         new_call_thread_fsm.
 413         (call_thread_fsm::should_stop): Rename from
 414         call_thread_fsm_should_stop.
 415         (call_thread_fsm::should_notify_stop): Rename from
 416         call_thread_fsm_should_notify_stop.
 417         (run_inferior_call, call_function_by_hand_dummy): Update.
 418         * cli/cli-interp.c (should_print_stop_to_console): Update.
 419         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
 420         Add constructor.  Change type of location_breakpoint,
 421         caller_breakpoint.
 422         (until_break_fsm_ops): Remove.
 423         (new_until_break_fsm): Remove.
 424         (until_break_fsm::should_stop): Rename from
 425         until_break_fsm_should_stop.
 426         (until_break_fsm::clean_up): Rename from
 427         until_break_fsm_clean_up.
 428         (until_break_fsm::do_async_reply_reason): Rename from
 429         until_break_fsm_async_reply_reason.
 430         (until_break_command): Update.
 431         * thread-fsm.c: Remove.
 432         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
 433
 434 2019-02-07  Tom Tromey  <tom@tromey.com>
 435
 436         * yy-remap.h: Add include guard.
 437         * xtensa-tdep.h: Add include guard.
 438         * xcoffread.h: Rename include guard.
 439         * varobj-iter.h: Add include guard.
 440         * tui/tui.h: Rename include guard.
 441         * tui/tui-winsource.h: Rename include guard.
 442         * tui/tui-wingeneral.h: Rename include guard.
 443         * tui/tui-windata.h: Rename include guard.
 444         * tui/tui-win.h: Rename include guard.
 445         * tui/tui-stack.h: Rename include guard.
 446         * tui/tui-source.h: Rename include guard.
 447         * tui/tui-regs.h: Rename include guard.
 448         * tui/tui-out.h: Rename include guard.
 449         * tui/tui-layout.h: Rename include guard.
 450         * tui/tui-io.h: Rename include guard.
 451         * tui/tui-hooks.h: Rename include guard.
 452         * tui/tui-file.h: Rename include guard.
 453         * tui/tui-disasm.h: Rename include guard.
 454         * tui/tui-data.h: Rename include guard.
 455         * tui/tui-command.h: Rename include guard.
 456         * tic6x-tdep.h: Add include guard.
 457         * target/waitstatus.h: Rename include guard.
 458         * target/wait.h: Rename include guard.
 459         * target/target.h: Rename include guard.
 460         * target/resume.h: Rename include guard.
 461         * target-float.h: Rename include guard.
 462         * stabsread.h: Add include guard.
 463         * rs6000-tdep.h: Add include guard.
 464         * riscv-fbsd-tdep.h: Add include guard.
 465         * regformats/regdef.h: Rename include guard.
 466         * record.h: Rename include guard.
 467         * python/python.h: Rename include guard.
 468         * python/python-internal.h: Rename include guard.
 469         * python/py-stopevent.h: Rename include guard.
 470         * python/py-ref.h: Rename include guard.
 471         * python/py-record.h: Rename include guard.
 472         * python/py-record-full.h: Rename include guard.
 473         * python/py-record-btrace.h: Rename include guard.
 474         * python/py-instruction.h: Rename include guard.
 475         * python/py-events.h: Rename include guard.
 476         * python/py-event.h: Rename include guard.
 477         * procfs.h: Add include guard.
 478         * proc-utils.h: Add include guard.
 479         * p-lang.h: Add include guard.
 480         * or1k-tdep.h: Rename include guard.
 481         * observable.h: Rename include guard.
 482         * nto-tdep.h: Rename include guard.
 483         * nat/x86-linux.h: Rename include guard.
 484         * nat/x86-linux-dregs.h: Rename include guard.
 485         * nat/x86-gcc-cpuid.h: Add include guard.
 486         * nat/x86-dregs.h: Rename include guard.
 487         * nat/x86-cpuid.h: Rename include guard.
 488         * nat/ppc-linux.h: Rename include guard.
 489         * nat/mips-linux-watch.h: Rename include guard.
 490         * nat/linux-waitpid.h: Rename include guard.
 491         * nat/linux-ptrace.h: Rename include guard.
 492         * nat/linux-procfs.h: Rename include guard.
 493         * nat/linux-osdata.h: Rename include guard.
 494         * nat/linux-nat.h: Rename include guard.
 495         * nat/linux-namespaces.h: Rename include guard.
 496         * nat/linux-btrace.h: Rename include guard.
 497         * nat/glibc_thread_db.h: Rename include guard.
 498         * nat/gdb_thread_db.h: Rename include guard.
 499         * nat/gdb_ptrace.h: Rename include guard.
 500         * nat/fork-inferior.h: Rename include guard.
 501         * nat/amd64-linux-siginfo.h: Rename include guard.
 502         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
 503         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
 504         * nat/aarch64-linux.h: Rename include guard.
 505         * nat/aarch64-linux-hw-point.h: Rename include guard.
 506         * mn10300-tdep.h: Add include guard.
 507         * mips-linux-tdep.h: Add include guard.
 508         * mi/mi-parse.h: Rename include guard.
 509         * mi/mi-out.h: Rename include guard.
 510         * mi/mi-main.h: Rename include guard.
 511         * mi/mi-interp.h: Rename include guard.
 512         * mi/mi-getopt.h: Rename include guard.
 513         * mi/mi-console.h: Rename include guard.
 514         * mi/mi-common.h: Rename include guard.
 515         * mi/mi-cmds.h: Rename include guard.
 516         * mi/mi-cmd-break.h: Rename include guard.
 517         * m2-lang.h: Add include guard.
 518         * location.h: Rename include guard.
 519         * linux-record.h: Rename include guard.
 520         * linux-nat.h: Add include guard.
 521         * linux-fork.h: Add include guard.
 522         * i386-darwin-tdep.h: Rename include guard.
 523         * hppa-linux-offsets.h: Add include guard.
 524         * guile/guile.h: Rename include guard.
 525         * guile/guile-internal.h: Rename include guard.
 526         * gnu-nat.h: Rename include guard.
 527         * gdb-stabs.h: Rename include guard.
 528         * frv-tdep.h: Add include guard.
 529         * f-lang.h: Add include guard.
 530         * event-loop.h: Add include guard.
 531         * darwin-nat.h: Rename include guard.
 532         * cp-abi.h: Rename include guard.
 533         * config/sparc/nm-sol2.h: Rename include guard.
 534         * config/nm-nto.h: Rename include guard.
 535         * config/nm-linux.h: Add include guard.
 536         * config/i386/nm-i386gnu.h: Rename include guard.
 537         * config/djgpp/nl_types.h: Rename include guard.
 538         * config/djgpp/langinfo.h: Rename include guard.
 539         * compile/gcc-cp-plugin.h: Add include guard.
 540         * compile/gcc-c-plugin.h: Add include guard.
 541         * compile/compile.h: Rename include guard.
 542         * compile/compile-object-run.h: Rename include guard.
 543         * compile/compile-object-load.h: Rename include guard.
 544         * compile/compile-internal.h: Rename include guard.
 545         * compile/compile-cplus.h: Rename include guard.
 546         * compile/compile-c.h: Rename include guard.
 547         * common/xml-utils.h: Rename include guard.
 548         * common/x86-xstate.h: Rename include guard.
 549         * common/version.h: Rename include guard.
 550         * common/vec.h: Rename include guard.
 551         * common/tdesc.h: Rename include guard.
 552         * common/selftest.h: Rename include guard.
 553         * common/scoped_restore.h: Rename include guard.
 554         * common/scoped_mmap.h: Rename include guard.
 555         * common/scoped_fd.h: Rename include guard.
 556         * common/safe-iterator.h: Rename include guard.
 557         * common/run-time-clock.h: Rename include guard.
 558         * common/refcounted-object.h: Rename include guard.
 559         * common/queue.h: Rename include guard.
 560         * common/ptid.h: Rename include guard.
 561         * common/print-utils.h: Rename include guard.
 562         * common/preprocessor.h: Rename include guard.
 563         * common/pathstuff.h: Rename include guard.
 564         * common/observable.h: Rename include guard.
 565         * common/netstuff.h: Rename include guard.
 566         * common/job-control.h: Rename include guard.
 567         * common/host-defs.h: Rename include guard.
 568         * common/gdb_wait.h: Rename include guard.
 569         * common/gdb_vecs.h: Rename include guard.
 570         * common/gdb_unlinker.h: Rename include guard.
 571         * common/gdb_unique_ptr.h: Rename include guard.
 572         * common/gdb_tilde_expand.h: Rename include guard.
 573         * common/gdb_sys_time.h: Rename include guard.
 574         * common/gdb_string_view.h: Rename include guard.
 575         * common/gdb_splay_tree.h: Rename include guard.
 576         * common/gdb_setjmp.h: Rename include guard.
 577         * common/gdb_ref_ptr.h: Rename include guard.
 578         * common/gdb_optional.h: Rename include guard.
 579         * common/gdb_locale.h: Rename include guard.
 580         * common/gdb_assert.h: Rename include guard.
 581         * common/filtered-iterator.h: Rename include guard.
 582         * common/filestuff.h: Rename include guard.
 583         * common/fileio.h: Rename include guard.
 584         * common/environ.h: Rename include guard.
 585         * common/common-utils.h: Rename include guard.
 586         * common/common-types.h: Rename include guard.
 587         * common/common-regcache.h: Rename include guard.
 588         * common/common-inferior.h: Rename include guard.
 589         * common/common-gdbthread.h: Rename include guard.
 590         * common/common-exceptions.h: Rename include guard.
 591         * common/common-defs.h: Rename include guard.
 592         * common/common-debug.h: Rename include guard.
 593         * common/cleanups.h: Rename include guard.
 594         * common/buffer.h: Rename include guard.
 595         * common/btrace-common.h: Rename include guard.
 596         * common/break-common.h: Rename include guard.
 597         * cli/cli-utils.h: Rename include guard.
 598         * cli/cli-style.h: Rename include guard.
 599         * cli/cli-setshow.h: Rename include guard.
 600         * cli/cli-script.h: Rename include guard.
 601         * cli/cli-interp.h: Rename include guard.
 602         * cli/cli-decode.h: Rename include guard.
 603         * cli/cli-cmds.h: Rename include guard.
 604         * charset-list.h: Add include guard.
 605         * buildsym-legacy.h: Rename include guard.
 606         * bfin-tdep.h: Add include guard.
 607         * ax.h: Rename include guard.
 608         * arm-linux-tdep.h: Add include guard.
 609         * arm-fbsd-tdep.h: Add include guard.
 610         * arch/xtensa.h: Rename include guard.
 611         * arch/tic6x.h: Add include guard.
 612         * arch/i386.h: Add include guard.
 613         * arch/arm.h: Rename include guard.
 614         * arch/arm-linux.h: Rename include guard.
 615         * arch/arm-get-next-pcs.h: Rename include guard.
 616         * arch/amd64.h: Add include guard.
 617         * arch/aarch64-insn.h: Rename include guard.
 618         * arch-utils.h: Rename include guard.
 619         * annotate.h: Add include guard.
 620         * amd64-darwin-tdep.h: Rename include guard.
 621         * aarch64-linux-tdep.h: Add include guard.
 622         * aarch64-fbsd-tdep.h: Add include guard.
 623         * aarch32-linux-nat.h: Add include guard.
 624
 625 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 626
 627         * macrotab.c (macro_define_internal): New function that
 628         factorizes macro_define_object_internal and macro_define_function
 629         code.
 630         (macro_define_object_internal): Use macro_define_internal.
 631         (macro_define_function): Likewise.
 632
 633 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 634
 635         * macrocmd.c (extract_identifier): Return
 636         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
 637         callers.
 638
 639 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
 640
 641         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
 642
 643 2019-02-05  Tom Tromey  <tom@tromey.com>
 644
 645         * target.c (target_stack::unpush): Move assertion earlier.
 646
 647 2019-01-30  Tom Tromey  <tom@tromey.com>
 648
 649         PR python/23615:
 650         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
 651         (gdbpy_parse_and_eval): Likewise.
 652         * python/python-internal.h (gdbpy_allow_threads): New class.
 653
 654 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
 655
 656         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
 657         (aarch64_fbsd_fpregmap): Move earlier.
 658         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
 659         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 660         instead of individual calls to trad_frame_set_reg_addr.
 661         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
 662         earlier.
 663         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
 664         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 665         instead of individual calls to trad_frame_set_reg_addr.
 666
 667 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
 668
 669         * CONTRIBUTE: Replace contribution list with wiki link.
 670
 671 2019-01-25  Tom Tromey  <tom@tromey.com>
 672
 673         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
 674
 675 2019-01-25  Tom Tromey  <tom@tromey.com>
 676
 677         * xtensa-linux-nat.c: Fix common/ includes.
 678         * xml-support.h: Fix common/ includes.
 679         * xml-support.c: Fix common/ includes.
 680         * x86-linux-nat.c: Fix common/ includes.
 681         * windows-nat.c: Fix common/ includes.
 682         * varobj.h: Fix common/ includes.
 683         * varobj.c: Fix common/ includes.
 684         * value.c: Fix common/ includes.
 685         * valops.c: Fix common/ includes.
 686         * utils.c: Fix common/ includes.
 687         * unittests/xml-utils-selftests.c: Fix common/ includes.
 688         * unittests/utils-selftests.c: Fix common/ includes.
 689         * unittests/unpack-selftests.c: Fix common/ includes.
 690         * unittests/tracepoint-selftests.c: Fix common/ includes.
 691         * unittests/style-selftests.c: Fix common/ includes.
 692         * unittests/string_view-selftests.c: Fix common/ includes.
 693         * unittests/scoped_restore-selftests.c: Fix common/ includes.
 694         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
 695         * unittests/scoped_fd-selftests.c: Fix common/ includes.
 696         * unittests/rsp-low-selftests.c: Fix common/ includes.
 697         * unittests/parse-connection-spec-selftests.c: Fix common/
 698         includes.
 699         * unittests/optional-selftests.c: Fix common/ includes.
 700         * unittests/offset-type-selftests.c: Fix common/ includes.
 701         * unittests/observable-selftests.c: Fix common/ includes.
 702         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
 703         * unittests/memrange-selftests.c: Fix common/ includes.
 704         * unittests/memory-map-selftests.c: Fix common/ includes.
 705         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
 706         * unittests/function-view-selftests.c: Fix common/ includes.
 707         * unittests/environ-selftests.c: Fix common/ includes.
 708         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
 709         * unittests/common-utils-selftests.c: Fix common/ includes.
 710         * unittests/cli-utils-selftests.c: Fix common/ includes.
 711         * unittests/array-view-selftests.c: Fix common/ includes.
 712         * ui-file.c: Fix common/ includes.
 713         * tui/tui-io.c: Fix common/ includes.
 714         * tracepoint.h: Fix common/ includes.
 715         * tracepoint.c: Fix common/ includes.
 716         * tracefile-tfile.c: Fix common/ includes.
 717         * top.h: Fix common/ includes.
 718         * top.c: Fix common/ includes.
 719         * thread.c: Fix common/ includes.
 720         * target/waitstatus.h: Fix common/ includes.
 721         * target/waitstatus.c: Fix common/ includes.
 722         * target.h: Fix common/ includes.
 723         * target.c: Fix common/ includes.
 724         * target-memory.c: Fix common/ includes.
 725         * target-descriptions.c: Fix common/ includes.
 726         * symtab.h: Fix common/ includes.
 727         * symfile.c: Fix common/ includes.
 728         * stap-probe.c: Fix common/ includes.
 729         * spu-linux-nat.c: Fix common/ includes.
 730         * sparc-nat.c: Fix common/ includes.
 731         * source.c: Fix common/ includes.
 732         * solib.c: Fix common/ includes.
 733         * solib-target.c: Fix common/ includes.
 734         * ser-unix.c: Fix common/ includes.
 735         * ser-tcp.c: Fix common/ includes.
 736         * ser-pipe.c: Fix common/ includes.
 737         * ser-base.c: Fix common/ includes.
 738         * selftest-arch.c: Fix common/ includes.
 739         * s12z-tdep.c: Fix common/ includes.
 740         * rust-exp.y: Fix common/ includes.
 741         * rs6000-aix-tdep.c: Fix common/ includes.
 742         * riscv-tdep.c: Fix common/ includes.
 743         * remote.c: Fix common/ includes.
 744         * remote-notif.h: Fix common/ includes.
 745         * remote-fileio.h: Fix common/ includes.
 746         * remote-fileio.c: Fix common/ includes.
 747         * regcache.h: Fix common/ includes.
 748         * regcache.c: Fix common/ includes.
 749         * record-btrace.c: Fix common/ includes.
 750         * python/python.c: Fix common/ includes.
 751         * python/py-type.c: Fix common/ includes.
 752         * python/py-inferior.c: Fix common/ includes.
 753         * progspace.h: Fix common/ includes.
 754         * producer.c: Fix common/ includes.
 755         * procfs.c: Fix common/ includes.
 756         * proc-api.c: Fix common/ includes.
 757         * printcmd.c: Fix common/ includes.
 758         * ppc-linux-nat.c: Fix common/ includes.
 759         * parser-defs.h: Fix common/ includes.
 760         * osdata.c: Fix common/ includes.
 761         * obsd-nat.c: Fix common/ includes.
 762         * nat/x86-linux.c: Fix common/ includes.
 763         * nat/x86-linux-dregs.c: Fix common/ includes.
 764         * nat/x86-dregs.h: Fix common/ includes.
 765         * nat/x86-dregs.c: Fix common/ includes.
 766         * nat/ppc-linux.c: Fix common/ includes.
 767         * nat/mips-linux-watch.h: Fix common/ includes.
 768         * nat/mips-linux-watch.c: Fix common/ includes.
 769         * nat/linux-waitpid.c: Fix common/ includes.
 770         * nat/linux-ptrace.h: Fix common/ includes.
 771         * nat/linux-ptrace.c: Fix common/ includes.
 772         * nat/linux-procfs.c: Fix common/ includes.
 773         * nat/linux-personality.c: Fix common/ includes.
 774         * nat/linux-osdata.c: Fix common/ includes.
 775         * nat/linux-namespaces.c: Fix common/ includes.
 776         * nat/linux-btrace.h: Fix common/ includes.
 777         * nat/linux-btrace.c: Fix common/ includes.
 778         * nat/fork-inferior.c: Fix common/ includes.
 779         * nat/amd64-linux-siginfo.c: Fix common/ includes.
 780         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
 781         * nat/aarch64-linux.c: Fix common/ includes.
 782         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
 783         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
 784         * namespace.h: Fix common/ includes.
 785         * mips-linux-tdep.c: Fix common/ includes.
 786         * minsyms.c: Fix common/ includes.
 787         * mi/mi-parse.h: Fix common/ includes.
 788         * mi/mi-main.c: Fix common/ includes.
 789         * mi/mi-cmd-env.c: Fix common/ includes.
 790         * memrange.h: Fix common/ includes.
 791         * memattr.c: Fix common/ includes.
 792         * maint.h: Fix common/ includes.
 793         * maint.c: Fix common/ includes.
 794         * main.c: Fix common/ includes.
 795         * machoread.c: Fix common/ includes.
 796         * location.c: Fix common/ includes.
 797         * linux-thread-db.c: Fix common/ includes.
 798         * linux-nat.c: Fix common/ includes.
 799         * linux-fork.c: Fix common/ includes.
 800         * inline-frame.c: Fix common/ includes.
 801         * infrun.c: Fix common/ includes.
 802         * inflow.c: Fix common/ includes.
 803         * inferior.h: Fix common/ includes.
 804         * inferior.c: Fix common/ includes.
 805         * infcmd.c: Fix common/ includes.
 806         * inf-ptrace.c: Fix common/ includes.
 807         * inf-child.c: Fix common/ includes.
 808         * ia64-linux-nat.c: Fix common/ includes.
 809         * i387-tdep.c: Fix common/ includes.
 810         * i386-tdep.c: Fix common/ includes.
 811         * i386-linux-tdep.c: Fix common/ includes.
 812         * i386-linux-nat.c: Fix common/ includes.
 813         * i386-go32-tdep.c: Fix common/ includes.
 814         * i386-fbsd-tdep.c: Fix common/ includes.
 815         * i386-fbsd-nat.c: Fix common/ includes.
 816         * guile/scm-type.c: Fix common/ includes.
 817         * guile/guile.c: Fix common/ includes.
 818         * go32-nat.c: Fix common/ includes.
 819         * gnu-nat.c: Fix common/ includes.
 820         * gdbthread.h: Fix common/ includes.
 821         * gdbarch-selftests.c: Fix common/ includes.
 822         * gdb_usleep.c: Fix common/ includes.
 823         * gdb_select.h: Fix common/ includes.
 824         * gdb_bfd.c: Fix common/ includes.
 825         * gcore.c: Fix common/ includes.
 826         * fork-child.c: Fix common/ includes.
 827         * findvar.c: Fix common/ includes.
 828         * fbsd-nat.c: Fix common/ includes.
 829         * event-top.c: Fix common/ includes.
 830         * event-loop.c: Fix common/ includes.
 831         * dwarf2read.c: Fix common/ includes.
 832         * dwarf2loc.c: Fix common/ includes.
 833         * dwarf2-frame.c: Fix common/ includes.
 834         * dwarf-index-cache.c: Fix common/ includes.
 835         * dtrace-probe.c: Fix common/ includes.
 836         * disasm-selftests.c: Fix common/ includes.
 837         * defs.h: Fix common/ includes.
 838         * csky-tdep.c: Fix common/ includes.
 839         * cp-valprint.c: Fix common/ includes.
 840         * cp-support.h: Fix common/ includes.
 841         * cp-support.c: Fix common/ includes.
 842         * corelow.c: Fix common/ includes.
 843         * completer.h: Fix common/ includes.
 844         * completer.c: Fix common/ includes.
 845         * compile/compile.c: Fix common/ includes.
 846         * compile/compile-loc2c.c: Fix common/ includes.
 847         * compile/compile-cplus-types.c: Fix common/ includes.
 848         * compile/compile-cplus-symbols.c: Fix common/ includes.
 849         * command.h: Fix common/ includes.
 850         * cli/cli-dump.c: Fix common/ includes.
 851         * cli/cli-cmds.c: Fix common/ includes.
 852         * charset.c: Fix common/ includes.
 853         * build-id.c: Fix common/ includes.
 854         * btrace.h: Fix common/ includes.
 855         * btrace.c: Fix common/ includes.
 856         * breakpoint.h: Fix common/ includes.
 857         * breakpoint.c: Fix common/ includes.
 858         * ax.h:
 859         (enum agent_op): Fix common/ includes.
 860         * ax-general.c (struct aop_map): Fix common/ includes.
 861         * ax-gdb.c: Fix common/ includes.
 862         * auxv.c: Fix common/ includes.
 863         * auto-load.c: Fix common/ includes.
 864         * arm-tdep.c: Fix common/ includes.
 865         * arch/riscv.c: Fix common/ includes.
 866         * arch/ppc-linux-common.c: Fix common/ includes.
 867         * arch/i386.c: Fix common/ includes.
 868         * arch/arm.c: Fix common/ includes.
 869         * arch/arm-linux.c: Fix common/ includes.
 870         * arch/arm-get-next-pcs.c: Fix common/ includes.
 871         * arch/amd64.c: Fix common/ includes.
 872         * arch/aarch64.c: Fix common/ includes.
 873         * arch/aarch64-insn.c: Fix common/ includes.
 874         * arch-utils.c: Fix common/ includes.
 875         * amd64-windows-tdep.c: Fix common/ includes.
 876         * amd64-tdep.c: Fix common/ includes.
 877         * amd64-sol2-tdep.c: Fix common/ includes.
 878         * amd64-obsd-tdep.c: Fix common/ includes.
 879         * amd64-nbsd-tdep.c: Fix common/ includes.
 880         * amd64-linux-tdep.c: Fix common/ includes.
 881         * amd64-linux-nat.c: Fix common/ includes.
 882         * amd64-fbsd-tdep.c: Fix common/ includes.
 883         * amd64-fbsd-nat.c: Fix common/ includes.
 884         * amd64-dicos-tdep.c: Fix common/ includes.
 885         * amd64-darwin-tdep.c: Fix common/ includes.
 886         * agent.c: Fix common/ includes.
 887         * ada-lang.h: Fix common/ includes.
 888         * ada-lang.c: Fix common/ includes.
 889         * aarch64-tdep.c: Fix common/ includes.
 890
 891 2019-01-25  Tom Tromey  <tom@tromey.com>
 892
 893         * common/create-version.sh: Use common/version.h.
 894
 895 2019-01-24  Pedro Alves  <palves@redhat.com>
 896
 897         * infrun.c (signal_stop, signal_print, signal_program)
 898         (signal_catch, signal_pass): Now arrays instead of pointers.
 899         (update_signals_program_target, do_target_resume)
 900         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
 901         * linux-nat.c (linux_nat_target::pass_signals)
 902         (linux_nat_target::create_inferior, linux_nat_target::attach):
 903         Adjust.
 904         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
 905         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
 906         * procfs.c (procfs_target::pass_signals): Adjust.
 907         * record-full.c (record_full_target::resume): Adjust.
 908         * remote.c (remote_target::pass_signals)
 909         (remote_target::program_signals): Adjust.
 910         * target-debug.h (target_debug_print_signals): Now takes a
 911         gdb::array_view as parameter.  Adjust.
 912         * target.h (target_ops) <pass_signals, program_signals>: Replace
 913         pointer and length parameters with gdb::array_view.
 914         (target_pass_signals, target_program_signals): Likewise.
 915         * target-delegates.c: Regenerate.
 916
 917 2019-01-24  Pedro Alves  <palves@redhat.com>
 918
 919         * common/forward-scope-exit.h
 920         (forward_scope_exit::forward_scope_exit): Pass arguments to
 921         m_bind_function directly, instead of creating a std::bind and
 922         copying that.
 923
 924 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
 925
 926         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 927         for static members.
 928         (pass_in_v_vfp_candidate): Likewise.
 929
 930 2019-01-23  Tom Tromey  <tom@tromey.com>
 931             Pedro Alves  <palves@redhat.com>
 932
 933         * regcache.c (class regcache_invalidator): Remove.
 934         (regcache::raw_write): Use make_scope_exit.
 935
 936 2019-01-23  Tom Tromey  <tom@tromey.com>
 937
 938         * ui-out.h (class ui_out_emit_type): Update comment.
 939
 940 2019-01-23  Tom Tromey  <tom@tromey.com>
 941
 942         * infrun.c (fetch_inferior_event): Update comment.
 943
 944 2019-01-23  Tom Tromey  <tom@tromey.com>
 945             Pedro Alves  <palves@redhat.com>
 946
 947         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
 948         parameter.
 949         (fetch_inferior_event): Use SCOPE_EXIT.
 950
 951
 952 2019-01-23  Tom Tromey  <tom@tromey.com>
 953             Pedro Alves  <palves@redhat.com>
 954
 955         * infrun.c (disable_thread_events): Delete.
 956         (stop_all_threads): Use SCOPE_EXIT.
 957
 958 2019-01-23  Tom Tromey  <tom@tromey.com>
 959             Pedro Alves  <palves@redhat.com>
 960
 961         * symfile.c: Include forward-scope-exit.h.
 962         (clear_symtab_users_cleanup): Replace forward declaration with
 963         a FORWARD_SCOPE_EXIT.
 964         (syms_from_objfile_1): Use the forward_scope_exit and
 965         gdb::optional instead of cleanup_function.
 966         (reread_symbols): Use the forward_scope_exit instead of
 967         cleanup_function.
 968         (clear_symtab_users_cleanup): Remove function.
 969
 970 2019-01-23  Tom Tromey  <tom@tromey.com>
 971             Pedro Alves  <palves@redhat.com>
 972
 973         * linux-nat.c: Include scope-exit.h.
 974         (cleanup_target_stop): Remove.
 975         (linux_nat_target::static_tracepoint_markers_by_strid): Use
 976         SCOPE_EXIT.
 977
 978 2019-01-23  Tom Tromey  <tom@tromey.com>
 979             Pedro Alves  <palves@redhat.com>
 980
 981         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
 982         (call_function_by_hand_dummy): Use SCOPE_EXIT.
 983
 984 2019-01-23  Tom Tromey  <tom@tromey.com>
 985             Andrew Burgess  <andrew.burgess@embecosm.com>
 986             Pedro Alves  <palves@redhat.com>
 987
 988         * infrun.c (fetch_inferior_event): Use scope_exit.
 989         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
 990         * top.c (execute_command): Use scope_exit.
 991         * breakpoint.c (bpstat_do_actions): Use scope_exit.
 992         * utils.c (do_bpstat_clear_actions_cleanup)
 993         (make_bpstat_clear_actions_cleanup): Remove.
 994
 995 2019-01-23  Tom Tromey  <tom@tromey.com>
 996             Pedro Alves  <palves@redhat.com>
 997
 998         * infrun.c: Include "common/scope-exit.h"
 999         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1000         (wait_for_inferior): Use SCOPE_EXIT.
1001         (fetch_inferior_event): Use scope_exit.
1002
1003 2019-01-23  Tom Tromey  <tom@tromey.com>
1004             Pedro Alves  <palves@redhat.com>
1005
1006         * breakpoint.c (create_breakpoint): Remove cleanup.
1007
1008 2019-01-23  Tom Tromey  <tom@tromey.com>
1009             Andrew Burgess  <andrew.burgess@embecosm.com>
1010             Pedro Alves  <palves@redhat.com>
1011
1012 2019-01-23  Pedro Alves  <palves@redhat.com>
1013
1014         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1015
1016 2019-01-23  Pedro Alves  <palves@redhat.com>
1017             Andrew Burgess  <andrew.burgess@embecosm.com>
1018
1019         * gdbthread.h: Include "common/forward-scope-exit.h".
1020         (scoped_finish_thread_state): Redefine custom class in terms of
1021         forward_scope_exit.
1022
1023 2019-01-23  Pedro Alves  <palves@redhat.com>
1024             Andrew Burgess  <andrew.burgess@embecosm.com>
1025
1026         * common/forward-scope-exit.h: New file.
1027
1028 2019-01-23  Pedro Alves  <palves@redhat.com>
1029             Andrew Burgess  <andrew.burgess@embecosm.com>
1030             Tom Tromey  <tom@tromey.com>
1031
1032         * common/scope-exit.h: New file.
1033
1034 2019-01-23  Pedro Alves  <palves@redhat.com>
1035
1036         * common/preprocessor.h (ESC): Rename to ...
1037         (ESC_PARENS): ... this.
1038         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1039         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1040
1041 2019-01-23  Tom Tromey  <tom@tromey.com>
1042
1043         * language.h (class scoped_switch_to_sym_language_if_auto):
1044         Initialize m_lang in both cases.
1045
1046 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1047
1048         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1049         with XCNEW.
1050
1051 2019-01-22  Tom Tromey  <tom@tromey.com>
1052
1053         * corelow.c: Do not include sys/file.h.
1054
1055 2019-01-22  Tom Tromey  <tom@tromey.com>
1056
1057         * tui/tui-wingeneral.h: Include gdb_curses.h.
1058
1059 2019-01-22  Tom Tromey  <tom@tromey.com>
1060
1061         * source-cache.h (class source_cache) <get_source_lines,
1062         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1063
1064 2019-01-22  Tom Tromey  <tom@tromey.com>
1065
1066         * remote-fileio.h (struct remote_target): Declare.
1067
1068 2019-01-22  Tom Tromey  <tom@tromey.com>
1069
1070         * python/py-arch.c: Do not include py-ref.h.
1071         * python/py-bpevent.c: Do not include py-ref.h.
1072         * python/py-cmd.c: Do not include py-ref.h.
1073         * python/py-continueevent.c: Do not include py-ref.h.
1074         * python/py-event.h: Do not include py-ref.h.
1075         * python/py-evtregistry.c: Do not include py-ref.h.
1076         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1077         * python/py-frame.c: Do not include py-ref.h.
1078         * python/py-framefilter.c: Do not include py-ref.h.
1079         * python/py-function.c: Do not include py-ref.h.
1080         * python/py-infevents.c: Do not include py-ref.h.
1081         * python/py-linetable.c: Do not include py-ref.h.
1082         * python/py-objfile.c: Do not include py-ref.h.
1083         * python/py-param.c: Do not include py-ref.h.
1084         * python/py-prettyprint.c: Do not include py-ref.h.
1085         * python/py-progspace.c: Do not include py-ref.h.
1086         * python/py-symbol.c: Do not include py-ref.h.
1087         * python/py-symtab.c: Do not include py-ref.h.
1088         * python/py-type.c: Do not include py-ref.h.
1089         * python/py-unwind.c: Do not include py-ref.h.
1090         * python/py-utils.c: Do not include py-ref.h.
1091         * python/py-value.c: Do not include py-ref.h.
1092         * python/py-varobj.c: Do not include py-ref.h.
1093         * python/py-xmethods.c: Do not include py-ref.h.
1094         * python/python.c: Do not include py-ref.h.
1095         * varobj.c: Do not include py-ref.h.
1096
1097 2019-01-22  Tom Tromey  <tom@tromey.com>
1098
1099         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1100         keyword for bcache.
1101
1102 2019-01-22  Tom Tromey  <tom@tromey.com>
1103
1104         * compile/compile-cplus-types.c: Remove a comment by #include.
1105
1106 2019-01-22  Tom Tromey  <tom@tromey.com>
1107
1108         * compile/gcc-c-plugin.h: Include compile-internal.h.
1109
1110 2019-01-22  Tom Tromey  <tom@tromey.com>
1111
1112         * stabsread.c (EXTERN): Do not define.
1113         (symnum, next_symbol_text_func, processing_gcc_compilation)
1114         (within_function, global_sym_chain, global_stabs)
1115         (previous_stab_code, this_object_header_files)
1116         (n_this_object_header_files)
1117         (n_allocated_this_object_header_files): Define.
1118         * stabsread.h (EXTERN): Never define.  Use "extern".
1119
1120 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1121
1122         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1123         history_value.
1124
1125 2019-01-21  Tom Tromey  <tom@tromey.com>
1126
1127         * ui-out.c: Fix includes.
1128         * tui/tui-source.c: Fix includes.
1129         * target.c: Fix includes.
1130         * remote.c: Fix includes.
1131         * regcache.c: Fix includes.
1132         * python/py-block.c: Fix includes.
1133         * printcmd.c: Fix includes.
1134         * or1k-tdep.c: Fix includes.
1135         * mi/mi-main.c: Fix includes.
1136         * m32r-tdep.c: Fix includes.
1137         * csky-tdep.c: Fix includes.
1138         * compile/compile-cplus-types.c: Fix includes.
1139         * cli/cli-interp.c: Fix includes.
1140
1141 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1142
1143         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1144         for padding.
1145
1146 2019-01-16  Tom Tromey  <tom@tromey.com>
1147
1148         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1149         earlier.
1150         (struct objfile) <msymbols_range>: Move from top level.
1151         <msymbols>: New method.
1152         (class objfile_msymbols): Remove.
1153         * symtab.c (default_collect_symbol_completion_matches_break_on):
1154         Update.
1155         * symmisc.c (dump_msymbols): Update.
1156         * stabsread.c (scan_file_globals): Update.
1157         * objc-lang.c (info_selectors_command, info_classes_command)
1158         (find_methods): Update.
1159         * minsyms.c (find_solib_trampoline_target): Update.
1160         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1161         * coffread.c (coff_symfile_read): Update.
1162         * ada-lang.c (ada_lookup_simple_minsym)
1163         (ada_collect_symbol_completion_matches): Update.
1164
1165 2019-01-16  Tom Tromey  <tom@tromey.com>
1166
1167         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1168         type.  Remove no-argument constructor.
1169         <iterator::operator++>: Simplify.
1170         <begin>: Update.
1171         <end>: Use minimal_symbol_count.
1172
1173 2019-01-16  Tom Tromey  <tom@tromey.com>
1174
1175         * objfiles.h (struct objfile) <psymtabs>: New method.
1176         (class objfile_psymtabs): Remove.
1177         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1178         typedef.
1179         <range>: New method.
1180         (require_partial_symbols): Change return type.
1181         * psymtab.c (require_partial_symbols)
1182         (psym_expand_symtabs_matching): Update.
1183         * mdebugread.c (parse_partial_symbols): Update.
1184         * dbxread.c (dbx_end_psymtab): Update.
1185
1186 2019-01-15  Tom Tromey  <tom@tromey.com>
1187
1188         * symtab.c (lookup_objfile_from_block)
1189         (lookup_symbol_in_objfile_symtabs)
1190         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1191         (find_line_symtab, info_sources_command)
1192         (default_collect_symbol_completion_matches_break_on)
1193         (make_source_files_completion_list): Update.
1194         * symmisc.c (print_objfile_statistics, dump_objfile)
1195         (maintenance_print_symbols, maintenance_info_symtabs)
1196         (maintenance_check_symtabs, maintenance_info_line_tables):
1197         Update.
1198         * source.c (select_source_symtab)
1199         (forget_cached_source_info_for_objfile): Update.
1200         * objfiles.h (class objfile_compunits): Remove.
1201         (struct objfile) <compunits_range>: New typedef.
1202         (compunits): New method.
1203         * objfiles.c (objfile_relocate1): Update.
1204         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1205         * maint.c (count_symtabs_and_blocks): Update.
1206         * linespec.c (iterate_over_all_matching_symtabs): Update.
1207         * cp-support.c (add_symbol_overload_list_qualified): Update.
1208         * coffread.c (coff_symtab_read): Update.
1209         * ada-lang.c (add_nonlocal_symbols)
1210         (ada_collect_symbol_completion_matches)
1211         (ada_add_global_exceptions): Update.
1212
1213 2019-01-15  Tom Tromey  <tom@tromey.com>
1214
1215         * progspace.h (program_space) <objfiles_safe_range>: New
1216         typedef.
1217         <objfiles_safe>: New method.
1218         * objfiles.h (class all_objfiles_safe): Remove.
1219         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1220         * jit.c (jit_inferior_exit_hook): Update.
1221
1222 2019-01-17  Tom Tromey  <tom@tromey.com>
1223
1224         * progspace.h (program_space) <objfiles_range>: New typedef.
1225         <objfiles>: New method.
1226         <objfiles_head>: Rename from objfiles.
1227         (object_files): Update.
1228         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1229         * guile/scm-pretty-print.c
1230         (ppscm_find_pretty_printer_from_objfiles): Update.
1231         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1232         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1233         Update.
1234         * python/py-progspace.c (pspy_get_objfiles): Update.
1235         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1236         Update.
1237         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1238         (objfpy_lookup_objfile_by_build_id): Update.
1239         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1240         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1241         Update.
1242         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1243         (expand_symtab_containing_pc, lookup_objfile_from_block)
1244         (lookup_static_symbol, basic_lookup_transparent_type)
1245         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1246         (find_line_symtab, info_sources_command)
1247         (default_collect_symbol_completion_matches_break_on)
1248         (make_source_files_completion_list, find_main_name): Update.
1249         * symmisc.c (print_symbol_bcache_statistics)
1250         (print_objfile_statistics, maintenance_print_symbols)
1251         (maintenance_print_msymbols, maintenance_print_objfiles)
1252         (maintenance_info_symtabs, maintenance_check_symtabs)
1253         (maintenance_expand_symtabs, maintenance_info_line_tables):
1254         Update.
1255         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1256         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1257         (map_overlay_command, unmap_overlay_command)
1258         (simple_overlay_update, expand_symtabs_matching)
1259         (map_symbol_filenames): Update.
1260         * symfile-debug.c (set_debug_symfile): Update.
1261         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1262         Update.
1263         * source.c (select_source_symtab, forget_cached_source_info):
1264         Update.
1265         * solib.c (solib_read_symbols): Update.
1266         * solib-spu.c (append_ocl_sos): Update.
1267         * psymtab.c (maintenance_print_psymbols)
1268         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1269         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1270         * printcmd.c (info_symbol_command): Update.
1271         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1272         Update.
1273         * objfiles.h (class all_objfiles): Remove.
1274         * objfiles.c (have_partial_symbols, have_full_symbols)
1275         (have_minimal_symbols, qsort_cmp, update_section_map)
1276         (shared_objfile_contains_address_p)
1277         (default_iterate_over_objfiles_in_search_order): Update.
1278         * objc-lang.c (info_selectors_command, info_classes_command)
1279         (find_methods): Update.
1280         * minsyms.c (find_solib_trampoline_target): Update.
1281         * maint.c (maintenance_info_sections)
1282         (maintenance_translate_address, count_symtabs_and_blocks):
1283         Update.
1284         * main.c (captured_main_1): Update.
1285         * linux-thread-db.c (try_thread_db_load_from_pdir)
1286         (has_libpthread): Update.
1287         * linespec.c (iterate_over_all_matching_symtabs)
1288         (search_minsyms_for_name): Update.
1289         * jit.c (jit_find_objf_with_entry_addr): Update.
1290         * hppa-tdep.c (find_unwind_entry)
1291         (hppa_lookup_stub_minimal_symbol): Update.
1292         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1293         Update.
1294         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1295         (elf_gnu_ifunc_resolve_by_got): Update.
1296         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1297         * dwarf-index-write.c (save_gdb_index_command): Update.
1298         * cp-support.c (add_symbol_overload_list_qualified): Update.
1299         * breakpoint.c (create_overlay_event_breakpoint)
1300         (create_longjmp_master_breakpoint)
1301         (create_std_terminate_master_breakpoint)
1302         (create_exception_master_breakpoint): Update.
1303         * blockframe.c (find_pc_partial_function): Update.
1304         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1305         (ada_collect_symbol_completion_matches)
1306         (ada_add_global_exceptions): Update.
1307
1308 2019-01-17  Tom Tromey  <tom@tromey.com>
1309
1310         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1311         declare VEC.
1312         (solib_target_parse_libraries): Change return type.
1313         (library_list_start_segment, library_list_start_section)
1314         (library_list_end_library, library_list_start_library); Update.
1315         (solib_target_free_library_list): Remove.
1316         (solib_target_parse_libraries): Remove cleanup.  Change return
1317         type.
1318         (solib_target_current_sos): Update.
1319
1320 2019-01-17  Tom Tromey  <tromey@bapiya>
1321
1322         * valprint.c: Replace "the the" with "the".
1323         * symtab.c: Replace "the the" with "the".
1324         * solib.c: Replace "the the" with "the".
1325         * solib-dsbt.c: Replace "the the" with "the".
1326         * linespec.c: Replace "the the" with "the".
1327         * dwarf2loc.h: Replace "the the" with "the".
1328         * amd64-windows-tdep.c: Replace "the the" with "the".
1329         * aarch64-tdep.c: Replace "the the" with "the".
1330
1331 2019-01-16  Keith Seitz  <keiths@redhat.com>
1332
1333         PR gdb/23773
1334         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1335         <builder>: Rename to ..
1336         <m_builder>: ... this and make private.
1337         (dwarf2_cu::get_builder): New method.  Change all users of
1338         `builder' to use this method.
1339         (dwarf2_start_symtab): Move to ...
1340         (dwarf2_cu::start_symtab): ... here.  Update all callers
1341         (setup_type_unit_groups): Move to ...
1342         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1343         callers.
1344         (dwarf2_cu::reset_builder): New method.
1345         (process_full_compunit, process_full_type_unit): Use
1346         dwarf2_cu::reset_builder.
1347         (follow_die_offset): Record the ancestor CU if it is different
1348         from the followed DIE's CU.
1349         (follow_die_sig_1): Likewise.
1350
1351 2019-01-15  Tom Tromey  <tom@tromey.com>
1352
1353         * remote.c (class remote_state) <buf>: Now a char_vector.
1354         <buf_size>: Remove.
1355         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1356         parameter.
1357         (remote_target::getpkt_or_notif_sane_1)
1358         (remote_target::getpkt_sane)
1359         (remote_target::getpkt_or_notif_sane): Likewise.
1360         (class remote_target) <putpkt>: New overload.
1361         (remote_target::read_frame): Change type of "buf_p".  Remove
1362         sizeof_p parameter.
1363         (packet_ok): New overload.
1364         (packet_check_result): New overload.
1365         Update all uses.
1366
1367 2019-01-14  Tom Tromey  <tom@tromey.com>
1368
1369         * remote-notif.c (handle_notification, remote_notif_ack)
1370         (remote_notif_parse): Make "buf" const.
1371         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1372         const.
1373         (remote_notif_parse, remote_notif_ack, handle_notification):
1374         Likewise.
1375         * remote.c (remote_notif_stop_parse): Make "buf" const.
1376         (remote_target::remote_parse_stop_reply): Make "buf" const.
1377         (remote_notif_stop_ack): Make "buf" const.
1378
1379 2019-01-14  Tom Tromey  <tom@tromey.com>
1380
1381         * remote.c (remote_console_output): Make parameter const.
1382
1383 2019-01-14  Tom Tromey  <tom@tromey.com>
1384
1385         * target-debug.h (target_debug_print_signals): Constify.
1386         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1387         * procfs.c (procfs_target::pass_signals): Update.
1388         * linux-nat.c (linux_nat_target::pass_signals): Update.
1389         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1390         * target-delegates.c: Rebuild.
1391         * remote.c (remote_target::program_signals): Update.
1392         (remote_target::pass_signals): Update.
1393         * target.c (target_pass_signals): Constify argument.
1394         (target_program_signals): Likewise.
1395         * target.h (struct target_ops) <pass_signals, program_signals>:
1396         Constify argument.
1397         (target_pass_signals, target_program_signals): Constify argument.
1398
1399 2019-01-14  Tom Tromey  <tom@tromey.com>
1400
1401         PR tui/28819:
1402         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1403
1404 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1405
1406         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1407         field.
1408         * rs6000-tdep.c: Include reggroups.h.
1409         (IS_V_ALIAS_PSEUDOREG): Define.
1410         (rs6000_register_name): Return names for the "vX" aliases.
1411         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1412         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1413         aliases.  Call default_register_reggroup_p for all other
1414         pseudo-registers.
1415         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1416         New functions.
1417         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1418         Handle "vX" aliases.
1419         (v_alias_pseudo_register_collect): New function.
1420         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1421         (rs6000_gdbarch_init): Initialize "vX" aliases as
1422         pseudo-registers.  Restore registration of
1423         rs6000_pseudo_register_reggroup_p with
1424         set_tdesc_pseudo_register_reggroup_p.
1425
1426 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1427
1428         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1429         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1430         set_gdbarch_num_pseudo_regs.
1431
1432 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1433
1434         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1435         Remove arg prefixname, add do_set and do_show.
1436         Add member functions set_list and show_list.
1437         * cli/cli-style.c (class cli_style_option): Update accordingly.
1438         (style_set_list): Move to file scope.
1439         (style_show_list): Likewise.
1440         (set_style): Call help_list.
1441         (show_style): Call cmd_show_list.
1442         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1443         Update to use the new macro.
1444
1445 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1446
1447         * ada-lang.c (_initialize_ada_language): Expand the help text
1448         for the "catch exception" command.
1449
1450 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1451
1452         * symtab.c (matching_obj_sections): Initialize obj,
1453         declare it closer to its usage.
1454
1455 2019-01-10  Tom Tromey  <tom@tromey.com>
1456
1457         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1458         (basic_inf_threads_range): Remove.
1459         (inf_threads_range, inf_non_exited_threads_range)
1460         (safe_inf_threads_range): Use next_adapter.
1461
1462 2019-01-10  Keith Seitz  <keiths@redhat.com>
1463
1464         PR gdb/23712
1465         PR symtab/23010
1466         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1467         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1468
1469 2019-01-10  Keith Seitz  <keiths@redhat.com>
1470
1471         PR gdb/23712
1472         PR symtab/23010
1473         * dictionary.c (pending_to_vector): Remove.
1474         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1475         Remove _1 suffix, replacing functions of the same name.  Update
1476         all callers.
1477         (dict_create_hashed, dict_create_hashed_expandable)
1478         (dict_create_linear, dict_create_linear_expandable, dict_free)
1479         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1480         Make functions static.
1481
1482 2019-01-10  Keith Seitz  <keiths@redhat.com>
1483
1484         PR gdb/23712
1485         PR symtab/23010
1486         * dictionary.h (struct dictionary): Replace declaration with
1487         multidictionary.
1488         (dict_create_hashed, dict_create_hashed_expandable)
1489         (dict_create_linear, dict_create_linear_expandable)
1490         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1491         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1492         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1493         taking multidictionary argument.
1494         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1495         * block.h (struct block) <dict>: Change to multidictionary
1496         and rename `multidict'.
1497         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1498         symmisc.c: Update all dictionary references to multidictionary.
1499
1500 2019-01-10  Keith Seitz  <keiths@redhat.com>
1501
1502         PR gdb/23712
1503         PR symtab/23010
1504         * dictionary.c: Include unordered_map.
1505         (pending_to_vector): New function.
1506         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1507         Rewrite the non-"_1" functions to take vector instead
1508         of linked list.
1509         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1510         "new" _1 versions of the same name.
1511         (multidictionary): Define.
1512         (std::hash<enum language): New definition.
1513         (collate_pending_symbols_by_language, mdict_create_hashed)
1514         (mdict_create_hashed_expandable, mdict_create_linear)
1515         (mdict_create_linear_expandable, mdict_free)
1516         (find_language_dictionary, create_new_language_dictionary)
1517         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1518         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1519         (mdict_size, mdict_empty): New functions.
1520         * dictionary.h (mdict_iterator): Define.
1521
1522 2019-01-10  Pedro Alves  <palves@redhat.com>
1523
1524         * breakpoint.c (read_uploaded_action)
1525         (create_tracepoint_from_upload): Adjust to use
1526         gdb::unique_xmalloc_ptr.
1527         * ctf.c (ctf_write_uploaded_tp):
1528         (SET_ARRAY_FIELD): Use emplace_back.
1529         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1530         * tracefile-tfile.c (tfile_write_uploaded_tp):
1531         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1532         gdb::unique_xmalloc_ptr.
1533         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1534         at_string, cond_string, cmd_strings>: Replace char pointers
1535         with gdb::unique_xmalloc_ptr.
1536
1537 2019-01-10  Pedro Alves  <palves@redhat.com>
1538
1539         * solib-target.c (library_list_start_library): Don't xstrdup name.
1540
1541 2019-01-10  Pedro Alves  <palves@redhat.com>
1542
1543         * mdebugread.c (parse_partial_symbols): Use
1544         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1545
1546 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1547
1548         * linux-fork.c (scoped_switch_fork_info)
1549         <~scoped_switch_fork_info>: Fix incorrect variable name.
1550
1551 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1552
1553         * linux-fork.c (scoped_switch_fork_info)
1554         <scoped_switch_fork_info>: Make explicit.
1555         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1556
1557 2019-01-10  Tom Tromey  <tom@tromey.com>
1558
1559         * objfiles.h (objfile::reset_psymtabs): Update.
1560         * objfiles.c (objfile::objfile): Update.
1561         * psymtab.h (psymtab_storage::obstack): Update.
1562         (psymtab_storage::m_obstack): Use gdb::optional.
1563         (class psymtab_storage): Update comment.  Remove objfile
1564         parameter.
1565         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1566
1567 2019-01-10  Tom Tromey  <tom@tromey.com>
1568
1569         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1570         <free_psymtabs>: Now private.
1571         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1572         (allocate_psymtab): Use new method.
1573
1574 2019-01-10  Tom Tromey  <tom@tromey.com>
1575
1576         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1577         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1578         * mdebugread.c (parse_partial_symbols): Use
1579         allocate_dependencies.
1580         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1581         allocate_dependencies.
1582         (process_psymtab_comp_unit_reader)
1583         (build_type_psymtab_dependencies): Likewise.
1584         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1585
1586 2019-01-10  Tom Tromey  <tom@tromey.com>
1587
1588         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1589         PSYMBOL_SET_LANGUAGE.
1590         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1591
1592 2019-01-10  Tom Tromey  <tom@tromey.com>
1593
1594         * psymtab.h (psymtab_storage::obstack): New method.
1595         <m_obstack>: Rename from obstack; now private.
1596         * psymtab.c (psymtab_storage): Update.
1597         * dwarf2read.c (create_addrmap_from_index)
1598         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1599         Update.
1600
1601 2019-01-10  Tom Tromey  <tom@tromey.com>
1602
1603         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1604         * objfiles.h (objfile::reset_psymtabs): New method.
1605
1606 2019-01-10  Tom Tromey  <tom@tromey.com>
1607
1608         * symmisc.c (print_symbol_bcache_statistics): Update.
1609         (print_objfile_statistics): Update.
1610         * symfile.c (reread_symbols): Update.
1611         * psymtab.h (class psymtab_storage): New.
1612         * psymtab.c (psymtab_storage): New constructor.
1613         (~psymtab_storage): New destructor.
1614         (require_partial_symbols): Update.
1615         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1616         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1617         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1618         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1619         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1620         (start_psymtab_common, end_psymtab_common)
1621         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1622         (allocate_psymtab): Update.
1623         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1624         Update.
1625         (dump_psymtab_addrmap, maintenance_print_psymbols)
1626         (maintenance_check_psymtabs): Update.
1627         (class objfile_psymtabs): Move to objfiles.h.
1628         * psympriv.h (discard_psymtab): Now inline.
1629         (psymtab_discarder::psymtab_discarder): Update.
1630         (psymtab_discarder::~psymtab_discarder): Update.
1631         (ALL_OBJFILE_PSYMTABS): Rewrite.
1632         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1633         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1634         Remove fields.
1635         <partial_symtabs>: New field.
1636         (class objfile_psymtabs): Move from psymtab.h.  Update.
1637         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1638         psymbol_cache.
1639         (objfile::~objfile): Don't destroy psymbol_cache.
1640         * mdebugread.c (parse_partial_symbols): Update.
1641         * dwarf2read.c (create_addrmap_from_index)
1642         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1643         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1644         (add_partial_subprogram, dwarf2_ranges_read): Update.
1645         * dwarf-index-write.c (write_address_map)
1646         (write_one_signatured_type, recursively_write_psymbols)
1647         (class debug_names, class debug_names, write_psymtabs_to_index):
1648         Update.
1649
1650 2019-01-10  Tom Tromey  <tom@tromey.com>
1651
1652         * symtab.h (SYMBOL_SET_NAMES): Update.
1653         (symbol_set_names): Update.
1654         (MSYMBOL_SET_NAMES): Update.
1655         * symtab.c (symbol_set_names): Change argument to be an
1656         objfile_per_bfd_storage.
1657         * psymtab.c (add_psymbol_to_bcache): Update.
1658         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1659
1660 2019-01-10  Tom Tromey  <tom@tromey.com>
1661
1662         * symtab.c (create_demangled_names_hash): Change argument to be an
1663         objfile_per_bfd_storage.
1664         (symbol_set_names): Update.
1665
1666 2019-01-10  Tom Tromey  <tom@tromey.com>
1667
1668         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1669         init_psymbol_list.
1670         * psymtab.c (init_psymbol_list): Do nothing if already called.
1671         * psympriv.h (init_psymbol_list): Add comment.
1672         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1673         init_psymbol_list.
1674         * dbxread.c (dbx_symfile_read): Unconditionally call
1675         init_psymbol_list.
1676
1677 2019-01-10  Tom Tromey  <tom@tromey.com>
1678
1679         * xcoffread.c (scan_xcoff_symtab): Update.
1680         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1681         "where".
1682         * mdebugread.c (parse_partial_symbols)
1683         (handle_psymbol_enumerators): Update.
1684         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1685         * dbxread.c (read_dbx_symtab): Update.
1686         * psympriv.h (psymbol_placement): New enum.
1687         (add_psymbol_to_list): Update.
1688
1689 2019-01-10  Tom Tromey  <tom@tromey.com>
1690
1691         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1692         static_psymbols parameters.
1693         (scan_xcoff_symtab): Update.
1694         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1695         static_psymbols parameters.
1696         * psympriv.h (start_psymtab_common): Update.
1697         * mdebugread.c (parse_partial_symbols): Update.
1698         * dwarf2read.c (create_partial_symtab): Update.
1699         * dbxread.c (read_dbx_symtab): Update.
1700         (start_psymtab): Remove global_psymbols and static_psymbols
1701         parameters.
1702
1703 2019-01-10  Tom Tromey  <tom@tromey.com>
1704
1705         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1706         * psymtab.c (allocate_psymtab): Add comment.
1707         * psympriv.h (allocate_psymtab): Add comment.
1708         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1709         initializations.
1710         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1711
1712 2019-01-10  Tom Tromey  <tom@tromey.com>
1713
1714         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1715         Don't declare.
1716         * mipsread.c: Include mdebugread.h.
1717         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1718         Declare.
1719         * elfread.c: Include mdebugread.h.
1720
1721 2019-01-09  Tom Tromey  <tom@tromey.com>
1722
1723         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1724         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1725         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1726         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1727         (psym_lookup_symbol, psym_find_last_source_symtab)
1728         (psym_forget_cached_source_info, psym_print_stats)
1729         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1730         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1731         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1732         (psym_find_compunit_symtab_by_address)
1733         (maintenance_print_psymbols, maintenance_info_psymtabs)
1734         (maintenance_check_psymtabs): Use ranged for.
1735         * psymtab.h (class objfile_psymtabs): New.
1736         (require_partial_symbols): Return objfile_psymtabs.
1737         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1738
1739 2019-01-09  Tom Tromey  <tom@tromey.com>
1740
1741         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1742         (find_pc_mapped_section, list_overlays_command)
1743         (map_overlay_command, unmap_overlay_command)
1744         (simple_overlay_update): Use all_objfiles.
1745         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1746         * printcmd.c (info_symbol_command): Use all_objfiles.
1747         * objfiles.h (ALL_OBJSECTIONS): Remove.
1748         * maint.c (maintenance_translate_address): Use all_objfiles.
1749         * gcore.c (gcore_create_callback): Use all_objfiles.
1750         (objfile_find_memory_regions): Likewise.
1751
1752 2019-01-09  Tom Tromey  <tom@tromey.com>
1753
1754         * symtab.c (find_line_symtab, info_sources_command)
1755         (make_source_files_completion_list): Use objfile_compunits.
1756         * source.c (select_source_symtab): Use objfile_compunits.
1757         * objfiles.h (struct objfile): Update comment.
1758         (ALL_OBJFILES): Remove.
1759         (ALL_FILETABS): Remove.
1760         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
1761         objfile_compunits.
1762
1763 2019-01-09  Tom Tromey  <tom@tromey.com>
1764
1765         * symmisc.c (print_objfile_statistics, dump_objfile)
1766         (maintenance_print_symbols): Use compunit_filetabs.
1767         * source.c (forget_cached_source_info_for_objfile): Use
1768         compunit_filetabs.
1769         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
1770         (ALL_FILETABS): Use compunit_filetabs.
1771         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
1772         * coffread.c (coff_symtab_read): Use compunit_filetabs.
1773
1774 2019-01-09  Tom Tromey  <tom@tromey.com>
1775
1776         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
1777         (compunit_filetabs): New.
1778         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
1779         compunit_filetabs.
1780         (info_sources_command, make_source_files_completion_list): Remove
1781         declaration.
1782         * symmisc.c (print_objfile_statistics, dump_objfile)
1783         (maintenance_print_symbols): Remove declaration.
1784         (maintenance_info_symtabs): Use compunit_filetabs.
1785         (maintenance_info_line_tables): Likewise.
1786         * source.c (select_source_symtab): Change local variable name.
1787         (forget_cached_source_info_for_objfile): Remove declaration.
1788         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
1789         * objfiles.c (objfile_relocate1): Remove declaration.
1790         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1791         declaration.
1792         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
1793         * coffread.c (coff_symtab_read): Remove declaration.
1794         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1795         compunit_filetabs.
1796
1797 2019-01-09  Tom Tromey  <tom@tromey.com>
1798
1799         * symtab.c (lookup_objfile_from_block)
1800         (find_pc_sect_compunit_symtab, search_symbols)
1801         (default_collect_symbol_completion_matches_break_on): Use
1802         objfile_compunits.
1803         * objfiles.h (ALL_COMPUNITS): Remove.
1804         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
1805         * cp-support.c (add_symbol_overload_list_qualified): Use
1806         objfile_compunits.
1807         * ada-lang.c (ada_collect_symbol_completion_matches)
1808         (ada_add_global_exceptions): Use objfile_compunits.
1809
1810 2019-01-09  Tom Tromey  <tom@tromey.com>
1811
1812         * source.c (select_source_symtab)
1813         (forget_cached_source_info_for_objfile): Remove declaration.
1814         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1815         declaration.
1816         * maint.c (count_symtabs_and_blocks): Remove declaration.
1817         * cp-support.c (add_symbol_overload_list_qualified): Remove
1818         declaration.
1819         * coffread.c (coff_symtab_read): Remove declaration.
1820         * symtab.c (lookup_symbol_in_objfile_symtabs)
1821         (basic_lookup_transparent_type_1): Use objfile_compunits.
1822         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
1823         (info_sources_command, search_symbols)
1824         (default_collect_symbol_completion_matches_break_on)
1825         (make_source_files_completion_list): Remove declaration.
1826         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
1827         (ada_collect_symbol_completion_matches)
1828         (ada_add_global_exceptions): Remove declaration.
1829         * linespec.c (iterate_over_all_matching_symtabs): Use
1830         objfile_compunits.
1831         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
1832         (class objfile_compunits): New.
1833         (ALL_COMPUNITS): Use objfile_compunits.
1834         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
1835         (maintenance_check_symtabs, maintenance_info_line_tables): Use
1836         objfile_compunits.
1837         * objfiles.c (objfile_relocate1): Use objfile_compunits.
1838
1839 2019-01-09  Tom Tromey  <tom@tromey.com>
1840
1841         * symtab.c (search_symbols)
1842         (default_collect_symbol_completion_matches_break_on): Use
1843         objfile_msymbols.
1844         * ada-lang.c (ada_lookup_simple_minsym)
1845         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
1846         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
1847         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
1848         objfile_msymbols.
1849         * coffread.c (coff_symfile_read): Use objfile_msymbols.
1850         * symmisc.c (dump_msymbols): Use objfile_msymbols.
1851         * objc-lang.c (find_methods): Use objfile_msymbols.
1852         (info_selectors_command, info_classes_command): Likewise.
1853         * stabsread.c (scan_file_globals): Use objfile_msymbols.
1854         * objfiles.h (class objfile_msymbols): New.
1855         (ALL_OBJFILE_MSYMBOLS): Remove.
1856         (ALL_MSYMBOLS): Remove.
1857
1858 2019-01-09  Tom Tromey  <tom@tromey.com>
1859
1860         * common/next-iterator.h (next_adapter): Add Iterator template
1861         parameter.
1862         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
1863         (class all_objfiles_safe): New.
1864         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
1865         * objfiles.c (put_objfile_before): Update comment.
1866         (add_separate_debug_objfile): Likewise.
1867         (free_all_objfiles): Use all_objfiles_safe.
1868         (objfile_purge_solibs): Likewise.
1869
1870 2019-01-09  Tom Tromey  <tom@tromey.com>
1871
1872         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1873         (expand_symtab_containing_pc, lookup_static_symbol)
1874         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
1875         (find_symbol_at_address, find_line_symtab, find_main_name): Use
1876         all_objfiles.
1877         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
1878         * breakpoint.c (create_overlay_event_breakpoint)
1879         (create_longjmp_master_breakpoint)
1880         (create_std_terminate_master_breakpoint)
1881         (create_exception_master_breakpoint): Use all_objfiles.
1882         * linux-thread-db.c (try_thread_db_load_from_pdir)
1883         (has_libpthread): Use all_objfiles.
1884         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
1885         * linespec.c (iterate_over_all_matching_symtabs)
1886         (search_minsyms_for_name): Use all_objfiles.
1887         * maint.c (maintenance_info_sections): Use all_objfiles.
1888         * main.c (captured_main_1): Use all_objfiles.
1889         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
1890         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
1891         * guile/scm-pretty-print.c
1892         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
1893         * solib-spu.c (append_ocl_sos): Use all_objfiles.
1894         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
1895         (maintenance_print_msymbols): Use all_objfiles.
1896         * source.c (select_source_symtab): Use all_objfiles.
1897         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
1898         * symfile.c (remove_symbol_file_command)
1899         (expand_symtabs_matching, map_symbol_filenames): Use
1900         all_objfiles.
1901         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
1902         all_objfiles.
1903         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
1904         * objc-lang.c (find_methods): Use all_objfiles.
1905         * objfiles.c (have_partial_symbols, have_full_symbols)
1906         (have_minimal_symbols, qsort_cmp)
1907         (default_iterate_over_objfiles_in_search_order): Use
1908         all_objfiles.
1909         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
1910         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
1911         (maintenance_check_psymtabs): Use all_objfiles.
1912         (ALL_PSYMTABS): Remove.
1913         * compile/compile-object-run.c (do_module_cleanup): Use
1914         all_objfiles.
1915         * blockframe.c (find_pc_partial_function): Use all_objfiles.
1916         * cp-support.c (add_symbol_overload_list_qualified): Use
1917         all_objfiles.
1918         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1919         Use all_objfiles.
1920         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
1921         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
1922         all_objfiles.
1923         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1924         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
1925         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1926         Uses all_objfiles.
1927         * solib.c (solib_read_symbols): Use all_objfiles
1928
1929 2019-01-09  Tom Tromey  <tom@tromey.com>
1930
1931         * probe.c (parse_probes_in_pspace): Use all_objfiles.
1932         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
1933         all_objfiles.
1934         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
1935         * symmisc.c (print_symbol_bcache_statistics)
1936         (print_objfile_statistics, maintenance_print_objfiles)
1937         (maintenance_info_symtabs, maintenance_check_symtabs)
1938         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
1939         all_objfiles.
1940         * source.c (forget_cached_source_info): Use all_objfiles.
1941         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
1942         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1943         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
1944         * objfiles.c (update_section_map): Use all_objfiles.
1945         (shared_objfile_contains_address_p): Likewise.
1946         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
1947         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
1948
1949 2019-01-09  Tom Tromey  <tom@tromey.com>
1950
1951         * common/next-iterator.h: New file.
1952         * objfiles.h (class all_objfiles): New.
1953         (struct objfile_iterator): New.
1954
1955 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1956
1957         * NEWS: Move the description of the changed "frame", "select-frame",
1958          and "info frame" commands to the Changed commands section.
1959
1960 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
1961
1962         * gdbtypes.c (check_stub_method_group): Remove handling of old
1963         mangling schemes.
1964         * linespec.c (find_methods): Likewise.
1965         * stabsread.c (read_member_functions): Likewise.
1966         * valops.c (search_struct_method): Likewise.
1967         (value_struct_elt_for_reference): Likewise.
1968         * NEWS: Mention this change.
1969
1970 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1971
1972         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
1973         print_source_lines.
1974         * source.c (print_source_lines_base): Update line number check.
1975         (print_source_lines): New function.
1976         (source_lines_range::source_lines_range): New function.
1977         * source.h (class source_lines_range): New class.
1978         (print_source_lines): New declaration.
1979
1980 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1981
1982         * linespec.c (linespec_state_destructor): Free self->canonical_names.
1983
1984 2019-01-08  Tom Tromey  <tom@tromey.com>
1985             Simon Marchi  <simon.marchi@ericsson.com>
1986
1987         PR gdb/24060
1988         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
1989         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
1990         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1991         * f-exp.y (DOLLAR_VARIABLE): Likewise.
1992         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
1993         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1994
1995 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1996
1997         * source.c (select_source_symtab): Move header comment to
1998         declaration in source.h.
1999         (forget_cached_source_info_for_objfile): Likewise.
2000         (forget_cached_source_info): Likewise.
2001         (identify_source_line): Likewise.
2002         * source.h (identify_source_line): Move declaration from symtab.h
2003         and add comment from source.c
2004         (print_source_lines): Likewise.
2005         (forget_cached_source_info_for_objfile): Likewise.
2006         (forget_cached_source_info): Likewise.
2007         (select_source_symtab): Likewise.
2008         (enum print_source_lines_flag): Move definition from symtab.h.
2009         * symtab.h (identify_source_line): Move declaration to source.h.
2010         (print_source_lines): Likewise.
2011         (forget_cached_source_info_for_objfile): Likewise.
2012         (forget_cached_source_info): Likewise.
2013         (select_source_symtab): Likewise.
2014         (enum print_source_lines_flag): Move definition to source.h.
2015         * tui/tui-hooks.c: Add 'source.h' include.
2016
2017 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2018
2019         * source.c (print_source_lines_base): Handle requests to print
2020         reverse line number sequences, and guard against empty lines
2021         string.
2022
2023 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2024
2025         * source.c (print_source_lines_base): Fix skip of '\r' if next
2026         character is '\n'.
2027
2028 2019-01-06  Tom Tromey  <tom@tromey.com>
2029
2030         * c-exp.y (struct c_parse_state) <macro_original_text,
2031         expansion_obstack>: New member.
2032         (macro_original_text, expansion_obstack): Remove globals.
2033         (scan_macro_expansion, scanning_macro_expansion)
2034         (finished_macro_expansion): Update.
2035         (scan_macro_cleanup): Remove.
2036         (yylex, c_parse): Update.
2037
2038 2019-01-06  Tom Tromey  <tom@tromey.com>
2039
2040         * c-exp.y (struct c_parse_state) <strings>: New member.
2041         (operator_stoken): Update.
2042
2043 2019-01-06  Tom Tromey  <tom@tromey.com>
2044
2045         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2046         (union type_stack_elt) <typelist_val>: Now a pointer to
2047         std::vector.
2048         (type_stack_cleanup): Don't declare.
2049         (push_typelist): Update.
2050         * parse.c (pop_typelist): Return a std::vector.
2051         (push_typelist): Take a std::vector.
2052         (follow_types): Update.  Do not free args.
2053         (type_stack_cleanup): Remove.
2054         * c-exp.y (struct c_parse_state): New.
2055         (cpstate): New global.
2056         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2057         (nonempty_typelist): Update.
2058         (func_mod): Create a new vector.
2059         (c_parse): Create a c_parse_state.
2060         (check_parameter_typelist): Do not delete params.
2061         (function_method): Update.  Do not delete type_list.
2062
2063 2019-01-06  Tom Tromey  <tom@tromey.com>
2064
2065         PR gdb/28155:
2066         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2067         check_typedef.
2068         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2069         (print_return_value): Likewise.
2070
2071 2019-01-05  Tom Tromey  <tom@tromey.com>
2072
2073         * contrib/cleanup_check.py: Remove.
2074         * contrib/gcc-with-excheck: Remove.
2075         * contrib/exsummary.py: Remove.
2076         * contrib/excheck.py: Remove.
2077
2078 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2079
2080         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2081         NULL. Initialize tpprev to NULL instead of assigning it
2082         to NULL on the next statement.
2083         * windows-nat.c (windows_delete_thread): Remove check for
2084         main_thread_id before printing thread exit notifications.
2085         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2086         Remove thread ID check against main_thread_id.
2087         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2088         windows_delete_thread.
2089         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2090
2091 2019-01-04  Tom Tromey  <tom@tromey.com>
2092
2093         * compile/compile.c (_initialize_compile): Use upper case for
2094         metasyntactic variables.
2095         * symmisc.c (_initialize_symmisc): Use upper case for
2096         metasyntactic variables.
2097         * psymtab.c (_initialize_psymtab): Use upper case for
2098         metasyntactic variables.
2099         * demangle.c (demangle_command): Use upper case for metasyntactic
2100         variables.
2101         (_initialize_demangler): Likewise.
2102         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2103         variables.
2104
2105 2019-01-03  Tom Tromey  <tom@tromey.com>
2106
2107         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2108
2109 2019-01-03  Tom Tromey  <tom@tromey.com>
2110
2111         * python/py-symtab.c (salpy_str): Update.
2112         (struct salpy_sal_object) <symtab>: Now a PyObject.
2113         (salpy_dealloc): Update.
2114         (del_objfile_sal): Use gdbpy_ref.
2115
2116 2019-01-03  Tom Tromey  <tom@tromey.com>
2117
2118         * python/py-type.c (convert_field): Use new_reference.  Return
2119         gdbpy_ref.
2120         (make_fielditem): Return gdbpy_ref.
2121         (typy_fields): Update.
2122         (typy_getitem): Update.
2123         (field_name): Return gdbpy_ref.  Use new_reference.
2124         (typy_iterator_iternext): Update.
2125
2126 2019-01-03  Tom Tromey  <tom@tromey.com>
2127
2128         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2129
2130 2019-01-03  Tom Tromey  <tom@tromey.com>
2131
2132         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2133         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2134         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2135         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2136         (pspy_set_type_printers): Likewise.
2137         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2138         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2139         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2140         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2141         (objfpy_set_type_printers): Likewise.
2142
2143 2019-01-03  Tom Tromey  <tom@tromey.com>
2144
2145         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2146         (gdbpy_print_stack): Use gdbpy_err_fetch.
2147         * python/python-internal.h (class gdbpy_err_fetch): New class.
2148         (class gdbpy_enter) <m_error_type, m_error_value,
2149         m_error_traceback>: Remove.
2150         <m_error>: New member.
2151         (gdbpy_exception_to_string): Don't declare.
2152         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2153         * python/py-value.c (convert_value_from_python): Use
2154         gdbpy_err_fetch.
2155         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2156         gdbpy_exception_to_string.
2157         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2158         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2159         gdbpy_err_fetch.
2160
2161 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2162
2163         * linux-nat.c (delete_lwp_cleanup): Delete.
2164         (struct lwp_deleter): New struct.
2165         (lwp_info_up): New typedef.
2166         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2167         lwp_info_up.
2168
2169 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2170
2171         * linux-fork.c (class scoped_switch_fork_info): New class.
2172         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2173
2174 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2175
2176         * valops.c (find_overload_match): Remove use of null_cleanup, and
2177         calls to do_cleanups.
2178
2179 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2180
2181         * compile/compile-cplus-types.c
2182         (compile_cplus_instance::decl_name): Handle changes to
2183         cp_func_name.
2184         * cp-support.c (cp_func_name): Update header comment, update
2185         return type.
2186         * cp-support.h (cp_func_name): Update return type in declaration.
2187         * valops.c (find_overload_match): Move temp_func local to top
2188         level of function and change its type.  Use temp_func to hold and
2189         delete temporary string obtained from cp_func_name.
2190
2191 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2192
2193         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2194         gdb::char_vector, remove cleanup, and update uses of `msg`.
2195
2196 2019-01-03  Jim Wilson  <jimw@sifive.com>
2197
2198         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2199
2200 2019-01-02  Tom Tromey  <tom@tromey.com>
2201
2202         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2203         (tdesc_parse_xml): Remove cleanups.
2204         * target-descriptions.h (make_cleanup_free_target_description):
2205         Don't declare.
2206         (target_desc_deleter): New struct.
2207         (target_desc_up): New typedef.
2208         * target-descriptions.c (target_desc_deleter::operator()): Rename
2209         from free_target_description.
2210         (make_cleanup_free_target_description): Remove.
2211
2212 2019-01-02  Tom Tromey  <tom@tromey.com>
2213
2214         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2215         constructor, destructor.
2216         (linespec_parser): Remove typedef.
2217         (~linespec_parser): Rename from linespec_parser_delete.
2218         (linespec_lex_to_end, linespec_complete_label)
2219         (linespec_complete): Update.
2220         (decode_line_full): Remove cleanups.
2221         (decode_line_1): Update.
2222
2223 2019-01-02  Tom Tromey  <tom@tromey.com>
2224
2225         * python/python-internal.h (inferior_to_inferior_object): Change
2226         return type.
2227         * python/py-exitedevent.c (create_exited_event_object): Update.
2228         * python/py-inferior.c (inferior_to_inferior_object): Return
2229         gdbpy_ref.
2230         (python_new_inferior, python_inferior_deleted)
2231         (thread_to_thread_object, delete_thread_object)
2232         (build_inferior_list, gdbpy_selected_inferior): Update.
2233         * python/py-infthread.c (create_thread_object): Update.  Also fail
2234         if inferior_to_inferior_object fails.
2235
2236 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2237
2238         * inferior.h (class inferior) <displaced_step_state>: New field.
2239         * infrun.h (struct displaced_step_state): Move here from
2240         infrun.c.  Initialize fields, add constructor.
2241         <inf>: Remove field.
2242         <reset>: New method.
2243         * infrun.c (struct displaced_step_inferior_state): Move to
2244         infrun.h.
2245         (displaced_step_inferior_states): Remove.
2246         (get_displaced_stepping_state): Adust.
2247         (displaced_step_in_progress_any_inferior): Adjust.
2248         (displaced_step_in_progress_thread): Adjust.
2249         (displaced_step_in_progress): Adjust.
2250         (add_displaced_stepping_state): Remove.
2251         (get_displaced_step_closure_by_addr): Adjust.
2252         (remove_displaced_stepping_state): Remove.
2253         (infrun_inferior_exit): Call displaced_step_state.reset.
2254         (use_displaced_stepping): Don't check for NULL.
2255         (displaced_step_prepare_throw): Call
2256         get_displaced_stepping_state.
2257         (displaced_step_fixup): Don't check for NULL.
2258         (prepare_for_detach): Don't check for NULL.
2259
2260 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2261
2262         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2263          in case of call that did not complete.
2264
2265 2019-01-02  Andrey Utkin  <autkin@undo.io>
2266
2267         * symfile.c (find_separate_debug_file): Fix search of debug files for
2268         remote debuggee.
2269
2270 2019-01-02  Tom Tromey  <tom@tromey.com>
2271
2272         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2273         indentation.
2274         * python/py-frame.c (frapy_older): Remove cast.
2275         (frapy_newer): Likewise.
2276         * python/py-breakpoint.c (local_setattro): Remove cast.
2277         * python/py-arch.c (archpy_name): Remove local variable.
2278         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2279
2280 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2281
2282         * unittests/basic_string_view/element_access/char/empty.cc:
2283         Fix year range in copyright header.
2284
2285 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2286
2287         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2288         Delete.
2289         <operator==>: Update with for removed field.
2290         <hash>: Likewise.
2291         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2292         <isa_features>: ...this.
2293         <abi_features>: New field.
2294         (riscv_isa_flen): Update comment.
2295         (riscv_abi_xlen): New declaration.
2296         (riscv_abi_flen): New declaration.
2297         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2298         isa_features.
2299         (riscv_abi_xlen): New function.
2300         (riscv_isa_flen): Update to get answer from isa_features.
2301         (riscv_abi_flen): New function.
2302         (riscv_has_fp_abi): Update to get answer from abi_features.
2303         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2304         xlen and flen.
2305         (riscv_call_info) <xlen, flen>: Update comment.
2306         (riscv_call_arg_struct): Remove invalid assertions
2307         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2308         is removed.
2309         (riscv_gdbarch_init): Gather isa features and abi features
2310         separately, ensure both match on the gdbarch when reusing an old
2311         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2312         a target with 64-bit float hardware.
2313
2314 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2315
2316         * source.c (search_command_helper): Stop reverse search
2317         when line 1 has been searched.
2318
2319 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2320
2321         * record-full.c (record_full_base_target::close): Rewrite
2322         record_full_core_buf_list free logic.
2323
2324 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2325
2326         * break-catch-syscall.c (print_one_catch_syscall): xfree
2327         the last text.
2328
2329 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2330
2331         * top.c (print_gdb_version): Update Copyright year in version
2332         message.
2333
2334 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2335
2336         Update copyright year range in all GDB files.
2337
2338 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2339
2340         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2341
2342 For older changes see ChangeLog-2018.
2343 \f
2344 Local Variables:
2345 mode: change-log
2346 left-margin: 8
2347 fill-column: 74
2348 version-control: never
2349 coding: utf-8
2350 End:
2351