gdb/ChangeLog

   1 2019-01-22  Tom Tromey  <tom@tromey.com>
   2
   3         * compile/gcc-c-plugin.h: Include compile-internal.h.
   4
   5 2019-01-22  Tom Tromey  <tom@tromey.com>
   6
   7         * stabsread.c (EXTERN): Do not define.
   8         (symnum, next_symbol_text_func, processing_gcc_compilation)
   9         (within_function, global_sym_chain, global_stabs)
  10         (previous_stab_code, this_object_header_files)
  11         (n_this_object_header_files)
  12         (n_allocated_this_object_header_files): Define.
  13         * stabsread.h (EXTERN): Never define.  Use "extern".
  14
  15 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  16
  17         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
  18         history_value.
  19
  20 2019-01-21  Tom Tromey  <tom@tromey.com>
  21
  22         * ui-out.c: Fix includes.
  23         * tui/tui-source.c: Fix includes.
  24         * target.c: Fix includes.
  25         * remote.c: Fix includes.
  26         * regcache.c: Fix includes.
  27         * python/py-block.c: Fix includes.
  28         * printcmd.c: Fix includes.
  29         * or1k-tdep.c: Fix includes.
  30         * mi/mi-main.c: Fix includes.
  31         * m32r-tdep.c: Fix includes.
  32         * csky-tdep.c: Fix includes.
  33         * compile/compile-cplus-types.c: Fix includes.
  34         * cli/cli-interp.c: Fix includes.
  35
  36 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
  37
  38         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
  39         for padding.
  40
  41 2019-01-16  Tom Tromey  <tom@tromey.com>
  42
  43         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
  44         earlier.
  45         (struct objfile) <msymbols_range>: Move from top level.
  46         <msymbols>: New method.
  47         (class objfile_msymbols): Remove.
  48         * symtab.c (default_collect_symbol_completion_matches_break_on):
  49         Update.
  50         * symmisc.c (dump_msymbols): Update.
  51         * stabsread.c (scan_file_globals): Update.
  52         * objc-lang.c (info_selectors_command, info_classes_command)
  53         (find_methods): Update.
  54         * minsyms.c (find_solib_trampoline_target): Update.
  55         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
  56         * coffread.c (coff_symfile_read): Update.
  57         * ada-lang.c (ada_lookup_simple_minsym)
  58         (ada_collect_symbol_completion_matches): Update.
  59
  60 2019-01-16  Tom Tromey  <tom@tromey.com>
  61
  62         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
  63         type.  Remove no-argument constructor.
  64         <iterator::operator++>: Simplify.
  65         <begin>: Update.
  66         <end>: Use minimal_symbol_count.
  67
  68 2019-01-16  Tom Tromey  <tom@tromey.com>
  69
  70         * objfiles.h (struct objfile) <psymtabs>: New method.
  71         (class objfile_psymtabs): Remove.
  72         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
  73         typedef.
  74         <range>: New method.
  75         (require_partial_symbols): Change return type.
  76         * psymtab.c (require_partial_symbols)
  77         (psym_expand_symtabs_matching): Update.
  78         * mdebugread.c (parse_partial_symbols): Update.
  79         * dbxread.c (dbx_end_psymtab): Update.
  80
  81 2019-01-15  Tom Tromey  <tom@tromey.com>
  82
  83         * symtab.c (lookup_objfile_from_block)
  84         (lookup_symbol_in_objfile_symtabs)
  85         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
  86         (find_line_symtab, info_sources_command)
  87         (default_collect_symbol_completion_matches_break_on)
  88         (make_source_files_completion_list): Update.
  89         * symmisc.c (print_objfile_statistics, dump_objfile)
  90         (maintenance_print_symbols, maintenance_info_symtabs)
  91         (maintenance_check_symtabs, maintenance_info_line_tables):
  92         Update.
  93         * source.c (select_source_symtab)
  94         (forget_cached_source_info_for_objfile): Update.
  95         * objfiles.h (class objfile_compunits): Remove.
  96         (struct objfile) <compunits_range>: New typedef.
  97         (compunits): New method.
  98         * objfiles.c (objfile_relocate1): Update.
  99         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
 100         * maint.c (count_symtabs_and_blocks): Update.
 101         * linespec.c (iterate_over_all_matching_symtabs): Update.
 102         * cp-support.c (add_symbol_overload_list_qualified): Update.
 103         * coffread.c (coff_symtab_read): Update.
 104         * ada-lang.c (add_nonlocal_symbols)
 105         (ada_collect_symbol_completion_matches)
 106         (ada_add_global_exceptions): Update.
 107
 108 2019-01-15  Tom Tromey  <tom@tromey.com>
 109
 110         * progspace.h (program_space) <objfiles_safe_range>: New
 111         typedef.
 112         <objfiles_safe>: New method.
 113         * objfiles.h (class all_objfiles_safe): Remove.
 114         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
 115         * jit.c (jit_inferior_exit_hook): Update.
 116
 117 2019-01-17  Tom Tromey  <tom@tromey.com>
 118
 119         * progspace.h (program_space) <objfiles_range>: New typedef.
 120         <objfiles>: New method.
 121         <objfiles_head>: Rename from objfiles.
 122         (object_files): Update.
 123         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
 124         * guile/scm-pretty-print.c
 125         (ppscm_find_pretty_printer_from_objfiles): Update.
 126         * guile/scm-objfile.c (gdbscm_objfiles): Update.
 127         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
 128         Update.
 129         * python/py-progspace.c (pspy_get_objfiles): Update.
 130         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
 131         Update.
 132         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
 133         (objfpy_lookup_objfile_by_build_id): Update.
 134         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
 135         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
 136         Update.
 137         * symtab.c (iterate_over_symtabs, matching_obj_sections)
 138         (expand_symtab_containing_pc, lookup_objfile_from_block)
 139         (lookup_static_symbol, basic_lookup_transparent_type)
 140         (find_pc_sect_compunit_symtab, find_symbol_at_address)
 141         (find_line_symtab, info_sources_command)
 142         (default_collect_symbol_completion_matches_break_on)
 143         (make_source_files_completion_list, find_main_name): Update.
 144         * symmisc.c (print_symbol_bcache_statistics)
 145         (print_objfile_statistics, maintenance_print_symbols)
 146         (maintenance_print_msymbols, maintenance_print_objfiles)
 147         (maintenance_info_symtabs, maintenance_check_symtabs)
 148         (maintenance_expand_symtabs, maintenance_info_line_tables):
 149         Update.
 150         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
 151         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
 152         (map_overlay_command, unmap_overlay_command)
 153         (simple_overlay_update, expand_symtabs_matching)
 154         (map_symbol_filenames): Update.
 155         * symfile-debug.c (set_debug_symfile): Update.
 156         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
 157         Update.
 158         * source.c (select_source_symtab, forget_cached_source_info):
 159         Update.
 160         * solib.c (solib_read_symbols): Update.
 161         * solib-spu.c (append_ocl_sos): Update.
 162         * psymtab.c (maintenance_print_psymbols)
 163         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
 164         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
 165         * printcmd.c (info_symbol_command): Update.
 166         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
 167         Update.
 168         * objfiles.h (class all_objfiles): Remove.
 169         * objfiles.c (have_partial_symbols, have_full_symbols)
 170         (have_minimal_symbols, qsort_cmp, update_section_map)
 171         (shared_objfile_contains_address_p)
 172         (default_iterate_over_objfiles_in_search_order): Update.
 173         * objc-lang.c (info_selectors_command, info_classes_command)
 174         (find_methods): Update.
 175         * minsyms.c (find_solib_trampoline_target): Update.
 176         * maint.c (maintenance_info_sections)
 177         (maintenance_translate_address, count_symtabs_and_blocks):
 178         Update.
 179         * main.c (captured_main_1): Update.
 180         * linux-thread-db.c (try_thread_db_load_from_pdir)
 181         (has_libpthread): Update.
 182         * linespec.c (iterate_over_all_matching_symtabs)
 183         (search_minsyms_for_name): Update.
 184         * jit.c (jit_find_objf_with_entry_addr): Update.
 185         * hppa-tdep.c (find_unwind_entry)
 186         (hppa_lookup_stub_minimal_symbol): Update.
 187         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
 188         Update.
 189         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
 190         (elf_gnu_ifunc_resolve_by_got): Update.
 191         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
 192         * dwarf-index-write.c (save_gdb_index_command): Update.
 193         * cp-support.c (add_symbol_overload_list_qualified): Update.
 194         * breakpoint.c (create_overlay_event_breakpoint)
 195         (create_longjmp_master_breakpoint)
 196         (create_std_terminate_master_breakpoint)
 197         (create_exception_master_breakpoint): Update.
 198         * blockframe.c (find_pc_partial_function): Update.
 199         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
 200         (ada_collect_symbol_completion_matches)
 201         (ada_add_global_exceptions): Update.
 202
 203 2019-01-17  Tom Tromey  <tom@tromey.com>
 204
 205         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
 206         declare VEC.
 207         (solib_target_parse_libraries): Change return type.
 208         (library_list_start_segment, library_list_start_section)
 209         (library_list_end_library, library_list_start_library); Update.
 210         (solib_target_free_library_list): Remove.
 211         (solib_target_parse_libraries): Remove cleanup.  Change return
 212         type.
 213         (solib_target_current_sos): Update.
 214
 215 2019-01-17  Tom Tromey  <tromey@bapiya>
 216
 217         * valprint.c: Replace "the the" with "the".
 218         * symtab.c: Replace "the the" with "the".
 219         * solib.c: Replace "the the" with "the".
 220         * solib-dsbt.c: Replace "the the" with "the".
 221         * linespec.c: Replace "the the" with "the".
 222         * dwarf2loc.h: Replace "the the" with "the".
 223         * amd64-windows-tdep.c: Replace "the the" with "the".
 224         * aarch64-tdep.c: Replace "the the" with "the".
 225
 226 2019-01-16  Keith Seitz  <keiths@redhat.com>
 227
 228         PR gdb/23773
 229         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
 230         <builder>: Rename to ..
 231         <m_builder>: ... this and make private.
 232         (dwarf2_cu::get_builder): New method.  Change all users of
 233         `builder' to use this method.
 234         (dwarf2_start_symtab): Move to ...
 235         (dwarf2_cu::start_symtab): ... here.  Update all callers
 236         (setup_type_unit_groups): Move to ...
 237         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
 238         callers.
 239         (dwarf2_cu::reset_builder): New method.
 240         (process_full_compunit, process_full_type_unit): Use
 241         dwarf2_cu::reset_builder.
 242         (follow_die_offset): Record the ancestor CU if it is different
 243         from the followed DIE's CU.
 244         (follow_die_sig_1): Likewise.
 245
 246 2019-01-15  Tom Tromey  <tom@tromey.com>
 247
 248         * remote.c (class remote_state) <buf>: Now a char_vector.
 249         <buf_size>: Remove.
 250         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
 251         parameter.
 252         (remote_target::getpkt_or_notif_sane_1)
 253         (remote_target::getpkt_sane)
 254         (remote_target::getpkt_or_notif_sane): Likewise.
 255         (class remote_target) <putpkt>: New overload.
 256         (remote_target::read_frame): Change type of "buf_p".  Remove
 257         sizeof_p parameter.
 258         (packet_ok): New overload.
 259         (packet_check_result): New overload.
 260         Update all uses.
 261
 262 2019-01-14  Tom Tromey  <tom@tromey.com>
 263
 264         * remote-notif.c (handle_notification, remote_notif_ack)
 265         (remote_notif_parse): Make "buf" const.
 266         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
 267         const.
 268         (remote_notif_parse, remote_notif_ack, handle_notification):
 269         Likewise.
 270         * remote.c (remote_notif_stop_parse): Make "buf" const.
 271         (remote_target::remote_parse_stop_reply): Make "buf" const.
 272         (remote_notif_stop_ack): Make "buf" const.
 273
 274 2019-01-14  Tom Tromey  <tom@tromey.com>
 275
 276         * remote.c (remote_console_output): Make parameter const.
 277
 278 2019-01-14  Tom Tromey  <tom@tromey.com>
 279
 280         * target-debug.h (target_debug_print_signals): Constify.
 281         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
 282         * procfs.c (procfs_target::pass_signals): Update.
 283         * linux-nat.c (linux_nat_target::pass_signals): Update.
 284         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
 285         * target-delegates.c: Rebuild.
 286         * remote.c (remote_target::program_signals): Update.
 287         (remote_target::pass_signals): Update.
 288         * target.c (target_pass_signals): Constify argument.
 289         (target_program_signals): Likewise.
 290         * target.h (struct target_ops) <pass_signals, program_signals>:
 291         Constify argument.
 292         (target_pass_signals, target_program_signals): Constify argument.
 293
 294 2019-01-14  Tom Tromey  <tom@tromey.com>
 295
 296         PR tui/28819:
 297         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
 298
 299 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 300
 301         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
 302         field.
 303         * rs6000-tdep.c: Include reggroups.h.
 304         (IS_V_ALIAS_PSEUDOREG): Define.
 305         (rs6000_register_name): Return names for the "vX" aliases.
 306         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
 307         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
 308         aliases.  Call default_register_reggroup_p for all other
 309         pseudo-registers.
 310         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
 311         New functions.
 312         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
 313         Handle "vX" aliases.
 314         (v_alias_pseudo_register_collect): New function.
 315         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
 316         (rs6000_gdbarch_init): Initialize "vX" aliases as
 317         pseudo-registers.  Restore registration of
 318         rs6000_pseudo_register_reggroup_p with
 319         set_tdesc_pseudo_register_reggroup_p.
 320
 321 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
 322
 323         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
 324         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
 325         set_gdbarch_num_pseudo_regs.
 326
 327 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 328
 329         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
 330         Remove arg prefixname, add do_set and do_show.
 331         Add member functions set_list and show_list.
 332         * cli/cli-style.c (class cli_style_option): Update accordingly.
 333         (style_set_list): Move to file scope.
 334         (style_show_list): Likewise.
 335         (set_style): Call help_list.
 336         (show_style): Call cmd_show_list.
 337         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
 338         Update to use the new macro.
 339
 340 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
 341
 342         * ada-lang.c (_initialize_ada_language): Expand the help text
 343         for the "catch exception" command.
 344
 345 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 346
 347         * symtab.c (matching_obj_sections): Initialize obj,
 348         declare it closer to its usage.
 349
 350 2019-01-10  Tom Tromey  <tom@tromey.com>
 351
 352         * thread-iter.h (inf_threads_iterator): Use next_iterator.
 353         (basic_inf_threads_range): Remove.
 354         (inf_threads_range, inf_non_exited_threads_range)
 355         (safe_inf_threads_range): Use next_adapter.
 356
 357 2019-01-10  Keith Seitz  <keiths@redhat.com>
 358
 359         PR gdb/23712
 360         PR symtab/23010
 361         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
 362         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
 363
 364 2019-01-10  Keith Seitz  <keiths@redhat.com>
 365
 366         PR gdb/23712
 367         PR symtab/23010
 368         * dictionary.c (pending_to_vector): Remove.
 369         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 370         Remove _1 suffix, replacing functions of the same name.  Update
 371         all callers.
 372         (dict_create_hashed, dict_create_hashed_expandable)
 373         (dict_create_linear, dict_create_linear_expandable, dict_free)
 374         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
 375         Make functions static.
 376
 377 2019-01-10  Keith Seitz  <keiths@redhat.com>
 378
 379         PR gdb/23712
 380         PR symtab/23010
 381         * dictionary.h (struct dictionary): Replace declaration with
 382         multidictionary.
 383         (dict_create_hashed, dict_create_hashed_expandable)
 384         (dict_create_linear, dict_create_linear_expandable)
 385         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
 386         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
 387         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
 388         taking multidictionary argument.
 389         [ALL_DICT_SYMBOLS]: Update for multidictionary.
 390         * block.h (struct block) <dict>: Change to multidictionary
 391         and rename `multidict'.
 392         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
 393         symmisc.c: Update all dictionary references to multidictionary.
 394
 395 2019-01-10  Keith Seitz  <keiths@redhat.com>
 396
 397         PR gdb/23712
 398         PR symtab/23010
 399         * dictionary.c: Include unordered_map.
 400         (pending_to_vector): New function.
 401         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 402         Rewrite the non-"_1" functions to take vector instead
 403         of linked list.
 404         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
 405         "new" _1 versions of the same name.
 406         (multidictionary): Define.
 407         (std::hash<enum language): New definition.
 408         (collate_pending_symbols_by_language, mdict_create_hashed)
 409         (mdict_create_hashed_expandable, mdict_create_linear)
 410         (mdict_create_linear_expandable, mdict_free)
 411         (find_language_dictionary, create_new_language_dictionary)
 412         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
 413         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
 414         (mdict_size, mdict_empty): New functions.
 415         * dictionary.h (mdict_iterator): Define.
 416
 417 2019-01-10  Pedro Alves  <palves@redhat.com>
 418
 419         * breakpoint.c (read_uploaded_action)
 420         (create_tracepoint_from_upload): Adjust to use
 421         gdb::unique_xmalloc_ptr.
 422         * ctf.c (ctf_write_uploaded_tp):
 423         (SET_ARRAY_FIELD): Use emplace_back.
 424         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
 425         * tracefile-tfile.c (tfile_write_uploaded_tp):
 426         * tracepoint.c (parse_tracepoint_definition): Adjust to use
 427         gdb::unique_xmalloc_ptr.
 428         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
 429         at_string, cond_string, cmd_strings>: Replace char pointers
 430         with gdb::unique_xmalloc_ptr.
 431
 432 2019-01-10  Pedro Alves  <palves@redhat.com>
 433
 434         * solib-target.c (library_list_start_library): Don't xstrdup name.
 435
 436 2019-01-10  Pedro Alves  <palves@redhat.com>
 437
 438         * mdebugread.c (parse_partial_symbols): Use
 439         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
 440
 441 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 442
 443         * linux-fork.c (scoped_switch_fork_info)
 444         <~scoped_switch_fork_info>: Fix incorrect variable name.
 445
 446 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 447
 448         * linux-fork.c (scoped_switch_fork_info)
 449         <scoped_switch_fork_info>: Make explicit.
 450         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
 451
 452 2019-01-10  Tom Tromey  <tom@tromey.com>
 453
 454         * objfiles.h (objfile::reset_psymtabs): Update.
 455         * objfiles.c (objfile::objfile): Update.
 456         * psymtab.h (psymtab_storage::obstack): Update.
 457         (psymtab_storage::m_obstack): Use gdb::optional.
 458         (class psymtab_storage): Update comment.  Remove objfile
 459         parameter.
 460         * psymtab.c (psymtab_storage::psymtab_storage): Update.
 461
 462 2019-01-10  Tom Tromey  <tom@tromey.com>
 463
 464         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
 465         <free_psymtabs>: Now private.
 466         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
 467         (allocate_psymtab): Use new method.
 468
 469 2019-01-10  Tom Tromey  <tom@tromey.com>
 470
 471         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
 472         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
 473         * mdebugread.c (parse_partial_symbols): Use
 474         allocate_dependencies.
 475         * dwarf2read.c (dwarf2_create_include_psymtab): Use
 476         allocate_dependencies.
 477         (process_psymtab_comp_unit_reader)
 478         (build_type_psymtab_dependencies): Likewise.
 479         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
 480
 481 2019-01-10  Tom Tromey  <tom@tromey.com>
 482
 483         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
 484         PSYMBOL_SET_LANGUAGE.
 485         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
 486
 487 2019-01-10  Tom Tromey  <tom@tromey.com>
 488
 489         * psymtab.h (psymtab_storage::obstack): New method.
 490         <m_obstack>: Rename from obstack; now private.
 491         * psymtab.c (psymtab_storage): Update.
 492         * dwarf2read.c (create_addrmap_from_index)
 493         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
 494         Update.
 495
 496 2019-01-10  Tom Tromey  <tom@tromey.com>
 497
 498         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
 499         * objfiles.h (objfile::reset_psymtabs): New method.
 500
 501 2019-01-10  Tom Tromey  <tom@tromey.com>
 502
 503         * symmisc.c (print_symbol_bcache_statistics): Update.
 504         (print_objfile_statistics): Update.
 505         * symfile.c (reread_symbols): Update.
 506         * psymtab.h (class psymtab_storage): New.
 507         * psymtab.c (psymtab_storage): New constructor.
 508         (~psymtab_storage): New destructor.
 509         (require_partial_symbols): Update.
 510         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
 511         (find_pc_sect_psymtab, find_pc_sect_psymbol)
 512         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
 513         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
 514         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
 515         (start_psymtab_common, end_psymtab_common)
 516         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
 517         (allocate_psymtab): Update.
 518         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
 519         Update.
 520         (dump_psymtab_addrmap, maintenance_print_psymbols)
 521         (maintenance_check_psymtabs): Update.
 522         (class objfile_psymtabs): Move to objfiles.h.
 523         * psympriv.h (discard_psymtab): Now inline.
 524         (psymtab_discarder::psymtab_discarder): Update.
 525         (psymtab_discarder::~psymtab_discarder): Update.
 526         (ALL_OBJFILE_PSYMTABS): Rewrite.
 527         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
 528         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
 529         Remove fields.
 530         <partial_symtabs>: New field.
 531         (class objfile_psymtabs): Move from psymtab.h.  Update.
 532         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
 533         psymbol_cache.
 534         (objfile::~objfile): Don't destroy psymbol_cache.
 535         * mdebugread.c (parse_partial_symbols): Update.
 536         * dwarf2read.c (create_addrmap_from_index)
 537         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
 538         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
 539         (add_partial_subprogram, dwarf2_ranges_read): Update.
 540         * dwarf-index-write.c (write_address_map)
 541         (write_one_signatured_type, recursively_write_psymbols)
 542         (class debug_names, class debug_names, write_psymtabs_to_index):
 543         Update.
 544
 545 2019-01-10  Tom Tromey  <tom@tromey.com>
 546
 547         * symtab.h (SYMBOL_SET_NAMES): Update.
 548         (symbol_set_names): Update.
 549         (MSYMBOL_SET_NAMES): Update.
 550         * symtab.c (symbol_set_names): Change argument to be an
 551         objfile_per_bfd_storage.
 552         * psymtab.c (add_psymbol_to_bcache): Update.
 553         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
 554
 555 2019-01-10  Tom Tromey  <tom@tromey.com>
 556
 557         * symtab.c (create_demangled_names_hash): Change argument to be an
 558         objfile_per_bfd_storage.
 559         (symbol_set_names): Update.
 560
 561 2019-01-10  Tom Tromey  <tom@tromey.com>
 562
 563         * xcoffread.c (xcoff_initial_scan): Unconditionally call
 564         init_psymbol_list.
 565         * psymtab.c (init_psymbol_list): Do nothing if already called.
 566         * psympriv.h (init_psymbol_list): Add comment.
 567         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
 568         init_psymbol_list.
 569         * dbxread.c (dbx_symfile_read): Unconditionally call
 570         init_psymbol_list.
 571
 572 2019-01-10  Tom Tromey  <tom@tromey.com>
 573
 574         * xcoffread.c (scan_xcoff_symtab): Update.
 575         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
 576         "where".
 577         * mdebugread.c (parse_partial_symbols)
 578         (handle_psymbol_enumerators): Update.
 579         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
 580         * dbxread.c (read_dbx_symtab): Update.
 581         * psympriv.h (psymbol_placement): New enum.
 582         (add_psymbol_to_list): Update.
 583
 584 2019-01-10  Tom Tromey  <tom@tromey.com>
 585
 586         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
 587         static_psymbols parameters.
 588         (scan_xcoff_symtab): Update.
 589         * psymtab.c (start_psymtab_common): Remove global_psymbols and
 590         static_psymbols parameters.
 591         * psympriv.h (start_psymtab_common): Update.
 592         * mdebugread.c (parse_partial_symbols): Update.
 593         * dwarf2read.c (create_partial_symtab): Update.
 594         * dbxread.c (read_dbx_symtab): Update.
 595         (start_psymtab): Remove global_psymbols and static_psymbols
 596         parameters.
 597
 598 2019-01-10  Tom Tromey  <tom@tromey.com>
 599
 600         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
 601         * psymtab.c (allocate_psymtab): Add comment.
 602         * psympriv.h (allocate_psymtab): Add comment.
 603         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
 604         initializations.
 605         * dbxread.c (dbx_end_psymtab): Remove some initializations.
 606
 607 2019-01-10  Tom Tromey  <tom@tromey.com>
 608
 609         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
 610         Don't declare.
 611         * mipsread.c: Include mdebugread.h.
 612         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
 613         Declare.
 614         * elfread.c: Include mdebugread.h.
 615
 616 2019-01-09  Tom Tromey  <tom@tromey.com>
 617
 618         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
 619         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
 620         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
 621         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
 622         (psym_lookup_symbol, psym_find_last_source_symtab)
 623         (psym_forget_cached_source_info, psym_print_stats)
 624         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
 625         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
 626         (psym_map_matching_symbols, psym_expand_symtabs_matching)
 627         (psym_find_compunit_symtab_by_address)
 628         (maintenance_print_psymbols, maintenance_info_psymtabs)
 629         (maintenance_check_psymtabs): Use ranged for.
 630         * psymtab.h (class objfile_psymtabs): New.
 631         (require_partial_symbols): Return objfile_psymtabs.
 632         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
 633
 634 2019-01-09  Tom Tromey  <tom@tromey.com>
 635
 636         * symfile.c (overlay_invalidate_all, find_pc_overlay)
 637         (find_pc_mapped_section, list_overlays_command)
 638         (map_overlay_command, unmap_overlay_command)
 639         (simple_overlay_update): Use all_objfiles.
 640         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
 641         * printcmd.c (info_symbol_command): Use all_objfiles.
 642         * objfiles.h (ALL_OBJSECTIONS): Remove.
 643         * maint.c (maintenance_translate_address): Use all_objfiles.
 644         * gcore.c (gcore_create_callback): Use all_objfiles.
 645         (objfile_find_memory_regions): Likewise.
 646
 647 2019-01-09  Tom Tromey  <tom@tromey.com>
 648
 649         * symtab.c (find_line_symtab, info_sources_command)
 650         (make_source_files_completion_list): Use objfile_compunits.
 651         * source.c (select_source_symtab): Use objfile_compunits.
 652         * objfiles.h (struct objfile): Update comment.
 653         (ALL_OBJFILES): Remove.
 654         (ALL_FILETABS): Remove.
 655         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
 656         objfile_compunits.
 657
 658 2019-01-09  Tom Tromey  <tom@tromey.com>
 659
 660         * symmisc.c (print_objfile_statistics, dump_objfile)
 661         (maintenance_print_symbols): Use compunit_filetabs.
 662         * source.c (forget_cached_source_info_for_objfile): Use
 663         compunit_filetabs.
 664         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
 665         (ALL_FILETABS): Use compunit_filetabs.
 666         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
 667         * coffread.c (coff_symtab_read): Use compunit_filetabs.
 668
 669 2019-01-09  Tom Tromey  <tom@tromey.com>
 670
 671         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
 672         (compunit_filetabs): New.
 673         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
 674         compunit_filetabs.
 675         (info_sources_command, make_source_files_completion_list): Remove
 676         declaration.
 677         * symmisc.c (print_objfile_statistics, dump_objfile)
 678         (maintenance_print_symbols): Remove declaration.
 679         (maintenance_info_symtabs): Use compunit_filetabs.
 680         (maintenance_info_line_tables): Likewise.
 681         * source.c (select_source_symtab): Change local variable name.
 682         (forget_cached_source_info_for_objfile): Remove declaration.
 683         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
 684         * objfiles.c (objfile_relocate1): Remove declaration.
 685         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
 686         declaration.
 687         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
 688         * coffread.c (coff_symtab_read): Remove declaration.
 689         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 690         compunit_filetabs.
 691
 692 2019-01-09  Tom Tromey  <tom@tromey.com>
 693
 694         * symtab.c (lookup_objfile_from_block)
 695         (find_pc_sect_compunit_symtab, search_symbols)
 696         (default_collect_symbol_completion_matches_break_on): Use
 697         objfile_compunits.
 698         * objfiles.h (ALL_COMPUNITS): Remove.
 699         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
 700         * cp-support.c (add_symbol_overload_list_qualified): Use
 701         objfile_compunits.
 702         * ada-lang.c (ada_collect_symbol_completion_matches)
 703         (ada_add_global_exceptions): Use objfile_compunits.
 704
 705 2019-01-09  Tom Tromey  <tom@tromey.com>
 706
 707         * source.c (select_source_symtab)
 708         (forget_cached_source_info_for_objfile): Remove declaration.
 709         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
 710         declaration.
 711         * maint.c (count_symtabs_and_blocks): Remove declaration.
 712         * cp-support.c (add_symbol_overload_list_qualified): Remove
 713         declaration.
 714         * coffread.c (coff_symtab_read): Remove declaration.
 715         * symtab.c (lookup_symbol_in_objfile_symtabs)
 716         (basic_lookup_transparent_type_1): Use objfile_compunits.
 717         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
 718         (info_sources_command, search_symbols)
 719         (default_collect_symbol_completion_matches_break_on)
 720         (make_source_files_completion_list): Remove declaration.
 721         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
 722         (ada_collect_symbol_completion_matches)
 723         (ada_add_global_exceptions): Remove declaration.
 724         * linespec.c (iterate_over_all_matching_symtabs): Use
 725         objfile_compunits.
 726         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
 727         (class objfile_compunits): New.
 728         (ALL_COMPUNITS): Use objfile_compunits.
 729         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
 730         (maintenance_check_symtabs, maintenance_info_line_tables): Use
 731         objfile_compunits.
 732         * objfiles.c (objfile_relocate1): Use objfile_compunits.
 733
 734 2019-01-09  Tom Tromey  <tom@tromey.com>
 735
 736         * symtab.c (search_symbols)
 737         (default_collect_symbol_completion_matches_break_on): Use
 738         objfile_msymbols.
 739         * ada-lang.c (ada_lookup_simple_minsym)
 740         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
 741         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
 742         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
 743         objfile_msymbols.
 744         * coffread.c (coff_symfile_read): Use objfile_msymbols.
 745         * symmisc.c (dump_msymbols): Use objfile_msymbols.
 746         * objc-lang.c (find_methods): Use objfile_msymbols.
 747         (info_selectors_command, info_classes_command): Likewise.
 748         * stabsread.c (scan_file_globals): Use objfile_msymbols.
 749         * objfiles.h (class objfile_msymbols): New.
 750         (ALL_OBJFILE_MSYMBOLS): Remove.
 751         (ALL_MSYMBOLS): Remove.
 752
 753 2019-01-09  Tom Tromey  <tom@tromey.com>
 754
 755         * common/next-iterator.h (next_adapter): Add Iterator template
 756         parameter.
 757         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
 758         (class all_objfiles_safe): New.
 759         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
 760         * objfiles.c (put_objfile_before): Update comment.
 761         (add_separate_debug_objfile): Likewise.
 762         (free_all_objfiles): Use all_objfiles_safe.
 763         (objfile_purge_solibs): Likewise.
 764
 765 2019-01-09  Tom Tromey  <tom@tromey.com>
 766
 767         * symtab.c (iterate_over_symtabs, matching_obj_sections)
 768         (expand_symtab_containing_pc, lookup_static_symbol)
 769         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
 770         (find_symbol_at_address, find_line_symtab, find_main_name): Use
 771         all_objfiles.
 772         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
 773         * breakpoint.c (create_overlay_event_breakpoint)
 774         (create_longjmp_master_breakpoint)
 775         (create_std_terminate_master_breakpoint)
 776         (create_exception_master_breakpoint): Use all_objfiles.
 777         * linux-thread-db.c (try_thread_db_load_from_pdir)
 778         (has_libpthread): Use all_objfiles.
 779         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
 780         * linespec.c (iterate_over_all_matching_symtabs)
 781         (search_minsyms_for_name): Use all_objfiles.
 782         * maint.c (maintenance_info_sections): Use all_objfiles.
 783         * main.c (captured_main_1): Use all_objfiles.
 784         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
 785         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
 786         * guile/scm-pretty-print.c
 787         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
 788         * solib-spu.c (append_ocl_sos): Use all_objfiles.
 789         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
 790         (maintenance_print_msymbols): Use all_objfiles.
 791         * source.c (select_source_symtab): Use all_objfiles.
 792         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
 793         * symfile.c (remove_symbol_file_command)
 794         (expand_symtabs_matching, map_symbol_filenames): Use
 795         all_objfiles.
 796         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
 797         all_objfiles.
 798         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
 799         * objc-lang.c (find_methods): Use all_objfiles.
 800         * objfiles.c (have_partial_symbols, have_full_symbols)
 801         (have_minimal_symbols, qsort_cmp)
 802         (default_iterate_over_objfiles_in_search_order): Use
 803         all_objfiles.
 804         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
 805         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
 806         (maintenance_check_psymtabs): Use all_objfiles.
 807         (ALL_PSYMTABS): Remove.
 808         * compile/compile-object-run.c (do_module_cleanup): Use
 809         all_objfiles.
 810         * blockframe.c (find_pc_partial_function): Use all_objfiles.
 811         * cp-support.c (add_symbol_overload_list_qualified): Use
 812         all_objfiles.
 813         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
 814         Use all_objfiles.
 815         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
 816         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
 817         all_objfiles.
 818         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
 819         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
 820         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
 821         Uses all_objfiles.
 822         * solib.c (solib_read_symbols): Use all_objfiles
 823
 824 2019-01-09  Tom Tromey  <tom@tromey.com>
 825
 826         * probe.c (parse_probes_in_pspace): Use all_objfiles.
 827         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
 828         all_objfiles.
 829         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
 830         * symmisc.c (print_symbol_bcache_statistics)
 831         (print_objfile_statistics, maintenance_print_objfiles)
 832         (maintenance_info_symtabs, maintenance_check_symtabs)
 833         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
 834         all_objfiles.
 835         * source.c (forget_cached_source_info): Use all_objfiles.
 836         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
 837         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
 838         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
 839         * objfiles.c (update_section_map): Use all_objfiles.
 840         (shared_objfile_contains_address_p): Likewise.
 841         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
 842         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
 843
 844 2019-01-09  Tom Tromey  <tom@tromey.com>
 845
 846         * common/next-iterator.h: New file.
 847         * objfiles.h (class all_objfiles): New.
 848         (struct objfile_iterator): New.
 849
 850 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 851
 852         * NEWS: Move the description of the changed "frame", "select-frame",
 853          and "info frame" commands to the Changed commands section.
 854
 855 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
 856
 857         * gdbtypes.c (check_stub_method_group): Remove handling of old
 858         mangling schemes.
 859         * linespec.c (find_methods): Likewise.
 860         * stabsread.c (read_member_functions): Likewise.
 861         * valops.c (search_struct_method): Likewise.
 862         (value_struct_elt_for_reference): Likewise.
 863         * NEWS: Mention this change.
 864
 865 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 866
 867         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
 868         print_source_lines.
 869         * source.c (print_source_lines_base): Update line number check.
 870         (print_source_lines): New function.
 871         (source_lines_range::source_lines_range): New function.
 872         * source.h (class source_lines_range): New class.
 873         (print_source_lines): New declaration.
 874
 875 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 876
 877         * linespec.c (linespec_state_destructor): Free self->canonical_names.
 878
 879 2019-01-08  Tom Tromey  <tom@tromey.com>
 880             Simon Marchi  <simon.marchi@ericsson.com>
 881
 882         PR gdb/24060
 883         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
 884         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
 885         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
 886         * f-exp.y (DOLLAR_VARIABLE): Likewise.
 887         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
 888         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
 889
 890 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 891
 892         * source.c (select_source_symtab): Move header comment to
 893         declaration in source.h.
 894         (forget_cached_source_info_for_objfile): Likewise.
 895         (forget_cached_source_info): Likewise.
 896         (identify_source_line): Likewise.
 897         * source.h (identify_source_line): Move declaration from symtab.h
 898         and add comment from source.c
 899         (print_source_lines): Likewise.
 900         (forget_cached_source_info_for_objfile): Likewise.
 901         (forget_cached_source_info): Likewise.
 902         (select_source_symtab): Likewise.
 903         (enum print_source_lines_flag): Move definition from symtab.h.
 904         * symtab.h (identify_source_line): Move declaration to source.h.
 905         (print_source_lines): Likewise.
 906         (forget_cached_source_info_for_objfile): Likewise.
 907         (forget_cached_source_info): Likewise.
 908         (select_source_symtab): Likewise.
 909         (enum print_source_lines_flag): Move definition to source.h.
 910         * tui/tui-hooks.c: Add 'source.h' include.
 911
 912 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 913
 914         * source.c (print_source_lines_base): Handle requests to print
 915         reverse line number sequences, and guard against empty lines
 916         string.
 917
 918 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 919
 920         * source.c (print_source_lines_base): Fix skip of '\r' if next
 921         character is '\n'.
 922
 923 2019-01-06  Tom Tromey  <tom@tromey.com>
 924
 925         * c-exp.y (struct c_parse_state) <macro_original_text,
 926         expansion_obstack>: New member.
 927         (macro_original_text, expansion_obstack): Remove globals.
 928         (scan_macro_expansion, scanning_macro_expansion)
 929         (finished_macro_expansion): Update.
 930         (scan_macro_cleanup): Remove.
 931         (yylex, c_parse): Update.
 932
 933 2019-01-06  Tom Tromey  <tom@tromey.com>
 934
 935         * c-exp.y (struct c_parse_state) <strings>: New member.
 936         (operator_stoken): Update.
 937
 938 2019-01-06  Tom Tromey  <tom@tromey.com>
 939
 940         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
 941         (union type_stack_elt) <typelist_val>: Now a pointer to
 942         std::vector.
 943         (type_stack_cleanup): Don't declare.
 944         (push_typelist): Update.
 945         * parse.c (pop_typelist): Return a std::vector.
 946         (push_typelist): Take a std::vector.
 947         (follow_types): Update.  Do not free args.
 948         (type_stack_cleanup): Remove.
 949         * c-exp.y (struct c_parse_state): New.
 950         (cpstate): New global.
 951         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
 952         (nonempty_typelist): Update.
 953         (func_mod): Create a new vector.
 954         (c_parse): Create a c_parse_state.
 955         (check_parameter_typelist): Do not delete params.
 956         (function_method): Update.  Do not delete type_list.
 957
 958 2019-01-06  Tom Tromey  <tom@tromey.com>
 959
 960         PR gdb/28155:
 961         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
 962         check_typedef.
 963         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
 964         (print_return_value): Likewise.
 965
 966 2019-01-05  Tom Tromey  <tom@tromey.com>
 967
 968         * contrib/cleanup_check.py: Remove.
 969         * contrib/gcc-with-excheck: Remove.
 970         * contrib/exsummary.py: Remove.
 971         * contrib/excheck.py: Remove.
 972
 973 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
 974
 975         * thread.c (delete_thread_1): Add gdb_assert that THR is not
 976         NULL. Initialize tpprev to NULL instead of assigning it
 977         to NULL on the next statement.
 978         * windows-nat.c (windows_delete_thread): Remove check for
 979         main_thread_id before printing thread exit notifications.
 980         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
 981         Remove thread ID check against main_thread_id.
 982         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
 983         windows_delete_thread.
 984         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
 985
 986 2019-01-04  Tom Tromey  <tom@tromey.com>
 987
 988         * compile/compile.c (_initialize_compile): Use upper case for
 989         metasyntactic variables.
 990         * symmisc.c (_initialize_symmisc): Use upper case for
 991         metasyntactic variables.
 992         * psymtab.c (_initialize_psymtab): Use upper case for
 993         metasyntactic variables.
 994         * demangle.c (demangle_command): Use upper case for metasyntactic
 995         variables.
 996         (_initialize_demangler): Likewise.
 997         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
 998         variables.
 999
1000 2019-01-03  Tom Tromey  <tom@tromey.com>
1001
1002         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
1003
1004 2019-01-03  Tom Tromey  <tom@tromey.com>
1005
1006         * python/py-symtab.c (salpy_str): Update.
1007         (struct salpy_sal_object) <symtab>: Now a PyObject.
1008         (salpy_dealloc): Update.
1009         (del_objfile_sal): Use gdbpy_ref.
1010
1011 2019-01-03  Tom Tromey  <tom@tromey.com>
1012
1013         * python/py-type.c (convert_field): Use new_reference.  Return
1014         gdbpy_ref.
1015         (make_fielditem): Return gdbpy_ref.
1016         (typy_fields): Update.
1017         (typy_getitem): Update.
1018         (field_name): Return gdbpy_ref.  Use new_reference.
1019         (typy_iterator_iternext): Update.
1020
1021 2019-01-03  Tom Tromey  <tom@tromey.com>
1022
1023         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
1024
1025 2019-01-03  Tom Tromey  <tom@tromey.com>
1026
1027         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
1028         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
1029         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
1030         (pspy_set_frame_filters, pspy_set_frame_unwinders)
1031         (pspy_set_type_printers): Likewise.
1032         * python/py-function.c (fnpy_init): Use gdbpy_ref.
1033         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
1034         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
1035         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
1036         (objfpy_set_type_printers): Likewise.
1037
1038 2019-01-03  Tom Tromey  <tom@tromey.com>
1039
1040         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
1041         (gdbpy_print_stack): Use gdbpy_err_fetch.
1042         * python/python-internal.h (class gdbpy_err_fetch): New class.
1043         (class gdbpy_enter) <m_error_type, m_error_value,
1044         m_error_traceback>: Remove.
1045         <m_error>: New member.
1046         (gdbpy_exception_to_string): Don't declare.
1047         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
1048         * python/py-value.c (convert_value_from_python): Use
1049         gdbpy_err_fetch.
1050         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
1051         gdbpy_exception_to_string.
1052         (gdbpy_handle_exception): Use gdbpy_err_fetch.
1053         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1054         gdbpy_err_fetch.
1055
1056 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1057
1058         * linux-nat.c (delete_lwp_cleanup): Delete.
1059         (struct lwp_deleter): New struct.
1060         (lwp_info_up): New typedef.
1061         (linux_nat_target::follow_fork): Delete cleanup, and make use of
1062         lwp_info_up.
1063
1064 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1065
1066         * linux-fork.c (class scoped_switch_fork_info): New class.
1067         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
1068
1069 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1070
1071         * valops.c (find_overload_match): Remove use of null_cleanup, and
1072         calls to do_cleanups.
1073
1074 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1075
1076         * compile/compile-cplus-types.c
1077         (compile_cplus_instance::decl_name): Handle changes to
1078         cp_func_name.
1079         * cp-support.c (cp_func_name): Update header comment, update
1080         return type.
1081         * cp-support.h (cp_func_name): Update return type in declaration.
1082         * valops.c (find_overload_match): Move temp_func local to top
1083         level of function and change its type.  Use temp_func to hold and
1084         delete temporary string obtained from cp_func_name.
1085
1086 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1087
1088         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
1089         gdb::char_vector, remove cleanup, and update uses of `msg`.
1090
1091 2019-01-03  Jim Wilson  <jimw@sifive.com>
1092
1093         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
1094
1095 2019-01-02  Tom Tromey  <tom@tromey.com>
1096
1097         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
1098         (tdesc_parse_xml): Remove cleanups.
1099         * target-descriptions.h (make_cleanup_free_target_description):
1100         Don't declare.
1101         (target_desc_deleter): New struct.
1102         (target_desc_up): New typedef.
1103         * target-descriptions.c (target_desc_deleter::operator()): Rename
1104         from free_target_description.
1105         (make_cleanup_free_target_description): Remove.
1106
1107 2019-01-02  Tom Tromey  <tom@tromey.com>
1108
1109         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
1110         constructor, destructor.
1111         (linespec_parser): Remove typedef.
1112         (~linespec_parser): Rename from linespec_parser_delete.
1113         (linespec_lex_to_end, linespec_complete_label)
1114         (linespec_complete): Update.
1115         (decode_line_full): Remove cleanups.
1116         (decode_line_1): Update.
1117
1118 2019-01-02  Tom Tromey  <tom@tromey.com>
1119
1120         * python/python-internal.h (inferior_to_inferior_object): Change
1121         return type.
1122         * python/py-exitedevent.c (create_exited_event_object): Update.
1123         * python/py-inferior.c (inferior_to_inferior_object): Return
1124         gdbpy_ref.
1125         (python_new_inferior, python_inferior_deleted)
1126         (thread_to_thread_object, delete_thread_object)
1127         (build_inferior_list, gdbpy_selected_inferior): Update.
1128         * python/py-infthread.c (create_thread_object): Update.  Also fail
1129         if inferior_to_inferior_object fails.
1130
1131 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
1132
1133         * inferior.h (class inferior) <displaced_step_state>: New field.
1134         * infrun.h (struct displaced_step_state): Move here from
1135         infrun.c.  Initialize fields, add constructor.
1136         <inf>: Remove field.
1137         <reset>: New method.
1138         * infrun.c (struct displaced_step_inferior_state): Move to
1139         infrun.h.
1140         (displaced_step_inferior_states): Remove.
1141         (get_displaced_stepping_state): Adust.
1142         (displaced_step_in_progress_any_inferior): Adjust.
1143         (displaced_step_in_progress_thread): Adjust.
1144         (displaced_step_in_progress): Adjust.
1145         (add_displaced_stepping_state): Remove.
1146         (get_displaced_step_closure_by_addr): Adjust.
1147         (remove_displaced_stepping_state): Remove.
1148         (infrun_inferior_exit): Call displaced_step_state.reset.
1149         (use_displaced_stepping): Don't check for NULL.
1150         (displaced_step_prepare_throw): Call
1151         get_displaced_stepping_state.
1152         (displaced_step_fixup): Don't check for NULL.
1153         (prepare_for_detach): Don't check for NULL.
1154
1155 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1156
1157         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
1158          in case of call that did not complete.
1159
1160 2019-01-02  Andrey Utkin  <autkin@undo.io>
1161
1162         * symfile.c (find_separate_debug_file): Fix search of debug files for
1163         remote debuggee.
1164
1165 2019-01-02  Tom Tromey  <tom@tromey.com>
1166
1167         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
1168         indentation.
1169         * python/py-frame.c (frapy_older): Remove cast.
1170         (frapy_newer): Likewise.
1171         * python/py-breakpoint.c (local_setattro): Remove cast.
1172         * python/py-arch.c (archpy_name): Remove local variable.
1173         * python/py-type.c (gdbpy_lookup_type): Remove cast.
1174
1175 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
1176
1177         * unittests/basic_string_view/element_access/char/empty.cc:
1178         Fix year range in copyright header.
1179
1180 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1181
1182         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
1183         Delete.
1184         <operator==>: Update with for removed field.
1185         <hash>: Likewise.
1186         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
1187         <isa_features>: ...this.
1188         <abi_features>: New field.
1189         (riscv_isa_flen): Update comment.
1190         (riscv_abi_xlen): New declaration.
1191         (riscv_abi_flen): New declaration.
1192         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
1193         isa_features.
1194         (riscv_abi_xlen): New function.
1195         (riscv_isa_flen): Update to get answer from isa_features.
1196         (riscv_abi_flen): New function.
1197         (riscv_has_fp_abi): Update to get answer from abi_features.
1198         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
1199         xlen and flen.
1200         (riscv_call_info) <xlen, flen>: Update comment.
1201         (riscv_call_arg_struct): Remove invalid assertions
1202         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
1203         is removed.
1204         (riscv_gdbarch_init): Gather isa features and abi features
1205         separately, ensure both match on the gdbarch when reusing an old
1206         gdbarch.  Relax an error check to allow 32-bit abi float to run on
1207         a target with 64-bit float hardware.
1208
1209 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1210
1211         * source.c (search_command_helper): Stop reverse search
1212         when line 1 has been searched.
1213
1214 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1215
1216         * record-full.c (record_full_base_target::close): Rewrite
1217         record_full_core_buf_list free logic.
1218
1219 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1220
1221         * break-catch-syscall.c (print_one_catch_syscall): xfree
1222         the last text.
1223
1224 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1225
1226         * top.c (print_gdb_version): Update Copyright year in version
1227         message.
1228
1229 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1230
1231         Update copyright year range in all GDB files.
1232
1233 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
1234
1235         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
1236
1237 For older changes see ChangeLog-2018.
1238 \f
1239 Local Variables:
1240 mode: change-log
1241 left-margin: 8
1242 fill-column: 74
1243 version-control: never
1244 coding: utf-8
1245 End:
1246