gdb/lm32: Use default gdbarch methods where possible
[external/binutils.git] / gdb / ChangeLog
1 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2
3         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4         (lm32_unwind_pc): Delete.
5         (lm32_dummy_id): Delete.
6         (lm32_gdbarch_init): Don't register deleted functions with
7         gdbarch.
8
9 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10
11         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
12         (iq2000_unwind_pc): Delete.
13         (iq2000_dummy_id): Delete.
14         (iq2000_gdbarch_init): Don't register deleted functions with
15         gdbarch.
16
17 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
18
19         * nds32-tdep.c (nds32_type_align): Delete.
20         (nds32_push_dummy_call): Use type_align instead.
21
22 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
23
24         * arm-tdep.c (arm_type_align): Only handle vector override case.
25         (arm_push_dummy_call): Use type_align.
26         (arm_gdbarch_init): Register arm_type_align gdbarch function.
27
28 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
29
30         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
31         case.
32         (pass_on_stack): Use type_align.
33         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
34         function.
35
36 2019-04-23  Tom Tromey  <tromey@adacore.com>
37
38         * dwarf2read.c (line_header::file_name_at): Remove unused
39         overload.
40
41 2019-04-23  Tom de Vries  <tdevries@suse.de>
42
43         PR gdb/24438
44         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
45         invocation.
46
47
48 2019-03-27  Ali Tamur  <tamur@google.com>
49
50         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
51         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
52         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
53         (dwarf_expr_context::get_addr_index): Likewise
54         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
55         (symbol_needs_eval_context::get_addr_index): Likewise
56         (disassemble_dwarf_expression): Add DW_OP_addrx
57         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
58         (read_cutu_die_from_dwo): Update comment
59         (skip_one_die): Add DW_FORM_addrx
60         (read_attribute_value): Likewise
61         (var_decode_location): Add DW_OP_addrx
62         (dwarf2_const_value_attr): Add DW_FORM_addrx
63         (dump_die_shallow): Likewise
64         (dwarf2_fetch_constant_bytes): Likewise
65         (decode_locdesc): Add DW_OP_addrx
66         (skip_form_bytes): Add DW_FORM_addrx
67
68 2019-04-22  Ali Tamur  <tamur@google.com>
69
70         * MAINTAINERS (Write After Approval): Add self.
71
72 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
73
74         * solib-svr4.c (get_svr4_info): Add pspace parameter.
75         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
76         (open_symbol_file_object): Likewise.
77         (svr4_default_sos): Add info parameter.
78         (svr4_read_so_list): Likewise.
79         (svr4_current_sos_direct): Adjust functions calls to pass down
80         info.
81         (svr4_current_sos_1): Add info parameter.
82         (svr4_current_sos): Call get_svr4_info, pass info down to
83         svr4_current_sos_1.
84         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
85         get_svr4_info.
86         (svr4_in_dynsym_resolve_code): Pass current_program_space to
87         get_svr4_info.
88         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
89         to get_svr4_info.
90         (probes_table_remove_objfile_probes): Likewise.
91         (register_solib_event_probe): Add info parameter.
92         (solist_update_incremental): Pass info parameter down to
93         svr4_read_so_list.
94         (disable_probes_interface): Add info parameter.
95         (svr4_handle_solib_event): Pass current_program_space to
96         get_svr4_info.  Adjust disable_probes_interface cleanup.
97         (svr4_create_probe_breakpoints): Add info parameter, pass it
98         down to register_solib_event_probe.
99         (svr4_create_solib_event_breakpoints): Add info parameter,
100         pass it down to svr4_create_probe_breakpoints.
101         (enable_break): Pass info down to
102         svr4_create_solib_event_breakpoints.
103         (svr4_solib_create_inferior_hook): Pass current_program_space to
104         get_svr4_info.
105         (svr4_clear_solib): Likewise.
106
107 2019-04-22  Pedro Alves  <palves@redhat.com>
108
109         * solib-svr4.c (svr4_free_objfile_observer): New.
110         (probe_and_action::objfile): New field.
111         (probes_table_htab_remove_objfile_probes)
112         (probes_table_remove_objfile_probes): New functions.
113         (register_solib_event_probe): Add 'objfile' parameter.  Store it
114         in the new probe_and_action.  Don't store the probe in 'lookup'.
115         (svr4_create_probe_breakpoints): Pass objfile to
116         register_solib_event_probe.
117         (_initialize_svr4_solib): Register a free_objfile observer.
118
119 2019-04-19  Tom Tromey  <tom@tromey.com>
120
121         * common/queue.h: Remove.
122
123 2019-04-19  Tom Tromey  <tom@tromey.com>
124
125         * event-loop.c: Don't include "common/queue.h".
126
127 2019-04-19  Tom Tromey  <tom@tromey.com>
128
129         * remote.c (remote_target): Use delete.
130         * remote-notif.h: Include <list>, not "common/queue.h".
131         (notif_client_p): Remove typedef.
132         (remote_notif_state): Add constructor, destructor, initializer.
133         <notif_queue>: Now a std::list.
134         (remote_notif_state_xfree): Don't declare.
135         * remote-notif.c (remote_notif_process, handle_notification)
136         (remote_notif_state_allocate): Update.
137         (~remote_notif_state): Rename from remote_notif_state_xfree.
138
139 2019-04-19  Tom Tromey  <tom@tromey.com>
140
141         * symfile.c (reread_symbols): Update.
142         * objfiles.c (objfile_register_static_link)
143         (objfile_lookup_static_link): Update
144         (~objfile) Don't delete static_links.
145         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
146
147 2019-04-19  Tom Tromey  <tom@tromey.com>
148
149         * type-stack.h (struct type_stack) <insert>: Constify string.
150         * type-stack.c (type_stack::insert): Constify string.
151         * gdbtypes.h (lookup_template_type): Update.
152         (address_space_name_to_int): Update.
153         * gdbtypes.c (address_space_name_to_int): Make space_identifier
154         const.
155         (lookup_template_type): Make name const.
156         * c-exp.y: Update rules.
157         (lex_one_token, classify_name, classify_inner_name)
158         (c_print_token): Update.
159         * p-exp.y: Update rules.
160         (yylex): Update.
161         * f-exp.y: Update rules.
162         (yylex): Update.
163         * d-exp.y: Update rules.
164         (lex_one_token, classify_name, classify_inner_name): Update.
165         * parse.c (write_dollar_variable, copy_name): Return std::string.
166         * parser-defs.h (copy_name): Change return type.
167         * m2-exp.y: Update rules.
168         (yylex): Update.
169         * go-exp.y (lex_one_token): Update.
170         Update rules.
171         (classify_unsafe_function, classify_packaged_name)
172         (classify_name, yylex): Update.
173
174 2019-04-19  Sergei Trofimovich <siarheit@google.com>
175
176         * configure.ac: add --enable-source-highlight switch.
177         * configure: Regenerate.
178         * top.c (print_gdb_version): plumb --enable-source-highlight
179         status to "show configuration".
180
181 2019-04-19  Tom Tromey  <tromey@adacore.com>
182
183         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
184         Check ADA_TYPE_P.
185         (empty_record, ada_template_to_fixed_record_type_1)
186         (template_to_static_fixed_type)
187         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
188         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
189         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
190         macros.
191
192 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
193
194         PR symtab/24423:
195         * source.c (print_source_lines_base): Advance "iter" when a
196         control character is seen.
197
198 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
199
200         * inferior.h (struct infcall_suspend_state_deleter):
201         Catch exception in destructor to avoid crash.
202
203 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
204
205         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
206         close to the add_com "shell".
207
208 2019-04-18  Tom Tromey  <tromey@adacore.com>
209
210         * process-stratum-target.h (class process_stratum_target)
211         <stratum>: Add "final".
212
213 2019-04-17  Tom Tromey  <tromey@adacore.com>
214
215         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
216         against nullptr before use.
217
218 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
219
220         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
221
222 2019-04-17  Jim Wilson  <jimw@sifive.com>
223             Andrew Burgess  <andrew.burgess@embecosm.com>
224
225         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
226         code read might fail, assume 4-byte breakpoint in that case.
227
228 2019-04-15  Leszek Swirski  <leszeks@google.com>
229
230         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
231         rather than a hand-rolled POD check when checking for forced MEMORY
232         classification.
233
234 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
235
236         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
237         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
238         function.
239         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
240         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
241         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
242         declaration.
243
244 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
245
246         * aarch64-linux-nat.c
247         (aarch64_linux_nat_target::thread_architecture): Add override.
248         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
249         each VQ.
250
251 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
252
253         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
254
255 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
256
257         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
258         target types of size 96-bits, add some additional comments, and
259         check that the builtin type we found was the correct size.
260
261 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
262
263         * utils.c (prompt_for_continue): Don't restore the styling at the
264         end, as applied_style has the wrong value.  This fixes styling in
265         long lists of file names that are interrupted by the "Continue?"
266         prompt.
267
268 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
269
270         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
271         * c-lang.c (c_language_defn): Likewise.
272         (cplus_language_defn): Likewise.
273         (asm_language_defn): Likewise.
274         (minimal_language_defn): Likewise.
275         * d-lang.c (d_language_defn): Likewise.
276         * f-lang.c (f_language_defn): Likewise.
277         * go-lang.c (go_language_defn): Likewise.
278         * language.c (unknown_language_defn): Likewise.
279         (auto_language_defn): Likewise.
280         * language.h (struct language_defn): Remove la_magic field.
281         (LANG_MAGIC): Delete.
282         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
283         * objc-lang.c (objc_language_defn): Likewise.
284         * opencl-lang.c (opencl_language_defn): Likewise.
285         * p-lang.c (pascal_language_defn): Likewise.
286         * rust-lang.c (rust_language_defn): Likewise.
287
288 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
289
290         * riscv-tdep.c (riscv_type_align): New function.
291         (riscv_type_alignment): Delete.
292         (riscv_arg_location): Use 'type_align'.
293         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
294
295 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
296
297         * gdbtypes.c (type_align): A struct with no non-static fields also
298         has alignment of 1.
299
300 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
301
302         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
303         component to 0.
304         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
305         member.
306         (riscv_struct_info::analyse): New implementation using new
307         analyse_inner member function.
308         (riscv_struct_info::field_offset): New member function.
309         (riscv_struct_info::m_offsets): New member variable.
310         (riscv_struct_info::analyse_inner): New private member function,
311         takes the old implementation of riscv_struct_info::analyse but
312         extended to track field offsets.
313         (riscv_call_arg_struct): Update the struct folding special cases
314         to handle cases where empty C++ structs, which are non-zero
315         length, are found.
316         (riscv_arg_location): Initialise the length of each location, a
317         non-zero length now indicates the location is in use.
318         (riscv_push_dummy_call): Allow for the first location having a
319         non-zero offset when setting up arguments.
320         (riscv_return_value): Likewise, but for return values.
321
322 2019-04-11  Tom Tromey  <tromey@adacore.com>
323
324         * utils.c (internal_vproblem): Make "msg" const.
325
326 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
327
328         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
329         * trad-frame.c (trad_frame_reset_saved_regs): New function.
330         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
331         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
332
333 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
334
335         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
336         function.
337         (fill_gregset): Call amd64_linux_collect_native_gregset instead
338         of amd64_collect_native_gregset.
339         (amd64_linux_nat_target::store_registers): Likewise.
340
341 2019-04-10  Tom Tromey  <tom@tromey.com>
342
343         * symtab.c (lookup_global_symbol_from_objfile)
344         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
345         * objfiles.h (class separate_debug_iterator): New.
346         (class separate_debug_range): New.
347         (struct objfile) <separate_debug_objfiles>: New method.
348         (objfile_separate_debug_iterate): Don't declare.
349         * objfiles.c (separate_debug_iterator::operator++): Rename from
350         objfile_separate_debug_iterate.
351         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
352         iterator.
353         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
354         iterator.
355
356 2019-04-10  Tom Tromey  <tom@tromey.com>
357
358         * symfile.c (reread_symbols): Remove old comment.
359         * objfiles.c (free_all_objfiles): Fix a typo.
360
361 2019-04-10  Tom Tromey  <tom@tromey.com>
362
363         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
364         * minsyms.c (lookup_minimal_symbol): Use foreach.
365         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
366         (lookup_minimal_symbol_solib_trampoline): Likewise.
367         * symfile.c (reread_symbols): Use foreach.
368
369 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
370             Tom Tromey  <tromey@adacore.com>
371
372         PR rust/24414:
373         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
374         (rust_lex_int_test): Change "value" to be LONGEST.
375         (rust_lex_tests): Add test for long integer literal.
376
377 2019-04-09  Tom Tromey  <tromey@adacore.com>
378
379         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
380         to bool.
381         (extended_remote_target::attach): Update.
382         (remote_target::remote_notice_new_inferior): Update.
383         (remote_target::add_current_inferior_and_thread): Update.
384         * inferior.c (exit_inferior_1): Use "false".
385         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
386
387 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
388
389         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
390         the "start" command.
391
392 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
393
394         * python/py-inferior.c (infpy_thread_from_thread_handle):
395         Adjust comments to reflect renaming of thread_from_thread_handle
396         to thread_from_handle.  Adjust keywords.  Fix type error message.
397         (inferior_object_methods): Add thread_from_handle.  Retain
398         thread_from_thread_handle, but mark it as deprecated.
399
400 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
401
402         * gdbthread.h (find_thread_by_handle): Revise declaration.
403         * thread.c (find_thread_by_handle): Likewise.  Adjust
404         implementation too.
405         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
406         support for buffer objects as handles.
407
408 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
409
410         * python/py-infthread.c (thpy_thread_handle): New function.
411         (thread_object_methods): Register thpy_thread_handle.
412
413 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
414
415         * gdbthread.h (thread_to_thread_handle): Declare.
416         * thread.c (gdbtypes.h): Include.
417         (thread_to_thread_handle): New function.
418
419         * target.h (struct target_ops): Add thread_info_to_thread_handle.
420         (target_thread_info_to_thread_handle): Declare.
421         * target.c (target_thread_info_to_thread_handle): New function.
422         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
423         * target-delegates.c: Regenerate.
424
425         * linux-thread-db.c (class thread_db_target): Add method
426         thread_info_to_thread_handle.
427         (thread_db_target::thread_info_to_thread_handle): Define.
428         * remote.c (class remote_target): Add new method
429         thread_info_to_thread_handle.
430         (remote_target::thread_info_to_thread_handle): Define.
431
432 2019-04-08  Pedro Alves  <palves@redhat.com>
433
434         * common/common-exceptions.c (throw_exception): Don't create
435         named object to throw; throw directly.
436         (throw_it): Likewise.  Don't initialize gdb_exception::message
437         here, with new; pass FMT and AP to the ctor instead.
438         * common/common-exceptions.h: Include <string>.
439         (gdb_exception::gdb_exception(enum return_reason, enum errors,
440         const char *, va_list)): New ctor.  Use std::make_shared.
441         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
442         errors)): Delete.
443         (gdb_exception_error::gdb_exception_error(enum errors, const char
444         *, va_list)): New.
445         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
446         Add assertion.
447         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
448         errors)): Delete.
449         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
450         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
451         Add assertion.
452
453 2019-04-08  Tom Tromey  <tom@tromey.com>
454
455         * valops.c (value_rtti_indirect_type): Replace throw_exception
456         with throw.
457         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
458         with throw.
459         * thread.c (thr_try_catch_cmd): Replace throw_exception with
460         throw.
461         * target.c (target_translate_tls_address): Replace throw_exception
462         with throw.
463         * stack.c (frame_apply_command_count): Replace throw_exception
464         with throw.
465         * solib-spu.c (append_ocl_sos): Replace throw_exception with
466         throw.
467         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
468         with throw.
469         * rs6000-tdep.c (rs6000_frame_cache)
470         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
471         * remote.c: Replace throw_exception with throw.
472         * record-full.c (record_full_message, record_full_wait_1)
473         (record_full_restore): Replace throw_exception with throw.
474         * record-btrace.c:
475         (get_thread_current_frame_id, record_btrace_start_replaying)
476         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
477         (cmd_record_btrace_start): Replace throw_exception with throw.
478         * parse.c (parse_exp_in_context_1): Replace throw_exception with
479         throw.
480         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
481         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
482         * linespec.c:
483         (find_linespec_symbols): Replace throw_exception with throw.
484         * infrun.c (displaced_step_prepare, resume): Replace
485         throw_exception with throw.
486         * infcmd.c (post_create_inferior): Replace throw_exception with
487         throw.
488         * inf-loop.c (inferior_event_handler): Replace throw_exception
489         with throw.
490         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
491         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
492         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
493         (get_prev_frame_always, get_frame_pc_if_available)
494         (get_frame_address_in_block_if_available, get_frame_language):
495         Replace throw_exception with throw.
496         * frame-unwind.c (frame_unwind_try_unwinder): Replace
497         throw_exception with throw.
498         * eval.c (fetch_subexp_value, evaluate_var_value)
499         (evaluate_funcall, evaluate_subexp_standard): Replace
500         throw_exception with throw.
501         * dwarf2loc.c (call_site_find_chain)
502         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
503         Replace throw_exception with throw.
504         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
505         with throw.
506         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
507         throw.
508         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
509         * completer.c (complete_line_internal): Replace throw_exception
510         with throw.
511         * compile/compile-object-run.c (compile_object_run): Replace
512         throw_exception with throw.
513         * cli/cli-script.c (process_next_line): Replace throw_exception
514         with throw.
515         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
516         (btrace_enable, btrace_maint_update_pt_packets): Replace
517         throw_exception with throw.
518         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
519         throw_exception with throw.
520         * break-catch-throw.c (re_set_exception_catchpoint): Replace
521         throw_exception with throw.
522         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
523         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
524         * aarch64-tdep.c (aarch64_make_prologue_cache)
525         (aarch64_make_stub_cache): Replace throw_exception with throw.
526
527 2019-04-08  Tom Tromey  <tom@tromey.com>
528
529         * common/common-exceptions.c (throw_exception): Rename from
530         throw_exception_cxx.  Remove old copy.  Make argument const.
531         (throw_it): Create and throw exception objects directly.
532         * common/common-exceptions.h (throw_exception): Make argument
533         const.
534         (struct gdb_exception_error): Add constructor.
535         (struct gdb_exception_quit): Add constructor.
536
537 2019-04-08  Tom Tromey  <tom@tromey.com>
538
539         * common/common-exceptions.h (exception_rethrow): Don't declare.
540         (TRY_SJLJ): Update comment.
541         (TRY, CATCH, END_CATCH): Remove.
542         * common/common-exceptions.c (exception_rethrow): Remove.
543
544 2019-04-08  Tom Tromey  <tom@tromey.com>
545
546         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
547         Remove.
548         (gdb_exception_error): Rename from
549         gdb_exception_RETURN_MASK_ERROR.
550         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
551         (gdb_quit_bad_alloc): Update.
552         * aarch64-tdep.c: Update.
553         * ada-lang.c: Update.
554         * ada-typeprint.c: Update.
555         * ada-valprint.c: Update.
556         * amd64-tdep.c: Update.
557         * arch-utils.c: Update.
558         * break-catch-throw.c: Update.
559         * breakpoint.c: Update.
560         * btrace.c: Update.
561         * c-varobj.c: Update.
562         * cli/cli-cmds.c: Update.
563         * cli/cli-interp.c: Update.
564         * cli/cli-script.c: Update.
565         * common/common-exceptions.c: Update.
566         * common/new-op.c: Update.
567         * common/selftest.c: Update.
568         * compile/compile-c-symbols.c: Update.
569         * compile/compile-cplus-symbols.c: Update.
570         * compile/compile-object-load.c: Update.
571         * compile/compile-object-run.c: Update.
572         * completer.c: Update.
573         * corelow.c: Update.
574         * cp-abi.c: Update.
575         * cp-support.c: Update.
576         * cp-valprint.c: Update.
577         * darwin-nat.c: Update.
578         * disasm-selftests.c: Update.
579         * dtrace-probe.c: Update.
580         * dwarf-index-cache.c: Update.
581         * dwarf-index-write.c: Update.
582         * dwarf2-frame-tailcall.c: Update.
583         * dwarf2-frame.c: Update.
584         * dwarf2loc.c: Update.
585         * dwarf2read.c: Update.
586         * eval.c: Update.
587         * event-loop.c: Update.
588         * event-top.c: Update.
589         * exec.c: Update.
590         * f-valprint.c: Update.
591         * fbsd-tdep.c: Update.
592         * frame-unwind.c: Update.
593         * frame.c: Update.
594         * gdbtypes.c: Update.
595         * gnu-v3-abi.c: Update.
596         * guile/guile-internal.h: Update.
597         * guile/scm-block.c: Update.
598         * guile/scm-breakpoint.c: Update.
599         * guile/scm-cmd.c: Update.
600         * guile/scm-disasm.c: Update.
601         * guile/scm-frame.c: Update.
602         * guile/scm-lazy-string.c: Update.
603         * guile/scm-math.c: Update.
604         * guile/scm-param.c: Update.
605         * guile/scm-ports.c: Update.
606         * guile/scm-pretty-print.c: Update.
607         * guile/scm-symbol.c: Update.
608         * guile/scm-symtab.c: Update.
609         * guile/scm-type.c: Update.
610         * guile/scm-value.c: Update.
611         * i386-linux-tdep.c: Update.
612         * i386-tdep.c: Update.
613         * inf-loop.c: Update.
614         * infcall.c: Update.
615         * infcmd.c: Update.
616         * infrun.c: Update.
617         * jit.c: Update.
618         * language.c: Update.
619         * linespec.c: Update.
620         * linux-fork.c: Update.
621         * linux-nat.c: Update.
622         * linux-tdep.c: Update.
623         * linux-thread-db.c: Update.
624         * main.c: Update.
625         * mi/mi-cmd-break.c: Update.
626         * mi/mi-cmd-stack.c: Update.
627         * mi/mi-interp.c: Update.
628         * mi/mi-main.c: Update.
629         * objc-lang.c: Update.
630         * p-valprint.c: Update.
631         * parse.c: Update.
632         * ppc-linux-tdep.c: Update.
633         * printcmd.c: Update.
634         * python/py-arch.c: Update.
635         * python/py-breakpoint.c: Update.
636         * python/py-cmd.c: Update.
637         * python/py-finishbreakpoint.c: Update.
638         * python/py-frame.c: Update.
639         * python/py-framefilter.c: Update.
640         * python/py-gdb-readline.c: Update.
641         * python/py-inferior.c: Update.
642         * python/py-infthread.c: Update.
643         * python/py-lazy-string.c: Update.
644         * python/py-linetable.c: Update.
645         * python/py-objfile.c: Update.
646         * python/py-param.c: Update.
647         * python/py-prettyprint.c: Update.
648         * python/py-progspace.c: Update.
649         * python/py-record-btrace.c: Update.
650         * python/py-record.c: Update.
651         * python/py-symbol.c: Update.
652         * python/py-type.c: Update.
653         * python/py-unwind.c: Update.
654         * python/py-utils.c: Update.
655         * python/py-value.c: Update.
656         * python/python.c: Update.
657         * record-btrace.c: Update.
658         * record-full.c: Update.
659         * remote-fileio.c: Update.
660         * remote.c: Update.
661         * riscv-tdep.c: Update.
662         * rs6000-aix-tdep.c: Update.
663         * rs6000-tdep.c: Update.
664         * rust-exp.y: Update.
665         * rust-lang.c: Update.
666         * s390-tdep.c: Update.
667         * selftest-arch.c: Update.
668         * solib-dsbt.c: Update.
669         * solib-frv.c: Update.
670         * solib-spu.c: Update.
671         * solib-svr4.c: Update.
672         * solib.c: Update.
673         * sparc64-linux-tdep.c: Update.
674         * stack.c: Update.
675         * symfile-mem.c: Update.
676         * symmisc.c: Update.
677         * target.c: Update.
678         * thread.c: Update.
679         * top.c: Update.
680         * tracefile-tfile.c: Update.
681         * tui/tui.c: Update.
682         * typeprint.c: Update.
683         * unittests/cli-utils-selftests.c: Update.
684         * unittests/parse-connection-spec-selftests.c: Update.
685         * valops.c: Update.
686         * valprint.c: Update.
687         * value.c: Update.
688         * varobj.c: Update.
689         * windows-nat.c: Update.
690         * x86-linux-nat.c: Update.
691         * xml-support.c: Update.
692
693 2019-04-08  Tom Tromey  <tom@tromey.com>
694
695         * xml-support.c: Use C++ exception handling.
696         * x86-linux-nat.c: Use C++ exception handling.
697         * windows-nat.c: Use C++ exception handling.
698         * varobj.c: Use C++ exception handling.
699         * value.c: Use C++ exception handling.
700         * valprint.c: Use C++ exception handling.
701         * valops.c: Use C++ exception handling.
702         * unittests/parse-connection-spec-selftests.c: Use C++ exception
703         handling.
704         * unittests/cli-utils-selftests.c: Use C++ exception handling.
705         * typeprint.c: Use C++ exception handling.
706         * tui/tui.c: Use C++ exception handling.
707         * tracefile-tfile.c: Use C++ exception handling.
708         * top.c: Use C++ exception handling.
709         * thread.c: Use C++ exception handling.
710         * target.c: Use C++ exception handling.
711         * symmisc.c: Use C++ exception handling.
712         * symfile-mem.c: Use C++ exception handling.
713         * stack.c: Use C++ exception handling.
714         * sparc64-linux-tdep.c: Use C++ exception handling.
715         * solib.c: Use C++ exception handling.
716         * solib-svr4.c: Use C++ exception handling.
717         * solib-spu.c: Use C++ exception handling.
718         * solib-frv.c: Use C++ exception handling.
719         * solib-dsbt.c: Use C++ exception handling.
720         * selftest-arch.c: Use C++ exception handling.
721         * s390-tdep.c: Use C++ exception handling.
722         * rust-lang.c: Use C++ exception handling.
723         * rust-exp.y: Use C++ exception handling.
724         * rs6000-tdep.c: Use C++ exception handling.
725         * rs6000-aix-tdep.c: Use C++ exception handling.
726         * riscv-tdep.c: Use C++ exception handling.
727         * remote.c: Use C++ exception handling.
728         * remote-fileio.c: Use C++ exception handling.
729         * record-full.c: Use C++ exception handling.
730         * record-btrace.c: Use C++ exception handling.
731         * python/python.c: Use C++ exception handling.
732         * python/py-value.c: Use C++ exception handling.
733         * python/py-utils.c: Use C++ exception handling.
734         * python/py-unwind.c: Use C++ exception handling.
735         * python/py-type.c: Use C++ exception handling.
736         * python/py-symbol.c: Use C++ exception handling.
737         * python/py-record.c: Use C++ exception handling.
738         * python/py-record-btrace.c: Use C++ exception handling.
739         * python/py-progspace.c: Use C++ exception handling.
740         * python/py-prettyprint.c: Use C++ exception handling.
741         * python/py-param.c: Use C++ exception handling.
742         * python/py-objfile.c: Use C++ exception handling.
743         * python/py-linetable.c: Use C++ exception handling.
744         * python/py-lazy-string.c: Use C++ exception handling.
745         * python/py-infthread.c: Use C++ exception handling.
746         * python/py-inferior.c: Use C++ exception handling.
747         * python/py-gdb-readline.c: Use C++ exception handling.
748         * python/py-framefilter.c: Use C++ exception handling.
749         * python/py-frame.c: Use C++ exception handling.
750         * python/py-finishbreakpoint.c: Use C++ exception handling.
751         * python/py-cmd.c: Use C++ exception handling.
752         * python/py-breakpoint.c: Use C++ exception handling.
753         * python/py-arch.c: Use C++ exception handling.
754         * printcmd.c: Use C++ exception handling.
755         * ppc-linux-tdep.c: Use C++ exception handling.
756         * parse.c: Use C++ exception handling.
757         * p-valprint.c: Use C++ exception handling.
758         * objc-lang.c: Use C++ exception handling.
759         * mi/mi-main.c: Use C++ exception handling.
760         * mi/mi-interp.c: Use C++ exception handling.
761         * mi/mi-cmd-stack.c: Use C++ exception handling.
762         * mi/mi-cmd-break.c: Use C++ exception handling.
763         * main.c: Use C++ exception handling.
764         * linux-thread-db.c: Use C++ exception handling.
765         * linux-tdep.c: Use C++ exception handling.
766         * linux-nat.c: Use C++ exception handling.
767         * linux-fork.c: Use C++ exception handling.
768         * linespec.c: Use C++ exception handling.
769         * language.c: Use C++ exception handling.
770         * jit.c: Use C++ exception handling.
771         * infrun.c: Use C++ exception handling.
772         * infcmd.c: Use C++ exception handling.
773         * infcall.c: Use C++ exception handling.
774         * inf-loop.c: Use C++ exception handling.
775         * i386-tdep.c: Use C++ exception handling.
776         * i386-linux-tdep.c: Use C++ exception handling.
777         * guile/scm-value.c: Use C++ exception handling.
778         * guile/scm-type.c: Use C++ exception handling.
779         * guile/scm-symtab.c: Use C++ exception handling.
780         * guile/scm-symbol.c: Use C++ exception handling.
781         * guile/scm-pretty-print.c: Use C++ exception handling.
782         * guile/scm-ports.c: Use C++ exception handling.
783         * guile/scm-param.c: Use C++ exception handling.
784         * guile/scm-math.c: Use C++ exception handling.
785         * guile/scm-lazy-string.c: Use C++ exception handling.
786         * guile/scm-frame.c: Use C++ exception handling.
787         * guile/scm-disasm.c: Use C++ exception handling.
788         * guile/scm-cmd.c: Use C++ exception handling.
789         * guile/scm-breakpoint.c: Use C++ exception handling.
790         * guile/scm-block.c: Use C++ exception handling.
791         * guile/guile-internal.h: Use C++ exception handling.
792         * gnu-v3-abi.c: Use C++ exception handling.
793         * gdbtypes.c: Use C++ exception handling.
794         * frame.c: Use C++ exception handling.
795         * frame-unwind.c: Use C++ exception handling.
796         * fbsd-tdep.c: Use C++ exception handling.
797         * f-valprint.c: Use C++ exception handling.
798         * exec.c: Use C++ exception handling.
799         * event-top.c: Use C++ exception handling.
800         * event-loop.c: Use C++ exception handling.
801         * eval.c: Use C++ exception handling.
802         * dwarf2read.c: Use C++ exception handling.
803         * dwarf2loc.c: Use C++ exception handling.
804         * dwarf2-frame.c: Use C++ exception handling.
805         * dwarf2-frame-tailcall.c: Use C++ exception handling.
806         * dwarf-index-write.c: Use C++ exception handling.
807         * dwarf-index-cache.c: Use C++ exception handling.
808         * dtrace-probe.c: Use C++ exception handling.
809         * disasm-selftests.c: Use C++ exception handling.
810         * darwin-nat.c: Use C++ exception handling.
811         * cp-valprint.c: Use C++ exception handling.
812         * cp-support.c: Use C++ exception handling.
813         * cp-abi.c: Use C++ exception handling.
814         * corelow.c: Use C++ exception handling.
815         * completer.c: Use C++ exception handling.
816         * compile/compile-object-run.c: Use C++ exception handling.
817         * compile/compile-object-load.c: Use C++ exception handling.
818         * compile/compile-cplus-symbols.c: Use C++ exception handling.
819         * compile/compile-c-symbols.c: Use C++ exception handling.
820         * common/selftest.c: Use C++ exception handling.
821         * common/new-op.c: Use C++ exception handling.
822         * cli/cli-script.c: Use C++ exception handling.
823         * cli/cli-interp.c: Use C++ exception handling.
824         * cli/cli-cmds.c: Use C++ exception handling.
825         * c-varobj.c: Use C++ exception handling.
826         * btrace.c: Use C++ exception handling.
827         * breakpoint.c: Use C++ exception handling.
828         * break-catch-throw.c: Use C++ exception handling.
829         * arch-utils.c: Use C++ exception handling.
830         * amd64-tdep.c: Use C++ exception handling.
831         * ada-valprint.c: Use C++ exception handling.
832         * ada-typeprint.c: Use C++ exception handling.
833         * ada-lang.c: Use C++ exception handling.
834         * aarch64-tdep.c: Use C++ exception handling.
835
836 2019-04-08  Tom Tromey  <tom@tromey.com>
837
838         * xml-support.c (gdb_xml_parser::parse): Update.
839         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
840         * value.c (show_convenience): Update.
841         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
842         (test_parse_flags_qcs): Update.
843         * thread.c (thr_try_catch_cmd): Update.
844         * target.c (target_translate_tls_address): Update.
845         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
846         (info_frame_command_core, frame_apply_command_count): Update.
847         * rust-exp.y (rust_lex_exception_test): Update.
848         * riscv-tdep.c (riscv_print_one_register_info): Update.
849         * remote.c (remote_target::enable_btrace): Update.
850         * record-btrace.c (record_btrace_enable_warn): Update.
851         * python/py-utils.c (gdbpy_convert_exception): Update.
852         * printcmd.c (do_one_display, print_variable_and_value): Update.
853         * mi/mi-main.c (mi_print_exception): Update.
854         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
855         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
856         * linux-nat.c (linux_nat_target::attach): Update.
857         * linux-fork.c (class scoped_switch_fork_info): Update.
858         * infrun.c (displaced_step_prepare): Update.
859         * infcall.c (call_function_by_hand_dummy): Update.
860         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
861         * gnu-v3-abi.c (print_one_vtable): Update.
862         * frame.c (get_prev_frame_always): Update.
863         * f-valprint.c (info_common_command_for_block): Update.
864         * exec.c (try_open_exec_file): Update.
865         * exceptions.c (print_exception, exception_print)
866         (exception_fprintf, exception_print_same): Update.
867         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
868         * dwarf-index-cache.c (index_cache::store)
869         (index_cache::lookup_gdb_index): Update.
870         * darwin-nat.c (maybe_cache_shell): Update.
871         * cp-valprint.c (cp_print_value_fields): Update.
872         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
873         (gcc_cplus_symbol_address): Update.
874         * compile/compile-c-symbols.c (gcc_convert_symbol)
875         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
876         * common/selftest.c: Update.
877         * common/common-exceptions.h (struct gdb_exception) <message>: Now
878         a std::string.
879         (exception_try_scope_entry, exception_try_scope_exit): Don't
880         declare.
881         (struct exception_try_scope): Remove.
882         (TRY): Don't use exception_try_scope.
883         (struct gdb_exception): Add constructor, operator=.
884         <what>: New method.
885         (struct gdb_exception_RETURN_MASK_ALL)
886         (struct gdb_exception_RETURN_MASK_ERROR)
887         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
888         (struct gdb_quit_bad_alloc): Update.
889         * common/common-exceptions.c (exception_none): Change
890         initializer.
891         (struct catcher) <state, exception>: Initialize inline.
892         <prev>: Remove member.
893         (current_catcher): Remove.
894         (catchers): New global.
895         (exceptions_state_mc_init): Simplify.
896         (catcher_pop): Remove.
897         (exceptions_state_mc, exceptions_state_mc_catch): Update.
898         (try_scope_depth, exception_try_scope_entry)
899         (exception_try_scope_exit): Remove.
900         (throw_exception_sjlj): Update.
901         (exception_messages, exception_messages_size): Remove.
902         (throw_it): Simplify.
903         (gdb_exception_sliced_copy): Remove.
904         (throw_exception_cxx): Update.
905         * cli/cli-script.c (script_from_file): Update.
906         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
907         Update.
908         * ada-valprint.c (ada_val_print): Update.
909         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
910         (create_excep_cond_exprs): Update.
911
912 2019-04-08  Tom Tromey  <tom@tromey.com>
913
914         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
915         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
916         (TRY, CATCH, END_CATCH): Remove some definitions.
917         * common/common-exceptions.c: Don't use GDB_XCPT.
918         (catcher_list_size): Remove.
919         (throw_exception, throw_it): Simplify.
920
921 2019-04-05  Tom Tromey  <tom@tromey.com>
922
923         Revert the header-sorting patch.
924         * ft32-tdep.c: Revert.
925         * frv-tdep.c: Revert.
926         * frv-linux-tdep.c: Revert.
927         * frame.c: Revert.
928         * frame-unwind.c: Revert.
929         * frame-base.c: Revert.
930         * fork-child.c: Revert.
931         * findvar.c: Revert.
932         * findcmd.c: Revert.
933         * filesystem.c: Revert.
934         * filename-seen-cache.h: Revert.
935         * filename-seen-cache.c: Revert.
936         * fbsd-tdep.c: Revert.
937         * fbsd-nat.h: Revert.
938         * fbsd-nat.c: Revert.
939         * f-valprint.c: Revert.
940         * f-typeprint.c: Revert.
941         * f-lang.c: Revert.
942         * extension.h: Revert.
943         * extension.c: Revert.
944         * extension-priv.h: Revert.
945         * expprint.c: Revert.
946         * exec.h: Revert.
947         * exec.c: Revert.
948         * exceptions.c: Revert.
949         * event-top.c: Revert.
950         * event-loop.c: Revert.
951         * eval.c: Revert.
952         * elfread.c: Revert.
953         * dwarf2read.h: Revert.
954         * dwarf2read.c: Revert.
955         * dwarf2loc.c: Revert.
956         * dwarf2expr.h: Revert.
957         * dwarf2expr.c: Revert.
958         * dwarf2-frame.c: Revert.
959         * dwarf2-frame-tailcall.c: Revert.
960         * dwarf-index-write.h: Revert.
961         * dwarf-index-write.c: Revert.
962         * dwarf-index-common.c: Revert.
963         * dwarf-index-cache.h: Revert.
964         * dwarf-index-cache.c: Revert.
965         * dummy-frame.c: Revert.
966         * dtrace-probe.c: Revert.
967         * disasm.h: Revert.
968         * disasm.c: Revert.
969         * disasm-selftests.c: Revert.
970         * dictionary.c: Revert.
971         * dicos-tdep.c: Revert.
972         * demangle.c: Revert.
973         * dcache.h: Revert.
974         * dcache.c: Revert.
975         * darwin-nat.h: Revert.
976         * darwin-nat.c: Revert.
977         * darwin-nat-info.c: Revert.
978         * d-valprint.c: Revert.
979         * d-namespace.c: Revert.
980         * d-lang.c: Revert.
981         * ctf.c: Revert.
982         * csky-tdep.c: Revert.
983         * csky-linux-tdep.c: Revert.
984         * cris-tdep.c: Revert.
985         * cris-linux-tdep.c: Revert.
986         * cp-valprint.c: Revert.
987         * cp-support.c: Revert.
988         * cp-namespace.c: Revert.
989         * cp-abi.c: Revert.
990         * corelow.c: Revert.
991         * corefile.c: Revert.
992         * continuations.c: Revert.
993         * completer.h: Revert.
994         * completer.c: Revert.
995         * complaints.c: Revert.
996         * coffread.c: Revert.
997         * coff-pe-read.c: Revert.
998         * cli-out.h: Revert.
999         * cli-out.c: Revert.
1000         * charset.c: Revert.
1001         * c-varobj.c: Revert.
1002         * c-valprint.c: Revert.
1003         * c-typeprint.c: Revert.
1004         * c-lang.c: Revert.
1005         * buildsym.c: Revert.
1006         * buildsym-legacy.c: Revert.
1007         * build-id.h: Revert.
1008         * build-id.c: Revert.
1009         * btrace.c: Revert.
1010         * bsd-uthread.c: Revert.
1011         * breakpoint.h: Revert.
1012         * breakpoint.c: Revert.
1013         * break-catch-throw.c: Revert.
1014         * break-catch-syscall.c: Revert.
1015         * break-catch-sig.c: Revert.
1016         * blockframe.c: Revert.
1017         * block.c: Revert.
1018         * bfin-tdep.c: Revert.
1019         * bfin-linux-tdep.c: Revert.
1020         * bfd-target.c: Revert.
1021         * bcache.c: Revert.
1022         * ax-general.c: Revert.
1023         * ax-gdb.h: Revert.
1024         * ax-gdb.c: Revert.
1025         * avr-tdep.c: Revert.
1026         * auxv.c: Revert.
1027         * auto-load.c: Revert.
1028         * arm-wince-tdep.c: Revert.
1029         * arm-tdep.c: Revert.
1030         * arm-symbian-tdep.c: Revert.
1031         * arm-pikeos-tdep.c: Revert.
1032         * arm-obsd-tdep.c: Revert.
1033         * arm-nbsd-tdep.c: Revert.
1034         * arm-nbsd-nat.c: Revert.
1035         * arm-linux-tdep.c: Revert.
1036         * arm-linux-nat.c: Revert.
1037         * arm-fbsd-tdep.c: Revert.
1038         * arm-fbsd-nat.c: Revert.
1039         * arm-bsd-tdep.c: Revert.
1040         * arch-utils.c: Revert.
1041         * arc-tdep.c: Revert.
1042         * arc-newlib-tdep.c: Revert.
1043         * annotate.h: Revert.
1044         * annotate.c: Revert.
1045         * amd64-windows-tdep.c: Revert.
1046         * amd64-windows-nat.c: Revert.
1047         * amd64-tdep.c: Revert.
1048         * amd64-sol2-tdep.c: Revert.
1049         * amd64-obsd-tdep.c: Revert.
1050         * amd64-obsd-nat.c: Revert.
1051         * amd64-nbsd-tdep.c: Revert.
1052         * amd64-nbsd-nat.c: Revert.
1053         * amd64-nat.c: Revert.
1054         * amd64-linux-tdep.c: Revert.
1055         * amd64-linux-nat.c: Revert.
1056         * amd64-fbsd-tdep.c: Revert.
1057         * amd64-fbsd-nat.c: Revert.
1058         * amd64-dicos-tdep.c: Revert.
1059         * amd64-darwin-tdep.c: Revert.
1060         * amd64-bsd-nat.c: Revert.
1061         * alpha-tdep.c: Revert.
1062         * alpha-obsd-tdep.c: Revert.
1063         * alpha-nbsd-tdep.c: Revert.
1064         * alpha-mdebug-tdep.c: Revert.
1065         * alpha-linux-tdep.c: Revert.
1066         * alpha-linux-nat.c: Revert.
1067         * alpha-bsd-tdep.c: Revert.
1068         * alpha-bsd-nat.c: Revert.
1069         * aix-thread.c: Revert.
1070         * agent.c: Revert.
1071         * addrmap.c: Revert.
1072         * ada-varobj.c: Revert.
1073         * ada-valprint.c: Revert.
1074         * ada-typeprint.c: Revert.
1075         * ada-tasks.c: Revert.
1076         * ada-lang.c: Revert.
1077         * aarch64-tdep.c: Revert.
1078         * aarch64-ravenscar-thread.c: Revert.
1079         * aarch64-newlib-tdep.c: Revert.
1080         * aarch64-linux-tdep.c: Revert.
1081         * aarch64-linux-nat.c: Revert.
1082         * aarch64-fbsd-tdep.c: Revert.
1083         * aarch64-fbsd-nat.c: Revert.
1084         * aarch32-linux-nat.c: Revert.
1085
1086 2019-04-05  Tom Tromey  <tom@tromey.com>
1087
1088         * ft32-tdep.c: Sort headers.
1089         * frv-tdep.c: Sort headers.
1090         * frv-linux-tdep.c: Sort headers.
1091         * frame.c: Sort headers.
1092         * frame-unwind.c: Sort headers.
1093         * frame-base.c: Sort headers.
1094         * fork-child.c: Sort headers.
1095         * findvar.c: Sort headers.
1096         * findcmd.c: Sort headers.
1097         * filesystem.c: Sort headers.
1098         * filename-seen-cache.h: Sort headers.
1099         * filename-seen-cache.c: Sort headers.
1100         * fbsd-tdep.c: Sort headers.
1101         * fbsd-nat.h: Sort headers.
1102         * fbsd-nat.c: Sort headers.
1103         * f-valprint.c: Sort headers.
1104         * f-typeprint.c: Sort headers.
1105         * f-lang.c: Sort headers.
1106         * extension.h: Sort headers.
1107         * extension.c: Sort headers.
1108         * extension-priv.h: Sort headers.
1109         * expprint.c: Sort headers.
1110         * exec.h: Sort headers.
1111         * exec.c: Sort headers.
1112         * exceptions.c: Sort headers.
1113         * event-top.c: Sort headers.
1114         * event-loop.c: Sort headers.
1115         * eval.c: Sort headers.
1116         * elfread.c: Sort headers.
1117         * dwarf2read.h: Sort headers.
1118         * dwarf2read.c: Sort headers.
1119         * dwarf2loc.c: Sort headers.
1120         * dwarf2expr.h: Sort headers.
1121         * dwarf2expr.c: Sort headers.
1122         * dwarf2-frame.c: Sort headers.
1123         * dwarf2-frame-tailcall.c: Sort headers.
1124         * dwarf-index-write.h: Sort headers.
1125         * dwarf-index-write.c: Sort headers.
1126         * dwarf-index-common.c: Sort headers.
1127         * dwarf-index-cache.h: Sort headers.
1128         * dwarf-index-cache.c: Sort headers.
1129         * dummy-frame.c: Sort headers.
1130         * dtrace-probe.c: Sort headers.
1131         * disasm.h: Sort headers.
1132         * disasm.c: Sort headers.
1133         * disasm-selftests.c: Sort headers.
1134         * dictionary.c: Sort headers.
1135         * dicos-tdep.c: Sort headers.
1136         * demangle.c: Sort headers.
1137         * dcache.h: Sort headers.
1138         * dcache.c: Sort headers.
1139         * darwin-nat.h: Sort headers.
1140         * darwin-nat.c: Sort headers.
1141         * darwin-nat-info.c: Sort headers.
1142         * d-valprint.c: Sort headers.
1143         * d-namespace.c: Sort headers.
1144         * d-lang.c: Sort headers.
1145         * ctf.c: Sort headers.
1146         * csky-tdep.c: Sort headers.
1147         * csky-linux-tdep.c: Sort headers.
1148         * cris-tdep.c: Sort headers.
1149         * cris-linux-tdep.c: Sort headers.
1150         * cp-valprint.c: Sort headers.
1151         * cp-support.c: Sort headers.
1152         * cp-namespace.c: Sort headers.
1153         * cp-abi.c: Sort headers.
1154         * corelow.c: Sort headers.
1155         * corefile.c: Sort headers.
1156         * continuations.c: Sort headers.
1157         * completer.h: Sort headers.
1158         * completer.c: Sort headers.
1159         * complaints.c: Sort headers.
1160         * coffread.c: Sort headers.
1161         * coff-pe-read.c: Sort headers.
1162         * cli-out.h: Sort headers.
1163         * cli-out.c: Sort headers.
1164         * charset.c: Sort headers.
1165         * c-varobj.c: Sort headers.
1166         * c-valprint.c: Sort headers.
1167         * c-typeprint.c: Sort headers.
1168         * c-lang.c: Sort headers.
1169         * buildsym.c: Sort headers.
1170         * buildsym-legacy.c: Sort headers.
1171         * build-id.h: Sort headers.
1172         * build-id.c: Sort headers.
1173         * btrace.c: Sort headers.
1174         * bsd-uthread.c: Sort headers.
1175         * breakpoint.h: Sort headers.
1176         * breakpoint.c: Sort headers.
1177         * break-catch-throw.c: Sort headers.
1178         * break-catch-syscall.c: Sort headers.
1179         * break-catch-sig.c: Sort headers.
1180         * blockframe.c: Sort headers.
1181         * block.c: Sort headers.
1182         * bfin-tdep.c: Sort headers.
1183         * bfin-linux-tdep.c: Sort headers.
1184         * bfd-target.c: Sort headers.
1185         * bcache.c: Sort headers.
1186         * ax-general.c: Sort headers.
1187         * ax-gdb.h: Sort headers.
1188         * ax-gdb.c: Sort headers.
1189         * avr-tdep.c: Sort headers.
1190         * auxv.c: Sort headers.
1191         * auto-load.c: Sort headers.
1192         * arm-wince-tdep.c: Sort headers.
1193         * arm-tdep.c: Sort headers.
1194         * arm-symbian-tdep.c: Sort headers.
1195         * arm-pikeos-tdep.c: Sort headers.
1196         * arm-obsd-tdep.c: Sort headers.
1197         * arm-nbsd-tdep.c: Sort headers.
1198         * arm-nbsd-nat.c: Sort headers.
1199         * arm-linux-tdep.c: Sort headers.
1200         * arm-linux-nat.c: Sort headers.
1201         * arm-fbsd-tdep.c: Sort headers.
1202         * arm-fbsd-nat.c: Sort headers.
1203         * arm-bsd-tdep.c: Sort headers.
1204         * arch-utils.c: Sort headers.
1205         * arc-tdep.c: Sort headers.
1206         * arc-newlib-tdep.c: Sort headers.
1207         * annotate.h: Sort headers.
1208         * annotate.c: Sort headers.
1209         * amd64-windows-tdep.c: Sort headers.
1210         * amd64-windows-nat.c: Sort headers.
1211         * amd64-tdep.c: Sort headers.
1212         * amd64-sol2-tdep.c: Sort headers.
1213         * amd64-obsd-tdep.c: Sort headers.
1214         * amd64-obsd-nat.c: Sort headers.
1215         * amd64-nbsd-tdep.c: Sort headers.
1216         * amd64-nbsd-nat.c: Sort headers.
1217         * amd64-nat.c: Sort headers.
1218         * amd64-linux-tdep.c: Sort headers.
1219         * amd64-linux-nat.c: Sort headers.
1220         * amd64-fbsd-tdep.c: Sort headers.
1221         * amd64-fbsd-nat.c: Sort headers.
1222         * amd64-dicos-tdep.c: Sort headers.
1223         * amd64-darwin-tdep.c: Sort headers.
1224         * amd64-bsd-nat.c: Sort headers.
1225         * alpha-tdep.c: Sort headers.
1226         * alpha-obsd-tdep.c: Sort headers.
1227         * alpha-nbsd-tdep.c: Sort headers.
1228         * alpha-mdebug-tdep.c: Sort headers.
1229         * alpha-linux-tdep.c: Sort headers.
1230         * alpha-linux-nat.c: Sort headers.
1231         * alpha-bsd-tdep.c: Sort headers.
1232         * alpha-bsd-nat.c: Sort headers.
1233         * aix-thread.c: Sort headers.
1234         * agent.c: Sort headers.
1235         * addrmap.c: Sort headers.
1236         * ada-varobj.c: Sort headers.
1237         * ada-valprint.c: Sort headers.
1238         * ada-typeprint.c: Sort headers.
1239         * ada-tasks.c: Sort headers.
1240         * ada-lang.c: Sort headers.
1241         * aarch64-tdep.c: Sort headers.
1242         * aarch64-ravenscar-thread.c: Sort headers.
1243         * aarch64-newlib-tdep.c: Sort headers.
1244         * aarch64-linux-tdep.c: Sort headers.
1245         * aarch64-linux-nat.c: Sort headers.
1246         * aarch64-fbsd-tdep.c: Sort headers.
1247         * aarch64-fbsd-nat.c: Sort headers.
1248         * aarch32-linux-nat.c: Sort headers.
1249
1250 2019-04-04  Tom Tromey  <tom@tromey.com>
1251
1252         * varobj.c (varobj_create): Update.
1253         * rust-exp.y (struct rust_parser) <update_innermost_block,
1254         lookup_symbol>: New methods.
1255         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
1256         Rename.
1257         (rust_parser::rust_lookup_type)
1258         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1259         * printcmd.c (display_command, do_one_display): Update.
1260         * parser-defs.h (struct parser_state) <parser_state>: Add
1261         "tracker" parameter.
1262         (block_tracker): New member.
1263         (class innermost_block_tracker) <innermost_block_tracker>: Add
1264         "types" parameter.
1265         <reset>: Remove method.
1266         (innermost_block): Don't declare.
1267         (null_post_parser): Update.
1268         * parse.c (innermost_block): Remove global.
1269         (write_dollar_variable): Update.
1270         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
1271         Remove "tracker_types" parameter.
1272         (parse_expression): Add "tracker" parameter.
1273         (parse_expression_for_completion): Update.
1274         (null_post_parser): Add "tracker" parameter.
1275         * p-exp.y: Update rules.
1276         * m2-exp.y: Update rules.
1277         * language.h (struct language_defn) <la_post_parser>: Add
1278         "tracker" parameter.
1279         * go-exp.y: Update rules.
1280         * f-exp.y: Update rules.
1281         * expression.h (parse_expression, parse_exp_1): Add "tracker"
1282         parameter.
1283         * d-exp.y: Update rules.
1284         * c-exp.y: Update rules.
1285         * breakpoint.c (set_breakpoint_condition): Create an
1286         innermost_block_tracker.
1287         (watch_command_1): Likewise.
1288         * ada-lang.c (resolve): Add "tracker" parameter.
1289         (resolve_subexp): Likewise.
1290         * ada-exp.y (write_var_from_sym): Update.
1291
1292 2019-04-04  Tom Tromey  <tom@tromey.com>
1293
1294         * type-stack.h: New file.
1295         * type-stack.c: New file.
1296         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
1297         type-stack.h.
1298         (insert_into_type_stack, insert_type, push_type, push_type_int)
1299         (insert_type_address_space, pop_type, pop_type_int)
1300         (pop_typelist, pop_type_stack, append_type_stack)
1301         (push_type_stack, get_type_stack, push_typelist)
1302         (follow_type_instance_flags, follow_types): Don't declare.
1303         * parse.c (type_stack): Remove global.
1304         (parse_exp_in_context): Update.
1305         (insert_into_type_stack, insert_type, push_type, push_type_int)
1306         (insert_type_address_space, pop_type, pop_type_int)
1307         (pop_typelist, pop_type_stack, append_type_stack)
1308         (push_type_stack, get_type_stack, push_typelist)
1309         (follow_type_instance_flags, follow_types): Remove (moved to
1310         type-stack.c).
1311         * f-exp.y (type_stack): New global.
1312         Update rules.
1313         (push_kind_type, f_parse): Update.
1314         * d-exp.y (type_stack): New global.
1315         Update rules.
1316         (d_parse): Update.
1317         * c-exp.y (struct c_parse_state) <type_stack>: New member.
1318         Update rules.
1319         * Makefile.in (COMMON_SFILES): Add type-stack.c.
1320         (HFILES_NO_SRCDIR): Add type-stack.h.
1321
1322 2019-04-04  Tom Tromey  <tom@tromey.com>
1323
1324         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
1325         (rust_parser::convert_ast_to_expression, rust_parse)
1326         (rust_lex_test_completion, rust_lex_tests): Update.
1327         * parser-defs.h (struct expr_completion_state): New.
1328         (struct parser_state) <parser_state>: Add completion parameter.
1329         <mark_struct_expression, mark_completion_tag>: New methods.
1330         <parse_completion, m_completion_state>: New members.
1331         (prefixify_expression, null_post_parser): Update.
1332         (mark_struct_expression, mark_completion_tag): Don't declare.
1333         * parse.c (parse_completion, expout_last_struct)
1334         (expout_tag_completion_type, expout_completion_name): Remove
1335         globals.
1336         (parser_state::mark_struct_expression)
1337         (parser_state::mark_completion_tag): Now methods.
1338         (prefixify_expression): Add last_struct parameter.
1339         (prefixify_subexp): Likewise.
1340         (parse_exp_1): Update.
1341         (parse_exp_in_context): Add cstate parameter.  Update.
1342         (parse_expression_for_completion): Create an
1343         expr_completion_state.
1344         (null_post_parser): Add "completion" parameter.
1345         * p-exp.y: Update rules.
1346         (yylex): Update.
1347         * language.h (struct language_defn) <la_post_parser>: Add
1348         "completing" parameter.
1349         * go-exp.y: Update rules.
1350         (lex_one_token): Update.
1351         * expression.h (parse_completion): Don't declare.
1352         * d-exp.y: Update rules.
1353         (lex_one_token): Update rules.
1354         * c-exp.y: Update rules.
1355         (lex_one_token): Update.
1356         * ada-lang.c (resolve): Add "parse_completion" parameter.
1357         (resolve_subexp): Likewise.
1358         (ada_resolve_function): Likewise.
1359
1360 2019-04-04  Tom Tromey  <tom@tromey.com>
1361
1362         * parser-defs.h (struct parser_state) <start_arglist,
1363         end_arglist>: New methods.
1364         <arglist_len, m_funcall_chain>: New members.
1365         (arglist_len, start_arglist, end_arglist): Don't declare.
1366         * parse.c (arglist_len, funcall_chain): Remove global.
1367         (start_arglist, end_arglist): Remove functions.
1368         (parse_exp_in_context): Update.
1369         * p-exp.y: Update rules.
1370         * m2-exp.y: Update rules.
1371         * go-exp.y: Update rules.
1372         * f-exp.y: Update rules.
1373         * d-exp.y: Update rules.
1374         * c-exp.y: Update rules.
1375
1376 2019-04-04  Tom Tromey  <tom@tromey.com>
1377
1378         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
1379         lex_operator, push_back>: New methods.
1380         Update all rules.
1381         (rust_parser::lex_hex, lex_escape): Rename and update.
1382         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
1383         (rust_parser::lex_operator): Rename and update.
1384         (rust_parser::lex_number, rustyylex, rustyyerror)
1385         (rust_lex_test_init, rust_lex_test_sequence)
1386         (rust_lex_test_push_back, rust_lex_tests): Update.
1387         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
1388         parameter.
1389         <lexptr, prev_lexptr>: New members.
1390         (lexptr, prev_lexptr): Don't declare.
1391         * parse.c (lexptr, prev_lexptr): Remove globals.
1392         (parse_exp_in_context): Update.
1393         * p-exp.y (yylex, yyerror): Update.
1394         * m2-exp.y (parse_number, yylex, yyerror): Update.
1395         * go-exp.y (lex_one_token, yyerror): Update.
1396         * f-exp.y (match_string_literal, yylex, yyerror): Update.
1397         * d-exp.y (lex_one_token, yyerror): Update.
1398         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
1399         (lex_one_token, yyerror): Update.
1400         * ada-lex.l (YY_INPUT): Update.
1401         (rewind_to_char): Update.
1402         * ada-exp.y (yyerror): Update.
1403
1404 2019-04-04  Tom Tromey  <tom@tromey.com>
1405
1406         * rust-exp.y (rustyylex, rust_lex_tests): Update.
1407         * parser-defs.h (struct parser_state) <parser_state>: Add new
1408         parameter.
1409         <comma_terminates>: New member.
1410         (comma_terminates): Don't declare global.
1411         * parse.c (comma_terminates): Remove global.
1412         (parse_exp_in_context): Update.
1413         * p-exp.y (yylex): Update.
1414         * m2-exp.y (yylex): Update.
1415         * go-exp.y (lex_one_token): Update.
1416         * f-exp.y (yylex): Update.
1417         * d-exp.y (lex_one_token): Update.
1418         * c-exp.y (lex_one_token): Update.
1419         * ada-lex.l: Update.
1420
1421 2019-04-04  Tom Tromey  <tom@tromey.com>
1422
1423         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
1424         (rustyylex, rust_lex_test_init, rust_lex_test_one)
1425         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
1426         * parser-defs.h (paren_depth): Don't declare.
1427         * parse.c (paren_depth): Remove global.
1428         (parse_exp_in_context): Update.
1429         * p-exp.y (paren_depth): New global.
1430         (pascal_parse): Initialize it.
1431         * m2-exp.y (paren_depth): New global.
1432         (m2_parse): Initialize it.
1433         * go-exp.y (paren_depth): New global.
1434         (go_parse): Initialize it.
1435         * f-exp.y (paren_depth): New global.
1436         (f_parse): Initialize it.
1437         * d-exp.y (paren_depth): New global.
1438         (d_parse): Initialize it.
1439         * c-exp.y (paren_depth): New global.
1440         (c_parse): Initialize it.
1441         * ada-lex.l (paren_depth): New global.
1442         (lexer_init): Initialize it.
1443
1444 2019-04-04  Tom Tromey  <tom@tromey.com>
1445
1446         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
1447         (rust_parser::convert_ast_to_type)
1448         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1449         * parser-defs.h (struct parser_state) <parser_state>: Add
1450         parameters.  Initialize new members.
1451         <expression_context_block, expression_context_pc>: New members.
1452         * parse.c (expression_context_block, expression_context_pc):
1453         Remove globals.
1454         (parse_exp_in_context): Update.
1455         * p-exp.y: Update all rules.
1456         (yylex): Update.
1457         * m2-exp.y: Update all rules.
1458         (yylex): Update.
1459         * go-exp.y (yylex): Update.
1460         * f-exp.y (yylex): Update.
1461         * d-exp.y: Update all rules.
1462         (yylex): Update.
1463         * c-exp.y: Update all rules.
1464         (lex_one_token, classify_name, yylex, c_parse): Update.
1465         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
1466
1467 2019-04-04  Tom Tromey  <tom@tromey.com>
1468
1469         * gdbarch.h, gdbarch.c: Rebuild.
1470         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
1471         * stap-probe.h: 
1472         (struct stap_parse_info): Replace "parser_state" with
1473         "expr_builder".
1474         * parser-defs.h (struct expr_builder): Rename from "parser_state".
1475         (parser_state): New class.
1476         * parse.c (expr_builder): Rename.
1477         (expr_builder::release): Rename.
1478         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
1479         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
1480         (write_exp_elt_longcst, write_exp_elt_floatcst)
1481         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
1482         (write_exp_string_vector, write_exp_bitstring)
1483         (write_exp_msymbol, mark_struct_expression)
1484         (write_dollar_variable)
1485         (insert_type_address_space, increase_expout_size): Replace
1486         "parser_state" with "expr_builder".
1487         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
1488         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
1489         "parser_state" with "expr_builder".
1490
1491 2019-04-04  Tom Tromey  <tom@tromey.com>
1492
1493         * rust-exp.y: Replace "parse_language" with method call.
1494         * p-exp.y: 
1495         (yylex): Replace "parse_language" with method call.
1496         * m2-exp.y: 
1497         (yylex): Replace "parse_language" with method call.
1498         * go-exp.y (classify_name): Replace "parse_language" with method
1499         call.
1500         * f-exp.y (yylex): Replace "parse_language" with method call.
1501         * d-exp.y (lex_one_token): Replace "parse_language" with method
1502         call.
1503         * c-exp.y: 
1504         (lex_one_token, classify_name, yylex): Replace "parse_language"
1505         with method call.
1506         * ada-exp.y (find_primitive_type, type_char)
1507         (type_system_address): Replace "parse_language" with method call.
1508
1509 2019-04-04  Tom Tromey  <tom@tromey.com>
1510
1511         * rust-exp.y: Replace "parse_gdbarch" with method call.
1512         * parse.c (write_dollar_variable, insert_type_address_space):
1513         Replace "parse_gdbarch" with method call.
1514         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
1515         call.
1516         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
1517         call.
1518         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
1519         "parse_gdbarch" with method call.
1520         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
1521         with method call.
1522         * f-exp.y (parse_type, parse_f_type, yylex): Replace
1523         "parse_gdbarch" with method call.
1524         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
1525         "parse_gdbarch" with method call.
1526         * c-exp.y (parse_type, parse_number, classify_name): Replace
1527         "parse_gdbarch" with method call.
1528         * ada-lex.l: Replace "parse_gdbarch" with method call.
1529         * ada-exp.y (parse_type, find_primitive_type, type_char)
1530         (type_system_address): Replace "parse_gdbarch" with method call.
1531
1532 2019-04-04  Tom Tromey  <tom@tromey.com>
1533
1534         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
1535         * stap-probe.c (stap_parse_argument): Update.
1536         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
1537         initial_size parameter.
1538         * rust-exp.y (rust_lex_tests): Update.
1539         * parse.c (parser_state): Update.
1540         (parse_exp_in_context): Update.
1541         * parser-defs.h (struct parser_state) <parser_state>: Remove
1542         "initial_size" parameter.
1543
1544 2019-04-04  Tom Tromey  <tom@tromey.com>
1545
1546         * parser-defs.h (increase_expout_size): Don't declare.
1547         * parse.c (increase_expout_size): Now static.
1548
1549 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
1550
1551         * gnu-nat.c (gnu_nat_target::wait): Fix
1552         target_waitstatus_to_string call.
1553
1554 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1555
1556         * eval.c (evaluate_subexp_standard): Handle internal functions
1557         during Fortran function call handling.
1558
1559 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1560
1561         * NEWS: Mention new internal functions.
1562         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
1563         (read_base_type): Use dwarf2_init_complex_target_type.
1564         * value.c (creal_internal_fn): New function.
1565         (cimag_internal_fn): New function.
1566         (_initialize_values): Register new internal functions.
1567
1568 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1569
1570         * infrun.c (stop_all_threads): If debug_infrun, always
1571         trace the wait status after wait_one, using
1572         target_waitstatus_to_string and target_pid_to_str.
1573         (handle_inferior_event): Replace various trace of
1574         wait status kind by a single trace.
1575         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
1576         wait status kind image by target_waitstatus_to_string.
1577         * target/waitstatus.c (target_waitstatus_to_string): Fix
1578         obsolete comment.
1579
1580 2019-04-01  Tom Tromey  <tromey@adacore.com>
1581
1582         PR symtab/23331:
1583         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
1584
1585 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
1586             Pedro Alves  <palves@redhat.com>
1587
1588         * top.c (quit_force): Call 'finalize_values'.
1589         * value.c (finalize_values): New function.
1590         * value.h (finalize_values): Declare.
1591
1592 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
1593
1594         * NEWS: Announce $_gdb_major and $_gdb_minor.
1595
1596         * top.c (init_gdb_version_vars): New function.
1597         (gdb_init): Call init_gdb_version_vars.
1598
1599 2019-03-29  Tom Tromey  <tromey@adacore.com>
1600
1601         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
1602         help text.  Remove dead code.
1603
1604 2019-03-29  Keith Seitz  <keiths@redhat.com>
1605
1606         From Siddhesh Poyarekar:
1607         * f-lang.h (f77_get_upperbound): Return LONGEST.
1608         (f77_get_lowerbound): Likewise.
1609         * f-typeprint.c (f_type_print_varspec_suffix): Expand
1610         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
1611         print them.
1612         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
1613         plongest to format print it.
1614         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
1615         (f77_get_upperbound): Likewise.
1616         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
1617         LOWER_BOUND to LONGEST.
1618         (f77_create_arrayprint_offset_tbl): Likewise.
1619
1620 2019-03-29  Keith Seitz  <keiths@redhat.com>
1621
1622         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
1623         %s/pulongest for TYPE_LENGTH instead of %d in format
1624         strings.
1625         * ada-typerint.c (ada_print_type): Likewise.
1626         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
1627         * compile/compile-c-support.c (generate_register_struct): Likewise.
1628         * gdbtypes.c (recursive_dump_type): Likewise.
1629         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
1630         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
1631         instead of %d in format strings.
1632         * riscv-tdep.c (riscv_type_alignment): Cast second argument
1633         to std::min to ULONGEST.
1634         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
1635         instead of %d in format strings.
1636         * tracepoint.c (info_scope_command): Likewise.
1637         * typeprint.c (print_offset_data::update)
1638         (print_offset_data::finish): Likewise.
1639         * xtensa-tdep.c (xtensa_store_return_value)
1640         (xtensa_push_dummy_call): Likewise.
1641
1642 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
1643
1644         * windows-nat.c (display_selector): Fixed format specifications
1645         for 64-bit Cygwin.
1646
1647 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1648
1649         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
1650
1651 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
1652
1653         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
1654         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
1655         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
1656         (nios2_linux_init_abi): Install it.
1657
1658 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1659
1660         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
1661
1662 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1663
1664         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
1665
1666 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1667             Tom Tromey  <tromey@adacore.com>
1668
1669         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
1670
1671 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
1672
1673         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
1674         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
1675         method to compute the bounds of range types. Also print "[evaluated]"
1676         if the bounds' values come from a dynamic evaluation.
1677
1678 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1679
1680         * cp-valprint.c (cp_print_value_fields): Don't print trailing
1681         whitespace when pretty printing is on.
1682
1683 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1684
1685         * ppc-linux-nat.c: Add include.
1686
1687 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1688
1689         * NEWS: Mention AArch64 Pointer Authentication.
1690
1691 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1692
1693         * arm-linux-nat.c: Add include.
1694
1695 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
1696
1697         * source-cache.c (source_cache::get_source_lines): Re-read
1698         fullname after calling open_source_file.
1699
1700 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
1701
1702         * NEWS: Mention TLS support for FreeBSD.
1703
1704 2019-03-25  Tom Tromey  <tromey@adacore.com>
1705
1706         * minsyms.c (BUNCH_SIZE): Update comment.
1707         (~minimal_symbol_reader): Remove old comment.
1708         (compact_minimal_symbols): Update comment.
1709         (minimal_symbol_reader::install): Remove old comment.  Update
1710         other comments.
1711
1712 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1713
1714         * s390-linux-nat.c: Add include.
1715
1716 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1717
1718         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1719         Call linux_get_hwcap.
1720         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
1721         Likewise.
1722         (aarch64_linux_get_hwcap): Remove function.
1723         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
1724         declaration.
1725         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
1726         linux_get_hwcap.
1727         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1728         * linux-tdep.c (linux_get_hwcap): Add function.
1729         (linux_get_hwcap2): Likewise.
1730         * linux-tdep.h (linux_get_hwcap): Add declaration.
1731         (linux_get_hwcap2): Likewise.
1732         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
1733         (ppc_linux_get_hwcap2): Likewise.
1734         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
1735         linux_get_hwcap.
1736         (ppc_linux_nat_target::insert_watchpoint): Likewise.
1737         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
1738         (ppc_linux_nat_target::read_description): Likewise.
1739         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
1740         * s390-linux-nat.c: Likewise.
1741         * s390-linux-tdep.c (s390_core_read_description): Likewise.
1742
1743 2019-03-24  Tom Tromey  <tom@tromey.com>
1744
1745         * ada-lang.c (standard_lookup): Simplify initialization.
1746         (ada_lookup_symbol_nonlocal): Simplify return.
1747         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
1748         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
1749         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
1750         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
1751         initialization.
1752         * solib.c (solib_global_lookup): Simplify.
1753         * symtab.c (null_block_symbol): Remove.
1754         (symbol_cache_lookup): Simplify returns.
1755         (lookup_language_this): Simplify returns.
1756         (lookup_symbol_aux): Simplify return.
1757         (lookup_local_symbol): Simplify returns.
1758         (lookup_global_symbol_from_objfile): Simplify return.
1759         (lookup_symbol_in_objfile_symtabs)
1760         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
1761         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
1762         (lookup_static_symbol, lookup_global_symbol): Simplify return.
1763         * cp-namespace.c (cp_lookup_bare_symbol)
1764         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
1765         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
1766         (cp_lookup_nested_symbol): Don't use null_block_symbol.
1767         (cp_lookup_symbol_via_imports): Simplify initialization.
1768         (find_symbol_in_baseclass): Likewise.
1769         * symtab.h (null_block_symbol): Remove.
1770         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
1771         (d_lookup_nested_symbol, d_lookup_symbol_imports)
1772         (d_lookup_symbol_module): Likewise.
1773         (find_symbol_in_baseclass): Simplify initialization.
1774
1775 2019-03-24  Tom Tromey  <tom@tromey.com>
1776
1777         * expression.h: Don't include symtab.h.
1778         (struct block): Forward declare.
1779
1780 2019-03-24  Tom Tromey  <tom@tromey.com>
1781
1782         * c-exp.y (typebase): Remove casts.
1783         * gdbtypes.c (lookup_unsigned_typename, )
1784         (lookup_signed_typename): Remove cast.
1785         * eval.c (parse_to_comma_and_eval): Remove cast.
1786         * parse.c (write_dollar_variable): Remove cast.
1787         * block.h (struct block) <superblock>: Now const.
1788         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
1789         * psymtab.c (psym_map_matching_symbols): Make "block" const.
1790         (map_block): Make "block" const.
1791         * symfile.h (struct quick_symbol_functions)
1792         <map_matching_symbols>: Constify block argument to "callback".
1793         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
1794         const.
1795         (find_pc_sect_compunit_symtab): Make "b" const.
1796         (find_symbol_at_address): Likewise.
1797         (search_symbols): Likewise.
1798         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
1799         (dw2_debug_names_lookup_symbol): Likewise.
1800         (dw2_map_matching_symbols): Update.
1801         * p-valprint.c (pascal_val_print): Remove "block".
1802         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
1803         (aux_add_nonlocal_symbols): Make "block" const.
1804         (resolve_subexp): Remove cast.
1805         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
1806         const.
1807         (iterate_over_file_blocks): Likewise.
1808         * f-exp.y (%union) <bval>: Remove.
1809         * coffread.c (patch_opaque_types): Make "b" const.
1810         * spu-tdep.c (spu_catch_start): Make "block" const.
1811         * c-valprint.c (print_unpacked_pointer): Remove "block".
1812         * symmisc.c (dump_symtab_1): Make "b" const.
1813         (block_depth): Make "block" const.
1814         * d-exp.y (%union) <bval>: Remove.
1815         * cp-support.h (cp_lookup_rtti_type): Update.
1816         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
1817         * psymtab.c (psym_lookup_symbol): Make "block" const.
1818         (maintenance_check_psymtabs): Make "b" const.
1819         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
1820         (enumerate_locals, enumerate_args): Update.
1821         * python/py-symtab.c (stpy_global_block): Make "block" const.
1822         (stpy_static_block): Likewise.
1823         * inline-frame.c (block_starting_point_at): Make "new_block"
1824         const.
1825         * block.c (find_block_in_blockvector): Make return type const.
1826         (blockvector_for_pc_sect): Make "b" const.
1827         (find_block_in_blockvector): Make "b" const.
1828
1829 2019-03-23  Tom Tromey  <tom@tromey.com>
1830
1831         * varobj.c (varobj_create): Update.
1832         * symfile.c (clear_symtab_users): Don't reset innermost_block.
1833         * printcmd.c (display_command, do_one_display): Don't reset
1834         innermost_block.
1835         * parser-defs.h (enum innermost_block_tracker_type): Move to
1836         expression.h.
1837         (innermost_block): Update comment.
1838         * parse.c (parse_exp_1): Add tracker_types parameter.
1839         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
1840         tracker_types parameter.  Reset innermost_block.
1841         (parse_exp_in_context): Remove.
1842         (parse_expression_for_completion): Update.
1843         * objfiles.c (~objfile): Don't reset expression_context_block or
1844         innermost_block.
1845         * expression.h (enum innermost_block_tracker_type): Move from
1846         parser-defs.h.
1847         (parse_exp_1): Add tracker_types parameter.
1848         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
1849         reset innermost_block.
1850
1851 2019-03-23  Tom Tromey  <tom@tromey.com>
1852
1853         * objfiles.h: Include bcache.h.
1854
1855 2019-03-23  Tom Tromey  <tom@tromey.com>
1856
1857         * linespec.c (get_current_search_block): Use
1858         scoped_restore_current_language.
1859         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
1860
1861 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1862             Jiong Wang  <jiong.wang@arm.com>
1863
1864         * aarch64-linux-tdep.c
1865         (aarch64_linux_iterate_over_regset_sections): Check for pauth
1866         section.
1867         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
1868
1869 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1870             Jiong Wang  <jiong.wang@arm.com>
1871
1872         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
1873         instructions.
1874         (aarch64_analyze_prologue_test): Add PACIASP test.
1875         (aarch64_prologue_prev_register): Unmask PC value.
1876
1877 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1878             Jiong Wang  <jiong.wang@arm.com>
1879
1880         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
1881         (aarch64_dwarf2_prev_register): Unmask PC value.
1882         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
1883         (aarch64_execute_dwarf_cfa_vendor_op): Check for
1884         DW_CFA_AARCH64_negate_ra_state.
1885         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
1886
1887 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1888             Jiong Wang  <jiong.wang@arm.com>
1889
1890         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
1891         registers.
1892         (aarch64_pseudo_register_name): Likewise.
1893         (aarch64_pseudo_register_type): Likewise.
1894         (aarch64_pseudo_register_reggroup_p): Likewise.
1895         (aarch64_gdbarch_init): Add pauth registers.
1896         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
1897         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
1898         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
1899         (struct gdbarch_tdep): Add regnum for ra_state.
1900
1901 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1902             Jiong Wang  <jiong.wang@arm.com>
1903
1904         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
1905
1906 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1907             Jiong Wang  <jiong.wang@arm.com>
1908
1909         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
1910         function.
1911         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
1912         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
1913         (aarch64_gdbarch_init): Add puth registers.
1914         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
1915         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
1916         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
1917
1918 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1919             Jiong Wang  <jiong.wang@arm.com>
1920
1921         * aarch64-linux-nat.c
1922         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
1923         * aarch64-linux-tdep.c
1924         (aarch64_linux_core_read_description): Likewise.
1925         (aarch64_linux_get_hwcap): New function.
1926         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
1927         (aarch64_linux_get_hwcap): New declaration.
1928
1929 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1930             Jiong Wang  <jiong.wang@arm.com>
1931
1932         * aarch64-linux-nat.c
1933         (aarch64_linux_nat_target::read_description): Add pauth param.
1934         * aarch64-linux-tdep.c
1935         (aarch64_linux_core_read_description): Likewise.
1936         * aarch64-tdep.c (struct target_desc): Add in pauth.
1937         (aarch64_read_description): Add pauth param.
1938         (aarch64_gdbarch_init): Likewise.
1939         * aarch64-tdep.h (aarch64_read_description): Likewise.
1940         * arch/aarch64.c (aarch64_create_target_description): Likewise.
1941         * arch/aarch64.h (aarch64_create_target_description): Likewise.
1942         * features/Makefile: Add new files.
1943         * features/aarch64-pauth.c: New file.
1944         * features/aarch64-pauth.xml: New file.
1945
1946 2019-03-20  Tom Tromey  <tromey@adacore.com>
1947
1948         * infrun.c (handle_inferior_event): Rename from
1949         handle_inferior_event_1.  Create a scoped_value_mark.
1950         (handle_inferior_event): Remove.
1951
1952 2019-03-19  Tom Tromey  <tromey@adacore.com>
1953
1954         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
1955         * infrun.h (print_stop_event): Add "displays" parameter.
1956         * infrun.c (print_stop_event): Add "displays" parameter.
1957
1958 2019-03-19  Pedro Alves  <palves@redhat.com>
1959
1960         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
1961         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
1962         to -1.  Fix TABs vs spaces.
1963         (tui_ui_out::tui_ui_out): Don't initialize fields here.
1964         * tui/tui-out.h (tui_ui_out) Add intro comments.
1965         <m_line, m_start_of_line>: In-class initialize, and add describing
1966         comment.
1967
1968 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
1969
1970         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
1971         variable names.
1972         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
1973
1974 2019-03-18  Pedro Alves  <palves@redhat.com>
1975             Eli Zaretskii <eliz@gnu.org>
1976
1977         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
1978         m_line and m_start_of_line.
1979
1980 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
1981
1982         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
1983         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
1984         it returns a newline.  This fixes a regression in TU mode, whereby
1985         the next line is output on the same screen line as the user input.
1986
1987 2019-03-18  Tom Tromey  <tromey@adacore.com>
1988
1989         * minsyms.c (minimal_symbol_reader::install): Remove call to
1990         obstack_blank.
1991
1992 2019-03-18  Pedro Alves  <palves@redhat.com>
1993
1994         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
1995         New globals.
1996         (apply_style): New, factored out from ...
1997         (apply_ansi_escape): ... this.  Handle reverse video mode.
1998         (tui_set_reverse_mode): New function.
1999         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
2000         * tui/tui-winsource.c (tui_show_source_line): Use
2001         tui_set_reverse_mode instead of setting A_STANDOUT.
2002         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
2003         New setter methods.
2004
2005 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
2006
2007         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
2008         Handle tabs.
2009
2010 2019-03-18  Tom Tromey  <tromey@adacore.com>
2011
2012         * ada-lang.c (empty_array): Add "high" parameter.
2013         (ada_evaluate_subexp): Update.
2014
2015 2019-03-17  Sergei Trofimovich <siarheit@google.com>
2016
2017         * unittests/string_view-selftests.c: Define
2018         _initialize_string_view_selftests unconditionally.
2019
2020 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2021
2022         PR gdb/24350
2023         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
2024
2025 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2026
2027         PR gdb/24351
2028         * windows-nat.c (display_selector): Fix format specifiers.
2029
2030 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
2031
2032         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
2033         tui_refill_source_window instead of tui_refresh_win, to update the
2034         current execution line.  This fixes redisplay of the current line
2035         when stepping through the code with "next" or "step".
2036
2037 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2038
2039         * source-cache.c (source_cache::get_source_lines): Call
2040         find_source_lines to initialize s->nlines.  This fixes vertical
2041         scrolling of TUI source window when the DOWN arrow is pressed.
2042
2043 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2044
2045         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
2046         linux-thread-db.c (_initialize_thread_db): Likewise.
2047
2048 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2049
2050         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
2051         wclrtoeol in tui_show_source_line".  This reverts changes made in
2052         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
2053
2054 2019-03-15  Tom Tromey  <tom@tromey.com>
2055
2056         * symtab.h (struct minimal_symbol): Derive from
2057         general_symbol_info.
2058         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
2059         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
2060         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
2061         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
2062         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
2063         (MSYMBOL_SEARCH_NAME): Update.
2064         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
2065         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
2066         * minsyms.c (minimal_symbol_reader::record_full): Update.
2067
2068 2019-03-15  Tom Tromey  <tom@tromey.com>
2069
2070         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
2071
2072 2019-03-15  Tom Tromey  <tom@tromey.com>
2073
2074         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
2075         unique_xmalloc_ptr.
2076         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
2077         Update.
2078         * minsyms.c (lookup_minimal_symbol_by_pc_section)
2079         (build_minimal_symbol_hash_tables)
2080         (minimal_symbol_reader::install): Update.
2081
2082 2019-03-15  Tom Tromey  <tom@tromey.com>
2083
2084         * symtab.c (create_demangled_names_hash): Update.
2085         (symbol_set_names): Update.
2086         * objfiles.h (struct objfile_per_bfd_storage)
2087         <demangled_names_hash>: Now an htab_up.
2088         * objfiles.c (objfile_per_bfd_storage): Simplify.
2089
2090 2019-03-15  Tom Tromey  <tom@tromey.com>
2091
2092         * objfiles.h (struct objfile_per_bfd_storage): Declare
2093         destructor.
2094         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
2095         New.
2096         (get_objfile_bfd_data): Use new.  Don't initialize
2097         language_of_main.
2098         (free_objfile_per_bfd_storage): Remove.
2099         (objfile_bfd_data_free, objfile::~objfile): Use delete.
2100
2101 2019-03-15  Tom Tromey  <tom@tromey.com>
2102
2103         * symfile.c (reread_symbols): Update.
2104         * objfiles.c (objfile::objfile): Update.
2105         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
2106         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
2107         comment.
2108         (minimal_symbol_reader::install): Update.
2109         (terminate_minimal_symbol_table): Remove.
2110         * jit.c (jit_object_close_impl): Update.
2111
2112 2019-03-15  Tom Tromey  <tom@tromey.com>
2113
2114         * minsyms.c (minimal_symbol_reader::record_full): Remove some
2115         initializations.
2116
2117 2019-03-15  Tom Tromey  <tom@tromey.com>
2118
2119         * objfiles.h (struct objfile_per_bfd_storage)
2120         <demangled_hash_languages>: Now a bitset.
2121         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
2122         (lookup_minimal_symbol): Update.
2123
2124 2019-03-15  Tom Tromey  <tom@tromey.com>
2125
2126         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
2127         Don't return the symbol.
2128         * coffread.c (record_minimal_symbol): Use record_full.
2129
2130 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
2131
2132         The MS-Windows port of ncurses fails to switch to a color pair if
2133         one or both of the colors are the implicit default colors.  This
2134         change records the default colors when TUI is initialized, and
2135         then specifies them explicitly when a color pair uses the default
2136         colors.  This allows color styling in TUI mode on MS-Windows.
2137
2138         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
2139         ncurses_norm_attr.
2140         (tui_initialize_io) [__MINGW32__]: Record the default terminal
2141         colors in ncurses_norm_attr.
2142         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
2143         "none", replace it with the default color recorded in
2144         ncurses_norm_attr.
2145
2146 2019-03-14  Tom Tromey  <tromey@adacore.com>
2147
2148         * source-cache.h (class source_cache) <get_source_lines>: Return
2149         std::string.
2150         * source-cache.c (source_cache::extract_lines): Handle case where
2151         first_pos==npos.  Return std::string.
2152         (source_cache::get_source_lines): Update.
2153
2154 2019-03-14  Tom Tromey  <tromey@adacore.com>
2155
2156         * NEWS: Add item for "style sources" commands.
2157         * source-cache.c (source_cache::get_source_lines): Check
2158         source_styling.
2159         * cli/cli-style.c (source_styling): New global.
2160         (_initialize_cli_style): Add "style sources" commands.
2161         (show_style_sources): New function.
2162         * cli/cli-style.h (source_styling): Declare.
2163
2164 2019-03-14  Pedro Alves  <palves@redhat.com>
2165             Tom Tromey  <tromey@adacore.com>
2166
2167         * tui/tui-winsource.h (tui_refill_source_window): Declare.
2168         * tui/tui-winsource.c (tui_refill_source_window): New function,
2169         from...
2170         (tui_horizontal_source_scroll): ... here.  Move some logic.
2171         * cli/cli-style.c (set_style_enabled): Notify new observable.
2172         * tui/tui-hooks.c (tui_redisplay_source): New function.
2173         (tui_attach_detach_observers): Attach or detach
2174         tui_redisplay_source.
2175         * observable.h (source_styling_changed): New observable.
2176         * observable.c: Define source_styling_changed observable.
2177
2178 2019-03-13  Tom Tromey  <tromey@adacore.com>
2179
2180         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
2181         (i386_gnu_nat_target::store_registers): Update.
2182         * target-debug.h (target_debug_print_std_string): New macro.
2183         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2184         * windows-tdep.c (display_one_tib): Update.
2185         * tui/tui-stack.c (tui_make_status_line): Update.
2186         * top.c (print_inferior_quit_action): Update.
2187         * thread.c (thr_try_catch_cmd): Update.
2188         (add_thread_with_info): Update.
2189         (thread_target_id_str): Update.
2190         (thr_try_catch_cmd): Update.
2191         (thread_command): Update.
2192         (thread_find_command): Update.
2193         * record-btrace.c (record_btrace_target::info_record)
2194         (record_btrace_resume_thread, record_btrace_target::resume)
2195         (record_btrace_cancel_resume, record_btrace_step_thread)
2196         (record_btrace_target::wait, record_btrace_target::wait)
2197         (record_btrace_target::wait, record_btrace_target::stop): Update.
2198         * progspace.c (print_program_space): Update.
2199         * process-stratum-target.c
2200         (process_stratum_target::thread_address_space): Update.
2201         * linux-fork.c (linux_fork_mourn_inferior)
2202         (detach_checkpoint_command, info_checkpoints_command)
2203         (linux_fork_context): Update.
2204         (linux_fork_detach): Update.
2205         (class scoped_switch_fork_info): Update.
2206         (delete_checkpoint_command): Update.
2207         * infrun.c (follow_fork_inferior): Update.
2208         (follow_fork_inferior): Update.
2209         (proceed_after_vfork_done): Update.
2210         (handle_vfork_child_exec_or_exit): Update.
2211         (follow_exec): Update.
2212         (displaced_step_prepare_throw): Update.
2213         (displaced_step_restore): Update.
2214         (start_step_over): Update.
2215         (resume_1): Update.
2216         (clear_proceed_status_thread): Update.
2217         (proceed): Update.
2218         (print_target_wait_results): Update.
2219         (do_target_wait): Update.
2220         (context_switch): Update.
2221         (stop_all_threads): Update.
2222         (restart_threads): Update.
2223         (finish_step_over): Update.
2224         (handle_signal_stop): Update.
2225         (switch_back_to_stepped_thread): Update.
2226         (keep_going_pass_signal): Update.
2227         (print_exited_reason): Update.
2228         (normal_stop): Update.
2229         * inferior.c (inferior_pid_to_str): Change return type.
2230         (print_selected_inferior): Update.
2231         (add_inferior): Update.
2232         (detach_inferior): Update.
2233         * dummy-frame.c (fprint_dummy_frames): Update.
2234         * dcache.c (dcache_info_1): Update.
2235         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
2236         (btrace_fetch, btrace_clear): Update.
2237         * linux-tdep.c (linux_core_pid_to_str): Change return type.
2238         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
2239         type.
2240         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
2241         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
2242         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
2243         * gdbarch.c, gdbarch.h: Rebuild.
2244         * gdbarch.sh (core_pid_to_str): Change return type.
2245         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
2246         return type.
2247         (windows_nat_target::pid_to_str): Change return type.
2248         (windows_delete_thread): Update.
2249         (windows_nat_target::attach): Update.
2250         (windows_nat_target::files_info): Update.
2251         * target-delegates.c: Rebuild.
2252         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
2253         return type.
2254         (sol_thread_target::pid_to_str): Change return type.
2255         * remote.c (class remote_target) <pid_to_str>: Change return
2256         type.
2257         (remote_target::pid_to_str): Change return type.
2258         (extended_remote_target::attach, remote_target::remote_stop_ns)
2259         (remote_target::remote_notif_remove_queued_reply)
2260         (remote_target::push_stop_reply, remote_target::disable_btrace):
2261         Update.
2262         (extended_remote_target::attach): Update.
2263         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
2264         type.
2265         (gdbsim_target::pid_to_str): Change return type.
2266         * ravenscar-thread.c (struct ravenscar_thread_target)
2267         <pid_to_str>: Change return type.
2268         (ravenscar_thread_target::pid_to_str): Change return type.
2269         * procfs.c (class procfs_target) <pid_to_str>: Change return
2270         type.
2271         (procfs_target::pid_to_str): Change return type.
2272         (procfs_target::attach): Update.
2273         (procfs_target::detach): Update.
2274         (procfs_target::fetch_registers): Update.
2275         (procfs_target::store_registers): Update.
2276         (procfs_target::wait): Update.
2277         (procfs_target::files_info): Update.
2278         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
2279         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
2280         return type.
2281         (nto_procfs_target::pid_to_str): Change return type.
2282         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
2283         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
2284         return type.
2285         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
2286         (exit_lwp): Update.
2287         (attach_proc_task_lwp_callback, get_detach_signal)
2288         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
2289         (linux_nat_target::resume, wait_lwp, stop_callback)
2290         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
2291         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
2292         (linux_nat_wait_1, resume_stopped_resumed_lwps)
2293         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
2294         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
2295         type.
2296         (inf_ptrace_target::attach): Update.
2297         (inf_ptrace_target::files_info): Update.
2298         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
2299         type.
2300         (go32_nat_target::pid_to_str): Change return type.
2301         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
2302         (gnu_nat_target::wait): Update.
2303         (gnu_nat_target::wait): Update.
2304         (gnu_nat_target::resume): Update.
2305         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
2306         (fbsd_nat_target::wait): Update.
2307         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
2308         type.
2309         (darwin_nat_target::attach): Update.
2310         * corelow.c (class core_target) <pid_to_str>: Change return type.
2311         (core_target::pid_to_str): Change return type.
2312         * target.c (normal_pid_to_str): Change return type.
2313         (default_pid_to_str): Likewise.
2314         (target_pid_to_str): Change return type.
2315         (target_translate_tls_address): Update.
2316         (target_announce_detach): Update.
2317         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
2318         return type.
2319         (bsd_uthread_target::pid_to_str): Change return type.
2320         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
2321         type.
2322         (bsd_kvm_target::pid_to_str): Change return type.
2323         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
2324         return type.
2325         (aix_thread_target::pid_to_str): Change return type.
2326         * target.h (struct target_ops) <pid_to_str>: Change return type.
2327         (target_pid_to_str, normal_pid_to_str): Likewise.
2328         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
2329         type.
2330         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
2331         type.
2332         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
2333         return type.
2334         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
2335         type.
2336         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
2337         type.
2338         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
2339         return type.
2340
2341 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
2342
2343         * NEWS: Mention that the new default MI version is 3.  Mention
2344         changes to the output of commands and events that deal with
2345         multi-location breakpoints.
2346         * breakpoint.c: Include "mi/mi-out.h".
2347         (print_one_breakpoint): Change output syntax if using MI version
2348         >= 3.
2349         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
2350         New.
2351         (mi_multi_location_breakpoint_output_fixed): New.
2352         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
2353         (mi_cmd_fix_multi_location_breakpoint_output): New.
2354         (mi_multi_location_breakpoint_output_fixed): New.
2355         * mi/mi-cmds.c (mi_cmds): Register command
2356         -fix-multi-location-breakpoint-output.
2357         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
2358         interpreter "mi".
2359
2360 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
2361
2362         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
2363         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
2364         instantiate mi_ui_out based on interpreter name.
2365         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
2366         * mi/mi-main.c (mi_load_progress): Likewise.
2367
2368 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2369
2370         * NEWS: Combine separate "New targets" sections for 8.3.
2371
2372 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2373
2374         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
2375         (ppcfbsd_init_abi): Install gdbarch
2376         "fetch_tls_load_module_address" and "get_thread_local_address"
2377         methods.
2378
2379 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2380
2381         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
2382         (riscv_fbsd_init_abi): Install gdbarch
2383         "fetch_tls_load_module_address" and "get_thread_local_address"
2384         methods.
2385
2386 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2387
2388         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
2389         (i386fbsd_init_abi): Install gdbarch
2390         "fetch_tls_load_module_address" and "get_thread_local_address"
2391         methods.
2392
2393 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2394
2395         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
2396         (amd64fbsd_init_abi): Install gdbarch
2397         "fetch_tls_load_module_address" and "get_thread_local_address"
2398         methods.
2399
2400 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2401
2402         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
2403         (struct fbsd_pspace_data): New type.
2404         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
2405         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
2406         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
2407         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
2408         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
2409
2410 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2411
2412         * gdbtypes.c (lookup_struct_elt): New function.
2413         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
2414         * gdbtypes.h (struct struct_elt): New type.
2415         (lookup_struct_elt): New prototype.
2416
2417 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2418
2419         * gdbtypes.c (lookup_struct_elt_type): Update comment and
2420         remove disabled code block.
2421
2422 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2423
2424         * gdbarch.sh (get_thread_local_address): New method.
2425         * gdbarch.h, gdbarch.c: Regenerate.
2426         * target.c (target_translate_tls_address): Use
2427         gdbarch_get_thread_local_address if present instead of
2428         target::get_thread_local_address.
2429
2430 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2431
2432         * target.h (target::get_thread_local_address): Update comment.
2433
2434 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2435
2436         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
2437         objfile->separate_debug_objfile_backlink if not NULL.
2438
2439 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2440
2441         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
2442         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
2443         (amd64bsd_store_inferior_registers): Likewise.
2444         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2445         Enable segment base registers.
2446         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
2447         PT_GETFSBASE and PT_GETGSBASE.
2448         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
2449         PT_SETGSBASE.
2450         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
2451         segment base registers.
2452         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2453
2454 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2455
2456         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2457         Update calls to i386_target_description to add 'segments'
2458         parameter.
2459         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
2460         add segment base registers.
2461         * arch/i386.c (i386_create_target_description): Add 'segments'
2462         parameter to enable segment base registers.
2463         * arch/i386.h (i386_create_target_description): Likewise.
2464         * features/i386/32bit-segments.xml: New file.
2465         * features/i386/32bit-segments.c: Generate.
2466         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
2467         call to i386_target_description to add 'segments' parameter.
2468         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2469         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
2470         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
2471         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
2472         if feature is present.
2473         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
2474         Add 'segments' parameter to call to i386_target_description.
2475         (i386_target_description): Add 'segments' parameter to enable
2476         segment base registers.
2477         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
2478         to call to i386_target_description.
2479         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
2480         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
2481         Define I386_NUM_REGS.
2482         (i386_target_description): Add 'segments' parameter to enable
2483         segment base registers.
2484
2485 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
2486
2487         PR/24325
2488         * source-cache.c: #undef open and close, to avoid unresolved
2489         externals during linking.
2490
2491 2019-03-12  Tom Tromey  <tromey@adacore.com>
2492
2493         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
2494         const.  Add initializers.
2495         (_initialize_remote): Don't initialize ptid globals.
2496
2497 2019-03-12  Pedro Alves  <palves@redhat.com>
2498
2499         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
2500
2501 2019-03-12  Pedro Alves  <palves@redhat.com>
2502
2503         * cp-name-parser.y (main): Remove unused 'len' variable.
2504
2505 2019-03-12  Tom Tromey  <tromey@adacore.com>
2506
2507         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
2508         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
2509
2510 2019-03-12  Tom Tromey  <tromey@adacore.com>
2511
2512         * linux-nat.c (iterate_over_lwps): Update.
2513         (stop_callback): Remove parameter.
2514         (stop_wait_callback, detach_callback, resume_set_callback)
2515         (select_singlestep_lwp_callback, set_ignore_sigint)
2516         (status_callback, resumed_callback, resume_clear_callback)
2517         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
2518         data parameter.
2519         (linux_nat_target::detach, linux_nat_target::resume)
2520         (linux_stop_and_wait_all_lwps, select_event_lwp)
2521         (linux_nat_filter_event, linux_nat_wait_1)
2522         (linux_nat_target::kill, linux_nat_target::stop)
2523         (linux_nat_target::stop): Update.
2524         (linux_nat_resume_callback): Change type.
2525         (resume_stopped_resumed_lwps, count_events_callback)
2526         (select_event_lwp_callback): Likewise.
2527         (linux_stop_lwp, linux_nat_stop_lwp): Update.
2528         * arm-linux-nat.c (struct update_registers_data): Remove.
2529         (update_registers_callback): Change type.
2530         (arm_linux_insert_hw_breakpoint1): Update.
2531         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
2532         parameter.
2533         (x86_linux_dr_set_addr): Update.
2534         (x86_linux_dr_set_control): Update.
2535         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
2536         (iterate_over_lwps): Use gdb::function_view.
2537         * nat/aarch64-linux-hw-point.c (struct
2538         aarch64_dr_update_callback_param): Remove.
2539         (debug_reg_change_callback): Change type.
2540         (aarch64_notify_debug_reg_change): Update.
2541         * s390-linux-nat.c (s390_refresh_per_info): Update.
2542
2543 2019-03-11  Tom Tromey  <tromey@adacore.com>
2544
2545         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
2546         redundant assignment to "this_cu".
2547
2548 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2549
2550         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
2551
2552 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2553
2554         * gdbtypes.c (rank_one_type_parm_set): New function extracted
2555         from...
2556         (rank_one_type): ... this.
2557
2558 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2559
2560         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
2561         from...
2562         (rank_one_type): ... this.
2563
2564 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2565
2566         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
2567         from...
2568         (rank_one_type): ... this.
2569
2570 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2571
2572         * gdbtypes.c (rank_one_type_parm_float): New function extracted
2573         from...
2574         (rank_one_type): ... this.
2575
2576 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2577
2578         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
2579         from...
2580         (rank_one_type): ... this.
2581
2582 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2583
2584         * gdbtypes.c (rank_one_type_parm_range): New function extracted
2585         from...
2586         (rank_one_type): ... this.
2587
2588 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2589
2590         * gdbtypes.c (rank_one_type_parm_char): New function extracted
2591         from...
2592         (rank_one_type): ... this.
2593
2594 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2595
2596         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
2597         from...
2598         (rank_one_type): ... this.
2599
2600 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2601
2602         * gdbtypes.c (rank_one_type_parm_int): New function extracted
2603         from...
2604         (rank_one_type): ... this.
2605
2606 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2607
2608         * gdbtypes.c (rank_one_type_parm_func): New function extracted
2609         from...
2610         (rank_one_type): ... this.
2611
2612 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2613
2614         * gdbtypes.c (rank_one_type_parm_array): New function extracted
2615         from...
2616         (rank_one_type): ... this.
2617
2618 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2619
2620         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
2621         from...
2622         (rank_one_type): ... this.
2623
2624 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2625
2626         * inferior.c (initialize_inferiors): Ensure 'help set/show print
2627         inferior-events' shows the example events.
2628
2629 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
2630
2631         Support styling on native MS-Windows console
2632
2633         PR/24315
2634         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
2635         on MS-Windows if $TERM is not defined.
2636
2637         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
2638
2639         * posix-hdep.c (gdb_console_fputs):
2640         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
2641         functions.
2642         * ui-file.h (gdb_console_fputs): Add prototype.
2643
2644         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
2645         back to fputs only if the former returns zero.
2646
2647 2019-03-07  Tom Tromey  <tom@tromey.com>
2648
2649         * symmisc.c (print_symbol_bcache_statistics): Update.
2650         (print_objfile_statistics): Update.
2651         * symfile.c (allocate_symtab): Update.
2652         * stabsread.c: Don't include bcache.h.
2653         * psymtab.h (struct psymbol_bcache): Don't declare.
2654         (class psymtab_storage) <psymbol_cache>: Now a bcache.
2655         (psymbol_bcache_init, psymbol_bcache_free)
2656         (psymbol_bcache_get_bcache): Don't declare.
2657         * psymtab.c (struct psymbol_bcache): Remove.
2658         (psymtab_storage::psymtab_storage): Update.
2659         (psymtab_storage::~psymtab_storage): Update.
2660         (psymbol_bcache_init, psymbol_bcache_free)
2661         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
2662         (add_psymbol_to_bcache): Update.
2663         (allocate_psymtab): Update.
2664         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
2665         macro_cache>: No longer pointers.
2666         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
2667         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
2668         * macrotab.c (macro_bcache): Update.
2669         * macroexp.c: Don't include bcache.h.
2670         * gdbtypes.c (check_types_worklist): Update.
2671         (types_deeply_equal): Remove TRY/CATCH.  Update.
2672         * elfread.c (elf_symtab_read): Update.
2673         * dwarf2read.c: Don't include bcache.h.
2674         * buildsym.c (buildsym_compunit::get_macro_table): Update.
2675         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
2676         (print_bcache_statistics, bcache_memory_used): Don't declare.
2677         (struct bcache): Move from bcache.c.  Add constructor, destructor,
2678         methods.  Rename all data members.
2679         * bcache.c (struct bcache): Move to bcache.h.
2680         (bcache::expand_hash_table): Rename from expand_hash_table.
2681         (bcache): Remove.
2682         (bcache::insert): Rename from bcache_full.
2683         (bcache::compare): Rename from bcache_compare.
2684         (bcache_xmalloc): Remove.
2685         (bcache::~bcache): Rename from bcache_xfree.
2686         (bcache::print_statistics): Rename from print_bcache_statistics.
2687         (bcache::memory_used): Rename from bcache_memory_used.
2688
2689 2019-03-07  Pedro Alves  <palves@redhat.com>
2690
2691         * infrun.c (normal_stop): Also check for
2692         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
2693
2694 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
2695
2696         * f-lang.c (value_from_host_double): Moved to...
2697         * value.c (value_from_host_double): ...here.
2698         * value.h (value_from_host_double): Declare.
2699         * guile/scm-math.c (vlscm_convert_typed_number): Use
2700         value_from_host_double.
2701         (vlscm_convert_number): Likewise.
2702         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
2703         * python/py-value.c (convert_value_from_python): Likewise.
2704
2705 2019-03-06  Tom Tromey  <tom@tromey.com>
2706
2707         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
2708
2709 2019-03-06  Tom Tromey  <tom@tromey.com>
2710
2711         * utils.h (free_current_contents): Don't declare.
2712         * utils.c (free_current_contents): Remove.
2713
2714 2019-03-06  Tom Tromey  <tom@tromey.com>
2715
2716         * top.c (quit_force): Update.
2717         * main.c (captured_command_loop): Update.
2718         * common/new-op.c (operator new): Update.
2719         * common/common-exceptions.c (struct catcher)
2720         <save_cleanup_chain>: Remove member.
2721         (exceptions_state_mc_init): Update.
2722         (exception_try_scope_entry): Return nullptr.
2723         (exception_try_scope_exit, exception_rethrow)
2724         (throw_exception_sjlj, throw_exception_cxx): Update.
2725         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
2726         (all_cleanups, do_cleanups, discard_cleanups)
2727         (discard_final_cleanups, save_cleanups, save_final_cleanups)
2728         (restore_cleanups, restore_final_cleanups): Don't declare.
2729         (do_final_cleanups): Remove parameter.
2730         * common/cleanups.c (cleanup_chain, make_cleanup)
2731         (make_cleanup_dtor, all_cleanups, do_cleanups)
2732         (discard_my_cleanups, discard_cleanups)
2733         (discard_final_cleanups, save_my_cleanups, save_cleanups)
2734         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
2735         (null_cleanup): Remove.
2736         (do_final_cleanups): Remove parameter.
2737
2738 2019-03-06  Tom Tromey  <tom@tromey.com>
2739
2740         * remote.c (remote_target::remote_parse_stop_reply): Use
2741         unique_xmalloc_ptr.
2742
2743 2019-03-06  Tom Tromey  <tom@tromey.com>
2744
2745         * stabsread.c (struct stabs_field_info): Rename from field_info.
2746         <list, fnlist>: Add initializers.
2747         <obstack>: New member.
2748         (read_member_functions, read_struct_fields, read_baseclasses):
2749         Allocate on obstack.  Don't use cleanups.
2750         (read_one_struct_field, read_member_functions, read_struct_fields)
2751         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
2752         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
2753         (read_struct_type): Update.
2754
2755 2019-03-06  Tom Tromey  <tom@tromey.com>
2756
2757         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
2758         * common/filestuff.h (make_cleanup_close): Don't declare.
2759         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
2760         Remove.
2761
2762 2019-03-06  Tom Tromey  <tom@tromey.com>
2763
2764         * solib-aix.c: Use make_scope_exit.
2765
2766 2019-03-06  Tom Tromey  <tom@tromey.com>
2767
2768         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
2769         Use make_scope_exit.
2770
2771 2019-03-06  Tom Tromey  <tom@tromey.com>
2772
2773         * solib-svr4.c (disable_probes_interface): Remove parameter.
2774         (svr4_handle_solib_event): Use make_scope_exit.
2775
2776 2019-03-06  Tom Tromey  <tom@tromey.com>
2777
2778         * remote.c (struct stop_reply_deleter): Remove.
2779         (stop_reply_up): Update.
2780         (struct stop_reply): Derive from notif_event.  Don't typedef.
2781         <regcache>: Now a std::vector.
2782         (stop_reply_xfree): Remove.
2783         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
2784         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
2785         (remote_target::discard_pending_stop_replies): Use delete.
2786         (remote_target::remote_parse_stop_reply): Update.
2787         (remote_target::process_stop_reply): Update.
2788         * remote-notif.h (struct notif_event): Add virtual destructor.
2789         Remove "dtr" member.
2790         (struct notif_client) <alloc_event>: Return a unique_ptr.
2791         (notif_event_xfree): Don't declare.
2792         (notif_event_up): New typedef.
2793         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
2794         (notif_event_xfree, do_notif_event_xfree): Remove.
2795         (remote_notif_state_xfree): Update.
2796
2797 2019-03-06  Tom Tromey  <tom@tromey.com>
2798
2799         * infrun.c (displaced_step_clear_cleanup): Now a
2800         forward_scope_exit type.
2801         (displaced_step_prepare_throw): Update.
2802         (displaced_step_fixup): Update.
2803
2804 2019-03-06  Tom Tromey  <tom@tromey.com>
2805
2806         * inferior.h (class inferior): Update comment.
2807         * gdbthread.h (class thread_info): Update comment.
2808
2809 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
2810             Tom Tromey  <tom@tromey.com>
2811
2812         * stabsread.h (struct stab_section_list): Remove.
2813         (coffstab_build_psymtabs): Update.
2814         * dbxread.c (symbuf_sections): Now a std::vector.
2815         (sect_idx): New global.
2816         (fill_symbuf): Update.
2817         (coffstab_build_psymtabs): Change type of stabsects parameter.
2818         Update.
2819         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
2820         std::vector.
2821         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
2822         (coff_locate_sections): Update.
2823         (coff_symfile_read): Remove cleanups.  Update.
2824         (init_stringtab): Add storage parameter.
2825         (free_stringtab, free_stringtab_cleanup): Remove.
2826         (init_lineno): Add storage parameter.
2827         (free_linetab, free_linetab_cleanup): Remove.
2828
2829 2019-03-06  Pedro Alves  <palves@redhat.com>
2830
2831         * linux-fork.c (fork_info::clobber_regs): Delete.
2832         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
2833         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
2834         comment.  Adjust.
2835         (scoped_switch_fork_info::scoped_switch_fork_info)
2836         (checkpoint_command, linux_fork_context): Adjust
2837         fork_save_infrun_state calls.
2838
2839 2019-03-06  Pedro Alves  <palves@redhat.com>
2840
2841         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
2842         (inf_has_multiple_threads): Return 'bool' and rewrite using
2843         inferior_info::threads().
2844
2845 2019-03-06  Pedro Alves  <palves@redhat.com>
2846
2847         * linux-fork.c: Include <list>.
2848         (fork_list): Now a std::list instance.
2849         (fork_info): Add ctor, dtor, and in-class initialize all fields.
2850         (forks_exist_p, find_last_fork): Adjust.
2851         (new_fork): Delete.
2852         (one_fork_p): New.
2853         (add_fork): Adjust.
2854         (free_fork): Delete, folded into fork_info::~fork_info().
2855         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
2856         Adjust.
2857         (init_fork_list): Delete.
2858         (linux_fork_killall, linux_fork_mourn_inferior)
2859         (linux_fork_detach, info_checkpoints_command): Adjust.
2860         (_initialize_linux_fork): No longer call init_fork_list.
2861
2862 2019-03-06  Pedro Alves  <palves@redhat.com>
2863
2864         * linux-fork.c (new_fork): New, split out of ...
2865         (add_fork): ... this.  Return void.  Move "first fork" special
2866         case from here, to ...
2867         (checkpoint_command): ... here.
2868         * linux-linux.h (add_fork): Return void.
2869
2870 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2871
2872         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
2873
2874 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2875             Chris January  <chris.january@arm.com>
2876             David Lecomber  <david.lecomber@arm.com>
2877
2878         * f-exp.y: New token, UNOP_INTRINSIC.
2879         (exp): New pattern using UNOP_INTRINSIC token.
2880         (f77_keywords): Add 'abs' keyword.
2881         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
2882         (value_from_host_double): New function.
2883         (evaluate_subexp_f): Support UNOP_ABS.
2884
2885 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2886
2887         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
2888         types.
2889
2890 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2891
2892         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
2893         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
2894         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
2895
2896 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2897
2898         * f-exp.y (convert_to_kind_type): Handle more type kinds.
2899
2900 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2901             Chris January  <chris.january@arm.com>
2902
2903         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
2904         * f-exp.y: Define 'KIND' token.
2905         (exp): New pattern for KIND expressions.
2906         (ptype): Handle types with a kind extension.
2907         (direct_abs_decl): Extend to spot kind extensions.
2908         (f77_keywords): Add 'kind' to the list.
2909         (push_kind_type): New function.
2910         (convert_to_kind_type): New function.
2911         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
2912         * parse.c (operator_length_standard): Likewise.
2913         * parser-defs.h (enum type_pieces): Add tp_kind.
2914         * std-operator.def: Add UNOP_KIND.
2915
2916 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2917
2918         * f-exp.y (f_parse): Set yydebug.
2919
2920 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2921
2922         * f-lang.c (evaluate_subexp_f): New function.
2923         (exp_descriptor_f): New global.
2924         (f_language_defn): Use exp_descriptor_f instead of
2925         exp_descriptor_standard.
2926
2927 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2928
2929         * f-exp.y (struct token): Add comments.
2930         (dot_ops): Remove uppercase versions and the end marker.
2931         (f77_keywords): Likewise.
2932         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
2933         entries in the dot_ops array are case insensitive, and use
2934         strncasecmp to compare strings.  Also some whitespace cleanup in
2935         this area.  Similar for the f77_keywords array, except entries in
2936         this list might be case sensitive.
2937
2938 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2939
2940         * f-exp.y (struct f77_boolean_val): Add comments.
2941         (boolean_values): Remove uppercase versions, and end marker.
2942         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
2943         and use strncasecmp to achieve case insensitivity.  Additionally,
2944         perform whitespace cleanup around this code.
2945
2946 2019-03-06  Tom Tromey  <tromey@adacore.com>
2947
2948         * remote-sim.c (gdbsim_target_open): Use result of
2949         gdb_argv::release.
2950
2951 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
2952         Dirk Schubert  <dirk.schubert@arm.com>
2953         Chris January  <chris.january@arm.com>
2954
2955         * eval.c (evaluate_subexp_standard): Call Fortran argument
2956         wrapping logic.
2957         * f-lang.c (struct value): A value which can be passed into a
2958         Fortran function call.
2959         (fortran_argument_convert): Wrap Fortran arguments in a pointer
2960         where appropriate.
2961         (struct type): Value ready for a Fortran function call.
2962         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
2963         is needed.
2964         * f-lang.h (fortran_argument_convert): Declaration.
2965         (fortran_preserve_arg_pointer): Declaration.
2966         * infcall.c (value_arg_coerce): Call Fortran argument logic.
2967
2968 2019-03-05  Tom Tromey  <tromey@adacore.com>
2969
2970         * python/py-prettyprint.c (print_string_repr): Remove #if.
2971         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
2972
2973 2019-03-05  Tom Tromey  <tromey@adacore.com>
2974
2975         * target.c (the_dummy_target): Move later.  Change type to
2976         "dummy_target".
2977         (initialize_targets): Don't initialize the_dummy_target.
2978
2979 2019-03-05  Tom Tromey  <tromey@adacore.com>
2980
2981         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
2982         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
2983
2984 2019-03-05  Tom Tromey  <tromey@adacore.com>
2985
2986         * windows-nat.c (windows_nat_target::attach)
2987         (windows_nat_target::detach): Don't call gdb_flush.
2988         * valprint.c (generic_val_print, val_print, val_print_string):
2989         Don't call gdb_flush.
2990         * utils.c (defaulted_query): Don't call gdb_flush.
2991         * typeprint.c (print_type_scalar): Don't call gdb_flush.
2992         * target.c (target_announce_detach): Don't call gdb_flush.
2993         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
2994         * remote.c (extended_remote_target::attach): Don't call
2995         gdb_flush.
2996         * procfs.c (procfs_target::detach): Don't call gdb_flush.
2997         * printcmd.c (do_examine): Don't call gdb_flush.
2998         (info_display_command): Don't call gdb_flush.
2999         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
3000         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
3001         * memattr.c (info_mem_command): Don't call gdb_flush.
3002         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
3003         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
3004         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
3005         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
3006         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
3007         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
3008         (gnu_nat_target::detach): Don't call gdb_flush.
3009         * f-valprint.c (f_val_print): Don't call gdb_flush.
3010         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
3011         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
3012         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
3013         gdb_flush.
3014         * c-valprint.c (c_val_print): Don't call gdb_flush.
3015         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
3016
3017 2019-03-05  Tom Tromey  <tromey@adacore.com>
3018
3019         * varobj.c (update_dynamic_varobj_children): Update.
3020         (install_default_visualizer): Use reset, not release.
3021         * value.c (set_internalvar): Update.
3022         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
3023         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
3024         ATTRIBUTE_UNUSED_RESULT.
3025
3026 2019-03-05  Tom Tromey  <tromey@adacore.com>
3027
3028         * remote.c (class scoped_remote_fd) <release>: Add
3029         ATTRIBUTE_UNUSED_RESULT.
3030
3031 2019-03-05  Tom Tromey  <tromey@adacore.com>
3032
3033         * macroexp.c (struct macro_buffer) <release>: Add
3034         ATTRIBUTE_UNUSED_RESULT.
3035
3036 2019-03-05  Tom Tromey  <tromey@adacore.com>
3037
3038         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
3039         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
3040         ATTRIBUTE_UNUSED_RESULT.
3041
3042 2019-03-05  Tom Tromey  <tromey@adacore.com>
3043
3044         * common/scoped_fd.h (class scoped_fd) <release>: Add
3045         ATTRIBUTE_UNUSED_RESULT.
3046
3047 2019-03-05  Tom Tromey  <tromey@adacore.com>
3048
3049         * parser-defs.h (struct parser_state) <release>: Add
3050         ATTRIBUTE_UNUSED_RESULT.
3051
3052 2019-03-05  Tom Tromey  <tromey@adacore.com>
3053
3054         * utils.h (class gdb_argv) <release>: Add
3055         ATTRIBUTE_UNUSED_RESULT.
3056         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
3057
3058 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
3059
3060         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
3061         for-loop range, to avoid compiler warnings.
3062
3063         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
3064         avoid compiler warnings about unused variables.
3065
3066         * NEWS: Mention end of support for native debugging on MS-Windows
3067         before XP.
3068
3069         PR gdb/24292
3070         * common/netstuff.c:
3071         * gdbserver/gdbreplay.c
3072         * gdbserver/remote-utils.c:
3073         * ser-tcp.c:
3074         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
3075         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
3076         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
3077         'getaddrinfo' and 'freeaddrinfo' were not available before
3078         Windows XP, and mingw.org's MinGW headers by default define
3079         _WIN32_WINNT to 0x500.
3080
3081 2019-03-01  Gary Benson <gbenson@redhat.com>
3082
3083         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
3084
3085 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
3086             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
3087
3088         PR gdb/8527
3089         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
3090         set_sigint_trap, clear_sigint_trap.
3091
3092 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3093
3094         * target.c (target_detach): Clear the regcache and the
3095         frame cache.
3096
3097 2019-02-27  Pedro Alves  <palves@redhat.com>
3098
3099         * utils.c (set_screen_size): When we cap the height/width sizes,
3100         tweak the corresponding command variable to show "unlimited":
3101
3102 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
3103             Pedro Alves  <palves@redhat.com>
3104
3105         * utils.c (set_screen_size): Reduce "infinite" rows and columns
3106         before calling rl_set_screen_size.
3107
3108 2019-02-27  Tom Tromey  <tromey@adacore.com>
3109
3110         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
3111         define.
3112         * python/py-value.c: Remove Python 2.4 workaround.
3113         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
3114         workaround.
3115         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
3116         Python 2.4 workaround.
3117         * python/python-internal.h: Remove Python 2.4 comment.
3118         (Py_ssize_t): Don't define.
3119         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
3120         (gdb_Py_DECREF): Remove Python 2.4 workaround.
3121         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
3122         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
3123         * python/python.c (do_start_initialization): Remove Python 2.4
3124         workaround.
3125         * python/py-prettyprint.c (class dummy_python_frame): Remove.
3126         (print_children): Remove Python 2.4 workaround.
3127         * python/py-inferior.c (buffer_procs): Remove Python 2.4
3128         workaround.
3129         (CHARBUFFERPROC_NAME): Remove.
3130         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
3131         Python 2.4 workaround.
3132
3133 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3134
3135         * NEWS: Note minimum Python version.
3136
3137 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3138
3139         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
3140         code from these functions.  Remove corresponding ifdefs.  Use
3141         Py_buffer_up instead of explicit calls to PyBuffer_Release.
3142         Remove gotos and target of gotos.
3143         (infpy_search_memory): Likewise.
3144
3145 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3146
3147         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
3148         (hppa_gdbarch_init): Don't register deleted functions with
3149         gdbarch.
3150
3151 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3152
3153         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
3154         (h8300_unwind_sp): Delete.
3155         (h8300_dummy_id): Delete.
3156         (h8300_gdbarch_init): Don't register deleted functions with
3157         gdbarch.
3158
3159 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3160
3161         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
3162         (ft32_unwind_pc): Delete.
3163         (ft32_unwind_sp): Delete.
3164         (ft32_gdbarch_init): Don't register deleted functions with
3165         gdbarch.
3166
3167 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3168
3169         * gdb/frv-tdep.c (frv_dummy_id): Delete.
3170         (frv_unwind_pc): Delete.
3171         (frv_unwind_sp): Delete.
3172         (frv_gdbarch_init): Don't register deleted functions with
3173         gdbarch.
3174
3175 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3176
3177         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
3178         (riscv_unwind_pc): Delete.
3179         (riscv_unwind_sp): Delete.
3180         (riscv_gdbarch_init): Don't register deleted functions with
3181         gdbarch.
3182
3183 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3184
3185         * gdb/csky-tdep.c (csky_dummy_id): Delete.
3186         (csky_unwind_pc): Delete.
3187         (csky_unwind_sp): Delete.
3188         (csky_gdbarch_init): Don't register deleted functions with
3189         gdbarch.
3190
3191 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3192
3193         * gdb/cris-tdep.c (cris_dummy_id): Delete.
3194         (cris_unwind_pc): Delete.
3195         (cris_unwind_sp): Delete.
3196         (cris_gdbarch_init): Don't register deleted functions with
3197         gdbarch.
3198
3199 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3200
3201         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
3202         (bfin_unwind_pc): Delete.
3203         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
3204
3205 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3206
3207         * gdb/arm-tdep.c (arm_dummy_id): Delete.
3208         (arm_unwind_pc): Delete.
3209         (arm_unwind_sp): Delete.
3210         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
3211
3212 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3213
3214         * gdb/arc-tdep.c (arc_dummy_id): Delete.
3215         (arc_unwind_pc): Delete.
3216         (arc_unwind_sp): Delete.
3217         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
3218
3219 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3220
3221         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
3222         (alpha_unwind_pc): Delete.
3223         (alpha_gdbarch_init): Don't register deleted functions with
3224         gdbarch.
3225
3226 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3227
3228         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
3229         (aarch64_unwind_pc): Delete.
3230         (aarch64_unwind_sp): Delete.
3231         (aarch64_gdbarch_init): Don't register deleted functions with
3232         gdbarch.
3233
3234 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3235
3236         * gdbtypes.c (type_align): Don't consider static members when
3237         computing structure alignment.
3238
3239 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3240
3241         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
3242         return 0 for other types.
3243         * arch-utils.c (default_type_align): Always return 0.
3244         * gdbarch.h: Regenerate.
3245         * gdbarch.sh (type_align): Extend comment.
3246         * gdbtypes.c (type_align): Add additional comments, always call
3247         gdbarch_type_align before applying the default rules.
3248         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
3249         generic code will then apply a suitable default.
3250         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
3251         types, return 0 for other types.
3252
3253 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3254
3255         * NEWS: Create a new section for the next release branch.
3256         Rename the section of the current branch, now that it has
3257         been cut.
3258
3259 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3260
3261         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
3262         * version.in: Bump version to 8.3.50.DATE-git.
3263
3264 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
3265
3266         * aix-thread.c (ptid_cmp): Remove unused variable.
3267         (get_signaled_thread): Likewise.
3268         (store_regs_user_thread): Likewise.
3269         (store_regs_kernel_thread): Likewise.
3270         (fetch_regs_kernel_thread): Remove shadowed variable.
3271
3272 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3273
3274         * features/riscv/32bit-cpu.xml: Add register numbers.
3275         * features/riscv/32bit-fpu.c: Regenerate.
3276         * features/riscv/32bit-fpu.xml: Add register numbers.
3277         * features/riscv/64bit-cpu.xml: Add register numbers.
3278         * features/riscv/64bit-fpu.c: Regenerate.
3279         * features/riscv/64bit-fpu.xml: Add register numbers.
3280
3281 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
3282
3283         * NEWS: Mention two argument form of gdb.Value constructor.
3284         * python/py-value.c (convert_buffer_and_type_to_value): New
3285         function.
3286         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
3287         Add support for handling an optional second argument.  Call
3288         convert_buffer_and_type_to_value as appropriate.
3289         * python/python-internal.h (Py_buffer_deleter): New struct.
3290         (Py_buffer_up): New typedef.
3291
3292 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
3293
3294         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
3295         instead of releasing ownership.
3296
3297 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
3298
3299         * dwarf2read.c (open_and_init_dwp_file): Call
3300         elf_numsections instead of bfd_count_sections to initialize
3301         dwp_file->num_sections.
3302
3303 2019-02-25  Tom Tromey  <tromey@adacore.com>
3304
3305         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
3306
3307 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
3308
3309         * gcore.in: Add '--readnever' option when invoking GDB.
3310
3311 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3312
3313         * MAINTAINERS: Update my email address.
3314
3315 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3316
3317         * build-id.c (build_id_to_debug_bfd_1): New function.
3318         (build_id_to_debug_bfd): Look for separate debug file in
3319         sysroot.
3320
3321 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3322
3323         * gdbarch.sh: Update the copyright year range that is placed into
3324         generated files.
3325
3326 2019-02-22  Keith Seitz  <keiths@redhat.com>
3327
3328         PR symtab/23853
3329         * linespec.c (create_sals_line_offset): Search for the default
3330         symtab's filename instead of its fullname.
3331
3332 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3333
3334         * NEWS: Update style defaults.
3335
3336 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3337
3338         * main.c (captured_main_1): Disable styling in batch mode.
3339
3340 2019-02-20  Tom Tromey  <tom@tromey.com>
3341
3342         * symtab.c (symtab_symbol_info): Fix typos.
3343
3344 2019-02-20  Tom Tromey  <tromey@adacore.com>
3345
3346         * findcmd.c (_initialize_mem_search): Use upper case for
3347         metasyntactic variables.
3348
3349 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
3350
3351         * aarch64-tdep.c (aarch64_add_reggroups): New function.
3352         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
3353
3354 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
3355
3356         * top.h (source_file_name): Change to std::string.
3357         * top.c (source_file_name): Likewise.
3358         (command_line_input): Adjust.
3359         * cli/cli-script.c (script_from_file): Adjust.
3360
3361 2019-02-19  Tom Tromey  <tromey@adacore.com>
3362
3363         * ravenscar-thread.c
3364         (ravenscar_thread_target::update_thread_list): Don't call
3365         ada_build_task_list.
3366         * ada-lang.h (ada_build_task_list): Don't declare.
3367         * ada-tasks.c (struct ada_tasks_inferior_data)
3368         <task_list_valid_p>: Now bool.
3369         (read_known_tasks, ada_task_list_changed)
3370         (ada_tasks_invalidate_inferior_data): Update.
3371         (read_known_tasks_array): Return bool.
3372         (read_known_tasks_list): Likewise.
3373         (read_known_tasks): Return void.
3374         (ada_build_task_list): Now static.
3375
3376 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3377
3378         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
3379         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
3380
3381 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3382
3383         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
3384         variant for ada_tasks_pspace_data_handle and
3385         ada_tasks_inferior_data_handle.
3386         (ada_tasks_pspace_data_cleanup): New function.
3387         (ada_tasks_inferior_data_cleanup): New function.
3388
3389 2019-02-17  Tom Tromey  <tom@tromey.com>
3390
3391         * macrotab.h (macro_source_fullname): Return a std::string.
3392         * macrotab.c (macro_include, check_for_redefinition)
3393         (macro_undef, macro_lookup_definition, foreach_macro)
3394         (foreach_macro_in_scope): Update.
3395         (macro_source_fullname): Return a std::string.
3396         * macrocmd.c (show_pp_source_pos): Update.
3397
3398 2019-02-17  Tom Tromey  <tom@tromey.com>
3399
3400         * macrocmd.c (show_pp_source_pos): Style the file names.
3401
3402 2019-02-17  Tom Tromey  <tom@tromey.com>
3403
3404         PR tui/24197:
3405         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
3406
3407 2019-02-17  Tom Tromey  <tom@tromey.com>
3408
3409         * ada-lang.c (user_select_syms): Use filtered printing.
3410         * utils.c (wrap_style): New global.
3411         (desired_style): Remove.
3412         (emit_style_escape): Add stream parameter.
3413         (set_output_style, reset_terminal_style, prompt_for_continue):
3414         Update.
3415         (flush_wrap_buffer): Only flush gdb_stdout.
3416         (wrap_here): Set wrap_style.
3417         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
3418         treat escape sequences as a character.  Change when wrap buffer is
3419         flushed.
3420         (fputs_styled): Do not set the output style when the default is
3421         requested.
3422         * ui-style.h (struct ui_file_style) <is_default>: New method.
3423         * source.c (print_source_lines_base): Emit escape sequences in one
3424         piece.
3425
3426 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3427
3428         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
3429         integers and enumeration types.
3430
3431 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3432
3433         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
3434         instead of lookup_symbol_in_language
3435         (do_exact_match): New function.
3436         (ada_get_symbol_name_matcher): Return do_exact_match when
3437         doing a verbatim match.
3438
3439 2019-02-15  Tom Tromey  <tromey@adacore.com>
3440
3441         * ravenscar-thread.c (ravenscar_thread_target::resume)
3442         (ravenscar_thread_target::wait): Special case wildcard requests.
3443
3444 2019-02-15  Tom Tromey  <tromey@adacore.com>
3445
3446         * ravenscar-thread.c (base_ptid): Remove.
3447         (struct ravenscar_thread_target) <close>: New method.
3448         <m_base_ptid>: New member.
3449         <update_inferior_ptid, active_task, task_is_currently_active,
3450         runtime_initialized>: Declare methods.
3451         <ravenscar_thread_target>: Add constructor.
3452         (ravenscar_thread_target::task_is_currently_active)
3453         (ravenscar_thread_target::update_inferior_ptid)
3454         (ravenscar_runtime_initialized): Rename.  Now methods.
3455         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
3456         (ravenscar_thread_target::update_thread_list): Update.
3457         (ravenscar_thread_target::active_task): Now method.
3458         (ravenscar_thread_target::store_registers)
3459         (ravenscar_thread_target::prepare_to_store)
3460         (ravenscar_thread_target::prepare_to_store)
3461         (ravenscar_thread_target::mourn_inferior): Update.
3462         (ravenscar_inferior_created): Use "new" to create target.
3463         (ravenscar_thread_target::get_ada_task_ptid): Update.
3464         (_initialize_ravenscar): Don't initialize base_ptid.
3465         (ravenscar_ops): Remove global.
3466
3467 2019-02-15  Tom Tromey  <tromey@adacore.com>
3468
3469         * target.h (push_target): Declare new overload.
3470         * target.c (push_target): New overload, taking an rvalue reference.
3471         * remote.c (remote_target::open_1): Use push_target overload.
3472         * corelow.c (core_target_open): Use push_target overload.
3473
3474 2019-02-15  Tom Tromey  <tromey@adacore.com>
3475
3476         * ravenscar-thread.c (is_ravenscar_task)
3477         (ravenscar_task_is_currently_active): Return bool.
3478         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
3479         (_initialize_ravenscar): Remove "(void)".
3480         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
3481         Return bool.
3482
3483 2019-02-15  Tom Tromey  <tromey@adacore.com>
3484
3485         * ravenscar-thread.c (ravenscar_runtime_initializer)
3486         (has_ravenscar_runtime, get_running_thread_id)
3487         (ravenscar_thread_target::resume): Fix indentation.
3488
3489 2019-02-15  Tom Tromey  <tromey@adacore.com>
3490
3491         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
3492         from ravenscar_arch_ops.
3493         (sparc_ravenscar_ops::fetch_registers)
3494         (sparc_ravenscar_ops::store_registers): Now methods.
3495         (sparc_ravenscar_prepare_to_store): Remove.
3496         (sparc_ravenscar_ops): Redefine.
3497         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
3498         methods and destructor.  Remove members.
3499         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
3500         (ravenscar_thread_target::store_registers)
3501         (ravenscar_thread_target::prepare_to_store): Update.
3502         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
3503         Remove.
3504         (struct ppc_ravenscar_powerpc_ops): Derive from
3505         ravenscar_arch_ops.
3506         (ppc_ravenscar_powerpc_ops::fetch_registers)
3507         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
3508         (ppc_ravenscar_powerpc_ops): Redefine.
3509         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
3510         (ppc_ravenscar_e500_ops::fetch_registers)
3511         (ppc_ravenscar_e500_ops::store_registers): Now methods.
3512         (ppc_ravenscar_e500_ops): Redefine.
3513         * aarch64-ravenscar-thread.c
3514         (aarch64_ravenscar_generic_prepare_to_store): Remove.
3515         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
3516         (aarch64_ravenscar_fetch_registers)
3517         (aarch64_ravenscar_store_registers): Now methods.
3518         (aarch64_ravenscar_ops): Redefine.
3519
3520 2019-02-15  Tom Tromey  <tromey@adacore.com>
3521
3522         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
3523         (ravenscar_thread_target::stopped_by_hw_breakpoint)
3524         (ravenscar_thread_target::stopped_by_watchpoint)
3525         (ravenscar_thread_target::stopped_data_address)
3526         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
3527
3528 2019-02-15  Tom Tromey  <tromey@adacore.com>
3529
3530         * ravenscar-thread.c: Fix some typos.
3531
3532 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3533             Tom Tromey  <tromey@adacore.com>
3534
3535         * ada-lang.c (ada_exception_sal): Change addr_string to a
3536         std::string.
3537         (create_ada_exception_catchpoint): Update.
3538
3539 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3540             Tom Tromey  <tromey@adacore.com>
3541
3542         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
3543         (bp_location_ops): Remove.
3544         (base_breakpoint_allocate_location): Update.
3545         (free_bp_location): Update.
3546         * ada-lang.c (class ada_catchpoint_location)
3547         <ada_catchpoint_location>: Remove ops parameter.
3548         (ada_catchpoint_location_dtor): Remove.
3549         (ada_catchpoint_location_ops): Remove.
3550         (allocate_location_exception): Update.
3551         * breakpoint.h (struct bp_location_ops): Remove.
3552         (class bp_location) <bp_location>: Remove bp_location_ops
3553         parameter.
3554         <~bp_location>: Add destructor.
3555         <ops>: Remove.
3556
3557 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3558             Pedro Alves  <palves@redhat.com>
3559
3560         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
3561         'PATH_MAX'.
3562
3563 2019-02-14  David Michael  <fedora.dm0@gmail.com>
3564             Samuel Thibault  <samuel.thibault@gnu.org>
3565             Thomas Schwinge  <thomas@codesourcery.com>
3566
3567         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
3568         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
3569
3570 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3571
3572         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
3573         (check_empty): Use "const char *".
3574
3575         * gnu-nat.c (gnu_nat_target::detach): Instead of
3576         'detach_inferior (pid)' call
3577         'detach_inferior (find_inferior_pid (pid))'.
3578
3579         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
3580         'nat/fork-inferior.o'.
3581         * gnu-nat.c: #include "nat/fork-inferior.h".
3582
3583         * gnu-nat.c (gnu_nat_target::detach): Instead of
3584         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
3585         * gnu-nat.h: #include "inf-child.h".
3586         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
3587         'i386_gnu_nat_target::fetch_registers'.
3588         (gnu_store_registers): Rename/move to
3589         'i386_gnu_nat_target::store_registers'.
3590
3591         * config/i386/nm-i386gnu.h: Don't "#include" any files.
3592         * gnu-nat.h (mach_thread_info): New function.
3593         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
3594
3595         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
3596
3597 2019-02-14  Frederic Konrad  <konrad@adacore.com>
3598
3599         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
3600
3601 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
3602
3603         * windows-nat.c (windows_add_thread): Add new parameter
3604         "main_thread_p" with default value set to false.  Update
3605         function documentation as well as all callers.
3606         (windows_delete_thread): Likewise.
3607         (fake_create_process): Update call to windows_add_thread.
3608         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
3609         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
3610         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
3611         call to windows_delete_thread.
3612
3613 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
3614
3615         * MAINTAINERS: Add Andrew Burgess as global maintainer.
3616
3617 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3618
3619         * symfile.c (find_separate_debug_file): Use canonical path of
3620         sysroot with child_path instead of gdb_sysroot if it is valid.
3621
3622 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3623
3624         * symfile.c (find_separate_debug_file): Use child_path to
3625         determine if an object file is under a sysroot.
3626
3627 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3628
3629         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
3630         unittests/child-path-selftests.c.
3631         * common/pathstuff.c (child_path): New function.
3632         * common/pathstuff.h (child_path): New prototype.
3633         * unittests/child-path-selftests.c: New file.
3634
3635 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3636
3637         * symfile.c (find_separate_debug_file): Look for separate debug
3638         files in debug directories under the sysroot.
3639
3640 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3641
3642         * symtab.h (struct minimal_symbol data_p): New const method.
3643         (struct minimal_symbol text_p): Likewise.
3644         * symtab.c (output_source_filename): Use file name style
3645         to print file name.
3646         (print_symbol_info): Likewise.
3647         (print_msymbol_info): Use address style to print addresses.
3648         Use function name style to print executable text symbols.
3649         (expand_symtab_containing_pc): Use data_p.
3650         (find_pc_sect_compunit_symtab): Likewise.
3651
3652 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3653
3654         * breakpoint.c (describe_other_breakpoints): Use address style
3655         to print addresses.
3656         (say_where): Likewise.
3657
3658 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3659
3660         * ada-typeprint.c (print_func_type): Print function name
3661         style to print function name.
3662         * c-typeprint.c (c_print_type_1): Likewise.
3663
3664 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
3665
3666         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
3667         for execve.
3668
3669 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3670
3671         * c-exp.y (direct_abs_decl): Use emplace_back to record the
3672         type_stack.
3673
3674 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
3675
3676         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
3677         TYPE_CODE_REF types.
3678
3679 2019-02-08  Jim Wilson  <jimw@sifive.com>
3680
3681         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
3682         (riscv_linux_fregset): New.
3683         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
3684
3685 2019-02-07  Tom Tromey  <tom@tromey.com>
3686
3687         * thread.c (thread_cancel_execution_command): Update.
3688         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
3689         methods.
3690         (struct thread_fsm_ops): Remove.
3691         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
3692         (thread_fsm_should_stop, thread_fsm_return_value)
3693         (thread_fsm_set_finished, thread_fsm_finished_p)
3694         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
3695         Don't declare.
3696         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
3697         * infrun.c (clear_proceed_status_thread)
3698         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
3699         (print_stop_event): Update.
3700         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
3701         Add constructor.
3702         (step_command_fsm_ops): Remove.
3703         (new_step_command_fsm): Remove.
3704         (step_1): Update.
3705         (step_command_fsm::should_stop): Rename from
3706         step_command_fsm_should_stop.
3707         (step_command_fsm::clean_up): Rename from
3708         step_command_fsm_clean_up.
3709         (step_command_fsm::do_async_reply_reason): Rename from
3710         step_command_fsm_async_reply_reason.
3711         (struct until_next_fsm): Inherit from thread_fsm.  Add
3712         constructor.
3713         (until_next_fsm_ops): Remove.
3714         (new_until_next_fsm): Remove.
3715         (until_next_fsm::should_stop): Rename from
3716         until_next_fsm_should_stop.
3717         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
3718         (until_next_fsm::do_async_reply_reason): Rename from
3719         until_next_fsm_async_reply_reason.
3720         (struct finish_command_fsm): Inherit from thread_fsm.  Add
3721         constructor.  Change type of breakpoint.
3722         (finish_command_fsm_ops): Remove.
3723         (new_finish_command_fsm): Remove.
3724         (finish_command_fsm::should_stop): Rename from
3725         finish_command_fsm_should_stop.
3726         (finish_command_fsm::clean_up): Rename from
3727         finish_command_fsm_clean_up.
3728         (finish_command_fsm::return_value): Rename from
3729         finish_command_fsm_return_value.
3730         (finish_command_fsm::do_async_reply_reason): Rename from
3731         finish_command_fsm_async_reply_reason.
3732         (finish_command): Update.
3733         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
3734         Add constructor.
3735         (call_thread_fsm_ops): Remove.
3736         (call_thread_fsm::call_thread_fsm): Rename from
3737         new_call_thread_fsm.
3738         (call_thread_fsm::should_stop): Rename from
3739         call_thread_fsm_should_stop.
3740         (call_thread_fsm::should_notify_stop): Rename from
3741         call_thread_fsm_should_notify_stop.
3742         (run_inferior_call, call_function_by_hand_dummy): Update.
3743         * cli/cli-interp.c (should_print_stop_to_console): Update.
3744         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
3745         Add constructor.  Change type of location_breakpoint,
3746         caller_breakpoint.
3747         (until_break_fsm_ops): Remove.
3748         (new_until_break_fsm): Remove.
3749         (until_break_fsm::should_stop): Rename from
3750         until_break_fsm_should_stop.
3751         (until_break_fsm::clean_up): Rename from
3752         until_break_fsm_clean_up.
3753         (until_break_fsm::do_async_reply_reason): Rename from
3754         until_break_fsm_async_reply_reason.
3755         (until_break_command): Update.
3756         * thread-fsm.c: Remove.
3757         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
3758
3759 2019-02-07  Tom Tromey  <tom@tromey.com>
3760
3761         * yy-remap.h: Add include guard.
3762         * xtensa-tdep.h: Add include guard.
3763         * xcoffread.h: Rename include guard.
3764         * varobj-iter.h: Add include guard.
3765         * tui/tui.h: Rename include guard.
3766         * tui/tui-winsource.h: Rename include guard.
3767         * tui/tui-wingeneral.h: Rename include guard.
3768         * tui/tui-windata.h: Rename include guard.
3769         * tui/tui-win.h: Rename include guard.
3770         * tui/tui-stack.h: Rename include guard.
3771         * tui/tui-source.h: Rename include guard.
3772         * tui/tui-regs.h: Rename include guard.
3773         * tui/tui-out.h: Rename include guard.
3774         * tui/tui-layout.h: Rename include guard.
3775         * tui/tui-io.h: Rename include guard.
3776         * tui/tui-hooks.h: Rename include guard.
3777         * tui/tui-file.h: Rename include guard.
3778         * tui/tui-disasm.h: Rename include guard.
3779         * tui/tui-data.h: Rename include guard.
3780         * tui/tui-command.h: Rename include guard.
3781         * tic6x-tdep.h: Add include guard.
3782         * target/waitstatus.h: Rename include guard.
3783         * target/wait.h: Rename include guard.
3784         * target/target.h: Rename include guard.
3785         * target/resume.h: Rename include guard.
3786         * target-float.h: Rename include guard.
3787         * stabsread.h: Add include guard.
3788         * rs6000-tdep.h: Add include guard.
3789         * riscv-fbsd-tdep.h: Add include guard.
3790         * regformats/regdef.h: Rename include guard.
3791         * record.h: Rename include guard.
3792         * python/python.h: Rename include guard.
3793         * python/python-internal.h: Rename include guard.
3794         * python/py-stopevent.h: Rename include guard.
3795         * python/py-ref.h: Rename include guard.
3796         * python/py-record.h: Rename include guard.
3797         * python/py-record-full.h: Rename include guard.
3798         * python/py-record-btrace.h: Rename include guard.
3799         * python/py-instruction.h: Rename include guard.
3800         * python/py-events.h: Rename include guard.
3801         * python/py-event.h: Rename include guard.
3802         * procfs.h: Add include guard.
3803         * proc-utils.h: Add include guard.
3804         * p-lang.h: Add include guard.
3805         * or1k-tdep.h: Rename include guard.
3806         * observable.h: Rename include guard.
3807         * nto-tdep.h: Rename include guard.
3808         * nat/x86-linux.h: Rename include guard.
3809         * nat/x86-linux-dregs.h: Rename include guard.
3810         * nat/x86-gcc-cpuid.h: Add include guard.
3811         * nat/x86-dregs.h: Rename include guard.
3812         * nat/x86-cpuid.h: Rename include guard.
3813         * nat/ppc-linux.h: Rename include guard.
3814         * nat/mips-linux-watch.h: Rename include guard.
3815         * nat/linux-waitpid.h: Rename include guard.
3816         * nat/linux-ptrace.h: Rename include guard.
3817         * nat/linux-procfs.h: Rename include guard.
3818         * nat/linux-osdata.h: Rename include guard.
3819         * nat/linux-nat.h: Rename include guard.
3820         * nat/linux-namespaces.h: Rename include guard.
3821         * nat/linux-btrace.h: Rename include guard.
3822         * nat/glibc_thread_db.h: Rename include guard.
3823         * nat/gdb_thread_db.h: Rename include guard.
3824         * nat/gdb_ptrace.h: Rename include guard.
3825         * nat/fork-inferior.h: Rename include guard.
3826         * nat/amd64-linux-siginfo.h: Rename include guard.
3827         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
3828         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
3829         * nat/aarch64-linux.h: Rename include guard.
3830         * nat/aarch64-linux-hw-point.h: Rename include guard.
3831         * mn10300-tdep.h: Add include guard.
3832         * mips-linux-tdep.h: Add include guard.
3833         * mi/mi-parse.h: Rename include guard.
3834         * mi/mi-out.h: Rename include guard.
3835         * mi/mi-main.h: Rename include guard.
3836         * mi/mi-interp.h: Rename include guard.
3837         * mi/mi-getopt.h: Rename include guard.
3838         * mi/mi-console.h: Rename include guard.
3839         * mi/mi-common.h: Rename include guard.
3840         * mi/mi-cmds.h: Rename include guard.
3841         * mi/mi-cmd-break.h: Rename include guard.
3842         * m2-lang.h: Add include guard.
3843         * location.h: Rename include guard.
3844         * linux-record.h: Rename include guard.
3845         * linux-nat.h: Add include guard.
3846         * linux-fork.h: Add include guard.
3847         * i386-darwin-tdep.h: Rename include guard.
3848         * hppa-linux-offsets.h: Add include guard.
3849         * guile/guile.h: Rename include guard.
3850         * guile/guile-internal.h: Rename include guard.
3851         * gnu-nat.h: Rename include guard.
3852         * gdb-stabs.h: Rename include guard.
3853         * frv-tdep.h: Add include guard.
3854         * f-lang.h: Add include guard.
3855         * event-loop.h: Add include guard.
3856         * darwin-nat.h: Rename include guard.
3857         * cp-abi.h: Rename include guard.
3858         * config/sparc/nm-sol2.h: Rename include guard.
3859         * config/nm-nto.h: Rename include guard.
3860         * config/nm-linux.h: Add include guard.
3861         * config/i386/nm-i386gnu.h: Rename include guard.
3862         * config/djgpp/nl_types.h: Rename include guard.
3863         * config/djgpp/langinfo.h: Rename include guard.
3864         * compile/gcc-cp-plugin.h: Add include guard.
3865         * compile/gcc-c-plugin.h: Add include guard.
3866         * compile/compile.h: Rename include guard.
3867         * compile/compile-object-run.h: Rename include guard.
3868         * compile/compile-object-load.h: Rename include guard.
3869         * compile/compile-internal.h: Rename include guard.
3870         * compile/compile-cplus.h: Rename include guard.
3871         * compile/compile-c.h: Rename include guard.
3872         * common/xml-utils.h: Rename include guard.
3873         * common/x86-xstate.h: Rename include guard.
3874         * common/version.h: Rename include guard.
3875         * common/vec.h: Rename include guard.
3876         * common/tdesc.h: Rename include guard.
3877         * common/selftest.h: Rename include guard.
3878         * common/scoped_restore.h: Rename include guard.
3879         * common/scoped_mmap.h: Rename include guard.
3880         * common/scoped_fd.h: Rename include guard.
3881         * common/safe-iterator.h: Rename include guard.
3882         * common/run-time-clock.h: Rename include guard.
3883         * common/refcounted-object.h: Rename include guard.
3884         * common/queue.h: Rename include guard.
3885         * common/ptid.h: Rename include guard.
3886         * common/print-utils.h: Rename include guard.
3887         * common/preprocessor.h: Rename include guard.
3888         * common/pathstuff.h: Rename include guard.
3889         * common/observable.h: Rename include guard.
3890         * common/netstuff.h: Rename include guard.
3891         * common/job-control.h: Rename include guard.
3892         * common/host-defs.h: Rename include guard.
3893         * common/gdb_wait.h: Rename include guard.
3894         * common/gdb_vecs.h: Rename include guard.
3895         * common/gdb_unlinker.h: Rename include guard.
3896         * common/gdb_unique_ptr.h: Rename include guard.
3897         * common/gdb_tilde_expand.h: Rename include guard.
3898         * common/gdb_sys_time.h: Rename include guard.
3899         * common/gdb_string_view.h: Rename include guard.
3900         * common/gdb_splay_tree.h: Rename include guard.
3901         * common/gdb_setjmp.h: Rename include guard.
3902         * common/gdb_ref_ptr.h: Rename include guard.
3903         * common/gdb_optional.h: Rename include guard.
3904         * common/gdb_locale.h: Rename include guard.
3905         * common/gdb_assert.h: Rename include guard.
3906         * common/filtered-iterator.h: Rename include guard.
3907         * common/filestuff.h: Rename include guard.
3908         * common/fileio.h: Rename include guard.
3909         * common/environ.h: Rename include guard.
3910         * common/common-utils.h: Rename include guard.
3911         * common/common-types.h: Rename include guard.
3912         * common/common-regcache.h: Rename include guard.
3913         * common/common-inferior.h: Rename include guard.
3914         * common/common-gdbthread.h: Rename include guard.
3915         * common/common-exceptions.h: Rename include guard.
3916         * common/common-defs.h: Rename include guard.
3917         * common/common-debug.h: Rename include guard.
3918         * common/cleanups.h: Rename include guard.
3919         * common/buffer.h: Rename include guard.
3920         * common/btrace-common.h: Rename include guard.
3921         * common/break-common.h: Rename include guard.
3922         * cli/cli-utils.h: Rename include guard.
3923         * cli/cli-style.h: Rename include guard.
3924         * cli/cli-setshow.h: Rename include guard.
3925         * cli/cli-script.h: Rename include guard.
3926         * cli/cli-interp.h: Rename include guard.
3927         * cli/cli-decode.h: Rename include guard.
3928         * cli/cli-cmds.h: Rename include guard.
3929         * charset-list.h: Add include guard.
3930         * buildsym-legacy.h: Rename include guard.
3931         * bfin-tdep.h: Add include guard.
3932         * ax.h: Rename include guard.
3933         * arm-linux-tdep.h: Add include guard.
3934         * arm-fbsd-tdep.h: Add include guard.
3935         * arch/xtensa.h: Rename include guard.
3936         * arch/tic6x.h: Add include guard.
3937         * arch/i386.h: Add include guard.
3938         * arch/arm.h: Rename include guard.
3939         * arch/arm-linux.h: Rename include guard.
3940         * arch/arm-get-next-pcs.h: Rename include guard.
3941         * arch/amd64.h: Add include guard.
3942         * arch/aarch64-insn.h: Rename include guard.
3943         * arch-utils.h: Rename include guard.
3944         * annotate.h: Add include guard.
3945         * amd64-darwin-tdep.h: Rename include guard.
3946         * aarch64-linux-tdep.h: Add include guard.
3947         * aarch64-fbsd-tdep.h: Add include guard.
3948         * aarch32-linux-nat.h: Add include guard.
3949
3950 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3951
3952         * macrotab.c (macro_define_internal): New function that
3953         factorizes macro_define_object_internal and macro_define_function
3954         code.
3955         (macro_define_object_internal): Use macro_define_internal.
3956         (macro_define_function): Likewise.
3957
3958 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3959
3960         * macrocmd.c (extract_identifier): Return
3961         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
3962         callers.
3963
3964 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
3965
3966         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
3967
3968 2019-02-05  Tom Tromey  <tom@tromey.com>
3969
3970         * target.c (target_stack::unpush): Move assertion earlier.
3971
3972 2019-01-30  Tom Tromey  <tom@tromey.com>
3973
3974         PR python/23615:
3975         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
3976         (gdbpy_parse_and_eval): Likewise.
3977         * python/python-internal.h (gdbpy_allow_threads): New class.
3978
3979 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
3980
3981         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
3982         (aarch64_fbsd_fpregmap): Move earlier.
3983         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
3984         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3985         instead of individual calls to trad_frame_set_reg_addr.
3986         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
3987         earlier.
3988         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
3989         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3990         instead of individual calls to trad_frame_set_reg_addr.
3991
3992 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
3993
3994         * CONTRIBUTE: Replace contribution list with wiki link.
3995
3996 2019-01-25  Tom Tromey  <tom@tromey.com>
3997
3998         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
3999
4000 2019-01-25  Tom Tromey  <tom@tromey.com>
4001
4002         * xtensa-linux-nat.c: Fix common/ includes.
4003         * xml-support.h: Fix common/ includes.
4004         * xml-support.c: Fix common/ includes.
4005         * x86-linux-nat.c: Fix common/ includes.
4006         * windows-nat.c: Fix common/ includes.
4007         * varobj.h: Fix common/ includes.
4008         * varobj.c: Fix common/ includes.
4009         * value.c: Fix common/ includes.
4010         * valops.c: Fix common/ includes.
4011         * utils.c: Fix common/ includes.
4012         * unittests/xml-utils-selftests.c: Fix common/ includes.
4013         * unittests/utils-selftests.c: Fix common/ includes.
4014         * unittests/unpack-selftests.c: Fix common/ includes.
4015         * unittests/tracepoint-selftests.c: Fix common/ includes.
4016         * unittests/style-selftests.c: Fix common/ includes.
4017         * unittests/string_view-selftests.c: Fix common/ includes.
4018         * unittests/scoped_restore-selftests.c: Fix common/ includes.
4019         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
4020         * unittests/scoped_fd-selftests.c: Fix common/ includes.
4021         * unittests/rsp-low-selftests.c: Fix common/ includes.
4022         * unittests/parse-connection-spec-selftests.c: Fix common/
4023         includes.
4024         * unittests/optional-selftests.c: Fix common/ includes.
4025         * unittests/offset-type-selftests.c: Fix common/ includes.
4026         * unittests/observable-selftests.c: Fix common/ includes.
4027         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
4028         * unittests/memrange-selftests.c: Fix common/ includes.
4029         * unittests/memory-map-selftests.c: Fix common/ includes.
4030         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
4031         * unittests/function-view-selftests.c: Fix common/ includes.
4032         * unittests/environ-selftests.c: Fix common/ includes.
4033         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
4034         * unittests/common-utils-selftests.c: Fix common/ includes.
4035         * unittests/cli-utils-selftests.c: Fix common/ includes.
4036         * unittests/array-view-selftests.c: Fix common/ includes.
4037         * ui-file.c: Fix common/ includes.
4038         * tui/tui-io.c: Fix common/ includes.
4039         * tracepoint.h: Fix common/ includes.
4040         * tracepoint.c: Fix common/ includes.
4041         * tracefile-tfile.c: Fix common/ includes.
4042         * top.h: Fix common/ includes.
4043         * top.c: Fix common/ includes.
4044         * thread.c: Fix common/ includes.
4045         * target/waitstatus.h: Fix common/ includes.
4046         * target/waitstatus.c: Fix common/ includes.
4047         * target.h: Fix common/ includes.
4048         * target.c: Fix common/ includes.
4049         * target-memory.c: Fix common/ includes.
4050         * target-descriptions.c: Fix common/ includes.
4051         * symtab.h: Fix common/ includes.
4052         * symfile.c: Fix common/ includes.
4053         * stap-probe.c: Fix common/ includes.
4054         * spu-linux-nat.c: Fix common/ includes.
4055         * sparc-nat.c: Fix common/ includes.
4056         * source.c: Fix common/ includes.
4057         * solib.c: Fix common/ includes.
4058         * solib-target.c: Fix common/ includes.
4059         * ser-unix.c: Fix common/ includes.
4060         * ser-tcp.c: Fix common/ includes.
4061         * ser-pipe.c: Fix common/ includes.
4062         * ser-base.c: Fix common/ includes.
4063         * selftest-arch.c: Fix common/ includes.
4064         * s12z-tdep.c: Fix common/ includes.
4065         * rust-exp.y: Fix common/ includes.
4066         * rs6000-aix-tdep.c: Fix common/ includes.
4067         * riscv-tdep.c: Fix common/ includes.
4068         * remote.c: Fix common/ includes.
4069         * remote-notif.h: Fix common/ includes.
4070         * remote-fileio.h: Fix common/ includes.
4071         * remote-fileio.c: Fix common/ includes.
4072         * regcache.h: Fix common/ includes.
4073         * regcache.c: Fix common/ includes.
4074         * record-btrace.c: Fix common/ includes.
4075         * python/python.c: Fix common/ includes.
4076         * python/py-type.c: Fix common/ includes.
4077         * python/py-inferior.c: Fix common/ includes.
4078         * progspace.h: Fix common/ includes.
4079         * producer.c: Fix common/ includes.
4080         * procfs.c: Fix common/ includes.
4081         * proc-api.c: Fix common/ includes.
4082         * printcmd.c: Fix common/ includes.
4083         * ppc-linux-nat.c: Fix common/ includes.
4084         * parser-defs.h: Fix common/ includes.
4085         * osdata.c: Fix common/ includes.
4086         * obsd-nat.c: Fix common/ includes.
4087         * nat/x86-linux.c: Fix common/ includes.
4088         * nat/x86-linux-dregs.c: Fix common/ includes.
4089         * nat/x86-dregs.h: Fix common/ includes.
4090         * nat/x86-dregs.c: Fix common/ includes.
4091         * nat/ppc-linux.c: Fix common/ includes.
4092         * nat/mips-linux-watch.h: Fix common/ includes.
4093         * nat/mips-linux-watch.c: Fix common/ includes.
4094         * nat/linux-waitpid.c: Fix common/ includes.
4095         * nat/linux-ptrace.h: Fix common/ includes.
4096         * nat/linux-ptrace.c: Fix common/ includes.
4097         * nat/linux-procfs.c: Fix common/ includes.
4098         * nat/linux-personality.c: Fix common/ includes.
4099         * nat/linux-osdata.c: Fix common/ includes.
4100         * nat/linux-namespaces.c: Fix common/ includes.
4101         * nat/linux-btrace.h: Fix common/ includes.
4102         * nat/linux-btrace.c: Fix common/ includes.
4103         * nat/fork-inferior.c: Fix common/ includes.
4104         * nat/amd64-linux-siginfo.c: Fix common/ includes.
4105         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
4106         * nat/aarch64-linux.c: Fix common/ includes.
4107         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
4108         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
4109         * namespace.h: Fix common/ includes.
4110         * mips-linux-tdep.c: Fix common/ includes.
4111         * minsyms.c: Fix common/ includes.
4112         * mi/mi-parse.h: Fix common/ includes.
4113         * mi/mi-main.c: Fix common/ includes.
4114         * mi/mi-cmd-env.c: Fix common/ includes.
4115         * memrange.h: Fix common/ includes.
4116         * memattr.c: Fix common/ includes.
4117         * maint.h: Fix common/ includes.
4118         * maint.c: Fix common/ includes.
4119         * main.c: Fix common/ includes.
4120         * machoread.c: Fix common/ includes.
4121         * location.c: Fix common/ includes.
4122         * linux-thread-db.c: Fix common/ includes.
4123         * linux-nat.c: Fix common/ includes.
4124         * linux-fork.c: Fix common/ includes.
4125         * inline-frame.c: Fix common/ includes.
4126         * infrun.c: Fix common/ includes.
4127         * inflow.c: Fix common/ includes.
4128         * inferior.h: Fix common/ includes.
4129         * inferior.c: Fix common/ includes.
4130         * infcmd.c: Fix common/ includes.
4131         * inf-ptrace.c: Fix common/ includes.
4132         * inf-child.c: Fix common/ includes.
4133         * ia64-linux-nat.c: Fix common/ includes.
4134         * i387-tdep.c: Fix common/ includes.
4135         * i386-tdep.c: Fix common/ includes.
4136         * i386-linux-tdep.c: Fix common/ includes.
4137         * i386-linux-nat.c: Fix common/ includes.
4138         * i386-go32-tdep.c: Fix common/ includes.
4139         * i386-fbsd-tdep.c: Fix common/ includes.
4140         * i386-fbsd-nat.c: Fix common/ includes.
4141         * guile/scm-type.c: Fix common/ includes.
4142         * guile/guile.c: Fix common/ includes.
4143         * go32-nat.c: Fix common/ includes.
4144         * gnu-nat.c: Fix common/ includes.
4145         * gdbthread.h: Fix common/ includes.
4146         * gdbarch-selftests.c: Fix common/ includes.
4147         * gdb_usleep.c: Fix common/ includes.
4148         * gdb_select.h: Fix common/ includes.
4149         * gdb_bfd.c: Fix common/ includes.
4150         * gcore.c: Fix common/ includes.
4151         * fork-child.c: Fix common/ includes.
4152         * findvar.c: Fix common/ includes.
4153         * fbsd-nat.c: Fix common/ includes.
4154         * event-top.c: Fix common/ includes.
4155         * event-loop.c: Fix common/ includes.
4156         * dwarf2read.c: Fix common/ includes.
4157         * dwarf2loc.c: Fix common/ includes.
4158         * dwarf2-frame.c: Fix common/ includes.
4159         * dwarf-index-cache.c: Fix common/ includes.
4160         * dtrace-probe.c: Fix common/ includes.
4161         * disasm-selftests.c: Fix common/ includes.
4162         * defs.h: Fix common/ includes.
4163         * csky-tdep.c: Fix common/ includes.
4164         * cp-valprint.c: Fix common/ includes.
4165         * cp-support.h: Fix common/ includes.
4166         * cp-support.c: Fix common/ includes.
4167         * corelow.c: Fix common/ includes.
4168         * completer.h: Fix common/ includes.
4169         * completer.c: Fix common/ includes.
4170         * compile/compile.c: Fix common/ includes.
4171         * compile/compile-loc2c.c: Fix common/ includes.
4172         * compile/compile-cplus-types.c: Fix common/ includes.
4173         * compile/compile-cplus-symbols.c: Fix common/ includes.
4174         * command.h: Fix common/ includes.
4175         * cli/cli-dump.c: Fix common/ includes.
4176         * cli/cli-cmds.c: Fix common/ includes.
4177         * charset.c: Fix common/ includes.
4178         * build-id.c: Fix common/ includes.
4179         * btrace.h: Fix common/ includes.
4180         * btrace.c: Fix common/ includes.
4181         * breakpoint.h: Fix common/ includes.
4182         * breakpoint.c: Fix common/ includes.
4183         * ax.h: 
4184         (enum agent_op): Fix common/ includes.
4185         * ax-general.c (struct aop_map): Fix common/ includes.
4186         * ax-gdb.c: Fix common/ includes.
4187         * auxv.c: Fix common/ includes.
4188         * auto-load.c: Fix common/ includes.
4189         * arm-tdep.c: Fix common/ includes.
4190         * arch/riscv.c: Fix common/ includes.
4191         * arch/ppc-linux-common.c: Fix common/ includes.
4192         * arch/i386.c: Fix common/ includes.
4193         * arch/arm.c: Fix common/ includes.
4194         * arch/arm-linux.c: Fix common/ includes.
4195         * arch/arm-get-next-pcs.c: Fix common/ includes.
4196         * arch/amd64.c: Fix common/ includes.
4197         * arch/aarch64.c: Fix common/ includes.
4198         * arch/aarch64-insn.c: Fix common/ includes.
4199         * arch-utils.c: Fix common/ includes.
4200         * amd64-windows-tdep.c: Fix common/ includes.
4201         * amd64-tdep.c: Fix common/ includes.
4202         * amd64-sol2-tdep.c: Fix common/ includes.
4203         * amd64-obsd-tdep.c: Fix common/ includes.
4204         * amd64-nbsd-tdep.c: Fix common/ includes.
4205         * amd64-linux-tdep.c: Fix common/ includes.
4206         * amd64-linux-nat.c: Fix common/ includes.
4207         * amd64-fbsd-tdep.c: Fix common/ includes.
4208         * amd64-fbsd-nat.c: Fix common/ includes.
4209         * amd64-dicos-tdep.c: Fix common/ includes.
4210         * amd64-darwin-tdep.c: Fix common/ includes.
4211         * agent.c: Fix common/ includes.
4212         * ada-lang.h: Fix common/ includes.
4213         * ada-lang.c: Fix common/ includes.
4214         * aarch64-tdep.c: Fix common/ includes.
4215
4216 2019-01-25  Tom Tromey  <tom@tromey.com>
4217
4218         * common/create-version.sh: Use common/version.h.
4219
4220 2019-01-24  Pedro Alves  <palves@redhat.com>
4221
4222         * infrun.c (signal_stop, signal_print, signal_program)
4223         (signal_catch, signal_pass): Now arrays instead of pointers.
4224         (update_signals_program_target, do_target_resume)
4225         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
4226         * linux-nat.c (linux_nat_target::pass_signals)
4227         (linux_nat_target::create_inferior, linux_nat_target::attach):
4228         Adjust.
4229         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
4230         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
4231         * procfs.c (procfs_target::pass_signals): Adjust.
4232         * record-full.c (record_full_target::resume): Adjust.
4233         * remote.c (remote_target::pass_signals)
4234         (remote_target::program_signals): Adjust.
4235         * target-debug.h (target_debug_print_signals): Now takes a
4236         gdb::array_view as parameter.  Adjust.
4237         * target.h (target_ops) <pass_signals, program_signals>: Replace
4238         pointer and length parameters with gdb::array_view.
4239         (target_pass_signals, target_program_signals): Likewise.
4240         * target-delegates.c: Regenerate.
4241
4242 2019-01-24  Pedro Alves  <palves@redhat.com>
4243
4244         * common/forward-scope-exit.h
4245         (forward_scope_exit::forward_scope_exit): Pass arguments to
4246         m_bind_function directly, instead of creating a std::bind and
4247         copying that.
4248
4249 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
4250
4251         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4252         for static members.
4253         (pass_in_v_vfp_candidate): Likewise.
4254
4255 2019-01-23  Tom Tromey  <tom@tromey.com>
4256             Pedro Alves  <palves@redhat.com>
4257
4258         * regcache.c (class regcache_invalidator): Remove.
4259         (regcache::raw_write): Use make_scope_exit.
4260
4261 2019-01-23  Tom Tromey  <tom@tromey.com>
4262
4263         * ui-out.h (class ui_out_emit_type): Update comment.
4264
4265 2019-01-23  Tom Tromey  <tom@tromey.com>
4266
4267         * infrun.c (fetch_inferior_event): Update comment.
4268
4269 2019-01-23  Tom Tromey  <tom@tromey.com>
4270             Pedro Alves  <palves@redhat.com>
4271
4272         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
4273         parameter.
4274         (fetch_inferior_event): Use SCOPE_EXIT.
4275
4276
4277 2019-01-23  Tom Tromey  <tom@tromey.com>
4278             Pedro Alves  <palves@redhat.com>
4279
4280         * infrun.c (disable_thread_events): Delete.
4281         (stop_all_threads): Use SCOPE_EXIT.
4282
4283 2019-01-23  Tom Tromey  <tom@tromey.com>
4284             Pedro Alves  <palves@redhat.com>
4285
4286         * symfile.c: Include forward-scope-exit.h.
4287         (clear_symtab_users_cleanup): Replace forward declaration with
4288         a FORWARD_SCOPE_EXIT.
4289         (syms_from_objfile_1): Use the forward_scope_exit and
4290         gdb::optional instead of cleanup_function.
4291         (reread_symbols): Use the forward_scope_exit instead of
4292         cleanup_function.
4293         (clear_symtab_users_cleanup): Remove function.
4294
4295 2019-01-23  Tom Tromey  <tom@tromey.com>
4296             Pedro Alves  <palves@redhat.com>
4297
4298         * linux-nat.c: Include scope-exit.h.
4299         (cleanup_target_stop): Remove.
4300         (linux_nat_target::static_tracepoint_markers_by_strid): Use
4301         SCOPE_EXIT.
4302
4303 2019-01-23  Tom Tromey  <tom@tromey.com>
4304             Pedro Alves  <palves@redhat.com>
4305
4306         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
4307         (call_function_by_hand_dummy): Use SCOPE_EXIT.
4308
4309 2019-01-23  Tom Tromey  <tom@tromey.com>
4310             Andrew Burgess  <andrew.burgess@embecosm.com>
4311             Pedro Alves  <palves@redhat.com>
4312
4313         * infrun.c (fetch_inferior_event): Use scope_exit.
4314         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
4315         * top.c (execute_command): Use scope_exit.
4316         * breakpoint.c (bpstat_do_actions): Use scope_exit.
4317         * utils.c (do_bpstat_clear_actions_cleanup)
4318         (make_bpstat_clear_actions_cleanup): Remove.
4319
4320 2019-01-23  Tom Tromey  <tom@tromey.com>
4321             Pedro Alves  <palves@redhat.com>
4322
4323         * infrun.c: Include "common/scope-exit.h"
4324         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
4325         (wait_for_inferior): Use SCOPE_EXIT.
4326         (fetch_inferior_event): Use scope_exit.
4327
4328 2019-01-23  Tom Tromey  <tom@tromey.com>
4329             Pedro Alves  <palves@redhat.com>
4330
4331         * breakpoint.c (create_breakpoint): Remove cleanup.
4332
4333 2019-01-23  Tom Tromey  <tom@tromey.com>
4334             Andrew Burgess  <andrew.burgess@embecosm.com>
4335             Pedro Alves  <palves@redhat.com>
4336
4337 2019-01-23  Pedro Alves  <palves@redhat.com>
4338
4339         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
4340
4341 2019-01-23  Pedro Alves  <palves@redhat.com>
4342             Andrew Burgess  <andrew.burgess@embecosm.com>
4343
4344         * gdbthread.h: Include "common/forward-scope-exit.h".
4345         (scoped_finish_thread_state): Redefine custom class in terms of
4346         forward_scope_exit.
4347
4348 2019-01-23  Pedro Alves  <palves@redhat.com>
4349             Andrew Burgess  <andrew.burgess@embecosm.com>
4350
4351         * common/forward-scope-exit.h: New file.
4352
4353 2019-01-23  Pedro Alves  <palves@redhat.com>
4354             Andrew Burgess  <andrew.burgess@embecosm.com>
4355             Tom Tromey  <tom@tromey.com>
4356
4357         * common/scope-exit.h: New file.
4358
4359 2019-01-23  Pedro Alves  <palves@redhat.com>
4360
4361         * common/preprocessor.h (ESC): Rename to ...
4362         (ESC_PARENS): ... this.
4363         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
4364         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
4365
4366 2019-01-23  Tom Tromey  <tom@tromey.com>
4367
4368         * language.h (class scoped_switch_to_sym_language_if_auto):
4369         Initialize m_lang in both cases.
4370
4371 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
4372
4373         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
4374         with XCNEW.
4375
4376 2019-01-22  Tom Tromey  <tom@tromey.com>
4377
4378         * corelow.c: Do not include sys/file.h.
4379
4380 2019-01-22  Tom Tromey  <tom@tromey.com>
4381
4382         * tui/tui-wingeneral.h: Include gdb_curses.h.
4383
4384 2019-01-22  Tom Tromey  <tom@tromey.com>
4385
4386         * source-cache.h (class source_cache) <get_source_lines,
4387         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
4388
4389 2019-01-22  Tom Tromey  <tom@tromey.com>
4390
4391         * remote-fileio.h (struct remote_target): Declare.
4392
4393 2019-01-22  Tom Tromey  <tom@tromey.com>
4394
4395         * python/py-arch.c: Do not include py-ref.h.
4396         * python/py-bpevent.c: Do not include py-ref.h.
4397         * python/py-cmd.c: Do not include py-ref.h.
4398         * python/py-continueevent.c: Do not include py-ref.h.
4399         * python/py-event.h: Do not include py-ref.h.
4400         * python/py-evtregistry.c: Do not include py-ref.h.
4401         * python/py-finishbreakpoint.c: Do not include py-ref.h.
4402         * python/py-frame.c: Do not include py-ref.h.
4403         * python/py-framefilter.c: Do not include py-ref.h.
4404         * python/py-function.c: Do not include py-ref.h.
4405         * python/py-infevents.c: Do not include py-ref.h.
4406         * python/py-linetable.c: Do not include py-ref.h.
4407         * python/py-objfile.c: Do not include py-ref.h.
4408         * python/py-param.c: Do not include py-ref.h.
4409         * python/py-prettyprint.c: Do not include py-ref.h.
4410         * python/py-progspace.c: Do not include py-ref.h.
4411         * python/py-symbol.c: Do not include py-ref.h.
4412         * python/py-symtab.c: Do not include py-ref.h.
4413         * python/py-type.c: Do not include py-ref.h.
4414         * python/py-unwind.c: Do not include py-ref.h.
4415         * python/py-utils.c: Do not include py-ref.h.
4416         * python/py-value.c: Do not include py-ref.h.
4417         * python/py-varobj.c: Do not include py-ref.h.
4418         * python/py-xmethods.c: Do not include py-ref.h.
4419         * python/python.c: Do not include py-ref.h.
4420         * varobj.c: Do not include py-ref.h.
4421
4422 2019-01-22  Tom Tromey  <tom@tromey.com>
4423
4424         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
4425         keyword for bcache.
4426
4427 2019-01-22  Tom Tromey  <tom@tromey.com>
4428
4429         * compile/compile-cplus-types.c: Remove a comment by #include.
4430
4431 2019-01-22  Tom Tromey  <tom@tromey.com>
4432
4433         * compile/gcc-c-plugin.h: Include compile-internal.h.
4434
4435 2019-01-22  Tom Tromey  <tom@tromey.com>
4436
4437         * stabsread.c (EXTERN): Do not define.
4438         (symnum, next_symbol_text_func, processing_gcc_compilation)
4439         (within_function, global_sym_chain, global_stabs)
4440         (previous_stab_code, this_object_header_files)
4441         (n_this_object_header_files)
4442         (n_allocated_this_object_header_files): Define.
4443         * stabsread.h (EXTERN): Never define.  Use "extern".
4444
4445 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4446
4447         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
4448         history_value.
4449
4450 2019-01-21  Tom Tromey  <tom@tromey.com>
4451
4452         * ui-out.c: Fix includes.
4453         * tui/tui-source.c: Fix includes.
4454         * target.c: Fix includes.
4455         * remote.c: Fix includes.
4456         * regcache.c: Fix includes.
4457         * python/py-block.c: Fix includes.
4458         * printcmd.c: Fix includes.
4459         * or1k-tdep.c: Fix includes.
4460         * mi/mi-main.c: Fix includes.
4461         * m32r-tdep.c: Fix includes.
4462         * csky-tdep.c: Fix includes.
4463         * compile/compile-cplus-types.c: Fix includes.
4464         * cli/cli-interp.c: Fix includes.
4465
4466 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
4467
4468         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4469         for padding.
4470
4471 2019-01-16  Tom Tromey  <tom@tromey.com>
4472
4473         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
4474         earlier.
4475         (struct objfile) <msymbols_range>: Move from top level.
4476         <msymbols>: New method.
4477         (class objfile_msymbols): Remove.
4478         * symtab.c (default_collect_symbol_completion_matches_break_on):
4479         Update.
4480         * symmisc.c (dump_msymbols): Update.
4481         * stabsread.c (scan_file_globals): Update.
4482         * objc-lang.c (info_selectors_command, info_classes_command)
4483         (find_methods): Update.
4484         * minsyms.c (find_solib_trampoline_target): Update.
4485         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
4486         * coffread.c (coff_symfile_read): Update.
4487         * ada-lang.c (ada_lookup_simple_minsym)
4488         (ada_collect_symbol_completion_matches): Update.
4489
4490 2019-01-16  Tom Tromey  <tom@tromey.com>
4491
4492         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
4493         type.  Remove no-argument constructor.
4494         <iterator::operator++>: Simplify.
4495         <begin>: Update.
4496         <end>: Use minimal_symbol_count.
4497
4498 2019-01-16  Tom Tromey  <tom@tromey.com>
4499
4500         * objfiles.h (struct objfile) <psymtabs>: New method.
4501         (class objfile_psymtabs): Remove.
4502         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
4503         typedef.
4504         <range>: New method.
4505         (require_partial_symbols): Change return type.
4506         * psymtab.c (require_partial_symbols)
4507         (psym_expand_symtabs_matching): Update.
4508         * mdebugread.c (parse_partial_symbols): Update.
4509         * dbxread.c (dbx_end_psymtab): Update.
4510
4511 2019-01-15  Tom Tromey  <tom@tromey.com>
4512
4513         * symtab.c (lookup_objfile_from_block)
4514         (lookup_symbol_in_objfile_symtabs)
4515         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
4516         (find_line_symtab, info_sources_command)
4517         (default_collect_symbol_completion_matches_break_on)
4518         (make_source_files_completion_list): Update.
4519         * symmisc.c (print_objfile_statistics, dump_objfile)
4520         (maintenance_print_symbols, maintenance_info_symtabs)
4521         (maintenance_check_symtabs, maintenance_info_line_tables):
4522         Update.
4523         * source.c (select_source_symtab)
4524         (forget_cached_source_info_for_objfile): Update.
4525         * objfiles.h (class objfile_compunits): Remove.
4526         (struct objfile) <compunits_range>: New typedef.
4527         (compunits): New method.
4528         * objfiles.c (objfile_relocate1): Update.
4529         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4530         * maint.c (count_symtabs_and_blocks): Update.
4531         * linespec.c (iterate_over_all_matching_symtabs): Update.
4532         * cp-support.c (add_symbol_overload_list_qualified): Update.
4533         * coffread.c (coff_symtab_read): Update.
4534         * ada-lang.c (add_nonlocal_symbols)
4535         (ada_collect_symbol_completion_matches)
4536         (ada_add_global_exceptions): Update.
4537
4538 2019-01-15  Tom Tromey  <tom@tromey.com>
4539
4540         * progspace.h (program_space) <objfiles_safe_range>: New
4541         typedef.
4542         <objfiles_safe>: New method.
4543         * objfiles.h (class all_objfiles_safe): Remove.
4544         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
4545         * jit.c (jit_inferior_exit_hook): Update.
4546
4547 2019-01-17  Tom Tromey  <tom@tromey.com>
4548
4549         * progspace.h (program_space) <objfiles_range>: New typedef.
4550         <objfiles>: New method.
4551         <objfiles_head>: Rename from objfiles.
4552         (object_files): Update.
4553         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
4554         * guile/scm-pretty-print.c
4555         (ppscm_find_pretty_printer_from_objfiles): Update.
4556         * guile/scm-objfile.c (gdbscm_objfiles): Update.
4557         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
4558         Update.
4559         * python/py-progspace.c (pspy_get_objfiles): Update.
4560         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
4561         Update.
4562         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
4563         (objfpy_lookup_objfile_by_build_id): Update.
4564         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4565         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
4566         Update.
4567         * symtab.c (iterate_over_symtabs, matching_obj_sections)
4568         (expand_symtab_containing_pc, lookup_objfile_from_block)
4569         (lookup_static_symbol, basic_lookup_transparent_type)
4570         (find_pc_sect_compunit_symtab, find_symbol_at_address)
4571         (find_line_symtab, info_sources_command)
4572         (default_collect_symbol_completion_matches_break_on)
4573         (make_source_files_completion_list, find_main_name): Update.
4574         * symmisc.c (print_symbol_bcache_statistics)
4575         (print_objfile_statistics, maintenance_print_symbols)
4576         (maintenance_print_msymbols, maintenance_print_objfiles)
4577         (maintenance_info_symtabs, maintenance_check_symtabs)
4578         (maintenance_expand_symtabs, maintenance_info_line_tables):
4579         Update.
4580         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
4581         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
4582         (map_overlay_command, unmap_overlay_command)
4583         (simple_overlay_update, expand_symtabs_matching)
4584         (map_symbol_filenames): Update.
4585         * symfile-debug.c (set_debug_symfile): Update.
4586         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
4587         Update.
4588         * source.c (select_source_symtab, forget_cached_source_info):
4589         Update.
4590         * solib.c (solib_read_symbols): Update.
4591         * solib-spu.c (append_ocl_sos): Update.
4592         * psymtab.c (maintenance_print_psymbols)
4593         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
4594         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
4595         * printcmd.c (info_symbol_command): Update.
4596         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
4597         Update.
4598         * objfiles.h (class all_objfiles): Remove.
4599         * objfiles.c (have_partial_symbols, have_full_symbols)
4600         (have_minimal_symbols, qsort_cmp, update_section_map)
4601         (shared_objfile_contains_address_p)
4602         (default_iterate_over_objfiles_in_search_order): Update.
4603         * objc-lang.c (info_selectors_command, info_classes_command)
4604         (find_methods): Update.
4605         * minsyms.c (find_solib_trampoline_target): Update.
4606         * maint.c (maintenance_info_sections)
4607         (maintenance_translate_address, count_symtabs_and_blocks):
4608         Update.
4609         * main.c (captured_main_1): Update.
4610         * linux-thread-db.c (try_thread_db_load_from_pdir)
4611         (has_libpthread): Update.
4612         * linespec.c (iterate_over_all_matching_symtabs)
4613         (search_minsyms_for_name): Update.
4614         * jit.c (jit_find_objf_with_entry_addr): Update.
4615         * hppa-tdep.c (find_unwind_entry)
4616         (hppa_lookup_stub_minimal_symbol): Update.
4617         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
4618         Update.
4619         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
4620         (elf_gnu_ifunc_resolve_by_got): Update.
4621         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
4622         * dwarf-index-write.c (save_gdb_index_command): Update.
4623         * cp-support.c (add_symbol_overload_list_qualified): Update.
4624         * breakpoint.c (create_overlay_event_breakpoint)
4625         (create_longjmp_master_breakpoint)
4626         (create_std_terminate_master_breakpoint)
4627         (create_exception_master_breakpoint): Update.
4628         * blockframe.c (find_pc_partial_function): Update.
4629         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
4630         (ada_collect_symbol_completion_matches)
4631         (ada_add_global_exceptions): Update.
4632
4633 2019-01-17  Tom Tromey  <tom@tromey.com>
4634
4635         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
4636         declare VEC.
4637         (solib_target_parse_libraries): Change return type.
4638         (library_list_start_segment, library_list_start_section)
4639         (library_list_end_library, library_list_start_library); Update.
4640         (solib_target_free_library_list): Remove.
4641         (solib_target_parse_libraries): Remove cleanup.  Change return
4642         type.
4643         (solib_target_current_sos): Update.
4644
4645 2019-01-17  Tom Tromey  <tromey@bapiya>
4646
4647         * valprint.c: Replace "the the" with "the".
4648         * symtab.c: Replace "the the" with "the".
4649         * solib.c: Replace "the the" with "the".
4650         * solib-dsbt.c: Replace "the the" with "the".
4651         * linespec.c: Replace "the the" with "the".
4652         * dwarf2loc.h: Replace "the the" with "the".
4653         * amd64-windows-tdep.c: Replace "the the" with "the".
4654         * aarch64-tdep.c: Replace "the the" with "the".
4655
4656 2019-01-16  Keith Seitz  <keiths@redhat.com>
4657
4658         PR gdb/23773
4659         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
4660         <builder>: Rename to ..
4661         <m_builder>: ... this and make private.
4662         (dwarf2_cu::get_builder): New method.  Change all users of
4663         `builder' to use this method.
4664         (dwarf2_start_symtab): Move to ...
4665         (dwarf2_cu::start_symtab): ... here.  Update all callers
4666         (setup_type_unit_groups): Move to ...
4667         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
4668         callers.
4669         (dwarf2_cu::reset_builder): New method.
4670         (process_full_compunit, process_full_type_unit): Use
4671         dwarf2_cu::reset_builder.
4672         (follow_die_offset): Record the ancestor CU if it is different
4673         from the followed DIE's CU.
4674         (follow_die_sig_1): Likewise.
4675
4676 2019-01-15  Tom Tromey  <tom@tromey.com>
4677
4678         * remote.c (class remote_state) <buf>: Now a char_vector.
4679         <buf_size>: Remove.
4680         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
4681         parameter.
4682         (remote_target::getpkt_or_notif_sane_1)
4683         (remote_target::getpkt_sane)
4684         (remote_target::getpkt_or_notif_sane): Likewise.
4685         (class remote_target) <putpkt>: New overload.
4686         (remote_target::read_frame): Change type of "buf_p".  Remove
4687         sizeof_p parameter.
4688         (packet_ok): New overload.
4689         (packet_check_result): New overload.
4690         Update all uses.
4691
4692 2019-01-14  Tom Tromey  <tom@tromey.com>
4693
4694         * remote-notif.c (handle_notification, remote_notif_ack)
4695         (remote_notif_parse): Make "buf" const.
4696         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
4697         const.
4698         (remote_notif_parse, remote_notif_ack, handle_notification):
4699         Likewise.
4700         * remote.c (remote_notif_stop_parse): Make "buf" const.
4701         (remote_target::remote_parse_stop_reply): Make "buf" const.
4702         (remote_notif_stop_ack): Make "buf" const.
4703
4704 2019-01-14  Tom Tromey  <tom@tromey.com>
4705
4706         * remote.c (remote_console_output): Make parameter const.
4707
4708 2019-01-14  Tom Tromey  <tom@tromey.com>
4709
4710         * target-debug.h (target_debug_print_signals): Constify.
4711         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
4712         * procfs.c (procfs_target::pass_signals): Update.
4713         * linux-nat.c (linux_nat_target::pass_signals): Update.
4714         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
4715         * target-delegates.c: Rebuild.
4716         * remote.c (remote_target::program_signals): Update.
4717         (remote_target::pass_signals): Update.
4718         * target.c (target_pass_signals): Constify argument.
4719         (target_program_signals): Likewise.
4720         * target.h (struct target_ops) <pass_signals, program_signals>:
4721         Constify argument.
4722         (target_pass_signals, target_program_signals): Constify argument.
4723
4724 2019-01-14  Tom Tromey  <tom@tromey.com>
4725
4726         PR tui/28819:
4727         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
4728
4729 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
4730
4731         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
4732         field.
4733         * rs6000-tdep.c: Include reggroups.h.
4734         (IS_V_ALIAS_PSEUDOREG): Define.
4735         (rs6000_register_name): Return names for the "vX" aliases.
4736         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
4737         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
4738         aliases.  Call default_register_reggroup_p for all other
4739         pseudo-registers.
4740         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
4741         New functions.
4742         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
4743         Handle "vX" aliases.
4744         (v_alias_pseudo_register_collect): New function.
4745         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
4746         (rs6000_gdbarch_init): Initialize "vX" aliases as
4747         pseudo-registers.  Restore registration of
4748         rs6000_pseudo_register_reggroup_p with
4749         set_tdesc_pseudo_register_reggroup_p.
4750
4751 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
4752
4753         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
4754         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
4755         set_gdbarch_num_pseudo_regs.
4756
4757 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4758
4759         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
4760         Remove arg prefixname, add do_set and do_show.
4761         Add member functions set_list and show_list.
4762         * cli/cli-style.c (class cli_style_option): Update accordingly.
4763         (style_set_list): Move to file scope.
4764         (style_show_list): Likewise.
4765         (set_style): Call help_list.
4766         (show_style): Call cmd_show_list.
4767         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
4768         Update to use the new macro.
4769
4770 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
4771
4772         * ada-lang.c (_initialize_ada_language): Expand the help text
4773         for the "catch exception" command.
4774
4775 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4776
4777         * symtab.c (matching_obj_sections): Initialize obj,
4778         declare it closer to its usage.
4779
4780 2019-01-10  Tom Tromey  <tom@tromey.com>
4781
4782         * thread-iter.h (inf_threads_iterator): Use next_iterator.
4783         (basic_inf_threads_range): Remove.
4784         (inf_threads_range, inf_non_exited_threads_range)
4785         (safe_inf_threads_range): Use next_adapter.
4786
4787 2019-01-10  Keith Seitz  <keiths@redhat.com>
4788
4789         PR gdb/23712
4790         PR symtab/23010
4791         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
4792         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
4793
4794 2019-01-10  Keith Seitz  <keiths@redhat.com>
4795
4796         PR gdb/23712
4797         PR symtab/23010
4798         * dictionary.c (pending_to_vector): Remove.
4799         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4800         Remove _1 suffix, replacing functions of the same name.  Update
4801         all callers.
4802         (dict_create_hashed, dict_create_hashed_expandable)
4803         (dict_create_linear, dict_create_linear_expandable, dict_free)
4804         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
4805         Make functions static.
4806
4807 2019-01-10  Keith Seitz  <keiths@redhat.com>
4808
4809         PR gdb/23712
4810         PR symtab/23010
4811         * dictionary.h (struct dictionary): Replace declaration with
4812         multidictionary.
4813         (dict_create_hashed, dict_create_hashed_expandable)
4814         (dict_create_linear, dict_create_linear_expandable)
4815         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
4816         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
4817         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
4818         taking multidictionary argument.
4819         [ALL_DICT_SYMBOLS]: Update for multidictionary.
4820         * block.h (struct block) <dict>: Change to multidictionary
4821         and rename `multidict'.
4822         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
4823         symmisc.c: Update all dictionary references to multidictionary.
4824
4825 2019-01-10  Keith Seitz  <keiths@redhat.com>
4826
4827         PR gdb/23712
4828         PR symtab/23010
4829         * dictionary.c: Include unordered_map.
4830         (pending_to_vector): New function.
4831         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4832         Rewrite the non-"_1" functions to take vector instead
4833         of linked list.
4834         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
4835         "new" _1 versions of the same name.
4836         (multidictionary): Define.
4837         (std::hash<enum language): New definition.
4838         (collate_pending_symbols_by_language, mdict_create_hashed)
4839         (mdict_create_hashed_expandable, mdict_create_linear)
4840         (mdict_create_linear_expandable, mdict_free)
4841         (find_language_dictionary, create_new_language_dictionary)
4842         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
4843         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
4844         (mdict_size, mdict_empty): New functions.
4845         * dictionary.h (mdict_iterator): Define.
4846
4847 2019-01-10  Pedro Alves  <palves@redhat.com>
4848
4849         * breakpoint.c (read_uploaded_action)
4850         (create_tracepoint_from_upload): Adjust to use
4851         gdb::unique_xmalloc_ptr.
4852         * ctf.c (ctf_write_uploaded_tp):
4853         (SET_ARRAY_FIELD): Use emplace_back.
4854         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
4855         * tracefile-tfile.c (tfile_write_uploaded_tp):
4856         * tracepoint.c (parse_tracepoint_definition): Adjust to use
4857         gdb::unique_xmalloc_ptr.
4858         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
4859         at_string, cond_string, cmd_strings>: Replace char pointers
4860         with gdb::unique_xmalloc_ptr.
4861
4862 2019-01-10  Pedro Alves  <palves@redhat.com>
4863
4864         * solib-target.c (library_list_start_library): Don't xstrdup name.
4865
4866 2019-01-10  Pedro Alves  <palves@redhat.com>
4867
4868         * mdebugread.c (parse_partial_symbols): Use
4869         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
4870
4871 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4872
4873         * linux-fork.c (scoped_switch_fork_info)
4874         <~scoped_switch_fork_info>: Fix incorrect variable name.
4875
4876 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4877
4878         * linux-fork.c (scoped_switch_fork_info)
4879         <scoped_switch_fork_info>: Make explicit.
4880         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
4881
4882 2019-01-10  Tom Tromey  <tom@tromey.com>
4883
4884         * objfiles.h (objfile::reset_psymtabs): Update.
4885         * objfiles.c (objfile::objfile): Update.
4886         * psymtab.h (psymtab_storage::obstack): Update.
4887         (psymtab_storage::m_obstack): Use gdb::optional.
4888         (class psymtab_storage): Update comment.  Remove objfile
4889         parameter.
4890         * psymtab.c (psymtab_storage::psymtab_storage): Update.
4891
4892 2019-01-10  Tom Tromey  <tom@tromey.com>
4893
4894         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
4895         <free_psymtabs>: Now private.
4896         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
4897         (allocate_psymtab): Use new method.
4898
4899 2019-01-10  Tom Tromey  <tom@tromey.com>
4900
4901         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
4902         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
4903         * mdebugread.c (parse_partial_symbols): Use
4904         allocate_dependencies.
4905         * dwarf2read.c (dwarf2_create_include_psymtab): Use
4906         allocate_dependencies.
4907         (process_psymtab_comp_unit_reader)
4908         (build_type_psymtab_dependencies): Likewise.
4909         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
4910
4911 2019-01-10  Tom Tromey  <tom@tromey.com>
4912
4913         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
4914         PSYMBOL_SET_LANGUAGE.
4915         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
4916
4917 2019-01-10  Tom Tromey  <tom@tromey.com>
4918
4919         * psymtab.h (psymtab_storage::obstack): New method.
4920         <m_obstack>: Rename from obstack; now private.
4921         * psymtab.c (psymtab_storage): Update.
4922         * dwarf2read.c (create_addrmap_from_index)
4923         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
4924         Update.
4925
4926 2019-01-10  Tom Tromey  <tom@tromey.com>
4927
4928         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
4929         * objfiles.h (objfile::reset_psymtabs): New method.
4930
4931 2019-01-10  Tom Tromey  <tom@tromey.com>
4932
4933         * symmisc.c (print_symbol_bcache_statistics): Update.
4934         (print_objfile_statistics): Update.
4935         * symfile.c (reread_symbols): Update.
4936         * psymtab.h (class psymtab_storage): New.
4937         * psymtab.c (psymtab_storage): New constructor.
4938         (~psymtab_storage): New destructor.
4939         (require_partial_symbols): Update.
4940         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
4941         (find_pc_sect_psymtab, find_pc_sect_psymbol)
4942         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
4943         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
4944         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
4945         (start_psymtab_common, end_psymtab_common)
4946         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
4947         (allocate_psymtab): Update.
4948         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
4949         Update.
4950         (dump_psymtab_addrmap, maintenance_print_psymbols)
4951         (maintenance_check_psymtabs): Update.
4952         (class objfile_psymtabs): Move to objfiles.h.
4953         * psympriv.h (discard_psymtab): Now inline.
4954         (psymtab_discarder::psymtab_discarder): Update.
4955         (psymtab_discarder::~psymtab_discarder): Update.
4956         (ALL_OBJFILE_PSYMTABS): Rewrite.
4957         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
4958         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
4959         Remove fields.
4960         <partial_symtabs>: New field.
4961         (class objfile_psymtabs): Move from psymtab.h.  Update.
4962         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
4963         psymbol_cache.
4964         (objfile::~objfile): Don't destroy psymbol_cache.
4965         * mdebugread.c (parse_partial_symbols): Update.
4966         * dwarf2read.c (create_addrmap_from_index)
4967         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
4968         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
4969         (add_partial_subprogram, dwarf2_ranges_read): Update.
4970         * dwarf-index-write.c (write_address_map)
4971         (write_one_signatured_type, recursively_write_psymbols)
4972         (class debug_names, class debug_names, write_psymtabs_to_index):
4973         Update.
4974
4975 2019-01-10  Tom Tromey  <tom@tromey.com>
4976
4977         * symtab.h (SYMBOL_SET_NAMES): Update.
4978         (symbol_set_names): Update.
4979         (MSYMBOL_SET_NAMES): Update.
4980         * symtab.c (symbol_set_names): Change argument to be an
4981         objfile_per_bfd_storage.
4982         * psymtab.c (add_psymbol_to_bcache): Update.
4983         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
4984
4985 2019-01-10  Tom Tromey  <tom@tromey.com>
4986
4987         * symtab.c (create_demangled_names_hash): Change argument to be an
4988         objfile_per_bfd_storage.
4989         (symbol_set_names): Update.
4990
4991 2019-01-10  Tom Tromey  <tom@tromey.com>
4992
4993         * xcoffread.c (xcoff_initial_scan): Unconditionally call
4994         init_psymbol_list.
4995         * psymtab.c (init_psymbol_list): Do nothing if already called.
4996         * psympriv.h (init_psymbol_list): Add comment.
4997         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
4998         init_psymbol_list.
4999         * dbxread.c (dbx_symfile_read): Unconditionally call
5000         init_psymbol_list.
5001
5002 2019-01-10  Tom Tromey  <tom@tromey.com>
5003
5004         * xcoffread.c (scan_xcoff_symtab): Update.
5005         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
5006         "where".
5007         * mdebugread.c (parse_partial_symbols)
5008         (handle_psymbol_enumerators): Update.
5009         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
5010         * dbxread.c (read_dbx_symtab): Update.
5011         * psympriv.h (psymbol_placement): New enum.
5012         (add_psymbol_to_list): Update.
5013
5014 2019-01-10  Tom Tromey  <tom@tromey.com>
5015
5016         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
5017         static_psymbols parameters.
5018         (scan_xcoff_symtab): Update.
5019         * psymtab.c (start_psymtab_common): Remove global_psymbols and
5020         static_psymbols parameters.
5021         * psympriv.h (start_psymtab_common): Update.
5022         * mdebugread.c (parse_partial_symbols): Update.
5023         * dwarf2read.c (create_partial_symtab): Update.
5024         * dbxread.c (read_dbx_symtab): Update.
5025         (start_psymtab): Remove global_psymbols and static_psymbols
5026         parameters.
5027
5028 2019-01-10  Tom Tromey  <tom@tromey.com>
5029
5030         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
5031         * psymtab.c (allocate_psymtab): Add comment.
5032         * psympriv.h (allocate_psymtab): Add comment.
5033         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
5034         initializations.
5035         * dbxread.c (dbx_end_psymtab): Remove some initializations.
5036
5037 2019-01-10  Tom Tromey  <tom@tromey.com>
5038
5039         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5040         Don't declare.
5041         * mipsread.c: Include mdebugread.h.
5042         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5043         Declare.
5044         * elfread.c: Include mdebugread.h.
5045
5046 2019-01-09  Tom Tromey  <tom@tromey.com>
5047
5048         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
5049         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
5050         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
5051         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
5052         (psym_lookup_symbol, psym_find_last_source_symtab)
5053         (psym_forget_cached_source_info, psym_print_stats)
5054         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
5055         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
5056         (psym_map_matching_symbols, psym_expand_symtabs_matching)
5057         (psym_find_compunit_symtab_by_address)
5058         (maintenance_print_psymbols, maintenance_info_psymtabs)
5059         (maintenance_check_psymtabs): Use ranged for.
5060         * psymtab.h (class objfile_psymtabs): New.
5061         (require_partial_symbols): Return objfile_psymtabs.
5062         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
5063
5064 2019-01-09  Tom Tromey  <tom@tromey.com>
5065
5066         * symfile.c (overlay_invalidate_all, find_pc_overlay)
5067         (find_pc_mapped_section, list_overlays_command)
5068         (map_overlay_command, unmap_overlay_command)
5069         (simple_overlay_update): Use all_objfiles.
5070         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
5071         * printcmd.c (info_symbol_command): Use all_objfiles.
5072         * objfiles.h (ALL_OBJSECTIONS): Remove.
5073         * maint.c (maintenance_translate_address): Use all_objfiles.
5074         * gcore.c (gcore_create_callback): Use all_objfiles.
5075         (objfile_find_memory_regions): Likewise.
5076
5077 2019-01-09  Tom Tromey  <tom@tromey.com>
5078
5079         * symtab.c (find_line_symtab, info_sources_command)
5080         (make_source_files_completion_list): Use objfile_compunits.
5081         * source.c (select_source_symtab): Use objfile_compunits.
5082         * objfiles.h (struct objfile): Update comment.
5083         (ALL_OBJFILES): Remove.
5084         (ALL_FILETABS): Remove.
5085         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
5086         objfile_compunits.
5087
5088 2019-01-09  Tom Tromey  <tom@tromey.com>
5089
5090         * symmisc.c (print_objfile_statistics, dump_objfile)
5091         (maintenance_print_symbols): Use compunit_filetabs.
5092         * source.c (forget_cached_source_info_for_objfile): Use
5093         compunit_filetabs.
5094         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
5095         (ALL_FILETABS): Use compunit_filetabs.
5096         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
5097         * coffread.c (coff_symtab_read): Use compunit_filetabs.
5098
5099 2019-01-09  Tom Tromey  <tom@tromey.com>
5100
5101         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
5102         (compunit_filetabs): New.
5103         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
5104         compunit_filetabs.
5105         (info_sources_command, make_source_files_completion_list): Remove
5106         declaration.
5107         * symmisc.c (print_objfile_statistics, dump_objfile)
5108         (maintenance_print_symbols): Remove declaration.
5109         (maintenance_info_symtabs): Use compunit_filetabs.
5110         (maintenance_info_line_tables): Likewise.
5111         * source.c (select_source_symtab): Change local variable name.
5112         (forget_cached_source_info_for_objfile): Remove declaration.
5113         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
5114         * objfiles.c (objfile_relocate1): Remove declaration.
5115         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5116         declaration.
5117         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
5118         * coffread.c (coff_symtab_read): Remove declaration.
5119         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5120         compunit_filetabs.
5121
5122 2019-01-09  Tom Tromey  <tom@tromey.com>
5123
5124         * symtab.c (lookup_objfile_from_block)
5125         (find_pc_sect_compunit_symtab, search_symbols)
5126         (default_collect_symbol_completion_matches_break_on): Use
5127         objfile_compunits.
5128         * objfiles.h (ALL_COMPUNITS): Remove.
5129         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
5130         * cp-support.c (add_symbol_overload_list_qualified): Use
5131         objfile_compunits.
5132         * ada-lang.c (ada_collect_symbol_completion_matches)
5133         (ada_add_global_exceptions): Use objfile_compunits.
5134
5135 2019-01-09  Tom Tromey  <tom@tromey.com>
5136
5137         * source.c (select_source_symtab)
5138         (forget_cached_source_info_for_objfile): Remove declaration.
5139         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5140         declaration.
5141         * maint.c (count_symtabs_and_blocks): Remove declaration.
5142         * cp-support.c (add_symbol_overload_list_qualified): Remove
5143         declaration.
5144         * coffread.c (coff_symtab_read): Remove declaration.
5145         * symtab.c (lookup_symbol_in_objfile_symtabs)
5146         (basic_lookup_transparent_type_1): Use objfile_compunits.
5147         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
5148         (info_sources_command, search_symbols)
5149         (default_collect_symbol_completion_matches_break_on)
5150         (make_source_files_completion_list): Remove declaration.
5151         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
5152         (ada_collect_symbol_completion_matches)
5153         (ada_add_global_exceptions): Remove declaration.
5154         * linespec.c (iterate_over_all_matching_symtabs): Use
5155         objfile_compunits.
5156         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
5157         (class objfile_compunits): New.
5158         (ALL_COMPUNITS): Use objfile_compunits.
5159         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
5160         (maintenance_check_symtabs, maintenance_info_line_tables): Use
5161         objfile_compunits.
5162         * objfiles.c (objfile_relocate1): Use objfile_compunits.
5163
5164 2019-01-09  Tom Tromey  <tom@tromey.com>
5165
5166         * symtab.c (search_symbols)
5167         (default_collect_symbol_completion_matches_break_on): Use
5168         objfile_msymbols.
5169         * ada-lang.c (ada_lookup_simple_minsym)
5170         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
5171         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
5172         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
5173         objfile_msymbols.
5174         * coffread.c (coff_symfile_read): Use objfile_msymbols.
5175         * symmisc.c (dump_msymbols): Use objfile_msymbols.
5176         * objc-lang.c (find_methods): Use objfile_msymbols.
5177         (info_selectors_command, info_classes_command): Likewise.
5178         * stabsread.c (scan_file_globals): Use objfile_msymbols.
5179         * objfiles.h (class objfile_msymbols): New.
5180         (ALL_OBJFILE_MSYMBOLS): Remove.
5181         (ALL_MSYMBOLS): Remove.
5182
5183 2019-01-09  Tom Tromey  <tom@tromey.com>
5184
5185         * common/next-iterator.h (next_adapter): Add Iterator template
5186         parameter.
5187         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
5188         (class all_objfiles_safe): New.
5189         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
5190         * objfiles.c (put_objfile_before): Update comment.
5191         (add_separate_debug_objfile): Likewise.
5192         (free_all_objfiles): Use all_objfiles_safe.
5193         (objfile_purge_solibs): Likewise.
5194
5195 2019-01-09  Tom Tromey  <tom@tromey.com>
5196
5197         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5198         (expand_symtab_containing_pc, lookup_static_symbol)
5199         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
5200         (find_symbol_at_address, find_line_symtab, find_main_name): Use
5201         all_objfiles.
5202         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
5203         * breakpoint.c (create_overlay_event_breakpoint)
5204         (create_longjmp_master_breakpoint)
5205         (create_std_terminate_master_breakpoint)
5206         (create_exception_master_breakpoint): Use all_objfiles.
5207         * linux-thread-db.c (try_thread_db_load_from_pdir)
5208         (has_libpthread): Use all_objfiles.
5209         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
5210         * linespec.c (iterate_over_all_matching_symtabs)
5211         (search_minsyms_for_name): Use all_objfiles.
5212         * maint.c (maintenance_info_sections): Use all_objfiles.
5213         * main.c (captured_main_1): Use all_objfiles.
5214         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
5215         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
5216         * guile/scm-pretty-print.c
5217         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
5218         * solib-spu.c (append_ocl_sos): Use all_objfiles.
5219         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
5220         (maintenance_print_msymbols): Use all_objfiles.
5221         * source.c (select_source_symtab): Use all_objfiles.
5222         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
5223         * symfile.c (remove_symbol_file_command)
5224         (expand_symtabs_matching, map_symbol_filenames): Use
5225         all_objfiles.
5226         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
5227         all_objfiles.
5228         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
5229         * objc-lang.c (find_methods): Use all_objfiles.
5230         * objfiles.c (have_partial_symbols, have_full_symbols)
5231         (have_minimal_symbols, qsort_cmp)
5232         (default_iterate_over_objfiles_in_search_order): Use
5233         all_objfiles.
5234         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
5235         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
5236         (maintenance_check_psymtabs): Use all_objfiles.
5237         (ALL_PSYMTABS): Remove.
5238         * compile/compile-object-run.c (do_module_cleanup): Use
5239         all_objfiles.
5240         * blockframe.c (find_pc_partial_function): Use all_objfiles.
5241         * cp-support.c (add_symbol_overload_list_qualified): Use
5242         all_objfiles.
5243         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5244         Use all_objfiles.
5245         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
5246         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
5247         all_objfiles.
5248         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5249         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
5250         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5251         Uses all_objfiles.
5252         * solib.c (solib_read_symbols): Use all_objfiles
5253
5254 2019-01-09  Tom Tromey  <tom@tromey.com>
5255
5256         * probe.c (parse_probes_in_pspace): Use all_objfiles.
5257         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
5258         all_objfiles.
5259         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
5260         * symmisc.c (print_symbol_bcache_statistics)
5261         (print_objfile_statistics, maintenance_print_objfiles)
5262         (maintenance_info_symtabs, maintenance_check_symtabs)
5263         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
5264         all_objfiles.
5265         * source.c (forget_cached_source_info): Use all_objfiles.
5266         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
5267         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5268         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
5269         * objfiles.c (update_section_map): Use all_objfiles.
5270         (shared_objfile_contains_address_p): Likewise.
5271         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
5272         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
5273
5274 2019-01-09  Tom Tromey  <tom@tromey.com>
5275
5276         * common/next-iterator.h: New file.
5277         * objfiles.h (class all_objfiles): New.
5278         (struct objfile_iterator): New.
5279
5280 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5281
5282         * NEWS: Move the description of the changed "frame", "select-frame",
5283          and "info frame" commands to the Changed commands section.
5284
5285 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
5286
5287         * gdbtypes.c (check_stub_method_group): Remove handling of old
5288         mangling schemes.
5289         * linespec.c (find_methods): Likewise.
5290         * stabsread.c (read_member_functions): Likewise.
5291         * valops.c (search_struct_method): Likewise.
5292         (value_struct_elt_for_reference): Likewise.
5293         * NEWS: Mention this change.
5294
5295 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5296
5297         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
5298         print_source_lines.
5299         * source.c (print_source_lines_base): Update line number check.
5300         (print_source_lines): New function.
5301         (source_lines_range::source_lines_range): New function.
5302         * source.h (class source_lines_range): New class.
5303         (print_source_lines): New declaration.
5304
5305 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5306
5307         * linespec.c (linespec_state_destructor): Free self->canonical_names.
5308
5309 2019-01-08  Tom Tromey  <tom@tromey.com>
5310             Simon Marchi  <simon.marchi@ericsson.com>
5311
5312         PR gdb/24060
5313         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
5314         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
5315         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5316         * f-exp.y (DOLLAR_VARIABLE): Likewise.
5317         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
5318         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5319
5320 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5321
5322         * source.c (select_source_symtab): Move header comment to
5323         declaration in source.h.
5324         (forget_cached_source_info_for_objfile): Likewise.
5325         (forget_cached_source_info): Likewise.
5326         (identify_source_line): Likewise.
5327         * source.h (identify_source_line): Move declaration from symtab.h
5328         and add comment from source.c
5329         (print_source_lines): Likewise.
5330         (forget_cached_source_info_for_objfile): Likewise.
5331         (forget_cached_source_info): Likewise.
5332         (select_source_symtab): Likewise.
5333         (enum print_source_lines_flag): Move definition from symtab.h.
5334         * symtab.h (identify_source_line): Move declaration to source.h.
5335         (print_source_lines): Likewise.
5336         (forget_cached_source_info_for_objfile): Likewise.
5337         (forget_cached_source_info): Likewise.
5338         (select_source_symtab): Likewise.
5339         (enum print_source_lines_flag): Move definition to source.h.
5340         * tui/tui-hooks.c: Add 'source.h' include.
5341
5342 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5343
5344         * source.c (print_source_lines_base): Handle requests to print
5345         reverse line number sequences, and guard against empty lines
5346         string.
5347
5348 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5349
5350         * source.c (print_source_lines_base): Fix skip of '\r' if next
5351         character is '\n'.
5352
5353 2019-01-06  Tom Tromey  <tom@tromey.com>
5354
5355         * c-exp.y (struct c_parse_state) <macro_original_text,
5356         expansion_obstack>: New member.
5357         (macro_original_text, expansion_obstack): Remove globals.
5358         (scan_macro_expansion, scanning_macro_expansion)
5359         (finished_macro_expansion): Update.
5360         (scan_macro_cleanup): Remove.
5361         (yylex, c_parse): Update.
5362
5363 2019-01-06  Tom Tromey  <tom@tromey.com>
5364
5365         * c-exp.y (struct c_parse_state) <strings>: New member.
5366         (operator_stoken): Update.
5367
5368 2019-01-06  Tom Tromey  <tom@tromey.com>
5369
5370         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
5371         (union type_stack_elt) <typelist_val>: Now a pointer to
5372         std::vector.
5373         (type_stack_cleanup): Don't declare.
5374         (push_typelist): Update.
5375         * parse.c (pop_typelist): Return a std::vector.
5376         (push_typelist): Take a std::vector.
5377         (follow_types): Update.  Do not free args.
5378         (type_stack_cleanup): Remove.
5379         * c-exp.y (struct c_parse_state): New.
5380         (cpstate): New global.
5381         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
5382         (nonempty_typelist): Update.
5383         (func_mod): Create a new vector.
5384         (c_parse): Create a c_parse_state.
5385         (check_parameter_typelist): Do not delete params.
5386         (function_method): Update.  Do not delete type_list.
5387
5388 2019-01-06  Tom Tromey  <tom@tromey.com>
5389
5390         PR gdb/28155:
5391         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
5392         check_typedef.
5393         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
5394         (print_return_value): Likewise.
5395
5396 2019-01-05  Tom Tromey  <tom@tromey.com>
5397
5398         * contrib/cleanup_check.py: Remove.
5399         * contrib/gcc-with-excheck: Remove.
5400         * contrib/exsummary.py: Remove.
5401         * contrib/excheck.py: Remove.
5402
5403 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
5404
5405         * thread.c (delete_thread_1): Add gdb_assert that THR is not
5406         NULL. Initialize tpprev to NULL instead of assigning it
5407         to NULL on the next statement.
5408         * windows-nat.c (windows_delete_thread): Remove check for
5409         main_thread_id before printing thread exit notifications.
5410         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
5411         Remove thread ID check against main_thread_id.
5412         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
5413         windows_delete_thread.
5414         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
5415
5416 2019-01-04  Tom Tromey  <tom@tromey.com>
5417
5418         * compile/compile.c (_initialize_compile): Use upper case for
5419         metasyntactic variables.
5420         * symmisc.c (_initialize_symmisc): Use upper case for
5421         metasyntactic variables.
5422         * psymtab.c (_initialize_psymtab): Use upper case for
5423         metasyntactic variables.
5424         * demangle.c (demangle_command): Use upper case for metasyntactic
5425         variables.
5426         (_initialize_demangler): Likewise.
5427         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
5428         variables.
5429
5430 2019-01-03  Tom Tromey  <tom@tromey.com>
5431
5432         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
5433
5434 2019-01-03  Tom Tromey  <tom@tromey.com>
5435
5436         * python/py-symtab.c (salpy_str): Update.
5437         (struct salpy_sal_object) <symtab>: Now a PyObject.
5438         (salpy_dealloc): Update.
5439         (del_objfile_sal): Use gdbpy_ref.
5440
5441 2019-01-03  Tom Tromey  <tom@tromey.com>
5442
5443         * python/py-type.c (convert_field): Use new_reference.  Return
5444         gdbpy_ref.
5445         (make_fielditem): Return gdbpy_ref.
5446         (typy_fields): Update.
5447         (typy_getitem): Update.
5448         (field_name): Return gdbpy_ref.  Use new_reference.
5449         (typy_iterator_iternext): Update.
5450
5451 2019-01-03  Tom Tromey  <tom@tromey.com>
5452
5453         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
5454
5455 2019-01-03  Tom Tromey  <tom@tromey.com>
5456
5457         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
5458         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
5459         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
5460         (pspy_set_frame_filters, pspy_set_frame_unwinders)
5461         (pspy_set_type_printers): Likewise.
5462         * python/py-function.c (fnpy_init): Use gdbpy_ref.
5463         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
5464         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
5465         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
5466         (objfpy_set_type_printers): Likewise.
5467
5468 2019-01-03  Tom Tromey  <tom@tromey.com>
5469
5470         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
5471         (gdbpy_print_stack): Use gdbpy_err_fetch.
5472         * python/python-internal.h (class gdbpy_err_fetch): New class.
5473         (class gdbpy_enter) <m_error_type, m_error_value,
5474         m_error_traceback>: Remove.
5475         <m_error>: New member.
5476         (gdbpy_exception_to_string): Don't declare.
5477         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
5478         * python/py-value.c (convert_value_from_python): Use
5479         gdbpy_err_fetch.
5480         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
5481         gdbpy_exception_to_string.
5482         (gdbpy_handle_exception): Use gdbpy_err_fetch.
5483         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
5484         gdbpy_err_fetch.
5485
5486 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5487
5488         * linux-nat.c (delete_lwp_cleanup): Delete.
5489         (struct lwp_deleter): New struct.
5490         (lwp_info_up): New typedef.
5491         (linux_nat_target::follow_fork): Delete cleanup, and make use of
5492         lwp_info_up.
5493
5494 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5495
5496         * linux-fork.c (class scoped_switch_fork_info): New class.
5497         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
5498
5499 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5500
5501         * valops.c (find_overload_match): Remove use of null_cleanup, and
5502         calls to do_cleanups.
5503
5504 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5505
5506         * compile/compile-cplus-types.c
5507         (compile_cplus_instance::decl_name): Handle changes to
5508         cp_func_name.
5509         * cp-support.c (cp_func_name): Update header comment, update
5510         return type.
5511         * cp-support.h (cp_func_name): Update return type in declaration.
5512         * valops.c (find_overload_match): Move temp_func local to top
5513         level of function and change its type.  Use temp_func to hold and
5514         delete temporary string obtained from cp_func_name.
5515
5516 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5517
5518         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
5519         gdb::char_vector, remove cleanup, and update uses of `msg`.
5520
5521 2019-01-03  Jim Wilson  <jimw@sifive.com>
5522
5523         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
5524
5525 2019-01-02  Tom Tromey  <tom@tromey.com>
5526
5527         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
5528         (tdesc_parse_xml): Remove cleanups.
5529         * target-descriptions.h (make_cleanup_free_target_description):
5530         Don't declare.
5531         (target_desc_deleter): New struct.
5532         (target_desc_up): New typedef.
5533         * target-descriptions.c (target_desc_deleter::operator()): Rename
5534         from free_target_description.
5535         (make_cleanup_free_target_description): Remove.
5536
5537 2019-01-02  Tom Tromey  <tom@tromey.com>
5538
5539         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
5540         constructor, destructor.
5541         (linespec_parser): Remove typedef.
5542         (~linespec_parser): Rename from linespec_parser_delete.
5543         (linespec_lex_to_end, linespec_complete_label)
5544         (linespec_complete): Update.
5545         (decode_line_full): Remove cleanups.
5546         (decode_line_1): Update.
5547
5548 2019-01-02  Tom Tromey  <tom@tromey.com>
5549
5550         * python/python-internal.h (inferior_to_inferior_object): Change
5551         return type.
5552         * python/py-exitedevent.c (create_exited_event_object): Update.
5553         * python/py-inferior.c (inferior_to_inferior_object): Return
5554         gdbpy_ref.
5555         (python_new_inferior, python_inferior_deleted)
5556         (thread_to_thread_object, delete_thread_object)
5557         (build_inferior_list, gdbpy_selected_inferior): Update.
5558         * python/py-infthread.c (create_thread_object): Update.  Also fail
5559         if inferior_to_inferior_object fails.
5560
5561 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
5562
5563         * inferior.h (class inferior) <displaced_step_state>: New field.
5564         * infrun.h (struct displaced_step_state): Move here from
5565         infrun.c.  Initialize fields, add constructor.
5566         <inf>: Remove field.
5567         <reset>: New method.
5568         * infrun.c (struct displaced_step_inferior_state): Move to
5569         infrun.h.
5570         (displaced_step_inferior_states): Remove.
5571         (get_displaced_stepping_state): Adust.
5572         (displaced_step_in_progress_any_inferior): Adjust.
5573         (displaced_step_in_progress_thread): Adjust.
5574         (displaced_step_in_progress): Adjust.
5575         (add_displaced_stepping_state): Remove.
5576         (get_displaced_step_closure_by_addr): Adjust.
5577         (remove_displaced_stepping_state): Remove.
5578         (infrun_inferior_exit): Call displaced_step_state.reset.
5579         (use_displaced_stepping): Don't check for NULL.
5580         (displaced_step_prepare_throw): Call
5581         get_displaced_stepping_state.
5582         (displaced_step_fixup): Don't check for NULL.
5583         (prepare_for_detach): Don't check for NULL.
5584
5585 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5586
5587         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
5588          in case of call that did not complete.
5589
5590 2019-01-02  Andrey Utkin  <autkin@undo.io>
5591
5592         * symfile.c (find_separate_debug_file): Fix search of debug files for
5593         remote debuggee.
5594
5595 2019-01-02  Tom Tromey  <tom@tromey.com>
5596
5597         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
5598         indentation.
5599         * python/py-frame.c (frapy_older): Remove cast.
5600         (frapy_newer): Likewise.
5601         * python/py-breakpoint.c (local_setattro): Remove cast.
5602         * python/py-arch.c (archpy_name): Remove local variable.
5603         * python/py-type.c (gdbpy_lookup_type): Remove cast.
5604
5605 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
5606
5607         * unittests/basic_string_view/element_access/char/empty.cc:
5608         Fix year range in copyright header.
5609
5610 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5611
5612         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
5613         Delete.
5614         <operator==>: Update with for removed field.
5615         <hash>: Likewise.
5616         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
5617         <isa_features>: ...this.
5618         <abi_features>: New field.
5619         (riscv_isa_flen): Update comment.
5620         (riscv_abi_xlen): New declaration.
5621         (riscv_abi_flen): New declaration.
5622         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
5623         isa_features.
5624         (riscv_abi_xlen): New function.
5625         (riscv_isa_flen): Update to get answer from isa_features.
5626         (riscv_abi_flen): New function.
5627         (riscv_has_fp_abi): Update to get answer from abi_features.
5628         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
5629         xlen and flen.
5630         (riscv_call_info) <xlen, flen>: Update comment.
5631         (riscv_call_arg_struct): Remove invalid assertions
5632         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
5633         is removed.
5634         (riscv_gdbarch_init): Gather isa features and abi features
5635         separately, ensure both match on the gdbarch when reusing an old
5636         gdbarch.  Relax an error check to allow 32-bit abi float to run on
5637         a target with 64-bit float hardware.
5638
5639 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5640
5641         * source.c (search_command_helper): Stop reverse search
5642         when line 1 has been searched.
5643
5644 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5645
5646         * record-full.c (record_full_base_target::close): Rewrite
5647         record_full_core_buf_list free logic.
5648
5649 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5650
5651         * break-catch-syscall.c (print_one_catch_syscall): xfree
5652         the last text.
5653
5654 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5655
5656         * top.c (print_gdb_version): Update Copyright year in version
5657         message.
5658
5659 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5660
5661         Update copyright year range in all GDB files.
5662
5663 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
5664
5665         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
5666
5667 For older changes see ChangeLog-2018.
5668 \f
5669 Local Variables:
5670 mode: change-log
5671 left-margin: 8
5672 fill-column: 74
5673 version-control: never
5674 coding: utf-8
5675 End:
5676