gdb/ChangeLog

   1 2019-02-17  Tom Tromey  <tom@tromey.com>
   2
   3         * macrotab.h (macro_source_fullname): Return a std::string.
   4         * macrotab.c (macro_include, check_for_redefinition)
   5         (macro_undef, macro_lookup_definition, foreach_macro)
   6         (foreach_macro_in_scope): Update.
   7         (macro_source_fullname): Return a std::string.
   8         * macrocmd.c (show_pp_source_pos): Update.
   9
  10 2019-02-17  Tom Tromey  <tom@tromey.com>
  11
  12         * macrocmd.c (show_pp_source_pos): Style the file names.
  13
  14 2019-02-17  Tom Tromey  <tom@tromey.com>
  15
  16         PR tui/24197:
  17         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
  18
  19 2019-02-17  Tom Tromey  <tom@tromey.com>
  20
  21         * ada-lang.c (user_select_syms): Use filtered printing.
  22         * utils.c (wrap_style): New global.
  23         (desired_style): Remove.
  24         (emit_style_escape): Add stream parameter.
  25         (set_output_style, reset_terminal_style, prompt_for_continue):
  26         Update.
  27         (flush_wrap_buffer): Only flush gdb_stdout.
  28         (wrap_here): Set wrap_style.
  29         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
  30         treat escape sequences as a character.  Change when wrap buffer is
  31         flushed.
  32         (fputs_styled): Do not set the output style when the default is
  33         requested.
  34         * ui-style.h (struct ui_file_style) <is_default>: New method.
  35         * source.c (print_source_lines_base): Emit escape sequences in one
  36         piece.
  37
  38 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
  39
  40         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
  41         integers and enumeration types.
  42
  43 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
  44
  45         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
  46         instead of lookup_symbol_in_language
  47         (do_exact_match): New function.
  48         (ada_get_symbol_name_matcher): Return do_exact_match when
  49         doing a verbatim match.
  50
  51 2019-02-15  Tom Tromey  <tromey@adacore.com>
  52
  53         * ravenscar-thread.c (ravenscar_thread_target::resume)
  54         (ravenscar_thread_target::wait): Special case wildcard requests.
  55
  56 2019-02-15  Tom Tromey  <tromey@adacore.com>
  57
  58         * ravenscar-thread.c (base_ptid): Remove.
  59         (struct ravenscar_thread_target) <close>: New method.
  60         <m_base_ptid>: New member.
  61         <update_inferior_ptid, active_task, task_is_currently_active,
  62         runtime_initialized>: Declare methods.
  63         <ravenscar_thread_target>: Add constructor.
  64         (ravenscar_thread_target::task_is_currently_active)
  65         (ravenscar_thread_target::update_inferior_ptid)
  66         (ravenscar_runtime_initialized): Rename.  Now methods.
  67         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
  68         (ravenscar_thread_target::update_thread_list): Update.
  69         (ravenscar_thread_target::active_task): Now method.
  70         (ravenscar_thread_target::store_registers)
  71         (ravenscar_thread_target::prepare_to_store)
  72         (ravenscar_thread_target::prepare_to_store)
  73         (ravenscar_thread_target::mourn_inferior): Update.
  74         (ravenscar_inferior_created): Use "new" to create target.
  75         (ravenscar_thread_target::get_ada_task_ptid): Update.
  76         (_initialize_ravenscar): Don't initialize base_ptid.
  77         (ravenscar_ops): Remove global.
  78
  79 2019-02-15  Tom Tromey  <tromey@adacore.com>
  80
  81         * target.h (push_target): Declare new overload.
  82         * target.c (push_target): New overload, taking an rvalue reference.
  83         * remote.c (remote_target::open_1): Use push_target overload.
  84         * corelow.c (core_target_open): Use push_target overload.
  85
  86 2019-02-15  Tom Tromey  <tromey@adacore.com>
  87
  88         * ravenscar-thread.c (is_ravenscar_task)
  89         (ravenscar_task_is_currently_active): Return bool.
  90         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
  91         (_initialize_ravenscar): Remove "(void)".
  92         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
  93         Return bool.
  94
  95 2019-02-15  Tom Tromey  <tromey@adacore.com>
  96
  97         * ravenscar-thread.c (ravenscar_runtime_initializer)
  98         (has_ravenscar_runtime, get_running_thread_id)
  99         (ravenscar_thread_target::resume): Fix indentation.
 100
 101 2019-02-15  Tom Tromey  <tromey@adacore.com>
 102
 103         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
 104         from ravenscar_arch_ops.
 105         (sparc_ravenscar_ops::fetch_registers)
 106         (sparc_ravenscar_ops::store_registers): Now methods.
 107         (sparc_ravenscar_prepare_to_store): Remove.
 108         (sparc_ravenscar_ops): Redefine.
 109         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
 110         methods and destructor.  Remove members.
 111         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
 112         (ravenscar_thread_target::store_registers)
 113         (ravenscar_thread_target::prepare_to_store): Update.
 114         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
 115         Remove.
 116         (struct ppc_ravenscar_powerpc_ops): Derive from
 117         ravenscar_arch_ops.
 118         (ppc_ravenscar_powerpc_ops::fetch_registers)
 119         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
 120         (ppc_ravenscar_powerpc_ops): Redefine.
 121         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
 122         (ppc_ravenscar_e500_ops::fetch_registers)
 123         (ppc_ravenscar_e500_ops::store_registers): Now methods.
 124         (ppc_ravenscar_e500_ops): Redefine.
 125         * aarch64-ravenscar-thread.c
 126         (aarch64_ravenscar_generic_prepare_to_store): Remove.
 127         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
 128         (aarch64_ravenscar_fetch_registers)
 129         (aarch64_ravenscar_store_registers): Now methods.
 130         (aarch64_ravenscar_ops): Redefine.
 131
 132 2019-02-15  Tom Tromey  <tromey@adacore.com>
 133
 134         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
 135         (ravenscar_thread_target::stopped_by_hw_breakpoint)
 136         (ravenscar_thread_target::stopped_by_watchpoint)
 137         (ravenscar_thread_target::stopped_data_address)
 138         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
 139
 140 2019-02-15  Tom Tromey  <tromey@adacore.com>
 141
 142         * ravenscar-thread.c: Fix some typos.
 143
 144 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 145             Tom Tromey  <tromey@adacore.com>
 146
 147         * ada-lang.c (ada_exception_sal): Change addr_string to a
 148         std::string.
 149         (create_ada_exception_catchpoint): Update.
 150
 151 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 152             Tom Tromey  <tromey@adacore.com>
 153
 154         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
 155         (bp_location_ops): Remove.
 156         (base_breakpoint_allocate_location): Update.
 157         (free_bp_location): Update.
 158         * ada-lang.c (class ada_catchpoint_location)
 159         <ada_catchpoint_location>: Remove ops parameter.
 160         (ada_catchpoint_location_dtor): Remove.
 161         (ada_catchpoint_location_ops): Remove.
 162         (allocate_location_exception): Update.
 163         * breakpoint.h (struct bp_location_ops): Remove.
 164         (class bp_location) <bp_location>: Remove bp_location_ops
 165         parameter.
 166         <~bp_location>: Add destructor.
 167         <ops>: Remove.
 168
 169 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 170             Pedro Alves  <palves@redhat.com>
 171
 172         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
 173         'PATH_MAX'.
 174
 175 2019-02-14  David Michael  <fedora.dm0@gmail.com>
 176             Samuel Thibault  <samuel.thibault@gnu.org>
 177             Thomas Schwinge  <thomas@codesourcery.com>
 178
 179         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
 180         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
 181
 182 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 183
 184         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
 185         (check_empty): Use "const char *".
 186
 187         * gnu-nat.c (gnu_nat_target::detach): Instead of
 188         'detach_inferior (pid)' call
 189         'detach_inferior (find_inferior_pid (pid))'.
 190
 191         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
 192         'nat/fork-inferior.o'.
 193         * gnu-nat.c: #include "nat/fork-inferior.h".
 194
 195         * gnu-nat.c (gnu_nat_target::detach): Instead of
 196         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
 197         * gnu-nat.h: #include "inf-child.h".
 198         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
 199         'i386_gnu_nat_target::fetch_registers'.
 200         (gnu_store_registers): Rename/move to
 201         'i386_gnu_nat_target::store_registers'.
 202
 203         * config/i386/nm-i386gnu.h: Don't "#include" any files.
 204         * gnu-nat.h (mach_thread_info): New function.
 205         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
 206
 207         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
 208
 209 2019-02-14  Frederic Konrad  <konrad@adacore.com>
 210
 211         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
 212
 213 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
 214
 215         * windows-nat.c (windows_add_thread): Add new parameter
 216         "main_thread_p" with default value set to false.  Update
 217         function documentation as well as all callers.
 218         (windows_delete_thread): Likewise.
 219         (fake_create_process): Update call to windows_add_thread.
 220         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
 221         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
 222         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
 223         call to windows_delete_thread.
 224
 225 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
 226
 227         * MAINTAINERS: Add Andrew Burgess as global maintainer.
 228
 229 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 230
 231         * symfile.c (find_separate_debug_file): Use canonical path of
 232         sysroot with child_path instead of gdb_sysroot if it is valid.
 233
 234 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 235
 236         * symfile.c (find_separate_debug_file): Use child_path to
 237         determine if an object file is under a sysroot.
 238
 239 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 240
 241         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 242         unittests/child-path-selftests.c.
 243         * common/pathstuff.c (child_path): New function.
 244         * common/pathstuff.h (child_path): New prototype.
 245         * unittests/child-path-selftests.c: New file.
 246
 247 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 248
 249         * symfile.c (find_separate_debug_file): Look for separate debug
 250         files in debug directories under the sysroot.
 251
 252 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 253
 254         * symtab.h (struct minimal_symbol data_p): New const method.
 255         (struct minimal_symbol text_p): Likewise.
 256         * symtab.c (output_source_filename): Use file name style
 257         to print file name.
 258         (print_symbol_info): Likewise.
 259         (print_msymbol_info): Use address style to print addresses.
 260         Use function name style to print executable text symbols.
 261         (expand_symtab_containing_pc): Use data_p.
 262         (find_pc_sect_compunit_symtab): Likewise.
 263
 264 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 265
 266         * breakpoint.c (describe_other_breakpoints): Use address style
 267         to print addresses.
 268         (say_where): Likewise.
 269
 270 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 271
 272         * ada-typeprint.c (print_func_type): Print function name
 273         style to print function name.
 274         * c-typeprint.c (c_print_type_1): Likewise.
 275
 276 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
 277
 278         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
 279         for execve.
 280
 281 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 282
 283         * c-exp.y (direct_abs_decl): Use emplace_back to record the
 284         type_stack.
 285
 286 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
 287
 288         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
 289         TYPE_CODE_REF types.
 290
 291 2019-02-08  Jim Wilson  <jimw@sifive.com>
 292
 293         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
 294         (riscv_linux_fregset): New.
 295         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
 296
 297 2019-02-07  Tom Tromey  <tom@tromey.com>
 298
 299         * thread.c (thread_cancel_execution_command): Update.
 300         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
 301         methods.
 302         (struct thread_fsm_ops): Remove.
 303         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
 304         (thread_fsm_should_stop, thread_fsm_return_value)
 305         (thread_fsm_set_finished, thread_fsm_finished_p)
 306         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
 307         Don't declare.
 308         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
 309         * infrun.c (clear_proceed_status_thread)
 310         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
 311         (print_stop_event): Update.
 312         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
 313         Add constructor.
 314         (step_command_fsm_ops): Remove.
 315         (new_step_command_fsm): Remove.
 316         (step_1): Update.
 317         (step_command_fsm::should_stop): Rename from
 318         step_command_fsm_should_stop.
 319         (step_command_fsm::clean_up): Rename from
 320         step_command_fsm_clean_up.
 321         (step_command_fsm::do_async_reply_reason): Rename from
 322         step_command_fsm_async_reply_reason.
 323         (struct until_next_fsm): Inherit from thread_fsm.  Add
 324         constructor.
 325         (until_next_fsm_ops): Remove.
 326         (new_until_next_fsm): Remove.
 327         (until_next_fsm::should_stop): Rename from
 328         until_next_fsm_should_stop.
 329         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
 330         (until_next_fsm::do_async_reply_reason): Rename from
 331         until_next_fsm_async_reply_reason.
 332         (struct finish_command_fsm): Inherit from thread_fsm.  Add
 333         constructor.  Change type of breakpoint.
 334         (finish_command_fsm_ops): Remove.
 335         (new_finish_command_fsm): Remove.
 336         (finish_command_fsm::should_stop): Rename from
 337         finish_command_fsm_should_stop.
 338         (finish_command_fsm::clean_up): Rename from
 339         finish_command_fsm_clean_up.
 340         (finish_command_fsm::return_value): Rename from
 341         finish_command_fsm_return_value.
 342         (finish_command_fsm::do_async_reply_reason): Rename from
 343         finish_command_fsm_async_reply_reason.
 344         (finish_command): Update.
 345         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
 346         Add constructor.
 347         (call_thread_fsm_ops): Remove.
 348         (call_thread_fsm::call_thread_fsm): Rename from
 349         new_call_thread_fsm.
 350         (call_thread_fsm::should_stop): Rename from
 351         call_thread_fsm_should_stop.
 352         (call_thread_fsm::should_notify_stop): Rename from
 353         call_thread_fsm_should_notify_stop.
 354         (run_inferior_call, call_function_by_hand_dummy): Update.
 355         * cli/cli-interp.c (should_print_stop_to_console): Update.
 356         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
 357         Add constructor.  Change type of location_breakpoint,
 358         caller_breakpoint.
 359         (until_break_fsm_ops): Remove.
 360         (new_until_break_fsm): Remove.
 361         (until_break_fsm::should_stop): Rename from
 362         until_break_fsm_should_stop.
 363         (until_break_fsm::clean_up): Rename from
 364         until_break_fsm_clean_up.
 365         (until_break_fsm::do_async_reply_reason): Rename from
 366         until_break_fsm_async_reply_reason.
 367         (until_break_command): Update.
 368         * thread-fsm.c: Remove.
 369         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
 370
 371 2019-02-07  Tom Tromey  <tom@tromey.com>
 372
 373         * yy-remap.h: Add include guard.
 374         * xtensa-tdep.h: Add include guard.
 375         * xcoffread.h: Rename include guard.
 376         * varobj-iter.h: Add include guard.
 377         * tui/tui.h: Rename include guard.
 378         * tui/tui-winsource.h: Rename include guard.
 379         * tui/tui-wingeneral.h: Rename include guard.
 380         * tui/tui-windata.h: Rename include guard.
 381         * tui/tui-win.h: Rename include guard.
 382         * tui/tui-stack.h: Rename include guard.
 383         * tui/tui-source.h: Rename include guard.
 384         * tui/tui-regs.h: Rename include guard.
 385         * tui/tui-out.h: Rename include guard.
 386         * tui/tui-layout.h: Rename include guard.
 387         * tui/tui-io.h: Rename include guard.
 388         * tui/tui-hooks.h: Rename include guard.
 389         * tui/tui-file.h: Rename include guard.
 390         * tui/tui-disasm.h: Rename include guard.
 391         * tui/tui-data.h: Rename include guard.
 392         * tui/tui-command.h: Rename include guard.
 393         * tic6x-tdep.h: Add include guard.
 394         * target/waitstatus.h: Rename include guard.
 395         * target/wait.h: Rename include guard.
 396         * target/target.h: Rename include guard.
 397         * target/resume.h: Rename include guard.
 398         * target-float.h: Rename include guard.
 399         * stabsread.h: Add include guard.
 400         * rs6000-tdep.h: Add include guard.
 401         * riscv-fbsd-tdep.h: Add include guard.
 402         * regformats/regdef.h: Rename include guard.
 403         * record.h: Rename include guard.
 404         * python/python.h: Rename include guard.
 405         * python/python-internal.h: Rename include guard.
 406         * python/py-stopevent.h: Rename include guard.
 407         * python/py-ref.h: Rename include guard.
 408         * python/py-record.h: Rename include guard.
 409         * python/py-record-full.h: Rename include guard.
 410         * python/py-record-btrace.h: Rename include guard.
 411         * python/py-instruction.h: Rename include guard.
 412         * python/py-events.h: Rename include guard.
 413         * python/py-event.h: Rename include guard.
 414         * procfs.h: Add include guard.
 415         * proc-utils.h: Add include guard.
 416         * p-lang.h: Add include guard.
 417         * or1k-tdep.h: Rename include guard.
 418         * observable.h: Rename include guard.
 419         * nto-tdep.h: Rename include guard.
 420         * nat/x86-linux.h: Rename include guard.
 421         * nat/x86-linux-dregs.h: Rename include guard.
 422         * nat/x86-gcc-cpuid.h: Add include guard.
 423         * nat/x86-dregs.h: Rename include guard.
 424         * nat/x86-cpuid.h: Rename include guard.
 425         * nat/ppc-linux.h: Rename include guard.
 426         * nat/mips-linux-watch.h: Rename include guard.
 427         * nat/linux-waitpid.h: Rename include guard.
 428         * nat/linux-ptrace.h: Rename include guard.
 429         * nat/linux-procfs.h: Rename include guard.
 430         * nat/linux-osdata.h: Rename include guard.
 431         * nat/linux-nat.h: Rename include guard.
 432         * nat/linux-namespaces.h: Rename include guard.
 433         * nat/linux-btrace.h: Rename include guard.
 434         * nat/glibc_thread_db.h: Rename include guard.
 435         * nat/gdb_thread_db.h: Rename include guard.
 436         * nat/gdb_ptrace.h: Rename include guard.
 437         * nat/fork-inferior.h: Rename include guard.
 438         * nat/amd64-linux-siginfo.h: Rename include guard.
 439         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
 440         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
 441         * nat/aarch64-linux.h: Rename include guard.
 442         * nat/aarch64-linux-hw-point.h: Rename include guard.
 443         * mn10300-tdep.h: Add include guard.
 444         * mips-linux-tdep.h: Add include guard.
 445         * mi/mi-parse.h: Rename include guard.
 446         * mi/mi-out.h: Rename include guard.
 447         * mi/mi-main.h: Rename include guard.
 448         * mi/mi-interp.h: Rename include guard.
 449         * mi/mi-getopt.h: Rename include guard.
 450         * mi/mi-console.h: Rename include guard.
 451         * mi/mi-common.h: Rename include guard.
 452         * mi/mi-cmds.h: Rename include guard.
 453         * mi/mi-cmd-break.h: Rename include guard.
 454         * m2-lang.h: Add include guard.
 455         * location.h: Rename include guard.
 456         * linux-record.h: Rename include guard.
 457         * linux-nat.h: Add include guard.
 458         * linux-fork.h: Add include guard.
 459         * i386-darwin-tdep.h: Rename include guard.
 460         * hppa-linux-offsets.h: Add include guard.
 461         * guile/guile.h: Rename include guard.
 462         * guile/guile-internal.h: Rename include guard.
 463         * gnu-nat.h: Rename include guard.
 464         * gdb-stabs.h: Rename include guard.
 465         * frv-tdep.h: Add include guard.
 466         * f-lang.h: Add include guard.
 467         * event-loop.h: Add include guard.
 468         * darwin-nat.h: Rename include guard.
 469         * cp-abi.h: Rename include guard.
 470         * config/sparc/nm-sol2.h: Rename include guard.
 471         * config/nm-nto.h: Rename include guard.
 472         * config/nm-linux.h: Add include guard.
 473         * config/i386/nm-i386gnu.h: Rename include guard.
 474         * config/djgpp/nl_types.h: Rename include guard.
 475         * config/djgpp/langinfo.h: Rename include guard.
 476         * compile/gcc-cp-plugin.h: Add include guard.
 477         * compile/gcc-c-plugin.h: Add include guard.
 478         * compile/compile.h: Rename include guard.
 479         * compile/compile-object-run.h: Rename include guard.
 480         * compile/compile-object-load.h: Rename include guard.
 481         * compile/compile-internal.h: Rename include guard.
 482         * compile/compile-cplus.h: Rename include guard.
 483         * compile/compile-c.h: Rename include guard.
 484         * common/xml-utils.h: Rename include guard.
 485         * common/x86-xstate.h: Rename include guard.
 486         * common/version.h: Rename include guard.
 487         * common/vec.h: Rename include guard.
 488         * common/tdesc.h: Rename include guard.
 489         * common/selftest.h: Rename include guard.
 490         * common/scoped_restore.h: Rename include guard.
 491         * common/scoped_mmap.h: Rename include guard.
 492         * common/scoped_fd.h: Rename include guard.
 493         * common/safe-iterator.h: Rename include guard.
 494         * common/run-time-clock.h: Rename include guard.
 495         * common/refcounted-object.h: Rename include guard.
 496         * common/queue.h: Rename include guard.
 497         * common/ptid.h: Rename include guard.
 498         * common/print-utils.h: Rename include guard.
 499         * common/preprocessor.h: Rename include guard.
 500         * common/pathstuff.h: Rename include guard.
 501         * common/observable.h: Rename include guard.
 502         * common/netstuff.h: Rename include guard.
 503         * common/job-control.h: Rename include guard.
 504         * common/host-defs.h: Rename include guard.
 505         * common/gdb_wait.h: Rename include guard.
 506         * common/gdb_vecs.h: Rename include guard.
 507         * common/gdb_unlinker.h: Rename include guard.
 508         * common/gdb_unique_ptr.h: Rename include guard.
 509         * common/gdb_tilde_expand.h: Rename include guard.
 510         * common/gdb_sys_time.h: Rename include guard.
 511         * common/gdb_string_view.h: Rename include guard.
 512         * common/gdb_splay_tree.h: Rename include guard.
 513         * common/gdb_setjmp.h: Rename include guard.
 514         * common/gdb_ref_ptr.h: Rename include guard.
 515         * common/gdb_optional.h: Rename include guard.
 516         * common/gdb_locale.h: Rename include guard.
 517         * common/gdb_assert.h: Rename include guard.
 518         * common/filtered-iterator.h: Rename include guard.
 519         * common/filestuff.h: Rename include guard.
 520         * common/fileio.h: Rename include guard.
 521         * common/environ.h: Rename include guard.
 522         * common/common-utils.h: Rename include guard.
 523         * common/common-types.h: Rename include guard.
 524         * common/common-regcache.h: Rename include guard.
 525         * common/common-inferior.h: Rename include guard.
 526         * common/common-gdbthread.h: Rename include guard.
 527         * common/common-exceptions.h: Rename include guard.
 528         * common/common-defs.h: Rename include guard.
 529         * common/common-debug.h: Rename include guard.
 530         * common/cleanups.h: Rename include guard.
 531         * common/buffer.h: Rename include guard.
 532         * common/btrace-common.h: Rename include guard.
 533         * common/break-common.h: Rename include guard.
 534         * cli/cli-utils.h: Rename include guard.
 535         * cli/cli-style.h: Rename include guard.
 536         * cli/cli-setshow.h: Rename include guard.
 537         * cli/cli-script.h: Rename include guard.
 538         * cli/cli-interp.h: Rename include guard.
 539         * cli/cli-decode.h: Rename include guard.
 540         * cli/cli-cmds.h: Rename include guard.
 541         * charset-list.h: Add include guard.
 542         * buildsym-legacy.h: Rename include guard.
 543         * bfin-tdep.h: Add include guard.
 544         * ax.h: Rename include guard.
 545         * arm-linux-tdep.h: Add include guard.
 546         * arm-fbsd-tdep.h: Add include guard.
 547         * arch/xtensa.h: Rename include guard.
 548         * arch/tic6x.h: Add include guard.
 549         * arch/i386.h: Add include guard.
 550         * arch/arm.h: Rename include guard.
 551         * arch/arm-linux.h: Rename include guard.
 552         * arch/arm-get-next-pcs.h: Rename include guard.
 553         * arch/amd64.h: Add include guard.
 554         * arch/aarch64-insn.h: Rename include guard.
 555         * arch-utils.h: Rename include guard.
 556         * annotate.h: Add include guard.
 557         * amd64-darwin-tdep.h: Rename include guard.
 558         * aarch64-linux-tdep.h: Add include guard.
 559         * aarch64-fbsd-tdep.h: Add include guard.
 560         * aarch32-linux-nat.h: Add include guard.
 561
 562 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 563
 564         * macrotab.c (macro_define_internal): New function that
 565         factorizes macro_define_object_internal and macro_define_function
 566         code.
 567         (macro_define_object_internal): Use macro_define_internal.
 568         (macro_define_function): Likewise.
 569
 570 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 571
 572         * macrocmd.c (extract_identifier): Return
 573         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
 574         callers.
 575
 576 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
 577
 578         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
 579
 580 2019-02-05  Tom Tromey  <tom@tromey.com>
 581
 582         * target.c (target_stack::unpush): Move assertion earlier.
 583
 584 2019-01-30  Tom Tromey  <tom@tromey.com>
 585
 586         PR python/23615:
 587         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
 588         (gdbpy_parse_and_eval): Likewise.
 589         * python/python-internal.h (gdbpy_allow_threads): New class.
 590
 591 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
 592
 593         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
 594         (aarch64_fbsd_fpregmap): Move earlier.
 595         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
 596         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 597         instead of individual calls to trad_frame_set_reg_addr.
 598         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
 599         earlier.
 600         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
 601         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 602         instead of individual calls to trad_frame_set_reg_addr.
 603
 604 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
 605
 606         * CONTRIBUTE: Replace contribution list with wiki link.
 607
 608 2019-01-25  Tom Tromey  <tom@tromey.com>
 609
 610         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
 611
 612 2019-01-25  Tom Tromey  <tom@tromey.com>
 613
 614         * xtensa-linux-nat.c: Fix common/ includes.
 615         * xml-support.h: Fix common/ includes.
 616         * xml-support.c: Fix common/ includes.
 617         * x86-linux-nat.c: Fix common/ includes.
 618         * windows-nat.c: Fix common/ includes.
 619         * varobj.h: Fix common/ includes.
 620         * varobj.c: Fix common/ includes.
 621         * value.c: Fix common/ includes.
 622         * valops.c: Fix common/ includes.
 623         * utils.c: Fix common/ includes.
 624         * unittests/xml-utils-selftests.c: Fix common/ includes.
 625         * unittests/utils-selftests.c: Fix common/ includes.
 626         * unittests/unpack-selftests.c: Fix common/ includes.
 627         * unittests/tracepoint-selftests.c: Fix common/ includes.
 628         * unittests/style-selftests.c: Fix common/ includes.
 629         * unittests/string_view-selftests.c: Fix common/ includes.
 630         * unittests/scoped_restore-selftests.c: Fix common/ includes.
 631         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
 632         * unittests/scoped_fd-selftests.c: Fix common/ includes.
 633         * unittests/rsp-low-selftests.c: Fix common/ includes.
 634         * unittests/parse-connection-spec-selftests.c: Fix common/
 635         includes.
 636         * unittests/optional-selftests.c: Fix common/ includes.
 637         * unittests/offset-type-selftests.c: Fix common/ includes.
 638         * unittests/observable-selftests.c: Fix common/ includes.
 639         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
 640         * unittests/memrange-selftests.c: Fix common/ includes.
 641         * unittests/memory-map-selftests.c: Fix common/ includes.
 642         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
 643         * unittests/function-view-selftests.c: Fix common/ includes.
 644         * unittests/environ-selftests.c: Fix common/ includes.
 645         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
 646         * unittests/common-utils-selftests.c: Fix common/ includes.
 647         * unittests/cli-utils-selftests.c: Fix common/ includes.
 648         * unittests/array-view-selftests.c: Fix common/ includes.
 649         * ui-file.c: Fix common/ includes.
 650         * tui/tui-io.c: Fix common/ includes.
 651         * tracepoint.h: Fix common/ includes.
 652         * tracepoint.c: Fix common/ includes.
 653         * tracefile-tfile.c: Fix common/ includes.
 654         * top.h: Fix common/ includes.
 655         * top.c: Fix common/ includes.
 656         * thread.c: Fix common/ includes.
 657         * target/waitstatus.h: Fix common/ includes.
 658         * target/waitstatus.c: Fix common/ includes.
 659         * target.h: Fix common/ includes.
 660         * target.c: Fix common/ includes.
 661         * target-memory.c: Fix common/ includes.
 662         * target-descriptions.c: Fix common/ includes.
 663         * symtab.h: Fix common/ includes.
 664         * symfile.c: Fix common/ includes.
 665         * stap-probe.c: Fix common/ includes.
 666         * spu-linux-nat.c: Fix common/ includes.
 667         * sparc-nat.c: Fix common/ includes.
 668         * source.c: Fix common/ includes.
 669         * solib.c: Fix common/ includes.
 670         * solib-target.c: Fix common/ includes.
 671         * ser-unix.c: Fix common/ includes.
 672         * ser-tcp.c: Fix common/ includes.
 673         * ser-pipe.c: Fix common/ includes.
 674         * ser-base.c: Fix common/ includes.
 675         * selftest-arch.c: Fix common/ includes.
 676         * s12z-tdep.c: Fix common/ includes.
 677         * rust-exp.y: Fix common/ includes.
 678         * rs6000-aix-tdep.c: Fix common/ includes.
 679         * riscv-tdep.c: Fix common/ includes.
 680         * remote.c: Fix common/ includes.
 681         * remote-notif.h: Fix common/ includes.
 682         * remote-fileio.h: Fix common/ includes.
 683         * remote-fileio.c: Fix common/ includes.
 684         * regcache.h: Fix common/ includes.
 685         * regcache.c: Fix common/ includes.
 686         * record-btrace.c: Fix common/ includes.
 687         * python/python.c: Fix common/ includes.
 688         * python/py-type.c: Fix common/ includes.
 689         * python/py-inferior.c: Fix common/ includes.
 690         * progspace.h: Fix common/ includes.
 691         * producer.c: Fix common/ includes.
 692         * procfs.c: Fix common/ includes.
 693         * proc-api.c: Fix common/ includes.
 694         * printcmd.c: Fix common/ includes.
 695         * ppc-linux-nat.c: Fix common/ includes.
 696         * parser-defs.h: Fix common/ includes.
 697         * osdata.c: Fix common/ includes.
 698         * obsd-nat.c: Fix common/ includes.
 699         * nat/x86-linux.c: Fix common/ includes.
 700         * nat/x86-linux-dregs.c: Fix common/ includes.
 701         * nat/x86-dregs.h: Fix common/ includes.
 702         * nat/x86-dregs.c: Fix common/ includes.
 703         * nat/ppc-linux.c: Fix common/ includes.
 704         * nat/mips-linux-watch.h: Fix common/ includes.
 705         * nat/mips-linux-watch.c: Fix common/ includes.
 706         * nat/linux-waitpid.c: Fix common/ includes.
 707         * nat/linux-ptrace.h: Fix common/ includes.
 708         * nat/linux-ptrace.c: Fix common/ includes.
 709         * nat/linux-procfs.c: Fix common/ includes.
 710         * nat/linux-personality.c: Fix common/ includes.
 711         * nat/linux-osdata.c: Fix common/ includes.
 712         * nat/linux-namespaces.c: Fix common/ includes.
 713         * nat/linux-btrace.h: Fix common/ includes.
 714         * nat/linux-btrace.c: Fix common/ includes.
 715         * nat/fork-inferior.c: Fix common/ includes.
 716         * nat/amd64-linux-siginfo.c: Fix common/ includes.
 717         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
 718         * nat/aarch64-linux.c: Fix common/ includes.
 719         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
 720         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
 721         * namespace.h: Fix common/ includes.
 722         * mips-linux-tdep.c: Fix common/ includes.
 723         * minsyms.c: Fix common/ includes.
 724         * mi/mi-parse.h: Fix common/ includes.
 725         * mi/mi-main.c: Fix common/ includes.
 726         * mi/mi-cmd-env.c: Fix common/ includes.
 727         * memrange.h: Fix common/ includes.
 728         * memattr.c: Fix common/ includes.
 729         * maint.h: Fix common/ includes.
 730         * maint.c: Fix common/ includes.
 731         * main.c: Fix common/ includes.
 732         * machoread.c: Fix common/ includes.
 733         * location.c: Fix common/ includes.
 734         * linux-thread-db.c: Fix common/ includes.
 735         * linux-nat.c: Fix common/ includes.
 736         * linux-fork.c: Fix common/ includes.
 737         * inline-frame.c: Fix common/ includes.
 738         * infrun.c: Fix common/ includes.
 739         * inflow.c: Fix common/ includes.
 740         * inferior.h: Fix common/ includes.
 741         * inferior.c: Fix common/ includes.
 742         * infcmd.c: Fix common/ includes.
 743         * inf-ptrace.c: Fix common/ includes.
 744         * inf-child.c: Fix common/ includes.
 745         * ia64-linux-nat.c: Fix common/ includes.
 746         * i387-tdep.c: Fix common/ includes.
 747         * i386-tdep.c: Fix common/ includes.
 748         * i386-linux-tdep.c: Fix common/ includes.
 749         * i386-linux-nat.c: Fix common/ includes.
 750         * i386-go32-tdep.c: Fix common/ includes.
 751         * i386-fbsd-tdep.c: Fix common/ includes.
 752         * i386-fbsd-nat.c: Fix common/ includes.
 753         * guile/scm-type.c: Fix common/ includes.
 754         * guile/guile.c: Fix common/ includes.
 755         * go32-nat.c: Fix common/ includes.
 756         * gnu-nat.c: Fix common/ includes.
 757         * gdbthread.h: Fix common/ includes.
 758         * gdbarch-selftests.c: Fix common/ includes.
 759         * gdb_usleep.c: Fix common/ includes.
 760         * gdb_select.h: Fix common/ includes.
 761         * gdb_bfd.c: Fix common/ includes.
 762         * gcore.c: Fix common/ includes.
 763         * fork-child.c: Fix common/ includes.
 764         * findvar.c: Fix common/ includes.
 765         * fbsd-nat.c: Fix common/ includes.
 766         * event-top.c: Fix common/ includes.
 767         * event-loop.c: Fix common/ includes.
 768         * dwarf2read.c: Fix common/ includes.
 769         * dwarf2loc.c: Fix common/ includes.
 770         * dwarf2-frame.c: Fix common/ includes.
 771         * dwarf-index-cache.c: Fix common/ includes.
 772         * dtrace-probe.c: Fix common/ includes.
 773         * disasm-selftests.c: Fix common/ includes.
 774         * defs.h: Fix common/ includes.
 775         * csky-tdep.c: Fix common/ includes.
 776         * cp-valprint.c: Fix common/ includes.
 777         * cp-support.h: Fix common/ includes.
 778         * cp-support.c: Fix common/ includes.
 779         * corelow.c: Fix common/ includes.
 780         * completer.h: Fix common/ includes.
 781         * completer.c: Fix common/ includes.
 782         * compile/compile.c: Fix common/ includes.
 783         * compile/compile-loc2c.c: Fix common/ includes.
 784         * compile/compile-cplus-types.c: Fix common/ includes.
 785         * compile/compile-cplus-symbols.c: Fix common/ includes.
 786         * command.h: Fix common/ includes.
 787         * cli/cli-dump.c: Fix common/ includes.
 788         * cli/cli-cmds.c: Fix common/ includes.
 789         * charset.c: Fix common/ includes.
 790         * build-id.c: Fix common/ includes.
 791         * btrace.h: Fix common/ includes.
 792         * btrace.c: Fix common/ includes.
 793         * breakpoint.h: Fix common/ includes.
 794         * breakpoint.c: Fix common/ includes.
 795         * ax.h:
 796         (enum agent_op): Fix common/ includes.
 797         * ax-general.c (struct aop_map): Fix common/ includes.
 798         * ax-gdb.c: Fix common/ includes.
 799         * auxv.c: Fix common/ includes.
 800         * auto-load.c: Fix common/ includes.
 801         * arm-tdep.c: Fix common/ includes.
 802         * arch/riscv.c: Fix common/ includes.
 803         * arch/ppc-linux-common.c: Fix common/ includes.
 804         * arch/i386.c: Fix common/ includes.
 805         * arch/arm.c: Fix common/ includes.
 806         * arch/arm-linux.c: Fix common/ includes.
 807         * arch/arm-get-next-pcs.c: Fix common/ includes.
 808         * arch/amd64.c: Fix common/ includes.
 809         * arch/aarch64.c: Fix common/ includes.
 810         * arch/aarch64-insn.c: Fix common/ includes.
 811         * arch-utils.c: Fix common/ includes.
 812         * amd64-windows-tdep.c: Fix common/ includes.
 813         * amd64-tdep.c: Fix common/ includes.
 814         * amd64-sol2-tdep.c: Fix common/ includes.
 815         * amd64-obsd-tdep.c: Fix common/ includes.
 816         * amd64-nbsd-tdep.c: Fix common/ includes.
 817         * amd64-linux-tdep.c: Fix common/ includes.
 818         * amd64-linux-nat.c: Fix common/ includes.
 819         * amd64-fbsd-tdep.c: Fix common/ includes.
 820         * amd64-fbsd-nat.c: Fix common/ includes.
 821         * amd64-dicos-tdep.c: Fix common/ includes.
 822         * amd64-darwin-tdep.c: Fix common/ includes.
 823         * agent.c: Fix common/ includes.
 824         * ada-lang.h: Fix common/ includes.
 825         * ada-lang.c: Fix common/ includes.
 826         * aarch64-tdep.c: Fix common/ includes.
 827
 828 2019-01-25  Tom Tromey  <tom@tromey.com>
 829
 830         * common/create-version.sh: Use common/version.h.
 831
 832 2019-01-24  Pedro Alves  <palves@redhat.com>
 833
 834         * infrun.c (signal_stop, signal_print, signal_program)
 835         (signal_catch, signal_pass): Now arrays instead of pointers.
 836         (update_signals_program_target, do_target_resume)
 837         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
 838         * linux-nat.c (linux_nat_target::pass_signals)
 839         (linux_nat_target::create_inferior, linux_nat_target::attach):
 840         Adjust.
 841         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
 842         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
 843         * procfs.c (procfs_target::pass_signals): Adjust.
 844         * record-full.c (record_full_target::resume): Adjust.
 845         * remote.c (remote_target::pass_signals)
 846         (remote_target::program_signals): Adjust.
 847         * target-debug.h (target_debug_print_signals): Now takes a
 848         gdb::array_view as parameter.  Adjust.
 849         * target.h (target_ops) <pass_signals, program_signals>: Replace
 850         pointer and length parameters with gdb::array_view.
 851         (target_pass_signals, target_program_signals): Likewise.
 852         * target-delegates.c: Regenerate.
 853
 854 2019-01-24  Pedro Alves  <palves@redhat.com>
 855
 856         * common/forward-scope-exit.h
 857         (forward_scope_exit::forward_scope_exit): Pass arguments to
 858         m_bind_function directly, instead of creating a std::bind and
 859         copying that.
 860
 861 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
 862
 863         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 864         for static members.
 865         (pass_in_v_vfp_candidate): Likewise.
 866
 867 2019-01-23  Tom Tromey  <tom@tromey.com>
 868             Pedro Alves  <palves@redhat.com>
 869
 870         * regcache.c (class regcache_invalidator): Remove.
 871         (regcache::raw_write): Use make_scope_exit.
 872
 873 2019-01-23  Tom Tromey  <tom@tromey.com>
 874
 875         * ui-out.h (class ui_out_emit_type): Update comment.
 876
 877 2019-01-23  Tom Tromey  <tom@tromey.com>
 878
 879         * infrun.c (fetch_inferior_event): Update comment.
 880
 881 2019-01-23  Tom Tromey  <tom@tromey.com>
 882             Pedro Alves  <palves@redhat.com>
 883
 884         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
 885         parameter.
 886         (fetch_inferior_event): Use SCOPE_EXIT.
 887
 888
 889 2019-01-23  Tom Tromey  <tom@tromey.com>
 890             Pedro Alves  <palves@redhat.com>
 891
 892         * infrun.c (disable_thread_events): Delete.
 893         (stop_all_threads): Use SCOPE_EXIT.
 894
 895 2019-01-23  Tom Tromey  <tom@tromey.com>
 896             Pedro Alves  <palves@redhat.com>
 897
 898         * symfile.c: Include forward-scope-exit.h.
 899         (clear_symtab_users_cleanup): Replace forward declaration with
 900         a FORWARD_SCOPE_EXIT.
 901         (syms_from_objfile_1): Use the forward_scope_exit and
 902         gdb::optional instead of cleanup_function.
 903         (reread_symbols): Use the forward_scope_exit instead of
 904         cleanup_function.
 905         (clear_symtab_users_cleanup): Remove function.
 906
 907 2019-01-23  Tom Tromey  <tom@tromey.com>
 908             Pedro Alves  <palves@redhat.com>
 909
 910         * linux-nat.c: Include scope-exit.h.
 911         (cleanup_target_stop): Remove.
 912         (linux_nat_target::static_tracepoint_markers_by_strid): Use
 913         SCOPE_EXIT.
 914
 915 2019-01-23  Tom Tromey  <tom@tromey.com>
 916             Pedro Alves  <palves@redhat.com>
 917
 918         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
 919         (call_function_by_hand_dummy): Use SCOPE_EXIT.
 920
 921 2019-01-23  Tom Tromey  <tom@tromey.com>
 922             Andrew Burgess  <andrew.burgess@embecosm.com>
 923             Pedro Alves  <palves@redhat.com>
 924
 925         * infrun.c (fetch_inferior_event): Use scope_exit.
 926         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
 927         * top.c (execute_command): Use scope_exit.
 928         * breakpoint.c (bpstat_do_actions): Use scope_exit.
 929         * utils.c (do_bpstat_clear_actions_cleanup)
 930         (make_bpstat_clear_actions_cleanup): Remove.
 931
 932 2019-01-23  Tom Tromey  <tom@tromey.com>
 933             Pedro Alves  <palves@redhat.com>
 934
 935         * infrun.c: Include "common/scope-exit.h"
 936         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
 937         (wait_for_inferior): Use SCOPE_EXIT.
 938         (fetch_inferior_event): Use scope_exit.
 939
 940 2019-01-23  Tom Tromey  <tom@tromey.com>
 941             Pedro Alves  <palves@redhat.com>
 942
 943         * breakpoint.c (create_breakpoint): Remove cleanup.
 944
 945 2019-01-23  Tom Tromey  <tom@tromey.com>
 946             Andrew Burgess  <andrew.burgess@embecosm.com>
 947             Pedro Alves  <palves@redhat.com>
 948
 949 2019-01-23  Pedro Alves  <palves@redhat.com>
 950
 951         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
 952
 953 2019-01-23  Pedro Alves  <palves@redhat.com>
 954             Andrew Burgess  <andrew.burgess@embecosm.com>
 955
 956         * gdbthread.h: Include "common/forward-scope-exit.h".
 957         (scoped_finish_thread_state): Redefine custom class in terms of
 958         forward_scope_exit.
 959
 960 2019-01-23  Pedro Alves  <palves@redhat.com>
 961             Andrew Burgess  <andrew.burgess@embecosm.com>
 962
 963         * common/forward-scope-exit.h: New file.
 964
 965 2019-01-23  Pedro Alves  <palves@redhat.com>
 966             Andrew Burgess  <andrew.burgess@embecosm.com>
 967             Tom Tromey  <tom@tromey.com>
 968
 969         * common/scope-exit.h: New file.
 970
 971 2019-01-23  Pedro Alves  <palves@redhat.com>
 972
 973         * common/preprocessor.h (ESC): Rename to ...
 974         (ESC_PARENS): ... this.
 975         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
 976         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
 977
 978 2019-01-23  Tom Tromey  <tom@tromey.com>
 979
 980         * language.h (class scoped_switch_to_sym_language_if_auto):
 981         Initialize m_lang in both cases.
 982
 983 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
 984
 985         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
 986         with XCNEW.
 987
 988 2019-01-22  Tom Tromey  <tom@tromey.com>
 989
 990         * corelow.c: Do not include sys/file.h.
 991
 992 2019-01-22  Tom Tromey  <tom@tromey.com>
 993
 994         * tui/tui-wingeneral.h: Include gdb_curses.h.
 995
 996 2019-01-22  Tom Tromey  <tom@tromey.com>
 997
 998         * source-cache.h (class source_cache) <get_source_lines,
 999         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1000
1001 2019-01-22  Tom Tromey  <tom@tromey.com>
1002
1003         * remote-fileio.h (struct remote_target): Declare.
1004
1005 2019-01-22  Tom Tromey  <tom@tromey.com>
1006
1007         * python/py-arch.c: Do not include py-ref.h.
1008         * python/py-bpevent.c: Do not include py-ref.h.
1009         * python/py-cmd.c: Do not include py-ref.h.
1010         * python/py-continueevent.c: Do not include py-ref.h.
1011         * python/py-event.h: Do not include py-ref.h.
1012         * python/py-evtregistry.c: Do not include py-ref.h.
1013         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1014         * python/py-frame.c: Do not include py-ref.h.
1015         * python/py-framefilter.c: Do not include py-ref.h.
1016         * python/py-function.c: Do not include py-ref.h.
1017         * python/py-infevents.c: Do not include py-ref.h.
1018         * python/py-linetable.c: Do not include py-ref.h.
1019         * python/py-objfile.c: Do not include py-ref.h.
1020         * python/py-param.c: Do not include py-ref.h.
1021         * python/py-prettyprint.c: Do not include py-ref.h.
1022         * python/py-progspace.c: Do not include py-ref.h.
1023         * python/py-symbol.c: Do not include py-ref.h.
1024         * python/py-symtab.c: Do not include py-ref.h.
1025         * python/py-type.c: Do not include py-ref.h.
1026         * python/py-unwind.c: Do not include py-ref.h.
1027         * python/py-utils.c: Do not include py-ref.h.
1028         * python/py-value.c: Do not include py-ref.h.
1029         * python/py-varobj.c: Do not include py-ref.h.
1030         * python/py-xmethods.c: Do not include py-ref.h.
1031         * python/python.c: Do not include py-ref.h.
1032         * varobj.c: Do not include py-ref.h.
1033
1034 2019-01-22  Tom Tromey  <tom@tromey.com>
1035
1036         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1037         keyword for bcache.
1038
1039 2019-01-22  Tom Tromey  <tom@tromey.com>
1040
1041         * compile/compile-cplus-types.c: Remove a comment by #include.
1042
1043 2019-01-22  Tom Tromey  <tom@tromey.com>
1044
1045         * compile/gcc-c-plugin.h: Include compile-internal.h.
1046
1047 2019-01-22  Tom Tromey  <tom@tromey.com>
1048
1049         * stabsread.c (EXTERN): Do not define.
1050         (symnum, next_symbol_text_func, processing_gcc_compilation)
1051         (within_function, global_sym_chain, global_stabs)
1052         (previous_stab_code, this_object_header_files)
1053         (n_this_object_header_files)
1054         (n_allocated_this_object_header_files): Define.
1055         * stabsread.h (EXTERN): Never define.  Use "extern".
1056
1057 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1058
1059         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1060         history_value.
1061
1062 2019-01-21  Tom Tromey  <tom@tromey.com>
1063
1064         * ui-out.c: Fix includes.
1065         * tui/tui-source.c: Fix includes.
1066         * target.c: Fix includes.
1067         * remote.c: Fix includes.
1068         * regcache.c: Fix includes.
1069         * python/py-block.c: Fix includes.
1070         * printcmd.c: Fix includes.
1071         * or1k-tdep.c: Fix includes.
1072         * mi/mi-main.c: Fix includes.
1073         * m32r-tdep.c: Fix includes.
1074         * csky-tdep.c: Fix includes.
1075         * compile/compile-cplus-types.c: Fix includes.
1076         * cli/cli-interp.c: Fix includes.
1077
1078 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1079
1080         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1081         for padding.
1082
1083 2019-01-16  Tom Tromey  <tom@tromey.com>
1084
1085         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1086         earlier.
1087         (struct objfile) <msymbols_range>: Move from top level.
1088         <msymbols>: New method.
1089         (class objfile_msymbols): Remove.
1090         * symtab.c (default_collect_symbol_completion_matches_break_on):
1091         Update.
1092         * symmisc.c (dump_msymbols): Update.
1093         * stabsread.c (scan_file_globals): Update.
1094         * objc-lang.c (info_selectors_command, info_classes_command)
1095         (find_methods): Update.
1096         * minsyms.c (find_solib_trampoline_target): Update.
1097         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1098         * coffread.c (coff_symfile_read): Update.
1099         * ada-lang.c (ada_lookup_simple_minsym)
1100         (ada_collect_symbol_completion_matches): Update.
1101
1102 2019-01-16  Tom Tromey  <tom@tromey.com>
1103
1104         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1105         type.  Remove no-argument constructor.
1106         <iterator::operator++>: Simplify.
1107         <begin>: Update.
1108         <end>: Use minimal_symbol_count.
1109
1110 2019-01-16  Tom Tromey  <tom@tromey.com>
1111
1112         * objfiles.h (struct objfile) <psymtabs>: New method.
1113         (class objfile_psymtabs): Remove.
1114         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1115         typedef.
1116         <range>: New method.
1117         (require_partial_symbols): Change return type.
1118         * psymtab.c (require_partial_symbols)
1119         (psym_expand_symtabs_matching): Update.
1120         * mdebugread.c (parse_partial_symbols): Update.
1121         * dbxread.c (dbx_end_psymtab): Update.
1122
1123 2019-01-15  Tom Tromey  <tom@tromey.com>
1124
1125         * symtab.c (lookup_objfile_from_block)
1126         (lookup_symbol_in_objfile_symtabs)
1127         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1128         (find_line_symtab, info_sources_command)
1129         (default_collect_symbol_completion_matches_break_on)
1130         (make_source_files_completion_list): Update.
1131         * symmisc.c (print_objfile_statistics, dump_objfile)
1132         (maintenance_print_symbols, maintenance_info_symtabs)
1133         (maintenance_check_symtabs, maintenance_info_line_tables):
1134         Update.
1135         * source.c (select_source_symtab)
1136         (forget_cached_source_info_for_objfile): Update.
1137         * objfiles.h (class objfile_compunits): Remove.
1138         (struct objfile) <compunits_range>: New typedef.
1139         (compunits): New method.
1140         * objfiles.c (objfile_relocate1): Update.
1141         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1142         * maint.c (count_symtabs_and_blocks): Update.
1143         * linespec.c (iterate_over_all_matching_symtabs): Update.
1144         * cp-support.c (add_symbol_overload_list_qualified): Update.
1145         * coffread.c (coff_symtab_read): Update.
1146         * ada-lang.c (add_nonlocal_symbols)
1147         (ada_collect_symbol_completion_matches)
1148         (ada_add_global_exceptions): Update.
1149
1150 2019-01-15  Tom Tromey  <tom@tromey.com>
1151
1152         * progspace.h (program_space) <objfiles_safe_range>: New
1153         typedef.
1154         <objfiles_safe>: New method.
1155         * objfiles.h (class all_objfiles_safe): Remove.
1156         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1157         * jit.c (jit_inferior_exit_hook): Update.
1158
1159 2019-01-17  Tom Tromey  <tom@tromey.com>
1160
1161         * progspace.h (program_space) <objfiles_range>: New typedef.
1162         <objfiles>: New method.
1163         <objfiles_head>: Rename from objfiles.
1164         (object_files): Update.
1165         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1166         * guile/scm-pretty-print.c
1167         (ppscm_find_pretty_printer_from_objfiles): Update.
1168         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1169         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1170         Update.
1171         * python/py-progspace.c (pspy_get_objfiles): Update.
1172         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1173         Update.
1174         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1175         (objfpy_lookup_objfile_by_build_id): Update.
1176         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1177         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1178         Update.
1179         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1180         (expand_symtab_containing_pc, lookup_objfile_from_block)
1181         (lookup_static_symbol, basic_lookup_transparent_type)
1182         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1183         (find_line_symtab, info_sources_command)
1184         (default_collect_symbol_completion_matches_break_on)
1185         (make_source_files_completion_list, find_main_name): Update.
1186         * symmisc.c (print_symbol_bcache_statistics)
1187         (print_objfile_statistics, maintenance_print_symbols)
1188         (maintenance_print_msymbols, maintenance_print_objfiles)
1189         (maintenance_info_symtabs, maintenance_check_symtabs)
1190         (maintenance_expand_symtabs, maintenance_info_line_tables):
1191         Update.
1192         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1193         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1194         (map_overlay_command, unmap_overlay_command)
1195         (simple_overlay_update, expand_symtabs_matching)
1196         (map_symbol_filenames): Update.
1197         * symfile-debug.c (set_debug_symfile): Update.
1198         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1199         Update.
1200         * source.c (select_source_symtab, forget_cached_source_info):
1201         Update.
1202         * solib.c (solib_read_symbols): Update.
1203         * solib-spu.c (append_ocl_sos): Update.
1204         * psymtab.c (maintenance_print_psymbols)
1205         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1206         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1207         * printcmd.c (info_symbol_command): Update.
1208         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1209         Update.
1210         * objfiles.h (class all_objfiles): Remove.
1211         * objfiles.c (have_partial_symbols, have_full_symbols)
1212         (have_minimal_symbols, qsort_cmp, update_section_map)
1213         (shared_objfile_contains_address_p)
1214         (default_iterate_over_objfiles_in_search_order): Update.
1215         * objc-lang.c (info_selectors_command, info_classes_command)
1216         (find_methods): Update.
1217         * minsyms.c (find_solib_trampoline_target): Update.
1218         * maint.c (maintenance_info_sections)
1219         (maintenance_translate_address, count_symtabs_and_blocks):
1220         Update.
1221         * main.c (captured_main_1): Update.
1222         * linux-thread-db.c (try_thread_db_load_from_pdir)
1223         (has_libpthread): Update.
1224         * linespec.c (iterate_over_all_matching_symtabs)
1225         (search_minsyms_for_name): Update.
1226         * jit.c (jit_find_objf_with_entry_addr): Update.
1227         * hppa-tdep.c (find_unwind_entry)
1228         (hppa_lookup_stub_minimal_symbol): Update.
1229         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1230         Update.
1231         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1232         (elf_gnu_ifunc_resolve_by_got): Update.
1233         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1234         * dwarf-index-write.c (save_gdb_index_command): Update.
1235         * cp-support.c (add_symbol_overload_list_qualified): Update.
1236         * breakpoint.c (create_overlay_event_breakpoint)
1237         (create_longjmp_master_breakpoint)
1238         (create_std_terminate_master_breakpoint)
1239         (create_exception_master_breakpoint): Update.
1240         * blockframe.c (find_pc_partial_function): Update.
1241         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1242         (ada_collect_symbol_completion_matches)
1243         (ada_add_global_exceptions): Update.
1244
1245 2019-01-17  Tom Tromey  <tom@tromey.com>
1246
1247         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1248         declare VEC.
1249         (solib_target_parse_libraries): Change return type.
1250         (library_list_start_segment, library_list_start_section)
1251         (library_list_end_library, library_list_start_library); Update.
1252         (solib_target_free_library_list): Remove.
1253         (solib_target_parse_libraries): Remove cleanup.  Change return
1254         type.
1255         (solib_target_current_sos): Update.
1256
1257 2019-01-17  Tom Tromey  <tromey@bapiya>
1258
1259         * valprint.c: Replace "the the" with "the".
1260         * symtab.c: Replace "the the" with "the".
1261         * solib.c: Replace "the the" with "the".
1262         * solib-dsbt.c: Replace "the the" with "the".
1263         * linespec.c: Replace "the the" with "the".
1264         * dwarf2loc.h: Replace "the the" with "the".
1265         * amd64-windows-tdep.c: Replace "the the" with "the".
1266         * aarch64-tdep.c: Replace "the the" with "the".
1267
1268 2019-01-16  Keith Seitz  <keiths@redhat.com>
1269
1270         PR gdb/23773
1271         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1272         <builder>: Rename to ..
1273         <m_builder>: ... this and make private.
1274         (dwarf2_cu::get_builder): New method.  Change all users of
1275         `builder' to use this method.
1276         (dwarf2_start_symtab): Move to ...
1277         (dwarf2_cu::start_symtab): ... here.  Update all callers
1278         (setup_type_unit_groups): Move to ...
1279         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1280         callers.
1281         (dwarf2_cu::reset_builder): New method.
1282         (process_full_compunit, process_full_type_unit): Use
1283         dwarf2_cu::reset_builder.
1284         (follow_die_offset): Record the ancestor CU if it is different
1285         from the followed DIE's CU.
1286         (follow_die_sig_1): Likewise.
1287
1288 2019-01-15  Tom Tromey  <tom@tromey.com>
1289
1290         * remote.c (class remote_state) <buf>: Now a char_vector.
1291         <buf_size>: Remove.
1292         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1293         parameter.
1294         (remote_target::getpkt_or_notif_sane_1)
1295         (remote_target::getpkt_sane)
1296         (remote_target::getpkt_or_notif_sane): Likewise.
1297         (class remote_target) <putpkt>: New overload.
1298         (remote_target::read_frame): Change type of "buf_p".  Remove
1299         sizeof_p parameter.
1300         (packet_ok): New overload.
1301         (packet_check_result): New overload.
1302         Update all uses.
1303
1304 2019-01-14  Tom Tromey  <tom@tromey.com>
1305
1306         * remote-notif.c (handle_notification, remote_notif_ack)
1307         (remote_notif_parse): Make "buf" const.
1308         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1309         const.
1310         (remote_notif_parse, remote_notif_ack, handle_notification):
1311         Likewise.
1312         * remote.c (remote_notif_stop_parse): Make "buf" const.
1313         (remote_target::remote_parse_stop_reply): Make "buf" const.
1314         (remote_notif_stop_ack): Make "buf" const.
1315
1316 2019-01-14  Tom Tromey  <tom@tromey.com>
1317
1318         * remote.c (remote_console_output): Make parameter const.
1319
1320 2019-01-14  Tom Tromey  <tom@tromey.com>
1321
1322         * target-debug.h (target_debug_print_signals): Constify.
1323         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1324         * procfs.c (procfs_target::pass_signals): Update.
1325         * linux-nat.c (linux_nat_target::pass_signals): Update.
1326         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1327         * target-delegates.c: Rebuild.
1328         * remote.c (remote_target::program_signals): Update.
1329         (remote_target::pass_signals): Update.
1330         * target.c (target_pass_signals): Constify argument.
1331         (target_program_signals): Likewise.
1332         * target.h (struct target_ops) <pass_signals, program_signals>:
1333         Constify argument.
1334         (target_pass_signals, target_program_signals): Constify argument.
1335
1336 2019-01-14  Tom Tromey  <tom@tromey.com>
1337
1338         PR tui/28819:
1339         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1340
1341 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1342
1343         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1344         field.
1345         * rs6000-tdep.c: Include reggroups.h.
1346         (IS_V_ALIAS_PSEUDOREG): Define.
1347         (rs6000_register_name): Return names for the "vX" aliases.
1348         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1349         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1350         aliases.  Call default_register_reggroup_p for all other
1351         pseudo-registers.
1352         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1353         New functions.
1354         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1355         Handle "vX" aliases.
1356         (v_alias_pseudo_register_collect): New function.
1357         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1358         (rs6000_gdbarch_init): Initialize "vX" aliases as
1359         pseudo-registers.  Restore registration of
1360         rs6000_pseudo_register_reggroup_p with
1361         set_tdesc_pseudo_register_reggroup_p.
1362
1363 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1364
1365         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1366         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1367         set_gdbarch_num_pseudo_regs.
1368
1369 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1370
1371         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1372         Remove arg prefixname, add do_set and do_show.
1373         Add member functions set_list and show_list.
1374         * cli/cli-style.c (class cli_style_option): Update accordingly.
1375         (style_set_list): Move to file scope.
1376         (style_show_list): Likewise.
1377         (set_style): Call help_list.
1378         (show_style): Call cmd_show_list.
1379         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1380         Update to use the new macro.
1381
1382 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1383
1384         * ada-lang.c (_initialize_ada_language): Expand the help text
1385         for the "catch exception" command.
1386
1387 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1388
1389         * symtab.c (matching_obj_sections): Initialize obj,
1390         declare it closer to its usage.
1391
1392 2019-01-10  Tom Tromey  <tom@tromey.com>
1393
1394         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1395         (basic_inf_threads_range): Remove.
1396         (inf_threads_range, inf_non_exited_threads_range)
1397         (safe_inf_threads_range): Use next_adapter.
1398
1399 2019-01-10  Keith Seitz  <keiths@redhat.com>
1400
1401         PR gdb/23712
1402         PR symtab/23010
1403         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1404         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1405
1406 2019-01-10  Keith Seitz  <keiths@redhat.com>
1407
1408         PR gdb/23712
1409         PR symtab/23010
1410         * dictionary.c (pending_to_vector): Remove.
1411         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1412         Remove _1 suffix, replacing functions of the same name.  Update
1413         all callers.
1414         (dict_create_hashed, dict_create_hashed_expandable)
1415         (dict_create_linear, dict_create_linear_expandable, dict_free)
1416         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1417         Make functions static.
1418
1419 2019-01-10  Keith Seitz  <keiths@redhat.com>
1420
1421         PR gdb/23712
1422         PR symtab/23010
1423         * dictionary.h (struct dictionary): Replace declaration with
1424         multidictionary.
1425         (dict_create_hashed, dict_create_hashed_expandable)
1426         (dict_create_linear, dict_create_linear_expandable)
1427         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1428         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1429         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1430         taking multidictionary argument.
1431         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1432         * block.h (struct block) <dict>: Change to multidictionary
1433         and rename `multidict'.
1434         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1435         symmisc.c: Update all dictionary references to multidictionary.
1436
1437 2019-01-10  Keith Seitz  <keiths@redhat.com>
1438
1439         PR gdb/23712
1440         PR symtab/23010
1441         * dictionary.c: Include unordered_map.
1442         (pending_to_vector): New function.
1443         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1444         Rewrite the non-"_1" functions to take vector instead
1445         of linked list.
1446         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1447         "new" _1 versions of the same name.
1448         (multidictionary): Define.
1449         (std::hash<enum language): New definition.
1450         (collate_pending_symbols_by_language, mdict_create_hashed)
1451         (mdict_create_hashed_expandable, mdict_create_linear)
1452         (mdict_create_linear_expandable, mdict_free)
1453         (find_language_dictionary, create_new_language_dictionary)
1454         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1455         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1456         (mdict_size, mdict_empty): New functions.
1457         * dictionary.h (mdict_iterator): Define.
1458
1459 2019-01-10  Pedro Alves  <palves@redhat.com>
1460
1461         * breakpoint.c (read_uploaded_action)
1462         (create_tracepoint_from_upload): Adjust to use
1463         gdb::unique_xmalloc_ptr.
1464         * ctf.c (ctf_write_uploaded_tp):
1465         (SET_ARRAY_FIELD): Use emplace_back.
1466         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1467         * tracefile-tfile.c (tfile_write_uploaded_tp):
1468         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1469         gdb::unique_xmalloc_ptr.
1470         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1471         at_string, cond_string, cmd_strings>: Replace char pointers
1472         with gdb::unique_xmalloc_ptr.
1473
1474 2019-01-10  Pedro Alves  <palves@redhat.com>
1475
1476         * solib-target.c (library_list_start_library): Don't xstrdup name.
1477
1478 2019-01-10  Pedro Alves  <palves@redhat.com>
1479
1480         * mdebugread.c (parse_partial_symbols): Use
1481         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1482
1483 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1484
1485         * linux-fork.c (scoped_switch_fork_info)
1486         <~scoped_switch_fork_info>: Fix incorrect variable name.
1487
1488 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1489
1490         * linux-fork.c (scoped_switch_fork_info)
1491         <scoped_switch_fork_info>: Make explicit.
1492         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1493
1494 2019-01-10  Tom Tromey  <tom@tromey.com>
1495
1496         * objfiles.h (objfile::reset_psymtabs): Update.
1497         * objfiles.c (objfile::objfile): Update.
1498         * psymtab.h (psymtab_storage::obstack): Update.
1499         (psymtab_storage::m_obstack): Use gdb::optional.
1500         (class psymtab_storage): Update comment.  Remove objfile
1501         parameter.
1502         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1503
1504 2019-01-10  Tom Tromey  <tom@tromey.com>
1505
1506         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1507         <free_psymtabs>: Now private.
1508         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1509         (allocate_psymtab): Use new method.
1510
1511 2019-01-10  Tom Tromey  <tom@tromey.com>
1512
1513         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1514         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1515         * mdebugread.c (parse_partial_symbols): Use
1516         allocate_dependencies.
1517         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1518         allocate_dependencies.
1519         (process_psymtab_comp_unit_reader)
1520         (build_type_psymtab_dependencies): Likewise.
1521         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1522
1523 2019-01-10  Tom Tromey  <tom@tromey.com>
1524
1525         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1526         PSYMBOL_SET_LANGUAGE.
1527         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1528
1529 2019-01-10  Tom Tromey  <tom@tromey.com>
1530
1531         * psymtab.h (psymtab_storage::obstack): New method.
1532         <m_obstack>: Rename from obstack; now private.
1533         * psymtab.c (psymtab_storage): Update.
1534         * dwarf2read.c (create_addrmap_from_index)
1535         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1536         Update.
1537
1538 2019-01-10  Tom Tromey  <tom@tromey.com>
1539
1540         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1541         * objfiles.h (objfile::reset_psymtabs): New method.
1542
1543 2019-01-10  Tom Tromey  <tom@tromey.com>
1544
1545         * symmisc.c (print_symbol_bcache_statistics): Update.
1546         (print_objfile_statistics): Update.
1547         * symfile.c (reread_symbols): Update.
1548         * psymtab.h (class psymtab_storage): New.
1549         * psymtab.c (psymtab_storage): New constructor.
1550         (~psymtab_storage): New destructor.
1551         (require_partial_symbols): Update.
1552         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1553         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1554         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1555         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1556         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1557         (start_psymtab_common, end_psymtab_common)
1558         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1559         (allocate_psymtab): Update.
1560         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1561         Update.
1562         (dump_psymtab_addrmap, maintenance_print_psymbols)
1563         (maintenance_check_psymtabs): Update.
1564         (class objfile_psymtabs): Move to objfiles.h.
1565         * psympriv.h (discard_psymtab): Now inline.
1566         (psymtab_discarder::psymtab_discarder): Update.
1567         (psymtab_discarder::~psymtab_discarder): Update.
1568         (ALL_OBJFILE_PSYMTABS): Rewrite.
1569         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1570         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1571         Remove fields.
1572         <partial_symtabs>: New field.
1573         (class objfile_psymtabs): Move from psymtab.h.  Update.
1574         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1575         psymbol_cache.
1576         (objfile::~objfile): Don't destroy psymbol_cache.
1577         * mdebugread.c (parse_partial_symbols): Update.
1578         * dwarf2read.c (create_addrmap_from_index)
1579         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1580         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1581         (add_partial_subprogram, dwarf2_ranges_read): Update.
1582         * dwarf-index-write.c (write_address_map)
1583         (write_one_signatured_type, recursively_write_psymbols)
1584         (class debug_names, class debug_names, write_psymtabs_to_index):
1585         Update.
1586
1587 2019-01-10  Tom Tromey  <tom@tromey.com>
1588
1589         * symtab.h (SYMBOL_SET_NAMES): Update.
1590         (symbol_set_names): Update.
1591         (MSYMBOL_SET_NAMES): Update.
1592         * symtab.c (symbol_set_names): Change argument to be an
1593         objfile_per_bfd_storage.
1594         * psymtab.c (add_psymbol_to_bcache): Update.
1595         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1596
1597 2019-01-10  Tom Tromey  <tom@tromey.com>
1598
1599         * symtab.c (create_demangled_names_hash): Change argument to be an
1600         objfile_per_bfd_storage.
1601         (symbol_set_names): Update.
1602
1603 2019-01-10  Tom Tromey  <tom@tromey.com>
1604
1605         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1606         init_psymbol_list.
1607         * psymtab.c (init_psymbol_list): Do nothing if already called.
1608         * psympriv.h (init_psymbol_list): Add comment.
1609         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1610         init_psymbol_list.
1611         * dbxread.c (dbx_symfile_read): Unconditionally call
1612         init_psymbol_list.
1613
1614 2019-01-10  Tom Tromey  <tom@tromey.com>
1615
1616         * xcoffread.c (scan_xcoff_symtab): Update.
1617         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1618         "where".
1619         * mdebugread.c (parse_partial_symbols)
1620         (handle_psymbol_enumerators): Update.
1621         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1622         * dbxread.c (read_dbx_symtab): Update.
1623         * psympriv.h (psymbol_placement): New enum.
1624         (add_psymbol_to_list): Update.
1625
1626 2019-01-10  Tom Tromey  <tom@tromey.com>
1627
1628         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1629         static_psymbols parameters.
1630         (scan_xcoff_symtab): Update.
1631         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1632         static_psymbols parameters.
1633         * psympriv.h (start_psymtab_common): Update.
1634         * mdebugread.c (parse_partial_symbols): Update.
1635         * dwarf2read.c (create_partial_symtab): Update.
1636         * dbxread.c (read_dbx_symtab): Update.
1637         (start_psymtab): Remove global_psymbols and static_psymbols
1638         parameters.
1639
1640 2019-01-10  Tom Tromey  <tom@tromey.com>
1641
1642         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1643         * psymtab.c (allocate_psymtab): Add comment.
1644         * psympriv.h (allocate_psymtab): Add comment.
1645         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1646         initializations.
1647         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1648
1649 2019-01-10  Tom Tromey  <tom@tromey.com>
1650
1651         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1652         Don't declare.
1653         * mipsread.c: Include mdebugread.h.
1654         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1655         Declare.
1656         * elfread.c: Include mdebugread.h.
1657
1658 2019-01-09  Tom Tromey  <tom@tromey.com>
1659
1660         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1661         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1662         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1663         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1664         (psym_lookup_symbol, psym_find_last_source_symtab)
1665         (psym_forget_cached_source_info, psym_print_stats)
1666         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1667         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1668         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1669         (psym_find_compunit_symtab_by_address)
1670         (maintenance_print_psymbols, maintenance_info_psymtabs)
1671         (maintenance_check_psymtabs): Use ranged for.
1672         * psymtab.h (class objfile_psymtabs): New.
1673         (require_partial_symbols): Return objfile_psymtabs.
1674         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1675
1676 2019-01-09  Tom Tromey  <tom@tromey.com>
1677
1678         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1679         (find_pc_mapped_section, list_overlays_command)
1680         (map_overlay_command, unmap_overlay_command)
1681         (simple_overlay_update): Use all_objfiles.
1682         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1683         * printcmd.c (info_symbol_command): Use all_objfiles.
1684         * objfiles.h (ALL_OBJSECTIONS): Remove.
1685         * maint.c (maintenance_translate_address): Use all_objfiles.
1686         * gcore.c (gcore_create_callback): Use all_objfiles.
1687         (objfile_find_memory_regions): Likewise.
1688
1689 2019-01-09  Tom Tromey  <tom@tromey.com>
1690
1691         * symtab.c (find_line_symtab, info_sources_command)
1692         (make_source_files_completion_list): Use objfile_compunits.
1693         * source.c (select_source_symtab): Use objfile_compunits.
1694         * objfiles.h (struct objfile): Update comment.
1695         (ALL_OBJFILES): Remove.
1696         (ALL_FILETABS): Remove.
1697         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
1698         objfile_compunits.
1699
1700 2019-01-09  Tom Tromey  <tom@tromey.com>
1701
1702         * symmisc.c (print_objfile_statistics, dump_objfile)
1703         (maintenance_print_symbols): Use compunit_filetabs.
1704         * source.c (forget_cached_source_info_for_objfile): Use
1705         compunit_filetabs.
1706         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
1707         (ALL_FILETABS): Use compunit_filetabs.
1708         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
1709         * coffread.c (coff_symtab_read): Use compunit_filetabs.
1710
1711 2019-01-09  Tom Tromey  <tom@tromey.com>
1712
1713         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
1714         (compunit_filetabs): New.
1715         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
1716         compunit_filetabs.
1717         (info_sources_command, make_source_files_completion_list): Remove
1718         declaration.
1719         * symmisc.c (print_objfile_statistics, dump_objfile)
1720         (maintenance_print_symbols): Remove declaration.
1721         (maintenance_info_symtabs): Use compunit_filetabs.
1722         (maintenance_info_line_tables): Likewise.
1723         * source.c (select_source_symtab): Change local variable name.
1724         (forget_cached_source_info_for_objfile): Remove declaration.
1725         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
1726         * objfiles.c (objfile_relocate1): Remove declaration.
1727         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1728         declaration.
1729         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
1730         * coffread.c (coff_symtab_read): Remove declaration.
1731         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1732         compunit_filetabs.
1733
1734 2019-01-09  Tom Tromey  <tom@tromey.com>
1735
1736         * symtab.c (lookup_objfile_from_block)
1737         (find_pc_sect_compunit_symtab, search_symbols)
1738         (default_collect_symbol_completion_matches_break_on): Use
1739         objfile_compunits.
1740         * objfiles.h (ALL_COMPUNITS): Remove.
1741         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
1742         * cp-support.c (add_symbol_overload_list_qualified): Use
1743         objfile_compunits.
1744         * ada-lang.c (ada_collect_symbol_completion_matches)
1745         (ada_add_global_exceptions): Use objfile_compunits.
1746
1747 2019-01-09  Tom Tromey  <tom@tromey.com>
1748
1749         * source.c (select_source_symtab)
1750         (forget_cached_source_info_for_objfile): Remove declaration.
1751         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1752         declaration.
1753         * maint.c (count_symtabs_and_blocks): Remove declaration.
1754         * cp-support.c (add_symbol_overload_list_qualified): Remove
1755         declaration.
1756         * coffread.c (coff_symtab_read): Remove declaration.
1757         * symtab.c (lookup_symbol_in_objfile_symtabs)
1758         (basic_lookup_transparent_type_1): Use objfile_compunits.
1759         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
1760         (info_sources_command, search_symbols)
1761         (default_collect_symbol_completion_matches_break_on)
1762         (make_source_files_completion_list): Remove declaration.
1763         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
1764         (ada_collect_symbol_completion_matches)
1765         (ada_add_global_exceptions): Remove declaration.
1766         * linespec.c (iterate_over_all_matching_symtabs): Use
1767         objfile_compunits.
1768         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
1769         (class objfile_compunits): New.
1770         (ALL_COMPUNITS): Use objfile_compunits.
1771         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
1772         (maintenance_check_symtabs, maintenance_info_line_tables): Use
1773         objfile_compunits.
1774         * objfiles.c (objfile_relocate1): Use objfile_compunits.
1775
1776 2019-01-09  Tom Tromey  <tom@tromey.com>
1777
1778         * symtab.c (search_symbols)
1779         (default_collect_symbol_completion_matches_break_on): Use
1780         objfile_msymbols.
1781         * ada-lang.c (ada_lookup_simple_minsym)
1782         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
1783         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
1784         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
1785         objfile_msymbols.
1786         * coffread.c (coff_symfile_read): Use objfile_msymbols.
1787         * symmisc.c (dump_msymbols): Use objfile_msymbols.
1788         * objc-lang.c (find_methods): Use objfile_msymbols.
1789         (info_selectors_command, info_classes_command): Likewise.
1790         * stabsread.c (scan_file_globals): Use objfile_msymbols.
1791         * objfiles.h (class objfile_msymbols): New.
1792         (ALL_OBJFILE_MSYMBOLS): Remove.
1793         (ALL_MSYMBOLS): Remove.
1794
1795 2019-01-09  Tom Tromey  <tom@tromey.com>
1796
1797         * common/next-iterator.h (next_adapter): Add Iterator template
1798         parameter.
1799         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
1800         (class all_objfiles_safe): New.
1801         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
1802         * objfiles.c (put_objfile_before): Update comment.
1803         (add_separate_debug_objfile): Likewise.
1804         (free_all_objfiles): Use all_objfiles_safe.
1805         (objfile_purge_solibs): Likewise.
1806
1807 2019-01-09  Tom Tromey  <tom@tromey.com>
1808
1809         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1810         (expand_symtab_containing_pc, lookup_static_symbol)
1811         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
1812         (find_symbol_at_address, find_line_symtab, find_main_name): Use
1813         all_objfiles.
1814         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
1815         * breakpoint.c (create_overlay_event_breakpoint)
1816         (create_longjmp_master_breakpoint)
1817         (create_std_terminate_master_breakpoint)
1818         (create_exception_master_breakpoint): Use all_objfiles.
1819         * linux-thread-db.c (try_thread_db_load_from_pdir)
1820         (has_libpthread): Use all_objfiles.
1821         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
1822         * linespec.c (iterate_over_all_matching_symtabs)
1823         (search_minsyms_for_name): Use all_objfiles.
1824         * maint.c (maintenance_info_sections): Use all_objfiles.
1825         * main.c (captured_main_1): Use all_objfiles.
1826         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
1827         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
1828         * guile/scm-pretty-print.c
1829         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
1830         * solib-spu.c (append_ocl_sos): Use all_objfiles.
1831         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
1832         (maintenance_print_msymbols): Use all_objfiles.
1833         * source.c (select_source_symtab): Use all_objfiles.
1834         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
1835         * symfile.c (remove_symbol_file_command)
1836         (expand_symtabs_matching, map_symbol_filenames): Use
1837         all_objfiles.
1838         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
1839         all_objfiles.
1840         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
1841         * objc-lang.c (find_methods): Use all_objfiles.
1842         * objfiles.c (have_partial_symbols, have_full_symbols)
1843         (have_minimal_symbols, qsort_cmp)
1844         (default_iterate_over_objfiles_in_search_order): Use
1845         all_objfiles.
1846         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
1847         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
1848         (maintenance_check_psymtabs): Use all_objfiles.
1849         (ALL_PSYMTABS): Remove.
1850         * compile/compile-object-run.c (do_module_cleanup): Use
1851         all_objfiles.
1852         * blockframe.c (find_pc_partial_function): Use all_objfiles.
1853         * cp-support.c (add_symbol_overload_list_qualified): Use
1854         all_objfiles.
1855         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1856         Use all_objfiles.
1857         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
1858         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
1859         all_objfiles.
1860         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1861         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
1862         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1863         Uses all_objfiles.
1864         * solib.c (solib_read_symbols): Use all_objfiles
1865
1866 2019-01-09  Tom Tromey  <tom@tromey.com>
1867
1868         * probe.c (parse_probes_in_pspace): Use all_objfiles.
1869         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
1870         all_objfiles.
1871         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
1872         * symmisc.c (print_symbol_bcache_statistics)
1873         (print_objfile_statistics, maintenance_print_objfiles)
1874         (maintenance_info_symtabs, maintenance_check_symtabs)
1875         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
1876         all_objfiles.
1877         * source.c (forget_cached_source_info): Use all_objfiles.
1878         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
1879         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1880         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
1881         * objfiles.c (update_section_map): Use all_objfiles.
1882         (shared_objfile_contains_address_p): Likewise.
1883         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
1884         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
1885
1886 2019-01-09  Tom Tromey  <tom@tromey.com>
1887
1888         * common/next-iterator.h: New file.
1889         * objfiles.h (class all_objfiles): New.
1890         (struct objfile_iterator): New.
1891
1892 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1893
1894         * NEWS: Move the description of the changed "frame", "select-frame",
1895          and "info frame" commands to the Changed commands section.
1896
1897 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
1898
1899         * gdbtypes.c (check_stub_method_group): Remove handling of old
1900         mangling schemes.
1901         * linespec.c (find_methods): Likewise.
1902         * stabsread.c (read_member_functions): Likewise.
1903         * valops.c (search_struct_method): Likewise.
1904         (value_struct_elt_for_reference): Likewise.
1905         * NEWS: Mention this change.
1906
1907 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1908
1909         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
1910         print_source_lines.
1911         * source.c (print_source_lines_base): Update line number check.
1912         (print_source_lines): New function.
1913         (source_lines_range::source_lines_range): New function.
1914         * source.h (class source_lines_range): New class.
1915         (print_source_lines): New declaration.
1916
1917 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1918
1919         * linespec.c (linespec_state_destructor): Free self->canonical_names.
1920
1921 2019-01-08  Tom Tromey  <tom@tromey.com>
1922             Simon Marchi  <simon.marchi@ericsson.com>
1923
1924         PR gdb/24060
1925         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
1926         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
1927         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1928         * f-exp.y (DOLLAR_VARIABLE): Likewise.
1929         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
1930         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1931
1932 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1933
1934         * source.c (select_source_symtab): Move header comment to
1935         declaration in source.h.
1936         (forget_cached_source_info_for_objfile): Likewise.
1937         (forget_cached_source_info): Likewise.
1938         (identify_source_line): Likewise.
1939         * source.h (identify_source_line): Move declaration from symtab.h
1940         and add comment from source.c
1941         (print_source_lines): Likewise.
1942         (forget_cached_source_info_for_objfile): Likewise.
1943         (forget_cached_source_info): Likewise.
1944         (select_source_symtab): Likewise.
1945         (enum print_source_lines_flag): Move definition from symtab.h.
1946         * symtab.h (identify_source_line): Move declaration to source.h.
1947         (print_source_lines): Likewise.
1948         (forget_cached_source_info_for_objfile): Likewise.
1949         (forget_cached_source_info): Likewise.
1950         (select_source_symtab): Likewise.
1951         (enum print_source_lines_flag): Move definition to source.h.
1952         * tui/tui-hooks.c: Add 'source.h' include.
1953
1954 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1955
1956         * source.c (print_source_lines_base): Handle requests to print
1957         reverse line number sequences, and guard against empty lines
1958         string.
1959
1960 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1961
1962         * source.c (print_source_lines_base): Fix skip of '\r' if next
1963         character is '\n'.
1964
1965 2019-01-06  Tom Tromey  <tom@tromey.com>
1966
1967         * c-exp.y (struct c_parse_state) <macro_original_text,
1968         expansion_obstack>: New member.
1969         (macro_original_text, expansion_obstack): Remove globals.
1970         (scan_macro_expansion, scanning_macro_expansion)
1971         (finished_macro_expansion): Update.
1972         (scan_macro_cleanup): Remove.
1973         (yylex, c_parse): Update.
1974
1975 2019-01-06  Tom Tromey  <tom@tromey.com>
1976
1977         * c-exp.y (struct c_parse_state) <strings>: New member.
1978         (operator_stoken): Update.
1979
1980 2019-01-06  Tom Tromey  <tom@tromey.com>
1981
1982         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
1983         (union type_stack_elt) <typelist_val>: Now a pointer to
1984         std::vector.
1985         (type_stack_cleanup): Don't declare.
1986         (push_typelist): Update.
1987         * parse.c (pop_typelist): Return a std::vector.
1988         (push_typelist): Take a std::vector.
1989         (follow_types): Update.  Do not free args.
1990         (type_stack_cleanup): Remove.
1991         * c-exp.y (struct c_parse_state): New.
1992         (cpstate): New global.
1993         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
1994         (nonempty_typelist): Update.
1995         (func_mod): Create a new vector.
1996         (c_parse): Create a c_parse_state.
1997         (check_parameter_typelist): Do not delete params.
1998         (function_method): Update.  Do not delete type_list.
1999
2000 2019-01-06  Tom Tromey  <tom@tromey.com>
2001
2002         PR gdb/28155:
2003         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2004         check_typedef.
2005         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2006         (print_return_value): Likewise.
2007
2008 2019-01-05  Tom Tromey  <tom@tromey.com>
2009
2010         * contrib/cleanup_check.py: Remove.
2011         * contrib/gcc-with-excheck: Remove.
2012         * contrib/exsummary.py: Remove.
2013         * contrib/excheck.py: Remove.
2014
2015 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2016
2017         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2018         NULL. Initialize tpprev to NULL instead of assigning it
2019         to NULL on the next statement.
2020         * windows-nat.c (windows_delete_thread): Remove check for
2021         main_thread_id before printing thread exit notifications.
2022         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2023         Remove thread ID check against main_thread_id.
2024         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2025         windows_delete_thread.
2026         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2027
2028 2019-01-04  Tom Tromey  <tom@tromey.com>
2029
2030         * compile/compile.c (_initialize_compile): Use upper case for
2031         metasyntactic variables.
2032         * symmisc.c (_initialize_symmisc): Use upper case for
2033         metasyntactic variables.
2034         * psymtab.c (_initialize_psymtab): Use upper case for
2035         metasyntactic variables.
2036         * demangle.c (demangle_command): Use upper case for metasyntactic
2037         variables.
2038         (_initialize_demangler): Likewise.
2039         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2040         variables.
2041
2042 2019-01-03  Tom Tromey  <tom@tromey.com>
2043
2044         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2045
2046 2019-01-03  Tom Tromey  <tom@tromey.com>
2047
2048         * python/py-symtab.c (salpy_str): Update.
2049         (struct salpy_sal_object) <symtab>: Now a PyObject.
2050         (salpy_dealloc): Update.
2051         (del_objfile_sal): Use gdbpy_ref.
2052
2053 2019-01-03  Tom Tromey  <tom@tromey.com>
2054
2055         * python/py-type.c (convert_field): Use new_reference.  Return
2056         gdbpy_ref.
2057         (make_fielditem): Return gdbpy_ref.
2058         (typy_fields): Update.
2059         (typy_getitem): Update.
2060         (field_name): Return gdbpy_ref.  Use new_reference.
2061         (typy_iterator_iternext): Update.
2062
2063 2019-01-03  Tom Tromey  <tom@tromey.com>
2064
2065         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2066
2067 2019-01-03  Tom Tromey  <tom@tromey.com>
2068
2069         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2070         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2071         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2072         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2073         (pspy_set_type_printers): Likewise.
2074         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2075         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2076         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2077         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2078         (objfpy_set_type_printers): Likewise.
2079
2080 2019-01-03  Tom Tromey  <tom@tromey.com>
2081
2082         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2083         (gdbpy_print_stack): Use gdbpy_err_fetch.
2084         * python/python-internal.h (class gdbpy_err_fetch): New class.
2085         (class gdbpy_enter) <m_error_type, m_error_value,
2086         m_error_traceback>: Remove.
2087         <m_error>: New member.
2088         (gdbpy_exception_to_string): Don't declare.
2089         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2090         * python/py-value.c (convert_value_from_python): Use
2091         gdbpy_err_fetch.
2092         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2093         gdbpy_exception_to_string.
2094         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2095         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2096         gdbpy_err_fetch.
2097
2098 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2099
2100         * linux-nat.c (delete_lwp_cleanup): Delete.
2101         (struct lwp_deleter): New struct.
2102         (lwp_info_up): New typedef.
2103         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2104         lwp_info_up.
2105
2106 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2107
2108         * linux-fork.c (class scoped_switch_fork_info): New class.
2109         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2110
2111 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2112
2113         * valops.c (find_overload_match): Remove use of null_cleanup, and
2114         calls to do_cleanups.
2115
2116 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2117
2118         * compile/compile-cplus-types.c
2119         (compile_cplus_instance::decl_name): Handle changes to
2120         cp_func_name.
2121         * cp-support.c (cp_func_name): Update header comment, update
2122         return type.
2123         * cp-support.h (cp_func_name): Update return type in declaration.
2124         * valops.c (find_overload_match): Move temp_func local to top
2125         level of function and change its type.  Use temp_func to hold and
2126         delete temporary string obtained from cp_func_name.
2127
2128 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2129
2130         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2131         gdb::char_vector, remove cleanup, and update uses of `msg`.
2132
2133 2019-01-03  Jim Wilson  <jimw@sifive.com>
2134
2135         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2136
2137 2019-01-02  Tom Tromey  <tom@tromey.com>
2138
2139         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2140         (tdesc_parse_xml): Remove cleanups.
2141         * target-descriptions.h (make_cleanup_free_target_description):
2142         Don't declare.
2143         (target_desc_deleter): New struct.
2144         (target_desc_up): New typedef.
2145         * target-descriptions.c (target_desc_deleter::operator()): Rename
2146         from free_target_description.
2147         (make_cleanup_free_target_description): Remove.
2148
2149 2019-01-02  Tom Tromey  <tom@tromey.com>
2150
2151         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2152         constructor, destructor.
2153         (linespec_parser): Remove typedef.
2154         (~linespec_parser): Rename from linespec_parser_delete.
2155         (linespec_lex_to_end, linespec_complete_label)
2156         (linespec_complete): Update.
2157         (decode_line_full): Remove cleanups.
2158         (decode_line_1): Update.
2159
2160 2019-01-02  Tom Tromey  <tom@tromey.com>
2161
2162         * python/python-internal.h (inferior_to_inferior_object): Change
2163         return type.
2164         * python/py-exitedevent.c (create_exited_event_object): Update.
2165         * python/py-inferior.c (inferior_to_inferior_object): Return
2166         gdbpy_ref.
2167         (python_new_inferior, python_inferior_deleted)
2168         (thread_to_thread_object, delete_thread_object)
2169         (build_inferior_list, gdbpy_selected_inferior): Update.
2170         * python/py-infthread.c (create_thread_object): Update.  Also fail
2171         if inferior_to_inferior_object fails.
2172
2173 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2174
2175         * inferior.h (class inferior) <displaced_step_state>: New field.
2176         * infrun.h (struct displaced_step_state): Move here from
2177         infrun.c.  Initialize fields, add constructor.
2178         <inf>: Remove field.
2179         <reset>: New method.
2180         * infrun.c (struct displaced_step_inferior_state): Move to
2181         infrun.h.
2182         (displaced_step_inferior_states): Remove.
2183         (get_displaced_stepping_state): Adust.
2184         (displaced_step_in_progress_any_inferior): Adjust.
2185         (displaced_step_in_progress_thread): Adjust.
2186         (displaced_step_in_progress): Adjust.
2187         (add_displaced_stepping_state): Remove.
2188         (get_displaced_step_closure_by_addr): Adjust.
2189         (remove_displaced_stepping_state): Remove.
2190         (infrun_inferior_exit): Call displaced_step_state.reset.
2191         (use_displaced_stepping): Don't check for NULL.
2192         (displaced_step_prepare_throw): Call
2193         get_displaced_stepping_state.
2194         (displaced_step_fixup): Don't check for NULL.
2195         (prepare_for_detach): Don't check for NULL.
2196
2197 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2198
2199         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2200          in case of call that did not complete.
2201
2202 2019-01-02  Andrey Utkin  <autkin@undo.io>
2203
2204         * symfile.c (find_separate_debug_file): Fix search of debug files for
2205         remote debuggee.
2206
2207 2019-01-02  Tom Tromey  <tom@tromey.com>
2208
2209         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2210         indentation.
2211         * python/py-frame.c (frapy_older): Remove cast.
2212         (frapy_newer): Likewise.
2213         * python/py-breakpoint.c (local_setattro): Remove cast.
2214         * python/py-arch.c (archpy_name): Remove local variable.
2215         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2216
2217 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2218
2219         * unittests/basic_string_view/element_access/char/empty.cc:
2220         Fix year range in copyright header.
2221
2222 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2223
2224         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2225         Delete.
2226         <operator==>: Update with for removed field.
2227         <hash>: Likewise.
2228         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2229         <isa_features>: ...this.
2230         <abi_features>: New field.
2231         (riscv_isa_flen): Update comment.
2232         (riscv_abi_xlen): New declaration.
2233         (riscv_abi_flen): New declaration.
2234         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2235         isa_features.
2236         (riscv_abi_xlen): New function.
2237         (riscv_isa_flen): Update to get answer from isa_features.
2238         (riscv_abi_flen): New function.
2239         (riscv_has_fp_abi): Update to get answer from abi_features.
2240         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2241         xlen and flen.
2242         (riscv_call_info) <xlen, flen>: Update comment.
2243         (riscv_call_arg_struct): Remove invalid assertions
2244         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2245         is removed.
2246         (riscv_gdbarch_init): Gather isa features and abi features
2247         separately, ensure both match on the gdbarch when reusing an old
2248         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2249         a target with 64-bit float hardware.
2250
2251 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2252
2253         * source.c (search_command_helper): Stop reverse search
2254         when line 1 has been searched.
2255
2256 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2257
2258         * record-full.c (record_full_base_target::close): Rewrite
2259         record_full_core_buf_list free logic.
2260
2261 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2262
2263         * break-catch-syscall.c (print_one_catch_syscall): xfree
2264         the last text.
2265
2266 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2267
2268         * top.c (print_gdb_version): Update Copyright year in version
2269         message.
2270
2271 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2272
2273         Update copyright year range in all GDB files.
2274
2275 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2276
2277         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2278
2279 For older changes see ChangeLog-2018.
2280 \f
2281 Local Variables:
2282 mode: change-log
2283 left-margin: 8
2284 fill-column: 74
2285 version-control: never
2286 coding: utf-8
2287 End:
2288