gdb/ChangeLog

   1 2019-01-22  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-wingeneral.h: Include gdb_curses.h.
   4
   5 2019-01-22  Tom Tromey  <tom@tromey.com>
   6
   7         * source-cache.h (class source_cache) <get_source_lines,
   8         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
   9
  10 2019-01-22  Tom Tromey  <tom@tromey.com>
  11
  12         * remote-fileio.h (struct remote_target): Declare.
  13
  14 2019-01-22  Tom Tromey  <tom@tromey.com>
  15
  16         * python/py-arch.c: Do not include py-ref.h.
  17         * python/py-bpevent.c: Do not include py-ref.h.
  18         * python/py-cmd.c: Do not include py-ref.h.
  19         * python/py-continueevent.c: Do not include py-ref.h.
  20         * python/py-event.h: Do not include py-ref.h.
  21         * python/py-evtregistry.c: Do not include py-ref.h.
  22         * python/py-finishbreakpoint.c: Do not include py-ref.h.
  23         * python/py-frame.c: Do not include py-ref.h.
  24         * python/py-framefilter.c: Do not include py-ref.h.
  25         * python/py-function.c: Do not include py-ref.h.
  26         * python/py-infevents.c: Do not include py-ref.h.
  27         * python/py-linetable.c: Do not include py-ref.h.
  28         * python/py-objfile.c: Do not include py-ref.h.
  29         * python/py-param.c: Do not include py-ref.h.
  30         * python/py-prettyprint.c: Do not include py-ref.h.
  31         * python/py-progspace.c: Do not include py-ref.h.
  32         * python/py-symbol.c: Do not include py-ref.h.
  33         * python/py-symtab.c: Do not include py-ref.h.
  34         * python/py-type.c: Do not include py-ref.h.
  35         * python/py-unwind.c: Do not include py-ref.h.
  36         * python/py-utils.c: Do not include py-ref.h.
  37         * python/py-value.c: Do not include py-ref.h.
  38         * python/py-varobj.c: Do not include py-ref.h.
  39         * python/py-xmethods.c: Do not include py-ref.h.
  40         * python/python.c: Do not include py-ref.h.
  41         * varobj.c: Do not include py-ref.h.
  42
  43 2019-01-22  Tom Tromey  <tom@tromey.com>
  44
  45         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
  46         keyword for bcache.
  47
  48 2019-01-22  Tom Tromey  <tom@tromey.com>
  49
  50         * compile/compile-cplus-types.c: Remove a comment by #include.
  51
  52 2019-01-22  Tom Tromey  <tom@tromey.com>
  53
  54         * compile/gcc-c-plugin.h: Include compile-internal.h.
  55
  56 2019-01-22  Tom Tromey  <tom@tromey.com>
  57
  58         * stabsread.c (EXTERN): Do not define.
  59         (symnum, next_symbol_text_func, processing_gcc_compilation)
  60         (within_function, global_sym_chain, global_stabs)
  61         (previous_stab_code, this_object_header_files)
  62         (n_this_object_header_files)
  63         (n_allocated_this_object_header_files): Define.
  64         * stabsread.h (EXTERN): Never define.  Use "extern".
  65
  66 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  67
  68         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
  69         history_value.
  70
  71 2019-01-21  Tom Tromey  <tom@tromey.com>
  72
  73         * ui-out.c: Fix includes.
  74         * tui/tui-source.c: Fix includes.
  75         * target.c: Fix includes.
  76         * remote.c: Fix includes.
  77         * regcache.c: Fix includes.
  78         * python/py-block.c: Fix includes.
  79         * printcmd.c: Fix includes.
  80         * or1k-tdep.c: Fix includes.
  81         * mi/mi-main.c: Fix includes.
  82         * m32r-tdep.c: Fix includes.
  83         * csky-tdep.c: Fix includes.
  84         * compile/compile-cplus-types.c: Fix includes.
  85         * cli/cli-interp.c: Fix includes.
  86
  87 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
  88
  89         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
  90         for padding.
  91
  92 2019-01-16  Tom Tromey  <tom@tromey.com>
  93
  94         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
  95         earlier.
  96         (struct objfile) <msymbols_range>: Move from top level.
  97         <msymbols>: New method.
  98         (class objfile_msymbols): Remove.
  99         * symtab.c (default_collect_symbol_completion_matches_break_on):
 100         Update.
 101         * symmisc.c (dump_msymbols): Update.
 102         * stabsread.c (scan_file_globals): Update.
 103         * objc-lang.c (info_selectors_command, info_classes_command)
 104         (find_methods): Update.
 105         * minsyms.c (find_solib_trampoline_target): Update.
 106         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
 107         * coffread.c (coff_symfile_read): Update.
 108         * ada-lang.c (ada_lookup_simple_minsym)
 109         (ada_collect_symbol_completion_matches): Update.
 110
 111 2019-01-16  Tom Tromey  <tom@tromey.com>
 112
 113         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
 114         type.  Remove no-argument constructor.
 115         <iterator::operator++>: Simplify.
 116         <begin>: Update.
 117         <end>: Use minimal_symbol_count.
 118
 119 2019-01-16  Tom Tromey  <tom@tromey.com>
 120
 121         * objfiles.h (struct objfile) <psymtabs>: New method.
 122         (class objfile_psymtabs): Remove.
 123         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
 124         typedef.
 125         <range>: New method.
 126         (require_partial_symbols): Change return type.
 127         * psymtab.c (require_partial_symbols)
 128         (psym_expand_symtabs_matching): Update.
 129         * mdebugread.c (parse_partial_symbols): Update.
 130         * dbxread.c (dbx_end_psymtab): Update.
 131
 132 2019-01-15  Tom Tromey  <tom@tromey.com>
 133
 134         * symtab.c (lookup_objfile_from_block)
 135         (lookup_symbol_in_objfile_symtabs)
 136         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
 137         (find_line_symtab, info_sources_command)
 138         (default_collect_symbol_completion_matches_break_on)
 139         (make_source_files_completion_list): Update.
 140         * symmisc.c (print_objfile_statistics, dump_objfile)
 141         (maintenance_print_symbols, maintenance_info_symtabs)
 142         (maintenance_check_symtabs, maintenance_info_line_tables):
 143         Update.
 144         * source.c (select_source_symtab)
 145         (forget_cached_source_info_for_objfile): Update.
 146         * objfiles.h (class objfile_compunits): Remove.
 147         (struct objfile) <compunits_range>: New typedef.
 148         (compunits): New method.
 149         * objfiles.c (objfile_relocate1): Update.
 150         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
 151         * maint.c (count_symtabs_and_blocks): Update.
 152         * linespec.c (iterate_over_all_matching_symtabs): Update.
 153         * cp-support.c (add_symbol_overload_list_qualified): Update.
 154         * coffread.c (coff_symtab_read): Update.
 155         * ada-lang.c (add_nonlocal_symbols)
 156         (ada_collect_symbol_completion_matches)
 157         (ada_add_global_exceptions): Update.
 158
 159 2019-01-15  Tom Tromey  <tom@tromey.com>
 160
 161         * progspace.h (program_space) <objfiles_safe_range>: New
 162         typedef.
 163         <objfiles_safe>: New method.
 164         * objfiles.h (class all_objfiles_safe): Remove.
 165         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
 166         * jit.c (jit_inferior_exit_hook): Update.
 167
 168 2019-01-17  Tom Tromey  <tom@tromey.com>
 169
 170         * progspace.h (program_space) <objfiles_range>: New typedef.
 171         <objfiles>: New method.
 172         <objfiles_head>: Rename from objfiles.
 173         (object_files): Update.
 174         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
 175         * guile/scm-pretty-print.c
 176         (ppscm_find_pretty_printer_from_objfiles): Update.
 177         * guile/scm-objfile.c (gdbscm_objfiles): Update.
 178         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
 179         Update.
 180         * python/py-progspace.c (pspy_get_objfiles): Update.
 181         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
 182         Update.
 183         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
 184         (objfpy_lookup_objfile_by_build_id): Update.
 185         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
 186         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
 187         Update.
 188         * symtab.c (iterate_over_symtabs, matching_obj_sections)
 189         (expand_symtab_containing_pc, lookup_objfile_from_block)
 190         (lookup_static_symbol, basic_lookup_transparent_type)
 191         (find_pc_sect_compunit_symtab, find_symbol_at_address)
 192         (find_line_symtab, info_sources_command)
 193         (default_collect_symbol_completion_matches_break_on)
 194         (make_source_files_completion_list, find_main_name): Update.
 195         * symmisc.c (print_symbol_bcache_statistics)
 196         (print_objfile_statistics, maintenance_print_symbols)
 197         (maintenance_print_msymbols, maintenance_print_objfiles)
 198         (maintenance_info_symtabs, maintenance_check_symtabs)
 199         (maintenance_expand_symtabs, maintenance_info_line_tables):
 200         Update.
 201         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
 202         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
 203         (map_overlay_command, unmap_overlay_command)
 204         (simple_overlay_update, expand_symtabs_matching)
 205         (map_symbol_filenames): Update.
 206         * symfile-debug.c (set_debug_symfile): Update.
 207         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
 208         Update.
 209         * source.c (select_source_symtab, forget_cached_source_info):
 210         Update.
 211         * solib.c (solib_read_symbols): Update.
 212         * solib-spu.c (append_ocl_sos): Update.
 213         * psymtab.c (maintenance_print_psymbols)
 214         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
 215         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
 216         * printcmd.c (info_symbol_command): Update.
 217         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
 218         Update.
 219         * objfiles.h (class all_objfiles): Remove.
 220         * objfiles.c (have_partial_symbols, have_full_symbols)
 221         (have_minimal_symbols, qsort_cmp, update_section_map)
 222         (shared_objfile_contains_address_p)
 223         (default_iterate_over_objfiles_in_search_order): Update.
 224         * objc-lang.c (info_selectors_command, info_classes_command)
 225         (find_methods): Update.
 226         * minsyms.c (find_solib_trampoline_target): Update.
 227         * maint.c (maintenance_info_sections)
 228         (maintenance_translate_address, count_symtabs_and_blocks):
 229         Update.
 230         * main.c (captured_main_1): Update.
 231         * linux-thread-db.c (try_thread_db_load_from_pdir)
 232         (has_libpthread): Update.
 233         * linespec.c (iterate_over_all_matching_symtabs)
 234         (search_minsyms_for_name): Update.
 235         * jit.c (jit_find_objf_with_entry_addr): Update.
 236         * hppa-tdep.c (find_unwind_entry)
 237         (hppa_lookup_stub_minimal_symbol): Update.
 238         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
 239         Update.
 240         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
 241         (elf_gnu_ifunc_resolve_by_got): Update.
 242         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
 243         * dwarf-index-write.c (save_gdb_index_command): Update.
 244         * cp-support.c (add_symbol_overload_list_qualified): Update.
 245         * breakpoint.c (create_overlay_event_breakpoint)
 246         (create_longjmp_master_breakpoint)
 247         (create_std_terminate_master_breakpoint)
 248         (create_exception_master_breakpoint): Update.
 249         * blockframe.c (find_pc_partial_function): Update.
 250         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
 251         (ada_collect_symbol_completion_matches)
 252         (ada_add_global_exceptions): Update.
 253
 254 2019-01-17  Tom Tromey  <tom@tromey.com>
 255
 256         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
 257         declare VEC.
 258         (solib_target_parse_libraries): Change return type.
 259         (library_list_start_segment, library_list_start_section)
 260         (library_list_end_library, library_list_start_library); Update.
 261         (solib_target_free_library_list): Remove.
 262         (solib_target_parse_libraries): Remove cleanup.  Change return
 263         type.
 264         (solib_target_current_sos): Update.
 265
 266 2019-01-17  Tom Tromey  <tromey@bapiya>
 267
 268         * valprint.c: Replace "the the" with "the".
 269         * symtab.c: Replace "the the" with "the".
 270         * solib.c: Replace "the the" with "the".
 271         * solib-dsbt.c: Replace "the the" with "the".
 272         * linespec.c: Replace "the the" with "the".
 273         * dwarf2loc.h: Replace "the the" with "the".
 274         * amd64-windows-tdep.c: Replace "the the" with "the".
 275         * aarch64-tdep.c: Replace "the the" with "the".
 276
 277 2019-01-16  Keith Seitz  <keiths@redhat.com>
 278
 279         PR gdb/23773
 280         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
 281         <builder>: Rename to ..
 282         <m_builder>: ... this and make private.
 283         (dwarf2_cu::get_builder): New method.  Change all users of
 284         `builder' to use this method.
 285         (dwarf2_start_symtab): Move to ...
 286         (dwarf2_cu::start_symtab): ... here.  Update all callers
 287         (setup_type_unit_groups): Move to ...
 288         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
 289         callers.
 290         (dwarf2_cu::reset_builder): New method.
 291         (process_full_compunit, process_full_type_unit): Use
 292         dwarf2_cu::reset_builder.
 293         (follow_die_offset): Record the ancestor CU if it is different
 294         from the followed DIE's CU.
 295         (follow_die_sig_1): Likewise.
 296
 297 2019-01-15  Tom Tromey  <tom@tromey.com>
 298
 299         * remote.c (class remote_state) <buf>: Now a char_vector.
 300         <buf_size>: Remove.
 301         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
 302         parameter.
 303         (remote_target::getpkt_or_notif_sane_1)
 304         (remote_target::getpkt_sane)
 305         (remote_target::getpkt_or_notif_sane): Likewise.
 306         (class remote_target) <putpkt>: New overload.
 307         (remote_target::read_frame): Change type of "buf_p".  Remove
 308         sizeof_p parameter.
 309         (packet_ok): New overload.
 310         (packet_check_result): New overload.
 311         Update all uses.
 312
 313 2019-01-14  Tom Tromey  <tom@tromey.com>
 314
 315         * remote-notif.c (handle_notification, remote_notif_ack)
 316         (remote_notif_parse): Make "buf" const.
 317         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
 318         const.
 319         (remote_notif_parse, remote_notif_ack, handle_notification):
 320         Likewise.
 321         * remote.c (remote_notif_stop_parse): Make "buf" const.
 322         (remote_target::remote_parse_stop_reply): Make "buf" const.
 323         (remote_notif_stop_ack): Make "buf" const.
 324
 325 2019-01-14  Tom Tromey  <tom@tromey.com>
 326
 327         * remote.c (remote_console_output): Make parameter const.
 328
 329 2019-01-14  Tom Tromey  <tom@tromey.com>
 330
 331         * target-debug.h (target_debug_print_signals): Constify.
 332         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
 333         * procfs.c (procfs_target::pass_signals): Update.
 334         * linux-nat.c (linux_nat_target::pass_signals): Update.
 335         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
 336         * target-delegates.c: Rebuild.
 337         * remote.c (remote_target::program_signals): Update.
 338         (remote_target::pass_signals): Update.
 339         * target.c (target_pass_signals): Constify argument.
 340         (target_program_signals): Likewise.
 341         * target.h (struct target_ops) <pass_signals, program_signals>:
 342         Constify argument.
 343         (target_pass_signals, target_program_signals): Constify argument.
 344
 345 2019-01-14  Tom Tromey  <tom@tromey.com>
 346
 347         PR tui/28819:
 348         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
 349
 350 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 351
 352         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
 353         field.
 354         * rs6000-tdep.c: Include reggroups.h.
 355         (IS_V_ALIAS_PSEUDOREG): Define.
 356         (rs6000_register_name): Return names for the "vX" aliases.
 357         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
 358         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
 359         aliases.  Call default_register_reggroup_p for all other
 360         pseudo-registers.
 361         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
 362         New functions.
 363         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
 364         Handle "vX" aliases.
 365         (v_alias_pseudo_register_collect): New function.
 366         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
 367         (rs6000_gdbarch_init): Initialize "vX" aliases as
 368         pseudo-registers.  Restore registration of
 369         rs6000_pseudo_register_reggroup_p with
 370         set_tdesc_pseudo_register_reggroup_p.
 371
 372 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
 373
 374         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
 375         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
 376         set_gdbarch_num_pseudo_regs.
 377
 378 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 379
 380         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
 381         Remove arg prefixname, add do_set and do_show.
 382         Add member functions set_list and show_list.
 383         * cli/cli-style.c (class cli_style_option): Update accordingly.
 384         (style_set_list): Move to file scope.
 385         (style_show_list): Likewise.
 386         (set_style): Call help_list.
 387         (show_style): Call cmd_show_list.
 388         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
 389         Update to use the new macro.
 390
 391 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
 392
 393         * ada-lang.c (_initialize_ada_language): Expand the help text
 394         for the "catch exception" command.
 395
 396 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 397
 398         * symtab.c (matching_obj_sections): Initialize obj,
 399         declare it closer to its usage.
 400
 401 2019-01-10  Tom Tromey  <tom@tromey.com>
 402
 403         * thread-iter.h (inf_threads_iterator): Use next_iterator.
 404         (basic_inf_threads_range): Remove.
 405         (inf_threads_range, inf_non_exited_threads_range)
 406         (safe_inf_threads_range): Use next_adapter.
 407
 408 2019-01-10  Keith Seitz  <keiths@redhat.com>
 409
 410         PR gdb/23712
 411         PR symtab/23010
 412         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
 413         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
 414
 415 2019-01-10  Keith Seitz  <keiths@redhat.com>
 416
 417         PR gdb/23712
 418         PR symtab/23010
 419         * dictionary.c (pending_to_vector): Remove.
 420         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 421         Remove _1 suffix, replacing functions of the same name.  Update
 422         all callers.
 423         (dict_create_hashed, dict_create_hashed_expandable)
 424         (dict_create_linear, dict_create_linear_expandable, dict_free)
 425         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
 426         Make functions static.
 427
 428 2019-01-10  Keith Seitz  <keiths@redhat.com>
 429
 430         PR gdb/23712
 431         PR symtab/23010
 432         * dictionary.h (struct dictionary): Replace declaration with
 433         multidictionary.
 434         (dict_create_hashed, dict_create_hashed_expandable)
 435         (dict_create_linear, dict_create_linear_expandable)
 436         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
 437         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
 438         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
 439         taking multidictionary argument.
 440         [ALL_DICT_SYMBOLS]: Update for multidictionary.
 441         * block.h (struct block) <dict>: Change to multidictionary
 442         and rename `multidict'.
 443         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
 444         symmisc.c: Update all dictionary references to multidictionary.
 445
 446 2019-01-10  Keith Seitz  <keiths@redhat.com>
 447
 448         PR gdb/23712
 449         PR symtab/23010
 450         * dictionary.c: Include unordered_map.
 451         (pending_to_vector): New function.
 452         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 453         Rewrite the non-"_1" functions to take vector instead
 454         of linked list.
 455         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
 456         "new" _1 versions of the same name.
 457         (multidictionary): Define.
 458         (std::hash<enum language): New definition.
 459         (collate_pending_symbols_by_language, mdict_create_hashed)
 460         (mdict_create_hashed_expandable, mdict_create_linear)
 461         (mdict_create_linear_expandable, mdict_free)
 462         (find_language_dictionary, create_new_language_dictionary)
 463         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
 464         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
 465         (mdict_size, mdict_empty): New functions.
 466         * dictionary.h (mdict_iterator): Define.
 467
 468 2019-01-10  Pedro Alves  <palves@redhat.com>
 469
 470         * breakpoint.c (read_uploaded_action)
 471         (create_tracepoint_from_upload): Adjust to use
 472         gdb::unique_xmalloc_ptr.
 473         * ctf.c (ctf_write_uploaded_tp):
 474         (SET_ARRAY_FIELD): Use emplace_back.
 475         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
 476         * tracefile-tfile.c (tfile_write_uploaded_tp):
 477         * tracepoint.c (parse_tracepoint_definition): Adjust to use
 478         gdb::unique_xmalloc_ptr.
 479         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
 480         at_string, cond_string, cmd_strings>: Replace char pointers
 481         with gdb::unique_xmalloc_ptr.
 482
 483 2019-01-10  Pedro Alves  <palves@redhat.com>
 484
 485         * solib-target.c (library_list_start_library): Don't xstrdup name.
 486
 487 2019-01-10  Pedro Alves  <palves@redhat.com>
 488
 489         * mdebugread.c (parse_partial_symbols): Use
 490         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
 491
 492 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 493
 494         * linux-fork.c (scoped_switch_fork_info)
 495         <~scoped_switch_fork_info>: Fix incorrect variable name.
 496
 497 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 498
 499         * linux-fork.c (scoped_switch_fork_info)
 500         <scoped_switch_fork_info>: Make explicit.
 501         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
 502
 503 2019-01-10  Tom Tromey  <tom@tromey.com>
 504
 505         * objfiles.h (objfile::reset_psymtabs): Update.
 506         * objfiles.c (objfile::objfile): Update.
 507         * psymtab.h (psymtab_storage::obstack): Update.
 508         (psymtab_storage::m_obstack): Use gdb::optional.
 509         (class psymtab_storage): Update comment.  Remove objfile
 510         parameter.
 511         * psymtab.c (psymtab_storage::psymtab_storage): Update.
 512
 513 2019-01-10  Tom Tromey  <tom@tromey.com>
 514
 515         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
 516         <free_psymtabs>: Now private.
 517         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
 518         (allocate_psymtab): Use new method.
 519
 520 2019-01-10  Tom Tromey  <tom@tromey.com>
 521
 522         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
 523         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
 524         * mdebugread.c (parse_partial_symbols): Use
 525         allocate_dependencies.
 526         * dwarf2read.c (dwarf2_create_include_psymtab): Use
 527         allocate_dependencies.
 528         (process_psymtab_comp_unit_reader)
 529         (build_type_psymtab_dependencies): Likewise.
 530         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
 531
 532 2019-01-10  Tom Tromey  <tom@tromey.com>
 533
 534         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
 535         PSYMBOL_SET_LANGUAGE.
 536         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
 537
 538 2019-01-10  Tom Tromey  <tom@tromey.com>
 539
 540         * psymtab.h (psymtab_storage::obstack): New method.
 541         <m_obstack>: Rename from obstack; now private.
 542         * psymtab.c (psymtab_storage): Update.
 543         * dwarf2read.c (create_addrmap_from_index)
 544         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
 545         Update.
 546
 547 2019-01-10  Tom Tromey  <tom@tromey.com>
 548
 549         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
 550         * objfiles.h (objfile::reset_psymtabs): New method.
 551
 552 2019-01-10  Tom Tromey  <tom@tromey.com>
 553
 554         * symmisc.c (print_symbol_bcache_statistics): Update.
 555         (print_objfile_statistics): Update.
 556         * symfile.c (reread_symbols): Update.
 557         * psymtab.h (class psymtab_storage): New.
 558         * psymtab.c (psymtab_storage): New constructor.
 559         (~psymtab_storage): New destructor.
 560         (require_partial_symbols): Update.
 561         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
 562         (find_pc_sect_psymtab, find_pc_sect_psymbol)
 563         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
 564         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
 565         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
 566         (start_psymtab_common, end_psymtab_common)
 567         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
 568         (allocate_psymtab): Update.
 569         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
 570         Update.
 571         (dump_psymtab_addrmap, maintenance_print_psymbols)
 572         (maintenance_check_psymtabs): Update.
 573         (class objfile_psymtabs): Move to objfiles.h.
 574         * psympriv.h (discard_psymtab): Now inline.
 575         (psymtab_discarder::psymtab_discarder): Update.
 576         (psymtab_discarder::~psymtab_discarder): Update.
 577         (ALL_OBJFILE_PSYMTABS): Rewrite.
 578         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
 579         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
 580         Remove fields.
 581         <partial_symtabs>: New field.
 582         (class objfile_psymtabs): Move from psymtab.h.  Update.
 583         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
 584         psymbol_cache.
 585         (objfile::~objfile): Don't destroy psymbol_cache.
 586         * mdebugread.c (parse_partial_symbols): Update.
 587         * dwarf2read.c (create_addrmap_from_index)
 588         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
 589         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
 590         (add_partial_subprogram, dwarf2_ranges_read): Update.
 591         * dwarf-index-write.c (write_address_map)
 592         (write_one_signatured_type, recursively_write_psymbols)
 593         (class debug_names, class debug_names, write_psymtabs_to_index):
 594         Update.
 595
 596 2019-01-10  Tom Tromey  <tom@tromey.com>
 597
 598         * symtab.h (SYMBOL_SET_NAMES): Update.
 599         (symbol_set_names): Update.
 600         (MSYMBOL_SET_NAMES): Update.
 601         * symtab.c (symbol_set_names): Change argument to be an
 602         objfile_per_bfd_storage.
 603         * psymtab.c (add_psymbol_to_bcache): Update.
 604         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
 605
 606 2019-01-10  Tom Tromey  <tom@tromey.com>
 607
 608         * symtab.c (create_demangled_names_hash): Change argument to be an
 609         objfile_per_bfd_storage.
 610         (symbol_set_names): Update.
 611
 612 2019-01-10  Tom Tromey  <tom@tromey.com>
 613
 614         * xcoffread.c (xcoff_initial_scan): Unconditionally call
 615         init_psymbol_list.
 616         * psymtab.c (init_psymbol_list): Do nothing if already called.
 617         * psympriv.h (init_psymbol_list): Add comment.
 618         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
 619         init_psymbol_list.
 620         * dbxread.c (dbx_symfile_read): Unconditionally call
 621         init_psymbol_list.
 622
 623 2019-01-10  Tom Tromey  <tom@tromey.com>
 624
 625         * xcoffread.c (scan_xcoff_symtab): Update.
 626         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
 627         "where".
 628         * mdebugread.c (parse_partial_symbols)
 629         (handle_psymbol_enumerators): Update.
 630         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
 631         * dbxread.c (read_dbx_symtab): Update.
 632         * psympriv.h (psymbol_placement): New enum.
 633         (add_psymbol_to_list): Update.
 634
 635 2019-01-10  Tom Tromey  <tom@tromey.com>
 636
 637         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
 638         static_psymbols parameters.
 639         (scan_xcoff_symtab): Update.
 640         * psymtab.c (start_psymtab_common): Remove global_psymbols and
 641         static_psymbols parameters.
 642         * psympriv.h (start_psymtab_common): Update.
 643         * mdebugread.c (parse_partial_symbols): Update.
 644         * dwarf2read.c (create_partial_symtab): Update.
 645         * dbxread.c (read_dbx_symtab): Update.
 646         (start_psymtab): Remove global_psymbols and static_psymbols
 647         parameters.
 648
 649 2019-01-10  Tom Tromey  <tom@tromey.com>
 650
 651         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
 652         * psymtab.c (allocate_psymtab): Add comment.
 653         * psympriv.h (allocate_psymtab): Add comment.
 654         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
 655         initializations.
 656         * dbxread.c (dbx_end_psymtab): Remove some initializations.
 657
 658 2019-01-10  Tom Tromey  <tom@tromey.com>
 659
 660         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
 661         Don't declare.
 662         * mipsread.c: Include mdebugread.h.
 663         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
 664         Declare.
 665         * elfread.c: Include mdebugread.h.
 666
 667 2019-01-09  Tom Tromey  <tom@tromey.com>
 668
 669         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
 670         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
 671         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
 672         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
 673         (psym_lookup_symbol, psym_find_last_source_symtab)
 674         (psym_forget_cached_source_info, psym_print_stats)
 675         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
 676         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
 677         (psym_map_matching_symbols, psym_expand_symtabs_matching)
 678         (psym_find_compunit_symtab_by_address)
 679         (maintenance_print_psymbols, maintenance_info_psymtabs)
 680         (maintenance_check_psymtabs): Use ranged for.
 681         * psymtab.h (class objfile_psymtabs): New.
 682         (require_partial_symbols): Return objfile_psymtabs.
 683         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
 684
 685 2019-01-09  Tom Tromey  <tom@tromey.com>
 686
 687         * symfile.c (overlay_invalidate_all, find_pc_overlay)
 688         (find_pc_mapped_section, list_overlays_command)
 689         (map_overlay_command, unmap_overlay_command)
 690         (simple_overlay_update): Use all_objfiles.
 691         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
 692         * printcmd.c (info_symbol_command): Use all_objfiles.
 693         * objfiles.h (ALL_OBJSECTIONS): Remove.
 694         * maint.c (maintenance_translate_address): Use all_objfiles.
 695         * gcore.c (gcore_create_callback): Use all_objfiles.
 696         (objfile_find_memory_regions): Likewise.
 697
 698 2019-01-09  Tom Tromey  <tom@tromey.com>
 699
 700         * symtab.c (find_line_symtab, info_sources_command)
 701         (make_source_files_completion_list): Use objfile_compunits.
 702         * source.c (select_source_symtab): Use objfile_compunits.
 703         * objfiles.h (struct objfile): Update comment.
 704         (ALL_OBJFILES): Remove.
 705         (ALL_FILETABS): Remove.
 706         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
 707         objfile_compunits.
 708
 709 2019-01-09  Tom Tromey  <tom@tromey.com>
 710
 711         * symmisc.c (print_objfile_statistics, dump_objfile)
 712         (maintenance_print_symbols): Use compunit_filetabs.
 713         * source.c (forget_cached_source_info_for_objfile): Use
 714         compunit_filetabs.
 715         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
 716         (ALL_FILETABS): Use compunit_filetabs.
 717         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
 718         * coffread.c (coff_symtab_read): Use compunit_filetabs.
 719
 720 2019-01-09  Tom Tromey  <tom@tromey.com>
 721
 722         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
 723         (compunit_filetabs): New.
 724         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
 725         compunit_filetabs.
 726         (info_sources_command, make_source_files_completion_list): Remove
 727         declaration.
 728         * symmisc.c (print_objfile_statistics, dump_objfile)
 729         (maintenance_print_symbols): Remove declaration.
 730         (maintenance_info_symtabs): Use compunit_filetabs.
 731         (maintenance_info_line_tables): Likewise.
 732         * source.c (select_source_symtab): Change local variable name.
 733         (forget_cached_source_info_for_objfile): Remove declaration.
 734         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
 735         * objfiles.c (objfile_relocate1): Remove declaration.
 736         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
 737         declaration.
 738         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
 739         * coffread.c (coff_symtab_read): Remove declaration.
 740         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 741         compunit_filetabs.
 742
 743 2019-01-09  Tom Tromey  <tom@tromey.com>
 744
 745         * symtab.c (lookup_objfile_from_block)
 746         (find_pc_sect_compunit_symtab, search_symbols)
 747         (default_collect_symbol_completion_matches_break_on): Use
 748         objfile_compunits.
 749         * objfiles.h (ALL_COMPUNITS): Remove.
 750         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
 751         * cp-support.c (add_symbol_overload_list_qualified): Use
 752         objfile_compunits.
 753         * ada-lang.c (ada_collect_symbol_completion_matches)
 754         (ada_add_global_exceptions): Use objfile_compunits.
 755
 756 2019-01-09  Tom Tromey  <tom@tromey.com>
 757
 758         * source.c (select_source_symtab)
 759         (forget_cached_source_info_for_objfile): Remove declaration.
 760         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
 761         declaration.
 762         * maint.c (count_symtabs_and_blocks): Remove declaration.
 763         * cp-support.c (add_symbol_overload_list_qualified): Remove
 764         declaration.
 765         * coffread.c (coff_symtab_read): Remove declaration.
 766         * symtab.c (lookup_symbol_in_objfile_symtabs)
 767         (basic_lookup_transparent_type_1): Use objfile_compunits.
 768         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
 769         (info_sources_command, search_symbols)
 770         (default_collect_symbol_completion_matches_break_on)
 771         (make_source_files_completion_list): Remove declaration.
 772         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
 773         (ada_collect_symbol_completion_matches)
 774         (ada_add_global_exceptions): Remove declaration.
 775         * linespec.c (iterate_over_all_matching_symtabs): Use
 776         objfile_compunits.
 777         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
 778         (class objfile_compunits): New.
 779         (ALL_COMPUNITS): Use objfile_compunits.
 780         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
 781         (maintenance_check_symtabs, maintenance_info_line_tables): Use
 782         objfile_compunits.
 783         * objfiles.c (objfile_relocate1): Use objfile_compunits.
 784
 785 2019-01-09  Tom Tromey  <tom@tromey.com>
 786
 787         * symtab.c (search_symbols)
 788         (default_collect_symbol_completion_matches_break_on): Use
 789         objfile_msymbols.
 790         * ada-lang.c (ada_lookup_simple_minsym)
 791         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
 792         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
 793         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
 794         objfile_msymbols.
 795         * coffread.c (coff_symfile_read): Use objfile_msymbols.
 796         * symmisc.c (dump_msymbols): Use objfile_msymbols.
 797         * objc-lang.c (find_methods): Use objfile_msymbols.
 798         (info_selectors_command, info_classes_command): Likewise.
 799         * stabsread.c (scan_file_globals): Use objfile_msymbols.
 800         * objfiles.h (class objfile_msymbols): New.
 801         (ALL_OBJFILE_MSYMBOLS): Remove.
 802         (ALL_MSYMBOLS): Remove.
 803
 804 2019-01-09  Tom Tromey  <tom@tromey.com>
 805
 806         * common/next-iterator.h (next_adapter): Add Iterator template
 807         parameter.
 808         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
 809         (class all_objfiles_safe): New.
 810         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
 811         * objfiles.c (put_objfile_before): Update comment.
 812         (add_separate_debug_objfile): Likewise.
 813         (free_all_objfiles): Use all_objfiles_safe.
 814         (objfile_purge_solibs): Likewise.
 815
 816 2019-01-09  Tom Tromey  <tom@tromey.com>
 817
 818         * symtab.c (iterate_over_symtabs, matching_obj_sections)
 819         (expand_symtab_containing_pc, lookup_static_symbol)
 820         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
 821         (find_symbol_at_address, find_line_symtab, find_main_name): Use
 822         all_objfiles.
 823         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
 824         * breakpoint.c (create_overlay_event_breakpoint)
 825         (create_longjmp_master_breakpoint)
 826         (create_std_terminate_master_breakpoint)
 827         (create_exception_master_breakpoint): Use all_objfiles.
 828         * linux-thread-db.c (try_thread_db_load_from_pdir)
 829         (has_libpthread): Use all_objfiles.
 830         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
 831         * linespec.c (iterate_over_all_matching_symtabs)
 832         (search_minsyms_for_name): Use all_objfiles.
 833         * maint.c (maintenance_info_sections): Use all_objfiles.
 834         * main.c (captured_main_1): Use all_objfiles.
 835         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
 836         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
 837         * guile/scm-pretty-print.c
 838         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
 839         * solib-spu.c (append_ocl_sos): Use all_objfiles.
 840         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
 841         (maintenance_print_msymbols): Use all_objfiles.
 842         * source.c (select_source_symtab): Use all_objfiles.
 843         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
 844         * symfile.c (remove_symbol_file_command)
 845         (expand_symtabs_matching, map_symbol_filenames): Use
 846         all_objfiles.
 847         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
 848         all_objfiles.
 849         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
 850         * objc-lang.c (find_methods): Use all_objfiles.
 851         * objfiles.c (have_partial_symbols, have_full_symbols)
 852         (have_minimal_symbols, qsort_cmp)
 853         (default_iterate_over_objfiles_in_search_order): Use
 854         all_objfiles.
 855         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
 856         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
 857         (maintenance_check_psymtabs): Use all_objfiles.
 858         (ALL_PSYMTABS): Remove.
 859         * compile/compile-object-run.c (do_module_cleanup): Use
 860         all_objfiles.
 861         * blockframe.c (find_pc_partial_function): Use all_objfiles.
 862         * cp-support.c (add_symbol_overload_list_qualified): Use
 863         all_objfiles.
 864         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
 865         Use all_objfiles.
 866         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
 867         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
 868         all_objfiles.
 869         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
 870         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
 871         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
 872         Uses all_objfiles.
 873         * solib.c (solib_read_symbols): Use all_objfiles
 874
 875 2019-01-09  Tom Tromey  <tom@tromey.com>
 876
 877         * probe.c (parse_probes_in_pspace): Use all_objfiles.
 878         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
 879         all_objfiles.
 880         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
 881         * symmisc.c (print_symbol_bcache_statistics)
 882         (print_objfile_statistics, maintenance_print_objfiles)
 883         (maintenance_info_symtabs, maintenance_check_symtabs)
 884         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
 885         all_objfiles.
 886         * source.c (forget_cached_source_info): Use all_objfiles.
 887         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
 888         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
 889         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
 890         * objfiles.c (update_section_map): Use all_objfiles.
 891         (shared_objfile_contains_address_p): Likewise.
 892         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
 893         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
 894
 895 2019-01-09  Tom Tromey  <tom@tromey.com>
 896
 897         * common/next-iterator.h: New file.
 898         * objfiles.h (class all_objfiles): New.
 899         (struct objfile_iterator): New.
 900
 901 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 902
 903         * NEWS: Move the description of the changed "frame", "select-frame",
 904          and "info frame" commands to the Changed commands section.
 905
 906 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
 907
 908         * gdbtypes.c (check_stub_method_group): Remove handling of old
 909         mangling schemes.
 910         * linespec.c (find_methods): Likewise.
 911         * stabsread.c (read_member_functions): Likewise.
 912         * valops.c (search_struct_method): Likewise.
 913         (value_struct_elt_for_reference): Likewise.
 914         * NEWS: Mention this change.
 915
 916 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 917
 918         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
 919         print_source_lines.
 920         * source.c (print_source_lines_base): Update line number check.
 921         (print_source_lines): New function.
 922         (source_lines_range::source_lines_range): New function.
 923         * source.h (class source_lines_range): New class.
 924         (print_source_lines): New declaration.
 925
 926 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 927
 928         * linespec.c (linespec_state_destructor): Free self->canonical_names.
 929
 930 2019-01-08  Tom Tromey  <tom@tromey.com>
 931             Simon Marchi  <simon.marchi@ericsson.com>
 932
 933         PR gdb/24060
 934         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
 935         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
 936         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
 937         * f-exp.y (DOLLAR_VARIABLE): Likewise.
 938         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
 939         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
 940
 941 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 942
 943         * source.c (select_source_symtab): Move header comment to
 944         declaration in source.h.
 945         (forget_cached_source_info_for_objfile): Likewise.
 946         (forget_cached_source_info): Likewise.
 947         (identify_source_line): Likewise.
 948         * source.h (identify_source_line): Move declaration from symtab.h
 949         and add comment from source.c
 950         (print_source_lines): Likewise.
 951         (forget_cached_source_info_for_objfile): Likewise.
 952         (forget_cached_source_info): Likewise.
 953         (select_source_symtab): Likewise.
 954         (enum print_source_lines_flag): Move definition from symtab.h.
 955         * symtab.h (identify_source_line): Move declaration to source.h.
 956         (print_source_lines): Likewise.
 957         (forget_cached_source_info_for_objfile): Likewise.
 958         (forget_cached_source_info): Likewise.
 959         (select_source_symtab): Likewise.
 960         (enum print_source_lines_flag): Move definition to source.h.
 961         * tui/tui-hooks.c: Add 'source.h' include.
 962
 963 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 964
 965         * source.c (print_source_lines_base): Handle requests to print
 966         reverse line number sequences, and guard against empty lines
 967         string.
 968
 969 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 970
 971         * source.c (print_source_lines_base): Fix skip of '\r' if next
 972         character is '\n'.
 973
 974 2019-01-06  Tom Tromey  <tom@tromey.com>
 975
 976         * c-exp.y (struct c_parse_state) <macro_original_text,
 977         expansion_obstack>: New member.
 978         (macro_original_text, expansion_obstack): Remove globals.
 979         (scan_macro_expansion, scanning_macro_expansion)
 980         (finished_macro_expansion): Update.
 981         (scan_macro_cleanup): Remove.
 982         (yylex, c_parse): Update.
 983
 984 2019-01-06  Tom Tromey  <tom@tromey.com>
 985
 986         * c-exp.y (struct c_parse_state) <strings>: New member.
 987         (operator_stoken): Update.
 988
 989 2019-01-06  Tom Tromey  <tom@tromey.com>
 990
 991         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
 992         (union type_stack_elt) <typelist_val>: Now a pointer to
 993         std::vector.
 994         (type_stack_cleanup): Don't declare.
 995         (push_typelist): Update.
 996         * parse.c (pop_typelist): Return a std::vector.
 997         (push_typelist): Take a std::vector.
 998         (follow_types): Update.  Do not free args.
 999         (type_stack_cleanup): Remove.
1000         * c-exp.y (struct c_parse_state): New.
1001         (cpstate): New global.
1002         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
1003         (nonempty_typelist): Update.
1004         (func_mod): Create a new vector.
1005         (c_parse): Create a c_parse_state.
1006         (check_parameter_typelist): Do not delete params.
1007         (function_method): Update.  Do not delete type_list.
1008
1009 2019-01-06  Tom Tromey  <tom@tromey.com>
1010
1011         PR gdb/28155:
1012         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
1013         check_typedef.
1014         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
1015         (print_return_value): Likewise.
1016
1017 2019-01-05  Tom Tromey  <tom@tromey.com>
1018
1019         * contrib/cleanup_check.py: Remove.
1020         * contrib/gcc-with-excheck: Remove.
1021         * contrib/exsummary.py: Remove.
1022         * contrib/excheck.py: Remove.
1023
1024 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
1025
1026         * thread.c (delete_thread_1): Add gdb_assert that THR is not
1027         NULL. Initialize tpprev to NULL instead of assigning it
1028         to NULL on the next statement.
1029         * windows-nat.c (windows_delete_thread): Remove check for
1030         main_thread_id before printing thread exit notifications.
1031         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
1032         Remove thread ID check against main_thread_id.
1033         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
1034         windows_delete_thread.
1035         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
1036
1037 2019-01-04  Tom Tromey  <tom@tromey.com>
1038
1039         * compile/compile.c (_initialize_compile): Use upper case for
1040         metasyntactic variables.
1041         * symmisc.c (_initialize_symmisc): Use upper case for
1042         metasyntactic variables.
1043         * psymtab.c (_initialize_psymtab): Use upper case for
1044         metasyntactic variables.
1045         * demangle.c (demangle_command): Use upper case for metasyntactic
1046         variables.
1047         (_initialize_demangler): Likewise.
1048         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
1049         variables.
1050
1051 2019-01-03  Tom Tromey  <tom@tromey.com>
1052
1053         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
1054
1055 2019-01-03  Tom Tromey  <tom@tromey.com>
1056
1057         * python/py-symtab.c (salpy_str): Update.
1058         (struct salpy_sal_object) <symtab>: Now a PyObject.
1059         (salpy_dealloc): Update.
1060         (del_objfile_sal): Use gdbpy_ref.
1061
1062 2019-01-03  Tom Tromey  <tom@tromey.com>
1063
1064         * python/py-type.c (convert_field): Use new_reference.  Return
1065         gdbpy_ref.
1066         (make_fielditem): Return gdbpy_ref.
1067         (typy_fields): Update.
1068         (typy_getitem): Update.
1069         (field_name): Return gdbpy_ref.  Use new_reference.
1070         (typy_iterator_iternext): Update.
1071
1072 2019-01-03  Tom Tromey  <tom@tromey.com>
1073
1074         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
1075
1076 2019-01-03  Tom Tromey  <tom@tromey.com>
1077
1078         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
1079         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
1080         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
1081         (pspy_set_frame_filters, pspy_set_frame_unwinders)
1082         (pspy_set_type_printers): Likewise.
1083         * python/py-function.c (fnpy_init): Use gdbpy_ref.
1084         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
1085         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
1086         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
1087         (objfpy_set_type_printers): Likewise.
1088
1089 2019-01-03  Tom Tromey  <tom@tromey.com>
1090
1091         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
1092         (gdbpy_print_stack): Use gdbpy_err_fetch.
1093         * python/python-internal.h (class gdbpy_err_fetch): New class.
1094         (class gdbpy_enter) <m_error_type, m_error_value,
1095         m_error_traceback>: Remove.
1096         <m_error>: New member.
1097         (gdbpy_exception_to_string): Don't declare.
1098         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
1099         * python/py-value.c (convert_value_from_python): Use
1100         gdbpy_err_fetch.
1101         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
1102         gdbpy_exception_to_string.
1103         (gdbpy_handle_exception): Use gdbpy_err_fetch.
1104         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1105         gdbpy_err_fetch.
1106
1107 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1108
1109         * linux-nat.c (delete_lwp_cleanup): Delete.
1110         (struct lwp_deleter): New struct.
1111         (lwp_info_up): New typedef.
1112         (linux_nat_target::follow_fork): Delete cleanup, and make use of
1113         lwp_info_up.
1114
1115 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1116
1117         * linux-fork.c (class scoped_switch_fork_info): New class.
1118         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
1119
1120 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1121
1122         * valops.c (find_overload_match): Remove use of null_cleanup, and
1123         calls to do_cleanups.
1124
1125 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1126
1127         * compile/compile-cplus-types.c
1128         (compile_cplus_instance::decl_name): Handle changes to
1129         cp_func_name.
1130         * cp-support.c (cp_func_name): Update header comment, update
1131         return type.
1132         * cp-support.h (cp_func_name): Update return type in declaration.
1133         * valops.c (find_overload_match): Move temp_func local to top
1134         level of function and change its type.  Use temp_func to hold and
1135         delete temporary string obtained from cp_func_name.
1136
1137 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1138
1139         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
1140         gdb::char_vector, remove cleanup, and update uses of `msg`.
1141
1142 2019-01-03  Jim Wilson  <jimw@sifive.com>
1143
1144         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
1145
1146 2019-01-02  Tom Tromey  <tom@tromey.com>
1147
1148         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
1149         (tdesc_parse_xml): Remove cleanups.
1150         * target-descriptions.h (make_cleanup_free_target_description):
1151         Don't declare.
1152         (target_desc_deleter): New struct.
1153         (target_desc_up): New typedef.
1154         * target-descriptions.c (target_desc_deleter::operator()): Rename
1155         from free_target_description.
1156         (make_cleanup_free_target_description): Remove.
1157
1158 2019-01-02  Tom Tromey  <tom@tromey.com>
1159
1160         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
1161         constructor, destructor.
1162         (linespec_parser): Remove typedef.
1163         (~linespec_parser): Rename from linespec_parser_delete.
1164         (linespec_lex_to_end, linespec_complete_label)
1165         (linespec_complete): Update.
1166         (decode_line_full): Remove cleanups.
1167         (decode_line_1): Update.
1168
1169 2019-01-02  Tom Tromey  <tom@tromey.com>
1170
1171         * python/python-internal.h (inferior_to_inferior_object): Change
1172         return type.
1173         * python/py-exitedevent.c (create_exited_event_object): Update.
1174         * python/py-inferior.c (inferior_to_inferior_object): Return
1175         gdbpy_ref.
1176         (python_new_inferior, python_inferior_deleted)
1177         (thread_to_thread_object, delete_thread_object)
1178         (build_inferior_list, gdbpy_selected_inferior): Update.
1179         * python/py-infthread.c (create_thread_object): Update.  Also fail
1180         if inferior_to_inferior_object fails.
1181
1182 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
1183
1184         * inferior.h (class inferior) <displaced_step_state>: New field.
1185         * infrun.h (struct displaced_step_state): Move here from
1186         infrun.c.  Initialize fields, add constructor.
1187         <inf>: Remove field.
1188         <reset>: New method.
1189         * infrun.c (struct displaced_step_inferior_state): Move to
1190         infrun.h.
1191         (displaced_step_inferior_states): Remove.
1192         (get_displaced_stepping_state): Adust.
1193         (displaced_step_in_progress_any_inferior): Adjust.
1194         (displaced_step_in_progress_thread): Adjust.
1195         (displaced_step_in_progress): Adjust.
1196         (add_displaced_stepping_state): Remove.
1197         (get_displaced_step_closure_by_addr): Adjust.
1198         (remove_displaced_stepping_state): Remove.
1199         (infrun_inferior_exit): Call displaced_step_state.reset.
1200         (use_displaced_stepping): Don't check for NULL.
1201         (displaced_step_prepare_throw): Call
1202         get_displaced_stepping_state.
1203         (displaced_step_fixup): Don't check for NULL.
1204         (prepare_for_detach): Don't check for NULL.
1205
1206 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1207
1208         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
1209          in case of call that did not complete.
1210
1211 2019-01-02  Andrey Utkin  <autkin@undo.io>
1212
1213         * symfile.c (find_separate_debug_file): Fix search of debug files for
1214         remote debuggee.
1215
1216 2019-01-02  Tom Tromey  <tom@tromey.com>
1217
1218         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
1219         indentation.
1220         * python/py-frame.c (frapy_older): Remove cast.
1221         (frapy_newer): Likewise.
1222         * python/py-breakpoint.c (local_setattro): Remove cast.
1223         * python/py-arch.c (archpy_name): Remove local variable.
1224         * python/py-type.c (gdbpy_lookup_type): Remove cast.
1225
1226 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
1227
1228         * unittests/basic_string_view/element_access/char/empty.cc:
1229         Fix year range in copyright header.
1230
1231 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1232
1233         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
1234         Delete.
1235         <operator==>: Update with for removed field.
1236         <hash>: Likewise.
1237         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
1238         <isa_features>: ...this.
1239         <abi_features>: New field.
1240         (riscv_isa_flen): Update comment.
1241         (riscv_abi_xlen): New declaration.
1242         (riscv_abi_flen): New declaration.
1243         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
1244         isa_features.
1245         (riscv_abi_xlen): New function.
1246         (riscv_isa_flen): Update to get answer from isa_features.
1247         (riscv_abi_flen): New function.
1248         (riscv_has_fp_abi): Update to get answer from abi_features.
1249         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
1250         xlen and flen.
1251         (riscv_call_info) <xlen, flen>: Update comment.
1252         (riscv_call_arg_struct): Remove invalid assertions
1253         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
1254         is removed.
1255         (riscv_gdbarch_init): Gather isa features and abi features
1256         separately, ensure both match on the gdbarch when reusing an old
1257         gdbarch.  Relax an error check to allow 32-bit abi float to run on
1258         a target with 64-bit float hardware.
1259
1260 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1261
1262         * source.c (search_command_helper): Stop reverse search
1263         when line 1 has been searched.
1264
1265 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1266
1267         * record-full.c (record_full_base_target::close): Rewrite
1268         record_full_core_buf_list free logic.
1269
1270 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1271
1272         * break-catch-syscall.c (print_one_catch_syscall): xfree
1273         the last text.
1274
1275 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1276
1277         * top.c (print_gdb_version): Update Copyright year in version
1278         message.
1279
1280 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1281
1282         Update copyright year range in all GDB files.
1283
1284 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
1285
1286         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
1287
1288 For older changes see ChangeLog-2018.
1289 \f
1290 Local Variables:
1291 mode: change-log
1292 left-margin: 8
1293 fill-column: 74
1294 version-control: never
1295 coding: utf-8
1296 End:
1297