gdb/ChangeLog

   1 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
   2
   3         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
   4         (check_empty): Use "const char *".
   5
   6         * gnu-nat.c (gnu_nat_target::detach): Instead of
   7         'detach_inferior (pid)' call
   8         'detach_inferior (find_inferior_pid (pid))'.
   9
  10         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
  11         'nat/fork-inferior.o'.
  12         * gnu-nat.c: #include "nat/fork-inferior.h".
  13
  14         * gnu-nat.c (gnu_nat_target::detach): Instead of
  15         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
  16         * gnu-nat.h: #include "inf-child.h".
  17         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
  18         'i386_gnu_nat_target::fetch_registers'.
  19         (gnu_store_registers): Rename/move to
  20         'i386_gnu_nat_target::store_registers'.
  21
  22         * config/i386/nm-i386gnu.h: Don't "#include" any files.
  23         * gnu-nat.h (mach_thread_info): New function.
  24         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
  25
  26         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
  27
  28 2019-02-14  Frederic Konrad  <konrad@adacore.com>
  29
  30         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
  31
  32 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
  33
  34         * windows-nat.c (windows_add_thread): Add new parameter
  35         "main_thread_p" with default value set to false.  Update
  36         function documentation as well as all callers.
  37         (windows_delete_thread): Likewise.
  38         (fake_create_process): Update call to windows_add_thread.
  39         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
  40         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
  41         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
  42         call to windows_delete_thread.
  43
  44 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
  45
  46         * MAINTAINERS: Add Andrew Burgess as global maintainer.
  47
  48 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
  49
  50         * symfile.c (find_separate_debug_file): Use canonical path of
  51         sysroot with child_path instead of gdb_sysroot if it is valid.
  52
  53 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
  54
  55         * symfile.c (find_separate_debug_file): Use child_path to
  56         determine if an object file is under a sysroot.
  57
  58 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
  59
  60         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
  61         unittests/child-path-selftests.c.
  62         * common/pathstuff.c (child_path): New function.
  63         * common/pathstuff.h (child_path): New prototype.
  64         * unittests/child-path-selftests.c: New file.
  65
  66 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
  67
  68         * symfile.c (find_separate_debug_file): Look for separate debug
  69         files in debug directories under the sysroot.
  70
  71 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  72
  73         * symtab.h (struct minimal_symbol data_p): New const method.
  74         (struct minimal_symbol text_p): Likewise.
  75         * symtab.c (output_source_filename): Use file name style
  76         to print file name.
  77         (print_symbol_info): Likewise.
  78         (print_msymbol_info): Use address style to print addresses.
  79         Use function name style to print executable text symbols.
  80         (expand_symtab_containing_pc): Use data_p.
  81         (find_pc_sect_compunit_symtab): Likewise.
  82
  83 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  84
  85         * breakpoint.c (describe_other_breakpoints): Use address style
  86         to print addresses.
  87         (say_where): Likewise.
  88
  89 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  90
  91         * ada-typeprint.c (print_func_type): Print function name
  92         style to print function name.
  93         * c-typeprint.c (c_print_type_1): Likewise.
  94
  95 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
  96
  97         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
  98         for execve.
  99
 100 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 101
 102         * c-exp.y (direct_abs_decl): Use emplace_back to record the
 103         type_stack.
 104
 105 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
 106
 107         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
 108         TYPE_CODE_REF types.
 109
 110 2019-02-08  Jim Wilson  <jimw@sifive.com>
 111
 112         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
 113         (riscv_linux_fregset): New.
 114         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
 115
 116 2019-02-07  Tom Tromey  <tom@tromey.com>
 117
 118         * thread.c (thread_cancel_execution_command): Update.
 119         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
 120         methods.
 121         (struct thread_fsm_ops): Remove.
 122         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
 123         (thread_fsm_should_stop, thread_fsm_return_value)
 124         (thread_fsm_set_finished, thread_fsm_finished_p)
 125         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
 126         Don't declare.
 127         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
 128         * infrun.c (clear_proceed_status_thread)
 129         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
 130         (print_stop_event): Update.
 131         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
 132         Add constructor.
 133         (step_command_fsm_ops): Remove.
 134         (new_step_command_fsm): Remove.
 135         (step_1): Update.
 136         (step_command_fsm::should_stop): Rename from
 137         step_command_fsm_should_stop.
 138         (step_command_fsm::clean_up): Rename from
 139         step_command_fsm_clean_up.
 140         (step_command_fsm::do_async_reply_reason): Rename from
 141         step_command_fsm_async_reply_reason.
 142         (struct until_next_fsm): Inherit from thread_fsm.  Add
 143         constructor.
 144         (until_next_fsm_ops): Remove.
 145         (new_until_next_fsm): Remove.
 146         (until_next_fsm::should_stop): Rename from
 147         until_next_fsm_should_stop.
 148         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
 149         (until_next_fsm::do_async_reply_reason): Rename from
 150         until_next_fsm_async_reply_reason.
 151         (struct finish_command_fsm): Inherit from thread_fsm.  Add
 152         constructor.  Change type of breakpoint.
 153         (finish_command_fsm_ops): Remove.
 154         (new_finish_command_fsm): Remove.
 155         (finish_command_fsm::should_stop): Rename from
 156         finish_command_fsm_should_stop.
 157         (finish_command_fsm::clean_up): Rename from
 158         finish_command_fsm_clean_up.
 159         (finish_command_fsm::return_value): Rename from
 160         finish_command_fsm_return_value.
 161         (finish_command_fsm::do_async_reply_reason): Rename from
 162         finish_command_fsm_async_reply_reason.
 163         (finish_command): Update.
 164         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
 165         Add constructor.
 166         (call_thread_fsm_ops): Remove.
 167         (call_thread_fsm::call_thread_fsm): Rename from
 168         new_call_thread_fsm.
 169         (call_thread_fsm::should_stop): Rename from
 170         call_thread_fsm_should_stop.
 171         (call_thread_fsm::should_notify_stop): Rename from
 172         call_thread_fsm_should_notify_stop.
 173         (run_inferior_call, call_function_by_hand_dummy): Update.
 174         * cli/cli-interp.c (should_print_stop_to_console): Update.
 175         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
 176         Add constructor.  Change type of location_breakpoint,
 177         caller_breakpoint.
 178         (until_break_fsm_ops): Remove.
 179         (new_until_break_fsm): Remove.
 180         (until_break_fsm::should_stop): Rename from
 181         until_break_fsm_should_stop.
 182         (until_break_fsm::clean_up): Rename from
 183         until_break_fsm_clean_up.
 184         (until_break_fsm::do_async_reply_reason): Rename from
 185         until_break_fsm_async_reply_reason.
 186         (until_break_command): Update.
 187         * thread-fsm.c: Remove.
 188         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
 189
 190 2019-02-07  Tom Tromey  <tom@tromey.com>
 191
 192         * yy-remap.h: Add include guard.
 193         * xtensa-tdep.h: Add include guard.
 194         * xcoffread.h: Rename include guard.
 195         * varobj-iter.h: Add include guard.
 196         * tui/tui.h: Rename include guard.
 197         * tui/tui-winsource.h: Rename include guard.
 198         * tui/tui-wingeneral.h: Rename include guard.
 199         * tui/tui-windata.h: Rename include guard.
 200         * tui/tui-win.h: Rename include guard.
 201         * tui/tui-stack.h: Rename include guard.
 202         * tui/tui-source.h: Rename include guard.
 203         * tui/tui-regs.h: Rename include guard.
 204         * tui/tui-out.h: Rename include guard.
 205         * tui/tui-layout.h: Rename include guard.
 206         * tui/tui-io.h: Rename include guard.
 207         * tui/tui-hooks.h: Rename include guard.
 208         * tui/tui-file.h: Rename include guard.
 209         * tui/tui-disasm.h: Rename include guard.
 210         * tui/tui-data.h: Rename include guard.
 211         * tui/tui-command.h: Rename include guard.
 212         * tic6x-tdep.h: Add include guard.
 213         * target/waitstatus.h: Rename include guard.
 214         * target/wait.h: Rename include guard.
 215         * target/target.h: Rename include guard.
 216         * target/resume.h: Rename include guard.
 217         * target-float.h: Rename include guard.
 218         * stabsread.h: Add include guard.
 219         * rs6000-tdep.h: Add include guard.
 220         * riscv-fbsd-tdep.h: Add include guard.
 221         * regformats/regdef.h: Rename include guard.
 222         * record.h: Rename include guard.
 223         * python/python.h: Rename include guard.
 224         * python/python-internal.h: Rename include guard.
 225         * python/py-stopevent.h: Rename include guard.
 226         * python/py-ref.h: Rename include guard.
 227         * python/py-record.h: Rename include guard.
 228         * python/py-record-full.h: Rename include guard.
 229         * python/py-record-btrace.h: Rename include guard.
 230         * python/py-instruction.h: Rename include guard.
 231         * python/py-events.h: Rename include guard.
 232         * python/py-event.h: Rename include guard.
 233         * procfs.h: Add include guard.
 234         * proc-utils.h: Add include guard.
 235         * p-lang.h: Add include guard.
 236         * or1k-tdep.h: Rename include guard.
 237         * observable.h: Rename include guard.
 238         * nto-tdep.h: Rename include guard.
 239         * nat/x86-linux.h: Rename include guard.
 240         * nat/x86-linux-dregs.h: Rename include guard.
 241         * nat/x86-gcc-cpuid.h: Add include guard.
 242         * nat/x86-dregs.h: Rename include guard.
 243         * nat/x86-cpuid.h: Rename include guard.
 244         * nat/ppc-linux.h: Rename include guard.
 245         * nat/mips-linux-watch.h: Rename include guard.
 246         * nat/linux-waitpid.h: Rename include guard.
 247         * nat/linux-ptrace.h: Rename include guard.
 248         * nat/linux-procfs.h: Rename include guard.
 249         * nat/linux-osdata.h: Rename include guard.
 250         * nat/linux-nat.h: Rename include guard.
 251         * nat/linux-namespaces.h: Rename include guard.
 252         * nat/linux-btrace.h: Rename include guard.
 253         * nat/glibc_thread_db.h: Rename include guard.
 254         * nat/gdb_thread_db.h: Rename include guard.
 255         * nat/gdb_ptrace.h: Rename include guard.
 256         * nat/fork-inferior.h: Rename include guard.
 257         * nat/amd64-linux-siginfo.h: Rename include guard.
 258         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
 259         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
 260         * nat/aarch64-linux.h: Rename include guard.
 261         * nat/aarch64-linux-hw-point.h: Rename include guard.
 262         * mn10300-tdep.h: Add include guard.
 263         * mips-linux-tdep.h: Add include guard.
 264         * mi/mi-parse.h: Rename include guard.
 265         * mi/mi-out.h: Rename include guard.
 266         * mi/mi-main.h: Rename include guard.
 267         * mi/mi-interp.h: Rename include guard.
 268         * mi/mi-getopt.h: Rename include guard.
 269         * mi/mi-console.h: Rename include guard.
 270         * mi/mi-common.h: Rename include guard.
 271         * mi/mi-cmds.h: Rename include guard.
 272         * mi/mi-cmd-break.h: Rename include guard.
 273         * m2-lang.h: Add include guard.
 274         * location.h: Rename include guard.
 275         * linux-record.h: Rename include guard.
 276         * linux-nat.h: Add include guard.
 277         * linux-fork.h: Add include guard.
 278         * i386-darwin-tdep.h: Rename include guard.
 279         * hppa-linux-offsets.h: Add include guard.
 280         * guile/guile.h: Rename include guard.
 281         * guile/guile-internal.h: Rename include guard.
 282         * gnu-nat.h: Rename include guard.
 283         * gdb-stabs.h: Rename include guard.
 284         * frv-tdep.h: Add include guard.
 285         * f-lang.h: Add include guard.
 286         * event-loop.h: Add include guard.
 287         * darwin-nat.h: Rename include guard.
 288         * cp-abi.h: Rename include guard.
 289         * config/sparc/nm-sol2.h: Rename include guard.
 290         * config/nm-nto.h: Rename include guard.
 291         * config/nm-linux.h: Add include guard.
 292         * config/i386/nm-i386gnu.h: Rename include guard.
 293         * config/djgpp/nl_types.h: Rename include guard.
 294         * config/djgpp/langinfo.h: Rename include guard.
 295         * compile/gcc-cp-plugin.h: Add include guard.
 296         * compile/gcc-c-plugin.h: Add include guard.
 297         * compile/compile.h: Rename include guard.
 298         * compile/compile-object-run.h: Rename include guard.
 299         * compile/compile-object-load.h: Rename include guard.
 300         * compile/compile-internal.h: Rename include guard.
 301         * compile/compile-cplus.h: Rename include guard.
 302         * compile/compile-c.h: Rename include guard.
 303         * common/xml-utils.h: Rename include guard.
 304         * common/x86-xstate.h: Rename include guard.
 305         * common/version.h: Rename include guard.
 306         * common/vec.h: Rename include guard.
 307         * common/tdesc.h: Rename include guard.
 308         * common/selftest.h: Rename include guard.
 309         * common/scoped_restore.h: Rename include guard.
 310         * common/scoped_mmap.h: Rename include guard.
 311         * common/scoped_fd.h: Rename include guard.
 312         * common/safe-iterator.h: Rename include guard.
 313         * common/run-time-clock.h: Rename include guard.
 314         * common/refcounted-object.h: Rename include guard.
 315         * common/queue.h: Rename include guard.
 316         * common/ptid.h: Rename include guard.
 317         * common/print-utils.h: Rename include guard.
 318         * common/preprocessor.h: Rename include guard.
 319         * common/pathstuff.h: Rename include guard.
 320         * common/observable.h: Rename include guard.
 321         * common/netstuff.h: Rename include guard.
 322         * common/job-control.h: Rename include guard.
 323         * common/host-defs.h: Rename include guard.
 324         * common/gdb_wait.h: Rename include guard.
 325         * common/gdb_vecs.h: Rename include guard.
 326         * common/gdb_unlinker.h: Rename include guard.
 327         * common/gdb_unique_ptr.h: Rename include guard.
 328         * common/gdb_tilde_expand.h: Rename include guard.
 329         * common/gdb_sys_time.h: Rename include guard.
 330         * common/gdb_string_view.h: Rename include guard.
 331         * common/gdb_splay_tree.h: Rename include guard.
 332         * common/gdb_setjmp.h: Rename include guard.
 333         * common/gdb_ref_ptr.h: Rename include guard.
 334         * common/gdb_optional.h: Rename include guard.
 335         * common/gdb_locale.h: Rename include guard.
 336         * common/gdb_assert.h: Rename include guard.
 337         * common/filtered-iterator.h: Rename include guard.
 338         * common/filestuff.h: Rename include guard.
 339         * common/fileio.h: Rename include guard.
 340         * common/environ.h: Rename include guard.
 341         * common/common-utils.h: Rename include guard.
 342         * common/common-types.h: Rename include guard.
 343         * common/common-regcache.h: Rename include guard.
 344         * common/common-inferior.h: Rename include guard.
 345         * common/common-gdbthread.h: Rename include guard.
 346         * common/common-exceptions.h: Rename include guard.
 347         * common/common-defs.h: Rename include guard.
 348         * common/common-debug.h: Rename include guard.
 349         * common/cleanups.h: Rename include guard.
 350         * common/buffer.h: Rename include guard.
 351         * common/btrace-common.h: Rename include guard.
 352         * common/break-common.h: Rename include guard.
 353         * cli/cli-utils.h: Rename include guard.
 354         * cli/cli-style.h: Rename include guard.
 355         * cli/cli-setshow.h: Rename include guard.
 356         * cli/cli-script.h: Rename include guard.
 357         * cli/cli-interp.h: Rename include guard.
 358         * cli/cli-decode.h: Rename include guard.
 359         * cli/cli-cmds.h: Rename include guard.
 360         * charset-list.h: Add include guard.
 361         * buildsym-legacy.h: Rename include guard.
 362         * bfin-tdep.h: Add include guard.
 363         * ax.h: Rename include guard.
 364         * arm-linux-tdep.h: Add include guard.
 365         * arm-fbsd-tdep.h: Add include guard.
 366         * arch/xtensa.h: Rename include guard.
 367         * arch/tic6x.h: Add include guard.
 368         * arch/i386.h: Add include guard.
 369         * arch/arm.h: Rename include guard.
 370         * arch/arm-linux.h: Rename include guard.
 371         * arch/arm-get-next-pcs.h: Rename include guard.
 372         * arch/amd64.h: Add include guard.
 373         * arch/aarch64-insn.h: Rename include guard.
 374         * arch-utils.h: Rename include guard.
 375         * annotate.h: Add include guard.
 376         * amd64-darwin-tdep.h: Rename include guard.
 377         * aarch64-linux-tdep.h: Add include guard.
 378         * aarch64-fbsd-tdep.h: Add include guard.
 379         * aarch32-linux-nat.h: Add include guard.
 380
 381 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 382
 383         * macrotab.c (macro_define_internal): New function that
 384         factorizes macro_define_object_internal and macro_define_function
 385         code.
 386         (macro_define_object_internal): Use macro_define_internal.
 387         (macro_define_function): Likewise.
 388
 389 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 390
 391         * macrocmd.c (extract_identifier): Return
 392         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
 393         callers.
 394
 395 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
 396
 397         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
 398
 399 2019-02-05  Tom Tromey  <tom@tromey.com>
 400
 401         * target.c (target_stack::unpush): Move assertion earlier.
 402
 403 2019-01-30  Tom Tromey  <tom@tromey.com>
 404
 405         PR python/23615:
 406         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
 407         (gdbpy_parse_and_eval): Likewise.
 408         * python/python-internal.h (gdbpy_allow_threads): New class.
 409
 410 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
 411
 412         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
 413         (aarch64_fbsd_fpregmap): Move earlier.
 414         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
 415         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 416         instead of individual calls to trad_frame_set_reg_addr.
 417         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
 418         earlier.
 419         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
 420         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 421         instead of individual calls to trad_frame_set_reg_addr.
 422
 423 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
 424
 425         * CONTRIBUTE: Replace contribution list with wiki link.
 426
 427 2019-01-25  Tom Tromey  <tom@tromey.com>
 428
 429         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
 430
 431 2019-01-25  Tom Tromey  <tom@tromey.com>
 432
 433         * xtensa-linux-nat.c: Fix common/ includes.
 434         * xml-support.h: Fix common/ includes.
 435         * xml-support.c: Fix common/ includes.
 436         * x86-linux-nat.c: Fix common/ includes.
 437         * windows-nat.c: Fix common/ includes.
 438         * varobj.h: Fix common/ includes.
 439         * varobj.c: Fix common/ includes.
 440         * value.c: Fix common/ includes.
 441         * valops.c: Fix common/ includes.
 442         * utils.c: Fix common/ includes.
 443         * unittests/xml-utils-selftests.c: Fix common/ includes.
 444         * unittests/utils-selftests.c: Fix common/ includes.
 445         * unittests/unpack-selftests.c: Fix common/ includes.
 446         * unittests/tracepoint-selftests.c: Fix common/ includes.
 447         * unittests/style-selftests.c: Fix common/ includes.
 448         * unittests/string_view-selftests.c: Fix common/ includes.
 449         * unittests/scoped_restore-selftests.c: Fix common/ includes.
 450         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
 451         * unittests/scoped_fd-selftests.c: Fix common/ includes.
 452         * unittests/rsp-low-selftests.c: Fix common/ includes.
 453         * unittests/parse-connection-spec-selftests.c: Fix common/
 454         includes.
 455         * unittests/optional-selftests.c: Fix common/ includes.
 456         * unittests/offset-type-selftests.c: Fix common/ includes.
 457         * unittests/observable-selftests.c: Fix common/ includes.
 458         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
 459         * unittests/memrange-selftests.c: Fix common/ includes.
 460         * unittests/memory-map-selftests.c: Fix common/ includes.
 461         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
 462         * unittests/function-view-selftests.c: Fix common/ includes.
 463         * unittests/environ-selftests.c: Fix common/ includes.
 464         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
 465         * unittests/common-utils-selftests.c: Fix common/ includes.
 466         * unittests/cli-utils-selftests.c: Fix common/ includes.
 467         * unittests/array-view-selftests.c: Fix common/ includes.
 468         * ui-file.c: Fix common/ includes.
 469         * tui/tui-io.c: Fix common/ includes.
 470         * tracepoint.h: Fix common/ includes.
 471         * tracepoint.c: Fix common/ includes.
 472         * tracefile-tfile.c: Fix common/ includes.
 473         * top.h: Fix common/ includes.
 474         * top.c: Fix common/ includes.
 475         * thread.c: Fix common/ includes.
 476         * target/waitstatus.h: Fix common/ includes.
 477         * target/waitstatus.c: Fix common/ includes.
 478         * target.h: Fix common/ includes.
 479         * target.c: Fix common/ includes.
 480         * target-memory.c: Fix common/ includes.
 481         * target-descriptions.c: Fix common/ includes.
 482         * symtab.h: Fix common/ includes.
 483         * symfile.c: Fix common/ includes.
 484         * stap-probe.c: Fix common/ includes.
 485         * spu-linux-nat.c: Fix common/ includes.
 486         * sparc-nat.c: Fix common/ includes.
 487         * source.c: Fix common/ includes.
 488         * solib.c: Fix common/ includes.
 489         * solib-target.c: Fix common/ includes.
 490         * ser-unix.c: Fix common/ includes.
 491         * ser-tcp.c: Fix common/ includes.
 492         * ser-pipe.c: Fix common/ includes.
 493         * ser-base.c: Fix common/ includes.
 494         * selftest-arch.c: Fix common/ includes.
 495         * s12z-tdep.c: Fix common/ includes.
 496         * rust-exp.y: Fix common/ includes.
 497         * rs6000-aix-tdep.c: Fix common/ includes.
 498         * riscv-tdep.c: Fix common/ includes.
 499         * remote.c: Fix common/ includes.
 500         * remote-notif.h: Fix common/ includes.
 501         * remote-fileio.h: Fix common/ includes.
 502         * remote-fileio.c: Fix common/ includes.
 503         * regcache.h: Fix common/ includes.
 504         * regcache.c: Fix common/ includes.
 505         * record-btrace.c: Fix common/ includes.
 506         * python/python.c: Fix common/ includes.
 507         * python/py-type.c: Fix common/ includes.
 508         * python/py-inferior.c: Fix common/ includes.
 509         * progspace.h: Fix common/ includes.
 510         * producer.c: Fix common/ includes.
 511         * procfs.c: Fix common/ includes.
 512         * proc-api.c: Fix common/ includes.
 513         * printcmd.c: Fix common/ includes.
 514         * ppc-linux-nat.c: Fix common/ includes.
 515         * parser-defs.h: Fix common/ includes.
 516         * osdata.c: Fix common/ includes.
 517         * obsd-nat.c: Fix common/ includes.
 518         * nat/x86-linux.c: Fix common/ includes.
 519         * nat/x86-linux-dregs.c: Fix common/ includes.
 520         * nat/x86-dregs.h: Fix common/ includes.
 521         * nat/x86-dregs.c: Fix common/ includes.
 522         * nat/ppc-linux.c: Fix common/ includes.
 523         * nat/mips-linux-watch.h: Fix common/ includes.
 524         * nat/mips-linux-watch.c: Fix common/ includes.
 525         * nat/linux-waitpid.c: Fix common/ includes.
 526         * nat/linux-ptrace.h: Fix common/ includes.
 527         * nat/linux-ptrace.c: Fix common/ includes.
 528         * nat/linux-procfs.c: Fix common/ includes.
 529         * nat/linux-personality.c: Fix common/ includes.
 530         * nat/linux-osdata.c: Fix common/ includes.
 531         * nat/linux-namespaces.c: Fix common/ includes.
 532         * nat/linux-btrace.h: Fix common/ includes.
 533         * nat/linux-btrace.c: Fix common/ includes.
 534         * nat/fork-inferior.c: Fix common/ includes.
 535         * nat/amd64-linux-siginfo.c: Fix common/ includes.
 536         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
 537         * nat/aarch64-linux.c: Fix common/ includes.
 538         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
 539         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
 540         * namespace.h: Fix common/ includes.
 541         * mips-linux-tdep.c: Fix common/ includes.
 542         * minsyms.c: Fix common/ includes.
 543         * mi/mi-parse.h: Fix common/ includes.
 544         * mi/mi-main.c: Fix common/ includes.
 545         * mi/mi-cmd-env.c: Fix common/ includes.
 546         * memrange.h: Fix common/ includes.
 547         * memattr.c: Fix common/ includes.
 548         * maint.h: Fix common/ includes.
 549         * maint.c: Fix common/ includes.
 550         * main.c: Fix common/ includes.
 551         * machoread.c: Fix common/ includes.
 552         * location.c: Fix common/ includes.
 553         * linux-thread-db.c: Fix common/ includes.
 554         * linux-nat.c: Fix common/ includes.
 555         * linux-fork.c: Fix common/ includes.
 556         * inline-frame.c: Fix common/ includes.
 557         * infrun.c: Fix common/ includes.
 558         * inflow.c: Fix common/ includes.
 559         * inferior.h: Fix common/ includes.
 560         * inferior.c: Fix common/ includes.
 561         * infcmd.c: Fix common/ includes.
 562         * inf-ptrace.c: Fix common/ includes.
 563         * inf-child.c: Fix common/ includes.
 564         * ia64-linux-nat.c: Fix common/ includes.
 565         * i387-tdep.c: Fix common/ includes.
 566         * i386-tdep.c: Fix common/ includes.
 567         * i386-linux-tdep.c: Fix common/ includes.
 568         * i386-linux-nat.c: Fix common/ includes.
 569         * i386-go32-tdep.c: Fix common/ includes.
 570         * i386-fbsd-tdep.c: Fix common/ includes.
 571         * i386-fbsd-nat.c: Fix common/ includes.
 572         * guile/scm-type.c: Fix common/ includes.
 573         * guile/guile.c: Fix common/ includes.
 574         * go32-nat.c: Fix common/ includes.
 575         * gnu-nat.c: Fix common/ includes.
 576         * gdbthread.h: Fix common/ includes.
 577         * gdbarch-selftests.c: Fix common/ includes.
 578         * gdb_usleep.c: Fix common/ includes.
 579         * gdb_select.h: Fix common/ includes.
 580         * gdb_bfd.c: Fix common/ includes.
 581         * gcore.c: Fix common/ includes.
 582         * fork-child.c: Fix common/ includes.
 583         * findvar.c: Fix common/ includes.
 584         * fbsd-nat.c: Fix common/ includes.
 585         * event-top.c: Fix common/ includes.
 586         * event-loop.c: Fix common/ includes.
 587         * dwarf2read.c: Fix common/ includes.
 588         * dwarf2loc.c: Fix common/ includes.
 589         * dwarf2-frame.c: Fix common/ includes.
 590         * dwarf-index-cache.c: Fix common/ includes.
 591         * dtrace-probe.c: Fix common/ includes.
 592         * disasm-selftests.c: Fix common/ includes.
 593         * defs.h: Fix common/ includes.
 594         * csky-tdep.c: Fix common/ includes.
 595         * cp-valprint.c: Fix common/ includes.
 596         * cp-support.h: Fix common/ includes.
 597         * cp-support.c: Fix common/ includes.
 598         * corelow.c: Fix common/ includes.
 599         * completer.h: Fix common/ includes.
 600         * completer.c: Fix common/ includes.
 601         * compile/compile.c: Fix common/ includes.
 602         * compile/compile-loc2c.c: Fix common/ includes.
 603         * compile/compile-cplus-types.c: Fix common/ includes.
 604         * compile/compile-cplus-symbols.c: Fix common/ includes.
 605         * command.h: Fix common/ includes.
 606         * cli/cli-dump.c: Fix common/ includes.
 607         * cli/cli-cmds.c: Fix common/ includes.
 608         * charset.c: Fix common/ includes.
 609         * build-id.c: Fix common/ includes.
 610         * btrace.h: Fix common/ includes.
 611         * btrace.c: Fix common/ includes.
 612         * breakpoint.h: Fix common/ includes.
 613         * breakpoint.c: Fix common/ includes.
 614         * ax.h:
 615         (enum agent_op): Fix common/ includes.
 616         * ax-general.c (struct aop_map): Fix common/ includes.
 617         * ax-gdb.c: Fix common/ includes.
 618         * auxv.c: Fix common/ includes.
 619         * auto-load.c: Fix common/ includes.
 620         * arm-tdep.c: Fix common/ includes.
 621         * arch/riscv.c: Fix common/ includes.
 622         * arch/ppc-linux-common.c: Fix common/ includes.
 623         * arch/i386.c: Fix common/ includes.
 624         * arch/arm.c: Fix common/ includes.
 625         * arch/arm-linux.c: Fix common/ includes.
 626         * arch/arm-get-next-pcs.c: Fix common/ includes.
 627         * arch/amd64.c: Fix common/ includes.
 628         * arch/aarch64.c: Fix common/ includes.
 629         * arch/aarch64-insn.c: Fix common/ includes.
 630         * arch-utils.c: Fix common/ includes.
 631         * amd64-windows-tdep.c: Fix common/ includes.
 632         * amd64-tdep.c: Fix common/ includes.
 633         * amd64-sol2-tdep.c: Fix common/ includes.
 634         * amd64-obsd-tdep.c: Fix common/ includes.
 635         * amd64-nbsd-tdep.c: Fix common/ includes.
 636         * amd64-linux-tdep.c: Fix common/ includes.
 637         * amd64-linux-nat.c: Fix common/ includes.
 638         * amd64-fbsd-tdep.c: Fix common/ includes.
 639         * amd64-fbsd-nat.c: Fix common/ includes.
 640         * amd64-dicos-tdep.c: Fix common/ includes.
 641         * amd64-darwin-tdep.c: Fix common/ includes.
 642         * agent.c: Fix common/ includes.
 643         * ada-lang.h: Fix common/ includes.
 644         * ada-lang.c: Fix common/ includes.
 645         * aarch64-tdep.c: Fix common/ includes.
 646
 647 2019-01-25  Tom Tromey  <tom@tromey.com>
 648
 649         * common/create-version.sh: Use common/version.h.
 650
 651 2019-01-24  Pedro Alves  <palves@redhat.com>
 652
 653         * infrun.c (signal_stop, signal_print, signal_program)
 654         (signal_catch, signal_pass): Now arrays instead of pointers.
 655         (update_signals_program_target, do_target_resume)
 656         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
 657         * linux-nat.c (linux_nat_target::pass_signals)
 658         (linux_nat_target::create_inferior, linux_nat_target::attach):
 659         Adjust.
 660         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
 661         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
 662         * procfs.c (procfs_target::pass_signals): Adjust.
 663         * record-full.c (record_full_target::resume): Adjust.
 664         * remote.c (remote_target::pass_signals)
 665         (remote_target::program_signals): Adjust.
 666         * target-debug.h (target_debug_print_signals): Now takes a
 667         gdb::array_view as parameter.  Adjust.
 668         * target.h (target_ops) <pass_signals, program_signals>: Replace
 669         pointer and length parameters with gdb::array_view.
 670         (target_pass_signals, target_program_signals): Likewise.
 671         * target-delegates.c: Regenerate.
 672
 673 2019-01-24  Pedro Alves  <palves@redhat.com>
 674
 675         * common/forward-scope-exit.h
 676         (forward_scope_exit::forward_scope_exit): Pass arguments to
 677         m_bind_function directly, instead of creating a std::bind and
 678         copying that.
 679
 680 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
 681
 682         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 683         for static members.
 684         (pass_in_v_vfp_candidate): Likewise.
 685
 686 2019-01-23  Tom Tromey  <tom@tromey.com>
 687             Pedro Alves  <palves@redhat.com>
 688
 689         * regcache.c (class regcache_invalidator): Remove.
 690         (regcache::raw_write): Use make_scope_exit.
 691
 692 2019-01-23  Tom Tromey  <tom@tromey.com>
 693
 694         * ui-out.h (class ui_out_emit_type): Update comment.
 695
 696 2019-01-23  Tom Tromey  <tom@tromey.com>
 697
 698         * infrun.c (fetch_inferior_event): Update comment.
 699
 700 2019-01-23  Tom Tromey  <tom@tromey.com>
 701             Pedro Alves  <palves@redhat.com>
 702
 703         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
 704         parameter.
 705         (fetch_inferior_event): Use SCOPE_EXIT.
 706
 707
 708 2019-01-23  Tom Tromey  <tom@tromey.com>
 709             Pedro Alves  <palves@redhat.com>
 710
 711         * infrun.c (disable_thread_events): Delete.
 712         (stop_all_threads): Use SCOPE_EXIT.
 713
 714 2019-01-23  Tom Tromey  <tom@tromey.com>
 715             Pedro Alves  <palves@redhat.com>
 716
 717         * symfile.c: Include forward-scope-exit.h.
 718         (clear_symtab_users_cleanup): Replace forward declaration with
 719         a FORWARD_SCOPE_EXIT.
 720         (syms_from_objfile_1): Use the forward_scope_exit and
 721         gdb::optional instead of cleanup_function.
 722         (reread_symbols): Use the forward_scope_exit instead of
 723         cleanup_function.
 724         (clear_symtab_users_cleanup): Remove function.
 725
 726 2019-01-23  Tom Tromey  <tom@tromey.com>
 727             Pedro Alves  <palves@redhat.com>
 728
 729         * linux-nat.c: Include scope-exit.h.
 730         (cleanup_target_stop): Remove.
 731         (linux_nat_target::static_tracepoint_markers_by_strid): Use
 732         SCOPE_EXIT.
 733
 734 2019-01-23  Tom Tromey  <tom@tromey.com>
 735             Pedro Alves  <palves@redhat.com>
 736
 737         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
 738         (call_function_by_hand_dummy): Use SCOPE_EXIT.
 739
 740 2019-01-23  Tom Tromey  <tom@tromey.com>
 741             Andrew Burgess  <andrew.burgess@embecosm.com>
 742             Pedro Alves  <palves@redhat.com>
 743
 744         * infrun.c (fetch_inferior_event): Use scope_exit.
 745         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
 746         * top.c (execute_command): Use scope_exit.
 747         * breakpoint.c (bpstat_do_actions): Use scope_exit.
 748         * utils.c (do_bpstat_clear_actions_cleanup)
 749         (make_bpstat_clear_actions_cleanup): Remove.
 750
 751 2019-01-23  Tom Tromey  <tom@tromey.com>
 752             Pedro Alves  <palves@redhat.com>
 753
 754         * infrun.c: Include "common/scope-exit.h"
 755         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
 756         (wait_for_inferior): Use SCOPE_EXIT.
 757         (fetch_inferior_event): Use scope_exit.
 758
 759 2019-01-23  Tom Tromey  <tom@tromey.com>
 760             Pedro Alves  <palves@redhat.com>
 761
 762         * breakpoint.c (create_breakpoint): Remove cleanup.
 763
 764 2019-01-23  Tom Tromey  <tom@tromey.com>
 765             Andrew Burgess  <andrew.burgess@embecosm.com>
 766             Pedro Alves  <palves@redhat.com>
 767
 768 2019-01-23  Pedro Alves  <palves@redhat.com>
 769
 770         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
 771
 772 2019-01-23  Pedro Alves  <palves@redhat.com>
 773             Andrew Burgess  <andrew.burgess@embecosm.com>
 774
 775         * gdbthread.h: Include "common/forward-scope-exit.h".
 776         (scoped_finish_thread_state): Redefine custom class in terms of
 777         forward_scope_exit.
 778
 779 2019-01-23  Pedro Alves  <palves@redhat.com>
 780             Andrew Burgess  <andrew.burgess@embecosm.com>
 781
 782         * common/forward-scope-exit.h: New file.
 783
 784 2019-01-23  Pedro Alves  <palves@redhat.com>
 785             Andrew Burgess  <andrew.burgess@embecosm.com>
 786             Tom Tromey  <tom@tromey.com>
 787
 788         * common/scope-exit.h: New file.
 789
 790 2019-01-23  Pedro Alves  <palves@redhat.com>
 791
 792         * common/preprocessor.h (ESC): Rename to ...
 793         (ESC_PARENS): ... this.
 794         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
 795         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
 796
 797 2019-01-23  Tom Tromey  <tom@tromey.com>
 798
 799         * language.h (class scoped_switch_to_sym_language_if_auto):
 800         Initialize m_lang in both cases.
 801
 802 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
 803
 804         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
 805         with XCNEW.
 806
 807 2019-01-22  Tom Tromey  <tom@tromey.com>
 808
 809         * corelow.c: Do not include sys/file.h.
 810
 811 2019-01-22  Tom Tromey  <tom@tromey.com>
 812
 813         * tui/tui-wingeneral.h: Include gdb_curses.h.
 814
 815 2019-01-22  Tom Tromey  <tom@tromey.com>
 816
 817         * source-cache.h (class source_cache) <get_source_lines,
 818         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
 819
 820 2019-01-22  Tom Tromey  <tom@tromey.com>
 821
 822         * remote-fileio.h (struct remote_target): Declare.
 823
 824 2019-01-22  Tom Tromey  <tom@tromey.com>
 825
 826         * python/py-arch.c: Do not include py-ref.h.
 827         * python/py-bpevent.c: Do not include py-ref.h.
 828         * python/py-cmd.c: Do not include py-ref.h.
 829         * python/py-continueevent.c: Do not include py-ref.h.
 830         * python/py-event.h: Do not include py-ref.h.
 831         * python/py-evtregistry.c: Do not include py-ref.h.
 832         * python/py-finishbreakpoint.c: Do not include py-ref.h.
 833         * python/py-frame.c: Do not include py-ref.h.
 834         * python/py-framefilter.c: Do not include py-ref.h.
 835         * python/py-function.c: Do not include py-ref.h.
 836         * python/py-infevents.c: Do not include py-ref.h.
 837         * python/py-linetable.c: Do not include py-ref.h.
 838         * python/py-objfile.c: Do not include py-ref.h.
 839         * python/py-param.c: Do not include py-ref.h.
 840         * python/py-prettyprint.c: Do not include py-ref.h.
 841         * python/py-progspace.c: Do not include py-ref.h.
 842         * python/py-symbol.c: Do not include py-ref.h.
 843         * python/py-symtab.c: Do not include py-ref.h.
 844         * python/py-type.c: Do not include py-ref.h.
 845         * python/py-unwind.c: Do not include py-ref.h.
 846         * python/py-utils.c: Do not include py-ref.h.
 847         * python/py-value.c: Do not include py-ref.h.
 848         * python/py-varobj.c: Do not include py-ref.h.
 849         * python/py-xmethods.c: Do not include py-ref.h.
 850         * python/python.c: Do not include py-ref.h.
 851         * varobj.c: Do not include py-ref.h.
 852
 853 2019-01-22  Tom Tromey  <tom@tromey.com>
 854
 855         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
 856         keyword for bcache.
 857
 858 2019-01-22  Tom Tromey  <tom@tromey.com>
 859
 860         * compile/compile-cplus-types.c: Remove a comment by #include.
 861
 862 2019-01-22  Tom Tromey  <tom@tromey.com>
 863
 864         * compile/gcc-c-plugin.h: Include compile-internal.h.
 865
 866 2019-01-22  Tom Tromey  <tom@tromey.com>
 867
 868         * stabsread.c (EXTERN): Do not define.
 869         (symnum, next_symbol_text_func, processing_gcc_compilation)
 870         (within_function, global_sym_chain, global_stabs)
 871         (previous_stab_code, this_object_header_files)
 872         (n_this_object_header_files)
 873         (n_allocated_this_object_header_files): Define.
 874         * stabsread.h (EXTERN): Never define.  Use "extern".
 875
 876 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 877
 878         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
 879         history_value.
 880
 881 2019-01-21  Tom Tromey  <tom@tromey.com>
 882
 883         * ui-out.c: Fix includes.
 884         * tui/tui-source.c: Fix includes.
 885         * target.c: Fix includes.
 886         * remote.c: Fix includes.
 887         * regcache.c: Fix includes.
 888         * python/py-block.c: Fix includes.
 889         * printcmd.c: Fix includes.
 890         * or1k-tdep.c: Fix includes.
 891         * mi/mi-main.c: Fix includes.
 892         * m32r-tdep.c: Fix includes.
 893         * csky-tdep.c: Fix includes.
 894         * compile/compile-cplus-types.c: Fix includes.
 895         * cli/cli-interp.c: Fix includes.
 896
 897 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
 898
 899         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 900         for padding.
 901
 902 2019-01-16  Tom Tromey  <tom@tromey.com>
 903
 904         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
 905         earlier.
 906         (struct objfile) <msymbols_range>: Move from top level.
 907         <msymbols>: New method.
 908         (class objfile_msymbols): Remove.
 909         * symtab.c (default_collect_symbol_completion_matches_break_on):
 910         Update.
 911         * symmisc.c (dump_msymbols): Update.
 912         * stabsread.c (scan_file_globals): Update.
 913         * objc-lang.c (info_selectors_command, info_classes_command)
 914         (find_methods): Update.
 915         * minsyms.c (find_solib_trampoline_target): Update.
 916         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
 917         * coffread.c (coff_symfile_read): Update.
 918         * ada-lang.c (ada_lookup_simple_minsym)
 919         (ada_collect_symbol_completion_matches): Update.
 920
 921 2019-01-16  Tom Tromey  <tom@tromey.com>
 922
 923         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
 924         type.  Remove no-argument constructor.
 925         <iterator::operator++>: Simplify.
 926         <begin>: Update.
 927         <end>: Use minimal_symbol_count.
 928
 929 2019-01-16  Tom Tromey  <tom@tromey.com>
 930
 931         * objfiles.h (struct objfile) <psymtabs>: New method.
 932         (class objfile_psymtabs): Remove.
 933         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
 934         typedef.
 935         <range>: New method.
 936         (require_partial_symbols): Change return type.
 937         * psymtab.c (require_partial_symbols)
 938         (psym_expand_symtabs_matching): Update.
 939         * mdebugread.c (parse_partial_symbols): Update.
 940         * dbxread.c (dbx_end_psymtab): Update.
 941
 942 2019-01-15  Tom Tromey  <tom@tromey.com>
 943
 944         * symtab.c (lookup_objfile_from_block)
 945         (lookup_symbol_in_objfile_symtabs)
 946         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
 947         (find_line_symtab, info_sources_command)
 948         (default_collect_symbol_completion_matches_break_on)
 949         (make_source_files_completion_list): Update.
 950         * symmisc.c (print_objfile_statistics, dump_objfile)
 951         (maintenance_print_symbols, maintenance_info_symtabs)
 952         (maintenance_check_symtabs, maintenance_info_line_tables):
 953         Update.
 954         * source.c (select_source_symtab)
 955         (forget_cached_source_info_for_objfile): Update.
 956         * objfiles.h (class objfile_compunits): Remove.
 957         (struct objfile) <compunits_range>: New typedef.
 958         (compunits): New method.
 959         * objfiles.c (objfile_relocate1): Update.
 960         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
 961         * maint.c (count_symtabs_and_blocks): Update.
 962         * linespec.c (iterate_over_all_matching_symtabs): Update.
 963         * cp-support.c (add_symbol_overload_list_qualified): Update.
 964         * coffread.c (coff_symtab_read): Update.
 965         * ada-lang.c (add_nonlocal_symbols)
 966         (ada_collect_symbol_completion_matches)
 967         (ada_add_global_exceptions): Update.
 968
 969 2019-01-15  Tom Tromey  <tom@tromey.com>
 970
 971         * progspace.h (program_space) <objfiles_safe_range>: New
 972         typedef.
 973         <objfiles_safe>: New method.
 974         * objfiles.h (class all_objfiles_safe): Remove.
 975         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
 976         * jit.c (jit_inferior_exit_hook): Update.
 977
 978 2019-01-17  Tom Tromey  <tom@tromey.com>
 979
 980         * progspace.h (program_space) <objfiles_range>: New typedef.
 981         <objfiles>: New method.
 982         <objfiles_head>: Rename from objfiles.
 983         (object_files): Update.
 984         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
 985         * guile/scm-pretty-print.c
 986         (ppscm_find_pretty_printer_from_objfiles): Update.
 987         * guile/scm-objfile.c (gdbscm_objfiles): Update.
 988         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
 989         Update.
 990         * python/py-progspace.c (pspy_get_objfiles): Update.
 991         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
 992         Update.
 993         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
 994         (objfpy_lookup_objfile_by_build_id): Update.
 995         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
 996         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
 997         Update.
 998         * symtab.c (iterate_over_symtabs, matching_obj_sections)
 999         (expand_symtab_containing_pc, lookup_objfile_from_block)
1000         (lookup_static_symbol, basic_lookup_transparent_type)
1001         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1002         (find_line_symtab, info_sources_command)
1003         (default_collect_symbol_completion_matches_break_on)
1004         (make_source_files_completion_list, find_main_name): Update.
1005         * symmisc.c (print_symbol_bcache_statistics)
1006         (print_objfile_statistics, maintenance_print_symbols)
1007         (maintenance_print_msymbols, maintenance_print_objfiles)
1008         (maintenance_info_symtabs, maintenance_check_symtabs)
1009         (maintenance_expand_symtabs, maintenance_info_line_tables):
1010         Update.
1011         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1012         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1013         (map_overlay_command, unmap_overlay_command)
1014         (simple_overlay_update, expand_symtabs_matching)
1015         (map_symbol_filenames): Update.
1016         * symfile-debug.c (set_debug_symfile): Update.
1017         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1018         Update.
1019         * source.c (select_source_symtab, forget_cached_source_info):
1020         Update.
1021         * solib.c (solib_read_symbols): Update.
1022         * solib-spu.c (append_ocl_sos): Update.
1023         * psymtab.c (maintenance_print_psymbols)
1024         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1025         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1026         * printcmd.c (info_symbol_command): Update.
1027         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1028         Update.
1029         * objfiles.h (class all_objfiles): Remove.
1030         * objfiles.c (have_partial_symbols, have_full_symbols)
1031         (have_minimal_symbols, qsort_cmp, update_section_map)
1032         (shared_objfile_contains_address_p)
1033         (default_iterate_over_objfiles_in_search_order): Update.
1034         * objc-lang.c (info_selectors_command, info_classes_command)
1035         (find_methods): Update.
1036         * minsyms.c (find_solib_trampoline_target): Update.
1037         * maint.c (maintenance_info_sections)
1038         (maintenance_translate_address, count_symtabs_and_blocks):
1039         Update.
1040         * main.c (captured_main_1): Update.
1041         * linux-thread-db.c (try_thread_db_load_from_pdir)
1042         (has_libpthread): Update.
1043         * linespec.c (iterate_over_all_matching_symtabs)
1044         (search_minsyms_for_name): Update.
1045         * jit.c (jit_find_objf_with_entry_addr): Update.
1046         * hppa-tdep.c (find_unwind_entry)
1047         (hppa_lookup_stub_minimal_symbol): Update.
1048         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1049         Update.
1050         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1051         (elf_gnu_ifunc_resolve_by_got): Update.
1052         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1053         * dwarf-index-write.c (save_gdb_index_command): Update.
1054         * cp-support.c (add_symbol_overload_list_qualified): Update.
1055         * breakpoint.c (create_overlay_event_breakpoint)
1056         (create_longjmp_master_breakpoint)
1057         (create_std_terminate_master_breakpoint)
1058         (create_exception_master_breakpoint): Update.
1059         * blockframe.c (find_pc_partial_function): Update.
1060         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1061         (ada_collect_symbol_completion_matches)
1062         (ada_add_global_exceptions): Update.
1063
1064 2019-01-17  Tom Tromey  <tom@tromey.com>
1065
1066         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1067         declare VEC.
1068         (solib_target_parse_libraries): Change return type.
1069         (library_list_start_segment, library_list_start_section)
1070         (library_list_end_library, library_list_start_library); Update.
1071         (solib_target_free_library_list): Remove.
1072         (solib_target_parse_libraries): Remove cleanup.  Change return
1073         type.
1074         (solib_target_current_sos): Update.
1075
1076 2019-01-17  Tom Tromey  <tromey@bapiya>
1077
1078         * valprint.c: Replace "the the" with "the".
1079         * symtab.c: Replace "the the" with "the".
1080         * solib.c: Replace "the the" with "the".
1081         * solib-dsbt.c: Replace "the the" with "the".
1082         * linespec.c: Replace "the the" with "the".
1083         * dwarf2loc.h: Replace "the the" with "the".
1084         * amd64-windows-tdep.c: Replace "the the" with "the".
1085         * aarch64-tdep.c: Replace "the the" with "the".
1086
1087 2019-01-16  Keith Seitz  <keiths@redhat.com>
1088
1089         PR gdb/23773
1090         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1091         <builder>: Rename to ..
1092         <m_builder>: ... this and make private.
1093         (dwarf2_cu::get_builder): New method.  Change all users of
1094         `builder' to use this method.
1095         (dwarf2_start_symtab): Move to ...
1096         (dwarf2_cu::start_symtab): ... here.  Update all callers
1097         (setup_type_unit_groups): Move to ...
1098         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1099         callers.
1100         (dwarf2_cu::reset_builder): New method.
1101         (process_full_compunit, process_full_type_unit): Use
1102         dwarf2_cu::reset_builder.
1103         (follow_die_offset): Record the ancestor CU if it is different
1104         from the followed DIE's CU.
1105         (follow_die_sig_1): Likewise.
1106
1107 2019-01-15  Tom Tromey  <tom@tromey.com>
1108
1109         * remote.c (class remote_state) <buf>: Now a char_vector.
1110         <buf_size>: Remove.
1111         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1112         parameter.
1113         (remote_target::getpkt_or_notif_sane_1)
1114         (remote_target::getpkt_sane)
1115         (remote_target::getpkt_or_notif_sane): Likewise.
1116         (class remote_target) <putpkt>: New overload.
1117         (remote_target::read_frame): Change type of "buf_p".  Remove
1118         sizeof_p parameter.
1119         (packet_ok): New overload.
1120         (packet_check_result): New overload.
1121         Update all uses.
1122
1123 2019-01-14  Tom Tromey  <tom@tromey.com>
1124
1125         * remote-notif.c (handle_notification, remote_notif_ack)
1126         (remote_notif_parse): Make "buf" const.
1127         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1128         const.
1129         (remote_notif_parse, remote_notif_ack, handle_notification):
1130         Likewise.
1131         * remote.c (remote_notif_stop_parse): Make "buf" const.
1132         (remote_target::remote_parse_stop_reply): Make "buf" const.
1133         (remote_notif_stop_ack): Make "buf" const.
1134
1135 2019-01-14  Tom Tromey  <tom@tromey.com>
1136
1137         * remote.c (remote_console_output): Make parameter const.
1138
1139 2019-01-14  Tom Tromey  <tom@tromey.com>
1140
1141         * target-debug.h (target_debug_print_signals): Constify.
1142         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1143         * procfs.c (procfs_target::pass_signals): Update.
1144         * linux-nat.c (linux_nat_target::pass_signals): Update.
1145         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1146         * target-delegates.c: Rebuild.
1147         * remote.c (remote_target::program_signals): Update.
1148         (remote_target::pass_signals): Update.
1149         * target.c (target_pass_signals): Constify argument.
1150         (target_program_signals): Likewise.
1151         * target.h (struct target_ops) <pass_signals, program_signals>:
1152         Constify argument.
1153         (target_pass_signals, target_program_signals): Constify argument.
1154
1155 2019-01-14  Tom Tromey  <tom@tromey.com>
1156
1157         PR tui/28819:
1158         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1159
1160 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1161
1162         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1163         field.
1164         * rs6000-tdep.c: Include reggroups.h.
1165         (IS_V_ALIAS_PSEUDOREG): Define.
1166         (rs6000_register_name): Return names for the "vX" aliases.
1167         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1168         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1169         aliases.  Call default_register_reggroup_p for all other
1170         pseudo-registers.
1171         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1172         New functions.
1173         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1174         Handle "vX" aliases.
1175         (v_alias_pseudo_register_collect): New function.
1176         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1177         (rs6000_gdbarch_init): Initialize "vX" aliases as
1178         pseudo-registers.  Restore registration of
1179         rs6000_pseudo_register_reggroup_p with
1180         set_tdesc_pseudo_register_reggroup_p.
1181
1182 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1183
1184         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1185         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1186         set_gdbarch_num_pseudo_regs.
1187
1188 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1189
1190         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1191         Remove arg prefixname, add do_set and do_show.
1192         Add member functions set_list and show_list.
1193         * cli/cli-style.c (class cli_style_option): Update accordingly.
1194         (style_set_list): Move to file scope.
1195         (style_show_list): Likewise.
1196         (set_style): Call help_list.
1197         (show_style): Call cmd_show_list.
1198         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1199         Update to use the new macro.
1200
1201 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1202
1203         * ada-lang.c (_initialize_ada_language): Expand the help text
1204         for the "catch exception" command.
1205
1206 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1207
1208         * symtab.c (matching_obj_sections): Initialize obj,
1209         declare it closer to its usage.
1210
1211 2019-01-10  Tom Tromey  <tom@tromey.com>
1212
1213         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1214         (basic_inf_threads_range): Remove.
1215         (inf_threads_range, inf_non_exited_threads_range)
1216         (safe_inf_threads_range): Use next_adapter.
1217
1218 2019-01-10  Keith Seitz  <keiths@redhat.com>
1219
1220         PR gdb/23712
1221         PR symtab/23010
1222         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1223         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1224
1225 2019-01-10  Keith Seitz  <keiths@redhat.com>
1226
1227         PR gdb/23712
1228         PR symtab/23010
1229         * dictionary.c (pending_to_vector): Remove.
1230         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1231         Remove _1 suffix, replacing functions of the same name.  Update
1232         all callers.
1233         (dict_create_hashed, dict_create_hashed_expandable)
1234         (dict_create_linear, dict_create_linear_expandable, dict_free)
1235         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1236         Make functions static.
1237
1238 2019-01-10  Keith Seitz  <keiths@redhat.com>
1239
1240         PR gdb/23712
1241         PR symtab/23010
1242         * dictionary.h (struct dictionary): Replace declaration with
1243         multidictionary.
1244         (dict_create_hashed, dict_create_hashed_expandable)
1245         (dict_create_linear, dict_create_linear_expandable)
1246         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1247         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1248         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1249         taking multidictionary argument.
1250         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1251         * block.h (struct block) <dict>: Change to multidictionary
1252         and rename `multidict'.
1253         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1254         symmisc.c: Update all dictionary references to multidictionary.
1255
1256 2019-01-10  Keith Seitz  <keiths@redhat.com>
1257
1258         PR gdb/23712
1259         PR symtab/23010
1260         * dictionary.c: Include unordered_map.
1261         (pending_to_vector): New function.
1262         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1263         Rewrite the non-"_1" functions to take vector instead
1264         of linked list.
1265         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1266         "new" _1 versions of the same name.
1267         (multidictionary): Define.
1268         (std::hash<enum language): New definition.
1269         (collate_pending_symbols_by_language, mdict_create_hashed)
1270         (mdict_create_hashed_expandable, mdict_create_linear)
1271         (mdict_create_linear_expandable, mdict_free)
1272         (find_language_dictionary, create_new_language_dictionary)
1273         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1274         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1275         (mdict_size, mdict_empty): New functions.
1276         * dictionary.h (mdict_iterator): Define.
1277
1278 2019-01-10  Pedro Alves  <palves@redhat.com>
1279
1280         * breakpoint.c (read_uploaded_action)
1281         (create_tracepoint_from_upload): Adjust to use
1282         gdb::unique_xmalloc_ptr.
1283         * ctf.c (ctf_write_uploaded_tp):
1284         (SET_ARRAY_FIELD): Use emplace_back.
1285         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1286         * tracefile-tfile.c (tfile_write_uploaded_tp):
1287         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1288         gdb::unique_xmalloc_ptr.
1289         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1290         at_string, cond_string, cmd_strings>: Replace char pointers
1291         with gdb::unique_xmalloc_ptr.
1292
1293 2019-01-10  Pedro Alves  <palves@redhat.com>
1294
1295         * solib-target.c (library_list_start_library): Don't xstrdup name.
1296
1297 2019-01-10  Pedro Alves  <palves@redhat.com>
1298
1299         * mdebugread.c (parse_partial_symbols): Use
1300         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1301
1302 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1303
1304         * linux-fork.c (scoped_switch_fork_info)
1305         <~scoped_switch_fork_info>: Fix incorrect variable name.
1306
1307 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1308
1309         * linux-fork.c (scoped_switch_fork_info)
1310         <scoped_switch_fork_info>: Make explicit.
1311         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1312
1313 2019-01-10  Tom Tromey  <tom@tromey.com>
1314
1315         * objfiles.h (objfile::reset_psymtabs): Update.
1316         * objfiles.c (objfile::objfile): Update.
1317         * psymtab.h (psymtab_storage::obstack): Update.
1318         (psymtab_storage::m_obstack): Use gdb::optional.
1319         (class psymtab_storage): Update comment.  Remove objfile
1320         parameter.
1321         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1322
1323 2019-01-10  Tom Tromey  <tom@tromey.com>
1324
1325         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1326         <free_psymtabs>: Now private.
1327         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1328         (allocate_psymtab): Use new method.
1329
1330 2019-01-10  Tom Tromey  <tom@tromey.com>
1331
1332         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1333         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1334         * mdebugread.c (parse_partial_symbols): Use
1335         allocate_dependencies.
1336         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1337         allocate_dependencies.
1338         (process_psymtab_comp_unit_reader)
1339         (build_type_psymtab_dependencies): Likewise.
1340         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1341
1342 2019-01-10  Tom Tromey  <tom@tromey.com>
1343
1344         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1345         PSYMBOL_SET_LANGUAGE.
1346         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1347
1348 2019-01-10  Tom Tromey  <tom@tromey.com>
1349
1350         * psymtab.h (psymtab_storage::obstack): New method.
1351         <m_obstack>: Rename from obstack; now private.
1352         * psymtab.c (psymtab_storage): Update.
1353         * dwarf2read.c (create_addrmap_from_index)
1354         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1355         Update.
1356
1357 2019-01-10  Tom Tromey  <tom@tromey.com>
1358
1359         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1360         * objfiles.h (objfile::reset_psymtabs): New method.
1361
1362 2019-01-10  Tom Tromey  <tom@tromey.com>
1363
1364         * symmisc.c (print_symbol_bcache_statistics): Update.
1365         (print_objfile_statistics): Update.
1366         * symfile.c (reread_symbols): Update.
1367         * psymtab.h (class psymtab_storage): New.
1368         * psymtab.c (psymtab_storage): New constructor.
1369         (~psymtab_storage): New destructor.
1370         (require_partial_symbols): Update.
1371         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1372         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1373         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1374         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1375         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1376         (start_psymtab_common, end_psymtab_common)
1377         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1378         (allocate_psymtab): Update.
1379         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1380         Update.
1381         (dump_psymtab_addrmap, maintenance_print_psymbols)
1382         (maintenance_check_psymtabs): Update.
1383         (class objfile_psymtabs): Move to objfiles.h.
1384         * psympriv.h (discard_psymtab): Now inline.
1385         (psymtab_discarder::psymtab_discarder): Update.
1386         (psymtab_discarder::~psymtab_discarder): Update.
1387         (ALL_OBJFILE_PSYMTABS): Rewrite.
1388         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1389         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1390         Remove fields.
1391         <partial_symtabs>: New field.
1392         (class objfile_psymtabs): Move from psymtab.h.  Update.
1393         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1394         psymbol_cache.
1395         (objfile::~objfile): Don't destroy psymbol_cache.
1396         * mdebugread.c (parse_partial_symbols): Update.
1397         * dwarf2read.c (create_addrmap_from_index)
1398         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1399         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1400         (add_partial_subprogram, dwarf2_ranges_read): Update.
1401         * dwarf-index-write.c (write_address_map)
1402         (write_one_signatured_type, recursively_write_psymbols)
1403         (class debug_names, class debug_names, write_psymtabs_to_index):
1404         Update.
1405
1406 2019-01-10  Tom Tromey  <tom@tromey.com>
1407
1408         * symtab.h (SYMBOL_SET_NAMES): Update.
1409         (symbol_set_names): Update.
1410         (MSYMBOL_SET_NAMES): Update.
1411         * symtab.c (symbol_set_names): Change argument to be an
1412         objfile_per_bfd_storage.
1413         * psymtab.c (add_psymbol_to_bcache): Update.
1414         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1415
1416 2019-01-10  Tom Tromey  <tom@tromey.com>
1417
1418         * symtab.c (create_demangled_names_hash): Change argument to be an
1419         objfile_per_bfd_storage.
1420         (symbol_set_names): Update.
1421
1422 2019-01-10  Tom Tromey  <tom@tromey.com>
1423
1424         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1425         init_psymbol_list.
1426         * psymtab.c (init_psymbol_list): Do nothing if already called.
1427         * psympriv.h (init_psymbol_list): Add comment.
1428         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1429         init_psymbol_list.
1430         * dbxread.c (dbx_symfile_read): Unconditionally call
1431         init_psymbol_list.
1432
1433 2019-01-10  Tom Tromey  <tom@tromey.com>
1434
1435         * xcoffread.c (scan_xcoff_symtab): Update.
1436         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1437         "where".
1438         * mdebugread.c (parse_partial_symbols)
1439         (handle_psymbol_enumerators): Update.
1440         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1441         * dbxread.c (read_dbx_symtab): Update.
1442         * psympriv.h (psymbol_placement): New enum.
1443         (add_psymbol_to_list): Update.
1444
1445 2019-01-10  Tom Tromey  <tom@tromey.com>
1446
1447         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1448         static_psymbols parameters.
1449         (scan_xcoff_symtab): Update.
1450         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1451         static_psymbols parameters.
1452         * psympriv.h (start_psymtab_common): Update.
1453         * mdebugread.c (parse_partial_symbols): Update.
1454         * dwarf2read.c (create_partial_symtab): Update.
1455         * dbxread.c (read_dbx_symtab): Update.
1456         (start_psymtab): Remove global_psymbols and static_psymbols
1457         parameters.
1458
1459 2019-01-10  Tom Tromey  <tom@tromey.com>
1460
1461         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1462         * psymtab.c (allocate_psymtab): Add comment.
1463         * psympriv.h (allocate_psymtab): Add comment.
1464         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1465         initializations.
1466         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1467
1468 2019-01-10  Tom Tromey  <tom@tromey.com>
1469
1470         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1471         Don't declare.
1472         * mipsread.c: Include mdebugread.h.
1473         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1474         Declare.
1475         * elfread.c: Include mdebugread.h.
1476
1477 2019-01-09  Tom Tromey  <tom@tromey.com>
1478
1479         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1480         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1481         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1482         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1483         (psym_lookup_symbol, psym_find_last_source_symtab)
1484         (psym_forget_cached_source_info, psym_print_stats)
1485         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1486         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1487         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1488         (psym_find_compunit_symtab_by_address)
1489         (maintenance_print_psymbols, maintenance_info_psymtabs)
1490         (maintenance_check_psymtabs): Use ranged for.
1491         * psymtab.h (class objfile_psymtabs): New.
1492         (require_partial_symbols): Return objfile_psymtabs.
1493         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1494
1495 2019-01-09  Tom Tromey  <tom@tromey.com>
1496
1497         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1498         (find_pc_mapped_section, list_overlays_command)
1499         (map_overlay_command, unmap_overlay_command)
1500         (simple_overlay_update): Use all_objfiles.
1501         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1502         * printcmd.c (info_symbol_command): Use all_objfiles.
1503         * objfiles.h (ALL_OBJSECTIONS): Remove.
1504         * maint.c (maintenance_translate_address): Use all_objfiles.
1505         * gcore.c (gcore_create_callback): Use all_objfiles.
1506         (objfile_find_memory_regions): Likewise.
1507
1508 2019-01-09  Tom Tromey  <tom@tromey.com>
1509
1510         * symtab.c (find_line_symtab, info_sources_command)
1511         (make_source_files_completion_list): Use objfile_compunits.
1512         * source.c (select_source_symtab): Use objfile_compunits.
1513         * objfiles.h (struct objfile): Update comment.
1514         (ALL_OBJFILES): Remove.
1515         (ALL_FILETABS): Remove.
1516         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
1517         objfile_compunits.
1518
1519 2019-01-09  Tom Tromey  <tom@tromey.com>
1520
1521         * symmisc.c (print_objfile_statistics, dump_objfile)
1522         (maintenance_print_symbols): Use compunit_filetabs.
1523         * source.c (forget_cached_source_info_for_objfile): Use
1524         compunit_filetabs.
1525         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
1526         (ALL_FILETABS): Use compunit_filetabs.
1527         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
1528         * coffread.c (coff_symtab_read): Use compunit_filetabs.
1529
1530 2019-01-09  Tom Tromey  <tom@tromey.com>
1531
1532         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
1533         (compunit_filetabs): New.
1534         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
1535         compunit_filetabs.
1536         (info_sources_command, make_source_files_completion_list): Remove
1537         declaration.
1538         * symmisc.c (print_objfile_statistics, dump_objfile)
1539         (maintenance_print_symbols): Remove declaration.
1540         (maintenance_info_symtabs): Use compunit_filetabs.
1541         (maintenance_info_line_tables): Likewise.
1542         * source.c (select_source_symtab): Change local variable name.
1543         (forget_cached_source_info_for_objfile): Remove declaration.
1544         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
1545         * objfiles.c (objfile_relocate1): Remove declaration.
1546         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1547         declaration.
1548         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
1549         * coffread.c (coff_symtab_read): Remove declaration.
1550         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1551         compunit_filetabs.
1552
1553 2019-01-09  Tom Tromey  <tom@tromey.com>
1554
1555         * symtab.c (lookup_objfile_from_block)
1556         (find_pc_sect_compunit_symtab, search_symbols)
1557         (default_collect_symbol_completion_matches_break_on): Use
1558         objfile_compunits.
1559         * objfiles.h (ALL_COMPUNITS): Remove.
1560         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
1561         * cp-support.c (add_symbol_overload_list_qualified): Use
1562         objfile_compunits.
1563         * ada-lang.c (ada_collect_symbol_completion_matches)
1564         (ada_add_global_exceptions): Use objfile_compunits.
1565
1566 2019-01-09  Tom Tromey  <tom@tromey.com>
1567
1568         * source.c (select_source_symtab)
1569         (forget_cached_source_info_for_objfile): Remove declaration.
1570         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1571         declaration.
1572         * maint.c (count_symtabs_and_blocks): Remove declaration.
1573         * cp-support.c (add_symbol_overload_list_qualified): Remove
1574         declaration.
1575         * coffread.c (coff_symtab_read): Remove declaration.
1576         * symtab.c (lookup_symbol_in_objfile_symtabs)
1577         (basic_lookup_transparent_type_1): Use objfile_compunits.
1578         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
1579         (info_sources_command, search_symbols)
1580         (default_collect_symbol_completion_matches_break_on)
1581         (make_source_files_completion_list): Remove declaration.
1582         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
1583         (ada_collect_symbol_completion_matches)
1584         (ada_add_global_exceptions): Remove declaration.
1585         * linespec.c (iterate_over_all_matching_symtabs): Use
1586         objfile_compunits.
1587         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
1588         (class objfile_compunits): New.
1589         (ALL_COMPUNITS): Use objfile_compunits.
1590         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
1591         (maintenance_check_symtabs, maintenance_info_line_tables): Use
1592         objfile_compunits.
1593         * objfiles.c (objfile_relocate1): Use objfile_compunits.
1594
1595 2019-01-09  Tom Tromey  <tom@tromey.com>
1596
1597         * symtab.c (search_symbols)
1598         (default_collect_symbol_completion_matches_break_on): Use
1599         objfile_msymbols.
1600         * ada-lang.c (ada_lookup_simple_minsym)
1601         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
1602         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
1603         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
1604         objfile_msymbols.
1605         * coffread.c (coff_symfile_read): Use objfile_msymbols.
1606         * symmisc.c (dump_msymbols): Use objfile_msymbols.
1607         * objc-lang.c (find_methods): Use objfile_msymbols.
1608         (info_selectors_command, info_classes_command): Likewise.
1609         * stabsread.c (scan_file_globals): Use objfile_msymbols.
1610         * objfiles.h (class objfile_msymbols): New.
1611         (ALL_OBJFILE_MSYMBOLS): Remove.
1612         (ALL_MSYMBOLS): Remove.
1613
1614 2019-01-09  Tom Tromey  <tom@tromey.com>
1615
1616         * common/next-iterator.h (next_adapter): Add Iterator template
1617         parameter.
1618         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
1619         (class all_objfiles_safe): New.
1620         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
1621         * objfiles.c (put_objfile_before): Update comment.
1622         (add_separate_debug_objfile): Likewise.
1623         (free_all_objfiles): Use all_objfiles_safe.
1624         (objfile_purge_solibs): Likewise.
1625
1626 2019-01-09  Tom Tromey  <tom@tromey.com>
1627
1628         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1629         (expand_symtab_containing_pc, lookup_static_symbol)
1630         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
1631         (find_symbol_at_address, find_line_symtab, find_main_name): Use
1632         all_objfiles.
1633         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
1634         * breakpoint.c (create_overlay_event_breakpoint)
1635         (create_longjmp_master_breakpoint)
1636         (create_std_terminate_master_breakpoint)
1637         (create_exception_master_breakpoint): Use all_objfiles.
1638         * linux-thread-db.c (try_thread_db_load_from_pdir)
1639         (has_libpthread): Use all_objfiles.
1640         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
1641         * linespec.c (iterate_over_all_matching_symtabs)
1642         (search_minsyms_for_name): Use all_objfiles.
1643         * maint.c (maintenance_info_sections): Use all_objfiles.
1644         * main.c (captured_main_1): Use all_objfiles.
1645         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
1646         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
1647         * guile/scm-pretty-print.c
1648         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
1649         * solib-spu.c (append_ocl_sos): Use all_objfiles.
1650         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
1651         (maintenance_print_msymbols): Use all_objfiles.
1652         * source.c (select_source_symtab): Use all_objfiles.
1653         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
1654         * symfile.c (remove_symbol_file_command)
1655         (expand_symtabs_matching, map_symbol_filenames): Use
1656         all_objfiles.
1657         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
1658         all_objfiles.
1659         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
1660         * objc-lang.c (find_methods): Use all_objfiles.
1661         * objfiles.c (have_partial_symbols, have_full_symbols)
1662         (have_minimal_symbols, qsort_cmp)
1663         (default_iterate_over_objfiles_in_search_order): Use
1664         all_objfiles.
1665         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
1666         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
1667         (maintenance_check_psymtabs): Use all_objfiles.
1668         (ALL_PSYMTABS): Remove.
1669         * compile/compile-object-run.c (do_module_cleanup): Use
1670         all_objfiles.
1671         * blockframe.c (find_pc_partial_function): Use all_objfiles.
1672         * cp-support.c (add_symbol_overload_list_qualified): Use
1673         all_objfiles.
1674         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1675         Use all_objfiles.
1676         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
1677         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
1678         all_objfiles.
1679         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1680         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
1681         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1682         Uses all_objfiles.
1683         * solib.c (solib_read_symbols): Use all_objfiles
1684
1685 2019-01-09  Tom Tromey  <tom@tromey.com>
1686
1687         * probe.c (parse_probes_in_pspace): Use all_objfiles.
1688         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
1689         all_objfiles.
1690         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
1691         * symmisc.c (print_symbol_bcache_statistics)
1692         (print_objfile_statistics, maintenance_print_objfiles)
1693         (maintenance_info_symtabs, maintenance_check_symtabs)
1694         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
1695         all_objfiles.
1696         * source.c (forget_cached_source_info): Use all_objfiles.
1697         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
1698         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1699         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
1700         * objfiles.c (update_section_map): Use all_objfiles.
1701         (shared_objfile_contains_address_p): Likewise.
1702         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
1703         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
1704
1705 2019-01-09  Tom Tromey  <tom@tromey.com>
1706
1707         * common/next-iterator.h: New file.
1708         * objfiles.h (class all_objfiles): New.
1709         (struct objfile_iterator): New.
1710
1711 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1712
1713         * NEWS: Move the description of the changed "frame", "select-frame",
1714          and "info frame" commands to the Changed commands section.
1715
1716 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
1717
1718         * gdbtypes.c (check_stub_method_group): Remove handling of old
1719         mangling schemes.
1720         * linespec.c (find_methods): Likewise.
1721         * stabsread.c (read_member_functions): Likewise.
1722         * valops.c (search_struct_method): Likewise.
1723         (value_struct_elt_for_reference): Likewise.
1724         * NEWS: Mention this change.
1725
1726 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1727
1728         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
1729         print_source_lines.
1730         * source.c (print_source_lines_base): Update line number check.
1731         (print_source_lines): New function.
1732         (source_lines_range::source_lines_range): New function.
1733         * source.h (class source_lines_range): New class.
1734         (print_source_lines): New declaration.
1735
1736 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1737
1738         * linespec.c (linespec_state_destructor): Free self->canonical_names.
1739
1740 2019-01-08  Tom Tromey  <tom@tromey.com>
1741             Simon Marchi  <simon.marchi@ericsson.com>
1742
1743         PR gdb/24060
1744         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
1745         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
1746         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1747         * f-exp.y (DOLLAR_VARIABLE): Likewise.
1748         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
1749         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1750
1751 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1752
1753         * source.c (select_source_symtab): Move header comment to
1754         declaration in source.h.
1755         (forget_cached_source_info_for_objfile): Likewise.
1756         (forget_cached_source_info): Likewise.
1757         (identify_source_line): Likewise.
1758         * source.h (identify_source_line): Move declaration from symtab.h
1759         and add comment from source.c
1760         (print_source_lines): Likewise.
1761         (forget_cached_source_info_for_objfile): Likewise.
1762         (forget_cached_source_info): Likewise.
1763         (select_source_symtab): Likewise.
1764         (enum print_source_lines_flag): Move definition from symtab.h.
1765         * symtab.h (identify_source_line): Move declaration to source.h.
1766         (print_source_lines): Likewise.
1767         (forget_cached_source_info_for_objfile): Likewise.
1768         (forget_cached_source_info): Likewise.
1769         (select_source_symtab): Likewise.
1770         (enum print_source_lines_flag): Move definition to source.h.
1771         * tui/tui-hooks.c: Add 'source.h' include.
1772
1773 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1774
1775         * source.c (print_source_lines_base): Handle requests to print
1776         reverse line number sequences, and guard against empty lines
1777         string.
1778
1779 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1780
1781         * source.c (print_source_lines_base): Fix skip of '\r' if next
1782         character is '\n'.
1783
1784 2019-01-06  Tom Tromey  <tom@tromey.com>
1785
1786         * c-exp.y (struct c_parse_state) <macro_original_text,
1787         expansion_obstack>: New member.
1788         (macro_original_text, expansion_obstack): Remove globals.
1789         (scan_macro_expansion, scanning_macro_expansion)
1790         (finished_macro_expansion): Update.
1791         (scan_macro_cleanup): Remove.
1792         (yylex, c_parse): Update.
1793
1794 2019-01-06  Tom Tromey  <tom@tromey.com>
1795
1796         * c-exp.y (struct c_parse_state) <strings>: New member.
1797         (operator_stoken): Update.
1798
1799 2019-01-06  Tom Tromey  <tom@tromey.com>
1800
1801         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
1802         (union type_stack_elt) <typelist_val>: Now a pointer to
1803         std::vector.
1804         (type_stack_cleanup): Don't declare.
1805         (push_typelist): Update.
1806         * parse.c (pop_typelist): Return a std::vector.
1807         (push_typelist): Take a std::vector.
1808         (follow_types): Update.  Do not free args.
1809         (type_stack_cleanup): Remove.
1810         * c-exp.y (struct c_parse_state): New.
1811         (cpstate): New global.
1812         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
1813         (nonempty_typelist): Update.
1814         (func_mod): Create a new vector.
1815         (c_parse): Create a c_parse_state.
1816         (check_parameter_typelist): Do not delete params.
1817         (function_method): Update.  Do not delete type_list.
1818
1819 2019-01-06  Tom Tromey  <tom@tromey.com>
1820
1821         PR gdb/28155:
1822         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
1823         check_typedef.
1824         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
1825         (print_return_value): Likewise.
1826
1827 2019-01-05  Tom Tromey  <tom@tromey.com>
1828
1829         * contrib/cleanup_check.py: Remove.
1830         * contrib/gcc-with-excheck: Remove.
1831         * contrib/exsummary.py: Remove.
1832         * contrib/excheck.py: Remove.
1833
1834 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
1835
1836         * thread.c (delete_thread_1): Add gdb_assert that THR is not
1837         NULL. Initialize tpprev to NULL instead of assigning it
1838         to NULL on the next statement.
1839         * windows-nat.c (windows_delete_thread): Remove check for
1840         main_thread_id before printing thread exit notifications.
1841         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
1842         Remove thread ID check against main_thread_id.
1843         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
1844         windows_delete_thread.
1845         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
1846
1847 2019-01-04  Tom Tromey  <tom@tromey.com>
1848
1849         * compile/compile.c (_initialize_compile): Use upper case for
1850         metasyntactic variables.
1851         * symmisc.c (_initialize_symmisc): Use upper case for
1852         metasyntactic variables.
1853         * psymtab.c (_initialize_psymtab): Use upper case for
1854         metasyntactic variables.
1855         * demangle.c (demangle_command): Use upper case for metasyntactic
1856         variables.
1857         (_initialize_demangler): Likewise.
1858         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
1859         variables.
1860
1861 2019-01-03  Tom Tromey  <tom@tromey.com>
1862
1863         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
1864
1865 2019-01-03  Tom Tromey  <tom@tromey.com>
1866
1867         * python/py-symtab.c (salpy_str): Update.
1868         (struct salpy_sal_object) <symtab>: Now a PyObject.
1869         (salpy_dealloc): Update.
1870         (del_objfile_sal): Use gdbpy_ref.
1871
1872 2019-01-03  Tom Tromey  <tom@tromey.com>
1873
1874         * python/py-type.c (convert_field): Use new_reference.  Return
1875         gdbpy_ref.
1876         (make_fielditem): Return gdbpy_ref.
1877         (typy_fields): Update.
1878         (typy_getitem): Update.
1879         (field_name): Return gdbpy_ref.  Use new_reference.
1880         (typy_iterator_iternext): Update.
1881
1882 2019-01-03  Tom Tromey  <tom@tromey.com>
1883
1884         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
1885
1886 2019-01-03  Tom Tromey  <tom@tromey.com>
1887
1888         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
1889         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
1890         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
1891         (pspy_set_frame_filters, pspy_set_frame_unwinders)
1892         (pspy_set_type_printers): Likewise.
1893         * python/py-function.c (fnpy_init): Use gdbpy_ref.
1894         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
1895         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
1896         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
1897         (objfpy_set_type_printers): Likewise.
1898
1899 2019-01-03  Tom Tromey  <tom@tromey.com>
1900
1901         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
1902         (gdbpy_print_stack): Use gdbpy_err_fetch.
1903         * python/python-internal.h (class gdbpy_err_fetch): New class.
1904         (class gdbpy_enter) <m_error_type, m_error_value,
1905         m_error_traceback>: Remove.
1906         <m_error>: New member.
1907         (gdbpy_exception_to_string): Don't declare.
1908         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
1909         * python/py-value.c (convert_value_from_python): Use
1910         gdbpy_err_fetch.
1911         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
1912         gdbpy_exception_to_string.
1913         (gdbpy_handle_exception): Use gdbpy_err_fetch.
1914         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1915         gdbpy_err_fetch.
1916
1917 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1918
1919         * linux-nat.c (delete_lwp_cleanup): Delete.
1920         (struct lwp_deleter): New struct.
1921         (lwp_info_up): New typedef.
1922         (linux_nat_target::follow_fork): Delete cleanup, and make use of
1923         lwp_info_up.
1924
1925 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1926
1927         * linux-fork.c (class scoped_switch_fork_info): New class.
1928         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
1929
1930 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1931
1932         * valops.c (find_overload_match): Remove use of null_cleanup, and
1933         calls to do_cleanups.
1934
1935 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1936
1937         * compile/compile-cplus-types.c
1938         (compile_cplus_instance::decl_name): Handle changes to
1939         cp_func_name.
1940         * cp-support.c (cp_func_name): Update header comment, update
1941         return type.
1942         * cp-support.h (cp_func_name): Update return type in declaration.
1943         * valops.c (find_overload_match): Move temp_func local to top
1944         level of function and change its type.  Use temp_func to hold and
1945         delete temporary string obtained from cp_func_name.
1946
1947 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1948
1949         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
1950         gdb::char_vector, remove cleanup, and update uses of `msg`.
1951
1952 2019-01-03  Jim Wilson  <jimw@sifive.com>
1953
1954         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
1955
1956 2019-01-02  Tom Tromey  <tom@tromey.com>
1957
1958         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
1959         (tdesc_parse_xml): Remove cleanups.
1960         * target-descriptions.h (make_cleanup_free_target_description):
1961         Don't declare.
1962         (target_desc_deleter): New struct.
1963         (target_desc_up): New typedef.
1964         * target-descriptions.c (target_desc_deleter::operator()): Rename
1965         from free_target_description.
1966         (make_cleanup_free_target_description): Remove.
1967
1968 2019-01-02  Tom Tromey  <tom@tromey.com>
1969
1970         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
1971         constructor, destructor.
1972         (linespec_parser): Remove typedef.
1973         (~linespec_parser): Rename from linespec_parser_delete.
1974         (linespec_lex_to_end, linespec_complete_label)
1975         (linespec_complete): Update.
1976         (decode_line_full): Remove cleanups.
1977         (decode_line_1): Update.
1978
1979 2019-01-02  Tom Tromey  <tom@tromey.com>
1980
1981         * python/python-internal.h (inferior_to_inferior_object): Change
1982         return type.
1983         * python/py-exitedevent.c (create_exited_event_object): Update.
1984         * python/py-inferior.c (inferior_to_inferior_object): Return
1985         gdbpy_ref.
1986         (python_new_inferior, python_inferior_deleted)
1987         (thread_to_thread_object, delete_thread_object)
1988         (build_inferior_list, gdbpy_selected_inferior): Update.
1989         * python/py-infthread.c (create_thread_object): Update.  Also fail
1990         if inferior_to_inferior_object fails.
1991
1992 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
1993
1994         * inferior.h (class inferior) <displaced_step_state>: New field.
1995         * infrun.h (struct displaced_step_state): Move here from
1996         infrun.c.  Initialize fields, add constructor.
1997         <inf>: Remove field.
1998         <reset>: New method.
1999         * infrun.c (struct displaced_step_inferior_state): Move to
2000         infrun.h.
2001         (displaced_step_inferior_states): Remove.
2002         (get_displaced_stepping_state): Adust.
2003         (displaced_step_in_progress_any_inferior): Adjust.
2004         (displaced_step_in_progress_thread): Adjust.
2005         (displaced_step_in_progress): Adjust.
2006         (add_displaced_stepping_state): Remove.
2007         (get_displaced_step_closure_by_addr): Adjust.
2008         (remove_displaced_stepping_state): Remove.
2009         (infrun_inferior_exit): Call displaced_step_state.reset.
2010         (use_displaced_stepping): Don't check for NULL.
2011         (displaced_step_prepare_throw): Call
2012         get_displaced_stepping_state.
2013         (displaced_step_fixup): Don't check for NULL.
2014         (prepare_for_detach): Don't check for NULL.
2015
2016 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2017
2018         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2019          in case of call that did not complete.
2020
2021 2019-01-02  Andrey Utkin  <autkin@undo.io>
2022
2023         * symfile.c (find_separate_debug_file): Fix search of debug files for
2024         remote debuggee.
2025
2026 2019-01-02  Tom Tromey  <tom@tromey.com>
2027
2028         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2029         indentation.
2030         * python/py-frame.c (frapy_older): Remove cast.
2031         (frapy_newer): Likewise.
2032         * python/py-breakpoint.c (local_setattro): Remove cast.
2033         * python/py-arch.c (archpy_name): Remove local variable.
2034         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2035
2036 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2037
2038         * unittests/basic_string_view/element_access/char/empty.cc:
2039         Fix year range in copyright header.
2040
2041 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2042
2043         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2044         Delete.
2045         <operator==>: Update with for removed field.
2046         <hash>: Likewise.
2047         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2048         <isa_features>: ...this.
2049         <abi_features>: New field.
2050         (riscv_isa_flen): Update comment.
2051         (riscv_abi_xlen): New declaration.
2052         (riscv_abi_flen): New declaration.
2053         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2054         isa_features.
2055         (riscv_abi_xlen): New function.
2056         (riscv_isa_flen): Update to get answer from isa_features.
2057         (riscv_abi_flen): New function.
2058         (riscv_has_fp_abi): Update to get answer from abi_features.
2059         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2060         xlen and flen.
2061         (riscv_call_info) <xlen, flen>: Update comment.
2062         (riscv_call_arg_struct): Remove invalid assertions
2063         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2064         is removed.
2065         (riscv_gdbarch_init): Gather isa features and abi features
2066         separately, ensure both match on the gdbarch when reusing an old
2067         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2068         a target with 64-bit float hardware.
2069
2070 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2071
2072         * source.c (search_command_helper): Stop reverse search
2073         when line 1 has been searched.
2074
2075 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2076
2077         * record-full.c (record_full_base_target::close): Rewrite
2078         record_full_core_buf_list free logic.
2079
2080 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2081
2082         * break-catch-syscall.c (print_one_catch_syscall): xfree
2083         the last text.
2084
2085 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2086
2087         * top.c (print_gdb_version): Update Copyright year in version
2088         message.
2089
2090 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2091
2092         Update copyright year range in all GDB files.
2093
2094 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2095
2096         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2097
2098 For older changes see ChangeLog-2018.
2099 \f
2100 Local Variables:
2101 mode: change-log
2102 left-margin: 8
2103 fill-column: 74
2104 version-control: never
2105 coding: utf-8
2106 End:
2107