Print non-Ada unions without crashing
[external/binutils.git] / gdb / ChangeLog
1 2019-04-19  Tom Tromey  <tromey@adacore.com>
2
3         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4         Check ADA_TYPE_P.
5         (empty_record, ada_template_to_fixed_record_type_1)
6         (template_to_static_fixed_type)
7         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
8         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
9         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
10         macros.
11
12 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
13
14         PR symtab/24423:
15         * source.c (print_source_lines_base): Advance "iter" when a
16         control character is seen.
17
18 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
19
20         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
21         close to the add_com "shell".
22
23 2019-04-18  Tom Tromey  <tromey@adacore.com>
24
25         * process-stratum-target.h (class process_stratum_target)
26         <stratum>: Add "final".
27
28 2019-04-17  Tom Tromey  <tromey@adacore.com>
29
30         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
31         against nullptr before use.
32
33 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
34
35         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
36
37 2019-04-17  Jim Wilson  <jimw@sifive.com>
38             Andrew Burgess  <andrew.burgess@embecosm.com>
39
40         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
41         code read might fail, assume 4-byte breakpoint in that case.
42
43 2019-04-15  Leszek Swirski  <leszeks@google.com>
44
45         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
46         rather than a hand-rolled POD check when checking for forced MEMORY
47         classification.
48
49 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
50
51         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
52         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
53         function.
54         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
55         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
56         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
57         declaration.
58
59 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
60
61         * aarch64-linux-nat.c
62         (aarch64_linux_nat_target::thread_architecture): Add override.
63         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
64         each VQ.
65
66 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
67
68         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
69
70 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
71
72         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
73         target types of size 96-bits, add some additional comments, and
74         check that the builtin type we found was the correct size.
75
76 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
77
78         * utils.c (prompt_for_continue): Don't restore the styling at the
79         end, as applied_style has the wrong value.  This fixes styling in
80         long lists of file names that are interrupted by the "Continue?"
81         prompt.
82
83 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
84
85         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
86         * c-lang.c (c_language_defn): Likewise.
87         (cplus_language_defn): Likewise.
88         (asm_language_defn): Likewise.
89         (minimal_language_defn): Likewise.
90         * d-lang.c (d_language_defn): Likewise.
91         * f-lang.c (f_language_defn): Likewise.
92         * go-lang.c (go_language_defn): Likewise.
93         * language.c (unknown_language_defn): Likewise.
94         (auto_language_defn): Likewise.
95         * language.h (struct language_defn): Remove la_magic field.
96         (LANG_MAGIC): Delete.
97         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
98         * objc-lang.c (objc_language_defn): Likewise.
99         * opencl-lang.c (opencl_language_defn): Likewise.
100         * p-lang.c (pascal_language_defn): Likewise.
101         * rust-lang.c (rust_language_defn): Likewise.
102
103 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
104
105         * riscv-tdep.c (riscv_type_align): New function.
106         (riscv_type_alignment): Delete.
107         (riscv_arg_location): Use 'type_align'.
108         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
109
110 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
111
112         * gdbtypes.c (type_align): A struct with no non-static fields also
113         has alignment of 1.
114
115 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
116
117         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
118         component to 0.
119         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
120         member.
121         (riscv_struct_info::analyse): New implementation using new
122         analyse_inner member function.
123         (riscv_struct_info::field_offset): New member function.
124         (riscv_struct_info::m_offsets): New member variable.
125         (riscv_struct_info::analyse_inner): New private member function,
126         takes the old implementation of riscv_struct_info::analyse but
127         extended to track field offsets.
128         (riscv_call_arg_struct): Update the struct folding special cases
129         to handle cases where empty C++ structs, which are non-zero
130         length, are found.
131         (riscv_arg_location): Initialise the length of each location, a
132         non-zero length now indicates the location is in use.
133         (riscv_push_dummy_call): Allow for the first location having a
134         non-zero offset when setting up arguments.
135         (riscv_return_value): Likewise, but for return values.
136
137 2019-04-11  Tom Tromey  <tromey@adacore.com>
138
139         * utils.c (internal_vproblem): Make "msg" const.
140
141 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
142
143         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
144         * trad-frame.c (trad_frame_reset_saved_regs): New function.
145         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
146         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
147
148 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
149
150         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
151         function.
152         (fill_gregset): Call amd64_linux_collect_native_gregset instead
153         of amd64_collect_native_gregset.
154         (amd64_linux_nat_target::store_registers): Likewise.
155
156 2019-04-10  Tom Tromey  <tom@tromey.com>
157
158         * symtab.c (lookup_global_symbol_from_objfile)
159         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
160         * objfiles.h (class separate_debug_iterator): New.
161         (class separate_debug_range): New.
162         (struct objfile) <separate_debug_objfiles>: New method.
163         (objfile_separate_debug_iterate): Don't declare.
164         * objfiles.c (separate_debug_iterator::operator++): Rename from
165         objfile_separate_debug_iterate.
166         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
167         iterator.
168         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
169         iterator.
170
171 2019-04-10  Tom Tromey  <tom@tromey.com>
172
173         * symfile.c (reread_symbols): Remove old comment.
174         * objfiles.c (free_all_objfiles): Fix a typo.
175
176 2019-04-10  Tom Tromey  <tom@tromey.com>
177
178         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
179         * minsyms.c (lookup_minimal_symbol): Use foreach.
180         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
181         (lookup_minimal_symbol_solib_trampoline): Likewise.
182         * symfile.c (reread_symbols): Use foreach.
183
184 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
185             Tom Tromey  <tromey@adacore.com>
186
187         PR rust/24414:
188         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
189         (rust_lex_int_test): Change "value" to be LONGEST.
190         (rust_lex_tests): Add test for long integer literal.
191
192 2019-04-09  Tom Tromey  <tromey@adacore.com>
193
194         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
195         to bool.
196         (extended_remote_target::attach): Update.
197         (remote_target::remote_notice_new_inferior): Update.
198         (remote_target::add_current_inferior_and_thread): Update.
199         * inferior.c (exit_inferior_1): Use "false".
200         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
201
202 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
203
204         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
205         the "start" command.
206
207 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
208
209         * python/py-inferior.c (infpy_thread_from_thread_handle):
210         Adjust comments to reflect renaming of thread_from_thread_handle
211         to thread_from_handle.  Adjust keywords.  Fix type error message.
212         (inferior_object_methods): Add thread_from_handle.  Retain
213         thread_from_thread_handle, but mark it as deprecated.
214
215 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
216
217         * gdbthread.h (find_thread_by_handle): Revise declaration.
218         * thread.c (find_thread_by_handle): Likewise.  Adjust
219         implementation too.
220         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
221         support for buffer objects as handles.
222
223 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
224
225         * python/py-infthread.c (thpy_thread_handle): New function.
226         (thread_object_methods): Register thpy_thread_handle.
227
228 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
229
230         * gdbthread.h (thread_to_thread_handle): Declare.
231         * thread.c (gdbtypes.h): Include.
232         (thread_to_thread_handle): New function.
233
234         * target.h (struct target_ops): Add thread_info_to_thread_handle.
235         (target_thread_info_to_thread_handle): Declare.
236         * target.c (target_thread_info_to_thread_handle): New function.
237         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
238         * target-delegates.c: Regenerate.
239
240         * linux-thread-db.c (class thread_db_target): Add method
241         thread_info_to_thread_handle.
242         (thread_db_target::thread_info_to_thread_handle): Define.
243         * remote.c (class remote_target): Add new method
244         thread_info_to_thread_handle.
245         (remote_target::thread_info_to_thread_handle): Define.
246
247 2019-04-08  Pedro Alves  <palves@redhat.com>
248
249         * common/common-exceptions.c (throw_exception): Don't create
250         named object to throw; throw directly.
251         (throw_it): Likewise.  Don't initialize gdb_exception::message
252         here, with new; pass FMT and AP to the ctor instead.
253         * common/common-exceptions.h: Include <string>.
254         (gdb_exception::gdb_exception(enum return_reason, enum errors,
255         const char *, va_list)): New ctor.  Use std::make_shared.
256         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
257         errors)): Delete.
258         (gdb_exception_error::gdb_exception_error(enum errors, const char
259         *, va_list)): New.
260         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
261         Add assertion.
262         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
263         errors)): Delete.
264         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
265         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
266         Add assertion.
267
268 2019-04-08  Tom Tromey  <tom@tromey.com>
269
270         * valops.c (value_rtti_indirect_type): Replace throw_exception
271         with throw.
272         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
273         with throw.
274         * thread.c (thr_try_catch_cmd): Replace throw_exception with
275         throw.
276         * target.c (target_translate_tls_address): Replace throw_exception
277         with throw.
278         * stack.c (frame_apply_command_count): Replace throw_exception
279         with throw.
280         * solib-spu.c (append_ocl_sos): Replace throw_exception with
281         throw.
282         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
283         with throw.
284         * rs6000-tdep.c (rs6000_frame_cache)
285         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
286         * remote.c: Replace throw_exception with throw.
287         * record-full.c (record_full_message, record_full_wait_1)
288         (record_full_restore): Replace throw_exception with throw.
289         * record-btrace.c:
290         (get_thread_current_frame_id, record_btrace_start_replaying)
291         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
292         (cmd_record_btrace_start): Replace throw_exception with throw.
293         * parse.c (parse_exp_in_context_1): Replace throw_exception with
294         throw.
295         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
296         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
297         * linespec.c:
298         (find_linespec_symbols): Replace throw_exception with throw.
299         * infrun.c (displaced_step_prepare, resume): Replace
300         throw_exception with throw.
301         * infcmd.c (post_create_inferior): Replace throw_exception with
302         throw.
303         * inf-loop.c (inferior_event_handler): Replace throw_exception
304         with throw.
305         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
306         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
307         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
308         (get_prev_frame_always, get_frame_pc_if_available)
309         (get_frame_address_in_block_if_available, get_frame_language):
310         Replace throw_exception with throw.
311         * frame-unwind.c (frame_unwind_try_unwinder): Replace
312         throw_exception with throw.
313         * eval.c (fetch_subexp_value, evaluate_var_value)
314         (evaluate_funcall, evaluate_subexp_standard): Replace
315         throw_exception with throw.
316         * dwarf2loc.c (call_site_find_chain)
317         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
318         Replace throw_exception with throw.
319         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
320         with throw.
321         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
322         throw.
323         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
324         * completer.c (complete_line_internal): Replace throw_exception
325         with throw.
326         * compile/compile-object-run.c (compile_object_run): Replace
327         throw_exception with throw.
328         * cli/cli-script.c (process_next_line): Replace throw_exception
329         with throw.
330         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
331         (btrace_enable, btrace_maint_update_pt_packets): Replace
332         throw_exception with throw.
333         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
334         throw_exception with throw.
335         * break-catch-throw.c (re_set_exception_catchpoint): Replace
336         throw_exception with throw.
337         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
338         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
339         * aarch64-tdep.c (aarch64_make_prologue_cache)
340         (aarch64_make_stub_cache): Replace throw_exception with throw.
341
342 2019-04-08  Tom Tromey  <tom@tromey.com>
343
344         * common/common-exceptions.c (throw_exception): Rename from
345         throw_exception_cxx.  Remove old copy.  Make argument const.
346         (throw_it): Create and throw exception objects directly.
347         * common/common-exceptions.h (throw_exception): Make argument
348         const.
349         (struct gdb_exception_error): Add constructor.
350         (struct gdb_exception_quit): Add constructor.
351
352 2019-04-08  Tom Tromey  <tom@tromey.com>
353
354         * common/common-exceptions.h (exception_rethrow): Don't declare.
355         (TRY_SJLJ): Update comment.
356         (TRY, CATCH, END_CATCH): Remove.
357         * common/common-exceptions.c (exception_rethrow): Remove.
358
359 2019-04-08  Tom Tromey  <tom@tromey.com>
360
361         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
362         Remove.
363         (gdb_exception_error): Rename from
364         gdb_exception_RETURN_MASK_ERROR.
365         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
366         (gdb_quit_bad_alloc): Update.
367         * aarch64-tdep.c: Update.
368         * ada-lang.c: Update.
369         * ada-typeprint.c: Update.
370         * ada-valprint.c: Update.
371         * amd64-tdep.c: Update.
372         * arch-utils.c: Update.
373         * break-catch-throw.c: Update.
374         * breakpoint.c: Update.
375         * btrace.c: Update.
376         * c-varobj.c: Update.
377         * cli/cli-cmds.c: Update.
378         * cli/cli-interp.c: Update.
379         * cli/cli-script.c: Update.
380         * common/common-exceptions.c: Update.
381         * common/new-op.c: Update.
382         * common/selftest.c: Update.
383         * compile/compile-c-symbols.c: Update.
384         * compile/compile-cplus-symbols.c: Update.
385         * compile/compile-object-load.c: Update.
386         * compile/compile-object-run.c: Update.
387         * completer.c: Update.
388         * corelow.c: Update.
389         * cp-abi.c: Update.
390         * cp-support.c: Update.
391         * cp-valprint.c: Update.
392         * darwin-nat.c: Update.
393         * disasm-selftests.c: Update.
394         * dtrace-probe.c: Update.
395         * dwarf-index-cache.c: Update.
396         * dwarf-index-write.c: Update.
397         * dwarf2-frame-tailcall.c: Update.
398         * dwarf2-frame.c: Update.
399         * dwarf2loc.c: Update.
400         * dwarf2read.c: Update.
401         * eval.c: Update.
402         * event-loop.c: Update.
403         * event-top.c: Update.
404         * exec.c: Update.
405         * f-valprint.c: Update.
406         * fbsd-tdep.c: Update.
407         * frame-unwind.c: Update.
408         * frame.c: Update.
409         * gdbtypes.c: Update.
410         * gnu-v3-abi.c: Update.
411         * guile/guile-internal.h: Update.
412         * guile/scm-block.c: Update.
413         * guile/scm-breakpoint.c: Update.
414         * guile/scm-cmd.c: Update.
415         * guile/scm-disasm.c: Update.
416         * guile/scm-frame.c: Update.
417         * guile/scm-lazy-string.c: Update.
418         * guile/scm-math.c: Update.
419         * guile/scm-param.c: Update.
420         * guile/scm-ports.c: Update.
421         * guile/scm-pretty-print.c: Update.
422         * guile/scm-symbol.c: Update.
423         * guile/scm-symtab.c: Update.
424         * guile/scm-type.c: Update.
425         * guile/scm-value.c: Update.
426         * i386-linux-tdep.c: Update.
427         * i386-tdep.c: Update.
428         * inf-loop.c: Update.
429         * infcall.c: Update.
430         * infcmd.c: Update.
431         * infrun.c: Update.
432         * jit.c: Update.
433         * language.c: Update.
434         * linespec.c: Update.
435         * linux-fork.c: Update.
436         * linux-nat.c: Update.
437         * linux-tdep.c: Update.
438         * linux-thread-db.c: Update.
439         * main.c: Update.
440         * mi/mi-cmd-break.c: Update.
441         * mi/mi-cmd-stack.c: Update.
442         * mi/mi-interp.c: Update.
443         * mi/mi-main.c: Update.
444         * objc-lang.c: Update.
445         * p-valprint.c: Update.
446         * parse.c: Update.
447         * ppc-linux-tdep.c: Update.
448         * printcmd.c: Update.
449         * python/py-arch.c: Update.
450         * python/py-breakpoint.c: Update.
451         * python/py-cmd.c: Update.
452         * python/py-finishbreakpoint.c: Update.
453         * python/py-frame.c: Update.
454         * python/py-framefilter.c: Update.
455         * python/py-gdb-readline.c: Update.
456         * python/py-inferior.c: Update.
457         * python/py-infthread.c: Update.
458         * python/py-lazy-string.c: Update.
459         * python/py-linetable.c: Update.
460         * python/py-objfile.c: Update.
461         * python/py-param.c: Update.
462         * python/py-prettyprint.c: Update.
463         * python/py-progspace.c: Update.
464         * python/py-record-btrace.c: Update.
465         * python/py-record.c: Update.
466         * python/py-symbol.c: Update.
467         * python/py-type.c: Update.
468         * python/py-unwind.c: Update.
469         * python/py-utils.c: Update.
470         * python/py-value.c: Update.
471         * python/python.c: Update.
472         * record-btrace.c: Update.
473         * record-full.c: Update.
474         * remote-fileio.c: Update.
475         * remote.c: Update.
476         * riscv-tdep.c: Update.
477         * rs6000-aix-tdep.c: Update.
478         * rs6000-tdep.c: Update.
479         * rust-exp.y: Update.
480         * rust-lang.c: Update.
481         * s390-tdep.c: Update.
482         * selftest-arch.c: Update.
483         * solib-dsbt.c: Update.
484         * solib-frv.c: Update.
485         * solib-spu.c: Update.
486         * solib-svr4.c: Update.
487         * solib.c: Update.
488         * sparc64-linux-tdep.c: Update.
489         * stack.c: Update.
490         * symfile-mem.c: Update.
491         * symmisc.c: Update.
492         * target.c: Update.
493         * thread.c: Update.
494         * top.c: Update.
495         * tracefile-tfile.c: Update.
496         * tui/tui.c: Update.
497         * typeprint.c: Update.
498         * unittests/cli-utils-selftests.c: Update.
499         * unittests/parse-connection-spec-selftests.c: Update.
500         * valops.c: Update.
501         * valprint.c: Update.
502         * value.c: Update.
503         * varobj.c: Update.
504         * windows-nat.c: Update.
505         * x86-linux-nat.c: Update.
506         * xml-support.c: Update.
507
508 2019-04-08  Tom Tromey  <tom@tromey.com>
509
510         * xml-support.c: Use C++ exception handling.
511         * x86-linux-nat.c: Use C++ exception handling.
512         * windows-nat.c: Use C++ exception handling.
513         * varobj.c: Use C++ exception handling.
514         * value.c: Use C++ exception handling.
515         * valprint.c: Use C++ exception handling.
516         * valops.c: Use C++ exception handling.
517         * unittests/parse-connection-spec-selftests.c: Use C++ exception
518         handling.
519         * unittests/cli-utils-selftests.c: Use C++ exception handling.
520         * typeprint.c: Use C++ exception handling.
521         * tui/tui.c: Use C++ exception handling.
522         * tracefile-tfile.c: Use C++ exception handling.
523         * top.c: Use C++ exception handling.
524         * thread.c: Use C++ exception handling.
525         * target.c: Use C++ exception handling.
526         * symmisc.c: Use C++ exception handling.
527         * symfile-mem.c: Use C++ exception handling.
528         * stack.c: Use C++ exception handling.
529         * sparc64-linux-tdep.c: Use C++ exception handling.
530         * solib.c: Use C++ exception handling.
531         * solib-svr4.c: Use C++ exception handling.
532         * solib-spu.c: Use C++ exception handling.
533         * solib-frv.c: Use C++ exception handling.
534         * solib-dsbt.c: Use C++ exception handling.
535         * selftest-arch.c: Use C++ exception handling.
536         * s390-tdep.c: Use C++ exception handling.
537         * rust-lang.c: Use C++ exception handling.
538         * rust-exp.y: Use C++ exception handling.
539         * rs6000-tdep.c: Use C++ exception handling.
540         * rs6000-aix-tdep.c: Use C++ exception handling.
541         * riscv-tdep.c: Use C++ exception handling.
542         * remote.c: Use C++ exception handling.
543         * remote-fileio.c: Use C++ exception handling.
544         * record-full.c: Use C++ exception handling.
545         * record-btrace.c: Use C++ exception handling.
546         * python/python.c: Use C++ exception handling.
547         * python/py-value.c: Use C++ exception handling.
548         * python/py-utils.c: Use C++ exception handling.
549         * python/py-unwind.c: Use C++ exception handling.
550         * python/py-type.c: Use C++ exception handling.
551         * python/py-symbol.c: Use C++ exception handling.
552         * python/py-record.c: Use C++ exception handling.
553         * python/py-record-btrace.c: Use C++ exception handling.
554         * python/py-progspace.c: Use C++ exception handling.
555         * python/py-prettyprint.c: Use C++ exception handling.
556         * python/py-param.c: Use C++ exception handling.
557         * python/py-objfile.c: Use C++ exception handling.
558         * python/py-linetable.c: Use C++ exception handling.
559         * python/py-lazy-string.c: Use C++ exception handling.
560         * python/py-infthread.c: Use C++ exception handling.
561         * python/py-inferior.c: Use C++ exception handling.
562         * python/py-gdb-readline.c: Use C++ exception handling.
563         * python/py-framefilter.c: Use C++ exception handling.
564         * python/py-frame.c: Use C++ exception handling.
565         * python/py-finishbreakpoint.c: Use C++ exception handling.
566         * python/py-cmd.c: Use C++ exception handling.
567         * python/py-breakpoint.c: Use C++ exception handling.
568         * python/py-arch.c: Use C++ exception handling.
569         * printcmd.c: Use C++ exception handling.
570         * ppc-linux-tdep.c: Use C++ exception handling.
571         * parse.c: Use C++ exception handling.
572         * p-valprint.c: Use C++ exception handling.
573         * objc-lang.c: Use C++ exception handling.
574         * mi/mi-main.c: Use C++ exception handling.
575         * mi/mi-interp.c: Use C++ exception handling.
576         * mi/mi-cmd-stack.c: Use C++ exception handling.
577         * mi/mi-cmd-break.c: Use C++ exception handling.
578         * main.c: Use C++ exception handling.
579         * linux-thread-db.c: Use C++ exception handling.
580         * linux-tdep.c: Use C++ exception handling.
581         * linux-nat.c: Use C++ exception handling.
582         * linux-fork.c: Use C++ exception handling.
583         * linespec.c: Use C++ exception handling.
584         * language.c: Use C++ exception handling.
585         * jit.c: Use C++ exception handling.
586         * infrun.c: Use C++ exception handling.
587         * infcmd.c: Use C++ exception handling.
588         * infcall.c: Use C++ exception handling.
589         * inf-loop.c: Use C++ exception handling.
590         * i386-tdep.c: Use C++ exception handling.
591         * i386-linux-tdep.c: Use C++ exception handling.
592         * guile/scm-value.c: Use C++ exception handling.
593         * guile/scm-type.c: Use C++ exception handling.
594         * guile/scm-symtab.c: Use C++ exception handling.
595         * guile/scm-symbol.c: Use C++ exception handling.
596         * guile/scm-pretty-print.c: Use C++ exception handling.
597         * guile/scm-ports.c: Use C++ exception handling.
598         * guile/scm-param.c: Use C++ exception handling.
599         * guile/scm-math.c: Use C++ exception handling.
600         * guile/scm-lazy-string.c: Use C++ exception handling.
601         * guile/scm-frame.c: Use C++ exception handling.
602         * guile/scm-disasm.c: Use C++ exception handling.
603         * guile/scm-cmd.c: Use C++ exception handling.
604         * guile/scm-breakpoint.c: Use C++ exception handling.
605         * guile/scm-block.c: Use C++ exception handling.
606         * guile/guile-internal.h: Use C++ exception handling.
607         * gnu-v3-abi.c: Use C++ exception handling.
608         * gdbtypes.c: Use C++ exception handling.
609         * frame.c: Use C++ exception handling.
610         * frame-unwind.c: Use C++ exception handling.
611         * fbsd-tdep.c: Use C++ exception handling.
612         * f-valprint.c: Use C++ exception handling.
613         * exec.c: Use C++ exception handling.
614         * event-top.c: Use C++ exception handling.
615         * event-loop.c: Use C++ exception handling.
616         * eval.c: Use C++ exception handling.
617         * dwarf2read.c: Use C++ exception handling.
618         * dwarf2loc.c: Use C++ exception handling.
619         * dwarf2-frame.c: Use C++ exception handling.
620         * dwarf2-frame-tailcall.c: Use C++ exception handling.
621         * dwarf-index-write.c: Use C++ exception handling.
622         * dwarf-index-cache.c: Use C++ exception handling.
623         * dtrace-probe.c: Use C++ exception handling.
624         * disasm-selftests.c: Use C++ exception handling.
625         * darwin-nat.c: Use C++ exception handling.
626         * cp-valprint.c: Use C++ exception handling.
627         * cp-support.c: Use C++ exception handling.
628         * cp-abi.c: Use C++ exception handling.
629         * corelow.c: Use C++ exception handling.
630         * completer.c: Use C++ exception handling.
631         * compile/compile-object-run.c: Use C++ exception handling.
632         * compile/compile-object-load.c: Use C++ exception handling.
633         * compile/compile-cplus-symbols.c: Use C++ exception handling.
634         * compile/compile-c-symbols.c: Use C++ exception handling.
635         * common/selftest.c: Use C++ exception handling.
636         * common/new-op.c: Use C++ exception handling.
637         * cli/cli-script.c: Use C++ exception handling.
638         * cli/cli-interp.c: Use C++ exception handling.
639         * cli/cli-cmds.c: Use C++ exception handling.
640         * c-varobj.c: Use C++ exception handling.
641         * btrace.c: Use C++ exception handling.
642         * breakpoint.c: Use C++ exception handling.
643         * break-catch-throw.c: Use C++ exception handling.
644         * arch-utils.c: Use C++ exception handling.
645         * amd64-tdep.c: Use C++ exception handling.
646         * ada-valprint.c: Use C++ exception handling.
647         * ada-typeprint.c: Use C++ exception handling.
648         * ada-lang.c: Use C++ exception handling.
649         * aarch64-tdep.c: Use C++ exception handling.
650
651 2019-04-08  Tom Tromey  <tom@tromey.com>
652
653         * xml-support.c (gdb_xml_parser::parse): Update.
654         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
655         * value.c (show_convenience): Update.
656         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
657         (test_parse_flags_qcs): Update.
658         * thread.c (thr_try_catch_cmd): Update.
659         * target.c (target_translate_tls_address): Update.
660         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
661         (info_frame_command_core, frame_apply_command_count): Update.
662         * rust-exp.y (rust_lex_exception_test): Update.
663         * riscv-tdep.c (riscv_print_one_register_info): Update.
664         * remote.c (remote_target::enable_btrace): Update.
665         * record-btrace.c (record_btrace_enable_warn): Update.
666         * python/py-utils.c (gdbpy_convert_exception): Update.
667         * printcmd.c (do_one_display, print_variable_and_value): Update.
668         * mi/mi-main.c (mi_print_exception): Update.
669         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
670         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
671         * linux-nat.c (linux_nat_target::attach): Update.
672         * linux-fork.c (class scoped_switch_fork_info): Update.
673         * infrun.c (displaced_step_prepare): Update.
674         * infcall.c (call_function_by_hand_dummy): Update.
675         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
676         * gnu-v3-abi.c (print_one_vtable): Update.
677         * frame.c (get_prev_frame_always): Update.
678         * f-valprint.c (info_common_command_for_block): Update.
679         * exec.c (try_open_exec_file): Update.
680         * exceptions.c (print_exception, exception_print)
681         (exception_fprintf, exception_print_same): Update.
682         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
683         * dwarf-index-cache.c (index_cache::store)
684         (index_cache::lookup_gdb_index): Update.
685         * darwin-nat.c (maybe_cache_shell): Update.
686         * cp-valprint.c (cp_print_value_fields): Update.
687         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
688         (gcc_cplus_symbol_address): Update.
689         * compile/compile-c-symbols.c (gcc_convert_symbol)
690         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
691         * common/selftest.c: Update.
692         * common/common-exceptions.h (struct gdb_exception) <message>: Now
693         a std::string.
694         (exception_try_scope_entry, exception_try_scope_exit): Don't
695         declare.
696         (struct exception_try_scope): Remove.
697         (TRY): Don't use exception_try_scope.
698         (struct gdb_exception): Add constructor, operator=.
699         <what>: New method.
700         (struct gdb_exception_RETURN_MASK_ALL)
701         (struct gdb_exception_RETURN_MASK_ERROR)
702         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
703         (struct gdb_quit_bad_alloc): Update.
704         * common/common-exceptions.c (exception_none): Change
705         initializer.
706         (struct catcher) <state, exception>: Initialize inline.
707         <prev>: Remove member.
708         (current_catcher): Remove.
709         (catchers): New global.
710         (exceptions_state_mc_init): Simplify.
711         (catcher_pop): Remove.
712         (exceptions_state_mc, exceptions_state_mc_catch): Update.
713         (try_scope_depth, exception_try_scope_entry)
714         (exception_try_scope_exit): Remove.
715         (throw_exception_sjlj): Update.
716         (exception_messages, exception_messages_size): Remove.
717         (throw_it): Simplify.
718         (gdb_exception_sliced_copy): Remove.
719         (throw_exception_cxx): Update.
720         * cli/cli-script.c (script_from_file): Update.
721         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
722         Update.
723         * ada-valprint.c (ada_val_print): Update.
724         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
725         (create_excep_cond_exprs): Update.
726
727 2019-04-08  Tom Tromey  <tom@tromey.com>
728
729         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
730         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
731         (TRY, CATCH, END_CATCH): Remove some definitions.
732         * common/common-exceptions.c: Don't use GDB_XCPT.
733         (catcher_list_size): Remove.
734         (throw_exception, throw_it): Simplify.
735
736 2019-04-05  Tom Tromey  <tom@tromey.com>
737
738         Revert the header-sorting patch.
739         * ft32-tdep.c: Revert.
740         * frv-tdep.c: Revert.
741         * frv-linux-tdep.c: Revert.
742         * frame.c: Revert.
743         * frame-unwind.c: Revert.
744         * frame-base.c: Revert.
745         * fork-child.c: Revert.
746         * findvar.c: Revert.
747         * findcmd.c: Revert.
748         * filesystem.c: Revert.
749         * filename-seen-cache.h: Revert.
750         * filename-seen-cache.c: Revert.
751         * fbsd-tdep.c: Revert.
752         * fbsd-nat.h: Revert.
753         * fbsd-nat.c: Revert.
754         * f-valprint.c: Revert.
755         * f-typeprint.c: Revert.
756         * f-lang.c: Revert.
757         * extension.h: Revert.
758         * extension.c: Revert.
759         * extension-priv.h: Revert.
760         * expprint.c: Revert.
761         * exec.h: Revert.
762         * exec.c: Revert.
763         * exceptions.c: Revert.
764         * event-top.c: Revert.
765         * event-loop.c: Revert.
766         * eval.c: Revert.
767         * elfread.c: Revert.
768         * dwarf2read.h: Revert.
769         * dwarf2read.c: Revert.
770         * dwarf2loc.c: Revert.
771         * dwarf2expr.h: Revert.
772         * dwarf2expr.c: Revert.
773         * dwarf2-frame.c: Revert.
774         * dwarf2-frame-tailcall.c: Revert.
775         * dwarf-index-write.h: Revert.
776         * dwarf-index-write.c: Revert.
777         * dwarf-index-common.c: Revert.
778         * dwarf-index-cache.h: Revert.
779         * dwarf-index-cache.c: Revert.
780         * dummy-frame.c: Revert.
781         * dtrace-probe.c: Revert.
782         * disasm.h: Revert.
783         * disasm.c: Revert.
784         * disasm-selftests.c: Revert.
785         * dictionary.c: Revert.
786         * dicos-tdep.c: Revert.
787         * demangle.c: Revert.
788         * dcache.h: Revert.
789         * dcache.c: Revert.
790         * darwin-nat.h: Revert.
791         * darwin-nat.c: Revert.
792         * darwin-nat-info.c: Revert.
793         * d-valprint.c: Revert.
794         * d-namespace.c: Revert.
795         * d-lang.c: Revert.
796         * ctf.c: Revert.
797         * csky-tdep.c: Revert.
798         * csky-linux-tdep.c: Revert.
799         * cris-tdep.c: Revert.
800         * cris-linux-tdep.c: Revert.
801         * cp-valprint.c: Revert.
802         * cp-support.c: Revert.
803         * cp-namespace.c: Revert.
804         * cp-abi.c: Revert.
805         * corelow.c: Revert.
806         * corefile.c: Revert.
807         * continuations.c: Revert.
808         * completer.h: Revert.
809         * completer.c: Revert.
810         * complaints.c: Revert.
811         * coffread.c: Revert.
812         * coff-pe-read.c: Revert.
813         * cli-out.h: Revert.
814         * cli-out.c: Revert.
815         * charset.c: Revert.
816         * c-varobj.c: Revert.
817         * c-valprint.c: Revert.
818         * c-typeprint.c: Revert.
819         * c-lang.c: Revert.
820         * buildsym.c: Revert.
821         * buildsym-legacy.c: Revert.
822         * build-id.h: Revert.
823         * build-id.c: Revert.
824         * btrace.c: Revert.
825         * bsd-uthread.c: Revert.
826         * breakpoint.h: Revert.
827         * breakpoint.c: Revert.
828         * break-catch-throw.c: Revert.
829         * break-catch-syscall.c: Revert.
830         * break-catch-sig.c: Revert.
831         * blockframe.c: Revert.
832         * block.c: Revert.
833         * bfin-tdep.c: Revert.
834         * bfin-linux-tdep.c: Revert.
835         * bfd-target.c: Revert.
836         * bcache.c: Revert.
837         * ax-general.c: Revert.
838         * ax-gdb.h: Revert.
839         * ax-gdb.c: Revert.
840         * avr-tdep.c: Revert.
841         * auxv.c: Revert.
842         * auto-load.c: Revert.
843         * arm-wince-tdep.c: Revert.
844         * arm-tdep.c: Revert.
845         * arm-symbian-tdep.c: Revert.
846         * arm-pikeos-tdep.c: Revert.
847         * arm-obsd-tdep.c: Revert.
848         * arm-nbsd-tdep.c: Revert.
849         * arm-nbsd-nat.c: Revert.
850         * arm-linux-tdep.c: Revert.
851         * arm-linux-nat.c: Revert.
852         * arm-fbsd-tdep.c: Revert.
853         * arm-fbsd-nat.c: Revert.
854         * arm-bsd-tdep.c: Revert.
855         * arch-utils.c: Revert.
856         * arc-tdep.c: Revert.
857         * arc-newlib-tdep.c: Revert.
858         * annotate.h: Revert.
859         * annotate.c: Revert.
860         * amd64-windows-tdep.c: Revert.
861         * amd64-windows-nat.c: Revert.
862         * amd64-tdep.c: Revert.
863         * amd64-sol2-tdep.c: Revert.
864         * amd64-obsd-tdep.c: Revert.
865         * amd64-obsd-nat.c: Revert.
866         * amd64-nbsd-tdep.c: Revert.
867         * amd64-nbsd-nat.c: Revert.
868         * amd64-nat.c: Revert.
869         * amd64-linux-tdep.c: Revert.
870         * amd64-linux-nat.c: Revert.
871         * amd64-fbsd-tdep.c: Revert.
872         * amd64-fbsd-nat.c: Revert.
873         * amd64-dicos-tdep.c: Revert.
874         * amd64-darwin-tdep.c: Revert.
875         * amd64-bsd-nat.c: Revert.
876         * alpha-tdep.c: Revert.
877         * alpha-obsd-tdep.c: Revert.
878         * alpha-nbsd-tdep.c: Revert.
879         * alpha-mdebug-tdep.c: Revert.
880         * alpha-linux-tdep.c: Revert.
881         * alpha-linux-nat.c: Revert.
882         * alpha-bsd-tdep.c: Revert.
883         * alpha-bsd-nat.c: Revert.
884         * aix-thread.c: Revert.
885         * agent.c: Revert.
886         * addrmap.c: Revert.
887         * ada-varobj.c: Revert.
888         * ada-valprint.c: Revert.
889         * ada-typeprint.c: Revert.
890         * ada-tasks.c: Revert.
891         * ada-lang.c: Revert.
892         * aarch64-tdep.c: Revert.
893         * aarch64-ravenscar-thread.c: Revert.
894         * aarch64-newlib-tdep.c: Revert.
895         * aarch64-linux-tdep.c: Revert.
896         * aarch64-linux-nat.c: Revert.
897         * aarch64-fbsd-tdep.c: Revert.
898         * aarch64-fbsd-nat.c: Revert.
899         * aarch32-linux-nat.c: Revert.
900
901 2019-04-05  Tom Tromey  <tom@tromey.com>
902
903         * ft32-tdep.c: Sort headers.
904         * frv-tdep.c: Sort headers.
905         * frv-linux-tdep.c: Sort headers.
906         * frame.c: Sort headers.
907         * frame-unwind.c: Sort headers.
908         * frame-base.c: Sort headers.
909         * fork-child.c: Sort headers.
910         * findvar.c: Sort headers.
911         * findcmd.c: Sort headers.
912         * filesystem.c: Sort headers.
913         * filename-seen-cache.h: Sort headers.
914         * filename-seen-cache.c: Sort headers.
915         * fbsd-tdep.c: Sort headers.
916         * fbsd-nat.h: Sort headers.
917         * fbsd-nat.c: Sort headers.
918         * f-valprint.c: Sort headers.
919         * f-typeprint.c: Sort headers.
920         * f-lang.c: Sort headers.
921         * extension.h: Sort headers.
922         * extension.c: Sort headers.
923         * extension-priv.h: Sort headers.
924         * expprint.c: Sort headers.
925         * exec.h: Sort headers.
926         * exec.c: Sort headers.
927         * exceptions.c: Sort headers.
928         * event-top.c: Sort headers.
929         * event-loop.c: Sort headers.
930         * eval.c: Sort headers.
931         * elfread.c: Sort headers.
932         * dwarf2read.h: Sort headers.
933         * dwarf2read.c: Sort headers.
934         * dwarf2loc.c: Sort headers.
935         * dwarf2expr.h: Sort headers.
936         * dwarf2expr.c: Sort headers.
937         * dwarf2-frame.c: Sort headers.
938         * dwarf2-frame-tailcall.c: Sort headers.
939         * dwarf-index-write.h: Sort headers.
940         * dwarf-index-write.c: Sort headers.
941         * dwarf-index-common.c: Sort headers.
942         * dwarf-index-cache.h: Sort headers.
943         * dwarf-index-cache.c: Sort headers.
944         * dummy-frame.c: Sort headers.
945         * dtrace-probe.c: Sort headers.
946         * disasm.h: Sort headers.
947         * disasm.c: Sort headers.
948         * disasm-selftests.c: Sort headers.
949         * dictionary.c: Sort headers.
950         * dicos-tdep.c: Sort headers.
951         * demangle.c: Sort headers.
952         * dcache.h: Sort headers.
953         * dcache.c: Sort headers.
954         * darwin-nat.h: Sort headers.
955         * darwin-nat.c: Sort headers.
956         * darwin-nat-info.c: Sort headers.
957         * d-valprint.c: Sort headers.
958         * d-namespace.c: Sort headers.
959         * d-lang.c: Sort headers.
960         * ctf.c: Sort headers.
961         * csky-tdep.c: Sort headers.
962         * csky-linux-tdep.c: Sort headers.
963         * cris-tdep.c: Sort headers.
964         * cris-linux-tdep.c: Sort headers.
965         * cp-valprint.c: Sort headers.
966         * cp-support.c: Sort headers.
967         * cp-namespace.c: Sort headers.
968         * cp-abi.c: Sort headers.
969         * corelow.c: Sort headers.
970         * corefile.c: Sort headers.
971         * continuations.c: Sort headers.
972         * completer.h: Sort headers.
973         * completer.c: Sort headers.
974         * complaints.c: Sort headers.
975         * coffread.c: Sort headers.
976         * coff-pe-read.c: Sort headers.
977         * cli-out.h: Sort headers.
978         * cli-out.c: Sort headers.
979         * charset.c: Sort headers.
980         * c-varobj.c: Sort headers.
981         * c-valprint.c: Sort headers.
982         * c-typeprint.c: Sort headers.
983         * c-lang.c: Sort headers.
984         * buildsym.c: Sort headers.
985         * buildsym-legacy.c: Sort headers.
986         * build-id.h: Sort headers.
987         * build-id.c: Sort headers.
988         * btrace.c: Sort headers.
989         * bsd-uthread.c: Sort headers.
990         * breakpoint.h: Sort headers.
991         * breakpoint.c: Sort headers.
992         * break-catch-throw.c: Sort headers.
993         * break-catch-syscall.c: Sort headers.
994         * break-catch-sig.c: Sort headers.
995         * blockframe.c: Sort headers.
996         * block.c: Sort headers.
997         * bfin-tdep.c: Sort headers.
998         * bfin-linux-tdep.c: Sort headers.
999         * bfd-target.c: Sort headers.
1000         * bcache.c: Sort headers.
1001         * ax-general.c: Sort headers.
1002         * ax-gdb.h: Sort headers.
1003         * ax-gdb.c: Sort headers.
1004         * avr-tdep.c: Sort headers.
1005         * auxv.c: Sort headers.
1006         * auto-load.c: Sort headers.
1007         * arm-wince-tdep.c: Sort headers.
1008         * arm-tdep.c: Sort headers.
1009         * arm-symbian-tdep.c: Sort headers.
1010         * arm-pikeos-tdep.c: Sort headers.
1011         * arm-obsd-tdep.c: Sort headers.
1012         * arm-nbsd-tdep.c: Sort headers.
1013         * arm-nbsd-nat.c: Sort headers.
1014         * arm-linux-tdep.c: Sort headers.
1015         * arm-linux-nat.c: Sort headers.
1016         * arm-fbsd-tdep.c: Sort headers.
1017         * arm-fbsd-nat.c: Sort headers.
1018         * arm-bsd-tdep.c: Sort headers.
1019         * arch-utils.c: Sort headers.
1020         * arc-tdep.c: Sort headers.
1021         * arc-newlib-tdep.c: Sort headers.
1022         * annotate.h: Sort headers.
1023         * annotate.c: Sort headers.
1024         * amd64-windows-tdep.c: Sort headers.
1025         * amd64-windows-nat.c: Sort headers.
1026         * amd64-tdep.c: Sort headers.
1027         * amd64-sol2-tdep.c: Sort headers.
1028         * amd64-obsd-tdep.c: Sort headers.
1029         * amd64-obsd-nat.c: Sort headers.
1030         * amd64-nbsd-tdep.c: Sort headers.
1031         * amd64-nbsd-nat.c: Sort headers.
1032         * amd64-nat.c: Sort headers.
1033         * amd64-linux-tdep.c: Sort headers.
1034         * amd64-linux-nat.c: Sort headers.
1035         * amd64-fbsd-tdep.c: Sort headers.
1036         * amd64-fbsd-nat.c: Sort headers.
1037         * amd64-dicos-tdep.c: Sort headers.
1038         * amd64-darwin-tdep.c: Sort headers.
1039         * amd64-bsd-nat.c: Sort headers.
1040         * alpha-tdep.c: Sort headers.
1041         * alpha-obsd-tdep.c: Sort headers.
1042         * alpha-nbsd-tdep.c: Sort headers.
1043         * alpha-mdebug-tdep.c: Sort headers.
1044         * alpha-linux-tdep.c: Sort headers.
1045         * alpha-linux-nat.c: Sort headers.
1046         * alpha-bsd-tdep.c: Sort headers.
1047         * alpha-bsd-nat.c: Sort headers.
1048         * aix-thread.c: Sort headers.
1049         * agent.c: Sort headers.
1050         * addrmap.c: Sort headers.
1051         * ada-varobj.c: Sort headers.
1052         * ada-valprint.c: Sort headers.
1053         * ada-typeprint.c: Sort headers.
1054         * ada-tasks.c: Sort headers.
1055         * ada-lang.c: Sort headers.
1056         * aarch64-tdep.c: Sort headers.
1057         * aarch64-ravenscar-thread.c: Sort headers.
1058         * aarch64-newlib-tdep.c: Sort headers.
1059         * aarch64-linux-tdep.c: Sort headers.
1060         * aarch64-linux-nat.c: Sort headers.
1061         * aarch64-fbsd-tdep.c: Sort headers.
1062         * aarch64-fbsd-nat.c: Sort headers.
1063         * aarch32-linux-nat.c: Sort headers.
1064
1065 2019-04-04  Tom Tromey  <tom@tromey.com>
1066
1067         * varobj.c (varobj_create): Update.
1068         * rust-exp.y (struct rust_parser) <update_innermost_block,
1069         lookup_symbol>: New methods.
1070         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
1071         Rename.
1072         (rust_parser::rust_lookup_type)
1073         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1074         * printcmd.c (display_command, do_one_display): Update.
1075         * parser-defs.h (struct parser_state) <parser_state>: Add
1076         "tracker" parameter.
1077         (block_tracker): New member.
1078         (class innermost_block_tracker) <innermost_block_tracker>: Add
1079         "types" parameter.
1080         <reset>: Remove method.
1081         (innermost_block): Don't declare.
1082         (null_post_parser): Update.
1083         * parse.c (innermost_block): Remove global.
1084         (write_dollar_variable): Update.
1085         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
1086         Remove "tracker_types" parameter.
1087         (parse_expression): Add "tracker" parameter.
1088         (parse_expression_for_completion): Update.
1089         (null_post_parser): Add "tracker" parameter.
1090         * p-exp.y: Update rules.
1091         * m2-exp.y: Update rules.
1092         * language.h (struct language_defn) <la_post_parser>: Add
1093         "tracker" parameter.
1094         * go-exp.y: Update rules.
1095         * f-exp.y: Update rules.
1096         * expression.h (parse_expression, parse_exp_1): Add "tracker"
1097         parameter.
1098         * d-exp.y: Update rules.
1099         * c-exp.y: Update rules.
1100         * breakpoint.c (set_breakpoint_condition): Create an
1101         innermost_block_tracker.
1102         (watch_command_1): Likewise.
1103         * ada-lang.c (resolve): Add "tracker" parameter.
1104         (resolve_subexp): Likewise.
1105         * ada-exp.y (write_var_from_sym): Update.
1106
1107 2019-04-04  Tom Tromey  <tom@tromey.com>
1108
1109         * type-stack.h: New file.
1110         * type-stack.c: New file.
1111         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
1112         type-stack.h.
1113         (insert_into_type_stack, insert_type, push_type, push_type_int)
1114         (insert_type_address_space, pop_type, pop_type_int)
1115         (pop_typelist, pop_type_stack, append_type_stack)
1116         (push_type_stack, get_type_stack, push_typelist)
1117         (follow_type_instance_flags, follow_types): Don't declare.
1118         * parse.c (type_stack): Remove global.
1119         (parse_exp_in_context): Update.
1120         (insert_into_type_stack, insert_type, push_type, push_type_int)
1121         (insert_type_address_space, pop_type, pop_type_int)
1122         (pop_typelist, pop_type_stack, append_type_stack)
1123         (push_type_stack, get_type_stack, push_typelist)
1124         (follow_type_instance_flags, follow_types): Remove (moved to
1125         type-stack.c).
1126         * f-exp.y (type_stack): New global.
1127         Update rules.
1128         (push_kind_type, f_parse): Update.
1129         * d-exp.y (type_stack): New global.
1130         Update rules.
1131         (d_parse): Update.
1132         * c-exp.y (struct c_parse_state) <type_stack>: New member.
1133         Update rules.
1134         * Makefile.in (COMMON_SFILES): Add type-stack.c.
1135         (HFILES_NO_SRCDIR): Add type-stack.h.
1136
1137 2019-04-04  Tom Tromey  <tom@tromey.com>
1138
1139         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
1140         (rust_parser::convert_ast_to_expression, rust_parse)
1141         (rust_lex_test_completion, rust_lex_tests): Update.
1142         * parser-defs.h (struct expr_completion_state): New.
1143         (struct parser_state) <parser_state>: Add completion parameter.
1144         <mark_struct_expression, mark_completion_tag>: New methods.
1145         <parse_completion, m_completion_state>: New members.
1146         (prefixify_expression, null_post_parser): Update.
1147         (mark_struct_expression, mark_completion_tag): Don't declare.
1148         * parse.c (parse_completion, expout_last_struct)
1149         (expout_tag_completion_type, expout_completion_name): Remove
1150         globals.
1151         (parser_state::mark_struct_expression)
1152         (parser_state::mark_completion_tag): Now methods.
1153         (prefixify_expression): Add last_struct parameter.
1154         (prefixify_subexp): Likewise.
1155         (parse_exp_1): Update.
1156         (parse_exp_in_context): Add cstate parameter.  Update.
1157         (parse_expression_for_completion): Create an
1158         expr_completion_state.
1159         (null_post_parser): Add "completion" parameter.
1160         * p-exp.y: Update rules.
1161         (yylex): Update.
1162         * language.h (struct language_defn) <la_post_parser>: Add
1163         "completing" parameter.
1164         * go-exp.y: Update rules.
1165         (lex_one_token): Update.
1166         * expression.h (parse_completion): Don't declare.
1167         * d-exp.y: Update rules.
1168         (lex_one_token): Update rules.
1169         * c-exp.y: Update rules.
1170         (lex_one_token): Update.
1171         * ada-lang.c (resolve): Add "parse_completion" parameter.
1172         (resolve_subexp): Likewise.
1173         (ada_resolve_function): Likewise.
1174
1175 2019-04-04  Tom Tromey  <tom@tromey.com>
1176
1177         * parser-defs.h (struct parser_state) <start_arglist,
1178         end_arglist>: New methods.
1179         <arglist_len, m_funcall_chain>: New members.
1180         (arglist_len, start_arglist, end_arglist): Don't declare.
1181         * parse.c (arglist_len, funcall_chain): Remove global.
1182         (start_arglist, end_arglist): Remove functions.
1183         (parse_exp_in_context): Update.
1184         * p-exp.y: Update rules.
1185         * m2-exp.y: Update rules.
1186         * go-exp.y: Update rules.
1187         * f-exp.y: Update rules.
1188         * d-exp.y: Update rules.
1189         * c-exp.y: Update rules.
1190
1191 2019-04-04  Tom Tromey  <tom@tromey.com>
1192
1193         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
1194         lex_operator, push_back>: New methods.
1195         Update all rules.
1196         (rust_parser::lex_hex, lex_escape): Rename and update.
1197         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
1198         (rust_parser::lex_operator): Rename and update.
1199         (rust_parser::lex_number, rustyylex, rustyyerror)
1200         (rust_lex_test_init, rust_lex_test_sequence)
1201         (rust_lex_test_push_back, rust_lex_tests): Update.
1202         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
1203         parameter.
1204         <lexptr, prev_lexptr>: New members.
1205         (lexptr, prev_lexptr): Don't declare.
1206         * parse.c (lexptr, prev_lexptr): Remove globals.
1207         (parse_exp_in_context): Update.
1208         * p-exp.y (yylex, yyerror): Update.
1209         * m2-exp.y (parse_number, yylex, yyerror): Update.
1210         * go-exp.y (lex_one_token, yyerror): Update.
1211         * f-exp.y (match_string_literal, yylex, yyerror): Update.
1212         * d-exp.y (lex_one_token, yyerror): Update.
1213         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
1214         (lex_one_token, yyerror): Update.
1215         * ada-lex.l (YY_INPUT): Update.
1216         (rewind_to_char): Update.
1217         * ada-exp.y (yyerror): Update.
1218
1219 2019-04-04  Tom Tromey  <tom@tromey.com>
1220
1221         * rust-exp.y (rustyylex, rust_lex_tests): Update.
1222         * parser-defs.h (struct parser_state) <parser_state>: Add new
1223         parameter.
1224         <comma_terminates>: New member.
1225         (comma_terminates): Don't declare global.
1226         * parse.c (comma_terminates): Remove global.
1227         (parse_exp_in_context): Update.
1228         * p-exp.y (yylex): Update.
1229         * m2-exp.y (yylex): Update.
1230         * go-exp.y (lex_one_token): Update.
1231         * f-exp.y (yylex): Update.
1232         * d-exp.y (lex_one_token): Update.
1233         * c-exp.y (lex_one_token): Update.
1234         * ada-lex.l: Update.
1235
1236 2019-04-04  Tom Tromey  <tom@tromey.com>
1237
1238         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
1239         (rustyylex, rust_lex_test_init, rust_lex_test_one)
1240         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
1241         * parser-defs.h (paren_depth): Don't declare.
1242         * parse.c (paren_depth): Remove global.
1243         (parse_exp_in_context): Update.
1244         * p-exp.y (paren_depth): New global.
1245         (pascal_parse): Initialize it.
1246         * m2-exp.y (paren_depth): New global.
1247         (m2_parse): Initialize it.
1248         * go-exp.y (paren_depth): New global.
1249         (go_parse): Initialize it.
1250         * f-exp.y (paren_depth): New global.
1251         (f_parse): Initialize it.
1252         * d-exp.y (paren_depth): New global.
1253         (d_parse): Initialize it.
1254         * c-exp.y (paren_depth): New global.
1255         (c_parse): Initialize it.
1256         * ada-lex.l (paren_depth): New global.
1257         (lexer_init): Initialize it.
1258
1259 2019-04-04  Tom Tromey  <tom@tromey.com>
1260
1261         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
1262         (rust_parser::convert_ast_to_type)
1263         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1264         * parser-defs.h (struct parser_state) <parser_state>: Add
1265         parameters.  Initialize new members.
1266         <expression_context_block, expression_context_pc>: New members.
1267         * parse.c (expression_context_block, expression_context_pc):
1268         Remove globals.
1269         (parse_exp_in_context): Update.
1270         * p-exp.y: Update all rules.
1271         (yylex): Update.
1272         * m2-exp.y: Update all rules.
1273         (yylex): Update.
1274         * go-exp.y (yylex): Update.
1275         * f-exp.y (yylex): Update.
1276         * d-exp.y: Update all rules.
1277         (yylex): Update.
1278         * c-exp.y: Update all rules.
1279         (lex_one_token, classify_name, yylex, c_parse): Update.
1280         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
1281
1282 2019-04-04  Tom Tromey  <tom@tromey.com>
1283
1284         * gdbarch.h, gdbarch.c: Rebuild.
1285         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
1286         * stap-probe.h: 
1287         (struct stap_parse_info): Replace "parser_state" with
1288         "expr_builder".
1289         * parser-defs.h (struct expr_builder): Rename from "parser_state".
1290         (parser_state): New class.
1291         * parse.c (expr_builder): Rename.
1292         (expr_builder::release): Rename.
1293         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
1294         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
1295         (write_exp_elt_longcst, write_exp_elt_floatcst)
1296         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
1297         (write_exp_string_vector, write_exp_bitstring)
1298         (write_exp_msymbol, mark_struct_expression)
1299         (write_dollar_variable)
1300         (insert_type_address_space, increase_expout_size): Replace
1301         "parser_state" with "expr_builder".
1302         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
1303         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
1304         "parser_state" with "expr_builder".
1305
1306 2019-04-04  Tom Tromey  <tom@tromey.com>
1307
1308         * rust-exp.y: Replace "parse_language" with method call.
1309         * p-exp.y: 
1310         (yylex): Replace "parse_language" with method call.
1311         * m2-exp.y: 
1312         (yylex): Replace "parse_language" with method call.
1313         * go-exp.y (classify_name): Replace "parse_language" with method
1314         call.
1315         * f-exp.y (yylex): Replace "parse_language" with method call.
1316         * d-exp.y (lex_one_token): Replace "parse_language" with method
1317         call.
1318         * c-exp.y: 
1319         (lex_one_token, classify_name, yylex): Replace "parse_language"
1320         with method call.
1321         * ada-exp.y (find_primitive_type, type_char)
1322         (type_system_address): Replace "parse_language" with method call.
1323
1324 2019-04-04  Tom Tromey  <tom@tromey.com>
1325
1326         * rust-exp.y: Replace "parse_gdbarch" with method call.
1327         * parse.c (write_dollar_variable, insert_type_address_space):
1328         Replace "parse_gdbarch" with method call.
1329         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
1330         call.
1331         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
1332         call.
1333         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
1334         "parse_gdbarch" with method call.
1335         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
1336         with method call.
1337         * f-exp.y (parse_type, parse_f_type, yylex): Replace
1338         "parse_gdbarch" with method call.
1339         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
1340         "parse_gdbarch" with method call.
1341         * c-exp.y (parse_type, parse_number, classify_name): Replace
1342         "parse_gdbarch" with method call.
1343         * ada-lex.l: Replace "parse_gdbarch" with method call.
1344         * ada-exp.y (parse_type, find_primitive_type, type_char)
1345         (type_system_address): Replace "parse_gdbarch" with method call.
1346
1347 2019-04-04  Tom Tromey  <tom@tromey.com>
1348
1349         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
1350         * stap-probe.c (stap_parse_argument): Update.
1351         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
1352         initial_size parameter.
1353         * rust-exp.y (rust_lex_tests): Update.
1354         * parse.c (parser_state): Update.
1355         (parse_exp_in_context): Update.
1356         * parser-defs.h (struct parser_state) <parser_state>: Remove
1357         "initial_size" parameter.
1358
1359 2019-04-04  Tom Tromey  <tom@tromey.com>
1360
1361         * parser-defs.h (increase_expout_size): Don't declare.
1362         * parse.c (increase_expout_size): Now static.
1363
1364 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
1365
1366         * gnu-nat.c (gnu_nat_target::wait): Fix
1367         target_waitstatus_to_string call.
1368
1369 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1370
1371         * eval.c (evaluate_subexp_standard): Handle internal functions
1372         during Fortran function call handling.
1373
1374 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1375
1376         * NEWS: Mention new internal functions.
1377         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
1378         (read_base_type): Use dwarf2_init_complex_target_type.
1379         * value.c (creal_internal_fn): New function.
1380         (cimag_internal_fn): New function.
1381         (_initialize_values): Register new internal functions.
1382
1383 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1384
1385         * infrun.c (stop_all_threads): If debug_infrun, always
1386         trace the wait status after wait_one, using
1387         target_waitstatus_to_string and target_pid_to_str.
1388         (handle_inferior_event): Replace various trace of
1389         wait status kind by a single trace.
1390         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
1391         wait status kind image by target_waitstatus_to_string.
1392         * target/waitstatus.c (target_waitstatus_to_string): Fix
1393         obsolete comment.
1394
1395 2019-04-01  Tom Tromey  <tromey@adacore.com>
1396
1397         PR symtab/23331:
1398         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
1399
1400 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
1401             Pedro Alves  <palves@redhat.com>
1402
1403         * top.c (quit_force): Call 'finalize_values'.
1404         * value.c (finalize_values): New function.
1405         * value.h (finalize_values): Declare.
1406
1407 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
1408
1409         * NEWS: Announce $_gdb_major and $_gdb_minor.
1410
1411         * top.c (init_gdb_version_vars): New function.
1412         (gdb_init): Call init_gdb_version_vars.
1413
1414 2019-03-29  Tom Tromey  <tromey@adacore.com>
1415
1416         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
1417         help text.  Remove dead code.
1418
1419 2019-03-29  Keith Seitz  <keiths@redhat.com>
1420
1421         From Siddhesh Poyarekar:
1422         * f-lang.h (f77_get_upperbound): Return LONGEST.
1423         (f77_get_lowerbound): Likewise.
1424         * f-typeprint.c (f_type_print_varspec_suffix): Expand
1425         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
1426         print them.
1427         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
1428         plongest to format print it.
1429         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
1430         (f77_get_upperbound): Likewise.
1431         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
1432         LOWER_BOUND to LONGEST.
1433         (f77_create_arrayprint_offset_tbl): Likewise.
1434
1435 2019-03-29  Keith Seitz  <keiths@redhat.com>
1436
1437         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
1438         %s/pulongest for TYPE_LENGTH instead of %d in format
1439         strings.
1440         * ada-typerint.c (ada_print_type): Likewise.
1441         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
1442         * compile/compile-c-support.c (generate_register_struct): Likewise.
1443         * gdbtypes.c (recursive_dump_type): Likewise.
1444         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
1445         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
1446         instead of %d in format strings.
1447         * riscv-tdep.c (riscv_type_alignment): Cast second argument
1448         to std::min to ULONGEST.
1449         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
1450         instead of %d in format strings.
1451         * tracepoint.c (info_scope_command): Likewise.
1452         * typeprint.c (print_offset_data::update)
1453         (print_offset_data::finish): Likewise.
1454         * xtensa-tdep.c (xtensa_store_return_value)
1455         (xtensa_push_dummy_call): Likewise.
1456
1457 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
1458
1459         * windows-nat.c (display_selector): Fixed format specifications
1460         for 64-bit Cygwin.
1461
1462 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1463
1464         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
1465
1466 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
1467
1468         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
1469         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
1470         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
1471         (nios2_linux_init_abi): Install it.
1472
1473 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1474
1475         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
1476
1477 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1478
1479         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
1480
1481 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1482             Tom Tromey  <tromey@adacore.com>
1483
1484         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
1485
1486 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
1487
1488         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
1489         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
1490         method to compute the bounds of range types. Also print "[evaluated]"
1491         if the bounds' values come from a dynamic evaluation.
1492
1493 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1494
1495         * cp-valprint.c (cp_print_value_fields): Don't print trailing
1496         whitespace when pretty printing is on.
1497
1498 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1499
1500         * ppc-linux-nat.c: Add include.
1501
1502 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1503
1504         * NEWS: Mention AArch64 Pointer Authentication.
1505
1506 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1507
1508         * arm-linux-nat.c: Add include.
1509
1510 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
1511
1512         * source-cache.c (source_cache::get_source_lines): Re-read
1513         fullname after calling open_source_file.
1514
1515 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
1516
1517         * NEWS: Mention TLS support for FreeBSD.
1518
1519 2019-03-25  Tom Tromey  <tromey@adacore.com>
1520
1521         * minsyms.c (BUNCH_SIZE): Update comment.
1522         (~minimal_symbol_reader): Remove old comment.
1523         (compact_minimal_symbols): Update comment.
1524         (minimal_symbol_reader::install): Remove old comment.  Update
1525         other comments.
1526
1527 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1528
1529         * s390-linux-nat.c: Add include.
1530
1531 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1532
1533         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1534         Call linux_get_hwcap.
1535         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
1536         Likewise.
1537         (aarch64_linux_get_hwcap): Remove function.
1538         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
1539         declaration.
1540         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
1541         linux_get_hwcap.
1542         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1543         * linux-tdep.c (linux_get_hwcap): Add function.
1544         (linux_get_hwcap2): Likewise.
1545         * linux-tdep.h (linux_get_hwcap): Add declaration.
1546         (linux_get_hwcap2): Likewise.
1547         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
1548         (ppc_linux_get_hwcap2): Likewise.
1549         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
1550         linux_get_hwcap.
1551         (ppc_linux_nat_target::insert_watchpoint): Likewise.
1552         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
1553         (ppc_linux_nat_target::read_description): Likewise.
1554         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
1555         * s390-linux-nat.c: Likewise.
1556         * s390-linux-tdep.c (s390_core_read_description): Likewise.
1557
1558 2019-03-24  Tom Tromey  <tom@tromey.com>
1559
1560         * ada-lang.c (standard_lookup): Simplify initialization.
1561         (ada_lookup_symbol_nonlocal): Simplify return.
1562         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
1563         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
1564         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
1565         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
1566         initialization.
1567         * solib.c (solib_global_lookup): Simplify.
1568         * symtab.c (null_block_symbol): Remove.
1569         (symbol_cache_lookup): Simplify returns.
1570         (lookup_language_this): Simplify returns.
1571         (lookup_symbol_aux): Simplify return.
1572         (lookup_local_symbol): Simplify returns.
1573         (lookup_global_symbol_from_objfile): Simplify return.
1574         (lookup_symbol_in_objfile_symtabs)
1575         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
1576         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
1577         (lookup_static_symbol, lookup_global_symbol): Simplify return.
1578         * cp-namespace.c (cp_lookup_bare_symbol)
1579         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
1580         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
1581         (cp_lookup_nested_symbol): Don't use null_block_symbol.
1582         (cp_lookup_symbol_via_imports): Simplify initialization.
1583         (find_symbol_in_baseclass): Likewise.
1584         * symtab.h (null_block_symbol): Remove.
1585         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
1586         (d_lookup_nested_symbol, d_lookup_symbol_imports)
1587         (d_lookup_symbol_module): Likewise.
1588         (find_symbol_in_baseclass): Simplify initialization.
1589
1590 2019-03-24  Tom Tromey  <tom@tromey.com>
1591
1592         * expression.h: Don't include symtab.h.
1593         (struct block): Forward declare.
1594
1595 2019-03-24  Tom Tromey  <tom@tromey.com>
1596
1597         * c-exp.y (typebase): Remove casts.
1598         * gdbtypes.c (lookup_unsigned_typename, )
1599         (lookup_signed_typename): Remove cast.
1600         * eval.c (parse_to_comma_and_eval): Remove cast.
1601         * parse.c (write_dollar_variable): Remove cast.
1602         * block.h (struct block) <superblock>: Now const.
1603         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
1604         * psymtab.c (psym_map_matching_symbols): Make "block" const.
1605         (map_block): Make "block" const.
1606         * symfile.h (struct quick_symbol_functions)
1607         <map_matching_symbols>: Constify block argument to "callback".
1608         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
1609         const.
1610         (find_pc_sect_compunit_symtab): Make "b" const.
1611         (find_symbol_at_address): Likewise.
1612         (search_symbols): Likewise.
1613         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
1614         (dw2_debug_names_lookup_symbol): Likewise.
1615         (dw2_map_matching_symbols): Update.
1616         * p-valprint.c (pascal_val_print): Remove "block".
1617         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
1618         (aux_add_nonlocal_symbols): Make "block" const.
1619         (resolve_subexp): Remove cast.
1620         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
1621         const.
1622         (iterate_over_file_blocks): Likewise.
1623         * f-exp.y (%union) <bval>: Remove.
1624         * coffread.c (patch_opaque_types): Make "b" const.
1625         * spu-tdep.c (spu_catch_start): Make "block" const.
1626         * c-valprint.c (print_unpacked_pointer): Remove "block".
1627         * symmisc.c (dump_symtab_1): Make "b" const.
1628         (block_depth): Make "block" const.
1629         * d-exp.y (%union) <bval>: Remove.
1630         * cp-support.h (cp_lookup_rtti_type): Update.
1631         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
1632         * psymtab.c (psym_lookup_symbol): Make "block" const.
1633         (maintenance_check_psymtabs): Make "b" const.
1634         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
1635         (enumerate_locals, enumerate_args): Update.
1636         * python/py-symtab.c (stpy_global_block): Make "block" const.
1637         (stpy_static_block): Likewise.
1638         * inline-frame.c (block_starting_point_at): Make "new_block"
1639         const.
1640         * block.c (find_block_in_blockvector): Make return type const.
1641         (blockvector_for_pc_sect): Make "b" const.
1642         (find_block_in_blockvector): Make "b" const.
1643
1644 2019-03-23  Tom Tromey  <tom@tromey.com>
1645
1646         * varobj.c (varobj_create): Update.
1647         * symfile.c (clear_symtab_users): Don't reset innermost_block.
1648         * printcmd.c (display_command, do_one_display): Don't reset
1649         innermost_block.
1650         * parser-defs.h (enum innermost_block_tracker_type): Move to
1651         expression.h.
1652         (innermost_block): Update comment.
1653         * parse.c (parse_exp_1): Add tracker_types parameter.
1654         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
1655         tracker_types parameter.  Reset innermost_block.
1656         (parse_exp_in_context): Remove.
1657         (parse_expression_for_completion): Update.
1658         * objfiles.c (~objfile): Don't reset expression_context_block or
1659         innermost_block.
1660         * expression.h (enum innermost_block_tracker_type): Move from
1661         parser-defs.h.
1662         (parse_exp_1): Add tracker_types parameter.
1663         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
1664         reset innermost_block.
1665
1666 2019-03-23  Tom Tromey  <tom@tromey.com>
1667
1668         * objfiles.h: Include bcache.h.
1669
1670 2019-03-23  Tom Tromey  <tom@tromey.com>
1671
1672         * linespec.c (get_current_search_block): Use
1673         scoped_restore_current_language.
1674         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
1675
1676 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1677             Jiong Wang  <jiong.wang@arm.com>
1678
1679         * aarch64-linux-tdep.c
1680         (aarch64_linux_iterate_over_regset_sections): Check for pauth
1681         section.
1682         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
1683
1684 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1685             Jiong Wang  <jiong.wang@arm.com>
1686
1687         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
1688         instructions.
1689         (aarch64_analyze_prologue_test): Add PACIASP test.
1690         (aarch64_prologue_prev_register): Unmask PC value.
1691
1692 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1693             Jiong Wang  <jiong.wang@arm.com>
1694
1695         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
1696         (aarch64_dwarf2_prev_register): Unmask PC value.
1697         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
1698         (aarch64_execute_dwarf_cfa_vendor_op): Check for
1699         DW_CFA_AARCH64_negate_ra_state.
1700         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
1701
1702 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1703             Jiong Wang  <jiong.wang@arm.com>
1704
1705         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
1706         registers.
1707         (aarch64_pseudo_register_name): Likewise.
1708         (aarch64_pseudo_register_type): Likewise.
1709         (aarch64_pseudo_register_reggroup_p): Likewise.
1710         (aarch64_gdbarch_init): Add pauth registers.
1711         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
1712         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
1713         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
1714         (struct gdbarch_tdep): Add regnum for ra_state.
1715
1716 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1717             Jiong Wang  <jiong.wang@arm.com>
1718
1719         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
1720
1721 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1722             Jiong Wang  <jiong.wang@arm.com>
1723
1724         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
1725         function.
1726         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
1727         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
1728         (aarch64_gdbarch_init): Add puth registers.
1729         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
1730         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
1731         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
1732
1733 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1734             Jiong Wang  <jiong.wang@arm.com>
1735
1736         * aarch64-linux-nat.c
1737         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
1738         * aarch64-linux-tdep.c
1739         (aarch64_linux_core_read_description): Likewise.
1740         (aarch64_linux_get_hwcap): New function.
1741         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
1742         (aarch64_linux_get_hwcap): New declaration.
1743
1744 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1745             Jiong Wang  <jiong.wang@arm.com>
1746
1747         * aarch64-linux-nat.c
1748         (aarch64_linux_nat_target::read_description): Add pauth param.
1749         * aarch64-linux-tdep.c
1750         (aarch64_linux_core_read_description): Likewise.
1751         * aarch64-tdep.c (struct target_desc): Add in pauth.
1752         (aarch64_read_description): Add pauth param.
1753         (aarch64_gdbarch_init): Likewise.
1754         * aarch64-tdep.h (aarch64_read_description): Likewise.
1755         * arch/aarch64.c (aarch64_create_target_description): Likewise.
1756         * arch/aarch64.h (aarch64_create_target_description): Likewise.
1757         * features/Makefile: Add new files.
1758         * features/aarch64-pauth.c: New file.
1759         * features/aarch64-pauth.xml: New file.
1760
1761 2019-03-20  Tom Tromey  <tromey@adacore.com>
1762
1763         * infrun.c (handle_inferior_event): Rename from
1764         handle_inferior_event_1.  Create a scoped_value_mark.
1765         (handle_inferior_event): Remove.
1766
1767 2019-03-19  Tom Tromey  <tromey@adacore.com>
1768
1769         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
1770         * infrun.h (print_stop_event): Add "displays" parameter.
1771         * infrun.c (print_stop_event): Add "displays" parameter.
1772
1773 2019-03-19  Pedro Alves  <palves@redhat.com>
1774
1775         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
1776         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
1777         to -1.  Fix TABs vs spaces.
1778         (tui_ui_out::tui_ui_out): Don't initialize fields here.
1779         * tui/tui-out.h (tui_ui_out) Add intro comments.
1780         <m_line, m_start_of_line>: In-class initialize, and add describing
1781         comment.
1782
1783 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
1784
1785         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
1786         variable names.
1787         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
1788
1789 2019-03-18  Pedro Alves  <palves@redhat.com>
1790             Eli Zaretskii <eliz@gnu.org>
1791
1792         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
1793         m_line and m_start_of_line.
1794
1795 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
1796
1797         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
1798         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
1799         it returns a newline.  This fixes a regression in TU mode, whereby
1800         the next line is output on the same screen line as the user input.
1801
1802 2019-03-18  Tom Tromey  <tromey@adacore.com>
1803
1804         * minsyms.c (minimal_symbol_reader::install): Remove call to
1805         obstack_blank.
1806
1807 2019-03-18  Pedro Alves  <palves@redhat.com>
1808
1809         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
1810         New globals.
1811         (apply_style): New, factored out from ...
1812         (apply_ansi_escape): ... this.  Handle reverse video mode.
1813         (tui_set_reverse_mode): New function.
1814         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
1815         * tui/tui-winsource.c (tui_show_source_line): Use
1816         tui_set_reverse_mode instead of setting A_STANDOUT.
1817         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
1818         New setter methods.
1819
1820 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
1821
1822         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
1823         Handle tabs.
1824
1825 2019-03-18  Tom Tromey  <tromey@adacore.com>
1826
1827         * ada-lang.c (empty_array): Add "high" parameter.
1828         (ada_evaluate_subexp): Update.
1829
1830 2019-03-17  Sergei Trofimovich <siarheit@google.com>
1831
1832         * unittests/string_view-selftests.c: Define
1833         _initialize_string_view_selftests unconditionally.
1834
1835 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
1836
1837         PR gdb/24350
1838         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
1839
1840 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
1841
1842         PR gdb/24351
1843         * windows-nat.c (display_selector): Fix format specifiers.
1844
1845 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
1846
1847         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
1848         tui_refill_source_window instead of tui_refresh_win, to update the
1849         current execution line.  This fixes redisplay of the current line
1850         when stepping through the code with "next" or "step".
1851
1852 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
1853
1854         * source-cache.c (source_cache::get_source_lines): Call
1855         find_source_lines to initialize s->nlines.  This fixes vertical
1856         scrolling of TUI source window when the DOWN arrow is pressed.
1857
1858 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1859
1860         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
1861         linux-thread-db.c (_initialize_thread_db): Likewise.
1862
1863 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
1864
1865         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
1866         wclrtoeol in tui_show_source_line".  This reverts changes made in
1867         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
1868
1869 2019-03-15  Tom Tromey  <tom@tromey.com>
1870
1871         * symtab.h (struct minimal_symbol): Derive from
1872         general_symbol_info.
1873         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
1874         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
1875         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
1876         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
1877         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
1878         (MSYMBOL_SEARCH_NAME): Update.
1879         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
1880         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
1881         * minsyms.c (minimal_symbol_reader::record_full): Update.
1882
1883 2019-03-15  Tom Tromey  <tom@tromey.com>
1884
1885         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
1886
1887 2019-03-15  Tom Tromey  <tom@tromey.com>
1888
1889         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
1890         unique_xmalloc_ptr.
1891         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
1892         Update.
1893         * minsyms.c (lookup_minimal_symbol_by_pc_section)
1894         (build_minimal_symbol_hash_tables)
1895         (minimal_symbol_reader::install): Update.
1896
1897 2019-03-15  Tom Tromey  <tom@tromey.com>
1898
1899         * symtab.c (create_demangled_names_hash): Update.
1900         (symbol_set_names): Update.
1901         * objfiles.h (struct objfile_per_bfd_storage)
1902         <demangled_names_hash>: Now an htab_up.
1903         * objfiles.c (objfile_per_bfd_storage): Simplify.
1904
1905 2019-03-15  Tom Tromey  <tom@tromey.com>
1906
1907         * objfiles.h (struct objfile_per_bfd_storage): Declare
1908         destructor.
1909         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
1910         New.
1911         (get_objfile_bfd_data): Use new.  Don't initialize
1912         language_of_main.
1913         (free_objfile_per_bfd_storage): Remove.
1914         (objfile_bfd_data_free, objfile::~objfile): Use delete.
1915
1916 2019-03-15  Tom Tromey  <tom@tromey.com>
1917
1918         * symfile.c (reread_symbols): Update.
1919         * objfiles.c (objfile::objfile): Update.
1920         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
1921         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
1922         comment.
1923         (minimal_symbol_reader::install): Update.
1924         (terminate_minimal_symbol_table): Remove.
1925         * jit.c (jit_object_close_impl): Update.
1926
1927 2019-03-15  Tom Tromey  <tom@tromey.com>
1928
1929         * minsyms.c (minimal_symbol_reader::record_full): Remove some
1930         initializations.
1931
1932 2019-03-15  Tom Tromey  <tom@tromey.com>
1933
1934         * objfiles.h (struct objfile_per_bfd_storage)
1935         <demangled_hash_languages>: Now a bitset.
1936         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
1937         (lookup_minimal_symbol): Update.
1938
1939 2019-03-15  Tom Tromey  <tom@tromey.com>
1940
1941         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
1942         Don't return the symbol.
1943         * coffread.c (record_minimal_symbol): Use record_full.
1944
1945 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
1946
1947         The MS-Windows port of ncurses fails to switch to a color pair if
1948         one or both of the colors are the implicit default colors.  This
1949         change records the default colors when TUI is initialized, and
1950         then specifies them explicitly when a color pair uses the default
1951         colors.  This allows color styling in TUI mode on MS-Windows.
1952
1953         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
1954         ncurses_norm_attr.
1955         (tui_initialize_io) [__MINGW32__]: Record the default terminal
1956         colors in ncurses_norm_attr.
1957         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
1958         "none", replace it with the default color recorded in
1959         ncurses_norm_attr.
1960
1961 2019-03-14  Tom Tromey  <tromey@adacore.com>
1962
1963         * source-cache.h (class source_cache) <get_source_lines>: Return
1964         std::string.
1965         * source-cache.c (source_cache::extract_lines): Handle case where
1966         first_pos==npos.  Return std::string.
1967         (source_cache::get_source_lines): Update.
1968
1969 2019-03-14  Tom Tromey  <tromey@adacore.com>
1970
1971         * NEWS: Add item for "style sources" commands.
1972         * source-cache.c (source_cache::get_source_lines): Check
1973         source_styling.
1974         * cli/cli-style.c (source_styling): New global.
1975         (_initialize_cli_style): Add "style sources" commands.
1976         (show_style_sources): New function.
1977         * cli/cli-style.h (source_styling): Declare.
1978
1979 2019-03-14  Pedro Alves  <palves@redhat.com>
1980             Tom Tromey  <tromey@adacore.com>
1981
1982         * tui/tui-winsource.h (tui_refill_source_window): Declare.
1983         * tui/tui-winsource.c (tui_refill_source_window): New function,
1984         from...
1985         (tui_horizontal_source_scroll): ... here.  Move some logic.
1986         * cli/cli-style.c (set_style_enabled): Notify new observable.
1987         * tui/tui-hooks.c (tui_redisplay_source): New function.
1988         (tui_attach_detach_observers): Attach or detach
1989         tui_redisplay_source.
1990         * observable.h (source_styling_changed): New observable.
1991         * observable.c: Define source_styling_changed observable.
1992
1993 2019-03-13  Tom Tromey  <tromey@adacore.com>
1994
1995         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
1996         (i386_gnu_nat_target::store_registers): Update.
1997         * target-debug.h (target_debug_print_std_string): New macro.
1998         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1999         * windows-tdep.c (display_one_tib): Update.
2000         * tui/tui-stack.c (tui_make_status_line): Update.
2001         * top.c (print_inferior_quit_action): Update.
2002         * thread.c (thr_try_catch_cmd): Update.
2003         (add_thread_with_info): Update.
2004         (thread_target_id_str): Update.
2005         (thr_try_catch_cmd): Update.
2006         (thread_command): Update.
2007         (thread_find_command): Update.
2008         * record-btrace.c (record_btrace_target::info_record)
2009         (record_btrace_resume_thread, record_btrace_target::resume)
2010         (record_btrace_cancel_resume, record_btrace_step_thread)
2011         (record_btrace_target::wait, record_btrace_target::wait)
2012         (record_btrace_target::wait, record_btrace_target::stop): Update.
2013         * progspace.c (print_program_space): Update.
2014         * process-stratum-target.c
2015         (process_stratum_target::thread_address_space): Update.
2016         * linux-fork.c (linux_fork_mourn_inferior)
2017         (detach_checkpoint_command, info_checkpoints_command)
2018         (linux_fork_context): Update.
2019         (linux_fork_detach): Update.
2020         (class scoped_switch_fork_info): Update.
2021         (delete_checkpoint_command): Update.
2022         * infrun.c (follow_fork_inferior): Update.
2023         (follow_fork_inferior): Update.
2024         (proceed_after_vfork_done): Update.
2025         (handle_vfork_child_exec_or_exit): Update.
2026         (follow_exec): Update.
2027         (displaced_step_prepare_throw): Update.
2028         (displaced_step_restore): Update.
2029         (start_step_over): Update.
2030         (resume_1): Update.
2031         (clear_proceed_status_thread): Update.
2032         (proceed): Update.
2033         (print_target_wait_results): Update.
2034         (do_target_wait): Update.
2035         (context_switch): Update.
2036         (stop_all_threads): Update.
2037         (restart_threads): Update.
2038         (finish_step_over): Update.
2039         (handle_signal_stop): Update.
2040         (switch_back_to_stepped_thread): Update.
2041         (keep_going_pass_signal): Update.
2042         (print_exited_reason): Update.
2043         (normal_stop): Update.
2044         * inferior.c (inferior_pid_to_str): Change return type.
2045         (print_selected_inferior): Update.
2046         (add_inferior): Update.
2047         (detach_inferior): Update.
2048         * dummy-frame.c (fprint_dummy_frames): Update.
2049         * dcache.c (dcache_info_1): Update.
2050         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
2051         (btrace_fetch, btrace_clear): Update.
2052         * linux-tdep.c (linux_core_pid_to_str): Change return type.
2053         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
2054         type.
2055         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
2056         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
2057         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
2058         * gdbarch.c, gdbarch.h: Rebuild.
2059         * gdbarch.sh (core_pid_to_str): Change return type.
2060         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
2061         return type.
2062         (windows_nat_target::pid_to_str): Change return type.
2063         (windows_delete_thread): Update.
2064         (windows_nat_target::attach): Update.
2065         (windows_nat_target::files_info): Update.
2066         * target-delegates.c: Rebuild.
2067         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
2068         return type.
2069         (sol_thread_target::pid_to_str): Change return type.
2070         * remote.c (class remote_target) <pid_to_str>: Change return
2071         type.
2072         (remote_target::pid_to_str): Change return type.
2073         (extended_remote_target::attach, remote_target::remote_stop_ns)
2074         (remote_target::remote_notif_remove_queued_reply)
2075         (remote_target::push_stop_reply, remote_target::disable_btrace):
2076         Update.
2077         (extended_remote_target::attach): Update.
2078         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
2079         type.
2080         (gdbsim_target::pid_to_str): Change return type.
2081         * ravenscar-thread.c (struct ravenscar_thread_target)
2082         <pid_to_str>: Change return type.
2083         (ravenscar_thread_target::pid_to_str): Change return type.
2084         * procfs.c (class procfs_target) <pid_to_str>: Change return
2085         type.
2086         (procfs_target::pid_to_str): Change return type.
2087         (procfs_target::attach): Update.
2088         (procfs_target::detach): Update.
2089         (procfs_target::fetch_registers): Update.
2090         (procfs_target::store_registers): Update.
2091         (procfs_target::wait): Update.
2092         (procfs_target::files_info): Update.
2093         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
2094         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
2095         return type.
2096         (nto_procfs_target::pid_to_str): Change return type.
2097         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
2098         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
2099         return type.
2100         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
2101         (exit_lwp): Update.
2102         (attach_proc_task_lwp_callback, get_detach_signal)
2103         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
2104         (linux_nat_target::resume, wait_lwp, stop_callback)
2105         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
2106         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
2107         (linux_nat_wait_1, resume_stopped_resumed_lwps)
2108         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
2109         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
2110         type.
2111         (inf_ptrace_target::attach): Update.
2112         (inf_ptrace_target::files_info): Update.
2113         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
2114         type.
2115         (go32_nat_target::pid_to_str): Change return type.
2116         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
2117         (gnu_nat_target::wait): Update.
2118         (gnu_nat_target::wait): Update.
2119         (gnu_nat_target::resume): Update.
2120         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
2121         (fbsd_nat_target::wait): Update.
2122         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
2123         type.
2124         (darwin_nat_target::attach): Update.
2125         * corelow.c (class core_target) <pid_to_str>: Change return type.
2126         (core_target::pid_to_str): Change return type.
2127         * target.c (normal_pid_to_str): Change return type.
2128         (default_pid_to_str): Likewise.
2129         (target_pid_to_str): Change return type.
2130         (target_translate_tls_address): Update.
2131         (target_announce_detach): Update.
2132         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
2133         return type.
2134         (bsd_uthread_target::pid_to_str): Change return type.
2135         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
2136         type.
2137         (bsd_kvm_target::pid_to_str): Change return type.
2138         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
2139         return type.
2140         (aix_thread_target::pid_to_str): Change return type.
2141         * target.h (struct target_ops) <pid_to_str>: Change return type.
2142         (target_pid_to_str, normal_pid_to_str): Likewise.
2143         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
2144         type.
2145         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
2146         type.
2147         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
2148         return type.
2149         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
2150         type.
2151         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
2152         type.
2153         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
2154         return type.
2155
2156 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
2157
2158         * NEWS: Mention that the new default MI version is 3.  Mention
2159         changes to the output of commands and events that deal with
2160         multi-location breakpoints.
2161         * breakpoint.c: Include "mi/mi-out.h".
2162         (print_one_breakpoint): Change output syntax if using MI version
2163         >= 3.
2164         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
2165         New.
2166         (mi_multi_location_breakpoint_output_fixed): New.
2167         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
2168         (mi_cmd_fix_multi_location_breakpoint_output): New.
2169         (mi_multi_location_breakpoint_output_fixed): New.
2170         * mi/mi-cmds.c (mi_cmds): Register command
2171         -fix-multi-location-breakpoint-output.
2172         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
2173         interpreter "mi".
2174
2175 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
2176
2177         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
2178         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
2179         instantiate mi_ui_out based on interpreter name.
2180         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
2181         * mi/mi-main.c (mi_load_progress): Likewise.
2182
2183 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2184
2185         * NEWS: Combine separate "New targets" sections for 8.3.
2186
2187 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2188
2189         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
2190         (ppcfbsd_init_abi): Install gdbarch
2191         "fetch_tls_load_module_address" and "get_thread_local_address"
2192         methods.
2193
2194 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2195
2196         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
2197         (riscv_fbsd_init_abi): Install gdbarch
2198         "fetch_tls_load_module_address" and "get_thread_local_address"
2199         methods.
2200
2201 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2202
2203         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
2204         (i386fbsd_init_abi): Install gdbarch
2205         "fetch_tls_load_module_address" and "get_thread_local_address"
2206         methods.
2207
2208 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2209
2210         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
2211         (amd64fbsd_init_abi): Install gdbarch
2212         "fetch_tls_load_module_address" and "get_thread_local_address"
2213         methods.
2214
2215 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2216
2217         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
2218         (struct fbsd_pspace_data): New type.
2219         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
2220         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
2221         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
2222         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
2223         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
2224
2225 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2226
2227         * gdbtypes.c (lookup_struct_elt): New function.
2228         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
2229         * gdbtypes.h (struct struct_elt): New type.
2230         (lookup_struct_elt): New prototype.
2231
2232 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2233
2234         * gdbtypes.c (lookup_struct_elt_type): Update comment and
2235         remove disabled code block.
2236
2237 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2238
2239         * gdbarch.sh (get_thread_local_address): New method.
2240         * gdbarch.h, gdbarch.c: Regenerate.
2241         * target.c (target_translate_tls_address): Use
2242         gdbarch_get_thread_local_address if present instead of
2243         target::get_thread_local_address.
2244
2245 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2246
2247         * target.h (target::get_thread_local_address): Update comment.
2248
2249 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2250
2251         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
2252         objfile->separate_debug_objfile_backlink if not NULL.
2253
2254 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2255
2256         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
2257         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
2258         (amd64bsd_store_inferior_registers): Likewise.
2259         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2260         Enable segment base registers.
2261         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
2262         PT_GETFSBASE and PT_GETGSBASE.
2263         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
2264         PT_SETGSBASE.
2265         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
2266         segment base registers.
2267         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2268
2269 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2270
2271         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2272         Update calls to i386_target_description to add 'segments'
2273         parameter.
2274         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
2275         add segment base registers.
2276         * arch/i386.c (i386_create_target_description): Add 'segments'
2277         parameter to enable segment base registers.
2278         * arch/i386.h (i386_create_target_description): Likewise.
2279         * features/i386/32bit-segments.xml: New file.
2280         * features/i386/32bit-segments.c: Generate.
2281         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
2282         call to i386_target_description to add 'segments' parameter.
2283         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2284         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
2285         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
2286         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
2287         if feature is present.
2288         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
2289         Add 'segments' parameter to call to i386_target_description.
2290         (i386_target_description): Add 'segments' parameter to enable
2291         segment base registers.
2292         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
2293         to call to i386_target_description.
2294         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
2295         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
2296         Define I386_NUM_REGS.
2297         (i386_target_description): Add 'segments' parameter to enable
2298         segment base registers.
2299
2300 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
2301
2302         PR/24325
2303         * source-cache.c: #undef open and close, to avoid unresolved
2304         externals during linking.
2305
2306 2019-03-12  Tom Tromey  <tromey@adacore.com>
2307
2308         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
2309         const.  Add initializers.
2310         (_initialize_remote): Don't initialize ptid globals.
2311
2312 2019-03-12  Pedro Alves  <palves@redhat.com>
2313
2314         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
2315
2316 2019-03-12  Pedro Alves  <palves@redhat.com>
2317
2318         * cp-name-parser.y (main): Remove unused 'len' variable.
2319
2320 2019-03-12  Tom Tromey  <tromey@adacore.com>
2321
2322         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
2323         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
2324
2325 2019-03-12  Tom Tromey  <tromey@adacore.com>
2326
2327         * linux-nat.c (iterate_over_lwps): Update.
2328         (stop_callback): Remove parameter.
2329         (stop_wait_callback, detach_callback, resume_set_callback)
2330         (select_singlestep_lwp_callback, set_ignore_sigint)
2331         (status_callback, resumed_callback, resume_clear_callback)
2332         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
2333         data parameter.
2334         (linux_nat_target::detach, linux_nat_target::resume)
2335         (linux_stop_and_wait_all_lwps, select_event_lwp)
2336         (linux_nat_filter_event, linux_nat_wait_1)
2337         (linux_nat_target::kill, linux_nat_target::stop)
2338         (linux_nat_target::stop): Update.
2339         (linux_nat_resume_callback): Change type.
2340         (resume_stopped_resumed_lwps, count_events_callback)
2341         (select_event_lwp_callback): Likewise.
2342         (linux_stop_lwp, linux_nat_stop_lwp): Update.
2343         * arm-linux-nat.c (struct update_registers_data): Remove.
2344         (update_registers_callback): Change type.
2345         (arm_linux_insert_hw_breakpoint1): Update.
2346         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
2347         parameter.
2348         (x86_linux_dr_set_addr): Update.
2349         (x86_linux_dr_set_control): Update.
2350         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
2351         (iterate_over_lwps): Use gdb::function_view.
2352         * nat/aarch64-linux-hw-point.c (struct
2353         aarch64_dr_update_callback_param): Remove.
2354         (debug_reg_change_callback): Change type.
2355         (aarch64_notify_debug_reg_change): Update.
2356         * s390-linux-nat.c (s390_refresh_per_info): Update.
2357
2358 2019-03-11  Tom Tromey  <tromey@adacore.com>
2359
2360         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
2361         redundant assignment to "this_cu".
2362
2363 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2364
2365         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
2366
2367 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2368
2369         * gdbtypes.c (rank_one_type_parm_set): New function extracted
2370         from...
2371         (rank_one_type): ... this.
2372
2373 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2374
2375         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
2376         from...
2377         (rank_one_type): ... this.
2378
2379 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2380
2381         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
2382         from...
2383         (rank_one_type): ... this.
2384
2385 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2386
2387         * gdbtypes.c (rank_one_type_parm_float): New function extracted
2388         from...
2389         (rank_one_type): ... this.
2390
2391 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2392
2393         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
2394         from...
2395         (rank_one_type): ... this.
2396
2397 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2398
2399         * gdbtypes.c (rank_one_type_parm_range): New function extracted
2400         from...
2401         (rank_one_type): ... this.
2402
2403 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2404
2405         * gdbtypes.c (rank_one_type_parm_char): New function extracted
2406         from...
2407         (rank_one_type): ... this.
2408
2409 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2410
2411         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
2412         from...
2413         (rank_one_type): ... this.
2414
2415 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2416
2417         * gdbtypes.c (rank_one_type_parm_int): New function extracted
2418         from...
2419         (rank_one_type): ... this.
2420
2421 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2422
2423         * gdbtypes.c (rank_one_type_parm_func): New function extracted
2424         from...
2425         (rank_one_type): ... this.
2426
2427 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2428
2429         * gdbtypes.c (rank_one_type_parm_array): New function extracted
2430         from...
2431         (rank_one_type): ... this.
2432
2433 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2434
2435         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
2436         from...
2437         (rank_one_type): ... this.
2438
2439 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2440
2441         * inferior.c (initialize_inferiors): Ensure 'help set/show print
2442         inferior-events' shows the example events.
2443
2444 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
2445
2446         Support styling on native MS-Windows console
2447
2448         PR/24315
2449         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
2450         on MS-Windows if $TERM is not defined.
2451
2452         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
2453
2454         * posix-hdep.c (gdb_console_fputs):
2455         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
2456         functions.
2457         * ui-file.h (gdb_console_fputs): Add prototype.
2458
2459         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
2460         back to fputs only if the former returns zero.
2461
2462 2019-03-07  Tom Tromey  <tom@tromey.com>
2463
2464         * symmisc.c (print_symbol_bcache_statistics): Update.
2465         (print_objfile_statistics): Update.
2466         * symfile.c (allocate_symtab): Update.
2467         * stabsread.c: Don't include bcache.h.
2468         * psymtab.h (struct psymbol_bcache): Don't declare.
2469         (class psymtab_storage) <psymbol_cache>: Now a bcache.
2470         (psymbol_bcache_init, psymbol_bcache_free)
2471         (psymbol_bcache_get_bcache): Don't declare.
2472         * psymtab.c (struct psymbol_bcache): Remove.
2473         (psymtab_storage::psymtab_storage): Update.
2474         (psymtab_storage::~psymtab_storage): Update.
2475         (psymbol_bcache_init, psymbol_bcache_free)
2476         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
2477         (add_psymbol_to_bcache): Update.
2478         (allocate_psymtab): Update.
2479         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
2480         macro_cache>: No longer pointers.
2481         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
2482         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
2483         * macrotab.c (macro_bcache): Update.
2484         * macroexp.c: Don't include bcache.h.
2485         * gdbtypes.c (check_types_worklist): Update.
2486         (types_deeply_equal): Remove TRY/CATCH.  Update.
2487         * elfread.c (elf_symtab_read): Update.
2488         * dwarf2read.c: Don't include bcache.h.
2489         * buildsym.c (buildsym_compunit::get_macro_table): Update.
2490         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
2491         (print_bcache_statistics, bcache_memory_used): Don't declare.
2492         (struct bcache): Move from bcache.c.  Add constructor, destructor,
2493         methods.  Rename all data members.
2494         * bcache.c (struct bcache): Move to bcache.h.
2495         (bcache::expand_hash_table): Rename from expand_hash_table.
2496         (bcache): Remove.
2497         (bcache::insert): Rename from bcache_full.
2498         (bcache::compare): Rename from bcache_compare.
2499         (bcache_xmalloc): Remove.
2500         (bcache::~bcache): Rename from bcache_xfree.
2501         (bcache::print_statistics): Rename from print_bcache_statistics.
2502         (bcache::memory_used): Rename from bcache_memory_used.
2503
2504 2019-03-07  Pedro Alves  <palves@redhat.com>
2505
2506         * infrun.c (normal_stop): Also check for
2507         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
2508
2509 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
2510
2511         * f-lang.c (value_from_host_double): Moved to...
2512         * value.c (value_from_host_double): ...here.
2513         * value.h (value_from_host_double): Declare.
2514         * guile/scm-math.c (vlscm_convert_typed_number): Use
2515         value_from_host_double.
2516         (vlscm_convert_number): Likewise.
2517         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
2518         * python/py-value.c (convert_value_from_python): Likewise.
2519
2520 2019-03-06  Tom Tromey  <tom@tromey.com>
2521
2522         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
2523
2524 2019-03-06  Tom Tromey  <tom@tromey.com>
2525
2526         * utils.h (free_current_contents): Don't declare.
2527         * utils.c (free_current_contents): Remove.
2528
2529 2019-03-06  Tom Tromey  <tom@tromey.com>
2530
2531         * top.c (quit_force): Update.
2532         * main.c (captured_command_loop): Update.
2533         * common/new-op.c (operator new): Update.
2534         * common/common-exceptions.c (struct catcher)
2535         <save_cleanup_chain>: Remove member.
2536         (exceptions_state_mc_init): Update.
2537         (exception_try_scope_entry): Return nullptr.
2538         (exception_try_scope_exit, exception_rethrow)
2539         (throw_exception_sjlj, throw_exception_cxx): Update.
2540         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
2541         (all_cleanups, do_cleanups, discard_cleanups)
2542         (discard_final_cleanups, save_cleanups, save_final_cleanups)
2543         (restore_cleanups, restore_final_cleanups): Don't declare.
2544         (do_final_cleanups): Remove parameter.
2545         * common/cleanups.c (cleanup_chain, make_cleanup)
2546         (make_cleanup_dtor, all_cleanups, do_cleanups)
2547         (discard_my_cleanups, discard_cleanups)
2548         (discard_final_cleanups, save_my_cleanups, save_cleanups)
2549         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
2550         (null_cleanup): Remove.
2551         (do_final_cleanups): Remove parameter.
2552
2553 2019-03-06  Tom Tromey  <tom@tromey.com>
2554
2555         * remote.c (remote_target::remote_parse_stop_reply): Use
2556         unique_xmalloc_ptr.
2557
2558 2019-03-06  Tom Tromey  <tom@tromey.com>
2559
2560         * stabsread.c (struct stabs_field_info): Rename from field_info.
2561         <list, fnlist>: Add initializers.
2562         <obstack>: New member.
2563         (read_member_functions, read_struct_fields, read_baseclasses):
2564         Allocate on obstack.  Don't use cleanups.
2565         (read_one_struct_field, read_member_functions, read_struct_fields)
2566         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
2567         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
2568         (read_struct_type): Update.
2569
2570 2019-03-06  Tom Tromey  <tom@tromey.com>
2571
2572         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
2573         * common/filestuff.h (make_cleanup_close): Don't declare.
2574         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
2575         Remove.
2576
2577 2019-03-06  Tom Tromey  <tom@tromey.com>
2578
2579         * solib-aix.c: Use make_scope_exit.
2580
2581 2019-03-06  Tom Tromey  <tom@tromey.com>
2582
2583         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
2584         Use make_scope_exit.
2585
2586 2019-03-06  Tom Tromey  <tom@tromey.com>
2587
2588         * solib-svr4.c (disable_probes_interface): Remove parameter.
2589         (svr4_handle_solib_event): Use make_scope_exit.
2590
2591 2019-03-06  Tom Tromey  <tom@tromey.com>
2592
2593         * remote.c (struct stop_reply_deleter): Remove.
2594         (stop_reply_up): Update.
2595         (struct stop_reply): Derive from notif_event.  Don't typedef.
2596         <regcache>: Now a std::vector.
2597         (stop_reply_xfree): Remove.
2598         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
2599         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
2600         (remote_target::discard_pending_stop_replies): Use delete.
2601         (remote_target::remote_parse_stop_reply): Update.
2602         (remote_target::process_stop_reply): Update.
2603         * remote-notif.h (struct notif_event): Add virtual destructor.
2604         Remove "dtr" member.
2605         (struct notif_client) <alloc_event>: Return a unique_ptr.
2606         (notif_event_xfree): Don't declare.
2607         (notif_event_up): New typedef.
2608         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
2609         (notif_event_xfree, do_notif_event_xfree): Remove.
2610         (remote_notif_state_xfree): Update.
2611
2612 2019-03-06  Tom Tromey  <tom@tromey.com>
2613
2614         * infrun.c (displaced_step_clear_cleanup): Now a
2615         forward_scope_exit type.
2616         (displaced_step_prepare_throw): Update.
2617         (displaced_step_fixup): Update.
2618
2619 2019-03-06  Tom Tromey  <tom@tromey.com>
2620
2621         * inferior.h (class inferior): Update comment.
2622         * gdbthread.h (class thread_info): Update comment.
2623
2624 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
2625             Tom Tromey  <tom@tromey.com>
2626
2627         * stabsread.h (struct stab_section_list): Remove.
2628         (coffstab_build_psymtabs): Update.
2629         * dbxread.c (symbuf_sections): Now a std::vector.
2630         (sect_idx): New global.
2631         (fill_symbuf): Update.
2632         (coffstab_build_psymtabs): Change type of stabsects parameter.
2633         Update.
2634         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
2635         std::vector.
2636         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
2637         (coff_locate_sections): Update.
2638         (coff_symfile_read): Remove cleanups.  Update.
2639         (init_stringtab): Add storage parameter.
2640         (free_stringtab, free_stringtab_cleanup): Remove.
2641         (init_lineno): Add storage parameter.
2642         (free_linetab, free_linetab_cleanup): Remove.
2643
2644 2019-03-06  Pedro Alves  <palves@redhat.com>
2645
2646         * linux-fork.c (fork_info::clobber_regs): Delete.
2647         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
2648         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
2649         comment.  Adjust.
2650         (scoped_switch_fork_info::scoped_switch_fork_info)
2651         (checkpoint_command, linux_fork_context): Adjust
2652         fork_save_infrun_state calls.
2653
2654 2019-03-06  Pedro Alves  <palves@redhat.com>
2655
2656         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
2657         (inf_has_multiple_threads): Return 'bool' and rewrite using
2658         inferior_info::threads().
2659
2660 2019-03-06  Pedro Alves  <palves@redhat.com>
2661
2662         * linux-fork.c: Include <list>.
2663         (fork_list): Now a std::list instance.
2664         (fork_info): Add ctor, dtor, and in-class initialize all fields.
2665         (forks_exist_p, find_last_fork): Adjust.
2666         (new_fork): Delete.
2667         (one_fork_p): New.
2668         (add_fork): Adjust.
2669         (free_fork): Delete, folded into fork_info::~fork_info().
2670         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
2671         Adjust.
2672         (init_fork_list): Delete.
2673         (linux_fork_killall, linux_fork_mourn_inferior)
2674         (linux_fork_detach, info_checkpoints_command): Adjust.
2675         (_initialize_linux_fork): No longer call init_fork_list.
2676
2677 2019-03-06  Pedro Alves  <palves@redhat.com>
2678
2679         * linux-fork.c (new_fork): New, split out of ...
2680         (add_fork): ... this.  Return void.  Move "first fork" special
2681         case from here, to ...
2682         (checkpoint_command): ... here.
2683         * linux-linux.h (add_fork): Return void.
2684
2685 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2686
2687         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
2688
2689 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2690             Chris January  <chris.january@arm.com>
2691             David Lecomber  <david.lecomber@arm.com>
2692
2693         * f-exp.y: New token, UNOP_INTRINSIC.
2694         (exp): New pattern using UNOP_INTRINSIC token.
2695         (f77_keywords): Add 'abs' keyword.
2696         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
2697         (value_from_host_double): New function.
2698         (evaluate_subexp_f): Support UNOP_ABS.
2699
2700 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2701
2702         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
2703         types.
2704
2705 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2706
2707         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
2708         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
2709         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
2710
2711 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2712
2713         * f-exp.y (convert_to_kind_type): Handle more type kinds.
2714
2715 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2716             Chris January  <chris.january@arm.com>
2717
2718         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
2719         * f-exp.y: Define 'KIND' token.
2720         (exp): New pattern for KIND expressions.
2721         (ptype): Handle types with a kind extension.
2722         (direct_abs_decl): Extend to spot kind extensions.
2723         (f77_keywords): Add 'kind' to the list.
2724         (push_kind_type): New function.
2725         (convert_to_kind_type): New function.
2726         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
2727         * parse.c (operator_length_standard): Likewise.
2728         * parser-defs.h (enum type_pieces): Add tp_kind.
2729         * std-operator.def: Add UNOP_KIND.
2730
2731 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2732
2733         * f-exp.y (f_parse): Set yydebug.
2734
2735 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2736
2737         * f-lang.c (evaluate_subexp_f): New function.
2738         (exp_descriptor_f): New global.
2739         (f_language_defn): Use exp_descriptor_f instead of
2740         exp_descriptor_standard.
2741
2742 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2743
2744         * f-exp.y (struct token): Add comments.
2745         (dot_ops): Remove uppercase versions and the end marker.
2746         (f77_keywords): Likewise.
2747         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
2748         entries in the dot_ops array are case insensitive, and use
2749         strncasecmp to compare strings.  Also some whitespace cleanup in
2750         this area.  Similar for the f77_keywords array, except entries in
2751         this list might be case sensitive.
2752
2753 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2754
2755         * f-exp.y (struct f77_boolean_val): Add comments.
2756         (boolean_values): Remove uppercase versions, and end marker.
2757         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
2758         and use strncasecmp to achieve case insensitivity.  Additionally,
2759         perform whitespace cleanup around this code.
2760
2761 2019-03-06  Tom Tromey  <tromey@adacore.com>
2762
2763         * remote-sim.c (gdbsim_target_open): Use result of
2764         gdb_argv::release.
2765
2766 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
2767         Dirk Schubert  <dirk.schubert@arm.com>
2768         Chris January  <chris.january@arm.com>
2769
2770         * eval.c (evaluate_subexp_standard): Call Fortran argument
2771         wrapping logic.
2772         * f-lang.c (struct value): A value which can be passed into a
2773         Fortran function call.
2774         (fortran_argument_convert): Wrap Fortran arguments in a pointer
2775         where appropriate.
2776         (struct type): Value ready for a Fortran function call.
2777         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
2778         is needed.
2779         * f-lang.h (fortran_argument_convert): Declaration.
2780         (fortran_preserve_arg_pointer): Declaration.
2781         * infcall.c (value_arg_coerce): Call Fortran argument logic.
2782
2783 2019-03-05  Tom Tromey  <tromey@adacore.com>
2784
2785         * python/py-prettyprint.c (print_string_repr): Remove #if.
2786         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
2787
2788 2019-03-05  Tom Tromey  <tromey@adacore.com>
2789
2790         * target.c (the_dummy_target): Move later.  Change type to
2791         "dummy_target".
2792         (initialize_targets): Don't initialize the_dummy_target.
2793
2794 2019-03-05  Tom Tromey  <tromey@adacore.com>
2795
2796         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
2797         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
2798
2799 2019-03-05  Tom Tromey  <tromey@adacore.com>
2800
2801         * windows-nat.c (windows_nat_target::attach)
2802         (windows_nat_target::detach): Don't call gdb_flush.
2803         * valprint.c (generic_val_print, val_print, val_print_string):
2804         Don't call gdb_flush.
2805         * utils.c (defaulted_query): Don't call gdb_flush.
2806         * typeprint.c (print_type_scalar): Don't call gdb_flush.
2807         * target.c (target_announce_detach): Don't call gdb_flush.
2808         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
2809         * remote.c (extended_remote_target::attach): Don't call
2810         gdb_flush.
2811         * procfs.c (procfs_target::detach): Don't call gdb_flush.
2812         * printcmd.c (do_examine): Don't call gdb_flush.
2813         (info_display_command): Don't call gdb_flush.
2814         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
2815         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
2816         * memattr.c (info_mem_command): Don't call gdb_flush.
2817         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
2818         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
2819         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
2820         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
2821         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
2822         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
2823         (gnu_nat_target::detach): Don't call gdb_flush.
2824         * f-valprint.c (f_val_print): Don't call gdb_flush.
2825         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
2826         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
2827         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
2828         gdb_flush.
2829         * c-valprint.c (c_val_print): Don't call gdb_flush.
2830         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
2831
2832 2019-03-05  Tom Tromey  <tromey@adacore.com>
2833
2834         * varobj.c (update_dynamic_varobj_children): Update.
2835         (install_default_visualizer): Use reset, not release.
2836         * value.c (set_internalvar): Update.
2837         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
2838         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
2839         ATTRIBUTE_UNUSED_RESULT.
2840
2841 2019-03-05  Tom Tromey  <tromey@adacore.com>
2842
2843         * remote.c (class scoped_remote_fd) <release>: Add
2844         ATTRIBUTE_UNUSED_RESULT.
2845
2846 2019-03-05  Tom Tromey  <tromey@adacore.com>
2847
2848         * macroexp.c (struct macro_buffer) <release>: Add
2849         ATTRIBUTE_UNUSED_RESULT.
2850
2851 2019-03-05  Tom Tromey  <tromey@adacore.com>
2852
2853         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
2854         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
2855         ATTRIBUTE_UNUSED_RESULT.
2856
2857 2019-03-05  Tom Tromey  <tromey@adacore.com>
2858
2859         * common/scoped_fd.h (class scoped_fd) <release>: Add
2860         ATTRIBUTE_UNUSED_RESULT.
2861
2862 2019-03-05  Tom Tromey  <tromey@adacore.com>
2863
2864         * parser-defs.h (struct parser_state) <release>: Add
2865         ATTRIBUTE_UNUSED_RESULT.
2866
2867 2019-03-05  Tom Tromey  <tromey@adacore.com>
2868
2869         * utils.h (class gdb_argv) <release>: Add
2870         ATTRIBUTE_UNUSED_RESULT.
2871         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
2872
2873 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
2874
2875         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
2876         for-loop range, to avoid compiler warnings.
2877
2878         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
2879         avoid compiler warnings about unused variables.
2880
2881         * NEWS: Mention end of support for native debugging on MS-Windows
2882         before XP.
2883
2884         PR gdb/24292
2885         * common/netstuff.c:
2886         * gdbserver/gdbreplay.c
2887         * gdbserver/remote-utils.c:
2888         * ser-tcp.c:
2889         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
2890         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
2891         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
2892         'getaddrinfo' and 'freeaddrinfo' were not available before
2893         Windows XP, and mingw.org's MinGW headers by default define
2894         _WIN32_WINNT to 0x500.
2895
2896 2019-03-01  Gary Benson <gbenson@redhat.com>
2897
2898         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
2899
2900 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
2901             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2902
2903         PR gdb/8527
2904         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
2905         set_sigint_trap, clear_sigint_trap.
2906
2907 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2908
2909         * target.c (target_detach): Clear the regcache and the
2910         frame cache.
2911
2912 2019-02-27  Pedro Alves  <palves@redhat.com>
2913
2914         * utils.c (set_screen_size): When we cap the height/width sizes,
2915         tweak the corresponding command variable to show "unlimited":
2916
2917 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
2918             Pedro Alves  <palves@redhat.com>
2919
2920         * utils.c (set_screen_size): Reduce "infinite" rows and columns
2921         before calling rl_set_screen_size.
2922
2923 2019-02-27  Tom Tromey  <tromey@adacore.com>
2924
2925         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
2926         define.
2927         * python/py-value.c: Remove Python 2.4 workaround.
2928         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
2929         workaround.
2930         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
2931         Python 2.4 workaround.
2932         * python/python-internal.h: Remove Python 2.4 comment.
2933         (Py_ssize_t): Don't define.
2934         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
2935         (gdb_Py_DECREF): Remove Python 2.4 workaround.
2936         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
2937         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
2938         * python/python.c (do_start_initialization): Remove Python 2.4
2939         workaround.
2940         * python/py-prettyprint.c (class dummy_python_frame): Remove.
2941         (print_children): Remove Python 2.4 workaround.
2942         * python/py-inferior.c (buffer_procs): Remove Python 2.4
2943         workaround.
2944         (CHARBUFFERPROC_NAME): Remove.
2945         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
2946         Python 2.4 workaround.
2947
2948 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
2949
2950         * NEWS: Note minimum Python version.
2951
2952 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
2953
2954         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
2955         code from these functions.  Remove corresponding ifdefs.  Use
2956         Py_buffer_up instead of explicit calls to PyBuffer_Release.
2957         Remove gotos and target of gotos.
2958         (infpy_search_memory): Likewise.
2959
2960 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2961
2962         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
2963         (hppa_gdbarch_init): Don't register deleted functions with
2964         gdbarch.
2965
2966 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2967
2968         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
2969         (h8300_unwind_sp): Delete.
2970         (h8300_dummy_id): Delete.
2971         (h8300_gdbarch_init): Don't register deleted functions with
2972         gdbarch.
2973
2974 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2975
2976         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
2977         (ft32_unwind_pc): Delete.
2978         (ft32_unwind_sp): Delete.
2979         (ft32_gdbarch_init): Don't register deleted functions with
2980         gdbarch.
2981
2982 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2983
2984         * gdb/frv-tdep.c (frv_dummy_id): Delete.
2985         (frv_unwind_pc): Delete.
2986         (frv_unwind_sp): Delete.
2987         (frv_gdbarch_init): Don't register deleted functions with
2988         gdbarch.
2989
2990 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2991
2992         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
2993         (riscv_unwind_pc): Delete.
2994         (riscv_unwind_sp): Delete.
2995         (riscv_gdbarch_init): Don't register deleted functions with
2996         gdbarch.
2997
2998 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2999
3000         * gdb/csky-tdep.c (csky_dummy_id): Delete.
3001         (csky_unwind_pc): Delete.
3002         (csky_unwind_sp): Delete.
3003         (csky_gdbarch_init): Don't register deleted functions with
3004         gdbarch.
3005
3006 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3007
3008         * gdb/cris-tdep.c (cris_dummy_id): Delete.
3009         (cris_unwind_pc): Delete.
3010         (cris_unwind_sp): Delete.
3011         (cris_gdbarch_init): Don't register deleted functions with
3012         gdbarch.
3013
3014 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3015
3016         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
3017         (bfin_unwind_pc): Delete.
3018         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
3019
3020 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3021
3022         * gdb/arm-tdep.c (arm_dummy_id): Delete.
3023         (arm_unwind_pc): Delete.
3024         (arm_unwind_sp): Delete.
3025         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
3026
3027 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3028
3029         * gdb/arc-tdep.c (arc_dummy_id): Delete.
3030         (arc_unwind_pc): Delete.
3031         (arc_unwind_sp): Delete.
3032         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
3033
3034 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3035
3036         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
3037         (alpha_unwind_pc): Delete.
3038         (alpha_gdbarch_init): Don't register deleted functions with
3039         gdbarch.
3040
3041 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3042
3043         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
3044         (aarch64_unwind_pc): Delete.
3045         (aarch64_unwind_sp): Delete.
3046         (aarch64_gdbarch_init): Don't register deleted functions with
3047         gdbarch.
3048
3049 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3050
3051         * gdbtypes.c (type_align): Don't consider static members when
3052         computing structure alignment.
3053
3054 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3055
3056         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
3057         return 0 for other types.
3058         * arch-utils.c (default_type_align): Always return 0.
3059         * gdbarch.h: Regenerate.
3060         * gdbarch.sh (type_align): Extend comment.
3061         * gdbtypes.c (type_align): Add additional comments, always call
3062         gdbarch_type_align before applying the default rules.
3063         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
3064         generic code will then apply a suitable default.
3065         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
3066         types, return 0 for other types.
3067
3068 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3069
3070         * NEWS: Create a new section for the next release branch.
3071         Rename the section of the current branch, now that it has
3072         been cut.
3073
3074 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3075
3076         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
3077         * version.in: Bump version to 8.3.50.DATE-git.
3078
3079 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
3080
3081         * aix-thread.c (ptid_cmp): Remove unused variable.
3082         (get_signaled_thread): Likewise.
3083         (store_regs_user_thread): Likewise.
3084         (store_regs_kernel_thread): Likewise.
3085         (fetch_regs_kernel_thread): Remove shadowed variable.
3086
3087 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3088
3089         * features/riscv/32bit-cpu.xml: Add register numbers.
3090         * features/riscv/32bit-fpu.c: Regenerate.
3091         * features/riscv/32bit-fpu.xml: Add register numbers.
3092         * features/riscv/64bit-cpu.xml: Add register numbers.
3093         * features/riscv/64bit-fpu.c: Regenerate.
3094         * features/riscv/64bit-fpu.xml: Add register numbers.
3095
3096 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
3097
3098         * NEWS: Mention two argument form of gdb.Value constructor.
3099         * python/py-value.c (convert_buffer_and_type_to_value): New
3100         function.
3101         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
3102         Add support for handling an optional second argument.  Call
3103         convert_buffer_and_type_to_value as appropriate.
3104         * python/python-internal.h (Py_buffer_deleter): New struct.
3105         (Py_buffer_up): New typedef.
3106
3107 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
3108
3109         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
3110         instead of releasing ownership.
3111
3112 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
3113
3114         * dwarf2read.c (open_and_init_dwp_file): Call
3115         elf_numsections instead of bfd_count_sections to initialize
3116         dwp_file->num_sections.
3117
3118 2019-02-25  Tom Tromey  <tromey@adacore.com>
3119
3120         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
3121
3122 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
3123
3124         * gcore.in: Add '--readnever' option when invoking GDB.
3125
3126 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3127
3128         * MAINTAINERS: Update my email address.
3129
3130 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3131
3132         * build-id.c (build_id_to_debug_bfd_1): New function.
3133         (build_id_to_debug_bfd): Look for separate debug file in
3134         sysroot.
3135
3136 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3137
3138         * gdbarch.sh: Update the copyright year range that is placed into
3139         generated files.
3140
3141 2019-02-22  Keith Seitz  <keiths@redhat.com>
3142
3143         PR symtab/23853
3144         * linespec.c (create_sals_line_offset): Search for the default
3145         symtab's filename instead of its fullname.
3146
3147 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3148
3149         * NEWS: Update style defaults.
3150
3151 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3152
3153         * main.c (captured_main_1): Disable styling in batch mode.
3154
3155 2019-02-20  Tom Tromey  <tom@tromey.com>
3156
3157         * symtab.c (symtab_symbol_info): Fix typos.
3158
3159 2019-02-20  Tom Tromey  <tromey@adacore.com>
3160
3161         * findcmd.c (_initialize_mem_search): Use upper case for
3162         metasyntactic variables.
3163
3164 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
3165
3166         * aarch64-tdep.c (aarch64_add_reggroups): New function.
3167         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
3168
3169 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
3170
3171         * top.h (source_file_name): Change to std::string.
3172         * top.c (source_file_name): Likewise.
3173         (command_line_input): Adjust.
3174         * cli/cli-script.c (script_from_file): Adjust.
3175
3176 2019-02-19  Tom Tromey  <tromey@adacore.com>
3177
3178         * ravenscar-thread.c
3179         (ravenscar_thread_target::update_thread_list): Don't call
3180         ada_build_task_list.
3181         * ada-lang.h (ada_build_task_list): Don't declare.
3182         * ada-tasks.c (struct ada_tasks_inferior_data)
3183         <task_list_valid_p>: Now bool.
3184         (read_known_tasks, ada_task_list_changed)
3185         (ada_tasks_invalidate_inferior_data): Update.
3186         (read_known_tasks_array): Return bool.
3187         (read_known_tasks_list): Likewise.
3188         (read_known_tasks): Return void.
3189         (ada_build_task_list): Now static.
3190
3191 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3192
3193         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
3194         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
3195
3196 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3197
3198         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
3199         variant for ada_tasks_pspace_data_handle and
3200         ada_tasks_inferior_data_handle.
3201         (ada_tasks_pspace_data_cleanup): New function.
3202         (ada_tasks_inferior_data_cleanup): New function.
3203
3204 2019-02-17  Tom Tromey  <tom@tromey.com>
3205
3206         * macrotab.h (macro_source_fullname): Return a std::string.
3207         * macrotab.c (macro_include, check_for_redefinition)
3208         (macro_undef, macro_lookup_definition, foreach_macro)
3209         (foreach_macro_in_scope): Update.
3210         (macro_source_fullname): Return a std::string.
3211         * macrocmd.c (show_pp_source_pos): Update.
3212
3213 2019-02-17  Tom Tromey  <tom@tromey.com>
3214
3215         * macrocmd.c (show_pp_source_pos): Style the file names.
3216
3217 2019-02-17  Tom Tromey  <tom@tromey.com>
3218
3219         PR tui/24197:
3220         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
3221
3222 2019-02-17  Tom Tromey  <tom@tromey.com>
3223
3224         * ada-lang.c (user_select_syms): Use filtered printing.
3225         * utils.c (wrap_style): New global.
3226         (desired_style): Remove.
3227         (emit_style_escape): Add stream parameter.
3228         (set_output_style, reset_terminal_style, prompt_for_continue):
3229         Update.
3230         (flush_wrap_buffer): Only flush gdb_stdout.
3231         (wrap_here): Set wrap_style.
3232         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
3233         treat escape sequences as a character.  Change when wrap buffer is
3234         flushed.
3235         (fputs_styled): Do not set the output style when the default is
3236         requested.
3237         * ui-style.h (struct ui_file_style) <is_default>: New method.
3238         * source.c (print_source_lines_base): Emit escape sequences in one
3239         piece.
3240
3241 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3242
3243         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
3244         integers and enumeration types.
3245
3246 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3247
3248         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
3249         instead of lookup_symbol_in_language
3250         (do_exact_match): New function.
3251         (ada_get_symbol_name_matcher): Return do_exact_match when
3252         doing a verbatim match.
3253
3254 2019-02-15  Tom Tromey  <tromey@adacore.com>
3255
3256         * ravenscar-thread.c (ravenscar_thread_target::resume)
3257         (ravenscar_thread_target::wait): Special case wildcard requests.
3258
3259 2019-02-15  Tom Tromey  <tromey@adacore.com>
3260
3261         * ravenscar-thread.c (base_ptid): Remove.
3262         (struct ravenscar_thread_target) <close>: New method.
3263         <m_base_ptid>: New member.
3264         <update_inferior_ptid, active_task, task_is_currently_active,
3265         runtime_initialized>: Declare methods.
3266         <ravenscar_thread_target>: Add constructor.
3267         (ravenscar_thread_target::task_is_currently_active)
3268         (ravenscar_thread_target::update_inferior_ptid)
3269         (ravenscar_runtime_initialized): Rename.  Now methods.
3270         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
3271         (ravenscar_thread_target::update_thread_list): Update.
3272         (ravenscar_thread_target::active_task): Now method.
3273         (ravenscar_thread_target::store_registers)
3274         (ravenscar_thread_target::prepare_to_store)
3275         (ravenscar_thread_target::prepare_to_store)
3276         (ravenscar_thread_target::mourn_inferior): Update.
3277         (ravenscar_inferior_created): Use "new" to create target.
3278         (ravenscar_thread_target::get_ada_task_ptid): Update.
3279         (_initialize_ravenscar): Don't initialize base_ptid.
3280         (ravenscar_ops): Remove global.
3281
3282 2019-02-15  Tom Tromey  <tromey@adacore.com>
3283
3284         * target.h (push_target): Declare new overload.
3285         * target.c (push_target): New overload, taking an rvalue reference.
3286         * remote.c (remote_target::open_1): Use push_target overload.
3287         * corelow.c (core_target_open): Use push_target overload.
3288
3289 2019-02-15  Tom Tromey  <tromey@adacore.com>
3290
3291         * ravenscar-thread.c (is_ravenscar_task)
3292         (ravenscar_task_is_currently_active): Return bool.
3293         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
3294         (_initialize_ravenscar): Remove "(void)".
3295         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
3296         Return bool.
3297
3298 2019-02-15  Tom Tromey  <tromey@adacore.com>
3299
3300         * ravenscar-thread.c (ravenscar_runtime_initializer)
3301         (has_ravenscar_runtime, get_running_thread_id)
3302         (ravenscar_thread_target::resume): Fix indentation.
3303
3304 2019-02-15  Tom Tromey  <tromey@adacore.com>
3305
3306         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
3307         from ravenscar_arch_ops.
3308         (sparc_ravenscar_ops::fetch_registers)
3309         (sparc_ravenscar_ops::store_registers): Now methods.
3310         (sparc_ravenscar_prepare_to_store): Remove.
3311         (sparc_ravenscar_ops): Redefine.
3312         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
3313         methods and destructor.  Remove members.
3314         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
3315         (ravenscar_thread_target::store_registers)
3316         (ravenscar_thread_target::prepare_to_store): Update.
3317         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
3318         Remove.
3319         (struct ppc_ravenscar_powerpc_ops): Derive from
3320         ravenscar_arch_ops.
3321         (ppc_ravenscar_powerpc_ops::fetch_registers)
3322         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
3323         (ppc_ravenscar_powerpc_ops): Redefine.
3324         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
3325         (ppc_ravenscar_e500_ops::fetch_registers)
3326         (ppc_ravenscar_e500_ops::store_registers): Now methods.
3327         (ppc_ravenscar_e500_ops): Redefine.
3328         * aarch64-ravenscar-thread.c
3329         (aarch64_ravenscar_generic_prepare_to_store): Remove.
3330         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
3331         (aarch64_ravenscar_fetch_registers)
3332         (aarch64_ravenscar_store_registers): Now methods.
3333         (aarch64_ravenscar_ops): Redefine.
3334
3335 2019-02-15  Tom Tromey  <tromey@adacore.com>
3336
3337         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
3338         (ravenscar_thread_target::stopped_by_hw_breakpoint)
3339         (ravenscar_thread_target::stopped_by_watchpoint)
3340         (ravenscar_thread_target::stopped_data_address)
3341         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
3342
3343 2019-02-15  Tom Tromey  <tromey@adacore.com>
3344
3345         * ravenscar-thread.c: Fix some typos.
3346
3347 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3348             Tom Tromey  <tromey@adacore.com>
3349
3350         * ada-lang.c (ada_exception_sal): Change addr_string to a
3351         std::string.
3352         (create_ada_exception_catchpoint): Update.
3353
3354 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3355             Tom Tromey  <tromey@adacore.com>
3356
3357         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
3358         (bp_location_ops): Remove.
3359         (base_breakpoint_allocate_location): Update.
3360         (free_bp_location): Update.
3361         * ada-lang.c (class ada_catchpoint_location)
3362         <ada_catchpoint_location>: Remove ops parameter.
3363         (ada_catchpoint_location_dtor): Remove.
3364         (ada_catchpoint_location_ops): Remove.
3365         (allocate_location_exception): Update.
3366         * breakpoint.h (struct bp_location_ops): Remove.
3367         (class bp_location) <bp_location>: Remove bp_location_ops
3368         parameter.
3369         <~bp_location>: Add destructor.
3370         <ops>: Remove.
3371
3372 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3373             Pedro Alves  <palves@redhat.com>
3374
3375         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
3376         'PATH_MAX'.
3377
3378 2019-02-14  David Michael  <fedora.dm0@gmail.com>
3379             Samuel Thibault  <samuel.thibault@gnu.org>
3380             Thomas Schwinge  <thomas@codesourcery.com>
3381
3382         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
3383         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
3384
3385 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3386
3387         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
3388         (check_empty): Use "const char *".
3389
3390         * gnu-nat.c (gnu_nat_target::detach): Instead of
3391         'detach_inferior (pid)' call
3392         'detach_inferior (find_inferior_pid (pid))'.
3393
3394         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
3395         'nat/fork-inferior.o'.
3396         * gnu-nat.c: #include "nat/fork-inferior.h".
3397
3398         * gnu-nat.c (gnu_nat_target::detach): Instead of
3399         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
3400         * gnu-nat.h: #include "inf-child.h".
3401         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
3402         'i386_gnu_nat_target::fetch_registers'.
3403         (gnu_store_registers): Rename/move to
3404         'i386_gnu_nat_target::store_registers'.
3405
3406         * config/i386/nm-i386gnu.h: Don't "#include" any files.
3407         * gnu-nat.h (mach_thread_info): New function.
3408         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
3409
3410         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
3411
3412 2019-02-14  Frederic Konrad  <konrad@adacore.com>
3413
3414         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
3415
3416 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
3417
3418         * windows-nat.c (windows_add_thread): Add new parameter
3419         "main_thread_p" with default value set to false.  Update
3420         function documentation as well as all callers.
3421         (windows_delete_thread): Likewise.
3422         (fake_create_process): Update call to windows_add_thread.
3423         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
3424         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
3425         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
3426         call to windows_delete_thread.
3427
3428 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
3429
3430         * MAINTAINERS: Add Andrew Burgess as global maintainer.
3431
3432 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3433
3434         * symfile.c (find_separate_debug_file): Use canonical path of
3435         sysroot with child_path instead of gdb_sysroot if it is valid.
3436
3437 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3438
3439         * symfile.c (find_separate_debug_file): Use child_path to
3440         determine if an object file is under a sysroot.
3441
3442 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3443
3444         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
3445         unittests/child-path-selftests.c.
3446         * common/pathstuff.c (child_path): New function.
3447         * common/pathstuff.h (child_path): New prototype.
3448         * unittests/child-path-selftests.c: New file.
3449
3450 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3451
3452         * symfile.c (find_separate_debug_file): Look for separate debug
3453         files in debug directories under the sysroot.
3454
3455 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3456
3457         * symtab.h (struct minimal_symbol data_p): New const method.
3458         (struct minimal_symbol text_p): Likewise.
3459         * symtab.c (output_source_filename): Use file name style
3460         to print file name.
3461         (print_symbol_info): Likewise.
3462         (print_msymbol_info): Use address style to print addresses.
3463         Use function name style to print executable text symbols.
3464         (expand_symtab_containing_pc): Use data_p.
3465         (find_pc_sect_compunit_symtab): Likewise.
3466
3467 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3468
3469         * breakpoint.c (describe_other_breakpoints): Use address style
3470         to print addresses.
3471         (say_where): Likewise.
3472
3473 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3474
3475         * ada-typeprint.c (print_func_type): Print function name
3476         style to print function name.
3477         * c-typeprint.c (c_print_type_1): Likewise.
3478
3479 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
3480
3481         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
3482         for execve.
3483
3484 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3485
3486         * c-exp.y (direct_abs_decl): Use emplace_back to record the
3487         type_stack.
3488
3489 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
3490
3491         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
3492         TYPE_CODE_REF types.
3493
3494 2019-02-08  Jim Wilson  <jimw@sifive.com>
3495
3496         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
3497         (riscv_linux_fregset): New.
3498         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
3499
3500 2019-02-07  Tom Tromey  <tom@tromey.com>
3501
3502         * thread.c (thread_cancel_execution_command): Update.
3503         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
3504         methods.
3505         (struct thread_fsm_ops): Remove.
3506         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
3507         (thread_fsm_should_stop, thread_fsm_return_value)
3508         (thread_fsm_set_finished, thread_fsm_finished_p)
3509         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
3510         Don't declare.
3511         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
3512         * infrun.c (clear_proceed_status_thread)
3513         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
3514         (print_stop_event): Update.
3515         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
3516         Add constructor.
3517         (step_command_fsm_ops): Remove.
3518         (new_step_command_fsm): Remove.
3519         (step_1): Update.
3520         (step_command_fsm::should_stop): Rename from
3521         step_command_fsm_should_stop.
3522         (step_command_fsm::clean_up): Rename from
3523         step_command_fsm_clean_up.
3524         (step_command_fsm::do_async_reply_reason): Rename from
3525         step_command_fsm_async_reply_reason.
3526         (struct until_next_fsm): Inherit from thread_fsm.  Add
3527         constructor.
3528         (until_next_fsm_ops): Remove.
3529         (new_until_next_fsm): Remove.
3530         (until_next_fsm::should_stop): Rename from
3531         until_next_fsm_should_stop.
3532         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
3533         (until_next_fsm::do_async_reply_reason): Rename from
3534         until_next_fsm_async_reply_reason.
3535         (struct finish_command_fsm): Inherit from thread_fsm.  Add
3536         constructor.  Change type of breakpoint.
3537         (finish_command_fsm_ops): Remove.
3538         (new_finish_command_fsm): Remove.
3539         (finish_command_fsm::should_stop): Rename from
3540         finish_command_fsm_should_stop.
3541         (finish_command_fsm::clean_up): Rename from
3542         finish_command_fsm_clean_up.
3543         (finish_command_fsm::return_value): Rename from
3544         finish_command_fsm_return_value.
3545         (finish_command_fsm::do_async_reply_reason): Rename from
3546         finish_command_fsm_async_reply_reason.
3547         (finish_command): Update.
3548         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
3549         Add constructor.
3550         (call_thread_fsm_ops): Remove.
3551         (call_thread_fsm::call_thread_fsm): Rename from
3552         new_call_thread_fsm.
3553         (call_thread_fsm::should_stop): Rename from
3554         call_thread_fsm_should_stop.
3555         (call_thread_fsm::should_notify_stop): Rename from
3556         call_thread_fsm_should_notify_stop.
3557         (run_inferior_call, call_function_by_hand_dummy): Update.
3558         * cli/cli-interp.c (should_print_stop_to_console): Update.
3559         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
3560         Add constructor.  Change type of location_breakpoint,
3561         caller_breakpoint.
3562         (until_break_fsm_ops): Remove.
3563         (new_until_break_fsm): Remove.
3564         (until_break_fsm::should_stop): Rename from
3565         until_break_fsm_should_stop.
3566         (until_break_fsm::clean_up): Rename from
3567         until_break_fsm_clean_up.
3568         (until_break_fsm::do_async_reply_reason): Rename from
3569         until_break_fsm_async_reply_reason.
3570         (until_break_command): Update.
3571         * thread-fsm.c: Remove.
3572         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
3573
3574 2019-02-07  Tom Tromey  <tom@tromey.com>
3575
3576         * yy-remap.h: Add include guard.
3577         * xtensa-tdep.h: Add include guard.
3578         * xcoffread.h: Rename include guard.
3579         * varobj-iter.h: Add include guard.
3580         * tui/tui.h: Rename include guard.
3581         * tui/tui-winsource.h: Rename include guard.
3582         * tui/tui-wingeneral.h: Rename include guard.
3583         * tui/tui-windata.h: Rename include guard.
3584         * tui/tui-win.h: Rename include guard.
3585         * tui/tui-stack.h: Rename include guard.
3586         * tui/tui-source.h: Rename include guard.
3587         * tui/tui-regs.h: Rename include guard.
3588         * tui/tui-out.h: Rename include guard.
3589         * tui/tui-layout.h: Rename include guard.
3590         * tui/tui-io.h: Rename include guard.
3591         * tui/tui-hooks.h: Rename include guard.
3592         * tui/tui-file.h: Rename include guard.
3593         * tui/tui-disasm.h: Rename include guard.
3594         * tui/tui-data.h: Rename include guard.
3595         * tui/tui-command.h: Rename include guard.
3596         * tic6x-tdep.h: Add include guard.
3597         * target/waitstatus.h: Rename include guard.
3598         * target/wait.h: Rename include guard.
3599         * target/target.h: Rename include guard.
3600         * target/resume.h: Rename include guard.
3601         * target-float.h: Rename include guard.
3602         * stabsread.h: Add include guard.
3603         * rs6000-tdep.h: Add include guard.
3604         * riscv-fbsd-tdep.h: Add include guard.
3605         * regformats/regdef.h: Rename include guard.
3606         * record.h: Rename include guard.
3607         * python/python.h: Rename include guard.
3608         * python/python-internal.h: Rename include guard.
3609         * python/py-stopevent.h: Rename include guard.
3610         * python/py-ref.h: Rename include guard.
3611         * python/py-record.h: Rename include guard.
3612         * python/py-record-full.h: Rename include guard.
3613         * python/py-record-btrace.h: Rename include guard.
3614         * python/py-instruction.h: Rename include guard.
3615         * python/py-events.h: Rename include guard.
3616         * python/py-event.h: Rename include guard.
3617         * procfs.h: Add include guard.
3618         * proc-utils.h: Add include guard.
3619         * p-lang.h: Add include guard.
3620         * or1k-tdep.h: Rename include guard.
3621         * observable.h: Rename include guard.
3622         * nto-tdep.h: Rename include guard.
3623         * nat/x86-linux.h: Rename include guard.
3624         * nat/x86-linux-dregs.h: Rename include guard.
3625         * nat/x86-gcc-cpuid.h: Add include guard.
3626         * nat/x86-dregs.h: Rename include guard.
3627         * nat/x86-cpuid.h: Rename include guard.
3628         * nat/ppc-linux.h: Rename include guard.
3629         * nat/mips-linux-watch.h: Rename include guard.
3630         * nat/linux-waitpid.h: Rename include guard.
3631         * nat/linux-ptrace.h: Rename include guard.
3632         * nat/linux-procfs.h: Rename include guard.
3633         * nat/linux-osdata.h: Rename include guard.
3634         * nat/linux-nat.h: Rename include guard.
3635         * nat/linux-namespaces.h: Rename include guard.
3636         * nat/linux-btrace.h: Rename include guard.
3637         * nat/glibc_thread_db.h: Rename include guard.
3638         * nat/gdb_thread_db.h: Rename include guard.
3639         * nat/gdb_ptrace.h: Rename include guard.
3640         * nat/fork-inferior.h: Rename include guard.
3641         * nat/amd64-linux-siginfo.h: Rename include guard.
3642         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
3643         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
3644         * nat/aarch64-linux.h: Rename include guard.
3645         * nat/aarch64-linux-hw-point.h: Rename include guard.
3646         * mn10300-tdep.h: Add include guard.
3647         * mips-linux-tdep.h: Add include guard.
3648         * mi/mi-parse.h: Rename include guard.
3649         * mi/mi-out.h: Rename include guard.
3650         * mi/mi-main.h: Rename include guard.
3651         * mi/mi-interp.h: Rename include guard.
3652         * mi/mi-getopt.h: Rename include guard.
3653         * mi/mi-console.h: Rename include guard.
3654         * mi/mi-common.h: Rename include guard.
3655         * mi/mi-cmds.h: Rename include guard.
3656         * mi/mi-cmd-break.h: Rename include guard.
3657         * m2-lang.h: Add include guard.
3658         * location.h: Rename include guard.
3659         * linux-record.h: Rename include guard.
3660         * linux-nat.h: Add include guard.
3661         * linux-fork.h: Add include guard.
3662         * i386-darwin-tdep.h: Rename include guard.
3663         * hppa-linux-offsets.h: Add include guard.
3664         * guile/guile.h: Rename include guard.
3665         * guile/guile-internal.h: Rename include guard.
3666         * gnu-nat.h: Rename include guard.
3667         * gdb-stabs.h: Rename include guard.
3668         * frv-tdep.h: Add include guard.
3669         * f-lang.h: Add include guard.
3670         * event-loop.h: Add include guard.
3671         * darwin-nat.h: Rename include guard.
3672         * cp-abi.h: Rename include guard.
3673         * config/sparc/nm-sol2.h: Rename include guard.
3674         * config/nm-nto.h: Rename include guard.
3675         * config/nm-linux.h: Add include guard.
3676         * config/i386/nm-i386gnu.h: Rename include guard.
3677         * config/djgpp/nl_types.h: Rename include guard.
3678         * config/djgpp/langinfo.h: Rename include guard.
3679         * compile/gcc-cp-plugin.h: Add include guard.
3680         * compile/gcc-c-plugin.h: Add include guard.
3681         * compile/compile.h: Rename include guard.
3682         * compile/compile-object-run.h: Rename include guard.
3683         * compile/compile-object-load.h: Rename include guard.
3684         * compile/compile-internal.h: Rename include guard.
3685         * compile/compile-cplus.h: Rename include guard.
3686         * compile/compile-c.h: Rename include guard.
3687         * common/xml-utils.h: Rename include guard.
3688         * common/x86-xstate.h: Rename include guard.
3689         * common/version.h: Rename include guard.
3690         * common/vec.h: Rename include guard.
3691         * common/tdesc.h: Rename include guard.
3692         * common/selftest.h: Rename include guard.
3693         * common/scoped_restore.h: Rename include guard.
3694         * common/scoped_mmap.h: Rename include guard.
3695         * common/scoped_fd.h: Rename include guard.
3696         * common/safe-iterator.h: Rename include guard.
3697         * common/run-time-clock.h: Rename include guard.
3698         * common/refcounted-object.h: Rename include guard.
3699         * common/queue.h: Rename include guard.
3700         * common/ptid.h: Rename include guard.
3701         * common/print-utils.h: Rename include guard.
3702         * common/preprocessor.h: Rename include guard.
3703         * common/pathstuff.h: Rename include guard.
3704         * common/observable.h: Rename include guard.
3705         * common/netstuff.h: Rename include guard.
3706         * common/job-control.h: Rename include guard.
3707         * common/host-defs.h: Rename include guard.
3708         * common/gdb_wait.h: Rename include guard.
3709         * common/gdb_vecs.h: Rename include guard.
3710         * common/gdb_unlinker.h: Rename include guard.
3711         * common/gdb_unique_ptr.h: Rename include guard.
3712         * common/gdb_tilde_expand.h: Rename include guard.
3713         * common/gdb_sys_time.h: Rename include guard.
3714         * common/gdb_string_view.h: Rename include guard.
3715         * common/gdb_splay_tree.h: Rename include guard.
3716         * common/gdb_setjmp.h: Rename include guard.
3717         * common/gdb_ref_ptr.h: Rename include guard.
3718         * common/gdb_optional.h: Rename include guard.
3719         * common/gdb_locale.h: Rename include guard.
3720         * common/gdb_assert.h: Rename include guard.
3721         * common/filtered-iterator.h: Rename include guard.
3722         * common/filestuff.h: Rename include guard.
3723         * common/fileio.h: Rename include guard.
3724         * common/environ.h: Rename include guard.
3725         * common/common-utils.h: Rename include guard.
3726         * common/common-types.h: Rename include guard.
3727         * common/common-regcache.h: Rename include guard.
3728         * common/common-inferior.h: Rename include guard.
3729         * common/common-gdbthread.h: Rename include guard.
3730         * common/common-exceptions.h: Rename include guard.
3731         * common/common-defs.h: Rename include guard.
3732         * common/common-debug.h: Rename include guard.
3733         * common/cleanups.h: Rename include guard.
3734         * common/buffer.h: Rename include guard.
3735         * common/btrace-common.h: Rename include guard.
3736         * common/break-common.h: Rename include guard.
3737         * cli/cli-utils.h: Rename include guard.
3738         * cli/cli-style.h: Rename include guard.
3739         * cli/cli-setshow.h: Rename include guard.
3740         * cli/cli-script.h: Rename include guard.
3741         * cli/cli-interp.h: Rename include guard.
3742         * cli/cli-decode.h: Rename include guard.
3743         * cli/cli-cmds.h: Rename include guard.
3744         * charset-list.h: Add include guard.
3745         * buildsym-legacy.h: Rename include guard.
3746         * bfin-tdep.h: Add include guard.
3747         * ax.h: Rename include guard.
3748         * arm-linux-tdep.h: Add include guard.
3749         * arm-fbsd-tdep.h: Add include guard.
3750         * arch/xtensa.h: Rename include guard.
3751         * arch/tic6x.h: Add include guard.
3752         * arch/i386.h: Add include guard.
3753         * arch/arm.h: Rename include guard.
3754         * arch/arm-linux.h: Rename include guard.
3755         * arch/arm-get-next-pcs.h: Rename include guard.
3756         * arch/amd64.h: Add include guard.
3757         * arch/aarch64-insn.h: Rename include guard.
3758         * arch-utils.h: Rename include guard.
3759         * annotate.h: Add include guard.
3760         * amd64-darwin-tdep.h: Rename include guard.
3761         * aarch64-linux-tdep.h: Add include guard.
3762         * aarch64-fbsd-tdep.h: Add include guard.
3763         * aarch32-linux-nat.h: Add include guard.
3764
3765 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3766
3767         * macrotab.c (macro_define_internal): New function that
3768         factorizes macro_define_object_internal and macro_define_function
3769         code.
3770         (macro_define_object_internal): Use macro_define_internal.
3771         (macro_define_function): Likewise.
3772
3773 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3774
3775         * macrocmd.c (extract_identifier): Return
3776         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
3777         callers.
3778
3779 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
3780
3781         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
3782
3783 2019-02-05  Tom Tromey  <tom@tromey.com>
3784
3785         * target.c (target_stack::unpush): Move assertion earlier.
3786
3787 2019-01-30  Tom Tromey  <tom@tromey.com>
3788
3789         PR python/23615:
3790         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
3791         (gdbpy_parse_and_eval): Likewise.
3792         * python/python-internal.h (gdbpy_allow_threads): New class.
3793
3794 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
3795
3796         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
3797         (aarch64_fbsd_fpregmap): Move earlier.
3798         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
3799         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3800         instead of individual calls to trad_frame_set_reg_addr.
3801         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
3802         earlier.
3803         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
3804         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3805         instead of individual calls to trad_frame_set_reg_addr.
3806
3807 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
3808
3809         * CONTRIBUTE: Replace contribution list with wiki link.
3810
3811 2019-01-25  Tom Tromey  <tom@tromey.com>
3812
3813         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
3814
3815 2019-01-25  Tom Tromey  <tom@tromey.com>
3816
3817         * xtensa-linux-nat.c: Fix common/ includes.
3818         * xml-support.h: Fix common/ includes.
3819         * xml-support.c: Fix common/ includes.
3820         * x86-linux-nat.c: Fix common/ includes.
3821         * windows-nat.c: Fix common/ includes.
3822         * varobj.h: Fix common/ includes.
3823         * varobj.c: Fix common/ includes.
3824         * value.c: Fix common/ includes.
3825         * valops.c: Fix common/ includes.
3826         * utils.c: Fix common/ includes.
3827         * unittests/xml-utils-selftests.c: Fix common/ includes.
3828         * unittests/utils-selftests.c: Fix common/ includes.
3829         * unittests/unpack-selftests.c: Fix common/ includes.
3830         * unittests/tracepoint-selftests.c: Fix common/ includes.
3831         * unittests/style-selftests.c: Fix common/ includes.
3832         * unittests/string_view-selftests.c: Fix common/ includes.
3833         * unittests/scoped_restore-selftests.c: Fix common/ includes.
3834         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
3835         * unittests/scoped_fd-selftests.c: Fix common/ includes.
3836         * unittests/rsp-low-selftests.c: Fix common/ includes.
3837         * unittests/parse-connection-spec-selftests.c: Fix common/
3838         includes.
3839         * unittests/optional-selftests.c: Fix common/ includes.
3840         * unittests/offset-type-selftests.c: Fix common/ includes.
3841         * unittests/observable-selftests.c: Fix common/ includes.
3842         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
3843         * unittests/memrange-selftests.c: Fix common/ includes.
3844         * unittests/memory-map-selftests.c: Fix common/ includes.
3845         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
3846         * unittests/function-view-selftests.c: Fix common/ includes.
3847         * unittests/environ-selftests.c: Fix common/ includes.
3848         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
3849         * unittests/common-utils-selftests.c: Fix common/ includes.
3850         * unittests/cli-utils-selftests.c: Fix common/ includes.
3851         * unittests/array-view-selftests.c: Fix common/ includes.
3852         * ui-file.c: Fix common/ includes.
3853         * tui/tui-io.c: Fix common/ includes.
3854         * tracepoint.h: Fix common/ includes.
3855         * tracepoint.c: Fix common/ includes.
3856         * tracefile-tfile.c: Fix common/ includes.
3857         * top.h: Fix common/ includes.
3858         * top.c: Fix common/ includes.
3859         * thread.c: Fix common/ includes.
3860         * target/waitstatus.h: Fix common/ includes.
3861         * target/waitstatus.c: Fix common/ includes.
3862         * target.h: Fix common/ includes.
3863         * target.c: Fix common/ includes.
3864         * target-memory.c: Fix common/ includes.
3865         * target-descriptions.c: Fix common/ includes.
3866         * symtab.h: Fix common/ includes.
3867         * symfile.c: Fix common/ includes.
3868         * stap-probe.c: Fix common/ includes.
3869         * spu-linux-nat.c: Fix common/ includes.
3870         * sparc-nat.c: Fix common/ includes.
3871         * source.c: Fix common/ includes.
3872         * solib.c: Fix common/ includes.
3873         * solib-target.c: Fix common/ includes.
3874         * ser-unix.c: Fix common/ includes.
3875         * ser-tcp.c: Fix common/ includes.
3876         * ser-pipe.c: Fix common/ includes.
3877         * ser-base.c: Fix common/ includes.
3878         * selftest-arch.c: Fix common/ includes.
3879         * s12z-tdep.c: Fix common/ includes.
3880         * rust-exp.y: Fix common/ includes.
3881         * rs6000-aix-tdep.c: Fix common/ includes.
3882         * riscv-tdep.c: Fix common/ includes.
3883         * remote.c: Fix common/ includes.
3884         * remote-notif.h: Fix common/ includes.
3885         * remote-fileio.h: Fix common/ includes.
3886         * remote-fileio.c: Fix common/ includes.
3887         * regcache.h: Fix common/ includes.
3888         * regcache.c: Fix common/ includes.
3889         * record-btrace.c: Fix common/ includes.
3890         * python/python.c: Fix common/ includes.
3891         * python/py-type.c: Fix common/ includes.
3892         * python/py-inferior.c: Fix common/ includes.
3893         * progspace.h: Fix common/ includes.
3894         * producer.c: Fix common/ includes.
3895         * procfs.c: Fix common/ includes.
3896         * proc-api.c: Fix common/ includes.
3897         * printcmd.c: Fix common/ includes.
3898         * ppc-linux-nat.c: Fix common/ includes.
3899         * parser-defs.h: Fix common/ includes.
3900         * osdata.c: Fix common/ includes.
3901         * obsd-nat.c: Fix common/ includes.
3902         * nat/x86-linux.c: Fix common/ includes.
3903         * nat/x86-linux-dregs.c: Fix common/ includes.
3904         * nat/x86-dregs.h: Fix common/ includes.
3905         * nat/x86-dregs.c: Fix common/ includes.
3906         * nat/ppc-linux.c: Fix common/ includes.
3907         * nat/mips-linux-watch.h: Fix common/ includes.
3908         * nat/mips-linux-watch.c: Fix common/ includes.
3909         * nat/linux-waitpid.c: Fix common/ includes.
3910         * nat/linux-ptrace.h: Fix common/ includes.
3911         * nat/linux-ptrace.c: Fix common/ includes.
3912         * nat/linux-procfs.c: Fix common/ includes.
3913         * nat/linux-personality.c: Fix common/ includes.
3914         * nat/linux-osdata.c: Fix common/ includes.
3915         * nat/linux-namespaces.c: Fix common/ includes.
3916         * nat/linux-btrace.h: Fix common/ includes.
3917         * nat/linux-btrace.c: Fix common/ includes.
3918         * nat/fork-inferior.c: Fix common/ includes.
3919         * nat/amd64-linux-siginfo.c: Fix common/ includes.
3920         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
3921         * nat/aarch64-linux.c: Fix common/ includes.
3922         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
3923         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
3924         * namespace.h: Fix common/ includes.
3925         * mips-linux-tdep.c: Fix common/ includes.
3926         * minsyms.c: Fix common/ includes.
3927         * mi/mi-parse.h: Fix common/ includes.
3928         * mi/mi-main.c: Fix common/ includes.
3929         * mi/mi-cmd-env.c: Fix common/ includes.
3930         * memrange.h: Fix common/ includes.
3931         * memattr.c: Fix common/ includes.
3932         * maint.h: Fix common/ includes.
3933         * maint.c: Fix common/ includes.
3934         * main.c: Fix common/ includes.
3935         * machoread.c: Fix common/ includes.
3936         * location.c: Fix common/ includes.
3937         * linux-thread-db.c: Fix common/ includes.
3938         * linux-nat.c: Fix common/ includes.
3939         * linux-fork.c: Fix common/ includes.
3940         * inline-frame.c: Fix common/ includes.
3941         * infrun.c: Fix common/ includes.
3942         * inflow.c: Fix common/ includes.
3943         * inferior.h: Fix common/ includes.
3944         * inferior.c: Fix common/ includes.
3945         * infcmd.c: Fix common/ includes.
3946         * inf-ptrace.c: Fix common/ includes.
3947         * inf-child.c: Fix common/ includes.
3948         * ia64-linux-nat.c: Fix common/ includes.
3949         * i387-tdep.c: Fix common/ includes.
3950         * i386-tdep.c: Fix common/ includes.
3951         * i386-linux-tdep.c: Fix common/ includes.
3952         * i386-linux-nat.c: Fix common/ includes.
3953         * i386-go32-tdep.c: Fix common/ includes.
3954         * i386-fbsd-tdep.c: Fix common/ includes.
3955         * i386-fbsd-nat.c: Fix common/ includes.
3956         * guile/scm-type.c: Fix common/ includes.
3957         * guile/guile.c: Fix common/ includes.
3958         * go32-nat.c: Fix common/ includes.
3959         * gnu-nat.c: Fix common/ includes.
3960         * gdbthread.h: Fix common/ includes.
3961         * gdbarch-selftests.c: Fix common/ includes.
3962         * gdb_usleep.c: Fix common/ includes.
3963         * gdb_select.h: Fix common/ includes.
3964         * gdb_bfd.c: Fix common/ includes.
3965         * gcore.c: Fix common/ includes.
3966         * fork-child.c: Fix common/ includes.
3967         * findvar.c: Fix common/ includes.
3968         * fbsd-nat.c: Fix common/ includes.
3969         * event-top.c: Fix common/ includes.
3970         * event-loop.c: Fix common/ includes.
3971         * dwarf2read.c: Fix common/ includes.
3972         * dwarf2loc.c: Fix common/ includes.
3973         * dwarf2-frame.c: Fix common/ includes.
3974         * dwarf-index-cache.c: Fix common/ includes.
3975         * dtrace-probe.c: Fix common/ includes.
3976         * disasm-selftests.c: Fix common/ includes.
3977         * defs.h: Fix common/ includes.
3978         * csky-tdep.c: Fix common/ includes.
3979         * cp-valprint.c: Fix common/ includes.
3980         * cp-support.h: Fix common/ includes.
3981         * cp-support.c: Fix common/ includes.
3982         * corelow.c: Fix common/ includes.
3983         * completer.h: Fix common/ includes.
3984         * completer.c: Fix common/ includes.
3985         * compile/compile.c: Fix common/ includes.
3986         * compile/compile-loc2c.c: Fix common/ includes.
3987         * compile/compile-cplus-types.c: Fix common/ includes.
3988         * compile/compile-cplus-symbols.c: Fix common/ includes.
3989         * command.h: Fix common/ includes.
3990         * cli/cli-dump.c: Fix common/ includes.
3991         * cli/cli-cmds.c: Fix common/ includes.
3992         * charset.c: Fix common/ includes.
3993         * build-id.c: Fix common/ includes.
3994         * btrace.h: Fix common/ includes.
3995         * btrace.c: Fix common/ includes.
3996         * breakpoint.h: Fix common/ includes.
3997         * breakpoint.c: Fix common/ includes.
3998         * ax.h: 
3999         (enum agent_op): Fix common/ includes.
4000         * ax-general.c (struct aop_map): Fix common/ includes.
4001         * ax-gdb.c: Fix common/ includes.
4002         * auxv.c: Fix common/ includes.
4003         * auto-load.c: Fix common/ includes.
4004         * arm-tdep.c: Fix common/ includes.
4005         * arch/riscv.c: Fix common/ includes.
4006         * arch/ppc-linux-common.c: Fix common/ includes.
4007         * arch/i386.c: Fix common/ includes.
4008         * arch/arm.c: Fix common/ includes.
4009         * arch/arm-linux.c: Fix common/ includes.
4010         * arch/arm-get-next-pcs.c: Fix common/ includes.
4011         * arch/amd64.c: Fix common/ includes.
4012         * arch/aarch64.c: Fix common/ includes.
4013         * arch/aarch64-insn.c: Fix common/ includes.
4014         * arch-utils.c: Fix common/ includes.
4015         * amd64-windows-tdep.c: Fix common/ includes.
4016         * amd64-tdep.c: Fix common/ includes.
4017         * amd64-sol2-tdep.c: Fix common/ includes.
4018         * amd64-obsd-tdep.c: Fix common/ includes.
4019         * amd64-nbsd-tdep.c: Fix common/ includes.
4020         * amd64-linux-tdep.c: Fix common/ includes.
4021         * amd64-linux-nat.c: Fix common/ includes.
4022         * amd64-fbsd-tdep.c: Fix common/ includes.
4023         * amd64-fbsd-nat.c: Fix common/ includes.
4024         * amd64-dicos-tdep.c: Fix common/ includes.
4025         * amd64-darwin-tdep.c: Fix common/ includes.
4026         * agent.c: Fix common/ includes.
4027         * ada-lang.h: Fix common/ includes.
4028         * ada-lang.c: Fix common/ includes.
4029         * aarch64-tdep.c: Fix common/ includes.
4030
4031 2019-01-25  Tom Tromey  <tom@tromey.com>
4032
4033         * common/create-version.sh: Use common/version.h.
4034
4035 2019-01-24  Pedro Alves  <palves@redhat.com>
4036
4037         * infrun.c (signal_stop, signal_print, signal_program)
4038         (signal_catch, signal_pass): Now arrays instead of pointers.
4039         (update_signals_program_target, do_target_resume)
4040         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
4041         * linux-nat.c (linux_nat_target::pass_signals)
4042         (linux_nat_target::create_inferior, linux_nat_target::attach):
4043         Adjust.
4044         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
4045         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
4046         * procfs.c (procfs_target::pass_signals): Adjust.
4047         * record-full.c (record_full_target::resume): Adjust.
4048         * remote.c (remote_target::pass_signals)
4049         (remote_target::program_signals): Adjust.
4050         * target-debug.h (target_debug_print_signals): Now takes a
4051         gdb::array_view as parameter.  Adjust.
4052         * target.h (target_ops) <pass_signals, program_signals>: Replace
4053         pointer and length parameters with gdb::array_view.
4054         (target_pass_signals, target_program_signals): Likewise.
4055         * target-delegates.c: Regenerate.
4056
4057 2019-01-24  Pedro Alves  <palves@redhat.com>
4058
4059         * common/forward-scope-exit.h
4060         (forward_scope_exit::forward_scope_exit): Pass arguments to
4061         m_bind_function directly, instead of creating a std::bind and
4062         copying that.
4063
4064 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
4065
4066         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4067         for static members.
4068         (pass_in_v_vfp_candidate): Likewise.
4069
4070 2019-01-23  Tom Tromey  <tom@tromey.com>
4071             Pedro Alves  <palves@redhat.com>
4072
4073         * regcache.c (class regcache_invalidator): Remove.
4074         (regcache::raw_write): Use make_scope_exit.
4075
4076 2019-01-23  Tom Tromey  <tom@tromey.com>
4077
4078         * ui-out.h (class ui_out_emit_type): Update comment.
4079
4080 2019-01-23  Tom Tromey  <tom@tromey.com>
4081
4082         * infrun.c (fetch_inferior_event): Update comment.
4083
4084 2019-01-23  Tom Tromey  <tom@tromey.com>
4085             Pedro Alves  <palves@redhat.com>
4086
4087         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
4088         parameter.
4089         (fetch_inferior_event): Use SCOPE_EXIT.
4090
4091
4092 2019-01-23  Tom Tromey  <tom@tromey.com>
4093             Pedro Alves  <palves@redhat.com>
4094
4095         * infrun.c (disable_thread_events): Delete.
4096         (stop_all_threads): Use SCOPE_EXIT.
4097
4098 2019-01-23  Tom Tromey  <tom@tromey.com>
4099             Pedro Alves  <palves@redhat.com>
4100
4101         * symfile.c: Include forward-scope-exit.h.
4102         (clear_symtab_users_cleanup): Replace forward declaration with
4103         a FORWARD_SCOPE_EXIT.
4104         (syms_from_objfile_1): Use the forward_scope_exit and
4105         gdb::optional instead of cleanup_function.
4106         (reread_symbols): Use the forward_scope_exit instead of
4107         cleanup_function.
4108         (clear_symtab_users_cleanup): Remove function.
4109
4110 2019-01-23  Tom Tromey  <tom@tromey.com>
4111             Pedro Alves  <palves@redhat.com>
4112
4113         * linux-nat.c: Include scope-exit.h.
4114         (cleanup_target_stop): Remove.
4115         (linux_nat_target::static_tracepoint_markers_by_strid): Use
4116         SCOPE_EXIT.
4117
4118 2019-01-23  Tom Tromey  <tom@tromey.com>
4119             Pedro Alves  <palves@redhat.com>
4120
4121         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
4122         (call_function_by_hand_dummy): Use SCOPE_EXIT.
4123
4124 2019-01-23  Tom Tromey  <tom@tromey.com>
4125             Andrew Burgess  <andrew.burgess@embecosm.com>
4126             Pedro Alves  <palves@redhat.com>
4127
4128         * infrun.c (fetch_inferior_event): Use scope_exit.
4129         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
4130         * top.c (execute_command): Use scope_exit.
4131         * breakpoint.c (bpstat_do_actions): Use scope_exit.
4132         * utils.c (do_bpstat_clear_actions_cleanup)
4133         (make_bpstat_clear_actions_cleanup): Remove.
4134
4135 2019-01-23  Tom Tromey  <tom@tromey.com>
4136             Pedro Alves  <palves@redhat.com>
4137
4138         * infrun.c: Include "common/scope-exit.h"
4139         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
4140         (wait_for_inferior): Use SCOPE_EXIT.
4141         (fetch_inferior_event): Use scope_exit.
4142
4143 2019-01-23  Tom Tromey  <tom@tromey.com>
4144             Pedro Alves  <palves@redhat.com>
4145
4146         * breakpoint.c (create_breakpoint): Remove cleanup.
4147
4148 2019-01-23  Tom Tromey  <tom@tromey.com>
4149             Andrew Burgess  <andrew.burgess@embecosm.com>
4150             Pedro Alves  <palves@redhat.com>
4151
4152 2019-01-23  Pedro Alves  <palves@redhat.com>
4153
4154         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
4155
4156 2019-01-23  Pedro Alves  <palves@redhat.com>
4157             Andrew Burgess  <andrew.burgess@embecosm.com>
4158
4159         * gdbthread.h: Include "common/forward-scope-exit.h".
4160         (scoped_finish_thread_state): Redefine custom class in terms of
4161         forward_scope_exit.
4162
4163 2019-01-23  Pedro Alves  <palves@redhat.com>
4164             Andrew Burgess  <andrew.burgess@embecosm.com>
4165
4166         * common/forward-scope-exit.h: New file.
4167
4168 2019-01-23  Pedro Alves  <palves@redhat.com>
4169             Andrew Burgess  <andrew.burgess@embecosm.com>
4170             Tom Tromey  <tom@tromey.com>
4171
4172         * common/scope-exit.h: New file.
4173
4174 2019-01-23  Pedro Alves  <palves@redhat.com>
4175
4176         * common/preprocessor.h (ESC): Rename to ...
4177         (ESC_PARENS): ... this.
4178         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
4179         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
4180
4181 2019-01-23  Tom Tromey  <tom@tromey.com>
4182
4183         * language.h (class scoped_switch_to_sym_language_if_auto):
4184         Initialize m_lang in both cases.
4185
4186 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
4187
4188         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
4189         with XCNEW.
4190
4191 2019-01-22  Tom Tromey  <tom@tromey.com>
4192
4193         * corelow.c: Do not include sys/file.h.
4194
4195 2019-01-22  Tom Tromey  <tom@tromey.com>
4196
4197         * tui/tui-wingeneral.h: Include gdb_curses.h.
4198
4199 2019-01-22  Tom Tromey  <tom@tromey.com>
4200
4201         * source-cache.h (class source_cache) <get_source_lines,
4202         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
4203
4204 2019-01-22  Tom Tromey  <tom@tromey.com>
4205
4206         * remote-fileio.h (struct remote_target): Declare.
4207
4208 2019-01-22  Tom Tromey  <tom@tromey.com>
4209
4210         * python/py-arch.c: Do not include py-ref.h.
4211         * python/py-bpevent.c: Do not include py-ref.h.
4212         * python/py-cmd.c: Do not include py-ref.h.
4213         * python/py-continueevent.c: Do not include py-ref.h.
4214         * python/py-event.h: Do not include py-ref.h.
4215         * python/py-evtregistry.c: Do not include py-ref.h.
4216         * python/py-finishbreakpoint.c: Do not include py-ref.h.
4217         * python/py-frame.c: Do not include py-ref.h.
4218         * python/py-framefilter.c: Do not include py-ref.h.
4219         * python/py-function.c: Do not include py-ref.h.
4220         * python/py-infevents.c: Do not include py-ref.h.
4221         * python/py-linetable.c: Do not include py-ref.h.
4222         * python/py-objfile.c: Do not include py-ref.h.
4223         * python/py-param.c: Do not include py-ref.h.
4224         * python/py-prettyprint.c: Do not include py-ref.h.
4225         * python/py-progspace.c: Do not include py-ref.h.
4226         * python/py-symbol.c: Do not include py-ref.h.
4227         * python/py-symtab.c: Do not include py-ref.h.
4228         * python/py-type.c: Do not include py-ref.h.
4229         * python/py-unwind.c: Do not include py-ref.h.
4230         * python/py-utils.c: Do not include py-ref.h.
4231         * python/py-value.c: Do not include py-ref.h.
4232         * python/py-varobj.c: Do not include py-ref.h.
4233         * python/py-xmethods.c: Do not include py-ref.h.
4234         * python/python.c: Do not include py-ref.h.
4235         * varobj.c: Do not include py-ref.h.
4236
4237 2019-01-22  Tom Tromey  <tom@tromey.com>
4238
4239         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
4240         keyword for bcache.
4241
4242 2019-01-22  Tom Tromey  <tom@tromey.com>
4243
4244         * compile/compile-cplus-types.c: Remove a comment by #include.
4245
4246 2019-01-22  Tom Tromey  <tom@tromey.com>
4247
4248         * compile/gcc-c-plugin.h: Include compile-internal.h.
4249
4250 2019-01-22  Tom Tromey  <tom@tromey.com>
4251
4252         * stabsread.c (EXTERN): Do not define.
4253         (symnum, next_symbol_text_func, processing_gcc_compilation)
4254         (within_function, global_sym_chain, global_stabs)
4255         (previous_stab_code, this_object_header_files)
4256         (n_this_object_header_files)
4257         (n_allocated_this_object_header_files): Define.
4258         * stabsread.h (EXTERN): Never define.  Use "extern".
4259
4260 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4261
4262         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
4263         history_value.
4264
4265 2019-01-21  Tom Tromey  <tom@tromey.com>
4266
4267         * ui-out.c: Fix includes.
4268         * tui/tui-source.c: Fix includes.
4269         * target.c: Fix includes.
4270         * remote.c: Fix includes.
4271         * regcache.c: Fix includes.
4272         * python/py-block.c: Fix includes.
4273         * printcmd.c: Fix includes.
4274         * or1k-tdep.c: Fix includes.
4275         * mi/mi-main.c: Fix includes.
4276         * m32r-tdep.c: Fix includes.
4277         * csky-tdep.c: Fix includes.
4278         * compile/compile-cplus-types.c: Fix includes.
4279         * cli/cli-interp.c: Fix includes.
4280
4281 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
4282
4283         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4284         for padding.
4285
4286 2019-01-16  Tom Tromey  <tom@tromey.com>
4287
4288         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
4289         earlier.
4290         (struct objfile) <msymbols_range>: Move from top level.
4291         <msymbols>: New method.
4292         (class objfile_msymbols): Remove.
4293         * symtab.c (default_collect_symbol_completion_matches_break_on):
4294         Update.
4295         * symmisc.c (dump_msymbols): Update.
4296         * stabsread.c (scan_file_globals): Update.
4297         * objc-lang.c (info_selectors_command, info_classes_command)
4298         (find_methods): Update.
4299         * minsyms.c (find_solib_trampoline_target): Update.
4300         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
4301         * coffread.c (coff_symfile_read): Update.
4302         * ada-lang.c (ada_lookup_simple_minsym)
4303         (ada_collect_symbol_completion_matches): Update.
4304
4305 2019-01-16  Tom Tromey  <tom@tromey.com>
4306
4307         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
4308         type.  Remove no-argument constructor.
4309         <iterator::operator++>: Simplify.
4310         <begin>: Update.
4311         <end>: Use minimal_symbol_count.
4312
4313 2019-01-16  Tom Tromey  <tom@tromey.com>
4314
4315         * objfiles.h (struct objfile) <psymtabs>: New method.
4316         (class objfile_psymtabs): Remove.
4317         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
4318         typedef.
4319         <range>: New method.
4320         (require_partial_symbols): Change return type.
4321         * psymtab.c (require_partial_symbols)
4322         (psym_expand_symtabs_matching): Update.
4323         * mdebugread.c (parse_partial_symbols): Update.
4324         * dbxread.c (dbx_end_psymtab): Update.
4325
4326 2019-01-15  Tom Tromey  <tom@tromey.com>
4327
4328         * symtab.c (lookup_objfile_from_block)
4329         (lookup_symbol_in_objfile_symtabs)
4330         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
4331         (find_line_symtab, info_sources_command)
4332         (default_collect_symbol_completion_matches_break_on)
4333         (make_source_files_completion_list): Update.
4334         * symmisc.c (print_objfile_statistics, dump_objfile)
4335         (maintenance_print_symbols, maintenance_info_symtabs)
4336         (maintenance_check_symtabs, maintenance_info_line_tables):
4337         Update.
4338         * source.c (select_source_symtab)
4339         (forget_cached_source_info_for_objfile): Update.
4340         * objfiles.h (class objfile_compunits): Remove.
4341         (struct objfile) <compunits_range>: New typedef.
4342         (compunits): New method.
4343         * objfiles.c (objfile_relocate1): Update.
4344         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4345         * maint.c (count_symtabs_and_blocks): Update.
4346         * linespec.c (iterate_over_all_matching_symtabs): Update.
4347         * cp-support.c (add_symbol_overload_list_qualified): Update.
4348         * coffread.c (coff_symtab_read): Update.
4349         * ada-lang.c (add_nonlocal_symbols)
4350         (ada_collect_symbol_completion_matches)
4351         (ada_add_global_exceptions): Update.
4352
4353 2019-01-15  Tom Tromey  <tom@tromey.com>
4354
4355         * progspace.h (program_space) <objfiles_safe_range>: New
4356         typedef.
4357         <objfiles_safe>: New method.
4358         * objfiles.h (class all_objfiles_safe): Remove.
4359         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
4360         * jit.c (jit_inferior_exit_hook): Update.
4361
4362 2019-01-17  Tom Tromey  <tom@tromey.com>
4363
4364         * progspace.h (program_space) <objfiles_range>: New typedef.
4365         <objfiles>: New method.
4366         <objfiles_head>: Rename from objfiles.
4367         (object_files): Update.
4368         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
4369         * guile/scm-pretty-print.c
4370         (ppscm_find_pretty_printer_from_objfiles): Update.
4371         * guile/scm-objfile.c (gdbscm_objfiles): Update.
4372         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
4373         Update.
4374         * python/py-progspace.c (pspy_get_objfiles): Update.
4375         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
4376         Update.
4377         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
4378         (objfpy_lookup_objfile_by_build_id): Update.
4379         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4380         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
4381         Update.
4382         * symtab.c (iterate_over_symtabs, matching_obj_sections)
4383         (expand_symtab_containing_pc, lookup_objfile_from_block)
4384         (lookup_static_symbol, basic_lookup_transparent_type)
4385         (find_pc_sect_compunit_symtab, find_symbol_at_address)
4386         (find_line_symtab, info_sources_command)
4387         (default_collect_symbol_completion_matches_break_on)
4388         (make_source_files_completion_list, find_main_name): Update.
4389         * symmisc.c (print_symbol_bcache_statistics)
4390         (print_objfile_statistics, maintenance_print_symbols)
4391         (maintenance_print_msymbols, maintenance_print_objfiles)
4392         (maintenance_info_symtabs, maintenance_check_symtabs)
4393         (maintenance_expand_symtabs, maintenance_info_line_tables):
4394         Update.
4395         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
4396         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
4397         (map_overlay_command, unmap_overlay_command)
4398         (simple_overlay_update, expand_symtabs_matching)
4399         (map_symbol_filenames): Update.
4400         * symfile-debug.c (set_debug_symfile): Update.
4401         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
4402         Update.
4403         * source.c (select_source_symtab, forget_cached_source_info):
4404         Update.
4405         * solib.c (solib_read_symbols): Update.
4406         * solib-spu.c (append_ocl_sos): Update.
4407         * psymtab.c (maintenance_print_psymbols)
4408         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
4409         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
4410         * printcmd.c (info_symbol_command): Update.
4411         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
4412         Update.
4413         * objfiles.h (class all_objfiles): Remove.
4414         * objfiles.c (have_partial_symbols, have_full_symbols)
4415         (have_minimal_symbols, qsort_cmp, update_section_map)
4416         (shared_objfile_contains_address_p)
4417         (default_iterate_over_objfiles_in_search_order): Update.
4418         * objc-lang.c (info_selectors_command, info_classes_command)
4419         (find_methods): Update.
4420         * minsyms.c (find_solib_trampoline_target): Update.
4421         * maint.c (maintenance_info_sections)
4422         (maintenance_translate_address, count_symtabs_and_blocks):
4423         Update.
4424         * main.c (captured_main_1): Update.
4425         * linux-thread-db.c (try_thread_db_load_from_pdir)
4426         (has_libpthread): Update.
4427         * linespec.c (iterate_over_all_matching_symtabs)
4428         (search_minsyms_for_name): Update.
4429         * jit.c (jit_find_objf_with_entry_addr): Update.
4430         * hppa-tdep.c (find_unwind_entry)
4431         (hppa_lookup_stub_minimal_symbol): Update.
4432         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
4433         Update.
4434         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
4435         (elf_gnu_ifunc_resolve_by_got): Update.
4436         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
4437         * dwarf-index-write.c (save_gdb_index_command): Update.
4438         * cp-support.c (add_symbol_overload_list_qualified): Update.
4439         * breakpoint.c (create_overlay_event_breakpoint)
4440         (create_longjmp_master_breakpoint)
4441         (create_std_terminate_master_breakpoint)
4442         (create_exception_master_breakpoint): Update.
4443         * blockframe.c (find_pc_partial_function): Update.
4444         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
4445         (ada_collect_symbol_completion_matches)
4446         (ada_add_global_exceptions): Update.
4447
4448 2019-01-17  Tom Tromey  <tom@tromey.com>
4449
4450         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
4451         declare VEC.
4452         (solib_target_parse_libraries): Change return type.
4453         (library_list_start_segment, library_list_start_section)
4454         (library_list_end_library, library_list_start_library); Update.
4455         (solib_target_free_library_list): Remove.
4456         (solib_target_parse_libraries): Remove cleanup.  Change return
4457         type.
4458         (solib_target_current_sos): Update.
4459
4460 2019-01-17  Tom Tromey  <tromey@bapiya>
4461
4462         * valprint.c: Replace "the the" with "the".
4463         * symtab.c: Replace "the the" with "the".
4464         * solib.c: Replace "the the" with "the".
4465         * solib-dsbt.c: Replace "the the" with "the".
4466         * linespec.c: Replace "the the" with "the".
4467         * dwarf2loc.h: Replace "the the" with "the".
4468         * amd64-windows-tdep.c: Replace "the the" with "the".
4469         * aarch64-tdep.c: Replace "the the" with "the".
4470
4471 2019-01-16  Keith Seitz  <keiths@redhat.com>
4472
4473         PR gdb/23773
4474         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
4475         <builder>: Rename to ..
4476         <m_builder>: ... this and make private.
4477         (dwarf2_cu::get_builder): New method.  Change all users of
4478         `builder' to use this method.
4479         (dwarf2_start_symtab): Move to ...
4480         (dwarf2_cu::start_symtab): ... here.  Update all callers
4481         (setup_type_unit_groups): Move to ...
4482         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
4483         callers.
4484         (dwarf2_cu::reset_builder): New method.
4485         (process_full_compunit, process_full_type_unit): Use
4486         dwarf2_cu::reset_builder.
4487         (follow_die_offset): Record the ancestor CU if it is different
4488         from the followed DIE's CU.
4489         (follow_die_sig_1): Likewise.
4490
4491 2019-01-15  Tom Tromey  <tom@tromey.com>
4492
4493         * remote.c (class remote_state) <buf>: Now a char_vector.
4494         <buf_size>: Remove.
4495         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
4496         parameter.
4497         (remote_target::getpkt_or_notif_sane_1)
4498         (remote_target::getpkt_sane)
4499         (remote_target::getpkt_or_notif_sane): Likewise.
4500         (class remote_target) <putpkt>: New overload.
4501         (remote_target::read_frame): Change type of "buf_p".  Remove
4502         sizeof_p parameter.
4503         (packet_ok): New overload.
4504         (packet_check_result): New overload.
4505         Update all uses.
4506
4507 2019-01-14  Tom Tromey  <tom@tromey.com>
4508
4509         * remote-notif.c (handle_notification, remote_notif_ack)
4510         (remote_notif_parse): Make "buf" const.
4511         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
4512         const.
4513         (remote_notif_parse, remote_notif_ack, handle_notification):
4514         Likewise.
4515         * remote.c (remote_notif_stop_parse): Make "buf" const.
4516         (remote_target::remote_parse_stop_reply): Make "buf" const.
4517         (remote_notif_stop_ack): Make "buf" const.
4518
4519 2019-01-14  Tom Tromey  <tom@tromey.com>
4520
4521         * remote.c (remote_console_output): Make parameter const.
4522
4523 2019-01-14  Tom Tromey  <tom@tromey.com>
4524
4525         * target-debug.h (target_debug_print_signals): Constify.
4526         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
4527         * procfs.c (procfs_target::pass_signals): Update.
4528         * linux-nat.c (linux_nat_target::pass_signals): Update.
4529         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
4530         * target-delegates.c: Rebuild.
4531         * remote.c (remote_target::program_signals): Update.
4532         (remote_target::pass_signals): Update.
4533         * target.c (target_pass_signals): Constify argument.
4534         (target_program_signals): Likewise.
4535         * target.h (struct target_ops) <pass_signals, program_signals>:
4536         Constify argument.
4537         (target_pass_signals, target_program_signals): Constify argument.
4538
4539 2019-01-14  Tom Tromey  <tom@tromey.com>
4540
4541         PR tui/28819:
4542         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
4543
4544 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
4545
4546         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
4547         field.
4548         * rs6000-tdep.c: Include reggroups.h.
4549         (IS_V_ALIAS_PSEUDOREG): Define.
4550         (rs6000_register_name): Return names for the "vX" aliases.
4551         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
4552         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
4553         aliases.  Call default_register_reggroup_p for all other
4554         pseudo-registers.
4555         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
4556         New functions.
4557         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
4558         Handle "vX" aliases.
4559         (v_alias_pseudo_register_collect): New function.
4560         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
4561         (rs6000_gdbarch_init): Initialize "vX" aliases as
4562         pseudo-registers.  Restore registration of
4563         rs6000_pseudo_register_reggroup_p with
4564         set_tdesc_pseudo_register_reggroup_p.
4565
4566 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
4567
4568         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
4569         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
4570         set_gdbarch_num_pseudo_regs.
4571
4572 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4573
4574         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
4575         Remove arg prefixname, add do_set and do_show.
4576         Add member functions set_list and show_list.
4577         * cli/cli-style.c (class cli_style_option): Update accordingly.
4578         (style_set_list): Move to file scope.
4579         (style_show_list): Likewise.
4580         (set_style): Call help_list.
4581         (show_style): Call cmd_show_list.
4582         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
4583         Update to use the new macro.
4584
4585 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
4586
4587         * ada-lang.c (_initialize_ada_language): Expand the help text
4588         for the "catch exception" command.
4589
4590 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4591
4592         * symtab.c (matching_obj_sections): Initialize obj,
4593         declare it closer to its usage.
4594
4595 2019-01-10  Tom Tromey  <tom@tromey.com>
4596
4597         * thread-iter.h (inf_threads_iterator): Use next_iterator.
4598         (basic_inf_threads_range): Remove.
4599         (inf_threads_range, inf_non_exited_threads_range)
4600         (safe_inf_threads_range): Use next_adapter.
4601
4602 2019-01-10  Keith Seitz  <keiths@redhat.com>
4603
4604         PR gdb/23712
4605         PR symtab/23010
4606         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
4607         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
4608
4609 2019-01-10  Keith Seitz  <keiths@redhat.com>
4610
4611         PR gdb/23712
4612         PR symtab/23010
4613         * dictionary.c (pending_to_vector): Remove.
4614         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4615         Remove _1 suffix, replacing functions of the same name.  Update
4616         all callers.
4617         (dict_create_hashed, dict_create_hashed_expandable)
4618         (dict_create_linear, dict_create_linear_expandable, dict_free)
4619         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
4620         Make functions static.
4621
4622 2019-01-10  Keith Seitz  <keiths@redhat.com>
4623
4624         PR gdb/23712
4625         PR symtab/23010
4626         * dictionary.h (struct dictionary): Replace declaration with
4627         multidictionary.
4628         (dict_create_hashed, dict_create_hashed_expandable)
4629         (dict_create_linear, dict_create_linear_expandable)
4630         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
4631         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
4632         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
4633         taking multidictionary argument.
4634         [ALL_DICT_SYMBOLS]: Update for multidictionary.
4635         * block.h (struct block) <dict>: Change to multidictionary
4636         and rename `multidict'.
4637         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
4638         symmisc.c: Update all dictionary references to multidictionary.
4639
4640 2019-01-10  Keith Seitz  <keiths@redhat.com>
4641
4642         PR gdb/23712
4643         PR symtab/23010
4644         * dictionary.c: Include unordered_map.
4645         (pending_to_vector): New function.
4646         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4647         Rewrite the non-"_1" functions to take vector instead
4648         of linked list.
4649         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
4650         "new" _1 versions of the same name.
4651         (multidictionary): Define.
4652         (std::hash<enum language): New definition.
4653         (collate_pending_symbols_by_language, mdict_create_hashed)
4654         (mdict_create_hashed_expandable, mdict_create_linear)
4655         (mdict_create_linear_expandable, mdict_free)
4656         (find_language_dictionary, create_new_language_dictionary)
4657         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
4658         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
4659         (mdict_size, mdict_empty): New functions.
4660         * dictionary.h (mdict_iterator): Define.
4661
4662 2019-01-10  Pedro Alves  <palves@redhat.com>
4663
4664         * breakpoint.c (read_uploaded_action)
4665         (create_tracepoint_from_upload): Adjust to use
4666         gdb::unique_xmalloc_ptr.
4667         * ctf.c (ctf_write_uploaded_tp):
4668         (SET_ARRAY_FIELD): Use emplace_back.
4669         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
4670         * tracefile-tfile.c (tfile_write_uploaded_tp):
4671         * tracepoint.c (parse_tracepoint_definition): Adjust to use
4672         gdb::unique_xmalloc_ptr.
4673         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
4674         at_string, cond_string, cmd_strings>: Replace char pointers
4675         with gdb::unique_xmalloc_ptr.
4676
4677 2019-01-10  Pedro Alves  <palves@redhat.com>
4678
4679         * solib-target.c (library_list_start_library): Don't xstrdup name.
4680
4681 2019-01-10  Pedro Alves  <palves@redhat.com>
4682
4683         * mdebugread.c (parse_partial_symbols): Use
4684         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
4685
4686 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4687
4688         * linux-fork.c (scoped_switch_fork_info)
4689         <~scoped_switch_fork_info>: Fix incorrect variable name.
4690
4691 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4692
4693         * linux-fork.c (scoped_switch_fork_info)
4694         <scoped_switch_fork_info>: Make explicit.
4695         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
4696
4697 2019-01-10  Tom Tromey  <tom@tromey.com>
4698
4699         * objfiles.h (objfile::reset_psymtabs): Update.
4700         * objfiles.c (objfile::objfile): Update.
4701         * psymtab.h (psymtab_storage::obstack): Update.
4702         (psymtab_storage::m_obstack): Use gdb::optional.
4703         (class psymtab_storage): Update comment.  Remove objfile
4704         parameter.
4705         * psymtab.c (psymtab_storage::psymtab_storage): Update.
4706
4707 2019-01-10  Tom Tromey  <tom@tromey.com>
4708
4709         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
4710         <free_psymtabs>: Now private.
4711         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
4712         (allocate_psymtab): Use new method.
4713
4714 2019-01-10  Tom Tromey  <tom@tromey.com>
4715
4716         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
4717         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
4718         * mdebugread.c (parse_partial_symbols): Use
4719         allocate_dependencies.
4720         * dwarf2read.c (dwarf2_create_include_psymtab): Use
4721         allocate_dependencies.
4722         (process_psymtab_comp_unit_reader)
4723         (build_type_psymtab_dependencies): Likewise.
4724         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
4725
4726 2019-01-10  Tom Tromey  <tom@tromey.com>
4727
4728         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
4729         PSYMBOL_SET_LANGUAGE.
4730         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
4731
4732 2019-01-10  Tom Tromey  <tom@tromey.com>
4733
4734         * psymtab.h (psymtab_storage::obstack): New method.
4735         <m_obstack>: Rename from obstack; now private.
4736         * psymtab.c (psymtab_storage): Update.
4737         * dwarf2read.c (create_addrmap_from_index)
4738         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
4739         Update.
4740
4741 2019-01-10  Tom Tromey  <tom@tromey.com>
4742
4743         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
4744         * objfiles.h (objfile::reset_psymtabs): New method.
4745
4746 2019-01-10  Tom Tromey  <tom@tromey.com>
4747
4748         * symmisc.c (print_symbol_bcache_statistics): Update.
4749         (print_objfile_statistics): Update.
4750         * symfile.c (reread_symbols): Update.
4751         * psymtab.h (class psymtab_storage): New.
4752         * psymtab.c (psymtab_storage): New constructor.
4753         (~psymtab_storage): New destructor.
4754         (require_partial_symbols): Update.
4755         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
4756         (find_pc_sect_psymtab, find_pc_sect_psymbol)
4757         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
4758         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
4759         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
4760         (start_psymtab_common, end_psymtab_common)
4761         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
4762         (allocate_psymtab): Update.
4763         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
4764         Update.
4765         (dump_psymtab_addrmap, maintenance_print_psymbols)
4766         (maintenance_check_psymtabs): Update.
4767         (class objfile_psymtabs): Move to objfiles.h.
4768         * psympriv.h (discard_psymtab): Now inline.
4769         (psymtab_discarder::psymtab_discarder): Update.
4770         (psymtab_discarder::~psymtab_discarder): Update.
4771         (ALL_OBJFILE_PSYMTABS): Rewrite.
4772         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
4773         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
4774         Remove fields.
4775         <partial_symtabs>: New field.
4776         (class objfile_psymtabs): Move from psymtab.h.  Update.
4777         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
4778         psymbol_cache.
4779         (objfile::~objfile): Don't destroy psymbol_cache.
4780         * mdebugread.c (parse_partial_symbols): Update.
4781         * dwarf2read.c (create_addrmap_from_index)
4782         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
4783         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
4784         (add_partial_subprogram, dwarf2_ranges_read): Update.
4785         * dwarf-index-write.c (write_address_map)
4786         (write_one_signatured_type, recursively_write_psymbols)
4787         (class debug_names, class debug_names, write_psymtabs_to_index):
4788         Update.
4789
4790 2019-01-10  Tom Tromey  <tom@tromey.com>
4791
4792         * symtab.h (SYMBOL_SET_NAMES): Update.
4793         (symbol_set_names): Update.
4794         (MSYMBOL_SET_NAMES): Update.
4795         * symtab.c (symbol_set_names): Change argument to be an
4796         objfile_per_bfd_storage.
4797         * psymtab.c (add_psymbol_to_bcache): Update.
4798         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
4799
4800 2019-01-10  Tom Tromey  <tom@tromey.com>
4801
4802         * symtab.c (create_demangled_names_hash): Change argument to be an
4803         objfile_per_bfd_storage.
4804         (symbol_set_names): Update.
4805
4806 2019-01-10  Tom Tromey  <tom@tromey.com>
4807
4808         * xcoffread.c (xcoff_initial_scan): Unconditionally call
4809         init_psymbol_list.
4810         * psymtab.c (init_psymbol_list): Do nothing if already called.
4811         * psympriv.h (init_psymbol_list): Add comment.
4812         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
4813         init_psymbol_list.
4814         * dbxread.c (dbx_symfile_read): Unconditionally call
4815         init_psymbol_list.
4816
4817 2019-01-10  Tom Tromey  <tom@tromey.com>
4818
4819         * xcoffread.c (scan_xcoff_symtab): Update.
4820         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
4821         "where".
4822         * mdebugread.c (parse_partial_symbols)
4823         (handle_psymbol_enumerators): Update.
4824         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
4825         * dbxread.c (read_dbx_symtab): Update.
4826         * psympriv.h (psymbol_placement): New enum.
4827         (add_psymbol_to_list): Update.
4828
4829 2019-01-10  Tom Tromey  <tom@tromey.com>
4830
4831         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
4832         static_psymbols parameters.
4833         (scan_xcoff_symtab): Update.
4834         * psymtab.c (start_psymtab_common): Remove global_psymbols and
4835         static_psymbols parameters.
4836         * psympriv.h (start_psymtab_common): Update.
4837         * mdebugread.c (parse_partial_symbols): Update.
4838         * dwarf2read.c (create_partial_symtab): Update.
4839         * dbxread.c (read_dbx_symtab): Update.
4840         (start_psymtab): Remove global_psymbols and static_psymbols
4841         parameters.
4842
4843 2019-01-10  Tom Tromey  <tom@tromey.com>
4844
4845         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
4846         * psymtab.c (allocate_psymtab): Add comment.
4847         * psympriv.h (allocate_psymtab): Add comment.
4848         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
4849         initializations.
4850         * dbxread.c (dbx_end_psymtab): Remove some initializations.
4851
4852 2019-01-10  Tom Tromey  <tom@tromey.com>
4853
4854         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
4855         Don't declare.
4856         * mipsread.c: Include mdebugread.h.
4857         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
4858         Declare.
4859         * elfread.c: Include mdebugread.h.
4860
4861 2019-01-09  Tom Tromey  <tom@tromey.com>
4862
4863         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
4864         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
4865         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
4866         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
4867         (psym_lookup_symbol, psym_find_last_source_symtab)
4868         (psym_forget_cached_source_info, psym_print_stats)
4869         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
4870         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
4871         (psym_map_matching_symbols, psym_expand_symtabs_matching)
4872         (psym_find_compunit_symtab_by_address)
4873         (maintenance_print_psymbols, maintenance_info_psymtabs)
4874         (maintenance_check_psymtabs): Use ranged for.
4875         * psymtab.h (class objfile_psymtabs): New.
4876         (require_partial_symbols): Return objfile_psymtabs.
4877         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
4878
4879 2019-01-09  Tom Tromey  <tom@tromey.com>
4880
4881         * symfile.c (overlay_invalidate_all, find_pc_overlay)
4882         (find_pc_mapped_section, list_overlays_command)
4883         (map_overlay_command, unmap_overlay_command)
4884         (simple_overlay_update): Use all_objfiles.
4885         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
4886         * printcmd.c (info_symbol_command): Use all_objfiles.
4887         * objfiles.h (ALL_OBJSECTIONS): Remove.
4888         * maint.c (maintenance_translate_address): Use all_objfiles.
4889         * gcore.c (gcore_create_callback): Use all_objfiles.
4890         (objfile_find_memory_regions): Likewise.
4891
4892 2019-01-09  Tom Tromey  <tom@tromey.com>
4893
4894         * symtab.c (find_line_symtab, info_sources_command)
4895         (make_source_files_completion_list): Use objfile_compunits.
4896         * source.c (select_source_symtab): Use objfile_compunits.
4897         * objfiles.h (struct objfile): Update comment.
4898         (ALL_OBJFILES): Remove.
4899         (ALL_FILETABS): Remove.
4900         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
4901         objfile_compunits.
4902
4903 2019-01-09  Tom Tromey  <tom@tromey.com>
4904
4905         * symmisc.c (print_objfile_statistics, dump_objfile)
4906         (maintenance_print_symbols): Use compunit_filetabs.
4907         * source.c (forget_cached_source_info_for_objfile): Use
4908         compunit_filetabs.
4909         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
4910         (ALL_FILETABS): Use compunit_filetabs.
4911         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
4912         * coffread.c (coff_symtab_read): Use compunit_filetabs.
4913
4914 2019-01-09  Tom Tromey  <tom@tromey.com>
4915
4916         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
4917         (compunit_filetabs): New.
4918         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
4919         compunit_filetabs.
4920         (info_sources_command, make_source_files_completion_list): Remove
4921         declaration.
4922         * symmisc.c (print_objfile_statistics, dump_objfile)
4923         (maintenance_print_symbols): Remove declaration.
4924         (maintenance_info_symtabs): Use compunit_filetabs.
4925         (maintenance_info_line_tables): Likewise.
4926         * source.c (select_source_symtab): Change local variable name.
4927         (forget_cached_source_info_for_objfile): Remove declaration.
4928         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
4929         * objfiles.c (objfile_relocate1): Remove declaration.
4930         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
4931         declaration.
4932         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
4933         * coffread.c (coff_symtab_read): Remove declaration.
4934         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
4935         compunit_filetabs.
4936
4937 2019-01-09  Tom Tromey  <tom@tromey.com>
4938
4939         * symtab.c (lookup_objfile_from_block)
4940         (find_pc_sect_compunit_symtab, search_symbols)
4941         (default_collect_symbol_completion_matches_break_on): Use
4942         objfile_compunits.
4943         * objfiles.h (ALL_COMPUNITS): Remove.
4944         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
4945         * cp-support.c (add_symbol_overload_list_qualified): Use
4946         objfile_compunits.
4947         * ada-lang.c (ada_collect_symbol_completion_matches)
4948         (ada_add_global_exceptions): Use objfile_compunits.
4949
4950 2019-01-09  Tom Tromey  <tom@tromey.com>
4951
4952         * source.c (select_source_symtab)
4953         (forget_cached_source_info_for_objfile): Remove declaration.
4954         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
4955         declaration.
4956         * maint.c (count_symtabs_and_blocks): Remove declaration.
4957         * cp-support.c (add_symbol_overload_list_qualified): Remove
4958         declaration.
4959         * coffread.c (coff_symtab_read): Remove declaration.
4960         * symtab.c (lookup_symbol_in_objfile_symtabs)
4961         (basic_lookup_transparent_type_1): Use objfile_compunits.
4962         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
4963         (info_sources_command, search_symbols)
4964         (default_collect_symbol_completion_matches_break_on)
4965         (make_source_files_completion_list): Remove declaration.
4966         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
4967         (ada_collect_symbol_completion_matches)
4968         (ada_add_global_exceptions): Remove declaration.
4969         * linespec.c (iterate_over_all_matching_symtabs): Use
4970         objfile_compunits.
4971         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
4972         (class objfile_compunits): New.
4973         (ALL_COMPUNITS): Use objfile_compunits.
4974         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
4975         (maintenance_check_symtabs, maintenance_info_line_tables): Use
4976         objfile_compunits.
4977         * objfiles.c (objfile_relocate1): Use objfile_compunits.
4978
4979 2019-01-09  Tom Tromey  <tom@tromey.com>
4980
4981         * symtab.c (search_symbols)
4982         (default_collect_symbol_completion_matches_break_on): Use
4983         objfile_msymbols.
4984         * ada-lang.c (ada_lookup_simple_minsym)
4985         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
4986         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
4987         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
4988         objfile_msymbols.
4989         * coffread.c (coff_symfile_read): Use objfile_msymbols.
4990         * symmisc.c (dump_msymbols): Use objfile_msymbols.
4991         * objc-lang.c (find_methods): Use objfile_msymbols.
4992         (info_selectors_command, info_classes_command): Likewise.
4993         * stabsread.c (scan_file_globals): Use objfile_msymbols.
4994         * objfiles.h (class objfile_msymbols): New.
4995         (ALL_OBJFILE_MSYMBOLS): Remove.
4996         (ALL_MSYMBOLS): Remove.
4997
4998 2019-01-09  Tom Tromey  <tom@tromey.com>
4999
5000         * common/next-iterator.h (next_adapter): Add Iterator template
5001         parameter.
5002         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
5003         (class all_objfiles_safe): New.
5004         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
5005         * objfiles.c (put_objfile_before): Update comment.
5006         (add_separate_debug_objfile): Likewise.
5007         (free_all_objfiles): Use all_objfiles_safe.
5008         (objfile_purge_solibs): Likewise.
5009
5010 2019-01-09  Tom Tromey  <tom@tromey.com>
5011
5012         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5013         (expand_symtab_containing_pc, lookup_static_symbol)
5014         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
5015         (find_symbol_at_address, find_line_symtab, find_main_name): Use
5016         all_objfiles.
5017         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
5018         * breakpoint.c (create_overlay_event_breakpoint)
5019         (create_longjmp_master_breakpoint)
5020         (create_std_terminate_master_breakpoint)
5021         (create_exception_master_breakpoint): Use all_objfiles.
5022         * linux-thread-db.c (try_thread_db_load_from_pdir)
5023         (has_libpthread): Use all_objfiles.
5024         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
5025         * linespec.c (iterate_over_all_matching_symtabs)
5026         (search_minsyms_for_name): Use all_objfiles.
5027         * maint.c (maintenance_info_sections): Use all_objfiles.
5028         * main.c (captured_main_1): Use all_objfiles.
5029         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
5030         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
5031         * guile/scm-pretty-print.c
5032         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
5033         * solib-spu.c (append_ocl_sos): Use all_objfiles.
5034         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
5035         (maintenance_print_msymbols): Use all_objfiles.
5036         * source.c (select_source_symtab): Use all_objfiles.
5037         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
5038         * symfile.c (remove_symbol_file_command)
5039         (expand_symtabs_matching, map_symbol_filenames): Use
5040         all_objfiles.
5041         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
5042         all_objfiles.
5043         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
5044         * objc-lang.c (find_methods): Use all_objfiles.
5045         * objfiles.c (have_partial_symbols, have_full_symbols)
5046         (have_minimal_symbols, qsort_cmp)
5047         (default_iterate_over_objfiles_in_search_order): Use
5048         all_objfiles.
5049         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
5050         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
5051         (maintenance_check_psymtabs): Use all_objfiles.
5052         (ALL_PSYMTABS): Remove.
5053         * compile/compile-object-run.c (do_module_cleanup): Use
5054         all_objfiles.
5055         * blockframe.c (find_pc_partial_function): Use all_objfiles.
5056         * cp-support.c (add_symbol_overload_list_qualified): Use
5057         all_objfiles.
5058         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5059         Use all_objfiles.
5060         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
5061         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
5062         all_objfiles.
5063         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5064         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
5065         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5066         Uses all_objfiles.
5067         * solib.c (solib_read_symbols): Use all_objfiles
5068
5069 2019-01-09  Tom Tromey  <tom@tromey.com>
5070
5071         * probe.c (parse_probes_in_pspace): Use all_objfiles.
5072         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
5073         all_objfiles.
5074         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
5075         * symmisc.c (print_symbol_bcache_statistics)
5076         (print_objfile_statistics, maintenance_print_objfiles)
5077         (maintenance_info_symtabs, maintenance_check_symtabs)
5078         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
5079         all_objfiles.
5080         * source.c (forget_cached_source_info): Use all_objfiles.
5081         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
5082         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5083         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
5084         * objfiles.c (update_section_map): Use all_objfiles.
5085         (shared_objfile_contains_address_p): Likewise.
5086         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
5087         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
5088
5089 2019-01-09  Tom Tromey  <tom@tromey.com>
5090
5091         * common/next-iterator.h: New file.
5092         * objfiles.h (class all_objfiles): New.
5093         (struct objfile_iterator): New.
5094
5095 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5096
5097         * NEWS: Move the description of the changed "frame", "select-frame",
5098          and "info frame" commands to the Changed commands section.
5099
5100 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
5101
5102         * gdbtypes.c (check_stub_method_group): Remove handling of old
5103         mangling schemes.
5104         * linespec.c (find_methods): Likewise.
5105         * stabsread.c (read_member_functions): Likewise.
5106         * valops.c (search_struct_method): Likewise.
5107         (value_struct_elt_for_reference): Likewise.
5108         * NEWS: Mention this change.
5109
5110 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5111
5112         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
5113         print_source_lines.
5114         * source.c (print_source_lines_base): Update line number check.
5115         (print_source_lines): New function.
5116         (source_lines_range::source_lines_range): New function.
5117         * source.h (class source_lines_range): New class.
5118         (print_source_lines): New declaration.
5119
5120 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5121
5122         * linespec.c (linespec_state_destructor): Free self->canonical_names.
5123
5124 2019-01-08  Tom Tromey  <tom@tromey.com>
5125             Simon Marchi  <simon.marchi@ericsson.com>
5126
5127         PR gdb/24060
5128         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
5129         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
5130         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5131         * f-exp.y (DOLLAR_VARIABLE): Likewise.
5132         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
5133         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5134
5135 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5136
5137         * source.c (select_source_symtab): Move header comment to
5138         declaration in source.h.
5139         (forget_cached_source_info_for_objfile): Likewise.
5140         (forget_cached_source_info): Likewise.
5141         (identify_source_line): Likewise.
5142         * source.h (identify_source_line): Move declaration from symtab.h
5143         and add comment from source.c
5144         (print_source_lines): Likewise.
5145         (forget_cached_source_info_for_objfile): Likewise.
5146         (forget_cached_source_info): Likewise.
5147         (select_source_symtab): Likewise.
5148         (enum print_source_lines_flag): Move definition from symtab.h.
5149         * symtab.h (identify_source_line): Move declaration to source.h.
5150         (print_source_lines): Likewise.
5151         (forget_cached_source_info_for_objfile): Likewise.
5152         (forget_cached_source_info): Likewise.
5153         (select_source_symtab): Likewise.
5154         (enum print_source_lines_flag): Move definition to source.h.
5155         * tui/tui-hooks.c: Add 'source.h' include.
5156
5157 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5158
5159         * source.c (print_source_lines_base): Handle requests to print
5160         reverse line number sequences, and guard against empty lines
5161         string.
5162
5163 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5164
5165         * source.c (print_source_lines_base): Fix skip of '\r' if next
5166         character is '\n'.
5167
5168 2019-01-06  Tom Tromey  <tom@tromey.com>
5169
5170         * c-exp.y (struct c_parse_state) <macro_original_text,
5171         expansion_obstack>: New member.
5172         (macro_original_text, expansion_obstack): Remove globals.
5173         (scan_macro_expansion, scanning_macro_expansion)
5174         (finished_macro_expansion): Update.
5175         (scan_macro_cleanup): Remove.
5176         (yylex, c_parse): Update.
5177
5178 2019-01-06  Tom Tromey  <tom@tromey.com>
5179
5180         * c-exp.y (struct c_parse_state) <strings>: New member.
5181         (operator_stoken): Update.
5182
5183 2019-01-06  Tom Tromey  <tom@tromey.com>
5184
5185         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
5186         (union type_stack_elt) <typelist_val>: Now a pointer to
5187         std::vector.
5188         (type_stack_cleanup): Don't declare.
5189         (push_typelist): Update.
5190         * parse.c (pop_typelist): Return a std::vector.
5191         (push_typelist): Take a std::vector.
5192         (follow_types): Update.  Do not free args.
5193         (type_stack_cleanup): Remove.
5194         * c-exp.y (struct c_parse_state): New.
5195         (cpstate): New global.
5196         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
5197         (nonempty_typelist): Update.
5198         (func_mod): Create a new vector.
5199         (c_parse): Create a c_parse_state.
5200         (check_parameter_typelist): Do not delete params.
5201         (function_method): Update.  Do not delete type_list.
5202
5203 2019-01-06  Tom Tromey  <tom@tromey.com>
5204
5205         PR gdb/28155:
5206         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
5207         check_typedef.
5208         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
5209         (print_return_value): Likewise.
5210
5211 2019-01-05  Tom Tromey  <tom@tromey.com>
5212
5213         * contrib/cleanup_check.py: Remove.
5214         * contrib/gcc-with-excheck: Remove.
5215         * contrib/exsummary.py: Remove.
5216         * contrib/excheck.py: Remove.
5217
5218 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
5219
5220         * thread.c (delete_thread_1): Add gdb_assert that THR is not
5221         NULL. Initialize tpprev to NULL instead of assigning it
5222         to NULL on the next statement.
5223         * windows-nat.c (windows_delete_thread): Remove check for
5224         main_thread_id before printing thread exit notifications.
5225         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
5226         Remove thread ID check against main_thread_id.
5227         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
5228         windows_delete_thread.
5229         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
5230
5231 2019-01-04  Tom Tromey  <tom@tromey.com>
5232
5233         * compile/compile.c (_initialize_compile): Use upper case for
5234         metasyntactic variables.
5235         * symmisc.c (_initialize_symmisc): Use upper case for
5236         metasyntactic variables.
5237         * psymtab.c (_initialize_psymtab): Use upper case for
5238         metasyntactic variables.
5239         * demangle.c (demangle_command): Use upper case for metasyntactic
5240         variables.
5241         (_initialize_demangler): Likewise.
5242         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
5243         variables.
5244
5245 2019-01-03  Tom Tromey  <tom@tromey.com>
5246
5247         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
5248
5249 2019-01-03  Tom Tromey  <tom@tromey.com>
5250
5251         * python/py-symtab.c (salpy_str): Update.
5252         (struct salpy_sal_object) <symtab>: Now a PyObject.
5253         (salpy_dealloc): Update.
5254         (del_objfile_sal): Use gdbpy_ref.
5255
5256 2019-01-03  Tom Tromey  <tom@tromey.com>
5257
5258         * python/py-type.c (convert_field): Use new_reference.  Return
5259         gdbpy_ref.
5260         (make_fielditem): Return gdbpy_ref.
5261         (typy_fields): Update.
5262         (typy_getitem): Update.
5263         (field_name): Return gdbpy_ref.  Use new_reference.
5264         (typy_iterator_iternext): Update.
5265
5266 2019-01-03  Tom Tromey  <tom@tromey.com>
5267
5268         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
5269
5270 2019-01-03  Tom Tromey  <tom@tromey.com>
5271
5272         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
5273         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
5274         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
5275         (pspy_set_frame_filters, pspy_set_frame_unwinders)
5276         (pspy_set_type_printers): Likewise.
5277         * python/py-function.c (fnpy_init): Use gdbpy_ref.
5278         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
5279         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
5280         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
5281         (objfpy_set_type_printers): Likewise.
5282
5283 2019-01-03  Tom Tromey  <tom@tromey.com>
5284
5285         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
5286         (gdbpy_print_stack): Use gdbpy_err_fetch.
5287         * python/python-internal.h (class gdbpy_err_fetch): New class.
5288         (class gdbpy_enter) <m_error_type, m_error_value,
5289         m_error_traceback>: Remove.
5290         <m_error>: New member.
5291         (gdbpy_exception_to_string): Don't declare.
5292         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
5293         * python/py-value.c (convert_value_from_python): Use
5294         gdbpy_err_fetch.
5295         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
5296         gdbpy_exception_to_string.
5297         (gdbpy_handle_exception): Use gdbpy_err_fetch.
5298         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
5299         gdbpy_err_fetch.
5300
5301 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5302
5303         * linux-nat.c (delete_lwp_cleanup): Delete.
5304         (struct lwp_deleter): New struct.
5305         (lwp_info_up): New typedef.
5306         (linux_nat_target::follow_fork): Delete cleanup, and make use of
5307         lwp_info_up.
5308
5309 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5310
5311         * linux-fork.c (class scoped_switch_fork_info): New class.
5312         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
5313
5314 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5315
5316         * valops.c (find_overload_match): Remove use of null_cleanup, and
5317         calls to do_cleanups.
5318
5319 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5320
5321         * compile/compile-cplus-types.c
5322         (compile_cplus_instance::decl_name): Handle changes to
5323         cp_func_name.
5324         * cp-support.c (cp_func_name): Update header comment, update
5325         return type.
5326         * cp-support.h (cp_func_name): Update return type in declaration.
5327         * valops.c (find_overload_match): Move temp_func local to top
5328         level of function and change its type.  Use temp_func to hold and
5329         delete temporary string obtained from cp_func_name.
5330
5331 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5332
5333         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
5334         gdb::char_vector, remove cleanup, and update uses of `msg`.
5335
5336 2019-01-03  Jim Wilson  <jimw@sifive.com>
5337
5338         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
5339
5340 2019-01-02  Tom Tromey  <tom@tromey.com>
5341
5342         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
5343         (tdesc_parse_xml): Remove cleanups.
5344         * target-descriptions.h (make_cleanup_free_target_description):
5345         Don't declare.
5346         (target_desc_deleter): New struct.
5347         (target_desc_up): New typedef.
5348         * target-descriptions.c (target_desc_deleter::operator()): Rename
5349         from free_target_description.
5350         (make_cleanup_free_target_description): Remove.
5351
5352 2019-01-02  Tom Tromey  <tom@tromey.com>
5353
5354         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
5355         constructor, destructor.
5356         (linespec_parser): Remove typedef.
5357         (~linespec_parser): Rename from linespec_parser_delete.
5358         (linespec_lex_to_end, linespec_complete_label)
5359         (linespec_complete): Update.
5360         (decode_line_full): Remove cleanups.
5361         (decode_line_1): Update.
5362
5363 2019-01-02  Tom Tromey  <tom@tromey.com>
5364
5365         * python/python-internal.h (inferior_to_inferior_object): Change
5366         return type.
5367         * python/py-exitedevent.c (create_exited_event_object): Update.
5368         * python/py-inferior.c (inferior_to_inferior_object): Return
5369         gdbpy_ref.
5370         (python_new_inferior, python_inferior_deleted)
5371         (thread_to_thread_object, delete_thread_object)
5372         (build_inferior_list, gdbpy_selected_inferior): Update.
5373         * python/py-infthread.c (create_thread_object): Update.  Also fail
5374         if inferior_to_inferior_object fails.
5375
5376 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
5377
5378         * inferior.h (class inferior) <displaced_step_state>: New field.
5379         * infrun.h (struct displaced_step_state): Move here from
5380         infrun.c.  Initialize fields, add constructor.
5381         <inf>: Remove field.
5382         <reset>: New method.
5383         * infrun.c (struct displaced_step_inferior_state): Move to
5384         infrun.h.
5385         (displaced_step_inferior_states): Remove.
5386         (get_displaced_stepping_state): Adust.
5387         (displaced_step_in_progress_any_inferior): Adjust.
5388         (displaced_step_in_progress_thread): Adjust.
5389         (displaced_step_in_progress): Adjust.
5390         (add_displaced_stepping_state): Remove.
5391         (get_displaced_step_closure_by_addr): Adjust.
5392         (remove_displaced_stepping_state): Remove.
5393         (infrun_inferior_exit): Call displaced_step_state.reset.
5394         (use_displaced_stepping): Don't check for NULL.
5395         (displaced_step_prepare_throw): Call
5396         get_displaced_stepping_state.
5397         (displaced_step_fixup): Don't check for NULL.
5398         (prepare_for_detach): Don't check for NULL.
5399
5400 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5401
5402         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
5403          in case of call that did not complete.
5404
5405 2019-01-02  Andrey Utkin  <autkin@undo.io>
5406
5407         * symfile.c (find_separate_debug_file): Fix search of debug files for
5408         remote debuggee.
5409
5410 2019-01-02  Tom Tromey  <tom@tromey.com>
5411
5412         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
5413         indentation.
5414         * python/py-frame.c (frapy_older): Remove cast.
5415         (frapy_newer): Likewise.
5416         * python/py-breakpoint.c (local_setattro): Remove cast.
5417         * python/py-arch.c (archpy_name): Remove local variable.
5418         * python/py-type.c (gdbpy_lookup_type): Remove cast.
5419
5420 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
5421
5422         * unittests/basic_string_view/element_access/char/empty.cc:
5423         Fix year range in copyright header.
5424
5425 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5426
5427         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
5428         Delete.
5429         <operator==>: Update with for removed field.
5430         <hash>: Likewise.
5431         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
5432         <isa_features>: ...this.
5433         <abi_features>: New field.
5434         (riscv_isa_flen): Update comment.
5435         (riscv_abi_xlen): New declaration.
5436         (riscv_abi_flen): New declaration.
5437         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
5438         isa_features.
5439         (riscv_abi_xlen): New function.
5440         (riscv_isa_flen): Update to get answer from isa_features.
5441         (riscv_abi_flen): New function.
5442         (riscv_has_fp_abi): Update to get answer from abi_features.
5443         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
5444         xlen and flen.
5445         (riscv_call_info) <xlen, flen>: Update comment.
5446         (riscv_call_arg_struct): Remove invalid assertions
5447         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
5448         is removed.
5449         (riscv_gdbarch_init): Gather isa features and abi features
5450         separately, ensure both match on the gdbarch when reusing an old
5451         gdbarch.  Relax an error check to allow 32-bit abi float to run on
5452         a target with 64-bit float hardware.
5453
5454 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5455
5456         * source.c (search_command_helper): Stop reverse search
5457         when line 1 has been searched.
5458
5459 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5460
5461         * record-full.c (record_full_base_target::close): Rewrite
5462         record_full_core_buf_list free logic.
5463
5464 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5465
5466         * break-catch-syscall.c (print_one_catch_syscall): xfree
5467         the last text.
5468
5469 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5470
5471         * top.c (print_gdb_version): Update Copyright year in version
5472         message.
5473
5474 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5475
5476         Update copyright year range in all GDB files.
5477
5478 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
5479
5480         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
5481
5482 For older changes see ChangeLog-2018.
5483 \f
5484 Local Variables:
5485 mode: change-log
5486 left-margin: 8
5487 fill-column: 74
5488 version-control: never
5489 coding: utf-8
5490 End:
5491