gdb/ChangeLog

   1 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
   2
   3         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
   4         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
   5         instantiate mi_ui_out based on interpreter name.
   6         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
   7         * mi/mi-main.c (mi_load_progress): Likewise.
   8
   9 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
  10
  11         * NEWS: Combine separate "New targets" sections for 8.3.
  12
  13 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
  14
  15         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
  16         (ppcfbsd_init_abi): Install gdbarch
  17         "fetch_tls_load_module_address" and "get_thread_local_address"
  18         methods.
  19
  20 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
  21
  22         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
  23         (riscv_fbsd_init_abi): Install gdbarch
  24         "fetch_tls_load_module_address" and "get_thread_local_address"
  25         methods.
  26
  27 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
  28
  29         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
  30         (i386fbsd_init_abi): Install gdbarch
  31         "fetch_tls_load_module_address" and "get_thread_local_address"
  32         methods.
  33
  34 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
  35
  36         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
  37         (amd64fbsd_init_abi): Install gdbarch
  38         "fetch_tls_load_module_address" and "get_thread_local_address"
  39         methods.
  40
  41 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
  42
  43         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
  44         (struct fbsd_pspace_data): New type.
  45         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
  46         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
  47         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
  48         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
  49         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
  50
  51 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
  52
  53         * gdbtypes.c (lookup_struct_elt): New function.
  54         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
  55         * gdbtypes.h (struct struct_elt): New type.
  56         (lookup_struct_elt): New prototype.
  57
  58 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
  59
  60         * gdbtypes.c (lookup_struct_elt_type): Update comment and
  61         remove disabled code block.
  62
  63 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
  64
  65         * gdbarch.sh (get_thread_local_address): New method.
  66         * gdbarch.h, gdbarch.c: Regenerate.
  67         * target.c (target_translate_tls_address): Use
  68         gdbarch_get_thread_local_address if present instead of
  69         target::get_thread_local_address.
  70
  71 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
  72
  73         * target.h (target::get_thread_local_address): Update comment.
  74
  75 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
  76
  77         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
  78         objfile->separate_debug_objfile_backlink if not NULL.
  79
  80 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
  81
  82         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
  83         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
  84         (amd64bsd_store_inferior_registers): Likewise.
  85         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
  86         Enable segment base registers.
  87         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
  88         PT_GETFSBASE and PT_GETGSBASE.
  89         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
  90         PT_SETGSBASE.
  91         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
  92         segment base registers.
  93         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
  94
  95 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
  96
  97         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
  98         Update calls to i386_target_description to add 'segments'
  99         parameter.
 100         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
 101         add segment base registers.
 102         * arch/i386.c (i386_create_target_description): Add 'segments'
 103         parameter to enable segment base registers.
 104         * arch/i386.h (i386_create_target_description): Likewise.
 105         * features/i386/32bit-segments.xml: New file.
 106         * features/i386/32bit-segments.c: Generate.
 107         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
 108         call to i386_target_description to add 'segments' parameter.
 109         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 110         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
 111         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
 112         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
 113         if feature is present.
 114         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
 115         Add 'segments' parameter to call to i386_target_description.
 116         (i386_target_description): Add 'segments' parameter to enable
 117         segment base registers.
 118         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
 119         to call to i386_target_description.
 120         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
 121         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
 122         Define I386_NUM_REGS.
 123         (i386_target_description): Add 'segments' parameter to enable
 124         segment base registers.
 125
 126 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
 127
 128         PR/24325
 129         * source-cache.c: #undef open and close, to avoid unresolved
 130         externals during linking.
 131
 132 2019-03-12  Tom Tromey  <tromey@adacore.com>
 133
 134         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
 135         const.  Add initializers.
 136         (_initialize_remote): Don't initialize ptid globals.
 137
 138 2019-03-12  Pedro Alves  <palves@redhat.com>
 139
 140         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
 141
 142 2019-03-12  Pedro Alves  <palves@redhat.com>
 143
 144         * cp-name-parser.y (main): Remove unused 'len' variable.
 145
 146 2019-03-12  Tom Tromey  <tromey@adacore.com>
 147
 148         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
 149         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
 150
 151 2019-03-12  Tom Tromey  <tromey@adacore.com>
 152
 153         * linux-nat.c (iterate_over_lwps): Update.
 154         (stop_callback): Remove parameter.
 155         (stop_wait_callback, detach_callback, resume_set_callback)
 156         (select_singlestep_lwp_callback, set_ignore_sigint)
 157         (status_callback, resumed_callback, resume_clear_callback)
 158         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
 159         data parameter.
 160         (linux_nat_target::detach, linux_nat_target::resume)
 161         (linux_stop_and_wait_all_lwps, select_event_lwp)
 162         (linux_nat_filter_event, linux_nat_wait_1)
 163         (linux_nat_target::kill, linux_nat_target::stop)
 164         (linux_nat_target::stop): Update.
 165         (linux_nat_resume_callback): Change type.
 166         (resume_stopped_resumed_lwps, count_events_callback)
 167         (select_event_lwp_callback): Likewise.
 168         (linux_stop_lwp, linux_nat_stop_lwp): Update.
 169         * arm-linux-nat.c (struct update_registers_data): Remove.
 170         (update_registers_callback): Change type.
 171         (arm_linux_insert_hw_breakpoint1): Update.
 172         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
 173         parameter.
 174         (x86_linux_dr_set_addr): Update.
 175         (x86_linux_dr_set_control): Update.
 176         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
 177         (iterate_over_lwps): Use gdb::function_view.
 178         * nat/aarch64-linux-hw-point.c (struct
 179         aarch64_dr_update_callback_param): Remove.
 180         (debug_reg_change_callback): Change type.
 181         (aarch64_notify_debug_reg_change): Update.
 182         * s390-linux-nat.c (s390_refresh_per_info): Update.
 183
 184 2019-03-11  Tom Tromey  <tromey@adacore.com>
 185
 186         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
 187         redundant assignment to "this_cu".
 188
 189 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 190
 191         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
 192
 193 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 194
 195         * gdbtypes.c (rank_one_type_parm_set): New function extracted
 196         from...
 197         (rank_one_type): ... this.
 198
 199 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 200
 201         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
 202         from...
 203         (rank_one_type): ... this.
 204
 205 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 206
 207         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
 208         from...
 209         (rank_one_type): ... this.
 210
 211 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 212
 213         * gdbtypes.c (rank_one_type_parm_float): New function extracted
 214         from...
 215         (rank_one_type): ... this.
 216
 217 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 218
 219         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
 220         from...
 221         (rank_one_type): ... this.
 222
 223 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 224
 225         * gdbtypes.c (rank_one_type_parm_range): New function extracted
 226         from...
 227         (rank_one_type): ... this.
 228
 229 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 230
 231         * gdbtypes.c (rank_one_type_parm_char): New function extracted
 232         from...
 233         (rank_one_type): ... this.
 234
 235 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 236
 237         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
 238         from...
 239         (rank_one_type): ... this.
 240
 241 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 242
 243         * gdbtypes.c (rank_one_type_parm_int): New function extracted
 244         from...
 245         (rank_one_type): ... this.
 246
 247 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 248
 249         * gdbtypes.c (rank_one_type_parm_func): New function extracted
 250         from...
 251         (rank_one_type): ... this.
 252
 253 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 254
 255         * gdbtypes.c (rank_one_type_parm_array): New function extracted
 256         from...
 257         (rank_one_type): ... this.
 258
 259 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 260
 261         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
 262         from...
 263         (rank_one_type): ... this.
 264
 265 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 266
 267         * inferior.c (initialize_inferiors): Ensure 'help set/show print
 268         inferior-events' shows the example events.
 269
 270 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
 271
 272         Support styling on native MS-Windows console
 273
 274         PR/24315
 275         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
 276         on MS-Windows if $TERM is not defined.
 277
 278         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
 279
 280         * posix-hdep.c (gdb_console_fputs):
 281         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
 282         functions.
 283         * ui-file.h (gdb_console_fputs): Add prototype.
 284
 285         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
 286         back to fputs only if the former returns zero.
 287
 288 2019-03-07  Tom Tromey  <tom@tromey.com>
 289
 290         * symmisc.c (print_symbol_bcache_statistics): Update.
 291         (print_objfile_statistics): Update.
 292         * symfile.c (allocate_symtab): Update.
 293         * stabsread.c: Don't include bcache.h.
 294         * psymtab.h (struct psymbol_bcache): Don't declare.
 295         (class psymtab_storage) <psymbol_cache>: Now a bcache.
 296         (psymbol_bcache_init, psymbol_bcache_free)
 297         (psymbol_bcache_get_bcache): Don't declare.
 298         * psymtab.c (struct psymbol_bcache): Remove.
 299         (psymtab_storage::psymtab_storage): Update.
 300         (psymtab_storage::~psymtab_storage): Update.
 301         (psymbol_bcache_init, psymbol_bcache_free)
 302         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
 303         (add_psymbol_to_bcache): Update.
 304         (allocate_psymtab): Update.
 305         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
 306         macro_cache>: No longer pointers.
 307         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
 308         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
 309         * macrotab.c (macro_bcache): Update.
 310         * macroexp.c: Don't include bcache.h.
 311         * gdbtypes.c (check_types_worklist): Update.
 312         (types_deeply_equal): Remove TRY/CATCH.  Update.
 313         * elfread.c (elf_symtab_read): Update.
 314         * dwarf2read.c: Don't include bcache.h.
 315         * buildsym.c (buildsym_compunit::get_macro_table): Update.
 316         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
 317         (print_bcache_statistics, bcache_memory_used): Don't declare.
 318         (struct bcache): Move from bcache.c.  Add constructor, destructor,
 319         methods.  Rename all data members.
 320         * bcache.c (struct bcache): Move to bcache.h.
 321         (bcache::expand_hash_table): Rename from expand_hash_table.
 322         (bcache): Remove.
 323         (bcache::insert): Rename from bcache_full.
 324         (bcache::compare): Rename from bcache_compare.
 325         (bcache_xmalloc): Remove.
 326         (bcache::~bcache): Rename from bcache_xfree.
 327         (bcache::print_statistics): Rename from print_bcache_statistics.
 328         (bcache::memory_used): Rename from bcache_memory_used.
 329
 330 2019-03-07  Pedro Alves  <palves@redhat.com>
 331
 332         * infrun.c (normal_stop): Also check for
 333         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
 334
 335 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
 336
 337         * f-lang.c (value_from_host_double): Moved to...
 338         * value.c (value_from_host_double): ...here.
 339         * value.h (value_from_host_double): Declare.
 340         * guile/scm-math.c (vlscm_convert_typed_number): Use
 341         value_from_host_double.
 342         (vlscm_convert_number): Likewise.
 343         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
 344         * python/py-value.c (convert_value_from_python): Likewise.
 345
 346 2019-03-06  Tom Tromey  <tom@tromey.com>
 347
 348         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
 349
 350 2019-03-06  Tom Tromey  <tom@tromey.com>
 351
 352         * utils.h (free_current_contents): Don't declare.
 353         * utils.c (free_current_contents): Remove.
 354
 355 2019-03-06  Tom Tromey  <tom@tromey.com>
 356
 357         * top.c (quit_force): Update.
 358         * main.c (captured_command_loop): Update.
 359         * common/new-op.c (operator new): Update.
 360         * common/common-exceptions.c (struct catcher)
 361         <save_cleanup_chain>: Remove member.
 362         (exceptions_state_mc_init): Update.
 363         (exception_try_scope_entry): Return nullptr.
 364         (exception_try_scope_exit, exception_rethrow)
 365         (throw_exception_sjlj, throw_exception_cxx): Update.
 366         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
 367         (all_cleanups, do_cleanups, discard_cleanups)
 368         (discard_final_cleanups, save_cleanups, save_final_cleanups)
 369         (restore_cleanups, restore_final_cleanups): Don't declare.
 370         (do_final_cleanups): Remove parameter.
 371         * common/cleanups.c (cleanup_chain, make_cleanup)
 372         (make_cleanup_dtor, all_cleanups, do_cleanups)
 373         (discard_my_cleanups, discard_cleanups)
 374         (discard_final_cleanups, save_my_cleanups, save_cleanups)
 375         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
 376         (null_cleanup): Remove.
 377         (do_final_cleanups): Remove parameter.
 378
 379 2019-03-06  Tom Tromey  <tom@tromey.com>
 380
 381         * remote.c (remote_target::remote_parse_stop_reply): Use
 382         unique_xmalloc_ptr.
 383
 384 2019-03-06  Tom Tromey  <tom@tromey.com>
 385
 386         * stabsread.c (struct stabs_field_info): Rename from field_info.
 387         <list, fnlist>: Add initializers.
 388         <obstack>: New member.
 389         (read_member_functions, read_struct_fields, read_baseclasses):
 390         Allocate on obstack.  Don't use cleanups.
 391         (read_one_struct_field, read_member_functions, read_struct_fields)
 392         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
 393         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
 394         (read_struct_type): Update.
 395
 396 2019-03-06  Tom Tromey  <tom@tromey.com>
 397
 398         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
 399         * common/filestuff.h (make_cleanup_close): Don't declare.
 400         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
 401         Remove.
 402
 403 2019-03-06  Tom Tromey  <tom@tromey.com>
 404
 405         * solib-aix.c: Use make_scope_exit.
 406
 407 2019-03-06  Tom Tromey  <tom@tromey.com>
 408
 409         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
 410         Use make_scope_exit.
 411
 412 2019-03-06  Tom Tromey  <tom@tromey.com>
 413
 414         * solib-svr4.c (disable_probes_interface): Remove parameter.
 415         (svr4_handle_solib_event): Use make_scope_exit.
 416
 417 2019-03-06  Tom Tromey  <tom@tromey.com>
 418
 419         * remote.c (struct stop_reply_deleter): Remove.
 420         (stop_reply_up): Update.
 421         (struct stop_reply): Derive from notif_event.  Don't typedef.
 422         <regcache>: Now a std::vector.
 423         (stop_reply_xfree): Remove.
 424         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
 425         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
 426         (remote_target::discard_pending_stop_replies): Use delete.
 427         (remote_target::remote_parse_stop_reply): Update.
 428         (remote_target::process_stop_reply): Update.
 429         * remote-notif.h (struct notif_event): Add virtual destructor.
 430         Remove "dtr" member.
 431         (struct notif_client) <alloc_event>: Return a unique_ptr.
 432         (notif_event_xfree): Don't declare.
 433         (notif_event_up): New typedef.
 434         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
 435         (notif_event_xfree, do_notif_event_xfree): Remove.
 436         (remote_notif_state_xfree): Update.
 437
 438 2019-03-06  Tom Tromey  <tom@tromey.com>
 439
 440         * infrun.c (displaced_step_clear_cleanup): Now a
 441         forward_scope_exit type.
 442         (displaced_step_prepare_throw): Update.
 443         (displaced_step_fixup): Update.
 444
 445 2019-03-06  Tom Tromey  <tom@tromey.com>
 446
 447         * inferior.h (class inferior): Update comment.
 448         * gdbthread.h (class thread_info): Update comment.
 449
 450 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
 451             Tom Tromey  <tom@tromey.com>
 452
 453         * stabsread.h (struct stab_section_list): Remove.
 454         (coffstab_build_psymtabs): Update.
 455         * dbxread.c (symbuf_sections): Now a std::vector.
 456         (sect_idx): New global.
 457         (fill_symbuf): Update.
 458         (coffstab_build_psymtabs): Change type of stabsects parameter.
 459         Update.
 460         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
 461         std::vector.
 462         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
 463         (coff_locate_sections): Update.
 464         (coff_symfile_read): Remove cleanups.  Update.
 465         (init_stringtab): Add storage parameter.
 466         (free_stringtab, free_stringtab_cleanup): Remove.
 467         (init_lineno): Add storage parameter.
 468         (free_linetab, free_linetab_cleanup): Remove.
 469
 470 2019-03-06  Pedro Alves  <palves@redhat.com>
 471
 472         * linux-fork.c (fork_info::clobber_regs): Delete.
 473         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
 474         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
 475         comment.  Adjust.
 476         (scoped_switch_fork_info::scoped_switch_fork_info)
 477         (checkpoint_command, linux_fork_context): Adjust
 478         fork_save_infrun_state calls.
 479
 480 2019-03-06  Pedro Alves  <palves@redhat.com>
 481
 482         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
 483         (inf_has_multiple_threads): Return 'bool' and rewrite using
 484         inferior_info::threads().
 485
 486 2019-03-06  Pedro Alves  <palves@redhat.com>
 487
 488         * linux-fork.c: Include <list>.
 489         (fork_list): Now a std::list instance.
 490         (fork_info): Add ctor, dtor, and in-class initialize all fields.
 491         (forks_exist_p, find_last_fork): Adjust.
 492         (new_fork): Delete.
 493         (one_fork_p): New.
 494         (add_fork): Adjust.
 495         (free_fork): Delete, folded into fork_info::~fork_info().
 496         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
 497         Adjust.
 498         (init_fork_list): Delete.
 499         (linux_fork_killall, linux_fork_mourn_inferior)
 500         (linux_fork_detach, info_checkpoints_command): Adjust.
 501         (_initialize_linux_fork): No longer call init_fork_list.
 502
 503 2019-03-06  Pedro Alves  <palves@redhat.com>
 504
 505         * linux-fork.c (new_fork): New, split out of ...
 506         (add_fork): ... this.  Return void.  Move "first fork" special
 507         case from here, to ...
 508         (checkpoint_command): ... here.
 509         * linux-linux.h (add_fork): Return void.
 510
 511 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 512
 513         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
 514
 515 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 516             Chris January  <chris.january@arm.com>
 517             David Lecomber  <david.lecomber@arm.com>
 518
 519         * f-exp.y: New token, UNOP_INTRINSIC.
 520         (exp): New pattern using UNOP_INTRINSIC token.
 521         (f77_keywords): Add 'abs' keyword.
 522         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
 523         (value_from_host_double): New function.
 524         (evaluate_subexp_f): Support UNOP_ABS.
 525
 526 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 527
 528         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
 529         types.
 530
 531 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 532
 533         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
 534         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
 535         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
 536
 537 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 538
 539         * f-exp.y (convert_to_kind_type): Handle more type kinds.
 540
 541 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 542             Chris January  <chris.january@arm.com>
 543
 544         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
 545         * f-exp.y: Define 'KIND' token.
 546         (exp): New pattern for KIND expressions.
 547         (ptype): Handle types with a kind extension.
 548         (direct_abs_decl): Extend to spot kind extensions.
 549         (f77_keywords): Add 'kind' to the list.
 550         (push_kind_type): New function.
 551         (convert_to_kind_type): New function.
 552         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
 553         * parse.c (operator_length_standard): Likewise.
 554         * parser-defs.h (enum type_pieces): Add tp_kind.
 555         * std-operator.def: Add UNOP_KIND.
 556
 557 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 558
 559         * f-exp.y (f_parse): Set yydebug.
 560
 561 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 562
 563         * f-lang.c (evaluate_subexp_f): New function.
 564         (exp_descriptor_f): New global.
 565         (f_language_defn): Use exp_descriptor_f instead of
 566         exp_descriptor_standard.
 567
 568 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 569
 570         * f-exp.y (struct token): Add comments.
 571         (dot_ops): Remove uppercase versions and the end marker.
 572         (f77_keywords): Likewise.
 573         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
 574         entries in the dot_ops array are case insensitive, and use
 575         strncasecmp to compare strings.  Also some whitespace cleanup in
 576         this area.  Similar for the f77_keywords array, except entries in
 577         this list might be case sensitive.
 578
 579 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 580
 581         * f-exp.y (struct f77_boolean_val): Add comments.
 582         (boolean_values): Remove uppercase versions, and end marker.
 583         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
 584         and use strncasecmp to achieve case insensitivity.  Additionally,
 585         perform whitespace cleanup around this code.
 586
 587 2019-03-06  Tom Tromey  <tromey@adacore.com>
 588
 589         * remote-sim.c (gdbsim_target_open): Use result of
 590         gdb_argv::release.
 591
 592 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
 593         Dirk Schubert  <dirk.schubert@arm.com>
 594         Chris January  <chris.january@arm.com>
 595
 596         * eval.c (evaluate_subexp_standard): Call Fortran argument
 597         wrapping logic.
 598         * f-lang.c (struct value): A value which can be passed into a
 599         Fortran function call.
 600         (fortran_argument_convert): Wrap Fortran arguments in a pointer
 601         where appropriate.
 602         (struct type): Value ready for a Fortran function call.
 603         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
 604         is needed.
 605         * f-lang.h (fortran_argument_convert): Declaration.
 606         (fortran_preserve_arg_pointer): Declaration.
 607         * infcall.c (value_arg_coerce): Call Fortran argument logic.
 608
 609 2019-03-05  Tom Tromey  <tromey@adacore.com>
 610
 611         * python/py-prettyprint.c (print_string_repr): Remove #if.
 612         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
 613
 614 2019-03-05  Tom Tromey  <tromey@adacore.com>
 615
 616         * target.c (the_dummy_target): Move later.  Change type to
 617         "dummy_target".
 618         (initialize_targets): Don't initialize the_dummy_target.
 619
 620 2019-03-05  Tom Tromey  <tromey@adacore.com>
 621
 622         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
 623         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
 624
 625 2019-03-05  Tom Tromey  <tromey@adacore.com>
 626
 627         * windows-nat.c (windows_nat_target::attach)
 628         (windows_nat_target::detach): Don't call gdb_flush.
 629         * valprint.c (generic_val_print, val_print, val_print_string):
 630         Don't call gdb_flush.
 631         * utils.c (defaulted_query): Don't call gdb_flush.
 632         * typeprint.c (print_type_scalar): Don't call gdb_flush.
 633         * target.c (target_announce_detach): Don't call gdb_flush.
 634         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
 635         * remote.c (extended_remote_target::attach): Don't call
 636         gdb_flush.
 637         * procfs.c (procfs_target::detach): Don't call gdb_flush.
 638         * printcmd.c (do_examine): Don't call gdb_flush.
 639         (info_display_command): Don't call gdb_flush.
 640         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
 641         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
 642         * memattr.c (info_mem_command): Don't call gdb_flush.
 643         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
 644         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
 645         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
 646         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
 647         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
 648         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
 649         (gnu_nat_target::detach): Don't call gdb_flush.
 650         * f-valprint.c (f_val_print): Don't call gdb_flush.
 651         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
 652         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
 653         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
 654         gdb_flush.
 655         * c-valprint.c (c_val_print): Don't call gdb_flush.
 656         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
 657
 658 2019-03-05  Tom Tromey  <tromey@adacore.com>
 659
 660         * varobj.c (update_dynamic_varobj_children): Update.
 661         (install_default_visualizer): Use reset, not release.
 662         * value.c (set_internalvar): Update.
 663         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
 664         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
 665         ATTRIBUTE_UNUSED_RESULT.
 666
 667 2019-03-05  Tom Tromey  <tromey@adacore.com>
 668
 669         * remote.c (class scoped_remote_fd) <release>: Add
 670         ATTRIBUTE_UNUSED_RESULT.
 671
 672 2019-03-05  Tom Tromey  <tromey@adacore.com>
 673
 674         * macroexp.c (struct macro_buffer) <release>: Add
 675         ATTRIBUTE_UNUSED_RESULT.
 676
 677 2019-03-05  Tom Tromey  <tromey@adacore.com>
 678
 679         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
 680         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
 681         ATTRIBUTE_UNUSED_RESULT.
 682
 683 2019-03-05  Tom Tromey  <tromey@adacore.com>
 684
 685         * common/scoped_fd.h (class scoped_fd) <release>: Add
 686         ATTRIBUTE_UNUSED_RESULT.
 687
 688 2019-03-05  Tom Tromey  <tromey@adacore.com>
 689
 690         * parser-defs.h (struct parser_state) <release>: Add
 691         ATTRIBUTE_UNUSED_RESULT.
 692
 693 2019-03-05  Tom Tromey  <tromey@adacore.com>
 694
 695         * utils.h (class gdb_argv) <release>: Add
 696         ATTRIBUTE_UNUSED_RESULT.
 697         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
 698
 699 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
 700
 701         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
 702         for-loop range, to avoid compiler warnings.
 703
 704         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
 705         avoid compiler warnings about unused variables.
 706
 707         * NEWS: Mention end of support for native debugging on MS-Windows
 708         before XP.
 709
 710         PR gdb/24292
 711         * common/netstuff.c:
 712         * gdbserver/gdbreplay.c
 713         * gdbserver/remote-utils.c:
 714         * ser-tcp.c:
 715         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
 716         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
 717         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
 718         'getaddrinfo' and 'freeaddrinfo' were not available before
 719         Windows XP, and mingw.org's MinGW headers by default define
 720         _WIN32_WINNT to 0x500.
 721
 722 2019-03-01  Gary Benson <gbenson@redhat.com>
 723
 724         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
 725
 726 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
 727             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 728
 729         PR gdb/8527
 730         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
 731         set_sigint_trap, clear_sigint_trap.
 732
 733 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 734
 735         * target.c (target_detach): Clear the regcache and the
 736         frame cache.
 737
 738 2019-02-27  Pedro Alves  <palves@redhat.com>
 739
 740         * utils.c (set_screen_size): When we cap the height/width sizes,
 741         tweak the corresponding command variable to show "unlimited":
 742
 743 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
 744             Pedro Alves  <palves@redhat.com>
 745
 746         * utils.c (set_screen_size): Reduce "infinite" rows and columns
 747         before calling rl_set_screen_size.
 748
 749 2019-02-27  Tom Tromey  <tromey@adacore.com>
 750
 751         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
 752         define.
 753         * python/py-value.c: Remove Python 2.4 workaround.
 754         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
 755         workaround.
 756         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
 757         Python 2.4 workaround.
 758         * python/python-internal.h: Remove Python 2.4 comment.
 759         (Py_ssize_t): Don't define.
 760         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
 761         (gdb_Py_DECREF): Remove Python 2.4 workaround.
 762         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
 763         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
 764         * python/python.c (do_start_initialization): Remove Python 2.4
 765         workaround.
 766         * python/py-prettyprint.c (class dummy_python_frame): Remove.
 767         (print_children): Remove Python 2.4 workaround.
 768         * python/py-inferior.c (buffer_procs): Remove Python 2.4
 769         workaround.
 770         (CHARBUFFERPROC_NAME): Remove.
 771         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
 772         Python 2.4 workaround.
 773
 774 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
 775
 776         * NEWS: Note minimum Python version.
 777
 778 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
 779
 780         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
 781         code from these functions.  Remove corresponding ifdefs.  Use
 782         Py_buffer_up instead of explicit calls to PyBuffer_Release.
 783         Remove gotos and target of gotos.
 784         (infpy_search_memory): Likewise.
 785
 786 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 787
 788         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
 789         (hppa_gdbarch_init): Don't register deleted functions with
 790         gdbarch.
 791
 792 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 793
 794         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
 795         (h8300_unwind_sp): Delete.
 796         (h8300_dummy_id): Delete.
 797         (h8300_gdbarch_init): Don't register deleted functions with
 798         gdbarch.
 799
 800 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 801
 802         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
 803         (ft32_unwind_pc): Delete.
 804         (ft32_unwind_sp): Delete.
 805         (ft32_gdbarch_init): Don't register deleted functions with
 806         gdbarch.
 807
 808 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 809
 810         * gdb/frv-tdep.c (frv_dummy_id): Delete.
 811         (frv_unwind_pc): Delete.
 812         (frv_unwind_sp): Delete.
 813         (frv_gdbarch_init): Don't register deleted functions with
 814         gdbarch.
 815
 816 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 817
 818         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
 819         (riscv_unwind_pc): Delete.
 820         (riscv_unwind_sp): Delete.
 821         (riscv_gdbarch_init): Don't register deleted functions with
 822         gdbarch.
 823
 824 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 825
 826         * gdb/csky-tdep.c (csky_dummy_id): Delete.
 827         (csky_unwind_pc): Delete.
 828         (csky_unwind_sp): Delete.
 829         (csky_gdbarch_init): Don't register deleted functions with
 830         gdbarch.
 831
 832 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 833
 834         * gdb/cris-tdep.c (cris_dummy_id): Delete.
 835         (cris_unwind_pc): Delete.
 836         (cris_unwind_sp): Delete.
 837         (cris_gdbarch_init): Don't register deleted functions with
 838         gdbarch.
 839
 840 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 841
 842         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
 843         (bfin_unwind_pc): Delete.
 844         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
 845
 846 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 847
 848         * gdb/arm-tdep.c (arm_dummy_id): Delete.
 849         (arm_unwind_pc): Delete.
 850         (arm_unwind_sp): Delete.
 851         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
 852
 853 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 854
 855         * gdb/arc-tdep.c (arc_dummy_id): Delete.
 856         (arc_unwind_pc): Delete.
 857         (arc_unwind_sp): Delete.
 858         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
 859
 860 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 861
 862         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
 863         (alpha_unwind_pc): Delete.
 864         (alpha_gdbarch_init): Don't register deleted functions with
 865         gdbarch.
 866
 867 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 868
 869         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
 870         (aarch64_unwind_pc): Delete.
 871         (aarch64_unwind_sp): Delete.
 872         (aarch64_gdbarch_init): Don't register deleted functions with
 873         gdbarch.
 874
 875 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 876
 877         * gdbtypes.c (type_align): Don't consider static members when
 878         computing structure alignment.
 879
 880 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 881
 882         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
 883         return 0 for other types.
 884         * arch-utils.c (default_type_align): Always return 0.
 885         * gdbarch.h: Regenerate.
 886         * gdbarch.sh (type_align): Extend comment.
 887         * gdbtypes.c (type_align): Add additional comments, always call
 888         gdbarch_type_align before applying the default rules.
 889         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
 890         generic code will then apply a suitable default.
 891         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
 892         types, return 0 for other types.
 893
 894 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 895
 896         * NEWS: Create a new section for the next release branch.
 897         Rename the section of the current branch, now that it has
 898         been cut.
 899
 900 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 901
 902         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
 903         * version.in: Bump version to 8.3.50.DATE-git.
 904
 905 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
 906
 907         * aix-thread.c (ptid_cmp): Remove unused variable.
 908         (get_signaled_thread): Likewise.
 909         (store_regs_user_thread): Likewise.
 910         (store_regs_kernel_thread): Likewise.
 911         (fetch_regs_kernel_thread): Remove shadowed variable.
 912
 913 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
 914
 915         * features/riscv/32bit-cpu.xml: Add register numbers.
 916         * features/riscv/32bit-fpu.c: Regenerate.
 917         * features/riscv/32bit-fpu.xml: Add register numbers.
 918         * features/riscv/64bit-cpu.xml: Add register numbers.
 919         * features/riscv/64bit-fpu.c: Regenerate.
 920         * features/riscv/64bit-fpu.xml: Add register numbers.
 921
 922 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
 923
 924         * NEWS: Mention two argument form of gdb.Value constructor.
 925         * python/py-value.c (convert_buffer_and_type_to_value): New
 926         function.
 927         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
 928         Add support for handling an optional second argument.  Call
 929         convert_buffer_and_type_to_value as appropriate.
 930         * python/python-internal.h (Py_buffer_deleter): New struct.
 931         (Py_buffer_up): New typedef.
 932
 933 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
 934
 935         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
 936         instead of releasing ownership.
 937
 938 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
 939
 940         * dwarf2read.c (open_and_init_dwp_file): Call
 941         elf_numsections instead of bfd_count_sections to initialize
 942         dwp_file->num_sections.
 943
 944 2019-02-25  Tom Tromey  <tromey@adacore.com>
 945
 946         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
 947
 948 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 949
 950         * gcore.in: Add '--readnever' option when invoking GDB.
 951
 952 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
 953
 954         * MAINTAINERS: Update my email address.
 955
 956 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
 957
 958         * build-id.c (build_id_to_debug_bfd_1): New function.
 959         (build_id_to_debug_bfd): Look for separate debug file in
 960         sysroot.
 961
 962 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 963
 964         * gdbarch.sh: Update the copyright year range that is placed into
 965         generated files.
 966
 967 2019-02-22  Keith Seitz  <keiths@redhat.com>
 968
 969         PR symtab/23853
 970         * linespec.c (create_sals_line_offset): Search for the default
 971         symtab's filename instead of its fullname.
 972
 973 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 974
 975         * NEWS: Update style defaults.
 976
 977 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 978
 979         * main.c (captured_main_1): Disable styling in batch mode.
 980
 981 2019-02-20  Tom Tromey  <tom@tromey.com>
 982
 983         * symtab.c (symtab_symbol_info): Fix typos.
 984
 985 2019-02-20  Tom Tromey  <tromey@adacore.com>
 986
 987         * findcmd.c (_initialize_mem_search): Use upper case for
 988         metasyntactic variables.
 989
 990 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
 991
 992         * aarch64-tdep.c (aarch64_add_reggroups): New function.
 993         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
 994
 995 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
 996
 997         * top.h (source_file_name): Change to std::string.
 998         * top.c (source_file_name): Likewise.
 999         (command_line_input): Adjust.
1000         * cli/cli-script.c (script_from_file): Adjust.
1001
1002 2019-02-19  Tom Tromey  <tromey@adacore.com>
1003
1004         * ravenscar-thread.c
1005         (ravenscar_thread_target::update_thread_list): Don't call
1006         ada_build_task_list.
1007         * ada-lang.h (ada_build_task_list): Don't declare.
1008         * ada-tasks.c (struct ada_tasks_inferior_data)
1009         <task_list_valid_p>: Now bool.
1010         (read_known_tasks, ada_task_list_changed)
1011         (ada_tasks_invalidate_inferior_data): Update.
1012         (read_known_tasks_array): Return bool.
1013         (read_known_tasks_list): Likewise.
1014         (read_known_tasks): Return void.
1015         (ada_build_task_list): Now static.
1016
1017 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1018
1019         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
1020         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
1021
1022 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1023
1024         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
1025         variant for ada_tasks_pspace_data_handle and
1026         ada_tasks_inferior_data_handle.
1027         (ada_tasks_pspace_data_cleanup): New function.
1028         (ada_tasks_inferior_data_cleanup): New function.
1029
1030 2019-02-17  Tom Tromey  <tom@tromey.com>
1031
1032         * macrotab.h (macro_source_fullname): Return a std::string.
1033         * macrotab.c (macro_include, check_for_redefinition)
1034         (macro_undef, macro_lookup_definition, foreach_macro)
1035         (foreach_macro_in_scope): Update.
1036         (macro_source_fullname): Return a std::string.
1037         * macrocmd.c (show_pp_source_pos): Update.
1038
1039 2019-02-17  Tom Tromey  <tom@tromey.com>
1040
1041         * macrocmd.c (show_pp_source_pos): Style the file names.
1042
1043 2019-02-17  Tom Tromey  <tom@tromey.com>
1044
1045         PR tui/24197:
1046         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
1047
1048 2019-02-17  Tom Tromey  <tom@tromey.com>
1049
1050         * ada-lang.c (user_select_syms): Use filtered printing.
1051         * utils.c (wrap_style): New global.
1052         (desired_style): Remove.
1053         (emit_style_escape): Add stream parameter.
1054         (set_output_style, reset_terminal_style, prompt_for_continue):
1055         Update.
1056         (flush_wrap_buffer): Only flush gdb_stdout.
1057         (wrap_here): Set wrap_style.
1058         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
1059         treat escape sequences as a character.  Change when wrap buffer is
1060         flushed.
1061         (fputs_styled): Do not set the output style when the default is
1062         requested.
1063         * ui-style.h (struct ui_file_style) <is_default>: New method.
1064         * source.c (print_source_lines_base): Emit escape sequences in one
1065         piece.
1066
1067 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1068
1069         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
1070         integers and enumeration types.
1071
1072 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1073
1074         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
1075         instead of lookup_symbol_in_language
1076         (do_exact_match): New function.
1077         (ada_get_symbol_name_matcher): Return do_exact_match when
1078         doing a verbatim match.
1079
1080 2019-02-15  Tom Tromey  <tromey@adacore.com>
1081
1082         * ravenscar-thread.c (ravenscar_thread_target::resume)
1083         (ravenscar_thread_target::wait): Special case wildcard requests.
1084
1085 2019-02-15  Tom Tromey  <tromey@adacore.com>
1086
1087         * ravenscar-thread.c (base_ptid): Remove.
1088         (struct ravenscar_thread_target) <close>: New method.
1089         <m_base_ptid>: New member.
1090         <update_inferior_ptid, active_task, task_is_currently_active,
1091         runtime_initialized>: Declare methods.
1092         <ravenscar_thread_target>: Add constructor.
1093         (ravenscar_thread_target::task_is_currently_active)
1094         (ravenscar_thread_target::update_inferior_ptid)
1095         (ravenscar_runtime_initialized): Rename.  Now methods.
1096         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
1097         (ravenscar_thread_target::update_thread_list): Update.
1098         (ravenscar_thread_target::active_task): Now method.
1099         (ravenscar_thread_target::store_registers)
1100         (ravenscar_thread_target::prepare_to_store)
1101         (ravenscar_thread_target::prepare_to_store)
1102         (ravenscar_thread_target::mourn_inferior): Update.
1103         (ravenscar_inferior_created): Use "new" to create target.
1104         (ravenscar_thread_target::get_ada_task_ptid): Update.
1105         (_initialize_ravenscar): Don't initialize base_ptid.
1106         (ravenscar_ops): Remove global.
1107
1108 2019-02-15  Tom Tromey  <tromey@adacore.com>
1109
1110         * target.h (push_target): Declare new overload.
1111         * target.c (push_target): New overload, taking an rvalue reference.
1112         * remote.c (remote_target::open_1): Use push_target overload.
1113         * corelow.c (core_target_open): Use push_target overload.
1114
1115 2019-02-15  Tom Tromey  <tromey@adacore.com>
1116
1117         * ravenscar-thread.c (is_ravenscar_task)
1118         (ravenscar_task_is_currently_active): Return bool.
1119         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
1120         (_initialize_ravenscar): Remove "(void)".
1121         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
1122         Return bool.
1123
1124 2019-02-15  Tom Tromey  <tromey@adacore.com>
1125
1126         * ravenscar-thread.c (ravenscar_runtime_initializer)
1127         (has_ravenscar_runtime, get_running_thread_id)
1128         (ravenscar_thread_target::resume): Fix indentation.
1129
1130 2019-02-15  Tom Tromey  <tromey@adacore.com>
1131
1132         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
1133         from ravenscar_arch_ops.
1134         (sparc_ravenscar_ops::fetch_registers)
1135         (sparc_ravenscar_ops::store_registers): Now methods.
1136         (sparc_ravenscar_prepare_to_store): Remove.
1137         (sparc_ravenscar_ops): Redefine.
1138         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
1139         methods and destructor.  Remove members.
1140         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
1141         (ravenscar_thread_target::store_registers)
1142         (ravenscar_thread_target::prepare_to_store): Update.
1143         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
1144         Remove.
1145         (struct ppc_ravenscar_powerpc_ops): Derive from
1146         ravenscar_arch_ops.
1147         (ppc_ravenscar_powerpc_ops::fetch_registers)
1148         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
1149         (ppc_ravenscar_powerpc_ops): Redefine.
1150         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
1151         (ppc_ravenscar_e500_ops::fetch_registers)
1152         (ppc_ravenscar_e500_ops::store_registers): Now methods.
1153         (ppc_ravenscar_e500_ops): Redefine.
1154         * aarch64-ravenscar-thread.c
1155         (aarch64_ravenscar_generic_prepare_to_store): Remove.
1156         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
1157         (aarch64_ravenscar_fetch_registers)
1158         (aarch64_ravenscar_store_registers): Now methods.
1159         (aarch64_ravenscar_ops): Redefine.
1160
1161 2019-02-15  Tom Tromey  <tromey@adacore.com>
1162
1163         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
1164         (ravenscar_thread_target::stopped_by_hw_breakpoint)
1165         (ravenscar_thread_target::stopped_by_watchpoint)
1166         (ravenscar_thread_target::stopped_data_address)
1167         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
1168
1169 2019-02-15  Tom Tromey  <tromey@adacore.com>
1170
1171         * ravenscar-thread.c: Fix some typos.
1172
1173 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1174             Tom Tromey  <tromey@adacore.com>
1175
1176         * ada-lang.c (ada_exception_sal): Change addr_string to a
1177         std::string.
1178         (create_ada_exception_catchpoint): Update.
1179
1180 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1181             Tom Tromey  <tromey@adacore.com>
1182
1183         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
1184         (bp_location_ops): Remove.
1185         (base_breakpoint_allocate_location): Update.
1186         (free_bp_location): Update.
1187         * ada-lang.c (class ada_catchpoint_location)
1188         <ada_catchpoint_location>: Remove ops parameter.
1189         (ada_catchpoint_location_dtor): Remove.
1190         (ada_catchpoint_location_ops): Remove.
1191         (allocate_location_exception): Update.
1192         * breakpoint.h (struct bp_location_ops): Remove.
1193         (class bp_location) <bp_location>: Remove bp_location_ops
1194         parameter.
1195         <~bp_location>: Add destructor.
1196         <ops>: Remove.
1197
1198 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1199             Pedro Alves  <palves@redhat.com>
1200
1201         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
1202         'PATH_MAX'.
1203
1204 2019-02-14  David Michael  <fedora.dm0@gmail.com>
1205             Samuel Thibault  <samuel.thibault@gnu.org>
1206             Thomas Schwinge  <thomas@codesourcery.com>
1207
1208         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
1209         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
1210
1211 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1212
1213         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
1214         (check_empty): Use "const char *".
1215
1216         * gnu-nat.c (gnu_nat_target::detach): Instead of
1217         'detach_inferior (pid)' call
1218         'detach_inferior (find_inferior_pid (pid))'.
1219
1220         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
1221         'nat/fork-inferior.o'.
1222         * gnu-nat.c: #include "nat/fork-inferior.h".
1223
1224         * gnu-nat.c (gnu_nat_target::detach): Instead of
1225         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
1226         * gnu-nat.h: #include "inf-child.h".
1227         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
1228         'i386_gnu_nat_target::fetch_registers'.
1229         (gnu_store_registers): Rename/move to
1230         'i386_gnu_nat_target::store_registers'.
1231
1232         * config/i386/nm-i386gnu.h: Don't "#include" any files.
1233         * gnu-nat.h (mach_thread_info): New function.
1234         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
1235
1236         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
1237
1238 2019-02-14  Frederic Konrad  <konrad@adacore.com>
1239
1240         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
1241
1242 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
1243
1244         * windows-nat.c (windows_add_thread): Add new parameter
1245         "main_thread_p" with default value set to false.  Update
1246         function documentation as well as all callers.
1247         (windows_delete_thread): Likewise.
1248         (fake_create_process): Update call to windows_add_thread.
1249         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
1250         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
1251         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
1252         call to windows_delete_thread.
1253
1254 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
1255
1256         * MAINTAINERS: Add Andrew Burgess as global maintainer.
1257
1258 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1259
1260         * symfile.c (find_separate_debug_file): Use canonical path of
1261         sysroot with child_path instead of gdb_sysroot if it is valid.
1262
1263 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1264
1265         * symfile.c (find_separate_debug_file): Use child_path to
1266         determine if an object file is under a sysroot.
1267
1268 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1269
1270         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1271         unittests/child-path-selftests.c.
1272         * common/pathstuff.c (child_path): New function.
1273         * common/pathstuff.h (child_path): New prototype.
1274         * unittests/child-path-selftests.c: New file.
1275
1276 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1277
1278         * symfile.c (find_separate_debug_file): Look for separate debug
1279         files in debug directories under the sysroot.
1280
1281 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1282
1283         * symtab.h (struct minimal_symbol data_p): New const method.
1284         (struct minimal_symbol text_p): Likewise.
1285         * symtab.c (output_source_filename): Use file name style
1286         to print file name.
1287         (print_symbol_info): Likewise.
1288         (print_msymbol_info): Use address style to print addresses.
1289         Use function name style to print executable text symbols.
1290         (expand_symtab_containing_pc): Use data_p.
1291         (find_pc_sect_compunit_symtab): Likewise.
1292
1293 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1294
1295         * breakpoint.c (describe_other_breakpoints): Use address style
1296         to print addresses.
1297         (say_where): Likewise.
1298
1299 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1300
1301         * ada-typeprint.c (print_func_type): Print function name
1302         style to print function name.
1303         * c-typeprint.c (c_print_type_1): Likewise.
1304
1305 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
1306
1307         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
1308         for execve.
1309
1310 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1311
1312         * c-exp.y (direct_abs_decl): Use emplace_back to record the
1313         type_stack.
1314
1315 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
1316
1317         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
1318         TYPE_CODE_REF types.
1319
1320 2019-02-08  Jim Wilson  <jimw@sifive.com>
1321
1322         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
1323         (riscv_linux_fregset): New.
1324         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
1325
1326 2019-02-07  Tom Tromey  <tom@tromey.com>
1327
1328         * thread.c (thread_cancel_execution_command): Update.
1329         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
1330         methods.
1331         (struct thread_fsm_ops): Remove.
1332         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
1333         (thread_fsm_should_stop, thread_fsm_return_value)
1334         (thread_fsm_set_finished, thread_fsm_finished_p)
1335         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
1336         Don't declare.
1337         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
1338         * infrun.c (clear_proceed_status_thread)
1339         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
1340         (print_stop_event): Update.
1341         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
1342         Add constructor.
1343         (step_command_fsm_ops): Remove.
1344         (new_step_command_fsm): Remove.
1345         (step_1): Update.
1346         (step_command_fsm::should_stop): Rename from
1347         step_command_fsm_should_stop.
1348         (step_command_fsm::clean_up): Rename from
1349         step_command_fsm_clean_up.
1350         (step_command_fsm::do_async_reply_reason): Rename from
1351         step_command_fsm_async_reply_reason.
1352         (struct until_next_fsm): Inherit from thread_fsm.  Add
1353         constructor.
1354         (until_next_fsm_ops): Remove.
1355         (new_until_next_fsm): Remove.
1356         (until_next_fsm::should_stop): Rename from
1357         until_next_fsm_should_stop.
1358         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
1359         (until_next_fsm::do_async_reply_reason): Rename from
1360         until_next_fsm_async_reply_reason.
1361         (struct finish_command_fsm): Inherit from thread_fsm.  Add
1362         constructor.  Change type of breakpoint.
1363         (finish_command_fsm_ops): Remove.
1364         (new_finish_command_fsm): Remove.
1365         (finish_command_fsm::should_stop): Rename from
1366         finish_command_fsm_should_stop.
1367         (finish_command_fsm::clean_up): Rename from
1368         finish_command_fsm_clean_up.
1369         (finish_command_fsm::return_value): Rename from
1370         finish_command_fsm_return_value.
1371         (finish_command_fsm::do_async_reply_reason): Rename from
1372         finish_command_fsm_async_reply_reason.
1373         (finish_command): Update.
1374         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
1375         Add constructor.
1376         (call_thread_fsm_ops): Remove.
1377         (call_thread_fsm::call_thread_fsm): Rename from
1378         new_call_thread_fsm.
1379         (call_thread_fsm::should_stop): Rename from
1380         call_thread_fsm_should_stop.
1381         (call_thread_fsm::should_notify_stop): Rename from
1382         call_thread_fsm_should_notify_stop.
1383         (run_inferior_call, call_function_by_hand_dummy): Update.
1384         * cli/cli-interp.c (should_print_stop_to_console): Update.
1385         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
1386         Add constructor.  Change type of location_breakpoint,
1387         caller_breakpoint.
1388         (until_break_fsm_ops): Remove.
1389         (new_until_break_fsm): Remove.
1390         (until_break_fsm::should_stop): Rename from
1391         until_break_fsm_should_stop.
1392         (until_break_fsm::clean_up): Rename from
1393         until_break_fsm_clean_up.
1394         (until_break_fsm::do_async_reply_reason): Rename from
1395         until_break_fsm_async_reply_reason.
1396         (until_break_command): Update.
1397         * thread-fsm.c: Remove.
1398         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
1399
1400 2019-02-07  Tom Tromey  <tom@tromey.com>
1401
1402         * yy-remap.h: Add include guard.
1403         * xtensa-tdep.h: Add include guard.
1404         * xcoffread.h: Rename include guard.
1405         * varobj-iter.h: Add include guard.
1406         * tui/tui.h: Rename include guard.
1407         * tui/tui-winsource.h: Rename include guard.
1408         * tui/tui-wingeneral.h: Rename include guard.
1409         * tui/tui-windata.h: Rename include guard.
1410         * tui/tui-win.h: Rename include guard.
1411         * tui/tui-stack.h: Rename include guard.
1412         * tui/tui-source.h: Rename include guard.
1413         * tui/tui-regs.h: Rename include guard.
1414         * tui/tui-out.h: Rename include guard.
1415         * tui/tui-layout.h: Rename include guard.
1416         * tui/tui-io.h: Rename include guard.
1417         * tui/tui-hooks.h: Rename include guard.
1418         * tui/tui-file.h: Rename include guard.
1419         * tui/tui-disasm.h: Rename include guard.
1420         * tui/tui-data.h: Rename include guard.
1421         * tui/tui-command.h: Rename include guard.
1422         * tic6x-tdep.h: Add include guard.
1423         * target/waitstatus.h: Rename include guard.
1424         * target/wait.h: Rename include guard.
1425         * target/target.h: Rename include guard.
1426         * target/resume.h: Rename include guard.
1427         * target-float.h: Rename include guard.
1428         * stabsread.h: Add include guard.
1429         * rs6000-tdep.h: Add include guard.
1430         * riscv-fbsd-tdep.h: Add include guard.
1431         * regformats/regdef.h: Rename include guard.
1432         * record.h: Rename include guard.
1433         * python/python.h: Rename include guard.
1434         * python/python-internal.h: Rename include guard.
1435         * python/py-stopevent.h: Rename include guard.
1436         * python/py-ref.h: Rename include guard.
1437         * python/py-record.h: Rename include guard.
1438         * python/py-record-full.h: Rename include guard.
1439         * python/py-record-btrace.h: Rename include guard.
1440         * python/py-instruction.h: Rename include guard.
1441         * python/py-events.h: Rename include guard.
1442         * python/py-event.h: Rename include guard.
1443         * procfs.h: Add include guard.
1444         * proc-utils.h: Add include guard.
1445         * p-lang.h: Add include guard.
1446         * or1k-tdep.h: Rename include guard.
1447         * observable.h: Rename include guard.
1448         * nto-tdep.h: Rename include guard.
1449         * nat/x86-linux.h: Rename include guard.
1450         * nat/x86-linux-dregs.h: Rename include guard.
1451         * nat/x86-gcc-cpuid.h: Add include guard.
1452         * nat/x86-dregs.h: Rename include guard.
1453         * nat/x86-cpuid.h: Rename include guard.
1454         * nat/ppc-linux.h: Rename include guard.
1455         * nat/mips-linux-watch.h: Rename include guard.
1456         * nat/linux-waitpid.h: Rename include guard.
1457         * nat/linux-ptrace.h: Rename include guard.
1458         * nat/linux-procfs.h: Rename include guard.
1459         * nat/linux-osdata.h: Rename include guard.
1460         * nat/linux-nat.h: Rename include guard.
1461         * nat/linux-namespaces.h: Rename include guard.
1462         * nat/linux-btrace.h: Rename include guard.
1463         * nat/glibc_thread_db.h: Rename include guard.
1464         * nat/gdb_thread_db.h: Rename include guard.
1465         * nat/gdb_ptrace.h: Rename include guard.
1466         * nat/fork-inferior.h: Rename include guard.
1467         * nat/amd64-linux-siginfo.h: Rename include guard.
1468         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
1469         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
1470         * nat/aarch64-linux.h: Rename include guard.
1471         * nat/aarch64-linux-hw-point.h: Rename include guard.
1472         * mn10300-tdep.h: Add include guard.
1473         * mips-linux-tdep.h: Add include guard.
1474         * mi/mi-parse.h: Rename include guard.
1475         * mi/mi-out.h: Rename include guard.
1476         * mi/mi-main.h: Rename include guard.
1477         * mi/mi-interp.h: Rename include guard.
1478         * mi/mi-getopt.h: Rename include guard.
1479         * mi/mi-console.h: Rename include guard.
1480         * mi/mi-common.h: Rename include guard.
1481         * mi/mi-cmds.h: Rename include guard.
1482         * mi/mi-cmd-break.h: Rename include guard.
1483         * m2-lang.h: Add include guard.
1484         * location.h: Rename include guard.
1485         * linux-record.h: Rename include guard.
1486         * linux-nat.h: Add include guard.
1487         * linux-fork.h: Add include guard.
1488         * i386-darwin-tdep.h: Rename include guard.
1489         * hppa-linux-offsets.h: Add include guard.
1490         * guile/guile.h: Rename include guard.
1491         * guile/guile-internal.h: Rename include guard.
1492         * gnu-nat.h: Rename include guard.
1493         * gdb-stabs.h: Rename include guard.
1494         * frv-tdep.h: Add include guard.
1495         * f-lang.h: Add include guard.
1496         * event-loop.h: Add include guard.
1497         * darwin-nat.h: Rename include guard.
1498         * cp-abi.h: Rename include guard.
1499         * config/sparc/nm-sol2.h: Rename include guard.
1500         * config/nm-nto.h: Rename include guard.
1501         * config/nm-linux.h: Add include guard.
1502         * config/i386/nm-i386gnu.h: Rename include guard.
1503         * config/djgpp/nl_types.h: Rename include guard.
1504         * config/djgpp/langinfo.h: Rename include guard.
1505         * compile/gcc-cp-plugin.h: Add include guard.
1506         * compile/gcc-c-plugin.h: Add include guard.
1507         * compile/compile.h: Rename include guard.
1508         * compile/compile-object-run.h: Rename include guard.
1509         * compile/compile-object-load.h: Rename include guard.
1510         * compile/compile-internal.h: Rename include guard.
1511         * compile/compile-cplus.h: Rename include guard.
1512         * compile/compile-c.h: Rename include guard.
1513         * common/xml-utils.h: Rename include guard.
1514         * common/x86-xstate.h: Rename include guard.
1515         * common/version.h: Rename include guard.
1516         * common/vec.h: Rename include guard.
1517         * common/tdesc.h: Rename include guard.
1518         * common/selftest.h: Rename include guard.
1519         * common/scoped_restore.h: Rename include guard.
1520         * common/scoped_mmap.h: Rename include guard.
1521         * common/scoped_fd.h: Rename include guard.
1522         * common/safe-iterator.h: Rename include guard.
1523         * common/run-time-clock.h: Rename include guard.
1524         * common/refcounted-object.h: Rename include guard.
1525         * common/queue.h: Rename include guard.
1526         * common/ptid.h: Rename include guard.
1527         * common/print-utils.h: Rename include guard.
1528         * common/preprocessor.h: Rename include guard.
1529         * common/pathstuff.h: Rename include guard.
1530         * common/observable.h: Rename include guard.
1531         * common/netstuff.h: Rename include guard.
1532         * common/job-control.h: Rename include guard.
1533         * common/host-defs.h: Rename include guard.
1534         * common/gdb_wait.h: Rename include guard.
1535         * common/gdb_vecs.h: Rename include guard.
1536         * common/gdb_unlinker.h: Rename include guard.
1537         * common/gdb_unique_ptr.h: Rename include guard.
1538         * common/gdb_tilde_expand.h: Rename include guard.
1539         * common/gdb_sys_time.h: Rename include guard.
1540         * common/gdb_string_view.h: Rename include guard.
1541         * common/gdb_splay_tree.h: Rename include guard.
1542         * common/gdb_setjmp.h: Rename include guard.
1543         * common/gdb_ref_ptr.h: Rename include guard.
1544         * common/gdb_optional.h: Rename include guard.
1545         * common/gdb_locale.h: Rename include guard.
1546         * common/gdb_assert.h: Rename include guard.
1547         * common/filtered-iterator.h: Rename include guard.
1548         * common/filestuff.h: Rename include guard.
1549         * common/fileio.h: Rename include guard.
1550         * common/environ.h: Rename include guard.
1551         * common/common-utils.h: Rename include guard.
1552         * common/common-types.h: Rename include guard.
1553         * common/common-regcache.h: Rename include guard.
1554         * common/common-inferior.h: Rename include guard.
1555         * common/common-gdbthread.h: Rename include guard.
1556         * common/common-exceptions.h: Rename include guard.
1557         * common/common-defs.h: Rename include guard.
1558         * common/common-debug.h: Rename include guard.
1559         * common/cleanups.h: Rename include guard.
1560         * common/buffer.h: Rename include guard.
1561         * common/btrace-common.h: Rename include guard.
1562         * common/break-common.h: Rename include guard.
1563         * cli/cli-utils.h: Rename include guard.
1564         * cli/cli-style.h: Rename include guard.
1565         * cli/cli-setshow.h: Rename include guard.
1566         * cli/cli-script.h: Rename include guard.
1567         * cli/cli-interp.h: Rename include guard.
1568         * cli/cli-decode.h: Rename include guard.
1569         * cli/cli-cmds.h: Rename include guard.
1570         * charset-list.h: Add include guard.
1571         * buildsym-legacy.h: Rename include guard.
1572         * bfin-tdep.h: Add include guard.
1573         * ax.h: Rename include guard.
1574         * arm-linux-tdep.h: Add include guard.
1575         * arm-fbsd-tdep.h: Add include guard.
1576         * arch/xtensa.h: Rename include guard.
1577         * arch/tic6x.h: Add include guard.
1578         * arch/i386.h: Add include guard.
1579         * arch/arm.h: Rename include guard.
1580         * arch/arm-linux.h: Rename include guard.
1581         * arch/arm-get-next-pcs.h: Rename include guard.
1582         * arch/amd64.h: Add include guard.
1583         * arch/aarch64-insn.h: Rename include guard.
1584         * arch-utils.h: Rename include guard.
1585         * annotate.h: Add include guard.
1586         * amd64-darwin-tdep.h: Rename include guard.
1587         * aarch64-linux-tdep.h: Add include guard.
1588         * aarch64-fbsd-tdep.h: Add include guard.
1589         * aarch32-linux-nat.h: Add include guard.
1590
1591 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1592
1593         * macrotab.c (macro_define_internal): New function that
1594         factorizes macro_define_object_internal and macro_define_function
1595         code.
1596         (macro_define_object_internal): Use macro_define_internal.
1597         (macro_define_function): Likewise.
1598
1599 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1600
1601         * macrocmd.c (extract_identifier): Return
1602         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
1603         callers.
1604
1605 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
1606
1607         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
1608
1609 2019-02-05  Tom Tromey  <tom@tromey.com>
1610
1611         * target.c (target_stack::unpush): Move assertion earlier.
1612
1613 2019-01-30  Tom Tromey  <tom@tromey.com>
1614
1615         PR python/23615:
1616         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
1617         (gdbpy_parse_and_eval): Likewise.
1618         * python/python-internal.h (gdbpy_allow_threads): New class.
1619
1620 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
1621
1622         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
1623         (aarch64_fbsd_fpregmap): Move earlier.
1624         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
1625         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1626         instead of individual calls to trad_frame_set_reg_addr.
1627         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
1628         earlier.
1629         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
1630         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1631         instead of individual calls to trad_frame_set_reg_addr.
1632
1633 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
1634
1635         * CONTRIBUTE: Replace contribution list with wiki link.
1636
1637 2019-01-25  Tom Tromey  <tom@tromey.com>
1638
1639         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
1640
1641 2019-01-25  Tom Tromey  <tom@tromey.com>
1642
1643         * xtensa-linux-nat.c: Fix common/ includes.
1644         * xml-support.h: Fix common/ includes.
1645         * xml-support.c: Fix common/ includes.
1646         * x86-linux-nat.c: Fix common/ includes.
1647         * windows-nat.c: Fix common/ includes.
1648         * varobj.h: Fix common/ includes.
1649         * varobj.c: Fix common/ includes.
1650         * value.c: Fix common/ includes.
1651         * valops.c: Fix common/ includes.
1652         * utils.c: Fix common/ includes.
1653         * unittests/xml-utils-selftests.c: Fix common/ includes.
1654         * unittests/utils-selftests.c: Fix common/ includes.
1655         * unittests/unpack-selftests.c: Fix common/ includes.
1656         * unittests/tracepoint-selftests.c: Fix common/ includes.
1657         * unittests/style-selftests.c: Fix common/ includes.
1658         * unittests/string_view-selftests.c: Fix common/ includes.
1659         * unittests/scoped_restore-selftests.c: Fix common/ includes.
1660         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
1661         * unittests/scoped_fd-selftests.c: Fix common/ includes.
1662         * unittests/rsp-low-selftests.c: Fix common/ includes.
1663         * unittests/parse-connection-spec-selftests.c: Fix common/
1664         includes.
1665         * unittests/optional-selftests.c: Fix common/ includes.
1666         * unittests/offset-type-selftests.c: Fix common/ includes.
1667         * unittests/observable-selftests.c: Fix common/ includes.
1668         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
1669         * unittests/memrange-selftests.c: Fix common/ includes.
1670         * unittests/memory-map-selftests.c: Fix common/ includes.
1671         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
1672         * unittests/function-view-selftests.c: Fix common/ includes.
1673         * unittests/environ-selftests.c: Fix common/ includes.
1674         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
1675         * unittests/common-utils-selftests.c: Fix common/ includes.
1676         * unittests/cli-utils-selftests.c: Fix common/ includes.
1677         * unittests/array-view-selftests.c: Fix common/ includes.
1678         * ui-file.c: Fix common/ includes.
1679         * tui/tui-io.c: Fix common/ includes.
1680         * tracepoint.h: Fix common/ includes.
1681         * tracepoint.c: Fix common/ includes.
1682         * tracefile-tfile.c: Fix common/ includes.
1683         * top.h: Fix common/ includes.
1684         * top.c: Fix common/ includes.
1685         * thread.c: Fix common/ includes.
1686         * target/waitstatus.h: Fix common/ includes.
1687         * target/waitstatus.c: Fix common/ includes.
1688         * target.h: Fix common/ includes.
1689         * target.c: Fix common/ includes.
1690         * target-memory.c: Fix common/ includes.
1691         * target-descriptions.c: Fix common/ includes.
1692         * symtab.h: Fix common/ includes.
1693         * symfile.c: Fix common/ includes.
1694         * stap-probe.c: Fix common/ includes.
1695         * spu-linux-nat.c: Fix common/ includes.
1696         * sparc-nat.c: Fix common/ includes.
1697         * source.c: Fix common/ includes.
1698         * solib.c: Fix common/ includes.
1699         * solib-target.c: Fix common/ includes.
1700         * ser-unix.c: Fix common/ includes.
1701         * ser-tcp.c: Fix common/ includes.
1702         * ser-pipe.c: Fix common/ includes.
1703         * ser-base.c: Fix common/ includes.
1704         * selftest-arch.c: Fix common/ includes.
1705         * s12z-tdep.c: Fix common/ includes.
1706         * rust-exp.y: Fix common/ includes.
1707         * rs6000-aix-tdep.c: Fix common/ includes.
1708         * riscv-tdep.c: Fix common/ includes.
1709         * remote.c: Fix common/ includes.
1710         * remote-notif.h: Fix common/ includes.
1711         * remote-fileio.h: Fix common/ includes.
1712         * remote-fileio.c: Fix common/ includes.
1713         * regcache.h: Fix common/ includes.
1714         * regcache.c: Fix common/ includes.
1715         * record-btrace.c: Fix common/ includes.
1716         * python/python.c: Fix common/ includes.
1717         * python/py-type.c: Fix common/ includes.
1718         * python/py-inferior.c: Fix common/ includes.
1719         * progspace.h: Fix common/ includes.
1720         * producer.c: Fix common/ includes.
1721         * procfs.c: Fix common/ includes.
1722         * proc-api.c: Fix common/ includes.
1723         * printcmd.c: Fix common/ includes.
1724         * ppc-linux-nat.c: Fix common/ includes.
1725         * parser-defs.h: Fix common/ includes.
1726         * osdata.c: Fix common/ includes.
1727         * obsd-nat.c: Fix common/ includes.
1728         * nat/x86-linux.c: Fix common/ includes.
1729         * nat/x86-linux-dregs.c: Fix common/ includes.
1730         * nat/x86-dregs.h: Fix common/ includes.
1731         * nat/x86-dregs.c: Fix common/ includes.
1732         * nat/ppc-linux.c: Fix common/ includes.
1733         * nat/mips-linux-watch.h: Fix common/ includes.
1734         * nat/mips-linux-watch.c: Fix common/ includes.
1735         * nat/linux-waitpid.c: Fix common/ includes.
1736         * nat/linux-ptrace.h: Fix common/ includes.
1737         * nat/linux-ptrace.c: Fix common/ includes.
1738         * nat/linux-procfs.c: Fix common/ includes.
1739         * nat/linux-personality.c: Fix common/ includes.
1740         * nat/linux-osdata.c: Fix common/ includes.
1741         * nat/linux-namespaces.c: Fix common/ includes.
1742         * nat/linux-btrace.h: Fix common/ includes.
1743         * nat/linux-btrace.c: Fix common/ includes.
1744         * nat/fork-inferior.c: Fix common/ includes.
1745         * nat/amd64-linux-siginfo.c: Fix common/ includes.
1746         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
1747         * nat/aarch64-linux.c: Fix common/ includes.
1748         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
1749         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
1750         * namespace.h: Fix common/ includes.
1751         * mips-linux-tdep.c: Fix common/ includes.
1752         * minsyms.c: Fix common/ includes.
1753         * mi/mi-parse.h: Fix common/ includes.
1754         * mi/mi-main.c: Fix common/ includes.
1755         * mi/mi-cmd-env.c: Fix common/ includes.
1756         * memrange.h: Fix common/ includes.
1757         * memattr.c: Fix common/ includes.
1758         * maint.h: Fix common/ includes.
1759         * maint.c: Fix common/ includes.
1760         * main.c: Fix common/ includes.
1761         * machoread.c: Fix common/ includes.
1762         * location.c: Fix common/ includes.
1763         * linux-thread-db.c: Fix common/ includes.
1764         * linux-nat.c: Fix common/ includes.
1765         * linux-fork.c: Fix common/ includes.
1766         * inline-frame.c: Fix common/ includes.
1767         * infrun.c: Fix common/ includes.
1768         * inflow.c: Fix common/ includes.
1769         * inferior.h: Fix common/ includes.
1770         * inferior.c: Fix common/ includes.
1771         * infcmd.c: Fix common/ includes.
1772         * inf-ptrace.c: Fix common/ includes.
1773         * inf-child.c: Fix common/ includes.
1774         * ia64-linux-nat.c: Fix common/ includes.
1775         * i387-tdep.c: Fix common/ includes.
1776         * i386-tdep.c: Fix common/ includes.
1777         * i386-linux-tdep.c: Fix common/ includes.
1778         * i386-linux-nat.c: Fix common/ includes.
1779         * i386-go32-tdep.c: Fix common/ includes.
1780         * i386-fbsd-tdep.c: Fix common/ includes.
1781         * i386-fbsd-nat.c: Fix common/ includes.
1782         * guile/scm-type.c: Fix common/ includes.
1783         * guile/guile.c: Fix common/ includes.
1784         * go32-nat.c: Fix common/ includes.
1785         * gnu-nat.c: Fix common/ includes.
1786         * gdbthread.h: Fix common/ includes.
1787         * gdbarch-selftests.c: Fix common/ includes.
1788         * gdb_usleep.c: Fix common/ includes.
1789         * gdb_select.h: Fix common/ includes.
1790         * gdb_bfd.c: Fix common/ includes.
1791         * gcore.c: Fix common/ includes.
1792         * fork-child.c: Fix common/ includes.
1793         * findvar.c: Fix common/ includes.
1794         * fbsd-nat.c: Fix common/ includes.
1795         * event-top.c: Fix common/ includes.
1796         * event-loop.c: Fix common/ includes.
1797         * dwarf2read.c: Fix common/ includes.
1798         * dwarf2loc.c: Fix common/ includes.
1799         * dwarf2-frame.c: Fix common/ includes.
1800         * dwarf-index-cache.c: Fix common/ includes.
1801         * dtrace-probe.c: Fix common/ includes.
1802         * disasm-selftests.c: Fix common/ includes.
1803         * defs.h: Fix common/ includes.
1804         * csky-tdep.c: Fix common/ includes.
1805         * cp-valprint.c: Fix common/ includes.
1806         * cp-support.h: Fix common/ includes.
1807         * cp-support.c: Fix common/ includes.
1808         * corelow.c: Fix common/ includes.
1809         * completer.h: Fix common/ includes.
1810         * completer.c: Fix common/ includes.
1811         * compile/compile.c: Fix common/ includes.
1812         * compile/compile-loc2c.c: Fix common/ includes.
1813         * compile/compile-cplus-types.c: Fix common/ includes.
1814         * compile/compile-cplus-symbols.c: Fix common/ includes.
1815         * command.h: Fix common/ includes.
1816         * cli/cli-dump.c: Fix common/ includes.
1817         * cli/cli-cmds.c: Fix common/ includes.
1818         * charset.c: Fix common/ includes.
1819         * build-id.c: Fix common/ includes.
1820         * btrace.h: Fix common/ includes.
1821         * btrace.c: Fix common/ includes.
1822         * breakpoint.h: Fix common/ includes.
1823         * breakpoint.c: Fix common/ includes.
1824         * ax.h:
1825         (enum agent_op): Fix common/ includes.
1826         * ax-general.c (struct aop_map): Fix common/ includes.
1827         * ax-gdb.c: Fix common/ includes.
1828         * auxv.c: Fix common/ includes.
1829         * auto-load.c: Fix common/ includes.
1830         * arm-tdep.c: Fix common/ includes.
1831         * arch/riscv.c: Fix common/ includes.
1832         * arch/ppc-linux-common.c: Fix common/ includes.
1833         * arch/i386.c: Fix common/ includes.
1834         * arch/arm.c: Fix common/ includes.
1835         * arch/arm-linux.c: Fix common/ includes.
1836         * arch/arm-get-next-pcs.c: Fix common/ includes.
1837         * arch/amd64.c: Fix common/ includes.
1838         * arch/aarch64.c: Fix common/ includes.
1839         * arch/aarch64-insn.c: Fix common/ includes.
1840         * arch-utils.c: Fix common/ includes.
1841         * amd64-windows-tdep.c: Fix common/ includes.
1842         * amd64-tdep.c: Fix common/ includes.
1843         * amd64-sol2-tdep.c: Fix common/ includes.
1844         * amd64-obsd-tdep.c: Fix common/ includes.
1845         * amd64-nbsd-tdep.c: Fix common/ includes.
1846         * amd64-linux-tdep.c: Fix common/ includes.
1847         * amd64-linux-nat.c: Fix common/ includes.
1848         * amd64-fbsd-tdep.c: Fix common/ includes.
1849         * amd64-fbsd-nat.c: Fix common/ includes.
1850         * amd64-dicos-tdep.c: Fix common/ includes.
1851         * amd64-darwin-tdep.c: Fix common/ includes.
1852         * agent.c: Fix common/ includes.
1853         * ada-lang.h: Fix common/ includes.
1854         * ada-lang.c: Fix common/ includes.
1855         * aarch64-tdep.c: Fix common/ includes.
1856
1857 2019-01-25  Tom Tromey  <tom@tromey.com>
1858
1859         * common/create-version.sh: Use common/version.h.
1860
1861 2019-01-24  Pedro Alves  <palves@redhat.com>
1862
1863         * infrun.c (signal_stop, signal_print, signal_program)
1864         (signal_catch, signal_pass): Now arrays instead of pointers.
1865         (update_signals_program_target, do_target_resume)
1866         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1867         * linux-nat.c (linux_nat_target::pass_signals)
1868         (linux_nat_target::create_inferior, linux_nat_target::attach):
1869         Adjust.
1870         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1871         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1872         * procfs.c (procfs_target::pass_signals): Adjust.
1873         * record-full.c (record_full_target::resume): Adjust.
1874         * remote.c (remote_target::pass_signals)
1875         (remote_target::program_signals): Adjust.
1876         * target-debug.h (target_debug_print_signals): Now takes a
1877         gdb::array_view as parameter.  Adjust.
1878         * target.h (target_ops) <pass_signals, program_signals>: Replace
1879         pointer and length parameters with gdb::array_view.
1880         (target_pass_signals, target_program_signals): Likewise.
1881         * target-delegates.c: Regenerate.
1882
1883 2019-01-24  Pedro Alves  <palves@redhat.com>
1884
1885         * common/forward-scope-exit.h
1886         (forward_scope_exit::forward_scope_exit): Pass arguments to
1887         m_bind_function directly, instead of creating a std::bind and
1888         copying that.
1889
1890 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1891
1892         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1893         for static members.
1894         (pass_in_v_vfp_candidate): Likewise.
1895
1896 2019-01-23  Tom Tromey  <tom@tromey.com>
1897             Pedro Alves  <palves@redhat.com>
1898
1899         * regcache.c (class regcache_invalidator): Remove.
1900         (regcache::raw_write): Use make_scope_exit.
1901
1902 2019-01-23  Tom Tromey  <tom@tromey.com>
1903
1904         * ui-out.h (class ui_out_emit_type): Update comment.
1905
1906 2019-01-23  Tom Tromey  <tom@tromey.com>
1907
1908         * infrun.c (fetch_inferior_event): Update comment.
1909
1910 2019-01-23  Tom Tromey  <tom@tromey.com>
1911             Pedro Alves  <palves@redhat.com>
1912
1913         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1914         parameter.
1915         (fetch_inferior_event): Use SCOPE_EXIT.
1916
1917
1918 2019-01-23  Tom Tromey  <tom@tromey.com>
1919             Pedro Alves  <palves@redhat.com>
1920
1921         * infrun.c (disable_thread_events): Delete.
1922         (stop_all_threads): Use SCOPE_EXIT.
1923
1924 2019-01-23  Tom Tromey  <tom@tromey.com>
1925             Pedro Alves  <palves@redhat.com>
1926
1927         * symfile.c: Include forward-scope-exit.h.
1928         (clear_symtab_users_cleanup): Replace forward declaration with
1929         a FORWARD_SCOPE_EXIT.
1930         (syms_from_objfile_1): Use the forward_scope_exit and
1931         gdb::optional instead of cleanup_function.
1932         (reread_symbols): Use the forward_scope_exit instead of
1933         cleanup_function.
1934         (clear_symtab_users_cleanup): Remove function.
1935
1936 2019-01-23  Tom Tromey  <tom@tromey.com>
1937             Pedro Alves  <palves@redhat.com>
1938
1939         * linux-nat.c: Include scope-exit.h.
1940         (cleanup_target_stop): Remove.
1941         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1942         SCOPE_EXIT.
1943
1944 2019-01-23  Tom Tromey  <tom@tromey.com>
1945             Pedro Alves  <palves@redhat.com>
1946
1947         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1948         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1949
1950 2019-01-23  Tom Tromey  <tom@tromey.com>
1951             Andrew Burgess  <andrew.burgess@embecosm.com>
1952             Pedro Alves  <palves@redhat.com>
1953
1954         * infrun.c (fetch_inferior_event): Use scope_exit.
1955         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1956         * top.c (execute_command): Use scope_exit.
1957         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1958         * utils.c (do_bpstat_clear_actions_cleanup)
1959         (make_bpstat_clear_actions_cleanup): Remove.
1960
1961 2019-01-23  Tom Tromey  <tom@tromey.com>
1962             Pedro Alves  <palves@redhat.com>
1963
1964         * infrun.c: Include "common/scope-exit.h"
1965         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1966         (wait_for_inferior): Use SCOPE_EXIT.
1967         (fetch_inferior_event): Use scope_exit.
1968
1969 2019-01-23  Tom Tromey  <tom@tromey.com>
1970             Pedro Alves  <palves@redhat.com>
1971
1972         * breakpoint.c (create_breakpoint): Remove cleanup.
1973
1974 2019-01-23  Tom Tromey  <tom@tromey.com>
1975             Andrew Burgess  <andrew.burgess@embecosm.com>
1976             Pedro Alves  <palves@redhat.com>
1977
1978 2019-01-23  Pedro Alves  <palves@redhat.com>
1979
1980         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1981
1982 2019-01-23  Pedro Alves  <palves@redhat.com>
1983             Andrew Burgess  <andrew.burgess@embecosm.com>
1984
1985         * gdbthread.h: Include "common/forward-scope-exit.h".
1986         (scoped_finish_thread_state): Redefine custom class in terms of
1987         forward_scope_exit.
1988
1989 2019-01-23  Pedro Alves  <palves@redhat.com>
1990             Andrew Burgess  <andrew.burgess@embecosm.com>
1991
1992         * common/forward-scope-exit.h: New file.
1993
1994 2019-01-23  Pedro Alves  <palves@redhat.com>
1995             Andrew Burgess  <andrew.burgess@embecosm.com>
1996             Tom Tromey  <tom@tromey.com>
1997
1998         * common/scope-exit.h: New file.
1999
2000 2019-01-23  Pedro Alves  <palves@redhat.com>
2001
2002         * common/preprocessor.h (ESC): Rename to ...
2003         (ESC_PARENS): ... this.
2004         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
2005         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
2006
2007 2019-01-23  Tom Tromey  <tom@tromey.com>
2008
2009         * language.h (class scoped_switch_to_sym_language_if_auto):
2010         Initialize m_lang in both cases.
2011
2012 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
2013
2014         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
2015         with XCNEW.
2016
2017 2019-01-22  Tom Tromey  <tom@tromey.com>
2018
2019         * corelow.c: Do not include sys/file.h.
2020
2021 2019-01-22  Tom Tromey  <tom@tromey.com>
2022
2023         * tui/tui-wingeneral.h: Include gdb_curses.h.
2024
2025 2019-01-22  Tom Tromey  <tom@tromey.com>
2026
2027         * source-cache.h (class source_cache) <get_source_lines,
2028         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
2029
2030 2019-01-22  Tom Tromey  <tom@tromey.com>
2031
2032         * remote-fileio.h (struct remote_target): Declare.
2033
2034 2019-01-22  Tom Tromey  <tom@tromey.com>
2035
2036         * python/py-arch.c: Do not include py-ref.h.
2037         * python/py-bpevent.c: Do not include py-ref.h.
2038         * python/py-cmd.c: Do not include py-ref.h.
2039         * python/py-continueevent.c: Do not include py-ref.h.
2040         * python/py-event.h: Do not include py-ref.h.
2041         * python/py-evtregistry.c: Do not include py-ref.h.
2042         * python/py-finishbreakpoint.c: Do not include py-ref.h.
2043         * python/py-frame.c: Do not include py-ref.h.
2044         * python/py-framefilter.c: Do not include py-ref.h.
2045         * python/py-function.c: Do not include py-ref.h.
2046         * python/py-infevents.c: Do not include py-ref.h.
2047         * python/py-linetable.c: Do not include py-ref.h.
2048         * python/py-objfile.c: Do not include py-ref.h.
2049         * python/py-param.c: Do not include py-ref.h.
2050         * python/py-prettyprint.c: Do not include py-ref.h.
2051         * python/py-progspace.c: Do not include py-ref.h.
2052         * python/py-symbol.c: Do not include py-ref.h.
2053         * python/py-symtab.c: Do not include py-ref.h.
2054         * python/py-type.c: Do not include py-ref.h.
2055         * python/py-unwind.c: Do not include py-ref.h.
2056         * python/py-utils.c: Do not include py-ref.h.
2057         * python/py-value.c: Do not include py-ref.h.
2058         * python/py-varobj.c: Do not include py-ref.h.
2059         * python/py-xmethods.c: Do not include py-ref.h.
2060         * python/python.c: Do not include py-ref.h.
2061         * varobj.c: Do not include py-ref.h.
2062
2063 2019-01-22  Tom Tromey  <tom@tromey.com>
2064
2065         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
2066         keyword for bcache.
2067
2068 2019-01-22  Tom Tromey  <tom@tromey.com>
2069
2070         * compile/compile-cplus-types.c: Remove a comment by #include.
2071
2072 2019-01-22  Tom Tromey  <tom@tromey.com>
2073
2074         * compile/gcc-c-plugin.h: Include compile-internal.h.
2075
2076 2019-01-22  Tom Tromey  <tom@tromey.com>
2077
2078         * stabsread.c (EXTERN): Do not define.
2079         (symnum, next_symbol_text_func, processing_gcc_compilation)
2080         (within_function, global_sym_chain, global_stabs)
2081         (previous_stab_code, this_object_header_files)
2082         (n_this_object_header_files)
2083         (n_allocated_this_object_header_files): Define.
2084         * stabsread.h (EXTERN): Never define.  Use "extern".
2085
2086 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2087
2088         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
2089         history_value.
2090
2091 2019-01-21  Tom Tromey  <tom@tromey.com>
2092
2093         * ui-out.c: Fix includes.
2094         * tui/tui-source.c: Fix includes.
2095         * target.c: Fix includes.
2096         * remote.c: Fix includes.
2097         * regcache.c: Fix includes.
2098         * python/py-block.c: Fix includes.
2099         * printcmd.c: Fix includes.
2100         * or1k-tdep.c: Fix includes.
2101         * mi/mi-main.c: Fix includes.
2102         * m32r-tdep.c: Fix includes.
2103         * csky-tdep.c: Fix includes.
2104         * compile/compile-cplus-types.c: Fix includes.
2105         * cli/cli-interp.c: Fix includes.
2106
2107 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
2108
2109         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2110         for padding.
2111
2112 2019-01-16  Tom Tromey  <tom@tromey.com>
2113
2114         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
2115         earlier.
2116         (struct objfile) <msymbols_range>: Move from top level.
2117         <msymbols>: New method.
2118         (class objfile_msymbols): Remove.
2119         * symtab.c (default_collect_symbol_completion_matches_break_on):
2120         Update.
2121         * symmisc.c (dump_msymbols): Update.
2122         * stabsread.c (scan_file_globals): Update.
2123         * objc-lang.c (info_selectors_command, info_classes_command)
2124         (find_methods): Update.
2125         * minsyms.c (find_solib_trampoline_target): Update.
2126         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
2127         * coffread.c (coff_symfile_read): Update.
2128         * ada-lang.c (ada_lookup_simple_minsym)
2129         (ada_collect_symbol_completion_matches): Update.
2130
2131 2019-01-16  Tom Tromey  <tom@tromey.com>
2132
2133         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
2134         type.  Remove no-argument constructor.
2135         <iterator::operator++>: Simplify.
2136         <begin>: Update.
2137         <end>: Use minimal_symbol_count.
2138
2139 2019-01-16  Tom Tromey  <tom@tromey.com>
2140
2141         * objfiles.h (struct objfile) <psymtabs>: New method.
2142         (class objfile_psymtabs): Remove.
2143         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
2144         typedef.
2145         <range>: New method.
2146         (require_partial_symbols): Change return type.
2147         * psymtab.c (require_partial_symbols)
2148         (psym_expand_symtabs_matching): Update.
2149         * mdebugread.c (parse_partial_symbols): Update.
2150         * dbxread.c (dbx_end_psymtab): Update.
2151
2152 2019-01-15  Tom Tromey  <tom@tromey.com>
2153
2154         * symtab.c (lookup_objfile_from_block)
2155         (lookup_symbol_in_objfile_symtabs)
2156         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
2157         (find_line_symtab, info_sources_command)
2158         (default_collect_symbol_completion_matches_break_on)
2159         (make_source_files_completion_list): Update.
2160         * symmisc.c (print_objfile_statistics, dump_objfile)
2161         (maintenance_print_symbols, maintenance_info_symtabs)
2162         (maintenance_check_symtabs, maintenance_info_line_tables):
2163         Update.
2164         * source.c (select_source_symtab)
2165         (forget_cached_source_info_for_objfile): Update.
2166         * objfiles.h (class objfile_compunits): Remove.
2167         (struct objfile) <compunits_range>: New typedef.
2168         (compunits): New method.
2169         * objfiles.c (objfile_relocate1): Update.
2170         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2171         * maint.c (count_symtabs_and_blocks): Update.
2172         * linespec.c (iterate_over_all_matching_symtabs): Update.
2173         * cp-support.c (add_symbol_overload_list_qualified): Update.
2174         * coffread.c (coff_symtab_read): Update.
2175         * ada-lang.c (add_nonlocal_symbols)
2176         (ada_collect_symbol_completion_matches)
2177         (ada_add_global_exceptions): Update.
2178
2179 2019-01-15  Tom Tromey  <tom@tromey.com>
2180
2181         * progspace.h (program_space) <objfiles_safe_range>: New
2182         typedef.
2183         <objfiles_safe>: New method.
2184         * objfiles.h (class all_objfiles_safe): Remove.
2185         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
2186         * jit.c (jit_inferior_exit_hook): Update.
2187
2188 2019-01-17  Tom Tromey  <tom@tromey.com>
2189
2190         * progspace.h (program_space) <objfiles_range>: New typedef.
2191         <objfiles>: New method.
2192         <objfiles_head>: Rename from objfiles.
2193         (object_files): Update.
2194         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
2195         * guile/scm-pretty-print.c
2196         (ppscm_find_pretty_printer_from_objfiles): Update.
2197         * guile/scm-objfile.c (gdbscm_objfiles): Update.
2198         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
2199         Update.
2200         * python/py-progspace.c (pspy_get_objfiles): Update.
2201         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2202         Update.
2203         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2204         (objfpy_lookup_objfile_by_build_id): Update.
2205         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2206         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2207         Update.
2208         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2209         (expand_symtab_containing_pc, lookup_objfile_from_block)
2210         (lookup_static_symbol, basic_lookup_transparent_type)
2211         (find_pc_sect_compunit_symtab, find_symbol_at_address)
2212         (find_line_symtab, info_sources_command)
2213         (default_collect_symbol_completion_matches_break_on)
2214         (make_source_files_completion_list, find_main_name): Update.
2215         * symmisc.c (print_symbol_bcache_statistics)
2216         (print_objfile_statistics, maintenance_print_symbols)
2217         (maintenance_print_msymbols, maintenance_print_objfiles)
2218         (maintenance_info_symtabs, maintenance_check_symtabs)
2219         (maintenance_expand_symtabs, maintenance_info_line_tables):
2220         Update.
2221         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
2222         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
2223         (map_overlay_command, unmap_overlay_command)
2224         (simple_overlay_update, expand_symtabs_matching)
2225         (map_symbol_filenames): Update.
2226         * symfile-debug.c (set_debug_symfile): Update.
2227         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
2228         Update.
2229         * source.c (select_source_symtab, forget_cached_source_info):
2230         Update.
2231         * solib.c (solib_read_symbols): Update.
2232         * solib-spu.c (append_ocl_sos): Update.
2233         * psymtab.c (maintenance_print_psymbols)
2234         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
2235         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
2236         * printcmd.c (info_symbol_command): Update.
2237         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
2238         Update.
2239         * objfiles.h (class all_objfiles): Remove.
2240         * objfiles.c (have_partial_symbols, have_full_symbols)
2241         (have_minimal_symbols, qsort_cmp, update_section_map)
2242         (shared_objfile_contains_address_p)
2243         (default_iterate_over_objfiles_in_search_order): Update.
2244         * objc-lang.c (info_selectors_command, info_classes_command)
2245         (find_methods): Update.
2246         * minsyms.c (find_solib_trampoline_target): Update.
2247         * maint.c (maintenance_info_sections)
2248         (maintenance_translate_address, count_symtabs_and_blocks):
2249         Update.
2250         * main.c (captured_main_1): Update.
2251         * linux-thread-db.c (try_thread_db_load_from_pdir)
2252         (has_libpthread): Update.
2253         * linespec.c (iterate_over_all_matching_symtabs)
2254         (search_minsyms_for_name): Update.
2255         * jit.c (jit_find_objf_with_entry_addr): Update.
2256         * hppa-tdep.c (find_unwind_entry)
2257         (hppa_lookup_stub_minimal_symbol): Update.
2258         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
2259         Update.
2260         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2261         (elf_gnu_ifunc_resolve_by_got): Update.
2262         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
2263         * dwarf-index-write.c (save_gdb_index_command): Update.
2264         * cp-support.c (add_symbol_overload_list_qualified): Update.
2265         * breakpoint.c (create_overlay_event_breakpoint)
2266         (create_longjmp_master_breakpoint)
2267         (create_std_terminate_master_breakpoint)
2268         (create_exception_master_breakpoint): Update.
2269         * blockframe.c (find_pc_partial_function): Update.
2270         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
2271         (ada_collect_symbol_completion_matches)
2272         (ada_add_global_exceptions): Update.
2273
2274 2019-01-17  Tom Tromey  <tom@tromey.com>
2275
2276         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
2277         declare VEC.
2278         (solib_target_parse_libraries): Change return type.
2279         (library_list_start_segment, library_list_start_section)
2280         (library_list_end_library, library_list_start_library); Update.
2281         (solib_target_free_library_list): Remove.
2282         (solib_target_parse_libraries): Remove cleanup.  Change return
2283         type.
2284         (solib_target_current_sos): Update.
2285
2286 2019-01-17  Tom Tromey  <tromey@bapiya>
2287
2288         * valprint.c: Replace "the the" with "the".
2289         * symtab.c: Replace "the the" with "the".
2290         * solib.c: Replace "the the" with "the".
2291         * solib-dsbt.c: Replace "the the" with "the".
2292         * linespec.c: Replace "the the" with "the".
2293         * dwarf2loc.h: Replace "the the" with "the".
2294         * amd64-windows-tdep.c: Replace "the the" with "the".
2295         * aarch64-tdep.c: Replace "the the" with "the".
2296
2297 2019-01-16  Keith Seitz  <keiths@redhat.com>
2298
2299         PR gdb/23773
2300         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
2301         <builder>: Rename to ..
2302         <m_builder>: ... this and make private.
2303         (dwarf2_cu::get_builder): New method.  Change all users of
2304         `builder' to use this method.
2305         (dwarf2_start_symtab): Move to ...
2306         (dwarf2_cu::start_symtab): ... here.  Update all callers
2307         (setup_type_unit_groups): Move to ...
2308         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
2309         callers.
2310         (dwarf2_cu::reset_builder): New method.
2311         (process_full_compunit, process_full_type_unit): Use
2312         dwarf2_cu::reset_builder.
2313         (follow_die_offset): Record the ancestor CU if it is different
2314         from the followed DIE's CU.
2315         (follow_die_sig_1): Likewise.
2316
2317 2019-01-15  Tom Tromey  <tom@tromey.com>
2318
2319         * remote.c (class remote_state) <buf>: Now a char_vector.
2320         <buf_size>: Remove.
2321         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
2322         parameter.
2323         (remote_target::getpkt_or_notif_sane_1)
2324         (remote_target::getpkt_sane)
2325         (remote_target::getpkt_or_notif_sane): Likewise.
2326         (class remote_target) <putpkt>: New overload.
2327         (remote_target::read_frame): Change type of "buf_p".  Remove
2328         sizeof_p parameter.
2329         (packet_ok): New overload.
2330         (packet_check_result): New overload.
2331         Update all uses.
2332
2333 2019-01-14  Tom Tromey  <tom@tromey.com>
2334
2335         * remote-notif.c (handle_notification, remote_notif_ack)
2336         (remote_notif_parse): Make "buf" const.
2337         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
2338         const.
2339         (remote_notif_parse, remote_notif_ack, handle_notification):
2340         Likewise.
2341         * remote.c (remote_notif_stop_parse): Make "buf" const.
2342         (remote_target::remote_parse_stop_reply): Make "buf" const.
2343         (remote_notif_stop_ack): Make "buf" const.
2344
2345 2019-01-14  Tom Tromey  <tom@tromey.com>
2346
2347         * remote.c (remote_console_output): Make parameter const.
2348
2349 2019-01-14  Tom Tromey  <tom@tromey.com>
2350
2351         * target-debug.h (target_debug_print_signals): Constify.
2352         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
2353         * procfs.c (procfs_target::pass_signals): Update.
2354         * linux-nat.c (linux_nat_target::pass_signals): Update.
2355         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
2356         * target-delegates.c: Rebuild.
2357         * remote.c (remote_target::program_signals): Update.
2358         (remote_target::pass_signals): Update.
2359         * target.c (target_pass_signals): Constify argument.
2360         (target_program_signals): Likewise.
2361         * target.h (struct target_ops) <pass_signals, program_signals>:
2362         Constify argument.
2363         (target_pass_signals, target_program_signals): Constify argument.
2364
2365 2019-01-14  Tom Tromey  <tom@tromey.com>
2366
2367         PR tui/28819:
2368         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
2369
2370 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2371
2372         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
2373         field.
2374         * rs6000-tdep.c: Include reggroups.h.
2375         (IS_V_ALIAS_PSEUDOREG): Define.
2376         (rs6000_register_name): Return names for the "vX" aliases.
2377         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
2378         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
2379         aliases.  Call default_register_reggroup_p for all other
2380         pseudo-registers.
2381         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
2382         New functions.
2383         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
2384         Handle "vX" aliases.
2385         (v_alias_pseudo_register_collect): New function.
2386         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
2387         (rs6000_gdbarch_init): Initialize "vX" aliases as
2388         pseudo-registers.  Restore registration of
2389         rs6000_pseudo_register_reggroup_p with
2390         set_tdesc_pseudo_register_reggroup_p.
2391
2392 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
2393
2394         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
2395         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
2396         set_gdbarch_num_pseudo_regs.
2397
2398 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2399
2400         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
2401         Remove arg prefixname, add do_set and do_show.
2402         Add member functions set_list and show_list.
2403         * cli/cli-style.c (class cli_style_option): Update accordingly.
2404         (style_set_list): Move to file scope.
2405         (style_show_list): Likewise.
2406         (set_style): Call help_list.
2407         (show_style): Call cmd_show_list.
2408         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
2409         Update to use the new macro.
2410
2411 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
2412
2413         * ada-lang.c (_initialize_ada_language): Expand the help text
2414         for the "catch exception" command.
2415
2416 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2417
2418         * symtab.c (matching_obj_sections): Initialize obj,
2419         declare it closer to its usage.
2420
2421 2019-01-10  Tom Tromey  <tom@tromey.com>
2422
2423         * thread-iter.h (inf_threads_iterator): Use next_iterator.
2424         (basic_inf_threads_range): Remove.
2425         (inf_threads_range, inf_non_exited_threads_range)
2426         (safe_inf_threads_range): Use next_adapter.
2427
2428 2019-01-10  Keith Seitz  <keiths@redhat.com>
2429
2430         PR gdb/23712
2431         PR symtab/23010
2432         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
2433         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
2434
2435 2019-01-10  Keith Seitz  <keiths@redhat.com>
2436
2437         PR gdb/23712
2438         PR symtab/23010
2439         * dictionary.c (pending_to_vector): Remove.
2440         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2441         Remove _1 suffix, replacing functions of the same name.  Update
2442         all callers.
2443         (dict_create_hashed, dict_create_hashed_expandable)
2444         (dict_create_linear, dict_create_linear_expandable, dict_free)
2445         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
2446         Make functions static.
2447
2448 2019-01-10  Keith Seitz  <keiths@redhat.com>
2449
2450         PR gdb/23712
2451         PR symtab/23010
2452         * dictionary.h (struct dictionary): Replace declaration with
2453         multidictionary.
2454         (dict_create_hashed, dict_create_hashed_expandable)
2455         (dict_create_linear, dict_create_linear_expandable)
2456         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
2457         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
2458         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
2459         taking multidictionary argument.
2460         [ALL_DICT_SYMBOLS]: Update for multidictionary.
2461         * block.h (struct block) <dict>: Change to multidictionary
2462         and rename `multidict'.
2463         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
2464         symmisc.c: Update all dictionary references to multidictionary.
2465
2466 2019-01-10  Keith Seitz  <keiths@redhat.com>
2467
2468         PR gdb/23712
2469         PR symtab/23010
2470         * dictionary.c: Include unordered_map.
2471         (pending_to_vector): New function.
2472         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2473         Rewrite the non-"_1" functions to take vector instead
2474         of linked list.
2475         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
2476         "new" _1 versions of the same name.
2477         (multidictionary): Define.
2478         (std::hash<enum language): New definition.
2479         (collate_pending_symbols_by_language, mdict_create_hashed)
2480         (mdict_create_hashed_expandable, mdict_create_linear)
2481         (mdict_create_linear_expandable, mdict_free)
2482         (find_language_dictionary, create_new_language_dictionary)
2483         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
2484         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
2485         (mdict_size, mdict_empty): New functions.
2486         * dictionary.h (mdict_iterator): Define.
2487
2488 2019-01-10  Pedro Alves  <palves@redhat.com>
2489
2490         * breakpoint.c (read_uploaded_action)
2491         (create_tracepoint_from_upload): Adjust to use
2492         gdb::unique_xmalloc_ptr.
2493         * ctf.c (ctf_write_uploaded_tp):
2494         (SET_ARRAY_FIELD): Use emplace_back.
2495         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
2496         * tracefile-tfile.c (tfile_write_uploaded_tp):
2497         * tracepoint.c (parse_tracepoint_definition): Adjust to use
2498         gdb::unique_xmalloc_ptr.
2499         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
2500         at_string, cond_string, cmd_strings>: Replace char pointers
2501         with gdb::unique_xmalloc_ptr.
2502
2503 2019-01-10  Pedro Alves  <palves@redhat.com>
2504
2505         * solib-target.c (library_list_start_library): Don't xstrdup name.
2506
2507 2019-01-10  Pedro Alves  <palves@redhat.com>
2508
2509         * mdebugread.c (parse_partial_symbols): Use
2510         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
2511
2512 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2513
2514         * linux-fork.c (scoped_switch_fork_info)
2515         <~scoped_switch_fork_info>: Fix incorrect variable name.
2516
2517 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2518
2519         * linux-fork.c (scoped_switch_fork_info)
2520         <scoped_switch_fork_info>: Make explicit.
2521         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
2522
2523 2019-01-10  Tom Tromey  <tom@tromey.com>
2524
2525         * objfiles.h (objfile::reset_psymtabs): Update.
2526         * objfiles.c (objfile::objfile): Update.
2527         * psymtab.h (psymtab_storage::obstack): Update.
2528         (psymtab_storage::m_obstack): Use gdb::optional.
2529         (class psymtab_storage): Update comment.  Remove objfile
2530         parameter.
2531         * psymtab.c (psymtab_storage::psymtab_storage): Update.
2532
2533 2019-01-10  Tom Tromey  <tom@tromey.com>
2534
2535         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
2536         <free_psymtabs>: Now private.
2537         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
2538         (allocate_psymtab): Use new method.
2539
2540 2019-01-10  Tom Tromey  <tom@tromey.com>
2541
2542         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
2543         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
2544         * mdebugread.c (parse_partial_symbols): Use
2545         allocate_dependencies.
2546         * dwarf2read.c (dwarf2_create_include_psymtab): Use
2547         allocate_dependencies.
2548         (process_psymtab_comp_unit_reader)
2549         (build_type_psymtab_dependencies): Likewise.
2550         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
2551
2552 2019-01-10  Tom Tromey  <tom@tromey.com>
2553
2554         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
2555         PSYMBOL_SET_LANGUAGE.
2556         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
2557
2558 2019-01-10  Tom Tromey  <tom@tromey.com>
2559
2560         * psymtab.h (psymtab_storage::obstack): New method.
2561         <m_obstack>: Rename from obstack; now private.
2562         * psymtab.c (psymtab_storage): Update.
2563         * dwarf2read.c (create_addrmap_from_index)
2564         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
2565         Update.
2566
2567 2019-01-10  Tom Tromey  <tom@tromey.com>
2568
2569         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
2570         * objfiles.h (objfile::reset_psymtabs): New method.
2571
2572 2019-01-10  Tom Tromey  <tom@tromey.com>
2573
2574         * symmisc.c (print_symbol_bcache_statistics): Update.
2575         (print_objfile_statistics): Update.
2576         * symfile.c (reread_symbols): Update.
2577         * psymtab.h (class psymtab_storage): New.
2578         * psymtab.c (psymtab_storage): New constructor.
2579         (~psymtab_storage): New destructor.
2580         (require_partial_symbols): Update.
2581         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
2582         (find_pc_sect_psymtab, find_pc_sect_psymbol)
2583         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
2584         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
2585         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
2586         (start_psymtab_common, end_psymtab_common)
2587         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
2588         (allocate_psymtab): Update.
2589         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
2590         Update.
2591         (dump_psymtab_addrmap, maintenance_print_psymbols)
2592         (maintenance_check_psymtabs): Update.
2593         (class objfile_psymtabs): Move to objfiles.h.
2594         * psympriv.h (discard_psymtab): Now inline.
2595         (psymtab_discarder::psymtab_discarder): Update.
2596         (psymtab_discarder::~psymtab_discarder): Update.
2597         (ALL_OBJFILE_PSYMTABS): Rewrite.
2598         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
2599         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
2600         Remove fields.
2601         <partial_symtabs>: New field.
2602         (class objfile_psymtabs): Move from psymtab.h.  Update.
2603         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
2604         psymbol_cache.
2605         (objfile::~objfile): Don't destroy psymbol_cache.
2606         * mdebugread.c (parse_partial_symbols): Update.
2607         * dwarf2read.c (create_addrmap_from_index)
2608         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
2609         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
2610         (add_partial_subprogram, dwarf2_ranges_read): Update.
2611         * dwarf-index-write.c (write_address_map)
2612         (write_one_signatured_type, recursively_write_psymbols)
2613         (class debug_names, class debug_names, write_psymtabs_to_index):
2614         Update.
2615
2616 2019-01-10  Tom Tromey  <tom@tromey.com>
2617
2618         * symtab.h (SYMBOL_SET_NAMES): Update.
2619         (symbol_set_names): Update.
2620         (MSYMBOL_SET_NAMES): Update.
2621         * symtab.c (symbol_set_names): Change argument to be an
2622         objfile_per_bfd_storage.
2623         * psymtab.c (add_psymbol_to_bcache): Update.
2624         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
2625
2626 2019-01-10  Tom Tromey  <tom@tromey.com>
2627
2628         * symtab.c (create_demangled_names_hash): Change argument to be an
2629         objfile_per_bfd_storage.
2630         (symbol_set_names): Update.
2631
2632 2019-01-10  Tom Tromey  <tom@tromey.com>
2633
2634         * xcoffread.c (xcoff_initial_scan): Unconditionally call
2635         init_psymbol_list.
2636         * psymtab.c (init_psymbol_list): Do nothing if already called.
2637         * psympriv.h (init_psymbol_list): Add comment.
2638         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
2639         init_psymbol_list.
2640         * dbxread.c (dbx_symfile_read): Unconditionally call
2641         init_psymbol_list.
2642
2643 2019-01-10  Tom Tromey  <tom@tromey.com>
2644
2645         * xcoffread.c (scan_xcoff_symtab): Update.
2646         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
2647         "where".
2648         * mdebugread.c (parse_partial_symbols)
2649         (handle_psymbol_enumerators): Update.
2650         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
2651         * dbxread.c (read_dbx_symtab): Update.
2652         * psympriv.h (psymbol_placement): New enum.
2653         (add_psymbol_to_list): Update.
2654
2655 2019-01-10  Tom Tromey  <tom@tromey.com>
2656
2657         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
2658         static_psymbols parameters.
2659         (scan_xcoff_symtab): Update.
2660         * psymtab.c (start_psymtab_common): Remove global_psymbols and
2661         static_psymbols parameters.
2662         * psympriv.h (start_psymtab_common): Update.
2663         * mdebugread.c (parse_partial_symbols): Update.
2664         * dwarf2read.c (create_partial_symtab): Update.
2665         * dbxread.c (read_dbx_symtab): Update.
2666         (start_psymtab): Remove global_psymbols and static_psymbols
2667         parameters.
2668
2669 2019-01-10  Tom Tromey  <tom@tromey.com>
2670
2671         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
2672         * psymtab.c (allocate_psymtab): Add comment.
2673         * psympriv.h (allocate_psymtab): Add comment.
2674         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
2675         initializations.
2676         * dbxread.c (dbx_end_psymtab): Remove some initializations.
2677
2678 2019-01-10  Tom Tromey  <tom@tromey.com>
2679
2680         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2681         Don't declare.
2682         * mipsread.c: Include mdebugread.h.
2683         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2684         Declare.
2685         * elfread.c: Include mdebugread.h.
2686
2687 2019-01-09  Tom Tromey  <tom@tromey.com>
2688
2689         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
2690         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
2691         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
2692         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
2693         (psym_lookup_symbol, psym_find_last_source_symtab)
2694         (psym_forget_cached_source_info, psym_print_stats)
2695         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
2696         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
2697         (psym_map_matching_symbols, psym_expand_symtabs_matching)
2698         (psym_find_compunit_symtab_by_address)
2699         (maintenance_print_psymbols, maintenance_info_psymtabs)
2700         (maintenance_check_psymtabs): Use ranged for.
2701         * psymtab.h (class objfile_psymtabs): New.
2702         (require_partial_symbols): Return objfile_psymtabs.
2703         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
2704
2705 2019-01-09  Tom Tromey  <tom@tromey.com>
2706
2707         * symfile.c (overlay_invalidate_all, find_pc_overlay)
2708         (find_pc_mapped_section, list_overlays_command)
2709         (map_overlay_command, unmap_overlay_command)
2710         (simple_overlay_update): Use all_objfiles.
2711         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
2712         * printcmd.c (info_symbol_command): Use all_objfiles.
2713         * objfiles.h (ALL_OBJSECTIONS): Remove.
2714         * maint.c (maintenance_translate_address): Use all_objfiles.
2715         * gcore.c (gcore_create_callback): Use all_objfiles.
2716         (objfile_find_memory_regions): Likewise.
2717
2718 2019-01-09  Tom Tromey  <tom@tromey.com>
2719
2720         * symtab.c (find_line_symtab, info_sources_command)
2721         (make_source_files_completion_list): Use objfile_compunits.
2722         * source.c (select_source_symtab): Use objfile_compunits.
2723         * objfiles.h (struct objfile): Update comment.
2724         (ALL_OBJFILES): Remove.
2725         (ALL_FILETABS): Remove.
2726         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
2727         objfile_compunits.
2728
2729 2019-01-09  Tom Tromey  <tom@tromey.com>
2730
2731         * symmisc.c (print_objfile_statistics, dump_objfile)
2732         (maintenance_print_symbols): Use compunit_filetabs.
2733         * source.c (forget_cached_source_info_for_objfile): Use
2734         compunit_filetabs.
2735         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
2736         (ALL_FILETABS): Use compunit_filetabs.
2737         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
2738         * coffread.c (coff_symtab_read): Use compunit_filetabs.
2739
2740 2019-01-09  Tom Tromey  <tom@tromey.com>
2741
2742         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
2743         (compunit_filetabs): New.
2744         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
2745         compunit_filetabs.
2746         (info_sources_command, make_source_files_completion_list): Remove
2747         declaration.
2748         * symmisc.c (print_objfile_statistics, dump_objfile)
2749         (maintenance_print_symbols): Remove declaration.
2750         (maintenance_info_symtabs): Use compunit_filetabs.
2751         (maintenance_info_line_tables): Likewise.
2752         * source.c (select_source_symtab): Change local variable name.
2753         (forget_cached_source_info_for_objfile): Remove declaration.
2754         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
2755         * objfiles.c (objfile_relocate1): Remove declaration.
2756         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2757         declaration.
2758         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
2759         * coffread.c (coff_symtab_read): Remove declaration.
2760         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2761         compunit_filetabs.
2762
2763 2019-01-09  Tom Tromey  <tom@tromey.com>
2764
2765         * symtab.c (lookup_objfile_from_block)
2766         (find_pc_sect_compunit_symtab, search_symbols)
2767         (default_collect_symbol_completion_matches_break_on): Use
2768         objfile_compunits.
2769         * objfiles.h (ALL_COMPUNITS): Remove.
2770         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
2771         * cp-support.c (add_symbol_overload_list_qualified): Use
2772         objfile_compunits.
2773         * ada-lang.c (ada_collect_symbol_completion_matches)
2774         (ada_add_global_exceptions): Use objfile_compunits.
2775
2776 2019-01-09  Tom Tromey  <tom@tromey.com>
2777
2778         * source.c (select_source_symtab)
2779         (forget_cached_source_info_for_objfile): Remove declaration.
2780         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2781         declaration.
2782         * maint.c (count_symtabs_and_blocks): Remove declaration.
2783         * cp-support.c (add_symbol_overload_list_qualified): Remove
2784         declaration.
2785         * coffread.c (coff_symtab_read): Remove declaration.
2786         * symtab.c (lookup_symbol_in_objfile_symtabs)
2787         (basic_lookup_transparent_type_1): Use objfile_compunits.
2788         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
2789         (info_sources_command, search_symbols)
2790         (default_collect_symbol_completion_matches_break_on)
2791         (make_source_files_completion_list): Remove declaration.
2792         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
2793         (ada_collect_symbol_completion_matches)
2794         (ada_add_global_exceptions): Remove declaration.
2795         * linespec.c (iterate_over_all_matching_symtabs): Use
2796         objfile_compunits.
2797         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
2798         (class objfile_compunits): New.
2799         (ALL_COMPUNITS): Use objfile_compunits.
2800         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
2801         (maintenance_check_symtabs, maintenance_info_line_tables): Use
2802         objfile_compunits.
2803         * objfiles.c (objfile_relocate1): Use objfile_compunits.
2804
2805 2019-01-09  Tom Tromey  <tom@tromey.com>
2806
2807         * symtab.c (search_symbols)
2808         (default_collect_symbol_completion_matches_break_on): Use
2809         objfile_msymbols.
2810         * ada-lang.c (ada_lookup_simple_minsym)
2811         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
2812         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
2813         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
2814         objfile_msymbols.
2815         * coffread.c (coff_symfile_read): Use objfile_msymbols.
2816         * symmisc.c (dump_msymbols): Use objfile_msymbols.
2817         * objc-lang.c (find_methods): Use objfile_msymbols.
2818         (info_selectors_command, info_classes_command): Likewise.
2819         * stabsread.c (scan_file_globals): Use objfile_msymbols.
2820         * objfiles.h (class objfile_msymbols): New.
2821         (ALL_OBJFILE_MSYMBOLS): Remove.
2822         (ALL_MSYMBOLS): Remove.
2823
2824 2019-01-09  Tom Tromey  <tom@tromey.com>
2825
2826         * common/next-iterator.h (next_adapter): Add Iterator template
2827         parameter.
2828         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
2829         (class all_objfiles_safe): New.
2830         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
2831         * objfiles.c (put_objfile_before): Update comment.
2832         (add_separate_debug_objfile): Likewise.
2833         (free_all_objfiles): Use all_objfiles_safe.
2834         (objfile_purge_solibs): Likewise.
2835
2836 2019-01-09  Tom Tromey  <tom@tromey.com>
2837
2838         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2839         (expand_symtab_containing_pc, lookup_static_symbol)
2840         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
2841         (find_symbol_at_address, find_line_symtab, find_main_name): Use
2842         all_objfiles.
2843         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
2844         * breakpoint.c (create_overlay_event_breakpoint)
2845         (create_longjmp_master_breakpoint)
2846         (create_std_terminate_master_breakpoint)
2847         (create_exception_master_breakpoint): Use all_objfiles.
2848         * linux-thread-db.c (try_thread_db_load_from_pdir)
2849         (has_libpthread): Use all_objfiles.
2850         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
2851         * linespec.c (iterate_over_all_matching_symtabs)
2852         (search_minsyms_for_name): Use all_objfiles.
2853         * maint.c (maintenance_info_sections): Use all_objfiles.
2854         * main.c (captured_main_1): Use all_objfiles.
2855         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
2856         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
2857         * guile/scm-pretty-print.c
2858         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
2859         * solib-spu.c (append_ocl_sos): Use all_objfiles.
2860         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2861         (maintenance_print_msymbols): Use all_objfiles.
2862         * source.c (select_source_symtab): Use all_objfiles.
2863         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2864         * symfile.c (remove_symbol_file_command)
2865         (expand_symtabs_matching, map_symbol_filenames): Use
2866         all_objfiles.
2867         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2868         all_objfiles.
2869         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2870         * objc-lang.c (find_methods): Use all_objfiles.
2871         * objfiles.c (have_partial_symbols, have_full_symbols)
2872         (have_minimal_symbols, qsort_cmp)
2873         (default_iterate_over_objfiles_in_search_order): Use
2874         all_objfiles.
2875         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2876         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2877         (maintenance_check_psymtabs): Use all_objfiles.
2878         (ALL_PSYMTABS): Remove.
2879         * compile/compile-object-run.c (do_module_cleanup): Use
2880         all_objfiles.
2881         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2882         * cp-support.c (add_symbol_overload_list_qualified): Use
2883         all_objfiles.
2884         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2885         Use all_objfiles.
2886         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2887         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2888         all_objfiles.
2889         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2890         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2891         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2892         Uses all_objfiles.
2893         * solib.c (solib_read_symbols): Use all_objfiles
2894
2895 2019-01-09  Tom Tromey  <tom@tromey.com>
2896
2897         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2898         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2899         all_objfiles.
2900         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2901         * symmisc.c (print_symbol_bcache_statistics)
2902         (print_objfile_statistics, maintenance_print_objfiles)
2903         (maintenance_info_symtabs, maintenance_check_symtabs)
2904         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2905         all_objfiles.
2906         * source.c (forget_cached_source_info): Use all_objfiles.
2907         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2908         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2909         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2910         * objfiles.c (update_section_map): Use all_objfiles.
2911         (shared_objfile_contains_address_p): Likewise.
2912         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2913         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2914
2915 2019-01-09  Tom Tromey  <tom@tromey.com>
2916
2917         * common/next-iterator.h: New file.
2918         * objfiles.h (class all_objfiles): New.
2919         (struct objfile_iterator): New.
2920
2921 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2922
2923         * NEWS: Move the description of the changed "frame", "select-frame",
2924          and "info frame" commands to the Changed commands section.
2925
2926 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2927
2928         * gdbtypes.c (check_stub_method_group): Remove handling of old
2929         mangling schemes.
2930         * linespec.c (find_methods): Likewise.
2931         * stabsread.c (read_member_functions): Likewise.
2932         * valops.c (search_struct_method): Likewise.
2933         (value_struct_elt_for_reference): Likewise.
2934         * NEWS: Mention this change.
2935
2936 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2937
2938         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2939         print_source_lines.
2940         * source.c (print_source_lines_base): Update line number check.
2941         (print_source_lines): New function.
2942         (source_lines_range::source_lines_range): New function.
2943         * source.h (class source_lines_range): New class.
2944         (print_source_lines): New declaration.
2945
2946 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2947
2948         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2949
2950 2019-01-08  Tom Tromey  <tom@tromey.com>
2951             Simon Marchi  <simon.marchi@ericsson.com>
2952
2953         PR gdb/24060
2954         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2955         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2956         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2957         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2958         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2959         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2960
2961 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2962
2963         * source.c (select_source_symtab): Move header comment to
2964         declaration in source.h.
2965         (forget_cached_source_info_for_objfile): Likewise.
2966         (forget_cached_source_info): Likewise.
2967         (identify_source_line): Likewise.
2968         * source.h (identify_source_line): Move declaration from symtab.h
2969         and add comment from source.c
2970         (print_source_lines): Likewise.
2971         (forget_cached_source_info_for_objfile): Likewise.
2972         (forget_cached_source_info): Likewise.
2973         (select_source_symtab): Likewise.
2974         (enum print_source_lines_flag): Move definition from symtab.h.
2975         * symtab.h (identify_source_line): Move declaration to source.h.
2976         (print_source_lines): Likewise.
2977         (forget_cached_source_info_for_objfile): Likewise.
2978         (forget_cached_source_info): Likewise.
2979         (select_source_symtab): Likewise.
2980         (enum print_source_lines_flag): Move definition to source.h.
2981         * tui/tui-hooks.c: Add 'source.h' include.
2982
2983 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2984
2985         * source.c (print_source_lines_base): Handle requests to print
2986         reverse line number sequences, and guard against empty lines
2987         string.
2988
2989 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2990
2991         * source.c (print_source_lines_base): Fix skip of '\r' if next
2992         character is '\n'.
2993
2994 2019-01-06  Tom Tromey  <tom@tromey.com>
2995
2996         * c-exp.y (struct c_parse_state) <macro_original_text,
2997         expansion_obstack>: New member.
2998         (macro_original_text, expansion_obstack): Remove globals.
2999         (scan_macro_expansion, scanning_macro_expansion)
3000         (finished_macro_expansion): Update.
3001         (scan_macro_cleanup): Remove.
3002         (yylex, c_parse): Update.
3003
3004 2019-01-06  Tom Tromey  <tom@tromey.com>
3005
3006         * c-exp.y (struct c_parse_state) <strings>: New member.
3007         (operator_stoken): Update.
3008
3009 2019-01-06  Tom Tromey  <tom@tromey.com>
3010
3011         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
3012         (union type_stack_elt) <typelist_val>: Now a pointer to
3013         std::vector.
3014         (type_stack_cleanup): Don't declare.
3015         (push_typelist): Update.
3016         * parse.c (pop_typelist): Return a std::vector.
3017         (push_typelist): Take a std::vector.
3018         (follow_types): Update.  Do not free args.
3019         (type_stack_cleanup): Remove.
3020         * c-exp.y (struct c_parse_state): New.
3021         (cpstate): New global.
3022         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
3023         (nonempty_typelist): Update.
3024         (func_mod): Create a new vector.
3025         (c_parse): Create a c_parse_state.
3026         (check_parameter_typelist): Do not delete params.
3027         (function_method): Update.  Do not delete type_list.
3028
3029 2019-01-06  Tom Tromey  <tom@tromey.com>
3030
3031         PR gdb/28155:
3032         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
3033         check_typedef.
3034         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
3035         (print_return_value): Likewise.
3036
3037 2019-01-05  Tom Tromey  <tom@tromey.com>
3038
3039         * contrib/cleanup_check.py: Remove.
3040         * contrib/gcc-with-excheck: Remove.
3041         * contrib/exsummary.py: Remove.
3042         * contrib/excheck.py: Remove.
3043
3044 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
3045
3046         * thread.c (delete_thread_1): Add gdb_assert that THR is not
3047         NULL. Initialize tpprev to NULL instead of assigning it
3048         to NULL on the next statement.
3049         * windows-nat.c (windows_delete_thread): Remove check for
3050         main_thread_id before printing thread exit notifications.
3051         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
3052         Remove thread ID check against main_thread_id.
3053         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
3054         windows_delete_thread.
3055         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
3056
3057 2019-01-04  Tom Tromey  <tom@tromey.com>
3058
3059         * compile/compile.c (_initialize_compile): Use upper case for
3060         metasyntactic variables.
3061         * symmisc.c (_initialize_symmisc): Use upper case for
3062         metasyntactic variables.
3063         * psymtab.c (_initialize_psymtab): Use upper case for
3064         metasyntactic variables.
3065         * demangle.c (demangle_command): Use upper case for metasyntactic
3066         variables.
3067         (_initialize_demangler): Likewise.
3068         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
3069         variables.
3070
3071 2019-01-03  Tom Tromey  <tom@tromey.com>
3072
3073         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
3074
3075 2019-01-03  Tom Tromey  <tom@tromey.com>
3076
3077         * python/py-symtab.c (salpy_str): Update.
3078         (struct salpy_sal_object) <symtab>: Now a PyObject.
3079         (salpy_dealloc): Update.
3080         (del_objfile_sal): Use gdbpy_ref.
3081
3082 2019-01-03  Tom Tromey  <tom@tromey.com>
3083
3084         * python/py-type.c (convert_field): Use new_reference.  Return
3085         gdbpy_ref.
3086         (make_fielditem): Return gdbpy_ref.
3087         (typy_fields): Update.
3088         (typy_getitem): Update.
3089         (field_name): Return gdbpy_ref.  Use new_reference.
3090         (typy_iterator_iternext): Update.
3091
3092 2019-01-03  Tom Tromey  <tom@tromey.com>
3093
3094         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
3095
3096 2019-01-03  Tom Tromey  <tom@tromey.com>
3097
3098         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
3099         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
3100         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
3101         (pspy_set_frame_filters, pspy_set_frame_unwinders)
3102         (pspy_set_type_printers): Likewise.
3103         * python/py-function.c (fnpy_init): Use gdbpy_ref.
3104         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
3105         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
3106         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
3107         (objfpy_set_type_printers): Likewise.
3108
3109 2019-01-03  Tom Tromey  <tom@tromey.com>
3110
3111         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
3112         (gdbpy_print_stack): Use gdbpy_err_fetch.
3113         * python/python-internal.h (class gdbpy_err_fetch): New class.
3114         (class gdbpy_enter) <m_error_type, m_error_value,
3115         m_error_traceback>: Remove.
3116         <m_error>: New member.
3117         (gdbpy_exception_to_string): Don't declare.
3118         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
3119         * python/py-value.c (convert_value_from_python): Use
3120         gdbpy_err_fetch.
3121         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
3122         gdbpy_exception_to_string.
3123         (gdbpy_handle_exception): Use gdbpy_err_fetch.
3124         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3125         gdbpy_err_fetch.
3126
3127 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3128
3129         * linux-nat.c (delete_lwp_cleanup): Delete.
3130         (struct lwp_deleter): New struct.
3131         (lwp_info_up): New typedef.
3132         (linux_nat_target::follow_fork): Delete cleanup, and make use of
3133         lwp_info_up.
3134
3135 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3136
3137         * linux-fork.c (class scoped_switch_fork_info): New class.
3138         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
3139
3140 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3141
3142         * valops.c (find_overload_match): Remove use of null_cleanup, and
3143         calls to do_cleanups.
3144
3145 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3146
3147         * compile/compile-cplus-types.c
3148         (compile_cplus_instance::decl_name): Handle changes to
3149         cp_func_name.
3150         * cp-support.c (cp_func_name): Update header comment, update
3151         return type.
3152         * cp-support.h (cp_func_name): Update return type in declaration.
3153         * valops.c (find_overload_match): Move temp_func local to top
3154         level of function and change its type.  Use temp_func to hold and
3155         delete temporary string obtained from cp_func_name.
3156
3157 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3158
3159         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
3160         gdb::char_vector, remove cleanup, and update uses of `msg`.
3161
3162 2019-01-03  Jim Wilson  <jimw@sifive.com>
3163
3164         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
3165
3166 2019-01-02  Tom Tromey  <tom@tromey.com>
3167
3168         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
3169         (tdesc_parse_xml): Remove cleanups.
3170         * target-descriptions.h (make_cleanup_free_target_description):
3171         Don't declare.
3172         (target_desc_deleter): New struct.
3173         (target_desc_up): New typedef.
3174         * target-descriptions.c (target_desc_deleter::operator()): Rename
3175         from free_target_description.
3176         (make_cleanup_free_target_description): Remove.
3177
3178 2019-01-02  Tom Tromey  <tom@tromey.com>
3179
3180         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
3181         constructor, destructor.
3182         (linespec_parser): Remove typedef.
3183         (~linespec_parser): Rename from linespec_parser_delete.
3184         (linespec_lex_to_end, linespec_complete_label)
3185         (linespec_complete): Update.
3186         (decode_line_full): Remove cleanups.
3187         (decode_line_1): Update.
3188
3189 2019-01-02  Tom Tromey  <tom@tromey.com>
3190
3191         * python/python-internal.h (inferior_to_inferior_object): Change
3192         return type.
3193         * python/py-exitedevent.c (create_exited_event_object): Update.
3194         * python/py-inferior.c (inferior_to_inferior_object): Return
3195         gdbpy_ref.
3196         (python_new_inferior, python_inferior_deleted)
3197         (thread_to_thread_object, delete_thread_object)
3198         (build_inferior_list, gdbpy_selected_inferior): Update.
3199         * python/py-infthread.c (create_thread_object): Update.  Also fail
3200         if inferior_to_inferior_object fails.
3201
3202 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
3203
3204         * inferior.h (class inferior) <displaced_step_state>: New field.
3205         * infrun.h (struct displaced_step_state): Move here from
3206         infrun.c.  Initialize fields, add constructor.
3207         <inf>: Remove field.
3208         <reset>: New method.
3209         * infrun.c (struct displaced_step_inferior_state): Move to
3210         infrun.h.
3211         (displaced_step_inferior_states): Remove.
3212         (get_displaced_stepping_state): Adust.
3213         (displaced_step_in_progress_any_inferior): Adjust.
3214         (displaced_step_in_progress_thread): Adjust.
3215         (displaced_step_in_progress): Adjust.
3216         (add_displaced_stepping_state): Remove.
3217         (get_displaced_step_closure_by_addr): Adjust.
3218         (remove_displaced_stepping_state): Remove.
3219         (infrun_inferior_exit): Call displaced_step_state.reset.
3220         (use_displaced_stepping): Don't check for NULL.
3221         (displaced_step_prepare_throw): Call
3222         get_displaced_stepping_state.
3223         (displaced_step_fixup): Don't check for NULL.
3224         (prepare_for_detach): Don't check for NULL.
3225
3226 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3227
3228         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
3229          in case of call that did not complete.
3230
3231 2019-01-02  Andrey Utkin  <autkin@undo.io>
3232
3233         * symfile.c (find_separate_debug_file): Fix search of debug files for
3234         remote debuggee.
3235
3236 2019-01-02  Tom Tromey  <tom@tromey.com>
3237
3238         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
3239         indentation.
3240         * python/py-frame.c (frapy_older): Remove cast.
3241         (frapy_newer): Likewise.
3242         * python/py-breakpoint.c (local_setattro): Remove cast.
3243         * python/py-arch.c (archpy_name): Remove local variable.
3244         * python/py-type.c (gdbpy_lookup_type): Remove cast.
3245
3246 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
3247
3248         * unittests/basic_string_view/element_access/char/empty.cc:
3249         Fix year range in copyright header.
3250
3251 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3252
3253         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
3254         Delete.
3255         <operator==>: Update with for removed field.
3256         <hash>: Likewise.
3257         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
3258         <isa_features>: ...this.
3259         <abi_features>: New field.
3260         (riscv_isa_flen): Update comment.
3261         (riscv_abi_xlen): New declaration.
3262         (riscv_abi_flen): New declaration.
3263         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
3264         isa_features.
3265         (riscv_abi_xlen): New function.
3266         (riscv_isa_flen): Update to get answer from isa_features.
3267         (riscv_abi_flen): New function.
3268         (riscv_has_fp_abi): Update to get answer from abi_features.
3269         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
3270         xlen and flen.
3271         (riscv_call_info) <xlen, flen>: Update comment.
3272         (riscv_call_arg_struct): Remove invalid assertions
3273         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
3274         is removed.
3275         (riscv_gdbarch_init): Gather isa features and abi features
3276         separately, ensure both match on the gdbarch when reusing an old
3277         gdbarch.  Relax an error check to allow 32-bit abi float to run on
3278         a target with 64-bit float hardware.
3279
3280 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3281
3282         * source.c (search_command_helper): Stop reverse search
3283         when line 1 has been searched.
3284
3285 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3286
3287         * record-full.c (record_full_base_target::close): Rewrite
3288         record_full_core_buf_list free logic.
3289
3290 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3291
3292         * break-catch-syscall.c (print_one_catch_syscall): xfree
3293         the last text.
3294
3295 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3296
3297         * top.c (print_gdb_version): Update Copyright year in version
3298         message.
3299
3300 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3301
3302         Update copyright year range in all GDB files.
3303
3304 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
3305
3306         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
3307
3308 For older changes see ChangeLog-2018.
3309 \f
3310 Local Variables:
3311 mode: change-log
3312 left-margin: 8
3313 fill-column: 74
3314 version-control: never
3315 coding: utf-8
3316 End:
3317