gdb/ChangeLog

   1 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
   2             Tom Tromey  <tromey@adacore.com>
   3
   4         PR rust/24414:
   5         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
   6         (rust_lex_int_test): Change "value" to be LONGEST.
   7         (rust_lex_tests): Add test for long integer literal.
   8
   9 2019-04-09  Tom Tromey  <tromey@adacore.com>
  10
  11         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
  12         to bool.
  13         (extended_remote_target::attach): Update.
  14         (remote_target::remote_notice_new_inferior): Update.
  15         (remote_target::add_current_inferior_and_thread): Update.
  16         * inferior.c (exit_inferior_1): Use "false".
  17         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
  18
  19 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
  20
  21         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
  22         the "start" command.
  23
  24 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
  25
  26         * python/py-inferior.c (infpy_thread_from_thread_handle):
  27         Adjust comments to reflect renaming of thread_from_thread_handle
  28         to thread_from_handle.  Adjust keywords.  Fix type error message.
  29         (inferior_object_methods): Add thread_from_handle.  Retain
  30         thread_from_thread_handle, but mark it as deprecated.
  31
  32 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
  33
  34         * gdbthread.h (find_thread_by_handle): Revise declaration.
  35         * thread.c (find_thread_by_handle): Likewise.  Adjust
  36         implementation too.
  37         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
  38         support for buffer objects as handles.
  39
  40 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
  41
  42         * python/py-infthread.c (thpy_thread_handle): New function.
  43         (thread_object_methods): Register thpy_thread_handle.
  44
  45 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
  46
  47         * gdbthread.h (thread_to_thread_handle): Declare.
  48         * thread.c (gdbtypes.h): Include.
  49         (thread_to_thread_handle): New function.
  50
  51         * target.h (struct target_ops): Add thread_info_to_thread_handle.
  52         (target_thread_info_to_thread_handle): Declare.
  53         * target.c (target_thread_info_to_thread_handle): New function.
  54         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
  55         * target-delegates.c: Regenerate.
  56
  57         * linux-thread-db.c (class thread_db_target): Add method
  58         thread_info_to_thread_handle.
  59         (thread_db_target::thread_info_to_thread_handle): Define.
  60         * remote.c (class remote_target): Add new method
  61         thread_info_to_thread_handle.
  62         (remote_target::thread_info_to_thread_handle): Define.
  63
  64 2019-04-08  Pedro Alves  <palves@redhat.com>
  65
  66         * common/common-exceptions.c (throw_exception): Don't create
  67         named object to throw; throw directly.
  68         (throw_it): Likewise.  Don't initialize gdb_exception::message
  69         here, with new; pass FMT and AP to the ctor instead.
  70         * common/common-exceptions.h: Include <string>.
  71         (gdb_exception::gdb_exception(enum return_reason, enum errors,
  72         const char *, va_list)): New ctor.  Use std::make_shared.
  73         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
  74         errors)): Delete.
  75         (gdb_exception_error::gdb_exception_error(enum errors, const char
  76         *, va_list)): New.
  77         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
  78         Add assertion.
  79         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
  80         errors)): Delete.
  81         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
  82         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
  83         Add assertion.
  84
  85 2019-04-08  Tom Tromey  <tom@tromey.com>
  86
  87         * valops.c (value_rtti_indirect_type): Replace throw_exception
  88         with throw.
  89         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
  90         with throw.
  91         * thread.c (thr_try_catch_cmd): Replace throw_exception with
  92         throw.
  93         * target.c (target_translate_tls_address): Replace throw_exception
  94         with throw.
  95         * stack.c (frame_apply_command_count): Replace throw_exception
  96         with throw.
  97         * solib-spu.c (append_ocl_sos): Replace throw_exception with
  98         throw.
  99         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
 100         with throw.
 101         * rs6000-tdep.c (rs6000_frame_cache)
 102         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
 103         * remote.c: Replace throw_exception with throw.
 104         * record-full.c (record_full_message, record_full_wait_1)
 105         (record_full_restore): Replace throw_exception with throw.
 106         * record-btrace.c:
 107         (get_thread_current_frame_id, record_btrace_start_replaying)
 108         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
 109         (cmd_record_btrace_start): Replace throw_exception with throw.
 110         * parse.c (parse_exp_in_context_1): Replace throw_exception with
 111         throw.
 112         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
 113         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
 114         * linespec.c:
 115         (find_linespec_symbols): Replace throw_exception with throw.
 116         * infrun.c (displaced_step_prepare, resume): Replace
 117         throw_exception with throw.
 118         * infcmd.c (post_create_inferior): Replace throw_exception with
 119         throw.
 120         * inf-loop.c (inferior_event_handler): Replace throw_exception
 121         with throw.
 122         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
 123         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
 124         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
 125         (get_prev_frame_always, get_frame_pc_if_available)
 126         (get_frame_address_in_block_if_available, get_frame_language):
 127         Replace throw_exception with throw.
 128         * frame-unwind.c (frame_unwind_try_unwinder): Replace
 129         throw_exception with throw.
 130         * eval.c (fetch_subexp_value, evaluate_var_value)
 131         (evaluate_funcall, evaluate_subexp_standard): Replace
 132         throw_exception with throw.
 133         * dwarf2loc.c (call_site_find_chain)
 134         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
 135         Replace throw_exception with throw.
 136         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
 137         with throw.
 138         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
 139         throw.
 140         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
 141         * completer.c (complete_line_internal): Replace throw_exception
 142         with throw.
 143         * compile/compile-object-run.c (compile_object_run): Replace
 144         throw_exception with throw.
 145         * cli/cli-script.c (process_next_line): Replace throw_exception
 146         with throw.
 147         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
 148         (btrace_enable, btrace_maint_update_pt_packets): Replace
 149         throw_exception with throw.
 150         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
 151         throw_exception with throw.
 152         * break-catch-throw.c (re_set_exception_catchpoint): Replace
 153         throw_exception with throw.
 154         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
 155         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
 156         * aarch64-tdep.c (aarch64_make_prologue_cache)
 157         (aarch64_make_stub_cache): Replace throw_exception with throw.
 158
 159 2019-04-08  Tom Tromey  <tom@tromey.com>
 160
 161         * common/common-exceptions.c (throw_exception): Rename from
 162         throw_exception_cxx.  Remove old copy.  Make argument const.
 163         (throw_it): Create and throw exception objects directly.
 164         * common/common-exceptions.h (throw_exception): Make argument
 165         const.
 166         (struct gdb_exception_error): Add constructor.
 167         (struct gdb_exception_quit): Add constructor.
 168
 169 2019-04-08  Tom Tromey  <tom@tromey.com>
 170
 171         * common/common-exceptions.h (exception_rethrow): Don't declare.
 172         (TRY_SJLJ): Update comment.
 173         (TRY, CATCH, END_CATCH): Remove.
 174         * common/common-exceptions.c (exception_rethrow): Remove.
 175
 176 2019-04-08  Tom Tromey  <tom@tromey.com>
 177
 178         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
 179         Remove.
 180         (gdb_exception_error): Rename from
 181         gdb_exception_RETURN_MASK_ERROR.
 182         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
 183         (gdb_quit_bad_alloc): Update.
 184         * aarch64-tdep.c: Update.
 185         * ada-lang.c: Update.
 186         * ada-typeprint.c: Update.
 187         * ada-valprint.c: Update.
 188         * amd64-tdep.c: Update.
 189         * arch-utils.c: Update.
 190         * break-catch-throw.c: Update.
 191         * breakpoint.c: Update.
 192         * btrace.c: Update.
 193         * c-varobj.c: Update.
 194         * cli/cli-cmds.c: Update.
 195         * cli/cli-interp.c: Update.
 196         * cli/cli-script.c: Update.
 197         * common/common-exceptions.c: Update.
 198         * common/new-op.c: Update.
 199         * common/selftest.c: Update.
 200         * compile/compile-c-symbols.c: Update.
 201         * compile/compile-cplus-symbols.c: Update.
 202         * compile/compile-object-load.c: Update.
 203         * compile/compile-object-run.c: Update.
 204         * completer.c: Update.
 205         * corelow.c: Update.
 206         * cp-abi.c: Update.
 207         * cp-support.c: Update.
 208         * cp-valprint.c: Update.
 209         * darwin-nat.c: Update.
 210         * disasm-selftests.c: Update.
 211         * dtrace-probe.c: Update.
 212         * dwarf-index-cache.c: Update.
 213         * dwarf-index-write.c: Update.
 214         * dwarf2-frame-tailcall.c: Update.
 215         * dwarf2-frame.c: Update.
 216         * dwarf2loc.c: Update.
 217         * dwarf2read.c: Update.
 218         * eval.c: Update.
 219         * event-loop.c: Update.
 220         * event-top.c: Update.
 221         * exec.c: Update.
 222         * f-valprint.c: Update.
 223         * fbsd-tdep.c: Update.
 224         * frame-unwind.c: Update.
 225         * frame.c: Update.
 226         * gdbtypes.c: Update.
 227         * gnu-v3-abi.c: Update.
 228         * guile/guile-internal.h: Update.
 229         * guile/scm-block.c: Update.
 230         * guile/scm-breakpoint.c: Update.
 231         * guile/scm-cmd.c: Update.
 232         * guile/scm-disasm.c: Update.
 233         * guile/scm-frame.c: Update.
 234         * guile/scm-lazy-string.c: Update.
 235         * guile/scm-math.c: Update.
 236         * guile/scm-param.c: Update.
 237         * guile/scm-ports.c: Update.
 238         * guile/scm-pretty-print.c: Update.
 239         * guile/scm-symbol.c: Update.
 240         * guile/scm-symtab.c: Update.
 241         * guile/scm-type.c: Update.
 242         * guile/scm-value.c: Update.
 243         * i386-linux-tdep.c: Update.
 244         * i386-tdep.c: Update.
 245         * inf-loop.c: Update.
 246         * infcall.c: Update.
 247         * infcmd.c: Update.
 248         * infrun.c: Update.
 249         * jit.c: Update.
 250         * language.c: Update.
 251         * linespec.c: Update.
 252         * linux-fork.c: Update.
 253         * linux-nat.c: Update.
 254         * linux-tdep.c: Update.
 255         * linux-thread-db.c: Update.
 256         * main.c: Update.
 257         * mi/mi-cmd-break.c: Update.
 258         * mi/mi-cmd-stack.c: Update.
 259         * mi/mi-interp.c: Update.
 260         * mi/mi-main.c: Update.
 261         * objc-lang.c: Update.
 262         * p-valprint.c: Update.
 263         * parse.c: Update.
 264         * ppc-linux-tdep.c: Update.
 265         * printcmd.c: Update.
 266         * python/py-arch.c: Update.
 267         * python/py-breakpoint.c: Update.
 268         * python/py-cmd.c: Update.
 269         * python/py-finishbreakpoint.c: Update.
 270         * python/py-frame.c: Update.
 271         * python/py-framefilter.c: Update.
 272         * python/py-gdb-readline.c: Update.
 273         * python/py-inferior.c: Update.
 274         * python/py-infthread.c: Update.
 275         * python/py-lazy-string.c: Update.
 276         * python/py-linetable.c: Update.
 277         * python/py-objfile.c: Update.
 278         * python/py-param.c: Update.
 279         * python/py-prettyprint.c: Update.
 280         * python/py-progspace.c: Update.
 281         * python/py-record-btrace.c: Update.
 282         * python/py-record.c: Update.
 283         * python/py-symbol.c: Update.
 284         * python/py-type.c: Update.
 285         * python/py-unwind.c: Update.
 286         * python/py-utils.c: Update.
 287         * python/py-value.c: Update.
 288         * python/python.c: Update.
 289         * record-btrace.c: Update.
 290         * record-full.c: Update.
 291         * remote-fileio.c: Update.
 292         * remote.c: Update.
 293         * riscv-tdep.c: Update.
 294         * rs6000-aix-tdep.c: Update.
 295         * rs6000-tdep.c: Update.
 296         * rust-exp.y: Update.
 297         * rust-lang.c: Update.
 298         * s390-tdep.c: Update.
 299         * selftest-arch.c: Update.
 300         * solib-dsbt.c: Update.
 301         * solib-frv.c: Update.
 302         * solib-spu.c: Update.
 303         * solib-svr4.c: Update.
 304         * solib.c: Update.
 305         * sparc64-linux-tdep.c: Update.
 306         * stack.c: Update.
 307         * symfile-mem.c: Update.
 308         * symmisc.c: Update.
 309         * target.c: Update.
 310         * thread.c: Update.
 311         * top.c: Update.
 312         * tracefile-tfile.c: Update.
 313         * tui/tui.c: Update.
 314         * typeprint.c: Update.
 315         * unittests/cli-utils-selftests.c: Update.
 316         * unittests/parse-connection-spec-selftests.c: Update.
 317         * valops.c: Update.
 318         * valprint.c: Update.
 319         * value.c: Update.
 320         * varobj.c: Update.
 321         * windows-nat.c: Update.
 322         * x86-linux-nat.c: Update.
 323         * xml-support.c: Update.
 324
 325 2019-04-08  Tom Tromey  <tom@tromey.com>
 326
 327         * xml-support.c: Use C++ exception handling.
 328         * x86-linux-nat.c: Use C++ exception handling.
 329         * windows-nat.c: Use C++ exception handling.
 330         * varobj.c: Use C++ exception handling.
 331         * value.c: Use C++ exception handling.
 332         * valprint.c: Use C++ exception handling.
 333         * valops.c: Use C++ exception handling.
 334         * unittests/parse-connection-spec-selftests.c: Use C++ exception
 335         handling.
 336         * unittests/cli-utils-selftests.c: Use C++ exception handling.
 337         * typeprint.c: Use C++ exception handling.
 338         * tui/tui.c: Use C++ exception handling.
 339         * tracefile-tfile.c: Use C++ exception handling.
 340         * top.c: Use C++ exception handling.
 341         * thread.c: Use C++ exception handling.
 342         * target.c: Use C++ exception handling.
 343         * symmisc.c: Use C++ exception handling.
 344         * symfile-mem.c: Use C++ exception handling.
 345         * stack.c: Use C++ exception handling.
 346         * sparc64-linux-tdep.c: Use C++ exception handling.
 347         * solib.c: Use C++ exception handling.
 348         * solib-svr4.c: Use C++ exception handling.
 349         * solib-spu.c: Use C++ exception handling.
 350         * solib-frv.c: Use C++ exception handling.
 351         * solib-dsbt.c: Use C++ exception handling.
 352         * selftest-arch.c: Use C++ exception handling.
 353         * s390-tdep.c: Use C++ exception handling.
 354         * rust-lang.c: Use C++ exception handling.
 355         * rust-exp.y: Use C++ exception handling.
 356         * rs6000-tdep.c: Use C++ exception handling.
 357         * rs6000-aix-tdep.c: Use C++ exception handling.
 358         * riscv-tdep.c: Use C++ exception handling.
 359         * remote.c: Use C++ exception handling.
 360         * remote-fileio.c: Use C++ exception handling.
 361         * record-full.c: Use C++ exception handling.
 362         * record-btrace.c: Use C++ exception handling.
 363         * python/python.c: Use C++ exception handling.
 364         * python/py-value.c: Use C++ exception handling.
 365         * python/py-utils.c: Use C++ exception handling.
 366         * python/py-unwind.c: Use C++ exception handling.
 367         * python/py-type.c: Use C++ exception handling.
 368         * python/py-symbol.c: Use C++ exception handling.
 369         * python/py-record.c: Use C++ exception handling.
 370         * python/py-record-btrace.c: Use C++ exception handling.
 371         * python/py-progspace.c: Use C++ exception handling.
 372         * python/py-prettyprint.c: Use C++ exception handling.
 373         * python/py-param.c: Use C++ exception handling.
 374         * python/py-objfile.c: Use C++ exception handling.
 375         * python/py-linetable.c: Use C++ exception handling.
 376         * python/py-lazy-string.c: Use C++ exception handling.
 377         * python/py-infthread.c: Use C++ exception handling.
 378         * python/py-inferior.c: Use C++ exception handling.
 379         * python/py-gdb-readline.c: Use C++ exception handling.
 380         * python/py-framefilter.c: Use C++ exception handling.
 381         * python/py-frame.c: Use C++ exception handling.
 382         * python/py-finishbreakpoint.c: Use C++ exception handling.
 383         * python/py-cmd.c: Use C++ exception handling.
 384         * python/py-breakpoint.c: Use C++ exception handling.
 385         * python/py-arch.c: Use C++ exception handling.
 386         * printcmd.c: Use C++ exception handling.
 387         * ppc-linux-tdep.c: Use C++ exception handling.
 388         * parse.c: Use C++ exception handling.
 389         * p-valprint.c: Use C++ exception handling.
 390         * objc-lang.c: Use C++ exception handling.
 391         * mi/mi-main.c: Use C++ exception handling.
 392         * mi/mi-interp.c: Use C++ exception handling.
 393         * mi/mi-cmd-stack.c: Use C++ exception handling.
 394         * mi/mi-cmd-break.c: Use C++ exception handling.
 395         * main.c: Use C++ exception handling.
 396         * linux-thread-db.c: Use C++ exception handling.
 397         * linux-tdep.c: Use C++ exception handling.
 398         * linux-nat.c: Use C++ exception handling.
 399         * linux-fork.c: Use C++ exception handling.
 400         * linespec.c: Use C++ exception handling.
 401         * language.c: Use C++ exception handling.
 402         * jit.c: Use C++ exception handling.
 403         * infrun.c: Use C++ exception handling.
 404         * infcmd.c: Use C++ exception handling.
 405         * infcall.c: Use C++ exception handling.
 406         * inf-loop.c: Use C++ exception handling.
 407         * i386-tdep.c: Use C++ exception handling.
 408         * i386-linux-tdep.c: Use C++ exception handling.
 409         * guile/scm-value.c: Use C++ exception handling.
 410         * guile/scm-type.c: Use C++ exception handling.
 411         * guile/scm-symtab.c: Use C++ exception handling.
 412         * guile/scm-symbol.c: Use C++ exception handling.
 413         * guile/scm-pretty-print.c: Use C++ exception handling.
 414         * guile/scm-ports.c: Use C++ exception handling.
 415         * guile/scm-param.c: Use C++ exception handling.
 416         * guile/scm-math.c: Use C++ exception handling.
 417         * guile/scm-lazy-string.c: Use C++ exception handling.
 418         * guile/scm-frame.c: Use C++ exception handling.
 419         * guile/scm-disasm.c: Use C++ exception handling.
 420         * guile/scm-cmd.c: Use C++ exception handling.
 421         * guile/scm-breakpoint.c: Use C++ exception handling.
 422         * guile/scm-block.c: Use C++ exception handling.
 423         * guile/guile-internal.h: Use C++ exception handling.
 424         * gnu-v3-abi.c: Use C++ exception handling.
 425         * gdbtypes.c: Use C++ exception handling.
 426         * frame.c: Use C++ exception handling.
 427         * frame-unwind.c: Use C++ exception handling.
 428         * fbsd-tdep.c: Use C++ exception handling.
 429         * f-valprint.c: Use C++ exception handling.
 430         * exec.c: Use C++ exception handling.
 431         * event-top.c: Use C++ exception handling.
 432         * event-loop.c: Use C++ exception handling.
 433         * eval.c: Use C++ exception handling.
 434         * dwarf2read.c: Use C++ exception handling.
 435         * dwarf2loc.c: Use C++ exception handling.
 436         * dwarf2-frame.c: Use C++ exception handling.
 437         * dwarf2-frame-tailcall.c: Use C++ exception handling.
 438         * dwarf-index-write.c: Use C++ exception handling.
 439         * dwarf-index-cache.c: Use C++ exception handling.
 440         * dtrace-probe.c: Use C++ exception handling.
 441         * disasm-selftests.c: Use C++ exception handling.
 442         * darwin-nat.c: Use C++ exception handling.
 443         * cp-valprint.c: Use C++ exception handling.
 444         * cp-support.c: Use C++ exception handling.
 445         * cp-abi.c: Use C++ exception handling.
 446         * corelow.c: Use C++ exception handling.
 447         * completer.c: Use C++ exception handling.
 448         * compile/compile-object-run.c: Use C++ exception handling.
 449         * compile/compile-object-load.c: Use C++ exception handling.
 450         * compile/compile-cplus-symbols.c: Use C++ exception handling.
 451         * compile/compile-c-symbols.c: Use C++ exception handling.
 452         * common/selftest.c: Use C++ exception handling.
 453         * common/new-op.c: Use C++ exception handling.
 454         * cli/cli-script.c: Use C++ exception handling.
 455         * cli/cli-interp.c: Use C++ exception handling.
 456         * cli/cli-cmds.c: Use C++ exception handling.
 457         * c-varobj.c: Use C++ exception handling.
 458         * btrace.c: Use C++ exception handling.
 459         * breakpoint.c: Use C++ exception handling.
 460         * break-catch-throw.c: Use C++ exception handling.
 461         * arch-utils.c: Use C++ exception handling.
 462         * amd64-tdep.c: Use C++ exception handling.
 463         * ada-valprint.c: Use C++ exception handling.
 464         * ada-typeprint.c: Use C++ exception handling.
 465         * ada-lang.c: Use C++ exception handling.
 466         * aarch64-tdep.c: Use C++ exception handling.
 467
 468 2019-04-08  Tom Tromey  <tom@tromey.com>
 469
 470         * xml-support.c (gdb_xml_parser::parse): Update.
 471         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
 472         * value.c (show_convenience): Update.
 473         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
 474         (test_parse_flags_qcs): Update.
 475         * thread.c (thr_try_catch_cmd): Update.
 476         * target.c (target_translate_tls_address): Update.
 477         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
 478         (info_frame_command_core, frame_apply_command_count): Update.
 479         * rust-exp.y (rust_lex_exception_test): Update.
 480         * riscv-tdep.c (riscv_print_one_register_info): Update.
 481         * remote.c (remote_target::enable_btrace): Update.
 482         * record-btrace.c (record_btrace_enable_warn): Update.
 483         * python/py-utils.c (gdbpy_convert_exception): Update.
 484         * printcmd.c (do_one_display, print_variable_and_value): Update.
 485         * mi/mi-main.c (mi_print_exception): Update.
 486         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
 487         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 488         * linux-nat.c (linux_nat_target::attach): Update.
 489         * linux-fork.c (class scoped_switch_fork_info): Update.
 490         * infrun.c (displaced_step_prepare): Update.
 491         * infcall.c (call_function_by_hand_dummy): Update.
 492         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
 493         * gnu-v3-abi.c (print_one_vtable): Update.
 494         * frame.c (get_prev_frame_always): Update.
 495         * f-valprint.c (info_common_command_for_block): Update.
 496         * exec.c (try_open_exec_file): Update.
 497         * exceptions.c (print_exception, exception_print)
 498         (exception_fprintf, exception_print_same): Update.
 499         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
 500         * dwarf-index-cache.c (index_cache::store)
 501         (index_cache::lookup_gdb_index): Update.
 502         * darwin-nat.c (maybe_cache_shell): Update.
 503         * cp-valprint.c (cp_print_value_fields): Update.
 504         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
 505         (gcc_cplus_symbol_address): Update.
 506         * compile/compile-c-symbols.c (gcc_convert_symbol)
 507         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
 508         * common/selftest.c: Update.
 509         * common/common-exceptions.h (struct gdb_exception) <message>: Now
 510         a std::string.
 511         (exception_try_scope_entry, exception_try_scope_exit): Don't
 512         declare.
 513         (struct exception_try_scope): Remove.
 514         (TRY): Don't use exception_try_scope.
 515         (struct gdb_exception): Add constructor, operator=.
 516         <what>: New method.
 517         (struct gdb_exception_RETURN_MASK_ALL)
 518         (struct gdb_exception_RETURN_MASK_ERROR)
 519         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
 520         (struct gdb_quit_bad_alloc): Update.
 521         * common/common-exceptions.c (exception_none): Change
 522         initializer.
 523         (struct catcher) <state, exception>: Initialize inline.
 524         <prev>: Remove member.
 525         (current_catcher): Remove.
 526         (catchers): New global.
 527         (exceptions_state_mc_init): Simplify.
 528         (catcher_pop): Remove.
 529         (exceptions_state_mc, exceptions_state_mc_catch): Update.
 530         (try_scope_depth, exception_try_scope_entry)
 531         (exception_try_scope_exit): Remove.
 532         (throw_exception_sjlj): Update.
 533         (exception_messages, exception_messages_size): Remove.
 534         (throw_it): Simplify.
 535         (gdb_exception_sliced_copy): Remove.
 536         (throw_exception_cxx): Update.
 537         * cli/cli-script.c (script_from_file): Update.
 538         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
 539         Update.
 540         * ada-valprint.c (ada_val_print): Update.
 541         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
 542         (create_excep_cond_exprs): Update.
 543
 544 2019-04-08  Tom Tromey  <tom@tromey.com>
 545
 546         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
 547         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
 548         (TRY, CATCH, END_CATCH): Remove some definitions.
 549         * common/common-exceptions.c: Don't use GDB_XCPT.
 550         (catcher_list_size): Remove.
 551         (throw_exception, throw_it): Simplify.
 552
 553 2019-04-05  Tom Tromey  <tom@tromey.com>
 554
 555         Revert the header-sorting patch.
 556         * ft32-tdep.c: Revert.
 557         * frv-tdep.c: Revert.
 558         * frv-linux-tdep.c: Revert.
 559         * frame.c: Revert.
 560         * frame-unwind.c: Revert.
 561         * frame-base.c: Revert.
 562         * fork-child.c: Revert.
 563         * findvar.c: Revert.
 564         * findcmd.c: Revert.
 565         * filesystem.c: Revert.
 566         * filename-seen-cache.h: Revert.
 567         * filename-seen-cache.c: Revert.
 568         * fbsd-tdep.c: Revert.
 569         * fbsd-nat.h: Revert.
 570         * fbsd-nat.c: Revert.
 571         * f-valprint.c: Revert.
 572         * f-typeprint.c: Revert.
 573         * f-lang.c: Revert.
 574         * extension.h: Revert.
 575         * extension.c: Revert.
 576         * extension-priv.h: Revert.
 577         * expprint.c: Revert.
 578         * exec.h: Revert.
 579         * exec.c: Revert.
 580         * exceptions.c: Revert.
 581         * event-top.c: Revert.
 582         * event-loop.c: Revert.
 583         * eval.c: Revert.
 584         * elfread.c: Revert.
 585         * dwarf2read.h: Revert.
 586         * dwarf2read.c: Revert.
 587         * dwarf2loc.c: Revert.
 588         * dwarf2expr.h: Revert.
 589         * dwarf2expr.c: Revert.
 590         * dwarf2-frame.c: Revert.
 591         * dwarf2-frame-tailcall.c: Revert.
 592         * dwarf-index-write.h: Revert.
 593         * dwarf-index-write.c: Revert.
 594         * dwarf-index-common.c: Revert.
 595         * dwarf-index-cache.h: Revert.
 596         * dwarf-index-cache.c: Revert.
 597         * dummy-frame.c: Revert.
 598         * dtrace-probe.c: Revert.
 599         * disasm.h: Revert.
 600         * disasm.c: Revert.
 601         * disasm-selftests.c: Revert.
 602         * dictionary.c: Revert.
 603         * dicos-tdep.c: Revert.
 604         * demangle.c: Revert.
 605         * dcache.h: Revert.
 606         * dcache.c: Revert.
 607         * darwin-nat.h: Revert.
 608         * darwin-nat.c: Revert.
 609         * darwin-nat-info.c: Revert.
 610         * d-valprint.c: Revert.
 611         * d-namespace.c: Revert.
 612         * d-lang.c: Revert.
 613         * ctf.c: Revert.
 614         * csky-tdep.c: Revert.
 615         * csky-linux-tdep.c: Revert.
 616         * cris-tdep.c: Revert.
 617         * cris-linux-tdep.c: Revert.
 618         * cp-valprint.c: Revert.
 619         * cp-support.c: Revert.
 620         * cp-namespace.c: Revert.
 621         * cp-abi.c: Revert.
 622         * corelow.c: Revert.
 623         * corefile.c: Revert.
 624         * continuations.c: Revert.
 625         * completer.h: Revert.
 626         * completer.c: Revert.
 627         * complaints.c: Revert.
 628         * coffread.c: Revert.
 629         * coff-pe-read.c: Revert.
 630         * cli-out.h: Revert.
 631         * cli-out.c: Revert.
 632         * charset.c: Revert.
 633         * c-varobj.c: Revert.
 634         * c-valprint.c: Revert.
 635         * c-typeprint.c: Revert.
 636         * c-lang.c: Revert.
 637         * buildsym.c: Revert.
 638         * buildsym-legacy.c: Revert.
 639         * build-id.h: Revert.
 640         * build-id.c: Revert.
 641         * btrace.c: Revert.
 642         * bsd-uthread.c: Revert.
 643         * breakpoint.h: Revert.
 644         * breakpoint.c: Revert.
 645         * break-catch-throw.c: Revert.
 646         * break-catch-syscall.c: Revert.
 647         * break-catch-sig.c: Revert.
 648         * blockframe.c: Revert.
 649         * block.c: Revert.
 650         * bfin-tdep.c: Revert.
 651         * bfin-linux-tdep.c: Revert.
 652         * bfd-target.c: Revert.
 653         * bcache.c: Revert.
 654         * ax-general.c: Revert.
 655         * ax-gdb.h: Revert.
 656         * ax-gdb.c: Revert.
 657         * avr-tdep.c: Revert.
 658         * auxv.c: Revert.
 659         * auto-load.c: Revert.
 660         * arm-wince-tdep.c: Revert.
 661         * arm-tdep.c: Revert.
 662         * arm-symbian-tdep.c: Revert.
 663         * arm-pikeos-tdep.c: Revert.
 664         * arm-obsd-tdep.c: Revert.
 665         * arm-nbsd-tdep.c: Revert.
 666         * arm-nbsd-nat.c: Revert.
 667         * arm-linux-tdep.c: Revert.
 668         * arm-linux-nat.c: Revert.
 669         * arm-fbsd-tdep.c: Revert.
 670         * arm-fbsd-nat.c: Revert.
 671         * arm-bsd-tdep.c: Revert.
 672         * arch-utils.c: Revert.
 673         * arc-tdep.c: Revert.
 674         * arc-newlib-tdep.c: Revert.
 675         * annotate.h: Revert.
 676         * annotate.c: Revert.
 677         * amd64-windows-tdep.c: Revert.
 678         * amd64-windows-nat.c: Revert.
 679         * amd64-tdep.c: Revert.
 680         * amd64-sol2-tdep.c: Revert.
 681         * amd64-obsd-tdep.c: Revert.
 682         * amd64-obsd-nat.c: Revert.
 683         * amd64-nbsd-tdep.c: Revert.
 684         * amd64-nbsd-nat.c: Revert.
 685         * amd64-nat.c: Revert.
 686         * amd64-linux-tdep.c: Revert.
 687         * amd64-linux-nat.c: Revert.
 688         * amd64-fbsd-tdep.c: Revert.
 689         * amd64-fbsd-nat.c: Revert.
 690         * amd64-dicos-tdep.c: Revert.
 691         * amd64-darwin-tdep.c: Revert.
 692         * amd64-bsd-nat.c: Revert.
 693         * alpha-tdep.c: Revert.
 694         * alpha-obsd-tdep.c: Revert.
 695         * alpha-nbsd-tdep.c: Revert.
 696         * alpha-mdebug-tdep.c: Revert.
 697         * alpha-linux-tdep.c: Revert.
 698         * alpha-linux-nat.c: Revert.
 699         * alpha-bsd-tdep.c: Revert.
 700         * alpha-bsd-nat.c: Revert.
 701         * aix-thread.c: Revert.
 702         * agent.c: Revert.
 703         * addrmap.c: Revert.
 704         * ada-varobj.c: Revert.
 705         * ada-valprint.c: Revert.
 706         * ada-typeprint.c: Revert.
 707         * ada-tasks.c: Revert.
 708         * ada-lang.c: Revert.
 709         * aarch64-tdep.c: Revert.
 710         * aarch64-ravenscar-thread.c: Revert.
 711         * aarch64-newlib-tdep.c: Revert.
 712         * aarch64-linux-tdep.c: Revert.
 713         * aarch64-linux-nat.c: Revert.
 714         * aarch64-fbsd-tdep.c: Revert.
 715         * aarch64-fbsd-nat.c: Revert.
 716         * aarch32-linux-nat.c: Revert.
 717
 718 2019-04-05  Tom Tromey  <tom@tromey.com>
 719
 720         * ft32-tdep.c: Sort headers.
 721         * frv-tdep.c: Sort headers.
 722         * frv-linux-tdep.c: Sort headers.
 723         * frame.c: Sort headers.
 724         * frame-unwind.c: Sort headers.
 725         * frame-base.c: Sort headers.
 726         * fork-child.c: Sort headers.
 727         * findvar.c: Sort headers.
 728         * findcmd.c: Sort headers.
 729         * filesystem.c: Sort headers.
 730         * filename-seen-cache.h: Sort headers.
 731         * filename-seen-cache.c: Sort headers.
 732         * fbsd-tdep.c: Sort headers.
 733         * fbsd-nat.h: Sort headers.
 734         * fbsd-nat.c: Sort headers.
 735         * f-valprint.c: Sort headers.
 736         * f-typeprint.c: Sort headers.
 737         * f-lang.c: Sort headers.
 738         * extension.h: Sort headers.
 739         * extension.c: Sort headers.
 740         * extension-priv.h: Sort headers.
 741         * expprint.c: Sort headers.
 742         * exec.h: Sort headers.
 743         * exec.c: Sort headers.
 744         * exceptions.c: Sort headers.
 745         * event-top.c: Sort headers.
 746         * event-loop.c: Sort headers.
 747         * eval.c: Sort headers.
 748         * elfread.c: Sort headers.
 749         * dwarf2read.h: Sort headers.
 750         * dwarf2read.c: Sort headers.
 751         * dwarf2loc.c: Sort headers.
 752         * dwarf2expr.h: Sort headers.
 753         * dwarf2expr.c: Sort headers.
 754         * dwarf2-frame.c: Sort headers.
 755         * dwarf2-frame-tailcall.c: Sort headers.
 756         * dwarf-index-write.h: Sort headers.
 757         * dwarf-index-write.c: Sort headers.
 758         * dwarf-index-common.c: Sort headers.
 759         * dwarf-index-cache.h: Sort headers.
 760         * dwarf-index-cache.c: Sort headers.
 761         * dummy-frame.c: Sort headers.
 762         * dtrace-probe.c: Sort headers.
 763         * disasm.h: Sort headers.
 764         * disasm.c: Sort headers.
 765         * disasm-selftests.c: Sort headers.
 766         * dictionary.c: Sort headers.
 767         * dicos-tdep.c: Sort headers.
 768         * demangle.c: Sort headers.
 769         * dcache.h: Sort headers.
 770         * dcache.c: Sort headers.
 771         * darwin-nat.h: Sort headers.
 772         * darwin-nat.c: Sort headers.
 773         * darwin-nat-info.c: Sort headers.
 774         * d-valprint.c: Sort headers.
 775         * d-namespace.c: Sort headers.
 776         * d-lang.c: Sort headers.
 777         * ctf.c: Sort headers.
 778         * csky-tdep.c: Sort headers.
 779         * csky-linux-tdep.c: Sort headers.
 780         * cris-tdep.c: Sort headers.
 781         * cris-linux-tdep.c: Sort headers.
 782         * cp-valprint.c: Sort headers.
 783         * cp-support.c: Sort headers.
 784         * cp-namespace.c: Sort headers.
 785         * cp-abi.c: Sort headers.
 786         * corelow.c: Sort headers.
 787         * corefile.c: Sort headers.
 788         * continuations.c: Sort headers.
 789         * completer.h: Sort headers.
 790         * completer.c: Sort headers.
 791         * complaints.c: Sort headers.
 792         * coffread.c: Sort headers.
 793         * coff-pe-read.c: Sort headers.
 794         * cli-out.h: Sort headers.
 795         * cli-out.c: Sort headers.
 796         * charset.c: Sort headers.
 797         * c-varobj.c: Sort headers.
 798         * c-valprint.c: Sort headers.
 799         * c-typeprint.c: Sort headers.
 800         * c-lang.c: Sort headers.
 801         * buildsym.c: Sort headers.
 802         * buildsym-legacy.c: Sort headers.
 803         * build-id.h: Sort headers.
 804         * build-id.c: Sort headers.
 805         * btrace.c: Sort headers.
 806         * bsd-uthread.c: Sort headers.
 807         * breakpoint.h: Sort headers.
 808         * breakpoint.c: Sort headers.
 809         * break-catch-throw.c: Sort headers.
 810         * break-catch-syscall.c: Sort headers.
 811         * break-catch-sig.c: Sort headers.
 812         * blockframe.c: Sort headers.
 813         * block.c: Sort headers.
 814         * bfin-tdep.c: Sort headers.
 815         * bfin-linux-tdep.c: Sort headers.
 816         * bfd-target.c: Sort headers.
 817         * bcache.c: Sort headers.
 818         * ax-general.c: Sort headers.
 819         * ax-gdb.h: Sort headers.
 820         * ax-gdb.c: Sort headers.
 821         * avr-tdep.c: Sort headers.
 822         * auxv.c: Sort headers.
 823         * auto-load.c: Sort headers.
 824         * arm-wince-tdep.c: Sort headers.
 825         * arm-tdep.c: Sort headers.
 826         * arm-symbian-tdep.c: Sort headers.
 827         * arm-pikeos-tdep.c: Sort headers.
 828         * arm-obsd-tdep.c: Sort headers.
 829         * arm-nbsd-tdep.c: Sort headers.
 830         * arm-nbsd-nat.c: Sort headers.
 831         * arm-linux-tdep.c: Sort headers.
 832         * arm-linux-nat.c: Sort headers.
 833         * arm-fbsd-tdep.c: Sort headers.
 834         * arm-fbsd-nat.c: Sort headers.
 835         * arm-bsd-tdep.c: Sort headers.
 836         * arch-utils.c: Sort headers.
 837         * arc-tdep.c: Sort headers.
 838         * arc-newlib-tdep.c: Sort headers.
 839         * annotate.h: Sort headers.
 840         * annotate.c: Sort headers.
 841         * amd64-windows-tdep.c: Sort headers.
 842         * amd64-windows-nat.c: Sort headers.
 843         * amd64-tdep.c: Sort headers.
 844         * amd64-sol2-tdep.c: Sort headers.
 845         * amd64-obsd-tdep.c: Sort headers.
 846         * amd64-obsd-nat.c: Sort headers.
 847         * amd64-nbsd-tdep.c: Sort headers.
 848         * amd64-nbsd-nat.c: Sort headers.
 849         * amd64-nat.c: Sort headers.
 850         * amd64-linux-tdep.c: Sort headers.
 851         * amd64-linux-nat.c: Sort headers.
 852         * amd64-fbsd-tdep.c: Sort headers.
 853         * amd64-fbsd-nat.c: Sort headers.
 854         * amd64-dicos-tdep.c: Sort headers.
 855         * amd64-darwin-tdep.c: Sort headers.
 856         * amd64-bsd-nat.c: Sort headers.
 857         * alpha-tdep.c: Sort headers.
 858         * alpha-obsd-tdep.c: Sort headers.
 859         * alpha-nbsd-tdep.c: Sort headers.
 860         * alpha-mdebug-tdep.c: Sort headers.
 861         * alpha-linux-tdep.c: Sort headers.
 862         * alpha-linux-nat.c: Sort headers.
 863         * alpha-bsd-tdep.c: Sort headers.
 864         * alpha-bsd-nat.c: Sort headers.
 865         * aix-thread.c: Sort headers.
 866         * agent.c: Sort headers.
 867         * addrmap.c: Sort headers.
 868         * ada-varobj.c: Sort headers.
 869         * ada-valprint.c: Sort headers.
 870         * ada-typeprint.c: Sort headers.
 871         * ada-tasks.c: Sort headers.
 872         * ada-lang.c: Sort headers.
 873         * aarch64-tdep.c: Sort headers.
 874         * aarch64-ravenscar-thread.c: Sort headers.
 875         * aarch64-newlib-tdep.c: Sort headers.
 876         * aarch64-linux-tdep.c: Sort headers.
 877         * aarch64-linux-nat.c: Sort headers.
 878         * aarch64-fbsd-tdep.c: Sort headers.
 879         * aarch64-fbsd-nat.c: Sort headers.
 880         * aarch32-linux-nat.c: Sort headers.
 881
 882 2019-04-04  Tom Tromey  <tom@tromey.com>
 883
 884         * varobj.c (varobj_create): Update.
 885         * rust-exp.y (struct rust_parser) <update_innermost_block,
 886         lookup_symbol>: New methods.
 887         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
 888         Rename.
 889         (rust_parser::rust_lookup_type)
 890         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
 891         * printcmd.c (display_command, do_one_display): Update.
 892         * parser-defs.h (struct parser_state) <parser_state>: Add
 893         "tracker" parameter.
 894         (block_tracker): New member.
 895         (class innermost_block_tracker) <innermost_block_tracker>: Add
 896         "types" parameter.
 897         <reset>: Remove method.
 898         (innermost_block): Don't declare.
 899         (null_post_parser): Update.
 900         * parse.c (innermost_block): Remove global.
 901         (write_dollar_variable): Update.
 902         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
 903         Remove "tracker_types" parameter.
 904         (parse_expression): Add "tracker" parameter.
 905         (parse_expression_for_completion): Update.
 906         (null_post_parser): Add "tracker" parameter.
 907         * p-exp.y: Update rules.
 908         * m2-exp.y: Update rules.
 909         * language.h (struct language_defn) <la_post_parser>: Add
 910         "tracker" parameter.
 911         * go-exp.y: Update rules.
 912         * f-exp.y: Update rules.
 913         * expression.h (parse_expression, parse_exp_1): Add "tracker"
 914         parameter.
 915         * d-exp.y: Update rules.
 916         * c-exp.y: Update rules.
 917         * breakpoint.c (set_breakpoint_condition): Create an
 918         innermost_block_tracker.
 919         (watch_command_1): Likewise.
 920         * ada-lang.c (resolve): Add "tracker" parameter.
 921         (resolve_subexp): Likewise.
 922         * ada-exp.y (write_var_from_sym): Update.
 923
 924 2019-04-04  Tom Tromey  <tom@tromey.com>
 925
 926         * type-stack.h: New file.
 927         * type-stack.c: New file.
 928         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
 929         type-stack.h.
 930         (insert_into_type_stack, insert_type, push_type, push_type_int)
 931         (insert_type_address_space, pop_type, pop_type_int)
 932         (pop_typelist, pop_type_stack, append_type_stack)
 933         (push_type_stack, get_type_stack, push_typelist)
 934         (follow_type_instance_flags, follow_types): Don't declare.
 935         * parse.c (type_stack): Remove global.
 936         (parse_exp_in_context): Update.
 937         (insert_into_type_stack, insert_type, push_type, push_type_int)
 938         (insert_type_address_space, pop_type, pop_type_int)
 939         (pop_typelist, pop_type_stack, append_type_stack)
 940         (push_type_stack, get_type_stack, push_typelist)
 941         (follow_type_instance_flags, follow_types): Remove (moved to
 942         type-stack.c).
 943         * f-exp.y (type_stack): New global.
 944         Update rules.
 945         (push_kind_type, f_parse): Update.
 946         * d-exp.y (type_stack): New global.
 947         Update rules.
 948         (d_parse): Update.
 949         * c-exp.y (struct c_parse_state) <type_stack>: New member.
 950         Update rules.
 951         * Makefile.in (COMMON_SFILES): Add type-stack.c.
 952         (HFILES_NO_SRCDIR): Add type-stack.h.
 953
 954 2019-04-04  Tom Tromey  <tom@tromey.com>
 955
 956         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
 957         (rust_parser::convert_ast_to_expression, rust_parse)
 958         (rust_lex_test_completion, rust_lex_tests): Update.
 959         * parser-defs.h (struct expr_completion_state): New.
 960         (struct parser_state) <parser_state>: Add completion parameter.
 961         <mark_struct_expression, mark_completion_tag>: New methods.
 962         <parse_completion, m_completion_state>: New members.
 963         (prefixify_expression, null_post_parser): Update.
 964         (mark_struct_expression, mark_completion_tag): Don't declare.
 965         * parse.c (parse_completion, expout_last_struct)
 966         (expout_tag_completion_type, expout_completion_name): Remove
 967         globals.
 968         (parser_state::mark_struct_expression)
 969         (parser_state::mark_completion_tag): Now methods.
 970         (prefixify_expression): Add last_struct parameter.
 971         (prefixify_subexp): Likewise.
 972         (parse_exp_1): Update.
 973         (parse_exp_in_context): Add cstate parameter.  Update.
 974         (parse_expression_for_completion): Create an
 975         expr_completion_state.
 976         (null_post_parser): Add "completion" parameter.
 977         * p-exp.y: Update rules.
 978         (yylex): Update.
 979         * language.h (struct language_defn) <la_post_parser>: Add
 980         "completing" parameter.
 981         * go-exp.y: Update rules.
 982         (lex_one_token): Update.
 983         * expression.h (parse_completion): Don't declare.
 984         * d-exp.y: Update rules.
 985         (lex_one_token): Update rules.
 986         * c-exp.y: Update rules.
 987         (lex_one_token): Update.
 988         * ada-lang.c (resolve): Add "parse_completion" parameter.
 989         (resolve_subexp): Likewise.
 990         (ada_resolve_function): Likewise.
 991
 992 2019-04-04  Tom Tromey  <tom@tromey.com>
 993
 994         * parser-defs.h (struct parser_state) <start_arglist,
 995         end_arglist>: New methods.
 996         <arglist_len, m_funcall_chain>: New members.
 997         (arglist_len, start_arglist, end_arglist): Don't declare.
 998         * parse.c (arglist_len, funcall_chain): Remove global.
 999         (start_arglist, end_arglist): Remove functions.
1000         (parse_exp_in_context): Update.
1001         * p-exp.y: Update rules.
1002         * m2-exp.y: Update rules.
1003         * go-exp.y: Update rules.
1004         * f-exp.y: Update rules.
1005         * d-exp.y: Update rules.
1006         * c-exp.y: Update rules.
1007
1008 2019-04-04  Tom Tromey  <tom@tromey.com>
1009
1010         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
1011         lex_operator, push_back>: New methods.
1012         Update all rules.
1013         (rust_parser::lex_hex, lex_escape): Rename and update.
1014         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
1015         (rust_parser::lex_operator): Rename and update.
1016         (rust_parser::lex_number, rustyylex, rustyyerror)
1017         (rust_lex_test_init, rust_lex_test_sequence)
1018         (rust_lex_test_push_back, rust_lex_tests): Update.
1019         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
1020         parameter.
1021         <lexptr, prev_lexptr>: New members.
1022         (lexptr, prev_lexptr): Don't declare.
1023         * parse.c (lexptr, prev_lexptr): Remove globals.
1024         (parse_exp_in_context): Update.
1025         * p-exp.y (yylex, yyerror): Update.
1026         * m2-exp.y (parse_number, yylex, yyerror): Update.
1027         * go-exp.y (lex_one_token, yyerror): Update.
1028         * f-exp.y (match_string_literal, yylex, yyerror): Update.
1029         * d-exp.y (lex_one_token, yyerror): Update.
1030         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
1031         (lex_one_token, yyerror): Update.
1032         * ada-lex.l (YY_INPUT): Update.
1033         (rewind_to_char): Update.
1034         * ada-exp.y (yyerror): Update.
1035
1036 2019-04-04  Tom Tromey  <tom@tromey.com>
1037
1038         * rust-exp.y (rustyylex, rust_lex_tests): Update.
1039         * parser-defs.h (struct parser_state) <parser_state>: Add new
1040         parameter.
1041         <comma_terminates>: New member.
1042         (comma_terminates): Don't declare global.
1043         * parse.c (comma_terminates): Remove global.
1044         (parse_exp_in_context): Update.
1045         * p-exp.y (yylex): Update.
1046         * m2-exp.y (yylex): Update.
1047         * go-exp.y (lex_one_token): Update.
1048         * f-exp.y (yylex): Update.
1049         * d-exp.y (lex_one_token): Update.
1050         * c-exp.y (lex_one_token): Update.
1051         * ada-lex.l: Update.
1052
1053 2019-04-04  Tom Tromey  <tom@tromey.com>
1054
1055         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
1056         (rustyylex, rust_lex_test_init, rust_lex_test_one)
1057         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
1058         * parser-defs.h (paren_depth): Don't declare.
1059         * parse.c (paren_depth): Remove global.
1060         (parse_exp_in_context): Update.
1061         * p-exp.y (paren_depth): New global.
1062         (pascal_parse): Initialize it.
1063         * m2-exp.y (paren_depth): New global.
1064         (m2_parse): Initialize it.
1065         * go-exp.y (paren_depth): New global.
1066         (go_parse): Initialize it.
1067         * f-exp.y (paren_depth): New global.
1068         (f_parse): Initialize it.
1069         * d-exp.y (paren_depth): New global.
1070         (d_parse): Initialize it.
1071         * c-exp.y (paren_depth): New global.
1072         (c_parse): Initialize it.
1073         * ada-lex.l (paren_depth): New global.
1074         (lexer_init): Initialize it.
1075
1076 2019-04-04  Tom Tromey  <tom@tromey.com>
1077
1078         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
1079         (rust_parser::convert_ast_to_type)
1080         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1081         * parser-defs.h (struct parser_state) <parser_state>: Add
1082         parameters.  Initialize new members.
1083         <expression_context_block, expression_context_pc>: New members.
1084         * parse.c (expression_context_block, expression_context_pc):
1085         Remove globals.
1086         (parse_exp_in_context): Update.
1087         * p-exp.y: Update all rules.
1088         (yylex): Update.
1089         * m2-exp.y: Update all rules.
1090         (yylex): Update.
1091         * go-exp.y (yylex): Update.
1092         * f-exp.y (yylex): Update.
1093         * d-exp.y: Update all rules.
1094         (yylex): Update.
1095         * c-exp.y: Update all rules.
1096         (lex_one_token, classify_name, yylex, c_parse): Update.
1097         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
1098
1099 2019-04-04  Tom Tromey  <tom@tromey.com>
1100
1101         * gdbarch.h, gdbarch.c: Rebuild.
1102         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
1103         * stap-probe.h:
1104         (struct stap_parse_info): Replace "parser_state" with
1105         "expr_builder".
1106         * parser-defs.h (struct expr_builder): Rename from "parser_state".
1107         (parser_state): New class.
1108         * parse.c (expr_builder): Rename.
1109         (expr_builder::release): Rename.
1110         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
1111         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
1112         (write_exp_elt_longcst, write_exp_elt_floatcst)
1113         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
1114         (write_exp_string_vector, write_exp_bitstring)
1115         (write_exp_msymbol, mark_struct_expression)
1116         (write_dollar_variable)
1117         (insert_type_address_space, increase_expout_size): Replace
1118         "parser_state" with "expr_builder".
1119         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
1120         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
1121         "parser_state" with "expr_builder".
1122
1123 2019-04-04  Tom Tromey  <tom@tromey.com>
1124
1125         * rust-exp.y: Replace "parse_language" with method call.
1126         * p-exp.y:
1127         (yylex): Replace "parse_language" with method call.
1128         * m2-exp.y:
1129         (yylex): Replace "parse_language" with method call.
1130         * go-exp.y (classify_name): Replace "parse_language" with method
1131         call.
1132         * f-exp.y (yylex): Replace "parse_language" with method call.
1133         * d-exp.y (lex_one_token): Replace "parse_language" with method
1134         call.
1135         * c-exp.y:
1136         (lex_one_token, classify_name, yylex): Replace "parse_language"
1137         with method call.
1138         * ada-exp.y (find_primitive_type, type_char)
1139         (type_system_address): Replace "parse_language" with method call.
1140
1141 2019-04-04  Tom Tromey  <tom@tromey.com>
1142
1143         * rust-exp.y: Replace "parse_gdbarch" with method call.
1144         * parse.c (write_dollar_variable, insert_type_address_space):
1145         Replace "parse_gdbarch" with method call.
1146         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
1147         call.
1148         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
1149         call.
1150         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
1151         "parse_gdbarch" with method call.
1152         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
1153         with method call.
1154         * f-exp.y (parse_type, parse_f_type, yylex): Replace
1155         "parse_gdbarch" with method call.
1156         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
1157         "parse_gdbarch" with method call.
1158         * c-exp.y (parse_type, parse_number, classify_name): Replace
1159         "parse_gdbarch" with method call.
1160         * ada-lex.l: Replace "parse_gdbarch" with method call.
1161         * ada-exp.y (parse_type, find_primitive_type, type_char)
1162         (type_system_address): Replace "parse_gdbarch" with method call.
1163
1164 2019-04-04  Tom Tromey  <tom@tromey.com>
1165
1166         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
1167         * stap-probe.c (stap_parse_argument): Update.
1168         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
1169         initial_size parameter.
1170         * rust-exp.y (rust_lex_tests): Update.
1171         * parse.c (parser_state): Update.
1172         (parse_exp_in_context): Update.
1173         * parser-defs.h (struct parser_state) <parser_state>: Remove
1174         "initial_size" parameter.
1175
1176 2019-04-04  Tom Tromey  <tom@tromey.com>
1177
1178         * parser-defs.h (increase_expout_size): Don't declare.
1179         * parse.c (increase_expout_size): Now static.
1180
1181 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
1182
1183         * gnu-nat.c (gnu_nat_target::wait): Fix
1184         target_waitstatus_to_string call.
1185
1186 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1187
1188         * eval.c (evaluate_subexp_standard): Handle internal functions
1189         during Fortran function call handling.
1190
1191 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1192
1193         * NEWS: Mention new internal functions.
1194         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
1195         (read_base_type): Use dwarf2_init_complex_target_type.
1196         * value.c (creal_internal_fn): New function.
1197         (cimag_internal_fn): New function.
1198         (_initialize_values): Register new internal functions.
1199
1200 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1201
1202         * infrun.c (stop_all_threads): If debug_infrun, always
1203         trace the wait status after wait_one, using
1204         target_waitstatus_to_string and target_pid_to_str.
1205         (handle_inferior_event): Replace various trace of
1206         wait status kind by a single trace.
1207         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
1208         wait status kind image by target_waitstatus_to_string.
1209         * target/waitstatus.c (target_waitstatus_to_string): Fix
1210         obsolete comment.
1211
1212 2019-04-01  Tom Tromey  <tromey@adacore.com>
1213
1214         PR symtab/23331:
1215         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
1216
1217 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
1218             Pedro Alves  <palves@redhat.com>
1219
1220         * top.c (quit_force): Call 'finalize_values'.
1221         * value.c (finalize_values): New function.
1222         * value.h (finalize_values): Declare.
1223
1224 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
1225
1226         * NEWS: Announce $_gdb_major and $_gdb_minor.
1227
1228         * top.c (init_gdb_version_vars): New function.
1229         (gdb_init): Call init_gdb_version_vars.
1230
1231 2019-03-29  Tom Tromey  <tromey@adacore.com>
1232
1233         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
1234         help text.  Remove dead code.
1235
1236 2019-03-29  Keith Seitz  <keiths@redhat.com>
1237
1238         From Siddhesh Poyarekar:
1239         * f-lang.h (f77_get_upperbound): Return LONGEST.
1240         (f77_get_lowerbound): Likewise.
1241         * f-typeprint.c (f_type_print_varspec_suffix): Expand
1242         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
1243         print them.
1244         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
1245         plongest to format print it.
1246         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
1247         (f77_get_upperbound): Likewise.
1248         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
1249         LOWER_BOUND to LONGEST.
1250         (f77_create_arrayprint_offset_tbl): Likewise.
1251
1252 2019-03-29  Keith Seitz  <keiths@redhat.com>
1253
1254         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
1255         %s/pulongest for TYPE_LENGTH instead of %d in format
1256         strings.
1257         * ada-typerint.c (ada_print_type): Likewise.
1258         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
1259         * compile/compile-c-support.c (generate_register_struct): Likewise.
1260         * gdbtypes.c (recursive_dump_type): Likewise.
1261         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
1262         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
1263         instead of %d in format strings.
1264         * riscv-tdep.c (riscv_type_alignment): Cast second argument
1265         to std::min to ULONGEST.
1266         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
1267         instead of %d in format strings.
1268         * tracepoint.c (info_scope_command): Likewise.
1269         * typeprint.c (print_offset_data::update)
1270         (print_offset_data::finish): Likewise.
1271         * xtensa-tdep.c (xtensa_store_return_value)
1272         (xtensa_push_dummy_call): Likewise.
1273
1274 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
1275
1276         * windows-nat.c (display_selector): Fixed format specifications
1277         for 64-bit Cygwin.
1278
1279 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1280
1281         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
1282
1283 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
1284
1285         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
1286         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
1287         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
1288         (nios2_linux_init_abi): Install it.
1289
1290 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1291
1292         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
1293
1294 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1295
1296         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
1297
1298 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1299             Tom Tromey  <tromey@adacore.com>
1300
1301         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
1302
1303 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
1304
1305         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
1306         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
1307         method to compute the bounds of range types. Also print "[evaluated]"
1308         if the bounds' values come from a dynamic evaluation.
1309
1310 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1311
1312         * cp-valprint.c (cp_print_value_fields): Don't print trailing
1313         whitespace when pretty printing is on.
1314
1315 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1316
1317         * ppc-linux-nat.c: Add include.
1318
1319 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1320
1321         * NEWS: Mention AArch64 Pointer Authentication.
1322
1323 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1324
1325         * arm-linux-nat.c: Add include.
1326
1327 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
1328
1329         * source-cache.c (source_cache::get_source_lines): Re-read
1330         fullname after calling open_source_file.
1331
1332 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
1333
1334         * NEWS: Mention TLS support for FreeBSD.
1335
1336 2019-03-25  Tom Tromey  <tromey@adacore.com>
1337
1338         * minsyms.c (BUNCH_SIZE): Update comment.
1339         (~minimal_symbol_reader): Remove old comment.
1340         (compact_minimal_symbols): Update comment.
1341         (minimal_symbol_reader::install): Remove old comment.  Update
1342         other comments.
1343
1344 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1345
1346         * s390-linux-nat.c: Add include.
1347
1348 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1349
1350         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1351         Call linux_get_hwcap.
1352         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
1353         Likewise.
1354         (aarch64_linux_get_hwcap): Remove function.
1355         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
1356         declaration.
1357         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
1358         linux_get_hwcap.
1359         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1360         * linux-tdep.c (linux_get_hwcap): Add function.
1361         (linux_get_hwcap2): Likewise.
1362         * linux-tdep.h (linux_get_hwcap): Add declaration.
1363         (linux_get_hwcap2): Likewise.
1364         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
1365         (ppc_linux_get_hwcap2): Likewise.
1366         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
1367         linux_get_hwcap.
1368         (ppc_linux_nat_target::insert_watchpoint): Likewise.
1369         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
1370         (ppc_linux_nat_target::read_description): Likewise.
1371         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
1372         * s390-linux-nat.c: Likewise.
1373         * s390-linux-tdep.c (s390_core_read_description): Likewise.
1374
1375 2019-03-24  Tom Tromey  <tom@tromey.com>
1376
1377         * ada-lang.c (standard_lookup): Simplify initialization.
1378         (ada_lookup_symbol_nonlocal): Simplify return.
1379         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
1380         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
1381         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
1382         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
1383         initialization.
1384         * solib.c (solib_global_lookup): Simplify.
1385         * symtab.c (null_block_symbol): Remove.
1386         (symbol_cache_lookup): Simplify returns.
1387         (lookup_language_this): Simplify returns.
1388         (lookup_symbol_aux): Simplify return.
1389         (lookup_local_symbol): Simplify returns.
1390         (lookup_global_symbol_from_objfile): Simplify return.
1391         (lookup_symbol_in_objfile_symtabs)
1392         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
1393         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
1394         (lookup_static_symbol, lookup_global_symbol): Simplify return.
1395         * cp-namespace.c (cp_lookup_bare_symbol)
1396         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
1397         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
1398         (cp_lookup_nested_symbol): Don't use null_block_symbol.
1399         (cp_lookup_symbol_via_imports): Simplify initialization.
1400         (find_symbol_in_baseclass): Likewise.
1401         * symtab.h (null_block_symbol): Remove.
1402         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
1403         (d_lookup_nested_symbol, d_lookup_symbol_imports)
1404         (d_lookup_symbol_module): Likewise.
1405         (find_symbol_in_baseclass): Simplify initialization.
1406
1407 2019-03-24  Tom Tromey  <tom@tromey.com>
1408
1409         * expression.h: Don't include symtab.h.
1410         (struct block): Forward declare.
1411
1412 2019-03-24  Tom Tromey  <tom@tromey.com>
1413
1414         * c-exp.y (typebase): Remove casts.
1415         * gdbtypes.c (lookup_unsigned_typename, )
1416         (lookup_signed_typename): Remove cast.
1417         * eval.c (parse_to_comma_and_eval): Remove cast.
1418         * parse.c (write_dollar_variable): Remove cast.
1419         * block.h (struct block) <superblock>: Now const.
1420         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
1421         * psymtab.c (psym_map_matching_symbols): Make "block" const.
1422         (map_block): Make "block" const.
1423         * symfile.h (struct quick_symbol_functions)
1424         <map_matching_symbols>: Constify block argument to "callback".
1425         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
1426         const.
1427         (find_pc_sect_compunit_symtab): Make "b" const.
1428         (find_symbol_at_address): Likewise.
1429         (search_symbols): Likewise.
1430         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
1431         (dw2_debug_names_lookup_symbol): Likewise.
1432         (dw2_map_matching_symbols): Update.
1433         * p-valprint.c (pascal_val_print): Remove "block".
1434         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
1435         (aux_add_nonlocal_symbols): Make "block" const.
1436         (resolve_subexp): Remove cast.
1437         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
1438         const.
1439         (iterate_over_file_blocks): Likewise.
1440         * f-exp.y (%union) <bval>: Remove.
1441         * coffread.c (patch_opaque_types): Make "b" const.
1442         * spu-tdep.c (spu_catch_start): Make "block" const.
1443         * c-valprint.c (print_unpacked_pointer): Remove "block".
1444         * symmisc.c (dump_symtab_1): Make "b" const.
1445         (block_depth): Make "block" const.
1446         * d-exp.y (%union) <bval>: Remove.
1447         * cp-support.h (cp_lookup_rtti_type): Update.
1448         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
1449         * psymtab.c (psym_lookup_symbol): Make "block" const.
1450         (maintenance_check_psymtabs): Make "b" const.
1451         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
1452         (enumerate_locals, enumerate_args): Update.
1453         * python/py-symtab.c (stpy_global_block): Make "block" const.
1454         (stpy_static_block): Likewise.
1455         * inline-frame.c (block_starting_point_at): Make "new_block"
1456         const.
1457         * block.c (find_block_in_blockvector): Make return type const.
1458         (blockvector_for_pc_sect): Make "b" const.
1459         (find_block_in_blockvector): Make "b" const.
1460
1461 2019-03-23  Tom Tromey  <tom@tromey.com>
1462
1463         * varobj.c (varobj_create): Update.
1464         * symfile.c (clear_symtab_users): Don't reset innermost_block.
1465         * printcmd.c (display_command, do_one_display): Don't reset
1466         innermost_block.
1467         * parser-defs.h (enum innermost_block_tracker_type): Move to
1468         expression.h.
1469         (innermost_block): Update comment.
1470         * parse.c (parse_exp_1): Add tracker_types parameter.
1471         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
1472         tracker_types parameter.  Reset innermost_block.
1473         (parse_exp_in_context): Remove.
1474         (parse_expression_for_completion): Update.
1475         * objfiles.c (~objfile): Don't reset expression_context_block or
1476         innermost_block.
1477         * expression.h (enum innermost_block_tracker_type): Move from
1478         parser-defs.h.
1479         (parse_exp_1): Add tracker_types parameter.
1480         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
1481         reset innermost_block.
1482
1483 2019-03-23  Tom Tromey  <tom@tromey.com>
1484
1485         * objfiles.h: Include bcache.h.
1486
1487 2019-03-23  Tom Tromey  <tom@tromey.com>
1488
1489         * linespec.c (get_current_search_block): Use
1490         scoped_restore_current_language.
1491         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
1492
1493 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1494             Jiong Wang  <jiong.wang@arm.com>
1495
1496         * aarch64-linux-tdep.c
1497         (aarch64_linux_iterate_over_regset_sections): Check for pauth
1498         section.
1499         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
1500
1501 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1502             Jiong Wang  <jiong.wang@arm.com>
1503
1504         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
1505         instructions.
1506         (aarch64_analyze_prologue_test): Add PACIASP test.
1507         (aarch64_prologue_prev_register): Unmask PC value.
1508
1509 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1510             Jiong Wang  <jiong.wang@arm.com>
1511
1512         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
1513         (aarch64_dwarf2_prev_register): Unmask PC value.
1514         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
1515         (aarch64_execute_dwarf_cfa_vendor_op): Check for
1516         DW_CFA_AARCH64_negate_ra_state.
1517         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
1518
1519 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1520             Jiong Wang  <jiong.wang@arm.com>
1521
1522         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
1523         registers.
1524         (aarch64_pseudo_register_name): Likewise.
1525         (aarch64_pseudo_register_type): Likewise.
1526         (aarch64_pseudo_register_reggroup_p): Likewise.
1527         (aarch64_gdbarch_init): Add pauth registers.
1528         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
1529         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
1530         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
1531         (struct gdbarch_tdep): Add regnum for ra_state.
1532
1533 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1534             Jiong Wang  <jiong.wang@arm.com>
1535
1536         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
1537
1538 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1539             Jiong Wang  <jiong.wang@arm.com>
1540
1541         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
1542         function.
1543         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
1544         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
1545         (aarch64_gdbarch_init): Add puth registers.
1546         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
1547         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
1548         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
1549
1550 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1551             Jiong Wang  <jiong.wang@arm.com>
1552
1553         * aarch64-linux-nat.c
1554         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
1555         * aarch64-linux-tdep.c
1556         (aarch64_linux_core_read_description): Likewise.
1557         (aarch64_linux_get_hwcap): New function.
1558         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
1559         (aarch64_linux_get_hwcap): New declaration.
1560
1561 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1562             Jiong Wang  <jiong.wang@arm.com>
1563
1564         * aarch64-linux-nat.c
1565         (aarch64_linux_nat_target::read_description): Add pauth param.
1566         * aarch64-linux-tdep.c
1567         (aarch64_linux_core_read_description): Likewise.
1568         * aarch64-tdep.c (struct target_desc): Add in pauth.
1569         (aarch64_read_description): Add pauth param.
1570         (aarch64_gdbarch_init): Likewise.
1571         * aarch64-tdep.h (aarch64_read_description): Likewise.
1572         * arch/aarch64.c (aarch64_create_target_description): Likewise.
1573         * arch/aarch64.h (aarch64_create_target_description): Likewise.
1574         * features/Makefile: Add new files.
1575         * features/aarch64-pauth.c: New file.
1576         * features/aarch64-pauth.xml: New file.
1577
1578 2019-03-20  Tom Tromey  <tromey@adacore.com>
1579
1580         * infrun.c (handle_inferior_event): Rename from
1581         handle_inferior_event_1.  Create a scoped_value_mark.
1582         (handle_inferior_event): Remove.
1583
1584 2019-03-19  Tom Tromey  <tromey@adacore.com>
1585
1586         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
1587         * infrun.h (print_stop_event): Add "displays" parameter.
1588         * infrun.c (print_stop_event): Add "displays" parameter.
1589
1590 2019-03-19  Pedro Alves  <palves@redhat.com>
1591
1592         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
1593         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
1594         to -1.  Fix TABs vs spaces.
1595         (tui_ui_out::tui_ui_out): Don't initialize fields here.
1596         * tui/tui-out.h (tui_ui_out) Add intro comments.
1597         <m_line, m_start_of_line>: In-class initialize, and add describing
1598         comment.
1599
1600 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
1601
1602         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
1603         variable names.
1604         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
1605
1606 2019-03-18  Pedro Alves  <palves@redhat.com>
1607             Eli Zaretskii <eliz@gnu.org>
1608
1609         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
1610         m_line and m_start_of_line.
1611
1612 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
1613
1614         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
1615         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
1616         it returns a newline.  This fixes a regression in TU mode, whereby
1617         the next line is output on the same screen line as the user input.
1618
1619 2019-03-18  Tom Tromey  <tromey@adacore.com>
1620
1621         * minsyms.c (minimal_symbol_reader::install): Remove call to
1622         obstack_blank.
1623
1624 2019-03-18  Pedro Alves  <palves@redhat.com>
1625
1626         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
1627         New globals.
1628         (apply_style): New, factored out from ...
1629         (apply_ansi_escape): ... this.  Handle reverse video mode.
1630         (tui_set_reverse_mode): New function.
1631         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
1632         * tui/tui-winsource.c (tui_show_source_line): Use
1633         tui_set_reverse_mode instead of setting A_STANDOUT.
1634         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
1635         New setter methods.
1636
1637 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
1638
1639         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
1640         Handle tabs.
1641
1642 2019-03-18  Tom Tromey  <tromey@adacore.com>
1643
1644         * ada-lang.c (empty_array): Add "high" parameter.
1645         (ada_evaluate_subexp): Update.
1646
1647 2019-03-17  Sergei Trofimovich <siarheit@google.com>
1648
1649         * unittests/string_view-selftests.c: Define
1650         _initialize_string_view_selftests unconditionally.
1651
1652 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
1653
1654         PR gdb/24350
1655         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
1656
1657 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
1658
1659         PR gdb/24351
1660         * windows-nat.c (display_selector): Fix format specifiers.
1661
1662 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
1663
1664         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
1665         tui_refill_source_window instead of tui_refresh_win, to update the
1666         current execution line.  This fixes redisplay of the current line
1667         when stepping through the code with "next" or "step".
1668
1669 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
1670
1671         * source-cache.c (source_cache::get_source_lines): Call
1672         find_source_lines to initialize s->nlines.  This fixes vertical
1673         scrolling of TUI source window when the DOWN arrow is pressed.
1674
1675 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1676
1677         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
1678         linux-thread-db.c (_initialize_thread_db): Likewise.
1679
1680 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
1681
1682         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
1683         wclrtoeol in tui_show_source_line".  This reverts changes made in
1684         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
1685
1686 2019-03-15  Tom Tromey  <tom@tromey.com>
1687
1688         * symtab.h (struct minimal_symbol): Derive from
1689         general_symbol_info.
1690         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
1691         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
1692         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
1693         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
1694         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
1695         (MSYMBOL_SEARCH_NAME): Update.
1696         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
1697         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
1698         * minsyms.c (minimal_symbol_reader::record_full): Update.
1699
1700 2019-03-15  Tom Tromey  <tom@tromey.com>
1701
1702         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
1703
1704 2019-03-15  Tom Tromey  <tom@tromey.com>
1705
1706         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
1707         unique_xmalloc_ptr.
1708         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
1709         Update.
1710         * minsyms.c (lookup_minimal_symbol_by_pc_section)
1711         (build_minimal_symbol_hash_tables)
1712         (minimal_symbol_reader::install): Update.
1713
1714 2019-03-15  Tom Tromey  <tom@tromey.com>
1715
1716         * symtab.c (create_demangled_names_hash): Update.
1717         (symbol_set_names): Update.
1718         * objfiles.h (struct objfile_per_bfd_storage)
1719         <demangled_names_hash>: Now an htab_up.
1720         * objfiles.c (objfile_per_bfd_storage): Simplify.
1721
1722 2019-03-15  Tom Tromey  <tom@tromey.com>
1723
1724         * objfiles.h (struct objfile_per_bfd_storage): Declare
1725         destructor.
1726         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
1727         New.
1728         (get_objfile_bfd_data): Use new.  Don't initialize
1729         language_of_main.
1730         (free_objfile_per_bfd_storage): Remove.
1731         (objfile_bfd_data_free, objfile::~objfile): Use delete.
1732
1733 2019-03-15  Tom Tromey  <tom@tromey.com>
1734
1735         * symfile.c (reread_symbols): Update.
1736         * objfiles.c (objfile::objfile): Update.
1737         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
1738         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
1739         comment.
1740         (minimal_symbol_reader::install): Update.
1741         (terminate_minimal_symbol_table): Remove.
1742         * jit.c (jit_object_close_impl): Update.
1743
1744 2019-03-15  Tom Tromey  <tom@tromey.com>
1745
1746         * minsyms.c (minimal_symbol_reader::record_full): Remove some
1747         initializations.
1748
1749 2019-03-15  Tom Tromey  <tom@tromey.com>
1750
1751         * objfiles.h (struct objfile_per_bfd_storage)
1752         <demangled_hash_languages>: Now a bitset.
1753         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
1754         (lookup_minimal_symbol): Update.
1755
1756 2019-03-15  Tom Tromey  <tom@tromey.com>
1757
1758         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
1759         Don't return the symbol.
1760         * coffread.c (record_minimal_symbol): Use record_full.
1761
1762 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
1763
1764         The MS-Windows port of ncurses fails to switch to a color pair if
1765         one or both of the colors are the implicit default colors.  This
1766         change records the default colors when TUI is initialized, and
1767         then specifies them explicitly when a color pair uses the default
1768         colors.  This allows color styling in TUI mode on MS-Windows.
1769
1770         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
1771         ncurses_norm_attr.
1772         (tui_initialize_io) [__MINGW32__]: Record the default terminal
1773         colors in ncurses_norm_attr.
1774         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
1775         "none", replace it with the default color recorded in
1776         ncurses_norm_attr.
1777
1778 2019-03-14  Tom Tromey  <tromey@adacore.com>
1779
1780         * source-cache.h (class source_cache) <get_source_lines>: Return
1781         std::string.
1782         * source-cache.c (source_cache::extract_lines): Handle case where
1783         first_pos==npos.  Return std::string.
1784         (source_cache::get_source_lines): Update.
1785
1786 2019-03-14  Tom Tromey  <tromey@adacore.com>
1787
1788         * NEWS: Add item for "style sources" commands.
1789         * source-cache.c (source_cache::get_source_lines): Check
1790         source_styling.
1791         * cli/cli-style.c (source_styling): New global.
1792         (_initialize_cli_style): Add "style sources" commands.
1793         (show_style_sources): New function.
1794         * cli/cli-style.h (source_styling): Declare.
1795
1796 2019-03-14  Pedro Alves  <palves@redhat.com>
1797             Tom Tromey  <tromey@adacore.com>
1798
1799         * tui/tui-winsource.h (tui_refill_source_window): Declare.
1800         * tui/tui-winsource.c (tui_refill_source_window): New function,
1801         from...
1802         (tui_horizontal_source_scroll): ... here.  Move some logic.
1803         * cli/cli-style.c (set_style_enabled): Notify new observable.
1804         * tui/tui-hooks.c (tui_redisplay_source): New function.
1805         (tui_attach_detach_observers): Attach or detach
1806         tui_redisplay_source.
1807         * observable.h (source_styling_changed): New observable.
1808         * observable.c: Define source_styling_changed observable.
1809
1810 2019-03-13  Tom Tromey  <tromey@adacore.com>
1811
1812         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
1813         (i386_gnu_nat_target::store_registers): Update.
1814         * target-debug.h (target_debug_print_std_string): New macro.
1815         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1816         * windows-tdep.c (display_one_tib): Update.
1817         * tui/tui-stack.c (tui_make_status_line): Update.
1818         * top.c (print_inferior_quit_action): Update.
1819         * thread.c (thr_try_catch_cmd): Update.
1820         (add_thread_with_info): Update.
1821         (thread_target_id_str): Update.
1822         (thr_try_catch_cmd): Update.
1823         (thread_command): Update.
1824         (thread_find_command): Update.
1825         * record-btrace.c (record_btrace_target::info_record)
1826         (record_btrace_resume_thread, record_btrace_target::resume)
1827         (record_btrace_cancel_resume, record_btrace_step_thread)
1828         (record_btrace_target::wait, record_btrace_target::wait)
1829         (record_btrace_target::wait, record_btrace_target::stop): Update.
1830         * progspace.c (print_program_space): Update.
1831         * process-stratum-target.c
1832         (process_stratum_target::thread_address_space): Update.
1833         * linux-fork.c (linux_fork_mourn_inferior)
1834         (detach_checkpoint_command, info_checkpoints_command)
1835         (linux_fork_context): Update.
1836         (linux_fork_detach): Update.
1837         (class scoped_switch_fork_info): Update.
1838         (delete_checkpoint_command): Update.
1839         * infrun.c (follow_fork_inferior): Update.
1840         (follow_fork_inferior): Update.
1841         (proceed_after_vfork_done): Update.
1842         (handle_vfork_child_exec_or_exit): Update.
1843         (follow_exec): Update.
1844         (displaced_step_prepare_throw): Update.
1845         (displaced_step_restore): Update.
1846         (start_step_over): Update.
1847         (resume_1): Update.
1848         (clear_proceed_status_thread): Update.
1849         (proceed): Update.
1850         (print_target_wait_results): Update.
1851         (do_target_wait): Update.
1852         (context_switch): Update.
1853         (stop_all_threads): Update.
1854         (restart_threads): Update.
1855         (finish_step_over): Update.
1856         (handle_signal_stop): Update.
1857         (switch_back_to_stepped_thread): Update.
1858         (keep_going_pass_signal): Update.
1859         (print_exited_reason): Update.
1860         (normal_stop): Update.
1861         * inferior.c (inferior_pid_to_str): Change return type.
1862         (print_selected_inferior): Update.
1863         (add_inferior): Update.
1864         (detach_inferior): Update.
1865         * dummy-frame.c (fprint_dummy_frames): Update.
1866         * dcache.c (dcache_info_1): Update.
1867         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
1868         (btrace_fetch, btrace_clear): Update.
1869         * linux-tdep.c (linux_core_pid_to_str): Change return type.
1870         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
1871         type.
1872         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
1873         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
1874         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
1875         * gdbarch.c, gdbarch.h: Rebuild.
1876         * gdbarch.sh (core_pid_to_str): Change return type.
1877         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
1878         return type.
1879         (windows_nat_target::pid_to_str): Change return type.
1880         (windows_delete_thread): Update.
1881         (windows_nat_target::attach): Update.
1882         (windows_nat_target::files_info): Update.
1883         * target-delegates.c: Rebuild.
1884         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
1885         return type.
1886         (sol_thread_target::pid_to_str): Change return type.
1887         * remote.c (class remote_target) <pid_to_str>: Change return
1888         type.
1889         (remote_target::pid_to_str): Change return type.
1890         (extended_remote_target::attach, remote_target::remote_stop_ns)
1891         (remote_target::remote_notif_remove_queued_reply)
1892         (remote_target::push_stop_reply, remote_target::disable_btrace):
1893         Update.
1894         (extended_remote_target::attach): Update.
1895         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
1896         type.
1897         (gdbsim_target::pid_to_str): Change return type.
1898         * ravenscar-thread.c (struct ravenscar_thread_target)
1899         <pid_to_str>: Change return type.
1900         (ravenscar_thread_target::pid_to_str): Change return type.
1901         * procfs.c (class procfs_target) <pid_to_str>: Change return
1902         type.
1903         (procfs_target::pid_to_str): Change return type.
1904         (procfs_target::attach): Update.
1905         (procfs_target::detach): Update.
1906         (procfs_target::fetch_registers): Update.
1907         (procfs_target::store_registers): Update.
1908         (procfs_target::wait): Update.
1909         (procfs_target::files_info): Update.
1910         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
1911         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
1912         return type.
1913         (nto_procfs_target::pid_to_str): Change return type.
1914         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
1915         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
1916         return type.
1917         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
1918         (exit_lwp): Update.
1919         (attach_proc_task_lwp_callback, get_detach_signal)
1920         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
1921         (linux_nat_target::resume, wait_lwp, stop_callback)
1922         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
1923         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
1924         (linux_nat_wait_1, resume_stopped_resumed_lwps)
1925         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
1926         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
1927         type.
1928         (inf_ptrace_target::attach): Update.
1929         (inf_ptrace_target::files_info): Update.
1930         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
1931         type.
1932         (go32_nat_target::pid_to_str): Change return type.
1933         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
1934         (gnu_nat_target::wait): Update.
1935         (gnu_nat_target::wait): Update.
1936         (gnu_nat_target::resume): Update.
1937         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
1938         (fbsd_nat_target::wait): Update.
1939         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
1940         type.
1941         (darwin_nat_target::attach): Update.
1942         * corelow.c (class core_target) <pid_to_str>: Change return type.
1943         (core_target::pid_to_str): Change return type.
1944         * target.c (normal_pid_to_str): Change return type.
1945         (default_pid_to_str): Likewise.
1946         (target_pid_to_str): Change return type.
1947         (target_translate_tls_address): Update.
1948         (target_announce_detach): Update.
1949         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
1950         return type.
1951         (bsd_uthread_target::pid_to_str): Change return type.
1952         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
1953         type.
1954         (bsd_kvm_target::pid_to_str): Change return type.
1955         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
1956         return type.
1957         (aix_thread_target::pid_to_str): Change return type.
1958         * target.h (struct target_ops) <pid_to_str>: Change return type.
1959         (target_pid_to_str, normal_pid_to_str): Likewise.
1960         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
1961         type.
1962         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
1963         type.
1964         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
1965         return type.
1966         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
1967         type.
1968         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
1969         type.
1970         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
1971         return type.
1972
1973 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
1974
1975         * NEWS: Mention that the new default MI version is 3.  Mention
1976         changes to the output of commands and events that deal with
1977         multi-location breakpoints.
1978         * breakpoint.c: Include "mi/mi-out.h".
1979         (print_one_breakpoint): Change output syntax if using MI version
1980         >= 3.
1981         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
1982         New.
1983         (mi_multi_location_breakpoint_output_fixed): New.
1984         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
1985         (mi_cmd_fix_multi_location_breakpoint_output): New.
1986         (mi_multi_location_breakpoint_output_fixed): New.
1987         * mi/mi-cmds.c (mi_cmds): Register command
1988         -fix-multi-location-breakpoint-output.
1989         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
1990         interpreter "mi".
1991
1992 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
1993
1994         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
1995         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
1996         instantiate mi_ui_out based on interpreter name.
1997         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
1998         * mi/mi-main.c (mi_load_progress): Likewise.
1999
2000 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2001
2002         * NEWS: Combine separate "New targets" sections for 8.3.
2003
2004 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2005
2006         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
2007         (ppcfbsd_init_abi): Install gdbarch
2008         "fetch_tls_load_module_address" and "get_thread_local_address"
2009         methods.
2010
2011 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2012
2013         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
2014         (riscv_fbsd_init_abi): Install gdbarch
2015         "fetch_tls_load_module_address" and "get_thread_local_address"
2016         methods.
2017
2018 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2019
2020         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
2021         (i386fbsd_init_abi): Install gdbarch
2022         "fetch_tls_load_module_address" and "get_thread_local_address"
2023         methods.
2024
2025 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2026
2027         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
2028         (amd64fbsd_init_abi): Install gdbarch
2029         "fetch_tls_load_module_address" and "get_thread_local_address"
2030         methods.
2031
2032 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2033
2034         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
2035         (struct fbsd_pspace_data): New type.
2036         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
2037         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
2038         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
2039         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
2040         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
2041
2042 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2043
2044         * gdbtypes.c (lookup_struct_elt): New function.
2045         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
2046         * gdbtypes.h (struct struct_elt): New type.
2047         (lookup_struct_elt): New prototype.
2048
2049 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2050
2051         * gdbtypes.c (lookup_struct_elt_type): Update comment and
2052         remove disabled code block.
2053
2054 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2055
2056         * gdbarch.sh (get_thread_local_address): New method.
2057         * gdbarch.h, gdbarch.c: Regenerate.
2058         * target.c (target_translate_tls_address): Use
2059         gdbarch_get_thread_local_address if present instead of
2060         target::get_thread_local_address.
2061
2062 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2063
2064         * target.h (target::get_thread_local_address): Update comment.
2065
2066 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2067
2068         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
2069         objfile->separate_debug_objfile_backlink if not NULL.
2070
2071 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2072
2073         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
2074         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
2075         (amd64bsd_store_inferior_registers): Likewise.
2076         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2077         Enable segment base registers.
2078         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
2079         PT_GETFSBASE and PT_GETGSBASE.
2080         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
2081         PT_SETGSBASE.
2082         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
2083         segment base registers.
2084         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2085
2086 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2087
2088         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2089         Update calls to i386_target_description to add 'segments'
2090         parameter.
2091         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
2092         add segment base registers.
2093         * arch/i386.c (i386_create_target_description): Add 'segments'
2094         parameter to enable segment base registers.
2095         * arch/i386.h (i386_create_target_description): Likewise.
2096         * features/i386/32bit-segments.xml: New file.
2097         * features/i386/32bit-segments.c: Generate.
2098         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
2099         call to i386_target_description to add 'segments' parameter.
2100         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2101         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
2102         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
2103         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
2104         if feature is present.
2105         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
2106         Add 'segments' parameter to call to i386_target_description.
2107         (i386_target_description): Add 'segments' parameter to enable
2108         segment base registers.
2109         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
2110         to call to i386_target_description.
2111         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
2112         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
2113         Define I386_NUM_REGS.
2114         (i386_target_description): Add 'segments' parameter to enable
2115         segment base registers.
2116
2117 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
2118
2119         PR/24325
2120         * source-cache.c: #undef open and close, to avoid unresolved
2121         externals during linking.
2122
2123 2019-03-12  Tom Tromey  <tromey@adacore.com>
2124
2125         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
2126         const.  Add initializers.
2127         (_initialize_remote): Don't initialize ptid globals.
2128
2129 2019-03-12  Pedro Alves  <palves@redhat.com>
2130
2131         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
2132
2133 2019-03-12  Pedro Alves  <palves@redhat.com>
2134
2135         * cp-name-parser.y (main): Remove unused 'len' variable.
2136
2137 2019-03-12  Tom Tromey  <tromey@adacore.com>
2138
2139         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
2140         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
2141
2142 2019-03-12  Tom Tromey  <tromey@adacore.com>
2143
2144         * linux-nat.c (iterate_over_lwps): Update.
2145         (stop_callback): Remove parameter.
2146         (stop_wait_callback, detach_callback, resume_set_callback)
2147         (select_singlestep_lwp_callback, set_ignore_sigint)
2148         (status_callback, resumed_callback, resume_clear_callback)
2149         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
2150         data parameter.
2151         (linux_nat_target::detach, linux_nat_target::resume)
2152         (linux_stop_and_wait_all_lwps, select_event_lwp)
2153         (linux_nat_filter_event, linux_nat_wait_1)
2154         (linux_nat_target::kill, linux_nat_target::stop)
2155         (linux_nat_target::stop): Update.
2156         (linux_nat_resume_callback): Change type.
2157         (resume_stopped_resumed_lwps, count_events_callback)
2158         (select_event_lwp_callback): Likewise.
2159         (linux_stop_lwp, linux_nat_stop_lwp): Update.
2160         * arm-linux-nat.c (struct update_registers_data): Remove.
2161         (update_registers_callback): Change type.
2162         (arm_linux_insert_hw_breakpoint1): Update.
2163         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
2164         parameter.
2165         (x86_linux_dr_set_addr): Update.
2166         (x86_linux_dr_set_control): Update.
2167         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
2168         (iterate_over_lwps): Use gdb::function_view.
2169         * nat/aarch64-linux-hw-point.c (struct
2170         aarch64_dr_update_callback_param): Remove.
2171         (debug_reg_change_callback): Change type.
2172         (aarch64_notify_debug_reg_change): Update.
2173         * s390-linux-nat.c (s390_refresh_per_info): Update.
2174
2175 2019-03-11  Tom Tromey  <tromey@adacore.com>
2176
2177         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
2178         redundant assignment to "this_cu".
2179
2180 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2181
2182         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
2183
2184 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2185
2186         * gdbtypes.c (rank_one_type_parm_set): New function extracted
2187         from...
2188         (rank_one_type): ... this.
2189
2190 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2191
2192         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
2193         from...
2194         (rank_one_type): ... this.
2195
2196 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2197
2198         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
2199         from...
2200         (rank_one_type): ... this.
2201
2202 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2203
2204         * gdbtypes.c (rank_one_type_parm_float): New function extracted
2205         from...
2206         (rank_one_type): ... this.
2207
2208 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2209
2210         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
2211         from...
2212         (rank_one_type): ... this.
2213
2214 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2215
2216         * gdbtypes.c (rank_one_type_parm_range): New function extracted
2217         from...
2218         (rank_one_type): ... this.
2219
2220 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2221
2222         * gdbtypes.c (rank_one_type_parm_char): New function extracted
2223         from...
2224         (rank_one_type): ... this.
2225
2226 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2227
2228         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
2229         from...
2230         (rank_one_type): ... this.
2231
2232 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2233
2234         * gdbtypes.c (rank_one_type_parm_int): New function extracted
2235         from...
2236         (rank_one_type): ... this.
2237
2238 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2239
2240         * gdbtypes.c (rank_one_type_parm_func): New function extracted
2241         from...
2242         (rank_one_type): ... this.
2243
2244 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2245
2246         * gdbtypes.c (rank_one_type_parm_array): New function extracted
2247         from...
2248         (rank_one_type): ... this.
2249
2250 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2251
2252         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
2253         from...
2254         (rank_one_type): ... this.
2255
2256 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2257
2258         * inferior.c (initialize_inferiors): Ensure 'help set/show print
2259         inferior-events' shows the example events.
2260
2261 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
2262
2263         Support styling on native MS-Windows console
2264
2265         PR/24315
2266         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
2267         on MS-Windows if $TERM is not defined.
2268
2269         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
2270
2271         * posix-hdep.c (gdb_console_fputs):
2272         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
2273         functions.
2274         * ui-file.h (gdb_console_fputs): Add prototype.
2275
2276         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
2277         back to fputs only if the former returns zero.
2278
2279 2019-03-07  Tom Tromey  <tom@tromey.com>
2280
2281         * symmisc.c (print_symbol_bcache_statistics): Update.
2282         (print_objfile_statistics): Update.
2283         * symfile.c (allocate_symtab): Update.
2284         * stabsread.c: Don't include bcache.h.
2285         * psymtab.h (struct psymbol_bcache): Don't declare.
2286         (class psymtab_storage) <psymbol_cache>: Now a bcache.
2287         (psymbol_bcache_init, psymbol_bcache_free)
2288         (psymbol_bcache_get_bcache): Don't declare.
2289         * psymtab.c (struct psymbol_bcache): Remove.
2290         (psymtab_storage::psymtab_storage): Update.
2291         (psymtab_storage::~psymtab_storage): Update.
2292         (psymbol_bcache_init, psymbol_bcache_free)
2293         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
2294         (add_psymbol_to_bcache): Update.
2295         (allocate_psymtab): Update.
2296         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
2297         macro_cache>: No longer pointers.
2298         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
2299         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
2300         * macrotab.c (macro_bcache): Update.
2301         * macroexp.c: Don't include bcache.h.
2302         * gdbtypes.c (check_types_worklist): Update.
2303         (types_deeply_equal): Remove TRY/CATCH.  Update.
2304         * elfread.c (elf_symtab_read): Update.
2305         * dwarf2read.c: Don't include bcache.h.
2306         * buildsym.c (buildsym_compunit::get_macro_table): Update.
2307         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
2308         (print_bcache_statistics, bcache_memory_used): Don't declare.
2309         (struct bcache): Move from bcache.c.  Add constructor, destructor,
2310         methods.  Rename all data members.
2311         * bcache.c (struct bcache): Move to bcache.h.
2312         (bcache::expand_hash_table): Rename from expand_hash_table.
2313         (bcache): Remove.
2314         (bcache::insert): Rename from bcache_full.
2315         (bcache::compare): Rename from bcache_compare.
2316         (bcache_xmalloc): Remove.
2317         (bcache::~bcache): Rename from bcache_xfree.
2318         (bcache::print_statistics): Rename from print_bcache_statistics.
2319         (bcache::memory_used): Rename from bcache_memory_used.
2320
2321 2019-03-07  Pedro Alves  <palves@redhat.com>
2322
2323         * infrun.c (normal_stop): Also check for
2324         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
2325
2326 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
2327
2328         * f-lang.c (value_from_host_double): Moved to...
2329         * value.c (value_from_host_double): ...here.
2330         * value.h (value_from_host_double): Declare.
2331         * guile/scm-math.c (vlscm_convert_typed_number): Use
2332         value_from_host_double.
2333         (vlscm_convert_number): Likewise.
2334         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
2335         * python/py-value.c (convert_value_from_python): Likewise.
2336
2337 2019-03-06  Tom Tromey  <tom@tromey.com>
2338
2339         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
2340
2341 2019-03-06  Tom Tromey  <tom@tromey.com>
2342
2343         * utils.h (free_current_contents): Don't declare.
2344         * utils.c (free_current_contents): Remove.
2345
2346 2019-03-06  Tom Tromey  <tom@tromey.com>
2347
2348         * top.c (quit_force): Update.
2349         * main.c (captured_command_loop): Update.
2350         * common/new-op.c (operator new): Update.
2351         * common/common-exceptions.c (struct catcher)
2352         <save_cleanup_chain>: Remove member.
2353         (exceptions_state_mc_init): Update.
2354         (exception_try_scope_entry): Return nullptr.
2355         (exception_try_scope_exit, exception_rethrow)
2356         (throw_exception_sjlj, throw_exception_cxx): Update.
2357         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
2358         (all_cleanups, do_cleanups, discard_cleanups)
2359         (discard_final_cleanups, save_cleanups, save_final_cleanups)
2360         (restore_cleanups, restore_final_cleanups): Don't declare.
2361         (do_final_cleanups): Remove parameter.
2362         * common/cleanups.c (cleanup_chain, make_cleanup)
2363         (make_cleanup_dtor, all_cleanups, do_cleanups)
2364         (discard_my_cleanups, discard_cleanups)
2365         (discard_final_cleanups, save_my_cleanups, save_cleanups)
2366         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
2367         (null_cleanup): Remove.
2368         (do_final_cleanups): Remove parameter.
2369
2370 2019-03-06  Tom Tromey  <tom@tromey.com>
2371
2372         * remote.c (remote_target::remote_parse_stop_reply): Use
2373         unique_xmalloc_ptr.
2374
2375 2019-03-06  Tom Tromey  <tom@tromey.com>
2376
2377         * stabsread.c (struct stabs_field_info): Rename from field_info.
2378         <list, fnlist>: Add initializers.
2379         <obstack>: New member.
2380         (read_member_functions, read_struct_fields, read_baseclasses):
2381         Allocate on obstack.  Don't use cleanups.
2382         (read_one_struct_field, read_member_functions, read_struct_fields)
2383         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
2384         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
2385         (read_struct_type): Update.
2386
2387 2019-03-06  Tom Tromey  <tom@tromey.com>
2388
2389         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
2390         * common/filestuff.h (make_cleanup_close): Don't declare.
2391         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
2392         Remove.
2393
2394 2019-03-06  Tom Tromey  <tom@tromey.com>
2395
2396         * solib-aix.c: Use make_scope_exit.
2397
2398 2019-03-06  Tom Tromey  <tom@tromey.com>
2399
2400         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
2401         Use make_scope_exit.
2402
2403 2019-03-06  Tom Tromey  <tom@tromey.com>
2404
2405         * solib-svr4.c (disable_probes_interface): Remove parameter.
2406         (svr4_handle_solib_event): Use make_scope_exit.
2407
2408 2019-03-06  Tom Tromey  <tom@tromey.com>
2409
2410         * remote.c (struct stop_reply_deleter): Remove.
2411         (stop_reply_up): Update.
2412         (struct stop_reply): Derive from notif_event.  Don't typedef.
2413         <regcache>: Now a std::vector.
2414         (stop_reply_xfree): Remove.
2415         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
2416         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
2417         (remote_target::discard_pending_stop_replies): Use delete.
2418         (remote_target::remote_parse_stop_reply): Update.
2419         (remote_target::process_stop_reply): Update.
2420         * remote-notif.h (struct notif_event): Add virtual destructor.
2421         Remove "dtr" member.
2422         (struct notif_client) <alloc_event>: Return a unique_ptr.
2423         (notif_event_xfree): Don't declare.
2424         (notif_event_up): New typedef.
2425         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
2426         (notif_event_xfree, do_notif_event_xfree): Remove.
2427         (remote_notif_state_xfree): Update.
2428
2429 2019-03-06  Tom Tromey  <tom@tromey.com>
2430
2431         * infrun.c (displaced_step_clear_cleanup): Now a
2432         forward_scope_exit type.
2433         (displaced_step_prepare_throw): Update.
2434         (displaced_step_fixup): Update.
2435
2436 2019-03-06  Tom Tromey  <tom@tromey.com>
2437
2438         * inferior.h (class inferior): Update comment.
2439         * gdbthread.h (class thread_info): Update comment.
2440
2441 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
2442             Tom Tromey  <tom@tromey.com>
2443
2444         * stabsread.h (struct stab_section_list): Remove.
2445         (coffstab_build_psymtabs): Update.
2446         * dbxread.c (symbuf_sections): Now a std::vector.
2447         (sect_idx): New global.
2448         (fill_symbuf): Update.
2449         (coffstab_build_psymtabs): Change type of stabsects parameter.
2450         Update.
2451         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
2452         std::vector.
2453         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
2454         (coff_locate_sections): Update.
2455         (coff_symfile_read): Remove cleanups.  Update.
2456         (init_stringtab): Add storage parameter.
2457         (free_stringtab, free_stringtab_cleanup): Remove.
2458         (init_lineno): Add storage parameter.
2459         (free_linetab, free_linetab_cleanup): Remove.
2460
2461 2019-03-06  Pedro Alves  <palves@redhat.com>
2462
2463         * linux-fork.c (fork_info::clobber_regs): Delete.
2464         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
2465         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
2466         comment.  Adjust.
2467         (scoped_switch_fork_info::scoped_switch_fork_info)
2468         (checkpoint_command, linux_fork_context): Adjust
2469         fork_save_infrun_state calls.
2470
2471 2019-03-06  Pedro Alves  <palves@redhat.com>
2472
2473         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
2474         (inf_has_multiple_threads): Return 'bool' and rewrite using
2475         inferior_info::threads().
2476
2477 2019-03-06  Pedro Alves  <palves@redhat.com>
2478
2479         * linux-fork.c: Include <list>.
2480         (fork_list): Now a std::list instance.
2481         (fork_info): Add ctor, dtor, and in-class initialize all fields.
2482         (forks_exist_p, find_last_fork): Adjust.
2483         (new_fork): Delete.
2484         (one_fork_p): New.
2485         (add_fork): Adjust.
2486         (free_fork): Delete, folded into fork_info::~fork_info().
2487         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
2488         Adjust.
2489         (init_fork_list): Delete.
2490         (linux_fork_killall, linux_fork_mourn_inferior)
2491         (linux_fork_detach, info_checkpoints_command): Adjust.
2492         (_initialize_linux_fork): No longer call init_fork_list.
2493
2494 2019-03-06  Pedro Alves  <palves@redhat.com>
2495
2496         * linux-fork.c (new_fork): New, split out of ...
2497         (add_fork): ... this.  Return void.  Move "first fork" special
2498         case from here, to ...
2499         (checkpoint_command): ... here.
2500         * linux-linux.h (add_fork): Return void.
2501
2502 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2503
2504         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
2505
2506 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2507             Chris January  <chris.january@arm.com>
2508             David Lecomber  <david.lecomber@arm.com>
2509
2510         * f-exp.y: New token, UNOP_INTRINSIC.
2511         (exp): New pattern using UNOP_INTRINSIC token.
2512         (f77_keywords): Add 'abs' keyword.
2513         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
2514         (value_from_host_double): New function.
2515         (evaluate_subexp_f): Support UNOP_ABS.
2516
2517 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2518
2519         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
2520         types.
2521
2522 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2523
2524         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
2525         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
2526         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
2527
2528 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2529
2530         * f-exp.y (convert_to_kind_type): Handle more type kinds.
2531
2532 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2533             Chris January  <chris.january@arm.com>
2534
2535         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
2536         * f-exp.y: Define 'KIND' token.
2537         (exp): New pattern for KIND expressions.
2538         (ptype): Handle types with a kind extension.
2539         (direct_abs_decl): Extend to spot kind extensions.
2540         (f77_keywords): Add 'kind' to the list.
2541         (push_kind_type): New function.
2542         (convert_to_kind_type): New function.
2543         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
2544         * parse.c (operator_length_standard): Likewise.
2545         * parser-defs.h (enum type_pieces): Add tp_kind.
2546         * std-operator.def: Add UNOP_KIND.
2547
2548 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2549
2550         * f-exp.y (f_parse): Set yydebug.
2551
2552 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2553
2554         * f-lang.c (evaluate_subexp_f): New function.
2555         (exp_descriptor_f): New global.
2556         (f_language_defn): Use exp_descriptor_f instead of
2557         exp_descriptor_standard.
2558
2559 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2560
2561         * f-exp.y (struct token): Add comments.
2562         (dot_ops): Remove uppercase versions and the end marker.
2563         (f77_keywords): Likewise.
2564         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
2565         entries in the dot_ops array are case insensitive, and use
2566         strncasecmp to compare strings.  Also some whitespace cleanup in
2567         this area.  Similar for the f77_keywords array, except entries in
2568         this list might be case sensitive.
2569
2570 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2571
2572         * f-exp.y (struct f77_boolean_val): Add comments.
2573         (boolean_values): Remove uppercase versions, and end marker.
2574         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
2575         and use strncasecmp to achieve case insensitivity.  Additionally,
2576         perform whitespace cleanup around this code.
2577
2578 2019-03-06  Tom Tromey  <tromey@adacore.com>
2579
2580         * remote-sim.c (gdbsim_target_open): Use result of
2581         gdb_argv::release.
2582
2583 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
2584         Dirk Schubert  <dirk.schubert@arm.com>
2585         Chris January  <chris.january@arm.com>
2586
2587         * eval.c (evaluate_subexp_standard): Call Fortran argument
2588         wrapping logic.
2589         * f-lang.c (struct value): A value which can be passed into a
2590         Fortran function call.
2591         (fortran_argument_convert): Wrap Fortran arguments in a pointer
2592         where appropriate.
2593         (struct type): Value ready for a Fortran function call.
2594         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
2595         is needed.
2596         * f-lang.h (fortran_argument_convert): Declaration.
2597         (fortran_preserve_arg_pointer): Declaration.
2598         * infcall.c (value_arg_coerce): Call Fortran argument logic.
2599
2600 2019-03-05  Tom Tromey  <tromey@adacore.com>
2601
2602         * python/py-prettyprint.c (print_string_repr): Remove #if.
2603         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
2604
2605 2019-03-05  Tom Tromey  <tromey@adacore.com>
2606
2607         * target.c (the_dummy_target): Move later.  Change type to
2608         "dummy_target".
2609         (initialize_targets): Don't initialize the_dummy_target.
2610
2611 2019-03-05  Tom Tromey  <tromey@adacore.com>
2612
2613         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
2614         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
2615
2616 2019-03-05  Tom Tromey  <tromey@adacore.com>
2617
2618         * windows-nat.c (windows_nat_target::attach)
2619         (windows_nat_target::detach): Don't call gdb_flush.
2620         * valprint.c (generic_val_print, val_print, val_print_string):
2621         Don't call gdb_flush.
2622         * utils.c (defaulted_query): Don't call gdb_flush.
2623         * typeprint.c (print_type_scalar): Don't call gdb_flush.
2624         * target.c (target_announce_detach): Don't call gdb_flush.
2625         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
2626         * remote.c (extended_remote_target::attach): Don't call
2627         gdb_flush.
2628         * procfs.c (procfs_target::detach): Don't call gdb_flush.
2629         * printcmd.c (do_examine): Don't call gdb_flush.
2630         (info_display_command): Don't call gdb_flush.
2631         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
2632         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
2633         * memattr.c (info_mem_command): Don't call gdb_flush.
2634         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
2635         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
2636         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
2637         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
2638         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
2639         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
2640         (gnu_nat_target::detach): Don't call gdb_flush.
2641         * f-valprint.c (f_val_print): Don't call gdb_flush.
2642         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
2643         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
2644         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
2645         gdb_flush.
2646         * c-valprint.c (c_val_print): Don't call gdb_flush.
2647         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
2648
2649 2019-03-05  Tom Tromey  <tromey@adacore.com>
2650
2651         * varobj.c (update_dynamic_varobj_children): Update.
2652         (install_default_visualizer): Use reset, not release.
2653         * value.c (set_internalvar): Update.
2654         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
2655         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
2656         ATTRIBUTE_UNUSED_RESULT.
2657
2658 2019-03-05  Tom Tromey  <tromey@adacore.com>
2659
2660         * remote.c (class scoped_remote_fd) <release>: Add
2661         ATTRIBUTE_UNUSED_RESULT.
2662
2663 2019-03-05  Tom Tromey  <tromey@adacore.com>
2664
2665         * macroexp.c (struct macro_buffer) <release>: Add
2666         ATTRIBUTE_UNUSED_RESULT.
2667
2668 2019-03-05  Tom Tromey  <tromey@adacore.com>
2669
2670         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
2671         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
2672         ATTRIBUTE_UNUSED_RESULT.
2673
2674 2019-03-05  Tom Tromey  <tromey@adacore.com>
2675
2676         * common/scoped_fd.h (class scoped_fd) <release>: Add
2677         ATTRIBUTE_UNUSED_RESULT.
2678
2679 2019-03-05  Tom Tromey  <tromey@adacore.com>
2680
2681         * parser-defs.h (struct parser_state) <release>: Add
2682         ATTRIBUTE_UNUSED_RESULT.
2683
2684 2019-03-05  Tom Tromey  <tromey@adacore.com>
2685
2686         * utils.h (class gdb_argv) <release>: Add
2687         ATTRIBUTE_UNUSED_RESULT.
2688         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
2689
2690 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
2691
2692         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
2693         for-loop range, to avoid compiler warnings.
2694
2695         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
2696         avoid compiler warnings about unused variables.
2697
2698         * NEWS: Mention end of support for native debugging on MS-Windows
2699         before XP.
2700
2701         PR gdb/24292
2702         * common/netstuff.c:
2703         * gdbserver/gdbreplay.c
2704         * gdbserver/remote-utils.c:
2705         * ser-tcp.c:
2706         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
2707         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
2708         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
2709         'getaddrinfo' and 'freeaddrinfo' were not available before
2710         Windows XP, and mingw.org's MinGW headers by default define
2711         _WIN32_WINNT to 0x500.
2712
2713 2019-03-01  Gary Benson <gbenson@redhat.com>
2714
2715         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
2716
2717 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
2718             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2719
2720         PR gdb/8527
2721         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
2722         set_sigint_trap, clear_sigint_trap.
2723
2724 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2725
2726         * target.c (target_detach): Clear the regcache and the
2727         frame cache.
2728
2729 2019-02-27  Pedro Alves  <palves@redhat.com>
2730
2731         * utils.c (set_screen_size): When we cap the height/width sizes,
2732         tweak the corresponding command variable to show "unlimited":
2733
2734 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
2735             Pedro Alves  <palves@redhat.com>
2736
2737         * utils.c (set_screen_size): Reduce "infinite" rows and columns
2738         before calling rl_set_screen_size.
2739
2740 2019-02-27  Tom Tromey  <tromey@adacore.com>
2741
2742         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
2743         define.
2744         * python/py-value.c: Remove Python 2.4 workaround.
2745         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
2746         workaround.
2747         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
2748         Python 2.4 workaround.
2749         * python/python-internal.h: Remove Python 2.4 comment.
2750         (Py_ssize_t): Don't define.
2751         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
2752         (gdb_Py_DECREF): Remove Python 2.4 workaround.
2753         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
2754         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
2755         * python/python.c (do_start_initialization): Remove Python 2.4
2756         workaround.
2757         * python/py-prettyprint.c (class dummy_python_frame): Remove.
2758         (print_children): Remove Python 2.4 workaround.
2759         * python/py-inferior.c (buffer_procs): Remove Python 2.4
2760         workaround.
2761         (CHARBUFFERPROC_NAME): Remove.
2762         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
2763         Python 2.4 workaround.
2764
2765 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
2766
2767         * NEWS: Note minimum Python version.
2768
2769 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
2770
2771         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
2772         code from these functions.  Remove corresponding ifdefs.  Use
2773         Py_buffer_up instead of explicit calls to PyBuffer_Release.
2774         Remove gotos and target of gotos.
2775         (infpy_search_memory): Likewise.
2776
2777 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2778
2779         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
2780         (hppa_gdbarch_init): Don't register deleted functions with
2781         gdbarch.
2782
2783 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2784
2785         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
2786         (h8300_unwind_sp): Delete.
2787         (h8300_dummy_id): Delete.
2788         (h8300_gdbarch_init): Don't register deleted functions with
2789         gdbarch.
2790
2791 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2792
2793         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
2794         (ft32_unwind_pc): Delete.
2795         (ft32_unwind_sp): Delete.
2796         (ft32_gdbarch_init): Don't register deleted functions with
2797         gdbarch.
2798
2799 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2800
2801         * gdb/frv-tdep.c (frv_dummy_id): Delete.
2802         (frv_unwind_pc): Delete.
2803         (frv_unwind_sp): Delete.
2804         (frv_gdbarch_init): Don't register deleted functions with
2805         gdbarch.
2806
2807 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2808
2809         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
2810         (riscv_unwind_pc): Delete.
2811         (riscv_unwind_sp): Delete.
2812         (riscv_gdbarch_init): Don't register deleted functions with
2813         gdbarch.
2814
2815 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2816
2817         * gdb/csky-tdep.c (csky_dummy_id): Delete.
2818         (csky_unwind_pc): Delete.
2819         (csky_unwind_sp): Delete.
2820         (csky_gdbarch_init): Don't register deleted functions with
2821         gdbarch.
2822
2823 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2824
2825         * gdb/cris-tdep.c (cris_dummy_id): Delete.
2826         (cris_unwind_pc): Delete.
2827         (cris_unwind_sp): Delete.
2828         (cris_gdbarch_init): Don't register deleted functions with
2829         gdbarch.
2830
2831 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2832
2833         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
2834         (bfin_unwind_pc): Delete.
2835         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
2836
2837 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2838
2839         * gdb/arm-tdep.c (arm_dummy_id): Delete.
2840         (arm_unwind_pc): Delete.
2841         (arm_unwind_sp): Delete.
2842         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
2843
2844 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2845
2846         * gdb/arc-tdep.c (arc_dummy_id): Delete.
2847         (arc_unwind_pc): Delete.
2848         (arc_unwind_sp): Delete.
2849         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
2850
2851 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2852
2853         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
2854         (alpha_unwind_pc): Delete.
2855         (alpha_gdbarch_init): Don't register deleted functions with
2856         gdbarch.
2857
2858 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2859
2860         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
2861         (aarch64_unwind_pc): Delete.
2862         (aarch64_unwind_sp): Delete.
2863         (aarch64_gdbarch_init): Don't register deleted functions with
2864         gdbarch.
2865
2866 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2867
2868         * gdbtypes.c (type_align): Don't consider static members when
2869         computing structure alignment.
2870
2871 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2872
2873         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
2874         return 0 for other types.
2875         * arch-utils.c (default_type_align): Always return 0.
2876         * gdbarch.h: Regenerate.
2877         * gdbarch.sh (type_align): Extend comment.
2878         * gdbtypes.c (type_align): Add additional comments, always call
2879         gdbarch_type_align before applying the default rules.
2880         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
2881         generic code will then apply a suitable default.
2882         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
2883         types, return 0 for other types.
2884
2885 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
2886
2887         * NEWS: Create a new section for the next release branch.
2888         Rename the section of the current branch, now that it has
2889         been cut.
2890
2891 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
2892
2893         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
2894         * version.in: Bump version to 8.3.50.DATE-git.
2895
2896 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
2897
2898         * aix-thread.c (ptid_cmp): Remove unused variable.
2899         (get_signaled_thread): Likewise.
2900         (store_regs_user_thread): Likewise.
2901         (store_regs_kernel_thread): Likewise.
2902         (fetch_regs_kernel_thread): Remove shadowed variable.
2903
2904 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2905
2906         * features/riscv/32bit-cpu.xml: Add register numbers.
2907         * features/riscv/32bit-fpu.c: Regenerate.
2908         * features/riscv/32bit-fpu.xml: Add register numbers.
2909         * features/riscv/64bit-cpu.xml: Add register numbers.
2910         * features/riscv/64bit-fpu.c: Regenerate.
2911         * features/riscv/64bit-fpu.xml: Add register numbers.
2912
2913 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
2914
2915         * NEWS: Mention two argument form of gdb.Value constructor.
2916         * python/py-value.c (convert_buffer_and_type_to_value): New
2917         function.
2918         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
2919         Add support for handling an optional second argument.  Call
2920         convert_buffer_and_type_to_value as appropriate.
2921         * python/python-internal.h (Py_buffer_deleter): New struct.
2922         (Py_buffer_up): New typedef.
2923
2924 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
2925
2926         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
2927         instead of releasing ownership.
2928
2929 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
2930
2931         * dwarf2read.c (open_and_init_dwp_file): Call
2932         elf_numsections instead of bfd_count_sections to initialize
2933         dwp_file->num_sections.
2934
2935 2019-02-25  Tom Tromey  <tromey@adacore.com>
2936
2937         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
2938
2939 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
2940
2941         * gcore.in: Add '--readnever' option when invoking GDB.
2942
2943 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
2944
2945         * MAINTAINERS: Update my email address.
2946
2947 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
2948
2949         * build-id.c (build_id_to_debug_bfd_1): New function.
2950         (build_id_to_debug_bfd): Look for separate debug file in
2951         sysroot.
2952
2953 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2954
2955         * gdbarch.sh: Update the copyright year range that is placed into
2956         generated files.
2957
2958 2019-02-22  Keith Seitz  <keiths@redhat.com>
2959
2960         PR symtab/23853
2961         * linespec.c (create_sals_line_offset): Search for the default
2962         symtab's filename instead of its fullname.
2963
2964 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
2965
2966         * NEWS: Update style defaults.
2967
2968 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
2969
2970         * main.c (captured_main_1): Disable styling in batch mode.
2971
2972 2019-02-20  Tom Tromey  <tom@tromey.com>
2973
2974         * symtab.c (symtab_symbol_info): Fix typos.
2975
2976 2019-02-20  Tom Tromey  <tromey@adacore.com>
2977
2978         * findcmd.c (_initialize_mem_search): Use upper case for
2979         metasyntactic variables.
2980
2981 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
2982
2983         * aarch64-tdep.c (aarch64_add_reggroups): New function.
2984         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
2985
2986 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
2987
2988         * top.h (source_file_name): Change to std::string.
2989         * top.c (source_file_name): Likewise.
2990         (command_line_input): Adjust.
2991         * cli/cli-script.c (script_from_file): Adjust.
2992
2993 2019-02-19  Tom Tromey  <tromey@adacore.com>
2994
2995         * ravenscar-thread.c
2996         (ravenscar_thread_target::update_thread_list): Don't call
2997         ada_build_task_list.
2998         * ada-lang.h (ada_build_task_list): Don't declare.
2999         * ada-tasks.c (struct ada_tasks_inferior_data)
3000         <task_list_valid_p>: Now bool.
3001         (read_known_tasks, ada_task_list_changed)
3002         (ada_tasks_invalidate_inferior_data): Update.
3003         (read_known_tasks_array): Return bool.
3004         (read_known_tasks_list): Likewise.
3005         (read_known_tasks): Return void.
3006         (ada_build_task_list): Now static.
3007
3008 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3009
3010         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
3011         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
3012
3013 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3014
3015         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
3016         variant for ada_tasks_pspace_data_handle and
3017         ada_tasks_inferior_data_handle.
3018         (ada_tasks_pspace_data_cleanup): New function.
3019         (ada_tasks_inferior_data_cleanup): New function.
3020
3021 2019-02-17  Tom Tromey  <tom@tromey.com>
3022
3023         * macrotab.h (macro_source_fullname): Return a std::string.
3024         * macrotab.c (macro_include, check_for_redefinition)
3025         (macro_undef, macro_lookup_definition, foreach_macro)
3026         (foreach_macro_in_scope): Update.
3027         (macro_source_fullname): Return a std::string.
3028         * macrocmd.c (show_pp_source_pos): Update.
3029
3030 2019-02-17  Tom Tromey  <tom@tromey.com>
3031
3032         * macrocmd.c (show_pp_source_pos): Style the file names.
3033
3034 2019-02-17  Tom Tromey  <tom@tromey.com>
3035
3036         PR tui/24197:
3037         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
3038
3039 2019-02-17  Tom Tromey  <tom@tromey.com>
3040
3041         * ada-lang.c (user_select_syms): Use filtered printing.
3042         * utils.c (wrap_style): New global.
3043         (desired_style): Remove.
3044         (emit_style_escape): Add stream parameter.
3045         (set_output_style, reset_terminal_style, prompt_for_continue):
3046         Update.
3047         (flush_wrap_buffer): Only flush gdb_stdout.
3048         (wrap_here): Set wrap_style.
3049         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
3050         treat escape sequences as a character.  Change when wrap buffer is
3051         flushed.
3052         (fputs_styled): Do not set the output style when the default is
3053         requested.
3054         * ui-style.h (struct ui_file_style) <is_default>: New method.
3055         * source.c (print_source_lines_base): Emit escape sequences in one
3056         piece.
3057
3058 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3059
3060         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
3061         integers and enumeration types.
3062
3063 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3064
3065         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
3066         instead of lookup_symbol_in_language
3067         (do_exact_match): New function.
3068         (ada_get_symbol_name_matcher): Return do_exact_match when
3069         doing a verbatim match.
3070
3071 2019-02-15  Tom Tromey  <tromey@adacore.com>
3072
3073         * ravenscar-thread.c (ravenscar_thread_target::resume)
3074         (ravenscar_thread_target::wait): Special case wildcard requests.
3075
3076 2019-02-15  Tom Tromey  <tromey@adacore.com>
3077
3078         * ravenscar-thread.c (base_ptid): Remove.
3079         (struct ravenscar_thread_target) <close>: New method.
3080         <m_base_ptid>: New member.
3081         <update_inferior_ptid, active_task, task_is_currently_active,
3082         runtime_initialized>: Declare methods.
3083         <ravenscar_thread_target>: Add constructor.
3084         (ravenscar_thread_target::task_is_currently_active)
3085         (ravenscar_thread_target::update_inferior_ptid)
3086         (ravenscar_runtime_initialized): Rename.  Now methods.
3087         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
3088         (ravenscar_thread_target::update_thread_list): Update.
3089         (ravenscar_thread_target::active_task): Now method.
3090         (ravenscar_thread_target::store_registers)
3091         (ravenscar_thread_target::prepare_to_store)
3092         (ravenscar_thread_target::prepare_to_store)
3093         (ravenscar_thread_target::mourn_inferior): Update.
3094         (ravenscar_inferior_created): Use "new" to create target.
3095         (ravenscar_thread_target::get_ada_task_ptid): Update.
3096         (_initialize_ravenscar): Don't initialize base_ptid.
3097         (ravenscar_ops): Remove global.
3098
3099 2019-02-15  Tom Tromey  <tromey@adacore.com>
3100
3101         * target.h (push_target): Declare new overload.
3102         * target.c (push_target): New overload, taking an rvalue reference.
3103         * remote.c (remote_target::open_1): Use push_target overload.
3104         * corelow.c (core_target_open): Use push_target overload.
3105
3106 2019-02-15  Tom Tromey  <tromey@adacore.com>
3107
3108         * ravenscar-thread.c (is_ravenscar_task)
3109         (ravenscar_task_is_currently_active): Return bool.
3110         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
3111         (_initialize_ravenscar): Remove "(void)".
3112         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
3113         Return bool.
3114
3115 2019-02-15  Tom Tromey  <tromey@adacore.com>
3116
3117         * ravenscar-thread.c (ravenscar_runtime_initializer)
3118         (has_ravenscar_runtime, get_running_thread_id)
3119         (ravenscar_thread_target::resume): Fix indentation.
3120
3121 2019-02-15  Tom Tromey  <tromey@adacore.com>
3122
3123         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
3124         from ravenscar_arch_ops.
3125         (sparc_ravenscar_ops::fetch_registers)
3126         (sparc_ravenscar_ops::store_registers): Now methods.
3127         (sparc_ravenscar_prepare_to_store): Remove.
3128         (sparc_ravenscar_ops): Redefine.
3129         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
3130         methods and destructor.  Remove members.
3131         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
3132         (ravenscar_thread_target::store_registers)
3133         (ravenscar_thread_target::prepare_to_store): Update.
3134         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
3135         Remove.
3136         (struct ppc_ravenscar_powerpc_ops): Derive from
3137         ravenscar_arch_ops.
3138         (ppc_ravenscar_powerpc_ops::fetch_registers)
3139         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
3140         (ppc_ravenscar_powerpc_ops): Redefine.
3141         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
3142         (ppc_ravenscar_e500_ops::fetch_registers)
3143         (ppc_ravenscar_e500_ops::store_registers): Now methods.
3144         (ppc_ravenscar_e500_ops): Redefine.
3145         * aarch64-ravenscar-thread.c
3146         (aarch64_ravenscar_generic_prepare_to_store): Remove.
3147         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
3148         (aarch64_ravenscar_fetch_registers)
3149         (aarch64_ravenscar_store_registers): Now methods.
3150         (aarch64_ravenscar_ops): Redefine.
3151
3152 2019-02-15  Tom Tromey  <tromey@adacore.com>
3153
3154         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
3155         (ravenscar_thread_target::stopped_by_hw_breakpoint)
3156         (ravenscar_thread_target::stopped_by_watchpoint)
3157         (ravenscar_thread_target::stopped_data_address)
3158         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
3159
3160 2019-02-15  Tom Tromey  <tromey@adacore.com>
3161
3162         * ravenscar-thread.c: Fix some typos.
3163
3164 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3165             Tom Tromey  <tromey@adacore.com>
3166
3167         * ada-lang.c (ada_exception_sal): Change addr_string to a
3168         std::string.
3169         (create_ada_exception_catchpoint): Update.
3170
3171 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3172             Tom Tromey  <tromey@adacore.com>
3173
3174         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
3175         (bp_location_ops): Remove.
3176         (base_breakpoint_allocate_location): Update.
3177         (free_bp_location): Update.
3178         * ada-lang.c (class ada_catchpoint_location)
3179         <ada_catchpoint_location>: Remove ops parameter.
3180         (ada_catchpoint_location_dtor): Remove.
3181         (ada_catchpoint_location_ops): Remove.
3182         (allocate_location_exception): Update.
3183         * breakpoint.h (struct bp_location_ops): Remove.
3184         (class bp_location) <bp_location>: Remove bp_location_ops
3185         parameter.
3186         <~bp_location>: Add destructor.
3187         <ops>: Remove.
3188
3189 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3190             Pedro Alves  <palves@redhat.com>
3191
3192         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
3193         'PATH_MAX'.
3194
3195 2019-02-14  David Michael  <fedora.dm0@gmail.com>
3196             Samuel Thibault  <samuel.thibault@gnu.org>
3197             Thomas Schwinge  <thomas@codesourcery.com>
3198
3199         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
3200         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
3201
3202 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3203
3204         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
3205         (check_empty): Use "const char *".
3206
3207         * gnu-nat.c (gnu_nat_target::detach): Instead of
3208         'detach_inferior (pid)' call
3209         'detach_inferior (find_inferior_pid (pid))'.
3210
3211         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
3212         'nat/fork-inferior.o'.
3213         * gnu-nat.c: #include "nat/fork-inferior.h".
3214
3215         * gnu-nat.c (gnu_nat_target::detach): Instead of
3216         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
3217         * gnu-nat.h: #include "inf-child.h".
3218         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
3219         'i386_gnu_nat_target::fetch_registers'.
3220         (gnu_store_registers): Rename/move to
3221         'i386_gnu_nat_target::store_registers'.
3222
3223         * config/i386/nm-i386gnu.h: Don't "#include" any files.
3224         * gnu-nat.h (mach_thread_info): New function.
3225         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
3226
3227         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
3228
3229 2019-02-14  Frederic Konrad  <konrad@adacore.com>
3230
3231         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
3232
3233 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
3234
3235         * windows-nat.c (windows_add_thread): Add new parameter
3236         "main_thread_p" with default value set to false.  Update
3237         function documentation as well as all callers.
3238         (windows_delete_thread): Likewise.
3239         (fake_create_process): Update call to windows_add_thread.
3240         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
3241         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
3242         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
3243         call to windows_delete_thread.
3244
3245 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
3246
3247         * MAINTAINERS: Add Andrew Burgess as global maintainer.
3248
3249 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3250
3251         * symfile.c (find_separate_debug_file): Use canonical path of
3252         sysroot with child_path instead of gdb_sysroot if it is valid.
3253
3254 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3255
3256         * symfile.c (find_separate_debug_file): Use child_path to
3257         determine if an object file is under a sysroot.
3258
3259 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3260
3261         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
3262         unittests/child-path-selftests.c.
3263         * common/pathstuff.c (child_path): New function.
3264         * common/pathstuff.h (child_path): New prototype.
3265         * unittests/child-path-selftests.c: New file.
3266
3267 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3268
3269         * symfile.c (find_separate_debug_file): Look for separate debug
3270         files in debug directories under the sysroot.
3271
3272 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3273
3274         * symtab.h (struct minimal_symbol data_p): New const method.
3275         (struct minimal_symbol text_p): Likewise.
3276         * symtab.c (output_source_filename): Use file name style
3277         to print file name.
3278         (print_symbol_info): Likewise.
3279         (print_msymbol_info): Use address style to print addresses.
3280         Use function name style to print executable text symbols.
3281         (expand_symtab_containing_pc): Use data_p.
3282         (find_pc_sect_compunit_symtab): Likewise.
3283
3284 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3285
3286         * breakpoint.c (describe_other_breakpoints): Use address style
3287         to print addresses.
3288         (say_where): Likewise.
3289
3290 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3291
3292         * ada-typeprint.c (print_func_type): Print function name
3293         style to print function name.
3294         * c-typeprint.c (c_print_type_1): Likewise.
3295
3296 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
3297
3298         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
3299         for execve.
3300
3301 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3302
3303         * c-exp.y (direct_abs_decl): Use emplace_back to record the
3304         type_stack.
3305
3306 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
3307
3308         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
3309         TYPE_CODE_REF types.
3310
3311 2019-02-08  Jim Wilson  <jimw@sifive.com>
3312
3313         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
3314         (riscv_linux_fregset): New.
3315         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
3316
3317 2019-02-07  Tom Tromey  <tom@tromey.com>
3318
3319         * thread.c (thread_cancel_execution_command): Update.
3320         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
3321         methods.
3322         (struct thread_fsm_ops): Remove.
3323         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
3324         (thread_fsm_should_stop, thread_fsm_return_value)
3325         (thread_fsm_set_finished, thread_fsm_finished_p)
3326         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
3327         Don't declare.
3328         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
3329         * infrun.c (clear_proceed_status_thread)
3330         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
3331         (print_stop_event): Update.
3332         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
3333         Add constructor.
3334         (step_command_fsm_ops): Remove.
3335         (new_step_command_fsm): Remove.
3336         (step_1): Update.
3337         (step_command_fsm::should_stop): Rename from
3338         step_command_fsm_should_stop.
3339         (step_command_fsm::clean_up): Rename from
3340         step_command_fsm_clean_up.
3341         (step_command_fsm::do_async_reply_reason): Rename from
3342         step_command_fsm_async_reply_reason.
3343         (struct until_next_fsm): Inherit from thread_fsm.  Add
3344         constructor.
3345         (until_next_fsm_ops): Remove.
3346         (new_until_next_fsm): Remove.
3347         (until_next_fsm::should_stop): Rename from
3348         until_next_fsm_should_stop.
3349         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
3350         (until_next_fsm::do_async_reply_reason): Rename from
3351         until_next_fsm_async_reply_reason.
3352         (struct finish_command_fsm): Inherit from thread_fsm.  Add
3353         constructor.  Change type of breakpoint.
3354         (finish_command_fsm_ops): Remove.
3355         (new_finish_command_fsm): Remove.
3356         (finish_command_fsm::should_stop): Rename from
3357         finish_command_fsm_should_stop.
3358         (finish_command_fsm::clean_up): Rename from
3359         finish_command_fsm_clean_up.
3360         (finish_command_fsm::return_value): Rename from
3361         finish_command_fsm_return_value.
3362         (finish_command_fsm::do_async_reply_reason): Rename from
3363         finish_command_fsm_async_reply_reason.
3364         (finish_command): Update.
3365         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
3366         Add constructor.
3367         (call_thread_fsm_ops): Remove.
3368         (call_thread_fsm::call_thread_fsm): Rename from
3369         new_call_thread_fsm.
3370         (call_thread_fsm::should_stop): Rename from
3371         call_thread_fsm_should_stop.
3372         (call_thread_fsm::should_notify_stop): Rename from
3373         call_thread_fsm_should_notify_stop.
3374         (run_inferior_call, call_function_by_hand_dummy): Update.
3375         * cli/cli-interp.c (should_print_stop_to_console): Update.
3376         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
3377         Add constructor.  Change type of location_breakpoint,
3378         caller_breakpoint.
3379         (until_break_fsm_ops): Remove.
3380         (new_until_break_fsm): Remove.
3381         (until_break_fsm::should_stop): Rename from
3382         until_break_fsm_should_stop.
3383         (until_break_fsm::clean_up): Rename from
3384         until_break_fsm_clean_up.
3385         (until_break_fsm::do_async_reply_reason): Rename from
3386         until_break_fsm_async_reply_reason.
3387         (until_break_command): Update.
3388         * thread-fsm.c: Remove.
3389         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
3390
3391 2019-02-07  Tom Tromey  <tom@tromey.com>
3392
3393         * yy-remap.h: Add include guard.
3394         * xtensa-tdep.h: Add include guard.
3395         * xcoffread.h: Rename include guard.
3396         * varobj-iter.h: Add include guard.
3397         * tui/tui.h: Rename include guard.
3398         * tui/tui-winsource.h: Rename include guard.
3399         * tui/tui-wingeneral.h: Rename include guard.
3400         * tui/tui-windata.h: Rename include guard.
3401         * tui/tui-win.h: Rename include guard.
3402         * tui/tui-stack.h: Rename include guard.
3403         * tui/tui-source.h: Rename include guard.
3404         * tui/tui-regs.h: Rename include guard.
3405         * tui/tui-out.h: Rename include guard.
3406         * tui/tui-layout.h: Rename include guard.
3407         * tui/tui-io.h: Rename include guard.
3408         * tui/tui-hooks.h: Rename include guard.
3409         * tui/tui-file.h: Rename include guard.
3410         * tui/tui-disasm.h: Rename include guard.
3411         * tui/tui-data.h: Rename include guard.
3412         * tui/tui-command.h: Rename include guard.
3413         * tic6x-tdep.h: Add include guard.
3414         * target/waitstatus.h: Rename include guard.
3415         * target/wait.h: Rename include guard.
3416         * target/target.h: Rename include guard.
3417         * target/resume.h: Rename include guard.
3418         * target-float.h: Rename include guard.
3419         * stabsread.h: Add include guard.
3420         * rs6000-tdep.h: Add include guard.
3421         * riscv-fbsd-tdep.h: Add include guard.
3422         * regformats/regdef.h: Rename include guard.
3423         * record.h: Rename include guard.
3424         * python/python.h: Rename include guard.
3425         * python/python-internal.h: Rename include guard.
3426         * python/py-stopevent.h: Rename include guard.
3427         * python/py-ref.h: Rename include guard.
3428         * python/py-record.h: Rename include guard.
3429         * python/py-record-full.h: Rename include guard.
3430         * python/py-record-btrace.h: Rename include guard.
3431         * python/py-instruction.h: Rename include guard.
3432         * python/py-events.h: Rename include guard.
3433         * python/py-event.h: Rename include guard.
3434         * procfs.h: Add include guard.
3435         * proc-utils.h: Add include guard.
3436         * p-lang.h: Add include guard.
3437         * or1k-tdep.h: Rename include guard.
3438         * observable.h: Rename include guard.
3439         * nto-tdep.h: Rename include guard.
3440         * nat/x86-linux.h: Rename include guard.
3441         * nat/x86-linux-dregs.h: Rename include guard.
3442         * nat/x86-gcc-cpuid.h: Add include guard.
3443         * nat/x86-dregs.h: Rename include guard.
3444         * nat/x86-cpuid.h: Rename include guard.
3445         * nat/ppc-linux.h: Rename include guard.
3446         * nat/mips-linux-watch.h: Rename include guard.
3447         * nat/linux-waitpid.h: Rename include guard.
3448         * nat/linux-ptrace.h: Rename include guard.
3449         * nat/linux-procfs.h: Rename include guard.
3450         * nat/linux-osdata.h: Rename include guard.
3451         * nat/linux-nat.h: Rename include guard.
3452         * nat/linux-namespaces.h: Rename include guard.
3453         * nat/linux-btrace.h: Rename include guard.
3454         * nat/glibc_thread_db.h: Rename include guard.
3455         * nat/gdb_thread_db.h: Rename include guard.
3456         * nat/gdb_ptrace.h: Rename include guard.
3457         * nat/fork-inferior.h: Rename include guard.
3458         * nat/amd64-linux-siginfo.h: Rename include guard.
3459         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
3460         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
3461         * nat/aarch64-linux.h: Rename include guard.
3462         * nat/aarch64-linux-hw-point.h: Rename include guard.
3463         * mn10300-tdep.h: Add include guard.
3464         * mips-linux-tdep.h: Add include guard.
3465         * mi/mi-parse.h: Rename include guard.
3466         * mi/mi-out.h: Rename include guard.
3467         * mi/mi-main.h: Rename include guard.
3468         * mi/mi-interp.h: Rename include guard.
3469         * mi/mi-getopt.h: Rename include guard.
3470         * mi/mi-console.h: Rename include guard.
3471         * mi/mi-common.h: Rename include guard.
3472         * mi/mi-cmds.h: Rename include guard.
3473         * mi/mi-cmd-break.h: Rename include guard.
3474         * m2-lang.h: Add include guard.
3475         * location.h: Rename include guard.
3476         * linux-record.h: Rename include guard.
3477         * linux-nat.h: Add include guard.
3478         * linux-fork.h: Add include guard.
3479         * i386-darwin-tdep.h: Rename include guard.
3480         * hppa-linux-offsets.h: Add include guard.
3481         * guile/guile.h: Rename include guard.
3482         * guile/guile-internal.h: Rename include guard.
3483         * gnu-nat.h: Rename include guard.
3484         * gdb-stabs.h: Rename include guard.
3485         * frv-tdep.h: Add include guard.
3486         * f-lang.h: Add include guard.
3487         * event-loop.h: Add include guard.
3488         * darwin-nat.h: Rename include guard.
3489         * cp-abi.h: Rename include guard.
3490         * config/sparc/nm-sol2.h: Rename include guard.
3491         * config/nm-nto.h: Rename include guard.
3492         * config/nm-linux.h: Add include guard.
3493         * config/i386/nm-i386gnu.h: Rename include guard.
3494         * config/djgpp/nl_types.h: Rename include guard.
3495         * config/djgpp/langinfo.h: Rename include guard.
3496         * compile/gcc-cp-plugin.h: Add include guard.
3497         * compile/gcc-c-plugin.h: Add include guard.
3498         * compile/compile.h: Rename include guard.
3499         * compile/compile-object-run.h: Rename include guard.
3500         * compile/compile-object-load.h: Rename include guard.
3501         * compile/compile-internal.h: Rename include guard.
3502         * compile/compile-cplus.h: Rename include guard.
3503         * compile/compile-c.h: Rename include guard.
3504         * common/xml-utils.h: Rename include guard.
3505         * common/x86-xstate.h: Rename include guard.
3506         * common/version.h: Rename include guard.
3507         * common/vec.h: Rename include guard.
3508         * common/tdesc.h: Rename include guard.
3509         * common/selftest.h: Rename include guard.
3510         * common/scoped_restore.h: Rename include guard.
3511         * common/scoped_mmap.h: Rename include guard.
3512         * common/scoped_fd.h: Rename include guard.
3513         * common/safe-iterator.h: Rename include guard.
3514         * common/run-time-clock.h: Rename include guard.
3515         * common/refcounted-object.h: Rename include guard.
3516         * common/queue.h: Rename include guard.
3517         * common/ptid.h: Rename include guard.
3518         * common/print-utils.h: Rename include guard.
3519         * common/preprocessor.h: Rename include guard.
3520         * common/pathstuff.h: Rename include guard.
3521         * common/observable.h: Rename include guard.
3522         * common/netstuff.h: Rename include guard.
3523         * common/job-control.h: Rename include guard.
3524         * common/host-defs.h: Rename include guard.
3525         * common/gdb_wait.h: Rename include guard.
3526         * common/gdb_vecs.h: Rename include guard.
3527         * common/gdb_unlinker.h: Rename include guard.
3528         * common/gdb_unique_ptr.h: Rename include guard.
3529         * common/gdb_tilde_expand.h: Rename include guard.
3530         * common/gdb_sys_time.h: Rename include guard.
3531         * common/gdb_string_view.h: Rename include guard.
3532         * common/gdb_splay_tree.h: Rename include guard.
3533         * common/gdb_setjmp.h: Rename include guard.
3534         * common/gdb_ref_ptr.h: Rename include guard.
3535         * common/gdb_optional.h: Rename include guard.
3536         * common/gdb_locale.h: Rename include guard.
3537         * common/gdb_assert.h: Rename include guard.
3538         * common/filtered-iterator.h: Rename include guard.
3539         * common/filestuff.h: Rename include guard.
3540         * common/fileio.h: Rename include guard.
3541         * common/environ.h: Rename include guard.
3542         * common/common-utils.h: Rename include guard.
3543         * common/common-types.h: Rename include guard.
3544         * common/common-regcache.h: Rename include guard.
3545         * common/common-inferior.h: Rename include guard.
3546         * common/common-gdbthread.h: Rename include guard.
3547         * common/common-exceptions.h: Rename include guard.
3548         * common/common-defs.h: Rename include guard.
3549         * common/common-debug.h: Rename include guard.
3550         * common/cleanups.h: Rename include guard.
3551         * common/buffer.h: Rename include guard.
3552         * common/btrace-common.h: Rename include guard.
3553         * common/break-common.h: Rename include guard.
3554         * cli/cli-utils.h: Rename include guard.
3555         * cli/cli-style.h: Rename include guard.
3556         * cli/cli-setshow.h: Rename include guard.
3557         * cli/cli-script.h: Rename include guard.
3558         * cli/cli-interp.h: Rename include guard.
3559         * cli/cli-decode.h: Rename include guard.
3560         * cli/cli-cmds.h: Rename include guard.
3561         * charset-list.h: Add include guard.
3562         * buildsym-legacy.h: Rename include guard.
3563         * bfin-tdep.h: Add include guard.
3564         * ax.h: Rename include guard.
3565         * arm-linux-tdep.h: Add include guard.
3566         * arm-fbsd-tdep.h: Add include guard.
3567         * arch/xtensa.h: Rename include guard.
3568         * arch/tic6x.h: Add include guard.
3569         * arch/i386.h: Add include guard.
3570         * arch/arm.h: Rename include guard.
3571         * arch/arm-linux.h: Rename include guard.
3572         * arch/arm-get-next-pcs.h: Rename include guard.
3573         * arch/amd64.h: Add include guard.
3574         * arch/aarch64-insn.h: Rename include guard.
3575         * arch-utils.h: Rename include guard.
3576         * annotate.h: Add include guard.
3577         * amd64-darwin-tdep.h: Rename include guard.
3578         * aarch64-linux-tdep.h: Add include guard.
3579         * aarch64-fbsd-tdep.h: Add include guard.
3580         * aarch32-linux-nat.h: Add include guard.
3581
3582 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3583
3584         * macrotab.c (macro_define_internal): New function that
3585         factorizes macro_define_object_internal and macro_define_function
3586         code.
3587         (macro_define_object_internal): Use macro_define_internal.
3588         (macro_define_function): Likewise.
3589
3590 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3591
3592         * macrocmd.c (extract_identifier): Return
3593         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
3594         callers.
3595
3596 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
3597
3598         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
3599
3600 2019-02-05  Tom Tromey  <tom@tromey.com>
3601
3602         * target.c (target_stack::unpush): Move assertion earlier.
3603
3604 2019-01-30  Tom Tromey  <tom@tromey.com>
3605
3606         PR python/23615:
3607         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
3608         (gdbpy_parse_and_eval): Likewise.
3609         * python/python-internal.h (gdbpy_allow_threads): New class.
3610
3611 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
3612
3613         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
3614         (aarch64_fbsd_fpregmap): Move earlier.
3615         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
3616         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3617         instead of individual calls to trad_frame_set_reg_addr.
3618         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
3619         earlier.
3620         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
3621         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3622         instead of individual calls to trad_frame_set_reg_addr.
3623
3624 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
3625
3626         * CONTRIBUTE: Replace contribution list with wiki link.
3627
3628 2019-01-25  Tom Tromey  <tom@tromey.com>
3629
3630         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
3631
3632 2019-01-25  Tom Tromey  <tom@tromey.com>
3633
3634         * xtensa-linux-nat.c: Fix common/ includes.
3635         * xml-support.h: Fix common/ includes.
3636         * xml-support.c: Fix common/ includes.
3637         * x86-linux-nat.c: Fix common/ includes.
3638         * windows-nat.c: Fix common/ includes.
3639         * varobj.h: Fix common/ includes.
3640         * varobj.c: Fix common/ includes.
3641         * value.c: Fix common/ includes.
3642         * valops.c: Fix common/ includes.
3643         * utils.c: Fix common/ includes.
3644         * unittests/xml-utils-selftests.c: Fix common/ includes.
3645         * unittests/utils-selftests.c: Fix common/ includes.
3646         * unittests/unpack-selftests.c: Fix common/ includes.
3647         * unittests/tracepoint-selftests.c: Fix common/ includes.
3648         * unittests/style-selftests.c: Fix common/ includes.
3649         * unittests/string_view-selftests.c: Fix common/ includes.
3650         * unittests/scoped_restore-selftests.c: Fix common/ includes.
3651         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
3652         * unittests/scoped_fd-selftests.c: Fix common/ includes.
3653         * unittests/rsp-low-selftests.c: Fix common/ includes.
3654         * unittests/parse-connection-spec-selftests.c: Fix common/
3655         includes.
3656         * unittests/optional-selftests.c: Fix common/ includes.
3657         * unittests/offset-type-selftests.c: Fix common/ includes.
3658         * unittests/observable-selftests.c: Fix common/ includes.
3659         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
3660         * unittests/memrange-selftests.c: Fix common/ includes.
3661         * unittests/memory-map-selftests.c: Fix common/ includes.
3662         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
3663         * unittests/function-view-selftests.c: Fix common/ includes.
3664         * unittests/environ-selftests.c: Fix common/ includes.
3665         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
3666         * unittests/common-utils-selftests.c: Fix common/ includes.
3667         * unittests/cli-utils-selftests.c: Fix common/ includes.
3668         * unittests/array-view-selftests.c: Fix common/ includes.
3669         * ui-file.c: Fix common/ includes.
3670         * tui/tui-io.c: Fix common/ includes.
3671         * tracepoint.h: Fix common/ includes.
3672         * tracepoint.c: Fix common/ includes.
3673         * tracefile-tfile.c: Fix common/ includes.
3674         * top.h: Fix common/ includes.
3675         * top.c: Fix common/ includes.
3676         * thread.c: Fix common/ includes.
3677         * target/waitstatus.h: Fix common/ includes.
3678         * target/waitstatus.c: Fix common/ includes.
3679         * target.h: Fix common/ includes.
3680         * target.c: Fix common/ includes.
3681         * target-memory.c: Fix common/ includes.
3682         * target-descriptions.c: Fix common/ includes.
3683         * symtab.h: Fix common/ includes.
3684         * symfile.c: Fix common/ includes.
3685         * stap-probe.c: Fix common/ includes.
3686         * spu-linux-nat.c: Fix common/ includes.
3687         * sparc-nat.c: Fix common/ includes.
3688         * source.c: Fix common/ includes.
3689         * solib.c: Fix common/ includes.
3690         * solib-target.c: Fix common/ includes.
3691         * ser-unix.c: Fix common/ includes.
3692         * ser-tcp.c: Fix common/ includes.
3693         * ser-pipe.c: Fix common/ includes.
3694         * ser-base.c: Fix common/ includes.
3695         * selftest-arch.c: Fix common/ includes.
3696         * s12z-tdep.c: Fix common/ includes.
3697         * rust-exp.y: Fix common/ includes.
3698         * rs6000-aix-tdep.c: Fix common/ includes.
3699         * riscv-tdep.c: Fix common/ includes.
3700         * remote.c: Fix common/ includes.
3701         * remote-notif.h: Fix common/ includes.
3702         * remote-fileio.h: Fix common/ includes.
3703         * remote-fileio.c: Fix common/ includes.
3704         * regcache.h: Fix common/ includes.
3705         * regcache.c: Fix common/ includes.
3706         * record-btrace.c: Fix common/ includes.
3707         * python/python.c: Fix common/ includes.
3708         * python/py-type.c: Fix common/ includes.
3709         * python/py-inferior.c: Fix common/ includes.
3710         * progspace.h: Fix common/ includes.
3711         * producer.c: Fix common/ includes.
3712         * procfs.c: Fix common/ includes.
3713         * proc-api.c: Fix common/ includes.
3714         * printcmd.c: Fix common/ includes.
3715         * ppc-linux-nat.c: Fix common/ includes.
3716         * parser-defs.h: Fix common/ includes.
3717         * osdata.c: Fix common/ includes.
3718         * obsd-nat.c: Fix common/ includes.
3719         * nat/x86-linux.c: Fix common/ includes.
3720         * nat/x86-linux-dregs.c: Fix common/ includes.
3721         * nat/x86-dregs.h: Fix common/ includes.
3722         * nat/x86-dregs.c: Fix common/ includes.
3723         * nat/ppc-linux.c: Fix common/ includes.
3724         * nat/mips-linux-watch.h: Fix common/ includes.
3725         * nat/mips-linux-watch.c: Fix common/ includes.
3726         * nat/linux-waitpid.c: Fix common/ includes.
3727         * nat/linux-ptrace.h: Fix common/ includes.
3728         * nat/linux-ptrace.c: Fix common/ includes.
3729         * nat/linux-procfs.c: Fix common/ includes.
3730         * nat/linux-personality.c: Fix common/ includes.
3731         * nat/linux-osdata.c: Fix common/ includes.
3732         * nat/linux-namespaces.c: Fix common/ includes.
3733         * nat/linux-btrace.h: Fix common/ includes.
3734         * nat/linux-btrace.c: Fix common/ includes.
3735         * nat/fork-inferior.c: Fix common/ includes.
3736         * nat/amd64-linux-siginfo.c: Fix common/ includes.
3737         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
3738         * nat/aarch64-linux.c: Fix common/ includes.
3739         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
3740         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
3741         * namespace.h: Fix common/ includes.
3742         * mips-linux-tdep.c: Fix common/ includes.
3743         * minsyms.c: Fix common/ includes.
3744         * mi/mi-parse.h: Fix common/ includes.
3745         * mi/mi-main.c: Fix common/ includes.
3746         * mi/mi-cmd-env.c: Fix common/ includes.
3747         * memrange.h: Fix common/ includes.
3748         * memattr.c: Fix common/ includes.
3749         * maint.h: Fix common/ includes.
3750         * maint.c: Fix common/ includes.
3751         * main.c: Fix common/ includes.
3752         * machoread.c: Fix common/ includes.
3753         * location.c: Fix common/ includes.
3754         * linux-thread-db.c: Fix common/ includes.
3755         * linux-nat.c: Fix common/ includes.
3756         * linux-fork.c: Fix common/ includes.
3757         * inline-frame.c: Fix common/ includes.
3758         * infrun.c: Fix common/ includes.
3759         * inflow.c: Fix common/ includes.
3760         * inferior.h: Fix common/ includes.
3761         * inferior.c: Fix common/ includes.
3762         * infcmd.c: Fix common/ includes.
3763         * inf-ptrace.c: Fix common/ includes.
3764         * inf-child.c: Fix common/ includes.
3765         * ia64-linux-nat.c: Fix common/ includes.
3766         * i387-tdep.c: Fix common/ includes.
3767         * i386-tdep.c: Fix common/ includes.
3768         * i386-linux-tdep.c: Fix common/ includes.
3769         * i386-linux-nat.c: Fix common/ includes.
3770         * i386-go32-tdep.c: Fix common/ includes.
3771         * i386-fbsd-tdep.c: Fix common/ includes.
3772         * i386-fbsd-nat.c: Fix common/ includes.
3773         * guile/scm-type.c: Fix common/ includes.
3774         * guile/guile.c: Fix common/ includes.
3775         * go32-nat.c: Fix common/ includes.
3776         * gnu-nat.c: Fix common/ includes.
3777         * gdbthread.h: Fix common/ includes.
3778         * gdbarch-selftests.c: Fix common/ includes.
3779         * gdb_usleep.c: Fix common/ includes.
3780         * gdb_select.h: Fix common/ includes.
3781         * gdb_bfd.c: Fix common/ includes.
3782         * gcore.c: Fix common/ includes.
3783         * fork-child.c: Fix common/ includes.
3784         * findvar.c: Fix common/ includes.
3785         * fbsd-nat.c: Fix common/ includes.
3786         * event-top.c: Fix common/ includes.
3787         * event-loop.c: Fix common/ includes.
3788         * dwarf2read.c: Fix common/ includes.
3789         * dwarf2loc.c: Fix common/ includes.
3790         * dwarf2-frame.c: Fix common/ includes.
3791         * dwarf-index-cache.c: Fix common/ includes.
3792         * dtrace-probe.c: Fix common/ includes.
3793         * disasm-selftests.c: Fix common/ includes.
3794         * defs.h: Fix common/ includes.
3795         * csky-tdep.c: Fix common/ includes.
3796         * cp-valprint.c: Fix common/ includes.
3797         * cp-support.h: Fix common/ includes.
3798         * cp-support.c: Fix common/ includes.
3799         * corelow.c: Fix common/ includes.
3800         * completer.h: Fix common/ includes.
3801         * completer.c: Fix common/ includes.
3802         * compile/compile.c: Fix common/ includes.
3803         * compile/compile-loc2c.c: Fix common/ includes.
3804         * compile/compile-cplus-types.c: Fix common/ includes.
3805         * compile/compile-cplus-symbols.c: Fix common/ includes.
3806         * command.h: Fix common/ includes.
3807         * cli/cli-dump.c: Fix common/ includes.
3808         * cli/cli-cmds.c: Fix common/ includes.
3809         * charset.c: Fix common/ includes.
3810         * build-id.c: Fix common/ includes.
3811         * btrace.h: Fix common/ includes.
3812         * btrace.c: Fix common/ includes.
3813         * breakpoint.h: Fix common/ includes.
3814         * breakpoint.c: Fix common/ includes.
3815         * ax.h:
3816         (enum agent_op): Fix common/ includes.
3817         * ax-general.c (struct aop_map): Fix common/ includes.
3818         * ax-gdb.c: Fix common/ includes.
3819         * auxv.c: Fix common/ includes.
3820         * auto-load.c: Fix common/ includes.
3821         * arm-tdep.c: Fix common/ includes.
3822         * arch/riscv.c: Fix common/ includes.
3823         * arch/ppc-linux-common.c: Fix common/ includes.
3824         * arch/i386.c: Fix common/ includes.
3825         * arch/arm.c: Fix common/ includes.
3826         * arch/arm-linux.c: Fix common/ includes.
3827         * arch/arm-get-next-pcs.c: Fix common/ includes.
3828         * arch/amd64.c: Fix common/ includes.
3829         * arch/aarch64.c: Fix common/ includes.
3830         * arch/aarch64-insn.c: Fix common/ includes.
3831         * arch-utils.c: Fix common/ includes.
3832         * amd64-windows-tdep.c: Fix common/ includes.
3833         * amd64-tdep.c: Fix common/ includes.
3834         * amd64-sol2-tdep.c: Fix common/ includes.
3835         * amd64-obsd-tdep.c: Fix common/ includes.
3836         * amd64-nbsd-tdep.c: Fix common/ includes.
3837         * amd64-linux-tdep.c: Fix common/ includes.
3838         * amd64-linux-nat.c: Fix common/ includes.
3839         * amd64-fbsd-tdep.c: Fix common/ includes.
3840         * amd64-fbsd-nat.c: Fix common/ includes.
3841         * amd64-dicos-tdep.c: Fix common/ includes.
3842         * amd64-darwin-tdep.c: Fix common/ includes.
3843         * agent.c: Fix common/ includes.
3844         * ada-lang.h: Fix common/ includes.
3845         * ada-lang.c: Fix common/ includes.
3846         * aarch64-tdep.c: Fix common/ includes.
3847
3848 2019-01-25  Tom Tromey  <tom@tromey.com>
3849
3850         * common/create-version.sh: Use common/version.h.
3851
3852 2019-01-24  Pedro Alves  <palves@redhat.com>
3853
3854         * infrun.c (signal_stop, signal_print, signal_program)
3855         (signal_catch, signal_pass): Now arrays instead of pointers.
3856         (update_signals_program_target, do_target_resume)
3857         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
3858         * linux-nat.c (linux_nat_target::pass_signals)
3859         (linux_nat_target::create_inferior, linux_nat_target::attach):
3860         Adjust.
3861         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
3862         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
3863         * procfs.c (procfs_target::pass_signals): Adjust.
3864         * record-full.c (record_full_target::resume): Adjust.
3865         * remote.c (remote_target::pass_signals)
3866         (remote_target::program_signals): Adjust.
3867         * target-debug.h (target_debug_print_signals): Now takes a
3868         gdb::array_view as parameter.  Adjust.
3869         * target.h (target_ops) <pass_signals, program_signals>: Replace
3870         pointer and length parameters with gdb::array_view.
3871         (target_pass_signals, target_program_signals): Likewise.
3872         * target-delegates.c: Regenerate.
3873
3874 2019-01-24  Pedro Alves  <palves@redhat.com>
3875
3876         * common/forward-scope-exit.h
3877         (forward_scope_exit::forward_scope_exit): Pass arguments to
3878         m_bind_function directly, instead of creating a std::bind and
3879         copying that.
3880
3881 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
3882
3883         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
3884         for static members.
3885         (pass_in_v_vfp_candidate): Likewise.
3886
3887 2019-01-23  Tom Tromey  <tom@tromey.com>
3888             Pedro Alves  <palves@redhat.com>
3889
3890         * regcache.c (class regcache_invalidator): Remove.
3891         (regcache::raw_write): Use make_scope_exit.
3892
3893 2019-01-23  Tom Tromey  <tom@tromey.com>
3894
3895         * ui-out.h (class ui_out_emit_type): Update comment.
3896
3897 2019-01-23  Tom Tromey  <tom@tromey.com>
3898
3899         * infrun.c (fetch_inferior_event): Update comment.
3900
3901 2019-01-23  Tom Tromey  <tom@tromey.com>
3902             Pedro Alves  <palves@redhat.com>
3903
3904         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
3905         parameter.
3906         (fetch_inferior_event): Use SCOPE_EXIT.
3907
3908
3909 2019-01-23  Tom Tromey  <tom@tromey.com>
3910             Pedro Alves  <palves@redhat.com>
3911
3912         * infrun.c (disable_thread_events): Delete.
3913         (stop_all_threads): Use SCOPE_EXIT.
3914
3915 2019-01-23  Tom Tromey  <tom@tromey.com>
3916             Pedro Alves  <palves@redhat.com>
3917
3918         * symfile.c: Include forward-scope-exit.h.
3919         (clear_symtab_users_cleanup): Replace forward declaration with
3920         a FORWARD_SCOPE_EXIT.
3921         (syms_from_objfile_1): Use the forward_scope_exit and
3922         gdb::optional instead of cleanup_function.
3923         (reread_symbols): Use the forward_scope_exit instead of
3924         cleanup_function.
3925         (clear_symtab_users_cleanup): Remove function.
3926
3927 2019-01-23  Tom Tromey  <tom@tromey.com>
3928             Pedro Alves  <palves@redhat.com>
3929
3930         * linux-nat.c: Include scope-exit.h.
3931         (cleanup_target_stop): Remove.
3932         (linux_nat_target::static_tracepoint_markers_by_strid): Use
3933         SCOPE_EXIT.
3934
3935 2019-01-23  Tom Tromey  <tom@tromey.com>
3936             Pedro Alves  <palves@redhat.com>
3937
3938         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
3939         (call_function_by_hand_dummy): Use SCOPE_EXIT.
3940
3941 2019-01-23  Tom Tromey  <tom@tromey.com>
3942             Andrew Burgess  <andrew.burgess@embecosm.com>
3943             Pedro Alves  <palves@redhat.com>
3944
3945         * infrun.c (fetch_inferior_event): Use scope_exit.
3946         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
3947         * top.c (execute_command): Use scope_exit.
3948         * breakpoint.c (bpstat_do_actions): Use scope_exit.
3949         * utils.c (do_bpstat_clear_actions_cleanup)
3950         (make_bpstat_clear_actions_cleanup): Remove.
3951
3952 2019-01-23  Tom Tromey  <tom@tromey.com>
3953             Pedro Alves  <palves@redhat.com>
3954
3955         * infrun.c: Include "common/scope-exit.h"
3956         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
3957         (wait_for_inferior): Use SCOPE_EXIT.
3958         (fetch_inferior_event): Use scope_exit.
3959
3960 2019-01-23  Tom Tromey  <tom@tromey.com>
3961             Pedro Alves  <palves@redhat.com>
3962
3963         * breakpoint.c (create_breakpoint): Remove cleanup.
3964
3965 2019-01-23  Tom Tromey  <tom@tromey.com>
3966             Andrew Burgess  <andrew.burgess@embecosm.com>
3967             Pedro Alves  <palves@redhat.com>
3968
3969 2019-01-23  Pedro Alves  <palves@redhat.com>
3970
3971         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
3972
3973 2019-01-23  Pedro Alves  <palves@redhat.com>
3974             Andrew Burgess  <andrew.burgess@embecosm.com>
3975
3976         * gdbthread.h: Include "common/forward-scope-exit.h".
3977         (scoped_finish_thread_state): Redefine custom class in terms of
3978         forward_scope_exit.
3979
3980 2019-01-23  Pedro Alves  <palves@redhat.com>
3981             Andrew Burgess  <andrew.burgess@embecosm.com>
3982
3983         * common/forward-scope-exit.h: New file.
3984
3985 2019-01-23  Pedro Alves  <palves@redhat.com>
3986             Andrew Burgess  <andrew.burgess@embecosm.com>
3987             Tom Tromey  <tom@tromey.com>
3988
3989         * common/scope-exit.h: New file.
3990
3991 2019-01-23  Pedro Alves  <palves@redhat.com>
3992
3993         * common/preprocessor.h (ESC): Rename to ...
3994         (ESC_PARENS): ... this.
3995         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
3996         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
3997
3998 2019-01-23  Tom Tromey  <tom@tromey.com>
3999
4000         * language.h (class scoped_switch_to_sym_language_if_auto):
4001         Initialize m_lang in both cases.
4002
4003 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
4004
4005         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
4006         with XCNEW.
4007
4008 2019-01-22  Tom Tromey  <tom@tromey.com>
4009
4010         * corelow.c: Do not include sys/file.h.
4011
4012 2019-01-22  Tom Tromey  <tom@tromey.com>
4013
4014         * tui/tui-wingeneral.h: Include gdb_curses.h.
4015
4016 2019-01-22  Tom Tromey  <tom@tromey.com>
4017
4018         * source-cache.h (class source_cache) <get_source_lines,
4019         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
4020
4021 2019-01-22  Tom Tromey  <tom@tromey.com>
4022
4023         * remote-fileio.h (struct remote_target): Declare.
4024
4025 2019-01-22  Tom Tromey  <tom@tromey.com>
4026
4027         * python/py-arch.c: Do not include py-ref.h.
4028         * python/py-bpevent.c: Do not include py-ref.h.
4029         * python/py-cmd.c: Do not include py-ref.h.
4030         * python/py-continueevent.c: Do not include py-ref.h.
4031         * python/py-event.h: Do not include py-ref.h.
4032         * python/py-evtregistry.c: Do not include py-ref.h.
4033         * python/py-finishbreakpoint.c: Do not include py-ref.h.
4034         * python/py-frame.c: Do not include py-ref.h.
4035         * python/py-framefilter.c: Do not include py-ref.h.
4036         * python/py-function.c: Do not include py-ref.h.
4037         * python/py-infevents.c: Do not include py-ref.h.
4038         * python/py-linetable.c: Do not include py-ref.h.
4039         * python/py-objfile.c: Do not include py-ref.h.
4040         * python/py-param.c: Do not include py-ref.h.
4041         * python/py-prettyprint.c: Do not include py-ref.h.
4042         * python/py-progspace.c: Do not include py-ref.h.
4043         * python/py-symbol.c: Do not include py-ref.h.
4044         * python/py-symtab.c: Do not include py-ref.h.
4045         * python/py-type.c: Do not include py-ref.h.
4046         * python/py-unwind.c: Do not include py-ref.h.
4047         * python/py-utils.c: Do not include py-ref.h.
4048         * python/py-value.c: Do not include py-ref.h.
4049         * python/py-varobj.c: Do not include py-ref.h.
4050         * python/py-xmethods.c: Do not include py-ref.h.
4051         * python/python.c: Do not include py-ref.h.
4052         * varobj.c: Do not include py-ref.h.
4053
4054 2019-01-22  Tom Tromey  <tom@tromey.com>
4055
4056         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
4057         keyword for bcache.
4058
4059 2019-01-22  Tom Tromey  <tom@tromey.com>
4060
4061         * compile/compile-cplus-types.c: Remove a comment by #include.
4062
4063 2019-01-22  Tom Tromey  <tom@tromey.com>
4064
4065         * compile/gcc-c-plugin.h: Include compile-internal.h.
4066
4067 2019-01-22  Tom Tromey  <tom@tromey.com>
4068
4069         * stabsread.c (EXTERN): Do not define.
4070         (symnum, next_symbol_text_func, processing_gcc_compilation)
4071         (within_function, global_sym_chain, global_stabs)
4072         (previous_stab_code, this_object_header_files)
4073         (n_this_object_header_files)
4074         (n_allocated_this_object_header_files): Define.
4075         * stabsread.h (EXTERN): Never define.  Use "extern".
4076
4077 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4078
4079         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
4080         history_value.
4081
4082 2019-01-21  Tom Tromey  <tom@tromey.com>
4083
4084         * ui-out.c: Fix includes.
4085         * tui/tui-source.c: Fix includes.
4086         * target.c: Fix includes.
4087         * remote.c: Fix includes.
4088         * regcache.c: Fix includes.
4089         * python/py-block.c: Fix includes.
4090         * printcmd.c: Fix includes.
4091         * or1k-tdep.c: Fix includes.
4092         * mi/mi-main.c: Fix includes.
4093         * m32r-tdep.c: Fix includes.
4094         * csky-tdep.c: Fix includes.
4095         * compile/compile-cplus-types.c: Fix includes.
4096         * cli/cli-interp.c: Fix includes.
4097
4098 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
4099
4100         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4101         for padding.
4102
4103 2019-01-16  Tom Tromey  <tom@tromey.com>
4104
4105         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
4106         earlier.
4107         (struct objfile) <msymbols_range>: Move from top level.
4108         <msymbols>: New method.
4109         (class objfile_msymbols): Remove.
4110         * symtab.c (default_collect_symbol_completion_matches_break_on):
4111         Update.
4112         * symmisc.c (dump_msymbols): Update.
4113         * stabsread.c (scan_file_globals): Update.
4114         * objc-lang.c (info_selectors_command, info_classes_command)
4115         (find_methods): Update.
4116         * minsyms.c (find_solib_trampoline_target): Update.
4117         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
4118         * coffread.c (coff_symfile_read): Update.
4119         * ada-lang.c (ada_lookup_simple_minsym)
4120         (ada_collect_symbol_completion_matches): Update.
4121
4122 2019-01-16  Tom Tromey  <tom@tromey.com>
4123
4124         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
4125         type.  Remove no-argument constructor.
4126         <iterator::operator++>: Simplify.
4127         <begin>: Update.
4128         <end>: Use minimal_symbol_count.
4129
4130 2019-01-16  Tom Tromey  <tom@tromey.com>
4131
4132         * objfiles.h (struct objfile) <psymtabs>: New method.
4133         (class objfile_psymtabs): Remove.
4134         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
4135         typedef.
4136         <range>: New method.
4137         (require_partial_symbols): Change return type.
4138         * psymtab.c (require_partial_symbols)
4139         (psym_expand_symtabs_matching): Update.
4140         * mdebugread.c (parse_partial_symbols): Update.
4141         * dbxread.c (dbx_end_psymtab): Update.
4142
4143 2019-01-15  Tom Tromey  <tom@tromey.com>
4144
4145         * symtab.c (lookup_objfile_from_block)
4146         (lookup_symbol_in_objfile_symtabs)
4147         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
4148         (find_line_symtab, info_sources_command)
4149         (default_collect_symbol_completion_matches_break_on)
4150         (make_source_files_completion_list): Update.
4151         * symmisc.c (print_objfile_statistics, dump_objfile)
4152         (maintenance_print_symbols, maintenance_info_symtabs)
4153         (maintenance_check_symtabs, maintenance_info_line_tables):
4154         Update.
4155         * source.c (select_source_symtab)
4156         (forget_cached_source_info_for_objfile): Update.
4157         * objfiles.h (class objfile_compunits): Remove.
4158         (struct objfile) <compunits_range>: New typedef.
4159         (compunits): New method.
4160         * objfiles.c (objfile_relocate1): Update.
4161         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4162         * maint.c (count_symtabs_and_blocks): Update.
4163         * linespec.c (iterate_over_all_matching_symtabs): Update.
4164         * cp-support.c (add_symbol_overload_list_qualified): Update.
4165         * coffread.c (coff_symtab_read): Update.
4166         * ada-lang.c (add_nonlocal_symbols)
4167         (ada_collect_symbol_completion_matches)
4168         (ada_add_global_exceptions): Update.
4169
4170 2019-01-15  Tom Tromey  <tom@tromey.com>
4171
4172         * progspace.h (program_space) <objfiles_safe_range>: New
4173         typedef.
4174         <objfiles_safe>: New method.
4175         * objfiles.h (class all_objfiles_safe): Remove.
4176         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
4177         * jit.c (jit_inferior_exit_hook): Update.
4178
4179 2019-01-17  Tom Tromey  <tom@tromey.com>
4180
4181         * progspace.h (program_space) <objfiles_range>: New typedef.
4182         <objfiles>: New method.
4183         <objfiles_head>: Rename from objfiles.
4184         (object_files): Update.
4185         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
4186         * guile/scm-pretty-print.c
4187         (ppscm_find_pretty_printer_from_objfiles): Update.
4188         * guile/scm-objfile.c (gdbscm_objfiles): Update.
4189         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
4190         Update.
4191         * python/py-progspace.c (pspy_get_objfiles): Update.
4192         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
4193         Update.
4194         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
4195         (objfpy_lookup_objfile_by_build_id): Update.
4196         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4197         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
4198         Update.
4199         * symtab.c (iterate_over_symtabs, matching_obj_sections)
4200         (expand_symtab_containing_pc, lookup_objfile_from_block)
4201         (lookup_static_symbol, basic_lookup_transparent_type)
4202         (find_pc_sect_compunit_symtab, find_symbol_at_address)
4203         (find_line_symtab, info_sources_command)
4204         (default_collect_symbol_completion_matches_break_on)
4205         (make_source_files_completion_list, find_main_name): Update.
4206         * symmisc.c (print_symbol_bcache_statistics)
4207         (print_objfile_statistics, maintenance_print_symbols)
4208         (maintenance_print_msymbols, maintenance_print_objfiles)
4209         (maintenance_info_symtabs, maintenance_check_symtabs)
4210         (maintenance_expand_symtabs, maintenance_info_line_tables):
4211         Update.
4212         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
4213         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
4214         (map_overlay_command, unmap_overlay_command)
4215         (simple_overlay_update, expand_symtabs_matching)
4216         (map_symbol_filenames): Update.
4217         * symfile-debug.c (set_debug_symfile): Update.
4218         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
4219         Update.
4220         * source.c (select_source_symtab, forget_cached_source_info):
4221         Update.
4222         * solib.c (solib_read_symbols): Update.
4223         * solib-spu.c (append_ocl_sos): Update.
4224         * psymtab.c (maintenance_print_psymbols)
4225         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
4226         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
4227         * printcmd.c (info_symbol_command): Update.
4228         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
4229         Update.
4230         * objfiles.h (class all_objfiles): Remove.
4231         * objfiles.c (have_partial_symbols, have_full_symbols)
4232         (have_minimal_symbols, qsort_cmp, update_section_map)
4233         (shared_objfile_contains_address_p)
4234         (default_iterate_over_objfiles_in_search_order): Update.
4235         * objc-lang.c (info_selectors_command, info_classes_command)
4236         (find_methods): Update.
4237         * minsyms.c (find_solib_trampoline_target): Update.
4238         * maint.c (maintenance_info_sections)
4239         (maintenance_translate_address, count_symtabs_and_blocks):
4240         Update.
4241         * main.c (captured_main_1): Update.
4242         * linux-thread-db.c (try_thread_db_load_from_pdir)
4243         (has_libpthread): Update.
4244         * linespec.c (iterate_over_all_matching_symtabs)
4245         (search_minsyms_for_name): Update.
4246         * jit.c (jit_find_objf_with_entry_addr): Update.
4247         * hppa-tdep.c (find_unwind_entry)
4248         (hppa_lookup_stub_minimal_symbol): Update.
4249         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
4250         Update.
4251         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
4252         (elf_gnu_ifunc_resolve_by_got): Update.
4253         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
4254         * dwarf-index-write.c (save_gdb_index_command): Update.
4255         * cp-support.c (add_symbol_overload_list_qualified): Update.
4256         * breakpoint.c (create_overlay_event_breakpoint)
4257         (create_longjmp_master_breakpoint)
4258         (create_std_terminate_master_breakpoint)
4259         (create_exception_master_breakpoint): Update.
4260         * blockframe.c (find_pc_partial_function): Update.
4261         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
4262         (ada_collect_symbol_completion_matches)
4263         (ada_add_global_exceptions): Update.
4264
4265 2019-01-17  Tom Tromey  <tom@tromey.com>
4266
4267         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
4268         declare VEC.
4269         (solib_target_parse_libraries): Change return type.
4270         (library_list_start_segment, library_list_start_section)
4271         (library_list_end_library, library_list_start_library); Update.
4272         (solib_target_free_library_list): Remove.
4273         (solib_target_parse_libraries): Remove cleanup.  Change return
4274         type.
4275         (solib_target_current_sos): Update.
4276
4277 2019-01-17  Tom Tromey  <tromey@bapiya>
4278
4279         * valprint.c: Replace "the the" with "the".
4280         * symtab.c: Replace "the the" with "the".
4281         * solib.c: Replace "the the" with "the".
4282         * solib-dsbt.c: Replace "the the" with "the".
4283         * linespec.c: Replace "the the" with "the".
4284         * dwarf2loc.h: Replace "the the" with "the".
4285         * amd64-windows-tdep.c: Replace "the the" with "the".
4286         * aarch64-tdep.c: Replace "the the" with "the".
4287
4288 2019-01-16  Keith Seitz  <keiths@redhat.com>
4289
4290         PR gdb/23773
4291         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
4292         <builder>: Rename to ..
4293         <m_builder>: ... this and make private.
4294         (dwarf2_cu::get_builder): New method.  Change all users of
4295         `builder' to use this method.
4296         (dwarf2_start_symtab): Move to ...
4297         (dwarf2_cu::start_symtab): ... here.  Update all callers
4298         (setup_type_unit_groups): Move to ...
4299         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
4300         callers.
4301         (dwarf2_cu::reset_builder): New method.
4302         (process_full_compunit, process_full_type_unit): Use
4303         dwarf2_cu::reset_builder.
4304         (follow_die_offset): Record the ancestor CU if it is different
4305         from the followed DIE's CU.
4306         (follow_die_sig_1): Likewise.
4307
4308 2019-01-15  Tom Tromey  <tom@tromey.com>
4309
4310         * remote.c (class remote_state) <buf>: Now a char_vector.
4311         <buf_size>: Remove.
4312         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
4313         parameter.
4314         (remote_target::getpkt_or_notif_sane_1)
4315         (remote_target::getpkt_sane)
4316         (remote_target::getpkt_or_notif_sane): Likewise.
4317         (class remote_target) <putpkt>: New overload.
4318         (remote_target::read_frame): Change type of "buf_p".  Remove
4319         sizeof_p parameter.
4320         (packet_ok): New overload.
4321         (packet_check_result): New overload.
4322         Update all uses.
4323
4324 2019-01-14  Tom Tromey  <tom@tromey.com>
4325
4326         * remote-notif.c (handle_notification, remote_notif_ack)
4327         (remote_notif_parse): Make "buf" const.
4328         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
4329         const.
4330         (remote_notif_parse, remote_notif_ack, handle_notification):
4331         Likewise.
4332         * remote.c (remote_notif_stop_parse): Make "buf" const.
4333         (remote_target::remote_parse_stop_reply): Make "buf" const.
4334         (remote_notif_stop_ack): Make "buf" const.
4335
4336 2019-01-14  Tom Tromey  <tom@tromey.com>
4337
4338         * remote.c (remote_console_output): Make parameter const.
4339
4340 2019-01-14  Tom Tromey  <tom@tromey.com>
4341
4342         * target-debug.h (target_debug_print_signals): Constify.
4343         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
4344         * procfs.c (procfs_target::pass_signals): Update.
4345         * linux-nat.c (linux_nat_target::pass_signals): Update.
4346         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
4347         * target-delegates.c: Rebuild.
4348         * remote.c (remote_target::program_signals): Update.
4349         (remote_target::pass_signals): Update.
4350         * target.c (target_pass_signals): Constify argument.
4351         (target_program_signals): Likewise.
4352         * target.h (struct target_ops) <pass_signals, program_signals>:
4353         Constify argument.
4354         (target_pass_signals, target_program_signals): Constify argument.
4355
4356 2019-01-14  Tom Tromey  <tom@tromey.com>
4357
4358         PR tui/28819:
4359         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
4360
4361 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
4362
4363         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
4364         field.
4365         * rs6000-tdep.c: Include reggroups.h.
4366         (IS_V_ALIAS_PSEUDOREG): Define.
4367         (rs6000_register_name): Return names for the "vX" aliases.
4368         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
4369         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
4370         aliases.  Call default_register_reggroup_p for all other
4371         pseudo-registers.
4372         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
4373         New functions.
4374         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
4375         Handle "vX" aliases.
4376         (v_alias_pseudo_register_collect): New function.
4377         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
4378         (rs6000_gdbarch_init): Initialize "vX" aliases as
4379         pseudo-registers.  Restore registration of
4380         rs6000_pseudo_register_reggroup_p with
4381         set_tdesc_pseudo_register_reggroup_p.
4382
4383 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
4384
4385         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
4386         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
4387         set_gdbarch_num_pseudo_regs.
4388
4389 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4390
4391         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
4392         Remove arg prefixname, add do_set and do_show.
4393         Add member functions set_list and show_list.
4394         * cli/cli-style.c (class cli_style_option): Update accordingly.
4395         (style_set_list): Move to file scope.
4396         (style_show_list): Likewise.
4397         (set_style): Call help_list.
4398         (show_style): Call cmd_show_list.
4399         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
4400         Update to use the new macro.
4401
4402 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
4403
4404         * ada-lang.c (_initialize_ada_language): Expand the help text
4405         for the "catch exception" command.
4406
4407 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4408
4409         * symtab.c (matching_obj_sections): Initialize obj,
4410         declare it closer to its usage.
4411
4412 2019-01-10  Tom Tromey  <tom@tromey.com>
4413
4414         * thread-iter.h (inf_threads_iterator): Use next_iterator.
4415         (basic_inf_threads_range): Remove.
4416         (inf_threads_range, inf_non_exited_threads_range)
4417         (safe_inf_threads_range): Use next_adapter.
4418
4419 2019-01-10  Keith Seitz  <keiths@redhat.com>
4420
4421         PR gdb/23712
4422         PR symtab/23010
4423         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
4424         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
4425
4426 2019-01-10  Keith Seitz  <keiths@redhat.com>
4427
4428         PR gdb/23712
4429         PR symtab/23010
4430         * dictionary.c (pending_to_vector): Remove.
4431         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4432         Remove _1 suffix, replacing functions of the same name.  Update
4433         all callers.
4434         (dict_create_hashed, dict_create_hashed_expandable)
4435         (dict_create_linear, dict_create_linear_expandable, dict_free)
4436         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
4437         Make functions static.
4438
4439 2019-01-10  Keith Seitz  <keiths@redhat.com>
4440
4441         PR gdb/23712
4442         PR symtab/23010
4443         * dictionary.h (struct dictionary): Replace declaration with
4444         multidictionary.
4445         (dict_create_hashed, dict_create_hashed_expandable)
4446         (dict_create_linear, dict_create_linear_expandable)
4447         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
4448         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
4449         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
4450         taking multidictionary argument.
4451         [ALL_DICT_SYMBOLS]: Update for multidictionary.
4452         * block.h (struct block) <dict>: Change to multidictionary
4453         and rename `multidict'.
4454         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
4455         symmisc.c: Update all dictionary references to multidictionary.
4456
4457 2019-01-10  Keith Seitz  <keiths@redhat.com>
4458
4459         PR gdb/23712
4460         PR symtab/23010
4461         * dictionary.c: Include unordered_map.
4462         (pending_to_vector): New function.
4463         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4464         Rewrite the non-"_1" functions to take vector instead
4465         of linked list.
4466         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
4467         "new" _1 versions of the same name.
4468         (multidictionary): Define.
4469         (std::hash<enum language): New definition.
4470         (collate_pending_symbols_by_language, mdict_create_hashed)
4471         (mdict_create_hashed_expandable, mdict_create_linear)
4472         (mdict_create_linear_expandable, mdict_free)
4473         (find_language_dictionary, create_new_language_dictionary)
4474         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
4475         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
4476         (mdict_size, mdict_empty): New functions.
4477         * dictionary.h (mdict_iterator): Define.
4478
4479 2019-01-10  Pedro Alves  <palves@redhat.com>
4480
4481         * breakpoint.c (read_uploaded_action)
4482         (create_tracepoint_from_upload): Adjust to use
4483         gdb::unique_xmalloc_ptr.
4484         * ctf.c (ctf_write_uploaded_tp):
4485         (SET_ARRAY_FIELD): Use emplace_back.
4486         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
4487         * tracefile-tfile.c (tfile_write_uploaded_tp):
4488         * tracepoint.c (parse_tracepoint_definition): Adjust to use
4489         gdb::unique_xmalloc_ptr.
4490         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
4491         at_string, cond_string, cmd_strings>: Replace char pointers
4492         with gdb::unique_xmalloc_ptr.
4493
4494 2019-01-10  Pedro Alves  <palves@redhat.com>
4495
4496         * solib-target.c (library_list_start_library): Don't xstrdup name.
4497
4498 2019-01-10  Pedro Alves  <palves@redhat.com>
4499
4500         * mdebugread.c (parse_partial_symbols): Use
4501         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
4502
4503 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4504
4505         * linux-fork.c (scoped_switch_fork_info)
4506         <~scoped_switch_fork_info>: Fix incorrect variable name.
4507
4508 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4509
4510         * linux-fork.c (scoped_switch_fork_info)
4511         <scoped_switch_fork_info>: Make explicit.
4512         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
4513
4514 2019-01-10  Tom Tromey  <tom@tromey.com>
4515
4516         * objfiles.h (objfile::reset_psymtabs): Update.
4517         * objfiles.c (objfile::objfile): Update.
4518         * psymtab.h (psymtab_storage::obstack): Update.
4519         (psymtab_storage::m_obstack): Use gdb::optional.
4520         (class psymtab_storage): Update comment.  Remove objfile
4521         parameter.
4522         * psymtab.c (psymtab_storage::psymtab_storage): Update.
4523
4524 2019-01-10  Tom Tromey  <tom@tromey.com>
4525
4526         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
4527         <free_psymtabs>: Now private.
4528         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
4529         (allocate_psymtab): Use new method.
4530
4531 2019-01-10  Tom Tromey  <tom@tromey.com>
4532
4533         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
4534         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
4535         * mdebugread.c (parse_partial_symbols): Use
4536         allocate_dependencies.
4537         * dwarf2read.c (dwarf2_create_include_psymtab): Use
4538         allocate_dependencies.
4539         (process_psymtab_comp_unit_reader)
4540         (build_type_psymtab_dependencies): Likewise.
4541         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
4542
4543 2019-01-10  Tom Tromey  <tom@tromey.com>
4544
4545         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
4546         PSYMBOL_SET_LANGUAGE.
4547         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
4548
4549 2019-01-10  Tom Tromey  <tom@tromey.com>
4550
4551         * psymtab.h (psymtab_storage::obstack): New method.
4552         <m_obstack>: Rename from obstack; now private.
4553         * psymtab.c (psymtab_storage): Update.
4554         * dwarf2read.c (create_addrmap_from_index)
4555         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
4556         Update.
4557
4558 2019-01-10  Tom Tromey  <tom@tromey.com>
4559
4560         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
4561         * objfiles.h (objfile::reset_psymtabs): New method.
4562
4563 2019-01-10  Tom Tromey  <tom@tromey.com>
4564
4565         * symmisc.c (print_symbol_bcache_statistics): Update.
4566         (print_objfile_statistics): Update.
4567         * symfile.c (reread_symbols): Update.
4568         * psymtab.h (class psymtab_storage): New.
4569         * psymtab.c (psymtab_storage): New constructor.
4570         (~psymtab_storage): New destructor.
4571         (require_partial_symbols): Update.
4572         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
4573         (find_pc_sect_psymtab, find_pc_sect_psymbol)
4574         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
4575         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
4576         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
4577         (start_psymtab_common, end_psymtab_common)
4578         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
4579         (allocate_psymtab): Update.
4580         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
4581         Update.
4582         (dump_psymtab_addrmap, maintenance_print_psymbols)
4583         (maintenance_check_psymtabs): Update.
4584         (class objfile_psymtabs): Move to objfiles.h.
4585         * psympriv.h (discard_psymtab): Now inline.
4586         (psymtab_discarder::psymtab_discarder): Update.
4587         (psymtab_discarder::~psymtab_discarder): Update.
4588         (ALL_OBJFILE_PSYMTABS): Rewrite.
4589         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
4590         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
4591         Remove fields.
4592         <partial_symtabs>: New field.
4593         (class objfile_psymtabs): Move from psymtab.h.  Update.
4594         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
4595         psymbol_cache.
4596         (objfile::~objfile): Don't destroy psymbol_cache.
4597         * mdebugread.c (parse_partial_symbols): Update.
4598         * dwarf2read.c (create_addrmap_from_index)
4599         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
4600         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
4601         (add_partial_subprogram, dwarf2_ranges_read): Update.
4602         * dwarf-index-write.c (write_address_map)
4603         (write_one_signatured_type, recursively_write_psymbols)
4604         (class debug_names, class debug_names, write_psymtabs_to_index):
4605         Update.
4606
4607 2019-01-10  Tom Tromey  <tom@tromey.com>
4608
4609         * symtab.h (SYMBOL_SET_NAMES): Update.
4610         (symbol_set_names): Update.
4611         (MSYMBOL_SET_NAMES): Update.
4612         * symtab.c (symbol_set_names): Change argument to be an
4613         objfile_per_bfd_storage.
4614         * psymtab.c (add_psymbol_to_bcache): Update.
4615         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
4616
4617 2019-01-10  Tom Tromey  <tom@tromey.com>
4618
4619         * symtab.c (create_demangled_names_hash): Change argument to be an
4620         objfile_per_bfd_storage.
4621         (symbol_set_names): Update.
4622
4623 2019-01-10  Tom Tromey  <tom@tromey.com>
4624
4625         * xcoffread.c (xcoff_initial_scan): Unconditionally call
4626         init_psymbol_list.
4627         * psymtab.c (init_psymbol_list): Do nothing if already called.
4628         * psympriv.h (init_psymbol_list): Add comment.
4629         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
4630         init_psymbol_list.
4631         * dbxread.c (dbx_symfile_read): Unconditionally call
4632         init_psymbol_list.
4633
4634 2019-01-10  Tom Tromey  <tom@tromey.com>
4635
4636         * xcoffread.c (scan_xcoff_symtab): Update.
4637         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
4638         "where".
4639         * mdebugread.c (parse_partial_symbols)
4640         (handle_psymbol_enumerators): Update.
4641         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
4642         * dbxread.c (read_dbx_symtab): Update.
4643         * psympriv.h (psymbol_placement): New enum.
4644         (add_psymbol_to_list): Update.
4645
4646 2019-01-10  Tom Tromey  <tom@tromey.com>
4647
4648         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
4649         static_psymbols parameters.
4650         (scan_xcoff_symtab): Update.
4651         * psymtab.c (start_psymtab_common): Remove global_psymbols and
4652         static_psymbols parameters.
4653         * psympriv.h (start_psymtab_common): Update.
4654         * mdebugread.c (parse_partial_symbols): Update.
4655         * dwarf2read.c (create_partial_symtab): Update.
4656         * dbxread.c (read_dbx_symtab): Update.
4657         (start_psymtab): Remove global_psymbols and static_psymbols
4658         parameters.
4659
4660 2019-01-10  Tom Tromey  <tom@tromey.com>
4661
4662         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
4663         * psymtab.c (allocate_psymtab): Add comment.
4664         * psympriv.h (allocate_psymtab): Add comment.
4665         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
4666         initializations.
4667         * dbxread.c (dbx_end_psymtab): Remove some initializations.
4668
4669 2019-01-10  Tom Tromey  <tom@tromey.com>
4670
4671         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
4672         Don't declare.
4673         * mipsread.c: Include mdebugread.h.
4674         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
4675         Declare.
4676         * elfread.c: Include mdebugread.h.
4677
4678 2019-01-09  Tom Tromey  <tom@tromey.com>
4679
4680         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
4681         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
4682         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
4683         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
4684         (psym_lookup_symbol, psym_find_last_source_symtab)
4685         (psym_forget_cached_source_info, psym_print_stats)
4686         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
4687         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
4688         (psym_map_matching_symbols, psym_expand_symtabs_matching)
4689         (psym_find_compunit_symtab_by_address)
4690         (maintenance_print_psymbols, maintenance_info_psymtabs)
4691         (maintenance_check_psymtabs): Use ranged for.
4692         * psymtab.h (class objfile_psymtabs): New.
4693         (require_partial_symbols): Return objfile_psymtabs.
4694         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
4695
4696 2019-01-09  Tom Tromey  <tom@tromey.com>
4697
4698         * symfile.c (overlay_invalidate_all, find_pc_overlay)
4699         (find_pc_mapped_section, list_overlays_command)
4700         (map_overlay_command, unmap_overlay_command)
4701         (simple_overlay_update): Use all_objfiles.
4702         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
4703         * printcmd.c (info_symbol_command): Use all_objfiles.
4704         * objfiles.h (ALL_OBJSECTIONS): Remove.
4705         * maint.c (maintenance_translate_address): Use all_objfiles.
4706         * gcore.c (gcore_create_callback): Use all_objfiles.
4707         (objfile_find_memory_regions): Likewise.
4708
4709 2019-01-09  Tom Tromey  <tom@tromey.com>
4710
4711         * symtab.c (find_line_symtab, info_sources_command)
4712         (make_source_files_completion_list): Use objfile_compunits.
4713         * source.c (select_source_symtab): Use objfile_compunits.
4714         * objfiles.h (struct objfile): Update comment.
4715         (ALL_OBJFILES): Remove.
4716         (ALL_FILETABS): Remove.
4717         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
4718         objfile_compunits.
4719
4720 2019-01-09  Tom Tromey  <tom@tromey.com>
4721
4722         * symmisc.c (print_objfile_statistics, dump_objfile)
4723         (maintenance_print_symbols): Use compunit_filetabs.
4724         * source.c (forget_cached_source_info_for_objfile): Use
4725         compunit_filetabs.
4726         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
4727         (ALL_FILETABS): Use compunit_filetabs.
4728         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
4729         * coffread.c (coff_symtab_read): Use compunit_filetabs.
4730
4731 2019-01-09  Tom Tromey  <tom@tromey.com>
4732
4733         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
4734         (compunit_filetabs): New.
4735         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
4736         compunit_filetabs.
4737         (info_sources_command, make_source_files_completion_list): Remove
4738         declaration.
4739         * symmisc.c (print_objfile_statistics, dump_objfile)
4740         (maintenance_print_symbols): Remove declaration.
4741         (maintenance_info_symtabs): Use compunit_filetabs.
4742         (maintenance_info_line_tables): Likewise.
4743         * source.c (select_source_symtab): Change local variable name.
4744         (forget_cached_source_info_for_objfile): Remove declaration.
4745         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
4746         * objfiles.c (objfile_relocate1): Remove declaration.
4747         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
4748         declaration.
4749         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
4750         * coffread.c (coff_symtab_read): Remove declaration.
4751         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
4752         compunit_filetabs.
4753
4754 2019-01-09  Tom Tromey  <tom@tromey.com>
4755
4756         * symtab.c (lookup_objfile_from_block)
4757         (find_pc_sect_compunit_symtab, search_symbols)
4758         (default_collect_symbol_completion_matches_break_on): Use
4759         objfile_compunits.
4760         * objfiles.h (ALL_COMPUNITS): Remove.
4761         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
4762         * cp-support.c (add_symbol_overload_list_qualified): Use
4763         objfile_compunits.
4764         * ada-lang.c (ada_collect_symbol_completion_matches)
4765         (ada_add_global_exceptions): Use objfile_compunits.
4766
4767 2019-01-09  Tom Tromey  <tom@tromey.com>
4768
4769         * source.c (select_source_symtab)
4770         (forget_cached_source_info_for_objfile): Remove declaration.
4771         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
4772         declaration.
4773         * maint.c (count_symtabs_and_blocks): Remove declaration.
4774         * cp-support.c (add_symbol_overload_list_qualified): Remove
4775         declaration.
4776         * coffread.c (coff_symtab_read): Remove declaration.
4777         * symtab.c (lookup_symbol_in_objfile_symtabs)
4778         (basic_lookup_transparent_type_1): Use objfile_compunits.
4779         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
4780         (info_sources_command, search_symbols)
4781         (default_collect_symbol_completion_matches_break_on)
4782         (make_source_files_completion_list): Remove declaration.
4783         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
4784         (ada_collect_symbol_completion_matches)
4785         (ada_add_global_exceptions): Remove declaration.
4786         * linespec.c (iterate_over_all_matching_symtabs): Use
4787         objfile_compunits.
4788         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
4789         (class objfile_compunits): New.
4790         (ALL_COMPUNITS): Use objfile_compunits.
4791         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
4792         (maintenance_check_symtabs, maintenance_info_line_tables): Use
4793         objfile_compunits.
4794         * objfiles.c (objfile_relocate1): Use objfile_compunits.
4795
4796 2019-01-09  Tom Tromey  <tom@tromey.com>
4797
4798         * symtab.c (search_symbols)
4799         (default_collect_symbol_completion_matches_break_on): Use
4800         objfile_msymbols.
4801         * ada-lang.c (ada_lookup_simple_minsym)
4802         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
4803         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
4804         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
4805         objfile_msymbols.
4806         * coffread.c (coff_symfile_read): Use objfile_msymbols.
4807         * symmisc.c (dump_msymbols): Use objfile_msymbols.
4808         * objc-lang.c (find_methods): Use objfile_msymbols.
4809         (info_selectors_command, info_classes_command): Likewise.
4810         * stabsread.c (scan_file_globals): Use objfile_msymbols.
4811         * objfiles.h (class objfile_msymbols): New.
4812         (ALL_OBJFILE_MSYMBOLS): Remove.
4813         (ALL_MSYMBOLS): Remove.
4814
4815 2019-01-09  Tom Tromey  <tom@tromey.com>
4816
4817         * common/next-iterator.h (next_adapter): Add Iterator template
4818         parameter.
4819         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
4820         (class all_objfiles_safe): New.
4821         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
4822         * objfiles.c (put_objfile_before): Update comment.
4823         (add_separate_debug_objfile): Likewise.
4824         (free_all_objfiles): Use all_objfiles_safe.
4825         (objfile_purge_solibs): Likewise.
4826
4827 2019-01-09  Tom Tromey  <tom@tromey.com>
4828
4829         * symtab.c (iterate_over_symtabs, matching_obj_sections)
4830         (expand_symtab_containing_pc, lookup_static_symbol)
4831         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
4832         (find_symbol_at_address, find_line_symtab, find_main_name): Use
4833         all_objfiles.
4834         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
4835         * breakpoint.c (create_overlay_event_breakpoint)
4836         (create_longjmp_master_breakpoint)
4837         (create_std_terminate_master_breakpoint)
4838         (create_exception_master_breakpoint): Use all_objfiles.
4839         * linux-thread-db.c (try_thread_db_load_from_pdir)
4840         (has_libpthread): Use all_objfiles.
4841         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
4842         * linespec.c (iterate_over_all_matching_symtabs)
4843         (search_minsyms_for_name): Use all_objfiles.
4844         * maint.c (maintenance_info_sections): Use all_objfiles.
4845         * main.c (captured_main_1): Use all_objfiles.
4846         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
4847         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
4848         * guile/scm-pretty-print.c
4849         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
4850         * solib-spu.c (append_ocl_sos): Use all_objfiles.
4851         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
4852         (maintenance_print_msymbols): Use all_objfiles.
4853         * source.c (select_source_symtab): Use all_objfiles.
4854         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
4855         * symfile.c (remove_symbol_file_command)
4856         (expand_symtabs_matching, map_symbol_filenames): Use
4857         all_objfiles.
4858         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
4859         all_objfiles.
4860         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
4861         * objc-lang.c (find_methods): Use all_objfiles.
4862         * objfiles.c (have_partial_symbols, have_full_symbols)
4863         (have_minimal_symbols, qsort_cmp)
4864         (default_iterate_over_objfiles_in_search_order): Use
4865         all_objfiles.
4866         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
4867         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
4868         (maintenance_check_psymtabs): Use all_objfiles.
4869         (ALL_PSYMTABS): Remove.
4870         * compile/compile-object-run.c (do_module_cleanup): Use
4871         all_objfiles.
4872         * blockframe.c (find_pc_partial_function): Use all_objfiles.
4873         * cp-support.c (add_symbol_overload_list_qualified): Use
4874         all_objfiles.
4875         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
4876         Use all_objfiles.
4877         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
4878         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
4879         all_objfiles.
4880         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
4881         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
4882         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
4883         Uses all_objfiles.
4884         * solib.c (solib_read_symbols): Use all_objfiles
4885
4886 2019-01-09  Tom Tromey  <tom@tromey.com>
4887
4888         * probe.c (parse_probes_in_pspace): Use all_objfiles.
4889         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
4890         all_objfiles.
4891         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
4892         * symmisc.c (print_symbol_bcache_statistics)
4893         (print_objfile_statistics, maintenance_print_objfiles)
4894         (maintenance_info_symtabs, maintenance_check_symtabs)
4895         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
4896         all_objfiles.
4897         * source.c (forget_cached_source_info): Use all_objfiles.
4898         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
4899         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
4900         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
4901         * objfiles.c (update_section_map): Use all_objfiles.
4902         (shared_objfile_contains_address_p): Likewise.
4903         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
4904         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
4905
4906 2019-01-09  Tom Tromey  <tom@tromey.com>
4907
4908         * common/next-iterator.h: New file.
4909         * objfiles.h (class all_objfiles): New.
4910         (struct objfile_iterator): New.
4911
4912 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4913
4914         * NEWS: Move the description of the changed "frame", "select-frame",
4915          and "info frame" commands to the Changed commands section.
4916
4917 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
4918
4919         * gdbtypes.c (check_stub_method_group): Remove handling of old
4920         mangling schemes.
4921         * linespec.c (find_methods): Likewise.
4922         * stabsread.c (read_member_functions): Likewise.
4923         * valops.c (search_struct_method): Likewise.
4924         (value_struct_elt_for_reference): Likewise.
4925         * NEWS: Mention this change.
4926
4927 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4928
4929         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
4930         print_source_lines.
4931         * source.c (print_source_lines_base): Update line number check.
4932         (print_source_lines): New function.
4933         (source_lines_range::source_lines_range): New function.
4934         * source.h (class source_lines_range): New class.
4935         (print_source_lines): New declaration.
4936
4937 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4938
4939         * linespec.c (linespec_state_destructor): Free self->canonical_names.
4940
4941 2019-01-08  Tom Tromey  <tom@tromey.com>
4942             Simon Marchi  <simon.marchi@ericsson.com>
4943
4944         PR gdb/24060
4945         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
4946         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
4947         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
4948         * f-exp.y (DOLLAR_VARIABLE): Likewise.
4949         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
4950         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
4951
4952 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4953
4954         * source.c (select_source_symtab): Move header comment to
4955         declaration in source.h.
4956         (forget_cached_source_info_for_objfile): Likewise.
4957         (forget_cached_source_info): Likewise.
4958         (identify_source_line): Likewise.
4959         * source.h (identify_source_line): Move declaration from symtab.h
4960         and add comment from source.c
4961         (print_source_lines): Likewise.
4962         (forget_cached_source_info_for_objfile): Likewise.
4963         (forget_cached_source_info): Likewise.
4964         (select_source_symtab): Likewise.
4965         (enum print_source_lines_flag): Move definition from symtab.h.
4966         * symtab.h (identify_source_line): Move declaration to source.h.
4967         (print_source_lines): Likewise.
4968         (forget_cached_source_info_for_objfile): Likewise.
4969         (forget_cached_source_info): Likewise.
4970         (select_source_symtab): Likewise.
4971         (enum print_source_lines_flag): Move definition to source.h.
4972         * tui/tui-hooks.c: Add 'source.h' include.
4973
4974 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4975
4976         * source.c (print_source_lines_base): Handle requests to print
4977         reverse line number sequences, and guard against empty lines
4978         string.
4979
4980 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4981
4982         * source.c (print_source_lines_base): Fix skip of '\r' if next
4983         character is '\n'.
4984
4985 2019-01-06  Tom Tromey  <tom@tromey.com>
4986
4987         * c-exp.y (struct c_parse_state) <macro_original_text,
4988         expansion_obstack>: New member.
4989         (macro_original_text, expansion_obstack): Remove globals.
4990         (scan_macro_expansion, scanning_macro_expansion)
4991         (finished_macro_expansion): Update.
4992         (scan_macro_cleanup): Remove.
4993         (yylex, c_parse): Update.
4994
4995 2019-01-06  Tom Tromey  <tom@tromey.com>
4996
4997         * c-exp.y (struct c_parse_state) <strings>: New member.
4998         (operator_stoken): Update.
4999
5000 2019-01-06  Tom Tromey  <tom@tromey.com>
5001
5002         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
5003         (union type_stack_elt) <typelist_val>: Now a pointer to
5004         std::vector.
5005         (type_stack_cleanup): Don't declare.
5006         (push_typelist): Update.
5007         * parse.c (pop_typelist): Return a std::vector.
5008         (push_typelist): Take a std::vector.
5009         (follow_types): Update.  Do not free args.
5010         (type_stack_cleanup): Remove.
5011         * c-exp.y (struct c_parse_state): New.
5012         (cpstate): New global.
5013         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
5014         (nonempty_typelist): Update.
5015         (func_mod): Create a new vector.
5016         (c_parse): Create a c_parse_state.
5017         (check_parameter_typelist): Do not delete params.
5018         (function_method): Update.  Do not delete type_list.
5019
5020 2019-01-06  Tom Tromey  <tom@tromey.com>
5021
5022         PR gdb/28155:
5023         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
5024         check_typedef.
5025         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
5026         (print_return_value): Likewise.
5027
5028 2019-01-05  Tom Tromey  <tom@tromey.com>
5029
5030         * contrib/cleanup_check.py: Remove.
5031         * contrib/gcc-with-excheck: Remove.
5032         * contrib/exsummary.py: Remove.
5033         * contrib/excheck.py: Remove.
5034
5035 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
5036
5037         * thread.c (delete_thread_1): Add gdb_assert that THR is not
5038         NULL. Initialize tpprev to NULL instead of assigning it
5039         to NULL on the next statement.
5040         * windows-nat.c (windows_delete_thread): Remove check for
5041         main_thread_id before printing thread exit notifications.
5042         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
5043         Remove thread ID check against main_thread_id.
5044         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
5045         windows_delete_thread.
5046         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
5047
5048 2019-01-04  Tom Tromey  <tom@tromey.com>
5049
5050         * compile/compile.c (_initialize_compile): Use upper case for
5051         metasyntactic variables.
5052         * symmisc.c (_initialize_symmisc): Use upper case for
5053         metasyntactic variables.
5054         * psymtab.c (_initialize_psymtab): Use upper case for
5055         metasyntactic variables.
5056         * demangle.c (demangle_command): Use upper case for metasyntactic
5057         variables.
5058         (_initialize_demangler): Likewise.
5059         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
5060         variables.
5061
5062 2019-01-03  Tom Tromey  <tom@tromey.com>
5063
5064         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
5065
5066 2019-01-03  Tom Tromey  <tom@tromey.com>
5067
5068         * python/py-symtab.c (salpy_str): Update.
5069         (struct salpy_sal_object) <symtab>: Now a PyObject.
5070         (salpy_dealloc): Update.
5071         (del_objfile_sal): Use gdbpy_ref.
5072
5073 2019-01-03  Tom Tromey  <tom@tromey.com>
5074
5075         * python/py-type.c (convert_field): Use new_reference.  Return
5076         gdbpy_ref.
5077         (make_fielditem): Return gdbpy_ref.
5078         (typy_fields): Update.
5079         (typy_getitem): Update.
5080         (field_name): Return gdbpy_ref.  Use new_reference.
5081         (typy_iterator_iternext): Update.
5082
5083 2019-01-03  Tom Tromey  <tom@tromey.com>
5084
5085         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
5086
5087 2019-01-03  Tom Tromey  <tom@tromey.com>
5088
5089         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
5090         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
5091         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
5092         (pspy_set_frame_filters, pspy_set_frame_unwinders)
5093         (pspy_set_type_printers): Likewise.
5094         * python/py-function.c (fnpy_init): Use gdbpy_ref.
5095         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
5096         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
5097         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
5098         (objfpy_set_type_printers): Likewise.
5099
5100 2019-01-03  Tom Tromey  <tom@tromey.com>
5101
5102         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
5103         (gdbpy_print_stack): Use gdbpy_err_fetch.
5104         * python/python-internal.h (class gdbpy_err_fetch): New class.
5105         (class gdbpy_enter) <m_error_type, m_error_value,
5106         m_error_traceback>: Remove.
5107         <m_error>: New member.
5108         (gdbpy_exception_to_string): Don't declare.
5109         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
5110         * python/py-value.c (convert_value_from_python): Use
5111         gdbpy_err_fetch.
5112         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
5113         gdbpy_exception_to_string.
5114         (gdbpy_handle_exception): Use gdbpy_err_fetch.
5115         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
5116         gdbpy_err_fetch.
5117
5118 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5119
5120         * linux-nat.c (delete_lwp_cleanup): Delete.
5121         (struct lwp_deleter): New struct.
5122         (lwp_info_up): New typedef.
5123         (linux_nat_target::follow_fork): Delete cleanup, and make use of
5124         lwp_info_up.
5125
5126 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5127
5128         * linux-fork.c (class scoped_switch_fork_info): New class.
5129         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
5130
5131 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5132
5133         * valops.c (find_overload_match): Remove use of null_cleanup, and
5134         calls to do_cleanups.
5135
5136 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5137
5138         * compile/compile-cplus-types.c
5139         (compile_cplus_instance::decl_name): Handle changes to
5140         cp_func_name.
5141         * cp-support.c (cp_func_name): Update header comment, update
5142         return type.
5143         * cp-support.h (cp_func_name): Update return type in declaration.
5144         * valops.c (find_overload_match): Move temp_func local to top
5145         level of function and change its type.  Use temp_func to hold and
5146         delete temporary string obtained from cp_func_name.
5147
5148 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5149
5150         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
5151         gdb::char_vector, remove cleanup, and update uses of `msg`.
5152
5153 2019-01-03  Jim Wilson  <jimw@sifive.com>
5154
5155         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
5156
5157 2019-01-02  Tom Tromey  <tom@tromey.com>
5158
5159         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
5160         (tdesc_parse_xml): Remove cleanups.
5161         * target-descriptions.h (make_cleanup_free_target_description):
5162         Don't declare.
5163         (target_desc_deleter): New struct.
5164         (target_desc_up): New typedef.
5165         * target-descriptions.c (target_desc_deleter::operator()): Rename
5166         from free_target_description.
5167         (make_cleanup_free_target_description): Remove.
5168
5169 2019-01-02  Tom Tromey  <tom@tromey.com>
5170
5171         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
5172         constructor, destructor.
5173         (linespec_parser): Remove typedef.
5174         (~linespec_parser): Rename from linespec_parser_delete.
5175         (linespec_lex_to_end, linespec_complete_label)
5176         (linespec_complete): Update.
5177         (decode_line_full): Remove cleanups.
5178         (decode_line_1): Update.
5179
5180 2019-01-02  Tom Tromey  <tom@tromey.com>
5181
5182         * python/python-internal.h (inferior_to_inferior_object): Change
5183         return type.
5184         * python/py-exitedevent.c (create_exited_event_object): Update.
5185         * python/py-inferior.c (inferior_to_inferior_object): Return
5186         gdbpy_ref.
5187         (python_new_inferior, python_inferior_deleted)
5188         (thread_to_thread_object, delete_thread_object)
5189         (build_inferior_list, gdbpy_selected_inferior): Update.
5190         * python/py-infthread.c (create_thread_object): Update.  Also fail
5191         if inferior_to_inferior_object fails.
5192
5193 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
5194
5195         * inferior.h (class inferior) <displaced_step_state>: New field.
5196         * infrun.h (struct displaced_step_state): Move here from
5197         infrun.c.  Initialize fields, add constructor.
5198         <inf>: Remove field.
5199         <reset>: New method.
5200         * infrun.c (struct displaced_step_inferior_state): Move to
5201         infrun.h.
5202         (displaced_step_inferior_states): Remove.
5203         (get_displaced_stepping_state): Adust.
5204         (displaced_step_in_progress_any_inferior): Adjust.
5205         (displaced_step_in_progress_thread): Adjust.
5206         (displaced_step_in_progress): Adjust.
5207         (add_displaced_stepping_state): Remove.
5208         (get_displaced_step_closure_by_addr): Adjust.
5209         (remove_displaced_stepping_state): Remove.
5210         (infrun_inferior_exit): Call displaced_step_state.reset.
5211         (use_displaced_stepping): Don't check for NULL.
5212         (displaced_step_prepare_throw): Call
5213         get_displaced_stepping_state.
5214         (displaced_step_fixup): Don't check for NULL.
5215         (prepare_for_detach): Don't check for NULL.
5216
5217 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5218
5219         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
5220          in case of call that did not complete.
5221
5222 2019-01-02  Andrey Utkin  <autkin@undo.io>
5223
5224         * symfile.c (find_separate_debug_file): Fix search of debug files for
5225         remote debuggee.
5226
5227 2019-01-02  Tom Tromey  <tom@tromey.com>
5228
5229         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
5230         indentation.
5231         * python/py-frame.c (frapy_older): Remove cast.
5232         (frapy_newer): Likewise.
5233         * python/py-breakpoint.c (local_setattro): Remove cast.
5234         * python/py-arch.c (archpy_name): Remove local variable.
5235         * python/py-type.c (gdbpy_lookup_type): Remove cast.
5236
5237 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
5238
5239         * unittests/basic_string_view/element_access/char/empty.cc:
5240         Fix year range in copyright header.
5241
5242 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5243
5244         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
5245         Delete.
5246         <operator==>: Update with for removed field.
5247         <hash>: Likewise.
5248         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
5249         <isa_features>: ...this.
5250         <abi_features>: New field.
5251         (riscv_isa_flen): Update comment.
5252         (riscv_abi_xlen): New declaration.
5253         (riscv_abi_flen): New declaration.
5254         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
5255         isa_features.
5256         (riscv_abi_xlen): New function.
5257         (riscv_isa_flen): Update to get answer from isa_features.
5258         (riscv_abi_flen): New function.
5259         (riscv_has_fp_abi): Update to get answer from abi_features.
5260         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
5261         xlen and flen.
5262         (riscv_call_info) <xlen, flen>: Update comment.
5263         (riscv_call_arg_struct): Remove invalid assertions
5264         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
5265         is removed.
5266         (riscv_gdbarch_init): Gather isa features and abi features
5267         separately, ensure both match on the gdbarch when reusing an old
5268         gdbarch.  Relax an error check to allow 32-bit abi float to run on
5269         a target with 64-bit float hardware.
5270
5271 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5272
5273         * source.c (search_command_helper): Stop reverse search
5274         when line 1 has been searched.
5275
5276 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5277
5278         * record-full.c (record_full_base_target::close): Rewrite
5279         record_full_core_buf_list free logic.
5280
5281 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5282
5283         * break-catch-syscall.c (print_one_catch_syscall): xfree
5284         the last text.
5285
5286 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5287
5288         * top.c (print_gdb_version): Update Copyright year in version
5289         message.
5290
5291 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5292
5293         Update copyright year range in all GDB files.
5294
5295 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
5296
5297         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
5298
5299 For older changes see ChangeLog-2018.
5300 \f
5301 Local Variables:
5302 mode: change-log
5303 left-margin: 8
5304 fill-column: 74
5305 version-control: never
5306 coding: utf-8
5307 End:
5308