Remove cleanup from remote.c
[external/binutils.git] / gdb / ChangeLog
1 2019-01-15  Tom Tromey  <tom@tromey.com>
2
3         * remote.c (class remote_state) <buf>: Now a char_vector.
4         <buf_size>: Remove.
5         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
6         parameter.
7         (remote_target::getpkt_or_notif_sane_1)
8         (remote_target::getpkt_sane)
9         (remote_target::getpkt_or_notif_sane): Likewise.
10         (class remote_target) <putpkt>: New overload.
11         (remote_target::read_frame): Change type of "buf_p".  Remove
12         sizeof_p parameter.
13         (packet_ok): New overload.
14         (packet_check_result): New overload.
15         Update all uses.
16
17 2019-01-14  Tom Tromey  <tom@tromey.com>
18
19         * remote-notif.c (handle_notification, remote_notif_ack)
20         (remote_notif_parse): Make "buf" const.
21         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
22         const.
23         (remote_notif_parse, remote_notif_ack, handle_notification):
24         Likewise.
25         * remote.c (remote_notif_stop_parse): Make "buf" const.
26         (remote_target::remote_parse_stop_reply): Make "buf" const.
27         (remote_notif_stop_ack): Make "buf" const.
28
29 2019-01-14  Tom Tromey  <tom@tromey.com>
30
31         * remote.c (remote_console_output): Make parameter const.
32
33 2019-01-14  Tom Tromey  <tom@tromey.com>
34
35         * target-debug.h (target_debug_print_signals): Constify.
36         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
37         * procfs.c (procfs_target::pass_signals): Update.
38         * linux-nat.c (linux_nat_target::pass_signals): Update.
39         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
40         * target-delegates.c: Rebuild.
41         * remote.c (remote_target::program_signals): Update.
42         (remote_target::pass_signals): Update.
43         * target.c (target_pass_signals): Constify argument.
44         (target_program_signals): Likewise.
45         * target.h (struct target_ops) <pass_signals, program_signals>:
46         Constify argument.
47         (target_pass_signals, target_program_signals): Constify argument.
48
49 2019-01-14  Tom Tromey  <tom@tromey.com>
50
51         PR tui/28819:
52         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
53
54 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
55
56         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
57         field.
58         * rs6000-tdep.c: Include reggroups.h.
59         (IS_V_ALIAS_PSEUDOREG): Define.
60         (rs6000_register_name): Return names for the "vX" aliases.
61         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
62         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
63         aliases.  Call default_register_reggroup_p for all other
64         pseudo-registers.
65         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
66         New functions.
67         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
68         Handle "vX" aliases.
69         (v_alias_pseudo_register_collect): New function.
70         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
71         (rs6000_gdbarch_init): Initialize "vX" aliases as
72         pseudo-registers.  Restore registration of
73         rs6000_pseudo_register_reggroup_p with
74         set_tdesc_pseudo_register_reggroup_p.
75
76 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
77
78         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
79         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
80         set_gdbarch_num_pseudo_regs.
81
82 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
83
84         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
85         Remove arg prefixname, add do_set and do_show.
86         Add member functions set_list and show_list.
87         * cli/cli-style.c (class cli_style_option): Update accordingly.
88         (style_set_list): Move to file scope.
89         (style_show_list): Likewise.
90         (set_style): Call help_list.
91         (show_style): Call cmd_show_list.
92         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
93         Update to use the new macro.
94
95 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
96
97         * ada-lang.c (_initialize_ada_language): Expand the help text
98         for the "catch exception" command.
99
100 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
101
102         * symtab.c (matching_obj_sections): Initialize obj,
103         declare it closer to its usage.
104
105 2019-01-10  Tom Tromey  <tom@tromey.com>
106
107         * thread-iter.h (inf_threads_iterator): Use next_iterator.
108         (basic_inf_threads_range): Remove.
109         (inf_threads_range, inf_non_exited_threads_range)
110         (safe_inf_threads_range): Use next_adapter.
111
112 2019-01-10  Keith Seitz  <keiths@redhat.com>
113
114         PR gdb/23712
115         PR symtab/23010
116         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
117         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
118
119 2019-01-10  Keith Seitz  <keiths@redhat.com>
120
121         PR gdb/23712
122         PR symtab/23010
123         * dictionary.c (pending_to_vector): Remove.
124         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
125         Remove _1 suffix, replacing functions of the same name.  Update
126         all callers.
127         (dict_create_hashed, dict_create_hashed_expandable)
128         (dict_create_linear, dict_create_linear_expandable, dict_free)
129         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
130         Make functions static.
131
132 2019-01-10  Keith Seitz  <keiths@redhat.com>
133
134         PR gdb/23712
135         PR symtab/23010
136         * dictionary.h (struct dictionary): Replace declaration with
137         multidictionary.
138         (dict_create_hashed, dict_create_hashed_expandable)
139         (dict_create_linear, dict_create_linear_expandable)
140         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
141         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
142         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
143         taking multidictionary argument.
144         [ALL_DICT_SYMBOLS]: Update for multidictionary.
145         * block.h (struct block) <dict>: Change to multidictionary
146         and rename `multidict'.
147         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
148         symmisc.c: Update all dictionary references to multidictionary.
149
150 2019-01-10  Keith Seitz  <keiths@redhat.com>
151
152         PR gdb/23712
153         PR symtab/23010
154         * dictionary.c: Include unordered_map.
155         (pending_to_vector): New function.
156         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
157         Rewrite the non-"_1" functions to take vector instead
158         of linked list.
159         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
160         "new" _1 versions of the same name.
161         (multidictionary): Define.
162         (std::hash<enum language): New definition.
163         (collate_pending_symbols_by_language, mdict_create_hashed)
164         (mdict_create_hashed_expandable, mdict_create_linear)
165         (mdict_create_linear_expandable, mdict_free)
166         (find_language_dictionary, create_new_language_dictionary)
167         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
168         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
169         (mdict_size, mdict_empty): New functions.
170         * dictionary.h (mdict_iterator): Define.
171
172 2019-01-10  Pedro Alves  <palves@redhat.com>
173
174         * breakpoint.c (read_uploaded_action)
175         (create_tracepoint_from_upload): Adjust to use
176         gdb::unique_xmalloc_ptr.
177         * ctf.c (ctf_write_uploaded_tp):
178         (SET_ARRAY_FIELD): Use emplace_back.
179         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
180         * tracefile-tfile.c (tfile_write_uploaded_tp):
181         * tracepoint.c (parse_tracepoint_definition): Adjust to use
182         gdb::unique_xmalloc_ptr.
183         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
184         at_string, cond_string, cmd_strings>: Replace char pointers
185         with gdb::unique_xmalloc_ptr.
186
187 2019-01-10  Pedro Alves  <palves@redhat.com>
188
189         * solib-target.c (library_list_start_library): Don't xstrdup name.
190
191 2019-01-10  Pedro Alves  <palves@redhat.com>
192
193         * mdebugread.c (parse_partial_symbols): Use
194         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
195
196 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
197
198         * linux-fork.c (scoped_switch_fork_info)
199         <~scoped_switch_fork_info>: Fix incorrect variable name.
200
201 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
202
203         * linux-fork.c (scoped_switch_fork_info)
204         <scoped_switch_fork_info>: Make explicit.
205         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
206
207 2019-01-10  Tom Tromey  <tom@tromey.com>
208
209         * objfiles.h (objfile::reset_psymtabs): Update.
210         * objfiles.c (objfile::objfile): Update.
211         * psymtab.h (psymtab_storage::obstack): Update.
212         (psymtab_storage::m_obstack): Use gdb::optional.
213         (class psymtab_storage): Update comment.  Remove objfile
214         parameter.
215         * psymtab.c (psymtab_storage::psymtab_storage): Update.
216
217 2019-01-10  Tom Tromey  <tom@tromey.com>
218
219         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
220         <free_psymtabs>: Now private.
221         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
222         (allocate_psymtab): Use new method.
223
224 2019-01-10  Tom Tromey  <tom@tromey.com>
225
226         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
227         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
228         * mdebugread.c (parse_partial_symbols): Use
229         allocate_dependencies.
230         * dwarf2read.c (dwarf2_create_include_psymtab): Use
231         allocate_dependencies.
232         (process_psymtab_comp_unit_reader)
233         (build_type_psymtab_dependencies): Likewise.
234         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
235
236 2019-01-10  Tom Tromey  <tom@tromey.com>
237
238         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
239         PSYMBOL_SET_LANGUAGE.
240         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
241
242 2019-01-10  Tom Tromey  <tom@tromey.com>
243
244         * psymtab.h (psymtab_storage::obstack): New method.
245         <m_obstack>: Rename from obstack; now private.
246         * psymtab.c (psymtab_storage): Update.
247         * dwarf2read.c (create_addrmap_from_index)
248         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
249         Update.
250
251 2019-01-10  Tom Tromey  <tom@tromey.com>
252
253         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
254         * objfiles.h (objfile::reset_psymtabs): New method.
255
256 2019-01-10  Tom Tromey  <tom@tromey.com>
257
258         * symmisc.c (print_symbol_bcache_statistics): Update.
259         (print_objfile_statistics): Update.
260         * symfile.c (reread_symbols): Update.
261         * psymtab.h (class psymtab_storage): New.
262         * psymtab.c (psymtab_storage): New constructor.
263         (~psymtab_storage): New destructor.
264         (require_partial_symbols): Update.
265         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
266         (find_pc_sect_psymtab, find_pc_sect_psymbol)
267         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
268         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
269         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
270         (start_psymtab_common, end_psymtab_common)
271         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
272         (allocate_psymtab): Update.
273         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
274         Update.
275         (dump_psymtab_addrmap, maintenance_print_psymbols)
276         (maintenance_check_psymtabs): Update.
277         (class objfile_psymtabs): Move to objfiles.h.
278         * psympriv.h (discard_psymtab): Now inline.
279         (psymtab_discarder::psymtab_discarder): Update.
280         (psymtab_discarder::~psymtab_discarder): Update.
281         (ALL_OBJFILE_PSYMTABS): Rewrite.
282         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
283         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
284         Remove fields.
285         <partial_symtabs>: New field.
286         (class objfile_psymtabs): Move from psymtab.h.  Update.
287         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
288         psymbol_cache.
289         (objfile::~objfile): Don't destroy psymbol_cache.
290         * mdebugread.c (parse_partial_symbols): Update.
291         * dwarf2read.c (create_addrmap_from_index)
292         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
293         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
294         (add_partial_subprogram, dwarf2_ranges_read): Update.
295         * dwarf-index-write.c (write_address_map)
296         (write_one_signatured_type, recursively_write_psymbols)
297         (class debug_names, class debug_names, write_psymtabs_to_index):
298         Update.
299
300 2019-01-10  Tom Tromey  <tom@tromey.com>
301
302         * symtab.h (SYMBOL_SET_NAMES): Update.
303         (symbol_set_names): Update.
304         (MSYMBOL_SET_NAMES): Update.
305         * symtab.c (symbol_set_names): Change argument to be an
306         objfile_per_bfd_storage.
307         * psymtab.c (add_psymbol_to_bcache): Update.
308         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
309
310 2019-01-10  Tom Tromey  <tom@tromey.com>
311
312         * symtab.c (create_demangled_names_hash): Change argument to be an
313         objfile_per_bfd_storage.
314         (symbol_set_names): Update.
315
316 2019-01-10  Tom Tromey  <tom@tromey.com>
317
318         * xcoffread.c (xcoff_initial_scan): Unconditionally call
319         init_psymbol_list.
320         * psymtab.c (init_psymbol_list): Do nothing if already called.
321         * psympriv.h (init_psymbol_list): Add comment.
322         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
323         init_psymbol_list.
324         * dbxread.c (dbx_symfile_read): Unconditionally call
325         init_psymbol_list.
326
327 2019-01-10  Tom Tromey  <tom@tromey.com>
328
329         * xcoffread.c (scan_xcoff_symtab): Update.
330         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
331         "where".
332         * mdebugread.c (parse_partial_symbols)
333         (handle_psymbol_enumerators): Update.
334         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
335         * dbxread.c (read_dbx_symtab): Update.
336         * psympriv.h (psymbol_placement): New enum.
337         (add_psymbol_to_list): Update.
338
339 2019-01-10  Tom Tromey  <tom@tromey.com>
340
341         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
342         static_psymbols parameters.
343         (scan_xcoff_symtab): Update.
344         * psymtab.c (start_psymtab_common): Remove global_psymbols and
345         static_psymbols parameters.
346         * psympriv.h (start_psymtab_common): Update.
347         * mdebugread.c (parse_partial_symbols): Update.
348         * dwarf2read.c (create_partial_symtab): Update.
349         * dbxread.c (read_dbx_symtab): Update.
350         (start_psymtab): Remove global_psymbols and static_psymbols
351         parameters.
352
353 2019-01-10  Tom Tromey  <tom@tromey.com>
354
355         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
356         * psymtab.c (allocate_psymtab): Add comment.
357         * psympriv.h (allocate_psymtab): Add comment.
358         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
359         initializations.
360         * dbxread.c (dbx_end_psymtab): Remove some initializations.
361
362 2019-01-10  Tom Tromey  <tom@tromey.com>
363
364         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
365         Don't declare.
366         * mipsread.c: Include mdebugread.h.
367         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
368         Declare.
369         * elfread.c: Include mdebugread.h.
370
371 2019-01-09  Tom Tromey  <tom@tromey.com>
372
373         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
374         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
375         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
376         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
377         (psym_lookup_symbol, psym_find_last_source_symtab)
378         (psym_forget_cached_source_info, psym_print_stats)
379         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
380         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
381         (psym_map_matching_symbols, psym_expand_symtabs_matching)
382         (psym_find_compunit_symtab_by_address)
383         (maintenance_print_psymbols, maintenance_info_psymtabs)
384         (maintenance_check_psymtabs): Use ranged for.
385         * psymtab.h (class objfile_psymtabs): New.
386         (require_partial_symbols): Return objfile_psymtabs.
387         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
388
389 2019-01-09  Tom Tromey  <tom@tromey.com>
390
391         * symfile.c (overlay_invalidate_all, find_pc_overlay)
392         (find_pc_mapped_section, list_overlays_command)
393         (map_overlay_command, unmap_overlay_command)
394         (simple_overlay_update): Use all_objfiles.
395         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
396         * printcmd.c (info_symbol_command): Use all_objfiles.
397         * objfiles.h (ALL_OBJSECTIONS): Remove.
398         * maint.c (maintenance_translate_address): Use all_objfiles.
399         * gcore.c (gcore_create_callback): Use all_objfiles.
400         (objfile_find_memory_regions): Likewise.
401
402 2019-01-09  Tom Tromey  <tom@tromey.com>
403
404         * symtab.c (find_line_symtab, info_sources_command)
405         (make_source_files_completion_list): Use objfile_compunits.
406         * source.c (select_source_symtab): Use objfile_compunits.
407         * objfiles.h (struct objfile): Update comment.
408         (ALL_OBJFILES): Remove.
409         (ALL_FILETABS): Remove.
410         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
411         objfile_compunits.
412
413 2019-01-09  Tom Tromey  <tom@tromey.com>
414
415         * symmisc.c (print_objfile_statistics, dump_objfile)
416         (maintenance_print_symbols): Use compunit_filetabs.
417         * source.c (forget_cached_source_info_for_objfile): Use
418         compunit_filetabs.
419         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
420         (ALL_FILETABS): Use compunit_filetabs.
421         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
422         * coffread.c (coff_symtab_read): Use compunit_filetabs.
423
424 2019-01-09  Tom Tromey  <tom@tromey.com>
425
426         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
427         (compunit_filetabs): New.
428         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
429         compunit_filetabs.
430         (info_sources_command, make_source_files_completion_list): Remove
431         declaration.
432         * symmisc.c (print_objfile_statistics, dump_objfile)
433         (maintenance_print_symbols): Remove declaration.
434         (maintenance_info_symtabs): Use compunit_filetabs.
435         (maintenance_info_line_tables): Likewise.
436         * source.c (select_source_symtab): Change local variable name.
437         (forget_cached_source_info_for_objfile): Remove declaration.
438         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
439         * objfiles.c (objfile_relocate1): Remove declaration.
440         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
441         declaration.
442         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
443         * coffread.c (coff_symtab_read): Remove declaration.
444         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
445         compunit_filetabs.
446
447 2019-01-09  Tom Tromey  <tom@tromey.com>
448
449         * symtab.c (lookup_objfile_from_block)
450         (find_pc_sect_compunit_symtab, search_symbols)
451         (default_collect_symbol_completion_matches_break_on): Use
452         objfile_compunits.
453         * objfiles.h (ALL_COMPUNITS): Remove.
454         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
455         * cp-support.c (add_symbol_overload_list_qualified): Use
456         objfile_compunits.
457         * ada-lang.c (ada_collect_symbol_completion_matches)
458         (ada_add_global_exceptions): Use objfile_compunits.
459
460 2019-01-09  Tom Tromey  <tom@tromey.com>
461
462         * source.c (select_source_symtab)
463         (forget_cached_source_info_for_objfile): Remove declaration.
464         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
465         declaration.
466         * maint.c (count_symtabs_and_blocks): Remove declaration.
467         * cp-support.c (add_symbol_overload_list_qualified): Remove
468         declaration.
469         * coffread.c (coff_symtab_read): Remove declaration.
470         * symtab.c (lookup_symbol_in_objfile_symtabs)
471         (basic_lookup_transparent_type_1): Use objfile_compunits.
472         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
473         (info_sources_command, search_symbols)
474         (default_collect_symbol_completion_matches_break_on)
475         (make_source_files_completion_list): Remove declaration.
476         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
477         (ada_collect_symbol_completion_matches)
478         (ada_add_global_exceptions): Remove declaration.
479         * linespec.c (iterate_over_all_matching_symtabs): Use
480         objfile_compunits.
481         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
482         (class objfile_compunits): New.
483         (ALL_COMPUNITS): Use objfile_compunits.
484         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
485         (maintenance_check_symtabs, maintenance_info_line_tables): Use
486         objfile_compunits.
487         * objfiles.c (objfile_relocate1): Use objfile_compunits.
488
489 2019-01-09  Tom Tromey  <tom@tromey.com>
490
491         * symtab.c (search_symbols)
492         (default_collect_symbol_completion_matches_break_on): Use
493         objfile_msymbols.
494         * ada-lang.c (ada_lookup_simple_minsym)
495         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
496         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
497         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
498         objfile_msymbols.
499         * coffread.c (coff_symfile_read): Use objfile_msymbols.
500         * symmisc.c (dump_msymbols): Use objfile_msymbols.
501         * objc-lang.c (find_methods): Use objfile_msymbols.
502         (info_selectors_command, info_classes_command): Likewise.
503         * stabsread.c (scan_file_globals): Use objfile_msymbols.
504         * objfiles.h (class objfile_msymbols): New.
505         (ALL_OBJFILE_MSYMBOLS): Remove.
506         (ALL_MSYMBOLS): Remove.
507
508 2019-01-09  Tom Tromey  <tom@tromey.com>
509
510         * common/next-iterator.h (next_adapter): Add Iterator template
511         parameter.
512         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
513         (class all_objfiles_safe): New.
514         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
515         * objfiles.c (put_objfile_before): Update comment.
516         (add_separate_debug_objfile): Likewise.
517         (free_all_objfiles): Use all_objfiles_safe.
518         (objfile_purge_solibs): Likewise.
519
520 2019-01-09  Tom Tromey  <tom@tromey.com>
521
522         * symtab.c (iterate_over_symtabs, matching_obj_sections)
523         (expand_symtab_containing_pc, lookup_static_symbol)
524         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
525         (find_symbol_at_address, find_line_symtab, find_main_name): Use
526         all_objfiles.
527         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
528         * breakpoint.c (create_overlay_event_breakpoint)
529         (create_longjmp_master_breakpoint)
530         (create_std_terminate_master_breakpoint)
531         (create_exception_master_breakpoint): Use all_objfiles.
532         * linux-thread-db.c (try_thread_db_load_from_pdir)
533         (has_libpthread): Use all_objfiles.
534         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
535         * linespec.c (iterate_over_all_matching_symtabs)
536         (search_minsyms_for_name): Use all_objfiles.
537         * maint.c (maintenance_info_sections): Use all_objfiles.
538         * main.c (captured_main_1): Use all_objfiles.
539         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
540         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
541         * guile/scm-pretty-print.c
542         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
543         * solib-spu.c (append_ocl_sos): Use all_objfiles.
544         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
545         (maintenance_print_msymbols): Use all_objfiles.
546         * source.c (select_source_symtab): Use all_objfiles.
547         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
548         * symfile.c (remove_symbol_file_command)
549         (expand_symtabs_matching, map_symbol_filenames): Use
550         all_objfiles.
551         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
552         all_objfiles.
553         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
554         * objc-lang.c (find_methods): Use all_objfiles.
555         * objfiles.c (have_partial_symbols, have_full_symbols)
556         (have_minimal_symbols, qsort_cmp)
557         (default_iterate_over_objfiles_in_search_order): Use
558         all_objfiles.
559         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
560         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
561         (maintenance_check_psymtabs): Use all_objfiles.
562         (ALL_PSYMTABS): Remove.
563         * compile/compile-object-run.c (do_module_cleanup): Use
564         all_objfiles.
565         * blockframe.c (find_pc_partial_function): Use all_objfiles.
566         * cp-support.c (add_symbol_overload_list_qualified): Use
567         all_objfiles.
568         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
569         Use all_objfiles.
570         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
571         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
572         all_objfiles.
573         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
574         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
575         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
576         Uses all_objfiles.
577         * solib.c (solib_read_symbols): Use all_objfiles
578
579 2019-01-09  Tom Tromey  <tom@tromey.com>
580
581         * probe.c (parse_probes_in_pspace): Use all_objfiles.
582         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
583         all_objfiles.
584         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
585         * symmisc.c (print_symbol_bcache_statistics)
586         (print_objfile_statistics, maintenance_print_objfiles)
587         (maintenance_info_symtabs, maintenance_check_symtabs)
588         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
589         all_objfiles.
590         * source.c (forget_cached_source_info): Use all_objfiles.
591         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
592         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
593         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
594         * objfiles.c (update_section_map): Use all_objfiles.
595         (shared_objfile_contains_address_p): Likewise.
596         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
597         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
598
599 2019-01-09  Tom Tromey  <tom@tromey.com>
600
601         * common/next-iterator.h: New file.
602         * objfiles.h (class all_objfiles): New.
603         (struct objfile_iterator): New.
604
605 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
606
607         * NEWS: Move the description of the changed "frame", "select-frame",
608          and "info frame" commands to the Changed commands section.
609
610 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
611
612         * gdbtypes.c (check_stub_method_group): Remove handling of old
613         mangling schemes.
614         * linespec.c (find_methods): Likewise.
615         * stabsread.c (read_member_functions): Likewise.
616         * valops.c (search_struct_method): Likewise.
617         (value_struct_elt_for_reference): Likewise.
618         * NEWS: Mention this change.
619
620 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
621
622         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
623         print_source_lines.
624         * source.c (print_source_lines_base): Update line number check.
625         (print_source_lines): New function.
626         (source_lines_range::source_lines_range): New function.
627         * source.h (class source_lines_range): New class.
628         (print_source_lines): New declaration.
629
630 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
631
632         * linespec.c (linespec_state_destructor): Free self->canonical_names.
633
634 2019-01-08  Tom Tromey  <tom@tromey.com>
635             Simon Marchi  <simon.marchi@ericsson.com>
636
637         PR gdb/24060
638         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
639         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
640         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
641         * f-exp.y (DOLLAR_VARIABLE): Likewise.
642         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
643         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
644
645 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
646
647         * source.c (select_source_symtab): Move header comment to
648         declaration in source.h.
649         (forget_cached_source_info_for_objfile): Likewise.
650         (forget_cached_source_info): Likewise.
651         (identify_source_line): Likewise.
652         * source.h (identify_source_line): Move declaration from symtab.h
653         and add comment from source.c
654         (print_source_lines): Likewise.
655         (forget_cached_source_info_for_objfile): Likewise.
656         (forget_cached_source_info): Likewise.
657         (select_source_symtab): Likewise.
658         (enum print_source_lines_flag): Move definition from symtab.h.
659         * symtab.h (identify_source_line): Move declaration to source.h.
660         (print_source_lines): Likewise.
661         (forget_cached_source_info_for_objfile): Likewise.
662         (forget_cached_source_info): Likewise.
663         (select_source_symtab): Likewise.
664         (enum print_source_lines_flag): Move definition to source.h.
665         * tui/tui-hooks.c: Add 'source.h' include.
666
667 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
668
669         * source.c (print_source_lines_base): Handle requests to print
670         reverse line number sequences, and guard against empty lines
671         string.
672
673 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
674
675         * source.c (print_source_lines_base): Fix skip of '\r' if next
676         character is '\n'.
677
678 2019-01-06  Tom Tromey  <tom@tromey.com>
679
680         * c-exp.y (struct c_parse_state) <macro_original_text,
681         expansion_obstack>: New member.
682         (macro_original_text, expansion_obstack): Remove globals.
683         (scan_macro_expansion, scanning_macro_expansion)
684         (finished_macro_expansion): Update.
685         (scan_macro_cleanup): Remove.
686         (yylex, c_parse): Update.
687
688 2019-01-06  Tom Tromey  <tom@tromey.com>
689
690         * c-exp.y (struct c_parse_state) <strings>: New member.
691         (operator_stoken): Update.
692
693 2019-01-06  Tom Tromey  <tom@tromey.com>
694
695         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
696         (union type_stack_elt) <typelist_val>: Now a pointer to
697         std::vector.
698         (type_stack_cleanup): Don't declare.
699         (push_typelist): Update.
700         * parse.c (pop_typelist): Return a std::vector.
701         (push_typelist): Take a std::vector.
702         (follow_types): Update.  Do not free args.
703         (type_stack_cleanup): Remove.
704         * c-exp.y (struct c_parse_state): New.
705         (cpstate): New global.
706         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
707         (nonempty_typelist): Update.
708         (func_mod): Create a new vector.
709         (c_parse): Create a c_parse_state.
710         (check_parameter_typelist): Do not delete params.
711         (function_method): Update.  Do not delete type_list.
712
713 2019-01-06  Tom Tromey  <tom@tromey.com>
714
715         PR gdb/28155:
716         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
717         check_typedef.
718         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
719         (print_return_value): Likewise.
720
721 2019-01-05  Tom Tromey  <tom@tromey.com>
722
723         * contrib/cleanup_check.py: Remove.
724         * contrib/gcc-with-excheck: Remove.
725         * contrib/exsummary.py: Remove.
726         * contrib/excheck.py: Remove.
727
728 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
729
730         * thread.c (delete_thread_1): Add gdb_assert that THR is not
731         NULL. Initialize tpprev to NULL instead of assigning it
732         to NULL on the next statement.
733         * windows-nat.c (windows_delete_thread): Remove check for
734         main_thread_id before printing thread exit notifications.
735         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
736         Remove thread ID check against main_thread_id.
737         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
738         windows_delete_thread.
739         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
740
741 2019-01-04  Tom Tromey  <tom@tromey.com>
742
743         * compile/compile.c (_initialize_compile): Use upper case for
744         metasyntactic variables.
745         * symmisc.c (_initialize_symmisc): Use upper case for
746         metasyntactic variables.
747         * psymtab.c (_initialize_psymtab): Use upper case for
748         metasyntactic variables.
749         * demangle.c (demangle_command): Use upper case for metasyntactic
750         variables.
751         (_initialize_demangler): Likewise.
752         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
753         variables.
754
755 2019-01-03  Tom Tromey  <tom@tromey.com>
756
757         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
758
759 2019-01-03  Tom Tromey  <tom@tromey.com>
760
761         * python/py-symtab.c (salpy_str): Update.
762         (struct salpy_sal_object) <symtab>: Now a PyObject.
763         (salpy_dealloc): Update.
764         (del_objfile_sal): Use gdbpy_ref.
765
766 2019-01-03  Tom Tromey  <tom@tromey.com>
767
768         * python/py-type.c (convert_field): Use new_reference.  Return
769         gdbpy_ref.
770         (make_fielditem): Return gdbpy_ref.
771         (typy_fields): Update.
772         (typy_getitem): Update.
773         (field_name): Return gdbpy_ref.  Use new_reference.
774         (typy_iterator_iternext): Update.
775
776 2019-01-03  Tom Tromey  <tom@tromey.com>
777
778         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
779
780 2019-01-03  Tom Tromey  <tom@tromey.com>
781
782         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
783         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
784         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
785         (pspy_set_frame_filters, pspy_set_frame_unwinders)
786         (pspy_set_type_printers): Likewise.
787         * python/py-function.c (fnpy_init): Use gdbpy_ref.
788         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
789         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
790         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
791         (objfpy_set_type_printers): Likewise.
792
793 2019-01-03  Tom Tromey  <tom@tromey.com>
794
795         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
796         (gdbpy_print_stack): Use gdbpy_err_fetch.
797         * python/python-internal.h (class gdbpy_err_fetch): New class.
798         (class gdbpy_enter) <m_error_type, m_error_value,
799         m_error_traceback>: Remove.
800         <m_error>: New member.
801         (gdbpy_exception_to_string): Don't declare.
802         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
803         * python/py-value.c (convert_value_from_python): Use
804         gdbpy_err_fetch.
805         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
806         gdbpy_exception_to_string.
807         (gdbpy_handle_exception): Use gdbpy_err_fetch.
808         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
809         gdbpy_err_fetch.
810
811 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
812
813         * linux-nat.c (delete_lwp_cleanup): Delete.
814         (struct lwp_deleter): New struct.
815         (lwp_info_up): New typedef.
816         (linux_nat_target::follow_fork): Delete cleanup, and make use of
817         lwp_info_up.
818
819 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
820
821         * linux-fork.c (class scoped_switch_fork_info): New class.
822         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
823
824 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
825
826         * valops.c (find_overload_match): Remove use of null_cleanup, and
827         calls to do_cleanups.
828
829 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
830
831         * compile/compile-cplus-types.c
832         (compile_cplus_instance::decl_name): Handle changes to
833         cp_func_name.
834         * cp-support.c (cp_func_name): Update header comment, update
835         return type.
836         * cp-support.h (cp_func_name): Update return type in declaration.
837         * valops.c (find_overload_match): Move temp_func local to top
838         level of function and change its type.  Use temp_func to hold and
839         delete temporary string obtained from cp_func_name.
840
841 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
842
843         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
844         gdb::char_vector, remove cleanup, and update uses of `msg`.
845
846 2019-01-03  Jim Wilson  <jimw@sifive.com>
847
848         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
849
850 2019-01-02  Tom Tromey  <tom@tromey.com>
851
852         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
853         (tdesc_parse_xml): Remove cleanups.
854         * target-descriptions.h (make_cleanup_free_target_description):
855         Don't declare.
856         (target_desc_deleter): New struct.
857         (target_desc_up): New typedef.
858         * target-descriptions.c (target_desc_deleter::operator()): Rename
859         from free_target_description.
860         (make_cleanup_free_target_description): Remove.
861
862 2019-01-02  Tom Tromey  <tom@tromey.com>
863
864         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
865         constructor, destructor.
866         (linespec_parser): Remove typedef.
867         (~linespec_parser): Rename from linespec_parser_delete.
868         (linespec_lex_to_end, linespec_complete_label)
869         (linespec_complete): Update.
870         (decode_line_full): Remove cleanups.
871         (decode_line_1): Update.
872
873 2019-01-02  Tom Tromey  <tom@tromey.com>
874
875         * python/python-internal.h (inferior_to_inferior_object): Change
876         return type.
877         * python/py-exitedevent.c (create_exited_event_object): Update.
878         * python/py-inferior.c (inferior_to_inferior_object): Return
879         gdbpy_ref.
880         (python_new_inferior, python_inferior_deleted)
881         (thread_to_thread_object, delete_thread_object)
882         (build_inferior_list, gdbpy_selected_inferior): Update.
883         * python/py-infthread.c (create_thread_object): Update.  Also fail
884         if inferior_to_inferior_object fails.
885
886 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
887
888         * inferior.h (class inferior) <displaced_step_state>: New field.
889         * infrun.h (struct displaced_step_state): Move here from
890         infrun.c.  Initialize fields, add constructor.
891         <inf>: Remove field.
892         <reset>: New method.
893         * infrun.c (struct displaced_step_inferior_state): Move to
894         infrun.h.
895         (displaced_step_inferior_states): Remove.
896         (get_displaced_stepping_state): Adust.
897         (displaced_step_in_progress_any_inferior): Adjust.
898         (displaced_step_in_progress_thread): Adjust.
899         (displaced_step_in_progress): Adjust.
900         (add_displaced_stepping_state): Remove.
901         (get_displaced_step_closure_by_addr): Adjust.
902         (remove_displaced_stepping_state): Remove.
903         (infrun_inferior_exit): Call displaced_step_state.reset.
904         (use_displaced_stepping): Don't check for NULL.
905         (displaced_step_prepare_throw): Call
906         get_displaced_stepping_state.
907         (displaced_step_fixup): Don't check for NULL.
908         (prepare_for_detach): Don't check for NULL.
909
910 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
911
912         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
913          in case of call that did not complete.
914
915 2019-01-02  Andrey Utkin  <autkin@undo.io>
916
917         * symfile.c (find_separate_debug_file): Fix search of debug files for
918         remote debuggee.
919
920 2019-01-02  Tom Tromey  <tom@tromey.com>
921
922         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
923         indentation.
924         * python/py-frame.c (frapy_older): Remove cast.
925         (frapy_newer): Likewise.
926         * python/py-breakpoint.c (local_setattro): Remove cast.
927         * python/py-arch.c (archpy_name): Remove local variable.
928         * python/py-type.c (gdbpy_lookup_type): Remove cast.
929
930 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
931
932         * unittests/basic_string_view/element_access/char/empty.cc:
933         Fix year range in copyright header.
934
935 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
936
937         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
938         Delete.
939         <operator==>: Update with for removed field.
940         <hash>: Likewise.
941         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
942         <isa_features>: ...this.
943         <abi_features>: New field.
944         (riscv_isa_flen): Update comment.
945         (riscv_abi_xlen): New declaration.
946         (riscv_abi_flen): New declaration.
947         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
948         isa_features.
949         (riscv_abi_xlen): New function.
950         (riscv_isa_flen): Update to get answer from isa_features.
951         (riscv_abi_flen): New function.
952         (riscv_has_fp_abi): Update to get answer from abi_features.
953         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
954         xlen and flen.
955         (riscv_call_info) <xlen, flen>: Update comment.
956         (riscv_call_arg_struct): Remove invalid assertions
957         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
958         is removed.
959         (riscv_gdbarch_init): Gather isa features and abi features
960         separately, ensure both match on the gdbarch when reusing an old
961         gdbarch.  Relax an error check to allow 32-bit abi float to run on
962         a target with 64-bit float hardware.
963
964 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
965
966         * source.c (search_command_helper): Stop reverse search
967         when line 1 has been searched.
968
969 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
970
971         * record-full.c (record_full_base_target::close): Rewrite
972         record_full_core_buf_list free logic.
973
974 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
975
976         * break-catch-syscall.c (print_one_catch_syscall): xfree
977         the last text.
978
979 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
980
981         * top.c (print_gdb_version): Update Copyright year in version
982         message.
983
984 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
985
986         Update copyright year range in all GDB files.
987
988 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
989
990         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
991
992 For older changes see ChangeLog-2018.
993 \f
994 Local Variables:
995 mode: change-log
996 left-margin: 8
997 fill-column: 74
998 version-control: never
999 coding: utf-8
1000 End:
1001