gdb: Add $_cimag and $_creal internal functions
[external/binutils.git] / gdb / ChangeLog
1 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2
3         * NEWS: Mention new internal functions.
4         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
5         (read_base_type): Use dwarf2_init_complex_target_type.
6         * value.c (creal_internal_fn): New function.
7         (cimag_internal_fn): New function.
8         (_initialize_values): Register new internal functions.
9
10 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11
12         * infrun.c (stop_all_threads): If debug_infrun, always
13         trace the wait status after wait_one, using
14         target_waitstatus_to_string and target_pid_to_str.
15         (handle_inferior_event): Replace various trace of
16         wait status kind by a single trace.
17         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
18         wait status kind image by target_waitstatus_to_string.
19         * target/waitstatus.c (target_waitstatus_to_string): Fix
20         obsolete comment.
21
22 2019-04-01  Tom Tromey  <tromey@adacore.com>
23
24         PR symtab/23331:
25         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
26
27 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
28             Pedro Alves  <palves@redhat.com>
29
30         * top.c (quit_force): Call 'finalize_values'.
31         * value.c (finalize_values): New function.
32         * value.h (finalize_values): Declare.
33
34 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
35
36         * NEWS: Announce $_gdb_major and $_gdb_minor.
37
38         * top.c (init_gdb_version_vars): New function.
39         (gdb_init): Call init_gdb_version_vars.
40
41 2019-03-29  Tom Tromey  <tromey@adacore.com>
42
43         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
44         help text.  Remove dead code.
45
46 2019-03-29  Keith Seitz  <keiths@redhat.com>
47
48         From Siddhesh Poyarekar:
49         * f-lang.h (f77_get_upperbound): Return LONGEST.
50         (f77_get_lowerbound): Likewise.
51         * f-typeprint.c (f_type_print_varspec_suffix): Expand
52         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
53         print them.
54         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
55         plongest to format print it.
56         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
57         (f77_get_upperbound): Likewise.
58         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
59         LOWER_BOUND to LONGEST.
60         (f77_create_arrayprint_offset_tbl): Likewise.
61
62 2019-03-29  Keith Seitz  <keiths@redhat.com>
63
64         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
65         %s/pulongest for TYPE_LENGTH instead of %d in format
66         strings.
67         * ada-typerint.c (ada_print_type): Likewise.
68         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
69         * compile/compile-c-support.c (generate_register_struct): Likewise.
70         * gdbtypes.c (recursive_dump_type): Likewise.
71         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
72         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
73         instead of %d in format strings.
74         * riscv-tdep.c (riscv_type_alignment): Cast second argument
75         to std::min to ULONGEST.
76         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
77         instead of %d in format strings.
78         * tracepoint.c (info_scope_command): Likewise.
79         * typeprint.c (print_offset_data::update)
80         (print_offset_data::finish): Likewise.
81         * xtensa-tdep.c (xtensa_store_return_value)
82         (xtensa_push_dummy_call): Likewise.
83
84 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
85
86         * windows-nat.c (display_selector): Fixed format specifications
87         for 64-bit Cygwin.
88
89 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
90
91         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
92
93 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
94
95         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
96         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
97         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
98         (nios2_linux_init_abi): Install it.
99
100 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
101
102         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
103
104 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
105
106         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
107
108 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
109             Tom Tromey  <tromey@adacore.com>
110
111         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
112
113 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
114
115         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
116         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
117         method to compute the bounds of range types. Also print "[evaluated]"
118         if the bounds' values come from a dynamic evaluation.
119
120 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
121
122         * cp-valprint.c (cp_print_value_fields): Don't print trailing
123         whitespace when pretty printing is on.
124
125 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
126
127         * ppc-linux-nat.c: Add include.
128
129 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
130
131         * NEWS: Mention AArch64 Pointer Authentication.
132
133 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
134
135         * arm-linux-nat.c: Add include.
136
137 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
138
139         * source-cache.c (source_cache::get_source_lines): Re-read
140         fullname after calling open_source_file.
141
142 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
143
144         * NEWS: Mention TLS support for FreeBSD.
145
146 2019-03-25  Tom Tromey  <tromey@adacore.com>
147
148         * minsyms.c (BUNCH_SIZE): Update comment.
149         (~minimal_symbol_reader): Remove old comment.
150         (compact_minimal_symbols): Update comment.
151         (minimal_symbol_reader::install): Remove old comment.  Update
152         other comments.
153
154 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
155
156         * s390-linux-nat.c: Add include.
157
158 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
159
160         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
161         Call linux_get_hwcap.
162         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
163         Likewise.
164         (aarch64_linux_get_hwcap): Remove function.
165         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
166         declaration.
167         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
168         linux_get_hwcap.
169         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
170         * linux-tdep.c (linux_get_hwcap): Add function.
171         (linux_get_hwcap2): Likewise.
172         * linux-tdep.h (linux_get_hwcap): Add declaration.
173         (linux_get_hwcap2): Likewise.
174         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
175         (ppc_linux_get_hwcap2): Likewise.
176         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
177         linux_get_hwcap.
178         (ppc_linux_nat_target::insert_watchpoint): Likewise.
179         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
180         (ppc_linux_nat_target::read_description): Likewise.
181         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
182         * s390-linux-nat.c: Likewise.
183         * s390-linux-tdep.c (s390_core_read_description): Likewise.
184
185 2019-03-24  Tom Tromey  <tom@tromey.com>
186
187         * ada-lang.c (standard_lookup): Simplify initialization.
188         (ada_lookup_symbol_nonlocal): Simplify return.
189         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
190         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
191         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
192         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
193         initialization.
194         * solib.c (solib_global_lookup): Simplify.
195         * symtab.c (null_block_symbol): Remove.
196         (symbol_cache_lookup): Simplify returns.
197         (lookup_language_this): Simplify returns.
198         (lookup_symbol_aux): Simplify return.
199         (lookup_local_symbol): Simplify returns.
200         (lookup_global_symbol_from_objfile): Simplify return.
201         (lookup_symbol_in_objfile_symtabs)
202         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
203         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
204         (lookup_static_symbol, lookup_global_symbol): Simplify return.
205         * cp-namespace.c (cp_lookup_bare_symbol)
206         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
207         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
208         (cp_lookup_nested_symbol): Don't use null_block_symbol.
209         (cp_lookup_symbol_via_imports): Simplify initialization.
210         (find_symbol_in_baseclass): Likewise.
211         * symtab.h (null_block_symbol): Remove.
212         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
213         (d_lookup_nested_symbol, d_lookup_symbol_imports)
214         (d_lookup_symbol_module): Likewise.
215         (find_symbol_in_baseclass): Simplify initialization.
216
217 2019-03-24  Tom Tromey  <tom@tromey.com>
218
219         * expression.h: Don't include symtab.h.
220         (struct block): Forward declare.
221
222 2019-03-24  Tom Tromey  <tom@tromey.com>
223
224         * c-exp.y (typebase): Remove casts.
225         * gdbtypes.c (lookup_unsigned_typename, )
226         (lookup_signed_typename): Remove cast.
227         * eval.c (parse_to_comma_and_eval): Remove cast.
228         * parse.c (write_dollar_variable): Remove cast.
229         * block.h (struct block) <superblock>: Now const.
230         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
231         * psymtab.c (psym_map_matching_symbols): Make "block" const.
232         (map_block): Make "block" const.
233         * symfile.h (struct quick_symbol_functions)
234         <map_matching_symbols>: Constify block argument to "callback".
235         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
236         const.
237         (find_pc_sect_compunit_symtab): Make "b" const.
238         (find_symbol_at_address): Likewise.
239         (search_symbols): Likewise.
240         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
241         (dw2_debug_names_lookup_symbol): Likewise.
242         (dw2_map_matching_symbols): Update.
243         * p-valprint.c (pascal_val_print): Remove "block".
244         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
245         (aux_add_nonlocal_symbols): Make "block" const.
246         (resolve_subexp): Remove cast.
247         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
248         const.
249         (iterate_over_file_blocks): Likewise.
250         * f-exp.y (%union) <bval>: Remove.
251         * coffread.c (patch_opaque_types): Make "b" const.
252         * spu-tdep.c (spu_catch_start): Make "block" const.
253         * c-valprint.c (print_unpacked_pointer): Remove "block".
254         * symmisc.c (dump_symtab_1): Make "b" const.
255         (block_depth): Make "block" const.
256         * d-exp.y (%union) <bval>: Remove.
257         * cp-support.h (cp_lookup_rtti_type): Update.
258         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
259         * psymtab.c (psym_lookup_symbol): Make "block" const.
260         (maintenance_check_psymtabs): Make "b" const.
261         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
262         (enumerate_locals, enumerate_args): Update.
263         * python/py-symtab.c (stpy_global_block): Make "block" const.
264         (stpy_static_block): Likewise.
265         * inline-frame.c (block_starting_point_at): Make "new_block"
266         const.
267         * block.c (find_block_in_blockvector): Make return type const.
268         (blockvector_for_pc_sect): Make "b" const.
269         (find_block_in_blockvector): Make "b" const.
270
271 2019-03-23  Tom Tromey  <tom@tromey.com>
272
273         * varobj.c (varobj_create): Update.
274         * symfile.c (clear_symtab_users): Don't reset innermost_block.
275         * printcmd.c (display_command, do_one_display): Don't reset
276         innermost_block.
277         * parser-defs.h (enum innermost_block_tracker_type): Move to
278         expression.h.
279         (innermost_block): Update comment.
280         * parse.c (parse_exp_1): Add tracker_types parameter.
281         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
282         tracker_types parameter.  Reset innermost_block.
283         (parse_exp_in_context): Remove.
284         (parse_expression_for_completion): Update.
285         * objfiles.c (~objfile): Don't reset expression_context_block or
286         innermost_block.
287         * expression.h (enum innermost_block_tracker_type): Move from
288         parser-defs.h.
289         (parse_exp_1): Add tracker_types parameter.
290         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
291         reset innermost_block.
292
293 2019-03-23  Tom Tromey  <tom@tromey.com>
294
295         * objfiles.h: Include bcache.h.
296
297 2019-03-23  Tom Tromey  <tom@tromey.com>
298
299         * linespec.c (get_current_search_block): Use
300         scoped_restore_current_language.
301         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
302
303 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
304             Jiong Wang  <jiong.wang@arm.com>
305
306         * aarch64-linux-tdep.c
307         (aarch64_linux_iterate_over_regset_sections): Check for pauth
308         section.
309         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
310
311 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
312             Jiong Wang  <jiong.wang@arm.com>
313
314         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
315         instructions.
316         (aarch64_analyze_prologue_test): Add PACIASP test.
317         (aarch64_prologue_prev_register): Unmask PC value.
318
319 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
320             Jiong Wang  <jiong.wang@arm.com>
321
322         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
323         (aarch64_dwarf2_prev_register): Unmask PC value.
324         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
325         (aarch64_execute_dwarf_cfa_vendor_op): Check for
326         DW_CFA_AARCH64_negate_ra_state.
327         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
328
329 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
330             Jiong Wang  <jiong.wang@arm.com>
331
332         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
333         registers.
334         (aarch64_pseudo_register_name): Likewise.
335         (aarch64_pseudo_register_type): Likewise.
336         (aarch64_pseudo_register_reggroup_p): Likewise.
337         (aarch64_gdbarch_init): Add pauth registers.
338         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
339         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
340         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
341         (struct gdbarch_tdep): Add regnum for ra_state.
342
343 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
344             Jiong Wang  <jiong.wang@arm.com>
345
346         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
347
348 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
349             Jiong Wang  <jiong.wang@arm.com>
350
351         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
352         function.
353         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
354         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
355         (aarch64_gdbarch_init): Add puth registers.
356         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
357         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
358         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
359
360 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
361             Jiong Wang  <jiong.wang@arm.com>
362
363         * aarch64-linux-nat.c
364         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
365         * aarch64-linux-tdep.c
366         (aarch64_linux_core_read_description): Likewise.
367         (aarch64_linux_get_hwcap): New function.
368         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
369         (aarch64_linux_get_hwcap): New declaration.
370
371 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
372             Jiong Wang  <jiong.wang@arm.com>
373
374         * aarch64-linux-nat.c
375         (aarch64_linux_nat_target::read_description): Add pauth param.
376         * aarch64-linux-tdep.c
377         (aarch64_linux_core_read_description): Likewise.
378         * aarch64-tdep.c (struct target_desc): Add in pauth.
379         (aarch64_read_description): Add pauth param.
380         (aarch64_gdbarch_init): Likewise.
381         * aarch64-tdep.h (aarch64_read_description): Likewise.
382         * arch/aarch64.c (aarch64_create_target_description): Likewise.
383         * arch/aarch64.h (aarch64_create_target_description): Likewise.
384         * features/Makefile: Add new files.
385         * features/aarch64-pauth.c: New file.
386         * features/aarch64-pauth.xml: New file.
387
388 2019-03-20  Tom Tromey  <tromey@adacore.com>
389
390         * infrun.c (handle_inferior_event): Rename from
391         handle_inferior_event_1.  Create a scoped_value_mark.
392         (handle_inferior_event): Remove.
393
394 2019-03-19  Tom Tromey  <tromey@adacore.com>
395
396         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
397         * infrun.h (print_stop_event): Add "displays" parameter.
398         * infrun.c (print_stop_event): Add "displays" parameter.
399
400 2019-03-19  Pedro Alves  <palves@redhat.com>
401
402         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
403         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
404         to -1.  Fix TABs vs spaces.
405         (tui_ui_out::tui_ui_out): Don't initialize fields here.
406         * tui/tui-out.h (tui_ui_out) Add intro comments.
407         <m_line, m_start_of_line>: In-class initialize, and add describing
408         comment.
409
410 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
411
412         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
413         variable names.
414         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
415
416 2019-03-18  Pedro Alves  <palves@redhat.com>
417             Eli Zaretskii <eliz@gnu.org>
418
419         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
420         m_line and m_start_of_line.
421
422 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
423
424         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
425         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
426         it returns a newline.  This fixes a regression in TU mode, whereby
427         the next line is output on the same screen line as the user input.
428
429 2019-03-18  Tom Tromey  <tromey@adacore.com>
430
431         * minsyms.c (minimal_symbol_reader::install): Remove call to
432         obstack_blank.
433
434 2019-03-18  Pedro Alves  <palves@redhat.com>
435
436         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
437         New globals.
438         (apply_style): New, factored out from ...
439         (apply_ansi_escape): ... this.  Handle reverse video mode.
440         (tui_set_reverse_mode): New function.
441         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
442         * tui/tui-winsource.c (tui_show_source_line): Use
443         tui_set_reverse_mode instead of setting A_STANDOUT.
444         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
445         New setter methods.
446
447 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
448
449         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
450         Handle tabs.
451
452 2019-03-18  Tom Tromey  <tromey@adacore.com>
453
454         * ada-lang.c (empty_array): Add "high" parameter.
455         (ada_evaluate_subexp): Update.
456
457 2019-03-17  Sergei Trofimovich <siarheit@google.com>
458
459         * unittests/string_view-selftests.c: Define
460         _initialize_string_view_selftests unconditionally.
461
462 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
463
464         PR gdb/24350
465         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
466
467 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
468
469         PR gdb/24351
470         * windows-nat.c (display_selector): Fix format specifiers.
471
472 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
473
474         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
475         tui_refill_source_window instead of tui_refresh_win, to update the
476         current execution line.  This fixes redisplay of the current line
477         when stepping through the code with "next" or "step".
478
479 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
480
481         * source-cache.c (source_cache::get_source_lines): Call
482         find_source_lines to initialize s->nlines.  This fixes vertical
483         scrolling of TUI source window when the DOWN arrow is pressed.
484
485 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
486
487         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
488         linux-thread-db.c (_initialize_thread_db): Likewise.
489
490 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
491
492         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
493         wclrtoeol in tui_show_source_line".  This reverts changes made in
494         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
495
496 2019-03-15  Tom Tromey  <tom@tromey.com>
497
498         * symtab.h (struct minimal_symbol): Derive from
499         general_symbol_info.
500         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
501         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
502         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
503         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
504         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
505         (MSYMBOL_SEARCH_NAME): Update.
506         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
507         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
508         * minsyms.c (minimal_symbol_reader::record_full): Update.
509
510 2019-03-15  Tom Tromey  <tom@tromey.com>
511
512         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
513
514 2019-03-15  Tom Tromey  <tom@tromey.com>
515
516         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
517         unique_xmalloc_ptr.
518         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
519         Update.
520         * minsyms.c (lookup_minimal_symbol_by_pc_section)
521         (build_minimal_symbol_hash_tables)
522         (minimal_symbol_reader::install): Update.
523
524 2019-03-15  Tom Tromey  <tom@tromey.com>
525
526         * symtab.c (create_demangled_names_hash): Update.
527         (symbol_set_names): Update.
528         * objfiles.h (struct objfile_per_bfd_storage)
529         <demangled_names_hash>: Now an htab_up.
530         * objfiles.c (objfile_per_bfd_storage): Simplify.
531
532 2019-03-15  Tom Tromey  <tom@tromey.com>
533
534         * objfiles.h (struct objfile_per_bfd_storage): Declare
535         destructor.
536         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
537         New.
538         (get_objfile_bfd_data): Use new.  Don't initialize
539         language_of_main.
540         (free_objfile_per_bfd_storage): Remove.
541         (objfile_bfd_data_free, objfile::~objfile): Use delete.
542
543 2019-03-15  Tom Tromey  <tom@tromey.com>
544
545         * symfile.c (reread_symbols): Update.
546         * objfiles.c (objfile::objfile): Update.
547         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
548         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
549         comment.
550         (minimal_symbol_reader::install): Update.
551         (terminate_minimal_symbol_table): Remove.
552         * jit.c (jit_object_close_impl): Update.
553
554 2019-03-15  Tom Tromey  <tom@tromey.com>
555
556         * minsyms.c (minimal_symbol_reader::record_full): Remove some
557         initializations.
558
559 2019-03-15  Tom Tromey  <tom@tromey.com>
560
561         * objfiles.h (struct objfile_per_bfd_storage)
562         <demangled_hash_languages>: Now a bitset.
563         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
564         (lookup_minimal_symbol): Update.
565
566 2019-03-15  Tom Tromey  <tom@tromey.com>
567
568         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
569         Don't return the symbol.
570         * coffread.c (record_minimal_symbol): Use record_full.
571
572 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
573
574         The MS-Windows port of ncurses fails to switch to a color pair if
575         one or both of the colors are the implicit default colors.  This
576         change records the default colors when TUI is initialized, and
577         then specifies them explicitly when a color pair uses the default
578         colors.  This allows color styling in TUI mode on MS-Windows.
579
580         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
581         ncurses_norm_attr.
582         (tui_initialize_io) [__MINGW32__]: Record the default terminal
583         colors in ncurses_norm_attr.
584         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
585         "none", replace it with the default color recorded in
586         ncurses_norm_attr.
587
588 2019-03-14  Tom Tromey  <tromey@adacore.com>
589
590         * source-cache.h (class source_cache) <get_source_lines>: Return
591         std::string.
592         * source-cache.c (source_cache::extract_lines): Handle case where
593         first_pos==npos.  Return std::string.
594         (source_cache::get_source_lines): Update.
595
596 2019-03-14  Tom Tromey  <tromey@adacore.com>
597
598         * NEWS: Add item for "style sources" commands.
599         * source-cache.c (source_cache::get_source_lines): Check
600         source_styling.
601         * cli/cli-style.c (source_styling): New global.
602         (_initialize_cli_style): Add "style sources" commands.
603         (show_style_sources): New function.
604         * cli/cli-style.h (source_styling): Declare.
605
606 2019-03-14  Pedro Alves  <palves@redhat.com>
607             Tom Tromey  <tromey@adacore.com>
608
609         * tui/tui-winsource.h (tui_refill_source_window): Declare.
610         * tui/tui-winsource.c (tui_refill_source_window): New function,
611         from...
612         (tui_horizontal_source_scroll): ... here.  Move some logic.
613         * cli/cli-style.c (set_style_enabled): Notify new observable.
614         * tui/tui-hooks.c (tui_redisplay_source): New function.
615         (tui_attach_detach_observers): Attach or detach
616         tui_redisplay_source.
617         * observable.h (source_styling_changed): New observable.
618         * observable.c: Define source_styling_changed observable.
619
620 2019-03-13  Tom Tromey  <tromey@adacore.com>
621
622         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
623         (i386_gnu_nat_target::store_registers): Update.
624         * target-debug.h (target_debug_print_std_string): New macro.
625         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
626         * windows-tdep.c (display_one_tib): Update.
627         * tui/tui-stack.c (tui_make_status_line): Update.
628         * top.c (print_inferior_quit_action): Update.
629         * thread.c (thr_try_catch_cmd): Update.
630         (add_thread_with_info): Update.
631         (thread_target_id_str): Update.
632         (thr_try_catch_cmd): Update.
633         (thread_command): Update.
634         (thread_find_command): Update.
635         * record-btrace.c (record_btrace_target::info_record)
636         (record_btrace_resume_thread, record_btrace_target::resume)
637         (record_btrace_cancel_resume, record_btrace_step_thread)
638         (record_btrace_target::wait, record_btrace_target::wait)
639         (record_btrace_target::wait, record_btrace_target::stop): Update.
640         * progspace.c (print_program_space): Update.
641         * process-stratum-target.c
642         (process_stratum_target::thread_address_space): Update.
643         * linux-fork.c (linux_fork_mourn_inferior)
644         (detach_checkpoint_command, info_checkpoints_command)
645         (linux_fork_context): Update.
646         (linux_fork_detach): Update.
647         (class scoped_switch_fork_info): Update.
648         (delete_checkpoint_command): Update.
649         * infrun.c (follow_fork_inferior): Update.
650         (follow_fork_inferior): Update.
651         (proceed_after_vfork_done): Update.
652         (handle_vfork_child_exec_or_exit): Update.
653         (follow_exec): Update.
654         (displaced_step_prepare_throw): Update.
655         (displaced_step_restore): Update.
656         (start_step_over): Update.
657         (resume_1): Update.
658         (clear_proceed_status_thread): Update.
659         (proceed): Update.
660         (print_target_wait_results): Update.
661         (do_target_wait): Update.
662         (context_switch): Update.
663         (stop_all_threads): Update.
664         (restart_threads): Update.
665         (finish_step_over): Update.
666         (handle_signal_stop): Update.
667         (switch_back_to_stepped_thread): Update.
668         (keep_going_pass_signal): Update.
669         (print_exited_reason): Update.
670         (normal_stop): Update.
671         * inferior.c (inferior_pid_to_str): Change return type.
672         (print_selected_inferior): Update.
673         (add_inferior): Update.
674         (detach_inferior): Update.
675         * dummy-frame.c (fprint_dummy_frames): Update.
676         * dcache.c (dcache_info_1): Update.
677         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
678         (btrace_fetch, btrace_clear): Update.
679         * linux-tdep.c (linux_core_pid_to_str): Change return type.
680         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
681         type.
682         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
683         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
684         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
685         * gdbarch.c, gdbarch.h: Rebuild.
686         * gdbarch.sh (core_pid_to_str): Change return type.
687         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
688         return type.
689         (windows_nat_target::pid_to_str): Change return type.
690         (windows_delete_thread): Update.
691         (windows_nat_target::attach): Update.
692         (windows_nat_target::files_info): Update.
693         * target-delegates.c: Rebuild.
694         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
695         return type.
696         (sol_thread_target::pid_to_str): Change return type.
697         * remote.c (class remote_target) <pid_to_str>: Change return
698         type.
699         (remote_target::pid_to_str): Change return type.
700         (extended_remote_target::attach, remote_target::remote_stop_ns)
701         (remote_target::remote_notif_remove_queued_reply)
702         (remote_target::push_stop_reply, remote_target::disable_btrace):
703         Update.
704         (extended_remote_target::attach): Update.
705         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
706         type.
707         (gdbsim_target::pid_to_str): Change return type.
708         * ravenscar-thread.c (struct ravenscar_thread_target)
709         <pid_to_str>: Change return type.
710         (ravenscar_thread_target::pid_to_str): Change return type.
711         * procfs.c (class procfs_target) <pid_to_str>: Change return
712         type.
713         (procfs_target::pid_to_str): Change return type.
714         (procfs_target::attach): Update.
715         (procfs_target::detach): Update.
716         (procfs_target::fetch_registers): Update.
717         (procfs_target::store_registers): Update.
718         (procfs_target::wait): Update.
719         (procfs_target::files_info): Update.
720         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
721         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
722         return type.
723         (nto_procfs_target::pid_to_str): Change return type.
724         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
725         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
726         return type.
727         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
728         (exit_lwp): Update.
729         (attach_proc_task_lwp_callback, get_detach_signal)
730         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
731         (linux_nat_target::resume, wait_lwp, stop_callback)
732         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
733         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
734         (linux_nat_wait_1, resume_stopped_resumed_lwps)
735         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
736         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
737         type.
738         (inf_ptrace_target::attach): Update.
739         (inf_ptrace_target::files_info): Update.
740         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
741         type.
742         (go32_nat_target::pid_to_str): Change return type.
743         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
744         (gnu_nat_target::wait): Update.
745         (gnu_nat_target::wait): Update.
746         (gnu_nat_target::resume): Update.
747         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
748         (fbsd_nat_target::wait): Update.
749         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
750         type.
751         (darwin_nat_target::attach): Update.
752         * corelow.c (class core_target) <pid_to_str>: Change return type.
753         (core_target::pid_to_str): Change return type.
754         * target.c (normal_pid_to_str): Change return type.
755         (default_pid_to_str): Likewise.
756         (target_pid_to_str): Change return type.
757         (target_translate_tls_address): Update.
758         (target_announce_detach): Update.
759         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
760         return type.
761         (bsd_uthread_target::pid_to_str): Change return type.
762         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
763         type.
764         (bsd_kvm_target::pid_to_str): Change return type.
765         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
766         return type.
767         (aix_thread_target::pid_to_str): Change return type.
768         * target.h (struct target_ops) <pid_to_str>: Change return type.
769         (target_pid_to_str, normal_pid_to_str): Likewise.
770         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
771         type.
772         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
773         type.
774         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
775         return type.
776         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
777         type.
778         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
779         type.
780         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
781         return type.
782
783 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
784
785         * NEWS: Mention that the new default MI version is 3.  Mention
786         changes to the output of commands and events that deal with
787         multi-location breakpoints.
788         * breakpoint.c: Include "mi/mi-out.h".
789         (print_one_breakpoint): Change output syntax if using MI version
790         >= 3.
791         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
792         New.
793         (mi_multi_location_breakpoint_output_fixed): New.
794         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
795         (mi_cmd_fix_multi_location_breakpoint_output): New.
796         (mi_multi_location_breakpoint_output_fixed): New.
797         * mi/mi-cmds.c (mi_cmds): Register command
798         -fix-multi-location-breakpoint-output.
799         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
800         interpreter "mi".
801
802 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
803
804         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
805         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
806         instantiate mi_ui_out based on interpreter name.
807         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
808         * mi/mi-main.c (mi_load_progress): Likewise.
809
810 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
811
812         * NEWS: Combine separate "New targets" sections for 8.3.
813
814 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
815
816         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
817         (ppcfbsd_init_abi): Install gdbarch
818         "fetch_tls_load_module_address" and "get_thread_local_address"
819         methods.
820
821 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
822
823         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
824         (riscv_fbsd_init_abi): Install gdbarch
825         "fetch_tls_load_module_address" and "get_thread_local_address"
826         methods.
827
828 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
829
830         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
831         (i386fbsd_init_abi): Install gdbarch
832         "fetch_tls_load_module_address" and "get_thread_local_address"
833         methods.
834
835 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
836
837         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
838         (amd64fbsd_init_abi): Install gdbarch
839         "fetch_tls_load_module_address" and "get_thread_local_address"
840         methods.
841
842 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
843
844         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
845         (struct fbsd_pspace_data): New type.
846         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
847         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
848         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
849         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
850         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
851
852 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
853
854         * gdbtypes.c (lookup_struct_elt): New function.
855         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
856         * gdbtypes.h (struct struct_elt): New type.
857         (lookup_struct_elt): New prototype.
858
859 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
860
861         * gdbtypes.c (lookup_struct_elt_type): Update comment and
862         remove disabled code block.
863
864 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
865
866         * gdbarch.sh (get_thread_local_address): New method.
867         * gdbarch.h, gdbarch.c: Regenerate.
868         * target.c (target_translate_tls_address): Use
869         gdbarch_get_thread_local_address if present instead of
870         target::get_thread_local_address.
871
872 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
873
874         * target.h (target::get_thread_local_address): Update comment.
875
876 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
877
878         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
879         objfile->separate_debug_objfile_backlink if not NULL.
880
881 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
882
883         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
884         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
885         (amd64bsd_store_inferior_registers): Likewise.
886         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
887         Enable segment base registers.
888         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
889         PT_GETFSBASE and PT_GETGSBASE.
890         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
891         PT_SETGSBASE.
892         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
893         segment base registers.
894         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
895
896 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
897
898         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
899         Update calls to i386_target_description to add 'segments'
900         parameter.
901         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
902         add segment base registers.
903         * arch/i386.c (i386_create_target_description): Add 'segments'
904         parameter to enable segment base registers.
905         * arch/i386.h (i386_create_target_description): Likewise.
906         * features/i386/32bit-segments.xml: New file.
907         * features/i386/32bit-segments.c: Generate.
908         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
909         call to i386_target_description to add 'segments' parameter.
910         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
911         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
912         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
913         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
914         if feature is present.
915         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
916         Add 'segments' parameter to call to i386_target_description.
917         (i386_target_description): Add 'segments' parameter to enable
918         segment base registers.
919         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
920         to call to i386_target_description.
921         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
922         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
923         Define I386_NUM_REGS.
924         (i386_target_description): Add 'segments' parameter to enable
925         segment base registers.
926
927 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
928
929         PR/24325
930         * source-cache.c: #undef open and close, to avoid unresolved
931         externals during linking.
932
933 2019-03-12  Tom Tromey  <tromey@adacore.com>
934
935         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
936         const.  Add initializers.
937         (_initialize_remote): Don't initialize ptid globals.
938
939 2019-03-12  Pedro Alves  <palves@redhat.com>
940
941         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
942
943 2019-03-12  Pedro Alves  <palves@redhat.com>
944
945         * cp-name-parser.y (main): Remove unused 'len' variable.
946
947 2019-03-12  Tom Tromey  <tromey@adacore.com>
948
949         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
950         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
951
952 2019-03-12  Tom Tromey  <tromey@adacore.com>
953
954         * linux-nat.c (iterate_over_lwps): Update.
955         (stop_callback): Remove parameter.
956         (stop_wait_callback, detach_callback, resume_set_callback)
957         (select_singlestep_lwp_callback, set_ignore_sigint)
958         (status_callback, resumed_callback, resume_clear_callback)
959         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
960         data parameter.
961         (linux_nat_target::detach, linux_nat_target::resume)
962         (linux_stop_and_wait_all_lwps, select_event_lwp)
963         (linux_nat_filter_event, linux_nat_wait_1)
964         (linux_nat_target::kill, linux_nat_target::stop)
965         (linux_nat_target::stop): Update.
966         (linux_nat_resume_callback): Change type.
967         (resume_stopped_resumed_lwps, count_events_callback)
968         (select_event_lwp_callback): Likewise.
969         (linux_stop_lwp, linux_nat_stop_lwp): Update.
970         * arm-linux-nat.c (struct update_registers_data): Remove.
971         (update_registers_callback): Change type.
972         (arm_linux_insert_hw_breakpoint1): Update.
973         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
974         parameter.
975         (x86_linux_dr_set_addr): Update.
976         (x86_linux_dr_set_control): Update.
977         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
978         (iterate_over_lwps): Use gdb::function_view.
979         * nat/aarch64-linux-hw-point.c (struct
980         aarch64_dr_update_callback_param): Remove.
981         (debug_reg_change_callback): Change type.
982         (aarch64_notify_debug_reg_change): Update.
983         * s390-linux-nat.c (s390_refresh_per_info): Update.
984
985 2019-03-11  Tom Tromey  <tromey@adacore.com>
986
987         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
988         redundant assignment to "this_cu".
989
990 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
991
992         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
993
994 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
995
996         * gdbtypes.c (rank_one_type_parm_set): New function extracted
997         from...
998         (rank_one_type): ... this.
999
1000 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1001
1002         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
1003         from...
1004         (rank_one_type): ... this.
1005
1006 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1007
1008         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
1009         from...
1010         (rank_one_type): ... this.
1011
1012 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1013
1014         * gdbtypes.c (rank_one_type_parm_float): New function extracted
1015         from...
1016         (rank_one_type): ... this.
1017
1018 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1019
1020         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
1021         from...
1022         (rank_one_type): ... this.
1023
1024 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1025
1026         * gdbtypes.c (rank_one_type_parm_range): New function extracted
1027         from...
1028         (rank_one_type): ... this.
1029
1030 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1031
1032         * gdbtypes.c (rank_one_type_parm_char): New function extracted
1033         from...
1034         (rank_one_type): ... this.
1035
1036 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1037
1038         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
1039         from...
1040         (rank_one_type): ... this.
1041
1042 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1043
1044         * gdbtypes.c (rank_one_type_parm_int): New function extracted
1045         from...
1046         (rank_one_type): ... this.
1047
1048 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1049
1050         * gdbtypes.c (rank_one_type_parm_func): New function extracted
1051         from...
1052         (rank_one_type): ... this.
1053
1054 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1055
1056         * gdbtypes.c (rank_one_type_parm_array): New function extracted
1057         from...
1058         (rank_one_type): ... this.
1059
1060 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1061
1062         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
1063         from...
1064         (rank_one_type): ... this.
1065
1066 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1067
1068         * inferior.c (initialize_inferiors): Ensure 'help set/show print
1069         inferior-events' shows the example events.
1070
1071 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
1072
1073         Support styling on native MS-Windows console
1074
1075         PR/24315
1076         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
1077         on MS-Windows if $TERM is not defined.
1078
1079         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
1080
1081         * posix-hdep.c (gdb_console_fputs):
1082         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
1083         functions.
1084         * ui-file.h (gdb_console_fputs): Add prototype.
1085
1086         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
1087         back to fputs only if the former returns zero.
1088
1089 2019-03-07  Tom Tromey  <tom@tromey.com>
1090
1091         * symmisc.c (print_symbol_bcache_statistics): Update.
1092         (print_objfile_statistics): Update.
1093         * symfile.c (allocate_symtab): Update.
1094         * stabsread.c: Don't include bcache.h.
1095         * psymtab.h (struct psymbol_bcache): Don't declare.
1096         (class psymtab_storage) <psymbol_cache>: Now a bcache.
1097         (psymbol_bcache_init, psymbol_bcache_free)
1098         (psymbol_bcache_get_bcache): Don't declare.
1099         * psymtab.c (struct psymbol_bcache): Remove.
1100         (psymtab_storage::psymtab_storage): Update.
1101         (psymtab_storage::~psymtab_storage): Update.
1102         (psymbol_bcache_init, psymbol_bcache_free)
1103         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
1104         (add_psymbol_to_bcache): Update.
1105         (allocate_psymtab): Update.
1106         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
1107         macro_cache>: No longer pointers.
1108         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
1109         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
1110         * macrotab.c (macro_bcache): Update.
1111         * macroexp.c: Don't include bcache.h.
1112         * gdbtypes.c (check_types_worklist): Update.
1113         (types_deeply_equal): Remove TRY/CATCH.  Update.
1114         * elfread.c (elf_symtab_read): Update.
1115         * dwarf2read.c: Don't include bcache.h.
1116         * buildsym.c (buildsym_compunit::get_macro_table): Update.
1117         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
1118         (print_bcache_statistics, bcache_memory_used): Don't declare.
1119         (struct bcache): Move from bcache.c.  Add constructor, destructor,
1120         methods.  Rename all data members.
1121         * bcache.c (struct bcache): Move to bcache.h.
1122         (bcache::expand_hash_table): Rename from expand_hash_table.
1123         (bcache): Remove.
1124         (bcache::insert): Rename from bcache_full.
1125         (bcache::compare): Rename from bcache_compare.
1126         (bcache_xmalloc): Remove.
1127         (bcache::~bcache): Rename from bcache_xfree.
1128         (bcache::print_statistics): Rename from print_bcache_statistics.
1129         (bcache::memory_used): Rename from bcache_memory_used.
1130
1131 2019-03-07  Pedro Alves  <palves@redhat.com>
1132
1133         * infrun.c (normal_stop): Also check for
1134         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
1135
1136 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
1137
1138         * f-lang.c (value_from_host_double): Moved to...
1139         * value.c (value_from_host_double): ...here.
1140         * value.h (value_from_host_double): Declare.
1141         * guile/scm-math.c (vlscm_convert_typed_number): Use
1142         value_from_host_double.
1143         (vlscm_convert_number): Likewise.
1144         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
1145         * python/py-value.c (convert_value_from_python): Likewise.
1146
1147 2019-03-06  Tom Tromey  <tom@tromey.com>
1148
1149         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
1150
1151 2019-03-06  Tom Tromey  <tom@tromey.com>
1152
1153         * utils.h (free_current_contents): Don't declare.
1154         * utils.c (free_current_contents): Remove.
1155
1156 2019-03-06  Tom Tromey  <tom@tromey.com>
1157
1158         * top.c (quit_force): Update.
1159         * main.c (captured_command_loop): Update.
1160         * common/new-op.c (operator new): Update.
1161         * common/common-exceptions.c (struct catcher)
1162         <save_cleanup_chain>: Remove member.
1163         (exceptions_state_mc_init): Update.
1164         (exception_try_scope_entry): Return nullptr.
1165         (exception_try_scope_exit, exception_rethrow)
1166         (throw_exception_sjlj, throw_exception_cxx): Update.
1167         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
1168         (all_cleanups, do_cleanups, discard_cleanups)
1169         (discard_final_cleanups, save_cleanups, save_final_cleanups)
1170         (restore_cleanups, restore_final_cleanups): Don't declare.
1171         (do_final_cleanups): Remove parameter.
1172         * common/cleanups.c (cleanup_chain, make_cleanup)
1173         (make_cleanup_dtor, all_cleanups, do_cleanups)
1174         (discard_my_cleanups, discard_cleanups)
1175         (discard_final_cleanups, save_my_cleanups, save_cleanups)
1176         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
1177         (null_cleanup): Remove.
1178         (do_final_cleanups): Remove parameter.
1179
1180 2019-03-06  Tom Tromey  <tom@tromey.com>
1181
1182         * remote.c (remote_target::remote_parse_stop_reply): Use
1183         unique_xmalloc_ptr.
1184
1185 2019-03-06  Tom Tromey  <tom@tromey.com>
1186
1187         * stabsread.c (struct stabs_field_info): Rename from field_info.
1188         <list, fnlist>: Add initializers.
1189         <obstack>: New member.
1190         (read_member_functions, read_struct_fields, read_baseclasses):
1191         Allocate on obstack.  Don't use cleanups.
1192         (read_one_struct_field, read_member_functions, read_struct_fields)
1193         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
1194         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
1195         (read_struct_type): Update.
1196
1197 2019-03-06  Tom Tromey  <tom@tromey.com>
1198
1199         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
1200         * common/filestuff.h (make_cleanup_close): Don't declare.
1201         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
1202         Remove.
1203
1204 2019-03-06  Tom Tromey  <tom@tromey.com>
1205
1206         * solib-aix.c: Use make_scope_exit.
1207
1208 2019-03-06  Tom Tromey  <tom@tromey.com>
1209
1210         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
1211         Use make_scope_exit.
1212
1213 2019-03-06  Tom Tromey  <tom@tromey.com>
1214
1215         * solib-svr4.c (disable_probes_interface): Remove parameter.
1216         (svr4_handle_solib_event): Use make_scope_exit.
1217
1218 2019-03-06  Tom Tromey  <tom@tromey.com>
1219
1220         * remote.c (struct stop_reply_deleter): Remove.
1221         (stop_reply_up): Update.
1222         (struct stop_reply): Derive from notif_event.  Don't typedef.
1223         <regcache>: Now a std::vector.
1224         (stop_reply_xfree): Remove.
1225         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
1226         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
1227         (remote_target::discard_pending_stop_replies): Use delete.
1228         (remote_target::remote_parse_stop_reply): Update.
1229         (remote_target::process_stop_reply): Update.
1230         * remote-notif.h (struct notif_event): Add virtual destructor.
1231         Remove "dtr" member.
1232         (struct notif_client) <alloc_event>: Return a unique_ptr.
1233         (notif_event_xfree): Don't declare.
1234         (notif_event_up): New typedef.
1235         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
1236         (notif_event_xfree, do_notif_event_xfree): Remove.
1237         (remote_notif_state_xfree): Update.
1238
1239 2019-03-06  Tom Tromey  <tom@tromey.com>
1240
1241         * infrun.c (displaced_step_clear_cleanup): Now a
1242         forward_scope_exit type.
1243         (displaced_step_prepare_throw): Update.
1244         (displaced_step_fixup): Update.
1245
1246 2019-03-06  Tom Tromey  <tom@tromey.com>
1247
1248         * inferior.h (class inferior): Update comment.
1249         * gdbthread.h (class thread_info): Update comment.
1250
1251 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
1252             Tom Tromey  <tom@tromey.com>
1253
1254         * stabsread.h (struct stab_section_list): Remove.
1255         (coffstab_build_psymtabs): Update.
1256         * dbxread.c (symbuf_sections): Now a std::vector.
1257         (sect_idx): New global.
1258         (fill_symbuf): Update.
1259         (coffstab_build_psymtabs): Change type of stabsects parameter.
1260         Update.
1261         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
1262         std::vector.
1263         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
1264         (coff_locate_sections): Update.
1265         (coff_symfile_read): Remove cleanups.  Update.
1266         (init_stringtab): Add storage parameter.
1267         (free_stringtab, free_stringtab_cleanup): Remove.
1268         (init_lineno): Add storage parameter.
1269         (free_linetab, free_linetab_cleanup): Remove.
1270
1271 2019-03-06  Pedro Alves  <palves@redhat.com>
1272
1273         * linux-fork.c (fork_info::clobber_regs): Delete.
1274         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
1275         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
1276         comment.  Adjust.
1277         (scoped_switch_fork_info::scoped_switch_fork_info)
1278         (checkpoint_command, linux_fork_context): Adjust
1279         fork_save_infrun_state calls.
1280
1281 2019-03-06  Pedro Alves  <palves@redhat.com>
1282
1283         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
1284         (inf_has_multiple_threads): Return 'bool' and rewrite using
1285         inferior_info::threads().
1286
1287 2019-03-06  Pedro Alves  <palves@redhat.com>
1288
1289         * linux-fork.c: Include <list>.
1290         (fork_list): Now a std::list instance.
1291         (fork_info): Add ctor, dtor, and in-class initialize all fields.
1292         (forks_exist_p, find_last_fork): Adjust.
1293         (new_fork): Delete.
1294         (one_fork_p): New.
1295         (add_fork): Adjust.
1296         (free_fork): Delete, folded into fork_info::~fork_info().
1297         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
1298         Adjust.
1299         (init_fork_list): Delete.
1300         (linux_fork_killall, linux_fork_mourn_inferior)
1301         (linux_fork_detach, info_checkpoints_command): Adjust.
1302         (_initialize_linux_fork): No longer call init_fork_list.
1303
1304 2019-03-06  Pedro Alves  <palves@redhat.com>
1305
1306         * linux-fork.c (new_fork): New, split out of ...
1307         (add_fork): ... this.  Return void.  Move "first fork" special
1308         case from here, to ...
1309         (checkpoint_command): ... here.
1310         * linux-linux.h (add_fork): Return void.
1311
1312 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1313
1314         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
1315
1316 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1317             Chris January  <chris.january@arm.com>
1318             David Lecomber  <david.lecomber@arm.com>
1319
1320         * f-exp.y: New token, UNOP_INTRINSIC.
1321         (exp): New pattern using UNOP_INTRINSIC token.
1322         (f77_keywords): Add 'abs' keyword.
1323         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
1324         (value_from_host_double): New function.
1325         (evaluate_subexp_f): Support UNOP_ABS.
1326
1327 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1328
1329         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
1330         types.
1331
1332 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1333
1334         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
1335         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
1336         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
1337
1338 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1339
1340         * f-exp.y (convert_to_kind_type): Handle more type kinds.
1341
1342 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1343             Chris January  <chris.january@arm.com>
1344
1345         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
1346         * f-exp.y: Define 'KIND' token.
1347         (exp): New pattern for KIND expressions.
1348         (ptype): Handle types with a kind extension.
1349         (direct_abs_decl): Extend to spot kind extensions.
1350         (f77_keywords): Add 'kind' to the list.
1351         (push_kind_type): New function.
1352         (convert_to_kind_type): New function.
1353         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
1354         * parse.c (operator_length_standard): Likewise.
1355         * parser-defs.h (enum type_pieces): Add tp_kind.
1356         * std-operator.def: Add UNOP_KIND.
1357
1358 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1359
1360         * f-exp.y (f_parse): Set yydebug.
1361
1362 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1363
1364         * f-lang.c (evaluate_subexp_f): New function.
1365         (exp_descriptor_f): New global.
1366         (f_language_defn): Use exp_descriptor_f instead of
1367         exp_descriptor_standard.
1368
1369 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1370
1371         * f-exp.y (struct token): Add comments.
1372         (dot_ops): Remove uppercase versions and the end marker.
1373         (f77_keywords): Likewise.
1374         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
1375         entries in the dot_ops array are case insensitive, and use
1376         strncasecmp to compare strings.  Also some whitespace cleanup in
1377         this area.  Similar for the f77_keywords array, except entries in
1378         this list might be case sensitive.
1379
1380 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1381
1382         * f-exp.y (struct f77_boolean_val): Add comments.
1383         (boolean_values): Remove uppercase versions, and end marker.
1384         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
1385         and use strncasecmp to achieve case insensitivity.  Additionally,
1386         perform whitespace cleanup around this code.
1387
1388 2019-03-06  Tom Tromey  <tromey@adacore.com>
1389
1390         * remote-sim.c (gdbsim_target_open): Use result of
1391         gdb_argv::release.
1392
1393 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
1394         Dirk Schubert  <dirk.schubert@arm.com>
1395         Chris January  <chris.january@arm.com>
1396
1397         * eval.c (evaluate_subexp_standard): Call Fortran argument
1398         wrapping logic.
1399         * f-lang.c (struct value): A value which can be passed into a
1400         Fortran function call.
1401         (fortran_argument_convert): Wrap Fortran arguments in a pointer
1402         where appropriate.
1403         (struct type): Value ready for a Fortran function call.
1404         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
1405         is needed.
1406         * f-lang.h (fortran_argument_convert): Declaration.
1407         (fortran_preserve_arg_pointer): Declaration.
1408         * infcall.c (value_arg_coerce): Call Fortran argument logic.
1409
1410 2019-03-05  Tom Tromey  <tromey@adacore.com>
1411
1412         * python/py-prettyprint.c (print_string_repr): Remove #if.
1413         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
1414
1415 2019-03-05  Tom Tromey  <tromey@adacore.com>
1416
1417         * target.c (the_dummy_target): Move later.  Change type to
1418         "dummy_target".
1419         (initialize_targets): Don't initialize the_dummy_target.
1420
1421 2019-03-05  Tom Tromey  <tromey@adacore.com>
1422
1423         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
1424         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
1425
1426 2019-03-05  Tom Tromey  <tromey@adacore.com>
1427
1428         * windows-nat.c (windows_nat_target::attach)
1429         (windows_nat_target::detach): Don't call gdb_flush.
1430         * valprint.c (generic_val_print, val_print, val_print_string):
1431         Don't call gdb_flush.
1432         * utils.c (defaulted_query): Don't call gdb_flush.
1433         * typeprint.c (print_type_scalar): Don't call gdb_flush.
1434         * target.c (target_announce_detach): Don't call gdb_flush.
1435         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
1436         * remote.c (extended_remote_target::attach): Don't call
1437         gdb_flush.
1438         * procfs.c (procfs_target::detach): Don't call gdb_flush.
1439         * printcmd.c (do_examine): Don't call gdb_flush.
1440         (info_display_command): Don't call gdb_flush.
1441         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
1442         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
1443         * memattr.c (info_mem_command): Don't call gdb_flush.
1444         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
1445         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
1446         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
1447         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
1448         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
1449         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
1450         (gnu_nat_target::detach): Don't call gdb_flush.
1451         * f-valprint.c (f_val_print): Don't call gdb_flush.
1452         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
1453         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
1454         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
1455         gdb_flush.
1456         * c-valprint.c (c_val_print): Don't call gdb_flush.
1457         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
1458
1459 2019-03-05  Tom Tromey  <tromey@adacore.com>
1460
1461         * varobj.c (update_dynamic_varobj_children): Update.
1462         (install_default_visualizer): Use reset, not release.
1463         * value.c (set_internalvar): Update.
1464         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
1465         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
1466         ATTRIBUTE_UNUSED_RESULT.
1467
1468 2019-03-05  Tom Tromey  <tromey@adacore.com>
1469
1470         * remote.c (class scoped_remote_fd) <release>: Add
1471         ATTRIBUTE_UNUSED_RESULT.
1472
1473 2019-03-05  Tom Tromey  <tromey@adacore.com>
1474
1475         * macroexp.c (struct macro_buffer) <release>: Add
1476         ATTRIBUTE_UNUSED_RESULT.
1477
1478 2019-03-05  Tom Tromey  <tromey@adacore.com>
1479
1480         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
1481         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
1482         ATTRIBUTE_UNUSED_RESULT.
1483
1484 2019-03-05  Tom Tromey  <tromey@adacore.com>
1485
1486         * common/scoped_fd.h (class scoped_fd) <release>: Add
1487         ATTRIBUTE_UNUSED_RESULT.
1488
1489 2019-03-05  Tom Tromey  <tromey@adacore.com>
1490
1491         * parser-defs.h (struct parser_state) <release>: Add
1492         ATTRIBUTE_UNUSED_RESULT.
1493
1494 2019-03-05  Tom Tromey  <tromey@adacore.com>
1495
1496         * utils.h (class gdb_argv) <release>: Add
1497         ATTRIBUTE_UNUSED_RESULT.
1498         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
1499
1500 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
1501
1502         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
1503         for-loop range, to avoid compiler warnings.
1504
1505         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
1506         avoid compiler warnings about unused variables.
1507
1508         * NEWS: Mention end of support for native debugging on MS-Windows
1509         before XP.
1510
1511         PR gdb/24292
1512         * common/netstuff.c:
1513         * gdbserver/gdbreplay.c
1514         * gdbserver/remote-utils.c:
1515         * ser-tcp.c:
1516         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
1517         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
1518         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
1519         'getaddrinfo' and 'freeaddrinfo' were not available before
1520         Windows XP, and mingw.org's MinGW headers by default define
1521         _WIN32_WINNT to 0x500.
1522
1523 2019-03-01  Gary Benson <gbenson@redhat.com>
1524
1525         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
1526
1527 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
1528             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1529
1530         PR gdb/8527
1531         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
1532         set_sigint_trap, clear_sigint_trap.
1533
1534 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1535
1536         * target.c (target_detach): Clear the regcache and the
1537         frame cache.
1538
1539 2019-02-27  Pedro Alves  <palves@redhat.com>
1540
1541         * utils.c (set_screen_size): When we cap the height/width sizes,
1542         tweak the corresponding command variable to show "unlimited":
1543
1544 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
1545             Pedro Alves  <palves@redhat.com>
1546
1547         * utils.c (set_screen_size): Reduce "infinite" rows and columns
1548         before calling rl_set_screen_size.
1549
1550 2019-02-27  Tom Tromey  <tromey@adacore.com>
1551
1552         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
1553         define.
1554         * python/py-value.c: Remove Python 2.4 workaround.
1555         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
1556         workaround.
1557         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
1558         Python 2.4 workaround.
1559         * python/python-internal.h: Remove Python 2.4 comment.
1560         (Py_ssize_t): Don't define.
1561         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
1562         (gdb_Py_DECREF): Remove Python 2.4 workaround.
1563         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
1564         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
1565         * python/python.c (do_start_initialization): Remove Python 2.4
1566         workaround.
1567         * python/py-prettyprint.c (class dummy_python_frame): Remove.
1568         (print_children): Remove Python 2.4 workaround.
1569         * python/py-inferior.c (buffer_procs): Remove Python 2.4
1570         workaround.
1571         (CHARBUFFERPROC_NAME): Remove.
1572         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
1573         Python 2.4 workaround.
1574
1575 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1576
1577         * NEWS: Note minimum Python version.
1578
1579 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1580
1581         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
1582         code from these functions.  Remove corresponding ifdefs.  Use
1583         Py_buffer_up instead of explicit calls to PyBuffer_Release.
1584         Remove gotos and target of gotos.
1585         (infpy_search_memory): Likewise.
1586
1587 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1588
1589         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
1590         (hppa_gdbarch_init): Don't register deleted functions with
1591         gdbarch.
1592
1593 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1594
1595         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
1596         (h8300_unwind_sp): Delete.
1597         (h8300_dummy_id): Delete.
1598         (h8300_gdbarch_init): Don't register deleted functions with
1599         gdbarch.
1600
1601 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1602
1603         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
1604         (ft32_unwind_pc): Delete.
1605         (ft32_unwind_sp): Delete.
1606         (ft32_gdbarch_init): Don't register deleted functions with
1607         gdbarch.
1608
1609 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1610
1611         * gdb/frv-tdep.c (frv_dummy_id): Delete.
1612         (frv_unwind_pc): Delete.
1613         (frv_unwind_sp): Delete.
1614         (frv_gdbarch_init): Don't register deleted functions with
1615         gdbarch.
1616
1617 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1618
1619         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
1620         (riscv_unwind_pc): Delete.
1621         (riscv_unwind_sp): Delete.
1622         (riscv_gdbarch_init): Don't register deleted functions with
1623         gdbarch.
1624
1625 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1626
1627         * gdb/csky-tdep.c (csky_dummy_id): Delete.
1628         (csky_unwind_pc): Delete.
1629         (csky_unwind_sp): Delete.
1630         (csky_gdbarch_init): Don't register deleted functions with
1631         gdbarch.
1632
1633 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1634
1635         * gdb/cris-tdep.c (cris_dummy_id): Delete.
1636         (cris_unwind_pc): Delete.
1637         (cris_unwind_sp): Delete.
1638         (cris_gdbarch_init): Don't register deleted functions with
1639         gdbarch.
1640
1641 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1642
1643         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
1644         (bfin_unwind_pc): Delete.
1645         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
1646
1647 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1648
1649         * gdb/arm-tdep.c (arm_dummy_id): Delete.
1650         (arm_unwind_pc): Delete.
1651         (arm_unwind_sp): Delete.
1652         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
1653
1654 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1655
1656         * gdb/arc-tdep.c (arc_dummy_id): Delete.
1657         (arc_unwind_pc): Delete.
1658         (arc_unwind_sp): Delete.
1659         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
1660
1661 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1662
1663         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
1664         (alpha_unwind_pc): Delete.
1665         (alpha_gdbarch_init): Don't register deleted functions with
1666         gdbarch.
1667
1668 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1669
1670         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
1671         (aarch64_unwind_pc): Delete.
1672         (aarch64_unwind_sp): Delete.
1673         (aarch64_gdbarch_init): Don't register deleted functions with
1674         gdbarch.
1675
1676 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1677
1678         * gdbtypes.c (type_align): Don't consider static members when
1679         computing structure alignment.
1680
1681 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1682
1683         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
1684         return 0 for other types.
1685         * arch-utils.c (default_type_align): Always return 0.
1686         * gdbarch.h: Regenerate.
1687         * gdbarch.sh (type_align): Extend comment.
1688         * gdbtypes.c (type_align): Add additional comments, always call
1689         gdbarch_type_align before applying the default rules.
1690         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
1691         generic code will then apply a suitable default.
1692         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
1693         types, return 0 for other types.
1694
1695 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1696
1697         * NEWS: Create a new section for the next release branch.
1698         Rename the section of the current branch, now that it has
1699         been cut.
1700
1701 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1702
1703         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
1704         * version.in: Bump version to 8.3.50.DATE-git.
1705
1706 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
1707
1708         * aix-thread.c (ptid_cmp): Remove unused variable.
1709         (get_signaled_thread): Likewise.
1710         (store_regs_user_thread): Likewise.
1711         (store_regs_kernel_thread): Likewise.
1712         (fetch_regs_kernel_thread): Remove shadowed variable.
1713
1714 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1715
1716         * features/riscv/32bit-cpu.xml: Add register numbers.
1717         * features/riscv/32bit-fpu.c: Regenerate.
1718         * features/riscv/32bit-fpu.xml: Add register numbers.
1719         * features/riscv/64bit-cpu.xml: Add register numbers.
1720         * features/riscv/64bit-fpu.c: Regenerate.
1721         * features/riscv/64bit-fpu.xml: Add register numbers.
1722
1723 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
1724
1725         * NEWS: Mention two argument form of gdb.Value constructor.
1726         * python/py-value.c (convert_buffer_and_type_to_value): New
1727         function.
1728         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
1729         Add support for handling an optional second argument.  Call
1730         convert_buffer_and_type_to_value as appropriate.
1731         * python/python-internal.h (Py_buffer_deleter): New struct.
1732         (Py_buffer_up): New typedef.
1733
1734 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
1735
1736         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
1737         instead of releasing ownership.
1738
1739 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
1740
1741         * dwarf2read.c (open_and_init_dwp_file): Call
1742         elf_numsections instead of bfd_count_sections to initialize
1743         dwp_file->num_sections.
1744
1745 2019-02-25  Tom Tromey  <tromey@adacore.com>
1746
1747         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
1748
1749 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1750
1751         * gcore.in: Add '--readnever' option when invoking GDB.
1752
1753 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1754
1755         * MAINTAINERS: Update my email address.
1756
1757 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1758
1759         * build-id.c (build_id_to_debug_bfd_1): New function.
1760         (build_id_to_debug_bfd): Look for separate debug file in
1761         sysroot.
1762
1763 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1764
1765         * gdbarch.sh: Update the copyright year range that is placed into
1766         generated files.
1767
1768 2019-02-22  Keith Seitz  <keiths@redhat.com>
1769
1770         PR symtab/23853
1771         * linespec.c (create_sals_line_offset): Search for the default
1772         symtab's filename instead of its fullname.
1773
1774 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1775
1776         * NEWS: Update style defaults.
1777
1778 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1779
1780         * main.c (captured_main_1): Disable styling in batch mode.
1781
1782 2019-02-20  Tom Tromey  <tom@tromey.com>
1783
1784         * symtab.c (symtab_symbol_info): Fix typos.
1785
1786 2019-02-20  Tom Tromey  <tromey@adacore.com>
1787
1788         * findcmd.c (_initialize_mem_search): Use upper case for
1789         metasyntactic variables.
1790
1791 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
1792
1793         * aarch64-tdep.c (aarch64_add_reggroups): New function.
1794         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
1795
1796 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
1797
1798         * top.h (source_file_name): Change to std::string.
1799         * top.c (source_file_name): Likewise.
1800         (command_line_input): Adjust.
1801         * cli/cli-script.c (script_from_file): Adjust.
1802
1803 2019-02-19  Tom Tromey  <tromey@adacore.com>
1804
1805         * ravenscar-thread.c
1806         (ravenscar_thread_target::update_thread_list): Don't call
1807         ada_build_task_list.
1808         * ada-lang.h (ada_build_task_list): Don't declare.
1809         * ada-tasks.c (struct ada_tasks_inferior_data)
1810         <task_list_valid_p>: Now bool.
1811         (read_known_tasks, ada_task_list_changed)
1812         (ada_tasks_invalidate_inferior_data): Update.
1813         (read_known_tasks_array): Return bool.
1814         (read_known_tasks_list): Likewise.
1815         (read_known_tasks): Return void.
1816         (ada_build_task_list): Now static.
1817
1818 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1819
1820         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
1821         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
1822
1823 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1824
1825         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
1826         variant for ada_tasks_pspace_data_handle and
1827         ada_tasks_inferior_data_handle.
1828         (ada_tasks_pspace_data_cleanup): New function.
1829         (ada_tasks_inferior_data_cleanup): New function.
1830
1831 2019-02-17  Tom Tromey  <tom@tromey.com>
1832
1833         * macrotab.h (macro_source_fullname): Return a std::string.
1834         * macrotab.c (macro_include, check_for_redefinition)
1835         (macro_undef, macro_lookup_definition, foreach_macro)
1836         (foreach_macro_in_scope): Update.
1837         (macro_source_fullname): Return a std::string.
1838         * macrocmd.c (show_pp_source_pos): Update.
1839
1840 2019-02-17  Tom Tromey  <tom@tromey.com>
1841
1842         * macrocmd.c (show_pp_source_pos): Style the file names.
1843
1844 2019-02-17  Tom Tromey  <tom@tromey.com>
1845
1846         PR tui/24197:
1847         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
1848
1849 2019-02-17  Tom Tromey  <tom@tromey.com>
1850
1851         * ada-lang.c (user_select_syms): Use filtered printing.
1852         * utils.c (wrap_style): New global.
1853         (desired_style): Remove.
1854         (emit_style_escape): Add stream parameter.
1855         (set_output_style, reset_terminal_style, prompt_for_continue):
1856         Update.
1857         (flush_wrap_buffer): Only flush gdb_stdout.
1858         (wrap_here): Set wrap_style.
1859         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
1860         treat escape sequences as a character.  Change when wrap buffer is
1861         flushed.
1862         (fputs_styled): Do not set the output style when the default is
1863         requested.
1864         * ui-style.h (struct ui_file_style) <is_default>: New method.
1865         * source.c (print_source_lines_base): Emit escape sequences in one
1866         piece.
1867
1868 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1869
1870         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
1871         integers and enumeration types.
1872
1873 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1874
1875         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
1876         instead of lookup_symbol_in_language
1877         (do_exact_match): New function.
1878         (ada_get_symbol_name_matcher): Return do_exact_match when
1879         doing a verbatim match.
1880
1881 2019-02-15  Tom Tromey  <tromey@adacore.com>
1882
1883         * ravenscar-thread.c (ravenscar_thread_target::resume)
1884         (ravenscar_thread_target::wait): Special case wildcard requests.
1885
1886 2019-02-15  Tom Tromey  <tromey@adacore.com>
1887
1888         * ravenscar-thread.c (base_ptid): Remove.
1889         (struct ravenscar_thread_target) <close>: New method.
1890         <m_base_ptid>: New member.
1891         <update_inferior_ptid, active_task, task_is_currently_active,
1892         runtime_initialized>: Declare methods.
1893         <ravenscar_thread_target>: Add constructor.
1894         (ravenscar_thread_target::task_is_currently_active)
1895         (ravenscar_thread_target::update_inferior_ptid)
1896         (ravenscar_runtime_initialized): Rename.  Now methods.
1897         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
1898         (ravenscar_thread_target::update_thread_list): Update.
1899         (ravenscar_thread_target::active_task): Now method.
1900         (ravenscar_thread_target::store_registers)
1901         (ravenscar_thread_target::prepare_to_store)
1902         (ravenscar_thread_target::prepare_to_store)
1903         (ravenscar_thread_target::mourn_inferior): Update.
1904         (ravenscar_inferior_created): Use "new" to create target.
1905         (ravenscar_thread_target::get_ada_task_ptid): Update.
1906         (_initialize_ravenscar): Don't initialize base_ptid.
1907         (ravenscar_ops): Remove global.
1908
1909 2019-02-15  Tom Tromey  <tromey@adacore.com>
1910
1911         * target.h (push_target): Declare new overload.
1912         * target.c (push_target): New overload, taking an rvalue reference.
1913         * remote.c (remote_target::open_1): Use push_target overload.
1914         * corelow.c (core_target_open): Use push_target overload.
1915
1916 2019-02-15  Tom Tromey  <tromey@adacore.com>
1917
1918         * ravenscar-thread.c (is_ravenscar_task)
1919         (ravenscar_task_is_currently_active): Return bool.
1920         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
1921         (_initialize_ravenscar): Remove "(void)".
1922         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
1923         Return bool.
1924
1925 2019-02-15  Tom Tromey  <tromey@adacore.com>
1926
1927         * ravenscar-thread.c (ravenscar_runtime_initializer)
1928         (has_ravenscar_runtime, get_running_thread_id)
1929         (ravenscar_thread_target::resume): Fix indentation.
1930
1931 2019-02-15  Tom Tromey  <tromey@adacore.com>
1932
1933         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
1934         from ravenscar_arch_ops.
1935         (sparc_ravenscar_ops::fetch_registers)
1936         (sparc_ravenscar_ops::store_registers): Now methods.
1937         (sparc_ravenscar_prepare_to_store): Remove.
1938         (sparc_ravenscar_ops): Redefine.
1939         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
1940         methods and destructor.  Remove members.
1941         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
1942         (ravenscar_thread_target::store_registers)
1943         (ravenscar_thread_target::prepare_to_store): Update.
1944         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
1945         Remove.
1946         (struct ppc_ravenscar_powerpc_ops): Derive from
1947         ravenscar_arch_ops.
1948         (ppc_ravenscar_powerpc_ops::fetch_registers)
1949         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
1950         (ppc_ravenscar_powerpc_ops): Redefine.
1951         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
1952         (ppc_ravenscar_e500_ops::fetch_registers)
1953         (ppc_ravenscar_e500_ops::store_registers): Now methods.
1954         (ppc_ravenscar_e500_ops): Redefine.
1955         * aarch64-ravenscar-thread.c
1956         (aarch64_ravenscar_generic_prepare_to_store): Remove.
1957         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
1958         (aarch64_ravenscar_fetch_registers)
1959         (aarch64_ravenscar_store_registers): Now methods.
1960         (aarch64_ravenscar_ops): Redefine.
1961
1962 2019-02-15  Tom Tromey  <tromey@adacore.com>
1963
1964         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
1965         (ravenscar_thread_target::stopped_by_hw_breakpoint)
1966         (ravenscar_thread_target::stopped_by_watchpoint)
1967         (ravenscar_thread_target::stopped_data_address)
1968         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
1969
1970 2019-02-15  Tom Tromey  <tromey@adacore.com>
1971
1972         * ravenscar-thread.c: Fix some typos.
1973
1974 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1975             Tom Tromey  <tromey@adacore.com>
1976
1977         * ada-lang.c (ada_exception_sal): Change addr_string to a
1978         std::string.
1979         (create_ada_exception_catchpoint): Update.
1980
1981 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1982             Tom Tromey  <tromey@adacore.com>
1983
1984         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
1985         (bp_location_ops): Remove.
1986         (base_breakpoint_allocate_location): Update.
1987         (free_bp_location): Update.
1988         * ada-lang.c (class ada_catchpoint_location)
1989         <ada_catchpoint_location>: Remove ops parameter.
1990         (ada_catchpoint_location_dtor): Remove.
1991         (ada_catchpoint_location_ops): Remove.
1992         (allocate_location_exception): Update.
1993         * breakpoint.h (struct bp_location_ops): Remove.
1994         (class bp_location) <bp_location>: Remove bp_location_ops
1995         parameter.
1996         <~bp_location>: Add destructor.
1997         <ops>: Remove.
1998
1999 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
2000             Pedro Alves  <palves@redhat.com>
2001
2002         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
2003         'PATH_MAX'.
2004
2005 2019-02-14  David Michael  <fedora.dm0@gmail.com>
2006             Samuel Thibault  <samuel.thibault@gnu.org>
2007             Thomas Schwinge  <thomas@codesourcery.com>
2008
2009         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
2010         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
2011
2012 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
2013
2014         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
2015         (check_empty): Use "const char *".
2016
2017         * gnu-nat.c (gnu_nat_target::detach): Instead of
2018         'detach_inferior (pid)' call
2019         'detach_inferior (find_inferior_pid (pid))'.
2020
2021         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
2022         'nat/fork-inferior.o'.
2023         * gnu-nat.c: #include "nat/fork-inferior.h".
2024
2025         * gnu-nat.c (gnu_nat_target::detach): Instead of
2026         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
2027         * gnu-nat.h: #include "inf-child.h".
2028         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
2029         'i386_gnu_nat_target::fetch_registers'.
2030         (gnu_store_registers): Rename/move to
2031         'i386_gnu_nat_target::store_registers'.
2032
2033         * config/i386/nm-i386gnu.h: Don't "#include" any files.
2034         * gnu-nat.h (mach_thread_info): New function.
2035         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
2036
2037         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
2038
2039 2019-02-14  Frederic Konrad  <konrad@adacore.com>
2040
2041         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
2042
2043 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
2044
2045         * windows-nat.c (windows_add_thread): Add new parameter
2046         "main_thread_p" with default value set to false.  Update
2047         function documentation as well as all callers.
2048         (windows_delete_thread): Likewise.
2049         (fake_create_process): Update call to windows_add_thread.
2050         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
2051         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
2052         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
2053         call to windows_delete_thread.
2054
2055 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
2056
2057         * MAINTAINERS: Add Andrew Burgess as global maintainer.
2058
2059 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2060
2061         * symfile.c (find_separate_debug_file): Use canonical path of
2062         sysroot with child_path instead of gdb_sysroot if it is valid.
2063
2064 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2065
2066         * symfile.c (find_separate_debug_file): Use child_path to
2067         determine if an object file is under a sysroot.
2068
2069 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2070
2071         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
2072         unittests/child-path-selftests.c.
2073         * common/pathstuff.c (child_path): New function.
2074         * common/pathstuff.h (child_path): New prototype.
2075         * unittests/child-path-selftests.c: New file.
2076
2077 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2078
2079         * symfile.c (find_separate_debug_file): Look for separate debug
2080         files in debug directories under the sysroot.
2081
2082 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2083
2084         * symtab.h (struct minimal_symbol data_p): New const method.
2085         (struct minimal_symbol text_p): Likewise.
2086         * symtab.c (output_source_filename): Use file name style
2087         to print file name.
2088         (print_symbol_info): Likewise.
2089         (print_msymbol_info): Use address style to print addresses.
2090         Use function name style to print executable text symbols.
2091         (expand_symtab_containing_pc): Use data_p.
2092         (find_pc_sect_compunit_symtab): Likewise.
2093
2094 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2095
2096         * breakpoint.c (describe_other_breakpoints): Use address style
2097         to print addresses.
2098         (say_where): Likewise.
2099
2100 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2101
2102         * ada-typeprint.c (print_func_type): Print function name
2103         style to print function name.
2104         * c-typeprint.c (c_print_type_1): Likewise.
2105
2106 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
2107
2108         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
2109         for execve.
2110
2111 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2112
2113         * c-exp.y (direct_abs_decl): Use emplace_back to record the
2114         type_stack.
2115
2116 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
2117
2118         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
2119         TYPE_CODE_REF types.
2120
2121 2019-02-08  Jim Wilson  <jimw@sifive.com>
2122
2123         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
2124         (riscv_linux_fregset): New.
2125         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
2126
2127 2019-02-07  Tom Tromey  <tom@tromey.com>
2128
2129         * thread.c (thread_cancel_execution_command): Update.
2130         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
2131         methods.
2132         (struct thread_fsm_ops): Remove.
2133         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
2134         (thread_fsm_should_stop, thread_fsm_return_value)
2135         (thread_fsm_set_finished, thread_fsm_finished_p)
2136         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
2137         Don't declare.
2138         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
2139         * infrun.c (clear_proceed_status_thread)
2140         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
2141         (print_stop_event): Update.
2142         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
2143         Add constructor.
2144         (step_command_fsm_ops): Remove.
2145         (new_step_command_fsm): Remove.
2146         (step_1): Update.
2147         (step_command_fsm::should_stop): Rename from
2148         step_command_fsm_should_stop.
2149         (step_command_fsm::clean_up): Rename from
2150         step_command_fsm_clean_up.
2151         (step_command_fsm::do_async_reply_reason): Rename from
2152         step_command_fsm_async_reply_reason.
2153         (struct until_next_fsm): Inherit from thread_fsm.  Add
2154         constructor.
2155         (until_next_fsm_ops): Remove.
2156         (new_until_next_fsm): Remove.
2157         (until_next_fsm::should_stop): Rename from
2158         until_next_fsm_should_stop.
2159         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
2160         (until_next_fsm::do_async_reply_reason): Rename from
2161         until_next_fsm_async_reply_reason.
2162         (struct finish_command_fsm): Inherit from thread_fsm.  Add
2163         constructor.  Change type of breakpoint.
2164         (finish_command_fsm_ops): Remove.
2165         (new_finish_command_fsm): Remove.
2166         (finish_command_fsm::should_stop): Rename from
2167         finish_command_fsm_should_stop.
2168         (finish_command_fsm::clean_up): Rename from
2169         finish_command_fsm_clean_up.
2170         (finish_command_fsm::return_value): Rename from
2171         finish_command_fsm_return_value.
2172         (finish_command_fsm::do_async_reply_reason): Rename from
2173         finish_command_fsm_async_reply_reason.
2174         (finish_command): Update.
2175         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
2176         Add constructor.
2177         (call_thread_fsm_ops): Remove.
2178         (call_thread_fsm::call_thread_fsm): Rename from
2179         new_call_thread_fsm.
2180         (call_thread_fsm::should_stop): Rename from
2181         call_thread_fsm_should_stop.
2182         (call_thread_fsm::should_notify_stop): Rename from
2183         call_thread_fsm_should_notify_stop.
2184         (run_inferior_call, call_function_by_hand_dummy): Update.
2185         * cli/cli-interp.c (should_print_stop_to_console): Update.
2186         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
2187         Add constructor.  Change type of location_breakpoint,
2188         caller_breakpoint.
2189         (until_break_fsm_ops): Remove.
2190         (new_until_break_fsm): Remove.
2191         (until_break_fsm::should_stop): Rename from
2192         until_break_fsm_should_stop.
2193         (until_break_fsm::clean_up): Rename from
2194         until_break_fsm_clean_up.
2195         (until_break_fsm::do_async_reply_reason): Rename from
2196         until_break_fsm_async_reply_reason.
2197         (until_break_command): Update.
2198         * thread-fsm.c: Remove.
2199         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
2200
2201 2019-02-07  Tom Tromey  <tom@tromey.com>
2202
2203         * yy-remap.h: Add include guard.
2204         * xtensa-tdep.h: Add include guard.
2205         * xcoffread.h: Rename include guard.
2206         * varobj-iter.h: Add include guard.
2207         * tui/tui.h: Rename include guard.
2208         * tui/tui-winsource.h: Rename include guard.
2209         * tui/tui-wingeneral.h: Rename include guard.
2210         * tui/tui-windata.h: Rename include guard.
2211         * tui/tui-win.h: Rename include guard.
2212         * tui/tui-stack.h: Rename include guard.
2213         * tui/tui-source.h: Rename include guard.
2214         * tui/tui-regs.h: Rename include guard.
2215         * tui/tui-out.h: Rename include guard.
2216         * tui/tui-layout.h: Rename include guard.
2217         * tui/tui-io.h: Rename include guard.
2218         * tui/tui-hooks.h: Rename include guard.
2219         * tui/tui-file.h: Rename include guard.
2220         * tui/tui-disasm.h: Rename include guard.
2221         * tui/tui-data.h: Rename include guard.
2222         * tui/tui-command.h: Rename include guard.
2223         * tic6x-tdep.h: Add include guard.
2224         * target/waitstatus.h: Rename include guard.
2225         * target/wait.h: Rename include guard.
2226         * target/target.h: Rename include guard.
2227         * target/resume.h: Rename include guard.
2228         * target-float.h: Rename include guard.
2229         * stabsread.h: Add include guard.
2230         * rs6000-tdep.h: Add include guard.
2231         * riscv-fbsd-tdep.h: Add include guard.
2232         * regformats/regdef.h: Rename include guard.
2233         * record.h: Rename include guard.
2234         * python/python.h: Rename include guard.
2235         * python/python-internal.h: Rename include guard.
2236         * python/py-stopevent.h: Rename include guard.
2237         * python/py-ref.h: Rename include guard.
2238         * python/py-record.h: Rename include guard.
2239         * python/py-record-full.h: Rename include guard.
2240         * python/py-record-btrace.h: Rename include guard.
2241         * python/py-instruction.h: Rename include guard.
2242         * python/py-events.h: Rename include guard.
2243         * python/py-event.h: Rename include guard.
2244         * procfs.h: Add include guard.
2245         * proc-utils.h: Add include guard.
2246         * p-lang.h: Add include guard.
2247         * or1k-tdep.h: Rename include guard.
2248         * observable.h: Rename include guard.
2249         * nto-tdep.h: Rename include guard.
2250         * nat/x86-linux.h: Rename include guard.
2251         * nat/x86-linux-dregs.h: Rename include guard.
2252         * nat/x86-gcc-cpuid.h: Add include guard.
2253         * nat/x86-dregs.h: Rename include guard.
2254         * nat/x86-cpuid.h: Rename include guard.
2255         * nat/ppc-linux.h: Rename include guard.
2256         * nat/mips-linux-watch.h: Rename include guard.
2257         * nat/linux-waitpid.h: Rename include guard.
2258         * nat/linux-ptrace.h: Rename include guard.
2259         * nat/linux-procfs.h: Rename include guard.
2260         * nat/linux-osdata.h: Rename include guard.
2261         * nat/linux-nat.h: Rename include guard.
2262         * nat/linux-namespaces.h: Rename include guard.
2263         * nat/linux-btrace.h: Rename include guard.
2264         * nat/glibc_thread_db.h: Rename include guard.
2265         * nat/gdb_thread_db.h: Rename include guard.
2266         * nat/gdb_ptrace.h: Rename include guard.
2267         * nat/fork-inferior.h: Rename include guard.
2268         * nat/amd64-linux-siginfo.h: Rename include guard.
2269         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
2270         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
2271         * nat/aarch64-linux.h: Rename include guard.
2272         * nat/aarch64-linux-hw-point.h: Rename include guard.
2273         * mn10300-tdep.h: Add include guard.
2274         * mips-linux-tdep.h: Add include guard.
2275         * mi/mi-parse.h: Rename include guard.
2276         * mi/mi-out.h: Rename include guard.
2277         * mi/mi-main.h: Rename include guard.
2278         * mi/mi-interp.h: Rename include guard.
2279         * mi/mi-getopt.h: Rename include guard.
2280         * mi/mi-console.h: Rename include guard.
2281         * mi/mi-common.h: Rename include guard.
2282         * mi/mi-cmds.h: Rename include guard.
2283         * mi/mi-cmd-break.h: Rename include guard.
2284         * m2-lang.h: Add include guard.
2285         * location.h: Rename include guard.
2286         * linux-record.h: Rename include guard.
2287         * linux-nat.h: Add include guard.
2288         * linux-fork.h: Add include guard.
2289         * i386-darwin-tdep.h: Rename include guard.
2290         * hppa-linux-offsets.h: Add include guard.
2291         * guile/guile.h: Rename include guard.
2292         * guile/guile-internal.h: Rename include guard.
2293         * gnu-nat.h: Rename include guard.
2294         * gdb-stabs.h: Rename include guard.
2295         * frv-tdep.h: Add include guard.
2296         * f-lang.h: Add include guard.
2297         * event-loop.h: Add include guard.
2298         * darwin-nat.h: Rename include guard.
2299         * cp-abi.h: Rename include guard.
2300         * config/sparc/nm-sol2.h: Rename include guard.
2301         * config/nm-nto.h: Rename include guard.
2302         * config/nm-linux.h: Add include guard.
2303         * config/i386/nm-i386gnu.h: Rename include guard.
2304         * config/djgpp/nl_types.h: Rename include guard.
2305         * config/djgpp/langinfo.h: Rename include guard.
2306         * compile/gcc-cp-plugin.h: Add include guard.
2307         * compile/gcc-c-plugin.h: Add include guard.
2308         * compile/compile.h: Rename include guard.
2309         * compile/compile-object-run.h: Rename include guard.
2310         * compile/compile-object-load.h: Rename include guard.
2311         * compile/compile-internal.h: Rename include guard.
2312         * compile/compile-cplus.h: Rename include guard.
2313         * compile/compile-c.h: Rename include guard.
2314         * common/xml-utils.h: Rename include guard.
2315         * common/x86-xstate.h: Rename include guard.
2316         * common/version.h: Rename include guard.
2317         * common/vec.h: Rename include guard.
2318         * common/tdesc.h: Rename include guard.
2319         * common/selftest.h: Rename include guard.
2320         * common/scoped_restore.h: Rename include guard.
2321         * common/scoped_mmap.h: Rename include guard.
2322         * common/scoped_fd.h: Rename include guard.
2323         * common/safe-iterator.h: Rename include guard.
2324         * common/run-time-clock.h: Rename include guard.
2325         * common/refcounted-object.h: Rename include guard.
2326         * common/queue.h: Rename include guard.
2327         * common/ptid.h: Rename include guard.
2328         * common/print-utils.h: Rename include guard.
2329         * common/preprocessor.h: Rename include guard.
2330         * common/pathstuff.h: Rename include guard.
2331         * common/observable.h: Rename include guard.
2332         * common/netstuff.h: Rename include guard.
2333         * common/job-control.h: Rename include guard.
2334         * common/host-defs.h: Rename include guard.
2335         * common/gdb_wait.h: Rename include guard.
2336         * common/gdb_vecs.h: Rename include guard.
2337         * common/gdb_unlinker.h: Rename include guard.
2338         * common/gdb_unique_ptr.h: Rename include guard.
2339         * common/gdb_tilde_expand.h: Rename include guard.
2340         * common/gdb_sys_time.h: Rename include guard.
2341         * common/gdb_string_view.h: Rename include guard.
2342         * common/gdb_splay_tree.h: Rename include guard.
2343         * common/gdb_setjmp.h: Rename include guard.
2344         * common/gdb_ref_ptr.h: Rename include guard.
2345         * common/gdb_optional.h: Rename include guard.
2346         * common/gdb_locale.h: Rename include guard.
2347         * common/gdb_assert.h: Rename include guard.
2348         * common/filtered-iterator.h: Rename include guard.
2349         * common/filestuff.h: Rename include guard.
2350         * common/fileio.h: Rename include guard.
2351         * common/environ.h: Rename include guard.
2352         * common/common-utils.h: Rename include guard.
2353         * common/common-types.h: Rename include guard.
2354         * common/common-regcache.h: Rename include guard.
2355         * common/common-inferior.h: Rename include guard.
2356         * common/common-gdbthread.h: Rename include guard.
2357         * common/common-exceptions.h: Rename include guard.
2358         * common/common-defs.h: Rename include guard.
2359         * common/common-debug.h: Rename include guard.
2360         * common/cleanups.h: Rename include guard.
2361         * common/buffer.h: Rename include guard.
2362         * common/btrace-common.h: Rename include guard.
2363         * common/break-common.h: Rename include guard.
2364         * cli/cli-utils.h: Rename include guard.
2365         * cli/cli-style.h: Rename include guard.
2366         * cli/cli-setshow.h: Rename include guard.
2367         * cli/cli-script.h: Rename include guard.
2368         * cli/cli-interp.h: Rename include guard.
2369         * cli/cli-decode.h: Rename include guard.
2370         * cli/cli-cmds.h: Rename include guard.
2371         * charset-list.h: Add include guard.
2372         * buildsym-legacy.h: Rename include guard.
2373         * bfin-tdep.h: Add include guard.
2374         * ax.h: Rename include guard.
2375         * arm-linux-tdep.h: Add include guard.
2376         * arm-fbsd-tdep.h: Add include guard.
2377         * arch/xtensa.h: Rename include guard.
2378         * arch/tic6x.h: Add include guard.
2379         * arch/i386.h: Add include guard.
2380         * arch/arm.h: Rename include guard.
2381         * arch/arm-linux.h: Rename include guard.
2382         * arch/arm-get-next-pcs.h: Rename include guard.
2383         * arch/amd64.h: Add include guard.
2384         * arch/aarch64-insn.h: Rename include guard.
2385         * arch-utils.h: Rename include guard.
2386         * annotate.h: Add include guard.
2387         * amd64-darwin-tdep.h: Rename include guard.
2388         * aarch64-linux-tdep.h: Add include guard.
2389         * aarch64-fbsd-tdep.h: Add include guard.
2390         * aarch32-linux-nat.h: Add include guard.
2391
2392 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2393
2394         * macrotab.c (macro_define_internal): New function that
2395         factorizes macro_define_object_internal and macro_define_function
2396         code.
2397         (macro_define_object_internal): Use macro_define_internal.
2398         (macro_define_function): Likewise.
2399
2400 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2401
2402         * macrocmd.c (extract_identifier): Return
2403         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
2404         callers.
2405
2406 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
2407
2408         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
2409
2410 2019-02-05  Tom Tromey  <tom@tromey.com>
2411
2412         * target.c (target_stack::unpush): Move assertion earlier.
2413
2414 2019-01-30  Tom Tromey  <tom@tromey.com>
2415
2416         PR python/23615:
2417         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
2418         (gdbpy_parse_and_eval): Likewise.
2419         * python/python-internal.h (gdbpy_allow_threads): New class.
2420
2421 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
2422
2423         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
2424         (aarch64_fbsd_fpregmap): Move earlier.
2425         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
2426         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2427         instead of individual calls to trad_frame_set_reg_addr.
2428         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
2429         earlier.
2430         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
2431         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2432         instead of individual calls to trad_frame_set_reg_addr.
2433
2434 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
2435
2436         * CONTRIBUTE: Replace contribution list with wiki link.
2437
2438 2019-01-25  Tom Tromey  <tom@tromey.com>
2439
2440         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
2441
2442 2019-01-25  Tom Tromey  <tom@tromey.com>
2443
2444         * xtensa-linux-nat.c: Fix common/ includes.
2445         * xml-support.h: Fix common/ includes.
2446         * xml-support.c: Fix common/ includes.
2447         * x86-linux-nat.c: Fix common/ includes.
2448         * windows-nat.c: Fix common/ includes.
2449         * varobj.h: Fix common/ includes.
2450         * varobj.c: Fix common/ includes.
2451         * value.c: Fix common/ includes.
2452         * valops.c: Fix common/ includes.
2453         * utils.c: Fix common/ includes.
2454         * unittests/xml-utils-selftests.c: Fix common/ includes.
2455         * unittests/utils-selftests.c: Fix common/ includes.
2456         * unittests/unpack-selftests.c: Fix common/ includes.
2457         * unittests/tracepoint-selftests.c: Fix common/ includes.
2458         * unittests/style-selftests.c: Fix common/ includes.
2459         * unittests/string_view-selftests.c: Fix common/ includes.
2460         * unittests/scoped_restore-selftests.c: Fix common/ includes.
2461         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
2462         * unittests/scoped_fd-selftests.c: Fix common/ includes.
2463         * unittests/rsp-low-selftests.c: Fix common/ includes.
2464         * unittests/parse-connection-spec-selftests.c: Fix common/
2465         includes.
2466         * unittests/optional-selftests.c: Fix common/ includes.
2467         * unittests/offset-type-selftests.c: Fix common/ includes.
2468         * unittests/observable-selftests.c: Fix common/ includes.
2469         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
2470         * unittests/memrange-selftests.c: Fix common/ includes.
2471         * unittests/memory-map-selftests.c: Fix common/ includes.
2472         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
2473         * unittests/function-view-selftests.c: Fix common/ includes.
2474         * unittests/environ-selftests.c: Fix common/ includes.
2475         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
2476         * unittests/common-utils-selftests.c: Fix common/ includes.
2477         * unittests/cli-utils-selftests.c: Fix common/ includes.
2478         * unittests/array-view-selftests.c: Fix common/ includes.
2479         * ui-file.c: Fix common/ includes.
2480         * tui/tui-io.c: Fix common/ includes.
2481         * tracepoint.h: Fix common/ includes.
2482         * tracepoint.c: Fix common/ includes.
2483         * tracefile-tfile.c: Fix common/ includes.
2484         * top.h: Fix common/ includes.
2485         * top.c: Fix common/ includes.
2486         * thread.c: Fix common/ includes.
2487         * target/waitstatus.h: Fix common/ includes.
2488         * target/waitstatus.c: Fix common/ includes.
2489         * target.h: Fix common/ includes.
2490         * target.c: Fix common/ includes.
2491         * target-memory.c: Fix common/ includes.
2492         * target-descriptions.c: Fix common/ includes.
2493         * symtab.h: Fix common/ includes.
2494         * symfile.c: Fix common/ includes.
2495         * stap-probe.c: Fix common/ includes.
2496         * spu-linux-nat.c: Fix common/ includes.
2497         * sparc-nat.c: Fix common/ includes.
2498         * source.c: Fix common/ includes.
2499         * solib.c: Fix common/ includes.
2500         * solib-target.c: Fix common/ includes.
2501         * ser-unix.c: Fix common/ includes.
2502         * ser-tcp.c: Fix common/ includes.
2503         * ser-pipe.c: Fix common/ includes.
2504         * ser-base.c: Fix common/ includes.
2505         * selftest-arch.c: Fix common/ includes.
2506         * s12z-tdep.c: Fix common/ includes.
2507         * rust-exp.y: Fix common/ includes.
2508         * rs6000-aix-tdep.c: Fix common/ includes.
2509         * riscv-tdep.c: Fix common/ includes.
2510         * remote.c: Fix common/ includes.
2511         * remote-notif.h: Fix common/ includes.
2512         * remote-fileio.h: Fix common/ includes.
2513         * remote-fileio.c: Fix common/ includes.
2514         * regcache.h: Fix common/ includes.
2515         * regcache.c: Fix common/ includes.
2516         * record-btrace.c: Fix common/ includes.
2517         * python/python.c: Fix common/ includes.
2518         * python/py-type.c: Fix common/ includes.
2519         * python/py-inferior.c: Fix common/ includes.
2520         * progspace.h: Fix common/ includes.
2521         * producer.c: Fix common/ includes.
2522         * procfs.c: Fix common/ includes.
2523         * proc-api.c: Fix common/ includes.
2524         * printcmd.c: Fix common/ includes.
2525         * ppc-linux-nat.c: Fix common/ includes.
2526         * parser-defs.h: Fix common/ includes.
2527         * osdata.c: Fix common/ includes.
2528         * obsd-nat.c: Fix common/ includes.
2529         * nat/x86-linux.c: Fix common/ includes.
2530         * nat/x86-linux-dregs.c: Fix common/ includes.
2531         * nat/x86-dregs.h: Fix common/ includes.
2532         * nat/x86-dregs.c: Fix common/ includes.
2533         * nat/ppc-linux.c: Fix common/ includes.
2534         * nat/mips-linux-watch.h: Fix common/ includes.
2535         * nat/mips-linux-watch.c: Fix common/ includes.
2536         * nat/linux-waitpid.c: Fix common/ includes.
2537         * nat/linux-ptrace.h: Fix common/ includes.
2538         * nat/linux-ptrace.c: Fix common/ includes.
2539         * nat/linux-procfs.c: Fix common/ includes.
2540         * nat/linux-personality.c: Fix common/ includes.
2541         * nat/linux-osdata.c: Fix common/ includes.
2542         * nat/linux-namespaces.c: Fix common/ includes.
2543         * nat/linux-btrace.h: Fix common/ includes.
2544         * nat/linux-btrace.c: Fix common/ includes.
2545         * nat/fork-inferior.c: Fix common/ includes.
2546         * nat/amd64-linux-siginfo.c: Fix common/ includes.
2547         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
2548         * nat/aarch64-linux.c: Fix common/ includes.
2549         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
2550         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
2551         * namespace.h: Fix common/ includes.
2552         * mips-linux-tdep.c: Fix common/ includes.
2553         * minsyms.c: Fix common/ includes.
2554         * mi/mi-parse.h: Fix common/ includes.
2555         * mi/mi-main.c: Fix common/ includes.
2556         * mi/mi-cmd-env.c: Fix common/ includes.
2557         * memrange.h: Fix common/ includes.
2558         * memattr.c: Fix common/ includes.
2559         * maint.h: Fix common/ includes.
2560         * maint.c: Fix common/ includes.
2561         * main.c: Fix common/ includes.
2562         * machoread.c: Fix common/ includes.
2563         * location.c: Fix common/ includes.
2564         * linux-thread-db.c: Fix common/ includes.
2565         * linux-nat.c: Fix common/ includes.
2566         * linux-fork.c: Fix common/ includes.
2567         * inline-frame.c: Fix common/ includes.
2568         * infrun.c: Fix common/ includes.
2569         * inflow.c: Fix common/ includes.
2570         * inferior.h: Fix common/ includes.
2571         * inferior.c: Fix common/ includes.
2572         * infcmd.c: Fix common/ includes.
2573         * inf-ptrace.c: Fix common/ includes.
2574         * inf-child.c: Fix common/ includes.
2575         * ia64-linux-nat.c: Fix common/ includes.
2576         * i387-tdep.c: Fix common/ includes.
2577         * i386-tdep.c: Fix common/ includes.
2578         * i386-linux-tdep.c: Fix common/ includes.
2579         * i386-linux-nat.c: Fix common/ includes.
2580         * i386-go32-tdep.c: Fix common/ includes.
2581         * i386-fbsd-tdep.c: Fix common/ includes.
2582         * i386-fbsd-nat.c: Fix common/ includes.
2583         * guile/scm-type.c: Fix common/ includes.
2584         * guile/guile.c: Fix common/ includes.
2585         * go32-nat.c: Fix common/ includes.
2586         * gnu-nat.c: Fix common/ includes.
2587         * gdbthread.h: Fix common/ includes.
2588         * gdbarch-selftests.c: Fix common/ includes.
2589         * gdb_usleep.c: Fix common/ includes.
2590         * gdb_select.h: Fix common/ includes.
2591         * gdb_bfd.c: Fix common/ includes.
2592         * gcore.c: Fix common/ includes.
2593         * fork-child.c: Fix common/ includes.
2594         * findvar.c: Fix common/ includes.
2595         * fbsd-nat.c: Fix common/ includes.
2596         * event-top.c: Fix common/ includes.
2597         * event-loop.c: Fix common/ includes.
2598         * dwarf2read.c: Fix common/ includes.
2599         * dwarf2loc.c: Fix common/ includes.
2600         * dwarf2-frame.c: Fix common/ includes.
2601         * dwarf-index-cache.c: Fix common/ includes.
2602         * dtrace-probe.c: Fix common/ includes.
2603         * disasm-selftests.c: Fix common/ includes.
2604         * defs.h: Fix common/ includes.
2605         * csky-tdep.c: Fix common/ includes.
2606         * cp-valprint.c: Fix common/ includes.
2607         * cp-support.h: Fix common/ includes.
2608         * cp-support.c: Fix common/ includes.
2609         * corelow.c: Fix common/ includes.
2610         * completer.h: Fix common/ includes.
2611         * completer.c: Fix common/ includes.
2612         * compile/compile.c: Fix common/ includes.
2613         * compile/compile-loc2c.c: Fix common/ includes.
2614         * compile/compile-cplus-types.c: Fix common/ includes.
2615         * compile/compile-cplus-symbols.c: Fix common/ includes.
2616         * command.h: Fix common/ includes.
2617         * cli/cli-dump.c: Fix common/ includes.
2618         * cli/cli-cmds.c: Fix common/ includes.
2619         * charset.c: Fix common/ includes.
2620         * build-id.c: Fix common/ includes.
2621         * btrace.h: Fix common/ includes.
2622         * btrace.c: Fix common/ includes.
2623         * breakpoint.h: Fix common/ includes.
2624         * breakpoint.c: Fix common/ includes.
2625         * ax.h: 
2626         (enum agent_op): Fix common/ includes.
2627         * ax-general.c (struct aop_map): Fix common/ includes.
2628         * ax-gdb.c: Fix common/ includes.
2629         * auxv.c: Fix common/ includes.
2630         * auto-load.c: Fix common/ includes.
2631         * arm-tdep.c: Fix common/ includes.
2632         * arch/riscv.c: Fix common/ includes.
2633         * arch/ppc-linux-common.c: Fix common/ includes.
2634         * arch/i386.c: Fix common/ includes.
2635         * arch/arm.c: Fix common/ includes.
2636         * arch/arm-linux.c: Fix common/ includes.
2637         * arch/arm-get-next-pcs.c: Fix common/ includes.
2638         * arch/amd64.c: Fix common/ includes.
2639         * arch/aarch64.c: Fix common/ includes.
2640         * arch/aarch64-insn.c: Fix common/ includes.
2641         * arch-utils.c: Fix common/ includes.
2642         * amd64-windows-tdep.c: Fix common/ includes.
2643         * amd64-tdep.c: Fix common/ includes.
2644         * amd64-sol2-tdep.c: Fix common/ includes.
2645         * amd64-obsd-tdep.c: Fix common/ includes.
2646         * amd64-nbsd-tdep.c: Fix common/ includes.
2647         * amd64-linux-tdep.c: Fix common/ includes.
2648         * amd64-linux-nat.c: Fix common/ includes.
2649         * amd64-fbsd-tdep.c: Fix common/ includes.
2650         * amd64-fbsd-nat.c: Fix common/ includes.
2651         * amd64-dicos-tdep.c: Fix common/ includes.
2652         * amd64-darwin-tdep.c: Fix common/ includes.
2653         * agent.c: Fix common/ includes.
2654         * ada-lang.h: Fix common/ includes.
2655         * ada-lang.c: Fix common/ includes.
2656         * aarch64-tdep.c: Fix common/ includes.
2657
2658 2019-01-25  Tom Tromey  <tom@tromey.com>
2659
2660         * common/create-version.sh: Use common/version.h.
2661
2662 2019-01-24  Pedro Alves  <palves@redhat.com>
2663
2664         * infrun.c (signal_stop, signal_print, signal_program)
2665         (signal_catch, signal_pass): Now arrays instead of pointers.
2666         (update_signals_program_target, do_target_resume)
2667         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
2668         * linux-nat.c (linux_nat_target::pass_signals)
2669         (linux_nat_target::create_inferior, linux_nat_target::attach):
2670         Adjust.
2671         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
2672         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
2673         * procfs.c (procfs_target::pass_signals): Adjust.
2674         * record-full.c (record_full_target::resume): Adjust.
2675         * remote.c (remote_target::pass_signals)
2676         (remote_target::program_signals): Adjust.
2677         * target-debug.h (target_debug_print_signals): Now takes a
2678         gdb::array_view as parameter.  Adjust.
2679         * target.h (target_ops) <pass_signals, program_signals>: Replace
2680         pointer and length parameters with gdb::array_view.
2681         (target_pass_signals, target_program_signals): Likewise.
2682         * target-delegates.c: Regenerate.
2683
2684 2019-01-24  Pedro Alves  <palves@redhat.com>
2685
2686         * common/forward-scope-exit.h
2687         (forward_scope_exit::forward_scope_exit): Pass arguments to
2688         m_bind_function directly, instead of creating a std::bind and
2689         copying that.
2690
2691 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
2692
2693         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2694         for static members.
2695         (pass_in_v_vfp_candidate): Likewise.
2696
2697 2019-01-23  Tom Tromey  <tom@tromey.com>
2698             Pedro Alves  <palves@redhat.com>
2699
2700         * regcache.c (class regcache_invalidator): Remove.
2701         (regcache::raw_write): Use make_scope_exit.
2702
2703 2019-01-23  Tom Tromey  <tom@tromey.com>
2704
2705         * ui-out.h (class ui_out_emit_type): Update comment.
2706
2707 2019-01-23  Tom Tromey  <tom@tromey.com>
2708
2709         * infrun.c (fetch_inferior_event): Update comment.
2710
2711 2019-01-23  Tom Tromey  <tom@tromey.com>
2712             Pedro Alves  <palves@redhat.com>
2713
2714         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
2715         parameter.
2716         (fetch_inferior_event): Use SCOPE_EXIT.
2717
2718
2719 2019-01-23  Tom Tromey  <tom@tromey.com>
2720             Pedro Alves  <palves@redhat.com>
2721
2722         * infrun.c (disable_thread_events): Delete.
2723         (stop_all_threads): Use SCOPE_EXIT.
2724
2725 2019-01-23  Tom Tromey  <tom@tromey.com>
2726             Pedro Alves  <palves@redhat.com>
2727
2728         * symfile.c: Include forward-scope-exit.h.
2729         (clear_symtab_users_cleanup): Replace forward declaration with
2730         a FORWARD_SCOPE_EXIT.
2731         (syms_from_objfile_1): Use the forward_scope_exit and
2732         gdb::optional instead of cleanup_function.
2733         (reread_symbols): Use the forward_scope_exit instead of
2734         cleanup_function.
2735         (clear_symtab_users_cleanup): Remove function.
2736
2737 2019-01-23  Tom Tromey  <tom@tromey.com>
2738             Pedro Alves  <palves@redhat.com>
2739
2740         * linux-nat.c: Include scope-exit.h.
2741         (cleanup_target_stop): Remove.
2742         (linux_nat_target::static_tracepoint_markers_by_strid): Use
2743         SCOPE_EXIT.
2744
2745 2019-01-23  Tom Tromey  <tom@tromey.com>
2746             Pedro Alves  <palves@redhat.com>
2747
2748         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
2749         (call_function_by_hand_dummy): Use SCOPE_EXIT.
2750
2751 2019-01-23  Tom Tromey  <tom@tromey.com>
2752             Andrew Burgess  <andrew.burgess@embecosm.com>
2753             Pedro Alves  <palves@redhat.com>
2754
2755         * infrun.c (fetch_inferior_event): Use scope_exit.
2756         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
2757         * top.c (execute_command): Use scope_exit.
2758         * breakpoint.c (bpstat_do_actions): Use scope_exit.
2759         * utils.c (do_bpstat_clear_actions_cleanup)
2760         (make_bpstat_clear_actions_cleanup): Remove.
2761
2762 2019-01-23  Tom Tromey  <tom@tromey.com>
2763             Pedro Alves  <palves@redhat.com>
2764
2765         * infrun.c: Include "common/scope-exit.h"
2766         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
2767         (wait_for_inferior): Use SCOPE_EXIT.
2768         (fetch_inferior_event): Use scope_exit.
2769
2770 2019-01-23  Tom Tromey  <tom@tromey.com>
2771             Pedro Alves  <palves@redhat.com>
2772
2773         * breakpoint.c (create_breakpoint): Remove cleanup.
2774
2775 2019-01-23  Tom Tromey  <tom@tromey.com>
2776             Andrew Burgess  <andrew.burgess@embecosm.com>
2777             Pedro Alves  <palves@redhat.com>
2778
2779 2019-01-23  Pedro Alves  <palves@redhat.com>
2780
2781         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
2782
2783 2019-01-23  Pedro Alves  <palves@redhat.com>
2784             Andrew Burgess  <andrew.burgess@embecosm.com>
2785
2786         * gdbthread.h: Include "common/forward-scope-exit.h".
2787         (scoped_finish_thread_state): Redefine custom class in terms of
2788         forward_scope_exit.
2789
2790 2019-01-23  Pedro Alves  <palves@redhat.com>
2791             Andrew Burgess  <andrew.burgess@embecosm.com>
2792
2793         * common/forward-scope-exit.h: New file.
2794
2795 2019-01-23  Pedro Alves  <palves@redhat.com>
2796             Andrew Burgess  <andrew.burgess@embecosm.com>
2797             Tom Tromey  <tom@tromey.com>
2798
2799         * common/scope-exit.h: New file.
2800
2801 2019-01-23  Pedro Alves  <palves@redhat.com>
2802
2803         * common/preprocessor.h (ESC): Rename to ...
2804         (ESC_PARENS): ... this.
2805         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
2806         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
2807
2808 2019-01-23  Tom Tromey  <tom@tromey.com>
2809
2810         * language.h (class scoped_switch_to_sym_language_if_auto):
2811         Initialize m_lang in both cases.
2812
2813 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
2814
2815         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
2816         with XCNEW.
2817
2818 2019-01-22  Tom Tromey  <tom@tromey.com>
2819
2820         * corelow.c: Do not include sys/file.h.
2821
2822 2019-01-22  Tom Tromey  <tom@tromey.com>
2823
2824         * tui/tui-wingeneral.h: Include gdb_curses.h.
2825
2826 2019-01-22  Tom Tromey  <tom@tromey.com>
2827
2828         * source-cache.h (class source_cache) <get_source_lines,
2829         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
2830
2831 2019-01-22  Tom Tromey  <tom@tromey.com>
2832
2833         * remote-fileio.h (struct remote_target): Declare.
2834
2835 2019-01-22  Tom Tromey  <tom@tromey.com>
2836
2837         * python/py-arch.c: Do not include py-ref.h.
2838         * python/py-bpevent.c: Do not include py-ref.h.
2839         * python/py-cmd.c: Do not include py-ref.h.
2840         * python/py-continueevent.c: Do not include py-ref.h.
2841         * python/py-event.h: Do not include py-ref.h.
2842         * python/py-evtregistry.c: Do not include py-ref.h.
2843         * python/py-finishbreakpoint.c: Do not include py-ref.h.
2844         * python/py-frame.c: Do not include py-ref.h.
2845         * python/py-framefilter.c: Do not include py-ref.h.
2846         * python/py-function.c: Do not include py-ref.h.
2847         * python/py-infevents.c: Do not include py-ref.h.
2848         * python/py-linetable.c: Do not include py-ref.h.
2849         * python/py-objfile.c: Do not include py-ref.h.
2850         * python/py-param.c: Do not include py-ref.h.
2851         * python/py-prettyprint.c: Do not include py-ref.h.
2852         * python/py-progspace.c: Do not include py-ref.h.
2853         * python/py-symbol.c: Do not include py-ref.h.
2854         * python/py-symtab.c: Do not include py-ref.h.
2855         * python/py-type.c: Do not include py-ref.h.
2856         * python/py-unwind.c: Do not include py-ref.h.
2857         * python/py-utils.c: Do not include py-ref.h.
2858         * python/py-value.c: Do not include py-ref.h.
2859         * python/py-varobj.c: Do not include py-ref.h.
2860         * python/py-xmethods.c: Do not include py-ref.h.
2861         * python/python.c: Do not include py-ref.h.
2862         * varobj.c: Do not include py-ref.h.
2863
2864 2019-01-22  Tom Tromey  <tom@tromey.com>
2865
2866         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
2867         keyword for bcache.
2868
2869 2019-01-22  Tom Tromey  <tom@tromey.com>
2870
2871         * compile/compile-cplus-types.c: Remove a comment by #include.
2872
2873 2019-01-22  Tom Tromey  <tom@tromey.com>
2874
2875         * compile/gcc-c-plugin.h: Include compile-internal.h.
2876
2877 2019-01-22  Tom Tromey  <tom@tromey.com>
2878
2879         * stabsread.c (EXTERN): Do not define.
2880         (symnum, next_symbol_text_func, processing_gcc_compilation)
2881         (within_function, global_sym_chain, global_stabs)
2882         (previous_stab_code, this_object_header_files)
2883         (n_this_object_header_files)
2884         (n_allocated_this_object_header_files): Define.
2885         * stabsread.h (EXTERN): Never define.  Use "extern".
2886
2887 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2888
2889         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
2890         history_value.
2891
2892 2019-01-21  Tom Tromey  <tom@tromey.com>
2893
2894         * ui-out.c: Fix includes.
2895         * tui/tui-source.c: Fix includes.
2896         * target.c: Fix includes.
2897         * remote.c: Fix includes.
2898         * regcache.c: Fix includes.
2899         * python/py-block.c: Fix includes.
2900         * printcmd.c: Fix includes.
2901         * or1k-tdep.c: Fix includes.
2902         * mi/mi-main.c: Fix includes.
2903         * m32r-tdep.c: Fix includes.
2904         * csky-tdep.c: Fix includes.
2905         * compile/compile-cplus-types.c: Fix includes.
2906         * cli/cli-interp.c: Fix includes.
2907
2908 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
2909
2910         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2911         for padding.
2912
2913 2019-01-16  Tom Tromey  <tom@tromey.com>
2914
2915         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
2916         earlier.
2917         (struct objfile) <msymbols_range>: Move from top level.
2918         <msymbols>: New method.
2919         (class objfile_msymbols): Remove.
2920         * symtab.c (default_collect_symbol_completion_matches_break_on):
2921         Update.
2922         * symmisc.c (dump_msymbols): Update.
2923         * stabsread.c (scan_file_globals): Update.
2924         * objc-lang.c (info_selectors_command, info_classes_command)
2925         (find_methods): Update.
2926         * minsyms.c (find_solib_trampoline_target): Update.
2927         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
2928         * coffread.c (coff_symfile_read): Update.
2929         * ada-lang.c (ada_lookup_simple_minsym)
2930         (ada_collect_symbol_completion_matches): Update.
2931
2932 2019-01-16  Tom Tromey  <tom@tromey.com>
2933
2934         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
2935         type.  Remove no-argument constructor.
2936         <iterator::operator++>: Simplify.
2937         <begin>: Update.
2938         <end>: Use minimal_symbol_count.
2939
2940 2019-01-16  Tom Tromey  <tom@tromey.com>
2941
2942         * objfiles.h (struct objfile) <psymtabs>: New method.
2943         (class objfile_psymtabs): Remove.
2944         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
2945         typedef.
2946         <range>: New method.
2947         (require_partial_symbols): Change return type.
2948         * psymtab.c (require_partial_symbols)
2949         (psym_expand_symtabs_matching): Update.
2950         * mdebugread.c (parse_partial_symbols): Update.
2951         * dbxread.c (dbx_end_psymtab): Update.
2952
2953 2019-01-15  Tom Tromey  <tom@tromey.com>
2954
2955         * symtab.c (lookup_objfile_from_block)
2956         (lookup_symbol_in_objfile_symtabs)
2957         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
2958         (find_line_symtab, info_sources_command)
2959         (default_collect_symbol_completion_matches_break_on)
2960         (make_source_files_completion_list): Update.
2961         * symmisc.c (print_objfile_statistics, dump_objfile)
2962         (maintenance_print_symbols, maintenance_info_symtabs)
2963         (maintenance_check_symtabs, maintenance_info_line_tables):
2964         Update.
2965         * source.c (select_source_symtab)
2966         (forget_cached_source_info_for_objfile): Update.
2967         * objfiles.h (class objfile_compunits): Remove.
2968         (struct objfile) <compunits_range>: New typedef.
2969         (compunits): New method.
2970         * objfiles.c (objfile_relocate1): Update.
2971         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2972         * maint.c (count_symtabs_and_blocks): Update.
2973         * linespec.c (iterate_over_all_matching_symtabs): Update.
2974         * cp-support.c (add_symbol_overload_list_qualified): Update.
2975         * coffread.c (coff_symtab_read): Update.
2976         * ada-lang.c (add_nonlocal_symbols)
2977         (ada_collect_symbol_completion_matches)
2978         (ada_add_global_exceptions): Update.
2979
2980 2019-01-15  Tom Tromey  <tom@tromey.com>
2981
2982         * progspace.h (program_space) <objfiles_safe_range>: New
2983         typedef.
2984         <objfiles_safe>: New method.
2985         * objfiles.h (class all_objfiles_safe): Remove.
2986         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
2987         * jit.c (jit_inferior_exit_hook): Update.
2988
2989 2019-01-17  Tom Tromey  <tom@tromey.com>
2990
2991         * progspace.h (program_space) <objfiles_range>: New typedef.
2992         <objfiles>: New method.
2993         <objfiles_head>: Rename from objfiles.
2994         (object_files): Update.
2995         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
2996         * guile/scm-pretty-print.c
2997         (ppscm_find_pretty_printer_from_objfiles): Update.
2998         * guile/scm-objfile.c (gdbscm_objfiles): Update.
2999         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
3000         Update.
3001         * python/py-progspace.c (pspy_get_objfiles): Update.
3002         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3003         Update.
3004         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3005         (objfpy_lookup_objfile_by_build_id): Update.
3006         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
3007         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3008         Update.
3009         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3010         (expand_symtab_containing_pc, lookup_objfile_from_block)
3011         (lookup_static_symbol, basic_lookup_transparent_type)
3012         (find_pc_sect_compunit_symtab, find_symbol_at_address)
3013         (find_line_symtab, info_sources_command)
3014         (default_collect_symbol_completion_matches_break_on)
3015         (make_source_files_completion_list, find_main_name): Update.
3016         * symmisc.c (print_symbol_bcache_statistics)
3017         (print_objfile_statistics, maintenance_print_symbols)
3018         (maintenance_print_msymbols, maintenance_print_objfiles)
3019         (maintenance_info_symtabs, maintenance_check_symtabs)
3020         (maintenance_expand_symtabs, maintenance_info_line_tables):
3021         Update.
3022         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
3023         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
3024         (map_overlay_command, unmap_overlay_command)
3025         (simple_overlay_update, expand_symtabs_matching)
3026         (map_symbol_filenames): Update.
3027         * symfile-debug.c (set_debug_symfile): Update.
3028         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
3029         Update.
3030         * source.c (select_source_symtab, forget_cached_source_info):
3031         Update.
3032         * solib.c (solib_read_symbols): Update.
3033         * solib-spu.c (append_ocl_sos): Update.
3034         * psymtab.c (maintenance_print_psymbols)
3035         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
3036         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
3037         * printcmd.c (info_symbol_command): Update.
3038         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
3039         Update.
3040         * objfiles.h (class all_objfiles): Remove.
3041         * objfiles.c (have_partial_symbols, have_full_symbols)
3042         (have_minimal_symbols, qsort_cmp, update_section_map)
3043         (shared_objfile_contains_address_p)
3044         (default_iterate_over_objfiles_in_search_order): Update.
3045         * objc-lang.c (info_selectors_command, info_classes_command)
3046         (find_methods): Update.
3047         * minsyms.c (find_solib_trampoline_target): Update.
3048         * maint.c (maintenance_info_sections)
3049         (maintenance_translate_address, count_symtabs_and_blocks):
3050         Update.
3051         * main.c (captured_main_1): Update.
3052         * linux-thread-db.c (try_thread_db_load_from_pdir)
3053         (has_libpthread): Update.
3054         * linespec.c (iterate_over_all_matching_symtabs)
3055         (search_minsyms_for_name): Update.
3056         * jit.c (jit_find_objf_with_entry_addr): Update.
3057         * hppa-tdep.c (find_unwind_entry)
3058         (hppa_lookup_stub_minimal_symbol): Update.
3059         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
3060         Update.
3061         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3062         (elf_gnu_ifunc_resolve_by_got): Update.
3063         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
3064         * dwarf-index-write.c (save_gdb_index_command): Update.
3065         * cp-support.c (add_symbol_overload_list_qualified): Update.
3066         * breakpoint.c (create_overlay_event_breakpoint)
3067         (create_longjmp_master_breakpoint)
3068         (create_std_terminate_master_breakpoint)
3069         (create_exception_master_breakpoint): Update.
3070         * blockframe.c (find_pc_partial_function): Update.
3071         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
3072         (ada_collect_symbol_completion_matches)
3073         (ada_add_global_exceptions): Update.
3074
3075 2019-01-17  Tom Tromey  <tom@tromey.com>
3076
3077         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
3078         declare VEC.
3079         (solib_target_parse_libraries): Change return type.
3080         (library_list_start_segment, library_list_start_section)
3081         (library_list_end_library, library_list_start_library); Update.
3082         (solib_target_free_library_list): Remove.
3083         (solib_target_parse_libraries): Remove cleanup.  Change return
3084         type.
3085         (solib_target_current_sos): Update.
3086
3087 2019-01-17  Tom Tromey  <tromey@bapiya>
3088
3089         * valprint.c: Replace "the the" with "the".
3090         * symtab.c: Replace "the the" with "the".
3091         * solib.c: Replace "the the" with "the".
3092         * solib-dsbt.c: Replace "the the" with "the".
3093         * linespec.c: Replace "the the" with "the".
3094         * dwarf2loc.h: Replace "the the" with "the".
3095         * amd64-windows-tdep.c: Replace "the the" with "the".
3096         * aarch64-tdep.c: Replace "the the" with "the".
3097
3098 2019-01-16  Keith Seitz  <keiths@redhat.com>
3099
3100         PR gdb/23773
3101         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
3102         <builder>: Rename to ..
3103         <m_builder>: ... this and make private.
3104         (dwarf2_cu::get_builder): New method.  Change all users of
3105         `builder' to use this method.
3106         (dwarf2_start_symtab): Move to ...
3107         (dwarf2_cu::start_symtab): ... here.  Update all callers
3108         (setup_type_unit_groups): Move to ...
3109         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
3110         callers.
3111         (dwarf2_cu::reset_builder): New method.
3112         (process_full_compunit, process_full_type_unit): Use
3113         dwarf2_cu::reset_builder.
3114         (follow_die_offset): Record the ancestor CU if it is different
3115         from the followed DIE's CU.
3116         (follow_die_sig_1): Likewise.
3117
3118 2019-01-15  Tom Tromey  <tom@tromey.com>
3119
3120         * remote.c (class remote_state) <buf>: Now a char_vector.
3121         <buf_size>: Remove.
3122         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
3123         parameter.
3124         (remote_target::getpkt_or_notif_sane_1)
3125         (remote_target::getpkt_sane)
3126         (remote_target::getpkt_or_notif_sane): Likewise.
3127         (class remote_target) <putpkt>: New overload.
3128         (remote_target::read_frame): Change type of "buf_p".  Remove
3129         sizeof_p parameter.
3130         (packet_ok): New overload.
3131         (packet_check_result): New overload.
3132         Update all uses.
3133
3134 2019-01-14  Tom Tromey  <tom@tromey.com>
3135
3136         * remote-notif.c (handle_notification, remote_notif_ack)
3137         (remote_notif_parse): Make "buf" const.
3138         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
3139         const.
3140         (remote_notif_parse, remote_notif_ack, handle_notification):
3141         Likewise.
3142         * remote.c (remote_notif_stop_parse): Make "buf" const.
3143         (remote_target::remote_parse_stop_reply): Make "buf" const.
3144         (remote_notif_stop_ack): Make "buf" const.
3145
3146 2019-01-14  Tom Tromey  <tom@tromey.com>
3147
3148         * remote.c (remote_console_output): Make parameter const.
3149
3150 2019-01-14  Tom Tromey  <tom@tromey.com>
3151
3152         * target-debug.h (target_debug_print_signals): Constify.
3153         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
3154         * procfs.c (procfs_target::pass_signals): Update.
3155         * linux-nat.c (linux_nat_target::pass_signals): Update.
3156         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
3157         * target-delegates.c: Rebuild.
3158         * remote.c (remote_target::program_signals): Update.
3159         (remote_target::pass_signals): Update.
3160         * target.c (target_pass_signals): Constify argument.
3161         (target_program_signals): Likewise.
3162         * target.h (struct target_ops) <pass_signals, program_signals>:
3163         Constify argument.
3164         (target_pass_signals, target_program_signals): Constify argument.
3165
3166 2019-01-14  Tom Tromey  <tom@tromey.com>
3167
3168         PR tui/28819:
3169         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
3170
3171 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3172
3173         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
3174         field.
3175         * rs6000-tdep.c: Include reggroups.h.
3176         (IS_V_ALIAS_PSEUDOREG): Define.
3177         (rs6000_register_name): Return names for the "vX" aliases.
3178         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
3179         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
3180         aliases.  Call default_register_reggroup_p for all other
3181         pseudo-registers.
3182         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
3183         New functions.
3184         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
3185         Handle "vX" aliases.
3186         (v_alias_pseudo_register_collect): New function.
3187         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
3188         (rs6000_gdbarch_init): Initialize "vX" aliases as
3189         pseudo-registers.  Restore registration of
3190         rs6000_pseudo_register_reggroup_p with
3191         set_tdesc_pseudo_register_reggroup_p.
3192
3193 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
3194
3195         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
3196         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
3197         set_gdbarch_num_pseudo_regs.
3198
3199 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3200
3201         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
3202         Remove arg prefixname, add do_set and do_show.
3203         Add member functions set_list and show_list.
3204         * cli/cli-style.c (class cli_style_option): Update accordingly.
3205         (style_set_list): Move to file scope.
3206         (style_show_list): Likewise.
3207         (set_style): Call help_list.
3208         (show_style): Call cmd_show_list.
3209         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
3210         Update to use the new macro.
3211
3212 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
3213
3214         * ada-lang.c (_initialize_ada_language): Expand the help text
3215         for the "catch exception" command.
3216
3217 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3218
3219         * symtab.c (matching_obj_sections): Initialize obj,
3220         declare it closer to its usage.
3221
3222 2019-01-10  Tom Tromey  <tom@tromey.com>
3223
3224         * thread-iter.h (inf_threads_iterator): Use next_iterator.
3225         (basic_inf_threads_range): Remove.
3226         (inf_threads_range, inf_non_exited_threads_range)
3227         (safe_inf_threads_range): Use next_adapter.
3228
3229 2019-01-10  Keith Seitz  <keiths@redhat.com>
3230
3231         PR gdb/23712
3232         PR symtab/23010
3233         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
3234         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
3235
3236 2019-01-10  Keith Seitz  <keiths@redhat.com>
3237
3238         PR gdb/23712
3239         PR symtab/23010
3240         * dictionary.c (pending_to_vector): Remove.
3241         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3242         Remove _1 suffix, replacing functions of the same name.  Update
3243         all callers.
3244         (dict_create_hashed, dict_create_hashed_expandable)
3245         (dict_create_linear, dict_create_linear_expandable, dict_free)
3246         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
3247         Make functions static.
3248
3249 2019-01-10  Keith Seitz  <keiths@redhat.com>
3250
3251         PR gdb/23712
3252         PR symtab/23010
3253         * dictionary.h (struct dictionary): Replace declaration with
3254         multidictionary.
3255         (dict_create_hashed, dict_create_hashed_expandable)
3256         (dict_create_linear, dict_create_linear_expandable)
3257         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
3258         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
3259         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
3260         taking multidictionary argument.
3261         [ALL_DICT_SYMBOLS]: Update for multidictionary.
3262         * block.h (struct block) <dict>: Change to multidictionary
3263         and rename `multidict'.
3264         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
3265         symmisc.c: Update all dictionary references to multidictionary.
3266
3267 2019-01-10  Keith Seitz  <keiths@redhat.com>
3268
3269         PR gdb/23712
3270         PR symtab/23010
3271         * dictionary.c: Include unordered_map.
3272         (pending_to_vector): New function.
3273         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3274         Rewrite the non-"_1" functions to take vector instead
3275         of linked list.
3276         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
3277         "new" _1 versions of the same name.
3278         (multidictionary): Define.
3279         (std::hash<enum language): New definition.
3280         (collate_pending_symbols_by_language, mdict_create_hashed)
3281         (mdict_create_hashed_expandable, mdict_create_linear)
3282         (mdict_create_linear_expandable, mdict_free)
3283         (find_language_dictionary, create_new_language_dictionary)
3284         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
3285         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
3286         (mdict_size, mdict_empty): New functions.
3287         * dictionary.h (mdict_iterator): Define.
3288
3289 2019-01-10  Pedro Alves  <palves@redhat.com>
3290
3291         * breakpoint.c (read_uploaded_action)
3292         (create_tracepoint_from_upload): Adjust to use
3293         gdb::unique_xmalloc_ptr.
3294         * ctf.c (ctf_write_uploaded_tp):
3295         (SET_ARRAY_FIELD): Use emplace_back.
3296         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
3297         * tracefile-tfile.c (tfile_write_uploaded_tp):
3298         * tracepoint.c (parse_tracepoint_definition): Adjust to use
3299         gdb::unique_xmalloc_ptr.
3300         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
3301         at_string, cond_string, cmd_strings>: Replace char pointers
3302         with gdb::unique_xmalloc_ptr.
3303
3304 2019-01-10  Pedro Alves  <palves@redhat.com>
3305
3306         * solib-target.c (library_list_start_library): Don't xstrdup name.
3307
3308 2019-01-10  Pedro Alves  <palves@redhat.com>
3309
3310         * mdebugread.c (parse_partial_symbols): Use
3311         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
3312
3313 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3314
3315         * linux-fork.c (scoped_switch_fork_info)
3316         <~scoped_switch_fork_info>: Fix incorrect variable name.
3317
3318 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3319
3320         * linux-fork.c (scoped_switch_fork_info)
3321         <scoped_switch_fork_info>: Make explicit.
3322         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
3323
3324 2019-01-10  Tom Tromey  <tom@tromey.com>
3325
3326         * objfiles.h (objfile::reset_psymtabs): Update.
3327         * objfiles.c (objfile::objfile): Update.
3328         * psymtab.h (psymtab_storage::obstack): Update.
3329         (psymtab_storage::m_obstack): Use gdb::optional.
3330         (class psymtab_storage): Update comment.  Remove objfile
3331         parameter.
3332         * psymtab.c (psymtab_storage::psymtab_storage): Update.
3333
3334 2019-01-10  Tom Tromey  <tom@tromey.com>
3335
3336         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
3337         <free_psymtabs>: Now private.
3338         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
3339         (allocate_psymtab): Use new method.
3340
3341 2019-01-10  Tom Tromey  <tom@tromey.com>
3342
3343         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
3344         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
3345         * mdebugread.c (parse_partial_symbols): Use
3346         allocate_dependencies.
3347         * dwarf2read.c (dwarf2_create_include_psymtab): Use
3348         allocate_dependencies.
3349         (process_psymtab_comp_unit_reader)
3350         (build_type_psymtab_dependencies): Likewise.
3351         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
3352
3353 2019-01-10  Tom Tromey  <tom@tromey.com>
3354
3355         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
3356         PSYMBOL_SET_LANGUAGE.
3357         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
3358
3359 2019-01-10  Tom Tromey  <tom@tromey.com>
3360
3361         * psymtab.h (psymtab_storage::obstack): New method.
3362         <m_obstack>: Rename from obstack; now private.
3363         * psymtab.c (psymtab_storage): Update.
3364         * dwarf2read.c (create_addrmap_from_index)
3365         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
3366         Update.
3367
3368 2019-01-10  Tom Tromey  <tom@tromey.com>
3369
3370         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
3371         * objfiles.h (objfile::reset_psymtabs): New method.
3372
3373 2019-01-10  Tom Tromey  <tom@tromey.com>
3374
3375         * symmisc.c (print_symbol_bcache_statistics): Update.
3376         (print_objfile_statistics): Update.
3377         * symfile.c (reread_symbols): Update.
3378         * psymtab.h (class psymtab_storage): New.
3379         * psymtab.c (psymtab_storage): New constructor.
3380         (~psymtab_storage): New destructor.
3381         (require_partial_symbols): Update.
3382         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
3383         (find_pc_sect_psymtab, find_pc_sect_psymbol)
3384         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
3385         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
3386         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
3387         (start_psymtab_common, end_psymtab_common)
3388         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
3389         (allocate_psymtab): Update.
3390         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
3391         Update.
3392         (dump_psymtab_addrmap, maintenance_print_psymbols)
3393         (maintenance_check_psymtabs): Update.
3394         (class objfile_psymtabs): Move to objfiles.h.
3395         * psympriv.h (discard_psymtab): Now inline.
3396         (psymtab_discarder::psymtab_discarder): Update.
3397         (psymtab_discarder::~psymtab_discarder): Update.
3398         (ALL_OBJFILE_PSYMTABS): Rewrite.
3399         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
3400         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
3401         Remove fields.
3402         <partial_symtabs>: New field.
3403         (class objfile_psymtabs): Move from psymtab.h.  Update.
3404         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
3405         psymbol_cache.
3406         (objfile::~objfile): Don't destroy psymbol_cache.
3407         * mdebugread.c (parse_partial_symbols): Update.
3408         * dwarf2read.c (create_addrmap_from_index)
3409         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
3410         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
3411         (add_partial_subprogram, dwarf2_ranges_read): Update.
3412         * dwarf-index-write.c (write_address_map)
3413         (write_one_signatured_type, recursively_write_psymbols)
3414         (class debug_names, class debug_names, write_psymtabs_to_index):
3415         Update.
3416
3417 2019-01-10  Tom Tromey  <tom@tromey.com>
3418
3419         * symtab.h (SYMBOL_SET_NAMES): Update.
3420         (symbol_set_names): Update.
3421         (MSYMBOL_SET_NAMES): Update.
3422         * symtab.c (symbol_set_names): Change argument to be an
3423         objfile_per_bfd_storage.
3424         * psymtab.c (add_psymbol_to_bcache): Update.
3425         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
3426
3427 2019-01-10  Tom Tromey  <tom@tromey.com>
3428
3429         * symtab.c (create_demangled_names_hash): Change argument to be an
3430         objfile_per_bfd_storage.
3431         (symbol_set_names): Update.
3432
3433 2019-01-10  Tom Tromey  <tom@tromey.com>
3434
3435         * xcoffread.c (xcoff_initial_scan): Unconditionally call
3436         init_psymbol_list.
3437         * psymtab.c (init_psymbol_list): Do nothing if already called.
3438         * psympriv.h (init_psymbol_list): Add comment.
3439         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
3440         init_psymbol_list.
3441         * dbxread.c (dbx_symfile_read): Unconditionally call
3442         init_psymbol_list.
3443
3444 2019-01-10  Tom Tromey  <tom@tromey.com>
3445
3446         * xcoffread.c (scan_xcoff_symtab): Update.
3447         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
3448         "where".
3449         * mdebugread.c (parse_partial_symbols)
3450         (handle_psymbol_enumerators): Update.
3451         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
3452         * dbxread.c (read_dbx_symtab): Update.
3453         * psympriv.h (psymbol_placement): New enum.
3454         (add_psymbol_to_list): Update.
3455
3456 2019-01-10  Tom Tromey  <tom@tromey.com>
3457
3458         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
3459         static_psymbols parameters.
3460         (scan_xcoff_symtab): Update.
3461         * psymtab.c (start_psymtab_common): Remove global_psymbols and
3462         static_psymbols parameters.
3463         * psympriv.h (start_psymtab_common): Update.
3464         * mdebugread.c (parse_partial_symbols): Update.
3465         * dwarf2read.c (create_partial_symtab): Update.
3466         * dbxread.c (read_dbx_symtab): Update.
3467         (start_psymtab): Remove global_psymbols and static_psymbols
3468         parameters.
3469
3470 2019-01-10  Tom Tromey  <tom@tromey.com>
3471
3472         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
3473         * psymtab.c (allocate_psymtab): Add comment.
3474         * psympriv.h (allocate_psymtab): Add comment.
3475         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
3476         initializations.
3477         * dbxread.c (dbx_end_psymtab): Remove some initializations.
3478
3479 2019-01-10  Tom Tromey  <tom@tromey.com>
3480
3481         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3482         Don't declare.
3483         * mipsread.c: Include mdebugread.h.
3484         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3485         Declare.
3486         * elfread.c: Include mdebugread.h.
3487
3488 2019-01-09  Tom Tromey  <tom@tromey.com>
3489
3490         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
3491         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
3492         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
3493         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
3494         (psym_lookup_symbol, psym_find_last_source_symtab)
3495         (psym_forget_cached_source_info, psym_print_stats)
3496         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
3497         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
3498         (psym_map_matching_symbols, psym_expand_symtabs_matching)
3499         (psym_find_compunit_symtab_by_address)
3500         (maintenance_print_psymbols, maintenance_info_psymtabs)
3501         (maintenance_check_psymtabs): Use ranged for.
3502         * psymtab.h (class objfile_psymtabs): New.
3503         (require_partial_symbols): Return objfile_psymtabs.
3504         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
3505
3506 2019-01-09  Tom Tromey  <tom@tromey.com>
3507
3508         * symfile.c (overlay_invalidate_all, find_pc_overlay)
3509         (find_pc_mapped_section, list_overlays_command)
3510         (map_overlay_command, unmap_overlay_command)
3511         (simple_overlay_update): Use all_objfiles.
3512         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
3513         * printcmd.c (info_symbol_command): Use all_objfiles.
3514         * objfiles.h (ALL_OBJSECTIONS): Remove.
3515         * maint.c (maintenance_translate_address): Use all_objfiles.
3516         * gcore.c (gcore_create_callback): Use all_objfiles.
3517         (objfile_find_memory_regions): Likewise.
3518
3519 2019-01-09  Tom Tromey  <tom@tromey.com>
3520
3521         * symtab.c (find_line_symtab, info_sources_command)
3522         (make_source_files_completion_list): Use objfile_compunits.
3523         * source.c (select_source_symtab): Use objfile_compunits.
3524         * objfiles.h (struct objfile): Update comment.
3525         (ALL_OBJFILES): Remove.
3526         (ALL_FILETABS): Remove.
3527         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
3528         objfile_compunits.
3529
3530 2019-01-09  Tom Tromey  <tom@tromey.com>
3531
3532         * symmisc.c (print_objfile_statistics, dump_objfile)
3533         (maintenance_print_symbols): Use compunit_filetabs.
3534         * source.c (forget_cached_source_info_for_objfile): Use
3535         compunit_filetabs.
3536         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
3537         (ALL_FILETABS): Use compunit_filetabs.
3538         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
3539         * coffread.c (coff_symtab_read): Use compunit_filetabs.
3540
3541 2019-01-09  Tom Tromey  <tom@tromey.com>
3542
3543         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
3544         (compunit_filetabs): New.
3545         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
3546         compunit_filetabs.
3547         (info_sources_command, make_source_files_completion_list): Remove
3548         declaration.
3549         * symmisc.c (print_objfile_statistics, dump_objfile)
3550         (maintenance_print_symbols): Remove declaration.
3551         (maintenance_info_symtabs): Use compunit_filetabs.
3552         (maintenance_info_line_tables): Likewise.
3553         * source.c (select_source_symtab): Change local variable name.
3554         (forget_cached_source_info_for_objfile): Remove declaration.
3555         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
3556         * objfiles.c (objfile_relocate1): Remove declaration.
3557         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3558         declaration.
3559         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
3560         * coffread.c (coff_symtab_read): Remove declaration.
3561         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3562         compunit_filetabs.
3563
3564 2019-01-09  Tom Tromey  <tom@tromey.com>
3565
3566         * symtab.c (lookup_objfile_from_block)
3567         (find_pc_sect_compunit_symtab, search_symbols)
3568         (default_collect_symbol_completion_matches_break_on): Use
3569         objfile_compunits.
3570         * objfiles.h (ALL_COMPUNITS): Remove.
3571         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
3572         * cp-support.c (add_symbol_overload_list_qualified): Use
3573         objfile_compunits.
3574         * ada-lang.c (ada_collect_symbol_completion_matches)
3575         (ada_add_global_exceptions): Use objfile_compunits.
3576
3577 2019-01-09  Tom Tromey  <tom@tromey.com>
3578
3579         * source.c (select_source_symtab)
3580         (forget_cached_source_info_for_objfile): Remove declaration.
3581         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3582         declaration.
3583         * maint.c (count_symtabs_and_blocks): Remove declaration.
3584         * cp-support.c (add_symbol_overload_list_qualified): Remove
3585         declaration.
3586         * coffread.c (coff_symtab_read): Remove declaration.
3587         * symtab.c (lookup_symbol_in_objfile_symtabs)
3588         (basic_lookup_transparent_type_1): Use objfile_compunits.
3589         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
3590         (info_sources_command, search_symbols)
3591         (default_collect_symbol_completion_matches_break_on)
3592         (make_source_files_completion_list): Remove declaration.
3593         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
3594         (ada_collect_symbol_completion_matches)
3595         (ada_add_global_exceptions): Remove declaration.
3596         * linespec.c (iterate_over_all_matching_symtabs): Use
3597         objfile_compunits.
3598         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
3599         (class objfile_compunits): New.
3600         (ALL_COMPUNITS): Use objfile_compunits.
3601         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
3602         (maintenance_check_symtabs, maintenance_info_line_tables): Use
3603         objfile_compunits.
3604         * objfiles.c (objfile_relocate1): Use objfile_compunits.
3605
3606 2019-01-09  Tom Tromey  <tom@tromey.com>
3607
3608         * symtab.c (search_symbols)
3609         (default_collect_symbol_completion_matches_break_on): Use
3610         objfile_msymbols.
3611         * ada-lang.c (ada_lookup_simple_minsym)
3612         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
3613         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
3614         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
3615         objfile_msymbols.
3616         * coffread.c (coff_symfile_read): Use objfile_msymbols.
3617         * symmisc.c (dump_msymbols): Use objfile_msymbols.
3618         * objc-lang.c (find_methods): Use objfile_msymbols.
3619         (info_selectors_command, info_classes_command): Likewise.
3620         * stabsread.c (scan_file_globals): Use objfile_msymbols.
3621         * objfiles.h (class objfile_msymbols): New.
3622         (ALL_OBJFILE_MSYMBOLS): Remove.
3623         (ALL_MSYMBOLS): Remove.
3624
3625 2019-01-09  Tom Tromey  <tom@tromey.com>
3626
3627         * common/next-iterator.h (next_adapter): Add Iterator template
3628         parameter.
3629         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
3630         (class all_objfiles_safe): New.
3631         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
3632         * objfiles.c (put_objfile_before): Update comment.
3633         (add_separate_debug_objfile): Likewise.
3634         (free_all_objfiles): Use all_objfiles_safe.
3635         (objfile_purge_solibs): Likewise.
3636
3637 2019-01-09  Tom Tromey  <tom@tromey.com>
3638
3639         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3640         (expand_symtab_containing_pc, lookup_static_symbol)
3641         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
3642         (find_symbol_at_address, find_line_symtab, find_main_name): Use
3643         all_objfiles.
3644         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
3645         * breakpoint.c (create_overlay_event_breakpoint)
3646         (create_longjmp_master_breakpoint)
3647         (create_std_terminate_master_breakpoint)
3648         (create_exception_master_breakpoint): Use all_objfiles.
3649         * linux-thread-db.c (try_thread_db_load_from_pdir)
3650         (has_libpthread): Use all_objfiles.
3651         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
3652         * linespec.c (iterate_over_all_matching_symtabs)
3653         (search_minsyms_for_name): Use all_objfiles.
3654         * maint.c (maintenance_info_sections): Use all_objfiles.
3655         * main.c (captured_main_1): Use all_objfiles.
3656         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
3657         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
3658         * guile/scm-pretty-print.c
3659         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
3660         * solib-spu.c (append_ocl_sos): Use all_objfiles.
3661         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
3662         (maintenance_print_msymbols): Use all_objfiles.
3663         * source.c (select_source_symtab): Use all_objfiles.
3664         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
3665         * symfile.c (remove_symbol_file_command)
3666         (expand_symtabs_matching, map_symbol_filenames): Use
3667         all_objfiles.
3668         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
3669         all_objfiles.
3670         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
3671         * objc-lang.c (find_methods): Use all_objfiles.
3672         * objfiles.c (have_partial_symbols, have_full_symbols)
3673         (have_minimal_symbols, qsort_cmp)
3674         (default_iterate_over_objfiles_in_search_order): Use
3675         all_objfiles.
3676         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
3677         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
3678         (maintenance_check_psymtabs): Use all_objfiles.
3679         (ALL_PSYMTABS): Remove.
3680         * compile/compile-object-run.c (do_module_cleanup): Use
3681         all_objfiles.
3682         * blockframe.c (find_pc_partial_function): Use all_objfiles.
3683         * cp-support.c (add_symbol_overload_list_qualified): Use
3684         all_objfiles.
3685         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3686         Use all_objfiles.
3687         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
3688         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
3689         all_objfiles.
3690         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3691         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
3692         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3693         Uses all_objfiles.
3694         * solib.c (solib_read_symbols): Use all_objfiles
3695
3696 2019-01-09  Tom Tromey  <tom@tromey.com>
3697
3698         * probe.c (parse_probes_in_pspace): Use all_objfiles.
3699         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
3700         all_objfiles.
3701         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
3702         * symmisc.c (print_symbol_bcache_statistics)
3703         (print_objfile_statistics, maintenance_print_objfiles)
3704         (maintenance_info_symtabs, maintenance_check_symtabs)
3705         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
3706         all_objfiles.
3707         * source.c (forget_cached_source_info): Use all_objfiles.
3708         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
3709         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3710         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
3711         * objfiles.c (update_section_map): Use all_objfiles.
3712         (shared_objfile_contains_address_p): Likewise.
3713         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
3714         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
3715
3716 2019-01-09  Tom Tromey  <tom@tromey.com>
3717
3718         * common/next-iterator.h: New file.
3719         * objfiles.h (class all_objfiles): New.
3720         (struct objfile_iterator): New.
3721
3722 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3723
3724         * NEWS: Move the description of the changed "frame", "select-frame",
3725          and "info frame" commands to the Changed commands section.
3726
3727 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
3728
3729         * gdbtypes.c (check_stub_method_group): Remove handling of old
3730         mangling schemes.
3731         * linespec.c (find_methods): Likewise.
3732         * stabsread.c (read_member_functions): Likewise.
3733         * valops.c (search_struct_method): Likewise.
3734         (value_struct_elt_for_reference): Likewise.
3735         * NEWS: Mention this change.
3736
3737 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3738
3739         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
3740         print_source_lines.
3741         * source.c (print_source_lines_base): Update line number check.
3742         (print_source_lines): New function.
3743         (source_lines_range::source_lines_range): New function.
3744         * source.h (class source_lines_range): New class.
3745         (print_source_lines): New declaration.
3746
3747 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3748
3749         * linespec.c (linespec_state_destructor): Free self->canonical_names.
3750
3751 2019-01-08  Tom Tromey  <tom@tromey.com>
3752             Simon Marchi  <simon.marchi@ericsson.com>
3753
3754         PR gdb/24060
3755         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
3756         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
3757         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3758         * f-exp.y (DOLLAR_VARIABLE): Likewise.
3759         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
3760         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3761
3762 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3763
3764         * source.c (select_source_symtab): Move header comment to
3765         declaration in source.h.
3766         (forget_cached_source_info_for_objfile): Likewise.
3767         (forget_cached_source_info): Likewise.
3768         (identify_source_line): Likewise.
3769         * source.h (identify_source_line): Move declaration from symtab.h
3770         and add comment from source.c
3771         (print_source_lines): Likewise.
3772         (forget_cached_source_info_for_objfile): Likewise.
3773         (forget_cached_source_info): Likewise.
3774         (select_source_symtab): Likewise.
3775         (enum print_source_lines_flag): Move definition from symtab.h.
3776         * symtab.h (identify_source_line): Move declaration to source.h.
3777         (print_source_lines): Likewise.
3778         (forget_cached_source_info_for_objfile): Likewise.
3779         (forget_cached_source_info): Likewise.
3780         (select_source_symtab): Likewise.
3781         (enum print_source_lines_flag): Move definition to source.h.
3782         * tui/tui-hooks.c: Add 'source.h' include.
3783
3784 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3785
3786         * source.c (print_source_lines_base): Handle requests to print
3787         reverse line number sequences, and guard against empty lines
3788         string.
3789
3790 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3791
3792         * source.c (print_source_lines_base): Fix skip of '\r' if next
3793         character is '\n'.
3794
3795 2019-01-06  Tom Tromey  <tom@tromey.com>
3796
3797         * c-exp.y (struct c_parse_state) <macro_original_text,
3798         expansion_obstack>: New member.
3799         (macro_original_text, expansion_obstack): Remove globals.
3800         (scan_macro_expansion, scanning_macro_expansion)
3801         (finished_macro_expansion): Update.
3802         (scan_macro_cleanup): Remove.
3803         (yylex, c_parse): Update.
3804
3805 2019-01-06  Tom Tromey  <tom@tromey.com>
3806
3807         * c-exp.y (struct c_parse_state) <strings>: New member.
3808         (operator_stoken): Update.
3809
3810 2019-01-06  Tom Tromey  <tom@tromey.com>
3811
3812         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
3813         (union type_stack_elt) <typelist_val>: Now a pointer to
3814         std::vector.
3815         (type_stack_cleanup): Don't declare.
3816         (push_typelist): Update.
3817         * parse.c (pop_typelist): Return a std::vector.
3818         (push_typelist): Take a std::vector.
3819         (follow_types): Update.  Do not free args.
3820         (type_stack_cleanup): Remove.
3821         * c-exp.y (struct c_parse_state): New.
3822         (cpstate): New global.
3823         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
3824         (nonempty_typelist): Update.
3825         (func_mod): Create a new vector.
3826         (c_parse): Create a c_parse_state.
3827         (check_parameter_typelist): Do not delete params.
3828         (function_method): Update.  Do not delete type_list.
3829
3830 2019-01-06  Tom Tromey  <tom@tromey.com>
3831
3832         PR gdb/28155:
3833         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
3834         check_typedef.
3835         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
3836         (print_return_value): Likewise.
3837
3838 2019-01-05  Tom Tromey  <tom@tromey.com>
3839
3840         * contrib/cleanup_check.py: Remove.
3841         * contrib/gcc-with-excheck: Remove.
3842         * contrib/exsummary.py: Remove.
3843         * contrib/excheck.py: Remove.
3844
3845 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
3846
3847         * thread.c (delete_thread_1): Add gdb_assert that THR is not
3848         NULL. Initialize tpprev to NULL instead of assigning it
3849         to NULL on the next statement.
3850         * windows-nat.c (windows_delete_thread): Remove check for
3851         main_thread_id before printing thread exit notifications.
3852         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
3853         Remove thread ID check against main_thread_id.
3854         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
3855         windows_delete_thread.
3856         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
3857
3858 2019-01-04  Tom Tromey  <tom@tromey.com>
3859
3860         * compile/compile.c (_initialize_compile): Use upper case for
3861         metasyntactic variables.
3862         * symmisc.c (_initialize_symmisc): Use upper case for
3863         metasyntactic variables.
3864         * psymtab.c (_initialize_psymtab): Use upper case for
3865         metasyntactic variables.
3866         * demangle.c (demangle_command): Use upper case for metasyntactic
3867         variables.
3868         (_initialize_demangler): Likewise.
3869         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
3870         variables.
3871
3872 2019-01-03  Tom Tromey  <tom@tromey.com>
3873
3874         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
3875
3876 2019-01-03  Tom Tromey  <tom@tromey.com>
3877
3878         * python/py-symtab.c (salpy_str): Update.
3879         (struct salpy_sal_object) <symtab>: Now a PyObject.
3880         (salpy_dealloc): Update.
3881         (del_objfile_sal): Use gdbpy_ref.
3882
3883 2019-01-03  Tom Tromey  <tom@tromey.com>
3884
3885         * python/py-type.c (convert_field): Use new_reference.  Return
3886         gdbpy_ref.
3887         (make_fielditem): Return gdbpy_ref.
3888         (typy_fields): Update.
3889         (typy_getitem): Update.
3890         (field_name): Return gdbpy_ref.  Use new_reference.
3891         (typy_iterator_iternext): Update.
3892
3893 2019-01-03  Tom Tromey  <tom@tromey.com>
3894
3895         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
3896
3897 2019-01-03  Tom Tromey  <tom@tromey.com>
3898
3899         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
3900         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
3901         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
3902         (pspy_set_frame_filters, pspy_set_frame_unwinders)
3903         (pspy_set_type_printers): Likewise.
3904         * python/py-function.c (fnpy_init): Use gdbpy_ref.
3905         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
3906         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
3907         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
3908         (objfpy_set_type_printers): Likewise.
3909
3910 2019-01-03  Tom Tromey  <tom@tromey.com>
3911
3912         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
3913         (gdbpy_print_stack): Use gdbpy_err_fetch.
3914         * python/python-internal.h (class gdbpy_err_fetch): New class.
3915         (class gdbpy_enter) <m_error_type, m_error_value,
3916         m_error_traceback>: Remove.
3917         <m_error>: New member.
3918         (gdbpy_exception_to_string): Don't declare.
3919         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
3920         * python/py-value.c (convert_value_from_python): Use
3921         gdbpy_err_fetch.
3922         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
3923         gdbpy_exception_to_string.
3924         (gdbpy_handle_exception): Use gdbpy_err_fetch.
3925         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3926         gdbpy_err_fetch.
3927
3928 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3929
3930         * linux-nat.c (delete_lwp_cleanup): Delete.
3931         (struct lwp_deleter): New struct.
3932         (lwp_info_up): New typedef.
3933         (linux_nat_target::follow_fork): Delete cleanup, and make use of
3934         lwp_info_up.
3935
3936 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3937
3938         * linux-fork.c (class scoped_switch_fork_info): New class.
3939         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
3940
3941 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3942
3943         * valops.c (find_overload_match): Remove use of null_cleanup, and
3944         calls to do_cleanups.
3945
3946 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3947
3948         * compile/compile-cplus-types.c
3949         (compile_cplus_instance::decl_name): Handle changes to
3950         cp_func_name.
3951         * cp-support.c (cp_func_name): Update header comment, update
3952         return type.
3953         * cp-support.h (cp_func_name): Update return type in declaration.
3954         * valops.c (find_overload_match): Move temp_func local to top
3955         level of function and change its type.  Use temp_func to hold and
3956         delete temporary string obtained from cp_func_name.
3957
3958 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3959
3960         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
3961         gdb::char_vector, remove cleanup, and update uses of `msg`.
3962
3963 2019-01-03  Jim Wilson  <jimw@sifive.com>
3964
3965         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
3966
3967 2019-01-02  Tom Tromey  <tom@tromey.com>
3968
3969         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
3970         (tdesc_parse_xml): Remove cleanups.
3971         * target-descriptions.h (make_cleanup_free_target_description):
3972         Don't declare.
3973         (target_desc_deleter): New struct.
3974         (target_desc_up): New typedef.
3975         * target-descriptions.c (target_desc_deleter::operator()): Rename
3976         from free_target_description.
3977         (make_cleanup_free_target_description): Remove.
3978
3979 2019-01-02  Tom Tromey  <tom@tromey.com>
3980
3981         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
3982         constructor, destructor.
3983         (linespec_parser): Remove typedef.
3984         (~linespec_parser): Rename from linespec_parser_delete.
3985         (linespec_lex_to_end, linespec_complete_label)
3986         (linespec_complete): Update.
3987         (decode_line_full): Remove cleanups.
3988         (decode_line_1): Update.
3989
3990 2019-01-02  Tom Tromey  <tom@tromey.com>
3991
3992         * python/python-internal.h (inferior_to_inferior_object): Change
3993         return type.
3994         * python/py-exitedevent.c (create_exited_event_object): Update.
3995         * python/py-inferior.c (inferior_to_inferior_object): Return
3996         gdbpy_ref.
3997         (python_new_inferior, python_inferior_deleted)
3998         (thread_to_thread_object, delete_thread_object)
3999         (build_inferior_list, gdbpy_selected_inferior): Update.
4000         * python/py-infthread.c (create_thread_object): Update.  Also fail
4001         if inferior_to_inferior_object fails.
4002
4003 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
4004
4005         * inferior.h (class inferior) <displaced_step_state>: New field.
4006         * infrun.h (struct displaced_step_state): Move here from
4007         infrun.c.  Initialize fields, add constructor.
4008         <inf>: Remove field.
4009         <reset>: New method.
4010         * infrun.c (struct displaced_step_inferior_state): Move to
4011         infrun.h.
4012         (displaced_step_inferior_states): Remove.
4013         (get_displaced_stepping_state): Adust.
4014         (displaced_step_in_progress_any_inferior): Adjust.
4015         (displaced_step_in_progress_thread): Adjust.
4016         (displaced_step_in_progress): Adjust.
4017         (add_displaced_stepping_state): Remove.
4018         (get_displaced_step_closure_by_addr): Adjust.
4019         (remove_displaced_stepping_state): Remove.
4020         (infrun_inferior_exit): Call displaced_step_state.reset.
4021         (use_displaced_stepping): Don't check for NULL.
4022         (displaced_step_prepare_throw): Call
4023         get_displaced_stepping_state.
4024         (displaced_step_fixup): Don't check for NULL.
4025         (prepare_for_detach): Don't check for NULL.
4026
4027 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4028
4029         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
4030          in case of call that did not complete.
4031
4032 2019-01-02  Andrey Utkin  <autkin@undo.io>
4033
4034         * symfile.c (find_separate_debug_file): Fix search of debug files for
4035         remote debuggee.
4036
4037 2019-01-02  Tom Tromey  <tom@tromey.com>
4038
4039         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
4040         indentation.
4041         * python/py-frame.c (frapy_older): Remove cast.
4042         (frapy_newer): Likewise.
4043         * python/py-breakpoint.c (local_setattro): Remove cast.
4044         * python/py-arch.c (archpy_name): Remove local variable.
4045         * python/py-type.c (gdbpy_lookup_type): Remove cast.
4046
4047 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
4048
4049         * unittests/basic_string_view/element_access/char/empty.cc:
4050         Fix year range in copyright header.
4051
4052 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4053
4054         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
4055         Delete.
4056         <operator==>: Update with for removed field.
4057         <hash>: Likewise.
4058         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
4059         <isa_features>: ...this.
4060         <abi_features>: New field.
4061         (riscv_isa_flen): Update comment.
4062         (riscv_abi_xlen): New declaration.
4063         (riscv_abi_flen): New declaration.
4064         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
4065         isa_features.
4066         (riscv_abi_xlen): New function.
4067         (riscv_isa_flen): Update to get answer from isa_features.
4068         (riscv_abi_flen): New function.
4069         (riscv_has_fp_abi): Update to get answer from abi_features.
4070         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
4071         xlen and flen.
4072         (riscv_call_info) <xlen, flen>: Update comment.
4073         (riscv_call_arg_struct): Remove invalid assertions
4074         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
4075         is removed.
4076         (riscv_gdbarch_init): Gather isa features and abi features
4077         separately, ensure both match on the gdbarch when reusing an old
4078         gdbarch.  Relax an error check to allow 32-bit abi float to run on
4079         a target with 64-bit float hardware.
4080
4081 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4082
4083         * source.c (search_command_helper): Stop reverse search
4084         when line 1 has been searched.
4085
4086 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4087
4088         * record-full.c (record_full_base_target::close): Rewrite
4089         record_full_core_buf_list free logic.
4090
4091 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4092
4093         * break-catch-syscall.c (print_one_catch_syscall): xfree
4094         the last text.
4095
4096 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
4097
4098         * top.c (print_gdb_version): Update Copyright year in version
4099         message.
4100
4101 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
4102
4103         Update copyright year range in all GDB files.
4104
4105 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
4106
4107         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
4108
4109 For older changes see ChangeLog-2018.
4110 \f
4111 Local Variables:
4112 mode: change-log
4113 left-margin: 8
4114 fill-column: 74
4115 version-control: never
4116 coding: utf-8
4117 End:
4118