gdb/ChangeLog

   1 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
   2
   3         * gcore.in: Add '--readnever' option when invoking GDB.
   4
   5 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
   6
   7         * MAINTAINERS: Update my email address.
   8
   9 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
  10
  11         * build-id.c (build_id_to_debug_bfd_1): New function.
  12         (build_id_to_debug_bfd): Look for separate debug file in
  13         sysroot.
  14
  15 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
  16
  17         * gdbarch.sh: Update the copyright year range that is placed into
  18         generated files.
  19
  20 2019-02-22  Keith Seitz  <keiths@redhat.com>
  21
  22         PR symtab/23853
  23         * linespec.c (create_sals_line_offset): Search for the default
  24         symtab's filename instead of its fullname.
  25
  26 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
  27
  28         * NEWS: Update style defaults.
  29
  30 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
  31
  32         * main.c (captured_main_1): Disable styling in batch mode.
  33
  34 2019-02-20  Tom Tromey  <tom@tromey.com>
  35
  36         * symtab.c (symtab_symbol_info): Fix typos.
  37
  38 2019-02-20  Tom Tromey  <tromey@adacore.com>
  39
  40         * findcmd.c (_initialize_mem_search): Use upper case for
  41         metasyntactic variables.
  42
  43 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
  44
  45         * aarch64-tdep.c (aarch64_add_reggroups): New function.
  46         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
  47
  48 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
  49
  50         * top.h (source_file_name): Change to std::string.
  51         * top.c (source_file_name): Likewise.
  52         (command_line_input): Adjust.
  53         * cli/cli-script.c (script_from_file): Adjust.
  54
  55 2019-02-19  Tom Tromey  <tromey@adacore.com>
  56
  57         * ravenscar-thread.c
  58         (ravenscar_thread_target::update_thread_list): Don't call
  59         ada_build_task_list.
  60         * ada-lang.h (ada_build_task_list): Don't declare.
  61         * ada-tasks.c (struct ada_tasks_inferior_data)
  62         <task_list_valid_p>: Now bool.
  63         (read_known_tasks, ada_task_list_changed)
  64         (ada_tasks_invalidate_inferior_data): Update.
  65         (read_known_tasks_array): Return bool.
  66         (read_known_tasks_list): Likewise.
  67         (read_known_tasks): Return void.
  68         (ada_build_task_list): Now static.
  69
  70 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
  71
  72         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
  73         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
  74
  75 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  76
  77         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
  78         variant for ada_tasks_pspace_data_handle and
  79         ada_tasks_inferior_data_handle.
  80         (ada_tasks_pspace_data_cleanup): New function.
  81         (ada_tasks_inferior_data_cleanup): New function.
  82
  83 2019-02-17  Tom Tromey  <tom@tromey.com>
  84
  85         * macrotab.h (macro_source_fullname): Return a std::string.
  86         * macrotab.c (macro_include, check_for_redefinition)
  87         (macro_undef, macro_lookup_definition, foreach_macro)
  88         (foreach_macro_in_scope): Update.
  89         (macro_source_fullname): Return a std::string.
  90         * macrocmd.c (show_pp_source_pos): Update.
  91
  92 2019-02-17  Tom Tromey  <tom@tromey.com>
  93
  94         * macrocmd.c (show_pp_source_pos): Style the file names.
  95
  96 2019-02-17  Tom Tromey  <tom@tromey.com>
  97
  98         PR tui/24197:
  99         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
 100
 101 2019-02-17  Tom Tromey  <tom@tromey.com>
 102
 103         * ada-lang.c (user_select_syms): Use filtered printing.
 104         * utils.c (wrap_style): New global.
 105         (desired_style): Remove.
 106         (emit_style_escape): Add stream parameter.
 107         (set_output_style, reset_terminal_style, prompt_for_continue):
 108         Update.
 109         (flush_wrap_buffer): Only flush gdb_stdout.
 110         (wrap_here): Set wrap_style.
 111         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
 112         treat escape sequences as a character.  Change when wrap buffer is
 113         flushed.
 114         (fputs_styled): Do not set the output style when the default is
 115         requested.
 116         * ui-style.h (struct ui_file_style) <is_default>: New method.
 117         * source.c (print_source_lines_base): Emit escape sequences in one
 118         piece.
 119
 120 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 121
 122         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
 123         integers and enumeration types.
 124
 125 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 126
 127         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
 128         instead of lookup_symbol_in_language
 129         (do_exact_match): New function.
 130         (ada_get_symbol_name_matcher): Return do_exact_match when
 131         doing a verbatim match.
 132
 133 2019-02-15  Tom Tromey  <tromey@adacore.com>
 134
 135         * ravenscar-thread.c (ravenscar_thread_target::resume)
 136         (ravenscar_thread_target::wait): Special case wildcard requests.
 137
 138 2019-02-15  Tom Tromey  <tromey@adacore.com>
 139
 140         * ravenscar-thread.c (base_ptid): Remove.
 141         (struct ravenscar_thread_target) <close>: New method.
 142         <m_base_ptid>: New member.
 143         <update_inferior_ptid, active_task, task_is_currently_active,
 144         runtime_initialized>: Declare methods.
 145         <ravenscar_thread_target>: Add constructor.
 146         (ravenscar_thread_target::task_is_currently_active)
 147         (ravenscar_thread_target::update_inferior_ptid)
 148         (ravenscar_runtime_initialized): Rename.  Now methods.
 149         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
 150         (ravenscar_thread_target::update_thread_list): Update.
 151         (ravenscar_thread_target::active_task): Now method.
 152         (ravenscar_thread_target::store_registers)
 153         (ravenscar_thread_target::prepare_to_store)
 154         (ravenscar_thread_target::prepare_to_store)
 155         (ravenscar_thread_target::mourn_inferior): Update.
 156         (ravenscar_inferior_created): Use "new" to create target.
 157         (ravenscar_thread_target::get_ada_task_ptid): Update.
 158         (_initialize_ravenscar): Don't initialize base_ptid.
 159         (ravenscar_ops): Remove global.
 160
 161 2019-02-15  Tom Tromey  <tromey@adacore.com>
 162
 163         * target.h (push_target): Declare new overload.
 164         * target.c (push_target): New overload, taking an rvalue reference.
 165         * remote.c (remote_target::open_1): Use push_target overload.
 166         * corelow.c (core_target_open): Use push_target overload.
 167
 168 2019-02-15  Tom Tromey  <tromey@adacore.com>
 169
 170         * ravenscar-thread.c (is_ravenscar_task)
 171         (ravenscar_task_is_currently_active): Return bool.
 172         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
 173         (_initialize_ravenscar): Remove "(void)".
 174         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
 175         Return bool.
 176
 177 2019-02-15  Tom Tromey  <tromey@adacore.com>
 178
 179         * ravenscar-thread.c (ravenscar_runtime_initializer)
 180         (has_ravenscar_runtime, get_running_thread_id)
 181         (ravenscar_thread_target::resume): Fix indentation.
 182
 183 2019-02-15  Tom Tromey  <tromey@adacore.com>
 184
 185         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
 186         from ravenscar_arch_ops.
 187         (sparc_ravenscar_ops::fetch_registers)
 188         (sparc_ravenscar_ops::store_registers): Now methods.
 189         (sparc_ravenscar_prepare_to_store): Remove.
 190         (sparc_ravenscar_ops): Redefine.
 191         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
 192         methods and destructor.  Remove members.
 193         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
 194         (ravenscar_thread_target::store_registers)
 195         (ravenscar_thread_target::prepare_to_store): Update.
 196         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
 197         Remove.
 198         (struct ppc_ravenscar_powerpc_ops): Derive from
 199         ravenscar_arch_ops.
 200         (ppc_ravenscar_powerpc_ops::fetch_registers)
 201         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
 202         (ppc_ravenscar_powerpc_ops): Redefine.
 203         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
 204         (ppc_ravenscar_e500_ops::fetch_registers)
 205         (ppc_ravenscar_e500_ops::store_registers): Now methods.
 206         (ppc_ravenscar_e500_ops): Redefine.
 207         * aarch64-ravenscar-thread.c
 208         (aarch64_ravenscar_generic_prepare_to_store): Remove.
 209         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
 210         (aarch64_ravenscar_fetch_registers)
 211         (aarch64_ravenscar_store_registers): Now methods.
 212         (aarch64_ravenscar_ops): Redefine.
 213
 214 2019-02-15  Tom Tromey  <tromey@adacore.com>
 215
 216         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
 217         (ravenscar_thread_target::stopped_by_hw_breakpoint)
 218         (ravenscar_thread_target::stopped_by_watchpoint)
 219         (ravenscar_thread_target::stopped_data_address)
 220         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
 221
 222 2019-02-15  Tom Tromey  <tromey@adacore.com>
 223
 224         * ravenscar-thread.c: Fix some typos.
 225
 226 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 227             Tom Tromey  <tromey@adacore.com>
 228
 229         * ada-lang.c (ada_exception_sal): Change addr_string to a
 230         std::string.
 231         (create_ada_exception_catchpoint): Update.
 232
 233 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 234             Tom Tromey  <tromey@adacore.com>
 235
 236         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
 237         (bp_location_ops): Remove.
 238         (base_breakpoint_allocate_location): Update.
 239         (free_bp_location): Update.
 240         * ada-lang.c (class ada_catchpoint_location)
 241         <ada_catchpoint_location>: Remove ops parameter.
 242         (ada_catchpoint_location_dtor): Remove.
 243         (ada_catchpoint_location_ops): Remove.
 244         (allocate_location_exception): Update.
 245         * breakpoint.h (struct bp_location_ops): Remove.
 246         (class bp_location) <bp_location>: Remove bp_location_ops
 247         parameter.
 248         <~bp_location>: Add destructor.
 249         <ops>: Remove.
 250
 251 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 252             Pedro Alves  <palves@redhat.com>
 253
 254         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
 255         'PATH_MAX'.
 256
 257 2019-02-14  David Michael  <fedora.dm0@gmail.com>
 258             Samuel Thibault  <samuel.thibault@gnu.org>
 259             Thomas Schwinge  <thomas@codesourcery.com>
 260
 261         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
 262         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
 263
 264 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 265
 266         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
 267         (check_empty): Use "const char *".
 268
 269         * gnu-nat.c (gnu_nat_target::detach): Instead of
 270         'detach_inferior (pid)' call
 271         'detach_inferior (find_inferior_pid (pid))'.
 272
 273         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
 274         'nat/fork-inferior.o'.
 275         * gnu-nat.c: #include "nat/fork-inferior.h".
 276
 277         * gnu-nat.c (gnu_nat_target::detach): Instead of
 278         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
 279         * gnu-nat.h: #include "inf-child.h".
 280         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
 281         'i386_gnu_nat_target::fetch_registers'.
 282         (gnu_store_registers): Rename/move to
 283         'i386_gnu_nat_target::store_registers'.
 284
 285         * config/i386/nm-i386gnu.h: Don't "#include" any files.
 286         * gnu-nat.h (mach_thread_info): New function.
 287         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
 288
 289         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
 290
 291 2019-02-14  Frederic Konrad  <konrad@adacore.com>
 292
 293         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
 294
 295 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
 296
 297         * windows-nat.c (windows_add_thread): Add new parameter
 298         "main_thread_p" with default value set to false.  Update
 299         function documentation as well as all callers.
 300         (windows_delete_thread): Likewise.
 301         (fake_create_process): Update call to windows_add_thread.
 302         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
 303         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
 304         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
 305         call to windows_delete_thread.
 306
 307 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
 308
 309         * MAINTAINERS: Add Andrew Burgess as global maintainer.
 310
 311 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 312
 313         * symfile.c (find_separate_debug_file): Use canonical path of
 314         sysroot with child_path instead of gdb_sysroot if it is valid.
 315
 316 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 317
 318         * symfile.c (find_separate_debug_file): Use child_path to
 319         determine if an object file is under a sysroot.
 320
 321 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 322
 323         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 324         unittests/child-path-selftests.c.
 325         * common/pathstuff.c (child_path): New function.
 326         * common/pathstuff.h (child_path): New prototype.
 327         * unittests/child-path-selftests.c: New file.
 328
 329 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 330
 331         * symfile.c (find_separate_debug_file): Look for separate debug
 332         files in debug directories under the sysroot.
 333
 334 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 335
 336         * symtab.h (struct minimal_symbol data_p): New const method.
 337         (struct minimal_symbol text_p): Likewise.
 338         * symtab.c (output_source_filename): Use file name style
 339         to print file name.
 340         (print_symbol_info): Likewise.
 341         (print_msymbol_info): Use address style to print addresses.
 342         Use function name style to print executable text symbols.
 343         (expand_symtab_containing_pc): Use data_p.
 344         (find_pc_sect_compunit_symtab): Likewise.
 345
 346 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 347
 348         * breakpoint.c (describe_other_breakpoints): Use address style
 349         to print addresses.
 350         (say_where): Likewise.
 351
 352 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 353
 354         * ada-typeprint.c (print_func_type): Print function name
 355         style to print function name.
 356         * c-typeprint.c (c_print_type_1): Likewise.
 357
 358 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
 359
 360         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
 361         for execve.
 362
 363 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 364
 365         * c-exp.y (direct_abs_decl): Use emplace_back to record the
 366         type_stack.
 367
 368 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
 369
 370         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
 371         TYPE_CODE_REF types.
 372
 373 2019-02-08  Jim Wilson  <jimw@sifive.com>
 374
 375         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
 376         (riscv_linux_fregset): New.
 377         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
 378
 379 2019-02-07  Tom Tromey  <tom@tromey.com>
 380
 381         * thread.c (thread_cancel_execution_command): Update.
 382         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
 383         methods.
 384         (struct thread_fsm_ops): Remove.
 385         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
 386         (thread_fsm_should_stop, thread_fsm_return_value)
 387         (thread_fsm_set_finished, thread_fsm_finished_p)
 388         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
 389         Don't declare.
 390         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
 391         * infrun.c (clear_proceed_status_thread)
 392         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
 393         (print_stop_event): Update.
 394         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
 395         Add constructor.
 396         (step_command_fsm_ops): Remove.
 397         (new_step_command_fsm): Remove.
 398         (step_1): Update.
 399         (step_command_fsm::should_stop): Rename from
 400         step_command_fsm_should_stop.
 401         (step_command_fsm::clean_up): Rename from
 402         step_command_fsm_clean_up.
 403         (step_command_fsm::do_async_reply_reason): Rename from
 404         step_command_fsm_async_reply_reason.
 405         (struct until_next_fsm): Inherit from thread_fsm.  Add
 406         constructor.
 407         (until_next_fsm_ops): Remove.
 408         (new_until_next_fsm): Remove.
 409         (until_next_fsm::should_stop): Rename from
 410         until_next_fsm_should_stop.
 411         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
 412         (until_next_fsm::do_async_reply_reason): Rename from
 413         until_next_fsm_async_reply_reason.
 414         (struct finish_command_fsm): Inherit from thread_fsm.  Add
 415         constructor.  Change type of breakpoint.
 416         (finish_command_fsm_ops): Remove.
 417         (new_finish_command_fsm): Remove.
 418         (finish_command_fsm::should_stop): Rename from
 419         finish_command_fsm_should_stop.
 420         (finish_command_fsm::clean_up): Rename from
 421         finish_command_fsm_clean_up.
 422         (finish_command_fsm::return_value): Rename from
 423         finish_command_fsm_return_value.
 424         (finish_command_fsm::do_async_reply_reason): Rename from
 425         finish_command_fsm_async_reply_reason.
 426         (finish_command): Update.
 427         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
 428         Add constructor.
 429         (call_thread_fsm_ops): Remove.
 430         (call_thread_fsm::call_thread_fsm): Rename from
 431         new_call_thread_fsm.
 432         (call_thread_fsm::should_stop): Rename from
 433         call_thread_fsm_should_stop.
 434         (call_thread_fsm::should_notify_stop): Rename from
 435         call_thread_fsm_should_notify_stop.
 436         (run_inferior_call, call_function_by_hand_dummy): Update.
 437         * cli/cli-interp.c (should_print_stop_to_console): Update.
 438         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
 439         Add constructor.  Change type of location_breakpoint,
 440         caller_breakpoint.
 441         (until_break_fsm_ops): Remove.
 442         (new_until_break_fsm): Remove.
 443         (until_break_fsm::should_stop): Rename from
 444         until_break_fsm_should_stop.
 445         (until_break_fsm::clean_up): Rename from
 446         until_break_fsm_clean_up.
 447         (until_break_fsm::do_async_reply_reason): Rename from
 448         until_break_fsm_async_reply_reason.
 449         (until_break_command): Update.
 450         * thread-fsm.c: Remove.
 451         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
 452
 453 2019-02-07  Tom Tromey  <tom@tromey.com>
 454
 455         * yy-remap.h: Add include guard.
 456         * xtensa-tdep.h: Add include guard.
 457         * xcoffread.h: Rename include guard.
 458         * varobj-iter.h: Add include guard.
 459         * tui/tui.h: Rename include guard.
 460         * tui/tui-winsource.h: Rename include guard.
 461         * tui/tui-wingeneral.h: Rename include guard.
 462         * tui/tui-windata.h: Rename include guard.
 463         * tui/tui-win.h: Rename include guard.
 464         * tui/tui-stack.h: Rename include guard.
 465         * tui/tui-source.h: Rename include guard.
 466         * tui/tui-regs.h: Rename include guard.
 467         * tui/tui-out.h: Rename include guard.
 468         * tui/tui-layout.h: Rename include guard.
 469         * tui/tui-io.h: Rename include guard.
 470         * tui/tui-hooks.h: Rename include guard.
 471         * tui/tui-file.h: Rename include guard.
 472         * tui/tui-disasm.h: Rename include guard.
 473         * tui/tui-data.h: Rename include guard.
 474         * tui/tui-command.h: Rename include guard.
 475         * tic6x-tdep.h: Add include guard.
 476         * target/waitstatus.h: Rename include guard.
 477         * target/wait.h: Rename include guard.
 478         * target/target.h: Rename include guard.
 479         * target/resume.h: Rename include guard.
 480         * target-float.h: Rename include guard.
 481         * stabsread.h: Add include guard.
 482         * rs6000-tdep.h: Add include guard.
 483         * riscv-fbsd-tdep.h: Add include guard.
 484         * regformats/regdef.h: Rename include guard.
 485         * record.h: Rename include guard.
 486         * python/python.h: Rename include guard.
 487         * python/python-internal.h: Rename include guard.
 488         * python/py-stopevent.h: Rename include guard.
 489         * python/py-ref.h: Rename include guard.
 490         * python/py-record.h: Rename include guard.
 491         * python/py-record-full.h: Rename include guard.
 492         * python/py-record-btrace.h: Rename include guard.
 493         * python/py-instruction.h: Rename include guard.
 494         * python/py-events.h: Rename include guard.
 495         * python/py-event.h: Rename include guard.
 496         * procfs.h: Add include guard.
 497         * proc-utils.h: Add include guard.
 498         * p-lang.h: Add include guard.
 499         * or1k-tdep.h: Rename include guard.
 500         * observable.h: Rename include guard.
 501         * nto-tdep.h: Rename include guard.
 502         * nat/x86-linux.h: Rename include guard.
 503         * nat/x86-linux-dregs.h: Rename include guard.
 504         * nat/x86-gcc-cpuid.h: Add include guard.
 505         * nat/x86-dregs.h: Rename include guard.
 506         * nat/x86-cpuid.h: Rename include guard.
 507         * nat/ppc-linux.h: Rename include guard.
 508         * nat/mips-linux-watch.h: Rename include guard.
 509         * nat/linux-waitpid.h: Rename include guard.
 510         * nat/linux-ptrace.h: Rename include guard.
 511         * nat/linux-procfs.h: Rename include guard.
 512         * nat/linux-osdata.h: Rename include guard.
 513         * nat/linux-nat.h: Rename include guard.
 514         * nat/linux-namespaces.h: Rename include guard.
 515         * nat/linux-btrace.h: Rename include guard.
 516         * nat/glibc_thread_db.h: Rename include guard.
 517         * nat/gdb_thread_db.h: Rename include guard.
 518         * nat/gdb_ptrace.h: Rename include guard.
 519         * nat/fork-inferior.h: Rename include guard.
 520         * nat/amd64-linux-siginfo.h: Rename include guard.
 521         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
 522         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
 523         * nat/aarch64-linux.h: Rename include guard.
 524         * nat/aarch64-linux-hw-point.h: Rename include guard.
 525         * mn10300-tdep.h: Add include guard.
 526         * mips-linux-tdep.h: Add include guard.
 527         * mi/mi-parse.h: Rename include guard.
 528         * mi/mi-out.h: Rename include guard.
 529         * mi/mi-main.h: Rename include guard.
 530         * mi/mi-interp.h: Rename include guard.
 531         * mi/mi-getopt.h: Rename include guard.
 532         * mi/mi-console.h: Rename include guard.
 533         * mi/mi-common.h: Rename include guard.
 534         * mi/mi-cmds.h: Rename include guard.
 535         * mi/mi-cmd-break.h: Rename include guard.
 536         * m2-lang.h: Add include guard.
 537         * location.h: Rename include guard.
 538         * linux-record.h: Rename include guard.
 539         * linux-nat.h: Add include guard.
 540         * linux-fork.h: Add include guard.
 541         * i386-darwin-tdep.h: Rename include guard.
 542         * hppa-linux-offsets.h: Add include guard.
 543         * guile/guile.h: Rename include guard.
 544         * guile/guile-internal.h: Rename include guard.
 545         * gnu-nat.h: Rename include guard.
 546         * gdb-stabs.h: Rename include guard.
 547         * frv-tdep.h: Add include guard.
 548         * f-lang.h: Add include guard.
 549         * event-loop.h: Add include guard.
 550         * darwin-nat.h: Rename include guard.
 551         * cp-abi.h: Rename include guard.
 552         * config/sparc/nm-sol2.h: Rename include guard.
 553         * config/nm-nto.h: Rename include guard.
 554         * config/nm-linux.h: Add include guard.
 555         * config/i386/nm-i386gnu.h: Rename include guard.
 556         * config/djgpp/nl_types.h: Rename include guard.
 557         * config/djgpp/langinfo.h: Rename include guard.
 558         * compile/gcc-cp-plugin.h: Add include guard.
 559         * compile/gcc-c-plugin.h: Add include guard.
 560         * compile/compile.h: Rename include guard.
 561         * compile/compile-object-run.h: Rename include guard.
 562         * compile/compile-object-load.h: Rename include guard.
 563         * compile/compile-internal.h: Rename include guard.
 564         * compile/compile-cplus.h: Rename include guard.
 565         * compile/compile-c.h: Rename include guard.
 566         * common/xml-utils.h: Rename include guard.
 567         * common/x86-xstate.h: Rename include guard.
 568         * common/version.h: Rename include guard.
 569         * common/vec.h: Rename include guard.
 570         * common/tdesc.h: Rename include guard.
 571         * common/selftest.h: Rename include guard.
 572         * common/scoped_restore.h: Rename include guard.
 573         * common/scoped_mmap.h: Rename include guard.
 574         * common/scoped_fd.h: Rename include guard.
 575         * common/safe-iterator.h: Rename include guard.
 576         * common/run-time-clock.h: Rename include guard.
 577         * common/refcounted-object.h: Rename include guard.
 578         * common/queue.h: Rename include guard.
 579         * common/ptid.h: Rename include guard.
 580         * common/print-utils.h: Rename include guard.
 581         * common/preprocessor.h: Rename include guard.
 582         * common/pathstuff.h: Rename include guard.
 583         * common/observable.h: Rename include guard.
 584         * common/netstuff.h: Rename include guard.
 585         * common/job-control.h: Rename include guard.
 586         * common/host-defs.h: Rename include guard.
 587         * common/gdb_wait.h: Rename include guard.
 588         * common/gdb_vecs.h: Rename include guard.
 589         * common/gdb_unlinker.h: Rename include guard.
 590         * common/gdb_unique_ptr.h: Rename include guard.
 591         * common/gdb_tilde_expand.h: Rename include guard.
 592         * common/gdb_sys_time.h: Rename include guard.
 593         * common/gdb_string_view.h: Rename include guard.
 594         * common/gdb_splay_tree.h: Rename include guard.
 595         * common/gdb_setjmp.h: Rename include guard.
 596         * common/gdb_ref_ptr.h: Rename include guard.
 597         * common/gdb_optional.h: Rename include guard.
 598         * common/gdb_locale.h: Rename include guard.
 599         * common/gdb_assert.h: Rename include guard.
 600         * common/filtered-iterator.h: Rename include guard.
 601         * common/filestuff.h: Rename include guard.
 602         * common/fileio.h: Rename include guard.
 603         * common/environ.h: Rename include guard.
 604         * common/common-utils.h: Rename include guard.
 605         * common/common-types.h: Rename include guard.
 606         * common/common-regcache.h: Rename include guard.
 607         * common/common-inferior.h: Rename include guard.
 608         * common/common-gdbthread.h: Rename include guard.
 609         * common/common-exceptions.h: Rename include guard.
 610         * common/common-defs.h: Rename include guard.
 611         * common/common-debug.h: Rename include guard.
 612         * common/cleanups.h: Rename include guard.
 613         * common/buffer.h: Rename include guard.
 614         * common/btrace-common.h: Rename include guard.
 615         * common/break-common.h: Rename include guard.
 616         * cli/cli-utils.h: Rename include guard.
 617         * cli/cli-style.h: Rename include guard.
 618         * cli/cli-setshow.h: Rename include guard.
 619         * cli/cli-script.h: Rename include guard.
 620         * cli/cli-interp.h: Rename include guard.
 621         * cli/cli-decode.h: Rename include guard.
 622         * cli/cli-cmds.h: Rename include guard.
 623         * charset-list.h: Add include guard.
 624         * buildsym-legacy.h: Rename include guard.
 625         * bfin-tdep.h: Add include guard.
 626         * ax.h: Rename include guard.
 627         * arm-linux-tdep.h: Add include guard.
 628         * arm-fbsd-tdep.h: Add include guard.
 629         * arch/xtensa.h: Rename include guard.
 630         * arch/tic6x.h: Add include guard.
 631         * arch/i386.h: Add include guard.
 632         * arch/arm.h: Rename include guard.
 633         * arch/arm-linux.h: Rename include guard.
 634         * arch/arm-get-next-pcs.h: Rename include guard.
 635         * arch/amd64.h: Add include guard.
 636         * arch/aarch64-insn.h: Rename include guard.
 637         * arch-utils.h: Rename include guard.
 638         * annotate.h: Add include guard.
 639         * amd64-darwin-tdep.h: Rename include guard.
 640         * aarch64-linux-tdep.h: Add include guard.
 641         * aarch64-fbsd-tdep.h: Add include guard.
 642         * aarch32-linux-nat.h: Add include guard.
 643
 644 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 645
 646         * macrotab.c (macro_define_internal): New function that
 647         factorizes macro_define_object_internal and macro_define_function
 648         code.
 649         (macro_define_object_internal): Use macro_define_internal.
 650         (macro_define_function): Likewise.
 651
 652 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 653
 654         * macrocmd.c (extract_identifier): Return
 655         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
 656         callers.
 657
 658 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
 659
 660         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
 661
 662 2019-02-05  Tom Tromey  <tom@tromey.com>
 663
 664         * target.c (target_stack::unpush): Move assertion earlier.
 665
 666 2019-01-30  Tom Tromey  <tom@tromey.com>
 667
 668         PR python/23615:
 669         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
 670         (gdbpy_parse_and_eval): Likewise.
 671         * python/python-internal.h (gdbpy_allow_threads): New class.
 672
 673 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
 674
 675         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
 676         (aarch64_fbsd_fpregmap): Move earlier.
 677         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
 678         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 679         instead of individual calls to trad_frame_set_reg_addr.
 680         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
 681         earlier.
 682         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
 683         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 684         instead of individual calls to trad_frame_set_reg_addr.
 685
 686 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
 687
 688         * CONTRIBUTE: Replace contribution list with wiki link.
 689
 690 2019-01-25  Tom Tromey  <tom@tromey.com>
 691
 692         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
 693
 694 2019-01-25  Tom Tromey  <tom@tromey.com>
 695
 696         * xtensa-linux-nat.c: Fix common/ includes.
 697         * xml-support.h: Fix common/ includes.
 698         * xml-support.c: Fix common/ includes.
 699         * x86-linux-nat.c: Fix common/ includes.
 700         * windows-nat.c: Fix common/ includes.
 701         * varobj.h: Fix common/ includes.
 702         * varobj.c: Fix common/ includes.
 703         * value.c: Fix common/ includes.
 704         * valops.c: Fix common/ includes.
 705         * utils.c: Fix common/ includes.
 706         * unittests/xml-utils-selftests.c: Fix common/ includes.
 707         * unittests/utils-selftests.c: Fix common/ includes.
 708         * unittests/unpack-selftests.c: Fix common/ includes.
 709         * unittests/tracepoint-selftests.c: Fix common/ includes.
 710         * unittests/style-selftests.c: Fix common/ includes.
 711         * unittests/string_view-selftests.c: Fix common/ includes.
 712         * unittests/scoped_restore-selftests.c: Fix common/ includes.
 713         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
 714         * unittests/scoped_fd-selftests.c: Fix common/ includes.
 715         * unittests/rsp-low-selftests.c: Fix common/ includes.
 716         * unittests/parse-connection-spec-selftests.c: Fix common/
 717         includes.
 718         * unittests/optional-selftests.c: Fix common/ includes.
 719         * unittests/offset-type-selftests.c: Fix common/ includes.
 720         * unittests/observable-selftests.c: Fix common/ includes.
 721         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
 722         * unittests/memrange-selftests.c: Fix common/ includes.
 723         * unittests/memory-map-selftests.c: Fix common/ includes.
 724         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
 725         * unittests/function-view-selftests.c: Fix common/ includes.
 726         * unittests/environ-selftests.c: Fix common/ includes.
 727         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
 728         * unittests/common-utils-selftests.c: Fix common/ includes.
 729         * unittests/cli-utils-selftests.c: Fix common/ includes.
 730         * unittests/array-view-selftests.c: Fix common/ includes.
 731         * ui-file.c: Fix common/ includes.
 732         * tui/tui-io.c: Fix common/ includes.
 733         * tracepoint.h: Fix common/ includes.
 734         * tracepoint.c: Fix common/ includes.
 735         * tracefile-tfile.c: Fix common/ includes.
 736         * top.h: Fix common/ includes.
 737         * top.c: Fix common/ includes.
 738         * thread.c: Fix common/ includes.
 739         * target/waitstatus.h: Fix common/ includes.
 740         * target/waitstatus.c: Fix common/ includes.
 741         * target.h: Fix common/ includes.
 742         * target.c: Fix common/ includes.
 743         * target-memory.c: Fix common/ includes.
 744         * target-descriptions.c: Fix common/ includes.
 745         * symtab.h: Fix common/ includes.
 746         * symfile.c: Fix common/ includes.
 747         * stap-probe.c: Fix common/ includes.
 748         * spu-linux-nat.c: Fix common/ includes.
 749         * sparc-nat.c: Fix common/ includes.
 750         * source.c: Fix common/ includes.
 751         * solib.c: Fix common/ includes.
 752         * solib-target.c: Fix common/ includes.
 753         * ser-unix.c: Fix common/ includes.
 754         * ser-tcp.c: Fix common/ includes.
 755         * ser-pipe.c: Fix common/ includes.
 756         * ser-base.c: Fix common/ includes.
 757         * selftest-arch.c: Fix common/ includes.
 758         * s12z-tdep.c: Fix common/ includes.
 759         * rust-exp.y: Fix common/ includes.
 760         * rs6000-aix-tdep.c: Fix common/ includes.
 761         * riscv-tdep.c: Fix common/ includes.
 762         * remote.c: Fix common/ includes.
 763         * remote-notif.h: Fix common/ includes.
 764         * remote-fileio.h: Fix common/ includes.
 765         * remote-fileio.c: Fix common/ includes.
 766         * regcache.h: Fix common/ includes.
 767         * regcache.c: Fix common/ includes.
 768         * record-btrace.c: Fix common/ includes.
 769         * python/python.c: Fix common/ includes.
 770         * python/py-type.c: Fix common/ includes.
 771         * python/py-inferior.c: Fix common/ includes.
 772         * progspace.h: Fix common/ includes.
 773         * producer.c: Fix common/ includes.
 774         * procfs.c: Fix common/ includes.
 775         * proc-api.c: Fix common/ includes.
 776         * printcmd.c: Fix common/ includes.
 777         * ppc-linux-nat.c: Fix common/ includes.
 778         * parser-defs.h: Fix common/ includes.
 779         * osdata.c: Fix common/ includes.
 780         * obsd-nat.c: Fix common/ includes.
 781         * nat/x86-linux.c: Fix common/ includes.
 782         * nat/x86-linux-dregs.c: Fix common/ includes.
 783         * nat/x86-dregs.h: Fix common/ includes.
 784         * nat/x86-dregs.c: Fix common/ includes.
 785         * nat/ppc-linux.c: Fix common/ includes.
 786         * nat/mips-linux-watch.h: Fix common/ includes.
 787         * nat/mips-linux-watch.c: Fix common/ includes.
 788         * nat/linux-waitpid.c: Fix common/ includes.
 789         * nat/linux-ptrace.h: Fix common/ includes.
 790         * nat/linux-ptrace.c: Fix common/ includes.
 791         * nat/linux-procfs.c: Fix common/ includes.
 792         * nat/linux-personality.c: Fix common/ includes.
 793         * nat/linux-osdata.c: Fix common/ includes.
 794         * nat/linux-namespaces.c: Fix common/ includes.
 795         * nat/linux-btrace.h: Fix common/ includes.
 796         * nat/linux-btrace.c: Fix common/ includes.
 797         * nat/fork-inferior.c: Fix common/ includes.
 798         * nat/amd64-linux-siginfo.c: Fix common/ includes.
 799         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
 800         * nat/aarch64-linux.c: Fix common/ includes.
 801         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
 802         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
 803         * namespace.h: Fix common/ includes.
 804         * mips-linux-tdep.c: Fix common/ includes.
 805         * minsyms.c: Fix common/ includes.
 806         * mi/mi-parse.h: Fix common/ includes.
 807         * mi/mi-main.c: Fix common/ includes.
 808         * mi/mi-cmd-env.c: Fix common/ includes.
 809         * memrange.h: Fix common/ includes.
 810         * memattr.c: Fix common/ includes.
 811         * maint.h: Fix common/ includes.
 812         * maint.c: Fix common/ includes.
 813         * main.c: Fix common/ includes.
 814         * machoread.c: Fix common/ includes.
 815         * location.c: Fix common/ includes.
 816         * linux-thread-db.c: Fix common/ includes.
 817         * linux-nat.c: Fix common/ includes.
 818         * linux-fork.c: Fix common/ includes.
 819         * inline-frame.c: Fix common/ includes.
 820         * infrun.c: Fix common/ includes.
 821         * inflow.c: Fix common/ includes.
 822         * inferior.h: Fix common/ includes.
 823         * inferior.c: Fix common/ includes.
 824         * infcmd.c: Fix common/ includes.
 825         * inf-ptrace.c: Fix common/ includes.
 826         * inf-child.c: Fix common/ includes.
 827         * ia64-linux-nat.c: Fix common/ includes.
 828         * i387-tdep.c: Fix common/ includes.
 829         * i386-tdep.c: Fix common/ includes.
 830         * i386-linux-tdep.c: Fix common/ includes.
 831         * i386-linux-nat.c: Fix common/ includes.
 832         * i386-go32-tdep.c: Fix common/ includes.
 833         * i386-fbsd-tdep.c: Fix common/ includes.
 834         * i386-fbsd-nat.c: Fix common/ includes.
 835         * guile/scm-type.c: Fix common/ includes.
 836         * guile/guile.c: Fix common/ includes.
 837         * go32-nat.c: Fix common/ includes.
 838         * gnu-nat.c: Fix common/ includes.
 839         * gdbthread.h: Fix common/ includes.
 840         * gdbarch-selftests.c: Fix common/ includes.
 841         * gdb_usleep.c: Fix common/ includes.
 842         * gdb_select.h: Fix common/ includes.
 843         * gdb_bfd.c: Fix common/ includes.
 844         * gcore.c: Fix common/ includes.
 845         * fork-child.c: Fix common/ includes.
 846         * findvar.c: Fix common/ includes.
 847         * fbsd-nat.c: Fix common/ includes.
 848         * event-top.c: Fix common/ includes.
 849         * event-loop.c: Fix common/ includes.
 850         * dwarf2read.c: Fix common/ includes.
 851         * dwarf2loc.c: Fix common/ includes.
 852         * dwarf2-frame.c: Fix common/ includes.
 853         * dwarf-index-cache.c: Fix common/ includes.
 854         * dtrace-probe.c: Fix common/ includes.
 855         * disasm-selftests.c: Fix common/ includes.
 856         * defs.h: Fix common/ includes.
 857         * csky-tdep.c: Fix common/ includes.
 858         * cp-valprint.c: Fix common/ includes.
 859         * cp-support.h: Fix common/ includes.
 860         * cp-support.c: Fix common/ includes.
 861         * corelow.c: Fix common/ includes.
 862         * completer.h: Fix common/ includes.
 863         * completer.c: Fix common/ includes.
 864         * compile/compile.c: Fix common/ includes.
 865         * compile/compile-loc2c.c: Fix common/ includes.
 866         * compile/compile-cplus-types.c: Fix common/ includes.
 867         * compile/compile-cplus-symbols.c: Fix common/ includes.
 868         * command.h: Fix common/ includes.
 869         * cli/cli-dump.c: Fix common/ includes.
 870         * cli/cli-cmds.c: Fix common/ includes.
 871         * charset.c: Fix common/ includes.
 872         * build-id.c: Fix common/ includes.
 873         * btrace.h: Fix common/ includes.
 874         * btrace.c: Fix common/ includes.
 875         * breakpoint.h: Fix common/ includes.
 876         * breakpoint.c: Fix common/ includes.
 877         * ax.h:
 878         (enum agent_op): Fix common/ includes.
 879         * ax-general.c (struct aop_map): Fix common/ includes.
 880         * ax-gdb.c: Fix common/ includes.
 881         * auxv.c: Fix common/ includes.
 882         * auto-load.c: Fix common/ includes.
 883         * arm-tdep.c: Fix common/ includes.
 884         * arch/riscv.c: Fix common/ includes.
 885         * arch/ppc-linux-common.c: Fix common/ includes.
 886         * arch/i386.c: Fix common/ includes.
 887         * arch/arm.c: Fix common/ includes.
 888         * arch/arm-linux.c: Fix common/ includes.
 889         * arch/arm-get-next-pcs.c: Fix common/ includes.
 890         * arch/amd64.c: Fix common/ includes.
 891         * arch/aarch64.c: Fix common/ includes.
 892         * arch/aarch64-insn.c: Fix common/ includes.
 893         * arch-utils.c: Fix common/ includes.
 894         * amd64-windows-tdep.c: Fix common/ includes.
 895         * amd64-tdep.c: Fix common/ includes.
 896         * amd64-sol2-tdep.c: Fix common/ includes.
 897         * amd64-obsd-tdep.c: Fix common/ includes.
 898         * amd64-nbsd-tdep.c: Fix common/ includes.
 899         * amd64-linux-tdep.c: Fix common/ includes.
 900         * amd64-linux-nat.c: Fix common/ includes.
 901         * amd64-fbsd-tdep.c: Fix common/ includes.
 902         * amd64-fbsd-nat.c: Fix common/ includes.
 903         * amd64-dicos-tdep.c: Fix common/ includes.
 904         * amd64-darwin-tdep.c: Fix common/ includes.
 905         * agent.c: Fix common/ includes.
 906         * ada-lang.h: Fix common/ includes.
 907         * ada-lang.c: Fix common/ includes.
 908         * aarch64-tdep.c: Fix common/ includes.
 909
 910 2019-01-25  Tom Tromey  <tom@tromey.com>
 911
 912         * common/create-version.sh: Use common/version.h.
 913
 914 2019-01-24  Pedro Alves  <palves@redhat.com>
 915
 916         * infrun.c (signal_stop, signal_print, signal_program)
 917         (signal_catch, signal_pass): Now arrays instead of pointers.
 918         (update_signals_program_target, do_target_resume)
 919         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
 920         * linux-nat.c (linux_nat_target::pass_signals)
 921         (linux_nat_target::create_inferior, linux_nat_target::attach):
 922         Adjust.
 923         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
 924         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
 925         * procfs.c (procfs_target::pass_signals): Adjust.
 926         * record-full.c (record_full_target::resume): Adjust.
 927         * remote.c (remote_target::pass_signals)
 928         (remote_target::program_signals): Adjust.
 929         * target-debug.h (target_debug_print_signals): Now takes a
 930         gdb::array_view as parameter.  Adjust.
 931         * target.h (target_ops) <pass_signals, program_signals>: Replace
 932         pointer and length parameters with gdb::array_view.
 933         (target_pass_signals, target_program_signals): Likewise.
 934         * target-delegates.c: Regenerate.
 935
 936 2019-01-24  Pedro Alves  <palves@redhat.com>
 937
 938         * common/forward-scope-exit.h
 939         (forward_scope_exit::forward_scope_exit): Pass arguments to
 940         m_bind_function directly, instead of creating a std::bind and
 941         copying that.
 942
 943 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
 944
 945         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 946         for static members.
 947         (pass_in_v_vfp_candidate): Likewise.
 948
 949 2019-01-23  Tom Tromey  <tom@tromey.com>
 950             Pedro Alves  <palves@redhat.com>
 951
 952         * regcache.c (class regcache_invalidator): Remove.
 953         (regcache::raw_write): Use make_scope_exit.
 954
 955 2019-01-23  Tom Tromey  <tom@tromey.com>
 956
 957         * ui-out.h (class ui_out_emit_type): Update comment.
 958
 959 2019-01-23  Tom Tromey  <tom@tromey.com>
 960
 961         * infrun.c (fetch_inferior_event): Update comment.
 962
 963 2019-01-23  Tom Tromey  <tom@tromey.com>
 964             Pedro Alves  <palves@redhat.com>
 965
 966         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
 967         parameter.
 968         (fetch_inferior_event): Use SCOPE_EXIT.
 969
 970
 971 2019-01-23  Tom Tromey  <tom@tromey.com>
 972             Pedro Alves  <palves@redhat.com>
 973
 974         * infrun.c (disable_thread_events): Delete.
 975         (stop_all_threads): Use SCOPE_EXIT.
 976
 977 2019-01-23  Tom Tromey  <tom@tromey.com>
 978             Pedro Alves  <palves@redhat.com>
 979
 980         * symfile.c: Include forward-scope-exit.h.
 981         (clear_symtab_users_cleanup): Replace forward declaration with
 982         a FORWARD_SCOPE_EXIT.
 983         (syms_from_objfile_1): Use the forward_scope_exit and
 984         gdb::optional instead of cleanup_function.
 985         (reread_symbols): Use the forward_scope_exit instead of
 986         cleanup_function.
 987         (clear_symtab_users_cleanup): Remove function.
 988
 989 2019-01-23  Tom Tromey  <tom@tromey.com>
 990             Pedro Alves  <palves@redhat.com>
 991
 992         * linux-nat.c: Include scope-exit.h.
 993         (cleanup_target_stop): Remove.
 994         (linux_nat_target::static_tracepoint_markers_by_strid): Use
 995         SCOPE_EXIT.
 996
 997 2019-01-23  Tom Tromey  <tom@tromey.com>
 998             Pedro Alves  <palves@redhat.com>
 999
1000         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1001         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1002
1003 2019-01-23  Tom Tromey  <tom@tromey.com>
1004             Andrew Burgess  <andrew.burgess@embecosm.com>
1005             Pedro Alves  <palves@redhat.com>
1006
1007         * infrun.c (fetch_inferior_event): Use scope_exit.
1008         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1009         * top.c (execute_command): Use scope_exit.
1010         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1011         * utils.c (do_bpstat_clear_actions_cleanup)
1012         (make_bpstat_clear_actions_cleanup): Remove.
1013
1014 2019-01-23  Tom Tromey  <tom@tromey.com>
1015             Pedro Alves  <palves@redhat.com>
1016
1017         * infrun.c: Include "common/scope-exit.h"
1018         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1019         (wait_for_inferior): Use SCOPE_EXIT.
1020         (fetch_inferior_event): Use scope_exit.
1021
1022 2019-01-23  Tom Tromey  <tom@tromey.com>
1023             Pedro Alves  <palves@redhat.com>
1024
1025         * breakpoint.c (create_breakpoint): Remove cleanup.
1026
1027 2019-01-23  Tom Tromey  <tom@tromey.com>
1028             Andrew Burgess  <andrew.burgess@embecosm.com>
1029             Pedro Alves  <palves@redhat.com>
1030
1031 2019-01-23  Pedro Alves  <palves@redhat.com>
1032
1033         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1034
1035 2019-01-23  Pedro Alves  <palves@redhat.com>
1036             Andrew Burgess  <andrew.burgess@embecosm.com>
1037
1038         * gdbthread.h: Include "common/forward-scope-exit.h".
1039         (scoped_finish_thread_state): Redefine custom class in terms of
1040         forward_scope_exit.
1041
1042 2019-01-23  Pedro Alves  <palves@redhat.com>
1043             Andrew Burgess  <andrew.burgess@embecosm.com>
1044
1045         * common/forward-scope-exit.h: New file.
1046
1047 2019-01-23  Pedro Alves  <palves@redhat.com>
1048             Andrew Burgess  <andrew.burgess@embecosm.com>
1049             Tom Tromey  <tom@tromey.com>
1050
1051         * common/scope-exit.h: New file.
1052
1053 2019-01-23  Pedro Alves  <palves@redhat.com>
1054
1055         * common/preprocessor.h (ESC): Rename to ...
1056         (ESC_PARENS): ... this.
1057         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1058         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1059
1060 2019-01-23  Tom Tromey  <tom@tromey.com>
1061
1062         * language.h (class scoped_switch_to_sym_language_if_auto):
1063         Initialize m_lang in both cases.
1064
1065 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1066
1067         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1068         with XCNEW.
1069
1070 2019-01-22  Tom Tromey  <tom@tromey.com>
1071
1072         * corelow.c: Do not include sys/file.h.
1073
1074 2019-01-22  Tom Tromey  <tom@tromey.com>
1075
1076         * tui/tui-wingeneral.h: Include gdb_curses.h.
1077
1078 2019-01-22  Tom Tromey  <tom@tromey.com>
1079
1080         * source-cache.h (class source_cache) <get_source_lines,
1081         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1082
1083 2019-01-22  Tom Tromey  <tom@tromey.com>
1084
1085         * remote-fileio.h (struct remote_target): Declare.
1086
1087 2019-01-22  Tom Tromey  <tom@tromey.com>
1088
1089         * python/py-arch.c: Do not include py-ref.h.
1090         * python/py-bpevent.c: Do not include py-ref.h.
1091         * python/py-cmd.c: Do not include py-ref.h.
1092         * python/py-continueevent.c: Do not include py-ref.h.
1093         * python/py-event.h: Do not include py-ref.h.
1094         * python/py-evtregistry.c: Do not include py-ref.h.
1095         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1096         * python/py-frame.c: Do not include py-ref.h.
1097         * python/py-framefilter.c: Do not include py-ref.h.
1098         * python/py-function.c: Do not include py-ref.h.
1099         * python/py-infevents.c: Do not include py-ref.h.
1100         * python/py-linetable.c: Do not include py-ref.h.
1101         * python/py-objfile.c: Do not include py-ref.h.
1102         * python/py-param.c: Do not include py-ref.h.
1103         * python/py-prettyprint.c: Do not include py-ref.h.
1104         * python/py-progspace.c: Do not include py-ref.h.
1105         * python/py-symbol.c: Do not include py-ref.h.
1106         * python/py-symtab.c: Do not include py-ref.h.
1107         * python/py-type.c: Do not include py-ref.h.
1108         * python/py-unwind.c: Do not include py-ref.h.
1109         * python/py-utils.c: Do not include py-ref.h.
1110         * python/py-value.c: Do not include py-ref.h.
1111         * python/py-varobj.c: Do not include py-ref.h.
1112         * python/py-xmethods.c: Do not include py-ref.h.
1113         * python/python.c: Do not include py-ref.h.
1114         * varobj.c: Do not include py-ref.h.
1115
1116 2019-01-22  Tom Tromey  <tom@tromey.com>
1117
1118         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1119         keyword for bcache.
1120
1121 2019-01-22  Tom Tromey  <tom@tromey.com>
1122
1123         * compile/compile-cplus-types.c: Remove a comment by #include.
1124
1125 2019-01-22  Tom Tromey  <tom@tromey.com>
1126
1127         * compile/gcc-c-plugin.h: Include compile-internal.h.
1128
1129 2019-01-22  Tom Tromey  <tom@tromey.com>
1130
1131         * stabsread.c (EXTERN): Do not define.
1132         (symnum, next_symbol_text_func, processing_gcc_compilation)
1133         (within_function, global_sym_chain, global_stabs)
1134         (previous_stab_code, this_object_header_files)
1135         (n_this_object_header_files)
1136         (n_allocated_this_object_header_files): Define.
1137         * stabsread.h (EXTERN): Never define.  Use "extern".
1138
1139 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1140
1141         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1142         history_value.
1143
1144 2019-01-21  Tom Tromey  <tom@tromey.com>
1145
1146         * ui-out.c: Fix includes.
1147         * tui/tui-source.c: Fix includes.
1148         * target.c: Fix includes.
1149         * remote.c: Fix includes.
1150         * regcache.c: Fix includes.
1151         * python/py-block.c: Fix includes.
1152         * printcmd.c: Fix includes.
1153         * or1k-tdep.c: Fix includes.
1154         * mi/mi-main.c: Fix includes.
1155         * m32r-tdep.c: Fix includes.
1156         * csky-tdep.c: Fix includes.
1157         * compile/compile-cplus-types.c: Fix includes.
1158         * cli/cli-interp.c: Fix includes.
1159
1160 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1161
1162         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1163         for padding.
1164
1165 2019-01-16  Tom Tromey  <tom@tromey.com>
1166
1167         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1168         earlier.
1169         (struct objfile) <msymbols_range>: Move from top level.
1170         <msymbols>: New method.
1171         (class objfile_msymbols): Remove.
1172         * symtab.c (default_collect_symbol_completion_matches_break_on):
1173         Update.
1174         * symmisc.c (dump_msymbols): Update.
1175         * stabsread.c (scan_file_globals): Update.
1176         * objc-lang.c (info_selectors_command, info_classes_command)
1177         (find_methods): Update.
1178         * minsyms.c (find_solib_trampoline_target): Update.
1179         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1180         * coffread.c (coff_symfile_read): Update.
1181         * ada-lang.c (ada_lookup_simple_minsym)
1182         (ada_collect_symbol_completion_matches): Update.
1183
1184 2019-01-16  Tom Tromey  <tom@tromey.com>
1185
1186         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1187         type.  Remove no-argument constructor.
1188         <iterator::operator++>: Simplify.
1189         <begin>: Update.
1190         <end>: Use minimal_symbol_count.
1191
1192 2019-01-16  Tom Tromey  <tom@tromey.com>
1193
1194         * objfiles.h (struct objfile) <psymtabs>: New method.
1195         (class objfile_psymtabs): Remove.
1196         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1197         typedef.
1198         <range>: New method.
1199         (require_partial_symbols): Change return type.
1200         * psymtab.c (require_partial_symbols)
1201         (psym_expand_symtabs_matching): Update.
1202         * mdebugread.c (parse_partial_symbols): Update.
1203         * dbxread.c (dbx_end_psymtab): Update.
1204
1205 2019-01-15  Tom Tromey  <tom@tromey.com>
1206
1207         * symtab.c (lookup_objfile_from_block)
1208         (lookup_symbol_in_objfile_symtabs)
1209         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1210         (find_line_symtab, info_sources_command)
1211         (default_collect_symbol_completion_matches_break_on)
1212         (make_source_files_completion_list): Update.
1213         * symmisc.c (print_objfile_statistics, dump_objfile)
1214         (maintenance_print_symbols, maintenance_info_symtabs)
1215         (maintenance_check_symtabs, maintenance_info_line_tables):
1216         Update.
1217         * source.c (select_source_symtab)
1218         (forget_cached_source_info_for_objfile): Update.
1219         * objfiles.h (class objfile_compunits): Remove.
1220         (struct objfile) <compunits_range>: New typedef.
1221         (compunits): New method.
1222         * objfiles.c (objfile_relocate1): Update.
1223         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1224         * maint.c (count_symtabs_and_blocks): Update.
1225         * linespec.c (iterate_over_all_matching_symtabs): Update.
1226         * cp-support.c (add_symbol_overload_list_qualified): Update.
1227         * coffread.c (coff_symtab_read): Update.
1228         * ada-lang.c (add_nonlocal_symbols)
1229         (ada_collect_symbol_completion_matches)
1230         (ada_add_global_exceptions): Update.
1231
1232 2019-01-15  Tom Tromey  <tom@tromey.com>
1233
1234         * progspace.h (program_space) <objfiles_safe_range>: New
1235         typedef.
1236         <objfiles_safe>: New method.
1237         * objfiles.h (class all_objfiles_safe): Remove.
1238         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1239         * jit.c (jit_inferior_exit_hook): Update.
1240
1241 2019-01-17  Tom Tromey  <tom@tromey.com>
1242
1243         * progspace.h (program_space) <objfiles_range>: New typedef.
1244         <objfiles>: New method.
1245         <objfiles_head>: Rename from objfiles.
1246         (object_files): Update.
1247         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1248         * guile/scm-pretty-print.c
1249         (ppscm_find_pretty_printer_from_objfiles): Update.
1250         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1251         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1252         Update.
1253         * python/py-progspace.c (pspy_get_objfiles): Update.
1254         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1255         Update.
1256         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1257         (objfpy_lookup_objfile_by_build_id): Update.
1258         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1259         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1260         Update.
1261         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1262         (expand_symtab_containing_pc, lookup_objfile_from_block)
1263         (lookup_static_symbol, basic_lookup_transparent_type)
1264         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1265         (find_line_symtab, info_sources_command)
1266         (default_collect_symbol_completion_matches_break_on)
1267         (make_source_files_completion_list, find_main_name): Update.
1268         * symmisc.c (print_symbol_bcache_statistics)
1269         (print_objfile_statistics, maintenance_print_symbols)
1270         (maintenance_print_msymbols, maintenance_print_objfiles)
1271         (maintenance_info_symtabs, maintenance_check_symtabs)
1272         (maintenance_expand_symtabs, maintenance_info_line_tables):
1273         Update.
1274         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1275         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1276         (map_overlay_command, unmap_overlay_command)
1277         (simple_overlay_update, expand_symtabs_matching)
1278         (map_symbol_filenames): Update.
1279         * symfile-debug.c (set_debug_symfile): Update.
1280         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1281         Update.
1282         * source.c (select_source_symtab, forget_cached_source_info):
1283         Update.
1284         * solib.c (solib_read_symbols): Update.
1285         * solib-spu.c (append_ocl_sos): Update.
1286         * psymtab.c (maintenance_print_psymbols)
1287         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1288         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1289         * printcmd.c (info_symbol_command): Update.
1290         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1291         Update.
1292         * objfiles.h (class all_objfiles): Remove.
1293         * objfiles.c (have_partial_symbols, have_full_symbols)
1294         (have_minimal_symbols, qsort_cmp, update_section_map)
1295         (shared_objfile_contains_address_p)
1296         (default_iterate_over_objfiles_in_search_order): Update.
1297         * objc-lang.c (info_selectors_command, info_classes_command)
1298         (find_methods): Update.
1299         * minsyms.c (find_solib_trampoline_target): Update.
1300         * maint.c (maintenance_info_sections)
1301         (maintenance_translate_address, count_symtabs_and_blocks):
1302         Update.
1303         * main.c (captured_main_1): Update.
1304         * linux-thread-db.c (try_thread_db_load_from_pdir)
1305         (has_libpthread): Update.
1306         * linespec.c (iterate_over_all_matching_symtabs)
1307         (search_minsyms_for_name): Update.
1308         * jit.c (jit_find_objf_with_entry_addr): Update.
1309         * hppa-tdep.c (find_unwind_entry)
1310         (hppa_lookup_stub_minimal_symbol): Update.
1311         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1312         Update.
1313         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1314         (elf_gnu_ifunc_resolve_by_got): Update.
1315         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1316         * dwarf-index-write.c (save_gdb_index_command): Update.
1317         * cp-support.c (add_symbol_overload_list_qualified): Update.
1318         * breakpoint.c (create_overlay_event_breakpoint)
1319         (create_longjmp_master_breakpoint)
1320         (create_std_terminate_master_breakpoint)
1321         (create_exception_master_breakpoint): Update.
1322         * blockframe.c (find_pc_partial_function): Update.
1323         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1324         (ada_collect_symbol_completion_matches)
1325         (ada_add_global_exceptions): Update.
1326
1327 2019-01-17  Tom Tromey  <tom@tromey.com>
1328
1329         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1330         declare VEC.
1331         (solib_target_parse_libraries): Change return type.
1332         (library_list_start_segment, library_list_start_section)
1333         (library_list_end_library, library_list_start_library); Update.
1334         (solib_target_free_library_list): Remove.
1335         (solib_target_parse_libraries): Remove cleanup.  Change return
1336         type.
1337         (solib_target_current_sos): Update.
1338
1339 2019-01-17  Tom Tromey  <tromey@bapiya>
1340
1341         * valprint.c: Replace "the the" with "the".
1342         * symtab.c: Replace "the the" with "the".
1343         * solib.c: Replace "the the" with "the".
1344         * solib-dsbt.c: Replace "the the" with "the".
1345         * linespec.c: Replace "the the" with "the".
1346         * dwarf2loc.h: Replace "the the" with "the".
1347         * amd64-windows-tdep.c: Replace "the the" with "the".
1348         * aarch64-tdep.c: Replace "the the" with "the".
1349
1350 2019-01-16  Keith Seitz  <keiths@redhat.com>
1351
1352         PR gdb/23773
1353         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1354         <builder>: Rename to ..
1355         <m_builder>: ... this and make private.
1356         (dwarf2_cu::get_builder): New method.  Change all users of
1357         `builder' to use this method.
1358         (dwarf2_start_symtab): Move to ...
1359         (dwarf2_cu::start_symtab): ... here.  Update all callers
1360         (setup_type_unit_groups): Move to ...
1361         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1362         callers.
1363         (dwarf2_cu::reset_builder): New method.
1364         (process_full_compunit, process_full_type_unit): Use
1365         dwarf2_cu::reset_builder.
1366         (follow_die_offset): Record the ancestor CU if it is different
1367         from the followed DIE's CU.
1368         (follow_die_sig_1): Likewise.
1369
1370 2019-01-15  Tom Tromey  <tom@tromey.com>
1371
1372         * remote.c (class remote_state) <buf>: Now a char_vector.
1373         <buf_size>: Remove.
1374         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1375         parameter.
1376         (remote_target::getpkt_or_notif_sane_1)
1377         (remote_target::getpkt_sane)
1378         (remote_target::getpkt_or_notif_sane): Likewise.
1379         (class remote_target) <putpkt>: New overload.
1380         (remote_target::read_frame): Change type of "buf_p".  Remove
1381         sizeof_p parameter.
1382         (packet_ok): New overload.
1383         (packet_check_result): New overload.
1384         Update all uses.
1385
1386 2019-01-14  Tom Tromey  <tom@tromey.com>
1387
1388         * remote-notif.c (handle_notification, remote_notif_ack)
1389         (remote_notif_parse): Make "buf" const.
1390         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1391         const.
1392         (remote_notif_parse, remote_notif_ack, handle_notification):
1393         Likewise.
1394         * remote.c (remote_notif_stop_parse): Make "buf" const.
1395         (remote_target::remote_parse_stop_reply): Make "buf" const.
1396         (remote_notif_stop_ack): Make "buf" const.
1397
1398 2019-01-14  Tom Tromey  <tom@tromey.com>
1399
1400         * remote.c (remote_console_output): Make parameter const.
1401
1402 2019-01-14  Tom Tromey  <tom@tromey.com>
1403
1404         * target-debug.h (target_debug_print_signals): Constify.
1405         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1406         * procfs.c (procfs_target::pass_signals): Update.
1407         * linux-nat.c (linux_nat_target::pass_signals): Update.
1408         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1409         * target-delegates.c: Rebuild.
1410         * remote.c (remote_target::program_signals): Update.
1411         (remote_target::pass_signals): Update.
1412         * target.c (target_pass_signals): Constify argument.
1413         (target_program_signals): Likewise.
1414         * target.h (struct target_ops) <pass_signals, program_signals>:
1415         Constify argument.
1416         (target_pass_signals, target_program_signals): Constify argument.
1417
1418 2019-01-14  Tom Tromey  <tom@tromey.com>
1419
1420         PR tui/28819:
1421         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1422
1423 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1424
1425         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1426         field.
1427         * rs6000-tdep.c: Include reggroups.h.
1428         (IS_V_ALIAS_PSEUDOREG): Define.
1429         (rs6000_register_name): Return names for the "vX" aliases.
1430         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1431         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1432         aliases.  Call default_register_reggroup_p for all other
1433         pseudo-registers.
1434         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1435         New functions.
1436         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1437         Handle "vX" aliases.
1438         (v_alias_pseudo_register_collect): New function.
1439         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1440         (rs6000_gdbarch_init): Initialize "vX" aliases as
1441         pseudo-registers.  Restore registration of
1442         rs6000_pseudo_register_reggroup_p with
1443         set_tdesc_pseudo_register_reggroup_p.
1444
1445 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1446
1447         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1448         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1449         set_gdbarch_num_pseudo_regs.
1450
1451 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1452
1453         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1454         Remove arg prefixname, add do_set and do_show.
1455         Add member functions set_list and show_list.
1456         * cli/cli-style.c (class cli_style_option): Update accordingly.
1457         (style_set_list): Move to file scope.
1458         (style_show_list): Likewise.
1459         (set_style): Call help_list.
1460         (show_style): Call cmd_show_list.
1461         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1462         Update to use the new macro.
1463
1464 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1465
1466         * ada-lang.c (_initialize_ada_language): Expand the help text
1467         for the "catch exception" command.
1468
1469 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1470
1471         * symtab.c (matching_obj_sections): Initialize obj,
1472         declare it closer to its usage.
1473
1474 2019-01-10  Tom Tromey  <tom@tromey.com>
1475
1476         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1477         (basic_inf_threads_range): Remove.
1478         (inf_threads_range, inf_non_exited_threads_range)
1479         (safe_inf_threads_range): Use next_adapter.
1480
1481 2019-01-10  Keith Seitz  <keiths@redhat.com>
1482
1483         PR gdb/23712
1484         PR symtab/23010
1485         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1486         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1487
1488 2019-01-10  Keith Seitz  <keiths@redhat.com>
1489
1490         PR gdb/23712
1491         PR symtab/23010
1492         * dictionary.c (pending_to_vector): Remove.
1493         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1494         Remove _1 suffix, replacing functions of the same name.  Update
1495         all callers.
1496         (dict_create_hashed, dict_create_hashed_expandable)
1497         (dict_create_linear, dict_create_linear_expandable, dict_free)
1498         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1499         Make functions static.
1500
1501 2019-01-10  Keith Seitz  <keiths@redhat.com>
1502
1503         PR gdb/23712
1504         PR symtab/23010
1505         * dictionary.h (struct dictionary): Replace declaration with
1506         multidictionary.
1507         (dict_create_hashed, dict_create_hashed_expandable)
1508         (dict_create_linear, dict_create_linear_expandable)
1509         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1510         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1511         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1512         taking multidictionary argument.
1513         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1514         * block.h (struct block) <dict>: Change to multidictionary
1515         and rename `multidict'.
1516         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1517         symmisc.c: Update all dictionary references to multidictionary.
1518
1519 2019-01-10  Keith Seitz  <keiths@redhat.com>
1520
1521         PR gdb/23712
1522         PR symtab/23010
1523         * dictionary.c: Include unordered_map.
1524         (pending_to_vector): New function.
1525         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1526         Rewrite the non-"_1" functions to take vector instead
1527         of linked list.
1528         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1529         "new" _1 versions of the same name.
1530         (multidictionary): Define.
1531         (std::hash<enum language): New definition.
1532         (collate_pending_symbols_by_language, mdict_create_hashed)
1533         (mdict_create_hashed_expandable, mdict_create_linear)
1534         (mdict_create_linear_expandable, mdict_free)
1535         (find_language_dictionary, create_new_language_dictionary)
1536         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1537         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1538         (mdict_size, mdict_empty): New functions.
1539         * dictionary.h (mdict_iterator): Define.
1540
1541 2019-01-10  Pedro Alves  <palves@redhat.com>
1542
1543         * breakpoint.c (read_uploaded_action)
1544         (create_tracepoint_from_upload): Adjust to use
1545         gdb::unique_xmalloc_ptr.
1546         * ctf.c (ctf_write_uploaded_tp):
1547         (SET_ARRAY_FIELD): Use emplace_back.
1548         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1549         * tracefile-tfile.c (tfile_write_uploaded_tp):
1550         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1551         gdb::unique_xmalloc_ptr.
1552         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1553         at_string, cond_string, cmd_strings>: Replace char pointers
1554         with gdb::unique_xmalloc_ptr.
1555
1556 2019-01-10  Pedro Alves  <palves@redhat.com>
1557
1558         * solib-target.c (library_list_start_library): Don't xstrdup name.
1559
1560 2019-01-10  Pedro Alves  <palves@redhat.com>
1561
1562         * mdebugread.c (parse_partial_symbols): Use
1563         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1564
1565 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1566
1567         * linux-fork.c (scoped_switch_fork_info)
1568         <~scoped_switch_fork_info>: Fix incorrect variable name.
1569
1570 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1571
1572         * linux-fork.c (scoped_switch_fork_info)
1573         <scoped_switch_fork_info>: Make explicit.
1574         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1575
1576 2019-01-10  Tom Tromey  <tom@tromey.com>
1577
1578         * objfiles.h (objfile::reset_psymtabs): Update.
1579         * objfiles.c (objfile::objfile): Update.
1580         * psymtab.h (psymtab_storage::obstack): Update.
1581         (psymtab_storage::m_obstack): Use gdb::optional.
1582         (class psymtab_storage): Update comment.  Remove objfile
1583         parameter.
1584         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1585
1586 2019-01-10  Tom Tromey  <tom@tromey.com>
1587
1588         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1589         <free_psymtabs>: Now private.
1590         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1591         (allocate_psymtab): Use new method.
1592
1593 2019-01-10  Tom Tromey  <tom@tromey.com>
1594
1595         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1596         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1597         * mdebugread.c (parse_partial_symbols): Use
1598         allocate_dependencies.
1599         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1600         allocate_dependencies.
1601         (process_psymtab_comp_unit_reader)
1602         (build_type_psymtab_dependencies): Likewise.
1603         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1604
1605 2019-01-10  Tom Tromey  <tom@tromey.com>
1606
1607         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1608         PSYMBOL_SET_LANGUAGE.
1609         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1610
1611 2019-01-10  Tom Tromey  <tom@tromey.com>
1612
1613         * psymtab.h (psymtab_storage::obstack): New method.
1614         <m_obstack>: Rename from obstack; now private.
1615         * psymtab.c (psymtab_storage): Update.
1616         * dwarf2read.c (create_addrmap_from_index)
1617         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1618         Update.
1619
1620 2019-01-10  Tom Tromey  <tom@tromey.com>
1621
1622         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1623         * objfiles.h (objfile::reset_psymtabs): New method.
1624
1625 2019-01-10  Tom Tromey  <tom@tromey.com>
1626
1627         * symmisc.c (print_symbol_bcache_statistics): Update.
1628         (print_objfile_statistics): Update.
1629         * symfile.c (reread_symbols): Update.
1630         * psymtab.h (class psymtab_storage): New.
1631         * psymtab.c (psymtab_storage): New constructor.
1632         (~psymtab_storage): New destructor.
1633         (require_partial_symbols): Update.
1634         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1635         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1636         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1637         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1638         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1639         (start_psymtab_common, end_psymtab_common)
1640         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1641         (allocate_psymtab): Update.
1642         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1643         Update.
1644         (dump_psymtab_addrmap, maintenance_print_psymbols)
1645         (maintenance_check_psymtabs): Update.
1646         (class objfile_psymtabs): Move to objfiles.h.
1647         * psympriv.h (discard_psymtab): Now inline.
1648         (psymtab_discarder::psymtab_discarder): Update.
1649         (psymtab_discarder::~psymtab_discarder): Update.
1650         (ALL_OBJFILE_PSYMTABS): Rewrite.
1651         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1652         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1653         Remove fields.
1654         <partial_symtabs>: New field.
1655         (class objfile_psymtabs): Move from psymtab.h.  Update.
1656         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1657         psymbol_cache.
1658         (objfile::~objfile): Don't destroy psymbol_cache.
1659         * mdebugread.c (parse_partial_symbols): Update.
1660         * dwarf2read.c (create_addrmap_from_index)
1661         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1662         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1663         (add_partial_subprogram, dwarf2_ranges_read): Update.
1664         * dwarf-index-write.c (write_address_map)
1665         (write_one_signatured_type, recursively_write_psymbols)
1666         (class debug_names, class debug_names, write_psymtabs_to_index):
1667         Update.
1668
1669 2019-01-10  Tom Tromey  <tom@tromey.com>
1670
1671         * symtab.h (SYMBOL_SET_NAMES): Update.
1672         (symbol_set_names): Update.
1673         (MSYMBOL_SET_NAMES): Update.
1674         * symtab.c (symbol_set_names): Change argument to be an
1675         objfile_per_bfd_storage.
1676         * psymtab.c (add_psymbol_to_bcache): Update.
1677         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1678
1679 2019-01-10  Tom Tromey  <tom@tromey.com>
1680
1681         * symtab.c (create_demangled_names_hash): Change argument to be an
1682         objfile_per_bfd_storage.
1683         (symbol_set_names): Update.
1684
1685 2019-01-10  Tom Tromey  <tom@tromey.com>
1686
1687         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1688         init_psymbol_list.
1689         * psymtab.c (init_psymbol_list): Do nothing if already called.
1690         * psympriv.h (init_psymbol_list): Add comment.
1691         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1692         init_psymbol_list.
1693         * dbxread.c (dbx_symfile_read): Unconditionally call
1694         init_psymbol_list.
1695
1696 2019-01-10  Tom Tromey  <tom@tromey.com>
1697
1698         * xcoffread.c (scan_xcoff_symtab): Update.
1699         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1700         "where".
1701         * mdebugread.c (parse_partial_symbols)
1702         (handle_psymbol_enumerators): Update.
1703         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1704         * dbxread.c (read_dbx_symtab): Update.
1705         * psympriv.h (psymbol_placement): New enum.
1706         (add_psymbol_to_list): Update.
1707
1708 2019-01-10  Tom Tromey  <tom@tromey.com>
1709
1710         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1711         static_psymbols parameters.
1712         (scan_xcoff_symtab): Update.
1713         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1714         static_psymbols parameters.
1715         * psympriv.h (start_psymtab_common): Update.
1716         * mdebugread.c (parse_partial_symbols): Update.
1717         * dwarf2read.c (create_partial_symtab): Update.
1718         * dbxread.c (read_dbx_symtab): Update.
1719         (start_psymtab): Remove global_psymbols and static_psymbols
1720         parameters.
1721
1722 2019-01-10  Tom Tromey  <tom@tromey.com>
1723
1724         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1725         * psymtab.c (allocate_psymtab): Add comment.
1726         * psympriv.h (allocate_psymtab): Add comment.
1727         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1728         initializations.
1729         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1730
1731 2019-01-10  Tom Tromey  <tom@tromey.com>
1732
1733         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1734         Don't declare.
1735         * mipsread.c: Include mdebugread.h.
1736         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1737         Declare.
1738         * elfread.c: Include mdebugread.h.
1739
1740 2019-01-09  Tom Tromey  <tom@tromey.com>
1741
1742         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1743         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1744         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1745         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1746         (psym_lookup_symbol, psym_find_last_source_symtab)
1747         (psym_forget_cached_source_info, psym_print_stats)
1748         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1749         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1750         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1751         (psym_find_compunit_symtab_by_address)
1752         (maintenance_print_psymbols, maintenance_info_psymtabs)
1753         (maintenance_check_psymtabs): Use ranged for.
1754         * psymtab.h (class objfile_psymtabs): New.
1755         (require_partial_symbols): Return objfile_psymtabs.
1756         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1757
1758 2019-01-09  Tom Tromey  <tom@tromey.com>
1759
1760         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1761         (find_pc_mapped_section, list_overlays_command)
1762         (map_overlay_command, unmap_overlay_command)
1763         (simple_overlay_update): Use all_objfiles.
1764         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1765         * printcmd.c (info_symbol_command): Use all_objfiles.
1766         * objfiles.h (ALL_OBJSECTIONS): Remove.
1767         * maint.c (maintenance_translate_address): Use all_objfiles.
1768         * gcore.c (gcore_create_callback): Use all_objfiles.
1769         (objfile_find_memory_regions): Likewise.
1770
1771 2019-01-09  Tom Tromey  <tom@tromey.com>
1772
1773         * symtab.c (find_line_symtab, info_sources_command)
1774         (make_source_files_completion_list): Use objfile_compunits.
1775         * source.c (select_source_symtab): Use objfile_compunits.
1776         * objfiles.h (struct objfile): Update comment.
1777         (ALL_OBJFILES): Remove.
1778         (ALL_FILETABS): Remove.
1779         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
1780         objfile_compunits.
1781
1782 2019-01-09  Tom Tromey  <tom@tromey.com>
1783
1784         * symmisc.c (print_objfile_statistics, dump_objfile)
1785         (maintenance_print_symbols): Use compunit_filetabs.
1786         * source.c (forget_cached_source_info_for_objfile): Use
1787         compunit_filetabs.
1788         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
1789         (ALL_FILETABS): Use compunit_filetabs.
1790         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
1791         * coffread.c (coff_symtab_read): Use compunit_filetabs.
1792
1793 2019-01-09  Tom Tromey  <tom@tromey.com>
1794
1795         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
1796         (compunit_filetabs): New.
1797         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
1798         compunit_filetabs.
1799         (info_sources_command, make_source_files_completion_list): Remove
1800         declaration.
1801         * symmisc.c (print_objfile_statistics, dump_objfile)
1802         (maintenance_print_symbols): Remove declaration.
1803         (maintenance_info_symtabs): Use compunit_filetabs.
1804         (maintenance_info_line_tables): Likewise.
1805         * source.c (select_source_symtab): Change local variable name.
1806         (forget_cached_source_info_for_objfile): Remove declaration.
1807         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
1808         * objfiles.c (objfile_relocate1): Remove declaration.
1809         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1810         declaration.
1811         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
1812         * coffread.c (coff_symtab_read): Remove declaration.
1813         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1814         compunit_filetabs.
1815
1816 2019-01-09  Tom Tromey  <tom@tromey.com>
1817
1818         * symtab.c (lookup_objfile_from_block)
1819         (find_pc_sect_compunit_symtab, search_symbols)
1820         (default_collect_symbol_completion_matches_break_on): Use
1821         objfile_compunits.
1822         * objfiles.h (ALL_COMPUNITS): Remove.
1823         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
1824         * cp-support.c (add_symbol_overload_list_qualified): Use
1825         objfile_compunits.
1826         * ada-lang.c (ada_collect_symbol_completion_matches)
1827         (ada_add_global_exceptions): Use objfile_compunits.
1828
1829 2019-01-09  Tom Tromey  <tom@tromey.com>
1830
1831         * source.c (select_source_symtab)
1832         (forget_cached_source_info_for_objfile): Remove declaration.
1833         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1834         declaration.
1835         * maint.c (count_symtabs_and_blocks): Remove declaration.
1836         * cp-support.c (add_symbol_overload_list_qualified): Remove
1837         declaration.
1838         * coffread.c (coff_symtab_read): Remove declaration.
1839         * symtab.c (lookup_symbol_in_objfile_symtabs)
1840         (basic_lookup_transparent_type_1): Use objfile_compunits.
1841         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
1842         (info_sources_command, search_symbols)
1843         (default_collect_symbol_completion_matches_break_on)
1844         (make_source_files_completion_list): Remove declaration.
1845         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
1846         (ada_collect_symbol_completion_matches)
1847         (ada_add_global_exceptions): Remove declaration.
1848         * linespec.c (iterate_over_all_matching_symtabs): Use
1849         objfile_compunits.
1850         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
1851         (class objfile_compunits): New.
1852         (ALL_COMPUNITS): Use objfile_compunits.
1853         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
1854         (maintenance_check_symtabs, maintenance_info_line_tables): Use
1855         objfile_compunits.
1856         * objfiles.c (objfile_relocate1): Use objfile_compunits.
1857
1858 2019-01-09  Tom Tromey  <tom@tromey.com>
1859
1860         * symtab.c (search_symbols)
1861         (default_collect_symbol_completion_matches_break_on): Use
1862         objfile_msymbols.
1863         * ada-lang.c (ada_lookup_simple_minsym)
1864         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
1865         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
1866         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
1867         objfile_msymbols.
1868         * coffread.c (coff_symfile_read): Use objfile_msymbols.
1869         * symmisc.c (dump_msymbols): Use objfile_msymbols.
1870         * objc-lang.c (find_methods): Use objfile_msymbols.
1871         (info_selectors_command, info_classes_command): Likewise.
1872         * stabsread.c (scan_file_globals): Use objfile_msymbols.
1873         * objfiles.h (class objfile_msymbols): New.
1874         (ALL_OBJFILE_MSYMBOLS): Remove.
1875         (ALL_MSYMBOLS): Remove.
1876
1877 2019-01-09  Tom Tromey  <tom@tromey.com>
1878
1879         * common/next-iterator.h (next_adapter): Add Iterator template
1880         parameter.
1881         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
1882         (class all_objfiles_safe): New.
1883         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
1884         * objfiles.c (put_objfile_before): Update comment.
1885         (add_separate_debug_objfile): Likewise.
1886         (free_all_objfiles): Use all_objfiles_safe.
1887         (objfile_purge_solibs): Likewise.
1888
1889 2019-01-09  Tom Tromey  <tom@tromey.com>
1890
1891         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1892         (expand_symtab_containing_pc, lookup_static_symbol)
1893         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
1894         (find_symbol_at_address, find_line_symtab, find_main_name): Use
1895         all_objfiles.
1896         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
1897         * breakpoint.c (create_overlay_event_breakpoint)
1898         (create_longjmp_master_breakpoint)
1899         (create_std_terminate_master_breakpoint)
1900         (create_exception_master_breakpoint): Use all_objfiles.
1901         * linux-thread-db.c (try_thread_db_load_from_pdir)
1902         (has_libpthread): Use all_objfiles.
1903         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
1904         * linespec.c (iterate_over_all_matching_symtabs)
1905         (search_minsyms_for_name): Use all_objfiles.
1906         * maint.c (maintenance_info_sections): Use all_objfiles.
1907         * main.c (captured_main_1): Use all_objfiles.
1908         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
1909         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
1910         * guile/scm-pretty-print.c
1911         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
1912         * solib-spu.c (append_ocl_sos): Use all_objfiles.
1913         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
1914         (maintenance_print_msymbols): Use all_objfiles.
1915         * source.c (select_source_symtab): Use all_objfiles.
1916         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
1917         * symfile.c (remove_symbol_file_command)
1918         (expand_symtabs_matching, map_symbol_filenames): Use
1919         all_objfiles.
1920         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
1921         all_objfiles.
1922         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
1923         * objc-lang.c (find_methods): Use all_objfiles.
1924         * objfiles.c (have_partial_symbols, have_full_symbols)
1925         (have_minimal_symbols, qsort_cmp)
1926         (default_iterate_over_objfiles_in_search_order): Use
1927         all_objfiles.
1928         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
1929         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
1930         (maintenance_check_psymtabs): Use all_objfiles.
1931         (ALL_PSYMTABS): Remove.
1932         * compile/compile-object-run.c (do_module_cleanup): Use
1933         all_objfiles.
1934         * blockframe.c (find_pc_partial_function): Use all_objfiles.
1935         * cp-support.c (add_symbol_overload_list_qualified): Use
1936         all_objfiles.
1937         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1938         Use all_objfiles.
1939         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
1940         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
1941         all_objfiles.
1942         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1943         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
1944         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1945         Uses all_objfiles.
1946         * solib.c (solib_read_symbols): Use all_objfiles
1947
1948 2019-01-09  Tom Tromey  <tom@tromey.com>
1949
1950         * probe.c (parse_probes_in_pspace): Use all_objfiles.
1951         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
1952         all_objfiles.
1953         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
1954         * symmisc.c (print_symbol_bcache_statistics)
1955         (print_objfile_statistics, maintenance_print_objfiles)
1956         (maintenance_info_symtabs, maintenance_check_symtabs)
1957         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
1958         all_objfiles.
1959         * source.c (forget_cached_source_info): Use all_objfiles.
1960         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
1961         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1962         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
1963         * objfiles.c (update_section_map): Use all_objfiles.
1964         (shared_objfile_contains_address_p): Likewise.
1965         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
1966         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
1967
1968 2019-01-09  Tom Tromey  <tom@tromey.com>
1969
1970         * common/next-iterator.h: New file.
1971         * objfiles.h (class all_objfiles): New.
1972         (struct objfile_iterator): New.
1973
1974 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1975
1976         * NEWS: Move the description of the changed "frame", "select-frame",
1977          and "info frame" commands to the Changed commands section.
1978
1979 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
1980
1981         * gdbtypes.c (check_stub_method_group): Remove handling of old
1982         mangling schemes.
1983         * linespec.c (find_methods): Likewise.
1984         * stabsread.c (read_member_functions): Likewise.
1985         * valops.c (search_struct_method): Likewise.
1986         (value_struct_elt_for_reference): Likewise.
1987         * NEWS: Mention this change.
1988
1989 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1990
1991         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
1992         print_source_lines.
1993         * source.c (print_source_lines_base): Update line number check.
1994         (print_source_lines): New function.
1995         (source_lines_range::source_lines_range): New function.
1996         * source.h (class source_lines_range): New class.
1997         (print_source_lines): New declaration.
1998
1999 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2000
2001         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2002
2003 2019-01-08  Tom Tromey  <tom@tromey.com>
2004             Simon Marchi  <simon.marchi@ericsson.com>
2005
2006         PR gdb/24060
2007         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2008         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2009         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2010         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2011         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2012         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2013
2014 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2015
2016         * source.c (select_source_symtab): Move header comment to
2017         declaration in source.h.
2018         (forget_cached_source_info_for_objfile): Likewise.
2019         (forget_cached_source_info): Likewise.
2020         (identify_source_line): Likewise.
2021         * source.h (identify_source_line): Move declaration from symtab.h
2022         and add comment from source.c
2023         (print_source_lines): Likewise.
2024         (forget_cached_source_info_for_objfile): Likewise.
2025         (forget_cached_source_info): Likewise.
2026         (select_source_symtab): Likewise.
2027         (enum print_source_lines_flag): Move definition from symtab.h.
2028         * symtab.h (identify_source_line): Move declaration to source.h.
2029         (print_source_lines): Likewise.
2030         (forget_cached_source_info_for_objfile): Likewise.
2031         (forget_cached_source_info): Likewise.
2032         (select_source_symtab): Likewise.
2033         (enum print_source_lines_flag): Move definition to source.h.
2034         * tui/tui-hooks.c: Add 'source.h' include.
2035
2036 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2037
2038         * source.c (print_source_lines_base): Handle requests to print
2039         reverse line number sequences, and guard against empty lines
2040         string.
2041
2042 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2043
2044         * source.c (print_source_lines_base): Fix skip of '\r' if next
2045         character is '\n'.
2046
2047 2019-01-06  Tom Tromey  <tom@tromey.com>
2048
2049         * c-exp.y (struct c_parse_state) <macro_original_text,
2050         expansion_obstack>: New member.
2051         (macro_original_text, expansion_obstack): Remove globals.
2052         (scan_macro_expansion, scanning_macro_expansion)
2053         (finished_macro_expansion): Update.
2054         (scan_macro_cleanup): Remove.
2055         (yylex, c_parse): Update.
2056
2057 2019-01-06  Tom Tromey  <tom@tromey.com>
2058
2059         * c-exp.y (struct c_parse_state) <strings>: New member.
2060         (operator_stoken): Update.
2061
2062 2019-01-06  Tom Tromey  <tom@tromey.com>
2063
2064         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2065         (union type_stack_elt) <typelist_val>: Now a pointer to
2066         std::vector.
2067         (type_stack_cleanup): Don't declare.
2068         (push_typelist): Update.
2069         * parse.c (pop_typelist): Return a std::vector.
2070         (push_typelist): Take a std::vector.
2071         (follow_types): Update.  Do not free args.
2072         (type_stack_cleanup): Remove.
2073         * c-exp.y (struct c_parse_state): New.
2074         (cpstate): New global.
2075         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2076         (nonempty_typelist): Update.
2077         (func_mod): Create a new vector.
2078         (c_parse): Create a c_parse_state.
2079         (check_parameter_typelist): Do not delete params.
2080         (function_method): Update.  Do not delete type_list.
2081
2082 2019-01-06  Tom Tromey  <tom@tromey.com>
2083
2084         PR gdb/28155:
2085         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2086         check_typedef.
2087         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2088         (print_return_value): Likewise.
2089
2090 2019-01-05  Tom Tromey  <tom@tromey.com>
2091
2092         * contrib/cleanup_check.py: Remove.
2093         * contrib/gcc-with-excheck: Remove.
2094         * contrib/exsummary.py: Remove.
2095         * contrib/excheck.py: Remove.
2096
2097 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2098
2099         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2100         NULL. Initialize tpprev to NULL instead of assigning it
2101         to NULL on the next statement.
2102         * windows-nat.c (windows_delete_thread): Remove check for
2103         main_thread_id before printing thread exit notifications.
2104         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2105         Remove thread ID check against main_thread_id.
2106         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2107         windows_delete_thread.
2108         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2109
2110 2019-01-04  Tom Tromey  <tom@tromey.com>
2111
2112         * compile/compile.c (_initialize_compile): Use upper case for
2113         metasyntactic variables.
2114         * symmisc.c (_initialize_symmisc): Use upper case for
2115         metasyntactic variables.
2116         * psymtab.c (_initialize_psymtab): Use upper case for
2117         metasyntactic variables.
2118         * demangle.c (demangle_command): Use upper case for metasyntactic
2119         variables.
2120         (_initialize_demangler): Likewise.
2121         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2122         variables.
2123
2124 2019-01-03  Tom Tromey  <tom@tromey.com>
2125
2126         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2127
2128 2019-01-03  Tom Tromey  <tom@tromey.com>
2129
2130         * python/py-symtab.c (salpy_str): Update.
2131         (struct salpy_sal_object) <symtab>: Now a PyObject.
2132         (salpy_dealloc): Update.
2133         (del_objfile_sal): Use gdbpy_ref.
2134
2135 2019-01-03  Tom Tromey  <tom@tromey.com>
2136
2137         * python/py-type.c (convert_field): Use new_reference.  Return
2138         gdbpy_ref.
2139         (make_fielditem): Return gdbpy_ref.
2140         (typy_fields): Update.
2141         (typy_getitem): Update.
2142         (field_name): Return gdbpy_ref.  Use new_reference.
2143         (typy_iterator_iternext): Update.
2144
2145 2019-01-03  Tom Tromey  <tom@tromey.com>
2146
2147         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2148
2149 2019-01-03  Tom Tromey  <tom@tromey.com>
2150
2151         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2152         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2153         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2154         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2155         (pspy_set_type_printers): Likewise.
2156         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2157         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2158         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2159         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2160         (objfpy_set_type_printers): Likewise.
2161
2162 2019-01-03  Tom Tromey  <tom@tromey.com>
2163
2164         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2165         (gdbpy_print_stack): Use gdbpy_err_fetch.
2166         * python/python-internal.h (class gdbpy_err_fetch): New class.
2167         (class gdbpy_enter) <m_error_type, m_error_value,
2168         m_error_traceback>: Remove.
2169         <m_error>: New member.
2170         (gdbpy_exception_to_string): Don't declare.
2171         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2172         * python/py-value.c (convert_value_from_python): Use
2173         gdbpy_err_fetch.
2174         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2175         gdbpy_exception_to_string.
2176         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2177         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2178         gdbpy_err_fetch.
2179
2180 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2181
2182         * linux-nat.c (delete_lwp_cleanup): Delete.
2183         (struct lwp_deleter): New struct.
2184         (lwp_info_up): New typedef.
2185         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2186         lwp_info_up.
2187
2188 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2189
2190         * linux-fork.c (class scoped_switch_fork_info): New class.
2191         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2192
2193 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2194
2195         * valops.c (find_overload_match): Remove use of null_cleanup, and
2196         calls to do_cleanups.
2197
2198 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2199
2200         * compile/compile-cplus-types.c
2201         (compile_cplus_instance::decl_name): Handle changes to
2202         cp_func_name.
2203         * cp-support.c (cp_func_name): Update header comment, update
2204         return type.
2205         * cp-support.h (cp_func_name): Update return type in declaration.
2206         * valops.c (find_overload_match): Move temp_func local to top
2207         level of function and change its type.  Use temp_func to hold and
2208         delete temporary string obtained from cp_func_name.
2209
2210 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2211
2212         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2213         gdb::char_vector, remove cleanup, and update uses of `msg`.
2214
2215 2019-01-03  Jim Wilson  <jimw@sifive.com>
2216
2217         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2218
2219 2019-01-02  Tom Tromey  <tom@tromey.com>
2220
2221         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2222         (tdesc_parse_xml): Remove cleanups.
2223         * target-descriptions.h (make_cleanup_free_target_description):
2224         Don't declare.
2225         (target_desc_deleter): New struct.
2226         (target_desc_up): New typedef.
2227         * target-descriptions.c (target_desc_deleter::operator()): Rename
2228         from free_target_description.
2229         (make_cleanup_free_target_description): Remove.
2230
2231 2019-01-02  Tom Tromey  <tom@tromey.com>
2232
2233         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2234         constructor, destructor.
2235         (linespec_parser): Remove typedef.
2236         (~linespec_parser): Rename from linespec_parser_delete.
2237         (linespec_lex_to_end, linespec_complete_label)
2238         (linespec_complete): Update.
2239         (decode_line_full): Remove cleanups.
2240         (decode_line_1): Update.
2241
2242 2019-01-02  Tom Tromey  <tom@tromey.com>
2243
2244         * python/python-internal.h (inferior_to_inferior_object): Change
2245         return type.
2246         * python/py-exitedevent.c (create_exited_event_object): Update.
2247         * python/py-inferior.c (inferior_to_inferior_object): Return
2248         gdbpy_ref.
2249         (python_new_inferior, python_inferior_deleted)
2250         (thread_to_thread_object, delete_thread_object)
2251         (build_inferior_list, gdbpy_selected_inferior): Update.
2252         * python/py-infthread.c (create_thread_object): Update.  Also fail
2253         if inferior_to_inferior_object fails.
2254
2255 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2256
2257         * inferior.h (class inferior) <displaced_step_state>: New field.
2258         * infrun.h (struct displaced_step_state): Move here from
2259         infrun.c.  Initialize fields, add constructor.
2260         <inf>: Remove field.
2261         <reset>: New method.
2262         * infrun.c (struct displaced_step_inferior_state): Move to
2263         infrun.h.
2264         (displaced_step_inferior_states): Remove.
2265         (get_displaced_stepping_state): Adust.
2266         (displaced_step_in_progress_any_inferior): Adjust.
2267         (displaced_step_in_progress_thread): Adjust.
2268         (displaced_step_in_progress): Adjust.
2269         (add_displaced_stepping_state): Remove.
2270         (get_displaced_step_closure_by_addr): Adjust.
2271         (remove_displaced_stepping_state): Remove.
2272         (infrun_inferior_exit): Call displaced_step_state.reset.
2273         (use_displaced_stepping): Don't check for NULL.
2274         (displaced_step_prepare_throw): Call
2275         get_displaced_stepping_state.
2276         (displaced_step_fixup): Don't check for NULL.
2277         (prepare_for_detach): Don't check for NULL.
2278
2279 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2280
2281         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2282          in case of call that did not complete.
2283
2284 2019-01-02  Andrey Utkin  <autkin@undo.io>
2285
2286         * symfile.c (find_separate_debug_file): Fix search of debug files for
2287         remote debuggee.
2288
2289 2019-01-02  Tom Tromey  <tom@tromey.com>
2290
2291         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2292         indentation.
2293         * python/py-frame.c (frapy_older): Remove cast.
2294         (frapy_newer): Likewise.
2295         * python/py-breakpoint.c (local_setattro): Remove cast.
2296         * python/py-arch.c (archpy_name): Remove local variable.
2297         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2298
2299 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2300
2301         * unittests/basic_string_view/element_access/char/empty.cc:
2302         Fix year range in copyright header.
2303
2304 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2305
2306         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2307         Delete.
2308         <operator==>: Update with for removed field.
2309         <hash>: Likewise.
2310         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2311         <isa_features>: ...this.
2312         <abi_features>: New field.
2313         (riscv_isa_flen): Update comment.
2314         (riscv_abi_xlen): New declaration.
2315         (riscv_abi_flen): New declaration.
2316         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2317         isa_features.
2318         (riscv_abi_xlen): New function.
2319         (riscv_isa_flen): Update to get answer from isa_features.
2320         (riscv_abi_flen): New function.
2321         (riscv_has_fp_abi): Update to get answer from abi_features.
2322         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2323         xlen and flen.
2324         (riscv_call_info) <xlen, flen>: Update comment.
2325         (riscv_call_arg_struct): Remove invalid assertions
2326         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2327         is removed.
2328         (riscv_gdbarch_init): Gather isa features and abi features
2329         separately, ensure both match on the gdbarch when reusing an old
2330         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2331         a target with 64-bit float hardware.
2332
2333 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2334
2335         * source.c (search_command_helper): Stop reverse search
2336         when line 1 has been searched.
2337
2338 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2339
2340         * record-full.c (record_full_base_target::close): Rewrite
2341         record_full_core_buf_list free logic.
2342
2343 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2344
2345         * break-catch-syscall.c (print_one_catch_syscall): xfree
2346         the last text.
2347
2348 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2349
2350         * top.c (print_gdb_version): Update Copyright year in version
2351         message.
2352
2353 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2354
2355         Update copyright year range in all GDB files.
2356
2357 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2358
2359         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2360
2361 For older changes see ChangeLog-2018.
2362 \f
2363 Local Variables:
2364 mode: change-log
2365 left-margin: 8
2366 fill-column: 74
2367 version-control: never
2368 coding: utf-8
2369 End:
2370