gdb/ChangeLog

   1 2018-05-31  Uros Bizjak  <ubizjak@gmail.com>
   2
   3         * nat/linux-ptrace.h [__alpha__]
   4         (GDB_ARCH_IS_TRAP_BRKPT, GDB_ARCH_IS_TRAP_HWBKPT): Remove
   5         definitions.
   6
   7 2018-05-31  Maciej W. Rozycki  <macro@mips.com>
   8
   9         * arch-utils.c (gdbarch_info_fill): Set `default_byte_order' to
  10         the endianness selected.
  11         * NEWS: Document `set endian auto' mode operation update.
  12
  13 2018-05-31  Alan Hayward  <alan.hayward@arm.com>
  14
  15         * Makefile.in: Add new header.
  16         * gdb/arch/aarch64.h (sve_vg_from_vl): New macro.
  17         (sve_vl_from_vg): Likewise.
  18         (sve_vq_from_vl): Likewise.
  19         (sve_vl_from_vq): Likewise.
  20         (sve_vq_from_vg): Likewise.
  21         (sve_vg_from_vq): Likewise.
  22         * configure.nat: Add new c file.
  23         * nat/aarch64-sve-linux-ptrace.c: New file.
  24         * nat/aarch64-sve-linux-ptrace.h: New file.
  25
  26 2018-05-31  Alan Hayward  <alan.hayward@arm.com>
  27
  28         * aarch64-linux-nat.c (aarch64_linux_read_description):
  29         Add parmeter zero.
  30         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
  31         Likewise.
  32         * aarch64-tdep.c (tdesc_aarch64_list): Add.
  33         (aarch64_read_description): Use VQ to index tdesc_aarch64_list.
  34         (aarch64_gdbarch_init): Add parmeter zero.
  35         * aarch64-tdep.h (aarch64_read_description): Add VQ parmeter.
  36         * arch/aarch64.c (aarch64_create_target_description): Check VQ.
  37         * arch/aarch64.h (aarch64_create_target_description): Add VQ.
  38         parmeter.
  39         * doc/gdb.texinfo: Describe SVE feature
  40         * features/aarch64-sve.c: New file.
  41
  42 2018-05-31  Omair Javaid  <omair.javaid@linaro.org>
  43
  44         PR gdb/23210
  45         * gdbarch.sh (significant_addr_bit): Default to zero when
  46         not set by target architecture.
  47         * gdbarch.c: Re-generated.
  48         * utils.c (address_significant): Update.
  49
  50 2018-05-30  Joel Brobecker  <brobecker@adacore.com>
  51
  52         * stack.c (func_command): Remove trailing newline in call to error.
  53
  54 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
  55
  56         * regcache.h (regcache_raw_collect): Remove, update callers to
  57         use regcache::raw_collect.
  58         * regcache.c (regcache_raw_collect): Remove.
  59
  60 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
  61
  62         * regcache.h (regcache_raw_supply): Remove, update callers to
  63         use detached_regcache::raw_supply.
  64         * regcache.c (regcache_raw_supply): Remove.
  65
  66 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
  67
  68         * regcache.h (regcache_cooked_write_part): Remove, update
  69         callers to use regcache::cooked_write_part.
  70         * regcache.c (regcache_cooked_write_part): Remove.
  71
  72 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
  73
  74         * regcache.h (regcache_cooked_read_part): Remove, update callers
  75         to use readable_regcache::cooked_read_part.
  76         * regcache.c (regcache_cooked_read_part): Remove.
  77
  78 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
  79
  80         * regcache.h (regcache_cooked_read_value): Remove, update
  81         callers to use readable_regcache::cooked_read_value.
  82         * regcache.c (regcache_cooked_read_value): Remove.
  83
  84 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
  85
  86         * regcache.h (regcache_cooked_write): Remove, update callers to
  87         use regcache::cooked_write.
  88         * regcache.c (regcache_cooked_write): Remove.
  89
  90 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
  91
  92         * regcache.h (regcache_invalidate): Remove, update callers to
  93         use detached_regcache::invalidate instead.
  94         * regcache.c (regcache_invalidate): Remove.
  95
  96 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
  97
  98         * regcache.h (regcache_raw_write_part): Remove, update callers
  99         to use regcache::raw_write_part instead.
 100         * regcache.c (regcache_raw_write_part): Remove.
 101
 102 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
 103
 104         * regcache.h (regcache_raw_read_part): Remove, update callers to
 105         use readable_regcache::raw_read_part instead.
 106         * regcache.c (regcache_raw_read_part): Remove.
 107
 108 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
 109
 110         * regcache.h (regcache_cooked_read): Remove, update callers to
 111         use readable_regcache::cooked_read instead.
 112         * regcache.c (regcache_cooked_read): Remove.
 113
 114 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
 115
 116         * regcache.h (regcache_raw_write): Remove, update callers to use
 117         regcache::raw_write instead.
 118         * regcache.c (regcache_raw_write): Remove.
 119
 120 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
 121
 122         * regcache.h (regcache_raw_read): Remove, update callers to use
 123         readable_regcache::raw_read instead.
 124         * regcache.c (regcache_raw_read): Remove.
 125
 126 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
 127
 128         * regcache.h (regcache_raw_update): Remove, update callers to
 129         use readable_regcache::raw_update instead.
 130         * regcache.c (regcache_raw_update): Remove.
 131
 132 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
 133
 134         * regcache.h (regcache_register_status): Remove, update callers
 135         to use reg_buffer::get_register_status directly instead.
 136         * regcache.c (regcache_register_status): Remove.
 137
 138 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
 139
 140         * regcache.h (regcache_get_ptid): Remove, update all callers to
 141         call regcache::ptid instead.
 142         * regcache.c (regcache_get_ptid): Remove.
 143
 144 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
 145
 146         * Makefile.in (ALL_TARGET_OBS): Add or1k-tdep.o.
 147
 148 2018-05-30  Pedro Alves  <palves@redhat.com>
 149
 150         * common/common-exceptions.h (exception_rethrow): Use
 151         ATTRIBUTE_NORETURN.
 152
 153 2018-05-29  Simon Marchi  <simon.marchi@polymtl.ca>
 154
 155         * breakpoint.c (print_solib_event, check_status_catch_solib):
 156         Remove struct keyword in range-based for loops.
 157         * dbxread.c (find_corresponding_bincl_psymtab): Likewise.
 158         * dwarf2read.c (compute_delayed_physnames, rust_union_quirks);
 159         Likewise.
 160         * linespec.c (find_superclass_methods, search_minsyms_for_name):
 161         Likewise.
 162         * symfile.c (addr_info_make_relative): Likewise.
 163         * thread.c (value_in_thread_stack_temporaries): Likewise.
 164
 165 2018-05-29  Weimin Pan  <weimin.pan@oracle.com>
 166
 167         * minsyms.h (lookup_minimal_symbol_and_objfile): Remove declaration.
 168         * minsyms.c (lookup_minimal_symbol_and_objfile): Remove definition.
 169         * coff-pe-read.c (add_pe_forwarded_sym): Replace
 170         lookup_minimal_symbol_and_objfile with lookup_bound_minimal_symbol.
 171         * glibc-tdep.c (glibc_skip_solib_resolver): Likewise.
 172         * jit.c (jit_breakpoint_re_set_internal): Likewise.
 173         * printcmd.c (info_address_command): Likewise.
 174
 175 2018-05-29  Tom Tromey  <tom@tromey.com>
 176
 177         * windows-nat.c (handle_exception): Update fall-through comment.
 178
 179 2018-05-29  Tom Tromey  <tom@tromey.com>
 180
 181         * progspace.h (so_list_ptr): Remove typedef.  Don't declare VEC.
 182         (struct program_space) <added_solibs>: Now a std::vector.
 183         * breakpoint.c (print_solib_event): Update.
 184         (check_status_catch_solib): Update.
 185         * progspace.c (clear_program_space_solib_cache): Update.
 186         * solib.c (update_solib_list): Update.
 187
 188 2018-05-29  Tom Tromey  <tom@tromey.com>
 189
 190         * python/py-type.c (typy_richcompare): Update.
 191         * guile/scm-type.c (tyscm_equal_p_type_smob): Update.
 192         * gdbtypes.h (types_deeply_equal): Return bool.
 193         (types_equal): Likewise.
 194         * gdbtypes.c (type_equality_entry_d): Remove typedef.  Don't
 195         declare VEC.
 196         (check_types_equal): Change worklist to std::vector.  Return
 197         bool.
 198         (struct type_equality_entry): Add constructor.
 199         (compare_maybe_null_strings): Return bool.
 200         (check_types_worklist): Return bool.  Change worklist to
 201         std::vector.
 202         (types_deeply_equal): Use std::vector.
 203         (types_equal): Return bool.
 204         (compare_maybe_null_strings): Simplify.
 205
 206 2018-05-29  Tom Tromey  <tom@tromey.com>
 207
 208         * record-btrace.c (tp_t): Remove typedef.  Don't declare VEC.
 209
 210 2018-05-29  Tom Tromey  <tom@tromey.com>
 211
 212         * objc-lang.h: Don't include cp-support.h.
 213         * common/gdb_vecs.h (const_char_ptr): Remove typedef.  Don't
 214         declare VEC.
 215
 216 2018-05-27  Tom Tromey  <tom@tromey.com>
 217
 218         * Makefile.in (DEPFILES): Don't reference REMOTE_OBS.
 219
 220 2018-05-25  Tom Tromey  <tom@tromey.com>
 221
 222         * value.c (value::location): Initialize.
 223
 224 2018-05-25  Tom Tromey  <tom@tromey.com>
 225
 226         * dbxread.c (init_bincl_list): Remove.
 227         (bincl_list): Now a std::vector.
 228         (bincls_allocated, next_bincl): Remove.
 229         (free_bincl_list, do_free_bincl_list_cleanup)
 230         (make_cleanup_free_bincl_list): Remove.
 231         (dbx_read_symtab, elfstab_build_psymtabs): Use scoped_restore,
 232         unique_xmalloc_ptr.
 233         (find_corresponding_bincl_psymtab, read_dbx_symtab): Update.
 234         (struct header_file_location): Add constructor.
 235         (add_bincl_to_list): Remove.
 236
 237 2018-05-25  Tom Tromey  <tom@tromey.com>
 238
 239         * tui/tui.c (tui_enable): Update.
 240         * mi/mi-interp.c (mi_interp::init): Update.
 241         * interps.h (class interp) <name>: New method.
 242         <m_name>: Rename from name.
 243         (~scoped_restore_interp): Update.
 244         * interps.c (interp::interp): Update.
 245         (interp_add, interp_set, interp_lookup_existing)
 246         (current_interp_named_p): Update.
 247
 248 2018-05-25  Tom Tromey  <tom@tromey.com>
 249
 250         * interps.c (interp_name): Remove.
 251         * mi/mi-interp.c (mi_interp::init): Update.
 252         * interps.h (interp_name): Remove.
 253         (~scoped_restore_interp): Update.
 254         * tui/tui.c (tui_enable): Update.
 255
 256 2018-05-25  Tom Tromey  <tom@tromey.com>
 257
 258         * utils.c (fputs_maybe_filtered): Update.
 259         * linespec.c (decode_line_full): Update.
 260         * mi/mi-interp.c (mi_on_normal_stop_1, mi_tsv_modified)
 261         (mi_print_breakpoint_for_event, mi_solib_loaded)
 262         (mi_solib_unloaded, mi_command_param_changed, mi_memory_changed)
 263         (mi_user_selected_context_changed): Update.
 264         * mi/mi-main.c (mi_execute_command): Update.
 265         * cli/cli-script.c (execute_control_command): Update.
 266         * python/python.c (execute_gdb_command): Update.
 267         * solib.c (info_sharedlibrary_command): Update.
 268         * interps.c (interp_ui_out): Remove.
 269         * interps.h (interp_ui_out): Remove.
 270
 271 2018-05-25  Tom Tromey  <tom@tromey.com>
 272
 273         * tui/tui-interp.c (as_tui_interp): Use dynamic_cast.
 274         * mi/mi-interp.c (as_mi_interp): Use dynamic_cast.
 275         * cli/cli-interp.c (as_cli_interp): Use dynamic_cast.
 276
 277 2018-05-25  Tom Tromey  <tom@tromey.com>
 278
 279         * cli/cli-interp.c (safe_execute_command): Use scoped_restore.
 280         * interps.c (interp_exec): Use scoped_restore.
 281
 282 2018-05-25  Tom Tromey  <tom@tromey.com>
 283
 284         * remote.c (remote_target::remote_file_get): Use
 285         gdb::byte_vector.
 286         (remote_target::remote_file_put): Likewise.
 287
 288 2018-05-25  Tom Tromey  <tom@tromey.com>
 289
 290         * coff-pe-read.c (struct read_pe_section_data) <section_name>: Now
 291         a std::string.
 292         (get_pe_section_index, add_pe_exported_sym): Update.
 293         (read_pe_exported_syms): Use gdb::def_vector.
 294
 295 2018-05-25  Tom Tromey  <tom@tromey.com>
 296
 297         * frame.c (remove_prev_frame): Remove.
 298         (get_prev_frame_if_no_cycle): Use TRY/CATCH.
 299
 300 2018-05-25  Maciej W. Rozycki  <macro@mips.com>
 301
 302         * mips-linux-tdep.h (mips_supply_fpregset, mips_fill_fpregset):
 303         Remove prototypes.
 304         * mips-linux-nat.c (supply_fpregset): Always call
 305         `mips64_supply_fpregset' rather than `mips_supply_fpregset'.
 306         (fill_fpregset): Always call `mips64_fill_fpregset' rather than
 307         `mips_fill_fpregset'.
 308         * mips-linux-tdep.c (mips_supply_fpregset)
 309         (mips_supply_fpregset_wrapper, mips_fill_fpregset)
 310         (mips_fill_fpregset_wrapper): Remove functions.
 311         (mips64_supply_fpregset, mips64_fill_fpregset): Update comments.
 312         (mips_linux_fpregset): Remove variable.
 313         (mips_linux_iterate_over_regset_sections): Use
 314         `mips64_linux_fpregset' in place of `mips_linux_fpregset'.
 315         (mips_linux_o32_sigframe_init): Remove comment.
 316
 317 2018-05-25  Pedro Alves  <palves@redhat.com>
 318
 319         * remote.c (struct vCont_action_support, MAXTHREADLISTRESULTS)
 320         (struct readahead_cache, struct packet_reg, struct
 321         remote_arch_state, class remote_state): Move higher up in the
 322         file.
 323         (remote_target::m_remote_state): Now an object instead of a pointer.
 324         (remote_target::get_remote_state): Adjust.
 325
 326 2018-05-24  Andrew Burgess  <andrew.burgess@embecosm.com>
 327
 328         * stack.c (select_and_print_frame): Delete.
 329         (struct function_bounds): Move struct within function.
 330         (func_command): Most content moved into new function
 331         find_frame_for_function, use new function, print result, add
 332         function comment.
 333         (find_frame_for_function): New function, now returns a result.
 334
 335 2018-05-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 336
 337         * stack.c (iterate_over_block_arg_vars): Fix comment.
 338         (print_frame_arg_vars): Pass stream in cb_data, not gdb_stdout.
 339
 340 2018-05-24  Andrew Burgess  <andrew.burgess@embecosm.com>
 341
 342         PR gdb/23203
 343         * frame.c
 344         (scoped_restore_selected_frame::scoped_restore_selected_frame):
 345         Define.
 346         (scoped_restore_selected_frame::~scoped_restore_selected_frame):
 347         Define.
 348         * frame.h (class scoped_restore_selected_frame): New class.
 349         * stack.c (print_frame_local_vars): Remove catching and rethrowing
 350         of any exception, use scoped_restore_selected_frame to restore the
 351         frame instead.
 352
 353 2018-05-24  Pedro Alves  <palves@redhat.com>
 354
 355         * darwin-nat.h (darwin_nat_target::create_inferior): Mark with
 356         override.
 357
 358 2018-05-23  Tom Tromey  <tom@tromey.com>
 359
 360         * complaints.c (struct complaints): Remove.
 361         (symfile_complaint_book): Remove.
 362         (series): New global.
 363         (complaint_internal): Update.
 364         (clear_complaints): Update.
 365
 366 2018-05-23  Tom Tromey  <tom@tromey.com>
 367
 368         * complaints.c (counters): New global.
 369         (struct complain): Remove.
 370         (struct complaints) <root>: Remove.
 371         (complaint_sentinel): Remove.
 372         (symfile_complaint_book): Update.
 373         (find_complaint) Remove.
 374         (complaint_internal, clear_complaints): Update.
 375
 376 2018-05-23  Tom Tromey  <tom@tromey.com>
 377
 378         * complaints.c (struct complain) <file, line>: Remove.
 379         (find_complaint): Remove file, line parameters.
 380         (complaint_internal): Update.
 381
 382 2018-05-23  Tom Tromey  <tom@tromey.com>
 383
 384         * complaints.c (vcomplaint): Remove.
 385         (complaint_internal) Merge in contents of vcomplaint.
 386
 387 2018-05-23  Tom Tromey  <tom@tromey.com>
 388
 389         * complaints.c (struct complaints) <explanation>: Remove.
 390         (symfile_explanations): Remove.
 391         (symfile_complaint_book): Update.
 392         (vcomplaint): Update.
 393         (struct explanation): Remove.
 394
 395 2018-05-23  Tom Tromey  <tom@tromey.com>
 396
 397         * complaints.c (symfile_complaints): Remove.
 398         (complaint_internal): Remove "complaints" parameter.
 399         (clear_complaints, vcomplaint): Remove "c" parameter.
 400         (get_complaints): Remove.
 401         * dwarf2read.c (dwarf2_statement_list_fits_in_line_number_section_complaint)
 402         (dwarf2_debug_line_missing_file_complaint)
 403         (dwarf2_debug_line_missing_end_sequence_complaint)
 404         (dwarf2_complex_location_expr_complaint)
 405         (dwarf2_const_value_length_mismatch_complaint)
 406         (dwarf2_section_buffer_overflow_complaint)
 407         (dwarf2_macro_malformed_definition_complaint)
 408         (dwarf2_invalid_attrib_class_complaint)
 409         (create_addrmap_from_index, dw2_symtab_iter_next)
 410         (dw2_expand_marked_cus)
 411         (dw2_debug_names_iterator::find_vec_in_debug_names)
 412         (dw2_debug_names_iterator::next, dw2_debug_names_iterator::next)
 413         (create_debug_type_hash_table, init_cutu_and_read_dies)
 414         (partial_die_parent_scope, add_partial_enumeration)
 415         (skip_one_die, fixup_go_packaging, quirk_rust_enum, process_die)
 416         (dwarf2_compute_name, dwarf2_physname, read_namespace_alias)
 417         (read_import_statement, read_file_scope, create_dwo_cu_reader)
 418         (create_cus_hash_table, create_dwp_hash_table)
 419         (inherit_abstract_dies, read_func_scope, read_call_site_scope)
 420         (dwarf2_rnglists_process, dwarf2_ranges_process)
 421         (dwarf2_add_type_defn, dwarf2_attach_fields_to_type)
 422         (dwarf2_add_member_fn, get_alignment, maybe_set_alignment)
 423         (handle_struct_member_die, process_structure_scope)
 424         (read_array_type, read_common_block, read_module_type)
 425         (read_tag_pointer_type, read_typedef, read_base_type)
 426         (read_subrange_type, load_partial_dies, partial_die_info::read)
 427         (partial_die_info::read, partial_die_info::read)
 428         (partial_die_info::read, read_checked_initial_length_and_offset)
 429         (dwarf2_string_attr, read_formatted_entries)
 430         (dwarf_decode_line_header)
 431         (lnp_state_machine::check_line_address, dwarf_decode_lines_1)
 432         (new_symbol, dwarf2_const_value_attr, lookup_die_type)
 433         (read_type_die_1, determine_prefix, dwarf2_get_ref_die_offset)
 434         (dwarf2_get_attr_constant_value, dwarf2_fetch_constant_bytes)
 435         (get_signatured_type, get_DW_AT_signature_type)
 436         (decode_locdesc, file_file_name, consume_improper_spaces)
 437         (skip_form_bytes, skip_unknown_opcode, dwarf_parse_macro_header)
 438         (dwarf_decode_macro_bytes, dwarf_decode_macros)
 439         (dwarf2_symbol_mark_computed, set_die_type)
 440         (read_attribute_value): Update.
 441         * stap-probe.c (handle_stap_probe, get_stap_base_address):
 442         Update.
 443         * dbxread.c (unknown_symtype_complaint)
 444         (lbrac_mismatch_complaint, repeated_header_complaint)
 445         (set_namestring, function_outside_compilation_unit_complaint)
 446         (read_dbx_symtab, process_one_symbol): Update.
 447         * gdbtypes.c (stub_noname_complaint): Update.
 448         * windows-nat.c (handle_unload_dll): Update.
 449         * coffread.c (coff_symtab_read, enter_linenos, decode_type)
 450         (decode_base_type): Update.
 451         * xcoffread.c (bf_notfound_complaint, ef_complaint)
 452         (eb_complaint, record_include_begin, record_include_end)
 453         (enter_line_range, xcoff_next_symbol_text, read_xcoff_symtab)
 454         (process_xcoff_symbol, read_symbol)
 455         (function_outside_compilation_unit_complaint)
 456         (scan_xcoff_symtab): Update.
 457         * machoread.c (macho_symtab_read, macho_add_oso_symfile): Update.
 458         * buildsym.c (finish_block_internal, make_blockvector)
 459         (end_symtab_get_static_block, augment_type_symtab): Update.
 460         * dtrace-probe.c (dtrace_process_dof)
 461         (dtrace_static_probe_ops::get_probes): Update.
 462         * complaints.h (struct complaint): Don't declare.
 463         (symfile_complaints): Remove.
 464         (complaint_internal): Remove "complaints" parameter.
 465         (complaint): Likewise.
 466         (clear_complaints): Likewise.
 467         * symfile.c (syms_from_objfile_1, finish_new_objfile)
 468         (reread_symbols): Update.
 469         * dwarf2-frame.c (dwarf2_restore_rule, execute_cfa_program)
 470         (dwarf2_frame_cache, decode_frame_entry): Update.
 471         * dwarf2loc.c (dwarf_reg_to_regnum): Update.
 472         * objc-lang.c (lookup_objc_class, lookup_child_selector)
 473         (info_selectors_command): Update.
 474         * macrotab.c (macro_include, check_for_redefinition)
 475         (macro_undef): Update.
 476         * objfiles.c (filter_overlapping_sections): Update.
 477         * stabsread.c (invalid_cpp_abbrev_complaint)
 478         (reg_value_complaint, stabs_general_complaint, dbx_lookup_type)
 479         (define_symbol, error_type, read_type, rs6000_builtin_type)
 480         (stabs_method_name_from_physname, read_member_functions)
 481         (read_cpp_abbrev, read_baseclasses, read_tilde_fields)
 482         (attach_fields_to_type, complain_about_struct_wipeout)
 483         (read_range_type, read_args, common_block_start)
 484         (common_block_end, cleanup_undefined_types_1, scan_file_globals):
 485         Update.
 486         * mdebugread.c (index_complaint, unknown_ext_complaint)
 487         (basic_type_complaint, bad_tag_guess_complaint)
 488         (bad_rfd_entry_complaint, unexpected_type_code_complaint)
 489         (reg_value_complaint, parse_symbol, parse_type, upgrade_type)
 490         (parse_procedure, parse_lines)
 491         (function_outside_compilation_unit_complaint)
 492         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref)
 493         (bad_tag_guess_complaint, reg_value_complaint): Update.
 494         * cp-support.c (demangled_name_complaint): Update.
 495         * macroscope.c (sal_macro_scope): Update.
 496         * dwarf-index-write.c (class debug_names): Update.
 497
 498 2018-05-23  Tom Tromey  <tom@tromey.com>
 499
 500         * complaints.c (clear_complaints): Remove "noisy" parameter.
 501         * complaints.h (clear_complaints): Update.
 502         * symfile.c (syms_from_objfile_1, finish_new_objfile)
 503         (reread_symbols): Update.
 504
 505 2018-05-23  Tom Tromey  <tom@tromey.com>
 506
 507         * complaints.c (enum complaint_series): Remove FIRST_MESSAGE,
 508         SUBSEQUENT_MESSAGE.
 509         (vcomplaint, clear_complaints): Update.
 510         (symfile_explanations): Remove some messages.
 511
 512 2018-05-23  Tom Tromey  <tom@tromey.com>
 513
 514         * complaints.c (internal_complaint): Remove.
 515         * complaints.h (internal_complaint): Remove.
 516
 517 2018-05-22  Maciej W. Rozycki  <macro@mips.com>
 518
 519         * i387-tdep.c (i387_collect_xsave): Make `i' unsigned.
 520
 521 2018-05-22  Pedro Alves  <palves@redhat.com>
 522
 523         * remote-fileio.c (remote_fileio_reply, remote_fileio_ioerror)
 524         (remote_fileio_badfd, remote_fileio_return_errno)
 525         (remote_fileio_return_success, remote_fileio_func_open)
 526         (remote_fileio_func_open, remote_fileio_func_close)
 527         (remote_fileio_func_read, remote_fileio_func_write)
 528         (remote_fileio_func_lseek, remote_fileio_func_rename)
 529         (remote_fileio_func_unlink, remote_fileio_func_stat)
 530         (remote_fileio_func_fstat, remote_fileio_func_gettimeofday)
 531         (remote_fileio_func_isatty, remote_fileio_func_system): Add
 532         remote_target parameter.
 533         (remote_fio_func_map) <func>: Add remote_target parameter.
 534         (do_remote_fileio_request, remote_fileio_request):
 535         * remote-fileio.h (remote_fileio_request):
 536         * remote-notif.c (remote_notif_ack, remote_notif_parse, ): Add
 537         remote_target parameter.
 538         (remote_notif_process, handle_notification): Adjust to pass down
 539         the remote.
 540         (remote_notif_state_allocate): Add remote_target parameter.  Save
 541         it.
 542         * remote-notif.h (struct remote_target): Forward declare.
 543         (struct notif_client) <parse, ack, can_get_pending_events>: Add
 544         remote_target parameter.
 545         (struct remote_notif_state) <remote>: New field.
 546         (remote_notif_ack, remote_notif_parse): Add remote_target
 547         parameter.
 548         (remote_notif_state_allocate, remote_notif_state_allocate): Add
 549         remote_target parameter.
 550         * remote.c (OPAQUETHREADBYTES, threadref, gdb_ext_thread_info)
 551         (threads_listing_context, rmt_thread_action, protocol_feature)
 552         (packet_reg, stop_reply, stop_reply_p, enum packet_support)
 553         (packet_result, struct threads_listing_context, remote_state):
 554         Move definitions and declarations higher up.
 555         (remote_target) <~remote_target>: Declare.
 556         (remote_download_command_source, remote_file_put, remote_file_get)
 557         (remote_file_delete, remote_hostio_pread, remote_hostio_pwrite)
 558         (remote_hostio_pread_vFile, remote_hostio_send_command)
 559         (remote_hostio_set_filesystem, remote_hostio_open)
 560         (remote_hostio_close, remote_hostio_unlink, remote_state)
 561         (get_remote_state, get_remote_packet_size, get_memory_packet_size)
 562         (get_memory_write_packet_size, get_memory_read_packet_size)
 563         (append_pending_thread_resumptions, remote_detach_1)
 564         (append_resumption, remote_resume_with_vcont)
 565         (add_current_inferior_and_thread, wait_ns, wait_as)
 566         (process_stop_reply, remote_notice_new_inferior)
 567         (process_initial_stop_replies, remote_add_thread)
 568         (btrace_sync_conf, remote_btrace_maybe_reopen)
 569         (remove_new_fork_children, kill_new_fork_children)
 570         (discard_pending_stop_replies, stop_reply_queue_length)
 571         (check_pending_events_prevent_wildcard_vcont)
 572         (discard_pending_stop_replies_in_queue, stop_reply)
 573         (remote_notif_remove_queued_reply, stop_reply *queued_stop_reply)
 574         (peek_stop_reply, remote_parse_stop_reply, remote_stop_ns)
 575         (remote_interrupt_as, remote_interrupt_ns)
 576         (remote_get_noisy_reply, remote_query_attached)
 577         (remote_add_inferior, remote_current_thread, get_current_thread)
 578         (set_thread, set_general_thread, set_continue_thread)
 579         (set_general_process, write_ptid)
 580         (remote_unpack_thread_info_response, remote_get_threadinfo)
 581         (parse_threadlist_response, remote_get_threadlist)
 582         (remote_threadlist_iterator, remote_get_threads_with_ql)
 583         (remote_get_threads_with_qxfer)
 584         (remote_get_threads_with_qthreadinfo, extended_remote_restart)
 585         (get_offsets, remote_check_symbols, remote_supported_packet)
 586         (remote_query_supported, remote_packet_size)
 587         (remote_serial_quit_handler, remote_detach_pid)
 588         (remote_vcont_probe, remote_resume_with_hc)
 589         (send_interrupt_sequence, interrupt_query)
 590         (remote_notif_get_pending_events, fetch_register_using_p)
 591         (send_g_packet, process_g_packet, fetch_registers_using_g)
 592         (store_register_using_P, store_registers_using_G)
 593         (set_remote_traceframe, check_binary_download)
 594         (remote_write_bytes_aux, remote_write_bytes, remote_read_bytes_1)
 595         (remote_xfer_live_readonly_partial, remote_read_bytes)
 596         (remote_send_printf, remote_flash_write, readchar)
 597         (remote_serial_write, putpkt, putpkt_binary, skip_frame)
 598         (read_frame, getpkt, getpkt_or_notif_sane_1, getpkt_sane)
 599         (getpkt_or_notif_sane, remote_vkill, remote_kill_k)
 600         (extended_remote_disable_randomization, extended_remote_run)
 601         (send_environment_packet, extended_remote_environment_support)
 602         (extended_remote_set_inferior_cwd, remote_write_qxfer)
 603         (remote_read_qxfer, push_stop_reply, vcont_r_supported)
 604         (packet_command): Now methods of ...
 605         (remote_target): ... this class.
 606         (m_remote_state) <remote_target>: New field.
 607         (struct remote_state) <stop_reply_queue,
 608         remote_async_inferior_event_token, wait_forever_enabled_p>: New
 609         fields.
 610         (remote_state::remote_state): Allocate stop_reply_queue.
 611         (remote_state): Delete global.
 612         (get_remote_state_raw): Delete.
 613         (remote_target::get_remote_state): Allocate m_remote_state on
 614         demand.
 615         (get_current_remote_target): New.
 616         (remote_ops, extended_remote_ops): Delete.
 617         (wait_forever_enabled_p, remote_async_inferior_event_token):
 618         Delete, moved to struct remote_state.
 619         (remote_target::close): Delete self.  Destruction bits split to
 620         ...
 621         (remote_target::~remote_target): ... this.
 622         (show_memory_packet_size): Adjust to use
 623         get_current_remote_target.
 624         (struct protocol_feature) <func>: Add remote_target parameter.
 625         All callers adjusted.
 626         (curr_quit_handler_target): New.
 627         (remote_serial_quit_handler): Reimplement.
 628         (remote_target::open_1): Adjust to use get_current_remote_target.
 629         Heap-allocate remote_target/extended_remote_target instances.
 630         (vcont_builder::vcont_builder): Add remote_target parameter, and
 631         save it in m_remote.  All callers adjusted.
 632         (vcont_builder::m_remote): New field.
 633         (vcont_builder::restart, vcont_builder::flush)
 634         (vcont_builder::push_action): Use it.
 635         (remote_target::commit_resume): Use it.
 636         (struct queue_iter_param) <remote>: New field.
 637         (remote_target::remove_new_fork_children): Fill in 'remote' field.
 638         (check_pending_event_prevents_wildcard_vcont_callback_data): New.
 639         (check_pending_event_prevents_wildcard_vcont_callback)
 640         (remote_target::check_pending_events_prevent_wildcard_vcont)
 641         (remote_target::discard_pending_stop_replies)
 642         (remote_target::discard_pending_stop_replies_in_queue)
 643         (remote_target::remote_notif_remove_queued_reply): Fill in
 644         'remote' field.
 645         (remote_notif_get_pending_events): New.
 646         (remote_target::readchar, remote_target::remote_serial_write):
 647         Save/restore curr_quit_handler_target.
 648         (putpkt): New.
 649         (kill_new_fork_children): Fill in 'remote' field.
 650         (packet_command): Use get_current_remote_target, defer to
 651         remote_target method of same name.
 652         (scoped_remote_fd::scoped_remote_fd): Add 'remote_target'
 653         parameter, and save it in m_remote.  All callers adjusted.
 654         (scoped_remote_fd::release): Use m_remote.
 655         (scoped_remote_fd::m_remote): New field.
 656         (remote_file_put, remote_file_get, remote_file_delete): Use
 657         get_current_remote_target, defer to remote_target method of same
 658         name.
 659         (remote_btrace_reset): Add remote_state paremeter.  Update all
 660         callers.
 661         (remote_async_inferior_event_handler). Pass down 'data'.
 662         (remote_new_objfile): Use get_current_remote_target.
 663         (remote_target::vcont_r_supported): New.
 664         (set_range_stepping): Use get_current_remote_target and
 665         remote_target::vcont_r_supported.
 666         (_initialize_remote): Don't allocate 'remote_state' and
 667         'stop_reply_queue' globals.
 668         * remote.h (struct remote_target): Forward declare.
 669         (getpkt, putpkt, remote_notif_get_pending_events): Add
 670         'remote_target' parameter.
 671
 672 2018-05-22  Pedro Alves  <palves@redhat.com>
 673
 674         * remote.c (vcont_builder): Now a class.  Make all data members
 675         private.
 676         (vcont_builder) <vcont_builder, restart, flush, push_action>:
 677         Declare methods.
 678         (vcont_builder_restart): Rename to ...
 679         (vcont_builder::restart): ... this.
 680         (vcont_builder_flush): Rename to ...
 681         (vcont_builder::flush): ... this.
 682         (vcont_builder_push_action): Rename to ...
 683         (vcont_builder::push_action): ... this.
 684         (remote_target::commit_resume): Adjust.
 685
 686 2018-05-22  Pedro Alves  <palves@redhat.com>
 687
 688         * remote.c (DEFAULT_MAX_MEMORY_PACKET_SIZE): Rename to ...
 689         (DEFAULT_MAX_MEMORY_PACKET_SIZE_FIXED): ... this.
 690         (get_fixed_memory_packet_size): New.
 691         (get_memory_packet_size): Use it.
 692         (set_memory_packet_size): Don't override the config size with
 693         DEFAULT_MAX_MEMORY_PACKET_SIZE.
 694         (show_memory_packet_size): Use get_fixed_memory_packet_size.
 695         Don't refer to get_memory_packet_size if not connected to a remote
 696         target.  Show "(default)" if configured size is 0.
 697
 698 2018-05-22  Pedro Alves  <palves@redhat.com>
 699
 700         * remote.c (remote_target::mourn_inferior): Move
 701         discard_pending_stop_replies call here from ...
 702         (_initialize_remote): ... here.
 703
 704 2018-05-22  Pedro Alves  <palves@redhat.com>
 705
 706         * remote.c (compare_section_command): Remove set_general_process
 707         call.
 708
 709 2018-05-22  Pedro Alves  <palves@redhat.com>
 710
 711         * remote.c (struct packet_reg, struct remote_arch_state):
 712         Move higher up in the file.
 713         (remote_state) <m_arch_states>: Store remote_arch_state values
 714         instead of remote_arch_state pointers.
 715         (remote_state::get_remote_arch_state): Adjust.
 716
 717 2018-05-22  Pedro Alves  <palves@redhat.com>
 718
 719         * remote.c: Include <unordered_map>.
 720         (remote_state): Now a class.
 721         (remote_state) <get_remote_arch_state>: Declare method.
 722         <get_remote_arch_state>: New field.
 723         (remote_arch_state) <remote_arch_state>: Declare ctor.
 724         <regs>: Now a unique_ptr.
 725         (remote_gdbarch_data_handle): Delete.
 726         (get_remote_arch_state): Delete.
 727         (remote_state::get_remote_arch_state): New.
 728         (get_remote_state): Adjust to call remote_state's
 729         get_remote_arch_state method.
 730         (init_remote_state): Delete, bits factored out to ...
 731         (remote_arch_state::remote_arch_state): ... this new method.
 732         (get_remote_packet_size, get_memory_packet_size)
 733         (process_g_packet, remote_target::fetch_registers)
 734         (remote_target::prepare_to_store, store_registers_using_G)
 735         (remote_target::store_registers, remote_target::get_trace_status):
 736         Adjust to call remote_state's method.
 737         (_initialize_remote): Remove reference to
 738         remote_gdbarch_data_handle.
 739
 740 2018-05-22  Pedro Alves  <palves@redhat.com>
 741
 742         * remote.c (struct readahead_cache) <invalidate, invalidate_fd,
 743         pread>: New method declarations.
 744         (remote_target::open_1): Adjust.
 745         (readahead_cache_invalidate): Rename to ...
 746         (readahead_cache::invalidate): ... this, and adjust to be a class
 747         method.
 748         (readahead_cache_invalidate_fd): Rename to ...
 749         (readahead_cache::invalidate_fd): ... this, and adjust to be a
 750         class method.
 751         (remote_hostio_pwrite): Adjust.
 752         (remote_hostio_pread_from_cache): Rename to ...
 753         (readahead_cache::pread): ... this, and adjust to be a class
 754         method.
 755         (remote_hostio_close): Adjust.
 756
 757 2018-05-22  Pedro Alves  <palves@redhat.com>
 758
 759         * remote.c (remote_hostio_close_cleanup): Delete.
 760         (class scoped_remote_fd): New.
 761         (remote_file_put, remote_file_get): Use it.
 762
 763 2018-05-22  Pedro Alves  <palves@redhat.com>
 764
 765         (struct vCont_action_support): Use bool and initialize all fields.
 766         (struct readahead_cache): Initialize all fields.
 767         (remote_state): Use bool and initialize all fields.
 768         (remote_state::remote_state, remote_state::~remote_state): New.
 769         (new_remote_state): Delete.
 770         (_initialize_remote): Use new to allocate remote_state.
 771
 772 2018-05-22  Pedro Alves  <palves@redhat.com>
 773             張俊芝  <zjz@zjz.name>
 774
 775         PR gdb/22973
 776         * c-exp.y: Include "c-support.h".
 777         (parse_number, c_parse_escape, lex_one_token): Use TOLOWER instead
 778         of tolower.  Use c_ident_is_alpha to scan names.
 779         * c-lang.c: Include "c-support.h".
 780         (convert_ucn, convert_octal, convert_hex, convert_escape): Use
 781         ISXDIGIT instead of isxdigit and ISDIGIT instead of isdigit.
 782         * c-support.h: New file, with bits factored out from ...
 783         * cp-name-parser.y: ... this file.
 784         Include "c-support.h".
 785         (cp_ident_is_alpha, cp_ident_is_alnum): Deleted, moved to
 786         c-support.h and renamed.
 787         (symbol_end, yylex): Adjust.
 788
 789 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
 790
 791         * arch/ppc-linux-common.c (ppc_linux_has_isa205): Change the
 792         parameter type to CORE_ADDR.
 793         * arch/ppc-linux-common.h (ppc_linux_has_isa205): Change the
 794         parameter type in declaration to CORE_ADDR.
 795         * ppc-linux-tdep.c (ppc_linux_core_read_description): Call
 796         target_auxv_search to get AT_HWCAP and use the result to get the
 797         target description.
 798         * ppc-linux-nat.c (ppc_linux_get_hwcap): Change the return type
 799         to CORE_ADDR. Remove the cast of the return value to unsigned
 800         long. Fix error predicate of target_auxv_search.
 801         (ppc_linux_nat_target::read_description): Change the type of the
 802         hwcap variable to CORE_ADDR.
 803
 804 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
 805
 806         * rs6000-tdep.c (rs6000_gdbarch_init): Assign 1 to have_dfp only
 807         if the size of fpscr is larger than 32 bits.
 808
 809 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
 810
 811         * ppc-linux-tdep.c (ppc_linux_vsxregset): New function.
 812         (ppc32_linux_vsxregmap): New global.
 813         (ppc32_linux_vsxregset): Initialize with ppc32_linux_vsxregmap,
 814         regcache_supply_regset, and regcache_collect_regset.
 815         * ppc-linux-tdep.h (ppc_linux_vsxregset): Declare.
 816         * ppc-linux-nat.c (supply_vsxregset, fill_vsxregset): Remove.
 817         (fetch_vsx_register, store_vsx_register): Remove.
 818         (fetch_vsx_registers): Add regno parameter. Get regset using
 819         ppc_linux_vsxregset. Use regset to supply registers.
 820         (store_vsx_registers): Add regno parameter. Get regset using
 821         ppc_linux_vsxregset. Use regset to collect registers.
 822         (fetch_register): Call fetch_vsx_registers instead of
 823         fetch_vsx_register.
 824         (store_register): Call store_vsx_registers instead of
 825         store_vsx_register.
 826         (fetch_ppc_registers): Call fetch_vsx_registers with -1 for the
 827         new regno parameter.
 828         (store_ppc_registers): Call store_vsx_registers with -1 for the
 829         new regno parameter.
 830         * rs6000-tdep.c (ppc_vsx_support_p, ppc_supply_vsxreget)
 831         (ppc_collect_vsxregset): Remove.
 832
 833 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
 834
 835         * ppc-tdep.h (struct ppc_reg_offsets): Remove vector register
 836         offset fields.
 837         * ppc-fbsd-tdep.c (ppc32_fbsd_reg_offsets): Remove initializers
 838         for vector register offset fields.
 839         (ppc64_fbsd_reg_offsets): Likewise.
 840         * ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Remove assignment
 841         to vector register offset fields.
 842         * ppc-obsd-tdep.c (_initialize_ppcnbsd_tdep): Remove assignment
 843         to vector register offset fields.
 844         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Remove assignment to
 845         vector register offset fields.
 846         * rs6000-aix-tdep.c (rs6000_aix32_reg_offsets): Remove
 847         initializers for vector register offset fields.
 848         (rs6000_aix64_reg_offsets): Likewise.
 849         * rs6000-tdep.c (ppc_vrreg_offset): Remove.
 850         (ppc_supply_vrregset): Remove.
 851         (ppc_collect_vrregset): Remove.
 852         * ppc-linux-tdep.c (ppc_linux_collect_vrregset): New function.
 853         (ppc_linux_vrregset) : New function.
 854         (ppc32_le_linux_vrregmap, ppc32_be_linux_vrregmap)
 855         (ppc32_le_linux_vrregset, ppc32_be_linux_vrregset): New globals.
 856         (ppc32_linux_vrregset): Remove.
 857         (ppc_linux_iterate_over_regset_sections): Call ppc_linux_vrregset
 858         and use result instead of ppc32_linux_vrregset.
 859         (ppc32_linux_reg_offsets): Remove initializers for vector register
 860         offset fields.
 861         (ppc64_linux_reg_offsets): Likewise.
 862         * ppc-linux-tdep.h (ppc_linux_vrregset): New declaration.
 863         * ppc-linux-nat.c: Include regset.h.
 864         (gdb_vrregset_t): Adjust comment to account for little-endian
 865         mode.
 866         (supply_vrregset, fill_vrregset): Remove.
 867         (fetch_altivec_register, store_altivec_register): Remove.
 868         (fetch_altivec_registers): Add regno parameter. Get regset using
 869         ppc_linux_vrregset. Use regset to supply registers.
 870         (store_altivec_registers): Add regno parameter. Get regset using
 871         ppc_linux_vrregset. Use regset to collect registers.
 872         (fetch_register): Call fetch_altivec_registers instead of
 873         fetch_altivec_register.
 874         (store_register): Call store_altivec_registers instead of
 875         store_altivec_register.
 876         (fetch_ppc_registers): Call fetch_altivec_registers with -1 for
 877         the new regno parameter.
 878         (store_ppc_registers): Call store_altivec_registers with -1 for
 879         the new regno parameter.
 880
 881 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
 882
 883         * arch/ppc-linux-common.h (PPC_LINUX_SIZEOF_VRREGSET)
 884         (PPC_LINUX_SIZEOF_VSXREGSET): Define.
 885         * ppc-linux-nat.c (SIZEOF_VSXREGS, SIZEOF_VRREGS): Remove.
 886         (gdb_vrregset_t): Change array type size to
 887         PPC_LINUX_SIZEOF_VRREGSET.
 888         (gdb_vsxregset_t): Change array type size to
 889         PPC_LINUX_SIZEOF_VSXREGSET.
 890         * ppc-linux-tdep.c (ppc_linux_iterate_over_regset_sections):
 891         Change integer literals to PPC_LINUX_SIZEOF_VRREGSET and
 892         PPC_LINUX_SIZEOF_VSXREGSET.
 893
 894 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
 895
 896         * configure.nat <linux powerpc>: Add ppc-linux.o to NATDEPFILES.
 897         * ppc-linux-nat.c (ppc_linux_target_wordsize): Move to
 898         nat/ppc-linux.c.
 899         (ppc_linux_nat_target::auxv_parse): Get thread id tid. Call
 900         ppc_linux_target_wordsize with tid.
 901         (ppc_linux_nat_target::read_description): Call ppc_linux_target
 902         wordsize with tid.
 903         * nat/ppc-linux.c: Include nat/gdb_ptrace.h.
 904         (ppc64_64bit_inferior_p): Add static and inline specifiers.
 905         (ppc_linux_target_wordsize): Move here from ppc-linux-nat.c. Add
 906         tid parameter. Remove static specifier.
 907         * nat/ppc-linux.h (ppc64_64bit_inferior_p): Remove declaration.
 908         (ppc_linux_target_wordsize): New declaration.
 909
 910 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
 911
 912         * arch/ppc-linux-common.c: New file.
 913         * arch/ppc-linux-common.h: New file.
 914         * arch/ppc-linux-tdesc.h: New file.
 915         * configure.tgt (powerpc*-*-linux*): Add arch/ppc-linux-common.o.
 916         * Makefile.in (ALL_TARGET_OBS): Add arch/ppc-linux-common.o.
 917         (HFILES_NO_SRCDIR): Add arch/ppc-linux-common.h and
 918         arch/ppc-linux-tdesc.h.
 919         * ppc-linux-nat.c: Include arch/ppc-linux-common.h and
 920         arch/ppc-linux-tdesc.h.
 921         (ppc_linux_nat_target::read_description): Remove target
 922         description matching code. Fill a ppc_linux_features struct and
 923         call ppc_linux_match_description with it. Move comment about ISA
 924         2.05 to ppc-linux-common.c.
 925         * ppc-linux-tdep.c: Include arch/ppc-linux-common.h and
 926         arch/ppc-linux-tdesc.h.
 927         (ppc_linux_core_read_description): Remove target description
 928         matching code. Fill a ppc_linux_features struct and call
 929         ppc_linux_match_description with it.
 930         * ppc-linux-tdep.h (tdesc_powerpc_32l, tdesc_powerpc_64l)
 931         (tdesc_powerpc_altivec32l, tdesc_powerpc_altivec64l)
 932         (tdesc_powerpc_cell32l, tdesc_powerpc_cell64l)
 933         (tdesc_powerpc_vsx32l, tdesc_powerpc_vsx64l)
 934         (tdesc_powerpc_isa205_32l, tdesc_powerpc_isa205_64l)
 935         (tdesc_powerpc_isa205_altivec32l, tdesc_powerpc_isa205_altivec64l)
 936         (tdesc_powerpc_isa205_vsx32l, tdesc_powerpc_isa205_vsx64l)
 937         (tdesc_powerpc_e500l): Remove.
 938
 939 2018-05-22  Joel Brobecker  <brobecker@adacore.com>
 940
 941         * ada-lang.c (catch_assert_command): Pass empty string instead
 942         of NULL for excep_string argument.
 943
 944 2018-05-22  Maciej W. Rozycki  <macro@mips.com>
 945
 946         * mips-linux-nat.c (mips64_linux_register_addr): Return -1 if
 947         the width of the requested register exceeds the width of the
 948         `ptrace' data type.
 949
 950 2018-05-21  Tom Tromey  <tom@tromey.com>
 951
 952         * printcmd.c (output_command): Remove.
 953         (output_command_const): Rename to output_command.
 954         * valprint.h (output_command): Rename from output_command_const.
 955         * tracepoint.c (trace_dump_actions): Call output_command.
 956
 957 2018-05-21  Tom Tromey  <tom@tromey.com>
 958
 959         * mi/mi-cmd-catch.c (mi_cmd_catch_assert)
 960         (mi_cmd_catch_exception, mi_cmd_catch_handlers): Update.
 961         * ada-lang.h (create_ada_exception_catchpoint): Update.
 962         * ada-lang.c (struct ada_catchpoint) <excep_string>: Now a
 963         std::string.
 964         (create_excep_cond_exprs, ~ada_catchpoint)
 965         (should_stop_exception, print_one_exception)
 966         (print_mention_exception, print_recreate_exception): Update.
 967         (ada_get_next_arg): Remove.
 968         (catch_ada_exception_command_split): Use std::string.  Change type
 969         of "excep_string", "cond_string".
 970         (catch_ada_exception_command): Update.
 971         (create_ada_exception_catchpoint): Change type of excep_string.
 972         (ada_exception_sal): Remove excep_string parameter.
 973         (~ada_catchpoint): Remove.
 974
 975 2018-05-21  Tom Tromey  <tom@tromey.com>
 976
 977         * ada-lang.c (ada_collect_symbol_completion_matches): Remove
 978         cleanup.
 979
 980 2018-05-21  Tom Tromey  <tom@tromey.com>
 981
 982         * ada-lang.c (ada_exception_message_1, ada_exception_message):
 983         Return unique_xmalloc_ptr.
 984         (print_it_exception): Update.
 985
 986 2018-05-21  Tom Tromey  <tom@tromey.com>
 987
 988         * tracepoint.c (trace_dump_actions): Use std::string.
 989
 990 2018-05-21  Tom Tromey  <tom@tromey.com>
 991
 992         * symfile.c (reread_symbols): Use std::string for original_name.
 993
 994 2018-05-21  Tom Tromey  <tom@tromey.com>
 995
 996         * dwarf2read.c (dwarf2_read_debug_names): Use std::unique_ptr.
 997         (mapped_index_base): Use DISABLE_COPY_AND_ASSIGN.  Default
 998         constructor.
 999
1000 2018-05-20  Simon Marchi  <simon.marchi@polymtl.ca>
1001
1002         * common/traits.h (HAVE_IS_TRIVIALLY_COPYABLE): Rename the wrong
1003         instance to...
1004         (HAVE_IS_TRIVIALLY_CONSTRUCTIBLE): ... this.
1005         * objfiles.c (get_objfile_bfd_data): Allocate
1006         objfile_per_bfd_storage with obstack_new when allocating on
1007         obstack.
1008
1009 2018-05-20  Simon Marchi  <simon.marchi@ericsson.com>
1010
1011         * ada-lang.c (cache_symbol): Use XOBNEW and/or XOBNEWVEC and/or
1012         OBSTACK_ZALLOC.
1013         * dwarf2-frame.c (dwarf2_build_frame_info): Likewise.
1014         * hppa-tdep.c (hppa_init_objfile_priv_data): Likewise.
1015         * mdebugread.c (mdebug_build_psymtabs): Likewise.
1016         (add_pending): Likewise.
1017         (parse_symbol): Likewise.
1018         (parse_partial_symbols): Likewise.
1019         (psymtab_to_symtab_1): Likewise.
1020         (new_psymtab): Likewise.
1021         (elfmdebug_build_psymtabs): Likewise.
1022         * minsyms.c (terminate_minimal_symbol_table): Likewise.
1023         * objfiles.c (get_objfile_bfd_data): Likewise.
1024         (objfile_register_static_link): Likewise.
1025         * psymtab.c (allocate_psymtab): Likewise.
1026         * stabsread.c (read_member_functions): Likewise.
1027         * xcoffread.c (xcoff_end_psymtab): Likewise.
1028
1029 2018-05-20  Simon Marchi  <simon.marchi@ericsson.com>
1030
1031         * common/traits.h (HAVE_IS_TRIVIALLY_COPYABLE): Define if
1032         compiler supports std::is_trivially_constructible.
1033         * common/poison.h: Include obstack.h.
1034         (IsMallocable): Define to is_trivially_constructible if the
1035         compiler supports it, define to true_type otherwise.
1036         (xobnew): New.
1037         (XOBNEW): Redefine.
1038         (xobnewvec): New.
1039         (XOBNEWVEC): Redefine.
1040         * gdb_obstack.h (obstack_zalloc): New.
1041         (OBSTACK_ZALLOC): Redefine.
1042         (obstack_calloc): New.
1043         (OBSTACK_CALLOC): Redefine.
1044         (obstack_new): New.
1045         * gdbarch.sh: Include gdb_obstack in gdbarch.h.
1046         (gdbarch_obstack): New declaration in gdbarch.h, definition in
1047         gdbarch.c.
1048         (GDBARCH_OBSTACK_CALLOC, GDBARCH_OBSTACK_ZALLOC): Use
1049         obstack_calloc/obstack_zalloc.
1050         (gdbarch_obstack_zalloc): Remove.
1051         * target-descriptions.c (tdesc_data_init): Use obstack_new.
1052
1053 2018-05-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1054
1055         * stack.c (backtrace_command_1): Remove useless variable int i.
1056
1057 2018-05-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1058
1059         * stack.c (print_frame_info): Fix comment.
1060
1061 2018-05-18  Tom Tromey  <tom@tromey.com>
1062
1063         * dwarf2read.c (struct dwz_file): Add constructor, initializers.
1064         <dwz_bfd>: Now a gdb_bfd_ref_ptr.
1065         (~dwarf2_per_objfile): Update
1066         (dwarf2_get_dwz_file): Use new.
1067         * dwarf2read.h (struct dwarf2_per_objfile) <dwz_file>: Now a
1068         unique_ptr.
1069
1070 2018-05-18  Tom Tromey  <tom@tromey.com>
1071
1072         * dwarf2read.h (struct dwarf2_per_objfile) <dwp_file>: Now a
1073         unique_ptr.
1074         * dwarf2read.c (struct dwp_file): Add constructor and
1075         initializers.
1076         (open_and_init_dwp_file): Return a unique_ptr.
1077         (dwarf2_per_objfile, create_dwp_hash_table)
1078         (create_dwo_unit_in_dwp_v1, create_dwo_unit_in_dwp_v2)
1079         (lookup_dwo_unit_in_dwp): Update.
1080         (open_and_init_dwp_file, get_dwp_file): Update.
1081
1082 2018-05-18  Tom Tromey  <tom@tromey.com>
1083
1084         * dwarf2read.c (dwarf2_per_objfile): Update.
1085         (struct mapped_index): Add initializers.
1086         (dwarf2_read_index): Use new.
1087         (dw2_symtab_iter_init): Update.
1088         * dwarf2read.h (struct dwarf2_per_objfile) <index_table>: Now a
1089         unique_ptr.
1090
1091 2018-05-18  Simon Marchi  <simon.marchi@ericsson.com>
1092
1093         * dwarf2read.c (mapped_index) <total_size>: Remove.
1094
1095 2018-05-18  Simon Marchi  <simon.marchi@ericsson.com>
1096
1097         * unittests/format_pieces-selftests.c (test_format_specifier):
1098         Add ARI comments.
1099
1100 2018-05-18  Tom Tromey  <tom@tromey.com>
1101
1102         * c-typeprint.c (maybe_print_hole): New function.
1103         (c_print_type_struct_field_offset): Update.
1104         (c_type_print_base_struct_union): Call maybe_print_hole.
1105
1106 2018-05-17  Keith Seitz  <keiths@redhat.com>
1107
1108         * breakpoint.c (build_bpstat_chain): New function, moved from
1109         bpstat_stop_status.
1110         (bpstat_stop_status): Add optional parameter, `stop_chain'.
1111         If no stop chain is passed, call build_bpstat_chain to build it.
1112         * breakpoint.h (build_bpstat_chain): Declare.
1113         (bpstat_stop_status): Move documentation here from breakpoint.c.
1114         * infrun.c (handle_signal_stop): Before eliding inlined frames,
1115         build the stop chain and pass it to skip_inline_frames.
1116         Pass this stop chain to bpstat_stop_status.
1117         * inline-frame.c: Include breakpoint.h.
1118         (stopped_by_user_bp_inline_frame): New function.
1119         (skip_inline_frames): Add parameter `stop_chain'.
1120         Move documention to inline-frame.h.
1121         If non-NULL, use stopped_by_user_bp_inline_frame to determine
1122         whether the frame should be elided.
1123         * inline-frame.h (skip_inline_frames): Add parameter `stop_chain'.
1124         Add moved documentation and update for new parameter.
1125
1126 2018-05-17  Simon Marchi  <simon.marchi@ericsson.com>
1127
1128         PR cli/14975
1129         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1130         unittests/format_pieces-selftests.c.
1131         * common/format.h (format_piece) <operator==>: New.
1132         (format_pieces) <operator[]>: Remove.
1133         * common/format.c (format_pieces::format_pieces): Handle \e.
1134         * unittests/format_pieces-selftests.c: New.
1135
1136 2018-05-17  Tom Tromey  <tom@tromey.com>
1137
1138         PR symtab/23010:
1139         * dwarf2read.c (load_cu, dw2_do_instantiate_symtab)
1140         (dw2_instantiate_symtab): Add skip_partial parameter.
1141         (dw2_find_last_source_symtab, dw2_map_expand_apply)
1142         (dw2_lookup_symbol, dw2_expand_symtabs_for_function)
1143         (dw2_expand_all_symtabs, dw2_expand_symtabs_with_fullname)
1144         (dw2_expand_symtabs_matching_one)
1145         (dw2_find_pc_sect_compunit_symtab)
1146         (dw2_debug_names_lookup_symbol)
1147         (dw2_debug_names_expand_symtabs_for_function): Update.
1148         (init_cutu_and_read_dies): Add skip_partial parameter.
1149         (process_psymtab_comp_unit, build_type_psymtabs_1)
1150         (process_skeletonless_type_unit, load_partial_comp_unit)
1151         (psymtab_to_symtab_1): Update.
1152         (load_full_comp_unit): Add skip_partial parameter.
1153         (process_imported_unit_die, dwarf2_read_addr_index)
1154         (follow_die_offset, dwarf2_fetch_die_loc_sect_off)
1155         (dwarf2_fetch_constant_bytes, dwarf2_fetch_die_type_sect_off)
1156         (read_signatured_type): Update.
1157
1158 2018-05-17  Simon Marchi  <simon.marchi@ericsson.com>
1159
1160         * value.c (release_value): Remove unused variable.
1161         (record_latest_value): Likewise.
1162         (access_value_history): Likewise.
1163         (preserve_values): Likewise.
1164
1165 2018-05-17  Tom Tromey  <tom@tromey.com>
1166
1167         * extension.h (struct ext_lang_type_printers) <py_type_printers>:
1168         Initialize.
1169
1170 2018-05-16  Maciej W. Rozycki  <macro@mips.com>
1171
1172         PR gdb/22286
1173         * linux-nat-trad.c (linux_nat_trad_target::fetch_register):
1174         Also handle registers whose width is not a multiple of
1175         PTRACE_TYPE_RET.
1176         (linux_nat_trad_target::store_register): Likewise.
1177
1178 2018-05-16  Tom Tromey  <tom@tromey.com>
1179
1180         * gdbcore.h (core_bfd): Redefine.
1181         * corelow.c (core_target::close): Update.
1182         (core_target_open): Update.
1183         * progspace.h (struct program_space) <cbfd>: Now a
1184         gdb_bfd_ref_ptr.
1185
1186 2018-05-16  Tom Tromey  <tom@tromey.com>
1187
1188         PR cli/19551:
1189         * symfile-add-flags.h (enum symfile_add_flags)
1190         <SYMFILE_NOT_FILENAME>: New constant.
1191         * symfile.c (read_symbols): Use SYMFILE_NOT_FILENAME.  Get
1192         objfile name from BFD.
1193         (symbol_file_add_with_addrs): Check SYMFILE_NOT_FILENAME.
1194         * minidebug.c (find_separate_debug_file_in_section): Put
1195         ".gnu_debugdata" into BFD's file name.
1196
1197 2018-05-16  Simon Marchi  <simon.marchi@ericsson.com>
1198
1199         * regcache.c (regcache_read_ftype, regcache_write_ftype):
1200         Remove.
1201
1202 2018-05-15  Tamar Christina  <tamar.christina@arm.com>
1203
1204         PR binutils/21446
1205         * aarch64-tdep.c (aarch64_analyze_prologue,
1206         aarch64_software_single_step, aarch64_displaced_step_copy_insn):
1207         Indicate not interested in errors.
1208
1209 2018-05-15  Maciej W. Rozycki  <macro@mips.com>
1210
1211         * mips-linux-nat.c (mips_linux_nat_target::fetch_registers):
1212         Supply the MIPS_ZERO_REGNUM register.
1213
1214 2018-05-15  Maciej W. Rozycki  <macro@mips.com>
1215
1216         * mips-tdep.c (mask_address_var): Make variable static.
1217
1218 2018-05-14  Tom Tromey  <tom@tromey.com>
1219
1220         * dwarf2read.c (rust_union_quirks): Clear rust_unions.
1221
1222 2018-05-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1223
1224         * i387-tdep.c (i387_collect_xsave): Use FXSAVE_MXCSR_ADDR not
1225         FXSAVE_ADDR for the mxcsr register.
1226
1227 2018-05-11  Max Filippov  <jcmvbkbc@gmail.com>
1228
1229         * configure.tgt (xtensa*-*-linux*): Drop gdb_target definition.
1230
1231 2018-05-11  Pedro Alves  <palves@redhat.com>
1232
1233         * corelow.c (core_target) <core_target>: No longer inline.
1234         Initialize m_core_gdbarch, m_core_vec and build the section table
1235         here.
1236         <~core_target>: New.
1237         <core_gdbarch, get_core_register_section>: New methods.
1238         <m_core_section_table, m_core_vec, m_core_gdbarch>: New fields,
1239         factored out from ...
1240         <core_data, core_vec, core_gdbarch>: ... these deleted globals.
1241         (core_ops): Delete.
1242         (sniff_core_bfd): Add gdbarch parameter.
1243         (core_close): Delete, merged into ...
1244         (core_target::close): ... here.  Delete self.
1245         (core_close_cleanup): Delete.
1246         (core_target_open): Allocate a core_target on the heap.  Use a
1247         unique_ptr instead of a cleanup.  Bits moved into the core_target
1248         ctor.  Adjust to use core_target methods instead of globals.
1249         (get_core_register_section): Rename to ...
1250         (core_target::get_core_register_section): ... this and adjust.
1251         (struct get_core_registers_cb_data): New.
1252         (get_core_registers_cb): Use it.  Use bool.
1253         (core_target::fetch_registers, core_target::files_info)
1254         (core_target::xfer_partial, core_target::read_description)
1255         (core_target::pid_to, core_target::thread_name): Adjust to
1256         reference class fields instead of globals.
1257         * target.h (struct target_ops_deleter, target_ops_up): New.
1258
1259 2018-05-11  Pedro Alves  <palves@redhat.com>
1260
1261         * corefile.c (core_file_command): Move to corelow.c.
1262         * corelow.c (the_core_target): Delete.
1263         (core_file_command): Moved from corefile.c.  Check exec_bfd
1264         instead of the_core_target.  Use target_detach instead of calling
1265         into the_core_target directly.
1266         (maybe_say_no_core_file_now): New.
1267         (core_target::detach): Use it.
1268         (_initialize_corelow): Remove references to the_core_target.
1269         * gdbcore.h (the_core_target): Delete.
1270
1271 2018-05-11  Tom Tromey  <tromey@redhat.com>
1272             Pedro Alves  <palves@redhat.com>
1273
1274         * corefile.c (core_bfd): Remove.
1275         * gdbcore.h (core_bfd): Now a macro.
1276         * progspace.h (struct program_space) <cbfd>: New field.
1277
1278 2018-05-11  Tom Tromey  <tom@tromey.com>
1279
1280         * mdebugread.c (parse_partial_symbols, psymtab_to_symtab_1): Use
1281         gdb::def_vector.
1282
1283 2018-05-10  Tom Tromey  <tom@tromey.com>
1284
1285         * configure: Rebuild.
1286         * warning.m4 (AM_GDB_WARNINGS): Use -Wimplicit-fallthrough=3.
1287
1288 2018-05-10  Joel Brobecker  <brobecker@adacore.com>
1289
1290         PR server/23158:
1291         * regformats/regdat.sh: Adjust script, following the addition
1292         of the new expedite_regs parameter to init_target_desc.
1293
1294 2018-05-10  Omair Javaid  <omair.javaid@linaro.org>
1295
1296         PR gdb/23127
1297         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Add call to
1298         set_gdbarch_significant_addr_bit.
1299         * aarch64-tdep.c (aarch64_gdbarch_init): Remove call to
1300         set_gdbarch_significant_addr_bit.
1301         * utils.c (address_significant): Update to sign extend addr.
1302
1303 2018-05-09  Max Filippov  <jcmvbkbc@gmail.com>
1304
1305         * xtensa-linux-tdep.c (xtensa-tdep.h): New include.
1306         (xtensa_linux_init_abi): Limit tdep->num_regs by
1307         tdep->num_nopriv_regs.
1308         * xtensa-tdep.c (xtensa_derive_tdep): Calculate
1309         tdep->num_nopriv_regs and only copy it to tdep->num_regs if it's
1310         not initialized.
1311
1312 2018-05-08  Simon Marchi  <simon.marchi@ericsson.com>
1313
1314         * unittests/string_view-selftests.c: Define GNULIB_NAMESPACE.
1315
1316 2018-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1317
1318         * common/x86-xstate.h (I387_FCTRL_INIT_VAL): New constant.
1319         (I387_MXCSR_INIT_VAL): New constant.
1320         * amd64-tdep.c (amd64_supply_xsave): Only read state from xsave
1321         buffer if it was supplied by the inferior.
1322         * i387-tdep.c (i387_supply_fsave): Use I387_MXCSR_INIT_VAL.
1323         (i387_xsave_get_clear_bv): New function.
1324         (i387_supply_xsave): Only read x87 control registers from the
1325         xsave buffer if the feature is enabled, and the state will have
1326         been written, otherwise, provide a suitable default.
1327         (i387_collect_xsave): Pre-clear all registers in xsave buffer,
1328         including x87 control registers.  Update control registers if they
1329         have changed from the default value, and mark features as enabled
1330         as required.
1331         * i387-tdep.h (i387_xsave_get_clear_bv): Declare.
1332
1333 2018-05-08  Ulrich Weigand  <uweigand@de.ibm.com>
1334
1335         * spu-tdep.c (info_spu_event_command): Fix output formatting.
1336
1337 2018-05-07  Tom Tromey  <tom@tromey.com>
1338
1339         * configure: Rebuild.
1340         * warning.m4 (AM_GDB_WARNINGS): Add -Wduplicated-cond.
1341
1342 2018-05-07  Tom Tromey  <tom@tromey.com>
1343
1344         PR tdep/20362:
1345         * arm-tdep.c (arm_record_vfp_data_proc_insn): Properly mask off D
1346         bit.  Use correct value for VDIV.
1347
1348 2018-05-04  Tom Tromey  <tom@tromey.com>
1349
1350         * configure: Rebuild.
1351         * warning.m4 (AM_GDB_WARNINGS): Add -Wimplicit-fallthrough.
1352
1353 2018-05-04  Tom Tromey  <tom@tromey.com>
1354
1355         * linux-record.c (record_linux_system_call) <case
1356         RECORD_SYS_RECVFROM>: Add "break".
1357
1358 2018-05-04  Tom Tromey  <tom@tromey.com>
1359
1360         * mi/mi-main.c (mi_cmd_trace_frame_collected) <REGISTERS_FORMAT>:
1361         Add missing "break".
1362         * mi/mi-cmd-stack.c (mi_cmd_stack_list_locals) <NO_FRAME_FILTERS>:
1363         Add missing "break".
1364
1365 2018-05-04  Tom Tromey  <tom@tromey.com>
1366
1367         * rs6000-tdep.c (ppc_process_record_op4)
1368         (ppc_process_record_op63): Add fall-through comment.
1369
1370 2018-05-04  Tom Tromey  <tom@tromey.com>
1371
1372         * i386-tdep.c (i386_process_record): Add fall-through comment.
1373
1374 2018-05-04  Tom Tromey  <tom@tromey.com>
1375
1376         * stabsread.c (define_symbol) <case 'p'>: Add fall-through
1377         comment.
1378
1379 2018-05-04  Tom Tromey  <tom@tromey.com>
1380
1381         * riscv-tdep.c (riscv_isa_xlen): Add fall-through comment.
1382         * utils.c (can_dump_core) <LIMIT_CUR>: Add fall-through comment.
1383         * eval.c (fetch_subexp_value) <MEMORY_ERROR>: Add fall-through
1384         comment.
1385         * d-valprint.c (d_val_print) <TYPE_CODE_STRUCT>: Add fall-through
1386         comment.
1387         * coffread.c (coff_symtab_read) <C_LABEL>: Add fall-through
1388         comment.
1389
1390 2018-05-04  Tom Tromey  <tom@tromey.com>
1391
1392         * dwarf2loc.c (unimplemented): Add ATTRIBUTE_NORETURN.
1393
1394 2018-05-04  Tom Tromey  <tom@tromey.com>
1395
1396         * s390-tdep.c (s390_process_record): Fix fall-through comments.
1397         * xcoffread.c (scan_xcoff_symtab): Move comment later.
1398         * symfile.c (section_is_mapped): Fix fall-through comment.
1399         * stabsread.c (define_symbol, read_member_functions): Fix
1400         fall-through comment.
1401         * s390-linux-tdep.c (s390_process_record): Fix fall-through
1402         comment.
1403         * remote.c (remote_wait_as): Fix fall-through comment.
1404         * p-exp.y (yylex): Fix fall-through comment.
1405         * nat/x86-dregs.c (x86_length_and_rw_bits): Fix fall-through
1406         comment.
1407         * msp430-tdep.c (msp430_gdbarch_init): Fix fall-through comment.
1408         * mdebugread.c (parse_partial_symbols): Fix fall-through comment.
1409         * jv-exp.y (yylex): Fix fall-through comment.
1410         * go-exp.y (lex_one_token): Fix fall-through comment.
1411         * gdbtypes.c (get_discrete_bounds, rank_one_type): Fix
1412         fall-through comment.
1413         * f-exp.y (yylex): Fix fall-through comment.
1414         * dwarf2read.c (process_die): Fix fall-through comments.
1415         * dbxread.c (process_one_symbol): Fix fall-through comment.
1416         * d-exp.y (lex_one_token): Fix fall-through comment.
1417         * cp-name-parser.y (yylex): Fix fall-through comment.
1418         * coffread.c (coff_symtab_read): Fix fall-through comment.
1419         * c-exp.y (lex_one_token): Fix fall-through comment.
1420         * arm-tdep.c (arm_decode_miscellaneous): Fix fall-through
1421         comment.
1422         * arch/arm.c (arm_instruction_changes_pc): Fix fall-through
1423         comment.
1424
1425 2018-05-04  Tom Tromey  <tom@tromey.com>
1426
1427         PR python/22730:
1428         * NEWS: Mention gdb.execute change.
1429         * gdbcmd.h (execute_control_command): Don't declare.
1430         * python/python.c (execute_gdb_command): Use read_command_lines_1,
1431         execute_control_commands, execute_control_commands_to_string.
1432         * cli/cli-script.h (execute_control_commands)
1433         (execute_control_commands_to_string): Declare.
1434         (execute_control_command): Add from_tty parameter.
1435         * cli/cli-script.c (execute_control_commands)
1436         (execute_control_commands_to_string): New functions.
1437         (execute_user_command): Use execute_control_commands.
1438         (execute_control_command_1): Add "from_tty" parameter.  Update.
1439         (execute_control_command): Likewise.
1440
1441 2018-05-04  Tom Tromey  <tom@tromey.com>
1442
1443         PR python/22731:
1444         * NEWS: Mention that breakpoint commands are writable.
1445         * python/py-breakpoint.c (bppy_set_commands): New function.
1446         (breakpoint_object_getset) <"commands">: Use it.
1447
1448 2018-05-04  Tom Tromey  <tom@tromey.com>
1449
1450         * tracepoint.c (actions_command): Update.
1451         * mi/mi-cmd-break.c (mi_command_line_array)
1452         (mi_command_line_array_cnt, mi_command_line_array_ptr)
1453         (mi_read_next_line): Remove.
1454         (mi_cmd_break_commands): Update.
1455         * cli/cli-script.h (read_command_lines, read_command_lines_1): Use
1456         function_view.
1457         * cli/cli-script.c (get_command_line): Update.
1458         (process_next_line): Use function_view.  Constify.
1459         (recurse_read_control_structure, read_command_lines)
1460         (read_command_lines_1): Change argument types to function_view.
1461         (do_define_command, document_command): Update.
1462         * breakpoint.h (check_tracepoint_command): Don't declare.
1463         * breakpoint.c (check_tracepoint_command): Remove.
1464         (commands_command_1, create_tracepoint_from_upload): Update.
1465
1466 2018-05-04  Tom Tromey  <tom@tromey.com>
1467
1468         PR gdb/11750:
1469         * cli/cli-script.h (enum command_control_type) <define_control>:
1470         New constant.
1471         * cli/cli-script.c (multi_line_command_p): Handle define_control.
1472         (build_command_line, execute_control_command_1)
1473         (process_next_line): Likewise.
1474         (do_define_command): New function, extracted from define_command.
1475         (define_command): Use it.
1476
1477 2018-05-04  Tom Tromey  <tom@tromey.com>
1478
1479         * tracepoint.c (actions_command): Update.
1480         * cli/cli-script.h (read_command_lines): Update.
1481         * cli/cli-script.c (read_command_lines): Constify prompt_arg.
1482         (MAX_TMPBUF): Remove define.
1483         (define_command): Use string_printf.
1484         (document_command): Likewise.
1485         * breakpoint.c (commands_command_1): Update.
1486
1487 2018-05-04  Tom Tromey  <tom@tromey.com>
1488
1489         * top.c (execute_command): Update.
1490         * cli/cli-script.h (print_command_lines): Now varargs.
1491         * cli/cli-script.c (print_command_lines): Now varargs.
1492         (execute_control_command_1) <case while_control, case if_control>:
1493         Update.
1494
1495 2018-05-04  Tom Tromey  <tom@tromey.com>
1496
1497         * tracepoint.c (all_tracepoint_actions): Rename from
1498         all_tracepoint_actions_and_cleanup.  Change return type.
1499         (actions_command, encode_actions_1, encode_actions)
1500         (trace_dump_actions, tdump_command): Update.
1501         * remote.c (remote_download_command_source): Update.
1502         * python/python.c (gdbpy_eval_from_control_command)
1503         (python_command, python_interactive_command): Update.
1504         * mi/mi-cmd-break.c (mi_cmd_break_commands): Update.
1505         * guile/guile.c (guile_command)
1506         (gdbscm_eval_from_control_command, guile_command): Update.
1507         * compile/compile.c (compile_code_command)
1508         (compile_print_command, compile_to_object): Update.
1509         * cli/cli-script.h (struct command_lines_deleter): New.
1510         (counted_command_line): New typedef.
1511         (struct command_line): Add constructor, destructor.
1512         <body_list>: Remove.
1513         <body_list_0, body_list_1>: New members.
1514         (command_line_up): Remove typedef.
1515         (read_command_lines, read_command_lines_1, get_command_line):
1516         Update.
1517         (copy_command_lines): Don't declare.
1518         * cli/cli-script.c (build_command_line): Use "new".
1519         (get_command_line): Return counted_command_line.
1520         (print_command_lines, execute_user_command)
1521         (execute_control_command_1, while_command, if_command): Update.
1522         (realloc_body_list): Remove.
1523         (process_next_line, recurse_read_control_structure): Update.
1524         (read_command_lines, read_command_lines_1): Return counted_command_line.
1525         (free_command_lines): Use "delete".
1526         (copy_command_lines): Remove.
1527         (define_command, document_command, show_user_1): Update.
1528         * cli/cli-decode.h (struct cmd_list_element) <user_commands>: Now
1529         a counted_command_line.
1530         * breakpoint.h (counted_command_line): Remove typedef.
1531         (breakpoint_set_commands): Update.
1532         * breakpoint.c (check_no_tracepoint_commands)
1533         (validate_commands_for_breakpoint): Update.
1534         (breakpoint_set_commands): Change commands to be a
1535         counted_command_line.
1536         (commands_command_1, update_dprintf_command_list)
1537         (create_tracepoint_from_upload): Update.
1538
1539 2018-05-04  Tom Tromey  <tom@tromey.com>
1540
1541         * cli/cli-decode.h (cmd_list_element): New constructor.
1542         (~cmd_list_element): New destructor.
1543         (struct cmd_list_element): Add initializers.
1544         * cli/cli-decode.c (do_add_cmd): Use "new".
1545         (delete_cmd): Use "delete".
1546
1547 2018-05-04  Jan Kratochvil  <jan.kratochvil@redhat.com>
1548             Pedro Alves <palves@redhat.com>
1549
1550         PR breakpoints/19806 and support for PR external/20207.
1551         * NEWS: Mention Aarch64 watchpoint improvements.
1552         * aarch64-linux-nat.c (aarch64_linux_stopped_data_address): Fix missed
1553         watchpoints and PR external/20207 watchpoints.
1554         * nat/aarch64-linux-hw-point.c
1555         (kernel_supports_any_contiguous_range): New.
1556         (aarch64_watchpoint_offset): New.
1557         (aarch64_watchpoint_length): Support PR external/20207 watchpoints.
1558         (aarch64_point_encode_ctrl_reg): New parameter offset, new asserts.
1559         (aarch64_point_is_aligned): Support PR external/20207 watchpoints.
1560         (aarch64_align_watchpoint): New parameters aligned_offset_p and
1561         next_addr_orig_p.  Support PR external/20207 watchpoints.
1562         (aarch64_downgrade_regs): New.
1563         (aarch64_dr_state_insert_one_point): New parameters offset and
1564         addr_orig.
1565         (aarch64_dr_state_remove_one_point): Likewise.
1566         (aarch64_handle_breakpoint): Update caller.
1567         (aarch64_handle_aligned_watchpoint): Likewise.
1568         (aarch64_handle_unaligned_watchpoint): Support addr_orig and
1569         aligned_offset.
1570         (aarch64_linux_set_debug_regs): Remove const from state.  Call
1571         aarch64_downgrade_regs.
1572         (aarch64_show_debug_reg_state): Print also dr_addr_orig_wp.
1573         * nat/aarch64-linux-hw-point.h (DR_CONTROL_LENGTH): Rename to ...
1574         (DR_CONTROL_MASK): ... this.
1575         (struct aarch64_debug_reg_state): New field dr_addr_orig_wp.
1576         (unsigned int aarch64_watchpoint_offset): New prototype.
1577         (aarch64_linux_set_debug_regs): Remove const from state.
1578         * utils.c (align_up, align_down): Move to ...
1579         * common/common-utils.c (align_up, align_down): ... here.
1580         * utils.h (align_up, align_down): Move to ...
1581         * common/common-utils.h (align_up, align_down): ... here.
1582
1583 2018-05-04  Joel Brobecker  <brobecker@adacore.com>
1584
1585         * sparc-tdep.c (sparc_structure_return_p): Re-implement to
1586         match the ABI as summarized in GCC's gcc/config/sparc/sparc.c.
1587         (sparc_arg_by_memory_p): Renamed from sparc_arg_on_registers_p.
1588         Re-implement to match the ABI as summarized in GCC's
1589         gcc/config/sparc/sparc.c.  All callers updated.
1590         (sparc32_store_arguments): Remove assertion.
1591
1592 2018-05-04  Tom Tromey  <tom@tromey.com>
1593
1594         * printcmd.c: Don't include tui.h.
1595         (decode_format): Use skip_spaces.
1596
1597 2018-05-04  Tom Tromey  <tom@tromey.com>
1598
1599         PR gdb/22619:
1600         * printcmd.c (last_count): New global.
1601         (x_command): Use saved count when repeating.
1602
1603 2018-05-04  Tom Tromey  <tom@tromey.com>
1604
1605         * nto-procfs.c (do_closedir_cleanup): Remove.
1606         (procfs_pidlist): Use gdb_dir_up.
1607         * procfs.c (do_closedir_cleanup): Remove.
1608         (proc_update_threads): Use gdb_dir_up.
1609         * common/filestuff.h (struct gdb_dir_deleter): New.
1610         (gdb_dir_up): New typedef.
1611
1612 2018-05-04  Tom Tromey  <tom@tromey.com>
1613
1614         * ada-lang.c (print_mention_exception): Use std::string.
1615
1616 2018-05-04  Tom Tromey  <tom@tromey.com>
1617
1618         * ada-lang.c (create_excep_cond_exprs): Update.
1619         (ada_exception_catchpoint_cond_string): Use std::string.
1620
1621 2018-05-04  Tom Tromey  <tom@tromey.com>
1622
1623         * ada-lang.c (xget_renaming_scope): Return std::string.
1624         (old_renaming_is_invisible): Update.
1625
1626 2018-05-04  Tom Tromey  <tom@tromey.com>
1627
1628         * bfd-target.c (target_bfd::m_bfd): Now a gdb_bfd_ref_ptr.
1629         (target_bfd::target_bfd, target_bfd::~target_bfd): Update.
1630
1631 2018-05-04  Ulrich Weigand  <uweigand@de.ibm.com>
1632
1633         * spu-linux-nat.c (spu_linux_nat_target::wait): Fix syntax error.
1634
1635 2018-05-04  Tom Tromey  <tom@tromey.com>
1636
1637         * remote.c (remote_query_supported_append): Change type.
1638         (remote_check_symbols): Update.
1639
1640 2018-05-04  Paul Pluzhnikov  <ppluzhnikov@google.com>
1641
1642         PR gdb/11420
1643         * configure.ac: Prepend libpython.
1644         * python/python-config.py: Likewise.
1645         * configure: Regenerate.
1646
1647 2018-05-03  Simon Marchi  <simon.marchi@ericsson.com>
1648
1649         * Makefile.in (%.c: %.l): Use -t instead of --stdout.
1650
1651 2018-05-03  Pedro Alves  <palves@redhat.com>
1652
1653         * s390-linux-nat.c
1654         (s390_linux_nat_target::have_continuable_watchpoint): Mark with
1655         override.  Write 'true' instead of '1'.
1656         (s390_linux_nat_target::watchpoint_addr_within_range): Remove
1657         declaration.
1658
1659 2018-05-02  Pedro Alves  <palves@redhat.com>
1660
1661         * aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Use
1662         add_inf_child_target.
1663         * aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Use
1664         add_inf_child_target.
1665         * aix-thread.c (aix_thread_target_info): New.
1666         (aix_thread_target) <shortname, longname, doc>: Delete.
1667         <info>: New.
1668         * alpha-bsd-nat.c (_initialize_alphabsd_nat): Use
1669         add_inf_child_target.
1670         * alpha-linux-nat.c (_initialize_alpha_linux_nat): Use
1671         add_inf_child_target.
1672         * amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Use
1673         add_inf_child_target.
1674         * amd64-linux-nat.c (_initialize_amd64_linux_nat): Use
1675         add_inf_child_target.
1676         * amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Use
1677         add_inf_child_target.
1678         * amd64-obsd-nat.c (_initialize_amd64obsd_nat): Use
1679         add_inf_child_target.
1680         * arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Use
1681         add_inf_child_target.
1682         * arm-linux-nat.c (_initialize_arm_linux_nat): Use
1683         add_inf_child_target.
1684         * arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Use
1685         add_inf_child_target.
1686         * bfd-target.c (target_bfd_target_info): New.
1687         (target_bfd) <shortname, longname, doc>: Delete.
1688         <info>: New.
1689         * bsd-kvm.c (bsd_kvm_target_info): New.
1690         (bsd_kvm_target) <shortname, longname, doc>: Delete.
1691         <info>: New.
1692         (bsd_kvm_target::open): Rename to ...
1693         (bsd_kvm_target_open): ... this.  Adjust.
1694         * bsd-uthread.c (bsd_uthread_target_info): New.
1695         (bsd_uthread_target) <shortname, longname, doc>: Delete.
1696         <info>: New.
1697         * corefile.c (core_file_command): Adjust.
1698         * corelow.c (core_target_info): New.
1699         (core_target) <shortname, longname, doc>: Delete.
1700         <info>: New.
1701         (core_target::open): Rename to ...
1702         (core_target_open): ... this.  Adjust.
1703         * ctf.c (ctf_target_info): New.
1704         (ctf_target) <shortname, longname, doc>: Delete.
1705         <info>: New.
1706         (ctf_target::open): Rename to ...
1707         (ctf_target_open): ... this.
1708         (_initialize_ctf): Adjust.
1709         * exec.c (exec_target_info): New.
1710         (exec_target) <shortname, longname, doc>: Delete.
1711         <info>: New.
1712         (exec_target::open): Rename to ...
1713         (exec_target_open): ... this.
1714         * gdbcore.h (core_target_open): Declare.
1715         * go32-nat.c (_initialize_go32_nat): Use add_inf_child_target.
1716         * hppa-linux-nat.c (_initialize_hppa_linux_nat): Use
1717         add_inf_child_target.
1718         * hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Use
1719         add_inf_child_target.
1720         * hppa-obsd-nat.c (_initialize_hppaobsd_nat): Use
1721         add_inf_child_target.
1722         * i386-darwin-nat.c (_initialize_i386_darwin_nat): Use
1723         add_inf_child_target.
1724         * i386-fbsd-nat.c (_initialize_i386fbsd_nat): Use
1725         add_inf_child_target.
1726         * i386-gnu-nat.c (_initialize_i386gnu_nat): Use
1727         add_inf_child_target.
1728         * i386-linux-nat.c (_initialize_i386_linux_nat): Use
1729         add_inf_child_target.
1730         * i386-nbsd-nat.c (_initialize_i386nbsd_nat): Use
1731         add_inf_child_target.
1732         * i386-obsd-nat.c (_initialize_i386obsd_nat): Use
1733         add_inf_child_target.
1734         * ia64-linux-nat.c (_initialize_ia64_linux_nat): Use
1735         add_inf_child_target.
1736         * inf-child.c (inf_child_target_info): New.
1737         (inf_child_target::info): New.
1738         (inf_child_open_target): Remove 'target' parameter.  Use
1739         get_native_target instead.
1740         (inf_child_target::open): Delete.
1741         (add_inf_child_target): New.
1742         * inf-child.h (inf_child_target) <shortname, longname, doc, open>:
1743         Delete.
1744         <info>: New.
1745         (add_inf_child_target): Declare.
1746         (inf_child_open_target): Declare.
1747         * linux-thread-db.c (thread_db_target_info): New.
1748         (thread_db_target) <shortname, longname, doc>: Delete.
1749         <info>: New.
1750         * m32r-linux-nat.c (_initialize_m32r_linux_nat): Use
1751         add_inf_child_target.
1752         * m68k-bsd-nat.c (_initialize_m68kbsd_nat): Use
1753         add_inf_child_target.
1754         * m68k-linux-nat.c (_initialize_m68k_linux_nat): Use
1755         add_inf_child_target.
1756         * m88k-bsd-nat.c (_initialize_m88kbsd_nat): Use
1757         add_inf_child_target.
1758         * make-target-delegates (print_class): Adjust.
1759         * mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Use
1760         add_inf_child_target.
1761         * mips-linux-nat.c (_initialize_mips_linux_nat): Use
1762         add_inf_child_target.
1763         * mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Use
1764         add_inf_child_target.
1765         * mips64-obsd-nat.c (_initialize_mips64obsd_nat): Use
1766         add_inf_child_target.
1767         * nto-procfs.c (nto_native_target_info): New.
1768         (nto_procfs_target_native) <shortname, longname, doc>:
1769         Delete.
1770         <info>: New.
1771         (nto_procfs_target_info): New.
1772         (nto_procfs_target_procfs) <shortname, longname, doc>:
1773         Delete.
1774         <info>: New.
1775         (init_procfs_targets): Adjust.
1776         * ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Use
1777         add_inf_child_target.
1778         * ppc-linux-nat.c (_initialize_ppc_linux_nat): Use
1779         add_inf_child_target.
1780         * ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Use
1781         add_inf_child_target.
1782         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Use
1783         add_inf_child_target.
1784         * ravenscar-thread.c (ravenscar_target_info): New.
1785         (ravenscar_thread_target) <shortname, longname, doc>:
1786         Delete.
1787         <info>: New.
1788         * record-btrace.c (record_btrace_target_info):
1789         (record_btrace_target) <shortname, longname, doc>: Delete.
1790         <info>: New.
1791         (record_btrace_target::open): Rename to ...
1792         (record_btrace_target_open): ... this.  Adjust.
1793         * record-full.c (record_longname, record_doc): New.
1794         (record_full_base_target) <shortname, longname, doc>: Delete.
1795         <info>: New.
1796         (record_full_target_info): New.
1797         (record_full_target): <shortname>: Delete.
1798         <info>: New.
1799         (record_full_core_open_1, record_full_open_1): Update comments.
1800         (record_full_base_target::open): Rename to ...
1801         (record_full_open): ... this.
1802         (cmd_record_full_restore): Update.
1803         (_initialize_record_full): Update.
1804         * remote-sim.c (remote_sim_target_info): New.
1805         (gdbsim_target) <shortname, longname, doc>: Delete.
1806         <info>: New.
1807         (gdbsim_target::open): Rename to ...
1808         (gdbsim_target_open): ... this.
1809         (_initialize_remote_sim): Adjust.
1810         * remote.c (remote_doc): New.
1811         (remote_target_info): New.
1812         (remote_target) <shortname, longname, doc>: Delete.
1813         <info>: New.
1814         (extended_remote_target_info): New.
1815         (extended_remote_target) <shortname, longname, doc>: Delete.
1816         <info>: New.
1817         (remote_target::open_1): Make static.  Adjust.
1818         * rs6000-nat.c (_initialize_rs6000_nat): Use add_inf_child_target.
1819         * s390-linux-nat.c (_initialize_s390_nat): Use
1820         add_inf_child_target.
1821         * sh-nbsd-nat.c (_initialize_shnbsd_nat): Use
1822         add_inf_child_target.
1823         * sol-thread.c (thread_db_target_info): New.
1824         (sol_thread_target) <shortname, longname, doc>: Delete.
1825         <info>: New.
1826         * sparc-linux-nat.c (_initialize_sparc_linux_nat): Use
1827         add_inf_child_target.
1828         * sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Use
1829         add_inf_child_target.
1830         * sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Use
1831         add_inf_child_target.
1832         * sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Use
1833         add_inf_child_target.
1834         * sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Use
1835         add_inf_child_target.
1836         * sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Use
1837         add_inf_child_target.
1838         * spu-linux-nat.c (_initialize_spu_nat): Use
1839         add_inf_child_target.
1840         * spu-multiarch.c (spu_multiarch_target_info): New.
1841         (spu_multiarch_target) <shortname, longname, doc>: Delete.
1842         <info>: New.
1843         * target-delegates.c: Regenerate.
1844         * target.c: Include <unordered_map>.
1845         (target_ops_p): Delete.
1846         (DEF_VEC_P(target_ops_p)): Delete.
1847         (target_factories): New.
1848         (test_target_info): New.
1849         (test_target_ops::info): New.
1850         (open_target): Adjust to use target_factories.
1851         (add_target_with_completer): Rename to ...
1852         (add_target): ... this.  Change prototype.  Register target_info
1853         and open callback in target_factories.  Register target_info in
1854         command context instead of target_ops.
1855         (add_target): Delete old implementation.
1856         (add_deprecated_target_alias): Change prototype.  Adjust.
1857         (the_native_target): New.
1858         (set_native_target, get_native_target): New.
1859         (find_default_run_target): Use the_native_target.
1860         (find_attach_target, find_run_target): Simplify.
1861         (target_ops::open): Delete.
1862         (dummy_target_info): New.
1863         (dummy_target::shortname, dummy_target::longname)
1864         (dummy_target::doc): Delete.
1865         (dummy_target::info): New.
1866         (debug_target::shortname, debug_target::longname)
1867         (debug_target::doc): Delete.
1868         (debug_target::info): New.
1869         * target.h (struct target_info): New.
1870         (target_ops::~target_ops): Add comment.
1871         (target_ops::info): New.
1872         (target_ops::shortname, target_ops::longname, target_ops::doc): No
1873         longer virtual.  Implement in terms of target_info.
1874         (set_native_target, get_native_target): Declare.
1875         (target_open_ftype): New.
1876         (add_target, add_target_with_completer)
1877         (add_deprecated_target_alias): Change prototype.
1878         (test_target) <shortname, longname, doc>: Delete.
1879         <info>: New.
1880         * tilegx-linux-nat.c (_initialize_tile_linux_nat): Use
1881         add_inf_child_target.
1882         * tracefile-tfile.c (tfile_target_info): New.
1883         (tfile_target) <shortname, longname, doc>: Delete.
1884         <info>: New.
1885         (tfile_target::open): Rename to ...
1886         (tfile_target_open): ... this.
1887         (_initialize_tracefile_tfile): Adjust.
1888         * vax-bsd-nat.c (_initialize_vaxbsd_nat): Use
1889         add_inf_child_target.
1890         * windows-nat.c (_initialize_windows_nat): Use
1891         add_inf_child_target.
1892         * xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Use
1893         add_inf_child_target.
1894
1895 2018-05-02  Pedro Alves  <palves@redhat.com>
1896
1897         * linux-nat.h (linux_nat_target) <low_new_thread,
1898         low_delete_thread, low_new_fork, low_forget_process,
1899         low_prepare_to_resume, low_siginfo_fixup, low_status_is_event>:
1900         New virtual methods.
1901         (linux_nat_set_new_thread, linux_nat_set_delete_thread)
1902         (linux_nat_new_fork_ftype, linux_nat_set_new_fork)
1903         (linux_nat_forget_process_ftype, linux_nat_set_forget_process)
1904         (linux_nat_forget_process, linux_nat_set_siginfo_fixup)
1905         (linux_nat_set_prepare_to_resume, linux_nat_set_status_is_event):
1906         Delete.
1907         * linux-fork.c (delete_fork): Adjust to call low method.
1908         * linux-nat.c (linux_nat_new_thread, linux_nat_delete_thread)
1909         (linux_nat_new_fork, linux_nat_forget_process_hook)
1910         (linux_nat_prepare_to_resume, linux_nat_siginfo_fixup)
1911         (linux_nat_status_is_event):
1912         (linux_nat_target::follow_fork, lwp_free, add_lwp, detach_one_lwp)
1913         (linux_resume_one_lwp_throw, linux_handle_extended_wait): Adjust
1914         to call low method.
1915         (sigtrap_is_event): Rename to ...
1916         (linux_nat_target::low_status_is_event): ... this.
1917         (linux_nat_set_status_is_event): Delete.
1918         (save_stop_reason, linux_nat_wait_1)
1919         (linux_nat_target::mourn_inferior, siginfo_fixup): Adjust to call
1920         low methods.
1921         (linux_nat_set_new_thread, linux_nat_set_delete_thread)
1922         (linux_nat_set_new_fork, linux_nat_set_forget_process)
1923         (linux_nat_forget_process, linux_nat_set_siginfo_fixup)
1924         (linux_nat_set_prepare_to_resume): Delete.
1925         * aarch64-linux-nat.c: All linux_nat_set_* callbacks converted to
1926         low virtual methods.
1927         * amd64-linux-nat.c: Likewise.
1928         * arm-linux-nat.c: Likewise.
1929         * i386-linux-nat.c: Likewise.
1930         * ia64-linux-nat.c: Likewise.
1931         * mips-linux-nat.c: Likewise.
1932         * ppc-linux-nat.c: Likewise.
1933         * s390-linux-nat.c: Likewise.
1934         * sparc64-linux-nat.c: Likewise.
1935         * x86-linux-nat.c: Likewise.
1936         * x86-linux-nat.h: Include "nat/x86-linux.h".
1937         (x86_linux_nat_target) <low_new_fork, low_forget_process,
1938         low_prepare_to_resume, low_new_thread, low_delete_thread>:
1939         Override methods.
1940
1941 2018-05-02  Pedro Alves  <palves@redhat.com>
1942
1943         * target.h (target_ops)
1944         <stopped_by_sw_breakpoint, supports_stopped_by_sw_breakpoint,
1945         stopped_by_hw_breakpoint, supports_stopped_by_hw_breakpoint,
1946         stopped_by_watchpoint, have_continuable_watchpoint,
1947         stopped_data_address, watchpoint_addr_within_range,
1948         can_accel_watchpoint_condition, can_run, thread_alive,
1949         has_all_memory, has_memory, has_stack, has_registers,
1950         has_execution, can_async_p, is_async_p, supports_non_stop,
1951         always_non_stop_p, can_execute_reverse, supports_multi_process,
1952         supports_enable_disable_tracepoint,
1953         supports_disable_randomization, supports_string_tracing,
1954         supports_evaluation_of_breakpoint_conditions,
1955         can_run_breakpoint_commands, filesystem_is_local,
1956         can_download_tracepoint, get_trace_state_variable_value,
1957         set_trace_notes, get_tib_address, use_agent, can_use_agent,
1958         record_is_replaying, record_will_replay,
1959         augmented_libraries_svr4_read>: Adjust to return bool.
1960         * aarch64-linux-nat.c: All implementations adjusted.
1961         * aix-thread.c: All implementations adjusted.
1962         * arm-linux-nat.c: All implementations adjusted.
1963         * breakpoint.c: All implementations adjusted.
1964         * bsd-kvm.c: All implementations adjusted.
1965         * bsd-uthread.c: All implementations adjusted.
1966         * corelow.c: All implementations adjusted.
1967         * ctf.c: All implementations adjusted.
1968         * darwin-nat.c: All implementations adjusted.
1969         * darwin-nat.h: All implementations adjusted.
1970         * exec.c: All implementations adjusted.
1971         * fbsd-nat.c: All implementations adjusted.
1972         * fbsd-nat.h: All implementations adjusted.
1973         * gnu-nat.c: All implementations adjusted.
1974         * gnu-nat.h: All implementations adjusted.
1975         * go32-nat.c: All implementations adjusted.
1976         * ia64-linux-nat.c: All implementations adjusted.
1977         * inf-child.c: All implementations adjusted.
1978         * inf-child.h: All implementations adjusted.
1979         * inf-ptrace.c: All implementations adjusted.
1980         * inf-ptrace.h: All implementations adjusted.
1981         * linux-nat.c: All implementations adjusted.
1982         * linux-nat.h: All implementations adjusted.
1983         * mips-linux-nat.c: All implementations adjusted.
1984         * nto-procfs.c: All implementations adjusted.
1985         * ppc-linux-nat.c: All implementations adjusted.
1986         * procfs.c: All implementations adjusted.
1987         * ravenscar-thread.c: All implementations adjusted.
1988         * record-btrace.c: All implementations adjusted.
1989         * record-full.c: All implementations adjusted.
1990         * remote-sim.c: All implementations adjusted.
1991         * remote.c: All implementations adjusted.
1992         * s390-linux-nat.c: All implementations adjusted.
1993         * sol-thread.c: All implementations adjusted.
1994         * spu-multiarch.c: All implementations adjusted.
1995         * target-delegates.c: All implementations adjusted.
1996         * target.c: All implementations adjusted.
1997         * target.h: All implementations adjusted.
1998         * tracefile-tfile.c: All implementations adjusted.
1999         * tracefile.c: All implementations adjusted.
2000         * tracefile.h: All implementations adjusted.
2001         * windows-nat.c: All implementations adjusted.
2002         * x86-linux-nat.h: All implementations adjusted.
2003         * x86-nat.h: All implementations adjusted.
2004
2005 2018-05-02  Pedro Alves  <palves@redhat.com>
2006
2007         * make-target-delegates (scan_target_h): Don't trim lines here.
2008         Replace sequences of tabs and/or whitespace with a single
2009         whitespace.
2010         (top level, parsing methods): Trim each line before processing it
2011         here.
2012
2013 2018-05-02  Pedro Alves  <palves@redhat.com>
2014             John Baldwin  <jhb@freebsd.org>
2015
2016         * target.h (enum strata) <debug_stratum>: New.
2017         (struct target_ops) <all delegation methods>: Replace by C++
2018         virtual methods, and drop "to_" prefix.  All references updated
2019         throughout.
2020         <to_shortname, to_longname, to_doc, to_data,
2021         to_have_steppable_watchpoint, to_have_continuable_watchpoint,
2022         to_has_thread_control, to_attach_no_wait>: Delete, replaced by
2023         virtual methods.  All references updated throughout.
2024         <can_attach, supports_terminal_ours, can_create_inferior,
2025         get_thread_control_capabilities, attach_no_wait>: New
2026         virtual methods.
2027         <insert_breakpoint, remove_breakpoint>: Now
2028         TARGET_DEFAULT_NORETURN methods.
2029         <info_proc>: Now returns bool.
2030         <to_magic>: Delete.
2031         (OPS_MAGIC): Delete.
2032         (current_target): Delete.  All references replaced by references
2033         to ...
2034         (target_stack): ... this.  New.
2035         (target_shortname, target_longname): Adjust.
2036         (target_can_run): Now a function declaration.
2037         (default_child_has_all_memory, default_child_has_memory)
2038         (default_child_has_stack, default_child_has_registers)
2039         (default_child_has_execution): Remove target_ops parameter.
2040         (complete_target_initialization): Delete.
2041         (memory_breakpoint_target): New template class.
2042         (test_target_ops): Refactor as a C++ class with virtual methods.
2043         * make-target-delegates (NAME_PART): Tighten.
2044         (POINTER_PART, CP_SYMBOL): New.
2045         (SIMPLE_RETURN_PART): Reimplement.
2046         (VEC_RETURN_PART): Expect less.
2047         (RETURN_PART, VIRTUAL_PART): New.
2048         (METHOD): Adjust to C++ virtual methods.
2049         (scan_target_h): Remove reference to C99.
2050         (dname): Output "target_ops::" prefix.
2051         (write_function_header): Adjust to output a C++ class method.
2052         (write_declaration): New.
2053         (write_delegator): Adjust to output a C++ class method.
2054         (tdname): Output "dummy_target::" prefix.
2055         (write_tdefault, write_debugmethod): Adjust to output a C++ class
2056         method.
2057         (tdefault_names, debug_names): Delete.
2058         (return_types, tdefaults, styles, argtypes_array): New.
2059         (top level): All methods are delegators.
2060         (print_class): New.
2061         (top level): Print dummy_target and debug_target classes.
2062         * target-delegates.c: Regenerate.
2063         * target-debug.h (target_debug_print_enum_info_proc_what)
2064         (target_debug_print_thread_control_capabilities)
2065         (target_debug_print_thread_info_p): New.
2066         * target.c (dummy_target): Delete.
2067         (the_dummy_target, the_debug_target): New.
2068         (target_stack): Now extern.
2069         (set_targetdebug): Push/unpush debug target.
2070         (default_child_has_all_memory, default_child_has_memory)
2071         (default_child_has_stack, default_child_has_registers)
2072         (default_child_has_execution): Remove target_ops parameter.
2073         (complete_target_initialization): Delete.
2074         (add_target_with_completer): No longer call
2075         complete_target_initialization.
2076         (target_supports_terminal_ours): Use regular delegation.
2077         (update_current_target): Delete.
2078         (push_target): No longer check magic number.  Don't call
2079         update_current_target.
2080         (unpush_target): Don't call update_current_target.
2081         (target_is_pushed): No longer check magic number.
2082         (target_require_runnable): Skip for all stratums over
2083         process_stratum.
2084         (target_ops::info_proc): New.
2085         (target_info_proc): Use find_target_at and
2086         find_default_run_target.
2087         (target_supports_disable_randomization): Use regular delegation.
2088         (target_get_osdata): Use find_target_at.
2089         (target_ops::open, target_ops::close, target_ops::can_attach)
2090         (target_ops::attach, target_ops::can_create_inferior)
2091         (target_ops::create_inferior, target_ops::can_run)
2092         (target_can_run): New.
2093         (default_fileio_target): Use regular delegation.
2094         (target_ops::fileio_open, target_ops::fileio_pwrite)
2095         (target_ops::fileio_pread, target_ops::fileio_fstat)
2096         (target_ops::fileio_close, target_ops::fileio_unlink)
2097         (target_ops::fileio_readlink): New.
2098         (target_fileio_open_1, target_fileio_unlink)
2099         (target_fileio_readlink): Always call the target method.  Handle
2100         FILEIO_ENOSYS.
2101         (return_zero, return_zero_has_execution): Delete.
2102         (init_dummy_target): Delete.
2103         (dummy_target::dummy_target, dummy_target::shortname)
2104         (dummy_target::longname, dummy_target::doc)
2105         (debug_target::debug_target, debug_target::shortname)
2106         (debug_target::longname, debug_target::doc): New.
2107         (target_supports_delete_record): Use regular delegation.
2108         (setup_target_debug): Delete.
2109         (maintenance_print_target_stack): Skip debug_stratum.
2110         (initialize_targets): Instantiate the_dummy_target and
2111         the_debug_target.
2112         * auxv.c (target_auxv_parse): Remove 'ops' parameter.  Adjust to
2113         use target_stack.
2114         (target_auxv_search, fprint_target_auxv): Adjust.
2115         (info_auxv_command): Adjust to use target_stack.
2116         * auxv.h (target_auxv_parse): Remove 'ops' parameter.
2117         * exceptions.c (print_flush): Handle a NULL target_stack.
2118         * regcache.c (target_ops_no_register): Refactor as class with
2119         virtual methods.
2120
2121         * exec.c (exec_target): New class.
2122         (exec_ops): Now an exec_target.
2123         (exec_open, exec_close_1, exec_get_section_table)
2124         (exec_xfer_partial, exec_files_info, exec_has_memory)
2125         (exec_make_note_section): Refactor as exec_target methods.
2126         (exec_file_clear, ignore, exec_remove_breakpoint, init_exec_ops):
2127         Delete.
2128         (exec_target::find_memory_regions): New.
2129         (_initialize_exec): Don't call init_exec_ops.
2130         * gdbcore.h (exec_file_clear): Delete.
2131
2132         * corefile.c (core_target): Delete.
2133         (core_file_command): Adjust.
2134         * corelow.c (core_target): New class.
2135         (the_core_target): New.
2136         (core_close): Remove target_ops parameter.
2137         (core_close_cleanup): Adjust.
2138         (core_target::close): New.
2139         (core_open, core_detach, get_core_registers, core_files_info)
2140         (core_xfer_partial, core_thread_alive, core_read_description)
2141         (core_pid_to_str, core_thread_name, core_has_memory)
2142         (core_has_stack, core_has_registers, core_info_proc): Rework as
2143         core_target methods.
2144         (ignore, core_remove_breakpoint, init_core_ops): Delete.
2145         (_initialize_corelow): Initialize the_core_target.
2146         * gdbcore.h (core_target): Delete.
2147         (the_core_target): New.
2148
2149         * ctf.c: (ctf_target): New class.
2150         (ctf_ops): Now a ctf_target.
2151         (ctf_open, ctf_close, ctf_files_info, ctf_fetch_registers)
2152         (ctf_xfer_partial, ctf_get_trace_state_variable_value)
2153         (ctf_trace_find, ctf_traceframe_info): Refactor as ctf_target
2154         methods.
2155         (init_ctf_ops): Delete.
2156         (_initialize_ctf): Don't call it.
2157         * tracefile-tfile.c (tfile_target): New class.
2158         (tfile_ops): Now a tfile_target.
2159         (tfile_open, tfile_close, tfile_files_info)
2160         (tfile_get_tracepoint_status, tfile_trace_find)
2161         (tfile_fetch_registers, tfile_xfer_partial)
2162         (tfile_get_trace_state_variable_value, tfile_traceframe_info):
2163         Refactor as tfile_target methods.
2164         (tfile_xfer_partial_features): Remove target_ops parameter.
2165         (init_tfile_ops): Delete.
2166         (_initialize_tracefile_tfile): Don't call it.
2167         * tracefile.c (tracefile_has_all_memory, tracefile_has_memory)
2168         (tracefile_has_stack, tracefile_has_registers)
2169         (tracefile_thread_alive, tracefile_get_trace_status): Refactor as
2170         tracefile_target methods.
2171         (init_tracefile_ops): Delete.
2172         (tracefile_target::tracefile_target): New.
2173         * tracefile.h: Include "target.h".
2174         (tracefile_target): New class.
2175         (init_tracefile_ops): Delete.
2176
2177         * spu-multiarch.c (spu_multiarch_target): New class.
2178         (spu_ops): Now a spu_multiarch_target.
2179         (spu_thread_architecture, spu_region_ok_for_hw_watchpoint)
2180         (spu_fetch_registers, spu_store_registers, spu_xfer_partial)
2181         (spu_search_memory, spu_mourn_inferior): Refactor as
2182         spu_multiarch_target methods.
2183         (init_spu_ops): Delete.
2184         (_initialize_spu_multiarch): Remove references to init_spu_ops,
2185         complete_target_initialization.
2186
2187         * ravenscar-thread.c (ravenscar_thread_target): New class.
2188         (ravenscar_ops): Now a ravenscar_thread_target.
2189         (ravenscar_resume, ravenscar_wait, ravenscar_update_thread_list)
2190         (ravenscar_thread_alive, ravenscar_pid_to_str)
2191         (ravenscar_fetch_registers, ravenscar_store_registers)
2192         (ravenscar_prepare_to_store, ravenscar_stopped_by_sw_breakpoint)
2193         (ravenscar_stopped_by_hw_breakpoint)
2194         (ravenscar_stopped_by_watchpoint, ravenscar_stopped_data_address)
2195         (ravenscar_mourn_inferior, ravenscar_core_of_thread)
2196         (ravenscar_get_ada_task_ptid): Refactor as ravenscar_thread_target
2197         methods.
2198         (init_ravenscar_thread_ops): Delete.
2199         (_initialize_ravenscar): Remove references to
2200         init_ravenscar_thread_ops and complete_target_initialization.
2201
2202         * bsd-uthread.c (bsd_uthread_ops_hack): Delete.
2203         (bsd_uthread_target): New class.
2204         (bsd_uthread_ops): Now a bsd_uthread_target.
2205         (bsd_uthread_activate): Adjust to refer to bsd_uthread_ops.
2206         (bsd_uthread_close, bsd_uthread_mourn_inferior)
2207         (bsd_uthread_fetch_registers, bsd_uthread_store_registers)
2208         (bsd_uthread_wait, bsd_uthread_resume, bsd_uthread_thread_alive)
2209         (bsd_uthread_update_thread_list, bsd_uthread_extra_thread_info)
2210         (bsd_uthread_pid_to_str): Refactor as bsd_uthread_target methods.
2211         (bsd_uthread_target): Delete function.
2212         (_initialize_bsd_uthread): Remove reference to
2213         complete_target_initialization.
2214
2215         * bfd-target.c (target_bfd_data): Delete.  Fields folded into ...
2216         (target_bfd): ... this new class.
2217         (target_bfd_xfer_partial, target_bfd_get_section_table)
2218         (target_bfd_close): Refactor as target_bfd methods.
2219         (target_bfd::~target_bfd): New.
2220         (target_bfd_reopen): Adjust.
2221         (target_bfd::close): New.
2222
2223         * record-btrace.c (record_btrace_target): New class.
2224         (record_btrace_ops): Now a record_btrace_target.
2225         (record_btrace_open, record_btrace_stop_recording)
2226         (record_btrace_disconnect, record_btrace_close)
2227         (record_btrace_async, record_btrace_info)
2228         (record_btrace_insn_history, record_btrace_insn_history_range)
2229         (record_btrace_insn_history_from, record_btrace_call_history)
2230         (record_btrace_call_history_range)
2231         (record_btrace_call_history_from, record_btrace_record_method)
2232         (record_btrace_is_replaying, record_btrace_will_replay)
2233         (record_btrace_xfer_partial, record_btrace_insert_breakpoint)
2234         (record_btrace_remove_breakpoint, record_btrace_fetch_registers)
2235         (record_btrace_store_registers, record_btrace_prepare_to_store)
2236         (record_btrace_to_get_unwinder)
2237         (record_btrace_to_get_tailcall_unwinder, record_btrace_resume)
2238         (record_btrace_commit_resume, record_btrace_wait)
2239         (record_btrace_stop, record_btrace_can_execute_reverse)
2240         (record_btrace_stopped_by_sw_breakpoint)
2241         (record_btrace_supports_stopped_by_sw_breakpoint)
2242         (record_btrace_stopped_by_hw_breakpoint)
2243         (record_btrace_supports_stopped_by_hw_breakpoint)
2244         (record_btrace_update_thread_list, record_btrace_thread_alive)
2245         (record_btrace_goto_begin, record_btrace_goto_end)
2246         (record_btrace_goto, record_btrace_stop_replaying_all)
2247         (record_btrace_execution_direction)
2248         (record_btrace_prepare_to_generate_core)
2249         (record_btrace_done_generating_core): Refactor as
2250         record_btrace_target methods.
2251         (init_record_btrace_ops): Delete.
2252         (_initialize_record_btrace): Remove reference to
2253         init_record_btrace_ops.
2254         * record-full.c (RECORD_FULL_IS_REPLAY): Adjust to always refer to
2255         the execution_direction global.
2256         (record_full_base_target, record_full_target)
2257         (record_full_core_target): New classes.
2258         (record_full_ops): Now a record_full_target.
2259         (record_full_core_ops): Now a record_full_core_target.
2260         (record_full_target::detach, record_full_target::disconnect)
2261         (record_full_core_target::disconnect)
2262         (record_full_target::mourn_inferior, record_full_target::kill):
2263         New.
2264         (record_full_open, record_full_close, record_full_async): Refactor
2265         as methods of the record_full_base_target class.
2266         (record_full_resume, record_full_commit_resume): Refactor
2267         as methods of the record_full_target class.
2268         (record_full_wait, record_full_stopped_by_watchpoint)
2269         (record_full_stopped_data_address)
2270         (record_full_stopped_by_sw_breakpoint)
2271         (record_full_supports_stopped_by_sw_breakpoint)
2272         (record_full_stopped_by_hw_breakpoint)
2273         (record_full_supports_stopped_by_hw_breakpoint): Refactor as
2274         methods of the record_full_base_target class.
2275         (record_full_store_registers, record_full_xfer_partial)
2276         (record_full_insert_breakpoint, record_full_remove_breakpoint):
2277         Refactor as methods of the record_full_target class.
2278         (record_full_can_execute_reverse, record_full_get_bookmark)
2279         (record_full_goto_bookmark, record_full_execution_direction)
2280         (record_full_record_method, record_full_info, record_full_delete)
2281         (record_full_is_replaying, record_full_will_replay)
2282         (record_full_goto_begin, record_full_goto_end, record_full_goto)
2283         (record_full_stop_replaying): Refactor as methods of the
2284         record_full_base_target class.
2285         (record_full_core_resume, record_full_core_kill)
2286         (record_full_core_fetch_registers)
2287         (record_full_core_prepare_to_store)
2288         (record_full_core_store_registers, record_full_core_xfer_partial)
2289         (record_full_core_insert_breakpoint)
2290         (record_full_core_remove_breakpoint)
2291         (record_full_core_has_execution): Refactor
2292         as methods of the record_full_core_target class.
2293         (record_full_base_target::supports_delete_record): New.
2294         (init_record_full_ops): Delete.
2295         (init_record_full_core_ops): Delete.
2296         (record_full_save): Refactor as method of the
2297         record_full_base_target class.
2298         (_initialize_record_full): Remove references to
2299         init_record_full_ops and init_record_full_core_ops.
2300
2301         * remote.c (remote_target, extended_remote_target): New classes.
2302         (remote_ops): Now a remote_target.
2303         (extended_remote_ops): Now an extended_remote_target.
2304         (remote_insert_fork_catchpoint, remote_remove_fork_catchpoint)
2305         (remote_insert_vfork_catchpoint, remote_remove_vfork_catchpoint)
2306         (remote_insert_exec_catchpoint, remote_remove_exec_catchpoint)
2307         (remote_pass_signals, remote_set_syscall_catchpoint)
2308         (remote_program_signals, )
2309         (remote_thread_always_alive): Remove target_ops parameter.
2310         (remote_thread_alive, remote_thread_name)
2311         (remote_update_thread_list, remote_threads_extra_info)
2312         (remote_static_tracepoint_marker_at)
2313         (remote_static_tracepoint_markers_by_strid)
2314         (remote_get_ada_task_ptid, remote_close, remote_start_remote)
2315         (remote_open): Refactor as methods of remote_target.
2316         (extended_remote_open, extended_remote_detach)
2317         (extended_remote_attach, extended_remote_post_attach):
2318         (extended_remote_supports_disable_randomization)
2319         (extended_remote_create_inferior): : Refactor as method of
2320         extended_remote_target.
2321         (remote_set_permissions, remote_open_1, remote_detach)
2322         (remote_follow_fork, remote_follow_exec, remote_disconnect)
2323         (remote_resume, remote_commit_resume, remote_stop)
2324         (remote_interrupt, remote_pass_ctrlc, remote_terminal_inferior)
2325         (remote_terminal_ours, remote_wait, remote_fetch_registers)
2326         (remote_prepare_to_store, remote_store_registers)
2327         (remote_flash_erase, remote_flash_done, remote_files_info)
2328         (remote_kill, remote_mourn, remote_insert_breakpoint)
2329         (remote_remove_breakpoint, remote_insert_watchpoint)
2330         (remote_watchpoint_addr_within_range)
2331         (remote_remove_watchpoint, remote_region_ok_for_hw_watchpoint)
2332         (remote_check_watch_resources, remote_stopped_by_sw_breakpoint)
2333         (remote_supports_stopped_by_sw_breakpoint)
2334         (remote_stopped_by_hw_breakpoint)
2335         (remote_supports_stopped_by_hw_breakpoint)
2336         (remote_stopped_by_watchpoint, remote_stopped_data_address)
2337         (remote_insert_hw_breakpoint, remote_remove_hw_breakpoint)
2338         (remote_verify_memory): Refactor as methods of remote_target.
2339         (remote_write_qxfer, remote_read_qxfer): Remove target_ops
2340         parameter.
2341         (remote_xfer_partial, remote_get_memory_xfer_limit)
2342         (remote_search_memory, remote_rcmd, remote_memory_map)
2343         (remote_pid_to_str, remote_get_thread_local_address)
2344         (remote_get_tib_address, remote_read_description): Refactor as
2345         methods of remote_target.
2346         (remote_target::fileio_open, remote_target::fileio_pwrite)
2347         (remote_target::fileio_pread, remote_target::fileio_close): New.
2348         (remote_hostio_readlink, remote_hostio_fstat)
2349         (remote_filesystem_is_local, remote_can_execute_reverse)
2350         (remote_supports_non_stop, remote_supports_disable_randomization)
2351         (remote_supports_multi_process, remote_supports_cond_breakpoints)
2352         (remote_supports_enable_disable_tracepoint)
2353         (remote_supports_string_tracing)
2354         (remote_can_run_breakpoint_commands, remote_trace_init)
2355         (remote_download_tracepoint, remote_can_download_tracepoint)
2356         (remote_download_trace_state_variable, remote_enable_tracepoint)
2357         (remote_disable_tracepoint, remote_trace_set_readonly_regions)
2358         (remote_trace_start, remote_get_trace_status)
2359         (remote_get_tracepoint_status, remote_trace_stop)
2360         (remote_trace_find, remote_get_trace_state_variable_value)
2361         (remote_save_trace_data, remote_get_raw_trace_data)
2362         (remote_set_disconnected_tracing, remote_core_of_thread)
2363         (remote_set_circular_trace_buffer, remote_traceframe_info)
2364         (remote_get_min_fast_tracepoint_insn_len)
2365         (remote_set_trace_buffer_size, remote_set_trace_notes)
2366         (remote_use_agent, remote_can_use_agent, remote_enable_btrace)
2367         (remote_disable_btrace, remote_teardown_btrace)
2368         (remote_read_btrace, remote_btrace_conf)
2369         (remote_augmented_libraries_svr4_read, remote_load)
2370         (remote_pid_to_exec_file, remote_can_do_single_step)
2371         (remote_execution_direction, remote_thread_handle_to_thread_info):
2372         Refactor as methods of remote_target.
2373         (init_remote_ops, init_extended_remote_ops): Delete.
2374         (remote_can_async_p, remote_is_async_p, remote_async)
2375         (remote_thread_events, remote_upload_tracepoints)
2376         (remote_upload_trace_state_variables): Refactor as methods of
2377         remote_target.
2378         (_initialize_remote): Remove references to init_remote_ops and
2379         init_extended_remote_ops.
2380
2381         * remote-sim.c (gdbsim_target): New class.
2382         (gdbsim_fetch_register, gdbsim_store_register, gdbsim_kill)
2383         (gdbsim_load, gdbsim_create_inferior, gdbsim_open, gdbsim_close)
2384         (gdbsim_detach, gdbsim_resume, gdbsim_interrupt)
2385         (gdbsim_wait, gdbsim_prepare_to_store, gdbsim_xfer_partial)
2386         (gdbsim_files_info, gdbsim_mourn_inferior, gdbsim_thread_alive)
2387         (gdbsim_pid_to_str, gdbsim_has_all_memory, gdbsim_has_memory):
2388         Refactor as methods of gdbsim_target.
2389         (gdbsim_ops): Now a gdbsim_target.
2390         (init_gdbsim_ops): Delete.
2391         (gdbsim_cntrl_c): Adjust.
2392         (_initialize_remote_sim): Remove reference to init_gdbsim_ops.
2393
2394         * amd64-linux-nat.c (amd64_linux_nat_target): New class.
2395         (the_amd64_linux_nat_target): New.
2396         (amd64_linux_fetch_inferior_registers)
2397         (amd64_linux_store_inferior_registers): Refactor as methods of
2398         amd64_linux_nat_target.
2399         (_initialize_amd64_linux_nat): Adjust.  Set linux_target.
2400         * i386-linux-nat.c: Don't include "linux-nat.h".
2401         (i386_linux_nat_target): New class.
2402         (the_i386_linux_nat_target): New.
2403         (i386_linux_fetch_inferior_registers)
2404         (i386_linux_store_inferior_registers, i386_linux_resume): Refactor
2405         as methods of i386_linux_nat_target.
2406         (_initialize_i386_linux_nat): Adjust.  Set linux_target.
2407         * inf-child.c (inf_child_ops): Delete.
2408         (inf_child_fetch_inferior_registers)
2409         (inf_child_store_inferior_registers): Delete.
2410         (inf_child_post_attach, inf_child_prepare_to_store): Refactor as
2411         methods of inf_child_target.
2412         (inf_child_target::supports_terminal_ours)
2413         (inf_child_target::terminal_init)
2414         (inf_child_target::terminal_inferior)
2415         (inf_child_target::terminal_ours_for_output)
2416         (inf_child_target::terminal_ours, inf_child_target::interrupt)
2417         (inf_child_target::pass_ctrlc, inf_child_target::terminal_info):
2418         New.
2419         (inf_child_open, inf_child_disconnect, inf_child_close)
2420         (inf_child_mourn_inferior, inf_child_maybe_unpush_target)
2421         (inf_child_post_startup_inferior, inf_child_can_run)
2422         (inf_child_pid_to_exec_file): Refactor as methods of
2423         inf_child_target.
2424         (inf_child_follow_fork): Delete.
2425         (inf_child_target::can_create_inferior)
2426         (inf_child_target::can_attach): New.
2427         (inf_child_target::has_all_memory, inf_child_target::has_memory)
2428         (inf_child_target::has_stack, inf_child_target::has_registers)
2429         (inf_child_target::has_execution): New.
2430         (inf_child_fileio_open, inf_child_fileio_pwrite)
2431         (inf_child_fileio_pread, inf_child_fileio_fstat)
2432         (inf_child_fileio_close, inf_child_fileio_unlink)
2433         (inf_child_fileio_readlink, inf_child_use_agent)
2434         (inf_child_can_use_agent): Refactor as methods of
2435         inf_child_target.
2436         (return_zero, inf_child_target): Delete.
2437         (inf_child_target::inf_child_target): New.
2438         * inf-child.h: Include "target.h".
2439         (inf_child_target): Delete function prototype.
2440         (inf_child_target): New class.
2441         (inf_child_open_target, inf_child_mourn_inferior)
2442         (inf_child_maybe_unpush_target): Delete.
2443         * inf-ptrace.c (inf_ptrace_target::~inf_ptrace_target): New.
2444         (inf_ptrace_follow_fork, inf_ptrace_insert_fork_catchpoint)
2445         (inf_ptrace_remove_fork_catchpoint, inf_ptrace_create_inferior)
2446         (inf_ptrace_post_startup_inferior, inf_ptrace_mourn_inferior)
2447         (inf_ptrace_attach, inf_ptrace_post_attach, inf_ptrace_detach)
2448         (inf_ptrace_detach_success, inf_ptrace_kill, inf_ptrace_resume)
2449         (inf_ptrace_wait, inf_ptrace_xfer_partial)
2450         (inf_ptrace_thread_alive, inf_ptrace_files_info)
2451         (inf_ptrace_pid_to_str, inf_ptrace_auxv_parse): Refactor as
2452         methods of inf_ptrace_target.
2453         (inf_ptrace_target): Delete function.
2454         * inf-ptrace.h: Include "inf-child.h".
2455         (inf_ptrace_target): Delete function declaration.
2456         (inf_ptrace_target): New class.
2457         (inf_ptrace_trad_target, inf_ptrace_detach_success): Delete.
2458         * linux-nat.c (linux_target): New.
2459         (linux_ops, linux_ops_saved, super_xfer_partial): Delete.
2460         (linux_nat_target::~linux_nat_target): New.
2461         (linux_child_post_attach, linux_child_post_startup_inferior)
2462         (linux_child_follow_fork, linux_child_insert_fork_catchpoint)
2463         (linux_child_remove_fork_catchpoint)
2464         (linux_child_insert_vfork_catchpoint)
2465         (linux_child_remove_vfork_catchpoint)
2466         (linux_child_insert_exec_catchpoint)
2467         (linux_child_remove_exec_catchpoint)
2468         (linux_child_set_syscall_catchpoint, linux_nat_pass_signals)
2469         (linux_nat_create_inferior, linux_nat_attach, linux_nat_detach)
2470         (linux_nat_resume, linux_nat_stopped_by_watchpoint)
2471         (linux_nat_stopped_data_address)
2472         (linux_nat_stopped_by_sw_breakpoint)
2473         (linux_nat_supports_stopped_by_sw_breakpoint)
2474         (linux_nat_stopped_by_hw_breakpoint)
2475         (linux_nat_supports_stopped_by_hw_breakpoint, linux_nat_wait)
2476         (linux_nat_kill, linux_nat_mourn_inferior)
2477         (linux_nat_xfer_partial, linux_nat_thread_alive)
2478         (linux_nat_update_thread_list, linux_nat_pid_to_str)
2479         (linux_nat_thread_name, linux_child_pid_to_exec_file)
2480         (linux_child_static_tracepoint_markers_by_strid)
2481         (linux_nat_is_async_p, linux_nat_can_async_p)
2482         (linux_nat_supports_non_stop, linux_nat_always_non_stop_p)
2483         (linux_nat_supports_multi_process)
2484         (linux_nat_supports_disable_randomization, linux_nat_async)
2485         (linux_nat_stop, linux_nat_close, linux_nat_thread_address_space)
2486         (linux_nat_core_of_thread, linux_nat_filesystem_is_local)
2487         (linux_nat_fileio_open, linux_nat_fileio_readlink)
2488         (linux_nat_fileio_unlink, linux_nat_thread_events): Refactor as
2489         methods of linux_nat_target.
2490         (linux_nat_wait_1, linux_xfer_siginfo, linux_proc_xfer_partial)
2491         (linux_proc_xfer_spu, linux_nat_xfer_osdata): Remove target_ops
2492         parameter.
2493         (check_stopped_by_watchpoint): Adjust.
2494         (linux_xfer_partial): Delete.
2495         (linux_target_install_ops, linux_target, linux_nat_add_target):
2496         Delete.
2497         (linux_nat_target::linux_nat_target): New.
2498         * linux-nat.h: Include "inf-ptrace.h".
2499         (linux_nat_target): New.
2500         (linux_target, linux_target_install_ops, linux_nat_add_target):
2501         Delete function declarations.
2502         (linux_target): Declare global.
2503         * linux-thread-db.c (thread_db_target): New.
2504         (thread_db_target::thread_db_target): New.
2505         (thread_db_ops): Delete.
2506         (the_thread_db_target): New.
2507         (thread_db_detach, thread_db_wait, thread_db_mourn_inferior)
2508         (thread_db_update_thread_list, thread_db_pid_to_str)
2509         (thread_db_extra_thread_info)
2510         (thread_db_thread_handle_to_thread_info)
2511         (thread_db_get_thread_local_address, thread_db_get_ada_task_ptid)
2512         (thread_db_resume): Refactor as methods of thread_db_target.
2513         (init_thread_db_ops): Delete.
2514         (_initialize_thread_db): Remove reference to init_thread_db_ops.
2515         * x86-linux-nat.c: Don't include "linux-nat.h".
2516         (super_post_startup_inferior): Delete.
2517         (x86_linux_nat_target::~x86_linux_nat_target): New.
2518         (x86_linux_child_post_startup_inferior)
2519         (x86_linux_read_description, x86_linux_enable_btrace)
2520         (x86_linux_disable_btrace, x86_linux_teardown_btrace)
2521         (x86_linux_read_btrace, x86_linux_btrace_conf): Refactor as
2522         methods of x86_linux_nat_target.
2523         (x86_linux_create_target): Delete.  Bits folded ...
2524         (x86_linux_add_target): ... here.  Now takes a linux_nat_target
2525         pointer.
2526         * x86-linux-nat.h: Include "linux-nat.h" and "x86-nat.h".
2527         (x86_linux_nat_target): New class.
2528         (x86_linux_create_target): Delete.
2529         (x86_linux_add_target): Now takes a linux_nat_target pointer.
2530         * x86-nat.c (x86_insert_watchpoint, x86_remove_watchpoint)
2531         (x86_region_ok_for_watchpoint, x86_stopped_data_address)
2532         (x86_stopped_by_watchpoint, x86_insert_hw_breakpoint)
2533         (x86_remove_hw_breakpoint, x86_can_use_hw_breakpoint)
2534         (x86_stopped_by_hw_breakpoint): Remove target_ops parameter and
2535         make extern.
2536         (x86_use_watchpoints): Delete.
2537         * x86-nat.h: Include "breakpoint.h" and "target.h".
2538         (x86_use_watchpoints): Delete.
2539         (x86_can_use_hw_breakpoint, x86_region_ok_for_hw_watchpoint)
2540         (x86_stopped_by_watchpoint, x86_stopped_data_address)
2541         (x86_insert_watchpoint, x86_remove_watchpoint)
2542         (x86_insert_hw_breakpoint, x86_remove_hw_breakpoint)
2543         (x86_stopped_by_hw_breakpoint): New declarations.
2544         (x86_nat_target): New template class.
2545
2546         * ppc-linux-nat.c (ppc_linux_nat_target): New class.
2547         (the_ppc_linux_nat_target): New.
2548         (ppc_linux_fetch_inferior_registers)
2549         (ppc_linux_can_use_hw_breakpoint)
2550         (ppc_linux_region_ok_for_hw_watchpoint)
2551         (ppc_linux_ranged_break_num_registers)
2552         (ppc_linux_insert_hw_breakpoint, ppc_linux_remove_hw_breakpoint)
2553         (ppc_linux_insert_mask_watchpoint)
2554         (ppc_linux_remove_mask_watchpoint)
2555         (ppc_linux_can_accel_watchpoint_condition)
2556         (ppc_linux_insert_watchpoint, ppc_linux_remove_watchpoint)
2557         (ppc_linux_stopped_data_address, ppc_linux_stopped_by_watchpoint)
2558         (ppc_linux_watchpoint_addr_within_range)
2559         (ppc_linux_masked_watch_num_registers)
2560         (ppc_linux_store_inferior_registers, ppc_linux_auxv_parse)
2561         (ppc_linux_read_description): Refactor as methods of
2562         ppc_linux_nat_target.
2563         (_initialize_ppc_linux_nat): Adjust.  Set linux_target.
2564
2565         * procfs.c (procfs_xfer_partial): Delete forward declaration.
2566         (procfs_target): New class.
2567         (the_procfs_target): New.
2568         (procfs_target): Delete function.
2569         (procfs_auxv_parse, procfs_attach, procfs_detach)
2570         (procfs_fetch_registers, procfs_store_registers, procfs_wait)
2571         (procfs_xfer_partial, procfs_resume, procfs_pass_signals)
2572         (procfs_files_info, procfs_kill_inferior, procfs_mourn_inferior)
2573         (procfs_create_inferior, procfs_update_thread_list)
2574         (procfs_thread_alive, procfs_pid_to_str)
2575         (procfs_can_use_hw_breakpoint, procfs_stopped_by_watchpoint)
2576         (procfs_stopped_data_address, procfs_insert_watchpoint)
2577         (procfs_remove_watchpoint, procfs_region_ok_for_hw_watchpoint)
2578         (proc_find_memory_regions, procfs_info_proc)
2579         (procfs_make_note_section): Refactor as methods of procfs_target.
2580         (_initialize_procfs): Adjust.
2581         * sol-thread.c (sol_thread_target): New class.
2582         (sol_thread_ops): Now a sol_thread_target.
2583         (sol_thread_detach, sol_thread_resume, sol_thread_wait)
2584         (sol_thread_fetch_registers, sol_thread_store_registers)
2585         (sol_thread_xfer_partial, sol_thread_mourn_inferior)
2586         (sol_thread_alive, solaris_pid_to_str, sol_update_thread_list)
2587         (sol_get_ada_task_ptid): Refactor as methods of sol_thread_target.
2588         (init_sol_thread_ops): Delete.
2589         (_initialize_sol_thread): Adjust.  Remove references to
2590         init_sol_thread_ops and complete_target_initialization.
2591
2592         * windows-nat.c (windows_nat_target): New class.
2593         (windows_fetch_inferior_registers)
2594         (windows_store_inferior_registers, windows_resume, windows_wait)
2595         (windows_attach, windows_detach, windows_pid_to_exec_file)
2596         (windows_files_info, windows_create_inferior)
2597         (windows_mourn_inferior, windows_interrupt, windows_kill_inferior)
2598         (windows_close, windows_pid_to_str, windows_xfer_partial)
2599         (windows_get_tib_address, windows_get_ada_task_ptid)
2600         (windows_thread_name, windows_thread_alive): Refactor as
2601         windows_nat_target methods.
2602         (do_initial_windows_stuff): Adjust.
2603         (windows_target): Delete function.
2604         (_initialize_windows_nat): Adjust.
2605
2606         * darwin-nat.c (darwin_resume, darwin_wait_to, darwin_interrupt)
2607         (darwin_mourn_inferior, darwin_kill_inferior)
2608         (darwin_create_inferior, darwin_attach, darwin_detach)
2609         (darwin_pid_to_str, darwin_thread_alive, darwin_xfer_partial)
2610         (darwin_pid_to_exec_file, darwin_get_ada_task_ptid)
2611         (darwin_supports_multi_process): Refactor as darwin_nat_target
2612         methods.
2613         (darwin_resume_to, darwin_files_info): Delete.
2614         (_initialize_darwin_inferior): Rename to ...
2615         (_initialize_darwin_nat): ... this.  Adjust to C++ification.
2616         * darwin-nat.h: Include "inf-child.h".
2617         (darwin_nat_target): New class.
2618         (darwin_complete_target): Delete.
2619         * i386-darwin-nat.c (i386_darwin_nat_target): New class.
2620         (darwin_target): New.
2621         (i386_darwin_fetch_inferior_registers)
2622         (i386_darwin_store_inferior_registers): Refactor as methods of
2623         darwin_nat_target.
2624         (darwin_complete_target): Delete, with ...
2625         (_initialize_i386_darwin_nat): ... bits factored out here.
2626
2627         * alpha-linux-nat.c (alpha_linux_nat_target): New class.
2628         (the_alpha_linux_nat_target): New.
2629         (alpha_linux_register_u_offset): Refactor as
2630         alpha_linux_nat_target method.
2631         (_initialize_alpha_linux_nat): Adjust.
2632         * linux-nat-trad.c (inf_ptrace_register_u_offset): Delete.
2633         (inf_ptrace_fetch_register, inf_ptrace_fetch_registers)
2634         (inf_ptrace_store_register, inf_ptrace_store_registers): Refact as
2635         methods of linux_nat_trad_target.
2636         (linux_trad_target): Delete.
2637         * linux-nat-trad.h (linux_trad_target): Delete function.
2638         (linux_nat_trad_target): New class.
2639         * mips-linux-nat.c (mips_linux_nat_target): New class.
2640         (super_fetch_registers, super_store_registers, super_close):
2641         Delete.
2642         (the_mips_linux_nat_target): New.
2643         (mips64_linux_regsets_fetch_registers)
2644         (mips64_linux_regsets_store_registers)
2645         (mips64_linux_fetch_registers, mips64_linux_store_registers)
2646         (mips_linux_register_u_offset, mips_linux_read_description)
2647         (mips_linux_can_use_hw_breakpoint)
2648         (mips_linux_stopped_by_watchpoint)
2649         (mips_linux_stopped_data_address)
2650         (mips_linux_region_ok_for_hw_watchpoint)
2651         (mips_linux_insert_watchpoint, mips_linux_remove_watchpoint)
2652         (mips_linux_close): Refactor as methods of mips_linux_nat.
2653         (_initialize_mips_linux_nat): Adjust to C++ification.
2654
2655         * aix-thread.c (aix_thread_target): New class.
2656         (aix_thread_ops): Now an aix_thread_target.
2657         (aix_thread_detach, aix_thread_resume, aix_thread_wait)
2658         (aix_thread_fetch_registers, aix_thread_store_registers)
2659         (aix_thread_xfer_partial, aix_thread_mourn_inferior)
2660         (aix_thread_thread_alive, aix_thread_pid_to_str)
2661         (aix_thread_extra_thread_info, aix_thread_get_ada_task_ptid):
2662         Refactor as methods of aix_thread_target.
2663         (init_aix_thread_ops): Delete.
2664         (_initialize_aix_thread): Remove references to init_aix_thread_ops
2665         and complete_target_initialization.
2666         * rs6000-nat.c (rs6000_xfer_shared_libraries): Delete.
2667         (rs6000_nat_target): New class.
2668         (the_rs6000_nat_target): New.
2669         (rs6000_fetch_inferior_registers, rs6000_store_inferior_registers)
2670         (rs6000_xfer_partial, rs6000_wait, rs6000_create_inferior)
2671         (rs6000_xfer_shared_libraries): Refactor as rs6000_nat_target methods.
2672         (super_create_inferior): Delete.
2673         (_initialize_rs6000_nat): Adjust to C++ification.
2674
2675         * arm-linux-nat.c (arm_linux_nat_target): New class.
2676         (the_arm_linux_nat_target): New.
2677         (arm_linux_fetch_inferior_registers)
2678         (arm_linux_store_inferior_registers, arm_linux_read_description)
2679         (arm_linux_can_use_hw_breakpoint, arm_linux_insert_hw_breakpoint)
2680         (arm_linux_remove_hw_breakpoint)
2681         (arm_linux_region_ok_for_hw_watchpoint)
2682         (arm_linux_insert_watchpoint, arm_linux_remove_watchpoint)
2683         (arm_linux_stopped_data_address, arm_linux_stopped_by_watchpoint)
2684         (arm_linux_watchpoint_addr_within_range): Refactor as methods of
2685         arm_linux_nat_target.
2686         (_initialize_arm_linux_nat): Adjust to C++ification.
2687
2688         * aarch64-linux-nat.c (aarch64_linux_nat_target): New class.
2689         (the_aarch64_linux_nat_target): New.
2690         (aarch64_linux_fetch_inferior_registers)
2691         (aarch64_linux_store_inferior_registers)
2692         (aarch64_linux_child_post_startup_inferior)
2693         (aarch64_linux_read_description)
2694         (aarch64_linux_can_use_hw_breakpoint)
2695         (aarch64_linux_insert_hw_breakpoint)
2696         (aarch64_linux_remove_hw_breakpoint)
2697         (aarch64_linux_insert_watchpoint, aarch64_linux_remove_watchpoint)
2698         (aarch64_linux_region_ok_for_hw_watchpoint)
2699         (aarch64_linux_stopped_data_address)
2700         (aarch64_linux_stopped_by_watchpoint)
2701         (aarch64_linux_watchpoint_addr_within_range)
2702         (aarch64_linux_can_do_single_step): Refactor as methods of
2703         aarch64_linux_nat_target.
2704         (super_post_startup_inferior): Delete.
2705         (_initialize_aarch64_linux_nat): Adjust to C++ification.
2706
2707         * hppa-linux-nat.c (hppa_linux_nat_target): New class.
2708         (the_hppa_linux_nat_target): New.
2709         (hppa_linux_fetch_inferior_registers)
2710         (hppa_linux_store_inferior_registers): Refactor as methods of
2711         hppa_linux_nat_target.
2712         (_initialize_hppa_linux_nat): Adjust to C++ification.
2713
2714         * ia64-linux-nat.c (ia64_linux_nat_target): New class.
2715         (the_ia64_linux_nat_target): New.
2716         (ia64_linux_insert_watchpoint, ia64_linux_remove_watchpoint)
2717         (ia64_linux_stopped_data_address)
2718         (ia64_linux_stopped_by_watchpoint, ia64_linux_fetch_registers)
2719         (ia64_linux_store_registers, ia64_linux_xfer_partial): Refactor as
2720         ia64_linux_nat_target methods.
2721         (super_xfer_partial): Delete.
2722         (_initialize_ia64_linux_nat): Adjust to C++ification.
2723
2724         * m32r-linux-nat.c (m32r_linux_nat_target): New class.
2725         (the_m32r_linux_nat_target): New.
2726         (m32r_linux_fetch_inferior_registers)
2727         (m32r_linux_store_inferior_registers): Refactor as
2728         m32r_linux_nat_target methods.
2729         (_initialize_m32r_linux_nat): Adjust to C++ification.
2730
2731         * m68k-linux-nat.c (m68k_linux_nat_target): New class.
2732         (the_m68k_linux_nat_target): New.
2733         (m68k_linux_fetch_inferior_registers)
2734         (m68k_linux_store_inferior_registers): Refactor as
2735         m68k_linux_nat_target methods.
2736         (_initialize_m68k_linux_nat): Adjust to C++ification.
2737
2738         * s390-linux-nat.c (s390_linux_nat_target): New class.
2739         (the_s390_linux_nat_target): New.
2740         (s390_linux_fetch_inferior_registers)
2741         (s390_linux_store_inferior_registers, s390_stopped_by_watchpoint)
2742         (s390_insert_watchpoint, s390_remove_watchpoint)
2743         (s390_can_use_hw_breakpoint, s390_insert_hw_breakpoint)
2744         (s390_remove_hw_breakpoint, s390_region_ok_for_hw_watchpoint)
2745         (s390_auxv_parse, s390_read_description): Refactor as methods of
2746         s390_linux_nat_target.
2747         (_initialize_s390_nat): Adjust to C++ification.
2748
2749         * sparc-linux-nat.c (sparc_linux_nat_target): New class.
2750         (the_sparc_linux_nat_target): New.
2751         (_initialize_sparc_linux_nat): Adjust to C++ification.
2752         * sparc-nat.c (sparc_fetch_inferior_registers)
2753         (sparc_store_inferior_registers): Remove target_ops parameter.
2754         * sparc-nat.h (sparc_fetch_inferior_registers)
2755         (sparc_store_inferior_registers): Remove target_ops parameter.
2756         * sparc64-linux-nat.c (sparc64_linux_nat_target): New class.
2757         (the_sparc64_linux_nat_target): New.
2758         (_initialize_sparc64_linux_nat): Adjust to C++ification.
2759
2760         * spu-linux-nat.c (spu_linux_nat_target): New class.
2761         (the_spu_linux_nat_target): New.
2762         (spu_child_post_startup_inferior, spu_child_post_attach)
2763         (spu_child_wait, spu_fetch_inferior_registers)
2764         (spu_store_inferior_registers, spu_xfer_partial)
2765         (spu_can_use_hw_breakpoint): Refactor as spu_linux_nat_target
2766         methods.
2767         (_initialize_spu_nat): Adjust to C++ification.
2768
2769         * tilegx-linux-nat.c (tilegx_linux_nat_target): New class.
2770         (the_tilegx_linux_nat_target): New.
2771         (fetch_inferior_registers, store_inferior_registers):
2772         Refactor as methods.
2773         (_initialize_tile_linux_nat): Adjust to C++ification.
2774
2775         * xtensa-linux-nat.c (xtensa_linux_nat_target): New class.
2776         (the_xtensa_linux_nat_target): New.
2777         (xtensa_linux_fetch_inferior_registers)
2778         (xtensa_linux_store_inferior_registers): Refactor as
2779         xtensa_linux_nat_target methods.
2780         (_initialize_xtensa_linux_nat): Adjust to C++ification.
2781
2782         * fbsd-nat.c (USE_SIGTRAP_SIGINFO): Delete.
2783         (fbsd_pid_to_exec_file, fbsd_find_memory_regions)
2784         (fbsd_find_memory_regions, fbsd_info_proc, fbsd_xfer_partial)
2785         (fbsd_thread_alive, fbsd_pid_to_str, fbsd_thread_name)
2786         (fbsd_update_thread_list, fbsd_resume, fbsd_wait)
2787         (fbsd_stopped_by_sw_breakpoint)
2788         (fbsd_supports_stopped_by_sw_breakpoint, fbsd_follow_fork)
2789         (fbsd_insert_fork_catchpoint, fbsd_remove_fork_catchpoint)
2790         (fbsd_insert_vfork_catchpoint, fbsd_remove_vfork_catchpoint)
2791         (fbsd_post_startup_inferior, fbsd_post_attach)
2792         (fbsd_insert_exec_catchpoint, fbsd_remove_exec_catchpoint)
2793         (fbsd_set_syscall_catchpoint)
2794         (super_xfer_partial, super_resume, super_wait)
2795         (fbsd_supports_stopped_by_hw_breakpoint): Delete.
2796         (fbsd_handle_debug_trap): Remove target_ops parameter.
2797         (fbsd_nat_add_target): Delete.
2798         * fbsd-nat.h: Include "inf-ptrace.h".
2799         (fbsd_nat_add_target): Delete.
2800         (USE_SIGTRAP_SIGINFO): Define.
2801         (fbsd_nat_target): New class.
2802
2803         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers)
2804         (amd64bsd_store_inferior_registers): Remove target_ops parameter.
2805         (amd64bsd_target): Delete.
2806         * amd64-bsd-nat.h: New file.
2807         * amd64-fbsd-nat.c: Include "amd64-bsd-nat.h" instead of
2808         "x86-bsd-nat.h".
2809         (amd64_fbsd_nat_target): New class.
2810         (the_amd64_fbsd_nat_target): New.
2811         (amd64fbsd_read_description): Refactor as method of
2812         amd64_fbsd_nat_target.
2813         (amd64_fbsd_nat_target::supports_stopped_by_hw_breakpoint): New.
2814         (_initialize_amd64fbsd_nat): Adjust to C++ification.
2815         * amd64-nat.h (amd64bsd_target): Delete function declaration.
2816         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers)
2817         (i386bsd_store_inferior_registers): Remove target_ops parameter.
2818         (i386bsd_target): Delete.
2819         * i386-bsd-nat.h (i386bsd_target): Delete function declaration.
2820         (i386bsd_fetch_inferior_registers)
2821         (i386bsd_store_inferior_registers): Declare.
2822         (i386_bsd_nat_target): New class.
2823         * i386-fbsd-nat.c (i386_fbsd_nat_target): New class.
2824         (the_i386_fbsd_nat_target): New.
2825         (i386fbsd_resume, i386fbsd_read_description): Refactor as
2826         i386_fbsd_nat_target methods.
2827         (i386_fbsd_nat_target::supports_stopped_by_hw_breakpoint): New.
2828         (_initialize_i386fbsd_nat): Adjust to C++ification.
2829         * x86-bsd-nat.c (super_mourn_inferior): Delete.
2830         (x86bsd_mourn_inferior, x86bsd_target): Delete.
2831         (_initialize_x86_bsd_nat): Adjust to C++ification.
2832         * x86-bsd-nat.h: Include "x86-nat.h".
2833         (x86bsd_target): Delete declaration.
2834         (x86bsd_nat_target): New class.
2835
2836         * aarch64-fbsd-nat.c (aarch64_fbsd_nat_target): New class.
2837         (the_aarch64_fbsd_nat_target): New.
2838         (aarch64_fbsd_fetch_inferior_registers)
2839         (aarch64_fbsd_store_inferior_registers): Refactor as methods of
2840         aarch64_fbsd_nat_target.
2841         (_initialize_aarch64_fbsd_nat): Adjust to C++ification.
2842         * alpha-bsd-nat.c (alpha_bsd_nat_target): New class.
2843         (the_alpha_bsd_nat_target): New.
2844         (alphabsd_fetch_inferior_registers)
2845         (alphabsd_store_inferior_registers): Refactor as
2846         alpha_bsd_nat_target methods.
2847         (_initialize_alphabsd_nat): Refactor as methods of
2848         alpha_bsd_nat_target.
2849         * amd64-nbsd-nat.c: Include "amd64-bsd-nat.h".
2850         (the_amd64_nbsd_nat_target): New.
2851         (_initialize_amd64nbsd_nat): Adjust to C++ification.
2852         * amd64-obsd-nat.c: Include "amd64-bsd-nat.h".
2853         (the_amd64_obsd_nat_target): New.
2854         (_initialize_amd64obsd_nat): Adjust to C++ification.
2855         * arm-fbsd-nat.c (arm_fbsd_nat_target): New.
2856         (the_arm_fbsd_nat_target): New.
2857         (arm_fbsd_fetch_inferior_registers)
2858         (arm_fbsd_store_inferior_registers, arm_fbsd_read_description):
2859         (_initialize_arm_fbsd_nat): Refactor as methods of
2860         arm_fbsd_nat_target.
2861         (_initialize_arm_fbsd_nat): Adjust to C++ification.
2862         * arm-nbsd-nat.c (arm_netbsd_nat_target): New class.
2863         (the_arm_netbsd_nat_target): New.
2864         (armnbsd_fetch_registers, armnbsd_store_registers): Refactor as
2865         arm_netbsd_nat_target.
2866         (_initialize_arm_netbsd_nat): Adjust to C++ification.
2867         * hppa-nbsd-nat.c (hppa_nbsd_nat_target): New class.
2868         (the_hppa_nbsd_nat_target): New.
2869         (hppanbsd_fetch_registers, hppanbsd_store_registers): Refactor as
2870         hppa_nbsd_nat_target methods.
2871         (_initialize_hppanbsd_nat): Adjust to C++ification.
2872         * hppa-obsd-nat.c (hppa_obsd_nat_target): New class.
2873         (the_hppa_obsd_nat_target): New.
2874         (hppaobsd_fetch_registers, hppaobsd_store_registers): Refactor as
2875         methods of hppa_obsd_nat_target.
2876         (_initialize_hppaobsd_nat): Adjust to C++ification.  Use
2877         add_target.
2878         * i386-nbsd-nat.c (the_i386_nbsd_nat_target): New.
2879         (_initialize_i386nbsd_nat): Adjust to C++ification.  Use
2880         add_target.
2881         * i386-obsd-nat.c (the_i386_obsd_nat_target): New.
2882         (_initialize_i386obsd_nat): Use add_target.
2883         * m68k-bsd-nat.c (m68k_bsd_nat_target): New class.
2884         (the_m68k_bsd_nat_target): New.
2885         (m68kbsd_fetch_inferior_registers)
2886         (m68kbsd_store_inferior_registers): Refactor as methods of
2887         m68k_bsd_nat_target.
2888         (_initialize_m68kbsd_nat): Adjust to C++ification.
2889         * mips-fbsd-nat.c (mips_fbsd_nat_target): New class.
2890         (the_mips_fbsd_nat_target): New.
2891         (mips_fbsd_fetch_inferior_registers)
2892         (mips_fbsd_store_inferior_registers): Refactor as methods of
2893         mips_fbsd_nat_target.
2894         (_initialize_mips_fbsd_nat): Adjust to C++ification.  Use
2895         add_target.
2896         * mips-nbsd-nat.c (mips_nbsd_nat_target): New class.
2897         (the_mips_nbsd_nat_target): New.
2898         (mipsnbsd_fetch_inferior_registers)
2899         (mipsnbsd_store_inferior_registers): Refactor as methods of
2900         mips_nbsd_nat_target.
2901         (_initialize_mipsnbsd_nat): Adjust to C++ification.
2902         * mips64-obsd-nat.c (mips64_obsd_nat_target): New class.
2903         (the_mips64_obsd_nat_target): New.
2904         (mips64obsd_fetch_inferior_registers)
2905         (mips64obsd_store_inferior_registers): Refactor as methods of
2906         mips64_obsd_nat_target.
2907         (_initialize_mips64obsd_nat): Adjust to C++ification.  Use
2908         add_target.
2909         * nbsd-nat.c (nbsd_pid_to_exec_file): Refactor as method of
2910         nbsd_nat_target.
2911         * nbsd-nat.h: Include "inf-ptrace.h".
2912         (nbsd_nat_target): New class.
2913         * obsd-nat.c (obsd_pid_to_str, obsd_update_thread_list)
2914         (obsd_wait): Refactor as methods of obsd_nat_target.
2915         (obsd_add_target): Delete.
2916         * obsd-nat.h: Include "inf-ptrace.h".
2917         (obsd_nat_target): New class.
2918         * ppc-fbsd-nat.c (ppc_fbsd_nat_target): New class.
2919         (the_ppc_fbsd_nat_target): New.
2920         (ppcfbsd_fetch_inferior_registers)
2921         (ppcfbsd_store_inferior_registers): Refactor as methods of
2922         ppc_fbsd_nat_target.
2923         (_initialize_ppcfbsd_nat): Adjust to C++ification.  Use
2924         add_target.
2925         * ppc-nbsd-nat.c (ppc_nbsd_nat_target): New class.
2926         (the_ppc_nbsd_nat_target): New.
2927         (ppcnbsd_fetch_inferior_registers)
2928         (ppcnbsd_store_inferior_registers): Refactor as methods of
2929         ppc_nbsd_nat_target.
2930         (_initialize_ppcnbsd_nat): Adjust to C++ification.
2931         * ppc-obsd-nat.c (ppc_obsd_nat_target): New class.
2932         (the_ppc_obsd_nat_target): New.
2933         (ppcobsd_fetch_registers, ppcobsd_store_registers): Refactor as
2934         methods of ppc_obsd_nat_target.
2935         (_initialize_ppcobsd_nat): Adjust to C++ification.  Use
2936         add_target.
2937         * sh-nbsd-nat.c (sh_nbsd_nat_target): New class.
2938         (the_sh_nbsd_nat_target): New.
2939         (shnbsd_fetch_inferior_registers)
2940         (shnbsd_store_inferior_registers): Refactor as methods of
2941         sh_nbsd_nat_target.
2942         (_initialize_shnbsd_nat): Adjust to C++ification.
2943         * sparc-nat.c (sparc_xfer_wcookie): Make extern.
2944         (inf_ptrace_xfer_partial): Delete.
2945         (sparc_xfer_partial, sparc_target): Delete.
2946         * sparc-nat.h (sparc_fetch_inferior_registers)
2947         (sparc_store_inferior_registers, sparc_xfer_wcookie): Declare.
2948         (sparc_target): Delete function declaration.
2949         (sparc_target): New template class.
2950         * sparc-nbsd-nat.c (the_sparc_nbsd_nat_target): New.
2951         (_initialize_sparcnbsd_nat): Adjust to C++ification.
2952         * sparc64-fbsd-nat.c (the_sparc64_fbsd_nat_target): New.
2953         (_initialize_sparc64fbsd_nat): Adjust to C++ification.  Use
2954         add_target.
2955         * sparc64-nbsd-nat.c (the_sparc64_nbsd_nat_target): New.
2956         (_initialize_sparc64nbsd_nat): Adjust to C++ification.
2957         * sparc64-obsd-nat.c (the_sparc64_obsd_nat_target): New.
2958         (_initialize_sparc64obsd_nat): Adjust to C++ification.  Use
2959         add_target.
2960         * vax-bsd-nat.c (vax_bsd_nat_target): New class.
2961         (the_vax_bsd_nat_target): New.
2962         (vaxbsd_fetch_inferior_registers)
2963         (vaxbsd_store_inferior_registers): Refactor as vax_bsd_nat_target
2964         methods.
2965         (_initialize_vaxbsd_nat): Adjust to C++ification.
2966
2967         * bsd-kvm.c (bsd_kvm_target): New class.
2968         (bsd_kvm_ops): Now a bsd_kvm_target.
2969         (bsd_kvm_open, bsd_kvm_close, bsd_kvm_xfer_partial)
2970         (bsd_kvm_files_info, bsd_kvm_fetch_registers)
2971         (bsd_kvm_thread_alive, bsd_kvm_pid_to_str): Refactor as methods of
2972         bsd_kvm_target.
2973         (bsd_kvm_return_one): Delete.
2974         (bsd_kvm_add_target): Adjust to C++ification.
2975
2976         * nto-procfs.c (nto_procfs_target, nto_procfs_target_native)
2977         (nto_procfs_target_procfs): New classes.
2978         (procfs_open_1, procfs_thread_alive, procfs_update_thread_list)
2979         (procfs_files_info, procfs_pid_to_exec_file, procfs_attach)
2980         (procfs_post_attach, procfs_wait, procfs_fetch_registers)
2981         (procfs_xfer_partial, procfs_detach, procfs_insert_breakpoint)
2982         (procfs_remove_breakpoint, procfs_insert_hw_breakpoint)
2983         (procfs_remove_hw_breakpoint, procfs_resume)
2984         (procfs_mourn_inferior, procfs_create_inferior, procfs_interrupt)
2985         (procfs_kill_inferior, procfs_store_registers)
2986         (procfs_pass_signals, procfs_pid_to_str, procfs_can_run): Refactor
2987         as methods of nto_procfs_target.
2988         (nto_procfs_ops): Now an nto_procfs_target_procfs.
2989         (nto_native_ops): Delete.
2990         (procfs_open, procfs_native_open): Delete.
2991         (nto_native_ops): Now an nto_procfs_target_native.
2992         (init_procfs_targets): Adjust to C++ification.
2993         (procfs_can_use_hw_breakpoint, procfs_remove_hw_watchpoint)
2994         (procfs_insert_hw_watchpoint, procfs_stopped_by_watchpoint):
2995         Refactor as methods of nto_procfs_target.
2996
2997         * go32-nat.c (go32_nat_target): New class.
2998         (the_go32_nat_target): New.
2999         (go32_attach, go32_resume, go32_wait, go32_fetch_registers)
3000         (go32_store_registers, go32_xfer_partial, go32_files_info)
3001         (go32_kill_inferior, go32_create_inferior, go32_mourn_inferior)
3002         (go32_terminal_init, go32_terminal_info, go32_terminal_inferior)
3003         (go32_terminal_ours, go32_pass_ctrlc, go32_thread_alive)
3004         (go32_pid_to_str): Refactor as methods of go32_nat_target.
3005         (go32_target): Delete.
3006         (_initialize_go32_nat): Adjust to C++ification.
3007
3008         * gnu-nat.c (gnu_wait, gnu_resume, gnu_kill_inferior)
3009         (gnu_mourn_inferior, gnu_create_inferior, gnu_attach, gnu_detach)
3010         (gnu_stop, gnu_thread_alive, gnu_xfer_partial)
3011         (gnu_find_memory_regions, gnu_pid_to_str): Refactor as methods of
3012         gnu_nat_target.
3013         (gnu_target): Delete.
3014         * gnu-nat.h (gnu_target): Delete.
3015         (gnu_nat_target): New class.
3016         * i386-gnu-nat.c (gnu_base_target): New.
3017         (i386_gnu_nat_target): New class.
3018         (the_i386_gnu_nat_target): New.
3019         (_initialize_i386gnu_nat): Adjust to C++ification.
3020
3021 2018-05-02  Pedro Alves  <palves@redhat.com>
3022
3023         * bfd-target.c (target_bfd_xclose): Rename to ...
3024         (target_bfd_close): ... this.
3025         (target_bfd_reopen): Adjust.
3026         * target.c (target_close): Remove references to to_xclose.
3027         * target.h (target_ops::to_xclose): Delete.
3028         (target_ops::to_close): Update comments.
3029
3030 2018-05-02  Pedro Alves  <palves@redhat.com>
3031
3032         * alpha-linux-nat.c: Include "linux-nat-trad.h" instead of
3033         "linux-nat.h".
3034         * configure.nat (alpha-linux, linux-mips): Add linux-nat-trad.o.
3035         * inf-ptrace.c (inf_ptrace_register_u_offset)
3036         (inf_ptrace_fetch_register, inf_ptrace_fetch_registers)
3037         (inf_ptrace_store_register, inf_ptrace_store_registers)
3038         (inf_ptrace_trad_target): Move to ...
3039         * linux-nat-trad.c: ... this new file.
3040         * linux-nat-trad.h: New file.
3041         * linux-nat.c (linux_target_install_ops): Make extern.
3042         (linux_trad_target): Delete.
3043         * linux-nat.h (linux_trad_target): Delete declaration.
3044         (linux_target_install_ops): Declare.
3045         * mips-linux-nat.c: Include "linux-nat-trad.h" instead of
3046         "linux-nat.h".
3047
3048 2018-05-02  Pedro Alves  <palves@redhat.com>
3049
3050         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Don't call
3051         procfs_target/add_target here.
3052         * procfs.c (procfs_target): Make static.
3053         (_initialize_procfs): Call add_target here.
3054         * procfs.h (struct target_ops): Remove forward declaration.
3055         (procfs_target): Remove declaration.
3056         * sparc-sol2-nat.c (_initialize_sparc_sol2_nat): Delete.
3057
3058 2018-05-02  Pedro Alves  <palves@redhat.com>
3059
3060         * procfs.c (procfs_stopped_by_watchpoint)
3061         (procfs_insert_watchpoint, procfs_remove_watchpoint)
3062         (procfs_region_ok_for_hw_watchpoint, procfs_stopped_data_address):
3063         Forward declare.
3064         (procfs_use_watchpoints): Delete, move contents...
3065         (procfs_target): ... here.
3066         * procfs.h (procfs_use_watchpoints): Delete declaration.
3067         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Don't call
3068         procfs_use_watchpoints.
3069         * sparc-sol2-nat.c (_initialize_sparc_sol2_nat): Don't call
3070         procfs_use_watchpoints.
3071
3072 2018-05-02  Tom Tromey  <tom@tromey.com>
3073
3074         PR python/20084:
3075         * python/python.c (gdbpy_parameter_value): Handle var_zuinteger
3076         and var_zuinteger_unlimited.
3077         * python/py-param.c (struct parm_constant): Add PARAM_ZUINTEGER
3078         and PARAM_ZUINTEGER_UNLIMITED.
3079         (set_parameter_value): Handle var_zuinteger and
3080         var_zuinteger_unlimited.
3081         (add_setshow_generic): Likewise.
3082         (parmpy_init): Likewise.
3083
3084 2018-04-28  Dan Robertson  <danlrobertson89@gmail.com>
3085
3086         PR rust/23124
3087         * gdb/rust-exp.y (convert_params_to_types): Ensure that the params
3088         pointer is not null before dereferencing it.
3089
3090 2018-04-30  Tom Tromey  <tom@tromey.com>
3091
3092         * darwin-nat-info.c (darwin_debug_regions_recurse): Remove use of
3093         is_mi_like_p.
3094
3095 2018-04-30  Tom Tromey  <tom@tromey.com>
3096
3097         * breakpoint.c (mention): Remove use of is_mi_like_p.
3098         (print_mention_ranged_breakpoint): Likewise.
3099         * break-catch-throw.c (print_it_exception_catchpoint): Remove use
3100         of is_mi_like_p.
3101
3102 2018-04-30  Tom Tromey  <tom@tromey.com>
3103
3104         * tracepoint.c (tvariables_info_1): Remove use of is_mi_like_p.
3105
3106 2018-04-30  Tom Tromey  <tom@tromey.com>
3107
3108         * spu-tdep.c (info_spu_mailbox_list, info_spu_dma_cmdlist)
3109         (info_spu_event_command): Remove some uses of is_mi_like_p.
3110
3111 2018-04-30  Tom Tromey  <tom@tromey.com>
3112
3113         * python/py-framefilter.c (py_print_single_arg)
3114         (enumerate_locals, py_print_args, py_print_frame): Remove some
3115         uses of is_mi_like_p.
3116
3117 2018-04-30  Tom Tromey  <tom@tromey.com>
3118
3119         * ui-out.c: Update.
3120         * cli-out.h (cli_ui_out::do_is_mi_like_p): Update.
3121         * ui-out.h (ui_out::is_mi_like_p): Now const.
3122         (ui_out::do_is_mi_like_p): Now const.
3123         * mi/mi-out.h (mi_ui_out::do_is_mi_like_p): Update.
3124
3125 2018-04-30  Tom Tromey  <tom@tromey.com>
3126
3127         * varobj.c (varobj_set_visualizer): Use new_reference.
3128         * python/python.c (gdbpy_decode_line): Use new_reference.
3129         * python/py-cmd.c (cmdpy_function, cmdpy_completer_helper): Use
3130         new_reference.
3131
3132 2018-04-30  Tom Tromey  <tom@tromey.com>
3133
3134         * varobj.c (install_new_value): Use new_reference.
3135         * value.h (value_incref): Return void.  Swap intro comment with
3136         value_decref.
3137         * value.c (set_value_parent): Use new_reference.
3138         (value_incref): Return void.  Update intro comment.
3139         (release_value): Use new_reference.
3140         * dwarf2loc.c (dwarf2_evaluate_loc_desc_full): Use new_reference.
3141
3142 2018-04-30  Tom Tromey  <tom@tromey.com>
3143
3144         * symfile-mem.c (symbol_file_add_from_memory): Use new_reference.
3145         * gdb_bfd.h (new_bfd_ref): Remove.
3146         (gdb_bfd_open): Update comment.
3147         * gdb_bfd.c (gdb_bfd_open, gdb_bfd_fopen, gdb_bfd_openr)
3148         (gdb_bfd_openw, gdb_bfd_openr_iovec, gdb_bfd_record_inclusion)
3149         (gdb_bfd_fdopenr): Use new_reference.
3150         * exec.c (exec_file_attach): Use new_reference.
3151
3152 2018-04-30  Tom Tromey  <tom@tromey.com>
3153
3154         * common/gdb_ref_ptr.h (ref_ptr::new_reference): New static
3155         method.
3156
3157 2018-04-30  Tom Tromey  <tom@tromey.com>
3158
3159         * jit.c (jit_read_code_entry): Use type_align.
3160         * i386-tdep.c (i386_gdbarch_init): Don't call
3161         set_gdbarch_long_long_align_bit.
3162         * gdbarch.sh: Remove long_long_align_bit.
3163         * gdbarch.c, gdbarch.h: Rebuild.
3164         * arc-tdep.c (arc_type_align): New function.
3165         (arc_gdbarch_init): Use arc_type_align.  Don't call
3166         set_gdbarch_long_long_align_bit.
3167
3168 2018-04-30  Tom Tromey  <tom@tromey.com>
3169
3170         * rust-lang.c (rust_type_alignment): Remove.
3171         (rust_composite_type): Use type_align.
3172
3173 2018-04-30  Tom Tromey  <tom@tromey.com>
3174
3175         * NEWS: Mention Type.align.
3176         * python/py-type.c (typy_get_alignof): New function.
3177         (type_object_getset): Add "alignof".
3178
3179 2018-04-30  Tom Tromey  <tom@tromey.com>
3180
3181         PR exp/17095:
3182         * NEWS: Update.
3183         * std-operator.def (UNOP_ALIGNOF): New operator.
3184         * expprint.c (dump_subexp_body_standard) <case UNOP_ALIGNOF>:
3185         New.
3186         * eval.c (evaluate_subexp_standard) <case UNOP_ALIGNOF>: New.
3187         * c-lang.c (c_op_print_tab): Add alignof.
3188         * c-exp.y (ALIGNOF): New token.
3189         (exp): Add "ALIGNOF" production.
3190         (ident_tokens): Add _Alignof and alignof.
3191
3192 2018-04-30  Tom Tromey  <tom@tromey.com>
3193
3194         * i386-tdep.c (i386_type_align): New function.
3195         (i386_gdbarch_init): Update.
3196         * gdbarch.sh (type_align): New method.
3197         * gdbarch.c, gdbarch.h: Rebuild.
3198         * arch-utils.h (default_type_align): Declare.
3199         * arch-utils.c (default_type_align): New function.
3200         * gdbtypes.h (TYPE_ALIGN_BITS): New define.
3201         (struct type) <align_log2>: New field.
3202         <instance_flags>: Now a bitfield.
3203         (TYPE_RAW_ALIGN): New macro.
3204         (type_align, type_raw_align, set_type_align): Declare.
3205         * gdbtypes.c (type_align, type_raw_align, set_type_align): New
3206         functions.
3207         * dwarf2read.c (quirk_rust_enum): Set type alignment.
3208         (get_alignment, maybe_set_alignment): New functions.
3209         (read_structure_type, read_enumeration_type, read_array_type)
3210         (read_set_type, read_tag_pointer_type, read_tag_reference_type)
3211         (read_subrange_type, read_base_type): Set type alignment.
3212
3213 2018-04-30  Simon Marchi  <simon.marchi@ericsson.com>
3214
3215         * dwarf2read.c (read_index_from_section): Use bool.
3216
3217 2018-04-29  Fabian Groffen  <grobian@gentoo.org>
3218
3219         PR gdb/22950
3220         * proc-events.c (init_syscall_table): Guard usage os SYS_uuidsys
3221         with #ifdef.
3222
3223 2018-04-29  John Reiser  <jreiser@BitWagon.com>
3224
3225         PR build/22873
3226         * gdb/Makefile.in: (.c:.l, .c:.y): Write the target only in the
3227         last step, and do it atomically.
3228
3229 2018-04-27  Alexandre Oliva  <aoliva@redhat.com>
3230
3231         * compile/compile-c-types.c (convert_int, convert_float):
3232         Update for C FE v1.
3233
3234 2018-04-27  Tom Tromey  <tom@tromey.com>
3235
3236         PR rust/22545:
3237         * rust-lang.c (rust_inclusive_range_type_p): New function.
3238         (rust_range): Handle inclusive ranges.
3239         (rust_compute_range): Likewise.
3240         * rust-exp.y (struct rust_op) <inclusive>: New field.
3241         (DOTDOTEQ): New constant.
3242         (range_expr): Add "..=" productions.
3243         (operator_tokens): Add "..=" token.
3244         (ast_range): Add "inclusive" parameter.
3245         (convert_ast_to_expression) <case OP_RANGE>: Handle inclusive
3246         ranges.
3247         * parse.c (operator_length_standard) <case OP_RANGE>: Handle new
3248         bounds values.
3249         * expression.h (enum range_type) <NONE_BOUND_DEFAULT_EXCLUSIVE,
3250         LOW_BOUND_DEFAULT_EXCLUSIVE>: New constants.
3251         Update comments.
3252         * expprint.c (print_subexp_standard): Handle new bounds values.
3253         (dump_subexp_body_standard): Likewise.
3254
3255 2018-04-27  Tom Tromey  <tom@tromey.com>
3256
3257         * configure: Rebuild.
3258         * warning.m4 (AM_GDB_WARNINGS): Add -Wsuggest-override.
3259         * dwarf2loc.c (class dwarf_evaluate_loc_desc): Use "override", not
3260         "OVERRIDE".
3261         (class symbol_needs_eval_context): Likewise.
3262         * dwarf2read.c (mock_mapped_index::symbol_name_count)
3263         (mock_mapped_index::symbol_name_at): Use "override".  Remove
3264         "virtual".
3265         * dwarf2-frame.c (dwarf_expr_executor::get_addr_index): Use
3266         "override".
3267         (class dwarf_expr_executor): Use "override", not "OVERRIDE".
3268         * aarch64-tdep.c (instruction_reader::read): Use "override".
3269         (instruction_reader_test::read): Likewise.
3270         * arm-tdep.c (instruction_reader::read): Use "override".
3271         (instruction_reader_thumb::read): Likewise.
3272
3273 2018-04-26  Andrzej Kaczmarek  <andrzej.kaczmarek@codecoup.pl>
3274
3275         PR remote/9665
3276         * remote.c (send_g_packet): Use putpkt/getpkt/packet_check_result
3277         instead of remote_send.
3278         (remote_send): Remove.
3279
3280 2018-04-26  Pedro Alves  <palves@redhat.com>
3281
3282         * elfread.c (elf_gnu_ifunc_resolver_return_stop): Use
3283         find_function_start_sal instead of find_pc_line.
3284
3285 2018-04-26  Pedro Alves  <palves@redhat.com>
3286
3287         * breakpoint.c (set_breakpoint_location_function): Handle
3288         mst_data_gnu_ifunc.
3289         * c-exp.y (variable production): Handle mst_data_gnu_ifunc.
3290         * elfread.c (elf_symtab_read): Give data symbols with
3291         BSF_GNU_INDIRECT_FUNCTION set mst_data_gnu_ifunc type.
3292         (elf_rel_plt_read): Update comment.
3293         * linespec.c (convert_linespec_to_sals): Handle
3294         mst_data_gnu_ifunc.
3295         (minsym_found): Handle mst_data_gnu_ifunc.
3296         * minsyms.c (msymbol_is_function, minimal_symbol_reader::record)
3297         (find_solib_trampoline_target): Handle mst_data_gnu_ifunc.
3298         * parse.c (find_minsym_type_and_address): Handle
3299         mst_data_gnu_ifunc.
3300         * symmisc.c (dump_msymbols): Handle mst_data_gnu_ifunc.
3301         * symtab.c (find_gnu_ifunc): Handle mst_data_gnu_ifunc.
3302         * symtab.h (minimal_symbol_type) <mst_text_gnu_ifunc>: Update
3303         comment.
3304         <mst_data_gnu_ifunc>: New enumerator.
3305
3306 2018-04-26  Pedro Alves  <palves@redhat.com>
3307
3308         * minsyms.c (lookup_minimal_symbol_by_pc_section_1): Rename to ...
3309         (lookup_minimal_symbol_by_pc_section): ... this.  Replace
3310         'want_trampoline' parameter by a lookup_msym_prefer parameter.
3311         Handle it.
3312         (lookup_minimal_symbol_by_pc_section): Delete old implementation.
3313         (lookup_minimal_symbol_by_pc): Adjust.
3314         (in_gnu_ifunc_stub): Prefer GNU ifunc symbols.
3315         (lookup_solib_trampoline_symbol_by_pc): Adjust.
3316         * minsyms.h (lookup_msym_prefer): New enum.
3317         (lookup_minimal_symbol_by_pc_section): Replace 'want_trampoline'
3318         parameter by a lookup_msym_prefer parameter.
3319
3320 2018-04-26  Pedro Alves  <palves@redhat.com>
3321
3322         * elfread.c (elf_gnu_ifunc_record_cache): Check if the symbol name
3323         ends in "@plt" instead of looking at the symbol's section.
3324
3325 2018-04-26  Pedro Alves  <palves@redhat.com>
3326
3327         * blockframe.c (cache_pc_function_is_gnu_ifunc): Delete.  Remove
3328         all references.
3329         (find_pc_partial_function_gnu_ifunc): Rename to ...
3330         (find_pc_partial_function): ... this, and remove references to
3331         'is_gnu_ifunc_p'.
3332         (find_pc_partial_function): Delete old implementation.
3333         * symtab.h (find_pc_partial_function_gnu_ifunc): Delete.
3334
3335 2018-04-26  Pedro Alves  <palves@redhat.com>
3336
3337         * linespec.c (struct bound_minimal_symbol_search_key): New.
3338         (convert_linespec_to_sals): Sort minimal symbols earlier.  Don't
3339         skip first line if we found a GNU ifunc minimal symbol by name.
3340         (compare_msymbols): Change parameters to work with a destructured
3341         lhs minsym.
3342         (compare_msymbols_for_qsort, compare_msymbols_for_bsearch): New
3343         functions.
3344
3345 2018-04-26  Pedro Alves  <palves@redhat.com>
3346
3347         * breakpoint.c (set_breakpoint_location_function): Don't resolve
3348         ifunc targets here.  Instead, if we have an ifunc minsym, use its
3349         address/name.
3350         (add_location_to_breakpoint): Store the minsym and the objfile in
3351         the breakpoint location.
3352         * breakpoint.h (bp_location) <msymbol, objfile>: New fields.
3353         * linespec.c (minsym_found): Resolve GNU ifunc targets here.
3354         Record the minsym in the sal.
3355         * symtab.h (symtab_and_line) <msymbol>: New field.
3356
3357 2018-04-26  Pedro Alves  <palves@redhat.com>
3358
3359         * elfread.c (elf_gnu_ifunc_resolve_by_got): Don't write to *ADDR_P
3360         unless we actually resolved the ifunc.
3361
3362 2018-04-26  Pedro Alves  <palves@redhat.com>
3363
3364         * c-exp.y (variable production): Prefer ifunc minsyms over
3365         regular function symbols.
3366         * symtab.c (find_gnu_ifunc): New function.
3367         * minsyms.h (lookup_msym_prefer): New enum.
3368         (lookup_minimal_symbol_by_pc_section): Replace 'want_trampoline'
3369         parameter by a lookup_msym_prefer parameter.
3370         * symtab.h (find_gnu_ifunc): New declaration.
3371
3372 2018-04-26  Pedro Alves  <palves@redhat.com>
3373
3374         * blockframe.c (find_gnu_ifunc_target_type): New function.
3375         (find_function_type): New.
3376         * eval.c (evaluate_var_msym_value): For GNU ifunc types, always
3377         return a value with a memory address.
3378         (eval_call): For calls to GNU ifunc functions, try to find the
3379         type of the target function from the type that the resolver
3380         returns.
3381         * gdbtypes.c (objfile_type): Don't install a return type for ifunc
3382         symbols.
3383         * infcall.c (find_function_return_type): Delete.
3384         (find_function_addr): Add 'function_type' parameter.  For calls to
3385         GNU ifunc functions, try to find the type of the target function
3386         from the type that the resolver returns, and return it via
3387         FUNCTION_TYPE.
3388         (call_function_by_hand_dummy): Adjust to use the function type
3389         returned by find_function_addr.
3390         (find_function_addr): Add 'function_type' parameter and move
3391         description here.
3392         * symtab.h (find_function_type, find_gnu_ifunc_target_type): New
3393         declarations.
3394
3395 2018-04-26  Pedro Alves  <palves@redhat.com>
3396
3397         * c-exp.y (variable production): Skip finding an alias for ifunc
3398         symbols.
3399
3400 2018-04-26  Pedro Alves  <palves@redhat.com>
3401
3402         * elfread.c (elf_rel_plt_read): Look for relocations for .got.plt too.
3403
3404 2018-04-25  Pedro Alves  <palves@redhat.com>
3405
3406         * infcmd.c (kill_command): Print the pid as string, not the whole
3407         thread's ptid.  Add comment.  s/has been killed/killed/ in output
3408         message.
3409         * remote.c (remote_detach_1): Print the pid as string, not the
3410         whole thread's ptid.
3411
3412 2018-04-24  Jan Kratochvil  <jan.kratochvil@redhat.com>
3413             Sergio Durigan Junior  <sergiodj@redhat.com>
3414             Pedro Alves  <palves@redhat.com>
3415
3416         * infcmd.c (kill_command): Print message when inferior has
3417         been killed.
3418         * inferior.c (print_inferior_events): Remove 'static'.  Set as
3419         '1'.
3420         (add_inferior): Improve message printed when
3421         'print_inferior_events' is on.
3422         (exit_inferior): Remove message printed when
3423         'print_inferior_events' is on.
3424         (detach_inferior): Improve message printed when
3425         'print_inferior_events' is on.
3426         (initialize_inferiors): Use 'add_inferior_silent' to set
3427         'current_inferior_'.
3428         * inferior.h (print_inferior_events): Declare here as
3429         'extern'.
3430         * infrun.c (follow_fork_inferior): Print '[Attaching...]' or
3431         '[Detaching...]' messages when 'print_inferior_events' is on.
3432         Use 'add_thread_silent' instead of 'add_thread'.  Add '[' and ']'
3433         as prefix/suffix for messages.  Remove periods.  Fix erroneous
3434         'Detaching after fork from child...', replace it by '... from
3435         parent...'.
3436         (handle_vfork_child_exec_or_exit): Add '[' and ']' as
3437         prefix/suffix when printing 'Detaching...' messages.  Print
3438         them when 'print_inferior_events' is on.
3439         * remote.c (remote_detach_1): Print message when detaching
3440         from inferior and '!is_fork_parent'.
3441
3442 2018-04-24  Tom Tromey  <tom@tromey.com>
3443
3444         * cli-out.h: Reindent.
3445
3446 2018-04-24  Tom Tromey  <tom@tromey.com>
3447
3448         * cli-out.c (cli_ui_out::out_field_fmt): Remove.
3449         (cli_ui_out::do_field_string): Use fputs_filtered.
3450         * cli-out.h (class cli_ui_out) <out_field_fmt>: Remove.
3451
3452 2018-04-23  Tom Tromey  <tom@tromey.com>
3453
3454         * guile/scm-frame.c (gdbscm_frame_read_var): Use
3455         gdb::unique_xmalloc_ptr.
3456
3457 2018-04-23  Tom Tromey  <tom@tromey.com>
3458
3459         * configure: Rebuild.
3460
3461 2018-04-22  Rajendra SY  <rajendra.sy@gmail.com>
3462
3463         PR gdb/23095
3464         * gdb/testsuite/gdb.base/break-probes.exp: Pass shlib_load to
3465         prepare_for_testing.  Set normal_bp to r_debug_state if target
3466         is bsd.
3467
3468 2018-04-21  Pedro Alves  <palves@redhat.com>
3469             Rajendra SY  <rajendra.sy@gmail.com>
3470
3471         * inf-ptrace.c (inf_ptrace_attach): Mark the thread as executing.
3472         * remote.c (extended_remote_attach): In all-stop mode, mark the
3473         thread as executing.
3474
3475 2018-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3476
3477         * thread.c (thread_apply_all_command): Fix comment.
3478         (thread_command): Fix comment.
3479
3480 2018-04-10  Alan Hayward  <alan.hayward@arm.com>
3481
3482         * common/tdesc.h (tdesc_create_feature): Remove xml filename
3483         parameter.
3484         * features/aarch64-core.c (create_feature_aarch64_core):
3485         Regenerate.
3486         * features/aarch64-fpu.c (create_feature_aarch64_fpu):
3487         Likewise.
3488         * features/i386/32bit-avx.c (create_feature_i386_32bit_avx):
3489         Likewise.
3490         * features/i386/32bit-avx512.c
3491         (create_feature_i386_32bit_avx512): Likewise.
3492         * features/i386/32bit-core.c (create_feature_i386_32bit_core):
3493         Likewise.
3494         * features/i386/32bit-linux.c (create_feature_i386_32bit_linux):
3495         Likewise.
3496         * features/i386/32bit-mpx.c (create_feature_i386_32bit_mpx):
3497         Likewise.
3498         * features/i386/32bit-pkeys.c (create_feature_i386_32bit_pkeys):
3499         Likewise.
3500         * features/i386/32bit-sse.c (create_feature_i386_32bit_sse):
3501         Likewise.
3502         * features/i386/64bit-avx.c (create_feature_i386_64bit_avx):
3503         Likewise.
3504         * features/i386/64bit-avx512.c
3505         (create_feature_i386_64bit_avx512): Likewise.
3506         * features/i386/64bit-core.c (create_feature_i386_64bit_core):
3507         Likewise.
3508         * features/i386/64bit-linux.c (create_feature_i386_64bit_linux):
3509         Likewise.
3510         * features/i386/64bit-mpx.c (create_feature_i386_64bit_mpx):
3511         Likewise.
3512         * features/i386/64bit-pkeys.c (create_feature_i386_64bit_pkeys):
3513         Likewise.
3514         * features/i386/64bit-segments.c
3515         (create_feature_i386_64bit_segments): Likewise.
3516         * features/i386/64bit-sse.c (create_feature_i386_64bit_sse):
3517         Likewise.
3518         * features/i386/x32-core.c
3519         (create_feature_i386_x32_core): Likewise.
3520         * features/tic6x-c6xp.c (create_feature_tic6x_c6xp): Likewise.
3521         * features/tic6x-core.c (create_feature_tic6x_core): Likewise.
3522         * features/tic6x-gp.c (create_feature_tic6x_gp): Likewise.
3523         * target-descriptions.c: In generated code, don't pass xml
3524         filename.
3525
3526 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
3527
3528         * common/tdesc.c (print_xml_feature::visit_pre): Add xml parsing.
3529         (print_xml_feature::visit_post): Likewise.
3530         (print_xml_feature::visit): Likewise.
3531         * common/tdesc.h (tdesc_get_features_xml): Use const tdesc.
3532         (print_xml_feature): Add new class.
3533         * regformats/regdat.sh: Null xmltarget on feature targets.
3534         * target-descriptions.c (struct target_desc): Add xmltarget.
3535         (maintenance_check_tdesc_xml_convert): Add unittest function.
3536         (tdesc_get_features_xml): Add function to get xml.
3537         (maintenance_check_xml_descriptions): Test xml generation.
3538         * xml-tdesc.c (string_read_description_xml): Add function.
3539         * xml-tdesc.h (string_read_description_xml): Add declaration.
3540
3541 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
3542
3543         * features/Makefile: Add feature marker to targets with new style
3544         target descriptions.
3545         * regformats/aarch64.dat: Regenerate.
3546         * regformats/i386/amd64-avx-avx512-linux.dat: Likewise.
3547         * regformats/i386/amd64-avx-linux.dat: Likewise.
3548         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Likewise.
3549         * regformats/i386/amd64-avx-mpx-linux.dat: Likewise.
3550         * regformats/i386/amd64-linux.dat: Likewise.
3551         * regformats/i386/amd64-mpx-linux.dat: Likewise.
3552         * regformats/i386/amd64.dat: Likewise.
3553         * regformats/i386/i386-avx-avx512-linux.dat: Likewise.
3554         * regformats/i386/i386-avx-linux.dat: Likewise.
3555         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Likewise.
3556         * regformats/i386/i386-avx-mpx-linux.dat: Likewise.
3557         * regformats/i386/i386-linux.dat: Likewise.
3558         * regformats/i386/i386-mmx-linux.dat: Likewise.
3559         * regformats/i386/i386-mpx-linux.dat: Likewise.
3560         * regformats/i386/i386.dat: Likewise.
3561         * regformats/i386/x32-avx-avx512-linux.dat: Likewise.
3562         * regformats/i386/x32-avx-linux.dat: Likewise.
3563         * regformats/i386/x32-linux.dat: Likewise.
3564         * regformats/tic6x-c62x-linux.dat: Likewise.
3565         * regformats/tic6x-c64x-linux.dat: Likewise.
3566         * regformats/tic6x-c64xp-linux.dat: Likewise.
3567         * regformats/regdat.sh: Parse feature marker.
3568
3569 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
3570
3571         * common/tdesc.h (tdesc_architecture_name): Add new declaration.
3572         (tdesc_osabi_name): Likewise.
3573         * target-descriptions.c (tdesc_architecture_name): Add new
3574         function.
3575         (tdesc_osabi_name): Likewise.
3576
3577 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
3578
3579         * common/tdesc.c (tdesc_predefined_type): Move to here.
3580         (tdesc_named_type): Likewise.
3581         (tdesc_create_vector): Likewise.
3582         (tdesc_create_struct): Likewise.
3583         (tdesc_set_struct_size): Likewise.
3584         (tdesc_create_union): Likewise.
3585         (tdesc_create_flags): Likewise.
3586         (tdesc_create_enum): Likewise.
3587         (tdesc_add_field): Likewise.
3588         (tdesc_add_typed_bitfield): Likewise.
3589         (tdesc_add_bitfield): Likewise.
3590         (tdesc_add_flag): Likewise.
3591         (tdesc_add_enum_value): Likewise.
3592         * common/tdesc.h (struct tdesc_type_builtin): Likewise.
3593         (struct tdesc_type_vector): Likewise.
3594         (struct tdesc_type_field): Likewise.
3595         (struct tdesc_type_with_fields): Likewise.
3596         (tdesc_create_enum): Add declaration.
3597         (tdesc_add_typed_bitfield): Likewise.
3598         (tdesc_add_enum_value): Likewise.
3599         * target-descriptions.c (tdesc_type_field): Move from here.
3600         (tdesc_type_builtin): Likewise.
3601         (tdesc_type_vector): Likewise.
3602         (tdesc_type_with_fields): Likewise.
3603         (tdesc_predefined_types): Likewise.
3604         (tdesc_named_type): Likewise.
3605         (tdesc_create_vector): Likewise.
3606         (tdesc_create_struct): Likewise.
3607         (tdesc_set_struct_size): Likewise.
3608         (tdesc_create_union): Likewise.
3609         (tdesc_create_flags): Likewise.
3610         (tdesc_create_enum): Likewise.
3611         (tdesc_add_field): Likewise.
3612         (tdesc_add_typed_bitfield): Likewise.
3613         (tdesc_add_bitfield): Likewise.
3614         (tdesc_add_flag): Likewise.
3615         (tdesc_add_enum_value): Likewise.
3616         * gdb/target-descriptions.h (tdesc_create_enum): Likewise.
3617         (tdesc_add_typed_bitfield): Likewise.
3618         (tdesc_add_enum_value): Likewise.
3619
3620 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
3621
3622         * common/tdesc.c (tdesc_feature::accept): Move to here.
3623         (tdesc_feature::operator==): Likewise.
3624         (tdesc_create_reg): Likewise.
3625         * common/tdesc.h (tdesc_type_kind): Likewise.
3626         (struct tdesc_type): Likewise.
3627         (struct tdesc_feature): Likewise.
3628         * regformats/regdat.sh: Create a feature.
3629         * target-descriptions.c (tdesc_type_kind): Move from here.
3630         (tdesc_type): Likewise.
3631         (tdesc_type_up): Likewise.
3632         (tdesc_feature): Likewise.
3633         (tdesc_create_reg): Likewise.
3634
3635 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
3636
3637         * Makefile.in: Add arch/tdesc.c
3638         * common/tdesc.c: New file.
3639         * common/tdesc.h (tdesc_element_visitor): Move to here.
3640         (tdesc_element): Likewise.
3641         (tdesc_reg): Likewise.
3642         (tdesc_reg_up): Likewise.
3643         * regformats/regdef.h (reg): Add offset to constructors.
3644         * target-descriptions.c (tdesc_element_visitor): Move from here.
3645         (tdesc_element): Likewise.
3646         (tdesc_reg): Likewise.
3647         (tdesc_reg_up): Likewise.
3648
3649 2018-04-17  Tom Tromey  <tom@tromey.com>
3650
3651         * dwarf2read.c (quirk_rust_enum): Conditionally drop the
3652         discriminant field.
3653
3654 2018-04-17  Tom Tromey  <tom@tromey.com>
3655
3656         * dwarf2read.c (quirk_rust_enum): Handle unions correctly.
3657
3658 2018-04-17  Andreas Arnez  <arnez@linux.vnet.ibm.com>
3659
3660         * symtab.c (print_symbol_info): Skip printing filename and line
3661         number when `last' is NULL.
3662         (symtab_symbol_info): Use empty string instead of NULL for first
3663         invocation of print_symbol_info.
3664         (rbreak_command): Pass NULL to `last' parameter of
3665         print_symbol_info.
3666
3667 2018-04-16  Simon Marchi  <simon.marchi@ericsson.com>
3668
3669         * linux-tdep.c (linux_spu_make_corefile_notes): Return note_data
3670         instead of nullptr.
3671
3672 2018-04-16  Pedro Alves  <palves@redhat.com>
3673
3674         * MAINTAINERS (sh): Remove.
3675         * Makefile.in (ALL_TARGET_OBS): Remove sh64-tdep.o.
3676         (HFILES_NO_SRCDIR): Remove sh64-tdep.h.
3677         (ALLDEPFILES): Remove sh64-tdep.c.
3678         * NEWS: Mentions that support for SH-5/SH64 is removed.
3679         * configure.tgt (sh*-*-linux*): Remove reference to sh64-tdep.o.
3680         (sh*-*-openbsd*): Ditto.
3681         (sh64-*-elf*): Remove.
3682         (sh*): Remove.
3683         * regcache.c (cooked_write_test): Remove bfd_mach_sh5 case.
3684         * sh-linux-tdep.c: Remove reference to bfd_mach_sh5.
3685         * sh-tdep.c: No longer include "sh64-tdep.h".
3686         (sh_gdbarch_init): Remove reference to bfd_mach_sh5.
3687         * sh64-tdep.c, sh64-tdep.h: Remove files.
3688
3689 2018-04-16  Pedro Alves  <palves@redhat.com>
3690
3691         * MAINTAINERS: Remove m88k.
3692         * Makefile.in (ALL_TARGET_OBS): Remove m88k-tdep.o.
3693         (HFILES_NO_SRCDIR): Remove m88k-tdep.h.
3694         (ALLDEPFILES): Remove m88k-bsd-nat.c and m88k-tdep.c.
3695         * NEWS: Mention that support for m88k was removed.
3696         * configure.host (m88*-*-*): Remove support.
3697         * configure.nat (m88k-*-*): Remove support.
3698         * configure.tgt (m88*-*-openbsd*): Remove.
3699         * m88k-bsd-nat.c, m88k-tdep.c, m88k-tdep.h: Delete.
3700
3701 2018-04-15  Simon Marchi  <simon.marchi@polymtl.ca>
3702
3703         * configure.tgt (x86_tobjs): New variable.
3704         (amd64_tobjs, i386_tobjs): Use it.
3705
3706 2018-04-13  Andreas Arnez  <arnez@linux.vnet.ibm.com>
3707
3708         * symtab.c (print_symbol_info): Precede the symbol definition by
3709         the line number when available.
3710         * NEWS: Advertise this enhancement.
3711
3712 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
3713
3714         * NEWS (New options): announce set/show record btrace cpu.
3715         * btrace.c: Include record-btrace.h.
3716         (btrace_compute_ftrace_pt): Skip enabling errata workarounds if
3717         the vendor is unknown.
3718         (btrace_compute_ftrace_1): Add cpu parameter.  Update callers.
3719         Maybe overwrite the btrace configuration's cpu.
3720         (btrace_compute_ftrace): Add cpu parameter.  Update callers.
3721         (btrace_fetch): Add cpu parameter.  Update callers.
3722         (btrace_maint_update_pt_packets): Call record_btrace_get_cpu.
3723         Maybe overwrite the btrace configuration's cpu.  Skip enabling
3724         errata workarounds if the vendor is unknown.
3725         * python/py-record-btrace.c: Include record-btrace.h.
3726         (recpy_bt_begin, recpy_bt_end, recpy_bt_instruction_history)
3727         (recpy_bt_function_call_history): Call record_btrace_get_cpu.
3728         * record-btrace.c (record_btrace_cpu_state_kind): New.
3729         (record_btrace_cpu): New.
3730         (set_record_btrace_cpu_cmdlist): New.
3731         (record_btrace_get_cpu): New.
3732         (require_btrace_thread, record_btrace_info)
3733         (record_btrace_resume_thread): Call record_btrace_get_cpu.
3734         (cmd_set_record_btrace_cpu_none): New.
3735         (cmd_set_record_btrace_cpu_auto): New.
3736         (cmd_set_record_btrace_cpu): New.
3737         (cmd_show_record_btrace_cpu): New.
3738         (_initialize_record_btrace): Initialize set/show record btrace cpu
3739         commands.
3740         * record-btrace.h (record_btrace_get_cpu): New.
3741
3742 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
3743
3744         * record.c (set_record_command): Fix typo in message.
3745
3746 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
3747
3748         * record-btrace.c (cmd_set_record_btrace): Print sub-commands.
3749
3750 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
3751
3752         * infrun.c (process_event_stop_test): Call
3753         gdbarch_in_indirect_branch_thunk.
3754         * gdbarch.sh (in_indirect_branch_thunk): New.
3755         * gdbarch.c: Regenerated.
3756         * gdbarch.h: Regenerated.
3757         * x86-tdep.h: New.
3758         * x86-tdep.c: New.
3759         * Makefile.in (ALL_TARGET_OBS): Add x86-tdep.o.
3760         (HFILES_NO_SRCDIR): Add x86-tdep.h.
3761         (ALLDEPFILES): Add x86-tdep.c.
3762         * arch-utils.h (default_in_indirect_branch_thunk): New.
3763         * arch-utils.c (default_in_indirect_branch_thunk): New.
3764         * i386-tdep: Include x86-tdep.h.
3765         (i386_in_indirect_branch_thunk): New.
3766         (i386_elf_init_abi): Set in_indirect_branch_thunk gdbarch
3767         function.
3768         * amd64-tdep: Include x86-tdep.h.
3769         (amd64_in_indirect_branch_thunk): New.
3770         (amd64_init_abi): Set in_indirect_branch_thunk gdbarch function.
3771
3772 2018-04-12  Jan Kratochvil  <jan.kratochvil@redhat.com>
3773
3774         PR gdb/23053
3775         * dwarf-index-write.c (data_buf::grow) (write_one_signatured_type)
3776         (recursively_write_psymbols) (debug_names::recursively_write_psymbols)
3777         (debug_names::write_one_signatured_type): Fix -D_GLIBCXX_DEBUG
3778         regression.
3779
3780 2018-04-12  Tom Tromey  <tom@tromey.com>
3781
3782         * rust-lang.c (rust_print_struct_def): Remove univariant code.
3783         (rust_evaluate_subexp): Likewise.
3784
3785 2018-04-12  Pedro Alves  <palves@redhat.com>
3786
3787         * procfs.c (procfs_detach): Make forward declaration's prototype
3788         match definition's protototype.
3789         (proc_get_LDT_entry): Remove stale do_cleanups call.
3790
3791 2018-04-12  Pedro Alves  <palves@redhat.com>
3792
3793         * target.h (target_ops::to_has_exited): Delete.
3794         (target_has_exited): Delete.
3795         * target-delegates.c: Regenerate.
3796
3797 2018-04-11  Pedro Alves  <palves@redhat.com>
3798
3799         * target.c (fileio_fh_t::t): Add comment.
3800         (target_fileio_pwrite, target_fileio_pread, target_fileio_fstat)
3801         (target_fileio_close): Handle a NULL target.
3802         (invalidate_fileio_fh): New.
3803         (target_close): Call it.
3804         * remote.c (remote_hostio_send_command): No longer check whether
3805         remote_desc is open.
3806
3807 2018-04-11  Pedro Alves  <palves@redhat.com>
3808
3809         * target.c (fileio_fh_t): Make it a named struct instead of a
3810         typedef.
3811         (fileio_fh_t::is_closed): New method.
3812         (DEF_VEC_O (fileio_fh_t)): Remove.
3813         (fileio_fhandles): Now a std::vector.
3814         (is_closed_fileio_fh): Delete.
3815         (acquire_fileio_fd): Adjust.  Rename parameters.
3816         (release_fileio_fd): Adjust.
3817         (fileio_fd_to_fh): Reimplement as a function instead of a macro.
3818         (target_fileio_pwrite, target_fileio_pread, target_fileio_fstat)
3819         (target_fileio_close): Adjust.
3820
3821 2018-04-10  Simon Marchi  <simon.marchi@ericsson.com>
3822
3823         * auto-load.c (auto_load_safe_path_vec_update): Iterate by
3824         index.
3825
3826 2018-04-10  Pedro Alves  <palves@redhat.com>
3827
3828         * gdbthread.h (finish_thread_state_cleanup): Delete declaration.
3829         (scoped_finish_thread_state): New class.
3830         * infcmd.c (run_command_1): Use it instead of finish_thread_state
3831         cleanup.
3832         * infrun.c (proceed, prepare_for_detach, wait_for_inferior)
3833         (fetch_inferior_event, normal_stop): Likewise.
3834         * thread.c (finish_thread_state_cleanup): Delete.
3835
3836 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3837             Pedro Alves  <palves@redhat.com>
3838
3839         * value.c: Include "selftest.h" and "common/array-view.h".
3840         (struct range) <operator ==>: New.
3841         (test_ranges_contain): New.
3842         (check_ranges_vector): New.
3843         (test_insert_into_bit_range_vector): New.
3844         (_initialize_values): Register selftests.
3845         * common/array-view.h (operator==, operator!=): New.
3846
3847 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3848
3849         * common/gdb_vecs.h (unordered_remove): Add overload that takes
3850         an iterator.
3851         * inline-frame.c: Include <algorithm>.
3852         (struct inline_state): Add constructor.
3853         (inline_state_s): Remove.
3854         (DEF_VEC_O(inline_state_s)): Remove.
3855         (inline_states): Change type to std::vector.
3856         (find_inline_frame_state): Adjust to std::vector.
3857         (allocate_inline_frame_state): Remove.
3858         (clear_inline_frame_state): Adjust to std::vector.
3859         (skip_inline_frames): Adjust to std::vector.
3860
3861 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3862
3863         * tracepoint.h (struct trace_state_variable): Add constructor.
3864         <name>: Change type to std::string.
3865         * tracepoint.c (tsv_s): Remove.
3866         (DEF_VEC_O(tsv_s)): Remove.
3867         (tvariables): Change to std::vector.
3868         (create_trace_state_variable): Adjust to std::vector.
3869         (find_trace_state_variable): Likewise.
3870         (find_trace_state_variable_by_number): Likewise.
3871         (delete_trace_state_variable): Likewise.
3872         (trace_variable_command): Adjust to std::string.
3873         (delete_trace_variable_command): Likewise.
3874         (tvariables_info_1): Adjust to std::vector.
3875         (save_trace_state_variables): Likewise.
3876         (start_tracing): Likewise.
3877         (merge_uploaded_trace_state_variables): Adjust to std::vector
3878         and std::string.
3879         * target.h (struct target_ops)
3880         <to_download_trace_state_variable>: Pass reference to
3881         trace_state_variable.
3882         * target-debug.h (target_debug_print_const_trace_state_variable_r): New.
3883         * target-delegates.c: Re-generate.
3884         * mi/mi-interp.c (mi_tsv_created): Adjust to std::string.
3885         (mi_tsv_deleted): Likewise.
3886         * mi/mi-main.c (mi_cmd_trace_frame_collected): Likewise.
3887         * remote.c (remote_download_trace_state_variable): Change
3888         pointer to reference and adjust.
3889         * make-target-delegates (parse_argtypes): Handle references.
3890         (write_function_header): Likewise.
3891         (munge_type): Likewise.
3892
3893 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3894
3895         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
3896         string_view-selftests.c.
3897         * unittests/basic_string_view/capacity/1.cc: Adapt to GDB
3898         testsuite.
3899         * unittests/basic_string_view/cons/char/1.cc: Likewise.
3900         * unittests/basic_string_view/cons/char/2.cc: Likewise.
3901         * unittests/basic_string_view/cons/char/3.cc: Likewise.
3902         * unittests/basic_string_view/element_access/char/1.cc:
3903         Likewise.
3904         * unittests/basic_string_view/element_access/char/empty.cc:
3905         Likewise.
3906         * unittests/basic_string_view/element_access/char/front_back.cc:
3907         Likewise.
3908         * unittests/basic_string_view/inserters/char/2.cc: Likewise.
3909         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc:
3910         Likewise.
3911         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc:
3912         Likewise.
3913         * unittests/basic_string_view/modifiers/swap/char/1.cc:
3914         Likewise.
3915         * unittests/basic_string_view/operations/compare/char/1.cc:
3916         Likewise.
3917         * unittests/basic_string_view/operations/compare/char/13650.cc:
3918         Likewise.
3919         * unittests/basic_string_view/operations/copy/char/1.cc:
3920         Likewise.
3921         * unittests/basic_string_view/operations/data/char/1.cc:
3922         Likewise.
3923         * unittests/basic_string_view/operations/find/char/1.cc:
3924         Likewise.
3925         * unittests/basic_string_view/operations/find/char/2.cc:
3926         Likewise.
3927         * unittests/basic_string_view/operations/find/char/3.cc:
3928         Likewise.
3929         * unittests/basic_string_view/operations/find/char/4.cc:
3930         Likewise.
3931         * unittests/basic_string_view/operations/rfind/char/1.cc:
3932         Likewise.
3933         * unittests/basic_string_view/operations/rfind/char/2.cc:
3934         Likewise.
3935         * unittests/basic_string_view/operations/rfind/char/3.cc:
3936         Likewise.
3937         * unittests/basic_string_view/operations/substr/char/1.cc:
3938         Likewise.
3939         * unittests/basic_string_view/operators/char/2.cc: Likewise.
3940         * unittests/string_view-selftests.c: New file.
3941
3942 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3943
3944         * unittests/basic_string_view/capacity/1.cc: New file.
3945         * unittests/basic_string_view/capacity/empty_neg.cc: New file.
3946         * unittests/basic_string_view/cons/char/1.cc: New file.
3947         * unittests/basic_string_view/cons/char/2.cc: New file.
3948         * unittests/basic_string_view/cons/char/3.cc: New file.
3949         * unittests/basic_string_view/cons/wchar_t/1.cc: New file.
3950         * unittests/basic_string_view/cons/wchar_t/2.cc: New file.
3951         * unittests/basic_string_view/cons/wchar_t/3.cc: New file.
3952         * unittests/basic_string_view/element_access/char/1.cc: New file.
3953         * unittests/basic_string_view/element_access/char/2.cc: New file.
3954         * unittests/basic_string_view/element_access/char/empty.cc: New file.
3955         * unittests/basic_string_view/element_access/char/front_back.cc: New file.
3956         * unittests/basic_string_view/element_access/wchar_t/1.cc: New file.
3957         * unittests/basic_string_view/element_access/wchar_t/2.cc: New file.
3958         * unittests/basic_string_view/element_access/wchar_t/empty.cc: New file.
3959         * unittests/basic_string_view/element_access/wchar_t/front_back.cc: New file.
3960         * unittests/basic_string_view/include.cc: New file.
3961         * unittests/basic_string_view/inserters/char/1.cc: New file.
3962         * unittests/basic_string_view/inserters/char/2.cc: New file.
3963         * unittests/basic_string_view/inserters/char/3.cc: New file.
3964         * unittests/basic_string_view/inserters/pod/10081-out.cc: New file.
3965         * unittests/basic_string_view/inserters/wchar_t/1.cc: New file.
3966         * unittests/basic_string_view/inserters/wchar_t/2.cc: New file.
3967         * unittests/basic_string_view/inserters/wchar_t/3.cc: New file.
3968         * unittests/basic_string_view/literals/types.cc: New file.
3969         * unittests/basic_string_view/literals/values.cc: New file.
3970         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc: New file.
3971         * unittests/basic_string_view/modifiers/remove_prefix/wchar_t/1.cc: New file.
3972         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc: New file.
3973         * unittests/basic_string_view/modifiers/remove_suffix/wchar_t/1.cc: New file.
3974         * unittests/basic_string_view/modifiers/swap/char/1.cc: New file.
3975         * unittests/basic_string_view/modifiers/swap/wchar_t/1.cc: New file.
3976         * unittests/basic_string_view/operations/compare/char/1.cc: New file.
3977         * unittests/basic_string_view/operations/compare/char/13650.cc: New file.
3978         * unittests/basic_string_view/operations/compare/char/2.cc: New file.
3979         * unittests/basic_string_view/operations/compare/char/70483.cc: New file.
3980         * unittests/basic_string_view/operations/compare/wchar_t/1.cc: New file.
3981         * unittests/basic_string_view/operations/compare/wchar_t/13650.cc: New file.
3982         * unittests/basic_string_view/operations/compare/wchar_t/2.cc: New file.
3983         * unittests/basic_string_view/operations/copy/char/1.cc: New file.
3984         * unittests/basic_string_view/operations/copy/wchar_t/1.cc: New file.
3985         * unittests/basic_string_view/operations/data/char/1.cc: New file.
3986         * unittests/basic_string_view/operations/data/wchar_t/1.cc: New file.
3987         * unittests/basic_string_view/operations/find/char/1.cc: New file.
3988         * unittests/basic_string_view/operations/find/char/2.cc: New file.
3989         * unittests/basic_string_view/operations/find/char/3.cc: New file.
3990         * unittests/basic_string_view/operations/find/char/4.cc: New file.
3991         * unittests/basic_string_view/operations/find/wchar_t/1.cc: New file.
3992         * unittests/basic_string_view/operations/find/wchar_t/2.cc: New file.
3993         * unittests/basic_string_view/operations/find/wchar_t/3.cc: New file.
3994         * unittests/basic_string_view/operations/find/wchar_t/4.cc: New file.
3995         * unittests/basic_string_view/operations/rfind/char/1.cc: New file.
3996         * unittests/basic_string_view/operations/rfind/char/2.cc: New file.
3997         * unittests/basic_string_view/operations/rfind/char/3.cc: New file.
3998         * unittests/basic_string_view/operations/rfind/wchar_t/1.cc: New file.
3999         * unittests/basic_string_view/operations/rfind/wchar_t/2.cc: New file.
4000         * unittests/basic_string_view/operations/rfind/wchar_t/3.cc: New file.
4001         * unittests/basic_string_view/operations/string_conversion/1.cc: New file.
4002         * unittests/basic_string_view/operations/substr/char/1.cc: New file.
4003         * unittests/basic_string_view/operations/substr/wchar_t/1.cc: New file.
4004         * unittests/basic_string_view/operators/char/2.cc: New file.
4005         * unittests/basic_string_view/operators/wchar_t/2.cc: New file.
4006         * unittests/basic_string_view/range_access/char/1.cc: New file.
4007         * unittests/basic_string_view/range_access/wchar_t/1.cc: New file.
4008         * unittests/basic_string_view/requirements/explicit_instantiation/1.cc: New file.
4009         * unittests/basic_string_view/requirements/explicit_instantiation/char/1.cc: New file.
4010         * unittests/basic_string_view/requirements/explicit_instantiation/char16_t/1.cc: New file.
4011         * unittests/basic_string_view/requirements/explicit_instantiation/char32_t/1.cc: New file.
4012         * unittests/basic_string_view/requirements/explicit_instantiation/wchar_t/1.cc: New file.
4013         * unittests/basic_string_view/requirements/typedefs.cc: New file.
4014         * unittests/basic_string_view/typedefs.cc: New file.
4015         * unittests/basic_string_view/types/1.cc: New file.
4016
4017 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
4018
4019         * common/gdb_string_view.h: Remove libstdc++ implementation
4020         details, adjust to gdb reality.
4021         * common/gdb_string_view.tcc: Likewise.
4022         * cli/cli-script.c (struct string_view): Remove.
4023         (user_args) <m_args>: Change element type to gdb::string_view.
4024         (user_args::insert_args): Adjust.
4025
4026 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
4027
4028         * common/gdb_string_view.h: New file.
4029         * common/gdb_string_view.tcc: New file.
4030
4031 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
4032
4033         * ax_cxx_compile_stdcxx.m4: Sync with upstream.
4034         * configure: Re-generate.
4035
4036 2018-04-09  Pedro Alves  <palves@redhat.com>
4037
4038         * gdbarch.sh: Include "observable.h" instead of "observer.h".
4039         (set_target_gdbarch): Call
4040         gdb::observers::architecture_changed.notify instead of
4041         observer_notify_architecture_changed.
4042
4043 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
4044
4045         * tracepoint.c (struct current_traceframe_cleanup): Remove.
4046         (do_restore_current_traceframe_cleanup): Remove.
4047         (restore_current_traceframe_cleanup_dtor): Remove.
4048         (make_cleanup_restore_current_traceframe): Remove.
4049         (scoped_restore_current_traceframe::scoped_restore_current_traceframe):
4050         New.
4051         * tracepoint.h (struct scoped_restore_current_traceframe): New.
4052         * infrun.c (fetch_inferior_event): Use
4053         scoped_restore_current_traceframe.
4054
4055 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
4056
4057         * dwarf2read.h (struct dwarf2_per_objfile) <n_type_units>:
4058         Remove.
4059         <n_allocated_type_units>: Remove.
4060         <all_type_units>: Change to std::vector.
4061         * dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile): Adjust
4062         to std::vector change.
4063         (dwarf2_per_objfile::get_cutu): Likewise.
4064         (dwarf2_per_objfile::get_tu): Likewise.
4065         (create_signatured_type_table_from_index): Likewise.
4066         (create_signatured_type_table_from_debug_names): Likewise.
4067         (dw2_symtab_iter_next): Likewise.
4068         (dw2_print_stats): Likewise.
4069         (dw2_expand_all_symtabs): Likewise.
4070         (dw2_expand_marked_cus): Likewise.
4071         (dw2_debug_names_iterator::next): Likewise.
4072         (dwarf2_initialize_objfile): Likewise.
4073         (add_signatured_type_cu_to_table): Likewise.
4074         (create_all_type_units): Likewise.
4075         (add_type_unit): Likewise.
4076         (struct tu_abbrev_offset): Add constructor.
4077         (build_type_psymtabs_1): Adjust to std::vector change.
4078         (print_tu_stats): Likewise.
4079         * dwarf-index-write.c (check_dwarf64_offsets): Likewise.
4080         (write_debug_names): Likewise.
4081
4082 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
4083
4084         * dwarf2read.h (struct dwarf2_per_objfile) <all_comp_units>: Likewise.
4085         Make an std::vector.
4086         <n_comp_units>: Remove.
4087         * dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile): Adjust
4088         to std::vector change.
4089         (dwarf2_per_objfile::get_cutu): Likewise.
4090         (dwarf2_per_objfile::get_cu): Likewise.
4091         (create_cus_from_index): Likewise.
4092         (create_addrmap_from_index): Likewise.
4093         (create_addrmap_from_aranges): Likewise.
4094         (dwarf2_read_index): Likewise.
4095         (dw2_find_last_source_symtab): Likewise.
4096         (dw2_map_symtabs_matching_filename): Likewise.
4097         (dw2_symtab_iter_next): Likewise.
4098         (dw2_print_stats): Likewise.
4099         (dw2_expand_all_symtabs): Likewise.
4100         (dw2_expand_symtabs_with_fullname): Likewise.
4101         (dw2_expand_marked_cus): Likewise.
4102         (dw2_map_symbol_filenames): Likewise.
4103         (create_cus_from_debug_names): Likewise.
4104         (dwarf2_read_debug_names): Likewise.
4105         (dw2_debug_names_iterator::next): Likewise.
4106         (dwarf2_initialize_objfile): Likewise.
4107         (set_partial_user): Likewise.
4108         (dwarf2_build_psymtabs_hard): Likewise.
4109         (read_comp_units_from_section): Remove arguments, adjust to
4110         std::vector change.
4111         (create_all_comp_units): Adjust to std::vector and
4112         read_comp_units_from_section changes.
4113         (dwarf2_find_containing_comp_unit): Adjust to std::vector
4114         change.
4115         * dwarf-index-write.c (check_dwarf64_offsets): Likewise.
4116         (psyms_seen_size): Likewise.
4117         (write_gdbindex): Likewise.
4118         (write_debug_names): Likewise.
4119
4120 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
4121
4122         * dwarf2read.c (create_cus_from_index_list): Replace objfile arg
4123         with dwarf2_per_objfile.
4124         (create_cus_from_index): Likewise.
4125         (create_signatured_type_table_from_index): Likewise.
4126         (dwarf2_read_index): Likewise.
4127         (dwarf2_initialize_objfile): Likewise.
4128         (dwarf2_fetch_die_loc_sect_off):  Get dwarf2_per_objfile from
4129         per_cu rather than get_dwarf2_per_objfile.
4130
4131 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
4132
4133         * dwarf2read.h (struct signatured_type): Forward declare.
4134         (struct dwarf2_per_objfile) <get_cutu, get_cu, get_tu>:
4135         New methods.
4136         * dwarf2read.c (dwarf2_per_objfile::get_cutu): Rename from...
4137         (dw2_get_cutu): ...this.
4138         (dwarf2_per_objfile::get_cu): Rename from...
4139         (dw2_get_cu): ...this.
4140         (dwarf2_per_objfile::get_tu): New.
4141         (create_addrmap_from_index): Adjust.
4142         (create_addrmap_from_aranges): Adjust.
4143         (dw2_find_last_source_symtab): Adjust.
4144         (dw2_map_symtabs_matching_filename): Adjust.
4145         (dw2_symtab_iter_next): Adjust.
4146         (dw2_print_stats): Adjust.
4147         (dw2_expand_all_symtabs): Adjust.
4148         (dw2_expand_symtabs_with_fullname): Adjust.
4149         (dw2_expand_marked_cus): Adjust.
4150         (dw_expand_symtabs_matching_file_matcher): Adjust.
4151         (dw2_map_symbol_filenames): Adjust.
4152         (dw2_debug_names_iterator::next): Adjust.
4153         (dwarf2_initialize_objfile): Adjust.
4154         (set_partial_user): Adjust.
4155         (dwarf2_build_psymtabs_hard): Adjust.
4156
4157 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
4158
4159         * dwarf2read.c (create_signatured_type_table_from_debug_names):
4160         Remove unused variables.
4161         (dw2_map_symtabs_matching_filename): Likewise.
4162         (dwarf2_record_block_ranges): Likewise.
4163         (dwarf2_read_addr_index): Likewise.
4164         (follow_die_offset): Likewise.
4165
4166 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
4167
4168         * progspace.c (clone_program_space): Pass SYMFILE_DEFER_BP_RESET
4169         to symbol_file_add_main.
4170
4171 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
4172
4173         PR mi/22299
4174         * mi/mi-console.c (do_fputc_async_safe): New.
4175         (mi_console_file::write_async_safe): New.
4176         (mi_console_file::flush): Adjust calls to fputstrn_unfiltered.
4177         * mi/mi-console.h (class mi_console_file) <write_async_safe>:
4178         New.
4179         * ui-file.c (ui_file::putstrn): Adjust call to
4180         fputstrn_unfiltered.
4181         * utils.c (printchar): Replace do_fputs and do_fprintf
4182         parameters by do_fputc.
4183         (fputstr_filtered): Adjust call to printchar.
4184         (fputstr_unfiltered): Likewise.
4185         (fputstrn_filtered): Likewise.
4186         (fputstrn_unfiltered): Add do_fputc parameter, pass to
4187         printchar.
4188         * utils.h (do_fputc_ftype): New typedef.
4189         (fputstrn_unfiltered): Add do_fputc parameter.
4190
4191 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
4192
4193         * regformats/i386/i386-avx.dat: Remove.
4194
4195 2018-04-07  Simon Marchi  <simon.marchi@ericsson.com>
4196
4197         PR gdb/22979
4198         * amd64-tdep.c (amd64_none_init_abi): New function.
4199         (amd64_x32_none_init_abi): New function.
4200         (_initialize_amd64_tdep): Register handlers for x86-64 and
4201         x64_32 with GDB_OSABI_NONE.
4202         * osabi.c (gdbarch_init_osabi): Allow running handlers for the
4203         GDB_OSABI_NONE osabi.
4204
4205 2018-04-07  Simon Marchi  <simon.marchi@ericsson.com>
4206
4207         PR gdb/22980
4208         * defs.h (enum gdb_osabi): Remove GDB_OSABI_UNINITIALIZED, add
4209         GDB_OSABI_NONE.
4210         * arch-utils.c (gdbarch_info_init): Don't set info->osabi.
4211         * osabi.c (gdb_osabi_names): Add "unknown" entry.
4212
4213 2018-04-07  Simon Marchi  <simon.marchi@ericsson.com>
4214
4215         * common/byte-vector.h (char_vector): New type.
4216         * target.h (target_read_alloc): Return
4217         gdb::optional<byte_vector>.
4218         (target_read_stralloc): Return gdb::optional<char_vector>.
4219         (target_get_osdata): Return gdb::optional<char_vector>.
4220         * target.c (target_read_alloc_1): Templatize.  Replacement
4221         manual memory management with vector.
4222         (target_read_alloc): Change return type, adjust.
4223         (target_read_stralloc): Change return type, adjust.
4224         (target_get_osdata): Change return type, adjust.
4225         * auxv.c (struct auxv_info) <length>: Remove.
4226         <data>: Change type to gdb::optional<byte_vector>.
4227         (auxv_inferior_data_cleanup): Free auxv_info with delete.
4228         (get_auxv_inferior_data): Allocate auxv_info with new, adjust.
4229         (target_auxv_search): Adjust.
4230         (fprint_target_auxv): Adjust.
4231         * avr-tdep.c (avr_io_reg_read_command): Adjust.
4232         * linux-tdep.c (linux_spu_make_corefile_notes): Adjust.
4233         (linux_make_corefile_notes): Adjust.
4234         * osdata.c (get_osdata): Adjust.
4235         * remote.c (remote_get_threads_with_qxfer): Adjust.
4236         (remote_memory_map): Adjust.
4237         (remote_traceframe_info): Adjust.
4238         (btrace_read_config): Adjust.
4239         (remote_read_btrace): Adjust.
4240         (remote_pid_to_exec_file): Adjust.
4241         * solib-aix.c (solib_aix_get_library_list): Adjust.
4242         * solib-dsbt.c (decode_loadmap): Don't free buf.
4243         (dsbt_get_initial_loadmaps): Adjust.
4244         * solib-svr4.c (svr4_current_sos_via_xfer_libraries): Adjust.
4245         * solib-target.c (solib_target_current_sos): Adjust.
4246         * tracepoint.c (sdata_make_value): Adjust.
4247         * xml-support.c (xinclude_start_include): Adjust.
4248         (xml_fetch_content_from_file): Adjust.
4249         * xml-support.h (xml_fetch_another): Change return type.
4250         (xml_fetch_content_from_file): Change return type.
4251         * xml-syscall.c (xml_init_syscalls_info): Adjust.
4252         * xml-tdesc.c (file_read_description_xml): Adjust.
4253         (fetch_available_features_from_target): Change return type.
4254         (target_fetch_description_xml): Adjust.
4255         (target_read_description_xml): Adjust.
4256
4257 2018-04-06  Tom Tromey  <tom@tromey.com>
4258
4259         * value.c (~value): Update.
4260         (struct value) <contents>: Now unique_xmalloc_ptr.
4261         (value_contents_bits_eq, allocate_value_contents)
4262         (value_contents_raw, value_contents_all_raw)
4263         (value_contents_for_printing, value_contents_for_printing_const)
4264         (set_value_enclosing_type): Update.
4265
4266 2018-04-06  Tom Tromey  <tom@tromey.com>
4267
4268         * value.c (range_s): Remove typedef, VEC.
4269         (struct range): Add operator<.
4270         (range_lessthan): Remove.
4271         (ranges_contain): Change type.
4272         (~value): Update.
4273         (struct value) <unavailable, optimized_out>: Now std::vector.
4274         (value_entirely_available)
4275         (value_entirely_covered_by_range_vector)
4276         (value_entirely_unavailable, value_entirely_optimized_out):
4277         Update.
4278         (insert_into_bit_range_vector): Change argument type.
4279         (find_first_range_overlap): Likewise.
4280         (struct ranges_and_idx, value_contents_bits_eq)
4281         (require_not_optimized_out, require_available): Update.
4282         (ranges_copy_adjusted): Change argument types.
4283         (value_optimized_out, value_copy, value_fetch_lazy): Update.
4284
4285 2018-04-06  Tom Tromey  <tom@tromey.com>
4286
4287         * value.c (~value): Update.
4288         (struct value) <parent>: Now a value_ref_ptr.
4289         (value_parent, set_value_parent, value_address, value_copy):
4290         Update.
4291
4292 2018-04-06  Tom Tromey  <tom@tromey.com>
4293
4294         * value.c (struct value): Add constructor, destructor, and member
4295         initializers.
4296         (allocate_value_lazy, value_decref): Update.
4297
4298 2018-04-06  Tom Tromey  <tom@tromey.com>
4299
4300         * value.c (struct value) <released, next>: Remove.
4301         (all_values): Now a std::vector.
4302         (allocate_value_lazy): Update.
4303         (value_next): Remove.
4304         (value_mark, value_free_to_mark, release_value)
4305         (value_release_to_mark): Update.
4306
4307 2018-04-06  Tom Tromey  <tom@tromey.com>
4308
4309         * value.h (fetch_subexp_value, value_release_to_mark): Update.
4310         (free_value_chain): Remove.
4311         * value.c (free_value_chain): Remove.
4312         (value_release_to_mark): Return a std::vector.
4313         * ppc-linux-nat.c (num_memory_accesses): Change "chain" to a
4314         std::vector.
4315         (check_condition): Update.
4316         * eval.c (fetch_subexp_value): Change "val_chain" to a
4317         std::vector.
4318         * breakpoint.c (update_watchpoint): Update.
4319         (can_use_hardware_watchpoint): Change "vals" to a std::vector.
4320
4321 2018-04-06  Tom Tromey  <tom@tromey.com>
4322
4323         * value.h (free_all_values): Remove.
4324         * value.c (free_all_values): Remove.
4325
4326 2018-04-06  Tom Tromey  <tom@tromey.com>
4327
4328         * value.c (VALUE_HISTORY_CHUNK, struct value_history_chunk)
4329         (value_history_chain, value_history_count): Remove.
4330         (value_history): New global.
4331         (record_latest_value, access_value_history, show_values)
4332         (preserve_values): Update.
4333
4334 2018-04-06  Tom Tromey  <tom@tromey.com>
4335
4336         * varobj.h (struct varobj) <value>: Now a value_ref_ptr.
4337         * varobj.c (varobj_set_display_format, varobj_set_value)
4338         (install_default_visualizer, construct_visualizer)
4339         (install_new_value, ~varobj, varobj_get_value_type)
4340         (my_value_of_variable, varobj_editable_p): Update.
4341         * c-varobj.c (c_describe_child, c_value_of_variable)
4342         (cplus_number_of_children, cplus_describe_child): Update.
4343         * ada-varobj.c (ada_number_of_children, ada_name_of_child)
4344         (ada_path_expr_of_child, ada_value_of_child, ada_type_of_child)
4345         (ada_value_of_variable, ada_value_is_changeable_p): Update.
4346
4347 2018-04-06  Tom Tromey  <tom@tromey.com>
4348
4349         * printcmd.c (last_examine_address): Change type to
4350         value_ref_ptr.
4351         (do_examine, x_command): Update.
4352
4353 2018-04-06  Tom Tromey  <tom@tromey.com>
4354
4355         * value.c (release_value): Update.
4356         * breakpoint.h (struct watchpoint) <val>: Now a value_ref_ptr.
4357         (struct bpstats) <val>: Now a value_ref_ptr.
4358         * breakpoint.c (update_watchpoint, breakpoint_init_inferior)
4359         (~bpstats, bpstats, bpstat_clear_actions, watchpoint_check)
4360         (~watchpoint, print_it_watchpoint, watch_command_1)
4361         (invalidate_bp_value_on_memory_change): Update.
4362
4363 2018-04-06  Tom Tromey  <tom@tromey.com>
4364
4365         * varobj.c (varobj_clear_saved_item)
4366         (update_dynamic_varobj_children, install_new_value, ~varobj):
4367         Update.
4368         * value.h (value_incref): Move declaration earlier.
4369         (value_decref): Rename from value_free.
4370         (struct value_ref_policy): New.
4371         (value_ref_ptr): New typedef.
4372         (struct value_deleter): Remove.
4373         (gdb_value_up): Remove typedef.
4374         (release_value): Change return type.
4375         (release_value_or_incref): Remove.
4376         * value.c (set_value_parent): Update.
4377         (value_incref): Change return type.
4378         (value_decref): Rename from value_free.
4379         (value_free_to_mark, free_all_values, free_value_chain): Update.
4380         (release_value): Return value_ref_ptr.
4381         (release_value_or_incref): Remove.
4382         (record_latest_value, set_internalvar, clear_internalvar):
4383         Update.
4384         * stack.c (info_frame_command): Don't call value_free.
4385         * python/py-value.c (valpy_dealloc, valpy_new)
4386         (value_to_value_object): Update.
4387         * printcmd.c (do_examine): Update.
4388         * opencl-lang.c (lval_func_free_closure): Update.
4389         * mi/mi-main.c (register_changed_p): Don't call value_free.
4390         * mep-tdep.c (mep_frame_prev_register): Don't call value_free.
4391         * m88k-tdep.c (m88k_frame_prev_register): Don't call value_free.
4392         * m68hc11-tdep.c (m68hc11_frame_prev_register): Don't call
4393         value_free.
4394         * guile/scm-value.c (vlscm_free_value_smob)
4395         (vlscm_scm_from_value): Update.
4396         * frame.c (frame_register_unwind, frame_unwind_register_signed)
4397         (frame_unwind_register_unsigned, get_frame_register_bytes)
4398         (put_frame_register_bytes): Don't call value_free.
4399         * findvar.c (address_from_register): Don't call value_free.
4400         * dwarf2read.c (dwarf2_compute_name): Don't call value_free.
4401         * dwarf2loc.c (entry_data_value_free_closure)
4402         (value_of_dwarf_reg_entry, free_pieced_value_closure)
4403         (dwarf2_evaluate_loc_desc_full): Update.
4404         * breakpoint.c (update_watchpoint, breakpoint_init_inferior)
4405         (~bpstats, bpstats, bpstat_clear_actions, watchpoint_check)
4406         (~watchpoint, watch_command_1)
4407         (invalidate_bp_value_on_memory_change): Update.
4408         * alpha-tdep.c (alpha_register_to_value): Don't call value_free.
4409
4410 2018-04-06  Simon Marchi  <simon.marchi@polymtl.ca>
4411
4412         PR gdb/23022
4413         * warning.m4: Add -Wno-error=deprecated-register.
4414         * configure: Re-generate.
4415
4416 2018-04-05  Tom Tromey  <tom@tromey.com>
4417
4418         * linespec.h: Remove include of "vec.h".
4419
4420 2018-04-05  Tom Tromey  <tom@tromey.com>
4421
4422         * linespec.c (typep): Remove typedef.
4423         (find_methods, find_superclass_methods): Take a std::vector.
4424         (find_method): Use std::vector.
4425
4426 2018-04-05  Tom Tromey  <tom@tromey.com>
4427
4428         * utils.c (compare_strings): Remove.
4429         * utils.h (compare_strings): Remove.
4430         * objc-lang.h (find_imps): Update.
4431         * objc-lang.c (find_methods): Take a std::vector.
4432         (uniquify_strings, find_imps): Likewise.
4433         * linespec.c (find_methods): Take a std::vector.
4434         (decode_objc): Use std::vector.
4435         (add_all_symbol_names_from_pspace, find_superclass_methods): Take
4436         a std::vector.
4437         (find_method, find_function_symbols): Use std::vector.
4438
4439 2018-04-05  Tom Tromey  <tom@tromey.com>
4440
4441         * completer.c (completion_tracker::completion_tracker): Remove
4442         cast.
4443         (completion_tracker::discard_completions): Likewise.
4444         * breakpoint.c (ambiguous_names_p): Remove cast.
4445         * ada-lang.c (_initialize_ada_language): Remove cast.
4446         * utils.h (streq): Update.
4447         (streq_hash): Add new declaration.
4448         * utils.c (streq): Return bool.
4449         (streq_hash): New function.
4450
4451 2018-04-05  Tom Tromey  <tom@tromey.com>
4452
4453         * linespec.c (event_location_to_sals) <case ADDRESS_LOCATION>:
4454         Remove a string copy.
4455
4456 2018-04-05  Tom Tromey  <tom@tromey.com>
4457
4458         * linespec.c (filter_results): Use std::vector.
4459         (decode_line_2, decode_line_full): Update.
4460
4461 2018-04-05  Tom Tromey  <tom@tromey.com>
4462
4463         * linespec.c (canonical_to_fullform): Return std::string.
4464         (filter_results): Update.
4465         (struct decode_line_2_item): Add constructor.
4466         <fullform, displayform>: Now std::string.
4467         (decode_line_2_compare_items): Now a std::sort comparator.
4468         (decode_line_2): Update.
4469
4470 2018-04-05  Tom Tromey  <tom@tromey.com>
4471
4472         * linespec.c (copy_token_string): Return a unique_xmalloc_ptr.
4473         (unexpected_linespec_error): Update.
4474         (linespec_parse_basic, parse_linespec): Update.
4475
4476 2018-04-05  Tom Tromey  <tom@tromey.com>
4477
4478         * linespec.c (linespec_parse_basic): Reindent.
4479
4480 2018-04-05  Tom Tromey  <tom@tromey.com>
4481
4482         * minsyms.h (iterate_over_minimal_symbols): Update.
4483         * minsyms.c (iterate_over_minimal_symbols): Take a
4484         gdb::function_view.
4485         * linespec.c (struct collect_minsyms): Remove.
4486         (compare_msyms): Now a std::sort comparator.
4487         (add_minsym): Add parameters.
4488         (search_minsyms_for_name): Update.  Use std::vector.
4489
4490 2018-04-03  Tom Tromey  <tom@tromey.com>
4491
4492         * mipsread.c (read_alphacoff_dynamic_symtab): Use
4493         gdb::byte_vector.
4494
4495 2018-04-02  Weimin Pan  <weimin.pan@oracle.com>
4496
4497         * MAINTAINERS (Write After Approval): Add Weimin Pan.
4498
4499 2018-04-02  Weimin Pan  <weimin.pan@oracle.com>
4500
4501         PR gdb/16959
4502         * cp-valprint.c: (cp_print_static_field) Fix infinite recursion when
4503         printing static type.
4504
4505 2018-04-01  Tom Tromey  <tom@tromey.com>
4506
4507         * rs6000-nat.c (rs6000_ptrace_ldinfo): Return a byte_vector.
4508         (rs6000_xfer_shared_libraries): Update.
4509
4510 2018-04-01  Simon Marchi  <simon.marchi@polymtl.ca>
4511
4512         * common/gdb_vecs.h (char_ptr): Remove.
4513         * tracepoint.c (encode_actions_1): Remove usage of char_ptr.
4514
4515 2018-03-30  Simon Marchi  <simon.marchi@polymtl.ca>
4516
4517         * guile/scm-utils.c (gdbscm_parse_function_args): Replace VEC
4518         with std::vector.
4519         * common/gdb_vecs.h (DEF_VEC_P (char_ptr)): Remove.
4520
4521 2018-03-30  Simon Marchi  <simon.marchi@polymtl.ca>
4522
4523         * tracepoint.h (struct uploaded_tp): Initialize fields.
4524         <actions, step_actions, cmd_strings>: Change type to
4525         std::vector<char *>.
4526         * tracepoint.c (get_uploaded_tp): Allocate with new.
4527         (free_uploaded_tps): Free with delete.
4528         (parse_tracepoint_definition): Adjust to std::vector change.
4529         * breakpoint.c (read_uploaded_action): Likewise.
4530         (create_tracepoint_from_upload): Likewise.
4531         * ctf.c (ctf_write_uploaded_tp): Likewise.
4532         (SET_ARRAY_FIELD): Likewise.
4533         * tracefile-tfile.c (tfile_write_uploaded_tp): Likewise.
4534
4535 2018-03-30  Tom Tromey  <tom@tromey.com>
4536
4537         * solib-svr4.c (lm_info_read): Use gdb::byte_vector.  Return
4538         std::unique_ptr.
4539         (svr4_keep_data_in_core): Update.
4540         (svr4_read_so_list): Update.
4541
4542 2018-03-30  Tom Tromey  <tom@tromey.com>
4543
4544         * windows-nat.c (handle_output_debug_string, handle_exception):
4545         Update.
4546         * target.h (target_read_string): Update.
4547         * target.c (target_read_string): Change "string" to
4548         unique_xmalloc_ptr.
4549         * solib-svr4.c (open_symbol_file_object, svr4_read_so_list):
4550         Update.
4551         * solib-frv.c (frv_current_sos): Update.
4552         * solib-dsbt.c (dsbt_current_sos): Update.
4553         * solib-darwin.c (darwin_current_sos): Update.
4554         * linux-thread-db.c (inferior_has_bug): Update.
4555         * expprint.c (print_subexp_standard) <case OP_OBJC_MSGCALL>:
4556         Update.  Remove alloca.
4557         * ada-lang.c (ada_main_name): Update.
4558
4559 2018-03-30  Tom Tromey  <tom@tromey.com>
4560
4561         * dwarf2read.c (struct free_dwo_file_cleanup_data): Remove.
4562         (struct dwo_file_deleter): New.
4563         (dwo_file_up): New typedef.
4564         (open_and_init_dwo_file): Use dwo_file_up.
4565         (free_dwo_file_cleanup): Remove.
4566
4567 2018-03-30  Tom Tromey  <tom@tromey.com>
4568
4569         * dwarf2read.c (free_dwo_file): Remove "objfile" parameter.
4570         (free_dwo_file_cleanup, free_dwo_file_from_slot): Update.
4571
4572 2018-03-30  Tom Tromey  <tom@tromey.com>
4573
4574         * dwarf2read.c (class free_cached_comp_units): New class.
4575         (dw2_instantiate_symtab, dwarf2_build_psymtabs_hard): Use it.
4576         (free_cached_comp_units): Remove function.
4577
4578 2018-03-30  Tom Tromey  <tom@tromey.com>
4579
4580         * utils.h (make_cleanup_unpush_target): Remove.
4581         * inf-ptrace.c (struct target_unpusher): New.
4582         (target_unpush_up) New typedef.
4583         (inf_ptrace_create_inferior, inf_ptrace_attach): Use
4584         target_unpush_up.
4585         * utils.c (do_unpush_target, make_cleanup_unpush_target): Remove.
4586
4587 2018-03-27  Tom Tromey  <tom@tromey.com>
4588
4589         * utils.c (prompt_for_continue): Use unique_xmalloc_ptr.
4590
4591 2018-03-27  Pedro Alves  <palves@redhat.com>
4592             Tom Tromey  <tom@tromey.com>
4593
4594         * top.c (class gdb_readline_wrapper_cleanup): Add constructor,
4595         destructor.  Now a class.
4596         (gdb_readline_wrapper_cleanup): Remove function.
4597         (gdb_readline_wrapper): Remove cleanups.
4598
4599 2018-03-27  Tom Tromey  <tom@tromey.com>
4600
4601         * typeprint.h (struct type_print_options) <local_typedefs,
4602         global_typedefs>: Remove "struct" keyword.
4603         (class typedef_hash_table): New class.
4604         (recursively_update_typedef_hash, add_template_parameters)
4605         (create_typedef_hash, free_typedef_hash, copy_typedef_hash)
4606         (find_typedef_in_hash): Don't declare.
4607         * typeprint.c (struct typedef_hash_table): Move to typeprint.h.
4608         (typedef_hash_table::recursively_update): Rename from
4609         recursively_update_typedef_hash.  Now a member.
4610         (typedef_hash_table::add_template_parameters): Rename from
4611         add_template_parameters.  Now a member.
4612         (typedef_hash_table::typedef_hash_table): Now a constructor;
4613         rename from create_typedef_hash.
4614         (typedef_hash_table::~typedef_hash_table): Now a destructor;
4615         rename from free_typedef_hash.
4616         (do_free_typedef_hash, make_cleanup_free_typedef_hash)
4617         (do_free_global_table): Remove.
4618         (typedef_hash_table::typedef_hash_table): New constructor; renamed
4619         from copy_type_recursive.
4620         (create_global_typedef_table): Remove.
4621         (typedef_hash_table::find_global_typedef): Now a member of
4622         typedef_hash_table.
4623         (typedef_hash_table::find_typedef): Rename from
4624         find_typedef_in_hash; now a member.
4625         (whatis_exp): Update.
4626         * extension.h (struct ext_lang_type_printers): Add constructor and
4627         destructor.
4628         (start_ext_lang_type_printers, free_ext_lang_type_printers): Don't
4629         declare.
4630         * extension.c (ext_lang_type_printers::ext_lang_type_printers):
4631         Now a constructor; rename from start_ext_lang_type_printers.
4632         (ext_lang_type_printers): Now a destructor; rename from
4633         free_ext_lang_type_printers.
4634         * c-typeprint.c (find_typedef_for_canonicalize, c_print_type_1):
4635         Update.
4636         (c_type_print_base_struct_union): Update.  Remove cleanups.
4637
4638 2018-03-27  Tom Tromey  <tom@tromey.com>
4639
4640         * dwarf-index-write.c: Include <cmath>.
4641
4642 2018-03-27  Joel Brobecker  <brobecker@adacore.com>
4643
4644         * NEWS: Add entry describing new "set|show varsize-limit" command.
4645         * ada-lang.c (_initialize_ada_language): Add "set/show varsize-limit"
4646         command.
4647         * printcmd.c (_initialize_printcmd): Add "set var" alias of
4648         "set variable".
4649
4650 2018-03-27  Simon Marchi  <simon.marchi@ericsson.com>
4651
4652         * Makefile.in (COMMON_SFILES): Add dwarf-index-common.c and
4653         dwarf-index-write.c
4654         (HFILES_NO_SRCDIR): Add dwarf-index-common.h and dwarf2read.h.
4655         * dwarf-index-common.c: New file.
4656         * dwarf-index-common.h: New file.
4657         * dwarf-index-write.c: New file.
4658         * dwarf2read.c: Include dwarf2read.h and dwarf-index-common.h.
4659         (struct dwarf2_section_info): Move from here.
4660         (dwarf2_section_info_def): Likewise.
4661         (DEF_VEC_O (dwarf2_section_info_def)): Likewise.
4662         (offset_type): Likewise.
4663         (DW2_GDB_INDEX_SYMBOL_STATIC_SET_VALUE): Likewise.
4664         (DW2_GDB_INDEX_SYMBOL_KIND_SET_VALUE): Likewise.
4665         (DW2_GDB_INDEX_CU_SET_VALUE): Likewise.
4666         (byte_swap): Likewise.
4667         (MAYBE_SWAP): Likewise.
4668         (dwarf2_per_cu_ptr): Likewise.
4669         (DEF_VEC_P (dwarf2_per_cu_ptr)): Likewise.
4670         (struct tu_stats): Likewise.
4671         (struct dwarf2_per_objfile): Likewise.
4672         (struct dwarf2_per_cu_data): Likewise.
4673         (struct signatured_type): Likewise.
4674         (sig_type_ptr): Likewise.
4675         (DEF_VEC_P (sig_type_ptr)): Likewise.
4676         (INDEX4_SUFFIX): Likewise.
4677         (INDEX5_SUFFIX): Likewise.
4678         (DEBUG_STR_SUFFIX): Likewise.
4679         (dwarf2_read_section): Make non-static.
4680         (mapped_index_string_hash): Move from here.
4681         (dwarf5_djb_hash): Likewise.
4682         (file_write): Likewise.
4683         (class data_buf): Likewise.
4684         (struct symtab_index_entry): Likewise.
4685         (struct mapped_symtab): Likewise.
4686         (find_slot): Likewise.
4687         (hash_expand): Likewise.
4688         (add_index_entry): Likewise.
4689         (uniquify_cu_indices): Likewise.
4690         (class c_str_view): Likewise.
4691         (class c_str_view_hasher): Likewise.
4692         (class vector_hasher): Likewise.
4693         (write_hash_table): Likewise.
4694         (psym_index_map): Likewise.
4695         (struct addrmap_index_data): Likewise.
4696         (add_address_entry): Likewise.
4697         (add_address_entry_worker): Likewise.
4698         (write_address_map): Likewise.
4699         (symbol_kind): Likewise.
4700         (write_psymbols): Likewise.
4701         (struct signatured_type_index_data): Likewise.
4702         (write_one_signatured_type): Likewise.
4703         (recursively_count_psymbols): Likewise.
4704         (recursively_write_psymbols): Likewise.
4705         (class debug_names): Likewise.
4706         (check_dwarf64_offsets): Likewise.
4707         (psyms_seen_size): Likewise.
4708         (write_gdbindex): Likewise.
4709         (write_debug_names): Likewise.
4710         (assert_file_size): Likewise.
4711         (write_psymtabs_to_index): Likewise.
4712         (save_gdb_index_command): Likewise.
4713         (_initialize_dwarf2_read): Don't register the "save gdb-index"
4714         command.
4715         * dwarf2read.h: New file.
4716
4717 2018-03-27  Joel Brobecker  <brobecker@adacore.com>
4718
4719         PR gdb/22670
4720         * dwarf2read.c (dwarf2_physname): Do not return the demangled
4721         symbol name if the CU's language stores symbol names in linkage
4722         format.
4723         * language.h (struct language_defn)
4724         <la_store_sym_names_in_linkage_form_p>: New field.  Adjust
4725         all instances of this struct.
4726
4727 2018-03-26  Tom Tromey  <tom@tromey.com>
4728
4729         * stack.c (backtrace_command_1): Remove verbose code.
4730
4731 2018-03-26  Tom Tromey  <tom@tromey.com>
4732
4733         * python/py-framefilter.c (py_print_type): Don't catch
4734         exceptions.  Return void.
4735         (py_print_value): Likewise.
4736         (py_print_single_arg): Likewise.
4737         (enumerate_args): Don't catch exceptions.
4738         (py_print_args): Likewise.
4739         (py_print_frame): Likewise.
4740         (gdbpy_apply_frame_filter): Catch exceptions here.
4741
4742 2018-03-26  Tom Tromey  <tom@tromey.com>
4743
4744         * stack.c (_initialize_stack): Remove trailing newlines from help
4745         text.  Add "Usage" line to "backtrace" help.
4746
4747 2018-03-26  Tom Tromey  <tom@tromey.com>
4748
4749         PR python/16486:
4750         * python/py-framefilter.c (py_print_args): Call wrap_hint.
4751
4752 2018-03-26  Tom Tromey  <tom@tromey.com>
4753
4754         * python/py-framefilter.c (py_print_single_arg): Return
4755         EXT_LANG_BT_ERROR from catch.
4756
4757 2018-03-26  Tom Tromey  <tom@tromey.com>
4758
4759         PR backtrace/15584:
4760         * stack.c (backtrace_command_1): Move some code into no-filters
4761         "if".
4762
4763 2018-03-26  Tom Tromey  <tom@tromey.com>
4764
4765         * python/py-framefilter.c (throw_quit_or_print_exception): New
4766         function.
4767         (gdbpy_apply_frame_filter): Use it.
4768
4769 2018-03-26  Tom Tromey  <tom@tromey.com>
4770
4771         PR cli/17716:
4772         * python/py-framefilter.c (py_print_type, py_print_value)
4773         (enumerate_args, py_print_args, gdbpy_apply_frame_filter): Use
4774         RETURN_MASK_ERROR.
4775
4776 2018-03-26  Tom Tromey  <tom@tromey.com>
4777
4778         * python/py-framefilter.c (enumerate_args): Use
4779         gdb::unique_xmalloc_ptr.
4780
4781 2018-03-26  Tom Tromey  <tom@tromey.com>
4782
4783         * python/py-framefilter.c (py_print_frame): Return
4784         EXT_LANG_BT_OK.
4785         (gdbpy_apply_frame_filter): Update comment.
4786         * extension.h (enum ext_lang_bt_status) <EXT_LANG_BT_COMPLETED>:
4787         Remove.
4788         <EXT_LANG_BT_NO_FILTERS>: Change value.
4789
4790 2018-03-26  Tom Tromey  <tom@tromey.com>
4791
4792         PR backtrace/15582:
4793         * stack.c (backtrace_command): Parse "hide" argument.
4794         * python/py-framefilter.c (py_print_frame): Handle PRINT_HIDE.
4795         * extension.h (enum frame_filter_flags) <PRINT_HIDE>: New
4796         constant.
4797
4798 2018-03-26  Tom Tromey  <tom@tromey.com>
4799
4800         * stack.c (backtrace_command_1): Remove "show_locals" parameter,
4801         add "flags".
4802         (backtrace_command): Remove "fulltrace", add "flags".
4803
4804 2018-03-26  Tom Tromey  <tom@tromey.com>
4805
4806         * stack.c (backtrace_command): Rewrite command line parsing.
4807
4808 2018-03-26  Simon Marchi  <simon.marchi@ericsson.com>
4809
4810         * dwarf2read.c (DEF_VEC_I(offset_type)): Remove.
4811
4812 2018-03-26  Simon Marchi  <simon.marchi@ericsson.com>
4813
4814         * filename-seen-cache.h: Add include guard.
4815
4816 2018-03-26  Keith Seitz  <keiths@redhat.com>
4817
4818         * symfile.c (place_section): Remove "struct" from section_addr_info
4819         in comment.
4820         * windows-nat.c (struct safe_symbol_file_add_args) <addrs>: Remove
4821         "struct" keyword from section_addr_info.
4822
4823 2018-03-26  Alan Hayward  <alan.hayward@arm.com>
4824
4825         * regformats/regdef.h (reg): Add constructors.
4826
4827 2018-03-25  Pedro Alves  <palves@redhat.com>
4828
4829         * eval.c (evaluate_funcall): Swap OP_VAR_MSYM_VALUE/OP_VAR_VALUE
4830         if then/else bodies in var_func_name extraction.
4831
4832 2018-03-23  Weimin Pan  <weimin.pan@oracle.com>
4833
4834         * minsyms.c (lookup_minimal_symbol_and_objfile): Use
4835         lookup_minimal_symbol() to find symbol entry.
4836         * minsyms.h (lookup_minimal_symbol_and_objfile): Update comment.
4837
4838 2018-03-23  Keith Seitz  <keiths@redhat.com>
4839
4840         PR c++/22968
4841         * dwarf2read.c (scan_partial_symbols): Scan structs/classes for
4842         nested type definitions for C++, too.
4843
4844 2018-03-23  Tom Tromey  <tom@tromey.com>
4845
4846         * machoread.c (struct oso_el): Add a constructor.  Don't define as
4847         a typedef.
4848         (macho_register_oso): Remove.
4849         (macho_symtab_read): Take a std::vector.
4850         (oso_el_compare_name): Now a std::sort comparator.
4851         (macho_symfile_read_all_oso): Take a std::vector.
4852         (macho_symfile_read): Use std::vector.  Remove cleanups.
4853
4854 2018-03-22  Tom Tromey  <tom@tromey.com>
4855
4856         * record-full.c (record_full_exec_insn): Use gdb::byte_vector.
4857         (record_full_goto_bookmark): Use std::string.
4858
4859 2018-03-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
4860
4861         PR tdep/18295
4862         * rs6000-tdep.c (skip_prologue): Match both stwux and stdux
4863         a single mask.
4864
4865 2018-03-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
4866
4867         * rs6000-tdep.c (store_insn_p): New function.
4868         (skip_prologue): New variable alloca_reg_offset. Set lr_reg
4869         and cr_reg to their unshifted values. Use store_insn_p to
4870         match LR saves using either R1 or fdata->alloca_reg. Use
4871         store_insn_p to match CR saves. Set alloca_reg_offset
4872         when alloca_reg and framep are set. Remove lr_reg shift
4873         when assigning to fdata->lr_register.
4874
4875 2018-03-22  Andreas Arnez  <arnez@linux.vnet.ibm.com>
4876
4877         * linux-tdep.c (linux_info_proc): For "info proc cmdline", print
4878         command line args instead of emitting a warning.
4879
4880 2018-03-22  Simon Marchi  <simon.marchi@polymtl.ca>
4881
4882         * tracepoint.h (struct static_tracepoint_marker): Initialize
4883         fields, define default constructor, move constructor and move
4884         assignment, disable the rest.
4885         <str_id, extra>: Make std::string.
4886         (release_static_tracepoint_marker): Remove.
4887         (free_current_marker): Remove.
4888         * tracepoint.c (free_current_marker): Remove.
4889         (parse_static_tracepoint_marker_definition): Adjust to
4890         std::string, use new hex2str overload.
4891         (release_static_tracepoint_marker): Remove.
4892         (print_one_static_tracepoint_marker): Get marker by reference
4893         and adjust to std::string.
4894         (info_static_tracepoint_markers_command): Adjust to std::vector
4895         changes
4896         * target.h (static_tracepoint_marker_p): Remove typedef.
4897         (DEF_VEC_P(static_tracepoint_marker_p)): Remove.
4898         (struct target_ops) <to_static_tracepoint_marker_at>: Return
4899         bool.
4900         <to_static_tracepoint_markers_by_strid>: Return std::vector.
4901         * target-debug.h
4902         (target_debug_print_VEC_static_tracepoint_marker_p_p): Remove.
4903         (target_debug_print_std_vector_static_tracepoint_marker): New.
4904         (target_debug_print_struct_static_tracepoint_marker_p): Rename
4905         to...
4906         (target_debug_print_static_tracepoint_marker_p): ... this.
4907         * target-delegates.c: Re-generate.
4908         * breakpoint.h (struct tracepoint) <static_trace_marker_id>:
4909         Make std::string.
4910         * breakpoint.c (init_breakpoint_sal): Adjust to std::string.
4911         (decode_static_tracepoint_spec): Adjust to std::vector.
4912         (tracepoint_print_one_detail): Adjust to std::string.
4913         (strace_marker_decode_location): Adjust to std::string.
4914         (update_static_tracepoint): Adjust to std::string, remove call
4915         to release_static_tracepoint_marker.
4916         * linux-nat.c (linux_child_static_tracepoint_markers_by_strid):
4917         Adjust to std::vector.
4918         * remote.c (remote_static_tracepoint_marker_at): Return bool.
4919         (remote_static_tracepoint_markers_by_strid): Adjust to
4920         std::vector.
4921         * common/rsp-low.h (hex2str): New overload with explicit count
4922         of bytes.
4923         * common/rsp-low.c (hex2str): New overload with explicit count
4924         of bytes.
4925         * unittests/rsp-low-selftests.c (test_hex2str): New function.
4926         (_initialize_rsp_low_selftests): Add test_hex2str test.
4927         * unittests/tracepoint-selftests.c
4928         (test_parse_static_tracepoint_marker_definition): Adjust to
4929         std::string.
4930
4931 2018-03-22  Simon Marchi  <simon.marchi@polymtl.ca>
4932
4933         * tracepoint.c (parse_static_tracepoint_marker_definition):
4934         Consider case where the definition is followed by more
4935         definitions.
4936         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4937         tracepoint-selftests.c.
4938         * unittests/tracepoint-selftests.c: New.
4939
4940 2018-03-21  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
4941
4942         * MAINTAINERS (Write After Approval): Add Pedro Franco de
4943         Carvalho.
4944
4945 2018-03-20  Stephen Roberts  <stephen.roberts@arm.com>
4946
4947         * symtab.c (find_pc_sect_line): fixed indentation.
4948
4949 2018-03-20  Stephen Roberts  <stephen.roberts@arm.com>
4950
4951         * symtab.c (find_pc_sect_line): now uses binary search.
4952
4953 2018-03-19  Tom Tromey  <tom@tromey.com>
4954
4955         * rust-exp.y (struct_expr_tail, struct_expr_list): Add plain
4956         "IDENT" production.
4957
4958 2018-03-19  Pedro Alves  <palves@redhat.com>
4959             Tom Tromey  <tom@tromey.com>
4960
4961         * unittests/observable-selftests.c: New file.
4962         * common/observable.h: New file.
4963         * observable.h: New file.
4964         * ada-lang.c, ada-tasks.c, agent.c, aix-thread.c, annotate.c,
4965         arm-tdep.c, auto-load.c, auxv.c, break-catch-syscall.c,
4966         breakpoint.c, bsd-uthread.c, cli/cli-interp.c, cli/cli-setshow.c,
4967         corefile.c, dummy-frame.c, event-loop.c, event-top.c, exec.c,
4968         extension.c, frame.c, gdbarch.c, guile/scm-breakpoint.c,
4969         infcall.c, infcmd.c, inferior.c, inflow.c, infrun.c, jit.c,
4970         linux-tdep.c, linux-thread-db.c, m68klinux-tdep.c,
4971         mi/mi-cmd-break.c, mi/mi-interp.c, mi/mi-main.c, objfiles.c,
4972         ppc-linux-nat.c, ppc-linux-tdep.c, printcmd.c, procfs.c,
4973         python/py-breakpoint.c, python/py-finishbreakpoint.c,
4974         python/py-inferior.c, python/py-unwind.c, ravenscar-thread.c,
4975         record-btrace.c, record-full.c, record.c, regcache.c, remote.c,
4976         riscv-tdep.c, sol-thread.c, solib-aix.c, solib-spu.c, solib.c,
4977         spu-multiarch.c, spu-tdep.c, stack.c, symfile-mem.c, symfile.c,
4978         symtab.c, thread.c, top.c, tracepoint.c, tui/tui-hooks.c,
4979         tui/tui-interp.c, valops.c: Update all users.
4980         * tui/tui-hooks.c (tui_bp_created_observer)
4981         (tui_bp_deleted_observer, tui_bp_modified_observer)
4982         (tui_inferior_exit_observer, tui_before_prompt_observer)
4983         (tui_normal_stop_observer, tui_register_changed_observer):
4984         Remove.
4985         (tui_observers_token): New global.
4986         (attach_or_detach, tui_attach_detach_observers): New functions.
4987         (tui_install_hooks, tui_remove_hooks): Use
4988         tui_attach_detach_observers.
4989         * record-btrace.c (record_btrace_thread_observer): Remove.
4990         (record_btrace_thread_observer_token): New global.
4991         * observer.sh: Remove.
4992         * observer.c: Rename to observable.c.
4993         * observable.c (namespace gdb_observers): Define new objects.
4994         (observer_debug): Move into gdb_observers namespace.
4995         (struct observer, struct observer_list, xalloc_observer_list_node)
4996         (xfree_observer_list_node, generic_observer_attach)
4997         (generic_observer_detach, generic_observer_notify): Remove.
4998         (_initialize_observer): Update.
4999         Don't include observer.inc.
5000         * Makefile.in (generated_files): Remove observer.h, observer.inc.
5001         (clean mostlyclean): Likewise.
5002         (observer.h, observer.inc): Remove targets.
5003         (SUBDIR_UNITTESTS_SRCS): Add observable-selftests.c.
5004         (COMMON_SFILES): Use observable.c, not observer.c.
5005         * .gitignore: Remove observer.h.
5006
5007 2018-03-18  Tom Tromey  <tom@tromey.com>
5008
5009         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Use
5010         gdb::def_vector.
5011         (bfd_lookup_symbol_from_dyn_symtab): Likewise.
5012
5013 2018-03-17  Tom Tromey  <tom@tromey.com>
5014
5015         * auto-load.c (auto_load_objfile_script_1): Use std::string.
5016
5017 2018-03-17  Tom Tromey  <tom@tromey.com>
5018
5019         * target.c (class scoped_target_fd): New.
5020         (target_fileio_close_cleanup): Remove.
5021         (target_fileio_read_alloc_1): Use scoped_target_fd.
5022
5023 2018-03-16  Simon Marchi  <simon.marchi@polymtl.ca>
5024
5025         * silent-rules.mk: New.
5026         * Makefile.in: Include silent-rules.mk
5027         (srcdir, VPATH, top_srcdir): Move up.
5028         (COMPILE): Add ECHO_CXX.
5029         (test-cp-name-parser$(EXEEXT)): Add ECHO_CXXLD.
5030         (init.c): Add ECHO_INIT_C.
5031         (gdb$(EXEEXT)): Add SILENCE and ECHO_CXXLD.
5032         (version.c): Add ECHO_GEN.
5033         (printcmd.o): Add ECHO_CXX.
5034         (target-float.o): Add ECHO_CXX.
5035         (ada-exp.o): Add ECHO_CXX.
5036         (stamp-xml): Add SILENCE and ECHO_GEN_XML_BUILTIN.
5037         (insight$(EXEEXT)): Add ECHO_CXXLD.
5038         * gnulib/configure.ac: Add AM_SILENT_RULES.
5039         * gnulib/aclocal.m4: Re-generate.
5040         * gnulib/configure: Re-generate.
5041         * gnulib/import/Makefile.in: Re-generate.
5042
5043 2018-03-16  Tom Tromey  <tom@tromey.com>
5044
5045         * xcoffread.c (xcoff_symfile_offsets): Change type of "addrs".
5046         * utils.h (make_cleanup_free_section_addr_info): Don't declare.
5047         * utils.c (do_free_section_addr_info)
5048         (make_cleanup_free_section_addr_info): Remove.
5049         * symfile.h (struct other_sections): Add constructor.
5050         (struct section_addr_info): Remove.
5051         (section_addr_info): New typedef.
5052         (struct sym_fns) <sym_offsets>: Change type of parameter.
5053         (build_section_addr_info_from_objfile)
5054         (relative_addr_info_to_section_offsets, addr_info_make_relative)
5055         (default_symfile_offsets, symbol_file_add)
5056         (symbol_file_add_from_bfd)
5057         (build_section_addr_info_from_section_table): Update.
5058         (alloc_section_addr_info, free_section_addr_info): Don't declare.
5059         * symfile.c (alloc_section_addr_info): Remove.
5060         (build_section_addr_info_from_section_table): Change return type.
5061         Update.
5062         (build_section_addr_info_from_bfd)
5063         (build_section_addr_info_from_objfile): Likewise.
5064         (free_section_addr_info): Remove.
5065         (relative_addr_info_to_section_offsets): Change type of "addrs".
5066         (addrs_section_compar): Now a std::sort comparator.
5067         (addrs_section_sort): Change return type.
5068         (addr_info_make_relative): Change type of "addrs".  Update.
5069         (default_symfile_offsets, syms_from_objfile_1)
5070         (syms_from_objfile, symbol_file_add_with_addrs): Likewise.
5071         (symbol_file_add_separate): Update.
5072         (symbol_file_add): Change type of "addrs".  Update.
5073         (add_symbol_file_command): Update.  Remove cleanups.
5074         * symfile-mem.c (symbol_file_add_from_memory): Update.  Remove
5075         cleanups.
5076         * symfile-debug.c (debug_sym_offsets): Change type of "info".
5077         * solib.c (solib_read_symbols): Update.
5078         * objfiles.c (objfile_relocate): Update.  Remove cleanups.
5079         * machoread.c (macho_symfile_offsets): Update.
5080         * jit.c (jit_bfd_try_read_symtab): Update.
5081
5082 2018-03-15  Simon Marchi  <simon.marchi@polymtl.ca>
5083
5084         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5085         unittests/utils-selftests.c.
5086         * unittests/utils-selftests.c: New file.
5087
5088 2018-03-14  Tom Tromey  <tom@tromey.com>
5089
5090         PR cli/14977:
5091         * printcmd.c (printf_c_string, printf_wide_c_string): Special case
5092         for NULL.
5093
5094 2018-03-14  Tom Tromey  <tom@tromey.com>
5095
5096         PR cli/19918:
5097         * printcmd.c (printf_pointer): Allow "-" in format.
5098
5099 2018-03-14  Tom Tromey  <tom@tromey.com>
5100
5101         * printcmd.c (_initialize_printcmd): Add usage to printf.
5102
5103 2018-03-14  Yao Qi  <qiyao@sourceware.org>
5104
5105         * MAINTAINERS: Update my email address.
5106
5107 2018-03-13  Tom Tromey  <tom@tromey.com>
5108
5109         * machoread.c (macho_check_dsym): Change filenamep to a
5110         std::string*.
5111         (macho_symfile_read): Update.
5112         * symfile.c (load_command): Use std::string.
5113
5114 2018-03-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5115
5116         * riscv-tdep.c (riscv_sw_breakpoint_from_kind): Add localization
5117         to error message string.
5118         (riscv_register_name): Use xsnprintf instead of sprintf.
5119         (riscv_insn::fetch_instruction): Use gdb_assert instead of
5120         internal_error.
5121         (riscv_print_arg_location): Use gdb_assert_not_reached instead of
5122         error.
5123         (riscv_push_dummy_call): Likewise.
5124
5125 2018-03-12  Tom Tromey  <tom@tromey.com>
5126
5127         * rs6000-aix-tdep.c (rs6000_aix_core_xfer_shared_libraries_aix):
5128         Use gdb::byte_vector.
5129         * arm-tdep.c (arm_exidx_new_objfile): Use gdb::byte_vector.
5130
5131 2018-03-12  Yao Qi  <yao.qi@linaro.org>
5132
5133         * ia64-libunwind-tdep.c (libunwind_get_reg_special): Change
5134         parameter type to readable_regcache.
5135         * ia64-libunwind-tdep.h (libunwind_get_reg_special): Update
5136         the declaration.
5137
5138 2018-03-11  Tom Tromey  <tom@tromey.com>
5139
5140         * dwarf2read.c (struct nextfield): Add initializers.
5141         (struct nextfnfield): Remove.
5142         (struct fnfieldlist): Add initializers.  Remove "length" and
5143         "head", use std::vector.
5144         (struct decl_field_list): Remove.
5145         (struct field_info): Add initializers.
5146         <fields, baseclasses>: Now std::vector.
5147         <nbaseclasses, nfnfields, typedef_field_list_count,
5148         nested_types_list_count>: Remove.
5149         (dwarf2_add_field, dwarf2_add_type_defn)
5150         (dwarf2_attach_fields_to_type, dwarf2_add_member_fn)
5151         (dwarf2_attach_fn_fields_to_type, handle_struct_member_die)
5152         (process_structure_scope): Update.
5153
5154 2018-03-11  Tom Tromey  <tom@tromey.com>
5155
5156         * dwarf2read.c (sort_tu_by_abbrev_offset): Change to be suitable
5157         for use by std::sort.
5158         (build_type_psymtabs_1): Use std::vector.
5159
5160 2018-03-09  Eli Zaretskii  <eliz@gnu.org>
5161
5162         * top.c (print_gdb_configuration): Reflect LIBIPT, LIBMEMCHECK,
5163         and LIBMPFR in the printed configuration.
5164
5165 2018-03-08  Tom Tromey  <tom@tromey.com>
5166
5167         * source.c (get_filename_and_charpos): Use scoped_fd.
5168         * nto-procfs.c (procfs_open_1): Use scoped_fd.
5169         (procfs_pidlist): Likewise.
5170         * procfs.c (proc_get_LDT_entry): Use scoped_fd.
5171         (iterate_over_mappings): Likewise.
5172
5173 2018-03-08  Tom Tromey  <tom@tromey.com>
5174
5175         * infcall.c (struct call_return_meta_info)
5176         <stack_temporaries_enabled>: Remove.
5177         (get_call_return_value, call_function_by_hand_dummy): Update.
5178         * thread.c (disable_thread_stack_temporaries): Remove.
5179         (enable_thread_stack_temporaries): Remove.
5180         (thread_stack_temporaries_enabled_p): Return bool.
5181         (push_thread_stack_temporary, value_in_thread_stack_temporaries)
5182         (get_last_thread_stack_temporary): Update.
5183         * eval.c (evaluate_subexp): Update.
5184         * gdbthread.h (class enable_thread_stack_temporaries): Now a
5185         class, not a function.
5186         (value_ptr, value_vec): Remove typedefs.
5187         (class thread_info) <stack_temporaries_enabled>: Now bool.
5188         <stack_temporaries>: Now a std::vector.
5189         (thread_stack_temporaries_enabled_p)
5190         (value_in_thread_stack_temporaries): Return bool.
5191
5192 2018-03-08  Simon Marchi  <simon.marchi@ericsson.com>
5193
5194         * remote.c (putpkt_binary): Fix omitted bytes reporting.
5195         (getpkt_or_notif_sane_1): Likewise.
5196
5197 2018-03-08  Simon Marchi  <simon.marchi@polymtl.ca>
5198
5199         * build-id.c (build_id_to_debug_bfd): Use std::string.
5200
5201 2018-03-08  Simon Marchi  <simon.marchi@polymtl.ca>
5202
5203         * build-id.c (find_separate_debug_file_by_buildid): Return
5204         std::string.
5205         * build-id.h (find_separate_debug_file_by_buildid): Return
5206         std::string.
5207         * coffread.c (coff_symfile_read): Adjust to std::string.
5208         * elfread.c (elf_symfile_read): Adjust to std::string.
5209         * symfile.c (separate_debug_file_exists): Change parameter to
5210         std::string.
5211         (find_separate_debug_file): Return std::string.
5212         (find_separate_debug_file_by_debuglink): Return std::string.
5213         * symfile.h (find_separate_debug_file_by_debuglink): Return
5214         std::string.
5215
5216 2018-03-08  Simon Marchi  <simon.marchi@polymtl.ca>
5217
5218         * common/xml-utils.c (xml_escape_text): Move code to...
5219         (xml_escape_text_append): ... this new function.
5220         * common/xml-utils.h (xml_escape_text_append): New declaration.
5221         * unittests/xml-utils-selftests.c (test_xml_escape_text_append):
5222         New function.
5223         (_initialize_xml_utils): register test_xml_escape_text_append as
5224         a selftest.
5225
5226 2018-03-07  Alan Hayward  <alan.hayward@arm.com>
5227
5228         * defs.h: Remove MAX_REGISTER_SIZE.
5229         * regcache.c (init_regcache_descr): Remove MAX_REGISTER_SIZE
5230         asserts.
5231         * python/py-unwind.c (pyuw_sniffer): Likewise.
5232
5233 2018-03-07  Tom Tromey  <tom@tromey.com>
5234
5235         * linux-tdep.c (linux_info_proc): Update.
5236         * target.h (struct target_ops) <to_fileio_readlink>: Return
5237         optional<string>.
5238         (target_fileio_readlink): Return optional<string>.
5239         * remote.c (remote_hostio_readlink): Return optional<string>.
5240         * inf-child.c (inf_child_fileio_readlink): Return
5241         optional<string>.
5242         * target.c (target_fileio_readlink): Return optional<string>.
5243
5244 2018-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
5245
5246         * regcache.c (cooked_read_test): Add riscv to the list of
5247         architectures that have a save_reggroup.
5248
5249 2018-03-07  Andreas Arnez  <arnez@linux.vnet.ibm.com>
5250
5251         * gnu-v3-abi.c (gnuv3_rtti_type): Add early exit if the given
5252         value is not a dynamic class object.
5253
5254 2018-03-06  Tom Tromey  <tom@tromey.com>
5255
5256         * rust-exp.y: Formatting fixes.
5257
5258 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5259
5260         * riscv-tdep.c (riscv_register_name): Remove target description
5261         support.
5262         (riscv_gdbarch_init): Remove target description check.
5263
5264 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5265
5266         * riscv-tdep.c: Remove 'Contributed by ...' lines from header
5267         comment.
5268         * riscv-tdep.h: Likewise.
5269
5270 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5271
5272         * riscv-tdep.c (riscv_pseudo_register_read): Delete.
5273         (riscv_pseudo_register_write): Delete.
5274         (riscv_gdbarch_init): Remove all use of pseudo registers.
5275
5276 2018-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
5277
5278         * record-btrace.c (btrace_print_lines): Replace cleanup
5279         parameter with RAII equivalents.
5280         (btrace_insn_history): Replace cleanup with RAII equivalents.
5281         * ui-out.h (make_cleanup_ui_out_list_begin_end,
5282         make_cleanup_ui_out_tuple_begin_end): Remove.
5283         * ui-out.c (struct ui_out_end_cleanup_data, do_cleanup_end,
5284         make_cleanup_ui_out_end, make_cleanup_ui_out_tuple_begin_end,
5285         make_cleanup_ui_out_list_begin_end): Remove.
5286
5287 2018-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
5288
5289         * record-btrace.c (record_btrace_maybe_mark_async_event): Change
5290         parameter types to std::vector.  Use bool.
5291         (record_btrace_wait): Replace VEC(tp_t) with
5292         std::vector<thread_info *>.
5293         * common/gdb_vecs.h (unordered_remove, ordered_remove): New.
5294
5295 2018-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
5296
5297         * record-btrace.c (record_btrace_disable_callback): Remove.
5298         (struct scoped_btrace_disable): New.
5299         (record_btrace_open): Use scoped_btrace_disable.
5300
5301 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5302
5303         * riscv-tdep.c (riscv_return_value): Change type to ULONGEST for
5304         reading values from registers.
5305
5306 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5307
5308         * riscv-tdep.c (riscv_push_dummy_call): Use core_addr_to_string_nz
5309         where appropriate.
5310
5311 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5312
5313         * riscv-tdep.c (riscv_print_arg_location): Add header comment,
5314         change parameter type.  Use GDB's print functions, and use
5315         core_addr_to_string where appropriate.
5316         (riscv_push_dummy_call): Use core_addr_to_string where
5317         appropriate, update call to riscv_print_arg_location, and reindent
5318         a few lines.
5319         (riscv_return_value): Update call to riscv_print_arg_location.
5320
5321 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5322             Tim Newsome <tim@sifive.com>
5323             Albert Ou <a0u@eecs.berkeley.edu>
5324             Darius Rad <darius@bluespec.com>
5325
5326         * Makefile.in (ALL_TARGET_OBS): Add riscv-tdep.o
5327         (HFILES_NO_SRCDIR): Add riscv-tdep.h.
5328         (ALLDEPFILES): Add riscv-tdep.c
5329         * configure.tgt: Add riscv support.
5330         * riscv-tdep.c: New file.
5331         * riscv-tdep.h: New file.
5332         * NEWS: Mention new target.
5333         * MAINTAINERS: Add entry for riscv.
5334
5335 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5336
5337         * amd64-tdep.c (amd64_classify_aggregate): Ignore zero sized
5338         fields within aggregates.
5339
5340 2018-03-04  Simon Marchi  <simon.marchi@polymtl.ca>
5341
5342         * record-btrace.c (btrace_print_lines): Change type of flags to
5343         gdb_disassembly_flags.
5344
5345 2018-03-04  John Baldwin  <jhb@FreeBSD.org>
5346
5347         * fbsd-nat.c: Include "inf-ptrace.h".
5348         (USE_SIGTRAP_SIGINFO): Conditionally define.
5349         [USE_SIGTRAP_SIGINFO] (fbsd_handle_debug_trap): New function.
5350         (fbsd_wait) [USE_SIGTRAP_SIGINFO]: Call "fbsd_handle_debug_trap".
5351         [USE_SIGTRAP_SIGINFO] (fbsd_stopped_by_sw_breakpoint): New
5352         function.
5353         [USE_SIGTRAP_SIGINFO] (fbsd_supports_stopped_by_sw_breakpoint):
5354         Likewise.
5355         [USE_SIGTRAP_SIGINFO] (fbsd_supports_stopped_by_hw_breakpoint):
5356         Likewise.
5357         (fbsd_nat_add_target) [USE_SIGTRAP_SIGINFO]: Set
5358         "stopped_by_sw_breakpoint", "supports_stopped_by_sw_breakpoint",
5359         "supports_stopped_by_hw_breakpoint" target methods.
5360
5361 2018-03-04  John Baldwin  <jhb@FreeBSD.org>
5362
5363         * NEWS (Changes since GDB 8.1): Add "set/show debug fbsd-nat".
5364         * fbsd-nat.c (debug_fbsd_nat): New variable.
5365         (show_fbsd_nat_debug): New function.
5366         (fbsd_wait): Log LWP info if "debug_fbsd_nat" is enabled.
5367         (_initialize_fbsd_nat): Add "fbsd-nat" debug boolean command.
5368
5369 2018-03-04  John Baldwin  <jhb@FreeBSD.org>
5370
5371         * nat/x86-dregs.c (x86_dr_stopped_by_hw_breakpoint): New function.
5372         * nat/x86-dregs.h (x86_dr_stopped_by_hw_breakpoint): New
5373         prototype.
5374         * x86-nat.c (x86_stopped_by_hw_breakpoint): New function.
5375         (x86_use_watchpoints): Set "stopped_by_hw_breakpoint" target
5376         method.
5377
5378 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
5379
5380         * common/gdb_vecs.c (free_char_ptr_vec): Remove.
5381         * common/gdb_vecs.h (free_char_ptr_vec): Remove.
5382
5383 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
5384
5385         * charset.c (struct charset_vector): New.
5386         (charsets): Change type to charset_vector.
5387         (find_charset_names): Adjust.
5388         (add_one): Adjust.
5389         (_initialize_charset): Adjust.
5390
5391 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
5392
5393         * progspace.h (struct program_space) <deleted_solibs>: Change
5394         type to std::vector<std::string>.
5395         * progspace.c (clear_program_space_solib_cache): Adjust.
5396         * breakpoint.c (print_solib_event): Adjust.
5397         (check_status_catch_solib): Adjust.
5398         * solib.c (update_solib_list): Adjust.
5399         * ui-out.h (class ui_out) <field_string>: New overload.
5400         * ui-out.c (ui_out::field_string): New overload.
5401
5402 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
5403
5404         * progspace.h (struct program_space): Add constructor and
5405         destructor, initialize fields.
5406         (add_program_space): Remove.
5407         * progspace.c (add_program_space): Rename to...
5408         (program_space::program_space): ... this.
5409         (release_program_space): Rename to...
5410         (program_space::~program_space): ... this.
5411         (delete_program_space): Use delete to delete program_space.
5412         (initialize_progspace): Use new to allocate program_space.
5413         * inferior.c (add_inferior_with_spaces): Likewise.
5414         (clone_inferior_command): Likewise.
5415         * infrun.c (follow_fork_inferior): Likewise.
5416         (handle_vfork_child_exec_or_exit): Likewise.
5417
5418 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
5419
5420         * common/gdb_vecs.h (make_cleanup_free_char_ptr_vec): Remove.
5421         (delim_string_to_char_ptr_vec): Return std::vector of
5422         gdb::unique_xmalloc_ptr.
5423         (dirnames_to_char_ptr_vec_append): Take std::vector of
5424         gdb::unique_xmalloc_ptr.
5425         (dirnames_to_char_ptr_vec): Return std::vector of
5426         gdb::unique_xmalloc_ptr.
5427         * common/gdb_vecs.c (delim_string_to_char_ptr_vec_append):
5428         Take std::vector of gdb::unique_xmalloc_ptr, adjust the code.
5429         (delim_string_to_char_ptr_vec): Return an std::vector of
5430         gdb::unique_xmalloc_ptr, adjust the code.
5431         (dirnames_to_char_ptr_vec_append): Take an std::vector of
5432         gdb::unique_xmalloc_ptr, adjust the code.
5433         (dirnames_to_char_ptr_vec): Return an std::vector of
5434         gdb::unique_xmalloc_ptr, adjust the code.
5435         * auto-load.c (auto_load_safe_path_vec): Change type to
5436         std::vector of gdb::unique_xmalloc_ptr.
5437         (auto_load_expand_dir_vars): Return an std::vector of
5438         gdb::unique_xmalloc_ptr, adjust the code.
5439         (auto_load_safe_path_vec_update): Adjust.
5440         (filename_is_in_auto_load_safe_path_vec): Adjust.
5441         (auto_load_objfile_script_1): Adjust.
5442         * build-id.c (build_id_to_debug_bfd): Adjust.
5443         * linux-thread-db.c (thread_db_load_search): Adjust.
5444         * source.c (add_path): Adjust.
5445         (openp): Adjust.
5446         * symfile.c (find_separate_debug_file): Adjust.
5447         * utils.c (do_free_char_ptr_vec): Remove.
5448         (make_cleanup_free_char_ptr_vec): Remove.
5449
5450 2018-03-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5451
5452         PR gdb/22907
5453         * common/pathstuff.c: Conditionally include "<windows.h>".
5454
5455 2018-03-01  Georg Sauthoff  <mail@georg.so>
5456
5457         PR gdb/22888
5458         * gcore.in: Quote variables and switch interpreter to bash.
5459
5460 2018-03-01  Tom Tromey  <tom@tromey.com>
5461
5462         * dwarf2read.c (alloc_discriminant_info): Fix default_index
5463         assertion.  Add assertion for discriminant_index.
5464         (quirk_rust_enum): Use correct base type name in univariant case.
5465
5466 2018-03-01  Simon Marchi  <simon.marchi@ericsson.com>
5467
5468         * record.c (get_call_history_modifiers): Return a
5469         record_print_flags.
5470         (cmd_record_call_history): Adjust.
5471         * record-btrace.c (record_btrace_call_history): Adjust.
5472         (record_btrace_call_history_range): Adjust.
5473         (record_btrace_call_history_from): Adjust.
5474         * target-debug.h (target_debug_print_record_print_flags): New.
5475         * target-delegates.c: Re-generate.
5476         * target.c (target_call_history): Change flags type.
5477         (target_call_history_from): Likewise.
5478         (target_call_history_range): Likewise.
5479         * target.h (struct target_ops) <target_call_history>: Likewise.
5480         (target_call_history_from): Likewise.
5481         (target_call_history_range): Likewise.
5482
5483 2018-02-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5484             Simon Marchi  <simon.marchi@polymtl.ca>
5485
5486         * common/common-utils.c: Include "sys/stat.h".
5487         (is_regular_file): Move here from "source.c"; change return
5488         type to "bool".
5489         * common/common-utils.h (is_regular_file): New prototype.
5490         * common/pathstuff.c (contains_dir_separator): New function.
5491         * common/pathstuff.h (contains_dir_separator): New prototype.
5492         * source.c: Don't include "sys/stat.h".
5493         (is_regular_file): Move to "common/common-utils.c".
5494
5495 2018-02-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5496
5497         * Makefile.in (COMMON_SFILES): Add "common/pathstuff.c".
5498         (HFILES_NO_SRCDIR): Add "common/pathstuff.h".
5499         * auto-load.c: Include "common/pathstuff.h".
5500         * common/common-def.h (current_directory): Move here.
5501         * common/gdb_tilde_expand.c (gdb_tilde_expand_up): New
5502         function.
5503         * common/gdb_tilde_expand.h (gdb_tilde_expand_up): New
5504         prototype.
5505         * common/pathstuff.c: New file.
5506         * common/pathstuff.h: New file.
5507         * compile/compile.c: Include "common/pathstuff.h".
5508         * defs.h (current_directory): Move to "common/common-defs.h".
5509         * dwarf2read.c: Include "common/pathstuff.h".
5510         * exec.c: Likewise.
5511         * guile/scm-safe-call.c: Likewise.
5512         * linux-thread-db.c: Likewise.
5513         * main.c: Likewise.
5514         * nto-tdep.c: Likewise.
5515         * objfiles.c: Likewise.
5516         * source.c: Likewise.
5517         * symtab.c: Likewise.
5518         * utils.c: Include "common/pathstuff.h".
5519         (gdb_realpath): Move to "common/pathstuff.c".
5520         (gdb_realpath_keepfile): Likewise.
5521         (gdb_abspath): Likewise.
5522         * utils.h (gdb_realpath): Move to "common/pathstuff.h".
5523         (gdb_realpath_keepfile): Likewise.
5524         (gdb_abspath): Likewise.
5525
5526 2018-02-28  John Baldwin  <jhb@FreeBSD.org>
5527
5528         * fbsd-nat.c (fbsd_resume): Use PT_SETSTEP for stepping and a
5529         wildcard process pid for super_resume for kernels with a
5530         specific bug.
5531
5532 2018-02-27  Phil Muldoon  <pmuldoon@redhat.com>
5533
5534         * compile/compile.c (get_args): Add additional comments
5535         explaining function.
5536
5537 2018-02-27  Simon Marchi  <simon.marchi@polymtl.ca>
5538             Tom Tromey  <tom@tromey.com>
5539
5540         * target.h (memory_write_request_s): Remove typedef.  Don't define
5541         VEC.
5542         (target_write_memory_blocks): Change argument to std::vector.
5543         (struct memory_write_request): Add constructor.
5544         * target-memory.c (compare_block_starting_address): Return bool.
5545         Change argument types.
5546         (claim_memory): Change arguments to use std::vector.
5547         (split_regular_and_flash_blocks, blocks_to_erase)
5548         (compute_garbled_blocks): Likewise.
5549         (cleanup_request_data, cleanup_write_requests_vector): Remove.
5550         (target_write_memory_blocks): Change argument to std::vector.
5551         * symfile.c (struct load_section_data): Add constructor and
5552         destructor.  Use std::vector for "requests".
5553         (struct load_progress_data): Add initializers.
5554         (load_section_callback): Update.  Use "new".
5555         (clear_memory_write_data): Remove.
5556         (generic_load): Update.
5557
5558 2018-02-27  Alan Hayward  <alan.hayward@arm.com>
5559
5560         * arch/aarch64.h: Use common/tdesc.h.
5561
5562 2018-02-26  Maciej W. Rozycki  <macro@mips.com>
5563
5564         * mips-tdep.c (mips_gdbarch_init): Don't use a 32-bit BFD
5565         architecture with a 64-bit ABI.
5566
5567 2018-02-26  Maciej W. Rozycki  <macro@mips.com>
5568
5569         * gdb/mips-tdep.c (mips_gdbarch_init): Reorder ABI determination
5570         ahead of target description loading.
5571
5572 2018-02-26  Tom Tromey  <tom@tromey.com>
5573
5574         * stack.c (backtrace_command_1): Update.
5575         * python/python-internal.h (gdbpy_apply_frame_filter): Change type
5576         of "flags".
5577         * python/py-framefilter.c (py_print_frame)
5578         (gdbpy_apply_frame_filter): Change type of "flags".
5579         * mi/mi-cmd-stack.c (mi_apply_ext_lang_frame_filter): Change type
5580         of "flags".
5581         (mi_cmd_stack_list_frames, mi_cmd_stack_list_locals)
5582         (mi_cmd_stack_list_args, mi_cmd_stack_list_variables): Update.
5583         * extension.h (enum frame_filter_flag): Rename from
5584         frame_filter_flags.
5585         (frame_filter_flags): Define using DEF_ENUM_FLAGS_TYPE.
5586         (apply_ext_lang_frame_filter): Change type of "flags".
5587         * extension.c (apply_ext_lang_frame_filter): Change type of
5588         "flags".
5589         * extension-priv.h (struct extension_language_ops)
5590         <apply_frame_filter>: Change type of "flags".
5591
5592 2018-02-26  Tom Tromey  <tom@tromey.com>
5593
5594         PR python/16497:
5595         * stack.c (backtrace_command_1): Set PRINT_MORE_FRAMES flag.  Fix
5596         off-by-one in py_end computation.
5597         * python/py-framefilter.c (gdbpy_apply_frame_filter): Handle
5598         PRINT_MORE_FRAMES.
5599         * extension.h (enum frame_filter_flags) <PRINT_MORE_FRAMES>: New
5600         constant.
5601
5602 2018-02-26  Tom Tromey  <tom@tromey.com>
5603
5604         * dwarf2read.c (struct variant_field): New.
5605         (struct nextfield) <variant>: New field.
5606         (dwarf2_add_field): Handle DW_TAG_variant_part.
5607         (dwarf2_attach_fields_to_type): Attach a discriminant_info to a
5608         discriminated union.
5609         (read_structure_type): Handle DW_TAG_variant_part.
5610         (handle_struct_member_die): New function, extracted from
5611         process_structure_scope.  Handle DW_TAG_variant.
5612         (process_structure_scope): Handle discriminated unions.  Call
5613         handle_struct_member_die.
5614
5615 2018-02-26  Tom Tromey  <tom@tromey.com>
5616
5617         * rust-lang.h (rust_last_path_segment): Declare.
5618         * rust-lang.c (rust_last_path_segment): Now public.  Change
5619         contract.
5620         (struct disr_info): Remove.
5621         (RUST_ENUM_PREFIX, RUST_ENCODED_ENUM_REAL)
5622         (RUST_ENCODED_ENUM_HIDDEN, rust_union_is_untagged)
5623         (rust_get_disr_info, rust_tuple_variant_type_p): Remove.
5624         (rust_enum_p, rust_enum_variant): New function.
5625         (rust_underscore_fields): Remove "offset" parameter.
5626         (rust_print_enum): New function.
5627         (rust_val_print) <TYPE_CODE_UNION>: Remove enum code.
5628         <TYPE_CODE_STRUCT>: Call rust_print_enum when appropriate.
5629         (rust_print_struct_def): Add "for_rust_enum" parameter.  Handle
5630         enums.
5631         (rust_internal_print_type): New function, from rust_print_type.
5632         Remove enum code.
5633         (rust_print_type): Call rust_internal_print_type.
5634         (rust_evaluate_subexp) <STRUCTOP_ANONYMOUS, STRUCTOP_STRUCT>:
5635         Update enum handling.
5636         * dwarf2read.c (struct dwarf2_cu) <rust_unions>: New field.
5637         (rust_fully_qualify, alloc_discriminant_info, quirk_rust_enum)
5638         (rust_union_quirks): New functions.
5639         (process_full_comp_unit, process_full_type_unit): Call
5640         rust_union_quirks.
5641         (process_structure_scope): Update rust_unions if necessary.
5642
5643 2018-02-26  Tom Tromey  <tom@tromey.com>
5644
5645         * value.h (value_union_variant): Declare.
5646         * valops.c (value_union_variant): New function.
5647         * gdbtypes.h (TYPE_FLAG_DISCRIMINATED_UNION): New macro.
5648         (struct discriminant_info): New.
5649         (enum dynamic_prop_node_kind) <DYN_PROP_DISCRIMINATED>: New
5650         enumerator.
5651         (struct main_type) <flag_discriminated_union>: New field.
5652
5653 2018-02-26  Tom Tromey  <tom@tromey.com>
5654
5655         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5656         unittests/unpack-selftests.c.
5657         * unittests/unpack-selftests.c: New file.
5658         * value.c (unpack_bits_as_long): Fix bugs in non-bitfield cases.
5659
5660 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5661
5662         * dwarf2read.c (struct partial_die_info) <read>: New method.
5663         (read_partial_die): Remove the declaration.
5664         (load_partial_dies): Update.
5665         (partial_die_info::partial_die_info):
5666         (read_partial_die): Change it to partial_die_info::read.
5667
5668 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5669
5670         * dwarf2read.c (struct partial_die_info) <fixup>: New method.
5671         (fixup_partial_die): Remove declaration.
5672         (scan_partial_symbols): Update.
5673         (partial_die_parent_scope): Likewise.
5674         (partial_die_full_name): Likewise.
5675         (fixup_partial_die): Change it to partial_die_info::fixup.
5676
5677 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5678
5679         * dwarf2read.c (read_partial_die): Update the declaration.
5680         (load_partial_dies): Caller update.
5681         (read_partial_die): Remove one argument abbrev_len.
5682
5683 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5684
5685         * dwarf2read.c (struct partial_die_info): Add ctor, delete
5686         assignment operator.
5687         (load_partial_dies): Use ctor and copy ctor.
5688         (read_partial_die): Update.
5689         (dwarf2_cu::find_partial_die): Use ctor.
5690
5691 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5692
5693         * dwarf2read.c (struct dwarf2_cu) <find_partial_die>: New method.
5694         (find_partial_die_in_comp_unit): Change it to
5695         dwarf2_cu::find_partial_die.
5696         (find_partial_die): Update.
5697
5698 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5699
5700         * dwarf2read.c (read_partial_die): Remove the code checking abbrev
5701         is NULL.
5702
5703 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5704
5705         * dwarf2read.c (load_partial_dies): Move the location of XOBNEW.
5706
5707 2018-02-26  Alan Hayward  <alan.hayward@arm.com>
5708
5709         * arch/amd64.h: Use common/tdesc.h.
5710         * arch/i386.c: Likewise.
5711         * arch/i386.h: Likewise.
5712         * arch/tic6x.c: Likewise.
5713         * arch/tdesc.h: Move file from here...
5714         * common/tdesc.h: ...to here.
5715         * features/aarch64-core.c: Regenerate.
5716         * features/aarch64-fpu.c: Regenerate.
5717         * features/i386/32bit-avx.c: Regenerate.
5718         * features/i386/32bit-avx512.c: Regenerate.
5719         * features/i386/32bit-core.c: Regenerate.
5720         * features/i386/32bit-linux.c: Regenerate.
5721         * features/i386/32bit-mpx.c: Regenerate.
5722         * features/i386/32bit-pkeys.c: Regenerate.
5723         * features/i386/32bit-sse.c: Regenerate.
5724         * features/i386/64bit-avx.c: Regenerate.
5725         * features/i386/64bit-avx512.c: Regenerate.
5726         * features/i386/64bit-core.c: Regenerate.
5727         * features/i386/64bit-linux.c: Regenerate.
5728         * features/i386/64bit-mpx.c: Regenerate.
5729         * features/i386/64bit-pkeys.c: Regenerate.
5730         * features/i386/64bit-segments.c: Regenerate.
5731         * features/i386/64bit-sse.c: Regenerate.
5732         * features/i386/x32-core.c: Regenerate.
5733         * features/tic6x-c6xp.c: Regenerate.
5734         * features/tic6x-core.c: Regenerate.
5735         * features/tic6x-gp.c: Regenerate.
5736         * target-descriptions.c: Use common/tdesc.h.
5737         * target-descriptions.h: Likewise.
5738
5739 2018-02-24  Tom Tromey  <tom@tromey.com>
5740
5741         * linux-thread-db.c (try_thread_db_load_from_pdir_1)
5742         (try_thread_db_load_from_dir, thread_db_load_search): Use
5743         std::string.
5744         (info_auto_load_libthread_db_compare): Return bool.  Change
5745         argument types.
5746         (info_auto_load_libthread_db): Use std::vector, std::string.
5747         Remove cleanups.
5748
5749 2018-02-24  Tom Tromey  <tom@tromey.com>
5750
5751         * i386-tdep.c (i386_fast_tracepoint_valid_at): "msg" now a
5752         std::string.
5753         * gdbarch.sh (fast_tracepoint_valid_at): Change "msg" to a
5754         std::string*.
5755         * gdbarch.c: Rebuild.
5756         * gdbarch.h: Rebuild.
5757         * breakpoint.c (check_fast_tracepoint_sals): Use std::string.
5758         * arch-utils.h (default_fast_tracepoint_valid_at): Update.
5759         * arch-utils.c (default_fast_tracepoint_valid_at): "msg" now a
5760         std::string*.
5761
5762 2018-02-23  Simon Marchi  <simon.marchi@polymtl.ca>
5763
5764         * gdbtypes.h (sect_offset): Change type to uint64_t.
5765         (sect_offset_str): New function.
5766         * dwarf2read.c (create_addrmap_from_aranges): Use
5767         sect_offset_str.
5768         (error_check_comp_unit_head): Likewise.
5769         (create_debug_type_hash_table): Likewise.
5770         (read_cutu_die_from_dwo): Likewise.
5771         (init_cutu_and_read_dies): Likewise.
5772         (init_cutu_and_read_dies_no_follow): Likewise.
5773         (process_psymtab_comp_unit_reader): Likewise.
5774         (partial_die_parent_scope): Likewise.
5775         (peek_die_abbrev): Likewise.
5776         (process_queue): Likewise.
5777         (dwarf2_physname): Likewise.
5778         (read_namespace_alias): Likewise.
5779         (read_import_statement): Likewise.
5780         (create_dwo_cu_reader): Likewise.
5781         (create_cus_hash_table): Likewise.
5782         (lookup_dwo_cutu): Likewise.
5783         (inherit_abstract_dies): Likewise.
5784         (read_func_scope): Likewise.
5785         (read_call_site_scope): Likewise.
5786         (dwarf2_add_member_fn): Likewise.
5787         (read_common_block): Likewise.
5788         (read_module_type): Likewise.
5789         (read_typedef): Likewise.
5790         (read_subrange_type): Likewise.
5791         (load_partial_dies): Likewise.
5792         (read_partial_die): Likewise.
5793         (find_partial_die): Likewise.
5794         (read_str_index): Likewise.
5795         (dwarf2_string_attr): Likewise.
5796         (build_error_marker_type): Likewise.
5797         (lookup_die_type): Likewise.
5798         (dump_die_shallow): Likewise.
5799         (follow_die_ref): Likewise.
5800         (dwarf2_fetch_die_loc_sect_off): Likewise.
5801         (dwarf2_fetch_constant_bytes): Likewise.
5802         (follow_die_sig): Likewise.
5803         (get_signatured_type): Likewise.
5804         (get_DW_AT_signature_type): Likewise.
5805         (dwarf2_find_containing_comp_unit): Likewise.
5806         (set_die_type): Likewise.
5807
5808 2018-02-21  John Baldwin  <jhb@FreeBSD.org>
5809
5810         * arch/aarch64.c: Include "common-defs.h".
5811         * arch/amd64.c: Likewise.
5812         * arch/i386.c: Likewise.
5813
5814 2018-02-21  Tom Tromey  <tom@tromey.com>
5815
5816         * value.h: (extract_field_op): Update.
5817         * eval.c (extract_field_op): Return a const char *.
5818         * expression.h (parse_expression_for_completion): Update.
5819         * completer.c (complete_expression): Update.
5820         (add_struct_fields): Make fieldname const.
5821         * parse.c (expout_completion_name): Now a unique_xmalloc_ptr.
5822         (mark_completion_tag, parse_exp_in_context_1): Update.
5823         (parse_expression_for_completion): Change "name" to
5824         unique_xmalloc_ptr*.
5825
5826 2018-02-21  Tom Tromey  <tom@tromey.com>
5827
5828         * infcall.c (call_function_by_hand_dummy): Use std::vector.
5829
5830 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5831
5832         * avr-tdep.c (avr_read_pc): Change parameter type to
5833         readable_regcache.
5834         * gdbarch.sh (read_pc): Likewise.
5835         * gdbarch.c: Re-generated.
5836         * gdbarch.h: Re-generated.
5837         * hppa-tdep.c (hppa_read_pc): Change parameter type to
5838         readable_regcache.
5839         * ia64-tdep.c (ia64_read_pc): Likewise.
5840         * mips-tdep.c (mips_read_pc): Likewise.
5841         * spu-tdep.c (spu_read_pc): Likewise.
5842
5843 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5844
5845         * Makefile.in (COMMON_SFILES): Add regcache-dump.c
5846         * regcache-dump.c: New file.
5847         * regcache.c: Move register_dump to regcache-dump.c.
5848         (maintenance_print_registers): Likewise.
5849         (maintenance_print_raw_registers): Likewise.
5850         (maintenance_print_cooked_registers): Likewise.
5851         (maintenance_print_register_groups): Likewise.
5852         (maintenance_print_remote_registers): Likewise.
5853         (_initialize_regcache): Likewise.
5854         * regcache.h (register_dump): Moved from regcache.c.
5855
5856 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5857
5858         * regcache.c (regcache::regcache): Update.
5859         (regcache::invalidate): Move it to detached_regcache::invalidate.
5860         (get_thread_arch_aspace_regcache): Update.
5861         (regcache::raw_update): Update.
5862         (regcache::cooked_read): Remove some code.
5863         (regcache::cooked_read_value): Likewise.
5864         (regcache::raw_write): Remove assert on m_readonly_p.
5865         (regcache::raw_supply_integer): Move it to
5866         detached_regcache::raw_supply_integer.
5867         (regcache::raw_supply_zeroed): Likewise.
5868         * regcache.h (detached_regcache) <raw_supply_integer>: New
5869         declaration.
5870         <raw_supply_zeroed, invalidate>: Likewise.
5871         (regcache) <raw_supply_integer, raw_supply_zeroed>: Removed.
5872         <invalidate>: Likewise.
5873         <m_readonly_p>: Removed.
5874
5875 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5876
5877         * infcmd.c (get_return_value): Let stop_regs point to
5878         get_current_regcache.
5879         * regcache.c (regcache::regcache): Remove.
5880         (register_dump_reg_buffer): New class.
5881         (regcache_print): Adjust.
5882         * regcache.h (regcache): Remove constructors.
5883
5884 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5885
5886         * regcache.c (class register_dump): New class.
5887         (register_dump_regcache, register_dump_none): New class.
5888         (register_dump_remote, register_dump_groups): New class.
5889         (regcache_print): Update.
5890         * regcache.h (regcache_dump_what): Move it to regcache.c.
5891         (regcache) <dump>: Remove.
5892
5893 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5894
5895         * jit.c (struct jit_unwind_private) <regcache>: Change its type to
5896          reg_buffer_rw *.
5897         (jit_unwind_reg_set_impl): Call raw_supply.
5898         (jit_frame_sniffer): Use reg_buffer_rw.
5899         * record-full.c (record_full_core_regbuf): Change its type.
5900         (record_full_core_open_1): Use reg_buffer_rw.
5901         (record_full_close): Likewise.
5902         (record_full_core_fetch_registers): Use regcache->raw_supply.
5903         (record_full_core_store_registers): Likewise.
5904         * regcache.c (regcache::get_register_status): Move it to
5905         reg_buffer.
5906         (regcache_raw_set_cached_value): Remove.
5907         (regcache::raw_set_cached_value): Remove.
5908         (regcache::raw_write): Call raw_supply.
5909         (regcache::raw_supply): Move it to reg_buffer_rw.
5910         * regcache.h (regcache_raw_set_cached_value): Remove.
5911         (reg_buffer_rw): New class.
5912
5913 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5914
5915         * dummy-frame.c (dummy_frame_cache) <prev_regcache>: Use
5916         readonly_detached_regcache.
5917         (dummy_frame_prev_register): Use regcache->cooked_read.
5918         * frame.c (frame_save_as_regcache): Change return type.
5919         (frame_pop): Update.
5920         * frame.h (frame_save_as_regcache): Update declaration.
5921         * inferior.h (get_infcall_suspend_state_regcache): Update
5922         declaration.
5923         * infrun.c (infcall_suspend_state) <registers>: use
5924         readonly_detached_regcache.
5925         (save_infcall_suspend_state): Don't use regcache_dup.
5926         (get_infcall_suspend_state_regcache): Change return type.
5927         * linux-fork.c (struct fork_info) <savedregs>: Change to
5928         readonly_detached_regcache.
5929         <pc>: New field.
5930         (fork_save_infrun_state): Don't use regcache_dup.
5931         (info_checkpoints_command): Adjust.
5932         * mi/mi-main.c (register_changed_p): Update declaration.
5933         (mi_cmd_data_list_changed_registers): Use
5934         readonly_detached_regcache.
5935         (register_changed_p): Change parameter type to
5936         readonly_detached_regcache.
5937         * ppc-linux-tdep.c (ppu2spu_cache) <regcache>: Use
5938         readonly_detached_regcache.
5939         (ppu2spu_sniffer): Construct a new readonly_detached_regcache.
5940         * regcache.c (readonly_detached_regcache::readonly_detached_regcache):
5941         New.
5942         (regcache::save): Move it to reg_buffer.
5943         (regcache::restore): Change parameter type.
5944         (regcache_dup): Remove.
5945         * regcache.h (reg_buffer) <save>: New method.
5946         (readonly_detached_regcache): New class.
5947         * spu-tdep.c (spu2ppu_cache) <regcache>: Use
5948         readonly_detached_regcache.
5949         (spu2ppu_sniffer): Construct a new readonly_detached_regcache.
5950
5951 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5952
5953         * frame.c (frame_save_as_regcache): Use regcache method save.
5954         (frame_pop): Use regcache method restore.
5955         * infrun.c (restore_infcall_suspend_state): Likewise.
5956         * linux-fork.c (fork_load_infrun_state): Likewise.
5957         * ppc-linux-tdep.c (ppu2spu_sniffer): User regcache method
5958         save.
5959         * regcache.c (regcache_save): Remove.
5960         (regcache::restore): More asserts.
5961         (regcache_cpy): Remove.
5962         * regcache.h (regcache_save): Remove the declaration.
5963         (regcache::restore): Move from private to public.
5964         Remove the friend declaration of regcache_cpy.
5965         (regcache_cpy): Remove declaration.
5966
5967 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5968
5969         * aarch64-tdep.c (aarch64_pseudo_register_read_value): Change
5970         parameter type to 'readable_regcache *'.
5971         * amd64-tdep.c (amd64_pseudo_register_read_value): Likewise.
5972         * arm-tdep.c (arm_neon_quad_read): Likewise.
5973         (arm_pseudo_read): Likewise.
5974         * avr-tdep.c (avr_pseudo_register_read): Likewise.
5975         * bfin-tdep.c (bfin_pseudo_register_read): Likewise.
5976         * frv-tdep.c (frv_pseudo_register_read): Likewise.
5977         * gdbarch.c: Re-generated.
5978         * gdbarch.h: Re-generated.
5979         * gdbarch.sh (pseudo_register_read): Change parameter type to
5980         'readable_regcache *'.
5981         (pseudo_register_read_value): Likewise.
5982         * h8300-tdep.c (pseudo_from_raw_register): Likewise.
5983         (h8300_pseudo_register_read): Likewise.
5984         * hppa-tdep.c (hppa_pseudo_register_read): Likewise.
5985         * i386-tdep.c (i386_mmx_regnum_to_fp_regnum): Likewise.
5986         (i386_pseudo_register_read_into_value): Likewise.
5987         (i386_pseudo_register_read_value): Likewise.
5988         * i386-tdep.h (i386_pseudo_register_read_into_value): Update
5989         declaration.
5990         * ia64-tdep.c (ia64_pseudo_register_read): Likewise.
5991         * m32c-tdep.c (m32c_raw_read): Likewise.
5992         (m32c_read_flg): Likewise.
5993         (m32c_banked_register): Likewise.
5994         (m32c_banked_read): Likewise.
5995         (m32c_sb_read): Likewise.
5996         (m32c_part_read): Likewise.
5997         (m32c_cat_read): Likewise.
5998         (m32c_r3r2r1r0_read): Likewise.
5999         (m32c_pseudo_register_read): Likewise.
6000         * m68hc11-tdep.c (m68hc11_pseudo_register_read): Likewise.
6001         * mep-tdep.c (mep_pseudo_cr32_read): Likewise.
6002         (mep_pseudo_cr64_read): Likewise.
6003         (mep_pseudo_register_read): Likewise.
6004         * mips-tdep.c (mips_pseudo_register_read): Likewise.
6005         * msp430-tdep.c (msp430_pseudo_register_read): Likewise.
6006         * nds32-tdep.c (nds32_pseudo_register_read): Likewise.
6007         * regcache.c (regcache::raw_read): Move it to readable_regcache.
6008         (regcache::cooked_read): Likewise.
6009         (regcache::cooked_read_value): Likewise.
6010         (regcache_cooked_read_signed):
6011         (regcache::cooked_read): Likewise.
6012         * regcache.h (readable_regcache): New class.
6013         (regcache): Inherit readable_regcache.  Move some methods to
6014         readable_regcache.
6015         * rl78-tdep.c (rl78_pseudo_register_read): Change
6016         parameter type to 'readable_regcache *'.
6017         * rs6000-tdep.c (do_regcache_raw_read): Remove.
6018         (e500_pseudo_register_read): Change parameter type to
6019         'readable_regcache *'.
6020         (dfp_pseudo_register_read): Likewise.
6021         (vsx_pseudo_register_read): Likewise.
6022         (efpr_pseudo_register_read): Likewise.
6023         * s390-tdep.c (s390_pseudo_register_read): Likewise.
6024         * sh-tdep.c (sh_pseudo_register_read): Likewise.
6025         * sh64-tdep.c (pseudo_register_read_portions): Likewise.
6026         (sh64_pseudo_register_read): Likewise.
6027         * sparc-tdep.c (sparc32_pseudo_register_read): Likewise.
6028         * sparc64-tdep.c (sparc64_pseudo_register_read): Likewise.
6029         * spu-tdep.c (spu_pseudo_register_read_spu): Likewise.
6030         (spu_pseudo_register_read): Likewise.
6031         * xtensa-tdep.c (xtensa_register_read_masked): Likewise.
6032         (xtensa_pseudo_register_read): Likewise.
6033
6034 2018-02-21  Yao Qi  <yao.qi@linaro.org>
6035
6036         * regcache.c (regcache::regcache): Call reg_buffer ctor.
6037         (regcache::arch): Move it to reg_buffer::arch.
6038         (regcache::register_buffer): Likewise.
6039         (regcache::assert_regnum): Likewise.
6040         (regcache::num_raw_registers): Likewise.
6041         * regcache.h (reg_buffer): New class.
6042         (regcache): Inherit reg_buffer.
6043
6044 2018-02-20  Simon Marchi  <simon.marchi@ericsson.com>
6045
6046         * remote-sim.c (gdb_os_printf_filtered, gdb_os_vprintf_filtered,
6047         gdb_os_evprintf_filtered, gdb_os_error): Add ATTRIBUTE_PRINTF.
6048
6049 2018-02-20  Markus Metzger  <markus.t.metzger@intel.com>
6050
6051         * gnulib/update-gnulib.sh (IMPORTED_GNULIB_MODULES): Add mkstemp.
6052
6053 2018-02-19  Alan Hayward  <alan.hayward@arm.com>
6054
6055         * Makefile.in: (COMMON_SFILES): Add common/*.c files.
6056         (SFILES): Remove common/*.c files.
6057         (COMMON_OBS): Remove some *.o files built from common/*.c files.
6058         * common/common.host: Add common reference.
6059         * configure.ac: Likewise.
6060         * configure: Regenerate.
6061
6062 2018-02-16  Yao Qi  <yao.qi@linaro.org>
6063
6064         * block.c (block_namespace_info): Inherit allocate_on_obstack.
6065         (block_initialize_namespace): Use new.
6066         * dwarf2read.c (dwarf2_per_objfile): Inherit allocate_on_obstack.
6067         (dwarf2_free_objfile): Use delete.
6068         * gdbtypes.c (type_pair): Inherit allocate_on_obstack.
6069         (copy_type_recursive): Use new.
6070         * gdb_obstack.h (allocate_on_obstack): New.
6071
6072 2018-02-15  Yao Qi  <yao.qi@linaro.org>
6073
6074         PR gdb/22849
6075         * inferior.c (exit_inferior_1): Reset inf->control.
6076
6077 2018-02-15  Joel Brobecker  <brobecker@adacore.com>
6078
6079         * ada-lang.c (ada_to_fixed_value_create): Delete advance
6080         declaration.
6081
6082 2018-02-14  Pedro Alves  <palves@redhat.com>
6083
6084         * frame-unwind.c (frame_unwind_try_unwinder): Always call
6085         frame_cleanup_after_sniffer on exception.
6086
6087 2018-02-14  Tom Tromey  <tom@tromey.com>
6088
6089         * solist.h (struct target_so_ops) <bfd_open>: Make pathname
6090         const.
6091         (solib_bfd_open): Make pathname const.
6092         * solib.c (solib_bfd_open): Make pathname const.
6093         * solib-spu.c (spu_bfd_fopen): Make name const.
6094         (spu_bfd_open): Make pathname const.
6095         * solib-darwin.c (darwin_bfd_open): Make pathname const.
6096         * solib-aix.c (solib_aix_bfd_open): Make pathname const.
6097
6098 2018-02-14  Tom Tromey  <tom@tromey.com>
6099
6100         * symfile.c (symfile_bfd_open): Update.
6101         * source.h (openp, source_full_path_of, find_and_open_source):
6102         Change argument type to unique_xmalloc_ptr.
6103         * source.c (openp): Take a unique_xmalloc_ptr.
6104         (source_full_path_of, find_and_open_source): Likewise.
6105         (open_source_file, symtab_to_fullname): Update.
6106         * solist.h (struct target_so_ops) <find_and_open_solib>: Take a
6107         unique_xmalloc_ptr.
6108         * solib.c (solib_find_1): Use unique_xmalloc_ptr.
6109         (exec_file_find): Update.
6110         * psymtab.c (psymtab_to_fullname): Update.
6111         * nto-tdep.h (nto_find_and_open_solib): Update.
6112         * nto-tdep.c (nto_find_and_open_solib): Change temp_path to a
6113         unique_xmalloc_ptr.
6114         * exec.c (exec_file_attach): Update.
6115         * dwarf2read.c (try_open_dwop_file): Use unique_xmalloc_ptr.
6116         * cli/cli-cmds.c (find_and_open_script): Use unique_xmalloc_ptr.
6117
6118 2018-02-14  Tom Tromey  <tom@tromey.com>
6119
6120         * solib.c: Include source.h.
6121         * nto-tdep.c: Include source.h.
6122         * mi/mi-cmd-env.c: Include source.h.
6123         * infcmd.c: Include source.h.
6124         * exec.c: Include source.h.
6125         * defs.h (enum openp_flag, openp, source_full_path_of, mod_path)
6126         (add_path, directory_switch, source_path, init_source_path): Move
6127         declarations...
6128         * source.h (enum openp_flag, openp, source_full_path_of, mod_path)
6129         (add_path, directory_switch, source_path, init_source_path):
6130         ...here.
6131
6132 2018-02-14  Tom Tromey  <tom@tromey.com>
6133
6134         * solist.h (exec_file_find, solib_find): Return
6135         unique_xmalloc_ptr.
6136         (solib_bfd_fopen): Take a const char *.
6137         * solib.c (solib_find_1): Return unique_xmalloc_ptr.
6138         (exec_file_find, solib_find): Likewise.
6139         (solib_bfd_fopen): Do not take ownership of "pathname".
6140         (solib_bfd_open): Use unique_xmalloc_ptr.
6141         * solib-darwin.c (darwin_bfd_open): Use unique_xmalloc_ptr.
6142         * solib-aix.c (solib_aix_bfd_open): Use unique_xmalloc_ptr.
6143         * infrun.c (follow_exec): Use unique_xmalloc_ptr.
6144         * exec.c (exec_file_locate_attach): Use unique_xmalloc_ptr.
6145
6146 2018-02-14  Joel Brobecker  <brobecker@adacore.com>
6147
6148         * ada-lang.c (name_match_type_from_name): Remove reference to
6149         ada_name_for_lookup in function's documentation.
6150         * ada-lang.h (ada_name_for_lookup): Delete declaration.
6151
6152 2018-02-13  Simon Marchi  <simon.marchi@polymtl.ca>
6153
6154         * defs.h (enum openp_flags): New enum.
6155         (OPF_TRY_CWD_FIRST, OPF_SEARCH_IN_PATH, OPF_RETURN_REALPATH):
6156         Move to enum openp_flags.
6157         (openp_flags): New enum flags.
6158         (openp): Change parameter type to openp_flags.
6159         * source.c (openp): Change parameter type to openp_flags.
6160         * cli/cli-cmds.c (find_and_open_script): Use openp_flags.
6161         * dwarf2read.c (try_open_dwop_file): Use openp_flags.
6162
6163 2018-02-13  Simon Marchi  <simon.marchi@polymtl.ca>
6164
6165         * maint.c (_initialize_maint_cmds): Fix prefix of maint set/show
6166         per-command.
6167
6168 2018-02-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6169
6170         * dwarf2read.c (dwarf2_release_queue): Delete function, move body
6171         into...
6172         (class dwarf2_queue_guard): ...the destructor of this new class.
6173         (dw2_do_instantiate_symtab): Create instance of the new class
6174         dwarf2_queue_guard, remove cleanup.
6175
6176 2018-02-09  Tom Tromey  <tom@tromey.com>
6177
6178         * source.c (find_source_lines): Don't reference past the end of
6179         the vector.
6180
6181 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
6182
6183         * remote.c (remote_btrace_maybe_reopen): Change error message.
6184         * btrace.c (btrace_enable): Likewise.
6185         (parse_xml_btrace): Likewise.
6186         (parse_xml_btrace_conf): Likewise.
6187
6188 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
6189
6190         * nat/linux-btrace.c (diagnose_perf_event_open_fail): New.
6191         (linux_enable_pt, linux_enable_bts): Call
6192         diagnose_perf_event_open_fail.
6193
6194 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
6195
6196         * nat/linux-btrace.c (perf_event_pt_event_type): Improve error message.
6197         Remove parameter and change return type.  Update callers.  Move it.
6198         (linux_enable_bts, linux_enable_pt): Improve error message.
6199         (linux_enable_pt): Remove zero buffer size check.
6200         (linux_enable_btrace): Improve error messages.  Remove NULL return
6201         check.
6202
6203 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
6204
6205         * btrace.c (btrace_enable): Remove target_supports_btrace call.
6206         * nat/linux-btrace.c (perf_event_pt_event_type): Move.
6207         (kernel_supports_bts, kernel_supports_pt, linux_supports_bts)
6208         (linux_supports_pt, linux_supports_btrace): Remove.
6209         (linux_enable_bts): Call cpu_supports_bts.
6210         * nat/linux-btrace.h (linux_supports_btrace): Remove.
6211         * remote.c (remote_supports_btrace): Remove.
6212         (init_remote_ops): Remove remote_supports_btrace.
6213         * target-delegates.c: Regenerated.
6214         * target.c (target_supports_btrace): Remove.
6215         * target.h (target_ops) <to_supports_btrace>: Remove
6216         (target_supports_btrace): Remove.
6217         * x86-linux-nat.c (x86_linux_create_target): Remove
6218         linux_supports_btrace.
6219
6220 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
6221
6222         * nat/linux-btrace.c (linux_enable_btrace): Throw exception if enabling
6223         btrace failed.
6224         * x86-linux-nat.c (x86_linux_enable_btrace): Catch btrace enabling
6225         exception and use message in own exception.
6226
6227 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
6228
6229         * nat/linux-btrace.c: Include scoped_fd.h and scoped_mmap.h.
6230         (perf_event_pt_event_type): Use gdb_file_up.
6231         (linux_enable_bts, linux_enable_pt): Use gdb::unique_xmalloc_ptr,
6232         scoped_fd, and scoped_mmap.
6233
6234 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
6235
6236         * common/scoped_mmap.h: New.
6237         * unittests/scoped_mmap-selftest.c: New.
6238         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6239         unittests/scoped_mmap-selftest.c.
6240
6241 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
6242
6243         * common/scoped_fd.h: New.
6244         * unittests/scoped_fd-selftest.c: New.
6245         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6246         unittests/scoped_fd-selftest.c.
6247
6248 2018-02-09  Tom Tromey  <tom@tromey.com>
6249
6250         * auto-load.c (auto_load_section_scripts): Use
6251         gdb::unique_xmalloc_ptr.
6252
6253 2018-02-09  Tom Tromey  <tom@tromey.com>
6254
6255         * auto-load.c (execute_script_contents): Use std::string.
6256
6257 2018-02-09  Joel Brobecker  <brobecker@adacore.com>
6258
6259         * NEWS <Changes in GDB 8.1>: Clarify that "rbreak" is a new
6260         Python function, rather than a new command.
6261
6262 2018-02-08  Tom Tromey  <tom@tromey.com>
6263
6264         * solib.c (solib_find_1): Use std::string.
6265         (solib_bfd_fopen): Use unique_xmalloc_ptr.
6266
6267 2018-02-08  Tom Tromey  <tom@tromey.com>
6268
6269         * build-id.c (build_id_to_debug_bfd): Use unique_xmalloc_ptr.
6270
6271 2018-02-08  Tom Tromey  <tom@tromey.com>
6272
6273         * source.c (find_source_lines): Use gdb::def_vector.
6274
6275 2018-02-08  Tom Tromey  <tom@tromey.com>
6276
6277         * macrocmd.c (struct temporary_macro_definition): New.
6278         (macro_define_command): Use temporary_macro_definition.  Remove
6279         cleanups.
6280         (free_macro_definition_ptr): Remove.
6281
6282 2018-02-08  Tom Tromey  <tom@tromey.com>
6283
6284         * macroexp.c (maybe_expand): Use std::string.
6285
6286 2018-02-08  Tom Tromey  <tom@tromey.com>
6287
6288         * macroexp.c (struct macro_buffer): Add initializers for some
6289         members.
6290         (init_buffer, init_shared_buffer, free_buffer)
6291         (free_buffer_return_text): Remove.
6292         (macro_buffer): New constructors.
6293         (~macro_buffer): New destructor.
6294         (macro_buffer::set_shared): New method.
6295         (macro_buffer::resize_buffer, macro_buffer::appendc)
6296         (macro_buffer::appendmem): Now methods, not free functions.
6297         (set_token, append_tokens_without_splicing, stringify)
6298         (macro_stringify): Update.
6299         (gather_arguments): Change return type.  Remove argc_p argument,
6300         add args_ptr argument.  Use std::vector.
6301         (substitute_args): Remove argc argument.  Accept std::vector.
6302         (expand): Update.  Use std::vector.
6303         (scan, macro_expand, macro_expand_next): Update.
6304
6305 2018-02-08  Tom Tromey  <tom@tromey.com>
6306
6307         * symtab.c (default_collect_symbol_completion_matches_break_on):
6308         Use unique_xmalloc_ptr.
6309         * macroscope.h: (sal_macro_scope, user_macro_scope)
6310         (default_macro_scope): Return unique_xmalloc_ptr.
6311         * macroscope.c (sal_macro_scope, user_macro_scope)
6312         (default_macro_scope): Return unique_xmalloc_ptr.
6313         * macroexp.h (macro_expand, macro_expand_once): Return
6314         unique_xmalloc_ptr.
6315         * macroexp.c (macro_expand, macro_expand_once): Return
6316         unique_xmalloc_ptr.
6317         * macrocmd.c (macro_expand_command, macro_expand_once_command)
6318         (info_macro_command, info_macros_command): Use
6319         unique_xmalloc_ptr.
6320         * compile/compile-c-support.c (write_macro_definitions): Use
6321         unique_xmalloc_ptr.
6322         * c-exp.y (c_parse): Use unique_xmalloc_ptr.
6323
6324 2018-02-07  Simon Marchi  <simon.marchi@ericsson.com>
6325
6326         * value.c (value_static_field): Assign field type instead of
6327         containing type when returning an optimized out value.
6328
6329 2018-02-06  Yao Qi  <yao.qi@linaro.org>
6330
6331         * ft32-tdep.c (ft32_read_pc): Remove.
6332         (ft32_write_pc): Remove.
6333         (ft32_gdbarch_init): Update.
6334         * m32r-tdep.c (m32r_read_pc): Remove.
6335         (m32r_gdbarch_init): Update.
6336         * mep-tdep.c (mep_read_pc): Remove.
6337         (mep_gdbarch_init): Update.
6338         * microblaze-tdep.c (microblaze_write_pc): Remove.
6339         (microblaze_gdbarch_init): Update.
6340         * mn10300-tdep.c (mn10300_read_pc): Remove.
6341         (mn10300_write_pc): Remove.
6342         (mn10300_gdbarch_init): Update.
6343         * moxie-tdep.c (moxie_read_pc): Remove.
6344         (moxie_write_pc): Remove.
6345         (moxie_gdbarch_init): Update.
6346
6347 2018-02-06  Yao Qi  <yao.qi@linaro.org>
6348
6349         * expprint.c (print_subexp_standard): Handle
6350         OP_F77_UNDETERMINED_ARGLIST.
6351         (dump_subexp_body_standard): Likewise.
6352
6353 2018-02-05  Alan Hayward  <alan.hayward@arm.com>
6354
6355         * target-descriptions.c (tdesc_element_visitor) Add empty
6356         implementations.
6357         (tdesc_type): Move make_gdb_type from here.
6358         (tdesc_type_builtin): Likewise.
6359         (tdesc_type_vector): Likewise.
6360         (tdesc_type_with_fields): Move make_gdb_type_ functions from here.
6361         (make_gdb_type_struct): Move from tdesc_type_with_fields.
6362         (make_gdb_type_union): Likewise.
6363         (make_gdb_type_flags): Likewise.
6364         (make_gdb_type_enum): Likewise.
6365         (make_gdb_type): New function.
6366         (tdesc_register_type): Use static make_gdb_type.
6367
6368 2018-02-05  Ruslan Kabatsayev <b7.10110111@gmail.com>
6369
6370         * infcmd.c (default_print_one_register_info): Align natural-format
6371         column values consistently one under another.
6372         (pad_to_column): New function.
6373
6374 2018-02-05  Joel Brobecker  <brobecker@adacore.com>
6375
6376         * dwarf2read.c (dwarf2_physname): Move commment.
6377
6378 2018-02-01  Leszek Swirski  <leszeks@google.com>
6379
6380         * varobj.c (varobj_formatted_print_options): Allow recursive
6381         pretty printing if pretty printing is enabled.
6382
6383 2018-02-01  Leszek Swirski  <leszeks@google.com>
6384
6385         * c-exp.y (lex_one_token, classify_name, yylex): Don't classify
6386         names after a structop as a filename.
6387
6388 2018-02-01  Yao Qi  <yao.qi@linaro.org>
6389
6390         * arm-tdep.c (arm_record_data_proc_misc_ld_str): Rewrite it.
6391         (arm_record_coproc_data_proc): Likewise.
6392
6393 2018-02-01  Yao Qi  <yao.qi@linaro.org>
6394
6395         * arm-tdep.c (arm_record_extension_space): Change ret to signed.
6396
6397 2018-01-31  Nikola Prica  <nikola.prica@rt-rk.com>
6398
6399         * rs6000-tdep.c (skip_prologue): Remove shifting for lr_reg and
6400         assign shifted lr_reg to fdata->lr_register when lr_reg is set.
6401
6402 2018-01-31  Pedro Alves  <palves@redhat.com>
6403
6404         * darwin-nat.c (darwin_interrupt): Remove ptid_t parameter.
6405         * inflow.c (child_terminal_save_inferior): Wrap reference to
6406         tcgetpgrp in HAVE_TERMIOS_H.
6407         (child_interrupt, child_pass_ctrlc): Wrap references to signal in
6408         _WIN32.
6409         * remote-sim.c (gdbsim_interrupt): Remove ptid_t parameter and
6410         always iterate over all inferiors.
6411         (gdbsim_cntrl_c): Adjust.
6412         * windows-nat.c (windows_interrupt): Remove 'ptid_t' parameter.
6413
6414 2018-01-31  Joel Brobecker  <brobecker@adacore.com>
6415
6416         * gdbtypes.c (lookup_array_range_type): Make sure the array's
6417         index type is objfile-owned if the element type is as well.
6418
6419 2018-01-31  Joel Brobecker  <brobecker@adacore.com>
6420
6421         GDB 8.1 released.
6422
6423 2018-01-30  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6424
6425         * s390-linux-tdep.c: Remove includes "features/s390-linux32.c" and
6426         "features/s390x-linux64.c".
6427         (_initialize_s390_linux_tdep): Remove initialization of tdescs
6428         s390_linux32 and s390x_linux64.
6429         (s390_linux_init_abi_31, s390_linux_init_abi_64): Don't set
6430         default tdesc.
6431         * s390-tdep.c: Include "features/s390-linux32.c" and
6432         "features/s390x-linux64.c".
6433         (s390_tdesc_valid): Add check for tdesc_has_registers.
6434         (s390_gdbarch_init): Make sure there is always a valid tdesc.
6435         (_initialize_s390_tdep): Initialize tdesc_s390_linux32 and
6436         tdesc_s390x_linux64.
6437         * s390-linux-tdep.h: Move export of tdesc_s390_linux32 and
6438         tdesc_s390x_linux64 to...
6439         * s390-tdep.h: ...here.
6440
6441 2018-01-30  Pedro Alves  <palves@redhat.com>
6442
6443         PR gdb/13211
6444         * config.in, configure: Regenerate.
6445         * configure.ac: Check for getpgid.
6446         * go32-nat.c (go32_pass_ctrlc): New.
6447         (go32_target): Install it.
6448         * inf-child.c (inf_child_target): Install
6449         child_terminal_save_inferior, child_pass_ctrlc and
6450         child_interrupt.
6451         * inf-ptrace.c (inf_ptrace_interrupt): Delete.
6452         (inf_ptrace_target): No longer install it.
6453         * infcmd.c (interrupt_target_1): Adjust.
6454         * inferior.h (child_terminal_save_inferior, child_pass_ctrlc)
6455         (child_interrupt): Declare.
6456         (inferior::terminal_state): New.
6457         * inflow.c (struct terminal_info): Update comments.
6458         (inferior_process_group): Delete.
6459         (terminal_is_ours): Delete.
6460         (gdb_tty_state): New.
6461         (child_terminal_init): Adjust.
6462         (is_gdb_terminal, sharing_input_terminal_1)
6463         (sharing_input_terminal): New functions.
6464         (child_terminal_inferior): Adjust.  Use sharing_input_terminal.
6465         Set the process's actual process group in the foreground if
6466         possible.  Handle is_ours_for_output/is_ours distinction.  Don't
6467         mark terminal as the inferior's if not sharing GDB's terminal.
6468         Don't check attach_flag.
6469         (child_terminal_ours_for_output, child_terminal_ours): Adjust to
6470         pass down a target_terminal_state.
6471         (child_terminal_save_inferior): New, factored out from ...
6472         (child_terminal_ours_1): ... this.  Handle
6473         target_terminal_state::is_ours_for_output.
6474         (child_interrupt, child_pass_ctrlc): New.
6475         (inflow_inferior_exit): Clear the inferior's terminal_state.
6476         (copy_terminal_info): Copy the inferior's terminal state.
6477         (_initialize_inflow): Remove reference to terminal_is_ours.
6478         * inflow.h (inferior_process_group): Delete.
6479         * nto-procfs.c (nto_handle_sigint, procfs_interrupt): Adjust.
6480         * procfs.c (procfs_target): Don't install procfs_interrupt.
6481         (procfs_interrupt): Delete.
6482         * remote.c (remote_serial_quit_handler): Adjust.
6483         (remote_interrupt): Remove ptid parameter.  Adjust.
6484         * target-delegates.c: Regenerate.
6485         * target.c: Include "terminal.h".
6486         (target_terminal::terminal_state): Rename to ...
6487         (target_terminal::m_terminal_state): ... this.
6488         (target_terminal::init): Adjust.
6489         (target_terminal::inferior): Adjust to per-inferior
6490         terminal_state.
6491         (target_terminal::restore_inferior, target_terminal_is_ours_kind): New.
6492         (target_terminal::ours, target_terminal::ours_for_output): Use
6493         target_terminal_is_ours_kind.
6494         (target_interrupt): Remove ptid parameter.  Adjust.
6495         (default_target_pass_ctrlc): Adjust.
6496         * target.h (target_ops::to_terminal_save_inferior): New field.
6497         (target_ops::to_interrupt): Remove ptid_t parameter.
6498         (target_interrupt): Remove ptid_t parameter.  Update comment.
6499         (target_pass_ctrlc): Update comment.
6500         * target/target.h (target_terminal_state): New scoped enum,
6501         factored out of ...
6502         (target_terminal::terminal_state): ... here.
6503         (target_terminal::inferior): Update comments.
6504         (target_terminal::restore_inferior): New.
6505         (target_terminal::is_inferior, target_terminal::is_ours)
6506         (target_terminal::is_ours_for_output): Adjust.
6507         (target_terminal::scoped_restore_terminal_state): Adjust to
6508         rename, and call restore_inferior() instead of inferior().
6509         (target_terminal::scoped_restore_terminal_state::m_state): Change
6510         type.
6511         (target_terminal::terminal_state): Rename to ...
6512         (target_terminal::m_terminal_state): ... this and change type.
6513
6514 2018-01-30  Pedro Alves  <palves@redhat.com>
6515
6516         * linux-nat.c (wait_for_signal): New function.
6517         (wait_lwp, linux_nat_wait_1): Use it instead of calling sigsuspend
6518         directly.
6519         (async_terminal_is_ours)
6520         (linux_nat_terminal_inferior, linux_nat_terminal_ours): Delete.
6521         (linux_nat_add_target): Don't override
6522         to_terminal_inferior/to_terminal_ours.
6523
6524 2018-01-29  Sergio Durigan Junior  <sergiodj@redhat.com>
6525
6526         * remote.c (remote_follow_fork): Don't call "detach_inferior".
6527
6528 2018-01-28  Simon Marchi  <simon.marchi@ericsson.com>
6529
6530         * dwarf2read.c (free_dwo_files): Add forward-declaration.
6531         (dwarf2_per_objfile::~dwarf2_per_objfile): Move content from
6532         dwarf2_per_objfile_free here.
6533         (dwarf2_per_objfile_free): Remove.
6534         (_initialize_dwarf2_read): Don't register
6535         dwarf2_per_objfile_free as a registry cleanup.
6536
6537 2018-01-27  Eli Zaretskii  <eliz@gnu.org>
6538
6539         Avoid compilation errors in MinGW native builds
6540
6541         The error is triggered by including python-internal.h, and the
6542         error message is:
6543
6544              In file included from d:\usr\lib\gcc\mingw32\6.3.0\include\c++\math.h:36:0,
6545                       from build-gnulib/import/math.h:27,
6546                       from d:/usr/Python26/include/pyport.h:235,
6547                       from d:/usr/Python26/include/Python.h:58,
6548                       from python/python-internal.h:94,
6549                       from python/py-arch.c:24:
6550              d:\usr\lib\gcc\mingw32\6.3.0\include\c++\cmath:1157:11: error: '::hypot' has not been declared
6551         using ::hypot;
6552                 ^~~~~
6553
6554         This happens because Python headers define 'hypot' to expand t
6555         '_hypot' in the Windows builds.
6556         * python/python-internal.h (_hypot) [__MINGW32__]: Define back to
6557         'hypoth'.  This avoids a compilation error.
6558
6559 2018-01-26  Alan Hayward  <alan.hayward@arm.com>
6560
6561         * MAINTAINERS (Write After Approval): Fix ordering.
6562
6563 2018-01-26  Alan Hayward  <alan.hayward@arm.com>
6564
6565         * MAINTAINERS (Write After Approval): Add Alan Hayward.
6566
6567 2018-01-26  Alan Modra  <amodra@gmail.com>
6568
6569         * ppc-linux-tdep.c (powerpc32_plt_stub): Make const.
6570         (powerpc32_plt_stub_so_1): Rename from powerpc32_plt_stub_so.
6571         Remove nop.  Make const.  Comment.
6572         (powerpc32_plt_stub_so_2): New.
6573         (POWERPC32_PLT_CHECK_LEN): Rename from POWERPC32_PLT_STUB_LEN.
6574         Correct count.  Update uses.
6575         (ppc_skip_trampoline_code): Match powerpc32_plt_stub_so_2 too.
6576         Move common code reading PLT entry word.  Correct
6577         powerpc32_plt_stub PLT address calculation.
6578         * ppc64-tdep.c (ppc64_standard_linkage1): Make const.
6579         (ppc64_standard_linkage2, ppc64_standard_linkage3): Likewise.
6580         (ppc64_standard_linkage4, ppc64_standard_linkage5): Likewise.
6581         (ppc64_standard_linkage6, ppc64_standard_linkage7): Likewise.
6582         (ppc64_standard_linkage8): Likewise.
6583         * rs6000-tdep.c (ppc_insns_match_pattern): Make pattern const.
6584         Correct insns description.
6585         * ppc-tdep.h (ppc_insns_match_pattern): Update prototype.
6586
6587 2018-01-24  Pedro Alves  <palves@redhat.com>
6588
6589         GCC PR libstdc++/83906
6590         * gdbtypes.c (operator==(const dynamic_prop &,
6591         const dynamic_prop &)): New.
6592         (operator==(const range_bounds &, const range_bounds &)): New.
6593         (check_types_equal): Use them instead of memcmp.
6594         * gdbtypes.h (operator==(const dynamic_prop &,
6595         const dynamic_prop &)): Declare.
6596         (operator!=(const dynamic_prop &, const dynamic_prop &)): Declare.
6597         (operator==(const range_bounds &, const range_bounds &)): Declare.
6598         (operator!=(const range_bounds &, const range_bounds &)): Declare.
6599
6600 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6601
6602         * s390-linux-tdep.c (s390_record_address_mask)
6603         (s390_record_calc_disp_common, s390_record_calc_disp)
6604         (s390_record_calc_disp_vsce, s390_record_calc_rl, s390_popcnt)
6605         (s390_record_gpr_g, s390_record_gpr_h, s390_record_vr)
6606         (s390_process_record): Move to s390-tdep.c.
6607         (s390_linux_init_abi_any): Adjust.
6608         * s390-tdep.c (s390_record_address_mask)
6609         (s390_record_calc_disp_common, s390_record_calc_disp)
6610         (s390_record_calc_disp_vsce, s390_record_calc_rl, s390_popcnt)
6611         (s390_record_gpr_g, s390_record_gpr_h, s390_record_vr)
6612         (s390_process_record): Moved from s390-linux-tdep.c
6613         (s390_gdbarch_init): Adjust.
6614
6615 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6616
6617         * s390-linux-nat.c (s390-tdep.h): New include.
6618         * Makefile.in (ALL_TARGET_OBS): Add s390-tdep.o.
6619         (HFILES_NO_SRCDIR): Add s390-tdep.h.
6620         (ALLDEPFILES): Add s390-tdep.c.
6621         * configure.tgt (s390*-*-linux*): Add s390-tdep.o.
6622         * s390-linux-tdep.h (HWCAP_S390_*, S390_*_REGNUM): Move to...
6623         * s390-tdep.h: ...this.  New file.
6624         * s390-linux-tdep.c (s390-tdep.h): New include.
6625         (_initialize_s390_tdep): Rename to...
6626         (_initialize_s390_linux_tdep): ...this and adjust.
6627         (s390_abi_kind, s390_vector_abi_kind, gdbarch_tdep)
6628         (enum named opcodes, S390_NUM_GPRS, S390_NUM_FPRS): Move to
6629         s390-tdep.h.
6630         (s390_break_insn, s390_breakpoint, s390_readinstruction, is_ri)
6631         (is_ril, is_rr, is_rre, is_rs, is_rsy, is_rx, is_rxy)
6632         (s390_is_partial_instruction, s390_software_single_step)
6633         (is_non_branch_ril, s390_displaced_step_copy_insn)
6634         (s390_displaced_step_fixup, s390_displaced_step_hw_singlestep)
6635         (s390_prologue_data, s390_addr, s390_store, s390_load)
6636         (s390_check_for_saved, s390_analyze_prologue, s390_skip_prologue)
6637         (s390_register_call_saved, s390_guess_tracepoint_registers)
6638         (s390_register_name, s390_dwarf_regmap, s390_dwarf_reg_to_regnum)
6639         (regnum_is_gpr_full, regnum_is_vxr_full, s390_value_from_register)
6640         (s390_pseudo_register_name, s390_pseudo_register_type)
6641         (s390_pseudo_register_read, s390_pseudo_register_write)
6642         (s390_pseudo_register_reggroup_p, s390_ax_pseudo_register_collect)
6643         (s390_ax_pseudo_register_push_stack, s390_gen_return_address)
6644         (s390_addr_bits_remove, s390_address_class_type_flags)
6645         (s390_address_class_type_flags_to_name)
6646         (s390_address_class_name_to_type_flags, s390_effective_inner_type)
6647         (s390_function_arg_float, s390_function_arg_vector)
6648         (is_power_of_two, s390_function_arg_integer, s390_arg_state)
6649         (s390_handle_arg, s390_push_dummy_call, s390_dummy_id)
6650         (s390_frame_align, s390_register_return_value, s390_return_value)
6651         (s390_stack_frame_destroyed_p, s390_unwind_pc, s390_unwind_sp)
6652         (s390_unwind_pseudo_register, s390_adjust_frame_regnum)
6653         (s390_dwarf2_prev_register, s390_dwarf2_frame_init_reg)
6654         (s390_trad_frame_prev_register, s390_unwind_cache)
6655         (s390_prologue_frame_unwind_cache)
6656         (s390_backchain_frame_unwind_cache, s390_frame_unwind_cache)
6657         (s390_frame_this_id, s390_frame_prev_register, s390_frame_unwind)
6658         (s390_stub_unwind_cache, s390_stub_frame_unwind_cache)
6659         (s390_stub_frame_this_id, s390_stub_frame_prev_register)
6660         (s390_stub_frame_sniffer, s390_stub_frame_unwind)
6661         (s390_frame_base_address, s390_local_base_address)
6662         (s390_frame_base, s390_gcc_target_options)
6663         (s390_gnu_triplet_regexp, s390_stap_is_single_operand)
6664         (s390_validate_reg_range, s390_tdesc_valid)
6665         (s390_gdbarch_tdep_alloc, s390_gdbarch_init): Move to...
6666         * s390-tdep.c: ...this.  New file.
6667
6668 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6669
6670         * s390-linux-tdep.c (gdbarch_tdep.s390_syscall_record): New hook.
6671         (s390_process_record, s390_gdbarch_tdep_alloc)
6672         (s390_linux_init_abi_any): Use/set new hook.
6673
6674 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6675
6676         * s390-linux-tdep.c (osabi.h): New include.
6677         (s390_linux_init_abi_31, s390_linux_init_abi_64)
6678         (s390_linux_init_abi_any): New functions.
6679         (s390_gdbarch_init, _initialize_s390_tdep): Adjust.
6680
6681 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6682
6683         * s390-linux-tdep.c (s390_gdbarch_init): Use gdb_assert for
6684         tdesc_has_registers check
6685
6686 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6687
6688         * s390-linux-tdep.c (s390_tdesc_valid): New function.
6689         (s390_validate_reg_range): New macro.
6690         (s390_gdbarch_init): Adjust.
6691
6692 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6693
6694         * s390-linux-tdep.c (gdbarch_tdep) <tdesc>: New field.
6695         (s390_gdbarch_tdep_alloc): Adjust.
6696         (s390_gdbarch_init): Adjust.
6697
6698 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6699
6700         * s390-linux-tdep.c (gdbarch_tdep) <have_linux_v1, have_linux_v2>
6701         <have_tdb>: Change type to bool.
6702         (s390_gdbarch_tdep_alloc): Adjust.
6703         (s390_gdbarch_init): Adjust.
6704
6705 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6706
6707         * s390-linux-tdep (s390_abi_kind) <ABI_NONE>: New default field.
6708         (gdbarch_tdep) <have_upper, have_vx>: New fields.
6709         (s390_gdbarch_tdep_alloc): New function.
6710         (s390_gdbarch_init): Allocate tdep at start and use its fields
6711         instead of separate variables.
6712
6713 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6714
6715         * s390-linux-tdep.c (s390_gdbarch_init): Remove duplicate checks
6716         when looking for cached gdbarch and add comment for remaining.
6717
6718 2018-01-22  Pedro Alves  <palves@redhat.com>
6719             Sergio Durigan Junior  <sergiodj@redhat.com>
6720
6721         * typeprint.c (whatis_exp): Initialize "val" in the "whatis type"
6722         case.
6723
6724 2018-01-22  Maciej W. Rozycki  <macro@mips.com>
6725
6726         * MAINTAINERS: Update my company e-mail address.
6727
6728 2018-01-22  Yao Qi  <yao.qi@linaro.org>
6729
6730         * regcache.c (cooked_write_test): New function.
6731         (_initialize_regcache): Register the test.
6732
6733 2018-01-22  Yao Qi  <yao.qi@linaro.org>
6734
6735         * ia64-tdep.c (ia64_pseudo_register_read): Call
6736         regcache->cooked_read instead of regcache_cooked_read_unsigned.
6737         * m32c-tdep.c (m32c_cat_read): Likewise.
6738         (m32c_r3r2r1r0_read): Likewise.
6739         * m68hc11-tdep.c (m68hc11_pseudo_register_read): Likewise.
6740         * xtensa-tdep.c (xtensa_register_read_masked): Likewise.
6741
6742 2018-01-22  Yao Qi  <yao.qi@linaro.org>
6743
6744         * aarch64-tdep.c (aarch64_pseudo_read_value): Call regcache
6745         method raw_read instead of regcache_raw_read.
6746         * amd64-tdep.c (amd64_pseudo_register_read_value): Likewise.
6747         * arm-tdep.c (arm_neon_quad_read): Likewise.
6748         * avr-tdep.c (avr_pseudo_register_read): Likewise.
6749         * bfin-tdep.c (bfin_pseudo_register_read): Likewise.
6750         * frv-tdep.c (frv_pseudo_register_read): Likewise.
6751         * h8300-tdep.c (h8300_pseudo_register_read): Likewise.
6752         * i386-tdep.c (i386_mmx_regnum_to_fp_regnum): Likewise.
6753         (i386_pseudo_register_read_into_value): Likewise.
6754         * mep-tdep.c (mep_pseudo_cr32_read): Likewise.
6755         * msp430-tdep.c (msp430_pseudo_register_read): Likewise.
6756         * nds32-tdep.c (nds32_pseudo_register_read): Likewise.
6757         * rl78-tdep.c (rl78_pseudo_register_read): Likewise.
6758         * s390-linux-tdep.c (s390_pseudo_register_read): Likewise.
6759         * sparc-tdep.c (sparc32_pseudo_register_read):  Likewise.
6760         * sparc64-tdep.c (sparc64_pseudo_register_read): Likewise.
6761         * spu-tdep.c (spu_pseudo_register_read_spu):  Likewise.
6762         * xtensa-tdep.c (xtensa_pseudo_register_read): Likewise.
6763
6764 2018-01-22  Yao Qi  <yao.qi@linaro.org>
6765
6766         * Makefile.in (ALL_TARGET_OBS): Remove mt-tdep.o.
6767         * configure.tgt: Remove target mt.
6768         * mt-tdep.c: Remove.
6769         * regcache.c (cooked_read_test): Remove the check for mt.
6770
6771 2018-01-22  Yao Qi  <yao.qi@linaro.org>
6772
6773         * jit.c (jit_frame_prev_register): Call regcache::cooked_read
6774         instead of gdbarch_pseudo_register_read_value.
6775
6776 2018-01-22  Joel Brobecker  <brobecker@adacore.com>
6777
6778         * dwarf2read.c (need_gnat_info): Return nonzero if the cu's
6779         language is Ada.
6780
6781 2018-01-22  Joel Brobecker  <brobecker@adacore.com>
6782
6783         * linespec.c (create_sals_line_offset): Remove code that preserved
6784         the symtab_and_line's line number.
6785
6786 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6787
6788         * varobj.c (varobj_create): Don't set valid_block when creating a
6789         floating varobj.
6790
6791 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6792
6793         * varobj.c (varobj_create): Remove out of date comment.
6794
6795 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6796
6797         PR mi/20395
6798         * ada-exp.y (write_var_from_sym): Pass extra parameter when
6799         updating innermost block.
6800         * parse.c (innermost_block_tracker::update): Take extra type
6801         parameter, and check types match before updating innermost block.
6802         (write_dollar_variable): Update innermost block for registers.
6803         * parser-defs.h (enum innermost_block_tracker_type): New enum.
6804         (innermost_block_tracker::innermost_block_tracker): Initialise
6805         m_types member.
6806         (innermost_block_tracker::reset): Take type parameter.
6807         (innermost_block_tracker::update): Take type parameter, and pass
6808         type through as needed.
6809         (innermost_block_tracker::m_types): New member.
6810         * varobj.c (varobj_create): Pass type when reseting innermost
6811         block.
6812
6813 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6814
6815         * ada-exp.y (write_var_from_sym): Switch to innermost_block API.
6816         * ada-lang.c (resolve_subexp): Likewise.
6817         * breakpoint.c (set_breakpoint_condition) Likewise.
6818         (watch_command_1) Likewise.
6819         * c-exp.y (variable): Likewise.
6820         * d-exp.y (PrimaryExpression): Likewise.
6821         * f-exp.y (variable): Likewise.
6822         * go-exp.y (variable): Likewise.
6823         * m2-exp.y (variable): Likewise.
6824         * objfiles.c (objfile::~objfile): Likewise.
6825         * p-exp.y (variable): Likewise.
6826         * parse.c (innermost_block): Change type.
6827         * parser-defs.h (class innermost_block_tracker): New.
6828         (innermost_block): Change to innermost_block_tracker.
6829         * printcmd.c (display_command): Switch to innermost_block API.
6830         (do_one_display): Likewise.
6831         * rust-exp.y (do_one_display): Likewise.
6832         * symfile.c (clear_symtab_users): Likewise.
6833         * varobj.c (varobj_create): Switch to innermost_block API, replace
6834         use of innermost_block with block stored on varobj object.
6835
6836 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6837
6838         * expression.h (innermost_block): Remove declaration.
6839         * varobj.c: Add 'parser-defs.h' include.
6840
6841 2018-01-19  Tom Tromey  <tom@tromey.com>
6842
6843         * rust-lang.c (rust_lookup_symbol_nonlocal): Look up qualified
6844         symbols in the static and global blocks.
6845
6846 2018-01-19  James Clarke  <jrtc27@jrtc27.com>
6847
6848         * nat/linux-ptrace.c: Remove unnecessary reinclusion of
6849         gdb_ptrace.h, and move including gdb_wait.h ...
6850         * nat/linux-ptrace.h: ... to here.
6851
6852 2018-01-19  Simon Marchi  <simon.marchi@ericsson.com>
6853
6854         * inf-ptrace.c (inf_ptrace_detach): Adjust call to
6855         inf_ptrace_detach_success.
6856         (inf_ptrace_detach_success): Add inferior parameter, use it
6857         instead of inferior_ptid, pass it to detach_inferior.
6858         * inf-ptrace.h (inf_ptrace_detach_success): Add inferior
6859         parameter.
6860         * inferior.c (detach_inferior): Add overload that takes an
6861         inferior object.
6862         * inferior.h (detach_inferior): Likewise.
6863         * linux-nat.c (linux_nat_detach): Use the inf parameter, don't
6864         use inferior_ptid, adjust call to inf_ptrace_detach_success.
6865         * linux-thread-db.c (thread_db_detach): Use inf parameter.
6866
6867 2018-01-19  Simon Marchi  <simon.marchi@ericsson.com>
6868
6869         * target.h (struct target_ops) <to_detach>: Add inferior
6870         parameter.
6871         (target_detach): Likewise.
6872         * target.c (dispose_inferior): Pass inferior down.
6873         (target_detach): Pass inferior down.  Assert that it is equal to
6874         the current inferior.
6875         * aix-thread.c (aix_thread_detach): Pass inferior down.
6876         * corefile.c (core_file_command): Pass current_inferior() down.
6877         * corelow.c (core_detach): Add inferior parameter.
6878         * darwin-nat.c (darwin_detach): Likewise.
6879         * gnu-nat.c (gnu_detach): Likewise.
6880         * inf-ptrace.c (inf_ptrace_detach): Likewise.
6881         * infcmd.c (detach_command): Pass current_inferior() down to
6882         target_detach.
6883         * infrun.c (follow_fork_inferior): Pass parent_inf to
6884         target_detach.
6885         (handle_vfork_child_exec_or_exit): Pass inf->vfork_parent to
6886         target_detach.
6887         * linux-nat.c (linux_nat_detach): Add inferior parameter.
6888         * linux-thread-db.c (thread_db_detach): Likewise.
6889         * nto-procfs.c (procfs_detach): Likewise.
6890         * procfs.c (procfs_detach): Likewise.
6891         * record.c (record_detach): Likewise.
6892         * record.h (struct inferior): Forward-declare.
6893         (record_detach): Add inferior parameter.
6894         * remote-sim.c (gdbsim_detach): Likewise.
6895         * remote.c (remote_detach_1): Likewise.
6896         (remote_detach): Likewise.
6897         (extended_remote_detach): Likewise.
6898         * sol-thread.c (sol_thread_detach): Likewise.
6899         * target-debug.h (target_debug_print_inferior_p): New macro.
6900         * target-delegates.c: Re-generate.
6901         * top.c (kill_or_detach): Pass inferior down to target_detach.
6902         * windows-nat.c (windows_detach): Add inferior parameter.
6903
6904 2018-01-19  Simon Marchi  <simon.marchi@ericsson.com>
6905
6906         * target.h (struct target_ops) <to_detach>: Remove args
6907         parameter.
6908         (target_detach): Likewise.
6909         * target.c (dispose_inferior): Adjust.
6910         (target_detach): Remove args parameter, adjust.
6911         * aix-thread.c (aix_thread_detach): Adjust.
6912         * corefile.c (core_file_command): Adjust.
6913         * corelow.c (core_detach): Adjust.
6914         * darwin-nat.c (darwin_detach): Adjust.
6915         * gnu-nat.c (gnu_detach): Adjust.
6916         * inf-ptrace.c (inf_ptrace_detach): Adjust.
6917         * infcmd.c (detach_command): Adjust
6918         * infrun.c (follow_fork_inferior): Adjust.
6919         (handle_vfork_child_exec_or_exit): Adjust.
6920         * linux-fork.c (linux_fork_detach): Remove args parameter.
6921         * linux-fork.h (linux_fork_detach): Likewise.
6922         * linux-nat.c (linux_nat_detach): Likewise, and adjust.
6923         * linux-thread-db.c (thread_db_detach): Likewise.
6924         * nto-procfs.c (procfs_detach): Likewise.
6925         * procfs.c (procfs_detach): Likewise.
6926         (do_detach): Remove signo parameter.
6927         * record.c (record_detach): Remove args parameter.
6928         * record.h (record_detach): Likewise.
6929         * remote-sim.c (gdbsim_detach): Likewise.
6930         * remote.c (remote_detach_1): Likewise.
6931         (remote_detach): Likewise.
6932         (extended_remote_detach): Likewise.
6933         * sol-thread.c (sol_thread_detach): Likewise.
6934         * target-delegates.c: Re-generate.
6935         * top.c (struct qt_args) <args>: Remove field.
6936         (kill_or_detach): Don't pass args.
6937         (quit_force): Don't set args.
6938         * windows-nat.c (windows_detach): Remove args parameter.
6939
6940 2018-01-19  Yao Qi  <yao.qi@linaro.org>
6941
6942         * arm-linux-tdep.c (arm_linux_gcc_target_options): New function.
6943         (arm_linux_init_abi): Install it.
6944
6945 2018-01-19  Yao Qi  <yao.qi@linaro.org>
6946
6947         * osabi.c (gdb_osabi_names): Extend the regexp for
6948         arm-linux-gnueabihf.
6949
6950 2018-01-18  Yao Qi  <yao.qi@linaro.org>
6951
6952         * dwarf2read.c (abbrev_table) <abbrevs>: Rename it to
6953         m_abbrevs.
6954         (abbrev_table::add_abbrev): Update.
6955         (abbrev_table::lookup_abbrev): Update.
6956
6957 2018-01-18  Yao Qi  <yao.qi@linaro.org>
6958
6959         * ppc-linux-tdep.c (ppu2spu_prev_register): Call cooked_read.
6960
6961 2018-01-17  Sergio Durigan Junior  <sergiodj@redhat.com>
6962
6963         * compile/compile.c (compile_to_object): Convert "triplet_rx"
6964         to "std::string".
6965
6966 2018-01-17  Tom Tromey  <tom@tromey.com>
6967
6968         * dwarf2read.c (symbolp): Remove typedef.  Don't instantiate VEC.
6969
6970 2018-01-17  Tom Tromey  <tom@tromey.com>
6971
6972         * gdbtypes.h (add_dyn_prop): Remove objfile parameter.
6973         * gdbtypes.c (add_dyn_prop): Remove objfile parameter.
6974         (create_array_type_with_stride): Update.
6975         * dwarf2read.c (set_die_type): Update.
6976
6977 2018-01-17  Tom Tromey  <tom@tromey.com>
6978
6979         * dwarf2read.c (delayed_method_info): Remove typedef.
6980         (dwarf2_cu::method_info): Now a std::vector.
6981         (add_to_method_list): Update.
6982         (free_delayed_list): Remove.
6983         (compute_delayed_physnames): Update.
6984         (process_full_comp_unit, process_full_type_unit): Clear the method
6985         list.  Remove cleanups.
6986         (psymtab_include_file_name): Add name_holder parameter.  Use
6987         unique_xmalloc_ptr.
6988         (dwarf_decode_lines): Update.
6989
6990 2018-01-17  Tom Tromey  <tom@tromey.com>
6991             Simon Marchi  <simon.marchi@ericsson.com>
6992
6993         * dwarf2read.c (struct dwarf2_cu): Add constructor, destructor.
6994         (dwarf2_per_objfile::free_cached_comp_units)
6995         (init_tu_and_read_dwo_dies, init_cutu_and_read_dies)
6996         (init_cutu_and_read_dies_no_follow): Update.
6997         (dwarf2_cu::dwarf2_cu): Rename from init_one_comp_unit.
6998         (dwarf2_cu::~dwarf2_cu): New.
6999         (free_heap_comp_unit, free_stack_comp_unit): Remove.
7000         (age_cached_comp_units, free_one_cached_comp_unit): Update.
7001
7002 2018-01-17  Tom Tromey  <tom@tromey.com>
7003             Simon Marchi  <simon.marchi@ericsson.com>
7004
7005         * dwarf2read.c (struct dwarf2_cu) <abbrev_table>: Remove.
7006         (struct die_reader_specs) <abbrev_table>: New member.
7007         (struct abbrev_table): Add constructor.
7008         <alloc_abbrev, add_abbrev, lookup_abbrev>: Declare.
7009         <abbrev_obstack>: Now an auto_obstack.
7010         (abbrev_table_up): New typedef.
7011         (init_cu_die_reader): Add abbrev_table parameter.
7012         (read_cutu_die_from_dwo): Remove abbrev_table_provided parameter.
7013         Add result_dwo_abbrev_table.
7014         (init_tu_and_read_dwo_dies, init_cutu_and_read_dies)
7015         (init_cutu_and_read_dies_no_follow, build_type_psymtabs_1):
7016         Update.
7017         (peek_die_abbrev): Take die_reader_specs, not dwarf_cu as
7018         parameter.
7019         (skip_children): Update.
7020         (abbrev_table::alloc_abbrev): Rename from
7021         abbrev_table_alloc_abbrev.
7022         (abbrev_table::add_abbrev): Rename from abbrev_table_add_abbrev.
7023         (abbrev_table::lookup_abbrev): Rename from
7024         abbrev_table_lookup_abbrev.
7025         (abbrev_table_read_table): Return abbrev_table_up.
7026         (abbrev_table_free, abbrev_table_free_cleanup)
7027         (dwarf2_read_abbrevs, dwarf2_free_abbrev_table): Remove.
7028         (load_partial_dies): Update.
7029
7030 2018-01-17  Tom Tromey  <tom@tromey.com>
7031
7032         * dwarf2read.c (dwarf2_compute_name): Update comment.
7033         (read_func_scope, read_variable): Update.
7034         (new_symbol): Remove.
7035         (new_symbol_full): Rename to new_symbol.
7036
7037 2018-01-17  Mike Gulick  <mgulick@mathworks.com>
7038
7039         PR gdb/16577
7040         * gdb_bfd.c (gdb_bfd_map_section): If unable to read object file, issue
7041         a warning instead of throwing an error, set section size to 0 and return
7042         NULL.
7043         * gdb_bfd.h (gdb_bfd_map_section): Update description.
7044
7045 2018-01-17  Simon Marchi  <simon.marchi@ericsson.com>
7046
7047         * nat/linux-ptrace.h (linux_ptrace_attach_fail_reason): Return
7048         std::string.
7049         (linux_ptrace_attach_fail_reason_string): Likewise.
7050         * nat/linux-ptrace.c (linux_ptrace_attach_fail_reason):
7051         Likewise.
7052         (linux_ptrace_attach_fail_reason_string): Likewise.
7053         * linux-nat.c (attach_proc_task_lwp_callback): Adjust.
7054
7055 2018-01-17  Simon Marchi  <simon.marchi@ericsson.com>
7056
7057         * linux-nat.c (linux_nat_attach): Remove xstrdup.
7058
7059 2018-01-17  Eldar Abusalimov  <eldar.abusalimov@jetbrains.com>
7060
7061         PR gdb/21559
7062         * configure.ac: Include <sys/types.h> prior to <sys/user.h> when
7063         checking for fs_base/gs_base fields in struct user_regs_struct.
7064         * configure: Regenerate.
7065
7066 2018-01-17  Yao Qi  <yao.qi@linaro.org>
7067
7068         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): New
7069         function.
7070         (aarch64_linux_init_abi): Install it to gdbarch hook
7071         gcc_target_options.
7072
7073 2018-01-15  Pedro Alves  <palves@redhat.com>
7074
7075         * common/signals-state-save-restore.c
7076         (save_original_signals_state): Fix typos.
7077
7078 2017-01-12  Tom Tromey  <tom@tromey.com>
7079             Sergio Durigan Junior  <sergiodj@redhat.com>
7080
7081         * Makefile.in (install-only): Install gdb-add-index.
7082
7083 2018-01-12  John Baldwin  <jhb@FreeBSD.org>
7084
7085         * fbsd-tdep.c (KVE_PROTECTION): Correct value.
7086
7087 2018-01-12  Andreas Arnez  <arnez@linux.vnet.ibm.com>
7088
7089         * infrun.c (keep_going_pass_signal): Clear step-over info when
7090         insert_breakpoints fails.
7091
7092 2018-01-11  Pedro Alves  <palves@redhat.com>
7093
7094         PR gdb/22583
7095         * infrun.c (resume): Rename to ...
7096         (resume_1): ... this.
7097         (resume): Reimplement as wrapper around resume_1.
7098
7099 2018-01-11  Pedro Alves  <palves@redhat.com>
7100
7101         PR remote/22597
7102         * remote.c (remote_parse_stop_reply): Default to the last-set
7103         general thread instead of to 'magic_null_ptid'.
7104
7105 2018-01-10  Pedro Alves  <palves@redhat.com>
7106
7107         * language.h (language_get_symbol_name_matcher): Rename ...
7108         (get_symbol_name_matcher): ... this.
7109         * language.c (language_get_symbol_name_matcher): Ditto.
7110         * dictionary.c, linespec.c, minsyms.c, psymtab.c, symtab.c: All
7111         callers adjusted.
7112
7113 2018-01-10  Pedro Alves  <palves@redhat.com>
7114
7115         PR gdb/22670
7116         * dwarf2read.c
7117         (gdb_index_symbol_name_matcher::gdb_index_symbol_name_matcher):
7118         Adjust to use language_get_symbol_name_matcher instead of
7119         language_defn::la_get_symbol_name_matcher.
7120         * language.c (language_get_symbol_name_matcher): If in Ada mode
7121         and the lookup name is a verbatim match, return Ada's matcher.
7122         * language.h (language_get_symbol_name_matcher): Adjust comment.
7123         (ada_lookup_name_info::verbatim_p):: New method.
7124
7125 2018-01-10  Pedro Alves  <palves@redhat.com>
7126
7127         PR gdb/22670
7128         * ada-lang.c (ada_collect_symbol_completion_matches): If the
7129         minsym's language is language_auto or language_cplus, pass down
7130         language_ada instead.
7131         * symtab.c (compare_symbol_name): Don't frob symbol language here.
7132
7133 2018-01-10  Pedro Alves  <palves@redhat.com>
7134
7135         PR gdb/22670
7136         * minsyms.c (linkage_name_str): New function.
7137         (iterate_over_minimal_symbols): Use it.
7138
7139 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
7140
7141         * NEWS: Document that 'info proc' now works on FreeBSD.
7142
7143 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
7144
7145         * configure.ac: Check for kinfo_getfile in libutil.
7146         * configure: Regenerate.
7147         * config.in: Regenerate.
7148         * fbsd-nat.c: Include "fbsd-tdep.h".
7149         (fbsd_fetch_cmdline): New.
7150         (fbsd_fetch_kinfo_proc): Move earlier and change to return a bool
7151         rather than calling error.
7152         (fbsd_info_proc): New.
7153         (fbsd_thread_name): Report error if fbsd_fetch_kinfo_proc fails.
7154         (fbsd_wait): Report warning if fbsd_fetch_kinfo_proc fails.
7155         (fbsd_nat_add_target): Set "to_info_proc" to "fbsd_info_proc".
7156
7157 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
7158
7159         * fbsd-nat.c (struct free_deleter): Remove.
7160         (fbsd_find_memory_regions): Use gdb::unique_xmalloc_ptr<>.
7161
7162 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
7163
7164         * fbsd-nat.c (fbsd_pid_to_exec_file) [KERN_PROC_PATHNAME]: Return
7165         NULL for an empty pathname.
7166
7167 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
7168
7169         * fbsd-tdep.c (KVE_STRUCTSIZE, KVE_START, KVE_END, KVE_OFFSET)
7170         (KVE_FLAGS, KVE_PROTECTION, KVE_PATH, KINFO_VME_PROT_READ)
7171         (KINFO_VME_PROT_WRITE, KINFO_VME_PROT_EXEC, KINFO_VME_FLAG_COW)
7172         (KINFO_VME_FLAG_NEEDS_COPY, KINFO_VME_FLAG_NOCOREDUMP)
7173         (KINFO_VME_FLAG_SUPER, KINFO_VME_FLAG_GROWS_UP)
7174         (KINFO_VME_FLAG_GROWS_DOWN, KF_STRUCTSIZE, KF_TYPE, KF_FD)
7175         (KF_PATH, KINFO_FILE_TYPE_VNODE, KINFO_FILE_FD_TYPE_CWD)
7176         (KINFO_FILE_FD_TYPE_TEXT, SIG_WORDS, struct kinfo_proc_layout)
7177         (kinfo_proc_layout_32, kinfo_proc_layout_i386)
7178         (kinfo_proc_layout_64, fbsd_vm_map_entry_flags)
7179         (fbsd_core_info_proc_mappings, fbsd_core_vnode_path)
7180         (fbsd_core_fetch_timeval, fbsd_print_sigset)
7181         (fbsd_core_info_proc_status, fbsd_core_info_proc): New.
7182         (fbsd_init_abi):  Install gdbarch "core_info_proc" method.
7183         * fbsd-tdep.h (fbsd_vm_map_entry_flags): New.
7184
7185 2018-01-08  Samuel Thibault  <samuel.thibault@ens-lyon.org>
7186
7187         * gdb/gnu-nat.c: Include <elf.h> and <link.h>.
7188         (gnu_xfer_auxv): New function.
7189         (gnu_xfer_partial): Call gnu_xfer_auxv when `object' is
7190         TARGET_OBJECT_AUXV.
7191
7192 2018-01-08  Yao Qi  <yao.qi@linaro.org>
7193             Simon Marchi  <simon.marchi@ericsson.com>
7194
7195         * Makefile.in (COMMON_SFILES): Remove selftest-arch.c and
7196         common/selftest.c.
7197         (COMMON_OBS): Remove selftest.o.
7198         * configure.ac: Append selftest-arch.c and common/selftest.c to
7199         CONFIG_SRCS.  Append selftest-arch.o and selftest.o to COMMON_OBS.
7200         * configure: Re-generated.
7201         * maint.c (maintenance_selftest): Wrap selftests::run_tests with
7202         GDB_SELF_TEST.
7203         (maintenance_info_selftests): Likewise.
7204
7205 2018-01-08  Xavier Roirand  <roirand@adacore.com>
7206
7207         * ada-valprint.c (val_print_packed_array_elements): Use
7208         proper number of elements when printing an array indexed
7209         by an enumeration type.
7210
7211 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
7212
7213         * dwarf2read.c (struct dwarf2_cu) <dwarf2_per_objfile>: Remove.
7214         (dw2_get_file_names_reader): Adjust.
7215         (lookup_dwo_signatured_type): Adjust.
7216         (lookup_dwp_signatured_type): Adjust.
7217         (lookup_signatured_type): Adjust.
7218         (create_type_unit_group): Adjust.
7219         (get_type_unit_group): Adjust.
7220         (process_psymtab_comp_unit_reader): Adjust.
7221         (build_type_psymtabs_reader): Adjust.
7222         (scan_partial_symbols): Adjust.
7223         (add_partial_symbol): Adjust.
7224         (add_partial_subprogram): Adjust.
7225         (peek_die_abbrev): Adjust.
7226         (fixup_go_packaging): Adjust.
7227         (process_imported_unit_die): Adjust.
7228         (dwarf2_compute_name): Adjust.
7229         (dwarf2_physname): Adjust.
7230         (read_import_statement): Adjust.
7231         (handle_DW_AT_stmt_list): Adjust.
7232         (read_file_scope): Adjust.
7233         (read_func_scope): Adjust.
7234         (read_lexical_block_scope): Adjust.
7235         (read_call_site_scope): Adjust.
7236         (read_variable): Adjust.
7237         (dwarf2_rnglists_process): Adjust.
7238         (dwarf2_ranges_process): Adjust.
7239         (dwarf2_ranges_read): Adjust.
7240         (dwarf2_get_pc_bounds): Adjust.
7241         (dwarf2_record_block_ranges): Adjust.
7242         (dwarf2_add_field): Adjust.
7243         (dwarf2_add_member_fn): Adjust.
7244         (read_structure_type): Adjust.
7245         (process_structure_scope): Adjust.
7246         (read_enumeration_type): Adjust.
7247         (read_array_type): Adjust.
7248         (mark_common_block_symbol_computed): Adjust.
7249         (read_common_block): Adjust.
7250         (read_namespace_type): Adjust.
7251         (read_namespace): Adjust.
7252         (read_module_type): Adjust.
7253         (read_tag_pointer_type): Adjust.
7254         (read_tag_ptr_to_member_type): Adjust.
7255         (read_tag_string_type): Adjust.
7256         (read_subroutine_type): Adjust.
7257         (read_typedef): Adjust.
7258         (read_base_type): Adjust.
7259         (attr_to_dynamic_prop): Adjust.
7260         (read_subrange_type): Adjust.
7261         (read_unspecified_type): Adjust.
7262         (dwarf2_read_abbrevs): Adjust.
7263         (load_partial_dies): Adjust.
7264         (read_partial_die): Adjust.
7265         (find_partial_die): Adjust.
7266         (guess_partial_die_structure_name): Adjust.
7267         (fixup_partial_die): Adjust.
7268         (read_attribute_value): Adjust.
7269         (read_addr_index): Adjust.
7270         (read_addr_index_from_leb128): Adjust.
7271         (read_str_index): Adjust.
7272         (dwarf2_string_attr): Adjust.
7273         (get_debug_line_section): Adjust.
7274         (dwarf_decode_line_header): Adjust.
7275         (lnp_state_machine::check_line_address): Adjust.
7276         (dwarf_decode_lines_1): Adjust.
7277         (dwarf_decode_lines): Adjust.
7278         (dwarf2_start_symtab): Adjust.
7279         (var_decode_location): Adjust.
7280         (new_symbol_full): Adjust.
7281         (dwarf2_const_value_data): Adjust.
7282         (dwarf2_const_value_attr): Adjust.
7283         (dwarf2_const_value): Adjust.
7284         (die_type): Adjust.
7285         (die_containing_type): Adjust.
7286         (build_error_marker_type): Adjust.
7287         (lookup_die_type): Adjust.
7288         (guess_full_die_structure_name): Adjust.
7289         (anonymous_struct_prefix): Adjust.
7290         (determine_prefix): Adjust.
7291         (dwarf2_name): Adjust.
7292         (follow_die_ref_or_sig): Adjust.
7293         (follow_die_offset): Adjust.
7294         (follow_die_ref): Adjust.
7295         (follow_die_sig_1): Adjust.
7296         (follow_die_sig): Adjust.
7297         (get_signatured_type): Adjust.
7298         (get_DW_AT_signature_type): Adjust.
7299         (decode_locdesc): Adjust.
7300         (dwarf_decode_macros): Adjust.
7301         (cu_debug_loc_section): Adjust.
7302         (fill_in_loclist_baton): Adjust.
7303         (dwarf2_symbol_mark_computed): Adjust.
7304         (init_one_comp_unit): Don't assign
7305         dwarf2_cu::dwarf2_per_objfile.
7306         (set_die_type): Adjust.
7307
7308 2018-01-07  Simon Marchi  <simon.marchi@ericsson.com>
7309
7310         * dwarf2read.c (struct mapped_debug_names): Add constructor.
7311         <dwarf2_per_objfile>: New field.
7312         (dwarf2_per_objfile): Remove global.
7313         (get_dwarf2_per_objfile): New function.
7314         (set_dwarf2_per_objfile): New function.
7315         (dwarf2_build_psymtabs_hard): Change objfile parameter to
7316         dwarf2_per_objfile.
7317         (abbrev_table_read_table): Add dwarf2_per_objfile parameter.
7318         (read_abbrev_offset): Likewise.
7319         (read_indirect_string): Likewise.
7320         (read_indirect_line_string): Likewise.
7321         (read_indirect_string_at_offset): Likewise.
7322         (read_indirect_string_from_dwz): Likewise.
7323         (dwarf2_find_containing_comp_unit): Change objfile parameter to
7324         dwarf2_per_objfile.
7325         (age_cached_comp_units): Add dwarf2_per_objfile parameter.
7326         (create_all_comp_units): Change objfile parameter to
7327         dwarf2_per_objfile.
7328         (create_all_type_units): Likewise.
7329         (process_queue): Add dwarf2_per_objfile parameter.
7330         (read_and_check_comp_unit_head): Likewise.
7331         (lookup_dwo_unit_in_dwp): Likewise.
7332         (get_dwp_file): Likewise.
7333         (process_cu_includes): Likewise.
7334         (struct free_dwo_file_cleanup_data): New struct.
7335         (dwarf2_has_info): Use get_dwarf2_per_objfile and
7336         set_dwarf2_per_objfile.
7337         (dwarf2_get_dwz_file): Add dwarf2_per_objfile parameter.
7338         (dw2_do_instantiate_symtab): Get dwarf2_per_objfile from
7339         context, adjust calls.
7340         (dw2_instantiate_symtab): Likewise.
7341         (dw2_get_cutu): Add dwarf2_per_objfile parameter.
7342         (dw2_get_cu): Likewise.
7343         (create_cu_from_index_list): Change objfile parameter to
7344         dwarf2_per_objfile.
7345         (create_cus_from_index_list): Get dwarf2_per_objfile from
7346         context, adjust calls.
7347         (create_cus_from_index): Likewise.
7348         (create_signatured_type_table_from_index): Change objfile
7349         parameter to dwarf2_per_objfile.
7350         (create_signatured_type_table_from_debug_names): Change objfile
7351         parameter to dwarf2_per_objfile.
7352         (create_addrmap_from_index): Likewise.
7353         (create_addrmap_from_aranges): Likewise.
7354         (dwarf2_read_index): Use get_dwarf2_per_objfile, adjust calls.
7355         (dw2_setup): Remove.
7356         (dw2_get_file_names_reader): Get dwarf2_per_objfile from
7357         context.
7358         (dw2_find_last_source_symtab): Get dwarf2_per_objfile using
7359         get_dwarf2_per_objfile.
7360         (dw2_forget_cached_source_info): Likewise.
7361         (dw2_map_symtabs_matching_filename): Likewise.
7362         (struct dw2_symtab_iterator) <index>: Remove.
7363         <dwarf2_per_objfile>: New field.
7364         (dw2_symtab_iter_init): Replace index parameter with
7365         dwarf2_per_objfile.
7366         (dw2_symtab_iter_next): Use dwarf2_per_objfile from iter.
7367         (dw2_lookup_symbol): Use get_dwarf2_per_objfile and adjust.
7368         (dw2_print_stats): Likewise.
7369         (dw2_dump): Likewise.
7370         (dw2_expand_symtabs_for_function): Likewise.
7371         (dw2_expand_all_symtabs): Likewise.
7372         (dw2_expand_symtabs_with_fullname): Likewise.
7373         (dw2_expand_marked_cus): Replace index and objfile parameters
7374         with dwarf2_per_objfile.
7375         (dw_expand_symtabs_matching_file_matcher): Add
7376         dwarf2_per_objfile parameter and adjust calls.
7377         (dw2_expand_symtabs_matching): Use get_dwarf2_per_objfile and
7378         adjust calls.
7379         (dw2_find_pc_sect_compunit_symtab): Don't call dw2_setup.
7380         (dw2_map_symbol_filenames): Use get_dwarf2_per_objfile and
7381         adjust calls.
7382         (create_cus_from_debug_names_list): Replace objfile parameter
7383         with dwarf2_per_objfile and adjust calls.
7384         (create_cus_from_debug_names): Likewise.
7385         (dwarf2_read_debug_names): Likewise.
7386         (mapped_debug_names::namei_to_name): Adjust call.
7387         (dw2_debug_names_iterator::next): Likewise.
7388         (dw2_debug_names_iterator::find_vec_in_debug_names): Likewise.
7389         (dw2_debug_names_lookup_symbol): Use get_dwarf2_per_objfile.
7390         (dw2_debug_names_dump): Likewise.
7391         (dw2_debug_names_expand_symtabs_for_function): Likewise.
7392         (dw2_debug_names_expand_symtabs_matching): Likewise.
7393         (dwarf2_initialize_objfile): Likewise.
7394         (dwarf2_build_psymtabs): Likewise.
7395         (get_abbrev_section_for_cu): Get dwarf2_per_objfile from
7396         this_cu.
7397         (error_check_comp_unit_head): Add dwarf2_per_objfile parameter.
7398         (read_and_check_comp_unit_head): Likewise.
7399         (read_abbrev_offset): Likewise.
7400         (create_debug_type_hash_table): Likewise.
7401         (create_debug_types_hash_table): Likewise.
7402         (create_all_type_units): Replace objfile parameter with
7403         dwarf2_per_objfile.
7404         (add_type_unit): Add dwarf2_per_objfile parameter.
7405         (fill_in_sig_entry_from_dwo_entry): Replace objfile parameter
7406         with dwarf2_per_objfile.
7407         (lookup_dwo_signatured_type): Get dwarf2_per_objfile from cu.
7408         (lookup_dwp_signatured_type): Likewise.
7409         (lookup_signatured_type): Likewise.
7410         (read_cutu_die_from_dwo): Likewise.
7411         (init_tu_and_read_dwo_dies): Likewise.
7412         (init_cutu_and_read_dies): Likewise.
7413         (init_cutu_and_read_dies_no_follow): Likewise.
7414         (allocate_type_unit_groups_table): Add objfile parameter.
7415         (create_type_unit_group): Use dwarf2_per_objfile from cu.
7416         (get_type_unit_group): Likewise.
7417         (process_psymtab_comp_unit): Update call.
7418         (build_type_psymtabs_reader): Use dwarf2_per_objfile from cu.
7419         (build_type_psymtabs_1): Add dwarf2_per_objfile parameter.
7420         (print_tu_stats): Likewise.
7421         (build_type_psymtab_dependencies): Use dwarf2_per_objfile passed
7422         in void* parameter.
7423         (build_type_psymtabs): Change objfile parameter to
7424         dwarf2_per_objfile.
7425         (process_skeletonless_type_unit): Use dwarf2_per_objfile
7426         passed in void* parameter.
7427         (process_skeletonless_type_units): Change objfile parameter to
7428         dwarf2_per_objfile.
7429         (set_partial_user): Likewise.
7430         (dwarf2_build_psymtabs_hard): Likewise.
7431         (read_comp_units_from_section): Likewise.
7432         (create_all_comp_units): Likewise.
7433         (scan_partial_symbols): Update calls.
7434         (add_partial_symbol): Likewise.
7435         (dwarf2_read_symtab): Use get_dwarf2_per_objfile.
7436         (maybe_queue_comp_unit): Use dwarf2_read_symtab from cu.
7437         (process_queue): Add dwarf2_per_objfile parameter.
7438         (get_compunit_symtab): Use dwarf2_per_objfile from cu.
7439         (compute_compunit_symtab_includes): Likewise.
7440         (process_cu_includes): Add dwarf2_per_objfile parameter.
7441         (process_full_comp_unit): Use dwarf2_per_objfile from cu.
7442         (process_full_type_unit): Likewise.
7443         (process_imported_unit_die): Update call.
7444         (handle_DW_AT_stmt_list): Use dwarf2_per_objfile from cu.
7445         (read_file_scope): Likewise.
7446         (allocate_dwo_file_hash_table): Add objfile parameter.
7447         (lookup_dwo_file_slot): Add dwarf2_per_objfile parameter.
7448         (create_cus_hash_table): Likewise.
7449         (create_dwp_hash_table): Likewise.
7450         (create_dwo_unit_in_dwp_v1): Likewise.
7451         (create_dwp_v2_section): Likewise.
7452         (create_dwo_unit_in_dwp_v2): Likewise.
7453         (lookup_dwo_unit_in_dwp): Likewise.
7454         (try_open_dwop_file): Likewise.
7455         (open_dwo_file): Likewise. Use dwarf2_per_objfile from cu.
7456         (open_and_init_dwo_file): Use dwarf2_per_objfile from cu, update
7457         cleanup to include a reference to dwarf2_per_objfile.
7458         (open_dwp_file): Add dwarf2_per_objfile parameter.
7459         (open_and_init_dwp_file): Likewise.
7460         (get_dwp_file): Likewise.
7461         (lookup_dwo_cutu): Use dwarf2_per_objfile from cu.
7462         (queue_and_load_all_dwo_tus): Update call.
7463         (free_dwo_file_cleanup): Use dwarf2_per_objfile from cleanup
7464         data.
7465         (dwarf2_rnglists_process): Use dwarf2_per_objfile from cu.
7466         (dwarf2_ranges_process): Likewise.
7467         (dwarf2_get_pc_bounds): Likewise.
7468         (mark_common_block_symbol_computed): Likewise.
7469         (abbrev_table_read_table): Add dwarf2_per_objfile parameter.
7470         (dwarf2_read_abbrevs): Update call.
7471         (read_partial_die): Use dwarf2_per_objfile from cu.
7472         (find_partial_die): Likewise.
7473         (fixup_partial_die): Likewise.
7474         (read_attribute_value): Likewise.
7475         (read_indirect_string_at_offset_from): Add objfile parameter.
7476         (read_indirect_string_at_offset): Add dwarf2_per_objfile
7477         parameter.
7478         (read_indirect_string_from_dwz): Add objfile parameter.
7479         (read_indirect_string): Add objfile parameter.
7480         (read_addr_index_1): Add dwarf2_per_objfile parameter.
7481         (read_addr_index): Use dwarf2_per_objfile from cu.
7482         (dwarf2_read_addr_index): Use dwarf2_per_objfile from cu, don't
7483         call dw2_setup.
7484         (read_str_index): Use dwarf2_per_objfile from cu.
7485         (get_debug_line_section): Likewise.
7486         (read_formatted_entries): Add dwarf2_per_objfile parameter.
7487         (dwarf_decode_line_header): Use dwarf2_per_objfile from cu.
7488         (new_symbol_full): Use dwarf2_per_objfile from cu.
7489         (build_error_marker_type): Likewise.
7490         (lookup_die_type): Likewise.
7491         (determine_prefix): Likewise.
7492         (follow_die_offset): Likewise.
7493         (dwarf2_fetch_die_loc_sect_off): Use get_dwarf2_per_objfile.
7494         (dwarf2_fetch_constant_bytes): Don't call dw2_setup.
7495         (dwarf2_fetch_die_type_sect_off): Likewise.
7496         (dwarf2_get_die_type): Likewise.
7497         (follow_die_sig_1): Use dwarf2_per_objfile from cu.
7498         (get_signatured_type): Likewise.
7499         (get_DW_AT_signature_type): Likewise.
7500         (dwarf_decode_macro_bytes): Add dwarf2_per_objfile parameter.
7501         (dwarf_decode_macros): Use dwarf2_per_objfile from cu.
7502         (cu_debug_loc_section): Likewise.
7503         (fill_in_loclist_baton): Likewise.
7504         (dwarf2_symbol_mark_computed): Likewise.
7505         (dwarf2_find_containing_comp_unit): Change objfile parameter to
7506         dwarf2_per_objfile.
7507         (free_cached_comp_units): Use dwarf2_per_objfile passed in void*
7508         parameter.
7509         (age_cached_comp_units): Add dwarf2_per_objfile parameter.
7510         (free_one_cached_comp_unit): Use dwarf2_per_objfile from cu.
7511         (dwarf2_free_objfile): Use get_dwarf2_per_objfile.
7512         (set_die_type): Use dwarf2_free_objfile from cu.
7513         (get_die_type_at_offset): Likewise.
7514         (dwarf2_per_objfile_free): Don't assign global variable.
7515         (debug_names) <constructor>: Add dwarf2_per_objfile
7516         parameter, update m_debugstrlookup construction.
7517         (debug_names::debug_str_lookup): Add dwarf2_per_objfile
7518         parameter.
7519         <m_dwarf2_per_objfile>: New field.
7520         <lookup>: Use m_dwarf2_per_objfile.
7521         (check_dwarf64_offsets): Add dwarf2_per_objfile parameter.
7522         (psyms_seen_size): Likewise.
7523         (write_gdbindex): Replace objfile parameter with
7524         dwarf2_per_objfile.
7525         (write_debug_names): Likewise.
7526         (write_psymtabs_to_index): Likewise.
7527         (save_gdb_index_command): Use get_dwarf2_per_objfile, update
7528         calls.
7529
7530 2018-01-07  Simon Marchi  <simon.marchi@ericsson.com>
7531
7532         * dwarf2read.c (struct dwarf2_cu) <objfile>: Remove.
7533         <dwarf2_per_objfile>: New field.
7534         (struct dwarf2_per_cu_data) <objfile>: Remove.
7535         <dwarf2_per_objfile>: New field.
7536         (create_cu_from_index_list): Assign dwarf2_per_objfile instead
7537         of objfile.
7538         (create_signatured_type_table_from_index): Likewise.
7539         (create_debug_type_hash_table): Likewise.
7540         (fill_in_sig_entry_from_dwo_entry): Likewise.
7541         (lookup_dwo_unit): Access objfile through dwarf2_per_objfile.
7542         (create_type_unit_group): Assign dwarf2_per_objfile instead of
7543         objfile.
7544         (create_partial_symtab): Access objfile through
7545         dwarf2_per_objfile.
7546         (process_psymtab_comp_unit_reader): Likewise.
7547         (read_comp_units_from_section): Likewise.
7548         (scan_partial_symbols): Likewise.
7549         (add_partial_symbol): Likewise.
7550         (add_partial_subprogram): Likewise.
7551         (peek_die_abbrev): Likewise.
7552         (fixup_go_packaging): Likewise.
7553         (process_full_comp_unit): Likewise.
7554         (process_full_type_unit): Likewise.
7555         (process_imported_unit_die): Likewise.
7556         (dwarf2_compute_name): Likewise.
7557         (dwarf2_physname): Likewise.
7558         (read_import_statement): Likewise.
7559         (create_cus_hash_table): Assign dwarf2_physname instead of
7560         objfile.
7561         (read_func_scope): Access objfile through dwarf2_per_objfile.
7562         (read_lexical_block_scope): Likewise.
7563         (read_call_site_scope): Likewise.
7564         (read_variable): Likewise.
7565         (dwarf2_rnglists_process): Likewise.
7566         (dwarf2_ranges_process): Likewise.
7567         (dwarf2_ranges_read): Likewise.
7568         (dwarf2_record_block_ranges): Likewise.
7569         (dwarf2_add_field): Likewise.
7570         (dwarf2_add_member_fn): Likewise.
7571         (read_structure_type): Likewise.
7572         (process_structure_scope): Likewise.
7573         (read_enumeration_type): Likewise.
7574         (read_array_type): Likewise.
7575         (read_common_block): Likewise.
7576         (read_namespace_type): Likewise.
7577         (read_namespace): Likewise.
7578         (read_module_type): Likewise.
7579         (read_tag_pointer_type): Likewise.
7580         (read_tag_ptr_to_member_type): Likewise.
7581         (read_tag_string_type): Likewise.
7582         (read_subroutine_type): Likewise.
7583         (read_typedef): Likewise.
7584         (read_base_type): Likewise.
7585         (attr_to_dynamic_prop): Likewise.
7586         (read_subrange_type): Likewise.
7587         (read_unspecified_type): Likewise.
7588         (load_partial_dies): Likewise.
7589         (read_partial_die): Likewise.
7590         (find_partial_die): Likewise.
7591         (guess_partial_die_structure_name): Likewise.
7592         (fixup_partial_die): Likewise.
7593         (read_attribute_value): Likewise.
7594         (read_addr_index_from_leb128): Likewise.
7595         (dwarf2_read_addr_index): Likewise.
7596         (dwarf2_string_attr): Likewise.
7597         (lnp_state_machine::check_line_address): Likewise.
7598         (dwarf_decode_lines_1): Likewise.
7599         (dwarf_decode_lines): Likewise.
7600         (dwarf2_start_symtab): Likewise.
7601         (var_decode_location): Likewise.
7602         (new_symbol_full): Likewise.
7603         (dwarf2_const_value_data): Likewise.
7604         (dwarf2_const_value_attr): Likewise.
7605         (dwarf2_const_value): Likewise.
7606         (die_type): Likewise.
7607         (die_containing_type): Likewise.
7608         (lookup_die_type): Likewise.
7609         (guess_full_die_structure_name): Likewise.
7610         (anonymous_struct_prefix): Likewise.
7611         (dwarf2_name): Likewise.
7612         (follow_die_ref_or_sig): Likewise.
7613         (follow_die_offset): Likewise.
7614         (follow_die_ref): Likewise.
7615         (dwarf2_fetch_die_loc_sect_off): Likewise.
7616         (dwarf2_fetch_constant_bytes): Likewise.
7617         (dwarf2_fetch_die_type_sect_off): Likewise.
7618         (dwarf2_get_die_type): Likewise.
7619         (follow_die_sig): Likewise.
7620         (decode_locdesc): Likewise.
7621         (dwarf2_per_cu_objfile): Likewise.
7622         (dwarf2_per_cu_text_offset): Likewise.
7623         (init_one_comp_unit): Assign dwarf2_per_objfile instead of
7624         objfile.
7625         (set_die_type): Access objfile through
7626         dwarf2_per_objfile.
7627
7628 2018-01-07  Simon Marchi  <simon.marchi@ericsson.com>
7629
7630         * valprint.c (converted_character_d): Remove typedef.
7631         (DEF_VEC_O (converted_character_d)): Remove.
7632         (count_next_character): Use std::vector.
7633         (print_converted_chars_to_obstack): Likewise.
7634         (generic_printstr): Likewise.
7635
7636 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
7637
7638         * xml-support.h (struct gdb_xml_value): Add constructor.
7639         <value>: Change type to unique_xmalloc_ptr.
7640         (gdb_xml_value_s): Remove typedef.
7641         (DEF_VEC_O (gdb_xml_value_s)): Remove.
7642         (gdb_xml_element_start_handler): Change parameter type to
7643         std::vector.
7644         (xml_find_attribute): Likewise.
7645         * xml-support.c (xml_find_attribute): Change parameter type to
7646         std::vector and adjust.
7647         (gdb_xml_values_cleanup): Remove.
7648         (gdb_xml_parser::start_element): Adjust to std::vector.
7649         (xinclude_start_include): Change paraeter type to std::vector
7650         and adjust.
7651         * btrace.c (check_xml_btrace_version): Likewise.
7652         (parse_xml_btrace_block): Likewise.
7653         (parse_xml_btrace_pt_config_cpu): Likewise.
7654         (parse_xml_btrace_pt): Likewise.
7655         (parse_xml_btrace_conf_bts): Likewise.
7656         (parse_xml_btrace_conf_pt): Likewise.
7657         * memory-map.c (memory_map_start_memory): Likewise.
7658         (memory_map_start_property): Likewise.
7659         * osdata.c (osdata_start_osdata): Likewise.
7660         (osdata_start_item): Likewise.
7661         (osdata_start_column): Likewise.
7662         * remote.c (start_thread): Likewise.
7663         * solib-aix.c (library_list_start_library): Likewise.
7664         (library_list_start_list): Likewise.
7665         * solib-svr4.c (library_list_start_library): Likewise.
7666         (svr4_library_list_start_list): Likewise.
7667         * solib-target.c (library_list_start_segment): Likewise.
7668         (library_list_start_section): Likewise.
7669         (library_list_start_library): Likewise.
7670         (library_list_start_list): Likewise.
7671         * tracepoint.c (traceframe_info_start_memory): Likewise.
7672         (traceframe_info_start_tvar): Likewise.
7673         * xml-syscall.c (syscall_start_syscall): Likewise.
7674         * xml-tdesc.c (tdesc_start_target): Likewise.
7675         (tdesc_start_feature): Likewise.
7676         (tdesc_start_reg): Likewise.
7677         (tdesc_start_union): Likewise.
7678         (tdesc_start_struct): Likewise.
7679         (tdesc_start_flags): Likewise.
7680         (tdesc_start_enum): Likewise.
7681         (tdesc_start_field): Likewise.
7682         (tdesc_start_enum_value): Likewise.
7683         (tdesc_start_vector): Likewise.
7684
7685 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
7686
7687         * extension.h (struct xmethod_worker) <clone>: Remove.
7688         * python/py-xmethods.c (struct python_xmethod_worker) <clone>:
7689         Remove.
7690         (python_xmethod_worker::clone): Remove.
7691         * valops.c (find_overload_match): Use std::move instead of
7692         clone.
7693
7694 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
7695
7696         * extension-priv.h (enum ext_lang_rc): Remove, move to extension.h.
7697         (struct extension_language_ops) <clone_xmethod_worker_data>: Remove.
7698         <free_xmethod_worker_data>: Remove.
7699         <get_matching_xmethod_workers>: Chance VEC to std::vector.
7700         <get_xmethod_arg_types>: Remove.
7701         <get_xmethod_result_type>: Remove.
7702         <invoke_xmethod>: Remove.
7703         * extension.c (new_xmethod_worker): Remove.
7704         (clone_xmethod_worker): Remove.
7705         (get_matching_xmethod_workers): Return void, pass std::vector by
7706         pointer.
7707         (get_xmethod_arg_types): Rename to...
7708         (xmethod_worker::get_arg_types): ... this, and adjust.
7709         (get_xmethod_result_type): Rename to...
7710         (xmethod_worker::get_result_type): ... this, and adjust.
7711         (invoke_xmethod): Remove.
7712         (free_xmethod_worker): Remove.
7713         (free_xmethod_worker_vec): Remove.
7714         * extension.h (enum ext_lang_rc): Move here from
7715         extension-priv.h.
7716         (struct xmethod_worker): Add constructor and destructor.
7717         <data>: Remove.
7718         <value>: Remove.
7719         <invoke, clone, do_get_result_type, do_get_arg_types>: New
7720         virtual pure methods.
7721         <get_arg_types, get_result_type>: New methods.
7722         (xmethod_worker_ptr): Remove typedef.
7723         (DEF_VEC_P (xmethod_worker_ptr)): Remove.
7724         (xmethod_worker_vec): Remove typedef.
7725         (xmethod_worker_up): New typedef.
7726         (invoke_xmethod): Remove.
7727         (clone_xmethod_worker): Remove.
7728         (free_xmethod_worker): Remove.
7729         (free_xmethod_worker_vec): Remove.
7730         (get_xmethod_arg_types): Remove.
7731         (get_xmethod_result_type): Remove.
7732         * valops.c (find_method_list): Use std::vector, don't use
7733         intermediate vector.
7734         (value_find_oload_method_list): Use std::vector.
7735         (find_overload_match): Use std::vector.
7736         (find_oload_champ): Use std::vector.
7737         * value.c (value_free): Use operator delete.
7738         (value_of_xmethod): Rename to...
7739         (value_from_xmethod): ... this.  Don't assign
7740         xmethod_worker::value, take rvalue-reference.
7741         (result_type_of_xmethod): Adjust.
7742         (call_xmethod): Adjust.
7743         * value.h: Include extension.h.
7744         (struct xmethod_worker): Don't forward-declare.
7745         (value_of_xmethod): Rename to...
7746         (value_from_xmethod): ... this, take rvalue-reference.
7747         * python/py-xmethods.c (struct gdbpy_worker_data): Rename to...
7748         (struct python_xmethod_worker): ... this, add constructor and
7749         destructor.
7750         <invoke, clone, do_get_arg_types, do_get_result_type>: Implement.
7751         (gdbpy_free_xmethod_worker_data): Rename to...
7752         (python_xmethod_worker::~python_xmethod_worker): ... this and
7753         adjust.
7754         (gdbpy_clone_xmethod_worker_data): Rename to...
7755         (python_xmethod_worker::clone): ... this and adjust.
7756         (gdbpy_get_matching_xmethod_workers): Use std::vector, don't use
7757         temporary vector.
7758         (gdbpy_get_xmethod_arg_types): Rename to...
7759         (python_xmethod_worker::do_get_arg_types): ... this and adjust.
7760         (gdbpy_get_xmethod_result_type): Rename to...
7761         (python_xmethod_worker::do_get_result_type): ... this and
7762         adjust.
7763         (gdbpy_invoke_xmethod): Rename to...
7764         (python_xmethod_worker::invoke): ... this and adjust.
7765         (new_python_xmethod_worker): Rename to...
7766         (python_xmethod_worker::python_xmethod_worker): ... this and
7767         adjust.
7768         * python/python-internal.h (gdbpy_clone_xmethod_worker_data):
7769         Remove.
7770         (gdbpy_free_xmethod_worker_data): Remove.
7771         (gdbpy_get_matching_xmethod_workers): Use std::vector.
7772         (gdbpy_get_xmethod_arg_types): Remove.
7773         (gdbpy_get_xmethod_result_type): Remove.
7774         (gdbpy_invoke_xmethod): Remove.
7775         * python/python.c (python_extension_ops): Remove obsolete
7776         callbacks.
7777
7778 2018-01-05  Pedro Alves  <palves@redhat.com>
7779
7780         PR gdb/18653
7781         * common/signals-state-save-restore.c
7782         (save_original_signals_state): New parameter 'quiet'.  Warn if we
7783         find a custom handler preinstalled, instead of internal erroring.
7784         But only warn if !quiet.
7785         * common/signals-state-save-restore.h
7786         (save_original_signals_state): New parameter 'quiet'.
7787         * main.c (captured_main_1): Move save_original_signals_state call
7788         after option handling, and pass QUIET.
7789
7790 2018-01-05  Pedro Alves  <palves@redhat.com>
7791
7792         * spu-tdep.c (spu_catch_start): Pass
7793         symbol_name_match_type::SEARCH_NAME to block_lookup_symbol.
7794
7795 2018-01-05  Pedro Alves  <palves@redhat.com>
7796
7797         PR gdb/22670
7798         * ada-lang.c (literal_symbol_name_matcher): New function.
7799         (ada_get_symbol_name_matcher): Use it for
7800         symbol_name_match_type::SEARCH_NAME.
7801         * block.c (block_lookup_symbol): New parameter 'match_type'.  Pass
7802         it down instead of assuming symbol_name_match_type::FULL.
7803         * block.h (block_lookup_symbol): New parameter 'match_type'.
7804         * c-valprint.c (print_unpacked_pointer): Use
7805         lookup_symbol_search_name instead of lookup_symbol.
7806         * compile/compile-object-load.c (get_out_value_type): Pass down
7807         symbol_name_match_type::SEARCH_NAME.
7808         * cp-namespace.c (cp_basic_lookup_symbol): Pass down
7809         symbol_name_match_type::FULL.
7810         * cp-support.c (cp_get_symbol_name_matcher): Handle
7811         symbol_name_match_type::SEARCH_NAME.
7812         * infrun.c (insert_exception_resume_breakpoint): Use
7813         lookup_symbol_search_name.
7814         * p-valprint.c (pascal_val_print): Use lookup_symbol_search_name.
7815         * psymtab.c (maintenance_check_psymtabs): Use
7816         symbol_name_match_type::SEARCH_NAME and SYMBOL_SEARCH_NAME.
7817         * stack.c (print_frame_args): Use lookup_symbol_search_name and
7818         SYMBOL_SEARCH_NAME.
7819         * symtab.c (lookup_local_symbol): Don't demangle the lookup name
7820         if symbol_name_match_type::SEARCH_NAME.
7821         (lookup_symbol_in_language): Pass down
7822         symbol_name_match_type::FULL.
7823         (lookup_symbol_search_name): New.
7824         (lookup_language_this): Pass down
7825         symbol_name_match_type::SEARCH_NAME.
7826         (lookup_symbol_aux, lookup_local_symbol): New parameter
7827         'match_type'.  Pass it down.
7828         * symtab.h (symbol_name_match_type::SEARCH_NAME): New enumerator.
7829         (lookup_symbol_search_name): New declaration.
7830         (lookup_symbol_in_block): New 'match_type' parameter.
7831
7832 2018-01-05  Pedro Alves  <palves@redhat.com>
7833
7834         PR gdb/22670
7835         * ada-lang.c (ada_lookup_encoded_symbol): Reimplement in terms of
7836         ada_lookup_symbol.
7837         (ada_lookup_symbol): Reimplement in terms of
7838         ada_lookup_symbol_list, bits factored out from
7839         ada_lookup_encoded_symbol.
7840
7841 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
7842
7843         * ada-exp.y (write_object_renaming): When subscripting an array
7844         using a symbol as the index, pass the block in call to
7845         ada_lookup_encoded_symbol when looking that symbol up.
7846
7847 2018-01-05  Jerome Guitton  <guitton@adacore.com>
7848
7849         * ada-lang.c (ada_array_length): Use ada_index_type instead of
7850         TYPE_INDEX_TYPE.
7851
7852 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
7853
7854         * ada-lang.c (ada_to_fixed_value_create): Add handling of
7855         the case where VALUE_LVAL (val0) is not lval_memory.
7856
7857 2018-01-05  Xavier Roirand  <roirand@adacore.com>
7858
7859         * ada-valprint.c (print_optional_low_bound): Handle
7860         character-indexed array printing like boolean-indexed array
7861         printing.
7862
7863 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
7864
7865         * NEWS: Create a new section for the next release branch.
7866         Rename the section of the current branch, now that it has
7867         been cut.
7868
7869 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
7870
7871         GDB 8.1 branch created (5219ac6237c272b938c28517bf371429260c71e7):
7872         * version.in: Bump version to 8.1.50.DATE-git.
7873
7874 2018-01-03  Xavier Roirand  <roirand@adacore.com>
7875
7876         * ada-lang.h (ada_exception_catchpoint_kind) <ada_catch_handlers>:
7877         Add field.
7878         * ada-lang.c (struct exception_support_info) <catch_handlers_sym>:
7879         Add field.
7880         (default_exception_support_info) <catch_handlers_sym>: Add field.
7881         (exception_support_info_fallback) <catch_handlers_sym>: Add field.
7882         (ada_exception_name_addr_1): Add "catch handlers" handling.
7883         (ada_exception_catchpoint_cond_string) <ex>: New parameter.
7884         Update all callers.
7885         (create_excep_cond_exprs) <ex>: Add parameter.
7886         (re_set_exception): Update create_excep_cond_exprs call.
7887         (print_it_exception, print_one_exception, print_mention_exception)
7888         (print_recreate_exception): Add "catch handler" handling.
7889         (allocate_location_catch_handlers, re_set_catch_handlers)
7890         (check_status_catch_handlers, print_it_catch_handlers)
7891         (print_one_catch_handlers, print_mention_catch_handlers)
7892         (print_recreate_catch_handlers): New function.
7893         (catch_handlers_breakpoint_ops): New variable.
7894         (catch_ada_exception_command_split) <is_catch_handlers_cmd>:
7895         Add parameter.  Add "catch handler" handling.
7896         (ada_exception_sym_name, ada_exception_breakpoint_ops):
7897         Add "catch handler" handling.
7898         (ada_exception_catchpoint_cond_string): Add "catch handler"
7899         handling.
7900         (create_ada_exception_catchpoint): Update create_excep_cond_exprs
7901         call.
7902         (catch_ada_handlers_command): New function.
7903         (initialize_ada_catchpoint_ops): Initialize "catch handlers"
7904         operations structure.
7905         (_initialize_ada_language): Add "catch handlers" command entry.
7906         * NEWS: Document "catch handlers" feature.
7907
7908 2018-01-02  Joel Brobecker  <brobecker@adacore.com>
7909
7910         * ada-lang.c (ada_value_slice_from_ptr): Take array stride into
7911         account when creating the array type of the slice.
7912         (ada_value_slice): Likewise.
7913
7914 2018-01-02  Joel Brobecker  <brobecker@adacore.com>
7915
7916         * gdbtypes.h (enum dynamic_prop_node_kind) <DYN_PROP_BYTE_STRIDE>:
7917         New enum value.
7918         (create_array_type_with_stride): Add byte_stride_prop parameter.
7919         * gdbtypes.c (create_array_type_with_stride) <byte_stride_prop>:
7920         New parameter.  Update all callers in this file.
7921         (array_type_has_dynamic_stride): New function.
7922         (is_dynamic_type_internal, resolve_dynamic_array): Add handling
7923         of arrays with dynamic byte strides.
7924         * dwarf2read.c (read_array_type): Add support for dynamic
7925         DW_AT_byte_stride attributes.
7926
7927 2018-01-02  Joel Brobecker  <brobecker@adacore.com>
7928
7929         * dwarf2read.c (read_unspecified_type): Treat
7930         DW_TAG_enumeration_type DIEs from Ada units as stubs.
7931
7932 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
7933
7934         Update copyright year range in all GDB files.
7935
7936 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
7937
7938         * copyright.py (BY_HAND): Remove gdb/testsuite/gdb.base/step-line.inp
7939         and gdb/testsuite/gdb.base/step-line.c.
7940
7941 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
7942
7943         * copyright.py (main): Dump the contents of
7944         MULTIPLE_COPYRIGHT_HEADERS (separately) from BY_HAND,
7945         even if BY_HAND is empty.
7946
7947 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
7948
7949         * top.c (print_gdb_version): Update Copyright year in version
7950         message.
7951
7952 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
7953
7954         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2017.
7955
7956 For older changes see ChangeLog-2017.
7957 \f
7958 Local Variables:
7959 mode: change-log
7960 left-margin: 8
7961 fill-column: 74
7962 version-control: never
7963 coding: utf-8
7964 End: