gdb/ChangeLog

   1 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
   2
   3         PR gdb/24839:
   4         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
   5         type.
   6
   7 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
   8
   9         * python/py-objfile.c (add_separate_debug_file): Fix comment about
  10         this function's Python signature.
  11
  12
  13 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
  14
  15         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
  16         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
  17         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
  18         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
  19         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
  20
  21
  22 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
  23
  24         * h8300-tdep.c (h8300_register_name_common): New.
  25         h8300_register_name): Use h8300_register_name_common.
  26         (h8300s_register_name): Likewise.
  27         (h8300sx_register_name): Likewise.
  28         (h8300h_register_nam): New.
  29         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
  30
  31
  32 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
  33
  34         * arm-tdep.c (arm_skip_cmse_entry): New function.
  35         (arm_is_sgstubs_section): New function.
  36         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
  37
  38 2019-07-22  Tom Tromey  <tom@tromey.com>
  39
  40         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
  41         Don't self-assign.
  42
  43 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
  44
  45         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
  46         type_print.
  47
  48 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
  49
  50         * symtab.c (search_symbols): Adjust msymbol matching type arrays
  51         so that GDB doesn't match any msymbols when searching in the
  52         TYPES_DOMAIN.
  53         (print_symbol_info): Print using typedef_print or type_print based
  54         on the type of the symbol.  Add updated FIXME comment moved from...
  55         (_initialize_symtab): ... move and update FIXME comment to above.
  56
  57 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
  58
  59         * NEWS: Mention adding -q option to "info types".
  60         * symtab.c (struct info_types_options): New struct.
  61         (info_types_options_defs): New variable.
  62         (make_info_types_options_def_group): New function.
  63         (info_types_command): Use gdb::option framework to parse options.
  64         (info_types_command_completer): New function.
  65         (_initialize_symtab): Extend the help text on "info types" and
  66         register command completer.
  67
  68 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
  69
  70         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
  71         (lookup_symbol_in_objfile): Change int to block_enum and add a
  72         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
  73
  74 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
  75
  76         * MAINTAINERS (Write After Approval): Add self.
  77
  78 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
  79
  80         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
  81         instruction to the dummy code region.
  82
  83 2019-07-19  Tom Tromey  <tromey@adacore.com>
  84
  85         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
  86         (ARGSUSED, PARAMS, __func__): Remove rules.
  87
  88 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
  89
  90         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
  91         * features/arm/arm-with-iwmmxt.c: Remove.
  92         * features/arm/arm-with-iwmmxt.xml: Remove.
  93         * features/arm/arm-with-m-fpa-layout.c: Remove.
  94         * features/arm/arm-with-m-fpa-layout.xml: Remove.
  95         * features/arm/arm-with-m-vfp-d16.c: Remove.
  96         * features/arm/arm-with-m-vfp-d16.xml: Remove.
  97         * features/arm/arm-with-m.c: Remove.
  98         * features/arm/arm-with-m.xml: Remove.
  99         * features/arm/arm-with-neon.c: Remove.
 100         * features/arm/arm-with-neon.xml: Remove.
 101         * features/arm/arm-with-vfpv2.c: Remove.
 102         * features/arm/arm-with-vfpv2.xml: Remove.
 103         * features/arm/arm-with-vfpv3.c: Remove.
 104         * features/arm/arm-with-vfpv3.xml: Remove.
 105
 106 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 107
 108         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
 109
 110 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 111
 112         * arch/aarch32.c (aarch32_create_target_description): Create
 113         target descriptions using features.
 114         * arch/arm.c (arm_create_target_description)
 115         (arm_create_mprofile_target_description): Likewise.
 116         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
 117
 118 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 119
 120         * Makefile.in: Add new files.
 121         * aarch32-tdep.c: New file.
 122         * aarch32-tdep.h: New file.
 123         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 124         Call aarch32_read_description.
 125         * arch/aarch32.c: New file.
 126         * arch/aarch32.h: New file.
 127         * arch/arm.c (arm_create_target_description)
 128         (arm_create_mprofile_target_description): New function.
 129         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
 130         (arm_create_target_description)
 131         (arm_create_mprofile_target_description): New declaration.
 132         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
 133         read_description functions.
 134         * arm-linux-nat.c (arm_linux_nat_target::read_description):
 135         Likewise.
 136         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 137         * arm-tdep.c (tdesc_arm_list): New variable.
 138         (arm_register_g_packet_guesses): Call create description functions.
 139         (arm_read_description) (arm_read_mprofile_description): New
 140         function.
 141         * arm-tdep.h (arm_read_description)
 142         (arm_read_mprofile_description): Add declaration.
 143         * configure.tgt: Add new files.
 144
 145 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
 146
 147         * top.c (new_ui_command): Open specified terminal just once.
 148
 149 2019-07-18  Tom Tromey  <tromey@adacore.com>
 150
 151         * symtab.c (main_name): Constify return type.
 152         * symfile.c (set_initial_language): Update.
 153         * symtab.h (main_name): Constify return type.
 154
 155 2019-07-17  Tom Tromey  <tom@tromey.com>
 156
 157         * tui/tui-winsource.c (tui_update_source_window)
 158         (tui_update_source_window_as_is)
 159         (tui_update_source_windows_with_line): Remove return.
 160         * tui/tui-disasm.c (tui_show_disassem)
 161         (tui_show_disassem_and_update_source): Remove return.
 162         * tui/tui.c (tui_reset): Remove return.
 163         * tui/tui-wingeneral.c
 164         (tui_check_and_display_highlight_if_needed): Remove return.
 165
 166 2019-07-17  Tom Tromey  <tom@tromey.com>
 167
 168         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
 169
 170 2019-07-17  Tom Tromey  <tom@tromey.com>
 171
 172         * tui/tui-winsource.h (struct tui_exec_info_window)
 173         (struct tui_source_window_base): Move from tui-data.h.
 174         * tui/tui-winsource.c: Move many method definitions from
 175         elsewhere.  Remove "structuring" comments.
 176         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
 177         (tui_source_window_base::refresh_window): Move to
 178         tui-winsource.c.
 179         * tui/tui-win.c (tui_source_window_base::refresh_all)
 180         (tui_source_window_base::update_tab_width)
 181         (tui_source_window_base::set_new_height)
 182         (tui_source_window_base::do_make_visible_with_new_height): Move to
 183         tui-winsource.c.
 184         * tui/tui-source.h: Update.
 185         * tui/tui-source.c (tui_source_window_base::reset): Move to
 186         tui-winsource.c.
 187         * tui/tui-disasm.h: Update.
 188         * tui/tui-data.h (struct tui_exec_info_window): Move to
 189         tui-winsource.h.
 190         (struct tui_source_window_base): Likewise.
 191         * tui/tui-data.c (tui_source_window_base::clear_detail)
 192         (tui_source_window_base, ~tui_source_window_base): Move to
 193         tui-winsource.c.
 194
 195 2019-07-17  Tom Tromey  <tom@tromey.com>
 196
 197         * tui/tui-win.c (tui_resize_all)
 198         (tui_source_window_base::update_tab_width)
 199         (tui_adjust_win_heights): Update.
 200         (tui_win_info::make_invisible_and_set_new_height): Rename from
 201         make_invisible_and_set_new_height.
 202         * tui/tui-data.h (struct tui_win_info)
 203         <make_invisible_and_set_new_height>: New method.
 204
 205 2019-07-17  Tom Tromey  <tom@tromey.com>
 206
 207         * tui/tui.c: Update.
 208         * tui/tui-source.h (struct tui_source_window): Move from
 209         tui-data.h.
 210         * tui/tui-layout.c: Update.
 211         * tui/tui-disasm.c: Update.
 212         * tui/tui-data.h (struct tui_source_window): Move to
 213         tui-source.h.
 214
 215 2019-07-17  Tom Tromey  <tom@tromey.com>
 216
 217         * tui/tui-disasm.h (struct tui_disasm_window): Move from
 218         tui-data.h.
 219         * tui/tui-data.h (struct tui_disasm_window): Move to
 220         tui-disasm.h.
 221
 222 2019-07-17  Tom Tromey  <tom@tromey.com>
 223
 224         * tui/tui-regs.h (struct tui_data_item_window): Move from
 225         tui-data.h.
 226         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
 227         * tui/tui-data.h (struct tui_data_item_window): Move to
 228         tui-regs.h.
 229         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
 230
 231 2019-07-17  Tom Tromey  <tom@tromey.com>
 232
 233         * tui/tui.c: Update.
 234         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
 235         (tui_cmd_window::max_height): Move to tui-command.c.
 236         * tui/tui-layout.c: Update.
 237         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
 238         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
 239         tui-command.c.
 240         * tui/tui-command.h (struct tui_cmd_window): Move from
 241         tui-data.h.
 242         * tui/tui-command.c: Remove "structuring" comments.
 243         (tui_cmd_window::clear_detail)
 244         (tui_cmd_window::do_make_visible_with_new_height)
 245         (tui_cmd_window::max_height): Move from elsewhere.
 246
 247 2019-07-17  Tom Tromey  <tom@tromey.com>
 248
 249         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
 250         Now static.
 251         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
 252         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
 253
 254 2019-07-17  Tom Tromey  <tom@tromey.com>
 255
 256         * tui/tui.c: Update.
 257         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
 258         tui-regs.c.
 259         * tui/tui-windata.h: Remove file.
 260         * tui/tui-windata.c: Remove file.
 261         * tui/tui-win.c (tui_data_window::set_new_height)
 262         (tui_data_window::do_make_visible_with_new_height): Move to
 263         tui-regs.c.
 264         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
 265         * tui/tui-regs.c: Remove "structuring" comments.
 266         (tui_data_window::first_data_item_displayed)
 267         (tui_data_window::delete_data_content_windows)
 268         (tui_data_window::erase_data_content)
 269         (tui_data_window::display_all_data)
 270         (tui_data_window::refresh_all)
 271         (tui_data_window::do_scroll_vertical)
 272         (tui_data_window::clear_detail, tui_data_window::set_new_height)
 273         (tui_data_window::do_make_visible_with_new_height)
 274         (tui_data_window::refresh_window): Move from elsewhere.
 275         (_initialize_tui_regs): Move to end of file.
 276         * tui/tui-layout.c: Update.
 277         * tui/tui-hooks.c: Update.
 278         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
 279         * tui/tui-data.c (tui_data_window::clear_detail): Move to
 280         tui-regs.c.
 281         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
 282
 283 2019-07-17  Tom Tromey  <tom@tromey.com>
 284
 285         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
 286         seen.
 287
 288 2019-07-17  Tom Tromey  <tom@tromey.com>
 289
 290         * tui/tui-win.c (tui_source_window_base::set_new_height)
 291         (tui_source_window_base::do_make_visible_with_new_height): Use
 292         m_has_locator field directly.
 293         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
 294         method.
 295         (struct tui_source_window_base) <has_locator>: Likewise.
 296
 297 2019-07-17  Tom Tromey  <tom@tromey.com>
 298
 299         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
 300         Don't declare.
 301         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
 302         Remove.
 303         * tui/tui-win.c (tui_source_window_base::set_new_height)
 304         (tui_source_window_base::set_new_height)
 305         (make_invisible_and_set_new_height)
 306         (tui_source_window_base::do_make_visible_with_new_height)
 307         (tui_source_window_base::do_make_visible_with_new_height):
 308         Update.
 309         * tui/tui-layout.c (show_source_disasm_command, show_data)
 310         (show_source_or_disasm_and_command): Update.
 311         * tui/tui-layout.c (show_layout): Update.
 312
 313 2019-07-17  Tom Tromey  <tom@tromey.com>
 314
 315         * tui/tui-layout.c (make_data_window): Remove.
 316         (show_data): Unify creation and re-initialization cases.
 317
 318 2019-07-17  Tom Tromey  <tom@tromey.com>
 319
 320         * tui/tui-layout.c (make_source_window, make_disasm_window):
 321         Remove.
 322         (show_data): Unify creation and re-initialization cases.
 323
 324 2019-07-17  Tom Tromey  <tom@tromey.com>
 325
 326         * tui/tui-layout.c (make_command_window): Remove.
 327         (show_source_disasm_command, show_source_or_disasm_and_command):
 328         Unify creation and re-initialization cases.
 329
 330 2019-07-17  Tom Tromey  <tom@tromey.com>
 331
 332         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
 333         creation and re-initialization cases.
 334
 335 2019-07-17  Tom Tromey  <tom@tromey.com>
 336
 337         * tui/tui-regs.c (tui_get_register): Return void.
 338
 339 2019-07-17  Tom Tromey  <tom@tromey.com>
 340
 341         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
 342         Simplify.
 343
 344 2019-07-17  Tom Tromey  <tom@tromey.com>
 345
 346         * tui/tui-layout.c (show_source_disasm_command): Simplify window
 347         resetting.
 348
 349 2019-07-17  Tom Tromey  <tom@tromey.com>
 350
 351         * tui/tui.h (tui_set_layout_by_name): Don't declare.
 352         * tui/tui-regs.c (tui_reg_layout): New function.
 353         (tui_show_registers, tui_reg_command): Use it.
 354         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
 355         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
 356         parameters.
 357         (tui_layout_command): Remove.
 358
 359 2019-07-17  Tom Tromey  <tom@tromey.com>
 360
 361         * tui/tui-layout.h (tui/tui-layout): Return void.
 362         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
 363
 364 2019-07-17  Tom Tromey  <tom@tromey.com>
 365
 366         * tui/tui-layout.c (show_source_disasm_command, show_data):
 367         Update.
 368         (reset_locator): Remove.
 369         (show_source_or_disasm_and_command): Update.
 370
 371 2019-07-17  Tom Tromey  <tom@tromey.com>
 372
 373         * tui/tui-source.c (tui_source_window_base::reset): Remove
 374         win_type parameter.
 375         * tui/tui-layout.c (make_command_window, make_source_window)
 376         (make_disasm_window, make_data_window)
 377         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
 378         (reset_locator, show_source_or_disasm_and_command): Update.
 379         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
 380         win_type parameter.
 381         (struct tui_source_window_base) <reset>: Likewise.
 382
 383 2019-07-17  Tom Tromey  <tom@tromey.com>
 384
 385         * tui/tui-layout.c (show_source_disasm_command): Use
 386         reset_locator.
 387         (reset_locator): New function.
 388         (init_and_make_win): Remove.
 389         (show_source_or_disasm_and_command): Use reset_locator.
 390
 391 2019-07-17  Tom Tromey  <tom@tromey.com>
 392
 393         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
 394         condition.
 395         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
 396         Remove condition.
 397         * tui/tui-source.c (tui_source_window_base::reset): New method.
 398         * tui/tui-layout.c (make_command_window): Don't call
 399         init_and_make_win.
 400         (make_source_window, make_disasm_window): Don't call
 401         make_source_or_disasm_window.
 402         (make_data_window): Don't call init_and_make_win.  Change calling
 403         convention.
 404         (show_source_disasm_command, show_data): Simplify.
 405         (make_source_or_disasm_window): Remove.
 406         (show_source_or_disasm_and_command): Simplify.
 407         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
 408         (struct tui_source_window_base) <reset>: Likewise.
 409         <execution_info>: Remove initializer.
 410         * tui/tui-data.c (tui_source_window_base): Initialize
 411         execution_info.
 412
 413 2019-07-17  Tom Tromey  <tom@tromey.com>
 414
 415         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
 416         variable.
 417
 418 2019-07-17  Tom Tromey  <tom@tromey.com>
 419
 420         * tui/tui.c (tui_rl_other_window): Update.
 421         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
 422         superclass method first.  Always iterate over regs_content.
 423         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
 424         method.
 425         * tui/tui-win.c (tui_set_focus_command): Update.
 426
 427 2019-07-17  Tom Tromey  <tom@tromey.com>
 428
 429         * tui/tui-win.c (tui_set_focus_command): Rename from
 430         tui_set_focus.  Call tui_enable.
 431         (tui_set_focus_command): Remove.
 432
 433 2019-07-17  Tom Tromey  <tom@tromey.com>
 434
 435         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
 436         refresh_window.
 437         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
 438         touchwin.
 439         (tui_data_window::refresh_window): Call refresh_window on data
 440         items.  Always call superclass refresh_window.
 441         (tui_win_info::refresh): Remove.
 442         (tui_source_window_base::refresh_window): Update.
 443         (tui_refresh_all): Update.
 444         * tui/tui-layout.c (show_source_disasm_command): Remove call to
 445         refresh_window.
 446         (show_source_or_disasm_and_command): Likewise.
 447         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 448         (struct tui_source_window_base) <refresh>: Likewise.
 449
 450 2019-07-17  Tom Tromey  <tom@tromey.com>
 451
 452         * tui/tui-winsource.c (tui_clear_source_content)
 453         (tui_show_source_content): Update.
 454         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 455         whether content is empty.
 456         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 457         Remove.
 458
 459 2019-07-17  Tom Tromey  <tom@tromey.com>
 460
 461         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 462         window's contents.
 463         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 464         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 465
 466 2019-07-17  Tom Tromey  <tom@tromey.com>
 467
 468         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 469         (struct tui_data_item_window): Update.
 470
 471 2019-07-17  Tom Tromey  <tom@tromey.com>
 472
 473         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 474         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 475         defines.
 476
 477 2019-07-17  Tom Tromey  <tom@tromey.com>
 478
 479         * tui/tui-winsource.h (tui_erase_source_content)
 480         (tui_clear_source_content): Remove "display_prompt" parameter.
 481         * tui/tui-winsource.c (tui_update_source_window_as_is)
 482         (tui_update_source_windows_with_addr): Update.
 483         (tui_clear_source_content): Remove "display_prompt" parameter.
 484         (tui_erase_source_content): Likewise.  Simplify.
 485         (tui_show_source_content): Update.
 486         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 487         * tui/tui-stack.c (tui_show_frame_info): Update.
 488         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 489         Remove defines.
 490
 491 2019-07-17  Tom Tromey  <tom@tromey.com>
 492
 493         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 494         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 495         parameter.
 496         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 497         parameter.
 498
 499 2019-07-17  Tom Tromey  <tom@tromey.com>
 500
 501         * tui/tui-winsource.c (tui_clear_source_content)
 502         (tui_show_source_content, tui_show_exec_info_content)
 503         (tui_clear_exec_info_content): Update.
 504         * tui/tui-stack.c (tui_show_locator_content): Update.
 505         (tui_show_frame_info): Update.
 506         * tui/tui-source.h (tui_source_window): Don't declare.
 507         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 508         from tui_source_is_displayed.
 509         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 510         Remove field.
 511         (struct tui_source_window_base) <content_in_use>: New field.  Now
 512         bool.
 513         (struct tui_source_window) <showing_source_p>: New method.
 514         (TUI_SRC_WIN): Change cast.
 515         * tui/tui-data.c (tui_initialize_static_data): Update.
 516
 517 2019-07-17  Tom Tromey  <tom@tromey.com>
 518
 519         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 520         location_matches_p.
 521         * tui/tui-source.c (tui_source_window::location_matches_p): New
 522         method.
 523         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 524         method.
 525         * tui/tui-data.h (struct tui_source_window_base)
 526         <location_matches_p>: New method.
 527         (struct tui_source_window, struct tui_disasm_window)
 528         <location_matches_p>: Likewise.
 529
 530 2019-07-17  Tom Tromey  <tom@tromey.com>
 531
 532         * tui/tui-win.c (tui_set_win_height_command): Rename from
 533         tui_set_win_height.
 534         (tui_set_win_height_command): Remove.
 535
 536 2019-07-17  Tom Tromey  <tom@tromey.com>
 537
 538         * tui/tui-source.c (tui_source_window): New constructor.  Add
 539         observer.
 540         (~tui_source_window): New destructor.
 541         (tui_source_window::style_changed): New method.
 542         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 543         (tui_attach_detach_observers): Update.
 544         * tui/tui-data.h (struct tui_source_window): Make constructor not
 545         inline.  Add destructor.
 546         (struct tui_source_window) <style_changed>: New method.
 547         <m_observable>: New member.
 548
 549 2019-07-17  Tom Tromey  <tom@tromey.com>
 550
 551         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 552         * tui/tui-win.c (tui_resize_all): Fix typo.
 553
 554 2019-07-17  Tom Tromey  <tom@tromey.com>
 555
 556         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 557         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 558         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 559         * tui/tui-win.c (window_name_completer): Use foreach.
 560         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 561         (update_tab_width): Likewise.
 562         * tui/tui-layout.c (show_layout): Update.
 563         * tui/tui-data.h (class tui_window_iterator): New.
 564         (struct all_tui_windows): New.
 565         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 566
 567 2019-07-17  Tom Tromey  <tom@tromey.com>
 568
 569         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 570         parameter.  Don't reference globals.
 571         (tui_reg_command): Update.
 572
 573 2019-07-17  Tom Tromey  <tom@tromey.com>
 574
 575         * tui/tui-regs.c (tui_show_registers): Simplify.
 576
 577 2019-07-17  Tom Tromey  <tom@tromey.com>
 578
 579         * tui/tui-regs.c (tui_show_registers): Update.
 580         (tui_show_register_group): Add win_info parameter.
 581
 582 2019-07-17  Tom Tromey  <tom@tromey.com>
 583
 584         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 585         Rename from tui_display_reg_element_at_line.
 586         (tui_data_window::display_registers_from_line): Update.
 587         * tui/tui-data.h (struct tui_data_window)
 588         <display_reg_element_at_line>: New method.
 589
 590 2019-07-17  Tom Tromey  <tom@tromey.com>
 591
 592         * tui/tui-regs.h (tui_display_registers_from)
 593         (tui_display_registers_from_line): Don't declare.
 594         * tui/tui-windata.c (tui_data_window::display_all_data)
 595         (tui_data_window::refresh_all)
 596         (tui_data_window::do_scroll_vertical): Update.
 597         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 598         from tui_display_registers_from.
 599         (tui_display_reg_element_at_line): Update.
 600         (tui_data_window::display_registers_from_line): Rename from
 601         tui_display_registers_from_line.
 602         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 603         display_registers_from_line>: New methods.
 604
 605 2019-07-17  Tom Tromey  <tom@tromey.com>
 606
 607         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 608         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 609         from tui_erase_data_content.
 610         (tui_data_window::display_all_data)
 611         (tui_data_window::refresh_all)
 612         (tui_data_window::do_scroll_vertical): Update.
 613         * tui/tui-regs.c (tui_show_registers): Update.
 614         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 615         New method.
 616
 617 2019-07-17  Tom Tromey  <tom@tromey.com>
 618
 619         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 620         declare.
 621         * tui/tui-windata.c
 622         (tui_data_window::delete_data_content_windows): Rename from
 623         tui_delete_data_content_windows.
 624         (tui_data_window::display_all_data)
 625         (tui_data_window::do_scroll_vertical): Update.
 626         * tui/tui-data.h (struct tui_data_window)
 627         <delete_data_content_windows>: New method.
 628
 629 2019-07-17  Tom Tromey  <tom@tromey.com>
 630
 631         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 632         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 633
 634 2019-07-17  Tom Tromey  <tom@tromey.com>
 635
 636         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 637         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 638         from tui_display_all_data.
 639         * tui/tui-win.c
 640         (tui_data_window::do_make_visible_with_new_height): Update.
 641         * tui/tui-regs.c (tui_show_registers): Update.
 642         * tui/tui-layout.c (tui_set_layout): Update.
 643         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 644         method.
 645
 646 2019-07-17  Tom Tromey  <tom@tromey.com>
 647
 648         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 649         * tui/tui-windata.c (tui_display_data_from): Remove.
 650         (tui_data_window::refresh_all): Update.
 651
 652 2019-07-17  Tom Tromey  <tom@tromey.com>
 653
 654         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 655         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 656         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 657         tui_display_registers_from_line.
 658         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 659         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 660         "force_display" parameter.
 661
 662 2019-07-17  Tom Tromey  <tom@tromey.com>
 663
 664         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 665         declare.
 666         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 667         Rename from tui_first_reg_element_no_inline.
 668         (tui_display_reg_element_at_line)
 669         (tui_display_registers_from_line): Update.
 670         * tui/tui-data.h (struct tui_data_window)
 671         <first_reg_element_no_inline>: New method.
 672
 673 2019-07-17  Tom Tromey  <tom@tromey.com>
 674
 675         * tui/tui-windata.c (tui_display_data_from)
 676         (tui_data_window::do_scroll_vertical): Update.
 677         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 678         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 679         Rename from tui_line_from_reg_element_no.
 680         (tui_display_registers_from_line): Update.
 681         * tui/tui-data.h (struct tui_data_window)
 682         <line_from_reg_element_no>: New method.
 683
 684 2019-07-17  Tom Tromey  <tom@tromey.com>
 685
 686         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 687         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 688         tui_last_regs_line_no.
 689         (tui_display_reg_element_at_line)
 690         (tui_display_registers_from_line): Update.
 691         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 692         method.
 693
 694 2019-07-17  Tom Tromey  <tom@tromey.com>
 695
 696         PR tui/24722:
 697         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 698         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 699         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 700         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 701         (tui_update_breakpoint_info): Likewise.
 702         * tui/tui-hooks.c (tui_event_create_breakpoint)
 703         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 704         Update.
 705
 706 2019-07-17  Tom Tromey  <tom@tromey.com>
 707
 708         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 709
 710 2019-07-17  Tom Tromey  <tom@tromey.com>
 711
 712         * tui/tui-winsource.c (tui_update_source_window_as_is)
 713         (tui_update_source_windows_with_addr): Update.
 714         * tui/tui-source.h (tui_set_source_content)
 715         (tui_show_symtab_source): Add "win_info" parameter.
 716         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 717         parameter.
 718         (tui_show_symtab_source): Likewise.
 719
 720 2019-07-17  Tom Tromey  <tom@tromey.com>
 721
 722         * tui/tui-wingeneral.c
 723         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 724
 725 2019-07-17  Tom Tromey  <tom@tromey.com>
 726
 727         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 728         (struct tui_cmd_window) <can_scroll>: New method.
 729         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 730         method.
 731
 732 2019-07-17  Tom Tromey  <tromey@adacore.com>
 733
 734         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 735         do_field_signed>: Rename.  Change type of "value".
 736         * ui-out.c (ui_out::field_signed): Rename from field_int.
 737         Change type of "value".
 738         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 739         type of "value".
 740         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 741         do_field_int.  Change type of "value".
 742         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 743         do_field_int.  Change type of "value".
 744         * tracepoint.c (trace_status_mi, tfind_1)
 745         (print_one_static_tracepoint_marker): Update.
 746         * thread.c (print_thread_info_1, print_selected_thread_frame):
 747         Update.
 748         * stack.c (print_frame, print_frame_info): Update.
 749         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 750         Update.
 751         * source.c (print_source_lines_base): Update.
 752         * skip.c (info_skip_command): Update.
 753         * record-btrace.c (btrace_ui_out_decode_error)
 754         (btrace_call_history_src_line): Update.
 755         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 756         Update.
 757         * progspace.c (print_program_space): Update.
 758         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 759         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 760         do_field_int.  Change type of "value".
 761         * mi/mi-out.c (mi_ui_out::do_table_begin)
 762         (mi_ui_out::do_table_header): Update.
 763         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 764         type of "value".
 765         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 766         (mi_cmd_data_list_changed_registers, output_register)
 767         (mi_cmd_data_read_memory, mi_load_progress)
 768         (mi_cmd_trace_frame_collected): Update.
 769         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 770         Update.
 771         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 772         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 773         (mi_cmd_var_list_children, varobj_update_one): Update.
 774         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 775         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 776         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 777         * inferior.c (print_inferior): Update.
 778         * gdb_bfd.c (print_one_bfd): Update.
 779         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 780         Update.
 781         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 782         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 783         do_field_int.  Change type of "value".
 784         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 785         do_field_int.  Change type of "value".
 786         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 787         (print_one_breakpoint_location, print_it_catch_fork)
 788         (print_one_catch_fork, print_it_catch_vfork)
 789         (print_one_catch_vfork, print_it_catch_solib)
 790         (print_it_catch_exec, print_it_ranged_breakpoint)
 791         (print_mention_watchpoint, print_mention_masked_watchpoint)
 792         (bkpt_print_it, update_static_tracepoint): Update.
 793         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 794         * break-catch-syscall.c (print_it_catch_syscall): Update.
 795         * ada-tasks.c (print_ada_task_info): Update.
 796         * ada-lang.c (print_it_exception, print_mention_exception):
 797         Update.
 798
 799 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 800
 801         PR breakpoints/24541
 802         * gdbarch.c: Regenerate.
 803         * gdbarch.h: Regenerate.
 804         * gdbarch.sh: Adjust return type and parameter types for
 805         'stap_adjust_register'.
 806         (i386_stap_adjust_register): Adjust signature and return new
 807         register name.
 808         * stap-probe.c (stap_parse_register_operand): Adjust use of
 809         'gdbarch_stap_adjust_register'.
 810
 811 2019-07-17  Tom Tromey  <tromey@adacore.com>
 812
 813         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 814         declare VEC.
 815         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 816         std::vector.
 817         (struct s390_process_info): Add initializers.
 818         (s390_add_process): Use new.
 819         (s390_linux_nat_target::low_forget_process): Use delete.
 820         (s390_linux_nat_target::low_new_fork)
 821         (s390_linux_nat_target::stopped_by_watchpoint)
 822         (s390_linux_nat_target::low_prepare_to_resume)
 823         (s390_linux_nat_target::insert_watchpoint)
 824         (s390_linux_nat_target::insert_hw_breakpoint)
 825         (s390_linux_nat_target::remove_watchpoint)
 826         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 827
 828 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 829
 830         * aarch64-fbsd-nat.c: Include regcache.h.
 831         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 832         argument.
 833         (aarch64_fbsd_nat_target::fetch_registers)
 834         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 835         variable.
 836         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 837
 838 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 839
 840         * fbsd-nat.c: Include gdbarch.h.
 841
 842 2019-07-15  Tom Tromey  <tromey@adacore.com>
 843
 844         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 845
 846 2019-07-15  Tom Tromey  <tromey@adacore.com>
 847
 848         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 849         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 850         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 851         * cli-out.c (cli_ui_out::do_field_int): New method.
 852         * ui-out.c (ui_out::field_unsigned): New method.
 853         * symfile.c (generic_load): Use field_unsigned.
 854         (print_transfer_performance): Likewise.
 855         * record-btrace.c (ui_out_field_uint): Remove.
 856         (btrace_call_history_insn_range, btrace_call_history): Use
 857         field_unsigned.
 858         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 859         field_unsigned.
 860         * ui-out.h (class ui_out) <field_unsigned>: New method.
 861         <do_field_unsigned>: Likewise.
 862
 863 2019-07-15  Tom Tromey  <tromey@adacore.com>
 864
 865         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 866         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 867         * target.c (flash_erase_command): Use field_string.
 868         * infrun.c (print_signal_received_reason): Use field_string.
 869         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 870         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 871         field_string.
 872         * ada-tasks.c (print_ada_task_info): Use field_string.
 873
 874 2019-07-15  Tom Tromey  <tromey@adacore.com>
 875
 876         * target.c (flash_erase_command): Use field_core_addr.
 877         * symfile.c (generic_load): Use field_core_addr.
 878         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 879         Use field_core_addr.
 880         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 881         field_core_addr.
 882
 883 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 884
 885         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 886         value if its desired type is smaller than a CORE_ADDR and signed.
 887
 888 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 889
 890         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 891         of changes to field names, and use new is_reference field to
 892         decide if a property is a reference or not.
 893         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 894         field.
 895         (struct dwarf2_property_baton): Update header comment, rename
 896         'referenced_type' to 'property_type' and update comments.
 897         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 898         default property type, store in property baton, update to take
 899         accound of renamed field.
 900         (read_func_scope): Update call to attr_to_dynamic_prop.
 901         (read_array_type): Likewise.
 902         (dwarf2_per_cu_addr_sized_int_type): New function.
 903         (read_subrange_index_type): Move type finding code to
 904         dwarf2_per_cu_addr_sized_int_type.
 905         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 906         (dwarf2_per_cu_addr_type): New function.
 907         (set_die_type): Update calls to attr_to_dynamic_prop.
 908
 909 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 910
 911         * dwarf2read.c (read_subrange_index_type): New function.
 912         (read_subrange_type): Move code into new function and call it.
 913         * gdbtypes.c (create_range_type): Add some asserts.
 914
 915 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 916
 917         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 918         update return statements.
 919         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 920         declaration, and update comment to match.
 921         * gdbtypes.c (resolve_dynamic_array): Update call to
 922         dwarf2_evaluate_property to match new return type.
 923
 924 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 925
 926         * valarith.c (value_subscripted_rvalue): Change lowerbound
 927         parameter type from int to LONGEST.
 928         * value.h (value_subscripted_rvalue): Likewise in declaration.
 929
 930 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 931
 932         * cli/cli-utils.c (info_print_command_completer): New function.
 933         * cli/cli-utils.h: Add 'completer.h' include, and forward
 934         declaration for 'struct cmd_list_element'.
 935         (info_print_command_completer): Declare.
 936         * stack.c (_initialize_stack): Add completer for 'info locals' and
 937         'info args'.
 938         * symtab.c (_initialize_symtab): Add completer for 'info
 939         variables' and 'info functions'.
 940         * NEWS: Mention completion for additional info commands.
 941
 942 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 943
 944         * cli/cli-utils.c (extract_info_print_args): Delete.
 945         (extract_arg_maybe_quoted): Delete.
 946         (info_print_options_defs): New variable.
 947         (make_info_print_options_def_group): New function.
 948         (extract_info_print_options): Define new function.
 949         * cli/cli-utils.h (extract_info_print_args): Delete.
 950         (struct info_print_options): New structure.
 951         (extract_info_print_options): Declare new function.
 952         * stack.c (info_locals_command): Update to use new
 953         extract_info_print_options, also add a header comment.
 954         (info_args_command): Likewise.
 955         * symtab.c (info_variables_command): Likewise.
 956         (info_functions_command): Likewise.
 957
 958 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 959
 960         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 961         to extract string arguments.
 962         * common/common-utils.c (extract_string_maybe_quoted): New function.
 963         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 964
 965 2019-07-11  Tom Tromey  <tromey@adacore.com>
 966
 967         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 968         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 969         * top.h (gdbinit): Don't declare.
 970         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 971         into...
 972         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 973         * top.c (gdb_init): Don't call init_cli_cmds.
 974         (gdbinit): Remove.
 975         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 976
 977 2019-07-11  Tom Tromey  <tromey@adacore.com>
 978
 979         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 980         after it has been moved.
 981
 982 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 983
 984         * valops.c (value_must_coerce_to_target): Change return type to
 985         bool.
 986         * value.h (value_must_coerce_to_target): Likewise.
 987
 988 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 989
 990         * breakpoint.c (is_hardware_watchpoint): Remove
 991         forward-declaration.
 992         (is_masked_watchpoint): Change return type to bool.
 993         (is_tracepoint): Likewise.
 994         (is_breakpoint): Likewise.
 995         (is_hardware_watchpoint): Likewise.
 996         (is_watchpoint): Likewise.
 997         (is_no_memory_software_watchpoint): Likewise.
 998         (is_catchpoint): Likewise.
 999         (breakpoint_1): Make FILTER parameter's return type bool.
1000         is_masked_watchpoint): Change return type to bool.
1001         (save_breakpoints): Make FILTER parameter's return type bool.
1002         * breakpoint.h (is_breakpoint): Change return type to bool.
1003         (is_watchpoint): Likewise.
1004         (is_catchpoint): Likewise.
1005         (is_tracepoint): Likewise.
1006
1007 2019-07-10  Tom Tromey  <tom@tromey.com>
1008
1009         * defs.h: Don't include gdbarch.h.
1010         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
1011         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
1012         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
1013         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
1014         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
1015         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
1016         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
1017         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
1018         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
1019         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
1020         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
1021         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
1022         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
1023         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
1024         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
1025         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
1026         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
1027         record-btrace.c, record.h, regcache-dump.c, regcache.h,
1028         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
1029         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
1030         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
1031         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
1032         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
1033         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
1034         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
1035         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
1036         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
1037
1038 2019-07-10  Tom Tromey  <tromey@adacore.com>
1039
1040         * ada-lang.h (is_ada_exception_catchpoint): Declare.
1041         * breakpoint.c (init_ada_exception_breakpoint): Register as
1042         bp_catchpoint.
1043         (print_one_breakpoint_location, print_one_breakpoint): Use
1044         is_ada_exception_catchpoint.
1045         * ada-lang.c (class ada_catchpoint_location): Pass
1046         bp_loc_software_breakpoint to bp_location constructor.
1047         (is_ada_exception_catchpoint): New function.
1048
1049 2019-07-10  Tom Tromey  <tromey@adacore.com>
1050
1051         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
1052         VEC.
1053         (struct arm_exidx_entry): New method operator<.
1054         (struct arm_exidx_data) <section_maps>: Change type.
1055         (arm_exidx_data_free): Remove.
1056         (arm_exidx_data_key): Change type.  Move lower.
1057         (arm_exidx_new_objfile): Update.
1058         (arm_compare_exidx_entries): Remove.
1059         (arm_find_exidx_entry, _initialize_arm_tdep)
1060
1061 2019-07-10  Tom Tromey  <tromey@adacore.com>
1062
1063         * solib-spu.c (ocl_program_data_key): Change type.
1064         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
1065         Update.
1066
1067 2019-07-10  Tom Tromey  <tromey@adacore.com>
1068
1069         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
1070         (struct solib_aix_inferior_data) <library_list>: Change type.
1071         (solib_aix_inferior_data_handle): Change type.
1072         (get_solib_aix_inferior_data): Update.
1073         (solib_aix_free_library_list): Remove.
1074         (library_list_start_library): Update.
1075         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1076         return type.
1077         (solib_aix_get_library_list)
1078         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1079         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1080
1081 2019-07-10  Tom Tromey  <tromey@adacore.com>
1082
1083         * solib-dsbt.c (struct dsbt_info): Add initializers.
1084         (solib_dsbt_pspace_data): Change type.
1085         (dsbt_pspace_data_cleanup): Remove.
1086         (get_dsbt_info, _initialize_dsbt_solib): Update.
1087
1088 2019-07-10  Tom Tromey  <tromey@adacore.com>
1089
1090         * spu-tdep.c (spu_overlay_data): Change type.
1091         (spu_get_overlay_table, spu_overlay_new_objfile)
1092         (_initialize_spu_tdep): Update.
1093
1094 2019-07-10  Tom Tromey  <tromey@adacore.com>
1095
1096         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1097         destructor.
1098         (dbx_objfile_data_key): Change type and declare later.
1099         (DBX_SYMFILE_INFO): Rewrite.
1100         * dbxread.c (dbx_objfile_data_key): Change type.
1101         (dbx_symfile_init): Update.
1102         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
1103         (coffstab_build_psymtabs, elfstab_build_psymtabs)
1104         (stabsect_build_psymtabs, _initialize_dbxread): Update.
1105
1106 2019-07-10  Tom Tromey  <tromey@adacore.com>
1107
1108         * jit.c (jit_program_space_key): Change type.  Move lower.
1109         (get_jit_program_space_data): Update.
1110         (jit_program_space_data_cleanup): Remove.
1111         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1112         Update.
1113         (struct jit_program_space_data): Add initializers.
1114
1115 2019-07-10  Tom Tromey  <tromey@adacore.com>
1116
1117         * solib-darwin.c (struct darwin_info): Add initializers.
1118         (solib_darwin_pspace_data): Change type.
1119         (darwin_pspace_data_cleanup): Remove.
1120         (get_darwin_info, _initialize_darwin_solib): Update.
1121
1122 2019-07-10  Tom Tromey  <tromey@adacore.com>
1123
1124         * remote-sim.c (struct sim_inferior_data): Add initializers,
1125         constructor, and destructor.
1126         (sim_inferior_data_key): Change type.  Move lower.
1127         (check_for_duplicate_sim_descriptor): Update.
1128         (get_sim_inferior_data): Use new.  Update.
1129         (~sim_inferior_data_cleanup): Rename from
1130         sim_inferior_data_cleanup.  Simplify.
1131         (gdbsim_close_inferior, simulator_command)
1132         (sim_command_completer, _initialize_remote_sim): Update.
1133         (next_pid, INITIAL_PID): Move earlier.
1134
1135 2019-07-10  Tom Tromey  <tromey@adacore.com>
1136
1137         * python/python-internal.h (create_thread_object): Return
1138         gdbpy_ref.
1139         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1140         * python/py-inferior.c (struct threadlist_entry): Add
1141         constructor.
1142         <thread_obj>: Now a gdbpy_ref.
1143         (thread_to_thread_object): Update.
1144         (add_thread_object): Use new.
1145         (delete_thread_object): Use delete.
1146         (infpy_threads): Update.
1147         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
1148         GIL.
1149
1150 2019-07-10  Tom Tromey  <tromey@adacore.com>
1151
1152         * valops.c (value_cast): Specialize error message for Ada.
1153
1154 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1155
1156         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1157
1158 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1159
1160         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1161         bpstat_should_step): Return bool, adjust comments.
1162         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1163         bpstat_should_step): Likewise.
1164
1165 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1166
1167         * features/Makefile: Use feature target descriptions for Arm.
1168         * features/arm/arm-core.c: Generate new file.
1169         * features/arm/arm-fpa.c: Likewise.
1170         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1171         * features/arm/arm-m-profile.c: Likewise.
1172         * features/arm/arm-vfpv2.c: Likewise.
1173         * features/arm/arm-vfpv3.c: Likewise.
1174         * features/arm/xscale-iwmmxt.c: Likewise.
1175         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1176
1177 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1178
1179         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1180         ptrace earlier.
1181
1182 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1183
1184         * features/aarch64-pauth.c: Regenerate.
1185
1186 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1187
1188         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1189         bool.
1190         (bpstat_what): Use false instead of 0.
1191
1192 2019-07-09  Pedro Alves  <palves@redhat.com>
1193
1194         * break-catch-throw.c (is_exception_catchpoint): New.
1195         * breakpoint.c (print_one_breakpoint_location): New parameter
1196         'raw_loc'.  Handle it.  Use
1197         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1198         looking at the breakpoint's type.
1199         (print_one_breakpoint): If handling "maint info breakpoints", also
1200         print locations of exception catchpoints.
1201         * breakpoint.h (is_exception_catchpoint): Declare.
1202
1203 2019-07-09  Pedro Alves  <palves@redhat.com>
1204
1205         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1206         "addr" field.
1207         (allocate_location_exception_catchpoint): New.
1208         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1209         (initialize_throw_catchpoint_ops): Install
1210         allocate_location_exception_catchpoint as allocate_location
1211         method.
1212         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1213         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1214         bp_loc_other.
1215         (breakpoint_address_is_meaningful): Delete.
1216         (bl_address_is_meaningful): New.
1217         (breakpoint_locations_match): Adjust comment.
1218         (bp_location_from_bp_type): New, factored out of...
1219         (bp_location::bp_location(breakpoint *)): ... this.
1220         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1221         factored out of...
1222         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1223         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1224         breakpoint_address_is_meaningful.
1225         (bp_locations_compare): Adjust comment.
1226         (update_global_location_list): Use bl_address_is_meaningful
1227         instead of breakpoint_address_is_meaningful.
1228         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1229         explicit.
1230         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1231         * python/py-breakpoint.c (bppy_get_location): No longer check
1232         whether location is null.
1233
1234 2019-07-09  Pedro Alves  <palves@redhat.com>
1235
1236         PR c++/15468
1237         * breakpoint.c (print_one_breakpoint_location): Remove
1238         single-location assert.
1239
1240 2019-07-09  Tom Tromey  <tom@tromey.com>
1241
1242         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1243         * configure: Rebuild.
1244         * configure.ac: Change common to gdbsupport.
1245         * gdbsupport: Rename from common.
1246         * acinclude.m4: Change common to gdbsupport.
1247         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1248         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1249         gdbsupport.
1250         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1251         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1252         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1253         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1254         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1255         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1256         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1257         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1258         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1259         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1260         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1261         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1262         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1263         coff-pe-read.c, command.h, compile/compile-c-support.c,
1264         compile/compile-c.h, compile/compile-cplus-symbols.c,
1265         compile/compile-cplus-types.c, compile/compile-cplus.h,
1266         compile/compile-loc2c.c, compile/compile.c, completer.c,
1267         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1268         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1269         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1270         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1271         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1272         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1273         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1274         features/aarch64-core.c, features/aarch64-fpu.c,
1275         features/aarch64-pauth.c, features/aarch64-sve.c,
1276         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1277         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1278         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1279         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1280         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1281         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1282         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1283         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1284         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1285         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1286         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1287         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1288         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1289         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1290         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1291         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1292         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1293         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1294         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1295         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1296         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1297         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1298         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1299         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1300         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1301         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1302         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1303         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1304         minsyms.c, mips-linux-tdep.c, namespace.h,
1305         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1306         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1307         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1308         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1309         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1310         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1311         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1312         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1313         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1314         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1315         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1316         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1317         procfs.c, producer.c, progspace.h, psymtab.h,
1318         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1319         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1320         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1321         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1322         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1323         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1324         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1325         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1326         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1327         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1328         target-memory.c, target.c, target.h, target/waitstatus.c,
1329         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1330         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1331         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1332         unittests/array-view-selftests.c,
1333         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1334         unittests/common-utils-selftests.c,
1335         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1336         unittests/format_pieces-selftests.c,
1337         unittests/function-view-selftests.c,
1338         unittests/lookup_name_info-selftests.c,
1339         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1340         unittests/mkdir-recursive-selftests.c,
1341         unittests/observable-selftests.c,
1342         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1343         unittests/parse-connection-spec-selftests.c,
1344         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1345         unittests/scoped_fd-selftests.c,
1346         unittests/scoped_mmap-selftests.c,
1347         unittests/scoped_restore-selftests.c,
1348         unittests/string_view-selftests.c, unittests/style-selftests.c,
1349         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1350         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1351         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1352         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1353         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1354         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1355
1356 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1357
1358         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1359         bool value.
1360         (decode_digits_ordinary): Set explicit_line field in sal.
1361         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1362         symtab_and_line that was set on an explicit line number in
1363         assembler code.  Do always update the recorded symtab and line if
1364         we do skip the prologue.
1365
1366 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1367
1368         * breakpoint.c (set_breakpoint_location_function): Remove
1369         explicit_loc parameter.
1370         (momentary_breakpoint_from_master): Update call to
1371         set_breakpoint_location_function.
1372         (add_location_to_breakpoint): Likewise.
1373
1374 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1375
1376         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1377         required features based on default bfd type when no specific bfd
1378         is present.
1379
1380 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1381
1382         * NEWS: Mention that GDB printf and eval commands can now print
1383         C-style and Ada-style convenience var strings without
1384         calling the inferior.
1385         * printcmd.c (printf_c_string): Locally print GDB internal var
1386         instead of transiting via the inferior.
1387         (printf_wide_c_string): Likewise.
1388
1389 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1390
1391         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1392
1393 2019-07-04  Tom Tromey  <tom@tromey.com>
1394
1395         PR tui/24724:
1396         * tui/tui-winsource.c (tui_clear_source_content): Update.
1397         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1398         (tui_update_breakpoint_info): Update.
1399         (tui_set_exec_info_content): Update.
1400         * tui/tui-source.c (tui_set_source_content_nil): Update.
1401         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1402         has_break.
1403         * tui/tui-data.h (enum tui_bp_flag): New.
1404         (tui_bp_flags): New enum flags type.
1405         (struct tui_source_element) <break_mode>: Change type.  Rename
1406         from has_break.
1407         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1408         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1409         constants.
1410         * tui/tui-winsource.h: Fix comment.
1411
1412 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1413
1414         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1415         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1416         (store_fpregs_to_thread)
1417         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1418         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1419         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1420         (IWMMXT_REGS_SIZE): Add define.
1421         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1422         (fetch_vfp_regs, store_vfp_regs)
1423         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1424         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1425
1426 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1427
1428         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1429         defines.
1430         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1431         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1432         (ARM_INT_REGISTER_SIZE): ...to this.
1433         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1434         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1435         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1436         (arm_linux_collect_gregset, supply_nwfpe_register)
1437         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1438         defines.
1439         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1440         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1441         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1442         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1443         (arm_return_in_memory, arm_store_return_value)
1444         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1445         (arm_record_ld_st_multiple): Likewise.
1446         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1447         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1448
1449 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1450
1451         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1452         AARCH64_DISPLACED_MODIFIED_INSNS.
1453         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1454         (aarch64_displaced_step_copy_insn): Likewise.
1455         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1456         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1457         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1458         ARM_DISPLACED_MODIFIED_INSNS.
1459         * arm-tdep.c (arm_gdbarch_init): Likewise.
1460         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1461         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1462         (struct arm_displaced_step_closure): Use
1463         ARM_DISPLACED_MODIFIED_INSNS.
1464
1465 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1466
1467         * features/Makefile: Remove unused xml files.
1468         * features/aarch64.xml: Remove.
1469         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1470         * features/i386/amd64-avx-avx512.xml: Remove.
1471         * features/i386/amd64-avx-linux.xml: Remove.
1472         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1473         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1474         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1475         * features/i386/amd64-avx-mpx.xml: Remove.
1476         * features/i386/amd64-avx.xml: Remove.
1477         * features/i386/amd64-linux.xml: Remove.
1478         * features/i386/amd64-mpx-linux.xml: Remove.
1479         * features/i386/amd64-mpx.xml: Remove.
1480         * features/i386/amd64.xml: Remove.
1481         * features/i386/i386-avx-avx512-linux.xml: Remove.
1482         * features/i386/i386-avx-avx512.xml: Remove.
1483         * features/i386/i386-avx-linux.xml: Remove.
1484         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1485         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1486         * features/i386/i386-avx-mpx-linux.xml: Remove.
1487         * features/i386/i386-avx-mpx.xml: Remove.
1488         * features/i386/i386-avx.xml: Remove.
1489         * features/i386/i386-linux.xml: Remove.
1490         * features/i386/i386-mmx-linux.xml: Remove.
1491         * features/i386/i386-mmx.xml: Remove.
1492         * features/i386/i386-mpx-linux.xml: Remove.
1493         * features/i386/i386-mpx.xml: Remove.
1494         * features/i386/i386.xml: Remove.
1495         * features/i386/x32-avx-avx512-linux.xml: Remove.
1496         * features/i386/x32-avx-linux.xml: Remove.
1497         * features/i386/x32-linux.xml: Remove.
1498
1499 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1500
1501         * regformats/aarch64.dat: Remove.
1502         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1503         * regformats/i386/amd64-avx-linux.dat: Remove.
1504         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1505         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1506         * regformats/i386/amd64-linux.dat: Remove.
1507         * regformats/i386/amd64-mpx-linux.dat: Remove.
1508         * regformats/i386/amd64.dat: Remove.
1509         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1510         * regformats/i386/i386-avx-linux.dat: Remove.
1511         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1512         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1513         * regformats/i386/i386-linux.dat: Remove.
1514         * regformats/i386/i386-mmx-linux.dat: Remove.
1515         * regformats/i386/i386-mpx-linux.dat: Remove.
1516         * regformats/i386/i386.dat: Remove.
1517         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1518         * regformats/i386/x32-avx-linux.dat: Remove.
1519         * regformats/i386/x32-linux.dat: Remove.
1520
1521 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1522
1523         * aarch64-tdep.c: Remove xml self tests.
1524         * amd64-linux-tdep.c: Likewise.
1525         * amd64-tdep.c: Likewise.
1526         * i386-linux-tdep.c: Likewise.
1527         * i386-tdep.c: Likewise.
1528
1529 2019-07-03  Pedro Alves  <palves@redhat.com>
1530
1531         PR cli/24732
1532         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1533         (pipe_cmd_option_defs): New.
1534         (make_pipe_cmd_options_def_group): New.
1535         (pipe_command): Use gdb::option::process_options.
1536         (pipe_command_completer): New function.
1537         (_initialize_cli_cmds): Install completer for "pipe" command.
1538
1539 2019-07-03  Pedro Alves  <palves@redhat.com>
1540
1541         * cli/cli-option.c (union option_value) <string>: New field.
1542         (struct option_def_and_value): Add ctor, move ctor, dtor and
1543         use DISABLE_COPY_AND_ASSIGN.
1544         (option_def_and_value::clear_value): New.
1545         (parse_option, save_option_value_in_ctx, get_val_type_str)
1546         (add_setshow_cmds_for_options): Handle var_string.
1547         * cli-option.h (union option_def::var_address) <string>: New
1548         field.
1549         (struct string_option_def): New.
1550         * maint-test-options.c (struct test_options_opts): Add default
1551         ctor and use DISABLE_COPY_AND_ASSIGN.
1552         <string_opt>: New field.
1553         (test_options_opts::~test_options_opts): New.
1554         (test_options_opts::dump): Also dump "-string".
1555         (test_options_option_defs): Install "string.
1556
1557 2019-07-03  Pedro Alves  <palves@redhat.com>
1558
1559         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1560         option_value with a null enumeration.
1561         (complete_options): Save the option values in the context.
1562         (save_option_value_in_ctx): New, factored out from ...
1563         (process_options): ... here.
1564         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1565         of the function.
1566         * maint-test-options.c (test_options_opts::dump): New, factored
1567         out from ...
1568         (maintenance_test_options_command_mode): ... here.
1569         (maintenance_test_options_command_completion_result): Delete.
1570         (maintenance_test_options_command_completion_text): Update
1571         comment.
1572         (maintenance_show_test_options_completion_result): Change
1573         prototype.  Just print
1574         maintenance_test_options_command_completion_text.
1575         (save_completion_result): New.
1576         (maintenance_test_options_completer_mode): Pass options context to
1577         complete_options, and then save a dump.
1578         (_initialize_maint_test_options): Use add_cmd to install "maint
1579         show test-options-completion-result".
1580
1581 2019-07-03  Pedro Alves  <palves@redhat.com>
1582
1583         * NEWS (New commands): Mention "with" and "maint with".
1584         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1585         (with_command, with_command_completer): New.
1586         (pipe_command): Adjust to new repeat_previous
1587         interface.
1588         (_initialize_cli_cmds): Install the "with" command and its "w"
1589         alias.
1590         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1591         declarations.
1592         * cli/cli-setshow.c (parse_cli_var_uinteger)
1593         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1594         argument strings for all var_types.
1595         (get_setshow_command_value_string): New, factored out from ...
1596         (do_show_command): ... this.
1597         * cli/cli-setshow.h: Include <string>.
1598         (get_setshow_command_value_string): Declare.
1599         * command.h (repeat_previous): Now returns const char *.  Adjust
1600         comment.
1601         * maint.c: Include "cli/cli-cmds.h".
1602         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1603         (_initialize_maint_cmds): Register the "maintenance with" command.
1604         * top.c (repeat_previous): Move bits from pipe_command here:
1605         Return the saved command line, if any; error out if there's no
1606         command to relaunch.
1607
1608 2019-07-03  Pedro Alves  <palves@redhat.com>
1609
1610         * NEWS (New commands): Mention "maint set/show test-settings"
1611         instead of "maint test-settings".
1612         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1613         (maintenance_test_settings_set_list): Rename to ...
1614         (maintenance_set_test_settings_list): ... this.
1615         (maintenance_test_settings_show_list): Rename to  ...
1616         (maintenance_show_test_settings_list): ... this.
1617         (maintenance_test_settings_cmd): Delete.
1618         (maintenance_test_settings_set_cmd): ...
1619         (maintenance_set_test_settings_cmd): ... this.
1620         (maintenance_test_settings_show_cmd): ...
1621         (maintenance_show_test_settings_cmd): ... this.
1622         (maintenance_test_settings_show_value_cmd):
1623         (maintenance_show_test_settings_value_cmd): ... this.
1624         (_initialize_maint_test_settings): No longer install the "maint
1625         test-settings" prefix command.  Rename "maint test-settings set"
1626         to "maint set test-settings", and "maint test-settings show" to
1627         "maint show test-settings".  Adjust all subcommands.
1628
1629 2019-07-03  Pedro Alves  <palves@redhat.com>
1630
1631         * maint-test-settings.c: Fix file's intro comment.  Replace all
1632         references to "test-options" with references to "test-settings",
1633         in comments.
1634
1635 2019-07-03  Pedro Alves  <palves@redhat.com>
1636
1637         * maint-test-settings.c (maintenance_test_settings_xxx)
1638         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1639         New.
1640         (maintenance_test_settings_enums): Use them.
1641         (maintenance_test_settings_enum): Default to
1642         maintenance_test_settings_xxx.
1643         (_initialize_maint_test_settings): Initialize
1644         MAINTENANCE_TEST_SETTINGS_FILENAME.
1645
1646 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1647
1648         * breakpoint.h (remove_breakpoints_inf): Change return type to
1649         void, move function documentation here.
1650         * breakpoint.c (remove_breakpoints_inf): Change return type to
1651         void, move function documentation to header.
1652
1653 2019-07-02  Pedro Alves  <palves@redhat.com>
1654
1655         * NEWS (Completion improvements): Mention "info threads".
1656         * thread.c (struct info_threads_opts, info_threads_option_defs)
1657         (make_info_threads_options_def_group): New.
1658         (info_threads_command): Use gdb::option::process_options.
1659         (info_threads_command_completer): New.
1660         (_initialize_thread): Use gdb::option::build_help to build the
1661         help text for "info threads".
1662
1663 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1664
1665         * defs.h (generic_load): Move from here...
1666         * symfile.h (generic_load): ... to here.  Rename name parameter
1667         to args.
1668         * symfile.c (generic_load): Add comment.
1669
1670 2019-07-01  Tom Tromey  <tromey@adacore.com>
1671
1672         * dwarf2read.c
1673         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1674         declaration of without_params.  Fix formatting.
1675
1676 2019-07-01  Tom Tromey  <tromey@adacore.com>
1677
1678         * ada-exp.y (find_primitive_type): Update.
1679         * ada-lang.h (ada_lookup_symbol): Update.
1680         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1681         parameter.
1682         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1683
1684 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1685
1686         PR breakpoints/24541
1687         * gdbarch.c: Regenerate.
1688         * gdbarch.h: Regenerate.
1689         * gdbarch.sh: Add 'stap_adjust_register'.
1690         * i386-tdep.c: Include '<unordered_set>'.
1691         (i386_stap_adjust_register): New function.
1692         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1693         * stap-probe.c (stap_parse_register_operand): Call
1694         'gdbarch_stap_adjust_register'.
1695
1696 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1697
1698         PR python/24742
1699         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1700         * python/python.c (do_start_initialization): Use 'xmalloc'
1701         instead of 'PyMem_Malloc'.
1702
1703 2019-06-28  Tom Tromey  <tromey@adacore.com>
1704
1705         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1706         for Ada.
1707
1708 2019-06-27  Tom Tromey  <tromey@adacore.com>
1709
1710         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1711         objfile_key.
1712         (arm_find_mapping_symbol, arm_record_special_symbol)
1713         (_initialize_arm_tdep): Update.
1714         (arm_objfile_data_free): Remove.
1715
1716 2019-06-27  Tom Tromey  <tromey@adacore.com>
1717
1718         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1719         to cp_print_static_field.
1720
1721 2019-06-26  Tom Tromey  <tromey@adacore.com>
1722
1723         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1724         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1725         declare.
1726
1727 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1728
1729         * features/aarch64-core.c (create_feature_aarch64_core):
1730         Regenerate.
1731         * features/aarch64-core.xml: Add cpsr flags.
1732
1733 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1734
1735         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1736         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1737
1738 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1739
1740         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1741         field.
1742         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1743         use.
1744         (arm_record_special_symbol): Don't insert new symbol in sorted
1745         position, push it at the end.
1746
1747 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1748
1749         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1750         (arm_mapping_symbol_s): Remove.
1751         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1752         (arm_mapping_symbol_vec): New typedef.
1753         (struct arm_per_objfile): Add constructor.
1754         <section_maps>: Change type to
1755         std::unique_ptr<arm_mapping_symbol_vec[]>.
1756         (arm_compare_mapping_symbols): Remove.
1757         (arm_find_mapping_symbol): Adjust to section_maps type change.
1758         (arm_objfile_data_free): Call delete on arm_per_objfile.
1759         (arm_record_special_symbol): Adjust to section_maps type change.
1760         Allocate arm_per_objfile with new.
1761
1762 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1763
1764         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1765         with the command prefix.
1766
1767 2019-06-25  Tom Tromey  <tom@tromey.com>
1768
1769         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1770         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1771
1772 2019-06-25  Tom Tromey  <tom@tromey.com>
1773
1774         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1775         type.
1776         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1777         protected.
1778
1779 2019-06-25  Tom Tromey  <tom@tromey.com>
1780
1781         * tui/tui-winsource.c
1782         (tui_source_window_base::set_is_exec_point_at): Add check against
1783         LOA_ADDRESS.
1784
1785 2019-06-25  Tom Tromey  <tom@tromey.com>
1786
1787         * tui/tui-source.c (tui_set_source_content): Don't check before
1788         xfree.
1789         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1790
1791 2019-06-25  Tom Tromey  <tom@tromey.com>
1792
1793         * tui/tui-winsource.h (tui_update_source_window_as_is)
1794         (tui_alloc_source_buffer, tui_line_is_displayed)
1795         (tui_addr_is_displayed): Change type of win_info.
1796         * tui/tui-winsource.c (tui_update_source_window_as_is)
1797         (tui_clear_source_content, tui_show_source_line)
1798         (tui_show_source_content, tui_source_window_base::refill)
1799         (tui_source_window_base::set_is_exec_point_at)
1800         (tui_source_window_base::set_is_exec_point_at)
1801         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1802         (tui_alloc_source_buffer, tui_line_is_displayed)
1803         (tui_addr_is_displayed): Change type of win_info.  Update.
1804         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1805         (tui_source_window_base::do_make_visible_with_new_height):
1806         Update.
1807         * tui/tui-source.c (tui_set_source_content)
1808         (tui_set_source_content_nil)
1809         (tui_source_window::do_scroll_vertical): Update.
1810         * tui/tui-layout.c (show_layout): Update.
1811         * tui/tui-disasm.c (tui_set_disassem_content)
1812         (tui_disasm_window::do_scroll_vertical): Update.
1813         * tui/tui-data.h (tui_win_content): Remove.
1814         (struct tui_gen_win_info) <content, content_size>: Remove.
1815         (struct tui_source_element): Add initializers and destructor.
1816         (union tui_which_element, struct tui_win_element): Remove.
1817         (struct tui_source_window_base) <content>: New field.
1818         (struct tui_data_window): Remove destructor.
1819         (tui_alloc_content, tui_free_win_content)
1820         (tui_free_all_source_wins_content): Don't declare.
1821         * tui/tui-data.c (tui_initialize_static_data): Update.
1822         (init_content_element, tui_alloc_content): Remove.
1823         (~tui_gen_win_info): Update.
1824         (~tui_data_window, tui_free_all_source_wins_content)
1825         (tui_free_win_content, free_content, free_content_elements):
1826         Remove.
1827
1828 2019-06-25  Tom Tromey  <tom@tromey.com>
1829
1830         * tui/tui-winsource.h (tui_clear_source_content)
1831         (tui_erase_source_content, tui_show_source_content): Change type
1832         of win_info.
1833         * tui/tui-winsource.c (tui_clear_source_content)
1834         (tui_erase_source_content, tui_show_source_content): Change type
1835         of win_info.
1836         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1837         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1838         win_info.
1839         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1840         win_info.
1841         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1842
1843 2019-06-25  Tom Tromey  <tom@tromey.com>
1844
1845         * tui/tui-winsource.c (tui_clear_source_content)
1846         (tui_source_window_base::set_is_exec_point_at): Update.
1847         * tui/tui-source.c (tui_set_source_content_nil): Update.
1848         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1849         a bool.
1850         * tui/tui-data.c (init_content_element): Update.
1851
1852 2019-06-25  Tom Tromey  <tom@tromey.com>
1853
1854         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1855         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1856         * tui/tui-layout.c (init_and_make_win): Update.
1857         * tui/tui.h (enum tui_win_type): Update.
1858         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1859         tui_win_is_auxillary.
1860         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1861         tui_win_is_auxillary.
1862
1863 2019-06-25  Tom Tromey  <tom@tromey.com>
1864
1865         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1866         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1867         (tui_delete_data_content_windows, tui_display_all_data)
1868         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1869         Update.
1870         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1871         * tui/tui-regs.c (tui_last_regs_line_no)
1872         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1873         (tui_show_registers): Update.
1874         (tui_show_register_group): Return void.  Update.
1875         (tui_display_registers_from, tui_display_reg_element_at_line)
1876         (tui_display_registers_from_line, tui_check_register_values):
1877         Update.
1878         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1879         member.
1880         (struct tui_data_window) <regs_content>: Now a std::vector.
1881         <regs_content_count>: Remove.
1882         (tui_add_content_elements, tui_free_data_content): Don't declare.
1883         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1884         (init_content_element): Remove DATA_WIN case.  Add assert.
1885         (tui_add_content_elements): Remove.
1886         (tui_data_window): Update.
1887         (tui_free_data_content): Remove.
1888         (free_content_elements): Remove DATA_WIN case.
1889
1890 2019-06-25  Tom Tromey  <tom@tromey.com>
1891
1892         * tui/tui-data.c (tui_data_item_window): Update.
1893         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1894         * tui/tui-windata.c (tui_display_all_data)
1895         (tui_display_data_from_line): Update.
1896         (tui_check_data_values): Remove.
1897         * tui/tui-regs.c (tui_show_register_group)
1898         (tui_display_reg_element_at_line): Update.
1899         * tui/tui-hooks.c (tui_register_changed)
1900         (tui_refresh_frame_and_register_information): Call
1901         tui_check_register_values.
1902         * tui/tui-data.h (struct tui_data_window) <data_content,
1903         data_content_count, data_type>: Remove.
1904         (enum tui_data_type): Remove.
1905
1906         * tui/tui-data.c (tui_data_window::clear_detail)
1907         (~tui_data_window): Update.
1908
1909 2019-06-25  Tom Tromey  <tom@tromey.com>
1910
1911         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1912         declare.
1913         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1914         Rename from tui_first_data_item_displayed.  Update.
1915         (tui_data_window::refresh_all)
1916         (tui_data_window::do_scroll_vertical): Update.
1917         * tui/tui-data.h (struct tui_data_window)
1918         <first_data_item_displayed>: Declare new method.
1919
1920 2019-06-25  Tom Tromey  <tom@tromey.com>
1921
1922         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1923         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1924         contents...
1925         (tui_initialize_static_data): ...here.
1926
1927 2019-06-25  Tom Tromey  <tom@tromey.com>
1928
1929         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1930         (tui_display_registers_from, tui_check_register_values): Update.
1931         (tui_display_register): Remove win_info parameter; update.
1932         (tui_get_register): Change type of parameters.
1933         * tui/tui-data.h (struct tui_data_element): Remove.
1934         (union tui_which_element) <data>: Remove.
1935         <data_window>: Change type.
1936         (struct tui_data_item_window): New.
1937         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1938         case.  Add assert.
1939         (~tui_data_item_window): New destructor.
1940         (free_content_elements): Remove DATA_ITEM_WIN case.
1941
1942 2019-06-25  Tom Tromey  <tom@tromey.com>
1943
1944         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1945         Remove.
1946
1947 2019-06-25  Tom Tromey  <tom@tromey.com>
1948
1949         * tui/tui-data.h (struct tui_command_element): Remove.
1950         (union tui_which_element) <command>: Remove.
1951         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1952         assert.
1953         (free_content_elements): Remove CMD_WIN case.
1954
1955 2019-06-25  Tom Tromey  <tom@tromey.com>
1956
1957         * tui/tui-layout.c (tui_set_layout): Update.
1958         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1959         * tui/tui-data.c (layout_def): Update.
1960
1961 2019-06-25  Tom Tromey  <tom@tromey.com>
1962
1963         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1964         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1965         (tui_source_window_base::set_new_height): Update.
1966         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1967         Update.
1968         (tui_set_locator_fullname, tui_set_locator_info)
1969         (tui_show_frame_info): Update.
1970         * tui/tui-source.c (tui_set_source_content)
1971         (tui_source_is_displayed): Update.
1972         * tui/tui-layout.c (show_source_disasm_command, show_data)
1973         (show_source_or_disasm_and_command): Update.
1974         * tui/tui-disasm.c (tui_set_disassem_content)
1975         (tui_get_begin_asm_address): Update.
1976         * tui/tui-data.h (struct tui_locator_element): Remove.
1977         (union tui_which_element) <locator>: Remove.
1978         (struct tui_locator_window): New.
1979         (tui_locator_win_info_ptr): Change return type.
1980         * tui/tui-data.c (_locator): Change type.
1981         (tui_locator_win_info_ptr): Change return type.
1982         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1983         (tui_alloc_content): Add assert.
1984
1985 2019-06-25  Tom Tromey  <tom@tromey.com>
1986
1987         * tui/tui-winsource.c
1988         (tui_exec_info_window::maybe_allocate_content): New method.
1989         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1990         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1991         (make_source_or_disasm_window): Add cast.
1992         * tui/tui-data.h (union tui_which_element) <simple_string>:
1993         Remove.
1994         (struct tui_source_info): New.
1995         (struct tui_source_window_base) <execution_info>: Change type.
1996         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1997         case, and add assert.
1998         (tui_alloc_content): Add assert.
1999
2000 2019-06-25  Tom Tromey  <tom@tromey.com>
2001
2002         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
2003         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
2004         * tui/tui-data.c (tui_alloc_win_info): Remove.
2005
2006 2019-06-25  Tom Tromey  <tom@tromey.com>
2007
2008         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
2009         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
2010         can_highlight.
2011
2012 2019-06-25  Tom Tromey  <tom@tromey.com>
2013
2014         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
2015         make_visible_with_new_height method.
2016         (tui_win_info::make_visible_with_new_height): New method.
2017         (tui_source_window_base::do_make_visible_with_new_height)
2018         (tui_data_window::do_make_visible_with_new_height)
2019         (tui_cmd_window::do_make_visible_with_new_height): New methods.
2020         (make_visible_with_new_height): Remove.
2021         (tui_resize_all, tui_adjust_win_heights): Use
2022         make_visible_with_new_height method.
2023         * tui/tui-data.h (struct tui_win_info)
2024         <do_make_visible_with_new_height, make_visible_with_new_height>:
2025         New methods.
2026         (struct tui_source_window_base, struct tui_data_window)
2027         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
2028         methods.
2029
2030 2019-06-25  Tom Tromey  <tom@tromey.com>
2031
2032         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
2033         method.
2034         (update_tab_width): Call update_tab_width method.
2035         * tui/tui-data.h (struct tui_win_info)
2036         (struct tui_source_window_base) <update_tab_width>: New methods.
2037
2038 2019-06-25  Tom Tromey  <tom@tromey.com>
2039
2040         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
2041         parameter.
2042         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
2043         parameter.
2044         (tui_gen_win_info::make_visible): Update.
2045         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
2046         parameter.
2047         * tui/tui-data.h (enum tui_box): New enum.
2048         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
2049
2050 2019-06-25  Tom Tromey  <tom@tromey.com>
2051
2052         * tui/tui-layout.c (make_source_or_disasm_window): Always use
2053         init_and_make_win for EXEC_INFO_WIN.
2054         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
2055         longer inline.
2056         (struct tui_win_info) <~tui_win_info>: Inline.
2057         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2058         Don't declare.
2059         * tui/tui-data.c (source_win, disasm_win): Remove globals.
2060         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2061         Remove.
2062         (tui_initialize_static_data): Update.
2063         (~tui_gen_win_info): Handle more cleanup here.
2064         (~tui_source_window_base): Delete "execution_info".
2065         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
2066
2067 2019-06-25  Tom Tromey  <tom@tromey.com>
2068
2069         * tui/tui-layout.c (make_command_window): Don't set
2070         can_highlight.
2071         (show_source_disasm_command): Call the reset method.
2072         (show_data): Don't set can_highlight.  Call the reset method.
2073         (tui_gen_win_info::reset): Rename from init_gen_win_info
2074         (init_and_make_win): Simplify.  Return tui_gen_win_info.
2075         (show_source_or_disasm_and_command): Call the reset method.
2076         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2077         (struct tui_cmd_window): Set can_highlight.
2078
2079 2019-06-25  Tom Tromey  <tom@tromey.com>
2080
2081         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2082         from make_visible.
2083         (tui_make_visible, tui_make_invisible): Rewrite.
2084         (tui_win_info::make_visible): Remove.
2085         (tui_source_window_base::make_visible): Update.
2086         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2087         method.  Moved from...
2088         (struct tui_win_info) <make_visible>: ...here.
2089
2090 2019-06-25  Tom Tromey  <tom@tromey.com>
2091
2092         * tui/tui-winsource.c
2093         (tui_source_window_base::do_scroll_horizontal): Remove direction
2094         parameter.
2095         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2096         direction parameter.
2097         * tui/tui-win.c (tui_win_info::forward_scroll)
2098         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2099         (tui_win_info::right_scroll): Update.
2100         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2101         direction parameter.
2102         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2103         direction parameter.
2104         * tui/tui-data.h (enum tui_scroll_direction): Remove.
2105         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2106         Remove direction parameter.
2107         (struct tui_source_window_base, struct tui_source_window)
2108         (struct tui_disasm_window, struct tui_data_window)
2109         (struct tui_cmd_window): Update.
2110
2111 2019-06-25  Tom Tromey  <tom@tromey.com>
2112
2113         * tui/tui-winsource.h (tui_set_exec_info_content)
2114         (tui_show_exec_info_content, tui_erase_exec_info_content)
2115         (tui_clear_exec_info_content, tui_update_exec_info): Change
2116         argument to tui_source_window_base.
2117         * tui/tui-winsource.c (tui_set_exec_info_content)
2118         (tui_show_exec_info_content, tui_erase_exec_info_content)
2119         (tui_clear_exec_info_content, tui_update_exec_info): Change
2120         argument to tui_source_window_base.
2121
2122 2019-06-25  Tom Tromey  <tom@tromey.com>
2123
2124         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2125         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2126
2127 2019-06-25  Tom Tromey  <tom@tromey.com>
2128
2129         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2130         check.
2131
2132 2019-06-25  Tom Tromey  <tom@tromey.com>
2133
2134         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2135         type to void.
2136         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2137         type to void.
2138         * tui/tui-source.c (tui_set_source_content): Update.
2139         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2140
2141 2019-06-25  Tom Tromey  <tom@tromey.com>
2142
2143         * tui/tui-win.c (window_name_completer, tui_set_focus)
2144         (tui_all_windows_info): Use name method.
2145         * tui/tui-data.h (struct tui_gen_win_info)
2146         (struct tui_source_window, struct tui_disasm_window)
2147         (struct tui_data_window, struct tui_cmd_window) <name>: New
2148         method.
2149         (tui_win_name): Don't declare.
2150         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2151         (tui_win_name): Remove.
2152
2153 2019-06-25  Tom Tromey  <tom@tromey.com>
2154
2155         * tui/tui-winsource.h (tui_update_source_window)
2156         (tui_update_source_window_as_is): Change parameter type.
2157         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2158         to be a tui_source_window_base.
2159         (tui_update_source_window_as_is): Likewise.
2160         * tui/tui-win.c (make_visible_with_new_height): Update.
2161
2162 2019-06-25  Tom Tromey  <tom@tromey.com>
2163
2164         * tui/tui-winsource.c (tui_erase_source_content)
2165         (tui_show_source_content, tui_show_exec_info_content)
2166         (tui_erase_exec_info_content): Use refresh_window method.
2167         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2168         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2169         from tui_refresh_win.
2170         (tui_data_window::refresh_window): New method.
2171         (tui_win_info::refresh, tui_source_window_base::refresh)
2172         (tui_refresh_all): Use refresh_window method.
2173         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2174         method.
2175         * tui/tui-regs.c (tui_display_register): Call refresh_window
2176         method.
2177         * tui/tui-layout.c (show_source_disasm_command)
2178         (show_source_or_disasm_and_command): Call refresh_window method.
2179         * tui/tui-data.h (struct tui_gen_win_info)
2180         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2181         New method.
2182
2183 2019-06-25  Tom Tromey  <tom@tromey.com>
2184
2185         * tui/tui.c (tui_rl_other_window, tui_enable)
2186         (tui_is_window_visible, tui_get_command_dimension): Update.
2187         * tui/tui-winsource.c (tui_update_source_window_as_is)
2188         (tui_clear_source_content, tui_erase_source_content)
2189         (tui_show_source_line, tui_source_window_base::refill)
2190         (tui_source_window_base::do_scroll_horizontal)
2191         (tui_source_window_base::set_is_exec_point_at)
2192         (tui_update_breakpoint_info, tui_set_exec_info_content)
2193         (tui_alloc_source_buffer, tui_line_is_displayed)
2194         (tui_addr_is_displayed): Update.
2195         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2196         (tui_check_and_display_highlight_if_needed)
2197         (tui_win_info::make_visible, tui_win_info::refresh)
2198         (tui_refresh_all): Update.
2199         * tui/tui-windata.c (tui_first_data_item_displayed)
2200         (tui_delete_data_content_windows, tui_erase_data_content)
2201         (tui_display_all_data, tui_data_window::refresh_all)
2202         (tui_check_data_values): Update.
2203         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2204         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2205         (tui_win_info::backward_scroll, tui_refresh_all_win)
2206         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2207         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2208         (tui_source_window_base::set_new_height)
2209         (tui_data_window::set_new_height)
2210         (make_invisible_and_set_new_height)
2211         (make_visible_with_new_height, new_height_ok)
2212         (parse_scrolling_args): Update.
2213         * tui/tui-stack.c (tui_show_frame_info): Update.
2214         * tui/tui-source.c (tui_set_source_content)
2215         (tui_set_source_content_nil, tui_source_is_displayed)
2216         (tui_source_window::do_scroll_vertical): Update.
2217         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2218         (tui_display_registers_from, tui_display_reg_element_at_line)
2219         (tui_check_register_values, tui_reg_command): Update.
2220         * tui/tui-layout.c (tui_default_win_height)
2221         (show_source_disasm_command, show_data, init_and_make_win)
2222         (show_source_or_disasm_and_command): Update.
2223         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2224         (tui_redisplay_readline, tui_mld_flush)
2225         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2226         (tui_getc): Update.
2227         * tui/tui-disasm.c (tui_set_disassem_content)
2228         (tui_disasm_window::do_scroll_vertical): Update.
2229         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2230         Now virtual.
2231         (struct tui_win_info): Derive from tui_gen_win_info.
2232         <~tui_win_info>: Mark as override.
2233         <generic>: Remove member.
2234         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2235         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2236         (~tui_data_window, ~tui_win_info)
2237         (tui_free_all_source_wins_content): Update.
2238         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2239
2240 2019-06-25  Tom Tromey  <tom@tromey.com>
2241
2242         * tui/tui-layout.c (init_and_make_win): Use new.
2243         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2244         destructor, initializers.
2245         (tui_alloc_generic_win_info): Don't declare.
2246         * tui/tui-data.c (_locator): Add argument to constructor.
2247         (source_win, disasm_win): New globals.
2248         (exec_info): Remove.
2249         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2250         Update.
2251         (tui_alloc_generic_win_info): Remove.
2252         (init_content_element): Use new.
2253         (tui_win_info::tui_win_info): Update.
2254         (free_content_elements) <case DATA_WIN>: Use delete.
2255
2256 2019-06-25  Tom Tromey  <tom@tromey.com>
2257
2258         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2259         * tui/tui-windata.c (tui_first_data_item_displayed)
2260         (tui_delete_data_content_windows): Update.
2261         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2262         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2263         (tui_display_registers_from, tui_check_register_values): Update.
2264         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2265         pointer.
2266         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2267         window.
2268         (tui_free_data_content): Update.
2269         (free_content_elements) <case DATA_WIN>: Free the window.
2270
2271 2019-06-25  Tom Tromey  <tom@tromey.com>
2272
2273         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2274         Update.
2275         * tui/tui-layout.c (make_command_window)
2276         (show_source_disasm_command, show_data, init_and_make_win)
2277         (show_source_or_disasm_and_command): Update.
2278         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2279         method.
2280         <can_highight, is_highlighted>: Now bool.
2281         (tui_set_win_highlight): Don't declare.
2282         * tui/tui-data.c (tui_set_win_highlight): Remove.
2283
2284 2019-06-25  Tom Tromey  <tom@tromey.com>
2285
2286         * tui/tui-wingeneral.c (make_visible): Remove check of window
2287         type.
2288
2289 2019-06-25  Tom Tromey  <tom@tromey.com>
2290
2291         * tui/tui-win.c (tui_win_info::max_height)
2292         (tui_cmd_window::max_height): New methods.
2293         (new_height_ok): Call max_height.
2294         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2295         <max_height>: New method.
2296
2297 2019-06-25  Tom Tromey  <tom@tromey.com>
2298
2299         * tui/tui-win.c (tui_source_window_base::set_new_height)
2300         (tui_data_window::set_new_height): New methods.
2301         (make_invisible_and_set_new_height): Call set_new_height method.
2302         * tui/tui-data.h (struct tui_win_info)
2303         (struct tui_source_window_base, struct tui_data_window)
2304         <set_new_height>: New method.
2305
2306 2019-06-25  Tom Tromey  <tom@tromey.com>
2307
2308         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2309         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2310         tui_refresh_data_win.
2311         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2312         method.
2313         (tui_refresh_all_win): Call the refresh_all method.
2314         (tui_set_focus): Likewise.
2315         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2316         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2317         Likewise.
2318
2319 2019-06-25  Tom Tromey  <tom@tromey.com>
2320
2321         * tui/tui-winsource.h (tui_refill_source_window)
2322         (tui_set_is_exec_point_at): Don't declare.
2323         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2324         (tui_source_window_base::refill): Rename from
2325         tui_refill_source_window.
2326         (tui_source_window_base::do_scroll_horizontal): Update.
2327         (tui_source_window_base::set_is_exec_point_at): Rename from
2328         tui_set_is_exec_point_at.
2329         (tui_update_all_breakpoint_info): Update.
2330         * tui/tui-stack.c (tui_show_frame_info): Update.
2331         * tui/tui-layout.c (show_data): Add cast.
2332         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2333         * tui/tui-data.h (struct tui_source_window_base) <refill,
2334         set_is_exec_point_at>: New methods.
2335         (tui_source_windows, tui_add_to_source_windows): Update types.
2336         (tui_add_to_source_windows): Remove redundant declaration.
2337         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2338         (tui_source_windows): Change return type.
2339         (tui_clear_source_windows_detail): Update.
2340         (tui_add_to_source_windows): Change type of parameter.
2341         (tui_free_all_source_wins_content): Update.
2342
2343 2019-06-25  Tom Tromey  <tom@tromey.com>
2344
2345         * tui/tui-wingeneral.c (tui_win_info::refresh)
2346         (tui_source_window_base::refresh): New methods.
2347         (tui_refresh_all): Call the refresh method.
2348         * tui/tui-data.h (struct tui_win_info)
2349         (struct tui_source_window_base) <refresh>: New method.
2350
2351 2019-06-25  Tom Tromey  <tom@tromey.com>
2352
2353         * tui/tui.h (tui_is_window_visible): Return bool.
2354         * tui/tui.c (tui_is_window_visible): Return bool.
2355         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2356         (tui_make_visible, tui_make_invisible)
2357         (tui_win_info::make_visible)
2358         (tui_source_window_base::make_visible, make_all_visible)
2359         (tui_make_all_visible, tui_make_all_invisible): Update.
2360         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2361         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2362         bool.
2363         (struct tui_win_info, struct tui_source_window_base)
2364         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2365         * tui/tui-data.c (tui_init_generic_part): Update.
2366
2367 2019-06-25  Tom Tromey  <tom@tromey.com>
2368
2369         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2370         (tui_source_window_base::make_visible): New methods.
2371         (make_all_visible): Make method call.
2372         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2373         (struct tui_source_window_base, struct tui_cmd_window): Override
2374         make_visible.
2375         (tui_win_is_source_type): Don't declare.
2376         * tui/tui-data.c (tui_win_is_source_type): Remove.
2377
2378 2019-06-25  Tom Tromey  <tom@tromey.com>
2379
2380         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2381         NULL check.
2382
2383 2019-06-25  Tom Tromey  <tom@tromey.com>
2384
2385         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2386         Inline constructor.  Add initializers for members.
2387         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2388         constructors; now inline in class.
2389
2390 2019-06-25  Tom Tromey  <tom@tromey.com>
2391
2392         * tui/tui-regs.c (tui_show_registers): Update.
2393         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2394         bool.
2395         * tui/tui-data.c (tui_data_window::clear_detail)
2396         (tui_data_window): Update.
2397
2398 2019-06-25  Tom Tromey  <tom@tromey.com>
2399
2400         * tui/tui-windata.c (tui_display_all_data)
2401         (tui_display_data_from_line, tui_display_data_from)
2402         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2403         Update.
2404         * tui/tui-regs.c (tui_last_regs_line_no)
2405         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2406         (tui_show_registers, tui_show_register_group)
2407         (tui_display_registers_from, tui_display_reg_element_at_line)
2408         (tui_display_registers_from_line, tui_check_register_values)
2409         (tui_reg_next, tui_reg_prev): Update.
2410         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2411         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2412         tui_data_window.
2413         (struct tui_win_info) <detail>: Remove.  Add new fields from
2414         tui_data_info.
2415         (TUI_DATA_WIN): Add cast.
2416         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2417         (~tui_data_window): Simplify.
2418
2419 2019-06-25  Tom Tromey  <tom@tromey.com>
2420
2421         * tui/tui-layout.c (show_source_disasm_command)
2422         (show_source_or_disasm_and_command): Update.
2423         * tui/tui-io.c (update_cmdwin_start_line)
2424         (tui_redisplay_readline): Update.
2425         * tui/tui-data.h (struct tui_command_info): Remove.
2426         (struct tui_win_info) <detail>: Remove command_info member.
2427         (struct tui_data_window) <start_line>: New member, from
2428         tui_command_info.
2429         (TUI_CMD_WIN): Add casts.
2430
2431 2019-06-25  Tom Tromey  <tom@tromey.com>
2432
2433         * tui/tui-winsource.c (tui_update_source_window)
2434         (tui_refill_source_window)
2435         (tui_source_window_base::do_scroll_horizontal)
2436         (tui_update_breakpoint_info, tui_set_exec_info_content)
2437         (tui_show_exec_info_content, tui_erase_exec_info_content)
2438         (tui_clear_exec_info_content): Update.
2439         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2440         Update.
2441         * tui/tui-win.c (make_invisible_and_set_new_height)
2442         (make_visible_with_new_height): Update.
2443         * tui/tui-source.c (tui_set_source_content)
2444         (tui_show_symtab_source): Update.
2445         * tui/tui-layout.c (extract_display_start_addr)
2446         (show_source_disasm_command, show_data)
2447         (make_source_or_disasm_window)
2448         (show_source_or_disasm_and_command): Update.
2449         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2450         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2451         "gdbarch".
2452         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2453         to tui_source_window_base.
2454         (struct tui_win_info) <detail>: Remove source_info member.
2455         (struct tui_source_window_base) <has_locator>: Inline.
2456         Move contents from tui_source_info; rename has_locator member to
2457         m_has_locator.
2458         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2459         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2460         header file.
2461         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2462         Simplify.
2463         (tui_free_all_source_wins_content): Cast to
2464         tui_source_window_base.
2465
2466 2019-06-25  Tom Tromey  <tom@tromey.com>
2467
2468         * tui/tui-win.c (make_invisible_and_set_new_height)
2469         (make_visible_with_new_height): Call has_locator method.
2470         * tui/tui-layout.c (show_source_disasm_command, show_data)
2471         (show_source_or_disasm_and_command): Update for bool change.
2472         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2473         (tui_win_info) <has_locator>: New method.
2474         (struct tui_source_window_base) <has_locator>: New method.
2475         (tui_win_has_locator): Don't declare.
2476         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2477         from tui_win_has_locator.
2478         (tui_source_window_base): Use false, not FALSE.
2479
2480 2019-06-25  Tom Tromey  <tom@tromey.com>
2481
2482         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2483         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2484         clear_detail method directly.
2485         (tui_clear_win_detail): Remove.
2486
2487 2019-06-25  Tom Tromey  <tom@tromey.com>
2488
2489         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2490         "this", not TUI_DISASM_WIN.
2491
2492 2019-06-25  Tom Tromey  <tom@tromey.com>
2493
2494         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2495         declare.
2496         * tui/tui-winsource.c
2497         (tui_source_window_base::do_scroll_horizontal): Rename from
2498         tui_horizontal_source_scroll.
2499         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2500         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2501         from tui_vertical_data_scroll.
2502         * tui/tui-win.h (tui_scroll): Don't declare.
2503         * tui/tui-win.c (tui_win_info::forward_scroll)
2504         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2505         (tui_win_info::right_scroll): Rename and update.
2506         (tui_scroll_forward_command, tui_scroll_backward_command)
2507         (tui_scroll_left_command, tui_scroll_right_command): Update.
2508         (tui_scroll): Remove.
2509         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2510         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2511         from tui_vertical_source_scroll.
2512         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2513         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2514         from tui_vertical_disassem_scroll.
2515         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2516         do_scroll_horizontal>: New methods.
2517         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2518         Likewise.
2519         (struct tui_source_window_base): Add do_scroll_horizontal.
2520         (struct tui_source_window, struct tui_disasm_window): Add
2521         do_scroll_vertical.
2522         (struct tui_data_window, struct tui_cmd_window): Add
2523         do_scroll_horizontal and do_scroll_vertical.
2524         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2525
2526 2019-06-25  Tom Tromey  <tom@tromey.com>
2527
2528         * tui/tui-data.h (struct tui_source_window_base): New struct.
2529         (struct tui_source_window): Derive from tui_source_window_base.
2530         (struct tui_disasm_window): New struct.
2531         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2532         from tui_source_window::clear_detail.
2533         (tui_source_window_base): Rename from tui_source_window.
2534         (~tui_source_window_base): Rename from ~tui_source_window.
2535         (tui_alloc_win_info): Create a tui_disasm_window.
2536
2537 2019-06-25  Tom Tromey  <tom@tromey.com>
2538
2539         * tui/tui-data.h (struct tui_source_window)
2540         (struct tui_data_window): Declare destructors.
2541         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2542         destructors.
2543         (tui_win_info): Simplify.
2544
2545 2019-06-25  Tom Tromey  <tom@tromey.com>
2546
2547         * tui/tui-winsource.c (tui_display_main)
2548         (tui_update_source_windows_with_addr)
2549         (tui_update_all_breakpoint_info): Update.
2550         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2551         (new_height_ok, parse_scrolling_args): Update.
2552         * tui/tui-stack.c (tui_show_frame_info): Update.
2553         * tui/tui-data.h (struct tui_list): Remove.
2554         (tui_source_windows): Return a reference to a std::vector.
2555         * tui/tui-data.c (source_windows): Now a std::vector.
2556         (tui_source_windows): Change return type.
2557         (tui_clear_source_windows): Rewrite.
2558         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2559         (tui_free_all_source_wins_content): Rewrite.
2560
2561 2019-06-25  Tom Tromey  <tom@tromey.com>
2562
2563         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2564         (struct tui_data_window, struct tui_cmd_window): Declare
2565         clear_detail method.
2566         * tui/tui-data.c (tui_source_window::clear_detail)
2567         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2568         methods.
2569         (tui_clear_win_detail): Simplify.
2570
2571 2019-06-25  Tom Tromey  <tom@tromey.com>
2572
2573         * tui/tui-layout.c (make_source_window, make_disasm_window)
2574         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2575         Return the new window.
2576         (show_source_disasm_command, show_data)
2577         (show_source_or_disasm_and_command): Update.
2578
2579 2019-06-25  Tom Tromey  <tom@tromey.com>
2580
2581         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2582         parameter.  Return the new window.
2583         (show_source_disasm_command): Update and remove NULL check.
2584         (show_source_or_disasm_and_command): Update.
2585
2586 2019-06-25  Tom Tromey  <tom@tromey.com>
2587
2588         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2589
2590 2019-06-25  Tom Tromey  <tom@tromey.com>
2591
2592         * tui/tui-data.h (struct tui_win_info): Make constructor
2593         protected.  Make destructor virtual.  Add initializers.
2594         (tui_source_window, tui_data_window, tui_cmd_window): New
2595         classes.
2596         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2597         constructor.  Add "type" parameter.
2598         (tui_source_window, tui_data_window, tui_cmd_window): New
2599         constructors.
2600         (tui_alloc_win_info): Instantiate the appropriate subclass.
2601
2602 2019-06-25  Tom Tromey  <tom@tromey.com>
2603
2604         * tui/tui-win.c (tui_resize_all): Use delete.
2605         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2606         destructor.
2607         (tui_free_window): Don't declare.
2608         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2609         Update.
2610
2611 2019-06-25  Tom Tromey  <tom@tromey.com>
2612
2613         * tui/tui-data.h (struct tui_win_info): Add constructor.
2614         * tui/tui-data.c (tui_alloc_win_info): Use new.
2615         (tui_free_window): Use delete.
2616
2617 2019-06-22  Tom Tromey  <tom@tromey.com>
2618
2619         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2620         declare.
2621         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2622
2623 2019-06-22  Tom Tromey  <tom@tromey.com>
2624
2625         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2626         declare.
2627         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2628
2629 2019-06-22  Tom de Vries  <tdevries@suse.de>
2630
2631         * dwarf2read.c (create_addrmap_from_aranges)
2632         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2633         instead of '%zu'.
2634
2635 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2636
2637         * dwarf2read.h (dwarf2_section_info_def): Remove.
2638         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2639         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2640         std::vector<dwarf2_section_info>.
2641         (struct dwo_file) <~dwo_file>: Remove.
2642         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2643         types field.
2644         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2645         (dwarf2_read_debug_names): Likewise.
2646         (create_debug_types_hash_table): Change parameter type to
2647         array_view, adjust code accordingly.
2648         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2649         (partial_die_info::fixup): Likewise.
2650         (determine_prefix): Likewise.
2651         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2652
2653 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2654
2655         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2656         gdb_bfd_ref_ptr.
2657         <~dwo_file>: Remove call to gdb_bfd_unref.
2658         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2659         gdb_bfd_ref_ptr::get.
2660
2661 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2662
2663         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2664         type to htab_up.
2665         * dwarf2read.c (struct dwo_file): Initialize fields.
2666         <~dwo_file>: New.
2667         (free_dwo_file): Remove, move content to ~dwo_file.
2668         (struct dwo_file_deleter): Remove.
2669         (dwo_file_up>: Remove custom deleter.
2670         (free_dwo_files): Remove.
2671         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2672         dwo_files.
2673         (process_skeletonless_type_units): Call unique_ptr::get.
2674         (allocate_dwo_file_hash_table): Add deleter to created hash
2675         table.  Change return type to htab_up.
2676         (lookup_dwo_file_slot): Don't memset dwo_file, call
2677         unique_ptr::get.
2678         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2679         (create_dwo_unit_in_dwp_v2): Likewise.
2680         (open_and_init_dwo_file): Likewise.
2681         (free_dwo_file_from_slot): Remove.
2682
2683 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2684
2685         * dwarf2read.h (struct dwarf2_section_info) <readin,
2686         is_virtual>: Change type to bool.
2687         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2688         true instead of 1.
2689
2690 2019-06-19  Tom Tromey  <tom@tromey.com>
2691
2692         * tui/tui-data.h (tui_init_content_element): Don't declare.
2693
2694 2019-06-19  Tom Tromey  <tom@tromey.com>
2695
2696         * tui/tui-data.h (tui_init_win_info): Don't declare.
2697
2698 2019-06-19  Tom de Vries  <tdevries@suse.de>
2699
2700         * dwarf2read.h (abstract_to_concrete): Change type to
2701         std::unordered_map<sect_offset, std::vector<sect_offset>,
2702         gdb::hash_enum<sect_offset>>.
2703
2704 2019-06-19  Tom Tromey  <tromey@adacore.com>
2705
2706         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2707         EVAL_AVOID_SIDE_EFFECTS specially.
2708
2709 2019-06-19  Tom Tromey  <tromey@adacore.com>
2710
2711         * source-cache.c (highlighter): New global.
2712         (source_cache::get_source_lines): Create a highlighter on demand.
2713
2714 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2715
2716         * defs.h (deprecated_interactive_hook): Delete declaration.
2717         * interps.c (clear_interpreter_hooks): Remove use of
2718         deprecated_interactive_hook.
2719         * top.c (deprecated_interactive_hook): Delete definition.
2720         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2721
2722 2019-06-18  Tom de Vries  <tdevries@suse.de>
2723
2724         PR gdb/24515
2725         * dwarf2read.h (abstract_to_concrete): Change type from
2726         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2727         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2728         * dwarf2read.c (read_variable): Update.
2729         (dwarf2_fetch_die_loc_sect_off): Update.
2730
2731 2019-06-17  Tom de Vries  <tdevries@suse.de>
2732
2733         PR gdb/24617
2734         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2735         accessing parent[parent_len - 1].
2736
2737 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2738
2739         PR gdb/24364
2740         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2741         call dtrace_process_dof with NULL dof.
2742
2743 2019-06-16  Tom de Vries  <tdevries@suse.de>
2744
2745         PR gdb/24445
2746         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2747
2748 2019-06-16  Tom Tromey  <tom@tromey.com>
2749
2750         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2751         (make_all_visible): Use address of member.
2752
2753 2019-06-16  Tom Tromey  <tom@tromey.com>
2754
2755         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2756         (tui_free_window, free_content, free_content_elements): Remove
2757         unnecessary cast.
2758         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2759         cast.
2760         * tui/tui-regs.c (tui_show_register_group)
2761         (tui_display_registers_from, tui_display_reg_element_at_line):
2762         Remove unnecessary cast.
2763
2764 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2765
2766         * linux-nat.c (normal_mask): Delete.
2767         (_initialize_linux_nat): Don't initialise normal_mask.
2768
2769 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2770
2771         PR gdb/24445
2772         * dwarf-index-write.h (write_psymtabs_to_index): Add
2773         dwz_basename parameter.
2774         * dwarf-index-write.c (write_gdbindex): Move file writing to
2775         write_gdbindex_1.  Change return type void.
2776         (assert_file_size): Move up, remove filename parameter.
2777         (write_gdbindex_1): New function.
2778         (write_debug_names): Change return type to void, call
2779         assert_file_size.
2780         (struct index_wip_file): New struct.
2781         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2782         file logic to index_wip_file.  Write index for dwz file if
2783         needed.
2784         (save_gdb_index_command): Pass basename of dwz file, if present.
2785         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2786         build-id of dwz file, if present.
2787         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2788         (dwarf2_get_dwz_file): Likewise.
2789         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2790         (dwarf2_get_dwz_file): Likewise.
2791
2792 2019-06-16  Tom Tromey  <tom@tromey.com>
2793
2794         * coffread.c (process_coff_symbol): Use xstrdup.
2795         * value.c (create_internalvar): Use xstrdup.
2796
2797 2019-06-16  Tom Tromey  <tom@tromey.com>
2798
2799         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2800         * breakpoint.c (stopin_command, stopat_command)
2801         (until_break_command, decode_location_default): Remove unnecessary
2802         cast.
2803         * utils.c (subset_compare): Remove unnecessary cast.
2804         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2805         cast.
2806         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2807         cast.
2808         * infcmd.c (path_command): Remove unnecessary cast.
2809         * coffread.c (decode_type): Remove unnecessary cast.
2810         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2811         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2812         * tui/tui-stack.c (tui_show_locator_content)
2813         (tui_show_frame_info): Remove unnecessary cast.
2814         * tui/tui-win.c (tui_scroll_forward_command)
2815         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2816         (parse_scrolling_args): Remove unnecessary cast.
2817         * tui/tui-data.c (init_win_info, tui_del_window)
2818         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2819         (free_content_elements): Remove unnecessary cast.
2820         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2821         unnecessary cast.
2822         * tui/tui-source.c (tui_set_source_content)
2823         (tui_vertical_source_scroll): Remove unnecessary cast.
2824         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2825         cast.
2826         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2827         * tui/tui-regs.c (tui_display_registers_from)
2828         (tui_display_register): Remove unnecessary cast.
2829         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2830         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2831         (make_visible): Remove unnecessary cast.
2832         * tui/tui-winsource.c (tui_erase_source_content)
2833         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2834         unnecessary cast.
2835         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2836         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2837         * stabsread.c (read_type, read_array_type, read_range_type):
2838         Remove unnecessary cast.
2839         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2840         (parse_symbol, parse_type, upgrade_type, parse_external)
2841         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2842         unnecessary cast.
2843         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2844
2845 2019-06-16  Tom Tromey  <tom@tromey.com>
2846
2847         * tui/tui-data.c (tui_alloc_generic_win_info)
2848         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2849         checks.
2850
2851 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2852             Andrew Burgess  <andrew.burgess@embecosm.com>
2853
2854         * f-typeprint.c (f_print_type): Don't return early for not
2855         associated or not allocated types.
2856         (f_type_print_varspec_suffix): Add print_rank parameter and print
2857         ranks of array types in case they dangling.
2858         (f_type_print_base): Add print_rank parameter.
2859
2860 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2861
2862         * NEWS: Mention new MI commands.
2863         * break-catch-throw.c (enum exception_event_kind): Move to
2864         breakpoint.h.
2865         (print_mention_exception_catchpoint): Output text as a single
2866         message.
2867         (catch_exception_command_1): Rename to...
2868         (catch_exception_event): ...this, make non-static, update header
2869         command, and change some parameter types.
2870         (catch_catch_command): Update for changes to
2871         catch_exception_command_1.
2872         (catch_throw_command): Likewise.
2873         (catch_rethrow_command): Likewise.
2874         * breakpoint.c (enum exception_event_kind): Delete.
2875         * breakpoint.h (enum exception_event_kind): Moved here from
2876         break-catch-throw.c.
2877         (catch_exception_event): Declare.
2878         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2879         (mi_cmd_catch_throw): New function.
2880         (mi_cmd_catch_rethrow): New function.
2881         (mi_cmd_catch_catch): New function.
2882         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2883         'catch-catch' entries.
2884         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2885         (mi_cmd_catch_rethrow): Declare.
2886         (mi_cmd_catch_catch): Declare.
2887
2888 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2889
2890         * annotate.c (annotate_source_line): Change return type to void,
2891         update implementation to match.
2892         * annotate.h (annotate_source_line): Change return type to void,
2893         update header comment.
2894         * stack.c (print_frame_info): Don't change what frame information
2895         is printed based on whether annotations are on or not.
2896
2897 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2898
2899         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2900         (annotate_source): Make static.
2901         (annotate_source_line): Moved from source.c and renamed from
2902         identify_source_line.  Update the return type.
2903         * annotate.h (annotate_source): Delete declaration.
2904         (annotate_source_line): Declaration moved from source.h, and
2905         renamed from identify_source_line.  Return type updated.
2906         * source.c (identify_source_line): Moved to annotate.c and renamed
2907         to annotate_source_line.
2908         (info_line_command): Remove check of annotation_level.
2909         * source.h (identify_source_line): Move declaration to annotate.h
2910         and rename to annotate_source_line.
2911         * stack.c: Add 'annotate.h' include.
2912         (print_frame_info): Remove check of annotation_level before
2913         calling annotate_source_line.
2914
2915 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2916
2917         * source-cache.c (source_cache::get_plain_source_lines): Use
2918         open_source_file_with_line_charpos instead of just
2919         open_source_file, remove call to find_source_lines.
2920         (source_cache::get_source_lines): Likewise.
2921         * source.c (find_source_lines): Make static.
2922         (get_filename_and_charpos): Renamed into...
2923         (open_source_file_with_line_charpos): ..this along with changes to
2924         return a scoped_fd, and some other minor clean ups.
2925         (identify_source_line): Use open_source_file_with_line_charpos.
2926         (search_command_helper): Use open_source_file_with_line_charpos
2927         instead of just open_source_file, remove call to
2928         find_source_lines.
2929         * source.h (open_source_file_with_line_charpos): Declare new
2930         function.
2931         (find_source_lines): Delete declaration.
2932
2933 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2934
2935         * source.c (get_filename_and_charpos): Remove fullname
2936         parameter.
2937         (identify_source_line): Update call to get_filename_and_charpos.
2938
2939 2019-06-14  Tom Tromey  <tromey@adacore.com>
2940
2941         PR gdb/24502:
2942         * ui-style.h (skip_ansi_escape): Update comment.
2943         * ui-file.h (class no_terminal_escape_file): New class.
2944         * ui-file.c (no_terminal_escape_file::write)
2945         (no_terminal_escape_file::puts): New methods.
2946         * cli/cli-logging.c (handle_redirections): Use
2947         no_terminal_escape_file.
2948
2949 2019-06-14  Tom Tromey  <tromey@adacore.com>
2950
2951         * NEWS: Move convenience variable news above Python news.
2952
2953 2019-06-14  Tom Tromey  <tom@tromey.com>
2954
2955         * gnulib: Move directory to top-level.
2956         * configure.ac: Don't configure gnulib.
2957         * configure: Rebuild.
2958         * common/common-defs.h: Use new path to gnulib.
2959         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2960         (GNULIB_H): Remove.
2961         (INCGNU): Look in new gnulib location.
2962         (HFILES_NO_SRCDIR): Remove gnulib files.
2963         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2964         (generated_files): Remove GNULIB_H.
2965         ($(LIBGNU), all-lib): Remove targets.
2966         (distclean): Don't mention GNULIB_BUILDDIR.
2967         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2968
2969 2019-06-14  Tom Tromey  <tromey@adacore.com>
2970
2971         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2972         Warn if symbol file does not provide any symbols.
2973
2974 2019-06-14  Tom Tromey  <tromey@adacore.com>
2975
2976         * source.c (find_and_open_source): Respect basenames_may_differ.
2977
2978 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2979
2980         * annotate.c (annotate_breakpoints_invalid): Make use of
2981         scoped_restore_terminal_state.
2982         (annotate_frames_invalid): Likewise.
2983
2984 2019-06-14  Tom Tromey  <tromey@adacore.com>
2985
2986         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2987         allow assignment to an internalvar.
2988
2989 2019-06-14  Tom Tromey  <tromey@adacore.com>
2990
2991         * ada-lex.l: Allow "_" in attribute names.
2992
2993 2019-06-14  Tom Tromey  <tromey@adacore.com>
2994
2995         PR gdb/24653:
2996         * regcache.c (registers_changed): Don't call alloca.
2997         * top.c (execute_command): Don't call alloca.
2998
2999 2019-06-13  Pedro Alves  <palves@redhat.com>
3000
3001         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
3002         'expression'.  When parsing an expression, error out if there's
3003         junk after "unlimited".
3004         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3005         (do_set_command): Adjust calls to is_unlimited_literal.
3006
3007 2019-06-13  Pedro Alves  <palves@redhat.com>
3008
3009         * compile/compile.c (make_compile_options_def_group): Add braces
3010         around array_view initializer.
3011         * thread.c (make_thread_apply_all_options_def_group)
3012         (make_thread_apply_all_options_def_group): Likewise.
3013
3014 2019-06-13  Pedro Alves  <palves@redhat.com>
3015
3016         * NEWS (New commands): Mention "maint test-options
3017         require-delimiter", "maint test-options unknown-is-error", "maint
3018         test-options unknown-is-operand" and "maint show
3019         test-options-completion-result".
3020         (New command options, command completion): New section.
3021         (Completion improvements): New section.
3022         Mention that you can abbreviate "unlimited".
3023
3024 2019-06-13  Pedro Alves  <palves@redhat.com>
3025
3026         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
3027         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
3028         * unittests/cli-utils-selftests.c (test_parse_flags)
3029         (test_parse_flags_qcs): Delete.
3030         (test_cli_utils): Don't call deleted functions.
3031
3032 2019-06-13  Pedro Alves  <palves@redhat.com>
3033
3034         * thread.c: Include "cli/cli-option.h".
3035         (tp_array_compar_ascending): Global.
3036         (tp_array_compar): Delete function.
3037         (tp_array_compar_ascending, tp_array_compar_descending): New
3038         functions.
3039         (ascending_option_def, qcs_flag_option_def)
3040         (thr_qcs_flags_option_defs)
3041         (make_thread_apply_all_options_def_group)
3042         (make_thread_apply_options_def_group): New.
3043         (thread_apply_all_command): Use gdb::option::process_options.
3044         (thread_apply_command_completer)
3045         (thread_apply_all_command_completer): New.
3046         (thread_apply_command): Use gdb::option::process_options.
3047         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
3048         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
3049         to generate help text of "thread apply".  Adjust "taas"'s help.
3050         * tid-parse.c (tid_range_parser::in_thread_range): New method.
3051         * tid-parse.h (tid_range_parser::in_thread_range): New method.
3052
3053 2019-06-13  Pedro Alves  <palves@redhat.com>
3054
3055         * thread.c (thread_apply_command): Check for invalid TID with
3056         isdigit instead of !isalpha.
3057
3058 2019-06-13  Pedro Alves  <palves@redhat.com>
3059
3060         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
3061         (validate_flags_qcs): New.
3062         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
3063         (validate_flags_qcs): Declare.
3064         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
3065         (make_frame_apply_options_def_group): New.
3066         (frame_apply_command_count): Process options with
3067         gdb::option::process_options.
3068         (frame_apply_completer): New.
3069         (frame_apply_level_completer, frame_apply_all_completer)
3070         (frame_apply_completer): New.
3071         (_initialize_stack): Update help of "frame apply", "frame apply
3072         level", "frame apply all" and "faas" to mention supported options
3073         and install command completers.
3074         * stack.h (frame_apply_all_completer): Declare.
3075         * thread.c: Include "stack.h".
3076         (tfaas_command): Add "--".
3077         (_initialize_thread): Update help "tfaas" to mention supported
3078         options and install command completer.
3079
3080 2019-06-13  Pedro Alves  <palves@redhat.com>
3081
3082         * completer.c (complete_nested_command_line): New.
3083         (gdb_completion_word_break_characters_throw): Add assertion.
3084         * completer.h (complete_nested_command_line): Declare.
3085
3086 2019-06-13  Pedro Alves  <palves@redhat.com>
3087
3088         * stack.c (parse_backtrace_qualifiers): New.
3089         (backtrace_command): Use it.
3090         (backtrace_command_completer): Complete on qualifiers.
3091
3092 2019-06-13  Pedro Alves  <palves@redhat.com>
3093
3094         * frame.c: Include "cli/cli-option.h.
3095         (user_set_backtrace_options): New.
3096         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3097         Delete.
3098         (get_prev_frame): Adjust.
3099         (boolean_option_def, uinteger_option_def)
3100         (set_backtrace_option_defs): New.
3101         (_initialize_frame): Adjust and use
3102         gdb::option::add_setshow_cmds_for_options to install "set
3103         backtrace past-main" and "set backtrace past-entry".
3104         * frame.h: Include "cli/cli-option.h".
3105         (struct frame_print_options): Forward declare.
3106         (print_frame_arguments_all, print_frame_arguments_scalars)
3107         (print_frame_arguments_none): Declare.
3108         (print_entry_values): Delete declaration.
3109         (struct frame_print_options, user_frame_print_options): New.
3110         (struct set_backtrace_options): New.
3111         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3112         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3113         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3114         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3115         (list_args_or_locals): Add frame_print_options parameter.
3116         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3117         * python/py-framefilter.c (enumerate_args): Pass down
3118         USER_FRAME_PRINT_OPTIONS.
3119         * stack.c: Include "cli/cli-option.h".
3120         (print_frame_arguments_all, print_frame_arguments_scalars)
3121         (print_frame_arguments_none): Declare.
3122         (print_raw_frame_arguments, print_entry_values): Delete.
3123         (user_frame_print_options): New.
3124         (boolean_option_def, enum_option_def, frame_print_option_defs):
3125         New.
3126         (struct backtrace_cmd_options): New.
3127         (bt_flag_option_def): New.
3128         (backtrace_command_option_defs): New.
3129         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3130         (print_frame_arg, read_frame_arg, print_frame_args)
3131         (print_frame_info, print_frame): Add frame_print_options parameter
3132         and use it.
3133         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3134         (backtrace_command_1): Add frame_print_options and
3135         backtrace_cmd_options parameters and use them.
3136         (make_backtrace_options_def_group): New.
3137         (backtrace_command): Process command options with
3138         gdb::option::process_options.
3139         (backtrace_command_completer): New.
3140         (_initialize_stack): Extend "backtrace"'s help to mention
3141         supported options.  Install completer for "backtrace".
3142         Install some settings commands with add_setshow_cmds_for_options.
3143
3144 2019-06-13  Pedro Alves  <palves@redhat.com>
3145
3146         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3147         and that "set/show print raw frame-arguments" are now deprecated.
3148
3149         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3150         command.
3151         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3152         * stack.c (_initialize_stack): Install "set/show print
3153         raw-frame-arguments", and deprecate "set/show print raw
3154         frame-arguments".
3155         * valprint.c (_initialize_valprint): Deprecate "set/show print
3156         raw".
3157
3158 2019-06-13  Pedro Alves  <palves@redhat.com>
3159
3160         * compile/compile.c (struct compile_options): New.
3161         (compile_flag_option_def, compile_command_option_defs)
3162         (make_compile_options_def_group): New.
3163         (compile_file_command): Handle options with
3164         gdb::option::process_options.
3165         (compile_file_command_completer): New function.
3166         (compile_code_command): Handle options with
3167         gdb::option::process_options.
3168         (compile_code_command_completer): New function.
3169         (_initialize_compiler): Install completers for "compile code" and
3170         "compile file".  Mention available options in "compile code" and
3171         "compile code"'s help.
3172         * completer.c (advance_to_completion_word): New, factored out from
3173         ...
3174         (advance_to_expression_complete_word_point): ... this.
3175         (advance_to_filename_complete_word_point): New.
3176         * completer.h (advance_to_filename_complete_word_point): New
3177         declaration.
3178
3179 2019-06-13  Pedro Alves  <palves@redhat.com>
3180
3181         * compile/compile.c: Include "cli/cli-option.h".
3182         (compile_print_value): Scope data pointer is now a
3183         value_print_options pointer; adjust.
3184         (compile_print_command): Process options.  Scope data pointer is
3185         now a value_print_options pointer; adjust.
3186         (_initialize_compile): Update "compile print"'s help to include
3187         supported options.  Install a completer for "compile print".
3188         * cp-valprint.c (show_vtblprint, show_objectprint)
3189         (show_static_field_print): Delete.
3190         (_initialize_cp_valprint): Don't install "set print
3191         static-members", "set print vtbl", "set print object" here.
3192         * printcmd.c: Include "cli/cli-option.h" and
3193         "common/gdb_optional.h".
3194         (print_command_parse_format): Rework to fill in a
3195         value_print_options instead of a format_data.
3196         (print_value): Change parameter type from format_data pointer to
3197         value_print_options reference.  Adjust.
3198         (print_command_1): Process options.  Adjust to pass down a
3199         value_print_options.
3200         (print_command_completer): New.
3201         (_initialize_printcmd): Install print_command_completer as
3202         handle_brkchars completer for the "print" command.  Update
3203         "print"'s help to include supported options.
3204         * valprint.c: Include "cli/cli-option.h".
3205         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3206         here from cp-valprint.c.
3207         (boolean_option_def, uinteger_option_def)
3208         (value_print_option_defs, make_value_print_options_def_group):
3209         New.  Use gdb::option::add_setshow_cmds_for_options to install
3210         "set print elements", "set print null-stop", "set print repeats",
3211         "set print pretty", "set print union", "set print array", "set
3212         print address", "set print symbol", "set print array-indexes".
3213         * valprint.h: Include <string> and "cli/cli-option.h".
3214         (make_value_print_options_def_group): Declare.
3215         (print_value): Change parameter type from format_data pointer to
3216         value_print_options reference.
3217         (print_command_completer): Declare.
3218
3219 2019-06-13  Pedro Alves  <palves@redhat.com>
3220
3221         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3222         (COMMON_SFILES): Add maint-test-settings.c.
3223         * cli/cli-decode.c (boolean_enums): New global, factored out from
3224         ...
3225         (add_setshow_boolean_cmd): ... here.
3226         * cli/cli-decode.h (boolean_enums): Declare.
3227         * cli/cli-option.c: New file.
3228         * cli/cli-option.h: New file.
3229         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3230         factored out from ...
3231         (parse_cli_boolean_value(const char *)): ... this.
3232         (is_unlimited_literal): Change parameter type to pointer to
3233         pointer.  Adjust and advance ARG pointer.
3234         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3235         (parse_cli_var_enum): New, factored out from ...
3236         (do_set_command): ... this.  Adjust.
3237         * cli/cli-setshow.h (parse_cli_boolean_value)
3238         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3239         (parse_cli_var_enum): Declare.
3240         * cli/cli-utils.c: Include "cli/cli-option.h".
3241         (get_ulongest): New.
3242         * cli/cli-utils.h (get_ulongest): Declare.
3243         (check_for_argument): New overloads.
3244         * maint-test-options.c: New file.
3245
3246 2019-06-13  Pedro Alves  <palves@redhat.com>
3247
3248         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3249         parse a range if "-" is at the end of the string.
3250
3251 2019-06-13  Pedro Alves  <palves@redhat.com>
3252
3253         * cli/cli-setshow.c (parse_auto_binary_operation)
3254         (parse_cli_boolean_value): Don't allow "o".
3255
3256 2019-06-13  Pedro Alves  <palves@redhat.com>
3257
3258         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3259         * NEWS: Mention maint test-settings KIND.
3260         * maint-test-settings.c: New file.
3261
3262 2019-06-13  Pedro Alves  <palves@redhat.com>
3263
3264         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3265         completer.
3266         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3267         "set" completers.
3268
3269 2019-06-13  Pedro Alves  <palves@redhat.com>
3270
3271         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3272         after item.
3273
3274 2019-06-13  Pedro Alves  <palves@redhat.com>
3275
3276         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3277
3278 2019-06-13  Pedro Alves <palves@redhat.com>
3279
3280         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3281         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3282         call.
3283         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3284         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3285         calls.
3286         (check_for_argument): Skip spaces after argument.
3287
3288 2019-06-13  Pedro Alves  <palves@redhat.com>
3289
3290         * thread.c (thread_apply_command): Adjust TID parsing.
3291         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3292         detected before end of string.
3293         (tid_is_in_list): Error out if LIST is invalid.
3294
3295 2019-06-13  Pedro Alves  <palves@redhat.com>
3296
3297         * completer.c (complete_line_internal_1): Rewind completion word
3298         point.
3299         (completion_tracker::advance_custom_word_point_by): Change
3300         parameter type to int.
3301         * completer.h (completion_tracker::advance_custom_word_point_by):
3302         Likewise.
3303
3304 2019-06-13  Pedro Alves  <palves@redhat.com>
3305
3306         * completer.c (advance_to_completion_word): Handle delimiters.
3307
3308 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3309
3310         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3311
3312 2019-06-11  Tom Tromey  <tom@tromey.com>
3313
3314         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3315         (xmalloc_failed): Move to alloc.c.
3316         * alloc.c: New file.
3317         * Makefile.in (COMMON_SFILES): Add alloc.c.
3318
3319 2019-06-11  Tom Tromey  <tom@tromey.com>
3320
3321         * nat/linux-waitpid.c: Don't include server.h.
3322         (linux_debug): Remove.
3323         (my_waitpid): Update.
3324
3325 2019-06-11  Tom Tromey  <tromey@adacore.com>
3326
3327         * infcall.c (_initialize_infcall): Remove trailing newline from
3328         help.
3329         * user-regs.c (_initialize_user_regs): Remove trailing newline
3330         from help.
3331         * typeprint.c (_initialize_typeprint): Remove trailing newline
3332         from help.
3333         * reverse.c (_initialize_reverse): Remove trailing newlines from
3334         help.
3335         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3336         from help.
3337         * language.c (add_set_language_command): Remove trailing newline
3338         from help.
3339         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3340         help.
3341         * disasm.c (_initialize_disasm): Remove trailing newline from
3342         help.
3343         * top.c (init_main): Remove trailing newline from help.
3344         * interps.c (_initialize_interpreter): Remove trailing newline
3345         from help.
3346         * btrace.c (_initialize_btrace): Remove trailing newlines from
3347         help.
3348         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3349         from help.
3350         * python/python.c (_initialize_python): Remove trailing newline
3351         from help.
3352         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3353         help.
3354         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3355         from help.  Reformat some text.
3356         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3357         from help.
3358         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3359         newline from help.
3360
3361 2019-06-11  Tom Tromey  <tromey@adacore.com>
3362
3363         * darwin-nat.c (darwin_decode_exception_message)
3364         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3365
3366 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3367
3368         * valops.c (value_slice): Check for not allocated or not
3369         associated values.
3370
3371 2019-06-10  Tom de Vries  <tdevries@suse.de>
3372
3373         PR gdb/24618
3374         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3375         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3376         invalid.
3377
3378 2019-06-10  Tom de Vries  <tdevries@suse.de>
3379
3380         PR gdb/24611
3381         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3382         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3383
3384 2019-06-10  Tom de Vries  <tdevries@suse.de>
3385
3386         PR symtab/24545
3387         * symtab.c (struct demangled_name_entry): Add language field.
3388         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3389         static minimal symbol".  Set and use language field.
3390
3391 2019-06-10  Tom Tromey  <tromey@adacore.com>
3392
3393         * ada-lang.c (_initialize_ada_language): Update help text.
3394
3395 2019-06-10  Tom Tromey  <tromey@adacore.com>
3396
3397         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3398         with a newline.
3399         * guile/guile.c (handle_boot_error): Don't end warning with a
3400         newline.
3401         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3402         warning with a newline.
3403         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3404         newline.
3405         (s12z_frame_cache): Likewise.
3406         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3407         a newline.
3408         * solib-svr4.c (disable_probes_interface): Don't end warning with
3409         a newline.
3410         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3411         newline.
3412         * python/python.c (do_finish_initialization): Don't end warning
3413         with a newline.
3414
3415 2019-06-10  Tom Tromey  <tom@tromey.com>
3416
3417         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3418         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3419         gdbpy_enter.
3420
3421 2019-06-10  Tom Tromey  <tromey@adacore.com>
3422
3423         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3424         data.
3425         (elf_new_init): Don't call stabsread_new_init.
3426         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3427         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3428         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3429
3430 2019-06-10  Tom de Vries  <tdevries@suse.de>
3431
3432         PR symtab/16264
3433         PR symtab/24517
3434         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3435
3436 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3437
3438         * source.c (find_and_open_source): Also rewrite relative file
3439         names.
3440
3441 2019-04-26  Amos Bird  <amosbird@gmail.com>
3442
3443         * annotate.c (annotate_thread_exited): Add "thread-exited"
3444         annotation.
3445
3446 2019-06-06  Tom Tromey  <tromey@adacore.com>
3447
3448         * maint.h (class scoped_command_stats): Use
3449         DISABLE_COPY_AND_ASSIGN.
3450         <print_time>: New method.
3451         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3452         print_time.
3453         (scoped_command_stats::print_time): New method.
3454
3455 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3456
3457         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3458         instructions of lengths 6 or 8 bytes.
3459
3460 2019-06-04  Pedro Alves  <palves@redhat.com>
3461
3462         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3463
3464         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3465         * breakpoint.c (condition_completer): Likewise.
3466         * cli/cli-dump.c (scan_expression): Likewise.
3467         * common/filestuff.c (mkdir_recursive): Likewise.
3468         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3469         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3470         (gdb_abspath): Likewise.
3471         * compile/compile-cplus-types.c
3472         (compile_cplus_instance::decl_name): Likewise.
3473         * completer.c (complete_explicit_location):
3474         (signal_completer, reg_or_group_completer_1): Likewise.
3475         * cp-support.c (cp_remove_params_if_any): Likewise.
3476         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3477         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3478         * infcmd.c (strip_bg_char): Likewise.
3479         * linespec.c (copy_token_string): Likewise.
3480         * mi/mi-main.c (output_cores): Likewise.
3481         * psymtab.c (psymtab_search_name):
3482         * symfile.c (test_set_ext_lang_command): Likewise.
3483         * target.c (target_fileio_read_stralloc): Likewise.
3484         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3485         * value.c (complete_internalvar): Likewise.
3486
3487 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3488
3489         Add objfile property to gdb.Type.
3490         * NEWS: Mention Python API addition.
3491         * python/py-type.c (typy_get_objfile): New method.
3492
3493 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3494
3495         * NEWS: Mention the new set|show style [title|highlight].
3496         Mention changes to "show style", "help" and "apropos".
3497
3498 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3499
3500         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3501         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3502         instead of print_help_for_command.
3503         (print_doc_of_command): New function.
3504         (help_list): Add 'apropos -v word' suggestion.
3505         (print_help_for_command): Style the command name using title style.
3506         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3507         (_initialize_cli_cmds): Describe -v in apropos_command help.
3508
3509 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3510
3511         * cli/cli-style.h (cli_style_option): Add name in constructor,
3512         add m_name class member, add constructor with intensity,
3513         add name class function.
3514         (cli_style_option::add_setshow_commands): Remove name argument.
3515         (highlight_style, title_style): New styles.
3516         * cli/cli-style.c (do_show): New function that shows a style
3517         characteristic styling the style name with itself.
3518         (set_style_name): New function.
3519         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3520         Update all callers according to the changes in cli/cli-style.h.
3521         * utils.h (fputs_highlighted): New function.
3522         * utils.c (fputs_highlighted): Likewise.
3523
3524 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3525
3526         * NEWS: Mention new pipe command and new convenience variables.
3527
3528 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3529
3530         * cli/cli-cmds.c (pipe_command): New function.
3531         (_initialize_cli_cmds): Call add_com for pipe_command.
3532         Define | as an alias for pipe.
3533         (exit_status_set_internal_vars): New function.
3534         (shell_escape): Call exit_status_set_internal_vars.
3535         cli/cli-decode.c (find_command_name_length): Recognize | as
3536         a single character command.
3537
3538 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3539
3540         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3541         top.c (execute_command_to_ui_file): New function, mostly a copy
3542         of execute_command_to_string.
3543         (execute_command_to_string): Implement by calling
3544         execute_command_to_ui_file.
3545
3546 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3547
3548         * top.h (saved_command_line): Remove declaration.
3549         * top.c (previous_saved_command_line, previous_repeat_arguments):
3550         New variables.
3551         (saved_command_line): Make static, define together with other
3552         'repeat variables'.
3553         (dont_repeat): Clear repeat_arguments.
3554         (repeat_previous, get_saved_command_line, save_command_line):
3555         New functions.
3556         (gdb_init): Initialize saved_command_line
3557         and previous_saved_command_line.
3558         * main.c (captured_main_1): Remove saved_command_line initialization.
3559         * event-top.c (handle_line_of_input): Update to use
3560         the new 'repeat' related functions instead of direct access to
3561         saved_command_line.
3562         * command.h (repeat_previous, get_saved_command_line,
3563         save_command_line): New declarations.
3564         (dont_repeat): Add comment.
3565
3566 2019-05-30  Tom Tromey  <tromey@adacore.com>
3567
3568         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3569         Fix comment.
3570         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3571
3572 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3573
3574         PR cli/24587
3575         * completer.c (complete): Initialize variable word.
3576
3577 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3578
3579         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3580         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3581         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3582         'body' is NULL to the outter 'if', protecting the '!is_define'
3583         situation as well.
3584
3585 2019-05-29  Tom Tromey  <tromey@adacore.com>
3586
3587         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3588         (dwarf_unknown): New function.
3589         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3590         (dwarf_type_encoding_name): Use dwarf_unknown.
3591
3592 2019-05-29  Tom Tromey  <tromey@adacore.com>
3593
3594         PR c++/20020:
3595         * cp-valprint.c (cp_print_value_fields): Call
3596         cp_print_static_field inside "try".
3597
3598 2019-05-29  Tom Tromey  <tromey@adacore.com>
3599
3600         * inflow.c (struct terminal_info): Add default operator=.
3601         * configure: Rebuild.
3602         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3603         -Wdeprecated-copy-dtor, -Wredundant-move.
3604
3605 2019-05-29  Tom Tromey  <tromey@adacore.com>
3606
3607         * NEWS: Add entry.
3608         * infcmd.c (print_return_value_1): Handle finish_print
3609         option.
3610         (show_print_finish): New function.
3611         (_initialize_infcmd): Add "set/show print finish" commands.
3612         * valprint.c (user_print_options): Initialize new member.
3613         * valprint.h (struct value_print_options) <finish_print>: New
3614         member.
3615
3616 2019-05-28  Tom Tromey  <tromey@adacore.com>
3617
3618         * ada-lang.c (ada_remove_Xbn_suffix)
3619         (find_old_style_renaming_symbol)
3620         (parse_old_style_renaming): Remove.
3621         (ada_find_renaming_symbol): Don't call
3622         find_old_style_renaming_symbol.
3623         (ada_is_renaming_symbol): Rename from
3624         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3625         bool.  Now static.
3626         (ada_read_var_value): Update and simplify.
3627         * ada-exp.y (write_var_or_type): Remove old code.
3628
3629 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3630
3631         * event-top.c: Remove include comment.
3632         * inflow.c (class scoped_ignore_sigttou): Move from here...
3633         * inflow.h (class scoped_ignore_sigttou): ...to here.
3634         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3635         * top.c:  Remove include comment.
3636
3637 2019-05-27  Tom Tromey  <tom@tromey.com>
3638
3639         * NEWS: Fix typo.
3640
3641 2019-05-22  Tom Tromey  <tromey@adacore.com>
3642
3643         * target.c (target_follow_exec): Constify parameter.
3644         * target-delegates.c: Rebuild.
3645         * remote.c (remote_target::follow_exec): Constify parameter.
3646         * infrun.c (follow_exec): Constify parameter.
3647         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3648         (target_follow_exec): Likewise.
3649
3650 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3651
3652         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3653         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3654
3655 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3656
3657         * NEWS: Add debugredirect and testsuite sections.
3658
3659 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3660
3661         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3662         target descriptions using exclusively floating point register name
3663         aliases.
3664
3665 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3666
3667         PR gdb/18644:
3668         * f-lang.c (build_fortran_types): Handle the case where
3669         gdbarch_floatformat_for_type returns a nullptr.
3670
3671 2019-05-21  Tom de Vries  <tdevries@suse.de>
3672
3673         PR cli/24587
3674         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3675
3676 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3677
3678         PR gdb/18644:
3679         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3680         16-byte floats.
3681         * i386-tdep.c (i386_floatformat_for_type): Use
3682         floatformats_ia64_quad for the 16-byte floating point component
3683         within a fortran 32-byte complex number.
3684
3685 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3686
3687         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3688         delete default constructor.
3689         (find_partial_die): Update to return const struct.
3690         (partial_die_parent_scope): Move variable declaration into scope
3691         of its use and change its type to auto.
3692         (guess_partial_die_structure_name): Likewise.
3693         (partial_die_info::fixup): Likewise.
3694
3695 2019-05-17  Tom Tromey  <tromey@adacore.com>
3696
3697         * source.c (find_and_open_source): Remove cast.
3698
3699 2019-05-17  Tom Tromey  <tromey@adacore.com>
3700
3701         * annotate.c (annotate_source): Make "filename" const.
3702         * annotate.h (annotate_source): Use const.
3703
3704 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3705
3706         * disasm.c (set_disassembler_options): Send errors to stderr.
3707
3708 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3709
3710         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3711         (cli_interp_base::set_logging): Check debug_redirect.
3712         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3713         * cli/cli-logging.c (debug_redirect): Add static variable.
3714         (pop_output_files): Add default param.
3715         (handle_redirections): Print debug setting.
3716         (show_logging_command): Likewise.
3717         (_initialize_cli_logging): Add debugredirect command.
3718         * interps.c (current_interp_set_logging): Add debug_redirect
3719         parameter.
3720         * interps.h (set_logging): Add debug_redirect parameter.
3721         (current_interp_set_logging): Likewise.
3722         * mi/mi-common.h: Likewise.
3723         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3724
3725 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3726             Tom Tromey  <tromey@adacore.com>
3727
3728         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3729         directly.
3730         * cli/cli-interp.h (make_logging_output): Remove declaration.
3731         * cli/cli-logging.c (make_logging_output): Remove function.
3732         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3733         directly.
3734         * ui-file.c (tee_file::tee_file): Remove bools.
3735         (tee_file::~tee_file): Remove deletes.
3736         * ui-file.h (tee_file): Remove bools.
3737
3738 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3739
3740         * mi/mi-cmds.h (mi_cmd_complete): New function.
3741         * mi/mi-main.c (mi_cmd_complete): Likewise.
3742         * mi/mi-cmds.c: Define new MI command -complete.
3743         * NEWS: Mention new -complete command.
3744
3745 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3746
3747         * completer.h (complete): New function.
3748         * completer.c (complete): Likewise.
3749         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3750         function defined in completer.h.
3751
3752 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3753
3754         * MAINTAINERS (Write After Approval): Add myself.
3755
3756 2019-05-17  Tom de Vries  <tdevries@suse.de>
3757
3758         PR gdb/24094
3759         * dwarf2read.c (struct cu_partial_die_info): New struct.
3760         (find_partial_die): Return cu_partial_die_info.
3761         (partial_die_parent_scope, guess_partial_die_structure_name)
3762         (partial_die_info::fixup): Handle new return type of find_partial_die.
3763
3764 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3765
3766         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3767         "std::string", simplifying the algorithm.
3768
3769 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3770
3771         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3772         (stap_static_probe_ops::get_probes): Likewise.
3773
3774 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3775
3776         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3777         '-')" and "else if".
3778         (stap_parse_single_operand): Join checks for
3779         "gdbarch_stap_parse_special_token_p" and
3780         "gdbarch_stap_parse_special_token" in the same "if" statement.
3781         Invert check when verifying for operation on register
3782         displacement.
3783
3784 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3785
3786         * stap-probe.c (stap_get_opcode): Update comment.
3787         (stap_get_expected_argument_type): Likewise.
3788         (handle_stap_probe): Likewise.
3789
3790 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3791
3792         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3793         return type to 'bool'.  Adjust comment.  Use 'bool' when
3794         appropriate.
3795         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3796         * stap-probe.c (stap_parse_argument_1): Likewise.
3797         (stap_is_operator): Likewise.
3798         (stap_is_generic_prefix): Likewise.
3799         (stap_is_register_prefix): Likewise.
3800         (stap_is_register_indirection_prefix): Likewise.
3801         (stap_is_integer_prefix): Likewise.
3802         (stap_generic_check_suffix): Likewise.
3803         (stap_check_integer_suffix): Likewise.
3804         (stap_check_register_suffix): Likewise.
3805         (stap_check_register_indirection_suffix): Likewise.
3806         (stap_parse_register_operand): Likewise.
3807         (stap_parse_single_operand): Likewise.
3808         (stap_parse_argument_1): Likewise.
3809         (stap_probe::get_argument_count): Likewise.
3810         (stap_is_operator): Likewise.
3811
3812 2019-05-16  Tom Tromey  <tromey@adacore.com>
3813
3814         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3815         keyword to foreach.
3816
3817 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3818
3819         * linux-thread-db.c (try_thread_db_load_1): Change return type
3820         to bool.
3821         (try_thread_db_load): Likewise.
3822         (try_thread_db_load_from_pdir_1): Likewise.
3823         (try_thread_db_load_from_pdir): Likewise.
3824         (try_thread_db_load_from_sdir): Likewise.
3825         (try_thread_db_load_from_dir): Likewise.
3826         (thread_db_load_search): Likewise.
3827         (has_libpthread): Likewise.
3828         (thread_db_load): Likewise.
3829
3830 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3831
3832         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3833         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3834         NULL, and complain/return if that's the case.
3835
3836 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3837
3838         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3839         (advance, posn, abstract_read_memory): New functions.
3840         [struct mem_read_abstraction]: New struct.
3841         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3842
3843 2019-05-14  Tom Tromey  <tromey@adacore.com>
3844
3845         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3846         value is not lval_memory.
3847
3848 2019-05-14  Tom Tromey  <tromey@adacore.com>
3849
3850         * solib.c (info_sharedlibrary_command): Style the file name.
3851
3852 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3853
3854         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3855         (aarch64_vnv_type): Likewise.
3856         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3857         * common/tdesc.c: Likewise.
3858         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3859         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3860         * features/aarch64-fpu.xml: Add ieee half view.
3861         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3862         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3863         * gdbtypes.h (struct builtin_type): Likewise.
3864         (struct objfile_type): Likewise.
3865
3866 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3867
3868         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3869         typo.
3870         * location.h (string_to_event_location): Likewise.
3871
3872 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3873
3874         GDB 8.3 released.
3875
3876 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3877
3878         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3879         New variable declaration.
3880         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3881         New variable.
3882         (print_one_breakpoint): Use ui_out::test_flags and new global
3883         variable to compute use_fixed_output.
3884         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3885         Remove.
3886         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3887         (mi_multi_location_breakpoint_output_fixed): Remove.
3888         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3889         new variable.
3890         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3891         fix_multi_location_breakpoint_output flag if version >= 3.
3892         * ui-out.h (enum ui_out_flag)
3893         <fix_multi_location_breakpoint_output>: New enumerator.
3894
3895 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3896
3897         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3898
3899 2019-05-10  Tom Tromey  <tromey@adacore.com>
3900
3901         * ada-lang.c (catch_ada_completer): New function.
3902         (_initialize_ada_language): Use it.
3903
3904 2019-05-10  Tom Tromey  <tromey@adacore.com>
3905
3906         * thread.c (print_thread_info): Make "requested_threads" const.
3907         * gdbthread.h (print_thread_info): Make "requested_threads"
3908         const.
3909         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3910         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3911
3912 2019-05-08  Tom Tromey  <tom@tromey.com>
3913
3914         * gdbtypes.c (objfile_type_data): Change type.
3915         (objfile_type, _initialize_gdbtypes): Update.
3916
3917 2019-05-08  Tom Tromey  <tom@tromey.com>
3918
3919         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3920         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3921         (_initialize_dwarf2_frame): Update.
3922
3923 2019-05-08  Tom Tromey  <tom@tromey.com>
3924
3925         * objc-lang.c (objc_objfile_data): Change type.
3926         (find_methods): Update.
3927         (_initialize_objc_lang): Remove.
3928
3929 2019-05-08  Tom Tromey  <tom@tromey.com>
3930
3931         * stabsread.c (rs6000_builtin_type_data): Change type.
3932         (rs6000_builtin_type, _initialize_stabsread): Update.
3933
3934 2019-05-08  Tom Tromey  <tom@tromey.com>
3935
3936         * mips-tdep.c (mips_pdr_data): Remove.
3937         (_initialize_mips_tdep): Update.
3938
3939 2019-05-08  Tom Tromey  <tom@tromey.com>
3940
3941         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3942         (hppa_init_objfile_priv_data, read_unwind_info)
3943         (find_unwind_entry, _initialize_hppa_tdep): Update.
3944
3945 2019-05-08  Tom Tromey  <tom@tromey.com>
3946
3947         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3948         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3949         on obstack.
3950         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3951
3952 2019-05-08  Tom Tromey  <tom@tromey.com>
3953
3954         * mdebugread.c (basic_type_data): Change type.
3955         (basic_type, _initialize_mdebugread): Update.
3956
3957 2019-05-08  Tom Tromey  <tom@tromey.com>
3958
3959         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3960
3961 2019-05-08  Tom Tromey  <tom@tromey.com>
3962
3963         * nto-tdep.c (nto_inferior_data_reg): Change type.
3964         (nto_inferior_data): Update.
3965         (nto_inferior_data_cleanup, nto_new_inferior_data)
3966         (_initialize_nto_tdep): Remove.
3967         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3968
3969 2019-05-08  Tom Tromey  <tom@tromey.com>
3970
3971         * ada-lang.c (struct ada_inferior_data): Add initializers.
3972         (ada_inferior_data): Change type.
3973         (ada_inferior_data_cleanup): Remove.
3974         (get_ada_inferior_data, ada_inferior_exit)
3975         (struct ada_pspace_data): Add initializers, destructor.
3976         (ada_pspace_data_handle): Change type.
3977         (get_ada_pspace_data): Update.
3978         (ada_pspace_data_cleanup): Remove.
3979
3980 2019-05-08  Tom Tromey  <tom@tromey.com>
3981
3982         * coffread.c (struct coff_symfile_info): Add initializers.
3983         (coff_objfile_data_key): Move lower.  Change type.
3984         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3985         Update.
3986         (coff_free_info): Remove.
3987
3988 2019-05-08  Tom Tromey  <tom@tromey.com>
3989
3990         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3991         (fbsd_pspace_data_handle): Move lower.  Change type.
3992         (get_fbsd_pspace_data): Update.
3993         (fbsd_pspace_data_cleanup): Remove.
3994         (_initialize_fbsd_tdep): Update.
3995
3996 2019-05-08  Tom Tromey  <tom@tromey.com>
3997
3998         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3999         (get_ada_tasks_pspace_data): Update.
4000         (ada_tasks_pspace_data_cleanup): Remove.
4001         (_initialize_tasks): Update.
4002         (ada_tasks_inferior_data_handle): Change type.
4003         (get_ada_tasks_inferior_data): Update.
4004         (ada_tasks_inferior_data_cleanup): Remove.
4005         (struct ada_tasks_pspace_data): Add initializers.
4006
4007 2019-05-08  Tom Tromey  <tom@tromey.com>
4008
4009         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
4010         * symfile-debug.c (debug_sym_get_probes): Change type.
4011         * stap-probe.c (handle_stap_probe):
4012         (stap_static_probe_ops::get_probes): Change type.
4013         * probe.h (class static_probe_ops) <get_probes>: Change type.
4014         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
4015         (parse_probes_in_pspace): Update.
4016         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
4017         Update.
4018         (any_static_probe_ops::get_probes): Change type.
4019         * elfread.c (elfread_data): New typedef.
4020         (probe_key): Change type.
4021         (elf_get_probes): Likewise.  Update.
4022         (probe_key_free): Remove.
4023         (_initialize_elfread): Update.
4024         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
4025         Change type.
4026         (dtrace_process_dof_probe, dtrace_process_dof)
4027         (dtrace_static_probe_ops::get_probe): Change type.
4028
4029 2019-05-08  Tom Tromey  <tom@tromey.com>
4030
4031         * xcoffread.c (struct xcoff_symfile_info): Rename from
4032         coff_symfile_info.  Add initializers.
4033         (xcoff_objfile_data_key): Move lower.  Change type.
4034         (XCOFF_DATA): Rewrite.
4035         (xcoff_free_info): Remove.
4036         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
4037         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
4038         (xcoff_initial_scan): Update.
4039
4040 2019-05-08  Tom Tromey  <tom@tromey.com>
4041
4042         * solib-svr4.c (struct svr4_info): Add initializers and
4043         destructor.
4044         <probes_table>: Now an htab_up.
4045         (solib_svr4_pspace_data): Change type.
4046         (free_probes_table): Simplify.
4047         (~svr4_info): Rename from svr4_pspace_data_cleanup.
4048         (get_svr4_info, probes_table_htab_remove_objfile_probes)
4049         (probes_table_remove_objfile_probes, register_solib_event_probe)
4050         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
4051         (_initialize_svr4_solib): Update.
4052
4053 2019-05-08  Tom Tromey  <tom@tromey.com>
4054
4055         * remote.c (remote_pspace_data): Change type.
4056         (remote_pspace_data_cleanup): Remove.
4057         (get_remote_exec_file, set_pspace_remote_exec_file)
4058         (_initialize_remote): Update.
4059
4060 2019-05-08  Tom Tromey  <tom@tromey.com>
4061
4062         * breakpoint.c (breakpoint_objfile_key): Change type.
4063         (get_breakpoint_objfile_data): Update.
4064         (free_breakpoint_objfile_data): Remove.
4065         (_initialize_breakpoint): Update.
4066
4067 2019-05-08  Tom Tromey  <tom@tromey.com>
4068
4069         * linux-tdep.c (struct linux_info): Add initializers.
4070         (linux_inferior_data): Move.  Change type.
4071         (invalidate_linux_cache_inf): Update.
4072         (linux_inferior_data_cleanup): Remove.
4073         (get_linux_inferior_data, _initialize_linux_tdep): Update.
4074
4075 2019-05-08  Tom Tromey  <tom@tromey.com>
4076
4077         * auxv.c (auxv_inferior_data): Move.  Change type.
4078         (auxv_inferior_data_cleanup): Remove.
4079         (invalidate_auxv_cache_inf): Rewrite.
4080         (get_auxv_inferior_data, _initialize_auxv): Update.
4081
4082 2019-05-08  Tom Tromey  <tom@tromey.com>
4083
4084         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4085         (symfile_debug_objfile_data_key): Change type.
4086         (symfile_debug_installed, debug_qf_has_symbols)
4087         (debug_qf_find_last_source_symtab)
4088         (debug_qf_forget_cached_source_info)
4089         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4090         (debug_qf_print_stats, debug_qf_dump)
4091         (debug_qf_expand_symtabs_for_function)
4092         (debug_qf_expand_all_symtabs)
4093         (debug_qf_expand_symtabs_with_fullname)
4094         (debug_qf_map_matching_symbols)
4095         (debug_qf_expand_symtabs_matching)
4096         (debug_qf_find_pc_sect_compunit_symtab)
4097         (debug_qf_map_symbol_filenames)
4098         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4099         (debug_sym_new_init, debug_sym_init, debug_sym_read)
4100         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4101         (debug_sym_read_linetable, debug_sym_relocate): Update.
4102         (symfile_debug_free_objfile): Remove.
4103         (install_symfile_debug_logging, _initialize_symfile_debug):
4104         Update.
4105
4106 2019-05-08  Tom Tromey  <tom@tromey.com>
4107
4108         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4109         allocate_on_obstack.
4110         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4111         (get_dwarf2_per_objfile): Update.
4112         (set_dwarf2_per_objfile): Remove.
4113         (dwarf2_has_info, dwarf2_get_section_info): Update.
4114         (dwarf2_free_objfile): Remove.
4115         (_initialize_dwarf2_read): Update.
4116
4117 2019-05-08  Tom Tromey  <tom@tromey.com>
4118
4119         * auto-load.c (struct auto_load_pspace_info): Add destructor and
4120         initializers.
4121         <unsupported_script_warning_printed,
4122         script_not_found_warning_printed>: Now bool.
4123         (auto_load_pspace_data): Change type.
4124         (~auto_load_pspace_info): Rename from
4125         auto_load_pspace_data_cleanup.
4126         (get_auto_load_pspace_data, init_loaded_scripts_info)
4127         (clear_section_scripts, maybe_print_unsupported_script_warning)
4128         (maybe_print_script_not_found_warning, _initialize_auto_load):
4129         Update.
4130
4131 2019-05-08  Tom Tromey  <tom@tromey.com>
4132
4133         * objfiles.c (objfile_pspace_info): Add destructor and
4134         initializers.
4135         (objfiles_pspace_data): Change type.
4136         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4137         (get_objfile_pspace_data): Update.
4138         (objfiles_bfd_data): Change type.
4139         (get_objfile_bfd_data): Update.
4140         (objfile_bfd_data_free, _initialize_objfiles): Remove.
4141
4142 2019-05-08  Tom Tromey  <tom@tromey.com>
4143
4144         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4145         Change type.
4146         (get_catch_syscall_inferior_data): Update.
4147         (catch_syscall_inferior_data_cleanup): Remove.
4148         (_initialize_break_catch_syscall): Update.
4149
4150 2019-05-08  Tom Tromey  <tom@tromey.com>
4151
4152         * inflow.c (struct terminal_info): Add destructor and
4153         initializers.
4154         (inflow_inferior_data): Change type.
4155         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4156         (get_inflow_inferior_data, inflow_inferior_exit)
4157         (swap_terminal_info, _initialize_inflow): Update.
4158
4159 2019-05-08  Tom Tromey  <tom@tromey.com>
4160
4161         * target-dcache.c (target_dcache_cleanup): Remove.
4162         (target_dcache_aspace_key): Change type.
4163         (target_dcache_init_p, target_dcache_invalidate)
4164         (target_dcache_get, target_dcache_get_or_init)
4165         (_initialize_target_dcache): Update.
4166         * dcache.h (struct dcache_deleter): New.
4167
4168 2019-05-08  Tom Tromey  <tom@tromey.com>
4169
4170         * symtab.c (struct symbol_cache): Add destructor and
4171         initializers.
4172         (symbol_cache_key): Move.  Change type.
4173         (make_symbol_cache, free_symbol_cache): Remove.
4174         (get_symbol_cache): Update.
4175         (symbol_cache_cleanup): Remove.
4176         (ALL_PSPACES, symbol_cache_flush)
4177         (maintenance_print_symbol_cache)
4178         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4179         Update.
4180
4181 2019-05-08  Tom Tromey  <tom@tromey.com>
4182
4183         * symtab.c (struct main_info): Add destructor and initializers.
4184         (main_progspace_key): Move.  Change type.
4185         (get_main_info): Update.
4186         (main_info_cleanup): Remove.
4187         (_initialize_symtab): Update.
4188
4189 2019-05-08  Tom Tromey  <tom@tromey.com>
4190
4191         * registry.h (DECLARE_REGISTRY): Define the _key class.
4192
4193 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4194
4195         * NEWS: Merge two 'New commands' sections.
4196
4197 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4198
4199         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4200         parameter and use Ada language definition instead.
4201         (ada_val_print_ptr): Remove unused language parameter.
4202         (ada_val_print_num): Remove language parameter and use Ada language
4203         definition instead.
4204         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4205         parameter.
4206         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4207         parameter and use Ada language definition instead.
4208         (ada_val_print_1): Update all ada_val_print_xxx calls.
4209         Remove language parameter.
4210         (ada_val_print): Update ada_val_print_1 call.
4211
4212 2019-05-08  Tom Tromey  <tromey@adacore.com>
4213
4214         * remote.c (remote_hw_watchpoint_limit)
4215         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4216         Now static.
4217
4218 2019-05-08  Tom Tromey  <tromey@adacore.com>
4219
4220         * maint.c (_initialize_maint_cmds): Move initialization code to
4221         remote.c.
4222         (watchdog, show_watchdog): Move to remote.c.
4223         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4224         "watchdog" static.
4225         (_initialize_remote): Move initialization code from maint.c.
4226         * defs.h (watchdog): Don't declare.
4227
4228 2019-05-08  Tom Tromey  <tromey@adacore.com>
4229
4230         * tui/tui-interp.c: Include main.h.
4231         * interps.c: Include main.h.
4232         * main.h (interpreter_p): Declare.
4233         * defs.h (interpreter_p): Don't declare.
4234
4235 2019-05-08  Tom Tromey  <tromey@adacore.com>
4236
4237         * dwarf2loc.c: Include dwarf2read.h.
4238         * defs.h (read_unsigned_leb128): Don't declare.
4239         * dwarf2read.h (read_unsigned_leb128): Declare.
4240
4241 2019-05-08  Tom Tromey  <tromey@adacore.com>
4242
4243         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4244         method.
4245
4246 2019-05-08  Tom Tromey  <tromey@adacore.com>
4247
4248         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4249         when no wrap column is set.
4250
4251 2019-05-08  Tom Tromey  <tromey@adacore.com>
4252
4253         * c-lang.c (c_get_string): Handle non-C-style arrays.
4254
4255 2019-05-08  Tom Tromey  <tromey@adacore.com>
4256
4257         * typeprint.c (print_offset_data::update): Print the bit offset,
4258         not the number of bits remaining.
4259
4260 2019-05-08  Tom Tromey  <tromey@adacore.com>
4261
4262         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4263         padding at end of comment.
4264
4265 2019-05-08  Tom Tromey  <tromey@adacore.com>
4266
4267         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4268         Compare main types.
4269
4270 2019-05-06  Tom Tromey  <tom@tromey.com>
4271
4272         * common/scoped_mmap.c: Include common-defs.h.
4273         * common/scoped_mmap.h: Don't include config.h.
4274
4275 2019-05-04  Tom Tromey  <tom@tromey.com>
4276
4277         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4278         (struct aarch64_call_info): Add initializers.
4279         <si>: Now a std::vector.
4280         (pass_on_stack, aarch64_push_dummy_call): Update.
4281
4282 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4283             Tom Tromey  <tom@tromey.com>
4284
4285         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4286         (ppc_threads): Now a std::vector.  Now static.
4287         (hwdebug_find_thread_points_by_tid)
4288         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4289         Update.
4290
4291 2019-05-04  Tom Tromey  <tom@tromey.com>
4292
4293         * arc-tdep.c (arc_tdesc_init): Return bool.
4294
4295 2019-05-04  Tom Tromey  <tom@tromey.com>
4296
4297         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4298         Use gdb_assert_not_reached.
4299
4300 2019-05-04  Tom Tromey  <tom@tromey.com>
4301
4302         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4303         "false".
4304
4305 2019-05-04  Tom Tromey  <tom@tromey.com>
4306
4307         * arc-tdep.c (arc_tdesc_init): Use bool.
4308
4309 2019-05-04  Tom Tromey  <tom@tromey.com>
4310
4311         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4312
4313 2019-05-04  Tom Tromey  <tom@tromey.com>
4314
4315         * cli/cli-cmds.c (valid_command_p): Return bool.
4316
4317 2019-05-04  Tom Tromey  <tom@tromey.com>
4318
4319         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4320         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4321
4322 2019-05-04  Raul Tambre  <raul@tambre.ee>
4323
4324         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4325         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4326         operator for comparison.
4327
4328 2019-05-04  Tom Tromey  <tom@tromey.com>
4329
4330         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4331         (lookup_partial_symbol, print_partial_symbols)
4332         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4333         (psymbol_compare): Update.
4334         (add_psymbol_to_bcache): Clear the entire psymbol.
4335         (maintenance_check_psymtabs): Update.
4336         * psympriv.h (struct partial_symbol): Don't derive from
4337         general_symbol_info.
4338         <obj_section, unrelocated_address, address,
4339         set_unrelocated_address>: Update.
4340         <ginfo>: New member.
4341         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4342         (debug_names::write_psymbols): Update.
4343
4344 2019-05-04  Tom de Vries  <tdevries@suse.de>
4345
4346         * contrib/cc-with-tweaks.sh: Support -n arg.
4347
4348 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4349
4350         * corelow.c (core_target::detach): Ensure frame cache and
4351         register caches are cleared.
4352         inferior.c (exit_inferior_1): Likewise.
4353
4354 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4355             Tom Tromey  <tom@tromey.com>
4356
4357         * dictionary.c (collate_pending_symbols_by_language): Remove
4358         "struct" from foreach.
4359         * symtab.c (lookup_global_symbol_from_objfile)
4360         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4361         foreach.
4362         * ser-tcp.c (net_open): Remove "struct" from foreach.
4363         * objfiles.c (objfile_relocate, objfile_rebase)
4364         (objfile_has_symbols): Remove "struct" from foreach.
4365         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4366         from foreach.
4367         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4368         foreach.
4369         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4370         "struct" from foreach.
4371         * ada-lang.c (create_excep_cond_exprs)
4372         (ada_exception_catchpoint_cond_string): Remove "struct" from
4373         foreach.
4374
4375 2019-05-03  Tom Tromey  <tromey@adacore.com>
4376
4377         * ada-exp.y (convert_char_literal): Check suffix of each
4378         enumerator.
4379
4380 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4381
4382         PR ada/21406:
4383         * ada-exp.y (yywrap): Don't define.
4384         * ada-lex.l (%option): Add noyywrap
4385         (yywrap): Remove.
4386
4387 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4388
4389         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4390         _WIN32_WINNT to the XP level, unless already defined to a higher
4391         level.
4392
4393         * unittests/parse-connection-spec-selftests.c:
4394         * ser-tcp.c:
4395         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4396         override.
4397
4398         * symfile.c (find_separate_debug_file): Remove colon from the
4399         drive spec of DOS/Windows file names of the target, so that the
4400         file name produced from DEBUGDIR and the target's directory will
4401         be valid on DOS/Windows systems.
4402
4403 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4404
4405         * rust-lang.c (val_print_struct): Handle printing structures
4406         containing strings.
4407
4408 2019-05-02  Tom Tromey  <tromey@adacore.com>
4409
4410         * valarith.c (_initialize_valarith): Remove.
4411
4412 2019-05-01  Tom Tromey  <tromey@adacore.com>
4413
4414         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4415         bitfields.
4416
4417 2019-05-01  Tom Tromey  <tromey@adacore.com>
4418
4419         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4420         for big-endian copies.
4421
4422 2019-04-30  Ali Tamur  <tamur@google.com>
4423         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4424         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4425         (read_3_bytes): New function.
4426
4427 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4428
4429         * windows-nat.c (main_thread_id): Delete.
4430         (handle_output_debug_string): Replace main_thread_id by
4431         current_event.dwThreadId.
4432         (fake_create_process): Likewise.
4433         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4434         Do not set main_thread_id.
4435         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4436         current_event.dwThreadId.
4437         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4438
4439 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4440
4441         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4442         Use current_event.dwThreadId instead of main_thread_id.
4443
4444 2019-04-30  Tom Tromey  <tromey@adacore.com>
4445
4446         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4447         (create_excep_cond_exprs): Iterate over program spaces.
4448         (ada_exception_catchpoint_cond_string): Examine all minimal
4449         symbols for exception types.
4450
4451 2019-04-30  Tom Tromey  <tromey@adacore.com>
4452
4453         PR c++/24470:
4454         * dwarf2read.c (process_structure_scope): Handle case where type
4455         has template parameters but no symbol was created.
4456
4457 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4458             Chris January  <chris.january@arm.com>
4459
4460         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4461         qualifier.
4462         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4463
4464 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4465
4466         * f-typeprint.c (f_print_type): Update rules for printing
4467         whitespace.
4468         (f_type_print_varspec_suffix): Likewise.
4469
4470 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4471             Chris January  <chris.january@arm.com>
4472
4473         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4474         function arguments.
4475
4476 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4477
4478         * f-lang.c (build_fortran_types): Change name of void type to
4479         lower case.
4480         * f-typeprint.c (f_type_print_base): Print the name of the void
4481         type, rather than a fixed string.
4482         * f-valprint.c (f_decorations): Use lower case void string.
4483
4484 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4485             Chris January  <chris.january@arm.com>
4486
4487         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4488         types for Fortran.
4489
4490 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4491             Chris January  <chris.january@arm.com>
4492             David Lecomber  <david.lecomber@arm.com>
4493
4494         * f-exp.y (BINOP_INTRINSIC): New token.
4495         (exp): New parser rule handling BINOP_INTRINSIC.
4496         (f77_keywords): Add new builtin procedures.
4497         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4498         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4499         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4500         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4501         (print_unop_subexp_f): New function.
4502         (print_binop_subexp_f): New function.
4503         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4504         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4505         (dump_subexp_body_f): Likewise.
4506         (operator_check_f): Likewise.
4507         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4508         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4509
4510 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4511
4512         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4513         UNOP_KIND.
4514         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4515         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4516         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4517         (operator_length_f): New fuction.
4518         (print_subexp_f): New function.
4519         (op_name_f): New function.
4520         (dump_subexp_body_f): New function.
4521         (operator_check_f): New function.
4522         (exp_descriptor_f): Replace standard expression handling functions
4523         with new functions.
4524         * gdb/fortran-operator.def: New file.
4525         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4526         * gdb/std-operator.def: Remove UNOP_KIND.
4527
4528 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4529
4530         * std-operator.def: Remove unbalanced, stray double quote
4531         character.
4532
4533 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4534             Chris January  <chris.january@arm.com>
4535             Daniel Everett  <daniel.everett@arm.com>
4536             Nick Forrington  <nick.forrington@arm.com>
4537             Richard Bunt  <richard.bunt@arm.com>
4538
4539         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4540         of depth when printing anonymous structs or unions.
4541         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4542         Don't print either the top-level value, or the children if the
4543         max-depth is exceeded.
4544         (ppscm_print_children): When printing the key of a map, allow one
4545         extra level of depth.
4546         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4547         print either the top-level value, or the children if the max-depth
4548         is exceeded.
4549         (print_children): When printing the key of a map, allow one extra
4550         level of depth.
4551         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4552         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4553         (user_print_options): Initialise max_depth field.
4554         (val_print_scalar_or_string_type_p): New function.
4555         (val_print): Check to see if the max depth has been reached.
4556         (val_print_check_max_depth): Define new function.
4557         (show_print_max_depth): New function.
4558         (_initialize_valprint): Add 'print max-depth' option.
4559         * valprint.h (struct value_print_options) <max_depth>: New field.
4560         (val_print_check_max_depth): Declare new function.
4561         * NEWS: Document new feature.
4562
4563 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4564
4565         * ada-lang.c (ada_language_defn): Initialise new field.
4566         * c-lang.c (c_is_string_type_p): New function.
4567         (c_language_defn): Initialise new field.
4568         (cplus_language_defn): Initialise new field.
4569         (asm_language_defn): Initialise new field.
4570         (minimal_language_defn): Initialise new field.
4571         * c-lang.h (c_is_string_type_p): Declare new function.
4572         * d-lang.c (d_language_defn): Initialise new field.
4573         * f-lang.c (f_is_string_type_p): New function.
4574         (f_language_defn): Initialise new field.
4575         * go-lang.c (go_is_string_type_p): New function.
4576         (go_language_defn): Initialise new field.
4577         * language.c (default_is_string_type_p): New function.
4578         (unknown_language_defn): Initialise new field.
4579         (auto_language_defn): Initialise new field.
4580         * language.h (struct language_defn) <la_is_string_type_p>: New
4581         member variable.
4582         (default_is_string_type_p): Declare new function.
4583         * m2-lang.c (m2_language_defn): Initialise new field.
4584         * objc-lang.c (objc_language_defn): Initialise new field.
4585         * opencl-lang.c (opencl_language_defn): Initialise new field.
4586         * p-lang.c (pascal_is_string_type_p): New function.
4587         (pascal_language_defn): Initialise new field.
4588         * rust-lang.c (rust_is_string_type_p): New function.
4589         (rust_language_defn): Initialise new field.
4590
4591 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4592
4593         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4594         New field.
4595         * ada-lang.c (ada_language_defn): Initialise new field.
4596         * c-lang.c (c_language_defn): Likewise.
4597         (cplus_language_defn): Likewise.
4598         (asm_language_defn): Likewise.
4599         (minimal_language_defn): Likewise.
4600         * d-lang.c (d_language_defn): Likewise.
4601         * f-lang.c (f_language_defn): Likewise.
4602         * go-lang.c (go_language_defn): Likewise.
4603         * language.c (unknown_language_defn): Likewise.
4604         (auto_language_defn): Likewise.
4605         * m2-lang.c (m2_language_defn): Likewise.
4606         * objc-lang.c (objc_language_defn): Likewise.
4607         * opencl-lang.c (opencl_language_defn): Likewise.
4608         * p-lang.c (pascal_language_defn): Likewise.
4609         * rust-lang.c (rust_language_defn): Likewise.
4610
4611 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4612
4613         * ada-lang.c (ada_is_character_type): Change return type to bool.
4614         (ada_is_string_type): Likewise.
4615         * ada-lang.h (ada_is_character_type): Update declaration
4616         (ada_is_string_type): Likewise.
4617
4618 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4619
4620         Support style in 'frame|thread apply'
4621
4622         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4623         * record.c (record_start, record_stop): Update callers of
4624         execute_command_to_string with false.
4625         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4626         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4627         methods.
4628         (class string_file): New constructor with term_out parameter.
4629         Override methods term_out and can_emit_style_escape.  New member
4630         term_out.
4631         (class stdio_file): Override can_emit_style_escape.
4632         (class tee_file): Override term_out and can_emit_style_escape.
4633         * utils.h (can_emit_style_escape): Remove.
4634         * utils.c (can_emit_style_escape): Likewise.
4635         Update all callers of can_emit_style_escape (SOMESTREAM) to
4636         SOMESTREAM->can_emit_style_escape.
4637         * source-cache.c (source_cache::get_source_lines): Likewise.
4638         * stack.c (frame_apply_command_count): Call execute_command_to_string
4639         passing the term_out characteristic of the current gdb_stdout.
4640         * thread.c (thr_try_catch_cmd): Likewise.
4641         * top.c (execute_command_to_string): pass term_out parameter
4642         to construct the string_file for the command output.
4643         * ui-file.c (term_cli_styling): New function (most code moved
4644         from utils.c can_emit_style_escape).
4645         (string_file::string_file, string_file::can_emit_style_escape,
4646         stdio_file::can_emit_style_escape, tee_file::term_out,
4647         tee_file::can_emit_style_escape): New functions.
4648
4649 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4650
4651         * NEWS: Mention the new set|show may-call-functions.
4652         * infcall.c (may_call_functions_p): New variable.
4653         (show_may_call_functions_p): New function.
4654         (call_function_by_hand_dummy): Throws an error if not
4655         may-call-functions.
4656         (_initialize_infcall): Call add_setshow_boolean_cmd for
4657         may-call-functions.
4658
4659 2019-04-25  Keith Seitz  <keiths@redhat.com>
4660
4661         PR c++/24367
4662         * cp-support.c (inspect_type): Don't attempt substitutions
4663         of symbol with the same name.
4664
4665 2019-04-25  Tom Tromey  <tromey@adacore.com>
4666
4667         PR gdb/24475:
4668         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4669         static.
4670
4671 2019-04-25  Tom Tromey  <tromey@adacore.com>
4672
4673         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4674         rvalue reference.
4675         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4676         (gdb_xml_parser::parse): Use std::move.
4677         * python/python-internal.h (gdbpy_convert_exception): Take a const
4678         reference.
4679         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4680         std::move.
4681         * python/py-utils.c (gdbpy_convert_exception): Take a const
4682         reference.
4683         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4684         Use std::move.
4685         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4686         Use std::move.
4687         * mi/mi-main.c (mi_print_exception): Take a const reference.
4688         * main.c (handle_command_errors): Take a const reference.
4689         * linespec.c (parse_linespec): Use std::move.
4690         * infcall.c (run_inferior_call): Use std::move.
4691         (call_function_by_hand_dummy): Use std::move.
4692         * exec.c (try_open_exec_file): Use std::move.
4693         * exceptions.h (exception_print, exception_fprintf)
4694         (exception_print_same): Update.
4695         * exceptions.c (print_exception, exception_print)
4696         (exception_fprintf, exception_print_same): Change parameters to
4697         const reference.
4698         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4699         * common/new-op.c: Use std::move.
4700         * common/common-exceptions.h (struct gdb_exception): Add move
4701         constructor.
4702         (struct gdb_exception_error, struct gdb_exception_quit, struct
4703         gdb_quit_bad_alloc): Change constructor to move constructor.
4704         (throw_exception): Change parameter to rvalue reference.
4705         * common/common-exceptions.c (throw_exception): Take rvalue
4706         reference.
4707         * cli/cli-interp.c (safe_execute_command): Use std::move.
4708         * breakpoint.c (insert_bp_location, location_to_sals): Use
4709         std::move.
4710
4711 2019-04-25  Tom Tromey  <tromey@adacore.com>
4712
4713         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4714         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4715         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4716         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4717         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4718         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4719         guile/scm-value.c: Use unpack.
4720         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4721         gdbscm_gdb_exception.
4722         (gdbscm_throw_gdb_exception): Likewise.
4723         (struct gdbscm_gdb_exception): New.
4724         (unpack): New function.
4725         (gdbscm_wrap): Use unpack.
4726
4727 2019-04-25  Tom Tromey  <tromey@adacore.com>
4728
4729         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4730         (gdb_rl_callback_handler): Use std::move.
4731         * common/common-exceptions.h (struct gdb_exception): Add move
4732         assignment operator.
4733         (throw_exception_sjlj): Change "exception" to const reference.
4734         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4735         (throw_exception_sjlj): Change "exception" to const reference.
4736
4737 2019-04-25  Tom Tromey  <tromey@adacore.com>
4738
4739         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4740         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4741         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4742         Update.
4743         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4744         Update.
4745         * mi/mi-interp.c (mi_interp::exec): Update.
4746         * linespec.c (parse_linespec): Update.
4747         * infcall.c (run_inferior_call): Update.
4748         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4749         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4750         (gdbscm_lookup_global_symbol): Update.
4751         * guile/scm-param.c (gdbscm_parameter_value): Update.
4752         * guile/scm-frame.c (gdbscm_frame_read_register)
4753         (gdbscm_frame_read_var): Update.
4754         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4755         * exec.c (try_open_exec_file): Update.
4756         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4757         (gdb_rl_callback_handler): Update.
4758         * common/common-exceptions.h (exception_none): Don't declare.
4759         * common/common-exceptions.c (exception_none): Don't define.
4760         (struct catcher) <exception>: Update.
4761         * cli/cli-interp.c (safe_execute_command): Update.
4762         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4763
4764 2019-04-25  Ali Tamur  <tamur@google.com>
4765
4766         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4767         (read_attribute_value): Likewise.
4768         (dwarf2_read_addr_index): Update comment.
4769         (read_str_index): Add DW_FORM_strx.
4770         (dwarf2_string_attr): Likewise.
4771         (dwarf2_const_value_attr): Likewise.
4772         (dump_die_shallow): Likewise.
4773         (dwarf2_fetch_constant_bytes): Likewise.
4774         (skip_form_bytes): Likewise.
4775         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4776
4777 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4778
4779         PR corefiles/11608
4780         PR corefiles/18187
4781         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4782         OFFSET.  Verify if current mapping contains an ELF header.
4783         (linux_find_memory_regions_full): Adjust call to
4784         dump_mapping_p.
4785
4786 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4787             Kang Li <kanglictf@gmail.com>
4788
4789         PR gdb/21600
4790
4791         * dwarf2-frame.c (read_initial_length): Be consistent about using
4792         unsigned representation of length.
4793         (decode_frame_entry_1): Likewise.  Check for wraparound of
4794         end pointer as well as buffer overflow.
4795
4796 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4797
4798         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4799         "vq".
4800
4801 2019-04-24  Tom Tromey  <tromey@adacore.com>
4802
4803         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4804
4805 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4806
4807         * s12z-tdep.c (s12z_unwind_pc): Delete.
4808         (s12z_unwind_sp): Delete.
4809         (s12z_gdbarch_init): Don't register deleted functions with
4810         gdbarch.
4811
4812 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4813
4814         * rl78-tdep.c (rl78_unwind_sp): Delete.
4815         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4816
4817 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4818
4819         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4820         (xstormy16_unwind_pc): Delete.
4821         (xstormy16_dummy_id): Delete.
4822         (xstormy16_gdbarch_init): Don't register deleted functions with
4823         gdbarch.
4824
4825 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4826
4827         * vax-tdep.c (vax_unwind_pc): Delete.
4828         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4829
4830 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4831
4832         * v850-tdep.c (v850_unwind_sp): Delete.
4833         (v850_unwind_pc): Delete.
4834         (v850_dummy_id): Delete.
4835         (v850_gdbarch_init): Don't register deleted functions with
4836         gdbarch.
4837
4838 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4839
4840         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4841         (tilegx_unwind_pc): Delete.
4842         (tilegx_unwind_dummy_id): Delete.
4843         (tilegx_gdbarch_init): Don't register deleted functions with
4844         gdbarch.
4845
4846 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4847
4848         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4849         (tic6x_dummy_id): Delete.
4850         (tic6x_gdbarch_init): Don't register deleted functions with
4851         gdbarch.
4852
4853 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4854
4855         * sparc-tdep.c (sparc_unwind_pc): Delete.
4856         (sparc32_gdbarch_init): Don't register deleted function with
4857         gdbarch.
4858
4859 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4860
4861         * sh-tdep.c (sh_unwind_sp): Delete.
4862         (sh_unwind_pc): Delete.
4863         (sh_dummy_id): Delete.
4864         (sh_gdbarch_init): Don't register deleted functions with
4865         gdbarch.
4866
4867 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4868
4869         * score-tdep.c (score_unwind_sp): Delete.
4870         (score_unwind_pc): Delete.
4871         (score_dummy_id): Delete.
4872         (score_gdbarch_init): Don't register deleted functions with
4873         gdbarch.
4874
4875 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4876
4877         * rx-tdep.c (rx_unwind_pc): Delete.
4878         (rx_unwind_sp): Delete.
4879         (rx_dummy_id): Delete.
4880         (rx_gdbarch_init): Don't register deleted functions with
4881         gdbarch.  Update comment.
4882
4883 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4884
4885         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4886         (rs6000_dummy_id): Delete.
4887         (rs6000_gdbarch_init): Don't register deleted functions with
4888         gdbarch.
4889
4890 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4891
4892         * or1k-tdep.c (or1k_dummy_id): Delete.
4893         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4894
4895 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4896
4897         * nios2-tdep.c (nios2_dummy_id): Delete.
4898         (nios2_unwind_sp): Delete.
4899         (nios2_gdbarch_init): Don't register deleted functions with
4900         gdbarch.
4901
4902 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4903
4904         * nds32-tdep.c (nds32_dummy_id): Delete.
4905         (nds32_unwind_pc): Delete.
4906         (nds32_unwind_sp): Delete.
4907         (nds32_gdbarch_init): Don't register deleted functions with
4908         gdbarch.
4909
4910 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4911
4912         * msp430-tdep.c (msp430_unwind_pc): Delete.
4913         (msp430_unwind_sp): Delete.
4914         (msp430_dummy_id): Delete.
4915         (msp430_gdbarch_init): Don't register deleted functions with
4916         gdbarch.
4917
4918 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4919
4920         * moxie-tdep.c (moxie_unwind_sp): Delete.
4921         (moxie_unwind_pc): Delete.
4922         (moxie_dummy_id): Delete.
4923         (moxie_gdbarch_init): Don't register deleted functions with
4924         gdbarch.
4925
4926 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4927
4928         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4929         (mn10300_unwind_pc): Delete.
4930         (mn10300_unwind_sp): Delete.
4931         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4932         mn10300_unwind_sp.
4933         (mn10300_frame_unwind_init): Don't register deleted functions with
4934         gdbarch.
4935
4936 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4937
4938         * mep-tdep.c (mep_unwind_pc): Delete.
4939         (mep_unwind_sp): Delete.
4940         (mep_dummy_id): Delete.
4941         (mep_gdbarch_init): Don't register deleted functions with
4942         gdbarch.
4943
4944 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4945
4946         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4947         (m68hc11_unwind_sp): Delete.
4948         (m68hc11_gdbarch_init): Don't register deleted functions with
4949         gdbarch.
4950
4951 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4952
4953         * m32r-tdep.c (m32r_unwind_sp): Delete.
4954         (m32r_unwind_pc): Delete.
4955         (m32r_dummy_id): Delete.
4956         (m32r_gdbarch_init): Don't register deleted functions with
4957         gdbarch.
4958
4959 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4960
4961         * m32c-tdep.c (m32c_unwind_pc): Delete.
4962         (m32c_unwind_sp): Delete.
4963         (m32c_dummy_id): Delete.
4964         (m32c_gdbarch_init): Don't register deleted functions with
4965         gdbarch.
4966
4967 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4968
4969         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4970         (lm32_unwind_pc): Delete.
4971         (lm32_dummy_id): Delete.
4972         (lm32_gdbarch_init): Don't register deleted functions with
4973         gdbarch.
4974
4975 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4976
4977         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4978         (iq2000_unwind_pc): Delete.
4979         (iq2000_dummy_id): Delete.
4980         (iq2000_gdbarch_init): Don't register deleted functions with
4981         gdbarch.
4982
4983 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4984
4985         * nds32-tdep.c (nds32_type_align): Delete.
4986         (nds32_push_dummy_call): Use type_align instead.
4987
4988 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4989
4990         * arm-tdep.c (arm_type_align): Only handle vector override case.
4991         (arm_push_dummy_call): Use type_align.
4992         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4993
4994 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4995
4996         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4997         case.
4998         (pass_on_stack): Use type_align.
4999         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
5000         function.
5001
5002 2019-04-23  Tom Tromey  <tromey@adacore.com>
5003
5004         * dwarf2read.c (line_header::file_name_at): Remove unused
5005         overload.
5006
5007 2019-04-23  Tom de Vries  <tdevries@suse.de>
5008
5009         PR gdb/24438
5010         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
5011         invocation.
5012
5013
5014 2019-03-27  Ali Tamur  <tamur@google.com>
5015
5016         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
5017         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
5018         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
5019         (dwarf_expr_context::get_addr_index): Likewise
5020         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
5021         (symbol_needs_eval_context::get_addr_index): Likewise
5022         (disassemble_dwarf_expression): Add DW_OP_addrx
5023         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
5024         (read_cutu_die_from_dwo): Update comment
5025         (skip_one_die): Add DW_FORM_addrx
5026         (read_attribute_value): Likewise
5027         (var_decode_location): Add DW_OP_addrx
5028         (dwarf2_const_value_attr): Add DW_FORM_addrx
5029         (dump_die_shallow): Likewise
5030         (dwarf2_fetch_constant_bytes): Likewise
5031         (decode_locdesc): Add DW_OP_addrx
5032         (skip_form_bytes): Add DW_FORM_addrx
5033
5034 2019-04-22  Ali Tamur  <tamur@google.com>
5035
5036         * MAINTAINERS (Write After Approval): Add self.
5037
5038 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
5039
5040         * solib-svr4.c (get_svr4_info): Add pspace parameter.
5041         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
5042         (open_symbol_file_object): Likewise.
5043         (svr4_default_sos): Add info parameter.
5044         (svr4_read_so_list): Likewise.
5045         (svr4_current_sos_direct): Adjust functions calls to pass down
5046         info.
5047         (svr4_current_sos_1): Add info parameter.
5048         (svr4_current_sos): Call get_svr4_info, pass info down to
5049         svr4_current_sos_1.
5050         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
5051         get_svr4_info.
5052         (svr4_in_dynsym_resolve_code): Pass current_program_space to
5053         get_svr4_info.
5054         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
5055         to get_svr4_info.
5056         (probes_table_remove_objfile_probes): Likewise.
5057         (register_solib_event_probe): Add info parameter.
5058         (solist_update_incremental): Pass info parameter down to
5059         svr4_read_so_list.
5060         (disable_probes_interface): Add info parameter.
5061         (svr4_handle_solib_event): Pass current_program_space to
5062         get_svr4_info.  Adjust disable_probes_interface cleanup.
5063         (svr4_create_probe_breakpoints): Add info parameter, pass it
5064         down to register_solib_event_probe.
5065         (svr4_create_solib_event_breakpoints): Add info parameter,
5066         pass it down to svr4_create_probe_breakpoints.
5067         (enable_break): Pass info down to
5068         svr4_create_solib_event_breakpoints.
5069         (svr4_solib_create_inferior_hook): Pass current_program_space to
5070         get_svr4_info.
5071         (svr4_clear_solib): Likewise.
5072
5073 2019-04-22  Pedro Alves  <palves@redhat.com>
5074
5075         * solib-svr4.c (svr4_free_objfile_observer): New.
5076         (probe_and_action::objfile): New field.
5077         (probes_table_htab_remove_objfile_probes)
5078         (probes_table_remove_objfile_probes): New functions.
5079         (register_solib_event_probe): Add 'objfile' parameter.  Store it
5080         in the new probe_and_action.  Don't store the probe in 'lookup'.
5081         (svr4_create_probe_breakpoints): Pass objfile to
5082         register_solib_event_probe.
5083         (_initialize_svr4_solib): Register a free_objfile observer.
5084
5085 2019-04-19  Tom Tromey  <tom@tromey.com>
5086
5087         * common/queue.h: Remove.
5088
5089 2019-04-19  Tom Tromey  <tom@tromey.com>
5090
5091         * event-loop.c: Don't include "common/queue.h".
5092
5093 2019-04-19  Tom Tromey  <tom@tromey.com>
5094
5095         * remote.c (remote_target): Use delete.
5096         * remote-notif.h: Include <list>, not "common/queue.h".
5097         (notif_client_p): Remove typedef.
5098         (remote_notif_state): Add constructor, destructor, initializer.
5099         <notif_queue>: Now a std::list.
5100         (remote_notif_state_xfree): Don't declare.
5101         * remote-notif.c (remote_notif_process, handle_notification)
5102         (remote_notif_state_allocate): Update.
5103         (~remote_notif_state): Rename from remote_notif_state_xfree.
5104
5105 2019-04-19  Tom Tromey  <tom@tromey.com>
5106
5107         * symfile.c (reread_symbols): Update.
5108         * objfiles.c (objfile_register_static_link)
5109         (objfile_lookup_static_link): Update
5110         (~objfile) Don't delete static_links.
5111         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5112
5113 2019-04-19  Tom Tromey  <tom@tromey.com>
5114
5115         * type-stack.h (struct type_stack) <insert>: Constify string.
5116         * type-stack.c (type_stack::insert): Constify string.
5117         * gdbtypes.h (lookup_template_type): Update.
5118         (address_space_name_to_int): Update.
5119         * gdbtypes.c (address_space_name_to_int): Make space_identifier
5120         const.
5121         (lookup_template_type): Make name const.
5122         * c-exp.y: Update rules.
5123         (lex_one_token, classify_name, classify_inner_name)
5124         (c_print_token): Update.
5125         * p-exp.y: Update rules.
5126         (yylex): Update.
5127         * f-exp.y: Update rules.
5128         (yylex): Update.
5129         * d-exp.y: Update rules.
5130         (lex_one_token, classify_name, classify_inner_name): Update.
5131         * parse.c (write_dollar_variable, copy_name): Return std::string.
5132         * parser-defs.h (copy_name): Change return type.
5133         * m2-exp.y: Update rules.
5134         (yylex): Update.
5135         * go-exp.y (lex_one_token): Update.
5136         Update rules.
5137         (classify_unsafe_function, classify_packaged_name)
5138         (classify_name, yylex): Update.
5139
5140 2019-04-19  Sergei Trofimovich <siarheit@google.com>
5141
5142         * configure.ac: add --enable-source-highlight switch.
5143         * configure: Regenerate.
5144         * top.c (print_gdb_version): plumb --enable-source-highlight
5145         status to "show configuration".
5146
5147 2019-04-19  Tom Tromey  <tromey@adacore.com>
5148
5149         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5150         Check ADA_TYPE_P.
5151         (empty_record, ada_template_to_fixed_record_type_1)
5152         (template_to_static_fixed_type)
5153         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5154         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5155         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5156         macros.
5157
5158 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5159
5160         PR symtab/24423:
5161         * source.c (print_source_lines_base): Advance "iter" when a
5162         control character is seen.
5163
5164 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5165
5166         * inferior.h (struct infcall_suspend_state_deleter):
5167         Catch exception in destructor to avoid crash.
5168
5169 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5170
5171         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5172         close to the add_com "shell".
5173
5174 2019-04-18  Tom Tromey  <tromey@adacore.com>
5175
5176         * process-stratum-target.h (class process_stratum_target)
5177         <stratum>: Add "final".
5178
5179 2019-04-17  Tom Tromey  <tromey@adacore.com>
5180
5181         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5182         against nullptr before use.
5183
5184 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5185
5186         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5187
5188 2019-04-17  Jim Wilson  <jimw@sifive.com>
5189             Andrew Burgess  <andrew.burgess@embecosm.com>
5190
5191         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5192         code read might fail, assume 4-byte breakpoint in that case.
5193
5194 2019-04-15  Leszek Swirski  <leszeks@google.com>
5195
5196         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5197         rather than a hand-rolled POD check when checking for forced MEMORY
5198         classification.
5199
5200 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5201
5202         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5203         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5204         function.
5205         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5206         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5207         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5208         declaration.
5209
5210 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5211
5212         * aarch64-linux-nat.c
5213         (aarch64_linux_nat_target::thread_architecture): Add override.
5214         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5215         each VQ.
5216
5217 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5218
5219         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5220
5221 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5222
5223         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5224         target types of size 96-bits, add some additional comments, and
5225         check that the builtin type we found was the correct size.
5226
5227 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5228
5229         * utils.c (prompt_for_continue): Don't restore the styling at the
5230         end, as applied_style has the wrong value.  This fixes styling in
5231         long lists of file names that are interrupted by the "Continue?"
5232         prompt.
5233
5234 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5235
5236         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5237         * c-lang.c (c_language_defn): Likewise.
5238         (cplus_language_defn): Likewise.
5239         (asm_language_defn): Likewise.
5240         (minimal_language_defn): Likewise.
5241         * d-lang.c (d_language_defn): Likewise.
5242         * f-lang.c (f_language_defn): Likewise.
5243         * go-lang.c (go_language_defn): Likewise.
5244         * language.c (unknown_language_defn): Likewise.
5245         (auto_language_defn): Likewise.
5246         * language.h (struct language_defn): Remove la_magic field.
5247         (LANG_MAGIC): Delete.
5248         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5249         * objc-lang.c (objc_language_defn): Likewise.
5250         * opencl-lang.c (opencl_language_defn): Likewise.
5251         * p-lang.c (pascal_language_defn): Likewise.
5252         * rust-lang.c (rust_language_defn): Likewise.
5253
5254 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5255
5256         * riscv-tdep.c (riscv_type_align): New function.
5257         (riscv_type_alignment): Delete.
5258         (riscv_arg_location): Use 'type_align'.
5259         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5260
5261 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5262
5263         * gdbtypes.c (type_align): A struct with no non-static fields also
5264         has alignment of 1.
5265
5266 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5267
5268         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5269         component to 0.
5270         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5271         member.
5272         (riscv_struct_info::analyse): New implementation using new
5273         analyse_inner member function.
5274         (riscv_struct_info::field_offset): New member function.
5275         (riscv_struct_info::m_offsets): New member variable.
5276         (riscv_struct_info::analyse_inner): New private member function,
5277         takes the old implementation of riscv_struct_info::analyse but
5278         extended to track field offsets.
5279         (riscv_call_arg_struct): Update the struct folding special cases
5280         to handle cases where empty C++ structs, which are non-zero
5281         length, are found.
5282         (riscv_arg_location): Initialise the length of each location, a
5283         non-zero length now indicates the location is in use.
5284         (riscv_push_dummy_call): Allow for the first location having a
5285         non-zero offset when setting up arguments.
5286         (riscv_return_value): Likewise, but for return values.
5287
5288 2019-04-11  Tom Tromey  <tromey@adacore.com>
5289
5290         * utils.c (internal_vproblem): Make "msg" const.
5291
5292 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5293
5294         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5295         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5296         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5297         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5298
5299 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5300
5301         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5302         function.
5303         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5304         of amd64_collect_native_gregset.
5305         (amd64_linux_nat_target::store_registers): Likewise.
5306
5307 2019-04-10  Tom Tromey  <tom@tromey.com>
5308
5309         * symtab.c (lookup_global_symbol_from_objfile)
5310         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5311         * objfiles.h (class separate_debug_iterator): New.
5312         (class separate_debug_range): New.
5313         (struct objfile) <separate_debug_objfiles>: New method.
5314         (objfile_separate_debug_iterate): Don't declare.
5315         * objfiles.c (separate_debug_iterator::operator++): Rename from
5316         objfile_separate_debug_iterate.
5317         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5318         iterator.
5319         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5320         iterator.
5321
5322 2019-04-10  Tom Tromey  <tom@tromey.com>
5323
5324         * symfile.c (reread_symbols): Remove old comment.
5325         * objfiles.c (free_all_objfiles): Fix a typo.
5326
5327 2019-04-10  Tom Tromey  <tom@tromey.com>
5328
5329         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5330         * minsyms.c (lookup_minimal_symbol): Use foreach.
5331         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5332         (lookup_minimal_symbol_solib_trampoline): Likewise.
5333         * symfile.c (reread_symbols): Use foreach.
5334
5335 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5336             Tom Tromey  <tromey@adacore.com>
5337
5338         PR rust/24414:
5339         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5340         (rust_lex_int_test): Change "value" to be LONGEST.
5341         (rust_lex_tests): Add test for long integer literal.
5342
5343 2019-04-09  Tom Tromey  <tromey@adacore.com>
5344
5345         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5346         to bool.
5347         (extended_remote_target::attach): Update.
5348         (remote_target::remote_notice_new_inferior): Update.
5349         (remote_target::add_current_inferior_and_thread): Update.
5350         * inferior.c (exit_inferior_1): Use "false".
5351         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5352
5353 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5354
5355         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5356         the "start" command.
5357
5358 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5359
5360         * python/py-inferior.c (infpy_thread_from_thread_handle):
5361         Adjust comments to reflect renaming of thread_from_thread_handle
5362         to thread_from_handle.  Adjust keywords.  Fix type error message.
5363         (inferior_object_methods): Add thread_from_handle.  Retain
5364         thread_from_thread_handle, but mark it as deprecated.
5365
5366 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5367
5368         * gdbthread.h (find_thread_by_handle): Revise declaration.
5369         * thread.c (find_thread_by_handle): Likewise.  Adjust
5370         implementation too.
5371         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5372         support for buffer objects as handles.
5373
5374 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5375
5376         * python/py-infthread.c (thpy_thread_handle): New function.
5377         (thread_object_methods): Register thpy_thread_handle.
5378
5379 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5380
5381         * gdbthread.h (thread_to_thread_handle): Declare.
5382         * thread.c (gdbtypes.h): Include.
5383         (thread_to_thread_handle): New function.
5384
5385         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5386         (target_thread_info_to_thread_handle): Declare.
5387         * target.c (target_thread_info_to_thread_handle): New function.
5388         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5389         * target-delegates.c: Regenerate.
5390
5391         * linux-thread-db.c (class thread_db_target): Add method
5392         thread_info_to_thread_handle.
5393         (thread_db_target::thread_info_to_thread_handle): Define.
5394         * remote.c (class remote_target): Add new method
5395         thread_info_to_thread_handle.
5396         (remote_target::thread_info_to_thread_handle): Define.
5397
5398 2019-04-08  Pedro Alves  <palves@redhat.com>
5399
5400         * common/common-exceptions.c (throw_exception): Don't create
5401         named object to throw; throw directly.
5402         (throw_it): Likewise.  Don't initialize gdb_exception::message
5403         here, with new; pass FMT and AP to the ctor instead.
5404         * common/common-exceptions.h: Include <string>.
5405         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5406         const char *, va_list)): New ctor.  Use std::make_shared.
5407         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5408         errors)): Delete.
5409         (gdb_exception_error::gdb_exception_error(enum errors, const char
5410         *, va_list)): New.
5411         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5412         Add assertion.
5413         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5414         errors)): Delete.
5415         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5416         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5417         Add assertion.
5418
5419 2019-04-08  Tom Tromey  <tom@tromey.com>
5420
5421         * valops.c (value_rtti_indirect_type): Replace throw_exception
5422         with throw.
5423         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5424         with throw.
5425         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5426         throw.
5427         * target.c (target_translate_tls_address): Replace throw_exception
5428         with throw.
5429         * stack.c (frame_apply_command_count): Replace throw_exception
5430         with throw.
5431         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5432         throw.
5433         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5434         with throw.
5435         * rs6000-tdep.c (rs6000_frame_cache)
5436         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5437         * remote.c: Replace throw_exception with throw.
5438         * record-full.c (record_full_message, record_full_wait_1)
5439         (record_full_restore): Replace throw_exception with throw.
5440         * record-btrace.c:
5441         (get_thread_current_frame_id, record_btrace_start_replaying)
5442         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5443         (cmd_record_btrace_start): Replace throw_exception with throw.
5444         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5445         throw.
5446         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5447         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5448         * linespec.c:
5449         (find_linespec_symbols): Replace throw_exception with throw.
5450         * infrun.c (displaced_step_prepare, resume): Replace
5451         throw_exception with throw.
5452         * infcmd.c (post_create_inferior): Replace throw_exception with
5453         throw.
5454         * inf-loop.c (inferior_event_handler): Replace throw_exception
5455         with throw.
5456         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5457         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5458         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5459         (get_prev_frame_always, get_frame_pc_if_available)
5460         (get_frame_address_in_block_if_available, get_frame_language):
5461         Replace throw_exception with throw.
5462         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5463         throw_exception with throw.
5464         * eval.c (fetch_subexp_value, evaluate_var_value)
5465         (evaluate_funcall, evaluate_subexp_standard): Replace
5466         throw_exception with throw.
5467         * dwarf2loc.c (call_site_find_chain)
5468         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5469         Replace throw_exception with throw.
5470         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5471         with throw.
5472         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5473         throw.
5474         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5475         * completer.c (complete_line_internal): Replace throw_exception
5476         with throw.
5477         * compile/compile-object-run.c (compile_object_run): Replace
5478         throw_exception with throw.
5479         * cli/cli-script.c (process_next_line): Replace throw_exception
5480         with throw.
5481         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5482         (btrace_enable, btrace_maint_update_pt_packets): Replace
5483         throw_exception with throw.
5484         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5485         throw_exception with throw.
5486         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5487         throw_exception with throw.
5488         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5489         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5490         * aarch64-tdep.c (aarch64_make_prologue_cache)
5491         (aarch64_make_stub_cache): Replace throw_exception with throw.
5492
5493 2019-04-08  Tom Tromey  <tom@tromey.com>
5494
5495         * common/common-exceptions.c (throw_exception): Rename from
5496         throw_exception_cxx.  Remove old copy.  Make argument const.
5497         (throw_it): Create and throw exception objects directly.
5498         * common/common-exceptions.h (throw_exception): Make argument
5499         const.
5500         (struct gdb_exception_error): Add constructor.
5501         (struct gdb_exception_quit): Add constructor.
5502
5503 2019-04-08  Tom Tromey  <tom@tromey.com>
5504
5505         * common/common-exceptions.h (exception_rethrow): Don't declare.
5506         (TRY_SJLJ): Update comment.
5507         (TRY, CATCH, END_CATCH): Remove.
5508         * common/common-exceptions.c (exception_rethrow): Remove.
5509
5510 2019-04-08  Tom Tromey  <tom@tromey.com>
5511
5512         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5513         Remove.
5514         (gdb_exception_error): Rename from
5515         gdb_exception_RETURN_MASK_ERROR.
5516         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5517         (gdb_quit_bad_alloc): Update.
5518         * aarch64-tdep.c: Update.
5519         * ada-lang.c: Update.
5520         * ada-typeprint.c: Update.
5521         * ada-valprint.c: Update.
5522         * amd64-tdep.c: Update.
5523         * arch-utils.c: Update.
5524         * break-catch-throw.c: Update.
5525         * breakpoint.c: Update.
5526         * btrace.c: Update.
5527         * c-varobj.c: Update.
5528         * cli/cli-cmds.c: Update.
5529         * cli/cli-interp.c: Update.
5530         * cli/cli-script.c: Update.
5531         * common/common-exceptions.c: Update.
5532         * common/new-op.c: Update.
5533         * common/selftest.c: Update.
5534         * compile/compile-c-symbols.c: Update.
5535         * compile/compile-cplus-symbols.c: Update.
5536         * compile/compile-object-load.c: Update.
5537         * compile/compile-object-run.c: Update.
5538         * completer.c: Update.
5539         * corelow.c: Update.
5540         * cp-abi.c: Update.
5541         * cp-support.c: Update.
5542         * cp-valprint.c: Update.
5543         * darwin-nat.c: Update.
5544         * disasm-selftests.c: Update.
5545         * dtrace-probe.c: Update.
5546         * dwarf-index-cache.c: Update.
5547         * dwarf-index-write.c: Update.
5548         * dwarf2-frame-tailcall.c: Update.
5549         * dwarf2-frame.c: Update.
5550         * dwarf2loc.c: Update.
5551         * dwarf2read.c: Update.
5552         * eval.c: Update.
5553         * event-loop.c: Update.
5554         * event-top.c: Update.
5555         * exec.c: Update.
5556         * f-valprint.c: Update.
5557         * fbsd-tdep.c: Update.
5558         * frame-unwind.c: Update.
5559         * frame.c: Update.
5560         * gdbtypes.c: Update.
5561         * gnu-v3-abi.c: Update.
5562         * guile/guile-internal.h: Update.
5563         * guile/scm-block.c: Update.
5564         * guile/scm-breakpoint.c: Update.
5565         * guile/scm-cmd.c: Update.
5566         * guile/scm-disasm.c: Update.
5567         * guile/scm-frame.c: Update.
5568         * guile/scm-lazy-string.c: Update.
5569         * guile/scm-math.c: Update.
5570         * guile/scm-param.c: Update.
5571         * guile/scm-ports.c: Update.
5572         * guile/scm-pretty-print.c: Update.
5573         * guile/scm-symbol.c: Update.
5574         * guile/scm-symtab.c: Update.
5575         * guile/scm-type.c: Update.
5576         * guile/scm-value.c: Update.
5577         * i386-linux-tdep.c: Update.
5578         * i386-tdep.c: Update.
5579         * inf-loop.c: Update.
5580         * infcall.c: Update.
5581         * infcmd.c: Update.
5582         * infrun.c: Update.
5583         * jit.c: Update.
5584         * language.c: Update.
5585         * linespec.c: Update.
5586         * linux-fork.c: Update.
5587         * linux-nat.c: Update.
5588         * linux-tdep.c: Update.
5589         * linux-thread-db.c: Update.
5590         * main.c: Update.
5591         * mi/mi-cmd-break.c: Update.
5592         * mi/mi-cmd-stack.c: Update.
5593         * mi/mi-interp.c: Update.
5594         * mi/mi-main.c: Update.
5595         * objc-lang.c: Update.
5596         * p-valprint.c: Update.
5597         * parse.c: Update.
5598         * ppc-linux-tdep.c: Update.
5599         * printcmd.c: Update.
5600         * python/py-arch.c: Update.
5601         * python/py-breakpoint.c: Update.
5602         * python/py-cmd.c: Update.
5603         * python/py-finishbreakpoint.c: Update.
5604         * python/py-frame.c: Update.
5605         * python/py-framefilter.c: Update.
5606         * python/py-gdb-readline.c: Update.
5607         * python/py-inferior.c: Update.
5608         * python/py-infthread.c: Update.
5609         * python/py-lazy-string.c: Update.
5610         * python/py-linetable.c: Update.
5611         * python/py-objfile.c: Update.
5612         * python/py-param.c: Update.
5613         * python/py-prettyprint.c: Update.
5614         * python/py-progspace.c: Update.
5615         * python/py-record-btrace.c: Update.
5616         * python/py-record.c: Update.
5617         * python/py-symbol.c: Update.
5618         * python/py-type.c: Update.
5619         * python/py-unwind.c: Update.
5620         * python/py-utils.c: Update.
5621         * python/py-value.c: Update.
5622         * python/python.c: Update.
5623         * record-btrace.c: Update.
5624         * record-full.c: Update.
5625         * remote-fileio.c: Update.
5626         * remote.c: Update.
5627         * riscv-tdep.c: Update.
5628         * rs6000-aix-tdep.c: Update.
5629         * rs6000-tdep.c: Update.
5630         * rust-exp.y: Update.
5631         * rust-lang.c: Update.
5632         * s390-tdep.c: Update.
5633         * selftest-arch.c: Update.
5634         * solib-dsbt.c: Update.
5635         * solib-frv.c: Update.
5636         * solib-spu.c: Update.
5637         * solib-svr4.c: Update.
5638         * solib.c: Update.
5639         * sparc64-linux-tdep.c: Update.
5640         * stack.c: Update.
5641         * symfile-mem.c: Update.
5642         * symmisc.c: Update.
5643         * target.c: Update.
5644         * thread.c: Update.
5645         * top.c: Update.
5646         * tracefile-tfile.c: Update.
5647         * tui/tui.c: Update.
5648         * typeprint.c: Update.
5649         * unittests/cli-utils-selftests.c: Update.
5650         * unittests/parse-connection-spec-selftests.c: Update.
5651         * valops.c: Update.
5652         * valprint.c: Update.
5653         * value.c: Update.
5654         * varobj.c: Update.
5655         * windows-nat.c: Update.
5656         * x86-linux-nat.c: Update.
5657         * xml-support.c: Update.
5658
5659 2019-04-08  Tom Tromey  <tom@tromey.com>
5660
5661         * xml-support.c: Use C++ exception handling.
5662         * x86-linux-nat.c: Use C++ exception handling.
5663         * windows-nat.c: Use C++ exception handling.
5664         * varobj.c: Use C++ exception handling.
5665         * value.c: Use C++ exception handling.
5666         * valprint.c: Use C++ exception handling.
5667         * valops.c: Use C++ exception handling.
5668         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5669         handling.
5670         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5671         * typeprint.c: Use C++ exception handling.
5672         * tui/tui.c: Use C++ exception handling.
5673         * tracefile-tfile.c: Use C++ exception handling.
5674         * top.c: Use C++ exception handling.
5675         * thread.c: Use C++ exception handling.
5676         * target.c: Use C++ exception handling.
5677         * symmisc.c: Use C++ exception handling.
5678         * symfile-mem.c: Use C++ exception handling.
5679         * stack.c: Use C++ exception handling.
5680         * sparc64-linux-tdep.c: Use C++ exception handling.
5681         * solib.c: Use C++ exception handling.
5682         * solib-svr4.c: Use C++ exception handling.
5683         * solib-spu.c: Use C++ exception handling.
5684         * solib-frv.c: Use C++ exception handling.
5685         * solib-dsbt.c: Use C++ exception handling.
5686         * selftest-arch.c: Use C++ exception handling.
5687         * s390-tdep.c: Use C++ exception handling.
5688         * rust-lang.c: Use C++ exception handling.
5689         * rust-exp.y: Use C++ exception handling.
5690         * rs6000-tdep.c: Use C++ exception handling.
5691         * rs6000-aix-tdep.c: Use C++ exception handling.
5692         * riscv-tdep.c: Use C++ exception handling.
5693         * remote.c: Use C++ exception handling.
5694         * remote-fileio.c: Use C++ exception handling.
5695         * record-full.c: Use C++ exception handling.
5696         * record-btrace.c: Use C++ exception handling.
5697         * python/python.c: Use C++ exception handling.
5698         * python/py-value.c: Use C++ exception handling.
5699         * python/py-utils.c: Use C++ exception handling.
5700         * python/py-unwind.c: Use C++ exception handling.
5701         * python/py-type.c: Use C++ exception handling.
5702         * python/py-symbol.c: Use C++ exception handling.
5703         * python/py-record.c: Use C++ exception handling.
5704         * python/py-record-btrace.c: Use C++ exception handling.
5705         * python/py-progspace.c: Use C++ exception handling.
5706         * python/py-prettyprint.c: Use C++ exception handling.
5707         * python/py-param.c: Use C++ exception handling.
5708         * python/py-objfile.c: Use C++ exception handling.
5709         * python/py-linetable.c: Use C++ exception handling.
5710         * python/py-lazy-string.c: Use C++ exception handling.
5711         * python/py-infthread.c: Use C++ exception handling.
5712         * python/py-inferior.c: Use C++ exception handling.
5713         * python/py-gdb-readline.c: Use C++ exception handling.
5714         * python/py-framefilter.c: Use C++ exception handling.
5715         * python/py-frame.c: Use C++ exception handling.
5716         * python/py-finishbreakpoint.c: Use C++ exception handling.
5717         * python/py-cmd.c: Use C++ exception handling.
5718         * python/py-breakpoint.c: Use C++ exception handling.
5719         * python/py-arch.c: Use C++ exception handling.
5720         * printcmd.c: Use C++ exception handling.
5721         * ppc-linux-tdep.c: Use C++ exception handling.
5722         * parse.c: Use C++ exception handling.
5723         * p-valprint.c: Use C++ exception handling.
5724         * objc-lang.c: Use C++ exception handling.
5725         * mi/mi-main.c: Use C++ exception handling.
5726         * mi/mi-interp.c: Use C++ exception handling.
5727         * mi/mi-cmd-stack.c: Use C++ exception handling.
5728         * mi/mi-cmd-break.c: Use C++ exception handling.
5729         * main.c: Use C++ exception handling.
5730         * linux-thread-db.c: Use C++ exception handling.
5731         * linux-tdep.c: Use C++ exception handling.
5732         * linux-nat.c: Use C++ exception handling.
5733         * linux-fork.c: Use C++ exception handling.
5734         * linespec.c: Use C++ exception handling.
5735         * language.c: Use C++ exception handling.
5736         * jit.c: Use C++ exception handling.
5737         * infrun.c: Use C++ exception handling.
5738         * infcmd.c: Use C++ exception handling.
5739         * infcall.c: Use C++ exception handling.
5740         * inf-loop.c: Use C++ exception handling.
5741         * i386-tdep.c: Use C++ exception handling.
5742         * i386-linux-tdep.c: Use C++ exception handling.
5743         * guile/scm-value.c: Use C++ exception handling.
5744         * guile/scm-type.c: Use C++ exception handling.
5745         * guile/scm-symtab.c: Use C++ exception handling.
5746         * guile/scm-symbol.c: Use C++ exception handling.
5747         * guile/scm-pretty-print.c: Use C++ exception handling.
5748         * guile/scm-ports.c: Use C++ exception handling.
5749         * guile/scm-param.c: Use C++ exception handling.
5750         * guile/scm-math.c: Use C++ exception handling.
5751         * guile/scm-lazy-string.c: Use C++ exception handling.
5752         * guile/scm-frame.c: Use C++ exception handling.
5753         * guile/scm-disasm.c: Use C++ exception handling.
5754         * guile/scm-cmd.c: Use C++ exception handling.
5755         * guile/scm-breakpoint.c: Use C++ exception handling.
5756         * guile/scm-block.c: Use C++ exception handling.
5757         * guile/guile-internal.h: Use C++ exception handling.
5758         * gnu-v3-abi.c: Use C++ exception handling.
5759         * gdbtypes.c: Use C++ exception handling.
5760         * frame.c: Use C++ exception handling.
5761         * frame-unwind.c: Use C++ exception handling.
5762         * fbsd-tdep.c: Use C++ exception handling.
5763         * f-valprint.c: Use C++ exception handling.
5764         * exec.c: Use C++ exception handling.
5765         * event-top.c: Use C++ exception handling.
5766         * event-loop.c: Use C++ exception handling.
5767         * eval.c: Use C++ exception handling.
5768         * dwarf2read.c: Use C++ exception handling.
5769         * dwarf2loc.c: Use C++ exception handling.
5770         * dwarf2-frame.c: Use C++ exception handling.
5771         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5772         * dwarf-index-write.c: Use C++ exception handling.
5773         * dwarf-index-cache.c: Use C++ exception handling.
5774         * dtrace-probe.c: Use C++ exception handling.
5775         * disasm-selftests.c: Use C++ exception handling.
5776         * darwin-nat.c: Use C++ exception handling.
5777         * cp-valprint.c: Use C++ exception handling.
5778         * cp-support.c: Use C++ exception handling.
5779         * cp-abi.c: Use C++ exception handling.
5780         * corelow.c: Use C++ exception handling.
5781         * completer.c: Use C++ exception handling.
5782         * compile/compile-object-run.c: Use C++ exception handling.
5783         * compile/compile-object-load.c: Use C++ exception handling.
5784         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5785         * compile/compile-c-symbols.c: Use C++ exception handling.
5786         * common/selftest.c: Use C++ exception handling.
5787         * common/new-op.c: Use C++ exception handling.
5788         * cli/cli-script.c: Use C++ exception handling.
5789         * cli/cli-interp.c: Use C++ exception handling.
5790         * cli/cli-cmds.c: Use C++ exception handling.
5791         * c-varobj.c: Use C++ exception handling.
5792         * btrace.c: Use C++ exception handling.
5793         * breakpoint.c: Use C++ exception handling.
5794         * break-catch-throw.c: Use C++ exception handling.
5795         * arch-utils.c: Use C++ exception handling.
5796         * amd64-tdep.c: Use C++ exception handling.
5797         * ada-valprint.c: Use C++ exception handling.
5798         * ada-typeprint.c: Use C++ exception handling.
5799         * ada-lang.c: Use C++ exception handling.
5800         * aarch64-tdep.c: Use C++ exception handling.
5801
5802 2019-04-08  Tom Tromey  <tom@tromey.com>
5803
5804         * xml-support.c (gdb_xml_parser::parse): Update.
5805         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5806         * value.c (show_convenience): Update.
5807         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5808         (test_parse_flags_qcs): Update.
5809         * thread.c (thr_try_catch_cmd): Update.
5810         * target.c (target_translate_tls_address): Update.
5811         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5812         (info_frame_command_core, frame_apply_command_count): Update.
5813         * rust-exp.y (rust_lex_exception_test): Update.
5814         * riscv-tdep.c (riscv_print_one_register_info): Update.
5815         * remote.c (remote_target::enable_btrace): Update.
5816         * record-btrace.c (record_btrace_enable_warn): Update.
5817         * python/py-utils.c (gdbpy_convert_exception): Update.
5818         * printcmd.c (do_one_display, print_variable_and_value): Update.
5819         * mi/mi-main.c (mi_print_exception): Update.
5820         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5821         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5822         * linux-nat.c (linux_nat_target::attach): Update.
5823         * linux-fork.c (class scoped_switch_fork_info): Update.
5824         * infrun.c (displaced_step_prepare): Update.
5825         * infcall.c (call_function_by_hand_dummy): Update.
5826         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5827         * gnu-v3-abi.c (print_one_vtable): Update.
5828         * frame.c (get_prev_frame_always): Update.
5829         * f-valprint.c (info_common_command_for_block): Update.
5830         * exec.c (try_open_exec_file): Update.
5831         * exceptions.c (print_exception, exception_print)
5832         (exception_fprintf, exception_print_same): Update.
5833         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5834         * dwarf-index-cache.c (index_cache::store)
5835         (index_cache::lookup_gdb_index): Update.
5836         * darwin-nat.c (maybe_cache_shell): Update.
5837         * cp-valprint.c (cp_print_value_fields): Update.
5838         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5839         (gcc_cplus_symbol_address): Update.
5840         * compile/compile-c-symbols.c (gcc_convert_symbol)
5841         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5842         * common/selftest.c: Update.
5843         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5844         a std::string.
5845         (exception_try_scope_entry, exception_try_scope_exit): Don't
5846         declare.
5847         (struct exception_try_scope): Remove.
5848         (TRY): Don't use exception_try_scope.
5849         (struct gdb_exception): Add constructor, operator=.
5850         <what>: New method.
5851         (struct gdb_exception_RETURN_MASK_ALL)
5852         (struct gdb_exception_RETURN_MASK_ERROR)
5853         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5854         (struct gdb_quit_bad_alloc): Update.
5855         * common/common-exceptions.c (exception_none): Change
5856         initializer.
5857         (struct catcher) <state, exception>: Initialize inline.
5858         <prev>: Remove member.
5859         (current_catcher): Remove.
5860         (catchers): New global.
5861         (exceptions_state_mc_init): Simplify.
5862         (catcher_pop): Remove.
5863         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5864         (try_scope_depth, exception_try_scope_entry)
5865         (exception_try_scope_exit): Remove.
5866         (throw_exception_sjlj): Update.
5867         (exception_messages, exception_messages_size): Remove.
5868         (throw_it): Simplify.
5869         (gdb_exception_sliced_copy): Remove.
5870         (throw_exception_cxx): Update.
5871         * cli/cli-script.c (script_from_file): Update.
5872         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5873         Update.
5874         * ada-valprint.c (ada_val_print): Update.
5875         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5876         (create_excep_cond_exprs): Update.
5877
5878 2019-04-08  Tom Tromey  <tom@tromey.com>
5879
5880         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5881         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5882         (TRY, CATCH, END_CATCH): Remove some definitions.
5883         * common/common-exceptions.c: Don't use GDB_XCPT.
5884         (catcher_list_size): Remove.
5885         (throw_exception, throw_it): Simplify.
5886
5887 2019-04-05  Tom Tromey  <tom@tromey.com>
5888
5889         Revert the header-sorting patch.
5890         * ft32-tdep.c: Revert.
5891         * frv-tdep.c: Revert.
5892         * frv-linux-tdep.c: Revert.
5893         * frame.c: Revert.
5894         * frame-unwind.c: Revert.
5895         * frame-base.c: Revert.
5896         * fork-child.c: Revert.
5897         * findvar.c: Revert.
5898         * findcmd.c: Revert.
5899         * filesystem.c: Revert.
5900         * filename-seen-cache.h: Revert.
5901         * filename-seen-cache.c: Revert.
5902         * fbsd-tdep.c: Revert.
5903         * fbsd-nat.h: Revert.
5904         * fbsd-nat.c: Revert.
5905         * f-valprint.c: Revert.
5906         * f-typeprint.c: Revert.
5907         * f-lang.c: Revert.
5908         * extension.h: Revert.
5909         * extension.c: Revert.
5910         * extension-priv.h: Revert.
5911         * expprint.c: Revert.
5912         * exec.h: Revert.
5913         * exec.c: Revert.
5914         * exceptions.c: Revert.
5915         * event-top.c: Revert.
5916         * event-loop.c: Revert.
5917         * eval.c: Revert.
5918         * elfread.c: Revert.
5919         * dwarf2read.h: Revert.
5920         * dwarf2read.c: Revert.
5921         * dwarf2loc.c: Revert.
5922         * dwarf2expr.h: Revert.
5923         * dwarf2expr.c: Revert.
5924         * dwarf2-frame.c: Revert.
5925         * dwarf2-frame-tailcall.c: Revert.
5926         * dwarf-index-write.h: Revert.
5927         * dwarf-index-write.c: Revert.
5928         * dwarf-index-common.c: Revert.
5929         * dwarf-index-cache.h: Revert.
5930         * dwarf-index-cache.c: Revert.
5931         * dummy-frame.c: Revert.
5932         * dtrace-probe.c: Revert.
5933         * disasm.h: Revert.
5934         * disasm.c: Revert.
5935         * disasm-selftests.c: Revert.
5936         * dictionary.c: Revert.
5937         * dicos-tdep.c: Revert.
5938         * demangle.c: Revert.
5939         * dcache.h: Revert.
5940         * dcache.c: Revert.
5941         * darwin-nat.h: Revert.
5942         * darwin-nat.c: Revert.
5943         * darwin-nat-info.c: Revert.
5944         * d-valprint.c: Revert.
5945         * d-namespace.c: Revert.
5946         * d-lang.c: Revert.
5947         * ctf.c: Revert.
5948         * csky-tdep.c: Revert.
5949         * csky-linux-tdep.c: Revert.
5950         * cris-tdep.c: Revert.
5951         * cris-linux-tdep.c: Revert.
5952         * cp-valprint.c: Revert.
5953         * cp-support.c: Revert.
5954         * cp-namespace.c: Revert.
5955         * cp-abi.c: Revert.
5956         * corelow.c: Revert.
5957         * corefile.c: Revert.
5958         * continuations.c: Revert.
5959         * completer.h: Revert.
5960         * completer.c: Revert.
5961         * complaints.c: Revert.
5962         * coffread.c: Revert.
5963         * coff-pe-read.c: Revert.
5964         * cli-out.h: Revert.
5965         * cli-out.c: Revert.
5966         * charset.c: Revert.
5967         * c-varobj.c: Revert.
5968         * c-valprint.c: Revert.
5969         * c-typeprint.c: Revert.
5970         * c-lang.c: Revert.
5971         * buildsym.c: Revert.
5972         * buildsym-legacy.c: Revert.
5973         * build-id.h: Revert.
5974         * build-id.c: Revert.
5975         * btrace.c: Revert.
5976         * bsd-uthread.c: Revert.
5977         * breakpoint.h: Revert.
5978         * breakpoint.c: Revert.
5979         * break-catch-throw.c: Revert.
5980         * break-catch-syscall.c: Revert.
5981         * break-catch-sig.c: Revert.
5982         * blockframe.c: Revert.
5983         * block.c: Revert.
5984         * bfin-tdep.c: Revert.
5985         * bfin-linux-tdep.c: Revert.
5986         * bfd-target.c: Revert.
5987         * bcache.c: Revert.
5988         * ax-general.c: Revert.
5989         * ax-gdb.h: Revert.
5990         * ax-gdb.c: Revert.
5991         * avr-tdep.c: Revert.
5992         * auxv.c: Revert.
5993         * auto-load.c: Revert.
5994         * arm-wince-tdep.c: Revert.
5995         * arm-tdep.c: Revert.
5996         * arm-symbian-tdep.c: Revert.
5997         * arm-pikeos-tdep.c: Revert.
5998         * arm-obsd-tdep.c: Revert.
5999         * arm-nbsd-tdep.c: Revert.
6000         * arm-nbsd-nat.c: Revert.
6001         * arm-linux-tdep.c: Revert.
6002         * arm-linux-nat.c: Revert.
6003         * arm-fbsd-tdep.c: Revert.
6004         * arm-fbsd-nat.c: Revert.
6005         * arm-bsd-tdep.c: Revert.
6006         * arch-utils.c: Revert.
6007         * arc-tdep.c: Revert.
6008         * arc-newlib-tdep.c: Revert.
6009         * annotate.h: Revert.
6010         * annotate.c: Revert.
6011         * amd64-windows-tdep.c: Revert.
6012         * amd64-windows-nat.c: Revert.
6013         * amd64-tdep.c: Revert.
6014         * amd64-sol2-tdep.c: Revert.
6015         * amd64-obsd-tdep.c: Revert.
6016         * amd64-obsd-nat.c: Revert.
6017         * amd64-nbsd-tdep.c: Revert.
6018         * amd64-nbsd-nat.c: Revert.
6019         * amd64-nat.c: Revert.
6020         * amd64-linux-tdep.c: Revert.
6021         * amd64-linux-nat.c: Revert.
6022         * amd64-fbsd-tdep.c: Revert.
6023         * amd64-fbsd-nat.c: Revert.
6024         * amd64-dicos-tdep.c: Revert.
6025         * amd64-darwin-tdep.c: Revert.
6026         * amd64-bsd-nat.c: Revert.
6027         * alpha-tdep.c: Revert.
6028         * alpha-obsd-tdep.c: Revert.
6029         * alpha-nbsd-tdep.c: Revert.
6030         * alpha-mdebug-tdep.c: Revert.
6031         * alpha-linux-tdep.c: Revert.
6032         * alpha-linux-nat.c: Revert.
6033         * alpha-bsd-tdep.c: Revert.
6034         * alpha-bsd-nat.c: Revert.
6035         * aix-thread.c: Revert.
6036         * agent.c: Revert.
6037         * addrmap.c: Revert.
6038         * ada-varobj.c: Revert.
6039         * ada-valprint.c: Revert.
6040         * ada-typeprint.c: Revert.
6041         * ada-tasks.c: Revert.
6042         * ada-lang.c: Revert.
6043         * aarch64-tdep.c: Revert.
6044         * aarch64-ravenscar-thread.c: Revert.
6045         * aarch64-newlib-tdep.c: Revert.
6046         * aarch64-linux-tdep.c: Revert.
6047         * aarch64-linux-nat.c: Revert.
6048         * aarch64-fbsd-tdep.c: Revert.
6049         * aarch64-fbsd-nat.c: Revert.
6050         * aarch32-linux-nat.c: Revert.
6051
6052 2019-04-05  Tom Tromey  <tom@tromey.com>
6053
6054         * ft32-tdep.c: Sort headers.
6055         * frv-tdep.c: Sort headers.
6056         * frv-linux-tdep.c: Sort headers.
6057         * frame.c: Sort headers.
6058         * frame-unwind.c: Sort headers.
6059         * frame-base.c: Sort headers.
6060         * fork-child.c: Sort headers.
6061         * findvar.c: Sort headers.
6062         * findcmd.c: Sort headers.
6063         * filesystem.c: Sort headers.
6064         * filename-seen-cache.h: Sort headers.
6065         * filename-seen-cache.c: Sort headers.
6066         * fbsd-tdep.c: Sort headers.
6067         * fbsd-nat.h: Sort headers.
6068         * fbsd-nat.c: Sort headers.
6069         * f-valprint.c: Sort headers.
6070         * f-typeprint.c: Sort headers.
6071         * f-lang.c: Sort headers.
6072         * extension.h: Sort headers.
6073         * extension.c: Sort headers.
6074         * extension-priv.h: Sort headers.
6075         * expprint.c: Sort headers.
6076         * exec.h: Sort headers.
6077         * exec.c: Sort headers.
6078         * exceptions.c: Sort headers.
6079         * event-top.c: Sort headers.
6080         * event-loop.c: Sort headers.
6081         * eval.c: Sort headers.
6082         * elfread.c: Sort headers.
6083         * dwarf2read.h: Sort headers.
6084         * dwarf2read.c: Sort headers.
6085         * dwarf2loc.c: Sort headers.
6086         * dwarf2expr.h: Sort headers.
6087         * dwarf2expr.c: Sort headers.
6088         * dwarf2-frame.c: Sort headers.
6089         * dwarf2-frame-tailcall.c: Sort headers.
6090         * dwarf-index-write.h: Sort headers.
6091         * dwarf-index-write.c: Sort headers.
6092         * dwarf-index-common.c: Sort headers.
6093         * dwarf-index-cache.h: Sort headers.
6094         * dwarf-index-cache.c: Sort headers.
6095         * dummy-frame.c: Sort headers.
6096         * dtrace-probe.c: Sort headers.
6097         * disasm.h: Sort headers.
6098         * disasm.c: Sort headers.
6099         * disasm-selftests.c: Sort headers.
6100         * dictionary.c: Sort headers.
6101         * dicos-tdep.c: Sort headers.
6102         * demangle.c: Sort headers.
6103         * dcache.h: Sort headers.
6104         * dcache.c: Sort headers.
6105         * darwin-nat.h: Sort headers.
6106         * darwin-nat.c: Sort headers.
6107         * darwin-nat-info.c: Sort headers.
6108         * d-valprint.c: Sort headers.
6109         * d-namespace.c: Sort headers.
6110         * d-lang.c: Sort headers.
6111         * ctf.c: Sort headers.
6112         * csky-tdep.c: Sort headers.
6113         * csky-linux-tdep.c: Sort headers.
6114         * cris-tdep.c: Sort headers.
6115         * cris-linux-tdep.c: Sort headers.
6116         * cp-valprint.c: Sort headers.
6117         * cp-support.c: Sort headers.
6118         * cp-namespace.c: Sort headers.
6119         * cp-abi.c: Sort headers.
6120         * corelow.c: Sort headers.
6121         * corefile.c: Sort headers.
6122         * continuations.c: Sort headers.
6123         * completer.h: Sort headers.
6124         * completer.c: Sort headers.
6125         * complaints.c: Sort headers.
6126         * coffread.c: Sort headers.
6127         * coff-pe-read.c: Sort headers.
6128         * cli-out.h: Sort headers.
6129         * cli-out.c: Sort headers.
6130         * charset.c: Sort headers.
6131         * c-varobj.c: Sort headers.
6132         * c-valprint.c: Sort headers.
6133         * c-typeprint.c: Sort headers.
6134         * c-lang.c: Sort headers.
6135         * buildsym.c: Sort headers.
6136         * buildsym-legacy.c: Sort headers.
6137         * build-id.h: Sort headers.
6138         * build-id.c: Sort headers.
6139         * btrace.c: Sort headers.
6140         * bsd-uthread.c: Sort headers.
6141         * breakpoint.h: Sort headers.
6142         * breakpoint.c: Sort headers.
6143         * break-catch-throw.c: Sort headers.
6144         * break-catch-syscall.c: Sort headers.
6145         * break-catch-sig.c: Sort headers.
6146         * blockframe.c: Sort headers.
6147         * block.c: Sort headers.
6148         * bfin-tdep.c: Sort headers.
6149         * bfin-linux-tdep.c: Sort headers.
6150         * bfd-target.c: Sort headers.
6151         * bcache.c: Sort headers.
6152         * ax-general.c: Sort headers.
6153         * ax-gdb.h: Sort headers.
6154         * ax-gdb.c: Sort headers.
6155         * avr-tdep.c: Sort headers.
6156         * auxv.c: Sort headers.
6157         * auto-load.c: Sort headers.
6158         * arm-wince-tdep.c: Sort headers.
6159         * arm-tdep.c: Sort headers.
6160         * arm-symbian-tdep.c: Sort headers.
6161         * arm-pikeos-tdep.c: Sort headers.
6162         * arm-obsd-tdep.c: Sort headers.
6163         * arm-nbsd-tdep.c: Sort headers.
6164         * arm-nbsd-nat.c: Sort headers.
6165         * arm-linux-tdep.c: Sort headers.
6166         * arm-linux-nat.c: Sort headers.
6167         * arm-fbsd-tdep.c: Sort headers.
6168         * arm-fbsd-nat.c: Sort headers.
6169         * arm-bsd-tdep.c: Sort headers.
6170         * arch-utils.c: Sort headers.
6171         * arc-tdep.c: Sort headers.
6172         * arc-newlib-tdep.c: Sort headers.
6173         * annotate.h: Sort headers.
6174         * annotate.c: Sort headers.
6175         * amd64-windows-tdep.c: Sort headers.
6176         * amd64-windows-nat.c: Sort headers.
6177         * amd64-tdep.c: Sort headers.
6178         * amd64-sol2-tdep.c: Sort headers.
6179         * amd64-obsd-tdep.c: Sort headers.
6180         * amd64-obsd-nat.c: Sort headers.
6181         * amd64-nbsd-tdep.c: Sort headers.
6182         * amd64-nbsd-nat.c: Sort headers.
6183         * amd64-nat.c: Sort headers.
6184         * amd64-linux-tdep.c: Sort headers.
6185         * amd64-linux-nat.c: Sort headers.
6186         * amd64-fbsd-tdep.c: Sort headers.
6187         * amd64-fbsd-nat.c: Sort headers.
6188         * amd64-dicos-tdep.c: Sort headers.
6189         * amd64-darwin-tdep.c: Sort headers.
6190         * amd64-bsd-nat.c: Sort headers.
6191         * alpha-tdep.c: Sort headers.
6192         * alpha-obsd-tdep.c: Sort headers.
6193         * alpha-nbsd-tdep.c: Sort headers.
6194         * alpha-mdebug-tdep.c: Sort headers.
6195         * alpha-linux-tdep.c: Sort headers.
6196         * alpha-linux-nat.c: Sort headers.
6197         * alpha-bsd-tdep.c: Sort headers.
6198         * alpha-bsd-nat.c: Sort headers.
6199         * aix-thread.c: Sort headers.
6200         * agent.c: Sort headers.
6201         * addrmap.c: Sort headers.
6202         * ada-varobj.c: Sort headers.
6203         * ada-valprint.c: Sort headers.
6204         * ada-typeprint.c: Sort headers.
6205         * ada-tasks.c: Sort headers.
6206         * ada-lang.c: Sort headers.
6207         * aarch64-tdep.c: Sort headers.
6208         * aarch64-ravenscar-thread.c: Sort headers.
6209         * aarch64-newlib-tdep.c: Sort headers.
6210         * aarch64-linux-tdep.c: Sort headers.
6211         * aarch64-linux-nat.c: Sort headers.
6212         * aarch64-fbsd-tdep.c: Sort headers.
6213         * aarch64-fbsd-nat.c: Sort headers.
6214         * aarch32-linux-nat.c: Sort headers.
6215
6216 2019-04-04  Tom Tromey  <tom@tromey.com>
6217
6218         * varobj.c (varobj_create): Update.
6219         * rust-exp.y (struct rust_parser) <update_innermost_block,
6220         lookup_symbol>: New methods.
6221         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6222         Rename.
6223         (rust_parser::rust_lookup_type)
6224         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6225         * printcmd.c (display_command, do_one_display): Update.
6226         * parser-defs.h (struct parser_state) <parser_state>: Add
6227         "tracker" parameter.
6228         (block_tracker): New member.
6229         (class innermost_block_tracker) <innermost_block_tracker>: Add
6230         "types" parameter.
6231         <reset>: Remove method.
6232         (innermost_block): Don't declare.
6233         (null_post_parser): Update.
6234         * parse.c (innermost_block): Remove global.
6235         (write_dollar_variable): Update.
6236         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6237         Remove "tracker_types" parameter.
6238         (parse_expression): Add "tracker" parameter.
6239         (parse_expression_for_completion): Update.
6240         (null_post_parser): Add "tracker" parameter.
6241         * p-exp.y: Update rules.
6242         * m2-exp.y: Update rules.
6243         * language.h (struct language_defn) <la_post_parser>: Add
6244         "tracker" parameter.
6245         * go-exp.y: Update rules.
6246         * f-exp.y: Update rules.
6247         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6248         parameter.
6249         * d-exp.y: Update rules.
6250         * c-exp.y: Update rules.
6251         * breakpoint.c (set_breakpoint_condition): Create an
6252         innermost_block_tracker.
6253         (watch_command_1): Likewise.
6254         * ada-lang.c (resolve): Add "tracker" parameter.
6255         (resolve_subexp): Likewise.
6256         * ada-exp.y (write_var_from_sym): Update.
6257
6258 2019-04-04  Tom Tromey  <tom@tromey.com>
6259
6260         * type-stack.h: New file.
6261         * type-stack.c: New file.
6262         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6263         type-stack.h.
6264         (insert_into_type_stack, insert_type, push_type, push_type_int)
6265         (insert_type_address_space, pop_type, pop_type_int)
6266         (pop_typelist, pop_type_stack, append_type_stack)
6267         (push_type_stack, get_type_stack, push_typelist)
6268         (follow_type_instance_flags, follow_types): Don't declare.
6269         * parse.c (type_stack): Remove global.
6270         (parse_exp_in_context): Update.
6271         (insert_into_type_stack, insert_type, push_type, push_type_int)
6272         (insert_type_address_space, pop_type, pop_type_int)
6273         (pop_typelist, pop_type_stack, append_type_stack)
6274         (push_type_stack, get_type_stack, push_typelist)
6275         (follow_type_instance_flags, follow_types): Remove (moved to
6276         type-stack.c).
6277         * f-exp.y (type_stack): New global.
6278         Update rules.
6279         (push_kind_type, f_parse): Update.
6280         * d-exp.y (type_stack): New global.
6281         Update rules.
6282         (d_parse): Update.
6283         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6284         Update rules.
6285         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6286         (HFILES_NO_SRCDIR): Add type-stack.h.
6287
6288 2019-04-04  Tom Tromey  <tom@tromey.com>
6289
6290         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6291         (rust_parser::convert_ast_to_expression, rust_parse)
6292         (rust_lex_test_completion, rust_lex_tests): Update.
6293         * parser-defs.h (struct expr_completion_state): New.
6294         (struct parser_state) <parser_state>: Add completion parameter.
6295         <mark_struct_expression, mark_completion_tag>: New methods.
6296         <parse_completion, m_completion_state>: New members.
6297         (prefixify_expression, null_post_parser): Update.
6298         (mark_struct_expression, mark_completion_tag): Don't declare.
6299         * parse.c (parse_completion, expout_last_struct)
6300         (expout_tag_completion_type, expout_completion_name): Remove
6301         globals.
6302         (parser_state::mark_struct_expression)
6303         (parser_state::mark_completion_tag): Now methods.
6304         (prefixify_expression): Add last_struct parameter.
6305         (prefixify_subexp): Likewise.
6306         (parse_exp_1): Update.
6307         (parse_exp_in_context): Add cstate parameter.  Update.
6308         (parse_expression_for_completion): Create an
6309         expr_completion_state.
6310         (null_post_parser): Add "completion" parameter.
6311         * p-exp.y: Update rules.
6312         (yylex): Update.
6313         * language.h (struct language_defn) <la_post_parser>: Add
6314         "completing" parameter.
6315         * go-exp.y: Update rules.
6316         (lex_one_token): Update.
6317         * expression.h (parse_completion): Don't declare.
6318         * d-exp.y: Update rules.
6319         (lex_one_token): Update rules.
6320         * c-exp.y: Update rules.
6321         (lex_one_token): Update.
6322         * ada-lang.c (resolve): Add "parse_completion" parameter.
6323         (resolve_subexp): Likewise.
6324         (ada_resolve_function): Likewise.
6325
6326 2019-04-04  Tom Tromey  <tom@tromey.com>
6327
6328         * parser-defs.h (struct parser_state) <start_arglist,
6329         end_arglist>: New methods.
6330         <arglist_len, m_funcall_chain>: New members.
6331         (arglist_len, start_arglist, end_arglist): Don't declare.
6332         * parse.c (arglist_len, funcall_chain): Remove global.
6333         (start_arglist, end_arglist): Remove functions.
6334         (parse_exp_in_context): Update.
6335         * p-exp.y: Update rules.
6336         * m2-exp.y: Update rules.
6337         * go-exp.y: Update rules.
6338         * f-exp.y: Update rules.
6339         * d-exp.y: Update rules.
6340         * c-exp.y: Update rules.
6341
6342 2019-04-04  Tom Tromey  <tom@tromey.com>
6343
6344         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6345         lex_operator, push_back>: New methods.
6346         Update all rules.
6347         (rust_parser::lex_hex, lex_escape): Rename and update.
6348         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6349         (rust_parser::lex_operator): Rename and update.
6350         (rust_parser::lex_number, rustyylex, rustyyerror)
6351         (rust_lex_test_init, rust_lex_test_sequence)
6352         (rust_lex_test_push_back, rust_lex_tests): Update.
6353         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6354         parameter.
6355         <lexptr, prev_lexptr>: New members.
6356         (lexptr, prev_lexptr): Don't declare.
6357         * parse.c (lexptr, prev_lexptr): Remove globals.
6358         (parse_exp_in_context): Update.
6359         * p-exp.y (yylex, yyerror): Update.
6360         * m2-exp.y (parse_number, yylex, yyerror): Update.
6361         * go-exp.y (lex_one_token, yyerror): Update.
6362         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6363         * d-exp.y (lex_one_token, yyerror): Update.
6364         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6365         (lex_one_token, yyerror): Update.
6366         * ada-lex.l (YY_INPUT): Update.
6367         (rewind_to_char): Update.
6368         * ada-exp.y (yyerror): Update.
6369
6370 2019-04-04  Tom Tromey  <tom@tromey.com>
6371
6372         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6373         * parser-defs.h (struct parser_state) <parser_state>: Add new
6374         parameter.
6375         <comma_terminates>: New member.
6376         (comma_terminates): Don't declare global.
6377         * parse.c (comma_terminates): Remove global.
6378         (parse_exp_in_context): Update.
6379         * p-exp.y (yylex): Update.
6380         * m2-exp.y (yylex): Update.
6381         * go-exp.y (lex_one_token): Update.
6382         * f-exp.y (yylex): Update.
6383         * d-exp.y (lex_one_token): Update.
6384         * c-exp.y (lex_one_token): Update.
6385         * ada-lex.l: Update.
6386
6387 2019-04-04  Tom Tromey  <tom@tromey.com>
6388
6389         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6390         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6391         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6392         * parser-defs.h (paren_depth): Don't declare.
6393         * parse.c (paren_depth): Remove global.
6394         (parse_exp_in_context): Update.
6395         * p-exp.y (paren_depth): New global.
6396         (pascal_parse): Initialize it.
6397         * m2-exp.y (paren_depth): New global.
6398         (m2_parse): Initialize it.
6399         * go-exp.y (paren_depth): New global.
6400         (go_parse): Initialize it.
6401         * f-exp.y (paren_depth): New global.
6402         (f_parse): Initialize it.
6403         * d-exp.y (paren_depth): New global.
6404         (d_parse): Initialize it.
6405         * c-exp.y (paren_depth): New global.
6406         (c_parse): Initialize it.
6407         * ada-lex.l (paren_depth): New global.
6408         (lexer_init): Initialize it.
6409
6410 2019-04-04  Tom Tromey  <tom@tromey.com>
6411
6412         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6413         (rust_parser::convert_ast_to_type)
6414         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6415         * parser-defs.h (struct parser_state) <parser_state>: Add
6416         parameters.  Initialize new members.
6417         <expression_context_block, expression_context_pc>: New members.
6418         * parse.c (expression_context_block, expression_context_pc):
6419         Remove globals.
6420         (parse_exp_in_context): Update.
6421         * p-exp.y: Update all rules.
6422         (yylex): Update.
6423         * m2-exp.y: Update all rules.
6424         (yylex): Update.
6425         * go-exp.y (yylex): Update.
6426         * f-exp.y (yylex): Update.
6427         * d-exp.y: Update all rules.
6428         (yylex): Update.
6429         * c-exp.y: Update all rules.
6430         (lex_one_token, classify_name, yylex, c_parse): Update.
6431         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6432
6433 2019-04-04  Tom Tromey  <tom@tromey.com>
6434
6435         * gdbarch.h, gdbarch.c: Rebuild.
6436         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6437         * stap-probe.h:
6438         (struct stap_parse_info): Replace "parser_state" with
6439         "expr_builder".
6440         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6441         (parser_state): New class.
6442         * parse.c (expr_builder): Rename.
6443         (expr_builder::release): Rename.
6444         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6445         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6446         (write_exp_elt_longcst, write_exp_elt_floatcst)
6447         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6448         (write_exp_string_vector, write_exp_bitstring)
6449         (write_exp_msymbol, mark_struct_expression)
6450         (write_dollar_variable)
6451         (insert_type_address_space, increase_expout_size): Replace
6452         "parser_state" with "expr_builder".
6453         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6454         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6455         "parser_state" with "expr_builder".
6456
6457 2019-04-04  Tom Tromey  <tom@tromey.com>
6458
6459         * rust-exp.y: Replace "parse_language" with method call.
6460         * p-exp.y:
6461         (yylex): Replace "parse_language" with method call.
6462         * m2-exp.y:
6463         (yylex): Replace "parse_language" with method call.
6464         * go-exp.y (classify_name): Replace "parse_language" with method
6465         call.
6466         * f-exp.y (yylex): Replace "parse_language" with method call.
6467         * d-exp.y (lex_one_token): Replace "parse_language" with method
6468         call.
6469         * c-exp.y:
6470         (lex_one_token, classify_name, yylex): Replace "parse_language"
6471         with method call.
6472         * ada-exp.y (find_primitive_type, type_char)
6473         (type_system_address): Replace "parse_language" with method call.
6474
6475 2019-04-04  Tom Tromey  <tom@tromey.com>
6476
6477         * rust-exp.y: Replace "parse_gdbarch" with method call.
6478         * parse.c (write_dollar_variable, insert_type_address_space):
6479         Replace "parse_gdbarch" with method call.
6480         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6481         call.
6482         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6483         call.
6484         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6485         "parse_gdbarch" with method call.
6486         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6487         with method call.
6488         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6489         "parse_gdbarch" with method call.
6490         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6491         "parse_gdbarch" with method call.
6492         * c-exp.y (parse_type, parse_number, classify_name): Replace
6493         "parse_gdbarch" with method call.
6494         * ada-lex.l: Replace "parse_gdbarch" with method call.
6495         * ada-exp.y (parse_type, find_primitive_type, type_char)
6496         (type_system_address): Replace "parse_gdbarch" with method call.
6497
6498 2019-04-04  Tom Tromey  <tom@tromey.com>
6499
6500         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6501         * stap-probe.c (stap_parse_argument): Update.
6502         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6503         initial_size parameter.
6504         * rust-exp.y (rust_lex_tests): Update.
6505         * parse.c (parser_state): Update.
6506         (parse_exp_in_context): Update.
6507         * parser-defs.h (struct parser_state) <parser_state>: Remove
6508         "initial_size" parameter.
6509
6510 2019-04-04  Tom Tromey  <tom@tromey.com>
6511
6512         * parser-defs.h (increase_expout_size): Don't declare.
6513         * parse.c (increase_expout_size): Now static.
6514
6515 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6516
6517         * gnu-nat.c (gnu_nat_target::wait): Fix
6518         target_waitstatus_to_string call.
6519
6520 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6521
6522         * eval.c (evaluate_subexp_standard): Handle internal functions
6523         during Fortran function call handling.
6524
6525 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6526
6527         * NEWS: Mention new internal functions.
6528         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6529         (read_base_type): Use dwarf2_init_complex_target_type.
6530         * value.c (creal_internal_fn): New function.
6531         (cimag_internal_fn): New function.
6532         (_initialize_values): Register new internal functions.
6533
6534 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6535
6536         * infrun.c (stop_all_threads): If debug_infrun, always
6537         trace the wait status after wait_one, using
6538         target_waitstatus_to_string and target_pid_to_str.
6539         (handle_inferior_event): Replace various trace of
6540         wait status kind by a single trace.
6541         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6542         wait status kind image by target_waitstatus_to_string.
6543         * target/waitstatus.c (target_waitstatus_to_string): Fix
6544         obsolete comment.
6545
6546 2019-04-01  Tom Tromey  <tromey@adacore.com>
6547
6548         PR symtab/23331:
6549         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6550
6551 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6552             Pedro Alves  <palves@redhat.com>
6553
6554         * top.c (quit_force): Call 'finalize_values'.
6555         * value.c (finalize_values): New function.
6556         * value.h (finalize_values): Declare.
6557
6558 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6559
6560         * NEWS: Announce $_gdb_major and $_gdb_minor.
6561
6562         * top.c (init_gdb_version_vars): New function.
6563         (gdb_init): Call init_gdb_version_vars.
6564
6565 2019-03-29  Tom Tromey  <tromey@adacore.com>
6566
6567         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6568         help text.  Remove dead code.
6569
6570 2019-03-29  Keith Seitz  <keiths@redhat.com>
6571
6572         From Siddhesh Poyarekar:
6573         * f-lang.h (f77_get_upperbound): Return LONGEST.
6574         (f77_get_lowerbound): Likewise.
6575         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6576         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6577         print them.
6578         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6579         plongest to format print it.
6580         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6581         (f77_get_upperbound): Likewise.
6582         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6583         LOWER_BOUND to LONGEST.
6584         (f77_create_arrayprint_offset_tbl): Likewise.
6585
6586 2019-03-29  Keith Seitz  <keiths@redhat.com>
6587
6588         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6589         %s/pulongest for TYPE_LENGTH instead of %d in format
6590         strings.
6591         * ada-typerint.c (ada_print_type): Likewise.
6592         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6593         * compile/compile-c-support.c (generate_register_struct): Likewise.
6594         * gdbtypes.c (recursive_dump_type): Likewise.
6595         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6596         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6597         instead of %d in format strings.
6598         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6599         to std::min to ULONGEST.
6600         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6601         instead of %d in format strings.
6602         * tracepoint.c (info_scope_command): Likewise.
6603         * typeprint.c (print_offset_data::update)
6604         (print_offset_data::finish): Likewise.
6605         * xtensa-tdep.c (xtensa_store_return_value)
6606         (xtensa_push_dummy_call): Likewise.
6607
6608 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6609
6610         * windows-nat.c (display_selector): Fixed format specifications
6611         for 64-bit Cygwin.
6612
6613 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6614
6615         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6616
6617 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6618
6619         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6620         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6621         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6622         (nios2_linux_init_abi): Install it.
6623
6624 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6625
6626         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6627
6628 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6629
6630         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6631
6632 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6633             Tom Tromey  <tromey@adacore.com>
6634
6635         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6636
6637 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6638
6639         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6640         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6641         method to compute the bounds of range types. Also print "[evaluated]"
6642         if the bounds' values come from a dynamic evaluation.
6643
6644 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6645
6646         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6647         whitespace when pretty printing is on.
6648
6649 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6650
6651         * ppc-linux-nat.c: Add include.
6652
6653 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6654
6655         * NEWS: Mention AArch64 Pointer Authentication.
6656
6657 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6658
6659         * arm-linux-nat.c: Add include.
6660
6661 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6662
6663         * source-cache.c (source_cache::get_source_lines): Re-read
6664         fullname after calling open_source_file.
6665
6666 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6667
6668         * NEWS: Mention TLS support for FreeBSD.
6669
6670 2019-03-25  Tom Tromey  <tromey@adacore.com>
6671
6672         * minsyms.c (BUNCH_SIZE): Update comment.
6673         (~minimal_symbol_reader): Remove old comment.
6674         (compact_minimal_symbols): Update comment.
6675         (minimal_symbol_reader::install): Remove old comment.  Update
6676         other comments.
6677
6678 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6679
6680         * s390-linux-nat.c: Add include.
6681
6682 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6683
6684         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6685         Call linux_get_hwcap.
6686         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6687         Likewise.
6688         (aarch64_linux_get_hwcap): Remove function.
6689         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6690         declaration.
6691         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6692         linux_get_hwcap.
6693         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6694         * linux-tdep.c (linux_get_hwcap): Add function.
6695         (linux_get_hwcap2): Likewise.
6696         * linux-tdep.h (linux_get_hwcap): Add declaration.
6697         (linux_get_hwcap2): Likewise.
6698         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6699         (ppc_linux_get_hwcap2): Likewise.
6700         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6701         linux_get_hwcap.
6702         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6703         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6704         (ppc_linux_nat_target::read_description): Likewise.
6705         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6706         * s390-linux-nat.c: Likewise.
6707         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6708
6709 2019-03-24  Tom Tromey  <tom@tromey.com>
6710
6711         * ada-lang.c (standard_lookup): Simplify initialization.
6712         (ada_lookup_symbol_nonlocal): Simplify return.
6713         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6714         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6715         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6716         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6717         initialization.
6718         * solib.c (solib_global_lookup): Simplify.
6719         * symtab.c (null_block_symbol): Remove.
6720         (symbol_cache_lookup): Simplify returns.
6721         (lookup_language_this): Simplify returns.
6722         (lookup_symbol_aux): Simplify return.
6723         (lookup_local_symbol): Simplify returns.
6724         (lookup_global_symbol_from_objfile): Simplify return.
6725         (lookup_symbol_in_objfile_symtabs)
6726         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6727         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6728         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6729         * cp-namespace.c (cp_lookup_bare_symbol)
6730         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6731         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6732         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6733         (cp_lookup_symbol_via_imports): Simplify initialization.
6734         (find_symbol_in_baseclass): Likewise.
6735         * symtab.h (null_block_symbol): Remove.
6736         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6737         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6738         (d_lookup_symbol_module): Likewise.
6739         (find_symbol_in_baseclass): Simplify initialization.
6740
6741 2019-03-24  Tom Tromey  <tom@tromey.com>
6742
6743         * expression.h: Don't include symtab.h.
6744         (struct block): Forward declare.
6745
6746 2019-03-24  Tom Tromey  <tom@tromey.com>
6747
6748         * c-exp.y (typebase): Remove casts.
6749         * gdbtypes.c (lookup_unsigned_typename, )
6750         (lookup_signed_typename): Remove cast.
6751         * eval.c (parse_to_comma_and_eval): Remove cast.
6752         * parse.c (write_dollar_variable): Remove cast.
6753         * block.h (struct block) <superblock>: Now const.
6754         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6755         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6756         (map_block): Make "block" const.
6757         * symfile.h (struct quick_symbol_functions)
6758         <map_matching_symbols>: Constify block argument to "callback".
6759         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6760         const.
6761         (find_pc_sect_compunit_symtab): Make "b" const.
6762         (find_symbol_at_address): Likewise.
6763         (search_symbols): Likewise.
6764         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6765         (dw2_debug_names_lookup_symbol): Likewise.
6766         (dw2_map_matching_symbols): Update.
6767         * p-valprint.c (pascal_val_print): Remove "block".
6768         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6769         (aux_add_nonlocal_symbols): Make "block" const.
6770         (resolve_subexp): Remove cast.
6771         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6772         const.
6773         (iterate_over_file_blocks): Likewise.
6774         * f-exp.y (%union) <bval>: Remove.
6775         * coffread.c (patch_opaque_types): Make "b" const.
6776         * spu-tdep.c (spu_catch_start): Make "block" const.
6777         * c-valprint.c (print_unpacked_pointer): Remove "block".
6778         * symmisc.c (dump_symtab_1): Make "b" const.
6779         (block_depth): Make "block" const.
6780         * d-exp.y (%union) <bval>: Remove.
6781         * cp-support.h (cp_lookup_rtti_type): Update.
6782         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6783         * psymtab.c (psym_lookup_symbol): Make "block" const.
6784         (maintenance_check_psymtabs): Make "b" const.
6785         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6786         (enumerate_locals, enumerate_args): Update.
6787         * python/py-symtab.c (stpy_global_block): Make "block" const.
6788         (stpy_static_block): Likewise.
6789         * inline-frame.c (block_starting_point_at): Make "new_block"
6790         const.
6791         * block.c (find_block_in_blockvector): Make return type const.
6792         (blockvector_for_pc_sect): Make "b" const.
6793         (find_block_in_blockvector): Make "b" const.
6794
6795 2019-03-23  Tom Tromey  <tom@tromey.com>
6796
6797         * varobj.c (varobj_create): Update.
6798         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6799         * printcmd.c (display_command, do_one_display): Don't reset
6800         innermost_block.
6801         * parser-defs.h (enum innermost_block_tracker_type): Move to
6802         expression.h.
6803         (innermost_block): Update comment.
6804         * parse.c (parse_exp_1): Add tracker_types parameter.
6805         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6806         tracker_types parameter.  Reset innermost_block.
6807         (parse_exp_in_context): Remove.
6808         (parse_expression_for_completion): Update.
6809         * objfiles.c (~objfile): Don't reset expression_context_block or
6810         innermost_block.
6811         * expression.h (enum innermost_block_tracker_type): Move from
6812         parser-defs.h.
6813         (parse_exp_1): Add tracker_types parameter.
6814         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6815         reset innermost_block.
6816
6817 2019-03-23  Tom Tromey  <tom@tromey.com>
6818
6819         * objfiles.h: Include bcache.h.
6820
6821 2019-03-23  Tom Tromey  <tom@tromey.com>
6822
6823         * linespec.c (get_current_search_block): Use
6824         scoped_restore_current_language.
6825         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6826
6827 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6828             Jiong Wang  <jiong.wang@arm.com>
6829
6830         * aarch64-linux-tdep.c
6831         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6832         section.
6833         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6834
6835 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6836             Jiong Wang  <jiong.wang@arm.com>
6837
6838         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6839         instructions.
6840         (aarch64_analyze_prologue_test): Add PACIASP test.
6841         (aarch64_prologue_prev_register): Unmask PC value.
6842
6843 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6844             Jiong Wang  <jiong.wang@arm.com>
6845
6846         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6847         (aarch64_dwarf2_prev_register): Unmask PC value.
6848         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6849         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6850         DW_CFA_AARCH64_negate_ra_state.
6851         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6852
6853 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6854             Jiong Wang  <jiong.wang@arm.com>
6855
6856         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6857         registers.
6858         (aarch64_pseudo_register_name): Likewise.
6859         (aarch64_pseudo_register_type): Likewise.
6860         (aarch64_pseudo_register_reggroup_p): Likewise.
6861         (aarch64_gdbarch_init): Add pauth registers.
6862         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6863         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6864         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6865         (struct gdbarch_tdep): Add regnum for ra_state.
6866
6867 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6868             Jiong Wang  <jiong.wang@arm.com>
6869
6870         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6871
6872 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6873             Jiong Wang  <jiong.wang@arm.com>
6874
6875         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6876         function.
6877         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6878         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6879         (aarch64_gdbarch_init): Add puth registers.
6880         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6881         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6882         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6883
6884 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6885             Jiong Wang  <jiong.wang@arm.com>
6886
6887         * aarch64-linux-nat.c
6888         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6889         * aarch64-linux-tdep.c
6890         (aarch64_linux_core_read_description): Likewise.
6891         (aarch64_linux_get_hwcap): New function.
6892         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6893         (aarch64_linux_get_hwcap): New declaration.
6894
6895 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6896             Jiong Wang  <jiong.wang@arm.com>
6897
6898         * aarch64-linux-nat.c
6899         (aarch64_linux_nat_target::read_description): Add pauth param.
6900         * aarch64-linux-tdep.c
6901         (aarch64_linux_core_read_description): Likewise.
6902         * aarch64-tdep.c (struct target_desc): Add in pauth.
6903         (aarch64_read_description): Add pauth param.
6904         (aarch64_gdbarch_init): Likewise.
6905         * aarch64-tdep.h (aarch64_read_description): Likewise.
6906         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6907         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6908         * features/Makefile: Add new files.
6909         * features/aarch64-pauth.c: New file.
6910         * features/aarch64-pauth.xml: New file.
6911
6912 2019-03-20  Tom Tromey  <tromey@adacore.com>
6913
6914         * infrun.c (handle_inferior_event): Rename from
6915         handle_inferior_event_1.  Create a scoped_value_mark.
6916         (handle_inferior_event): Remove.
6917
6918 2019-03-19  Tom Tromey  <tromey@adacore.com>
6919
6920         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6921         * infrun.h (print_stop_event): Add "displays" parameter.
6922         * infrun.c (print_stop_event): Add "displays" parameter.
6923
6924 2019-03-19  Pedro Alves  <palves@redhat.com>
6925
6926         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6927         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6928         to -1.  Fix TABs vs spaces.
6929         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6930         * tui/tui-out.h (tui_ui_out) Add intro comments.
6931         <m_line, m_start_of_line>: In-class initialize, and add describing
6932         comment.
6933
6934 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6935
6936         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6937         variable names.
6938         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6939
6940 2019-03-18  Pedro Alves  <palves@redhat.com>
6941             Eli Zaretskii <eliz@gnu.org>
6942
6943         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6944         m_line and m_start_of_line.
6945
6946 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6947
6948         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6949         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6950         it returns a newline.  This fixes a regression in TU mode, whereby
6951         the next line is output on the same screen line as the user input.
6952
6953 2019-03-18  Tom Tromey  <tromey@adacore.com>
6954
6955         * minsyms.c (minimal_symbol_reader::install): Remove call to
6956         obstack_blank.
6957
6958 2019-03-18  Pedro Alves  <palves@redhat.com>
6959
6960         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6961         New globals.
6962         (apply_style): New, factored out from ...
6963         (apply_ansi_escape): ... this.  Handle reverse video mode.
6964         (tui_set_reverse_mode): New function.
6965         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6966         * tui/tui-winsource.c (tui_show_source_line): Use
6967         tui_set_reverse_mode instead of setting A_STANDOUT.
6968         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6969         New setter methods.
6970
6971 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6972
6973         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6974         Handle tabs.
6975
6976 2019-03-18  Tom Tromey  <tromey@adacore.com>
6977
6978         * ada-lang.c (empty_array): Add "high" parameter.
6979         (ada_evaluate_subexp): Update.
6980
6981 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6982
6983         * unittests/string_view-selftests.c: Define
6984         _initialize_string_view_selftests unconditionally.
6985
6986 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6987
6988         PR gdb/24350
6989         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6990
6991 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6992
6993         PR gdb/24351
6994         * windows-nat.c (display_selector): Fix format specifiers.
6995
6996 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6997
6998         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6999         tui_refill_source_window instead of tui_refresh_win, to update the
7000         current execution line.  This fixes redisplay of the current line
7001         when stepping through the code with "next" or "step".
7002
7003 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7004
7005         * source-cache.c (source_cache::get_source_lines): Call
7006         find_source_lines to initialize s->nlines.  This fixes vertical
7007         scrolling of TUI source window when the DOWN arrow is pressed.
7008
7009 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7010
7011         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
7012         linux-thread-db.c (_initialize_thread_db): Likewise.
7013
7014 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7015
7016         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
7017         wclrtoeol in tui_show_source_line".  This reverts changes made in
7018         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
7019
7020 2019-03-15  Tom Tromey  <tom@tromey.com>
7021
7022         * symtab.h (struct minimal_symbol): Derive from
7023         general_symbol_info.
7024         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
7025         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
7026         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
7027         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
7028         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
7029         (MSYMBOL_SEARCH_NAME): Update.
7030         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
7031         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
7032         * minsyms.c (minimal_symbol_reader::record_full): Update.
7033
7034 2019-03-15  Tom Tromey  <tom@tromey.com>
7035
7036         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
7037
7038 2019-03-15  Tom Tromey  <tom@tromey.com>
7039
7040         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
7041         unique_xmalloc_ptr.
7042         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
7043         Update.
7044         * minsyms.c (lookup_minimal_symbol_by_pc_section)
7045         (build_minimal_symbol_hash_tables)
7046         (minimal_symbol_reader::install): Update.
7047
7048 2019-03-15  Tom Tromey  <tom@tromey.com>
7049
7050         * symtab.c (create_demangled_names_hash): Update.
7051         (symbol_set_names): Update.
7052         * objfiles.h (struct objfile_per_bfd_storage)
7053         <demangled_names_hash>: Now an htab_up.
7054         * objfiles.c (objfile_per_bfd_storage): Simplify.
7055
7056 2019-03-15  Tom Tromey  <tom@tromey.com>
7057
7058         * objfiles.h (struct objfile_per_bfd_storage): Declare
7059         destructor.
7060         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
7061         New.
7062         (get_objfile_bfd_data): Use new.  Don't initialize
7063         language_of_main.
7064         (free_objfile_per_bfd_storage): Remove.
7065         (objfile_bfd_data_free, objfile::~objfile): Use delete.
7066
7067 2019-03-15  Tom Tromey  <tom@tromey.com>
7068
7069         * symfile.c (reread_symbols): Update.
7070         * objfiles.c (objfile::objfile): Update.
7071         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
7072         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7073         comment.
7074         (minimal_symbol_reader::install): Update.
7075         (terminate_minimal_symbol_table): Remove.
7076         * jit.c (jit_object_close_impl): Update.
7077
7078 2019-03-15  Tom Tromey  <tom@tromey.com>
7079
7080         * minsyms.c (minimal_symbol_reader::record_full): Remove some
7081         initializations.
7082
7083 2019-03-15  Tom Tromey  <tom@tromey.com>
7084
7085         * objfiles.h (struct objfile_per_bfd_storage)
7086         <demangled_hash_languages>: Now a bitset.
7087         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7088         (lookup_minimal_symbol): Update.
7089
7090 2019-03-15  Tom Tromey  <tom@tromey.com>
7091
7092         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7093         Don't return the symbol.
7094         * coffread.c (record_minimal_symbol): Use record_full.
7095
7096 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
7097
7098         The MS-Windows port of ncurses fails to switch to a color pair if
7099         one or both of the colors are the implicit default colors.  This
7100         change records the default colors when TUI is initialized, and
7101         then specifies them explicitly when a color pair uses the default
7102         colors.  This allows color styling in TUI mode on MS-Windows.
7103
7104         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
7105         ncurses_norm_attr.
7106         (tui_initialize_io) [__MINGW32__]: Record the default terminal
7107         colors in ncurses_norm_attr.
7108         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7109         "none", replace it with the default color recorded in
7110         ncurses_norm_attr.
7111
7112 2019-03-14  Tom Tromey  <tromey@adacore.com>
7113
7114         * source-cache.h (class source_cache) <get_source_lines>: Return
7115         std::string.
7116         * source-cache.c (source_cache::extract_lines): Handle case where
7117         first_pos==npos.  Return std::string.
7118         (source_cache::get_source_lines): Update.
7119
7120 2019-03-14  Tom Tromey  <tromey@adacore.com>
7121
7122         * NEWS: Add item for "style sources" commands.
7123         * source-cache.c (source_cache::get_source_lines): Check
7124         source_styling.
7125         * cli/cli-style.c (source_styling): New global.
7126         (_initialize_cli_style): Add "style sources" commands.
7127         (show_style_sources): New function.
7128         * cli/cli-style.h (source_styling): Declare.
7129
7130 2019-03-14  Pedro Alves  <palves@redhat.com>
7131             Tom Tromey  <tromey@adacore.com>
7132
7133         * tui/tui-winsource.h (tui_refill_source_window): Declare.
7134         * tui/tui-winsource.c (tui_refill_source_window): New function,
7135         from...
7136         (tui_horizontal_source_scroll): ... here.  Move some logic.
7137         * cli/cli-style.c (set_style_enabled): Notify new observable.
7138         * tui/tui-hooks.c (tui_redisplay_source): New function.
7139         (tui_attach_detach_observers): Attach or detach
7140         tui_redisplay_source.
7141         * observable.h (source_styling_changed): New observable.
7142         * observable.c: Define source_styling_changed observable.
7143
7144 2019-03-13  Tom Tromey  <tromey@adacore.com>
7145
7146         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7147         (i386_gnu_nat_target::store_registers): Update.
7148         * target-debug.h (target_debug_print_std_string): New macro.
7149         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7150         * windows-tdep.c (display_one_tib): Update.
7151         * tui/tui-stack.c (tui_make_status_line): Update.
7152         * top.c (print_inferior_quit_action): Update.
7153         * thread.c (thr_try_catch_cmd): Update.
7154         (add_thread_with_info): Update.
7155         (thread_target_id_str): Update.
7156         (thr_try_catch_cmd): Update.
7157         (thread_command): Update.
7158         (thread_find_command): Update.
7159         * record-btrace.c (record_btrace_target::info_record)
7160         (record_btrace_resume_thread, record_btrace_target::resume)
7161         (record_btrace_cancel_resume, record_btrace_step_thread)
7162         (record_btrace_target::wait, record_btrace_target::wait)
7163         (record_btrace_target::wait, record_btrace_target::stop): Update.
7164         * progspace.c (print_program_space): Update.
7165         * process-stratum-target.c
7166         (process_stratum_target::thread_address_space): Update.
7167         * linux-fork.c (linux_fork_mourn_inferior)
7168         (detach_checkpoint_command, info_checkpoints_command)
7169         (linux_fork_context): Update.
7170         (linux_fork_detach): Update.
7171         (class scoped_switch_fork_info): Update.
7172         (delete_checkpoint_command): Update.
7173         * infrun.c (follow_fork_inferior): Update.
7174         (follow_fork_inferior): Update.
7175         (proceed_after_vfork_done): Update.
7176         (handle_vfork_child_exec_or_exit): Update.
7177         (follow_exec): Update.
7178         (displaced_step_prepare_throw): Update.
7179         (displaced_step_restore): Update.
7180         (start_step_over): Update.
7181         (resume_1): Update.
7182         (clear_proceed_status_thread): Update.
7183         (proceed): Update.
7184         (print_target_wait_results): Update.
7185         (do_target_wait): Update.
7186         (context_switch): Update.
7187         (stop_all_threads): Update.
7188         (restart_threads): Update.
7189         (finish_step_over): Update.
7190         (handle_signal_stop): Update.
7191         (switch_back_to_stepped_thread): Update.
7192         (keep_going_pass_signal): Update.
7193         (print_exited_reason): Update.
7194         (normal_stop): Update.
7195         * inferior.c (inferior_pid_to_str): Change return type.
7196         (print_selected_inferior): Update.
7197         (add_inferior): Update.
7198         (detach_inferior): Update.
7199         * dummy-frame.c (fprint_dummy_frames): Update.
7200         * dcache.c (dcache_info_1): Update.
7201         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7202         (btrace_fetch, btrace_clear): Update.
7203         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7204         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7205         type.
7206         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7207         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7208         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7209         * gdbarch.c, gdbarch.h: Rebuild.
7210         * gdbarch.sh (core_pid_to_str): Change return type.
7211         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7212         return type.
7213         (windows_nat_target::pid_to_str): Change return type.
7214         (windows_delete_thread): Update.
7215         (windows_nat_target::attach): Update.
7216         (windows_nat_target::files_info): Update.
7217         * target-delegates.c: Rebuild.
7218         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7219         return type.
7220         (sol_thread_target::pid_to_str): Change return type.
7221         * remote.c (class remote_target) <pid_to_str>: Change return
7222         type.
7223         (remote_target::pid_to_str): Change return type.
7224         (extended_remote_target::attach, remote_target::remote_stop_ns)
7225         (remote_target::remote_notif_remove_queued_reply)
7226         (remote_target::push_stop_reply, remote_target::disable_btrace):
7227         Update.
7228         (extended_remote_target::attach): Update.
7229         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7230         type.
7231         (gdbsim_target::pid_to_str): Change return type.
7232         * ravenscar-thread.c (struct ravenscar_thread_target)
7233         <pid_to_str>: Change return type.
7234         (ravenscar_thread_target::pid_to_str): Change return type.
7235         * procfs.c (class procfs_target) <pid_to_str>: Change return
7236         type.
7237         (procfs_target::pid_to_str): Change return type.
7238         (procfs_target::attach): Update.
7239         (procfs_target::detach): Update.
7240         (procfs_target::fetch_registers): Update.
7241         (procfs_target::store_registers): Update.
7242         (procfs_target::wait): Update.
7243         (procfs_target::files_info): Update.
7244         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7245         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7246         return type.
7247         (nto_procfs_target::pid_to_str): Change return type.
7248         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7249         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7250         return type.
7251         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7252         (exit_lwp): Update.
7253         (attach_proc_task_lwp_callback, get_detach_signal)
7254         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7255         (linux_nat_target::resume, wait_lwp, stop_callback)
7256         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7257         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7258         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7259         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7260         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7261         type.
7262         (inf_ptrace_target::attach): Update.
7263         (inf_ptrace_target::files_info): Update.
7264         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7265         type.
7266         (go32_nat_target::pid_to_str): Change return type.
7267         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7268         (gnu_nat_target::wait): Update.
7269         (gnu_nat_target::wait): Update.
7270         (gnu_nat_target::resume): Update.
7271         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7272         (fbsd_nat_target::wait): Update.
7273         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7274         type.
7275         (darwin_nat_target::attach): Update.
7276         * corelow.c (class core_target) <pid_to_str>: Change return type.
7277         (core_target::pid_to_str): Change return type.
7278         * target.c (normal_pid_to_str): Change return type.
7279         (default_pid_to_str): Likewise.
7280         (target_pid_to_str): Change return type.
7281         (target_translate_tls_address): Update.
7282         (target_announce_detach): Update.
7283         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7284         return type.
7285         (bsd_uthread_target::pid_to_str): Change return type.
7286         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7287         type.
7288         (bsd_kvm_target::pid_to_str): Change return type.
7289         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7290         return type.
7291         (aix_thread_target::pid_to_str): Change return type.
7292         * target.h (struct target_ops) <pid_to_str>: Change return type.
7293         (target_pid_to_str, normal_pid_to_str): Likewise.
7294         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7295         type.
7296         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7297         type.
7298         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7299         return type.
7300         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7301         type.
7302         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7303         type.
7304         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7305         return type.
7306
7307 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7308
7309         * NEWS: Mention that the new default MI version is 3.  Mention
7310         changes to the output of commands and events that deal with
7311         multi-location breakpoints.
7312         * breakpoint.c: Include "mi/mi-out.h".
7313         (print_one_breakpoint): Change output syntax if using MI version
7314         >= 3.
7315         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7316         New.
7317         (mi_multi_location_breakpoint_output_fixed): New.
7318         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7319         (mi_cmd_fix_multi_location_breakpoint_output): New.
7320         (mi_multi_location_breakpoint_output_fixed): New.
7321         * mi/mi-cmds.c (mi_cmds): Register command
7322         -fix-multi-location-breakpoint-output.
7323         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7324         interpreter "mi".
7325
7326 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7327
7328         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7329         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7330         instantiate mi_ui_out based on interpreter name.
7331         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7332         * mi/mi-main.c (mi_load_progress): Likewise.
7333
7334 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7335
7336         * NEWS: Combine separate "New targets" sections for 8.3.
7337
7338 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7339
7340         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7341         (ppcfbsd_init_abi): Install gdbarch
7342         "fetch_tls_load_module_address" and "get_thread_local_address"
7343         methods.
7344
7345 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7346
7347         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7348         (riscv_fbsd_init_abi): Install gdbarch
7349         "fetch_tls_load_module_address" and "get_thread_local_address"
7350         methods.
7351
7352 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7353
7354         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7355         (i386fbsd_init_abi): Install gdbarch
7356         "fetch_tls_load_module_address" and "get_thread_local_address"
7357         methods.
7358
7359 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7360
7361         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7362         (amd64fbsd_init_abi): Install gdbarch
7363         "fetch_tls_load_module_address" and "get_thread_local_address"
7364         methods.
7365
7366 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7367
7368         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7369         (struct fbsd_pspace_data): New type.
7370         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7371         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7372         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7373         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7374         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7375
7376 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7377
7378         * gdbtypes.c (lookup_struct_elt): New function.
7379         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7380         * gdbtypes.h (struct struct_elt): New type.
7381         (lookup_struct_elt): New prototype.
7382
7383 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7384
7385         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7386         remove disabled code block.
7387
7388 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7389
7390         * gdbarch.sh (get_thread_local_address): New method.
7391         * gdbarch.h, gdbarch.c: Regenerate.
7392         * target.c (target_translate_tls_address): Use
7393         gdbarch_get_thread_local_address if present instead of
7394         target::get_thread_local_address.
7395
7396 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7397
7398         * target.h (target::get_thread_local_address): Update comment.
7399
7400 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7401
7402         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7403         objfile->separate_debug_objfile_backlink if not NULL.
7404
7405 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7406
7407         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7408         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7409         (amd64bsd_store_inferior_registers): Likewise.
7410         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7411         Enable segment base registers.
7412         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7413         PT_GETFSBASE and PT_GETGSBASE.
7414         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7415         PT_SETGSBASE.
7416         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7417         segment base registers.
7418         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7419
7420 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7421
7422         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7423         Update calls to i386_target_description to add 'segments'
7424         parameter.
7425         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7426         add segment base registers.
7427         * arch/i386.c (i386_create_target_description): Add 'segments'
7428         parameter to enable segment base registers.
7429         * arch/i386.h (i386_create_target_description): Likewise.
7430         * features/i386/32bit-segments.xml: New file.
7431         * features/i386/32bit-segments.c: Generate.
7432         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7433         call to i386_target_description to add 'segments' parameter.
7434         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7435         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7436         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7437         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7438         if feature is present.
7439         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7440         Add 'segments' parameter to call to i386_target_description.
7441         (i386_target_description): Add 'segments' parameter to enable
7442         segment base registers.
7443         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7444         to call to i386_target_description.
7445         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7446         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7447         Define I386_NUM_REGS.
7448         (i386_target_description): Add 'segments' parameter to enable
7449         segment base registers.
7450
7451 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7452
7453         PR/24325
7454         * source-cache.c: #undef open and close, to avoid unresolved
7455         externals during linking.
7456
7457 2019-03-12  Tom Tromey  <tromey@adacore.com>
7458
7459         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7460         const.  Add initializers.
7461         (_initialize_remote): Don't initialize ptid globals.
7462
7463 2019-03-12  Pedro Alves  <palves@redhat.com>
7464
7465         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7466
7467 2019-03-12  Pedro Alves  <palves@redhat.com>
7468
7469         * cp-name-parser.y (main): Remove unused 'len' variable.
7470
7471 2019-03-12  Tom Tromey  <tromey@adacore.com>
7472
7473         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7474         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7475
7476 2019-03-12  Tom Tromey  <tromey@adacore.com>
7477
7478         * linux-nat.c (iterate_over_lwps): Update.
7479         (stop_callback): Remove parameter.
7480         (stop_wait_callback, detach_callback, resume_set_callback)
7481         (select_singlestep_lwp_callback, set_ignore_sigint)
7482         (status_callback, resumed_callback, resume_clear_callback)
7483         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7484         data parameter.
7485         (linux_nat_target::detach, linux_nat_target::resume)
7486         (linux_stop_and_wait_all_lwps, select_event_lwp)
7487         (linux_nat_filter_event, linux_nat_wait_1)
7488         (linux_nat_target::kill, linux_nat_target::stop)
7489         (linux_nat_target::stop): Update.
7490         (linux_nat_resume_callback): Change type.
7491         (resume_stopped_resumed_lwps, count_events_callback)
7492         (select_event_lwp_callback): Likewise.
7493         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7494         * arm-linux-nat.c (struct update_registers_data): Remove.
7495         (update_registers_callback): Change type.
7496         (arm_linux_insert_hw_breakpoint1): Update.
7497         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7498         parameter.
7499         (x86_linux_dr_set_addr): Update.
7500         (x86_linux_dr_set_control): Update.
7501         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7502         (iterate_over_lwps): Use gdb::function_view.
7503         * nat/aarch64-linux-hw-point.c (struct
7504         aarch64_dr_update_callback_param): Remove.
7505         (debug_reg_change_callback): Change type.
7506         (aarch64_notify_debug_reg_change): Update.
7507         * s390-linux-nat.c (s390_refresh_per_info): Update.
7508
7509 2019-03-11  Tom Tromey  <tromey@adacore.com>
7510
7511         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7512         redundant assignment to "this_cu".
7513
7514 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7515
7516         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7517
7518 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7519
7520         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7521         from...
7522         (rank_one_type): ... this.
7523
7524 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7525
7526         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7527         from...
7528         (rank_one_type): ... this.
7529
7530 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7531
7532         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7533         from...
7534         (rank_one_type): ... this.
7535
7536 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7537
7538         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7539         from...
7540         (rank_one_type): ... this.
7541
7542 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7543
7544         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7545         from...
7546         (rank_one_type): ... this.
7547
7548 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7549
7550         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7551         from...
7552         (rank_one_type): ... this.
7553
7554 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7555
7556         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7557         from...
7558         (rank_one_type): ... this.
7559
7560 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7561
7562         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7563         from...
7564         (rank_one_type): ... this.
7565
7566 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7567
7568         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7569         from...
7570         (rank_one_type): ... this.
7571
7572 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7573
7574         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7575         from...
7576         (rank_one_type): ... this.
7577
7578 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7579
7580         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7581         from...
7582         (rank_one_type): ... this.
7583
7584 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7585
7586         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7587         from...
7588         (rank_one_type): ... this.
7589
7590 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7591
7592         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7593         inferior-events' shows the example events.
7594
7595 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7596
7597         Support styling on native MS-Windows console
7598
7599         PR/24315
7600         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7601         on MS-Windows if $TERM is not defined.
7602
7603         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7604
7605         * posix-hdep.c (gdb_console_fputs):
7606         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7607         functions.
7608         * ui-file.h (gdb_console_fputs): Add prototype.
7609
7610         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7611         back to fputs only if the former returns zero.
7612
7613 2019-03-07  Tom Tromey  <tom@tromey.com>
7614
7615         * symmisc.c (print_symbol_bcache_statistics): Update.
7616         (print_objfile_statistics): Update.
7617         * symfile.c (allocate_symtab): Update.
7618         * stabsread.c: Don't include bcache.h.
7619         * psymtab.h (struct psymbol_bcache): Don't declare.
7620         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7621         (psymbol_bcache_init, psymbol_bcache_free)
7622         (psymbol_bcache_get_bcache): Don't declare.
7623         * psymtab.c (struct psymbol_bcache): Remove.
7624         (psymtab_storage::psymtab_storage): Update.
7625         (psymtab_storage::~psymtab_storage): Update.
7626         (psymbol_bcache_init, psymbol_bcache_free)
7627         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7628         (add_psymbol_to_bcache): Update.
7629         (allocate_psymtab): Update.
7630         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7631         macro_cache>: No longer pointers.
7632         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7633         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7634         * macrotab.c (macro_bcache): Update.
7635         * macroexp.c: Don't include bcache.h.
7636         * gdbtypes.c (check_types_worklist): Update.
7637         (types_deeply_equal): Remove TRY/CATCH.  Update.
7638         * elfread.c (elf_symtab_read): Update.
7639         * dwarf2read.c: Don't include bcache.h.
7640         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7641         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7642         (print_bcache_statistics, bcache_memory_used): Don't declare.
7643         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7644         methods.  Rename all data members.
7645         * bcache.c (struct bcache): Move to bcache.h.
7646         (bcache::expand_hash_table): Rename from expand_hash_table.
7647         (bcache): Remove.
7648         (bcache::insert): Rename from bcache_full.
7649         (bcache::compare): Rename from bcache_compare.
7650         (bcache_xmalloc): Remove.
7651         (bcache::~bcache): Rename from bcache_xfree.
7652         (bcache::print_statistics): Rename from print_bcache_statistics.
7653         (bcache::memory_used): Rename from bcache_memory_used.
7654
7655 2019-03-07  Pedro Alves  <palves@redhat.com>
7656
7657         * infrun.c (normal_stop): Also check for
7658         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7659
7660 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7661
7662         * f-lang.c (value_from_host_double): Moved to...
7663         * value.c (value_from_host_double): ...here.
7664         * value.h (value_from_host_double): Declare.
7665         * guile/scm-math.c (vlscm_convert_typed_number): Use
7666         value_from_host_double.
7667         (vlscm_convert_number): Likewise.
7668         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7669         * python/py-value.c (convert_value_from_python): Likewise.
7670
7671 2019-03-06  Tom Tromey  <tom@tromey.com>
7672
7673         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7674
7675 2019-03-06  Tom Tromey  <tom@tromey.com>
7676
7677         * utils.h (free_current_contents): Don't declare.
7678         * utils.c (free_current_contents): Remove.
7679
7680 2019-03-06  Tom Tromey  <tom@tromey.com>
7681
7682         * top.c (quit_force): Update.
7683         * main.c (captured_command_loop): Update.
7684         * common/new-op.c (operator new): Update.
7685         * common/common-exceptions.c (struct catcher)
7686         <save_cleanup_chain>: Remove member.
7687         (exceptions_state_mc_init): Update.
7688         (exception_try_scope_entry): Return nullptr.
7689         (exception_try_scope_exit, exception_rethrow)
7690         (throw_exception_sjlj, throw_exception_cxx): Update.
7691         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7692         (all_cleanups, do_cleanups, discard_cleanups)
7693         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7694         (restore_cleanups, restore_final_cleanups): Don't declare.
7695         (do_final_cleanups): Remove parameter.
7696         * common/cleanups.c (cleanup_chain, make_cleanup)
7697         (make_cleanup_dtor, all_cleanups, do_cleanups)
7698         (discard_my_cleanups, discard_cleanups)
7699         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7700         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7701         (null_cleanup): Remove.
7702         (do_final_cleanups): Remove parameter.
7703
7704 2019-03-06  Tom Tromey  <tom@tromey.com>
7705
7706         * remote.c (remote_target::remote_parse_stop_reply): Use
7707         unique_xmalloc_ptr.
7708
7709 2019-03-06  Tom Tromey  <tom@tromey.com>
7710
7711         * stabsread.c (struct stabs_field_info): Rename from field_info.
7712         <list, fnlist>: Add initializers.
7713         <obstack>: New member.
7714         (read_member_functions, read_struct_fields, read_baseclasses):
7715         Allocate on obstack.  Don't use cleanups.
7716         (read_one_struct_field, read_member_functions, read_struct_fields)
7717         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7718         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7719         (read_struct_type): Update.
7720
7721 2019-03-06  Tom Tromey  <tom@tromey.com>
7722
7723         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7724         * common/filestuff.h (make_cleanup_close): Don't declare.
7725         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7726         Remove.
7727
7728 2019-03-06  Tom Tromey  <tom@tromey.com>
7729
7730         * solib-aix.c: Use make_scope_exit.
7731
7732 2019-03-06  Tom Tromey  <tom@tromey.com>
7733
7734         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7735         Use make_scope_exit.
7736
7737 2019-03-06  Tom Tromey  <tom@tromey.com>
7738
7739         * solib-svr4.c (disable_probes_interface): Remove parameter.
7740         (svr4_handle_solib_event): Use make_scope_exit.
7741
7742 2019-03-06  Tom Tromey  <tom@tromey.com>
7743
7744         * remote.c (struct stop_reply_deleter): Remove.
7745         (stop_reply_up): Update.
7746         (struct stop_reply): Derive from notif_event.  Don't typedef.
7747         <regcache>: Now a std::vector.
7748         (stop_reply_xfree): Remove.
7749         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7750         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7751         (remote_target::discard_pending_stop_replies): Use delete.
7752         (remote_target::remote_parse_stop_reply): Update.
7753         (remote_target::process_stop_reply): Update.
7754         * remote-notif.h (struct notif_event): Add virtual destructor.
7755         Remove "dtr" member.
7756         (struct notif_client) <alloc_event>: Return a unique_ptr.
7757         (notif_event_xfree): Don't declare.
7758         (notif_event_up): New typedef.
7759         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7760         (notif_event_xfree, do_notif_event_xfree): Remove.
7761         (remote_notif_state_xfree): Update.
7762
7763 2019-03-06  Tom Tromey  <tom@tromey.com>
7764
7765         * infrun.c (displaced_step_clear_cleanup): Now a
7766         forward_scope_exit type.
7767         (displaced_step_prepare_throw): Update.
7768         (displaced_step_fixup): Update.
7769
7770 2019-03-06  Tom Tromey  <tom@tromey.com>
7771
7772         * inferior.h (class inferior): Update comment.
7773         * gdbthread.h (class thread_info): Update comment.
7774
7775 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7776             Tom Tromey  <tom@tromey.com>
7777
7778         * stabsread.h (struct stab_section_list): Remove.
7779         (coffstab_build_psymtabs): Update.
7780         * dbxread.c (symbuf_sections): Now a std::vector.
7781         (sect_idx): New global.
7782         (fill_symbuf): Update.
7783         (coffstab_build_psymtabs): Change type of stabsects parameter.
7784         Update.
7785         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7786         std::vector.
7787         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7788         (coff_locate_sections): Update.
7789         (coff_symfile_read): Remove cleanups.  Update.
7790         (init_stringtab): Add storage parameter.
7791         (free_stringtab, free_stringtab_cleanup): Remove.
7792         (init_lineno): Add storage parameter.
7793         (free_linetab, free_linetab_cleanup): Remove.
7794
7795 2019-03-06  Pedro Alves  <palves@redhat.com>
7796
7797         * linux-fork.c (fork_info::clobber_regs): Delete.
7798         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7799         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7800         comment.  Adjust.
7801         (scoped_switch_fork_info::scoped_switch_fork_info)
7802         (checkpoint_command, linux_fork_context): Adjust
7803         fork_save_infrun_state calls.
7804
7805 2019-03-06  Pedro Alves  <palves@redhat.com>
7806
7807         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7808         (inf_has_multiple_threads): Return 'bool' and rewrite using
7809         inferior_info::threads().
7810
7811 2019-03-06  Pedro Alves  <palves@redhat.com>
7812
7813         * linux-fork.c: Include <list>.
7814         (fork_list): Now a std::list instance.
7815         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7816         (forks_exist_p, find_last_fork): Adjust.
7817         (new_fork): Delete.
7818         (one_fork_p): New.
7819         (add_fork): Adjust.
7820         (free_fork): Delete, folded into fork_info::~fork_info().
7821         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7822         Adjust.
7823         (init_fork_list): Delete.
7824         (linux_fork_killall, linux_fork_mourn_inferior)
7825         (linux_fork_detach, info_checkpoints_command): Adjust.
7826         (_initialize_linux_fork): No longer call init_fork_list.
7827
7828 2019-03-06  Pedro Alves  <palves@redhat.com>
7829
7830         * linux-fork.c (new_fork): New, split out of ...
7831         (add_fork): ... this.  Return void.  Move "first fork" special
7832         case from here, to ...
7833         (checkpoint_command): ... here.
7834         * linux-linux.h (add_fork): Return void.
7835
7836 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7837
7838         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7839
7840 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7841             Chris January  <chris.january@arm.com>
7842             David Lecomber  <david.lecomber@arm.com>
7843
7844         * f-exp.y: New token, UNOP_INTRINSIC.
7845         (exp): New pattern using UNOP_INTRINSIC token.
7846         (f77_keywords): Add 'abs' keyword.
7847         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7848         (value_from_host_double): New function.
7849         (evaluate_subexp_f): Support UNOP_ABS.
7850
7851 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7852
7853         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7854         types.
7855
7856 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7857
7858         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7859         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7860         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7861
7862 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7863
7864         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7865
7866 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7867             Chris January  <chris.january@arm.com>
7868
7869         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7870         * f-exp.y: Define 'KIND' token.
7871         (exp): New pattern for KIND expressions.
7872         (ptype): Handle types with a kind extension.
7873         (direct_abs_decl): Extend to spot kind extensions.
7874         (f77_keywords): Add 'kind' to the list.
7875         (push_kind_type): New function.
7876         (convert_to_kind_type): New function.
7877         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7878         * parse.c (operator_length_standard): Likewise.
7879         * parser-defs.h (enum type_pieces): Add tp_kind.
7880         * std-operator.def: Add UNOP_KIND.
7881
7882 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7883
7884         * f-exp.y (f_parse): Set yydebug.
7885
7886 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7887
7888         * f-lang.c (evaluate_subexp_f): New function.
7889         (exp_descriptor_f): New global.
7890         (f_language_defn): Use exp_descriptor_f instead of
7891         exp_descriptor_standard.
7892
7893 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7894
7895         * f-exp.y (struct token): Add comments.
7896         (dot_ops): Remove uppercase versions and the end marker.
7897         (f77_keywords): Likewise.
7898         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7899         entries in the dot_ops array are case insensitive, and use
7900         strncasecmp to compare strings.  Also some whitespace cleanup in
7901         this area.  Similar for the f77_keywords array, except entries in
7902         this list might be case sensitive.
7903
7904 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7905
7906         * f-exp.y (struct f77_boolean_val): Add comments.
7907         (boolean_values): Remove uppercase versions, and end marker.
7908         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7909         and use strncasecmp to achieve case insensitivity.  Additionally,
7910         perform whitespace cleanup around this code.
7911
7912 2019-03-06  Tom Tromey  <tromey@adacore.com>
7913
7914         * remote-sim.c (gdbsim_target_open): Use result of
7915         gdb_argv::release.
7916
7917 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7918         Dirk Schubert  <dirk.schubert@arm.com>
7919         Chris January  <chris.january@arm.com>
7920
7921         * eval.c (evaluate_subexp_standard): Call Fortran argument
7922         wrapping logic.
7923         * f-lang.c (struct value): A value which can be passed into a
7924         Fortran function call.
7925         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7926         where appropriate.
7927         (struct type): Value ready for a Fortran function call.
7928         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7929         is needed.
7930         * f-lang.h (fortran_argument_convert): Declaration.
7931         (fortran_preserve_arg_pointer): Declaration.
7932         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7933
7934 2019-03-05  Tom Tromey  <tromey@adacore.com>
7935
7936         * python/py-prettyprint.c (print_string_repr): Remove #if.
7937         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7938
7939 2019-03-05  Tom Tromey  <tromey@adacore.com>
7940
7941         * target.c (the_dummy_target): Move later.  Change type to
7942         "dummy_target".
7943         (initialize_targets): Don't initialize the_dummy_target.
7944
7945 2019-03-05  Tom Tromey  <tromey@adacore.com>
7946
7947         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7948         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7949
7950 2019-03-05  Tom Tromey  <tromey@adacore.com>
7951
7952         * windows-nat.c (windows_nat_target::attach)
7953         (windows_nat_target::detach): Don't call gdb_flush.
7954         * valprint.c (generic_val_print, val_print, val_print_string):
7955         Don't call gdb_flush.
7956         * utils.c (defaulted_query): Don't call gdb_flush.
7957         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7958         * target.c (target_announce_detach): Don't call gdb_flush.
7959         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7960         * remote.c (extended_remote_target::attach): Don't call
7961         gdb_flush.
7962         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7963         * printcmd.c (do_examine): Don't call gdb_flush.
7964         (info_display_command): Don't call gdb_flush.
7965         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7966         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7967         * memattr.c (info_mem_command): Don't call gdb_flush.
7968         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7969         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7970         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7971         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7972         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7973         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7974         (gnu_nat_target::detach): Don't call gdb_flush.
7975         * f-valprint.c (f_val_print): Don't call gdb_flush.
7976         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7977         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7978         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7979         gdb_flush.
7980         * c-valprint.c (c_val_print): Don't call gdb_flush.
7981         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7982
7983 2019-03-05  Tom Tromey  <tromey@adacore.com>
7984
7985         * varobj.c (update_dynamic_varobj_children): Update.
7986         (install_default_visualizer): Use reset, not release.
7987         * value.c (set_internalvar): Update.
7988         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7989         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7990         ATTRIBUTE_UNUSED_RESULT.
7991
7992 2019-03-05  Tom Tromey  <tromey@adacore.com>
7993
7994         * remote.c (class scoped_remote_fd) <release>: Add
7995         ATTRIBUTE_UNUSED_RESULT.
7996
7997 2019-03-05  Tom Tromey  <tromey@adacore.com>
7998
7999         * macroexp.c (struct macro_buffer) <release>: Add
8000         ATTRIBUTE_UNUSED_RESULT.
8001
8002 2019-03-05  Tom Tromey  <tromey@adacore.com>
8003
8004         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
8005         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
8006         ATTRIBUTE_UNUSED_RESULT.
8007
8008 2019-03-05  Tom Tromey  <tromey@adacore.com>
8009
8010         * common/scoped_fd.h (class scoped_fd) <release>: Add
8011         ATTRIBUTE_UNUSED_RESULT.
8012
8013 2019-03-05  Tom Tromey  <tromey@adacore.com>
8014
8015         * parser-defs.h (struct parser_state) <release>: Add
8016         ATTRIBUTE_UNUSED_RESULT.
8017
8018 2019-03-05  Tom Tromey  <tromey@adacore.com>
8019
8020         * utils.h (class gdb_argv) <release>: Add
8021         ATTRIBUTE_UNUSED_RESULT.
8022         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
8023
8024 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
8025
8026         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
8027         for-loop range, to avoid compiler warnings.
8028
8029         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
8030         avoid compiler warnings about unused variables.
8031
8032         * NEWS: Mention end of support for native debugging on MS-Windows
8033         before XP.
8034
8035         PR gdb/24292
8036         * common/netstuff.c:
8037         * gdbserver/gdbreplay.c
8038         * gdbserver/remote-utils.c:
8039         * ser-tcp.c:
8040         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
8041         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
8042         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
8043         'getaddrinfo' and 'freeaddrinfo' were not available before
8044         Windows XP, and mingw.org's MinGW headers by default define
8045         _WIN32_WINNT to 0x500.
8046
8047 2019-03-01  Gary Benson <gbenson@redhat.com>
8048
8049         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
8050
8051 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
8052             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
8053
8054         PR gdb/8527
8055         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
8056         set_sigint_trap, clear_sigint_trap.
8057
8058 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8059
8060         * target.c (target_detach): Clear the regcache and the
8061         frame cache.
8062
8063 2019-02-27  Pedro Alves  <palves@redhat.com>
8064
8065         * utils.c (set_screen_size): When we cap the height/width sizes,
8066         tweak the corresponding command variable to show "unlimited":
8067
8068 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
8069             Pedro Alves  <palves@redhat.com>
8070
8071         * utils.c (set_screen_size): Reduce "infinite" rows and columns
8072         before calling rl_set_screen_size.
8073
8074 2019-02-27  Tom Tromey  <tromey@adacore.com>
8075
8076         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8077         define.
8078         * python/py-value.c: Remove Python 2.4 workaround.
8079         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8080         workaround.
8081         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8082         Python 2.4 workaround.
8083         * python/python-internal.h: Remove Python 2.4 comment.
8084         (Py_ssize_t): Don't define.
8085         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8086         (gdb_Py_DECREF): Remove Python 2.4 workaround.
8087         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8088         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8089         * python/python.c (do_start_initialization): Remove Python 2.4
8090         workaround.
8091         * python/py-prettyprint.c (class dummy_python_frame): Remove.
8092         (print_children): Remove Python 2.4 workaround.
8093         * python/py-inferior.c (buffer_procs): Remove Python 2.4
8094         workaround.
8095         (CHARBUFFERPROC_NAME): Remove.
8096         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8097         Python 2.4 workaround.
8098
8099 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8100
8101         * NEWS: Note minimum Python version.
8102
8103 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8104
8105         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8106         code from these functions.  Remove corresponding ifdefs.  Use
8107         Py_buffer_up instead of explicit calls to PyBuffer_Release.
8108         Remove gotos and target of gotos.
8109         (infpy_search_memory): Likewise.
8110
8111 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8112
8113         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8114         (hppa_gdbarch_init): Don't register deleted functions with
8115         gdbarch.
8116
8117 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8118
8119         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8120         (h8300_unwind_sp): Delete.
8121         (h8300_dummy_id): Delete.
8122         (h8300_gdbarch_init): Don't register deleted functions with
8123         gdbarch.
8124
8125 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8126
8127         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8128         (ft32_unwind_pc): Delete.
8129         (ft32_unwind_sp): Delete.
8130         (ft32_gdbarch_init): Don't register deleted functions with
8131         gdbarch.
8132
8133 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8134
8135         * gdb/frv-tdep.c (frv_dummy_id): Delete.
8136         (frv_unwind_pc): Delete.
8137         (frv_unwind_sp): Delete.
8138         (frv_gdbarch_init): Don't register deleted functions with
8139         gdbarch.
8140
8141 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8142
8143         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8144         (riscv_unwind_pc): Delete.
8145         (riscv_unwind_sp): Delete.
8146         (riscv_gdbarch_init): Don't register deleted functions with
8147         gdbarch.
8148
8149 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8150
8151         * gdb/csky-tdep.c (csky_dummy_id): Delete.
8152         (csky_unwind_pc): Delete.
8153         (csky_unwind_sp): Delete.
8154         (csky_gdbarch_init): Don't register deleted functions with
8155         gdbarch.
8156
8157 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8158
8159         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8160         (cris_unwind_pc): Delete.
8161         (cris_unwind_sp): Delete.
8162         (cris_gdbarch_init): Don't register deleted functions with
8163         gdbarch.
8164
8165 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8166
8167         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8168         (bfin_unwind_pc): Delete.
8169         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8170
8171 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8172
8173         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8174         (arm_unwind_pc): Delete.
8175         (arm_unwind_sp): Delete.
8176         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8177
8178 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8179
8180         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8181         (arc_unwind_pc): Delete.
8182         (arc_unwind_sp): Delete.
8183         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8184
8185 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8186
8187         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8188         (alpha_unwind_pc): Delete.
8189         (alpha_gdbarch_init): Don't register deleted functions with
8190         gdbarch.
8191
8192 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8193
8194         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8195         (aarch64_unwind_pc): Delete.
8196         (aarch64_unwind_sp): Delete.
8197         (aarch64_gdbarch_init): Don't register deleted functions with
8198         gdbarch.
8199
8200 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8201
8202         * gdbtypes.c (type_align): Don't consider static members when
8203         computing structure alignment.
8204
8205 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8206
8207         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8208         return 0 for other types.
8209         * arch-utils.c (default_type_align): Always return 0.
8210         * gdbarch.h: Regenerate.
8211         * gdbarch.sh (type_align): Extend comment.
8212         * gdbtypes.c (type_align): Add additional comments, always call
8213         gdbarch_type_align before applying the default rules.
8214         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8215         generic code will then apply a suitable default.
8216         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8217         types, return 0 for other types.
8218
8219 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8220
8221         * NEWS: Create a new section for the next release branch.
8222         Rename the section of the current branch, now that it has
8223         been cut.
8224
8225 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8226
8227         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8228         * version.in: Bump version to 8.3.50.DATE-git.
8229
8230 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8231
8232         * aix-thread.c (ptid_cmp): Remove unused variable.
8233         (get_signaled_thread): Likewise.
8234         (store_regs_user_thread): Likewise.
8235         (store_regs_kernel_thread): Likewise.
8236         (fetch_regs_kernel_thread): Remove shadowed variable.
8237
8238 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8239
8240         * features/riscv/32bit-cpu.xml: Add register numbers.
8241         * features/riscv/32bit-fpu.c: Regenerate.
8242         * features/riscv/32bit-fpu.xml: Add register numbers.
8243         * features/riscv/64bit-cpu.xml: Add register numbers.
8244         * features/riscv/64bit-fpu.c: Regenerate.
8245         * features/riscv/64bit-fpu.xml: Add register numbers.
8246
8247 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8248
8249         * NEWS: Mention two argument form of gdb.Value constructor.
8250         * python/py-value.c (convert_buffer_and_type_to_value): New
8251         function.
8252         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8253         Add support for handling an optional second argument.  Call
8254         convert_buffer_and_type_to_value as appropriate.
8255         * python/python-internal.h (Py_buffer_deleter): New struct.
8256         (Py_buffer_up): New typedef.
8257
8258 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8259
8260         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8261         instead of releasing ownership.
8262
8263 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8264
8265         * dwarf2read.c (open_and_init_dwp_file): Call
8266         elf_numsections instead of bfd_count_sections to initialize
8267         dwp_file->num_sections.
8268
8269 2019-02-25  Tom Tromey  <tromey@adacore.com>
8270
8271         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8272
8273 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8274
8275         * gcore.in: Add '--readnever' option when invoking GDB.
8276
8277 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8278
8279         * MAINTAINERS: Update my email address.
8280
8281 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8282
8283         * build-id.c (build_id_to_debug_bfd_1): New function.
8284         (build_id_to_debug_bfd): Look for separate debug file in
8285         sysroot.
8286
8287 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8288
8289         * gdbarch.sh: Update the copyright year range that is placed into
8290         generated files.
8291
8292 2019-02-22  Keith Seitz  <keiths@redhat.com>
8293
8294         PR symtab/23853
8295         * linespec.c (create_sals_line_offset): Search for the default
8296         symtab's filename instead of its fullname.
8297
8298 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8299
8300         * NEWS: Update style defaults.
8301
8302 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8303
8304         * main.c (captured_main_1): Disable styling in batch mode.
8305
8306 2019-02-20  Tom Tromey  <tom@tromey.com>
8307
8308         * symtab.c (symtab_symbol_info): Fix typos.
8309
8310 2019-02-20  Tom Tromey  <tromey@adacore.com>
8311
8312         * findcmd.c (_initialize_mem_search): Use upper case for
8313         metasyntactic variables.
8314
8315 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8316
8317         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8318         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8319
8320 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8321
8322         * top.h (source_file_name): Change to std::string.
8323         * top.c (source_file_name): Likewise.
8324         (command_line_input): Adjust.
8325         * cli/cli-script.c (script_from_file): Adjust.
8326
8327 2019-02-19  Tom Tromey  <tromey@adacore.com>
8328
8329         * ravenscar-thread.c
8330         (ravenscar_thread_target::update_thread_list): Don't call
8331         ada_build_task_list.
8332         * ada-lang.h (ada_build_task_list): Don't declare.
8333         * ada-tasks.c (struct ada_tasks_inferior_data)
8334         <task_list_valid_p>: Now bool.
8335         (read_known_tasks, ada_task_list_changed)
8336         (ada_tasks_invalidate_inferior_data): Update.
8337         (read_known_tasks_array): Return bool.
8338         (read_known_tasks_list): Likewise.
8339         (read_known_tasks): Return void.
8340         (ada_build_task_list): Now static.
8341
8342 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8343
8344         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8345         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8346
8347 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8348
8349         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8350         variant for ada_tasks_pspace_data_handle and
8351         ada_tasks_inferior_data_handle.
8352         (ada_tasks_pspace_data_cleanup): New function.
8353         (ada_tasks_inferior_data_cleanup): New function.
8354
8355 2019-02-17  Tom Tromey  <tom@tromey.com>
8356
8357         * macrotab.h (macro_source_fullname): Return a std::string.
8358         * macrotab.c (macro_include, check_for_redefinition)
8359         (macro_undef, macro_lookup_definition, foreach_macro)
8360         (foreach_macro_in_scope): Update.
8361         (macro_source_fullname): Return a std::string.
8362         * macrocmd.c (show_pp_source_pos): Update.
8363
8364 2019-02-17  Tom Tromey  <tom@tromey.com>
8365
8366         * macrocmd.c (show_pp_source_pos): Style the file names.
8367
8368 2019-02-17  Tom Tromey  <tom@tromey.com>
8369
8370         PR tui/24197:
8371         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8372
8373 2019-02-17  Tom Tromey  <tom@tromey.com>
8374
8375         * ada-lang.c (user_select_syms): Use filtered printing.
8376         * utils.c (wrap_style): New global.
8377         (desired_style): Remove.
8378         (emit_style_escape): Add stream parameter.
8379         (set_output_style, reset_terminal_style, prompt_for_continue):
8380         Update.
8381         (flush_wrap_buffer): Only flush gdb_stdout.
8382         (wrap_here): Set wrap_style.
8383         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8384         treat escape sequences as a character.  Change when wrap buffer is
8385         flushed.
8386         (fputs_styled): Do not set the output style when the default is
8387         requested.
8388         * ui-style.h (struct ui_file_style) <is_default>: New method.
8389         * source.c (print_source_lines_base): Emit escape sequences in one
8390         piece.
8391
8392 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8393
8394         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8395         integers and enumeration types.
8396
8397 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8398
8399         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8400         instead of lookup_symbol_in_language
8401         (do_exact_match): New function.
8402         (ada_get_symbol_name_matcher): Return do_exact_match when
8403         doing a verbatim match.
8404
8405 2019-02-15  Tom Tromey  <tromey@adacore.com>
8406
8407         * ravenscar-thread.c (ravenscar_thread_target::resume)
8408         (ravenscar_thread_target::wait): Special case wildcard requests.
8409
8410 2019-02-15  Tom Tromey  <tromey@adacore.com>
8411
8412         * ravenscar-thread.c (base_ptid): Remove.
8413         (struct ravenscar_thread_target) <close>: New method.
8414         <m_base_ptid>: New member.
8415         <update_inferior_ptid, active_task, task_is_currently_active,
8416         runtime_initialized>: Declare methods.
8417         <ravenscar_thread_target>: Add constructor.
8418         (ravenscar_thread_target::task_is_currently_active)
8419         (ravenscar_thread_target::update_inferior_ptid)
8420         (ravenscar_runtime_initialized): Rename.  Now methods.
8421         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8422         (ravenscar_thread_target::update_thread_list): Update.
8423         (ravenscar_thread_target::active_task): Now method.
8424         (ravenscar_thread_target::store_registers)
8425         (ravenscar_thread_target::prepare_to_store)
8426         (ravenscar_thread_target::prepare_to_store)
8427         (ravenscar_thread_target::mourn_inferior): Update.
8428         (ravenscar_inferior_created): Use "new" to create target.
8429         (ravenscar_thread_target::get_ada_task_ptid): Update.
8430         (_initialize_ravenscar): Don't initialize base_ptid.
8431         (ravenscar_ops): Remove global.
8432
8433 2019-02-15  Tom Tromey  <tromey@adacore.com>
8434
8435         * target.h (push_target): Declare new overload.
8436         * target.c (push_target): New overload, taking an rvalue reference.
8437         * remote.c (remote_target::open_1): Use push_target overload.
8438         * corelow.c (core_target_open): Use push_target overload.
8439
8440 2019-02-15  Tom Tromey  <tromey@adacore.com>
8441
8442         * ravenscar-thread.c (is_ravenscar_task)
8443         (ravenscar_task_is_currently_active): Return bool.
8444         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8445         (_initialize_ravenscar): Remove "(void)".
8446         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8447         Return bool.
8448
8449 2019-02-15  Tom Tromey  <tromey@adacore.com>
8450
8451         * ravenscar-thread.c (ravenscar_runtime_initializer)
8452         (has_ravenscar_runtime, get_running_thread_id)
8453         (ravenscar_thread_target::resume): Fix indentation.
8454
8455 2019-02-15  Tom Tromey  <tromey@adacore.com>
8456
8457         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8458         from ravenscar_arch_ops.
8459         (sparc_ravenscar_ops::fetch_registers)
8460         (sparc_ravenscar_ops::store_registers): Now methods.
8461         (sparc_ravenscar_prepare_to_store): Remove.
8462         (sparc_ravenscar_ops): Redefine.
8463         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8464         methods and destructor.  Remove members.
8465         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8466         (ravenscar_thread_target::store_registers)
8467         (ravenscar_thread_target::prepare_to_store): Update.
8468         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8469         Remove.
8470         (struct ppc_ravenscar_powerpc_ops): Derive from
8471         ravenscar_arch_ops.
8472         (ppc_ravenscar_powerpc_ops::fetch_registers)
8473         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8474         (ppc_ravenscar_powerpc_ops): Redefine.
8475         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8476         (ppc_ravenscar_e500_ops::fetch_registers)
8477         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8478         (ppc_ravenscar_e500_ops): Redefine.
8479         * aarch64-ravenscar-thread.c
8480         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8481         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8482         (aarch64_ravenscar_fetch_registers)
8483         (aarch64_ravenscar_store_registers): Now methods.
8484         (aarch64_ravenscar_ops): Redefine.
8485
8486 2019-02-15  Tom Tromey  <tromey@adacore.com>
8487
8488         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8489         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8490         (ravenscar_thread_target::stopped_by_watchpoint)
8491         (ravenscar_thread_target::stopped_data_address)
8492         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8493
8494 2019-02-15  Tom Tromey  <tromey@adacore.com>
8495
8496         * ravenscar-thread.c: Fix some typos.
8497
8498 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8499             Tom Tromey  <tromey@adacore.com>
8500
8501         * ada-lang.c (ada_exception_sal): Change addr_string to a
8502         std::string.
8503         (create_ada_exception_catchpoint): Update.
8504
8505 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8506             Tom Tromey  <tromey@adacore.com>
8507
8508         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8509         (bp_location_ops): Remove.
8510         (base_breakpoint_allocate_location): Update.
8511         (free_bp_location): Update.
8512         * ada-lang.c (class ada_catchpoint_location)
8513         <ada_catchpoint_location>: Remove ops parameter.
8514         (ada_catchpoint_location_dtor): Remove.
8515         (ada_catchpoint_location_ops): Remove.
8516         (allocate_location_exception): Update.
8517         * breakpoint.h (struct bp_location_ops): Remove.
8518         (class bp_location) <bp_location>: Remove bp_location_ops
8519         parameter.
8520         <~bp_location>: Add destructor.
8521         <ops>: Remove.
8522
8523 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8524             Pedro Alves  <palves@redhat.com>
8525
8526         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8527         'PATH_MAX'.
8528
8529 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8530             Samuel Thibault  <samuel.thibault@gnu.org>
8531             Thomas Schwinge  <thomas@codesourcery.com>
8532
8533         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8534         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8535
8536 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8537
8538         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8539         (check_empty): Use "const char *".
8540
8541         * gnu-nat.c (gnu_nat_target::detach): Instead of
8542         'detach_inferior (pid)' call
8543         'detach_inferior (find_inferior_pid (pid))'.
8544
8545         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8546         'nat/fork-inferior.o'.
8547         * gnu-nat.c: #include "nat/fork-inferior.h".
8548
8549         * gnu-nat.c (gnu_nat_target::detach): Instead of
8550         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8551         * gnu-nat.h: #include "inf-child.h".
8552         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8553         'i386_gnu_nat_target::fetch_registers'.
8554         (gnu_store_registers): Rename/move to
8555         'i386_gnu_nat_target::store_registers'.
8556
8557         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8558         * gnu-nat.h (mach_thread_info): New function.
8559         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8560
8561         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8562
8563 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8564
8565         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8566
8567 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8568
8569         * windows-nat.c (windows_add_thread): Add new parameter
8570         "main_thread_p" with default value set to false.  Update
8571         function documentation as well as all callers.
8572         (windows_delete_thread): Likewise.
8573         (fake_create_process): Update call to windows_add_thread.
8574         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8575         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8576         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8577         call to windows_delete_thread.
8578
8579 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8580
8581         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8582
8583 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8584
8585         * symfile.c (find_separate_debug_file): Use canonical path of
8586         sysroot with child_path instead of gdb_sysroot if it is valid.
8587
8588 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8589
8590         * symfile.c (find_separate_debug_file): Use child_path to
8591         determine if an object file is under a sysroot.
8592
8593 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8594
8595         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8596         unittests/child-path-selftests.c.
8597         * common/pathstuff.c (child_path): New function.
8598         * common/pathstuff.h (child_path): New prototype.
8599         * unittests/child-path-selftests.c: New file.
8600
8601 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8602
8603         * symfile.c (find_separate_debug_file): Look for separate debug
8604         files in debug directories under the sysroot.
8605
8606 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8607
8608         * symtab.h (struct minimal_symbol data_p): New const method.
8609         (struct minimal_symbol text_p): Likewise.
8610         * symtab.c (output_source_filename): Use file name style
8611         to print file name.
8612         (print_symbol_info): Likewise.
8613         (print_msymbol_info): Use address style to print addresses.
8614         Use function name style to print executable text symbols.
8615         (expand_symtab_containing_pc): Use data_p.
8616         (find_pc_sect_compunit_symtab): Likewise.
8617
8618 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8619
8620         * breakpoint.c (describe_other_breakpoints): Use address style
8621         to print addresses.
8622         (say_where): Likewise.
8623
8624 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8625
8626         * ada-typeprint.c (print_func_type): Print function name
8627         style to print function name.
8628         * c-typeprint.c (c_print_type_1): Likewise.
8629
8630 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8631
8632         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8633         for execve.
8634
8635 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8636
8637         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8638         type_stack.
8639
8640 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8641
8642         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8643         TYPE_CODE_REF types.
8644
8645 2019-02-08  Jim Wilson  <jimw@sifive.com>
8646
8647         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8648         (riscv_linux_fregset): New.
8649         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8650
8651 2019-02-07  Tom Tromey  <tom@tromey.com>
8652
8653         * thread.c (thread_cancel_execution_command): Update.
8654         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8655         methods.
8656         (struct thread_fsm_ops): Remove.
8657         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8658         (thread_fsm_should_stop, thread_fsm_return_value)
8659         (thread_fsm_set_finished, thread_fsm_finished_p)
8660         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8661         Don't declare.
8662         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8663         * infrun.c (clear_proceed_status_thread)
8664         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8665         (print_stop_event): Update.
8666         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8667         Add constructor.
8668         (step_command_fsm_ops): Remove.
8669         (new_step_command_fsm): Remove.
8670         (step_1): Update.
8671         (step_command_fsm::should_stop): Rename from
8672         step_command_fsm_should_stop.
8673         (step_command_fsm::clean_up): Rename from
8674         step_command_fsm_clean_up.
8675         (step_command_fsm::do_async_reply_reason): Rename from
8676         step_command_fsm_async_reply_reason.
8677         (struct until_next_fsm): Inherit from thread_fsm.  Add
8678         constructor.
8679         (until_next_fsm_ops): Remove.
8680         (new_until_next_fsm): Remove.
8681         (until_next_fsm::should_stop): Rename from
8682         until_next_fsm_should_stop.
8683         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8684         (until_next_fsm::do_async_reply_reason): Rename from
8685         until_next_fsm_async_reply_reason.
8686         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8687         constructor.  Change type of breakpoint.
8688         (finish_command_fsm_ops): Remove.
8689         (new_finish_command_fsm): Remove.
8690         (finish_command_fsm::should_stop): Rename from
8691         finish_command_fsm_should_stop.
8692         (finish_command_fsm::clean_up): Rename from
8693         finish_command_fsm_clean_up.
8694         (finish_command_fsm::return_value): Rename from
8695         finish_command_fsm_return_value.
8696         (finish_command_fsm::do_async_reply_reason): Rename from
8697         finish_command_fsm_async_reply_reason.
8698         (finish_command): Update.
8699         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8700         Add constructor.
8701         (call_thread_fsm_ops): Remove.
8702         (call_thread_fsm::call_thread_fsm): Rename from
8703         new_call_thread_fsm.
8704         (call_thread_fsm::should_stop): Rename from
8705         call_thread_fsm_should_stop.
8706         (call_thread_fsm::should_notify_stop): Rename from
8707         call_thread_fsm_should_notify_stop.
8708         (run_inferior_call, call_function_by_hand_dummy): Update.
8709         * cli/cli-interp.c (should_print_stop_to_console): Update.
8710         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8711         Add constructor.  Change type of location_breakpoint,
8712         caller_breakpoint.
8713         (until_break_fsm_ops): Remove.
8714         (new_until_break_fsm): Remove.
8715         (until_break_fsm::should_stop): Rename from
8716         until_break_fsm_should_stop.
8717         (until_break_fsm::clean_up): Rename from
8718         until_break_fsm_clean_up.
8719         (until_break_fsm::do_async_reply_reason): Rename from
8720         until_break_fsm_async_reply_reason.
8721         (until_break_command): Update.
8722         * thread-fsm.c: Remove.
8723         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8724
8725 2019-02-07  Tom Tromey  <tom@tromey.com>
8726
8727         * yy-remap.h: Add include guard.
8728         * xtensa-tdep.h: Add include guard.
8729         * xcoffread.h: Rename include guard.
8730         * varobj-iter.h: Add include guard.
8731         * tui/tui.h: Rename include guard.
8732         * tui/tui-winsource.h: Rename include guard.
8733         * tui/tui-wingeneral.h: Rename include guard.
8734         * tui/tui-windata.h: Rename include guard.
8735         * tui/tui-win.h: Rename include guard.
8736         * tui/tui-stack.h: Rename include guard.
8737         * tui/tui-source.h: Rename include guard.
8738         * tui/tui-regs.h: Rename include guard.
8739         * tui/tui-out.h: Rename include guard.
8740         * tui/tui-layout.h: Rename include guard.
8741         * tui/tui-io.h: Rename include guard.
8742         * tui/tui-hooks.h: Rename include guard.
8743         * tui/tui-file.h: Rename include guard.
8744         * tui/tui-disasm.h: Rename include guard.
8745         * tui/tui-data.h: Rename include guard.
8746         * tui/tui-command.h: Rename include guard.
8747         * tic6x-tdep.h: Add include guard.
8748         * target/waitstatus.h: Rename include guard.
8749         * target/wait.h: Rename include guard.
8750         * target/target.h: Rename include guard.
8751         * target/resume.h: Rename include guard.
8752         * target-float.h: Rename include guard.
8753         * stabsread.h: Add include guard.
8754         * rs6000-tdep.h: Add include guard.
8755         * riscv-fbsd-tdep.h: Add include guard.
8756         * regformats/regdef.h: Rename include guard.
8757         * record.h: Rename include guard.
8758         * python/python.h: Rename include guard.
8759         * python/python-internal.h: Rename include guard.
8760         * python/py-stopevent.h: Rename include guard.
8761         * python/py-ref.h: Rename include guard.
8762         * python/py-record.h: Rename include guard.
8763         * python/py-record-full.h: Rename include guard.
8764         * python/py-record-btrace.h: Rename include guard.
8765         * python/py-instruction.h: Rename include guard.
8766         * python/py-events.h: Rename include guard.
8767         * python/py-event.h: Rename include guard.
8768         * procfs.h: Add include guard.
8769         * proc-utils.h: Add include guard.
8770         * p-lang.h: Add include guard.
8771         * or1k-tdep.h: Rename include guard.
8772         * observable.h: Rename include guard.
8773         * nto-tdep.h: Rename include guard.
8774         * nat/x86-linux.h: Rename include guard.
8775         * nat/x86-linux-dregs.h: Rename include guard.
8776         * nat/x86-gcc-cpuid.h: Add include guard.
8777         * nat/x86-dregs.h: Rename include guard.
8778         * nat/x86-cpuid.h: Rename include guard.
8779         * nat/ppc-linux.h: Rename include guard.
8780         * nat/mips-linux-watch.h: Rename include guard.
8781         * nat/linux-waitpid.h: Rename include guard.
8782         * nat/linux-ptrace.h: Rename include guard.
8783         * nat/linux-procfs.h: Rename include guard.
8784         * nat/linux-osdata.h: Rename include guard.
8785         * nat/linux-nat.h: Rename include guard.
8786         * nat/linux-namespaces.h: Rename include guard.
8787         * nat/linux-btrace.h: Rename include guard.
8788         * nat/glibc_thread_db.h: Rename include guard.
8789         * nat/gdb_thread_db.h: Rename include guard.
8790         * nat/gdb_ptrace.h: Rename include guard.
8791         * nat/fork-inferior.h: Rename include guard.
8792         * nat/amd64-linux-siginfo.h: Rename include guard.
8793         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8794         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8795         * nat/aarch64-linux.h: Rename include guard.
8796         * nat/aarch64-linux-hw-point.h: Rename include guard.
8797         * mn10300-tdep.h: Add include guard.
8798         * mips-linux-tdep.h: Add include guard.
8799         * mi/mi-parse.h: Rename include guard.
8800         * mi/mi-out.h: Rename include guard.
8801         * mi/mi-main.h: Rename include guard.
8802         * mi/mi-interp.h: Rename include guard.
8803         * mi/mi-getopt.h: Rename include guard.
8804         * mi/mi-console.h: Rename include guard.
8805         * mi/mi-common.h: Rename include guard.
8806         * mi/mi-cmds.h: Rename include guard.
8807         * mi/mi-cmd-break.h: Rename include guard.
8808         * m2-lang.h: Add include guard.
8809         * location.h: Rename include guard.
8810         * linux-record.h: Rename include guard.
8811         * linux-nat.h: Add include guard.
8812         * linux-fork.h: Add include guard.
8813         * i386-darwin-tdep.h: Rename include guard.
8814         * hppa-linux-offsets.h: Add include guard.
8815         * guile/guile.h: Rename include guard.
8816         * guile/guile-internal.h: Rename include guard.
8817         * gnu-nat.h: Rename include guard.
8818         * gdb-stabs.h: Rename include guard.
8819         * frv-tdep.h: Add include guard.
8820         * f-lang.h: Add include guard.
8821         * event-loop.h: Add include guard.
8822         * darwin-nat.h: Rename include guard.
8823         * cp-abi.h: Rename include guard.
8824         * config/sparc/nm-sol2.h: Rename include guard.
8825         * config/nm-nto.h: Rename include guard.
8826         * config/nm-linux.h: Add include guard.
8827         * config/i386/nm-i386gnu.h: Rename include guard.
8828         * config/djgpp/nl_types.h: Rename include guard.
8829         * config/djgpp/langinfo.h: Rename include guard.
8830         * compile/gcc-cp-plugin.h: Add include guard.
8831         * compile/gcc-c-plugin.h: Add include guard.
8832         * compile/compile.h: Rename include guard.
8833         * compile/compile-object-run.h: Rename include guard.
8834         * compile/compile-object-load.h: Rename include guard.
8835         * compile/compile-internal.h: Rename include guard.
8836         * compile/compile-cplus.h: Rename include guard.
8837         * compile/compile-c.h: Rename include guard.
8838         * common/xml-utils.h: Rename include guard.
8839         * common/x86-xstate.h: Rename include guard.
8840         * common/version.h: Rename include guard.
8841         * common/vec.h: Rename include guard.
8842         * common/tdesc.h: Rename include guard.
8843         * common/selftest.h: Rename include guard.
8844         * common/scoped_restore.h: Rename include guard.
8845         * common/scoped_mmap.h: Rename include guard.
8846         * common/scoped_fd.h: Rename include guard.
8847         * common/safe-iterator.h: Rename include guard.
8848         * common/run-time-clock.h: Rename include guard.
8849         * common/refcounted-object.h: Rename include guard.
8850         * common/queue.h: Rename include guard.
8851         * common/ptid.h: Rename include guard.
8852         * common/print-utils.h: Rename include guard.
8853         * common/preprocessor.h: Rename include guard.
8854         * common/pathstuff.h: Rename include guard.
8855         * common/observable.h: Rename include guard.
8856         * common/netstuff.h: Rename include guard.
8857         * common/job-control.h: Rename include guard.
8858         * common/host-defs.h: Rename include guard.
8859         * common/gdb_wait.h: Rename include guard.
8860         * common/gdb_vecs.h: Rename include guard.
8861         * common/gdb_unlinker.h: Rename include guard.
8862         * common/gdb_unique_ptr.h: Rename include guard.
8863         * common/gdb_tilde_expand.h: Rename include guard.
8864         * common/gdb_sys_time.h: Rename include guard.
8865         * common/gdb_string_view.h: Rename include guard.
8866         * common/gdb_splay_tree.h: Rename include guard.
8867         * common/gdb_setjmp.h: Rename include guard.
8868         * common/gdb_ref_ptr.h: Rename include guard.
8869         * common/gdb_optional.h: Rename include guard.
8870         * common/gdb_locale.h: Rename include guard.
8871         * common/gdb_assert.h: Rename include guard.
8872         * common/filtered-iterator.h: Rename include guard.
8873         * common/filestuff.h: Rename include guard.
8874         * common/fileio.h: Rename include guard.
8875         * common/environ.h: Rename include guard.
8876         * common/common-utils.h: Rename include guard.
8877         * common/common-types.h: Rename include guard.
8878         * common/common-regcache.h: Rename include guard.
8879         * common/common-inferior.h: Rename include guard.
8880         * common/common-gdbthread.h: Rename include guard.
8881         * common/common-exceptions.h: Rename include guard.
8882         * common/common-defs.h: Rename include guard.
8883         * common/common-debug.h: Rename include guard.
8884         * common/cleanups.h: Rename include guard.
8885         * common/buffer.h: Rename include guard.
8886         * common/btrace-common.h: Rename include guard.
8887         * common/break-common.h: Rename include guard.
8888         * cli/cli-utils.h: Rename include guard.
8889         * cli/cli-style.h: Rename include guard.
8890         * cli/cli-setshow.h: Rename include guard.
8891         * cli/cli-script.h: Rename include guard.
8892         * cli/cli-interp.h: Rename include guard.
8893         * cli/cli-decode.h: Rename include guard.
8894         * cli/cli-cmds.h: Rename include guard.
8895         * charset-list.h: Add include guard.
8896         * buildsym-legacy.h: Rename include guard.
8897         * bfin-tdep.h: Add include guard.
8898         * ax.h: Rename include guard.
8899         * arm-linux-tdep.h: Add include guard.
8900         * arm-fbsd-tdep.h: Add include guard.
8901         * arch/xtensa.h: Rename include guard.
8902         * arch/tic6x.h: Add include guard.
8903         * arch/i386.h: Add include guard.
8904         * arch/arm.h: Rename include guard.
8905         * arch/arm-linux.h: Rename include guard.
8906         * arch/arm-get-next-pcs.h: Rename include guard.
8907         * arch/amd64.h: Add include guard.
8908         * arch/aarch64-insn.h: Rename include guard.
8909         * arch-utils.h: Rename include guard.
8910         * annotate.h: Add include guard.
8911         * amd64-darwin-tdep.h: Rename include guard.
8912         * aarch64-linux-tdep.h: Add include guard.
8913         * aarch64-fbsd-tdep.h: Add include guard.
8914         * aarch32-linux-nat.h: Add include guard.
8915
8916 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8917
8918         * macrotab.c (macro_define_internal): New function that
8919         factorizes macro_define_object_internal and macro_define_function
8920         code.
8921         (macro_define_object_internal): Use macro_define_internal.
8922         (macro_define_function): Likewise.
8923
8924 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8925
8926         * macrocmd.c (extract_identifier): Return
8927         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8928         callers.
8929
8930 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8931
8932         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8933
8934 2019-02-05  Tom Tromey  <tom@tromey.com>
8935
8936         * target.c (target_stack::unpush): Move assertion earlier.
8937
8938 2019-01-30  Tom Tromey  <tom@tromey.com>
8939
8940         PR python/23615:
8941         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8942         (gdbpy_parse_and_eval): Likewise.
8943         * python/python-internal.h (gdbpy_allow_threads): New class.
8944
8945 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8946
8947         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8948         (aarch64_fbsd_fpregmap): Move earlier.
8949         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8950         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8951         instead of individual calls to trad_frame_set_reg_addr.
8952         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8953         earlier.
8954         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8955         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8956         instead of individual calls to trad_frame_set_reg_addr.
8957
8958 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8959
8960         * CONTRIBUTE: Replace contribution list with wiki link.
8961
8962 2019-01-25  Tom Tromey  <tom@tromey.com>
8963
8964         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8965
8966 2019-01-25  Tom Tromey  <tom@tromey.com>
8967
8968         * xtensa-linux-nat.c: Fix common/ includes.
8969         * xml-support.h: Fix common/ includes.
8970         * xml-support.c: Fix common/ includes.
8971         * x86-linux-nat.c: Fix common/ includes.
8972         * windows-nat.c: Fix common/ includes.
8973         * varobj.h: Fix common/ includes.
8974         * varobj.c: Fix common/ includes.
8975         * value.c: Fix common/ includes.
8976         * valops.c: Fix common/ includes.
8977         * utils.c: Fix common/ includes.
8978         * unittests/xml-utils-selftests.c: Fix common/ includes.
8979         * unittests/utils-selftests.c: Fix common/ includes.
8980         * unittests/unpack-selftests.c: Fix common/ includes.
8981         * unittests/tracepoint-selftests.c: Fix common/ includes.
8982         * unittests/style-selftests.c: Fix common/ includes.
8983         * unittests/string_view-selftests.c: Fix common/ includes.
8984         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8985         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8986         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8987         * unittests/rsp-low-selftests.c: Fix common/ includes.
8988         * unittests/parse-connection-spec-selftests.c: Fix common/
8989         includes.
8990         * unittests/optional-selftests.c: Fix common/ includes.
8991         * unittests/offset-type-selftests.c: Fix common/ includes.
8992         * unittests/observable-selftests.c: Fix common/ includes.
8993         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8994         * unittests/memrange-selftests.c: Fix common/ includes.
8995         * unittests/memory-map-selftests.c: Fix common/ includes.
8996         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8997         * unittests/function-view-selftests.c: Fix common/ includes.
8998         * unittests/environ-selftests.c: Fix common/ includes.
8999         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
9000         * unittests/common-utils-selftests.c: Fix common/ includes.
9001         * unittests/cli-utils-selftests.c: Fix common/ includes.
9002         * unittests/array-view-selftests.c: Fix common/ includes.
9003         * ui-file.c: Fix common/ includes.
9004         * tui/tui-io.c: Fix common/ includes.
9005         * tracepoint.h: Fix common/ includes.
9006         * tracepoint.c: Fix common/ includes.
9007         * tracefile-tfile.c: Fix common/ includes.
9008         * top.h: Fix common/ includes.
9009         * top.c: Fix common/ includes.
9010         * thread.c: Fix common/ includes.
9011         * target/waitstatus.h: Fix common/ includes.
9012         * target/waitstatus.c: Fix common/ includes.
9013         * target.h: Fix common/ includes.
9014         * target.c: Fix common/ includes.
9015         * target-memory.c: Fix common/ includes.
9016         * target-descriptions.c: Fix common/ includes.
9017         * symtab.h: Fix common/ includes.
9018         * symfile.c: Fix common/ includes.
9019         * stap-probe.c: Fix common/ includes.
9020         * spu-linux-nat.c: Fix common/ includes.
9021         * sparc-nat.c: Fix common/ includes.
9022         * source.c: Fix common/ includes.
9023         * solib.c: Fix common/ includes.
9024         * solib-target.c: Fix common/ includes.
9025         * ser-unix.c: Fix common/ includes.
9026         * ser-tcp.c: Fix common/ includes.
9027         * ser-pipe.c: Fix common/ includes.
9028         * ser-base.c: Fix common/ includes.
9029         * selftest-arch.c: Fix common/ includes.
9030         * s12z-tdep.c: Fix common/ includes.
9031         * rust-exp.y: Fix common/ includes.
9032         * rs6000-aix-tdep.c: Fix common/ includes.
9033         * riscv-tdep.c: Fix common/ includes.
9034         * remote.c: Fix common/ includes.
9035         * remote-notif.h: Fix common/ includes.
9036         * remote-fileio.h: Fix common/ includes.
9037         * remote-fileio.c: Fix common/ includes.
9038         * regcache.h: Fix common/ includes.
9039         * regcache.c: Fix common/ includes.
9040         * record-btrace.c: Fix common/ includes.
9041         * python/python.c: Fix common/ includes.
9042         * python/py-type.c: Fix common/ includes.
9043         * python/py-inferior.c: Fix common/ includes.
9044         * progspace.h: Fix common/ includes.
9045         * producer.c: Fix common/ includes.
9046         * procfs.c: Fix common/ includes.
9047         * proc-api.c: Fix common/ includes.
9048         * printcmd.c: Fix common/ includes.
9049         * ppc-linux-nat.c: Fix common/ includes.
9050         * parser-defs.h: Fix common/ includes.
9051         * osdata.c: Fix common/ includes.
9052         * obsd-nat.c: Fix common/ includes.
9053         * nat/x86-linux.c: Fix common/ includes.
9054         * nat/x86-linux-dregs.c: Fix common/ includes.
9055         * nat/x86-dregs.h: Fix common/ includes.
9056         * nat/x86-dregs.c: Fix common/ includes.
9057         * nat/ppc-linux.c: Fix common/ includes.
9058         * nat/mips-linux-watch.h: Fix common/ includes.
9059         * nat/mips-linux-watch.c: Fix common/ includes.
9060         * nat/linux-waitpid.c: Fix common/ includes.
9061         * nat/linux-ptrace.h: Fix common/ includes.
9062         * nat/linux-ptrace.c: Fix common/ includes.
9063         * nat/linux-procfs.c: Fix common/ includes.
9064         * nat/linux-personality.c: Fix common/ includes.
9065         * nat/linux-osdata.c: Fix common/ includes.
9066         * nat/linux-namespaces.c: Fix common/ includes.
9067         * nat/linux-btrace.h: Fix common/ includes.
9068         * nat/linux-btrace.c: Fix common/ includes.
9069         * nat/fork-inferior.c: Fix common/ includes.
9070         * nat/amd64-linux-siginfo.c: Fix common/ includes.
9071         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
9072         * nat/aarch64-linux.c: Fix common/ includes.
9073         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9074         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9075         * namespace.h: Fix common/ includes.
9076         * mips-linux-tdep.c: Fix common/ includes.
9077         * minsyms.c: Fix common/ includes.
9078         * mi/mi-parse.h: Fix common/ includes.
9079         * mi/mi-main.c: Fix common/ includes.
9080         * mi/mi-cmd-env.c: Fix common/ includes.
9081         * memrange.h: Fix common/ includes.
9082         * memattr.c: Fix common/ includes.
9083         * maint.h: Fix common/ includes.
9084         * maint.c: Fix common/ includes.
9085         * main.c: Fix common/ includes.
9086         * machoread.c: Fix common/ includes.
9087         * location.c: Fix common/ includes.
9088         * linux-thread-db.c: Fix common/ includes.
9089         * linux-nat.c: Fix common/ includes.
9090         * linux-fork.c: Fix common/ includes.
9091         * inline-frame.c: Fix common/ includes.
9092         * infrun.c: Fix common/ includes.
9093         * inflow.c: Fix common/ includes.
9094         * inferior.h: Fix common/ includes.
9095         * inferior.c: Fix common/ includes.
9096         * infcmd.c: Fix common/ includes.
9097         * inf-ptrace.c: Fix common/ includes.
9098         * inf-child.c: Fix common/ includes.
9099         * ia64-linux-nat.c: Fix common/ includes.
9100         * i387-tdep.c: Fix common/ includes.
9101         * i386-tdep.c: Fix common/ includes.
9102         * i386-linux-tdep.c: Fix common/ includes.
9103         * i386-linux-nat.c: Fix common/ includes.
9104         * i386-go32-tdep.c: Fix common/ includes.
9105         * i386-fbsd-tdep.c: Fix common/ includes.
9106         * i386-fbsd-nat.c: Fix common/ includes.
9107         * guile/scm-type.c: Fix common/ includes.
9108         * guile/guile.c: Fix common/ includes.
9109         * go32-nat.c: Fix common/ includes.
9110         * gnu-nat.c: Fix common/ includes.
9111         * gdbthread.h: Fix common/ includes.
9112         * gdbarch-selftests.c: Fix common/ includes.
9113         * gdb_usleep.c: Fix common/ includes.
9114         * gdb_select.h: Fix common/ includes.
9115         * gdb_bfd.c: Fix common/ includes.
9116         * gcore.c: Fix common/ includes.
9117         * fork-child.c: Fix common/ includes.
9118         * findvar.c: Fix common/ includes.
9119         * fbsd-nat.c: Fix common/ includes.
9120         * event-top.c: Fix common/ includes.
9121         * event-loop.c: Fix common/ includes.
9122         * dwarf2read.c: Fix common/ includes.
9123         * dwarf2loc.c: Fix common/ includes.
9124         * dwarf2-frame.c: Fix common/ includes.
9125         * dwarf-index-cache.c: Fix common/ includes.
9126         * dtrace-probe.c: Fix common/ includes.
9127         * disasm-selftests.c: Fix common/ includes.
9128         * defs.h: Fix common/ includes.
9129         * csky-tdep.c: Fix common/ includes.
9130         * cp-valprint.c: Fix common/ includes.
9131         * cp-support.h: Fix common/ includes.
9132         * cp-support.c: Fix common/ includes.
9133         * corelow.c: Fix common/ includes.
9134         * completer.h: Fix common/ includes.
9135         * completer.c: Fix common/ includes.
9136         * compile/compile.c: Fix common/ includes.
9137         * compile/compile-loc2c.c: Fix common/ includes.
9138         * compile/compile-cplus-types.c: Fix common/ includes.
9139         * compile/compile-cplus-symbols.c: Fix common/ includes.
9140         * command.h: Fix common/ includes.
9141         * cli/cli-dump.c: Fix common/ includes.
9142         * cli/cli-cmds.c: Fix common/ includes.
9143         * charset.c: Fix common/ includes.
9144         * build-id.c: Fix common/ includes.
9145         * btrace.h: Fix common/ includes.
9146         * btrace.c: Fix common/ includes.
9147         * breakpoint.h: Fix common/ includes.
9148         * breakpoint.c: Fix common/ includes.
9149         * ax.h:
9150         (enum agent_op): Fix common/ includes.
9151         * ax-general.c (struct aop_map): Fix common/ includes.
9152         * ax-gdb.c: Fix common/ includes.
9153         * auxv.c: Fix common/ includes.
9154         * auto-load.c: Fix common/ includes.
9155         * arm-tdep.c: Fix common/ includes.
9156         * arch/riscv.c: Fix common/ includes.
9157         * arch/ppc-linux-common.c: Fix common/ includes.
9158         * arch/i386.c: Fix common/ includes.
9159         * arch/arm.c: Fix common/ includes.
9160         * arch/arm-linux.c: Fix common/ includes.
9161         * arch/arm-get-next-pcs.c: Fix common/ includes.
9162         * arch/amd64.c: Fix common/ includes.
9163         * arch/aarch64.c: Fix common/ includes.
9164         * arch/aarch64-insn.c: Fix common/ includes.
9165         * arch-utils.c: Fix common/ includes.
9166         * amd64-windows-tdep.c: Fix common/ includes.
9167         * amd64-tdep.c: Fix common/ includes.
9168         * amd64-sol2-tdep.c: Fix common/ includes.
9169         * amd64-obsd-tdep.c: Fix common/ includes.
9170         * amd64-nbsd-tdep.c: Fix common/ includes.
9171         * amd64-linux-tdep.c: Fix common/ includes.
9172         * amd64-linux-nat.c: Fix common/ includes.
9173         * amd64-fbsd-tdep.c: Fix common/ includes.
9174         * amd64-fbsd-nat.c: Fix common/ includes.
9175         * amd64-dicos-tdep.c: Fix common/ includes.
9176         * amd64-darwin-tdep.c: Fix common/ includes.
9177         * agent.c: Fix common/ includes.
9178         * ada-lang.h: Fix common/ includes.
9179         * ada-lang.c: Fix common/ includes.
9180         * aarch64-tdep.c: Fix common/ includes.
9181
9182 2019-01-25  Tom Tromey  <tom@tromey.com>
9183
9184         * common/create-version.sh: Use common/version.h.
9185
9186 2019-01-24  Pedro Alves  <palves@redhat.com>
9187
9188         * infrun.c (signal_stop, signal_print, signal_program)
9189         (signal_catch, signal_pass): Now arrays instead of pointers.
9190         (update_signals_program_target, do_target_resume)
9191         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9192         * linux-nat.c (linux_nat_target::pass_signals)
9193         (linux_nat_target::create_inferior, linux_nat_target::attach):
9194         Adjust.
9195         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9196         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9197         * procfs.c (procfs_target::pass_signals): Adjust.
9198         * record-full.c (record_full_target::resume): Adjust.
9199         * remote.c (remote_target::pass_signals)
9200         (remote_target::program_signals): Adjust.
9201         * target-debug.h (target_debug_print_signals): Now takes a
9202         gdb::array_view as parameter.  Adjust.
9203         * target.h (target_ops) <pass_signals, program_signals>: Replace
9204         pointer and length parameters with gdb::array_view.
9205         (target_pass_signals, target_program_signals): Likewise.
9206         * target-delegates.c: Regenerate.
9207
9208 2019-01-24  Pedro Alves  <palves@redhat.com>
9209
9210         * common/forward-scope-exit.h
9211         (forward_scope_exit::forward_scope_exit): Pass arguments to
9212         m_bind_function directly, instead of creating a std::bind and
9213         copying that.
9214
9215 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9216
9217         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9218         for static members.
9219         (pass_in_v_vfp_candidate): Likewise.
9220
9221 2019-01-23  Tom Tromey  <tom@tromey.com>
9222             Pedro Alves  <palves@redhat.com>
9223
9224         * regcache.c (class regcache_invalidator): Remove.
9225         (regcache::raw_write): Use make_scope_exit.
9226
9227 2019-01-23  Tom Tromey  <tom@tromey.com>
9228
9229         * ui-out.h (class ui_out_emit_type): Update comment.
9230
9231 2019-01-23  Tom Tromey  <tom@tromey.com>
9232
9233         * infrun.c (fetch_inferior_event): Update comment.
9234
9235 2019-01-23  Tom Tromey  <tom@tromey.com>
9236             Pedro Alves  <palves@redhat.com>
9237
9238         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9239         parameter.
9240         (fetch_inferior_event): Use SCOPE_EXIT.
9241
9242
9243 2019-01-23  Tom Tromey  <tom@tromey.com>
9244             Pedro Alves  <palves@redhat.com>
9245
9246         * infrun.c (disable_thread_events): Delete.
9247         (stop_all_threads): Use SCOPE_EXIT.
9248
9249 2019-01-23  Tom Tromey  <tom@tromey.com>
9250             Pedro Alves  <palves@redhat.com>
9251
9252         * symfile.c: Include forward-scope-exit.h.
9253         (clear_symtab_users_cleanup): Replace forward declaration with
9254         a FORWARD_SCOPE_EXIT.
9255         (syms_from_objfile_1): Use the forward_scope_exit and
9256         gdb::optional instead of cleanup_function.
9257         (reread_symbols): Use the forward_scope_exit instead of
9258         cleanup_function.
9259         (clear_symtab_users_cleanup): Remove function.
9260
9261 2019-01-23  Tom Tromey  <tom@tromey.com>
9262             Pedro Alves  <palves@redhat.com>
9263
9264         * linux-nat.c: Include scope-exit.h.
9265         (cleanup_target_stop): Remove.
9266         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9267         SCOPE_EXIT.
9268
9269 2019-01-23  Tom Tromey  <tom@tromey.com>
9270             Pedro Alves  <palves@redhat.com>
9271
9272         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9273         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9274
9275 2019-01-23  Tom Tromey  <tom@tromey.com>
9276             Andrew Burgess  <andrew.burgess@embecosm.com>
9277             Pedro Alves  <palves@redhat.com>
9278
9279         * infrun.c (fetch_inferior_event): Use scope_exit.
9280         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9281         * top.c (execute_command): Use scope_exit.
9282         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9283         * utils.c (do_bpstat_clear_actions_cleanup)
9284         (make_bpstat_clear_actions_cleanup): Remove.
9285
9286 2019-01-23  Tom Tromey  <tom@tromey.com>
9287             Pedro Alves  <palves@redhat.com>
9288
9289         * infrun.c: Include "common/scope-exit.h"
9290         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9291         (wait_for_inferior): Use SCOPE_EXIT.
9292         (fetch_inferior_event): Use scope_exit.
9293
9294 2019-01-23  Tom Tromey  <tom@tromey.com>
9295             Pedro Alves  <palves@redhat.com>
9296
9297         * breakpoint.c (create_breakpoint): Remove cleanup.
9298
9299 2019-01-23  Tom Tromey  <tom@tromey.com>
9300             Andrew Burgess  <andrew.burgess@embecosm.com>
9301             Pedro Alves  <palves@redhat.com>
9302
9303 2019-01-23  Pedro Alves  <palves@redhat.com>
9304
9305         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9306
9307 2019-01-23  Pedro Alves  <palves@redhat.com>
9308             Andrew Burgess  <andrew.burgess@embecosm.com>
9309
9310         * gdbthread.h: Include "common/forward-scope-exit.h".
9311         (scoped_finish_thread_state): Redefine custom class in terms of
9312         forward_scope_exit.
9313
9314 2019-01-23  Pedro Alves  <palves@redhat.com>
9315             Andrew Burgess  <andrew.burgess@embecosm.com>
9316
9317         * common/forward-scope-exit.h: New file.
9318
9319 2019-01-23  Pedro Alves  <palves@redhat.com>
9320             Andrew Burgess  <andrew.burgess@embecosm.com>
9321             Tom Tromey  <tom@tromey.com>
9322
9323         * common/scope-exit.h: New file.
9324
9325 2019-01-23  Pedro Alves  <palves@redhat.com>
9326
9327         * common/preprocessor.h (ESC): Rename to ...
9328         (ESC_PARENS): ... this.
9329         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9330         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9331
9332 2019-01-23  Tom Tromey  <tom@tromey.com>
9333
9334         * language.h (class scoped_switch_to_sym_language_if_auto):
9335         Initialize m_lang in both cases.
9336
9337 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9338
9339         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9340         with XCNEW.
9341
9342 2019-01-22  Tom Tromey  <tom@tromey.com>
9343
9344         * corelow.c: Do not include sys/file.h.
9345
9346 2019-01-22  Tom Tromey  <tom@tromey.com>
9347
9348         * tui/tui-wingeneral.h: Include gdb_curses.h.
9349
9350 2019-01-22  Tom Tromey  <tom@tromey.com>
9351
9352         * source-cache.h (class source_cache) <get_source_lines,
9353         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9354
9355 2019-01-22  Tom Tromey  <tom@tromey.com>
9356
9357         * remote-fileio.h (struct remote_target): Declare.
9358
9359 2019-01-22  Tom Tromey  <tom@tromey.com>
9360
9361         * python/py-arch.c: Do not include py-ref.h.
9362         * python/py-bpevent.c: Do not include py-ref.h.
9363         * python/py-cmd.c: Do not include py-ref.h.
9364         * python/py-continueevent.c: Do not include py-ref.h.
9365         * python/py-event.h: Do not include py-ref.h.
9366         * python/py-evtregistry.c: Do not include py-ref.h.
9367         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9368         * python/py-frame.c: Do not include py-ref.h.
9369         * python/py-framefilter.c: Do not include py-ref.h.
9370         * python/py-function.c: Do not include py-ref.h.
9371         * python/py-infevents.c: Do not include py-ref.h.
9372         * python/py-linetable.c: Do not include py-ref.h.
9373         * python/py-objfile.c: Do not include py-ref.h.
9374         * python/py-param.c: Do not include py-ref.h.
9375         * python/py-prettyprint.c: Do not include py-ref.h.
9376         * python/py-progspace.c: Do not include py-ref.h.
9377         * python/py-symbol.c: Do not include py-ref.h.
9378         * python/py-symtab.c: Do not include py-ref.h.
9379         * python/py-type.c: Do not include py-ref.h.
9380         * python/py-unwind.c: Do not include py-ref.h.
9381         * python/py-utils.c: Do not include py-ref.h.
9382         * python/py-value.c: Do not include py-ref.h.
9383         * python/py-varobj.c: Do not include py-ref.h.
9384         * python/py-xmethods.c: Do not include py-ref.h.
9385         * python/python.c: Do not include py-ref.h.
9386         * varobj.c: Do not include py-ref.h.
9387
9388 2019-01-22  Tom Tromey  <tom@tromey.com>
9389
9390         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9391         keyword for bcache.
9392
9393 2019-01-22  Tom Tromey  <tom@tromey.com>
9394
9395         * compile/compile-cplus-types.c: Remove a comment by #include.
9396
9397 2019-01-22  Tom Tromey  <tom@tromey.com>
9398
9399         * compile/gcc-c-plugin.h: Include compile-internal.h.
9400
9401 2019-01-22  Tom Tromey  <tom@tromey.com>
9402
9403         * stabsread.c (EXTERN): Do not define.
9404         (symnum, next_symbol_text_func, processing_gcc_compilation)
9405         (within_function, global_sym_chain, global_stabs)
9406         (previous_stab_code, this_object_header_files)
9407         (n_this_object_header_files)
9408         (n_allocated_this_object_header_files): Define.
9409         * stabsread.h (EXTERN): Never define.  Use "extern".
9410
9411 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9412
9413         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9414         history_value.
9415
9416 2019-01-21  Tom Tromey  <tom@tromey.com>
9417
9418         * ui-out.c: Fix includes.
9419         * tui/tui-source.c: Fix includes.
9420         * target.c: Fix includes.
9421         * remote.c: Fix includes.
9422         * regcache.c: Fix includes.
9423         * python/py-block.c: Fix includes.
9424         * printcmd.c: Fix includes.
9425         * or1k-tdep.c: Fix includes.
9426         * mi/mi-main.c: Fix includes.
9427         * m32r-tdep.c: Fix includes.
9428         * csky-tdep.c: Fix includes.
9429         * compile/compile-cplus-types.c: Fix includes.
9430         * cli/cli-interp.c: Fix includes.
9431
9432 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9433
9434         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9435         for padding.
9436
9437 2019-01-16  Tom Tromey  <tom@tromey.com>
9438
9439         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9440         earlier.
9441         (struct objfile) <msymbols_range>: Move from top level.
9442         <msymbols>: New method.
9443         (class objfile_msymbols): Remove.
9444         * symtab.c (default_collect_symbol_completion_matches_break_on):
9445         Update.
9446         * symmisc.c (dump_msymbols): Update.
9447         * stabsread.c (scan_file_globals): Update.
9448         * objc-lang.c (info_selectors_command, info_classes_command)
9449         (find_methods): Update.
9450         * minsyms.c (find_solib_trampoline_target): Update.
9451         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9452         * coffread.c (coff_symfile_read): Update.
9453         * ada-lang.c (ada_lookup_simple_minsym)
9454         (ada_collect_symbol_completion_matches): Update.
9455
9456 2019-01-16  Tom Tromey  <tom@tromey.com>
9457
9458         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9459         type.  Remove no-argument constructor.
9460         <iterator::operator++>: Simplify.
9461         <begin>: Update.
9462         <end>: Use minimal_symbol_count.
9463
9464 2019-01-16  Tom Tromey  <tom@tromey.com>
9465
9466         * objfiles.h (struct objfile) <psymtabs>: New method.
9467         (class objfile_psymtabs): Remove.
9468         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9469         typedef.
9470         <range>: New method.
9471         (require_partial_symbols): Change return type.
9472         * psymtab.c (require_partial_symbols)
9473         (psym_expand_symtabs_matching): Update.
9474         * mdebugread.c (parse_partial_symbols): Update.
9475         * dbxread.c (dbx_end_psymtab): Update.
9476
9477 2019-01-15  Tom Tromey  <tom@tromey.com>
9478
9479         * symtab.c (lookup_objfile_from_block)
9480         (lookup_symbol_in_objfile_symtabs)
9481         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9482         (find_line_symtab, info_sources_command)
9483         (default_collect_symbol_completion_matches_break_on)
9484         (make_source_files_completion_list): Update.
9485         * symmisc.c (print_objfile_statistics, dump_objfile)
9486         (maintenance_print_symbols, maintenance_info_symtabs)
9487         (maintenance_check_symtabs, maintenance_info_line_tables):
9488         Update.
9489         * source.c (select_source_symtab)
9490         (forget_cached_source_info_for_objfile): Update.
9491         * objfiles.h (class objfile_compunits): Remove.
9492         (struct objfile) <compunits_range>: New typedef.
9493         (compunits): New method.
9494         * objfiles.c (objfile_relocate1): Update.
9495         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9496         * maint.c (count_symtabs_and_blocks): Update.
9497         * linespec.c (iterate_over_all_matching_symtabs): Update.
9498         * cp-support.c (add_symbol_overload_list_qualified): Update.
9499         * coffread.c (coff_symtab_read): Update.
9500         * ada-lang.c (add_nonlocal_symbols)
9501         (ada_collect_symbol_completion_matches)
9502         (ada_add_global_exceptions): Update.
9503
9504 2019-01-15  Tom Tromey  <tom@tromey.com>
9505
9506         * progspace.h (program_space) <objfiles_safe_range>: New
9507         typedef.
9508         <objfiles_safe>: New method.
9509         * objfiles.h (class all_objfiles_safe): Remove.
9510         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9511         * jit.c (jit_inferior_exit_hook): Update.
9512
9513 2019-01-17  Tom Tromey  <tom@tromey.com>
9514
9515         * progspace.h (program_space) <objfiles_range>: New typedef.
9516         <objfiles>: New method.
9517         <objfiles_head>: Rename from objfiles.
9518         (object_files): Update.
9519         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9520         * guile/scm-pretty-print.c
9521         (ppscm_find_pretty_printer_from_objfiles): Update.
9522         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9523         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9524         Update.
9525         * python/py-progspace.c (pspy_get_objfiles): Update.
9526         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9527         Update.
9528         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9529         (objfpy_lookup_objfile_by_build_id): Update.
9530         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9531         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9532         Update.
9533         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9534         (expand_symtab_containing_pc, lookup_objfile_from_block)
9535         (lookup_static_symbol, basic_lookup_transparent_type)
9536         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9537         (find_line_symtab, info_sources_command)
9538         (default_collect_symbol_completion_matches_break_on)
9539         (make_source_files_completion_list, find_main_name): Update.
9540         * symmisc.c (print_symbol_bcache_statistics)
9541         (print_objfile_statistics, maintenance_print_symbols)
9542         (maintenance_print_msymbols, maintenance_print_objfiles)
9543         (maintenance_info_symtabs, maintenance_check_symtabs)
9544         (maintenance_expand_symtabs, maintenance_info_line_tables):
9545         Update.
9546         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9547         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9548         (map_overlay_command, unmap_overlay_command)
9549         (simple_overlay_update, expand_symtabs_matching)
9550         (map_symbol_filenames): Update.
9551         * symfile-debug.c (set_debug_symfile): Update.
9552         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9553         Update.
9554         * source.c (select_source_symtab, forget_cached_source_info):
9555         Update.
9556         * solib.c (solib_read_symbols): Update.
9557         * solib-spu.c (append_ocl_sos): Update.
9558         * psymtab.c (maintenance_print_psymbols)
9559         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9560         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9561         * printcmd.c (info_symbol_command): Update.
9562         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9563         Update.
9564         * objfiles.h (class all_objfiles): Remove.
9565         * objfiles.c (have_partial_symbols, have_full_symbols)
9566         (have_minimal_symbols, qsort_cmp, update_section_map)
9567         (shared_objfile_contains_address_p)
9568         (default_iterate_over_objfiles_in_search_order): Update.
9569         * objc-lang.c (info_selectors_command, info_classes_command)
9570         (find_methods): Update.
9571         * minsyms.c (find_solib_trampoline_target): Update.
9572         * maint.c (maintenance_info_sections)
9573         (maintenance_translate_address, count_symtabs_and_blocks):
9574         Update.
9575         * main.c (captured_main_1): Update.
9576         * linux-thread-db.c (try_thread_db_load_from_pdir)
9577         (has_libpthread): Update.
9578         * linespec.c (iterate_over_all_matching_symtabs)
9579         (search_minsyms_for_name): Update.
9580         * jit.c (jit_find_objf_with_entry_addr): Update.
9581         * hppa-tdep.c (find_unwind_entry)
9582         (hppa_lookup_stub_minimal_symbol): Update.
9583         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9584         Update.
9585         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9586         (elf_gnu_ifunc_resolve_by_got): Update.
9587         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9588         * dwarf-index-write.c (save_gdb_index_command): Update.
9589         * cp-support.c (add_symbol_overload_list_qualified): Update.
9590         * breakpoint.c (create_overlay_event_breakpoint)
9591         (create_longjmp_master_breakpoint)
9592         (create_std_terminate_master_breakpoint)
9593         (create_exception_master_breakpoint): Update.
9594         * blockframe.c (find_pc_partial_function): Update.
9595         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9596         (ada_collect_symbol_completion_matches)
9597         (ada_add_global_exceptions): Update.
9598
9599 2019-01-17  Tom Tromey  <tom@tromey.com>
9600
9601         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9602         declare VEC.
9603         (solib_target_parse_libraries): Change return type.
9604         (library_list_start_segment, library_list_start_section)
9605         (library_list_end_library, library_list_start_library); Update.
9606         (solib_target_free_library_list): Remove.
9607         (solib_target_parse_libraries): Remove cleanup.  Change return
9608         type.
9609         (solib_target_current_sos): Update.
9610
9611 2019-01-17  Tom Tromey  <tromey@bapiya>
9612
9613         * valprint.c: Replace "the the" with "the".
9614         * symtab.c: Replace "the the" with "the".
9615         * solib.c: Replace "the the" with "the".
9616         * solib-dsbt.c: Replace "the the" with "the".
9617         * linespec.c: Replace "the the" with "the".
9618         * dwarf2loc.h: Replace "the the" with "the".
9619         * amd64-windows-tdep.c: Replace "the the" with "the".
9620         * aarch64-tdep.c: Replace "the the" with "the".
9621
9622 2019-01-16  Keith Seitz  <keiths@redhat.com>
9623
9624         PR gdb/23773
9625         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9626         <builder>: Rename to ..
9627         <m_builder>: ... this and make private.
9628         (dwarf2_cu::get_builder): New method.  Change all users of
9629         `builder' to use this method.
9630         (dwarf2_start_symtab): Move to ...
9631         (dwarf2_cu::start_symtab): ... here.  Update all callers
9632         (setup_type_unit_groups): Move to ...
9633         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9634         callers.
9635         (dwarf2_cu::reset_builder): New method.
9636         (process_full_compunit, process_full_type_unit): Use
9637         dwarf2_cu::reset_builder.
9638         (follow_die_offset): Record the ancestor CU if it is different
9639         from the followed DIE's CU.
9640         (follow_die_sig_1): Likewise.
9641
9642 2019-01-15  Tom Tromey  <tom@tromey.com>
9643
9644         * remote.c (class remote_state) <buf>: Now a char_vector.
9645         <buf_size>: Remove.
9646         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9647         parameter.
9648         (remote_target::getpkt_or_notif_sane_1)
9649         (remote_target::getpkt_sane)
9650         (remote_target::getpkt_or_notif_sane): Likewise.
9651         (class remote_target) <putpkt>: New overload.
9652         (remote_target::read_frame): Change type of "buf_p".  Remove
9653         sizeof_p parameter.
9654         (packet_ok): New overload.
9655         (packet_check_result): New overload.
9656         Update all uses.
9657
9658 2019-01-14  Tom Tromey  <tom@tromey.com>
9659
9660         * remote-notif.c (handle_notification, remote_notif_ack)
9661         (remote_notif_parse): Make "buf" const.
9662         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9663         const.
9664         (remote_notif_parse, remote_notif_ack, handle_notification):
9665         Likewise.
9666         * remote.c (remote_notif_stop_parse): Make "buf" const.
9667         (remote_target::remote_parse_stop_reply): Make "buf" const.
9668         (remote_notif_stop_ack): Make "buf" const.
9669
9670 2019-01-14  Tom Tromey  <tom@tromey.com>
9671
9672         * remote.c (remote_console_output): Make parameter const.
9673
9674 2019-01-14  Tom Tromey  <tom@tromey.com>
9675
9676         * target-debug.h (target_debug_print_signals): Constify.
9677         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9678         * procfs.c (procfs_target::pass_signals): Update.
9679         * linux-nat.c (linux_nat_target::pass_signals): Update.
9680         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9681         * target-delegates.c: Rebuild.
9682         * remote.c (remote_target::program_signals): Update.
9683         (remote_target::pass_signals): Update.
9684         * target.c (target_pass_signals): Constify argument.
9685         (target_program_signals): Likewise.
9686         * target.h (struct target_ops) <pass_signals, program_signals>:
9687         Constify argument.
9688         (target_pass_signals, target_program_signals): Constify argument.
9689
9690 2019-01-14  Tom Tromey  <tom@tromey.com>
9691
9692         PR tui/28819:
9693         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9694
9695 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9696
9697         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9698         field.
9699         * rs6000-tdep.c: Include reggroups.h.
9700         (IS_V_ALIAS_PSEUDOREG): Define.
9701         (rs6000_register_name): Return names for the "vX" aliases.
9702         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9703         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9704         aliases.  Call default_register_reggroup_p for all other
9705         pseudo-registers.
9706         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9707         New functions.
9708         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9709         Handle "vX" aliases.
9710         (v_alias_pseudo_register_collect): New function.
9711         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9712         (rs6000_gdbarch_init): Initialize "vX" aliases as
9713         pseudo-registers.  Restore registration of
9714         rs6000_pseudo_register_reggroup_p with
9715         set_tdesc_pseudo_register_reggroup_p.
9716
9717 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9718
9719         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9720         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9721         set_gdbarch_num_pseudo_regs.
9722
9723 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9724
9725         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9726         Remove arg prefixname, add do_set and do_show.
9727         Add member functions set_list and show_list.
9728         * cli/cli-style.c (class cli_style_option): Update accordingly.
9729         (style_set_list): Move to file scope.
9730         (style_show_list): Likewise.
9731         (set_style): Call help_list.
9732         (show_style): Call cmd_show_list.
9733         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9734         Update to use the new macro.
9735
9736 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9737
9738         * ada-lang.c (_initialize_ada_language): Expand the help text
9739         for the "catch exception" command.
9740
9741 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9742
9743         * symtab.c (matching_obj_sections): Initialize obj,
9744         declare it closer to its usage.
9745
9746 2019-01-10  Tom Tromey  <tom@tromey.com>
9747
9748         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9749         (basic_inf_threads_range): Remove.
9750         (inf_threads_range, inf_non_exited_threads_range)
9751         (safe_inf_threads_range): Use next_adapter.
9752
9753 2019-01-10  Keith Seitz  <keiths@redhat.com>
9754
9755         PR gdb/23712
9756         PR symtab/23010
9757         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9758         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9759
9760 2019-01-10  Keith Seitz  <keiths@redhat.com>
9761
9762         PR gdb/23712
9763         PR symtab/23010
9764         * dictionary.c (pending_to_vector): Remove.
9765         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9766         Remove _1 suffix, replacing functions of the same name.  Update
9767         all callers.
9768         (dict_create_hashed, dict_create_hashed_expandable)
9769         (dict_create_linear, dict_create_linear_expandable, dict_free)
9770         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9771         Make functions static.
9772
9773 2019-01-10  Keith Seitz  <keiths@redhat.com>
9774
9775         PR gdb/23712
9776         PR symtab/23010
9777         * dictionary.h (struct dictionary): Replace declaration with
9778         multidictionary.
9779         (dict_create_hashed, dict_create_hashed_expandable)
9780         (dict_create_linear, dict_create_linear_expandable)
9781         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9782         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9783         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9784         taking multidictionary argument.
9785         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9786         * block.h (struct block) <dict>: Change to multidictionary
9787         and rename `multidict'.
9788         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9789         symmisc.c: Update all dictionary references to multidictionary.
9790
9791 2019-01-10  Keith Seitz  <keiths@redhat.com>
9792
9793         PR gdb/23712
9794         PR symtab/23010
9795         * dictionary.c: Include unordered_map.
9796         (pending_to_vector): New function.
9797         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9798         Rewrite the non-"_1" functions to take vector instead
9799         of linked list.
9800         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9801         "new" _1 versions of the same name.
9802         (multidictionary): Define.
9803         (std::hash<enum language): New definition.
9804         (collate_pending_symbols_by_language, mdict_create_hashed)
9805         (mdict_create_hashed_expandable, mdict_create_linear)
9806         (mdict_create_linear_expandable, mdict_free)
9807         (find_language_dictionary, create_new_language_dictionary)
9808         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9809         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9810         (mdict_size, mdict_empty): New functions.
9811         * dictionary.h (mdict_iterator): Define.
9812
9813 2019-01-10  Pedro Alves  <palves@redhat.com>
9814
9815         * breakpoint.c (read_uploaded_action)
9816         (create_tracepoint_from_upload): Adjust to use
9817         gdb::unique_xmalloc_ptr.
9818         * ctf.c (ctf_write_uploaded_tp):
9819         (SET_ARRAY_FIELD): Use emplace_back.
9820         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9821         * tracefile-tfile.c (tfile_write_uploaded_tp):
9822         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9823         gdb::unique_xmalloc_ptr.
9824         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9825         at_string, cond_string, cmd_strings>: Replace char pointers
9826         with gdb::unique_xmalloc_ptr.
9827
9828 2019-01-10  Pedro Alves  <palves@redhat.com>
9829
9830         * solib-target.c (library_list_start_library): Don't xstrdup name.
9831
9832 2019-01-10  Pedro Alves  <palves@redhat.com>
9833
9834         * mdebugread.c (parse_partial_symbols): Use
9835         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9836
9837 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9838
9839         * linux-fork.c (scoped_switch_fork_info)
9840         <~scoped_switch_fork_info>: Fix incorrect variable name.
9841
9842 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9843
9844         * linux-fork.c (scoped_switch_fork_info)
9845         <scoped_switch_fork_info>: Make explicit.
9846         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9847
9848 2019-01-10  Tom Tromey  <tom@tromey.com>
9849
9850         * objfiles.h (objfile::reset_psymtabs): Update.
9851         * objfiles.c (objfile::objfile): Update.
9852         * psymtab.h (psymtab_storage::obstack): Update.
9853         (psymtab_storage::m_obstack): Use gdb::optional.
9854         (class psymtab_storage): Update comment.  Remove objfile
9855         parameter.
9856         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9857
9858 2019-01-10  Tom Tromey  <tom@tromey.com>
9859
9860         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9861         <free_psymtabs>: Now private.
9862         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9863         (allocate_psymtab): Use new method.
9864
9865 2019-01-10  Tom Tromey  <tom@tromey.com>
9866
9867         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9868         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9869         * mdebugread.c (parse_partial_symbols): Use
9870         allocate_dependencies.
9871         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9872         allocate_dependencies.
9873         (process_psymtab_comp_unit_reader)
9874         (build_type_psymtab_dependencies): Likewise.
9875         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9876
9877 2019-01-10  Tom Tromey  <tom@tromey.com>
9878
9879         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9880         PSYMBOL_SET_LANGUAGE.
9881         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9882
9883 2019-01-10  Tom Tromey  <tom@tromey.com>
9884
9885         * psymtab.h (psymtab_storage::obstack): New method.
9886         <m_obstack>: Rename from obstack; now private.
9887         * psymtab.c (psymtab_storage): Update.
9888         * dwarf2read.c (create_addrmap_from_index)
9889         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9890         Update.
9891
9892 2019-01-10  Tom Tromey  <tom@tromey.com>
9893
9894         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9895         * objfiles.h (objfile::reset_psymtabs): New method.
9896
9897 2019-01-10  Tom Tromey  <tom@tromey.com>
9898
9899         * symmisc.c (print_symbol_bcache_statistics): Update.
9900         (print_objfile_statistics): Update.
9901         * symfile.c (reread_symbols): Update.
9902         * psymtab.h (class psymtab_storage): New.
9903         * psymtab.c (psymtab_storage): New constructor.
9904         (~psymtab_storage): New destructor.
9905         (require_partial_symbols): Update.
9906         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9907         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9908         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9909         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9910         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9911         (start_psymtab_common, end_psymtab_common)
9912         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9913         (allocate_psymtab): Update.
9914         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9915         Update.
9916         (dump_psymtab_addrmap, maintenance_print_psymbols)
9917         (maintenance_check_psymtabs): Update.
9918         (class objfile_psymtabs): Move to objfiles.h.
9919         * psympriv.h (discard_psymtab): Now inline.
9920         (psymtab_discarder::psymtab_discarder): Update.
9921         (psymtab_discarder::~psymtab_discarder): Update.
9922         (ALL_OBJFILE_PSYMTABS): Rewrite.
9923         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9924         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9925         Remove fields.
9926         <partial_symtabs>: New field.
9927         (class objfile_psymtabs): Move from psymtab.h.  Update.
9928         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9929         psymbol_cache.
9930         (objfile::~objfile): Don't destroy psymbol_cache.
9931         * mdebugread.c (parse_partial_symbols): Update.
9932         * dwarf2read.c (create_addrmap_from_index)
9933         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9934         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9935         (add_partial_subprogram, dwarf2_ranges_read): Update.
9936         * dwarf-index-write.c (write_address_map)
9937         (write_one_signatured_type, recursively_write_psymbols)
9938         (class debug_names, class debug_names, write_psymtabs_to_index):
9939         Update.
9940
9941 2019-01-10  Tom Tromey  <tom@tromey.com>
9942
9943         * symtab.h (SYMBOL_SET_NAMES): Update.
9944         (symbol_set_names): Update.
9945         (MSYMBOL_SET_NAMES): Update.
9946         * symtab.c (symbol_set_names): Change argument to be an
9947         objfile_per_bfd_storage.
9948         * psymtab.c (add_psymbol_to_bcache): Update.
9949         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9950
9951 2019-01-10  Tom Tromey  <tom@tromey.com>
9952
9953         * symtab.c (create_demangled_names_hash): Change argument to be an
9954         objfile_per_bfd_storage.
9955         (symbol_set_names): Update.
9956
9957 2019-01-10  Tom Tromey  <tom@tromey.com>
9958
9959         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9960         init_psymbol_list.
9961         * psymtab.c (init_psymbol_list): Do nothing if already called.
9962         * psympriv.h (init_psymbol_list): Add comment.
9963         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9964         init_psymbol_list.
9965         * dbxread.c (dbx_symfile_read): Unconditionally call
9966         init_psymbol_list.
9967
9968 2019-01-10  Tom Tromey  <tom@tromey.com>
9969
9970         * xcoffread.c (scan_xcoff_symtab): Update.
9971         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9972         "where".
9973         * mdebugread.c (parse_partial_symbols)
9974         (handle_psymbol_enumerators): Update.
9975         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9976         * dbxread.c (read_dbx_symtab): Update.
9977         * psympriv.h (psymbol_placement): New enum.
9978         (add_psymbol_to_list): Update.
9979
9980 2019-01-10  Tom Tromey  <tom@tromey.com>
9981
9982         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9983         static_psymbols parameters.
9984         (scan_xcoff_symtab): Update.
9985         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9986         static_psymbols parameters.
9987         * psympriv.h (start_psymtab_common): Update.
9988         * mdebugread.c (parse_partial_symbols): Update.
9989         * dwarf2read.c (create_partial_symtab): Update.
9990         * dbxread.c (read_dbx_symtab): Update.
9991         (start_psymtab): Remove global_psymbols and static_psymbols
9992         parameters.
9993
9994 2019-01-10  Tom Tromey  <tom@tromey.com>
9995
9996         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9997         * psymtab.c (allocate_psymtab): Add comment.
9998         * psympriv.h (allocate_psymtab): Add comment.
9999         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
10000         initializations.
10001         * dbxread.c (dbx_end_psymtab): Remove some initializations.
10002
10003 2019-01-10  Tom Tromey  <tom@tromey.com>
10004
10005         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10006         Don't declare.
10007         * mipsread.c: Include mdebugread.h.
10008         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10009         Declare.
10010         * elfread.c: Include mdebugread.h.
10011
10012 2019-01-09  Tom Tromey  <tom@tromey.com>
10013
10014         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
10015         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
10016         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
10017         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
10018         (psym_lookup_symbol, psym_find_last_source_symtab)
10019         (psym_forget_cached_source_info, psym_print_stats)
10020         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
10021         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
10022         (psym_map_matching_symbols, psym_expand_symtabs_matching)
10023         (psym_find_compunit_symtab_by_address)
10024         (maintenance_print_psymbols, maintenance_info_psymtabs)
10025         (maintenance_check_psymtabs): Use ranged for.
10026         * psymtab.h (class objfile_psymtabs): New.
10027         (require_partial_symbols): Return objfile_psymtabs.
10028         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
10029
10030 2019-01-09  Tom Tromey  <tom@tromey.com>
10031
10032         * symfile.c (overlay_invalidate_all, find_pc_overlay)
10033         (find_pc_mapped_section, list_overlays_command)
10034         (map_overlay_command, unmap_overlay_command)
10035         (simple_overlay_update): Use all_objfiles.
10036         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
10037         * printcmd.c (info_symbol_command): Use all_objfiles.
10038         * objfiles.h (ALL_OBJSECTIONS): Remove.
10039         * maint.c (maintenance_translate_address): Use all_objfiles.
10040         * gcore.c (gcore_create_callback): Use all_objfiles.
10041         (objfile_find_memory_regions): Likewise.
10042
10043 2019-01-09  Tom Tromey  <tom@tromey.com>
10044
10045         * symtab.c (find_line_symtab, info_sources_command)
10046         (make_source_files_completion_list): Use objfile_compunits.
10047         * source.c (select_source_symtab): Use objfile_compunits.
10048         * objfiles.h (struct objfile): Update comment.
10049         (ALL_OBJFILES): Remove.
10050         (ALL_FILETABS): Remove.
10051         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
10052         objfile_compunits.
10053
10054 2019-01-09  Tom Tromey  <tom@tromey.com>
10055
10056         * symmisc.c (print_objfile_statistics, dump_objfile)
10057         (maintenance_print_symbols): Use compunit_filetabs.
10058         * source.c (forget_cached_source_info_for_objfile): Use
10059         compunit_filetabs.
10060         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
10061         (ALL_FILETABS): Use compunit_filetabs.
10062         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
10063         * coffread.c (coff_symtab_read): Use compunit_filetabs.
10064
10065 2019-01-09  Tom Tromey  <tom@tromey.com>
10066
10067         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
10068         (compunit_filetabs): New.
10069         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
10070         compunit_filetabs.
10071         (info_sources_command, make_source_files_completion_list): Remove
10072         declaration.
10073         * symmisc.c (print_objfile_statistics, dump_objfile)
10074         (maintenance_print_symbols): Remove declaration.
10075         (maintenance_info_symtabs): Use compunit_filetabs.
10076         (maintenance_info_line_tables): Likewise.
10077         * source.c (select_source_symtab): Change local variable name.
10078         (forget_cached_source_info_for_objfile): Remove declaration.
10079         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10080         * objfiles.c (objfile_relocate1): Remove declaration.
10081         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10082         declaration.
10083         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10084         * coffread.c (coff_symtab_read): Remove declaration.
10085         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10086         compunit_filetabs.
10087
10088 2019-01-09  Tom Tromey  <tom@tromey.com>
10089
10090         * symtab.c (lookup_objfile_from_block)
10091         (find_pc_sect_compunit_symtab, search_symbols)
10092         (default_collect_symbol_completion_matches_break_on): Use
10093         objfile_compunits.
10094         * objfiles.h (ALL_COMPUNITS): Remove.
10095         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10096         * cp-support.c (add_symbol_overload_list_qualified): Use
10097         objfile_compunits.
10098         * ada-lang.c (ada_collect_symbol_completion_matches)
10099         (ada_add_global_exceptions): Use objfile_compunits.
10100
10101 2019-01-09  Tom Tromey  <tom@tromey.com>
10102
10103         * source.c (select_source_symtab)
10104         (forget_cached_source_info_for_objfile): Remove declaration.
10105         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10106         declaration.
10107         * maint.c (count_symtabs_and_blocks): Remove declaration.
10108         * cp-support.c (add_symbol_overload_list_qualified): Remove
10109         declaration.
10110         * coffread.c (coff_symtab_read): Remove declaration.
10111         * symtab.c (lookup_symbol_in_objfile_symtabs)
10112         (basic_lookup_transparent_type_1): Use objfile_compunits.
10113         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10114         (info_sources_command, search_symbols)
10115         (default_collect_symbol_completion_matches_break_on)
10116         (make_source_files_completion_list): Remove declaration.
10117         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10118         (ada_collect_symbol_completion_matches)
10119         (ada_add_global_exceptions): Remove declaration.
10120         * linespec.c (iterate_over_all_matching_symtabs): Use
10121         objfile_compunits.
10122         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10123         (class objfile_compunits): New.
10124         (ALL_COMPUNITS): Use objfile_compunits.
10125         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10126         (maintenance_check_symtabs, maintenance_info_line_tables): Use
10127         objfile_compunits.
10128         * objfiles.c (objfile_relocate1): Use objfile_compunits.
10129
10130 2019-01-09  Tom Tromey  <tom@tromey.com>
10131
10132         * symtab.c (search_symbols)
10133         (default_collect_symbol_completion_matches_break_on): Use
10134         objfile_msymbols.
10135         * ada-lang.c (ada_lookup_simple_minsym)
10136         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10137         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10138         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10139         objfile_msymbols.
10140         * coffread.c (coff_symfile_read): Use objfile_msymbols.
10141         * symmisc.c (dump_msymbols): Use objfile_msymbols.
10142         * objc-lang.c (find_methods): Use objfile_msymbols.
10143         (info_selectors_command, info_classes_command): Likewise.
10144         * stabsread.c (scan_file_globals): Use objfile_msymbols.
10145         * objfiles.h (class objfile_msymbols): New.
10146         (ALL_OBJFILE_MSYMBOLS): Remove.
10147         (ALL_MSYMBOLS): Remove.
10148
10149 2019-01-09  Tom Tromey  <tom@tromey.com>
10150
10151         * common/next-iterator.h (next_adapter): Add Iterator template
10152         parameter.
10153         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10154         (class all_objfiles_safe): New.
10155         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10156         * objfiles.c (put_objfile_before): Update comment.
10157         (add_separate_debug_objfile): Likewise.
10158         (free_all_objfiles): Use all_objfiles_safe.
10159         (objfile_purge_solibs): Likewise.
10160
10161 2019-01-09  Tom Tromey  <tom@tromey.com>
10162
10163         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10164         (expand_symtab_containing_pc, lookup_static_symbol)
10165         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10166         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10167         all_objfiles.
10168         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10169         * breakpoint.c (create_overlay_event_breakpoint)
10170         (create_longjmp_master_breakpoint)
10171         (create_std_terminate_master_breakpoint)
10172         (create_exception_master_breakpoint): Use all_objfiles.
10173         * linux-thread-db.c (try_thread_db_load_from_pdir)
10174         (has_libpthread): Use all_objfiles.
10175         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10176         * linespec.c (iterate_over_all_matching_symtabs)
10177         (search_minsyms_for_name): Use all_objfiles.
10178         * maint.c (maintenance_info_sections): Use all_objfiles.
10179         * main.c (captured_main_1): Use all_objfiles.
10180         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10181         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10182         * guile/scm-pretty-print.c
10183         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10184         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10185         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10186         (maintenance_print_msymbols): Use all_objfiles.
10187         * source.c (select_source_symtab): Use all_objfiles.
10188         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10189         * symfile.c (remove_symbol_file_command)
10190         (expand_symtabs_matching, map_symbol_filenames): Use
10191         all_objfiles.
10192         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10193         all_objfiles.
10194         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10195         * objc-lang.c (find_methods): Use all_objfiles.
10196         * objfiles.c (have_partial_symbols, have_full_symbols)
10197         (have_minimal_symbols, qsort_cmp)
10198         (default_iterate_over_objfiles_in_search_order): Use
10199         all_objfiles.
10200         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10201         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10202         (maintenance_check_psymtabs): Use all_objfiles.
10203         (ALL_PSYMTABS): Remove.
10204         * compile/compile-object-run.c (do_module_cleanup): Use
10205         all_objfiles.
10206         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10207         * cp-support.c (add_symbol_overload_list_qualified): Use
10208         all_objfiles.
10209         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10210         Use all_objfiles.
10211         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10212         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10213         all_objfiles.
10214         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10215         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10216         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10217         Uses all_objfiles.
10218         * solib.c (solib_read_symbols): Use all_objfiles
10219
10220 2019-01-09  Tom Tromey  <tom@tromey.com>
10221
10222         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10223         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10224         all_objfiles.
10225         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10226         * symmisc.c (print_symbol_bcache_statistics)
10227         (print_objfile_statistics, maintenance_print_objfiles)
10228         (maintenance_info_symtabs, maintenance_check_symtabs)
10229         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10230         all_objfiles.
10231         * source.c (forget_cached_source_info): Use all_objfiles.
10232         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10233         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10234         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10235         * objfiles.c (update_section_map): Use all_objfiles.
10236         (shared_objfile_contains_address_p): Likewise.
10237         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10238         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10239
10240 2019-01-09  Tom Tromey  <tom@tromey.com>
10241
10242         * common/next-iterator.h: New file.
10243         * objfiles.h (class all_objfiles): New.
10244         (struct objfile_iterator): New.
10245
10246 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10247
10248         * NEWS: Move the description of the changed "frame", "select-frame",
10249          and "info frame" commands to the Changed commands section.
10250
10251 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10252
10253         * gdbtypes.c (check_stub_method_group): Remove handling of old
10254         mangling schemes.
10255         * linespec.c (find_methods): Likewise.
10256         * stabsread.c (read_member_functions): Likewise.
10257         * valops.c (search_struct_method): Likewise.
10258         (value_struct_elt_for_reference): Likewise.
10259         * NEWS: Mention this change.
10260
10261 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10262
10263         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10264         print_source_lines.
10265         * source.c (print_source_lines_base): Update line number check.
10266         (print_source_lines): New function.
10267         (source_lines_range::source_lines_range): New function.
10268         * source.h (class source_lines_range): New class.
10269         (print_source_lines): New declaration.
10270
10271 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10272
10273         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10274
10275 2019-01-08  Tom Tromey  <tom@tromey.com>
10276             Simon Marchi  <simon.marchi@ericsson.com>
10277
10278         PR gdb/24060
10279         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10280         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10281         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10282         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10283         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10284         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10285
10286 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10287
10288         * source.c (select_source_symtab): Move header comment to
10289         declaration in source.h.
10290         (forget_cached_source_info_for_objfile): Likewise.
10291         (forget_cached_source_info): Likewise.
10292         (identify_source_line): Likewise.
10293         * source.h (identify_source_line): Move declaration from symtab.h
10294         and add comment from source.c
10295         (print_source_lines): Likewise.
10296         (forget_cached_source_info_for_objfile): Likewise.
10297         (forget_cached_source_info): Likewise.
10298         (select_source_symtab): Likewise.
10299         (enum print_source_lines_flag): Move definition from symtab.h.
10300         * symtab.h (identify_source_line): Move declaration to source.h.
10301         (print_source_lines): Likewise.
10302         (forget_cached_source_info_for_objfile): Likewise.
10303         (forget_cached_source_info): Likewise.
10304         (select_source_symtab): Likewise.
10305         (enum print_source_lines_flag): Move definition to source.h.
10306         * tui/tui-hooks.c: Add 'source.h' include.
10307
10308 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10309
10310         * source.c (print_source_lines_base): Handle requests to print
10311         reverse line number sequences, and guard against empty lines
10312         string.
10313
10314 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10315
10316         * source.c (print_source_lines_base): Fix skip of '\r' if next
10317         character is '\n'.
10318
10319 2019-01-06  Tom Tromey  <tom@tromey.com>
10320
10321         * c-exp.y (struct c_parse_state) <macro_original_text,
10322         expansion_obstack>: New member.
10323         (macro_original_text, expansion_obstack): Remove globals.
10324         (scan_macro_expansion, scanning_macro_expansion)
10325         (finished_macro_expansion): Update.
10326         (scan_macro_cleanup): Remove.
10327         (yylex, c_parse): Update.
10328
10329 2019-01-06  Tom Tromey  <tom@tromey.com>
10330
10331         * c-exp.y (struct c_parse_state) <strings>: New member.
10332         (operator_stoken): Update.
10333
10334 2019-01-06  Tom Tromey  <tom@tromey.com>
10335
10336         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10337         (union type_stack_elt) <typelist_val>: Now a pointer to
10338         std::vector.
10339         (type_stack_cleanup): Don't declare.
10340         (push_typelist): Update.
10341         * parse.c (pop_typelist): Return a std::vector.
10342         (push_typelist): Take a std::vector.
10343         (follow_types): Update.  Do not free args.
10344         (type_stack_cleanup): Remove.
10345         * c-exp.y (struct c_parse_state): New.
10346         (cpstate): New global.
10347         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10348         (nonempty_typelist): Update.
10349         (func_mod): Create a new vector.
10350         (c_parse): Create a c_parse_state.
10351         (check_parameter_typelist): Do not delete params.
10352         (function_method): Update.  Do not delete type_list.
10353
10354 2019-01-06  Tom Tromey  <tom@tromey.com>
10355
10356         PR gdb/28155:
10357         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10358         check_typedef.
10359         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10360         (print_return_value): Likewise.
10361
10362 2019-01-05  Tom Tromey  <tom@tromey.com>
10363
10364         * contrib/cleanup_check.py: Remove.
10365         * contrib/gcc-with-excheck: Remove.
10366         * contrib/exsummary.py: Remove.
10367         * contrib/excheck.py: Remove.
10368
10369 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10370
10371         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10372         NULL. Initialize tpprev to NULL instead of assigning it
10373         to NULL on the next statement.
10374         * windows-nat.c (windows_delete_thread): Remove check for
10375         main_thread_id before printing thread exit notifications.
10376         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10377         Remove thread ID check against main_thread_id.
10378         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10379         windows_delete_thread.
10380         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10381
10382 2019-01-04  Tom Tromey  <tom@tromey.com>
10383
10384         * compile/compile.c (_initialize_compile): Use upper case for
10385         metasyntactic variables.
10386         * symmisc.c (_initialize_symmisc): Use upper case for
10387         metasyntactic variables.
10388         * psymtab.c (_initialize_psymtab): Use upper case for
10389         metasyntactic variables.
10390         * demangle.c (demangle_command): Use upper case for metasyntactic
10391         variables.
10392         (_initialize_demangler): Likewise.
10393         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10394         variables.
10395
10396 2019-01-03  Tom Tromey  <tom@tromey.com>
10397
10398         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10399
10400 2019-01-03  Tom Tromey  <tom@tromey.com>
10401
10402         * python/py-symtab.c (salpy_str): Update.
10403         (struct salpy_sal_object) <symtab>: Now a PyObject.
10404         (salpy_dealloc): Update.
10405         (del_objfile_sal): Use gdbpy_ref.
10406
10407 2019-01-03  Tom Tromey  <tom@tromey.com>
10408
10409         * python/py-type.c (convert_field): Use new_reference.  Return
10410         gdbpy_ref.
10411         (make_fielditem): Return gdbpy_ref.
10412         (typy_fields): Update.
10413         (typy_getitem): Update.
10414         (field_name): Return gdbpy_ref.  Use new_reference.
10415         (typy_iterator_iternext): Update.
10416
10417 2019-01-03  Tom Tromey  <tom@tromey.com>
10418
10419         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10420
10421 2019-01-03  Tom Tromey  <tom@tromey.com>
10422
10423         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10424         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10425         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10426         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10427         (pspy_set_type_printers): Likewise.
10428         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10429         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10430         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10431         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10432         (objfpy_set_type_printers): Likewise.
10433
10434 2019-01-03  Tom Tromey  <tom@tromey.com>
10435
10436         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10437         (gdbpy_print_stack): Use gdbpy_err_fetch.
10438         * python/python-internal.h (class gdbpy_err_fetch): New class.
10439         (class gdbpy_enter) <m_error_type, m_error_value,
10440         m_error_traceback>: Remove.
10441         <m_error>: New member.
10442         (gdbpy_exception_to_string): Don't declare.
10443         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10444         * python/py-value.c (convert_value_from_python): Use
10445         gdbpy_err_fetch.
10446         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10447         gdbpy_exception_to_string.
10448         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10449         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10450         gdbpy_err_fetch.
10451
10452 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10453
10454         * linux-nat.c (delete_lwp_cleanup): Delete.
10455         (struct lwp_deleter): New struct.
10456         (lwp_info_up): New typedef.
10457         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10458         lwp_info_up.
10459
10460 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10461
10462         * linux-fork.c (class scoped_switch_fork_info): New class.
10463         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10464
10465 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10466
10467         * valops.c (find_overload_match): Remove use of null_cleanup, and
10468         calls to do_cleanups.
10469
10470 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10471
10472         * compile/compile-cplus-types.c
10473         (compile_cplus_instance::decl_name): Handle changes to
10474         cp_func_name.
10475         * cp-support.c (cp_func_name): Update header comment, update
10476         return type.
10477         * cp-support.h (cp_func_name): Update return type in declaration.
10478         * valops.c (find_overload_match): Move temp_func local to top
10479         level of function and change its type.  Use temp_func to hold and
10480         delete temporary string obtained from cp_func_name.
10481
10482 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10483
10484         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10485         gdb::char_vector, remove cleanup, and update uses of `msg`.
10486
10487 2019-01-03  Jim Wilson  <jimw@sifive.com>
10488
10489         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10490
10491 2019-01-02  Tom Tromey  <tom@tromey.com>
10492
10493         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10494         (tdesc_parse_xml): Remove cleanups.
10495         * target-descriptions.h (make_cleanup_free_target_description):
10496         Don't declare.
10497         (target_desc_deleter): New struct.
10498         (target_desc_up): New typedef.
10499         * target-descriptions.c (target_desc_deleter::operator()): Rename
10500         from free_target_description.
10501         (make_cleanup_free_target_description): Remove.
10502
10503 2019-01-02  Tom Tromey  <tom@tromey.com>
10504
10505         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10506         constructor, destructor.
10507         (linespec_parser): Remove typedef.
10508         (~linespec_parser): Rename from linespec_parser_delete.
10509         (linespec_lex_to_end, linespec_complete_label)
10510         (linespec_complete): Update.
10511         (decode_line_full): Remove cleanups.
10512         (decode_line_1): Update.
10513
10514 2019-01-02  Tom Tromey  <tom@tromey.com>
10515
10516         * python/python-internal.h (inferior_to_inferior_object): Change
10517         return type.
10518         * python/py-exitedevent.c (create_exited_event_object): Update.
10519         * python/py-inferior.c (inferior_to_inferior_object): Return
10520         gdbpy_ref.
10521         (python_new_inferior, python_inferior_deleted)
10522         (thread_to_thread_object, delete_thread_object)
10523         (build_inferior_list, gdbpy_selected_inferior): Update.
10524         * python/py-infthread.c (create_thread_object): Update.  Also fail
10525         if inferior_to_inferior_object fails.
10526
10527 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10528
10529         * inferior.h (class inferior) <displaced_step_state>: New field.
10530         * infrun.h (struct displaced_step_state): Move here from
10531         infrun.c.  Initialize fields, add constructor.
10532         <inf>: Remove field.
10533         <reset>: New method.
10534         * infrun.c (struct displaced_step_inferior_state): Move to
10535         infrun.h.
10536         (displaced_step_inferior_states): Remove.
10537         (get_displaced_stepping_state): Adust.
10538         (displaced_step_in_progress_any_inferior): Adjust.
10539         (displaced_step_in_progress_thread): Adjust.
10540         (displaced_step_in_progress): Adjust.
10541         (add_displaced_stepping_state): Remove.
10542         (get_displaced_step_closure_by_addr): Adjust.
10543         (remove_displaced_stepping_state): Remove.
10544         (infrun_inferior_exit): Call displaced_step_state.reset.
10545         (use_displaced_stepping): Don't check for NULL.
10546         (displaced_step_prepare_throw): Call
10547         get_displaced_stepping_state.
10548         (displaced_step_fixup): Don't check for NULL.
10549         (prepare_for_detach): Don't check for NULL.
10550
10551 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10552
10553         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10554          in case of call that did not complete.
10555
10556 2019-01-02  Andrey Utkin  <autkin@undo.io>
10557
10558         * symfile.c (find_separate_debug_file): Fix search of debug files for
10559         remote debuggee.
10560
10561 2019-01-02  Tom Tromey  <tom@tromey.com>
10562
10563         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10564         indentation.
10565         * python/py-frame.c (frapy_older): Remove cast.
10566         (frapy_newer): Likewise.
10567         * python/py-breakpoint.c (local_setattro): Remove cast.
10568         * python/py-arch.c (archpy_name): Remove local variable.
10569         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10570
10571 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10572
10573         * unittests/basic_string_view/element_access/char/empty.cc:
10574         Fix year range in copyright header.
10575
10576 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10577
10578         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10579         Delete.
10580         <operator==>: Update with for removed field.
10581         <hash>: Likewise.
10582         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10583         <isa_features>: ...this.
10584         <abi_features>: New field.
10585         (riscv_isa_flen): Update comment.
10586         (riscv_abi_xlen): New declaration.
10587         (riscv_abi_flen): New declaration.
10588         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10589         isa_features.
10590         (riscv_abi_xlen): New function.
10591         (riscv_isa_flen): Update to get answer from isa_features.
10592         (riscv_abi_flen): New function.
10593         (riscv_has_fp_abi): Update to get answer from abi_features.
10594         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10595         xlen and flen.
10596         (riscv_call_info) <xlen, flen>: Update comment.
10597         (riscv_call_arg_struct): Remove invalid assertions
10598         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10599         is removed.
10600         (riscv_gdbarch_init): Gather isa features and abi features
10601         separately, ensure both match on the gdbarch when reusing an old
10602         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10603         a target with 64-bit float hardware.
10604
10605 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10606
10607         * source.c (search_command_helper): Stop reverse search
10608         when line 1 has been searched.
10609
10610 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10611
10612         * record-full.c (record_full_base_target::close): Rewrite
10613         record_full_core_buf_list free logic.
10614
10615 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10616
10617         * break-catch-syscall.c (print_one_catch_syscall): xfree
10618         the last text.
10619
10620 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10621
10622         * top.c (print_gdb_version): Update Copyright year in version
10623         message.
10624
10625 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10626
10627         Update copyright year range in all GDB files.
10628
10629 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10630
10631         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10632
10633 For older changes see ChangeLog-2018.
10634 \f
10635 Local Variables:
10636 mode: change-log
10637 left-margin: 8
10638 fill-column: 74
10639 version-control: never
10640 coding: utf-8
10641 End:
10642