gdb/ChangeLog

   1 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
   2
   3         * features/Makefile: Use feature target descriptions for Arm.
   4         * features/arm/arm-core.c: Generate new file.
   5         * features/arm/arm-fpa.c: Likewise.
   6         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
   7         * features/arm/arm-m-profile.c: Likewise.
   8         * features/arm/arm-vfpv2.c: Likewise.
   9         * features/arm/arm-vfpv3.c: Likewise.
  10         * features/arm/xscale-iwmmxt.c: Likewise.
  11         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
  12
  13 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
  14
  15         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
  16         ptrace earlier.
  17
  18 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
  19
  20         * features/aarch64-pauth.c: Regenerate.
  21
  22 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
  23
  24         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
  25         bool.
  26         (bpstat_what): Use false instead of 0.
  27
  28 2019-07-09  Pedro Alves  <palves@redhat.com>
  29
  30         * break-catch-throw.c (is_exception_catchpoint): New.
  31         * breakpoint.c (print_one_breakpoint_location): New parameter
  32         'raw_loc'.  Handle it.  Use
  33         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
  34         looking at the breakpoint's type.
  35         (print_one_breakpoint): If handling "maint info breakpoints", also
  36         print locations of exception catchpoints.
  37         * breakpoint.h (is_exception_catchpoint): Declare.
  38
  39 2019-07-09  Pedro Alves  <palves@redhat.com>
  40
  41         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
  42         "addr" field.
  43         (allocate_location_exception_catchpoint): New.
  44         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
  45         (initialize_throw_catchpoint_ops): Install
  46         allocate_location_exception_catchpoint as allocate_location
  47         method.
  48         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
  49         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
  50         bp_loc_other.
  51         (breakpoint_address_is_meaningful): Delete.
  52         (bl_address_is_meaningful): New.
  53         (breakpoint_locations_match): Adjust comment.
  54         (bp_location_from_bp_type): New, factored out of...
  55         (bp_location::bp_location(breakpoint *)): ... this.
  56         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
  57         factored out of...
  58         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
  59         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
  60         breakpoint_address_is_meaningful.
  61         (bp_locations_compare): Adjust comment.
  62         (update_global_location_list): Use bl_address_is_meaningful
  63         instead of breakpoint_address_is_meaningful.
  64         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
  65         explicit.
  66         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
  67         * python/py-breakpoint.c (bppy_get_location): No longer check
  68         whether location is null.
  69
  70 2019-07-09  Pedro Alves  <palves@redhat.com>
  71
  72         PR c++/15468
  73         * breakpoint.c (print_one_breakpoint_location): Remove
  74         single-location assert.
  75
  76 2019-07-09  Tom Tromey  <tom@tromey.com>
  77
  78         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
  79         * configure: Rebuild.
  80         * configure.ac: Change common to gdbsupport.
  81         * gdbsupport: Rename from common.
  82         * acinclude.m4: Change common to gdbsupport.
  83         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
  84         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
  85         gdbsupport.
  86         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
  87         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
  88         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
  89         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
  90         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
  91         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
  92         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
  93         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
  94         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
  95         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
  96         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
  97         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
  98         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
  99         coff-pe-read.c, command.h, compile/compile-c-support.c,
 100         compile/compile-c.h, compile/compile-cplus-symbols.c,
 101         compile/compile-cplus-types.c, compile/compile-cplus.h,
 102         compile/compile-loc2c.c, compile/compile.c, completer.c,
 103         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 104         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 105         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 106         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 107         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 108         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 109         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 110         features/aarch64-core.c, features/aarch64-fpu.c,
 111         features/aarch64-pauth.c, features/aarch64-sve.c,
 112         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 113         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 114         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 115         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 116         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 117         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 118         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 119         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 120         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 121         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 122         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 123         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 124         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 125         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 126         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 127         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 128         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 129         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 130         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 131         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 132         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 133         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 134         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 135         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 136         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 137         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 138         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 139         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 140         minsyms.c, mips-linux-tdep.c, namespace.h,
 141         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 142         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 143         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 144         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 145         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 146         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 147         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 148         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 149         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 150         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 151         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 152         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 153         procfs.c, producer.c, progspace.h, psymtab.h,
 154         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 155         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 156         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 157         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 158         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
 159         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
 160         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
 161         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
 162         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
 163         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
 164         target-memory.c, target.c, target.h, target/waitstatus.c,
 165         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
 166         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
 167         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
 168         unittests/array-view-selftests.c,
 169         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
 170         unittests/common-utils-selftests.c,
 171         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
 172         unittests/format_pieces-selftests.c,
 173         unittests/function-view-selftests.c,
 174         unittests/lookup_name_info-selftests.c,
 175         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
 176         unittests/mkdir-recursive-selftests.c,
 177         unittests/observable-selftests.c,
 178         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
 179         unittests/parse-connection-spec-selftests.c,
 180         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
 181         unittests/scoped_fd-selftests.c,
 182         unittests/scoped_mmap-selftests.c,
 183         unittests/scoped_restore-selftests.c,
 184         unittests/string_view-selftests.c, unittests/style-selftests.c,
 185         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
 186         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
 187         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
 188         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
 189         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
 190         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
 191
 192 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 193
 194         * linespec.c (decode_digits_list_mode): Set explicit_line to a
 195         bool value.
 196         (decode_digits_ordinary): Set explicit_line field in sal.
 197         * symtab.c (skip_prologue_sal): Don't skip prologue for a
 198         symtab_and_line that was set on an explicit line number in
 199         assembler code.  Do always update the recorded symtab and line if
 200         we do skip the prologue.
 201
 202 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 203
 204         * breakpoint.c (set_breakpoint_location_function): Remove
 205         explicit_loc parameter.
 206         (momentary_breakpoint_from_master): Update call to
 207         set_breakpoint_location_function.
 208         (add_location_to_breakpoint): Likewise.
 209
 210 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 211
 212         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
 213         required features based on default bfd type when no specific bfd
 214         is present.
 215
 216 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 217
 218         * NEWS: Mention that GDB printf and eval commands can now print
 219         C-style and Ada-style convenience var strings without
 220         calling the inferior.
 221         * printcmd.c (printf_c_string): Locally print GDB internal var
 222         instead of transiting via the inferior.
 223         (printf_wide_c_string): Likewise.
 224
 225 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 226
 227         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
 228
 229 2019-07-04  Tom Tromey  <tom@tromey.com>
 230
 231         PR tui/24724:
 232         * tui/tui-winsource.c (tui_clear_source_content): Update.
 233         (tui_source_window_base::set_is_exec_point_at): Fix comment.
 234         (tui_update_breakpoint_info): Update.
 235         (tui_set_exec_info_content): Update.
 236         * tui/tui-source.c (tui_set_source_content_nil): Update.
 237         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
 238         has_break.
 239         * tui/tui-data.h (enum tui_bp_flag): New.
 240         (tui_bp_flags): New enum flags type.
 241         (struct tui_source_element) <break_mode>: Change type.  Rename
 242         from has_break.
 243         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
 244         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
 245         constants.
 246         * tui/tui-winsource.h: Fix comment.
 247
 248 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 249
 250         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
 251         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
 252         (store_fpregs_to_thread)
 253         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 254         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
 255         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
 256         (IWMMXT_REGS_SIZE): Add define.
 257         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
 258         (fetch_vfp_regs, store_vfp_regs)
 259         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 260         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
 261
 262 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 263
 264         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
 265         defines.
 266         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
 267         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
 268         (ARM_INT_REGISTER_SIZE): ...to this.
 269         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
 270         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
 271         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
 272         (arm_linux_collect_gregset, supply_nwfpe_register)
 273         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
 274         defines.
 275         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
 276         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
 277         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
 278         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
 279         (arm_return_in_memory, arm_store_return_value)
 280         (arm_get_longjmp_target, arm_register_g_packet_guesses)
 281         (arm_record_ld_st_multiple): Likewise.
 282         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
 283         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
 284
 285 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 286
 287         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
 288         AARCH64_DISPLACED_MODIFIED_INSNS.
 289         * aarch64-tdep.c (struct aarch64_displaced_step_data)
 290         (aarch64_displaced_step_copy_insn): Likewise.
 291         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 292         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
 293         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
 294         ARM_DISPLACED_MODIFIED_INSNS.
 295         * arm-tdep.c (arm_gdbarch_init): Likewise.
 296         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 297         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
 298         (struct arm_displaced_step_closure): Use
 299         ARM_DISPLACED_MODIFIED_INSNS.
 300
 301 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 302
 303         * features/Makefile: Remove unused xml files.
 304         * features/aarch64.xml: Remove.
 305         * features/i386/amd64-avx-avx512-linux.xml: Remove.
 306         * features/i386/amd64-avx-avx512.xml: Remove.
 307         * features/i386/amd64-avx-linux.xml: Remove.
 308         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
 309         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
 310         * features/i386/amd64-avx-mpx-linux.xml: Remove.
 311         * features/i386/amd64-avx-mpx.xml: Remove.
 312         * features/i386/amd64-avx.xml: Remove.
 313         * features/i386/amd64-linux.xml: Remove.
 314         * features/i386/amd64-mpx-linux.xml: Remove.
 315         * features/i386/amd64-mpx.xml: Remove.
 316         * features/i386/amd64.xml: Remove.
 317         * features/i386/i386-avx-avx512-linux.xml: Remove.
 318         * features/i386/i386-avx-avx512.xml: Remove.
 319         * features/i386/i386-avx-linux.xml: Remove.
 320         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
 321         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
 322         * features/i386/i386-avx-mpx-linux.xml: Remove.
 323         * features/i386/i386-avx-mpx.xml: Remove.
 324         * features/i386/i386-avx.xml: Remove.
 325         * features/i386/i386-linux.xml: Remove.
 326         * features/i386/i386-mmx-linux.xml: Remove.
 327         * features/i386/i386-mmx.xml: Remove.
 328         * features/i386/i386-mpx-linux.xml: Remove.
 329         * features/i386/i386-mpx.xml: Remove.
 330         * features/i386/i386.xml: Remove.
 331         * features/i386/x32-avx-avx512-linux.xml: Remove.
 332         * features/i386/x32-avx-linux.xml: Remove.
 333         * features/i386/x32-linux.xml: Remove.
 334
 335 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 336
 337         * regformats/aarch64.dat: Remove.
 338         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
 339         * regformats/i386/amd64-avx-linux.dat: Remove.
 340         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
 341         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
 342         * regformats/i386/amd64-linux.dat: Remove.
 343         * regformats/i386/amd64-mpx-linux.dat: Remove.
 344         * regformats/i386/amd64.dat: Remove.
 345         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
 346         * regformats/i386/i386-avx-linux.dat: Remove.
 347         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
 348         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
 349         * regformats/i386/i386-linux.dat: Remove.
 350         * regformats/i386/i386-mmx-linux.dat: Remove.
 351         * regformats/i386/i386-mpx-linux.dat: Remove.
 352         * regformats/i386/i386.dat: Remove.
 353         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
 354         * regformats/i386/x32-avx-linux.dat: Remove.
 355         * regformats/i386/x32-linux.dat: Remove.
 356
 357 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 358
 359         * aarch64-tdep.c: Remove xml self tests.
 360         * amd64-linux-tdep.c: Likewise.
 361         * amd64-tdep.c: Likewise.
 362         * i386-linux-tdep.c: Likewise.
 363         * i386-tdep.c: Likewise.
 364
 365 2019-07-03  Pedro Alves  <palves@redhat.com>
 366
 367         PR cli/24732
 368         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
 369         (pipe_cmd_option_defs): New.
 370         (make_pipe_cmd_options_def_group): New.
 371         (pipe_command): Use gdb::option::process_options.
 372         (pipe_command_completer): New function.
 373         (_initialize_cli_cmds): Install completer for "pipe" command.
 374
 375 2019-07-03  Pedro Alves  <palves@redhat.com>
 376
 377         * cli/cli-option.c (union option_value) <string>: New field.
 378         (struct option_def_and_value): Add ctor, move ctor, dtor and
 379         use DISABLE_COPY_AND_ASSIGN.
 380         (option_def_and_value::clear_value): New.
 381         (parse_option, save_option_value_in_ctx, get_val_type_str)
 382         (add_setshow_cmds_for_options): Handle var_string.
 383         * cli-option.h (union option_def::var_address) <string>: New
 384         field.
 385         (struct string_option_def): New.
 386         * maint-test-options.c (struct test_options_opts): Add default
 387         ctor and use DISABLE_COPY_AND_ASSIGN.
 388         <string_opt>: New field.
 389         (test_options_opts::~test_options_opts): New.
 390         (test_options_opts::dump): Also dump "-string".
 391         (test_options_option_defs): Install "string.
 392
 393 2019-07-03  Pedro Alves  <palves@redhat.com>
 394
 395         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
 396         option_value with a null enumeration.
 397         (complete_options): Save the option values in the context.
 398         (save_option_value_in_ctx): New, factored out from ...
 399         (process_options): ... here.
 400         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
 401         of the function.
 402         * maint-test-options.c (test_options_opts::dump): New, factored
 403         out from ...
 404         (maintenance_test_options_command_mode): ... here.
 405         (maintenance_test_options_command_completion_result): Delete.
 406         (maintenance_test_options_command_completion_text): Update
 407         comment.
 408         (maintenance_show_test_options_completion_result): Change
 409         prototype.  Just print
 410         maintenance_test_options_command_completion_text.
 411         (save_completion_result): New.
 412         (maintenance_test_options_completer_mode): Pass options context to
 413         complete_options, and then save a dump.
 414         (_initialize_maint_test_options): Use add_cmd to install "maint
 415         show test-options-completion-result".
 416
 417 2019-07-03  Pedro Alves  <palves@redhat.com>
 418
 419         * NEWS (New commands): Mention "with" and "maint with".
 420         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
 421         (with_command, with_command_completer): New.
 422         (pipe_command): Adjust to new repeat_previous
 423         interface.
 424         (_initialize_cli_cmds): Install the "with" command and its "w"
 425         alias.
 426         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
 427         declarations.
 428         * cli/cli-setshow.c (parse_cli_var_uinteger)
 429         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
 430         argument strings for all var_types.
 431         (get_setshow_command_value_string): New, factored out from ...
 432         (do_show_command): ... this.
 433         * cli/cli-setshow.h: Include <string>.
 434         (get_setshow_command_value_string): Declare.
 435         * command.h (repeat_previous): Now returns const char *.  Adjust
 436         comment.
 437         * maint.c: Include "cli/cli-cmds.h".
 438         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
 439         (_initialize_maint_cmds): Register the "maintenance with" command.
 440         * top.c (repeat_previous): Move bits from pipe_command here:
 441         Return the saved command line, if any; error out if there's no
 442         command to relaunch.
 443
 444 2019-07-03  Pedro Alves  <palves@redhat.com>
 445
 446         * NEWS (New commands): Mention "maint set/show test-settings"
 447         instead of "maint test-settings".
 448         * maint-test-settings.c (maintenance_test_settings_list): Delete.
 449         (maintenance_test_settings_set_list): Rename to ...
 450         (maintenance_set_test_settings_list): ... this.
 451         (maintenance_test_settings_show_list): Rename to  ...
 452         (maintenance_show_test_settings_list): ... this.
 453         (maintenance_test_settings_cmd): Delete.
 454         (maintenance_test_settings_set_cmd): ...
 455         (maintenance_set_test_settings_cmd): ... this.
 456         (maintenance_test_settings_show_cmd): ...
 457         (maintenance_show_test_settings_cmd): ... this.
 458         (maintenance_test_settings_show_value_cmd):
 459         (maintenance_show_test_settings_value_cmd): ... this.
 460         (_initialize_maint_test_settings): No longer install the "maint
 461         test-settings" prefix command.  Rename "maint test-settings set"
 462         to "maint set test-settings", and "maint test-settings show" to
 463         "maint show test-settings".  Adjust all subcommands.
 464
 465 2019-07-03  Pedro Alves  <palves@redhat.com>
 466
 467         * maint-test-settings.c: Fix file's intro comment.  Replace all
 468         references to "test-options" with references to "test-settings",
 469         in comments.
 470
 471 2019-07-03  Pedro Alves  <palves@redhat.com>
 472
 473         * maint-test-settings.c (maintenance_test_settings_xxx)
 474         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
 475         New.
 476         (maintenance_test_settings_enums): Use them.
 477         (maintenance_test_settings_enum): Default to
 478         maintenance_test_settings_xxx.
 479         (_initialize_maint_test_settings): Initialize
 480         MAINTENANCE_TEST_SETTINGS_FILENAME.
 481
 482 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 483
 484         * breakpoint.h (remove_breakpoints_inf): Change return type to
 485         void, move function documentation here.
 486         * breakpoint.c (remove_breakpoints_inf): Change return type to
 487         void, move function documentation to header.
 488
 489 2019-07-02  Pedro Alves  <palves@redhat.com>
 490
 491         * NEWS (Completion improvements): Mention "info threads".
 492         * thread.c (struct info_threads_opts, info_threads_option_defs)
 493         (make_info_threads_options_def_group): New.
 494         (info_threads_command): Use gdb::option::process_options.
 495         (info_threads_command_completer): New.
 496         (_initialize_thread): Use gdb::option::build_help to build the
 497         help text for "info threads".
 498
 499 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 500
 501         * defs.h (generic_load): Move from here...
 502         * symfile.h (generic_load): ... to here.  Rename name parameter
 503         to args.
 504         * symfile.c (generic_load): Add comment.
 505
 506 2019-07-01  Tom Tromey  <tromey@adacore.com>
 507
 508         * dwarf2read.c
 509         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
 510         declaration of without_params.  Fix formatting.
 511
 512 2019-07-01  Tom Tromey  <tromey@adacore.com>
 513
 514         * ada-exp.y (find_primitive_type): Update.
 515         * ada-lang.h (ada_lookup_symbol): Update.
 516         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
 517         parameter.
 518         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
 519
 520 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 521
 522         PR breakpoints/24541
 523         * gdbarch.c: Regenerate.
 524         * gdbarch.h: Regenerate.
 525         * gdbarch.sh: Add 'stap_adjust_register'.
 526         * i386-tdep.c: Include '<unordered_set>'.
 527         (i386_stap_adjust_register): New function.
 528         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
 529         * stap-probe.c (stap_parse_register_operand): Call
 530         'gdbarch_stap_adjust_register'.
 531
 532 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 533
 534         PR python/24742
 535         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
 536         * python/python.c (do_start_initialization): Use 'xmalloc'
 537         instead of 'PyMem_Malloc'.
 538
 539 2019-06-28  Tom Tromey  <tromey@adacore.com>
 540
 541         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
 542         for Ada.
 543
 544 2019-06-27  Tom Tromey  <tromey@adacore.com>
 545
 546         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
 547         objfile_key.
 548         (arm_find_mapping_symbol, arm_record_special_symbol)
 549         (_initialize_arm_tdep): Update.
 550         (arm_objfile_data_free): Remove.
 551
 552 2019-06-27  Tom Tromey  <tromey@adacore.com>
 553
 554         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
 555         to cp_print_static_field.
 556
 557 2019-06-26  Tom Tromey  <tromey@adacore.com>
 558
 559         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
 560         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
 561         declare.
 562
 563 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 564
 565         * features/aarch64-core.c (create_feature_aarch64_core):
 566         Regenerate.
 567         * features/aarch64-core.xml: Add cpsr flags.
 568
 569 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 570
 571         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
 572         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
 573
 574 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 575
 576         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
 577         field.
 578         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
 579         use.
 580         (arm_record_special_symbol): Don't insert new symbol in sorted
 581         position, push it at the end.
 582
 583 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 584
 585         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
 586         (arm_mapping_symbol_s): Remove.
 587         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
 588         (arm_mapping_symbol_vec): New typedef.
 589         (struct arm_per_objfile): Add constructor.
 590         <section_maps>: Change type to
 591         std::unique_ptr<arm_mapping_symbol_vec[]>.
 592         (arm_compare_mapping_symbols): Remove.
 593         (arm_find_mapping_symbol): Adjust to section_maps type change.
 594         (arm_objfile_data_free): Call delete on arm_per_objfile.
 595         (arm_record_special_symbol): Adjust to section_maps type change.
 596         Allocate arm_per_objfile with new.
 597
 598 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 599
 600         * cli/cli-cmds.c (alias_command): Compare the alias prefix
 601         with the command prefix.
 602
 603 2019-06-25  Tom Tromey  <tom@tromey.com>
 604
 605         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
 606         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
 607
 608 2019-06-25  Tom Tromey  <tom@tromey.com>
 609
 610         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
 611         type.
 612         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
 613         protected.
 614
 615 2019-06-25  Tom Tromey  <tom@tromey.com>
 616
 617         * tui/tui-winsource.c
 618         (tui_source_window_base::set_is_exec_point_at): Add check against
 619         LOA_ADDRESS.
 620
 621 2019-06-25  Tom Tromey  <tom@tromey.com>
 622
 623         * tui/tui-source.c (tui_set_source_content): Don't check before
 624         xfree.
 625         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
 626
 627 2019-06-25  Tom Tromey  <tom@tromey.com>
 628
 629         * tui/tui-winsource.h (tui_update_source_window_as_is)
 630         (tui_alloc_source_buffer, tui_line_is_displayed)
 631         (tui_addr_is_displayed): Change type of win_info.
 632         * tui/tui-winsource.c (tui_update_source_window_as_is)
 633         (tui_clear_source_content, tui_show_source_line)
 634         (tui_show_source_content, tui_source_window_base::refill)
 635         (tui_source_window_base::set_is_exec_point_at)
 636         (tui_source_window_base::set_is_exec_point_at)
 637         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
 638         (tui_alloc_source_buffer, tui_line_is_displayed)
 639         (tui_addr_is_displayed): Change type of win_info.  Update.
 640         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 641         (tui_source_window_base::do_make_visible_with_new_height):
 642         Update.
 643         * tui/tui-source.c (tui_set_source_content)
 644         (tui_set_source_content_nil)
 645         (tui_source_window::do_scroll_vertical): Update.
 646         * tui/tui-layout.c (show_layout): Update.
 647         * tui/tui-disasm.c (tui_set_disassem_content)
 648         (tui_disasm_window::do_scroll_vertical): Update.
 649         * tui/tui-data.h (tui_win_content): Remove.
 650         (struct tui_gen_win_info) <content, content_size>: Remove.
 651         (struct tui_source_element): Add initializers and destructor.
 652         (union tui_which_element, struct tui_win_element): Remove.
 653         (struct tui_source_window_base) <content>: New field.
 654         (struct tui_data_window): Remove destructor.
 655         (tui_alloc_content, tui_free_win_content)
 656         (tui_free_all_source_wins_content): Don't declare.
 657         * tui/tui-data.c (tui_initialize_static_data): Update.
 658         (init_content_element, tui_alloc_content): Remove.
 659         (~tui_gen_win_info): Update.
 660         (~tui_data_window, tui_free_all_source_wins_content)
 661         (tui_free_win_content, free_content, free_content_elements):
 662         Remove.
 663
 664 2019-06-25  Tom Tromey  <tom@tromey.com>
 665
 666         * tui/tui-winsource.h (tui_clear_source_content)
 667         (tui_erase_source_content, tui_show_source_content): Change type
 668         of win_info.
 669         * tui/tui-winsource.c (tui_clear_source_content)
 670         (tui_erase_source_content, tui_show_source_content): Change type
 671         of win_info.
 672         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 673         * tui/tui-source.h (tui_set_source_content_nil): Change type of
 674         win_info.
 675         * tui/tui-source.c (tui_set_source_content_nil): Change type of
 676         win_info.
 677         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
 678
 679 2019-06-25  Tom Tromey  <tom@tromey.com>
 680
 681         * tui/tui-winsource.c (tui_clear_source_content)
 682         (tui_source_window_base::set_is_exec_point_at): Update.
 683         * tui/tui-source.c (tui_set_source_content_nil): Update.
 684         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
 685         a bool.
 686         * tui/tui-data.c (init_content_element): Update.
 687
 688 2019-06-25  Tom Tromey  <tom@tromey.com>
 689
 690         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
 691         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
 692         * tui/tui-layout.c (init_and_make_win): Update.
 693         * tui/tui.h (enum tui_win_type): Update.
 694         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
 695         tui_win_is_auxillary.
 696         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
 697         tui_win_is_auxillary.
 698
 699 2019-06-25  Tom Tromey  <tom@tromey.com>
 700
 701         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
 702         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
 703         (tui_delete_data_content_windows, tui_display_all_data)
 704         (tui_data_window::do_scroll_vertical, tui_display_data_from):
 705         Update.
 706         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
 707         * tui/tui-regs.c (tui_last_regs_line_no)
 708         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 709         (tui_show_registers): Update.
 710         (tui_show_register_group): Return void.  Update.
 711         (tui_display_registers_from, tui_display_reg_element_at_line)
 712         (tui_display_registers_from_line, tui_check_register_values):
 713         Update.
 714         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
 715         member.
 716         (struct tui_data_window) <regs_content>: Now a std::vector.
 717         <regs_content_count>: Remove.
 718         (tui_add_content_elements, tui_free_data_content): Don't declare.
 719         * tui/tui-data.c (tui_data_window::clear_detail): Update.
 720         (init_content_element): Remove DATA_WIN case.  Add assert.
 721         (tui_add_content_elements): Remove.
 722         (tui_data_window): Update.
 723         (tui_free_data_content): Remove.
 724         (free_content_elements): Remove DATA_WIN case.
 725
 726 2019-06-25  Tom Tromey  <tom@tromey.com>
 727
 728         * tui/tui-data.c (tui_data_item_window): Update.
 729         * tui/tui-windata.h (tui_check_data_values): Don't declare.
 730         * tui/tui-windata.c (tui_display_all_data)
 731         (tui_display_data_from_line): Update.
 732         (tui_check_data_values): Remove.
 733         * tui/tui-regs.c (tui_show_register_group)
 734         (tui_display_reg_element_at_line): Update.
 735         * tui/tui-hooks.c (tui_register_changed)
 736         (tui_refresh_frame_and_register_information): Call
 737         tui_check_register_values.
 738         * tui/tui-data.h (struct tui_data_window) <data_content,
 739         data_content_count, data_type>: Remove.
 740         (enum tui_data_type): Remove.
 741
 742         * tui/tui-data.c (tui_data_window::clear_detail)
 743         (~tui_data_window): Update.
 744
 745 2019-06-25  Tom Tromey  <tom@tromey.com>
 746
 747         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
 748         declare.
 749         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
 750         Rename from tui_first_data_item_displayed.  Update.
 751         (tui_data_window::refresh_all)
 752         (tui_data_window::do_scroll_vertical): Update.
 753         * tui/tui-data.h (struct tui_data_window)
 754         <first_data_item_displayed>: Declare new method.
 755
 756 2019-06-25  Tom Tromey  <tom@tromey.com>
 757
 758         * tui/tui-data.h (tui_init_generic_part): Don't declare.
 759         * tui/tui-data.c (tui_init_generic_part): Remove, moving
 760         contents...
 761         (tui_initialize_static_data): ...here.
 762
 763 2019-06-25  Tom Tromey  <tom@tromey.com>
 764
 765         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 766         (tui_display_registers_from, tui_check_register_values): Update.
 767         (tui_display_register): Remove win_info parameter; update.
 768         (tui_get_register): Change type of parameters.
 769         * tui/tui-data.h (struct tui_data_element): Remove.
 770         (union tui_which_element) <data>: Remove.
 771         <data_window>: Change type.
 772         (struct tui_data_item_window): New.
 773         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
 774         case.  Add assert.
 775         (~tui_data_item_window): New destructor.
 776         (free_content_elements): Remove DATA_ITEM_WIN case.
 777
 778 2019-06-25  Tom Tromey  <tom@tromey.com>
 779
 780         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
 781         Remove.
 782
 783 2019-06-25  Tom Tromey  <tom@tromey.com>
 784
 785         * tui/tui-data.h (struct tui_command_element): Remove.
 786         (union tui_which_element) <command>: Remove.
 787         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
 788         assert.
 789         (free_content_elements): Remove CMD_WIN case.
 790
 791 2019-06-25  Tom Tromey  <tom@tromey.com>
 792
 793         * tui/tui-layout.c (tui_set_layout): Update.
 794         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
 795         * tui/tui-data.c (layout_def): Update.
 796
 797 2019-06-25  Tom Tromey  <tom@tromey.com>
 798
 799         * tui/tui-wingeneral.c (tui_refresh_all): Update.
 800         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 801         (tui_source_window_base::set_new_height): Update.
 802         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
 803         Update.
 804         (tui_set_locator_fullname, tui_set_locator_info)
 805         (tui_show_frame_info): Update.
 806         * tui/tui-source.c (tui_set_source_content)
 807         (tui_source_is_displayed): Update.
 808         * tui/tui-layout.c (show_source_disasm_command, show_data)
 809         (show_source_or_disasm_and_command): Update.
 810         * tui/tui-disasm.c (tui_set_disassem_content)
 811         (tui_get_begin_asm_address): Update.
 812         * tui/tui-data.h (struct tui_locator_element): Remove.
 813         (union tui_which_element) <locator>: Remove.
 814         (struct tui_locator_window): New.
 815         (tui_locator_win_info_ptr): Change return type.
 816         * tui/tui-data.c (_locator): Change type.
 817         (tui_locator_win_info_ptr): Change return type.
 818         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
 819         (tui_alloc_content): Add assert.
 820
 821 2019-06-25  Tom Tromey  <tom@tromey.com>
 822
 823         * tui/tui-winsource.c
 824         (tui_exec_info_window::maybe_allocate_content): New method.
 825         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
 826         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
 827         (make_source_or_disasm_window): Add cast.
 828         * tui/tui-data.h (union tui_which_element) <simple_string>:
 829         Remove.
 830         (struct tui_source_info): New.
 831         (struct tui_source_window_base) <execution_info>: Change type.
 832         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
 833         case, and add assert.
 834         (tui_alloc_content): Add assert.
 835
 836 2019-06-25  Tom Tromey  <tom@tromey.com>
 837
 838         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
 839         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
 840         * tui/tui-data.c (tui_alloc_win_info): Remove.
 841
 842 2019-06-25  Tom Tromey  <tom@tromey.com>
 843
 844         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
 845         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
 846         can_highlight.
 847
 848 2019-06-25  Tom Tromey  <tom@tromey.com>
 849
 850         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
 851         make_visible_with_new_height method.
 852         (tui_win_info::make_visible_with_new_height): New method.
 853         (tui_source_window_base::do_make_visible_with_new_height)
 854         (tui_data_window::do_make_visible_with_new_height)
 855         (tui_cmd_window::do_make_visible_with_new_height): New methods.
 856         (make_visible_with_new_height): Remove.
 857         (tui_resize_all, tui_adjust_win_heights): Use
 858         make_visible_with_new_height method.
 859         * tui/tui-data.h (struct tui_win_info)
 860         <do_make_visible_with_new_height, make_visible_with_new_height>:
 861         New methods.
 862         (struct tui_source_window_base, struct tui_data_window)
 863         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
 864         methods.
 865
 866 2019-06-25  Tom Tromey  <tom@tromey.com>
 867
 868         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
 869         method.
 870         (update_tab_width): Call update_tab_width method.
 871         * tui/tui-data.h (struct tui_win_info)
 872         (struct tui_source_window_base) <update_tab_width>: New methods.
 873
 874 2019-06-25  Tom Tromey  <tom@tromey.com>
 875
 876         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
 877         parameter.
 878         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
 879         parameter.
 880         (tui_gen_win_info::make_visible): Update.
 881         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
 882         parameter.
 883         * tui/tui-data.h (enum tui_box): New enum.
 884         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
 885
 886 2019-06-25  Tom Tromey  <tom@tromey.com>
 887
 888         * tui/tui-layout.c (make_source_or_disasm_window): Always use
 889         init_and_make_win for EXEC_INFO_WIN.
 890         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
 891         longer inline.
 892         (struct tui_win_info) <~tui_win_info>: Inline.
 893         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 894         Don't declare.
 895         * tui/tui-data.c (source_win, disasm_win): Remove globals.
 896         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 897         Remove.
 898         (tui_initialize_static_data): Update.
 899         (~tui_gen_win_info): Handle more cleanup here.
 900         (~tui_source_window_base): Delete "execution_info".
 901         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
 902
 903 2019-06-25  Tom Tromey  <tom@tromey.com>
 904
 905         * tui/tui-layout.c (make_command_window): Don't set
 906         can_highlight.
 907         (show_source_disasm_command): Call the reset method.
 908         (show_data): Don't set can_highlight.  Call the reset method.
 909         (tui_gen_win_info::reset): Rename from init_gen_win_info
 910         (init_and_make_win): Simplify.  Return tui_gen_win_info.
 911         (show_source_or_disasm_and_command): Call the reset method.
 912         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
 913         (struct tui_cmd_window): Set can_highlight.
 914
 915 2019-06-25  Tom Tromey  <tom@tromey.com>
 916
 917         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
 918         from make_visible.
 919         (tui_make_visible, tui_make_invisible): Rewrite.
 920         (tui_win_info::make_visible): Remove.
 921         (tui_source_window_base::make_visible): Update.
 922         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
 923         method.  Moved from...
 924         (struct tui_win_info) <make_visible>: ...here.
 925
 926 2019-06-25  Tom Tromey  <tom@tromey.com>
 927
 928         * tui/tui-winsource.c
 929         (tui_source_window_base::do_scroll_horizontal): Remove direction
 930         parameter.
 931         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
 932         direction parameter.
 933         * tui/tui-win.c (tui_win_info::forward_scroll)
 934         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 935         (tui_win_info::right_scroll): Update.
 936         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
 937         direction parameter.
 938         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
 939         direction parameter.
 940         * tui/tui-data.h (enum tui_scroll_direction): Remove.
 941         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
 942         Remove direction parameter.
 943         (struct tui_source_window_base, struct tui_source_window)
 944         (struct tui_disasm_window, struct tui_data_window)
 945         (struct tui_cmd_window): Update.
 946
 947 2019-06-25  Tom Tromey  <tom@tromey.com>
 948
 949         * tui/tui-winsource.h (tui_set_exec_info_content)
 950         (tui_show_exec_info_content, tui_erase_exec_info_content)
 951         (tui_clear_exec_info_content, tui_update_exec_info): Change
 952         argument to tui_source_window_base.
 953         * tui/tui-winsource.c (tui_set_exec_info_content)
 954         (tui_show_exec_info_content, tui_erase_exec_info_content)
 955         (tui_clear_exec_info_content, tui_update_exec_info): Change
 956         argument to tui_source_window_base.
 957
 958 2019-06-25  Tom Tromey  <tom@tromey.com>
 959
 960         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
 961         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
 962
 963 2019-06-25  Tom Tromey  <tom@tromey.com>
 964
 965         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
 966         check.
 967
 968 2019-06-25  Tom Tromey  <tom@tromey.com>
 969
 970         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
 971         type to void.
 972         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
 973         type to void.
 974         * tui/tui-source.c (tui_set_source_content): Update.
 975         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 976
 977 2019-06-25  Tom Tromey  <tom@tromey.com>
 978
 979         * tui/tui-win.c (window_name_completer, tui_set_focus)
 980         (tui_all_windows_info): Use name method.
 981         * tui/tui-data.h (struct tui_gen_win_info)
 982         (struct tui_source_window, struct tui_disasm_window)
 983         (struct tui_data_window, struct tui_cmd_window) <name>: New
 984         method.
 985         (tui_win_name): Don't declare.
 986         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
 987         (tui_win_name): Remove.
 988
 989 2019-06-25  Tom Tromey  <tom@tromey.com>
 990
 991         * tui/tui-winsource.h (tui_update_source_window)
 992         (tui_update_source_window_as_is): Change parameter type.
 993         * tui/tui-winsource.c (tui_update_source_window): Change win_info
 994         to be a tui_source_window_base.
 995         (tui_update_source_window_as_is): Likewise.
 996         * tui/tui-win.c (make_visible_with_new_height): Update.
 997
 998 2019-06-25  Tom Tromey  <tom@tromey.com>
 999
1000         * tui/tui-winsource.c (tui_erase_source_content)
1001         (tui_show_source_content, tui_show_exec_info_content)
1002         (tui_erase_exec_info_content): Use refresh_window method.
1003         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1004         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1005         from tui_refresh_win.
1006         (tui_data_window::refresh_window): New method.
1007         (tui_win_info::refresh, tui_source_window_base::refresh)
1008         (tui_refresh_all): Use refresh_window method.
1009         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1010         method.
1011         * tui/tui-regs.c (tui_display_register): Call refresh_window
1012         method.
1013         * tui/tui-layout.c (show_source_disasm_command)
1014         (show_source_or_disasm_and_command): Call refresh_window method.
1015         * tui/tui-data.h (struct tui_gen_win_info)
1016         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1017         New method.
1018
1019 2019-06-25  Tom Tromey  <tom@tromey.com>
1020
1021         * tui/tui.c (tui_rl_other_window, tui_enable)
1022         (tui_is_window_visible, tui_get_command_dimension): Update.
1023         * tui/tui-winsource.c (tui_update_source_window_as_is)
1024         (tui_clear_source_content, tui_erase_source_content)
1025         (tui_show_source_line, tui_source_window_base::refill)
1026         (tui_source_window_base::do_scroll_horizontal)
1027         (tui_source_window_base::set_is_exec_point_at)
1028         (tui_update_breakpoint_info, tui_set_exec_info_content)
1029         (tui_alloc_source_buffer, tui_line_is_displayed)
1030         (tui_addr_is_displayed): Update.
1031         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1032         (tui_check_and_display_highlight_if_needed)
1033         (tui_win_info::make_visible, tui_win_info::refresh)
1034         (tui_refresh_all): Update.
1035         * tui/tui-windata.c (tui_first_data_item_displayed)
1036         (tui_delete_data_content_windows, tui_erase_data_content)
1037         (tui_display_all_data, tui_data_window::refresh_all)
1038         (tui_check_data_values): Update.
1039         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1040         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1041         (tui_win_info::backward_scroll, tui_refresh_all_win)
1042         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1043         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1044         (tui_source_window_base::set_new_height)
1045         (tui_data_window::set_new_height)
1046         (make_invisible_and_set_new_height)
1047         (make_visible_with_new_height, new_height_ok)
1048         (parse_scrolling_args): Update.
1049         * tui/tui-stack.c (tui_show_frame_info): Update.
1050         * tui/tui-source.c (tui_set_source_content)
1051         (tui_set_source_content_nil, tui_source_is_displayed)
1052         (tui_source_window::do_scroll_vertical): Update.
1053         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1054         (tui_display_registers_from, tui_display_reg_element_at_line)
1055         (tui_check_register_values, tui_reg_command): Update.
1056         * tui/tui-layout.c (tui_default_win_height)
1057         (show_source_disasm_command, show_data, init_and_make_win)
1058         (show_source_or_disasm_and_command): Update.
1059         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1060         (tui_redisplay_readline, tui_mld_flush)
1061         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1062         (tui_getc): Update.
1063         * tui/tui-disasm.c (tui_set_disassem_content)
1064         (tui_disasm_window::do_scroll_vertical): Update.
1065         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1066         Now virtual.
1067         (struct tui_win_info): Derive from tui_gen_win_info.
1068         <~tui_win_info>: Mark as override.
1069         <generic>: Remove member.
1070         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1071         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1072         (~tui_data_window, ~tui_win_info)
1073         (tui_free_all_source_wins_content): Update.
1074         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1075
1076 2019-06-25  Tom Tromey  <tom@tromey.com>
1077
1078         * tui/tui-layout.c (init_and_make_win): Use new.
1079         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1080         destructor, initializers.
1081         (tui_alloc_generic_win_info): Don't declare.
1082         * tui/tui-data.c (_locator): Add argument to constructor.
1083         (source_win, disasm_win): New globals.
1084         (exec_info): Remove.
1085         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1086         Update.
1087         (tui_alloc_generic_win_info): Remove.
1088         (init_content_element): Use new.
1089         (tui_win_info::tui_win_info): Update.
1090         (free_content_elements) <case DATA_WIN>: Use delete.
1091
1092 2019-06-25  Tom Tromey  <tom@tromey.com>
1093
1094         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1095         * tui/tui-windata.c (tui_first_data_item_displayed)
1096         (tui_delete_data_content_windows): Update.
1097         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1098         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1099         (tui_display_registers_from, tui_check_register_values): Update.
1100         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1101         pointer.
1102         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1103         window.
1104         (tui_free_data_content): Update.
1105         (free_content_elements) <case DATA_WIN>: Free the window.
1106
1107 2019-06-25  Tom Tromey  <tom@tromey.com>
1108
1109         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1110         Update.
1111         * tui/tui-layout.c (make_command_window)
1112         (show_source_disasm_command, show_data, init_and_make_win)
1113         (show_source_or_disasm_and_command): Update.
1114         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1115         method.
1116         <can_highight, is_highlighted>: Now bool.
1117         (tui_set_win_highlight): Don't declare.
1118         * tui/tui-data.c (tui_set_win_highlight): Remove.
1119
1120 2019-06-25  Tom Tromey  <tom@tromey.com>
1121
1122         * tui/tui-wingeneral.c (make_visible): Remove check of window
1123         type.
1124
1125 2019-06-25  Tom Tromey  <tom@tromey.com>
1126
1127         * tui/tui-win.c (tui_win_info::max_height)
1128         (tui_cmd_window::max_height): New methods.
1129         (new_height_ok): Call max_height.
1130         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1131         <max_height>: New method.
1132
1133 2019-06-25  Tom Tromey  <tom@tromey.com>
1134
1135         * tui/tui-win.c (tui_source_window_base::set_new_height)
1136         (tui_data_window::set_new_height): New methods.
1137         (make_invisible_and_set_new_height): Call set_new_height method.
1138         * tui/tui-data.h (struct tui_win_info)
1139         (struct tui_source_window_base, struct tui_data_window)
1140         <set_new_height>: New method.
1141
1142 2019-06-25  Tom Tromey  <tom@tromey.com>
1143
1144         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1145         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1146         tui_refresh_data_win.
1147         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1148         method.
1149         (tui_refresh_all_win): Call the refresh_all method.
1150         (tui_set_focus): Likewise.
1151         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1152         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1153         Likewise.
1154
1155 2019-06-25  Tom Tromey  <tom@tromey.com>
1156
1157         * tui/tui-winsource.h (tui_refill_source_window)
1158         (tui_set_is_exec_point_at): Don't declare.
1159         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1160         (tui_source_window_base::refill): Rename from
1161         tui_refill_source_window.
1162         (tui_source_window_base::do_scroll_horizontal): Update.
1163         (tui_source_window_base::set_is_exec_point_at): Rename from
1164         tui_set_is_exec_point_at.
1165         (tui_update_all_breakpoint_info): Update.
1166         * tui/tui-stack.c (tui_show_frame_info): Update.
1167         * tui/tui-layout.c (show_data): Add cast.
1168         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1169         * tui/tui-data.h (struct tui_source_window_base) <refill,
1170         set_is_exec_point_at>: New methods.
1171         (tui_source_windows, tui_add_to_source_windows): Update types.
1172         (tui_add_to_source_windows): Remove redundant declaration.
1173         * tui/tui-data.c (source_windows): Store tui_source_window_base.
1174         (tui_source_windows): Change return type.
1175         (tui_clear_source_windows_detail): Update.
1176         (tui_add_to_source_windows): Change type of parameter.
1177         (tui_free_all_source_wins_content): Update.
1178
1179 2019-06-25  Tom Tromey  <tom@tromey.com>
1180
1181         * tui/tui-wingeneral.c (tui_win_info::refresh)
1182         (tui_source_window_base::refresh): New methods.
1183         (tui_refresh_all): Call the refresh method.
1184         * tui/tui-data.h (struct tui_win_info)
1185         (struct tui_source_window_base) <refresh>: New method.
1186
1187 2019-06-25  Tom Tromey  <tom@tromey.com>
1188
1189         * tui/tui.h (tui_is_window_visible): Return bool.
1190         * tui/tui.c (tui_is_window_visible): Return bool.
1191         * tui/tui-wingeneral.c (tui_make_window, make_visible)
1192         (tui_make_visible, tui_make_invisible)
1193         (tui_win_info::make_visible)
1194         (tui_source_window_base::make_visible, make_all_visible)
1195         (tui_make_all_visible, tui_make_all_invisible): Update.
1196         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
1197         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
1198         bool.
1199         (struct tui_win_info, struct tui_source_window_base)
1200         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
1201         * tui/tui-data.c (tui_init_generic_part): Update.
1202
1203 2019-06-25  Tom Tromey  <tom@tromey.com>
1204
1205         * tui/tui-wingeneral.c (tui_win_info::make_visible)
1206         (tui_source_window_base::make_visible): New methods.
1207         (make_all_visible): Make method call.
1208         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
1209         (struct tui_source_window_base, struct tui_cmd_window): Override
1210         make_visible.
1211         (tui_win_is_source_type): Don't declare.
1212         * tui/tui-data.c (tui_win_is_source_type): Remove.
1213
1214 2019-06-25  Tom Tromey  <tom@tromey.com>
1215
1216         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
1217         NULL check.
1218
1219 2019-06-25  Tom Tromey  <tom@tromey.com>
1220
1221         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
1222         Inline constructor.  Add initializers for members.
1223         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
1224         constructors; now inline in class.
1225
1226 2019-06-25  Tom Tromey  <tom@tromey.com>
1227
1228         * tui/tui-regs.c (tui_show_registers): Update.
1229         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
1230         bool.
1231         * tui/tui-data.c (tui_data_window::clear_detail)
1232         (tui_data_window): Update.
1233
1234 2019-06-25  Tom Tromey  <tom@tromey.com>
1235
1236         * tui/tui-windata.c (tui_display_all_data)
1237         (tui_display_data_from_line, tui_display_data_from)
1238         (tui_check_data_values, tui_data_window::do_scroll_vertical):
1239         Update.
1240         * tui/tui-regs.c (tui_last_regs_line_no)
1241         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1242         (tui_show_registers, tui_show_register_group)
1243         (tui_display_registers_from, tui_display_reg_element_at_line)
1244         (tui_display_registers_from_line, tui_check_register_values)
1245         (tui_reg_next, tui_reg_prev): Update.
1246         * tui/tui-layout.c (tui_set_layout, show_data): Update.
1247         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
1248         tui_data_window.
1249         (struct tui_win_info) <detail>: Remove.  Add new fields from
1250         tui_data_info.
1251         (TUI_DATA_WIN): Add cast.
1252         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
1253         (~tui_data_window): Simplify.
1254
1255 2019-06-25  Tom Tromey  <tom@tromey.com>
1256
1257         * tui/tui-layout.c (show_source_disasm_command)
1258         (show_source_or_disasm_and_command): Update.
1259         * tui/tui-io.c (update_cmdwin_start_line)
1260         (tui_redisplay_readline): Update.
1261         * tui/tui-data.h (struct tui_command_info): Remove.
1262         (struct tui_win_info) <detail>: Remove command_info member.
1263         (struct tui_data_window) <start_line>: New member, from
1264         tui_command_info.
1265         (TUI_CMD_WIN): Add casts.
1266
1267 2019-06-25  Tom Tromey  <tom@tromey.com>
1268
1269         * tui/tui-winsource.c (tui_update_source_window)
1270         (tui_refill_source_window)
1271         (tui_source_window_base::do_scroll_horizontal)
1272         (tui_update_breakpoint_info, tui_set_exec_info_content)
1273         (tui_show_exec_info_content, tui_erase_exec_info_content)
1274         (tui_clear_exec_info_content): Update.
1275         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
1276         Update.
1277         * tui/tui-win.c (make_invisible_and_set_new_height)
1278         (make_visible_with_new_height): Update.
1279         * tui/tui-source.c (tui_set_source_content)
1280         (tui_show_symtab_source): Update.
1281         * tui/tui-layout.c (extract_display_start_addr)
1282         (show_source_disasm_command, show_data)
1283         (make_source_or_disasm_window)
1284         (show_source_or_disasm_and_command): Update.
1285         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
1286         (tui_disasm_window::do_scroll_vertical): Remove shadowing
1287         "gdbarch".
1288         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
1289         to tui_source_window_base.
1290         (struct tui_win_info) <detail>: Remove source_info member.
1291         (struct tui_source_window_base) <has_locator>: Inline.
1292         Move contents from tui_source_info; rename has_locator member to
1293         m_has_locator.
1294         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
1295         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
1296         header file.
1297         (tui_source_window_base::clear_detail, ~tui_source_window_base):
1298         Simplify.
1299         (tui_free_all_source_wins_content): Cast to
1300         tui_source_window_base.
1301
1302 2019-06-25  Tom Tromey  <tom@tromey.com>
1303
1304         * tui/tui-win.c (make_invisible_and_set_new_height)
1305         (make_visible_with_new_height): Call has_locator method.
1306         * tui/tui-layout.c (show_source_disasm_command, show_data)
1307         (show_source_or_disasm_and_command): Update for bool change.
1308         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
1309         (tui_win_info) <has_locator>: New method.
1310         (struct tui_source_window_base) <has_locator>: New method.
1311         (tui_win_has_locator): Don't declare.
1312         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
1313         from tui_win_has_locator.
1314         (tui_source_window_base): Use false, not FALSE.
1315
1316 2019-06-25  Tom Tromey  <tom@tromey.com>
1317
1318         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
1319         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
1320         clear_detail method directly.
1321         (tui_clear_win_detail): Remove.
1322
1323 2019-06-25  Tom Tromey  <tom@tromey.com>
1324
1325         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
1326         "this", not TUI_DISASM_WIN.
1327
1328 2019-06-25  Tom Tromey  <tom@tromey.com>
1329
1330         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
1331         declare.
1332         * tui/tui-winsource.c
1333         (tui_source_window_base::do_scroll_horizontal): Rename from
1334         tui_horizontal_source_scroll.
1335         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
1336         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
1337         from tui_vertical_data_scroll.
1338         * tui/tui-win.h (tui_scroll): Don't declare.
1339         * tui/tui-win.c (tui_win_info::forward_scroll)
1340         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1341         (tui_win_info::right_scroll): Rename and update.
1342         (tui_scroll_forward_command, tui_scroll_backward_command)
1343         (tui_scroll_left_command, tui_scroll_right_command): Update.
1344         (tui_scroll): Remove.
1345         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
1346         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
1347         from tui_vertical_source_scroll.
1348         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
1349         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
1350         from tui_vertical_disassem_scroll.
1351         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
1352         do_scroll_horizontal>: New methods.
1353         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
1354         Likewise.
1355         (struct tui_source_window_base): Add do_scroll_horizontal.
1356         (struct tui_source_window, struct tui_disasm_window): Add
1357         do_scroll_vertical.
1358         (struct tui_data_window, struct tui_cmd_window): Add
1359         do_scroll_horizontal and do_scroll_vertical.
1360         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
1361
1362 2019-06-25  Tom Tromey  <tom@tromey.com>
1363
1364         * tui/tui-data.h (struct tui_source_window_base): New struct.
1365         (struct tui_source_window): Derive from tui_source_window_base.
1366         (struct tui_disasm_window): New struct.
1367         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
1368         from tui_source_window::clear_detail.
1369         (tui_source_window_base): Rename from tui_source_window.
1370         (~tui_source_window_base): Rename from ~tui_source_window.
1371         (tui_alloc_win_info): Create a tui_disasm_window.
1372
1373 2019-06-25  Tom Tromey  <tom@tromey.com>
1374
1375         * tui/tui-data.h (struct tui_source_window)
1376         (struct tui_data_window): Declare destructors.
1377         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
1378         destructors.
1379         (tui_win_info): Simplify.
1380
1381 2019-06-25  Tom Tromey  <tom@tromey.com>
1382
1383         * tui/tui-winsource.c (tui_display_main)
1384         (tui_update_source_windows_with_addr)
1385         (tui_update_all_breakpoint_info): Update.
1386         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1387         (new_height_ok, parse_scrolling_args): Update.
1388         * tui/tui-stack.c (tui_show_frame_info): Update.
1389         * tui/tui-data.h (struct tui_list): Remove.
1390         (tui_source_windows): Return a reference to a std::vector.
1391         * tui/tui-data.c (source_windows): Now a std::vector.
1392         (tui_source_windows): Change return type.
1393         (tui_clear_source_windows): Rewrite.
1394         (tui_clear_source_windows_detail, tui_add_to_source_windows)
1395         (tui_free_all_source_wins_content): Rewrite.
1396
1397 2019-06-25  Tom Tromey  <tom@tromey.com>
1398
1399         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
1400         (struct tui_data_window, struct tui_cmd_window): Declare
1401         clear_detail method.
1402         * tui/tui-data.c (tui_source_window::clear_detail)
1403         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
1404         methods.
1405         (tui_clear_win_detail): Simplify.
1406
1407 2019-06-25  Tom Tromey  <tom@tromey.com>
1408
1409         * tui/tui-layout.c (make_source_window, make_disasm_window)
1410         (make_source_or_disasm_window): Remove win_info_ptr parameter.
1411         Return the new window.
1412         (show_source_disasm_command, show_data)
1413         (show_source_or_disasm_and_command): Update.
1414
1415 2019-06-25  Tom Tromey  <tom@tromey.com>
1416
1417         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
1418         parameter.  Return the new window.
1419         (show_source_disasm_command): Update and remove NULL check.
1420         (show_source_or_disasm_and_command): Update.
1421
1422 2019-06-25  Tom Tromey  <tom@tromey.com>
1423
1424         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
1425
1426 2019-06-25  Tom Tromey  <tom@tromey.com>
1427
1428         * tui/tui-data.h (struct tui_win_info): Make constructor
1429         protected.  Make destructor virtual.  Add initializers.
1430         (tui_source_window, tui_data_window, tui_cmd_window): New
1431         classes.
1432         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
1433         constructor.  Add "type" parameter.
1434         (tui_source_window, tui_data_window, tui_cmd_window): New
1435         constructors.
1436         (tui_alloc_win_info): Instantiate the appropriate subclass.
1437
1438 2019-06-25  Tom Tromey  <tom@tromey.com>
1439
1440         * tui/tui-win.c (tui_resize_all): Use delete.
1441         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
1442         destructor.
1443         (tui_free_window): Don't declare.
1444         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
1445         Update.
1446
1447 2019-06-25  Tom Tromey  <tom@tromey.com>
1448
1449         * tui/tui-data.h (struct tui_win_info): Add constructor.
1450         * tui/tui-data.c (tui_alloc_win_info): Use new.
1451         (tui_free_window): Use delete.
1452
1453 2019-06-22  Tom Tromey  <tom@tromey.com>
1454
1455         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
1456         declare.
1457         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
1458
1459 2019-06-22  Tom Tromey  <tom@tromey.com>
1460
1461         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
1462         declare.
1463         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
1464
1465 2019-06-22  Tom de Vries  <tdevries@suse.de>
1466
1467         * dwarf2read.c (create_addrmap_from_aranges)
1468         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
1469         instead of '%zu'.
1470
1471 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
1472
1473         * dwarf2read.h (dwarf2_section_info_def): Remove.
1474         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
1475         * dwarf2read.c (struct dwo_sections) <types>: Change type to
1476         std::vector<dwarf2_section_info>.
1477         (struct dwo_file) <~dwo_file>: Remove.
1478         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
1479         types field.
1480         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
1481         (dwarf2_read_debug_names): Likewise.
1482         (create_debug_types_hash_table): Change parameter type to
1483         array_view, adjust code accordingly.
1484         (dwarf2_locate_dwo_sections): Adjust to std::vector.
1485         (partial_die_info::fixup): Likewise.
1486         (determine_prefix): Likewise.
1487         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
1488
1489 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1490
1491         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
1492         gdb_bfd_ref_ptr.
1493         <~dwo_file>: Remove call to gdb_bfd_unref.
1494         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
1495         gdb_bfd_ref_ptr::get.
1496
1497 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1498
1499         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
1500         type to htab_up.
1501         * dwarf2read.c (struct dwo_file): Initialize fields.
1502         <~dwo_file>: New.
1503         (free_dwo_file): Remove, move content to ~dwo_file.
1504         (struct dwo_file_deleter): Remove.
1505         (dwo_file_up>: Remove custom deleter.
1506         (free_dwo_files): Remove.
1507         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
1508         dwo_files.
1509         (process_skeletonless_type_units): Call unique_ptr::get.
1510         (allocate_dwo_file_hash_table): Add deleter to created hash
1511         table.  Change return type to htab_up.
1512         (lookup_dwo_file_slot): Don't memset dwo_file, call
1513         unique_ptr::get.
1514         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
1515         (create_dwo_unit_in_dwp_v2): Likewise.
1516         (open_and_init_dwo_file): Likewise.
1517         (free_dwo_file_from_slot): Remove.
1518
1519 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1520
1521         * dwarf2read.h (struct dwarf2_section_info) <readin,
1522         is_virtual>: Change type to bool.
1523         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
1524         true instead of 1.
1525
1526 2019-06-19  Tom Tromey  <tom@tromey.com>
1527
1528         * tui/tui-data.h (tui_init_content_element): Don't declare.
1529
1530 2019-06-19  Tom Tromey  <tom@tromey.com>
1531
1532         * tui/tui-data.h (tui_init_win_info): Don't declare.
1533
1534 2019-06-19  Tom de Vries  <tdevries@suse.de>
1535
1536         * dwarf2read.h (abstract_to_concrete): Change type to
1537         std::unordered_map<sect_offset, std::vector<sect_offset>,
1538         gdb::hash_enum<sect_offset>>.
1539
1540 2019-06-19  Tom Tromey  <tromey@adacore.com>
1541
1542         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
1543         EVAL_AVOID_SIDE_EFFECTS specially.
1544
1545 2019-06-19  Tom Tromey  <tromey@adacore.com>
1546
1547         * source-cache.c (highlighter): New global.
1548         (source_cache::get_source_lines): Create a highlighter on demand.
1549
1550 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1551
1552         * defs.h (deprecated_interactive_hook): Delete declaration.
1553         * interps.c (clear_interpreter_hooks): Remove use of
1554         deprecated_interactive_hook.
1555         * top.c (deprecated_interactive_hook): Delete definition.
1556         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
1557
1558 2019-06-18  Tom de Vries  <tdevries@suse.de>
1559
1560         PR gdb/24515
1561         * dwarf2read.h (abstract_to_concrete): Change type from
1562         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
1563         std::unordered_map<sect_offset, std::vector<sect_offset>>.
1564         * dwarf2read.c (read_variable): Update.
1565         (dwarf2_fetch_die_loc_sect_off): Update.
1566
1567 2019-06-17  Tom de Vries  <tdevries@suse.de>
1568
1569         PR gdb/24617
1570         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
1571         accessing parent[parent_len - 1].
1572
1573 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
1574
1575         PR gdb/24364
1576         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
1577         call dtrace_process_dof with NULL dof.
1578
1579 2019-06-16  Tom de Vries  <tdevries@suse.de>
1580
1581         PR gdb/24445
1582         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
1583
1584 2019-06-16  Tom Tromey  <tom@tromey.com>
1585
1586         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1587         (make_all_visible): Use address of member.
1588
1589 2019-06-16  Tom Tromey  <tom@tromey.com>
1590
1591         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
1592         (tui_free_window, free_content, free_content_elements): Remove
1593         unnecessary cast.
1594         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
1595         cast.
1596         * tui/tui-regs.c (tui_show_register_group)
1597         (tui_display_registers_from, tui_display_reg_element_at_line):
1598         Remove unnecessary cast.
1599
1600 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
1601
1602         * linux-nat.c (normal_mask): Delete.
1603         (_initialize_linux_nat): Don't initialise normal_mask.
1604
1605 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
1606
1607         PR gdb/24445
1608         * dwarf-index-write.h (write_psymtabs_to_index): Add
1609         dwz_basename parameter.
1610         * dwarf-index-write.c (write_gdbindex): Move file writing to
1611         write_gdbindex_1.  Change return type void.
1612         (assert_file_size): Move up, remove filename parameter.
1613         (write_gdbindex_1): New function.
1614         (write_debug_names): Change return type to void, call
1615         assert_file_size.
1616         (struct index_wip_file): New struct.
1617         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
1618         file logic to index_wip_file.  Write index for dwz file if
1619         needed.
1620         (save_gdb_index_command): Pass basename of dwz file, if present.
1621         * dwarf-index-cache.c (index_cache::store): Obtain and pass
1622         build-id of dwz file, if present.
1623         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
1624         (dwarf2_get_dwz_file): Likewise.
1625         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
1626         (dwarf2_get_dwz_file): Likewise.
1627
1628 2019-06-16  Tom Tromey  <tom@tromey.com>
1629
1630         * coffread.c (process_coff_symbol): Use xstrdup.
1631         * value.c (create_internalvar): Use xstrdup.
1632
1633 2019-06-16  Tom Tromey  <tom@tromey.com>
1634
1635         * valops.c (value_cast, value_slice): Remove unnecessary cast.
1636         * breakpoint.c (stopin_command, stopat_command)
1637         (until_break_command, decode_location_default): Remove unnecessary
1638         cast.
1639         * utils.c (subset_compare): Remove unnecessary cast.
1640         * ada-lang.c (ada_update_initial_language): Remove unnecessary
1641         cast.
1642         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
1643         cast.
1644         * infcmd.c (path_command): Remove unnecessary cast.
1645         * coffread.c (decode_type): Remove unnecessary cast.
1646         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
1647         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
1648         * tui/tui-stack.c (tui_show_locator_content)
1649         (tui_show_frame_info): Remove unnecessary cast.
1650         * tui/tui-win.c (tui_scroll_forward_command)
1651         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
1652         (parse_scrolling_args): Remove unnecessary cast.
1653         * tui/tui-data.c (init_win_info, tui_del_window)
1654         (tui_free_window, tui_del_data_windows, tui_free_data_content)
1655         (free_content_elements): Remove unnecessary cast.
1656         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
1657         unnecessary cast.
1658         * tui/tui-source.c (tui_set_source_content)
1659         (tui_vertical_source_scroll): Remove unnecessary cast.
1660         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
1661         cast.
1662         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
1663         * tui/tui-regs.c (tui_display_registers_from)
1664         (tui_display_register): Remove unnecessary cast.
1665         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
1666         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
1667         (make_visible): Remove unnecessary cast.
1668         * tui/tui-winsource.c (tui_erase_source_content)
1669         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
1670         unnecessary cast.
1671         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
1672         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
1673         * stabsread.c (read_type, read_array_type, read_range_type):
1674         Remove unnecessary cast.
1675         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
1676         (parse_symbol, parse_type, upgrade_type, parse_external)
1677         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
1678         unnecessary cast.
1679         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
1680
1681 2019-06-16  Tom Tromey  <tom@tromey.com>
1682
1683         * tui/tui-data.c (tui_alloc_generic_win_info)
1684         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
1685         checks.
1686
1687 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
1688             Andrew Burgess  <andrew.burgess@embecosm.com>
1689
1690         * f-typeprint.c (f_print_type): Don't return early for not
1691         associated or not allocated types.
1692         (f_type_print_varspec_suffix): Add print_rank parameter and print
1693         ranks of array types in case they dangling.
1694         (f_type_print_base): Add print_rank parameter.
1695
1696 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1697
1698         * NEWS: Mention new MI commands.
1699         * break-catch-throw.c (enum exception_event_kind): Move to
1700         breakpoint.h.
1701         (print_mention_exception_catchpoint): Output text as a single
1702         message.
1703         (catch_exception_command_1): Rename to...
1704         (catch_exception_event): ...this, make non-static, update header
1705         command, and change some parameter types.
1706         (catch_catch_command): Update for changes to
1707         catch_exception_command_1.
1708         (catch_throw_command): Likewise.
1709         (catch_rethrow_command): Likewise.
1710         * breakpoint.c (enum exception_event_kind): Delete.
1711         * breakpoint.h (enum exception_event_kind): Moved here from
1712         break-catch-throw.c.
1713         (catch_exception_event): Declare.
1714         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
1715         (mi_cmd_catch_throw): New function.
1716         (mi_cmd_catch_rethrow): New function.
1717         (mi_cmd_catch_catch): New function.
1718         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
1719         'catch-catch' entries.
1720         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
1721         (mi_cmd_catch_rethrow): Declare.
1722         (mi_cmd_catch_catch): Declare.
1723
1724 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1725
1726         * annotate.c (annotate_source_line): Change return type to void,
1727         update implementation to match.
1728         * annotate.h (annotate_source_line): Change return type to void,
1729         update header comment.
1730         * stack.c (print_frame_info): Don't change what frame information
1731         is printed based on whether annotations are on or not.
1732
1733 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1734
1735         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
1736         (annotate_source): Make static.
1737         (annotate_source_line): Moved from source.c and renamed from
1738         identify_source_line.  Update the return type.
1739         * annotate.h (annotate_source): Delete declaration.
1740         (annotate_source_line): Declaration moved from source.h, and
1741         renamed from identify_source_line.  Return type updated.
1742         * source.c (identify_source_line): Moved to annotate.c and renamed
1743         to annotate_source_line.
1744         (info_line_command): Remove check of annotation_level.
1745         * source.h (identify_source_line): Move declaration to annotate.h
1746         and rename to annotate_source_line.
1747         * stack.c: Add 'annotate.h' include.
1748         (print_frame_info): Remove check of annotation_level before
1749         calling annotate_source_line.
1750
1751 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1752
1753         * source-cache.c (source_cache::get_plain_source_lines): Use
1754         open_source_file_with_line_charpos instead of just
1755         open_source_file, remove call to find_source_lines.
1756         (source_cache::get_source_lines): Likewise.
1757         * source.c (find_source_lines): Make static.
1758         (get_filename_and_charpos): Renamed into...
1759         (open_source_file_with_line_charpos): ..this along with changes to
1760         return a scoped_fd, and some other minor clean ups.
1761         (identify_source_line): Use open_source_file_with_line_charpos.
1762         (search_command_helper): Use open_source_file_with_line_charpos
1763         instead of just open_source_file, remove call to
1764         find_source_lines.
1765         * source.h (open_source_file_with_line_charpos): Declare new
1766         function.
1767         (find_source_lines): Delete declaration.
1768
1769 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1770
1771         * source.c (get_filename_and_charpos): Remove fullname
1772         parameter.
1773         (identify_source_line): Update call to get_filename_and_charpos.
1774
1775 2019-06-14  Tom Tromey  <tromey@adacore.com>
1776
1777         PR gdb/24502:
1778         * ui-style.h (skip_ansi_escape): Update comment.
1779         * ui-file.h (class no_terminal_escape_file): New class.
1780         * ui-file.c (no_terminal_escape_file::write)
1781         (no_terminal_escape_file::puts): New methods.
1782         * cli/cli-logging.c (handle_redirections): Use
1783         no_terminal_escape_file.
1784
1785 2019-06-14  Tom Tromey  <tromey@adacore.com>
1786
1787         * NEWS: Move convenience variable news above Python news.
1788
1789 2019-06-14  Tom Tromey  <tom@tromey.com>
1790
1791         * gnulib: Move directory to top-level.
1792         * configure.ac: Don't configure gnulib.
1793         * configure: Rebuild.
1794         * common/common-defs.h: Use new path to gnulib.
1795         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
1796         (GNULIB_H): Remove.
1797         (INCGNU): Look in new gnulib location.
1798         (HFILES_NO_SRCDIR): Remove gnulib files.
1799         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
1800         (generated_files): Remove GNULIB_H.
1801         ($(LIBGNU), all-lib): Remove targets.
1802         (distclean): Don't mention GNULIB_BUILDDIR.
1803         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
1804
1805 2019-06-14  Tom Tromey  <tromey@adacore.com>
1806
1807         * symfile.c (add_symbol_file_command): Remove obsolete comment.
1808         Warn if symbol file does not provide any symbols.
1809
1810 2019-06-14  Tom Tromey  <tromey@adacore.com>
1811
1812         * source.c (find_and_open_source): Respect basenames_may_differ.
1813
1814 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
1815
1816         * annotate.c (annotate_breakpoints_invalid): Make use of
1817         scoped_restore_terminal_state.
1818         (annotate_frames_invalid): Likewise.
1819
1820 2019-06-14  Tom Tromey  <tromey@adacore.com>
1821
1822         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
1823         allow assignment to an internalvar.
1824
1825 2019-06-14  Tom Tromey  <tromey@adacore.com>
1826
1827         * ada-lex.l: Allow "_" in attribute names.
1828
1829 2019-06-14  Tom Tromey  <tromey@adacore.com>
1830
1831         PR gdb/24653:
1832         * regcache.c (registers_changed): Don't call alloca.
1833         * top.c (execute_command): Don't call alloca.
1834
1835 2019-06-13  Pedro Alves  <palves@redhat.com>
1836
1837         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
1838         'expression'.  When parsing an expression, error out if there's
1839         junk after "unlimited".
1840         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1841         (do_set_command): Adjust calls to is_unlimited_literal.
1842
1843 2019-06-13  Pedro Alves  <palves@redhat.com>
1844
1845         * compile/compile.c (make_compile_options_def_group): Add braces
1846         around array_view initializer.
1847         * thread.c (make_thread_apply_all_options_def_group)
1848         (make_thread_apply_all_options_def_group): Likewise.
1849
1850 2019-06-13  Pedro Alves  <palves@redhat.com>
1851
1852         * NEWS (New commands): Mention "maint test-options
1853         require-delimiter", "maint test-options unknown-is-error", "maint
1854         test-options unknown-is-operand" and "maint show
1855         test-options-completion-result".
1856         (New command options, command completion): New section.
1857         (Completion improvements): New section.
1858         Mention that you can abbreviate "unlimited".
1859
1860 2019-06-13  Pedro Alves  <palves@redhat.com>
1861
1862         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
1863         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
1864         * unittests/cli-utils-selftests.c (test_parse_flags)
1865         (test_parse_flags_qcs): Delete.
1866         (test_cli_utils): Don't call deleted functions.
1867
1868 2019-06-13  Pedro Alves  <palves@redhat.com>
1869
1870         * thread.c: Include "cli/cli-option.h".
1871         (tp_array_compar_ascending): Global.
1872         (tp_array_compar): Delete function.
1873         (tp_array_compar_ascending, tp_array_compar_descending): New
1874         functions.
1875         (ascending_option_def, qcs_flag_option_def)
1876         (thr_qcs_flags_option_defs)
1877         (make_thread_apply_all_options_def_group)
1878         (make_thread_apply_options_def_group): New.
1879         (thread_apply_all_command): Use gdb::option::process_options.
1880         (thread_apply_command_completer)
1881         (thread_apply_all_command_completer): New.
1882         (thread_apply_command): Use gdb::option::process_options.
1883         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
1884         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
1885         to generate help text of "thread apply".  Adjust "taas"'s help.
1886         * tid-parse.c (tid_range_parser::in_thread_range): New method.
1887         * tid-parse.h (tid_range_parser::in_thread_range): New method.
1888
1889 2019-06-13  Pedro Alves  <palves@redhat.com>
1890
1891         * thread.c (thread_apply_command): Check for invalid TID with
1892         isdigit instead of !isalpha.
1893
1894 2019-06-13  Pedro Alves  <palves@redhat.com>
1895
1896         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
1897         (validate_flags_qcs): New.
1898         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
1899         (validate_flags_qcs): Declare.
1900         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
1901         (make_frame_apply_options_def_group): New.
1902         (frame_apply_command_count): Process options with
1903         gdb::option::process_options.
1904         (frame_apply_completer): New.
1905         (frame_apply_level_completer, frame_apply_all_completer)
1906         (frame_apply_completer): New.
1907         (_initialize_stack): Update help of "frame apply", "frame apply
1908         level", "frame apply all" and "faas" to mention supported options
1909         and install command completers.
1910         * stack.h (frame_apply_all_completer): Declare.
1911         * thread.c: Include "stack.h".
1912         (tfaas_command): Add "--".
1913         (_initialize_thread): Update help "tfaas" to mention supported
1914         options and install command completer.
1915
1916 2019-06-13  Pedro Alves  <palves@redhat.com>
1917
1918         * completer.c (complete_nested_command_line): New.
1919         (gdb_completion_word_break_characters_throw): Add assertion.
1920         * completer.h (complete_nested_command_line): Declare.
1921
1922 2019-06-13  Pedro Alves  <palves@redhat.com>
1923
1924         * stack.c (parse_backtrace_qualifiers): New.
1925         (backtrace_command): Use it.
1926         (backtrace_command_completer): Complete on qualifiers.
1927
1928 2019-06-13  Pedro Alves  <palves@redhat.com>
1929
1930         * frame.c: Include "cli/cli-option.h.
1931         (user_set_backtrace_options): New.
1932         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
1933         Delete.
1934         (get_prev_frame): Adjust.
1935         (boolean_option_def, uinteger_option_def)
1936         (set_backtrace_option_defs): New.
1937         (_initialize_frame): Adjust and use
1938         gdb::option::add_setshow_cmds_for_options to install "set
1939         backtrace past-main" and "set backtrace past-entry".
1940         * frame.h: Include "cli/cli-option.h".
1941         (struct frame_print_options): Forward declare.
1942         (print_frame_arguments_all, print_frame_arguments_scalars)
1943         (print_frame_arguments_none): Declare.
1944         (print_entry_values): Delete declaration.
1945         (struct frame_print_options, user_frame_print_options): New.
1946         (struct set_backtrace_options): New.
1947         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
1948         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
1949         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
1950         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
1951         (list_args_or_locals): Add frame_print_options parameter.
1952         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1953         * python/py-framefilter.c (enumerate_args): Pass down
1954         USER_FRAME_PRINT_OPTIONS.
1955         * stack.c: Include "cli/cli-option.h".
1956         (print_frame_arguments_all, print_frame_arguments_scalars)
1957         (print_frame_arguments_none): Declare.
1958         (print_raw_frame_arguments, print_entry_values): Delete.
1959         (user_frame_print_options): New.
1960         (boolean_option_def, enum_option_def, frame_print_option_defs):
1961         New.
1962         (struct backtrace_cmd_options): New.
1963         (bt_flag_option_def): New.
1964         (backtrace_command_option_defs): New.
1965         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1966         (print_frame_arg, read_frame_arg, print_frame_args)
1967         (print_frame_info, print_frame): Add frame_print_options parameter
1968         and use it.
1969         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
1970         (backtrace_command_1): Add frame_print_options and
1971         backtrace_cmd_options parameters and use them.
1972         (make_backtrace_options_def_group): New.
1973         (backtrace_command): Process command options with
1974         gdb::option::process_options.
1975         (backtrace_command_completer): New.
1976         (_initialize_stack): Extend "backtrace"'s help to mention
1977         supported options.  Install completer for "backtrace".
1978         Install some settings commands with add_setshow_cmds_for_options.
1979
1980 2019-06-13  Pedro Alves  <palves@redhat.com>
1981
1982         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
1983         and that "set/show print raw frame-arguments" are now deprecated.
1984
1985         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
1986         command.
1987         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
1988         * stack.c (_initialize_stack): Install "set/show print
1989         raw-frame-arguments", and deprecate "set/show print raw
1990         frame-arguments".
1991         * valprint.c (_initialize_valprint): Deprecate "set/show print
1992         raw".
1993
1994 2019-06-13  Pedro Alves  <palves@redhat.com>
1995
1996         * compile/compile.c (struct compile_options): New.
1997         (compile_flag_option_def, compile_command_option_defs)
1998         (make_compile_options_def_group): New.
1999         (compile_file_command): Handle options with
2000         gdb::option::process_options.
2001         (compile_file_command_completer): New function.
2002         (compile_code_command): Handle options with
2003         gdb::option::process_options.
2004         (compile_code_command_completer): New function.
2005         (_initialize_compiler): Install completers for "compile code" and
2006         "compile file".  Mention available options in "compile code" and
2007         "compile code"'s help.
2008         * completer.c (advance_to_completion_word): New, factored out from
2009         ...
2010         (advance_to_expression_complete_word_point): ... this.
2011         (advance_to_filename_complete_word_point): New.
2012         * completer.h (advance_to_filename_complete_word_point): New
2013         declaration.
2014
2015 2019-06-13  Pedro Alves  <palves@redhat.com>
2016
2017         * compile/compile.c: Include "cli/cli-option.h".
2018         (compile_print_value): Scope data pointer is now a
2019         value_print_options pointer; adjust.
2020         (compile_print_command): Process options.  Scope data pointer is
2021         now a value_print_options pointer; adjust.
2022         (_initialize_compile): Update "compile print"'s help to include
2023         supported options.  Install a completer for "compile print".
2024         * cp-valprint.c (show_vtblprint, show_objectprint)
2025         (show_static_field_print): Delete.
2026         (_initialize_cp_valprint): Don't install "set print
2027         static-members", "set print vtbl", "set print object" here.
2028         * printcmd.c: Include "cli/cli-option.h" and
2029         "common/gdb_optional.h".
2030         (print_command_parse_format): Rework to fill in a
2031         value_print_options instead of a format_data.
2032         (print_value): Change parameter type from format_data pointer to
2033         value_print_options reference.  Adjust.
2034         (print_command_1): Process options.  Adjust to pass down a
2035         value_print_options.
2036         (print_command_completer): New.
2037         (_initialize_printcmd): Install print_command_completer as
2038         handle_brkchars completer for the "print" command.  Update
2039         "print"'s help to include supported options.
2040         * valprint.c: Include "cli/cli-option.h".
2041         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2042         here from cp-valprint.c.
2043         (boolean_option_def, uinteger_option_def)
2044         (value_print_option_defs, make_value_print_options_def_group):
2045         New.  Use gdb::option::add_setshow_cmds_for_options to install
2046         "set print elements", "set print null-stop", "set print repeats",
2047         "set print pretty", "set print union", "set print array", "set
2048         print address", "set print symbol", "set print array-indexes".
2049         * valprint.h: Include <string> and "cli/cli-option.h".
2050         (make_value_print_options_def_group): Declare.
2051         (print_value): Change parameter type from format_data pointer to
2052         value_print_options reference.
2053         (print_command_completer): Declare.
2054
2055 2019-06-13  Pedro Alves  <palves@redhat.com>
2056
2057         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2058         (COMMON_SFILES): Add maint-test-settings.c.
2059         * cli/cli-decode.c (boolean_enums): New global, factored out from
2060         ...
2061         (add_setshow_boolean_cmd): ... here.
2062         * cli/cli-decode.h (boolean_enums): Declare.
2063         * cli/cli-option.c: New file.
2064         * cli/cli-option.h: New file.
2065         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2066         factored out from ...
2067         (parse_cli_boolean_value(const char *)): ... this.
2068         (is_unlimited_literal): Change parameter type to pointer to
2069         pointer.  Adjust and advance ARG pointer.
2070         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2071         (parse_cli_var_enum): New, factored out from ...
2072         (do_set_command): ... this.  Adjust.
2073         * cli/cli-setshow.h (parse_cli_boolean_value)
2074         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2075         (parse_cli_var_enum): Declare.
2076         * cli/cli-utils.c: Include "cli/cli-option.h".
2077         (get_ulongest): New.
2078         * cli/cli-utils.h (get_ulongest): Declare.
2079         (check_for_argument): New overloads.
2080         * maint-test-options.c: New file.
2081
2082 2019-06-13  Pedro Alves  <palves@redhat.com>
2083
2084         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2085         parse a range if "-" is at the end of the string.
2086
2087 2019-06-13  Pedro Alves  <palves@redhat.com>
2088
2089         * cli/cli-setshow.c (parse_auto_binary_operation)
2090         (parse_cli_boolean_value): Don't allow "o".
2091
2092 2019-06-13  Pedro Alves  <palves@redhat.com>
2093
2094         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2095         * NEWS: Mention maint test-settings KIND.
2096         * maint-test-settings.c: New file.
2097
2098 2019-06-13  Pedro Alves  <palves@redhat.com>
2099
2100         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2101         completer.
2102         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2103         "set" completers.
2104
2105 2019-06-13  Pedro Alves  <palves@redhat.com>
2106
2107         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2108         after item.
2109
2110 2019-06-13  Pedro Alves  <palves@redhat.com>
2111
2112         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2113
2114 2019-06-13  Pedro Alves <palves@redhat.com>
2115
2116         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2117         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2118         call.
2119         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2120         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2121         calls.
2122         (check_for_argument): Skip spaces after argument.
2123
2124 2019-06-13  Pedro Alves  <palves@redhat.com>
2125
2126         * thread.c (thread_apply_command): Adjust TID parsing.
2127         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2128         detected before end of string.
2129         (tid_is_in_list): Error out if LIST is invalid.
2130
2131 2019-06-13  Pedro Alves  <palves@redhat.com>
2132
2133         * completer.c (complete_line_internal_1): Rewind completion word
2134         point.
2135         (completion_tracker::advance_custom_word_point_by): Change
2136         parameter type to int.
2137         * completer.h (completion_tracker::advance_custom_word_point_by):
2138         Likewise.
2139
2140 2019-06-13  Pedro Alves  <palves@redhat.com>
2141
2142         * completer.c (advance_to_completion_word): Handle delimiters.
2143
2144 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2145
2146         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2147
2148 2019-06-11  Tom Tromey  <tom@tromey.com>
2149
2150         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2151         (xmalloc_failed): Move to alloc.c.
2152         * alloc.c: New file.
2153         * Makefile.in (COMMON_SFILES): Add alloc.c.
2154
2155 2019-06-11  Tom Tromey  <tom@tromey.com>
2156
2157         * nat/linux-waitpid.c: Don't include server.h.
2158         (linux_debug): Remove.
2159         (my_waitpid): Update.
2160
2161 2019-06-11  Tom Tromey  <tromey@adacore.com>
2162
2163         * infcall.c (_initialize_infcall): Remove trailing newline from
2164         help.
2165         * user-regs.c (_initialize_user_regs): Remove trailing newline
2166         from help.
2167         * typeprint.c (_initialize_typeprint): Remove trailing newline
2168         from help.
2169         * reverse.c (_initialize_reverse): Remove trailing newlines from
2170         help.
2171         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2172         from help.
2173         * language.c (add_set_language_command): Remove trailing newline
2174         from help.
2175         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2176         help.
2177         * disasm.c (_initialize_disasm): Remove trailing newline from
2178         help.
2179         * top.c (init_main): Remove trailing newline from help.
2180         * interps.c (_initialize_interpreter): Remove trailing newline
2181         from help.
2182         * btrace.c (_initialize_btrace): Remove trailing newlines from
2183         help.
2184         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
2185         from help.
2186         * python/python.c (_initialize_python): Remove trailing newline
2187         from help.
2188         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
2189         help.
2190         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
2191         from help.  Reformat some text.
2192         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
2193         from help.
2194         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
2195         newline from help.
2196
2197 2019-06-11  Tom Tromey  <tromey@adacore.com>
2198
2199         * darwin-nat.c (darwin_decode_exception_message)
2200         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
2201
2202 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2203
2204         * valops.c (value_slice): Check for not allocated or not
2205         associated values.
2206
2207 2019-06-10  Tom de Vries  <tdevries@suse.de>
2208
2209         PR gdb/24618
2210         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
2211         sure an empty slot (defined by a 32-bit zero pair) is recognized as
2212         invalid.
2213
2214 2019-06-10  Tom de Vries  <tdevries@suse.de>
2215
2216         PR gdb/24611
2217         * linespec.c (linespec_lexer_lex_string): Remove incorrect
2218         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
2219
2220 2019-06-10  Tom de Vries  <tdevries@suse.de>
2221
2222         PR symtab/24545
2223         * symtab.c (struct demangled_name_entry): Add language field.
2224         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
2225         static minimal symbol".  Set and use language field.
2226
2227 2019-06-10  Tom Tromey  <tromey@adacore.com>
2228
2229         * ada-lang.c (_initialize_ada_language): Update help text.
2230
2231 2019-06-10  Tom Tromey  <tromey@adacore.com>
2232
2233         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
2234         with a newline.
2235         * guile/guile.c (handle_boot_error): Don't end warning with a
2236         newline.
2237         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
2238         warning with a newline.
2239         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
2240         newline.
2241         (s12z_frame_cache): Likewise.
2242         * dwarf-index-cache.c (index_cache::store): Don't end warning with
2243         a newline.
2244         * solib-svr4.c (disable_probes_interface): Don't end warning with
2245         a newline.
2246         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2247         newline.
2248         * python/python.c (do_finish_initialization): Don't end warning
2249         with a newline.
2250
2251 2019-06-10  Tom Tromey  <tom@tromey.com>
2252
2253         * python/py-breakpoint.c (gdbpy_breakpoint_created)
2254         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
2255         gdbpy_enter.
2256
2257 2019-06-10  Tom Tromey  <tromey@adacore.com>
2258
2259         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
2260         data.
2261         (elf_new_init): Don't call stabsread_new_init.
2262         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
2263         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
2264         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
2265
2266 2019-06-10  Tom de Vries  <tdevries@suse.de>
2267
2268         PR symtab/16264
2269         PR symtab/24517
2270         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
2271
2272 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
2273
2274         * source.c (find_and_open_source): Also rewrite relative file
2275         names.
2276
2277 2019-04-26  Amos Bird  <amosbird@gmail.com>
2278
2279         * annotate.c (annotate_thread_exited): Add "thread-exited"
2280         annotation.
2281
2282 2019-06-06  Tom Tromey  <tromey@adacore.com>
2283
2284         * maint.h (class scoped_command_stats): Use
2285         DISABLE_COPY_AND_ASSIGN.
2286         <print_time>: New method.
2287         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
2288         print_time.
2289         (scoped_command_stats::print_time): New method.
2290
2291 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2292
2293         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
2294         instructions of lengths 6 or 8 bytes.
2295
2296 2019-06-04  Pedro Alves  <palves@redhat.com>
2297
2298         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
2299
2300         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
2301         * breakpoint.c (condition_completer): Likewise.
2302         * cli/cli-dump.c (scan_expression): Likewise.
2303         * common/filestuff.c (mkdir_recursive): Likewise.
2304         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
2305         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
2306         (gdb_abspath): Likewise.
2307         * compile/compile-cplus-types.c
2308         (compile_cplus_instance::decl_name): Likewise.
2309         * completer.c (complete_explicit_location):
2310         (signal_completer, reg_or_group_completer_1): Likewise.
2311         * cp-support.c (cp_remove_params_if_any): Likewise.
2312         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
2313         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
2314         * infcmd.c (strip_bg_char): Likewise.
2315         * linespec.c (copy_token_string): Likewise.
2316         * mi/mi-main.c (output_cores): Likewise.
2317         * psymtab.c (psymtab_search_name):
2318         * symfile.c (test_set_ext_lang_command): Likewise.
2319         * target.c (target_fileio_read_stralloc): Likewise.
2320         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
2321         * value.c (complete_internalvar): Likewise.
2322
2323 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
2324
2325         Add objfile property to gdb.Type.
2326         * NEWS: Mention Python API addition.
2327         * python/py-type.c (typy_get_objfile): New method.
2328
2329 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2330
2331         * NEWS: Mention the new set|show style [title|highlight].
2332         Mention changes to "show style", "help" and "apropos".
2333
2334 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2335
2336         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
2337         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
2338         instead of print_help_for_command.
2339         (print_doc_of_command): New function.
2340         (help_list): Add 'apropos -v word' suggestion.
2341         (print_help_for_command): Style the command name using title style.
2342         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
2343         (_initialize_cli_cmds): Describe -v in apropos_command help.
2344
2345 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2346
2347         * cli/cli-style.h (cli_style_option): Add name in constructor,
2348         add m_name class member, add constructor with intensity,
2349         add name class function.
2350         (cli_style_option::add_setshow_commands): Remove name argument.
2351         (highlight_style, title_style): New styles.
2352         * cli/cli-style.c (do_show): New function that shows a style
2353         characteristic styling the style name with itself.
2354         (set_style_name): New function.
2355         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
2356         Update all callers according to the changes in cli/cli-style.h.
2357         * utils.h (fputs_highlighted): New function.
2358         * utils.c (fputs_highlighted): Likewise.
2359
2360 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2361
2362         * NEWS: Mention new pipe command and new convenience variables.
2363
2364 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2365
2366         * cli/cli-cmds.c (pipe_command): New function.
2367         (_initialize_cli_cmds): Call add_com for pipe_command.
2368         Define | as an alias for pipe.
2369         (exit_status_set_internal_vars): New function.
2370         (shell_escape): Call exit_status_set_internal_vars.
2371         cli/cli-decode.c (find_command_name_length): Recognize | as
2372         a single character command.
2373
2374 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2375
2376         * gdbcmd.h (execute_command_to_ui_file): New declaration.
2377         top.c (execute_command_to_ui_file): New function, mostly a copy
2378         of execute_command_to_string.
2379         (execute_command_to_string): Implement by calling
2380         execute_command_to_ui_file.
2381
2382 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2383
2384         * top.h (saved_command_line): Remove declaration.
2385         * top.c (previous_saved_command_line, previous_repeat_arguments):
2386         New variables.
2387         (saved_command_line): Make static, define together with other
2388         'repeat variables'.
2389         (dont_repeat): Clear repeat_arguments.
2390         (repeat_previous, get_saved_command_line, save_command_line):
2391         New functions.
2392         (gdb_init): Initialize saved_command_line
2393         and previous_saved_command_line.
2394         * main.c (captured_main_1): Remove saved_command_line initialization.
2395         * event-top.c (handle_line_of_input): Update to use
2396         the new 'repeat' related functions instead of direct access to
2397         saved_command_line.
2398         * command.h (repeat_previous, get_saved_command_line,
2399         save_command_line): New declarations.
2400         (dont_repeat): Add comment.
2401
2402 2019-05-30  Tom Tromey  <tromey@adacore.com>
2403
2404         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
2405         Fix comment.
2406         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
2407
2408 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
2409
2410         PR cli/24587
2411         * completer.c (complete): Initialize variable word.
2412
2413 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
2414
2415         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2416         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
2417         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
2418         'body' is NULL to the outter 'if', protecting the '!is_define'
2419         situation as well.
2420
2421 2019-05-29  Tom Tromey  <tromey@adacore.com>
2422
2423         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
2424         (dwarf_unknown): New function.
2425         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
2426         (dwarf_type_encoding_name): Use dwarf_unknown.
2427
2428 2019-05-29  Tom Tromey  <tromey@adacore.com>
2429
2430         PR c++/20020:
2431         * cp-valprint.c (cp_print_value_fields): Call
2432         cp_print_static_field inside "try".
2433
2434 2019-05-29  Tom Tromey  <tromey@adacore.com>
2435
2436         * inflow.c (struct terminal_info): Add default operator=.
2437         * configure: Rebuild.
2438         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
2439         -Wdeprecated-copy-dtor, -Wredundant-move.
2440
2441 2019-05-29  Tom Tromey  <tromey@adacore.com>
2442
2443         * NEWS: Add entry.
2444         * infcmd.c (print_return_value_1): Handle finish_print
2445         option.
2446         (show_print_finish): New function.
2447         (_initialize_infcmd): Add "set/show print finish" commands.
2448         * valprint.c (user_print_options): Initialize new member.
2449         * valprint.h (struct value_print_options) <finish_print>: New
2450         member.
2451
2452 2019-05-28  Tom Tromey  <tromey@adacore.com>
2453
2454         * ada-lang.c (ada_remove_Xbn_suffix)
2455         (find_old_style_renaming_symbol)
2456         (parse_old_style_renaming): Remove.
2457         (ada_find_renaming_symbol): Don't call
2458         find_old_style_renaming_symbol.
2459         (ada_is_renaming_symbol): Rename from
2460         ada_find_renaming_symbol.  Remove "block" parameter.  Return
2461         bool.  Now static.
2462         (ada_read_var_value): Update and simplify.
2463         * ada-exp.y (write_var_or_type): Remove old code.
2464
2465 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
2466
2467         * event-top.c: Remove include comment.
2468         * inflow.c (class scoped_ignore_sigttou): Move from here...
2469         * inflow.h (class scoped_ignore_sigttou): ...to here.
2470         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
2471         * top.c:  Remove include comment.
2472
2473 2019-05-27  Tom Tromey  <tom@tromey.com>
2474
2475         * NEWS: Fix typo.
2476
2477 2019-05-22  Tom Tromey  <tromey@adacore.com>
2478
2479         * target.c (target_follow_exec): Constify parameter.
2480         * target-delegates.c: Rebuild.
2481         * remote.c (remote_target::follow_exec): Constify parameter.
2482         * infrun.c (follow_exec): Constify parameter.
2483         * target.h (struct target_ops) <follow_exec>: Constify parameter.
2484         (target_follow_exec): Likewise.
2485
2486 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2487
2488         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
2489         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
2490
2491 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2492
2493         * NEWS: Add debugredirect and testsuite sections.
2494
2495 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
2496
2497         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
2498         target descriptions using exclusively floating point register name
2499         aliases.
2500
2501 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2502
2503         PR gdb/18644:
2504         * f-lang.c (build_fortran_types): Handle the case where
2505         gdbarch_floatformat_for_type returns a nullptr.
2506
2507 2019-05-21  Tom de Vries  <tdevries@suse.de>
2508
2509         PR cli/24587
2510         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
2511
2512 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2513
2514         PR gdb/18644:
2515         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
2516         16-byte floats.
2517         * i386-tdep.c (i386_floatformat_for_type): Use
2518         floatformats_ia64_quad for the 16-byte floating point component
2519         within a fortran 32-byte complex number.
2520
2521 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2522
2523         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
2524         delete default constructor.
2525         (find_partial_die): Update to return const struct.
2526         (partial_die_parent_scope): Move variable declaration into scope
2527         of its use and change its type to auto.
2528         (guess_partial_die_structure_name): Likewise.
2529         (partial_die_info::fixup): Likewise.
2530
2531 2019-05-17  Tom Tromey  <tromey@adacore.com>
2532
2533         * source.c (find_and_open_source): Remove cast.
2534
2535 2019-05-17  Tom Tromey  <tromey@adacore.com>
2536
2537         * annotate.c (annotate_source): Make "filename" const.
2538         * annotate.h (annotate_source): Use const.
2539
2540 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2541
2542         * disasm.c (set_disassembler_options): Send errors to stderr.
2543
2544 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2545
2546         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
2547         (cli_interp_base::set_logging): Check debug_redirect.
2548         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
2549         * cli/cli-logging.c (debug_redirect): Add static variable.
2550         (pop_output_files): Add default param.
2551         (handle_redirections): Print debug setting.
2552         (show_logging_command): Likewise.
2553         (_initialize_cli_logging): Add debugredirect command.
2554         * interps.c (current_interp_set_logging): Add debug_redirect
2555         parameter.
2556         * interps.h (set_logging): Add debug_redirect parameter.
2557         (current_interp_set_logging): Likewise.
2558         * mi/mi-common.h: Likewise.
2559         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
2560
2561 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2562             Tom Tromey  <tromey@adacore.com>
2563
2564         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
2565         directly.
2566         * cli/cli-interp.h (make_logging_output): Remove declaration.
2567         * cli/cli-logging.c (make_logging_output): Remove function.
2568         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
2569         directly.
2570         * ui-file.c (tee_file::tee_file): Remove bools.
2571         (tee_file::~tee_file): Remove deletes.
2572         * ui-file.h (tee_file): Remove bools.
2573
2574 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
2575
2576         * mi/mi-cmds.h (mi_cmd_complete): New function.
2577         * mi/mi-main.c (mi_cmd_complete): Likewise.
2578         * mi/mi-cmds.c: Define new MI command -complete.
2579         * NEWS: Mention new -complete command.
2580
2581 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
2582
2583         * completer.h (complete): New function.
2584         * completer.c (complete): Likewise.
2585         * cli/cli-cmds.c: (complete_command): Update to use new complete()
2586         function defined in completer.h.
2587
2588 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
2589
2590         * MAINTAINERS (Write After Approval): Add myself.
2591
2592 2019-05-17  Tom de Vries  <tdevries@suse.de>
2593
2594         PR gdb/24094
2595         * dwarf2read.c (struct cu_partial_die_info): New struct.
2596         (find_partial_die): Return cu_partial_die_info.
2597         (partial_die_parent_scope, guess_partial_die_structure_name)
2598         (partial_die_info::fixup): Handle new return type of find_partial_die.
2599
2600 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2601
2602         * stap-probe.c (stap_parse_register_operand): Make "regname" an
2603         "std::string", simplifying the algorithm.
2604
2605 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2606
2607         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
2608         (stap_static_probe_ops::get_probes): Likewise.
2609
2610 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2611
2612         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
2613         '-')" and "else if".
2614         (stap_parse_single_operand): Join checks for
2615         "gdbarch_stap_parse_special_token_p" and
2616         "gdbarch_stap_parse_special_token" in the same "if" statement.
2617         Invert check when verifying for operation on register
2618         displacement.
2619
2620 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2621
2622         * stap-probe.c (stap_get_opcode): Update comment.
2623         (stap_get_expected_argument_type): Likewise.
2624         (handle_stap_probe): Likewise.
2625
2626 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2627
2628         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
2629         return type to 'bool'.  Adjust comment.  Use 'bool' when
2630         appropriate.
2631         (i386_stap_parse_special_token_three_arg_disp): Likewise.
2632         * stap-probe.c (stap_parse_argument_1): Likewise.
2633         (stap_is_operator): Likewise.
2634         (stap_is_generic_prefix): Likewise.
2635         (stap_is_register_prefix): Likewise.
2636         (stap_is_register_indirection_prefix): Likewise.
2637         (stap_is_integer_prefix): Likewise.
2638         (stap_generic_check_suffix): Likewise.
2639         (stap_check_integer_suffix): Likewise.
2640         (stap_check_register_suffix): Likewise.
2641         (stap_check_register_indirection_suffix): Likewise.
2642         (stap_parse_register_operand): Likewise.
2643         (stap_parse_single_operand): Likewise.
2644         (stap_parse_argument_1): Likewise.
2645         (stap_probe::get_argument_count): Likewise.
2646         (stap_is_operator): Likewise.
2647
2648 2019-05-16  Tom Tromey  <tromey@adacore.com>
2649
2650         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
2651         keyword to foreach.
2652
2653 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
2654
2655         * linux-thread-db.c (try_thread_db_load_1): Change return type
2656         to bool.
2657         (try_thread_db_load): Likewise.
2658         (try_thread_db_load_from_pdir_1): Likewise.
2659         (try_thread_db_load_from_pdir): Likewise.
2660         (try_thread_db_load_from_sdir): Likewise.
2661         (try_thread_db_load_from_dir): Likewise.
2662         (thread_db_load_search): Likewise.
2663         (has_libpthread): Likewise.
2664         (thread_db_load): Likewise.
2665
2666 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
2667
2668         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2669         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
2670         NULL, and complain/return if that's the case.
2671
2672 2019-05-15  John Darrington <john@darrington.wattle.id.au>
2673
2674         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
2675         (advance, posn, abstract_read_memory): New functions.
2676         [struct mem_read_abstraction]: New struct.
2677         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
2678
2679 2019-05-14  Tom Tromey  <tromey@adacore.com>
2680
2681         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
2682         value is not lval_memory.
2683
2684 2019-05-14  Tom Tromey  <tromey@adacore.com>
2685
2686         * solib.c (info_sharedlibrary_command): Style the file name.
2687
2688 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
2689
2690         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
2691         (aarch64_vnv_type): Likewise.
2692         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
2693         * common/tdesc.c: Likewise.
2694         * common/tdesc.h (enum tdesc_type_kind): Likewise.
2695         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
2696         * features/aarch64-fpu.xml: Add ieee half view.
2697         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
2698         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
2699         * gdbtypes.h (struct builtin_type): Likewise.
2700         (struct objfile_type): Likewise.
2701
2702 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
2703
2704         * language.c (language_sniff_from_mangled_name): Fix "langauge"
2705         typo.
2706         * location.h (string_to_event_location): Likewise.
2707
2708 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
2709
2710         GDB 8.3 released.
2711
2712 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2713
2714         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
2715         New variable declaration.
2716         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
2717         New variable.
2718         (print_one_breakpoint): Use ui_out::test_flags and new global
2719         variable to compute use_fixed_output.
2720         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
2721         Remove.
2722         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
2723         (mi_multi_location_breakpoint_output_fixed): Remove.
2724         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
2725         new variable.
2726         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
2727         fix_multi_location_breakpoint_output flag if version >= 3.
2728         * ui-out.h (enum ui_out_flag)
2729         <fix_multi_location_breakpoint_output>: New enumerator.
2730
2731 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2732
2733         * contrib/cc-with-tweaks.sh: Validate dwz's work.
2734
2735 2019-05-10  Tom Tromey  <tromey@adacore.com>
2736
2737         * ada-lang.c (catch_ada_completer): New function.
2738         (_initialize_ada_language): Use it.
2739
2740 2019-05-10  Tom Tromey  <tromey@adacore.com>
2741
2742         * thread.c (print_thread_info): Make "requested_threads" const.
2743         * gdbthread.h (print_thread_info): Make "requested_threads"
2744         const.
2745         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
2746         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
2747
2748 2019-05-08  Tom Tromey  <tom@tromey.com>
2749
2750         * gdbtypes.c (objfile_type_data): Change type.
2751         (objfile_type, _initialize_gdbtypes): Update.
2752
2753 2019-05-08  Tom Tromey  <tom@tromey.com>
2754
2755         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
2756         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
2757         (_initialize_dwarf2_frame): Update.
2758
2759 2019-05-08  Tom Tromey  <tom@tromey.com>
2760
2761         * objc-lang.c (objc_objfile_data): Change type.
2762         (find_methods): Update.
2763         (_initialize_objc_lang): Remove.
2764
2765 2019-05-08  Tom Tromey  <tom@tromey.com>
2766
2767         * stabsread.c (rs6000_builtin_type_data): Change type.
2768         (rs6000_builtin_type, _initialize_stabsread): Update.
2769
2770 2019-05-08  Tom Tromey  <tom@tromey.com>
2771
2772         * mips-tdep.c (mips_pdr_data): Remove.
2773         (_initialize_mips_tdep): Update.
2774
2775 2019-05-08  Tom Tromey  <tom@tromey.com>
2776
2777         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
2778         (hppa_init_objfile_priv_data, read_unwind_info)
2779         (find_unwind_entry, _initialize_hppa_tdep): Update.
2780
2781 2019-05-08  Tom Tromey  <tom@tromey.com>
2782
2783         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
2784         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
2785         on obstack.
2786         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
2787
2788 2019-05-08  Tom Tromey  <tom@tromey.com>
2789
2790         * mdebugread.c (basic_type_data): Change type.
2791         (basic_type, _initialize_mdebugread): Update.
2792
2793 2019-05-08  Tom Tromey  <tom@tromey.com>
2794
2795         * common/gdb_unique_ptr.h (struct noop_deleter): New.
2796
2797 2019-05-08  Tom Tromey  <tom@tromey.com>
2798
2799         * nto-tdep.c (nto_inferior_data_reg): Change type.
2800         (nto_inferior_data): Update.
2801         (nto_inferior_data_cleanup, nto_new_inferior_data)
2802         (_initialize_nto_tdep): Remove.
2803         * nto-tdep.h (struct nto_inferior_data): Add initializers.
2804
2805 2019-05-08  Tom Tromey  <tom@tromey.com>
2806
2807         * ada-lang.c (struct ada_inferior_data): Add initializers.
2808         (ada_inferior_data): Change type.
2809         (ada_inferior_data_cleanup): Remove.
2810         (get_ada_inferior_data, ada_inferior_exit)
2811         (struct ada_pspace_data): Add initializers, destructor.
2812         (ada_pspace_data_handle): Change type.
2813         (get_ada_pspace_data): Update.
2814         (ada_pspace_data_cleanup): Remove.
2815
2816 2019-05-08  Tom Tromey  <tom@tromey.com>
2817
2818         * coffread.c (struct coff_symfile_info): Add initializers.
2819         (coff_objfile_data_key): Move lower.  Change type.
2820         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
2821         Update.
2822         (coff_free_info): Remove.
2823
2824 2019-05-08  Tom Tromey  <tom@tromey.com>
2825
2826         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
2827         (fbsd_pspace_data_handle): Move lower.  Change type.
2828         (get_fbsd_pspace_data): Update.
2829         (fbsd_pspace_data_cleanup): Remove.
2830         (_initialize_fbsd_tdep): Update.
2831
2832 2019-05-08  Tom Tromey  <tom@tromey.com>
2833
2834         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
2835         (get_ada_tasks_pspace_data): Update.
2836         (ada_tasks_pspace_data_cleanup): Remove.
2837         (_initialize_tasks): Update.
2838         (ada_tasks_inferior_data_handle): Change type.
2839         (get_ada_tasks_inferior_data): Update.
2840         (ada_tasks_inferior_data_cleanup): Remove.
2841         (struct ada_tasks_pspace_data): Add initializers.
2842
2843 2019-05-08  Tom Tromey  <tom@tromey.com>
2844
2845         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
2846         * symfile-debug.c (debug_sym_get_probes): Change type.
2847         * stap-probe.c (handle_stap_probe):
2848         (stap_static_probe_ops::get_probes): Change type.
2849         * probe.h (class static_probe_ops) <get_probes>: Change type.
2850         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
2851         (parse_probes_in_pspace): Update.
2852         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
2853         Update.
2854         (any_static_probe_ops::get_probes): Change type.
2855         * elfread.c (elfread_data): New typedef.
2856         (probe_key): Change type.
2857         (elf_get_probes): Likewise.  Update.
2858         (probe_key_free): Remove.
2859         (_initialize_elfread): Update.
2860         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
2861         Change type.
2862         (dtrace_process_dof_probe, dtrace_process_dof)
2863         (dtrace_static_probe_ops::get_probe): Change type.
2864
2865 2019-05-08  Tom Tromey  <tom@tromey.com>
2866
2867         * xcoffread.c (struct xcoff_symfile_info): Rename from
2868         coff_symfile_info.  Add initializers.
2869         (xcoff_objfile_data_key): Move lower.  Change type.
2870         (XCOFF_DATA): Rewrite.
2871         (xcoff_free_info): Remove.
2872         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
2873         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
2874         (xcoff_initial_scan): Update.
2875
2876 2019-05-08  Tom Tromey  <tom@tromey.com>
2877
2878         * solib-svr4.c (struct svr4_info): Add initializers and
2879         destructor.
2880         <probes_table>: Now an htab_up.
2881         (solib_svr4_pspace_data): Change type.
2882         (free_probes_table): Simplify.
2883         (~svr4_info): Rename from svr4_pspace_data_cleanup.
2884         (get_svr4_info, probes_table_htab_remove_objfile_probes)
2885         (probes_table_remove_objfile_probes, register_solib_event_probe)
2886         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
2887         (_initialize_svr4_solib): Update.
2888
2889 2019-05-08  Tom Tromey  <tom@tromey.com>
2890
2891         * remote.c (remote_pspace_data): Change type.
2892         (remote_pspace_data_cleanup): Remove.
2893         (get_remote_exec_file, set_pspace_remote_exec_file)
2894         (_initialize_remote): Update.
2895
2896 2019-05-08  Tom Tromey  <tom@tromey.com>
2897
2898         * breakpoint.c (breakpoint_objfile_key): Change type.
2899         (get_breakpoint_objfile_data): Update.
2900         (free_breakpoint_objfile_data): Remove.
2901         (_initialize_breakpoint): Update.
2902
2903 2019-05-08  Tom Tromey  <tom@tromey.com>
2904
2905         * linux-tdep.c (struct linux_info): Add initializers.
2906         (linux_inferior_data): Move.  Change type.
2907         (invalidate_linux_cache_inf): Update.
2908         (linux_inferior_data_cleanup): Remove.
2909         (get_linux_inferior_data, _initialize_linux_tdep): Update.
2910
2911 2019-05-08  Tom Tromey  <tom@tromey.com>
2912
2913         * auxv.c (auxv_inferior_data): Move.  Change type.
2914         (auxv_inferior_data_cleanup): Remove.
2915         (invalidate_auxv_cache_inf): Rewrite.
2916         (get_auxv_inferior_data, _initialize_auxv): Update.
2917
2918 2019-05-08  Tom Tromey  <tom@tromey.com>
2919
2920         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
2921         (symfile_debug_objfile_data_key): Change type.
2922         (symfile_debug_installed, debug_qf_has_symbols)
2923         (debug_qf_find_last_source_symtab)
2924         (debug_qf_forget_cached_source_info)
2925         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
2926         (debug_qf_print_stats, debug_qf_dump)
2927         (debug_qf_expand_symtabs_for_function)
2928         (debug_qf_expand_all_symtabs)
2929         (debug_qf_expand_symtabs_with_fullname)
2930         (debug_qf_map_matching_symbols)
2931         (debug_qf_expand_symtabs_matching)
2932         (debug_qf_find_pc_sect_compunit_symtab)
2933         (debug_qf_map_symbol_filenames)
2934         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
2935         (debug_sym_new_init, debug_sym_init, debug_sym_read)
2936         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
2937         (debug_sym_read_linetable, debug_sym_relocate): Update.
2938         (symfile_debug_free_objfile): Remove.
2939         (install_symfile_debug_logging, _initialize_symfile_debug):
2940         Update.
2941
2942 2019-05-08  Tom Tromey  <tom@tromey.com>
2943
2944         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
2945         allocate_on_obstack.
2946         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
2947         (get_dwarf2_per_objfile): Update.
2948         (set_dwarf2_per_objfile): Remove.
2949         (dwarf2_has_info, dwarf2_get_section_info): Update.
2950         (dwarf2_free_objfile): Remove.
2951         (_initialize_dwarf2_read): Update.
2952
2953 2019-05-08  Tom Tromey  <tom@tromey.com>
2954
2955         * auto-load.c (struct auto_load_pspace_info): Add destructor and
2956         initializers.
2957         <unsupported_script_warning_printed,
2958         script_not_found_warning_printed>: Now bool.
2959         (auto_load_pspace_data): Change type.
2960         (~auto_load_pspace_info): Rename from
2961         auto_load_pspace_data_cleanup.
2962         (get_auto_load_pspace_data, init_loaded_scripts_info)
2963         (clear_section_scripts, maybe_print_unsupported_script_warning)
2964         (maybe_print_script_not_found_warning, _initialize_auto_load):
2965         Update.
2966
2967 2019-05-08  Tom Tromey  <tom@tromey.com>
2968
2969         * objfiles.c (objfile_pspace_info): Add destructor and
2970         initializers.
2971         (objfiles_pspace_data): Change type.
2972         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
2973         (get_objfile_pspace_data): Update.
2974         (objfiles_bfd_data): Change type.
2975         (get_objfile_bfd_data): Update.
2976         (objfile_bfd_data_free, _initialize_objfiles): Remove.
2977
2978 2019-05-08  Tom Tromey  <tom@tromey.com>
2979
2980         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
2981         Change type.
2982         (get_catch_syscall_inferior_data): Update.
2983         (catch_syscall_inferior_data_cleanup): Remove.
2984         (_initialize_break_catch_syscall): Update.
2985
2986 2019-05-08  Tom Tromey  <tom@tromey.com>
2987
2988         * inflow.c (struct terminal_info): Add destructor and
2989         initializers.
2990         (inflow_inferior_data): Change type.
2991         (~terminal_info): Rename from inflow_inferior_data_cleanup.
2992         (get_inflow_inferior_data, inflow_inferior_exit)
2993         (swap_terminal_info, _initialize_inflow): Update.
2994
2995 2019-05-08  Tom Tromey  <tom@tromey.com>
2996
2997         * target-dcache.c (target_dcache_cleanup): Remove.
2998         (target_dcache_aspace_key): Change type.
2999         (target_dcache_init_p, target_dcache_invalidate)
3000         (target_dcache_get, target_dcache_get_or_init)
3001         (_initialize_target_dcache): Update.
3002         * dcache.h (struct dcache_deleter): New.
3003
3004 2019-05-08  Tom Tromey  <tom@tromey.com>
3005
3006         * symtab.c (struct symbol_cache): Add destructor and
3007         initializers.
3008         (symbol_cache_key): Move.  Change type.
3009         (make_symbol_cache, free_symbol_cache): Remove.
3010         (get_symbol_cache): Update.
3011         (symbol_cache_cleanup): Remove.
3012         (ALL_PSPACES, symbol_cache_flush)
3013         (maintenance_print_symbol_cache)
3014         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3015         Update.
3016
3017 2019-05-08  Tom Tromey  <tom@tromey.com>
3018
3019         * symtab.c (struct main_info): Add destructor and initializers.
3020         (main_progspace_key): Move.  Change type.
3021         (get_main_info): Update.
3022         (main_info_cleanup): Remove.
3023         (_initialize_symtab): Update.
3024
3025 2019-05-08  Tom Tromey  <tom@tromey.com>
3026
3027         * registry.h (DECLARE_REGISTRY): Define the _key class.
3028
3029 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3030
3031         * NEWS: Merge two 'New commands' sections.
3032
3033 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3034
3035         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3036         parameter and use Ada language definition instead.
3037         (ada_val_print_ptr): Remove unused language parameter.
3038         (ada_val_print_num): Remove language parameter and use Ada language
3039         definition instead.
3040         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3041         parameter.
3042         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3043         parameter and use Ada language definition instead.
3044         (ada_val_print_1): Update all ada_val_print_xxx calls.
3045         Remove language parameter.
3046         (ada_val_print): Update ada_val_print_1 call.
3047
3048 2019-05-08  Tom Tromey  <tromey@adacore.com>
3049
3050         * remote.c (remote_hw_watchpoint_limit)
3051         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3052         Now static.
3053
3054 2019-05-08  Tom Tromey  <tromey@adacore.com>
3055
3056         * maint.c (_initialize_maint_cmds): Move initialization code to
3057         remote.c.
3058         (watchdog, show_watchdog): Move to remote.c.
3059         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3060         "watchdog" static.
3061         (_initialize_remote): Move initialization code from maint.c.
3062         * defs.h (watchdog): Don't declare.
3063
3064 2019-05-08  Tom Tromey  <tromey@adacore.com>
3065
3066         * tui/tui-interp.c: Include main.h.
3067         * interps.c: Include main.h.
3068         * main.h (interpreter_p): Declare.
3069         * defs.h (interpreter_p): Don't declare.
3070
3071 2019-05-08  Tom Tromey  <tromey@adacore.com>
3072
3073         * dwarf2loc.c: Include dwarf2read.h.
3074         * defs.h (read_unsigned_leb128): Don't declare.
3075         * dwarf2read.h (read_unsigned_leb128): Declare.
3076
3077 2019-05-08  Tom Tromey  <tromey@adacore.com>
3078
3079         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3080         method.
3081
3082 2019-05-08  Tom Tromey  <tromey@adacore.com>
3083
3084         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3085         when no wrap column is set.
3086
3087 2019-05-08  Tom Tromey  <tromey@adacore.com>
3088
3089         * c-lang.c (c_get_string): Handle non-C-style arrays.
3090
3091 2019-05-08  Tom Tromey  <tromey@adacore.com>
3092
3093         * typeprint.c (print_offset_data::update): Print the bit offset,
3094         not the number of bits remaining.
3095
3096 2019-05-08  Tom Tromey  <tromey@adacore.com>
3097
3098         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3099         padding at end of comment.
3100
3101 2019-05-08  Tom Tromey  <tromey@adacore.com>
3102
3103         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3104         Compare main types.
3105
3106 2019-05-06  Tom Tromey  <tom@tromey.com>
3107
3108         * common/scoped_mmap.c: Include common-defs.h.
3109         * common/scoped_mmap.h: Don't include config.h.
3110
3111 2019-05-04  Tom Tromey  <tom@tromey.com>
3112
3113         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3114         (struct aarch64_call_info): Add initializers.
3115         <si>: Now a std::vector.
3116         (pass_on_stack, aarch64_push_dummy_call): Update.
3117
3118 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3119             Tom Tromey  <tom@tromey.com>
3120
3121         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3122         (ppc_threads): Now a std::vector.  Now static.
3123         (hwdebug_find_thread_points_by_tid)
3124         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3125         Update.
3126
3127 2019-05-04  Tom Tromey  <tom@tromey.com>
3128
3129         * arc-tdep.c (arc_tdesc_init): Return bool.
3130
3131 2019-05-04  Tom Tromey  <tom@tromey.com>
3132
3133         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3134         Use gdb_assert_not_reached.
3135
3136 2019-05-04  Tom Tromey  <tom@tromey.com>
3137
3138         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3139         "false".
3140
3141 2019-05-04  Tom Tromey  <tom@tromey.com>
3142
3143         * arc-tdep.c (arc_tdesc_init): Use bool.
3144
3145 2019-05-04  Tom Tromey  <tom@tromey.com>
3146
3147         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3148
3149 2019-05-04  Tom Tromey  <tom@tromey.com>
3150
3151         * cli/cli-cmds.c (valid_command_p): Return bool.
3152
3153 2019-05-04  Tom Tromey  <tom@tromey.com>
3154
3155         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3156         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3157
3158 2019-05-04  Raul Tambre  <raul@tambre.ee>
3159
3160         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3161         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3162         operator for comparison.
3163
3164 2019-05-04  Tom Tromey  <tom@tromey.com>
3165
3166         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3167         (lookup_partial_symbol, print_partial_symbols)
3168         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3169         (psymbol_compare): Update.
3170         (add_psymbol_to_bcache): Clear the entire psymbol.
3171         (maintenance_check_psymtabs): Update.
3172         * psympriv.h (struct partial_symbol): Don't derive from
3173         general_symbol_info.
3174         <obj_section, unrelocated_address, address,
3175         set_unrelocated_address>: Update.
3176         <ginfo>: New member.
3177         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3178         (debug_names::write_psymbols): Update.
3179
3180 2019-05-04  Tom de Vries  <tdevries@suse.de>
3181
3182         * contrib/cc-with-tweaks.sh: Support -n arg.
3183
3184 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3185
3186         * corelow.c (core_target::detach): Ensure frame cache and
3187         register caches are cleared.
3188         inferior.c (exit_inferior_1): Likewise.
3189
3190 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
3191             Tom Tromey  <tom@tromey.com>
3192
3193         * dictionary.c (collate_pending_symbols_by_language): Remove
3194         "struct" from foreach.
3195         * symtab.c (lookup_global_symbol_from_objfile)
3196         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
3197         foreach.
3198         * ser-tcp.c (net_open): Remove "struct" from foreach.
3199         * objfiles.c (objfile_relocate, objfile_rebase)
3200         (objfile_has_symbols): Remove "struct" from foreach.
3201         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
3202         from foreach.
3203         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
3204         foreach.
3205         * darwin-nat.c (thread_info_from_private_thread_info): Remove
3206         "struct" from foreach.
3207         * ada-lang.c (create_excep_cond_exprs)
3208         (ada_exception_catchpoint_cond_string): Remove "struct" from
3209         foreach.
3210
3211 2019-05-03  Tom Tromey  <tromey@adacore.com>
3212
3213         * ada-exp.y (convert_char_literal): Check suffix of each
3214         enumerator.
3215
3216 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
3217
3218         PR ada/21406:
3219         * ada-exp.y (yywrap): Don't define.
3220         * ada-lex.l (%option): Add noyywrap
3221         (yywrap): Remove.
3222
3223 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
3224
3225         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
3226         _WIN32_WINNT to the XP level, unless already defined to a higher
3227         level.
3228
3229         * unittests/parse-connection-spec-selftests.c:
3230         * ser-tcp.c:
3231         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
3232         override.
3233
3234         * symfile.c (find_separate_debug_file): Remove colon from the
3235         drive spec of DOS/Windows file names of the target, so that the
3236         file name produced from DEBUGDIR and the target's directory will
3237         be valid on DOS/Windows systems.
3238
3239 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3240
3241         * rust-lang.c (val_print_struct): Handle printing structures
3242         containing strings.
3243
3244 2019-05-02  Tom Tromey  <tromey@adacore.com>
3245
3246         * valarith.c (_initialize_valarith): Remove.
3247
3248 2019-05-01  Tom Tromey  <tromey@adacore.com>
3249
3250         * ada-lang.c (ada_value_primitive_field): Treat more fields as
3251         bitfields.
3252
3253 2019-05-01  Tom Tromey  <tromey@adacore.com>
3254
3255         * ada-lang.c (ada_value_assign): Correctly compute starting offset
3256         for big-endian copies.
3257
3258 2019-04-30  Ali Tamur  <tamur@google.com>
3259         * gdb/dwarf2read.c (read_3_bytes): New declaration.
3260         (read_attribute_value): Added DW_FORM_strx1-4 cases.
3261         (read_3_bytes): New function.
3262
3263 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3264
3265         * windows-nat.c (main_thread_id): Delete.
3266         (handle_output_debug_string): Replace main_thread_id by
3267         current_event.dwThreadId.
3268         (fake_create_process): Likewise.
3269         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
3270         Do not set main_thread_id.
3271         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
3272         current_event.dwThreadId.
3273         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
3274
3275 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3276
3277         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
3278         Use current_event.dwThreadId instead of main_thread_id.
3279
3280 2019-04-30  Tom Tromey  <tromey@adacore.com>
3281
3282         * ada-lang.c (ada_lookup_simple_minsyms): New function.
3283         (create_excep_cond_exprs): Iterate over program spaces.
3284         (ada_exception_catchpoint_cond_string): Examine all minimal
3285         symbols for exception types.
3286
3287 2019-04-30  Tom Tromey  <tromey@adacore.com>
3288
3289         PR c++/24470:
3290         * dwarf2read.c (process_structure_scope): Handle case where type
3291         has template parameters but no symbol was created.
3292
3293 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3294             Chris January  <chris.january@arm.com>
3295
3296         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
3297         qualifier.
3298         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
3299
3300 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3301
3302         * f-typeprint.c (f_print_type): Update rules for printing
3303         whitespace.
3304         (f_type_print_varspec_suffix): Likewise.
3305
3306 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3307             Chris January  <chris.january@arm.com>
3308
3309         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
3310         function arguments.
3311
3312 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3313
3314         * f-lang.c (build_fortran_types): Change name of void type to
3315         lower case.
3316         * f-typeprint.c (f_type_print_base): Print the name of the void
3317         type, rather than a fixed string.
3318         * f-valprint.c (f_decorations): Use lower case void string.
3319
3320 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3321             Chris January  <chris.january@arm.com>
3322
3323         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
3324         types for Fortran.
3325
3326 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3327             Chris January  <chris.january@arm.com>
3328             David Lecomber  <david.lecomber@arm.com>
3329
3330         * f-exp.y (BINOP_INTRINSIC): New token.
3331         (exp): New parser rule handling BINOP_INTRINSIC.
3332         (f77_keywords): Add new builtin procedures.
3333         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
3334         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3335         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
3336         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3337         (print_unop_subexp_f): New function.
3338         (print_binop_subexp_f): New function.
3339         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3340         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3341         (dump_subexp_body_f): Likewise.
3342         (operator_check_f): Likewise.
3343         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3344         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
3345
3346 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3347
3348         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
3349         UNOP_KIND.
3350         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
3351         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
3352         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
3353         (operator_length_f): New fuction.
3354         (print_subexp_f): New function.
3355         (op_name_f): New function.
3356         (dump_subexp_body_f): New function.
3357         (operator_check_f): New function.
3358         (exp_descriptor_f): Replace standard expression handling functions
3359         with new functions.
3360         * gdb/fortran-operator.def: New file.
3361         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
3362         * gdb/std-operator.def: Remove UNOP_KIND.
3363
3364 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3365
3366         * std-operator.def: Remove unbalanced, stray double quote
3367         character.
3368
3369 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3370             Chris January  <chris.january@arm.com>
3371             Daniel Everett  <daniel.everett@arm.com>
3372             Nick Forrington  <nick.forrington@arm.com>
3373             Richard Bunt  <richard.bunt@arm.com>
3374
3375         * cp-valprint.c (cp_print_value_fields): Allow an additional level
3376         of depth when printing anonymous structs or unions.
3377         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
3378         Don't print either the top-level value, or the children if the
3379         max-depth is exceeded.
3380         (ppscm_print_children): When printing the key of a map, allow one
3381         extra level of depth.
3382         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
3383         print either the top-level value, or the children if the max-depth
3384         is exceeded.
3385         (print_children): When printing the key of a map, allow one extra
3386         level of depth.
3387         * python/py-value.c (valpy_format_string): Add max_depth keyword.
3388         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
3389         (user_print_options): Initialise max_depth field.
3390         (val_print_scalar_or_string_type_p): New function.
3391         (val_print): Check to see if the max depth has been reached.
3392         (val_print_check_max_depth): Define new function.
3393         (show_print_max_depth): New function.
3394         (_initialize_valprint): Add 'print max-depth' option.
3395         * valprint.h (struct value_print_options) <max_depth>: New field.
3396         (val_print_check_max_depth): Declare new function.
3397         * NEWS: Document new feature.
3398
3399 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3400
3401         * ada-lang.c (ada_language_defn): Initialise new field.
3402         * c-lang.c (c_is_string_type_p): New function.
3403         (c_language_defn): Initialise new field.
3404         (cplus_language_defn): Initialise new field.
3405         (asm_language_defn): Initialise new field.
3406         (minimal_language_defn): Initialise new field.
3407         * c-lang.h (c_is_string_type_p): Declare new function.
3408         * d-lang.c (d_language_defn): Initialise new field.
3409         * f-lang.c (f_is_string_type_p): New function.
3410         (f_language_defn): Initialise new field.
3411         * go-lang.c (go_is_string_type_p): New function.
3412         (go_language_defn): Initialise new field.
3413         * language.c (default_is_string_type_p): New function.
3414         (unknown_language_defn): Initialise new field.
3415         (auto_language_defn): Initialise new field.
3416         * language.h (struct language_defn) <la_is_string_type_p>: New
3417         member variable.
3418         (default_is_string_type_p): Declare new function.
3419         * m2-lang.c (m2_language_defn): Initialise new field.
3420         * objc-lang.c (objc_language_defn): Initialise new field.
3421         * opencl-lang.c (opencl_language_defn): Initialise new field.
3422         * p-lang.c (pascal_is_string_type_p): New function.
3423         (pascal_language_defn): Initialise new field.
3424         * rust-lang.c (rust_is_string_type_p): New function.
3425         (rust_language_defn): Initialise new field.
3426
3427 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3428
3429         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
3430         New field.
3431         * ada-lang.c (ada_language_defn): Initialise new field.
3432         * c-lang.c (c_language_defn): Likewise.
3433         (cplus_language_defn): Likewise.
3434         (asm_language_defn): Likewise.
3435         (minimal_language_defn): Likewise.
3436         * d-lang.c (d_language_defn): Likewise.
3437         * f-lang.c (f_language_defn): Likewise.
3438         * go-lang.c (go_language_defn): Likewise.
3439         * language.c (unknown_language_defn): Likewise.
3440         (auto_language_defn): Likewise.
3441         * m2-lang.c (m2_language_defn): Likewise.
3442         * objc-lang.c (objc_language_defn): Likewise.
3443         * opencl-lang.c (opencl_language_defn): Likewise.
3444         * p-lang.c (pascal_language_defn): Likewise.
3445         * rust-lang.c (rust_language_defn): Likewise.
3446
3447 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3448
3449         * ada-lang.c (ada_is_character_type): Change return type to bool.
3450         (ada_is_string_type): Likewise.
3451         * ada-lang.h (ada_is_character_type): Update declaration
3452         (ada_is_string_type): Likewise.
3453
3454 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3455
3456         Support style in 'frame|thread apply'
3457
3458         * gdbcmd.h (execute_command_to_string): New term_out parameter.
3459         * record.c (record_start, record_stop): Update callers of
3460         execute_command_to_string with false.
3461         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
3462         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
3463         methods.
3464         (class string_file): New constructor with term_out parameter.
3465         Override methods term_out and can_emit_style_escape.  New member
3466         term_out.
3467         (class stdio_file): Override can_emit_style_escape.
3468         (class tee_file): Override term_out and can_emit_style_escape.
3469         * utils.h (can_emit_style_escape): Remove.
3470         * utils.c (can_emit_style_escape): Likewise.
3471         Update all callers of can_emit_style_escape (SOMESTREAM) to
3472         SOMESTREAM->can_emit_style_escape.
3473         * source-cache.c (source_cache::get_source_lines): Likewise.
3474         * stack.c (frame_apply_command_count): Call execute_command_to_string
3475         passing the term_out characteristic of the current gdb_stdout.
3476         * thread.c (thr_try_catch_cmd): Likewise.
3477         * top.c (execute_command_to_string): pass term_out parameter
3478         to construct the string_file for the command output.
3479         * ui-file.c (term_cli_styling): New function (most code moved
3480         from utils.c can_emit_style_escape).
3481         (string_file::string_file, string_file::can_emit_style_escape,
3482         stdio_file::can_emit_style_escape, tee_file::term_out,
3483         tee_file::can_emit_style_escape): New functions.
3484
3485 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3486
3487         * NEWS: Mention the new set|show may-call-functions.
3488         * infcall.c (may_call_functions_p): New variable.
3489         (show_may_call_functions_p): New function.
3490         (call_function_by_hand_dummy): Throws an error if not
3491         may-call-functions.
3492         (_initialize_infcall): Call add_setshow_boolean_cmd for
3493         may-call-functions.
3494
3495 2019-04-25  Keith Seitz  <keiths@redhat.com>
3496
3497         PR c++/24367
3498         * cp-support.c (inspect_type): Don't attempt substitutions
3499         of symbol with the same name.
3500
3501 2019-04-25  Tom Tromey  <tromey@adacore.com>
3502
3503         PR gdb/24475:
3504         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
3505         static.
3506
3507 2019-04-25  Tom Tromey  <tromey@adacore.com>
3508
3509         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
3510         rvalue reference.
3511         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
3512         (gdb_xml_parser::parse): Use std::move.
3513         * python/python-internal.h (gdbpy_convert_exception): Take a const
3514         reference.
3515         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
3516         std::move.
3517         * python/py-utils.c (gdbpy_convert_exception): Take a const
3518         reference.
3519         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3520         Use std::move.
3521         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3522         Use std::move.
3523         * mi/mi-main.c (mi_print_exception): Take a const reference.
3524         * main.c (handle_command_errors): Take a const reference.
3525         * linespec.c (parse_linespec): Use std::move.
3526         * infcall.c (run_inferior_call): Use std::move.
3527         (call_function_by_hand_dummy): Use std::move.
3528         * exec.c (try_open_exec_file): Use std::move.
3529         * exceptions.h (exception_print, exception_fprintf)
3530         (exception_print_same): Update.
3531         * exceptions.c (print_exception, exception_print)
3532         (exception_fprintf, exception_print_same): Change parameters to
3533         const reference.
3534         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
3535         * common/new-op.c: Use std::move.
3536         * common/common-exceptions.h (struct gdb_exception): Add move
3537         constructor.
3538         (struct gdb_exception_error, struct gdb_exception_quit, struct
3539         gdb_quit_bad_alloc): Change constructor to move constructor.
3540         (throw_exception): Change parameter to rvalue reference.
3541         * common/common-exceptions.c (throw_exception): Take rvalue
3542         reference.
3543         * cli/cli-interp.c (safe_execute_command): Use std::move.
3544         * breakpoint.c (insert_bp_location, location_to_sals): Use
3545         std::move.
3546
3547 2019-04-25  Tom Tromey  <tromey@adacore.com>
3548
3549         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
3550         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
3551         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
3552         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
3553         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
3554         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
3555         guile/scm-value.c: Use unpack.
3556         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
3557         gdbscm_gdb_exception.
3558         (gdbscm_throw_gdb_exception): Likewise.
3559         (struct gdbscm_gdb_exception): New.
3560         (unpack): New function.
3561         (gdbscm_wrap): Use unpack.
3562
3563 2019-04-25  Tom Tromey  <tromey@adacore.com>
3564
3565         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3566         (gdb_rl_callback_handler): Use std::move.
3567         * common/common-exceptions.h (struct gdb_exception): Add move
3568         assignment operator.
3569         (throw_exception_sjlj): Change "exception" to const reference.
3570         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
3571         (throw_exception_sjlj): Change "exception" to const reference.
3572
3573 2019-04-25  Tom Tromey  <tromey@adacore.com>
3574
3575         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
3576         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
3577         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3578         Update.
3579         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3580         Update.
3581         * mi/mi-interp.c (mi_interp::exec): Update.
3582         * linespec.c (parse_linespec): Update.
3583         * infcall.c (run_inferior_call): Update.
3584         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
3585         * guile/scm-symbol.c (gdbscm_lookup_symbol)
3586         (gdbscm_lookup_global_symbol): Update.
3587         * guile/scm-param.c (gdbscm_parameter_value): Update.
3588         * guile/scm-frame.c (gdbscm_frame_read_register)
3589         (gdbscm_frame_read_var): Update.
3590         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
3591         * exec.c (try_open_exec_file): Update.
3592         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3593         (gdb_rl_callback_handler): Update.
3594         * common/common-exceptions.h (exception_none): Don't declare.
3595         * common/common-exceptions.c (exception_none): Don't define.
3596         (struct catcher) <exception>: Update.
3597         * cli/cli-interp.c (safe_execute_command): Update.
3598         * breakpoint.c (insert_bp_location, location_to_sals): Update.
3599
3600 2019-04-25  Ali Tamur  <tamur@google.com>
3601
3602         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
3603         (read_attribute_value): Likewise.
3604         (dwarf2_read_addr_index): Update comment.
3605         (read_str_index): Add DW_FORM_strx.
3606         (dwarf2_string_attr): Likewise.
3607         (dwarf2_const_value_attr): Likewise.
3608         (dump_die_shallow): Likewise.
3609         (dwarf2_fetch_constant_bytes): Likewise.
3610         (skip_form_bytes): Likewise.
3611         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
3612
3613 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
3614
3615         PR corefiles/11608
3616         PR corefiles/18187
3617         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
3618         OFFSET.  Verify if current mapping contains an ELF header.
3619         (linux_find_memory_regions_full): Adjust call to
3620         dump_mapping_p.
3621
3622 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
3623             Kang Li <kanglictf@gmail.com>
3624
3625         PR gdb/21600
3626
3627         * dwarf2-frame.c (read_initial_length): Be consistent about using
3628         unsigned representation of length.
3629         (decode_frame_entry_1): Likewise.  Check for wraparound of
3630         end pointer as well as buffer overflow.
3631
3632 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
3633
3634         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
3635         "vq".
3636
3637 2019-04-24  Tom Tromey  <tromey@adacore.com>
3638
3639         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
3640
3641 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3642
3643         * s12z-tdep.c (s12z_unwind_pc): Delete.
3644         (s12z_unwind_sp): Delete.
3645         (s12z_gdbarch_init): Don't register deleted functions with
3646         gdbarch.
3647
3648 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3649
3650         * rl78-tdep.c (rl78_unwind_sp): Delete.
3651         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
3652
3653 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3654
3655         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
3656         (xstormy16_unwind_pc): Delete.
3657         (xstormy16_dummy_id): Delete.
3658         (xstormy16_gdbarch_init): Don't register deleted functions with
3659         gdbarch.
3660
3661 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3662
3663         * vax-tdep.c (vax_unwind_pc): Delete.
3664         (vax_gdbarch_init): Don't register deleted function with gdbarch.
3665
3666 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3667
3668         * v850-tdep.c (v850_unwind_sp): Delete.
3669         (v850_unwind_pc): Delete.
3670         (v850_dummy_id): Delete.
3671         (v850_gdbarch_init): Don't register deleted functions with
3672         gdbarch.
3673
3674 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3675
3676         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
3677         (tilegx_unwind_pc): Delete.
3678         (tilegx_unwind_dummy_id): Delete.
3679         (tilegx_gdbarch_init): Don't register deleted functions with
3680         gdbarch.
3681
3682 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3683
3684         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
3685         (tic6x_dummy_id): Delete.
3686         (tic6x_gdbarch_init): Don't register deleted functions with
3687         gdbarch.
3688
3689 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3690
3691         * sparc-tdep.c (sparc_unwind_pc): Delete.
3692         (sparc32_gdbarch_init): Don't register deleted function with
3693         gdbarch.
3694
3695 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3696
3697         * sh-tdep.c (sh_unwind_sp): Delete.
3698         (sh_unwind_pc): Delete.
3699         (sh_dummy_id): Delete.
3700         (sh_gdbarch_init): Don't register deleted functions with
3701         gdbarch.
3702
3703 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3704
3705         * score-tdep.c (score_unwind_sp): Delete.
3706         (score_unwind_pc): Delete.
3707         (score_dummy_id): Delete.
3708         (score_gdbarch_init): Don't register deleted functions with
3709         gdbarch.
3710
3711 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3712
3713         * rx-tdep.c (rx_unwind_pc): Delete.
3714         (rx_unwind_sp): Delete.
3715         (rx_dummy_id): Delete.
3716         (rx_gdbarch_init): Don't register deleted functions with
3717         gdbarch.  Update comment.
3718
3719 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3720
3721         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
3722         (rs6000_dummy_id): Delete.
3723         (rs6000_gdbarch_init): Don't register deleted functions with
3724         gdbarch.
3725
3726 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3727
3728         * or1k-tdep.c (or1k_dummy_id): Delete.
3729         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
3730
3731 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3732
3733         * nios2-tdep.c (nios2_dummy_id): Delete.
3734         (nios2_unwind_sp): Delete.
3735         (nios2_gdbarch_init): Don't register deleted functions with
3736         gdbarch.
3737
3738 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3739
3740         * nds32-tdep.c (nds32_dummy_id): Delete.
3741         (nds32_unwind_pc): Delete.
3742         (nds32_unwind_sp): Delete.
3743         (nds32_gdbarch_init): Don't register deleted functions with
3744         gdbarch.
3745
3746 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3747
3748         * msp430-tdep.c (msp430_unwind_pc): Delete.
3749         (msp430_unwind_sp): Delete.
3750         (msp430_dummy_id): Delete.
3751         (msp430_gdbarch_init): Don't register deleted functions with
3752         gdbarch.
3753
3754 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3755
3756         * moxie-tdep.c (moxie_unwind_sp): Delete.
3757         (moxie_unwind_pc): Delete.
3758         (moxie_dummy_id): Delete.
3759         (moxie_gdbarch_init): Don't register deleted functions with
3760         gdbarch.
3761
3762 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3763
3764         * mn10300-tdep.c (mn10300_dummy_id): Delete.
3765         (mn10300_unwind_pc): Delete.
3766         (mn10300_unwind_sp): Delete.
3767         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
3768         mn10300_unwind_sp.
3769         (mn10300_frame_unwind_init): Don't register deleted functions with
3770         gdbarch.
3771
3772 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3773
3774         * mep-tdep.c (mep_unwind_pc): Delete.
3775         (mep_unwind_sp): Delete.
3776         (mep_dummy_id): Delete.
3777         (mep_gdbarch_init): Don't register deleted functions with
3778         gdbarch.
3779
3780 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3781
3782         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
3783         (m68hc11_unwind_sp): Delete.
3784         (m68hc11_gdbarch_init): Don't register deleted functions with
3785         gdbarch.
3786
3787 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3788
3789         * m32r-tdep.c (m32r_unwind_sp): Delete.
3790         (m32r_unwind_pc): Delete.
3791         (m32r_dummy_id): Delete.
3792         (m32r_gdbarch_init): Don't register deleted functions with
3793         gdbarch.
3794
3795 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3796
3797         * m32c-tdep.c (m32c_unwind_pc): Delete.
3798         (m32c_unwind_sp): Delete.
3799         (m32c_dummy_id): Delete.
3800         (m32c_gdbarch_init): Don't register deleted functions with
3801         gdbarch.
3802
3803 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3804
3805         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
3806         (lm32_unwind_pc): Delete.
3807         (lm32_dummy_id): Delete.
3808         (lm32_gdbarch_init): Don't register deleted functions with
3809         gdbarch.
3810
3811 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3812
3813         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
3814         (iq2000_unwind_pc): Delete.
3815         (iq2000_dummy_id): Delete.
3816         (iq2000_gdbarch_init): Don't register deleted functions with
3817         gdbarch.
3818
3819 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3820
3821         * nds32-tdep.c (nds32_type_align): Delete.
3822         (nds32_push_dummy_call): Use type_align instead.
3823
3824 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3825
3826         * arm-tdep.c (arm_type_align): Only handle vector override case.
3827         (arm_push_dummy_call): Use type_align.
3828         (arm_gdbarch_init): Register arm_type_align gdbarch function.
3829
3830 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3831
3832         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
3833         case.
3834         (pass_on_stack): Use type_align.
3835         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
3836         function.
3837
3838 2019-04-23  Tom Tromey  <tromey@adacore.com>
3839
3840         * dwarf2read.c (line_header::file_name_at): Remove unused
3841         overload.
3842
3843 2019-04-23  Tom de Vries  <tdevries@suse.de>
3844
3845         PR gdb/24438
3846         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
3847         invocation.
3848
3849
3850 2019-03-27  Ali Tamur  <tamur@google.com>
3851
3852         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
3853         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
3854         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
3855         (dwarf_expr_context::get_addr_index): Likewise
3856         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
3857         (symbol_needs_eval_context::get_addr_index): Likewise
3858         (disassemble_dwarf_expression): Add DW_OP_addrx
3859         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
3860         (read_cutu_die_from_dwo): Update comment
3861         (skip_one_die): Add DW_FORM_addrx
3862         (read_attribute_value): Likewise
3863         (var_decode_location): Add DW_OP_addrx
3864         (dwarf2_const_value_attr): Add DW_FORM_addrx
3865         (dump_die_shallow): Likewise
3866         (dwarf2_fetch_constant_bytes): Likewise
3867         (decode_locdesc): Add DW_OP_addrx
3868         (skip_form_bytes): Add DW_FORM_addrx
3869
3870 2019-04-22  Ali Tamur  <tamur@google.com>
3871
3872         * MAINTAINERS (Write After Approval): Add self.
3873
3874 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
3875
3876         * solib-svr4.c (get_svr4_info): Add pspace parameter.
3877         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
3878         (open_symbol_file_object): Likewise.
3879         (svr4_default_sos): Add info parameter.
3880         (svr4_read_so_list): Likewise.
3881         (svr4_current_sos_direct): Adjust functions calls to pass down
3882         info.
3883         (svr4_current_sos_1): Add info parameter.
3884         (svr4_current_sos): Call get_svr4_info, pass info down to
3885         svr4_current_sos_1.
3886         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
3887         get_svr4_info.
3888         (svr4_in_dynsym_resolve_code): Pass current_program_space to
3889         get_svr4_info.
3890         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
3891         to get_svr4_info.
3892         (probes_table_remove_objfile_probes): Likewise.
3893         (register_solib_event_probe): Add info parameter.
3894         (solist_update_incremental): Pass info parameter down to
3895         svr4_read_so_list.
3896         (disable_probes_interface): Add info parameter.
3897         (svr4_handle_solib_event): Pass current_program_space to
3898         get_svr4_info.  Adjust disable_probes_interface cleanup.
3899         (svr4_create_probe_breakpoints): Add info parameter, pass it
3900         down to register_solib_event_probe.
3901         (svr4_create_solib_event_breakpoints): Add info parameter,
3902         pass it down to svr4_create_probe_breakpoints.
3903         (enable_break): Pass info down to
3904         svr4_create_solib_event_breakpoints.
3905         (svr4_solib_create_inferior_hook): Pass current_program_space to
3906         get_svr4_info.
3907         (svr4_clear_solib): Likewise.
3908
3909 2019-04-22  Pedro Alves  <palves@redhat.com>
3910
3911         * solib-svr4.c (svr4_free_objfile_observer): New.
3912         (probe_and_action::objfile): New field.
3913         (probes_table_htab_remove_objfile_probes)
3914         (probes_table_remove_objfile_probes): New functions.
3915         (register_solib_event_probe): Add 'objfile' parameter.  Store it
3916         in the new probe_and_action.  Don't store the probe in 'lookup'.
3917         (svr4_create_probe_breakpoints): Pass objfile to
3918         register_solib_event_probe.
3919         (_initialize_svr4_solib): Register a free_objfile observer.
3920
3921 2019-04-19  Tom Tromey  <tom@tromey.com>
3922
3923         * common/queue.h: Remove.
3924
3925 2019-04-19  Tom Tromey  <tom@tromey.com>
3926
3927         * event-loop.c: Don't include "common/queue.h".
3928
3929 2019-04-19  Tom Tromey  <tom@tromey.com>
3930
3931         * remote.c (remote_target): Use delete.
3932         * remote-notif.h: Include <list>, not "common/queue.h".
3933         (notif_client_p): Remove typedef.
3934         (remote_notif_state): Add constructor, destructor, initializer.
3935         <notif_queue>: Now a std::list.
3936         (remote_notif_state_xfree): Don't declare.
3937         * remote-notif.c (remote_notif_process, handle_notification)
3938         (remote_notif_state_allocate): Update.
3939         (~remote_notif_state): Rename from remote_notif_state_xfree.
3940
3941 2019-04-19  Tom Tromey  <tom@tromey.com>
3942
3943         * symfile.c (reread_symbols): Update.
3944         * objfiles.c (objfile_register_static_link)
3945         (objfile_lookup_static_link): Update
3946         (~objfile) Don't delete static_links.
3947         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
3948
3949 2019-04-19  Tom Tromey  <tom@tromey.com>
3950
3951         * type-stack.h (struct type_stack) <insert>: Constify string.
3952         * type-stack.c (type_stack::insert): Constify string.
3953         * gdbtypes.h (lookup_template_type): Update.
3954         (address_space_name_to_int): Update.
3955         * gdbtypes.c (address_space_name_to_int): Make space_identifier
3956         const.
3957         (lookup_template_type): Make name const.
3958         * c-exp.y: Update rules.
3959         (lex_one_token, classify_name, classify_inner_name)
3960         (c_print_token): Update.
3961         * p-exp.y: Update rules.
3962         (yylex): Update.
3963         * f-exp.y: Update rules.
3964         (yylex): Update.
3965         * d-exp.y: Update rules.
3966         (lex_one_token, classify_name, classify_inner_name): Update.
3967         * parse.c (write_dollar_variable, copy_name): Return std::string.
3968         * parser-defs.h (copy_name): Change return type.
3969         * m2-exp.y: Update rules.
3970         (yylex): Update.
3971         * go-exp.y (lex_one_token): Update.
3972         Update rules.
3973         (classify_unsafe_function, classify_packaged_name)
3974         (classify_name, yylex): Update.
3975
3976 2019-04-19  Sergei Trofimovich <siarheit@google.com>
3977
3978         * configure.ac: add --enable-source-highlight switch.
3979         * configure: Regenerate.
3980         * top.c (print_gdb_version): plumb --enable-source-highlight
3981         status to "show configuration".
3982
3983 2019-04-19  Tom Tromey  <tromey@adacore.com>
3984
3985         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
3986         Check ADA_TYPE_P.
3987         (empty_record, ada_template_to_fixed_record_type_1)
3988         (template_to_static_fixed_type)
3989         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
3990         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
3991         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
3992         macros.
3993
3994 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
3995
3996         PR symtab/24423:
3997         * source.c (print_source_lines_base): Advance "iter" when a
3998         control character is seen.
3999
4000 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4001
4002         * inferior.h (struct infcall_suspend_state_deleter):
4003         Catch exception in destructor to avoid crash.
4004
4005 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4006
4007         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4008         close to the add_com "shell".
4009
4010 2019-04-18  Tom Tromey  <tromey@adacore.com>
4011
4012         * process-stratum-target.h (class process_stratum_target)
4013         <stratum>: Add "final".
4014
4015 2019-04-17  Tom Tromey  <tromey@adacore.com>
4016
4017         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4018         against nullptr before use.
4019
4020 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4021
4022         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4023
4024 2019-04-17  Jim Wilson  <jimw@sifive.com>
4025             Andrew Burgess  <andrew.burgess@embecosm.com>
4026
4027         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4028         code read might fail, assume 4-byte breakpoint in that case.
4029
4030 2019-04-15  Leszek Swirski  <leszeks@google.com>
4031
4032         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4033         rather than a hand-rolled POD check when checking for forced MEMORY
4034         classification.
4035
4036 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4037
4038         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4039         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4040         function.
4041         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4042         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4043         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4044         declaration.
4045
4046 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4047
4048         * aarch64-linux-nat.c
4049         (aarch64_linux_nat_target::thread_architecture): Add override.
4050         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4051         each VQ.
4052
4053 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4054
4055         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4056
4057 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4058
4059         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4060         target types of size 96-bits, add some additional comments, and
4061         check that the builtin type we found was the correct size.
4062
4063 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4064
4065         * utils.c (prompt_for_continue): Don't restore the styling at the
4066         end, as applied_style has the wrong value.  This fixes styling in
4067         long lists of file names that are interrupted by the "Continue?"
4068         prompt.
4069
4070 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4071
4072         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4073         * c-lang.c (c_language_defn): Likewise.
4074         (cplus_language_defn): Likewise.
4075         (asm_language_defn): Likewise.
4076         (minimal_language_defn): Likewise.
4077         * d-lang.c (d_language_defn): Likewise.
4078         * f-lang.c (f_language_defn): Likewise.
4079         * go-lang.c (go_language_defn): Likewise.
4080         * language.c (unknown_language_defn): Likewise.
4081         (auto_language_defn): Likewise.
4082         * language.h (struct language_defn): Remove la_magic field.
4083         (LANG_MAGIC): Delete.
4084         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4085         * objc-lang.c (objc_language_defn): Likewise.
4086         * opencl-lang.c (opencl_language_defn): Likewise.
4087         * p-lang.c (pascal_language_defn): Likewise.
4088         * rust-lang.c (rust_language_defn): Likewise.
4089
4090 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4091
4092         * riscv-tdep.c (riscv_type_align): New function.
4093         (riscv_type_alignment): Delete.
4094         (riscv_arg_location): Use 'type_align'.
4095         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4096
4097 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4098
4099         * gdbtypes.c (type_align): A struct with no non-static fields also
4100         has alignment of 1.
4101
4102 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4103
4104         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4105         component to 0.
4106         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4107         member.
4108         (riscv_struct_info::analyse): New implementation using new
4109         analyse_inner member function.
4110         (riscv_struct_info::field_offset): New member function.
4111         (riscv_struct_info::m_offsets): New member variable.
4112         (riscv_struct_info::analyse_inner): New private member function,
4113         takes the old implementation of riscv_struct_info::analyse but
4114         extended to track field offsets.
4115         (riscv_call_arg_struct): Update the struct folding special cases
4116         to handle cases where empty C++ structs, which are non-zero
4117         length, are found.
4118         (riscv_arg_location): Initialise the length of each location, a
4119         non-zero length now indicates the location is in use.
4120         (riscv_push_dummy_call): Allow for the first location having a
4121         non-zero offset when setting up arguments.
4122         (riscv_return_value): Likewise, but for return values.
4123
4124 2019-04-11  Tom Tromey  <tromey@adacore.com>
4125
4126         * utils.c (internal_vproblem): Make "msg" const.
4127
4128 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4129
4130         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4131         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4132         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4133         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4134
4135 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4136
4137         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4138         function.
4139         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4140         of amd64_collect_native_gregset.
4141         (amd64_linux_nat_target::store_registers): Likewise.
4142
4143 2019-04-10  Tom Tromey  <tom@tromey.com>
4144
4145         * symtab.c (lookup_global_symbol_from_objfile)
4146         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4147         * objfiles.h (class separate_debug_iterator): New.
4148         (class separate_debug_range): New.
4149         (struct objfile) <separate_debug_objfiles>: New method.
4150         (objfile_separate_debug_iterate): Don't declare.
4151         * objfiles.c (separate_debug_iterator::operator++): Rename from
4152         objfile_separate_debug_iterate.
4153         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4154         iterator.
4155         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4156         iterator.
4157
4158 2019-04-10  Tom Tromey  <tom@tromey.com>
4159
4160         * symfile.c (reread_symbols): Remove old comment.
4161         * objfiles.c (free_all_objfiles): Fix a typo.
4162
4163 2019-04-10  Tom Tromey  <tom@tromey.com>
4164
4165         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4166         * minsyms.c (lookup_minimal_symbol): Use foreach.
4167         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4168         (lookup_minimal_symbol_solib_trampoline): Likewise.
4169         * symfile.c (reread_symbols): Use foreach.
4170
4171 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4172             Tom Tromey  <tromey@adacore.com>
4173
4174         PR rust/24414:
4175         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4176         (rust_lex_int_test): Change "value" to be LONGEST.
4177         (rust_lex_tests): Add test for long integer literal.
4178
4179 2019-04-09  Tom Tromey  <tromey@adacore.com>
4180
4181         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
4182         to bool.
4183         (extended_remote_target::attach): Update.
4184         (remote_target::remote_notice_new_inferior): Update.
4185         (remote_target::add_current_inferior_and_thread): Update.
4186         * inferior.c (exit_inferior_1): Use "false".
4187         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
4188
4189 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
4190
4191         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
4192         the "start" command.
4193
4194 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4195
4196         * python/py-inferior.c (infpy_thread_from_thread_handle):
4197         Adjust comments to reflect renaming of thread_from_thread_handle
4198         to thread_from_handle.  Adjust keywords.  Fix type error message.
4199         (inferior_object_methods): Add thread_from_handle.  Retain
4200         thread_from_thread_handle, but mark it as deprecated.
4201
4202 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4203
4204         * gdbthread.h (find_thread_by_handle): Revise declaration.
4205         * thread.c (find_thread_by_handle): Likewise.  Adjust
4206         implementation too.
4207         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
4208         support for buffer objects as handles.
4209
4210 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4211
4212         * python/py-infthread.c (thpy_thread_handle): New function.
4213         (thread_object_methods): Register thpy_thread_handle.
4214
4215 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4216
4217         * gdbthread.h (thread_to_thread_handle): Declare.
4218         * thread.c (gdbtypes.h): Include.
4219         (thread_to_thread_handle): New function.
4220
4221         * target.h (struct target_ops): Add thread_info_to_thread_handle.
4222         (target_thread_info_to_thread_handle): Declare.
4223         * target.c (target_thread_info_to_thread_handle): New function.
4224         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
4225         * target-delegates.c: Regenerate.
4226
4227         * linux-thread-db.c (class thread_db_target): Add method
4228         thread_info_to_thread_handle.
4229         (thread_db_target::thread_info_to_thread_handle): Define.
4230         * remote.c (class remote_target): Add new method
4231         thread_info_to_thread_handle.
4232         (remote_target::thread_info_to_thread_handle): Define.
4233
4234 2019-04-08  Pedro Alves  <palves@redhat.com>
4235
4236         * common/common-exceptions.c (throw_exception): Don't create
4237         named object to throw; throw directly.
4238         (throw_it): Likewise.  Don't initialize gdb_exception::message
4239         here, with new; pass FMT and AP to the ctor instead.
4240         * common/common-exceptions.h: Include <string>.
4241         (gdb_exception::gdb_exception(enum return_reason, enum errors,
4242         const char *, va_list)): New ctor.  Use std::make_shared.
4243         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
4244         errors)): Delete.
4245         (gdb_exception_error::gdb_exception_error(enum errors, const char
4246         *, va_list)): New.
4247         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
4248         Add assertion.
4249         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
4250         errors)): Delete.
4251         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
4252         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
4253         Add assertion.
4254
4255 2019-04-08  Tom Tromey  <tom@tromey.com>
4256
4257         * valops.c (value_rtti_indirect_type): Replace throw_exception
4258         with throw.
4259         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
4260         with throw.
4261         * thread.c (thr_try_catch_cmd): Replace throw_exception with
4262         throw.
4263         * target.c (target_translate_tls_address): Replace throw_exception
4264         with throw.
4265         * stack.c (frame_apply_command_count): Replace throw_exception
4266         with throw.
4267         * solib-spu.c (append_ocl_sos): Replace throw_exception with
4268         throw.
4269         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
4270         with throw.
4271         * rs6000-tdep.c (rs6000_frame_cache)
4272         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
4273         * remote.c: Replace throw_exception with throw.
4274         * record-full.c (record_full_message, record_full_wait_1)
4275         (record_full_restore): Replace throw_exception with throw.
4276         * record-btrace.c:
4277         (get_thread_current_frame_id, record_btrace_start_replaying)
4278         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
4279         (cmd_record_btrace_start): Replace throw_exception with throw.
4280         * parse.c (parse_exp_in_context_1): Replace throw_exception with
4281         throw.
4282         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
4283         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
4284         * linespec.c:
4285         (find_linespec_symbols): Replace throw_exception with throw.
4286         * infrun.c (displaced_step_prepare, resume): Replace
4287         throw_exception with throw.
4288         * infcmd.c (post_create_inferior): Replace throw_exception with
4289         throw.
4290         * inf-loop.c (inferior_event_handler): Replace throw_exception
4291         with throw.
4292         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
4293         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
4294         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
4295         (get_prev_frame_always, get_frame_pc_if_available)
4296         (get_frame_address_in_block_if_available, get_frame_language):
4297         Replace throw_exception with throw.
4298         * frame-unwind.c (frame_unwind_try_unwinder): Replace
4299         throw_exception with throw.
4300         * eval.c (fetch_subexp_value, evaluate_var_value)
4301         (evaluate_funcall, evaluate_subexp_standard): Replace
4302         throw_exception with throw.
4303         * dwarf2loc.c (call_site_find_chain)
4304         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
4305         Replace throw_exception with throw.
4306         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
4307         with throw.
4308         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
4309         throw.
4310         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
4311         * completer.c (complete_line_internal): Replace throw_exception
4312         with throw.
4313         * compile/compile-object-run.c (compile_object_run): Replace
4314         throw_exception with throw.
4315         * cli/cli-script.c (process_next_line): Replace throw_exception
4316         with throw.
4317         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
4318         (btrace_enable, btrace_maint_update_pt_packets): Replace
4319         throw_exception with throw.
4320         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
4321         throw_exception with throw.
4322         * break-catch-throw.c (re_set_exception_catchpoint): Replace
4323         throw_exception with throw.
4324         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
4325         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
4326         * aarch64-tdep.c (aarch64_make_prologue_cache)
4327         (aarch64_make_stub_cache): Replace throw_exception with throw.
4328
4329 2019-04-08  Tom Tromey  <tom@tromey.com>
4330
4331         * common/common-exceptions.c (throw_exception): Rename from
4332         throw_exception_cxx.  Remove old copy.  Make argument const.
4333         (throw_it): Create and throw exception objects directly.
4334         * common/common-exceptions.h (throw_exception): Make argument
4335         const.
4336         (struct gdb_exception_error): Add constructor.
4337         (struct gdb_exception_quit): Add constructor.
4338
4339 2019-04-08  Tom Tromey  <tom@tromey.com>
4340
4341         * common/common-exceptions.h (exception_rethrow): Don't declare.
4342         (TRY_SJLJ): Update comment.
4343         (TRY, CATCH, END_CATCH): Remove.
4344         * common/common-exceptions.c (exception_rethrow): Remove.
4345
4346 2019-04-08  Tom Tromey  <tom@tromey.com>
4347
4348         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
4349         Remove.
4350         (gdb_exception_error): Rename from
4351         gdb_exception_RETURN_MASK_ERROR.
4352         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
4353         (gdb_quit_bad_alloc): Update.
4354         * aarch64-tdep.c: Update.
4355         * ada-lang.c: Update.
4356         * ada-typeprint.c: Update.
4357         * ada-valprint.c: Update.
4358         * amd64-tdep.c: Update.
4359         * arch-utils.c: Update.
4360         * break-catch-throw.c: Update.
4361         * breakpoint.c: Update.
4362         * btrace.c: Update.
4363         * c-varobj.c: Update.
4364         * cli/cli-cmds.c: Update.
4365         * cli/cli-interp.c: Update.
4366         * cli/cli-script.c: Update.
4367         * common/common-exceptions.c: Update.
4368         * common/new-op.c: Update.
4369         * common/selftest.c: Update.
4370         * compile/compile-c-symbols.c: Update.
4371         * compile/compile-cplus-symbols.c: Update.
4372         * compile/compile-object-load.c: Update.
4373         * compile/compile-object-run.c: Update.
4374         * completer.c: Update.
4375         * corelow.c: Update.
4376         * cp-abi.c: Update.
4377         * cp-support.c: Update.
4378         * cp-valprint.c: Update.
4379         * darwin-nat.c: Update.
4380         * disasm-selftests.c: Update.
4381         * dtrace-probe.c: Update.
4382         * dwarf-index-cache.c: Update.
4383         * dwarf-index-write.c: Update.
4384         * dwarf2-frame-tailcall.c: Update.
4385         * dwarf2-frame.c: Update.
4386         * dwarf2loc.c: Update.
4387         * dwarf2read.c: Update.
4388         * eval.c: Update.
4389         * event-loop.c: Update.
4390         * event-top.c: Update.
4391         * exec.c: Update.
4392         * f-valprint.c: Update.
4393         * fbsd-tdep.c: Update.
4394         * frame-unwind.c: Update.
4395         * frame.c: Update.
4396         * gdbtypes.c: Update.
4397         * gnu-v3-abi.c: Update.
4398         * guile/guile-internal.h: Update.
4399         * guile/scm-block.c: Update.
4400         * guile/scm-breakpoint.c: Update.
4401         * guile/scm-cmd.c: Update.
4402         * guile/scm-disasm.c: Update.
4403         * guile/scm-frame.c: Update.
4404         * guile/scm-lazy-string.c: Update.
4405         * guile/scm-math.c: Update.
4406         * guile/scm-param.c: Update.
4407         * guile/scm-ports.c: Update.
4408         * guile/scm-pretty-print.c: Update.
4409         * guile/scm-symbol.c: Update.
4410         * guile/scm-symtab.c: Update.
4411         * guile/scm-type.c: Update.
4412         * guile/scm-value.c: Update.
4413         * i386-linux-tdep.c: Update.
4414         * i386-tdep.c: Update.
4415         * inf-loop.c: Update.
4416         * infcall.c: Update.
4417         * infcmd.c: Update.
4418         * infrun.c: Update.
4419         * jit.c: Update.
4420         * language.c: Update.
4421         * linespec.c: Update.
4422         * linux-fork.c: Update.
4423         * linux-nat.c: Update.
4424         * linux-tdep.c: Update.
4425         * linux-thread-db.c: Update.
4426         * main.c: Update.
4427         * mi/mi-cmd-break.c: Update.
4428         * mi/mi-cmd-stack.c: Update.
4429         * mi/mi-interp.c: Update.
4430         * mi/mi-main.c: Update.
4431         * objc-lang.c: Update.
4432         * p-valprint.c: Update.
4433         * parse.c: Update.
4434         * ppc-linux-tdep.c: Update.
4435         * printcmd.c: Update.
4436         * python/py-arch.c: Update.
4437         * python/py-breakpoint.c: Update.
4438         * python/py-cmd.c: Update.
4439         * python/py-finishbreakpoint.c: Update.
4440         * python/py-frame.c: Update.
4441         * python/py-framefilter.c: Update.
4442         * python/py-gdb-readline.c: Update.
4443         * python/py-inferior.c: Update.
4444         * python/py-infthread.c: Update.
4445         * python/py-lazy-string.c: Update.
4446         * python/py-linetable.c: Update.
4447         * python/py-objfile.c: Update.
4448         * python/py-param.c: Update.
4449         * python/py-prettyprint.c: Update.
4450         * python/py-progspace.c: Update.
4451         * python/py-record-btrace.c: Update.
4452         * python/py-record.c: Update.
4453         * python/py-symbol.c: Update.
4454         * python/py-type.c: Update.
4455         * python/py-unwind.c: Update.
4456         * python/py-utils.c: Update.
4457         * python/py-value.c: Update.
4458         * python/python.c: Update.
4459         * record-btrace.c: Update.
4460         * record-full.c: Update.
4461         * remote-fileio.c: Update.
4462         * remote.c: Update.
4463         * riscv-tdep.c: Update.
4464         * rs6000-aix-tdep.c: Update.
4465         * rs6000-tdep.c: Update.
4466         * rust-exp.y: Update.
4467         * rust-lang.c: Update.
4468         * s390-tdep.c: Update.
4469         * selftest-arch.c: Update.
4470         * solib-dsbt.c: Update.
4471         * solib-frv.c: Update.
4472         * solib-spu.c: Update.
4473         * solib-svr4.c: Update.
4474         * solib.c: Update.
4475         * sparc64-linux-tdep.c: Update.
4476         * stack.c: Update.
4477         * symfile-mem.c: Update.
4478         * symmisc.c: Update.
4479         * target.c: Update.
4480         * thread.c: Update.
4481         * top.c: Update.
4482         * tracefile-tfile.c: Update.
4483         * tui/tui.c: Update.
4484         * typeprint.c: Update.
4485         * unittests/cli-utils-selftests.c: Update.
4486         * unittests/parse-connection-spec-selftests.c: Update.
4487         * valops.c: Update.
4488         * valprint.c: Update.
4489         * value.c: Update.
4490         * varobj.c: Update.
4491         * windows-nat.c: Update.
4492         * x86-linux-nat.c: Update.
4493         * xml-support.c: Update.
4494
4495 2019-04-08  Tom Tromey  <tom@tromey.com>
4496
4497         * xml-support.c: Use C++ exception handling.
4498         * x86-linux-nat.c: Use C++ exception handling.
4499         * windows-nat.c: Use C++ exception handling.
4500         * varobj.c: Use C++ exception handling.
4501         * value.c: Use C++ exception handling.
4502         * valprint.c: Use C++ exception handling.
4503         * valops.c: Use C++ exception handling.
4504         * unittests/parse-connection-spec-selftests.c: Use C++ exception
4505         handling.
4506         * unittests/cli-utils-selftests.c: Use C++ exception handling.
4507         * typeprint.c: Use C++ exception handling.
4508         * tui/tui.c: Use C++ exception handling.
4509         * tracefile-tfile.c: Use C++ exception handling.
4510         * top.c: Use C++ exception handling.
4511         * thread.c: Use C++ exception handling.
4512         * target.c: Use C++ exception handling.
4513         * symmisc.c: Use C++ exception handling.
4514         * symfile-mem.c: Use C++ exception handling.
4515         * stack.c: Use C++ exception handling.
4516         * sparc64-linux-tdep.c: Use C++ exception handling.
4517         * solib.c: Use C++ exception handling.
4518         * solib-svr4.c: Use C++ exception handling.
4519         * solib-spu.c: Use C++ exception handling.
4520         * solib-frv.c: Use C++ exception handling.
4521         * solib-dsbt.c: Use C++ exception handling.
4522         * selftest-arch.c: Use C++ exception handling.
4523         * s390-tdep.c: Use C++ exception handling.
4524         * rust-lang.c: Use C++ exception handling.
4525         * rust-exp.y: Use C++ exception handling.
4526         * rs6000-tdep.c: Use C++ exception handling.
4527         * rs6000-aix-tdep.c: Use C++ exception handling.
4528         * riscv-tdep.c: Use C++ exception handling.
4529         * remote.c: Use C++ exception handling.
4530         * remote-fileio.c: Use C++ exception handling.
4531         * record-full.c: Use C++ exception handling.
4532         * record-btrace.c: Use C++ exception handling.
4533         * python/python.c: Use C++ exception handling.
4534         * python/py-value.c: Use C++ exception handling.
4535         * python/py-utils.c: Use C++ exception handling.
4536         * python/py-unwind.c: Use C++ exception handling.
4537         * python/py-type.c: Use C++ exception handling.
4538         * python/py-symbol.c: Use C++ exception handling.
4539         * python/py-record.c: Use C++ exception handling.
4540         * python/py-record-btrace.c: Use C++ exception handling.
4541         * python/py-progspace.c: Use C++ exception handling.
4542         * python/py-prettyprint.c: Use C++ exception handling.
4543         * python/py-param.c: Use C++ exception handling.
4544         * python/py-objfile.c: Use C++ exception handling.
4545         * python/py-linetable.c: Use C++ exception handling.
4546         * python/py-lazy-string.c: Use C++ exception handling.
4547         * python/py-infthread.c: Use C++ exception handling.
4548         * python/py-inferior.c: Use C++ exception handling.
4549         * python/py-gdb-readline.c: Use C++ exception handling.
4550         * python/py-framefilter.c: Use C++ exception handling.
4551         * python/py-frame.c: Use C++ exception handling.
4552         * python/py-finishbreakpoint.c: Use C++ exception handling.
4553         * python/py-cmd.c: Use C++ exception handling.
4554         * python/py-breakpoint.c: Use C++ exception handling.
4555         * python/py-arch.c: Use C++ exception handling.
4556         * printcmd.c: Use C++ exception handling.
4557         * ppc-linux-tdep.c: Use C++ exception handling.
4558         * parse.c: Use C++ exception handling.
4559         * p-valprint.c: Use C++ exception handling.
4560         * objc-lang.c: Use C++ exception handling.
4561         * mi/mi-main.c: Use C++ exception handling.
4562         * mi/mi-interp.c: Use C++ exception handling.
4563         * mi/mi-cmd-stack.c: Use C++ exception handling.
4564         * mi/mi-cmd-break.c: Use C++ exception handling.
4565         * main.c: Use C++ exception handling.
4566         * linux-thread-db.c: Use C++ exception handling.
4567         * linux-tdep.c: Use C++ exception handling.
4568         * linux-nat.c: Use C++ exception handling.
4569         * linux-fork.c: Use C++ exception handling.
4570         * linespec.c: Use C++ exception handling.
4571         * language.c: Use C++ exception handling.
4572         * jit.c: Use C++ exception handling.
4573         * infrun.c: Use C++ exception handling.
4574         * infcmd.c: Use C++ exception handling.
4575         * infcall.c: Use C++ exception handling.
4576         * inf-loop.c: Use C++ exception handling.
4577         * i386-tdep.c: Use C++ exception handling.
4578         * i386-linux-tdep.c: Use C++ exception handling.
4579         * guile/scm-value.c: Use C++ exception handling.
4580         * guile/scm-type.c: Use C++ exception handling.
4581         * guile/scm-symtab.c: Use C++ exception handling.
4582         * guile/scm-symbol.c: Use C++ exception handling.
4583         * guile/scm-pretty-print.c: Use C++ exception handling.
4584         * guile/scm-ports.c: Use C++ exception handling.
4585         * guile/scm-param.c: Use C++ exception handling.
4586         * guile/scm-math.c: Use C++ exception handling.
4587         * guile/scm-lazy-string.c: Use C++ exception handling.
4588         * guile/scm-frame.c: Use C++ exception handling.
4589         * guile/scm-disasm.c: Use C++ exception handling.
4590         * guile/scm-cmd.c: Use C++ exception handling.
4591         * guile/scm-breakpoint.c: Use C++ exception handling.
4592         * guile/scm-block.c: Use C++ exception handling.
4593         * guile/guile-internal.h: Use C++ exception handling.
4594         * gnu-v3-abi.c: Use C++ exception handling.
4595         * gdbtypes.c: Use C++ exception handling.
4596         * frame.c: Use C++ exception handling.
4597         * frame-unwind.c: Use C++ exception handling.
4598         * fbsd-tdep.c: Use C++ exception handling.
4599         * f-valprint.c: Use C++ exception handling.
4600         * exec.c: Use C++ exception handling.
4601         * event-top.c: Use C++ exception handling.
4602         * event-loop.c: Use C++ exception handling.
4603         * eval.c: Use C++ exception handling.
4604         * dwarf2read.c: Use C++ exception handling.
4605         * dwarf2loc.c: Use C++ exception handling.
4606         * dwarf2-frame.c: Use C++ exception handling.
4607         * dwarf2-frame-tailcall.c: Use C++ exception handling.
4608         * dwarf-index-write.c: Use C++ exception handling.
4609         * dwarf-index-cache.c: Use C++ exception handling.
4610         * dtrace-probe.c: Use C++ exception handling.
4611         * disasm-selftests.c: Use C++ exception handling.
4612         * darwin-nat.c: Use C++ exception handling.
4613         * cp-valprint.c: Use C++ exception handling.
4614         * cp-support.c: Use C++ exception handling.
4615         * cp-abi.c: Use C++ exception handling.
4616         * corelow.c: Use C++ exception handling.
4617         * completer.c: Use C++ exception handling.
4618         * compile/compile-object-run.c: Use C++ exception handling.
4619         * compile/compile-object-load.c: Use C++ exception handling.
4620         * compile/compile-cplus-symbols.c: Use C++ exception handling.
4621         * compile/compile-c-symbols.c: Use C++ exception handling.
4622         * common/selftest.c: Use C++ exception handling.
4623         * common/new-op.c: Use C++ exception handling.
4624         * cli/cli-script.c: Use C++ exception handling.
4625         * cli/cli-interp.c: Use C++ exception handling.
4626         * cli/cli-cmds.c: Use C++ exception handling.
4627         * c-varobj.c: Use C++ exception handling.
4628         * btrace.c: Use C++ exception handling.
4629         * breakpoint.c: Use C++ exception handling.
4630         * break-catch-throw.c: Use C++ exception handling.
4631         * arch-utils.c: Use C++ exception handling.
4632         * amd64-tdep.c: Use C++ exception handling.
4633         * ada-valprint.c: Use C++ exception handling.
4634         * ada-typeprint.c: Use C++ exception handling.
4635         * ada-lang.c: Use C++ exception handling.
4636         * aarch64-tdep.c: Use C++ exception handling.
4637
4638 2019-04-08  Tom Tromey  <tom@tromey.com>
4639
4640         * xml-support.c (gdb_xml_parser::parse): Update.
4641         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4642         * value.c (show_convenience): Update.
4643         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
4644         (test_parse_flags_qcs): Update.
4645         * thread.c (thr_try_catch_cmd): Update.
4646         * target.c (target_translate_tls_address): Update.
4647         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4648         (info_frame_command_core, frame_apply_command_count): Update.
4649         * rust-exp.y (rust_lex_exception_test): Update.
4650         * riscv-tdep.c (riscv_print_one_register_info): Update.
4651         * remote.c (remote_target::enable_btrace): Update.
4652         * record-btrace.c (record_btrace_enable_warn): Update.
4653         * python/py-utils.c (gdbpy_convert_exception): Update.
4654         * printcmd.c (do_one_display, print_variable_and_value): Update.
4655         * mi/mi-main.c (mi_print_exception): Update.
4656         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
4657         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4658         * linux-nat.c (linux_nat_target::attach): Update.
4659         * linux-fork.c (class scoped_switch_fork_info): Update.
4660         * infrun.c (displaced_step_prepare): Update.
4661         * infcall.c (call_function_by_hand_dummy): Update.
4662         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
4663         * gnu-v3-abi.c (print_one_vtable): Update.
4664         * frame.c (get_prev_frame_always): Update.
4665         * f-valprint.c (info_common_command_for_block): Update.
4666         * exec.c (try_open_exec_file): Update.
4667         * exceptions.c (print_exception, exception_print)
4668         (exception_fprintf, exception_print_same): Update.
4669         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
4670         * dwarf-index-cache.c (index_cache::store)
4671         (index_cache::lookup_gdb_index): Update.
4672         * darwin-nat.c (maybe_cache_shell): Update.
4673         * cp-valprint.c (cp_print_value_fields): Update.
4674         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
4675         (gcc_cplus_symbol_address): Update.
4676         * compile/compile-c-symbols.c (gcc_convert_symbol)
4677         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
4678         * common/selftest.c: Update.
4679         * common/common-exceptions.h (struct gdb_exception) <message>: Now
4680         a std::string.
4681         (exception_try_scope_entry, exception_try_scope_exit): Don't
4682         declare.
4683         (struct exception_try_scope): Remove.
4684         (TRY): Don't use exception_try_scope.
4685         (struct gdb_exception): Add constructor, operator=.
4686         <what>: New method.
4687         (struct gdb_exception_RETURN_MASK_ALL)
4688         (struct gdb_exception_RETURN_MASK_ERROR)
4689         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
4690         (struct gdb_quit_bad_alloc): Update.
4691         * common/common-exceptions.c (exception_none): Change
4692         initializer.
4693         (struct catcher) <state, exception>: Initialize inline.
4694         <prev>: Remove member.
4695         (current_catcher): Remove.
4696         (catchers): New global.
4697         (exceptions_state_mc_init): Simplify.
4698         (catcher_pop): Remove.
4699         (exceptions_state_mc, exceptions_state_mc_catch): Update.
4700         (try_scope_depth, exception_try_scope_entry)
4701         (exception_try_scope_exit): Remove.
4702         (throw_exception_sjlj): Update.
4703         (exception_messages, exception_messages_size): Remove.
4704         (throw_it): Simplify.
4705         (gdb_exception_sliced_copy): Remove.
4706         (throw_exception_cxx): Update.
4707         * cli/cli-script.c (script_from_file): Update.
4708         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
4709         Update.
4710         * ada-valprint.c (ada_val_print): Update.
4711         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
4712         (create_excep_cond_exprs): Update.
4713
4714 2019-04-08  Tom Tromey  <tom@tromey.com>
4715
4716         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
4717         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
4718         (TRY, CATCH, END_CATCH): Remove some definitions.
4719         * common/common-exceptions.c: Don't use GDB_XCPT.
4720         (catcher_list_size): Remove.
4721         (throw_exception, throw_it): Simplify.
4722
4723 2019-04-05  Tom Tromey  <tom@tromey.com>
4724
4725         Revert the header-sorting patch.
4726         * ft32-tdep.c: Revert.
4727         * frv-tdep.c: Revert.
4728         * frv-linux-tdep.c: Revert.
4729         * frame.c: Revert.
4730         * frame-unwind.c: Revert.
4731         * frame-base.c: Revert.
4732         * fork-child.c: Revert.
4733         * findvar.c: Revert.
4734         * findcmd.c: Revert.
4735         * filesystem.c: Revert.
4736         * filename-seen-cache.h: Revert.
4737         * filename-seen-cache.c: Revert.
4738         * fbsd-tdep.c: Revert.
4739         * fbsd-nat.h: Revert.
4740         * fbsd-nat.c: Revert.
4741         * f-valprint.c: Revert.
4742         * f-typeprint.c: Revert.
4743         * f-lang.c: Revert.
4744         * extension.h: Revert.
4745         * extension.c: Revert.
4746         * extension-priv.h: Revert.
4747         * expprint.c: Revert.
4748         * exec.h: Revert.
4749         * exec.c: Revert.
4750         * exceptions.c: Revert.
4751         * event-top.c: Revert.
4752         * event-loop.c: Revert.
4753         * eval.c: Revert.
4754         * elfread.c: Revert.
4755         * dwarf2read.h: Revert.
4756         * dwarf2read.c: Revert.
4757         * dwarf2loc.c: Revert.
4758         * dwarf2expr.h: Revert.
4759         * dwarf2expr.c: Revert.
4760         * dwarf2-frame.c: Revert.
4761         * dwarf2-frame-tailcall.c: Revert.
4762         * dwarf-index-write.h: Revert.
4763         * dwarf-index-write.c: Revert.
4764         * dwarf-index-common.c: Revert.
4765         * dwarf-index-cache.h: Revert.
4766         * dwarf-index-cache.c: Revert.
4767         * dummy-frame.c: Revert.
4768         * dtrace-probe.c: Revert.
4769         * disasm.h: Revert.
4770         * disasm.c: Revert.
4771         * disasm-selftests.c: Revert.
4772         * dictionary.c: Revert.
4773         * dicos-tdep.c: Revert.
4774         * demangle.c: Revert.
4775         * dcache.h: Revert.
4776         * dcache.c: Revert.
4777         * darwin-nat.h: Revert.
4778         * darwin-nat.c: Revert.
4779         * darwin-nat-info.c: Revert.
4780         * d-valprint.c: Revert.
4781         * d-namespace.c: Revert.
4782         * d-lang.c: Revert.
4783         * ctf.c: Revert.
4784         * csky-tdep.c: Revert.
4785         * csky-linux-tdep.c: Revert.
4786         * cris-tdep.c: Revert.
4787         * cris-linux-tdep.c: Revert.
4788         * cp-valprint.c: Revert.
4789         * cp-support.c: Revert.
4790         * cp-namespace.c: Revert.
4791         * cp-abi.c: Revert.
4792         * corelow.c: Revert.
4793         * corefile.c: Revert.
4794         * continuations.c: Revert.
4795         * completer.h: Revert.
4796         * completer.c: Revert.
4797         * complaints.c: Revert.
4798         * coffread.c: Revert.
4799         * coff-pe-read.c: Revert.
4800         * cli-out.h: Revert.
4801         * cli-out.c: Revert.
4802         * charset.c: Revert.
4803         * c-varobj.c: Revert.
4804         * c-valprint.c: Revert.
4805         * c-typeprint.c: Revert.
4806         * c-lang.c: Revert.
4807         * buildsym.c: Revert.
4808         * buildsym-legacy.c: Revert.
4809         * build-id.h: Revert.
4810         * build-id.c: Revert.
4811         * btrace.c: Revert.
4812         * bsd-uthread.c: Revert.
4813         * breakpoint.h: Revert.
4814         * breakpoint.c: Revert.
4815         * break-catch-throw.c: Revert.
4816         * break-catch-syscall.c: Revert.
4817         * break-catch-sig.c: Revert.
4818         * blockframe.c: Revert.
4819         * block.c: Revert.
4820         * bfin-tdep.c: Revert.
4821         * bfin-linux-tdep.c: Revert.
4822         * bfd-target.c: Revert.
4823         * bcache.c: Revert.
4824         * ax-general.c: Revert.
4825         * ax-gdb.h: Revert.
4826         * ax-gdb.c: Revert.
4827         * avr-tdep.c: Revert.
4828         * auxv.c: Revert.
4829         * auto-load.c: Revert.
4830         * arm-wince-tdep.c: Revert.
4831         * arm-tdep.c: Revert.
4832         * arm-symbian-tdep.c: Revert.
4833         * arm-pikeos-tdep.c: Revert.
4834         * arm-obsd-tdep.c: Revert.
4835         * arm-nbsd-tdep.c: Revert.
4836         * arm-nbsd-nat.c: Revert.
4837         * arm-linux-tdep.c: Revert.
4838         * arm-linux-nat.c: Revert.
4839         * arm-fbsd-tdep.c: Revert.
4840         * arm-fbsd-nat.c: Revert.
4841         * arm-bsd-tdep.c: Revert.
4842         * arch-utils.c: Revert.
4843         * arc-tdep.c: Revert.
4844         * arc-newlib-tdep.c: Revert.
4845         * annotate.h: Revert.
4846         * annotate.c: Revert.
4847         * amd64-windows-tdep.c: Revert.
4848         * amd64-windows-nat.c: Revert.
4849         * amd64-tdep.c: Revert.
4850         * amd64-sol2-tdep.c: Revert.
4851         * amd64-obsd-tdep.c: Revert.
4852         * amd64-obsd-nat.c: Revert.
4853         * amd64-nbsd-tdep.c: Revert.
4854         * amd64-nbsd-nat.c: Revert.
4855         * amd64-nat.c: Revert.
4856         * amd64-linux-tdep.c: Revert.
4857         * amd64-linux-nat.c: Revert.
4858         * amd64-fbsd-tdep.c: Revert.
4859         * amd64-fbsd-nat.c: Revert.
4860         * amd64-dicos-tdep.c: Revert.
4861         * amd64-darwin-tdep.c: Revert.
4862         * amd64-bsd-nat.c: Revert.
4863         * alpha-tdep.c: Revert.
4864         * alpha-obsd-tdep.c: Revert.
4865         * alpha-nbsd-tdep.c: Revert.
4866         * alpha-mdebug-tdep.c: Revert.
4867         * alpha-linux-tdep.c: Revert.
4868         * alpha-linux-nat.c: Revert.
4869         * alpha-bsd-tdep.c: Revert.
4870         * alpha-bsd-nat.c: Revert.
4871         * aix-thread.c: Revert.
4872         * agent.c: Revert.
4873         * addrmap.c: Revert.
4874         * ada-varobj.c: Revert.
4875         * ada-valprint.c: Revert.
4876         * ada-typeprint.c: Revert.
4877         * ada-tasks.c: Revert.
4878         * ada-lang.c: Revert.
4879         * aarch64-tdep.c: Revert.
4880         * aarch64-ravenscar-thread.c: Revert.
4881         * aarch64-newlib-tdep.c: Revert.
4882         * aarch64-linux-tdep.c: Revert.
4883         * aarch64-linux-nat.c: Revert.
4884         * aarch64-fbsd-tdep.c: Revert.
4885         * aarch64-fbsd-nat.c: Revert.
4886         * aarch32-linux-nat.c: Revert.
4887
4888 2019-04-05  Tom Tromey  <tom@tromey.com>
4889
4890         * ft32-tdep.c: Sort headers.
4891         * frv-tdep.c: Sort headers.
4892         * frv-linux-tdep.c: Sort headers.
4893         * frame.c: Sort headers.
4894         * frame-unwind.c: Sort headers.
4895         * frame-base.c: Sort headers.
4896         * fork-child.c: Sort headers.
4897         * findvar.c: Sort headers.
4898         * findcmd.c: Sort headers.
4899         * filesystem.c: Sort headers.
4900         * filename-seen-cache.h: Sort headers.
4901         * filename-seen-cache.c: Sort headers.
4902         * fbsd-tdep.c: Sort headers.
4903         * fbsd-nat.h: Sort headers.
4904         * fbsd-nat.c: Sort headers.
4905         * f-valprint.c: Sort headers.
4906         * f-typeprint.c: Sort headers.
4907         * f-lang.c: Sort headers.
4908         * extension.h: Sort headers.
4909         * extension.c: Sort headers.
4910         * extension-priv.h: Sort headers.
4911         * expprint.c: Sort headers.
4912         * exec.h: Sort headers.
4913         * exec.c: Sort headers.
4914         * exceptions.c: Sort headers.
4915         * event-top.c: Sort headers.
4916         * event-loop.c: Sort headers.
4917         * eval.c: Sort headers.
4918         * elfread.c: Sort headers.
4919         * dwarf2read.h: Sort headers.
4920         * dwarf2read.c: Sort headers.
4921         * dwarf2loc.c: Sort headers.
4922         * dwarf2expr.h: Sort headers.
4923         * dwarf2expr.c: Sort headers.
4924         * dwarf2-frame.c: Sort headers.
4925         * dwarf2-frame-tailcall.c: Sort headers.
4926         * dwarf-index-write.h: Sort headers.
4927         * dwarf-index-write.c: Sort headers.
4928         * dwarf-index-common.c: Sort headers.
4929         * dwarf-index-cache.h: Sort headers.
4930         * dwarf-index-cache.c: Sort headers.
4931         * dummy-frame.c: Sort headers.
4932         * dtrace-probe.c: Sort headers.
4933         * disasm.h: Sort headers.
4934         * disasm.c: Sort headers.
4935         * disasm-selftests.c: Sort headers.
4936         * dictionary.c: Sort headers.
4937         * dicos-tdep.c: Sort headers.
4938         * demangle.c: Sort headers.
4939         * dcache.h: Sort headers.
4940         * dcache.c: Sort headers.
4941         * darwin-nat.h: Sort headers.
4942         * darwin-nat.c: Sort headers.
4943         * darwin-nat-info.c: Sort headers.
4944         * d-valprint.c: Sort headers.
4945         * d-namespace.c: Sort headers.
4946         * d-lang.c: Sort headers.
4947         * ctf.c: Sort headers.
4948         * csky-tdep.c: Sort headers.
4949         * csky-linux-tdep.c: Sort headers.
4950         * cris-tdep.c: Sort headers.
4951         * cris-linux-tdep.c: Sort headers.
4952         * cp-valprint.c: Sort headers.
4953         * cp-support.c: Sort headers.
4954         * cp-namespace.c: Sort headers.
4955         * cp-abi.c: Sort headers.
4956         * corelow.c: Sort headers.
4957         * corefile.c: Sort headers.
4958         * continuations.c: Sort headers.
4959         * completer.h: Sort headers.
4960         * completer.c: Sort headers.
4961         * complaints.c: Sort headers.
4962         * coffread.c: Sort headers.
4963         * coff-pe-read.c: Sort headers.
4964         * cli-out.h: Sort headers.
4965         * cli-out.c: Sort headers.
4966         * charset.c: Sort headers.
4967         * c-varobj.c: Sort headers.
4968         * c-valprint.c: Sort headers.
4969         * c-typeprint.c: Sort headers.
4970         * c-lang.c: Sort headers.
4971         * buildsym.c: Sort headers.
4972         * buildsym-legacy.c: Sort headers.
4973         * build-id.h: Sort headers.
4974         * build-id.c: Sort headers.
4975         * btrace.c: Sort headers.
4976         * bsd-uthread.c: Sort headers.
4977         * breakpoint.h: Sort headers.
4978         * breakpoint.c: Sort headers.
4979         * break-catch-throw.c: Sort headers.
4980         * break-catch-syscall.c: Sort headers.
4981         * break-catch-sig.c: Sort headers.
4982         * blockframe.c: Sort headers.
4983         * block.c: Sort headers.
4984         * bfin-tdep.c: Sort headers.
4985         * bfin-linux-tdep.c: Sort headers.
4986         * bfd-target.c: Sort headers.
4987         * bcache.c: Sort headers.
4988         * ax-general.c: Sort headers.
4989         * ax-gdb.h: Sort headers.
4990         * ax-gdb.c: Sort headers.
4991         * avr-tdep.c: Sort headers.
4992         * auxv.c: Sort headers.
4993         * auto-load.c: Sort headers.
4994         * arm-wince-tdep.c: Sort headers.
4995         * arm-tdep.c: Sort headers.
4996         * arm-symbian-tdep.c: Sort headers.
4997         * arm-pikeos-tdep.c: Sort headers.
4998         * arm-obsd-tdep.c: Sort headers.
4999         * arm-nbsd-tdep.c: Sort headers.
5000         * arm-nbsd-nat.c: Sort headers.
5001         * arm-linux-tdep.c: Sort headers.
5002         * arm-linux-nat.c: Sort headers.
5003         * arm-fbsd-tdep.c: Sort headers.
5004         * arm-fbsd-nat.c: Sort headers.
5005         * arm-bsd-tdep.c: Sort headers.
5006         * arch-utils.c: Sort headers.
5007         * arc-tdep.c: Sort headers.
5008         * arc-newlib-tdep.c: Sort headers.
5009         * annotate.h: Sort headers.
5010         * annotate.c: Sort headers.
5011         * amd64-windows-tdep.c: Sort headers.
5012         * amd64-windows-nat.c: Sort headers.
5013         * amd64-tdep.c: Sort headers.
5014         * amd64-sol2-tdep.c: Sort headers.
5015         * amd64-obsd-tdep.c: Sort headers.
5016         * amd64-obsd-nat.c: Sort headers.
5017         * amd64-nbsd-tdep.c: Sort headers.
5018         * amd64-nbsd-nat.c: Sort headers.
5019         * amd64-nat.c: Sort headers.
5020         * amd64-linux-tdep.c: Sort headers.
5021         * amd64-linux-nat.c: Sort headers.
5022         * amd64-fbsd-tdep.c: Sort headers.
5023         * amd64-fbsd-nat.c: Sort headers.
5024         * amd64-dicos-tdep.c: Sort headers.
5025         * amd64-darwin-tdep.c: Sort headers.
5026         * amd64-bsd-nat.c: Sort headers.
5027         * alpha-tdep.c: Sort headers.
5028         * alpha-obsd-tdep.c: Sort headers.
5029         * alpha-nbsd-tdep.c: Sort headers.
5030         * alpha-mdebug-tdep.c: Sort headers.
5031         * alpha-linux-tdep.c: Sort headers.
5032         * alpha-linux-nat.c: Sort headers.
5033         * alpha-bsd-tdep.c: Sort headers.
5034         * alpha-bsd-nat.c: Sort headers.
5035         * aix-thread.c: Sort headers.
5036         * agent.c: Sort headers.
5037         * addrmap.c: Sort headers.
5038         * ada-varobj.c: Sort headers.
5039         * ada-valprint.c: Sort headers.
5040         * ada-typeprint.c: Sort headers.
5041         * ada-tasks.c: Sort headers.
5042         * ada-lang.c: Sort headers.
5043         * aarch64-tdep.c: Sort headers.
5044         * aarch64-ravenscar-thread.c: Sort headers.
5045         * aarch64-newlib-tdep.c: Sort headers.
5046         * aarch64-linux-tdep.c: Sort headers.
5047         * aarch64-linux-nat.c: Sort headers.
5048         * aarch64-fbsd-tdep.c: Sort headers.
5049         * aarch64-fbsd-nat.c: Sort headers.
5050         * aarch32-linux-nat.c: Sort headers.
5051
5052 2019-04-04  Tom Tromey  <tom@tromey.com>
5053
5054         * varobj.c (varobj_create): Update.
5055         * rust-exp.y (struct rust_parser) <update_innermost_block,
5056         lookup_symbol>: New methods.
5057         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5058         Rename.
5059         (rust_parser::rust_lookup_type)
5060         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5061         * printcmd.c (display_command, do_one_display): Update.
5062         * parser-defs.h (struct parser_state) <parser_state>: Add
5063         "tracker" parameter.
5064         (block_tracker): New member.
5065         (class innermost_block_tracker) <innermost_block_tracker>: Add
5066         "types" parameter.
5067         <reset>: Remove method.
5068         (innermost_block): Don't declare.
5069         (null_post_parser): Update.
5070         * parse.c (innermost_block): Remove global.
5071         (write_dollar_variable): Update.
5072         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5073         Remove "tracker_types" parameter.
5074         (parse_expression): Add "tracker" parameter.
5075         (parse_expression_for_completion): Update.
5076         (null_post_parser): Add "tracker" parameter.
5077         * p-exp.y: Update rules.
5078         * m2-exp.y: Update rules.
5079         * language.h (struct language_defn) <la_post_parser>: Add
5080         "tracker" parameter.
5081         * go-exp.y: Update rules.
5082         * f-exp.y: Update rules.
5083         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5084         parameter.
5085         * d-exp.y: Update rules.
5086         * c-exp.y: Update rules.
5087         * breakpoint.c (set_breakpoint_condition): Create an
5088         innermost_block_tracker.
5089         (watch_command_1): Likewise.
5090         * ada-lang.c (resolve): Add "tracker" parameter.
5091         (resolve_subexp): Likewise.
5092         * ada-exp.y (write_var_from_sym): Update.
5093
5094 2019-04-04  Tom Tromey  <tom@tromey.com>
5095
5096         * type-stack.h: New file.
5097         * type-stack.c: New file.
5098         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5099         type-stack.h.
5100         (insert_into_type_stack, insert_type, push_type, push_type_int)
5101         (insert_type_address_space, pop_type, pop_type_int)
5102         (pop_typelist, pop_type_stack, append_type_stack)
5103         (push_type_stack, get_type_stack, push_typelist)
5104         (follow_type_instance_flags, follow_types): Don't declare.
5105         * parse.c (type_stack): Remove global.
5106         (parse_exp_in_context): Update.
5107         (insert_into_type_stack, insert_type, push_type, push_type_int)
5108         (insert_type_address_space, pop_type, pop_type_int)
5109         (pop_typelist, pop_type_stack, append_type_stack)
5110         (push_type_stack, get_type_stack, push_typelist)
5111         (follow_type_instance_flags, follow_types): Remove (moved to
5112         type-stack.c).
5113         * f-exp.y (type_stack): New global.
5114         Update rules.
5115         (push_kind_type, f_parse): Update.
5116         * d-exp.y (type_stack): New global.
5117         Update rules.
5118         (d_parse): Update.
5119         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5120         Update rules.
5121         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5122         (HFILES_NO_SRCDIR): Add type-stack.h.
5123
5124 2019-04-04  Tom Tromey  <tom@tromey.com>
5125
5126         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5127         (rust_parser::convert_ast_to_expression, rust_parse)
5128         (rust_lex_test_completion, rust_lex_tests): Update.
5129         * parser-defs.h (struct expr_completion_state): New.
5130         (struct parser_state) <parser_state>: Add completion parameter.
5131         <mark_struct_expression, mark_completion_tag>: New methods.
5132         <parse_completion, m_completion_state>: New members.
5133         (prefixify_expression, null_post_parser): Update.
5134         (mark_struct_expression, mark_completion_tag): Don't declare.
5135         * parse.c (parse_completion, expout_last_struct)
5136         (expout_tag_completion_type, expout_completion_name): Remove
5137         globals.
5138         (parser_state::mark_struct_expression)
5139         (parser_state::mark_completion_tag): Now methods.
5140         (prefixify_expression): Add last_struct parameter.
5141         (prefixify_subexp): Likewise.
5142         (parse_exp_1): Update.
5143         (parse_exp_in_context): Add cstate parameter.  Update.
5144         (parse_expression_for_completion): Create an
5145         expr_completion_state.
5146         (null_post_parser): Add "completion" parameter.
5147         * p-exp.y: Update rules.
5148         (yylex): Update.
5149         * language.h (struct language_defn) <la_post_parser>: Add
5150         "completing" parameter.
5151         * go-exp.y: Update rules.
5152         (lex_one_token): Update.
5153         * expression.h (parse_completion): Don't declare.
5154         * d-exp.y: Update rules.
5155         (lex_one_token): Update rules.
5156         * c-exp.y: Update rules.
5157         (lex_one_token): Update.
5158         * ada-lang.c (resolve): Add "parse_completion" parameter.
5159         (resolve_subexp): Likewise.
5160         (ada_resolve_function): Likewise.
5161
5162 2019-04-04  Tom Tromey  <tom@tromey.com>
5163
5164         * parser-defs.h (struct parser_state) <start_arglist,
5165         end_arglist>: New methods.
5166         <arglist_len, m_funcall_chain>: New members.
5167         (arglist_len, start_arglist, end_arglist): Don't declare.
5168         * parse.c (arglist_len, funcall_chain): Remove global.
5169         (start_arglist, end_arglist): Remove functions.
5170         (parse_exp_in_context): Update.
5171         * p-exp.y: Update rules.
5172         * m2-exp.y: Update rules.
5173         * go-exp.y: Update rules.
5174         * f-exp.y: Update rules.
5175         * d-exp.y: Update rules.
5176         * c-exp.y: Update rules.
5177
5178 2019-04-04  Tom Tromey  <tom@tromey.com>
5179
5180         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
5181         lex_operator, push_back>: New methods.
5182         Update all rules.
5183         (rust_parser::lex_hex, lex_escape): Rename and update.
5184         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
5185         (rust_parser::lex_operator): Rename and update.
5186         (rust_parser::lex_number, rustyylex, rustyyerror)
5187         (rust_lex_test_init, rust_lex_test_sequence)
5188         (rust_lex_test_push_back, rust_lex_tests): Update.
5189         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
5190         parameter.
5191         <lexptr, prev_lexptr>: New members.
5192         (lexptr, prev_lexptr): Don't declare.
5193         * parse.c (lexptr, prev_lexptr): Remove globals.
5194         (parse_exp_in_context): Update.
5195         * p-exp.y (yylex, yyerror): Update.
5196         * m2-exp.y (parse_number, yylex, yyerror): Update.
5197         * go-exp.y (lex_one_token, yyerror): Update.
5198         * f-exp.y (match_string_literal, yylex, yyerror): Update.
5199         * d-exp.y (lex_one_token, yyerror): Update.
5200         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
5201         (lex_one_token, yyerror): Update.
5202         * ada-lex.l (YY_INPUT): Update.
5203         (rewind_to_char): Update.
5204         * ada-exp.y (yyerror): Update.
5205
5206 2019-04-04  Tom Tromey  <tom@tromey.com>
5207
5208         * rust-exp.y (rustyylex, rust_lex_tests): Update.
5209         * parser-defs.h (struct parser_state) <parser_state>: Add new
5210         parameter.
5211         <comma_terminates>: New member.
5212         (comma_terminates): Don't declare global.
5213         * parse.c (comma_terminates): Remove global.
5214         (parse_exp_in_context): Update.
5215         * p-exp.y (yylex): Update.
5216         * m2-exp.y (yylex): Update.
5217         * go-exp.y (lex_one_token): Update.
5218         * f-exp.y (yylex): Update.
5219         * d-exp.y (lex_one_token): Update.
5220         * c-exp.y (lex_one_token): Update.
5221         * ada-lex.l: Update.
5222
5223 2019-04-04  Tom Tromey  <tom@tromey.com>
5224
5225         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
5226         (rustyylex, rust_lex_test_init, rust_lex_test_one)
5227         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
5228         * parser-defs.h (paren_depth): Don't declare.
5229         * parse.c (paren_depth): Remove global.
5230         (parse_exp_in_context): Update.
5231         * p-exp.y (paren_depth): New global.
5232         (pascal_parse): Initialize it.
5233         * m2-exp.y (paren_depth): New global.
5234         (m2_parse): Initialize it.
5235         * go-exp.y (paren_depth): New global.
5236         (go_parse): Initialize it.
5237         * f-exp.y (paren_depth): New global.
5238         (f_parse): Initialize it.
5239         * d-exp.y (paren_depth): New global.
5240         (d_parse): Initialize it.
5241         * c-exp.y (paren_depth): New global.
5242         (c_parse): Initialize it.
5243         * ada-lex.l (paren_depth): New global.
5244         (lexer_init): Initialize it.
5245
5246 2019-04-04  Tom Tromey  <tom@tromey.com>
5247
5248         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
5249         (rust_parser::convert_ast_to_type)
5250         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5251         * parser-defs.h (struct parser_state) <parser_state>: Add
5252         parameters.  Initialize new members.
5253         <expression_context_block, expression_context_pc>: New members.
5254         * parse.c (expression_context_block, expression_context_pc):
5255         Remove globals.
5256         (parse_exp_in_context): Update.
5257         * p-exp.y: Update all rules.
5258         (yylex): Update.
5259         * m2-exp.y: Update all rules.
5260         (yylex): Update.
5261         * go-exp.y (yylex): Update.
5262         * f-exp.y (yylex): Update.
5263         * d-exp.y: Update all rules.
5264         (yylex): Update.
5265         * c-exp.y: Update all rules.
5266         (lex_one_token, classify_name, yylex, c_parse): Update.
5267         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
5268
5269 2019-04-04  Tom Tromey  <tom@tromey.com>
5270
5271         * gdbarch.h, gdbarch.c: Rebuild.
5272         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
5273         * stap-probe.h:
5274         (struct stap_parse_info): Replace "parser_state" with
5275         "expr_builder".
5276         * parser-defs.h (struct expr_builder): Rename from "parser_state".
5277         (parser_state): New class.
5278         * parse.c (expr_builder): Rename.
5279         (expr_builder::release): Rename.
5280         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
5281         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
5282         (write_exp_elt_longcst, write_exp_elt_floatcst)
5283         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
5284         (write_exp_string_vector, write_exp_bitstring)
5285         (write_exp_msymbol, mark_struct_expression)
5286         (write_dollar_variable)
5287         (insert_type_address_space, increase_expout_size): Replace
5288         "parser_state" with "expr_builder".
5289         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
5290         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
5291         "parser_state" with "expr_builder".
5292
5293 2019-04-04  Tom Tromey  <tom@tromey.com>
5294
5295         * rust-exp.y: Replace "parse_language" with method call.
5296         * p-exp.y:
5297         (yylex): Replace "parse_language" with method call.
5298         * m2-exp.y:
5299         (yylex): Replace "parse_language" with method call.
5300         * go-exp.y (classify_name): Replace "parse_language" with method
5301         call.
5302         * f-exp.y (yylex): Replace "parse_language" with method call.
5303         * d-exp.y (lex_one_token): Replace "parse_language" with method
5304         call.
5305         * c-exp.y:
5306         (lex_one_token, classify_name, yylex): Replace "parse_language"
5307         with method call.
5308         * ada-exp.y (find_primitive_type, type_char)
5309         (type_system_address): Replace "parse_language" with method call.
5310
5311 2019-04-04  Tom Tromey  <tom@tromey.com>
5312
5313         * rust-exp.y: Replace "parse_gdbarch" with method call.
5314         * parse.c (write_dollar_variable, insert_type_address_space):
5315         Replace "parse_gdbarch" with method call.
5316         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
5317         call.
5318         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
5319         call.
5320         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
5321         "parse_gdbarch" with method call.
5322         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
5323         with method call.
5324         * f-exp.y (parse_type, parse_f_type, yylex): Replace
5325         "parse_gdbarch" with method call.
5326         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
5327         "parse_gdbarch" with method call.
5328         * c-exp.y (parse_type, parse_number, classify_name): Replace
5329         "parse_gdbarch" with method call.
5330         * ada-lex.l: Replace "parse_gdbarch" with method call.
5331         * ada-exp.y (parse_type, find_primitive_type, type_char)
5332         (type_system_address): Replace "parse_gdbarch" with method call.
5333
5334 2019-04-04  Tom Tromey  <tom@tromey.com>
5335
5336         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
5337         * stap-probe.c (stap_parse_argument): Update.
5338         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
5339         initial_size parameter.
5340         * rust-exp.y (rust_lex_tests): Update.
5341         * parse.c (parser_state): Update.
5342         (parse_exp_in_context): Update.
5343         * parser-defs.h (struct parser_state) <parser_state>: Remove
5344         "initial_size" parameter.
5345
5346 2019-04-04  Tom Tromey  <tom@tromey.com>
5347
5348         * parser-defs.h (increase_expout_size): Don't declare.
5349         * parse.c (increase_expout_size): Now static.
5350
5351 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
5352
5353         * gnu-nat.c (gnu_nat_target::wait): Fix
5354         target_waitstatus_to_string call.
5355
5356 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5357
5358         * eval.c (evaluate_subexp_standard): Handle internal functions
5359         during Fortran function call handling.
5360
5361 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5362
5363         * NEWS: Mention new internal functions.
5364         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
5365         (read_base_type): Use dwarf2_init_complex_target_type.
5366         * value.c (creal_internal_fn): New function.
5367         (cimag_internal_fn): New function.
5368         (_initialize_values): Register new internal functions.
5369
5370 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5371
5372         * infrun.c (stop_all_threads): If debug_infrun, always
5373         trace the wait status after wait_one, using
5374         target_waitstatus_to_string and target_pid_to_str.
5375         (handle_inferior_event): Replace various trace of
5376         wait status kind by a single trace.
5377         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
5378         wait status kind image by target_waitstatus_to_string.
5379         * target/waitstatus.c (target_waitstatus_to_string): Fix
5380         obsolete comment.
5381
5382 2019-04-01  Tom Tromey  <tromey@adacore.com>
5383
5384         PR symtab/23331:
5385         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
5386
5387 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5388             Pedro Alves  <palves@redhat.com>
5389
5390         * top.c (quit_force): Call 'finalize_values'.
5391         * value.c (finalize_values): New function.
5392         * value.h (finalize_values): Declare.
5393
5394 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
5395
5396         * NEWS: Announce $_gdb_major and $_gdb_minor.
5397
5398         * top.c (init_gdb_version_vars): New function.
5399         (gdb_init): Call init_gdb_version_vars.
5400
5401 2019-03-29  Tom Tromey  <tromey@adacore.com>
5402
5403         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
5404         help text.  Remove dead code.
5405
5406 2019-03-29  Keith Seitz  <keiths@redhat.com>
5407
5408         From Siddhesh Poyarekar:
5409         * f-lang.h (f77_get_upperbound): Return LONGEST.
5410         (f77_get_lowerbound): Likewise.
5411         * f-typeprint.c (f_type_print_varspec_suffix): Expand
5412         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
5413         print them.
5414         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
5415         plongest to format print it.
5416         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
5417         (f77_get_upperbound): Likewise.
5418         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
5419         LOWER_BOUND to LONGEST.
5420         (f77_create_arrayprint_offset_tbl): Likewise.
5421
5422 2019-03-29  Keith Seitz  <keiths@redhat.com>
5423
5424         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
5425         %s/pulongest for TYPE_LENGTH instead of %d in format
5426         strings.
5427         * ada-typerint.c (ada_print_type): Likewise.
5428         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
5429         * compile/compile-c-support.c (generate_register_struct): Likewise.
5430         * gdbtypes.c (recursive_dump_type): Likewise.
5431         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
5432         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
5433         instead of %d in format strings.
5434         * riscv-tdep.c (riscv_type_alignment): Cast second argument
5435         to std::min to ULONGEST.
5436         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
5437         instead of %d in format strings.
5438         * tracepoint.c (info_scope_command): Likewise.
5439         * typeprint.c (print_offset_data::update)
5440         (print_offset_data::finish): Likewise.
5441         * xtensa-tdep.c (xtensa_store_return_value)
5442         (xtensa_push_dummy_call): Likewise.
5443
5444 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
5445
5446         * windows-nat.c (display_selector): Fixed format specifications
5447         for 64-bit Cygwin.
5448
5449 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5450
5451         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
5452
5453 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
5454
5455         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
5456         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
5457         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
5458         (nios2_linux_init_abi): Install it.
5459
5460 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5461
5462         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
5463
5464 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5465
5466         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
5467
5468 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5469             Tom Tromey  <tromey@adacore.com>
5470
5471         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
5472
5473 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
5474
5475         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
5476         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
5477         method to compute the bounds of range types. Also print "[evaluated]"
5478         if the bounds' values come from a dynamic evaluation.
5479
5480 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5481
5482         * cp-valprint.c (cp_print_value_fields): Don't print trailing
5483         whitespace when pretty printing is on.
5484
5485 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5486
5487         * ppc-linux-nat.c: Add include.
5488
5489 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5490
5491         * NEWS: Mention AArch64 Pointer Authentication.
5492
5493 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5494
5495         * arm-linux-nat.c: Add include.
5496
5497 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
5498
5499         * source-cache.c (source_cache::get_source_lines): Re-read
5500         fullname after calling open_source_file.
5501
5502 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
5503
5504         * NEWS: Mention TLS support for FreeBSD.
5505
5506 2019-03-25  Tom Tromey  <tromey@adacore.com>
5507
5508         * minsyms.c (BUNCH_SIZE): Update comment.
5509         (~minimal_symbol_reader): Remove old comment.
5510         (compact_minimal_symbols): Update comment.
5511         (minimal_symbol_reader::install): Remove old comment.  Update
5512         other comments.
5513
5514 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5515
5516         * s390-linux-nat.c: Add include.
5517
5518 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5519
5520         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5521         Call linux_get_hwcap.
5522         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
5523         Likewise.
5524         (aarch64_linux_get_hwcap): Remove function.
5525         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
5526         declaration.
5527         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
5528         linux_get_hwcap.
5529         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5530         * linux-tdep.c (linux_get_hwcap): Add function.
5531         (linux_get_hwcap2): Likewise.
5532         * linux-tdep.h (linux_get_hwcap): Add declaration.
5533         (linux_get_hwcap2): Likewise.
5534         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
5535         (ppc_linux_get_hwcap2): Likewise.
5536         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
5537         linux_get_hwcap.
5538         (ppc_linux_nat_target::insert_watchpoint): Likewise.
5539         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
5540         (ppc_linux_nat_target::read_description): Likewise.
5541         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
5542         * s390-linux-nat.c: Likewise.
5543         * s390-linux-tdep.c (s390_core_read_description): Likewise.
5544
5545 2019-03-24  Tom Tromey  <tom@tromey.com>
5546
5547         * ada-lang.c (standard_lookup): Simplify initialization.
5548         (ada_lookup_symbol_nonlocal): Simplify return.
5549         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
5550         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
5551         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
5552         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
5553         initialization.
5554         * solib.c (solib_global_lookup): Simplify.
5555         * symtab.c (null_block_symbol): Remove.
5556         (symbol_cache_lookup): Simplify returns.
5557         (lookup_language_this): Simplify returns.
5558         (lookup_symbol_aux): Simplify return.
5559         (lookup_local_symbol): Simplify returns.
5560         (lookup_global_symbol_from_objfile): Simplify return.
5561         (lookup_symbol_in_objfile_symtabs)
5562         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
5563         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
5564         (lookup_static_symbol, lookup_global_symbol): Simplify return.
5565         * cp-namespace.c (cp_lookup_bare_symbol)
5566         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
5567         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
5568         (cp_lookup_nested_symbol): Don't use null_block_symbol.
5569         (cp_lookup_symbol_via_imports): Simplify initialization.
5570         (find_symbol_in_baseclass): Likewise.
5571         * symtab.h (null_block_symbol): Remove.
5572         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
5573         (d_lookup_nested_symbol, d_lookup_symbol_imports)
5574         (d_lookup_symbol_module): Likewise.
5575         (find_symbol_in_baseclass): Simplify initialization.
5576
5577 2019-03-24  Tom Tromey  <tom@tromey.com>
5578
5579         * expression.h: Don't include symtab.h.
5580         (struct block): Forward declare.
5581
5582 2019-03-24  Tom Tromey  <tom@tromey.com>
5583
5584         * c-exp.y (typebase): Remove casts.
5585         * gdbtypes.c (lookup_unsigned_typename, )
5586         (lookup_signed_typename): Remove cast.
5587         * eval.c (parse_to_comma_and_eval): Remove cast.
5588         * parse.c (write_dollar_variable): Remove cast.
5589         * block.h (struct block) <superblock>: Now const.
5590         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
5591         * psymtab.c (psym_map_matching_symbols): Make "block" const.
5592         (map_block): Make "block" const.
5593         * symfile.h (struct quick_symbol_functions)
5594         <map_matching_symbols>: Constify block argument to "callback".
5595         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
5596         const.
5597         (find_pc_sect_compunit_symtab): Make "b" const.
5598         (find_symbol_at_address): Likewise.
5599         (search_symbols): Likewise.
5600         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
5601         (dw2_debug_names_lookup_symbol): Likewise.
5602         (dw2_map_matching_symbols): Update.
5603         * p-valprint.c (pascal_val_print): Remove "block".
5604         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
5605         (aux_add_nonlocal_symbols): Make "block" const.
5606         (resolve_subexp): Remove cast.
5607         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
5608         const.
5609         (iterate_over_file_blocks): Likewise.
5610         * f-exp.y (%union) <bval>: Remove.
5611         * coffread.c (patch_opaque_types): Make "b" const.
5612         * spu-tdep.c (spu_catch_start): Make "block" const.
5613         * c-valprint.c (print_unpacked_pointer): Remove "block".
5614         * symmisc.c (dump_symtab_1): Make "b" const.
5615         (block_depth): Make "block" const.
5616         * d-exp.y (%union) <bval>: Remove.
5617         * cp-support.h (cp_lookup_rtti_type): Update.
5618         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
5619         * psymtab.c (psym_lookup_symbol): Make "block" const.
5620         (maintenance_check_psymtabs): Make "b" const.
5621         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
5622         (enumerate_locals, enumerate_args): Update.
5623         * python/py-symtab.c (stpy_global_block): Make "block" const.
5624         (stpy_static_block): Likewise.
5625         * inline-frame.c (block_starting_point_at): Make "new_block"
5626         const.
5627         * block.c (find_block_in_blockvector): Make return type const.
5628         (blockvector_for_pc_sect): Make "b" const.
5629         (find_block_in_blockvector): Make "b" const.
5630
5631 2019-03-23  Tom Tromey  <tom@tromey.com>
5632
5633         * varobj.c (varobj_create): Update.
5634         * symfile.c (clear_symtab_users): Don't reset innermost_block.
5635         * printcmd.c (display_command, do_one_display): Don't reset
5636         innermost_block.
5637         * parser-defs.h (enum innermost_block_tracker_type): Move to
5638         expression.h.
5639         (innermost_block): Update comment.
5640         * parse.c (parse_exp_1): Add tracker_types parameter.
5641         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
5642         tracker_types parameter.  Reset innermost_block.
5643         (parse_exp_in_context): Remove.
5644         (parse_expression_for_completion): Update.
5645         * objfiles.c (~objfile): Don't reset expression_context_block or
5646         innermost_block.
5647         * expression.h (enum innermost_block_tracker_type): Move from
5648         parser-defs.h.
5649         (parse_exp_1): Add tracker_types parameter.
5650         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
5651         reset innermost_block.
5652
5653 2019-03-23  Tom Tromey  <tom@tromey.com>
5654
5655         * objfiles.h: Include bcache.h.
5656
5657 2019-03-23  Tom Tromey  <tom@tromey.com>
5658
5659         * linespec.c (get_current_search_block): Use
5660         scoped_restore_current_language.
5661         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
5662
5663 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5664             Jiong Wang  <jiong.wang@arm.com>
5665
5666         * aarch64-linux-tdep.c
5667         (aarch64_linux_iterate_over_regset_sections): Check for pauth
5668         section.
5669         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
5670
5671 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5672             Jiong Wang  <jiong.wang@arm.com>
5673
5674         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
5675         instructions.
5676         (aarch64_analyze_prologue_test): Add PACIASP test.
5677         (aarch64_prologue_prev_register): Unmask PC value.
5678
5679 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5680             Jiong Wang  <jiong.wang@arm.com>
5681
5682         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
5683         (aarch64_dwarf2_prev_register): Unmask PC value.
5684         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
5685         (aarch64_execute_dwarf_cfa_vendor_op): Check for
5686         DW_CFA_AARCH64_negate_ra_state.
5687         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
5688
5689 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5690             Jiong Wang  <jiong.wang@arm.com>
5691
5692         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
5693         registers.
5694         (aarch64_pseudo_register_name): Likewise.
5695         (aarch64_pseudo_register_type): Likewise.
5696         (aarch64_pseudo_register_reggroup_p): Likewise.
5697         (aarch64_gdbarch_init): Add pauth registers.
5698         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
5699         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
5700         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
5701         (struct gdbarch_tdep): Add regnum for ra_state.
5702
5703 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5704             Jiong Wang  <jiong.wang@arm.com>
5705
5706         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
5707
5708 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5709             Jiong Wang  <jiong.wang@arm.com>
5710
5711         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
5712         function.
5713         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
5714         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
5715         (aarch64_gdbarch_init): Add puth registers.
5716         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
5717         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
5718         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
5719
5720 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5721             Jiong Wang  <jiong.wang@arm.com>
5722
5723         * aarch64-linux-nat.c
5724         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
5725         * aarch64-linux-tdep.c
5726         (aarch64_linux_core_read_description): Likewise.
5727         (aarch64_linux_get_hwcap): New function.
5728         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
5729         (aarch64_linux_get_hwcap): New declaration.
5730
5731 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5732             Jiong Wang  <jiong.wang@arm.com>
5733
5734         * aarch64-linux-nat.c
5735         (aarch64_linux_nat_target::read_description): Add pauth param.
5736         * aarch64-linux-tdep.c
5737         (aarch64_linux_core_read_description): Likewise.
5738         * aarch64-tdep.c (struct target_desc): Add in pauth.
5739         (aarch64_read_description): Add pauth param.
5740         (aarch64_gdbarch_init): Likewise.
5741         * aarch64-tdep.h (aarch64_read_description): Likewise.
5742         * arch/aarch64.c (aarch64_create_target_description): Likewise.
5743         * arch/aarch64.h (aarch64_create_target_description): Likewise.
5744         * features/Makefile: Add new files.
5745         * features/aarch64-pauth.c: New file.
5746         * features/aarch64-pauth.xml: New file.
5747
5748 2019-03-20  Tom Tromey  <tromey@adacore.com>
5749
5750         * infrun.c (handle_inferior_event): Rename from
5751         handle_inferior_event_1.  Create a scoped_value_mark.
5752         (handle_inferior_event): Remove.
5753
5754 2019-03-19  Tom Tromey  <tromey@adacore.com>
5755
5756         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
5757         * infrun.h (print_stop_event): Add "displays" parameter.
5758         * infrun.c (print_stop_event): Add "displays" parameter.
5759
5760 2019-03-19  Pedro Alves  <palves@redhat.com>
5761
5762         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
5763         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
5764         to -1.  Fix TABs vs spaces.
5765         (tui_ui_out::tui_ui_out): Don't initialize fields here.
5766         * tui/tui-out.h (tui_ui_out) Add intro comments.
5767         <m_line, m_start_of_line>: In-class initialize, and add describing
5768         comment.
5769
5770 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
5771
5772         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
5773         variable names.
5774         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
5775
5776 2019-03-18  Pedro Alves  <palves@redhat.com>
5777             Eli Zaretskii <eliz@gnu.org>
5778
5779         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
5780         m_line and m_start_of_line.
5781
5782 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
5783
5784         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
5785         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
5786         it returns a newline.  This fixes a regression in TU mode, whereby
5787         the next line is output on the same screen line as the user input.
5788
5789 2019-03-18  Tom Tromey  <tromey@adacore.com>
5790
5791         * minsyms.c (minimal_symbol_reader::install): Remove call to
5792         obstack_blank.
5793
5794 2019-03-18  Pedro Alves  <palves@redhat.com>
5795
5796         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
5797         New globals.
5798         (apply_style): New, factored out from ...
5799         (apply_ansi_escape): ... this.  Handle reverse video mode.
5800         (tui_set_reverse_mode): New function.
5801         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
5802         * tui/tui-winsource.c (tui_show_source_line): Use
5803         tui_set_reverse_mode instead of setting A_STANDOUT.
5804         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
5805         New setter methods.
5806
5807 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
5808
5809         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
5810         Handle tabs.
5811
5812 2019-03-18  Tom Tromey  <tromey@adacore.com>
5813
5814         * ada-lang.c (empty_array): Add "high" parameter.
5815         (ada_evaluate_subexp): Update.
5816
5817 2019-03-17  Sergei Trofimovich <siarheit@google.com>
5818
5819         * unittests/string_view-selftests.c: Define
5820         _initialize_string_view_selftests unconditionally.
5821
5822 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5823
5824         PR gdb/24350
5825         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
5826
5827 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5828
5829         PR gdb/24351
5830         * windows-nat.c (display_selector): Fix format specifiers.
5831
5832 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
5833
5834         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
5835         tui_refill_source_window instead of tui_refresh_win, to update the
5836         current execution line.  This fixes redisplay of the current line
5837         when stepping through the code with "next" or "step".
5838
5839 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5840
5841         * source-cache.c (source_cache::get_source_lines): Call
5842         find_source_lines to initialize s->nlines.  This fixes vertical
5843         scrolling of TUI source window when the DOWN arrow is pressed.
5844
5845 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5846
5847         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
5848         linux-thread-db.c (_initialize_thread_db): Likewise.
5849
5850 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5851
5852         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
5853         wclrtoeol in tui_show_source_line".  This reverts changes made in
5854         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
5855
5856 2019-03-15  Tom Tromey  <tom@tromey.com>
5857
5858         * symtab.h (struct minimal_symbol): Derive from
5859         general_symbol_info.
5860         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
5861         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
5862         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
5863         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
5864         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
5865         (MSYMBOL_SEARCH_NAME): Update.
5866         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
5867         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
5868         * minsyms.c (minimal_symbol_reader::record_full): Update.
5869
5870 2019-03-15  Tom Tromey  <tom@tromey.com>
5871
5872         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
5873
5874 2019-03-15  Tom Tromey  <tom@tromey.com>
5875
5876         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
5877         unique_xmalloc_ptr.
5878         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
5879         Update.
5880         * minsyms.c (lookup_minimal_symbol_by_pc_section)
5881         (build_minimal_symbol_hash_tables)
5882         (minimal_symbol_reader::install): Update.
5883
5884 2019-03-15  Tom Tromey  <tom@tromey.com>
5885
5886         * symtab.c (create_demangled_names_hash): Update.
5887         (symbol_set_names): Update.
5888         * objfiles.h (struct objfile_per_bfd_storage)
5889         <demangled_names_hash>: Now an htab_up.
5890         * objfiles.c (objfile_per_bfd_storage): Simplify.
5891
5892 2019-03-15  Tom Tromey  <tom@tromey.com>
5893
5894         * objfiles.h (struct objfile_per_bfd_storage): Declare
5895         destructor.
5896         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
5897         New.
5898         (get_objfile_bfd_data): Use new.  Don't initialize
5899         language_of_main.
5900         (free_objfile_per_bfd_storage): Remove.
5901         (objfile_bfd_data_free, objfile::~objfile): Use delete.
5902
5903 2019-03-15  Tom Tromey  <tom@tromey.com>
5904
5905         * symfile.c (reread_symbols): Update.
5906         * objfiles.c (objfile::objfile): Update.
5907         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
5908         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
5909         comment.
5910         (minimal_symbol_reader::install): Update.
5911         (terminate_minimal_symbol_table): Remove.
5912         * jit.c (jit_object_close_impl): Update.
5913
5914 2019-03-15  Tom Tromey  <tom@tromey.com>
5915
5916         * minsyms.c (minimal_symbol_reader::record_full): Remove some
5917         initializations.
5918
5919 2019-03-15  Tom Tromey  <tom@tromey.com>
5920
5921         * objfiles.h (struct objfile_per_bfd_storage)
5922         <demangled_hash_languages>: Now a bitset.
5923         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
5924         (lookup_minimal_symbol): Update.
5925
5926 2019-03-15  Tom Tromey  <tom@tromey.com>
5927
5928         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
5929         Don't return the symbol.
5930         * coffread.c (record_minimal_symbol): Use record_full.
5931
5932 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
5933
5934         The MS-Windows port of ncurses fails to switch to a color pair if
5935         one or both of the colors are the implicit default colors.  This
5936         change records the default colors when TUI is initialized, and
5937         then specifies them explicitly when a color pair uses the default
5938         colors.  This allows color styling in TUI mode on MS-Windows.
5939
5940         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
5941         ncurses_norm_attr.
5942         (tui_initialize_io) [__MINGW32__]: Record the default terminal
5943         colors in ncurses_norm_attr.
5944         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
5945         "none", replace it with the default color recorded in
5946         ncurses_norm_attr.
5947
5948 2019-03-14  Tom Tromey  <tromey@adacore.com>
5949
5950         * source-cache.h (class source_cache) <get_source_lines>: Return
5951         std::string.
5952         * source-cache.c (source_cache::extract_lines): Handle case where
5953         first_pos==npos.  Return std::string.
5954         (source_cache::get_source_lines): Update.
5955
5956 2019-03-14  Tom Tromey  <tromey@adacore.com>
5957
5958         * NEWS: Add item for "style sources" commands.
5959         * source-cache.c (source_cache::get_source_lines): Check
5960         source_styling.
5961         * cli/cli-style.c (source_styling): New global.
5962         (_initialize_cli_style): Add "style sources" commands.
5963         (show_style_sources): New function.
5964         * cli/cli-style.h (source_styling): Declare.
5965
5966 2019-03-14  Pedro Alves  <palves@redhat.com>
5967             Tom Tromey  <tromey@adacore.com>
5968
5969         * tui/tui-winsource.h (tui_refill_source_window): Declare.
5970         * tui/tui-winsource.c (tui_refill_source_window): New function,
5971         from...
5972         (tui_horizontal_source_scroll): ... here.  Move some logic.
5973         * cli/cli-style.c (set_style_enabled): Notify new observable.
5974         * tui/tui-hooks.c (tui_redisplay_source): New function.
5975         (tui_attach_detach_observers): Attach or detach
5976         tui_redisplay_source.
5977         * observable.h (source_styling_changed): New observable.
5978         * observable.c: Define source_styling_changed observable.
5979
5980 2019-03-13  Tom Tromey  <tromey@adacore.com>
5981
5982         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
5983         (i386_gnu_nat_target::store_registers): Update.
5984         * target-debug.h (target_debug_print_std_string): New macro.
5985         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5986         * windows-tdep.c (display_one_tib): Update.
5987         * tui/tui-stack.c (tui_make_status_line): Update.
5988         * top.c (print_inferior_quit_action): Update.
5989         * thread.c (thr_try_catch_cmd): Update.
5990         (add_thread_with_info): Update.
5991         (thread_target_id_str): Update.
5992         (thr_try_catch_cmd): Update.
5993         (thread_command): Update.
5994         (thread_find_command): Update.
5995         * record-btrace.c (record_btrace_target::info_record)
5996         (record_btrace_resume_thread, record_btrace_target::resume)
5997         (record_btrace_cancel_resume, record_btrace_step_thread)
5998         (record_btrace_target::wait, record_btrace_target::wait)
5999         (record_btrace_target::wait, record_btrace_target::stop): Update.
6000         * progspace.c (print_program_space): Update.
6001         * process-stratum-target.c
6002         (process_stratum_target::thread_address_space): Update.
6003         * linux-fork.c (linux_fork_mourn_inferior)
6004         (detach_checkpoint_command, info_checkpoints_command)
6005         (linux_fork_context): Update.
6006         (linux_fork_detach): Update.
6007         (class scoped_switch_fork_info): Update.
6008         (delete_checkpoint_command): Update.
6009         * infrun.c (follow_fork_inferior): Update.
6010         (follow_fork_inferior): Update.
6011         (proceed_after_vfork_done): Update.
6012         (handle_vfork_child_exec_or_exit): Update.
6013         (follow_exec): Update.
6014         (displaced_step_prepare_throw): Update.
6015         (displaced_step_restore): Update.
6016         (start_step_over): Update.
6017         (resume_1): Update.
6018         (clear_proceed_status_thread): Update.
6019         (proceed): Update.
6020         (print_target_wait_results): Update.
6021         (do_target_wait): Update.
6022         (context_switch): Update.
6023         (stop_all_threads): Update.
6024         (restart_threads): Update.
6025         (finish_step_over): Update.
6026         (handle_signal_stop): Update.
6027         (switch_back_to_stepped_thread): Update.
6028         (keep_going_pass_signal): Update.
6029         (print_exited_reason): Update.
6030         (normal_stop): Update.
6031         * inferior.c (inferior_pid_to_str): Change return type.
6032         (print_selected_inferior): Update.
6033         (add_inferior): Update.
6034         (detach_inferior): Update.
6035         * dummy-frame.c (fprint_dummy_frames): Update.
6036         * dcache.c (dcache_info_1): Update.
6037         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6038         (btrace_fetch, btrace_clear): Update.
6039         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6040         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6041         type.
6042         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6043         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6044         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6045         * gdbarch.c, gdbarch.h: Rebuild.
6046         * gdbarch.sh (core_pid_to_str): Change return type.
6047         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6048         return type.
6049         (windows_nat_target::pid_to_str): Change return type.
6050         (windows_delete_thread): Update.
6051         (windows_nat_target::attach): Update.
6052         (windows_nat_target::files_info): Update.
6053         * target-delegates.c: Rebuild.
6054         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6055         return type.
6056         (sol_thread_target::pid_to_str): Change return type.
6057         * remote.c (class remote_target) <pid_to_str>: Change return
6058         type.
6059         (remote_target::pid_to_str): Change return type.
6060         (extended_remote_target::attach, remote_target::remote_stop_ns)
6061         (remote_target::remote_notif_remove_queued_reply)
6062         (remote_target::push_stop_reply, remote_target::disable_btrace):
6063         Update.
6064         (extended_remote_target::attach): Update.
6065         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6066         type.
6067         (gdbsim_target::pid_to_str): Change return type.
6068         * ravenscar-thread.c (struct ravenscar_thread_target)
6069         <pid_to_str>: Change return type.
6070         (ravenscar_thread_target::pid_to_str): Change return type.
6071         * procfs.c (class procfs_target) <pid_to_str>: Change return
6072         type.
6073         (procfs_target::pid_to_str): Change return type.
6074         (procfs_target::attach): Update.
6075         (procfs_target::detach): Update.
6076         (procfs_target::fetch_registers): Update.
6077         (procfs_target::store_registers): Update.
6078         (procfs_target::wait): Update.
6079         (procfs_target::files_info): Update.
6080         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6081         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6082         return type.
6083         (nto_procfs_target::pid_to_str): Change return type.
6084         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6085         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6086         return type.
6087         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6088         (exit_lwp): Update.
6089         (attach_proc_task_lwp_callback, get_detach_signal)
6090         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6091         (linux_nat_target::resume, wait_lwp, stop_callback)
6092         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6093         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6094         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6095         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6096         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6097         type.
6098         (inf_ptrace_target::attach): Update.
6099         (inf_ptrace_target::files_info): Update.
6100         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6101         type.
6102         (go32_nat_target::pid_to_str): Change return type.
6103         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6104         (gnu_nat_target::wait): Update.
6105         (gnu_nat_target::wait): Update.
6106         (gnu_nat_target::resume): Update.
6107         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6108         (fbsd_nat_target::wait): Update.
6109         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6110         type.
6111         (darwin_nat_target::attach): Update.
6112         * corelow.c (class core_target) <pid_to_str>: Change return type.
6113         (core_target::pid_to_str): Change return type.
6114         * target.c (normal_pid_to_str): Change return type.
6115         (default_pid_to_str): Likewise.
6116         (target_pid_to_str): Change return type.
6117         (target_translate_tls_address): Update.
6118         (target_announce_detach): Update.
6119         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6120         return type.
6121         (bsd_uthread_target::pid_to_str): Change return type.
6122         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6123         type.
6124         (bsd_kvm_target::pid_to_str): Change return type.
6125         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6126         return type.
6127         (aix_thread_target::pid_to_str): Change return type.
6128         * target.h (struct target_ops) <pid_to_str>: Change return type.
6129         (target_pid_to_str, normal_pid_to_str): Likewise.
6130         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6131         type.
6132         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6133         type.
6134         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6135         return type.
6136         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6137         type.
6138         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6139         type.
6140         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6141         return type.
6142
6143 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6144
6145         * NEWS: Mention that the new default MI version is 3.  Mention
6146         changes to the output of commands and events that deal with
6147         multi-location breakpoints.
6148         * breakpoint.c: Include "mi/mi-out.h".
6149         (print_one_breakpoint): Change output syntax if using MI version
6150         >= 3.
6151         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6152         New.
6153         (mi_multi_location_breakpoint_output_fixed): New.
6154         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6155         (mi_cmd_fix_multi_location_breakpoint_output): New.
6156         (mi_multi_location_breakpoint_output_fixed): New.
6157         * mi/mi-cmds.c (mi_cmds): Register command
6158         -fix-multi-location-breakpoint-output.
6159         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6160         interpreter "mi".
6161
6162 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6163
6164         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6165         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6166         instantiate mi_ui_out based on interpreter name.
6167         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6168         * mi/mi-main.c (mi_load_progress): Likewise.
6169
6170 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6171
6172         * NEWS: Combine separate "New targets" sections for 8.3.
6173
6174 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6175
6176         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6177         (ppcfbsd_init_abi): Install gdbarch
6178         "fetch_tls_load_module_address" and "get_thread_local_address"
6179         methods.
6180
6181 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6182
6183         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
6184         (riscv_fbsd_init_abi): Install gdbarch
6185         "fetch_tls_load_module_address" and "get_thread_local_address"
6186         methods.
6187
6188 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6189
6190         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
6191         (i386fbsd_init_abi): Install gdbarch
6192         "fetch_tls_load_module_address" and "get_thread_local_address"
6193         methods.
6194
6195 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6196
6197         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
6198         (amd64fbsd_init_abi): Install gdbarch
6199         "fetch_tls_load_module_address" and "get_thread_local_address"
6200         methods.
6201
6202 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6203
6204         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
6205         (struct fbsd_pspace_data): New type.
6206         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
6207         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
6208         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
6209         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
6210         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
6211
6212 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6213
6214         * gdbtypes.c (lookup_struct_elt): New function.
6215         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
6216         * gdbtypes.h (struct struct_elt): New type.
6217         (lookup_struct_elt): New prototype.
6218
6219 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6220
6221         * gdbtypes.c (lookup_struct_elt_type): Update comment and
6222         remove disabled code block.
6223
6224 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6225
6226         * gdbarch.sh (get_thread_local_address): New method.
6227         * gdbarch.h, gdbarch.c: Regenerate.
6228         * target.c (target_translate_tls_address): Use
6229         gdbarch_get_thread_local_address if present instead of
6230         target::get_thread_local_address.
6231
6232 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6233
6234         * target.h (target::get_thread_local_address): Update comment.
6235
6236 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6237
6238         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
6239         objfile->separate_debug_objfile_backlink if not NULL.
6240
6241 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6242
6243         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6244         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
6245         (amd64bsd_store_inferior_registers): Likewise.
6246         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6247         Enable segment base registers.
6248         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
6249         PT_GETFSBASE and PT_GETGSBASE.
6250         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
6251         PT_SETGSBASE.
6252         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
6253         segment base registers.
6254         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6255
6256 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6257
6258         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6259         Update calls to i386_target_description to add 'segments'
6260         parameter.
6261         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
6262         add segment base registers.
6263         * arch/i386.c (i386_create_target_description): Add 'segments'
6264         parameter to enable segment base registers.
6265         * arch/i386.h (i386_create_target_description): Likewise.
6266         * features/i386/32bit-segments.xml: New file.
6267         * features/i386/32bit-segments.c: Generate.
6268         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
6269         call to i386_target_description to add 'segments' parameter.
6270         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6271         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
6272         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
6273         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
6274         if feature is present.
6275         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
6276         Add 'segments' parameter to call to i386_target_description.
6277         (i386_target_description): Add 'segments' parameter to enable
6278         segment base registers.
6279         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
6280         to call to i386_target_description.
6281         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
6282         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
6283         Define I386_NUM_REGS.
6284         (i386_target_description): Add 'segments' parameter to enable
6285         segment base registers.
6286
6287 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
6288
6289         PR/24325
6290         * source-cache.c: #undef open and close, to avoid unresolved
6291         externals during linking.
6292
6293 2019-03-12  Tom Tromey  <tromey@adacore.com>
6294
6295         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
6296         const.  Add initializers.
6297         (_initialize_remote): Don't initialize ptid globals.
6298
6299 2019-03-12  Pedro Alves  <palves@redhat.com>
6300
6301         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
6302
6303 2019-03-12  Pedro Alves  <palves@redhat.com>
6304
6305         * cp-name-parser.y (main): Remove unused 'len' variable.
6306
6307 2019-03-12  Tom Tromey  <tromey@adacore.com>
6308
6309         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
6310         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
6311
6312 2019-03-12  Tom Tromey  <tromey@adacore.com>
6313
6314         * linux-nat.c (iterate_over_lwps): Update.
6315         (stop_callback): Remove parameter.
6316         (stop_wait_callback, detach_callback, resume_set_callback)
6317         (select_singlestep_lwp_callback, set_ignore_sigint)
6318         (status_callback, resumed_callback, resume_clear_callback)
6319         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
6320         data parameter.
6321         (linux_nat_target::detach, linux_nat_target::resume)
6322         (linux_stop_and_wait_all_lwps, select_event_lwp)
6323         (linux_nat_filter_event, linux_nat_wait_1)
6324         (linux_nat_target::kill, linux_nat_target::stop)
6325         (linux_nat_target::stop): Update.
6326         (linux_nat_resume_callback): Change type.
6327         (resume_stopped_resumed_lwps, count_events_callback)
6328         (select_event_lwp_callback): Likewise.
6329         (linux_stop_lwp, linux_nat_stop_lwp): Update.
6330         * arm-linux-nat.c (struct update_registers_data): Remove.
6331         (update_registers_callback): Change type.
6332         (arm_linux_insert_hw_breakpoint1): Update.
6333         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
6334         parameter.
6335         (x86_linux_dr_set_addr): Update.
6336         (x86_linux_dr_set_control): Update.
6337         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
6338         (iterate_over_lwps): Use gdb::function_view.
6339         * nat/aarch64-linux-hw-point.c (struct
6340         aarch64_dr_update_callback_param): Remove.
6341         (debug_reg_change_callback): Change type.
6342         (aarch64_notify_debug_reg_change): Update.
6343         * s390-linux-nat.c (s390_refresh_per_info): Update.
6344
6345 2019-03-11  Tom Tromey  <tromey@adacore.com>
6346
6347         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
6348         redundant assignment to "this_cu".
6349
6350 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6351
6352         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
6353
6354 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6355
6356         * gdbtypes.c (rank_one_type_parm_set): New function extracted
6357         from...
6358         (rank_one_type): ... this.
6359
6360 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6361
6362         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
6363         from...
6364         (rank_one_type): ... this.
6365
6366 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6367
6368         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
6369         from...
6370         (rank_one_type): ... this.
6371
6372 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6373
6374         * gdbtypes.c (rank_one_type_parm_float): New function extracted
6375         from...
6376         (rank_one_type): ... this.
6377
6378 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6379
6380         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
6381         from...
6382         (rank_one_type): ... this.
6383
6384 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6385
6386         * gdbtypes.c (rank_one_type_parm_range): New function extracted
6387         from...
6388         (rank_one_type): ... this.
6389
6390 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6391
6392         * gdbtypes.c (rank_one_type_parm_char): New function extracted
6393         from...
6394         (rank_one_type): ... this.
6395
6396 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6397
6398         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
6399         from...
6400         (rank_one_type): ... this.
6401
6402 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6403
6404         * gdbtypes.c (rank_one_type_parm_int): New function extracted
6405         from...
6406         (rank_one_type): ... this.
6407
6408 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6409
6410         * gdbtypes.c (rank_one_type_parm_func): New function extracted
6411         from...
6412         (rank_one_type): ... this.
6413
6414 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6415
6416         * gdbtypes.c (rank_one_type_parm_array): New function extracted
6417         from...
6418         (rank_one_type): ... this.
6419
6420 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6421
6422         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
6423         from...
6424         (rank_one_type): ... this.
6425
6426 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6427
6428         * inferior.c (initialize_inferiors): Ensure 'help set/show print
6429         inferior-events' shows the example events.
6430
6431 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
6432
6433         Support styling on native MS-Windows console
6434
6435         PR/24315
6436         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
6437         on MS-Windows if $TERM is not defined.
6438
6439         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
6440
6441         * posix-hdep.c (gdb_console_fputs):
6442         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
6443         functions.
6444         * ui-file.h (gdb_console_fputs): Add prototype.
6445
6446         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
6447         back to fputs only if the former returns zero.
6448
6449 2019-03-07  Tom Tromey  <tom@tromey.com>
6450
6451         * symmisc.c (print_symbol_bcache_statistics): Update.
6452         (print_objfile_statistics): Update.
6453         * symfile.c (allocate_symtab): Update.
6454         * stabsread.c: Don't include bcache.h.
6455         * psymtab.h (struct psymbol_bcache): Don't declare.
6456         (class psymtab_storage) <psymbol_cache>: Now a bcache.
6457         (psymbol_bcache_init, psymbol_bcache_free)
6458         (psymbol_bcache_get_bcache): Don't declare.
6459         * psymtab.c (struct psymbol_bcache): Remove.
6460         (psymtab_storage::psymtab_storage): Update.
6461         (psymtab_storage::~psymtab_storage): Update.
6462         (psymbol_bcache_init, psymbol_bcache_free)
6463         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
6464         (add_psymbol_to_bcache): Update.
6465         (allocate_psymtab): Update.
6466         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
6467         macro_cache>: No longer pointers.
6468         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
6469         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
6470         * macrotab.c (macro_bcache): Update.
6471         * macroexp.c: Don't include bcache.h.
6472         * gdbtypes.c (check_types_worklist): Update.
6473         (types_deeply_equal): Remove TRY/CATCH.  Update.
6474         * elfread.c (elf_symtab_read): Update.
6475         * dwarf2read.c: Don't include bcache.h.
6476         * buildsym.c (buildsym_compunit::get_macro_table): Update.
6477         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
6478         (print_bcache_statistics, bcache_memory_used): Don't declare.
6479         (struct bcache): Move from bcache.c.  Add constructor, destructor,
6480         methods.  Rename all data members.
6481         * bcache.c (struct bcache): Move to bcache.h.
6482         (bcache::expand_hash_table): Rename from expand_hash_table.
6483         (bcache): Remove.
6484         (bcache::insert): Rename from bcache_full.
6485         (bcache::compare): Rename from bcache_compare.
6486         (bcache_xmalloc): Remove.
6487         (bcache::~bcache): Rename from bcache_xfree.
6488         (bcache::print_statistics): Rename from print_bcache_statistics.
6489         (bcache::memory_used): Rename from bcache_memory_used.
6490
6491 2019-03-07  Pedro Alves  <palves@redhat.com>
6492
6493         * infrun.c (normal_stop): Also check for
6494         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
6495
6496 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
6497
6498         * f-lang.c (value_from_host_double): Moved to...
6499         * value.c (value_from_host_double): ...here.
6500         * value.h (value_from_host_double): Declare.
6501         * guile/scm-math.c (vlscm_convert_typed_number): Use
6502         value_from_host_double.
6503         (vlscm_convert_number): Likewise.
6504         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
6505         * python/py-value.c (convert_value_from_python): Likewise.
6506
6507 2019-03-06  Tom Tromey  <tom@tromey.com>
6508
6509         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
6510
6511 2019-03-06  Tom Tromey  <tom@tromey.com>
6512
6513         * utils.h (free_current_contents): Don't declare.
6514         * utils.c (free_current_contents): Remove.
6515
6516 2019-03-06  Tom Tromey  <tom@tromey.com>
6517
6518         * top.c (quit_force): Update.
6519         * main.c (captured_command_loop): Update.
6520         * common/new-op.c (operator new): Update.
6521         * common/common-exceptions.c (struct catcher)
6522         <save_cleanup_chain>: Remove member.
6523         (exceptions_state_mc_init): Update.
6524         (exception_try_scope_entry): Return nullptr.
6525         (exception_try_scope_exit, exception_rethrow)
6526         (throw_exception_sjlj, throw_exception_cxx): Update.
6527         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
6528         (all_cleanups, do_cleanups, discard_cleanups)
6529         (discard_final_cleanups, save_cleanups, save_final_cleanups)
6530         (restore_cleanups, restore_final_cleanups): Don't declare.
6531         (do_final_cleanups): Remove parameter.
6532         * common/cleanups.c (cleanup_chain, make_cleanup)
6533         (make_cleanup_dtor, all_cleanups, do_cleanups)
6534         (discard_my_cleanups, discard_cleanups)
6535         (discard_final_cleanups, save_my_cleanups, save_cleanups)
6536         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
6537         (null_cleanup): Remove.
6538         (do_final_cleanups): Remove parameter.
6539
6540 2019-03-06  Tom Tromey  <tom@tromey.com>
6541
6542         * remote.c (remote_target::remote_parse_stop_reply): Use
6543         unique_xmalloc_ptr.
6544
6545 2019-03-06  Tom Tromey  <tom@tromey.com>
6546
6547         * stabsread.c (struct stabs_field_info): Rename from field_info.
6548         <list, fnlist>: Add initializers.
6549         <obstack>: New member.
6550         (read_member_functions, read_struct_fields, read_baseclasses):
6551         Allocate on obstack.  Don't use cleanups.
6552         (read_one_struct_field, read_member_functions, read_struct_fields)
6553         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
6554         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
6555         (read_struct_type): Update.
6556
6557 2019-03-06  Tom Tromey  <tom@tromey.com>
6558
6559         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
6560         * common/filestuff.h (make_cleanup_close): Don't declare.
6561         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
6562         Remove.
6563
6564 2019-03-06  Tom Tromey  <tom@tromey.com>
6565
6566         * solib-aix.c: Use make_scope_exit.
6567
6568 2019-03-06  Tom Tromey  <tom@tromey.com>
6569
6570         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
6571         Use make_scope_exit.
6572
6573 2019-03-06  Tom Tromey  <tom@tromey.com>
6574
6575         * solib-svr4.c (disable_probes_interface): Remove parameter.
6576         (svr4_handle_solib_event): Use make_scope_exit.
6577
6578 2019-03-06  Tom Tromey  <tom@tromey.com>
6579
6580         * remote.c (struct stop_reply_deleter): Remove.
6581         (stop_reply_up): Update.
6582         (struct stop_reply): Derive from notif_event.  Don't typedef.
6583         <regcache>: Now a std::vector.
6584         (stop_reply_xfree): Remove.
6585         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
6586         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
6587         (remote_target::discard_pending_stop_replies): Use delete.
6588         (remote_target::remote_parse_stop_reply): Update.
6589         (remote_target::process_stop_reply): Update.
6590         * remote-notif.h (struct notif_event): Add virtual destructor.
6591         Remove "dtr" member.
6592         (struct notif_client) <alloc_event>: Return a unique_ptr.
6593         (notif_event_xfree): Don't declare.
6594         (notif_event_up): New typedef.
6595         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
6596         (notif_event_xfree, do_notif_event_xfree): Remove.
6597         (remote_notif_state_xfree): Update.
6598
6599 2019-03-06  Tom Tromey  <tom@tromey.com>
6600
6601         * infrun.c (displaced_step_clear_cleanup): Now a
6602         forward_scope_exit type.
6603         (displaced_step_prepare_throw): Update.
6604         (displaced_step_fixup): Update.
6605
6606 2019-03-06  Tom Tromey  <tom@tromey.com>
6607
6608         * inferior.h (class inferior): Update comment.
6609         * gdbthread.h (class thread_info): Update comment.
6610
6611 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
6612             Tom Tromey  <tom@tromey.com>
6613
6614         * stabsread.h (struct stab_section_list): Remove.
6615         (coffstab_build_psymtabs): Update.
6616         * dbxread.c (symbuf_sections): Now a std::vector.
6617         (sect_idx): New global.
6618         (fill_symbuf): Update.
6619         (coffstab_build_psymtabs): Change type of stabsects parameter.
6620         Update.
6621         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
6622         std::vector.
6623         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
6624         (coff_locate_sections): Update.
6625         (coff_symfile_read): Remove cleanups.  Update.
6626         (init_stringtab): Add storage parameter.
6627         (free_stringtab, free_stringtab_cleanup): Remove.
6628         (init_lineno): Add storage parameter.
6629         (free_linetab, free_linetab_cleanup): Remove.
6630
6631 2019-03-06  Pedro Alves  <palves@redhat.com>
6632
6633         * linux-fork.c (fork_info::clobber_regs): Delete.
6634         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
6635         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
6636         comment.  Adjust.
6637         (scoped_switch_fork_info::scoped_switch_fork_info)
6638         (checkpoint_command, linux_fork_context): Adjust
6639         fork_save_infrun_state calls.
6640
6641 2019-03-06  Pedro Alves  <palves@redhat.com>
6642
6643         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
6644         (inf_has_multiple_threads): Return 'bool' and rewrite using
6645         inferior_info::threads().
6646
6647 2019-03-06  Pedro Alves  <palves@redhat.com>
6648
6649         * linux-fork.c: Include <list>.
6650         (fork_list): Now a std::list instance.
6651         (fork_info): Add ctor, dtor, and in-class initialize all fields.
6652         (forks_exist_p, find_last_fork): Adjust.
6653         (new_fork): Delete.
6654         (one_fork_p): New.
6655         (add_fork): Adjust.
6656         (free_fork): Delete, folded into fork_info::~fork_info().
6657         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
6658         Adjust.
6659         (init_fork_list): Delete.
6660         (linux_fork_killall, linux_fork_mourn_inferior)
6661         (linux_fork_detach, info_checkpoints_command): Adjust.
6662         (_initialize_linux_fork): No longer call init_fork_list.
6663
6664 2019-03-06  Pedro Alves  <palves@redhat.com>
6665
6666         * linux-fork.c (new_fork): New, split out of ...
6667         (add_fork): ... this.  Return void.  Move "first fork" special
6668         case from here, to ...
6669         (checkpoint_command): ... here.
6670         * linux-linux.h (add_fork): Return void.
6671
6672 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6673
6674         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
6675
6676 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6677             Chris January  <chris.january@arm.com>
6678             David Lecomber  <david.lecomber@arm.com>
6679
6680         * f-exp.y: New token, UNOP_INTRINSIC.
6681         (exp): New pattern using UNOP_INTRINSIC token.
6682         (f77_keywords): Add 'abs' keyword.
6683         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
6684         (value_from_host_double): New function.
6685         (evaluate_subexp_f): Support UNOP_ABS.
6686
6687 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6688
6689         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
6690         types.
6691
6692 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6693
6694         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
6695         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
6696         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
6697
6698 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6699
6700         * f-exp.y (convert_to_kind_type): Handle more type kinds.
6701
6702 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6703             Chris January  <chris.january@arm.com>
6704
6705         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
6706         * f-exp.y: Define 'KIND' token.
6707         (exp): New pattern for KIND expressions.
6708         (ptype): Handle types with a kind extension.
6709         (direct_abs_decl): Extend to spot kind extensions.
6710         (f77_keywords): Add 'kind' to the list.
6711         (push_kind_type): New function.
6712         (convert_to_kind_type): New function.
6713         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
6714         * parse.c (operator_length_standard): Likewise.
6715         * parser-defs.h (enum type_pieces): Add tp_kind.
6716         * std-operator.def: Add UNOP_KIND.
6717
6718 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6719
6720         * f-exp.y (f_parse): Set yydebug.
6721
6722 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6723
6724         * f-lang.c (evaluate_subexp_f): New function.
6725         (exp_descriptor_f): New global.
6726         (f_language_defn): Use exp_descriptor_f instead of
6727         exp_descriptor_standard.
6728
6729 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6730
6731         * f-exp.y (struct token): Add comments.
6732         (dot_ops): Remove uppercase versions and the end marker.
6733         (f77_keywords): Likewise.
6734         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
6735         entries in the dot_ops array are case insensitive, and use
6736         strncasecmp to compare strings.  Also some whitespace cleanup in
6737         this area.  Similar for the f77_keywords array, except entries in
6738         this list might be case sensitive.
6739
6740 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6741
6742         * f-exp.y (struct f77_boolean_val): Add comments.
6743         (boolean_values): Remove uppercase versions, and end marker.
6744         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
6745         and use strncasecmp to achieve case insensitivity.  Additionally,
6746         perform whitespace cleanup around this code.
6747
6748 2019-03-06  Tom Tromey  <tromey@adacore.com>
6749
6750         * remote-sim.c (gdbsim_target_open): Use result of
6751         gdb_argv::release.
6752
6753 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
6754         Dirk Schubert  <dirk.schubert@arm.com>
6755         Chris January  <chris.january@arm.com>
6756
6757         * eval.c (evaluate_subexp_standard): Call Fortran argument
6758         wrapping logic.
6759         * f-lang.c (struct value): A value which can be passed into a
6760         Fortran function call.
6761         (fortran_argument_convert): Wrap Fortran arguments in a pointer
6762         where appropriate.
6763         (struct type): Value ready for a Fortran function call.
6764         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
6765         is needed.
6766         * f-lang.h (fortran_argument_convert): Declaration.
6767         (fortran_preserve_arg_pointer): Declaration.
6768         * infcall.c (value_arg_coerce): Call Fortran argument logic.
6769
6770 2019-03-05  Tom Tromey  <tromey@adacore.com>
6771
6772         * python/py-prettyprint.c (print_string_repr): Remove #if.
6773         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
6774
6775 2019-03-05  Tom Tromey  <tromey@adacore.com>
6776
6777         * target.c (the_dummy_target): Move later.  Change type to
6778         "dummy_target".
6779         (initialize_targets): Don't initialize the_dummy_target.
6780
6781 2019-03-05  Tom Tromey  <tromey@adacore.com>
6782
6783         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
6784         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
6785
6786 2019-03-05  Tom Tromey  <tromey@adacore.com>
6787
6788         * windows-nat.c (windows_nat_target::attach)
6789         (windows_nat_target::detach): Don't call gdb_flush.
6790         * valprint.c (generic_val_print, val_print, val_print_string):
6791         Don't call gdb_flush.
6792         * utils.c (defaulted_query): Don't call gdb_flush.
6793         * typeprint.c (print_type_scalar): Don't call gdb_flush.
6794         * target.c (target_announce_detach): Don't call gdb_flush.
6795         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
6796         * remote.c (extended_remote_target::attach): Don't call
6797         gdb_flush.
6798         * procfs.c (procfs_target::detach): Don't call gdb_flush.
6799         * printcmd.c (do_examine): Don't call gdb_flush.
6800         (info_display_command): Don't call gdb_flush.
6801         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
6802         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
6803         * memattr.c (info_mem_command): Don't call gdb_flush.
6804         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
6805         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
6806         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
6807         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
6808         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
6809         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
6810         (gnu_nat_target::detach): Don't call gdb_flush.
6811         * f-valprint.c (f_val_print): Don't call gdb_flush.
6812         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
6813         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
6814         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
6815         gdb_flush.
6816         * c-valprint.c (c_val_print): Don't call gdb_flush.
6817         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
6818
6819 2019-03-05  Tom Tromey  <tromey@adacore.com>
6820
6821         * varobj.c (update_dynamic_varobj_children): Update.
6822         (install_default_visualizer): Use reset, not release.
6823         * value.c (set_internalvar): Update.
6824         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
6825         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
6826         ATTRIBUTE_UNUSED_RESULT.
6827
6828 2019-03-05  Tom Tromey  <tromey@adacore.com>
6829
6830         * remote.c (class scoped_remote_fd) <release>: Add
6831         ATTRIBUTE_UNUSED_RESULT.
6832
6833 2019-03-05  Tom Tromey  <tromey@adacore.com>
6834
6835         * macroexp.c (struct macro_buffer) <release>: Add
6836         ATTRIBUTE_UNUSED_RESULT.
6837
6838 2019-03-05  Tom Tromey  <tromey@adacore.com>
6839
6840         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
6841         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
6842         ATTRIBUTE_UNUSED_RESULT.
6843
6844 2019-03-05  Tom Tromey  <tromey@adacore.com>
6845
6846         * common/scoped_fd.h (class scoped_fd) <release>: Add
6847         ATTRIBUTE_UNUSED_RESULT.
6848
6849 2019-03-05  Tom Tromey  <tromey@adacore.com>
6850
6851         * parser-defs.h (struct parser_state) <release>: Add
6852         ATTRIBUTE_UNUSED_RESULT.
6853
6854 2019-03-05  Tom Tromey  <tromey@adacore.com>
6855
6856         * utils.h (class gdb_argv) <release>: Add
6857         ATTRIBUTE_UNUSED_RESULT.
6858         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
6859
6860 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
6861
6862         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
6863         for-loop range, to avoid compiler warnings.
6864
6865         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
6866         avoid compiler warnings about unused variables.
6867
6868         * NEWS: Mention end of support for native debugging on MS-Windows
6869         before XP.
6870
6871         PR gdb/24292
6872         * common/netstuff.c:
6873         * gdbserver/gdbreplay.c
6874         * gdbserver/remote-utils.c:
6875         * ser-tcp.c:
6876         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
6877         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
6878         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
6879         'getaddrinfo' and 'freeaddrinfo' were not available before
6880         Windows XP, and mingw.org's MinGW headers by default define
6881         _WIN32_WINNT to 0x500.
6882
6883 2019-03-01  Gary Benson <gbenson@redhat.com>
6884
6885         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
6886
6887 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
6888             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
6889
6890         PR gdb/8527
6891         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
6892         set_sigint_trap, clear_sigint_trap.
6893
6894 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6895
6896         * target.c (target_detach): Clear the regcache and the
6897         frame cache.
6898
6899 2019-02-27  Pedro Alves  <palves@redhat.com>
6900
6901         * utils.c (set_screen_size): When we cap the height/width sizes,
6902         tweak the corresponding command variable to show "unlimited":
6903
6904 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
6905             Pedro Alves  <palves@redhat.com>
6906
6907         * utils.c (set_screen_size): Reduce "infinite" rows and columns
6908         before calling rl_set_screen_size.
6909
6910 2019-02-27  Tom Tromey  <tromey@adacore.com>
6911
6912         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
6913         define.
6914         * python/py-value.c: Remove Python 2.4 workaround.
6915         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
6916         workaround.
6917         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
6918         Python 2.4 workaround.
6919         * python/python-internal.h: Remove Python 2.4 comment.
6920         (Py_ssize_t): Don't define.
6921         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
6922         (gdb_Py_DECREF): Remove Python 2.4 workaround.
6923         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
6924         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
6925         * python/python.c (do_start_initialization): Remove Python 2.4
6926         workaround.
6927         * python/py-prettyprint.c (class dummy_python_frame): Remove.
6928         (print_children): Remove Python 2.4 workaround.
6929         * python/py-inferior.c (buffer_procs): Remove Python 2.4
6930         workaround.
6931         (CHARBUFFERPROC_NAME): Remove.
6932         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
6933         Python 2.4 workaround.
6934
6935 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6936
6937         * NEWS: Note minimum Python version.
6938
6939 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6940
6941         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
6942         code from these functions.  Remove corresponding ifdefs.  Use
6943         Py_buffer_up instead of explicit calls to PyBuffer_Release.
6944         Remove gotos and target of gotos.
6945         (infpy_search_memory): Likewise.
6946
6947 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6948
6949         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
6950         (hppa_gdbarch_init): Don't register deleted functions with
6951         gdbarch.
6952
6953 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6954
6955         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
6956         (h8300_unwind_sp): Delete.
6957         (h8300_dummy_id): Delete.
6958         (h8300_gdbarch_init): Don't register deleted functions with
6959         gdbarch.
6960
6961 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6962
6963         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
6964         (ft32_unwind_pc): Delete.
6965         (ft32_unwind_sp): Delete.
6966         (ft32_gdbarch_init): Don't register deleted functions with
6967         gdbarch.
6968
6969 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6970
6971         * gdb/frv-tdep.c (frv_dummy_id): Delete.
6972         (frv_unwind_pc): Delete.
6973         (frv_unwind_sp): Delete.
6974         (frv_gdbarch_init): Don't register deleted functions with
6975         gdbarch.
6976
6977 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6978
6979         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
6980         (riscv_unwind_pc): Delete.
6981         (riscv_unwind_sp): Delete.
6982         (riscv_gdbarch_init): Don't register deleted functions with
6983         gdbarch.
6984
6985 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6986
6987         * gdb/csky-tdep.c (csky_dummy_id): Delete.
6988         (csky_unwind_pc): Delete.
6989         (csky_unwind_sp): Delete.
6990         (csky_gdbarch_init): Don't register deleted functions with
6991         gdbarch.
6992
6993 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6994
6995         * gdb/cris-tdep.c (cris_dummy_id): Delete.
6996         (cris_unwind_pc): Delete.
6997         (cris_unwind_sp): Delete.
6998         (cris_gdbarch_init): Don't register deleted functions with
6999         gdbarch.
7000
7001 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7002
7003         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7004         (bfin_unwind_pc): Delete.
7005         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7006
7007 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7008
7009         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7010         (arm_unwind_pc): Delete.
7011         (arm_unwind_sp): Delete.
7012         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7013
7014 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7015
7016         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7017         (arc_unwind_pc): Delete.
7018         (arc_unwind_sp): Delete.
7019         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7020
7021 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7022
7023         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7024         (alpha_unwind_pc): Delete.
7025         (alpha_gdbarch_init): Don't register deleted functions with
7026         gdbarch.
7027
7028 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7029
7030         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7031         (aarch64_unwind_pc): Delete.
7032         (aarch64_unwind_sp): Delete.
7033         (aarch64_gdbarch_init): Don't register deleted functions with
7034         gdbarch.
7035
7036 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7037
7038         * gdbtypes.c (type_align): Don't consider static members when
7039         computing structure alignment.
7040
7041 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7042
7043         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7044         return 0 for other types.
7045         * arch-utils.c (default_type_align): Always return 0.
7046         * gdbarch.h: Regenerate.
7047         * gdbarch.sh (type_align): Extend comment.
7048         * gdbtypes.c (type_align): Add additional comments, always call
7049         gdbarch_type_align before applying the default rules.
7050         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7051         generic code will then apply a suitable default.
7052         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7053         types, return 0 for other types.
7054
7055 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7056
7057         * NEWS: Create a new section for the next release branch.
7058         Rename the section of the current branch, now that it has
7059         been cut.
7060
7061 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7062
7063         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7064         * version.in: Bump version to 8.3.50.DATE-git.
7065
7066 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7067
7068         * aix-thread.c (ptid_cmp): Remove unused variable.
7069         (get_signaled_thread): Likewise.
7070         (store_regs_user_thread): Likewise.
7071         (store_regs_kernel_thread): Likewise.
7072         (fetch_regs_kernel_thread): Remove shadowed variable.
7073
7074 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7075
7076         * features/riscv/32bit-cpu.xml: Add register numbers.
7077         * features/riscv/32bit-fpu.c: Regenerate.
7078         * features/riscv/32bit-fpu.xml: Add register numbers.
7079         * features/riscv/64bit-cpu.xml: Add register numbers.
7080         * features/riscv/64bit-fpu.c: Regenerate.
7081         * features/riscv/64bit-fpu.xml: Add register numbers.
7082
7083 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7084
7085         * NEWS: Mention two argument form of gdb.Value constructor.
7086         * python/py-value.c (convert_buffer_and_type_to_value): New
7087         function.
7088         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7089         Add support for handling an optional second argument.  Call
7090         convert_buffer_and_type_to_value as appropriate.
7091         * python/python-internal.h (Py_buffer_deleter): New struct.
7092         (Py_buffer_up): New typedef.
7093
7094 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7095
7096         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7097         instead of releasing ownership.
7098
7099 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7100
7101         * dwarf2read.c (open_and_init_dwp_file): Call
7102         elf_numsections instead of bfd_count_sections to initialize
7103         dwp_file->num_sections.
7104
7105 2019-02-25  Tom Tromey  <tromey@adacore.com>
7106
7107         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7108
7109 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7110
7111         * gcore.in: Add '--readnever' option when invoking GDB.
7112
7113 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7114
7115         * MAINTAINERS: Update my email address.
7116
7117 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7118
7119         * build-id.c (build_id_to_debug_bfd_1): New function.
7120         (build_id_to_debug_bfd): Look for separate debug file in
7121         sysroot.
7122
7123 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7124
7125         * gdbarch.sh: Update the copyright year range that is placed into
7126         generated files.
7127
7128 2019-02-22  Keith Seitz  <keiths@redhat.com>
7129
7130         PR symtab/23853
7131         * linespec.c (create_sals_line_offset): Search for the default
7132         symtab's filename instead of its fullname.
7133
7134 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7135
7136         * NEWS: Update style defaults.
7137
7138 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7139
7140         * main.c (captured_main_1): Disable styling in batch mode.
7141
7142 2019-02-20  Tom Tromey  <tom@tromey.com>
7143
7144         * symtab.c (symtab_symbol_info): Fix typos.
7145
7146 2019-02-20  Tom Tromey  <tromey@adacore.com>
7147
7148         * findcmd.c (_initialize_mem_search): Use upper case for
7149         metasyntactic variables.
7150
7151 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7152
7153         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7154         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7155
7156 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7157
7158         * top.h (source_file_name): Change to std::string.
7159         * top.c (source_file_name): Likewise.
7160         (command_line_input): Adjust.
7161         * cli/cli-script.c (script_from_file): Adjust.
7162
7163 2019-02-19  Tom Tromey  <tromey@adacore.com>
7164
7165         * ravenscar-thread.c
7166         (ravenscar_thread_target::update_thread_list): Don't call
7167         ada_build_task_list.
7168         * ada-lang.h (ada_build_task_list): Don't declare.
7169         * ada-tasks.c (struct ada_tasks_inferior_data)
7170         <task_list_valid_p>: Now bool.
7171         (read_known_tasks, ada_task_list_changed)
7172         (ada_tasks_invalidate_inferior_data): Update.
7173         (read_known_tasks_array): Return bool.
7174         (read_known_tasks_list): Likewise.
7175         (read_known_tasks): Return void.
7176         (ada_build_task_list): Now static.
7177
7178 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7179
7180         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
7181         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
7182
7183 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7184
7185         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
7186         variant for ada_tasks_pspace_data_handle and
7187         ada_tasks_inferior_data_handle.
7188         (ada_tasks_pspace_data_cleanup): New function.
7189         (ada_tasks_inferior_data_cleanup): New function.
7190
7191 2019-02-17  Tom Tromey  <tom@tromey.com>
7192
7193         * macrotab.h (macro_source_fullname): Return a std::string.
7194         * macrotab.c (macro_include, check_for_redefinition)
7195         (macro_undef, macro_lookup_definition, foreach_macro)
7196         (foreach_macro_in_scope): Update.
7197         (macro_source_fullname): Return a std::string.
7198         * macrocmd.c (show_pp_source_pos): Update.
7199
7200 2019-02-17  Tom Tromey  <tom@tromey.com>
7201
7202         * macrocmd.c (show_pp_source_pos): Style the file names.
7203
7204 2019-02-17  Tom Tromey  <tom@tromey.com>
7205
7206         PR tui/24197:
7207         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
7208
7209 2019-02-17  Tom Tromey  <tom@tromey.com>
7210
7211         * ada-lang.c (user_select_syms): Use filtered printing.
7212         * utils.c (wrap_style): New global.
7213         (desired_style): Remove.
7214         (emit_style_escape): Add stream parameter.
7215         (set_output_style, reset_terminal_style, prompt_for_continue):
7216         Update.
7217         (flush_wrap_buffer): Only flush gdb_stdout.
7218         (wrap_here): Set wrap_style.
7219         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
7220         treat escape sequences as a character.  Change when wrap buffer is
7221         flushed.
7222         (fputs_styled): Do not set the output style when the default is
7223         requested.
7224         * ui-style.h (struct ui_file_style) <is_default>: New method.
7225         * source.c (print_source_lines_base): Emit escape sequences in one
7226         piece.
7227
7228 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7229
7230         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
7231         integers and enumeration types.
7232
7233 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7234
7235         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
7236         instead of lookup_symbol_in_language
7237         (do_exact_match): New function.
7238         (ada_get_symbol_name_matcher): Return do_exact_match when
7239         doing a verbatim match.
7240
7241 2019-02-15  Tom Tromey  <tromey@adacore.com>
7242
7243         * ravenscar-thread.c (ravenscar_thread_target::resume)
7244         (ravenscar_thread_target::wait): Special case wildcard requests.
7245
7246 2019-02-15  Tom Tromey  <tromey@adacore.com>
7247
7248         * ravenscar-thread.c (base_ptid): Remove.
7249         (struct ravenscar_thread_target) <close>: New method.
7250         <m_base_ptid>: New member.
7251         <update_inferior_ptid, active_task, task_is_currently_active,
7252         runtime_initialized>: Declare methods.
7253         <ravenscar_thread_target>: Add constructor.
7254         (ravenscar_thread_target::task_is_currently_active)
7255         (ravenscar_thread_target::update_inferior_ptid)
7256         (ravenscar_runtime_initialized): Rename.  Now methods.
7257         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
7258         (ravenscar_thread_target::update_thread_list): Update.
7259         (ravenscar_thread_target::active_task): Now method.
7260         (ravenscar_thread_target::store_registers)
7261         (ravenscar_thread_target::prepare_to_store)
7262         (ravenscar_thread_target::prepare_to_store)
7263         (ravenscar_thread_target::mourn_inferior): Update.
7264         (ravenscar_inferior_created): Use "new" to create target.
7265         (ravenscar_thread_target::get_ada_task_ptid): Update.
7266         (_initialize_ravenscar): Don't initialize base_ptid.
7267         (ravenscar_ops): Remove global.
7268
7269 2019-02-15  Tom Tromey  <tromey@adacore.com>
7270
7271         * target.h (push_target): Declare new overload.
7272         * target.c (push_target): New overload, taking an rvalue reference.
7273         * remote.c (remote_target::open_1): Use push_target overload.
7274         * corelow.c (core_target_open): Use push_target overload.
7275
7276 2019-02-15  Tom Tromey  <tromey@adacore.com>
7277
7278         * ravenscar-thread.c (is_ravenscar_task)
7279         (ravenscar_task_is_currently_active): Return bool.
7280         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
7281         (_initialize_ravenscar): Remove "(void)".
7282         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
7283         Return bool.
7284
7285 2019-02-15  Tom Tromey  <tromey@adacore.com>
7286
7287         * ravenscar-thread.c (ravenscar_runtime_initializer)
7288         (has_ravenscar_runtime, get_running_thread_id)
7289         (ravenscar_thread_target::resume): Fix indentation.
7290
7291 2019-02-15  Tom Tromey  <tromey@adacore.com>
7292
7293         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
7294         from ravenscar_arch_ops.
7295         (sparc_ravenscar_ops::fetch_registers)
7296         (sparc_ravenscar_ops::store_registers): Now methods.
7297         (sparc_ravenscar_prepare_to_store): Remove.
7298         (sparc_ravenscar_ops): Redefine.
7299         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
7300         methods and destructor.  Remove members.
7301         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
7302         (ravenscar_thread_target::store_registers)
7303         (ravenscar_thread_target::prepare_to_store): Update.
7304         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
7305         Remove.
7306         (struct ppc_ravenscar_powerpc_ops): Derive from
7307         ravenscar_arch_ops.
7308         (ppc_ravenscar_powerpc_ops::fetch_registers)
7309         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
7310         (ppc_ravenscar_powerpc_ops): Redefine.
7311         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
7312         (ppc_ravenscar_e500_ops::fetch_registers)
7313         (ppc_ravenscar_e500_ops::store_registers): Now methods.
7314         (ppc_ravenscar_e500_ops): Redefine.
7315         * aarch64-ravenscar-thread.c
7316         (aarch64_ravenscar_generic_prepare_to_store): Remove.
7317         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
7318         (aarch64_ravenscar_fetch_registers)
7319         (aarch64_ravenscar_store_registers): Now methods.
7320         (aarch64_ravenscar_ops): Redefine.
7321
7322 2019-02-15  Tom Tromey  <tromey@adacore.com>
7323
7324         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
7325         (ravenscar_thread_target::stopped_by_hw_breakpoint)
7326         (ravenscar_thread_target::stopped_by_watchpoint)
7327         (ravenscar_thread_target::stopped_data_address)
7328         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
7329
7330 2019-02-15  Tom Tromey  <tromey@adacore.com>
7331
7332         * ravenscar-thread.c: Fix some typos.
7333
7334 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7335             Tom Tromey  <tromey@adacore.com>
7336
7337         * ada-lang.c (ada_exception_sal): Change addr_string to a
7338         std::string.
7339         (create_ada_exception_catchpoint): Update.
7340
7341 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7342             Tom Tromey  <tromey@adacore.com>
7343
7344         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
7345         (bp_location_ops): Remove.
7346         (base_breakpoint_allocate_location): Update.
7347         (free_bp_location): Update.
7348         * ada-lang.c (class ada_catchpoint_location)
7349         <ada_catchpoint_location>: Remove ops parameter.
7350         (ada_catchpoint_location_dtor): Remove.
7351         (ada_catchpoint_location_ops): Remove.
7352         (allocate_location_exception): Update.
7353         * breakpoint.h (struct bp_location_ops): Remove.
7354         (class bp_location) <bp_location>: Remove bp_location_ops
7355         parameter.
7356         <~bp_location>: Add destructor.
7357         <ops>: Remove.
7358
7359 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7360             Pedro Alves  <palves@redhat.com>
7361
7362         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
7363         'PATH_MAX'.
7364
7365 2019-02-14  David Michael  <fedora.dm0@gmail.com>
7366             Samuel Thibault  <samuel.thibault@gnu.org>
7367             Thomas Schwinge  <thomas@codesourcery.com>
7368
7369         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
7370         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
7371
7372 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7373
7374         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
7375         (check_empty): Use "const char *".
7376
7377         * gnu-nat.c (gnu_nat_target::detach): Instead of
7378         'detach_inferior (pid)' call
7379         'detach_inferior (find_inferior_pid (pid))'.
7380
7381         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
7382         'nat/fork-inferior.o'.
7383         * gnu-nat.c: #include "nat/fork-inferior.h".
7384
7385         * gnu-nat.c (gnu_nat_target::detach): Instead of
7386         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
7387         * gnu-nat.h: #include "inf-child.h".
7388         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
7389         'i386_gnu_nat_target::fetch_registers'.
7390         (gnu_store_registers): Rename/move to
7391         'i386_gnu_nat_target::store_registers'.
7392
7393         * config/i386/nm-i386gnu.h: Don't "#include" any files.
7394         * gnu-nat.h (mach_thread_info): New function.
7395         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
7396
7397         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
7398
7399 2019-02-14  Frederic Konrad  <konrad@adacore.com>
7400
7401         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
7402
7403 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
7404
7405         * windows-nat.c (windows_add_thread): Add new parameter
7406         "main_thread_p" with default value set to false.  Update
7407         function documentation as well as all callers.
7408         (windows_delete_thread): Likewise.
7409         (fake_create_process): Update call to windows_add_thread.
7410         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
7411         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
7412         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
7413         call to windows_delete_thread.
7414
7415 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
7416
7417         * MAINTAINERS: Add Andrew Burgess as global maintainer.
7418
7419 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7420
7421         * symfile.c (find_separate_debug_file): Use canonical path of
7422         sysroot with child_path instead of gdb_sysroot if it is valid.
7423
7424 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7425
7426         * symfile.c (find_separate_debug_file): Use child_path to
7427         determine if an object file is under a sysroot.
7428
7429 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7430
7431         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
7432         unittests/child-path-selftests.c.
7433         * common/pathstuff.c (child_path): New function.
7434         * common/pathstuff.h (child_path): New prototype.
7435         * unittests/child-path-selftests.c: New file.
7436
7437 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7438
7439         * symfile.c (find_separate_debug_file): Look for separate debug
7440         files in debug directories under the sysroot.
7441
7442 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7443
7444         * symtab.h (struct minimal_symbol data_p): New const method.
7445         (struct minimal_symbol text_p): Likewise.
7446         * symtab.c (output_source_filename): Use file name style
7447         to print file name.
7448         (print_symbol_info): Likewise.
7449         (print_msymbol_info): Use address style to print addresses.
7450         Use function name style to print executable text symbols.
7451         (expand_symtab_containing_pc): Use data_p.
7452         (find_pc_sect_compunit_symtab): Likewise.
7453
7454 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7455
7456         * breakpoint.c (describe_other_breakpoints): Use address style
7457         to print addresses.
7458         (say_where): Likewise.
7459
7460 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7461
7462         * ada-typeprint.c (print_func_type): Print function name
7463         style to print function name.
7464         * c-typeprint.c (c_print_type_1): Likewise.
7465
7466 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
7467
7468         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
7469         for execve.
7470
7471 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7472
7473         * c-exp.y (direct_abs_decl): Use emplace_back to record the
7474         type_stack.
7475
7476 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
7477
7478         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
7479         TYPE_CODE_REF types.
7480
7481 2019-02-08  Jim Wilson  <jimw@sifive.com>
7482
7483         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
7484         (riscv_linux_fregset): New.
7485         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
7486
7487 2019-02-07  Tom Tromey  <tom@tromey.com>
7488
7489         * thread.c (thread_cancel_execution_command): Update.
7490         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
7491         methods.
7492         (struct thread_fsm_ops): Remove.
7493         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
7494         (thread_fsm_should_stop, thread_fsm_return_value)
7495         (thread_fsm_set_finished, thread_fsm_finished_p)
7496         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
7497         Don't declare.
7498         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
7499         * infrun.c (clear_proceed_status_thread)
7500         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
7501         (print_stop_event): Update.
7502         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
7503         Add constructor.
7504         (step_command_fsm_ops): Remove.
7505         (new_step_command_fsm): Remove.
7506         (step_1): Update.
7507         (step_command_fsm::should_stop): Rename from
7508         step_command_fsm_should_stop.
7509         (step_command_fsm::clean_up): Rename from
7510         step_command_fsm_clean_up.
7511         (step_command_fsm::do_async_reply_reason): Rename from
7512         step_command_fsm_async_reply_reason.
7513         (struct until_next_fsm): Inherit from thread_fsm.  Add
7514         constructor.
7515         (until_next_fsm_ops): Remove.
7516         (new_until_next_fsm): Remove.
7517         (until_next_fsm::should_stop): Rename from
7518         until_next_fsm_should_stop.
7519         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
7520         (until_next_fsm::do_async_reply_reason): Rename from
7521         until_next_fsm_async_reply_reason.
7522         (struct finish_command_fsm): Inherit from thread_fsm.  Add
7523         constructor.  Change type of breakpoint.
7524         (finish_command_fsm_ops): Remove.
7525         (new_finish_command_fsm): Remove.
7526         (finish_command_fsm::should_stop): Rename from
7527         finish_command_fsm_should_stop.
7528         (finish_command_fsm::clean_up): Rename from
7529         finish_command_fsm_clean_up.
7530         (finish_command_fsm::return_value): Rename from
7531         finish_command_fsm_return_value.
7532         (finish_command_fsm::do_async_reply_reason): Rename from
7533         finish_command_fsm_async_reply_reason.
7534         (finish_command): Update.
7535         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
7536         Add constructor.
7537         (call_thread_fsm_ops): Remove.
7538         (call_thread_fsm::call_thread_fsm): Rename from
7539         new_call_thread_fsm.
7540         (call_thread_fsm::should_stop): Rename from
7541         call_thread_fsm_should_stop.
7542         (call_thread_fsm::should_notify_stop): Rename from
7543         call_thread_fsm_should_notify_stop.
7544         (run_inferior_call, call_function_by_hand_dummy): Update.
7545         * cli/cli-interp.c (should_print_stop_to_console): Update.
7546         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
7547         Add constructor.  Change type of location_breakpoint,
7548         caller_breakpoint.
7549         (until_break_fsm_ops): Remove.
7550         (new_until_break_fsm): Remove.
7551         (until_break_fsm::should_stop): Rename from
7552         until_break_fsm_should_stop.
7553         (until_break_fsm::clean_up): Rename from
7554         until_break_fsm_clean_up.
7555         (until_break_fsm::do_async_reply_reason): Rename from
7556         until_break_fsm_async_reply_reason.
7557         (until_break_command): Update.
7558         * thread-fsm.c: Remove.
7559         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
7560
7561 2019-02-07  Tom Tromey  <tom@tromey.com>
7562
7563         * yy-remap.h: Add include guard.
7564         * xtensa-tdep.h: Add include guard.
7565         * xcoffread.h: Rename include guard.
7566         * varobj-iter.h: Add include guard.
7567         * tui/tui.h: Rename include guard.
7568         * tui/tui-winsource.h: Rename include guard.
7569         * tui/tui-wingeneral.h: Rename include guard.
7570         * tui/tui-windata.h: Rename include guard.
7571         * tui/tui-win.h: Rename include guard.
7572         * tui/tui-stack.h: Rename include guard.
7573         * tui/tui-source.h: Rename include guard.
7574         * tui/tui-regs.h: Rename include guard.
7575         * tui/tui-out.h: Rename include guard.
7576         * tui/tui-layout.h: Rename include guard.
7577         * tui/tui-io.h: Rename include guard.
7578         * tui/tui-hooks.h: Rename include guard.
7579         * tui/tui-file.h: Rename include guard.
7580         * tui/tui-disasm.h: Rename include guard.
7581         * tui/tui-data.h: Rename include guard.
7582         * tui/tui-command.h: Rename include guard.
7583         * tic6x-tdep.h: Add include guard.
7584         * target/waitstatus.h: Rename include guard.
7585         * target/wait.h: Rename include guard.
7586         * target/target.h: Rename include guard.
7587         * target/resume.h: Rename include guard.
7588         * target-float.h: Rename include guard.
7589         * stabsread.h: Add include guard.
7590         * rs6000-tdep.h: Add include guard.
7591         * riscv-fbsd-tdep.h: Add include guard.
7592         * regformats/regdef.h: Rename include guard.
7593         * record.h: Rename include guard.
7594         * python/python.h: Rename include guard.
7595         * python/python-internal.h: Rename include guard.
7596         * python/py-stopevent.h: Rename include guard.
7597         * python/py-ref.h: Rename include guard.
7598         * python/py-record.h: Rename include guard.
7599         * python/py-record-full.h: Rename include guard.
7600         * python/py-record-btrace.h: Rename include guard.
7601         * python/py-instruction.h: Rename include guard.
7602         * python/py-events.h: Rename include guard.
7603         * python/py-event.h: Rename include guard.
7604         * procfs.h: Add include guard.
7605         * proc-utils.h: Add include guard.
7606         * p-lang.h: Add include guard.
7607         * or1k-tdep.h: Rename include guard.
7608         * observable.h: Rename include guard.
7609         * nto-tdep.h: Rename include guard.
7610         * nat/x86-linux.h: Rename include guard.
7611         * nat/x86-linux-dregs.h: Rename include guard.
7612         * nat/x86-gcc-cpuid.h: Add include guard.
7613         * nat/x86-dregs.h: Rename include guard.
7614         * nat/x86-cpuid.h: Rename include guard.
7615         * nat/ppc-linux.h: Rename include guard.
7616         * nat/mips-linux-watch.h: Rename include guard.
7617         * nat/linux-waitpid.h: Rename include guard.
7618         * nat/linux-ptrace.h: Rename include guard.
7619         * nat/linux-procfs.h: Rename include guard.
7620         * nat/linux-osdata.h: Rename include guard.
7621         * nat/linux-nat.h: Rename include guard.
7622         * nat/linux-namespaces.h: Rename include guard.
7623         * nat/linux-btrace.h: Rename include guard.
7624         * nat/glibc_thread_db.h: Rename include guard.
7625         * nat/gdb_thread_db.h: Rename include guard.
7626         * nat/gdb_ptrace.h: Rename include guard.
7627         * nat/fork-inferior.h: Rename include guard.
7628         * nat/amd64-linux-siginfo.h: Rename include guard.
7629         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
7630         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
7631         * nat/aarch64-linux.h: Rename include guard.
7632         * nat/aarch64-linux-hw-point.h: Rename include guard.
7633         * mn10300-tdep.h: Add include guard.
7634         * mips-linux-tdep.h: Add include guard.
7635         * mi/mi-parse.h: Rename include guard.
7636         * mi/mi-out.h: Rename include guard.
7637         * mi/mi-main.h: Rename include guard.
7638         * mi/mi-interp.h: Rename include guard.
7639         * mi/mi-getopt.h: Rename include guard.
7640         * mi/mi-console.h: Rename include guard.
7641         * mi/mi-common.h: Rename include guard.
7642         * mi/mi-cmds.h: Rename include guard.
7643         * mi/mi-cmd-break.h: Rename include guard.
7644         * m2-lang.h: Add include guard.
7645         * location.h: Rename include guard.
7646         * linux-record.h: Rename include guard.
7647         * linux-nat.h: Add include guard.
7648         * linux-fork.h: Add include guard.
7649         * i386-darwin-tdep.h: Rename include guard.
7650         * hppa-linux-offsets.h: Add include guard.
7651         * guile/guile.h: Rename include guard.
7652         * guile/guile-internal.h: Rename include guard.
7653         * gnu-nat.h: Rename include guard.
7654         * gdb-stabs.h: Rename include guard.
7655         * frv-tdep.h: Add include guard.
7656         * f-lang.h: Add include guard.
7657         * event-loop.h: Add include guard.
7658         * darwin-nat.h: Rename include guard.
7659         * cp-abi.h: Rename include guard.
7660         * config/sparc/nm-sol2.h: Rename include guard.
7661         * config/nm-nto.h: Rename include guard.
7662         * config/nm-linux.h: Add include guard.
7663         * config/i386/nm-i386gnu.h: Rename include guard.
7664         * config/djgpp/nl_types.h: Rename include guard.
7665         * config/djgpp/langinfo.h: Rename include guard.
7666         * compile/gcc-cp-plugin.h: Add include guard.
7667         * compile/gcc-c-plugin.h: Add include guard.
7668         * compile/compile.h: Rename include guard.
7669         * compile/compile-object-run.h: Rename include guard.
7670         * compile/compile-object-load.h: Rename include guard.
7671         * compile/compile-internal.h: Rename include guard.
7672         * compile/compile-cplus.h: Rename include guard.
7673         * compile/compile-c.h: Rename include guard.
7674         * common/xml-utils.h: Rename include guard.
7675         * common/x86-xstate.h: Rename include guard.
7676         * common/version.h: Rename include guard.
7677         * common/vec.h: Rename include guard.
7678         * common/tdesc.h: Rename include guard.
7679         * common/selftest.h: Rename include guard.
7680         * common/scoped_restore.h: Rename include guard.
7681         * common/scoped_mmap.h: Rename include guard.
7682         * common/scoped_fd.h: Rename include guard.
7683         * common/safe-iterator.h: Rename include guard.
7684         * common/run-time-clock.h: Rename include guard.
7685         * common/refcounted-object.h: Rename include guard.
7686         * common/queue.h: Rename include guard.
7687         * common/ptid.h: Rename include guard.
7688         * common/print-utils.h: Rename include guard.
7689         * common/preprocessor.h: Rename include guard.
7690         * common/pathstuff.h: Rename include guard.
7691         * common/observable.h: Rename include guard.
7692         * common/netstuff.h: Rename include guard.
7693         * common/job-control.h: Rename include guard.
7694         * common/host-defs.h: Rename include guard.
7695         * common/gdb_wait.h: Rename include guard.
7696         * common/gdb_vecs.h: Rename include guard.
7697         * common/gdb_unlinker.h: Rename include guard.
7698         * common/gdb_unique_ptr.h: Rename include guard.
7699         * common/gdb_tilde_expand.h: Rename include guard.
7700         * common/gdb_sys_time.h: Rename include guard.
7701         * common/gdb_string_view.h: Rename include guard.
7702         * common/gdb_splay_tree.h: Rename include guard.
7703         * common/gdb_setjmp.h: Rename include guard.
7704         * common/gdb_ref_ptr.h: Rename include guard.
7705         * common/gdb_optional.h: Rename include guard.
7706         * common/gdb_locale.h: Rename include guard.
7707         * common/gdb_assert.h: Rename include guard.
7708         * common/filtered-iterator.h: Rename include guard.
7709         * common/filestuff.h: Rename include guard.
7710         * common/fileio.h: Rename include guard.
7711         * common/environ.h: Rename include guard.
7712         * common/common-utils.h: Rename include guard.
7713         * common/common-types.h: Rename include guard.
7714         * common/common-regcache.h: Rename include guard.
7715         * common/common-inferior.h: Rename include guard.
7716         * common/common-gdbthread.h: Rename include guard.
7717         * common/common-exceptions.h: Rename include guard.
7718         * common/common-defs.h: Rename include guard.
7719         * common/common-debug.h: Rename include guard.
7720         * common/cleanups.h: Rename include guard.
7721         * common/buffer.h: Rename include guard.
7722         * common/btrace-common.h: Rename include guard.
7723         * common/break-common.h: Rename include guard.
7724         * cli/cli-utils.h: Rename include guard.
7725         * cli/cli-style.h: Rename include guard.
7726         * cli/cli-setshow.h: Rename include guard.
7727         * cli/cli-script.h: Rename include guard.
7728         * cli/cli-interp.h: Rename include guard.
7729         * cli/cli-decode.h: Rename include guard.
7730         * cli/cli-cmds.h: Rename include guard.
7731         * charset-list.h: Add include guard.
7732         * buildsym-legacy.h: Rename include guard.
7733         * bfin-tdep.h: Add include guard.
7734         * ax.h: Rename include guard.
7735         * arm-linux-tdep.h: Add include guard.
7736         * arm-fbsd-tdep.h: Add include guard.
7737         * arch/xtensa.h: Rename include guard.
7738         * arch/tic6x.h: Add include guard.
7739         * arch/i386.h: Add include guard.
7740         * arch/arm.h: Rename include guard.
7741         * arch/arm-linux.h: Rename include guard.
7742         * arch/arm-get-next-pcs.h: Rename include guard.
7743         * arch/amd64.h: Add include guard.
7744         * arch/aarch64-insn.h: Rename include guard.
7745         * arch-utils.h: Rename include guard.
7746         * annotate.h: Add include guard.
7747         * amd64-darwin-tdep.h: Rename include guard.
7748         * aarch64-linux-tdep.h: Add include guard.
7749         * aarch64-fbsd-tdep.h: Add include guard.
7750         * aarch32-linux-nat.h: Add include guard.
7751
7752 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7753
7754         * macrotab.c (macro_define_internal): New function that
7755         factorizes macro_define_object_internal and macro_define_function
7756         code.
7757         (macro_define_object_internal): Use macro_define_internal.
7758         (macro_define_function): Likewise.
7759
7760 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7761
7762         * macrocmd.c (extract_identifier): Return
7763         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
7764         callers.
7765
7766 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
7767
7768         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
7769
7770 2019-02-05  Tom Tromey  <tom@tromey.com>
7771
7772         * target.c (target_stack::unpush): Move assertion earlier.
7773
7774 2019-01-30  Tom Tromey  <tom@tromey.com>
7775
7776         PR python/23615:
7777         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
7778         (gdbpy_parse_and_eval): Likewise.
7779         * python/python-internal.h (gdbpy_allow_threads): New class.
7780
7781 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
7782
7783         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
7784         (aarch64_fbsd_fpregmap): Move earlier.
7785         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
7786         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7787         instead of individual calls to trad_frame_set_reg_addr.
7788         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
7789         earlier.
7790         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
7791         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7792         instead of individual calls to trad_frame_set_reg_addr.
7793
7794 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
7795
7796         * CONTRIBUTE: Replace contribution list with wiki link.
7797
7798 2019-01-25  Tom Tromey  <tom@tromey.com>
7799
7800         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
7801
7802 2019-01-25  Tom Tromey  <tom@tromey.com>
7803
7804         * xtensa-linux-nat.c: Fix common/ includes.
7805         * xml-support.h: Fix common/ includes.
7806         * xml-support.c: Fix common/ includes.
7807         * x86-linux-nat.c: Fix common/ includes.
7808         * windows-nat.c: Fix common/ includes.
7809         * varobj.h: Fix common/ includes.
7810         * varobj.c: Fix common/ includes.
7811         * value.c: Fix common/ includes.
7812         * valops.c: Fix common/ includes.
7813         * utils.c: Fix common/ includes.
7814         * unittests/xml-utils-selftests.c: Fix common/ includes.
7815         * unittests/utils-selftests.c: Fix common/ includes.
7816         * unittests/unpack-selftests.c: Fix common/ includes.
7817         * unittests/tracepoint-selftests.c: Fix common/ includes.
7818         * unittests/style-selftests.c: Fix common/ includes.
7819         * unittests/string_view-selftests.c: Fix common/ includes.
7820         * unittests/scoped_restore-selftests.c: Fix common/ includes.
7821         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
7822         * unittests/scoped_fd-selftests.c: Fix common/ includes.
7823         * unittests/rsp-low-selftests.c: Fix common/ includes.
7824         * unittests/parse-connection-spec-selftests.c: Fix common/
7825         includes.
7826         * unittests/optional-selftests.c: Fix common/ includes.
7827         * unittests/offset-type-selftests.c: Fix common/ includes.
7828         * unittests/observable-selftests.c: Fix common/ includes.
7829         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
7830         * unittests/memrange-selftests.c: Fix common/ includes.
7831         * unittests/memory-map-selftests.c: Fix common/ includes.
7832         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
7833         * unittests/function-view-selftests.c: Fix common/ includes.
7834         * unittests/environ-selftests.c: Fix common/ includes.
7835         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
7836         * unittests/common-utils-selftests.c: Fix common/ includes.
7837         * unittests/cli-utils-selftests.c: Fix common/ includes.
7838         * unittests/array-view-selftests.c: Fix common/ includes.
7839         * ui-file.c: Fix common/ includes.
7840         * tui/tui-io.c: Fix common/ includes.
7841         * tracepoint.h: Fix common/ includes.
7842         * tracepoint.c: Fix common/ includes.
7843         * tracefile-tfile.c: Fix common/ includes.
7844         * top.h: Fix common/ includes.
7845         * top.c: Fix common/ includes.
7846         * thread.c: Fix common/ includes.
7847         * target/waitstatus.h: Fix common/ includes.
7848         * target/waitstatus.c: Fix common/ includes.
7849         * target.h: Fix common/ includes.
7850         * target.c: Fix common/ includes.
7851         * target-memory.c: Fix common/ includes.
7852         * target-descriptions.c: Fix common/ includes.
7853         * symtab.h: Fix common/ includes.
7854         * symfile.c: Fix common/ includes.
7855         * stap-probe.c: Fix common/ includes.
7856         * spu-linux-nat.c: Fix common/ includes.
7857         * sparc-nat.c: Fix common/ includes.
7858         * source.c: Fix common/ includes.
7859         * solib.c: Fix common/ includes.
7860         * solib-target.c: Fix common/ includes.
7861         * ser-unix.c: Fix common/ includes.
7862         * ser-tcp.c: Fix common/ includes.
7863         * ser-pipe.c: Fix common/ includes.
7864         * ser-base.c: Fix common/ includes.
7865         * selftest-arch.c: Fix common/ includes.
7866         * s12z-tdep.c: Fix common/ includes.
7867         * rust-exp.y: Fix common/ includes.
7868         * rs6000-aix-tdep.c: Fix common/ includes.
7869         * riscv-tdep.c: Fix common/ includes.
7870         * remote.c: Fix common/ includes.
7871         * remote-notif.h: Fix common/ includes.
7872         * remote-fileio.h: Fix common/ includes.
7873         * remote-fileio.c: Fix common/ includes.
7874         * regcache.h: Fix common/ includes.
7875         * regcache.c: Fix common/ includes.
7876         * record-btrace.c: Fix common/ includes.
7877         * python/python.c: Fix common/ includes.
7878         * python/py-type.c: Fix common/ includes.
7879         * python/py-inferior.c: Fix common/ includes.
7880         * progspace.h: Fix common/ includes.
7881         * producer.c: Fix common/ includes.
7882         * procfs.c: Fix common/ includes.
7883         * proc-api.c: Fix common/ includes.
7884         * printcmd.c: Fix common/ includes.
7885         * ppc-linux-nat.c: Fix common/ includes.
7886         * parser-defs.h: Fix common/ includes.
7887         * osdata.c: Fix common/ includes.
7888         * obsd-nat.c: Fix common/ includes.
7889         * nat/x86-linux.c: Fix common/ includes.
7890         * nat/x86-linux-dregs.c: Fix common/ includes.
7891         * nat/x86-dregs.h: Fix common/ includes.
7892         * nat/x86-dregs.c: Fix common/ includes.
7893         * nat/ppc-linux.c: Fix common/ includes.
7894         * nat/mips-linux-watch.h: Fix common/ includes.
7895         * nat/mips-linux-watch.c: Fix common/ includes.
7896         * nat/linux-waitpid.c: Fix common/ includes.
7897         * nat/linux-ptrace.h: Fix common/ includes.
7898         * nat/linux-ptrace.c: Fix common/ includes.
7899         * nat/linux-procfs.c: Fix common/ includes.
7900         * nat/linux-personality.c: Fix common/ includes.
7901         * nat/linux-osdata.c: Fix common/ includes.
7902         * nat/linux-namespaces.c: Fix common/ includes.
7903         * nat/linux-btrace.h: Fix common/ includes.
7904         * nat/linux-btrace.c: Fix common/ includes.
7905         * nat/fork-inferior.c: Fix common/ includes.
7906         * nat/amd64-linux-siginfo.c: Fix common/ includes.
7907         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
7908         * nat/aarch64-linux.c: Fix common/ includes.
7909         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
7910         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
7911         * namespace.h: Fix common/ includes.
7912         * mips-linux-tdep.c: Fix common/ includes.
7913         * minsyms.c: Fix common/ includes.
7914         * mi/mi-parse.h: Fix common/ includes.
7915         * mi/mi-main.c: Fix common/ includes.
7916         * mi/mi-cmd-env.c: Fix common/ includes.
7917         * memrange.h: Fix common/ includes.
7918         * memattr.c: Fix common/ includes.
7919         * maint.h: Fix common/ includes.
7920         * maint.c: Fix common/ includes.
7921         * main.c: Fix common/ includes.
7922         * machoread.c: Fix common/ includes.
7923         * location.c: Fix common/ includes.
7924         * linux-thread-db.c: Fix common/ includes.
7925         * linux-nat.c: Fix common/ includes.
7926         * linux-fork.c: Fix common/ includes.
7927         * inline-frame.c: Fix common/ includes.
7928         * infrun.c: Fix common/ includes.
7929         * inflow.c: Fix common/ includes.
7930         * inferior.h: Fix common/ includes.
7931         * inferior.c: Fix common/ includes.
7932         * infcmd.c: Fix common/ includes.
7933         * inf-ptrace.c: Fix common/ includes.
7934         * inf-child.c: Fix common/ includes.
7935         * ia64-linux-nat.c: Fix common/ includes.
7936         * i387-tdep.c: Fix common/ includes.
7937         * i386-tdep.c: Fix common/ includes.
7938         * i386-linux-tdep.c: Fix common/ includes.
7939         * i386-linux-nat.c: Fix common/ includes.
7940         * i386-go32-tdep.c: Fix common/ includes.
7941         * i386-fbsd-tdep.c: Fix common/ includes.
7942         * i386-fbsd-nat.c: Fix common/ includes.
7943         * guile/scm-type.c: Fix common/ includes.
7944         * guile/guile.c: Fix common/ includes.
7945         * go32-nat.c: Fix common/ includes.
7946         * gnu-nat.c: Fix common/ includes.
7947         * gdbthread.h: Fix common/ includes.
7948         * gdbarch-selftests.c: Fix common/ includes.
7949         * gdb_usleep.c: Fix common/ includes.
7950         * gdb_select.h: Fix common/ includes.
7951         * gdb_bfd.c: Fix common/ includes.
7952         * gcore.c: Fix common/ includes.
7953         * fork-child.c: Fix common/ includes.
7954         * findvar.c: Fix common/ includes.
7955         * fbsd-nat.c: Fix common/ includes.
7956         * event-top.c: Fix common/ includes.
7957         * event-loop.c: Fix common/ includes.
7958         * dwarf2read.c: Fix common/ includes.
7959         * dwarf2loc.c: Fix common/ includes.
7960         * dwarf2-frame.c: Fix common/ includes.
7961         * dwarf-index-cache.c: Fix common/ includes.
7962         * dtrace-probe.c: Fix common/ includes.
7963         * disasm-selftests.c: Fix common/ includes.
7964         * defs.h: Fix common/ includes.
7965         * csky-tdep.c: Fix common/ includes.
7966         * cp-valprint.c: Fix common/ includes.
7967         * cp-support.h: Fix common/ includes.
7968         * cp-support.c: Fix common/ includes.
7969         * corelow.c: Fix common/ includes.
7970         * completer.h: Fix common/ includes.
7971         * completer.c: Fix common/ includes.
7972         * compile/compile.c: Fix common/ includes.
7973         * compile/compile-loc2c.c: Fix common/ includes.
7974         * compile/compile-cplus-types.c: Fix common/ includes.
7975         * compile/compile-cplus-symbols.c: Fix common/ includes.
7976         * command.h: Fix common/ includes.
7977         * cli/cli-dump.c: Fix common/ includes.
7978         * cli/cli-cmds.c: Fix common/ includes.
7979         * charset.c: Fix common/ includes.
7980         * build-id.c: Fix common/ includes.
7981         * btrace.h: Fix common/ includes.
7982         * btrace.c: Fix common/ includes.
7983         * breakpoint.h: Fix common/ includes.
7984         * breakpoint.c: Fix common/ includes.
7985         * ax.h:
7986         (enum agent_op): Fix common/ includes.
7987         * ax-general.c (struct aop_map): Fix common/ includes.
7988         * ax-gdb.c: Fix common/ includes.
7989         * auxv.c: Fix common/ includes.
7990         * auto-load.c: Fix common/ includes.
7991         * arm-tdep.c: Fix common/ includes.
7992         * arch/riscv.c: Fix common/ includes.
7993         * arch/ppc-linux-common.c: Fix common/ includes.
7994         * arch/i386.c: Fix common/ includes.
7995         * arch/arm.c: Fix common/ includes.
7996         * arch/arm-linux.c: Fix common/ includes.
7997         * arch/arm-get-next-pcs.c: Fix common/ includes.
7998         * arch/amd64.c: Fix common/ includes.
7999         * arch/aarch64.c: Fix common/ includes.
8000         * arch/aarch64-insn.c: Fix common/ includes.
8001         * arch-utils.c: Fix common/ includes.
8002         * amd64-windows-tdep.c: Fix common/ includes.
8003         * amd64-tdep.c: Fix common/ includes.
8004         * amd64-sol2-tdep.c: Fix common/ includes.
8005         * amd64-obsd-tdep.c: Fix common/ includes.
8006         * amd64-nbsd-tdep.c: Fix common/ includes.
8007         * amd64-linux-tdep.c: Fix common/ includes.
8008         * amd64-linux-nat.c: Fix common/ includes.
8009         * amd64-fbsd-tdep.c: Fix common/ includes.
8010         * amd64-fbsd-nat.c: Fix common/ includes.
8011         * amd64-dicos-tdep.c: Fix common/ includes.
8012         * amd64-darwin-tdep.c: Fix common/ includes.
8013         * agent.c: Fix common/ includes.
8014         * ada-lang.h: Fix common/ includes.
8015         * ada-lang.c: Fix common/ includes.
8016         * aarch64-tdep.c: Fix common/ includes.
8017
8018 2019-01-25  Tom Tromey  <tom@tromey.com>
8019
8020         * common/create-version.sh: Use common/version.h.
8021
8022 2019-01-24  Pedro Alves  <palves@redhat.com>
8023
8024         * infrun.c (signal_stop, signal_print, signal_program)
8025         (signal_catch, signal_pass): Now arrays instead of pointers.
8026         (update_signals_program_target, do_target_resume)
8027         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8028         * linux-nat.c (linux_nat_target::pass_signals)
8029         (linux_nat_target::create_inferior, linux_nat_target::attach):
8030         Adjust.
8031         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8032         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8033         * procfs.c (procfs_target::pass_signals): Adjust.
8034         * record-full.c (record_full_target::resume): Adjust.
8035         * remote.c (remote_target::pass_signals)
8036         (remote_target::program_signals): Adjust.
8037         * target-debug.h (target_debug_print_signals): Now takes a
8038         gdb::array_view as parameter.  Adjust.
8039         * target.h (target_ops) <pass_signals, program_signals>: Replace
8040         pointer and length parameters with gdb::array_view.
8041         (target_pass_signals, target_program_signals): Likewise.
8042         * target-delegates.c: Regenerate.
8043
8044 2019-01-24  Pedro Alves  <palves@redhat.com>
8045
8046         * common/forward-scope-exit.h
8047         (forward_scope_exit::forward_scope_exit): Pass arguments to
8048         m_bind_function directly, instead of creating a std::bind and
8049         copying that.
8050
8051 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8052
8053         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8054         for static members.
8055         (pass_in_v_vfp_candidate): Likewise.
8056
8057 2019-01-23  Tom Tromey  <tom@tromey.com>
8058             Pedro Alves  <palves@redhat.com>
8059
8060         * regcache.c (class regcache_invalidator): Remove.
8061         (regcache::raw_write): Use make_scope_exit.
8062
8063 2019-01-23  Tom Tromey  <tom@tromey.com>
8064
8065         * ui-out.h (class ui_out_emit_type): Update comment.
8066
8067 2019-01-23  Tom Tromey  <tom@tromey.com>
8068
8069         * infrun.c (fetch_inferior_event): Update comment.
8070
8071 2019-01-23  Tom Tromey  <tom@tromey.com>
8072             Pedro Alves  <palves@redhat.com>
8073
8074         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8075         parameter.
8076         (fetch_inferior_event): Use SCOPE_EXIT.
8077
8078
8079 2019-01-23  Tom Tromey  <tom@tromey.com>
8080             Pedro Alves  <palves@redhat.com>
8081
8082         * infrun.c (disable_thread_events): Delete.
8083         (stop_all_threads): Use SCOPE_EXIT.
8084
8085 2019-01-23  Tom Tromey  <tom@tromey.com>
8086             Pedro Alves  <palves@redhat.com>
8087
8088         * symfile.c: Include forward-scope-exit.h.
8089         (clear_symtab_users_cleanup): Replace forward declaration with
8090         a FORWARD_SCOPE_EXIT.
8091         (syms_from_objfile_1): Use the forward_scope_exit and
8092         gdb::optional instead of cleanup_function.
8093         (reread_symbols): Use the forward_scope_exit instead of
8094         cleanup_function.
8095         (clear_symtab_users_cleanup): Remove function.
8096
8097 2019-01-23  Tom Tromey  <tom@tromey.com>
8098             Pedro Alves  <palves@redhat.com>
8099
8100         * linux-nat.c: Include scope-exit.h.
8101         (cleanup_target_stop): Remove.
8102         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8103         SCOPE_EXIT.
8104
8105 2019-01-23  Tom Tromey  <tom@tromey.com>
8106             Pedro Alves  <palves@redhat.com>
8107
8108         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8109         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8110
8111 2019-01-23  Tom Tromey  <tom@tromey.com>
8112             Andrew Burgess  <andrew.burgess@embecosm.com>
8113             Pedro Alves  <palves@redhat.com>
8114
8115         * infrun.c (fetch_inferior_event): Use scope_exit.
8116         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8117         * top.c (execute_command): Use scope_exit.
8118         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8119         * utils.c (do_bpstat_clear_actions_cleanup)
8120         (make_bpstat_clear_actions_cleanup): Remove.
8121
8122 2019-01-23  Tom Tromey  <tom@tromey.com>
8123             Pedro Alves  <palves@redhat.com>
8124
8125         * infrun.c: Include "common/scope-exit.h"
8126         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8127         (wait_for_inferior): Use SCOPE_EXIT.
8128         (fetch_inferior_event): Use scope_exit.
8129
8130 2019-01-23  Tom Tromey  <tom@tromey.com>
8131             Pedro Alves  <palves@redhat.com>
8132
8133         * breakpoint.c (create_breakpoint): Remove cleanup.
8134
8135 2019-01-23  Tom Tromey  <tom@tromey.com>
8136             Andrew Burgess  <andrew.burgess@embecosm.com>
8137             Pedro Alves  <palves@redhat.com>
8138
8139 2019-01-23  Pedro Alves  <palves@redhat.com>
8140
8141         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8142
8143 2019-01-23  Pedro Alves  <palves@redhat.com>
8144             Andrew Burgess  <andrew.burgess@embecosm.com>
8145
8146         * gdbthread.h: Include "common/forward-scope-exit.h".
8147         (scoped_finish_thread_state): Redefine custom class in terms of
8148         forward_scope_exit.
8149
8150 2019-01-23  Pedro Alves  <palves@redhat.com>
8151             Andrew Burgess  <andrew.burgess@embecosm.com>
8152
8153         * common/forward-scope-exit.h: New file.
8154
8155 2019-01-23  Pedro Alves  <palves@redhat.com>
8156             Andrew Burgess  <andrew.burgess@embecosm.com>
8157             Tom Tromey  <tom@tromey.com>
8158
8159         * common/scope-exit.h: New file.
8160
8161 2019-01-23  Pedro Alves  <palves@redhat.com>
8162
8163         * common/preprocessor.h (ESC): Rename to ...
8164         (ESC_PARENS): ... this.
8165         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8166         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8167
8168 2019-01-23  Tom Tromey  <tom@tromey.com>
8169
8170         * language.h (class scoped_switch_to_sym_language_if_auto):
8171         Initialize m_lang in both cases.
8172
8173 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
8174
8175         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8176         with XCNEW.
8177
8178 2019-01-22  Tom Tromey  <tom@tromey.com>
8179
8180         * corelow.c: Do not include sys/file.h.
8181
8182 2019-01-22  Tom Tromey  <tom@tromey.com>
8183
8184         * tui/tui-wingeneral.h: Include gdb_curses.h.
8185
8186 2019-01-22  Tom Tromey  <tom@tromey.com>
8187
8188         * source-cache.h (class source_cache) <get_source_lines,
8189         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
8190
8191 2019-01-22  Tom Tromey  <tom@tromey.com>
8192
8193         * remote-fileio.h (struct remote_target): Declare.
8194
8195 2019-01-22  Tom Tromey  <tom@tromey.com>
8196
8197         * python/py-arch.c: Do not include py-ref.h.
8198         * python/py-bpevent.c: Do not include py-ref.h.
8199         * python/py-cmd.c: Do not include py-ref.h.
8200         * python/py-continueevent.c: Do not include py-ref.h.
8201         * python/py-event.h: Do not include py-ref.h.
8202         * python/py-evtregistry.c: Do not include py-ref.h.
8203         * python/py-finishbreakpoint.c: Do not include py-ref.h.
8204         * python/py-frame.c: Do not include py-ref.h.
8205         * python/py-framefilter.c: Do not include py-ref.h.
8206         * python/py-function.c: Do not include py-ref.h.
8207         * python/py-infevents.c: Do not include py-ref.h.
8208         * python/py-linetable.c: Do not include py-ref.h.
8209         * python/py-objfile.c: Do not include py-ref.h.
8210         * python/py-param.c: Do not include py-ref.h.
8211         * python/py-prettyprint.c: Do not include py-ref.h.
8212         * python/py-progspace.c: Do not include py-ref.h.
8213         * python/py-symbol.c: Do not include py-ref.h.
8214         * python/py-symtab.c: Do not include py-ref.h.
8215         * python/py-type.c: Do not include py-ref.h.
8216         * python/py-unwind.c: Do not include py-ref.h.
8217         * python/py-utils.c: Do not include py-ref.h.
8218         * python/py-value.c: Do not include py-ref.h.
8219         * python/py-varobj.c: Do not include py-ref.h.
8220         * python/py-xmethods.c: Do not include py-ref.h.
8221         * python/python.c: Do not include py-ref.h.
8222         * varobj.c: Do not include py-ref.h.
8223
8224 2019-01-22  Tom Tromey  <tom@tromey.com>
8225
8226         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
8227         keyword for bcache.
8228
8229 2019-01-22  Tom Tromey  <tom@tromey.com>
8230
8231         * compile/compile-cplus-types.c: Remove a comment by #include.
8232
8233 2019-01-22  Tom Tromey  <tom@tromey.com>
8234
8235         * compile/gcc-c-plugin.h: Include compile-internal.h.
8236
8237 2019-01-22  Tom Tromey  <tom@tromey.com>
8238
8239         * stabsread.c (EXTERN): Do not define.
8240         (symnum, next_symbol_text_func, processing_gcc_compilation)
8241         (within_function, global_sym_chain, global_stabs)
8242         (previous_stab_code, this_object_header_files)
8243         (n_this_object_header_files)
8244         (n_allocated_this_object_header_files): Define.
8245         * stabsread.h (EXTERN): Never define.  Use "extern".
8246
8247 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8248
8249         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
8250         history_value.
8251
8252 2019-01-21  Tom Tromey  <tom@tromey.com>
8253
8254         * ui-out.c: Fix includes.
8255         * tui/tui-source.c: Fix includes.
8256         * target.c: Fix includes.
8257         * remote.c: Fix includes.
8258         * regcache.c: Fix includes.
8259         * python/py-block.c: Fix includes.
8260         * printcmd.c: Fix includes.
8261         * or1k-tdep.c: Fix includes.
8262         * mi/mi-main.c: Fix includes.
8263         * m32r-tdep.c: Fix includes.
8264         * csky-tdep.c: Fix includes.
8265         * compile/compile-cplus-types.c: Fix includes.
8266         * cli/cli-interp.c: Fix includes.
8267
8268 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
8269
8270         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8271         for padding.
8272
8273 2019-01-16  Tom Tromey  <tom@tromey.com>
8274
8275         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
8276         earlier.
8277         (struct objfile) <msymbols_range>: Move from top level.
8278         <msymbols>: New method.
8279         (class objfile_msymbols): Remove.
8280         * symtab.c (default_collect_symbol_completion_matches_break_on):
8281         Update.
8282         * symmisc.c (dump_msymbols): Update.
8283         * stabsread.c (scan_file_globals): Update.
8284         * objc-lang.c (info_selectors_command, info_classes_command)
8285         (find_methods): Update.
8286         * minsyms.c (find_solib_trampoline_target): Update.
8287         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
8288         * coffread.c (coff_symfile_read): Update.
8289         * ada-lang.c (ada_lookup_simple_minsym)
8290         (ada_collect_symbol_completion_matches): Update.
8291
8292 2019-01-16  Tom Tromey  <tom@tromey.com>
8293
8294         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
8295         type.  Remove no-argument constructor.
8296         <iterator::operator++>: Simplify.
8297         <begin>: Update.
8298         <end>: Use minimal_symbol_count.
8299
8300 2019-01-16  Tom Tromey  <tom@tromey.com>
8301
8302         * objfiles.h (struct objfile) <psymtabs>: New method.
8303         (class objfile_psymtabs): Remove.
8304         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
8305         typedef.
8306         <range>: New method.
8307         (require_partial_symbols): Change return type.
8308         * psymtab.c (require_partial_symbols)
8309         (psym_expand_symtabs_matching): Update.
8310         * mdebugread.c (parse_partial_symbols): Update.
8311         * dbxread.c (dbx_end_psymtab): Update.
8312
8313 2019-01-15  Tom Tromey  <tom@tromey.com>
8314
8315         * symtab.c (lookup_objfile_from_block)
8316         (lookup_symbol_in_objfile_symtabs)
8317         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
8318         (find_line_symtab, info_sources_command)
8319         (default_collect_symbol_completion_matches_break_on)
8320         (make_source_files_completion_list): Update.
8321         * symmisc.c (print_objfile_statistics, dump_objfile)
8322         (maintenance_print_symbols, maintenance_info_symtabs)
8323         (maintenance_check_symtabs, maintenance_info_line_tables):
8324         Update.
8325         * source.c (select_source_symtab)
8326         (forget_cached_source_info_for_objfile): Update.
8327         * objfiles.h (class objfile_compunits): Remove.
8328         (struct objfile) <compunits_range>: New typedef.
8329         (compunits): New method.
8330         * objfiles.c (objfile_relocate1): Update.
8331         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8332         * maint.c (count_symtabs_and_blocks): Update.
8333         * linespec.c (iterate_over_all_matching_symtabs): Update.
8334         * cp-support.c (add_symbol_overload_list_qualified): Update.
8335         * coffread.c (coff_symtab_read): Update.
8336         * ada-lang.c (add_nonlocal_symbols)
8337         (ada_collect_symbol_completion_matches)
8338         (ada_add_global_exceptions): Update.
8339
8340 2019-01-15  Tom Tromey  <tom@tromey.com>
8341
8342         * progspace.h (program_space) <objfiles_safe_range>: New
8343         typedef.
8344         <objfiles_safe>: New method.
8345         * objfiles.h (class all_objfiles_safe): Remove.
8346         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
8347         * jit.c (jit_inferior_exit_hook): Update.
8348
8349 2019-01-17  Tom Tromey  <tom@tromey.com>
8350
8351         * progspace.h (program_space) <objfiles_range>: New typedef.
8352         <objfiles>: New method.
8353         <objfiles_head>: Rename from objfiles.
8354         (object_files): Update.
8355         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
8356         * guile/scm-pretty-print.c
8357         (ppscm_find_pretty_printer_from_objfiles): Update.
8358         * guile/scm-objfile.c (gdbscm_objfiles): Update.
8359         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
8360         Update.
8361         * python/py-progspace.c (pspy_get_objfiles): Update.
8362         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8363         Update.
8364         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8365         (objfpy_lookup_objfile_by_build_id): Update.
8366         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8367         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8368         Update.
8369         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8370         (expand_symtab_containing_pc, lookup_objfile_from_block)
8371         (lookup_static_symbol, basic_lookup_transparent_type)
8372         (find_pc_sect_compunit_symtab, find_symbol_at_address)
8373         (find_line_symtab, info_sources_command)
8374         (default_collect_symbol_completion_matches_break_on)
8375         (make_source_files_completion_list, find_main_name): Update.
8376         * symmisc.c (print_symbol_bcache_statistics)
8377         (print_objfile_statistics, maintenance_print_symbols)
8378         (maintenance_print_msymbols, maintenance_print_objfiles)
8379         (maintenance_info_symtabs, maintenance_check_symtabs)
8380         (maintenance_expand_symtabs, maintenance_info_line_tables):
8381         Update.
8382         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
8383         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
8384         (map_overlay_command, unmap_overlay_command)
8385         (simple_overlay_update, expand_symtabs_matching)
8386         (map_symbol_filenames): Update.
8387         * symfile-debug.c (set_debug_symfile): Update.
8388         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
8389         Update.
8390         * source.c (select_source_symtab, forget_cached_source_info):
8391         Update.
8392         * solib.c (solib_read_symbols): Update.
8393         * solib-spu.c (append_ocl_sos): Update.
8394         * psymtab.c (maintenance_print_psymbols)
8395         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
8396         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
8397         * printcmd.c (info_symbol_command): Update.
8398         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
8399         Update.
8400         * objfiles.h (class all_objfiles): Remove.
8401         * objfiles.c (have_partial_symbols, have_full_symbols)
8402         (have_minimal_symbols, qsort_cmp, update_section_map)
8403         (shared_objfile_contains_address_p)
8404         (default_iterate_over_objfiles_in_search_order): Update.
8405         * objc-lang.c (info_selectors_command, info_classes_command)
8406         (find_methods): Update.
8407         * minsyms.c (find_solib_trampoline_target): Update.
8408         * maint.c (maintenance_info_sections)
8409         (maintenance_translate_address, count_symtabs_and_blocks):
8410         Update.
8411         * main.c (captured_main_1): Update.
8412         * linux-thread-db.c (try_thread_db_load_from_pdir)
8413         (has_libpthread): Update.
8414         * linespec.c (iterate_over_all_matching_symtabs)
8415         (search_minsyms_for_name): Update.
8416         * jit.c (jit_find_objf_with_entry_addr): Update.
8417         * hppa-tdep.c (find_unwind_entry)
8418         (hppa_lookup_stub_minimal_symbol): Update.
8419         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
8420         Update.
8421         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8422         (elf_gnu_ifunc_resolve_by_got): Update.
8423         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
8424         * dwarf-index-write.c (save_gdb_index_command): Update.
8425         * cp-support.c (add_symbol_overload_list_qualified): Update.
8426         * breakpoint.c (create_overlay_event_breakpoint)
8427         (create_longjmp_master_breakpoint)
8428         (create_std_terminate_master_breakpoint)
8429         (create_exception_master_breakpoint): Update.
8430         * blockframe.c (find_pc_partial_function): Update.
8431         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
8432         (ada_collect_symbol_completion_matches)
8433         (ada_add_global_exceptions): Update.
8434
8435 2019-01-17  Tom Tromey  <tom@tromey.com>
8436
8437         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
8438         declare VEC.
8439         (solib_target_parse_libraries): Change return type.
8440         (library_list_start_segment, library_list_start_section)
8441         (library_list_end_library, library_list_start_library); Update.
8442         (solib_target_free_library_list): Remove.
8443         (solib_target_parse_libraries): Remove cleanup.  Change return
8444         type.
8445         (solib_target_current_sos): Update.
8446
8447 2019-01-17  Tom Tromey  <tromey@bapiya>
8448
8449         * valprint.c: Replace "the the" with "the".
8450         * symtab.c: Replace "the the" with "the".
8451         * solib.c: Replace "the the" with "the".
8452         * solib-dsbt.c: Replace "the the" with "the".
8453         * linespec.c: Replace "the the" with "the".
8454         * dwarf2loc.h: Replace "the the" with "the".
8455         * amd64-windows-tdep.c: Replace "the the" with "the".
8456         * aarch64-tdep.c: Replace "the the" with "the".
8457
8458 2019-01-16  Keith Seitz  <keiths@redhat.com>
8459
8460         PR gdb/23773
8461         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
8462         <builder>: Rename to ..
8463         <m_builder>: ... this and make private.
8464         (dwarf2_cu::get_builder): New method.  Change all users of
8465         `builder' to use this method.
8466         (dwarf2_start_symtab): Move to ...
8467         (dwarf2_cu::start_symtab): ... here.  Update all callers
8468         (setup_type_unit_groups): Move to ...
8469         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
8470         callers.
8471         (dwarf2_cu::reset_builder): New method.
8472         (process_full_compunit, process_full_type_unit): Use
8473         dwarf2_cu::reset_builder.
8474         (follow_die_offset): Record the ancestor CU if it is different
8475         from the followed DIE's CU.
8476         (follow_die_sig_1): Likewise.
8477
8478 2019-01-15  Tom Tromey  <tom@tromey.com>
8479
8480         * remote.c (class remote_state) <buf>: Now a char_vector.
8481         <buf_size>: Remove.
8482         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
8483         parameter.
8484         (remote_target::getpkt_or_notif_sane_1)
8485         (remote_target::getpkt_sane)
8486         (remote_target::getpkt_or_notif_sane): Likewise.
8487         (class remote_target) <putpkt>: New overload.
8488         (remote_target::read_frame): Change type of "buf_p".  Remove
8489         sizeof_p parameter.
8490         (packet_ok): New overload.
8491         (packet_check_result): New overload.
8492         Update all uses.
8493
8494 2019-01-14  Tom Tromey  <tom@tromey.com>
8495
8496         * remote-notif.c (handle_notification, remote_notif_ack)
8497         (remote_notif_parse): Make "buf" const.
8498         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
8499         const.
8500         (remote_notif_parse, remote_notif_ack, handle_notification):
8501         Likewise.
8502         * remote.c (remote_notif_stop_parse): Make "buf" const.
8503         (remote_target::remote_parse_stop_reply): Make "buf" const.
8504         (remote_notif_stop_ack): Make "buf" const.
8505
8506 2019-01-14  Tom Tromey  <tom@tromey.com>
8507
8508         * remote.c (remote_console_output): Make parameter const.
8509
8510 2019-01-14  Tom Tromey  <tom@tromey.com>
8511
8512         * target-debug.h (target_debug_print_signals): Constify.
8513         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
8514         * procfs.c (procfs_target::pass_signals): Update.
8515         * linux-nat.c (linux_nat_target::pass_signals): Update.
8516         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
8517         * target-delegates.c: Rebuild.
8518         * remote.c (remote_target::program_signals): Update.
8519         (remote_target::pass_signals): Update.
8520         * target.c (target_pass_signals): Constify argument.
8521         (target_program_signals): Likewise.
8522         * target.h (struct target_ops) <pass_signals, program_signals>:
8523         Constify argument.
8524         (target_pass_signals, target_program_signals): Constify argument.
8525
8526 2019-01-14  Tom Tromey  <tom@tromey.com>
8527
8528         PR tui/28819:
8529         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
8530
8531 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
8532
8533         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
8534         field.
8535         * rs6000-tdep.c: Include reggroups.h.
8536         (IS_V_ALIAS_PSEUDOREG): Define.
8537         (rs6000_register_name): Return names for the "vX" aliases.
8538         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
8539         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
8540         aliases.  Call default_register_reggroup_p for all other
8541         pseudo-registers.
8542         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
8543         New functions.
8544         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
8545         Handle "vX" aliases.
8546         (v_alias_pseudo_register_collect): New function.
8547         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
8548         (rs6000_gdbarch_init): Initialize "vX" aliases as
8549         pseudo-registers.  Restore registration of
8550         rs6000_pseudo_register_reggroup_p with
8551         set_tdesc_pseudo_register_reggroup_p.
8552
8553 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
8554
8555         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
8556         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
8557         set_gdbarch_num_pseudo_regs.
8558
8559 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8560
8561         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
8562         Remove arg prefixname, add do_set and do_show.
8563         Add member functions set_list and show_list.
8564         * cli/cli-style.c (class cli_style_option): Update accordingly.
8565         (style_set_list): Move to file scope.
8566         (style_show_list): Likewise.
8567         (set_style): Call help_list.
8568         (show_style): Call cmd_show_list.
8569         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
8570         Update to use the new macro.
8571
8572 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
8573
8574         * ada-lang.c (_initialize_ada_language): Expand the help text
8575         for the "catch exception" command.
8576
8577 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8578
8579         * symtab.c (matching_obj_sections): Initialize obj,
8580         declare it closer to its usage.
8581
8582 2019-01-10  Tom Tromey  <tom@tromey.com>
8583
8584         * thread-iter.h (inf_threads_iterator): Use next_iterator.
8585         (basic_inf_threads_range): Remove.
8586         (inf_threads_range, inf_non_exited_threads_range)
8587         (safe_inf_threads_range): Use next_adapter.
8588
8589 2019-01-10  Keith Seitz  <keiths@redhat.com>
8590
8591         PR gdb/23712
8592         PR symtab/23010
8593         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
8594         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
8595
8596 2019-01-10  Keith Seitz  <keiths@redhat.com>
8597
8598         PR gdb/23712
8599         PR symtab/23010
8600         * dictionary.c (pending_to_vector): Remove.
8601         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8602         Remove _1 suffix, replacing functions of the same name.  Update
8603         all callers.
8604         (dict_create_hashed, dict_create_hashed_expandable)
8605         (dict_create_linear, dict_create_linear_expandable, dict_free)
8606         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
8607         Make functions static.
8608
8609 2019-01-10  Keith Seitz  <keiths@redhat.com>
8610
8611         PR gdb/23712
8612         PR symtab/23010
8613         * dictionary.h (struct dictionary): Replace declaration with
8614         multidictionary.
8615         (dict_create_hashed, dict_create_hashed_expandable)
8616         (dict_create_linear, dict_create_linear_expandable)
8617         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
8618         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
8619         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
8620         taking multidictionary argument.
8621         [ALL_DICT_SYMBOLS]: Update for multidictionary.
8622         * block.h (struct block) <dict>: Change to multidictionary
8623         and rename `multidict'.
8624         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
8625         symmisc.c: Update all dictionary references to multidictionary.
8626
8627 2019-01-10  Keith Seitz  <keiths@redhat.com>
8628
8629         PR gdb/23712
8630         PR symtab/23010
8631         * dictionary.c: Include unordered_map.
8632         (pending_to_vector): New function.
8633         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8634         Rewrite the non-"_1" functions to take vector instead
8635         of linked list.
8636         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
8637         "new" _1 versions of the same name.
8638         (multidictionary): Define.
8639         (std::hash<enum language): New definition.
8640         (collate_pending_symbols_by_language, mdict_create_hashed)
8641         (mdict_create_hashed_expandable, mdict_create_linear)
8642         (mdict_create_linear_expandable, mdict_free)
8643         (find_language_dictionary, create_new_language_dictionary)
8644         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
8645         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
8646         (mdict_size, mdict_empty): New functions.
8647         * dictionary.h (mdict_iterator): Define.
8648
8649 2019-01-10  Pedro Alves  <palves@redhat.com>
8650
8651         * breakpoint.c (read_uploaded_action)
8652         (create_tracepoint_from_upload): Adjust to use
8653         gdb::unique_xmalloc_ptr.
8654         * ctf.c (ctf_write_uploaded_tp):
8655         (SET_ARRAY_FIELD): Use emplace_back.
8656         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
8657         * tracefile-tfile.c (tfile_write_uploaded_tp):
8658         * tracepoint.c (parse_tracepoint_definition): Adjust to use
8659         gdb::unique_xmalloc_ptr.
8660         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
8661         at_string, cond_string, cmd_strings>: Replace char pointers
8662         with gdb::unique_xmalloc_ptr.
8663
8664 2019-01-10  Pedro Alves  <palves@redhat.com>
8665
8666         * solib-target.c (library_list_start_library): Don't xstrdup name.
8667
8668 2019-01-10  Pedro Alves  <palves@redhat.com>
8669
8670         * mdebugread.c (parse_partial_symbols): Use
8671         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
8672
8673 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8674
8675         * linux-fork.c (scoped_switch_fork_info)
8676         <~scoped_switch_fork_info>: Fix incorrect variable name.
8677
8678 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8679
8680         * linux-fork.c (scoped_switch_fork_info)
8681         <scoped_switch_fork_info>: Make explicit.
8682         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
8683
8684 2019-01-10  Tom Tromey  <tom@tromey.com>
8685
8686         * objfiles.h (objfile::reset_psymtabs): Update.
8687         * objfiles.c (objfile::objfile): Update.
8688         * psymtab.h (psymtab_storage::obstack): Update.
8689         (psymtab_storage::m_obstack): Use gdb::optional.
8690         (class psymtab_storage): Update comment.  Remove objfile
8691         parameter.
8692         * psymtab.c (psymtab_storage::psymtab_storage): Update.
8693
8694 2019-01-10  Tom Tromey  <tom@tromey.com>
8695
8696         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
8697         <free_psymtabs>: Now private.
8698         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
8699         (allocate_psymtab): Use new method.
8700
8701 2019-01-10  Tom Tromey  <tom@tromey.com>
8702
8703         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
8704         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
8705         * mdebugread.c (parse_partial_symbols): Use
8706         allocate_dependencies.
8707         * dwarf2read.c (dwarf2_create_include_psymtab): Use
8708         allocate_dependencies.
8709         (process_psymtab_comp_unit_reader)
8710         (build_type_psymtab_dependencies): Likewise.
8711         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
8712
8713 2019-01-10  Tom Tromey  <tom@tromey.com>
8714
8715         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
8716         PSYMBOL_SET_LANGUAGE.
8717         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
8718
8719 2019-01-10  Tom Tromey  <tom@tromey.com>
8720
8721         * psymtab.h (psymtab_storage::obstack): New method.
8722         <m_obstack>: Rename from obstack; now private.
8723         * psymtab.c (psymtab_storage): Update.
8724         * dwarf2read.c (create_addrmap_from_index)
8725         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
8726         Update.
8727
8728 2019-01-10  Tom Tromey  <tom@tromey.com>
8729
8730         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
8731         * objfiles.h (objfile::reset_psymtabs): New method.
8732
8733 2019-01-10  Tom Tromey  <tom@tromey.com>
8734
8735         * symmisc.c (print_symbol_bcache_statistics): Update.
8736         (print_objfile_statistics): Update.
8737         * symfile.c (reread_symbols): Update.
8738         * psymtab.h (class psymtab_storage): New.
8739         * psymtab.c (psymtab_storage): New constructor.
8740         (~psymtab_storage): New destructor.
8741         (require_partial_symbols): Update.
8742         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
8743         (find_pc_sect_psymtab, find_pc_sect_psymbol)
8744         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
8745         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
8746         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
8747         (start_psymtab_common, end_psymtab_common)
8748         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
8749         (allocate_psymtab): Update.
8750         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
8751         Update.
8752         (dump_psymtab_addrmap, maintenance_print_psymbols)
8753         (maintenance_check_psymtabs): Update.
8754         (class objfile_psymtabs): Move to objfiles.h.
8755         * psympriv.h (discard_psymtab): Now inline.
8756         (psymtab_discarder::psymtab_discarder): Update.
8757         (psymtab_discarder::~psymtab_discarder): Update.
8758         (ALL_OBJFILE_PSYMTABS): Rewrite.
8759         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
8760         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
8761         Remove fields.
8762         <partial_symtabs>: New field.
8763         (class objfile_psymtabs): Move from psymtab.h.  Update.
8764         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
8765         psymbol_cache.
8766         (objfile::~objfile): Don't destroy psymbol_cache.
8767         * mdebugread.c (parse_partial_symbols): Update.
8768         * dwarf2read.c (create_addrmap_from_index)
8769         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
8770         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
8771         (add_partial_subprogram, dwarf2_ranges_read): Update.
8772         * dwarf-index-write.c (write_address_map)
8773         (write_one_signatured_type, recursively_write_psymbols)
8774         (class debug_names, class debug_names, write_psymtabs_to_index):
8775         Update.
8776
8777 2019-01-10  Tom Tromey  <tom@tromey.com>
8778
8779         * symtab.h (SYMBOL_SET_NAMES): Update.
8780         (symbol_set_names): Update.
8781         (MSYMBOL_SET_NAMES): Update.
8782         * symtab.c (symbol_set_names): Change argument to be an
8783         objfile_per_bfd_storage.
8784         * psymtab.c (add_psymbol_to_bcache): Update.
8785         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
8786
8787 2019-01-10  Tom Tromey  <tom@tromey.com>
8788
8789         * symtab.c (create_demangled_names_hash): Change argument to be an
8790         objfile_per_bfd_storage.
8791         (symbol_set_names): Update.
8792
8793 2019-01-10  Tom Tromey  <tom@tromey.com>
8794
8795         * xcoffread.c (xcoff_initial_scan): Unconditionally call
8796         init_psymbol_list.
8797         * psymtab.c (init_psymbol_list): Do nothing if already called.
8798         * psympriv.h (init_psymbol_list): Add comment.
8799         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
8800         init_psymbol_list.
8801         * dbxread.c (dbx_symfile_read): Unconditionally call
8802         init_psymbol_list.
8803
8804 2019-01-10  Tom Tromey  <tom@tromey.com>
8805
8806         * xcoffread.c (scan_xcoff_symtab): Update.
8807         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
8808         "where".
8809         * mdebugread.c (parse_partial_symbols)
8810         (handle_psymbol_enumerators): Update.
8811         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
8812         * dbxread.c (read_dbx_symtab): Update.
8813         * psympriv.h (psymbol_placement): New enum.
8814         (add_psymbol_to_list): Update.
8815
8816 2019-01-10  Tom Tromey  <tom@tromey.com>
8817
8818         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
8819         static_psymbols parameters.
8820         (scan_xcoff_symtab): Update.
8821         * psymtab.c (start_psymtab_common): Remove global_psymbols and
8822         static_psymbols parameters.
8823         * psympriv.h (start_psymtab_common): Update.
8824         * mdebugread.c (parse_partial_symbols): Update.
8825         * dwarf2read.c (create_partial_symtab): Update.
8826         * dbxread.c (read_dbx_symtab): Update.
8827         (start_psymtab): Remove global_psymbols and static_psymbols
8828         parameters.
8829
8830 2019-01-10  Tom Tromey  <tom@tromey.com>
8831
8832         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
8833         * psymtab.c (allocate_psymtab): Add comment.
8834         * psympriv.h (allocate_psymtab): Add comment.
8835         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
8836         initializations.
8837         * dbxread.c (dbx_end_psymtab): Remove some initializations.
8838
8839 2019-01-10  Tom Tromey  <tom@tromey.com>
8840
8841         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8842         Don't declare.
8843         * mipsread.c: Include mdebugread.h.
8844         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8845         Declare.
8846         * elfread.c: Include mdebugread.h.
8847
8848 2019-01-09  Tom Tromey  <tom@tromey.com>
8849
8850         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
8851         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
8852         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
8853         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
8854         (psym_lookup_symbol, psym_find_last_source_symtab)
8855         (psym_forget_cached_source_info, psym_print_stats)
8856         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
8857         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
8858         (psym_map_matching_symbols, psym_expand_symtabs_matching)
8859         (psym_find_compunit_symtab_by_address)
8860         (maintenance_print_psymbols, maintenance_info_psymtabs)
8861         (maintenance_check_psymtabs): Use ranged for.
8862         * psymtab.h (class objfile_psymtabs): New.
8863         (require_partial_symbols): Return objfile_psymtabs.
8864         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
8865
8866 2019-01-09  Tom Tromey  <tom@tromey.com>
8867
8868         * symfile.c (overlay_invalidate_all, find_pc_overlay)
8869         (find_pc_mapped_section, list_overlays_command)
8870         (map_overlay_command, unmap_overlay_command)
8871         (simple_overlay_update): Use all_objfiles.
8872         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
8873         * printcmd.c (info_symbol_command): Use all_objfiles.
8874         * objfiles.h (ALL_OBJSECTIONS): Remove.
8875         * maint.c (maintenance_translate_address): Use all_objfiles.
8876         * gcore.c (gcore_create_callback): Use all_objfiles.
8877         (objfile_find_memory_regions): Likewise.
8878
8879 2019-01-09  Tom Tromey  <tom@tromey.com>
8880
8881         * symtab.c (find_line_symtab, info_sources_command)
8882         (make_source_files_completion_list): Use objfile_compunits.
8883         * source.c (select_source_symtab): Use objfile_compunits.
8884         * objfiles.h (struct objfile): Update comment.
8885         (ALL_OBJFILES): Remove.
8886         (ALL_FILETABS): Remove.
8887         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
8888         objfile_compunits.
8889
8890 2019-01-09  Tom Tromey  <tom@tromey.com>
8891
8892         * symmisc.c (print_objfile_statistics, dump_objfile)
8893         (maintenance_print_symbols): Use compunit_filetabs.
8894         * source.c (forget_cached_source_info_for_objfile): Use
8895         compunit_filetabs.
8896         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
8897         (ALL_FILETABS): Use compunit_filetabs.
8898         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
8899         * coffread.c (coff_symtab_read): Use compunit_filetabs.
8900
8901 2019-01-09  Tom Tromey  <tom@tromey.com>
8902
8903         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
8904         (compunit_filetabs): New.
8905         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
8906         compunit_filetabs.
8907         (info_sources_command, make_source_files_completion_list): Remove
8908         declaration.
8909         * symmisc.c (print_objfile_statistics, dump_objfile)
8910         (maintenance_print_symbols): Remove declaration.
8911         (maintenance_info_symtabs): Use compunit_filetabs.
8912         (maintenance_info_line_tables): Likewise.
8913         * source.c (select_source_symtab): Change local variable name.
8914         (forget_cached_source_info_for_objfile): Remove declaration.
8915         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
8916         * objfiles.c (objfile_relocate1): Remove declaration.
8917         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8918         declaration.
8919         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
8920         * coffread.c (coff_symtab_read): Remove declaration.
8921         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
8922         compunit_filetabs.
8923
8924 2019-01-09  Tom Tromey  <tom@tromey.com>
8925
8926         * symtab.c (lookup_objfile_from_block)
8927         (find_pc_sect_compunit_symtab, search_symbols)
8928         (default_collect_symbol_completion_matches_break_on): Use
8929         objfile_compunits.
8930         * objfiles.h (ALL_COMPUNITS): Remove.
8931         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
8932         * cp-support.c (add_symbol_overload_list_qualified): Use
8933         objfile_compunits.
8934         * ada-lang.c (ada_collect_symbol_completion_matches)
8935         (ada_add_global_exceptions): Use objfile_compunits.
8936
8937 2019-01-09  Tom Tromey  <tom@tromey.com>
8938
8939         * source.c (select_source_symtab)
8940         (forget_cached_source_info_for_objfile): Remove declaration.
8941         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8942         declaration.
8943         * maint.c (count_symtabs_and_blocks): Remove declaration.
8944         * cp-support.c (add_symbol_overload_list_qualified): Remove
8945         declaration.
8946         * coffread.c (coff_symtab_read): Remove declaration.
8947         * symtab.c (lookup_symbol_in_objfile_symtabs)
8948         (basic_lookup_transparent_type_1): Use objfile_compunits.
8949         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
8950         (info_sources_command, search_symbols)
8951         (default_collect_symbol_completion_matches_break_on)
8952         (make_source_files_completion_list): Remove declaration.
8953         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
8954         (ada_collect_symbol_completion_matches)
8955         (ada_add_global_exceptions): Remove declaration.
8956         * linespec.c (iterate_over_all_matching_symtabs): Use
8957         objfile_compunits.
8958         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
8959         (class objfile_compunits): New.
8960         (ALL_COMPUNITS): Use objfile_compunits.
8961         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
8962         (maintenance_check_symtabs, maintenance_info_line_tables): Use
8963         objfile_compunits.
8964         * objfiles.c (objfile_relocate1): Use objfile_compunits.
8965
8966 2019-01-09  Tom Tromey  <tom@tromey.com>
8967
8968         * symtab.c (search_symbols)
8969         (default_collect_symbol_completion_matches_break_on): Use
8970         objfile_msymbols.
8971         * ada-lang.c (ada_lookup_simple_minsym)
8972         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
8973         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
8974         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
8975         objfile_msymbols.
8976         * coffread.c (coff_symfile_read): Use objfile_msymbols.
8977         * symmisc.c (dump_msymbols): Use objfile_msymbols.
8978         * objc-lang.c (find_methods): Use objfile_msymbols.
8979         (info_selectors_command, info_classes_command): Likewise.
8980         * stabsread.c (scan_file_globals): Use objfile_msymbols.
8981         * objfiles.h (class objfile_msymbols): New.
8982         (ALL_OBJFILE_MSYMBOLS): Remove.
8983         (ALL_MSYMBOLS): Remove.
8984
8985 2019-01-09  Tom Tromey  <tom@tromey.com>
8986
8987         * common/next-iterator.h (next_adapter): Add Iterator template
8988         parameter.
8989         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
8990         (class all_objfiles_safe): New.
8991         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
8992         * objfiles.c (put_objfile_before): Update comment.
8993         (add_separate_debug_objfile): Likewise.
8994         (free_all_objfiles): Use all_objfiles_safe.
8995         (objfile_purge_solibs): Likewise.
8996
8997 2019-01-09  Tom Tromey  <tom@tromey.com>
8998
8999         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9000         (expand_symtab_containing_pc, lookup_static_symbol)
9001         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9002         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9003         all_objfiles.
9004         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9005         * breakpoint.c (create_overlay_event_breakpoint)
9006         (create_longjmp_master_breakpoint)
9007         (create_std_terminate_master_breakpoint)
9008         (create_exception_master_breakpoint): Use all_objfiles.
9009         * linux-thread-db.c (try_thread_db_load_from_pdir)
9010         (has_libpthread): Use all_objfiles.
9011         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9012         * linespec.c (iterate_over_all_matching_symtabs)
9013         (search_minsyms_for_name): Use all_objfiles.
9014         * maint.c (maintenance_info_sections): Use all_objfiles.
9015         * main.c (captured_main_1): Use all_objfiles.
9016         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9017         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9018         * guile/scm-pretty-print.c
9019         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9020         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9021         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9022         (maintenance_print_msymbols): Use all_objfiles.
9023         * source.c (select_source_symtab): Use all_objfiles.
9024         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9025         * symfile.c (remove_symbol_file_command)
9026         (expand_symtabs_matching, map_symbol_filenames): Use
9027         all_objfiles.
9028         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9029         all_objfiles.
9030         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9031         * objc-lang.c (find_methods): Use all_objfiles.
9032         * objfiles.c (have_partial_symbols, have_full_symbols)
9033         (have_minimal_symbols, qsort_cmp)
9034         (default_iterate_over_objfiles_in_search_order): Use
9035         all_objfiles.
9036         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9037         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9038         (maintenance_check_psymtabs): Use all_objfiles.
9039         (ALL_PSYMTABS): Remove.
9040         * compile/compile-object-run.c (do_module_cleanup): Use
9041         all_objfiles.
9042         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9043         * cp-support.c (add_symbol_overload_list_qualified): Use
9044         all_objfiles.
9045         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9046         Use all_objfiles.
9047         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9048         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9049         all_objfiles.
9050         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9051         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9052         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9053         Uses all_objfiles.
9054         * solib.c (solib_read_symbols): Use all_objfiles
9055
9056 2019-01-09  Tom Tromey  <tom@tromey.com>
9057
9058         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9059         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9060         all_objfiles.
9061         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9062         * symmisc.c (print_symbol_bcache_statistics)
9063         (print_objfile_statistics, maintenance_print_objfiles)
9064         (maintenance_info_symtabs, maintenance_check_symtabs)
9065         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9066         all_objfiles.
9067         * source.c (forget_cached_source_info): Use all_objfiles.
9068         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9069         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9070         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9071         * objfiles.c (update_section_map): Use all_objfiles.
9072         (shared_objfile_contains_address_p): Likewise.
9073         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9074         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9075
9076 2019-01-09  Tom Tromey  <tom@tromey.com>
9077
9078         * common/next-iterator.h: New file.
9079         * objfiles.h (class all_objfiles): New.
9080         (struct objfile_iterator): New.
9081
9082 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9083
9084         * NEWS: Move the description of the changed "frame", "select-frame",
9085          and "info frame" commands to the Changed commands section.
9086
9087 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9088
9089         * gdbtypes.c (check_stub_method_group): Remove handling of old
9090         mangling schemes.
9091         * linespec.c (find_methods): Likewise.
9092         * stabsread.c (read_member_functions): Likewise.
9093         * valops.c (search_struct_method): Likewise.
9094         (value_struct_elt_for_reference): Likewise.
9095         * NEWS: Mention this change.
9096
9097 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9098
9099         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9100         print_source_lines.
9101         * source.c (print_source_lines_base): Update line number check.
9102         (print_source_lines): New function.
9103         (source_lines_range::source_lines_range): New function.
9104         * source.h (class source_lines_range): New class.
9105         (print_source_lines): New declaration.
9106
9107 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9108
9109         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9110
9111 2019-01-08  Tom Tromey  <tom@tromey.com>
9112             Simon Marchi  <simon.marchi@ericsson.com>
9113
9114         PR gdb/24060
9115         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9116         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9117         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9118         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9119         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9120         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9121
9122 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9123
9124         * source.c (select_source_symtab): Move header comment to
9125         declaration in source.h.
9126         (forget_cached_source_info_for_objfile): Likewise.
9127         (forget_cached_source_info): Likewise.
9128         (identify_source_line): Likewise.
9129         * source.h (identify_source_line): Move declaration from symtab.h
9130         and add comment from source.c
9131         (print_source_lines): Likewise.
9132         (forget_cached_source_info_for_objfile): Likewise.
9133         (forget_cached_source_info): Likewise.
9134         (select_source_symtab): Likewise.
9135         (enum print_source_lines_flag): Move definition from symtab.h.
9136         * symtab.h (identify_source_line): Move declaration to source.h.
9137         (print_source_lines): Likewise.
9138         (forget_cached_source_info_for_objfile): Likewise.
9139         (forget_cached_source_info): Likewise.
9140         (select_source_symtab): Likewise.
9141         (enum print_source_lines_flag): Move definition to source.h.
9142         * tui/tui-hooks.c: Add 'source.h' include.
9143
9144 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9145
9146         * source.c (print_source_lines_base): Handle requests to print
9147         reverse line number sequences, and guard against empty lines
9148         string.
9149
9150 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9151
9152         * source.c (print_source_lines_base): Fix skip of '\r' if next
9153         character is '\n'.
9154
9155 2019-01-06  Tom Tromey  <tom@tromey.com>
9156
9157         * c-exp.y (struct c_parse_state) <macro_original_text,
9158         expansion_obstack>: New member.
9159         (macro_original_text, expansion_obstack): Remove globals.
9160         (scan_macro_expansion, scanning_macro_expansion)
9161         (finished_macro_expansion): Update.
9162         (scan_macro_cleanup): Remove.
9163         (yylex, c_parse): Update.
9164
9165 2019-01-06  Tom Tromey  <tom@tromey.com>
9166
9167         * c-exp.y (struct c_parse_state) <strings>: New member.
9168         (operator_stoken): Update.
9169
9170 2019-01-06  Tom Tromey  <tom@tromey.com>
9171
9172         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9173         (union type_stack_elt) <typelist_val>: Now a pointer to
9174         std::vector.
9175         (type_stack_cleanup): Don't declare.
9176         (push_typelist): Update.
9177         * parse.c (pop_typelist): Return a std::vector.
9178         (push_typelist): Take a std::vector.
9179         (follow_types): Update.  Do not free args.
9180         (type_stack_cleanup): Remove.
9181         * c-exp.y (struct c_parse_state): New.
9182         (cpstate): New global.
9183         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
9184         (nonempty_typelist): Update.
9185         (func_mod): Create a new vector.
9186         (c_parse): Create a c_parse_state.
9187         (check_parameter_typelist): Do not delete params.
9188         (function_method): Update.  Do not delete type_list.
9189
9190 2019-01-06  Tom Tromey  <tom@tromey.com>
9191
9192         PR gdb/28155:
9193         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
9194         check_typedef.
9195         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
9196         (print_return_value): Likewise.
9197
9198 2019-01-05  Tom Tromey  <tom@tromey.com>
9199
9200         * contrib/cleanup_check.py: Remove.
9201         * contrib/gcc-with-excheck: Remove.
9202         * contrib/exsummary.py: Remove.
9203         * contrib/excheck.py: Remove.
9204
9205 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
9206
9207         * thread.c (delete_thread_1): Add gdb_assert that THR is not
9208         NULL. Initialize tpprev to NULL instead of assigning it
9209         to NULL on the next statement.
9210         * windows-nat.c (windows_delete_thread): Remove check for
9211         main_thread_id before printing thread exit notifications.
9212         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
9213         Remove thread ID check against main_thread_id.
9214         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
9215         windows_delete_thread.
9216         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
9217
9218 2019-01-04  Tom Tromey  <tom@tromey.com>
9219
9220         * compile/compile.c (_initialize_compile): Use upper case for
9221         metasyntactic variables.
9222         * symmisc.c (_initialize_symmisc): Use upper case for
9223         metasyntactic variables.
9224         * psymtab.c (_initialize_psymtab): Use upper case for
9225         metasyntactic variables.
9226         * demangle.c (demangle_command): Use upper case for metasyntactic
9227         variables.
9228         (_initialize_demangler): Likewise.
9229         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
9230         variables.
9231
9232 2019-01-03  Tom Tromey  <tom@tromey.com>
9233
9234         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
9235
9236 2019-01-03  Tom Tromey  <tom@tromey.com>
9237
9238         * python/py-symtab.c (salpy_str): Update.
9239         (struct salpy_sal_object) <symtab>: Now a PyObject.
9240         (salpy_dealloc): Update.
9241         (del_objfile_sal): Use gdbpy_ref.
9242
9243 2019-01-03  Tom Tromey  <tom@tromey.com>
9244
9245         * python/py-type.c (convert_field): Use new_reference.  Return
9246         gdbpy_ref.
9247         (make_fielditem): Return gdbpy_ref.
9248         (typy_fields): Update.
9249         (typy_getitem): Update.
9250         (field_name): Return gdbpy_ref.  Use new_reference.
9251         (typy_iterator_iternext): Update.
9252
9253 2019-01-03  Tom Tromey  <tom@tromey.com>
9254
9255         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
9256
9257 2019-01-03  Tom Tromey  <tom@tromey.com>
9258
9259         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
9260         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
9261         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
9262         (pspy_set_frame_filters, pspy_set_frame_unwinders)
9263         (pspy_set_type_printers): Likewise.
9264         * python/py-function.c (fnpy_init): Use gdbpy_ref.
9265         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
9266         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
9267         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
9268         (objfpy_set_type_printers): Likewise.
9269
9270 2019-01-03  Tom Tromey  <tom@tromey.com>
9271
9272         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
9273         (gdbpy_print_stack): Use gdbpy_err_fetch.
9274         * python/python-internal.h (class gdbpy_err_fetch): New class.
9275         (class gdbpy_enter) <m_error_type, m_error_value,
9276         m_error_traceback>: Remove.
9277         <m_error>: New member.
9278         (gdbpy_exception_to_string): Don't declare.
9279         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
9280         * python/py-value.c (convert_value_from_python): Use
9281         gdbpy_err_fetch.
9282         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
9283         gdbpy_exception_to_string.
9284         (gdbpy_handle_exception): Use gdbpy_err_fetch.
9285         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
9286         gdbpy_err_fetch.
9287
9288 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9289
9290         * linux-nat.c (delete_lwp_cleanup): Delete.
9291         (struct lwp_deleter): New struct.
9292         (lwp_info_up): New typedef.
9293         (linux_nat_target::follow_fork): Delete cleanup, and make use of
9294         lwp_info_up.
9295
9296 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9297
9298         * linux-fork.c (class scoped_switch_fork_info): New class.
9299         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
9300
9301 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9302
9303         * valops.c (find_overload_match): Remove use of null_cleanup, and
9304         calls to do_cleanups.
9305
9306 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9307
9308         * compile/compile-cplus-types.c
9309         (compile_cplus_instance::decl_name): Handle changes to
9310         cp_func_name.
9311         * cp-support.c (cp_func_name): Update header comment, update
9312         return type.
9313         * cp-support.h (cp_func_name): Update return type in declaration.
9314         * valops.c (find_overload_match): Move temp_func local to top
9315         level of function and change its type.  Use temp_func to hold and
9316         delete temporary string obtained from cp_func_name.
9317
9318 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9319
9320         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
9321         gdb::char_vector, remove cleanup, and update uses of `msg`.
9322
9323 2019-01-03  Jim Wilson  <jimw@sifive.com>
9324
9325         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
9326
9327 2019-01-02  Tom Tromey  <tom@tromey.com>
9328
9329         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
9330         (tdesc_parse_xml): Remove cleanups.
9331         * target-descriptions.h (make_cleanup_free_target_description):
9332         Don't declare.
9333         (target_desc_deleter): New struct.
9334         (target_desc_up): New typedef.
9335         * target-descriptions.c (target_desc_deleter::operator()): Rename
9336         from free_target_description.
9337         (make_cleanup_free_target_description): Remove.
9338
9339 2019-01-02  Tom Tromey  <tom@tromey.com>
9340
9341         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
9342         constructor, destructor.
9343         (linespec_parser): Remove typedef.
9344         (~linespec_parser): Rename from linespec_parser_delete.
9345         (linespec_lex_to_end, linespec_complete_label)
9346         (linespec_complete): Update.
9347         (decode_line_full): Remove cleanups.
9348         (decode_line_1): Update.
9349
9350 2019-01-02  Tom Tromey  <tom@tromey.com>
9351
9352         * python/python-internal.h (inferior_to_inferior_object): Change
9353         return type.
9354         * python/py-exitedevent.c (create_exited_event_object): Update.
9355         * python/py-inferior.c (inferior_to_inferior_object): Return
9356         gdbpy_ref.
9357         (python_new_inferior, python_inferior_deleted)
9358         (thread_to_thread_object, delete_thread_object)
9359         (build_inferior_list, gdbpy_selected_inferior): Update.
9360         * python/py-infthread.c (create_thread_object): Update.  Also fail
9361         if inferior_to_inferior_object fails.
9362
9363 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
9364
9365         * inferior.h (class inferior) <displaced_step_state>: New field.
9366         * infrun.h (struct displaced_step_state): Move here from
9367         infrun.c.  Initialize fields, add constructor.
9368         <inf>: Remove field.
9369         <reset>: New method.
9370         * infrun.c (struct displaced_step_inferior_state): Move to
9371         infrun.h.
9372         (displaced_step_inferior_states): Remove.
9373         (get_displaced_stepping_state): Adust.
9374         (displaced_step_in_progress_any_inferior): Adjust.
9375         (displaced_step_in_progress_thread): Adjust.
9376         (displaced_step_in_progress): Adjust.
9377         (add_displaced_stepping_state): Remove.
9378         (get_displaced_step_closure_by_addr): Adjust.
9379         (remove_displaced_stepping_state): Remove.
9380         (infrun_inferior_exit): Call displaced_step_state.reset.
9381         (use_displaced_stepping): Don't check for NULL.
9382         (displaced_step_prepare_throw): Call
9383         get_displaced_stepping_state.
9384         (displaced_step_fixup): Don't check for NULL.
9385         (prepare_for_detach): Don't check for NULL.
9386
9387 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9388
9389         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
9390          in case of call that did not complete.
9391
9392 2019-01-02  Andrey Utkin  <autkin@undo.io>
9393
9394         * symfile.c (find_separate_debug_file): Fix search of debug files for
9395         remote debuggee.
9396
9397 2019-01-02  Tom Tromey  <tom@tromey.com>
9398
9399         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
9400         indentation.
9401         * python/py-frame.c (frapy_older): Remove cast.
9402         (frapy_newer): Likewise.
9403         * python/py-breakpoint.c (local_setattro): Remove cast.
9404         * python/py-arch.c (archpy_name): Remove local variable.
9405         * python/py-type.c (gdbpy_lookup_type): Remove cast.
9406
9407 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
9408
9409         * unittests/basic_string_view/element_access/char/empty.cc:
9410         Fix year range in copyright header.
9411
9412 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9413
9414         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
9415         Delete.
9416         <operator==>: Update with for removed field.
9417         <hash>: Likewise.
9418         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
9419         <isa_features>: ...this.
9420         <abi_features>: New field.
9421         (riscv_isa_flen): Update comment.
9422         (riscv_abi_xlen): New declaration.
9423         (riscv_abi_flen): New declaration.
9424         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
9425         isa_features.
9426         (riscv_abi_xlen): New function.
9427         (riscv_isa_flen): Update to get answer from isa_features.
9428         (riscv_abi_flen): New function.
9429         (riscv_has_fp_abi): Update to get answer from abi_features.
9430         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
9431         xlen and flen.
9432         (riscv_call_info) <xlen, flen>: Update comment.
9433         (riscv_call_arg_struct): Remove invalid assertions
9434         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
9435         is removed.
9436         (riscv_gdbarch_init): Gather isa features and abi features
9437         separately, ensure both match on the gdbarch when reusing an old
9438         gdbarch.  Relax an error check to allow 32-bit abi float to run on
9439         a target with 64-bit float hardware.
9440
9441 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9442
9443         * source.c (search_command_helper): Stop reverse search
9444         when line 1 has been searched.
9445
9446 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9447
9448         * record-full.c (record_full_base_target::close): Rewrite
9449         record_full_core_buf_list free logic.
9450
9451 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9452
9453         * break-catch-syscall.c (print_one_catch_syscall): xfree
9454         the last text.
9455
9456 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9457
9458         * top.c (print_gdb_version): Update Copyright year in version
9459         message.
9460
9461 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9462
9463         Update copyright year range in all GDB files.
9464
9465 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
9466
9467         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
9468
9469 For older changes see ChangeLog-2018.
9470 \f
9471 Local Variables:
9472 mode: change-log
9473 left-margin: 8
9474 fill-column: 74
9475 version-control: never
9476 coding: utf-8
9477 End:
9478