gdb/ChangeLog

   1 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
   2
   3         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
   4         tui_refill_source_window instead of tui_refresh_win, to update the
   5         current execution line.  This fixes redisplay of the current line
   6         when stepping through the code with "next" or "step".
   7
   8 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
   9
  10         * source-cache.c (source_cache::get_source_lines): Call
  11         find_source_lines to initialize s->nlines.  This fixes vertical
  12         scrolling of TUI source window when the DOWN arrow is pressed.
  13
  14 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
  15
  16         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
  17         wclrtoeol in tui_show_source_line".  This reverts changes made in
  18         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
  19
  20 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
  21
  22         * NEWS: Combine separate "New targets" sections for 8.3.
  23
  24 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
  25
  26         The MS-Windows port of ncurses fails to switch to a color pair if
  27         one or both of the colors are the implicit default colors.  This
  28         change records the default colors when TUI is initialized, and
  29         then specifies them explicitly when a color pair uses the default
  30         colors.  This allows color styling in TUI mode on MS-Windows.
  31
  32         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
  33         ncurses_norm_attr.
  34         (tui_initialize_io) [__MINGW32__]: Record the default terminal
  35         colors in ncurses_norm_attr.
  36         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
  37         "none", replace it with the default color recorded in
  38         ncurses_norm_attr.
  39
  40 2019-03-14  Tom Tromey  <tromey@adacore.com>
  41
  42         * source-cache.h (class source_cache) <get_source_lines>: Return
  43         std::string.
  44         * source-cache.c (source_cache::extract_lines): Handle case where
  45         first_pos==npos.  Return std::string.
  46         (source_cache::get_source_lines): Update.
  47
  48 2019-03-14  Tom Tromey  <tromey@adacore.com>
  49
  50         * NEWS: Add item for "style sources" commands.
  51         * source-cache.c (source_cache::get_source_lines): Check
  52         source_styling.
  53         * cli/cli-style.c (source_styling): New global.
  54         (_initialize_cli_style): Add "style sources" commands.
  55         (show_style_sources): New function.
  56         * cli/cli-style.h (source_styling): Declare.
  57
  58 2019-03-14  Pedro Alves  <palves@redhat.com>
  59             Tom Tromey  <tromey@adacore.com>
  60
  61         * tui/tui-winsource.h (tui_refill_source_window): Declare.
  62         * tui/tui-winsource.c (tui_refill_source_window): New function,
  63         from...
  64         (tui_horizontal_source_scroll): ... here.  Move some logic.
  65         * cli/cli-style.c (set_style_enabled): Notify new observable.
  66         * tui/tui-hooks.c (tui_redisplay_source): New function.
  67         (tui_attach_detach_observers): Attach or detach
  68         tui_redisplay_source.
  69         * observable.h (source_styling_changed): New observable.
  70         * observable.c: Define source_styling_changed observable.
  71
  72 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
  73
  74         PR/24325
  75         * source-cache.c: #undef open and close, to avoid unresolved
  76         externals during linking.
  77
  78 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
  79
  80         Support styling on native MS-Windows console
  81
  82         PR/24315
  83         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
  84         on MS-Windows if $TERM is not defined.
  85
  86         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
  87
  88         * posix-hdep.c (gdb_console_fputs):
  89         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
  90         functions.
  91         * ui-file.h (gdb_console_fputs): Add prototype.
  92
  93         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
  94         back to fputs only if the former returns zero.
  95
  96 2019-03-07  Brian Vandenberg  <phantall@gmail.com>
  97             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
  98
  99         PR gdb/8527
 100         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
 101         set_sigint_trap, clear_sigint_trap.
 102
 103 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
 104
 105         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
 106         for-loop range, to avoid compiler warnings.
 107
 108         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
 109         avoid compiler warnings about unused variables.
 110
 111 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
 112
 113         * NEWS: Mention end of support for native debugging on MS-Windows
 114         before XP.
 115
 116 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
 117
 118         PR gdb/24292
 119         * common/netstuff.c:
 120         * gdbserver/gdbreplay.c
 121         * gdbserver/remote-utils.c:
 122         * ser-tcp.c:
 123         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
 124         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
 125         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
 126         'getaddrinfo' and 'freeaddrinfo' were not available before
 127         Windows XP, and mingw.org's MinGW headers by default define
 128         _WIN32_WINNT to 0x500.
 129
 130 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
 131
 132         * NEWS: Note minimum Python version.
 133
 134 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 135
 136         * version.in: Set GDB version number to 8.2.90.DATE-git.
 137
 138 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 139
 140         GDB 8.2.90 released.
 141
 142 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 143
 144         * version.in: Set GDB version number to 8.2.90.
 145
 146 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 147
 148         * NEWS: Change "Changes since GDB 8.2" into "Changes in GDB 8.3".
 149
 150 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 151
 152         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
 153         * version.in: Bump version to 8.2.90.DATE-git.
 154
 155 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
 156
 157         * aix-thread.c (ptid_cmp): Remove unused variable.
 158         (get_signaled_thread): Likewise.
 159         (store_regs_user_thread): Likewise.
 160         (store_regs_kernel_thread): Likewise.
 161         (fetch_regs_kernel_thread): Remove shadowed variable.
 162
 163 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
 164
 165         * features/riscv/32bit-cpu.xml: Add register numbers.
 166         * features/riscv/32bit-fpu.c: Regenerate.
 167         * features/riscv/32bit-fpu.xml: Add register numbers.
 168         * features/riscv/64bit-cpu.xml: Add register numbers.
 169         * features/riscv/64bit-fpu.c: Regenerate.
 170         * features/riscv/64bit-fpu.xml: Add register numbers.
 171
 172 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
 173
 174         * NEWS: Mention two argument form of gdb.Value constructor.
 175         * python/py-value.c (convert_buffer_and_type_to_value): New
 176         function.
 177         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
 178         Add support for handling an optional second argument.  Call
 179         convert_buffer_and_type_to_value as appropriate.
 180         * python/python-internal.h (Py_buffer_deleter): New struct.
 181         (Py_buffer_up): New typedef.
 182
 183 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
 184
 185         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
 186         instead of releasing ownership.
 187
 188 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
 189
 190         * dwarf2read.c (open_and_init_dwp_file): Call
 191         elf_numsections instead of bfd_count_sections to initialize
 192         dwp_file->num_sections.
 193
 194 2019-02-25  Tom Tromey  <tromey@adacore.com>
 195
 196         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
 197
 198 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 199
 200         * gcore.in: Add '--readnever' option when invoking GDB.
 201
 202 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
 203
 204         * MAINTAINERS: Update my email address.
 205
 206 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
 207
 208         * build-id.c (build_id_to_debug_bfd_1): New function.
 209         (build_id_to_debug_bfd): Look for separate debug file in
 210         sysroot.
 211
 212 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 213
 214         * gdbarch.sh: Update the copyright year range that is placed into
 215         generated files.
 216
 217 2019-02-22  Keith Seitz  <keiths@redhat.com>
 218
 219         PR symtab/23853
 220         * linespec.c (create_sals_line_offset): Search for the default
 221         symtab's filename instead of its fullname.
 222
 223 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 224
 225         * NEWS: Update style defaults.
 226
 227 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 228
 229         * main.c (captured_main_1): Disable styling in batch mode.
 230
 231 2019-02-20  Tom Tromey  <tom@tromey.com>
 232
 233         * symtab.c (symtab_symbol_info): Fix typos.
 234
 235 2019-02-20  Tom Tromey  <tromey@adacore.com>
 236
 237         * findcmd.c (_initialize_mem_search): Use upper case for
 238         metasyntactic variables.
 239
 240 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
 241
 242         * aarch64-tdep.c (aarch64_add_reggroups): New function.
 243         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
 244
 245 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
 246
 247         * top.h (source_file_name): Change to std::string.
 248         * top.c (source_file_name): Likewise.
 249         (command_line_input): Adjust.
 250         * cli/cli-script.c (script_from_file): Adjust.
 251
 252 2019-02-19  Tom Tromey  <tromey@adacore.com>
 253
 254         * ravenscar-thread.c
 255         (ravenscar_thread_target::update_thread_list): Don't call
 256         ada_build_task_list.
 257         * ada-lang.h (ada_build_task_list): Don't declare.
 258         * ada-tasks.c (struct ada_tasks_inferior_data)
 259         <task_list_valid_p>: Now bool.
 260         (read_known_tasks, ada_task_list_changed)
 261         (ada_tasks_invalidate_inferior_data): Update.
 262         (read_known_tasks_array): Return bool.
 263         (read_known_tasks_list): Likewise.
 264         (read_known_tasks): Return void.
 265         (ada_build_task_list): Now static.
 266
 267 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 268
 269         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
 270         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
 271
 272 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 273
 274         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
 275         variant for ada_tasks_pspace_data_handle and
 276         ada_tasks_inferior_data_handle.
 277         (ada_tasks_pspace_data_cleanup): New function.
 278         (ada_tasks_inferior_data_cleanup): New function.
 279
 280 2019-02-17  Tom Tromey  <tom@tromey.com>
 281
 282         * macrotab.h (macro_source_fullname): Return a std::string.
 283         * macrotab.c (macro_include, check_for_redefinition)
 284         (macro_undef, macro_lookup_definition, foreach_macro)
 285         (foreach_macro_in_scope): Update.
 286         (macro_source_fullname): Return a std::string.
 287         * macrocmd.c (show_pp_source_pos): Update.
 288
 289 2019-02-17  Tom Tromey  <tom@tromey.com>
 290
 291         * macrocmd.c (show_pp_source_pos): Style the file names.
 292
 293 2019-02-17  Tom Tromey  <tom@tromey.com>
 294
 295         PR tui/24197:
 296         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
 297
 298 2019-02-17  Tom Tromey  <tom@tromey.com>
 299
 300         * ada-lang.c (user_select_syms): Use filtered printing.
 301         * utils.c (wrap_style): New global.
 302         (desired_style): Remove.
 303         (emit_style_escape): Add stream parameter.
 304         (set_output_style, reset_terminal_style, prompt_for_continue):
 305         Update.
 306         (flush_wrap_buffer): Only flush gdb_stdout.
 307         (wrap_here): Set wrap_style.
 308         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
 309         treat escape sequences as a character.  Change when wrap buffer is
 310         flushed.
 311         (fputs_styled): Do not set the output style when the default is
 312         requested.
 313         * ui-style.h (struct ui_file_style) <is_default>: New method.
 314         * source.c (print_source_lines_base): Emit escape sequences in one
 315         piece.
 316
 317 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 318
 319         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
 320         integers and enumeration types.
 321
 322 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 323
 324         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
 325         instead of lookup_symbol_in_language
 326         (do_exact_match): New function.
 327         (ada_get_symbol_name_matcher): Return do_exact_match when
 328         doing a verbatim match.
 329
 330 2019-02-15  Tom Tromey  <tromey@adacore.com>
 331
 332         * ravenscar-thread.c (ravenscar_thread_target::resume)
 333         (ravenscar_thread_target::wait): Special case wildcard requests.
 334
 335 2019-02-15  Tom Tromey  <tromey@adacore.com>
 336
 337         * ravenscar-thread.c (base_ptid): Remove.
 338         (struct ravenscar_thread_target) <close>: New method.
 339         <m_base_ptid>: New member.
 340         <update_inferior_ptid, active_task, task_is_currently_active,
 341         runtime_initialized>: Declare methods.
 342         <ravenscar_thread_target>: Add constructor.
 343         (ravenscar_thread_target::task_is_currently_active)
 344         (ravenscar_thread_target::update_inferior_ptid)
 345         (ravenscar_runtime_initialized): Rename.  Now methods.
 346         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
 347         (ravenscar_thread_target::update_thread_list): Update.
 348         (ravenscar_thread_target::active_task): Now method.
 349         (ravenscar_thread_target::store_registers)
 350         (ravenscar_thread_target::prepare_to_store)
 351         (ravenscar_thread_target::prepare_to_store)
 352         (ravenscar_thread_target::mourn_inferior): Update.
 353         (ravenscar_inferior_created): Use "new" to create target.
 354         (ravenscar_thread_target::get_ada_task_ptid): Update.
 355         (_initialize_ravenscar): Don't initialize base_ptid.
 356         (ravenscar_ops): Remove global.
 357
 358 2019-02-15  Tom Tromey  <tromey@adacore.com>
 359
 360         * target.h (push_target): Declare new overload.
 361         * target.c (push_target): New overload, taking an rvalue reference.
 362         * remote.c (remote_target::open_1): Use push_target overload.
 363         * corelow.c (core_target_open): Use push_target overload.
 364
 365 2019-02-15  Tom Tromey  <tromey@adacore.com>
 366
 367         * ravenscar-thread.c (is_ravenscar_task)
 368         (ravenscar_task_is_currently_active): Return bool.
 369         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
 370         (_initialize_ravenscar): Remove "(void)".
 371         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
 372         Return bool.
 373
 374 2019-02-15  Tom Tromey  <tromey@adacore.com>
 375
 376         * ravenscar-thread.c (ravenscar_runtime_initializer)
 377         (has_ravenscar_runtime, get_running_thread_id)
 378         (ravenscar_thread_target::resume): Fix indentation.
 379
 380 2019-02-15  Tom Tromey  <tromey@adacore.com>
 381
 382         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
 383         from ravenscar_arch_ops.
 384         (sparc_ravenscar_ops::fetch_registers)
 385         (sparc_ravenscar_ops::store_registers): Now methods.
 386         (sparc_ravenscar_prepare_to_store): Remove.
 387         (sparc_ravenscar_ops): Redefine.
 388         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
 389         methods and destructor.  Remove members.
 390         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
 391         (ravenscar_thread_target::store_registers)
 392         (ravenscar_thread_target::prepare_to_store): Update.
 393         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
 394         Remove.
 395         (struct ppc_ravenscar_powerpc_ops): Derive from
 396         ravenscar_arch_ops.
 397         (ppc_ravenscar_powerpc_ops::fetch_registers)
 398         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
 399         (ppc_ravenscar_powerpc_ops): Redefine.
 400         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
 401         (ppc_ravenscar_e500_ops::fetch_registers)
 402         (ppc_ravenscar_e500_ops::store_registers): Now methods.
 403         (ppc_ravenscar_e500_ops): Redefine.
 404         * aarch64-ravenscar-thread.c
 405         (aarch64_ravenscar_generic_prepare_to_store): Remove.
 406         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
 407         (aarch64_ravenscar_fetch_registers)
 408         (aarch64_ravenscar_store_registers): Now methods.
 409         (aarch64_ravenscar_ops): Redefine.
 410
 411 2019-02-15  Tom Tromey  <tromey@adacore.com>
 412
 413         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
 414         (ravenscar_thread_target::stopped_by_hw_breakpoint)
 415         (ravenscar_thread_target::stopped_by_watchpoint)
 416         (ravenscar_thread_target::stopped_data_address)
 417         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
 418
 419 2019-02-15  Tom Tromey  <tromey@adacore.com>
 420
 421         * ravenscar-thread.c: Fix some typos.
 422
 423 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 424             Tom Tromey  <tromey@adacore.com>
 425
 426         * ada-lang.c (ada_exception_sal): Change addr_string to a
 427         std::string.
 428         (create_ada_exception_catchpoint): Update.
 429
 430 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 431             Tom Tromey  <tromey@adacore.com>
 432
 433         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
 434         (bp_location_ops): Remove.
 435         (base_breakpoint_allocate_location): Update.
 436         (free_bp_location): Update.
 437         * ada-lang.c (class ada_catchpoint_location)
 438         <ada_catchpoint_location>: Remove ops parameter.
 439         (ada_catchpoint_location_dtor): Remove.
 440         (ada_catchpoint_location_ops): Remove.
 441         (allocate_location_exception): Update.
 442         * breakpoint.h (struct bp_location_ops): Remove.
 443         (class bp_location) <bp_location>: Remove bp_location_ops
 444         parameter.
 445         <~bp_location>: Add destructor.
 446         <ops>: Remove.
 447
 448 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 449             Pedro Alves  <palves@redhat.com>
 450
 451         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
 452         'PATH_MAX'.
 453
 454 2019-02-14  David Michael  <fedora.dm0@gmail.com>
 455             Samuel Thibault  <samuel.thibault@gnu.org>
 456             Thomas Schwinge  <thomas@codesourcery.com>
 457
 458         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
 459         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
 460
 461 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 462
 463         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
 464         (check_empty): Use "const char *".
 465
 466         * gnu-nat.c (gnu_nat_target::detach): Instead of
 467         'detach_inferior (pid)' call
 468         'detach_inferior (find_inferior_pid (pid))'.
 469
 470         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
 471         'nat/fork-inferior.o'.
 472         * gnu-nat.c: #include "nat/fork-inferior.h".
 473
 474         * gnu-nat.c (gnu_nat_target::detach): Instead of
 475         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
 476         * gnu-nat.h: #include "inf-child.h".
 477         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
 478         'i386_gnu_nat_target::fetch_registers'.
 479         (gnu_store_registers): Rename/move to
 480         'i386_gnu_nat_target::store_registers'.
 481
 482         * config/i386/nm-i386gnu.h: Don't "#include" any files.
 483         * gnu-nat.h (mach_thread_info): New function.
 484         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
 485
 486         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
 487
 488 2019-02-14  Frederic Konrad  <konrad@adacore.com>
 489
 490         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
 491
 492 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
 493
 494         * windows-nat.c (windows_add_thread): Add new parameter
 495         "main_thread_p" with default value set to false.  Update
 496         function documentation as well as all callers.
 497         (windows_delete_thread): Likewise.
 498         (fake_create_process): Update call to windows_add_thread.
 499         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
 500         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
 501         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
 502         call to windows_delete_thread.
 503
 504 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
 505
 506         * MAINTAINERS: Add Andrew Burgess as global maintainer.
 507
 508 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 509
 510         * symfile.c (find_separate_debug_file): Use canonical path of
 511         sysroot with child_path instead of gdb_sysroot if it is valid.
 512
 513 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 514
 515         * symfile.c (find_separate_debug_file): Use child_path to
 516         determine if an object file is under a sysroot.
 517
 518 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 519
 520         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 521         unittests/child-path-selftests.c.
 522         * common/pathstuff.c (child_path): New function.
 523         * common/pathstuff.h (child_path): New prototype.
 524         * unittests/child-path-selftests.c: New file.
 525
 526 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 527
 528         * symfile.c (find_separate_debug_file): Look for separate debug
 529         files in debug directories under the sysroot.
 530
 531 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 532
 533         * symtab.h (struct minimal_symbol data_p): New const method.
 534         (struct minimal_symbol text_p): Likewise.
 535         * symtab.c (output_source_filename): Use file name style
 536         to print file name.
 537         (print_symbol_info): Likewise.
 538         (print_msymbol_info): Use address style to print addresses.
 539         Use function name style to print executable text symbols.
 540         (expand_symtab_containing_pc): Use data_p.
 541         (find_pc_sect_compunit_symtab): Likewise.
 542
 543 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 544
 545         * breakpoint.c (describe_other_breakpoints): Use address style
 546         to print addresses.
 547         (say_where): Likewise.
 548
 549 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 550
 551         * ada-typeprint.c (print_func_type): Print function name
 552         style to print function name.
 553         * c-typeprint.c (c_print_type_1): Likewise.
 554
 555 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
 556
 557         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
 558         for execve.
 559
 560 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 561
 562         * c-exp.y (direct_abs_decl): Use emplace_back to record the
 563         type_stack.
 564
 565 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
 566
 567         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
 568         TYPE_CODE_REF types.
 569
 570 2019-02-08  Jim Wilson  <jimw@sifive.com>
 571
 572         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
 573         (riscv_linux_fregset): New.
 574         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
 575
 576 2019-02-07  Tom Tromey  <tom@tromey.com>
 577
 578         * thread.c (thread_cancel_execution_command): Update.
 579         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
 580         methods.
 581         (struct thread_fsm_ops): Remove.
 582         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
 583         (thread_fsm_should_stop, thread_fsm_return_value)
 584         (thread_fsm_set_finished, thread_fsm_finished_p)
 585         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
 586         Don't declare.
 587         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
 588         * infrun.c (clear_proceed_status_thread)
 589         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
 590         (print_stop_event): Update.
 591         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
 592         Add constructor.
 593         (step_command_fsm_ops): Remove.
 594         (new_step_command_fsm): Remove.
 595         (step_1): Update.
 596         (step_command_fsm::should_stop): Rename from
 597         step_command_fsm_should_stop.
 598         (step_command_fsm::clean_up): Rename from
 599         step_command_fsm_clean_up.
 600         (step_command_fsm::do_async_reply_reason): Rename from
 601         step_command_fsm_async_reply_reason.
 602         (struct until_next_fsm): Inherit from thread_fsm.  Add
 603         constructor.
 604         (until_next_fsm_ops): Remove.
 605         (new_until_next_fsm): Remove.
 606         (until_next_fsm::should_stop): Rename from
 607         until_next_fsm_should_stop.
 608         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
 609         (until_next_fsm::do_async_reply_reason): Rename from
 610         until_next_fsm_async_reply_reason.
 611         (struct finish_command_fsm): Inherit from thread_fsm.  Add
 612         constructor.  Change type of breakpoint.
 613         (finish_command_fsm_ops): Remove.
 614         (new_finish_command_fsm): Remove.
 615         (finish_command_fsm::should_stop): Rename from
 616         finish_command_fsm_should_stop.
 617         (finish_command_fsm::clean_up): Rename from
 618         finish_command_fsm_clean_up.
 619         (finish_command_fsm::return_value): Rename from
 620         finish_command_fsm_return_value.
 621         (finish_command_fsm::do_async_reply_reason): Rename from
 622         finish_command_fsm_async_reply_reason.
 623         (finish_command): Update.
 624         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
 625         Add constructor.
 626         (call_thread_fsm_ops): Remove.
 627         (call_thread_fsm::call_thread_fsm): Rename from
 628         new_call_thread_fsm.
 629         (call_thread_fsm::should_stop): Rename from
 630         call_thread_fsm_should_stop.
 631         (call_thread_fsm::should_notify_stop): Rename from
 632         call_thread_fsm_should_notify_stop.
 633         (run_inferior_call, call_function_by_hand_dummy): Update.
 634         * cli/cli-interp.c (should_print_stop_to_console): Update.
 635         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
 636         Add constructor.  Change type of location_breakpoint,
 637         caller_breakpoint.
 638         (until_break_fsm_ops): Remove.
 639         (new_until_break_fsm): Remove.
 640         (until_break_fsm::should_stop): Rename from
 641         until_break_fsm_should_stop.
 642         (until_break_fsm::clean_up): Rename from
 643         until_break_fsm_clean_up.
 644         (until_break_fsm::do_async_reply_reason): Rename from
 645         until_break_fsm_async_reply_reason.
 646         (until_break_command): Update.
 647         * thread-fsm.c: Remove.
 648         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
 649
 650 2019-02-07  Tom Tromey  <tom@tromey.com>
 651
 652         * yy-remap.h: Add include guard.
 653         * xtensa-tdep.h: Add include guard.
 654         * xcoffread.h: Rename include guard.
 655         * varobj-iter.h: Add include guard.
 656         * tui/tui.h: Rename include guard.
 657         * tui/tui-winsource.h: Rename include guard.
 658         * tui/tui-wingeneral.h: Rename include guard.
 659         * tui/tui-windata.h: Rename include guard.
 660         * tui/tui-win.h: Rename include guard.
 661         * tui/tui-stack.h: Rename include guard.
 662         * tui/tui-source.h: Rename include guard.
 663         * tui/tui-regs.h: Rename include guard.
 664         * tui/tui-out.h: Rename include guard.
 665         * tui/tui-layout.h: Rename include guard.
 666         * tui/tui-io.h: Rename include guard.
 667         * tui/tui-hooks.h: Rename include guard.
 668         * tui/tui-file.h: Rename include guard.
 669         * tui/tui-disasm.h: Rename include guard.
 670         * tui/tui-data.h: Rename include guard.
 671         * tui/tui-command.h: Rename include guard.
 672         * tic6x-tdep.h: Add include guard.
 673         * target/waitstatus.h: Rename include guard.
 674         * target/wait.h: Rename include guard.
 675         * target/target.h: Rename include guard.
 676         * target/resume.h: Rename include guard.
 677         * target-float.h: Rename include guard.
 678         * stabsread.h: Add include guard.
 679         * rs6000-tdep.h: Add include guard.
 680         * riscv-fbsd-tdep.h: Add include guard.
 681         * regformats/regdef.h: Rename include guard.
 682         * record.h: Rename include guard.
 683         * python/python.h: Rename include guard.
 684         * python/python-internal.h: Rename include guard.
 685         * python/py-stopevent.h: Rename include guard.
 686         * python/py-ref.h: Rename include guard.
 687         * python/py-record.h: Rename include guard.
 688         * python/py-record-full.h: Rename include guard.
 689         * python/py-record-btrace.h: Rename include guard.
 690         * python/py-instruction.h: Rename include guard.
 691         * python/py-events.h: Rename include guard.
 692         * python/py-event.h: Rename include guard.
 693         * procfs.h: Add include guard.
 694         * proc-utils.h: Add include guard.
 695         * p-lang.h: Add include guard.
 696         * or1k-tdep.h: Rename include guard.
 697         * observable.h: Rename include guard.
 698         * nto-tdep.h: Rename include guard.
 699         * nat/x86-linux.h: Rename include guard.
 700         * nat/x86-linux-dregs.h: Rename include guard.
 701         * nat/x86-gcc-cpuid.h: Add include guard.
 702         * nat/x86-dregs.h: Rename include guard.
 703         * nat/x86-cpuid.h: Rename include guard.
 704         * nat/ppc-linux.h: Rename include guard.
 705         * nat/mips-linux-watch.h: Rename include guard.
 706         * nat/linux-waitpid.h: Rename include guard.
 707         * nat/linux-ptrace.h: Rename include guard.
 708         * nat/linux-procfs.h: Rename include guard.
 709         * nat/linux-osdata.h: Rename include guard.
 710         * nat/linux-nat.h: Rename include guard.
 711         * nat/linux-namespaces.h: Rename include guard.
 712         * nat/linux-btrace.h: Rename include guard.
 713         * nat/glibc_thread_db.h: Rename include guard.
 714         * nat/gdb_thread_db.h: Rename include guard.
 715         * nat/gdb_ptrace.h: Rename include guard.
 716         * nat/fork-inferior.h: Rename include guard.
 717         * nat/amd64-linux-siginfo.h: Rename include guard.
 718         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
 719         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
 720         * nat/aarch64-linux.h: Rename include guard.
 721         * nat/aarch64-linux-hw-point.h: Rename include guard.
 722         * mn10300-tdep.h: Add include guard.
 723         * mips-linux-tdep.h: Add include guard.
 724         * mi/mi-parse.h: Rename include guard.
 725         * mi/mi-out.h: Rename include guard.
 726         * mi/mi-main.h: Rename include guard.
 727         * mi/mi-interp.h: Rename include guard.
 728         * mi/mi-getopt.h: Rename include guard.
 729         * mi/mi-console.h: Rename include guard.
 730         * mi/mi-common.h: Rename include guard.
 731         * mi/mi-cmds.h: Rename include guard.
 732         * mi/mi-cmd-break.h: Rename include guard.
 733         * m2-lang.h: Add include guard.
 734         * location.h: Rename include guard.
 735         * linux-record.h: Rename include guard.
 736         * linux-nat.h: Add include guard.
 737         * linux-fork.h: Add include guard.
 738         * i386-darwin-tdep.h: Rename include guard.
 739         * hppa-linux-offsets.h: Add include guard.
 740         * guile/guile.h: Rename include guard.
 741         * guile/guile-internal.h: Rename include guard.
 742         * gnu-nat.h: Rename include guard.
 743         * gdb-stabs.h: Rename include guard.
 744         * frv-tdep.h: Add include guard.
 745         * f-lang.h: Add include guard.
 746         * event-loop.h: Add include guard.
 747         * darwin-nat.h: Rename include guard.
 748         * cp-abi.h: Rename include guard.
 749         * config/sparc/nm-sol2.h: Rename include guard.
 750         * config/nm-nto.h: Rename include guard.
 751         * config/nm-linux.h: Add include guard.
 752         * config/i386/nm-i386gnu.h: Rename include guard.
 753         * config/djgpp/nl_types.h: Rename include guard.
 754         * config/djgpp/langinfo.h: Rename include guard.
 755         * compile/gcc-cp-plugin.h: Add include guard.
 756         * compile/gcc-c-plugin.h: Add include guard.
 757         * compile/compile.h: Rename include guard.
 758         * compile/compile-object-run.h: Rename include guard.
 759         * compile/compile-object-load.h: Rename include guard.
 760         * compile/compile-internal.h: Rename include guard.
 761         * compile/compile-cplus.h: Rename include guard.
 762         * compile/compile-c.h: Rename include guard.
 763         * common/xml-utils.h: Rename include guard.
 764         * common/x86-xstate.h: Rename include guard.
 765         * common/version.h: Rename include guard.
 766         * common/vec.h: Rename include guard.
 767         * common/tdesc.h: Rename include guard.
 768         * common/selftest.h: Rename include guard.
 769         * common/scoped_restore.h: Rename include guard.
 770         * common/scoped_mmap.h: Rename include guard.
 771         * common/scoped_fd.h: Rename include guard.
 772         * common/safe-iterator.h: Rename include guard.
 773         * common/run-time-clock.h: Rename include guard.
 774         * common/refcounted-object.h: Rename include guard.
 775         * common/queue.h: Rename include guard.
 776         * common/ptid.h: Rename include guard.
 777         * common/print-utils.h: Rename include guard.
 778         * common/preprocessor.h: Rename include guard.
 779         * common/pathstuff.h: Rename include guard.
 780         * common/observable.h: Rename include guard.
 781         * common/netstuff.h: Rename include guard.
 782         * common/job-control.h: Rename include guard.
 783         * common/host-defs.h: Rename include guard.
 784         * common/gdb_wait.h: Rename include guard.
 785         * common/gdb_vecs.h: Rename include guard.
 786         * common/gdb_unlinker.h: Rename include guard.
 787         * common/gdb_unique_ptr.h: Rename include guard.
 788         * common/gdb_tilde_expand.h: Rename include guard.
 789         * common/gdb_sys_time.h: Rename include guard.
 790         * common/gdb_string_view.h: Rename include guard.
 791         * common/gdb_splay_tree.h: Rename include guard.
 792         * common/gdb_setjmp.h: Rename include guard.
 793         * common/gdb_ref_ptr.h: Rename include guard.
 794         * common/gdb_optional.h: Rename include guard.
 795         * common/gdb_locale.h: Rename include guard.
 796         * common/gdb_assert.h: Rename include guard.
 797         * common/filtered-iterator.h: Rename include guard.
 798         * common/filestuff.h: Rename include guard.
 799         * common/fileio.h: Rename include guard.
 800         * common/environ.h: Rename include guard.
 801         * common/common-utils.h: Rename include guard.
 802         * common/common-types.h: Rename include guard.
 803         * common/common-regcache.h: Rename include guard.
 804         * common/common-inferior.h: Rename include guard.
 805         * common/common-gdbthread.h: Rename include guard.
 806         * common/common-exceptions.h: Rename include guard.
 807         * common/common-defs.h: Rename include guard.
 808         * common/common-debug.h: Rename include guard.
 809         * common/cleanups.h: Rename include guard.
 810         * common/buffer.h: Rename include guard.
 811         * common/btrace-common.h: Rename include guard.
 812         * common/break-common.h: Rename include guard.
 813         * cli/cli-utils.h: Rename include guard.
 814         * cli/cli-style.h: Rename include guard.
 815         * cli/cli-setshow.h: Rename include guard.
 816         * cli/cli-script.h: Rename include guard.
 817         * cli/cli-interp.h: Rename include guard.
 818         * cli/cli-decode.h: Rename include guard.
 819         * cli/cli-cmds.h: Rename include guard.
 820         * charset-list.h: Add include guard.
 821         * buildsym-legacy.h: Rename include guard.
 822         * bfin-tdep.h: Add include guard.
 823         * ax.h: Rename include guard.
 824         * arm-linux-tdep.h: Add include guard.
 825         * arm-fbsd-tdep.h: Add include guard.
 826         * arch/xtensa.h: Rename include guard.
 827         * arch/tic6x.h: Add include guard.
 828         * arch/i386.h: Add include guard.
 829         * arch/arm.h: Rename include guard.
 830         * arch/arm-linux.h: Rename include guard.
 831         * arch/arm-get-next-pcs.h: Rename include guard.
 832         * arch/amd64.h: Add include guard.
 833         * arch/aarch64-insn.h: Rename include guard.
 834         * arch-utils.h: Rename include guard.
 835         * annotate.h: Add include guard.
 836         * amd64-darwin-tdep.h: Rename include guard.
 837         * aarch64-linux-tdep.h: Add include guard.
 838         * aarch64-fbsd-tdep.h: Add include guard.
 839         * aarch32-linux-nat.h: Add include guard.
 840
 841 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 842
 843         * macrotab.c (macro_define_internal): New function that
 844         factorizes macro_define_object_internal and macro_define_function
 845         code.
 846         (macro_define_object_internal): Use macro_define_internal.
 847         (macro_define_function): Likewise.
 848
 849 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 850
 851         * macrocmd.c (extract_identifier): Return
 852         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
 853         callers.
 854
 855 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
 856
 857         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
 858
 859 2019-02-05  Tom Tromey  <tom@tromey.com>
 860
 861         * target.c (target_stack::unpush): Move assertion earlier.
 862
 863 2019-01-30  Tom Tromey  <tom@tromey.com>
 864
 865         PR python/23615:
 866         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
 867         (gdbpy_parse_and_eval): Likewise.
 868         * python/python-internal.h (gdbpy_allow_threads): New class.
 869
 870 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
 871
 872         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
 873         (aarch64_fbsd_fpregmap): Move earlier.
 874         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
 875         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 876         instead of individual calls to trad_frame_set_reg_addr.
 877         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
 878         earlier.
 879         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
 880         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 881         instead of individual calls to trad_frame_set_reg_addr.
 882
 883 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
 884
 885         * CONTRIBUTE: Replace contribution list with wiki link.
 886
 887 2019-01-25  Tom Tromey  <tom@tromey.com>
 888
 889         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
 890
 891 2019-01-25  Tom Tromey  <tom@tromey.com>
 892
 893         * xtensa-linux-nat.c: Fix common/ includes.
 894         * xml-support.h: Fix common/ includes.
 895         * xml-support.c: Fix common/ includes.
 896         * x86-linux-nat.c: Fix common/ includes.
 897         * windows-nat.c: Fix common/ includes.
 898         * varobj.h: Fix common/ includes.
 899         * varobj.c: Fix common/ includes.
 900         * value.c: Fix common/ includes.
 901         * valops.c: Fix common/ includes.
 902         * utils.c: Fix common/ includes.
 903         * unittests/xml-utils-selftests.c: Fix common/ includes.
 904         * unittests/utils-selftests.c: Fix common/ includes.
 905         * unittests/unpack-selftests.c: Fix common/ includes.
 906         * unittests/tracepoint-selftests.c: Fix common/ includes.
 907         * unittests/style-selftests.c: Fix common/ includes.
 908         * unittests/string_view-selftests.c: Fix common/ includes.
 909         * unittests/scoped_restore-selftests.c: Fix common/ includes.
 910         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
 911         * unittests/scoped_fd-selftests.c: Fix common/ includes.
 912         * unittests/rsp-low-selftests.c: Fix common/ includes.
 913         * unittests/parse-connection-spec-selftests.c: Fix common/
 914         includes.
 915         * unittests/optional-selftests.c: Fix common/ includes.
 916         * unittests/offset-type-selftests.c: Fix common/ includes.
 917         * unittests/observable-selftests.c: Fix common/ includes.
 918         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
 919         * unittests/memrange-selftests.c: Fix common/ includes.
 920         * unittests/memory-map-selftests.c: Fix common/ includes.
 921         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
 922         * unittests/function-view-selftests.c: Fix common/ includes.
 923         * unittests/environ-selftests.c: Fix common/ includes.
 924         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
 925         * unittests/common-utils-selftests.c: Fix common/ includes.
 926         * unittests/cli-utils-selftests.c: Fix common/ includes.
 927         * unittests/array-view-selftests.c: Fix common/ includes.
 928         * ui-file.c: Fix common/ includes.
 929         * tui/tui-io.c: Fix common/ includes.
 930         * tracepoint.h: Fix common/ includes.
 931         * tracepoint.c: Fix common/ includes.
 932         * tracefile-tfile.c: Fix common/ includes.
 933         * top.h: Fix common/ includes.
 934         * top.c: Fix common/ includes.
 935         * thread.c: Fix common/ includes.
 936         * target/waitstatus.h: Fix common/ includes.
 937         * target/waitstatus.c: Fix common/ includes.
 938         * target.h: Fix common/ includes.
 939         * target.c: Fix common/ includes.
 940         * target-memory.c: Fix common/ includes.
 941         * target-descriptions.c: Fix common/ includes.
 942         * symtab.h: Fix common/ includes.
 943         * symfile.c: Fix common/ includes.
 944         * stap-probe.c: Fix common/ includes.
 945         * spu-linux-nat.c: Fix common/ includes.
 946         * sparc-nat.c: Fix common/ includes.
 947         * source.c: Fix common/ includes.
 948         * solib.c: Fix common/ includes.
 949         * solib-target.c: Fix common/ includes.
 950         * ser-unix.c: Fix common/ includes.
 951         * ser-tcp.c: Fix common/ includes.
 952         * ser-pipe.c: Fix common/ includes.
 953         * ser-base.c: Fix common/ includes.
 954         * selftest-arch.c: Fix common/ includes.
 955         * s12z-tdep.c: Fix common/ includes.
 956         * rust-exp.y: Fix common/ includes.
 957         * rs6000-aix-tdep.c: Fix common/ includes.
 958         * riscv-tdep.c: Fix common/ includes.
 959         * remote.c: Fix common/ includes.
 960         * remote-notif.h: Fix common/ includes.
 961         * remote-fileio.h: Fix common/ includes.
 962         * remote-fileio.c: Fix common/ includes.
 963         * regcache.h: Fix common/ includes.
 964         * regcache.c: Fix common/ includes.
 965         * record-btrace.c: Fix common/ includes.
 966         * python/python.c: Fix common/ includes.
 967         * python/py-type.c: Fix common/ includes.
 968         * python/py-inferior.c: Fix common/ includes.
 969         * progspace.h: Fix common/ includes.
 970         * producer.c: Fix common/ includes.
 971         * procfs.c: Fix common/ includes.
 972         * proc-api.c: Fix common/ includes.
 973         * printcmd.c: Fix common/ includes.
 974         * ppc-linux-nat.c: Fix common/ includes.
 975         * parser-defs.h: Fix common/ includes.
 976         * osdata.c: Fix common/ includes.
 977         * obsd-nat.c: Fix common/ includes.
 978         * nat/x86-linux.c: Fix common/ includes.
 979         * nat/x86-linux-dregs.c: Fix common/ includes.
 980         * nat/x86-dregs.h: Fix common/ includes.
 981         * nat/x86-dregs.c: Fix common/ includes.
 982         * nat/ppc-linux.c: Fix common/ includes.
 983         * nat/mips-linux-watch.h: Fix common/ includes.
 984         * nat/mips-linux-watch.c: Fix common/ includes.
 985         * nat/linux-waitpid.c: Fix common/ includes.
 986         * nat/linux-ptrace.h: Fix common/ includes.
 987         * nat/linux-ptrace.c: Fix common/ includes.
 988         * nat/linux-procfs.c: Fix common/ includes.
 989         * nat/linux-personality.c: Fix common/ includes.
 990         * nat/linux-osdata.c: Fix common/ includes.
 991         * nat/linux-namespaces.c: Fix common/ includes.
 992         * nat/linux-btrace.h: Fix common/ includes.
 993         * nat/linux-btrace.c: Fix common/ includes.
 994         * nat/fork-inferior.c: Fix common/ includes.
 995         * nat/amd64-linux-siginfo.c: Fix common/ includes.
 996         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
 997         * nat/aarch64-linux.c: Fix common/ includes.
 998         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
 999         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
1000         * namespace.h: Fix common/ includes.
1001         * mips-linux-tdep.c: Fix common/ includes.
1002         * minsyms.c: Fix common/ includes.
1003         * mi/mi-parse.h: Fix common/ includes.
1004         * mi/mi-main.c: Fix common/ includes.
1005         * mi/mi-cmd-env.c: Fix common/ includes.
1006         * memrange.h: Fix common/ includes.
1007         * memattr.c: Fix common/ includes.
1008         * maint.h: Fix common/ includes.
1009         * maint.c: Fix common/ includes.
1010         * main.c: Fix common/ includes.
1011         * machoread.c: Fix common/ includes.
1012         * location.c: Fix common/ includes.
1013         * linux-thread-db.c: Fix common/ includes.
1014         * linux-nat.c: Fix common/ includes.
1015         * linux-fork.c: Fix common/ includes.
1016         * inline-frame.c: Fix common/ includes.
1017         * infrun.c: Fix common/ includes.
1018         * inflow.c: Fix common/ includes.
1019         * inferior.h: Fix common/ includes.
1020         * inferior.c: Fix common/ includes.
1021         * infcmd.c: Fix common/ includes.
1022         * inf-ptrace.c: Fix common/ includes.
1023         * inf-child.c: Fix common/ includes.
1024         * ia64-linux-nat.c: Fix common/ includes.
1025         * i387-tdep.c: Fix common/ includes.
1026         * i386-tdep.c: Fix common/ includes.
1027         * i386-linux-tdep.c: Fix common/ includes.
1028         * i386-linux-nat.c: Fix common/ includes.
1029         * i386-go32-tdep.c: Fix common/ includes.
1030         * i386-fbsd-tdep.c: Fix common/ includes.
1031         * i386-fbsd-nat.c: Fix common/ includes.
1032         * guile/scm-type.c: Fix common/ includes.
1033         * guile/guile.c: Fix common/ includes.
1034         * go32-nat.c: Fix common/ includes.
1035         * gnu-nat.c: Fix common/ includes.
1036         * gdbthread.h: Fix common/ includes.
1037         * gdbarch-selftests.c: Fix common/ includes.
1038         * gdb_usleep.c: Fix common/ includes.
1039         * gdb_select.h: Fix common/ includes.
1040         * gdb_bfd.c: Fix common/ includes.
1041         * gcore.c: Fix common/ includes.
1042         * fork-child.c: Fix common/ includes.
1043         * findvar.c: Fix common/ includes.
1044         * fbsd-nat.c: Fix common/ includes.
1045         * event-top.c: Fix common/ includes.
1046         * event-loop.c: Fix common/ includes.
1047         * dwarf2read.c: Fix common/ includes.
1048         * dwarf2loc.c: Fix common/ includes.
1049         * dwarf2-frame.c: Fix common/ includes.
1050         * dwarf-index-cache.c: Fix common/ includes.
1051         * dtrace-probe.c: Fix common/ includes.
1052         * disasm-selftests.c: Fix common/ includes.
1053         * defs.h: Fix common/ includes.
1054         * csky-tdep.c: Fix common/ includes.
1055         * cp-valprint.c: Fix common/ includes.
1056         * cp-support.h: Fix common/ includes.
1057         * cp-support.c: Fix common/ includes.
1058         * corelow.c: Fix common/ includes.
1059         * completer.h: Fix common/ includes.
1060         * completer.c: Fix common/ includes.
1061         * compile/compile.c: Fix common/ includes.
1062         * compile/compile-loc2c.c: Fix common/ includes.
1063         * compile/compile-cplus-types.c: Fix common/ includes.
1064         * compile/compile-cplus-symbols.c: Fix common/ includes.
1065         * command.h: Fix common/ includes.
1066         * cli/cli-dump.c: Fix common/ includes.
1067         * cli/cli-cmds.c: Fix common/ includes.
1068         * charset.c: Fix common/ includes.
1069         * build-id.c: Fix common/ includes.
1070         * btrace.h: Fix common/ includes.
1071         * btrace.c: Fix common/ includes.
1072         * breakpoint.h: Fix common/ includes.
1073         * breakpoint.c: Fix common/ includes.
1074         * ax.h:
1075         (enum agent_op): Fix common/ includes.
1076         * ax-general.c (struct aop_map): Fix common/ includes.
1077         * ax-gdb.c: Fix common/ includes.
1078         * auxv.c: Fix common/ includes.
1079         * auto-load.c: Fix common/ includes.
1080         * arm-tdep.c: Fix common/ includes.
1081         * arch/riscv.c: Fix common/ includes.
1082         * arch/ppc-linux-common.c: Fix common/ includes.
1083         * arch/i386.c: Fix common/ includes.
1084         * arch/arm.c: Fix common/ includes.
1085         * arch/arm-linux.c: Fix common/ includes.
1086         * arch/arm-get-next-pcs.c: Fix common/ includes.
1087         * arch/amd64.c: Fix common/ includes.
1088         * arch/aarch64.c: Fix common/ includes.
1089         * arch/aarch64-insn.c: Fix common/ includes.
1090         * arch-utils.c: Fix common/ includes.
1091         * amd64-windows-tdep.c: Fix common/ includes.
1092         * amd64-tdep.c: Fix common/ includes.
1093         * amd64-sol2-tdep.c: Fix common/ includes.
1094         * amd64-obsd-tdep.c: Fix common/ includes.
1095         * amd64-nbsd-tdep.c: Fix common/ includes.
1096         * amd64-linux-tdep.c: Fix common/ includes.
1097         * amd64-linux-nat.c: Fix common/ includes.
1098         * amd64-fbsd-tdep.c: Fix common/ includes.
1099         * amd64-fbsd-nat.c: Fix common/ includes.
1100         * amd64-dicos-tdep.c: Fix common/ includes.
1101         * amd64-darwin-tdep.c: Fix common/ includes.
1102         * agent.c: Fix common/ includes.
1103         * ada-lang.h: Fix common/ includes.
1104         * ada-lang.c: Fix common/ includes.
1105         * aarch64-tdep.c: Fix common/ includes.
1106
1107 2019-01-25  Tom Tromey  <tom@tromey.com>
1108
1109         * common/create-version.sh: Use common/version.h.
1110
1111 2019-01-24  Pedro Alves  <palves@redhat.com>
1112
1113         * infrun.c (signal_stop, signal_print, signal_program)
1114         (signal_catch, signal_pass): Now arrays instead of pointers.
1115         (update_signals_program_target, do_target_resume)
1116         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1117         * linux-nat.c (linux_nat_target::pass_signals)
1118         (linux_nat_target::create_inferior, linux_nat_target::attach):
1119         Adjust.
1120         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1121         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1122         * procfs.c (procfs_target::pass_signals): Adjust.
1123         * record-full.c (record_full_target::resume): Adjust.
1124         * remote.c (remote_target::pass_signals)
1125         (remote_target::program_signals): Adjust.
1126         * target-debug.h (target_debug_print_signals): Now takes a
1127         gdb::array_view as parameter.  Adjust.
1128         * target.h (target_ops) <pass_signals, program_signals>: Replace
1129         pointer and length parameters with gdb::array_view.
1130         (target_pass_signals, target_program_signals): Likewise.
1131         * target-delegates.c: Regenerate.
1132
1133 2019-01-24  Pedro Alves  <palves@redhat.com>
1134
1135         * common/forward-scope-exit.h
1136         (forward_scope_exit::forward_scope_exit): Pass arguments to
1137         m_bind_function directly, instead of creating a std::bind and
1138         copying that.
1139
1140 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1141
1142         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1143         for static members.
1144         (pass_in_v_vfp_candidate): Likewise.
1145
1146 2019-01-23  Tom Tromey  <tom@tromey.com>
1147             Pedro Alves  <palves@redhat.com>
1148
1149         * regcache.c (class regcache_invalidator): Remove.
1150         (regcache::raw_write): Use make_scope_exit.
1151
1152 2019-01-23  Tom Tromey  <tom@tromey.com>
1153
1154         * ui-out.h (class ui_out_emit_type): Update comment.
1155
1156 2019-01-23  Tom Tromey  <tom@tromey.com>
1157
1158         * infrun.c (fetch_inferior_event): Update comment.
1159
1160 2019-01-23  Tom Tromey  <tom@tromey.com>
1161             Pedro Alves  <palves@redhat.com>
1162
1163         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1164         parameter.
1165         (fetch_inferior_event): Use SCOPE_EXIT.
1166
1167
1168 2019-01-23  Tom Tromey  <tom@tromey.com>
1169             Pedro Alves  <palves@redhat.com>
1170
1171         * infrun.c (disable_thread_events): Delete.
1172         (stop_all_threads): Use SCOPE_EXIT.
1173
1174 2019-01-23  Tom Tromey  <tom@tromey.com>
1175             Pedro Alves  <palves@redhat.com>
1176
1177         * symfile.c: Include forward-scope-exit.h.
1178         (clear_symtab_users_cleanup): Replace forward declaration with
1179         a FORWARD_SCOPE_EXIT.
1180         (syms_from_objfile_1): Use the forward_scope_exit and
1181         gdb::optional instead of cleanup_function.
1182         (reread_symbols): Use the forward_scope_exit instead of
1183         cleanup_function.
1184         (clear_symtab_users_cleanup): Remove function.
1185
1186 2019-01-23  Tom Tromey  <tom@tromey.com>
1187             Pedro Alves  <palves@redhat.com>
1188
1189         * linux-nat.c: Include scope-exit.h.
1190         (cleanup_target_stop): Remove.
1191         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1192         SCOPE_EXIT.
1193
1194 2019-01-23  Tom Tromey  <tom@tromey.com>
1195             Pedro Alves  <palves@redhat.com>
1196
1197         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1198         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1199
1200 2019-01-23  Tom Tromey  <tom@tromey.com>
1201             Andrew Burgess  <andrew.burgess@embecosm.com>
1202             Pedro Alves  <palves@redhat.com>
1203
1204         * infrun.c (fetch_inferior_event): Use scope_exit.
1205         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1206         * top.c (execute_command): Use scope_exit.
1207         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1208         * utils.c (do_bpstat_clear_actions_cleanup)
1209         (make_bpstat_clear_actions_cleanup): Remove.
1210
1211 2019-01-23  Tom Tromey  <tom@tromey.com>
1212             Pedro Alves  <palves@redhat.com>
1213
1214         * infrun.c: Include "common/scope-exit.h"
1215         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1216         (wait_for_inferior): Use SCOPE_EXIT.
1217         (fetch_inferior_event): Use scope_exit.
1218
1219 2019-01-23  Tom Tromey  <tom@tromey.com>
1220             Pedro Alves  <palves@redhat.com>
1221
1222         * breakpoint.c (create_breakpoint): Remove cleanup.
1223
1224 2019-01-23  Tom Tromey  <tom@tromey.com>
1225             Andrew Burgess  <andrew.burgess@embecosm.com>
1226             Pedro Alves  <palves@redhat.com>
1227
1228 2019-01-23  Pedro Alves  <palves@redhat.com>
1229
1230         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1231
1232 2019-01-23  Pedro Alves  <palves@redhat.com>
1233             Andrew Burgess  <andrew.burgess@embecosm.com>
1234
1235         * gdbthread.h: Include "common/forward-scope-exit.h".
1236         (scoped_finish_thread_state): Redefine custom class in terms of
1237         forward_scope_exit.
1238
1239 2019-01-23  Pedro Alves  <palves@redhat.com>
1240             Andrew Burgess  <andrew.burgess@embecosm.com>
1241
1242         * common/forward-scope-exit.h: New file.
1243
1244 2019-01-23  Pedro Alves  <palves@redhat.com>
1245             Andrew Burgess  <andrew.burgess@embecosm.com>
1246             Tom Tromey  <tom@tromey.com>
1247
1248         * common/scope-exit.h: New file.
1249
1250 2019-01-23  Pedro Alves  <palves@redhat.com>
1251
1252         * common/preprocessor.h (ESC): Rename to ...
1253         (ESC_PARENS): ... this.
1254         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1255         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1256
1257 2019-01-23  Tom Tromey  <tom@tromey.com>
1258
1259         * language.h (class scoped_switch_to_sym_language_if_auto):
1260         Initialize m_lang in both cases.
1261
1262 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1263
1264         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1265         with XCNEW.
1266
1267 2019-01-22  Tom Tromey  <tom@tromey.com>
1268
1269         * corelow.c: Do not include sys/file.h.
1270
1271 2019-01-22  Tom Tromey  <tom@tromey.com>
1272
1273         * tui/tui-wingeneral.h: Include gdb_curses.h.
1274
1275 2019-01-22  Tom Tromey  <tom@tromey.com>
1276
1277         * source-cache.h (class source_cache) <get_source_lines,
1278         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1279
1280 2019-01-22  Tom Tromey  <tom@tromey.com>
1281
1282         * remote-fileio.h (struct remote_target): Declare.
1283
1284 2019-01-22  Tom Tromey  <tom@tromey.com>
1285
1286         * python/py-arch.c: Do not include py-ref.h.
1287         * python/py-bpevent.c: Do not include py-ref.h.
1288         * python/py-cmd.c: Do not include py-ref.h.
1289         * python/py-continueevent.c: Do not include py-ref.h.
1290         * python/py-event.h: Do not include py-ref.h.
1291         * python/py-evtregistry.c: Do not include py-ref.h.
1292         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1293         * python/py-frame.c: Do not include py-ref.h.
1294         * python/py-framefilter.c: Do not include py-ref.h.
1295         * python/py-function.c: Do not include py-ref.h.
1296         * python/py-infevents.c: Do not include py-ref.h.
1297         * python/py-linetable.c: Do not include py-ref.h.
1298         * python/py-objfile.c: Do not include py-ref.h.
1299         * python/py-param.c: Do not include py-ref.h.
1300         * python/py-prettyprint.c: Do not include py-ref.h.
1301         * python/py-progspace.c: Do not include py-ref.h.
1302         * python/py-symbol.c: Do not include py-ref.h.
1303         * python/py-symtab.c: Do not include py-ref.h.
1304         * python/py-type.c: Do not include py-ref.h.
1305         * python/py-unwind.c: Do not include py-ref.h.
1306         * python/py-utils.c: Do not include py-ref.h.
1307         * python/py-value.c: Do not include py-ref.h.
1308         * python/py-varobj.c: Do not include py-ref.h.
1309         * python/py-xmethods.c: Do not include py-ref.h.
1310         * python/python.c: Do not include py-ref.h.
1311         * varobj.c: Do not include py-ref.h.
1312
1313 2019-01-22  Tom Tromey  <tom@tromey.com>
1314
1315         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1316         keyword for bcache.
1317
1318 2019-01-22  Tom Tromey  <tom@tromey.com>
1319
1320         * compile/compile-cplus-types.c: Remove a comment by #include.
1321
1322 2019-01-22  Tom Tromey  <tom@tromey.com>
1323
1324         * compile/gcc-c-plugin.h: Include compile-internal.h.
1325
1326 2019-01-22  Tom Tromey  <tom@tromey.com>
1327
1328         * stabsread.c (EXTERN): Do not define.
1329         (symnum, next_symbol_text_func, processing_gcc_compilation)
1330         (within_function, global_sym_chain, global_stabs)
1331         (previous_stab_code, this_object_header_files)
1332         (n_this_object_header_files)
1333         (n_allocated_this_object_header_files): Define.
1334         * stabsread.h (EXTERN): Never define.  Use "extern".
1335
1336 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1337
1338         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1339         history_value.
1340
1341 2019-01-21  Tom Tromey  <tom@tromey.com>
1342
1343         * ui-out.c: Fix includes.
1344         * tui/tui-source.c: Fix includes.
1345         * target.c: Fix includes.
1346         * remote.c: Fix includes.
1347         * regcache.c: Fix includes.
1348         * python/py-block.c: Fix includes.
1349         * printcmd.c: Fix includes.
1350         * or1k-tdep.c: Fix includes.
1351         * mi/mi-main.c: Fix includes.
1352         * m32r-tdep.c: Fix includes.
1353         * csky-tdep.c: Fix includes.
1354         * compile/compile-cplus-types.c: Fix includes.
1355         * cli/cli-interp.c: Fix includes.
1356
1357 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1358
1359         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1360         for padding.
1361
1362 2019-01-16  Tom Tromey  <tom@tromey.com>
1363
1364         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1365         earlier.
1366         (struct objfile) <msymbols_range>: Move from top level.
1367         <msymbols>: New method.
1368         (class objfile_msymbols): Remove.
1369         * symtab.c (default_collect_symbol_completion_matches_break_on):
1370         Update.
1371         * symmisc.c (dump_msymbols): Update.
1372         * stabsread.c (scan_file_globals): Update.
1373         * objc-lang.c (info_selectors_command, info_classes_command)
1374         (find_methods): Update.
1375         * minsyms.c (find_solib_trampoline_target): Update.
1376         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1377         * coffread.c (coff_symfile_read): Update.
1378         * ada-lang.c (ada_lookup_simple_minsym)
1379         (ada_collect_symbol_completion_matches): Update.
1380
1381 2019-01-16  Tom Tromey  <tom@tromey.com>
1382
1383         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1384         type.  Remove no-argument constructor.
1385         <iterator::operator++>: Simplify.
1386         <begin>: Update.
1387         <end>: Use minimal_symbol_count.
1388
1389 2019-01-16  Tom Tromey  <tom@tromey.com>
1390
1391         * objfiles.h (struct objfile) <psymtabs>: New method.
1392         (class objfile_psymtabs): Remove.
1393         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1394         typedef.
1395         <range>: New method.
1396         (require_partial_symbols): Change return type.
1397         * psymtab.c (require_partial_symbols)
1398         (psym_expand_symtabs_matching): Update.
1399         * mdebugread.c (parse_partial_symbols): Update.
1400         * dbxread.c (dbx_end_psymtab): Update.
1401
1402 2019-01-15  Tom Tromey  <tom@tromey.com>
1403
1404         * symtab.c (lookup_objfile_from_block)
1405         (lookup_symbol_in_objfile_symtabs)
1406         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1407         (find_line_symtab, info_sources_command)
1408         (default_collect_symbol_completion_matches_break_on)
1409         (make_source_files_completion_list): Update.
1410         * symmisc.c (print_objfile_statistics, dump_objfile)
1411         (maintenance_print_symbols, maintenance_info_symtabs)
1412         (maintenance_check_symtabs, maintenance_info_line_tables):
1413         Update.
1414         * source.c (select_source_symtab)
1415         (forget_cached_source_info_for_objfile): Update.
1416         * objfiles.h (class objfile_compunits): Remove.
1417         (struct objfile) <compunits_range>: New typedef.
1418         (compunits): New method.
1419         * objfiles.c (objfile_relocate1): Update.
1420         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1421         * maint.c (count_symtabs_and_blocks): Update.
1422         * linespec.c (iterate_over_all_matching_symtabs): Update.
1423         * cp-support.c (add_symbol_overload_list_qualified): Update.
1424         * coffread.c (coff_symtab_read): Update.
1425         * ada-lang.c (add_nonlocal_symbols)
1426         (ada_collect_symbol_completion_matches)
1427         (ada_add_global_exceptions): Update.
1428
1429 2019-01-15  Tom Tromey  <tom@tromey.com>
1430
1431         * progspace.h (program_space) <objfiles_safe_range>: New
1432         typedef.
1433         <objfiles_safe>: New method.
1434         * objfiles.h (class all_objfiles_safe): Remove.
1435         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1436         * jit.c (jit_inferior_exit_hook): Update.
1437
1438 2019-01-17  Tom Tromey  <tom@tromey.com>
1439
1440         * progspace.h (program_space) <objfiles_range>: New typedef.
1441         <objfiles>: New method.
1442         <objfiles_head>: Rename from objfiles.
1443         (object_files): Update.
1444         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1445         * guile/scm-pretty-print.c
1446         (ppscm_find_pretty_printer_from_objfiles): Update.
1447         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1448         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1449         Update.
1450         * python/py-progspace.c (pspy_get_objfiles): Update.
1451         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1452         Update.
1453         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1454         (objfpy_lookup_objfile_by_build_id): Update.
1455         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1456         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1457         Update.
1458         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1459         (expand_symtab_containing_pc, lookup_objfile_from_block)
1460         (lookup_static_symbol, basic_lookup_transparent_type)
1461         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1462         (find_line_symtab, info_sources_command)
1463         (default_collect_symbol_completion_matches_break_on)
1464         (make_source_files_completion_list, find_main_name): Update.
1465         * symmisc.c (print_symbol_bcache_statistics)
1466         (print_objfile_statistics, maintenance_print_symbols)
1467         (maintenance_print_msymbols, maintenance_print_objfiles)
1468         (maintenance_info_symtabs, maintenance_check_symtabs)
1469         (maintenance_expand_symtabs, maintenance_info_line_tables):
1470         Update.
1471         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1472         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1473         (map_overlay_command, unmap_overlay_command)
1474         (simple_overlay_update, expand_symtabs_matching)
1475         (map_symbol_filenames): Update.
1476         * symfile-debug.c (set_debug_symfile): Update.
1477         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1478         Update.
1479         * source.c (select_source_symtab, forget_cached_source_info):
1480         Update.
1481         * solib.c (solib_read_symbols): Update.
1482         * solib-spu.c (append_ocl_sos): Update.
1483         * psymtab.c (maintenance_print_psymbols)
1484         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1485         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1486         * printcmd.c (info_symbol_command): Update.
1487         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1488         Update.
1489         * objfiles.h (class all_objfiles): Remove.
1490         * objfiles.c (have_partial_symbols, have_full_symbols)
1491         (have_minimal_symbols, qsort_cmp, update_section_map)
1492         (shared_objfile_contains_address_p)
1493         (default_iterate_over_objfiles_in_search_order): Update.
1494         * objc-lang.c (info_selectors_command, info_classes_command)
1495         (find_methods): Update.
1496         * minsyms.c (find_solib_trampoline_target): Update.
1497         * maint.c (maintenance_info_sections)
1498         (maintenance_translate_address, count_symtabs_and_blocks):
1499         Update.
1500         * main.c (captured_main_1): Update.
1501         * linux-thread-db.c (try_thread_db_load_from_pdir)
1502         (has_libpthread): Update.
1503         * linespec.c (iterate_over_all_matching_symtabs)
1504         (search_minsyms_for_name): Update.
1505         * jit.c (jit_find_objf_with_entry_addr): Update.
1506         * hppa-tdep.c (find_unwind_entry)
1507         (hppa_lookup_stub_minimal_symbol): Update.
1508         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1509         Update.
1510         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1511         (elf_gnu_ifunc_resolve_by_got): Update.
1512         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1513         * dwarf-index-write.c (save_gdb_index_command): Update.
1514         * cp-support.c (add_symbol_overload_list_qualified): Update.
1515         * breakpoint.c (create_overlay_event_breakpoint)
1516         (create_longjmp_master_breakpoint)
1517         (create_std_terminate_master_breakpoint)
1518         (create_exception_master_breakpoint): Update.
1519         * blockframe.c (find_pc_partial_function): Update.
1520         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1521         (ada_collect_symbol_completion_matches)
1522         (ada_add_global_exceptions): Update.
1523
1524 2019-01-17  Tom Tromey  <tom@tromey.com>
1525
1526         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1527         declare VEC.
1528         (solib_target_parse_libraries): Change return type.
1529         (library_list_start_segment, library_list_start_section)
1530         (library_list_end_library, library_list_start_library); Update.
1531         (solib_target_free_library_list): Remove.
1532         (solib_target_parse_libraries): Remove cleanup.  Change return
1533         type.
1534         (solib_target_current_sos): Update.
1535
1536 2019-01-17  Tom Tromey  <tromey@bapiya>
1537
1538         * valprint.c: Replace "the the" with "the".
1539         * symtab.c: Replace "the the" with "the".
1540         * solib.c: Replace "the the" with "the".
1541         * solib-dsbt.c: Replace "the the" with "the".
1542         * linespec.c: Replace "the the" with "the".
1543         * dwarf2loc.h: Replace "the the" with "the".
1544         * amd64-windows-tdep.c: Replace "the the" with "the".
1545         * aarch64-tdep.c: Replace "the the" with "the".
1546
1547 2019-01-16  Keith Seitz  <keiths@redhat.com>
1548
1549         PR gdb/23773
1550         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1551         <builder>: Rename to ..
1552         <m_builder>: ... this and make private.
1553         (dwarf2_cu::get_builder): New method.  Change all users of
1554         `builder' to use this method.
1555         (dwarf2_start_symtab): Move to ...
1556         (dwarf2_cu::start_symtab): ... here.  Update all callers
1557         (setup_type_unit_groups): Move to ...
1558         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1559         callers.
1560         (dwarf2_cu::reset_builder): New method.
1561         (process_full_compunit, process_full_type_unit): Use
1562         dwarf2_cu::reset_builder.
1563         (follow_die_offset): Record the ancestor CU if it is different
1564         from the followed DIE's CU.
1565         (follow_die_sig_1): Likewise.
1566
1567 2019-01-15  Tom Tromey  <tom@tromey.com>
1568
1569         * remote.c (class remote_state) <buf>: Now a char_vector.
1570         <buf_size>: Remove.
1571         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1572         parameter.
1573         (remote_target::getpkt_or_notif_sane_1)
1574         (remote_target::getpkt_sane)
1575         (remote_target::getpkt_or_notif_sane): Likewise.
1576         (class remote_target) <putpkt>: New overload.
1577         (remote_target::read_frame): Change type of "buf_p".  Remove
1578         sizeof_p parameter.
1579         (packet_ok): New overload.
1580         (packet_check_result): New overload.
1581         Update all uses.
1582
1583 2019-01-14  Tom Tromey  <tom@tromey.com>
1584
1585         * remote-notif.c (handle_notification, remote_notif_ack)
1586         (remote_notif_parse): Make "buf" const.
1587         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1588         const.
1589         (remote_notif_parse, remote_notif_ack, handle_notification):
1590         Likewise.
1591         * remote.c (remote_notif_stop_parse): Make "buf" const.
1592         (remote_target::remote_parse_stop_reply): Make "buf" const.
1593         (remote_notif_stop_ack): Make "buf" const.
1594
1595 2019-01-14  Tom Tromey  <tom@tromey.com>
1596
1597         * remote.c (remote_console_output): Make parameter const.
1598
1599 2019-01-14  Tom Tromey  <tom@tromey.com>
1600
1601         * target-debug.h (target_debug_print_signals): Constify.
1602         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1603         * procfs.c (procfs_target::pass_signals): Update.
1604         * linux-nat.c (linux_nat_target::pass_signals): Update.
1605         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1606         * target-delegates.c: Rebuild.
1607         * remote.c (remote_target::program_signals): Update.
1608         (remote_target::pass_signals): Update.
1609         * target.c (target_pass_signals): Constify argument.
1610         (target_program_signals): Likewise.
1611         * target.h (struct target_ops) <pass_signals, program_signals>:
1612         Constify argument.
1613         (target_pass_signals, target_program_signals): Constify argument.
1614
1615 2019-01-14  Tom Tromey  <tom@tromey.com>
1616
1617         PR tui/28819:
1618         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1619
1620 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1621
1622         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1623         field.
1624         * rs6000-tdep.c: Include reggroups.h.
1625         (IS_V_ALIAS_PSEUDOREG): Define.
1626         (rs6000_register_name): Return names for the "vX" aliases.
1627         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1628         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1629         aliases.  Call default_register_reggroup_p for all other
1630         pseudo-registers.
1631         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1632         New functions.
1633         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1634         Handle "vX" aliases.
1635         (v_alias_pseudo_register_collect): New function.
1636         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1637         (rs6000_gdbarch_init): Initialize "vX" aliases as
1638         pseudo-registers.  Restore registration of
1639         rs6000_pseudo_register_reggroup_p with
1640         set_tdesc_pseudo_register_reggroup_p.
1641
1642 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1643
1644         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1645         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1646         set_gdbarch_num_pseudo_regs.
1647
1648 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1649
1650         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1651         Remove arg prefixname, add do_set and do_show.
1652         Add member functions set_list and show_list.
1653         * cli/cli-style.c (class cli_style_option): Update accordingly.
1654         (style_set_list): Move to file scope.
1655         (style_show_list): Likewise.
1656         (set_style): Call help_list.
1657         (show_style): Call cmd_show_list.
1658         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1659         Update to use the new macro.
1660
1661 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1662
1663         * ada-lang.c (_initialize_ada_language): Expand the help text
1664         for the "catch exception" command.
1665
1666 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1667
1668         * symtab.c (matching_obj_sections): Initialize obj,
1669         declare it closer to its usage.
1670
1671 2019-01-10  Tom Tromey  <tom@tromey.com>
1672
1673         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1674         (basic_inf_threads_range): Remove.
1675         (inf_threads_range, inf_non_exited_threads_range)
1676         (safe_inf_threads_range): Use next_adapter.
1677
1678 2019-01-10  Keith Seitz  <keiths@redhat.com>
1679
1680         PR gdb/23712
1681         PR symtab/23010
1682         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1683         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1684
1685 2019-01-10  Keith Seitz  <keiths@redhat.com>
1686
1687         PR gdb/23712
1688         PR symtab/23010
1689         * dictionary.c (pending_to_vector): Remove.
1690         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1691         Remove _1 suffix, replacing functions of the same name.  Update
1692         all callers.
1693         (dict_create_hashed, dict_create_hashed_expandable)
1694         (dict_create_linear, dict_create_linear_expandable, dict_free)
1695         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1696         Make functions static.
1697
1698 2019-01-10  Keith Seitz  <keiths@redhat.com>
1699
1700         PR gdb/23712
1701         PR symtab/23010
1702         * dictionary.h (struct dictionary): Replace declaration with
1703         multidictionary.
1704         (dict_create_hashed, dict_create_hashed_expandable)
1705         (dict_create_linear, dict_create_linear_expandable)
1706         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1707         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1708         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1709         taking multidictionary argument.
1710         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1711         * block.h (struct block) <dict>: Change to multidictionary
1712         and rename `multidict'.
1713         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1714         symmisc.c: Update all dictionary references to multidictionary.
1715
1716 2019-01-10  Keith Seitz  <keiths@redhat.com>
1717
1718         PR gdb/23712
1719         PR symtab/23010
1720         * dictionary.c: Include unordered_map.
1721         (pending_to_vector): New function.
1722         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1723         Rewrite the non-"_1" functions to take vector instead
1724         of linked list.
1725         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1726         "new" _1 versions of the same name.
1727         (multidictionary): Define.
1728         (std::hash<enum language): New definition.
1729         (collate_pending_symbols_by_language, mdict_create_hashed)
1730         (mdict_create_hashed_expandable, mdict_create_linear)
1731         (mdict_create_linear_expandable, mdict_free)
1732         (find_language_dictionary, create_new_language_dictionary)
1733         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1734         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1735         (mdict_size, mdict_empty): New functions.
1736         * dictionary.h (mdict_iterator): Define.
1737
1738 2019-01-10  Pedro Alves  <palves@redhat.com>
1739
1740         * breakpoint.c (read_uploaded_action)
1741         (create_tracepoint_from_upload): Adjust to use
1742         gdb::unique_xmalloc_ptr.
1743         * ctf.c (ctf_write_uploaded_tp):
1744         (SET_ARRAY_FIELD): Use emplace_back.
1745         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1746         * tracefile-tfile.c (tfile_write_uploaded_tp):
1747         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1748         gdb::unique_xmalloc_ptr.
1749         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1750         at_string, cond_string, cmd_strings>: Replace char pointers
1751         with gdb::unique_xmalloc_ptr.
1752
1753 2019-01-10  Pedro Alves  <palves@redhat.com>
1754
1755         * solib-target.c (library_list_start_library): Don't xstrdup name.
1756
1757 2019-01-10  Pedro Alves  <palves@redhat.com>
1758
1759         * mdebugread.c (parse_partial_symbols): Use
1760         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1761
1762 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1763
1764         * linux-fork.c (scoped_switch_fork_info)
1765         <~scoped_switch_fork_info>: Fix incorrect variable name.
1766
1767 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1768
1769         * linux-fork.c (scoped_switch_fork_info)
1770         <scoped_switch_fork_info>: Make explicit.
1771         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1772
1773 2019-01-10  Tom Tromey  <tom@tromey.com>
1774
1775         * objfiles.h (objfile::reset_psymtabs): Update.
1776         * objfiles.c (objfile::objfile): Update.
1777         * psymtab.h (psymtab_storage::obstack): Update.
1778         (psymtab_storage::m_obstack): Use gdb::optional.
1779         (class psymtab_storage): Update comment.  Remove objfile
1780         parameter.
1781         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1782
1783 2019-01-10  Tom Tromey  <tom@tromey.com>
1784
1785         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1786         <free_psymtabs>: Now private.
1787         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1788         (allocate_psymtab): Use new method.
1789
1790 2019-01-10  Tom Tromey  <tom@tromey.com>
1791
1792         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1793         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1794         * mdebugread.c (parse_partial_symbols): Use
1795         allocate_dependencies.
1796         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1797         allocate_dependencies.
1798         (process_psymtab_comp_unit_reader)
1799         (build_type_psymtab_dependencies): Likewise.
1800         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1801
1802 2019-01-10  Tom Tromey  <tom@tromey.com>
1803
1804         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1805         PSYMBOL_SET_LANGUAGE.
1806         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1807
1808 2019-01-10  Tom Tromey  <tom@tromey.com>
1809
1810         * psymtab.h (psymtab_storage::obstack): New method.
1811         <m_obstack>: Rename from obstack; now private.
1812         * psymtab.c (psymtab_storage): Update.
1813         * dwarf2read.c (create_addrmap_from_index)
1814         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1815         Update.
1816
1817 2019-01-10  Tom Tromey  <tom@tromey.com>
1818
1819         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1820         * objfiles.h (objfile::reset_psymtabs): New method.
1821
1822 2019-01-10  Tom Tromey  <tom@tromey.com>
1823
1824         * symmisc.c (print_symbol_bcache_statistics): Update.
1825         (print_objfile_statistics): Update.
1826         * symfile.c (reread_symbols): Update.
1827         * psymtab.h (class psymtab_storage): New.
1828         * psymtab.c (psymtab_storage): New constructor.
1829         (~psymtab_storage): New destructor.
1830         (require_partial_symbols): Update.
1831         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1832         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1833         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1834         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1835         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1836         (start_psymtab_common, end_psymtab_common)
1837         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1838         (allocate_psymtab): Update.
1839         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1840         Update.
1841         (dump_psymtab_addrmap, maintenance_print_psymbols)
1842         (maintenance_check_psymtabs): Update.
1843         (class objfile_psymtabs): Move to objfiles.h.
1844         * psympriv.h (discard_psymtab): Now inline.
1845         (psymtab_discarder::psymtab_discarder): Update.
1846         (psymtab_discarder::~psymtab_discarder): Update.
1847         (ALL_OBJFILE_PSYMTABS): Rewrite.
1848         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1849         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1850         Remove fields.
1851         <partial_symtabs>: New field.
1852         (class objfile_psymtabs): Move from psymtab.h.  Update.
1853         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1854         psymbol_cache.
1855         (objfile::~objfile): Don't destroy psymbol_cache.
1856         * mdebugread.c (parse_partial_symbols): Update.
1857         * dwarf2read.c (create_addrmap_from_index)
1858         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1859         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1860         (add_partial_subprogram, dwarf2_ranges_read): Update.
1861         * dwarf-index-write.c (write_address_map)
1862         (write_one_signatured_type, recursively_write_psymbols)
1863         (class debug_names, class debug_names, write_psymtabs_to_index):
1864         Update.
1865
1866 2019-01-10  Tom Tromey  <tom@tromey.com>
1867
1868         * symtab.h (SYMBOL_SET_NAMES): Update.
1869         (symbol_set_names): Update.
1870         (MSYMBOL_SET_NAMES): Update.
1871         * symtab.c (symbol_set_names): Change argument to be an
1872         objfile_per_bfd_storage.
1873         * psymtab.c (add_psymbol_to_bcache): Update.
1874         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1875
1876 2019-01-10  Tom Tromey  <tom@tromey.com>
1877
1878         * symtab.c (create_demangled_names_hash): Change argument to be an
1879         objfile_per_bfd_storage.
1880         (symbol_set_names): Update.
1881
1882 2019-01-10  Tom Tromey  <tom@tromey.com>
1883
1884         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1885         init_psymbol_list.
1886         * psymtab.c (init_psymbol_list): Do nothing if already called.
1887         * psympriv.h (init_psymbol_list): Add comment.
1888         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1889         init_psymbol_list.
1890         * dbxread.c (dbx_symfile_read): Unconditionally call
1891         init_psymbol_list.
1892
1893 2019-01-10  Tom Tromey  <tom@tromey.com>
1894
1895         * xcoffread.c (scan_xcoff_symtab): Update.
1896         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1897         "where".
1898         * mdebugread.c (parse_partial_symbols)
1899         (handle_psymbol_enumerators): Update.
1900         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1901         * dbxread.c (read_dbx_symtab): Update.
1902         * psympriv.h (psymbol_placement): New enum.
1903         (add_psymbol_to_list): Update.
1904
1905 2019-01-10  Tom Tromey  <tom@tromey.com>
1906
1907         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1908         static_psymbols parameters.
1909         (scan_xcoff_symtab): Update.
1910         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1911         static_psymbols parameters.
1912         * psympriv.h (start_psymtab_common): Update.
1913         * mdebugread.c (parse_partial_symbols): Update.
1914         * dwarf2read.c (create_partial_symtab): Update.
1915         * dbxread.c (read_dbx_symtab): Update.
1916         (start_psymtab): Remove global_psymbols and static_psymbols
1917         parameters.
1918
1919 2019-01-10  Tom Tromey  <tom@tromey.com>
1920
1921         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1922         * psymtab.c (allocate_psymtab): Add comment.
1923         * psympriv.h (allocate_psymtab): Add comment.
1924         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1925         initializations.
1926         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1927
1928 2019-01-10  Tom Tromey  <tom@tromey.com>
1929
1930         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1931         Don't declare.
1932         * mipsread.c: Include mdebugread.h.
1933         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1934         Declare.
1935         * elfread.c: Include mdebugread.h.
1936
1937 2019-01-09  Tom Tromey  <tom@tromey.com>
1938
1939         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1940         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1941         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1942         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1943         (psym_lookup_symbol, psym_find_last_source_symtab)
1944         (psym_forget_cached_source_info, psym_print_stats)
1945         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1946         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1947         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1948         (psym_find_compunit_symtab_by_address)
1949         (maintenance_print_psymbols, maintenance_info_psymtabs)
1950         (maintenance_check_psymtabs): Use ranged for.
1951         * psymtab.h (class objfile_psymtabs): New.
1952         (require_partial_symbols): Return objfile_psymtabs.
1953         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1954
1955 2019-01-09  Tom Tromey  <tom@tromey.com>
1956
1957         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1958         (find_pc_mapped_section, list_overlays_command)
1959         (map_overlay_command, unmap_overlay_command)
1960         (simple_overlay_update): Use all_objfiles.
1961         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1962         * printcmd.c (info_symbol_command): Use all_objfiles.
1963         * objfiles.h (ALL_OBJSECTIONS): Remove.
1964         * maint.c (maintenance_translate_address): Use all_objfiles.
1965         * gcore.c (gcore_create_callback): Use all_objfiles.
1966         (objfile_find_memory_regions): Likewise.
1967
1968 2019-01-09  Tom Tromey  <tom@tromey.com>
1969
1970         * symtab.c (find_line_symtab, info_sources_command)
1971         (make_source_files_completion_list): Use objfile_compunits.
1972         * source.c (select_source_symtab): Use objfile_compunits.
1973         * objfiles.h (struct objfile): Update comment.
1974         (ALL_OBJFILES): Remove.
1975         (ALL_FILETABS): Remove.
1976         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
1977         objfile_compunits.
1978
1979 2019-01-09  Tom Tromey  <tom@tromey.com>
1980
1981         * symmisc.c (print_objfile_statistics, dump_objfile)
1982         (maintenance_print_symbols): Use compunit_filetabs.
1983         * source.c (forget_cached_source_info_for_objfile): Use
1984         compunit_filetabs.
1985         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
1986         (ALL_FILETABS): Use compunit_filetabs.
1987         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
1988         * coffread.c (coff_symtab_read): Use compunit_filetabs.
1989
1990 2019-01-09  Tom Tromey  <tom@tromey.com>
1991
1992         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
1993         (compunit_filetabs): New.
1994         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
1995         compunit_filetabs.
1996         (info_sources_command, make_source_files_completion_list): Remove
1997         declaration.
1998         * symmisc.c (print_objfile_statistics, dump_objfile)
1999         (maintenance_print_symbols): Remove declaration.
2000         (maintenance_info_symtabs): Use compunit_filetabs.
2001         (maintenance_info_line_tables): Likewise.
2002         * source.c (select_source_symtab): Change local variable name.
2003         (forget_cached_source_info_for_objfile): Remove declaration.
2004         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
2005         * objfiles.c (objfile_relocate1): Remove declaration.
2006         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2007         declaration.
2008         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
2009         * coffread.c (coff_symtab_read): Remove declaration.
2010         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2011         compunit_filetabs.
2012
2013 2019-01-09  Tom Tromey  <tom@tromey.com>
2014
2015         * symtab.c (lookup_objfile_from_block)
2016         (find_pc_sect_compunit_symtab, search_symbols)
2017         (default_collect_symbol_completion_matches_break_on): Use
2018         objfile_compunits.
2019         * objfiles.h (ALL_COMPUNITS): Remove.
2020         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
2021         * cp-support.c (add_symbol_overload_list_qualified): Use
2022         objfile_compunits.
2023         * ada-lang.c (ada_collect_symbol_completion_matches)
2024         (ada_add_global_exceptions): Use objfile_compunits.
2025
2026 2019-01-09  Tom Tromey  <tom@tromey.com>
2027
2028         * source.c (select_source_symtab)
2029         (forget_cached_source_info_for_objfile): Remove declaration.
2030         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2031         declaration.
2032         * maint.c (count_symtabs_and_blocks): Remove declaration.
2033         * cp-support.c (add_symbol_overload_list_qualified): Remove
2034         declaration.
2035         * coffread.c (coff_symtab_read): Remove declaration.
2036         * symtab.c (lookup_symbol_in_objfile_symtabs)
2037         (basic_lookup_transparent_type_1): Use objfile_compunits.
2038         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
2039         (info_sources_command, search_symbols)
2040         (default_collect_symbol_completion_matches_break_on)
2041         (make_source_files_completion_list): Remove declaration.
2042         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
2043         (ada_collect_symbol_completion_matches)
2044         (ada_add_global_exceptions): Remove declaration.
2045         * linespec.c (iterate_over_all_matching_symtabs): Use
2046         objfile_compunits.
2047         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
2048         (class objfile_compunits): New.
2049         (ALL_COMPUNITS): Use objfile_compunits.
2050         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
2051         (maintenance_check_symtabs, maintenance_info_line_tables): Use
2052         objfile_compunits.
2053         * objfiles.c (objfile_relocate1): Use objfile_compunits.
2054
2055 2019-01-09  Tom Tromey  <tom@tromey.com>
2056
2057         * symtab.c (search_symbols)
2058         (default_collect_symbol_completion_matches_break_on): Use
2059         objfile_msymbols.
2060         * ada-lang.c (ada_lookup_simple_minsym)
2061         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
2062         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
2063         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
2064         objfile_msymbols.
2065         * coffread.c (coff_symfile_read): Use objfile_msymbols.
2066         * symmisc.c (dump_msymbols): Use objfile_msymbols.
2067         * objc-lang.c (find_methods): Use objfile_msymbols.
2068         (info_selectors_command, info_classes_command): Likewise.
2069         * stabsread.c (scan_file_globals): Use objfile_msymbols.
2070         * objfiles.h (class objfile_msymbols): New.
2071         (ALL_OBJFILE_MSYMBOLS): Remove.
2072         (ALL_MSYMBOLS): Remove.
2073
2074 2019-01-09  Tom Tromey  <tom@tromey.com>
2075
2076         * common/next-iterator.h (next_adapter): Add Iterator template
2077         parameter.
2078         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
2079         (class all_objfiles_safe): New.
2080         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
2081         * objfiles.c (put_objfile_before): Update comment.
2082         (add_separate_debug_objfile): Likewise.
2083         (free_all_objfiles): Use all_objfiles_safe.
2084         (objfile_purge_solibs): Likewise.
2085
2086 2019-01-09  Tom Tromey  <tom@tromey.com>
2087
2088         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2089         (expand_symtab_containing_pc, lookup_static_symbol)
2090         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
2091         (find_symbol_at_address, find_line_symtab, find_main_name): Use
2092         all_objfiles.
2093         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
2094         * breakpoint.c (create_overlay_event_breakpoint)
2095         (create_longjmp_master_breakpoint)
2096         (create_std_terminate_master_breakpoint)
2097         (create_exception_master_breakpoint): Use all_objfiles.
2098         * linux-thread-db.c (try_thread_db_load_from_pdir)
2099         (has_libpthread): Use all_objfiles.
2100         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
2101         * linespec.c (iterate_over_all_matching_symtabs)
2102         (search_minsyms_for_name): Use all_objfiles.
2103         * maint.c (maintenance_info_sections): Use all_objfiles.
2104         * main.c (captured_main_1): Use all_objfiles.
2105         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
2106         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
2107         * guile/scm-pretty-print.c
2108         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
2109         * solib-spu.c (append_ocl_sos): Use all_objfiles.
2110         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2111         (maintenance_print_msymbols): Use all_objfiles.
2112         * source.c (select_source_symtab): Use all_objfiles.
2113         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2114         * symfile.c (remove_symbol_file_command)
2115         (expand_symtabs_matching, map_symbol_filenames): Use
2116         all_objfiles.
2117         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2118         all_objfiles.
2119         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2120         * objc-lang.c (find_methods): Use all_objfiles.
2121         * objfiles.c (have_partial_symbols, have_full_symbols)
2122         (have_minimal_symbols, qsort_cmp)
2123         (default_iterate_over_objfiles_in_search_order): Use
2124         all_objfiles.
2125         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2126         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2127         (maintenance_check_psymtabs): Use all_objfiles.
2128         (ALL_PSYMTABS): Remove.
2129         * compile/compile-object-run.c (do_module_cleanup): Use
2130         all_objfiles.
2131         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2132         * cp-support.c (add_symbol_overload_list_qualified): Use
2133         all_objfiles.
2134         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2135         Use all_objfiles.
2136         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2137         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2138         all_objfiles.
2139         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2140         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2141         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2142         Uses all_objfiles.
2143         * solib.c (solib_read_symbols): Use all_objfiles
2144
2145 2019-01-09  Tom Tromey  <tom@tromey.com>
2146
2147         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2148         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2149         all_objfiles.
2150         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2151         * symmisc.c (print_symbol_bcache_statistics)
2152         (print_objfile_statistics, maintenance_print_objfiles)
2153         (maintenance_info_symtabs, maintenance_check_symtabs)
2154         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2155         all_objfiles.
2156         * source.c (forget_cached_source_info): Use all_objfiles.
2157         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2158         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2159         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2160         * objfiles.c (update_section_map): Use all_objfiles.
2161         (shared_objfile_contains_address_p): Likewise.
2162         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2163         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2164
2165 2019-01-09  Tom Tromey  <tom@tromey.com>
2166
2167         * common/next-iterator.h: New file.
2168         * objfiles.h (class all_objfiles): New.
2169         (struct objfile_iterator): New.
2170
2171 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2172
2173         * NEWS: Move the description of the changed "frame", "select-frame",
2174          and "info frame" commands to the Changed commands section.
2175
2176 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2177
2178         * gdbtypes.c (check_stub_method_group): Remove handling of old
2179         mangling schemes.
2180         * linespec.c (find_methods): Likewise.
2181         * stabsread.c (read_member_functions): Likewise.
2182         * valops.c (search_struct_method): Likewise.
2183         (value_struct_elt_for_reference): Likewise.
2184         * NEWS: Mention this change.
2185
2186 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2187
2188         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2189         print_source_lines.
2190         * source.c (print_source_lines_base): Update line number check.
2191         (print_source_lines): New function.
2192         (source_lines_range::source_lines_range): New function.
2193         * source.h (class source_lines_range): New class.
2194         (print_source_lines): New declaration.
2195
2196 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2197
2198         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2199
2200 2019-01-08  Tom Tromey  <tom@tromey.com>
2201             Simon Marchi  <simon.marchi@ericsson.com>
2202
2203         PR gdb/24060
2204         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2205         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2206         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2207         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2208         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2209         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2210
2211 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2212
2213         * source.c (select_source_symtab): Move header comment to
2214         declaration in source.h.
2215         (forget_cached_source_info_for_objfile): Likewise.
2216         (forget_cached_source_info): Likewise.
2217         (identify_source_line): Likewise.
2218         * source.h (identify_source_line): Move declaration from symtab.h
2219         and add comment from source.c
2220         (print_source_lines): Likewise.
2221         (forget_cached_source_info_for_objfile): Likewise.
2222         (forget_cached_source_info): Likewise.
2223         (select_source_symtab): Likewise.
2224         (enum print_source_lines_flag): Move definition from symtab.h.
2225         * symtab.h (identify_source_line): Move declaration to source.h.
2226         (print_source_lines): Likewise.
2227         (forget_cached_source_info_for_objfile): Likewise.
2228         (forget_cached_source_info): Likewise.
2229         (select_source_symtab): Likewise.
2230         (enum print_source_lines_flag): Move definition to source.h.
2231         * tui/tui-hooks.c: Add 'source.h' include.
2232
2233 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2234
2235         * source.c (print_source_lines_base): Handle requests to print
2236         reverse line number sequences, and guard against empty lines
2237         string.
2238
2239 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2240
2241         * source.c (print_source_lines_base): Fix skip of '\r' if next
2242         character is '\n'.
2243
2244 2019-01-06  Tom Tromey  <tom@tromey.com>
2245
2246         * c-exp.y (struct c_parse_state) <macro_original_text,
2247         expansion_obstack>: New member.
2248         (macro_original_text, expansion_obstack): Remove globals.
2249         (scan_macro_expansion, scanning_macro_expansion)
2250         (finished_macro_expansion): Update.
2251         (scan_macro_cleanup): Remove.
2252         (yylex, c_parse): Update.
2253
2254 2019-01-06  Tom Tromey  <tom@tromey.com>
2255
2256         * c-exp.y (struct c_parse_state) <strings>: New member.
2257         (operator_stoken): Update.
2258
2259 2019-01-06  Tom Tromey  <tom@tromey.com>
2260
2261         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2262         (union type_stack_elt) <typelist_val>: Now a pointer to
2263         std::vector.
2264         (type_stack_cleanup): Don't declare.
2265         (push_typelist): Update.
2266         * parse.c (pop_typelist): Return a std::vector.
2267         (push_typelist): Take a std::vector.
2268         (follow_types): Update.  Do not free args.
2269         (type_stack_cleanup): Remove.
2270         * c-exp.y (struct c_parse_state): New.
2271         (cpstate): New global.
2272         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2273         (nonempty_typelist): Update.
2274         (func_mod): Create a new vector.
2275         (c_parse): Create a c_parse_state.
2276         (check_parameter_typelist): Do not delete params.
2277         (function_method): Update.  Do not delete type_list.
2278
2279 2019-01-06  Tom Tromey  <tom@tromey.com>
2280
2281         PR gdb/28155:
2282         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2283         check_typedef.
2284         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2285         (print_return_value): Likewise.
2286
2287 2019-01-05  Tom Tromey  <tom@tromey.com>
2288
2289         * contrib/cleanup_check.py: Remove.
2290         * contrib/gcc-with-excheck: Remove.
2291         * contrib/exsummary.py: Remove.
2292         * contrib/excheck.py: Remove.
2293
2294 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2295
2296         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2297         NULL. Initialize tpprev to NULL instead of assigning it
2298         to NULL on the next statement.
2299         * windows-nat.c (windows_delete_thread): Remove check for
2300         main_thread_id before printing thread exit notifications.
2301         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2302         Remove thread ID check against main_thread_id.
2303         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2304         windows_delete_thread.
2305         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2306
2307 2019-01-04  Tom Tromey  <tom@tromey.com>
2308
2309         * compile/compile.c (_initialize_compile): Use upper case for
2310         metasyntactic variables.
2311         * symmisc.c (_initialize_symmisc): Use upper case for
2312         metasyntactic variables.
2313         * psymtab.c (_initialize_psymtab): Use upper case for
2314         metasyntactic variables.
2315         * demangle.c (demangle_command): Use upper case for metasyntactic
2316         variables.
2317         (_initialize_demangler): Likewise.
2318         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2319         variables.
2320
2321 2019-01-03  Tom Tromey  <tom@tromey.com>
2322
2323         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2324
2325 2019-01-03  Tom Tromey  <tom@tromey.com>
2326
2327         * python/py-symtab.c (salpy_str): Update.
2328         (struct salpy_sal_object) <symtab>: Now a PyObject.
2329         (salpy_dealloc): Update.
2330         (del_objfile_sal): Use gdbpy_ref.
2331
2332 2019-01-03  Tom Tromey  <tom@tromey.com>
2333
2334         * python/py-type.c (convert_field): Use new_reference.  Return
2335         gdbpy_ref.
2336         (make_fielditem): Return gdbpy_ref.
2337         (typy_fields): Update.
2338         (typy_getitem): Update.
2339         (field_name): Return gdbpy_ref.  Use new_reference.
2340         (typy_iterator_iternext): Update.
2341
2342 2019-01-03  Tom Tromey  <tom@tromey.com>
2343
2344         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2345
2346 2019-01-03  Tom Tromey  <tom@tromey.com>
2347
2348         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2349         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2350         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2351         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2352         (pspy_set_type_printers): Likewise.
2353         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2354         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2355         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2356         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2357         (objfpy_set_type_printers): Likewise.
2358
2359 2019-01-03  Tom Tromey  <tom@tromey.com>
2360
2361         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2362         (gdbpy_print_stack): Use gdbpy_err_fetch.
2363         * python/python-internal.h (class gdbpy_err_fetch): New class.
2364         (class gdbpy_enter) <m_error_type, m_error_value,
2365         m_error_traceback>: Remove.
2366         <m_error>: New member.
2367         (gdbpy_exception_to_string): Don't declare.
2368         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2369         * python/py-value.c (convert_value_from_python): Use
2370         gdbpy_err_fetch.
2371         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2372         gdbpy_exception_to_string.
2373         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2374         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2375         gdbpy_err_fetch.
2376
2377 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2378
2379         * linux-nat.c (delete_lwp_cleanup): Delete.
2380         (struct lwp_deleter): New struct.
2381         (lwp_info_up): New typedef.
2382         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2383         lwp_info_up.
2384
2385 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2386
2387         * linux-fork.c (class scoped_switch_fork_info): New class.
2388         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2389
2390 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2391
2392         * valops.c (find_overload_match): Remove use of null_cleanup, and
2393         calls to do_cleanups.
2394
2395 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2396
2397         * compile/compile-cplus-types.c
2398         (compile_cplus_instance::decl_name): Handle changes to
2399         cp_func_name.
2400         * cp-support.c (cp_func_name): Update header comment, update
2401         return type.
2402         * cp-support.h (cp_func_name): Update return type in declaration.
2403         * valops.c (find_overload_match): Move temp_func local to top
2404         level of function and change its type.  Use temp_func to hold and
2405         delete temporary string obtained from cp_func_name.
2406
2407 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2408
2409         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2410         gdb::char_vector, remove cleanup, and update uses of `msg`.
2411
2412 2019-01-03  Jim Wilson  <jimw@sifive.com>
2413
2414         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2415
2416 2019-01-02  Tom Tromey  <tom@tromey.com>
2417
2418         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2419         (tdesc_parse_xml): Remove cleanups.
2420         * target-descriptions.h (make_cleanup_free_target_description):
2421         Don't declare.
2422         (target_desc_deleter): New struct.
2423         (target_desc_up): New typedef.
2424         * target-descriptions.c (target_desc_deleter::operator()): Rename
2425         from free_target_description.
2426         (make_cleanup_free_target_description): Remove.
2427
2428 2019-01-02  Tom Tromey  <tom@tromey.com>
2429
2430         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2431         constructor, destructor.
2432         (linespec_parser): Remove typedef.
2433         (~linespec_parser): Rename from linespec_parser_delete.
2434         (linespec_lex_to_end, linespec_complete_label)
2435         (linespec_complete): Update.
2436         (decode_line_full): Remove cleanups.
2437         (decode_line_1): Update.
2438
2439 2019-01-02  Tom Tromey  <tom@tromey.com>
2440
2441         * python/python-internal.h (inferior_to_inferior_object): Change
2442         return type.
2443         * python/py-exitedevent.c (create_exited_event_object): Update.
2444         * python/py-inferior.c (inferior_to_inferior_object): Return
2445         gdbpy_ref.
2446         (python_new_inferior, python_inferior_deleted)
2447         (thread_to_thread_object, delete_thread_object)
2448         (build_inferior_list, gdbpy_selected_inferior): Update.
2449         * python/py-infthread.c (create_thread_object): Update.  Also fail
2450         if inferior_to_inferior_object fails.
2451
2452 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2453
2454         * inferior.h (class inferior) <displaced_step_state>: New field.
2455         * infrun.h (struct displaced_step_state): Move here from
2456         infrun.c.  Initialize fields, add constructor.
2457         <inf>: Remove field.
2458         <reset>: New method.
2459         * infrun.c (struct displaced_step_inferior_state): Move to
2460         infrun.h.
2461         (displaced_step_inferior_states): Remove.
2462         (get_displaced_stepping_state): Adust.
2463         (displaced_step_in_progress_any_inferior): Adjust.
2464         (displaced_step_in_progress_thread): Adjust.
2465         (displaced_step_in_progress): Adjust.
2466         (add_displaced_stepping_state): Remove.
2467         (get_displaced_step_closure_by_addr): Adjust.
2468         (remove_displaced_stepping_state): Remove.
2469         (infrun_inferior_exit): Call displaced_step_state.reset.
2470         (use_displaced_stepping): Don't check for NULL.
2471         (displaced_step_prepare_throw): Call
2472         get_displaced_stepping_state.
2473         (displaced_step_fixup): Don't check for NULL.
2474         (prepare_for_detach): Don't check for NULL.
2475
2476 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2477
2478         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2479          in case of call that did not complete.
2480
2481 2019-01-02  Andrey Utkin  <autkin@undo.io>
2482
2483         * symfile.c (find_separate_debug_file): Fix search of debug files for
2484         remote debuggee.
2485
2486 2019-01-02  Tom Tromey  <tom@tromey.com>
2487
2488         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2489         indentation.
2490         * python/py-frame.c (frapy_older): Remove cast.
2491         (frapy_newer): Likewise.
2492         * python/py-breakpoint.c (local_setattro): Remove cast.
2493         * python/py-arch.c (archpy_name): Remove local variable.
2494         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2495
2496 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2497
2498         * unittests/basic_string_view/element_access/char/empty.cc:
2499         Fix year range in copyright header.
2500
2501 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2502
2503         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2504         Delete.
2505         <operator==>: Update with for removed field.
2506         <hash>: Likewise.
2507         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2508         <isa_features>: ...this.
2509         <abi_features>: New field.
2510         (riscv_isa_flen): Update comment.
2511         (riscv_abi_xlen): New declaration.
2512         (riscv_abi_flen): New declaration.
2513         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2514         isa_features.
2515         (riscv_abi_xlen): New function.
2516         (riscv_isa_flen): Update to get answer from isa_features.
2517         (riscv_abi_flen): New function.
2518         (riscv_has_fp_abi): Update to get answer from abi_features.
2519         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2520         xlen and flen.
2521         (riscv_call_info) <xlen, flen>: Update comment.
2522         (riscv_call_arg_struct): Remove invalid assertions
2523         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2524         is removed.
2525         (riscv_gdbarch_init): Gather isa features and abi features
2526         separately, ensure both match on the gdbarch when reusing an old
2527         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2528         a target with 64-bit float hardware.
2529
2530 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2531
2532         * source.c (search_command_helper): Stop reverse search
2533         when line 1 has been searched.
2534
2535 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2536
2537         * record-full.c (record_full_base_target::close): Rewrite
2538         record_full_core_buf_list free logic.
2539
2540 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2541
2542         * break-catch-syscall.c (print_one_catch_syscall): xfree
2543         the last text.
2544
2545 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2546
2547         * top.c (print_gdb_version): Update Copyright year in version
2548         message.
2549
2550 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2551
2552         Update copyright year range in all GDB files.
2553
2554 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2555
2556         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2557
2558 For older changes see ChangeLog-2018.
2559 \f
2560 Local Variables:
2561 mode: change-log
2562 left-margin: 8
2563 fill-column: 74
2564 version-control: never
2565 coding: utf-8
2566 End:
2567