gdb/ChangeLog

   1 2019-05-04  Tom Tromey  <tom@tromey.com>
   2
   3         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
   4         (struct aarch64_call_info): Add initializers.
   5         <si>: Now a std::vector.
   6         (pass_on_stack, aarch64_push_dummy_call): Update.
   7
   8 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
   9             Tom Tromey  <tom@tromey.com>
  10
  11         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
  12         (ppc_threads): Now a std::vector.  Now static.
  13         (hwdebug_find_thread_points_by_tid)
  14         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
  15         Update.
  16
  17 2019-05-04  Tom Tromey  <tom@tromey.com>
  18
  19         * arc-tdep.c (arc_tdesc_init): Return bool.
  20
  21 2019-05-04  Tom Tromey  <tom@tromey.com>
  22
  23         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
  24         Use gdb_assert_not_reached.
  25
  26 2019-05-04  Tom Tromey  <tom@tromey.com>
  27
  28         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
  29         "false".
  30
  31 2019-05-04  Tom Tromey  <tom@tromey.com>
  32
  33         * arc-tdep.c (arc_tdesc_init): Use bool.
  34
  35 2019-05-04  Tom Tromey  <tom@tromey.com>
  36
  37         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
  38
  39 2019-05-04  Tom Tromey  <tom@tromey.com>
  40
  41         * cli/cli-cmds.c (valid_command_p): Return bool.
  42
  43 2019-05-04  Tom Tromey  <tom@tromey.com>
  44
  45         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
  46         * command.h (valid_user_defined_cmd_name_p): Channge return type.
  47
  48 2019-05-04  Raul Tambre  <raul@tambre.ee>
  49
  50         * python/lib/gdb/prompt.py (_ExtendedPrompt)
  51         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
  52         operator for comparison.
  53
  54 2019-05-04  Tom Tromey  <tom@tromey.com>
  55
  56         * psymtab.c (psymbol_name_matches, match_partial_symbol)
  57         (lookup_partial_symbol, print_partial_symbols)
  58         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
  59         (psymbol_compare): Update.
  60         (add_psymbol_to_bcache): Clear the entire psymbol.
  61         (maintenance_check_psymtabs): Update.
  62         * psympriv.h (struct partial_symbol): Don't derive from
  63         general_symbol_info.
  64         <obj_section, unrelocated_address, address,
  65         set_unrelocated_address>: Update.
  66         <ginfo>: New member.
  67         * dwarf-index-write.c (write_psymbols, debug_names::insert)
  68         (debug_names::write_psymbols): Update.
  69
  70 2019-05-04  Tom de Vries  <tdevries@suse.de>
  71
  72         * contrib/cc-with-tweaks.sh: Support -n arg.
  73
  74 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  75
  76         * corelow.c (core_target::detach): Ensure frame cache and
  77         register caches are cleared.
  78         inferior.c (exit_inferior_1): Likewise.
  79
  80 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
  81             Tom Tromey  <tom@tromey.com>
  82
  83         * dictionary.c (collate_pending_symbols_by_language): Remove
  84         "struct" from foreach.
  85         * symtab.c (lookup_global_symbol_from_objfile)
  86         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
  87         foreach.
  88         * ser-tcp.c (net_open): Remove "struct" from foreach.
  89         * objfiles.c (objfile_relocate, objfile_rebase)
  90         (objfile_has_symbols): Remove "struct" from foreach.
  91         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
  92         from foreach.
  93         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
  94         foreach.
  95         * darwin-nat.c (thread_info_from_private_thread_info): Remove
  96         "struct" from foreach.
  97         * ada-lang.c (create_excep_cond_exprs)
  98         (ada_exception_catchpoint_cond_string): Remove "struct" from
  99         foreach.
 100
 101 2019-05-03  Tom Tromey  <tromey@adacore.com>
 102
 103         * ada-exp.y (convert_char_literal): Check suffix of each
 104         enumerator.
 105
 106 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
 107
 108         PR ada/21406:
 109         * ada-exp.y (yywrap): Don't define.
 110         * ada-lex.l (%option): Add noyywrap
 111         (yywrap): Remove.
 112
 113 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
 114
 115         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
 116         _WIN32_WINNT to the XP level, unless already defined to a higher
 117         level.
 118
 119         * unittests/parse-connection-spec-selftests.c:
 120         * ser-tcp.c:
 121         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
 122         override.
 123
 124         * symfile.c (find_separate_debug_file): Remove colon from the
 125         drive spec of DOS/Windows file names of the target, so that the
 126         file name produced from DEBUGDIR and the target's directory will
 127         be valid on DOS/Windows systems.
 128
 129 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 130
 131         * rust-lang.c (val_print_struct): Handle printing structures
 132         containing strings.
 133
 134 2019-05-02  Tom Tromey  <tromey@adacore.com>
 135
 136         * valarith.c (_initialize_valarith): Remove.
 137
 138 2019-05-01  Tom Tromey  <tromey@adacore.com>
 139
 140         * ada-lang.c (ada_value_primitive_field): Treat more fields as
 141         bitfields.
 142
 143 2019-05-01  Tom Tromey  <tromey@adacore.com>
 144
 145         * ada-lang.c (ada_value_assign): Correctly compute starting offset
 146         for big-endian copies.
 147
 148 2019-04-30  Ali Tamur  <tamur@google.com>
 149         * gdb/dwarf2read.c (read_3_bytes): New declaration.
 150         (read_attribute_value): Added DW_FORM_strx1-4 cases.
 151         (read_3_bytes): New function.
 152
 153 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 154
 155         * windows-nat.c (main_thread_id): Delete.
 156         (handle_output_debug_string): Replace main_thread_id by
 157         current_event.dwThreadId.
 158         (fake_create_process): Likewise.
 159         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
 160         Do not set main_thread_id.
 161         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
 162         current_event.dwThreadId.
 163         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
 164
 165 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 166
 167         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
 168         Use current_event.dwThreadId instead of main_thread_id.
 169
 170 2019-04-30  Tom Tromey  <tromey@adacore.com>
 171
 172         * ada-lang.c (ada_lookup_simple_minsyms): New function.
 173         (create_excep_cond_exprs): Iterate over program spaces.
 174         (ada_exception_catchpoint_cond_string): Examine all minimal
 175         symbols for exception types.
 176
 177 2019-04-30  Tom Tromey  <tromey@adacore.com>
 178
 179         PR c++/24470:
 180         * dwarf2read.c (process_structure_scope): Handle case where type
 181         has template parameters but no symbol was created.
 182
 183 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 184             Chris January  <chris.january@arm.com>
 185
 186         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
 187         qualifier.
 188         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
 189
 190 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 191
 192         * f-typeprint.c (f_print_type): Update rules for printing
 193         whitespace.
 194         (f_type_print_varspec_suffix): Likewise.
 195
 196 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 197             Chris January  <chris.january@arm.com>
 198
 199         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
 200         function arguments.
 201
 202 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 203
 204         * f-lang.c (build_fortran_types): Change name of void type to
 205         lower case.
 206         * f-typeprint.c (f_type_print_base): Print the name of the void
 207         type, rather than a fixed string.
 208         * f-valprint.c (f_decorations): Use lower case void string.
 209
 210 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 211             Chris January  <chris.january@arm.com>
 212
 213         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
 214         types for Fortran.
 215
 216 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 217             Chris January  <chris.january@arm.com>
 218             David Lecomber  <david.lecomber@arm.com>
 219
 220         * f-exp.y (BINOP_INTRINSIC): New token.
 221         (exp): New parser rule handling BINOP_INTRINSIC.
 222         (f77_keywords): Add new builtin procedures.
 223         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
 224         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 225         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
 226         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 227         (print_unop_subexp_f): New function.
 228         (print_binop_subexp_f): New function.
 229         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 230         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 231         (dump_subexp_body_f): Likewise.
 232         (operator_check_f): Likewise.
 233         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 234         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
 235
 236 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 237
 238         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
 239         UNOP_KIND.
 240         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
 241         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
 242         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
 243         (operator_length_f): New fuction.
 244         (print_subexp_f): New function.
 245         (op_name_f): New function.
 246         (dump_subexp_body_f): New function.
 247         (operator_check_f): New function.
 248         (exp_descriptor_f): Replace standard expression handling functions
 249         with new functions.
 250         * gdb/fortran-operator.def: New file.
 251         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
 252         * gdb/std-operator.def: Remove UNOP_KIND.
 253
 254 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 255
 256         * std-operator.def: Remove unbalanced, stray double quote
 257         character.
 258
 259 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 260             Chris January  <chris.january@arm.com>
 261             Daniel Everett  <daniel.everett@arm.com>
 262             Nick Forrington  <nick.forrington@arm.com>
 263             Richard Bunt  <richard.bunt@arm.com>
 264
 265         * cp-valprint.c (cp_print_value_fields): Allow an additional level
 266         of depth when printing anonymous structs or unions.
 267         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 268         Don't print either the top-level value, or the children if the
 269         max-depth is exceeded.
 270         (ppscm_print_children): When printing the key of a map, allow one
 271         extra level of depth.
 272         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
 273         print either the top-level value, or the children if the max-depth
 274         is exceeded.
 275         (print_children): When printing the key of a map, allow one extra
 276         level of depth.
 277         * python/py-value.c (valpy_format_string): Add max_depth keyword.
 278         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
 279         (user_print_options): Initialise max_depth field.
 280         (val_print_scalar_or_string_type_p): New function.
 281         (val_print): Check to see if the max depth has been reached.
 282         (val_print_check_max_depth): Define new function.
 283         (show_print_max_depth): New function.
 284         (_initialize_valprint): Add 'print max-depth' option.
 285         * valprint.h (struct value_print_options) <max_depth>: New field.
 286         (val_print_check_max_depth): Declare new function.
 287         * NEWS: Document new feature.
 288
 289 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 290
 291         * ada-lang.c (ada_language_defn): Initialise new field.
 292         * c-lang.c (c_is_string_type_p): New function.
 293         (c_language_defn): Initialise new field.
 294         (cplus_language_defn): Initialise new field.
 295         (asm_language_defn): Initialise new field.
 296         (minimal_language_defn): Initialise new field.
 297         * c-lang.h (c_is_string_type_p): Declare new function.
 298         * d-lang.c (d_language_defn): Initialise new field.
 299         * f-lang.c (f_is_string_type_p): New function.
 300         (f_language_defn): Initialise new field.
 301         * go-lang.c (go_is_string_type_p): New function.
 302         (go_language_defn): Initialise new field.
 303         * language.c (default_is_string_type_p): New function.
 304         (unknown_language_defn): Initialise new field.
 305         (auto_language_defn): Initialise new field.
 306         * language.h (struct language_defn) <la_is_string_type_p>: New
 307         member variable.
 308         (default_is_string_type_p): Declare new function.
 309         * m2-lang.c (m2_language_defn): Initialise new field.
 310         * objc-lang.c (objc_language_defn): Initialise new field.
 311         * opencl-lang.c (opencl_language_defn): Initialise new field.
 312         * p-lang.c (pascal_is_string_type_p): New function.
 313         (pascal_language_defn): Initialise new field.
 314         * rust-lang.c (rust_is_string_type_p): New function.
 315         (rust_language_defn): Initialise new field.
 316
 317 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 318
 319         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 320         New field.
 321         * ada-lang.c (ada_language_defn): Initialise new field.
 322         * c-lang.c (c_language_defn): Likewise.
 323         (cplus_language_defn): Likewise.
 324         (asm_language_defn): Likewise.
 325         (minimal_language_defn): Likewise.
 326         * d-lang.c (d_language_defn): Likewise.
 327         * f-lang.c (f_language_defn): Likewise.
 328         * go-lang.c (go_language_defn): Likewise.
 329         * language.c (unknown_language_defn): Likewise.
 330         (auto_language_defn): Likewise.
 331         * m2-lang.c (m2_language_defn): Likewise.
 332         * objc-lang.c (objc_language_defn): Likewise.
 333         * opencl-lang.c (opencl_language_defn): Likewise.
 334         * p-lang.c (pascal_language_defn): Likewise.
 335         * rust-lang.c (rust_language_defn): Likewise.
 336
 337 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 338
 339         * ada-lang.c (ada_is_character_type): Change return type to bool.
 340         (ada_is_string_type): Likewise.
 341         * ada-lang.h (ada_is_character_type): Update declaration
 342         (ada_is_string_type): Likewise.
 343
 344 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 345
 346         Support style in 'frame|thread apply'
 347
 348         * gdbcmd.h (execute_command_to_string): New term_out parameter.
 349         * record.c (record_start, record_stop): Update callers of
 350         execute_command_to_string with false.
 351         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
 352         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
 353         methods.
 354         (class string_file): New constructor with term_out parameter.
 355         Override methods term_out and can_emit_style_escape.  New member
 356         term_out.
 357         (class stdio_file): Override can_emit_style_escape.
 358         (class tee_file): Override term_out and can_emit_style_escape.
 359         * utils.h (can_emit_style_escape): Remove.
 360         * utils.c (can_emit_style_escape): Likewise.
 361         Update all callers of can_emit_style_escape (SOMESTREAM) to
 362         SOMESTREAM->can_emit_style_escape.
 363         * source-cache.c (source_cache::get_source_lines): Likewise.
 364         * stack.c (frame_apply_command_count): Call execute_command_to_string
 365         passing the term_out characteristic of the current gdb_stdout.
 366         * thread.c (thr_try_catch_cmd): Likewise.
 367         * top.c (execute_command_to_string): pass term_out parameter
 368         to construct the string_file for the command output.
 369         * ui-file.c (term_cli_styling): New function (most code moved
 370         from utils.c can_emit_style_escape).
 371         (string_file::string_file, string_file::can_emit_style_escape,
 372         stdio_file::can_emit_style_escape, tee_file::term_out,
 373         tee_file::can_emit_style_escape): New functions.
 374
 375 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 376
 377         * NEWS: Mention the new set|show may-call-functions.
 378         * infcall.c (may_call_functions_p): New variable.
 379         (show_may_call_functions_p): New function.
 380         (call_function_by_hand_dummy): Throws an error if not
 381         may-call-functions.
 382         (_initialize_infcall): Call add_setshow_boolean_cmd for
 383         may-call-functions.
 384
 385 2019-04-25  Keith Seitz  <keiths@redhat.com>
 386
 387         PR c++/24367
 388         * cp-support.c (inspect_type): Don't attempt substitutions
 389         of symbol with the same name.
 390
 391 2019-04-25  Tom Tromey  <tromey@adacore.com>
 392
 393         PR gdb/24475:
 394         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
 395         static.
 396
 397 2019-04-25  Tom Tromey  <tromey@adacore.com>
 398
 399         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
 400         rvalue reference.
 401         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
 402         (gdb_xml_parser::parse): Use std::move.
 403         * python/python-internal.h (gdbpy_convert_exception): Take a const
 404         reference.
 405         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
 406         std::move.
 407         * python/py-utils.c (gdbpy_convert_exception): Take a const
 408         reference.
 409         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 410         Use std::move.
 411         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 412         Use std::move.
 413         * mi/mi-main.c (mi_print_exception): Take a const reference.
 414         * main.c (handle_command_errors): Take a const reference.
 415         * linespec.c (parse_linespec): Use std::move.
 416         * infcall.c (run_inferior_call): Use std::move.
 417         (call_function_by_hand_dummy): Use std::move.
 418         * exec.c (try_open_exec_file): Use std::move.
 419         * exceptions.h (exception_print, exception_fprintf)
 420         (exception_print_same): Update.
 421         * exceptions.c (print_exception, exception_print)
 422         (exception_fprintf, exception_print_same): Change parameters to
 423         const reference.
 424         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
 425         * common/new-op.c: Use std::move.
 426         * common/common-exceptions.h (struct gdb_exception): Add move
 427         constructor.
 428         (struct gdb_exception_error, struct gdb_exception_quit, struct
 429         gdb_quit_bad_alloc): Change constructor to move constructor.
 430         (throw_exception): Change parameter to rvalue reference.
 431         * common/common-exceptions.c (throw_exception): Take rvalue
 432         reference.
 433         * cli/cli-interp.c (safe_execute_command): Use std::move.
 434         * breakpoint.c (insert_bp_location, location_to_sals): Use
 435         std::move.
 436
 437 2019-04-25  Tom Tromey  <tromey@adacore.com>
 438
 439         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
 440         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
 441         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
 442         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
 443         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
 444         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
 445         guile/scm-value.c: Use unpack.
 446         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
 447         gdbscm_gdb_exception.
 448         (gdbscm_throw_gdb_exception): Likewise.
 449         (struct gdbscm_gdb_exception): New.
 450         (unpack): New function.
 451         (gdbscm_wrap): Use unpack.
 452
 453 2019-04-25  Tom Tromey  <tromey@adacore.com>
 454
 455         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 456         (gdb_rl_callback_handler): Use std::move.
 457         * common/common-exceptions.h (struct gdb_exception): Add move
 458         assignment operator.
 459         (throw_exception_sjlj): Change "exception" to const reference.
 460         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
 461         (throw_exception_sjlj): Change "exception" to const reference.
 462
 463 2019-04-25  Tom Tromey  <tromey@adacore.com>
 464
 465         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
 466         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
 467         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 468         Update.
 469         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 470         Update.
 471         * mi/mi-interp.c (mi_interp::exec): Update.
 472         * linespec.c (parse_linespec): Update.
 473         * infcall.c (run_inferior_call): Update.
 474         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
 475         * guile/scm-symbol.c (gdbscm_lookup_symbol)
 476         (gdbscm_lookup_global_symbol): Update.
 477         * guile/scm-param.c (gdbscm_parameter_value): Update.
 478         * guile/scm-frame.c (gdbscm_frame_read_register)
 479         (gdbscm_frame_read_var): Update.
 480         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
 481         * exec.c (try_open_exec_file): Update.
 482         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 483         (gdb_rl_callback_handler): Update.
 484         * common/common-exceptions.h (exception_none): Don't declare.
 485         * common/common-exceptions.c (exception_none): Don't define.
 486         (struct catcher) <exception>: Update.
 487         * cli/cli-interp.c (safe_execute_command): Update.
 488         * breakpoint.c (insert_bp_location, location_to_sals): Update.
 489
 490 2019-04-25  Ali Tamur  <tamur@google.com>
 491
 492         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
 493         (read_attribute_value): Likewise.
 494         (dwarf2_read_addr_index): Update comment.
 495         (read_str_index): Add DW_FORM_strx.
 496         (dwarf2_string_attr): Likewise.
 497         (dwarf2_const_value_attr): Likewise.
 498         (dump_die_shallow): Likewise.
 499         (dwarf2_fetch_constant_bytes): Likewise.
 500         (skip_form_bytes): Likewise.
 501         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
 502
 503 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
 504
 505         PR corefiles/11608
 506         PR corefiles/18187
 507         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
 508         OFFSET.  Verify if current mapping contains an ELF header.
 509         (linux_find_memory_regions_full): Adjust call to
 510         dump_mapping_p.
 511
 512 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
 513             Kang Li <kanglictf@gmail.com>
 514
 515         PR gdb/21600
 516
 517         * dwarf2-frame.c (read_initial_length): Be consistent about using
 518         unsigned representation of length.
 519         (decode_frame_entry_1): Likewise.  Check for wraparound of
 520         end pointer as well as buffer overflow.
 521
 522 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
 523
 524         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
 525         "vq".
 526
 527 2019-04-24  Tom Tromey  <tromey@adacore.com>
 528
 529         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
 530
 531 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 532
 533         * s12z-tdep.c (s12z_unwind_pc): Delete.
 534         (s12z_unwind_sp): Delete.
 535         (s12z_gdbarch_init): Don't register deleted functions with
 536         gdbarch.
 537
 538 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 539
 540         * rl78-tdep.c (rl78_unwind_sp): Delete.
 541         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
 542
 543 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 544
 545         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
 546         (xstormy16_unwind_pc): Delete.
 547         (xstormy16_dummy_id): Delete.
 548         (xstormy16_gdbarch_init): Don't register deleted functions with
 549         gdbarch.
 550
 551 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 552
 553         * vax-tdep.c (vax_unwind_pc): Delete.
 554         (vax_gdbarch_init): Don't register deleted function with gdbarch.
 555
 556 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 557
 558         * v850-tdep.c (v850_unwind_sp): Delete.
 559         (v850_unwind_pc): Delete.
 560         (v850_dummy_id): Delete.
 561         (v850_gdbarch_init): Don't register deleted functions with
 562         gdbarch.
 563
 564 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 565
 566         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
 567         (tilegx_unwind_pc): Delete.
 568         (tilegx_unwind_dummy_id): Delete.
 569         (tilegx_gdbarch_init): Don't register deleted functions with
 570         gdbarch.
 571
 572 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 573
 574         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
 575         (tic6x_dummy_id): Delete.
 576         (tic6x_gdbarch_init): Don't register deleted functions with
 577         gdbarch.
 578
 579 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 580
 581         * sparc-tdep.c (sparc_unwind_pc): Delete.
 582         (sparc32_gdbarch_init): Don't register deleted function with
 583         gdbarch.
 584
 585 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 586
 587         * sh-tdep.c (sh_unwind_sp): Delete.
 588         (sh_unwind_pc): Delete.
 589         (sh_dummy_id): Delete.
 590         (sh_gdbarch_init): Don't register deleted functions with
 591         gdbarch.
 592
 593 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 594
 595         * score-tdep.c (score_unwind_sp): Delete.
 596         (score_unwind_pc): Delete.
 597         (score_dummy_id): Delete.
 598         (score_gdbarch_init): Don't register deleted functions with
 599         gdbarch.
 600
 601 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 602
 603         * rx-tdep.c (rx_unwind_pc): Delete.
 604         (rx_unwind_sp): Delete.
 605         (rx_dummy_id): Delete.
 606         (rx_gdbarch_init): Don't register deleted functions with
 607         gdbarch.  Update comment.
 608
 609 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 610
 611         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
 612         (rs6000_dummy_id): Delete.
 613         (rs6000_gdbarch_init): Don't register deleted functions with
 614         gdbarch.
 615
 616 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 617
 618         * or1k-tdep.c (or1k_dummy_id): Delete.
 619         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
 620
 621 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 622
 623         * nios2-tdep.c (nios2_dummy_id): Delete.
 624         (nios2_unwind_sp): Delete.
 625         (nios2_gdbarch_init): Don't register deleted functions with
 626         gdbarch.
 627
 628 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 629
 630         * nds32-tdep.c (nds32_dummy_id): Delete.
 631         (nds32_unwind_pc): Delete.
 632         (nds32_unwind_sp): Delete.
 633         (nds32_gdbarch_init): Don't register deleted functions with
 634         gdbarch.
 635
 636 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 637
 638         * msp430-tdep.c (msp430_unwind_pc): Delete.
 639         (msp430_unwind_sp): Delete.
 640         (msp430_dummy_id): Delete.
 641         (msp430_gdbarch_init): Don't register deleted functions with
 642         gdbarch.
 643
 644 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 645
 646         * moxie-tdep.c (moxie_unwind_sp): Delete.
 647         (moxie_unwind_pc): Delete.
 648         (moxie_dummy_id): Delete.
 649         (moxie_gdbarch_init): Don't register deleted functions with
 650         gdbarch.
 651
 652 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 653
 654         * mn10300-tdep.c (mn10300_dummy_id): Delete.
 655         (mn10300_unwind_pc): Delete.
 656         (mn10300_unwind_sp): Delete.
 657         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
 658         mn10300_unwind_sp.
 659         (mn10300_frame_unwind_init): Don't register deleted functions with
 660         gdbarch.
 661
 662 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 663
 664         * mep-tdep.c (mep_unwind_pc): Delete.
 665         (mep_unwind_sp): Delete.
 666         (mep_dummy_id): Delete.
 667         (mep_gdbarch_init): Don't register deleted functions with
 668         gdbarch.
 669
 670 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 671
 672         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
 673         (m68hc11_unwind_sp): Delete.
 674         (m68hc11_gdbarch_init): Don't register deleted functions with
 675         gdbarch.
 676
 677 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 678
 679         * m32r-tdep.c (m32r_unwind_sp): Delete.
 680         (m32r_unwind_pc): Delete.
 681         (m32r_dummy_id): Delete.
 682         (m32r_gdbarch_init): Don't register deleted functions with
 683         gdbarch.
 684
 685 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 686
 687         * m32c-tdep.c (m32c_unwind_pc): Delete.
 688         (m32c_unwind_sp): Delete.
 689         (m32c_dummy_id): Delete.
 690         (m32c_gdbarch_init): Don't register deleted functions with
 691         gdbarch.
 692
 693 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 694
 695         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
 696         (lm32_unwind_pc): Delete.
 697         (lm32_dummy_id): Delete.
 698         (lm32_gdbarch_init): Don't register deleted functions with
 699         gdbarch.
 700
 701 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 702
 703         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
 704         (iq2000_unwind_pc): Delete.
 705         (iq2000_dummy_id): Delete.
 706         (iq2000_gdbarch_init): Don't register deleted functions with
 707         gdbarch.
 708
 709 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 710
 711         * nds32-tdep.c (nds32_type_align): Delete.
 712         (nds32_push_dummy_call): Use type_align instead.
 713
 714 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 715
 716         * arm-tdep.c (arm_type_align): Only handle vector override case.
 717         (arm_push_dummy_call): Use type_align.
 718         (arm_gdbarch_init): Register arm_type_align gdbarch function.
 719
 720 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 721
 722         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
 723         case.
 724         (pass_on_stack): Use type_align.
 725         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
 726         function.
 727
 728 2019-04-23  Tom Tromey  <tromey@adacore.com>
 729
 730         * dwarf2read.c (line_header::file_name_at): Remove unused
 731         overload.
 732
 733 2019-04-23  Tom de Vries  <tdevries@suse.de>
 734
 735         PR gdb/24438
 736         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
 737         invocation.
 738
 739
 740 2019-03-27  Ali Tamur  <tamur@google.com>
 741
 742         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
 743         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
 744         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
 745         (dwarf_expr_context::get_addr_index): Likewise
 746         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
 747         (symbol_needs_eval_context::get_addr_index): Likewise
 748         (disassemble_dwarf_expression): Add DW_OP_addrx
 749         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
 750         (read_cutu_die_from_dwo): Update comment
 751         (skip_one_die): Add DW_FORM_addrx
 752         (read_attribute_value): Likewise
 753         (var_decode_location): Add DW_OP_addrx
 754         (dwarf2_const_value_attr): Add DW_FORM_addrx
 755         (dump_die_shallow): Likewise
 756         (dwarf2_fetch_constant_bytes): Likewise
 757         (decode_locdesc): Add DW_OP_addrx
 758         (skip_form_bytes): Add DW_FORM_addrx
 759
 760 2019-04-22  Ali Tamur  <tamur@google.com>
 761
 762         * MAINTAINERS (Write After Approval): Add self.
 763
 764 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
 765
 766         * solib-svr4.c (get_svr4_info): Add pspace parameter.
 767         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
 768         (open_symbol_file_object): Likewise.
 769         (svr4_default_sos): Add info parameter.
 770         (svr4_read_so_list): Likewise.
 771         (svr4_current_sos_direct): Adjust functions calls to pass down
 772         info.
 773         (svr4_current_sos_1): Add info parameter.
 774         (svr4_current_sos): Call get_svr4_info, pass info down to
 775         svr4_current_sos_1.
 776         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
 777         get_svr4_info.
 778         (svr4_in_dynsym_resolve_code): Pass current_program_space to
 779         get_svr4_info.
 780         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
 781         to get_svr4_info.
 782         (probes_table_remove_objfile_probes): Likewise.
 783         (register_solib_event_probe): Add info parameter.
 784         (solist_update_incremental): Pass info parameter down to
 785         svr4_read_so_list.
 786         (disable_probes_interface): Add info parameter.
 787         (svr4_handle_solib_event): Pass current_program_space to
 788         get_svr4_info.  Adjust disable_probes_interface cleanup.
 789         (svr4_create_probe_breakpoints): Add info parameter, pass it
 790         down to register_solib_event_probe.
 791         (svr4_create_solib_event_breakpoints): Add info parameter,
 792         pass it down to svr4_create_probe_breakpoints.
 793         (enable_break): Pass info down to
 794         svr4_create_solib_event_breakpoints.
 795         (svr4_solib_create_inferior_hook): Pass current_program_space to
 796         get_svr4_info.
 797         (svr4_clear_solib): Likewise.
 798
 799 2019-04-22  Pedro Alves  <palves@redhat.com>
 800
 801         * solib-svr4.c (svr4_free_objfile_observer): New.
 802         (probe_and_action::objfile): New field.
 803         (probes_table_htab_remove_objfile_probes)
 804         (probes_table_remove_objfile_probes): New functions.
 805         (register_solib_event_probe): Add 'objfile' parameter.  Store it
 806         in the new probe_and_action.  Don't store the probe in 'lookup'.
 807         (svr4_create_probe_breakpoints): Pass objfile to
 808         register_solib_event_probe.
 809         (_initialize_svr4_solib): Register a free_objfile observer.
 810
 811 2019-04-19  Tom Tromey  <tom@tromey.com>
 812
 813         * common/queue.h: Remove.
 814
 815 2019-04-19  Tom Tromey  <tom@tromey.com>
 816
 817         * event-loop.c: Don't include "common/queue.h".
 818
 819 2019-04-19  Tom Tromey  <tom@tromey.com>
 820
 821         * remote.c (remote_target): Use delete.
 822         * remote-notif.h: Include <list>, not "common/queue.h".
 823         (notif_client_p): Remove typedef.
 824         (remote_notif_state): Add constructor, destructor, initializer.
 825         <notif_queue>: Now a std::list.
 826         (remote_notif_state_xfree): Don't declare.
 827         * remote-notif.c (remote_notif_process, handle_notification)
 828         (remote_notif_state_allocate): Update.
 829         (~remote_notif_state): Rename from remote_notif_state_xfree.
 830
 831 2019-04-19  Tom Tromey  <tom@tromey.com>
 832
 833         * symfile.c (reread_symbols): Update.
 834         * objfiles.c (objfile_register_static_link)
 835         (objfile_lookup_static_link): Update
 836         (~objfile) Don't delete static_links.
 837         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
 838
 839 2019-04-19  Tom Tromey  <tom@tromey.com>
 840
 841         * type-stack.h (struct type_stack) <insert>: Constify string.
 842         * type-stack.c (type_stack::insert): Constify string.
 843         * gdbtypes.h (lookup_template_type): Update.
 844         (address_space_name_to_int): Update.
 845         * gdbtypes.c (address_space_name_to_int): Make space_identifier
 846         const.
 847         (lookup_template_type): Make name const.
 848         * c-exp.y: Update rules.
 849         (lex_one_token, classify_name, classify_inner_name)
 850         (c_print_token): Update.
 851         * p-exp.y: Update rules.
 852         (yylex): Update.
 853         * f-exp.y: Update rules.
 854         (yylex): Update.
 855         * d-exp.y: Update rules.
 856         (lex_one_token, classify_name, classify_inner_name): Update.
 857         * parse.c (write_dollar_variable, copy_name): Return std::string.
 858         * parser-defs.h (copy_name): Change return type.
 859         * m2-exp.y: Update rules.
 860         (yylex): Update.
 861         * go-exp.y (lex_one_token): Update.
 862         Update rules.
 863         (classify_unsafe_function, classify_packaged_name)
 864         (classify_name, yylex): Update.
 865
 866 2019-04-19  Sergei Trofimovich <siarheit@google.com>
 867
 868         * configure.ac: add --enable-source-highlight switch.
 869         * configure: Regenerate.
 870         * top.c (print_gdb_version): plumb --enable-source-highlight
 871         status to "show configuration".
 872
 873 2019-04-19  Tom Tromey  <tromey@adacore.com>
 874
 875         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
 876         Check ADA_TYPE_P.
 877         (empty_record, ada_template_to_fixed_record_type_1)
 878         (template_to_static_fixed_type)
 879         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
 880         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
 881         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
 882         macros.
 883
 884 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
 885
 886         PR symtab/24423:
 887         * source.c (print_source_lines_base): Advance "iter" when a
 888         control character is seen.
 889
 890 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 891
 892         * inferior.h (struct infcall_suspend_state_deleter):
 893         Catch exception in destructor to avoid crash.
 894
 895 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 896
 897         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
 898         close to the add_com "shell".
 899
 900 2019-04-18  Tom Tromey  <tromey@adacore.com>
 901
 902         * process-stratum-target.h (class process_stratum_target)
 903         <stratum>: Add "final".
 904
 905 2019-04-17  Tom Tromey  <tromey@adacore.com>
 906
 907         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
 908         against nullptr before use.
 909
 910 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
 911
 912         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
 913
 914 2019-04-17  Jim Wilson  <jimw@sifive.com>
 915             Andrew Burgess  <andrew.burgess@embecosm.com>
 916
 917         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
 918         code read might fail, assume 4-byte breakpoint in that case.
 919
 920 2019-04-15  Leszek Swirski  <leszeks@google.com>
 921
 922         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
 923         rather than a hand-rolled POD check when checking for forced MEMORY
 924         classification.
 925
 926 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 927
 928         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
 929         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
 930         function.
 931         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
 932         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
 933         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
 934         declaration.
 935
 936 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 937
 938         * aarch64-linux-nat.c
 939         (aarch64_linux_nat_target::thread_architecture): Add override.
 940         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
 941         each VQ.
 942
 943 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 944
 945         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
 946
 947 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
 948
 949         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
 950         target types of size 96-bits, add some additional comments, and
 951         check that the builtin type we found was the correct size.
 952
 953 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
 954
 955         * utils.c (prompt_for_continue): Don't restore the styling at the
 956         end, as applied_style has the wrong value.  This fixes styling in
 957         long lists of file names that are interrupted by the "Continue?"
 958         prompt.
 959
 960 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 961
 962         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
 963         * c-lang.c (c_language_defn): Likewise.
 964         (cplus_language_defn): Likewise.
 965         (asm_language_defn): Likewise.
 966         (minimal_language_defn): Likewise.
 967         * d-lang.c (d_language_defn): Likewise.
 968         * f-lang.c (f_language_defn): Likewise.
 969         * go-lang.c (go_language_defn): Likewise.
 970         * language.c (unknown_language_defn): Likewise.
 971         (auto_language_defn): Likewise.
 972         * language.h (struct language_defn): Remove la_magic field.
 973         (LANG_MAGIC): Delete.
 974         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
 975         * objc-lang.c (objc_language_defn): Likewise.
 976         * opencl-lang.c (opencl_language_defn): Likewise.
 977         * p-lang.c (pascal_language_defn): Likewise.
 978         * rust-lang.c (rust_language_defn): Likewise.
 979
 980 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 981
 982         * riscv-tdep.c (riscv_type_align): New function.
 983         (riscv_type_alignment): Delete.
 984         (riscv_arg_location): Use 'type_align'.
 985         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
 986
 987 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 988
 989         * gdbtypes.c (type_align): A struct with no non-static fields also
 990         has alignment of 1.
 991
 992 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 993
 994         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
 995         component to 0.
 996         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
 997         member.
 998         (riscv_struct_info::analyse): New implementation using new
 999         analyse_inner member function.
1000         (riscv_struct_info::field_offset): New member function.
1001         (riscv_struct_info::m_offsets): New member variable.
1002         (riscv_struct_info::analyse_inner): New private member function,
1003         takes the old implementation of riscv_struct_info::analyse but
1004         extended to track field offsets.
1005         (riscv_call_arg_struct): Update the struct folding special cases
1006         to handle cases where empty C++ structs, which are non-zero
1007         length, are found.
1008         (riscv_arg_location): Initialise the length of each location, a
1009         non-zero length now indicates the location is in use.
1010         (riscv_push_dummy_call): Allow for the first location having a
1011         non-zero offset when setting up arguments.
1012         (riscv_return_value): Likewise, but for return values.
1013
1014 2019-04-11  Tom Tromey  <tromey@adacore.com>
1015
1016         * utils.c (internal_vproblem): Make "msg" const.
1017
1018 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
1019
1020         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
1021         * trad-frame.c (trad_frame_reset_saved_regs): New function.
1022         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
1023         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
1024
1025 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
1026
1027         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
1028         function.
1029         (fill_gregset): Call amd64_linux_collect_native_gregset instead
1030         of amd64_collect_native_gregset.
1031         (amd64_linux_nat_target::store_registers): Likewise.
1032
1033 2019-04-10  Tom Tromey  <tom@tromey.com>
1034
1035         * symtab.c (lookup_global_symbol_from_objfile)
1036         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
1037         * objfiles.h (class separate_debug_iterator): New.
1038         (class separate_debug_range): New.
1039         (struct objfile) <separate_debug_objfiles>: New method.
1040         (objfile_separate_debug_iterate): Don't declare.
1041         * objfiles.c (separate_debug_iterator::operator++): Rename from
1042         objfile_separate_debug_iterate.
1043         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
1044         iterator.
1045         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
1046         iterator.
1047
1048 2019-04-10  Tom Tromey  <tom@tromey.com>
1049
1050         * symfile.c (reread_symbols): Remove old comment.
1051         * objfiles.c (free_all_objfiles): Fix a typo.
1052
1053 2019-04-10  Tom Tromey  <tom@tromey.com>
1054
1055         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
1056         * minsyms.c (lookup_minimal_symbol): Use foreach.
1057         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
1058         (lookup_minimal_symbol_solib_trampoline): Likewise.
1059         * symfile.c (reread_symbols): Use foreach.
1060
1061 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
1062             Tom Tromey  <tromey@adacore.com>
1063
1064         PR rust/24414:
1065         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
1066         (rust_lex_int_test): Change "value" to be LONGEST.
1067         (rust_lex_tests): Add test for long integer literal.
1068
1069 2019-04-09  Tom Tromey  <tromey@adacore.com>
1070
1071         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
1072         to bool.
1073         (extended_remote_target::attach): Update.
1074         (remote_target::remote_notice_new_inferior): Update.
1075         (remote_target::add_current_inferior_and_thread): Update.
1076         * inferior.c (exit_inferior_1): Use "false".
1077         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
1078
1079 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
1080
1081         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
1082         the "start" command.
1083
1084 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1085
1086         * python/py-inferior.c (infpy_thread_from_thread_handle):
1087         Adjust comments to reflect renaming of thread_from_thread_handle
1088         to thread_from_handle.  Adjust keywords.  Fix type error message.
1089         (inferior_object_methods): Add thread_from_handle.  Retain
1090         thread_from_thread_handle, but mark it as deprecated.
1091
1092 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1093
1094         * gdbthread.h (find_thread_by_handle): Revise declaration.
1095         * thread.c (find_thread_by_handle): Likewise.  Adjust
1096         implementation too.
1097         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
1098         support for buffer objects as handles.
1099
1100 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1101
1102         * python/py-infthread.c (thpy_thread_handle): New function.
1103         (thread_object_methods): Register thpy_thread_handle.
1104
1105 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1106
1107         * gdbthread.h (thread_to_thread_handle): Declare.
1108         * thread.c (gdbtypes.h): Include.
1109         (thread_to_thread_handle): New function.
1110
1111         * target.h (struct target_ops): Add thread_info_to_thread_handle.
1112         (target_thread_info_to_thread_handle): Declare.
1113         * target.c (target_thread_info_to_thread_handle): New function.
1114         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
1115         * target-delegates.c: Regenerate.
1116
1117         * linux-thread-db.c (class thread_db_target): Add method
1118         thread_info_to_thread_handle.
1119         (thread_db_target::thread_info_to_thread_handle): Define.
1120         * remote.c (class remote_target): Add new method
1121         thread_info_to_thread_handle.
1122         (remote_target::thread_info_to_thread_handle): Define.
1123
1124 2019-04-08  Pedro Alves  <palves@redhat.com>
1125
1126         * common/common-exceptions.c (throw_exception): Don't create
1127         named object to throw; throw directly.
1128         (throw_it): Likewise.  Don't initialize gdb_exception::message
1129         here, with new; pass FMT and AP to the ctor instead.
1130         * common/common-exceptions.h: Include <string>.
1131         (gdb_exception::gdb_exception(enum return_reason, enum errors,
1132         const char *, va_list)): New ctor.  Use std::make_shared.
1133         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1134         errors)): Delete.
1135         (gdb_exception_error::gdb_exception_error(enum errors, const char
1136         *, va_list)): New.
1137         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1138         Add assertion.
1139         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1140         errors)): Delete.
1141         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1142         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1143         Add assertion.
1144
1145 2019-04-08  Tom Tromey  <tom@tromey.com>
1146
1147         * valops.c (value_rtti_indirect_type): Replace throw_exception
1148         with throw.
1149         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1150         with throw.
1151         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1152         throw.
1153         * target.c (target_translate_tls_address): Replace throw_exception
1154         with throw.
1155         * stack.c (frame_apply_command_count): Replace throw_exception
1156         with throw.
1157         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1158         throw.
1159         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1160         with throw.
1161         * rs6000-tdep.c (rs6000_frame_cache)
1162         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1163         * remote.c: Replace throw_exception with throw.
1164         * record-full.c (record_full_message, record_full_wait_1)
1165         (record_full_restore): Replace throw_exception with throw.
1166         * record-btrace.c:
1167         (get_thread_current_frame_id, record_btrace_start_replaying)
1168         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1169         (cmd_record_btrace_start): Replace throw_exception with throw.
1170         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1171         throw.
1172         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1173         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1174         * linespec.c:
1175         (find_linespec_symbols): Replace throw_exception with throw.
1176         * infrun.c (displaced_step_prepare, resume): Replace
1177         throw_exception with throw.
1178         * infcmd.c (post_create_inferior): Replace throw_exception with
1179         throw.
1180         * inf-loop.c (inferior_event_handler): Replace throw_exception
1181         with throw.
1182         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1183         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1184         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1185         (get_prev_frame_always, get_frame_pc_if_available)
1186         (get_frame_address_in_block_if_available, get_frame_language):
1187         Replace throw_exception with throw.
1188         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1189         throw_exception with throw.
1190         * eval.c (fetch_subexp_value, evaluate_var_value)
1191         (evaluate_funcall, evaluate_subexp_standard): Replace
1192         throw_exception with throw.
1193         * dwarf2loc.c (call_site_find_chain)
1194         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1195         Replace throw_exception with throw.
1196         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1197         with throw.
1198         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1199         throw.
1200         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1201         * completer.c (complete_line_internal): Replace throw_exception
1202         with throw.
1203         * compile/compile-object-run.c (compile_object_run): Replace
1204         throw_exception with throw.
1205         * cli/cli-script.c (process_next_line): Replace throw_exception
1206         with throw.
1207         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1208         (btrace_enable, btrace_maint_update_pt_packets): Replace
1209         throw_exception with throw.
1210         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1211         throw_exception with throw.
1212         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1213         throw_exception with throw.
1214         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1215         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1216         * aarch64-tdep.c (aarch64_make_prologue_cache)
1217         (aarch64_make_stub_cache): Replace throw_exception with throw.
1218
1219 2019-04-08  Tom Tromey  <tom@tromey.com>
1220
1221         * common/common-exceptions.c (throw_exception): Rename from
1222         throw_exception_cxx.  Remove old copy.  Make argument const.
1223         (throw_it): Create and throw exception objects directly.
1224         * common/common-exceptions.h (throw_exception): Make argument
1225         const.
1226         (struct gdb_exception_error): Add constructor.
1227         (struct gdb_exception_quit): Add constructor.
1228
1229 2019-04-08  Tom Tromey  <tom@tromey.com>
1230
1231         * common/common-exceptions.h (exception_rethrow): Don't declare.
1232         (TRY_SJLJ): Update comment.
1233         (TRY, CATCH, END_CATCH): Remove.
1234         * common/common-exceptions.c (exception_rethrow): Remove.
1235
1236 2019-04-08  Tom Tromey  <tom@tromey.com>
1237
1238         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1239         Remove.
1240         (gdb_exception_error): Rename from
1241         gdb_exception_RETURN_MASK_ERROR.
1242         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1243         (gdb_quit_bad_alloc): Update.
1244         * aarch64-tdep.c: Update.
1245         * ada-lang.c: Update.
1246         * ada-typeprint.c: Update.
1247         * ada-valprint.c: Update.
1248         * amd64-tdep.c: Update.
1249         * arch-utils.c: Update.
1250         * break-catch-throw.c: Update.
1251         * breakpoint.c: Update.
1252         * btrace.c: Update.
1253         * c-varobj.c: Update.
1254         * cli/cli-cmds.c: Update.
1255         * cli/cli-interp.c: Update.
1256         * cli/cli-script.c: Update.
1257         * common/common-exceptions.c: Update.
1258         * common/new-op.c: Update.
1259         * common/selftest.c: Update.
1260         * compile/compile-c-symbols.c: Update.
1261         * compile/compile-cplus-symbols.c: Update.
1262         * compile/compile-object-load.c: Update.
1263         * compile/compile-object-run.c: Update.
1264         * completer.c: Update.
1265         * corelow.c: Update.
1266         * cp-abi.c: Update.
1267         * cp-support.c: Update.
1268         * cp-valprint.c: Update.
1269         * darwin-nat.c: Update.
1270         * disasm-selftests.c: Update.
1271         * dtrace-probe.c: Update.
1272         * dwarf-index-cache.c: Update.
1273         * dwarf-index-write.c: Update.
1274         * dwarf2-frame-tailcall.c: Update.
1275         * dwarf2-frame.c: Update.
1276         * dwarf2loc.c: Update.
1277         * dwarf2read.c: Update.
1278         * eval.c: Update.
1279         * event-loop.c: Update.
1280         * event-top.c: Update.
1281         * exec.c: Update.
1282         * f-valprint.c: Update.
1283         * fbsd-tdep.c: Update.
1284         * frame-unwind.c: Update.
1285         * frame.c: Update.
1286         * gdbtypes.c: Update.
1287         * gnu-v3-abi.c: Update.
1288         * guile/guile-internal.h: Update.
1289         * guile/scm-block.c: Update.
1290         * guile/scm-breakpoint.c: Update.
1291         * guile/scm-cmd.c: Update.
1292         * guile/scm-disasm.c: Update.
1293         * guile/scm-frame.c: Update.
1294         * guile/scm-lazy-string.c: Update.
1295         * guile/scm-math.c: Update.
1296         * guile/scm-param.c: Update.
1297         * guile/scm-ports.c: Update.
1298         * guile/scm-pretty-print.c: Update.
1299         * guile/scm-symbol.c: Update.
1300         * guile/scm-symtab.c: Update.
1301         * guile/scm-type.c: Update.
1302         * guile/scm-value.c: Update.
1303         * i386-linux-tdep.c: Update.
1304         * i386-tdep.c: Update.
1305         * inf-loop.c: Update.
1306         * infcall.c: Update.
1307         * infcmd.c: Update.
1308         * infrun.c: Update.
1309         * jit.c: Update.
1310         * language.c: Update.
1311         * linespec.c: Update.
1312         * linux-fork.c: Update.
1313         * linux-nat.c: Update.
1314         * linux-tdep.c: Update.
1315         * linux-thread-db.c: Update.
1316         * main.c: Update.
1317         * mi/mi-cmd-break.c: Update.
1318         * mi/mi-cmd-stack.c: Update.
1319         * mi/mi-interp.c: Update.
1320         * mi/mi-main.c: Update.
1321         * objc-lang.c: Update.
1322         * p-valprint.c: Update.
1323         * parse.c: Update.
1324         * ppc-linux-tdep.c: Update.
1325         * printcmd.c: Update.
1326         * python/py-arch.c: Update.
1327         * python/py-breakpoint.c: Update.
1328         * python/py-cmd.c: Update.
1329         * python/py-finishbreakpoint.c: Update.
1330         * python/py-frame.c: Update.
1331         * python/py-framefilter.c: Update.
1332         * python/py-gdb-readline.c: Update.
1333         * python/py-inferior.c: Update.
1334         * python/py-infthread.c: Update.
1335         * python/py-lazy-string.c: Update.
1336         * python/py-linetable.c: Update.
1337         * python/py-objfile.c: Update.
1338         * python/py-param.c: Update.
1339         * python/py-prettyprint.c: Update.
1340         * python/py-progspace.c: Update.
1341         * python/py-record-btrace.c: Update.
1342         * python/py-record.c: Update.
1343         * python/py-symbol.c: Update.
1344         * python/py-type.c: Update.
1345         * python/py-unwind.c: Update.
1346         * python/py-utils.c: Update.
1347         * python/py-value.c: Update.
1348         * python/python.c: Update.
1349         * record-btrace.c: Update.
1350         * record-full.c: Update.
1351         * remote-fileio.c: Update.
1352         * remote.c: Update.
1353         * riscv-tdep.c: Update.
1354         * rs6000-aix-tdep.c: Update.
1355         * rs6000-tdep.c: Update.
1356         * rust-exp.y: Update.
1357         * rust-lang.c: Update.
1358         * s390-tdep.c: Update.
1359         * selftest-arch.c: Update.
1360         * solib-dsbt.c: Update.
1361         * solib-frv.c: Update.
1362         * solib-spu.c: Update.
1363         * solib-svr4.c: Update.
1364         * solib.c: Update.
1365         * sparc64-linux-tdep.c: Update.
1366         * stack.c: Update.
1367         * symfile-mem.c: Update.
1368         * symmisc.c: Update.
1369         * target.c: Update.
1370         * thread.c: Update.
1371         * top.c: Update.
1372         * tracefile-tfile.c: Update.
1373         * tui/tui.c: Update.
1374         * typeprint.c: Update.
1375         * unittests/cli-utils-selftests.c: Update.
1376         * unittests/parse-connection-spec-selftests.c: Update.
1377         * valops.c: Update.
1378         * valprint.c: Update.
1379         * value.c: Update.
1380         * varobj.c: Update.
1381         * windows-nat.c: Update.
1382         * x86-linux-nat.c: Update.
1383         * xml-support.c: Update.
1384
1385 2019-04-08  Tom Tromey  <tom@tromey.com>
1386
1387         * xml-support.c: Use C++ exception handling.
1388         * x86-linux-nat.c: Use C++ exception handling.
1389         * windows-nat.c: Use C++ exception handling.
1390         * varobj.c: Use C++ exception handling.
1391         * value.c: Use C++ exception handling.
1392         * valprint.c: Use C++ exception handling.
1393         * valops.c: Use C++ exception handling.
1394         * unittests/parse-connection-spec-selftests.c: Use C++ exception
1395         handling.
1396         * unittests/cli-utils-selftests.c: Use C++ exception handling.
1397         * typeprint.c: Use C++ exception handling.
1398         * tui/tui.c: Use C++ exception handling.
1399         * tracefile-tfile.c: Use C++ exception handling.
1400         * top.c: Use C++ exception handling.
1401         * thread.c: Use C++ exception handling.
1402         * target.c: Use C++ exception handling.
1403         * symmisc.c: Use C++ exception handling.
1404         * symfile-mem.c: Use C++ exception handling.
1405         * stack.c: Use C++ exception handling.
1406         * sparc64-linux-tdep.c: Use C++ exception handling.
1407         * solib.c: Use C++ exception handling.
1408         * solib-svr4.c: Use C++ exception handling.
1409         * solib-spu.c: Use C++ exception handling.
1410         * solib-frv.c: Use C++ exception handling.
1411         * solib-dsbt.c: Use C++ exception handling.
1412         * selftest-arch.c: Use C++ exception handling.
1413         * s390-tdep.c: Use C++ exception handling.
1414         * rust-lang.c: Use C++ exception handling.
1415         * rust-exp.y: Use C++ exception handling.
1416         * rs6000-tdep.c: Use C++ exception handling.
1417         * rs6000-aix-tdep.c: Use C++ exception handling.
1418         * riscv-tdep.c: Use C++ exception handling.
1419         * remote.c: Use C++ exception handling.
1420         * remote-fileio.c: Use C++ exception handling.
1421         * record-full.c: Use C++ exception handling.
1422         * record-btrace.c: Use C++ exception handling.
1423         * python/python.c: Use C++ exception handling.
1424         * python/py-value.c: Use C++ exception handling.
1425         * python/py-utils.c: Use C++ exception handling.
1426         * python/py-unwind.c: Use C++ exception handling.
1427         * python/py-type.c: Use C++ exception handling.
1428         * python/py-symbol.c: Use C++ exception handling.
1429         * python/py-record.c: Use C++ exception handling.
1430         * python/py-record-btrace.c: Use C++ exception handling.
1431         * python/py-progspace.c: Use C++ exception handling.
1432         * python/py-prettyprint.c: Use C++ exception handling.
1433         * python/py-param.c: Use C++ exception handling.
1434         * python/py-objfile.c: Use C++ exception handling.
1435         * python/py-linetable.c: Use C++ exception handling.
1436         * python/py-lazy-string.c: Use C++ exception handling.
1437         * python/py-infthread.c: Use C++ exception handling.
1438         * python/py-inferior.c: Use C++ exception handling.
1439         * python/py-gdb-readline.c: Use C++ exception handling.
1440         * python/py-framefilter.c: Use C++ exception handling.
1441         * python/py-frame.c: Use C++ exception handling.
1442         * python/py-finishbreakpoint.c: Use C++ exception handling.
1443         * python/py-cmd.c: Use C++ exception handling.
1444         * python/py-breakpoint.c: Use C++ exception handling.
1445         * python/py-arch.c: Use C++ exception handling.
1446         * printcmd.c: Use C++ exception handling.
1447         * ppc-linux-tdep.c: Use C++ exception handling.
1448         * parse.c: Use C++ exception handling.
1449         * p-valprint.c: Use C++ exception handling.
1450         * objc-lang.c: Use C++ exception handling.
1451         * mi/mi-main.c: Use C++ exception handling.
1452         * mi/mi-interp.c: Use C++ exception handling.
1453         * mi/mi-cmd-stack.c: Use C++ exception handling.
1454         * mi/mi-cmd-break.c: Use C++ exception handling.
1455         * main.c: Use C++ exception handling.
1456         * linux-thread-db.c: Use C++ exception handling.
1457         * linux-tdep.c: Use C++ exception handling.
1458         * linux-nat.c: Use C++ exception handling.
1459         * linux-fork.c: Use C++ exception handling.
1460         * linespec.c: Use C++ exception handling.
1461         * language.c: Use C++ exception handling.
1462         * jit.c: Use C++ exception handling.
1463         * infrun.c: Use C++ exception handling.
1464         * infcmd.c: Use C++ exception handling.
1465         * infcall.c: Use C++ exception handling.
1466         * inf-loop.c: Use C++ exception handling.
1467         * i386-tdep.c: Use C++ exception handling.
1468         * i386-linux-tdep.c: Use C++ exception handling.
1469         * guile/scm-value.c: Use C++ exception handling.
1470         * guile/scm-type.c: Use C++ exception handling.
1471         * guile/scm-symtab.c: Use C++ exception handling.
1472         * guile/scm-symbol.c: Use C++ exception handling.
1473         * guile/scm-pretty-print.c: Use C++ exception handling.
1474         * guile/scm-ports.c: Use C++ exception handling.
1475         * guile/scm-param.c: Use C++ exception handling.
1476         * guile/scm-math.c: Use C++ exception handling.
1477         * guile/scm-lazy-string.c: Use C++ exception handling.
1478         * guile/scm-frame.c: Use C++ exception handling.
1479         * guile/scm-disasm.c: Use C++ exception handling.
1480         * guile/scm-cmd.c: Use C++ exception handling.
1481         * guile/scm-breakpoint.c: Use C++ exception handling.
1482         * guile/scm-block.c: Use C++ exception handling.
1483         * guile/guile-internal.h: Use C++ exception handling.
1484         * gnu-v3-abi.c: Use C++ exception handling.
1485         * gdbtypes.c: Use C++ exception handling.
1486         * frame.c: Use C++ exception handling.
1487         * frame-unwind.c: Use C++ exception handling.
1488         * fbsd-tdep.c: Use C++ exception handling.
1489         * f-valprint.c: Use C++ exception handling.
1490         * exec.c: Use C++ exception handling.
1491         * event-top.c: Use C++ exception handling.
1492         * event-loop.c: Use C++ exception handling.
1493         * eval.c: Use C++ exception handling.
1494         * dwarf2read.c: Use C++ exception handling.
1495         * dwarf2loc.c: Use C++ exception handling.
1496         * dwarf2-frame.c: Use C++ exception handling.
1497         * dwarf2-frame-tailcall.c: Use C++ exception handling.
1498         * dwarf-index-write.c: Use C++ exception handling.
1499         * dwarf-index-cache.c: Use C++ exception handling.
1500         * dtrace-probe.c: Use C++ exception handling.
1501         * disasm-selftests.c: Use C++ exception handling.
1502         * darwin-nat.c: Use C++ exception handling.
1503         * cp-valprint.c: Use C++ exception handling.
1504         * cp-support.c: Use C++ exception handling.
1505         * cp-abi.c: Use C++ exception handling.
1506         * corelow.c: Use C++ exception handling.
1507         * completer.c: Use C++ exception handling.
1508         * compile/compile-object-run.c: Use C++ exception handling.
1509         * compile/compile-object-load.c: Use C++ exception handling.
1510         * compile/compile-cplus-symbols.c: Use C++ exception handling.
1511         * compile/compile-c-symbols.c: Use C++ exception handling.
1512         * common/selftest.c: Use C++ exception handling.
1513         * common/new-op.c: Use C++ exception handling.
1514         * cli/cli-script.c: Use C++ exception handling.
1515         * cli/cli-interp.c: Use C++ exception handling.
1516         * cli/cli-cmds.c: Use C++ exception handling.
1517         * c-varobj.c: Use C++ exception handling.
1518         * btrace.c: Use C++ exception handling.
1519         * breakpoint.c: Use C++ exception handling.
1520         * break-catch-throw.c: Use C++ exception handling.
1521         * arch-utils.c: Use C++ exception handling.
1522         * amd64-tdep.c: Use C++ exception handling.
1523         * ada-valprint.c: Use C++ exception handling.
1524         * ada-typeprint.c: Use C++ exception handling.
1525         * ada-lang.c: Use C++ exception handling.
1526         * aarch64-tdep.c: Use C++ exception handling.
1527
1528 2019-04-08  Tom Tromey  <tom@tromey.com>
1529
1530         * xml-support.c (gdb_xml_parser::parse): Update.
1531         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1532         * value.c (show_convenience): Update.
1533         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
1534         (test_parse_flags_qcs): Update.
1535         * thread.c (thr_try_catch_cmd): Update.
1536         * target.c (target_translate_tls_address): Update.
1537         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1538         (info_frame_command_core, frame_apply_command_count): Update.
1539         * rust-exp.y (rust_lex_exception_test): Update.
1540         * riscv-tdep.c (riscv_print_one_register_info): Update.
1541         * remote.c (remote_target::enable_btrace): Update.
1542         * record-btrace.c (record_btrace_enable_warn): Update.
1543         * python/py-utils.c (gdbpy_convert_exception): Update.
1544         * printcmd.c (do_one_display, print_variable_and_value): Update.
1545         * mi/mi-main.c (mi_print_exception): Update.
1546         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
1547         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1548         * linux-nat.c (linux_nat_target::attach): Update.
1549         * linux-fork.c (class scoped_switch_fork_info): Update.
1550         * infrun.c (displaced_step_prepare): Update.
1551         * infcall.c (call_function_by_hand_dummy): Update.
1552         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
1553         * gnu-v3-abi.c (print_one_vtable): Update.
1554         * frame.c (get_prev_frame_always): Update.
1555         * f-valprint.c (info_common_command_for_block): Update.
1556         * exec.c (try_open_exec_file): Update.
1557         * exceptions.c (print_exception, exception_print)
1558         (exception_fprintf, exception_print_same): Update.
1559         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
1560         * dwarf-index-cache.c (index_cache::store)
1561         (index_cache::lookup_gdb_index): Update.
1562         * darwin-nat.c (maybe_cache_shell): Update.
1563         * cp-valprint.c (cp_print_value_fields): Update.
1564         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
1565         (gcc_cplus_symbol_address): Update.
1566         * compile/compile-c-symbols.c (gcc_convert_symbol)
1567         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
1568         * common/selftest.c: Update.
1569         * common/common-exceptions.h (struct gdb_exception) <message>: Now
1570         a std::string.
1571         (exception_try_scope_entry, exception_try_scope_exit): Don't
1572         declare.
1573         (struct exception_try_scope): Remove.
1574         (TRY): Don't use exception_try_scope.
1575         (struct gdb_exception): Add constructor, operator=.
1576         <what>: New method.
1577         (struct gdb_exception_RETURN_MASK_ALL)
1578         (struct gdb_exception_RETURN_MASK_ERROR)
1579         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
1580         (struct gdb_quit_bad_alloc): Update.
1581         * common/common-exceptions.c (exception_none): Change
1582         initializer.
1583         (struct catcher) <state, exception>: Initialize inline.
1584         <prev>: Remove member.
1585         (current_catcher): Remove.
1586         (catchers): New global.
1587         (exceptions_state_mc_init): Simplify.
1588         (catcher_pop): Remove.
1589         (exceptions_state_mc, exceptions_state_mc_catch): Update.
1590         (try_scope_depth, exception_try_scope_entry)
1591         (exception_try_scope_exit): Remove.
1592         (throw_exception_sjlj): Update.
1593         (exception_messages, exception_messages_size): Remove.
1594         (throw_it): Simplify.
1595         (gdb_exception_sliced_copy): Remove.
1596         (throw_exception_cxx): Update.
1597         * cli/cli-script.c (script_from_file): Update.
1598         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
1599         Update.
1600         * ada-valprint.c (ada_val_print): Update.
1601         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
1602         (create_excep_cond_exprs): Update.
1603
1604 2019-04-08  Tom Tromey  <tom@tromey.com>
1605
1606         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
1607         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
1608         (TRY, CATCH, END_CATCH): Remove some definitions.
1609         * common/common-exceptions.c: Don't use GDB_XCPT.
1610         (catcher_list_size): Remove.
1611         (throw_exception, throw_it): Simplify.
1612
1613 2019-04-05  Tom Tromey  <tom@tromey.com>
1614
1615         Revert the header-sorting patch.
1616         * ft32-tdep.c: Revert.
1617         * frv-tdep.c: Revert.
1618         * frv-linux-tdep.c: Revert.
1619         * frame.c: Revert.
1620         * frame-unwind.c: Revert.
1621         * frame-base.c: Revert.
1622         * fork-child.c: Revert.
1623         * findvar.c: Revert.
1624         * findcmd.c: Revert.
1625         * filesystem.c: Revert.
1626         * filename-seen-cache.h: Revert.
1627         * filename-seen-cache.c: Revert.
1628         * fbsd-tdep.c: Revert.
1629         * fbsd-nat.h: Revert.
1630         * fbsd-nat.c: Revert.
1631         * f-valprint.c: Revert.
1632         * f-typeprint.c: Revert.
1633         * f-lang.c: Revert.
1634         * extension.h: Revert.
1635         * extension.c: Revert.
1636         * extension-priv.h: Revert.
1637         * expprint.c: Revert.
1638         * exec.h: Revert.
1639         * exec.c: Revert.
1640         * exceptions.c: Revert.
1641         * event-top.c: Revert.
1642         * event-loop.c: Revert.
1643         * eval.c: Revert.
1644         * elfread.c: Revert.
1645         * dwarf2read.h: Revert.
1646         * dwarf2read.c: Revert.
1647         * dwarf2loc.c: Revert.
1648         * dwarf2expr.h: Revert.
1649         * dwarf2expr.c: Revert.
1650         * dwarf2-frame.c: Revert.
1651         * dwarf2-frame-tailcall.c: Revert.
1652         * dwarf-index-write.h: Revert.
1653         * dwarf-index-write.c: Revert.
1654         * dwarf-index-common.c: Revert.
1655         * dwarf-index-cache.h: Revert.
1656         * dwarf-index-cache.c: Revert.
1657         * dummy-frame.c: Revert.
1658         * dtrace-probe.c: Revert.
1659         * disasm.h: Revert.
1660         * disasm.c: Revert.
1661         * disasm-selftests.c: Revert.
1662         * dictionary.c: Revert.
1663         * dicos-tdep.c: Revert.
1664         * demangle.c: Revert.
1665         * dcache.h: Revert.
1666         * dcache.c: Revert.
1667         * darwin-nat.h: Revert.
1668         * darwin-nat.c: Revert.
1669         * darwin-nat-info.c: Revert.
1670         * d-valprint.c: Revert.
1671         * d-namespace.c: Revert.
1672         * d-lang.c: Revert.
1673         * ctf.c: Revert.
1674         * csky-tdep.c: Revert.
1675         * csky-linux-tdep.c: Revert.
1676         * cris-tdep.c: Revert.
1677         * cris-linux-tdep.c: Revert.
1678         * cp-valprint.c: Revert.
1679         * cp-support.c: Revert.
1680         * cp-namespace.c: Revert.
1681         * cp-abi.c: Revert.
1682         * corelow.c: Revert.
1683         * corefile.c: Revert.
1684         * continuations.c: Revert.
1685         * completer.h: Revert.
1686         * completer.c: Revert.
1687         * complaints.c: Revert.
1688         * coffread.c: Revert.
1689         * coff-pe-read.c: Revert.
1690         * cli-out.h: Revert.
1691         * cli-out.c: Revert.
1692         * charset.c: Revert.
1693         * c-varobj.c: Revert.
1694         * c-valprint.c: Revert.
1695         * c-typeprint.c: Revert.
1696         * c-lang.c: Revert.
1697         * buildsym.c: Revert.
1698         * buildsym-legacy.c: Revert.
1699         * build-id.h: Revert.
1700         * build-id.c: Revert.
1701         * btrace.c: Revert.
1702         * bsd-uthread.c: Revert.
1703         * breakpoint.h: Revert.
1704         * breakpoint.c: Revert.
1705         * break-catch-throw.c: Revert.
1706         * break-catch-syscall.c: Revert.
1707         * break-catch-sig.c: Revert.
1708         * blockframe.c: Revert.
1709         * block.c: Revert.
1710         * bfin-tdep.c: Revert.
1711         * bfin-linux-tdep.c: Revert.
1712         * bfd-target.c: Revert.
1713         * bcache.c: Revert.
1714         * ax-general.c: Revert.
1715         * ax-gdb.h: Revert.
1716         * ax-gdb.c: Revert.
1717         * avr-tdep.c: Revert.
1718         * auxv.c: Revert.
1719         * auto-load.c: Revert.
1720         * arm-wince-tdep.c: Revert.
1721         * arm-tdep.c: Revert.
1722         * arm-symbian-tdep.c: Revert.
1723         * arm-pikeos-tdep.c: Revert.
1724         * arm-obsd-tdep.c: Revert.
1725         * arm-nbsd-tdep.c: Revert.
1726         * arm-nbsd-nat.c: Revert.
1727         * arm-linux-tdep.c: Revert.
1728         * arm-linux-nat.c: Revert.
1729         * arm-fbsd-tdep.c: Revert.
1730         * arm-fbsd-nat.c: Revert.
1731         * arm-bsd-tdep.c: Revert.
1732         * arch-utils.c: Revert.
1733         * arc-tdep.c: Revert.
1734         * arc-newlib-tdep.c: Revert.
1735         * annotate.h: Revert.
1736         * annotate.c: Revert.
1737         * amd64-windows-tdep.c: Revert.
1738         * amd64-windows-nat.c: Revert.
1739         * amd64-tdep.c: Revert.
1740         * amd64-sol2-tdep.c: Revert.
1741         * amd64-obsd-tdep.c: Revert.
1742         * amd64-obsd-nat.c: Revert.
1743         * amd64-nbsd-tdep.c: Revert.
1744         * amd64-nbsd-nat.c: Revert.
1745         * amd64-nat.c: Revert.
1746         * amd64-linux-tdep.c: Revert.
1747         * amd64-linux-nat.c: Revert.
1748         * amd64-fbsd-tdep.c: Revert.
1749         * amd64-fbsd-nat.c: Revert.
1750         * amd64-dicos-tdep.c: Revert.
1751         * amd64-darwin-tdep.c: Revert.
1752         * amd64-bsd-nat.c: Revert.
1753         * alpha-tdep.c: Revert.
1754         * alpha-obsd-tdep.c: Revert.
1755         * alpha-nbsd-tdep.c: Revert.
1756         * alpha-mdebug-tdep.c: Revert.
1757         * alpha-linux-tdep.c: Revert.
1758         * alpha-linux-nat.c: Revert.
1759         * alpha-bsd-tdep.c: Revert.
1760         * alpha-bsd-nat.c: Revert.
1761         * aix-thread.c: Revert.
1762         * agent.c: Revert.
1763         * addrmap.c: Revert.
1764         * ada-varobj.c: Revert.
1765         * ada-valprint.c: Revert.
1766         * ada-typeprint.c: Revert.
1767         * ada-tasks.c: Revert.
1768         * ada-lang.c: Revert.
1769         * aarch64-tdep.c: Revert.
1770         * aarch64-ravenscar-thread.c: Revert.
1771         * aarch64-newlib-tdep.c: Revert.
1772         * aarch64-linux-tdep.c: Revert.
1773         * aarch64-linux-nat.c: Revert.
1774         * aarch64-fbsd-tdep.c: Revert.
1775         * aarch64-fbsd-nat.c: Revert.
1776         * aarch32-linux-nat.c: Revert.
1777
1778 2019-04-05  Tom Tromey  <tom@tromey.com>
1779
1780         * ft32-tdep.c: Sort headers.
1781         * frv-tdep.c: Sort headers.
1782         * frv-linux-tdep.c: Sort headers.
1783         * frame.c: Sort headers.
1784         * frame-unwind.c: Sort headers.
1785         * frame-base.c: Sort headers.
1786         * fork-child.c: Sort headers.
1787         * findvar.c: Sort headers.
1788         * findcmd.c: Sort headers.
1789         * filesystem.c: Sort headers.
1790         * filename-seen-cache.h: Sort headers.
1791         * filename-seen-cache.c: Sort headers.
1792         * fbsd-tdep.c: Sort headers.
1793         * fbsd-nat.h: Sort headers.
1794         * fbsd-nat.c: Sort headers.
1795         * f-valprint.c: Sort headers.
1796         * f-typeprint.c: Sort headers.
1797         * f-lang.c: Sort headers.
1798         * extension.h: Sort headers.
1799         * extension.c: Sort headers.
1800         * extension-priv.h: Sort headers.
1801         * expprint.c: Sort headers.
1802         * exec.h: Sort headers.
1803         * exec.c: Sort headers.
1804         * exceptions.c: Sort headers.
1805         * event-top.c: Sort headers.
1806         * event-loop.c: Sort headers.
1807         * eval.c: Sort headers.
1808         * elfread.c: Sort headers.
1809         * dwarf2read.h: Sort headers.
1810         * dwarf2read.c: Sort headers.
1811         * dwarf2loc.c: Sort headers.
1812         * dwarf2expr.h: Sort headers.
1813         * dwarf2expr.c: Sort headers.
1814         * dwarf2-frame.c: Sort headers.
1815         * dwarf2-frame-tailcall.c: Sort headers.
1816         * dwarf-index-write.h: Sort headers.
1817         * dwarf-index-write.c: Sort headers.
1818         * dwarf-index-common.c: Sort headers.
1819         * dwarf-index-cache.h: Sort headers.
1820         * dwarf-index-cache.c: Sort headers.
1821         * dummy-frame.c: Sort headers.
1822         * dtrace-probe.c: Sort headers.
1823         * disasm.h: Sort headers.
1824         * disasm.c: Sort headers.
1825         * disasm-selftests.c: Sort headers.
1826         * dictionary.c: Sort headers.
1827         * dicos-tdep.c: Sort headers.
1828         * demangle.c: Sort headers.
1829         * dcache.h: Sort headers.
1830         * dcache.c: Sort headers.
1831         * darwin-nat.h: Sort headers.
1832         * darwin-nat.c: Sort headers.
1833         * darwin-nat-info.c: Sort headers.
1834         * d-valprint.c: Sort headers.
1835         * d-namespace.c: Sort headers.
1836         * d-lang.c: Sort headers.
1837         * ctf.c: Sort headers.
1838         * csky-tdep.c: Sort headers.
1839         * csky-linux-tdep.c: Sort headers.
1840         * cris-tdep.c: Sort headers.
1841         * cris-linux-tdep.c: Sort headers.
1842         * cp-valprint.c: Sort headers.
1843         * cp-support.c: Sort headers.
1844         * cp-namespace.c: Sort headers.
1845         * cp-abi.c: Sort headers.
1846         * corelow.c: Sort headers.
1847         * corefile.c: Sort headers.
1848         * continuations.c: Sort headers.
1849         * completer.h: Sort headers.
1850         * completer.c: Sort headers.
1851         * complaints.c: Sort headers.
1852         * coffread.c: Sort headers.
1853         * coff-pe-read.c: Sort headers.
1854         * cli-out.h: Sort headers.
1855         * cli-out.c: Sort headers.
1856         * charset.c: Sort headers.
1857         * c-varobj.c: Sort headers.
1858         * c-valprint.c: Sort headers.
1859         * c-typeprint.c: Sort headers.
1860         * c-lang.c: Sort headers.
1861         * buildsym.c: Sort headers.
1862         * buildsym-legacy.c: Sort headers.
1863         * build-id.h: Sort headers.
1864         * build-id.c: Sort headers.
1865         * btrace.c: Sort headers.
1866         * bsd-uthread.c: Sort headers.
1867         * breakpoint.h: Sort headers.
1868         * breakpoint.c: Sort headers.
1869         * break-catch-throw.c: Sort headers.
1870         * break-catch-syscall.c: Sort headers.
1871         * break-catch-sig.c: Sort headers.
1872         * blockframe.c: Sort headers.
1873         * block.c: Sort headers.
1874         * bfin-tdep.c: Sort headers.
1875         * bfin-linux-tdep.c: Sort headers.
1876         * bfd-target.c: Sort headers.
1877         * bcache.c: Sort headers.
1878         * ax-general.c: Sort headers.
1879         * ax-gdb.h: Sort headers.
1880         * ax-gdb.c: Sort headers.
1881         * avr-tdep.c: Sort headers.
1882         * auxv.c: Sort headers.
1883         * auto-load.c: Sort headers.
1884         * arm-wince-tdep.c: Sort headers.
1885         * arm-tdep.c: Sort headers.
1886         * arm-symbian-tdep.c: Sort headers.
1887         * arm-pikeos-tdep.c: Sort headers.
1888         * arm-obsd-tdep.c: Sort headers.
1889         * arm-nbsd-tdep.c: Sort headers.
1890         * arm-nbsd-nat.c: Sort headers.
1891         * arm-linux-tdep.c: Sort headers.
1892         * arm-linux-nat.c: Sort headers.
1893         * arm-fbsd-tdep.c: Sort headers.
1894         * arm-fbsd-nat.c: Sort headers.
1895         * arm-bsd-tdep.c: Sort headers.
1896         * arch-utils.c: Sort headers.
1897         * arc-tdep.c: Sort headers.
1898         * arc-newlib-tdep.c: Sort headers.
1899         * annotate.h: Sort headers.
1900         * annotate.c: Sort headers.
1901         * amd64-windows-tdep.c: Sort headers.
1902         * amd64-windows-nat.c: Sort headers.
1903         * amd64-tdep.c: Sort headers.
1904         * amd64-sol2-tdep.c: Sort headers.
1905         * amd64-obsd-tdep.c: Sort headers.
1906         * amd64-obsd-nat.c: Sort headers.
1907         * amd64-nbsd-tdep.c: Sort headers.
1908         * amd64-nbsd-nat.c: Sort headers.
1909         * amd64-nat.c: Sort headers.
1910         * amd64-linux-tdep.c: Sort headers.
1911         * amd64-linux-nat.c: Sort headers.
1912         * amd64-fbsd-tdep.c: Sort headers.
1913         * amd64-fbsd-nat.c: Sort headers.
1914         * amd64-dicos-tdep.c: Sort headers.
1915         * amd64-darwin-tdep.c: Sort headers.
1916         * amd64-bsd-nat.c: Sort headers.
1917         * alpha-tdep.c: Sort headers.
1918         * alpha-obsd-tdep.c: Sort headers.
1919         * alpha-nbsd-tdep.c: Sort headers.
1920         * alpha-mdebug-tdep.c: Sort headers.
1921         * alpha-linux-tdep.c: Sort headers.
1922         * alpha-linux-nat.c: Sort headers.
1923         * alpha-bsd-tdep.c: Sort headers.
1924         * alpha-bsd-nat.c: Sort headers.
1925         * aix-thread.c: Sort headers.
1926         * agent.c: Sort headers.
1927         * addrmap.c: Sort headers.
1928         * ada-varobj.c: Sort headers.
1929         * ada-valprint.c: Sort headers.
1930         * ada-typeprint.c: Sort headers.
1931         * ada-tasks.c: Sort headers.
1932         * ada-lang.c: Sort headers.
1933         * aarch64-tdep.c: Sort headers.
1934         * aarch64-ravenscar-thread.c: Sort headers.
1935         * aarch64-newlib-tdep.c: Sort headers.
1936         * aarch64-linux-tdep.c: Sort headers.
1937         * aarch64-linux-nat.c: Sort headers.
1938         * aarch64-fbsd-tdep.c: Sort headers.
1939         * aarch64-fbsd-nat.c: Sort headers.
1940         * aarch32-linux-nat.c: Sort headers.
1941
1942 2019-04-04  Tom Tromey  <tom@tromey.com>
1943
1944         * varobj.c (varobj_create): Update.
1945         * rust-exp.y (struct rust_parser) <update_innermost_block,
1946         lookup_symbol>: New methods.
1947         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
1948         Rename.
1949         (rust_parser::rust_lookup_type)
1950         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1951         * printcmd.c (display_command, do_one_display): Update.
1952         * parser-defs.h (struct parser_state) <parser_state>: Add
1953         "tracker" parameter.
1954         (block_tracker): New member.
1955         (class innermost_block_tracker) <innermost_block_tracker>: Add
1956         "types" parameter.
1957         <reset>: Remove method.
1958         (innermost_block): Don't declare.
1959         (null_post_parser): Update.
1960         * parse.c (innermost_block): Remove global.
1961         (write_dollar_variable): Update.
1962         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
1963         Remove "tracker_types" parameter.
1964         (parse_expression): Add "tracker" parameter.
1965         (parse_expression_for_completion): Update.
1966         (null_post_parser): Add "tracker" parameter.
1967         * p-exp.y: Update rules.
1968         * m2-exp.y: Update rules.
1969         * language.h (struct language_defn) <la_post_parser>: Add
1970         "tracker" parameter.
1971         * go-exp.y: Update rules.
1972         * f-exp.y: Update rules.
1973         * expression.h (parse_expression, parse_exp_1): Add "tracker"
1974         parameter.
1975         * d-exp.y: Update rules.
1976         * c-exp.y: Update rules.
1977         * breakpoint.c (set_breakpoint_condition): Create an
1978         innermost_block_tracker.
1979         (watch_command_1): Likewise.
1980         * ada-lang.c (resolve): Add "tracker" parameter.
1981         (resolve_subexp): Likewise.
1982         * ada-exp.y (write_var_from_sym): Update.
1983
1984 2019-04-04  Tom Tromey  <tom@tromey.com>
1985
1986         * type-stack.h: New file.
1987         * type-stack.c: New file.
1988         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
1989         type-stack.h.
1990         (insert_into_type_stack, insert_type, push_type, push_type_int)
1991         (insert_type_address_space, pop_type, pop_type_int)
1992         (pop_typelist, pop_type_stack, append_type_stack)
1993         (push_type_stack, get_type_stack, push_typelist)
1994         (follow_type_instance_flags, follow_types): Don't declare.
1995         * parse.c (type_stack): Remove global.
1996         (parse_exp_in_context): Update.
1997         (insert_into_type_stack, insert_type, push_type, push_type_int)
1998         (insert_type_address_space, pop_type, pop_type_int)
1999         (pop_typelist, pop_type_stack, append_type_stack)
2000         (push_type_stack, get_type_stack, push_typelist)
2001         (follow_type_instance_flags, follow_types): Remove (moved to
2002         type-stack.c).
2003         * f-exp.y (type_stack): New global.
2004         Update rules.
2005         (push_kind_type, f_parse): Update.
2006         * d-exp.y (type_stack): New global.
2007         Update rules.
2008         (d_parse): Update.
2009         * c-exp.y (struct c_parse_state) <type_stack>: New member.
2010         Update rules.
2011         * Makefile.in (COMMON_SFILES): Add type-stack.c.
2012         (HFILES_NO_SRCDIR): Add type-stack.h.
2013
2014 2019-04-04  Tom Tromey  <tom@tromey.com>
2015
2016         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
2017         (rust_parser::convert_ast_to_expression, rust_parse)
2018         (rust_lex_test_completion, rust_lex_tests): Update.
2019         * parser-defs.h (struct expr_completion_state): New.
2020         (struct parser_state) <parser_state>: Add completion parameter.
2021         <mark_struct_expression, mark_completion_tag>: New methods.
2022         <parse_completion, m_completion_state>: New members.
2023         (prefixify_expression, null_post_parser): Update.
2024         (mark_struct_expression, mark_completion_tag): Don't declare.
2025         * parse.c (parse_completion, expout_last_struct)
2026         (expout_tag_completion_type, expout_completion_name): Remove
2027         globals.
2028         (parser_state::mark_struct_expression)
2029         (parser_state::mark_completion_tag): Now methods.
2030         (prefixify_expression): Add last_struct parameter.
2031         (prefixify_subexp): Likewise.
2032         (parse_exp_1): Update.
2033         (parse_exp_in_context): Add cstate parameter.  Update.
2034         (parse_expression_for_completion): Create an
2035         expr_completion_state.
2036         (null_post_parser): Add "completion" parameter.
2037         * p-exp.y: Update rules.
2038         (yylex): Update.
2039         * language.h (struct language_defn) <la_post_parser>: Add
2040         "completing" parameter.
2041         * go-exp.y: Update rules.
2042         (lex_one_token): Update.
2043         * expression.h (parse_completion): Don't declare.
2044         * d-exp.y: Update rules.
2045         (lex_one_token): Update rules.
2046         * c-exp.y: Update rules.
2047         (lex_one_token): Update.
2048         * ada-lang.c (resolve): Add "parse_completion" parameter.
2049         (resolve_subexp): Likewise.
2050         (ada_resolve_function): Likewise.
2051
2052 2019-04-04  Tom Tromey  <tom@tromey.com>
2053
2054         * parser-defs.h (struct parser_state) <start_arglist,
2055         end_arglist>: New methods.
2056         <arglist_len, m_funcall_chain>: New members.
2057         (arglist_len, start_arglist, end_arglist): Don't declare.
2058         * parse.c (arglist_len, funcall_chain): Remove global.
2059         (start_arglist, end_arglist): Remove functions.
2060         (parse_exp_in_context): Update.
2061         * p-exp.y: Update rules.
2062         * m2-exp.y: Update rules.
2063         * go-exp.y: Update rules.
2064         * f-exp.y: Update rules.
2065         * d-exp.y: Update rules.
2066         * c-exp.y: Update rules.
2067
2068 2019-04-04  Tom Tromey  <tom@tromey.com>
2069
2070         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
2071         lex_operator, push_back>: New methods.
2072         Update all rules.
2073         (rust_parser::lex_hex, lex_escape): Rename and update.
2074         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
2075         (rust_parser::lex_operator): Rename and update.
2076         (rust_parser::lex_number, rustyylex, rustyyerror)
2077         (rust_lex_test_init, rust_lex_test_sequence)
2078         (rust_lex_test_push_back, rust_lex_tests): Update.
2079         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
2080         parameter.
2081         <lexptr, prev_lexptr>: New members.
2082         (lexptr, prev_lexptr): Don't declare.
2083         * parse.c (lexptr, prev_lexptr): Remove globals.
2084         (parse_exp_in_context): Update.
2085         * p-exp.y (yylex, yyerror): Update.
2086         * m2-exp.y (parse_number, yylex, yyerror): Update.
2087         * go-exp.y (lex_one_token, yyerror): Update.
2088         * f-exp.y (match_string_literal, yylex, yyerror): Update.
2089         * d-exp.y (lex_one_token, yyerror): Update.
2090         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
2091         (lex_one_token, yyerror): Update.
2092         * ada-lex.l (YY_INPUT): Update.
2093         (rewind_to_char): Update.
2094         * ada-exp.y (yyerror): Update.
2095
2096 2019-04-04  Tom Tromey  <tom@tromey.com>
2097
2098         * rust-exp.y (rustyylex, rust_lex_tests): Update.
2099         * parser-defs.h (struct parser_state) <parser_state>: Add new
2100         parameter.
2101         <comma_terminates>: New member.
2102         (comma_terminates): Don't declare global.
2103         * parse.c (comma_terminates): Remove global.
2104         (parse_exp_in_context): Update.
2105         * p-exp.y (yylex): Update.
2106         * m2-exp.y (yylex): Update.
2107         * go-exp.y (lex_one_token): Update.
2108         * f-exp.y (yylex): Update.
2109         * d-exp.y (lex_one_token): Update.
2110         * c-exp.y (lex_one_token): Update.
2111         * ada-lex.l: Update.
2112
2113 2019-04-04  Tom Tromey  <tom@tromey.com>
2114
2115         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
2116         (rustyylex, rust_lex_test_init, rust_lex_test_one)
2117         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
2118         * parser-defs.h (paren_depth): Don't declare.
2119         * parse.c (paren_depth): Remove global.
2120         (parse_exp_in_context): Update.
2121         * p-exp.y (paren_depth): New global.
2122         (pascal_parse): Initialize it.
2123         * m2-exp.y (paren_depth): New global.
2124         (m2_parse): Initialize it.
2125         * go-exp.y (paren_depth): New global.
2126         (go_parse): Initialize it.
2127         * f-exp.y (paren_depth): New global.
2128         (f_parse): Initialize it.
2129         * d-exp.y (paren_depth): New global.
2130         (d_parse): Initialize it.
2131         * c-exp.y (paren_depth): New global.
2132         (c_parse): Initialize it.
2133         * ada-lex.l (paren_depth): New global.
2134         (lexer_init): Initialize it.
2135
2136 2019-04-04  Tom Tromey  <tom@tromey.com>
2137
2138         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2139         (rust_parser::convert_ast_to_type)
2140         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2141         * parser-defs.h (struct parser_state) <parser_state>: Add
2142         parameters.  Initialize new members.
2143         <expression_context_block, expression_context_pc>: New members.
2144         * parse.c (expression_context_block, expression_context_pc):
2145         Remove globals.
2146         (parse_exp_in_context): Update.
2147         * p-exp.y: Update all rules.
2148         (yylex): Update.
2149         * m2-exp.y: Update all rules.
2150         (yylex): Update.
2151         * go-exp.y (yylex): Update.
2152         * f-exp.y (yylex): Update.
2153         * d-exp.y: Update all rules.
2154         (yylex): Update.
2155         * c-exp.y: Update all rules.
2156         (lex_one_token, classify_name, yylex, c_parse): Update.
2157         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2158
2159 2019-04-04  Tom Tromey  <tom@tromey.com>
2160
2161         * gdbarch.h, gdbarch.c: Rebuild.
2162         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2163         * stap-probe.h:
2164         (struct stap_parse_info): Replace "parser_state" with
2165         "expr_builder".
2166         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2167         (parser_state): New class.
2168         * parse.c (expr_builder): Rename.
2169         (expr_builder::release): Rename.
2170         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2171         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2172         (write_exp_elt_longcst, write_exp_elt_floatcst)
2173         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2174         (write_exp_string_vector, write_exp_bitstring)
2175         (write_exp_msymbol, mark_struct_expression)
2176         (write_dollar_variable)
2177         (insert_type_address_space, increase_expout_size): Replace
2178         "parser_state" with "expr_builder".
2179         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2180         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2181         "parser_state" with "expr_builder".
2182
2183 2019-04-04  Tom Tromey  <tom@tromey.com>
2184
2185         * rust-exp.y: Replace "parse_language" with method call.
2186         * p-exp.y:
2187         (yylex): Replace "parse_language" with method call.
2188         * m2-exp.y:
2189         (yylex): Replace "parse_language" with method call.
2190         * go-exp.y (classify_name): Replace "parse_language" with method
2191         call.
2192         * f-exp.y (yylex): Replace "parse_language" with method call.
2193         * d-exp.y (lex_one_token): Replace "parse_language" with method
2194         call.
2195         * c-exp.y:
2196         (lex_one_token, classify_name, yylex): Replace "parse_language"
2197         with method call.
2198         * ada-exp.y (find_primitive_type, type_char)
2199         (type_system_address): Replace "parse_language" with method call.
2200
2201 2019-04-04  Tom Tromey  <tom@tromey.com>
2202
2203         * rust-exp.y: Replace "parse_gdbarch" with method call.
2204         * parse.c (write_dollar_variable, insert_type_address_space):
2205         Replace "parse_gdbarch" with method call.
2206         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2207         call.
2208         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2209         call.
2210         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2211         "parse_gdbarch" with method call.
2212         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2213         with method call.
2214         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2215         "parse_gdbarch" with method call.
2216         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2217         "parse_gdbarch" with method call.
2218         * c-exp.y (parse_type, parse_number, classify_name): Replace
2219         "parse_gdbarch" with method call.
2220         * ada-lex.l: Replace "parse_gdbarch" with method call.
2221         * ada-exp.y (parse_type, find_primitive_type, type_char)
2222         (type_system_address): Replace "parse_gdbarch" with method call.
2223
2224 2019-04-04  Tom Tromey  <tom@tromey.com>
2225
2226         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2227         * stap-probe.c (stap_parse_argument): Update.
2228         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2229         initial_size parameter.
2230         * rust-exp.y (rust_lex_tests): Update.
2231         * parse.c (parser_state): Update.
2232         (parse_exp_in_context): Update.
2233         * parser-defs.h (struct parser_state) <parser_state>: Remove
2234         "initial_size" parameter.
2235
2236 2019-04-04  Tom Tromey  <tom@tromey.com>
2237
2238         * parser-defs.h (increase_expout_size): Don't declare.
2239         * parse.c (increase_expout_size): Now static.
2240
2241 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2242
2243         * gnu-nat.c (gnu_nat_target::wait): Fix
2244         target_waitstatus_to_string call.
2245
2246 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2247
2248         * eval.c (evaluate_subexp_standard): Handle internal functions
2249         during Fortran function call handling.
2250
2251 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2252
2253         * NEWS: Mention new internal functions.
2254         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2255         (read_base_type): Use dwarf2_init_complex_target_type.
2256         * value.c (creal_internal_fn): New function.
2257         (cimag_internal_fn): New function.
2258         (_initialize_values): Register new internal functions.
2259
2260 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2261
2262         * infrun.c (stop_all_threads): If debug_infrun, always
2263         trace the wait status after wait_one, using
2264         target_waitstatus_to_string and target_pid_to_str.
2265         (handle_inferior_event): Replace various trace of
2266         wait status kind by a single trace.
2267         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2268         wait status kind image by target_waitstatus_to_string.
2269         * target/waitstatus.c (target_waitstatus_to_string): Fix
2270         obsolete comment.
2271
2272 2019-04-01  Tom Tromey  <tromey@adacore.com>
2273
2274         PR symtab/23331:
2275         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2276
2277 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2278             Pedro Alves  <palves@redhat.com>
2279
2280         * top.c (quit_force): Call 'finalize_values'.
2281         * value.c (finalize_values): New function.
2282         * value.h (finalize_values): Declare.
2283
2284 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2285
2286         * NEWS: Announce $_gdb_major and $_gdb_minor.
2287
2288         * top.c (init_gdb_version_vars): New function.
2289         (gdb_init): Call init_gdb_version_vars.
2290
2291 2019-03-29  Tom Tromey  <tromey@adacore.com>
2292
2293         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2294         help text.  Remove dead code.
2295
2296 2019-03-29  Keith Seitz  <keiths@redhat.com>
2297
2298         From Siddhesh Poyarekar:
2299         * f-lang.h (f77_get_upperbound): Return LONGEST.
2300         (f77_get_lowerbound): Likewise.
2301         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2302         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2303         print them.
2304         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2305         plongest to format print it.
2306         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2307         (f77_get_upperbound): Likewise.
2308         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2309         LOWER_BOUND to LONGEST.
2310         (f77_create_arrayprint_offset_tbl): Likewise.
2311
2312 2019-03-29  Keith Seitz  <keiths@redhat.com>
2313
2314         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2315         %s/pulongest for TYPE_LENGTH instead of %d in format
2316         strings.
2317         * ada-typerint.c (ada_print_type): Likewise.
2318         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2319         * compile/compile-c-support.c (generate_register_struct): Likewise.
2320         * gdbtypes.c (recursive_dump_type): Likewise.
2321         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2322         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2323         instead of %d in format strings.
2324         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2325         to std::min to ULONGEST.
2326         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2327         instead of %d in format strings.
2328         * tracepoint.c (info_scope_command): Likewise.
2329         * typeprint.c (print_offset_data::update)
2330         (print_offset_data::finish): Likewise.
2331         * xtensa-tdep.c (xtensa_store_return_value)
2332         (xtensa_push_dummy_call): Likewise.
2333
2334 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2335
2336         * windows-nat.c (display_selector): Fixed format specifications
2337         for 64-bit Cygwin.
2338
2339 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2340
2341         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2342
2343 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2344
2345         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2346         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2347         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2348         (nios2_linux_init_abi): Install it.
2349
2350 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2351
2352         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2353
2354 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2355
2356         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2357
2358 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2359             Tom Tromey  <tromey@adacore.com>
2360
2361         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2362
2363 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2364
2365         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
2366         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
2367         method to compute the bounds of range types. Also print "[evaluated]"
2368         if the bounds' values come from a dynamic evaluation.
2369
2370 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2371
2372         * cp-valprint.c (cp_print_value_fields): Don't print trailing
2373         whitespace when pretty printing is on.
2374
2375 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2376
2377         * ppc-linux-nat.c: Add include.
2378
2379 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2380
2381         * NEWS: Mention AArch64 Pointer Authentication.
2382
2383 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2384
2385         * arm-linux-nat.c: Add include.
2386
2387 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
2388
2389         * source-cache.c (source_cache::get_source_lines): Re-read
2390         fullname after calling open_source_file.
2391
2392 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
2393
2394         * NEWS: Mention TLS support for FreeBSD.
2395
2396 2019-03-25  Tom Tromey  <tromey@adacore.com>
2397
2398         * minsyms.c (BUNCH_SIZE): Update comment.
2399         (~minimal_symbol_reader): Remove old comment.
2400         (compact_minimal_symbols): Update comment.
2401         (minimal_symbol_reader::install): Remove old comment.  Update
2402         other comments.
2403
2404 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2405
2406         * s390-linux-nat.c: Add include.
2407
2408 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2409
2410         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2411         Call linux_get_hwcap.
2412         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
2413         Likewise.
2414         (aarch64_linux_get_hwcap): Remove function.
2415         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
2416         declaration.
2417         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
2418         linux_get_hwcap.
2419         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2420         * linux-tdep.c (linux_get_hwcap): Add function.
2421         (linux_get_hwcap2): Likewise.
2422         * linux-tdep.h (linux_get_hwcap): Add declaration.
2423         (linux_get_hwcap2): Likewise.
2424         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
2425         (ppc_linux_get_hwcap2): Likewise.
2426         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
2427         linux_get_hwcap.
2428         (ppc_linux_nat_target::insert_watchpoint): Likewise.
2429         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
2430         (ppc_linux_nat_target::read_description): Likewise.
2431         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
2432         * s390-linux-nat.c: Likewise.
2433         * s390-linux-tdep.c (s390_core_read_description): Likewise.
2434
2435 2019-03-24  Tom Tromey  <tom@tromey.com>
2436
2437         * ada-lang.c (standard_lookup): Simplify initialization.
2438         (ada_lookup_symbol_nonlocal): Simplify return.
2439         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
2440         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
2441         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
2442         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
2443         initialization.
2444         * solib.c (solib_global_lookup): Simplify.
2445         * symtab.c (null_block_symbol): Remove.
2446         (symbol_cache_lookup): Simplify returns.
2447         (lookup_language_this): Simplify returns.
2448         (lookup_symbol_aux): Simplify return.
2449         (lookup_local_symbol): Simplify returns.
2450         (lookup_global_symbol_from_objfile): Simplify return.
2451         (lookup_symbol_in_objfile_symtabs)
2452         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
2453         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
2454         (lookup_static_symbol, lookup_global_symbol): Simplify return.
2455         * cp-namespace.c (cp_lookup_bare_symbol)
2456         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
2457         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
2458         (cp_lookup_nested_symbol): Don't use null_block_symbol.
2459         (cp_lookup_symbol_via_imports): Simplify initialization.
2460         (find_symbol_in_baseclass): Likewise.
2461         * symtab.h (null_block_symbol): Remove.
2462         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
2463         (d_lookup_nested_symbol, d_lookup_symbol_imports)
2464         (d_lookup_symbol_module): Likewise.
2465         (find_symbol_in_baseclass): Simplify initialization.
2466
2467 2019-03-24  Tom Tromey  <tom@tromey.com>
2468
2469         * expression.h: Don't include symtab.h.
2470         (struct block): Forward declare.
2471
2472 2019-03-24  Tom Tromey  <tom@tromey.com>
2473
2474         * c-exp.y (typebase): Remove casts.
2475         * gdbtypes.c (lookup_unsigned_typename, )
2476         (lookup_signed_typename): Remove cast.
2477         * eval.c (parse_to_comma_and_eval): Remove cast.
2478         * parse.c (write_dollar_variable): Remove cast.
2479         * block.h (struct block) <superblock>: Now const.
2480         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
2481         * psymtab.c (psym_map_matching_symbols): Make "block" const.
2482         (map_block): Make "block" const.
2483         * symfile.h (struct quick_symbol_functions)
2484         <map_matching_symbols>: Constify block argument to "callback".
2485         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
2486         const.
2487         (find_pc_sect_compunit_symtab): Make "b" const.
2488         (find_symbol_at_address): Likewise.
2489         (search_symbols): Likewise.
2490         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
2491         (dw2_debug_names_lookup_symbol): Likewise.
2492         (dw2_map_matching_symbols): Update.
2493         * p-valprint.c (pascal_val_print): Remove "block".
2494         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
2495         (aux_add_nonlocal_symbols): Make "block" const.
2496         (resolve_subexp): Remove cast.
2497         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
2498         const.
2499         (iterate_over_file_blocks): Likewise.
2500         * f-exp.y (%union) <bval>: Remove.
2501         * coffread.c (patch_opaque_types): Make "b" const.
2502         * spu-tdep.c (spu_catch_start): Make "block" const.
2503         * c-valprint.c (print_unpacked_pointer): Remove "block".
2504         * symmisc.c (dump_symtab_1): Make "b" const.
2505         (block_depth): Make "block" const.
2506         * d-exp.y (%union) <bval>: Remove.
2507         * cp-support.h (cp_lookup_rtti_type): Update.
2508         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
2509         * psymtab.c (psym_lookup_symbol): Make "block" const.
2510         (maintenance_check_psymtabs): Make "b" const.
2511         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
2512         (enumerate_locals, enumerate_args): Update.
2513         * python/py-symtab.c (stpy_global_block): Make "block" const.
2514         (stpy_static_block): Likewise.
2515         * inline-frame.c (block_starting_point_at): Make "new_block"
2516         const.
2517         * block.c (find_block_in_blockvector): Make return type const.
2518         (blockvector_for_pc_sect): Make "b" const.
2519         (find_block_in_blockvector): Make "b" const.
2520
2521 2019-03-23  Tom Tromey  <tom@tromey.com>
2522
2523         * varobj.c (varobj_create): Update.
2524         * symfile.c (clear_symtab_users): Don't reset innermost_block.
2525         * printcmd.c (display_command, do_one_display): Don't reset
2526         innermost_block.
2527         * parser-defs.h (enum innermost_block_tracker_type): Move to
2528         expression.h.
2529         (innermost_block): Update comment.
2530         * parse.c (parse_exp_1): Add tracker_types parameter.
2531         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
2532         tracker_types parameter.  Reset innermost_block.
2533         (parse_exp_in_context): Remove.
2534         (parse_expression_for_completion): Update.
2535         * objfiles.c (~objfile): Don't reset expression_context_block or
2536         innermost_block.
2537         * expression.h (enum innermost_block_tracker_type): Move from
2538         parser-defs.h.
2539         (parse_exp_1): Add tracker_types parameter.
2540         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
2541         reset innermost_block.
2542
2543 2019-03-23  Tom Tromey  <tom@tromey.com>
2544
2545         * objfiles.h: Include bcache.h.
2546
2547 2019-03-23  Tom Tromey  <tom@tromey.com>
2548
2549         * linespec.c (get_current_search_block): Use
2550         scoped_restore_current_language.
2551         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
2552
2553 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2554             Jiong Wang  <jiong.wang@arm.com>
2555
2556         * aarch64-linux-tdep.c
2557         (aarch64_linux_iterate_over_regset_sections): Check for pauth
2558         section.
2559         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
2560
2561 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2562             Jiong Wang  <jiong.wang@arm.com>
2563
2564         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
2565         instructions.
2566         (aarch64_analyze_prologue_test): Add PACIASP test.
2567         (aarch64_prologue_prev_register): Unmask PC value.
2568
2569 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2570             Jiong Wang  <jiong.wang@arm.com>
2571
2572         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
2573         (aarch64_dwarf2_prev_register): Unmask PC value.
2574         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
2575         (aarch64_execute_dwarf_cfa_vendor_op): Check for
2576         DW_CFA_AARCH64_negate_ra_state.
2577         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
2578
2579 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2580             Jiong Wang  <jiong.wang@arm.com>
2581
2582         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
2583         registers.
2584         (aarch64_pseudo_register_name): Likewise.
2585         (aarch64_pseudo_register_type): Likewise.
2586         (aarch64_pseudo_register_reggroup_p): Likewise.
2587         (aarch64_gdbarch_init): Add pauth registers.
2588         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
2589         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
2590         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
2591         (struct gdbarch_tdep): Add regnum for ra_state.
2592
2593 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2594             Jiong Wang  <jiong.wang@arm.com>
2595
2596         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
2597
2598 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2599             Jiong Wang  <jiong.wang@arm.com>
2600
2601         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
2602         function.
2603         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
2604         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
2605         (aarch64_gdbarch_init): Add puth registers.
2606         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
2607         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
2608         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
2609
2610 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2611             Jiong Wang  <jiong.wang@arm.com>
2612
2613         * aarch64-linux-nat.c
2614         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
2615         * aarch64-linux-tdep.c
2616         (aarch64_linux_core_read_description): Likewise.
2617         (aarch64_linux_get_hwcap): New function.
2618         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
2619         (aarch64_linux_get_hwcap): New declaration.
2620
2621 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2622             Jiong Wang  <jiong.wang@arm.com>
2623
2624         * aarch64-linux-nat.c
2625         (aarch64_linux_nat_target::read_description): Add pauth param.
2626         * aarch64-linux-tdep.c
2627         (aarch64_linux_core_read_description): Likewise.
2628         * aarch64-tdep.c (struct target_desc): Add in pauth.
2629         (aarch64_read_description): Add pauth param.
2630         (aarch64_gdbarch_init): Likewise.
2631         * aarch64-tdep.h (aarch64_read_description): Likewise.
2632         * arch/aarch64.c (aarch64_create_target_description): Likewise.
2633         * arch/aarch64.h (aarch64_create_target_description): Likewise.
2634         * features/Makefile: Add new files.
2635         * features/aarch64-pauth.c: New file.
2636         * features/aarch64-pauth.xml: New file.
2637
2638 2019-03-20  Tom Tromey  <tromey@adacore.com>
2639
2640         * infrun.c (handle_inferior_event): Rename from
2641         handle_inferior_event_1.  Create a scoped_value_mark.
2642         (handle_inferior_event): Remove.
2643
2644 2019-03-19  Tom Tromey  <tromey@adacore.com>
2645
2646         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
2647         * infrun.h (print_stop_event): Add "displays" parameter.
2648         * infrun.c (print_stop_event): Add "displays" parameter.
2649
2650 2019-03-19  Pedro Alves  <palves@redhat.com>
2651
2652         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
2653         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
2654         to -1.  Fix TABs vs spaces.
2655         (tui_ui_out::tui_ui_out): Don't initialize fields here.
2656         * tui/tui-out.h (tui_ui_out) Add intro comments.
2657         <m_line, m_start_of_line>: In-class initialize, and add describing
2658         comment.
2659
2660 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
2661
2662         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
2663         variable names.
2664         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
2665
2666 2019-03-18  Pedro Alves  <palves@redhat.com>
2667             Eli Zaretskii <eliz@gnu.org>
2668
2669         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
2670         m_line and m_start_of_line.
2671
2672 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
2673
2674         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
2675         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
2676         it returns a newline.  This fixes a regression in TU mode, whereby
2677         the next line is output on the same screen line as the user input.
2678
2679 2019-03-18  Tom Tromey  <tromey@adacore.com>
2680
2681         * minsyms.c (minimal_symbol_reader::install): Remove call to
2682         obstack_blank.
2683
2684 2019-03-18  Pedro Alves  <palves@redhat.com>
2685
2686         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
2687         New globals.
2688         (apply_style): New, factored out from ...
2689         (apply_ansi_escape): ... this.  Handle reverse video mode.
2690         (tui_set_reverse_mode): New function.
2691         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
2692         * tui/tui-winsource.c (tui_show_source_line): Use
2693         tui_set_reverse_mode instead of setting A_STANDOUT.
2694         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
2695         New setter methods.
2696
2697 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
2698
2699         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
2700         Handle tabs.
2701
2702 2019-03-18  Tom Tromey  <tromey@adacore.com>
2703
2704         * ada-lang.c (empty_array): Add "high" parameter.
2705         (ada_evaluate_subexp): Update.
2706
2707 2019-03-17  Sergei Trofimovich <siarheit@google.com>
2708
2709         * unittests/string_view-selftests.c: Define
2710         _initialize_string_view_selftests unconditionally.
2711
2712 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2713
2714         PR gdb/24350
2715         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
2716
2717 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2718
2719         PR gdb/24351
2720         * windows-nat.c (display_selector): Fix format specifiers.
2721
2722 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
2723
2724         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
2725         tui_refill_source_window instead of tui_refresh_win, to update the
2726         current execution line.  This fixes redisplay of the current line
2727         when stepping through the code with "next" or "step".
2728
2729 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2730
2731         * source-cache.c (source_cache::get_source_lines): Call
2732         find_source_lines to initialize s->nlines.  This fixes vertical
2733         scrolling of TUI source window when the DOWN arrow is pressed.
2734
2735 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2736
2737         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
2738         linux-thread-db.c (_initialize_thread_db): Likewise.
2739
2740 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2741
2742         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
2743         wclrtoeol in tui_show_source_line".  This reverts changes made in
2744         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
2745
2746 2019-03-15  Tom Tromey  <tom@tromey.com>
2747
2748         * symtab.h (struct minimal_symbol): Derive from
2749         general_symbol_info.
2750         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
2751         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
2752         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
2753         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
2754         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
2755         (MSYMBOL_SEARCH_NAME): Update.
2756         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
2757         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
2758         * minsyms.c (minimal_symbol_reader::record_full): Update.
2759
2760 2019-03-15  Tom Tromey  <tom@tromey.com>
2761
2762         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
2763
2764 2019-03-15  Tom Tromey  <tom@tromey.com>
2765
2766         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
2767         unique_xmalloc_ptr.
2768         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
2769         Update.
2770         * minsyms.c (lookup_minimal_symbol_by_pc_section)
2771         (build_minimal_symbol_hash_tables)
2772         (minimal_symbol_reader::install): Update.
2773
2774 2019-03-15  Tom Tromey  <tom@tromey.com>
2775
2776         * symtab.c (create_demangled_names_hash): Update.
2777         (symbol_set_names): Update.
2778         * objfiles.h (struct objfile_per_bfd_storage)
2779         <demangled_names_hash>: Now an htab_up.
2780         * objfiles.c (objfile_per_bfd_storage): Simplify.
2781
2782 2019-03-15  Tom Tromey  <tom@tromey.com>
2783
2784         * objfiles.h (struct objfile_per_bfd_storage): Declare
2785         destructor.
2786         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
2787         New.
2788         (get_objfile_bfd_data): Use new.  Don't initialize
2789         language_of_main.
2790         (free_objfile_per_bfd_storage): Remove.
2791         (objfile_bfd_data_free, objfile::~objfile): Use delete.
2792
2793 2019-03-15  Tom Tromey  <tom@tromey.com>
2794
2795         * symfile.c (reread_symbols): Update.
2796         * objfiles.c (objfile::objfile): Update.
2797         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
2798         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
2799         comment.
2800         (minimal_symbol_reader::install): Update.
2801         (terminate_minimal_symbol_table): Remove.
2802         * jit.c (jit_object_close_impl): Update.
2803
2804 2019-03-15  Tom Tromey  <tom@tromey.com>
2805
2806         * minsyms.c (minimal_symbol_reader::record_full): Remove some
2807         initializations.
2808
2809 2019-03-15  Tom Tromey  <tom@tromey.com>
2810
2811         * objfiles.h (struct objfile_per_bfd_storage)
2812         <demangled_hash_languages>: Now a bitset.
2813         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
2814         (lookup_minimal_symbol): Update.
2815
2816 2019-03-15  Tom Tromey  <tom@tromey.com>
2817
2818         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
2819         Don't return the symbol.
2820         * coffread.c (record_minimal_symbol): Use record_full.
2821
2822 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
2823
2824         The MS-Windows port of ncurses fails to switch to a color pair if
2825         one or both of the colors are the implicit default colors.  This
2826         change records the default colors when TUI is initialized, and
2827         then specifies them explicitly when a color pair uses the default
2828         colors.  This allows color styling in TUI mode on MS-Windows.
2829
2830         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
2831         ncurses_norm_attr.
2832         (tui_initialize_io) [__MINGW32__]: Record the default terminal
2833         colors in ncurses_norm_attr.
2834         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
2835         "none", replace it with the default color recorded in
2836         ncurses_norm_attr.
2837
2838 2019-03-14  Tom Tromey  <tromey@adacore.com>
2839
2840         * source-cache.h (class source_cache) <get_source_lines>: Return
2841         std::string.
2842         * source-cache.c (source_cache::extract_lines): Handle case where
2843         first_pos==npos.  Return std::string.
2844         (source_cache::get_source_lines): Update.
2845
2846 2019-03-14  Tom Tromey  <tromey@adacore.com>
2847
2848         * NEWS: Add item for "style sources" commands.
2849         * source-cache.c (source_cache::get_source_lines): Check
2850         source_styling.
2851         * cli/cli-style.c (source_styling): New global.
2852         (_initialize_cli_style): Add "style sources" commands.
2853         (show_style_sources): New function.
2854         * cli/cli-style.h (source_styling): Declare.
2855
2856 2019-03-14  Pedro Alves  <palves@redhat.com>
2857             Tom Tromey  <tromey@adacore.com>
2858
2859         * tui/tui-winsource.h (tui_refill_source_window): Declare.
2860         * tui/tui-winsource.c (tui_refill_source_window): New function,
2861         from...
2862         (tui_horizontal_source_scroll): ... here.  Move some logic.
2863         * cli/cli-style.c (set_style_enabled): Notify new observable.
2864         * tui/tui-hooks.c (tui_redisplay_source): New function.
2865         (tui_attach_detach_observers): Attach or detach
2866         tui_redisplay_source.
2867         * observable.h (source_styling_changed): New observable.
2868         * observable.c: Define source_styling_changed observable.
2869
2870 2019-03-13  Tom Tromey  <tromey@adacore.com>
2871
2872         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
2873         (i386_gnu_nat_target::store_registers): Update.
2874         * target-debug.h (target_debug_print_std_string): New macro.
2875         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2876         * windows-tdep.c (display_one_tib): Update.
2877         * tui/tui-stack.c (tui_make_status_line): Update.
2878         * top.c (print_inferior_quit_action): Update.
2879         * thread.c (thr_try_catch_cmd): Update.
2880         (add_thread_with_info): Update.
2881         (thread_target_id_str): Update.
2882         (thr_try_catch_cmd): Update.
2883         (thread_command): Update.
2884         (thread_find_command): Update.
2885         * record-btrace.c (record_btrace_target::info_record)
2886         (record_btrace_resume_thread, record_btrace_target::resume)
2887         (record_btrace_cancel_resume, record_btrace_step_thread)
2888         (record_btrace_target::wait, record_btrace_target::wait)
2889         (record_btrace_target::wait, record_btrace_target::stop): Update.
2890         * progspace.c (print_program_space): Update.
2891         * process-stratum-target.c
2892         (process_stratum_target::thread_address_space): Update.
2893         * linux-fork.c (linux_fork_mourn_inferior)
2894         (detach_checkpoint_command, info_checkpoints_command)
2895         (linux_fork_context): Update.
2896         (linux_fork_detach): Update.
2897         (class scoped_switch_fork_info): Update.
2898         (delete_checkpoint_command): Update.
2899         * infrun.c (follow_fork_inferior): Update.
2900         (follow_fork_inferior): Update.
2901         (proceed_after_vfork_done): Update.
2902         (handle_vfork_child_exec_or_exit): Update.
2903         (follow_exec): Update.
2904         (displaced_step_prepare_throw): Update.
2905         (displaced_step_restore): Update.
2906         (start_step_over): Update.
2907         (resume_1): Update.
2908         (clear_proceed_status_thread): Update.
2909         (proceed): Update.
2910         (print_target_wait_results): Update.
2911         (do_target_wait): Update.
2912         (context_switch): Update.
2913         (stop_all_threads): Update.
2914         (restart_threads): Update.
2915         (finish_step_over): Update.
2916         (handle_signal_stop): Update.
2917         (switch_back_to_stepped_thread): Update.
2918         (keep_going_pass_signal): Update.
2919         (print_exited_reason): Update.
2920         (normal_stop): Update.
2921         * inferior.c (inferior_pid_to_str): Change return type.
2922         (print_selected_inferior): Update.
2923         (add_inferior): Update.
2924         (detach_inferior): Update.
2925         * dummy-frame.c (fprint_dummy_frames): Update.
2926         * dcache.c (dcache_info_1): Update.
2927         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
2928         (btrace_fetch, btrace_clear): Update.
2929         * linux-tdep.c (linux_core_pid_to_str): Change return type.
2930         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
2931         type.
2932         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
2933         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
2934         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
2935         * gdbarch.c, gdbarch.h: Rebuild.
2936         * gdbarch.sh (core_pid_to_str): Change return type.
2937         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
2938         return type.
2939         (windows_nat_target::pid_to_str): Change return type.
2940         (windows_delete_thread): Update.
2941         (windows_nat_target::attach): Update.
2942         (windows_nat_target::files_info): Update.
2943         * target-delegates.c: Rebuild.
2944         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
2945         return type.
2946         (sol_thread_target::pid_to_str): Change return type.
2947         * remote.c (class remote_target) <pid_to_str>: Change return
2948         type.
2949         (remote_target::pid_to_str): Change return type.
2950         (extended_remote_target::attach, remote_target::remote_stop_ns)
2951         (remote_target::remote_notif_remove_queued_reply)
2952         (remote_target::push_stop_reply, remote_target::disable_btrace):
2953         Update.
2954         (extended_remote_target::attach): Update.
2955         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
2956         type.
2957         (gdbsim_target::pid_to_str): Change return type.
2958         * ravenscar-thread.c (struct ravenscar_thread_target)
2959         <pid_to_str>: Change return type.
2960         (ravenscar_thread_target::pid_to_str): Change return type.
2961         * procfs.c (class procfs_target) <pid_to_str>: Change return
2962         type.
2963         (procfs_target::pid_to_str): Change return type.
2964         (procfs_target::attach): Update.
2965         (procfs_target::detach): Update.
2966         (procfs_target::fetch_registers): Update.
2967         (procfs_target::store_registers): Update.
2968         (procfs_target::wait): Update.
2969         (procfs_target::files_info): Update.
2970         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
2971         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
2972         return type.
2973         (nto_procfs_target::pid_to_str): Change return type.
2974         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
2975         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
2976         return type.
2977         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
2978         (exit_lwp): Update.
2979         (attach_proc_task_lwp_callback, get_detach_signal)
2980         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
2981         (linux_nat_target::resume, wait_lwp, stop_callback)
2982         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
2983         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
2984         (linux_nat_wait_1, resume_stopped_resumed_lwps)
2985         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
2986         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
2987         type.
2988         (inf_ptrace_target::attach): Update.
2989         (inf_ptrace_target::files_info): Update.
2990         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
2991         type.
2992         (go32_nat_target::pid_to_str): Change return type.
2993         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
2994         (gnu_nat_target::wait): Update.
2995         (gnu_nat_target::wait): Update.
2996         (gnu_nat_target::resume): Update.
2997         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
2998         (fbsd_nat_target::wait): Update.
2999         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
3000         type.
3001         (darwin_nat_target::attach): Update.
3002         * corelow.c (class core_target) <pid_to_str>: Change return type.
3003         (core_target::pid_to_str): Change return type.
3004         * target.c (normal_pid_to_str): Change return type.
3005         (default_pid_to_str): Likewise.
3006         (target_pid_to_str): Change return type.
3007         (target_translate_tls_address): Update.
3008         (target_announce_detach): Update.
3009         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
3010         return type.
3011         (bsd_uthread_target::pid_to_str): Change return type.
3012         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
3013         type.
3014         (bsd_kvm_target::pid_to_str): Change return type.
3015         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
3016         return type.
3017         (aix_thread_target::pid_to_str): Change return type.
3018         * target.h (struct target_ops) <pid_to_str>: Change return type.
3019         (target_pid_to_str, normal_pid_to_str): Likewise.
3020         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
3021         type.
3022         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
3023         type.
3024         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
3025         return type.
3026         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
3027         type.
3028         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
3029         type.
3030         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
3031         return type.
3032
3033 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
3034
3035         * NEWS: Mention that the new default MI version is 3.  Mention
3036         changes to the output of commands and events that deal with
3037         multi-location breakpoints.
3038         * breakpoint.c: Include "mi/mi-out.h".
3039         (print_one_breakpoint): Change output syntax if using MI version
3040         >= 3.
3041         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
3042         New.
3043         (mi_multi_location_breakpoint_output_fixed): New.
3044         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
3045         (mi_cmd_fix_multi_location_breakpoint_output): New.
3046         (mi_multi_location_breakpoint_output_fixed): New.
3047         * mi/mi-cmds.c (mi_cmds): Register command
3048         -fix-multi-location-breakpoint-output.
3049         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
3050         interpreter "mi".
3051
3052 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3053
3054         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
3055         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
3056         instantiate mi_ui_out based on interpreter name.
3057         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
3058         * mi/mi-main.c (mi_load_progress): Likewise.
3059
3060 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3061
3062         * NEWS: Combine separate "New targets" sections for 8.3.
3063
3064 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3065
3066         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
3067         (ppcfbsd_init_abi): Install gdbarch
3068         "fetch_tls_load_module_address" and "get_thread_local_address"
3069         methods.
3070
3071 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3072
3073         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
3074         (riscv_fbsd_init_abi): Install gdbarch
3075         "fetch_tls_load_module_address" and "get_thread_local_address"
3076         methods.
3077
3078 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3079
3080         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
3081         (i386fbsd_init_abi): Install gdbarch
3082         "fetch_tls_load_module_address" and "get_thread_local_address"
3083         methods.
3084
3085 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3086
3087         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
3088         (amd64fbsd_init_abi): Install gdbarch
3089         "fetch_tls_load_module_address" and "get_thread_local_address"
3090         methods.
3091
3092 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3093
3094         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
3095         (struct fbsd_pspace_data): New type.
3096         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
3097         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
3098         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
3099         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
3100         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
3101
3102 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3103
3104         * gdbtypes.c (lookup_struct_elt): New function.
3105         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
3106         * gdbtypes.h (struct struct_elt): New type.
3107         (lookup_struct_elt): New prototype.
3108
3109 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3110
3111         * gdbtypes.c (lookup_struct_elt_type): Update comment and
3112         remove disabled code block.
3113
3114 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3115
3116         * gdbarch.sh (get_thread_local_address): New method.
3117         * gdbarch.h, gdbarch.c: Regenerate.
3118         * target.c (target_translate_tls_address): Use
3119         gdbarch_get_thread_local_address if present instead of
3120         target::get_thread_local_address.
3121
3122 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3123
3124         * target.h (target::get_thread_local_address): Update comment.
3125
3126 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3127
3128         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
3129         objfile->separate_debug_objfile_backlink if not NULL.
3130
3131 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3132
3133         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3134         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3135         (amd64bsd_store_inferior_registers): Likewise.
3136         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3137         Enable segment base registers.
3138         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3139         PT_GETFSBASE and PT_GETGSBASE.
3140         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3141         PT_SETGSBASE.
3142         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3143         segment base registers.
3144         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3145
3146 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3147
3148         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3149         Update calls to i386_target_description to add 'segments'
3150         parameter.
3151         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3152         add segment base registers.
3153         * arch/i386.c (i386_create_target_description): Add 'segments'
3154         parameter to enable segment base registers.
3155         * arch/i386.h (i386_create_target_description): Likewise.
3156         * features/i386/32bit-segments.xml: New file.
3157         * features/i386/32bit-segments.c: Generate.
3158         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3159         call to i386_target_description to add 'segments' parameter.
3160         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3161         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3162         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3163         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3164         if feature is present.
3165         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3166         Add 'segments' parameter to call to i386_target_description.
3167         (i386_target_description): Add 'segments' parameter to enable
3168         segment base registers.
3169         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3170         to call to i386_target_description.
3171         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3172         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3173         Define I386_NUM_REGS.
3174         (i386_target_description): Add 'segments' parameter to enable
3175         segment base registers.
3176
3177 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3178
3179         PR/24325
3180         * source-cache.c: #undef open and close, to avoid unresolved
3181         externals during linking.
3182
3183 2019-03-12  Tom Tromey  <tromey@adacore.com>
3184
3185         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3186         const.  Add initializers.
3187         (_initialize_remote): Don't initialize ptid globals.
3188
3189 2019-03-12  Pedro Alves  <palves@redhat.com>
3190
3191         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3192
3193 2019-03-12  Pedro Alves  <palves@redhat.com>
3194
3195         * cp-name-parser.y (main): Remove unused 'len' variable.
3196
3197 2019-03-12  Tom Tromey  <tromey@adacore.com>
3198
3199         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3200         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3201
3202 2019-03-12  Tom Tromey  <tromey@adacore.com>
3203
3204         * linux-nat.c (iterate_over_lwps): Update.
3205         (stop_callback): Remove parameter.
3206         (stop_wait_callback, detach_callback, resume_set_callback)
3207         (select_singlestep_lwp_callback, set_ignore_sigint)
3208         (status_callback, resumed_callback, resume_clear_callback)
3209         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3210         data parameter.
3211         (linux_nat_target::detach, linux_nat_target::resume)
3212         (linux_stop_and_wait_all_lwps, select_event_lwp)
3213         (linux_nat_filter_event, linux_nat_wait_1)
3214         (linux_nat_target::kill, linux_nat_target::stop)
3215         (linux_nat_target::stop): Update.
3216         (linux_nat_resume_callback): Change type.
3217         (resume_stopped_resumed_lwps, count_events_callback)
3218         (select_event_lwp_callback): Likewise.
3219         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3220         * arm-linux-nat.c (struct update_registers_data): Remove.
3221         (update_registers_callback): Change type.
3222         (arm_linux_insert_hw_breakpoint1): Update.
3223         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3224         parameter.
3225         (x86_linux_dr_set_addr): Update.
3226         (x86_linux_dr_set_control): Update.
3227         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3228         (iterate_over_lwps): Use gdb::function_view.
3229         * nat/aarch64-linux-hw-point.c (struct
3230         aarch64_dr_update_callback_param): Remove.
3231         (debug_reg_change_callback): Change type.
3232         (aarch64_notify_debug_reg_change): Update.
3233         * s390-linux-nat.c (s390_refresh_per_info): Update.
3234
3235 2019-03-11  Tom Tromey  <tromey@adacore.com>
3236
3237         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3238         redundant assignment to "this_cu".
3239
3240 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3241
3242         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3243
3244 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3245
3246         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3247         from...
3248         (rank_one_type): ... this.
3249
3250 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3251
3252         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3253         from...
3254         (rank_one_type): ... this.
3255
3256 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3257
3258         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3259         from...
3260         (rank_one_type): ... this.
3261
3262 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3263
3264         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3265         from...
3266         (rank_one_type): ... this.
3267
3268 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3269
3270         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3271         from...
3272         (rank_one_type): ... this.
3273
3274 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3275
3276         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3277         from...
3278         (rank_one_type): ... this.
3279
3280 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3281
3282         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3283         from...
3284         (rank_one_type): ... this.
3285
3286 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3287
3288         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3289         from...
3290         (rank_one_type): ... this.
3291
3292 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3293
3294         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3295         from...
3296         (rank_one_type): ... this.
3297
3298 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3299
3300         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3301         from...
3302         (rank_one_type): ... this.
3303
3304 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3305
3306         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3307         from...
3308         (rank_one_type): ... this.
3309
3310 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3311
3312         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3313         from...
3314         (rank_one_type): ... this.
3315
3316 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3317
3318         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3319         inferior-events' shows the example events.
3320
3321 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3322
3323         Support styling on native MS-Windows console
3324
3325         PR/24315
3326         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3327         on MS-Windows if $TERM is not defined.
3328
3329         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3330
3331         * posix-hdep.c (gdb_console_fputs):
3332         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3333         functions.
3334         * ui-file.h (gdb_console_fputs): Add prototype.
3335
3336         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3337         back to fputs only if the former returns zero.
3338
3339 2019-03-07  Tom Tromey  <tom@tromey.com>
3340
3341         * symmisc.c (print_symbol_bcache_statistics): Update.
3342         (print_objfile_statistics): Update.
3343         * symfile.c (allocate_symtab): Update.
3344         * stabsread.c: Don't include bcache.h.
3345         * psymtab.h (struct psymbol_bcache): Don't declare.
3346         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3347         (psymbol_bcache_init, psymbol_bcache_free)
3348         (psymbol_bcache_get_bcache): Don't declare.
3349         * psymtab.c (struct psymbol_bcache): Remove.
3350         (psymtab_storage::psymtab_storage): Update.
3351         (psymtab_storage::~psymtab_storage): Update.
3352         (psymbol_bcache_init, psymbol_bcache_free)
3353         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3354         (add_psymbol_to_bcache): Update.
3355         (allocate_psymtab): Update.
3356         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3357         macro_cache>: No longer pointers.
3358         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3359         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3360         * macrotab.c (macro_bcache): Update.
3361         * macroexp.c: Don't include bcache.h.
3362         * gdbtypes.c (check_types_worklist): Update.
3363         (types_deeply_equal): Remove TRY/CATCH.  Update.
3364         * elfread.c (elf_symtab_read): Update.
3365         * dwarf2read.c: Don't include bcache.h.
3366         * buildsym.c (buildsym_compunit::get_macro_table): Update.
3367         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
3368         (print_bcache_statistics, bcache_memory_used): Don't declare.
3369         (struct bcache): Move from bcache.c.  Add constructor, destructor,
3370         methods.  Rename all data members.
3371         * bcache.c (struct bcache): Move to bcache.h.
3372         (bcache::expand_hash_table): Rename from expand_hash_table.
3373         (bcache): Remove.
3374         (bcache::insert): Rename from bcache_full.
3375         (bcache::compare): Rename from bcache_compare.
3376         (bcache_xmalloc): Remove.
3377         (bcache::~bcache): Rename from bcache_xfree.
3378         (bcache::print_statistics): Rename from print_bcache_statistics.
3379         (bcache::memory_used): Rename from bcache_memory_used.
3380
3381 2019-03-07  Pedro Alves  <palves@redhat.com>
3382
3383         * infrun.c (normal_stop): Also check for
3384         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
3385
3386 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3387
3388         * f-lang.c (value_from_host_double): Moved to...
3389         * value.c (value_from_host_double): ...here.
3390         * value.h (value_from_host_double): Declare.
3391         * guile/scm-math.c (vlscm_convert_typed_number): Use
3392         value_from_host_double.
3393         (vlscm_convert_number): Likewise.
3394         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
3395         * python/py-value.c (convert_value_from_python): Likewise.
3396
3397 2019-03-06  Tom Tromey  <tom@tromey.com>
3398
3399         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
3400
3401 2019-03-06  Tom Tromey  <tom@tromey.com>
3402
3403         * utils.h (free_current_contents): Don't declare.
3404         * utils.c (free_current_contents): Remove.
3405
3406 2019-03-06  Tom Tromey  <tom@tromey.com>
3407
3408         * top.c (quit_force): Update.
3409         * main.c (captured_command_loop): Update.
3410         * common/new-op.c (operator new): Update.
3411         * common/common-exceptions.c (struct catcher)
3412         <save_cleanup_chain>: Remove member.
3413         (exceptions_state_mc_init): Update.
3414         (exception_try_scope_entry): Return nullptr.
3415         (exception_try_scope_exit, exception_rethrow)
3416         (throw_exception_sjlj, throw_exception_cxx): Update.
3417         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
3418         (all_cleanups, do_cleanups, discard_cleanups)
3419         (discard_final_cleanups, save_cleanups, save_final_cleanups)
3420         (restore_cleanups, restore_final_cleanups): Don't declare.
3421         (do_final_cleanups): Remove parameter.
3422         * common/cleanups.c (cleanup_chain, make_cleanup)
3423         (make_cleanup_dtor, all_cleanups, do_cleanups)
3424         (discard_my_cleanups, discard_cleanups)
3425         (discard_final_cleanups, save_my_cleanups, save_cleanups)
3426         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
3427         (null_cleanup): Remove.
3428         (do_final_cleanups): Remove parameter.
3429
3430 2019-03-06  Tom Tromey  <tom@tromey.com>
3431
3432         * remote.c (remote_target::remote_parse_stop_reply): Use
3433         unique_xmalloc_ptr.
3434
3435 2019-03-06  Tom Tromey  <tom@tromey.com>
3436
3437         * stabsread.c (struct stabs_field_info): Rename from field_info.
3438         <list, fnlist>: Add initializers.
3439         <obstack>: New member.
3440         (read_member_functions, read_struct_fields, read_baseclasses):
3441         Allocate on obstack.  Don't use cleanups.
3442         (read_one_struct_field, read_member_functions, read_struct_fields)
3443         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
3444         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
3445         (read_struct_type): Update.
3446
3447 2019-03-06  Tom Tromey  <tom@tromey.com>
3448
3449         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
3450         * common/filestuff.h (make_cleanup_close): Don't declare.
3451         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
3452         Remove.
3453
3454 2019-03-06  Tom Tromey  <tom@tromey.com>
3455
3456         * solib-aix.c: Use make_scope_exit.
3457
3458 2019-03-06  Tom Tromey  <tom@tromey.com>
3459
3460         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
3461         Use make_scope_exit.
3462
3463 2019-03-06  Tom Tromey  <tom@tromey.com>
3464
3465         * solib-svr4.c (disable_probes_interface): Remove parameter.
3466         (svr4_handle_solib_event): Use make_scope_exit.
3467
3468 2019-03-06  Tom Tromey  <tom@tromey.com>
3469
3470         * remote.c (struct stop_reply_deleter): Remove.
3471         (stop_reply_up): Update.
3472         (struct stop_reply): Derive from notif_event.  Don't typedef.
3473         <regcache>: Now a std::vector.
3474         (stop_reply_xfree): Remove.
3475         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
3476         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
3477         (remote_target::discard_pending_stop_replies): Use delete.
3478         (remote_target::remote_parse_stop_reply): Update.
3479         (remote_target::process_stop_reply): Update.
3480         * remote-notif.h (struct notif_event): Add virtual destructor.
3481         Remove "dtr" member.
3482         (struct notif_client) <alloc_event>: Return a unique_ptr.
3483         (notif_event_xfree): Don't declare.
3484         (notif_event_up): New typedef.
3485         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
3486         (notif_event_xfree, do_notif_event_xfree): Remove.
3487         (remote_notif_state_xfree): Update.
3488
3489 2019-03-06  Tom Tromey  <tom@tromey.com>
3490
3491         * infrun.c (displaced_step_clear_cleanup): Now a
3492         forward_scope_exit type.
3493         (displaced_step_prepare_throw): Update.
3494         (displaced_step_fixup): Update.
3495
3496 2019-03-06  Tom Tromey  <tom@tromey.com>
3497
3498         * inferior.h (class inferior): Update comment.
3499         * gdbthread.h (class thread_info): Update comment.
3500
3501 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
3502             Tom Tromey  <tom@tromey.com>
3503
3504         * stabsread.h (struct stab_section_list): Remove.
3505         (coffstab_build_psymtabs): Update.
3506         * dbxread.c (symbuf_sections): Now a std::vector.
3507         (sect_idx): New global.
3508         (fill_symbuf): Update.
3509         (coffstab_build_psymtabs): Change type of stabsects parameter.
3510         Update.
3511         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
3512         std::vector.
3513         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
3514         (coff_locate_sections): Update.
3515         (coff_symfile_read): Remove cleanups.  Update.
3516         (init_stringtab): Add storage parameter.
3517         (free_stringtab, free_stringtab_cleanup): Remove.
3518         (init_lineno): Add storage parameter.
3519         (free_linetab, free_linetab_cleanup): Remove.
3520
3521 2019-03-06  Pedro Alves  <palves@redhat.com>
3522
3523         * linux-fork.c (fork_info::clobber_regs): Delete.
3524         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
3525         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
3526         comment.  Adjust.
3527         (scoped_switch_fork_info::scoped_switch_fork_info)
3528         (checkpoint_command, linux_fork_context): Adjust
3529         fork_save_infrun_state calls.
3530
3531 2019-03-06  Pedro Alves  <palves@redhat.com>
3532
3533         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
3534         (inf_has_multiple_threads): Return 'bool' and rewrite using
3535         inferior_info::threads().
3536
3537 2019-03-06  Pedro Alves  <palves@redhat.com>
3538
3539         * linux-fork.c: Include <list>.
3540         (fork_list): Now a std::list instance.
3541         (fork_info): Add ctor, dtor, and in-class initialize all fields.
3542         (forks_exist_p, find_last_fork): Adjust.
3543         (new_fork): Delete.
3544         (one_fork_p): New.
3545         (add_fork): Adjust.
3546         (free_fork): Delete, folded into fork_info::~fork_info().
3547         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
3548         Adjust.
3549         (init_fork_list): Delete.
3550         (linux_fork_killall, linux_fork_mourn_inferior)
3551         (linux_fork_detach, info_checkpoints_command): Adjust.
3552         (_initialize_linux_fork): No longer call init_fork_list.
3553
3554 2019-03-06  Pedro Alves  <palves@redhat.com>
3555
3556         * linux-fork.c (new_fork): New, split out of ...
3557         (add_fork): ... this.  Return void.  Move "first fork" special
3558         case from here, to ...
3559         (checkpoint_command): ... here.
3560         * linux-linux.h (add_fork): Return void.
3561
3562 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3563
3564         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
3565
3566 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3567             Chris January  <chris.january@arm.com>
3568             David Lecomber  <david.lecomber@arm.com>
3569
3570         * f-exp.y: New token, UNOP_INTRINSIC.
3571         (exp): New pattern using UNOP_INTRINSIC token.
3572         (f77_keywords): Add 'abs' keyword.
3573         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
3574         (value_from_host_double): New function.
3575         (evaluate_subexp_f): Support UNOP_ABS.
3576
3577 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3578
3579         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
3580         types.
3581
3582 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3583
3584         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
3585         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
3586         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
3587
3588 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3589
3590         * f-exp.y (convert_to_kind_type): Handle more type kinds.
3591
3592 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3593             Chris January  <chris.january@arm.com>
3594
3595         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
3596         * f-exp.y: Define 'KIND' token.
3597         (exp): New pattern for KIND expressions.
3598         (ptype): Handle types with a kind extension.
3599         (direct_abs_decl): Extend to spot kind extensions.
3600         (f77_keywords): Add 'kind' to the list.
3601         (push_kind_type): New function.
3602         (convert_to_kind_type): New function.
3603         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
3604         * parse.c (operator_length_standard): Likewise.
3605         * parser-defs.h (enum type_pieces): Add tp_kind.
3606         * std-operator.def: Add UNOP_KIND.
3607
3608 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3609
3610         * f-exp.y (f_parse): Set yydebug.
3611
3612 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3613
3614         * f-lang.c (evaluate_subexp_f): New function.
3615         (exp_descriptor_f): New global.
3616         (f_language_defn): Use exp_descriptor_f instead of
3617         exp_descriptor_standard.
3618
3619 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3620
3621         * f-exp.y (struct token): Add comments.
3622         (dot_ops): Remove uppercase versions and the end marker.
3623         (f77_keywords): Likewise.
3624         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
3625         entries in the dot_ops array are case insensitive, and use
3626         strncasecmp to compare strings.  Also some whitespace cleanup in
3627         this area.  Similar for the f77_keywords array, except entries in
3628         this list might be case sensitive.
3629
3630 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3631
3632         * f-exp.y (struct f77_boolean_val): Add comments.
3633         (boolean_values): Remove uppercase versions, and end marker.
3634         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
3635         and use strncasecmp to achieve case insensitivity.  Additionally,
3636         perform whitespace cleanup around this code.
3637
3638 2019-03-06  Tom Tromey  <tromey@adacore.com>
3639
3640         * remote-sim.c (gdbsim_target_open): Use result of
3641         gdb_argv::release.
3642
3643 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
3644         Dirk Schubert  <dirk.schubert@arm.com>
3645         Chris January  <chris.january@arm.com>
3646
3647         * eval.c (evaluate_subexp_standard): Call Fortran argument
3648         wrapping logic.
3649         * f-lang.c (struct value): A value which can be passed into a
3650         Fortran function call.
3651         (fortran_argument_convert): Wrap Fortran arguments in a pointer
3652         where appropriate.
3653         (struct type): Value ready for a Fortran function call.
3654         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
3655         is needed.
3656         * f-lang.h (fortran_argument_convert): Declaration.
3657         (fortran_preserve_arg_pointer): Declaration.
3658         * infcall.c (value_arg_coerce): Call Fortran argument logic.
3659
3660 2019-03-05  Tom Tromey  <tromey@adacore.com>
3661
3662         * python/py-prettyprint.c (print_string_repr): Remove #if.
3663         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
3664
3665 2019-03-05  Tom Tromey  <tromey@adacore.com>
3666
3667         * target.c (the_dummy_target): Move later.  Change type to
3668         "dummy_target".
3669         (initialize_targets): Don't initialize the_dummy_target.
3670
3671 2019-03-05  Tom Tromey  <tromey@adacore.com>
3672
3673         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
3674         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
3675
3676 2019-03-05  Tom Tromey  <tromey@adacore.com>
3677
3678         * windows-nat.c (windows_nat_target::attach)
3679         (windows_nat_target::detach): Don't call gdb_flush.
3680         * valprint.c (generic_val_print, val_print, val_print_string):
3681         Don't call gdb_flush.
3682         * utils.c (defaulted_query): Don't call gdb_flush.
3683         * typeprint.c (print_type_scalar): Don't call gdb_flush.
3684         * target.c (target_announce_detach): Don't call gdb_flush.
3685         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
3686         * remote.c (extended_remote_target::attach): Don't call
3687         gdb_flush.
3688         * procfs.c (procfs_target::detach): Don't call gdb_flush.
3689         * printcmd.c (do_examine): Don't call gdb_flush.
3690         (info_display_command): Don't call gdb_flush.
3691         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
3692         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
3693         * memattr.c (info_mem_command): Don't call gdb_flush.
3694         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
3695         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
3696         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
3697         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
3698         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
3699         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
3700         (gnu_nat_target::detach): Don't call gdb_flush.
3701         * f-valprint.c (f_val_print): Don't call gdb_flush.
3702         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
3703         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
3704         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
3705         gdb_flush.
3706         * c-valprint.c (c_val_print): Don't call gdb_flush.
3707         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
3708
3709 2019-03-05  Tom Tromey  <tromey@adacore.com>
3710
3711         * varobj.c (update_dynamic_varobj_children): Update.
3712         (install_default_visualizer): Use reset, not release.
3713         * value.c (set_internalvar): Update.
3714         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
3715         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
3716         ATTRIBUTE_UNUSED_RESULT.
3717
3718 2019-03-05  Tom Tromey  <tromey@adacore.com>
3719
3720         * remote.c (class scoped_remote_fd) <release>: Add
3721         ATTRIBUTE_UNUSED_RESULT.
3722
3723 2019-03-05  Tom Tromey  <tromey@adacore.com>
3724
3725         * macroexp.c (struct macro_buffer) <release>: Add
3726         ATTRIBUTE_UNUSED_RESULT.
3727
3728 2019-03-05  Tom Tromey  <tromey@adacore.com>
3729
3730         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
3731         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
3732         ATTRIBUTE_UNUSED_RESULT.
3733
3734 2019-03-05  Tom Tromey  <tromey@adacore.com>
3735
3736         * common/scoped_fd.h (class scoped_fd) <release>: Add
3737         ATTRIBUTE_UNUSED_RESULT.
3738
3739 2019-03-05  Tom Tromey  <tromey@adacore.com>
3740
3741         * parser-defs.h (struct parser_state) <release>: Add
3742         ATTRIBUTE_UNUSED_RESULT.
3743
3744 2019-03-05  Tom Tromey  <tromey@adacore.com>
3745
3746         * utils.h (class gdb_argv) <release>: Add
3747         ATTRIBUTE_UNUSED_RESULT.
3748         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
3749
3750 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
3751
3752         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
3753         for-loop range, to avoid compiler warnings.
3754
3755         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
3756         avoid compiler warnings about unused variables.
3757
3758         * NEWS: Mention end of support for native debugging on MS-Windows
3759         before XP.
3760
3761         PR gdb/24292
3762         * common/netstuff.c:
3763         * gdbserver/gdbreplay.c
3764         * gdbserver/remote-utils.c:
3765         * ser-tcp.c:
3766         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
3767         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
3768         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
3769         'getaddrinfo' and 'freeaddrinfo' were not available before
3770         Windows XP, and mingw.org's MinGW headers by default define
3771         _WIN32_WINNT to 0x500.
3772
3773 2019-03-01  Gary Benson <gbenson@redhat.com>
3774
3775         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
3776
3777 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
3778             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
3779
3780         PR gdb/8527
3781         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
3782         set_sigint_trap, clear_sigint_trap.
3783
3784 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3785
3786         * target.c (target_detach): Clear the regcache and the
3787         frame cache.
3788
3789 2019-02-27  Pedro Alves  <palves@redhat.com>
3790
3791         * utils.c (set_screen_size): When we cap the height/width sizes,
3792         tweak the corresponding command variable to show "unlimited":
3793
3794 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
3795             Pedro Alves  <palves@redhat.com>
3796
3797         * utils.c (set_screen_size): Reduce "infinite" rows and columns
3798         before calling rl_set_screen_size.
3799
3800 2019-02-27  Tom Tromey  <tromey@adacore.com>
3801
3802         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
3803         define.
3804         * python/py-value.c: Remove Python 2.4 workaround.
3805         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
3806         workaround.
3807         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
3808         Python 2.4 workaround.
3809         * python/python-internal.h: Remove Python 2.4 comment.
3810         (Py_ssize_t): Don't define.
3811         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
3812         (gdb_Py_DECREF): Remove Python 2.4 workaround.
3813         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
3814         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
3815         * python/python.c (do_start_initialization): Remove Python 2.4
3816         workaround.
3817         * python/py-prettyprint.c (class dummy_python_frame): Remove.
3818         (print_children): Remove Python 2.4 workaround.
3819         * python/py-inferior.c (buffer_procs): Remove Python 2.4
3820         workaround.
3821         (CHARBUFFERPROC_NAME): Remove.
3822         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
3823         Python 2.4 workaround.
3824
3825 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3826
3827         * NEWS: Note minimum Python version.
3828
3829 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3830
3831         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
3832         code from these functions.  Remove corresponding ifdefs.  Use
3833         Py_buffer_up instead of explicit calls to PyBuffer_Release.
3834         Remove gotos and target of gotos.
3835         (infpy_search_memory): Likewise.
3836
3837 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3838
3839         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
3840         (hppa_gdbarch_init): Don't register deleted functions with
3841         gdbarch.
3842
3843 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3844
3845         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
3846         (h8300_unwind_sp): Delete.
3847         (h8300_dummy_id): Delete.
3848         (h8300_gdbarch_init): Don't register deleted functions with
3849         gdbarch.
3850
3851 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3852
3853         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
3854         (ft32_unwind_pc): Delete.
3855         (ft32_unwind_sp): Delete.
3856         (ft32_gdbarch_init): Don't register deleted functions with
3857         gdbarch.
3858
3859 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3860
3861         * gdb/frv-tdep.c (frv_dummy_id): Delete.
3862         (frv_unwind_pc): Delete.
3863         (frv_unwind_sp): Delete.
3864         (frv_gdbarch_init): Don't register deleted functions with
3865         gdbarch.
3866
3867 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3868
3869         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
3870         (riscv_unwind_pc): Delete.
3871         (riscv_unwind_sp): Delete.
3872         (riscv_gdbarch_init): Don't register deleted functions with
3873         gdbarch.
3874
3875 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3876
3877         * gdb/csky-tdep.c (csky_dummy_id): Delete.
3878         (csky_unwind_pc): Delete.
3879         (csky_unwind_sp): Delete.
3880         (csky_gdbarch_init): Don't register deleted functions with
3881         gdbarch.
3882
3883 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3884
3885         * gdb/cris-tdep.c (cris_dummy_id): Delete.
3886         (cris_unwind_pc): Delete.
3887         (cris_unwind_sp): Delete.
3888         (cris_gdbarch_init): Don't register deleted functions with
3889         gdbarch.
3890
3891 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3892
3893         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
3894         (bfin_unwind_pc): Delete.
3895         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
3896
3897 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3898
3899         * gdb/arm-tdep.c (arm_dummy_id): Delete.
3900         (arm_unwind_pc): Delete.
3901         (arm_unwind_sp): Delete.
3902         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
3903
3904 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3905
3906         * gdb/arc-tdep.c (arc_dummy_id): Delete.
3907         (arc_unwind_pc): Delete.
3908         (arc_unwind_sp): Delete.
3909         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
3910
3911 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3912
3913         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
3914         (alpha_unwind_pc): Delete.
3915         (alpha_gdbarch_init): Don't register deleted functions with
3916         gdbarch.
3917
3918 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3919
3920         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
3921         (aarch64_unwind_pc): Delete.
3922         (aarch64_unwind_sp): Delete.
3923         (aarch64_gdbarch_init): Don't register deleted functions with
3924         gdbarch.
3925
3926 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3927
3928         * gdbtypes.c (type_align): Don't consider static members when
3929         computing structure alignment.
3930
3931 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3932
3933         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
3934         return 0 for other types.
3935         * arch-utils.c (default_type_align): Always return 0.
3936         * gdbarch.h: Regenerate.
3937         * gdbarch.sh (type_align): Extend comment.
3938         * gdbtypes.c (type_align): Add additional comments, always call
3939         gdbarch_type_align before applying the default rules.
3940         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
3941         generic code will then apply a suitable default.
3942         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
3943         types, return 0 for other types.
3944
3945 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3946
3947         * NEWS: Create a new section for the next release branch.
3948         Rename the section of the current branch, now that it has
3949         been cut.
3950
3951 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3952
3953         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
3954         * version.in: Bump version to 8.3.50.DATE-git.
3955
3956 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
3957
3958         * aix-thread.c (ptid_cmp): Remove unused variable.
3959         (get_signaled_thread): Likewise.
3960         (store_regs_user_thread): Likewise.
3961         (store_regs_kernel_thread): Likewise.
3962         (fetch_regs_kernel_thread): Remove shadowed variable.
3963
3964 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3965
3966         * features/riscv/32bit-cpu.xml: Add register numbers.
3967         * features/riscv/32bit-fpu.c: Regenerate.
3968         * features/riscv/32bit-fpu.xml: Add register numbers.
3969         * features/riscv/64bit-cpu.xml: Add register numbers.
3970         * features/riscv/64bit-fpu.c: Regenerate.
3971         * features/riscv/64bit-fpu.xml: Add register numbers.
3972
3973 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
3974
3975         * NEWS: Mention two argument form of gdb.Value constructor.
3976         * python/py-value.c (convert_buffer_and_type_to_value): New
3977         function.
3978         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
3979         Add support for handling an optional second argument.  Call
3980         convert_buffer_and_type_to_value as appropriate.
3981         * python/python-internal.h (Py_buffer_deleter): New struct.
3982         (Py_buffer_up): New typedef.
3983
3984 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
3985
3986         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
3987         instead of releasing ownership.
3988
3989 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
3990
3991         * dwarf2read.c (open_and_init_dwp_file): Call
3992         elf_numsections instead of bfd_count_sections to initialize
3993         dwp_file->num_sections.
3994
3995 2019-02-25  Tom Tromey  <tromey@adacore.com>
3996
3997         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
3998
3999 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4000
4001         * gcore.in: Add '--readnever' option when invoking GDB.
4002
4003 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4004
4005         * MAINTAINERS: Update my email address.
4006
4007 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4008
4009         * build-id.c (build_id_to_debug_bfd_1): New function.
4010         (build_id_to_debug_bfd): Look for separate debug file in
4011         sysroot.
4012
4013 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4014
4015         * gdbarch.sh: Update the copyright year range that is placed into
4016         generated files.
4017
4018 2019-02-22  Keith Seitz  <keiths@redhat.com>
4019
4020         PR symtab/23853
4021         * linespec.c (create_sals_line_offset): Search for the default
4022         symtab's filename instead of its fullname.
4023
4024 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4025
4026         * NEWS: Update style defaults.
4027
4028 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4029
4030         * main.c (captured_main_1): Disable styling in batch mode.
4031
4032 2019-02-20  Tom Tromey  <tom@tromey.com>
4033
4034         * symtab.c (symtab_symbol_info): Fix typos.
4035
4036 2019-02-20  Tom Tromey  <tromey@adacore.com>
4037
4038         * findcmd.c (_initialize_mem_search): Use upper case for
4039         metasyntactic variables.
4040
4041 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
4042
4043         * aarch64-tdep.c (aarch64_add_reggroups): New function.
4044         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
4045
4046 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
4047
4048         * top.h (source_file_name): Change to std::string.
4049         * top.c (source_file_name): Likewise.
4050         (command_line_input): Adjust.
4051         * cli/cli-script.c (script_from_file): Adjust.
4052
4053 2019-02-19  Tom Tromey  <tromey@adacore.com>
4054
4055         * ravenscar-thread.c
4056         (ravenscar_thread_target::update_thread_list): Don't call
4057         ada_build_task_list.
4058         * ada-lang.h (ada_build_task_list): Don't declare.
4059         * ada-tasks.c (struct ada_tasks_inferior_data)
4060         <task_list_valid_p>: Now bool.
4061         (read_known_tasks, ada_task_list_changed)
4062         (ada_tasks_invalidate_inferior_data): Update.
4063         (read_known_tasks_array): Return bool.
4064         (read_known_tasks_list): Likewise.
4065         (read_known_tasks): Return void.
4066         (ada_build_task_list): Now static.
4067
4068 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4069
4070         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
4071         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
4072
4073 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4074
4075         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
4076         variant for ada_tasks_pspace_data_handle and
4077         ada_tasks_inferior_data_handle.
4078         (ada_tasks_pspace_data_cleanup): New function.
4079         (ada_tasks_inferior_data_cleanup): New function.
4080
4081 2019-02-17  Tom Tromey  <tom@tromey.com>
4082
4083         * macrotab.h (macro_source_fullname): Return a std::string.
4084         * macrotab.c (macro_include, check_for_redefinition)
4085         (macro_undef, macro_lookup_definition, foreach_macro)
4086         (foreach_macro_in_scope): Update.
4087         (macro_source_fullname): Return a std::string.
4088         * macrocmd.c (show_pp_source_pos): Update.
4089
4090 2019-02-17  Tom Tromey  <tom@tromey.com>
4091
4092         * macrocmd.c (show_pp_source_pos): Style the file names.
4093
4094 2019-02-17  Tom Tromey  <tom@tromey.com>
4095
4096         PR tui/24197:
4097         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
4098
4099 2019-02-17  Tom Tromey  <tom@tromey.com>
4100
4101         * ada-lang.c (user_select_syms): Use filtered printing.
4102         * utils.c (wrap_style): New global.
4103         (desired_style): Remove.
4104         (emit_style_escape): Add stream parameter.
4105         (set_output_style, reset_terminal_style, prompt_for_continue):
4106         Update.
4107         (flush_wrap_buffer): Only flush gdb_stdout.
4108         (wrap_here): Set wrap_style.
4109         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
4110         treat escape sequences as a character.  Change when wrap buffer is
4111         flushed.
4112         (fputs_styled): Do not set the output style when the default is
4113         requested.
4114         * ui-style.h (struct ui_file_style) <is_default>: New method.
4115         * source.c (print_source_lines_base): Emit escape sequences in one
4116         piece.
4117
4118 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4119
4120         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
4121         integers and enumeration types.
4122
4123 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4124
4125         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
4126         instead of lookup_symbol_in_language
4127         (do_exact_match): New function.
4128         (ada_get_symbol_name_matcher): Return do_exact_match when
4129         doing a verbatim match.
4130
4131 2019-02-15  Tom Tromey  <tromey@adacore.com>
4132
4133         * ravenscar-thread.c (ravenscar_thread_target::resume)
4134         (ravenscar_thread_target::wait): Special case wildcard requests.
4135
4136 2019-02-15  Tom Tromey  <tromey@adacore.com>
4137
4138         * ravenscar-thread.c (base_ptid): Remove.
4139         (struct ravenscar_thread_target) <close>: New method.
4140         <m_base_ptid>: New member.
4141         <update_inferior_ptid, active_task, task_is_currently_active,
4142         runtime_initialized>: Declare methods.
4143         <ravenscar_thread_target>: Add constructor.
4144         (ravenscar_thread_target::task_is_currently_active)
4145         (ravenscar_thread_target::update_inferior_ptid)
4146         (ravenscar_runtime_initialized): Rename.  Now methods.
4147         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4148         (ravenscar_thread_target::update_thread_list): Update.
4149         (ravenscar_thread_target::active_task): Now method.
4150         (ravenscar_thread_target::store_registers)
4151         (ravenscar_thread_target::prepare_to_store)
4152         (ravenscar_thread_target::prepare_to_store)
4153         (ravenscar_thread_target::mourn_inferior): Update.
4154         (ravenscar_inferior_created): Use "new" to create target.
4155         (ravenscar_thread_target::get_ada_task_ptid): Update.
4156         (_initialize_ravenscar): Don't initialize base_ptid.
4157         (ravenscar_ops): Remove global.
4158
4159 2019-02-15  Tom Tromey  <tromey@adacore.com>
4160
4161         * target.h (push_target): Declare new overload.
4162         * target.c (push_target): New overload, taking an rvalue reference.
4163         * remote.c (remote_target::open_1): Use push_target overload.
4164         * corelow.c (core_target_open): Use push_target overload.
4165
4166 2019-02-15  Tom Tromey  <tromey@adacore.com>
4167
4168         * ravenscar-thread.c (is_ravenscar_task)
4169         (ravenscar_task_is_currently_active): Return bool.
4170         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4171         (_initialize_ravenscar): Remove "(void)".
4172         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4173         Return bool.
4174
4175 2019-02-15  Tom Tromey  <tromey@adacore.com>
4176
4177         * ravenscar-thread.c (ravenscar_runtime_initializer)
4178         (has_ravenscar_runtime, get_running_thread_id)
4179         (ravenscar_thread_target::resume): Fix indentation.
4180
4181 2019-02-15  Tom Tromey  <tromey@adacore.com>
4182
4183         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4184         from ravenscar_arch_ops.
4185         (sparc_ravenscar_ops::fetch_registers)
4186         (sparc_ravenscar_ops::store_registers): Now methods.
4187         (sparc_ravenscar_prepare_to_store): Remove.
4188         (sparc_ravenscar_ops): Redefine.
4189         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4190         methods and destructor.  Remove members.
4191         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4192         (ravenscar_thread_target::store_registers)
4193         (ravenscar_thread_target::prepare_to_store): Update.
4194         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4195         Remove.
4196         (struct ppc_ravenscar_powerpc_ops): Derive from
4197         ravenscar_arch_ops.
4198         (ppc_ravenscar_powerpc_ops::fetch_registers)
4199         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4200         (ppc_ravenscar_powerpc_ops): Redefine.
4201         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4202         (ppc_ravenscar_e500_ops::fetch_registers)
4203         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4204         (ppc_ravenscar_e500_ops): Redefine.
4205         * aarch64-ravenscar-thread.c
4206         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4207         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4208         (aarch64_ravenscar_fetch_registers)
4209         (aarch64_ravenscar_store_registers): Now methods.
4210         (aarch64_ravenscar_ops): Redefine.
4211
4212 2019-02-15  Tom Tromey  <tromey@adacore.com>
4213
4214         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4215         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4216         (ravenscar_thread_target::stopped_by_watchpoint)
4217         (ravenscar_thread_target::stopped_data_address)
4218         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4219
4220 2019-02-15  Tom Tromey  <tromey@adacore.com>
4221
4222         * ravenscar-thread.c: Fix some typos.
4223
4224 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4225             Tom Tromey  <tromey@adacore.com>
4226
4227         * ada-lang.c (ada_exception_sal): Change addr_string to a
4228         std::string.
4229         (create_ada_exception_catchpoint): Update.
4230
4231 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4232             Tom Tromey  <tromey@adacore.com>
4233
4234         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4235         (bp_location_ops): Remove.
4236         (base_breakpoint_allocate_location): Update.
4237         (free_bp_location): Update.
4238         * ada-lang.c (class ada_catchpoint_location)
4239         <ada_catchpoint_location>: Remove ops parameter.
4240         (ada_catchpoint_location_dtor): Remove.
4241         (ada_catchpoint_location_ops): Remove.
4242         (allocate_location_exception): Update.
4243         * breakpoint.h (struct bp_location_ops): Remove.
4244         (class bp_location) <bp_location>: Remove bp_location_ops
4245         parameter.
4246         <~bp_location>: Add destructor.
4247         <ops>: Remove.
4248
4249 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4250             Pedro Alves  <palves@redhat.com>
4251
4252         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4253         'PATH_MAX'.
4254
4255 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4256             Samuel Thibault  <samuel.thibault@gnu.org>
4257             Thomas Schwinge  <thomas@codesourcery.com>
4258
4259         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4260         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4261
4262 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4263
4264         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4265         (check_empty): Use "const char *".
4266
4267         * gnu-nat.c (gnu_nat_target::detach): Instead of
4268         'detach_inferior (pid)' call
4269         'detach_inferior (find_inferior_pid (pid))'.
4270
4271         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4272         'nat/fork-inferior.o'.
4273         * gnu-nat.c: #include "nat/fork-inferior.h".
4274
4275         * gnu-nat.c (gnu_nat_target::detach): Instead of
4276         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4277         * gnu-nat.h: #include "inf-child.h".
4278         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4279         'i386_gnu_nat_target::fetch_registers'.
4280         (gnu_store_registers): Rename/move to
4281         'i386_gnu_nat_target::store_registers'.
4282
4283         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4284         * gnu-nat.h (mach_thread_info): New function.
4285         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4286
4287         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4288
4289 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4290
4291         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4292
4293 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4294
4295         * windows-nat.c (windows_add_thread): Add new parameter
4296         "main_thread_p" with default value set to false.  Update
4297         function documentation as well as all callers.
4298         (windows_delete_thread): Likewise.
4299         (fake_create_process): Update call to windows_add_thread.
4300         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4301         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4302         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4303         call to windows_delete_thread.
4304
4305 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4306
4307         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4308
4309 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4310
4311         * symfile.c (find_separate_debug_file): Use canonical path of
4312         sysroot with child_path instead of gdb_sysroot if it is valid.
4313
4314 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4315
4316         * symfile.c (find_separate_debug_file): Use child_path to
4317         determine if an object file is under a sysroot.
4318
4319 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4320
4321         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4322         unittests/child-path-selftests.c.
4323         * common/pathstuff.c (child_path): New function.
4324         * common/pathstuff.h (child_path): New prototype.
4325         * unittests/child-path-selftests.c: New file.
4326
4327 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4328
4329         * symfile.c (find_separate_debug_file): Look for separate debug
4330         files in debug directories under the sysroot.
4331
4332 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4333
4334         * symtab.h (struct minimal_symbol data_p): New const method.
4335         (struct minimal_symbol text_p): Likewise.
4336         * symtab.c (output_source_filename): Use file name style
4337         to print file name.
4338         (print_symbol_info): Likewise.
4339         (print_msymbol_info): Use address style to print addresses.
4340         Use function name style to print executable text symbols.
4341         (expand_symtab_containing_pc): Use data_p.
4342         (find_pc_sect_compunit_symtab): Likewise.
4343
4344 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4345
4346         * breakpoint.c (describe_other_breakpoints): Use address style
4347         to print addresses.
4348         (say_where): Likewise.
4349
4350 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4351
4352         * ada-typeprint.c (print_func_type): Print function name
4353         style to print function name.
4354         * c-typeprint.c (c_print_type_1): Likewise.
4355
4356 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4357
4358         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4359         for execve.
4360
4361 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4362
4363         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4364         type_stack.
4365
4366 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
4367
4368         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
4369         TYPE_CODE_REF types.
4370
4371 2019-02-08  Jim Wilson  <jimw@sifive.com>
4372
4373         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4374         (riscv_linux_fregset): New.
4375         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
4376
4377 2019-02-07  Tom Tromey  <tom@tromey.com>
4378
4379         * thread.c (thread_cancel_execution_command): Update.
4380         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
4381         methods.
4382         (struct thread_fsm_ops): Remove.
4383         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
4384         (thread_fsm_should_stop, thread_fsm_return_value)
4385         (thread_fsm_set_finished, thread_fsm_finished_p)
4386         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
4387         Don't declare.
4388         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
4389         * infrun.c (clear_proceed_status_thread)
4390         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
4391         (print_stop_event): Update.
4392         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
4393         Add constructor.
4394         (step_command_fsm_ops): Remove.
4395         (new_step_command_fsm): Remove.
4396         (step_1): Update.
4397         (step_command_fsm::should_stop): Rename from
4398         step_command_fsm_should_stop.
4399         (step_command_fsm::clean_up): Rename from
4400         step_command_fsm_clean_up.
4401         (step_command_fsm::do_async_reply_reason): Rename from
4402         step_command_fsm_async_reply_reason.
4403         (struct until_next_fsm): Inherit from thread_fsm.  Add
4404         constructor.
4405         (until_next_fsm_ops): Remove.
4406         (new_until_next_fsm): Remove.
4407         (until_next_fsm::should_stop): Rename from
4408         until_next_fsm_should_stop.
4409         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
4410         (until_next_fsm::do_async_reply_reason): Rename from
4411         until_next_fsm_async_reply_reason.
4412         (struct finish_command_fsm): Inherit from thread_fsm.  Add
4413         constructor.  Change type of breakpoint.
4414         (finish_command_fsm_ops): Remove.
4415         (new_finish_command_fsm): Remove.
4416         (finish_command_fsm::should_stop): Rename from
4417         finish_command_fsm_should_stop.
4418         (finish_command_fsm::clean_up): Rename from
4419         finish_command_fsm_clean_up.
4420         (finish_command_fsm::return_value): Rename from
4421         finish_command_fsm_return_value.
4422         (finish_command_fsm::do_async_reply_reason): Rename from
4423         finish_command_fsm_async_reply_reason.
4424         (finish_command): Update.
4425         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
4426         Add constructor.
4427         (call_thread_fsm_ops): Remove.
4428         (call_thread_fsm::call_thread_fsm): Rename from
4429         new_call_thread_fsm.
4430         (call_thread_fsm::should_stop): Rename from
4431         call_thread_fsm_should_stop.
4432         (call_thread_fsm::should_notify_stop): Rename from
4433         call_thread_fsm_should_notify_stop.
4434         (run_inferior_call, call_function_by_hand_dummy): Update.
4435         * cli/cli-interp.c (should_print_stop_to_console): Update.
4436         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
4437         Add constructor.  Change type of location_breakpoint,
4438         caller_breakpoint.
4439         (until_break_fsm_ops): Remove.
4440         (new_until_break_fsm): Remove.
4441         (until_break_fsm::should_stop): Rename from
4442         until_break_fsm_should_stop.
4443         (until_break_fsm::clean_up): Rename from
4444         until_break_fsm_clean_up.
4445         (until_break_fsm::do_async_reply_reason): Rename from
4446         until_break_fsm_async_reply_reason.
4447         (until_break_command): Update.
4448         * thread-fsm.c: Remove.
4449         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
4450
4451 2019-02-07  Tom Tromey  <tom@tromey.com>
4452
4453         * yy-remap.h: Add include guard.
4454         * xtensa-tdep.h: Add include guard.
4455         * xcoffread.h: Rename include guard.
4456         * varobj-iter.h: Add include guard.
4457         * tui/tui.h: Rename include guard.
4458         * tui/tui-winsource.h: Rename include guard.
4459         * tui/tui-wingeneral.h: Rename include guard.
4460         * tui/tui-windata.h: Rename include guard.
4461         * tui/tui-win.h: Rename include guard.
4462         * tui/tui-stack.h: Rename include guard.
4463         * tui/tui-source.h: Rename include guard.
4464         * tui/tui-regs.h: Rename include guard.
4465         * tui/tui-out.h: Rename include guard.
4466         * tui/tui-layout.h: Rename include guard.
4467         * tui/tui-io.h: Rename include guard.
4468         * tui/tui-hooks.h: Rename include guard.
4469         * tui/tui-file.h: Rename include guard.
4470         * tui/tui-disasm.h: Rename include guard.
4471         * tui/tui-data.h: Rename include guard.
4472         * tui/tui-command.h: Rename include guard.
4473         * tic6x-tdep.h: Add include guard.
4474         * target/waitstatus.h: Rename include guard.
4475         * target/wait.h: Rename include guard.
4476         * target/target.h: Rename include guard.
4477         * target/resume.h: Rename include guard.
4478         * target-float.h: Rename include guard.
4479         * stabsread.h: Add include guard.
4480         * rs6000-tdep.h: Add include guard.
4481         * riscv-fbsd-tdep.h: Add include guard.
4482         * regformats/regdef.h: Rename include guard.
4483         * record.h: Rename include guard.
4484         * python/python.h: Rename include guard.
4485         * python/python-internal.h: Rename include guard.
4486         * python/py-stopevent.h: Rename include guard.
4487         * python/py-ref.h: Rename include guard.
4488         * python/py-record.h: Rename include guard.
4489         * python/py-record-full.h: Rename include guard.
4490         * python/py-record-btrace.h: Rename include guard.
4491         * python/py-instruction.h: Rename include guard.
4492         * python/py-events.h: Rename include guard.
4493         * python/py-event.h: Rename include guard.
4494         * procfs.h: Add include guard.
4495         * proc-utils.h: Add include guard.
4496         * p-lang.h: Add include guard.
4497         * or1k-tdep.h: Rename include guard.
4498         * observable.h: Rename include guard.
4499         * nto-tdep.h: Rename include guard.
4500         * nat/x86-linux.h: Rename include guard.
4501         * nat/x86-linux-dregs.h: Rename include guard.
4502         * nat/x86-gcc-cpuid.h: Add include guard.
4503         * nat/x86-dregs.h: Rename include guard.
4504         * nat/x86-cpuid.h: Rename include guard.
4505         * nat/ppc-linux.h: Rename include guard.
4506         * nat/mips-linux-watch.h: Rename include guard.
4507         * nat/linux-waitpid.h: Rename include guard.
4508         * nat/linux-ptrace.h: Rename include guard.
4509         * nat/linux-procfs.h: Rename include guard.
4510         * nat/linux-osdata.h: Rename include guard.
4511         * nat/linux-nat.h: Rename include guard.
4512         * nat/linux-namespaces.h: Rename include guard.
4513         * nat/linux-btrace.h: Rename include guard.
4514         * nat/glibc_thread_db.h: Rename include guard.
4515         * nat/gdb_thread_db.h: Rename include guard.
4516         * nat/gdb_ptrace.h: Rename include guard.
4517         * nat/fork-inferior.h: Rename include guard.
4518         * nat/amd64-linux-siginfo.h: Rename include guard.
4519         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
4520         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
4521         * nat/aarch64-linux.h: Rename include guard.
4522         * nat/aarch64-linux-hw-point.h: Rename include guard.
4523         * mn10300-tdep.h: Add include guard.
4524         * mips-linux-tdep.h: Add include guard.
4525         * mi/mi-parse.h: Rename include guard.
4526         * mi/mi-out.h: Rename include guard.
4527         * mi/mi-main.h: Rename include guard.
4528         * mi/mi-interp.h: Rename include guard.
4529         * mi/mi-getopt.h: Rename include guard.
4530         * mi/mi-console.h: Rename include guard.
4531         * mi/mi-common.h: Rename include guard.
4532         * mi/mi-cmds.h: Rename include guard.
4533         * mi/mi-cmd-break.h: Rename include guard.
4534         * m2-lang.h: Add include guard.
4535         * location.h: Rename include guard.
4536         * linux-record.h: Rename include guard.
4537         * linux-nat.h: Add include guard.
4538         * linux-fork.h: Add include guard.
4539         * i386-darwin-tdep.h: Rename include guard.
4540         * hppa-linux-offsets.h: Add include guard.
4541         * guile/guile.h: Rename include guard.
4542         * guile/guile-internal.h: Rename include guard.
4543         * gnu-nat.h: Rename include guard.
4544         * gdb-stabs.h: Rename include guard.
4545         * frv-tdep.h: Add include guard.
4546         * f-lang.h: Add include guard.
4547         * event-loop.h: Add include guard.
4548         * darwin-nat.h: Rename include guard.
4549         * cp-abi.h: Rename include guard.
4550         * config/sparc/nm-sol2.h: Rename include guard.
4551         * config/nm-nto.h: Rename include guard.
4552         * config/nm-linux.h: Add include guard.
4553         * config/i386/nm-i386gnu.h: Rename include guard.
4554         * config/djgpp/nl_types.h: Rename include guard.
4555         * config/djgpp/langinfo.h: Rename include guard.
4556         * compile/gcc-cp-plugin.h: Add include guard.
4557         * compile/gcc-c-plugin.h: Add include guard.
4558         * compile/compile.h: Rename include guard.
4559         * compile/compile-object-run.h: Rename include guard.
4560         * compile/compile-object-load.h: Rename include guard.
4561         * compile/compile-internal.h: Rename include guard.
4562         * compile/compile-cplus.h: Rename include guard.
4563         * compile/compile-c.h: Rename include guard.
4564         * common/xml-utils.h: Rename include guard.
4565         * common/x86-xstate.h: Rename include guard.
4566         * common/version.h: Rename include guard.
4567         * common/vec.h: Rename include guard.
4568         * common/tdesc.h: Rename include guard.
4569         * common/selftest.h: Rename include guard.
4570         * common/scoped_restore.h: Rename include guard.
4571         * common/scoped_mmap.h: Rename include guard.
4572         * common/scoped_fd.h: Rename include guard.
4573         * common/safe-iterator.h: Rename include guard.
4574         * common/run-time-clock.h: Rename include guard.
4575         * common/refcounted-object.h: Rename include guard.
4576         * common/queue.h: Rename include guard.
4577         * common/ptid.h: Rename include guard.
4578         * common/print-utils.h: Rename include guard.
4579         * common/preprocessor.h: Rename include guard.
4580         * common/pathstuff.h: Rename include guard.
4581         * common/observable.h: Rename include guard.
4582         * common/netstuff.h: Rename include guard.
4583         * common/job-control.h: Rename include guard.
4584         * common/host-defs.h: Rename include guard.
4585         * common/gdb_wait.h: Rename include guard.
4586         * common/gdb_vecs.h: Rename include guard.
4587         * common/gdb_unlinker.h: Rename include guard.
4588         * common/gdb_unique_ptr.h: Rename include guard.
4589         * common/gdb_tilde_expand.h: Rename include guard.
4590         * common/gdb_sys_time.h: Rename include guard.
4591         * common/gdb_string_view.h: Rename include guard.
4592         * common/gdb_splay_tree.h: Rename include guard.
4593         * common/gdb_setjmp.h: Rename include guard.
4594         * common/gdb_ref_ptr.h: Rename include guard.
4595         * common/gdb_optional.h: Rename include guard.
4596         * common/gdb_locale.h: Rename include guard.
4597         * common/gdb_assert.h: Rename include guard.
4598         * common/filtered-iterator.h: Rename include guard.
4599         * common/filestuff.h: Rename include guard.
4600         * common/fileio.h: Rename include guard.
4601         * common/environ.h: Rename include guard.
4602         * common/common-utils.h: Rename include guard.
4603         * common/common-types.h: Rename include guard.
4604         * common/common-regcache.h: Rename include guard.
4605         * common/common-inferior.h: Rename include guard.
4606         * common/common-gdbthread.h: Rename include guard.
4607         * common/common-exceptions.h: Rename include guard.
4608         * common/common-defs.h: Rename include guard.
4609         * common/common-debug.h: Rename include guard.
4610         * common/cleanups.h: Rename include guard.
4611         * common/buffer.h: Rename include guard.
4612         * common/btrace-common.h: Rename include guard.
4613         * common/break-common.h: Rename include guard.
4614         * cli/cli-utils.h: Rename include guard.
4615         * cli/cli-style.h: Rename include guard.
4616         * cli/cli-setshow.h: Rename include guard.
4617         * cli/cli-script.h: Rename include guard.
4618         * cli/cli-interp.h: Rename include guard.
4619         * cli/cli-decode.h: Rename include guard.
4620         * cli/cli-cmds.h: Rename include guard.
4621         * charset-list.h: Add include guard.
4622         * buildsym-legacy.h: Rename include guard.
4623         * bfin-tdep.h: Add include guard.
4624         * ax.h: Rename include guard.
4625         * arm-linux-tdep.h: Add include guard.
4626         * arm-fbsd-tdep.h: Add include guard.
4627         * arch/xtensa.h: Rename include guard.
4628         * arch/tic6x.h: Add include guard.
4629         * arch/i386.h: Add include guard.
4630         * arch/arm.h: Rename include guard.
4631         * arch/arm-linux.h: Rename include guard.
4632         * arch/arm-get-next-pcs.h: Rename include guard.
4633         * arch/amd64.h: Add include guard.
4634         * arch/aarch64-insn.h: Rename include guard.
4635         * arch-utils.h: Rename include guard.
4636         * annotate.h: Add include guard.
4637         * amd64-darwin-tdep.h: Rename include guard.
4638         * aarch64-linux-tdep.h: Add include guard.
4639         * aarch64-fbsd-tdep.h: Add include guard.
4640         * aarch32-linux-nat.h: Add include guard.
4641
4642 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4643
4644         * macrotab.c (macro_define_internal): New function that
4645         factorizes macro_define_object_internal and macro_define_function
4646         code.
4647         (macro_define_object_internal): Use macro_define_internal.
4648         (macro_define_function): Likewise.
4649
4650 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4651
4652         * macrocmd.c (extract_identifier): Return
4653         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
4654         callers.
4655
4656 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
4657
4658         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
4659
4660 2019-02-05  Tom Tromey  <tom@tromey.com>
4661
4662         * target.c (target_stack::unpush): Move assertion earlier.
4663
4664 2019-01-30  Tom Tromey  <tom@tromey.com>
4665
4666         PR python/23615:
4667         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
4668         (gdbpy_parse_and_eval): Likewise.
4669         * python/python-internal.h (gdbpy_allow_threads): New class.
4670
4671 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
4672
4673         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
4674         (aarch64_fbsd_fpregmap): Move earlier.
4675         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
4676         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4677         instead of individual calls to trad_frame_set_reg_addr.
4678         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
4679         earlier.
4680         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
4681         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4682         instead of individual calls to trad_frame_set_reg_addr.
4683
4684 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
4685
4686         * CONTRIBUTE: Replace contribution list with wiki link.
4687
4688 2019-01-25  Tom Tromey  <tom@tromey.com>
4689
4690         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
4691
4692 2019-01-25  Tom Tromey  <tom@tromey.com>
4693
4694         * xtensa-linux-nat.c: Fix common/ includes.
4695         * xml-support.h: Fix common/ includes.
4696         * xml-support.c: Fix common/ includes.
4697         * x86-linux-nat.c: Fix common/ includes.
4698         * windows-nat.c: Fix common/ includes.
4699         * varobj.h: Fix common/ includes.
4700         * varobj.c: Fix common/ includes.
4701         * value.c: Fix common/ includes.
4702         * valops.c: Fix common/ includes.
4703         * utils.c: Fix common/ includes.
4704         * unittests/xml-utils-selftests.c: Fix common/ includes.
4705         * unittests/utils-selftests.c: Fix common/ includes.
4706         * unittests/unpack-selftests.c: Fix common/ includes.
4707         * unittests/tracepoint-selftests.c: Fix common/ includes.
4708         * unittests/style-selftests.c: Fix common/ includes.
4709         * unittests/string_view-selftests.c: Fix common/ includes.
4710         * unittests/scoped_restore-selftests.c: Fix common/ includes.
4711         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
4712         * unittests/scoped_fd-selftests.c: Fix common/ includes.
4713         * unittests/rsp-low-selftests.c: Fix common/ includes.
4714         * unittests/parse-connection-spec-selftests.c: Fix common/
4715         includes.
4716         * unittests/optional-selftests.c: Fix common/ includes.
4717         * unittests/offset-type-selftests.c: Fix common/ includes.
4718         * unittests/observable-selftests.c: Fix common/ includes.
4719         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
4720         * unittests/memrange-selftests.c: Fix common/ includes.
4721         * unittests/memory-map-selftests.c: Fix common/ includes.
4722         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
4723         * unittests/function-view-selftests.c: Fix common/ includes.
4724         * unittests/environ-selftests.c: Fix common/ includes.
4725         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
4726         * unittests/common-utils-selftests.c: Fix common/ includes.
4727         * unittests/cli-utils-selftests.c: Fix common/ includes.
4728         * unittests/array-view-selftests.c: Fix common/ includes.
4729         * ui-file.c: Fix common/ includes.
4730         * tui/tui-io.c: Fix common/ includes.
4731         * tracepoint.h: Fix common/ includes.
4732         * tracepoint.c: Fix common/ includes.
4733         * tracefile-tfile.c: Fix common/ includes.
4734         * top.h: Fix common/ includes.
4735         * top.c: Fix common/ includes.
4736         * thread.c: Fix common/ includes.
4737         * target/waitstatus.h: Fix common/ includes.
4738         * target/waitstatus.c: Fix common/ includes.
4739         * target.h: Fix common/ includes.
4740         * target.c: Fix common/ includes.
4741         * target-memory.c: Fix common/ includes.
4742         * target-descriptions.c: Fix common/ includes.
4743         * symtab.h: Fix common/ includes.
4744         * symfile.c: Fix common/ includes.
4745         * stap-probe.c: Fix common/ includes.
4746         * spu-linux-nat.c: Fix common/ includes.
4747         * sparc-nat.c: Fix common/ includes.
4748         * source.c: Fix common/ includes.
4749         * solib.c: Fix common/ includes.
4750         * solib-target.c: Fix common/ includes.
4751         * ser-unix.c: Fix common/ includes.
4752         * ser-tcp.c: Fix common/ includes.
4753         * ser-pipe.c: Fix common/ includes.
4754         * ser-base.c: Fix common/ includes.
4755         * selftest-arch.c: Fix common/ includes.
4756         * s12z-tdep.c: Fix common/ includes.
4757         * rust-exp.y: Fix common/ includes.
4758         * rs6000-aix-tdep.c: Fix common/ includes.
4759         * riscv-tdep.c: Fix common/ includes.
4760         * remote.c: Fix common/ includes.
4761         * remote-notif.h: Fix common/ includes.
4762         * remote-fileio.h: Fix common/ includes.
4763         * remote-fileio.c: Fix common/ includes.
4764         * regcache.h: Fix common/ includes.
4765         * regcache.c: Fix common/ includes.
4766         * record-btrace.c: Fix common/ includes.
4767         * python/python.c: Fix common/ includes.
4768         * python/py-type.c: Fix common/ includes.
4769         * python/py-inferior.c: Fix common/ includes.
4770         * progspace.h: Fix common/ includes.
4771         * producer.c: Fix common/ includes.
4772         * procfs.c: Fix common/ includes.
4773         * proc-api.c: Fix common/ includes.
4774         * printcmd.c: Fix common/ includes.
4775         * ppc-linux-nat.c: Fix common/ includes.
4776         * parser-defs.h: Fix common/ includes.
4777         * osdata.c: Fix common/ includes.
4778         * obsd-nat.c: Fix common/ includes.
4779         * nat/x86-linux.c: Fix common/ includes.
4780         * nat/x86-linux-dregs.c: Fix common/ includes.
4781         * nat/x86-dregs.h: Fix common/ includes.
4782         * nat/x86-dregs.c: Fix common/ includes.
4783         * nat/ppc-linux.c: Fix common/ includes.
4784         * nat/mips-linux-watch.h: Fix common/ includes.
4785         * nat/mips-linux-watch.c: Fix common/ includes.
4786         * nat/linux-waitpid.c: Fix common/ includes.
4787         * nat/linux-ptrace.h: Fix common/ includes.
4788         * nat/linux-ptrace.c: Fix common/ includes.
4789         * nat/linux-procfs.c: Fix common/ includes.
4790         * nat/linux-personality.c: Fix common/ includes.
4791         * nat/linux-osdata.c: Fix common/ includes.
4792         * nat/linux-namespaces.c: Fix common/ includes.
4793         * nat/linux-btrace.h: Fix common/ includes.
4794         * nat/linux-btrace.c: Fix common/ includes.
4795         * nat/fork-inferior.c: Fix common/ includes.
4796         * nat/amd64-linux-siginfo.c: Fix common/ includes.
4797         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
4798         * nat/aarch64-linux.c: Fix common/ includes.
4799         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
4800         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
4801         * namespace.h: Fix common/ includes.
4802         * mips-linux-tdep.c: Fix common/ includes.
4803         * minsyms.c: Fix common/ includes.
4804         * mi/mi-parse.h: Fix common/ includes.
4805         * mi/mi-main.c: Fix common/ includes.
4806         * mi/mi-cmd-env.c: Fix common/ includes.
4807         * memrange.h: Fix common/ includes.
4808         * memattr.c: Fix common/ includes.
4809         * maint.h: Fix common/ includes.
4810         * maint.c: Fix common/ includes.
4811         * main.c: Fix common/ includes.
4812         * machoread.c: Fix common/ includes.
4813         * location.c: Fix common/ includes.
4814         * linux-thread-db.c: Fix common/ includes.
4815         * linux-nat.c: Fix common/ includes.
4816         * linux-fork.c: Fix common/ includes.
4817         * inline-frame.c: Fix common/ includes.
4818         * infrun.c: Fix common/ includes.
4819         * inflow.c: Fix common/ includes.
4820         * inferior.h: Fix common/ includes.
4821         * inferior.c: Fix common/ includes.
4822         * infcmd.c: Fix common/ includes.
4823         * inf-ptrace.c: Fix common/ includes.
4824         * inf-child.c: Fix common/ includes.
4825         * ia64-linux-nat.c: Fix common/ includes.
4826         * i387-tdep.c: Fix common/ includes.
4827         * i386-tdep.c: Fix common/ includes.
4828         * i386-linux-tdep.c: Fix common/ includes.
4829         * i386-linux-nat.c: Fix common/ includes.
4830         * i386-go32-tdep.c: Fix common/ includes.
4831         * i386-fbsd-tdep.c: Fix common/ includes.
4832         * i386-fbsd-nat.c: Fix common/ includes.
4833         * guile/scm-type.c: Fix common/ includes.
4834         * guile/guile.c: Fix common/ includes.
4835         * go32-nat.c: Fix common/ includes.
4836         * gnu-nat.c: Fix common/ includes.
4837         * gdbthread.h: Fix common/ includes.
4838         * gdbarch-selftests.c: Fix common/ includes.
4839         * gdb_usleep.c: Fix common/ includes.
4840         * gdb_select.h: Fix common/ includes.
4841         * gdb_bfd.c: Fix common/ includes.
4842         * gcore.c: Fix common/ includes.
4843         * fork-child.c: Fix common/ includes.
4844         * findvar.c: Fix common/ includes.
4845         * fbsd-nat.c: Fix common/ includes.
4846         * event-top.c: Fix common/ includes.
4847         * event-loop.c: Fix common/ includes.
4848         * dwarf2read.c: Fix common/ includes.
4849         * dwarf2loc.c: Fix common/ includes.
4850         * dwarf2-frame.c: Fix common/ includes.
4851         * dwarf-index-cache.c: Fix common/ includes.
4852         * dtrace-probe.c: Fix common/ includes.
4853         * disasm-selftests.c: Fix common/ includes.
4854         * defs.h: Fix common/ includes.
4855         * csky-tdep.c: Fix common/ includes.
4856         * cp-valprint.c: Fix common/ includes.
4857         * cp-support.h: Fix common/ includes.
4858         * cp-support.c: Fix common/ includes.
4859         * corelow.c: Fix common/ includes.
4860         * completer.h: Fix common/ includes.
4861         * completer.c: Fix common/ includes.
4862         * compile/compile.c: Fix common/ includes.
4863         * compile/compile-loc2c.c: Fix common/ includes.
4864         * compile/compile-cplus-types.c: Fix common/ includes.
4865         * compile/compile-cplus-symbols.c: Fix common/ includes.
4866         * command.h: Fix common/ includes.
4867         * cli/cli-dump.c: Fix common/ includes.
4868         * cli/cli-cmds.c: Fix common/ includes.
4869         * charset.c: Fix common/ includes.
4870         * build-id.c: Fix common/ includes.
4871         * btrace.h: Fix common/ includes.
4872         * btrace.c: Fix common/ includes.
4873         * breakpoint.h: Fix common/ includes.
4874         * breakpoint.c: Fix common/ includes.
4875         * ax.h:
4876         (enum agent_op): Fix common/ includes.
4877         * ax-general.c (struct aop_map): Fix common/ includes.
4878         * ax-gdb.c: Fix common/ includes.
4879         * auxv.c: Fix common/ includes.
4880         * auto-load.c: Fix common/ includes.
4881         * arm-tdep.c: Fix common/ includes.
4882         * arch/riscv.c: Fix common/ includes.
4883         * arch/ppc-linux-common.c: Fix common/ includes.
4884         * arch/i386.c: Fix common/ includes.
4885         * arch/arm.c: Fix common/ includes.
4886         * arch/arm-linux.c: Fix common/ includes.
4887         * arch/arm-get-next-pcs.c: Fix common/ includes.
4888         * arch/amd64.c: Fix common/ includes.
4889         * arch/aarch64.c: Fix common/ includes.
4890         * arch/aarch64-insn.c: Fix common/ includes.
4891         * arch-utils.c: Fix common/ includes.
4892         * amd64-windows-tdep.c: Fix common/ includes.
4893         * amd64-tdep.c: Fix common/ includes.
4894         * amd64-sol2-tdep.c: Fix common/ includes.
4895         * amd64-obsd-tdep.c: Fix common/ includes.
4896         * amd64-nbsd-tdep.c: Fix common/ includes.
4897         * amd64-linux-tdep.c: Fix common/ includes.
4898         * amd64-linux-nat.c: Fix common/ includes.
4899         * amd64-fbsd-tdep.c: Fix common/ includes.
4900         * amd64-fbsd-nat.c: Fix common/ includes.
4901         * amd64-dicos-tdep.c: Fix common/ includes.
4902         * amd64-darwin-tdep.c: Fix common/ includes.
4903         * agent.c: Fix common/ includes.
4904         * ada-lang.h: Fix common/ includes.
4905         * ada-lang.c: Fix common/ includes.
4906         * aarch64-tdep.c: Fix common/ includes.
4907
4908 2019-01-25  Tom Tromey  <tom@tromey.com>
4909
4910         * common/create-version.sh: Use common/version.h.
4911
4912 2019-01-24  Pedro Alves  <palves@redhat.com>
4913
4914         * infrun.c (signal_stop, signal_print, signal_program)
4915         (signal_catch, signal_pass): Now arrays instead of pointers.
4916         (update_signals_program_target, do_target_resume)
4917         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
4918         * linux-nat.c (linux_nat_target::pass_signals)
4919         (linux_nat_target::create_inferior, linux_nat_target::attach):
4920         Adjust.
4921         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
4922         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
4923         * procfs.c (procfs_target::pass_signals): Adjust.
4924         * record-full.c (record_full_target::resume): Adjust.
4925         * remote.c (remote_target::pass_signals)
4926         (remote_target::program_signals): Adjust.
4927         * target-debug.h (target_debug_print_signals): Now takes a
4928         gdb::array_view as parameter.  Adjust.
4929         * target.h (target_ops) <pass_signals, program_signals>: Replace
4930         pointer and length parameters with gdb::array_view.
4931         (target_pass_signals, target_program_signals): Likewise.
4932         * target-delegates.c: Regenerate.
4933
4934 2019-01-24  Pedro Alves  <palves@redhat.com>
4935
4936         * common/forward-scope-exit.h
4937         (forward_scope_exit::forward_scope_exit): Pass arguments to
4938         m_bind_function directly, instead of creating a std::bind and
4939         copying that.
4940
4941 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
4942
4943         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4944         for static members.
4945         (pass_in_v_vfp_candidate): Likewise.
4946
4947 2019-01-23  Tom Tromey  <tom@tromey.com>
4948             Pedro Alves  <palves@redhat.com>
4949
4950         * regcache.c (class regcache_invalidator): Remove.
4951         (regcache::raw_write): Use make_scope_exit.
4952
4953 2019-01-23  Tom Tromey  <tom@tromey.com>
4954
4955         * ui-out.h (class ui_out_emit_type): Update comment.
4956
4957 2019-01-23  Tom Tromey  <tom@tromey.com>
4958
4959         * infrun.c (fetch_inferior_event): Update comment.
4960
4961 2019-01-23  Tom Tromey  <tom@tromey.com>
4962             Pedro Alves  <palves@redhat.com>
4963
4964         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
4965         parameter.
4966         (fetch_inferior_event): Use SCOPE_EXIT.
4967
4968
4969 2019-01-23  Tom Tromey  <tom@tromey.com>
4970             Pedro Alves  <palves@redhat.com>
4971
4972         * infrun.c (disable_thread_events): Delete.
4973         (stop_all_threads): Use SCOPE_EXIT.
4974
4975 2019-01-23  Tom Tromey  <tom@tromey.com>
4976             Pedro Alves  <palves@redhat.com>
4977
4978         * symfile.c: Include forward-scope-exit.h.
4979         (clear_symtab_users_cleanup): Replace forward declaration with
4980         a FORWARD_SCOPE_EXIT.
4981         (syms_from_objfile_1): Use the forward_scope_exit and
4982         gdb::optional instead of cleanup_function.
4983         (reread_symbols): Use the forward_scope_exit instead of
4984         cleanup_function.
4985         (clear_symtab_users_cleanup): Remove function.
4986
4987 2019-01-23  Tom Tromey  <tom@tromey.com>
4988             Pedro Alves  <palves@redhat.com>
4989
4990         * linux-nat.c: Include scope-exit.h.
4991         (cleanup_target_stop): Remove.
4992         (linux_nat_target::static_tracepoint_markers_by_strid): Use
4993         SCOPE_EXIT.
4994
4995 2019-01-23  Tom Tromey  <tom@tromey.com>
4996             Pedro Alves  <palves@redhat.com>
4997
4998         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
4999         (call_function_by_hand_dummy): Use SCOPE_EXIT.
5000
5001 2019-01-23  Tom Tromey  <tom@tromey.com>
5002             Andrew Burgess  <andrew.burgess@embecosm.com>
5003             Pedro Alves  <palves@redhat.com>
5004
5005         * infrun.c (fetch_inferior_event): Use scope_exit.
5006         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
5007         * top.c (execute_command): Use scope_exit.
5008         * breakpoint.c (bpstat_do_actions): Use scope_exit.
5009         * utils.c (do_bpstat_clear_actions_cleanup)
5010         (make_bpstat_clear_actions_cleanup): Remove.
5011
5012 2019-01-23  Tom Tromey  <tom@tromey.com>
5013             Pedro Alves  <palves@redhat.com>
5014
5015         * infrun.c: Include "common/scope-exit.h"
5016         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
5017         (wait_for_inferior): Use SCOPE_EXIT.
5018         (fetch_inferior_event): Use scope_exit.
5019
5020 2019-01-23  Tom Tromey  <tom@tromey.com>
5021             Pedro Alves  <palves@redhat.com>
5022
5023         * breakpoint.c (create_breakpoint): Remove cleanup.
5024
5025 2019-01-23  Tom Tromey  <tom@tromey.com>
5026             Andrew Burgess  <andrew.burgess@embecosm.com>
5027             Pedro Alves  <palves@redhat.com>
5028
5029 2019-01-23  Pedro Alves  <palves@redhat.com>
5030
5031         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
5032
5033 2019-01-23  Pedro Alves  <palves@redhat.com>
5034             Andrew Burgess  <andrew.burgess@embecosm.com>
5035
5036         * gdbthread.h: Include "common/forward-scope-exit.h".
5037         (scoped_finish_thread_state): Redefine custom class in terms of
5038         forward_scope_exit.
5039
5040 2019-01-23  Pedro Alves  <palves@redhat.com>
5041             Andrew Burgess  <andrew.burgess@embecosm.com>
5042
5043         * common/forward-scope-exit.h: New file.
5044
5045 2019-01-23  Pedro Alves  <palves@redhat.com>
5046             Andrew Burgess  <andrew.burgess@embecosm.com>
5047             Tom Tromey  <tom@tromey.com>
5048
5049         * common/scope-exit.h: New file.
5050
5051 2019-01-23  Pedro Alves  <palves@redhat.com>
5052
5053         * common/preprocessor.h (ESC): Rename to ...
5054         (ESC_PARENS): ... this.
5055         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
5056         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
5057
5058 2019-01-23  Tom Tromey  <tom@tromey.com>
5059
5060         * language.h (class scoped_switch_to_sym_language_if_auto):
5061         Initialize m_lang in both cases.
5062
5063 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
5064
5065         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
5066         with XCNEW.
5067
5068 2019-01-22  Tom Tromey  <tom@tromey.com>
5069
5070         * corelow.c: Do not include sys/file.h.
5071
5072 2019-01-22  Tom Tromey  <tom@tromey.com>
5073
5074         * tui/tui-wingeneral.h: Include gdb_curses.h.
5075
5076 2019-01-22  Tom Tromey  <tom@tromey.com>
5077
5078         * source-cache.h (class source_cache) <get_source_lines,
5079         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
5080
5081 2019-01-22  Tom Tromey  <tom@tromey.com>
5082
5083         * remote-fileio.h (struct remote_target): Declare.
5084
5085 2019-01-22  Tom Tromey  <tom@tromey.com>
5086
5087         * python/py-arch.c: Do not include py-ref.h.
5088         * python/py-bpevent.c: Do not include py-ref.h.
5089         * python/py-cmd.c: Do not include py-ref.h.
5090         * python/py-continueevent.c: Do not include py-ref.h.
5091         * python/py-event.h: Do not include py-ref.h.
5092         * python/py-evtregistry.c: Do not include py-ref.h.
5093         * python/py-finishbreakpoint.c: Do not include py-ref.h.
5094         * python/py-frame.c: Do not include py-ref.h.
5095         * python/py-framefilter.c: Do not include py-ref.h.
5096         * python/py-function.c: Do not include py-ref.h.
5097         * python/py-infevents.c: Do not include py-ref.h.
5098         * python/py-linetable.c: Do not include py-ref.h.
5099         * python/py-objfile.c: Do not include py-ref.h.
5100         * python/py-param.c: Do not include py-ref.h.
5101         * python/py-prettyprint.c: Do not include py-ref.h.
5102         * python/py-progspace.c: Do not include py-ref.h.
5103         * python/py-symbol.c: Do not include py-ref.h.
5104         * python/py-symtab.c: Do not include py-ref.h.
5105         * python/py-type.c: Do not include py-ref.h.
5106         * python/py-unwind.c: Do not include py-ref.h.
5107         * python/py-utils.c: Do not include py-ref.h.
5108         * python/py-value.c: Do not include py-ref.h.
5109         * python/py-varobj.c: Do not include py-ref.h.
5110         * python/py-xmethods.c: Do not include py-ref.h.
5111         * python/python.c: Do not include py-ref.h.
5112         * varobj.c: Do not include py-ref.h.
5113
5114 2019-01-22  Tom Tromey  <tom@tromey.com>
5115
5116         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
5117         keyword for bcache.
5118
5119 2019-01-22  Tom Tromey  <tom@tromey.com>
5120
5121         * compile/compile-cplus-types.c: Remove a comment by #include.
5122
5123 2019-01-22  Tom Tromey  <tom@tromey.com>
5124
5125         * compile/gcc-c-plugin.h: Include compile-internal.h.
5126
5127 2019-01-22  Tom Tromey  <tom@tromey.com>
5128
5129         * stabsread.c (EXTERN): Do not define.
5130         (symnum, next_symbol_text_func, processing_gcc_compilation)
5131         (within_function, global_sym_chain, global_stabs)
5132         (previous_stab_code, this_object_header_files)
5133         (n_this_object_header_files)
5134         (n_allocated_this_object_header_files): Define.
5135         * stabsread.h (EXTERN): Never define.  Use "extern".
5136
5137 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5138
5139         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5140         history_value.
5141
5142 2019-01-21  Tom Tromey  <tom@tromey.com>
5143
5144         * ui-out.c: Fix includes.
5145         * tui/tui-source.c: Fix includes.
5146         * target.c: Fix includes.
5147         * remote.c: Fix includes.
5148         * regcache.c: Fix includes.
5149         * python/py-block.c: Fix includes.
5150         * printcmd.c: Fix includes.
5151         * or1k-tdep.c: Fix includes.
5152         * mi/mi-main.c: Fix includes.
5153         * m32r-tdep.c: Fix includes.
5154         * csky-tdep.c: Fix includes.
5155         * compile/compile-cplus-types.c: Fix includes.
5156         * cli/cli-interp.c: Fix includes.
5157
5158 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5159
5160         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5161         for padding.
5162
5163 2019-01-16  Tom Tromey  <tom@tromey.com>
5164
5165         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5166         earlier.
5167         (struct objfile) <msymbols_range>: Move from top level.
5168         <msymbols>: New method.
5169         (class objfile_msymbols): Remove.
5170         * symtab.c (default_collect_symbol_completion_matches_break_on):
5171         Update.
5172         * symmisc.c (dump_msymbols): Update.
5173         * stabsread.c (scan_file_globals): Update.
5174         * objc-lang.c (info_selectors_command, info_classes_command)
5175         (find_methods): Update.
5176         * minsyms.c (find_solib_trampoline_target): Update.
5177         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5178         * coffread.c (coff_symfile_read): Update.
5179         * ada-lang.c (ada_lookup_simple_minsym)
5180         (ada_collect_symbol_completion_matches): Update.
5181
5182 2019-01-16  Tom Tromey  <tom@tromey.com>
5183
5184         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5185         type.  Remove no-argument constructor.
5186         <iterator::operator++>: Simplify.
5187         <begin>: Update.
5188         <end>: Use minimal_symbol_count.
5189
5190 2019-01-16  Tom Tromey  <tom@tromey.com>
5191
5192         * objfiles.h (struct objfile) <psymtabs>: New method.
5193         (class objfile_psymtabs): Remove.
5194         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5195         typedef.
5196         <range>: New method.
5197         (require_partial_symbols): Change return type.
5198         * psymtab.c (require_partial_symbols)
5199         (psym_expand_symtabs_matching): Update.
5200         * mdebugread.c (parse_partial_symbols): Update.
5201         * dbxread.c (dbx_end_psymtab): Update.
5202
5203 2019-01-15  Tom Tromey  <tom@tromey.com>
5204
5205         * symtab.c (lookup_objfile_from_block)
5206         (lookup_symbol_in_objfile_symtabs)
5207         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5208         (find_line_symtab, info_sources_command)
5209         (default_collect_symbol_completion_matches_break_on)
5210         (make_source_files_completion_list): Update.
5211         * symmisc.c (print_objfile_statistics, dump_objfile)
5212         (maintenance_print_symbols, maintenance_info_symtabs)
5213         (maintenance_check_symtabs, maintenance_info_line_tables):
5214         Update.
5215         * source.c (select_source_symtab)
5216         (forget_cached_source_info_for_objfile): Update.
5217         * objfiles.h (class objfile_compunits): Remove.
5218         (struct objfile) <compunits_range>: New typedef.
5219         (compunits): New method.
5220         * objfiles.c (objfile_relocate1): Update.
5221         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5222         * maint.c (count_symtabs_and_blocks): Update.
5223         * linespec.c (iterate_over_all_matching_symtabs): Update.
5224         * cp-support.c (add_symbol_overload_list_qualified): Update.
5225         * coffread.c (coff_symtab_read): Update.
5226         * ada-lang.c (add_nonlocal_symbols)
5227         (ada_collect_symbol_completion_matches)
5228         (ada_add_global_exceptions): Update.
5229
5230 2019-01-15  Tom Tromey  <tom@tromey.com>
5231
5232         * progspace.h (program_space) <objfiles_safe_range>: New
5233         typedef.
5234         <objfiles_safe>: New method.
5235         * objfiles.h (class all_objfiles_safe): Remove.
5236         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5237         * jit.c (jit_inferior_exit_hook): Update.
5238
5239 2019-01-17  Tom Tromey  <tom@tromey.com>
5240
5241         * progspace.h (program_space) <objfiles_range>: New typedef.
5242         <objfiles>: New method.
5243         <objfiles_head>: Rename from objfiles.
5244         (object_files): Update.
5245         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5246         * guile/scm-pretty-print.c
5247         (ppscm_find_pretty_printer_from_objfiles): Update.
5248         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5249         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5250         Update.
5251         * python/py-progspace.c (pspy_get_objfiles): Update.
5252         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5253         Update.
5254         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5255         (objfpy_lookup_objfile_by_build_id): Update.
5256         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5257         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5258         Update.
5259         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5260         (expand_symtab_containing_pc, lookup_objfile_from_block)
5261         (lookup_static_symbol, basic_lookup_transparent_type)
5262         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5263         (find_line_symtab, info_sources_command)
5264         (default_collect_symbol_completion_matches_break_on)
5265         (make_source_files_completion_list, find_main_name): Update.
5266         * symmisc.c (print_symbol_bcache_statistics)
5267         (print_objfile_statistics, maintenance_print_symbols)
5268         (maintenance_print_msymbols, maintenance_print_objfiles)
5269         (maintenance_info_symtabs, maintenance_check_symtabs)
5270         (maintenance_expand_symtabs, maintenance_info_line_tables):
5271         Update.
5272         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5273         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5274         (map_overlay_command, unmap_overlay_command)
5275         (simple_overlay_update, expand_symtabs_matching)
5276         (map_symbol_filenames): Update.
5277         * symfile-debug.c (set_debug_symfile): Update.
5278         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5279         Update.
5280         * source.c (select_source_symtab, forget_cached_source_info):
5281         Update.
5282         * solib.c (solib_read_symbols): Update.
5283         * solib-spu.c (append_ocl_sos): Update.
5284         * psymtab.c (maintenance_print_psymbols)
5285         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5286         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5287         * printcmd.c (info_symbol_command): Update.
5288         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5289         Update.
5290         * objfiles.h (class all_objfiles): Remove.
5291         * objfiles.c (have_partial_symbols, have_full_symbols)
5292         (have_minimal_symbols, qsort_cmp, update_section_map)
5293         (shared_objfile_contains_address_p)
5294         (default_iterate_over_objfiles_in_search_order): Update.
5295         * objc-lang.c (info_selectors_command, info_classes_command)
5296         (find_methods): Update.
5297         * minsyms.c (find_solib_trampoline_target): Update.
5298         * maint.c (maintenance_info_sections)
5299         (maintenance_translate_address, count_symtabs_and_blocks):
5300         Update.
5301         * main.c (captured_main_1): Update.
5302         * linux-thread-db.c (try_thread_db_load_from_pdir)
5303         (has_libpthread): Update.
5304         * linespec.c (iterate_over_all_matching_symtabs)
5305         (search_minsyms_for_name): Update.
5306         * jit.c (jit_find_objf_with_entry_addr): Update.
5307         * hppa-tdep.c (find_unwind_entry)
5308         (hppa_lookup_stub_minimal_symbol): Update.
5309         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5310         Update.
5311         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5312         (elf_gnu_ifunc_resolve_by_got): Update.
5313         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5314         * dwarf-index-write.c (save_gdb_index_command): Update.
5315         * cp-support.c (add_symbol_overload_list_qualified): Update.
5316         * breakpoint.c (create_overlay_event_breakpoint)
5317         (create_longjmp_master_breakpoint)
5318         (create_std_terminate_master_breakpoint)
5319         (create_exception_master_breakpoint): Update.
5320         * blockframe.c (find_pc_partial_function): Update.
5321         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5322         (ada_collect_symbol_completion_matches)
5323         (ada_add_global_exceptions): Update.
5324
5325 2019-01-17  Tom Tromey  <tom@tromey.com>
5326
5327         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5328         declare VEC.
5329         (solib_target_parse_libraries): Change return type.
5330         (library_list_start_segment, library_list_start_section)
5331         (library_list_end_library, library_list_start_library); Update.
5332         (solib_target_free_library_list): Remove.
5333         (solib_target_parse_libraries): Remove cleanup.  Change return
5334         type.
5335         (solib_target_current_sos): Update.
5336
5337 2019-01-17  Tom Tromey  <tromey@bapiya>
5338
5339         * valprint.c: Replace "the the" with "the".
5340         * symtab.c: Replace "the the" with "the".
5341         * solib.c: Replace "the the" with "the".
5342         * solib-dsbt.c: Replace "the the" with "the".
5343         * linespec.c: Replace "the the" with "the".
5344         * dwarf2loc.h: Replace "the the" with "the".
5345         * amd64-windows-tdep.c: Replace "the the" with "the".
5346         * aarch64-tdep.c: Replace "the the" with "the".
5347
5348 2019-01-16  Keith Seitz  <keiths@redhat.com>
5349
5350         PR gdb/23773
5351         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5352         <builder>: Rename to ..
5353         <m_builder>: ... this and make private.
5354         (dwarf2_cu::get_builder): New method.  Change all users of
5355         `builder' to use this method.
5356         (dwarf2_start_symtab): Move to ...
5357         (dwarf2_cu::start_symtab): ... here.  Update all callers
5358         (setup_type_unit_groups): Move to ...
5359         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5360         callers.
5361         (dwarf2_cu::reset_builder): New method.
5362         (process_full_compunit, process_full_type_unit): Use
5363         dwarf2_cu::reset_builder.
5364         (follow_die_offset): Record the ancestor CU if it is different
5365         from the followed DIE's CU.
5366         (follow_die_sig_1): Likewise.
5367
5368 2019-01-15  Tom Tromey  <tom@tromey.com>
5369
5370         * remote.c (class remote_state) <buf>: Now a char_vector.
5371         <buf_size>: Remove.
5372         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
5373         parameter.
5374         (remote_target::getpkt_or_notif_sane_1)
5375         (remote_target::getpkt_sane)
5376         (remote_target::getpkt_or_notif_sane): Likewise.
5377         (class remote_target) <putpkt>: New overload.
5378         (remote_target::read_frame): Change type of "buf_p".  Remove
5379         sizeof_p parameter.
5380         (packet_ok): New overload.
5381         (packet_check_result): New overload.
5382         Update all uses.
5383
5384 2019-01-14  Tom Tromey  <tom@tromey.com>
5385
5386         * remote-notif.c (handle_notification, remote_notif_ack)
5387         (remote_notif_parse): Make "buf" const.
5388         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
5389         const.
5390         (remote_notif_parse, remote_notif_ack, handle_notification):
5391         Likewise.
5392         * remote.c (remote_notif_stop_parse): Make "buf" const.
5393         (remote_target::remote_parse_stop_reply): Make "buf" const.
5394         (remote_notif_stop_ack): Make "buf" const.
5395
5396 2019-01-14  Tom Tromey  <tom@tromey.com>
5397
5398         * remote.c (remote_console_output): Make parameter const.
5399
5400 2019-01-14  Tom Tromey  <tom@tromey.com>
5401
5402         * target-debug.h (target_debug_print_signals): Constify.
5403         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
5404         * procfs.c (procfs_target::pass_signals): Update.
5405         * linux-nat.c (linux_nat_target::pass_signals): Update.
5406         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
5407         * target-delegates.c: Rebuild.
5408         * remote.c (remote_target::program_signals): Update.
5409         (remote_target::pass_signals): Update.
5410         * target.c (target_pass_signals): Constify argument.
5411         (target_program_signals): Likewise.
5412         * target.h (struct target_ops) <pass_signals, program_signals>:
5413         Constify argument.
5414         (target_pass_signals, target_program_signals): Constify argument.
5415
5416 2019-01-14  Tom Tromey  <tom@tromey.com>
5417
5418         PR tui/28819:
5419         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
5420
5421 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5422
5423         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
5424         field.
5425         * rs6000-tdep.c: Include reggroups.h.
5426         (IS_V_ALIAS_PSEUDOREG): Define.
5427         (rs6000_register_name): Return names for the "vX" aliases.
5428         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
5429         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
5430         aliases.  Call default_register_reggroup_p for all other
5431         pseudo-registers.
5432         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
5433         New functions.
5434         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
5435         Handle "vX" aliases.
5436         (v_alias_pseudo_register_collect): New function.
5437         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
5438         (rs6000_gdbarch_init): Initialize "vX" aliases as
5439         pseudo-registers.  Restore registration of
5440         rs6000_pseudo_register_reggroup_p with
5441         set_tdesc_pseudo_register_reggroup_p.
5442
5443 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
5444
5445         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
5446         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
5447         set_gdbarch_num_pseudo_regs.
5448
5449 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5450
5451         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
5452         Remove arg prefixname, add do_set and do_show.
5453         Add member functions set_list and show_list.
5454         * cli/cli-style.c (class cli_style_option): Update accordingly.
5455         (style_set_list): Move to file scope.
5456         (style_show_list): Likewise.
5457         (set_style): Call help_list.
5458         (show_style): Call cmd_show_list.
5459         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
5460         Update to use the new macro.
5461
5462 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
5463
5464         * ada-lang.c (_initialize_ada_language): Expand the help text
5465         for the "catch exception" command.
5466
5467 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5468
5469         * symtab.c (matching_obj_sections): Initialize obj,
5470         declare it closer to its usage.
5471
5472 2019-01-10  Tom Tromey  <tom@tromey.com>
5473
5474         * thread-iter.h (inf_threads_iterator): Use next_iterator.
5475         (basic_inf_threads_range): Remove.
5476         (inf_threads_range, inf_non_exited_threads_range)
5477         (safe_inf_threads_range): Use next_adapter.
5478
5479 2019-01-10  Keith Seitz  <keiths@redhat.com>
5480
5481         PR gdb/23712
5482         PR symtab/23010
5483         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
5484         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
5485
5486 2019-01-10  Keith Seitz  <keiths@redhat.com>
5487
5488         PR gdb/23712
5489         PR symtab/23010
5490         * dictionary.c (pending_to_vector): Remove.
5491         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5492         Remove _1 suffix, replacing functions of the same name.  Update
5493         all callers.
5494         (dict_create_hashed, dict_create_hashed_expandable)
5495         (dict_create_linear, dict_create_linear_expandable, dict_free)
5496         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
5497         Make functions static.
5498
5499 2019-01-10  Keith Seitz  <keiths@redhat.com>
5500
5501         PR gdb/23712
5502         PR symtab/23010
5503         * dictionary.h (struct dictionary): Replace declaration with
5504         multidictionary.
5505         (dict_create_hashed, dict_create_hashed_expandable)
5506         (dict_create_linear, dict_create_linear_expandable)
5507         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
5508         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
5509         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
5510         taking multidictionary argument.
5511         [ALL_DICT_SYMBOLS]: Update for multidictionary.
5512         * block.h (struct block) <dict>: Change to multidictionary
5513         and rename `multidict'.
5514         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
5515         symmisc.c: Update all dictionary references to multidictionary.
5516
5517 2019-01-10  Keith Seitz  <keiths@redhat.com>
5518
5519         PR gdb/23712
5520         PR symtab/23010
5521         * dictionary.c: Include unordered_map.
5522         (pending_to_vector): New function.
5523         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5524         Rewrite the non-"_1" functions to take vector instead
5525         of linked list.
5526         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
5527         "new" _1 versions of the same name.
5528         (multidictionary): Define.
5529         (std::hash<enum language): New definition.
5530         (collate_pending_symbols_by_language, mdict_create_hashed)
5531         (mdict_create_hashed_expandable, mdict_create_linear)
5532         (mdict_create_linear_expandable, mdict_free)
5533         (find_language_dictionary, create_new_language_dictionary)
5534         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
5535         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
5536         (mdict_size, mdict_empty): New functions.
5537         * dictionary.h (mdict_iterator): Define.
5538
5539 2019-01-10  Pedro Alves  <palves@redhat.com>
5540
5541         * breakpoint.c (read_uploaded_action)
5542         (create_tracepoint_from_upload): Adjust to use
5543         gdb::unique_xmalloc_ptr.
5544         * ctf.c (ctf_write_uploaded_tp):
5545         (SET_ARRAY_FIELD): Use emplace_back.
5546         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
5547         * tracefile-tfile.c (tfile_write_uploaded_tp):
5548         * tracepoint.c (parse_tracepoint_definition): Adjust to use
5549         gdb::unique_xmalloc_ptr.
5550         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
5551         at_string, cond_string, cmd_strings>: Replace char pointers
5552         with gdb::unique_xmalloc_ptr.
5553
5554 2019-01-10  Pedro Alves  <palves@redhat.com>
5555
5556         * solib-target.c (library_list_start_library): Don't xstrdup name.
5557
5558 2019-01-10  Pedro Alves  <palves@redhat.com>
5559
5560         * mdebugread.c (parse_partial_symbols): Use
5561         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
5562
5563 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5564
5565         * linux-fork.c (scoped_switch_fork_info)
5566         <~scoped_switch_fork_info>: Fix incorrect variable name.
5567
5568 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5569
5570         * linux-fork.c (scoped_switch_fork_info)
5571         <scoped_switch_fork_info>: Make explicit.
5572         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
5573
5574 2019-01-10  Tom Tromey  <tom@tromey.com>
5575
5576         * objfiles.h (objfile::reset_psymtabs): Update.
5577         * objfiles.c (objfile::objfile): Update.
5578         * psymtab.h (psymtab_storage::obstack): Update.
5579         (psymtab_storage::m_obstack): Use gdb::optional.
5580         (class psymtab_storage): Update comment.  Remove objfile
5581         parameter.
5582         * psymtab.c (psymtab_storage::psymtab_storage): Update.
5583
5584 2019-01-10  Tom Tromey  <tom@tromey.com>
5585
5586         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
5587         <free_psymtabs>: Now private.
5588         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
5589         (allocate_psymtab): Use new method.
5590
5591 2019-01-10  Tom Tromey  <tom@tromey.com>
5592
5593         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
5594         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
5595         * mdebugread.c (parse_partial_symbols): Use
5596         allocate_dependencies.
5597         * dwarf2read.c (dwarf2_create_include_psymtab): Use
5598         allocate_dependencies.
5599         (process_psymtab_comp_unit_reader)
5600         (build_type_psymtab_dependencies): Likewise.
5601         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
5602
5603 2019-01-10  Tom Tromey  <tom@tromey.com>
5604
5605         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
5606         PSYMBOL_SET_LANGUAGE.
5607         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
5608
5609 2019-01-10  Tom Tromey  <tom@tromey.com>
5610
5611         * psymtab.h (psymtab_storage::obstack): New method.
5612         <m_obstack>: Rename from obstack; now private.
5613         * psymtab.c (psymtab_storage): Update.
5614         * dwarf2read.c (create_addrmap_from_index)
5615         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
5616         Update.
5617
5618 2019-01-10  Tom Tromey  <tom@tromey.com>
5619
5620         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
5621         * objfiles.h (objfile::reset_psymtabs): New method.
5622
5623 2019-01-10  Tom Tromey  <tom@tromey.com>
5624
5625         * symmisc.c (print_symbol_bcache_statistics): Update.
5626         (print_objfile_statistics): Update.
5627         * symfile.c (reread_symbols): Update.
5628         * psymtab.h (class psymtab_storage): New.
5629         * psymtab.c (psymtab_storage): New constructor.
5630         (~psymtab_storage): New destructor.
5631         (require_partial_symbols): Update.
5632         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
5633         (find_pc_sect_psymtab, find_pc_sect_psymbol)
5634         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
5635         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
5636         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
5637         (start_psymtab_common, end_psymtab_common)
5638         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
5639         (allocate_psymtab): Update.
5640         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
5641         Update.
5642         (dump_psymtab_addrmap, maintenance_print_psymbols)
5643         (maintenance_check_psymtabs): Update.
5644         (class objfile_psymtabs): Move to objfiles.h.
5645         * psympriv.h (discard_psymtab): Now inline.
5646         (psymtab_discarder::psymtab_discarder): Update.
5647         (psymtab_discarder::~psymtab_discarder): Update.
5648         (ALL_OBJFILE_PSYMTABS): Rewrite.
5649         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
5650         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
5651         Remove fields.
5652         <partial_symtabs>: New field.
5653         (class objfile_psymtabs): Move from psymtab.h.  Update.
5654         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
5655         psymbol_cache.
5656         (objfile::~objfile): Don't destroy psymbol_cache.
5657         * mdebugread.c (parse_partial_symbols): Update.
5658         * dwarf2read.c (create_addrmap_from_index)
5659         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
5660         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
5661         (add_partial_subprogram, dwarf2_ranges_read): Update.
5662         * dwarf-index-write.c (write_address_map)
5663         (write_one_signatured_type, recursively_write_psymbols)
5664         (class debug_names, class debug_names, write_psymtabs_to_index):
5665         Update.
5666
5667 2019-01-10  Tom Tromey  <tom@tromey.com>
5668
5669         * symtab.h (SYMBOL_SET_NAMES): Update.
5670         (symbol_set_names): Update.
5671         (MSYMBOL_SET_NAMES): Update.
5672         * symtab.c (symbol_set_names): Change argument to be an
5673         objfile_per_bfd_storage.
5674         * psymtab.c (add_psymbol_to_bcache): Update.
5675         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
5676
5677 2019-01-10  Tom Tromey  <tom@tromey.com>
5678
5679         * symtab.c (create_demangled_names_hash): Change argument to be an
5680         objfile_per_bfd_storage.
5681         (symbol_set_names): Update.
5682
5683 2019-01-10  Tom Tromey  <tom@tromey.com>
5684
5685         * xcoffread.c (xcoff_initial_scan): Unconditionally call
5686         init_psymbol_list.
5687         * psymtab.c (init_psymbol_list): Do nothing if already called.
5688         * psympriv.h (init_psymbol_list): Add comment.
5689         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
5690         init_psymbol_list.
5691         * dbxread.c (dbx_symfile_read): Unconditionally call
5692         init_psymbol_list.
5693
5694 2019-01-10  Tom Tromey  <tom@tromey.com>
5695
5696         * xcoffread.c (scan_xcoff_symtab): Update.
5697         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
5698         "where".
5699         * mdebugread.c (parse_partial_symbols)
5700         (handle_psymbol_enumerators): Update.
5701         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
5702         * dbxread.c (read_dbx_symtab): Update.
5703         * psympriv.h (psymbol_placement): New enum.
5704         (add_psymbol_to_list): Update.
5705
5706 2019-01-10  Tom Tromey  <tom@tromey.com>
5707
5708         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
5709         static_psymbols parameters.
5710         (scan_xcoff_symtab): Update.
5711         * psymtab.c (start_psymtab_common): Remove global_psymbols and
5712         static_psymbols parameters.
5713         * psympriv.h (start_psymtab_common): Update.
5714         * mdebugread.c (parse_partial_symbols): Update.
5715         * dwarf2read.c (create_partial_symtab): Update.
5716         * dbxread.c (read_dbx_symtab): Update.
5717         (start_psymtab): Remove global_psymbols and static_psymbols
5718         parameters.
5719
5720 2019-01-10  Tom Tromey  <tom@tromey.com>
5721
5722         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
5723         * psymtab.c (allocate_psymtab): Add comment.
5724         * psympriv.h (allocate_psymtab): Add comment.
5725         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
5726         initializations.
5727         * dbxread.c (dbx_end_psymtab): Remove some initializations.
5728
5729 2019-01-10  Tom Tromey  <tom@tromey.com>
5730
5731         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5732         Don't declare.
5733         * mipsread.c: Include mdebugread.h.
5734         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5735         Declare.
5736         * elfread.c: Include mdebugread.h.
5737
5738 2019-01-09  Tom Tromey  <tom@tromey.com>
5739
5740         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
5741         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
5742         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
5743         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
5744         (psym_lookup_symbol, psym_find_last_source_symtab)
5745         (psym_forget_cached_source_info, psym_print_stats)
5746         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
5747         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
5748         (psym_map_matching_symbols, psym_expand_symtabs_matching)
5749         (psym_find_compunit_symtab_by_address)
5750         (maintenance_print_psymbols, maintenance_info_psymtabs)
5751         (maintenance_check_psymtabs): Use ranged for.
5752         * psymtab.h (class objfile_psymtabs): New.
5753         (require_partial_symbols): Return objfile_psymtabs.
5754         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
5755
5756 2019-01-09  Tom Tromey  <tom@tromey.com>
5757
5758         * symfile.c (overlay_invalidate_all, find_pc_overlay)
5759         (find_pc_mapped_section, list_overlays_command)
5760         (map_overlay_command, unmap_overlay_command)
5761         (simple_overlay_update): Use all_objfiles.
5762         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
5763         * printcmd.c (info_symbol_command): Use all_objfiles.
5764         * objfiles.h (ALL_OBJSECTIONS): Remove.
5765         * maint.c (maintenance_translate_address): Use all_objfiles.
5766         * gcore.c (gcore_create_callback): Use all_objfiles.
5767         (objfile_find_memory_regions): Likewise.
5768
5769 2019-01-09  Tom Tromey  <tom@tromey.com>
5770
5771         * symtab.c (find_line_symtab, info_sources_command)
5772         (make_source_files_completion_list): Use objfile_compunits.
5773         * source.c (select_source_symtab): Use objfile_compunits.
5774         * objfiles.h (struct objfile): Update comment.
5775         (ALL_OBJFILES): Remove.
5776         (ALL_FILETABS): Remove.
5777         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
5778         objfile_compunits.
5779
5780 2019-01-09  Tom Tromey  <tom@tromey.com>
5781
5782         * symmisc.c (print_objfile_statistics, dump_objfile)
5783         (maintenance_print_symbols): Use compunit_filetabs.
5784         * source.c (forget_cached_source_info_for_objfile): Use
5785         compunit_filetabs.
5786         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
5787         (ALL_FILETABS): Use compunit_filetabs.
5788         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
5789         * coffread.c (coff_symtab_read): Use compunit_filetabs.
5790
5791 2019-01-09  Tom Tromey  <tom@tromey.com>
5792
5793         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
5794         (compunit_filetabs): New.
5795         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
5796         compunit_filetabs.
5797         (info_sources_command, make_source_files_completion_list): Remove
5798         declaration.
5799         * symmisc.c (print_objfile_statistics, dump_objfile)
5800         (maintenance_print_symbols): Remove declaration.
5801         (maintenance_info_symtabs): Use compunit_filetabs.
5802         (maintenance_info_line_tables): Likewise.
5803         * source.c (select_source_symtab): Change local variable name.
5804         (forget_cached_source_info_for_objfile): Remove declaration.
5805         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
5806         * objfiles.c (objfile_relocate1): Remove declaration.
5807         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5808         declaration.
5809         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
5810         * coffread.c (coff_symtab_read): Remove declaration.
5811         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5812         compunit_filetabs.
5813
5814 2019-01-09  Tom Tromey  <tom@tromey.com>
5815
5816         * symtab.c (lookup_objfile_from_block)
5817         (find_pc_sect_compunit_symtab, search_symbols)
5818         (default_collect_symbol_completion_matches_break_on): Use
5819         objfile_compunits.
5820         * objfiles.h (ALL_COMPUNITS): Remove.
5821         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
5822         * cp-support.c (add_symbol_overload_list_qualified): Use
5823         objfile_compunits.
5824         * ada-lang.c (ada_collect_symbol_completion_matches)
5825         (ada_add_global_exceptions): Use objfile_compunits.
5826
5827 2019-01-09  Tom Tromey  <tom@tromey.com>
5828
5829         * source.c (select_source_symtab)
5830         (forget_cached_source_info_for_objfile): Remove declaration.
5831         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5832         declaration.
5833         * maint.c (count_symtabs_and_blocks): Remove declaration.
5834         * cp-support.c (add_symbol_overload_list_qualified): Remove
5835         declaration.
5836         * coffread.c (coff_symtab_read): Remove declaration.
5837         * symtab.c (lookup_symbol_in_objfile_symtabs)
5838         (basic_lookup_transparent_type_1): Use objfile_compunits.
5839         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
5840         (info_sources_command, search_symbols)
5841         (default_collect_symbol_completion_matches_break_on)
5842         (make_source_files_completion_list): Remove declaration.
5843         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
5844         (ada_collect_symbol_completion_matches)
5845         (ada_add_global_exceptions): Remove declaration.
5846         * linespec.c (iterate_over_all_matching_symtabs): Use
5847         objfile_compunits.
5848         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
5849         (class objfile_compunits): New.
5850         (ALL_COMPUNITS): Use objfile_compunits.
5851         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
5852         (maintenance_check_symtabs, maintenance_info_line_tables): Use
5853         objfile_compunits.
5854         * objfiles.c (objfile_relocate1): Use objfile_compunits.
5855
5856 2019-01-09  Tom Tromey  <tom@tromey.com>
5857
5858         * symtab.c (search_symbols)
5859         (default_collect_symbol_completion_matches_break_on): Use
5860         objfile_msymbols.
5861         * ada-lang.c (ada_lookup_simple_minsym)
5862         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
5863         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
5864         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
5865         objfile_msymbols.
5866         * coffread.c (coff_symfile_read): Use objfile_msymbols.
5867         * symmisc.c (dump_msymbols): Use objfile_msymbols.
5868         * objc-lang.c (find_methods): Use objfile_msymbols.
5869         (info_selectors_command, info_classes_command): Likewise.
5870         * stabsread.c (scan_file_globals): Use objfile_msymbols.
5871         * objfiles.h (class objfile_msymbols): New.
5872         (ALL_OBJFILE_MSYMBOLS): Remove.
5873         (ALL_MSYMBOLS): Remove.
5874
5875 2019-01-09  Tom Tromey  <tom@tromey.com>
5876
5877         * common/next-iterator.h (next_adapter): Add Iterator template
5878         parameter.
5879         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
5880         (class all_objfiles_safe): New.
5881         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
5882         * objfiles.c (put_objfile_before): Update comment.
5883         (add_separate_debug_objfile): Likewise.
5884         (free_all_objfiles): Use all_objfiles_safe.
5885         (objfile_purge_solibs): Likewise.
5886
5887 2019-01-09  Tom Tromey  <tom@tromey.com>
5888
5889         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5890         (expand_symtab_containing_pc, lookup_static_symbol)
5891         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
5892         (find_symbol_at_address, find_line_symtab, find_main_name): Use
5893         all_objfiles.
5894         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
5895         * breakpoint.c (create_overlay_event_breakpoint)
5896         (create_longjmp_master_breakpoint)
5897         (create_std_terminate_master_breakpoint)
5898         (create_exception_master_breakpoint): Use all_objfiles.
5899         * linux-thread-db.c (try_thread_db_load_from_pdir)
5900         (has_libpthread): Use all_objfiles.
5901         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
5902         * linespec.c (iterate_over_all_matching_symtabs)
5903         (search_minsyms_for_name): Use all_objfiles.
5904         * maint.c (maintenance_info_sections): Use all_objfiles.
5905         * main.c (captured_main_1): Use all_objfiles.
5906         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
5907         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
5908         * guile/scm-pretty-print.c
5909         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
5910         * solib-spu.c (append_ocl_sos): Use all_objfiles.
5911         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
5912         (maintenance_print_msymbols): Use all_objfiles.
5913         * source.c (select_source_symtab): Use all_objfiles.
5914         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
5915         * symfile.c (remove_symbol_file_command)
5916         (expand_symtabs_matching, map_symbol_filenames): Use
5917         all_objfiles.
5918         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
5919         all_objfiles.
5920         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
5921         * objc-lang.c (find_methods): Use all_objfiles.
5922         * objfiles.c (have_partial_symbols, have_full_symbols)
5923         (have_minimal_symbols, qsort_cmp)
5924         (default_iterate_over_objfiles_in_search_order): Use
5925         all_objfiles.
5926         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
5927         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
5928         (maintenance_check_psymtabs): Use all_objfiles.
5929         (ALL_PSYMTABS): Remove.
5930         * compile/compile-object-run.c (do_module_cleanup): Use
5931         all_objfiles.
5932         * blockframe.c (find_pc_partial_function): Use all_objfiles.
5933         * cp-support.c (add_symbol_overload_list_qualified): Use
5934         all_objfiles.
5935         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5936         Use all_objfiles.
5937         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
5938         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
5939         all_objfiles.
5940         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5941         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
5942         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5943         Uses all_objfiles.
5944         * solib.c (solib_read_symbols): Use all_objfiles
5945
5946 2019-01-09  Tom Tromey  <tom@tromey.com>
5947
5948         * probe.c (parse_probes_in_pspace): Use all_objfiles.
5949         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
5950         all_objfiles.
5951         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
5952         * symmisc.c (print_symbol_bcache_statistics)
5953         (print_objfile_statistics, maintenance_print_objfiles)
5954         (maintenance_info_symtabs, maintenance_check_symtabs)
5955         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
5956         all_objfiles.
5957         * source.c (forget_cached_source_info): Use all_objfiles.
5958         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
5959         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5960         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
5961         * objfiles.c (update_section_map): Use all_objfiles.
5962         (shared_objfile_contains_address_p): Likewise.
5963         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
5964         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
5965
5966 2019-01-09  Tom Tromey  <tom@tromey.com>
5967
5968         * common/next-iterator.h: New file.
5969         * objfiles.h (class all_objfiles): New.
5970         (struct objfile_iterator): New.
5971
5972 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5973
5974         * NEWS: Move the description of the changed "frame", "select-frame",
5975          and "info frame" commands to the Changed commands section.
5976
5977 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
5978
5979         * gdbtypes.c (check_stub_method_group): Remove handling of old
5980         mangling schemes.
5981         * linespec.c (find_methods): Likewise.
5982         * stabsread.c (read_member_functions): Likewise.
5983         * valops.c (search_struct_method): Likewise.
5984         (value_struct_elt_for_reference): Likewise.
5985         * NEWS: Mention this change.
5986
5987 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5988
5989         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
5990         print_source_lines.
5991         * source.c (print_source_lines_base): Update line number check.
5992         (print_source_lines): New function.
5993         (source_lines_range::source_lines_range): New function.
5994         * source.h (class source_lines_range): New class.
5995         (print_source_lines): New declaration.
5996
5997 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5998
5999         * linespec.c (linespec_state_destructor): Free self->canonical_names.
6000
6001 2019-01-08  Tom Tromey  <tom@tromey.com>
6002             Simon Marchi  <simon.marchi@ericsson.com>
6003
6004         PR gdb/24060
6005         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
6006         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
6007         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6008         * f-exp.y (DOLLAR_VARIABLE): Likewise.
6009         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
6010         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6011
6012 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6013
6014         * source.c (select_source_symtab): Move header comment to
6015         declaration in source.h.
6016         (forget_cached_source_info_for_objfile): Likewise.
6017         (forget_cached_source_info): Likewise.
6018         (identify_source_line): Likewise.
6019         * source.h (identify_source_line): Move declaration from symtab.h
6020         and add comment from source.c
6021         (print_source_lines): Likewise.
6022         (forget_cached_source_info_for_objfile): Likewise.
6023         (forget_cached_source_info): Likewise.
6024         (select_source_symtab): Likewise.
6025         (enum print_source_lines_flag): Move definition from symtab.h.
6026         * symtab.h (identify_source_line): Move declaration to source.h.
6027         (print_source_lines): Likewise.
6028         (forget_cached_source_info_for_objfile): Likewise.
6029         (forget_cached_source_info): Likewise.
6030         (select_source_symtab): Likewise.
6031         (enum print_source_lines_flag): Move definition to source.h.
6032         * tui/tui-hooks.c: Add 'source.h' include.
6033
6034 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6035
6036         * source.c (print_source_lines_base): Handle requests to print
6037         reverse line number sequences, and guard against empty lines
6038         string.
6039
6040 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6041
6042         * source.c (print_source_lines_base): Fix skip of '\r' if next
6043         character is '\n'.
6044
6045 2019-01-06  Tom Tromey  <tom@tromey.com>
6046
6047         * c-exp.y (struct c_parse_state) <macro_original_text,
6048         expansion_obstack>: New member.
6049         (macro_original_text, expansion_obstack): Remove globals.
6050         (scan_macro_expansion, scanning_macro_expansion)
6051         (finished_macro_expansion): Update.
6052         (scan_macro_cleanup): Remove.
6053         (yylex, c_parse): Update.
6054
6055 2019-01-06  Tom Tromey  <tom@tromey.com>
6056
6057         * c-exp.y (struct c_parse_state) <strings>: New member.
6058         (operator_stoken): Update.
6059
6060 2019-01-06  Tom Tromey  <tom@tromey.com>
6061
6062         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
6063         (union type_stack_elt) <typelist_val>: Now a pointer to
6064         std::vector.
6065         (type_stack_cleanup): Don't declare.
6066         (push_typelist): Update.
6067         * parse.c (pop_typelist): Return a std::vector.
6068         (push_typelist): Take a std::vector.
6069         (follow_types): Update.  Do not free args.
6070         (type_stack_cleanup): Remove.
6071         * c-exp.y (struct c_parse_state): New.
6072         (cpstate): New global.
6073         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
6074         (nonempty_typelist): Update.
6075         (func_mod): Create a new vector.
6076         (c_parse): Create a c_parse_state.
6077         (check_parameter_typelist): Do not delete params.
6078         (function_method): Update.  Do not delete type_list.
6079
6080 2019-01-06  Tom Tromey  <tom@tromey.com>
6081
6082         PR gdb/28155:
6083         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
6084         check_typedef.
6085         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
6086         (print_return_value): Likewise.
6087
6088 2019-01-05  Tom Tromey  <tom@tromey.com>
6089
6090         * contrib/cleanup_check.py: Remove.
6091         * contrib/gcc-with-excheck: Remove.
6092         * contrib/exsummary.py: Remove.
6093         * contrib/excheck.py: Remove.
6094
6095 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
6096
6097         * thread.c (delete_thread_1): Add gdb_assert that THR is not
6098         NULL. Initialize tpprev to NULL instead of assigning it
6099         to NULL on the next statement.
6100         * windows-nat.c (windows_delete_thread): Remove check for
6101         main_thread_id before printing thread exit notifications.
6102         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
6103         Remove thread ID check against main_thread_id.
6104         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
6105         windows_delete_thread.
6106         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
6107
6108 2019-01-04  Tom Tromey  <tom@tromey.com>
6109
6110         * compile/compile.c (_initialize_compile): Use upper case for
6111         metasyntactic variables.
6112         * symmisc.c (_initialize_symmisc): Use upper case for
6113         metasyntactic variables.
6114         * psymtab.c (_initialize_psymtab): Use upper case for
6115         metasyntactic variables.
6116         * demangle.c (demangle_command): Use upper case for metasyntactic
6117         variables.
6118         (_initialize_demangler): Likewise.
6119         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
6120         variables.
6121
6122 2019-01-03  Tom Tromey  <tom@tromey.com>
6123
6124         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
6125
6126 2019-01-03  Tom Tromey  <tom@tromey.com>
6127
6128         * python/py-symtab.c (salpy_str): Update.
6129         (struct salpy_sal_object) <symtab>: Now a PyObject.
6130         (salpy_dealloc): Update.
6131         (del_objfile_sal): Use gdbpy_ref.
6132
6133 2019-01-03  Tom Tromey  <tom@tromey.com>
6134
6135         * python/py-type.c (convert_field): Use new_reference.  Return
6136         gdbpy_ref.
6137         (make_fielditem): Return gdbpy_ref.
6138         (typy_fields): Update.
6139         (typy_getitem): Update.
6140         (field_name): Return gdbpy_ref.  Use new_reference.
6141         (typy_iterator_iternext): Update.
6142
6143 2019-01-03  Tom Tromey  <tom@tromey.com>
6144
6145         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6146
6147 2019-01-03  Tom Tromey  <tom@tromey.com>
6148
6149         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6150         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6151         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6152         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6153         (pspy_set_type_printers): Likewise.
6154         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6155         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6156         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6157         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6158         (objfpy_set_type_printers): Likewise.
6159
6160 2019-01-03  Tom Tromey  <tom@tromey.com>
6161
6162         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6163         (gdbpy_print_stack): Use gdbpy_err_fetch.
6164         * python/python-internal.h (class gdbpy_err_fetch): New class.
6165         (class gdbpy_enter) <m_error_type, m_error_value,
6166         m_error_traceback>: Remove.
6167         <m_error>: New member.
6168         (gdbpy_exception_to_string): Don't declare.
6169         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6170         * python/py-value.c (convert_value_from_python): Use
6171         gdbpy_err_fetch.
6172         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6173         gdbpy_exception_to_string.
6174         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6175         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6176         gdbpy_err_fetch.
6177
6178 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6179
6180         * linux-nat.c (delete_lwp_cleanup): Delete.
6181         (struct lwp_deleter): New struct.
6182         (lwp_info_up): New typedef.
6183         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6184         lwp_info_up.
6185
6186 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6187
6188         * linux-fork.c (class scoped_switch_fork_info): New class.
6189         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6190
6191 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6192
6193         * valops.c (find_overload_match): Remove use of null_cleanup, and
6194         calls to do_cleanups.
6195
6196 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6197
6198         * compile/compile-cplus-types.c
6199         (compile_cplus_instance::decl_name): Handle changes to
6200         cp_func_name.
6201         * cp-support.c (cp_func_name): Update header comment, update
6202         return type.
6203         * cp-support.h (cp_func_name): Update return type in declaration.
6204         * valops.c (find_overload_match): Move temp_func local to top
6205         level of function and change its type.  Use temp_func to hold and
6206         delete temporary string obtained from cp_func_name.
6207
6208 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6209
6210         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6211         gdb::char_vector, remove cleanup, and update uses of `msg`.
6212
6213 2019-01-03  Jim Wilson  <jimw@sifive.com>
6214
6215         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6216
6217 2019-01-02  Tom Tromey  <tom@tromey.com>
6218
6219         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6220         (tdesc_parse_xml): Remove cleanups.
6221         * target-descriptions.h (make_cleanup_free_target_description):
6222         Don't declare.
6223         (target_desc_deleter): New struct.
6224         (target_desc_up): New typedef.
6225         * target-descriptions.c (target_desc_deleter::operator()): Rename
6226         from free_target_description.
6227         (make_cleanup_free_target_description): Remove.
6228
6229 2019-01-02  Tom Tromey  <tom@tromey.com>
6230
6231         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6232         constructor, destructor.
6233         (linespec_parser): Remove typedef.
6234         (~linespec_parser): Rename from linespec_parser_delete.
6235         (linespec_lex_to_end, linespec_complete_label)
6236         (linespec_complete): Update.
6237         (decode_line_full): Remove cleanups.
6238         (decode_line_1): Update.
6239
6240 2019-01-02  Tom Tromey  <tom@tromey.com>
6241
6242         * python/python-internal.h (inferior_to_inferior_object): Change
6243         return type.
6244         * python/py-exitedevent.c (create_exited_event_object): Update.
6245         * python/py-inferior.c (inferior_to_inferior_object): Return
6246         gdbpy_ref.
6247         (python_new_inferior, python_inferior_deleted)
6248         (thread_to_thread_object, delete_thread_object)
6249         (build_inferior_list, gdbpy_selected_inferior): Update.
6250         * python/py-infthread.c (create_thread_object): Update.  Also fail
6251         if inferior_to_inferior_object fails.
6252
6253 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6254
6255         * inferior.h (class inferior) <displaced_step_state>: New field.
6256         * infrun.h (struct displaced_step_state): Move here from
6257         infrun.c.  Initialize fields, add constructor.
6258         <inf>: Remove field.
6259         <reset>: New method.
6260         * infrun.c (struct displaced_step_inferior_state): Move to
6261         infrun.h.
6262         (displaced_step_inferior_states): Remove.
6263         (get_displaced_stepping_state): Adust.
6264         (displaced_step_in_progress_any_inferior): Adjust.
6265         (displaced_step_in_progress_thread): Adjust.
6266         (displaced_step_in_progress): Adjust.
6267         (add_displaced_stepping_state): Remove.
6268         (get_displaced_step_closure_by_addr): Adjust.
6269         (remove_displaced_stepping_state): Remove.
6270         (infrun_inferior_exit): Call displaced_step_state.reset.
6271         (use_displaced_stepping): Don't check for NULL.
6272         (displaced_step_prepare_throw): Call
6273         get_displaced_stepping_state.
6274         (displaced_step_fixup): Don't check for NULL.
6275         (prepare_for_detach): Don't check for NULL.
6276
6277 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6278
6279         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6280          in case of call that did not complete.
6281
6282 2019-01-02  Andrey Utkin  <autkin@undo.io>
6283
6284         * symfile.c (find_separate_debug_file): Fix search of debug files for
6285         remote debuggee.
6286
6287 2019-01-02  Tom Tromey  <tom@tromey.com>
6288
6289         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6290         indentation.
6291         * python/py-frame.c (frapy_older): Remove cast.
6292         (frapy_newer): Likewise.
6293         * python/py-breakpoint.c (local_setattro): Remove cast.
6294         * python/py-arch.c (archpy_name): Remove local variable.
6295         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6296
6297 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6298
6299         * unittests/basic_string_view/element_access/char/empty.cc:
6300         Fix year range in copyright header.
6301
6302 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6303
6304         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6305         Delete.
6306         <operator==>: Update with for removed field.
6307         <hash>: Likewise.
6308         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6309         <isa_features>: ...this.
6310         <abi_features>: New field.
6311         (riscv_isa_flen): Update comment.
6312         (riscv_abi_xlen): New declaration.
6313         (riscv_abi_flen): New declaration.
6314         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6315         isa_features.
6316         (riscv_abi_xlen): New function.
6317         (riscv_isa_flen): Update to get answer from isa_features.
6318         (riscv_abi_flen): New function.
6319         (riscv_has_fp_abi): Update to get answer from abi_features.
6320         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6321         xlen and flen.
6322         (riscv_call_info) <xlen, flen>: Update comment.
6323         (riscv_call_arg_struct): Remove invalid assertions
6324         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6325         is removed.
6326         (riscv_gdbarch_init): Gather isa features and abi features
6327         separately, ensure both match on the gdbarch when reusing an old
6328         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6329         a target with 64-bit float hardware.
6330
6331 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6332
6333         * source.c (search_command_helper): Stop reverse search
6334         when line 1 has been searched.
6335
6336 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6337
6338         * record-full.c (record_full_base_target::close): Rewrite
6339         record_full_core_buf_list free logic.
6340
6341 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6342
6343         * break-catch-syscall.c (print_one_catch_syscall): xfree
6344         the last text.
6345
6346 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6347
6348         * top.c (print_gdb_version): Update Copyright year in version
6349         message.
6350
6351 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6352
6353         Update copyright year range in all GDB files.
6354
6355 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6356
6357         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6358
6359 For older changes see ChangeLog-2018.
6360 \f
6361 Local Variables:
6362 mode: change-log
6363 left-margin: 8
6364 fill-column: 74
6365 version-control: never
6366 coding: utf-8
6367 End:
6368