gdb/ChangeLog

   1 2019-06-25  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-win.c (tui_win_info::max_height)
   4         (tui_cmd_window::max_height): New methods.
   5         (new_height_ok): Call max_height.
   6         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
   7         <max_height>: New method.
   8
   9 2019-06-25  Tom Tromey  <tom@tromey.com>
  10
  11         * tui/tui-win.c (tui_source_window_base::set_new_height)
  12         (tui_data_window::set_new_height): New methods.
  13         (make_invisible_and_set_new_height): Call set_new_height method.
  14         * tui/tui-data.h (struct tui_win_info)
  15         (struct tui_source_window_base, struct tui_data_window)
  16         <set_new_height>: New method.
  17
  18 2019-06-25  Tom Tromey  <tom@tromey.com>
  19
  20         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
  21         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
  22         tui_refresh_data_win.
  23         * tui/tui-win.c (tui_source_window_base::refresh_all): New
  24         method.
  25         (tui_refresh_all_win): Call the refresh_all method.
  26         (tui_set_focus): Likewise.
  27         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
  28         (struct tui_source_window_base, struct tui_data_window) <refresh>:
  29         Likewise.
  30
  31 2019-06-25  Tom Tromey  <tom@tromey.com>
  32
  33         * tui/tui-winsource.h (tui_refill_source_window)
  34         (tui_set_is_exec_point_at): Don't declare.
  35         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
  36         (tui_source_window_base::refill): Rename from
  37         tui_refill_source_window.
  38         (tui_source_window_base::do_scroll_horizontal): Update.
  39         (tui_source_window_base::set_is_exec_point_at): Rename from
  40         tui_set_is_exec_point_at.
  41         (tui_update_all_breakpoint_info): Update.
  42         * tui/tui-stack.c (tui_show_frame_info): Update.
  43         * tui/tui-layout.c (show_data): Add cast.
  44         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
  45         * tui/tui-data.h (struct tui_source_window_base) <refill,
  46         set_is_exec_point_at>: New methods.
  47         (tui_source_windows, tui_add_to_source_windows): Update types.
  48         (tui_add_to_source_windows): Remove redundant declaration.
  49         * tui/tui-data.c (source_windows): Store tui_source_window_base.
  50         (tui_source_windows): Change return type.
  51         (tui_clear_source_windows_detail): Update.
  52         (tui_add_to_source_windows): Change type of parameter.
  53         (tui_free_all_source_wins_content): Update.
  54
  55 2019-06-25  Tom Tromey  <tom@tromey.com>
  56
  57         * tui/tui-wingeneral.c (tui_win_info::refresh)
  58         (tui_source_window_base::refresh): New methods.
  59         (tui_refresh_all): Call the refresh method.
  60         * tui/tui-data.h (struct tui_win_info)
  61         (struct tui_source_window_base) <refresh>: New method.
  62
  63 2019-06-25  Tom Tromey  <tom@tromey.com>
  64
  65         * tui/tui.h (tui_is_window_visible): Return bool.
  66         * tui/tui.c (tui_is_window_visible): Return bool.
  67         * tui/tui-wingeneral.c (tui_make_window, make_visible)
  68         (tui_make_visible, tui_make_invisible)
  69         (tui_win_info::make_visible)
  70         (tui_source_window_base::make_visible, make_all_visible)
  71         (tui_make_all_visible, tui_make_all_invisible): Update.
  72         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
  73         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
  74         bool.
  75         (struct tui_win_info, struct tui_source_window_base)
  76         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
  77         * tui/tui-data.c (tui_init_generic_part): Update.
  78
  79 2019-06-25  Tom Tromey  <tom@tromey.com>
  80
  81         * tui/tui-wingeneral.c (tui_win_info::make_visible)
  82         (tui_source_window_base::make_visible): New methods.
  83         (make_all_visible): Make method call.
  84         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
  85         (struct tui_source_window_base, struct tui_cmd_window): Override
  86         make_visible.
  87         (tui_win_is_source_type): Don't declare.
  88         * tui/tui-data.c (tui_win_is_source_type): Remove.
  89
  90 2019-06-25  Tom Tromey  <tom@tromey.com>
  91
  92         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
  93         NULL check.
  94
  95 2019-06-25  Tom Tromey  <tom@tromey.com>
  96
  97         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
  98         Inline constructor.  Add initializers for members.
  99         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
 100         constructors; now inline in class.
 101
 102 2019-06-25  Tom Tromey  <tom@tromey.com>
 103
 104         * tui/tui-regs.c (tui_show_registers): Update.
 105         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
 106         bool.
 107         * tui/tui-data.c (tui_data_window::clear_detail)
 108         (tui_data_window): Update.
 109
 110 2019-06-25  Tom Tromey  <tom@tromey.com>
 111
 112         * tui/tui-windata.c (tui_display_all_data)
 113         (tui_display_data_from_line, tui_display_data_from)
 114         (tui_check_data_values, tui_data_window::do_scroll_vertical):
 115         Update.
 116         * tui/tui-regs.c (tui_last_regs_line_no)
 117         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 118         (tui_show_registers, tui_show_register_group)
 119         (tui_display_registers_from, tui_display_reg_element_at_line)
 120         (tui_display_registers_from_line, tui_check_register_values)
 121         (tui_reg_next, tui_reg_prev): Update.
 122         * tui/tui-layout.c (tui_set_layout, show_data): Update.
 123         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
 124         tui_data_window.
 125         (struct tui_win_info) <detail>: Remove.  Add new fields from
 126         tui_data_info.
 127         (TUI_DATA_WIN): Add cast.
 128         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
 129         (~tui_data_window): Simplify.
 130
 131 2019-06-25  Tom Tromey  <tom@tromey.com>
 132
 133         * tui/tui-layout.c (show_source_disasm_command)
 134         (show_source_or_disasm_and_command): Update.
 135         * tui/tui-io.c (update_cmdwin_start_line)
 136         (tui_redisplay_readline): Update.
 137         * tui/tui-data.h (struct tui_command_info): Remove.
 138         (struct tui_win_info) <detail>: Remove command_info member.
 139         (struct tui_data_window) <start_line>: New member, from
 140         tui_command_info.
 141         (TUI_CMD_WIN): Add casts.
 142
 143 2019-06-25  Tom Tromey  <tom@tromey.com>
 144
 145         * tui/tui-winsource.c (tui_update_source_window)
 146         (tui_refill_source_window)
 147         (tui_source_window_base::do_scroll_horizontal)
 148         (tui_update_breakpoint_info, tui_set_exec_info_content)
 149         (tui_show_exec_info_content, tui_erase_exec_info_content)
 150         (tui_clear_exec_info_content): Update.
 151         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
 152         Update.
 153         * tui/tui-win.c (make_invisible_and_set_new_height)
 154         (make_visible_with_new_height): Update.
 155         * tui/tui-source.c (tui_set_source_content)
 156         (tui_show_symtab_source): Update.
 157         * tui/tui-layout.c (extract_display_start_addr)
 158         (show_source_disasm_command, show_data)
 159         (make_source_or_disasm_window)
 160         (show_source_or_disasm_and_command): Update.
 161         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
 162         (tui_disasm_window::do_scroll_vertical): Remove shadowing
 163         "gdbarch".
 164         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
 165         to tui_source_window_base.
 166         (struct tui_win_info) <detail>: Remove source_info member.
 167         (struct tui_source_window_base) <has_locator>: Inline.
 168         Move contents from tui_source_info; rename has_locator member to
 169         m_has_locator.
 170         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
 171         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
 172         header file.
 173         (tui_source_window_base::clear_detail, ~tui_source_window_base):
 174         Simplify.
 175         (tui_free_all_source_wins_content): Cast to
 176         tui_source_window_base.
 177
 178 2019-06-25  Tom Tromey  <tom@tromey.com>
 179
 180         * tui/tui-win.c (make_invisible_and_set_new_height)
 181         (make_visible_with_new_height): Call has_locator method.
 182         * tui/tui-layout.c (show_source_disasm_command, show_data)
 183         (show_source_or_disasm_and_command): Update for bool change.
 184         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
 185         (tui_win_info) <has_locator>: New method.
 186         (struct tui_source_window_base) <has_locator>: New method.
 187         (tui_win_has_locator): Don't declare.
 188         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
 189         from tui_win_has_locator.
 190         (tui_source_window_base): Use false, not FALSE.
 191
 192 2019-06-25  Tom Tromey  <tom@tromey.com>
 193
 194         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
 195         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
 196         clear_detail method directly.
 197         (tui_clear_win_detail): Remove.
 198
 199 2019-06-25  Tom Tromey  <tom@tromey.com>
 200
 201         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
 202         "this", not TUI_DISASM_WIN.
 203
 204 2019-06-25  Tom Tromey  <tom@tromey.com>
 205
 206         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
 207         declare.
 208         * tui/tui-winsource.c
 209         (tui_source_window_base::do_scroll_horizontal): Rename from
 210         tui_horizontal_source_scroll.
 211         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
 212         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
 213         from tui_vertical_data_scroll.
 214         * tui/tui-win.h (tui_scroll): Don't declare.
 215         * tui/tui-win.c (tui_win_info::forward_scroll)
 216         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 217         (tui_win_info::right_scroll): Rename and update.
 218         (tui_scroll_forward_command, tui_scroll_backward_command)
 219         (tui_scroll_left_command, tui_scroll_right_command): Update.
 220         (tui_scroll): Remove.
 221         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
 222         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
 223         from tui_vertical_source_scroll.
 224         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
 225         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
 226         from tui_vertical_disassem_scroll.
 227         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
 228         do_scroll_horizontal>: New methods.
 229         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
 230         Likewise.
 231         (struct tui_source_window_base): Add do_scroll_horizontal.
 232         (struct tui_source_window, struct tui_disasm_window): Add
 233         do_scroll_vertical.
 234         (struct tui_data_window, struct tui_cmd_window): Add
 235         do_scroll_horizontal and do_scroll_vertical.
 236         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
 237
 238 2019-06-25  Tom Tromey  <tom@tromey.com>
 239
 240         * tui/tui-data.h (struct tui_source_window_base): New struct.
 241         (struct tui_source_window): Derive from tui_source_window_base.
 242         (struct tui_disasm_window): New struct.
 243         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
 244         from tui_source_window::clear_detail.
 245         (tui_source_window_base): Rename from tui_source_window.
 246         (~tui_source_window_base): Rename from ~tui_source_window.
 247         (tui_alloc_win_info): Create a tui_disasm_window.
 248
 249 2019-06-25  Tom Tromey  <tom@tromey.com>
 250
 251         * tui/tui-data.h (struct tui_source_window)
 252         (struct tui_data_window): Declare destructors.
 253         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
 254         destructors.
 255         (tui_win_info): Simplify.
 256
 257 2019-06-25  Tom Tromey  <tom@tromey.com>
 258
 259         * tui/tui-winsource.c (tui_display_main)
 260         (tui_update_source_windows_with_addr)
 261         (tui_update_all_breakpoint_info): Update.
 262         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 263         (new_height_ok, parse_scrolling_args): Update.
 264         * tui/tui-stack.c (tui_show_frame_info): Update.
 265         * tui/tui-data.h (struct tui_list): Remove.
 266         (tui_source_windows): Return a reference to a std::vector.
 267         * tui/tui-data.c (source_windows): Now a std::vector.
 268         (tui_source_windows): Change return type.
 269         (tui_clear_source_windows): Rewrite.
 270         (tui_clear_source_windows_detail, tui_add_to_source_windows)
 271         (tui_free_all_source_wins_content): Rewrite.
 272
 273 2019-06-25  Tom Tromey  <tom@tromey.com>
 274
 275         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
 276         (struct tui_data_window, struct tui_cmd_window): Declare
 277         clear_detail method.
 278         * tui/tui-data.c (tui_source_window::clear_detail)
 279         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
 280         methods.
 281         (tui_clear_win_detail): Simplify.
 282
 283 2019-06-25  Tom Tromey  <tom@tromey.com>
 284
 285         * tui/tui-layout.c (make_source_window, make_disasm_window)
 286         (make_source_or_disasm_window): Remove win_info_ptr parameter.
 287         Return the new window.
 288         (show_source_disasm_command, show_data)
 289         (show_source_or_disasm_and_command): Update.
 290
 291 2019-06-25  Tom Tromey  <tom@tromey.com>
 292
 293         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
 294         parameter.  Return the new window.
 295         (show_source_disasm_command): Update and remove NULL check.
 296         (show_source_or_disasm_and_command): Update.
 297
 298 2019-06-25  Tom Tromey  <tom@tromey.com>
 299
 300         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
 301
 302 2019-06-25  Tom Tromey  <tom@tromey.com>
 303
 304         * tui/tui-data.h (struct tui_win_info): Make constructor
 305         protected.  Make destructor virtual.  Add initializers.
 306         (tui_source_window, tui_data_window, tui_cmd_window): New
 307         classes.
 308         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
 309         constructor.  Add "type" parameter.
 310         (tui_source_window, tui_data_window, tui_cmd_window): New
 311         constructors.
 312         (tui_alloc_win_info): Instantiate the appropriate subclass.
 313
 314 2019-06-25  Tom Tromey  <tom@tromey.com>
 315
 316         * tui/tui-win.c (tui_resize_all): Use delete.
 317         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
 318         destructor.
 319         (tui_free_window): Don't declare.
 320         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
 321         Update.
 322
 323 2019-06-25  Tom Tromey  <tom@tromey.com>
 324
 325         * tui/tui-data.h (struct tui_win_info): Add constructor.
 326         * tui/tui-data.c (tui_alloc_win_info): Use new.
 327         (tui_free_window): Use delete.
 328
 329 2019-06-22  Tom Tromey  <tom@tromey.com>
 330
 331         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
 332         declare.
 333         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
 334
 335 2019-06-22  Tom Tromey  <tom@tromey.com>
 336
 337         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
 338         declare.
 339         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
 340
 341 2019-06-22  Tom de Vries  <tdevries@suse.de>
 342
 343         * dwarf2read.c (create_addrmap_from_aranges)
 344         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
 345         instead of '%zu'.
 346
 347 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
 348
 349         * dwarf2read.h (dwarf2_section_info_def): Remove.
 350         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
 351         * dwarf2read.c (struct dwo_sections) <types>: Change type to
 352         std::vector<dwarf2_section_info>.
 353         (struct dwo_file) <~dwo_file>: Remove.
 354         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
 355         types field.
 356         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
 357         (dwarf2_read_debug_names): Likewise.
 358         (create_debug_types_hash_table): Change parameter type to
 359         array_view, adjust code accordingly.
 360         (dwarf2_locate_dwo_sections): Adjust to std::vector.
 361         (partial_die_info::fixup): Likewise.
 362         (determine_prefix): Likewise.
 363         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
 364
 365 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 366
 367         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
 368         gdb_bfd_ref_ptr.
 369         <~dwo_file>: Remove call to gdb_bfd_unref.
 370         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
 371         gdb_bfd_ref_ptr::get.
 372
 373 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 374
 375         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
 376         type to htab_up.
 377         * dwarf2read.c (struct dwo_file): Initialize fields.
 378         <~dwo_file>: New.
 379         (free_dwo_file): Remove, move content to ~dwo_file.
 380         (struct dwo_file_deleter): Remove.
 381         (dwo_file_up>: Remove custom deleter.
 382         (free_dwo_files): Remove.
 383         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
 384         dwo_files.
 385         (process_skeletonless_type_units): Call unique_ptr::get.
 386         (allocate_dwo_file_hash_table): Add deleter to created hash
 387         table.  Change return type to htab_up.
 388         (lookup_dwo_file_slot): Don't memset dwo_file, call
 389         unique_ptr::get.
 390         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
 391         (create_dwo_unit_in_dwp_v2): Likewise.
 392         (open_and_init_dwo_file): Likewise.
 393         (free_dwo_file_from_slot): Remove.
 394
 395 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 396
 397         * dwarf2read.h (struct dwarf2_section_info) <readin,
 398         is_virtual>: Change type to bool.
 399         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
 400         true instead of 1.
 401
 402 2019-06-19  Tom Tromey  <tom@tromey.com>
 403
 404         * tui/tui-data.h (tui_init_content_element): Don't declare.
 405
 406 2019-06-19  Tom Tromey  <tom@tromey.com>
 407
 408         * tui/tui-data.h (tui_init_win_info): Don't declare.
 409
 410 2019-06-19  Tom de Vries  <tdevries@suse.de>
 411
 412         * dwarf2read.h (abstract_to_concrete): Change type to
 413         std::unordered_map<sect_offset, std::vector<sect_offset>,
 414         gdb::hash_enum<sect_offset>>.
 415
 416 2019-06-19  Tom Tromey  <tromey@adacore.com>
 417
 418         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
 419         EVAL_AVOID_SIDE_EFFECTS specially.
 420
 421 2019-06-19  Tom Tromey  <tromey@adacore.com>
 422
 423         * source-cache.c (highlighter): New global.
 424         (source_cache::get_source_lines): Create a highlighter on demand.
 425
 426 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 427
 428         * defs.h (deprecated_interactive_hook): Delete declaration.
 429         * interps.c (clear_interpreter_hooks): Remove use of
 430         deprecated_interactive_hook.
 431         * top.c (deprecated_interactive_hook): Delete definition.
 432         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
 433
 434 2019-06-18  Tom de Vries  <tdevries@suse.de>
 435
 436         PR gdb/24515
 437         * dwarf2read.h (abstract_to_concrete): Change type from
 438         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
 439         std::unordered_map<sect_offset, std::vector<sect_offset>>.
 440         * dwarf2read.c (read_variable): Update.
 441         (dwarf2_fetch_die_loc_sect_off): Update.
 442
 443 2019-06-17  Tom de Vries  <tdevries@suse.de>
 444
 445         PR gdb/24617
 446         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
 447         accessing parent[parent_len - 1].
 448
 449 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
 450
 451         PR gdb/24364
 452         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
 453         call dtrace_process_dof with NULL dof.
 454
 455 2019-06-16  Tom de Vries  <tdevries@suse.de>
 456
 457         PR gdb/24445
 458         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
 459
 460 2019-06-16  Tom Tromey  <tom@tromey.com>
 461
 462         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 463         (make_all_visible): Use address of member.
 464
 465 2019-06-16  Tom Tromey  <tom@tromey.com>
 466
 467         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
 468         (tui_free_window, free_content, free_content_elements): Remove
 469         unnecessary cast.
 470         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
 471         cast.
 472         * tui/tui-regs.c (tui_show_register_group)
 473         (tui_display_registers_from, tui_display_reg_element_at_line):
 474         Remove unnecessary cast.
 475
 476 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
 477
 478         * linux-nat.c (normal_mask): Delete.
 479         (_initialize_linux_nat): Don't initialise normal_mask.
 480
 481 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
 482
 483         PR gdb/24445
 484         * dwarf-index-write.h (write_psymtabs_to_index): Add
 485         dwz_basename parameter.
 486         * dwarf-index-write.c (write_gdbindex): Move file writing to
 487         write_gdbindex_1.  Change return type void.
 488         (assert_file_size): Move up, remove filename parameter.
 489         (write_gdbindex_1): New function.
 490         (write_debug_names): Change return type to void, call
 491         assert_file_size.
 492         (struct index_wip_file): New struct.
 493         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
 494         file logic to index_wip_file.  Write index for dwz file if
 495         needed.
 496         (save_gdb_index_command): Pass basename of dwz file, if present.
 497         * dwarf-index-cache.c (index_cache::store): Obtain and pass
 498         build-id of dwz file, if present.
 499         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
 500         (dwarf2_get_dwz_file): Likewise.
 501         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
 502         (dwarf2_get_dwz_file): Likewise.
 503
 504 2019-06-16  Tom Tromey  <tom@tromey.com>
 505
 506         * coffread.c (process_coff_symbol): Use xstrdup.
 507         * value.c (create_internalvar): Use xstrdup.
 508
 509 2019-06-16  Tom Tromey  <tom@tromey.com>
 510
 511         * valops.c (value_cast, value_slice): Remove unnecessary cast.
 512         * breakpoint.c (stopin_command, stopat_command)
 513         (until_break_command, decode_location_default): Remove unnecessary
 514         cast.
 515         * utils.c (subset_compare): Remove unnecessary cast.
 516         * ada-lang.c (ada_update_initial_language): Remove unnecessary
 517         cast.
 518         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
 519         cast.
 520         * infcmd.c (path_command): Remove unnecessary cast.
 521         * coffread.c (decode_type): Remove unnecessary cast.
 522         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
 523         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
 524         * tui/tui-stack.c (tui_show_locator_content)
 525         (tui_show_frame_info): Remove unnecessary cast.
 526         * tui/tui-win.c (tui_scroll_forward_command)
 527         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
 528         (parse_scrolling_args): Remove unnecessary cast.
 529         * tui/tui-data.c (init_win_info, tui_del_window)
 530         (tui_free_window, tui_del_data_windows, tui_free_data_content)
 531         (free_content_elements): Remove unnecessary cast.
 532         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
 533         unnecessary cast.
 534         * tui/tui-source.c (tui_set_source_content)
 535         (tui_vertical_source_scroll): Remove unnecessary cast.
 536         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
 537         cast.
 538         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
 539         * tui/tui-regs.c (tui_display_registers_from)
 540         (tui_display_register): Remove unnecessary cast.
 541         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
 542         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
 543         (make_visible): Remove unnecessary cast.
 544         * tui/tui-winsource.c (tui_erase_source_content)
 545         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
 546         unnecessary cast.
 547         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
 548         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
 549         * stabsread.c (read_type, read_array_type, read_range_type):
 550         Remove unnecessary cast.
 551         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
 552         (parse_symbol, parse_type, upgrade_type, parse_external)
 553         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
 554         unnecessary cast.
 555         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
 556
 557 2019-06-16  Tom Tromey  <tom@tromey.com>
 558
 559         * tui/tui-data.c (tui_alloc_generic_win_info)
 560         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
 561         checks.
 562
 563 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
 564             Andrew Burgess  <andrew.burgess@embecosm.com>
 565
 566         * f-typeprint.c (f_print_type): Don't return early for not
 567         associated or not allocated types.
 568         (f_type_print_varspec_suffix): Add print_rank parameter and print
 569         ranks of array types in case they dangling.
 570         (f_type_print_base): Add print_rank parameter.
 571
 572 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 573
 574         * NEWS: Mention new MI commands.
 575         * break-catch-throw.c (enum exception_event_kind): Move to
 576         breakpoint.h.
 577         (print_mention_exception_catchpoint): Output text as a single
 578         message.
 579         (catch_exception_command_1): Rename to...
 580         (catch_exception_event): ...this, make non-static, update header
 581         command, and change some parameter types.
 582         (catch_catch_command): Update for changes to
 583         catch_exception_command_1.
 584         (catch_throw_command): Likewise.
 585         (catch_rethrow_command): Likewise.
 586         * breakpoint.c (enum exception_event_kind): Delete.
 587         * breakpoint.h (enum exception_event_kind): Moved here from
 588         break-catch-throw.c.
 589         (catch_exception_event): Declare.
 590         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
 591         (mi_cmd_catch_throw): New function.
 592         (mi_cmd_catch_rethrow): New function.
 593         (mi_cmd_catch_catch): New function.
 594         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
 595         'catch-catch' entries.
 596         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
 597         (mi_cmd_catch_rethrow): Declare.
 598         (mi_cmd_catch_catch): Declare.
 599
 600 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 601
 602         * annotate.c (annotate_source_line): Change return type to void,
 603         update implementation to match.
 604         * annotate.h (annotate_source_line): Change return type to void,
 605         update header comment.
 606         * stack.c (print_frame_info): Don't change what frame information
 607         is printed based on whether annotations are on or not.
 608
 609 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 610
 611         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
 612         (annotate_source): Make static.
 613         (annotate_source_line): Moved from source.c and renamed from
 614         identify_source_line.  Update the return type.
 615         * annotate.h (annotate_source): Delete declaration.
 616         (annotate_source_line): Declaration moved from source.h, and
 617         renamed from identify_source_line.  Return type updated.
 618         * source.c (identify_source_line): Moved to annotate.c and renamed
 619         to annotate_source_line.
 620         (info_line_command): Remove check of annotation_level.
 621         * source.h (identify_source_line): Move declaration to annotate.h
 622         and rename to annotate_source_line.
 623         * stack.c: Add 'annotate.h' include.
 624         (print_frame_info): Remove check of annotation_level before
 625         calling annotate_source_line.
 626
 627 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 628
 629         * source-cache.c (source_cache::get_plain_source_lines): Use
 630         open_source_file_with_line_charpos instead of just
 631         open_source_file, remove call to find_source_lines.
 632         (source_cache::get_source_lines): Likewise.
 633         * source.c (find_source_lines): Make static.
 634         (get_filename_and_charpos): Renamed into...
 635         (open_source_file_with_line_charpos): ..this along with changes to
 636         return a scoped_fd, and some other minor clean ups.
 637         (identify_source_line): Use open_source_file_with_line_charpos.
 638         (search_command_helper): Use open_source_file_with_line_charpos
 639         instead of just open_source_file, remove call to
 640         find_source_lines.
 641         * source.h (open_source_file_with_line_charpos): Declare new
 642         function.
 643         (find_source_lines): Delete declaration.
 644
 645 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 646
 647         * source.c (get_filename_and_charpos): Remove fullname
 648         parameter.
 649         (identify_source_line): Update call to get_filename_and_charpos.
 650
 651 2019-06-14  Tom Tromey  <tromey@adacore.com>
 652
 653         PR gdb/24502:
 654         * ui-style.h (skip_ansi_escape): Update comment.
 655         * ui-file.h (class no_terminal_escape_file): New class.
 656         * ui-file.c (no_terminal_escape_file::write)
 657         (no_terminal_escape_file::puts): New methods.
 658         * cli/cli-logging.c (handle_redirections): Use
 659         no_terminal_escape_file.
 660
 661 2019-06-14  Tom Tromey  <tromey@adacore.com>
 662
 663         * NEWS: Move convenience variable news above Python news.
 664
 665 2019-06-14  Tom Tromey  <tom@tromey.com>
 666
 667         * gnulib: Move directory to top-level.
 668         * configure.ac: Don't configure gnulib.
 669         * configure: Rebuild.
 670         * common/common-defs.h: Use new path to gnulib.
 671         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
 672         (GNULIB_H): Remove.
 673         (INCGNU): Look in new gnulib location.
 674         (HFILES_NO_SRCDIR): Remove gnulib files.
 675         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
 676         (generated_files): Remove GNULIB_H.
 677         ($(LIBGNU), all-lib): Remove targets.
 678         (distclean): Don't mention GNULIB_BUILDDIR.
 679         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
 680
 681 2019-06-14  Tom Tromey  <tromey@adacore.com>
 682
 683         * symfile.c (add_symbol_file_command): Remove obsolete comment.
 684         Warn if symbol file does not provide any symbols.
 685
 686 2019-06-14  Tom Tromey  <tromey@adacore.com>
 687
 688         * source.c (find_and_open_source): Respect basenames_may_differ.
 689
 690 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
 691
 692         * annotate.c (annotate_breakpoints_invalid): Make use of
 693         scoped_restore_terminal_state.
 694         (annotate_frames_invalid): Likewise.
 695
 696 2019-06-14  Tom Tromey  <tromey@adacore.com>
 697
 698         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
 699         allow assignment to an internalvar.
 700
 701 2019-06-14  Tom Tromey  <tromey@adacore.com>
 702
 703         * ada-lex.l: Allow "_" in attribute names.
 704
 705 2019-06-14  Tom Tromey  <tromey@adacore.com>
 706
 707         PR gdb/24653:
 708         * regcache.c (registers_changed): Don't call alloca.
 709         * top.c (execute_command): Don't call alloca.
 710
 711 2019-06-13  Pedro Alves  <palves@redhat.com>
 712
 713         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
 714         'expression'.  When parsing an expression, error out if there's
 715         junk after "unlimited".
 716         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 717         (do_set_command): Adjust calls to is_unlimited_literal.
 718
 719 2019-06-13  Pedro Alves  <palves@redhat.com>
 720
 721         * compile/compile.c (make_compile_options_def_group): Add braces
 722         around array_view initializer.
 723         * thread.c (make_thread_apply_all_options_def_group)
 724         (make_thread_apply_all_options_def_group): Likewise.
 725
 726 2019-06-13  Pedro Alves  <palves@redhat.com>
 727
 728         * NEWS (New commands): Mention "maint test-options
 729         require-delimiter", "maint test-options unknown-is-error", "maint
 730         test-options unknown-is-operand" and "maint show
 731         test-options-completion-result".
 732         (New command options, command completion): New section.
 733         (Completion improvements): New section.
 734         Mention that you can abbreviate "unlimited".
 735
 736 2019-06-13  Pedro Alves  <palves@redhat.com>
 737
 738         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
 739         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
 740         * unittests/cli-utils-selftests.c (test_parse_flags)
 741         (test_parse_flags_qcs): Delete.
 742         (test_cli_utils): Don't call deleted functions.
 743
 744 2019-06-13  Pedro Alves  <palves@redhat.com>
 745
 746         * thread.c: Include "cli/cli-option.h".
 747         (tp_array_compar_ascending): Global.
 748         (tp_array_compar): Delete function.
 749         (tp_array_compar_ascending, tp_array_compar_descending): New
 750         functions.
 751         (ascending_option_def, qcs_flag_option_def)
 752         (thr_qcs_flags_option_defs)
 753         (make_thread_apply_all_options_def_group)
 754         (make_thread_apply_options_def_group): New.
 755         (thread_apply_all_command): Use gdb::option::process_options.
 756         (thread_apply_command_completer)
 757         (thread_apply_all_command_completer): New.
 758         (thread_apply_command): Use gdb::option::process_options.
 759         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
 760         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
 761         to generate help text of "thread apply".  Adjust "taas"'s help.
 762         * tid-parse.c (tid_range_parser::in_thread_range): New method.
 763         * tid-parse.h (tid_range_parser::in_thread_range): New method.
 764
 765 2019-06-13  Pedro Alves  <palves@redhat.com>
 766
 767         * thread.c (thread_apply_command): Check for invalid TID with
 768         isdigit instead of !isalpha.
 769
 770 2019-06-13  Pedro Alves  <palves@redhat.com>
 771
 772         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
 773         (validate_flags_qcs): New.
 774         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
 775         (validate_flags_qcs): Declare.
 776         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
 777         (make_frame_apply_options_def_group): New.
 778         (frame_apply_command_count): Process options with
 779         gdb::option::process_options.
 780         (frame_apply_completer): New.
 781         (frame_apply_level_completer, frame_apply_all_completer)
 782         (frame_apply_completer): New.
 783         (_initialize_stack): Update help of "frame apply", "frame apply
 784         level", "frame apply all" and "faas" to mention supported options
 785         and install command completers.
 786         * stack.h (frame_apply_all_completer): Declare.
 787         * thread.c: Include "stack.h".
 788         (tfaas_command): Add "--".
 789         (_initialize_thread): Update help "tfaas" to mention supported
 790         options and install command completer.
 791
 792 2019-06-13  Pedro Alves  <palves@redhat.com>
 793
 794         * completer.c (complete_nested_command_line): New.
 795         (gdb_completion_word_break_characters_throw): Add assertion.
 796         * completer.h (complete_nested_command_line): Declare.
 797
 798 2019-06-13  Pedro Alves  <palves@redhat.com>
 799
 800         * stack.c (parse_backtrace_qualifiers): New.
 801         (backtrace_command): Use it.
 802         (backtrace_command_completer): Complete on qualifiers.
 803
 804 2019-06-13  Pedro Alves  <palves@redhat.com>
 805
 806         * frame.c: Include "cli/cli-option.h.
 807         (user_set_backtrace_options): New.
 808         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
 809         Delete.
 810         (get_prev_frame): Adjust.
 811         (boolean_option_def, uinteger_option_def)
 812         (set_backtrace_option_defs): New.
 813         (_initialize_frame): Adjust and use
 814         gdb::option::add_setshow_cmds_for_options to install "set
 815         backtrace past-main" and "set backtrace past-entry".
 816         * frame.h: Include "cli/cli-option.h".
 817         (struct frame_print_options): Forward declare.
 818         (print_frame_arguments_all, print_frame_arguments_scalars)
 819         (print_frame_arguments_none): Declare.
 820         (print_entry_values): Delete declaration.
 821         (struct frame_print_options, user_frame_print_options): New.
 822         (struct set_backtrace_options): New.
 823         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
 824         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
 825         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
 826         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
 827         (list_args_or_locals): Add frame_print_options parameter.
 828         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 829         * python/py-framefilter.c (enumerate_args): Pass down
 830         USER_FRAME_PRINT_OPTIONS.
 831         * stack.c: Include "cli/cli-option.h".
 832         (print_frame_arguments_all, print_frame_arguments_scalars)
 833         (print_frame_arguments_none): Declare.
 834         (print_raw_frame_arguments, print_entry_values): Delete.
 835         (user_frame_print_options): New.
 836         (boolean_option_def, enum_option_def, frame_print_option_defs):
 837         New.
 838         (struct backtrace_cmd_options): New.
 839         (bt_flag_option_def): New.
 840         (backtrace_command_option_defs): New.
 841         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 842         (print_frame_arg, read_frame_arg, print_frame_args)
 843         (print_frame_info, print_frame): Add frame_print_options parameter
 844         and use it.
 845         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
 846         (backtrace_command_1): Add frame_print_options and
 847         backtrace_cmd_options parameters and use them.
 848         (make_backtrace_options_def_group): New.
 849         (backtrace_command): Process command options with
 850         gdb::option::process_options.
 851         (backtrace_command_completer): New.
 852         (_initialize_stack): Extend "backtrace"'s help to mention
 853         supported options.  Install completer for "backtrace".
 854         Install some settings commands with add_setshow_cmds_for_options.
 855
 856 2019-06-13  Pedro Alves  <palves@redhat.com>
 857
 858         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
 859         and that "set/show print raw frame-arguments" are now deprecated.
 860
 861         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
 862         command.
 863         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
 864         * stack.c (_initialize_stack): Install "set/show print
 865         raw-frame-arguments", and deprecate "set/show print raw
 866         frame-arguments".
 867         * valprint.c (_initialize_valprint): Deprecate "set/show print
 868         raw".
 869
 870 2019-06-13  Pedro Alves  <palves@redhat.com>
 871
 872         * compile/compile.c (struct compile_options): New.
 873         (compile_flag_option_def, compile_command_option_defs)
 874         (make_compile_options_def_group): New.
 875         (compile_file_command): Handle options with
 876         gdb::option::process_options.
 877         (compile_file_command_completer): New function.
 878         (compile_code_command): Handle options with
 879         gdb::option::process_options.
 880         (compile_code_command_completer): New function.
 881         (_initialize_compiler): Install completers for "compile code" and
 882         "compile file".  Mention available options in "compile code" and
 883         "compile code"'s help.
 884         * completer.c (advance_to_completion_word): New, factored out from
 885         ...
 886         (advance_to_expression_complete_word_point): ... this.
 887         (advance_to_filename_complete_word_point): New.
 888         * completer.h (advance_to_filename_complete_word_point): New
 889         declaration.
 890
 891 2019-06-13  Pedro Alves  <palves@redhat.com>
 892
 893         * compile/compile.c: Include "cli/cli-option.h".
 894         (compile_print_value): Scope data pointer is now a
 895         value_print_options pointer; adjust.
 896         (compile_print_command): Process options.  Scope data pointer is
 897         now a value_print_options pointer; adjust.
 898         (_initialize_compile): Update "compile print"'s help to include
 899         supported options.  Install a completer for "compile print".
 900         * cp-valprint.c (show_vtblprint, show_objectprint)
 901         (show_static_field_print): Delete.
 902         (_initialize_cp_valprint): Don't install "set print
 903         static-members", "set print vtbl", "set print object" here.
 904         * printcmd.c: Include "cli/cli-option.h" and
 905         "common/gdb_optional.h".
 906         (print_command_parse_format): Rework to fill in a
 907         value_print_options instead of a format_data.
 908         (print_value): Change parameter type from format_data pointer to
 909         value_print_options reference.  Adjust.
 910         (print_command_1): Process options.  Adjust to pass down a
 911         value_print_options.
 912         (print_command_completer): New.
 913         (_initialize_printcmd): Install print_command_completer as
 914         handle_brkchars completer for the "print" command.  Update
 915         "print"'s help to include supported options.
 916         * valprint.c: Include "cli/cli-option.h".
 917         (show_vtblprint, show_objectprint, show_static_field_print): Moved
 918         here from cp-valprint.c.
 919         (boolean_option_def, uinteger_option_def)
 920         (value_print_option_defs, make_value_print_options_def_group):
 921         New.  Use gdb::option::add_setshow_cmds_for_options to install
 922         "set print elements", "set print null-stop", "set print repeats",
 923         "set print pretty", "set print union", "set print array", "set
 924         print address", "set print symbol", "set print array-indexes".
 925         * valprint.h: Include <string> and "cli/cli-option.h".
 926         (make_value_print_options_def_group): Declare.
 927         (print_value): Change parameter type from format_data pointer to
 928         value_print_options reference.
 929         (print_command_completer): Declare.
 930
 931 2019-06-13  Pedro Alves  <palves@redhat.com>
 932
 933         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
 934         (COMMON_SFILES): Add maint-test-settings.c.
 935         * cli/cli-decode.c (boolean_enums): New global, factored out from
 936         ...
 937         (add_setshow_boolean_cmd): ... here.
 938         * cli/cli-decode.h (boolean_enums): Declare.
 939         * cli/cli-option.c: New file.
 940         * cli/cli-option.h: New file.
 941         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
 942         factored out from ...
 943         (parse_cli_boolean_value(const char *)): ... this.
 944         (is_unlimited_literal): Change parameter type to pointer to
 945         pointer.  Adjust and advance ARG pointer.
 946         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 947         (parse_cli_var_enum): New, factored out from ...
 948         (do_set_command): ... this.  Adjust.
 949         * cli/cli-setshow.h (parse_cli_boolean_value)
 950         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 951         (parse_cli_var_enum): Declare.
 952         * cli/cli-utils.c: Include "cli/cli-option.h".
 953         (get_ulongest): New.
 954         * cli/cli-utils.h (get_ulongest): Declare.
 955         (check_for_argument): New overloads.
 956         * maint-test-options.c: New file.
 957
 958 2019-06-13  Pedro Alves  <palves@redhat.com>
 959
 960         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
 961         parse a range if "-" is at the end of the string.
 962
 963 2019-06-13  Pedro Alves  <palves@redhat.com>
 964
 965         * cli/cli-setshow.c (parse_auto_binary_operation)
 966         (parse_cli_boolean_value): Don't allow "o".
 967
 968 2019-06-13  Pedro Alves  <palves@redhat.com>
 969
 970         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
 971         * NEWS: Mention maint test-settings KIND.
 972         * maint-test-settings.c: New file.
 973
 974 2019-06-13  Pedro Alves  <palves@redhat.com>
 975
 976         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
 977         completer.
 978         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
 979         "set" completers.
 980
 981 2019-06-13  Pedro Alves  <palves@redhat.com>
 982
 983         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
 984         after item.
 985
 986 2019-06-13  Pedro Alves  <palves@redhat.com>
 987
 988         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
 989
 990 2019-06-13  Pedro Alves <palves@redhat.com>
 991
 992         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
 993         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
 994         call.
 995         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
 996         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
 997         calls.
 998         (check_for_argument): Skip spaces after argument.
 999
1000 2019-06-13  Pedro Alves  <palves@redhat.com>
1001
1002         * thread.c (thread_apply_command): Adjust TID parsing.
1003         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
1004         detected before end of string.
1005         (tid_is_in_list): Error out if LIST is invalid.
1006
1007 2019-06-13  Pedro Alves  <palves@redhat.com>
1008
1009         * completer.c (complete_line_internal_1): Rewind completion word
1010         point.
1011         (completion_tracker::advance_custom_word_point_by): Change
1012         parameter type to int.
1013         * completer.h (completion_tracker::advance_custom_word_point_by):
1014         Likewise.
1015
1016 2019-06-13  Pedro Alves  <palves@redhat.com>
1017
1018         * completer.c (advance_to_completion_word): Handle delimiters.
1019
1020 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
1021
1022         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
1023
1024 2019-06-11  Tom Tromey  <tom@tromey.com>
1025
1026         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
1027         (xmalloc_failed): Move to alloc.c.
1028         * alloc.c: New file.
1029         * Makefile.in (COMMON_SFILES): Add alloc.c.
1030
1031 2019-06-11  Tom Tromey  <tom@tromey.com>
1032
1033         * nat/linux-waitpid.c: Don't include server.h.
1034         (linux_debug): Remove.
1035         (my_waitpid): Update.
1036
1037 2019-06-11  Tom Tromey  <tromey@adacore.com>
1038
1039         * infcall.c (_initialize_infcall): Remove trailing newline from
1040         help.
1041         * user-regs.c (_initialize_user_regs): Remove trailing newline
1042         from help.
1043         * typeprint.c (_initialize_typeprint): Remove trailing newline
1044         from help.
1045         * reverse.c (_initialize_reverse): Remove trailing newlines from
1046         help.
1047         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
1048         from help.
1049         * language.c (add_set_language_command): Remove trailing newline
1050         from help.
1051         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
1052         help.
1053         * disasm.c (_initialize_disasm): Remove trailing newline from
1054         help.
1055         * top.c (init_main): Remove trailing newline from help.
1056         * interps.c (_initialize_interpreter): Remove trailing newline
1057         from help.
1058         * btrace.c (_initialize_btrace): Remove trailing newlines from
1059         help.
1060         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
1061         from help.
1062         * python/python.c (_initialize_python): Remove trailing newline
1063         from help.
1064         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
1065         help.
1066         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
1067         from help.  Reformat some text.
1068         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
1069         from help.
1070         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
1071         newline from help.
1072
1073 2019-06-11  Tom Tromey  <tromey@adacore.com>
1074
1075         * darwin-nat.c (darwin_decode_exception_message)
1076         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
1077
1078 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1079
1080         * valops.c (value_slice): Check for not allocated or not
1081         associated values.
1082
1083 2019-06-10  Tom de Vries  <tdevries@suse.de>
1084
1085         PR gdb/24618
1086         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
1087         sure an empty slot (defined by a 32-bit zero pair) is recognized as
1088         invalid.
1089
1090 2019-06-10  Tom de Vries  <tdevries@suse.de>
1091
1092         PR gdb/24611
1093         * linespec.c (linespec_lexer_lex_string): Remove incorrect
1094         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
1095
1096 2019-06-10  Tom de Vries  <tdevries@suse.de>
1097
1098         PR symtab/24545
1099         * symtab.c (struct demangled_name_entry): Add language field.
1100         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
1101         static minimal symbol".  Set and use language field.
1102
1103 2019-06-10  Tom Tromey  <tromey@adacore.com>
1104
1105         * ada-lang.c (_initialize_ada_language): Update help text.
1106
1107 2019-06-10  Tom Tromey  <tromey@adacore.com>
1108
1109         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
1110         with a newline.
1111         * guile/guile.c (handle_boot_error): Don't end warning with a
1112         newline.
1113         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
1114         warning with a newline.
1115         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
1116         newline.
1117         (s12z_frame_cache): Likewise.
1118         * dwarf-index-cache.c (index_cache::store): Don't end warning with
1119         a newline.
1120         * solib-svr4.c (disable_probes_interface): Don't end warning with
1121         a newline.
1122         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
1123         newline.
1124         * python/python.c (do_finish_initialization): Don't end warning
1125         with a newline.
1126
1127 2019-06-10  Tom Tromey  <tom@tromey.com>
1128
1129         * python/py-breakpoint.c (gdbpy_breakpoint_created)
1130         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
1131         gdbpy_enter.
1132
1133 2019-06-10  Tom Tromey  <tromey@adacore.com>
1134
1135         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
1136         data.
1137         (elf_new_init): Don't call stabsread_new_init.
1138         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
1139         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
1140         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
1141
1142 2019-06-10  Tom de Vries  <tdevries@suse.de>
1143
1144         PR symtab/16264
1145         PR symtab/24517
1146         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
1147
1148 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
1149
1150         * source.c (find_and_open_source): Also rewrite relative file
1151         names.
1152
1153 2019-04-26  Amos Bird  <amosbird@gmail.com>
1154
1155         * annotate.c (annotate_thread_exited): Add "thread-exited"
1156         annotation.
1157
1158 2019-06-06  Tom Tromey  <tromey@adacore.com>
1159
1160         * maint.h (class scoped_command_stats): Use
1161         DISABLE_COPY_AND_ASSIGN.
1162         <print_time>: New method.
1163         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
1164         print_time.
1165         (scoped_command_stats::print_time): New method.
1166
1167 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
1168
1169         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
1170         instructions of lengths 6 or 8 bytes.
1171
1172 2019-06-04  Pedro Alves  <palves@redhat.com>
1173
1174         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
1175
1176         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
1177         * breakpoint.c (condition_completer): Likewise.
1178         * cli/cli-dump.c (scan_expression): Likewise.
1179         * common/filestuff.c (mkdir_recursive): Likewise.
1180         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
1181         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
1182         (gdb_abspath): Likewise.
1183         * compile/compile-cplus-types.c
1184         (compile_cplus_instance::decl_name): Likewise.
1185         * completer.c (complete_explicit_location):
1186         (signal_completer, reg_or_group_completer_1): Likewise.
1187         * cp-support.c (cp_remove_params_if_any): Likewise.
1188         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
1189         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
1190         * infcmd.c (strip_bg_char): Likewise.
1191         * linespec.c (copy_token_string): Likewise.
1192         * mi/mi-main.c (output_cores): Likewise.
1193         * psymtab.c (psymtab_search_name):
1194         * symfile.c (test_set_ext_lang_command): Likewise.
1195         * target.c (target_fileio_read_stralloc): Likewise.
1196         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
1197         * value.c (complete_internalvar): Likewise.
1198
1199 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
1200
1201         Add objfile property to gdb.Type.
1202         * NEWS: Mention Python API addition.
1203         * python/py-type.c (typy_get_objfile): New method.
1204
1205 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1206
1207         * NEWS: Mention the new set|show style [title|highlight].
1208         Mention changes to "show style", "help" and "apropos".
1209
1210 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1211
1212         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
1213         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
1214         instead of print_help_for_command.
1215         (print_doc_of_command): New function.
1216         (help_list): Add 'apropos -v word' suggestion.
1217         (print_help_for_command): Style the command name using title style.
1218         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
1219         (_initialize_cli_cmds): Describe -v in apropos_command help.
1220
1221 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1222
1223         * cli/cli-style.h (cli_style_option): Add name in constructor,
1224         add m_name class member, add constructor with intensity,
1225         add name class function.
1226         (cli_style_option::add_setshow_commands): Remove name argument.
1227         (highlight_style, title_style): New styles.
1228         * cli/cli-style.c (do_show): New function that shows a style
1229         characteristic styling the style name with itself.
1230         (set_style_name): New function.
1231         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
1232         Update all callers according to the changes in cli/cli-style.h.
1233         * utils.h (fputs_highlighted): New function.
1234         * utils.c (fputs_highlighted): Likewise.
1235
1236 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1237
1238         * NEWS: Mention new pipe command and new convenience variables.
1239
1240 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1241
1242         * cli/cli-cmds.c (pipe_command): New function.
1243         (_initialize_cli_cmds): Call add_com for pipe_command.
1244         Define | as an alias for pipe.
1245         (exit_status_set_internal_vars): New function.
1246         (shell_escape): Call exit_status_set_internal_vars.
1247         cli/cli-decode.c (find_command_name_length): Recognize | as
1248         a single character command.
1249
1250 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1251
1252         * gdbcmd.h (execute_command_to_ui_file): New declaration.
1253         top.c (execute_command_to_ui_file): New function, mostly a copy
1254         of execute_command_to_string.
1255         (execute_command_to_string): Implement by calling
1256         execute_command_to_ui_file.
1257
1258 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1259
1260         * top.h (saved_command_line): Remove declaration.
1261         * top.c (previous_saved_command_line, previous_repeat_arguments):
1262         New variables.
1263         (saved_command_line): Make static, define together with other
1264         'repeat variables'.
1265         (dont_repeat): Clear repeat_arguments.
1266         (repeat_previous, get_saved_command_line, save_command_line):
1267         New functions.
1268         (gdb_init): Initialize saved_command_line
1269         and previous_saved_command_line.
1270         * main.c (captured_main_1): Remove saved_command_line initialization.
1271         * event-top.c (handle_line_of_input): Update to use
1272         the new 'repeat' related functions instead of direct access to
1273         saved_command_line.
1274         * command.h (repeat_previous, get_saved_command_line,
1275         save_command_line): New declarations.
1276         (dont_repeat): Add comment.
1277
1278 2019-05-30  Tom Tromey  <tromey@adacore.com>
1279
1280         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
1281         Fix comment.
1282         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
1283
1284 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
1285
1286         PR cli/24587
1287         * completer.c (complete): Initialize variable word.
1288
1289 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
1290
1291         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1292         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
1293         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
1294         'body' is NULL to the outter 'if', protecting the '!is_define'
1295         situation as well.
1296
1297 2019-05-29  Tom Tromey  <tromey@adacore.com>
1298
1299         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
1300         (dwarf_unknown): New function.
1301         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
1302         (dwarf_type_encoding_name): Use dwarf_unknown.
1303
1304 2019-05-29  Tom Tromey  <tromey@adacore.com>
1305
1306         PR c++/20020:
1307         * cp-valprint.c (cp_print_value_fields): Call
1308         cp_print_static_field inside "try".
1309
1310 2019-05-29  Tom Tromey  <tromey@adacore.com>
1311
1312         * inflow.c (struct terminal_info): Add default operator=.
1313         * configure: Rebuild.
1314         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
1315         -Wdeprecated-copy-dtor, -Wredundant-move.
1316
1317 2019-05-29  Tom Tromey  <tromey@adacore.com>
1318
1319         * NEWS: Add entry.
1320         * infcmd.c (print_return_value_1): Handle finish_print
1321         option.
1322         (show_print_finish): New function.
1323         (_initialize_infcmd): Add "set/show print finish" commands.
1324         * valprint.c (user_print_options): Initialize new member.
1325         * valprint.h (struct value_print_options) <finish_print>: New
1326         member.
1327
1328 2019-05-28  Tom Tromey  <tromey@adacore.com>
1329
1330         * ada-lang.c (ada_remove_Xbn_suffix)
1331         (find_old_style_renaming_symbol)
1332         (parse_old_style_renaming): Remove.
1333         (ada_find_renaming_symbol): Don't call
1334         find_old_style_renaming_symbol.
1335         (ada_is_renaming_symbol): Rename from
1336         ada_find_renaming_symbol.  Remove "block" parameter.  Return
1337         bool.  Now static.
1338         (ada_read_var_value): Update and simplify.
1339         * ada-exp.y (write_var_or_type): Remove old code.
1340
1341 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
1342
1343         * event-top.c: Remove include comment.
1344         * inflow.c (class scoped_ignore_sigttou): Move from here...
1345         * inflow.h (class scoped_ignore_sigttou): ...to here.
1346         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
1347         * top.c:  Remove include comment.
1348
1349 2019-05-27  Tom Tromey  <tom@tromey.com>
1350
1351         * NEWS: Fix typo.
1352
1353 2019-05-22  Tom Tromey  <tromey@adacore.com>
1354
1355         * target.c (target_follow_exec): Constify parameter.
1356         * target-delegates.c: Rebuild.
1357         * remote.c (remote_target::follow_exec): Constify parameter.
1358         * infrun.c (follow_exec): Constify parameter.
1359         * target.h (struct target_ops) <follow_exec>: Constify parameter.
1360         (target_follow_exec): Likewise.
1361
1362 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1363
1364         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
1365         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
1366
1367 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1368
1369         * NEWS: Add debugredirect and testsuite sections.
1370
1371 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
1372
1373         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
1374         target descriptions using exclusively floating point register name
1375         aliases.
1376
1377 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
1378
1379         PR gdb/18644:
1380         * f-lang.c (build_fortran_types): Handle the case where
1381         gdbarch_floatformat_for_type returns a nullptr.
1382
1383 2019-05-21  Tom de Vries  <tdevries@suse.de>
1384
1385         PR cli/24587
1386         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
1387
1388 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1389
1390         PR gdb/18644:
1391         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
1392         16-byte floats.
1393         * i386-tdep.c (i386_floatformat_for_type): Use
1394         floatformats_ia64_quad for the 16-byte floating point component
1395         within a fortran 32-byte complex number.
1396
1397 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1398
1399         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
1400         delete default constructor.
1401         (find_partial_die): Update to return const struct.
1402         (partial_die_parent_scope): Move variable declaration into scope
1403         of its use and change its type to auto.
1404         (guess_partial_die_structure_name): Likewise.
1405         (partial_die_info::fixup): Likewise.
1406
1407 2019-05-17  Tom Tromey  <tromey@adacore.com>
1408
1409         * source.c (find_and_open_source): Remove cast.
1410
1411 2019-05-17  Tom Tromey  <tromey@adacore.com>
1412
1413         * annotate.c (annotate_source): Make "filename" const.
1414         * annotate.h (annotate_source): Use const.
1415
1416 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1417
1418         * disasm.c (set_disassembler_options): Send errors to stderr.
1419
1420 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1421
1422         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
1423         (cli_interp_base::set_logging): Check debug_redirect.
1424         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
1425         * cli/cli-logging.c (debug_redirect): Add static variable.
1426         (pop_output_files): Add default param.
1427         (handle_redirections): Print debug setting.
1428         (show_logging_command): Likewise.
1429         (_initialize_cli_logging): Add debugredirect command.
1430         * interps.c (current_interp_set_logging): Add debug_redirect
1431         parameter.
1432         * interps.h (set_logging): Add debug_redirect parameter.
1433         (current_interp_set_logging): Likewise.
1434         * mi/mi-common.h: Likewise.
1435         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
1436
1437 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1438             Tom Tromey  <tromey@adacore.com>
1439
1440         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
1441         directly.
1442         * cli/cli-interp.h (make_logging_output): Remove declaration.
1443         * cli/cli-logging.c (make_logging_output): Remove function.
1444         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
1445         directly.
1446         * ui-file.c (tee_file::tee_file): Remove bools.
1447         (tee_file::~tee_file): Remove deletes.
1448         * ui-file.h (tee_file): Remove bools.
1449
1450 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
1451
1452         * mi/mi-cmds.h (mi_cmd_complete): New function.
1453         * mi/mi-main.c (mi_cmd_complete): Likewise.
1454         * mi/mi-cmds.c: Define new MI command -complete.
1455         * NEWS: Mention new -complete command.
1456
1457 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
1458
1459         * completer.h (complete): New function.
1460         * completer.c (complete): Likewise.
1461         * cli/cli-cmds.c: (complete_command): Update to use new complete()
1462         function defined in completer.h.
1463
1464 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
1465
1466         * MAINTAINERS (Write After Approval): Add myself.
1467
1468 2019-05-17  Tom de Vries  <tdevries@suse.de>
1469
1470         PR gdb/24094
1471         * dwarf2read.c (struct cu_partial_die_info): New struct.
1472         (find_partial_die): Return cu_partial_die_info.
1473         (partial_die_parent_scope, guess_partial_die_structure_name)
1474         (partial_die_info::fixup): Handle new return type of find_partial_die.
1475
1476 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1477
1478         * stap-probe.c (stap_parse_register_operand): Make "regname" an
1479         "std::string", simplifying the algorithm.
1480
1481 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1482
1483         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
1484         (stap_static_probe_ops::get_probes): Likewise.
1485
1486 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1487
1488         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
1489         '-')" and "else if".
1490         (stap_parse_single_operand): Join checks for
1491         "gdbarch_stap_parse_special_token_p" and
1492         "gdbarch_stap_parse_special_token" in the same "if" statement.
1493         Invert check when verifying for operation on register
1494         displacement.
1495
1496 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1497
1498         * stap-probe.c (stap_get_opcode): Update comment.
1499         (stap_get_expected_argument_type): Likewise.
1500         (handle_stap_probe): Likewise.
1501
1502 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1503
1504         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
1505         return type to 'bool'.  Adjust comment.  Use 'bool' when
1506         appropriate.
1507         (i386_stap_parse_special_token_three_arg_disp): Likewise.
1508         * stap-probe.c (stap_parse_argument_1): Likewise.
1509         (stap_is_operator): Likewise.
1510         (stap_is_generic_prefix): Likewise.
1511         (stap_is_register_prefix): Likewise.
1512         (stap_is_register_indirection_prefix): Likewise.
1513         (stap_is_integer_prefix): Likewise.
1514         (stap_generic_check_suffix): Likewise.
1515         (stap_check_integer_suffix): Likewise.
1516         (stap_check_register_suffix): Likewise.
1517         (stap_check_register_indirection_suffix): Likewise.
1518         (stap_parse_register_operand): Likewise.
1519         (stap_parse_single_operand): Likewise.
1520         (stap_parse_argument_1): Likewise.
1521         (stap_probe::get_argument_count): Likewise.
1522         (stap_is_operator): Likewise.
1523
1524 2019-05-16  Tom Tromey  <tromey@adacore.com>
1525
1526         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
1527         keyword to foreach.
1528
1529 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
1530
1531         * linux-thread-db.c (try_thread_db_load_1): Change return type
1532         to bool.
1533         (try_thread_db_load): Likewise.
1534         (try_thread_db_load_from_pdir_1): Likewise.
1535         (try_thread_db_load_from_pdir): Likewise.
1536         (try_thread_db_load_from_sdir): Likewise.
1537         (try_thread_db_load_from_dir): Likewise.
1538         (thread_db_load_search): Likewise.
1539         (has_libpthread): Likewise.
1540         (thread_db_load): Likewise.
1541
1542 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
1543
1544         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1545         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
1546         NULL, and complain/return if that's the case.
1547
1548 2019-05-15  John Darrington <john@darrington.wattle.id.au>
1549
1550         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
1551         (advance, posn, abstract_read_memory): New functions.
1552         [struct mem_read_abstraction]: New struct.
1553         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
1554
1555 2019-05-14  Tom Tromey  <tromey@adacore.com>
1556
1557         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
1558         value is not lval_memory.
1559
1560 2019-05-14  Tom Tromey  <tromey@adacore.com>
1561
1562         * solib.c (info_sharedlibrary_command): Style the file name.
1563
1564 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
1565
1566         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
1567         (aarch64_vnv_type): Likewise.
1568         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
1569         * common/tdesc.c: Likewise.
1570         * common/tdesc.h (enum tdesc_type_kind): Likewise.
1571         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
1572         * features/aarch64-fpu.xml: Add ieee half view.
1573         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
1574         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
1575         * gdbtypes.h (struct builtin_type): Likewise.
1576         (struct objfile_type): Likewise.
1577
1578 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
1579
1580         * language.c (language_sniff_from_mangled_name): Fix "langauge"
1581         typo.
1582         * location.h (string_to_event_location): Likewise.
1583
1584 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
1585
1586         GDB 8.3 released.
1587
1588 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1589
1590         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
1591         New variable declaration.
1592         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
1593         New variable.
1594         (print_one_breakpoint): Use ui_out::test_flags and new global
1595         variable to compute use_fixed_output.
1596         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
1597         Remove.
1598         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
1599         (mi_multi_location_breakpoint_output_fixed): Remove.
1600         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
1601         new variable.
1602         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
1603         fix_multi_location_breakpoint_output flag if version >= 3.
1604         * ui-out.h (enum ui_out_flag)
1605         <fix_multi_location_breakpoint_output>: New enumerator.
1606
1607 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1608
1609         * contrib/cc-with-tweaks.sh: Validate dwz's work.
1610
1611 2019-05-10  Tom Tromey  <tromey@adacore.com>
1612
1613         * ada-lang.c (catch_ada_completer): New function.
1614         (_initialize_ada_language): Use it.
1615
1616 2019-05-10  Tom Tromey  <tromey@adacore.com>
1617
1618         * thread.c (print_thread_info): Make "requested_threads" const.
1619         * gdbthread.h (print_thread_info): Make "requested_threads"
1620         const.
1621         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
1622         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
1623
1624 2019-05-08  Tom Tromey  <tom@tromey.com>
1625
1626         * gdbtypes.c (objfile_type_data): Change type.
1627         (objfile_type, _initialize_gdbtypes): Update.
1628
1629 2019-05-08  Tom Tromey  <tom@tromey.com>
1630
1631         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
1632         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
1633         (_initialize_dwarf2_frame): Update.
1634
1635 2019-05-08  Tom Tromey  <tom@tromey.com>
1636
1637         * objc-lang.c (objc_objfile_data): Change type.
1638         (find_methods): Update.
1639         (_initialize_objc_lang): Remove.
1640
1641 2019-05-08  Tom Tromey  <tom@tromey.com>
1642
1643         * stabsread.c (rs6000_builtin_type_data): Change type.
1644         (rs6000_builtin_type, _initialize_stabsread): Update.
1645
1646 2019-05-08  Tom Tromey  <tom@tromey.com>
1647
1648         * mips-tdep.c (mips_pdr_data): Remove.
1649         (_initialize_mips_tdep): Update.
1650
1651 2019-05-08  Tom Tromey  <tom@tromey.com>
1652
1653         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
1654         (hppa_init_objfile_priv_data, read_unwind_info)
1655         (find_unwind_entry, _initialize_hppa_tdep): Update.
1656
1657 2019-05-08  Tom Tromey  <tom@tromey.com>
1658
1659         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
1660         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
1661         on obstack.
1662         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
1663
1664 2019-05-08  Tom Tromey  <tom@tromey.com>
1665
1666         * mdebugread.c (basic_type_data): Change type.
1667         (basic_type, _initialize_mdebugread): Update.
1668
1669 2019-05-08  Tom Tromey  <tom@tromey.com>
1670
1671         * common/gdb_unique_ptr.h (struct noop_deleter): New.
1672
1673 2019-05-08  Tom Tromey  <tom@tromey.com>
1674
1675         * nto-tdep.c (nto_inferior_data_reg): Change type.
1676         (nto_inferior_data): Update.
1677         (nto_inferior_data_cleanup, nto_new_inferior_data)
1678         (_initialize_nto_tdep): Remove.
1679         * nto-tdep.h (struct nto_inferior_data): Add initializers.
1680
1681 2019-05-08  Tom Tromey  <tom@tromey.com>
1682
1683         * ada-lang.c (struct ada_inferior_data): Add initializers.
1684         (ada_inferior_data): Change type.
1685         (ada_inferior_data_cleanup): Remove.
1686         (get_ada_inferior_data, ada_inferior_exit)
1687         (struct ada_pspace_data): Add initializers, destructor.
1688         (ada_pspace_data_handle): Change type.
1689         (get_ada_pspace_data): Update.
1690         (ada_pspace_data_cleanup): Remove.
1691
1692 2019-05-08  Tom Tromey  <tom@tromey.com>
1693
1694         * coffread.c (struct coff_symfile_info): Add initializers.
1695         (coff_objfile_data_key): Move lower.  Change type.
1696         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
1697         Update.
1698         (coff_free_info): Remove.
1699
1700 2019-05-08  Tom Tromey  <tom@tromey.com>
1701
1702         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
1703         (fbsd_pspace_data_handle): Move lower.  Change type.
1704         (get_fbsd_pspace_data): Update.
1705         (fbsd_pspace_data_cleanup): Remove.
1706         (_initialize_fbsd_tdep): Update.
1707
1708 2019-05-08  Tom Tromey  <tom@tromey.com>
1709
1710         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
1711         (get_ada_tasks_pspace_data): Update.
1712         (ada_tasks_pspace_data_cleanup): Remove.
1713         (_initialize_tasks): Update.
1714         (ada_tasks_inferior_data_handle): Change type.
1715         (get_ada_tasks_inferior_data): Update.
1716         (ada_tasks_inferior_data_cleanup): Remove.
1717         (struct ada_tasks_pspace_data): Add initializers.
1718
1719 2019-05-08  Tom Tromey  <tom@tromey.com>
1720
1721         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
1722         * symfile-debug.c (debug_sym_get_probes): Change type.
1723         * stap-probe.c (handle_stap_probe):
1724         (stap_static_probe_ops::get_probes): Change type.
1725         * probe.h (class static_probe_ops) <get_probes>: Change type.
1726         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
1727         (parse_probes_in_pspace): Update.
1728         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
1729         Update.
1730         (any_static_probe_ops::get_probes): Change type.
1731         * elfread.c (elfread_data): New typedef.
1732         (probe_key): Change type.
1733         (elf_get_probes): Likewise.  Update.
1734         (probe_key_free): Remove.
1735         (_initialize_elfread): Update.
1736         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
1737         Change type.
1738         (dtrace_process_dof_probe, dtrace_process_dof)
1739         (dtrace_static_probe_ops::get_probe): Change type.
1740
1741 2019-05-08  Tom Tromey  <tom@tromey.com>
1742
1743         * xcoffread.c (struct xcoff_symfile_info): Rename from
1744         coff_symfile_info.  Add initializers.
1745         (xcoff_objfile_data_key): Move lower.  Change type.
1746         (XCOFF_DATA): Rewrite.
1747         (xcoff_free_info): Remove.
1748         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
1749         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
1750         (xcoff_initial_scan): Update.
1751
1752 2019-05-08  Tom Tromey  <tom@tromey.com>
1753
1754         * solib-svr4.c (struct svr4_info): Add initializers and
1755         destructor.
1756         <probes_table>: Now an htab_up.
1757         (solib_svr4_pspace_data): Change type.
1758         (free_probes_table): Simplify.
1759         (~svr4_info): Rename from svr4_pspace_data_cleanup.
1760         (get_svr4_info, probes_table_htab_remove_objfile_probes)
1761         (probes_table_remove_objfile_probes, register_solib_event_probe)
1762         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
1763         (_initialize_svr4_solib): Update.
1764
1765 2019-05-08  Tom Tromey  <tom@tromey.com>
1766
1767         * remote.c (remote_pspace_data): Change type.
1768         (remote_pspace_data_cleanup): Remove.
1769         (get_remote_exec_file, set_pspace_remote_exec_file)
1770         (_initialize_remote): Update.
1771
1772 2019-05-08  Tom Tromey  <tom@tromey.com>
1773
1774         * breakpoint.c (breakpoint_objfile_key): Change type.
1775         (get_breakpoint_objfile_data): Update.
1776         (free_breakpoint_objfile_data): Remove.
1777         (_initialize_breakpoint): Update.
1778
1779 2019-05-08  Tom Tromey  <tom@tromey.com>
1780
1781         * linux-tdep.c (struct linux_info): Add initializers.
1782         (linux_inferior_data): Move.  Change type.
1783         (invalidate_linux_cache_inf): Update.
1784         (linux_inferior_data_cleanup): Remove.
1785         (get_linux_inferior_data, _initialize_linux_tdep): Update.
1786
1787 2019-05-08  Tom Tromey  <tom@tromey.com>
1788
1789         * auxv.c (auxv_inferior_data): Move.  Change type.
1790         (auxv_inferior_data_cleanup): Remove.
1791         (invalidate_auxv_cache_inf): Rewrite.
1792         (get_auxv_inferior_data, _initialize_auxv): Update.
1793
1794 2019-05-08  Tom Tromey  <tom@tromey.com>
1795
1796         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
1797         (symfile_debug_objfile_data_key): Change type.
1798         (symfile_debug_installed, debug_qf_has_symbols)
1799         (debug_qf_find_last_source_symtab)
1800         (debug_qf_forget_cached_source_info)
1801         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
1802         (debug_qf_print_stats, debug_qf_dump)
1803         (debug_qf_expand_symtabs_for_function)
1804         (debug_qf_expand_all_symtabs)
1805         (debug_qf_expand_symtabs_with_fullname)
1806         (debug_qf_map_matching_symbols)
1807         (debug_qf_expand_symtabs_matching)
1808         (debug_qf_find_pc_sect_compunit_symtab)
1809         (debug_qf_map_symbol_filenames)
1810         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
1811         (debug_sym_new_init, debug_sym_init, debug_sym_read)
1812         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
1813         (debug_sym_read_linetable, debug_sym_relocate): Update.
1814         (symfile_debug_free_objfile): Remove.
1815         (install_symfile_debug_logging, _initialize_symfile_debug):
1816         Update.
1817
1818 2019-05-08  Tom Tromey  <tom@tromey.com>
1819
1820         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
1821         allocate_on_obstack.
1822         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
1823         (get_dwarf2_per_objfile): Update.
1824         (set_dwarf2_per_objfile): Remove.
1825         (dwarf2_has_info, dwarf2_get_section_info): Update.
1826         (dwarf2_free_objfile): Remove.
1827         (_initialize_dwarf2_read): Update.
1828
1829 2019-05-08  Tom Tromey  <tom@tromey.com>
1830
1831         * auto-load.c (struct auto_load_pspace_info): Add destructor and
1832         initializers.
1833         <unsupported_script_warning_printed,
1834         script_not_found_warning_printed>: Now bool.
1835         (auto_load_pspace_data): Change type.
1836         (~auto_load_pspace_info): Rename from
1837         auto_load_pspace_data_cleanup.
1838         (get_auto_load_pspace_data, init_loaded_scripts_info)
1839         (clear_section_scripts, maybe_print_unsupported_script_warning)
1840         (maybe_print_script_not_found_warning, _initialize_auto_load):
1841         Update.
1842
1843 2019-05-08  Tom Tromey  <tom@tromey.com>
1844
1845         * objfiles.c (objfile_pspace_info): Add destructor and
1846         initializers.
1847         (objfiles_pspace_data): Change type.
1848         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
1849         (get_objfile_pspace_data): Update.
1850         (objfiles_bfd_data): Change type.
1851         (get_objfile_bfd_data): Update.
1852         (objfile_bfd_data_free, _initialize_objfiles): Remove.
1853
1854 2019-05-08  Tom Tromey  <tom@tromey.com>
1855
1856         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
1857         Change type.
1858         (get_catch_syscall_inferior_data): Update.
1859         (catch_syscall_inferior_data_cleanup): Remove.
1860         (_initialize_break_catch_syscall): Update.
1861
1862 2019-05-08  Tom Tromey  <tom@tromey.com>
1863
1864         * inflow.c (struct terminal_info): Add destructor and
1865         initializers.
1866         (inflow_inferior_data): Change type.
1867         (~terminal_info): Rename from inflow_inferior_data_cleanup.
1868         (get_inflow_inferior_data, inflow_inferior_exit)
1869         (swap_terminal_info, _initialize_inflow): Update.
1870
1871 2019-05-08  Tom Tromey  <tom@tromey.com>
1872
1873         * target-dcache.c (target_dcache_cleanup): Remove.
1874         (target_dcache_aspace_key): Change type.
1875         (target_dcache_init_p, target_dcache_invalidate)
1876         (target_dcache_get, target_dcache_get_or_init)
1877         (_initialize_target_dcache): Update.
1878         * dcache.h (struct dcache_deleter): New.
1879
1880 2019-05-08  Tom Tromey  <tom@tromey.com>
1881
1882         * symtab.c (struct symbol_cache): Add destructor and
1883         initializers.
1884         (symbol_cache_key): Move.  Change type.
1885         (make_symbol_cache, free_symbol_cache): Remove.
1886         (get_symbol_cache): Update.
1887         (symbol_cache_cleanup): Remove.
1888         (ALL_PSPACES, symbol_cache_flush)
1889         (maintenance_print_symbol_cache)
1890         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
1891         Update.
1892
1893 2019-05-08  Tom Tromey  <tom@tromey.com>
1894
1895         * symtab.c (struct main_info): Add destructor and initializers.
1896         (main_progspace_key): Move.  Change type.
1897         (get_main_info): Update.
1898         (main_info_cleanup): Remove.
1899         (_initialize_symtab): Update.
1900
1901 2019-05-08  Tom Tromey  <tom@tromey.com>
1902
1903         * registry.h (DECLARE_REGISTRY): Define the _key class.
1904
1905 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1906
1907         * NEWS: Merge two 'New commands' sections.
1908
1909 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
1910
1911         * ada-valprint.c (ada_val_print_gnat_array): Remove language
1912         parameter and use Ada language definition instead.
1913         (ada_val_print_ptr): Remove unused language parameter.
1914         (ada_val_print_num): Remove language parameter and use Ada language
1915         definition instead.
1916         (ada_val_print_enum, ada_val_print_flt): Remove unused language
1917         parameter.
1918         (ada_val_print_struct_union, ada_val_print_ref): Remove language
1919         parameter and use Ada language definition instead.
1920         (ada_val_print_1): Update all ada_val_print_xxx calls.
1921         Remove language parameter.
1922         (ada_val_print): Update ada_val_print_1 call.
1923
1924 2019-05-08  Tom Tromey  <tromey@adacore.com>
1925
1926         * remote.c (remote_hw_watchpoint_limit)
1927         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
1928         Now static.
1929
1930 2019-05-08  Tom Tromey  <tromey@adacore.com>
1931
1932         * maint.c (_initialize_maint_cmds): Move initialization code to
1933         remote.c.
1934         (watchdog, show_watchdog): Move to remote.c.
1935         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
1936         "watchdog" static.
1937         (_initialize_remote): Move initialization code from maint.c.
1938         * defs.h (watchdog): Don't declare.
1939
1940 2019-05-08  Tom Tromey  <tromey@adacore.com>
1941
1942         * tui/tui-interp.c: Include main.h.
1943         * interps.c: Include main.h.
1944         * main.h (interpreter_p): Declare.
1945         * defs.h (interpreter_p): Don't declare.
1946
1947 2019-05-08  Tom Tromey  <tromey@adacore.com>
1948
1949         * dwarf2loc.c: Include dwarf2read.h.
1950         * defs.h (read_unsigned_leb128): Don't declare.
1951         * dwarf2read.h (read_unsigned_leb128): Declare.
1952
1953 2019-05-08  Tom Tromey  <tromey@adacore.com>
1954
1955         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
1956         method.
1957
1958 2019-05-08  Tom Tromey  <tromey@adacore.com>
1959
1960         * utils.c (fputs_maybe_filtered): Reset style after paging, even
1961         when no wrap column is set.
1962
1963 2019-05-08  Tom Tromey  <tromey@adacore.com>
1964
1965         * c-lang.c (c_get_string): Handle non-C-style arrays.
1966
1967 2019-05-08  Tom Tromey  <tromey@adacore.com>
1968
1969         * typeprint.c (print_offset_data::update): Print the bit offset,
1970         not the number of bits remaining.
1971
1972 2019-05-08  Tom Tromey  <tromey@adacore.com>
1973
1974         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
1975         padding at end of comment.
1976
1977 2019-05-08  Tom Tromey  <tromey@adacore.com>
1978
1979         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
1980         Compare main types.
1981
1982 2019-05-06  Tom Tromey  <tom@tromey.com>
1983
1984         * common/scoped_mmap.c: Include common-defs.h.
1985         * common/scoped_mmap.h: Don't include config.h.
1986
1987 2019-05-04  Tom Tromey  <tom@tromey.com>
1988
1989         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
1990         (struct aarch64_call_info): Add initializers.
1991         <si>: Now a std::vector.
1992         (pass_on_stack, aarch64_push_dummy_call): Update.
1993
1994 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
1995             Tom Tromey  <tom@tromey.com>
1996
1997         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
1998         (ppc_threads): Now a std::vector.  Now static.
1999         (hwdebug_find_thread_points_by_tid)
2000         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
2001         Update.
2002
2003 2019-05-04  Tom Tromey  <tom@tromey.com>
2004
2005         * arc-tdep.c (arc_tdesc_init): Return bool.
2006
2007 2019-05-04  Tom Tromey  <tom@tromey.com>
2008
2009         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
2010         Use gdb_assert_not_reached.
2011
2012 2019-05-04  Tom Tromey  <tom@tromey.com>
2013
2014         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
2015         "false".
2016
2017 2019-05-04  Tom Tromey  <tom@tromey.com>
2018
2019         * arc-tdep.c (arc_tdesc_init): Use bool.
2020
2021 2019-05-04  Tom Tromey  <tom@tromey.com>
2022
2023         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
2024
2025 2019-05-04  Tom Tromey  <tom@tromey.com>
2026
2027         * cli/cli-cmds.c (valid_command_p): Return bool.
2028
2029 2019-05-04  Tom Tromey  <tom@tromey.com>
2030
2031         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
2032         * command.h (valid_user_defined_cmd_name_p): Channge return type.
2033
2034 2019-05-04  Raul Tambre  <raul@tambre.ee>
2035
2036         * python/lib/gdb/prompt.py (_ExtendedPrompt)
2037         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
2038         operator for comparison.
2039
2040 2019-05-04  Tom Tromey  <tom@tromey.com>
2041
2042         * psymtab.c (psymbol_name_matches, match_partial_symbol)
2043         (lookup_partial_symbol, print_partial_symbols)
2044         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
2045         (psymbol_compare): Update.
2046         (add_psymbol_to_bcache): Clear the entire psymbol.
2047         (maintenance_check_psymtabs): Update.
2048         * psympriv.h (struct partial_symbol): Don't derive from
2049         general_symbol_info.
2050         <obj_section, unrelocated_address, address,
2051         set_unrelocated_address>: Update.
2052         <ginfo>: New member.
2053         * dwarf-index-write.c (write_psymbols, debug_names::insert)
2054         (debug_names::write_psymbols): Update.
2055
2056 2019-05-04  Tom de Vries  <tdevries@suse.de>
2057
2058         * contrib/cc-with-tweaks.sh: Support -n arg.
2059
2060 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2061
2062         * corelow.c (core_target::detach): Ensure frame cache and
2063         register caches are cleared.
2064         inferior.c (exit_inferior_1): Likewise.
2065
2066 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
2067             Tom Tromey  <tom@tromey.com>
2068
2069         * dictionary.c (collate_pending_symbols_by_language): Remove
2070         "struct" from foreach.
2071         * symtab.c (lookup_global_symbol_from_objfile)
2072         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
2073         foreach.
2074         * ser-tcp.c (net_open): Remove "struct" from foreach.
2075         * objfiles.c (objfile_relocate, objfile_rebase)
2076         (objfile_has_symbols): Remove "struct" from foreach.
2077         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
2078         from foreach.
2079         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
2080         foreach.
2081         * darwin-nat.c (thread_info_from_private_thread_info): Remove
2082         "struct" from foreach.
2083         * ada-lang.c (create_excep_cond_exprs)
2084         (ada_exception_catchpoint_cond_string): Remove "struct" from
2085         foreach.
2086
2087 2019-05-03  Tom Tromey  <tromey@adacore.com>
2088
2089         * ada-exp.y (convert_char_literal): Check suffix of each
2090         enumerator.
2091
2092 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
2093
2094         PR ada/21406:
2095         * ada-exp.y (yywrap): Don't define.
2096         * ada-lex.l (%option): Add noyywrap
2097         (yywrap): Remove.
2098
2099 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
2100
2101         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
2102         _WIN32_WINNT to the XP level, unless already defined to a higher
2103         level.
2104
2105         * unittests/parse-connection-spec-selftests.c:
2106         * ser-tcp.c:
2107         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
2108         override.
2109
2110         * symfile.c (find_separate_debug_file): Remove colon from the
2111         drive spec of DOS/Windows file names of the target, so that the
2112         file name produced from DEBUGDIR and the target's directory will
2113         be valid on DOS/Windows systems.
2114
2115 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2116
2117         * rust-lang.c (val_print_struct): Handle printing structures
2118         containing strings.
2119
2120 2019-05-02  Tom Tromey  <tromey@adacore.com>
2121
2122         * valarith.c (_initialize_valarith): Remove.
2123
2124 2019-05-01  Tom Tromey  <tromey@adacore.com>
2125
2126         * ada-lang.c (ada_value_primitive_field): Treat more fields as
2127         bitfields.
2128
2129 2019-05-01  Tom Tromey  <tromey@adacore.com>
2130
2131         * ada-lang.c (ada_value_assign): Correctly compute starting offset
2132         for big-endian copies.
2133
2134 2019-04-30  Ali Tamur  <tamur@google.com>
2135         * gdb/dwarf2read.c (read_3_bytes): New declaration.
2136         (read_attribute_value): Added DW_FORM_strx1-4 cases.
2137         (read_3_bytes): New function.
2138
2139 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2140
2141         * windows-nat.c (main_thread_id): Delete.
2142         (handle_output_debug_string): Replace main_thread_id by
2143         current_event.dwThreadId.
2144         (fake_create_process): Likewise.
2145         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
2146         Do not set main_thread_id.
2147         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
2148         current_event.dwThreadId.
2149         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
2150
2151 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2152
2153         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
2154         Use current_event.dwThreadId instead of main_thread_id.
2155
2156 2019-04-30  Tom Tromey  <tromey@adacore.com>
2157
2158         * ada-lang.c (ada_lookup_simple_minsyms): New function.
2159         (create_excep_cond_exprs): Iterate over program spaces.
2160         (ada_exception_catchpoint_cond_string): Examine all minimal
2161         symbols for exception types.
2162
2163 2019-04-30  Tom Tromey  <tromey@adacore.com>
2164
2165         PR c++/24470:
2166         * dwarf2read.c (process_structure_scope): Handle case where type
2167         has template parameters but no symbol was created.
2168
2169 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2170             Chris January  <chris.january@arm.com>
2171
2172         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
2173         qualifier.
2174         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
2175
2176 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2177
2178         * f-typeprint.c (f_print_type): Update rules for printing
2179         whitespace.
2180         (f_type_print_varspec_suffix): Likewise.
2181
2182 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2183             Chris January  <chris.january@arm.com>
2184
2185         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
2186         function arguments.
2187
2188 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2189
2190         * f-lang.c (build_fortran_types): Change name of void type to
2191         lower case.
2192         * f-typeprint.c (f_type_print_base): Print the name of the void
2193         type, rather than a fixed string.
2194         * f-valprint.c (f_decorations): Use lower case void string.
2195
2196 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2197             Chris January  <chris.january@arm.com>
2198
2199         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
2200         types for Fortran.
2201
2202 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2203             Chris January  <chris.january@arm.com>
2204             David Lecomber  <david.lecomber@arm.com>
2205
2206         * f-exp.y (BINOP_INTRINSIC): New token.
2207         (exp): New parser rule handling BINOP_INTRINSIC.
2208         (f77_keywords): Add new builtin procedures.
2209         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
2210         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2211         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
2212         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2213         (print_unop_subexp_f): New function.
2214         (print_binop_subexp_f): New function.
2215         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2216         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2217         (dump_subexp_body_f): Likewise.
2218         (operator_check_f): Likewise.
2219         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2220         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
2221
2222 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2223
2224         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
2225         UNOP_KIND.
2226         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
2227         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
2228         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
2229         (operator_length_f): New fuction.
2230         (print_subexp_f): New function.
2231         (op_name_f): New function.
2232         (dump_subexp_body_f): New function.
2233         (operator_check_f): New function.
2234         (exp_descriptor_f): Replace standard expression handling functions
2235         with new functions.
2236         * gdb/fortran-operator.def: New file.
2237         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
2238         * gdb/std-operator.def: Remove UNOP_KIND.
2239
2240 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2241
2242         * std-operator.def: Remove unbalanced, stray double quote
2243         character.
2244
2245 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2246             Chris January  <chris.january@arm.com>
2247             Daniel Everett  <daniel.everett@arm.com>
2248             Nick Forrington  <nick.forrington@arm.com>
2249             Richard Bunt  <richard.bunt@arm.com>
2250
2251         * cp-valprint.c (cp_print_value_fields): Allow an additional level
2252         of depth when printing anonymous structs or unions.
2253         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
2254         Don't print either the top-level value, or the children if the
2255         max-depth is exceeded.
2256         (ppscm_print_children): When printing the key of a map, allow one
2257         extra level of depth.
2258         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
2259         print either the top-level value, or the children if the max-depth
2260         is exceeded.
2261         (print_children): When printing the key of a map, allow one extra
2262         level of depth.
2263         * python/py-value.c (valpy_format_string): Add max_depth keyword.
2264         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
2265         (user_print_options): Initialise max_depth field.
2266         (val_print_scalar_or_string_type_p): New function.
2267         (val_print): Check to see if the max depth has been reached.
2268         (val_print_check_max_depth): Define new function.
2269         (show_print_max_depth): New function.
2270         (_initialize_valprint): Add 'print max-depth' option.
2271         * valprint.h (struct value_print_options) <max_depth>: New field.
2272         (val_print_check_max_depth): Declare new function.
2273         * NEWS: Document new feature.
2274
2275 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2276
2277         * ada-lang.c (ada_language_defn): Initialise new field.
2278         * c-lang.c (c_is_string_type_p): New function.
2279         (c_language_defn): Initialise new field.
2280         (cplus_language_defn): Initialise new field.
2281         (asm_language_defn): Initialise new field.
2282         (minimal_language_defn): Initialise new field.
2283         * c-lang.h (c_is_string_type_p): Declare new function.
2284         * d-lang.c (d_language_defn): Initialise new field.
2285         * f-lang.c (f_is_string_type_p): New function.
2286         (f_language_defn): Initialise new field.
2287         * go-lang.c (go_is_string_type_p): New function.
2288         (go_language_defn): Initialise new field.
2289         * language.c (default_is_string_type_p): New function.
2290         (unknown_language_defn): Initialise new field.
2291         (auto_language_defn): Initialise new field.
2292         * language.h (struct language_defn) <la_is_string_type_p>: New
2293         member variable.
2294         (default_is_string_type_p): Declare new function.
2295         * m2-lang.c (m2_language_defn): Initialise new field.
2296         * objc-lang.c (objc_language_defn): Initialise new field.
2297         * opencl-lang.c (opencl_language_defn): Initialise new field.
2298         * p-lang.c (pascal_is_string_type_p): New function.
2299         (pascal_language_defn): Initialise new field.
2300         * rust-lang.c (rust_is_string_type_p): New function.
2301         (rust_language_defn): Initialise new field.
2302
2303 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2304
2305         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
2306         New field.
2307         * ada-lang.c (ada_language_defn): Initialise new field.
2308         * c-lang.c (c_language_defn): Likewise.
2309         (cplus_language_defn): Likewise.
2310         (asm_language_defn): Likewise.
2311         (minimal_language_defn): Likewise.
2312         * d-lang.c (d_language_defn): Likewise.
2313         * f-lang.c (f_language_defn): Likewise.
2314         * go-lang.c (go_language_defn): Likewise.
2315         * language.c (unknown_language_defn): Likewise.
2316         (auto_language_defn): Likewise.
2317         * m2-lang.c (m2_language_defn): Likewise.
2318         * objc-lang.c (objc_language_defn): Likewise.
2319         * opencl-lang.c (opencl_language_defn): Likewise.
2320         * p-lang.c (pascal_language_defn): Likewise.
2321         * rust-lang.c (rust_language_defn): Likewise.
2322
2323 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2324
2325         * ada-lang.c (ada_is_character_type): Change return type to bool.
2326         (ada_is_string_type): Likewise.
2327         * ada-lang.h (ada_is_character_type): Update declaration
2328         (ada_is_string_type): Likewise.
2329
2330 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2331
2332         Support style in 'frame|thread apply'
2333
2334         * gdbcmd.h (execute_command_to_string): New term_out parameter.
2335         * record.c (record_start, record_stop): Update callers of
2336         execute_command_to_string with false.
2337         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
2338         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
2339         methods.
2340         (class string_file): New constructor with term_out parameter.
2341         Override methods term_out and can_emit_style_escape.  New member
2342         term_out.
2343         (class stdio_file): Override can_emit_style_escape.
2344         (class tee_file): Override term_out and can_emit_style_escape.
2345         * utils.h (can_emit_style_escape): Remove.
2346         * utils.c (can_emit_style_escape): Likewise.
2347         Update all callers of can_emit_style_escape (SOMESTREAM) to
2348         SOMESTREAM->can_emit_style_escape.
2349         * source-cache.c (source_cache::get_source_lines): Likewise.
2350         * stack.c (frame_apply_command_count): Call execute_command_to_string
2351         passing the term_out characteristic of the current gdb_stdout.
2352         * thread.c (thr_try_catch_cmd): Likewise.
2353         * top.c (execute_command_to_string): pass term_out parameter
2354         to construct the string_file for the command output.
2355         * ui-file.c (term_cli_styling): New function (most code moved
2356         from utils.c can_emit_style_escape).
2357         (string_file::string_file, string_file::can_emit_style_escape,
2358         stdio_file::can_emit_style_escape, tee_file::term_out,
2359         tee_file::can_emit_style_escape): New functions.
2360
2361 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2362
2363         * NEWS: Mention the new set|show may-call-functions.
2364         * infcall.c (may_call_functions_p): New variable.
2365         (show_may_call_functions_p): New function.
2366         (call_function_by_hand_dummy): Throws an error if not
2367         may-call-functions.
2368         (_initialize_infcall): Call add_setshow_boolean_cmd for
2369         may-call-functions.
2370
2371 2019-04-25  Keith Seitz  <keiths@redhat.com>
2372
2373         PR c++/24367
2374         * cp-support.c (inspect_type): Don't attempt substitutions
2375         of symbol with the same name.
2376
2377 2019-04-25  Tom Tromey  <tromey@adacore.com>
2378
2379         PR gdb/24475:
2380         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
2381         static.
2382
2383 2019-04-25  Tom Tromey  <tromey@adacore.com>
2384
2385         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
2386         rvalue reference.
2387         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
2388         (gdb_xml_parser::parse): Use std::move.
2389         * python/python-internal.h (gdbpy_convert_exception): Take a const
2390         reference.
2391         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
2392         std::move.
2393         * python/py-utils.c (gdbpy_convert_exception): Take a const
2394         reference.
2395         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2396         Use std::move.
2397         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2398         Use std::move.
2399         * mi/mi-main.c (mi_print_exception): Take a const reference.
2400         * main.c (handle_command_errors): Take a const reference.
2401         * linespec.c (parse_linespec): Use std::move.
2402         * infcall.c (run_inferior_call): Use std::move.
2403         (call_function_by_hand_dummy): Use std::move.
2404         * exec.c (try_open_exec_file): Use std::move.
2405         * exceptions.h (exception_print, exception_fprintf)
2406         (exception_print_same): Update.
2407         * exceptions.c (print_exception, exception_print)
2408         (exception_fprintf, exception_print_same): Change parameters to
2409         const reference.
2410         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
2411         * common/new-op.c: Use std::move.
2412         * common/common-exceptions.h (struct gdb_exception): Add move
2413         constructor.
2414         (struct gdb_exception_error, struct gdb_exception_quit, struct
2415         gdb_quit_bad_alloc): Change constructor to move constructor.
2416         (throw_exception): Change parameter to rvalue reference.
2417         * common/common-exceptions.c (throw_exception): Take rvalue
2418         reference.
2419         * cli/cli-interp.c (safe_execute_command): Use std::move.
2420         * breakpoint.c (insert_bp_location, location_to_sals): Use
2421         std::move.
2422
2423 2019-04-25  Tom Tromey  <tromey@adacore.com>
2424
2425         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
2426         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
2427         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
2428         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
2429         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
2430         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
2431         guile/scm-value.c: Use unpack.
2432         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
2433         gdbscm_gdb_exception.
2434         (gdbscm_throw_gdb_exception): Likewise.
2435         (struct gdbscm_gdb_exception): New.
2436         (unpack): New function.
2437         (gdbscm_wrap): Use unpack.
2438
2439 2019-04-25  Tom Tromey  <tromey@adacore.com>
2440
2441         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2442         (gdb_rl_callback_handler): Use std::move.
2443         * common/common-exceptions.h (struct gdb_exception): Add move
2444         assignment operator.
2445         (throw_exception_sjlj): Change "exception" to const reference.
2446         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
2447         (throw_exception_sjlj): Change "exception" to const reference.
2448
2449 2019-04-25  Tom Tromey  <tromey@adacore.com>
2450
2451         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
2452         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
2453         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2454         Update.
2455         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2456         Update.
2457         * mi/mi-interp.c (mi_interp::exec): Update.
2458         * linespec.c (parse_linespec): Update.
2459         * infcall.c (run_inferior_call): Update.
2460         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
2461         * guile/scm-symbol.c (gdbscm_lookup_symbol)
2462         (gdbscm_lookup_global_symbol): Update.
2463         * guile/scm-param.c (gdbscm_parameter_value): Update.
2464         * guile/scm-frame.c (gdbscm_frame_read_register)
2465         (gdbscm_frame_read_var): Update.
2466         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
2467         * exec.c (try_open_exec_file): Update.
2468         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2469         (gdb_rl_callback_handler): Update.
2470         * common/common-exceptions.h (exception_none): Don't declare.
2471         * common/common-exceptions.c (exception_none): Don't define.
2472         (struct catcher) <exception>: Update.
2473         * cli/cli-interp.c (safe_execute_command): Update.
2474         * breakpoint.c (insert_bp_location, location_to_sals): Update.
2475
2476 2019-04-25  Ali Tamur  <tamur@google.com>
2477
2478         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
2479         (read_attribute_value): Likewise.
2480         (dwarf2_read_addr_index): Update comment.
2481         (read_str_index): Add DW_FORM_strx.
2482         (dwarf2_string_attr): Likewise.
2483         (dwarf2_const_value_attr): Likewise.
2484         (dump_die_shallow): Likewise.
2485         (dwarf2_fetch_constant_bytes): Likewise.
2486         (skip_form_bytes): Likewise.
2487         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
2488
2489 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
2490
2491         PR corefiles/11608
2492         PR corefiles/18187
2493         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
2494         OFFSET.  Verify if current mapping contains an ELF header.
2495         (linux_find_memory_regions_full): Adjust call to
2496         dump_mapping_p.
2497
2498 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
2499             Kang Li <kanglictf@gmail.com>
2500
2501         PR gdb/21600
2502
2503         * dwarf2-frame.c (read_initial_length): Be consistent about using
2504         unsigned representation of length.
2505         (decode_frame_entry_1): Likewise.  Check for wraparound of
2506         end pointer as well as buffer overflow.
2507
2508 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
2509
2510         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
2511         "vq".
2512
2513 2019-04-24  Tom Tromey  <tromey@adacore.com>
2514
2515         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
2516
2517 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2518
2519         * s12z-tdep.c (s12z_unwind_pc): Delete.
2520         (s12z_unwind_sp): Delete.
2521         (s12z_gdbarch_init): Don't register deleted functions with
2522         gdbarch.
2523
2524 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2525
2526         * rl78-tdep.c (rl78_unwind_sp): Delete.
2527         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
2528
2529 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2530
2531         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
2532         (xstormy16_unwind_pc): Delete.
2533         (xstormy16_dummy_id): Delete.
2534         (xstormy16_gdbarch_init): Don't register deleted functions with
2535         gdbarch.
2536
2537 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2538
2539         * vax-tdep.c (vax_unwind_pc): Delete.
2540         (vax_gdbarch_init): Don't register deleted function with gdbarch.
2541
2542 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2543
2544         * v850-tdep.c (v850_unwind_sp): Delete.
2545         (v850_unwind_pc): Delete.
2546         (v850_dummy_id): Delete.
2547         (v850_gdbarch_init): Don't register deleted functions with
2548         gdbarch.
2549
2550 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2551
2552         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
2553         (tilegx_unwind_pc): Delete.
2554         (tilegx_unwind_dummy_id): Delete.
2555         (tilegx_gdbarch_init): Don't register deleted functions with
2556         gdbarch.
2557
2558 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2559
2560         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
2561         (tic6x_dummy_id): Delete.
2562         (tic6x_gdbarch_init): Don't register deleted functions with
2563         gdbarch.
2564
2565 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2566
2567         * sparc-tdep.c (sparc_unwind_pc): Delete.
2568         (sparc32_gdbarch_init): Don't register deleted function with
2569         gdbarch.
2570
2571 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2572
2573         * sh-tdep.c (sh_unwind_sp): Delete.
2574         (sh_unwind_pc): Delete.
2575         (sh_dummy_id): Delete.
2576         (sh_gdbarch_init): Don't register deleted functions with
2577         gdbarch.
2578
2579 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2580
2581         * score-tdep.c (score_unwind_sp): Delete.
2582         (score_unwind_pc): Delete.
2583         (score_dummy_id): Delete.
2584         (score_gdbarch_init): Don't register deleted functions with
2585         gdbarch.
2586
2587 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2588
2589         * rx-tdep.c (rx_unwind_pc): Delete.
2590         (rx_unwind_sp): Delete.
2591         (rx_dummy_id): Delete.
2592         (rx_gdbarch_init): Don't register deleted functions with
2593         gdbarch.  Update comment.
2594
2595 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2596
2597         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
2598         (rs6000_dummy_id): Delete.
2599         (rs6000_gdbarch_init): Don't register deleted functions with
2600         gdbarch.
2601
2602 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2603
2604         * or1k-tdep.c (or1k_dummy_id): Delete.
2605         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
2606
2607 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2608
2609         * nios2-tdep.c (nios2_dummy_id): Delete.
2610         (nios2_unwind_sp): Delete.
2611         (nios2_gdbarch_init): Don't register deleted functions with
2612         gdbarch.
2613
2614 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2615
2616         * nds32-tdep.c (nds32_dummy_id): Delete.
2617         (nds32_unwind_pc): Delete.
2618         (nds32_unwind_sp): Delete.
2619         (nds32_gdbarch_init): Don't register deleted functions with
2620         gdbarch.
2621
2622 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2623
2624         * msp430-tdep.c (msp430_unwind_pc): Delete.
2625         (msp430_unwind_sp): Delete.
2626         (msp430_dummy_id): Delete.
2627         (msp430_gdbarch_init): Don't register deleted functions with
2628         gdbarch.
2629
2630 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2631
2632         * moxie-tdep.c (moxie_unwind_sp): Delete.
2633         (moxie_unwind_pc): Delete.
2634         (moxie_dummy_id): Delete.
2635         (moxie_gdbarch_init): Don't register deleted functions with
2636         gdbarch.
2637
2638 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2639
2640         * mn10300-tdep.c (mn10300_dummy_id): Delete.
2641         (mn10300_unwind_pc): Delete.
2642         (mn10300_unwind_sp): Delete.
2643         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
2644         mn10300_unwind_sp.
2645         (mn10300_frame_unwind_init): Don't register deleted functions with
2646         gdbarch.
2647
2648 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2649
2650         * mep-tdep.c (mep_unwind_pc): Delete.
2651         (mep_unwind_sp): Delete.
2652         (mep_dummy_id): Delete.
2653         (mep_gdbarch_init): Don't register deleted functions with
2654         gdbarch.
2655
2656 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2657
2658         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
2659         (m68hc11_unwind_sp): Delete.
2660         (m68hc11_gdbarch_init): Don't register deleted functions with
2661         gdbarch.
2662
2663 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2664
2665         * m32r-tdep.c (m32r_unwind_sp): Delete.
2666         (m32r_unwind_pc): Delete.
2667         (m32r_dummy_id): Delete.
2668         (m32r_gdbarch_init): Don't register deleted functions with
2669         gdbarch.
2670
2671 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2672
2673         * m32c-tdep.c (m32c_unwind_pc): Delete.
2674         (m32c_unwind_sp): Delete.
2675         (m32c_dummy_id): Delete.
2676         (m32c_gdbarch_init): Don't register deleted functions with
2677         gdbarch.
2678
2679 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2680
2681         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
2682         (lm32_unwind_pc): Delete.
2683         (lm32_dummy_id): Delete.
2684         (lm32_gdbarch_init): Don't register deleted functions with
2685         gdbarch.
2686
2687 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2688
2689         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
2690         (iq2000_unwind_pc): Delete.
2691         (iq2000_dummy_id): Delete.
2692         (iq2000_gdbarch_init): Don't register deleted functions with
2693         gdbarch.
2694
2695 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2696
2697         * nds32-tdep.c (nds32_type_align): Delete.
2698         (nds32_push_dummy_call): Use type_align instead.
2699
2700 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2701
2702         * arm-tdep.c (arm_type_align): Only handle vector override case.
2703         (arm_push_dummy_call): Use type_align.
2704         (arm_gdbarch_init): Register arm_type_align gdbarch function.
2705
2706 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2707
2708         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
2709         case.
2710         (pass_on_stack): Use type_align.
2711         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
2712         function.
2713
2714 2019-04-23  Tom Tromey  <tromey@adacore.com>
2715
2716         * dwarf2read.c (line_header::file_name_at): Remove unused
2717         overload.
2718
2719 2019-04-23  Tom de Vries  <tdevries@suse.de>
2720
2721         PR gdb/24438
2722         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
2723         invocation.
2724
2725
2726 2019-03-27  Ali Tamur  <tamur@google.com>
2727
2728         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
2729         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
2730         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
2731         (dwarf_expr_context::get_addr_index): Likewise
2732         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
2733         (symbol_needs_eval_context::get_addr_index): Likewise
2734         (disassemble_dwarf_expression): Add DW_OP_addrx
2735         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
2736         (read_cutu_die_from_dwo): Update comment
2737         (skip_one_die): Add DW_FORM_addrx
2738         (read_attribute_value): Likewise
2739         (var_decode_location): Add DW_OP_addrx
2740         (dwarf2_const_value_attr): Add DW_FORM_addrx
2741         (dump_die_shallow): Likewise
2742         (dwarf2_fetch_constant_bytes): Likewise
2743         (decode_locdesc): Add DW_OP_addrx
2744         (skip_form_bytes): Add DW_FORM_addrx
2745
2746 2019-04-22  Ali Tamur  <tamur@google.com>
2747
2748         * MAINTAINERS (Write After Approval): Add self.
2749
2750 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
2751
2752         * solib-svr4.c (get_svr4_info): Add pspace parameter.
2753         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
2754         (open_symbol_file_object): Likewise.
2755         (svr4_default_sos): Add info parameter.
2756         (svr4_read_so_list): Likewise.
2757         (svr4_current_sos_direct): Adjust functions calls to pass down
2758         info.
2759         (svr4_current_sos_1): Add info parameter.
2760         (svr4_current_sos): Call get_svr4_info, pass info down to
2761         svr4_current_sos_1.
2762         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
2763         get_svr4_info.
2764         (svr4_in_dynsym_resolve_code): Pass current_program_space to
2765         get_svr4_info.
2766         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
2767         to get_svr4_info.
2768         (probes_table_remove_objfile_probes): Likewise.
2769         (register_solib_event_probe): Add info parameter.
2770         (solist_update_incremental): Pass info parameter down to
2771         svr4_read_so_list.
2772         (disable_probes_interface): Add info parameter.
2773         (svr4_handle_solib_event): Pass current_program_space to
2774         get_svr4_info.  Adjust disable_probes_interface cleanup.
2775         (svr4_create_probe_breakpoints): Add info parameter, pass it
2776         down to register_solib_event_probe.
2777         (svr4_create_solib_event_breakpoints): Add info parameter,
2778         pass it down to svr4_create_probe_breakpoints.
2779         (enable_break): Pass info down to
2780         svr4_create_solib_event_breakpoints.
2781         (svr4_solib_create_inferior_hook): Pass current_program_space to
2782         get_svr4_info.
2783         (svr4_clear_solib): Likewise.
2784
2785 2019-04-22  Pedro Alves  <palves@redhat.com>
2786
2787         * solib-svr4.c (svr4_free_objfile_observer): New.
2788         (probe_and_action::objfile): New field.
2789         (probes_table_htab_remove_objfile_probes)
2790         (probes_table_remove_objfile_probes): New functions.
2791         (register_solib_event_probe): Add 'objfile' parameter.  Store it
2792         in the new probe_and_action.  Don't store the probe in 'lookup'.
2793         (svr4_create_probe_breakpoints): Pass objfile to
2794         register_solib_event_probe.
2795         (_initialize_svr4_solib): Register a free_objfile observer.
2796
2797 2019-04-19  Tom Tromey  <tom@tromey.com>
2798
2799         * common/queue.h: Remove.
2800
2801 2019-04-19  Tom Tromey  <tom@tromey.com>
2802
2803         * event-loop.c: Don't include "common/queue.h".
2804
2805 2019-04-19  Tom Tromey  <tom@tromey.com>
2806
2807         * remote.c (remote_target): Use delete.
2808         * remote-notif.h: Include <list>, not "common/queue.h".
2809         (notif_client_p): Remove typedef.
2810         (remote_notif_state): Add constructor, destructor, initializer.
2811         <notif_queue>: Now a std::list.
2812         (remote_notif_state_xfree): Don't declare.
2813         * remote-notif.c (remote_notif_process, handle_notification)
2814         (remote_notif_state_allocate): Update.
2815         (~remote_notif_state): Rename from remote_notif_state_xfree.
2816
2817 2019-04-19  Tom Tromey  <tom@tromey.com>
2818
2819         * symfile.c (reread_symbols): Update.
2820         * objfiles.c (objfile_register_static_link)
2821         (objfile_lookup_static_link): Update
2822         (~objfile) Don't delete static_links.
2823         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
2824
2825 2019-04-19  Tom Tromey  <tom@tromey.com>
2826
2827         * type-stack.h (struct type_stack) <insert>: Constify string.
2828         * type-stack.c (type_stack::insert): Constify string.
2829         * gdbtypes.h (lookup_template_type): Update.
2830         (address_space_name_to_int): Update.
2831         * gdbtypes.c (address_space_name_to_int): Make space_identifier
2832         const.
2833         (lookup_template_type): Make name const.
2834         * c-exp.y: Update rules.
2835         (lex_one_token, classify_name, classify_inner_name)
2836         (c_print_token): Update.
2837         * p-exp.y: Update rules.
2838         (yylex): Update.
2839         * f-exp.y: Update rules.
2840         (yylex): Update.
2841         * d-exp.y: Update rules.
2842         (lex_one_token, classify_name, classify_inner_name): Update.
2843         * parse.c (write_dollar_variable, copy_name): Return std::string.
2844         * parser-defs.h (copy_name): Change return type.
2845         * m2-exp.y: Update rules.
2846         (yylex): Update.
2847         * go-exp.y (lex_one_token): Update.
2848         Update rules.
2849         (classify_unsafe_function, classify_packaged_name)
2850         (classify_name, yylex): Update.
2851
2852 2019-04-19  Sergei Trofimovich <siarheit@google.com>
2853
2854         * configure.ac: add --enable-source-highlight switch.
2855         * configure: Regenerate.
2856         * top.c (print_gdb_version): plumb --enable-source-highlight
2857         status to "show configuration".
2858
2859 2019-04-19  Tom Tromey  <tromey@adacore.com>
2860
2861         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
2862         Check ADA_TYPE_P.
2863         (empty_record, ada_template_to_fixed_record_type_1)
2864         (template_to_static_fixed_type)
2865         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
2866         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
2867         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
2868         macros.
2869
2870 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
2871
2872         PR symtab/24423:
2873         * source.c (print_source_lines_base): Advance "iter" when a
2874         control character is seen.
2875
2876 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2877
2878         * inferior.h (struct infcall_suspend_state_deleter):
2879         Catch exception in destructor to avoid crash.
2880
2881 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2882
2883         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
2884         close to the add_com "shell".
2885
2886 2019-04-18  Tom Tromey  <tromey@adacore.com>
2887
2888         * process-stratum-target.h (class process_stratum_target)
2889         <stratum>: Add "final".
2890
2891 2019-04-17  Tom Tromey  <tromey@adacore.com>
2892
2893         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
2894         against nullptr before use.
2895
2896 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
2897
2898         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
2899
2900 2019-04-17  Jim Wilson  <jimw@sifive.com>
2901             Andrew Burgess  <andrew.burgess@embecosm.com>
2902
2903         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
2904         code read might fail, assume 4-byte breakpoint in that case.
2905
2906 2019-04-15  Leszek Swirski  <leszeks@google.com>
2907
2908         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
2909         rather than a hand-rolled POD check when checking for forced MEMORY
2910         classification.
2911
2912 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2913
2914         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
2915         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
2916         function.
2917         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
2918         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
2919         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
2920         declaration.
2921
2922 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2923
2924         * aarch64-linux-nat.c
2925         (aarch64_linux_nat_target::thread_architecture): Add override.
2926         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
2927         each VQ.
2928
2929 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2930
2931         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
2932
2933 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
2934
2935         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
2936         target types of size 96-bits, add some additional comments, and
2937         check that the builtin type we found was the correct size.
2938
2939 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
2940
2941         * utils.c (prompt_for_continue): Don't restore the styling at the
2942         end, as applied_style has the wrong value.  This fixes styling in
2943         long lists of file names that are interrupted by the "Continue?"
2944         prompt.
2945
2946 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2947
2948         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
2949         * c-lang.c (c_language_defn): Likewise.
2950         (cplus_language_defn): Likewise.
2951         (asm_language_defn): Likewise.
2952         (minimal_language_defn): Likewise.
2953         * d-lang.c (d_language_defn): Likewise.
2954         * f-lang.c (f_language_defn): Likewise.
2955         * go-lang.c (go_language_defn): Likewise.
2956         * language.c (unknown_language_defn): Likewise.
2957         (auto_language_defn): Likewise.
2958         * language.h (struct language_defn): Remove la_magic field.
2959         (LANG_MAGIC): Delete.
2960         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
2961         * objc-lang.c (objc_language_defn): Likewise.
2962         * opencl-lang.c (opencl_language_defn): Likewise.
2963         * p-lang.c (pascal_language_defn): Likewise.
2964         * rust-lang.c (rust_language_defn): Likewise.
2965
2966 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2967
2968         * riscv-tdep.c (riscv_type_align): New function.
2969         (riscv_type_alignment): Delete.
2970         (riscv_arg_location): Use 'type_align'.
2971         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
2972
2973 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2974
2975         * gdbtypes.c (type_align): A struct with no non-static fields also
2976         has alignment of 1.
2977
2978 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2979
2980         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
2981         component to 0.
2982         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
2983         member.
2984         (riscv_struct_info::analyse): New implementation using new
2985         analyse_inner member function.
2986         (riscv_struct_info::field_offset): New member function.
2987         (riscv_struct_info::m_offsets): New member variable.
2988         (riscv_struct_info::analyse_inner): New private member function,
2989         takes the old implementation of riscv_struct_info::analyse but
2990         extended to track field offsets.
2991         (riscv_call_arg_struct): Update the struct folding special cases
2992         to handle cases where empty C++ structs, which are non-zero
2993         length, are found.
2994         (riscv_arg_location): Initialise the length of each location, a
2995         non-zero length now indicates the location is in use.
2996         (riscv_push_dummy_call): Allow for the first location having a
2997         non-zero offset when setting up arguments.
2998         (riscv_return_value): Likewise, but for return values.
2999
3000 2019-04-11  Tom Tromey  <tromey@adacore.com>
3001
3002         * utils.c (internal_vproblem): Make "msg" const.
3003
3004 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
3005
3006         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
3007         * trad-frame.c (trad_frame_reset_saved_regs): New function.
3008         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
3009         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
3010
3011 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
3012
3013         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
3014         function.
3015         (fill_gregset): Call amd64_linux_collect_native_gregset instead
3016         of amd64_collect_native_gregset.
3017         (amd64_linux_nat_target::store_registers): Likewise.
3018
3019 2019-04-10  Tom Tromey  <tom@tromey.com>
3020
3021         * symtab.c (lookup_global_symbol_from_objfile)
3022         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
3023         * objfiles.h (class separate_debug_iterator): New.
3024         (class separate_debug_range): New.
3025         (struct objfile) <separate_debug_objfiles>: New method.
3026         (objfile_separate_debug_iterate): Don't declare.
3027         * objfiles.c (separate_debug_iterator::operator++): Rename from
3028         objfile_separate_debug_iterate.
3029         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
3030         iterator.
3031         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
3032         iterator.
3033
3034 2019-04-10  Tom Tromey  <tom@tromey.com>
3035
3036         * symfile.c (reread_symbols): Remove old comment.
3037         * objfiles.c (free_all_objfiles): Fix a typo.
3038
3039 2019-04-10  Tom Tromey  <tom@tromey.com>
3040
3041         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
3042         * minsyms.c (lookup_minimal_symbol): Use foreach.
3043         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
3044         (lookup_minimal_symbol_solib_trampoline): Likewise.
3045         * symfile.c (reread_symbols): Use foreach.
3046
3047 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
3048             Tom Tromey  <tromey@adacore.com>
3049
3050         PR rust/24414:
3051         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
3052         (rust_lex_int_test): Change "value" to be LONGEST.
3053         (rust_lex_tests): Add test for long integer literal.
3054
3055 2019-04-09  Tom Tromey  <tromey@adacore.com>
3056
3057         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
3058         to bool.
3059         (extended_remote_target::attach): Update.
3060         (remote_target::remote_notice_new_inferior): Update.
3061         (remote_target::add_current_inferior_and_thread): Update.
3062         * inferior.c (exit_inferior_1): Use "false".
3063         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
3064
3065 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
3066
3067         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
3068         the "start" command.
3069
3070 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3071
3072         * python/py-inferior.c (infpy_thread_from_thread_handle):
3073         Adjust comments to reflect renaming of thread_from_thread_handle
3074         to thread_from_handle.  Adjust keywords.  Fix type error message.
3075         (inferior_object_methods): Add thread_from_handle.  Retain
3076         thread_from_thread_handle, but mark it as deprecated.
3077
3078 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3079
3080         * gdbthread.h (find_thread_by_handle): Revise declaration.
3081         * thread.c (find_thread_by_handle): Likewise.  Adjust
3082         implementation too.
3083         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
3084         support for buffer objects as handles.
3085
3086 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3087
3088         * python/py-infthread.c (thpy_thread_handle): New function.
3089         (thread_object_methods): Register thpy_thread_handle.
3090
3091 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3092
3093         * gdbthread.h (thread_to_thread_handle): Declare.
3094         * thread.c (gdbtypes.h): Include.
3095         (thread_to_thread_handle): New function.
3096
3097         * target.h (struct target_ops): Add thread_info_to_thread_handle.
3098         (target_thread_info_to_thread_handle): Declare.
3099         * target.c (target_thread_info_to_thread_handle): New function.
3100         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
3101         * target-delegates.c: Regenerate.
3102
3103         * linux-thread-db.c (class thread_db_target): Add method
3104         thread_info_to_thread_handle.
3105         (thread_db_target::thread_info_to_thread_handle): Define.
3106         * remote.c (class remote_target): Add new method
3107         thread_info_to_thread_handle.
3108         (remote_target::thread_info_to_thread_handle): Define.
3109
3110 2019-04-08  Pedro Alves  <palves@redhat.com>
3111
3112         * common/common-exceptions.c (throw_exception): Don't create
3113         named object to throw; throw directly.
3114         (throw_it): Likewise.  Don't initialize gdb_exception::message
3115         here, with new; pass FMT and AP to the ctor instead.
3116         * common/common-exceptions.h: Include <string>.
3117         (gdb_exception::gdb_exception(enum return_reason, enum errors,
3118         const char *, va_list)): New ctor.  Use std::make_shared.
3119         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
3120         errors)): Delete.
3121         (gdb_exception_error::gdb_exception_error(enum errors, const char
3122         *, va_list)): New.
3123         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
3124         Add assertion.
3125         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
3126         errors)): Delete.
3127         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
3128         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
3129         Add assertion.
3130
3131 2019-04-08  Tom Tromey  <tom@tromey.com>
3132
3133         * valops.c (value_rtti_indirect_type): Replace throw_exception
3134         with throw.
3135         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
3136         with throw.
3137         * thread.c (thr_try_catch_cmd): Replace throw_exception with
3138         throw.
3139         * target.c (target_translate_tls_address): Replace throw_exception
3140         with throw.
3141         * stack.c (frame_apply_command_count): Replace throw_exception
3142         with throw.
3143         * solib-spu.c (append_ocl_sos): Replace throw_exception with
3144         throw.
3145         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
3146         with throw.
3147         * rs6000-tdep.c (rs6000_frame_cache)
3148         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
3149         * remote.c: Replace throw_exception with throw.
3150         * record-full.c (record_full_message, record_full_wait_1)
3151         (record_full_restore): Replace throw_exception with throw.
3152         * record-btrace.c:
3153         (get_thread_current_frame_id, record_btrace_start_replaying)
3154         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
3155         (cmd_record_btrace_start): Replace throw_exception with throw.
3156         * parse.c (parse_exp_in_context_1): Replace throw_exception with
3157         throw.
3158         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
3159         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
3160         * linespec.c:
3161         (find_linespec_symbols): Replace throw_exception with throw.
3162         * infrun.c (displaced_step_prepare, resume): Replace
3163         throw_exception with throw.
3164         * infcmd.c (post_create_inferior): Replace throw_exception with
3165         throw.
3166         * inf-loop.c (inferior_event_handler): Replace throw_exception
3167         with throw.
3168         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
3169         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
3170         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
3171         (get_prev_frame_always, get_frame_pc_if_available)
3172         (get_frame_address_in_block_if_available, get_frame_language):
3173         Replace throw_exception with throw.
3174         * frame-unwind.c (frame_unwind_try_unwinder): Replace
3175         throw_exception with throw.
3176         * eval.c (fetch_subexp_value, evaluate_var_value)
3177         (evaluate_funcall, evaluate_subexp_standard): Replace
3178         throw_exception with throw.
3179         * dwarf2loc.c (call_site_find_chain)
3180         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
3181         Replace throw_exception with throw.
3182         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
3183         with throw.
3184         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
3185         throw.
3186         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
3187         * completer.c (complete_line_internal): Replace throw_exception
3188         with throw.
3189         * compile/compile-object-run.c (compile_object_run): Replace
3190         throw_exception with throw.
3191         * cli/cli-script.c (process_next_line): Replace throw_exception
3192         with throw.
3193         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
3194         (btrace_enable, btrace_maint_update_pt_packets): Replace
3195         throw_exception with throw.
3196         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
3197         throw_exception with throw.
3198         * break-catch-throw.c (re_set_exception_catchpoint): Replace
3199         throw_exception with throw.
3200         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
3201         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
3202         * aarch64-tdep.c (aarch64_make_prologue_cache)
3203         (aarch64_make_stub_cache): Replace throw_exception with throw.
3204
3205 2019-04-08  Tom Tromey  <tom@tromey.com>
3206
3207         * common/common-exceptions.c (throw_exception): Rename from
3208         throw_exception_cxx.  Remove old copy.  Make argument const.
3209         (throw_it): Create and throw exception objects directly.
3210         * common/common-exceptions.h (throw_exception): Make argument
3211         const.
3212         (struct gdb_exception_error): Add constructor.
3213         (struct gdb_exception_quit): Add constructor.
3214
3215 2019-04-08  Tom Tromey  <tom@tromey.com>
3216
3217         * common/common-exceptions.h (exception_rethrow): Don't declare.
3218         (TRY_SJLJ): Update comment.
3219         (TRY, CATCH, END_CATCH): Remove.
3220         * common/common-exceptions.c (exception_rethrow): Remove.
3221
3222 2019-04-08  Tom Tromey  <tom@tromey.com>
3223
3224         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
3225         Remove.
3226         (gdb_exception_error): Rename from
3227         gdb_exception_RETURN_MASK_ERROR.
3228         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
3229         (gdb_quit_bad_alloc): Update.
3230         * aarch64-tdep.c: Update.
3231         * ada-lang.c: Update.
3232         * ada-typeprint.c: Update.
3233         * ada-valprint.c: Update.
3234         * amd64-tdep.c: Update.
3235         * arch-utils.c: Update.
3236         * break-catch-throw.c: Update.
3237         * breakpoint.c: Update.
3238         * btrace.c: Update.
3239         * c-varobj.c: Update.
3240         * cli/cli-cmds.c: Update.
3241         * cli/cli-interp.c: Update.
3242         * cli/cli-script.c: Update.
3243         * common/common-exceptions.c: Update.
3244         * common/new-op.c: Update.
3245         * common/selftest.c: Update.
3246         * compile/compile-c-symbols.c: Update.
3247         * compile/compile-cplus-symbols.c: Update.
3248         * compile/compile-object-load.c: Update.
3249         * compile/compile-object-run.c: Update.
3250         * completer.c: Update.
3251         * corelow.c: Update.
3252         * cp-abi.c: Update.
3253         * cp-support.c: Update.
3254         * cp-valprint.c: Update.
3255         * darwin-nat.c: Update.
3256         * disasm-selftests.c: Update.
3257         * dtrace-probe.c: Update.
3258         * dwarf-index-cache.c: Update.
3259         * dwarf-index-write.c: Update.
3260         * dwarf2-frame-tailcall.c: Update.
3261         * dwarf2-frame.c: Update.
3262         * dwarf2loc.c: Update.
3263         * dwarf2read.c: Update.
3264         * eval.c: Update.
3265         * event-loop.c: Update.
3266         * event-top.c: Update.
3267         * exec.c: Update.
3268         * f-valprint.c: Update.
3269         * fbsd-tdep.c: Update.
3270         * frame-unwind.c: Update.
3271         * frame.c: Update.
3272         * gdbtypes.c: Update.
3273         * gnu-v3-abi.c: Update.
3274         * guile/guile-internal.h: Update.
3275         * guile/scm-block.c: Update.
3276         * guile/scm-breakpoint.c: Update.
3277         * guile/scm-cmd.c: Update.
3278         * guile/scm-disasm.c: Update.
3279         * guile/scm-frame.c: Update.
3280         * guile/scm-lazy-string.c: Update.
3281         * guile/scm-math.c: Update.
3282         * guile/scm-param.c: Update.
3283         * guile/scm-ports.c: Update.
3284         * guile/scm-pretty-print.c: Update.
3285         * guile/scm-symbol.c: Update.
3286         * guile/scm-symtab.c: Update.
3287         * guile/scm-type.c: Update.
3288         * guile/scm-value.c: Update.
3289         * i386-linux-tdep.c: Update.
3290         * i386-tdep.c: Update.
3291         * inf-loop.c: Update.
3292         * infcall.c: Update.
3293         * infcmd.c: Update.
3294         * infrun.c: Update.
3295         * jit.c: Update.
3296         * language.c: Update.
3297         * linespec.c: Update.
3298         * linux-fork.c: Update.
3299         * linux-nat.c: Update.
3300         * linux-tdep.c: Update.
3301         * linux-thread-db.c: Update.
3302         * main.c: Update.
3303         * mi/mi-cmd-break.c: Update.
3304         * mi/mi-cmd-stack.c: Update.
3305         * mi/mi-interp.c: Update.
3306         * mi/mi-main.c: Update.
3307         * objc-lang.c: Update.
3308         * p-valprint.c: Update.
3309         * parse.c: Update.
3310         * ppc-linux-tdep.c: Update.
3311         * printcmd.c: Update.
3312         * python/py-arch.c: Update.
3313         * python/py-breakpoint.c: Update.
3314         * python/py-cmd.c: Update.
3315         * python/py-finishbreakpoint.c: Update.
3316         * python/py-frame.c: Update.
3317         * python/py-framefilter.c: Update.
3318         * python/py-gdb-readline.c: Update.
3319         * python/py-inferior.c: Update.
3320         * python/py-infthread.c: Update.
3321         * python/py-lazy-string.c: Update.
3322         * python/py-linetable.c: Update.
3323         * python/py-objfile.c: Update.
3324         * python/py-param.c: Update.
3325         * python/py-prettyprint.c: Update.
3326         * python/py-progspace.c: Update.
3327         * python/py-record-btrace.c: Update.
3328         * python/py-record.c: Update.
3329         * python/py-symbol.c: Update.
3330         * python/py-type.c: Update.
3331         * python/py-unwind.c: Update.
3332         * python/py-utils.c: Update.
3333         * python/py-value.c: Update.
3334         * python/python.c: Update.
3335         * record-btrace.c: Update.
3336         * record-full.c: Update.
3337         * remote-fileio.c: Update.
3338         * remote.c: Update.
3339         * riscv-tdep.c: Update.
3340         * rs6000-aix-tdep.c: Update.
3341         * rs6000-tdep.c: Update.
3342         * rust-exp.y: Update.
3343         * rust-lang.c: Update.
3344         * s390-tdep.c: Update.
3345         * selftest-arch.c: Update.
3346         * solib-dsbt.c: Update.
3347         * solib-frv.c: Update.
3348         * solib-spu.c: Update.
3349         * solib-svr4.c: Update.
3350         * solib.c: Update.
3351         * sparc64-linux-tdep.c: Update.
3352         * stack.c: Update.
3353         * symfile-mem.c: Update.
3354         * symmisc.c: Update.
3355         * target.c: Update.
3356         * thread.c: Update.
3357         * top.c: Update.
3358         * tracefile-tfile.c: Update.
3359         * tui/tui.c: Update.
3360         * typeprint.c: Update.
3361         * unittests/cli-utils-selftests.c: Update.
3362         * unittests/parse-connection-spec-selftests.c: Update.
3363         * valops.c: Update.
3364         * valprint.c: Update.
3365         * value.c: Update.
3366         * varobj.c: Update.
3367         * windows-nat.c: Update.
3368         * x86-linux-nat.c: Update.
3369         * xml-support.c: Update.
3370
3371 2019-04-08  Tom Tromey  <tom@tromey.com>
3372
3373         * xml-support.c: Use C++ exception handling.
3374         * x86-linux-nat.c: Use C++ exception handling.
3375         * windows-nat.c: Use C++ exception handling.
3376         * varobj.c: Use C++ exception handling.
3377         * value.c: Use C++ exception handling.
3378         * valprint.c: Use C++ exception handling.
3379         * valops.c: Use C++ exception handling.
3380         * unittests/parse-connection-spec-selftests.c: Use C++ exception
3381         handling.
3382         * unittests/cli-utils-selftests.c: Use C++ exception handling.
3383         * typeprint.c: Use C++ exception handling.
3384         * tui/tui.c: Use C++ exception handling.
3385         * tracefile-tfile.c: Use C++ exception handling.
3386         * top.c: Use C++ exception handling.
3387         * thread.c: Use C++ exception handling.
3388         * target.c: Use C++ exception handling.
3389         * symmisc.c: Use C++ exception handling.
3390         * symfile-mem.c: Use C++ exception handling.
3391         * stack.c: Use C++ exception handling.
3392         * sparc64-linux-tdep.c: Use C++ exception handling.
3393         * solib.c: Use C++ exception handling.
3394         * solib-svr4.c: Use C++ exception handling.
3395         * solib-spu.c: Use C++ exception handling.
3396         * solib-frv.c: Use C++ exception handling.
3397         * solib-dsbt.c: Use C++ exception handling.
3398         * selftest-arch.c: Use C++ exception handling.
3399         * s390-tdep.c: Use C++ exception handling.
3400         * rust-lang.c: Use C++ exception handling.
3401         * rust-exp.y: Use C++ exception handling.
3402         * rs6000-tdep.c: Use C++ exception handling.
3403         * rs6000-aix-tdep.c: Use C++ exception handling.
3404         * riscv-tdep.c: Use C++ exception handling.
3405         * remote.c: Use C++ exception handling.
3406         * remote-fileio.c: Use C++ exception handling.
3407         * record-full.c: Use C++ exception handling.
3408         * record-btrace.c: Use C++ exception handling.
3409         * python/python.c: Use C++ exception handling.
3410         * python/py-value.c: Use C++ exception handling.
3411         * python/py-utils.c: Use C++ exception handling.
3412         * python/py-unwind.c: Use C++ exception handling.
3413         * python/py-type.c: Use C++ exception handling.
3414         * python/py-symbol.c: Use C++ exception handling.
3415         * python/py-record.c: Use C++ exception handling.
3416         * python/py-record-btrace.c: Use C++ exception handling.
3417         * python/py-progspace.c: Use C++ exception handling.
3418         * python/py-prettyprint.c: Use C++ exception handling.
3419         * python/py-param.c: Use C++ exception handling.
3420         * python/py-objfile.c: Use C++ exception handling.
3421         * python/py-linetable.c: Use C++ exception handling.
3422         * python/py-lazy-string.c: Use C++ exception handling.
3423         * python/py-infthread.c: Use C++ exception handling.
3424         * python/py-inferior.c: Use C++ exception handling.
3425         * python/py-gdb-readline.c: Use C++ exception handling.
3426         * python/py-framefilter.c: Use C++ exception handling.
3427         * python/py-frame.c: Use C++ exception handling.
3428         * python/py-finishbreakpoint.c: Use C++ exception handling.
3429         * python/py-cmd.c: Use C++ exception handling.
3430         * python/py-breakpoint.c: Use C++ exception handling.
3431         * python/py-arch.c: Use C++ exception handling.
3432         * printcmd.c: Use C++ exception handling.
3433         * ppc-linux-tdep.c: Use C++ exception handling.
3434         * parse.c: Use C++ exception handling.
3435         * p-valprint.c: Use C++ exception handling.
3436         * objc-lang.c: Use C++ exception handling.
3437         * mi/mi-main.c: Use C++ exception handling.
3438         * mi/mi-interp.c: Use C++ exception handling.
3439         * mi/mi-cmd-stack.c: Use C++ exception handling.
3440         * mi/mi-cmd-break.c: Use C++ exception handling.
3441         * main.c: Use C++ exception handling.
3442         * linux-thread-db.c: Use C++ exception handling.
3443         * linux-tdep.c: Use C++ exception handling.
3444         * linux-nat.c: Use C++ exception handling.
3445         * linux-fork.c: Use C++ exception handling.
3446         * linespec.c: Use C++ exception handling.
3447         * language.c: Use C++ exception handling.
3448         * jit.c: Use C++ exception handling.
3449         * infrun.c: Use C++ exception handling.
3450         * infcmd.c: Use C++ exception handling.
3451         * infcall.c: Use C++ exception handling.
3452         * inf-loop.c: Use C++ exception handling.
3453         * i386-tdep.c: Use C++ exception handling.
3454         * i386-linux-tdep.c: Use C++ exception handling.
3455         * guile/scm-value.c: Use C++ exception handling.
3456         * guile/scm-type.c: Use C++ exception handling.
3457         * guile/scm-symtab.c: Use C++ exception handling.
3458         * guile/scm-symbol.c: Use C++ exception handling.
3459         * guile/scm-pretty-print.c: Use C++ exception handling.
3460         * guile/scm-ports.c: Use C++ exception handling.
3461         * guile/scm-param.c: Use C++ exception handling.
3462         * guile/scm-math.c: Use C++ exception handling.
3463         * guile/scm-lazy-string.c: Use C++ exception handling.
3464         * guile/scm-frame.c: Use C++ exception handling.
3465         * guile/scm-disasm.c: Use C++ exception handling.
3466         * guile/scm-cmd.c: Use C++ exception handling.
3467         * guile/scm-breakpoint.c: Use C++ exception handling.
3468         * guile/scm-block.c: Use C++ exception handling.
3469         * guile/guile-internal.h: Use C++ exception handling.
3470         * gnu-v3-abi.c: Use C++ exception handling.
3471         * gdbtypes.c: Use C++ exception handling.
3472         * frame.c: Use C++ exception handling.
3473         * frame-unwind.c: Use C++ exception handling.
3474         * fbsd-tdep.c: Use C++ exception handling.
3475         * f-valprint.c: Use C++ exception handling.
3476         * exec.c: Use C++ exception handling.
3477         * event-top.c: Use C++ exception handling.
3478         * event-loop.c: Use C++ exception handling.
3479         * eval.c: Use C++ exception handling.
3480         * dwarf2read.c: Use C++ exception handling.
3481         * dwarf2loc.c: Use C++ exception handling.
3482         * dwarf2-frame.c: Use C++ exception handling.
3483         * dwarf2-frame-tailcall.c: Use C++ exception handling.
3484         * dwarf-index-write.c: Use C++ exception handling.
3485         * dwarf-index-cache.c: Use C++ exception handling.
3486         * dtrace-probe.c: Use C++ exception handling.
3487         * disasm-selftests.c: Use C++ exception handling.
3488         * darwin-nat.c: Use C++ exception handling.
3489         * cp-valprint.c: Use C++ exception handling.
3490         * cp-support.c: Use C++ exception handling.
3491         * cp-abi.c: Use C++ exception handling.
3492         * corelow.c: Use C++ exception handling.
3493         * completer.c: Use C++ exception handling.
3494         * compile/compile-object-run.c: Use C++ exception handling.
3495         * compile/compile-object-load.c: Use C++ exception handling.
3496         * compile/compile-cplus-symbols.c: Use C++ exception handling.
3497         * compile/compile-c-symbols.c: Use C++ exception handling.
3498         * common/selftest.c: Use C++ exception handling.
3499         * common/new-op.c: Use C++ exception handling.
3500         * cli/cli-script.c: Use C++ exception handling.
3501         * cli/cli-interp.c: Use C++ exception handling.
3502         * cli/cli-cmds.c: Use C++ exception handling.
3503         * c-varobj.c: Use C++ exception handling.
3504         * btrace.c: Use C++ exception handling.
3505         * breakpoint.c: Use C++ exception handling.
3506         * break-catch-throw.c: Use C++ exception handling.
3507         * arch-utils.c: Use C++ exception handling.
3508         * amd64-tdep.c: Use C++ exception handling.
3509         * ada-valprint.c: Use C++ exception handling.
3510         * ada-typeprint.c: Use C++ exception handling.
3511         * ada-lang.c: Use C++ exception handling.
3512         * aarch64-tdep.c: Use C++ exception handling.
3513
3514 2019-04-08  Tom Tromey  <tom@tromey.com>
3515
3516         * xml-support.c (gdb_xml_parser::parse): Update.
3517         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3518         * value.c (show_convenience): Update.
3519         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
3520         (test_parse_flags_qcs): Update.
3521         * thread.c (thr_try_catch_cmd): Update.
3522         * target.c (target_translate_tls_address): Update.
3523         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3524         (info_frame_command_core, frame_apply_command_count): Update.
3525         * rust-exp.y (rust_lex_exception_test): Update.
3526         * riscv-tdep.c (riscv_print_one_register_info): Update.
3527         * remote.c (remote_target::enable_btrace): Update.
3528         * record-btrace.c (record_btrace_enable_warn): Update.
3529         * python/py-utils.c (gdbpy_convert_exception): Update.
3530         * printcmd.c (do_one_display, print_variable_and_value): Update.
3531         * mi/mi-main.c (mi_print_exception): Update.
3532         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
3533         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3534         * linux-nat.c (linux_nat_target::attach): Update.
3535         * linux-fork.c (class scoped_switch_fork_info): Update.
3536         * infrun.c (displaced_step_prepare): Update.
3537         * infcall.c (call_function_by_hand_dummy): Update.
3538         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
3539         * gnu-v3-abi.c (print_one_vtable): Update.
3540         * frame.c (get_prev_frame_always): Update.
3541         * f-valprint.c (info_common_command_for_block): Update.
3542         * exec.c (try_open_exec_file): Update.
3543         * exceptions.c (print_exception, exception_print)
3544         (exception_fprintf, exception_print_same): Update.
3545         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
3546         * dwarf-index-cache.c (index_cache::store)
3547         (index_cache::lookup_gdb_index): Update.
3548         * darwin-nat.c (maybe_cache_shell): Update.
3549         * cp-valprint.c (cp_print_value_fields): Update.
3550         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
3551         (gcc_cplus_symbol_address): Update.
3552         * compile/compile-c-symbols.c (gcc_convert_symbol)
3553         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
3554         * common/selftest.c: Update.
3555         * common/common-exceptions.h (struct gdb_exception) <message>: Now
3556         a std::string.
3557         (exception_try_scope_entry, exception_try_scope_exit): Don't
3558         declare.
3559         (struct exception_try_scope): Remove.
3560         (TRY): Don't use exception_try_scope.
3561         (struct gdb_exception): Add constructor, operator=.
3562         <what>: New method.
3563         (struct gdb_exception_RETURN_MASK_ALL)
3564         (struct gdb_exception_RETURN_MASK_ERROR)
3565         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
3566         (struct gdb_quit_bad_alloc): Update.
3567         * common/common-exceptions.c (exception_none): Change
3568         initializer.
3569         (struct catcher) <state, exception>: Initialize inline.
3570         <prev>: Remove member.
3571         (current_catcher): Remove.
3572         (catchers): New global.
3573         (exceptions_state_mc_init): Simplify.
3574         (catcher_pop): Remove.
3575         (exceptions_state_mc, exceptions_state_mc_catch): Update.
3576         (try_scope_depth, exception_try_scope_entry)
3577         (exception_try_scope_exit): Remove.
3578         (throw_exception_sjlj): Update.
3579         (exception_messages, exception_messages_size): Remove.
3580         (throw_it): Simplify.
3581         (gdb_exception_sliced_copy): Remove.
3582         (throw_exception_cxx): Update.
3583         * cli/cli-script.c (script_from_file): Update.
3584         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
3585         Update.
3586         * ada-valprint.c (ada_val_print): Update.
3587         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
3588         (create_excep_cond_exprs): Update.
3589
3590 2019-04-08  Tom Tromey  <tom@tromey.com>
3591
3592         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
3593         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
3594         (TRY, CATCH, END_CATCH): Remove some definitions.
3595         * common/common-exceptions.c: Don't use GDB_XCPT.
3596         (catcher_list_size): Remove.
3597         (throw_exception, throw_it): Simplify.
3598
3599 2019-04-05  Tom Tromey  <tom@tromey.com>
3600
3601         Revert the header-sorting patch.
3602         * ft32-tdep.c: Revert.
3603         * frv-tdep.c: Revert.
3604         * frv-linux-tdep.c: Revert.
3605         * frame.c: Revert.
3606         * frame-unwind.c: Revert.
3607         * frame-base.c: Revert.
3608         * fork-child.c: Revert.
3609         * findvar.c: Revert.
3610         * findcmd.c: Revert.
3611         * filesystem.c: Revert.
3612         * filename-seen-cache.h: Revert.
3613         * filename-seen-cache.c: Revert.
3614         * fbsd-tdep.c: Revert.
3615         * fbsd-nat.h: Revert.
3616         * fbsd-nat.c: Revert.
3617         * f-valprint.c: Revert.
3618         * f-typeprint.c: Revert.
3619         * f-lang.c: Revert.
3620         * extension.h: Revert.
3621         * extension.c: Revert.
3622         * extension-priv.h: Revert.
3623         * expprint.c: Revert.
3624         * exec.h: Revert.
3625         * exec.c: Revert.
3626         * exceptions.c: Revert.
3627         * event-top.c: Revert.
3628         * event-loop.c: Revert.
3629         * eval.c: Revert.
3630         * elfread.c: Revert.
3631         * dwarf2read.h: Revert.
3632         * dwarf2read.c: Revert.
3633         * dwarf2loc.c: Revert.
3634         * dwarf2expr.h: Revert.
3635         * dwarf2expr.c: Revert.
3636         * dwarf2-frame.c: Revert.
3637         * dwarf2-frame-tailcall.c: Revert.
3638         * dwarf-index-write.h: Revert.
3639         * dwarf-index-write.c: Revert.
3640         * dwarf-index-common.c: Revert.
3641         * dwarf-index-cache.h: Revert.
3642         * dwarf-index-cache.c: Revert.
3643         * dummy-frame.c: Revert.
3644         * dtrace-probe.c: Revert.
3645         * disasm.h: Revert.
3646         * disasm.c: Revert.
3647         * disasm-selftests.c: Revert.
3648         * dictionary.c: Revert.
3649         * dicos-tdep.c: Revert.
3650         * demangle.c: Revert.
3651         * dcache.h: Revert.
3652         * dcache.c: Revert.
3653         * darwin-nat.h: Revert.
3654         * darwin-nat.c: Revert.
3655         * darwin-nat-info.c: Revert.
3656         * d-valprint.c: Revert.
3657         * d-namespace.c: Revert.
3658         * d-lang.c: Revert.
3659         * ctf.c: Revert.
3660         * csky-tdep.c: Revert.
3661         * csky-linux-tdep.c: Revert.
3662         * cris-tdep.c: Revert.
3663         * cris-linux-tdep.c: Revert.
3664         * cp-valprint.c: Revert.
3665         * cp-support.c: Revert.
3666         * cp-namespace.c: Revert.
3667         * cp-abi.c: Revert.
3668         * corelow.c: Revert.
3669         * corefile.c: Revert.
3670         * continuations.c: Revert.
3671         * completer.h: Revert.
3672         * completer.c: Revert.
3673         * complaints.c: Revert.
3674         * coffread.c: Revert.
3675         * coff-pe-read.c: Revert.
3676         * cli-out.h: Revert.
3677         * cli-out.c: Revert.
3678         * charset.c: Revert.
3679         * c-varobj.c: Revert.
3680         * c-valprint.c: Revert.
3681         * c-typeprint.c: Revert.
3682         * c-lang.c: Revert.
3683         * buildsym.c: Revert.
3684         * buildsym-legacy.c: Revert.
3685         * build-id.h: Revert.
3686         * build-id.c: Revert.
3687         * btrace.c: Revert.
3688         * bsd-uthread.c: Revert.
3689         * breakpoint.h: Revert.
3690         * breakpoint.c: Revert.
3691         * break-catch-throw.c: Revert.
3692         * break-catch-syscall.c: Revert.
3693         * break-catch-sig.c: Revert.
3694         * blockframe.c: Revert.
3695         * block.c: Revert.
3696         * bfin-tdep.c: Revert.
3697         * bfin-linux-tdep.c: Revert.
3698         * bfd-target.c: Revert.
3699         * bcache.c: Revert.
3700         * ax-general.c: Revert.
3701         * ax-gdb.h: Revert.
3702         * ax-gdb.c: Revert.
3703         * avr-tdep.c: Revert.
3704         * auxv.c: Revert.
3705         * auto-load.c: Revert.
3706         * arm-wince-tdep.c: Revert.
3707         * arm-tdep.c: Revert.
3708         * arm-symbian-tdep.c: Revert.
3709         * arm-pikeos-tdep.c: Revert.
3710         * arm-obsd-tdep.c: Revert.
3711         * arm-nbsd-tdep.c: Revert.
3712         * arm-nbsd-nat.c: Revert.
3713         * arm-linux-tdep.c: Revert.
3714         * arm-linux-nat.c: Revert.
3715         * arm-fbsd-tdep.c: Revert.
3716         * arm-fbsd-nat.c: Revert.
3717         * arm-bsd-tdep.c: Revert.
3718         * arch-utils.c: Revert.
3719         * arc-tdep.c: Revert.
3720         * arc-newlib-tdep.c: Revert.
3721         * annotate.h: Revert.
3722         * annotate.c: Revert.
3723         * amd64-windows-tdep.c: Revert.
3724         * amd64-windows-nat.c: Revert.
3725         * amd64-tdep.c: Revert.
3726         * amd64-sol2-tdep.c: Revert.
3727         * amd64-obsd-tdep.c: Revert.
3728         * amd64-obsd-nat.c: Revert.
3729         * amd64-nbsd-tdep.c: Revert.
3730         * amd64-nbsd-nat.c: Revert.
3731         * amd64-nat.c: Revert.
3732         * amd64-linux-tdep.c: Revert.
3733         * amd64-linux-nat.c: Revert.
3734         * amd64-fbsd-tdep.c: Revert.
3735         * amd64-fbsd-nat.c: Revert.
3736         * amd64-dicos-tdep.c: Revert.
3737         * amd64-darwin-tdep.c: Revert.
3738         * amd64-bsd-nat.c: Revert.
3739         * alpha-tdep.c: Revert.
3740         * alpha-obsd-tdep.c: Revert.
3741         * alpha-nbsd-tdep.c: Revert.
3742         * alpha-mdebug-tdep.c: Revert.
3743         * alpha-linux-tdep.c: Revert.
3744         * alpha-linux-nat.c: Revert.
3745         * alpha-bsd-tdep.c: Revert.
3746         * alpha-bsd-nat.c: Revert.
3747         * aix-thread.c: Revert.
3748         * agent.c: Revert.
3749         * addrmap.c: Revert.
3750         * ada-varobj.c: Revert.
3751         * ada-valprint.c: Revert.
3752         * ada-typeprint.c: Revert.
3753         * ada-tasks.c: Revert.
3754         * ada-lang.c: Revert.
3755         * aarch64-tdep.c: Revert.
3756         * aarch64-ravenscar-thread.c: Revert.
3757         * aarch64-newlib-tdep.c: Revert.
3758         * aarch64-linux-tdep.c: Revert.
3759         * aarch64-linux-nat.c: Revert.
3760         * aarch64-fbsd-tdep.c: Revert.
3761         * aarch64-fbsd-nat.c: Revert.
3762         * aarch32-linux-nat.c: Revert.
3763
3764 2019-04-05  Tom Tromey  <tom@tromey.com>
3765
3766         * ft32-tdep.c: Sort headers.
3767         * frv-tdep.c: Sort headers.
3768         * frv-linux-tdep.c: Sort headers.
3769         * frame.c: Sort headers.
3770         * frame-unwind.c: Sort headers.
3771         * frame-base.c: Sort headers.
3772         * fork-child.c: Sort headers.
3773         * findvar.c: Sort headers.
3774         * findcmd.c: Sort headers.
3775         * filesystem.c: Sort headers.
3776         * filename-seen-cache.h: Sort headers.
3777         * filename-seen-cache.c: Sort headers.
3778         * fbsd-tdep.c: Sort headers.
3779         * fbsd-nat.h: Sort headers.
3780         * fbsd-nat.c: Sort headers.
3781         * f-valprint.c: Sort headers.
3782         * f-typeprint.c: Sort headers.
3783         * f-lang.c: Sort headers.
3784         * extension.h: Sort headers.
3785         * extension.c: Sort headers.
3786         * extension-priv.h: Sort headers.
3787         * expprint.c: Sort headers.
3788         * exec.h: Sort headers.
3789         * exec.c: Sort headers.
3790         * exceptions.c: Sort headers.
3791         * event-top.c: Sort headers.
3792         * event-loop.c: Sort headers.
3793         * eval.c: Sort headers.
3794         * elfread.c: Sort headers.
3795         * dwarf2read.h: Sort headers.
3796         * dwarf2read.c: Sort headers.
3797         * dwarf2loc.c: Sort headers.
3798         * dwarf2expr.h: Sort headers.
3799         * dwarf2expr.c: Sort headers.
3800         * dwarf2-frame.c: Sort headers.
3801         * dwarf2-frame-tailcall.c: Sort headers.
3802         * dwarf-index-write.h: Sort headers.
3803         * dwarf-index-write.c: Sort headers.
3804         * dwarf-index-common.c: Sort headers.
3805         * dwarf-index-cache.h: Sort headers.
3806         * dwarf-index-cache.c: Sort headers.
3807         * dummy-frame.c: Sort headers.
3808         * dtrace-probe.c: Sort headers.
3809         * disasm.h: Sort headers.
3810         * disasm.c: Sort headers.
3811         * disasm-selftests.c: Sort headers.
3812         * dictionary.c: Sort headers.
3813         * dicos-tdep.c: Sort headers.
3814         * demangle.c: Sort headers.
3815         * dcache.h: Sort headers.
3816         * dcache.c: Sort headers.
3817         * darwin-nat.h: Sort headers.
3818         * darwin-nat.c: Sort headers.
3819         * darwin-nat-info.c: Sort headers.
3820         * d-valprint.c: Sort headers.
3821         * d-namespace.c: Sort headers.
3822         * d-lang.c: Sort headers.
3823         * ctf.c: Sort headers.
3824         * csky-tdep.c: Sort headers.
3825         * csky-linux-tdep.c: Sort headers.
3826         * cris-tdep.c: Sort headers.
3827         * cris-linux-tdep.c: Sort headers.
3828         * cp-valprint.c: Sort headers.
3829         * cp-support.c: Sort headers.
3830         * cp-namespace.c: Sort headers.
3831         * cp-abi.c: Sort headers.
3832         * corelow.c: Sort headers.
3833         * corefile.c: Sort headers.
3834         * continuations.c: Sort headers.
3835         * completer.h: Sort headers.
3836         * completer.c: Sort headers.
3837         * complaints.c: Sort headers.
3838         * coffread.c: Sort headers.
3839         * coff-pe-read.c: Sort headers.
3840         * cli-out.h: Sort headers.
3841         * cli-out.c: Sort headers.
3842         * charset.c: Sort headers.
3843         * c-varobj.c: Sort headers.
3844         * c-valprint.c: Sort headers.
3845         * c-typeprint.c: Sort headers.
3846         * c-lang.c: Sort headers.
3847         * buildsym.c: Sort headers.
3848         * buildsym-legacy.c: Sort headers.
3849         * build-id.h: Sort headers.
3850         * build-id.c: Sort headers.
3851         * btrace.c: Sort headers.
3852         * bsd-uthread.c: Sort headers.
3853         * breakpoint.h: Sort headers.
3854         * breakpoint.c: Sort headers.
3855         * break-catch-throw.c: Sort headers.
3856         * break-catch-syscall.c: Sort headers.
3857         * break-catch-sig.c: Sort headers.
3858         * blockframe.c: Sort headers.
3859         * block.c: Sort headers.
3860         * bfin-tdep.c: Sort headers.
3861         * bfin-linux-tdep.c: Sort headers.
3862         * bfd-target.c: Sort headers.
3863         * bcache.c: Sort headers.
3864         * ax-general.c: Sort headers.
3865         * ax-gdb.h: Sort headers.
3866         * ax-gdb.c: Sort headers.
3867         * avr-tdep.c: Sort headers.
3868         * auxv.c: Sort headers.
3869         * auto-load.c: Sort headers.
3870         * arm-wince-tdep.c: Sort headers.
3871         * arm-tdep.c: Sort headers.
3872         * arm-symbian-tdep.c: Sort headers.
3873         * arm-pikeos-tdep.c: Sort headers.
3874         * arm-obsd-tdep.c: Sort headers.
3875         * arm-nbsd-tdep.c: Sort headers.
3876         * arm-nbsd-nat.c: Sort headers.
3877         * arm-linux-tdep.c: Sort headers.
3878         * arm-linux-nat.c: Sort headers.
3879         * arm-fbsd-tdep.c: Sort headers.
3880         * arm-fbsd-nat.c: Sort headers.
3881         * arm-bsd-tdep.c: Sort headers.
3882         * arch-utils.c: Sort headers.
3883         * arc-tdep.c: Sort headers.
3884         * arc-newlib-tdep.c: Sort headers.
3885         * annotate.h: Sort headers.
3886         * annotate.c: Sort headers.
3887         * amd64-windows-tdep.c: Sort headers.
3888         * amd64-windows-nat.c: Sort headers.
3889         * amd64-tdep.c: Sort headers.
3890         * amd64-sol2-tdep.c: Sort headers.
3891         * amd64-obsd-tdep.c: Sort headers.
3892         * amd64-obsd-nat.c: Sort headers.
3893         * amd64-nbsd-tdep.c: Sort headers.
3894         * amd64-nbsd-nat.c: Sort headers.
3895         * amd64-nat.c: Sort headers.
3896         * amd64-linux-tdep.c: Sort headers.
3897         * amd64-linux-nat.c: Sort headers.
3898         * amd64-fbsd-tdep.c: Sort headers.
3899         * amd64-fbsd-nat.c: Sort headers.
3900         * amd64-dicos-tdep.c: Sort headers.
3901         * amd64-darwin-tdep.c: Sort headers.
3902         * amd64-bsd-nat.c: Sort headers.
3903         * alpha-tdep.c: Sort headers.
3904         * alpha-obsd-tdep.c: Sort headers.
3905         * alpha-nbsd-tdep.c: Sort headers.
3906         * alpha-mdebug-tdep.c: Sort headers.
3907         * alpha-linux-tdep.c: Sort headers.
3908         * alpha-linux-nat.c: Sort headers.
3909         * alpha-bsd-tdep.c: Sort headers.
3910         * alpha-bsd-nat.c: Sort headers.
3911         * aix-thread.c: Sort headers.
3912         * agent.c: Sort headers.
3913         * addrmap.c: Sort headers.
3914         * ada-varobj.c: Sort headers.
3915         * ada-valprint.c: Sort headers.
3916         * ada-typeprint.c: Sort headers.
3917         * ada-tasks.c: Sort headers.
3918         * ada-lang.c: Sort headers.
3919         * aarch64-tdep.c: Sort headers.
3920         * aarch64-ravenscar-thread.c: Sort headers.
3921         * aarch64-newlib-tdep.c: Sort headers.
3922         * aarch64-linux-tdep.c: Sort headers.
3923         * aarch64-linux-nat.c: Sort headers.
3924         * aarch64-fbsd-tdep.c: Sort headers.
3925         * aarch64-fbsd-nat.c: Sort headers.
3926         * aarch32-linux-nat.c: Sort headers.
3927
3928 2019-04-04  Tom Tromey  <tom@tromey.com>
3929
3930         * varobj.c (varobj_create): Update.
3931         * rust-exp.y (struct rust_parser) <update_innermost_block,
3932         lookup_symbol>: New methods.
3933         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
3934         Rename.
3935         (rust_parser::rust_lookup_type)
3936         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3937         * printcmd.c (display_command, do_one_display): Update.
3938         * parser-defs.h (struct parser_state) <parser_state>: Add
3939         "tracker" parameter.
3940         (block_tracker): New member.
3941         (class innermost_block_tracker) <innermost_block_tracker>: Add
3942         "types" parameter.
3943         <reset>: Remove method.
3944         (innermost_block): Don't declare.
3945         (null_post_parser): Update.
3946         * parse.c (innermost_block): Remove global.
3947         (write_dollar_variable): Update.
3948         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
3949         Remove "tracker_types" parameter.
3950         (parse_expression): Add "tracker" parameter.
3951         (parse_expression_for_completion): Update.
3952         (null_post_parser): Add "tracker" parameter.
3953         * p-exp.y: Update rules.
3954         * m2-exp.y: Update rules.
3955         * language.h (struct language_defn) <la_post_parser>: Add
3956         "tracker" parameter.
3957         * go-exp.y: Update rules.
3958         * f-exp.y: Update rules.
3959         * expression.h (parse_expression, parse_exp_1): Add "tracker"
3960         parameter.
3961         * d-exp.y: Update rules.
3962         * c-exp.y: Update rules.
3963         * breakpoint.c (set_breakpoint_condition): Create an
3964         innermost_block_tracker.
3965         (watch_command_1): Likewise.
3966         * ada-lang.c (resolve): Add "tracker" parameter.
3967         (resolve_subexp): Likewise.
3968         * ada-exp.y (write_var_from_sym): Update.
3969
3970 2019-04-04  Tom Tromey  <tom@tromey.com>
3971
3972         * type-stack.h: New file.
3973         * type-stack.c: New file.
3974         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
3975         type-stack.h.
3976         (insert_into_type_stack, insert_type, push_type, push_type_int)
3977         (insert_type_address_space, pop_type, pop_type_int)
3978         (pop_typelist, pop_type_stack, append_type_stack)
3979         (push_type_stack, get_type_stack, push_typelist)
3980         (follow_type_instance_flags, follow_types): Don't declare.
3981         * parse.c (type_stack): Remove global.
3982         (parse_exp_in_context): Update.
3983         (insert_into_type_stack, insert_type, push_type, push_type_int)
3984         (insert_type_address_space, pop_type, pop_type_int)
3985         (pop_typelist, pop_type_stack, append_type_stack)
3986         (push_type_stack, get_type_stack, push_typelist)
3987         (follow_type_instance_flags, follow_types): Remove (moved to
3988         type-stack.c).
3989         * f-exp.y (type_stack): New global.
3990         Update rules.
3991         (push_kind_type, f_parse): Update.
3992         * d-exp.y (type_stack): New global.
3993         Update rules.
3994         (d_parse): Update.
3995         * c-exp.y (struct c_parse_state) <type_stack>: New member.
3996         Update rules.
3997         * Makefile.in (COMMON_SFILES): Add type-stack.c.
3998         (HFILES_NO_SRCDIR): Add type-stack.h.
3999
4000 2019-04-04  Tom Tromey  <tom@tromey.com>
4001
4002         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
4003         (rust_parser::convert_ast_to_expression, rust_parse)
4004         (rust_lex_test_completion, rust_lex_tests): Update.
4005         * parser-defs.h (struct expr_completion_state): New.
4006         (struct parser_state) <parser_state>: Add completion parameter.
4007         <mark_struct_expression, mark_completion_tag>: New methods.
4008         <parse_completion, m_completion_state>: New members.
4009         (prefixify_expression, null_post_parser): Update.
4010         (mark_struct_expression, mark_completion_tag): Don't declare.
4011         * parse.c (parse_completion, expout_last_struct)
4012         (expout_tag_completion_type, expout_completion_name): Remove
4013         globals.
4014         (parser_state::mark_struct_expression)
4015         (parser_state::mark_completion_tag): Now methods.
4016         (prefixify_expression): Add last_struct parameter.
4017         (prefixify_subexp): Likewise.
4018         (parse_exp_1): Update.
4019         (parse_exp_in_context): Add cstate parameter.  Update.
4020         (parse_expression_for_completion): Create an
4021         expr_completion_state.
4022         (null_post_parser): Add "completion" parameter.
4023         * p-exp.y: Update rules.
4024         (yylex): Update.
4025         * language.h (struct language_defn) <la_post_parser>: Add
4026         "completing" parameter.
4027         * go-exp.y: Update rules.
4028         (lex_one_token): Update.
4029         * expression.h (parse_completion): Don't declare.
4030         * d-exp.y: Update rules.
4031         (lex_one_token): Update rules.
4032         * c-exp.y: Update rules.
4033         (lex_one_token): Update.
4034         * ada-lang.c (resolve): Add "parse_completion" parameter.
4035         (resolve_subexp): Likewise.
4036         (ada_resolve_function): Likewise.
4037
4038 2019-04-04  Tom Tromey  <tom@tromey.com>
4039
4040         * parser-defs.h (struct parser_state) <start_arglist,
4041         end_arglist>: New methods.
4042         <arglist_len, m_funcall_chain>: New members.
4043         (arglist_len, start_arglist, end_arglist): Don't declare.
4044         * parse.c (arglist_len, funcall_chain): Remove global.
4045         (start_arglist, end_arglist): Remove functions.
4046         (parse_exp_in_context): Update.
4047         * p-exp.y: Update rules.
4048         * m2-exp.y: Update rules.
4049         * go-exp.y: Update rules.
4050         * f-exp.y: Update rules.
4051         * d-exp.y: Update rules.
4052         * c-exp.y: Update rules.
4053
4054 2019-04-04  Tom Tromey  <tom@tromey.com>
4055
4056         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
4057         lex_operator, push_back>: New methods.
4058         Update all rules.
4059         (rust_parser::lex_hex, lex_escape): Rename and update.
4060         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
4061         (rust_parser::lex_operator): Rename and update.
4062         (rust_parser::lex_number, rustyylex, rustyyerror)
4063         (rust_lex_test_init, rust_lex_test_sequence)
4064         (rust_lex_test_push_back, rust_lex_tests): Update.
4065         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
4066         parameter.
4067         <lexptr, prev_lexptr>: New members.
4068         (lexptr, prev_lexptr): Don't declare.
4069         * parse.c (lexptr, prev_lexptr): Remove globals.
4070         (parse_exp_in_context): Update.
4071         * p-exp.y (yylex, yyerror): Update.
4072         * m2-exp.y (parse_number, yylex, yyerror): Update.
4073         * go-exp.y (lex_one_token, yyerror): Update.
4074         * f-exp.y (match_string_literal, yylex, yyerror): Update.
4075         * d-exp.y (lex_one_token, yyerror): Update.
4076         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
4077         (lex_one_token, yyerror): Update.
4078         * ada-lex.l (YY_INPUT): Update.
4079         (rewind_to_char): Update.
4080         * ada-exp.y (yyerror): Update.
4081
4082 2019-04-04  Tom Tromey  <tom@tromey.com>
4083
4084         * rust-exp.y (rustyylex, rust_lex_tests): Update.
4085         * parser-defs.h (struct parser_state) <parser_state>: Add new
4086         parameter.
4087         <comma_terminates>: New member.
4088         (comma_terminates): Don't declare global.
4089         * parse.c (comma_terminates): Remove global.
4090         (parse_exp_in_context): Update.
4091         * p-exp.y (yylex): Update.
4092         * m2-exp.y (yylex): Update.
4093         * go-exp.y (lex_one_token): Update.
4094         * f-exp.y (yylex): Update.
4095         * d-exp.y (lex_one_token): Update.
4096         * c-exp.y (lex_one_token): Update.
4097         * ada-lex.l: Update.
4098
4099 2019-04-04  Tom Tromey  <tom@tromey.com>
4100
4101         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
4102         (rustyylex, rust_lex_test_init, rust_lex_test_one)
4103         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
4104         * parser-defs.h (paren_depth): Don't declare.
4105         * parse.c (paren_depth): Remove global.
4106         (parse_exp_in_context): Update.
4107         * p-exp.y (paren_depth): New global.
4108         (pascal_parse): Initialize it.
4109         * m2-exp.y (paren_depth): New global.
4110         (m2_parse): Initialize it.
4111         * go-exp.y (paren_depth): New global.
4112         (go_parse): Initialize it.
4113         * f-exp.y (paren_depth): New global.
4114         (f_parse): Initialize it.
4115         * d-exp.y (paren_depth): New global.
4116         (d_parse): Initialize it.
4117         * c-exp.y (paren_depth): New global.
4118         (c_parse): Initialize it.
4119         * ada-lex.l (paren_depth): New global.
4120         (lexer_init): Initialize it.
4121
4122 2019-04-04  Tom Tromey  <tom@tromey.com>
4123
4124         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
4125         (rust_parser::convert_ast_to_type)
4126         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4127         * parser-defs.h (struct parser_state) <parser_state>: Add
4128         parameters.  Initialize new members.
4129         <expression_context_block, expression_context_pc>: New members.
4130         * parse.c (expression_context_block, expression_context_pc):
4131         Remove globals.
4132         (parse_exp_in_context): Update.
4133         * p-exp.y: Update all rules.
4134         (yylex): Update.
4135         * m2-exp.y: Update all rules.
4136         (yylex): Update.
4137         * go-exp.y (yylex): Update.
4138         * f-exp.y (yylex): Update.
4139         * d-exp.y: Update all rules.
4140         (yylex): Update.
4141         * c-exp.y: Update all rules.
4142         (lex_one_token, classify_name, yylex, c_parse): Update.
4143         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
4144
4145 2019-04-04  Tom Tromey  <tom@tromey.com>
4146
4147         * gdbarch.h, gdbarch.c: Rebuild.
4148         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
4149         * stap-probe.h:
4150         (struct stap_parse_info): Replace "parser_state" with
4151         "expr_builder".
4152         * parser-defs.h (struct expr_builder): Rename from "parser_state".
4153         (parser_state): New class.
4154         * parse.c (expr_builder): Rename.
4155         (expr_builder::release): Rename.
4156         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
4157         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
4158         (write_exp_elt_longcst, write_exp_elt_floatcst)
4159         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
4160         (write_exp_string_vector, write_exp_bitstring)
4161         (write_exp_msymbol, mark_struct_expression)
4162         (write_dollar_variable)
4163         (insert_type_address_space, increase_expout_size): Replace
4164         "parser_state" with "expr_builder".
4165         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
4166         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
4167         "parser_state" with "expr_builder".
4168
4169 2019-04-04  Tom Tromey  <tom@tromey.com>
4170
4171         * rust-exp.y: Replace "parse_language" with method call.
4172         * p-exp.y:
4173         (yylex): Replace "parse_language" with method call.
4174         * m2-exp.y:
4175         (yylex): Replace "parse_language" with method call.
4176         * go-exp.y (classify_name): Replace "parse_language" with method
4177         call.
4178         * f-exp.y (yylex): Replace "parse_language" with method call.
4179         * d-exp.y (lex_one_token): Replace "parse_language" with method
4180         call.
4181         * c-exp.y:
4182         (lex_one_token, classify_name, yylex): Replace "parse_language"
4183         with method call.
4184         * ada-exp.y (find_primitive_type, type_char)
4185         (type_system_address): Replace "parse_language" with method call.
4186
4187 2019-04-04  Tom Tromey  <tom@tromey.com>
4188
4189         * rust-exp.y: Replace "parse_gdbarch" with method call.
4190         * parse.c (write_dollar_variable, insert_type_address_space):
4191         Replace "parse_gdbarch" with method call.
4192         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
4193         call.
4194         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
4195         call.
4196         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
4197         "parse_gdbarch" with method call.
4198         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
4199         with method call.
4200         * f-exp.y (parse_type, parse_f_type, yylex): Replace
4201         "parse_gdbarch" with method call.
4202         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
4203         "parse_gdbarch" with method call.
4204         * c-exp.y (parse_type, parse_number, classify_name): Replace
4205         "parse_gdbarch" with method call.
4206         * ada-lex.l: Replace "parse_gdbarch" with method call.
4207         * ada-exp.y (parse_type, find_primitive_type, type_char)
4208         (type_system_address): Replace "parse_gdbarch" with method call.
4209
4210 2019-04-04  Tom Tromey  <tom@tromey.com>
4211
4212         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
4213         * stap-probe.c (stap_parse_argument): Update.
4214         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
4215         initial_size parameter.
4216         * rust-exp.y (rust_lex_tests): Update.
4217         * parse.c (parser_state): Update.
4218         (parse_exp_in_context): Update.
4219         * parser-defs.h (struct parser_state) <parser_state>: Remove
4220         "initial_size" parameter.
4221
4222 2019-04-04  Tom Tromey  <tom@tromey.com>
4223
4224         * parser-defs.h (increase_expout_size): Don't declare.
4225         * parse.c (increase_expout_size): Now static.
4226
4227 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
4228
4229         * gnu-nat.c (gnu_nat_target::wait): Fix
4230         target_waitstatus_to_string call.
4231
4232 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4233
4234         * eval.c (evaluate_subexp_standard): Handle internal functions
4235         during Fortran function call handling.
4236
4237 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4238
4239         * NEWS: Mention new internal functions.
4240         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
4241         (read_base_type): Use dwarf2_init_complex_target_type.
4242         * value.c (creal_internal_fn): New function.
4243         (cimag_internal_fn): New function.
4244         (_initialize_values): Register new internal functions.
4245
4246 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4247
4248         * infrun.c (stop_all_threads): If debug_infrun, always
4249         trace the wait status after wait_one, using
4250         target_waitstatus_to_string and target_pid_to_str.
4251         (handle_inferior_event): Replace various trace of
4252         wait status kind by a single trace.
4253         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
4254         wait status kind image by target_waitstatus_to_string.
4255         * target/waitstatus.c (target_waitstatus_to_string): Fix
4256         obsolete comment.
4257
4258 2019-04-01  Tom Tromey  <tromey@adacore.com>
4259
4260         PR symtab/23331:
4261         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
4262
4263 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
4264             Pedro Alves  <palves@redhat.com>
4265
4266         * top.c (quit_force): Call 'finalize_values'.
4267         * value.c (finalize_values): New function.
4268         * value.h (finalize_values): Declare.
4269
4270 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
4271
4272         * NEWS: Announce $_gdb_major and $_gdb_minor.
4273
4274         * top.c (init_gdb_version_vars): New function.
4275         (gdb_init): Call init_gdb_version_vars.
4276
4277 2019-03-29  Tom Tromey  <tromey@adacore.com>
4278
4279         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
4280         help text.  Remove dead code.
4281
4282 2019-03-29  Keith Seitz  <keiths@redhat.com>
4283
4284         From Siddhesh Poyarekar:
4285         * f-lang.h (f77_get_upperbound): Return LONGEST.
4286         (f77_get_lowerbound): Likewise.
4287         * f-typeprint.c (f_type_print_varspec_suffix): Expand
4288         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
4289         print them.
4290         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
4291         plongest to format print it.
4292         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
4293         (f77_get_upperbound): Likewise.
4294         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
4295         LOWER_BOUND to LONGEST.
4296         (f77_create_arrayprint_offset_tbl): Likewise.
4297
4298 2019-03-29  Keith Seitz  <keiths@redhat.com>
4299
4300         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
4301         %s/pulongest for TYPE_LENGTH instead of %d in format
4302         strings.
4303         * ada-typerint.c (ada_print_type): Likewise.
4304         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
4305         * compile/compile-c-support.c (generate_register_struct): Likewise.
4306         * gdbtypes.c (recursive_dump_type): Likewise.
4307         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
4308         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
4309         instead of %d in format strings.
4310         * riscv-tdep.c (riscv_type_alignment): Cast second argument
4311         to std::min to ULONGEST.
4312         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
4313         instead of %d in format strings.
4314         * tracepoint.c (info_scope_command): Likewise.
4315         * typeprint.c (print_offset_data::update)
4316         (print_offset_data::finish): Likewise.
4317         * xtensa-tdep.c (xtensa_store_return_value)
4318         (xtensa_push_dummy_call): Likewise.
4319
4320 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
4321
4322         * windows-nat.c (display_selector): Fixed format specifications
4323         for 64-bit Cygwin.
4324
4325 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4326
4327         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
4328
4329 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
4330
4331         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
4332         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
4333         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
4334         (nios2_linux_init_abi): Install it.
4335
4336 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4337
4338         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
4339
4340 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4341
4342         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
4343
4344 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4345             Tom Tromey  <tromey@adacore.com>
4346
4347         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
4348
4349 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
4350
4351         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
4352         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
4353         method to compute the bounds of range types. Also print "[evaluated]"
4354         if the bounds' values come from a dynamic evaluation.
4355
4356 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4357
4358         * cp-valprint.c (cp_print_value_fields): Don't print trailing
4359         whitespace when pretty printing is on.
4360
4361 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4362
4363         * ppc-linux-nat.c: Add include.
4364
4365 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4366
4367         * NEWS: Mention AArch64 Pointer Authentication.
4368
4369 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4370
4371         * arm-linux-nat.c: Add include.
4372
4373 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
4374
4375         * source-cache.c (source_cache::get_source_lines): Re-read
4376         fullname after calling open_source_file.
4377
4378 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
4379
4380         * NEWS: Mention TLS support for FreeBSD.
4381
4382 2019-03-25  Tom Tromey  <tromey@adacore.com>
4383
4384         * minsyms.c (BUNCH_SIZE): Update comment.
4385         (~minimal_symbol_reader): Remove old comment.
4386         (compact_minimal_symbols): Update comment.
4387         (minimal_symbol_reader::install): Remove old comment.  Update
4388         other comments.
4389
4390 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4391
4392         * s390-linux-nat.c: Add include.
4393
4394 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4395
4396         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4397         Call linux_get_hwcap.
4398         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
4399         Likewise.
4400         (aarch64_linux_get_hwcap): Remove function.
4401         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
4402         declaration.
4403         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
4404         linux_get_hwcap.
4405         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4406         * linux-tdep.c (linux_get_hwcap): Add function.
4407         (linux_get_hwcap2): Likewise.
4408         * linux-tdep.h (linux_get_hwcap): Add declaration.
4409         (linux_get_hwcap2): Likewise.
4410         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
4411         (ppc_linux_get_hwcap2): Likewise.
4412         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
4413         linux_get_hwcap.
4414         (ppc_linux_nat_target::insert_watchpoint): Likewise.
4415         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
4416         (ppc_linux_nat_target::read_description): Likewise.
4417         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
4418         * s390-linux-nat.c: Likewise.
4419         * s390-linux-tdep.c (s390_core_read_description): Likewise.
4420
4421 2019-03-24  Tom Tromey  <tom@tromey.com>
4422
4423         * ada-lang.c (standard_lookup): Simplify initialization.
4424         (ada_lookup_symbol_nonlocal): Simplify return.
4425         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
4426         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
4427         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
4428         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
4429         initialization.
4430         * solib.c (solib_global_lookup): Simplify.
4431         * symtab.c (null_block_symbol): Remove.
4432         (symbol_cache_lookup): Simplify returns.
4433         (lookup_language_this): Simplify returns.
4434         (lookup_symbol_aux): Simplify return.
4435         (lookup_local_symbol): Simplify returns.
4436         (lookup_global_symbol_from_objfile): Simplify return.
4437         (lookup_symbol_in_objfile_symtabs)
4438         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
4439         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
4440         (lookup_static_symbol, lookup_global_symbol): Simplify return.
4441         * cp-namespace.c (cp_lookup_bare_symbol)
4442         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
4443         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
4444         (cp_lookup_nested_symbol): Don't use null_block_symbol.
4445         (cp_lookup_symbol_via_imports): Simplify initialization.
4446         (find_symbol_in_baseclass): Likewise.
4447         * symtab.h (null_block_symbol): Remove.
4448         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
4449         (d_lookup_nested_symbol, d_lookup_symbol_imports)
4450         (d_lookup_symbol_module): Likewise.
4451         (find_symbol_in_baseclass): Simplify initialization.
4452
4453 2019-03-24  Tom Tromey  <tom@tromey.com>
4454
4455         * expression.h: Don't include symtab.h.
4456         (struct block): Forward declare.
4457
4458 2019-03-24  Tom Tromey  <tom@tromey.com>
4459
4460         * c-exp.y (typebase): Remove casts.
4461         * gdbtypes.c (lookup_unsigned_typename, )
4462         (lookup_signed_typename): Remove cast.
4463         * eval.c (parse_to_comma_and_eval): Remove cast.
4464         * parse.c (write_dollar_variable): Remove cast.
4465         * block.h (struct block) <superblock>: Now const.
4466         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
4467         * psymtab.c (psym_map_matching_symbols): Make "block" const.
4468         (map_block): Make "block" const.
4469         * symfile.h (struct quick_symbol_functions)
4470         <map_matching_symbols>: Constify block argument to "callback".
4471         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
4472         const.
4473         (find_pc_sect_compunit_symtab): Make "b" const.
4474         (find_symbol_at_address): Likewise.
4475         (search_symbols): Likewise.
4476         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
4477         (dw2_debug_names_lookup_symbol): Likewise.
4478         (dw2_map_matching_symbols): Update.
4479         * p-valprint.c (pascal_val_print): Remove "block".
4480         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
4481         (aux_add_nonlocal_symbols): Make "block" const.
4482         (resolve_subexp): Remove cast.
4483         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
4484         const.
4485         (iterate_over_file_blocks): Likewise.
4486         * f-exp.y (%union) <bval>: Remove.
4487         * coffread.c (patch_opaque_types): Make "b" const.
4488         * spu-tdep.c (spu_catch_start): Make "block" const.
4489         * c-valprint.c (print_unpacked_pointer): Remove "block".
4490         * symmisc.c (dump_symtab_1): Make "b" const.
4491         (block_depth): Make "block" const.
4492         * d-exp.y (%union) <bval>: Remove.
4493         * cp-support.h (cp_lookup_rtti_type): Update.
4494         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
4495         * psymtab.c (psym_lookup_symbol): Make "block" const.
4496         (maintenance_check_psymtabs): Make "b" const.
4497         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
4498         (enumerate_locals, enumerate_args): Update.
4499         * python/py-symtab.c (stpy_global_block): Make "block" const.
4500         (stpy_static_block): Likewise.
4501         * inline-frame.c (block_starting_point_at): Make "new_block"
4502         const.
4503         * block.c (find_block_in_blockvector): Make return type const.
4504         (blockvector_for_pc_sect): Make "b" const.
4505         (find_block_in_blockvector): Make "b" const.
4506
4507 2019-03-23  Tom Tromey  <tom@tromey.com>
4508
4509         * varobj.c (varobj_create): Update.
4510         * symfile.c (clear_symtab_users): Don't reset innermost_block.
4511         * printcmd.c (display_command, do_one_display): Don't reset
4512         innermost_block.
4513         * parser-defs.h (enum innermost_block_tracker_type): Move to
4514         expression.h.
4515         (innermost_block): Update comment.
4516         * parse.c (parse_exp_1): Add tracker_types parameter.
4517         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
4518         tracker_types parameter.  Reset innermost_block.
4519         (parse_exp_in_context): Remove.
4520         (parse_expression_for_completion): Update.
4521         * objfiles.c (~objfile): Don't reset expression_context_block or
4522         innermost_block.
4523         * expression.h (enum innermost_block_tracker_type): Move from
4524         parser-defs.h.
4525         (parse_exp_1): Add tracker_types parameter.
4526         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
4527         reset innermost_block.
4528
4529 2019-03-23  Tom Tromey  <tom@tromey.com>
4530
4531         * objfiles.h: Include bcache.h.
4532
4533 2019-03-23  Tom Tromey  <tom@tromey.com>
4534
4535         * linespec.c (get_current_search_block): Use
4536         scoped_restore_current_language.
4537         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
4538
4539 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4540             Jiong Wang  <jiong.wang@arm.com>
4541
4542         * aarch64-linux-tdep.c
4543         (aarch64_linux_iterate_over_regset_sections): Check for pauth
4544         section.
4545         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
4546
4547 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4548             Jiong Wang  <jiong.wang@arm.com>
4549
4550         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
4551         instructions.
4552         (aarch64_analyze_prologue_test): Add PACIASP test.
4553         (aarch64_prologue_prev_register): Unmask PC value.
4554
4555 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4556             Jiong Wang  <jiong.wang@arm.com>
4557
4558         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
4559         (aarch64_dwarf2_prev_register): Unmask PC value.
4560         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
4561         (aarch64_execute_dwarf_cfa_vendor_op): Check for
4562         DW_CFA_AARCH64_negate_ra_state.
4563         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
4564
4565 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4566             Jiong Wang  <jiong.wang@arm.com>
4567
4568         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
4569         registers.
4570         (aarch64_pseudo_register_name): Likewise.
4571         (aarch64_pseudo_register_type): Likewise.
4572         (aarch64_pseudo_register_reggroup_p): Likewise.
4573         (aarch64_gdbarch_init): Add pauth registers.
4574         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
4575         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
4576         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
4577         (struct gdbarch_tdep): Add regnum for ra_state.
4578
4579 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4580             Jiong Wang  <jiong.wang@arm.com>
4581
4582         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
4583
4584 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4585             Jiong Wang  <jiong.wang@arm.com>
4586
4587         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
4588         function.
4589         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
4590         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
4591         (aarch64_gdbarch_init): Add puth registers.
4592         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
4593         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
4594         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
4595
4596 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4597             Jiong Wang  <jiong.wang@arm.com>
4598
4599         * aarch64-linux-nat.c
4600         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
4601         * aarch64-linux-tdep.c
4602         (aarch64_linux_core_read_description): Likewise.
4603         (aarch64_linux_get_hwcap): New function.
4604         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
4605         (aarch64_linux_get_hwcap): New declaration.
4606
4607 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4608             Jiong Wang  <jiong.wang@arm.com>
4609
4610         * aarch64-linux-nat.c
4611         (aarch64_linux_nat_target::read_description): Add pauth param.
4612         * aarch64-linux-tdep.c
4613         (aarch64_linux_core_read_description): Likewise.
4614         * aarch64-tdep.c (struct target_desc): Add in pauth.
4615         (aarch64_read_description): Add pauth param.
4616         (aarch64_gdbarch_init): Likewise.
4617         * aarch64-tdep.h (aarch64_read_description): Likewise.
4618         * arch/aarch64.c (aarch64_create_target_description): Likewise.
4619         * arch/aarch64.h (aarch64_create_target_description): Likewise.
4620         * features/Makefile: Add new files.
4621         * features/aarch64-pauth.c: New file.
4622         * features/aarch64-pauth.xml: New file.
4623
4624 2019-03-20  Tom Tromey  <tromey@adacore.com>
4625
4626         * infrun.c (handle_inferior_event): Rename from
4627         handle_inferior_event_1.  Create a scoped_value_mark.
4628         (handle_inferior_event): Remove.
4629
4630 2019-03-19  Tom Tromey  <tromey@adacore.com>
4631
4632         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
4633         * infrun.h (print_stop_event): Add "displays" parameter.
4634         * infrun.c (print_stop_event): Add "displays" parameter.
4635
4636 2019-03-19  Pedro Alves  <palves@redhat.com>
4637
4638         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
4639         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
4640         to -1.  Fix TABs vs spaces.
4641         (tui_ui_out::tui_ui_out): Don't initialize fields here.
4642         * tui/tui-out.h (tui_ui_out) Add intro comments.
4643         <m_line, m_start_of_line>: In-class initialize, and add describing
4644         comment.
4645
4646 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
4647
4648         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
4649         variable names.
4650         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
4651
4652 2019-03-18  Pedro Alves  <palves@redhat.com>
4653             Eli Zaretskii <eliz@gnu.org>
4654
4655         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
4656         m_line and m_start_of_line.
4657
4658 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
4659
4660         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
4661         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
4662         it returns a newline.  This fixes a regression in TU mode, whereby
4663         the next line is output on the same screen line as the user input.
4664
4665 2019-03-18  Tom Tromey  <tromey@adacore.com>
4666
4667         * minsyms.c (minimal_symbol_reader::install): Remove call to
4668         obstack_blank.
4669
4670 2019-03-18  Pedro Alves  <palves@redhat.com>
4671
4672         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
4673         New globals.
4674         (apply_style): New, factored out from ...
4675         (apply_ansi_escape): ... this.  Handle reverse video mode.
4676         (tui_set_reverse_mode): New function.
4677         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
4678         * tui/tui-winsource.c (tui_show_source_line): Use
4679         tui_set_reverse_mode instead of setting A_STANDOUT.
4680         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
4681         New setter methods.
4682
4683 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
4684
4685         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
4686         Handle tabs.
4687
4688 2019-03-18  Tom Tromey  <tromey@adacore.com>
4689
4690         * ada-lang.c (empty_array): Add "high" parameter.
4691         (ada_evaluate_subexp): Update.
4692
4693 2019-03-17  Sergei Trofimovich <siarheit@google.com>
4694
4695         * unittests/string_view-selftests.c: Define
4696         _initialize_string_view_selftests unconditionally.
4697
4698 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4699
4700         PR gdb/24350
4701         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
4702
4703 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4704
4705         PR gdb/24351
4706         * windows-nat.c (display_selector): Fix format specifiers.
4707
4708 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
4709
4710         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
4711         tui_refill_source_window instead of tui_refresh_win, to update the
4712         current execution line.  This fixes redisplay of the current line
4713         when stepping through the code with "next" or "step".
4714
4715 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4716
4717         * source-cache.c (source_cache::get_source_lines): Call
4718         find_source_lines to initialize s->nlines.  This fixes vertical
4719         scrolling of TUI source window when the DOWN arrow is pressed.
4720
4721 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4722
4723         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
4724         linux-thread-db.c (_initialize_thread_db): Likewise.
4725
4726 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4727
4728         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
4729         wclrtoeol in tui_show_source_line".  This reverts changes made in
4730         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
4731
4732 2019-03-15  Tom Tromey  <tom@tromey.com>
4733
4734         * symtab.h (struct minimal_symbol): Derive from
4735         general_symbol_info.
4736         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
4737         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
4738         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
4739         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
4740         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
4741         (MSYMBOL_SEARCH_NAME): Update.
4742         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
4743         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
4744         * minsyms.c (minimal_symbol_reader::record_full): Update.
4745
4746 2019-03-15  Tom Tromey  <tom@tromey.com>
4747
4748         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
4749
4750 2019-03-15  Tom Tromey  <tom@tromey.com>
4751
4752         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
4753         unique_xmalloc_ptr.
4754         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
4755         Update.
4756         * minsyms.c (lookup_minimal_symbol_by_pc_section)
4757         (build_minimal_symbol_hash_tables)
4758         (minimal_symbol_reader::install): Update.
4759
4760 2019-03-15  Tom Tromey  <tom@tromey.com>
4761
4762         * symtab.c (create_demangled_names_hash): Update.
4763         (symbol_set_names): Update.
4764         * objfiles.h (struct objfile_per_bfd_storage)
4765         <demangled_names_hash>: Now an htab_up.
4766         * objfiles.c (objfile_per_bfd_storage): Simplify.
4767
4768 2019-03-15  Tom Tromey  <tom@tromey.com>
4769
4770         * objfiles.h (struct objfile_per_bfd_storage): Declare
4771         destructor.
4772         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
4773         New.
4774         (get_objfile_bfd_data): Use new.  Don't initialize
4775         language_of_main.
4776         (free_objfile_per_bfd_storage): Remove.
4777         (objfile_bfd_data_free, objfile::~objfile): Use delete.
4778
4779 2019-03-15  Tom Tromey  <tom@tromey.com>
4780
4781         * symfile.c (reread_symbols): Update.
4782         * objfiles.c (objfile::objfile): Update.
4783         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
4784         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
4785         comment.
4786         (minimal_symbol_reader::install): Update.
4787         (terminate_minimal_symbol_table): Remove.
4788         * jit.c (jit_object_close_impl): Update.
4789
4790 2019-03-15  Tom Tromey  <tom@tromey.com>
4791
4792         * minsyms.c (minimal_symbol_reader::record_full): Remove some
4793         initializations.
4794
4795 2019-03-15  Tom Tromey  <tom@tromey.com>
4796
4797         * objfiles.h (struct objfile_per_bfd_storage)
4798         <demangled_hash_languages>: Now a bitset.
4799         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
4800         (lookup_minimal_symbol): Update.
4801
4802 2019-03-15  Tom Tromey  <tom@tromey.com>
4803
4804         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
4805         Don't return the symbol.
4806         * coffread.c (record_minimal_symbol): Use record_full.
4807
4808 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
4809
4810         The MS-Windows port of ncurses fails to switch to a color pair if
4811         one or both of the colors are the implicit default colors.  This
4812         change records the default colors when TUI is initialized, and
4813         then specifies them explicitly when a color pair uses the default
4814         colors.  This allows color styling in TUI mode on MS-Windows.
4815
4816         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
4817         ncurses_norm_attr.
4818         (tui_initialize_io) [__MINGW32__]: Record the default terminal
4819         colors in ncurses_norm_attr.
4820         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
4821         "none", replace it with the default color recorded in
4822         ncurses_norm_attr.
4823
4824 2019-03-14  Tom Tromey  <tromey@adacore.com>
4825
4826         * source-cache.h (class source_cache) <get_source_lines>: Return
4827         std::string.
4828         * source-cache.c (source_cache::extract_lines): Handle case where
4829         first_pos==npos.  Return std::string.
4830         (source_cache::get_source_lines): Update.
4831
4832 2019-03-14  Tom Tromey  <tromey@adacore.com>
4833
4834         * NEWS: Add item for "style sources" commands.
4835         * source-cache.c (source_cache::get_source_lines): Check
4836         source_styling.
4837         * cli/cli-style.c (source_styling): New global.
4838         (_initialize_cli_style): Add "style sources" commands.
4839         (show_style_sources): New function.
4840         * cli/cli-style.h (source_styling): Declare.
4841
4842 2019-03-14  Pedro Alves  <palves@redhat.com>
4843             Tom Tromey  <tromey@adacore.com>
4844
4845         * tui/tui-winsource.h (tui_refill_source_window): Declare.
4846         * tui/tui-winsource.c (tui_refill_source_window): New function,
4847         from...
4848         (tui_horizontal_source_scroll): ... here.  Move some logic.
4849         * cli/cli-style.c (set_style_enabled): Notify new observable.
4850         * tui/tui-hooks.c (tui_redisplay_source): New function.
4851         (tui_attach_detach_observers): Attach or detach
4852         tui_redisplay_source.
4853         * observable.h (source_styling_changed): New observable.
4854         * observable.c: Define source_styling_changed observable.
4855
4856 2019-03-13  Tom Tromey  <tromey@adacore.com>
4857
4858         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
4859         (i386_gnu_nat_target::store_registers): Update.
4860         * target-debug.h (target_debug_print_std_string): New macro.
4861         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4862         * windows-tdep.c (display_one_tib): Update.
4863         * tui/tui-stack.c (tui_make_status_line): Update.
4864         * top.c (print_inferior_quit_action): Update.
4865         * thread.c (thr_try_catch_cmd): Update.
4866         (add_thread_with_info): Update.
4867         (thread_target_id_str): Update.
4868         (thr_try_catch_cmd): Update.
4869         (thread_command): Update.
4870         (thread_find_command): Update.
4871         * record-btrace.c (record_btrace_target::info_record)
4872         (record_btrace_resume_thread, record_btrace_target::resume)
4873         (record_btrace_cancel_resume, record_btrace_step_thread)
4874         (record_btrace_target::wait, record_btrace_target::wait)
4875         (record_btrace_target::wait, record_btrace_target::stop): Update.
4876         * progspace.c (print_program_space): Update.
4877         * process-stratum-target.c
4878         (process_stratum_target::thread_address_space): Update.
4879         * linux-fork.c (linux_fork_mourn_inferior)
4880         (detach_checkpoint_command, info_checkpoints_command)
4881         (linux_fork_context): Update.
4882         (linux_fork_detach): Update.
4883         (class scoped_switch_fork_info): Update.
4884         (delete_checkpoint_command): Update.
4885         * infrun.c (follow_fork_inferior): Update.
4886         (follow_fork_inferior): Update.
4887         (proceed_after_vfork_done): Update.
4888         (handle_vfork_child_exec_or_exit): Update.
4889         (follow_exec): Update.
4890         (displaced_step_prepare_throw): Update.
4891         (displaced_step_restore): Update.
4892         (start_step_over): Update.
4893         (resume_1): Update.
4894         (clear_proceed_status_thread): Update.
4895         (proceed): Update.
4896         (print_target_wait_results): Update.
4897         (do_target_wait): Update.
4898         (context_switch): Update.
4899         (stop_all_threads): Update.
4900         (restart_threads): Update.
4901         (finish_step_over): Update.
4902         (handle_signal_stop): Update.
4903         (switch_back_to_stepped_thread): Update.
4904         (keep_going_pass_signal): Update.
4905         (print_exited_reason): Update.
4906         (normal_stop): Update.
4907         * inferior.c (inferior_pid_to_str): Change return type.
4908         (print_selected_inferior): Update.
4909         (add_inferior): Update.
4910         (detach_inferior): Update.
4911         * dummy-frame.c (fprint_dummy_frames): Update.
4912         * dcache.c (dcache_info_1): Update.
4913         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
4914         (btrace_fetch, btrace_clear): Update.
4915         * linux-tdep.c (linux_core_pid_to_str): Change return type.
4916         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
4917         type.
4918         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
4919         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
4920         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
4921         * gdbarch.c, gdbarch.h: Rebuild.
4922         * gdbarch.sh (core_pid_to_str): Change return type.
4923         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
4924         return type.
4925         (windows_nat_target::pid_to_str): Change return type.
4926         (windows_delete_thread): Update.
4927         (windows_nat_target::attach): Update.
4928         (windows_nat_target::files_info): Update.
4929         * target-delegates.c: Rebuild.
4930         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
4931         return type.
4932         (sol_thread_target::pid_to_str): Change return type.
4933         * remote.c (class remote_target) <pid_to_str>: Change return
4934         type.
4935         (remote_target::pid_to_str): Change return type.
4936         (extended_remote_target::attach, remote_target::remote_stop_ns)
4937         (remote_target::remote_notif_remove_queued_reply)
4938         (remote_target::push_stop_reply, remote_target::disable_btrace):
4939         Update.
4940         (extended_remote_target::attach): Update.
4941         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
4942         type.
4943         (gdbsim_target::pid_to_str): Change return type.
4944         * ravenscar-thread.c (struct ravenscar_thread_target)
4945         <pid_to_str>: Change return type.
4946         (ravenscar_thread_target::pid_to_str): Change return type.
4947         * procfs.c (class procfs_target) <pid_to_str>: Change return
4948         type.
4949         (procfs_target::pid_to_str): Change return type.
4950         (procfs_target::attach): Update.
4951         (procfs_target::detach): Update.
4952         (procfs_target::fetch_registers): Update.
4953         (procfs_target::store_registers): Update.
4954         (procfs_target::wait): Update.
4955         (procfs_target::files_info): Update.
4956         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
4957         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
4958         return type.
4959         (nto_procfs_target::pid_to_str): Change return type.
4960         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
4961         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
4962         return type.
4963         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
4964         (exit_lwp): Update.
4965         (attach_proc_task_lwp_callback, get_detach_signal)
4966         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
4967         (linux_nat_target::resume, wait_lwp, stop_callback)
4968         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
4969         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
4970         (linux_nat_wait_1, resume_stopped_resumed_lwps)
4971         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
4972         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
4973         type.
4974         (inf_ptrace_target::attach): Update.
4975         (inf_ptrace_target::files_info): Update.
4976         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
4977         type.
4978         (go32_nat_target::pid_to_str): Change return type.
4979         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
4980         (gnu_nat_target::wait): Update.
4981         (gnu_nat_target::wait): Update.
4982         (gnu_nat_target::resume): Update.
4983         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
4984         (fbsd_nat_target::wait): Update.
4985         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
4986         type.
4987         (darwin_nat_target::attach): Update.
4988         * corelow.c (class core_target) <pid_to_str>: Change return type.
4989         (core_target::pid_to_str): Change return type.
4990         * target.c (normal_pid_to_str): Change return type.
4991         (default_pid_to_str): Likewise.
4992         (target_pid_to_str): Change return type.
4993         (target_translate_tls_address): Update.
4994         (target_announce_detach): Update.
4995         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
4996         return type.
4997         (bsd_uthread_target::pid_to_str): Change return type.
4998         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
4999         type.
5000         (bsd_kvm_target::pid_to_str): Change return type.
5001         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
5002         return type.
5003         (aix_thread_target::pid_to_str): Change return type.
5004         * target.h (struct target_ops) <pid_to_str>: Change return type.
5005         (target_pid_to_str, normal_pid_to_str): Likewise.
5006         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
5007         type.
5008         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
5009         type.
5010         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
5011         return type.
5012         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
5013         type.
5014         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
5015         type.
5016         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
5017         return type.
5018
5019 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
5020
5021         * NEWS: Mention that the new default MI version is 3.  Mention
5022         changes to the output of commands and events that deal with
5023         multi-location breakpoints.
5024         * breakpoint.c: Include "mi/mi-out.h".
5025         (print_one_breakpoint): Change output syntax if using MI version
5026         >= 3.
5027         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
5028         New.
5029         (mi_multi_location_breakpoint_output_fixed): New.
5030         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
5031         (mi_cmd_fix_multi_location_breakpoint_output): New.
5032         (mi_multi_location_breakpoint_output_fixed): New.
5033         * mi/mi-cmds.c (mi_cmds): Register command
5034         -fix-multi-location-breakpoint-output.
5035         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
5036         interpreter "mi".
5037
5038 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
5039
5040         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
5041         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
5042         instantiate mi_ui_out based on interpreter name.
5043         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
5044         * mi/mi-main.c (mi_load_progress): Likewise.
5045
5046 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5047
5048         * NEWS: Combine separate "New targets" sections for 8.3.
5049
5050 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5051
5052         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
5053         (ppcfbsd_init_abi): Install gdbarch
5054         "fetch_tls_load_module_address" and "get_thread_local_address"
5055         methods.
5056
5057 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5058
5059         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
5060         (riscv_fbsd_init_abi): Install gdbarch
5061         "fetch_tls_load_module_address" and "get_thread_local_address"
5062         methods.
5063
5064 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5065
5066         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
5067         (i386fbsd_init_abi): Install gdbarch
5068         "fetch_tls_load_module_address" and "get_thread_local_address"
5069         methods.
5070
5071 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5072
5073         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
5074         (amd64fbsd_init_abi): Install gdbarch
5075         "fetch_tls_load_module_address" and "get_thread_local_address"
5076         methods.
5077
5078 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5079
5080         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
5081         (struct fbsd_pspace_data): New type.
5082         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
5083         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
5084         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
5085         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
5086         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
5087
5088 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5089
5090         * gdbtypes.c (lookup_struct_elt): New function.
5091         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
5092         * gdbtypes.h (struct struct_elt): New type.
5093         (lookup_struct_elt): New prototype.
5094
5095 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5096
5097         * gdbtypes.c (lookup_struct_elt_type): Update comment and
5098         remove disabled code block.
5099
5100 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5101
5102         * gdbarch.sh (get_thread_local_address): New method.
5103         * gdbarch.h, gdbarch.c: Regenerate.
5104         * target.c (target_translate_tls_address): Use
5105         gdbarch_get_thread_local_address if present instead of
5106         target::get_thread_local_address.
5107
5108 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5109
5110         * target.h (target::get_thread_local_address): Update comment.
5111
5112 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5113
5114         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
5115         objfile->separate_debug_objfile_backlink if not NULL.
5116
5117 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5118
5119         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
5120         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
5121         (amd64bsd_store_inferior_registers): Likewise.
5122         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5123         Enable segment base registers.
5124         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
5125         PT_GETFSBASE and PT_GETGSBASE.
5126         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
5127         PT_SETGSBASE.
5128         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
5129         segment base registers.
5130         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5131
5132 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5133
5134         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5135         Update calls to i386_target_description to add 'segments'
5136         parameter.
5137         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
5138         add segment base registers.
5139         * arch/i386.c (i386_create_target_description): Add 'segments'
5140         parameter to enable segment base registers.
5141         * arch/i386.h (i386_create_target_description): Likewise.
5142         * features/i386/32bit-segments.xml: New file.
5143         * features/i386/32bit-segments.c: Generate.
5144         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
5145         call to i386_target_description to add 'segments' parameter.
5146         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5147         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
5148         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
5149         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
5150         if feature is present.
5151         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
5152         Add 'segments' parameter to call to i386_target_description.
5153         (i386_target_description): Add 'segments' parameter to enable
5154         segment base registers.
5155         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
5156         to call to i386_target_description.
5157         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
5158         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
5159         Define I386_NUM_REGS.
5160         (i386_target_description): Add 'segments' parameter to enable
5161         segment base registers.
5162
5163 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
5164
5165         PR/24325
5166         * source-cache.c: #undef open and close, to avoid unresolved
5167         externals during linking.
5168
5169 2019-03-12  Tom Tromey  <tromey@adacore.com>
5170
5171         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
5172         const.  Add initializers.
5173         (_initialize_remote): Don't initialize ptid globals.
5174
5175 2019-03-12  Pedro Alves  <palves@redhat.com>
5176
5177         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
5178
5179 2019-03-12  Pedro Alves  <palves@redhat.com>
5180
5181         * cp-name-parser.y (main): Remove unused 'len' variable.
5182
5183 2019-03-12  Tom Tromey  <tromey@adacore.com>
5184
5185         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
5186         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
5187
5188 2019-03-12  Tom Tromey  <tromey@adacore.com>
5189
5190         * linux-nat.c (iterate_over_lwps): Update.
5191         (stop_callback): Remove parameter.
5192         (stop_wait_callback, detach_callback, resume_set_callback)
5193         (select_singlestep_lwp_callback, set_ignore_sigint)
5194         (status_callback, resumed_callback, resume_clear_callback)
5195         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
5196         data parameter.
5197         (linux_nat_target::detach, linux_nat_target::resume)
5198         (linux_stop_and_wait_all_lwps, select_event_lwp)
5199         (linux_nat_filter_event, linux_nat_wait_1)
5200         (linux_nat_target::kill, linux_nat_target::stop)
5201         (linux_nat_target::stop): Update.
5202         (linux_nat_resume_callback): Change type.
5203         (resume_stopped_resumed_lwps, count_events_callback)
5204         (select_event_lwp_callback): Likewise.
5205         (linux_stop_lwp, linux_nat_stop_lwp): Update.
5206         * arm-linux-nat.c (struct update_registers_data): Remove.
5207         (update_registers_callback): Change type.
5208         (arm_linux_insert_hw_breakpoint1): Update.
5209         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
5210         parameter.
5211         (x86_linux_dr_set_addr): Update.
5212         (x86_linux_dr_set_control): Update.
5213         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
5214         (iterate_over_lwps): Use gdb::function_view.
5215         * nat/aarch64-linux-hw-point.c (struct
5216         aarch64_dr_update_callback_param): Remove.
5217         (debug_reg_change_callback): Change type.
5218         (aarch64_notify_debug_reg_change): Update.
5219         * s390-linux-nat.c (s390_refresh_per_info): Update.
5220
5221 2019-03-11  Tom Tromey  <tromey@adacore.com>
5222
5223         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
5224         redundant assignment to "this_cu".
5225
5226 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5227
5228         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
5229
5230 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5231
5232         * gdbtypes.c (rank_one_type_parm_set): New function extracted
5233         from...
5234         (rank_one_type): ... this.
5235
5236 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5237
5238         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
5239         from...
5240         (rank_one_type): ... this.
5241
5242 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5243
5244         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
5245         from...
5246         (rank_one_type): ... this.
5247
5248 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5249
5250         * gdbtypes.c (rank_one_type_parm_float): New function extracted
5251         from...
5252         (rank_one_type): ... this.
5253
5254 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5255
5256         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
5257         from...
5258         (rank_one_type): ... this.
5259
5260 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5261
5262         * gdbtypes.c (rank_one_type_parm_range): New function extracted
5263         from...
5264         (rank_one_type): ... this.
5265
5266 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5267
5268         * gdbtypes.c (rank_one_type_parm_char): New function extracted
5269         from...
5270         (rank_one_type): ... this.
5271
5272 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5273
5274         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
5275         from...
5276         (rank_one_type): ... this.
5277
5278 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5279
5280         * gdbtypes.c (rank_one_type_parm_int): New function extracted
5281         from...
5282         (rank_one_type): ... this.
5283
5284 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5285
5286         * gdbtypes.c (rank_one_type_parm_func): New function extracted
5287         from...
5288         (rank_one_type): ... this.
5289
5290 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5291
5292         * gdbtypes.c (rank_one_type_parm_array): New function extracted
5293         from...
5294         (rank_one_type): ... this.
5295
5296 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5297
5298         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
5299         from...
5300         (rank_one_type): ... this.
5301
5302 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5303
5304         * inferior.c (initialize_inferiors): Ensure 'help set/show print
5305         inferior-events' shows the example events.
5306
5307 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
5308
5309         Support styling on native MS-Windows console
5310
5311         PR/24315
5312         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
5313         on MS-Windows if $TERM is not defined.
5314
5315         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
5316
5317         * posix-hdep.c (gdb_console_fputs):
5318         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
5319         functions.
5320         * ui-file.h (gdb_console_fputs): Add prototype.
5321
5322         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
5323         back to fputs only if the former returns zero.
5324
5325 2019-03-07  Tom Tromey  <tom@tromey.com>
5326
5327         * symmisc.c (print_symbol_bcache_statistics): Update.
5328         (print_objfile_statistics): Update.
5329         * symfile.c (allocate_symtab): Update.
5330         * stabsread.c: Don't include bcache.h.
5331         * psymtab.h (struct psymbol_bcache): Don't declare.
5332         (class psymtab_storage) <psymbol_cache>: Now a bcache.
5333         (psymbol_bcache_init, psymbol_bcache_free)
5334         (psymbol_bcache_get_bcache): Don't declare.
5335         * psymtab.c (struct psymbol_bcache): Remove.
5336         (psymtab_storage::psymtab_storage): Update.
5337         (psymtab_storage::~psymtab_storage): Update.
5338         (psymbol_bcache_init, psymbol_bcache_free)
5339         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
5340         (add_psymbol_to_bcache): Update.
5341         (allocate_psymtab): Update.
5342         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
5343         macro_cache>: No longer pointers.
5344         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
5345         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
5346         * macrotab.c (macro_bcache): Update.
5347         * macroexp.c: Don't include bcache.h.
5348         * gdbtypes.c (check_types_worklist): Update.
5349         (types_deeply_equal): Remove TRY/CATCH.  Update.
5350         * elfread.c (elf_symtab_read): Update.
5351         * dwarf2read.c: Don't include bcache.h.
5352         * buildsym.c (buildsym_compunit::get_macro_table): Update.
5353         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
5354         (print_bcache_statistics, bcache_memory_used): Don't declare.
5355         (struct bcache): Move from bcache.c.  Add constructor, destructor,
5356         methods.  Rename all data members.
5357         * bcache.c (struct bcache): Move to bcache.h.
5358         (bcache::expand_hash_table): Rename from expand_hash_table.
5359         (bcache): Remove.
5360         (bcache::insert): Rename from bcache_full.
5361         (bcache::compare): Rename from bcache_compare.
5362         (bcache_xmalloc): Remove.
5363         (bcache::~bcache): Rename from bcache_xfree.
5364         (bcache::print_statistics): Rename from print_bcache_statistics.
5365         (bcache::memory_used): Rename from bcache_memory_used.
5366
5367 2019-03-07  Pedro Alves  <palves@redhat.com>
5368
5369         * infrun.c (normal_stop): Also check for
5370         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
5371
5372 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
5373
5374         * f-lang.c (value_from_host_double): Moved to...
5375         * value.c (value_from_host_double): ...here.
5376         * value.h (value_from_host_double): Declare.
5377         * guile/scm-math.c (vlscm_convert_typed_number): Use
5378         value_from_host_double.
5379         (vlscm_convert_number): Likewise.
5380         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
5381         * python/py-value.c (convert_value_from_python): Likewise.
5382
5383 2019-03-06  Tom Tromey  <tom@tromey.com>
5384
5385         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
5386
5387 2019-03-06  Tom Tromey  <tom@tromey.com>
5388
5389         * utils.h (free_current_contents): Don't declare.
5390         * utils.c (free_current_contents): Remove.
5391
5392 2019-03-06  Tom Tromey  <tom@tromey.com>
5393
5394         * top.c (quit_force): Update.
5395         * main.c (captured_command_loop): Update.
5396         * common/new-op.c (operator new): Update.
5397         * common/common-exceptions.c (struct catcher)
5398         <save_cleanup_chain>: Remove member.
5399         (exceptions_state_mc_init): Update.
5400         (exception_try_scope_entry): Return nullptr.
5401         (exception_try_scope_exit, exception_rethrow)
5402         (throw_exception_sjlj, throw_exception_cxx): Update.
5403         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
5404         (all_cleanups, do_cleanups, discard_cleanups)
5405         (discard_final_cleanups, save_cleanups, save_final_cleanups)
5406         (restore_cleanups, restore_final_cleanups): Don't declare.
5407         (do_final_cleanups): Remove parameter.
5408         * common/cleanups.c (cleanup_chain, make_cleanup)
5409         (make_cleanup_dtor, all_cleanups, do_cleanups)
5410         (discard_my_cleanups, discard_cleanups)
5411         (discard_final_cleanups, save_my_cleanups, save_cleanups)
5412         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
5413         (null_cleanup): Remove.
5414         (do_final_cleanups): Remove parameter.
5415
5416 2019-03-06  Tom Tromey  <tom@tromey.com>
5417
5418         * remote.c (remote_target::remote_parse_stop_reply): Use
5419         unique_xmalloc_ptr.
5420
5421 2019-03-06  Tom Tromey  <tom@tromey.com>
5422
5423         * stabsread.c (struct stabs_field_info): Rename from field_info.
5424         <list, fnlist>: Add initializers.
5425         <obstack>: New member.
5426         (read_member_functions, read_struct_fields, read_baseclasses):
5427         Allocate on obstack.  Don't use cleanups.
5428         (read_one_struct_field, read_member_functions, read_struct_fields)
5429         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
5430         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
5431         (read_struct_type): Update.
5432
5433 2019-03-06  Tom Tromey  <tom@tromey.com>
5434
5435         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
5436         * common/filestuff.h (make_cleanup_close): Don't declare.
5437         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
5438         Remove.
5439
5440 2019-03-06  Tom Tromey  <tom@tromey.com>
5441
5442         * solib-aix.c: Use make_scope_exit.
5443
5444 2019-03-06  Tom Tromey  <tom@tromey.com>
5445
5446         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
5447         Use make_scope_exit.
5448
5449 2019-03-06  Tom Tromey  <tom@tromey.com>
5450
5451         * solib-svr4.c (disable_probes_interface): Remove parameter.
5452         (svr4_handle_solib_event): Use make_scope_exit.
5453
5454 2019-03-06  Tom Tromey  <tom@tromey.com>
5455
5456         * remote.c (struct stop_reply_deleter): Remove.
5457         (stop_reply_up): Update.
5458         (struct stop_reply): Derive from notif_event.  Don't typedef.
5459         <regcache>: Now a std::vector.
5460         (stop_reply_xfree): Remove.
5461         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
5462         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
5463         (remote_target::discard_pending_stop_replies): Use delete.
5464         (remote_target::remote_parse_stop_reply): Update.
5465         (remote_target::process_stop_reply): Update.
5466         * remote-notif.h (struct notif_event): Add virtual destructor.
5467         Remove "dtr" member.
5468         (struct notif_client) <alloc_event>: Return a unique_ptr.
5469         (notif_event_xfree): Don't declare.
5470         (notif_event_up): New typedef.
5471         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
5472         (notif_event_xfree, do_notif_event_xfree): Remove.
5473         (remote_notif_state_xfree): Update.
5474
5475 2019-03-06  Tom Tromey  <tom@tromey.com>
5476
5477         * infrun.c (displaced_step_clear_cleanup): Now a
5478         forward_scope_exit type.
5479         (displaced_step_prepare_throw): Update.
5480         (displaced_step_fixup): Update.
5481
5482 2019-03-06  Tom Tromey  <tom@tromey.com>
5483
5484         * inferior.h (class inferior): Update comment.
5485         * gdbthread.h (class thread_info): Update comment.
5486
5487 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
5488             Tom Tromey  <tom@tromey.com>
5489
5490         * stabsread.h (struct stab_section_list): Remove.
5491         (coffstab_build_psymtabs): Update.
5492         * dbxread.c (symbuf_sections): Now a std::vector.
5493         (sect_idx): New global.
5494         (fill_symbuf): Update.
5495         (coffstab_build_psymtabs): Change type of stabsects parameter.
5496         Update.
5497         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
5498         std::vector.
5499         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
5500         (coff_locate_sections): Update.
5501         (coff_symfile_read): Remove cleanups.  Update.
5502         (init_stringtab): Add storage parameter.
5503         (free_stringtab, free_stringtab_cleanup): Remove.
5504         (init_lineno): Add storage parameter.
5505         (free_linetab, free_linetab_cleanup): Remove.
5506
5507 2019-03-06  Pedro Alves  <palves@redhat.com>
5508
5509         * linux-fork.c (fork_info::clobber_regs): Delete.
5510         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
5511         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
5512         comment.  Adjust.
5513         (scoped_switch_fork_info::scoped_switch_fork_info)
5514         (checkpoint_command, linux_fork_context): Adjust
5515         fork_save_infrun_state calls.
5516
5517 2019-03-06  Pedro Alves  <palves@redhat.com>
5518
5519         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
5520         (inf_has_multiple_threads): Return 'bool' and rewrite using
5521         inferior_info::threads().
5522
5523 2019-03-06  Pedro Alves  <palves@redhat.com>
5524
5525         * linux-fork.c: Include <list>.
5526         (fork_list): Now a std::list instance.
5527         (fork_info): Add ctor, dtor, and in-class initialize all fields.
5528         (forks_exist_p, find_last_fork): Adjust.
5529         (new_fork): Delete.
5530         (one_fork_p): New.
5531         (add_fork): Adjust.
5532         (free_fork): Delete, folded into fork_info::~fork_info().
5533         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
5534         Adjust.
5535         (init_fork_list): Delete.
5536         (linux_fork_killall, linux_fork_mourn_inferior)
5537         (linux_fork_detach, info_checkpoints_command): Adjust.
5538         (_initialize_linux_fork): No longer call init_fork_list.
5539
5540 2019-03-06  Pedro Alves  <palves@redhat.com>
5541
5542         * linux-fork.c (new_fork): New, split out of ...
5543         (add_fork): ... this.  Return void.  Move "first fork" special
5544         case from here, to ...
5545         (checkpoint_command): ... here.
5546         * linux-linux.h (add_fork): Return void.
5547
5548 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5549
5550         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
5551
5552 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5553             Chris January  <chris.january@arm.com>
5554             David Lecomber  <david.lecomber@arm.com>
5555
5556         * f-exp.y: New token, UNOP_INTRINSIC.
5557         (exp): New pattern using UNOP_INTRINSIC token.
5558         (f77_keywords): Add 'abs' keyword.
5559         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
5560         (value_from_host_double): New function.
5561         (evaluate_subexp_f): Support UNOP_ABS.
5562
5563 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5564
5565         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
5566         types.
5567
5568 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5569
5570         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
5571         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
5572         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
5573
5574 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5575
5576         * f-exp.y (convert_to_kind_type): Handle more type kinds.
5577
5578 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5579             Chris January  <chris.january@arm.com>
5580
5581         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
5582         * f-exp.y: Define 'KIND' token.
5583         (exp): New pattern for KIND expressions.
5584         (ptype): Handle types with a kind extension.
5585         (direct_abs_decl): Extend to spot kind extensions.
5586         (f77_keywords): Add 'kind' to the list.
5587         (push_kind_type): New function.
5588         (convert_to_kind_type): New function.
5589         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
5590         * parse.c (operator_length_standard): Likewise.
5591         * parser-defs.h (enum type_pieces): Add tp_kind.
5592         * std-operator.def: Add UNOP_KIND.
5593
5594 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5595
5596         * f-exp.y (f_parse): Set yydebug.
5597
5598 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5599
5600         * f-lang.c (evaluate_subexp_f): New function.
5601         (exp_descriptor_f): New global.
5602         (f_language_defn): Use exp_descriptor_f instead of
5603         exp_descriptor_standard.
5604
5605 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5606
5607         * f-exp.y (struct token): Add comments.
5608         (dot_ops): Remove uppercase versions and the end marker.
5609         (f77_keywords): Likewise.
5610         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
5611         entries in the dot_ops array are case insensitive, and use
5612         strncasecmp to compare strings.  Also some whitespace cleanup in
5613         this area.  Similar for the f77_keywords array, except entries in
5614         this list might be case sensitive.
5615
5616 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5617
5618         * f-exp.y (struct f77_boolean_val): Add comments.
5619         (boolean_values): Remove uppercase versions, and end marker.
5620         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
5621         and use strncasecmp to achieve case insensitivity.  Additionally,
5622         perform whitespace cleanup around this code.
5623
5624 2019-03-06  Tom Tromey  <tromey@adacore.com>
5625
5626         * remote-sim.c (gdbsim_target_open): Use result of
5627         gdb_argv::release.
5628
5629 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
5630         Dirk Schubert  <dirk.schubert@arm.com>
5631         Chris January  <chris.january@arm.com>
5632
5633         * eval.c (evaluate_subexp_standard): Call Fortran argument
5634         wrapping logic.
5635         * f-lang.c (struct value): A value which can be passed into a
5636         Fortran function call.
5637         (fortran_argument_convert): Wrap Fortran arguments in a pointer
5638         where appropriate.
5639         (struct type): Value ready for a Fortran function call.
5640         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
5641         is needed.
5642         * f-lang.h (fortran_argument_convert): Declaration.
5643         (fortran_preserve_arg_pointer): Declaration.
5644         * infcall.c (value_arg_coerce): Call Fortran argument logic.
5645
5646 2019-03-05  Tom Tromey  <tromey@adacore.com>
5647
5648         * python/py-prettyprint.c (print_string_repr): Remove #if.
5649         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
5650
5651 2019-03-05  Tom Tromey  <tromey@adacore.com>
5652
5653         * target.c (the_dummy_target): Move later.  Change type to
5654         "dummy_target".
5655         (initialize_targets): Don't initialize the_dummy_target.
5656
5657 2019-03-05  Tom Tromey  <tromey@adacore.com>
5658
5659         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
5660         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
5661
5662 2019-03-05  Tom Tromey  <tromey@adacore.com>
5663
5664         * windows-nat.c (windows_nat_target::attach)
5665         (windows_nat_target::detach): Don't call gdb_flush.
5666         * valprint.c (generic_val_print, val_print, val_print_string):
5667         Don't call gdb_flush.
5668         * utils.c (defaulted_query): Don't call gdb_flush.
5669         * typeprint.c (print_type_scalar): Don't call gdb_flush.
5670         * target.c (target_announce_detach): Don't call gdb_flush.
5671         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
5672         * remote.c (extended_remote_target::attach): Don't call
5673         gdb_flush.
5674         * procfs.c (procfs_target::detach): Don't call gdb_flush.
5675         * printcmd.c (do_examine): Don't call gdb_flush.
5676         (info_display_command): Don't call gdb_flush.
5677         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
5678         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
5679         * memattr.c (info_mem_command): Don't call gdb_flush.
5680         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
5681         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
5682         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
5683         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
5684         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
5685         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
5686         (gnu_nat_target::detach): Don't call gdb_flush.
5687         * f-valprint.c (f_val_print): Don't call gdb_flush.
5688         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
5689         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
5690         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
5691         gdb_flush.
5692         * c-valprint.c (c_val_print): Don't call gdb_flush.
5693         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
5694
5695 2019-03-05  Tom Tromey  <tromey@adacore.com>
5696
5697         * varobj.c (update_dynamic_varobj_children): Update.
5698         (install_default_visualizer): Use reset, not release.
5699         * value.c (set_internalvar): Update.
5700         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
5701         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
5702         ATTRIBUTE_UNUSED_RESULT.
5703
5704 2019-03-05  Tom Tromey  <tromey@adacore.com>
5705
5706         * remote.c (class scoped_remote_fd) <release>: Add
5707         ATTRIBUTE_UNUSED_RESULT.
5708
5709 2019-03-05  Tom Tromey  <tromey@adacore.com>
5710
5711         * macroexp.c (struct macro_buffer) <release>: Add
5712         ATTRIBUTE_UNUSED_RESULT.
5713
5714 2019-03-05  Tom Tromey  <tromey@adacore.com>
5715
5716         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
5717         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
5718         ATTRIBUTE_UNUSED_RESULT.
5719
5720 2019-03-05  Tom Tromey  <tromey@adacore.com>
5721
5722         * common/scoped_fd.h (class scoped_fd) <release>: Add
5723         ATTRIBUTE_UNUSED_RESULT.
5724
5725 2019-03-05  Tom Tromey  <tromey@adacore.com>
5726
5727         * parser-defs.h (struct parser_state) <release>: Add
5728         ATTRIBUTE_UNUSED_RESULT.
5729
5730 2019-03-05  Tom Tromey  <tromey@adacore.com>
5731
5732         * utils.h (class gdb_argv) <release>: Add
5733         ATTRIBUTE_UNUSED_RESULT.
5734         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
5735
5736 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
5737
5738         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
5739         for-loop range, to avoid compiler warnings.
5740
5741         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
5742         avoid compiler warnings about unused variables.
5743
5744         * NEWS: Mention end of support for native debugging on MS-Windows
5745         before XP.
5746
5747         PR gdb/24292
5748         * common/netstuff.c:
5749         * gdbserver/gdbreplay.c
5750         * gdbserver/remote-utils.c:
5751         * ser-tcp.c:
5752         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
5753         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
5754         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
5755         'getaddrinfo' and 'freeaddrinfo' were not available before
5756         Windows XP, and mingw.org's MinGW headers by default define
5757         _WIN32_WINNT to 0x500.
5758
5759 2019-03-01  Gary Benson <gbenson@redhat.com>
5760
5761         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
5762
5763 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
5764             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
5765
5766         PR gdb/8527
5767         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
5768         set_sigint_trap, clear_sigint_trap.
5769
5770 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5771
5772         * target.c (target_detach): Clear the regcache and the
5773         frame cache.
5774
5775 2019-02-27  Pedro Alves  <palves@redhat.com>
5776
5777         * utils.c (set_screen_size): When we cap the height/width sizes,
5778         tweak the corresponding command variable to show "unlimited":
5779
5780 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
5781             Pedro Alves  <palves@redhat.com>
5782
5783         * utils.c (set_screen_size): Reduce "infinite" rows and columns
5784         before calling rl_set_screen_size.
5785
5786 2019-02-27  Tom Tromey  <tromey@adacore.com>
5787
5788         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
5789         define.
5790         * python/py-value.c: Remove Python 2.4 workaround.
5791         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
5792         workaround.
5793         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
5794         Python 2.4 workaround.
5795         * python/python-internal.h: Remove Python 2.4 comment.
5796         (Py_ssize_t): Don't define.
5797         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
5798         (gdb_Py_DECREF): Remove Python 2.4 workaround.
5799         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
5800         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
5801         * python/python.c (do_start_initialization): Remove Python 2.4
5802         workaround.
5803         * python/py-prettyprint.c (class dummy_python_frame): Remove.
5804         (print_children): Remove Python 2.4 workaround.
5805         * python/py-inferior.c (buffer_procs): Remove Python 2.4
5806         workaround.
5807         (CHARBUFFERPROC_NAME): Remove.
5808         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
5809         Python 2.4 workaround.
5810
5811 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5812
5813         * NEWS: Note minimum Python version.
5814
5815 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5816
5817         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
5818         code from these functions.  Remove corresponding ifdefs.  Use
5819         Py_buffer_up instead of explicit calls to PyBuffer_Release.
5820         Remove gotos and target of gotos.
5821         (infpy_search_memory): Likewise.
5822
5823 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5824
5825         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
5826         (hppa_gdbarch_init): Don't register deleted functions with
5827         gdbarch.
5828
5829 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5830
5831         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
5832         (h8300_unwind_sp): Delete.
5833         (h8300_dummy_id): Delete.
5834         (h8300_gdbarch_init): Don't register deleted functions with
5835         gdbarch.
5836
5837 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5838
5839         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
5840         (ft32_unwind_pc): Delete.
5841         (ft32_unwind_sp): Delete.
5842         (ft32_gdbarch_init): Don't register deleted functions with
5843         gdbarch.
5844
5845 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5846
5847         * gdb/frv-tdep.c (frv_dummy_id): Delete.
5848         (frv_unwind_pc): Delete.
5849         (frv_unwind_sp): Delete.
5850         (frv_gdbarch_init): Don't register deleted functions with
5851         gdbarch.
5852
5853 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5854
5855         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
5856         (riscv_unwind_pc): Delete.
5857         (riscv_unwind_sp): Delete.
5858         (riscv_gdbarch_init): Don't register deleted functions with
5859         gdbarch.
5860
5861 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5862
5863         * gdb/csky-tdep.c (csky_dummy_id): Delete.
5864         (csky_unwind_pc): Delete.
5865         (csky_unwind_sp): Delete.
5866         (csky_gdbarch_init): Don't register deleted functions with
5867         gdbarch.
5868
5869 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5870
5871         * gdb/cris-tdep.c (cris_dummy_id): Delete.
5872         (cris_unwind_pc): Delete.
5873         (cris_unwind_sp): Delete.
5874         (cris_gdbarch_init): Don't register deleted functions with
5875         gdbarch.
5876
5877 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5878
5879         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
5880         (bfin_unwind_pc): Delete.
5881         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
5882
5883 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5884
5885         * gdb/arm-tdep.c (arm_dummy_id): Delete.
5886         (arm_unwind_pc): Delete.
5887         (arm_unwind_sp): Delete.
5888         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
5889
5890 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5891
5892         * gdb/arc-tdep.c (arc_dummy_id): Delete.
5893         (arc_unwind_pc): Delete.
5894         (arc_unwind_sp): Delete.
5895         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
5896
5897 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5898
5899         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
5900         (alpha_unwind_pc): Delete.
5901         (alpha_gdbarch_init): Don't register deleted functions with
5902         gdbarch.
5903
5904 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5905
5906         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
5907         (aarch64_unwind_pc): Delete.
5908         (aarch64_unwind_sp): Delete.
5909         (aarch64_gdbarch_init): Don't register deleted functions with
5910         gdbarch.
5911
5912 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5913
5914         * gdbtypes.c (type_align): Don't consider static members when
5915         computing structure alignment.
5916
5917 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5918
5919         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
5920         return 0 for other types.
5921         * arch-utils.c (default_type_align): Always return 0.
5922         * gdbarch.h: Regenerate.
5923         * gdbarch.sh (type_align): Extend comment.
5924         * gdbtypes.c (type_align): Add additional comments, always call
5925         gdbarch_type_align before applying the default rules.
5926         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
5927         generic code will then apply a suitable default.
5928         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
5929         types, return 0 for other types.
5930
5931 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5932
5933         * NEWS: Create a new section for the next release branch.
5934         Rename the section of the current branch, now that it has
5935         been cut.
5936
5937 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5938
5939         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
5940         * version.in: Bump version to 8.3.50.DATE-git.
5941
5942 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
5943
5944         * aix-thread.c (ptid_cmp): Remove unused variable.
5945         (get_signaled_thread): Likewise.
5946         (store_regs_user_thread): Likewise.
5947         (store_regs_kernel_thread): Likewise.
5948         (fetch_regs_kernel_thread): Remove shadowed variable.
5949
5950 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5951
5952         * features/riscv/32bit-cpu.xml: Add register numbers.
5953         * features/riscv/32bit-fpu.c: Regenerate.
5954         * features/riscv/32bit-fpu.xml: Add register numbers.
5955         * features/riscv/64bit-cpu.xml: Add register numbers.
5956         * features/riscv/64bit-fpu.c: Regenerate.
5957         * features/riscv/64bit-fpu.xml: Add register numbers.
5958
5959 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
5960
5961         * NEWS: Mention two argument form of gdb.Value constructor.
5962         * python/py-value.c (convert_buffer_and_type_to_value): New
5963         function.
5964         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
5965         Add support for handling an optional second argument.  Call
5966         convert_buffer_and_type_to_value as appropriate.
5967         * python/python-internal.h (Py_buffer_deleter): New struct.
5968         (Py_buffer_up): New typedef.
5969
5970 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
5971
5972         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
5973         instead of releasing ownership.
5974
5975 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
5976
5977         * dwarf2read.c (open_and_init_dwp_file): Call
5978         elf_numsections instead of bfd_count_sections to initialize
5979         dwp_file->num_sections.
5980
5981 2019-02-25  Tom Tromey  <tromey@adacore.com>
5982
5983         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
5984
5985 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5986
5987         * gcore.in: Add '--readnever' option when invoking GDB.
5988
5989 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5990
5991         * MAINTAINERS: Update my email address.
5992
5993 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5994
5995         * build-id.c (build_id_to_debug_bfd_1): New function.
5996         (build_id_to_debug_bfd): Look for separate debug file in
5997         sysroot.
5998
5999 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6000
6001         * gdbarch.sh: Update the copyright year range that is placed into
6002         generated files.
6003
6004 2019-02-22  Keith Seitz  <keiths@redhat.com>
6005
6006         PR symtab/23853
6007         * linespec.c (create_sals_line_offset): Search for the default
6008         symtab's filename instead of its fullname.
6009
6010 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6011
6012         * NEWS: Update style defaults.
6013
6014 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6015
6016         * main.c (captured_main_1): Disable styling in batch mode.
6017
6018 2019-02-20  Tom Tromey  <tom@tromey.com>
6019
6020         * symtab.c (symtab_symbol_info): Fix typos.
6021
6022 2019-02-20  Tom Tromey  <tromey@adacore.com>
6023
6024         * findcmd.c (_initialize_mem_search): Use upper case for
6025         metasyntactic variables.
6026
6027 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
6028
6029         * aarch64-tdep.c (aarch64_add_reggroups): New function.
6030         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
6031
6032 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
6033
6034         * top.h (source_file_name): Change to std::string.
6035         * top.c (source_file_name): Likewise.
6036         (command_line_input): Adjust.
6037         * cli/cli-script.c (script_from_file): Adjust.
6038
6039 2019-02-19  Tom Tromey  <tromey@adacore.com>
6040
6041         * ravenscar-thread.c
6042         (ravenscar_thread_target::update_thread_list): Don't call
6043         ada_build_task_list.
6044         * ada-lang.h (ada_build_task_list): Don't declare.
6045         * ada-tasks.c (struct ada_tasks_inferior_data)
6046         <task_list_valid_p>: Now bool.
6047         (read_known_tasks, ada_task_list_changed)
6048         (ada_tasks_invalidate_inferior_data): Update.
6049         (read_known_tasks_array): Return bool.
6050         (read_known_tasks_list): Likewise.
6051         (read_known_tasks): Return void.
6052         (ada_build_task_list): Now static.
6053
6054 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6055
6056         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
6057         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
6058
6059 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6060
6061         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
6062         variant for ada_tasks_pspace_data_handle and
6063         ada_tasks_inferior_data_handle.
6064         (ada_tasks_pspace_data_cleanup): New function.
6065         (ada_tasks_inferior_data_cleanup): New function.
6066
6067 2019-02-17  Tom Tromey  <tom@tromey.com>
6068
6069         * macrotab.h (macro_source_fullname): Return a std::string.
6070         * macrotab.c (macro_include, check_for_redefinition)
6071         (macro_undef, macro_lookup_definition, foreach_macro)
6072         (foreach_macro_in_scope): Update.
6073         (macro_source_fullname): Return a std::string.
6074         * macrocmd.c (show_pp_source_pos): Update.
6075
6076 2019-02-17  Tom Tromey  <tom@tromey.com>
6077
6078         * macrocmd.c (show_pp_source_pos): Style the file names.
6079
6080 2019-02-17  Tom Tromey  <tom@tromey.com>
6081
6082         PR tui/24197:
6083         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
6084
6085 2019-02-17  Tom Tromey  <tom@tromey.com>
6086
6087         * ada-lang.c (user_select_syms): Use filtered printing.
6088         * utils.c (wrap_style): New global.
6089         (desired_style): Remove.
6090         (emit_style_escape): Add stream parameter.
6091         (set_output_style, reset_terminal_style, prompt_for_continue):
6092         Update.
6093         (flush_wrap_buffer): Only flush gdb_stdout.
6094         (wrap_here): Set wrap_style.
6095         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
6096         treat escape sequences as a character.  Change when wrap buffer is
6097         flushed.
6098         (fputs_styled): Do not set the output style when the default is
6099         requested.
6100         * ui-style.h (struct ui_file_style) <is_default>: New method.
6101         * source.c (print_source_lines_base): Emit escape sequences in one
6102         piece.
6103
6104 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6105
6106         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
6107         integers and enumeration types.
6108
6109 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6110
6111         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
6112         instead of lookup_symbol_in_language
6113         (do_exact_match): New function.
6114         (ada_get_symbol_name_matcher): Return do_exact_match when
6115         doing a verbatim match.
6116
6117 2019-02-15  Tom Tromey  <tromey@adacore.com>
6118
6119         * ravenscar-thread.c (ravenscar_thread_target::resume)
6120         (ravenscar_thread_target::wait): Special case wildcard requests.
6121
6122 2019-02-15  Tom Tromey  <tromey@adacore.com>
6123
6124         * ravenscar-thread.c (base_ptid): Remove.
6125         (struct ravenscar_thread_target) <close>: New method.
6126         <m_base_ptid>: New member.
6127         <update_inferior_ptid, active_task, task_is_currently_active,
6128         runtime_initialized>: Declare methods.
6129         <ravenscar_thread_target>: Add constructor.
6130         (ravenscar_thread_target::task_is_currently_active)
6131         (ravenscar_thread_target::update_inferior_ptid)
6132         (ravenscar_runtime_initialized): Rename.  Now methods.
6133         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
6134         (ravenscar_thread_target::update_thread_list): Update.
6135         (ravenscar_thread_target::active_task): Now method.
6136         (ravenscar_thread_target::store_registers)
6137         (ravenscar_thread_target::prepare_to_store)
6138         (ravenscar_thread_target::prepare_to_store)
6139         (ravenscar_thread_target::mourn_inferior): Update.
6140         (ravenscar_inferior_created): Use "new" to create target.
6141         (ravenscar_thread_target::get_ada_task_ptid): Update.
6142         (_initialize_ravenscar): Don't initialize base_ptid.
6143         (ravenscar_ops): Remove global.
6144
6145 2019-02-15  Tom Tromey  <tromey@adacore.com>
6146
6147         * target.h (push_target): Declare new overload.
6148         * target.c (push_target): New overload, taking an rvalue reference.
6149         * remote.c (remote_target::open_1): Use push_target overload.
6150         * corelow.c (core_target_open): Use push_target overload.
6151
6152 2019-02-15  Tom Tromey  <tromey@adacore.com>
6153
6154         * ravenscar-thread.c (is_ravenscar_task)
6155         (ravenscar_task_is_currently_active): Return bool.
6156         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
6157         (_initialize_ravenscar): Remove "(void)".
6158         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
6159         Return bool.
6160
6161 2019-02-15  Tom Tromey  <tromey@adacore.com>
6162
6163         * ravenscar-thread.c (ravenscar_runtime_initializer)
6164         (has_ravenscar_runtime, get_running_thread_id)
6165         (ravenscar_thread_target::resume): Fix indentation.
6166
6167 2019-02-15  Tom Tromey  <tromey@adacore.com>
6168
6169         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
6170         from ravenscar_arch_ops.
6171         (sparc_ravenscar_ops::fetch_registers)
6172         (sparc_ravenscar_ops::store_registers): Now methods.
6173         (sparc_ravenscar_prepare_to_store): Remove.
6174         (sparc_ravenscar_ops): Redefine.
6175         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
6176         methods and destructor.  Remove members.
6177         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
6178         (ravenscar_thread_target::store_registers)
6179         (ravenscar_thread_target::prepare_to_store): Update.
6180         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
6181         Remove.
6182         (struct ppc_ravenscar_powerpc_ops): Derive from
6183         ravenscar_arch_ops.
6184         (ppc_ravenscar_powerpc_ops::fetch_registers)
6185         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
6186         (ppc_ravenscar_powerpc_ops): Redefine.
6187         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
6188         (ppc_ravenscar_e500_ops::fetch_registers)
6189         (ppc_ravenscar_e500_ops::store_registers): Now methods.
6190         (ppc_ravenscar_e500_ops): Redefine.
6191         * aarch64-ravenscar-thread.c
6192         (aarch64_ravenscar_generic_prepare_to_store): Remove.
6193         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
6194         (aarch64_ravenscar_fetch_registers)
6195         (aarch64_ravenscar_store_registers): Now methods.
6196         (aarch64_ravenscar_ops): Redefine.
6197
6198 2019-02-15  Tom Tromey  <tromey@adacore.com>
6199
6200         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
6201         (ravenscar_thread_target::stopped_by_hw_breakpoint)
6202         (ravenscar_thread_target::stopped_by_watchpoint)
6203         (ravenscar_thread_target::stopped_data_address)
6204         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
6205
6206 2019-02-15  Tom Tromey  <tromey@adacore.com>
6207
6208         * ravenscar-thread.c: Fix some typos.
6209
6210 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6211             Tom Tromey  <tromey@adacore.com>
6212
6213         * ada-lang.c (ada_exception_sal): Change addr_string to a
6214         std::string.
6215         (create_ada_exception_catchpoint): Update.
6216
6217 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6218             Tom Tromey  <tromey@adacore.com>
6219
6220         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
6221         (bp_location_ops): Remove.
6222         (base_breakpoint_allocate_location): Update.
6223         (free_bp_location): Update.
6224         * ada-lang.c (class ada_catchpoint_location)
6225         <ada_catchpoint_location>: Remove ops parameter.
6226         (ada_catchpoint_location_dtor): Remove.
6227         (ada_catchpoint_location_ops): Remove.
6228         (allocate_location_exception): Update.
6229         * breakpoint.h (struct bp_location_ops): Remove.
6230         (class bp_location) <bp_location>: Remove bp_location_ops
6231         parameter.
6232         <~bp_location>: Add destructor.
6233         <ops>: Remove.
6234
6235 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6236             Pedro Alves  <palves@redhat.com>
6237
6238         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
6239         'PATH_MAX'.
6240
6241 2019-02-14  David Michael  <fedora.dm0@gmail.com>
6242             Samuel Thibault  <samuel.thibault@gnu.org>
6243             Thomas Schwinge  <thomas@codesourcery.com>
6244
6245         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
6246         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
6247
6248 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6249
6250         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
6251         (check_empty): Use "const char *".
6252
6253         * gnu-nat.c (gnu_nat_target::detach): Instead of
6254         'detach_inferior (pid)' call
6255         'detach_inferior (find_inferior_pid (pid))'.
6256
6257         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
6258         'nat/fork-inferior.o'.
6259         * gnu-nat.c: #include "nat/fork-inferior.h".
6260
6261         * gnu-nat.c (gnu_nat_target::detach): Instead of
6262         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
6263         * gnu-nat.h: #include "inf-child.h".
6264         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
6265         'i386_gnu_nat_target::fetch_registers'.
6266         (gnu_store_registers): Rename/move to
6267         'i386_gnu_nat_target::store_registers'.
6268
6269         * config/i386/nm-i386gnu.h: Don't "#include" any files.
6270         * gnu-nat.h (mach_thread_info): New function.
6271         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
6272
6273         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
6274
6275 2019-02-14  Frederic Konrad  <konrad@adacore.com>
6276
6277         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
6278
6279 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
6280
6281         * windows-nat.c (windows_add_thread): Add new parameter
6282         "main_thread_p" with default value set to false.  Update
6283         function documentation as well as all callers.
6284         (windows_delete_thread): Likewise.
6285         (fake_create_process): Update call to windows_add_thread.
6286         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
6287         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
6288         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
6289         call to windows_delete_thread.
6290
6291 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
6292
6293         * MAINTAINERS: Add Andrew Burgess as global maintainer.
6294
6295 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6296
6297         * symfile.c (find_separate_debug_file): Use canonical path of
6298         sysroot with child_path instead of gdb_sysroot if it is valid.
6299
6300 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6301
6302         * symfile.c (find_separate_debug_file): Use child_path to
6303         determine if an object file is under a sysroot.
6304
6305 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6306
6307         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6308         unittests/child-path-selftests.c.
6309         * common/pathstuff.c (child_path): New function.
6310         * common/pathstuff.h (child_path): New prototype.
6311         * unittests/child-path-selftests.c: New file.
6312
6313 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6314
6315         * symfile.c (find_separate_debug_file): Look for separate debug
6316         files in debug directories under the sysroot.
6317
6318 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6319
6320         * symtab.h (struct minimal_symbol data_p): New const method.
6321         (struct minimal_symbol text_p): Likewise.
6322         * symtab.c (output_source_filename): Use file name style
6323         to print file name.
6324         (print_symbol_info): Likewise.
6325         (print_msymbol_info): Use address style to print addresses.
6326         Use function name style to print executable text symbols.
6327         (expand_symtab_containing_pc): Use data_p.
6328         (find_pc_sect_compunit_symtab): Likewise.
6329
6330 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6331
6332         * breakpoint.c (describe_other_breakpoints): Use address style
6333         to print addresses.
6334         (say_where): Likewise.
6335
6336 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6337
6338         * ada-typeprint.c (print_func_type): Print function name
6339         style to print function name.
6340         * c-typeprint.c (c_print_type_1): Likewise.
6341
6342 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
6343
6344         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
6345         for execve.
6346
6347 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6348
6349         * c-exp.y (direct_abs_decl): Use emplace_back to record the
6350         type_stack.
6351
6352 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
6353
6354         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
6355         TYPE_CODE_REF types.
6356
6357 2019-02-08  Jim Wilson  <jimw@sifive.com>
6358
6359         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
6360         (riscv_linux_fregset): New.
6361         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
6362
6363 2019-02-07  Tom Tromey  <tom@tromey.com>
6364
6365         * thread.c (thread_cancel_execution_command): Update.
6366         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
6367         methods.
6368         (struct thread_fsm_ops): Remove.
6369         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
6370         (thread_fsm_should_stop, thread_fsm_return_value)
6371         (thread_fsm_set_finished, thread_fsm_finished_p)
6372         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
6373         Don't declare.
6374         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
6375         * infrun.c (clear_proceed_status_thread)
6376         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
6377         (print_stop_event): Update.
6378         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
6379         Add constructor.
6380         (step_command_fsm_ops): Remove.
6381         (new_step_command_fsm): Remove.
6382         (step_1): Update.
6383         (step_command_fsm::should_stop): Rename from
6384         step_command_fsm_should_stop.
6385         (step_command_fsm::clean_up): Rename from
6386         step_command_fsm_clean_up.
6387         (step_command_fsm::do_async_reply_reason): Rename from
6388         step_command_fsm_async_reply_reason.
6389         (struct until_next_fsm): Inherit from thread_fsm.  Add
6390         constructor.
6391         (until_next_fsm_ops): Remove.
6392         (new_until_next_fsm): Remove.
6393         (until_next_fsm::should_stop): Rename from
6394         until_next_fsm_should_stop.
6395         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
6396         (until_next_fsm::do_async_reply_reason): Rename from
6397         until_next_fsm_async_reply_reason.
6398         (struct finish_command_fsm): Inherit from thread_fsm.  Add
6399         constructor.  Change type of breakpoint.
6400         (finish_command_fsm_ops): Remove.
6401         (new_finish_command_fsm): Remove.
6402         (finish_command_fsm::should_stop): Rename from
6403         finish_command_fsm_should_stop.
6404         (finish_command_fsm::clean_up): Rename from
6405         finish_command_fsm_clean_up.
6406         (finish_command_fsm::return_value): Rename from
6407         finish_command_fsm_return_value.
6408         (finish_command_fsm::do_async_reply_reason): Rename from
6409         finish_command_fsm_async_reply_reason.
6410         (finish_command): Update.
6411         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
6412         Add constructor.
6413         (call_thread_fsm_ops): Remove.
6414         (call_thread_fsm::call_thread_fsm): Rename from
6415         new_call_thread_fsm.
6416         (call_thread_fsm::should_stop): Rename from
6417         call_thread_fsm_should_stop.
6418         (call_thread_fsm::should_notify_stop): Rename from
6419         call_thread_fsm_should_notify_stop.
6420         (run_inferior_call, call_function_by_hand_dummy): Update.
6421         * cli/cli-interp.c (should_print_stop_to_console): Update.
6422         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
6423         Add constructor.  Change type of location_breakpoint,
6424         caller_breakpoint.
6425         (until_break_fsm_ops): Remove.
6426         (new_until_break_fsm): Remove.
6427         (until_break_fsm::should_stop): Rename from
6428         until_break_fsm_should_stop.
6429         (until_break_fsm::clean_up): Rename from
6430         until_break_fsm_clean_up.
6431         (until_break_fsm::do_async_reply_reason): Rename from
6432         until_break_fsm_async_reply_reason.
6433         (until_break_command): Update.
6434         * thread-fsm.c: Remove.
6435         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
6436
6437 2019-02-07  Tom Tromey  <tom@tromey.com>
6438
6439         * yy-remap.h: Add include guard.
6440         * xtensa-tdep.h: Add include guard.
6441         * xcoffread.h: Rename include guard.
6442         * varobj-iter.h: Add include guard.
6443         * tui/tui.h: Rename include guard.
6444         * tui/tui-winsource.h: Rename include guard.
6445         * tui/tui-wingeneral.h: Rename include guard.
6446         * tui/tui-windata.h: Rename include guard.
6447         * tui/tui-win.h: Rename include guard.
6448         * tui/tui-stack.h: Rename include guard.
6449         * tui/tui-source.h: Rename include guard.
6450         * tui/tui-regs.h: Rename include guard.
6451         * tui/tui-out.h: Rename include guard.
6452         * tui/tui-layout.h: Rename include guard.
6453         * tui/tui-io.h: Rename include guard.
6454         * tui/tui-hooks.h: Rename include guard.
6455         * tui/tui-file.h: Rename include guard.
6456         * tui/tui-disasm.h: Rename include guard.
6457         * tui/tui-data.h: Rename include guard.
6458         * tui/tui-command.h: Rename include guard.
6459         * tic6x-tdep.h: Add include guard.
6460         * target/waitstatus.h: Rename include guard.
6461         * target/wait.h: Rename include guard.
6462         * target/target.h: Rename include guard.
6463         * target/resume.h: Rename include guard.
6464         * target-float.h: Rename include guard.
6465         * stabsread.h: Add include guard.
6466         * rs6000-tdep.h: Add include guard.
6467         * riscv-fbsd-tdep.h: Add include guard.
6468         * regformats/regdef.h: Rename include guard.
6469         * record.h: Rename include guard.
6470         * python/python.h: Rename include guard.
6471         * python/python-internal.h: Rename include guard.
6472         * python/py-stopevent.h: Rename include guard.
6473         * python/py-ref.h: Rename include guard.
6474         * python/py-record.h: Rename include guard.
6475         * python/py-record-full.h: Rename include guard.
6476         * python/py-record-btrace.h: Rename include guard.
6477         * python/py-instruction.h: Rename include guard.
6478         * python/py-events.h: Rename include guard.
6479         * python/py-event.h: Rename include guard.
6480         * procfs.h: Add include guard.
6481         * proc-utils.h: Add include guard.
6482         * p-lang.h: Add include guard.
6483         * or1k-tdep.h: Rename include guard.
6484         * observable.h: Rename include guard.
6485         * nto-tdep.h: Rename include guard.
6486         * nat/x86-linux.h: Rename include guard.
6487         * nat/x86-linux-dregs.h: Rename include guard.
6488         * nat/x86-gcc-cpuid.h: Add include guard.
6489         * nat/x86-dregs.h: Rename include guard.
6490         * nat/x86-cpuid.h: Rename include guard.
6491         * nat/ppc-linux.h: Rename include guard.
6492         * nat/mips-linux-watch.h: Rename include guard.
6493         * nat/linux-waitpid.h: Rename include guard.
6494         * nat/linux-ptrace.h: Rename include guard.
6495         * nat/linux-procfs.h: Rename include guard.
6496         * nat/linux-osdata.h: Rename include guard.
6497         * nat/linux-nat.h: Rename include guard.
6498         * nat/linux-namespaces.h: Rename include guard.
6499         * nat/linux-btrace.h: Rename include guard.
6500         * nat/glibc_thread_db.h: Rename include guard.
6501         * nat/gdb_thread_db.h: Rename include guard.
6502         * nat/gdb_ptrace.h: Rename include guard.
6503         * nat/fork-inferior.h: Rename include guard.
6504         * nat/amd64-linux-siginfo.h: Rename include guard.
6505         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
6506         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
6507         * nat/aarch64-linux.h: Rename include guard.
6508         * nat/aarch64-linux-hw-point.h: Rename include guard.
6509         * mn10300-tdep.h: Add include guard.
6510         * mips-linux-tdep.h: Add include guard.
6511         * mi/mi-parse.h: Rename include guard.
6512         * mi/mi-out.h: Rename include guard.
6513         * mi/mi-main.h: Rename include guard.
6514         * mi/mi-interp.h: Rename include guard.
6515         * mi/mi-getopt.h: Rename include guard.
6516         * mi/mi-console.h: Rename include guard.
6517         * mi/mi-common.h: Rename include guard.
6518         * mi/mi-cmds.h: Rename include guard.
6519         * mi/mi-cmd-break.h: Rename include guard.
6520         * m2-lang.h: Add include guard.
6521         * location.h: Rename include guard.
6522         * linux-record.h: Rename include guard.
6523         * linux-nat.h: Add include guard.
6524         * linux-fork.h: Add include guard.
6525         * i386-darwin-tdep.h: Rename include guard.
6526         * hppa-linux-offsets.h: Add include guard.
6527         * guile/guile.h: Rename include guard.
6528         * guile/guile-internal.h: Rename include guard.
6529         * gnu-nat.h: Rename include guard.
6530         * gdb-stabs.h: Rename include guard.
6531         * frv-tdep.h: Add include guard.
6532         * f-lang.h: Add include guard.
6533         * event-loop.h: Add include guard.
6534         * darwin-nat.h: Rename include guard.
6535         * cp-abi.h: Rename include guard.
6536         * config/sparc/nm-sol2.h: Rename include guard.
6537         * config/nm-nto.h: Rename include guard.
6538         * config/nm-linux.h: Add include guard.
6539         * config/i386/nm-i386gnu.h: Rename include guard.
6540         * config/djgpp/nl_types.h: Rename include guard.
6541         * config/djgpp/langinfo.h: Rename include guard.
6542         * compile/gcc-cp-plugin.h: Add include guard.
6543         * compile/gcc-c-plugin.h: Add include guard.
6544         * compile/compile.h: Rename include guard.
6545         * compile/compile-object-run.h: Rename include guard.
6546         * compile/compile-object-load.h: Rename include guard.
6547         * compile/compile-internal.h: Rename include guard.
6548         * compile/compile-cplus.h: Rename include guard.
6549         * compile/compile-c.h: Rename include guard.
6550         * common/xml-utils.h: Rename include guard.
6551         * common/x86-xstate.h: Rename include guard.
6552         * common/version.h: Rename include guard.
6553         * common/vec.h: Rename include guard.
6554         * common/tdesc.h: Rename include guard.
6555         * common/selftest.h: Rename include guard.
6556         * common/scoped_restore.h: Rename include guard.
6557         * common/scoped_mmap.h: Rename include guard.
6558         * common/scoped_fd.h: Rename include guard.
6559         * common/safe-iterator.h: Rename include guard.
6560         * common/run-time-clock.h: Rename include guard.
6561         * common/refcounted-object.h: Rename include guard.
6562         * common/queue.h: Rename include guard.
6563         * common/ptid.h: Rename include guard.
6564         * common/print-utils.h: Rename include guard.
6565         * common/preprocessor.h: Rename include guard.
6566         * common/pathstuff.h: Rename include guard.
6567         * common/observable.h: Rename include guard.
6568         * common/netstuff.h: Rename include guard.
6569         * common/job-control.h: Rename include guard.
6570         * common/host-defs.h: Rename include guard.
6571         * common/gdb_wait.h: Rename include guard.
6572         * common/gdb_vecs.h: Rename include guard.
6573         * common/gdb_unlinker.h: Rename include guard.
6574         * common/gdb_unique_ptr.h: Rename include guard.
6575         * common/gdb_tilde_expand.h: Rename include guard.
6576         * common/gdb_sys_time.h: Rename include guard.
6577         * common/gdb_string_view.h: Rename include guard.
6578         * common/gdb_splay_tree.h: Rename include guard.
6579         * common/gdb_setjmp.h: Rename include guard.
6580         * common/gdb_ref_ptr.h: Rename include guard.
6581         * common/gdb_optional.h: Rename include guard.
6582         * common/gdb_locale.h: Rename include guard.
6583         * common/gdb_assert.h: Rename include guard.
6584         * common/filtered-iterator.h: Rename include guard.
6585         * common/filestuff.h: Rename include guard.
6586         * common/fileio.h: Rename include guard.
6587         * common/environ.h: Rename include guard.
6588         * common/common-utils.h: Rename include guard.
6589         * common/common-types.h: Rename include guard.
6590         * common/common-regcache.h: Rename include guard.
6591         * common/common-inferior.h: Rename include guard.
6592         * common/common-gdbthread.h: Rename include guard.
6593         * common/common-exceptions.h: Rename include guard.
6594         * common/common-defs.h: Rename include guard.
6595         * common/common-debug.h: Rename include guard.
6596         * common/cleanups.h: Rename include guard.
6597         * common/buffer.h: Rename include guard.
6598         * common/btrace-common.h: Rename include guard.
6599         * common/break-common.h: Rename include guard.
6600         * cli/cli-utils.h: Rename include guard.
6601         * cli/cli-style.h: Rename include guard.
6602         * cli/cli-setshow.h: Rename include guard.
6603         * cli/cli-script.h: Rename include guard.
6604         * cli/cli-interp.h: Rename include guard.
6605         * cli/cli-decode.h: Rename include guard.
6606         * cli/cli-cmds.h: Rename include guard.
6607         * charset-list.h: Add include guard.
6608         * buildsym-legacy.h: Rename include guard.
6609         * bfin-tdep.h: Add include guard.
6610         * ax.h: Rename include guard.
6611         * arm-linux-tdep.h: Add include guard.
6612         * arm-fbsd-tdep.h: Add include guard.
6613         * arch/xtensa.h: Rename include guard.
6614         * arch/tic6x.h: Add include guard.
6615         * arch/i386.h: Add include guard.
6616         * arch/arm.h: Rename include guard.
6617         * arch/arm-linux.h: Rename include guard.
6618         * arch/arm-get-next-pcs.h: Rename include guard.
6619         * arch/amd64.h: Add include guard.
6620         * arch/aarch64-insn.h: Rename include guard.
6621         * arch-utils.h: Rename include guard.
6622         * annotate.h: Add include guard.
6623         * amd64-darwin-tdep.h: Rename include guard.
6624         * aarch64-linux-tdep.h: Add include guard.
6625         * aarch64-fbsd-tdep.h: Add include guard.
6626         * aarch32-linux-nat.h: Add include guard.
6627
6628 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6629
6630         * macrotab.c (macro_define_internal): New function that
6631         factorizes macro_define_object_internal and macro_define_function
6632         code.
6633         (macro_define_object_internal): Use macro_define_internal.
6634         (macro_define_function): Likewise.
6635
6636 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6637
6638         * macrocmd.c (extract_identifier): Return
6639         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
6640         callers.
6641
6642 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
6643
6644         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
6645
6646 2019-02-05  Tom Tromey  <tom@tromey.com>
6647
6648         * target.c (target_stack::unpush): Move assertion earlier.
6649
6650 2019-01-30  Tom Tromey  <tom@tromey.com>
6651
6652         PR python/23615:
6653         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
6654         (gdbpy_parse_and_eval): Likewise.
6655         * python/python-internal.h (gdbpy_allow_threads): New class.
6656
6657 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
6658
6659         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
6660         (aarch64_fbsd_fpregmap): Move earlier.
6661         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
6662         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6663         instead of individual calls to trad_frame_set_reg_addr.
6664         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
6665         earlier.
6666         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
6667         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6668         instead of individual calls to trad_frame_set_reg_addr.
6669
6670 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
6671
6672         * CONTRIBUTE: Replace contribution list with wiki link.
6673
6674 2019-01-25  Tom Tromey  <tom@tromey.com>
6675
6676         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
6677
6678 2019-01-25  Tom Tromey  <tom@tromey.com>
6679
6680         * xtensa-linux-nat.c: Fix common/ includes.
6681         * xml-support.h: Fix common/ includes.
6682         * xml-support.c: Fix common/ includes.
6683         * x86-linux-nat.c: Fix common/ includes.
6684         * windows-nat.c: Fix common/ includes.
6685         * varobj.h: Fix common/ includes.
6686         * varobj.c: Fix common/ includes.
6687         * value.c: Fix common/ includes.
6688         * valops.c: Fix common/ includes.
6689         * utils.c: Fix common/ includes.
6690         * unittests/xml-utils-selftests.c: Fix common/ includes.
6691         * unittests/utils-selftests.c: Fix common/ includes.
6692         * unittests/unpack-selftests.c: Fix common/ includes.
6693         * unittests/tracepoint-selftests.c: Fix common/ includes.
6694         * unittests/style-selftests.c: Fix common/ includes.
6695         * unittests/string_view-selftests.c: Fix common/ includes.
6696         * unittests/scoped_restore-selftests.c: Fix common/ includes.
6697         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
6698         * unittests/scoped_fd-selftests.c: Fix common/ includes.
6699         * unittests/rsp-low-selftests.c: Fix common/ includes.
6700         * unittests/parse-connection-spec-selftests.c: Fix common/
6701         includes.
6702         * unittests/optional-selftests.c: Fix common/ includes.
6703         * unittests/offset-type-selftests.c: Fix common/ includes.
6704         * unittests/observable-selftests.c: Fix common/ includes.
6705         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
6706         * unittests/memrange-selftests.c: Fix common/ includes.
6707         * unittests/memory-map-selftests.c: Fix common/ includes.
6708         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
6709         * unittests/function-view-selftests.c: Fix common/ includes.
6710         * unittests/environ-selftests.c: Fix common/ includes.
6711         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
6712         * unittests/common-utils-selftests.c: Fix common/ includes.
6713         * unittests/cli-utils-selftests.c: Fix common/ includes.
6714         * unittests/array-view-selftests.c: Fix common/ includes.
6715         * ui-file.c: Fix common/ includes.
6716         * tui/tui-io.c: Fix common/ includes.
6717         * tracepoint.h: Fix common/ includes.
6718         * tracepoint.c: Fix common/ includes.
6719         * tracefile-tfile.c: Fix common/ includes.
6720         * top.h: Fix common/ includes.
6721         * top.c: Fix common/ includes.
6722         * thread.c: Fix common/ includes.
6723         * target/waitstatus.h: Fix common/ includes.
6724         * target/waitstatus.c: Fix common/ includes.
6725         * target.h: Fix common/ includes.
6726         * target.c: Fix common/ includes.
6727         * target-memory.c: Fix common/ includes.
6728         * target-descriptions.c: Fix common/ includes.
6729         * symtab.h: Fix common/ includes.
6730         * symfile.c: Fix common/ includes.
6731         * stap-probe.c: Fix common/ includes.
6732         * spu-linux-nat.c: Fix common/ includes.
6733         * sparc-nat.c: Fix common/ includes.
6734         * source.c: Fix common/ includes.
6735         * solib.c: Fix common/ includes.
6736         * solib-target.c: Fix common/ includes.
6737         * ser-unix.c: Fix common/ includes.
6738         * ser-tcp.c: Fix common/ includes.
6739         * ser-pipe.c: Fix common/ includes.
6740         * ser-base.c: Fix common/ includes.
6741         * selftest-arch.c: Fix common/ includes.
6742         * s12z-tdep.c: Fix common/ includes.
6743         * rust-exp.y: Fix common/ includes.
6744         * rs6000-aix-tdep.c: Fix common/ includes.
6745         * riscv-tdep.c: Fix common/ includes.
6746         * remote.c: Fix common/ includes.
6747         * remote-notif.h: Fix common/ includes.
6748         * remote-fileio.h: Fix common/ includes.
6749         * remote-fileio.c: Fix common/ includes.
6750         * regcache.h: Fix common/ includes.
6751         * regcache.c: Fix common/ includes.
6752         * record-btrace.c: Fix common/ includes.
6753         * python/python.c: Fix common/ includes.
6754         * python/py-type.c: Fix common/ includes.
6755         * python/py-inferior.c: Fix common/ includes.
6756         * progspace.h: Fix common/ includes.
6757         * producer.c: Fix common/ includes.
6758         * procfs.c: Fix common/ includes.
6759         * proc-api.c: Fix common/ includes.
6760         * printcmd.c: Fix common/ includes.
6761         * ppc-linux-nat.c: Fix common/ includes.
6762         * parser-defs.h: Fix common/ includes.
6763         * osdata.c: Fix common/ includes.
6764         * obsd-nat.c: Fix common/ includes.
6765         * nat/x86-linux.c: Fix common/ includes.
6766         * nat/x86-linux-dregs.c: Fix common/ includes.
6767         * nat/x86-dregs.h: Fix common/ includes.
6768         * nat/x86-dregs.c: Fix common/ includes.
6769         * nat/ppc-linux.c: Fix common/ includes.
6770         * nat/mips-linux-watch.h: Fix common/ includes.
6771         * nat/mips-linux-watch.c: Fix common/ includes.
6772         * nat/linux-waitpid.c: Fix common/ includes.
6773         * nat/linux-ptrace.h: Fix common/ includes.
6774         * nat/linux-ptrace.c: Fix common/ includes.
6775         * nat/linux-procfs.c: Fix common/ includes.
6776         * nat/linux-personality.c: Fix common/ includes.
6777         * nat/linux-osdata.c: Fix common/ includes.
6778         * nat/linux-namespaces.c: Fix common/ includes.
6779         * nat/linux-btrace.h: Fix common/ includes.
6780         * nat/linux-btrace.c: Fix common/ includes.
6781         * nat/fork-inferior.c: Fix common/ includes.
6782         * nat/amd64-linux-siginfo.c: Fix common/ includes.
6783         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
6784         * nat/aarch64-linux.c: Fix common/ includes.
6785         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
6786         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
6787         * namespace.h: Fix common/ includes.
6788         * mips-linux-tdep.c: Fix common/ includes.
6789         * minsyms.c: Fix common/ includes.
6790         * mi/mi-parse.h: Fix common/ includes.
6791         * mi/mi-main.c: Fix common/ includes.
6792         * mi/mi-cmd-env.c: Fix common/ includes.
6793         * memrange.h: Fix common/ includes.
6794         * memattr.c: Fix common/ includes.
6795         * maint.h: Fix common/ includes.
6796         * maint.c: Fix common/ includes.
6797         * main.c: Fix common/ includes.
6798         * machoread.c: Fix common/ includes.
6799         * location.c: Fix common/ includes.
6800         * linux-thread-db.c: Fix common/ includes.
6801         * linux-nat.c: Fix common/ includes.
6802         * linux-fork.c: Fix common/ includes.
6803         * inline-frame.c: Fix common/ includes.
6804         * infrun.c: Fix common/ includes.
6805         * inflow.c: Fix common/ includes.
6806         * inferior.h: Fix common/ includes.
6807         * inferior.c: Fix common/ includes.
6808         * infcmd.c: Fix common/ includes.
6809         * inf-ptrace.c: Fix common/ includes.
6810         * inf-child.c: Fix common/ includes.
6811         * ia64-linux-nat.c: Fix common/ includes.
6812         * i387-tdep.c: Fix common/ includes.
6813         * i386-tdep.c: Fix common/ includes.
6814         * i386-linux-tdep.c: Fix common/ includes.
6815         * i386-linux-nat.c: Fix common/ includes.
6816         * i386-go32-tdep.c: Fix common/ includes.
6817         * i386-fbsd-tdep.c: Fix common/ includes.
6818         * i386-fbsd-nat.c: Fix common/ includes.
6819         * guile/scm-type.c: Fix common/ includes.
6820         * guile/guile.c: Fix common/ includes.
6821         * go32-nat.c: Fix common/ includes.
6822         * gnu-nat.c: Fix common/ includes.
6823         * gdbthread.h: Fix common/ includes.
6824         * gdbarch-selftests.c: Fix common/ includes.
6825         * gdb_usleep.c: Fix common/ includes.
6826         * gdb_select.h: Fix common/ includes.
6827         * gdb_bfd.c: Fix common/ includes.
6828         * gcore.c: Fix common/ includes.
6829         * fork-child.c: Fix common/ includes.
6830         * findvar.c: Fix common/ includes.
6831         * fbsd-nat.c: Fix common/ includes.
6832         * event-top.c: Fix common/ includes.
6833         * event-loop.c: Fix common/ includes.
6834         * dwarf2read.c: Fix common/ includes.
6835         * dwarf2loc.c: Fix common/ includes.
6836         * dwarf2-frame.c: Fix common/ includes.
6837         * dwarf-index-cache.c: Fix common/ includes.
6838         * dtrace-probe.c: Fix common/ includes.
6839         * disasm-selftests.c: Fix common/ includes.
6840         * defs.h: Fix common/ includes.
6841         * csky-tdep.c: Fix common/ includes.
6842         * cp-valprint.c: Fix common/ includes.
6843         * cp-support.h: Fix common/ includes.
6844         * cp-support.c: Fix common/ includes.
6845         * corelow.c: Fix common/ includes.
6846         * completer.h: Fix common/ includes.
6847         * completer.c: Fix common/ includes.
6848         * compile/compile.c: Fix common/ includes.
6849         * compile/compile-loc2c.c: Fix common/ includes.
6850         * compile/compile-cplus-types.c: Fix common/ includes.
6851         * compile/compile-cplus-symbols.c: Fix common/ includes.
6852         * command.h: Fix common/ includes.
6853         * cli/cli-dump.c: Fix common/ includes.
6854         * cli/cli-cmds.c: Fix common/ includes.
6855         * charset.c: Fix common/ includes.
6856         * build-id.c: Fix common/ includes.
6857         * btrace.h: Fix common/ includes.
6858         * btrace.c: Fix common/ includes.
6859         * breakpoint.h: Fix common/ includes.
6860         * breakpoint.c: Fix common/ includes.
6861         * ax.h:
6862         (enum agent_op): Fix common/ includes.
6863         * ax-general.c (struct aop_map): Fix common/ includes.
6864         * ax-gdb.c: Fix common/ includes.
6865         * auxv.c: Fix common/ includes.
6866         * auto-load.c: Fix common/ includes.
6867         * arm-tdep.c: Fix common/ includes.
6868         * arch/riscv.c: Fix common/ includes.
6869         * arch/ppc-linux-common.c: Fix common/ includes.
6870         * arch/i386.c: Fix common/ includes.
6871         * arch/arm.c: Fix common/ includes.
6872         * arch/arm-linux.c: Fix common/ includes.
6873         * arch/arm-get-next-pcs.c: Fix common/ includes.
6874         * arch/amd64.c: Fix common/ includes.
6875         * arch/aarch64.c: Fix common/ includes.
6876         * arch/aarch64-insn.c: Fix common/ includes.
6877         * arch-utils.c: Fix common/ includes.
6878         * amd64-windows-tdep.c: Fix common/ includes.
6879         * amd64-tdep.c: Fix common/ includes.
6880         * amd64-sol2-tdep.c: Fix common/ includes.
6881         * amd64-obsd-tdep.c: Fix common/ includes.
6882         * amd64-nbsd-tdep.c: Fix common/ includes.
6883         * amd64-linux-tdep.c: Fix common/ includes.
6884         * amd64-linux-nat.c: Fix common/ includes.
6885         * amd64-fbsd-tdep.c: Fix common/ includes.
6886         * amd64-fbsd-nat.c: Fix common/ includes.
6887         * amd64-dicos-tdep.c: Fix common/ includes.
6888         * amd64-darwin-tdep.c: Fix common/ includes.
6889         * agent.c: Fix common/ includes.
6890         * ada-lang.h: Fix common/ includes.
6891         * ada-lang.c: Fix common/ includes.
6892         * aarch64-tdep.c: Fix common/ includes.
6893
6894 2019-01-25  Tom Tromey  <tom@tromey.com>
6895
6896         * common/create-version.sh: Use common/version.h.
6897
6898 2019-01-24  Pedro Alves  <palves@redhat.com>
6899
6900         * infrun.c (signal_stop, signal_print, signal_program)
6901         (signal_catch, signal_pass): Now arrays instead of pointers.
6902         (update_signals_program_target, do_target_resume)
6903         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
6904         * linux-nat.c (linux_nat_target::pass_signals)
6905         (linux_nat_target::create_inferior, linux_nat_target::attach):
6906         Adjust.
6907         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
6908         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
6909         * procfs.c (procfs_target::pass_signals): Adjust.
6910         * record-full.c (record_full_target::resume): Adjust.
6911         * remote.c (remote_target::pass_signals)
6912         (remote_target::program_signals): Adjust.
6913         * target-debug.h (target_debug_print_signals): Now takes a
6914         gdb::array_view as parameter.  Adjust.
6915         * target.h (target_ops) <pass_signals, program_signals>: Replace
6916         pointer and length parameters with gdb::array_view.
6917         (target_pass_signals, target_program_signals): Likewise.
6918         * target-delegates.c: Regenerate.
6919
6920 2019-01-24  Pedro Alves  <palves@redhat.com>
6921
6922         * common/forward-scope-exit.h
6923         (forward_scope_exit::forward_scope_exit): Pass arguments to
6924         m_bind_function directly, instead of creating a std::bind and
6925         copying that.
6926
6927 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
6928
6929         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6930         for static members.
6931         (pass_in_v_vfp_candidate): Likewise.
6932
6933 2019-01-23  Tom Tromey  <tom@tromey.com>
6934             Pedro Alves  <palves@redhat.com>
6935
6936         * regcache.c (class regcache_invalidator): Remove.
6937         (regcache::raw_write): Use make_scope_exit.
6938
6939 2019-01-23  Tom Tromey  <tom@tromey.com>
6940
6941         * ui-out.h (class ui_out_emit_type): Update comment.
6942
6943 2019-01-23  Tom Tromey  <tom@tromey.com>
6944
6945         * infrun.c (fetch_inferior_event): Update comment.
6946
6947 2019-01-23  Tom Tromey  <tom@tromey.com>
6948             Pedro Alves  <palves@redhat.com>
6949
6950         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
6951         parameter.
6952         (fetch_inferior_event): Use SCOPE_EXIT.
6953
6954
6955 2019-01-23  Tom Tromey  <tom@tromey.com>
6956             Pedro Alves  <palves@redhat.com>
6957
6958         * infrun.c (disable_thread_events): Delete.
6959         (stop_all_threads): Use SCOPE_EXIT.
6960
6961 2019-01-23  Tom Tromey  <tom@tromey.com>
6962             Pedro Alves  <palves@redhat.com>
6963
6964         * symfile.c: Include forward-scope-exit.h.
6965         (clear_symtab_users_cleanup): Replace forward declaration with
6966         a FORWARD_SCOPE_EXIT.
6967         (syms_from_objfile_1): Use the forward_scope_exit and
6968         gdb::optional instead of cleanup_function.
6969         (reread_symbols): Use the forward_scope_exit instead of
6970         cleanup_function.
6971         (clear_symtab_users_cleanup): Remove function.
6972
6973 2019-01-23  Tom Tromey  <tom@tromey.com>
6974             Pedro Alves  <palves@redhat.com>
6975
6976         * linux-nat.c: Include scope-exit.h.
6977         (cleanup_target_stop): Remove.
6978         (linux_nat_target::static_tracepoint_markers_by_strid): Use
6979         SCOPE_EXIT.
6980
6981 2019-01-23  Tom Tromey  <tom@tromey.com>
6982             Pedro Alves  <palves@redhat.com>
6983
6984         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
6985         (call_function_by_hand_dummy): Use SCOPE_EXIT.
6986
6987 2019-01-23  Tom Tromey  <tom@tromey.com>
6988             Andrew Burgess  <andrew.burgess@embecosm.com>
6989             Pedro Alves  <palves@redhat.com>
6990
6991         * infrun.c (fetch_inferior_event): Use scope_exit.
6992         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
6993         * top.c (execute_command): Use scope_exit.
6994         * breakpoint.c (bpstat_do_actions): Use scope_exit.
6995         * utils.c (do_bpstat_clear_actions_cleanup)
6996         (make_bpstat_clear_actions_cleanup): Remove.
6997
6998 2019-01-23  Tom Tromey  <tom@tromey.com>
6999             Pedro Alves  <palves@redhat.com>
7000
7001         * infrun.c: Include "common/scope-exit.h"
7002         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
7003         (wait_for_inferior): Use SCOPE_EXIT.
7004         (fetch_inferior_event): Use scope_exit.
7005
7006 2019-01-23  Tom Tromey  <tom@tromey.com>
7007             Pedro Alves  <palves@redhat.com>
7008
7009         * breakpoint.c (create_breakpoint): Remove cleanup.
7010
7011 2019-01-23  Tom Tromey  <tom@tromey.com>
7012             Andrew Burgess  <andrew.burgess@embecosm.com>
7013             Pedro Alves  <palves@redhat.com>
7014
7015 2019-01-23  Pedro Alves  <palves@redhat.com>
7016
7017         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
7018
7019 2019-01-23  Pedro Alves  <palves@redhat.com>
7020             Andrew Burgess  <andrew.burgess@embecosm.com>
7021
7022         * gdbthread.h: Include "common/forward-scope-exit.h".
7023         (scoped_finish_thread_state): Redefine custom class in terms of
7024         forward_scope_exit.
7025
7026 2019-01-23  Pedro Alves  <palves@redhat.com>
7027             Andrew Burgess  <andrew.burgess@embecosm.com>
7028
7029         * common/forward-scope-exit.h: New file.
7030
7031 2019-01-23  Pedro Alves  <palves@redhat.com>
7032             Andrew Burgess  <andrew.burgess@embecosm.com>
7033             Tom Tromey  <tom@tromey.com>
7034
7035         * common/scope-exit.h: New file.
7036
7037 2019-01-23  Pedro Alves  <palves@redhat.com>
7038
7039         * common/preprocessor.h (ESC): Rename to ...
7040         (ESC_PARENS): ... this.
7041         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
7042         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
7043
7044 2019-01-23  Tom Tromey  <tom@tromey.com>
7045
7046         * language.h (class scoped_switch_to_sym_language_if_auto):
7047         Initialize m_lang in both cases.
7048
7049 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
7050
7051         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
7052         with XCNEW.
7053
7054 2019-01-22  Tom Tromey  <tom@tromey.com>
7055
7056         * corelow.c: Do not include sys/file.h.
7057
7058 2019-01-22  Tom Tromey  <tom@tromey.com>
7059
7060         * tui/tui-wingeneral.h: Include gdb_curses.h.
7061
7062 2019-01-22  Tom Tromey  <tom@tromey.com>
7063
7064         * source-cache.h (class source_cache) <get_source_lines,
7065         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
7066
7067 2019-01-22  Tom Tromey  <tom@tromey.com>
7068
7069         * remote-fileio.h (struct remote_target): Declare.
7070
7071 2019-01-22  Tom Tromey  <tom@tromey.com>
7072
7073         * python/py-arch.c: Do not include py-ref.h.
7074         * python/py-bpevent.c: Do not include py-ref.h.
7075         * python/py-cmd.c: Do not include py-ref.h.
7076         * python/py-continueevent.c: Do not include py-ref.h.
7077         * python/py-event.h: Do not include py-ref.h.
7078         * python/py-evtregistry.c: Do not include py-ref.h.
7079         * python/py-finishbreakpoint.c: Do not include py-ref.h.
7080         * python/py-frame.c: Do not include py-ref.h.
7081         * python/py-framefilter.c: Do not include py-ref.h.
7082         * python/py-function.c: Do not include py-ref.h.
7083         * python/py-infevents.c: Do not include py-ref.h.
7084         * python/py-linetable.c: Do not include py-ref.h.
7085         * python/py-objfile.c: Do not include py-ref.h.
7086         * python/py-param.c: Do not include py-ref.h.
7087         * python/py-prettyprint.c: Do not include py-ref.h.
7088         * python/py-progspace.c: Do not include py-ref.h.
7089         * python/py-symbol.c: Do not include py-ref.h.
7090         * python/py-symtab.c: Do not include py-ref.h.
7091         * python/py-type.c: Do not include py-ref.h.
7092         * python/py-unwind.c: Do not include py-ref.h.
7093         * python/py-utils.c: Do not include py-ref.h.
7094         * python/py-value.c: Do not include py-ref.h.
7095         * python/py-varobj.c: Do not include py-ref.h.
7096         * python/py-xmethods.c: Do not include py-ref.h.
7097         * python/python.c: Do not include py-ref.h.
7098         * varobj.c: Do not include py-ref.h.
7099
7100 2019-01-22  Tom Tromey  <tom@tromey.com>
7101
7102         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
7103         keyword for bcache.
7104
7105 2019-01-22  Tom Tromey  <tom@tromey.com>
7106
7107         * compile/compile-cplus-types.c: Remove a comment by #include.
7108
7109 2019-01-22  Tom Tromey  <tom@tromey.com>
7110
7111         * compile/gcc-c-plugin.h: Include compile-internal.h.
7112
7113 2019-01-22  Tom Tromey  <tom@tromey.com>
7114
7115         * stabsread.c (EXTERN): Do not define.
7116         (symnum, next_symbol_text_func, processing_gcc_compilation)
7117         (within_function, global_sym_chain, global_stabs)
7118         (previous_stab_code, this_object_header_files)
7119         (n_this_object_header_files)
7120         (n_allocated_this_object_header_files): Define.
7121         * stabsread.h (EXTERN): Never define.  Use "extern".
7122
7123 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7124
7125         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
7126         history_value.
7127
7128 2019-01-21  Tom Tromey  <tom@tromey.com>
7129
7130         * ui-out.c: Fix includes.
7131         * tui/tui-source.c: Fix includes.
7132         * target.c: Fix includes.
7133         * remote.c: Fix includes.
7134         * regcache.c: Fix includes.
7135         * python/py-block.c: Fix includes.
7136         * printcmd.c: Fix includes.
7137         * or1k-tdep.c: Fix includes.
7138         * mi/mi-main.c: Fix includes.
7139         * m32r-tdep.c: Fix includes.
7140         * csky-tdep.c: Fix includes.
7141         * compile/compile-cplus-types.c: Fix includes.
7142         * cli/cli-interp.c: Fix includes.
7143
7144 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
7145
7146         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7147         for padding.
7148
7149 2019-01-16  Tom Tromey  <tom@tromey.com>
7150
7151         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
7152         earlier.
7153         (struct objfile) <msymbols_range>: Move from top level.
7154         <msymbols>: New method.
7155         (class objfile_msymbols): Remove.
7156         * symtab.c (default_collect_symbol_completion_matches_break_on):
7157         Update.
7158         * symmisc.c (dump_msymbols): Update.
7159         * stabsread.c (scan_file_globals): Update.
7160         * objc-lang.c (info_selectors_command, info_classes_command)
7161         (find_methods): Update.
7162         * minsyms.c (find_solib_trampoline_target): Update.
7163         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
7164         * coffread.c (coff_symfile_read): Update.
7165         * ada-lang.c (ada_lookup_simple_minsym)
7166         (ada_collect_symbol_completion_matches): Update.
7167
7168 2019-01-16  Tom Tromey  <tom@tromey.com>
7169
7170         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
7171         type.  Remove no-argument constructor.
7172         <iterator::operator++>: Simplify.
7173         <begin>: Update.
7174         <end>: Use minimal_symbol_count.
7175
7176 2019-01-16  Tom Tromey  <tom@tromey.com>
7177
7178         * objfiles.h (struct objfile) <psymtabs>: New method.
7179         (class objfile_psymtabs): Remove.
7180         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
7181         typedef.
7182         <range>: New method.
7183         (require_partial_symbols): Change return type.
7184         * psymtab.c (require_partial_symbols)
7185         (psym_expand_symtabs_matching): Update.
7186         * mdebugread.c (parse_partial_symbols): Update.
7187         * dbxread.c (dbx_end_psymtab): Update.
7188
7189 2019-01-15  Tom Tromey  <tom@tromey.com>
7190
7191         * symtab.c (lookup_objfile_from_block)
7192         (lookup_symbol_in_objfile_symtabs)
7193         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
7194         (find_line_symtab, info_sources_command)
7195         (default_collect_symbol_completion_matches_break_on)
7196         (make_source_files_completion_list): Update.
7197         * symmisc.c (print_objfile_statistics, dump_objfile)
7198         (maintenance_print_symbols, maintenance_info_symtabs)
7199         (maintenance_check_symtabs, maintenance_info_line_tables):
7200         Update.
7201         * source.c (select_source_symtab)
7202         (forget_cached_source_info_for_objfile): Update.
7203         * objfiles.h (class objfile_compunits): Remove.
7204         (struct objfile) <compunits_range>: New typedef.
7205         (compunits): New method.
7206         * objfiles.c (objfile_relocate1): Update.
7207         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7208         * maint.c (count_symtabs_and_blocks): Update.
7209         * linespec.c (iterate_over_all_matching_symtabs): Update.
7210         * cp-support.c (add_symbol_overload_list_qualified): Update.
7211         * coffread.c (coff_symtab_read): Update.
7212         * ada-lang.c (add_nonlocal_symbols)
7213         (ada_collect_symbol_completion_matches)
7214         (ada_add_global_exceptions): Update.
7215
7216 2019-01-15  Tom Tromey  <tom@tromey.com>
7217
7218         * progspace.h (program_space) <objfiles_safe_range>: New
7219         typedef.
7220         <objfiles_safe>: New method.
7221         * objfiles.h (class all_objfiles_safe): Remove.
7222         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
7223         * jit.c (jit_inferior_exit_hook): Update.
7224
7225 2019-01-17  Tom Tromey  <tom@tromey.com>
7226
7227         * progspace.h (program_space) <objfiles_range>: New typedef.
7228         <objfiles>: New method.
7229         <objfiles_head>: Rename from objfiles.
7230         (object_files): Update.
7231         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
7232         * guile/scm-pretty-print.c
7233         (ppscm_find_pretty_printer_from_objfiles): Update.
7234         * guile/scm-objfile.c (gdbscm_objfiles): Update.
7235         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
7236         Update.
7237         * python/py-progspace.c (pspy_get_objfiles): Update.
7238         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7239         Update.
7240         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7241         (objfpy_lookup_objfile_by_build_id): Update.
7242         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7243         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7244         Update.
7245         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7246         (expand_symtab_containing_pc, lookup_objfile_from_block)
7247         (lookup_static_symbol, basic_lookup_transparent_type)
7248         (find_pc_sect_compunit_symtab, find_symbol_at_address)
7249         (find_line_symtab, info_sources_command)
7250         (default_collect_symbol_completion_matches_break_on)
7251         (make_source_files_completion_list, find_main_name): Update.
7252         * symmisc.c (print_symbol_bcache_statistics)
7253         (print_objfile_statistics, maintenance_print_symbols)
7254         (maintenance_print_msymbols, maintenance_print_objfiles)
7255         (maintenance_info_symtabs, maintenance_check_symtabs)
7256         (maintenance_expand_symtabs, maintenance_info_line_tables):
7257         Update.
7258         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
7259         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
7260         (map_overlay_command, unmap_overlay_command)
7261         (simple_overlay_update, expand_symtabs_matching)
7262         (map_symbol_filenames): Update.
7263         * symfile-debug.c (set_debug_symfile): Update.
7264         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
7265         Update.
7266         * source.c (select_source_symtab, forget_cached_source_info):
7267         Update.
7268         * solib.c (solib_read_symbols): Update.
7269         * solib-spu.c (append_ocl_sos): Update.
7270         * psymtab.c (maintenance_print_psymbols)
7271         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
7272         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
7273         * printcmd.c (info_symbol_command): Update.
7274         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
7275         Update.
7276         * objfiles.h (class all_objfiles): Remove.
7277         * objfiles.c (have_partial_symbols, have_full_symbols)
7278         (have_minimal_symbols, qsort_cmp, update_section_map)
7279         (shared_objfile_contains_address_p)
7280         (default_iterate_over_objfiles_in_search_order): Update.
7281         * objc-lang.c (info_selectors_command, info_classes_command)
7282         (find_methods): Update.
7283         * minsyms.c (find_solib_trampoline_target): Update.
7284         * maint.c (maintenance_info_sections)
7285         (maintenance_translate_address, count_symtabs_and_blocks):
7286         Update.
7287         * main.c (captured_main_1): Update.
7288         * linux-thread-db.c (try_thread_db_load_from_pdir)
7289         (has_libpthread): Update.
7290         * linespec.c (iterate_over_all_matching_symtabs)
7291         (search_minsyms_for_name): Update.
7292         * jit.c (jit_find_objf_with_entry_addr): Update.
7293         * hppa-tdep.c (find_unwind_entry)
7294         (hppa_lookup_stub_minimal_symbol): Update.
7295         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
7296         Update.
7297         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7298         (elf_gnu_ifunc_resolve_by_got): Update.
7299         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
7300         * dwarf-index-write.c (save_gdb_index_command): Update.
7301         * cp-support.c (add_symbol_overload_list_qualified): Update.
7302         * breakpoint.c (create_overlay_event_breakpoint)
7303         (create_longjmp_master_breakpoint)
7304         (create_std_terminate_master_breakpoint)
7305         (create_exception_master_breakpoint): Update.
7306         * blockframe.c (find_pc_partial_function): Update.
7307         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
7308         (ada_collect_symbol_completion_matches)
7309         (ada_add_global_exceptions): Update.
7310
7311 2019-01-17  Tom Tromey  <tom@tromey.com>
7312
7313         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
7314         declare VEC.
7315         (solib_target_parse_libraries): Change return type.
7316         (library_list_start_segment, library_list_start_section)
7317         (library_list_end_library, library_list_start_library); Update.
7318         (solib_target_free_library_list): Remove.
7319         (solib_target_parse_libraries): Remove cleanup.  Change return
7320         type.
7321         (solib_target_current_sos): Update.
7322
7323 2019-01-17  Tom Tromey  <tromey@bapiya>
7324
7325         * valprint.c: Replace "the the" with "the".
7326         * symtab.c: Replace "the the" with "the".
7327         * solib.c: Replace "the the" with "the".
7328         * solib-dsbt.c: Replace "the the" with "the".
7329         * linespec.c: Replace "the the" with "the".
7330         * dwarf2loc.h: Replace "the the" with "the".
7331         * amd64-windows-tdep.c: Replace "the the" with "the".
7332         * aarch64-tdep.c: Replace "the the" with "the".
7333
7334 2019-01-16  Keith Seitz  <keiths@redhat.com>
7335
7336         PR gdb/23773
7337         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
7338         <builder>: Rename to ..
7339         <m_builder>: ... this and make private.
7340         (dwarf2_cu::get_builder): New method.  Change all users of
7341         `builder' to use this method.
7342         (dwarf2_start_symtab): Move to ...
7343         (dwarf2_cu::start_symtab): ... here.  Update all callers
7344         (setup_type_unit_groups): Move to ...
7345         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
7346         callers.
7347         (dwarf2_cu::reset_builder): New method.
7348         (process_full_compunit, process_full_type_unit): Use
7349         dwarf2_cu::reset_builder.
7350         (follow_die_offset): Record the ancestor CU if it is different
7351         from the followed DIE's CU.
7352         (follow_die_sig_1): Likewise.
7353
7354 2019-01-15  Tom Tromey  <tom@tromey.com>
7355
7356         * remote.c (class remote_state) <buf>: Now a char_vector.
7357         <buf_size>: Remove.
7358         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
7359         parameter.
7360         (remote_target::getpkt_or_notif_sane_1)
7361         (remote_target::getpkt_sane)
7362         (remote_target::getpkt_or_notif_sane): Likewise.
7363         (class remote_target) <putpkt>: New overload.
7364         (remote_target::read_frame): Change type of "buf_p".  Remove
7365         sizeof_p parameter.
7366         (packet_ok): New overload.
7367         (packet_check_result): New overload.
7368         Update all uses.
7369
7370 2019-01-14  Tom Tromey  <tom@tromey.com>
7371
7372         * remote-notif.c (handle_notification, remote_notif_ack)
7373         (remote_notif_parse): Make "buf" const.
7374         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
7375         const.
7376         (remote_notif_parse, remote_notif_ack, handle_notification):
7377         Likewise.
7378         * remote.c (remote_notif_stop_parse): Make "buf" const.
7379         (remote_target::remote_parse_stop_reply): Make "buf" const.
7380         (remote_notif_stop_ack): Make "buf" const.
7381
7382 2019-01-14  Tom Tromey  <tom@tromey.com>
7383
7384         * remote.c (remote_console_output): Make parameter const.
7385
7386 2019-01-14  Tom Tromey  <tom@tromey.com>
7387
7388         * target-debug.h (target_debug_print_signals): Constify.
7389         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
7390         * procfs.c (procfs_target::pass_signals): Update.
7391         * linux-nat.c (linux_nat_target::pass_signals): Update.
7392         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
7393         * target-delegates.c: Rebuild.
7394         * remote.c (remote_target::program_signals): Update.
7395         (remote_target::pass_signals): Update.
7396         * target.c (target_pass_signals): Constify argument.
7397         (target_program_signals): Likewise.
7398         * target.h (struct target_ops) <pass_signals, program_signals>:
7399         Constify argument.
7400         (target_pass_signals, target_program_signals): Constify argument.
7401
7402 2019-01-14  Tom Tromey  <tom@tromey.com>
7403
7404         PR tui/28819:
7405         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
7406
7407 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
7408
7409         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
7410         field.
7411         * rs6000-tdep.c: Include reggroups.h.
7412         (IS_V_ALIAS_PSEUDOREG): Define.
7413         (rs6000_register_name): Return names for the "vX" aliases.
7414         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
7415         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
7416         aliases.  Call default_register_reggroup_p for all other
7417         pseudo-registers.
7418         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
7419         New functions.
7420         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
7421         Handle "vX" aliases.
7422         (v_alias_pseudo_register_collect): New function.
7423         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
7424         (rs6000_gdbarch_init): Initialize "vX" aliases as
7425         pseudo-registers.  Restore registration of
7426         rs6000_pseudo_register_reggroup_p with
7427         set_tdesc_pseudo_register_reggroup_p.
7428
7429 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
7430
7431         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
7432         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
7433         set_gdbarch_num_pseudo_regs.
7434
7435 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7436
7437         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
7438         Remove arg prefixname, add do_set and do_show.
7439         Add member functions set_list and show_list.
7440         * cli/cli-style.c (class cli_style_option): Update accordingly.
7441         (style_set_list): Move to file scope.
7442         (style_show_list): Likewise.
7443         (set_style): Call help_list.
7444         (show_style): Call cmd_show_list.
7445         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
7446         Update to use the new macro.
7447
7448 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
7449
7450         * ada-lang.c (_initialize_ada_language): Expand the help text
7451         for the "catch exception" command.
7452
7453 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7454
7455         * symtab.c (matching_obj_sections): Initialize obj,
7456         declare it closer to its usage.
7457
7458 2019-01-10  Tom Tromey  <tom@tromey.com>
7459
7460         * thread-iter.h (inf_threads_iterator): Use next_iterator.
7461         (basic_inf_threads_range): Remove.
7462         (inf_threads_range, inf_non_exited_threads_range)
7463         (safe_inf_threads_range): Use next_adapter.
7464
7465 2019-01-10  Keith Seitz  <keiths@redhat.com>
7466
7467         PR gdb/23712
7468         PR symtab/23010
7469         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
7470         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
7471
7472 2019-01-10  Keith Seitz  <keiths@redhat.com>
7473
7474         PR gdb/23712
7475         PR symtab/23010
7476         * dictionary.c (pending_to_vector): Remove.
7477         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7478         Remove _1 suffix, replacing functions of the same name.  Update
7479         all callers.
7480         (dict_create_hashed, dict_create_hashed_expandable)
7481         (dict_create_linear, dict_create_linear_expandable, dict_free)
7482         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
7483         Make functions static.
7484
7485 2019-01-10  Keith Seitz  <keiths@redhat.com>
7486
7487         PR gdb/23712
7488         PR symtab/23010
7489         * dictionary.h (struct dictionary): Replace declaration with
7490         multidictionary.
7491         (dict_create_hashed, dict_create_hashed_expandable)
7492         (dict_create_linear, dict_create_linear_expandable)
7493         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
7494         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
7495         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
7496         taking multidictionary argument.
7497         [ALL_DICT_SYMBOLS]: Update for multidictionary.
7498         * block.h (struct block) <dict>: Change to multidictionary
7499         and rename `multidict'.
7500         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
7501         symmisc.c: Update all dictionary references to multidictionary.
7502
7503 2019-01-10  Keith Seitz  <keiths@redhat.com>
7504
7505         PR gdb/23712
7506         PR symtab/23010
7507         * dictionary.c: Include unordered_map.
7508         (pending_to_vector): New function.
7509         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7510         Rewrite the non-"_1" functions to take vector instead
7511         of linked list.
7512         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
7513         "new" _1 versions of the same name.
7514         (multidictionary): Define.
7515         (std::hash<enum language): New definition.
7516         (collate_pending_symbols_by_language, mdict_create_hashed)
7517         (mdict_create_hashed_expandable, mdict_create_linear)
7518         (mdict_create_linear_expandable, mdict_free)
7519         (find_language_dictionary, create_new_language_dictionary)
7520         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
7521         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
7522         (mdict_size, mdict_empty): New functions.
7523         * dictionary.h (mdict_iterator): Define.
7524
7525 2019-01-10  Pedro Alves  <palves@redhat.com>
7526
7527         * breakpoint.c (read_uploaded_action)
7528         (create_tracepoint_from_upload): Adjust to use
7529         gdb::unique_xmalloc_ptr.
7530         * ctf.c (ctf_write_uploaded_tp):
7531         (SET_ARRAY_FIELD): Use emplace_back.
7532         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
7533         * tracefile-tfile.c (tfile_write_uploaded_tp):
7534         * tracepoint.c (parse_tracepoint_definition): Adjust to use
7535         gdb::unique_xmalloc_ptr.
7536         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
7537         at_string, cond_string, cmd_strings>: Replace char pointers
7538         with gdb::unique_xmalloc_ptr.
7539
7540 2019-01-10  Pedro Alves  <palves@redhat.com>
7541
7542         * solib-target.c (library_list_start_library): Don't xstrdup name.
7543
7544 2019-01-10  Pedro Alves  <palves@redhat.com>
7545
7546         * mdebugread.c (parse_partial_symbols): Use
7547         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
7548
7549 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7550
7551         * linux-fork.c (scoped_switch_fork_info)
7552         <~scoped_switch_fork_info>: Fix incorrect variable name.
7553
7554 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7555
7556         * linux-fork.c (scoped_switch_fork_info)
7557         <scoped_switch_fork_info>: Make explicit.
7558         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
7559
7560 2019-01-10  Tom Tromey  <tom@tromey.com>
7561
7562         * objfiles.h (objfile::reset_psymtabs): Update.
7563         * objfiles.c (objfile::objfile): Update.
7564         * psymtab.h (psymtab_storage::obstack): Update.
7565         (psymtab_storage::m_obstack): Use gdb::optional.
7566         (class psymtab_storage): Update comment.  Remove objfile
7567         parameter.
7568         * psymtab.c (psymtab_storage::psymtab_storage): Update.
7569
7570 2019-01-10  Tom Tromey  <tom@tromey.com>
7571
7572         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
7573         <free_psymtabs>: Now private.
7574         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
7575         (allocate_psymtab): Use new method.
7576
7577 2019-01-10  Tom Tromey  <tom@tromey.com>
7578
7579         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
7580         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
7581         * mdebugread.c (parse_partial_symbols): Use
7582         allocate_dependencies.
7583         * dwarf2read.c (dwarf2_create_include_psymtab): Use
7584         allocate_dependencies.
7585         (process_psymtab_comp_unit_reader)
7586         (build_type_psymtab_dependencies): Likewise.
7587         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
7588
7589 2019-01-10  Tom Tromey  <tom@tromey.com>
7590
7591         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
7592         PSYMBOL_SET_LANGUAGE.
7593         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
7594
7595 2019-01-10  Tom Tromey  <tom@tromey.com>
7596
7597         * psymtab.h (psymtab_storage::obstack): New method.
7598         <m_obstack>: Rename from obstack; now private.
7599         * psymtab.c (psymtab_storage): Update.
7600         * dwarf2read.c (create_addrmap_from_index)
7601         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
7602         Update.
7603
7604 2019-01-10  Tom Tromey  <tom@tromey.com>
7605
7606         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
7607         * objfiles.h (objfile::reset_psymtabs): New method.
7608
7609 2019-01-10  Tom Tromey  <tom@tromey.com>
7610
7611         * symmisc.c (print_symbol_bcache_statistics): Update.
7612         (print_objfile_statistics): Update.
7613         * symfile.c (reread_symbols): Update.
7614         * psymtab.h (class psymtab_storage): New.
7615         * psymtab.c (psymtab_storage): New constructor.
7616         (~psymtab_storage): New destructor.
7617         (require_partial_symbols): Update.
7618         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
7619         (find_pc_sect_psymtab, find_pc_sect_psymbol)
7620         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
7621         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
7622         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
7623         (start_psymtab_common, end_psymtab_common)
7624         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
7625         (allocate_psymtab): Update.
7626         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
7627         Update.
7628         (dump_psymtab_addrmap, maintenance_print_psymbols)
7629         (maintenance_check_psymtabs): Update.
7630         (class objfile_psymtabs): Move to objfiles.h.
7631         * psympriv.h (discard_psymtab): Now inline.
7632         (psymtab_discarder::psymtab_discarder): Update.
7633         (psymtab_discarder::~psymtab_discarder): Update.
7634         (ALL_OBJFILE_PSYMTABS): Rewrite.
7635         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
7636         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
7637         Remove fields.
7638         <partial_symtabs>: New field.
7639         (class objfile_psymtabs): Move from psymtab.h.  Update.
7640         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
7641         psymbol_cache.
7642         (objfile::~objfile): Don't destroy psymbol_cache.
7643         * mdebugread.c (parse_partial_symbols): Update.
7644         * dwarf2read.c (create_addrmap_from_index)
7645         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
7646         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
7647         (add_partial_subprogram, dwarf2_ranges_read): Update.
7648         * dwarf-index-write.c (write_address_map)
7649         (write_one_signatured_type, recursively_write_psymbols)
7650         (class debug_names, class debug_names, write_psymtabs_to_index):
7651         Update.
7652
7653 2019-01-10  Tom Tromey  <tom@tromey.com>
7654
7655         * symtab.h (SYMBOL_SET_NAMES): Update.
7656         (symbol_set_names): Update.
7657         (MSYMBOL_SET_NAMES): Update.
7658         * symtab.c (symbol_set_names): Change argument to be an
7659         objfile_per_bfd_storage.
7660         * psymtab.c (add_psymbol_to_bcache): Update.
7661         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
7662
7663 2019-01-10  Tom Tromey  <tom@tromey.com>
7664
7665         * symtab.c (create_demangled_names_hash): Change argument to be an
7666         objfile_per_bfd_storage.
7667         (symbol_set_names): Update.
7668
7669 2019-01-10  Tom Tromey  <tom@tromey.com>
7670
7671         * xcoffread.c (xcoff_initial_scan): Unconditionally call
7672         init_psymbol_list.
7673         * psymtab.c (init_psymbol_list): Do nothing if already called.
7674         * psympriv.h (init_psymbol_list): Add comment.
7675         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
7676         init_psymbol_list.
7677         * dbxread.c (dbx_symfile_read): Unconditionally call
7678         init_psymbol_list.
7679
7680 2019-01-10  Tom Tromey  <tom@tromey.com>
7681
7682         * xcoffread.c (scan_xcoff_symtab): Update.
7683         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
7684         "where".
7685         * mdebugread.c (parse_partial_symbols)
7686         (handle_psymbol_enumerators): Update.
7687         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
7688         * dbxread.c (read_dbx_symtab): Update.
7689         * psympriv.h (psymbol_placement): New enum.
7690         (add_psymbol_to_list): Update.
7691
7692 2019-01-10  Tom Tromey  <tom@tromey.com>
7693
7694         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
7695         static_psymbols parameters.
7696         (scan_xcoff_symtab): Update.
7697         * psymtab.c (start_psymtab_common): Remove global_psymbols and
7698         static_psymbols parameters.
7699         * psympriv.h (start_psymtab_common): Update.
7700         * mdebugread.c (parse_partial_symbols): Update.
7701         * dwarf2read.c (create_partial_symtab): Update.
7702         * dbxread.c (read_dbx_symtab): Update.
7703         (start_psymtab): Remove global_psymbols and static_psymbols
7704         parameters.
7705
7706 2019-01-10  Tom Tromey  <tom@tromey.com>
7707
7708         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
7709         * psymtab.c (allocate_psymtab): Add comment.
7710         * psympriv.h (allocate_psymtab): Add comment.
7711         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
7712         initializations.
7713         * dbxread.c (dbx_end_psymtab): Remove some initializations.
7714
7715 2019-01-10  Tom Tromey  <tom@tromey.com>
7716
7717         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7718         Don't declare.
7719         * mipsread.c: Include mdebugread.h.
7720         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7721         Declare.
7722         * elfread.c: Include mdebugread.h.
7723
7724 2019-01-09  Tom Tromey  <tom@tromey.com>
7725
7726         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
7727         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
7728         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
7729         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
7730         (psym_lookup_symbol, psym_find_last_source_symtab)
7731         (psym_forget_cached_source_info, psym_print_stats)
7732         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
7733         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
7734         (psym_map_matching_symbols, psym_expand_symtabs_matching)
7735         (psym_find_compunit_symtab_by_address)
7736         (maintenance_print_psymbols, maintenance_info_psymtabs)
7737         (maintenance_check_psymtabs): Use ranged for.
7738         * psymtab.h (class objfile_psymtabs): New.
7739         (require_partial_symbols): Return objfile_psymtabs.
7740         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
7741
7742 2019-01-09  Tom Tromey  <tom@tromey.com>
7743
7744         * symfile.c (overlay_invalidate_all, find_pc_overlay)
7745         (find_pc_mapped_section, list_overlays_command)
7746         (map_overlay_command, unmap_overlay_command)
7747         (simple_overlay_update): Use all_objfiles.
7748         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
7749         * printcmd.c (info_symbol_command): Use all_objfiles.
7750         * objfiles.h (ALL_OBJSECTIONS): Remove.
7751         * maint.c (maintenance_translate_address): Use all_objfiles.
7752         * gcore.c (gcore_create_callback): Use all_objfiles.
7753         (objfile_find_memory_regions): Likewise.
7754
7755 2019-01-09  Tom Tromey  <tom@tromey.com>
7756
7757         * symtab.c (find_line_symtab, info_sources_command)
7758         (make_source_files_completion_list): Use objfile_compunits.
7759         * source.c (select_source_symtab): Use objfile_compunits.
7760         * objfiles.h (struct objfile): Update comment.
7761         (ALL_OBJFILES): Remove.
7762         (ALL_FILETABS): Remove.
7763         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
7764         objfile_compunits.
7765
7766 2019-01-09  Tom Tromey  <tom@tromey.com>
7767
7768         * symmisc.c (print_objfile_statistics, dump_objfile)
7769         (maintenance_print_symbols): Use compunit_filetabs.
7770         * source.c (forget_cached_source_info_for_objfile): Use
7771         compunit_filetabs.
7772         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
7773         (ALL_FILETABS): Use compunit_filetabs.
7774         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
7775         * coffread.c (coff_symtab_read): Use compunit_filetabs.
7776
7777 2019-01-09  Tom Tromey  <tom@tromey.com>
7778
7779         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
7780         (compunit_filetabs): New.
7781         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
7782         compunit_filetabs.
7783         (info_sources_command, make_source_files_completion_list): Remove
7784         declaration.
7785         * symmisc.c (print_objfile_statistics, dump_objfile)
7786         (maintenance_print_symbols): Remove declaration.
7787         (maintenance_info_symtabs): Use compunit_filetabs.
7788         (maintenance_info_line_tables): Likewise.
7789         * source.c (select_source_symtab): Change local variable name.
7790         (forget_cached_source_info_for_objfile): Remove declaration.
7791         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
7792         * objfiles.c (objfile_relocate1): Remove declaration.
7793         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7794         declaration.
7795         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
7796         * coffread.c (coff_symtab_read): Remove declaration.
7797         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
7798         compunit_filetabs.
7799
7800 2019-01-09  Tom Tromey  <tom@tromey.com>
7801
7802         * symtab.c (lookup_objfile_from_block)
7803         (find_pc_sect_compunit_symtab, search_symbols)
7804         (default_collect_symbol_completion_matches_break_on): Use
7805         objfile_compunits.
7806         * objfiles.h (ALL_COMPUNITS): Remove.
7807         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
7808         * cp-support.c (add_symbol_overload_list_qualified): Use
7809         objfile_compunits.
7810         * ada-lang.c (ada_collect_symbol_completion_matches)
7811         (ada_add_global_exceptions): Use objfile_compunits.
7812
7813 2019-01-09  Tom Tromey  <tom@tromey.com>
7814
7815         * source.c (select_source_symtab)
7816         (forget_cached_source_info_for_objfile): Remove declaration.
7817         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7818         declaration.
7819         * maint.c (count_symtabs_and_blocks): Remove declaration.
7820         * cp-support.c (add_symbol_overload_list_qualified): Remove
7821         declaration.
7822         * coffread.c (coff_symtab_read): Remove declaration.
7823         * symtab.c (lookup_symbol_in_objfile_symtabs)
7824         (basic_lookup_transparent_type_1): Use objfile_compunits.
7825         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
7826         (info_sources_command, search_symbols)
7827         (default_collect_symbol_completion_matches_break_on)
7828         (make_source_files_completion_list): Remove declaration.
7829         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
7830         (ada_collect_symbol_completion_matches)
7831         (ada_add_global_exceptions): Remove declaration.
7832         * linespec.c (iterate_over_all_matching_symtabs): Use
7833         objfile_compunits.
7834         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
7835         (class objfile_compunits): New.
7836         (ALL_COMPUNITS): Use objfile_compunits.
7837         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
7838         (maintenance_check_symtabs, maintenance_info_line_tables): Use
7839         objfile_compunits.
7840         * objfiles.c (objfile_relocate1): Use objfile_compunits.
7841
7842 2019-01-09  Tom Tromey  <tom@tromey.com>
7843
7844         * symtab.c (search_symbols)
7845         (default_collect_symbol_completion_matches_break_on): Use
7846         objfile_msymbols.
7847         * ada-lang.c (ada_lookup_simple_minsym)
7848         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
7849         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
7850         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
7851         objfile_msymbols.
7852         * coffread.c (coff_symfile_read): Use objfile_msymbols.
7853         * symmisc.c (dump_msymbols): Use objfile_msymbols.
7854         * objc-lang.c (find_methods): Use objfile_msymbols.
7855         (info_selectors_command, info_classes_command): Likewise.
7856         * stabsread.c (scan_file_globals): Use objfile_msymbols.
7857         * objfiles.h (class objfile_msymbols): New.
7858         (ALL_OBJFILE_MSYMBOLS): Remove.
7859         (ALL_MSYMBOLS): Remove.
7860
7861 2019-01-09  Tom Tromey  <tom@tromey.com>
7862
7863         * common/next-iterator.h (next_adapter): Add Iterator template
7864         parameter.
7865         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
7866         (class all_objfiles_safe): New.
7867         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
7868         * objfiles.c (put_objfile_before): Update comment.
7869         (add_separate_debug_objfile): Likewise.
7870         (free_all_objfiles): Use all_objfiles_safe.
7871         (objfile_purge_solibs): Likewise.
7872
7873 2019-01-09  Tom Tromey  <tom@tromey.com>
7874
7875         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7876         (expand_symtab_containing_pc, lookup_static_symbol)
7877         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
7878         (find_symbol_at_address, find_line_symtab, find_main_name): Use
7879         all_objfiles.
7880         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
7881         * breakpoint.c (create_overlay_event_breakpoint)
7882         (create_longjmp_master_breakpoint)
7883         (create_std_terminate_master_breakpoint)
7884         (create_exception_master_breakpoint): Use all_objfiles.
7885         * linux-thread-db.c (try_thread_db_load_from_pdir)
7886         (has_libpthread): Use all_objfiles.
7887         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
7888         * linespec.c (iterate_over_all_matching_symtabs)
7889         (search_minsyms_for_name): Use all_objfiles.
7890         * maint.c (maintenance_info_sections): Use all_objfiles.
7891         * main.c (captured_main_1): Use all_objfiles.
7892         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
7893         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
7894         * guile/scm-pretty-print.c
7895         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
7896         * solib-spu.c (append_ocl_sos): Use all_objfiles.
7897         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
7898         (maintenance_print_msymbols): Use all_objfiles.
7899         * source.c (select_source_symtab): Use all_objfiles.
7900         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
7901         * symfile.c (remove_symbol_file_command)
7902         (expand_symtabs_matching, map_symbol_filenames): Use
7903         all_objfiles.
7904         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
7905         all_objfiles.
7906         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
7907         * objc-lang.c (find_methods): Use all_objfiles.
7908         * objfiles.c (have_partial_symbols, have_full_symbols)
7909         (have_minimal_symbols, qsort_cmp)
7910         (default_iterate_over_objfiles_in_search_order): Use
7911         all_objfiles.
7912         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
7913         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
7914         (maintenance_check_psymtabs): Use all_objfiles.
7915         (ALL_PSYMTABS): Remove.
7916         * compile/compile-object-run.c (do_module_cleanup): Use
7917         all_objfiles.
7918         * blockframe.c (find_pc_partial_function): Use all_objfiles.
7919         * cp-support.c (add_symbol_overload_list_qualified): Use
7920         all_objfiles.
7921         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7922         Use all_objfiles.
7923         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
7924         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
7925         all_objfiles.
7926         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7927         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
7928         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7929         Uses all_objfiles.
7930         * solib.c (solib_read_symbols): Use all_objfiles
7931
7932 2019-01-09  Tom Tromey  <tom@tromey.com>
7933
7934         * probe.c (parse_probes_in_pspace): Use all_objfiles.
7935         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
7936         all_objfiles.
7937         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
7938         * symmisc.c (print_symbol_bcache_statistics)
7939         (print_objfile_statistics, maintenance_print_objfiles)
7940         (maintenance_info_symtabs, maintenance_check_symtabs)
7941         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
7942         all_objfiles.
7943         * source.c (forget_cached_source_info): Use all_objfiles.
7944         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
7945         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7946         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
7947         * objfiles.c (update_section_map): Use all_objfiles.
7948         (shared_objfile_contains_address_p): Likewise.
7949         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
7950         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
7951
7952 2019-01-09  Tom Tromey  <tom@tromey.com>
7953
7954         * common/next-iterator.h: New file.
7955         * objfiles.h (class all_objfiles): New.
7956         (struct objfile_iterator): New.
7957
7958 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7959
7960         * NEWS: Move the description of the changed "frame", "select-frame",
7961          and "info frame" commands to the Changed commands section.
7962
7963 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
7964
7965         * gdbtypes.c (check_stub_method_group): Remove handling of old
7966         mangling schemes.
7967         * linespec.c (find_methods): Likewise.
7968         * stabsread.c (read_member_functions): Likewise.
7969         * valops.c (search_struct_method): Likewise.
7970         (value_struct_elt_for_reference): Likewise.
7971         * NEWS: Mention this change.
7972
7973 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7974
7975         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
7976         print_source_lines.
7977         * source.c (print_source_lines_base): Update line number check.
7978         (print_source_lines): New function.
7979         (source_lines_range::source_lines_range): New function.
7980         * source.h (class source_lines_range): New class.
7981         (print_source_lines): New declaration.
7982
7983 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7984
7985         * linespec.c (linespec_state_destructor): Free self->canonical_names.
7986
7987 2019-01-08  Tom Tromey  <tom@tromey.com>
7988             Simon Marchi  <simon.marchi@ericsson.com>
7989
7990         PR gdb/24060
7991         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
7992         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
7993         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7994         * f-exp.y (DOLLAR_VARIABLE): Likewise.
7995         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
7996         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7997
7998 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7999
8000         * source.c (select_source_symtab): Move header comment to
8001         declaration in source.h.
8002         (forget_cached_source_info_for_objfile): Likewise.
8003         (forget_cached_source_info): Likewise.
8004         (identify_source_line): Likewise.
8005         * source.h (identify_source_line): Move declaration from symtab.h
8006         and add comment from source.c
8007         (print_source_lines): Likewise.
8008         (forget_cached_source_info_for_objfile): Likewise.
8009         (forget_cached_source_info): Likewise.
8010         (select_source_symtab): Likewise.
8011         (enum print_source_lines_flag): Move definition from symtab.h.
8012         * symtab.h (identify_source_line): Move declaration to source.h.
8013         (print_source_lines): Likewise.
8014         (forget_cached_source_info_for_objfile): Likewise.
8015         (forget_cached_source_info): Likewise.
8016         (select_source_symtab): Likewise.
8017         (enum print_source_lines_flag): Move definition to source.h.
8018         * tui/tui-hooks.c: Add 'source.h' include.
8019
8020 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8021
8022         * source.c (print_source_lines_base): Handle requests to print
8023         reverse line number sequences, and guard against empty lines
8024         string.
8025
8026 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8027
8028         * source.c (print_source_lines_base): Fix skip of '\r' if next
8029         character is '\n'.
8030
8031 2019-01-06  Tom Tromey  <tom@tromey.com>
8032
8033         * c-exp.y (struct c_parse_state) <macro_original_text,
8034         expansion_obstack>: New member.
8035         (macro_original_text, expansion_obstack): Remove globals.
8036         (scan_macro_expansion, scanning_macro_expansion)
8037         (finished_macro_expansion): Update.
8038         (scan_macro_cleanup): Remove.
8039         (yylex, c_parse): Update.
8040
8041 2019-01-06  Tom Tromey  <tom@tromey.com>
8042
8043         * c-exp.y (struct c_parse_state) <strings>: New member.
8044         (operator_stoken): Update.
8045
8046 2019-01-06  Tom Tromey  <tom@tromey.com>
8047
8048         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
8049         (union type_stack_elt) <typelist_val>: Now a pointer to
8050         std::vector.
8051         (type_stack_cleanup): Don't declare.
8052         (push_typelist): Update.
8053         * parse.c (pop_typelist): Return a std::vector.
8054         (push_typelist): Take a std::vector.
8055         (follow_types): Update.  Do not free args.
8056         (type_stack_cleanup): Remove.
8057         * c-exp.y (struct c_parse_state): New.
8058         (cpstate): New global.
8059         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
8060         (nonempty_typelist): Update.
8061         (func_mod): Create a new vector.
8062         (c_parse): Create a c_parse_state.
8063         (check_parameter_typelist): Do not delete params.
8064         (function_method): Update.  Do not delete type_list.
8065
8066 2019-01-06  Tom Tromey  <tom@tromey.com>
8067
8068         PR gdb/28155:
8069         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
8070         check_typedef.
8071         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
8072         (print_return_value): Likewise.
8073
8074 2019-01-05  Tom Tromey  <tom@tromey.com>
8075
8076         * contrib/cleanup_check.py: Remove.
8077         * contrib/gcc-with-excheck: Remove.
8078         * contrib/exsummary.py: Remove.
8079         * contrib/excheck.py: Remove.
8080
8081 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
8082
8083         * thread.c (delete_thread_1): Add gdb_assert that THR is not
8084         NULL. Initialize tpprev to NULL instead of assigning it
8085         to NULL on the next statement.
8086         * windows-nat.c (windows_delete_thread): Remove check for
8087         main_thread_id before printing thread exit notifications.
8088         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
8089         Remove thread ID check against main_thread_id.
8090         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
8091         windows_delete_thread.
8092         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
8093
8094 2019-01-04  Tom Tromey  <tom@tromey.com>
8095
8096         * compile/compile.c (_initialize_compile): Use upper case for
8097         metasyntactic variables.
8098         * symmisc.c (_initialize_symmisc): Use upper case for
8099         metasyntactic variables.
8100         * psymtab.c (_initialize_psymtab): Use upper case for
8101         metasyntactic variables.
8102         * demangle.c (demangle_command): Use upper case for metasyntactic
8103         variables.
8104         (_initialize_demangler): Likewise.
8105         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
8106         variables.
8107
8108 2019-01-03  Tom Tromey  <tom@tromey.com>
8109
8110         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
8111
8112 2019-01-03  Tom Tromey  <tom@tromey.com>
8113
8114         * python/py-symtab.c (salpy_str): Update.
8115         (struct salpy_sal_object) <symtab>: Now a PyObject.
8116         (salpy_dealloc): Update.
8117         (del_objfile_sal): Use gdbpy_ref.
8118
8119 2019-01-03  Tom Tromey  <tom@tromey.com>
8120
8121         * python/py-type.c (convert_field): Use new_reference.  Return
8122         gdbpy_ref.
8123         (make_fielditem): Return gdbpy_ref.
8124         (typy_fields): Update.
8125         (typy_getitem): Update.
8126         (field_name): Return gdbpy_ref.  Use new_reference.
8127         (typy_iterator_iternext): Update.
8128
8129 2019-01-03  Tom Tromey  <tom@tromey.com>
8130
8131         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
8132
8133 2019-01-03  Tom Tromey  <tom@tromey.com>
8134
8135         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
8136         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
8137         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
8138         (pspy_set_frame_filters, pspy_set_frame_unwinders)
8139         (pspy_set_type_printers): Likewise.
8140         * python/py-function.c (fnpy_init): Use gdbpy_ref.
8141         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
8142         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
8143         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
8144         (objfpy_set_type_printers): Likewise.
8145
8146 2019-01-03  Tom Tromey  <tom@tromey.com>
8147
8148         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
8149         (gdbpy_print_stack): Use gdbpy_err_fetch.
8150         * python/python-internal.h (class gdbpy_err_fetch): New class.
8151         (class gdbpy_enter) <m_error_type, m_error_value,
8152         m_error_traceback>: Remove.
8153         <m_error>: New member.
8154         (gdbpy_exception_to_string): Don't declare.
8155         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
8156         * python/py-value.c (convert_value_from_python): Use
8157         gdbpy_err_fetch.
8158         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
8159         gdbpy_exception_to_string.
8160         (gdbpy_handle_exception): Use gdbpy_err_fetch.
8161         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
8162         gdbpy_err_fetch.
8163
8164 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8165
8166         * linux-nat.c (delete_lwp_cleanup): Delete.
8167         (struct lwp_deleter): New struct.
8168         (lwp_info_up): New typedef.
8169         (linux_nat_target::follow_fork): Delete cleanup, and make use of
8170         lwp_info_up.
8171
8172 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8173
8174         * linux-fork.c (class scoped_switch_fork_info): New class.
8175         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
8176
8177 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8178
8179         * valops.c (find_overload_match): Remove use of null_cleanup, and
8180         calls to do_cleanups.
8181
8182 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8183
8184         * compile/compile-cplus-types.c
8185         (compile_cplus_instance::decl_name): Handle changes to
8186         cp_func_name.
8187         * cp-support.c (cp_func_name): Update header comment, update
8188         return type.
8189         * cp-support.h (cp_func_name): Update return type in declaration.
8190         * valops.c (find_overload_match): Move temp_func local to top
8191         level of function and change its type.  Use temp_func to hold and
8192         delete temporary string obtained from cp_func_name.
8193
8194 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8195
8196         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
8197         gdb::char_vector, remove cleanup, and update uses of `msg`.
8198
8199 2019-01-03  Jim Wilson  <jimw@sifive.com>
8200
8201         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
8202
8203 2019-01-02  Tom Tromey  <tom@tromey.com>
8204
8205         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
8206         (tdesc_parse_xml): Remove cleanups.
8207         * target-descriptions.h (make_cleanup_free_target_description):
8208         Don't declare.
8209         (target_desc_deleter): New struct.
8210         (target_desc_up): New typedef.
8211         * target-descriptions.c (target_desc_deleter::operator()): Rename
8212         from free_target_description.
8213         (make_cleanup_free_target_description): Remove.
8214
8215 2019-01-02  Tom Tromey  <tom@tromey.com>
8216
8217         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
8218         constructor, destructor.
8219         (linespec_parser): Remove typedef.
8220         (~linespec_parser): Rename from linespec_parser_delete.
8221         (linespec_lex_to_end, linespec_complete_label)
8222         (linespec_complete): Update.
8223         (decode_line_full): Remove cleanups.
8224         (decode_line_1): Update.
8225
8226 2019-01-02  Tom Tromey  <tom@tromey.com>
8227
8228         * python/python-internal.h (inferior_to_inferior_object): Change
8229         return type.
8230         * python/py-exitedevent.c (create_exited_event_object): Update.
8231         * python/py-inferior.c (inferior_to_inferior_object): Return
8232         gdbpy_ref.
8233         (python_new_inferior, python_inferior_deleted)
8234         (thread_to_thread_object, delete_thread_object)
8235         (build_inferior_list, gdbpy_selected_inferior): Update.
8236         * python/py-infthread.c (create_thread_object): Update.  Also fail
8237         if inferior_to_inferior_object fails.
8238
8239 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
8240
8241         * inferior.h (class inferior) <displaced_step_state>: New field.
8242         * infrun.h (struct displaced_step_state): Move here from
8243         infrun.c.  Initialize fields, add constructor.
8244         <inf>: Remove field.
8245         <reset>: New method.
8246         * infrun.c (struct displaced_step_inferior_state): Move to
8247         infrun.h.
8248         (displaced_step_inferior_states): Remove.
8249         (get_displaced_stepping_state): Adust.
8250         (displaced_step_in_progress_any_inferior): Adjust.
8251         (displaced_step_in_progress_thread): Adjust.
8252         (displaced_step_in_progress): Adjust.
8253         (add_displaced_stepping_state): Remove.
8254         (get_displaced_step_closure_by_addr): Adjust.
8255         (remove_displaced_stepping_state): Remove.
8256         (infrun_inferior_exit): Call displaced_step_state.reset.
8257         (use_displaced_stepping): Don't check for NULL.
8258         (displaced_step_prepare_throw): Call
8259         get_displaced_stepping_state.
8260         (displaced_step_fixup): Don't check for NULL.
8261         (prepare_for_detach): Don't check for NULL.
8262
8263 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8264
8265         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
8266          in case of call that did not complete.
8267
8268 2019-01-02  Andrey Utkin  <autkin@undo.io>
8269
8270         * symfile.c (find_separate_debug_file): Fix search of debug files for
8271         remote debuggee.
8272
8273 2019-01-02  Tom Tromey  <tom@tromey.com>
8274
8275         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
8276         indentation.
8277         * python/py-frame.c (frapy_older): Remove cast.
8278         (frapy_newer): Likewise.
8279         * python/py-breakpoint.c (local_setattro): Remove cast.
8280         * python/py-arch.c (archpy_name): Remove local variable.
8281         * python/py-type.c (gdbpy_lookup_type): Remove cast.
8282
8283 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
8284
8285         * unittests/basic_string_view/element_access/char/empty.cc:
8286         Fix year range in copyright header.
8287
8288 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8289
8290         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
8291         Delete.
8292         <operator==>: Update with for removed field.
8293         <hash>: Likewise.
8294         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
8295         <isa_features>: ...this.
8296         <abi_features>: New field.
8297         (riscv_isa_flen): Update comment.
8298         (riscv_abi_xlen): New declaration.
8299         (riscv_abi_flen): New declaration.
8300         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
8301         isa_features.
8302         (riscv_abi_xlen): New function.
8303         (riscv_isa_flen): Update to get answer from isa_features.
8304         (riscv_abi_flen): New function.
8305         (riscv_has_fp_abi): Update to get answer from abi_features.
8306         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
8307         xlen and flen.
8308         (riscv_call_info) <xlen, flen>: Update comment.
8309         (riscv_call_arg_struct): Remove invalid assertions
8310         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
8311         is removed.
8312         (riscv_gdbarch_init): Gather isa features and abi features
8313         separately, ensure both match on the gdbarch when reusing an old
8314         gdbarch.  Relax an error check to allow 32-bit abi float to run on
8315         a target with 64-bit float hardware.
8316
8317 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8318
8319         * source.c (search_command_helper): Stop reverse search
8320         when line 1 has been searched.
8321
8322 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8323
8324         * record-full.c (record_full_base_target::close): Rewrite
8325         record_full_core_buf_list free logic.
8326
8327 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8328
8329         * break-catch-syscall.c (print_one_catch_syscall): xfree
8330         the last text.
8331
8332 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8333
8334         * top.c (print_gdb_version): Update Copyright year in version
8335         message.
8336
8337 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8338
8339         Update copyright year range in all GDB files.
8340
8341 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
8342
8343         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
8344
8345 For older changes see ChangeLog-2018.
8346 \f
8347 Local Variables:
8348 mode: change-log
8349 left-margin: 8
8350 fill-column: 74
8351 version-control: never
8352 coding: utf-8
8353 End:
8354