gdb/ChangeLog

   1 2019-07-17  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
   4         seen.
   5
   6 2019-07-17  Tom Tromey  <tom@tromey.com>
   7
   8         * tui/tui-win.c (tui_source_window_base::set_new_height)
   9         (tui_source_window_base::do_make_visible_with_new_height): Use
  10         m_has_locator field directly.
  11         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
  12         method.
  13         (struct tui_source_window_base) <has_locator>: Likewise.
  14
  15 2019-07-17  Tom Tromey  <tom@tromey.com>
  16
  17         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
  18         Don't declare.
  19         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
  20         Remove.
  21         * tui/tui-win.c (tui_source_window_base::set_new_height)
  22         (tui_source_window_base::set_new_height)
  23         (make_invisible_and_set_new_height)
  24         (tui_source_window_base::do_make_visible_with_new_height)
  25         (tui_source_window_base::do_make_visible_with_new_height):
  26         Update.
  27         * tui/tui-layout.c (show_source_disasm_command, show_data)
  28         (show_source_or_disasm_and_command): Update.
  29         * tui/tui-layout.c (show_layout): Update.
  30
  31 2019-07-17  Tom Tromey  <tom@tromey.com>
  32
  33         * tui/tui-layout.c (make_data_window): Remove.
  34         (show_data): Unify creation and re-initialization cases.
  35
  36 2019-07-17  Tom Tromey  <tom@tromey.com>
  37
  38         * tui/tui-layout.c (make_source_window, make_disasm_window):
  39         Remove.
  40         (show_data): Unify creation and re-initialization cases.
  41
  42 2019-07-17  Tom Tromey  <tom@tromey.com>
  43
  44         * tui/tui-layout.c (make_command_window): Remove.
  45         (show_source_disasm_command, show_source_or_disasm_and_command):
  46         Unify creation and re-initialization cases.
  47
  48 2019-07-17  Tom Tromey  <tom@tromey.com>
  49
  50         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
  51         creation and re-initialization cases.
  52
  53 2019-07-17  Tom Tromey  <tom@tromey.com>
  54
  55         * tui/tui-regs.c (tui_get_register): Return void.
  56
  57 2019-07-17  Tom Tromey  <tom@tromey.com>
  58
  59         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
  60         Simplify.
  61
  62 2019-07-17  Tom Tromey  <tom@tromey.com>
  63
  64         * tui/tui-layout.c (show_source_disasm_command): Simplify window
  65         resetting.
  66
  67 2019-07-17  Tom Tromey  <tom@tromey.com>
  68
  69         * tui/tui.h (tui_set_layout_by_name): Don't declare.
  70         * tui/tui-regs.c (tui_reg_layout): New function.
  71         (tui_show_registers, tui_reg_command): Use it.
  72         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
  73         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
  74         parameters.
  75         (tui_layout_command): Remove.
  76
  77 2019-07-17  Tom Tromey  <tom@tromey.com>
  78
  79         * tui/tui-layout.h (tui/tui-layout): Return void.
  80         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
  81
  82 2019-07-17  Tom Tromey  <tom@tromey.com>
  83
  84         * tui/tui-layout.c (show_source_disasm_command, show_data):
  85         Update.
  86         (reset_locator): Remove.
  87         (show_source_or_disasm_and_command): Update.
  88
  89 2019-07-17  Tom Tromey  <tom@tromey.com>
  90
  91         * tui/tui-source.c (tui_source_window_base::reset): Remove
  92         win_type parameter.
  93         * tui/tui-layout.c (make_command_window, make_source_window)
  94         (make_disasm_window, make_data_window)
  95         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
  96         (reset_locator, show_source_or_disasm_and_command): Update.
  97         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
  98         win_type parameter.
  99         (struct tui_source_window_base) <reset>: Likewise.
 100
 101 2019-07-17  Tom Tromey  <tom@tromey.com>
 102
 103         * tui/tui-layout.c (show_source_disasm_command): Use
 104         reset_locator.
 105         (reset_locator): New function.
 106         (init_and_make_win): Remove.
 107         (show_source_or_disasm_and_command): Use reset_locator.
 108
 109 2019-07-17  Tom Tromey  <tom@tromey.com>
 110
 111         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
 112         condition.
 113         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
 114         Remove condition.
 115         * tui/tui-source.c (tui_source_window_base::reset): New method.
 116         * tui/tui-layout.c (make_command_window): Don't call
 117         init_and_make_win.
 118         (make_source_window, make_disasm_window): Don't call
 119         make_source_or_disasm_window.
 120         (make_data_window): Don't call init_and_make_win.  Change calling
 121         convention.
 122         (show_source_disasm_command, show_data): Simplify.
 123         (make_source_or_disasm_window): Remove.
 124         (show_source_or_disasm_and_command): Simplify.
 125         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
 126         (struct tui_source_window_base) <reset>: Likewise.
 127         <execution_info>: Remove initializer.
 128         * tui/tui-data.c (tui_source_window_base): Initialize
 129         execution_info.
 130
 131 2019-07-17  Tom Tromey  <tom@tromey.com>
 132
 133         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
 134         variable.
 135
 136 2019-07-17  Tom Tromey  <tom@tromey.com>
 137
 138         * tui/tui.c (tui_rl_other_window): Update.
 139         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
 140         superclass method first.  Always iterate over regs_content.
 141         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
 142         method.
 143         * tui/tui-win.c (tui_set_focus_command): Update.
 144
 145 2019-07-17  Tom Tromey  <tom@tromey.com>
 146
 147         * tui/tui-win.c (tui_set_focus_command): Rename from
 148         tui_set_focus.  Call tui_enable.
 149         (tui_set_focus_command): Remove.
 150
 151 2019-07-17  Tom Tromey  <tom@tromey.com>
 152
 153         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
 154         refresh_window.
 155         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
 156         touchwin.
 157         (tui_data_window::refresh_window): Call refresh_window on data
 158         items.  Always call superclass refresh_window.
 159         (tui_win_info::refresh): Remove.
 160         (tui_source_window_base::refresh_window): Update.
 161         (tui_refresh_all): Update.
 162         * tui/tui-layout.c (show_source_disasm_command): Remove call to
 163         refresh_window.
 164         (show_source_or_disasm_and_command): Likewise.
 165         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 166         (struct tui_source_window_base) <refresh>: Likewise.
 167
 168 2019-07-17  Tom Tromey  <tom@tromey.com>
 169
 170         * tui/tui-winsource.c (tui_clear_source_content)
 171         (tui_show_source_content): Update.
 172         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 173         whether content is empty.
 174         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 175         Remove.
 176
 177 2019-07-17  Tom Tromey  <tom@tromey.com>
 178
 179         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 180         window's contents.
 181         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 182         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 183
 184 2019-07-17  Tom Tromey  <tom@tromey.com>
 185
 186         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 187         (struct tui_data_item_window): Update.
 188
 189 2019-07-17  Tom Tromey  <tom@tromey.com>
 190
 191         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 192         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 193         defines.
 194
 195 2019-07-17  Tom Tromey  <tom@tromey.com>
 196
 197         * tui/tui-winsource.h (tui_erase_source_content)
 198         (tui_clear_source_content): Remove "display_prompt" parameter.
 199         * tui/tui-winsource.c (tui_update_source_window_as_is)
 200         (tui_update_source_windows_with_addr): Update.
 201         (tui_clear_source_content): Remove "display_prompt" parameter.
 202         (tui_erase_source_content): Likewise.  Simplify.
 203         (tui_show_source_content): Update.
 204         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 205         * tui/tui-stack.c (tui_show_frame_info): Update.
 206         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 207         Remove defines.
 208
 209 2019-07-17  Tom Tromey  <tom@tromey.com>
 210
 211         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 212         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 213         parameter.
 214         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 215         parameter.
 216
 217 2019-07-17  Tom Tromey  <tom@tromey.com>
 218
 219         * tui/tui-winsource.c (tui_clear_source_content)
 220         (tui_show_source_content, tui_show_exec_info_content)
 221         (tui_clear_exec_info_content): Update.
 222         * tui/tui-stack.c (tui_show_locator_content): Update.
 223         (tui_show_frame_info): Update.
 224         * tui/tui-source.h (tui_source_window): Don't declare.
 225         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 226         from tui_source_is_displayed.
 227         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 228         Remove field.
 229         (struct tui_source_window_base) <content_in_use>: New field.  Now
 230         bool.
 231         (struct tui_source_window) <showing_source_p>: New method.
 232         (TUI_SRC_WIN): Change cast.
 233         * tui/tui-data.c (tui_initialize_static_data): Update.
 234
 235 2019-07-17  Tom Tromey  <tom@tromey.com>
 236
 237         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 238         location_matches_p.
 239         * tui/tui-source.c (tui_source_window::location_matches_p): New
 240         method.
 241         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 242         method.
 243         * tui/tui-data.h (struct tui_source_window_base)
 244         <location_matches_p>: New method.
 245         (struct tui_source_window, struct tui_disasm_window)
 246         <location_matches_p>: Likewise.
 247
 248 2019-07-17  Tom Tromey  <tom@tromey.com>
 249
 250         * tui/tui-win.c (tui_set_win_height_command): Rename from
 251         tui_set_win_height.
 252         (tui_set_win_height_command): Remove.
 253
 254 2019-07-17  Tom Tromey  <tom@tromey.com>
 255
 256         * tui/tui-source.c (tui_source_window): New constructor.  Add
 257         observer.
 258         (~tui_source_window): New destructor.
 259         (tui_source_window::style_changed): New method.
 260         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 261         (tui_attach_detach_observers): Update.
 262         * tui/tui-data.h (struct tui_source_window): Make constructor not
 263         inline.  Add destructor.
 264         (struct tui_source_window) <style_changed>: New method.
 265         <m_observable>: New member.
 266
 267 2019-07-17  Tom Tromey  <tom@tromey.com>
 268
 269         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 270         * tui/tui-win.c (tui_resize_all): Fix typo.
 271
 272 2019-07-17  Tom Tromey  <tom@tromey.com>
 273
 274         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 275         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 276         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 277         * tui/tui-win.c (window_name_completer): Use foreach.
 278         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 279         (update_tab_width): Likewise.
 280         * tui/tui-layout.c (show_layout): Update.
 281         * tui/tui-data.h (class tui_window_iterator): New.
 282         (struct all_tui_windows): New.
 283         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 284
 285 2019-07-17  Tom Tromey  <tom@tromey.com>
 286
 287         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 288         parameter.  Don't reference globals.
 289         (tui_reg_command): Update.
 290
 291 2019-07-17  Tom Tromey  <tom@tromey.com>
 292
 293         * tui/tui-regs.c (tui_show_registers): Simplify.
 294
 295 2019-07-17  Tom Tromey  <tom@tromey.com>
 296
 297         * tui/tui-regs.c (tui_show_registers): Update.
 298         (tui_show_register_group): Add win_info parameter.
 299
 300 2019-07-17  Tom Tromey  <tom@tromey.com>
 301
 302         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 303         Rename from tui_display_reg_element_at_line.
 304         (tui_data_window::display_registers_from_line): Update.
 305         * tui/tui-data.h (struct tui_data_window)
 306         <display_reg_element_at_line>: New method.
 307
 308 2019-07-17  Tom Tromey  <tom@tromey.com>
 309
 310         * tui/tui-regs.h (tui_display_registers_from)
 311         (tui_display_registers_from_line): Don't declare.
 312         * tui/tui-windata.c (tui_data_window::display_all_data)
 313         (tui_data_window::refresh_all)
 314         (tui_data_window::do_scroll_vertical): Update.
 315         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 316         from tui_display_registers_from.
 317         (tui_display_reg_element_at_line): Update.
 318         (tui_data_window::display_registers_from_line): Rename from
 319         tui_display_registers_from_line.
 320         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 321         display_registers_from_line>: New methods.
 322
 323 2019-07-17  Tom Tromey  <tom@tromey.com>
 324
 325         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 326         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 327         from tui_erase_data_content.
 328         (tui_data_window::display_all_data)
 329         (tui_data_window::refresh_all)
 330         (tui_data_window::do_scroll_vertical): Update.
 331         * tui/tui-regs.c (tui_show_registers): Update.
 332         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 333         New method.
 334
 335 2019-07-17  Tom Tromey  <tom@tromey.com>
 336
 337         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 338         declare.
 339         * tui/tui-windata.c
 340         (tui_data_window::delete_data_content_windows): Rename from
 341         tui_delete_data_content_windows.
 342         (tui_data_window::display_all_data)
 343         (tui_data_window::do_scroll_vertical): Update.
 344         * tui/tui-data.h (struct tui_data_window)
 345         <delete_data_content_windows>: New method.
 346
 347 2019-07-17  Tom Tromey  <tom@tromey.com>
 348
 349         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 350         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 351
 352 2019-07-17  Tom Tromey  <tom@tromey.com>
 353
 354         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 355         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 356         from tui_display_all_data.
 357         * tui/tui-win.c
 358         (tui_data_window::do_make_visible_with_new_height): Update.
 359         * tui/tui-regs.c (tui_show_registers): Update.
 360         * tui/tui-layout.c (tui_set_layout): Update.
 361         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 362         method.
 363
 364 2019-07-17  Tom Tromey  <tom@tromey.com>
 365
 366         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 367         * tui/tui-windata.c (tui_display_data_from): Remove.
 368         (tui_data_window::refresh_all): Update.
 369
 370 2019-07-17  Tom Tromey  <tom@tromey.com>
 371
 372         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 373         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 374         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 375         tui_display_registers_from_line.
 376         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 377         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 378         "force_display" parameter.
 379
 380 2019-07-17  Tom Tromey  <tom@tromey.com>
 381
 382         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 383         declare.
 384         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 385         Rename from tui_first_reg_element_no_inline.
 386         (tui_display_reg_element_at_line)
 387         (tui_display_registers_from_line): Update.
 388         * tui/tui-data.h (struct tui_data_window)
 389         <first_reg_element_no_inline>: New method.
 390
 391 2019-07-17  Tom Tromey  <tom@tromey.com>
 392
 393         * tui/tui-windata.c (tui_display_data_from)
 394         (tui_data_window::do_scroll_vertical): Update.
 395         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 396         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 397         Rename from tui_line_from_reg_element_no.
 398         (tui_display_registers_from_line): Update.
 399         * tui/tui-data.h (struct tui_data_window)
 400         <line_from_reg_element_no>: New method.
 401
 402 2019-07-17  Tom Tromey  <tom@tromey.com>
 403
 404         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 405         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 406         tui_last_regs_line_no.
 407         (tui_display_reg_element_at_line)
 408         (tui_display_registers_from_line): Update.
 409         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 410         method.
 411
 412 2019-07-17  Tom Tromey  <tom@tromey.com>
 413
 414         PR tui/24722:
 415         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 416         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 417         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 418         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 419         (tui_update_breakpoint_info): Likewise.
 420         * tui/tui-hooks.c (tui_event_create_breakpoint)
 421         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 422         Update.
 423
 424 2019-07-17  Tom Tromey  <tom@tromey.com>
 425
 426         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 427
 428 2019-07-17  Tom Tromey  <tom@tromey.com>
 429
 430         * tui/tui-winsource.c (tui_update_source_window_as_is)
 431         (tui_update_source_windows_with_addr): Update.
 432         * tui/tui-source.h (tui_set_source_content)
 433         (tui_show_symtab_source): Add "win_info" parameter.
 434         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 435         parameter.
 436         (tui_show_symtab_source): Likewise.
 437
 438 2019-07-17  Tom Tromey  <tom@tromey.com>
 439
 440         * tui/tui-wingeneral.c
 441         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 442
 443 2019-07-17  Tom Tromey  <tom@tromey.com>
 444
 445         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 446         (struct tui_cmd_window) <can_scroll>: New method.
 447         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 448         method.
 449
 450 2019-07-17  Tom Tromey  <tromey@adacore.com>
 451
 452         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 453         do_field_signed>: Rename.  Change type of "value".
 454         * ui-out.c (ui_out::field_signed): Rename from field_int.
 455         Change type of "value".
 456         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 457         type of "value".
 458         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 459         do_field_int.  Change type of "value".
 460         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 461         do_field_int.  Change type of "value".
 462         * tracepoint.c (trace_status_mi, tfind_1)
 463         (print_one_static_tracepoint_marker): Update.
 464         * thread.c (print_thread_info_1, print_selected_thread_frame):
 465         Update.
 466         * stack.c (print_frame, print_frame_info): Update.
 467         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 468         Update.
 469         * source.c (print_source_lines_base): Update.
 470         * skip.c (info_skip_command): Update.
 471         * record-btrace.c (btrace_ui_out_decode_error)
 472         (btrace_call_history_src_line): Update.
 473         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 474         Update.
 475         * progspace.c (print_program_space): Update.
 476         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 477         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 478         do_field_int.  Change type of "value".
 479         * mi/mi-out.c (mi_ui_out::do_table_begin)
 480         (mi_ui_out::do_table_header): Update.
 481         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 482         type of "value".
 483         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 484         (mi_cmd_data_list_changed_registers, output_register)
 485         (mi_cmd_data_read_memory, mi_load_progress)
 486         (mi_cmd_trace_frame_collected): Update.
 487         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 488         Update.
 489         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 490         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 491         (mi_cmd_var_list_children, varobj_update_one): Update.
 492         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 493         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 494         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 495         * inferior.c (print_inferior): Update.
 496         * gdb_bfd.c (print_one_bfd): Update.
 497         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 498         Update.
 499         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 500         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 501         do_field_int.  Change type of "value".
 502         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 503         do_field_int.  Change type of "value".
 504         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 505         (print_one_breakpoint_location, print_it_catch_fork)
 506         (print_one_catch_fork, print_it_catch_vfork)
 507         (print_one_catch_vfork, print_it_catch_solib)
 508         (print_it_catch_exec, print_it_ranged_breakpoint)
 509         (print_mention_watchpoint, print_mention_masked_watchpoint)
 510         (bkpt_print_it, update_static_tracepoint): Update.
 511         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 512         * break-catch-syscall.c (print_it_catch_syscall): Update.
 513         * ada-tasks.c (print_ada_task_info): Update.
 514         * ada-lang.c (print_it_exception, print_mention_exception):
 515         Update.
 516
 517 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 518
 519         PR breakpoints/24541
 520         * gdbarch.c: Regenerate.
 521         * gdbarch.h: Regenerate.
 522         * gdbarch.sh: Adjust return type and parameter types for
 523         'stap_adjust_register'.
 524         (i386_stap_adjust_register): Adjust signature and return new
 525         register name.
 526         * stap-probe.c (stap_parse_register_operand): Adjust use of
 527         'gdbarch_stap_adjust_register'.
 528
 529 2019-07-17  Tom Tromey  <tromey@adacore.com>
 530
 531         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 532         declare VEC.
 533         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 534         std::vector.
 535         (struct s390_process_info): Add initializers.
 536         (s390_add_process): Use new.
 537         (s390_linux_nat_target::low_forget_process): Use delete.
 538         (s390_linux_nat_target::low_new_fork)
 539         (s390_linux_nat_target::stopped_by_watchpoint)
 540         (s390_linux_nat_target::low_prepare_to_resume)
 541         (s390_linux_nat_target::insert_watchpoint)
 542         (s390_linux_nat_target::insert_hw_breakpoint)
 543         (s390_linux_nat_target::remove_watchpoint)
 544         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 545
 546 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 547
 548         * aarch64-fbsd-nat.c: Include regcache.h.
 549         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 550         argument.
 551         (aarch64_fbsd_nat_target::fetch_registers)
 552         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 553         variable.
 554         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 555
 556 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 557
 558         * fbsd-nat.c: Include gdbarch.h.
 559
 560 2019-07-15  Tom Tromey  <tromey@adacore.com>
 561
 562         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 563
 564 2019-07-15  Tom Tromey  <tromey@adacore.com>
 565
 566         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 567         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 568         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 569         * cli-out.c (cli_ui_out::do_field_int): New method.
 570         * ui-out.c (ui_out::field_unsigned): New method.
 571         * symfile.c (generic_load): Use field_unsigned.
 572         (print_transfer_performance): Likewise.
 573         * record-btrace.c (ui_out_field_uint): Remove.
 574         (btrace_call_history_insn_range, btrace_call_history): Use
 575         field_unsigned.
 576         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 577         field_unsigned.
 578         * ui-out.h (class ui_out) <field_unsigned>: New method.
 579         <do_field_unsigned>: Likewise.
 580
 581 2019-07-15  Tom Tromey  <tromey@adacore.com>
 582
 583         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 584         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 585         * target.c (flash_erase_command): Use field_string.
 586         * infrun.c (print_signal_received_reason): Use field_string.
 587         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 588         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 589         field_string.
 590         * ada-tasks.c (print_ada_task_info): Use field_string.
 591
 592 2019-07-15  Tom Tromey  <tromey@adacore.com>
 593
 594         * target.c (flash_erase_command): Use field_core_addr.
 595         * symfile.c (generic_load): Use field_core_addr.
 596         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 597         Use field_core_addr.
 598         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 599         field_core_addr.
 600
 601 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 602
 603         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 604         value if its desired type is smaller than a CORE_ADDR and signed.
 605
 606 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 607
 608         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 609         of changes to field names, and use new is_reference field to
 610         decide if a property is a reference or not.
 611         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 612         field.
 613         (struct dwarf2_property_baton): Update header comment, rename
 614         'referenced_type' to 'property_type' and update comments.
 615         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 616         default property type, store in property baton, update to take
 617         accound of renamed field.
 618         (read_func_scope): Update call to attr_to_dynamic_prop.
 619         (read_array_type): Likewise.
 620         (dwarf2_per_cu_addr_sized_int_type): New function.
 621         (read_subrange_index_type): Move type finding code to
 622         dwarf2_per_cu_addr_sized_int_type.
 623         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 624         (dwarf2_per_cu_addr_type): New function.
 625         (set_die_type): Update calls to attr_to_dynamic_prop.
 626
 627 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 628
 629         * dwarf2read.c (read_subrange_index_type): New function.
 630         (read_subrange_type): Move code into new function and call it.
 631         * gdbtypes.c (create_range_type): Add some asserts.
 632
 633 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 634
 635         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 636         update return statements.
 637         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 638         declaration, and update comment to match.
 639         * gdbtypes.c (resolve_dynamic_array): Update call to
 640         dwarf2_evaluate_property to match new return type.
 641
 642 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 643
 644         * valarith.c (value_subscripted_rvalue): Change lowerbound
 645         parameter type from int to LONGEST.
 646         * value.h (value_subscripted_rvalue): Likewise in declaration.
 647
 648 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 649
 650         * cli/cli-utils.c (info_print_command_completer): New function.
 651         * cli/cli-utils.h: Add 'completer.h' include, and forward
 652         declaration for 'struct cmd_list_element'.
 653         (info_print_command_completer): Declare.
 654         * stack.c (_initialize_stack): Add completer for 'info locals' and
 655         'info args'.
 656         * symtab.c (_initialize_symtab): Add completer for 'info
 657         variables' and 'info functions'.
 658         * NEWS: Mention completion for additional info commands.
 659
 660 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 661
 662         * cli/cli-utils.c (extract_info_print_args): Delete.
 663         (extract_arg_maybe_quoted): Delete.
 664         (info_print_options_defs): New variable.
 665         (make_info_print_options_def_group): New function.
 666         (extract_info_print_options): Define new function.
 667         * cli/cli-utils.h (extract_info_print_args): Delete.
 668         (struct info_print_options): New structure.
 669         (extract_info_print_options): Declare new function.
 670         * stack.c (info_locals_command): Update to use new
 671         extract_info_print_options, also add a header comment.
 672         (info_args_command): Likewise.
 673         * symtab.c (info_variables_command): Likewise.
 674         (info_functions_command): Likewise.
 675
 676 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 677
 678         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 679         to extract string arguments.
 680         * common/common-utils.c (extract_string_maybe_quoted): New function.
 681         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 682
 683 2019-07-11  Tom Tromey  <tromey@adacore.com>
 684
 685         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 686         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 687         * top.h (gdbinit): Don't declare.
 688         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 689         into...
 690         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 691         * top.c (gdb_init): Don't call init_cli_cmds.
 692         (gdbinit): Remove.
 693         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 694
 695 2019-07-11  Tom Tromey  <tromey@adacore.com>
 696
 697         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 698         after it has been moved.
 699
 700 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 701
 702         * valops.c (value_must_coerce_to_target): Change return type to
 703         bool.
 704         * value.h (value_must_coerce_to_target): Likewise.
 705
 706 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 707
 708         * breakpoint.c (is_hardware_watchpoint): Remove
 709         forward-declaration.
 710         (is_masked_watchpoint): Change return type to bool.
 711         (is_tracepoint): Likewise.
 712         (is_breakpoint): Likewise.
 713         (is_hardware_watchpoint): Likewise.
 714         (is_watchpoint): Likewise.
 715         (is_no_memory_software_watchpoint): Likewise.
 716         (is_catchpoint): Likewise.
 717         (breakpoint_1): Make FILTER parameter's return type bool.
 718         is_masked_watchpoint): Change return type to bool.
 719         (save_breakpoints): Make FILTER parameter's return type bool.
 720         * breakpoint.h (is_breakpoint): Change return type to bool.
 721         (is_watchpoint): Likewise.
 722         (is_catchpoint): Likewise.
 723         (is_tracepoint): Likewise.
 724
 725 2019-07-10  Tom Tromey  <tom@tromey.com>
 726
 727         * defs.h: Don't include gdbarch.h.
 728         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 729         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 730         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 731         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 732         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 733         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 734         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 735         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 736         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 737         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 738         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 739         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 740         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 741         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 742         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 743         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 744         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 745         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 746         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 747         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 748         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 749         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 750         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 751         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 752         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 753         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 754         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 755
 756 2019-07-10  Tom Tromey  <tromey@adacore.com>
 757
 758         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 759         * breakpoint.c (init_ada_exception_breakpoint): Register as
 760         bp_catchpoint.
 761         (print_one_breakpoint_location, print_one_breakpoint): Use
 762         is_ada_exception_catchpoint.
 763         * ada-lang.c (class ada_catchpoint_location): Pass
 764         bp_loc_software_breakpoint to bp_location constructor.
 765         (is_ada_exception_catchpoint): New function.
 766
 767 2019-07-10  Tom Tromey  <tromey@adacore.com>
 768
 769         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 770         VEC.
 771         (struct arm_exidx_entry): New method operator<.
 772         (struct arm_exidx_data) <section_maps>: Change type.
 773         (arm_exidx_data_free): Remove.
 774         (arm_exidx_data_key): Change type.  Move lower.
 775         (arm_exidx_new_objfile): Update.
 776         (arm_compare_exidx_entries): Remove.
 777         (arm_find_exidx_entry, _initialize_arm_tdep)
 778
 779 2019-07-10  Tom Tromey  <tromey@adacore.com>
 780
 781         * solib-spu.c (ocl_program_data_key): Change type.
 782         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 783         Update.
 784
 785 2019-07-10  Tom Tromey  <tromey@adacore.com>
 786
 787         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 788         (struct solib_aix_inferior_data) <library_list>: Change type.
 789         (solib_aix_inferior_data_handle): Change type.
 790         (get_solib_aix_inferior_data): Update.
 791         (solib_aix_free_library_list): Remove.
 792         (library_list_start_library): Update.
 793         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 794         return type.
 795         (solib_aix_get_library_list)
 796         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 797         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 798
 799 2019-07-10  Tom Tromey  <tromey@adacore.com>
 800
 801         * solib-dsbt.c (struct dsbt_info): Add initializers.
 802         (solib_dsbt_pspace_data): Change type.
 803         (dsbt_pspace_data_cleanup): Remove.
 804         (get_dsbt_info, _initialize_dsbt_solib): Update.
 805
 806 2019-07-10  Tom Tromey  <tromey@adacore.com>
 807
 808         * spu-tdep.c (spu_overlay_data): Change type.
 809         (spu_get_overlay_table, spu_overlay_new_objfile)
 810         (_initialize_spu_tdep): Update.
 811
 812 2019-07-10  Tom Tromey  <tromey@adacore.com>
 813
 814         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 815         destructor.
 816         (dbx_objfile_data_key): Change type and declare later.
 817         (DBX_SYMFILE_INFO): Rewrite.
 818         * dbxread.c (dbx_objfile_data_key): Change type.
 819         (dbx_symfile_init): Update.
 820         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 821         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 822         (stabsect_build_psymtabs, _initialize_dbxread): Update.
 823
 824 2019-07-10  Tom Tromey  <tromey@adacore.com>
 825
 826         * jit.c (jit_program_space_key): Change type.  Move lower.
 827         (get_jit_program_space_data): Update.
 828         (jit_program_space_data_cleanup): Remove.
 829         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
 830         Update.
 831         (struct jit_program_space_data): Add initializers.
 832
 833 2019-07-10  Tom Tromey  <tromey@adacore.com>
 834
 835         * solib-darwin.c (struct darwin_info): Add initializers.
 836         (solib_darwin_pspace_data): Change type.
 837         (darwin_pspace_data_cleanup): Remove.
 838         (get_darwin_info, _initialize_darwin_solib): Update.
 839
 840 2019-07-10  Tom Tromey  <tromey@adacore.com>
 841
 842         * remote-sim.c (struct sim_inferior_data): Add initializers,
 843         constructor, and destructor.
 844         (sim_inferior_data_key): Change type.  Move lower.
 845         (check_for_duplicate_sim_descriptor): Update.
 846         (get_sim_inferior_data): Use new.  Update.
 847         (~sim_inferior_data_cleanup): Rename from
 848         sim_inferior_data_cleanup.  Simplify.
 849         (gdbsim_close_inferior, simulator_command)
 850         (sim_command_completer, _initialize_remote_sim): Update.
 851         (next_pid, INITIAL_PID): Move earlier.
 852
 853 2019-07-10  Tom Tromey  <tromey@adacore.com>
 854
 855         * python/python-internal.h (create_thread_object): Return
 856         gdbpy_ref.
 857         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
 858         * python/py-inferior.c (struct threadlist_entry): Add
 859         constructor.
 860         <thread_obj>: Now a gdbpy_ref.
 861         (thread_to_thread_object): Update.
 862         (add_thread_object): Use new.
 863         (delete_thread_object): Use delete.
 864         (infpy_threads): Update.
 865         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
 866         GIL.
 867
 868 2019-07-10  Tom Tromey  <tromey@adacore.com>
 869
 870         * valops.c (value_cast): Specialize error message for Ada.
 871
 872 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 873
 874         * breakpoint.c (breakpoint_1): Update doc and parameter names.
 875
 876 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 877
 878         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
 879         bpstat_should_step): Return bool, adjust comments.
 880         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
 881         bpstat_should_step): Likewise.
 882
 883 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 884
 885         * features/Makefile: Use feature target descriptions for Arm.
 886         * features/arm/arm-core.c: Generate new file.
 887         * features/arm/arm-fpa.c: Likewise.
 888         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
 889         * features/arm/arm-m-profile.c: Likewise.
 890         * features/arm/arm-vfpv2.c: Likewise.
 891         * features/arm/arm-vfpv3.c: Likewise.
 892         * features/arm/xscale-iwmmxt.c: Likewise.
 893         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
 894
 895 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 896
 897         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
 898         ptrace earlier.
 899
 900 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 901
 902         * features/aarch64-pauth.c: Regenerate.
 903
 904 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
 905
 906         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
 907         bool.
 908         (bpstat_what): Use false instead of 0.
 909
 910 2019-07-09  Pedro Alves  <palves@redhat.com>
 911
 912         * break-catch-throw.c (is_exception_catchpoint): New.
 913         * breakpoint.c (print_one_breakpoint_location): New parameter
 914         'raw_loc'.  Handle it.  Use
 915         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
 916         looking at the breakpoint's type.
 917         (print_one_breakpoint): If handling "maint info breakpoints", also
 918         print locations of exception catchpoints.
 919         * breakpoint.h (is_exception_catchpoint): Declare.
 920
 921 2019-07-09  Pedro Alves  <palves@redhat.com>
 922
 923         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
 924         "addr" field.
 925         (allocate_location_exception_catchpoint): New.
 926         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
 927         (initialize_throw_catchpoint_ops): Install
 928         allocate_location_exception_catchpoint as allocate_location
 929         method.
 930         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
 931         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
 932         bp_loc_other.
 933         (breakpoint_address_is_meaningful): Delete.
 934         (bl_address_is_meaningful): New.
 935         (breakpoint_locations_match): Adjust comment.
 936         (bp_location_from_bp_type): New, factored out of...
 937         (bp_location::bp_location(breakpoint *)): ... this.
 938         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
 939         factored out of...
 940         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
 941         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
 942         breakpoint_address_is_meaningful.
 943         (bp_locations_compare): Adjust comment.
 944         (update_global_location_list): Use bl_address_is_meaningful
 945         instead of breakpoint_address_is_meaningful.
 946         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
 947         explicit.
 948         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
 949         * python/py-breakpoint.c (bppy_get_location): No longer check
 950         whether location is null.
 951
 952 2019-07-09  Pedro Alves  <palves@redhat.com>
 953
 954         PR c++/15468
 955         * breakpoint.c (print_one_breakpoint_location): Remove
 956         single-location assert.
 957
 958 2019-07-09  Tom Tromey  <tom@tromey.com>
 959
 960         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
 961         * configure: Rebuild.
 962         * configure.ac: Change common to gdbsupport.
 963         * gdbsupport: Rename from common.
 964         * acinclude.m4: Change common to gdbsupport.
 965         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
 966         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
 967         gdbsupport.
 968         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
 969         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
 970         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
 971         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
 972         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
 973         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
 974         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
 975         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
 976         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
 977         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
 978         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
 979         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
 980         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
 981         coff-pe-read.c, command.h, compile/compile-c-support.c,
 982         compile/compile-c.h, compile/compile-cplus-symbols.c,
 983         compile/compile-cplus-types.c, compile/compile-cplus.h,
 984         compile/compile-loc2c.c, compile/compile.c, completer.c,
 985         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 986         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 987         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 988         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 989         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 990         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 991         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 992         features/aarch64-core.c, features/aarch64-fpu.c,
 993         features/aarch64-pauth.c, features/aarch64-sve.c,
 994         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 995         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 996         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 997         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 998         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 999         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1000         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1001         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1002         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1003         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1004         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1005         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1006         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1007         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1008         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1009         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1010         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1011         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1012         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1013         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1014         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1015         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1016         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1017         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1018         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1019         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1020         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1021         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1022         minsyms.c, mips-linux-tdep.c, namespace.h,
1023         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1024         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1025         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1026         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1027         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1028         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1029         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1030         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1031         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1032         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1033         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1034         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1035         procfs.c, producer.c, progspace.h, psymtab.h,
1036         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1037         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1038         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1039         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1040         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1041         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1042         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1043         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1044         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1045         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1046         target-memory.c, target.c, target.h, target/waitstatus.c,
1047         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1048         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1049         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1050         unittests/array-view-selftests.c,
1051         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1052         unittests/common-utils-selftests.c,
1053         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1054         unittests/format_pieces-selftests.c,
1055         unittests/function-view-selftests.c,
1056         unittests/lookup_name_info-selftests.c,
1057         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1058         unittests/mkdir-recursive-selftests.c,
1059         unittests/observable-selftests.c,
1060         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1061         unittests/parse-connection-spec-selftests.c,
1062         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1063         unittests/scoped_fd-selftests.c,
1064         unittests/scoped_mmap-selftests.c,
1065         unittests/scoped_restore-selftests.c,
1066         unittests/string_view-selftests.c, unittests/style-selftests.c,
1067         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1068         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1069         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1070         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1071         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1072         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1073
1074 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1075
1076         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1077         bool value.
1078         (decode_digits_ordinary): Set explicit_line field in sal.
1079         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1080         symtab_and_line that was set on an explicit line number in
1081         assembler code.  Do always update the recorded symtab and line if
1082         we do skip the prologue.
1083
1084 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1085
1086         * breakpoint.c (set_breakpoint_location_function): Remove
1087         explicit_loc parameter.
1088         (momentary_breakpoint_from_master): Update call to
1089         set_breakpoint_location_function.
1090         (add_location_to_breakpoint): Likewise.
1091
1092 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1093
1094         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1095         required features based on default bfd type when no specific bfd
1096         is present.
1097
1098 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1099
1100         * NEWS: Mention that GDB printf and eval commands can now print
1101         C-style and Ada-style convenience var strings without
1102         calling the inferior.
1103         * printcmd.c (printf_c_string): Locally print GDB internal var
1104         instead of transiting via the inferior.
1105         (printf_wide_c_string): Likewise.
1106
1107 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1108
1109         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1110
1111 2019-07-04  Tom Tromey  <tom@tromey.com>
1112
1113         PR tui/24724:
1114         * tui/tui-winsource.c (tui_clear_source_content): Update.
1115         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1116         (tui_update_breakpoint_info): Update.
1117         (tui_set_exec_info_content): Update.
1118         * tui/tui-source.c (tui_set_source_content_nil): Update.
1119         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1120         has_break.
1121         * tui/tui-data.h (enum tui_bp_flag): New.
1122         (tui_bp_flags): New enum flags type.
1123         (struct tui_source_element) <break_mode>: Change type.  Rename
1124         from has_break.
1125         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1126         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1127         constants.
1128         * tui/tui-winsource.h: Fix comment.
1129
1130 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1131
1132         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1133         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1134         (store_fpregs_to_thread)
1135         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1136         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1137         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1138         (IWMMXT_REGS_SIZE): Add define.
1139         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1140         (fetch_vfp_regs, store_vfp_regs)
1141         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1142         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1143
1144 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1145
1146         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1147         defines.
1148         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1149         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1150         (ARM_INT_REGISTER_SIZE): ...to this.
1151         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1152         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1153         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1154         (arm_linux_collect_gregset, supply_nwfpe_register)
1155         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1156         defines.
1157         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1158         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1159         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1160         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1161         (arm_return_in_memory, arm_store_return_value)
1162         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1163         (arm_record_ld_st_multiple): Likewise.
1164         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1165         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1166
1167 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1168
1169         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1170         AARCH64_DISPLACED_MODIFIED_INSNS.
1171         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1172         (aarch64_displaced_step_copy_insn): Likewise.
1173         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1174         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1175         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1176         ARM_DISPLACED_MODIFIED_INSNS.
1177         * arm-tdep.c (arm_gdbarch_init): Likewise.
1178         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1179         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1180         (struct arm_displaced_step_closure): Use
1181         ARM_DISPLACED_MODIFIED_INSNS.
1182
1183 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1184
1185         * features/Makefile: Remove unused xml files.
1186         * features/aarch64.xml: Remove.
1187         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1188         * features/i386/amd64-avx-avx512.xml: Remove.
1189         * features/i386/amd64-avx-linux.xml: Remove.
1190         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1191         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1192         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1193         * features/i386/amd64-avx-mpx.xml: Remove.
1194         * features/i386/amd64-avx.xml: Remove.
1195         * features/i386/amd64-linux.xml: Remove.
1196         * features/i386/amd64-mpx-linux.xml: Remove.
1197         * features/i386/amd64-mpx.xml: Remove.
1198         * features/i386/amd64.xml: Remove.
1199         * features/i386/i386-avx-avx512-linux.xml: Remove.
1200         * features/i386/i386-avx-avx512.xml: Remove.
1201         * features/i386/i386-avx-linux.xml: Remove.
1202         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1203         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1204         * features/i386/i386-avx-mpx-linux.xml: Remove.
1205         * features/i386/i386-avx-mpx.xml: Remove.
1206         * features/i386/i386-avx.xml: Remove.
1207         * features/i386/i386-linux.xml: Remove.
1208         * features/i386/i386-mmx-linux.xml: Remove.
1209         * features/i386/i386-mmx.xml: Remove.
1210         * features/i386/i386-mpx-linux.xml: Remove.
1211         * features/i386/i386-mpx.xml: Remove.
1212         * features/i386/i386.xml: Remove.
1213         * features/i386/x32-avx-avx512-linux.xml: Remove.
1214         * features/i386/x32-avx-linux.xml: Remove.
1215         * features/i386/x32-linux.xml: Remove.
1216
1217 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1218
1219         * regformats/aarch64.dat: Remove.
1220         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1221         * regformats/i386/amd64-avx-linux.dat: Remove.
1222         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1223         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1224         * regformats/i386/amd64-linux.dat: Remove.
1225         * regformats/i386/amd64-mpx-linux.dat: Remove.
1226         * regformats/i386/amd64.dat: Remove.
1227         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1228         * regformats/i386/i386-avx-linux.dat: Remove.
1229         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1230         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1231         * regformats/i386/i386-linux.dat: Remove.
1232         * regformats/i386/i386-mmx-linux.dat: Remove.
1233         * regformats/i386/i386-mpx-linux.dat: Remove.
1234         * regformats/i386/i386.dat: Remove.
1235         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1236         * regformats/i386/x32-avx-linux.dat: Remove.
1237         * regformats/i386/x32-linux.dat: Remove.
1238
1239 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1240
1241         * aarch64-tdep.c: Remove xml self tests.
1242         * amd64-linux-tdep.c: Likewise.
1243         * amd64-tdep.c: Likewise.
1244         * i386-linux-tdep.c: Likewise.
1245         * i386-tdep.c: Likewise.
1246
1247 2019-07-03  Pedro Alves  <palves@redhat.com>
1248
1249         PR cli/24732
1250         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1251         (pipe_cmd_option_defs): New.
1252         (make_pipe_cmd_options_def_group): New.
1253         (pipe_command): Use gdb::option::process_options.
1254         (pipe_command_completer): New function.
1255         (_initialize_cli_cmds): Install completer for "pipe" command.
1256
1257 2019-07-03  Pedro Alves  <palves@redhat.com>
1258
1259         * cli/cli-option.c (union option_value) <string>: New field.
1260         (struct option_def_and_value): Add ctor, move ctor, dtor and
1261         use DISABLE_COPY_AND_ASSIGN.
1262         (option_def_and_value::clear_value): New.
1263         (parse_option, save_option_value_in_ctx, get_val_type_str)
1264         (add_setshow_cmds_for_options): Handle var_string.
1265         * cli-option.h (union option_def::var_address) <string>: New
1266         field.
1267         (struct string_option_def): New.
1268         * maint-test-options.c (struct test_options_opts): Add default
1269         ctor and use DISABLE_COPY_AND_ASSIGN.
1270         <string_opt>: New field.
1271         (test_options_opts::~test_options_opts): New.
1272         (test_options_opts::dump): Also dump "-string".
1273         (test_options_option_defs): Install "string.
1274
1275 2019-07-03  Pedro Alves  <palves@redhat.com>
1276
1277         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1278         option_value with a null enumeration.
1279         (complete_options): Save the option values in the context.
1280         (save_option_value_in_ctx): New, factored out from ...
1281         (process_options): ... here.
1282         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1283         of the function.
1284         * maint-test-options.c (test_options_opts::dump): New, factored
1285         out from ...
1286         (maintenance_test_options_command_mode): ... here.
1287         (maintenance_test_options_command_completion_result): Delete.
1288         (maintenance_test_options_command_completion_text): Update
1289         comment.
1290         (maintenance_show_test_options_completion_result): Change
1291         prototype.  Just print
1292         maintenance_test_options_command_completion_text.
1293         (save_completion_result): New.
1294         (maintenance_test_options_completer_mode): Pass options context to
1295         complete_options, and then save a dump.
1296         (_initialize_maint_test_options): Use add_cmd to install "maint
1297         show test-options-completion-result".
1298
1299 2019-07-03  Pedro Alves  <palves@redhat.com>
1300
1301         * NEWS (New commands): Mention "with" and "maint with".
1302         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1303         (with_command, with_command_completer): New.
1304         (pipe_command): Adjust to new repeat_previous
1305         interface.
1306         (_initialize_cli_cmds): Install the "with" command and its "w"
1307         alias.
1308         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1309         declarations.
1310         * cli/cli-setshow.c (parse_cli_var_uinteger)
1311         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1312         argument strings for all var_types.
1313         (get_setshow_command_value_string): New, factored out from ...
1314         (do_show_command): ... this.
1315         * cli/cli-setshow.h: Include <string>.
1316         (get_setshow_command_value_string): Declare.
1317         * command.h (repeat_previous): Now returns const char *.  Adjust
1318         comment.
1319         * maint.c: Include "cli/cli-cmds.h".
1320         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1321         (_initialize_maint_cmds): Register the "maintenance with" command.
1322         * top.c (repeat_previous): Move bits from pipe_command here:
1323         Return the saved command line, if any; error out if there's no
1324         command to relaunch.
1325
1326 2019-07-03  Pedro Alves  <palves@redhat.com>
1327
1328         * NEWS (New commands): Mention "maint set/show test-settings"
1329         instead of "maint test-settings".
1330         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1331         (maintenance_test_settings_set_list): Rename to ...
1332         (maintenance_set_test_settings_list): ... this.
1333         (maintenance_test_settings_show_list): Rename to  ...
1334         (maintenance_show_test_settings_list): ... this.
1335         (maintenance_test_settings_cmd): Delete.
1336         (maintenance_test_settings_set_cmd): ...
1337         (maintenance_set_test_settings_cmd): ... this.
1338         (maintenance_test_settings_show_cmd): ...
1339         (maintenance_show_test_settings_cmd): ... this.
1340         (maintenance_test_settings_show_value_cmd):
1341         (maintenance_show_test_settings_value_cmd): ... this.
1342         (_initialize_maint_test_settings): No longer install the "maint
1343         test-settings" prefix command.  Rename "maint test-settings set"
1344         to "maint set test-settings", and "maint test-settings show" to
1345         "maint show test-settings".  Adjust all subcommands.
1346
1347 2019-07-03  Pedro Alves  <palves@redhat.com>
1348
1349         * maint-test-settings.c: Fix file's intro comment.  Replace all
1350         references to "test-options" with references to "test-settings",
1351         in comments.
1352
1353 2019-07-03  Pedro Alves  <palves@redhat.com>
1354
1355         * maint-test-settings.c (maintenance_test_settings_xxx)
1356         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1357         New.
1358         (maintenance_test_settings_enums): Use them.
1359         (maintenance_test_settings_enum): Default to
1360         maintenance_test_settings_xxx.
1361         (_initialize_maint_test_settings): Initialize
1362         MAINTENANCE_TEST_SETTINGS_FILENAME.
1363
1364 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1365
1366         * breakpoint.h (remove_breakpoints_inf): Change return type to
1367         void, move function documentation here.
1368         * breakpoint.c (remove_breakpoints_inf): Change return type to
1369         void, move function documentation to header.
1370
1371 2019-07-02  Pedro Alves  <palves@redhat.com>
1372
1373         * NEWS (Completion improvements): Mention "info threads".
1374         * thread.c (struct info_threads_opts, info_threads_option_defs)
1375         (make_info_threads_options_def_group): New.
1376         (info_threads_command): Use gdb::option::process_options.
1377         (info_threads_command_completer): New.
1378         (_initialize_thread): Use gdb::option::build_help to build the
1379         help text for "info threads".
1380
1381 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1382
1383         * defs.h (generic_load): Move from here...
1384         * symfile.h (generic_load): ... to here.  Rename name parameter
1385         to args.
1386         * symfile.c (generic_load): Add comment.
1387
1388 2019-07-01  Tom Tromey  <tromey@adacore.com>
1389
1390         * dwarf2read.c
1391         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1392         declaration of without_params.  Fix formatting.
1393
1394 2019-07-01  Tom Tromey  <tromey@adacore.com>
1395
1396         * ada-exp.y (find_primitive_type): Update.
1397         * ada-lang.h (ada_lookup_symbol): Update.
1398         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1399         parameter.
1400         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1401
1402 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1403
1404         PR breakpoints/24541
1405         * gdbarch.c: Regenerate.
1406         * gdbarch.h: Regenerate.
1407         * gdbarch.sh: Add 'stap_adjust_register'.
1408         * i386-tdep.c: Include '<unordered_set>'.
1409         (i386_stap_adjust_register): New function.
1410         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1411         * stap-probe.c (stap_parse_register_operand): Call
1412         'gdbarch_stap_adjust_register'.
1413
1414 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1415
1416         PR python/24742
1417         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1418         * python/python.c (do_start_initialization): Use 'xmalloc'
1419         instead of 'PyMem_Malloc'.
1420
1421 2019-06-28  Tom Tromey  <tromey@adacore.com>
1422
1423         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1424         for Ada.
1425
1426 2019-06-27  Tom Tromey  <tromey@adacore.com>
1427
1428         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1429         objfile_key.
1430         (arm_find_mapping_symbol, arm_record_special_symbol)
1431         (_initialize_arm_tdep): Update.
1432         (arm_objfile_data_free): Remove.
1433
1434 2019-06-27  Tom Tromey  <tromey@adacore.com>
1435
1436         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1437         to cp_print_static_field.
1438
1439 2019-06-26  Tom Tromey  <tromey@adacore.com>
1440
1441         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1442         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1443         declare.
1444
1445 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1446
1447         * features/aarch64-core.c (create_feature_aarch64_core):
1448         Regenerate.
1449         * features/aarch64-core.xml: Add cpsr flags.
1450
1451 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1452
1453         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1454         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1455
1456 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1457
1458         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1459         field.
1460         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1461         use.
1462         (arm_record_special_symbol): Don't insert new symbol in sorted
1463         position, push it at the end.
1464
1465 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1466
1467         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1468         (arm_mapping_symbol_s): Remove.
1469         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1470         (arm_mapping_symbol_vec): New typedef.
1471         (struct arm_per_objfile): Add constructor.
1472         <section_maps>: Change type to
1473         std::unique_ptr<arm_mapping_symbol_vec[]>.
1474         (arm_compare_mapping_symbols): Remove.
1475         (arm_find_mapping_symbol): Adjust to section_maps type change.
1476         (arm_objfile_data_free): Call delete on arm_per_objfile.
1477         (arm_record_special_symbol): Adjust to section_maps type change.
1478         Allocate arm_per_objfile with new.
1479
1480 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1481
1482         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1483         with the command prefix.
1484
1485 2019-06-25  Tom Tromey  <tom@tromey.com>
1486
1487         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1488         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1489
1490 2019-06-25  Tom Tromey  <tom@tromey.com>
1491
1492         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1493         type.
1494         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1495         protected.
1496
1497 2019-06-25  Tom Tromey  <tom@tromey.com>
1498
1499         * tui/tui-winsource.c
1500         (tui_source_window_base::set_is_exec_point_at): Add check against
1501         LOA_ADDRESS.
1502
1503 2019-06-25  Tom Tromey  <tom@tromey.com>
1504
1505         * tui/tui-source.c (tui_set_source_content): Don't check before
1506         xfree.
1507         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1508
1509 2019-06-25  Tom Tromey  <tom@tromey.com>
1510
1511         * tui/tui-winsource.h (tui_update_source_window_as_is)
1512         (tui_alloc_source_buffer, tui_line_is_displayed)
1513         (tui_addr_is_displayed): Change type of win_info.
1514         * tui/tui-winsource.c (tui_update_source_window_as_is)
1515         (tui_clear_source_content, tui_show_source_line)
1516         (tui_show_source_content, tui_source_window_base::refill)
1517         (tui_source_window_base::set_is_exec_point_at)
1518         (tui_source_window_base::set_is_exec_point_at)
1519         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1520         (tui_alloc_source_buffer, tui_line_is_displayed)
1521         (tui_addr_is_displayed): Change type of win_info.  Update.
1522         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1523         (tui_source_window_base::do_make_visible_with_new_height):
1524         Update.
1525         * tui/tui-source.c (tui_set_source_content)
1526         (tui_set_source_content_nil)
1527         (tui_source_window::do_scroll_vertical): Update.
1528         * tui/tui-layout.c (show_layout): Update.
1529         * tui/tui-disasm.c (tui_set_disassem_content)
1530         (tui_disasm_window::do_scroll_vertical): Update.
1531         * tui/tui-data.h (tui_win_content): Remove.
1532         (struct tui_gen_win_info) <content, content_size>: Remove.
1533         (struct tui_source_element): Add initializers and destructor.
1534         (union tui_which_element, struct tui_win_element): Remove.
1535         (struct tui_source_window_base) <content>: New field.
1536         (struct tui_data_window): Remove destructor.
1537         (tui_alloc_content, tui_free_win_content)
1538         (tui_free_all_source_wins_content): Don't declare.
1539         * tui/tui-data.c (tui_initialize_static_data): Update.
1540         (init_content_element, tui_alloc_content): Remove.
1541         (~tui_gen_win_info): Update.
1542         (~tui_data_window, tui_free_all_source_wins_content)
1543         (tui_free_win_content, free_content, free_content_elements):
1544         Remove.
1545
1546 2019-06-25  Tom Tromey  <tom@tromey.com>
1547
1548         * tui/tui-winsource.h (tui_clear_source_content)
1549         (tui_erase_source_content, tui_show_source_content): Change type
1550         of win_info.
1551         * tui/tui-winsource.c (tui_clear_source_content)
1552         (tui_erase_source_content, tui_show_source_content): Change type
1553         of win_info.
1554         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1555         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1556         win_info.
1557         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1558         win_info.
1559         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1560
1561 2019-06-25  Tom Tromey  <tom@tromey.com>
1562
1563         * tui/tui-winsource.c (tui_clear_source_content)
1564         (tui_source_window_base::set_is_exec_point_at): Update.
1565         * tui/tui-source.c (tui_set_source_content_nil): Update.
1566         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1567         a bool.
1568         * tui/tui-data.c (init_content_element): Update.
1569
1570 2019-06-25  Tom Tromey  <tom@tromey.com>
1571
1572         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1573         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1574         * tui/tui-layout.c (init_and_make_win): Update.
1575         * tui/tui.h (enum tui_win_type): Update.
1576         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1577         tui_win_is_auxillary.
1578         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1579         tui_win_is_auxillary.
1580
1581 2019-06-25  Tom Tromey  <tom@tromey.com>
1582
1583         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1584         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1585         (tui_delete_data_content_windows, tui_display_all_data)
1586         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1587         Update.
1588         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1589         * tui/tui-regs.c (tui_last_regs_line_no)
1590         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1591         (tui_show_registers): Update.
1592         (tui_show_register_group): Return void.  Update.
1593         (tui_display_registers_from, tui_display_reg_element_at_line)
1594         (tui_display_registers_from_line, tui_check_register_values):
1595         Update.
1596         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1597         member.
1598         (struct tui_data_window) <regs_content>: Now a std::vector.
1599         <regs_content_count>: Remove.
1600         (tui_add_content_elements, tui_free_data_content): Don't declare.
1601         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1602         (init_content_element): Remove DATA_WIN case.  Add assert.
1603         (tui_add_content_elements): Remove.
1604         (tui_data_window): Update.
1605         (tui_free_data_content): Remove.
1606         (free_content_elements): Remove DATA_WIN case.
1607
1608 2019-06-25  Tom Tromey  <tom@tromey.com>
1609
1610         * tui/tui-data.c (tui_data_item_window): Update.
1611         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1612         * tui/tui-windata.c (tui_display_all_data)
1613         (tui_display_data_from_line): Update.
1614         (tui_check_data_values): Remove.
1615         * tui/tui-regs.c (tui_show_register_group)
1616         (tui_display_reg_element_at_line): Update.
1617         * tui/tui-hooks.c (tui_register_changed)
1618         (tui_refresh_frame_and_register_information): Call
1619         tui_check_register_values.
1620         * tui/tui-data.h (struct tui_data_window) <data_content,
1621         data_content_count, data_type>: Remove.
1622         (enum tui_data_type): Remove.
1623
1624         * tui/tui-data.c (tui_data_window::clear_detail)
1625         (~tui_data_window): Update.
1626
1627 2019-06-25  Tom Tromey  <tom@tromey.com>
1628
1629         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1630         declare.
1631         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1632         Rename from tui_first_data_item_displayed.  Update.
1633         (tui_data_window::refresh_all)
1634         (tui_data_window::do_scroll_vertical): Update.
1635         * tui/tui-data.h (struct tui_data_window)
1636         <first_data_item_displayed>: Declare new method.
1637
1638 2019-06-25  Tom Tromey  <tom@tromey.com>
1639
1640         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1641         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1642         contents...
1643         (tui_initialize_static_data): ...here.
1644
1645 2019-06-25  Tom Tromey  <tom@tromey.com>
1646
1647         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1648         (tui_display_registers_from, tui_check_register_values): Update.
1649         (tui_display_register): Remove win_info parameter; update.
1650         (tui_get_register): Change type of parameters.
1651         * tui/tui-data.h (struct tui_data_element): Remove.
1652         (union tui_which_element) <data>: Remove.
1653         <data_window>: Change type.
1654         (struct tui_data_item_window): New.
1655         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1656         case.  Add assert.
1657         (~tui_data_item_window): New destructor.
1658         (free_content_elements): Remove DATA_ITEM_WIN case.
1659
1660 2019-06-25  Tom Tromey  <tom@tromey.com>
1661
1662         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1663         Remove.
1664
1665 2019-06-25  Tom Tromey  <tom@tromey.com>
1666
1667         * tui/tui-data.h (struct tui_command_element): Remove.
1668         (union tui_which_element) <command>: Remove.
1669         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1670         assert.
1671         (free_content_elements): Remove CMD_WIN case.
1672
1673 2019-06-25  Tom Tromey  <tom@tromey.com>
1674
1675         * tui/tui-layout.c (tui_set_layout): Update.
1676         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1677         * tui/tui-data.c (layout_def): Update.
1678
1679 2019-06-25  Tom Tromey  <tom@tromey.com>
1680
1681         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1682         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1683         (tui_source_window_base::set_new_height): Update.
1684         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1685         Update.
1686         (tui_set_locator_fullname, tui_set_locator_info)
1687         (tui_show_frame_info): Update.
1688         * tui/tui-source.c (tui_set_source_content)
1689         (tui_source_is_displayed): Update.
1690         * tui/tui-layout.c (show_source_disasm_command, show_data)
1691         (show_source_or_disasm_and_command): Update.
1692         * tui/tui-disasm.c (tui_set_disassem_content)
1693         (tui_get_begin_asm_address): Update.
1694         * tui/tui-data.h (struct tui_locator_element): Remove.
1695         (union tui_which_element) <locator>: Remove.
1696         (struct tui_locator_window): New.
1697         (tui_locator_win_info_ptr): Change return type.
1698         * tui/tui-data.c (_locator): Change type.
1699         (tui_locator_win_info_ptr): Change return type.
1700         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1701         (tui_alloc_content): Add assert.
1702
1703 2019-06-25  Tom Tromey  <tom@tromey.com>
1704
1705         * tui/tui-winsource.c
1706         (tui_exec_info_window::maybe_allocate_content): New method.
1707         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1708         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1709         (make_source_or_disasm_window): Add cast.
1710         * tui/tui-data.h (union tui_which_element) <simple_string>:
1711         Remove.
1712         (struct tui_source_info): New.
1713         (struct tui_source_window_base) <execution_info>: Change type.
1714         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1715         case, and add assert.
1716         (tui_alloc_content): Add assert.
1717
1718 2019-06-25  Tom Tromey  <tom@tromey.com>
1719
1720         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1721         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1722         * tui/tui-data.c (tui_alloc_win_info): Remove.
1723
1724 2019-06-25  Tom Tromey  <tom@tromey.com>
1725
1726         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1727         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1728         can_highlight.
1729
1730 2019-06-25  Tom Tromey  <tom@tromey.com>
1731
1732         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1733         make_visible_with_new_height method.
1734         (tui_win_info::make_visible_with_new_height): New method.
1735         (tui_source_window_base::do_make_visible_with_new_height)
1736         (tui_data_window::do_make_visible_with_new_height)
1737         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1738         (make_visible_with_new_height): Remove.
1739         (tui_resize_all, tui_adjust_win_heights): Use
1740         make_visible_with_new_height method.
1741         * tui/tui-data.h (struct tui_win_info)
1742         <do_make_visible_with_new_height, make_visible_with_new_height>:
1743         New methods.
1744         (struct tui_source_window_base, struct tui_data_window)
1745         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1746         methods.
1747
1748 2019-06-25  Tom Tromey  <tom@tromey.com>
1749
1750         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1751         method.
1752         (update_tab_width): Call update_tab_width method.
1753         * tui/tui-data.h (struct tui_win_info)
1754         (struct tui_source_window_base) <update_tab_width>: New methods.
1755
1756 2019-06-25  Tom Tromey  <tom@tromey.com>
1757
1758         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1759         parameter.
1760         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1761         parameter.
1762         (tui_gen_win_info::make_visible): Update.
1763         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1764         parameter.
1765         * tui/tui-data.h (enum tui_box): New enum.
1766         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1767
1768 2019-06-25  Tom Tromey  <tom@tromey.com>
1769
1770         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1771         init_and_make_win for EXEC_INFO_WIN.
1772         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1773         longer inline.
1774         (struct tui_win_info) <~tui_win_info>: Inline.
1775         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1776         Don't declare.
1777         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1778         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1779         Remove.
1780         (tui_initialize_static_data): Update.
1781         (~tui_gen_win_info): Handle more cleanup here.
1782         (~tui_source_window_base): Delete "execution_info".
1783         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1784
1785 2019-06-25  Tom Tromey  <tom@tromey.com>
1786
1787         * tui/tui-layout.c (make_command_window): Don't set
1788         can_highlight.
1789         (show_source_disasm_command): Call the reset method.
1790         (show_data): Don't set can_highlight.  Call the reset method.
1791         (tui_gen_win_info::reset): Rename from init_gen_win_info
1792         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1793         (show_source_or_disasm_and_command): Call the reset method.
1794         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1795         (struct tui_cmd_window): Set can_highlight.
1796
1797 2019-06-25  Tom Tromey  <tom@tromey.com>
1798
1799         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1800         from make_visible.
1801         (tui_make_visible, tui_make_invisible): Rewrite.
1802         (tui_win_info::make_visible): Remove.
1803         (tui_source_window_base::make_visible): Update.
1804         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1805         method.  Moved from...
1806         (struct tui_win_info) <make_visible>: ...here.
1807
1808 2019-06-25  Tom Tromey  <tom@tromey.com>
1809
1810         * tui/tui-winsource.c
1811         (tui_source_window_base::do_scroll_horizontal): Remove direction
1812         parameter.
1813         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1814         direction parameter.
1815         * tui/tui-win.c (tui_win_info::forward_scroll)
1816         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1817         (tui_win_info::right_scroll): Update.
1818         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1819         direction parameter.
1820         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1821         direction parameter.
1822         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1823         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1824         Remove direction parameter.
1825         (struct tui_source_window_base, struct tui_source_window)
1826         (struct tui_disasm_window, struct tui_data_window)
1827         (struct tui_cmd_window): Update.
1828
1829 2019-06-25  Tom Tromey  <tom@tromey.com>
1830
1831         * tui/tui-winsource.h (tui_set_exec_info_content)
1832         (tui_show_exec_info_content, tui_erase_exec_info_content)
1833         (tui_clear_exec_info_content, tui_update_exec_info): Change
1834         argument to tui_source_window_base.
1835         * tui/tui-winsource.c (tui_set_exec_info_content)
1836         (tui_show_exec_info_content, tui_erase_exec_info_content)
1837         (tui_clear_exec_info_content, tui_update_exec_info): Change
1838         argument to tui_source_window_base.
1839
1840 2019-06-25  Tom Tromey  <tom@tromey.com>
1841
1842         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1843         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1844
1845 2019-06-25  Tom Tromey  <tom@tromey.com>
1846
1847         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1848         check.
1849
1850 2019-06-25  Tom Tromey  <tom@tromey.com>
1851
1852         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1853         type to void.
1854         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1855         type to void.
1856         * tui/tui-source.c (tui_set_source_content): Update.
1857         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1858
1859 2019-06-25  Tom Tromey  <tom@tromey.com>
1860
1861         * tui/tui-win.c (window_name_completer, tui_set_focus)
1862         (tui_all_windows_info): Use name method.
1863         * tui/tui-data.h (struct tui_gen_win_info)
1864         (struct tui_source_window, struct tui_disasm_window)
1865         (struct tui_data_window, struct tui_cmd_window) <name>: New
1866         method.
1867         (tui_win_name): Don't declare.
1868         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1869         (tui_win_name): Remove.
1870
1871 2019-06-25  Tom Tromey  <tom@tromey.com>
1872
1873         * tui/tui-winsource.h (tui_update_source_window)
1874         (tui_update_source_window_as_is): Change parameter type.
1875         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1876         to be a tui_source_window_base.
1877         (tui_update_source_window_as_is): Likewise.
1878         * tui/tui-win.c (make_visible_with_new_height): Update.
1879
1880 2019-06-25  Tom Tromey  <tom@tromey.com>
1881
1882         * tui/tui-winsource.c (tui_erase_source_content)
1883         (tui_show_source_content, tui_show_exec_info_content)
1884         (tui_erase_exec_info_content): Use refresh_window method.
1885         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1886         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1887         from tui_refresh_win.
1888         (tui_data_window::refresh_window): New method.
1889         (tui_win_info::refresh, tui_source_window_base::refresh)
1890         (tui_refresh_all): Use refresh_window method.
1891         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1892         method.
1893         * tui/tui-regs.c (tui_display_register): Call refresh_window
1894         method.
1895         * tui/tui-layout.c (show_source_disasm_command)
1896         (show_source_or_disasm_and_command): Call refresh_window method.
1897         * tui/tui-data.h (struct tui_gen_win_info)
1898         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1899         New method.
1900
1901 2019-06-25  Tom Tromey  <tom@tromey.com>
1902
1903         * tui/tui.c (tui_rl_other_window, tui_enable)
1904         (tui_is_window_visible, tui_get_command_dimension): Update.
1905         * tui/tui-winsource.c (tui_update_source_window_as_is)
1906         (tui_clear_source_content, tui_erase_source_content)
1907         (tui_show_source_line, tui_source_window_base::refill)
1908         (tui_source_window_base::do_scroll_horizontal)
1909         (tui_source_window_base::set_is_exec_point_at)
1910         (tui_update_breakpoint_info, tui_set_exec_info_content)
1911         (tui_alloc_source_buffer, tui_line_is_displayed)
1912         (tui_addr_is_displayed): Update.
1913         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1914         (tui_check_and_display_highlight_if_needed)
1915         (tui_win_info::make_visible, tui_win_info::refresh)
1916         (tui_refresh_all): Update.
1917         * tui/tui-windata.c (tui_first_data_item_displayed)
1918         (tui_delete_data_content_windows, tui_erase_data_content)
1919         (tui_display_all_data, tui_data_window::refresh_all)
1920         (tui_check_data_values): Update.
1921         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1922         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1923         (tui_win_info::backward_scroll, tui_refresh_all_win)
1924         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1925         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1926         (tui_source_window_base::set_new_height)
1927         (tui_data_window::set_new_height)
1928         (make_invisible_and_set_new_height)
1929         (make_visible_with_new_height, new_height_ok)
1930         (parse_scrolling_args): Update.
1931         * tui/tui-stack.c (tui_show_frame_info): Update.
1932         * tui/tui-source.c (tui_set_source_content)
1933         (tui_set_source_content_nil, tui_source_is_displayed)
1934         (tui_source_window::do_scroll_vertical): Update.
1935         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1936         (tui_display_registers_from, tui_display_reg_element_at_line)
1937         (tui_check_register_values, tui_reg_command): Update.
1938         * tui/tui-layout.c (tui_default_win_height)
1939         (show_source_disasm_command, show_data, init_and_make_win)
1940         (show_source_or_disasm_and_command): Update.
1941         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1942         (tui_redisplay_readline, tui_mld_flush)
1943         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1944         (tui_getc): Update.
1945         * tui/tui-disasm.c (tui_set_disassem_content)
1946         (tui_disasm_window::do_scroll_vertical): Update.
1947         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1948         Now virtual.
1949         (struct tui_win_info): Derive from tui_gen_win_info.
1950         <~tui_win_info>: Mark as override.
1951         <generic>: Remove member.
1952         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1953         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1954         (~tui_data_window, ~tui_win_info)
1955         (tui_free_all_source_wins_content): Update.
1956         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1957
1958 2019-06-25  Tom Tromey  <tom@tromey.com>
1959
1960         * tui/tui-layout.c (init_and_make_win): Use new.
1961         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1962         destructor, initializers.
1963         (tui_alloc_generic_win_info): Don't declare.
1964         * tui/tui-data.c (_locator): Add argument to constructor.
1965         (source_win, disasm_win): New globals.
1966         (exec_info): Remove.
1967         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1968         Update.
1969         (tui_alloc_generic_win_info): Remove.
1970         (init_content_element): Use new.
1971         (tui_win_info::tui_win_info): Update.
1972         (free_content_elements) <case DATA_WIN>: Use delete.
1973
1974 2019-06-25  Tom Tromey  <tom@tromey.com>
1975
1976         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1977         * tui/tui-windata.c (tui_first_data_item_displayed)
1978         (tui_delete_data_content_windows): Update.
1979         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1980         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1981         (tui_display_registers_from, tui_check_register_values): Update.
1982         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1983         pointer.
1984         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1985         window.
1986         (tui_free_data_content): Update.
1987         (free_content_elements) <case DATA_WIN>: Free the window.
1988
1989 2019-06-25  Tom Tromey  <tom@tromey.com>
1990
1991         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1992         Update.
1993         * tui/tui-layout.c (make_command_window)
1994         (show_source_disasm_command, show_data, init_and_make_win)
1995         (show_source_or_disasm_and_command): Update.
1996         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1997         method.
1998         <can_highight, is_highlighted>: Now bool.
1999         (tui_set_win_highlight): Don't declare.
2000         * tui/tui-data.c (tui_set_win_highlight): Remove.
2001
2002 2019-06-25  Tom Tromey  <tom@tromey.com>
2003
2004         * tui/tui-wingeneral.c (make_visible): Remove check of window
2005         type.
2006
2007 2019-06-25  Tom Tromey  <tom@tromey.com>
2008
2009         * tui/tui-win.c (tui_win_info::max_height)
2010         (tui_cmd_window::max_height): New methods.
2011         (new_height_ok): Call max_height.
2012         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2013         <max_height>: New method.
2014
2015 2019-06-25  Tom Tromey  <tom@tromey.com>
2016
2017         * tui/tui-win.c (tui_source_window_base::set_new_height)
2018         (tui_data_window::set_new_height): New methods.
2019         (make_invisible_and_set_new_height): Call set_new_height method.
2020         * tui/tui-data.h (struct tui_win_info)
2021         (struct tui_source_window_base, struct tui_data_window)
2022         <set_new_height>: New method.
2023
2024 2019-06-25  Tom Tromey  <tom@tromey.com>
2025
2026         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2027         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2028         tui_refresh_data_win.
2029         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2030         method.
2031         (tui_refresh_all_win): Call the refresh_all method.
2032         (tui_set_focus): Likewise.
2033         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2034         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2035         Likewise.
2036
2037 2019-06-25  Tom Tromey  <tom@tromey.com>
2038
2039         * tui/tui-winsource.h (tui_refill_source_window)
2040         (tui_set_is_exec_point_at): Don't declare.
2041         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2042         (tui_source_window_base::refill): Rename from
2043         tui_refill_source_window.
2044         (tui_source_window_base::do_scroll_horizontal): Update.
2045         (tui_source_window_base::set_is_exec_point_at): Rename from
2046         tui_set_is_exec_point_at.
2047         (tui_update_all_breakpoint_info): Update.
2048         * tui/tui-stack.c (tui_show_frame_info): Update.
2049         * tui/tui-layout.c (show_data): Add cast.
2050         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2051         * tui/tui-data.h (struct tui_source_window_base) <refill,
2052         set_is_exec_point_at>: New methods.
2053         (tui_source_windows, tui_add_to_source_windows): Update types.
2054         (tui_add_to_source_windows): Remove redundant declaration.
2055         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2056         (tui_source_windows): Change return type.
2057         (tui_clear_source_windows_detail): Update.
2058         (tui_add_to_source_windows): Change type of parameter.
2059         (tui_free_all_source_wins_content): Update.
2060
2061 2019-06-25  Tom Tromey  <tom@tromey.com>
2062
2063         * tui/tui-wingeneral.c (tui_win_info::refresh)
2064         (tui_source_window_base::refresh): New methods.
2065         (tui_refresh_all): Call the refresh method.
2066         * tui/tui-data.h (struct tui_win_info)
2067         (struct tui_source_window_base) <refresh>: New method.
2068
2069 2019-06-25  Tom Tromey  <tom@tromey.com>
2070
2071         * tui/tui.h (tui_is_window_visible): Return bool.
2072         * tui/tui.c (tui_is_window_visible): Return bool.
2073         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2074         (tui_make_visible, tui_make_invisible)
2075         (tui_win_info::make_visible)
2076         (tui_source_window_base::make_visible, make_all_visible)
2077         (tui_make_all_visible, tui_make_all_invisible): Update.
2078         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2079         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2080         bool.
2081         (struct tui_win_info, struct tui_source_window_base)
2082         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2083         * tui/tui-data.c (tui_init_generic_part): Update.
2084
2085 2019-06-25  Tom Tromey  <tom@tromey.com>
2086
2087         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2088         (tui_source_window_base::make_visible): New methods.
2089         (make_all_visible): Make method call.
2090         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2091         (struct tui_source_window_base, struct tui_cmd_window): Override
2092         make_visible.
2093         (tui_win_is_source_type): Don't declare.
2094         * tui/tui-data.c (tui_win_is_source_type): Remove.
2095
2096 2019-06-25  Tom Tromey  <tom@tromey.com>
2097
2098         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2099         NULL check.
2100
2101 2019-06-25  Tom Tromey  <tom@tromey.com>
2102
2103         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2104         Inline constructor.  Add initializers for members.
2105         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2106         constructors; now inline in class.
2107
2108 2019-06-25  Tom Tromey  <tom@tromey.com>
2109
2110         * tui/tui-regs.c (tui_show_registers): Update.
2111         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2112         bool.
2113         * tui/tui-data.c (tui_data_window::clear_detail)
2114         (tui_data_window): Update.
2115
2116 2019-06-25  Tom Tromey  <tom@tromey.com>
2117
2118         * tui/tui-windata.c (tui_display_all_data)
2119         (tui_display_data_from_line, tui_display_data_from)
2120         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2121         Update.
2122         * tui/tui-regs.c (tui_last_regs_line_no)
2123         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2124         (tui_show_registers, tui_show_register_group)
2125         (tui_display_registers_from, tui_display_reg_element_at_line)
2126         (tui_display_registers_from_line, tui_check_register_values)
2127         (tui_reg_next, tui_reg_prev): Update.
2128         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2129         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2130         tui_data_window.
2131         (struct tui_win_info) <detail>: Remove.  Add new fields from
2132         tui_data_info.
2133         (TUI_DATA_WIN): Add cast.
2134         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2135         (~tui_data_window): Simplify.
2136
2137 2019-06-25  Tom Tromey  <tom@tromey.com>
2138
2139         * tui/tui-layout.c (show_source_disasm_command)
2140         (show_source_or_disasm_and_command): Update.
2141         * tui/tui-io.c (update_cmdwin_start_line)
2142         (tui_redisplay_readline): Update.
2143         * tui/tui-data.h (struct tui_command_info): Remove.
2144         (struct tui_win_info) <detail>: Remove command_info member.
2145         (struct tui_data_window) <start_line>: New member, from
2146         tui_command_info.
2147         (TUI_CMD_WIN): Add casts.
2148
2149 2019-06-25  Tom Tromey  <tom@tromey.com>
2150
2151         * tui/tui-winsource.c (tui_update_source_window)
2152         (tui_refill_source_window)
2153         (tui_source_window_base::do_scroll_horizontal)
2154         (tui_update_breakpoint_info, tui_set_exec_info_content)
2155         (tui_show_exec_info_content, tui_erase_exec_info_content)
2156         (tui_clear_exec_info_content): Update.
2157         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2158         Update.
2159         * tui/tui-win.c (make_invisible_and_set_new_height)
2160         (make_visible_with_new_height): Update.
2161         * tui/tui-source.c (tui_set_source_content)
2162         (tui_show_symtab_source): Update.
2163         * tui/tui-layout.c (extract_display_start_addr)
2164         (show_source_disasm_command, show_data)
2165         (make_source_or_disasm_window)
2166         (show_source_or_disasm_and_command): Update.
2167         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2168         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2169         "gdbarch".
2170         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2171         to tui_source_window_base.
2172         (struct tui_win_info) <detail>: Remove source_info member.
2173         (struct tui_source_window_base) <has_locator>: Inline.
2174         Move contents from tui_source_info; rename has_locator member to
2175         m_has_locator.
2176         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2177         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2178         header file.
2179         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2180         Simplify.
2181         (tui_free_all_source_wins_content): Cast to
2182         tui_source_window_base.
2183
2184 2019-06-25  Tom Tromey  <tom@tromey.com>
2185
2186         * tui/tui-win.c (make_invisible_and_set_new_height)
2187         (make_visible_with_new_height): Call has_locator method.
2188         * tui/tui-layout.c (show_source_disasm_command, show_data)
2189         (show_source_or_disasm_and_command): Update for bool change.
2190         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2191         (tui_win_info) <has_locator>: New method.
2192         (struct tui_source_window_base) <has_locator>: New method.
2193         (tui_win_has_locator): Don't declare.
2194         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2195         from tui_win_has_locator.
2196         (tui_source_window_base): Use false, not FALSE.
2197
2198 2019-06-25  Tom Tromey  <tom@tromey.com>
2199
2200         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2201         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2202         clear_detail method directly.
2203         (tui_clear_win_detail): Remove.
2204
2205 2019-06-25  Tom Tromey  <tom@tromey.com>
2206
2207         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2208         "this", not TUI_DISASM_WIN.
2209
2210 2019-06-25  Tom Tromey  <tom@tromey.com>
2211
2212         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2213         declare.
2214         * tui/tui-winsource.c
2215         (tui_source_window_base::do_scroll_horizontal): Rename from
2216         tui_horizontal_source_scroll.
2217         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2218         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2219         from tui_vertical_data_scroll.
2220         * tui/tui-win.h (tui_scroll): Don't declare.
2221         * tui/tui-win.c (tui_win_info::forward_scroll)
2222         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2223         (tui_win_info::right_scroll): Rename and update.
2224         (tui_scroll_forward_command, tui_scroll_backward_command)
2225         (tui_scroll_left_command, tui_scroll_right_command): Update.
2226         (tui_scroll): Remove.
2227         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2228         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2229         from tui_vertical_source_scroll.
2230         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2231         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2232         from tui_vertical_disassem_scroll.
2233         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2234         do_scroll_horizontal>: New methods.
2235         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2236         Likewise.
2237         (struct tui_source_window_base): Add do_scroll_horizontal.
2238         (struct tui_source_window, struct tui_disasm_window): Add
2239         do_scroll_vertical.
2240         (struct tui_data_window, struct tui_cmd_window): Add
2241         do_scroll_horizontal and do_scroll_vertical.
2242         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2243
2244 2019-06-25  Tom Tromey  <tom@tromey.com>
2245
2246         * tui/tui-data.h (struct tui_source_window_base): New struct.
2247         (struct tui_source_window): Derive from tui_source_window_base.
2248         (struct tui_disasm_window): New struct.
2249         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2250         from tui_source_window::clear_detail.
2251         (tui_source_window_base): Rename from tui_source_window.
2252         (~tui_source_window_base): Rename from ~tui_source_window.
2253         (tui_alloc_win_info): Create a tui_disasm_window.
2254
2255 2019-06-25  Tom Tromey  <tom@tromey.com>
2256
2257         * tui/tui-data.h (struct tui_source_window)
2258         (struct tui_data_window): Declare destructors.
2259         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2260         destructors.
2261         (tui_win_info): Simplify.
2262
2263 2019-06-25  Tom Tromey  <tom@tromey.com>
2264
2265         * tui/tui-winsource.c (tui_display_main)
2266         (tui_update_source_windows_with_addr)
2267         (tui_update_all_breakpoint_info): Update.
2268         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2269         (new_height_ok, parse_scrolling_args): Update.
2270         * tui/tui-stack.c (tui_show_frame_info): Update.
2271         * tui/tui-data.h (struct tui_list): Remove.
2272         (tui_source_windows): Return a reference to a std::vector.
2273         * tui/tui-data.c (source_windows): Now a std::vector.
2274         (tui_source_windows): Change return type.
2275         (tui_clear_source_windows): Rewrite.
2276         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2277         (tui_free_all_source_wins_content): Rewrite.
2278
2279 2019-06-25  Tom Tromey  <tom@tromey.com>
2280
2281         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2282         (struct tui_data_window, struct tui_cmd_window): Declare
2283         clear_detail method.
2284         * tui/tui-data.c (tui_source_window::clear_detail)
2285         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2286         methods.
2287         (tui_clear_win_detail): Simplify.
2288
2289 2019-06-25  Tom Tromey  <tom@tromey.com>
2290
2291         * tui/tui-layout.c (make_source_window, make_disasm_window)
2292         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2293         Return the new window.
2294         (show_source_disasm_command, show_data)
2295         (show_source_or_disasm_and_command): Update.
2296
2297 2019-06-25  Tom Tromey  <tom@tromey.com>
2298
2299         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2300         parameter.  Return the new window.
2301         (show_source_disasm_command): Update and remove NULL check.
2302         (show_source_or_disasm_and_command): Update.
2303
2304 2019-06-25  Tom Tromey  <tom@tromey.com>
2305
2306         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2307
2308 2019-06-25  Tom Tromey  <tom@tromey.com>
2309
2310         * tui/tui-data.h (struct tui_win_info): Make constructor
2311         protected.  Make destructor virtual.  Add initializers.
2312         (tui_source_window, tui_data_window, tui_cmd_window): New
2313         classes.
2314         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2315         constructor.  Add "type" parameter.
2316         (tui_source_window, tui_data_window, tui_cmd_window): New
2317         constructors.
2318         (tui_alloc_win_info): Instantiate the appropriate subclass.
2319
2320 2019-06-25  Tom Tromey  <tom@tromey.com>
2321
2322         * tui/tui-win.c (tui_resize_all): Use delete.
2323         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2324         destructor.
2325         (tui_free_window): Don't declare.
2326         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2327         Update.
2328
2329 2019-06-25  Tom Tromey  <tom@tromey.com>
2330
2331         * tui/tui-data.h (struct tui_win_info): Add constructor.
2332         * tui/tui-data.c (tui_alloc_win_info): Use new.
2333         (tui_free_window): Use delete.
2334
2335 2019-06-22  Tom Tromey  <tom@tromey.com>
2336
2337         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2338         declare.
2339         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2340
2341 2019-06-22  Tom Tromey  <tom@tromey.com>
2342
2343         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2344         declare.
2345         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2346
2347 2019-06-22  Tom de Vries  <tdevries@suse.de>
2348
2349         * dwarf2read.c (create_addrmap_from_aranges)
2350         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2351         instead of '%zu'.
2352
2353 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2354
2355         * dwarf2read.h (dwarf2_section_info_def): Remove.
2356         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2357         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2358         std::vector<dwarf2_section_info>.
2359         (struct dwo_file) <~dwo_file>: Remove.
2360         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2361         types field.
2362         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2363         (dwarf2_read_debug_names): Likewise.
2364         (create_debug_types_hash_table): Change parameter type to
2365         array_view, adjust code accordingly.
2366         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2367         (partial_die_info::fixup): Likewise.
2368         (determine_prefix): Likewise.
2369         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2370
2371 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2372
2373         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2374         gdb_bfd_ref_ptr.
2375         <~dwo_file>: Remove call to gdb_bfd_unref.
2376         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2377         gdb_bfd_ref_ptr::get.
2378
2379 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2380
2381         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2382         type to htab_up.
2383         * dwarf2read.c (struct dwo_file): Initialize fields.
2384         <~dwo_file>: New.
2385         (free_dwo_file): Remove, move content to ~dwo_file.
2386         (struct dwo_file_deleter): Remove.
2387         (dwo_file_up>: Remove custom deleter.
2388         (free_dwo_files): Remove.
2389         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2390         dwo_files.
2391         (process_skeletonless_type_units): Call unique_ptr::get.
2392         (allocate_dwo_file_hash_table): Add deleter to created hash
2393         table.  Change return type to htab_up.
2394         (lookup_dwo_file_slot): Don't memset dwo_file, call
2395         unique_ptr::get.
2396         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2397         (create_dwo_unit_in_dwp_v2): Likewise.
2398         (open_and_init_dwo_file): Likewise.
2399         (free_dwo_file_from_slot): Remove.
2400
2401 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2402
2403         * dwarf2read.h (struct dwarf2_section_info) <readin,
2404         is_virtual>: Change type to bool.
2405         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2406         true instead of 1.
2407
2408 2019-06-19  Tom Tromey  <tom@tromey.com>
2409
2410         * tui/tui-data.h (tui_init_content_element): Don't declare.
2411
2412 2019-06-19  Tom Tromey  <tom@tromey.com>
2413
2414         * tui/tui-data.h (tui_init_win_info): Don't declare.
2415
2416 2019-06-19  Tom de Vries  <tdevries@suse.de>
2417
2418         * dwarf2read.h (abstract_to_concrete): Change type to
2419         std::unordered_map<sect_offset, std::vector<sect_offset>,
2420         gdb::hash_enum<sect_offset>>.
2421
2422 2019-06-19  Tom Tromey  <tromey@adacore.com>
2423
2424         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2425         EVAL_AVOID_SIDE_EFFECTS specially.
2426
2427 2019-06-19  Tom Tromey  <tromey@adacore.com>
2428
2429         * source-cache.c (highlighter): New global.
2430         (source_cache::get_source_lines): Create a highlighter on demand.
2431
2432 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2433
2434         * defs.h (deprecated_interactive_hook): Delete declaration.
2435         * interps.c (clear_interpreter_hooks): Remove use of
2436         deprecated_interactive_hook.
2437         * top.c (deprecated_interactive_hook): Delete definition.
2438         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2439
2440 2019-06-18  Tom de Vries  <tdevries@suse.de>
2441
2442         PR gdb/24515
2443         * dwarf2read.h (abstract_to_concrete): Change type from
2444         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2445         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2446         * dwarf2read.c (read_variable): Update.
2447         (dwarf2_fetch_die_loc_sect_off): Update.
2448
2449 2019-06-17  Tom de Vries  <tdevries@suse.de>
2450
2451         PR gdb/24617
2452         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2453         accessing parent[parent_len - 1].
2454
2455 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2456
2457         PR gdb/24364
2458         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2459         call dtrace_process_dof with NULL dof.
2460
2461 2019-06-16  Tom de Vries  <tdevries@suse.de>
2462
2463         PR gdb/24445
2464         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2465
2466 2019-06-16  Tom Tromey  <tom@tromey.com>
2467
2468         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2469         (make_all_visible): Use address of member.
2470
2471 2019-06-16  Tom Tromey  <tom@tromey.com>
2472
2473         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2474         (tui_free_window, free_content, free_content_elements): Remove
2475         unnecessary cast.
2476         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2477         cast.
2478         * tui/tui-regs.c (tui_show_register_group)
2479         (tui_display_registers_from, tui_display_reg_element_at_line):
2480         Remove unnecessary cast.
2481
2482 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2483
2484         * linux-nat.c (normal_mask): Delete.
2485         (_initialize_linux_nat): Don't initialise normal_mask.
2486
2487 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2488
2489         PR gdb/24445
2490         * dwarf-index-write.h (write_psymtabs_to_index): Add
2491         dwz_basename parameter.
2492         * dwarf-index-write.c (write_gdbindex): Move file writing to
2493         write_gdbindex_1.  Change return type void.
2494         (assert_file_size): Move up, remove filename parameter.
2495         (write_gdbindex_1): New function.
2496         (write_debug_names): Change return type to void, call
2497         assert_file_size.
2498         (struct index_wip_file): New struct.
2499         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2500         file logic to index_wip_file.  Write index for dwz file if
2501         needed.
2502         (save_gdb_index_command): Pass basename of dwz file, if present.
2503         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2504         build-id of dwz file, if present.
2505         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2506         (dwarf2_get_dwz_file): Likewise.
2507         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2508         (dwarf2_get_dwz_file): Likewise.
2509
2510 2019-06-16  Tom Tromey  <tom@tromey.com>
2511
2512         * coffread.c (process_coff_symbol): Use xstrdup.
2513         * value.c (create_internalvar): Use xstrdup.
2514
2515 2019-06-16  Tom Tromey  <tom@tromey.com>
2516
2517         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2518         * breakpoint.c (stopin_command, stopat_command)
2519         (until_break_command, decode_location_default): Remove unnecessary
2520         cast.
2521         * utils.c (subset_compare): Remove unnecessary cast.
2522         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2523         cast.
2524         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2525         cast.
2526         * infcmd.c (path_command): Remove unnecessary cast.
2527         * coffread.c (decode_type): Remove unnecessary cast.
2528         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2529         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2530         * tui/tui-stack.c (tui_show_locator_content)
2531         (tui_show_frame_info): Remove unnecessary cast.
2532         * tui/tui-win.c (tui_scroll_forward_command)
2533         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2534         (parse_scrolling_args): Remove unnecessary cast.
2535         * tui/tui-data.c (init_win_info, tui_del_window)
2536         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2537         (free_content_elements): Remove unnecessary cast.
2538         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2539         unnecessary cast.
2540         * tui/tui-source.c (tui_set_source_content)
2541         (tui_vertical_source_scroll): Remove unnecessary cast.
2542         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2543         cast.
2544         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2545         * tui/tui-regs.c (tui_display_registers_from)
2546         (tui_display_register): Remove unnecessary cast.
2547         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2548         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2549         (make_visible): Remove unnecessary cast.
2550         * tui/tui-winsource.c (tui_erase_source_content)
2551         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2552         unnecessary cast.
2553         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2554         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2555         * stabsread.c (read_type, read_array_type, read_range_type):
2556         Remove unnecessary cast.
2557         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2558         (parse_symbol, parse_type, upgrade_type, parse_external)
2559         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2560         unnecessary cast.
2561         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2562
2563 2019-06-16  Tom Tromey  <tom@tromey.com>
2564
2565         * tui/tui-data.c (tui_alloc_generic_win_info)
2566         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2567         checks.
2568
2569 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2570             Andrew Burgess  <andrew.burgess@embecosm.com>
2571
2572         * f-typeprint.c (f_print_type): Don't return early for not
2573         associated or not allocated types.
2574         (f_type_print_varspec_suffix): Add print_rank parameter and print
2575         ranks of array types in case they dangling.
2576         (f_type_print_base): Add print_rank parameter.
2577
2578 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2579
2580         * NEWS: Mention new MI commands.
2581         * break-catch-throw.c (enum exception_event_kind): Move to
2582         breakpoint.h.
2583         (print_mention_exception_catchpoint): Output text as a single
2584         message.
2585         (catch_exception_command_1): Rename to...
2586         (catch_exception_event): ...this, make non-static, update header
2587         command, and change some parameter types.
2588         (catch_catch_command): Update for changes to
2589         catch_exception_command_1.
2590         (catch_throw_command): Likewise.
2591         (catch_rethrow_command): Likewise.
2592         * breakpoint.c (enum exception_event_kind): Delete.
2593         * breakpoint.h (enum exception_event_kind): Moved here from
2594         break-catch-throw.c.
2595         (catch_exception_event): Declare.
2596         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2597         (mi_cmd_catch_throw): New function.
2598         (mi_cmd_catch_rethrow): New function.
2599         (mi_cmd_catch_catch): New function.
2600         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2601         'catch-catch' entries.
2602         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2603         (mi_cmd_catch_rethrow): Declare.
2604         (mi_cmd_catch_catch): Declare.
2605
2606 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2607
2608         * annotate.c (annotate_source_line): Change return type to void,
2609         update implementation to match.
2610         * annotate.h (annotate_source_line): Change return type to void,
2611         update header comment.
2612         * stack.c (print_frame_info): Don't change what frame information
2613         is printed based on whether annotations are on or not.
2614
2615 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2616
2617         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2618         (annotate_source): Make static.
2619         (annotate_source_line): Moved from source.c and renamed from
2620         identify_source_line.  Update the return type.
2621         * annotate.h (annotate_source): Delete declaration.
2622         (annotate_source_line): Declaration moved from source.h, and
2623         renamed from identify_source_line.  Return type updated.
2624         * source.c (identify_source_line): Moved to annotate.c and renamed
2625         to annotate_source_line.
2626         (info_line_command): Remove check of annotation_level.
2627         * source.h (identify_source_line): Move declaration to annotate.h
2628         and rename to annotate_source_line.
2629         * stack.c: Add 'annotate.h' include.
2630         (print_frame_info): Remove check of annotation_level before
2631         calling annotate_source_line.
2632
2633 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2634
2635         * source-cache.c (source_cache::get_plain_source_lines): Use
2636         open_source_file_with_line_charpos instead of just
2637         open_source_file, remove call to find_source_lines.
2638         (source_cache::get_source_lines): Likewise.
2639         * source.c (find_source_lines): Make static.
2640         (get_filename_and_charpos): Renamed into...
2641         (open_source_file_with_line_charpos): ..this along with changes to
2642         return a scoped_fd, and some other minor clean ups.
2643         (identify_source_line): Use open_source_file_with_line_charpos.
2644         (search_command_helper): Use open_source_file_with_line_charpos
2645         instead of just open_source_file, remove call to
2646         find_source_lines.
2647         * source.h (open_source_file_with_line_charpos): Declare new
2648         function.
2649         (find_source_lines): Delete declaration.
2650
2651 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2652
2653         * source.c (get_filename_and_charpos): Remove fullname
2654         parameter.
2655         (identify_source_line): Update call to get_filename_and_charpos.
2656
2657 2019-06-14  Tom Tromey  <tromey@adacore.com>
2658
2659         PR gdb/24502:
2660         * ui-style.h (skip_ansi_escape): Update comment.
2661         * ui-file.h (class no_terminal_escape_file): New class.
2662         * ui-file.c (no_terminal_escape_file::write)
2663         (no_terminal_escape_file::puts): New methods.
2664         * cli/cli-logging.c (handle_redirections): Use
2665         no_terminal_escape_file.
2666
2667 2019-06-14  Tom Tromey  <tromey@adacore.com>
2668
2669         * NEWS: Move convenience variable news above Python news.
2670
2671 2019-06-14  Tom Tromey  <tom@tromey.com>
2672
2673         * gnulib: Move directory to top-level.
2674         * configure.ac: Don't configure gnulib.
2675         * configure: Rebuild.
2676         * common/common-defs.h: Use new path to gnulib.
2677         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2678         (GNULIB_H): Remove.
2679         (INCGNU): Look in new gnulib location.
2680         (HFILES_NO_SRCDIR): Remove gnulib files.
2681         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2682         (generated_files): Remove GNULIB_H.
2683         ($(LIBGNU), all-lib): Remove targets.
2684         (distclean): Don't mention GNULIB_BUILDDIR.
2685         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2686
2687 2019-06-14  Tom Tromey  <tromey@adacore.com>
2688
2689         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2690         Warn if symbol file does not provide any symbols.
2691
2692 2019-06-14  Tom Tromey  <tromey@adacore.com>
2693
2694         * source.c (find_and_open_source): Respect basenames_may_differ.
2695
2696 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2697
2698         * annotate.c (annotate_breakpoints_invalid): Make use of
2699         scoped_restore_terminal_state.
2700         (annotate_frames_invalid): Likewise.
2701
2702 2019-06-14  Tom Tromey  <tromey@adacore.com>
2703
2704         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2705         allow assignment to an internalvar.
2706
2707 2019-06-14  Tom Tromey  <tromey@adacore.com>
2708
2709         * ada-lex.l: Allow "_" in attribute names.
2710
2711 2019-06-14  Tom Tromey  <tromey@adacore.com>
2712
2713         PR gdb/24653:
2714         * regcache.c (registers_changed): Don't call alloca.
2715         * top.c (execute_command): Don't call alloca.
2716
2717 2019-06-13  Pedro Alves  <palves@redhat.com>
2718
2719         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2720         'expression'.  When parsing an expression, error out if there's
2721         junk after "unlimited".
2722         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2723         (do_set_command): Adjust calls to is_unlimited_literal.
2724
2725 2019-06-13  Pedro Alves  <palves@redhat.com>
2726
2727         * compile/compile.c (make_compile_options_def_group): Add braces
2728         around array_view initializer.
2729         * thread.c (make_thread_apply_all_options_def_group)
2730         (make_thread_apply_all_options_def_group): Likewise.
2731
2732 2019-06-13  Pedro Alves  <palves@redhat.com>
2733
2734         * NEWS (New commands): Mention "maint test-options
2735         require-delimiter", "maint test-options unknown-is-error", "maint
2736         test-options unknown-is-operand" and "maint show
2737         test-options-completion-result".
2738         (New command options, command completion): New section.
2739         (Completion improvements): New section.
2740         Mention that you can abbreviate "unlimited".
2741
2742 2019-06-13  Pedro Alves  <palves@redhat.com>
2743
2744         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2745         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2746         * unittests/cli-utils-selftests.c (test_parse_flags)
2747         (test_parse_flags_qcs): Delete.
2748         (test_cli_utils): Don't call deleted functions.
2749
2750 2019-06-13  Pedro Alves  <palves@redhat.com>
2751
2752         * thread.c: Include "cli/cli-option.h".
2753         (tp_array_compar_ascending): Global.
2754         (tp_array_compar): Delete function.
2755         (tp_array_compar_ascending, tp_array_compar_descending): New
2756         functions.
2757         (ascending_option_def, qcs_flag_option_def)
2758         (thr_qcs_flags_option_defs)
2759         (make_thread_apply_all_options_def_group)
2760         (make_thread_apply_options_def_group): New.
2761         (thread_apply_all_command): Use gdb::option::process_options.
2762         (thread_apply_command_completer)
2763         (thread_apply_all_command_completer): New.
2764         (thread_apply_command): Use gdb::option::process_options.
2765         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2766         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2767         to generate help text of "thread apply".  Adjust "taas"'s help.
2768         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2769         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2770
2771 2019-06-13  Pedro Alves  <palves@redhat.com>
2772
2773         * thread.c (thread_apply_command): Check for invalid TID with
2774         isdigit instead of !isalpha.
2775
2776 2019-06-13  Pedro Alves  <palves@redhat.com>
2777
2778         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2779         (validate_flags_qcs): New.
2780         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2781         (validate_flags_qcs): Declare.
2782         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2783         (make_frame_apply_options_def_group): New.
2784         (frame_apply_command_count): Process options with
2785         gdb::option::process_options.
2786         (frame_apply_completer): New.
2787         (frame_apply_level_completer, frame_apply_all_completer)
2788         (frame_apply_completer): New.
2789         (_initialize_stack): Update help of "frame apply", "frame apply
2790         level", "frame apply all" and "faas" to mention supported options
2791         and install command completers.
2792         * stack.h (frame_apply_all_completer): Declare.
2793         * thread.c: Include "stack.h".
2794         (tfaas_command): Add "--".
2795         (_initialize_thread): Update help "tfaas" to mention supported
2796         options and install command completer.
2797
2798 2019-06-13  Pedro Alves  <palves@redhat.com>
2799
2800         * completer.c (complete_nested_command_line): New.
2801         (gdb_completion_word_break_characters_throw): Add assertion.
2802         * completer.h (complete_nested_command_line): Declare.
2803
2804 2019-06-13  Pedro Alves  <palves@redhat.com>
2805
2806         * stack.c (parse_backtrace_qualifiers): New.
2807         (backtrace_command): Use it.
2808         (backtrace_command_completer): Complete on qualifiers.
2809
2810 2019-06-13  Pedro Alves  <palves@redhat.com>
2811
2812         * frame.c: Include "cli/cli-option.h.
2813         (user_set_backtrace_options): New.
2814         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2815         Delete.
2816         (get_prev_frame): Adjust.
2817         (boolean_option_def, uinteger_option_def)
2818         (set_backtrace_option_defs): New.
2819         (_initialize_frame): Adjust and use
2820         gdb::option::add_setshow_cmds_for_options to install "set
2821         backtrace past-main" and "set backtrace past-entry".
2822         * frame.h: Include "cli/cli-option.h".
2823         (struct frame_print_options): Forward declare.
2824         (print_frame_arguments_all, print_frame_arguments_scalars)
2825         (print_frame_arguments_none): Declare.
2826         (print_entry_values): Delete declaration.
2827         (struct frame_print_options, user_frame_print_options): New.
2828         (struct set_backtrace_options): New.
2829         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2830         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2831         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2832         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2833         (list_args_or_locals): Add frame_print_options parameter.
2834         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2835         * python/py-framefilter.c (enumerate_args): Pass down
2836         USER_FRAME_PRINT_OPTIONS.
2837         * stack.c: Include "cli/cli-option.h".
2838         (print_frame_arguments_all, print_frame_arguments_scalars)
2839         (print_frame_arguments_none): Declare.
2840         (print_raw_frame_arguments, print_entry_values): Delete.
2841         (user_frame_print_options): New.
2842         (boolean_option_def, enum_option_def, frame_print_option_defs):
2843         New.
2844         (struct backtrace_cmd_options): New.
2845         (bt_flag_option_def): New.
2846         (backtrace_command_option_defs): New.
2847         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2848         (print_frame_arg, read_frame_arg, print_frame_args)
2849         (print_frame_info, print_frame): Add frame_print_options parameter
2850         and use it.
2851         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2852         (backtrace_command_1): Add frame_print_options and
2853         backtrace_cmd_options parameters and use them.
2854         (make_backtrace_options_def_group): New.
2855         (backtrace_command): Process command options with
2856         gdb::option::process_options.
2857         (backtrace_command_completer): New.
2858         (_initialize_stack): Extend "backtrace"'s help to mention
2859         supported options.  Install completer for "backtrace".
2860         Install some settings commands with add_setshow_cmds_for_options.
2861
2862 2019-06-13  Pedro Alves  <palves@redhat.com>
2863
2864         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2865         and that "set/show print raw frame-arguments" are now deprecated.
2866
2867         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2868         command.
2869         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2870         * stack.c (_initialize_stack): Install "set/show print
2871         raw-frame-arguments", and deprecate "set/show print raw
2872         frame-arguments".
2873         * valprint.c (_initialize_valprint): Deprecate "set/show print
2874         raw".
2875
2876 2019-06-13  Pedro Alves  <palves@redhat.com>
2877
2878         * compile/compile.c (struct compile_options): New.
2879         (compile_flag_option_def, compile_command_option_defs)
2880         (make_compile_options_def_group): New.
2881         (compile_file_command): Handle options with
2882         gdb::option::process_options.
2883         (compile_file_command_completer): New function.
2884         (compile_code_command): Handle options with
2885         gdb::option::process_options.
2886         (compile_code_command_completer): New function.
2887         (_initialize_compiler): Install completers for "compile code" and
2888         "compile file".  Mention available options in "compile code" and
2889         "compile code"'s help.
2890         * completer.c (advance_to_completion_word): New, factored out from
2891         ...
2892         (advance_to_expression_complete_word_point): ... this.
2893         (advance_to_filename_complete_word_point): New.
2894         * completer.h (advance_to_filename_complete_word_point): New
2895         declaration.
2896
2897 2019-06-13  Pedro Alves  <palves@redhat.com>
2898
2899         * compile/compile.c: Include "cli/cli-option.h".
2900         (compile_print_value): Scope data pointer is now a
2901         value_print_options pointer; adjust.
2902         (compile_print_command): Process options.  Scope data pointer is
2903         now a value_print_options pointer; adjust.
2904         (_initialize_compile): Update "compile print"'s help to include
2905         supported options.  Install a completer for "compile print".
2906         * cp-valprint.c (show_vtblprint, show_objectprint)
2907         (show_static_field_print): Delete.
2908         (_initialize_cp_valprint): Don't install "set print
2909         static-members", "set print vtbl", "set print object" here.
2910         * printcmd.c: Include "cli/cli-option.h" and
2911         "common/gdb_optional.h".
2912         (print_command_parse_format): Rework to fill in a
2913         value_print_options instead of a format_data.
2914         (print_value): Change parameter type from format_data pointer to
2915         value_print_options reference.  Adjust.
2916         (print_command_1): Process options.  Adjust to pass down a
2917         value_print_options.
2918         (print_command_completer): New.
2919         (_initialize_printcmd): Install print_command_completer as
2920         handle_brkchars completer for the "print" command.  Update
2921         "print"'s help to include supported options.
2922         * valprint.c: Include "cli/cli-option.h".
2923         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2924         here from cp-valprint.c.
2925         (boolean_option_def, uinteger_option_def)
2926         (value_print_option_defs, make_value_print_options_def_group):
2927         New.  Use gdb::option::add_setshow_cmds_for_options to install
2928         "set print elements", "set print null-stop", "set print repeats",
2929         "set print pretty", "set print union", "set print array", "set
2930         print address", "set print symbol", "set print array-indexes".
2931         * valprint.h: Include <string> and "cli/cli-option.h".
2932         (make_value_print_options_def_group): Declare.
2933         (print_value): Change parameter type from format_data pointer to
2934         value_print_options reference.
2935         (print_command_completer): Declare.
2936
2937 2019-06-13  Pedro Alves  <palves@redhat.com>
2938
2939         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2940         (COMMON_SFILES): Add maint-test-settings.c.
2941         * cli/cli-decode.c (boolean_enums): New global, factored out from
2942         ...
2943         (add_setshow_boolean_cmd): ... here.
2944         * cli/cli-decode.h (boolean_enums): Declare.
2945         * cli/cli-option.c: New file.
2946         * cli/cli-option.h: New file.
2947         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2948         factored out from ...
2949         (parse_cli_boolean_value(const char *)): ... this.
2950         (is_unlimited_literal): Change parameter type to pointer to
2951         pointer.  Adjust and advance ARG pointer.
2952         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2953         (parse_cli_var_enum): New, factored out from ...
2954         (do_set_command): ... this.  Adjust.
2955         * cli/cli-setshow.h (parse_cli_boolean_value)
2956         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2957         (parse_cli_var_enum): Declare.
2958         * cli/cli-utils.c: Include "cli/cli-option.h".
2959         (get_ulongest): New.
2960         * cli/cli-utils.h (get_ulongest): Declare.
2961         (check_for_argument): New overloads.
2962         * maint-test-options.c: New file.
2963
2964 2019-06-13  Pedro Alves  <palves@redhat.com>
2965
2966         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2967         parse a range if "-" is at the end of the string.
2968
2969 2019-06-13  Pedro Alves  <palves@redhat.com>
2970
2971         * cli/cli-setshow.c (parse_auto_binary_operation)
2972         (parse_cli_boolean_value): Don't allow "o".
2973
2974 2019-06-13  Pedro Alves  <palves@redhat.com>
2975
2976         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2977         * NEWS: Mention maint test-settings KIND.
2978         * maint-test-settings.c: New file.
2979
2980 2019-06-13  Pedro Alves  <palves@redhat.com>
2981
2982         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2983         completer.
2984         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2985         "set" completers.
2986
2987 2019-06-13  Pedro Alves  <palves@redhat.com>
2988
2989         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2990         after item.
2991
2992 2019-06-13  Pedro Alves  <palves@redhat.com>
2993
2994         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2995
2996 2019-06-13  Pedro Alves <palves@redhat.com>
2997
2998         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2999         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3000         call.
3001         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3002         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3003         calls.
3004         (check_for_argument): Skip spaces after argument.
3005
3006 2019-06-13  Pedro Alves  <palves@redhat.com>
3007
3008         * thread.c (thread_apply_command): Adjust TID parsing.
3009         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3010         detected before end of string.
3011         (tid_is_in_list): Error out if LIST is invalid.
3012
3013 2019-06-13  Pedro Alves  <palves@redhat.com>
3014
3015         * completer.c (complete_line_internal_1): Rewind completion word
3016         point.
3017         (completion_tracker::advance_custom_word_point_by): Change
3018         parameter type to int.
3019         * completer.h (completion_tracker::advance_custom_word_point_by):
3020         Likewise.
3021
3022 2019-06-13  Pedro Alves  <palves@redhat.com>
3023
3024         * completer.c (advance_to_completion_word): Handle delimiters.
3025
3026 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3027
3028         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3029
3030 2019-06-11  Tom Tromey  <tom@tromey.com>
3031
3032         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3033         (xmalloc_failed): Move to alloc.c.
3034         * alloc.c: New file.
3035         * Makefile.in (COMMON_SFILES): Add alloc.c.
3036
3037 2019-06-11  Tom Tromey  <tom@tromey.com>
3038
3039         * nat/linux-waitpid.c: Don't include server.h.
3040         (linux_debug): Remove.
3041         (my_waitpid): Update.
3042
3043 2019-06-11  Tom Tromey  <tromey@adacore.com>
3044
3045         * infcall.c (_initialize_infcall): Remove trailing newline from
3046         help.
3047         * user-regs.c (_initialize_user_regs): Remove trailing newline
3048         from help.
3049         * typeprint.c (_initialize_typeprint): Remove trailing newline
3050         from help.
3051         * reverse.c (_initialize_reverse): Remove trailing newlines from
3052         help.
3053         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3054         from help.
3055         * language.c (add_set_language_command): Remove trailing newline
3056         from help.
3057         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3058         help.
3059         * disasm.c (_initialize_disasm): Remove trailing newline from
3060         help.
3061         * top.c (init_main): Remove trailing newline from help.
3062         * interps.c (_initialize_interpreter): Remove trailing newline
3063         from help.
3064         * btrace.c (_initialize_btrace): Remove trailing newlines from
3065         help.
3066         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3067         from help.
3068         * python/python.c (_initialize_python): Remove trailing newline
3069         from help.
3070         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3071         help.
3072         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3073         from help.  Reformat some text.
3074         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3075         from help.
3076         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3077         newline from help.
3078
3079 2019-06-11  Tom Tromey  <tromey@adacore.com>
3080
3081         * darwin-nat.c (darwin_decode_exception_message)
3082         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3083
3084 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3085
3086         * valops.c (value_slice): Check for not allocated or not
3087         associated values.
3088
3089 2019-06-10  Tom de Vries  <tdevries@suse.de>
3090
3091         PR gdb/24618
3092         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3093         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3094         invalid.
3095
3096 2019-06-10  Tom de Vries  <tdevries@suse.de>
3097
3098         PR gdb/24611
3099         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3100         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3101
3102 2019-06-10  Tom de Vries  <tdevries@suse.de>
3103
3104         PR symtab/24545
3105         * symtab.c (struct demangled_name_entry): Add language field.
3106         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3107         static minimal symbol".  Set and use language field.
3108
3109 2019-06-10  Tom Tromey  <tromey@adacore.com>
3110
3111         * ada-lang.c (_initialize_ada_language): Update help text.
3112
3113 2019-06-10  Tom Tromey  <tromey@adacore.com>
3114
3115         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3116         with a newline.
3117         * guile/guile.c (handle_boot_error): Don't end warning with a
3118         newline.
3119         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3120         warning with a newline.
3121         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3122         newline.
3123         (s12z_frame_cache): Likewise.
3124         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3125         a newline.
3126         * solib-svr4.c (disable_probes_interface): Don't end warning with
3127         a newline.
3128         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3129         newline.
3130         * python/python.c (do_finish_initialization): Don't end warning
3131         with a newline.
3132
3133 2019-06-10  Tom Tromey  <tom@tromey.com>
3134
3135         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3136         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3137         gdbpy_enter.
3138
3139 2019-06-10  Tom Tromey  <tromey@adacore.com>
3140
3141         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3142         data.
3143         (elf_new_init): Don't call stabsread_new_init.
3144         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3145         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3146         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3147
3148 2019-06-10  Tom de Vries  <tdevries@suse.de>
3149
3150         PR symtab/16264
3151         PR symtab/24517
3152         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3153
3154 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3155
3156         * source.c (find_and_open_source): Also rewrite relative file
3157         names.
3158
3159 2019-04-26  Amos Bird  <amosbird@gmail.com>
3160
3161         * annotate.c (annotate_thread_exited): Add "thread-exited"
3162         annotation.
3163
3164 2019-06-06  Tom Tromey  <tromey@adacore.com>
3165
3166         * maint.h (class scoped_command_stats): Use
3167         DISABLE_COPY_AND_ASSIGN.
3168         <print_time>: New method.
3169         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3170         print_time.
3171         (scoped_command_stats::print_time): New method.
3172
3173 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3174
3175         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3176         instructions of lengths 6 or 8 bytes.
3177
3178 2019-06-04  Pedro Alves  <palves@redhat.com>
3179
3180         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3181
3182         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3183         * breakpoint.c (condition_completer): Likewise.
3184         * cli/cli-dump.c (scan_expression): Likewise.
3185         * common/filestuff.c (mkdir_recursive): Likewise.
3186         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3187         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3188         (gdb_abspath): Likewise.
3189         * compile/compile-cplus-types.c
3190         (compile_cplus_instance::decl_name): Likewise.
3191         * completer.c (complete_explicit_location):
3192         (signal_completer, reg_or_group_completer_1): Likewise.
3193         * cp-support.c (cp_remove_params_if_any): Likewise.
3194         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3195         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3196         * infcmd.c (strip_bg_char): Likewise.
3197         * linespec.c (copy_token_string): Likewise.
3198         * mi/mi-main.c (output_cores): Likewise.
3199         * psymtab.c (psymtab_search_name):
3200         * symfile.c (test_set_ext_lang_command): Likewise.
3201         * target.c (target_fileio_read_stralloc): Likewise.
3202         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3203         * value.c (complete_internalvar): Likewise.
3204
3205 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3206
3207         Add objfile property to gdb.Type.
3208         * NEWS: Mention Python API addition.
3209         * python/py-type.c (typy_get_objfile): New method.
3210
3211 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3212
3213         * NEWS: Mention the new set|show style [title|highlight].
3214         Mention changes to "show style", "help" and "apropos".
3215
3216 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3217
3218         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3219         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3220         instead of print_help_for_command.
3221         (print_doc_of_command): New function.
3222         (help_list): Add 'apropos -v word' suggestion.
3223         (print_help_for_command): Style the command name using title style.
3224         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3225         (_initialize_cli_cmds): Describe -v in apropos_command help.
3226
3227 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3228
3229         * cli/cli-style.h (cli_style_option): Add name in constructor,
3230         add m_name class member, add constructor with intensity,
3231         add name class function.
3232         (cli_style_option::add_setshow_commands): Remove name argument.
3233         (highlight_style, title_style): New styles.
3234         * cli/cli-style.c (do_show): New function that shows a style
3235         characteristic styling the style name with itself.
3236         (set_style_name): New function.
3237         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3238         Update all callers according to the changes in cli/cli-style.h.
3239         * utils.h (fputs_highlighted): New function.
3240         * utils.c (fputs_highlighted): Likewise.
3241
3242 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3243
3244         * NEWS: Mention new pipe command and new convenience variables.
3245
3246 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3247
3248         * cli/cli-cmds.c (pipe_command): New function.
3249         (_initialize_cli_cmds): Call add_com for pipe_command.
3250         Define | as an alias for pipe.
3251         (exit_status_set_internal_vars): New function.
3252         (shell_escape): Call exit_status_set_internal_vars.
3253         cli/cli-decode.c (find_command_name_length): Recognize | as
3254         a single character command.
3255
3256 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3257
3258         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3259         top.c (execute_command_to_ui_file): New function, mostly a copy
3260         of execute_command_to_string.
3261         (execute_command_to_string): Implement by calling
3262         execute_command_to_ui_file.
3263
3264 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3265
3266         * top.h (saved_command_line): Remove declaration.
3267         * top.c (previous_saved_command_line, previous_repeat_arguments):
3268         New variables.
3269         (saved_command_line): Make static, define together with other
3270         'repeat variables'.
3271         (dont_repeat): Clear repeat_arguments.
3272         (repeat_previous, get_saved_command_line, save_command_line):
3273         New functions.
3274         (gdb_init): Initialize saved_command_line
3275         and previous_saved_command_line.
3276         * main.c (captured_main_1): Remove saved_command_line initialization.
3277         * event-top.c (handle_line_of_input): Update to use
3278         the new 'repeat' related functions instead of direct access to
3279         saved_command_line.
3280         * command.h (repeat_previous, get_saved_command_line,
3281         save_command_line): New declarations.
3282         (dont_repeat): Add comment.
3283
3284 2019-05-30  Tom Tromey  <tromey@adacore.com>
3285
3286         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3287         Fix comment.
3288         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3289
3290 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3291
3292         PR cli/24587
3293         * completer.c (complete): Initialize variable word.
3294
3295 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3296
3297         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3298         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3299         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3300         'body' is NULL to the outter 'if', protecting the '!is_define'
3301         situation as well.
3302
3303 2019-05-29  Tom Tromey  <tromey@adacore.com>
3304
3305         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3306         (dwarf_unknown): New function.
3307         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3308         (dwarf_type_encoding_name): Use dwarf_unknown.
3309
3310 2019-05-29  Tom Tromey  <tromey@adacore.com>
3311
3312         PR c++/20020:
3313         * cp-valprint.c (cp_print_value_fields): Call
3314         cp_print_static_field inside "try".
3315
3316 2019-05-29  Tom Tromey  <tromey@adacore.com>
3317
3318         * inflow.c (struct terminal_info): Add default operator=.
3319         * configure: Rebuild.
3320         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3321         -Wdeprecated-copy-dtor, -Wredundant-move.
3322
3323 2019-05-29  Tom Tromey  <tromey@adacore.com>
3324
3325         * NEWS: Add entry.
3326         * infcmd.c (print_return_value_1): Handle finish_print
3327         option.
3328         (show_print_finish): New function.
3329         (_initialize_infcmd): Add "set/show print finish" commands.
3330         * valprint.c (user_print_options): Initialize new member.
3331         * valprint.h (struct value_print_options) <finish_print>: New
3332         member.
3333
3334 2019-05-28  Tom Tromey  <tromey@adacore.com>
3335
3336         * ada-lang.c (ada_remove_Xbn_suffix)
3337         (find_old_style_renaming_symbol)
3338         (parse_old_style_renaming): Remove.
3339         (ada_find_renaming_symbol): Don't call
3340         find_old_style_renaming_symbol.
3341         (ada_is_renaming_symbol): Rename from
3342         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3343         bool.  Now static.
3344         (ada_read_var_value): Update and simplify.
3345         * ada-exp.y (write_var_or_type): Remove old code.
3346
3347 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3348
3349         * event-top.c: Remove include comment.
3350         * inflow.c (class scoped_ignore_sigttou): Move from here...
3351         * inflow.h (class scoped_ignore_sigttou): ...to here.
3352         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3353         * top.c:  Remove include comment.
3354
3355 2019-05-27  Tom Tromey  <tom@tromey.com>
3356
3357         * NEWS: Fix typo.
3358
3359 2019-05-22  Tom Tromey  <tromey@adacore.com>
3360
3361         * target.c (target_follow_exec): Constify parameter.
3362         * target-delegates.c: Rebuild.
3363         * remote.c (remote_target::follow_exec): Constify parameter.
3364         * infrun.c (follow_exec): Constify parameter.
3365         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3366         (target_follow_exec): Likewise.
3367
3368 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3369
3370         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3371         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3372
3373 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3374
3375         * NEWS: Add debugredirect and testsuite sections.
3376
3377 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3378
3379         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3380         target descriptions using exclusively floating point register name
3381         aliases.
3382
3383 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3384
3385         PR gdb/18644:
3386         * f-lang.c (build_fortran_types): Handle the case where
3387         gdbarch_floatformat_for_type returns a nullptr.
3388
3389 2019-05-21  Tom de Vries  <tdevries@suse.de>
3390
3391         PR cli/24587
3392         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3393
3394 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3395
3396         PR gdb/18644:
3397         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3398         16-byte floats.
3399         * i386-tdep.c (i386_floatformat_for_type): Use
3400         floatformats_ia64_quad for the 16-byte floating point component
3401         within a fortran 32-byte complex number.
3402
3403 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3404
3405         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3406         delete default constructor.
3407         (find_partial_die): Update to return const struct.
3408         (partial_die_parent_scope): Move variable declaration into scope
3409         of its use and change its type to auto.
3410         (guess_partial_die_structure_name): Likewise.
3411         (partial_die_info::fixup): Likewise.
3412
3413 2019-05-17  Tom Tromey  <tromey@adacore.com>
3414
3415         * source.c (find_and_open_source): Remove cast.
3416
3417 2019-05-17  Tom Tromey  <tromey@adacore.com>
3418
3419         * annotate.c (annotate_source): Make "filename" const.
3420         * annotate.h (annotate_source): Use const.
3421
3422 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3423
3424         * disasm.c (set_disassembler_options): Send errors to stderr.
3425
3426 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3427
3428         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3429         (cli_interp_base::set_logging): Check debug_redirect.
3430         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3431         * cli/cli-logging.c (debug_redirect): Add static variable.
3432         (pop_output_files): Add default param.
3433         (handle_redirections): Print debug setting.
3434         (show_logging_command): Likewise.
3435         (_initialize_cli_logging): Add debugredirect command.
3436         * interps.c (current_interp_set_logging): Add debug_redirect
3437         parameter.
3438         * interps.h (set_logging): Add debug_redirect parameter.
3439         (current_interp_set_logging): Likewise.
3440         * mi/mi-common.h: Likewise.
3441         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3442
3443 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3444             Tom Tromey  <tromey@adacore.com>
3445
3446         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3447         directly.
3448         * cli/cli-interp.h (make_logging_output): Remove declaration.
3449         * cli/cli-logging.c (make_logging_output): Remove function.
3450         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3451         directly.
3452         * ui-file.c (tee_file::tee_file): Remove bools.
3453         (tee_file::~tee_file): Remove deletes.
3454         * ui-file.h (tee_file): Remove bools.
3455
3456 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3457
3458         * mi/mi-cmds.h (mi_cmd_complete): New function.
3459         * mi/mi-main.c (mi_cmd_complete): Likewise.
3460         * mi/mi-cmds.c: Define new MI command -complete.
3461         * NEWS: Mention new -complete command.
3462
3463 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3464
3465         * completer.h (complete): New function.
3466         * completer.c (complete): Likewise.
3467         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3468         function defined in completer.h.
3469
3470 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3471
3472         * MAINTAINERS (Write After Approval): Add myself.
3473
3474 2019-05-17  Tom de Vries  <tdevries@suse.de>
3475
3476         PR gdb/24094
3477         * dwarf2read.c (struct cu_partial_die_info): New struct.
3478         (find_partial_die): Return cu_partial_die_info.
3479         (partial_die_parent_scope, guess_partial_die_structure_name)
3480         (partial_die_info::fixup): Handle new return type of find_partial_die.
3481
3482 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3483
3484         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3485         "std::string", simplifying the algorithm.
3486
3487 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3488
3489         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3490         (stap_static_probe_ops::get_probes): Likewise.
3491
3492 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3493
3494         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3495         '-')" and "else if".
3496         (stap_parse_single_operand): Join checks for
3497         "gdbarch_stap_parse_special_token_p" and
3498         "gdbarch_stap_parse_special_token" in the same "if" statement.
3499         Invert check when verifying for operation on register
3500         displacement.
3501
3502 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3503
3504         * stap-probe.c (stap_get_opcode): Update comment.
3505         (stap_get_expected_argument_type): Likewise.
3506         (handle_stap_probe): Likewise.
3507
3508 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3509
3510         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3511         return type to 'bool'.  Adjust comment.  Use 'bool' when
3512         appropriate.
3513         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3514         * stap-probe.c (stap_parse_argument_1): Likewise.
3515         (stap_is_operator): Likewise.
3516         (stap_is_generic_prefix): Likewise.
3517         (stap_is_register_prefix): Likewise.
3518         (stap_is_register_indirection_prefix): Likewise.
3519         (stap_is_integer_prefix): Likewise.
3520         (stap_generic_check_suffix): Likewise.
3521         (stap_check_integer_suffix): Likewise.
3522         (stap_check_register_suffix): Likewise.
3523         (stap_check_register_indirection_suffix): Likewise.
3524         (stap_parse_register_operand): Likewise.
3525         (stap_parse_single_operand): Likewise.
3526         (stap_parse_argument_1): Likewise.
3527         (stap_probe::get_argument_count): Likewise.
3528         (stap_is_operator): Likewise.
3529
3530 2019-05-16  Tom Tromey  <tromey@adacore.com>
3531
3532         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3533         keyword to foreach.
3534
3535 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3536
3537         * linux-thread-db.c (try_thread_db_load_1): Change return type
3538         to bool.
3539         (try_thread_db_load): Likewise.
3540         (try_thread_db_load_from_pdir_1): Likewise.
3541         (try_thread_db_load_from_pdir): Likewise.
3542         (try_thread_db_load_from_sdir): Likewise.
3543         (try_thread_db_load_from_dir): Likewise.
3544         (thread_db_load_search): Likewise.
3545         (has_libpthread): Likewise.
3546         (thread_db_load): Likewise.
3547
3548 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3549
3550         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3551         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3552         NULL, and complain/return if that's the case.
3553
3554 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3555
3556         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3557         (advance, posn, abstract_read_memory): New functions.
3558         [struct mem_read_abstraction]: New struct.
3559         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3560
3561 2019-05-14  Tom Tromey  <tromey@adacore.com>
3562
3563         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3564         value is not lval_memory.
3565
3566 2019-05-14  Tom Tromey  <tromey@adacore.com>
3567
3568         * solib.c (info_sharedlibrary_command): Style the file name.
3569
3570 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3571
3572         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3573         (aarch64_vnv_type): Likewise.
3574         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3575         * common/tdesc.c: Likewise.
3576         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3577         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3578         * features/aarch64-fpu.xml: Add ieee half view.
3579         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3580         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3581         * gdbtypes.h (struct builtin_type): Likewise.
3582         (struct objfile_type): Likewise.
3583
3584 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3585
3586         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3587         typo.
3588         * location.h (string_to_event_location): Likewise.
3589
3590 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3591
3592         GDB 8.3 released.
3593
3594 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3595
3596         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3597         New variable declaration.
3598         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3599         New variable.
3600         (print_one_breakpoint): Use ui_out::test_flags and new global
3601         variable to compute use_fixed_output.
3602         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3603         Remove.
3604         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3605         (mi_multi_location_breakpoint_output_fixed): Remove.
3606         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3607         new variable.
3608         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3609         fix_multi_location_breakpoint_output flag if version >= 3.
3610         * ui-out.h (enum ui_out_flag)
3611         <fix_multi_location_breakpoint_output>: New enumerator.
3612
3613 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3614
3615         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3616
3617 2019-05-10  Tom Tromey  <tromey@adacore.com>
3618
3619         * ada-lang.c (catch_ada_completer): New function.
3620         (_initialize_ada_language): Use it.
3621
3622 2019-05-10  Tom Tromey  <tromey@adacore.com>
3623
3624         * thread.c (print_thread_info): Make "requested_threads" const.
3625         * gdbthread.h (print_thread_info): Make "requested_threads"
3626         const.
3627         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3628         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3629
3630 2019-05-08  Tom Tromey  <tom@tromey.com>
3631
3632         * gdbtypes.c (objfile_type_data): Change type.
3633         (objfile_type, _initialize_gdbtypes): Update.
3634
3635 2019-05-08  Tom Tromey  <tom@tromey.com>
3636
3637         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3638         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3639         (_initialize_dwarf2_frame): Update.
3640
3641 2019-05-08  Tom Tromey  <tom@tromey.com>
3642
3643         * objc-lang.c (objc_objfile_data): Change type.
3644         (find_methods): Update.
3645         (_initialize_objc_lang): Remove.
3646
3647 2019-05-08  Tom Tromey  <tom@tromey.com>
3648
3649         * stabsread.c (rs6000_builtin_type_data): Change type.
3650         (rs6000_builtin_type, _initialize_stabsread): Update.
3651
3652 2019-05-08  Tom Tromey  <tom@tromey.com>
3653
3654         * mips-tdep.c (mips_pdr_data): Remove.
3655         (_initialize_mips_tdep): Update.
3656
3657 2019-05-08  Tom Tromey  <tom@tromey.com>
3658
3659         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3660         (hppa_init_objfile_priv_data, read_unwind_info)
3661         (find_unwind_entry, _initialize_hppa_tdep): Update.
3662
3663 2019-05-08  Tom Tromey  <tom@tromey.com>
3664
3665         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3666         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3667         on obstack.
3668         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3669
3670 2019-05-08  Tom Tromey  <tom@tromey.com>
3671
3672         * mdebugread.c (basic_type_data): Change type.
3673         (basic_type, _initialize_mdebugread): Update.
3674
3675 2019-05-08  Tom Tromey  <tom@tromey.com>
3676
3677         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3678
3679 2019-05-08  Tom Tromey  <tom@tromey.com>
3680
3681         * nto-tdep.c (nto_inferior_data_reg): Change type.
3682         (nto_inferior_data): Update.
3683         (nto_inferior_data_cleanup, nto_new_inferior_data)
3684         (_initialize_nto_tdep): Remove.
3685         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3686
3687 2019-05-08  Tom Tromey  <tom@tromey.com>
3688
3689         * ada-lang.c (struct ada_inferior_data): Add initializers.
3690         (ada_inferior_data): Change type.
3691         (ada_inferior_data_cleanup): Remove.
3692         (get_ada_inferior_data, ada_inferior_exit)
3693         (struct ada_pspace_data): Add initializers, destructor.
3694         (ada_pspace_data_handle): Change type.
3695         (get_ada_pspace_data): Update.
3696         (ada_pspace_data_cleanup): Remove.
3697
3698 2019-05-08  Tom Tromey  <tom@tromey.com>
3699
3700         * coffread.c (struct coff_symfile_info): Add initializers.
3701         (coff_objfile_data_key): Move lower.  Change type.
3702         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3703         Update.
3704         (coff_free_info): Remove.
3705
3706 2019-05-08  Tom Tromey  <tom@tromey.com>
3707
3708         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3709         (fbsd_pspace_data_handle): Move lower.  Change type.
3710         (get_fbsd_pspace_data): Update.
3711         (fbsd_pspace_data_cleanup): Remove.
3712         (_initialize_fbsd_tdep): Update.
3713
3714 2019-05-08  Tom Tromey  <tom@tromey.com>
3715
3716         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3717         (get_ada_tasks_pspace_data): Update.
3718         (ada_tasks_pspace_data_cleanup): Remove.
3719         (_initialize_tasks): Update.
3720         (ada_tasks_inferior_data_handle): Change type.
3721         (get_ada_tasks_inferior_data): Update.
3722         (ada_tasks_inferior_data_cleanup): Remove.
3723         (struct ada_tasks_pspace_data): Add initializers.
3724
3725 2019-05-08  Tom Tromey  <tom@tromey.com>
3726
3727         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3728         * symfile-debug.c (debug_sym_get_probes): Change type.
3729         * stap-probe.c (handle_stap_probe):
3730         (stap_static_probe_ops::get_probes): Change type.
3731         * probe.h (class static_probe_ops) <get_probes>: Change type.
3732         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3733         (parse_probes_in_pspace): Update.
3734         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3735         Update.
3736         (any_static_probe_ops::get_probes): Change type.
3737         * elfread.c (elfread_data): New typedef.
3738         (probe_key): Change type.
3739         (elf_get_probes): Likewise.  Update.
3740         (probe_key_free): Remove.
3741         (_initialize_elfread): Update.
3742         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3743         Change type.
3744         (dtrace_process_dof_probe, dtrace_process_dof)
3745         (dtrace_static_probe_ops::get_probe): Change type.
3746
3747 2019-05-08  Tom Tromey  <tom@tromey.com>
3748
3749         * xcoffread.c (struct xcoff_symfile_info): Rename from
3750         coff_symfile_info.  Add initializers.
3751         (xcoff_objfile_data_key): Move lower.  Change type.
3752         (XCOFF_DATA): Rewrite.
3753         (xcoff_free_info): Remove.
3754         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3755         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3756         (xcoff_initial_scan): Update.
3757
3758 2019-05-08  Tom Tromey  <tom@tromey.com>
3759
3760         * solib-svr4.c (struct svr4_info): Add initializers and
3761         destructor.
3762         <probes_table>: Now an htab_up.
3763         (solib_svr4_pspace_data): Change type.
3764         (free_probes_table): Simplify.
3765         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3766         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3767         (probes_table_remove_objfile_probes, register_solib_event_probe)
3768         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3769         (_initialize_svr4_solib): Update.
3770
3771 2019-05-08  Tom Tromey  <tom@tromey.com>
3772
3773         * remote.c (remote_pspace_data): Change type.
3774         (remote_pspace_data_cleanup): Remove.
3775         (get_remote_exec_file, set_pspace_remote_exec_file)
3776         (_initialize_remote): Update.
3777
3778 2019-05-08  Tom Tromey  <tom@tromey.com>
3779
3780         * breakpoint.c (breakpoint_objfile_key): Change type.
3781         (get_breakpoint_objfile_data): Update.
3782         (free_breakpoint_objfile_data): Remove.
3783         (_initialize_breakpoint): Update.
3784
3785 2019-05-08  Tom Tromey  <tom@tromey.com>
3786
3787         * linux-tdep.c (struct linux_info): Add initializers.
3788         (linux_inferior_data): Move.  Change type.
3789         (invalidate_linux_cache_inf): Update.
3790         (linux_inferior_data_cleanup): Remove.
3791         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3792
3793 2019-05-08  Tom Tromey  <tom@tromey.com>
3794
3795         * auxv.c (auxv_inferior_data): Move.  Change type.
3796         (auxv_inferior_data_cleanup): Remove.
3797         (invalidate_auxv_cache_inf): Rewrite.
3798         (get_auxv_inferior_data, _initialize_auxv): Update.
3799
3800 2019-05-08  Tom Tromey  <tom@tromey.com>
3801
3802         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3803         (symfile_debug_objfile_data_key): Change type.
3804         (symfile_debug_installed, debug_qf_has_symbols)
3805         (debug_qf_find_last_source_symtab)
3806         (debug_qf_forget_cached_source_info)
3807         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3808         (debug_qf_print_stats, debug_qf_dump)
3809         (debug_qf_expand_symtabs_for_function)
3810         (debug_qf_expand_all_symtabs)
3811         (debug_qf_expand_symtabs_with_fullname)
3812         (debug_qf_map_matching_symbols)
3813         (debug_qf_expand_symtabs_matching)
3814         (debug_qf_find_pc_sect_compunit_symtab)
3815         (debug_qf_map_symbol_filenames)
3816         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3817         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3818         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3819         (debug_sym_read_linetable, debug_sym_relocate): Update.
3820         (symfile_debug_free_objfile): Remove.
3821         (install_symfile_debug_logging, _initialize_symfile_debug):
3822         Update.
3823
3824 2019-05-08  Tom Tromey  <tom@tromey.com>
3825
3826         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3827         allocate_on_obstack.
3828         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3829         (get_dwarf2_per_objfile): Update.
3830         (set_dwarf2_per_objfile): Remove.
3831         (dwarf2_has_info, dwarf2_get_section_info): Update.
3832         (dwarf2_free_objfile): Remove.
3833         (_initialize_dwarf2_read): Update.
3834
3835 2019-05-08  Tom Tromey  <tom@tromey.com>
3836
3837         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3838         initializers.
3839         <unsupported_script_warning_printed,
3840         script_not_found_warning_printed>: Now bool.
3841         (auto_load_pspace_data): Change type.
3842         (~auto_load_pspace_info): Rename from
3843         auto_load_pspace_data_cleanup.
3844         (get_auto_load_pspace_data, init_loaded_scripts_info)
3845         (clear_section_scripts, maybe_print_unsupported_script_warning)
3846         (maybe_print_script_not_found_warning, _initialize_auto_load):
3847         Update.
3848
3849 2019-05-08  Tom Tromey  <tom@tromey.com>
3850
3851         * objfiles.c (objfile_pspace_info): Add destructor and
3852         initializers.
3853         (objfiles_pspace_data): Change type.
3854         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3855         (get_objfile_pspace_data): Update.
3856         (objfiles_bfd_data): Change type.
3857         (get_objfile_bfd_data): Update.
3858         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3859
3860 2019-05-08  Tom Tromey  <tom@tromey.com>
3861
3862         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3863         Change type.
3864         (get_catch_syscall_inferior_data): Update.
3865         (catch_syscall_inferior_data_cleanup): Remove.
3866         (_initialize_break_catch_syscall): Update.
3867
3868 2019-05-08  Tom Tromey  <tom@tromey.com>
3869
3870         * inflow.c (struct terminal_info): Add destructor and
3871         initializers.
3872         (inflow_inferior_data): Change type.
3873         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3874         (get_inflow_inferior_data, inflow_inferior_exit)
3875         (swap_terminal_info, _initialize_inflow): Update.
3876
3877 2019-05-08  Tom Tromey  <tom@tromey.com>
3878
3879         * target-dcache.c (target_dcache_cleanup): Remove.
3880         (target_dcache_aspace_key): Change type.
3881         (target_dcache_init_p, target_dcache_invalidate)
3882         (target_dcache_get, target_dcache_get_or_init)
3883         (_initialize_target_dcache): Update.
3884         * dcache.h (struct dcache_deleter): New.
3885
3886 2019-05-08  Tom Tromey  <tom@tromey.com>
3887
3888         * symtab.c (struct symbol_cache): Add destructor and
3889         initializers.
3890         (symbol_cache_key): Move.  Change type.
3891         (make_symbol_cache, free_symbol_cache): Remove.
3892         (get_symbol_cache): Update.
3893         (symbol_cache_cleanup): Remove.
3894         (ALL_PSPACES, symbol_cache_flush)
3895         (maintenance_print_symbol_cache)
3896         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3897         Update.
3898
3899 2019-05-08  Tom Tromey  <tom@tromey.com>
3900
3901         * symtab.c (struct main_info): Add destructor and initializers.
3902         (main_progspace_key): Move.  Change type.
3903         (get_main_info): Update.
3904         (main_info_cleanup): Remove.
3905         (_initialize_symtab): Update.
3906
3907 2019-05-08  Tom Tromey  <tom@tromey.com>
3908
3909         * registry.h (DECLARE_REGISTRY): Define the _key class.
3910
3911 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3912
3913         * NEWS: Merge two 'New commands' sections.
3914
3915 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3916
3917         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3918         parameter and use Ada language definition instead.
3919         (ada_val_print_ptr): Remove unused language parameter.
3920         (ada_val_print_num): Remove language parameter and use Ada language
3921         definition instead.
3922         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3923         parameter.
3924         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3925         parameter and use Ada language definition instead.
3926         (ada_val_print_1): Update all ada_val_print_xxx calls.
3927         Remove language parameter.
3928         (ada_val_print): Update ada_val_print_1 call.
3929
3930 2019-05-08  Tom Tromey  <tromey@adacore.com>
3931
3932         * remote.c (remote_hw_watchpoint_limit)
3933         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3934         Now static.
3935
3936 2019-05-08  Tom Tromey  <tromey@adacore.com>
3937
3938         * maint.c (_initialize_maint_cmds): Move initialization code to
3939         remote.c.
3940         (watchdog, show_watchdog): Move to remote.c.
3941         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3942         "watchdog" static.
3943         (_initialize_remote): Move initialization code from maint.c.
3944         * defs.h (watchdog): Don't declare.
3945
3946 2019-05-08  Tom Tromey  <tromey@adacore.com>
3947
3948         * tui/tui-interp.c: Include main.h.
3949         * interps.c: Include main.h.
3950         * main.h (interpreter_p): Declare.
3951         * defs.h (interpreter_p): Don't declare.
3952
3953 2019-05-08  Tom Tromey  <tromey@adacore.com>
3954
3955         * dwarf2loc.c: Include dwarf2read.h.
3956         * defs.h (read_unsigned_leb128): Don't declare.
3957         * dwarf2read.h (read_unsigned_leb128): Declare.
3958
3959 2019-05-08  Tom Tromey  <tromey@adacore.com>
3960
3961         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3962         method.
3963
3964 2019-05-08  Tom Tromey  <tromey@adacore.com>
3965
3966         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3967         when no wrap column is set.
3968
3969 2019-05-08  Tom Tromey  <tromey@adacore.com>
3970
3971         * c-lang.c (c_get_string): Handle non-C-style arrays.
3972
3973 2019-05-08  Tom Tromey  <tromey@adacore.com>
3974
3975         * typeprint.c (print_offset_data::update): Print the bit offset,
3976         not the number of bits remaining.
3977
3978 2019-05-08  Tom Tromey  <tromey@adacore.com>
3979
3980         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3981         padding at end of comment.
3982
3983 2019-05-08  Tom Tromey  <tromey@adacore.com>
3984
3985         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3986         Compare main types.
3987
3988 2019-05-06  Tom Tromey  <tom@tromey.com>
3989
3990         * common/scoped_mmap.c: Include common-defs.h.
3991         * common/scoped_mmap.h: Don't include config.h.
3992
3993 2019-05-04  Tom Tromey  <tom@tromey.com>
3994
3995         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3996         (struct aarch64_call_info): Add initializers.
3997         <si>: Now a std::vector.
3998         (pass_on_stack, aarch64_push_dummy_call): Update.
3999
4000 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4001             Tom Tromey  <tom@tromey.com>
4002
4003         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4004         (ppc_threads): Now a std::vector.  Now static.
4005         (hwdebug_find_thread_points_by_tid)
4006         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4007         Update.
4008
4009 2019-05-04  Tom Tromey  <tom@tromey.com>
4010
4011         * arc-tdep.c (arc_tdesc_init): Return bool.
4012
4013 2019-05-04  Tom Tromey  <tom@tromey.com>
4014
4015         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4016         Use gdb_assert_not_reached.
4017
4018 2019-05-04  Tom Tromey  <tom@tromey.com>
4019
4020         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4021         "false".
4022
4023 2019-05-04  Tom Tromey  <tom@tromey.com>
4024
4025         * arc-tdep.c (arc_tdesc_init): Use bool.
4026
4027 2019-05-04  Tom Tromey  <tom@tromey.com>
4028
4029         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4030
4031 2019-05-04  Tom Tromey  <tom@tromey.com>
4032
4033         * cli/cli-cmds.c (valid_command_p): Return bool.
4034
4035 2019-05-04  Tom Tromey  <tom@tromey.com>
4036
4037         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4038         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4039
4040 2019-05-04  Raul Tambre  <raul@tambre.ee>
4041
4042         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4043         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4044         operator for comparison.
4045
4046 2019-05-04  Tom Tromey  <tom@tromey.com>
4047
4048         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4049         (lookup_partial_symbol, print_partial_symbols)
4050         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4051         (psymbol_compare): Update.
4052         (add_psymbol_to_bcache): Clear the entire psymbol.
4053         (maintenance_check_psymtabs): Update.
4054         * psympriv.h (struct partial_symbol): Don't derive from
4055         general_symbol_info.
4056         <obj_section, unrelocated_address, address,
4057         set_unrelocated_address>: Update.
4058         <ginfo>: New member.
4059         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4060         (debug_names::write_psymbols): Update.
4061
4062 2019-05-04  Tom de Vries  <tdevries@suse.de>
4063
4064         * contrib/cc-with-tweaks.sh: Support -n arg.
4065
4066 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4067
4068         * corelow.c (core_target::detach): Ensure frame cache and
4069         register caches are cleared.
4070         inferior.c (exit_inferior_1): Likewise.
4071
4072 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4073             Tom Tromey  <tom@tromey.com>
4074
4075         * dictionary.c (collate_pending_symbols_by_language): Remove
4076         "struct" from foreach.
4077         * symtab.c (lookup_global_symbol_from_objfile)
4078         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4079         foreach.
4080         * ser-tcp.c (net_open): Remove "struct" from foreach.
4081         * objfiles.c (objfile_relocate, objfile_rebase)
4082         (objfile_has_symbols): Remove "struct" from foreach.
4083         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4084         from foreach.
4085         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4086         foreach.
4087         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4088         "struct" from foreach.
4089         * ada-lang.c (create_excep_cond_exprs)
4090         (ada_exception_catchpoint_cond_string): Remove "struct" from
4091         foreach.
4092
4093 2019-05-03  Tom Tromey  <tromey@adacore.com>
4094
4095         * ada-exp.y (convert_char_literal): Check suffix of each
4096         enumerator.
4097
4098 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4099
4100         PR ada/21406:
4101         * ada-exp.y (yywrap): Don't define.
4102         * ada-lex.l (%option): Add noyywrap
4103         (yywrap): Remove.
4104
4105 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4106
4107         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4108         _WIN32_WINNT to the XP level, unless already defined to a higher
4109         level.
4110
4111         * unittests/parse-connection-spec-selftests.c:
4112         * ser-tcp.c:
4113         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4114         override.
4115
4116         * symfile.c (find_separate_debug_file): Remove colon from the
4117         drive spec of DOS/Windows file names of the target, so that the
4118         file name produced from DEBUGDIR and the target's directory will
4119         be valid on DOS/Windows systems.
4120
4121 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4122
4123         * rust-lang.c (val_print_struct): Handle printing structures
4124         containing strings.
4125
4126 2019-05-02  Tom Tromey  <tromey@adacore.com>
4127
4128         * valarith.c (_initialize_valarith): Remove.
4129
4130 2019-05-01  Tom Tromey  <tromey@adacore.com>
4131
4132         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4133         bitfields.
4134
4135 2019-05-01  Tom Tromey  <tromey@adacore.com>
4136
4137         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4138         for big-endian copies.
4139
4140 2019-04-30  Ali Tamur  <tamur@google.com>
4141         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4142         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4143         (read_3_bytes): New function.
4144
4145 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4146
4147         * windows-nat.c (main_thread_id): Delete.
4148         (handle_output_debug_string): Replace main_thread_id by
4149         current_event.dwThreadId.
4150         (fake_create_process): Likewise.
4151         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4152         Do not set main_thread_id.
4153         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4154         current_event.dwThreadId.
4155         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4156
4157 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4158
4159         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4160         Use current_event.dwThreadId instead of main_thread_id.
4161
4162 2019-04-30  Tom Tromey  <tromey@adacore.com>
4163
4164         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4165         (create_excep_cond_exprs): Iterate over program spaces.
4166         (ada_exception_catchpoint_cond_string): Examine all minimal
4167         symbols for exception types.
4168
4169 2019-04-30  Tom Tromey  <tromey@adacore.com>
4170
4171         PR c++/24470:
4172         * dwarf2read.c (process_structure_scope): Handle case where type
4173         has template parameters but no symbol was created.
4174
4175 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4176             Chris January  <chris.january@arm.com>
4177
4178         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4179         qualifier.
4180         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4181
4182 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4183
4184         * f-typeprint.c (f_print_type): Update rules for printing
4185         whitespace.
4186         (f_type_print_varspec_suffix): Likewise.
4187
4188 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4189             Chris January  <chris.january@arm.com>
4190
4191         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4192         function arguments.
4193
4194 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4195
4196         * f-lang.c (build_fortran_types): Change name of void type to
4197         lower case.
4198         * f-typeprint.c (f_type_print_base): Print the name of the void
4199         type, rather than a fixed string.
4200         * f-valprint.c (f_decorations): Use lower case void string.
4201
4202 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4203             Chris January  <chris.january@arm.com>
4204
4205         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4206         types for Fortran.
4207
4208 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4209             Chris January  <chris.january@arm.com>
4210             David Lecomber  <david.lecomber@arm.com>
4211
4212         * f-exp.y (BINOP_INTRINSIC): New token.
4213         (exp): New parser rule handling BINOP_INTRINSIC.
4214         (f77_keywords): Add new builtin procedures.
4215         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4216         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4217         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4218         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4219         (print_unop_subexp_f): New function.
4220         (print_binop_subexp_f): New function.
4221         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4222         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4223         (dump_subexp_body_f): Likewise.
4224         (operator_check_f): Likewise.
4225         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4226         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4227
4228 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4229
4230         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4231         UNOP_KIND.
4232         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4233         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4234         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4235         (operator_length_f): New fuction.
4236         (print_subexp_f): New function.
4237         (op_name_f): New function.
4238         (dump_subexp_body_f): New function.
4239         (operator_check_f): New function.
4240         (exp_descriptor_f): Replace standard expression handling functions
4241         with new functions.
4242         * gdb/fortran-operator.def: New file.
4243         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4244         * gdb/std-operator.def: Remove UNOP_KIND.
4245
4246 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4247
4248         * std-operator.def: Remove unbalanced, stray double quote
4249         character.
4250
4251 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4252             Chris January  <chris.january@arm.com>
4253             Daniel Everett  <daniel.everett@arm.com>
4254             Nick Forrington  <nick.forrington@arm.com>
4255             Richard Bunt  <richard.bunt@arm.com>
4256
4257         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4258         of depth when printing anonymous structs or unions.
4259         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4260         Don't print either the top-level value, or the children if the
4261         max-depth is exceeded.
4262         (ppscm_print_children): When printing the key of a map, allow one
4263         extra level of depth.
4264         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4265         print either the top-level value, or the children if the max-depth
4266         is exceeded.
4267         (print_children): When printing the key of a map, allow one extra
4268         level of depth.
4269         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4270         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4271         (user_print_options): Initialise max_depth field.
4272         (val_print_scalar_or_string_type_p): New function.
4273         (val_print): Check to see if the max depth has been reached.
4274         (val_print_check_max_depth): Define new function.
4275         (show_print_max_depth): New function.
4276         (_initialize_valprint): Add 'print max-depth' option.
4277         * valprint.h (struct value_print_options) <max_depth>: New field.
4278         (val_print_check_max_depth): Declare new function.
4279         * NEWS: Document new feature.
4280
4281 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4282
4283         * ada-lang.c (ada_language_defn): Initialise new field.
4284         * c-lang.c (c_is_string_type_p): New function.
4285         (c_language_defn): Initialise new field.
4286         (cplus_language_defn): Initialise new field.
4287         (asm_language_defn): Initialise new field.
4288         (minimal_language_defn): Initialise new field.
4289         * c-lang.h (c_is_string_type_p): Declare new function.
4290         * d-lang.c (d_language_defn): Initialise new field.
4291         * f-lang.c (f_is_string_type_p): New function.
4292         (f_language_defn): Initialise new field.
4293         * go-lang.c (go_is_string_type_p): New function.
4294         (go_language_defn): Initialise new field.
4295         * language.c (default_is_string_type_p): New function.
4296         (unknown_language_defn): Initialise new field.
4297         (auto_language_defn): Initialise new field.
4298         * language.h (struct language_defn) <la_is_string_type_p>: New
4299         member variable.
4300         (default_is_string_type_p): Declare new function.
4301         * m2-lang.c (m2_language_defn): Initialise new field.
4302         * objc-lang.c (objc_language_defn): Initialise new field.
4303         * opencl-lang.c (opencl_language_defn): Initialise new field.
4304         * p-lang.c (pascal_is_string_type_p): New function.
4305         (pascal_language_defn): Initialise new field.
4306         * rust-lang.c (rust_is_string_type_p): New function.
4307         (rust_language_defn): Initialise new field.
4308
4309 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4310
4311         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4312         New field.
4313         * ada-lang.c (ada_language_defn): Initialise new field.
4314         * c-lang.c (c_language_defn): Likewise.
4315         (cplus_language_defn): Likewise.
4316         (asm_language_defn): Likewise.
4317         (minimal_language_defn): Likewise.
4318         * d-lang.c (d_language_defn): Likewise.
4319         * f-lang.c (f_language_defn): Likewise.
4320         * go-lang.c (go_language_defn): Likewise.
4321         * language.c (unknown_language_defn): Likewise.
4322         (auto_language_defn): Likewise.
4323         * m2-lang.c (m2_language_defn): Likewise.
4324         * objc-lang.c (objc_language_defn): Likewise.
4325         * opencl-lang.c (opencl_language_defn): Likewise.
4326         * p-lang.c (pascal_language_defn): Likewise.
4327         * rust-lang.c (rust_language_defn): Likewise.
4328
4329 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4330
4331         * ada-lang.c (ada_is_character_type): Change return type to bool.
4332         (ada_is_string_type): Likewise.
4333         * ada-lang.h (ada_is_character_type): Update declaration
4334         (ada_is_string_type): Likewise.
4335
4336 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4337
4338         Support style in 'frame|thread apply'
4339
4340         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4341         * record.c (record_start, record_stop): Update callers of
4342         execute_command_to_string with false.
4343         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4344         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4345         methods.
4346         (class string_file): New constructor with term_out parameter.
4347         Override methods term_out and can_emit_style_escape.  New member
4348         term_out.
4349         (class stdio_file): Override can_emit_style_escape.
4350         (class tee_file): Override term_out and can_emit_style_escape.
4351         * utils.h (can_emit_style_escape): Remove.
4352         * utils.c (can_emit_style_escape): Likewise.
4353         Update all callers of can_emit_style_escape (SOMESTREAM) to
4354         SOMESTREAM->can_emit_style_escape.
4355         * source-cache.c (source_cache::get_source_lines): Likewise.
4356         * stack.c (frame_apply_command_count): Call execute_command_to_string
4357         passing the term_out characteristic of the current gdb_stdout.
4358         * thread.c (thr_try_catch_cmd): Likewise.
4359         * top.c (execute_command_to_string): pass term_out parameter
4360         to construct the string_file for the command output.
4361         * ui-file.c (term_cli_styling): New function (most code moved
4362         from utils.c can_emit_style_escape).
4363         (string_file::string_file, string_file::can_emit_style_escape,
4364         stdio_file::can_emit_style_escape, tee_file::term_out,
4365         tee_file::can_emit_style_escape): New functions.
4366
4367 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4368
4369         * NEWS: Mention the new set|show may-call-functions.
4370         * infcall.c (may_call_functions_p): New variable.
4371         (show_may_call_functions_p): New function.
4372         (call_function_by_hand_dummy): Throws an error if not
4373         may-call-functions.
4374         (_initialize_infcall): Call add_setshow_boolean_cmd for
4375         may-call-functions.
4376
4377 2019-04-25  Keith Seitz  <keiths@redhat.com>
4378
4379         PR c++/24367
4380         * cp-support.c (inspect_type): Don't attempt substitutions
4381         of symbol with the same name.
4382
4383 2019-04-25  Tom Tromey  <tromey@adacore.com>
4384
4385         PR gdb/24475:
4386         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4387         static.
4388
4389 2019-04-25  Tom Tromey  <tromey@adacore.com>
4390
4391         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4392         rvalue reference.
4393         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4394         (gdb_xml_parser::parse): Use std::move.
4395         * python/python-internal.h (gdbpy_convert_exception): Take a const
4396         reference.
4397         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4398         std::move.
4399         * python/py-utils.c (gdbpy_convert_exception): Take a const
4400         reference.
4401         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4402         Use std::move.
4403         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4404         Use std::move.
4405         * mi/mi-main.c (mi_print_exception): Take a const reference.
4406         * main.c (handle_command_errors): Take a const reference.
4407         * linespec.c (parse_linespec): Use std::move.
4408         * infcall.c (run_inferior_call): Use std::move.
4409         (call_function_by_hand_dummy): Use std::move.
4410         * exec.c (try_open_exec_file): Use std::move.
4411         * exceptions.h (exception_print, exception_fprintf)
4412         (exception_print_same): Update.
4413         * exceptions.c (print_exception, exception_print)
4414         (exception_fprintf, exception_print_same): Change parameters to
4415         const reference.
4416         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4417         * common/new-op.c: Use std::move.
4418         * common/common-exceptions.h (struct gdb_exception): Add move
4419         constructor.
4420         (struct gdb_exception_error, struct gdb_exception_quit, struct
4421         gdb_quit_bad_alloc): Change constructor to move constructor.
4422         (throw_exception): Change parameter to rvalue reference.
4423         * common/common-exceptions.c (throw_exception): Take rvalue
4424         reference.
4425         * cli/cli-interp.c (safe_execute_command): Use std::move.
4426         * breakpoint.c (insert_bp_location, location_to_sals): Use
4427         std::move.
4428
4429 2019-04-25  Tom Tromey  <tromey@adacore.com>
4430
4431         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4432         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4433         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4434         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4435         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4436         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4437         guile/scm-value.c: Use unpack.
4438         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4439         gdbscm_gdb_exception.
4440         (gdbscm_throw_gdb_exception): Likewise.
4441         (struct gdbscm_gdb_exception): New.
4442         (unpack): New function.
4443         (gdbscm_wrap): Use unpack.
4444
4445 2019-04-25  Tom Tromey  <tromey@adacore.com>
4446
4447         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4448         (gdb_rl_callback_handler): Use std::move.
4449         * common/common-exceptions.h (struct gdb_exception): Add move
4450         assignment operator.
4451         (throw_exception_sjlj): Change "exception" to const reference.
4452         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4453         (throw_exception_sjlj): Change "exception" to const reference.
4454
4455 2019-04-25  Tom Tromey  <tromey@adacore.com>
4456
4457         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4458         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4459         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4460         Update.
4461         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4462         Update.
4463         * mi/mi-interp.c (mi_interp::exec): Update.
4464         * linespec.c (parse_linespec): Update.
4465         * infcall.c (run_inferior_call): Update.
4466         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4467         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4468         (gdbscm_lookup_global_symbol): Update.
4469         * guile/scm-param.c (gdbscm_parameter_value): Update.
4470         * guile/scm-frame.c (gdbscm_frame_read_register)
4471         (gdbscm_frame_read_var): Update.
4472         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4473         * exec.c (try_open_exec_file): Update.
4474         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4475         (gdb_rl_callback_handler): Update.
4476         * common/common-exceptions.h (exception_none): Don't declare.
4477         * common/common-exceptions.c (exception_none): Don't define.
4478         (struct catcher) <exception>: Update.
4479         * cli/cli-interp.c (safe_execute_command): Update.
4480         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4481
4482 2019-04-25  Ali Tamur  <tamur@google.com>
4483
4484         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4485         (read_attribute_value): Likewise.
4486         (dwarf2_read_addr_index): Update comment.
4487         (read_str_index): Add DW_FORM_strx.
4488         (dwarf2_string_attr): Likewise.
4489         (dwarf2_const_value_attr): Likewise.
4490         (dump_die_shallow): Likewise.
4491         (dwarf2_fetch_constant_bytes): Likewise.
4492         (skip_form_bytes): Likewise.
4493         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4494
4495 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4496
4497         PR corefiles/11608
4498         PR corefiles/18187
4499         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4500         OFFSET.  Verify if current mapping contains an ELF header.
4501         (linux_find_memory_regions_full): Adjust call to
4502         dump_mapping_p.
4503
4504 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4505             Kang Li <kanglictf@gmail.com>
4506
4507         PR gdb/21600
4508
4509         * dwarf2-frame.c (read_initial_length): Be consistent about using
4510         unsigned representation of length.
4511         (decode_frame_entry_1): Likewise.  Check for wraparound of
4512         end pointer as well as buffer overflow.
4513
4514 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4515
4516         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4517         "vq".
4518
4519 2019-04-24  Tom Tromey  <tromey@adacore.com>
4520
4521         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4522
4523 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4524
4525         * s12z-tdep.c (s12z_unwind_pc): Delete.
4526         (s12z_unwind_sp): Delete.
4527         (s12z_gdbarch_init): Don't register deleted functions with
4528         gdbarch.
4529
4530 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4531
4532         * rl78-tdep.c (rl78_unwind_sp): Delete.
4533         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4534
4535 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4536
4537         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4538         (xstormy16_unwind_pc): Delete.
4539         (xstormy16_dummy_id): Delete.
4540         (xstormy16_gdbarch_init): Don't register deleted functions with
4541         gdbarch.
4542
4543 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4544
4545         * vax-tdep.c (vax_unwind_pc): Delete.
4546         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4547
4548 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4549
4550         * v850-tdep.c (v850_unwind_sp): Delete.
4551         (v850_unwind_pc): Delete.
4552         (v850_dummy_id): Delete.
4553         (v850_gdbarch_init): Don't register deleted functions with
4554         gdbarch.
4555
4556 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4557
4558         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4559         (tilegx_unwind_pc): Delete.
4560         (tilegx_unwind_dummy_id): Delete.
4561         (tilegx_gdbarch_init): Don't register deleted functions with
4562         gdbarch.
4563
4564 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4565
4566         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4567         (tic6x_dummy_id): Delete.
4568         (tic6x_gdbarch_init): Don't register deleted functions with
4569         gdbarch.
4570
4571 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4572
4573         * sparc-tdep.c (sparc_unwind_pc): Delete.
4574         (sparc32_gdbarch_init): Don't register deleted function with
4575         gdbarch.
4576
4577 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4578
4579         * sh-tdep.c (sh_unwind_sp): Delete.
4580         (sh_unwind_pc): Delete.
4581         (sh_dummy_id): Delete.
4582         (sh_gdbarch_init): Don't register deleted functions with
4583         gdbarch.
4584
4585 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4586
4587         * score-tdep.c (score_unwind_sp): Delete.
4588         (score_unwind_pc): Delete.
4589         (score_dummy_id): Delete.
4590         (score_gdbarch_init): Don't register deleted functions with
4591         gdbarch.
4592
4593 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4594
4595         * rx-tdep.c (rx_unwind_pc): Delete.
4596         (rx_unwind_sp): Delete.
4597         (rx_dummy_id): Delete.
4598         (rx_gdbarch_init): Don't register deleted functions with
4599         gdbarch.  Update comment.
4600
4601 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4602
4603         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4604         (rs6000_dummy_id): Delete.
4605         (rs6000_gdbarch_init): Don't register deleted functions with
4606         gdbarch.
4607
4608 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4609
4610         * or1k-tdep.c (or1k_dummy_id): Delete.
4611         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4612
4613 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4614
4615         * nios2-tdep.c (nios2_dummy_id): Delete.
4616         (nios2_unwind_sp): Delete.
4617         (nios2_gdbarch_init): Don't register deleted functions with
4618         gdbarch.
4619
4620 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4621
4622         * nds32-tdep.c (nds32_dummy_id): Delete.
4623         (nds32_unwind_pc): Delete.
4624         (nds32_unwind_sp): Delete.
4625         (nds32_gdbarch_init): Don't register deleted functions with
4626         gdbarch.
4627
4628 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4629
4630         * msp430-tdep.c (msp430_unwind_pc): Delete.
4631         (msp430_unwind_sp): Delete.
4632         (msp430_dummy_id): Delete.
4633         (msp430_gdbarch_init): Don't register deleted functions with
4634         gdbarch.
4635
4636 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4637
4638         * moxie-tdep.c (moxie_unwind_sp): Delete.
4639         (moxie_unwind_pc): Delete.
4640         (moxie_dummy_id): Delete.
4641         (moxie_gdbarch_init): Don't register deleted functions with
4642         gdbarch.
4643
4644 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4645
4646         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4647         (mn10300_unwind_pc): Delete.
4648         (mn10300_unwind_sp): Delete.
4649         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4650         mn10300_unwind_sp.
4651         (mn10300_frame_unwind_init): Don't register deleted functions with
4652         gdbarch.
4653
4654 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4655
4656         * mep-tdep.c (mep_unwind_pc): Delete.
4657         (mep_unwind_sp): Delete.
4658         (mep_dummy_id): Delete.
4659         (mep_gdbarch_init): Don't register deleted functions with
4660         gdbarch.
4661
4662 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4663
4664         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4665         (m68hc11_unwind_sp): Delete.
4666         (m68hc11_gdbarch_init): Don't register deleted functions with
4667         gdbarch.
4668
4669 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4670
4671         * m32r-tdep.c (m32r_unwind_sp): Delete.
4672         (m32r_unwind_pc): Delete.
4673         (m32r_dummy_id): Delete.
4674         (m32r_gdbarch_init): Don't register deleted functions with
4675         gdbarch.
4676
4677 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4678
4679         * m32c-tdep.c (m32c_unwind_pc): Delete.
4680         (m32c_unwind_sp): Delete.
4681         (m32c_dummy_id): Delete.
4682         (m32c_gdbarch_init): Don't register deleted functions with
4683         gdbarch.
4684
4685 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4686
4687         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4688         (lm32_unwind_pc): Delete.
4689         (lm32_dummy_id): Delete.
4690         (lm32_gdbarch_init): Don't register deleted functions with
4691         gdbarch.
4692
4693 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4694
4695         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4696         (iq2000_unwind_pc): Delete.
4697         (iq2000_dummy_id): Delete.
4698         (iq2000_gdbarch_init): Don't register deleted functions with
4699         gdbarch.
4700
4701 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4702
4703         * nds32-tdep.c (nds32_type_align): Delete.
4704         (nds32_push_dummy_call): Use type_align instead.
4705
4706 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4707
4708         * arm-tdep.c (arm_type_align): Only handle vector override case.
4709         (arm_push_dummy_call): Use type_align.
4710         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4711
4712 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4713
4714         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4715         case.
4716         (pass_on_stack): Use type_align.
4717         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4718         function.
4719
4720 2019-04-23  Tom Tromey  <tromey@adacore.com>
4721
4722         * dwarf2read.c (line_header::file_name_at): Remove unused
4723         overload.
4724
4725 2019-04-23  Tom de Vries  <tdevries@suse.de>
4726
4727         PR gdb/24438
4728         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4729         invocation.
4730
4731
4732 2019-03-27  Ali Tamur  <tamur@google.com>
4733
4734         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4735         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4736         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4737         (dwarf_expr_context::get_addr_index): Likewise
4738         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4739         (symbol_needs_eval_context::get_addr_index): Likewise
4740         (disassemble_dwarf_expression): Add DW_OP_addrx
4741         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4742         (read_cutu_die_from_dwo): Update comment
4743         (skip_one_die): Add DW_FORM_addrx
4744         (read_attribute_value): Likewise
4745         (var_decode_location): Add DW_OP_addrx
4746         (dwarf2_const_value_attr): Add DW_FORM_addrx
4747         (dump_die_shallow): Likewise
4748         (dwarf2_fetch_constant_bytes): Likewise
4749         (decode_locdesc): Add DW_OP_addrx
4750         (skip_form_bytes): Add DW_FORM_addrx
4751
4752 2019-04-22  Ali Tamur  <tamur@google.com>
4753
4754         * MAINTAINERS (Write After Approval): Add self.
4755
4756 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4757
4758         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4759         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4760         (open_symbol_file_object): Likewise.
4761         (svr4_default_sos): Add info parameter.
4762         (svr4_read_so_list): Likewise.
4763         (svr4_current_sos_direct): Adjust functions calls to pass down
4764         info.
4765         (svr4_current_sos_1): Add info parameter.
4766         (svr4_current_sos): Call get_svr4_info, pass info down to
4767         svr4_current_sos_1.
4768         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4769         get_svr4_info.
4770         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4771         get_svr4_info.
4772         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4773         to get_svr4_info.
4774         (probes_table_remove_objfile_probes): Likewise.
4775         (register_solib_event_probe): Add info parameter.
4776         (solist_update_incremental): Pass info parameter down to
4777         svr4_read_so_list.
4778         (disable_probes_interface): Add info parameter.
4779         (svr4_handle_solib_event): Pass current_program_space to
4780         get_svr4_info.  Adjust disable_probes_interface cleanup.
4781         (svr4_create_probe_breakpoints): Add info parameter, pass it
4782         down to register_solib_event_probe.
4783         (svr4_create_solib_event_breakpoints): Add info parameter,
4784         pass it down to svr4_create_probe_breakpoints.
4785         (enable_break): Pass info down to
4786         svr4_create_solib_event_breakpoints.
4787         (svr4_solib_create_inferior_hook): Pass current_program_space to
4788         get_svr4_info.
4789         (svr4_clear_solib): Likewise.
4790
4791 2019-04-22  Pedro Alves  <palves@redhat.com>
4792
4793         * solib-svr4.c (svr4_free_objfile_observer): New.
4794         (probe_and_action::objfile): New field.
4795         (probes_table_htab_remove_objfile_probes)
4796         (probes_table_remove_objfile_probes): New functions.
4797         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4798         in the new probe_and_action.  Don't store the probe in 'lookup'.
4799         (svr4_create_probe_breakpoints): Pass objfile to
4800         register_solib_event_probe.
4801         (_initialize_svr4_solib): Register a free_objfile observer.
4802
4803 2019-04-19  Tom Tromey  <tom@tromey.com>
4804
4805         * common/queue.h: Remove.
4806
4807 2019-04-19  Tom Tromey  <tom@tromey.com>
4808
4809         * event-loop.c: Don't include "common/queue.h".
4810
4811 2019-04-19  Tom Tromey  <tom@tromey.com>
4812
4813         * remote.c (remote_target): Use delete.
4814         * remote-notif.h: Include <list>, not "common/queue.h".
4815         (notif_client_p): Remove typedef.
4816         (remote_notif_state): Add constructor, destructor, initializer.
4817         <notif_queue>: Now a std::list.
4818         (remote_notif_state_xfree): Don't declare.
4819         * remote-notif.c (remote_notif_process, handle_notification)
4820         (remote_notif_state_allocate): Update.
4821         (~remote_notif_state): Rename from remote_notif_state_xfree.
4822
4823 2019-04-19  Tom Tromey  <tom@tromey.com>
4824
4825         * symfile.c (reread_symbols): Update.
4826         * objfiles.c (objfile_register_static_link)
4827         (objfile_lookup_static_link): Update
4828         (~objfile) Don't delete static_links.
4829         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4830
4831 2019-04-19  Tom Tromey  <tom@tromey.com>
4832
4833         * type-stack.h (struct type_stack) <insert>: Constify string.
4834         * type-stack.c (type_stack::insert): Constify string.
4835         * gdbtypes.h (lookup_template_type): Update.
4836         (address_space_name_to_int): Update.
4837         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4838         const.
4839         (lookup_template_type): Make name const.
4840         * c-exp.y: Update rules.
4841         (lex_one_token, classify_name, classify_inner_name)
4842         (c_print_token): Update.
4843         * p-exp.y: Update rules.
4844         (yylex): Update.
4845         * f-exp.y: Update rules.
4846         (yylex): Update.
4847         * d-exp.y: Update rules.
4848         (lex_one_token, classify_name, classify_inner_name): Update.
4849         * parse.c (write_dollar_variable, copy_name): Return std::string.
4850         * parser-defs.h (copy_name): Change return type.
4851         * m2-exp.y: Update rules.
4852         (yylex): Update.
4853         * go-exp.y (lex_one_token): Update.
4854         Update rules.
4855         (classify_unsafe_function, classify_packaged_name)
4856         (classify_name, yylex): Update.
4857
4858 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4859
4860         * configure.ac: add --enable-source-highlight switch.
4861         * configure: Regenerate.
4862         * top.c (print_gdb_version): plumb --enable-source-highlight
4863         status to "show configuration".
4864
4865 2019-04-19  Tom Tromey  <tromey@adacore.com>
4866
4867         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4868         Check ADA_TYPE_P.
4869         (empty_record, ada_template_to_fixed_record_type_1)
4870         (template_to_static_fixed_type)
4871         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4872         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4873         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4874         macros.
4875
4876 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4877
4878         PR symtab/24423:
4879         * source.c (print_source_lines_base): Advance "iter" when a
4880         control character is seen.
4881
4882 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4883
4884         * inferior.h (struct infcall_suspend_state_deleter):
4885         Catch exception in destructor to avoid crash.
4886
4887 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4888
4889         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4890         close to the add_com "shell".
4891
4892 2019-04-18  Tom Tromey  <tromey@adacore.com>
4893
4894         * process-stratum-target.h (class process_stratum_target)
4895         <stratum>: Add "final".
4896
4897 2019-04-17  Tom Tromey  <tromey@adacore.com>
4898
4899         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4900         against nullptr before use.
4901
4902 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4903
4904         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4905
4906 2019-04-17  Jim Wilson  <jimw@sifive.com>
4907             Andrew Burgess  <andrew.burgess@embecosm.com>
4908
4909         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4910         code read might fail, assume 4-byte breakpoint in that case.
4911
4912 2019-04-15  Leszek Swirski  <leszeks@google.com>
4913
4914         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4915         rather than a hand-rolled POD check when checking for forced MEMORY
4916         classification.
4917
4918 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4919
4920         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4921         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4922         function.
4923         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4924         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4925         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4926         declaration.
4927
4928 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4929
4930         * aarch64-linux-nat.c
4931         (aarch64_linux_nat_target::thread_architecture): Add override.
4932         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4933         each VQ.
4934
4935 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4936
4937         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4938
4939 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4940
4941         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4942         target types of size 96-bits, add some additional comments, and
4943         check that the builtin type we found was the correct size.
4944
4945 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4946
4947         * utils.c (prompt_for_continue): Don't restore the styling at the
4948         end, as applied_style has the wrong value.  This fixes styling in
4949         long lists of file names that are interrupted by the "Continue?"
4950         prompt.
4951
4952 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4953
4954         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4955         * c-lang.c (c_language_defn): Likewise.
4956         (cplus_language_defn): Likewise.
4957         (asm_language_defn): Likewise.
4958         (minimal_language_defn): Likewise.
4959         * d-lang.c (d_language_defn): Likewise.
4960         * f-lang.c (f_language_defn): Likewise.
4961         * go-lang.c (go_language_defn): Likewise.
4962         * language.c (unknown_language_defn): Likewise.
4963         (auto_language_defn): Likewise.
4964         * language.h (struct language_defn): Remove la_magic field.
4965         (LANG_MAGIC): Delete.
4966         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4967         * objc-lang.c (objc_language_defn): Likewise.
4968         * opencl-lang.c (opencl_language_defn): Likewise.
4969         * p-lang.c (pascal_language_defn): Likewise.
4970         * rust-lang.c (rust_language_defn): Likewise.
4971
4972 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4973
4974         * riscv-tdep.c (riscv_type_align): New function.
4975         (riscv_type_alignment): Delete.
4976         (riscv_arg_location): Use 'type_align'.
4977         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4978
4979 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4980
4981         * gdbtypes.c (type_align): A struct with no non-static fields also
4982         has alignment of 1.
4983
4984 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4985
4986         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4987         component to 0.
4988         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4989         member.
4990         (riscv_struct_info::analyse): New implementation using new
4991         analyse_inner member function.
4992         (riscv_struct_info::field_offset): New member function.
4993         (riscv_struct_info::m_offsets): New member variable.
4994         (riscv_struct_info::analyse_inner): New private member function,
4995         takes the old implementation of riscv_struct_info::analyse but
4996         extended to track field offsets.
4997         (riscv_call_arg_struct): Update the struct folding special cases
4998         to handle cases where empty C++ structs, which are non-zero
4999         length, are found.
5000         (riscv_arg_location): Initialise the length of each location, a
5001         non-zero length now indicates the location is in use.
5002         (riscv_push_dummy_call): Allow for the first location having a
5003         non-zero offset when setting up arguments.
5004         (riscv_return_value): Likewise, but for return values.
5005
5006 2019-04-11  Tom Tromey  <tromey@adacore.com>
5007
5008         * utils.c (internal_vproblem): Make "msg" const.
5009
5010 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5011
5012         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5013         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5014         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5015         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5016
5017 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5018
5019         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5020         function.
5021         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5022         of amd64_collect_native_gregset.
5023         (amd64_linux_nat_target::store_registers): Likewise.
5024
5025 2019-04-10  Tom Tromey  <tom@tromey.com>
5026
5027         * symtab.c (lookup_global_symbol_from_objfile)
5028         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5029         * objfiles.h (class separate_debug_iterator): New.
5030         (class separate_debug_range): New.
5031         (struct objfile) <separate_debug_objfiles>: New method.
5032         (objfile_separate_debug_iterate): Don't declare.
5033         * objfiles.c (separate_debug_iterator::operator++): Rename from
5034         objfile_separate_debug_iterate.
5035         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5036         iterator.
5037         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5038         iterator.
5039
5040 2019-04-10  Tom Tromey  <tom@tromey.com>
5041
5042         * symfile.c (reread_symbols): Remove old comment.
5043         * objfiles.c (free_all_objfiles): Fix a typo.
5044
5045 2019-04-10  Tom Tromey  <tom@tromey.com>
5046
5047         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5048         * minsyms.c (lookup_minimal_symbol): Use foreach.
5049         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5050         (lookup_minimal_symbol_solib_trampoline): Likewise.
5051         * symfile.c (reread_symbols): Use foreach.
5052
5053 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5054             Tom Tromey  <tromey@adacore.com>
5055
5056         PR rust/24414:
5057         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5058         (rust_lex_int_test): Change "value" to be LONGEST.
5059         (rust_lex_tests): Add test for long integer literal.
5060
5061 2019-04-09  Tom Tromey  <tromey@adacore.com>
5062
5063         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5064         to bool.
5065         (extended_remote_target::attach): Update.
5066         (remote_target::remote_notice_new_inferior): Update.
5067         (remote_target::add_current_inferior_and_thread): Update.
5068         * inferior.c (exit_inferior_1): Use "false".
5069         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5070
5071 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5072
5073         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5074         the "start" command.
5075
5076 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5077
5078         * python/py-inferior.c (infpy_thread_from_thread_handle):
5079         Adjust comments to reflect renaming of thread_from_thread_handle
5080         to thread_from_handle.  Adjust keywords.  Fix type error message.
5081         (inferior_object_methods): Add thread_from_handle.  Retain
5082         thread_from_thread_handle, but mark it as deprecated.
5083
5084 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5085
5086         * gdbthread.h (find_thread_by_handle): Revise declaration.
5087         * thread.c (find_thread_by_handle): Likewise.  Adjust
5088         implementation too.
5089         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5090         support for buffer objects as handles.
5091
5092 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5093
5094         * python/py-infthread.c (thpy_thread_handle): New function.
5095         (thread_object_methods): Register thpy_thread_handle.
5096
5097 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5098
5099         * gdbthread.h (thread_to_thread_handle): Declare.
5100         * thread.c (gdbtypes.h): Include.
5101         (thread_to_thread_handle): New function.
5102
5103         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5104         (target_thread_info_to_thread_handle): Declare.
5105         * target.c (target_thread_info_to_thread_handle): New function.
5106         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5107         * target-delegates.c: Regenerate.
5108
5109         * linux-thread-db.c (class thread_db_target): Add method
5110         thread_info_to_thread_handle.
5111         (thread_db_target::thread_info_to_thread_handle): Define.
5112         * remote.c (class remote_target): Add new method
5113         thread_info_to_thread_handle.
5114         (remote_target::thread_info_to_thread_handle): Define.
5115
5116 2019-04-08  Pedro Alves  <palves@redhat.com>
5117
5118         * common/common-exceptions.c (throw_exception): Don't create
5119         named object to throw; throw directly.
5120         (throw_it): Likewise.  Don't initialize gdb_exception::message
5121         here, with new; pass FMT and AP to the ctor instead.
5122         * common/common-exceptions.h: Include <string>.
5123         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5124         const char *, va_list)): New ctor.  Use std::make_shared.
5125         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5126         errors)): Delete.
5127         (gdb_exception_error::gdb_exception_error(enum errors, const char
5128         *, va_list)): New.
5129         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5130         Add assertion.
5131         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5132         errors)): Delete.
5133         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5134         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5135         Add assertion.
5136
5137 2019-04-08  Tom Tromey  <tom@tromey.com>
5138
5139         * valops.c (value_rtti_indirect_type): Replace throw_exception
5140         with throw.
5141         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5142         with throw.
5143         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5144         throw.
5145         * target.c (target_translate_tls_address): Replace throw_exception
5146         with throw.
5147         * stack.c (frame_apply_command_count): Replace throw_exception
5148         with throw.
5149         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5150         throw.
5151         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5152         with throw.
5153         * rs6000-tdep.c (rs6000_frame_cache)
5154         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5155         * remote.c: Replace throw_exception with throw.
5156         * record-full.c (record_full_message, record_full_wait_1)
5157         (record_full_restore): Replace throw_exception with throw.
5158         * record-btrace.c:
5159         (get_thread_current_frame_id, record_btrace_start_replaying)
5160         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5161         (cmd_record_btrace_start): Replace throw_exception with throw.
5162         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5163         throw.
5164         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5165         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5166         * linespec.c:
5167         (find_linespec_symbols): Replace throw_exception with throw.
5168         * infrun.c (displaced_step_prepare, resume): Replace
5169         throw_exception with throw.
5170         * infcmd.c (post_create_inferior): Replace throw_exception with
5171         throw.
5172         * inf-loop.c (inferior_event_handler): Replace throw_exception
5173         with throw.
5174         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5175         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5176         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5177         (get_prev_frame_always, get_frame_pc_if_available)
5178         (get_frame_address_in_block_if_available, get_frame_language):
5179         Replace throw_exception with throw.
5180         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5181         throw_exception with throw.
5182         * eval.c (fetch_subexp_value, evaluate_var_value)
5183         (evaluate_funcall, evaluate_subexp_standard): Replace
5184         throw_exception with throw.
5185         * dwarf2loc.c (call_site_find_chain)
5186         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5187         Replace throw_exception with throw.
5188         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5189         with throw.
5190         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5191         throw.
5192         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5193         * completer.c (complete_line_internal): Replace throw_exception
5194         with throw.
5195         * compile/compile-object-run.c (compile_object_run): Replace
5196         throw_exception with throw.
5197         * cli/cli-script.c (process_next_line): Replace throw_exception
5198         with throw.
5199         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5200         (btrace_enable, btrace_maint_update_pt_packets): Replace
5201         throw_exception with throw.
5202         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5203         throw_exception with throw.
5204         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5205         throw_exception with throw.
5206         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5207         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5208         * aarch64-tdep.c (aarch64_make_prologue_cache)
5209         (aarch64_make_stub_cache): Replace throw_exception with throw.
5210
5211 2019-04-08  Tom Tromey  <tom@tromey.com>
5212
5213         * common/common-exceptions.c (throw_exception): Rename from
5214         throw_exception_cxx.  Remove old copy.  Make argument const.
5215         (throw_it): Create and throw exception objects directly.
5216         * common/common-exceptions.h (throw_exception): Make argument
5217         const.
5218         (struct gdb_exception_error): Add constructor.
5219         (struct gdb_exception_quit): Add constructor.
5220
5221 2019-04-08  Tom Tromey  <tom@tromey.com>
5222
5223         * common/common-exceptions.h (exception_rethrow): Don't declare.
5224         (TRY_SJLJ): Update comment.
5225         (TRY, CATCH, END_CATCH): Remove.
5226         * common/common-exceptions.c (exception_rethrow): Remove.
5227
5228 2019-04-08  Tom Tromey  <tom@tromey.com>
5229
5230         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5231         Remove.
5232         (gdb_exception_error): Rename from
5233         gdb_exception_RETURN_MASK_ERROR.
5234         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5235         (gdb_quit_bad_alloc): Update.
5236         * aarch64-tdep.c: Update.
5237         * ada-lang.c: Update.
5238         * ada-typeprint.c: Update.
5239         * ada-valprint.c: Update.
5240         * amd64-tdep.c: Update.
5241         * arch-utils.c: Update.
5242         * break-catch-throw.c: Update.
5243         * breakpoint.c: Update.
5244         * btrace.c: Update.
5245         * c-varobj.c: Update.
5246         * cli/cli-cmds.c: Update.
5247         * cli/cli-interp.c: Update.
5248         * cli/cli-script.c: Update.
5249         * common/common-exceptions.c: Update.
5250         * common/new-op.c: Update.
5251         * common/selftest.c: Update.
5252         * compile/compile-c-symbols.c: Update.
5253         * compile/compile-cplus-symbols.c: Update.
5254         * compile/compile-object-load.c: Update.
5255         * compile/compile-object-run.c: Update.
5256         * completer.c: Update.
5257         * corelow.c: Update.
5258         * cp-abi.c: Update.
5259         * cp-support.c: Update.
5260         * cp-valprint.c: Update.
5261         * darwin-nat.c: Update.
5262         * disasm-selftests.c: Update.
5263         * dtrace-probe.c: Update.
5264         * dwarf-index-cache.c: Update.
5265         * dwarf-index-write.c: Update.
5266         * dwarf2-frame-tailcall.c: Update.
5267         * dwarf2-frame.c: Update.
5268         * dwarf2loc.c: Update.
5269         * dwarf2read.c: Update.
5270         * eval.c: Update.
5271         * event-loop.c: Update.
5272         * event-top.c: Update.
5273         * exec.c: Update.
5274         * f-valprint.c: Update.
5275         * fbsd-tdep.c: Update.
5276         * frame-unwind.c: Update.
5277         * frame.c: Update.
5278         * gdbtypes.c: Update.
5279         * gnu-v3-abi.c: Update.
5280         * guile/guile-internal.h: Update.
5281         * guile/scm-block.c: Update.
5282         * guile/scm-breakpoint.c: Update.
5283         * guile/scm-cmd.c: Update.
5284         * guile/scm-disasm.c: Update.
5285         * guile/scm-frame.c: Update.
5286         * guile/scm-lazy-string.c: Update.
5287         * guile/scm-math.c: Update.
5288         * guile/scm-param.c: Update.
5289         * guile/scm-ports.c: Update.
5290         * guile/scm-pretty-print.c: Update.
5291         * guile/scm-symbol.c: Update.
5292         * guile/scm-symtab.c: Update.
5293         * guile/scm-type.c: Update.
5294         * guile/scm-value.c: Update.
5295         * i386-linux-tdep.c: Update.
5296         * i386-tdep.c: Update.
5297         * inf-loop.c: Update.
5298         * infcall.c: Update.
5299         * infcmd.c: Update.
5300         * infrun.c: Update.
5301         * jit.c: Update.
5302         * language.c: Update.
5303         * linespec.c: Update.
5304         * linux-fork.c: Update.
5305         * linux-nat.c: Update.
5306         * linux-tdep.c: Update.
5307         * linux-thread-db.c: Update.
5308         * main.c: Update.
5309         * mi/mi-cmd-break.c: Update.
5310         * mi/mi-cmd-stack.c: Update.
5311         * mi/mi-interp.c: Update.
5312         * mi/mi-main.c: Update.
5313         * objc-lang.c: Update.
5314         * p-valprint.c: Update.
5315         * parse.c: Update.
5316         * ppc-linux-tdep.c: Update.
5317         * printcmd.c: Update.
5318         * python/py-arch.c: Update.
5319         * python/py-breakpoint.c: Update.
5320         * python/py-cmd.c: Update.
5321         * python/py-finishbreakpoint.c: Update.
5322         * python/py-frame.c: Update.
5323         * python/py-framefilter.c: Update.
5324         * python/py-gdb-readline.c: Update.
5325         * python/py-inferior.c: Update.
5326         * python/py-infthread.c: Update.
5327         * python/py-lazy-string.c: Update.
5328         * python/py-linetable.c: Update.
5329         * python/py-objfile.c: Update.
5330         * python/py-param.c: Update.
5331         * python/py-prettyprint.c: Update.
5332         * python/py-progspace.c: Update.
5333         * python/py-record-btrace.c: Update.
5334         * python/py-record.c: Update.
5335         * python/py-symbol.c: Update.
5336         * python/py-type.c: Update.
5337         * python/py-unwind.c: Update.
5338         * python/py-utils.c: Update.
5339         * python/py-value.c: Update.
5340         * python/python.c: Update.
5341         * record-btrace.c: Update.
5342         * record-full.c: Update.
5343         * remote-fileio.c: Update.
5344         * remote.c: Update.
5345         * riscv-tdep.c: Update.
5346         * rs6000-aix-tdep.c: Update.
5347         * rs6000-tdep.c: Update.
5348         * rust-exp.y: Update.
5349         * rust-lang.c: Update.
5350         * s390-tdep.c: Update.
5351         * selftest-arch.c: Update.
5352         * solib-dsbt.c: Update.
5353         * solib-frv.c: Update.
5354         * solib-spu.c: Update.
5355         * solib-svr4.c: Update.
5356         * solib.c: Update.
5357         * sparc64-linux-tdep.c: Update.
5358         * stack.c: Update.
5359         * symfile-mem.c: Update.
5360         * symmisc.c: Update.
5361         * target.c: Update.
5362         * thread.c: Update.
5363         * top.c: Update.
5364         * tracefile-tfile.c: Update.
5365         * tui/tui.c: Update.
5366         * typeprint.c: Update.
5367         * unittests/cli-utils-selftests.c: Update.
5368         * unittests/parse-connection-spec-selftests.c: Update.
5369         * valops.c: Update.
5370         * valprint.c: Update.
5371         * value.c: Update.
5372         * varobj.c: Update.
5373         * windows-nat.c: Update.
5374         * x86-linux-nat.c: Update.
5375         * xml-support.c: Update.
5376
5377 2019-04-08  Tom Tromey  <tom@tromey.com>
5378
5379         * xml-support.c: Use C++ exception handling.
5380         * x86-linux-nat.c: Use C++ exception handling.
5381         * windows-nat.c: Use C++ exception handling.
5382         * varobj.c: Use C++ exception handling.
5383         * value.c: Use C++ exception handling.
5384         * valprint.c: Use C++ exception handling.
5385         * valops.c: Use C++ exception handling.
5386         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5387         handling.
5388         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5389         * typeprint.c: Use C++ exception handling.
5390         * tui/tui.c: Use C++ exception handling.
5391         * tracefile-tfile.c: Use C++ exception handling.
5392         * top.c: Use C++ exception handling.
5393         * thread.c: Use C++ exception handling.
5394         * target.c: Use C++ exception handling.
5395         * symmisc.c: Use C++ exception handling.
5396         * symfile-mem.c: Use C++ exception handling.
5397         * stack.c: Use C++ exception handling.
5398         * sparc64-linux-tdep.c: Use C++ exception handling.
5399         * solib.c: Use C++ exception handling.
5400         * solib-svr4.c: Use C++ exception handling.
5401         * solib-spu.c: Use C++ exception handling.
5402         * solib-frv.c: Use C++ exception handling.
5403         * solib-dsbt.c: Use C++ exception handling.
5404         * selftest-arch.c: Use C++ exception handling.
5405         * s390-tdep.c: Use C++ exception handling.
5406         * rust-lang.c: Use C++ exception handling.
5407         * rust-exp.y: Use C++ exception handling.
5408         * rs6000-tdep.c: Use C++ exception handling.
5409         * rs6000-aix-tdep.c: Use C++ exception handling.
5410         * riscv-tdep.c: Use C++ exception handling.
5411         * remote.c: Use C++ exception handling.
5412         * remote-fileio.c: Use C++ exception handling.
5413         * record-full.c: Use C++ exception handling.
5414         * record-btrace.c: Use C++ exception handling.
5415         * python/python.c: Use C++ exception handling.
5416         * python/py-value.c: Use C++ exception handling.
5417         * python/py-utils.c: Use C++ exception handling.
5418         * python/py-unwind.c: Use C++ exception handling.
5419         * python/py-type.c: Use C++ exception handling.
5420         * python/py-symbol.c: Use C++ exception handling.
5421         * python/py-record.c: Use C++ exception handling.
5422         * python/py-record-btrace.c: Use C++ exception handling.
5423         * python/py-progspace.c: Use C++ exception handling.
5424         * python/py-prettyprint.c: Use C++ exception handling.
5425         * python/py-param.c: Use C++ exception handling.
5426         * python/py-objfile.c: Use C++ exception handling.
5427         * python/py-linetable.c: Use C++ exception handling.
5428         * python/py-lazy-string.c: Use C++ exception handling.
5429         * python/py-infthread.c: Use C++ exception handling.
5430         * python/py-inferior.c: Use C++ exception handling.
5431         * python/py-gdb-readline.c: Use C++ exception handling.
5432         * python/py-framefilter.c: Use C++ exception handling.
5433         * python/py-frame.c: Use C++ exception handling.
5434         * python/py-finishbreakpoint.c: Use C++ exception handling.
5435         * python/py-cmd.c: Use C++ exception handling.
5436         * python/py-breakpoint.c: Use C++ exception handling.
5437         * python/py-arch.c: Use C++ exception handling.
5438         * printcmd.c: Use C++ exception handling.
5439         * ppc-linux-tdep.c: Use C++ exception handling.
5440         * parse.c: Use C++ exception handling.
5441         * p-valprint.c: Use C++ exception handling.
5442         * objc-lang.c: Use C++ exception handling.
5443         * mi/mi-main.c: Use C++ exception handling.
5444         * mi/mi-interp.c: Use C++ exception handling.
5445         * mi/mi-cmd-stack.c: Use C++ exception handling.
5446         * mi/mi-cmd-break.c: Use C++ exception handling.
5447         * main.c: Use C++ exception handling.
5448         * linux-thread-db.c: Use C++ exception handling.
5449         * linux-tdep.c: Use C++ exception handling.
5450         * linux-nat.c: Use C++ exception handling.
5451         * linux-fork.c: Use C++ exception handling.
5452         * linespec.c: Use C++ exception handling.
5453         * language.c: Use C++ exception handling.
5454         * jit.c: Use C++ exception handling.
5455         * infrun.c: Use C++ exception handling.
5456         * infcmd.c: Use C++ exception handling.
5457         * infcall.c: Use C++ exception handling.
5458         * inf-loop.c: Use C++ exception handling.
5459         * i386-tdep.c: Use C++ exception handling.
5460         * i386-linux-tdep.c: Use C++ exception handling.
5461         * guile/scm-value.c: Use C++ exception handling.
5462         * guile/scm-type.c: Use C++ exception handling.
5463         * guile/scm-symtab.c: Use C++ exception handling.
5464         * guile/scm-symbol.c: Use C++ exception handling.
5465         * guile/scm-pretty-print.c: Use C++ exception handling.
5466         * guile/scm-ports.c: Use C++ exception handling.
5467         * guile/scm-param.c: Use C++ exception handling.
5468         * guile/scm-math.c: Use C++ exception handling.
5469         * guile/scm-lazy-string.c: Use C++ exception handling.
5470         * guile/scm-frame.c: Use C++ exception handling.
5471         * guile/scm-disasm.c: Use C++ exception handling.
5472         * guile/scm-cmd.c: Use C++ exception handling.
5473         * guile/scm-breakpoint.c: Use C++ exception handling.
5474         * guile/scm-block.c: Use C++ exception handling.
5475         * guile/guile-internal.h: Use C++ exception handling.
5476         * gnu-v3-abi.c: Use C++ exception handling.
5477         * gdbtypes.c: Use C++ exception handling.
5478         * frame.c: Use C++ exception handling.
5479         * frame-unwind.c: Use C++ exception handling.
5480         * fbsd-tdep.c: Use C++ exception handling.
5481         * f-valprint.c: Use C++ exception handling.
5482         * exec.c: Use C++ exception handling.
5483         * event-top.c: Use C++ exception handling.
5484         * event-loop.c: Use C++ exception handling.
5485         * eval.c: Use C++ exception handling.
5486         * dwarf2read.c: Use C++ exception handling.
5487         * dwarf2loc.c: Use C++ exception handling.
5488         * dwarf2-frame.c: Use C++ exception handling.
5489         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5490         * dwarf-index-write.c: Use C++ exception handling.
5491         * dwarf-index-cache.c: Use C++ exception handling.
5492         * dtrace-probe.c: Use C++ exception handling.
5493         * disasm-selftests.c: Use C++ exception handling.
5494         * darwin-nat.c: Use C++ exception handling.
5495         * cp-valprint.c: Use C++ exception handling.
5496         * cp-support.c: Use C++ exception handling.
5497         * cp-abi.c: Use C++ exception handling.
5498         * corelow.c: Use C++ exception handling.
5499         * completer.c: Use C++ exception handling.
5500         * compile/compile-object-run.c: Use C++ exception handling.
5501         * compile/compile-object-load.c: Use C++ exception handling.
5502         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5503         * compile/compile-c-symbols.c: Use C++ exception handling.
5504         * common/selftest.c: Use C++ exception handling.
5505         * common/new-op.c: Use C++ exception handling.
5506         * cli/cli-script.c: Use C++ exception handling.
5507         * cli/cli-interp.c: Use C++ exception handling.
5508         * cli/cli-cmds.c: Use C++ exception handling.
5509         * c-varobj.c: Use C++ exception handling.
5510         * btrace.c: Use C++ exception handling.
5511         * breakpoint.c: Use C++ exception handling.
5512         * break-catch-throw.c: Use C++ exception handling.
5513         * arch-utils.c: Use C++ exception handling.
5514         * amd64-tdep.c: Use C++ exception handling.
5515         * ada-valprint.c: Use C++ exception handling.
5516         * ada-typeprint.c: Use C++ exception handling.
5517         * ada-lang.c: Use C++ exception handling.
5518         * aarch64-tdep.c: Use C++ exception handling.
5519
5520 2019-04-08  Tom Tromey  <tom@tromey.com>
5521
5522         * xml-support.c (gdb_xml_parser::parse): Update.
5523         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5524         * value.c (show_convenience): Update.
5525         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5526         (test_parse_flags_qcs): Update.
5527         * thread.c (thr_try_catch_cmd): Update.
5528         * target.c (target_translate_tls_address): Update.
5529         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5530         (info_frame_command_core, frame_apply_command_count): Update.
5531         * rust-exp.y (rust_lex_exception_test): Update.
5532         * riscv-tdep.c (riscv_print_one_register_info): Update.
5533         * remote.c (remote_target::enable_btrace): Update.
5534         * record-btrace.c (record_btrace_enable_warn): Update.
5535         * python/py-utils.c (gdbpy_convert_exception): Update.
5536         * printcmd.c (do_one_display, print_variable_and_value): Update.
5537         * mi/mi-main.c (mi_print_exception): Update.
5538         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5539         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5540         * linux-nat.c (linux_nat_target::attach): Update.
5541         * linux-fork.c (class scoped_switch_fork_info): Update.
5542         * infrun.c (displaced_step_prepare): Update.
5543         * infcall.c (call_function_by_hand_dummy): Update.
5544         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5545         * gnu-v3-abi.c (print_one_vtable): Update.
5546         * frame.c (get_prev_frame_always): Update.
5547         * f-valprint.c (info_common_command_for_block): Update.
5548         * exec.c (try_open_exec_file): Update.
5549         * exceptions.c (print_exception, exception_print)
5550         (exception_fprintf, exception_print_same): Update.
5551         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5552         * dwarf-index-cache.c (index_cache::store)
5553         (index_cache::lookup_gdb_index): Update.
5554         * darwin-nat.c (maybe_cache_shell): Update.
5555         * cp-valprint.c (cp_print_value_fields): Update.
5556         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5557         (gcc_cplus_symbol_address): Update.
5558         * compile/compile-c-symbols.c (gcc_convert_symbol)
5559         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5560         * common/selftest.c: Update.
5561         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5562         a std::string.
5563         (exception_try_scope_entry, exception_try_scope_exit): Don't
5564         declare.
5565         (struct exception_try_scope): Remove.
5566         (TRY): Don't use exception_try_scope.
5567         (struct gdb_exception): Add constructor, operator=.
5568         <what>: New method.
5569         (struct gdb_exception_RETURN_MASK_ALL)
5570         (struct gdb_exception_RETURN_MASK_ERROR)
5571         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5572         (struct gdb_quit_bad_alloc): Update.
5573         * common/common-exceptions.c (exception_none): Change
5574         initializer.
5575         (struct catcher) <state, exception>: Initialize inline.
5576         <prev>: Remove member.
5577         (current_catcher): Remove.
5578         (catchers): New global.
5579         (exceptions_state_mc_init): Simplify.
5580         (catcher_pop): Remove.
5581         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5582         (try_scope_depth, exception_try_scope_entry)
5583         (exception_try_scope_exit): Remove.
5584         (throw_exception_sjlj): Update.
5585         (exception_messages, exception_messages_size): Remove.
5586         (throw_it): Simplify.
5587         (gdb_exception_sliced_copy): Remove.
5588         (throw_exception_cxx): Update.
5589         * cli/cli-script.c (script_from_file): Update.
5590         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5591         Update.
5592         * ada-valprint.c (ada_val_print): Update.
5593         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5594         (create_excep_cond_exprs): Update.
5595
5596 2019-04-08  Tom Tromey  <tom@tromey.com>
5597
5598         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5599         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5600         (TRY, CATCH, END_CATCH): Remove some definitions.
5601         * common/common-exceptions.c: Don't use GDB_XCPT.
5602         (catcher_list_size): Remove.
5603         (throw_exception, throw_it): Simplify.
5604
5605 2019-04-05  Tom Tromey  <tom@tromey.com>
5606
5607         Revert the header-sorting patch.
5608         * ft32-tdep.c: Revert.
5609         * frv-tdep.c: Revert.
5610         * frv-linux-tdep.c: Revert.
5611         * frame.c: Revert.
5612         * frame-unwind.c: Revert.
5613         * frame-base.c: Revert.
5614         * fork-child.c: Revert.
5615         * findvar.c: Revert.
5616         * findcmd.c: Revert.
5617         * filesystem.c: Revert.
5618         * filename-seen-cache.h: Revert.
5619         * filename-seen-cache.c: Revert.
5620         * fbsd-tdep.c: Revert.
5621         * fbsd-nat.h: Revert.
5622         * fbsd-nat.c: Revert.
5623         * f-valprint.c: Revert.
5624         * f-typeprint.c: Revert.
5625         * f-lang.c: Revert.
5626         * extension.h: Revert.
5627         * extension.c: Revert.
5628         * extension-priv.h: Revert.
5629         * expprint.c: Revert.
5630         * exec.h: Revert.
5631         * exec.c: Revert.
5632         * exceptions.c: Revert.
5633         * event-top.c: Revert.
5634         * event-loop.c: Revert.
5635         * eval.c: Revert.
5636         * elfread.c: Revert.
5637         * dwarf2read.h: Revert.
5638         * dwarf2read.c: Revert.
5639         * dwarf2loc.c: Revert.
5640         * dwarf2expr.h: Revert.
5641         * dwarf2expr.c: Revert.
5642         * dwarf2-frame.c: Revert.
5643         * dwarf2-frame-tailcall.c: Revert.
5644         * dwarf-index-write.h: Revert.
5645         * dwarf-index-write.c: Revert.
5646         * dwarf-index-common.c: Revert.
5647         * dwarf-index-cache.h: Revert.
5648         * dwarf-index-cache.c: Revert.
5649         * dummy-frame.c: Revert.
5650         * dtrace-probe.c: Revert.
5651         * disasm.h: Revert.
5652         * disasm.c: Revert.
5653         * disasm-selftests.c: Revert.
5654         * dictionary.c: Revert.
5655         * dicos-tdep.c: Revert.
5656         * demangle.c: Revert.
5657         * dcache.h: Revert.
5658         * dcache.c: Revert.
5659         * darwin-nat.h: Revert.
5660         * darwin-nat.c: Revert.
5661         * darwin-nat-info.c: Revert.
5662         * d-valprint.c: Revert.
5663         * d-namespace.c: Revert.
5664         * d-lang.c: Revert.
5665         * ctf.c: Revert.
5666         * csky-tdep.c: Revert.
5667         * csky-linux-tdep.c: Revert.
5668         * cris-tdep.c: Revert.
5669         * cris-linux-tdep.c: Revert.
5670         * cp-valprint.c: Revert.
5671         * cp-support.c: Revert.
5672         * cp-namespace.c: Revert.
5673         * cp-abi.c: Revert.
5674         * corelow.c: Revert.
5675         * corefile.c: Revert.
5676         * continuations.c: Revert.
5677         * completer.h: Revert.
5678         * completer.c: Revert.
5679         * complaints.c: Revert.
5680         * coffread.c: Revert.
5681         * coff-pe-read.c: Revert.
5682         * cli-out.h: Revert.
5683         * cli-out.c: Revert.
5684         * charset.c: Revert.
5685         * c-varobj.c: Revert.
5686         * c-valprint.c: Revert.
5687         * c-typeprint.c: Revert.
5688         * c-lang.c: Revert.
5689         * buildsym.c: Revert.
5690         * buildsym-legacy.c: Revert.
5691         * build-id.h: Revert.
5692         * build-id.c: Revert.
5693         * btrace.c: Revert.
5694         * bsd-uthread.c: Revert.
5695         * breakpoint.h: Revert.
5696         * breakpoint.c: Revert.
5697         * break-catch-throw.c: Revert.
5698         * break-catch-syscall.c: Revert.
5699         * break-catch-sig.c: Revert.
5700         * blockframe.c: Revert.
5701         * block.c: Revert.
5702         * bfin-tdep.c: Revert.
5703         * bfin-linux-tdep.c: Revert.
5704         * bfd-target.c: Revert.
5705         * bcache.c: Revert.
5706         * ax-general.c: Revert.
5707         * ax-gdb.h: Revert.
5708         * ax-gdb.c: Revert.
5709         * avr-tdep.c: Revert.
5710         * auxv.c: Revert.
5711         * auto-load.c: Revert.
5712         * arm-wince-tdep.c: Revert.
5713         * arm-tdep.c: Revert.
5714         * arm-symbian-tdep.c: Revert.
5715         * arm-pikeos-tdep.c: Revert.
5716         * arm-obsd-tdep.c: Revert.
5717         * arm-nbsd-tdep.c: Revert.
5718         * arm-nbsd-nat.c: Revert.
5719         * arm-linux-tdep.c: Revert.
5720         * arm-linux-nat.c: Revert.
5721         * arm-fbsd-tdep.c: Revert.
5722         * arm-fbsd-nat.c: Revert.
5723         * arm-bsd-tdep.c: Revert.
5724         * arch-utils.c: Revert.
5725         * arc-tdep.c: Revert.
5726         * arc-newlib-tdep.c: Revert.
5727         * annotate.h: Revert.
5728         * annotate.c: Revert.
5729         * amd64-windows-tdep.c: Revert.
5730         * amd64-windows-nat.c: Revert.
5731         * amd64-tdep.c: Revert.
5732         * amd64-sol2-tdep.c: Revert.
5733         * amd64-obsd-tdep.c: Revert.
5734         * amd64-obsd-nat.c: Revert.
5735         * amd64-nbsd-tdep.c: Revert.
5736         * amd64-nbsd-nat.c: Revert.
5737         * amd64-nat.c: Revert.
5738         * amd64-linux-tdep.c: Revert.
5739         * amd64-linux-nat.c: Revert.
5740         * amd64-fbsd-tdep.c: Revert.
5741         * amd64-fbsd-nat.c: Revert.
5742         * amd64-dicos-tdep.c: Revert.
5743         * amd64-darwin-tdep.c: Revert.
5744         * amd64-bsd-nat.c: Revert.
5745         * alpha-tdep.c: Revert.
5746         * alpha-obsd-tdep.c: Revert.
5747         * alpha-nbsd-tdep.c: Revert.
5748         * alpha-mdebug-tdep.c: Revert.
5749         * alpha-linux-tdep.c: Revert.
5750         * alpha-linux-nat.c: Revert.
5751         * alpha-bsd-tdep.c: Revert.
5752         * alpha-bsd-nat.c: Revert.
5753         * aix-thread.c: Revert.
5754         * agent.c: Revert.
5755         * addrmap.c: Revert.
5756         * ada-varobj.c: Revert.
5757         * ada-valprint.c: Revert.
5758         * ada-typeprint.c: Revert.
5759         * ada-tasks.c: Revert.
5760         * ada-lang.c: Revert.
5761         * aarch64-tdep.c: Revert.
5762         * aarch64-ravenscar-thread.c: Revert.
5763         * aarch64-newlib-tdep.c: Revert.
5764         * aarch64-linux-tdep.c: Revert.
5765         * aarch64-linux-nat.c: Revert.
5766         * aarch64-fbsd-tdep.c: Revert.
5767         * aarch64-fbsd-nat.c: Revert.
5768         * aarch32-linux-nat.c: Revert.
5769
5770 2019-04-05  Tom Tromey  <tom@tromey.com>
5771
5772         * ft32-tdep.c: Sort headers.
5773         * frv-tdep.c: Sort headers.
5774         * frv-linux-tdep.c: Sort headers.
5775         * frame.c: Sort headers.
5776         * frame-unwind.c: Sort headers.
5777         * frame-base.c: Sort headers.
5778         * fork-child.c: Sort headers.
5779         * findvar.c: Sort headers.
5780         * findcmd.c: Sort headers.
5781         * filesystem.c: Sort headers.
5782         * filename-seen-cache.h: Sort headers.
5783         * filename-seen-cache.c: Sort headers.
5784         * fbsd-tdep.c: Sort headers.
5785         * fbsd-nat.h: Sort headers.
5786         * fbsd-nat.c: Sort headers.
5787         * f-valprint.c: Sort headers.
5788         * f-typeprint.c: Sort headers.
5789         * f-lang.c: Sort headers.
5790         * extension.h: Sort headers.
5791         * extension.c: Sort headers.
5792         * extension-priv.h: Sort headers.
5793         * expprint.c: Sort headers.
5794         * exec.h: Sort headers.
5795         * exec.c: Sort headers.
5796         * exceptions.c: Sort headers.
5797         * event-top.c: Sort headers.
5798         * event-loop.c: Sort headers.
5799         * eval.c: Sort headers.
5800         * elfread.c: Sort headers.
5801         * dwarf2read.h: Sort headers.
5802         * dwarf2read.c: Sort headers.
5803         * dwarf2loc.c: Sort headers.
5804         * dwarf2expr.h: Sort headers.
5805         * dwarf2expr.c: Sort headers.
5806         * dwarf2-frame.c: Sort headers.
5807         * dwarf2-frame-tailcall.c: Sort headers.
5808         * dwarf-index-write.h: Sort headers.
5809         * dwarf-index-write.c: Sort headers.
5810         * dwarf-index-common.c: Sort headers.
5811         * dwarf-index-cache.h: Sort headers.
5812         * dwarf-index-cache.c: Sort headers.
5813         * dummy-frame.c: Sort headers.
5814         * dtrace-probe.c: Sort headers.
5815         * disasm.h: Sort headers.
5816         * disasm.c: Sort headers.
5817         * disasm-selftests.c: Sort headers.
5818         * dictionary.c: Sort headers.
5819         * dicos-tdep.c: Sort headers.
5820         * demangle.c: Sort headers.
5821         * dcache.h: Sort headers.
5822         * dcache.c: Sort headers.
5823         * darwin-nat.h: Sort headers.
5824         * darwin-nat.c: Sort headers.
5825         * darwin-nat-info.c: Sort headers.
5826         * d-valprint.c: Sort headers.
5827         * d-namespace.c: Sort headers.
5828         * d-lang.c: Sort headers.
5829         * ctf.c: Sort headers.
5830         * csky-tdep.c: Sort headers.
5831         * csky-linux-tdep.c: Sort headers.
5832         * cris-tdep.c: Sort headers.
5833         * cris-linux-tdep.c: Sort headers.
5834         * cp-valprint.c: Sort headers.
5835         * cp-support.c: Sort headers.
5836         * cp-namespace.c: Sort headers.
5837         * cp-abi.c: Sort headers.
5838         * corelow.c: Sort headers.
5839         * corefile.c: Sort headers.
5840         * continuations.c: Sort headers.
5841         * completer.h: Sort headers.
5842         * completer.c: Sort headers.
5843         * complaints.c: Sort headers.
5844         * coffread.c: Sort headers.
5845         * coff-pe-read.c: Sort headers.
5846         * cli-out.h: Sort headers.
5847         * cli-out.c: Sort headers.
5848         * charset.c: Sort headers.
5849         * c-varobj.c: Sort headers.
5850         * c-valprint.c: Sort headers.
5851         * c-typeprint.c: Sort headers.
5852         * c-lang.c: Sort headers.
5853         * buildsym.c: Sort headers.
5854         * buildsym-legacy.c: Sort headers.
5855         * build-id.h: Sort headers.
5856         * build-id.c: Sort headers.
5857         * btrace.c: Sort headers.
5858         * bsd-uthread.c: Sort headers.
5859         * breakpoint.h: Sort headers.
5860         * breakpoint.c: Sort headers.
5861         * break-catch-throw.c: Sort headers.
5862         * break-catch-syscall.c: Sort headers.
5863         * break-catch-sig.c: Sort headers.
5864         * blockframe.c: Sort headers.
5865         * block.c: Sort headers.
5866         * bfin-tdep.c: Sort headers.
5867         * bfin-linux-tdep.c: Sort headers.
5868         * bfd-target.c: Sort headers.
5869         * bcache.c: Sort headers.
5870         * ax-general.c: Sort headers.
5871         * ax-gdb.h: Sort headers.
5872         * ax-gdb.c: Sort headers.
5873         * avr-tdep.c: Sort headers.
5874         * auxv.c: Sort headers.
5875         * auto-load.c: Sort headers.
5876         * arm-wince-tdep.c: Sort headers.
5877         * arm-tdep.c: Sort headers.
5878         * arm-symbian-tdep.c: Sort headers.
5879         * arm-pikeos-tdep.c: Sort headers.
5880         * arm-obsd-tdep.c: Sort headers.
5881         * arm-nbsd-tdep.c: Sort headers.
5882         * arm-nbsd-nat.c: Sort headers.
5883         * arm-linux-tdep.c: Sort headers.
5884         * arm-linux-nat.c: Sort headers.
5885         * arm-fbsd-tdep.c: Sort headers.
5886         * arm-fbsd-nat.c: Sort headers.
5887         * arm-bsd-tdep.c: Sort headers.
5888         * arch-utils.c: Sort headers.
5889         * arc-tdep.c: Sort headers.
5890         * arc-newlib-tdep.c: Sort headers.
5891         * annotate.h: Sort headers.
5892         * annotate.c: Sort headers.
5893         * amd64-windows-tdep.c: Sort headers.
5894         * amd64-windows-nat.c: Sort headers.
5895         * amd64-tdep.c: Sort headers.
5896         * amd64-sol2-tdep.c: Sort headers.
5897         * amd64-obsd-tdep.c: Sort headers.
5898         * amd64-obsd-nat.c: Sort headers.
5899         * amd64-nbsd-tdep.c: Sort headers.
5900         * amd64-nbsd-nat.c: Sort headers.
5901         * amd64-nat.c: Sort headers.
5902         * amd64-linux-tdep.c: Sort headers.
5903         * amd64-linux-nat.c: Sort headers.
5904         * amd64-fbsd-tdep.c: Sort headers.
5905         * amd64-fbsd-nat.c: Sort headers.
5906         * amd64-dicos-tdep.c: Sort headers.
5907         * amd64-darwin-tdep.c: Sort headers.
5908         * amd64-bsd-nat.c: Sort headers.
5909         * alpha-tdep.c: Sort headers.
5910         * alpha-obsd-tdep.c: Sort headers.
5911         * alpha-nbsd-tdep.c: Sort headers.
5912         * alpha-mdebug-tdep.c: Sort headers.
5913         * alpha-linux-tdep.c: Sort headers.
5914         * alpha-linux-nat.c: Sort headers.
5915         * alpha-bsd-tdep.c: Sort headers.
5916         * alpha-bsd-nat.c: Sort headers.
5917         * aix-thread.c: Sort headers.
5918         * agent.c: Sort headers.
5919         * addrmap.c: Sort headers.
5920         * ada-varobj.c: Sort headers.
5921         * ada-valprint.c: Sort headers.
5922         * ada-typeprint.c: Sort headers.
5923         * ada-tasks.c: Sort headers.
5924         * ada-lang.c: Sort headers.
5925         * aarch64-tdep.c: Sort headers.
5926         * aarch64-ravenscar-thread.c: Sort headers.
5927         * aarch64-newlib-tdep.c: Sort headers.
5928         * aarch64-linux-tdep.c: Sort headers.
5929         * aarch64-linux-nat.c: Sort headers.
5930         * aarch64-fbsd-tdep.c: Sort headers.
5931         * aarch64-fbsd-nat.c: Sort headers.
5932         * aarch32-linux-nat.c: Sort headers.
5933
5934 2019-04-04  Tom Tromey  <tom@tromey.com>
5935
5936         * varobj.c (varobj_create): Update.
5937         * rust-exp.y (struct rust_parser) <update_innermost_block,
5938         lookup_symbol>: New methods.
5939         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5940         Rename.
5941         (rust_parser::rust_lookup_type)
5942         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5943         * printcmd.c (display_command, do_one_display): Update.
5944         * parser-defs.h (struct parser_state) <parser_state>: Add
5945         "tracker" parameter.
5946         (block_tracker): New member.
5947         (class innermost_block_tracker) <innermost_block_tracker>: Add
5948         "types" parameter.
5949         <reset>: Remove method.
5950         (innermost_block): Don't declare.
5951         (null_post_parser): Update.
5952         * parse.c (innermost_block): Remove global.
5953         (write_dollar_variable): Update.
5954         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5955         Remove "tracker_types" parameter.
5956         (parse_expression): Add "tracker" parameter.
5957         (parse_expression_for_completion): Update.
5958         (null_post_parser): Add "tracker" parameter.
5959         * p-exp.y: Update rules.
5960         * m2-exp.y: Update rules.
5961         * language.h (struct language_defn) <la_post_parser>: Add
5962         "tracker" parameter.
5963         * go-exp.y: Update rules.
5964         * f-exp.y: Update rules.
5965         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5966         parameter.
5967         * d-exp.y: Update rules.
5968         * c-exp.y: Update rules.
5969         * breakpoint.c (set_breakpoint_condition): Create an
5970         innermost_block_tracker.
5971         (watch_command_1): Likewise.
5972         * ada-lang.c (resolve): Add "tracker" parameter.
5973         (resolve_subexp): Likewise.
5974         * ada-exp.y (write_var_from_sym): Update.
5975
5976 2019-04-04  Tom Tromey  <tom@tromey.com>
5977
5978         * type-stack.h: New file.
5979         * type-stack.c: New file.
5980         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5981         type-stack.h.
5982         (insert_into_type_stack, insert_type, push_type, push_type_int)
5983         (insert_type_address_space, pop_type, pop_type_int)
5984         (pop_typelist, pop_type_stack, append_type_stack)
5985         (push_type_stack, get_type_stack, push_typelist)
5986         (follow_type_instance_flags, follow_types): Don't declare.
5987         * parse.c (type_stack): Remove global.
5988         (parse_exp_in_context): Update.
5989         (insert_into_type_stack, insert_type, push_type, push_type_int)
5990         (insert_type_address_space, pop_type, pop_type_int)
5991         (pop_typelist, pop_type_stack, append_type_stack)
5992         (push_type_stack, get_type_stack, push_typelist)
5993         (follow_type_instance_flags, follow_types): Remove (moved to
5994         type-stack.c).
5995         * f-exp.y (type_stack): New global.
5996         Update rules.
5997         (push_kind_type, f_parse): Update.
5998         * d-exp.y (type_stack): New global.
5999         Update rules.
6000         (d_parse): Update.
6001         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6002         Update rules.
6003         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6004         (HFILES_NO_SRCDIR): Add type-stack.h.
6005
6006 2019-04-04  Tom Tromey  <tom@tromey.com>
6007
6008         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6009         (rust_parser::convert_ast_to_expression, rust_parse)
6010         (rust_lex_test_completion, rust_lex_tests): Update.
6011         * parser-defs.h (struct expr_completion_state): New.
6012         (struct parser_state) <parser_state>: Add completion parameter.
6013         <mark_struct_expression, mark_completion_tag>: New methods.
6014         <parse_completion, m_completion_state>: New members.
6015         (prefixify_expression, null_post_parser): Update.
6016         (mark_struct_expression, mark_completion_tag): Don't declare.
6017         * parse.c (parse_completion, expout_last_struct)
6018         (expout_tag_completion_type, expout_completion_name): Remove
6019         globals.
6020         (parser_state::mark_struct_expression)
6021         (parser_state::mark_completion_tag): Now methods.
6022         (prefixify_expression): Add last_struct parameter.
6023         (prefixify_subexp): Likewise.
6024         (parse_exp_1): Update.
6025         (parse_exp_in_context): Add cstate parameter.  Update.
6026         (parse_expression_for_completion): Create an
6027         expr_completion_state.
6028         (null_post_parser): Add "completion" parameter.
6029         * p-exp.y: Update rules.
6030         (yylex): Update.
6031         * language.h (struct language_defn) <la_post_parser>: Add
6032         "completing" parameter.
6033         * go-exp.y: Update rules.
6034         (lex_one_token): Update.
6035         * expression.h (parse_completion): Don't declare.
6036         * d-exp.y: Update rules.
6037         (lex_one_token): Update rules.
6038         * c-exp.y: Update rules.
6039         (lex_one_token): Update.
6040         * ada-lang.c (resolve): Add "parse_completion" parameter.
6041         (resolve_subexp): Likewise.
6042         (ada_resolve_function): Likewise.
6043
6044 2019-04-04  Tom Tromey  <tom@tromey.com>
6045
6046         * parser-defs.h (struct parser_state) <start_arglist,
6047         end_arglist>: New methods.
6048         <arglist_len, m_funcall_chain>: New members.
6049         (arglist_len, start_arglist, end_arglist): Don't declare.
6050         * parse.c (arglist_len, funcall_chain): Remove global.
6051         (start_arglist, end_arglist): Remove functions.
6052         (parse_exp_in_context): Update.
6053         * p-exp.y: Update rules.
6054         * m2-exp.y: Update rules.
6055         * go-exp.y: Update rules.
6056         * f-exp.y: Update rules.
6057         * d-exp.y: Update rules.
6058         * c-exp.y: Update rules.
6059
6060 2019-04-04  Tom Tromey  <tom@tromey.com>
6061
6062         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6063         lex_operator, push_back>: New methods.
6064         Update all rules.
6065         (rust_parser::lex_hex, lex_escape): Rename and update.
6066         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6067         (rust_parser::lex_operator): Rename and update.
6068         (rust_parser::lex_number, rustyylex, rustyyerror)
6069         (rust_lex_test_init, rust_lex_test_sequence)
6070         (rust_lex_test_push_back, rust_lex_tests): Update.
6071         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6072         parameter.
6073         <lexptr, prev_lexptr>: New members.
6074         (lexptr, prev_lexptr): Don't declare.
6075         * parse.c (lexptr, prev_lexptr): Remove globals.
6076         (parse_exp_in_context): Update.
6077         * p-exp.y (yylex, yyerror): Update.
6078         * m2-exp.y (parse_number, yylex, yyerror): Update.
6079         * go-exp.y (lex_one_token, yyerror): Update.
6080         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6081         * d-exp.y (lex_one_token, yyerror): Update.
6082         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6083         (lex_one_token, yyerror): Update.
6084         * ada-lex.l (YY_INPUT): Update.
6085         (rewind_to_char): Update.
6086         * ada-exp.y (yyerror): Update.
6087
6088 2019-04-04  Tom Tromey  <tom@tromey.com>
6089
6090         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6091         * parser-defs.h (struct parser_state) <parser_state>: Add new
6092         parameter.
6093         <comma_terminates>: New member.
6094         (comma_terminates): Don't declare global.
6095         * parse.c (comma_terminates): Remove global.
6096         (parse_exp_in_context): Update.
6097         * p-exp.y (yylex): Update.
6098         * m2-exp.y (yylex): Update.
6099         * go-exp.y (lex_one_token): Update.
6100         * f-exp.y (yylex): Update.
6101         * d-exp.y (lex_one_token): Update.
6102         * c-exp.y (lex_one_token): Update.
6103         * ada-lex.l: Update.
6104
6105 2019-04-04  Tom Tromey  <tom@tromey.com>
6106
6107         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6108         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6109         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6110         * parser-defs.h (paren_depth): Don't declare.
6111         * parse.c (paren_depth): Remove global.
6112         (parse_exp_in_context): Update.
6113         * p-exp.y (paren_depth): New global.
6114         (pascal_parse): Initialize it.
6115         * m2-exp.y (paren_depth): New global.
6116         (m2_parse): Initialize it.
6117         * go-exp.y (paren_depth): New global.
6118         (go_parse): Initialize it.
6119         * f-exp.y (paren_depth): New global.
6120         (f_parse): Initialize it.
6121         * d-exp.y (paren_depth): New global.
6122         (d_parse): Initialize it.
6123         * c-exp.y (paren_depth): New global.
6124         (c_parse): Initialize it.
6125         * ada-lex.l (paren_depth): New global.
6126         (lexer_init): Initialize it.
6127
6128 2019-04-04  Tom Tromey  <tom@tromey.com>
6129
6130         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6131         (rust_parser::convert_ast_to_type)
6132         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6133         * parser-defs.h (struct parser_state) <parser_state>: Add
6134         parameters.  Initialize new members.
6135         <expression_context_block, expression_context_pc>: New members.
6136         * parse.c (expression_context_block, expression_context_pc):
6137         Remove globals.
6138         (parse_exp_in_context): Update.
6139         * p-exp.y: Update all rules.
6140         (yylex): Update.
6141         * m2-exp.y: Update all rules.
6142         (yylex): Update.
6143         * go-exp.y (yylex): Update.
6144         * f-exp.y (yylex): Update.
6145         * d-exp.y: Update all rules.
6146         (yylex): Update.
6147         * c-exp.y: Update all rules.
6148         (lex_one_token, classify_name, yylex, c_parse): Update.
6149         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6150
6151 2019-04-04  Tom Tromey  <tom@tromey.com>
6152
6153         * gdbarch.h, gdbarch.c: Rebuild.
6154         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6155         * stap-probe.h:
6156         (struct stap_parse_info): Replace "parser_state" with
6157         "expr_builder".
6158         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6159         (parser_state): New class.
6160         * parse.c (expr_builder): Rename.
6161         (expr_builder::release): Rename.
6162         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6163         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6164         (write_exp_elt_longcst, write_exp_elt_floatcst)
6165         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6166         (write_exp_string_vector, write_exp_bitstring)
6167         (write_exp_msymbol, mark_struct_expression)
6168         (write_dollar_variable)
6169         (insert_type_address_space, increase_expout_size): Replace
6170         "parser_state" with "expr_builder".
6171         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6172         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6173         "parser_state" with "expr_builder".
6174
6175 2019-04-04  Tom Tromey  <tom@tromey.com>
6176
6177         * rust-exp.y: Replace "parse_language" with method call.
6178         * p-exp.y:
6179         (yylex): Replace "parse_language" with method call.
6180         * m2-exp.y:
6181         (yylex): Replace "parse_language" with method call.
6182         * go-exp.y (classify_name): Replace "parse_language" with method
6183         call.
6184         * f-exp.y (yylex): Replace "parse_language" with method call.
6185         * d-exp.y (lex_one_token): Replace "parse_language" with method
6186         call.
6187         * c-exp.y:
6188         (lex_one_token, classify_name, yylex): Replace "parse_language"
6189         with method call.
6190         * ada-exp.y (find_primitive_type, type_char)
6191         (type_system_address): Replace "parse_language" with method call.
6192
6193 2019-04-04  Tom Tromey  <tom@tromey.com>
6194
6195         * rust-exp.y: Replace "parse_gdbarch" with method call.
6196         * parse.c (write_dollar_variable, insert_type_address_space):
6197         Replace "parse_gdbarch" with method call.
6198         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6199         call.
6200         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6201         call.
6202         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6203         "parse_gdbarch" with method call.
6204         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6205         with method call.
6206         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6207         "parse_gdbarch" with method call.
6208         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6209         "parse_gdbarch" with method call.
6210         * c-exp.y (parse_type, parse_number, classify_name): Replace
6211         "parse_gdbarch" with method call.
6212         * ada-lex.l: Replace "parse_gdbarch" with method call.
6213         * ada-exp.y (parse_type, find_primitive_type, type_char)
6214         (type_system_address): Replace "parse_gdbarch" with method call.
6215
6216 2019-04-04  Tom Tromey  <tom@tromey.com>
6217
6218         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6219         * stap-probe.c (stap_parse_argument): Update.
6220         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6221         initial_size parameter.
6222         * rust-exp.y (rust_lex_tests): Update.
6223         * parse.c (parser_state): Update.
6224         (parse_exp_in_context): Update.
6225         * parser-defs.h (struct parser_state) <parser_state>: Remove
6226         "initial_size" parameter.
6227
6228 2019-04-04  Tom Tromey  <tom@tromey.com>
6229
6230         * parser-defs.h (increase_expout_size): Don't declare.
6231         * parse.c (increase_expout_size): Now static.
6232
6233 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6234
6235         * gnu-nat.c (gnu_nat_target::wait): Fix
6236         target_waitstatus_to_string call.
6237
6238 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6239
6240         * eval.c (evaluate_subexp_standard): Handle internal functions
6241         during Fortran function call handling.
6242
6243 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6244
6245         * NEWS: Mention new internal functions.
6246         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6247         (read_base_type): Use dwarf2_init_complex_target_type.
6248         * value.c (creal_internal_fn): New function.
6249         (cimag_internal_fn): New function.
6250         (_initialize_values): Register new internal functions.
6251
6252 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6253
6254         * infrun.c (stop_all_threads): If debug_infrun, always
6255         trace the wait status after wait_one, using
6256         target_waitstatus_to_string and target_pid_to_str.
6257         (handle_inferior_event): Replace various trace of
6258         wait status kind by a single trace.
6259         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6260         wait status kind image by target_waitstatus_to_string.
6261         * target/waitstatus.c (target_waitstatus_to_string): Fix
6262         obsolete comment.
6263
6264 2019-04-01  Tom Tromey  <tromey@adacore.com>
6265
6266         PR symtab/23331:
6267         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6268
6269 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6270             Pedro Alves  <palves@redhat.com>
6271
6272         * top.c (quit_force): Call 'finalize_values'.
6273         * value.c (finalize_values): New function.
6274         * value.h (finalize_values): Declare.
6275
6276 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6277
6278         * NEWS: Announce $_gdb_major and $_gdb_minor.
6279
6280         * top.c (init_gdb_version_vars): New function.
6281         (gdb_init): Call init_gdb_version_vars.
6282
6283 2019-03-29  Tom Tromey  <tromey@adacore.com>
6284
6285         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6286         help text.  Remove dead code.
6287
6288 2019-03-29  Keith Seitz  <keiths@redhat.com>
6289
6290         From Siddhesh Poyarekar:
6291         * f-lang.h (f77_get_upperbound): Return LONGEST.
6292         (f77_get_lowerbound): Likewise.
6293         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6294         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6295         print them.
6296         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6297         plongest to format print it.
6298         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6299         (f77_get_upperbound): Likewise.
6300         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6301         LOWER_BOUND to LONGEST.
6302         (f77_create_arrayprint_offset_tbl): Likewise.
6303
6304 2019-03-29  Keith Seitz  <keiths@redhat.com>
6305
6306         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6307         %s/pulongest for TYPE_LENGTH instead of %d in format
6308         strings.
6309         * ada-typerint.c (ada_print_type): Likewise.
6310         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6311         * compile/compile-c-support.c (generate_register_struct): Likewise.
6312         * gdbtypes.c (recursive_dump_type): Likewise.
6313         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6314         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6315         instead of %d in format strings.
6316         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6317         to std::min to ULONGEST.
6318         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6319         instead of %d in format strings.
6320         * tracepoint.c (info_scope_command): Likewise.
6321         * typeprint.c (print_offset_data::update)
6322         (print_offset_data::finish): Likewise.
6323         * xtensa-tdep.c (xtensa_store_return_value)
6324         (xtensa_push_dummy_call): Likewise.
6325
6326 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6327
6328         * windows-nat.c (display_selector): Fixed format specifications
6329         for 64-bit Cygwin.
6330
6331 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6332
6333         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6334
6335 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6336
6337         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6338         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6339         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6340         (nios2_linux_init_abi): Install it.
6341
6342 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6343
6344         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6345
6346 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6347
6348         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6349
6350 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6351             Tom Tromey  <tromey@adacore.com>
6352
6353         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6354
6355 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6356
6357         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6358         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6359         method to compute the bounds of range types. Also print "[evaluated]"
6360         if the bounds' values come from a dynamic evaluation.
6361
6362 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6363
6364         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6365         whitespace when pretty printing is on.
6366
6367 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6368
6369         * ppc-linux-nat.c: Add include.
6370
6371 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6372
6373         * NEWS: Mention AArch64 Pointer Authentication.
6374
6375 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6376
6377         * arm-linux-nat.c: Add include.
6378
6379 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6380
6381         * source-cache.c (source_cache::get_source_lines): Re-read
6382         fullname after calling open_source_file.
6383
6384 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6385
6386         * NEWS: Mention TLS support for FreeBSD.
6387
6388 2019-03-25  Tom Tromey  <tromey@adacore.com>
6389
6390         * minsyms.c (BUNCH_SIZE): Update comment.
6391         (~minimal_symbol_reader): Remove old comment.
6392         (compact_minimal_symbols): Update comment.
6393         (minimal_symbol_reader::install): Remove old comment.  Update
6394         other comments.
6395
6396 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6397
6398         * s390-linux-nat.c: Add include.
6399
6400 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6401
6402         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6403         Call linux_get_hwcap.
6404         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6405         Likewise.
6406         (aarch64_linux_get_hwcap): Remove function.
6407         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6408         declaration.
6409         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6410         linux_get_hwcap.
6411         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6412         * linux-tdep.c (linux_get_hwcap): Add function.
6413         (linux_get_hwcap2): Likewise.
6414         * linux-tdep.h (linux_get_hwcap): Add declaration.
6415         (linux_get_hwcap2): Likewise.
6416         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6417         (ppc_linux_get_hwcap2): Likewise.
6418         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6419         linux_get_hwcap.
6420         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6421         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6422         (ppc_linux_nat_target::read_description): Likewise.
6423         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6424         * s390-linux-nat.c: Likewise.
6425         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6426
6427 2019-03-24  Tom Tromey  <tom@tromey.com>
6428
6429         * ada-lang.c (standard_lookup): Simplify initialization.
6430         (ada_lookup_symbol_nonlocal): Simplify return.
6431         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6432         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6433         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6434         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6435         initialization.
6436         * solib.c (solib_global_lookup): Simplify.
6437         * symtab.c (null_block_symbol): Remove.
6438         (symbol_cache_lookup): Simplify returns.
6439         (lookup_language_this): Simplify returns.
6440         (lookup_symbol_aux): Simplify return.
6441         (lookup_local_symbol): Simplify returns.
6442         (lookup_global_symbol_from_objfile): Simplify return.
6443         (lookup_symbol_in_objfile_symtabs)
6444         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6445         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6446         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6447         * cp-namespace.c (cp_lookup_bare_symbol)
6448         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6449         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6450         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6451         (cp_lookup_symbol_via_imports): Simplify initialization.
6452         (find_symbol_in_baseclass): Likewise.
6453         * symtab.h (null_block_symbol): Remove.
6454         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6455         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6456         (d_lookup_symbol_module): Likewise.
6457         (find_symbol_in_baseclass): Simplify initialization.
6458
6459 2019-03-24  Tom Tromey  <tom@tromey.com>
6460
6461         * expression.h: Don't include symtab.h.
6462         (struct block): Forward declare.
6463
6464 2019-03-24  Tom Tromey  <tom@tromey.com>
6465
6466         * c-exp.y (typebase): Remove casts.
6467         * gdbtypes.c (lookup_unsigned_typename, )
6468         (lookup_signed_typename): Remove cast.
6469         * eval.c (parse_to_comma_and_eval): Remove cast.
6470         * parse.c (write_dollar_variable): Remove cast.
6471         * block.h (struct block) <superblock>: Now const.
6472         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6473         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6474         (map_block): Make "block" const.
6475         * symfile.h (struct quick_symbol_functions)
6476         <map_matching_symbols>: Constify block argument to "callback".
6477         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6478         const.
6479         (find_pc_sect_compunit_symtab): Make "b" const.
6480         (find_symbol_at_address): Likewise.
6481         (search_symbols): Likewise.
6482         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6483         (dw2_debug_names_lookup_symbol): Likewise.
6484         (dw2_map_matching_symbols): Update.
6485         * p-valprint.c (pascal_val_print): Remove "block".
6486         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6487         (aux_add_nonlocal_symbols): Make "block" const.
6488         (resolve_subexp): Remove cast.
6489         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6490         const.
6491         (iterate_over_file_blocks): Likewise.
6492         * f-exp.y (%union) <bval>: Remove.
6493         * coffread.c (patch_opaque_types): Make "b" const.
6494         * spu-tdep.c (spu_catch_start): Make "block" const.
6495         * c-valprint.c (print_unpacked_pointer): Remove "block".
6496         * symmisc.c (dump_symtab_1): Make "b" const.
6497         (block_depth): Make "block" const.
6498         * d-exp.y (%union) <bval>: Remove.
6499         * cp-support.h (cp_lookup_rtti_type): Update.
6500         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6501         * psymtab.c (psym_lookup_symbol): Make "block" const.
6502         (maintenance_check_psymtabs): Make "b" const.
6503         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6504         (enumerate_locals, enumerate_args): Update.
6505         * python/py-symtab.c (stpy_global_block): Make "block" const.
6506         (stpy_static_block): Likewise.
6507         * inline-frame.c (block_starting_point_at): Make "new_block"
6508         const.
6509         * block.c (find_block_in_blockvector): Make return type const.
6510         (blockvector_for_pc_sect): Make "b" const.
6511         (find_block_in_blockvector): Make "b" const.
6512
6513 2019-03-23  Tom Tromey  <tom@tromey.com>
6514
6515         * varobj.c (varobj_create): Update.
6516         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6517         * printcmd.c (display_command, do_one_display): Don't reset
6518         innermost_block.
6519         * parser-defs.h (enum innermost_block_tracker_type): Move to
6520         expression.h.
6521         (innermost_block): Update comment.
6522         * parse.c (parse_exp_1): Add tracker_types parameter.
6523         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6524         tracker_types parameter.  Reset innermost_block.
6525         (parse_exp_in_context): Remove.
6526         (parse_expression_for_completion): Update.
6527         * objfiles.c (~objfile): Don't reset expression_context_block or
6528         innermost_block.
6529         * expression.h (enum innermost_block_tracker_type): Move from
6530         parser-defs.h.
6531         (parse_exp_1): Add tracker_types parameter.
6532         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6533         reset innermost_block.
6534
6535 2019-03-23  Tom Tromey  <tom@tromey.com>
6536
6537         * objfiles.h: Include bcache.h.
6538
6539 2019-03-23  Tom Tromey  <tom@tromey.com>
6540
6541         * linespec.c (get_current_search_block): Use
6542         scoped_restore_current_language.
6543         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6544
6545 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6546             Jiong Wang  <jiong.wang@arm.com>
6547
6548         * aarch64-linux-tdep.c
6549         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6550         section.
6551         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6552
6553 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6554             Jiong Wang  <jiong.wang@arm.com>
6555
6556         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6557         instructions.
6558         (aarch64_analyze_prologue_test): Add PACIASP test.
6559         (aarch64_prologue_prev_register): Unmask PC value.
6560
6561 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6562             Jiong Wang  <jiong.wang@arm.com>
6563
6564         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6565         (aarch64_dwarf2_prev_register): Unmask PC value.
6566         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6567         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6568         DW_CFA_AARCH64_negate_ra_state.
6569         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6570
6571 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6572             Jiong Wang  <jiong.wang@arm.com>
6573
6574         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6575         registers.
6576         (aarch64_pseudo_register_name): Likewise.
6577         (aarch64_pseudo_register_type): Likewise.
6578         (aarch64_pseudo_register_reggroup_p): Likewise.
6579         (aarch64_gdbarch_init): Add pauth registers.
6580         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6581         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6582         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6583         (struct gdbarch_tdep): Add regnum for ra_state.
6584
6585 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6586             Jiong Wang  <jiong.wang@arm.com>
6587
6588         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6589
6590 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6591             Jiong Wang  <jiong.wang@arm.com>
6592
6593         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6594         function.
6595         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6596         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6597         (aarch64_gdbarch_init): Add puth registers.
6598         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6599         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6600         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6601
6602 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6603             Jiong Wang  <jiong.wang@arm.com>
6604
6605         * aarch64-linux-nat.c
6606         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6607         * aarch64-linux-tdep.c
6608         (aarch64_linux_core_read_description): Likewise.
6609         (aarch64_linux_get_hwcap): New function.
6610         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6611         (aarch64_linux_get_hwcap): New declaration.
6612
6613 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6614             Jiong Wang  <jiong.wang@arm.com>
6615
6616         * aarch64-linux-nat.c
6617         (aarch64_linux_nat_target::read_description): Add pauth param.
6618         * aarch64-linux-tdep.c
6619         (aarch64_linux_core_read_description): Likewise.
6620         * aarch64-tdep.c (struct target_desc): Add in pauth.
6621         (aarch64_read_description): Add pauth param.
6622         (aarch64_gdbarch_init): Likewise.
6623         * aarch64-tdep.h (aarch64_read_description): Likewise.
6624         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6625         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6626         * features/Makefile: Add new files.
6627         * features/aarch64-pauth.c: New file.
6628         * features/aarch64-pauth.xml: New file.
6629
6630 2019-03-20  Tom Tromey  <tromey@adacore.com>
6631
6632         * infrun.c (handle_inferior_event): Rename from
6633         handle_inferior_event_1.  Create a scoped_value_mark.
6634         (handle_inferior_event): Remove.
6635
6636 2019-03-19  Tom Tromey  <tromey@adacore.com>
6637
6638         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6639         * infrun.h (print_stop_event): Add "displays" parameter.
6640         * infrun.c (print_stop_event): Add "displays" parameter.
6641
6642 2019-03-19  Pedro Alves  <palves@redhat.com>
6643
6644         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6645         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6646         to -1.  Fix TABs vs spaces.
6647         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6648         * tui/tui-out.h (tui_ui_out) Add intro comments.
6649         <m_line, m_start_of_line>: In-class initialize, and add describing
6650         comment.
6651
6652 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6653
6654         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6655         variable names.
6656         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6657
6658 2019-03-18  Pedro Alves  <palves@redhat.com>
6659             Eli Zaretskii <eliz@gnu.org>
6660
6661         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6662         m_line and m_start_of_line.
6663
6664 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6665
6666         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6667         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6668         it returns a newline.  This fixes a regression in TU mode, whereby
6669         the next line is output on the same screen line as the user input.
6670
6671 2019-03-18  Tom Tromey  <tromey@adacore.com>
6672
6673         * minsyms.c (minimal_symbol_reader::install): Remove call to
6674         obstack_blank.
6675
6676 2019-03-18  Pedro Alves  <palves@redhat.com>
6677
6678         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6679         New globals.
6680         (apply_style): New, factored out from ...
6681         (apply_ansi_escape): ... this.  Handle reverse video mode.
6682         (tui_set_reverse_mode): New function.
6683         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6684         * tui/tui-winsource.c (tui_show_source_line): Use
6685         tui_set_reverse_mode instead of setting A_STANDOUT.
6686         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6687         New setter methods.
6688
6689 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6690
6691         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6692         Handle tabs.
6693
6694 2019-03-18  Tom Tromey  <tromey@adacore.com>
6695
6696         * ada-lang.c (empty_array): Add "high" parameter.
6697         (ada_evaluate_subexp): Update.
6698
6699 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6700
6701         * unittests/string_view-selftests.c: Define
6702         _initialize_string_view_selftests unconditionally.
6703
6704 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6705
6706         PR gdb/24350
6707         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6708
6709 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6710
6711         PR gdb/24351
6712         * windows-nat.c (display_selector): Fix format specifiers.
6713
6714 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6715
6716         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6717         tui_refill_source_window instead of tui_refresh_win, to update the
6718         current execution line.  This fixes redisplay of the current line
6719         when stepping through the code with "next" or "step".
6720
6721 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6722
6723         * source-cache.c (source_cache::get_source_lines): Call
6724         find_source_lines to initialize s->nlines.  This fixes vertical
6725         scrolling of TUI source window when the DOWN arrow is pressed.
6726
6727 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6728
6729         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6730         linux-thread-db.c (_initialize_thread_db): Likewise.
6731
6732 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6733
6734         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6735         wclrtoeol in tui_show_source_line".  This reverts changes made in
6736         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6737
6738 2019-03-15  Tom Tromey  <tom@tromey.com>
6739
6740         * symtab.h (struct minimal_symbol): Derive from
6741         general_symbol_info.
6742         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6743         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6744         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6745         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6746         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6747         (MSYMBOL_SEARCH_NAME): Update.
6748         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6749         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6750         * minsyms.c (minimal_symbol_reader::record_full): Update.
6751
6752 2019-03-15  Tom Tromey  <tom@tromey.com>
6753
6754         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6755
6756 2019-03-15  Tom Tromey  <tom@tromey.com>
6757
6758         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6759         unique_xmalloc_ptr.
6760         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6761         Update.
6762         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6763         (build_minimal_symbol_hash_tables)
6764         (minimal_symbol_reader::install): Update.
6765
6766 2019-03-15  Tom Tromey  <tom@tromey.com>
6767
6768         * symtab.c (create_demangled_names_hash): Update.
6769         (symbol_set_names): Update.
6770         * objfiles.h (struct objfile_per_bfd_storage)
6771         <demangled_names_hash>: Now an htab_up.
6772         * objfiles.c (objfile_per_bfd_storage): Simplify.
6773
6774 2019-03-15  Tom Tromey  <tom@tromey.com>
6775
6776         * objfiles.h (struct objfile_per_bfd_storage): Declare
6777         destructor.
6778         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6779         New.
6780         (get_objfile_bfd_data): Use new.  Don't initialize
6781         language_of_main.
6782         (free_objfile_per_bfd_storage): Remove.
6783         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6784
6785 2019-03-15  Tom Tromey  <tom@tromey.com>
6786
6787         * symfile.c (reread_symbols): Update.
6788         * objfiles.c (objfile::objfile): Update.
6789         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6790         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6791         comment.
6792         (minimal_symbol_reader::install): Update.
6793         (terminate_minimal_symbol_table): Remove.
6794         * jit.c (jit_object_close_impl): Update.
6795
6796 2019-03-15  Tom Tromey  <tom@tromey.com>
6797
6798         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6799         initializations.
6800
6801 2019-03-15  Tom Tromey  <tom@tromey.com>
6802
6803         * objfiles.h (struct objfile_per_bfd_storage)
6804         <demangled_hash_languages>: Now a bitset.
6805         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6806         (lookup_minimal_symbol): Update.
6807
6808 2019-03-15  Tom Tromey  <tom@tromey.com>
6809
6810         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6811         Don't return the symbol.
6812         * coffread.c (record_minimal_symbol): Use record_full.
6813
6814 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6815
6816         The MS-Windows port of ncurses fails to switch to a color pair if
6817         one or both of the colors are the implicit default colors.  This
6818         change records the default colors when TUI is initialized, and
6819         then specifies them explicitly when a color pair uses the default
6820         colors.  This allows color styling in TUI mode on MS-Windows.
6821
6822         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6823         ncurses_norm_attr.
6824         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6825         colors in ncurses_norm_attr.
6826         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6827         "none", replace it with the default color recorded in
6828         ncurses_norm_attr.
6829
6830 2019-03-14  Tom Tromey  <tromey@adacore.com>
6831
6832         * source-cache.h (class source_cache) <get_source_lines>: Return
6833         std::string.
6834         * source-cache.c (source_cache::extract_lines): Handle case where
6835         first_pos==npos.  Return std::string.
6836         (source_cache::get_source_lines): Update.
6837
6838 2019-03-14  Tom Tromey  <tromey@adacore.com>
6839
6840         * NEWS: Add item for "style sources" commands.
6841         * source-cache.c (source_cache::get_source_lines): Check
6842         source_styling.
6843         * cli/cli-style.c (source_styling): New global.
6844         (_initialize_cli_style): Add "style sources" commands.
6845         (show_style_sources): New function.
6846         * cli/cli-style.h (source_styling): Declare.
6847
6848 2019-03-14  Pedro Alves  <palves@redhat.com>
6849             Tom Tromey  <tromey@adacore.com>
6850
6851         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6852         * tui/tui-winsource.c (tui_refill_source_window): New function,
6853         from...
6854         (tui_horizontal_source_scroll): ... here.  Move some logic.
6855         * cli/cli-style.c (set_style_enabled): Notify new observable.
6856         * tui/tui-hooks.c (tui_redisplay_source): New function.
6857         (tui_attach_detach_observers): Attach or detach
6858         tui_redisplay_source.
6859         * observable.h (source_styling_changed): New observable.
6860         * observable.c: Define source_styling_changed observable.
6861
6862 2019-03-13  Tom Tromey  <tromey@adacore.com>
6863
6864         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6865         (i386_gnu_nat_target::store_registers): Update.
6866         * target-debug.h (target_debug_print_std_string): New macro.
6867         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6868         * windows-tdep.c (display_one_tib): Update.
6869         * tui/tui-stack.c (tui_make_status_line): Update.
6870         * top.c (print_inferior_quit_action): Update.
6871         * thread.c (thr_try_catch_cmd): Update.
6872         (add_thread_with_info): Update.
6873         (thread_target_id_str): Update.
6874         (thr_try_catch_cmd): Update.
6875         (thread_command): Update.
6876         (thread_find_command): Update.
6877         * record-btrace.c (record_btrace_target::info_record)
6878         (record_btrace_resume_thread, record_btrace_target::resume)
6879         (record_btrace_cancel_resume, record_btrace_step_thread)
6880         (record_btrace_target::wait, record_btrace_target::wait)
6881         (record_btrace_target::wait, record_btrace_target::stop): Update.
6882         * progspace.c (print_program_space): Update.
6883         * process-stratum-target.c
6884         (process_stratum_target::thread_address_space): Update.
6885         * linux-fork.c (linux_fork_mourn_inferior)
6886         (detach_checkpoint_command, info_checkpoints_command)
6887         (linux_fork_context): Update.
6888         (linux_fork_detach): Update.
6889         (class scoped_switch_fork_info): Update.
6890         (delete_checkpoint_command): Update.
6891         * infrun.c (follow_fork_inferior): Update.
6892         (follow_fork_inferior): Update.
6893         (proceed_after_vfork_done): Update.
6894         (handle_vfork_child_exec_or_exit): Update.
6895         (follow_exec): Update.
6896         (displaced_step_prepare_throw): Update.
6897         (displaced_step_restore): Update.
6898         (start_step_over): Update.
6899         (resume_1): Update.
6900         (clear_proceed_status_thread): Update.
6901         (proceed): Update.
6902         (print_target_wait_results): Update.
6903         (do_target_wait): Update.
6904         (context_switch): Update.
6905         (stop_all_threads): Update.
6906         (restart_threads): Update.
6907         (finish_step_over): Update.
6908         (handle_signal_stop): Update.
6909         (switch_back_to_stepped_thread): Update.
6910         (keep_going_pass_signal): Update.
6911         (print_exited_reason): Update.
6912         (normal_stop): Update.
6913         * inferior.c (inferior_pid_to_str): Change return type.
6914         (print_selected_inferior): Update.
6915         (add_inferior): Update.
6916         (detach_inferior): Update.
6917         * dummy-frame.c (fprint_dummy_frames): Update.
6918         * dcache.c (dcache_info_1): Update.
6919         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6920         (btrace_fetch, btrace_clear): Update.
6921         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6922         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6923         type.
6924         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6925         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6926         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6927         * gdbarch.c, gdbarch.h: Rebuild.
6928         * gdbarch.sh (core_pid_to_str): Change return type.
6929         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6930         return type.
6931         (windows_nat_target::pid_to_str): Change return type.
6932         (windows_delete_thread): Update.
6933         (windows_nat_target::attach): Update.
6934         (windows_nat_target::files_info): Update.
6935         * target-delegates.c: Rebuild.
6936         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6937         return type.
6938         (sol_thread_target::pid_to_str): Change return type.
6939         * remote.c (class remote_target) <pid_to_str>: Change return
6940         type.
6941         (remote_target::pid_to_str): Change return type.
6942         (extended_remote_target::attach, remote_target::remote_stop_ns)
6943         (remote_target::remote_notif_remove_queued_reply)
6944         (remote_target::push_stop_reply, remote_target::disable_btrace):
6945         Update.
6946         (extended_remote_target::attach): Update.
6947         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6948         type.
6949         (gdbsim_target::pid_to_str): Change return type.
6950         * ravenscar-thread.c (struct ravenscar_thread_target)
6951         <pid_to_str>: Change return type.
6952         (ravenscar_thread_target::pid_to_str): Change return type.
6953         * procfs.c (class procfs_target) <pid_to_str>: Change return
6954         type.
6955         (procfs_target::pid_to_str): Change return type.
6956         (procfs_target::attach): Update.
6957         (procfs_target::detach): Update.
6958         (procfs_target::fetch_registers): Update.
6959         (procfs_target::store_registers): Update.
6960         (procfs_target::wait): Update.
6961         (procfs_target::files_info): Update.
6962         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6963         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6964         return type.
6965         (nto_procfs_target::pid_to_str): Change return type.
6966         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6967         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6968         return type.
6969         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6970         (exit_lwp): Update.
6971         (attach_proc_task_lwp_callback, get_detach_signal)
6972         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6973         (linux_nat_target::resume, wait_lwp, stop_callback)
6974         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6975         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6976         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6977         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6978         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6979         type.
6980         (inf_ptrace_target::attach): Update.
6981         (inf_ptrace_target::files_info): Update.
6982         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6983         type.
6984         (go32_nat_target::pid_to_str): Change return type.
6985         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6986         (gnu_nat_target::wait): Update.
6987         (gnu_nat_target::wait): Update.
6988         (gnu_nat_target::resume): Update.
6989         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6990         (fbsd_nat_target::wait): Update.
6991         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6992         type.
6993         (darwin_nat_target::attach): Update.
6994         * corelow.c (class core_target) <pid_to_str>: Change return type.
6995         (core_target::pid_to_str): Change return type.
6996         * target.c (normal_pid_to_str): Change return type.
6997         (default_pid_to_str): Likewise.
6998         (target_pid_to_str): Change return type.
6999         (target_translate_tls_address): Update.
7000         (target_announce_detach): Update.
7001         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7002         return type.
7003         (bsd_uthread_target::pid_to_str): Change return type.
7004         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7005         type.
7006         (bsd_kvm_target::pid_to_str): Change return type.
7007         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7008         return type.
7009         (aix_thread_target::pid_to_str): Change return type.
7010         * target.h (struct target_ops) <pid_to_str>: Change return type.
7011         (target_pid_to_str, normal_pid_to_str): Likewise.
7012         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7013         type.
7014         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7015         type.
7016         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7017         return type.
7018         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7019         type.
7020         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7021         type.
7022         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7023         return type.
7024
7025 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7026
7027         * NEWS: Mention that the new default MI version is 3.  Mention
7028         changes to the output of commands and events that deal with
7029         multi-location breakpoints.
7030         * breakpoint.c: Include "mi/mi-out.h".
7031         (print_one_breakpoint): Change output syntax if using MI version
7032         >= 3.
7033         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7034         New.
7035         (mi_multi_location_breakpoint_output_fixed): New.
7036         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7037         (mi_cmd_fix_multi_location_breakpoint_output): New.
7038         (mi_multi_location_breakpoint_output_fixed): New.
7039         * mi/mi-cmds.c (mi_cmds): Register command
7040         -fix-multi-location-breakpoint-output.
7041         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7042         interpreter "mi".
7043
7044 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7045
7046         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7047         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7048         instantiate mi_ui_out based on interpreter name.
7049         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7050         * mi/mi-main.c (mi_load_progress): Likewise.
7051
7052 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7053
7054         * NEWS: Combine separate "New targets" sections for 8.3.
7055
7056 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7057
7058         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7059         (ppcfbsd_init_abi): Install gdbarch
7060         "fetch_tls_load_module_address" and "get_thread_local_address"
7061         methods.
7062
7063 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7064
7065         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7066         (riscv_fbsd_init_abi): Install gdbarch
7067         "fetch_tls_load_module_address" and "get_thread_local_address"
7068         methods.
7069
7070 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7071
7072         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7073         (i386fbsd_init_abi): Install gdbarch
7074         "fetch_tls_load_module_address" and "get_thread_local_address"
7075         methods.
7076
7077 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7078
7079         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7080         (amd64fbsd_init_abi): Install gdbarch
7081         "fetch_tls_load_module_address" and "get_thread_local_address"
7082         methods.
7083
7084 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7085
7086         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7087         (struct fbsd_pspace_data): New type.
7088         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7089         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7090         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7091         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7092         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7093
7094 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7095
7096         * gdbtypes.c (lookup_struct_elt): New function.
7097         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7098         * gdbtypes.h (struct struct_elt): New type.
7099         (lookup_struct_elt): New prototype.
7100
7101 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7102
7103         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7104         remove disabled code block.
7105
7106 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7107
7108         * gdbarch.sh (get_thread_local_address): New method.
7109         * gdbarch.h, gdbarch.c: Regenerate.
7110         * target.c (target_translate_tls_address): Use
7111         gdbarch_get_thread_local_address if present instead of
7112         target::get_thread_local_address.
7113
7114 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7115
7116         * target.h (target::get_thread_local_address): Update comment.
7117
7118 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7119
7120         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7121         objfile->separate_debug_objfile_backlink if not NULL.
7122
7123 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7124
7125         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7126         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7127         (amd64bsd_store_inferior_registers): Likewise.
7128         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7129         Enable segment base registers.
7130         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7131         PT_GETFSBASE and PT_GETGSBASE.
7132         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7133         PT_SETGSBASE.
7134         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7135         segment base registers.
7136         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7137
7138 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7139
7140         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7141         Update calls to i386_target_description to add 'segments'
7142         parameter.
7143         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7144         add segment base registers.
7145         * arch/i386.c (i386_create_target_description): Add 'segments'
7146         parameter to enable segment base registers.
7147         * arch/i386.h (i386_create_target_description): Likewise.
7148         * features/i386/32bit-segments.xml: New file.
7149         * features/i386/32bit-segments.c: Generate.
7150         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7151         call to i386_target_description to add 'segments' parameter.
7152         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7153         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7154         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7155         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7156         if feature is present.
7157         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7158         Add 'segments' parameter to call to i386_target_description.
7159         (i386_target_description): Add 'segments' parameter to enable
7160         segment base registers.
7161         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7162         to call to i386_target_description.
7163         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7164         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7165         Define I386_NUM_REGS.
7166         (i386_target_description): Add 'segments' parameter to enable
7167         segment base registers.
7168
7169 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7170
7171         PR/24325
7172         * source-cache.c: #undef open and close, to avoid unresolved
7173         externals during linking.
7174
7175 2019-03-12  Tom Tromey  <tromey@adacore.com>
7176
7177         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7178         const.  Add initializers.
7179         (_initialize_remote): Don't initialize ptid globals.
7180
7181 2019-03-12  Pedro Alves  <palves@redhat.com>
7182
7183         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7184
7185 2019-03-12  Pedro Alves  <palves@redhat.com>
7186
7187         * cp-name-parser.y (main): Remove unused 'len' variable.
7188
7189 2019-03-12  Tom Tromey  <tromey@adacore.com>
7190
7191         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7192         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7193
7194 2019-03-12  Tom Tromey  <tromey@adacore.com>
7195
7196         * linux-nat.c (iterate_over_lwps): Update.
7197         (stop_callback): Remove parameter.
7198         (stop_wait_callback, detach_callback, resume_set_callback)
7199         (select_singlestep_lwp_callback, set_ignore_sigint)
7200         (status_callback, resumed_callback, resume_clear_callback)
7201         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7202         data parameter.
7203         (linux_nat_target::detach, linux_nat_target::resume)
7204         (linux_stop_and_wait_all_lwps, select_event_lwp)
7205         (linux_nat_filter_event, linux_nat_wait_1)
7206         (linux_nat_target::kill, linux_nat_target::stop)
7207         (linux_nat_target::stop): Update.
7208         (linux_nat_resume_callback): Change type.
7209         (resume_stopped_resumed_lwps, count_events_callback)
7210         (select_event_lwp_callback): Likewise.
7211         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7212         * arm-linux-nat.c (struct update_registers_data): Remove.
7213         (update_registers_callback): Change type.
7214         (arm_linux_insert_hw_breakpoint1): Update.
7215         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7216         parameter.
7217         (x86_linux_dr_set_addr): Update.
7218         (x86_linux_dr_set_control): Update.
7219         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7220         (iterate_over_lwps): Use gdb::function_view.
7221         * nat/aarch64-linux-hw-point.c (struct
7222         aarch64_dr_update_callback_param): Remove.
7223         (debug_reg_change_callback): Change type.
7224         (aarch64_notify_debug_reg_change): Update.
7225         * s390-linux-nat.c (s390_refresh_per_info): Update.
7226
7227 2019-03-11  Tom Tromey  <tromey@adacore.com>
7228
7229         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7230         redundant assignment to "this_cu".
7231
7232 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7233
7234         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7235
7236 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7237
7238         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7239         from...
7240         (rank_one_type): ... this.
7241
7242 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7243
7244         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7245         from...
7246         (rank_one_type): ... this.
7247
7248 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7249
7250         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7251         from...
7252         (rank_one_type): ... this.
7253
7254 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7255
7256         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7257         from...
7258         (rank_one_type): ... this.
7259
7260 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7261
7262         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7263         from...
7264         (rank_one_type): ... this.
7265
7266 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7267
7268         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7269         from...
7270         (rank_one_type): ... this.
7271
7272 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7273
7274         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7275         from...
7276         (rank_one_type): ... this.
7277
7278 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7279
7280         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7281         from...
7282         (rank_one_type): ... this.
7283
7284 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7285
7286         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7287         from...
7288         (rank_one_type): ... this.
7289
7290 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7291
7292         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7293         from...
7294         (rank_one_type): ... this.
7295
7296 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7297
7298         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7299         from...
7300         (rank_one_type): ... this.
7301
7302 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7303
7304         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7305         from...
7306         (rank_one_type): ... this.
7307
7308 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7309
7310         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7311         inferior-events' shows the example events.
7312
7313 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7314
7315         Support styling on native MS-Windows console
7316
7317         PR/24315
7318         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7319         on MS-Windows if $TERM is not defined.
7320
7321         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7322
7323         * posix-hdep.c (gdb_console_fputs):
7324         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7325         functions.
7326         * ui-file.h (gdb_console_fputs): Add prototype.
7327
7328         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7329         back to fputs only if the former returns zero.
7330
7331 2019-03-07  Tom Tromey  <tom@tromey.com>
7332
7333         * symmisc.c (print_symbol_bcache_statistics): Update.
7334         (print_objfile_statistics): Update.
7335         * symfile.c (allocate_symtab): Update.
7336         * stabsread.c: Don't include bcache.h.
7337         * psymtab.h (struct psymbol_bcache): Don't declare.
7338         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7339         (psymbol_bcache_init, psymbol_bcache_free)
7340         (psymbol_bcache_get_bcache): Don't declare.
7341         * psymtab.c (struct psymbol_bcache): Remove.
7342         (psymtab_storage::psymtab_storage): Update.
7343         (psymtab_storage::~psymtab_storage): Update.
7344         (psymbol_bcache_init, psymbol_bcache_free)
7345         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7346         (add_psymbol_to_bcache): Update.
7347         (allocate_psymtab): Update.
7348         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7349         macro_cache>: No longer pointers.
7350         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7351         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7352         * macrotab.c (macro_bcache): Update.
7353         * macroexp.c: Don't include bcache.h.
7354         * gdbtypes.c (check_types_worklist): Update.
7355         (types_deeply_equal): Remove TRY/CATCH.  Update.
7356         * elfread.c (elf_symtab_read): Update.
7357         * dwarf2read.c: Don't include bcache.h.
7358         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7359         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7360         (print_bcache_statistics, bcache_memory_used): Don't declare.
7361         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7362         methods.  Rename all data members.
7363         * bcache.c (struct bcache): Move to bcache.h.
7364         (bcache::expand_hash_table): Rename from expand_hash_table.
7365         (bcache): Remove.
7366         (bcache::insert): Rename from bcache_full.
7367         (bcache::compare): Rename from bcache_compare.
7368         (bcache_xmalloc): Remove.
7369         (bcache::~bcache): Rename from bcache_xfree.
7370         (bcache::print_statistics): Rename from print_bcache_statistics.
7371         (bcache::memory_used): Rename from bcache_memory_used.
7372
7373 2019-03-07  Pedro Alves  <palves@redhat.com>
7374
7375         * infrun.c (normal_stop): Also check for
7376         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7377
7378 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7379
7380         * f-lang.c (value_from_host_double): Moved to...
7381         * value.c (value_from_host_double): ...here.
7382         * value.h (value_from_host_double): Declare.
7383         * guile/scm-math.c (vlscm_convert_typed_number): Use
7384         value_from_host_double.
7385         (vlscm_convert_number): Likewise.
7386         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7387         * python/py-value.c (convert_value_from_python): Likewise.
7388
7389 2019-03-06  Tom Tromey  <tom@tromey.com>
7390
7391         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7392
7393 2019-03-06  Tom Tromey  <tom@tromey.com>
7394
7395         * utils.h (free_current_contents): Don't declare.
7396         * utils.c (free_current_contents): Remove.
7397
7398 2019-03-06  Tom Tromey  <tom@tromey.com>
7399
7400         * top.c (quit_force): Update.
7401         * main.c (captured_command_loop): Update.
7402         * common/new-op.c (operator new): Update.
7403         * common/common-exceptions.c (struct catcher)
7404         <save_cleanup_chain>: Remove member.
7405         (exceptions_state_mc_init): Update.
7406         (exception_try_scope_entry): Return nullptr.
7407         (exception_try_scope_exit, exception_rethrow)
7408         (throw_exception_sjlj, throw_exception_cxx): Update.
7409         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7410         (all_cleanups, do_cleanups, discard_cleanups)
7411         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7412         (restore_cleanups, restore_final_cleanups): Don't declare.
7413         (do_final_cleanups): Remove parameter.
7414         * common/cleanups.c (cleanup_chain, make_cleanup)
7415         (make_cleanup_dtor, all_cleanups, do_cleanups)
7416         (discard_my_cleanups, discard_cleanups)
7417         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7418         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7419         (null_cleanup): Remove.
7420         (do_final_cleanups): Remove parameter.
7421
7422 2019-03-06  Tom Tromey  <tom@tromey.com>
7423
7424         * remote.c (remote_target::remote_parse_stop_reply): Use
7425         unique_xmalloc_ptr.
7426
7427 2019-03-06  Tom Tromey  <tom@tromey.com>
7428
7429         * stabsread.c (struct stabs_field_info): Rename from field_info.
7430         <list, fnlist>: Add initializers.
7431         <obstack>: New member.
7432         (read_member_functions, read_struct_fields, read_baseclasses):
7433         Allocate on obstack.  Don't use cleanups.
7434         (read_one_struct_field, read_member_functions, read_struct_fields)
7435         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7436         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7437         (read_struct_type): Update.
7438
7439 2019-03-06  Tom Tromey  <tom@tromey.com>
7440
7441         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7442         * common/filestuff.h (make_cleanup_close): Don't declare.
7443         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7444         Remove.
7445
7446 2019-03-06  Tom Tromey  <tom@tromey.com>
7447
7448         * solib-aix.c: Use make_scope_exit.
7449
7450 2019-03-06  Tom Tromey  <tom@tromey.com>
7451
7452         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7453         Use make_scope_exit.
7454
7455 2019-03-06  Tom Tromey  <tom@tromey.com>
7456
7457         * solib-svr4.c (disable_probes_interface): Remove parameter.
7458         (svr4_handle_solib_event): Use make_scope_exit.
7459
7460 2019-03-06  Tom Tromey  <tom@tromey.com>
7461
7462         * remote.c (struct stop_reply_deleter): Remove.
7463         (stop_reply_up): Update.
7464         (struct stop_reply): Derive from notif_event.  Don't typedef.
7465         <regcache>: Now a std::vector.
7466         (stop_reply_xfree): Remove.
7467         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7468         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7469         (remote_target::discard_pending_stop_replies): Use delete.
7470         (remote_target::remote_parse_stop_reply): Update.
7471         (remote_target::process_stop_reply): Update.
7472         * remote-notif.h (struct notif_event): Add virtual destructor.
7473         Remove "dtr" member.
7474         (struct notif_client) <alloc_event>: Return a unique_ptr.
7475         (notif_event_xfree): Don't declare.
7476         (notif_event_up): New typedef.
7477         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7478         (notif_event_xfree, do_notif_event_xfree): Remove.
7479         (remote_notif_state_xfree): Update.
7480
7481 2019-03-06  Tom Tromey  <tom@tromey.com>
7482
7483         * infrun.c (displaced_step_clear_cleanup): Now a
7484         forward_scope_exit type.
7485         (displaced_step_prepare_throw): Update.
7486         (displaced_step_fixup): Update.
7487
7488 2019-03-06  Tom Tromey  <tom@tromey.com>
7489
7490         * inferior.h (class inferior): Update comment.
7491         * gdbthread.h (class thread_info): Update comment.
7492
7493 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7494             Tom Tromey  <tom@tromey.com>
7495
7496         * stabsread.h (struct stab_section_list): Remove.
7497         (coffstab_build_psymtabs): Update.
7498         * dbxread.c (symbuf_sections): Now a std::vector.
7499         (sect_idx): New global.
7500         (fill_symbuf): Update.
7501         (coffstab_build_psymtabs): Change type of stabsects parameter.
7502         Update.
7503         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7504         std::vector.
7505         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7506         (coff_locate_sections): Update.
7507         (coff_symfile_read): Remove cleanups.  Update.
7508         (init_stringtab): Add storage parameter.
7509         (free_stringtab, free_stringtab_cleanup): Remove.
7510         (init_lineno): Add storage parameter.
7511         (free_linetab, free_linetab_cleanup): Remove.
7512
7513 2019-03-06  Pedro Alves  <palves@redhat.com>
7514
7515         * linux-fork.c (fork_info::clobber_regs): Delete.
7516         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7517         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7518         comment.  Adjust.
7519         (scoped_switch_fork_info::scoped_switch_fork_info)
7520         (checkpoint_command, linux_fork_context): Adjust
7521         fork_save_infrun_state calls.
7522
7523 2019-03-06  Pedro Alves  <palves@redhat.com>
7524
7525         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7526         (inf_has_multiple_threads): Return 'bool' and rewrite using
7527         inferior_info::threads().
7528
7529 2019-03-06  Pedro Alves  <palves@redhat.com>
7530
7531         * linux-fork.c: Include <list>.
7532         (fork_list): Now a std::list instance.
7533         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7534         (forks_exist_p, find_last_fork): Adjust.
7535         (new_fork): Delete.
7536         (one_fork_p): New.
7537         (add_fork): Adjust.
7538         (free_fork): Delete, folded into fork_info::~fork_info().
7539         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7540         Adjust.
7541         (init_fork_list): Delete.
7542         (linux_fork_killall, linux_fork_mourn_inferior)
7543         (linux_fork_detach, info_checkpoints_command): Adjust.
7544         (_initialize_linux_fork): No longer call init_fork_list.
7545
7546 2019-03-06  Pedro Alves  <palves@redhat.com>
7547
7548         * linux-fork.c (new_fork): New, split out of ...
7549         (add_fork): ... this.  Return void.  Move "first fork" special
7550         case from here, to ...
7551         (checkpoint_command): ... here.
7552         * linux-linux.h (add_fork): Return void.
7553
7554 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7555
7556         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7557
7558 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7559             Chris January  <chris.january@arm.com>
7560             David Lecomber  <david.lecomber@arm.com>
7561
7562         * f-exp.y: New token, UNOP_INTRINSIC.
7563         (exp): New pattern using UNOP_INTRINSIC token.
7564         (f77_keywords): Add 'abs' keyword.
7565         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7566         (value_from_host_double): New function.
7567         (evaluate_subexp_f): Support UNOP_ABS.
7568
7569 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7570
7571         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7572         types.
7573
7574 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7575
7576         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7577         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7578         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7579
7580 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7581
7582         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7583
7584 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7585             Chris January  <chris.january@arm.com>
7586
7587         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7588         * f-exp.y: Define 'KIND' token.
7589         (exp): New pattern for KIND expressions.
7590         (ptype): Handle types with a kind extension.
7591         (direct_abs_decl): Extend to spot kind extensions.
7592         (f77_keywords): Add 'kind' to the list.
7593         (push_kind_type): New function.
7594         (convert_to_kind_type): New function.
7595         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7596         * parse.c (operator_length_standard): Likewise.
7597         * parser-defs.h (enum type_pieces): Add tp_kind.
7598         * std-operator.def: Add UNOP_KIND.
7599
7600 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7601
7602         * f-exp.y (f_parse): Set yydebug.
7603
7604 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7605
7606         * f-lang.c (evaluate_subexp_f): New function.
7607         (exp_descriptor_f): New global.
7608         (f_language_defn): Use exp_descriptor_f instead of
7609         exp_descriptor_standard.
7610
7611 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7612
7613         * f-exp.y (struct token): Add comments.
7614         (dot_ops): Remove uppercase versions and the end marker.
7615         (f77_keywords): Likewise.
7616         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7617         entries in the dot_ops array are case insensitive, and use
7618         strncasecmp to compare strings.  Also some whitespace cleanup in
7619         this area.  Similar for the f77_keywords array, except entries in
7620         this list might be case sensitive.
7621
7622 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7623
7624         * f-exp.y (struct f77_boolean_val): Add comments.
7625         (boolean_values): Remove uppercase versions, and end marker.
7626         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7627         and use strncasecmp to achieve case insensitivity.  Additionally,
7628         perform whitespace cleanup around this code.
7629
7630 2019-03-06  Tom Tromey  <tromey@adacore.com>
7631
7632         * remote-sim.c (gdbsim_target_open): Use result of
7633         gdb_argv::release.
7634
7635 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7636         Dirk Schubert  <dirk.schubert@arm.com>
7637         Chris January  <chris.january@arm.com>
7638
7639         * eval.c (evaluate_subexp_standard): Call Fortran argument
7640         wrapping logic.
7641         * f-lang.c (struct value): A value which can be passed into a
7642         Fortran function call.
7643         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7644         where appropriate.
7645         (struct type): Value ready for a Fortran function call.
7646         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7647         is needed.
7648         * f-lang.h (fortran_argument_convert): Declaration.
7649         (fortran_preserve_arg_pointer): Declaration.
7650         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7651
7652 2019-03-05  Tom Tromey  <tromey@adacore.com>
7653
7654         * python/py-prettyprint.c (print_string_repr): Remove #if.
7655         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7656
7657 2019-03-05  Tom Tromey  <tromey@adacore.com>
7658
7659         * target.c (the_dummy_target): Move later.  Change type to
7660         "dummy_target".
7661         (initialize_targets): Don't initialize the_dummy_target.
7662
7663 2019-03-05  Tom Tromey  <tromey@adacore.com>
7664
7665         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7666         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7667
7668 2019-03-05  Tom Tromey  <tromey@adacore.com>
7669
7670         * windows-nat.c (windows_nat_target::attach)
7671         (windows_nat_target::detach): Don't call gdb_flush.
7672         * valprint.c (generic_val_print, val_print, val_print_string):
7673         Don't call gdb_flush.
7674         * utils.c (defaulted_query): Don't call gdb_flush.
7675         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7676         * target.c (target_announce_detach): Don't call gdb_flush.
7677         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7678         * remote.c (extended_remote_target::attach): Don't call
7679         gdb_flush.
7680         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7681         * printcmd.c (do_examine): Don't call gdb_flush.
7682         (info_display_command): Don't call gdb_flush.
7683         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7684         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7685         * memattr.c (info_mem_command): Don't call gdb_flush.
7686         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7687         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7688         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7689         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7690         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7691         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7692         (gnu_nat_target::detach): Don't call gdb_flush.
7693         * f-valprint.c (f_val_print): Don't call gdb_flush.
7694         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7695         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7696         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7697         gdb_flush.
7698         * c-valprint.c (c_val_print): Don't call gdb_flush.
7699         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7700
7701 2019-03-05  Tom Tromey  <tromey@adacore.com>
7702
7703         * varobj.c (update_dynamic_varobj_children): Update.
7704         (install_default_visualizer): Use reset, not release.
7705         * value.c (set_internalvar): Update.
7706         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7707         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7708         ATTRIBUTE_UNUSED_RESULT.
7709
7710 2019-03-05  Tom Tromey  <tromey@adacore.com>
7711
7712         * remote.c (class scoped_remote_fd) <release>: Add
7713         ATTRIBUTE_UNUSED_RESULT.
7714
7715 2019-03-05  Tom Tromey  <tromey@adacore.com>
7716
7717         * macroexp.c (struct macro_buffer) <release>: Add
7718         ATTRIBUTE_UNUSED_RESULT.
7719
7720 2019-03-05  Tom Tromey  <tromey@adacore.com>
7721
7722         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7723         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7724         ATTRIBUTE_UNUSED_RESULT.
7725
7726 2019-03-05  Tom Tromey  <tromey@adacore.com>
7727
7728         * common/scoped_fd.h (class scoped_fd) <release>: Add
7729         ATTRIBUTE_UNUSED_RESULT.
7730
7731 2019-03-05  Tom Tromey  <tromey@adacore.com>
7732
7733         * parser-defs.h (struct parser_state) <release>: Add
7734         ATTRIBUTE_UNUSED_RESULT.
7735
7736 2019-03-05  Tom Tromey  <tromey@adacore.com>
7737
7738         * utils.h (class gdb_argv) <release>: Add
7739         ATTRIBUTE_UNUSED_RESULT.
7740         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7741
7742 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7743
7744         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7745         for-loop range, to avoid compiler warnings.
7746
7747         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7748         avoid compiler warnings about unused variables.
7749
7750         * NEWS: Mention end of support for native debugging on MS-Windows
7751         before XP.
7752
7753         PR gdb/24292
7754         * common/netstuff.c:
7755         * gdbserver/gdbreplay.c
7756         * gdbserver/remote-utils.c:
7757         * ser-tcp.c:
7758         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7759         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7760         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7761         'getaddrinfo' and 'freeaddrinfo' were not available before
7762         Windows XP, and mingw.org's MinGW headers by default define
7763         _WIN32_WINNT to 0x500.
7764
7765 2019-03-01  Gary Benson <gbenson@redhat.com>
7766
7767         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7768
7769 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7770             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7771
7772         PR gdb/8527
7773         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7774         set_sigint_trap, clear_sigint_trap.
7775
7776 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7777
7778         * target.c (target_detach): Clear the regcache and the
7779         frame cache.
7780
7781 2019-02-27  Pedro Alves  <palves@redhat.com>
7782
7783         * utils.c (set_screen_size): When we cap the height/width sizes,
7784         tweak the corresponding command variable to show "unlimited":
7785
7786 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7787             Pedro Alves  <palves@redhat.com>
7788
7789         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7790         before calling rl_set_screen_size.
7791
7792 2019-02-27  Tom Tromey  <tromey@adacore.com>
7793
7794         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7795         define.
7796         * python/py-value.c: Remove Python 2.4 workaround.
7797         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7798         workaround.
7799         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7800         Python 2.4 workaround.
7801         * python/python-internal.h: Remove Python 2.4 comment.
7802         (Py_ssize_t): Don't define.
7803         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7804         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7805         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7806         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7807         * python/python.c (do_start_initialization): Remove Python 2.4
7808         workaround.
7809         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7810         (print_children): Remove Python 2.4 workaround.
7811         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7812         workaround.
7813         (CHARBUFFERPROC_NAME): Remove.
7814         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7815         Python 2.4 workaround.
7816
7817 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7818
7819         * NEWS: Note minimum Python version.
7820
7821 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7822
7823         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7824         code from these functions.  Remove corresponding ifdefs.  Use
7825         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7826         Remove gotos and target of gotos.
7827         (infpy_search_memory): Likewise.
7828
7829 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7830
7831         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7832         (hppa_gdbarch_init): Don't register deleted functions with
7833         gdbarch.
7834
7835 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7836
7837         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7838         (h8300_unwind_sp): Delete.
7839         (h8300_dummy_id): Delete.
7840         (h8300_gdbarch_init): Don't register deleted functions with
7841         gdbarch.
7842
7843 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7844
7845         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7846         (ft32_unwind_pc): Delete.
7847         (ft32_unwind_sp): Delete.
7848         (ft32_gdbarch_init): Don't register deleted functions with
7849         gdbarch.
7850
7851 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7852
7853         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7854         (frv_unwind_pc): Delete.
7855         (frv_unwind_sp): Delete.
7856         (frv_gdbarch_init): Don't register deleted functions with
7857         gdbarch.
7858
7859 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7860
7861         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7862         (riscv_unwind_pc): Delete.
7863         (riscv_unwind_sp): Delete.
7864         (riscv_gdbarch_init): Don't register deleted functions with
7865         gdbarch.
7866
7867 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7868
7869         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7870         (csky_unwind_pc): Delete.
7871         (csky_unwind_sp): Delete.
7872         (csky_gdbarch_init): Don't register deleted functions with
7873         gdbarch.
7874
7875 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7876
7877         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7878         (cris_unwind_pc): Delete.
7879         (cris_unwind_sp): Delete.
7880         (cris_gdbarch_init): Don't register deleted functions with
7881         gdbarch.
7882
7883 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7884
7885         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7886         (bfin_unwind_pc): Delete.
7887         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7888
7889 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7890
7891         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7892         (arm_unwind_pc): Delete.
7893         (arm_unwind_sp): Delete.
7894         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7895
7896 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7897
7898         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7899         (arc_unwind_pc): Delete.
7900         (arc_unwind_sp): Delete.
7901         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7902
7903 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7904
7905         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7906         (alpha_unwind_pc): Delete.
7907         (alpha_gdbarch_init): Don't register deleted functions with
7908         gdbarch.
7909
7910 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7911
7912         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7913         (aarch64_unwind_pc): Delete.
7914         (aarch64_unwind_sp): Delete.
7915         (aarch64_gdbarch_init): Don't register deleted functions with
7916         gdbarch.
7917
7918 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7919
7920         * gdbtypes.c (type_align): Don't consider static members when
7921         computing structure alignment.
7922
7923 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7924
7925         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7926         return 0 for other types.
7927         * arch-utils.c (default_type_align): Always return 0.
7928         * gdbarch.h: Regenerate.
7929         * gdbarch.sh (type_align): Extend comment.
7930         * gdbtypes.c (type_align): Add additional comments, always call
7931         gdbarch_type_align before applying the default rules.
7932         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7933         generic code will then apply a suitable default.
7934         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7935         types, return 0 for other types.
7936
7937 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7938
7939         * NEWS: Create a new section for the next release branch.
7940         Rename the section of the current branch, now that it has
7941         been cut.
7942
7943 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7944
7945         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7946         * version.in: Bump version to 8.3.50.DATE-git.
7947
7948 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7949
7950         * aix-thread.c (ptid_cmp): Remove unused variable.
7951         (get_signaled_thread): Likewise.
7952         (store_regs_user_thread): Likewise.
7953         (store_regs_kernel_thread): Likewise.
7954         (fetch_regs_kernel_thread): Remove shadowed variable.
7955
7956 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7957
7958         * features/riscv/32bit-cpu.xml: Add register numbers.
7959         * features/riscv/32bit-fpu.c: Regenerate.
7960         * features/riscv/32bit-fpu.xml: Add register numbers.
7961         * features/riscv/64bit-cpu.xml: Add register numbers.
7962         * features/riscv/64bit-fpu.c: Regenerate.
7963         * features/riscv/64bit-fpu.xml: Add register numbers.
7964
7965 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7966
7967         * NEWS: Mention two argument form of gdb.Value constructor.
7968         * python/py-value.c (convert_buffer_and_type_to_value): New
7969         function.
7970         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7971         Add support for handling an optional second argument.  Call
7972         convert_buffer_and_type_to_value as appropriate.
7973         * python/python-internal.h (Py_buffer_deleter): New struct.
7974         (Py_buffer_up): New typedef.
7975
7976 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7977
7978         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7979         instead of releasing ownership.
7980
7981 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7982
7983         * dwarf2read.c (open_and_init_dwp_file): Call
7984         elf_numsections instead of bfd_count_sections to initialize
7985         dwp_file->num_sections.
7986
7987 2019-02-25  Tom Tromey  <tromey@adacore.com>
7988
7989         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7990
7991 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7992
7993         * gcore.in: Add '--readnever' option when invoking GDB.
7994
7995 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7996
7997         * MAINTAINERS: Update my email address.
7998
7999 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8000
8001         * build-id.c (build_id_to_debug_bfd_1): New function.
8002         (build_id_to_debug_bfd): Look for separate debug file in
8003         sysroot.
8004
8005 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8006
8007         * gdbarch.sh: Update the copyright year range that is placed into
8008         generated files.
8009
8010 2019-02-22  Keith Seitz  <keiths@redhat.com>
8011
8012         PR symtab/23853
8013         * linespec.c (create_sals_line_offset): Search for the default
8014         symtab's filename instead of its fullname.
8015
8016 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8017
8018         * NEWS: Update style defaults.
8019
8020 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8021
8022         * main.c (captured_main_1): Disable styling in batch mode.
8023
8024 2019-02-20  Tom Tromey  <tom@tromey.com>
8025
8026         * symtab.c (symtab_symbol_info): Fix typos.
8027
8028 2019-02-20  Tom Tromey  <tromey@adacore.com>
8029
8030         * findcmd.c (_initialize_mem_search): Use upper case for
8031         metasyntactic variables.
8032
8033 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8034
8035         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8036         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8037
8038 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8039
8040         * top.h (source_file_name): Change to std::string.
8041         * top.c (source_file_name): Likewise.
8042         (command_line_input): Adjust.
8043         * cli/cli-script.c (script_from_file): Adjust.
8044
8045 2019-02-19  Tom Tromey  <tromey@adacore.com>
8046
8047         * ravenscar-thread.c
8048         (ravenscar_thread_target::update_thread_list): Don't call
8049         ada_build_task_list.
8050         * ada-lang.h (ada_build_task_list): Don't declare.
8051         * ada-tasks.c (struct ada_tasks_inferior_data)
8052         <task_list_valid_p>: Now bool.
8053         (read_known_tasks, ada_task_list_changed)
8054         (ada_tasks_invalidate_inferior_data): Update.
8055         (read_known_tasks_array): Return bool.
8056         (read_known_tasks_list): Likewise.
8057         (read_known_tasks): Return void.
8058         (ada_build_task_list): Now static.
8059
8060 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8061
8062         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8063         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8064
8065 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8066
8067         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8068         variant for ada_tasks_pspace_data_handle and
8069         ada_tasks_inferior_data_handle.
8070         (ada_tasks_pspace_data_cleanup): New function.
8071         (ada_tasks_inferior_data_cleanup): New function.
8072
8073 2019-02-17  Tom Tromey  <tom@tromey.com>
8074
8075         * macrotab.h (macro_source_fullname): Return a std::string.
8076         * macrotab.c (macro_include, check_for_redefinition)
8077         (macro_undef, macro_lookup_definition, foreach_macro)
8078         (foreach_macro_in_scope): Update.
8079         (macro_source_fullname): Return a std::string.
8080         * macrocmd.c (show_pp_source_pos): Update.
8081
8082 2019-02-17  Tom Tromey  <tom@tromey.com>
8083
8084         * macrocmd.c (show_pp_source_pos): Style the file names.
8085
8086 2019-02-17  Tom Tromey  <tom@tromey.com>
8087
8088         PR tui/24197:
8089         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8090
8091 2019-02-17  Tom Tromey  <tom@tromey.com>
8092
8093         * ada-lang.c (user_select_syms): Use filtered printing.
8094         * utils.c (wrap_style): New global.
8095         (desired_style): Remove.
8096         (emit_style_escape): Add stream parameter.
8097         (set_output_style, reset_terminal_style, prompt_for_continue):
8098         Update.
8099         (flush_wrap_buffer): Only flush gdb_stdout.
8100         (wrap_here): Set wrap_style.
8101         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8102         treat escape sequences as a character.  Change when wrap buffer is
8103         flushed.
8104         (fputs_styled): Do not set the output style when the default is
8105         requested.
8106         * ui-style.h (struct ui_file_style) <is_default>: New method.
8107         * source.c (print_source_lines_base): Emit escape sequences in one
8108         piece.
8109
8110 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8111
8112         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8113         integers and enumeration types.
8114
8115 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8116
8117         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8118         instead of lookup_symbol_in_language
8119         (do_exact_match): New function.
8120         (ada_get_symbol_name_matcher): Return do_exact_match when
8121         doing a verbatim match.
8122
8123 2019-02-15  Tom Tromey  <tromey@adacore.com>
8124
8125         * ravenscar-thread.c (ravenscar_thread_target::resume)
8126         (ravenscar_thread_target::wait): Special case wildcard requests.
8127
8128 2019-02-15  Tom Tromey  <tromey@adacore.com>
8129
8130         * ravenscar-thread.c (base_ptid): Remove.
8131         (struct ravenscar_thread_target) <close>: New method.
8132         <m_base_ptid>: New member.
8133         <update_inferior_ptid, active_task, task_is_currently_active,
8134         runtime_initialized>: Declare methods.
8135         <ravenscar_thread_target>: Add constructor.
8136         (ravenscar_thread_target::task_is_currently_active)
8137         (ravenscar_thread_target::update_inferior_ptid)
8138         (ravenscar_runtime_initialized): Rename.  Now methods.
8139         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8140         (ravenscar_thread_target::update_thread_list): Update.
8141         (ravenscar_thread_target::active_task): Now method.
8142         (ravenscar_thread_target::store_registers)
8143         (ravenscar_thread_target::prepare_to_store)
8144         (ravenscar_thread_target::prepare_to_store)
8145         (ravenscar_thread_target::mourn_inferior): Update.
8146         (ravenscar_inferior_created): Use "new" to create target.
8147         (ravenscar_thread_target::get_ada_task_ptid): Update.
8148         (_initialize_ravenscar): Don't initialize base_ptid.
8149         (ravenscar_ops): Remove global.
8150
8151 2019-02-15  Tom Tromey  <tromey@adacore.com>
8152
8153         * target.h (push_target): Declare new overload.
8154         * target.c (push_target): New overload, taking an rvalue reference.
8155         * remote.c (remote_target::open_1): Use push_target overload.
8156         * corelow.c (core_target_open): Use push_target overload.
8157
8158 2019-02-15  Tom Tromey  <tromey@adacore.com>
8159
8160         * ravenscar-thread.c (is_ravenscar_task)
8161         (ravenscar_task_is_currently_active): Return bool.
8162         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8163         (_initialize_ravenscar): Remove "(void)".
8164         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8165         Return bool.
8166
8167 2019-02-15  Tom Tromey  <tromey@adacore.com>
8168
8169         * ravenscar-thread.c (ravenscar_runtime_initializer)
8170         (has_ravenscar_runtime, get_running_thread_id)
8171         (ravenscar_thread_target::resume): Fix indentation.
8172
8173 2019-02-15  Tom Tromey  <tromey@adacore.com>
8174
8175         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8176         from ravenscar_arch_ops.
8177         (sparc_ravenscar_ops::fetch_registers)
8178         (sparc_ravenscar_ops::store_registers): Now methods.
8179         (sparc_ravenscar_prepare_to_store): Remove.
8180         (sparc_ravenscar_ops): Redefine.
8181         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8182         methods and destructor.  Remove members.
8183         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8184         (ravenscar_thread_target::store_registers)
8185         (ravenscar_thread_target::prepare_to_store): Update.
8186         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8187         Remove.
8188         (struct ppc_ravenscar_powerpc_ops): Derive from
8189         ravenscar_arch_ops.
8190         (ppc_ravenscar_powerpc_ops::fetch_registers)
8191         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8192         (ppc_ravenscar_powerpc_ops): Redefine.
8193         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8194         (ppc_ravenscar_e500_ops::fetch_registers)
8195         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8196         (ppc_ravenscar_e500_ops): Redefine.
8197         * aarch64-ravenscar-thread.c
8198         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8199         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8200         (aarch64_ravenscar_fetch_registers)
8201         (aarch64_ravenscar_store_registers): Now methods.
8202         (aarch64_ravenscar_ops): Redefine.
8203
8204 2019-02-15  Tom Tromey  <tromey@adacore.com>
8205
8206         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8207         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8208         (ravenscar_thread_target::stopped_by_watchpoint)
8209         (ravenscar_thread_target::stopped_data_address)
8210         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8211
8212 2019-02-15  Tom Tromey  <tromey@adacore.com>
8213
8214         * ravenscar-thread.c: Fix some typos.
8215
8216 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8217             Tom Tromey  <tromey@adacore.com>
8218
8219         * ada-lang.c (ada_exception_sal): Change addr_string to a
8220         std::string.
8221         (create_ada_exception_catchpoint): Update.
8222
8223 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8224             Tom Tromey  <tromey@adacore.com>
8225
8226         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8227         (bp_location_ops): Remove.
8228         (base_breakpoint_allocate_location): Update.
8229         (free_bp_location): Update.
8230         * ada-lang.c (class ada_catchpoint_location)
8231         <ada_catchpoint_location>: Remove ops parameter.
8232         (ada_catchpoint_location_dtor): Remove.
8233         (ada_catchpoint_location_ops): Remove.
8234         (allocate_location_exception): Update.
8235         * breakpoint.h (struct bp_location_ops): Remove.
8236         (class bp_location) <bp_location>: Remove bp_location_ops
8237         parameter.
8238         <~bp_location>: Add destructor.
8239         <ops>: Remove.
8240
8241 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8242             Pedro Alves  <palves@redhat.com>
8243
8244         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8245         'PATH_MAX'.
8246
8247 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8248             Samuel Thibault  <samuel.thibault@gnu.org>
8249             Thomas Schwinge  <thomas@codesourcery.com>
8250
8251         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8252         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8253
8254 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8255
8256         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8257         (check_empty): Use "const char *".
8258
8259         * gnu-nat.c (gnu_nat_target::detach): Instead of
8260         'detach_inferior (pid)' call
8261         'detach_inferior (find_inferior_pid (pid))'.
8262
8263         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8264         'nat/fork-inferior.o'.
8265         * gnu-nat.c: #include "nat/fork-inferior.h".
8266
8267         * gnu-nat.c (gnu_nat_target::detach): Instead of
8268         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8269         * gnu-nat.h: #include "inf-child.h".
8270         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8271         'i386_gnu_nat_target::fetch_registers'.
8272         (gnu_store_registers): Rename/move to
8273         'i386_gnu_nat_target::store_registers'.
8274
8275         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8276         * gnu-nat.h (mach_thread_info): New function.
8277         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8278
8279         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8280
8281 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8282
8283         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8284
8285 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8286
8287         * windows-nat.c (windows_add_thread): Add new parameter
8288         "main_thread_p" with default value set to false.  Update
8289         function documentation as well as all callers.
8290         (windows_delete_thread): Likewise.
8291         (fake_create_process): Update call to windows_add_thread.
8292         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8293         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8294         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8295         call to windows_delete_thread.
8296
8297 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8298
8299         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8300
8301 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8302
8303         * symfile.c (find_separate_debug_file): Use canonical path of
8304         sysroot with child_path instead of gdb_sysroot if it is valid.
8305
8306 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8307
8308         * symfile.c (find_separate_debug_file): Use child_path to
8309         determine if an object file is under a sysroot.
8310
8311 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8312
8313         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8314         unittests/child-path-selftests.c.
8315         * common/pathstuff.c (child_path): New function.
8316         * common/pathstuff.h (child_path): New prototype.
8317         * unittests/child-path-selftests.c: New file.
8318
8319 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8320
8321         * symfile.c (find_separate_debug_file): Look for separate debug
8322         files in debug directories under the sysroot.
8323
8324 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8325
8326         * symtab.h (struct minimal_symbol data_p): New const method.
8327         (struct minimal_symbol text_p): Likewise.
8328         * symtab.c (output_source_filename): Use file name style
8329         to print file name.
8330         (print_symbol_info): Likewise.
8331         (print_msymbol_info): Use address style to print addresses.
8332         Use function name style to print executable text symbols.
8333         (expand_symtab_containing_pc): Use data_p.
8334         (find_pc_sect_compunit_symtab): Likewise.
8335
8336 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8337
8338         * breakpoint.c (describe_other_breakpoints): Use address style
8339         to print addresses.
8340         (say_where): Likewise.
8341
8342 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8343
8344         * ada-typeprint.c (print_func_type): Print function name
8345         style to print function name.
8346         * c-typeprint.c (c_print_type_1): Likewise.
8347
8348 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8349
8350         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8351         for execve.
8352
8353 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8354
8355         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8356         type_stack.
8357
8358 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8359
8360         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8361         TYPE_CODE_REF types.
8362
8363 2019-02-08  Jim Wilson  <jimw@sifive.com>
8364
8365         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8366         (riscv_linux_fregset): New.
8367         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8368
8369 2019-02-07  Tom Tromey  <tom@tromey.com>
8370
8371         * thread.c (thread_cancel_execution_command): Update.
8372         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8373         methods.
8374         (struct thread_fsm_ops): Remove.
8375         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8376         (thread_fsm_should_stop, thread_fsm_return_value)
8377         (thread_fsm_set_finished, thread_fsm_finished_p)
8378         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8379         Don't declare.
8380         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8381         * infrun.c (clear_proceed_status_thread)
8382         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8383         (print_stop_event): Update.
8384         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8385         Add constructor.
8386         (step_command_fsm_ops): Remove.
8387         (new_step_command_fsm): Remove.
8388         (step_1): Update.
8389         (step_command_fsm::should_stop): Rename from
8390         step_command_fsm_should_stop.
8391         (step_command_fsm::clean_up): Rename from
8392         step_command_fsm_clean_up.
8393         (step_command_fsm::do_async_reply_reason): Rename from
8394         step_command_fsm_async_reply_reason.
8395         (struct until_next_fsm): Inherit from thread_fsm.  Add
8396         constructor.
8397         (until_next_fsm_ops): Remove.
8398         (new_until_next_fsm): Remove.
8399         (until_next_fsm::should_stop): Rename from
8400         until_next_fsm_should_stop.
8401         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8402         (until_next_fsm::do_async_reply_reason): Rename from
8403         until_next_fsm_async_reply_reason.
8404         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8405         constructor.  Change type of breakpoint.
8406         (finish_command_fsm_ops): Remove.
8407         (new_finish_command_fsm): Remove.
8408         (finish_command_fsm::should_stop): Rename from
8409         finish_command_fsm_should_stop.
8410         (finish_command_fsm::clean_up): Rename from
8411         finish_command_fsm_clean_up.
8412         (finish_command_fsm::return_value): Rename from
8413         finish_command_fsm_return_value.
8414         (finish_command_fsm::do_async_reply_reason): Rename from
8415         finish_command_fsm_async_reply_reason.
8416         (finish_command): Update.
8417         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8418         Add constructor.
8419         (call_thread_fsm_ops): Remove.
8420         (call_thread_fsm::call_thread_fsm): Rename from
8421         new_call_thread_fsm.
8422         (call_thread_fsm::should_stop): Rename from
8423         call_thread_fsm_should_stop.
8424         (call_thread_fsm::should_notify_stop): Rename from
8425         call_thread_fsm_should_notify_stop.
8426         (run_inferior_call, call_function_by_hand_dummy): Update.
8427         * cli/cli-interp.c (should_print_stop_to_console): Update.
8428         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8429         Add constructor.  Change type of location_breakpoint,
8430         caller_breakpoint.
8431         (until_break_fsm_ops): Remove.
8432         (new_until_break_fsm): Remove.
8433         (until_break_fsm::should_stop): Rename from
8434         until_break_fsm_should_stop.
8435         (until_break_fsm::clean_up): Rename from
8436         until_break_fsm_clean_up.
8437         (until_break_fsm::do_async_reply_reason): Rename from
8438         until_break_fsm_async_reply_reason.
8439         (until_break_command): Update.
8440         * thread-fsm.c: Remove.
8441         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8442
8443 2019-02-07  Tom Tromey  <tom@tromey.com>
8444
8445         * yy-remap.h: Add include guard.
8446         * xtensa-tdep.h: Add include guard.
8447         * xcoffread.h: Rename include guard.
8448         * varobj-iter.h: Add include guard.
8449         * tui/tui.h: Rename include guard.
8450         * tui/tui-winsource.h: Rename include guard.
8451         * tui/tui-wingeneral.h: Rename include guard.
8452         * tui/tui-windata.h: Rename include guard.
8453         * tui/tui-win.h: Rename include guard.
8454         * tui/tui-stack.h: Rename include guard.
8455         * tui/tui-source.h: Rename include guard.
8456         * tui/tui-regs.h: Rename include guard.
8457         * tui/tui-out.h: Rename include guard.
8458         * tui/tui-layout.h: Rename include guard.
8459         * tui/tui-io.h: Rename include guard.
8460         * tui/tui-hooks.h: Rename include guard.
8461         * tui/tui-file.h: Rename include guard.
8462         * tui/tui-disasm.h: Rename include guard.
8463         * tui/tui-data.h: Rename include guard.
8464         * tui/tui-command.h: Rename include guard.
8465         * tic6x-tdep.h: Add include guard.
8466         * target/waitstatus.h: Rename include guard.
8467         * target/wait.h: Rename include guard.
8468         * target/target.h: Rename include guard.
8469         * target/resume.h: Rename include guard.
8470         * target-float.h: Rename include guard.
8471         * stabsread.h: Add include guard.
8472         * rs6000-tdep.h: Add include guard.
8473         * riscv-fbsd-tdep.h: Add include guard.
8474         * regformats/regdef.h: Rename include guard.
8475         * record.h: Rename include guard.
8476         * python/python.h: Rename include guard.
8477         * python/python-internal.h: Rename include guard.
8478         * python/py-stopevent.h: Rename include guard.
8479         * python/py-ref.h: Rename include guard.
8480         * python/py-record.h: Rename include guard.
8481         * python/py-record-full.h: Rename include guard.
8482         * python/py-record-btrace.h: Rename include guard.
8483         * python/py-instruction.h: Rename include guard.
8484         * python/py-events.h: Rename include guard.
8485         * python/py-event.h: Rename include guard.
8486         * procfs.h: Add include guard.
8487         * proc-utils.h: Add include guard.
8488         * p-lang.h: Add include guard.
8489         * or1k-tdep.h: Rename include guard.
8490         * observable.h: Rename include guard.
8491         * nto-tdep.h: Rename include guard.
8492         * nat/x86-linux.h: Rename include guard.
8493         * nat/x86-linux-dregs.h: Rename include guard.
8494         * nat/x86-gcc-cpuid.h: Add include guard.
8495         * nat/x86-dregs.h: Rename include guard.
8496         * nat/x86-cpuid.h: Rename include guard.
8497         * nat/ppc-linux.h: Rename include guard.
8498         * nat/mips-linux-watch.h: Rename include guard.
8499         * nat/linux-waitpid.h: Rename include guard.
8500         * nat/linux-ptrace.h: Rename include guard.
8501         * nat/linux-procfs.h: Rename include guard.
8502         * nat/linux-osdata.h: Rename include guard.
8503         * nat/linux-nat.h: Rename include guard.
8504         * nat/linux-namespaces.h: Rename include guard.
8505         * nat/linux-btrace.h: Rename include guard.
8506         * nat/glibc_thread_db.h: Rename include guard.
8507         * nat/gdb_thread_db.h: Rename include guard.
8508         * nat/gdb_ptrace.h: Rename include guard.
8509         * nat/fork-inferior.h: Rename include guard.
8510         * nat/amd64-linux-siginfo.h: Rename include guard.
8511         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8512         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8513         * nat/aarch64-linux.h: Rename include guard.
8514         * nat/aarch64-linux-hw-point.h: Rename include guard.
8515         * mn10300-tdep.h: Add include guard.
8516         * mips-linux-tdep.h: Add include guard.
8517         * mi/mi-parse.h: Rename include guard.
8518         * mi/mi-out.h: Rename include guard.
8519         * mi/mi-main.h: Rename include guard.
8520         * mi/mi-interp.h: Rename include guard.
8521         * mi/mi-getopt.h: Rename include guard.
8522         * mi/mi-console.h: Rename include guard.
8523         * mi/mi-common.h: Rename include guard.
8524         * mi/mi-cmds.h: Rename include guard.
8525         * mi/mi-cmd-break.h: Rename include guard.
8526         * m2-lang.h: Add include guard.
8527         * location.h: Rename include guard.
8528         * linux-record.h: Rename include guard.
8529         * linux-nat.h: Add include guard.
8530         * linux-fork.h: Add include guard.
8531         * i386-darwin-tdep.h: Rename include guard.
8532         * hppa-linux-offsets.h: Add include guard.
8533         * guile/guile.h: Rename include guard.
8534         * guile/guile-internal.h: Rename include guard.
8535         * gnu-nat.h: Rename include guard.
8536         * gdb-stabs.h: Rename include guard.
8537         * frv-tdep.h: Add include guard.
8538         * f-lang.h: Add include guard.
8539         * event-loop.h: Add include guard.
8540         * darwin-nat.h: Rename include guard.
8541         * cp-abi.h: Rename include guard.
8542         * config/sparc/nm-sol2.h: Rename include guard.
8543         * config/nm-nto.h: Rename include guard.
8544         * config/nm-linux.h: Add include guard.
8545         * config/i386/nm-i386gnu.h: Rename include guard.
8546         * config/djgpp/nl_types.h: Rename include guard.
8547         * config/djgpp/langinfo.h: Rename include guard.
8548         * compile/gcc-cp-plugin.h: Add include guard.
8549         * compile/gcc-c-plugin.h: Add include guard.
8550         * compile/compile.h: Rename include guard.
8551         * compile/compile-object-run.h: Rename include guard.
8552         * compile/compile-object-load.h: Rename include guard.
8553         * compile/compile-internal.h: Rename include guard.
8554         * compile/compile-cplus.h: Rename include guard.
8555         * compile/compile-c.h: Rename include guard.
8556         * common/xml-utils.h: Rename include guard.
8557         * common/x86-xstate.h: Rename include guard.
8558         * common/version.h: Rename include guard.
8559         * common/vec.h: Rename include guard.
8560         * common/tdesc.h: Rename include guard.
8561         * common/selftest.h: Rename include guard.
8562         * common/scoped_restore.h: Rename include guard.
8563         * common/scoped_mmap.h: Rename include guard.
8564         * common/scoped_fd.h: Rename include guard.
8565         * common/safe-iterator.h: Rename include guard.
8566         * common/run-time-clock.h: Rename include guard.
8567         * common/refcounted-object.h: Rename include guard.
8568         * common/queue.h: Rename include guard.
8569         * common/ptid.h: Rename include guard.
8570         * common/print-utils.h: Rename include guard.
8571         * common/preprocessor.h: Rename include guard.
8572         * common/pathstuff.h: Rename include guard.
8573         * common/observable.h: Rename include guard.
8574         * common/netstuff.h: Rename include guard.
8575         * common/job-control.h: Rename include guard.
8576         * common/host-defs.h: Rename include guard.
8577         * common/gdb_wait.h: Rename include guard.
8578         * common/gdb_vecs.h: Rename include guard.
8579         * common/gdb_unlinker.h: Rename include guard.
8580         * common/gdb_unique_ptr.h: Rename include guard.
8581         * common/gdb_tilde_expand.h: Rename include guard.
8582         * common/gdb_sys_time.h: Rename include guard.
8583         * common/gdb_string_view.h: Rename include guard.
8584         * common/gdb_splay_tree.h: Rename include guard.
8585         * common/gdb_setjmp.h: Rename include guard.
8586         * common/gdb_ref_ptr.h: Rename include guard.
8587         * common/gdb_optional.h: Rename include guard.
8588         * common/gdb_locale.h: Rename include guard.
8589         * common/gdb_assert.h: Rename include guard.
8590         * common/filtered-iterator.h: Rename include guard.
8591         * common/filestuff.h: Rename include guard.
8592         * common/fileio.h: Rename include guard.
8593         * common/environ.h: Rename include guard.
8594         * common/common-utils.h: Rename include guard.
8595         * common/common-types.h: Rename include guard.
8596         * common/common-regcache.h: Rename include guard.
8597         * common/common-inferior.h: Rename include guard.
8598         * common/common-gdbthread.h: Rename include guard.
8599         * common/common-exceptions.h: Rename include guard.
8600         * common/common-defs.h: Rename include guard.
8601         * common/common-debug.h: Rename include guard.
8602         * common/cleanups.h: Rename include guard.
8603         * common/buffer.h: Rename include guard.
8604         * common/btrace-common.h: Rename include guard.
8605         * common/break-common.h: Rename include guard.
8606         * cli/cli-utils.h: Rename include guard.
8607         * cli/cli-style.h: Rename include guard.
8608         * cli/cli-setshow.h: Rename include guard.
8609         * cli/cli-script.h: Rename include guard.
8610         * cli/cli-interp.h: Rename include guard.
8611         * cli/cli-decode.h: Rename include guard.
8612         * cli/cli-cmds.h: Rename include guard.
8613         * charset-list.h: Add include guard.
8614         * buildsym-legacy.h: Rename include guard.
8615         * bfin-tdep.h: Add include guard.
8616         * ax.h: Rename include guard.
8617         * arm-linux-tdep.h: Add include guard.
8618         * arm-fbsd-tdep.h: Add include guard.
8619         * arch/xtensa.h: Rename include guard.
8620         * arch/tic6x.h: Add include guard.
8621         * arch/i386.h: Add include guard.
8622         * arch/arm.h: Rename include guard.
8623         * arch/arm-linux.h: Rename include guard.
8624         * arch/arm-get-next-pcs.h: Rename include guard.
8625         * arch/amd64.h: Add include guard.
8626         * arch/aarch64-insn.h: Rename include guard.
8627         * arch-utils.h: Rename include guard.
8628         * annotate.h: Add include guard.
8629         * amd64-darwin-tdep.h: Rename include guard.
8630         * aarch64-linux-tdep.h: Add include guard.
8631         * aarch64-fbsd-tdep.h: Add include guard.
8632         * aarch32-linux-nat.h: Add include guard.
8633
8634 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8635
8636         * macrotab.c (macro_define_internal): New function that
8637         factorizes macro_define_object_internal and macro_define_function
8638         code.
8639         (macro_define_object_internal): Use macro_define_internal.
8640         (macro_define_function): Likewise.
8641
8642 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8643
8644         * macrocmd.c (extract_identifier): Return
8645         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8646         callers.
8647
8648 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8649
8650         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8651
8652 2019-02-05  Tom Tromey  <tom@tromey.com>
8653
8654         * target.c (target_stack::unpush): Move assertion earlier.
8655
8656 2019-01-30  Tom Tromey  <tom@tromey.com>
8657
8658         PR python/23615:
8659         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8660         (gdbpy_parse_and_eval): Likewise.
8661         * python/python-internal.h (gdbpy_allow_threads): New class.
8662
8663 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8664
8665         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8666         (aarch64_fbsd_fpregmap): Move earlier.
8667         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8668         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8669         instead of individual calls to trad_frame_set_reg_addr.
8670         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8671         earlier.
8672         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8673         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8674         instead of individual calls to trad_frame_set_reg_addr.
8675
8676 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8677
8678         * CONTRIBUTE: Replace contribution list with wiki link.
8679
8680 2019-01-25  Tom Tromey  <tom@tromey.com>
8681
8682         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8683
8684 2019-01-25  Tom Tromey  <tom@tromey.com>
8685
8686         * xtensa-linux-nat.c: Fix common/ includes.
8687         * xml-support.h: Fix common/ includes.
8688         * xml-support.c: Fix common/ includes.
8689         * x86-linux-nat.c: Fix common/ includes.
8690         * windows-nat.c: Fix common/ includes.
8691         * varobj.h: Fix common/ includes.
8692         * varobj.c: Fix common/ includes.
8693         * value.c: Fix common/ includes.
8694         * valops.c: Fix common/ includes.
8695         * utils.c: Fix common/ includes.
8696         * unittests/xml-utils-selftests.c: Fix common/ includes.
8697         * unittests/utils-selftests.c: Fix common/ includes.
8698         * unittests/unpack-selftests.c: Fix common/ includes.
8699         * unittests/tracepoint-selftests.c: Fix common/ includes.
8700         * unittests/style-selftests.c: Fix common/ includes.
8701         * unittests/string_view-selftests.c: Fix common/ includes.
8702         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8703         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8704         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8705         * unittests/rsp-low-selftests.c: Fix common/ includes.
8706         * unittests/parse-connection-spec-selftests.c: Fix common/
8707         includes.
8708         * unittests/optional-selftests.c: Fix common/ includes.
8709         * unittests/offset-type-selftests.c: Fix common/ includes.
8710         * unittests/observable-selftests.c: Fix common/ includes.
8711         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8712         * unittests/memrange-selftests.c: Fix common/ includes.
8713         * unittests/memory-map-selftests.c: Fix common/ includes.
8714         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8715         * unittests/function-view-selftests.c: Fix common/ includes.
8716         * unittests/environ-selftests.c: Fix common/ includes.
8717         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8718         * unittests/common-utils-selftests.c: Fix common/ includes.
8719         * unittests/cli-utils-selftests.c: Fix common/ includes.
8720         * unittests/array-view-selftests.c: Fix common/ includes.
8721         * ui-file.c: Fix common/ includes.
8722         * tui/tui-io.c: Fix common/ includes.
8723         * tracepoint.h: Fix common/ includes.
8724         * tracepoint.c: Fix common/ includes.
8725         * tracefile-tfile.c: Fix common/ includes.
8726         * top.h: Fix common/ includes.
8727         * top.c: Fix common/ includes.
8728         * thread.c: Fix common/ includes.
8729         * target/waitstatus.h: Fix common/ includes.
8730         * target/waitstatus.c: Fix common/ includes.
8731         * target.h: Fix common/ includes.
8732         * target.c: Fix common/ includes.
8733         * target-memory.c: Fix common/ includes.
8734         * target-descriptions.c: Fix common/ includes.
8735         * symtab.h: Fix common/ includes.
8736         * symfile.c: Fix common/ includes.
8737         * stap-probe.c: Fix common/ includes.
8738         * spu-linux-nat.c: Fix common/ includes.
8739         * sparc-nat.c: Fix common/ includes.
8740         * source.c: Fix common/ includes.
8741         * solib.c: Fix common/ includes.
8742         * solib-target.c: Fix common/ includes.
8743         * ser-unix.c: Fix common/ includes.
8744         * ser-tcp.c: Fix common/ includes.
8745         * ser-pipe.c: Fix common/ includes.
8746         * ser-base.c: Fix common/ includes.
8747         * selftest-arch.c: Fix common/ includes.
8748         * s12z-tdep.c: Fix common/ includes.
8749         * rust-exp.y: Fix common/ includes.
8750         * rs6000-aix-tdep.c: Fix common/ includes.
8751         * riscv-tdep.c: Fix common/ includes.
8752         * remote.c: Fix common/ includes.
8753         * remote-notif.h: Fix common/ includes.
8754         * remote-fileio.h: Fix common/ includes.
8755         * remote-fileio.c: Fix common/ includes.
8756         * regcache.h: Fix common/ includes.
8757         * regcache.c: Fix common/ includes.
8758         * record-btrace.c: Fix common/ includes.
8759         * python/python.c: Fix common/ includes.
8760         * python/py-type.c: Fix common/ includes.
8761         * python/py-inferior.c: Fix common/ includes.
8762         * progspace.h: Fix common/ includes.
8763         * producer.c: Fix common/ includes.
8764         * procfs.c: Fix common/ includes.
8765         * proc-api.c: Fix common/ includes.
8766         * printcmd.c: Fix common/ includes.
8767         * ppc-linux-nat.c: Fix common/ includes.
8768         * parser-defs.h: Fix common/ includes.
8769         * osdata.c: Fix common/ includes.
8770         * obsd-nat.c: Fix common/ includes.
8771         * nat/x86-linux.c: Fix common/ includes.
8772         * nat/x86-linux-dregs.c: Fix common/ includes.
8773         * nat/x86-dregs.h: Fix common/ includes.
8774         * nat/x86-dregs.c: Fix common/ includes.
8775         * nat/ppc-linux.c: Fix common/ includes.
8776         * nat/mips-linux-watch.h: Fix common/ includes.
8777         * nat/mips-linux-watch.c: Fix common/ includes.
8778         * nat/linux-waitpid.c: Fix common/ includes.
8779         * nat/linux-ptrace.h: Fix common/ includes.
8780         * nat/linux-ptrace.c: Fix common/ includes.
8781         * nat/linux-procfs.c: Fix common/ includes.
8782         * nat/linux-personality.c: Fix common/ includes.
8783         * nat/linux-osdata.c: Fix common/ includes.
8784         * nat/linux-namespaces.c: Fix common/ includes.
8785         * nat/linux-btrace.h: Fix common/ includes.
8786         * nat/linux-btrace.c: Fix common/ includes.
8787         * nat/fork-inferior.c: Fix common/ includes.
8788         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8789         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8790         * nat/aarch64-linux.c: Fix common/ includes.
8791         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8792         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8793         * namespace.h: Fix common/ includes.
8794         * mips-linux-tdep.c: Fix common/ includes.
8795         * minsyms.c: Fix common/ includes.
8796         * mi/mi-parse.h: Fix common/ includes.
8797         * mi/mi-main.c: Fix common/ includes.
8798         * mi/mi-cmd-env.c: Fix common/ includes.
8799         * memrange.h: Fix common/ includes.
8800         * memattr.c: Fix common/ includes.
8801         * maint.h: Fix common/ includes.
8802         * maint.c: Fix common/ includes.
8803         * main.c: Fix common/ includes.
8804         * machoread.c: Fix common/ includes.
8805         * location.c: Fix common/ includes.
8806         * linux-thread-db.c: Fix common/ includes.
8807         * linux-nat.c: Fix common/ includes.
8808         * linux-fork.c: Fix common/ includes.
8809         * inline-frame.c: Fix common/ includes.
8810         * infrun.c: Fix common/ includes.
8811         * inflow.c: Fix common/ includes.
8812         * inferior.h: Fix common/ includes.
8813         * inferior.c: Fix common/ includes.
8814         * infcmd.c: Fix common/ includes.
8815         * inf-ptrace.c: Fix common/ includes.
8816         * inf-child.c: Fix common/ includes.
8817         * ia64-linux-nat.c: Fix common/ includes.
8818         * i387-tdep.c: Fix common/ includes.
8819         * i386-tdep.c: Fix common/ includes.
8820         * i386-linux-tdep.c: Fix common/ includes.
8821         * i386-linux-nat.c: Fix common/ includes.
8822         * i386-go32-tdep.c: Fix common/ includes.
8823         * i386-fbsd-tdep.c: Fix common/ includes.
8824         * i386-fbsd-nat.c: Fix common/ includes.
8825         * guile/scm-type.c: Fix common/ includes.
8826         * guile/guile.c: Fix common/ includes.
8827         * go32-nat.c: Fix common/ includes.
8828         * gnu-nat.c: Fix common/ includes.
8829         * gdbthread.h: Fix common/ includes.
8830         * gdbarch-selftests.c: Fix common/ includes.
8831         * gdb_usleep.c: Fix common/ includes.
8832         * gdb_select.h: Fix common/ includes.
8833         * gdb_bfd.c: Fix common/ includes.
8834         * gcore.c: Fix common/ includes.
8835         * fork-child.c: Fix common/ includes.
8836         * findvar.c: Fix common/ includes.
8837         * fbsd-nat.c: Fix common/ includes.
8838         * event-top.c: Fix common/ includes.
8839         * event-loop.c: Fix common/ includes.
8840         * dwarf2read.c: Fix common/ includes.
8841         * dwarf2loc.c: Fix common/ includes.
8842         * dwarf2-frame.c: Fix common/ includes.
8843         * dwarf-index-cache.c: Fix common/ includes.
8844         * dtrace-probe.c: Fix common/ includes.
8845         * disasm-selftests.c: Fix common/ includes.
8846         * defs.h: Fix common/ includes.
8847         * csky-tdep.c: Fix common/ includes.
8848         * cp-valprint.c: Fix common/ includes.
8849         * cp-support.h: Fix common/ includes.
8850         * cp-support.c: Fix common/ includes.
8851         * corelow.c: Fix common/ includes.
8852         * completer.h: Fix common/ includes.
8853         * completer.c: Fix common/ includes.
8854         * compile/compile.c: Fix common/ includes.
8855         * compile/compile-loc2c.c: Fix common/ includes.
8856         * compile/compile-cplus-types.c: Fix common/ includes.
8857         * compile/compile-cplus-symbols.c: Fix common/ includes.
8858         * command.h: Fix common/ includes.
8859         * cli/cli-dump.c: Fix common/ includes.
8860         * cli/cli-cmds.c: Fix common/ includes.
8861         * charset.c: Fix common/ includes.
8862         * build-id.c: Fix common/ includes.
8863         * btrace.h: Fix common/ includes.
8864         * btrace.c: Fix common/ includes.
8865         * breakpoint.h: Fix common/ includes.
8866         * breakpoint.c: Fix common/ includes.
8867         * ax.h:
8868         (enum agent_op): Fix common/ includes.
8869         * ax-general.c (struct aop_map): Fix common/ includes.
8870         * ax-gdb.c: Fix common/ includes.
8871         * auxv.c: Fix common/ includes.
8872         * auto-load.c: Fix common/ includes.
8873         * arm-tdep.c: Fix common/ includes.
8874         * arch/riscv.c: Fix common/ includes.
8875         * arch/ppc-linux-common.c: Fix common/ includes.
8876         * arch/i386.c: Fix common/ includes.
8877         * arch/arm.c: Fix common/ includes.
8878         * arch/arm-linux.c: Fix common/ includes.
8879         * arch/arm-get-next-pcs.c: Fix common/ includes.
8880         * arch/amd64.c: Fix common/ includes.
8881         * arch/aarch64.c: Fix common/ includes.
8882         * arch/aarch64-insn.c: Fix common/ includes.
8883         * arch-utils.c: Fix common/ includes.
8884         * amd64-windows-tdep.c: Fix common/ includes.
8885         * amd64-tdep.c: Fix common/ includes.
8886         * amd64-sol2-tdep.c: Fix common/ includes.
8887         * amd64-obsd-tdep.c: Fix common/ includes.
8888         * amd64-nbsd-tdep.c: Fix common/ includes.
8889         * amd64-linux-tdep.c: Fix common/ includes.
8890         * amd64-linux-nat.c: Fix common/ includes.
8891         * amd64-fbsd-tdep.c: Fix common/ includes.
8892         * amd64-fbsd-nat.c: Fix common/ includes.
8893         * amd64-dicos-tdep.c: Fix common/ includes.
8894         * amd64-darwin-tdep.c: Fix common/ includes.
8895         * agent.c: Fix common/ includes.
8896         * ada-lang.h: Fix common/ includes.
8897         * ada-lang.c: Fix common/ includes.
8898         * aarch64-tdep.c: Fix common/ includes.
8899
8900 2019-01-25  Tom Tromey  <tom@tromey.com>
8901
8902         * common/create-version.sh: Use common/version.h.
8903
8904 2019-01-24  Pedro Alves  <palves@redhat.com>
8905
8906         * infrun.c (signal_stop, signal_print, signal_program)
8907         (signal_catch, signal_pass): Now arrays instead of pointers.
8908         (update_signals_program_target, do_target_resume)
8909         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8910         * linux-nat.c (linux_nat_target::pass_signals)
8911         (linux_nat_target::create_inferior, linux_nat_target::attach):
8912         Adjust.
8913         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8914         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8915         * procfs.c (procfs_target::pass_signals): Adjust.
8916         * record-full.c (record_full_target::resume): Adjust.
8917         * remote.c (remote_target::pass_signals)
8918         (remote_target::program_signals): Adjust.
8919         * target-debug.h (target_debug_print_signals): Now takes a
8920         gdb::array_view as parameter.  Adjust.
8921         * target.h (target_ops) <pass_signals, program_signals>: Replace
8922         pointer and length parameters with gdb::array_view.
8923         (target_pass_signals, target_program_signals): Likewise.
8924         * target-delegates.c: Regenerate.
8925
8926 2019-01-24  Pedro Alves  <palves@redhat.com>
8927
8928         * common/forward-scope-exit.h
8929         (forward_scope_exit::forward_scope_exit): Pass arguments to
8930         m_bind_function directly, instead of creating a std::bind and
8931         copying that.
8932
8933 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8934
8935         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8936         for static members.
8937         (pass_in_v_vfp_candidate): Likewise.
8938
8939 2019-01-23  Tom Tromey  <tom@tromey.com>
8940             Pedro Alves  <palves@redhat.com>
8941
8942         * regcache.c (class regcache_invalidator): Remove.
8943         (regcache::raw_write): Use make_scope_exit.
8944
8945 2019-01-23  Tom Tromey  <tom@tromey.com>
8946
8947         * ui-out.h (class ui_out_emit_type): Update comment.
8948
8949 2019-01-23  Tom Tromey  <tom@tromey.com>
8950
8951         * infrun.c (fetch_inferior_event): Update comment.
8952
8953 2019-01-23  Tom Tromey  <tom@tromey.com>
8954             Pedro Alves  <palves@redhat.com>
8955
8956         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8957         parameter.
8958         (fetch_inferior_event): Use SCOPE_EXIT.
8959
8960
8961 2019-01-23  Tom Tromey  <tom@tromey.com>
8962             Pedro Alves  <palves@redhat.com>
8963
8964         * infrun.c (disable_thread_events): Delete.
8965         (stop_all_threads): Use SCOPE_EXIT.
8966
8967 2019-01-23  Tom Tromey  <tom@tromey.com>
8968             Pedro Alves  <palves@redhat.com>
8969
8970         * symfile.c: Include forward-scope-exit.h.
8971         (clear_symtab_users_cleanup): Replace forward declaration with
8972         a FORWARD_SCOPE_EXIT.
8973         (syms_from_objfile_1): Use the forward_scope_exit and
8974         gdb::optional instead of cleanup_function.
8975         (reread_symbols): Use the forward_scope_exit instead of
8976         cleanup_function.
8977         (clear_symtab_users_cleanup): Remove function.
8978
8979 2019-01-23  Tom Tromey  <tom@tromey.com>
8980             Pedro Alves  <palves@redhat.com>
8981
8982         * linux-nat.c: Include scope-exit.h.
8983         (cleanup_target_stop): Remove.
8984         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8985         SCOPE_EXIT.
8986
8987 2019-01-23  Tom Tromey  <tom@tromey.com>
8988             Pedro Alves  <palves@redhat.com>
8989
8990         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8991         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8992
8993 2019-01-23  Tom Tromey  <tom@tromey.com>
8994             Andrew Burgess  <andrew.burgess@embecosm.com>
8995             Pedro Alves  <palves@redhat.com>
8996
8997         * infrun.c (fetch_inferior_event): Use scope_exit.
8998         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8999         * top.c (execute_command): Use scope_exit.
9000         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9001         * utils.c (do_bpstat_clear_actions_cleanup)
9002         (make_bpstat_clear_actions_cleanup): Remove.
9003
9004 2019-01-23  Tom Tromey  <tom@tromey.com>
9005             Pedro Alves  <palves@redhat.com>
9006
9007         * infrun.c: Include "common/scope-exit.h"
9008         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9009         (wait_for_inferior): Use SCOPE_EXIT.
9010         (fetch_inferior_event): Use scope_exit.
9011
9012 2019-01-23  Tom Tromey  <tom@tromey.com>
9013             Pedro Alves  <palves@redhat.com>
9014
9015         * breakpoint.c (create_breakpoint): Remove cleanup.
9016
9017 2019-01-23  Tom Tromey  <tom@tromey.com>
9018             Andrew Burgess  <andrew.burgess@embecosm.com>
9019             Pedro Alves  <palves@redhat.com>
9020
9021 2019-01-23  Pedro Alves  <palves@redhat.com>
9022
9023         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9024
9025 2019-01-23  Pedro Alves  <palves@redhat.com>
9026             Andrew Burgess  <andrew.burgess@embecosm.com>
9027
9028         * gdbthread.h: Include "common/forward-scope-exit.h".
9029         (scoped_finish_thread_state): Redefine custom class in terms of
9030         forward_scope_exit.
9031
9032 2019-01-23  Pedro Alves  <palves@redhat.com>
9033             Andrew Burgess  <andrew.burgess@embecosm.com>
9034
9035         * common/forward-scope-exit.h: New file.
9036
9037 2019-01-23  Pedro Alves  <palves@redhat.com>
9038             Andrew Burgess  <andrew.burgess@embecosm.com>
9039             Tom Tromey  <tom@tromey.com>
9040
9041         * common/scope-exit.h: New file.
9042
9043 2019-01-23  Pedro Alves  <palves@redhat.com>
9044
9045         * common/preprocessor.h (ESC): Rename to ...
9046         (ESC_PARENS): ... this.
9047         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9048         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9049
9050 2019-01-23  Tom Tromey  <tom@tromey.com>
9051
9052         * language.h (class scoped_switch_to_sym_language_if_auto):
9053         Initialize m_lang in both cases.
9054
9055 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9056
9057         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9058         with XCNEW.
9059
9060 2019-01-22  Tom Tromey  <tom@tromey.com>
9061
9062         * corelow.c: Do not include sys/file.h.
9063
9064 2019-01-22  Tom Tromey  <tom@tromey.com>
9065
9066         * tui/tui-wingeneral.h: Include gdb_curses.h.
9067
9068 2019-01-22  Tom Tromey  <tom@tromey.com>
9069
9070         * source-cache.h (class source_cache) <get_source_lines,
9071         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9072
9073 2019-01-22  Tom Tromey  <tom@tromey.com>
9074
9075         * remote-fileio.h (struct remote_target): Declare.
9076
9077 2019-01-22  Tom Tromey  <tom@tromey.com>
9078
9079         * python/py-arch.c: Do not include py-ref.h.
9080         * python/py-bpevent.c: Do not include py-ref.h.
9081         * python/py-cmd.c: Do not include py-ref.h.
9082         * python/py-continueevent.c: Do not include py-ref.h.
9083         * python/py-event.h: Do not include py-ref.h.
9084         * python/py-evtregistry.c: Do not include py-ref.h.
9085         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9086         * python/py-frame.c: Do not include py-ref.h.
9087         * python/py-framefilter.c: Do not include py-ref.h.
9088         * python/py-function.c: Do not include py-ref.h.
9089         * python/py-infevents.c: Do not include py-ref.h.
9090         * python/py-linetable.c: Do not include py-ref.h.
9091         * python/py-objfile.c: Do not include py-ref.h.
9092         * python/py-param.c: Do not include py-ref.h.
9093         * python/py-prettyprint.c: Do not include py-ref.h.
9094         * python/py-progspace.c: Do not include py-ref.h.
9095         * python/py-symbol.c: Do not include py-ref.h.
9096         * python/py-symtab.c: Do not include py-ref.h.
9097         * python/py-type.c: Do not include py-ref.h.
9098         * python/py-unwind.c: Do not include py-ref.h.
9099         * python/py-utils.c: Do not include py-ref.h.
9100         * python/py-value.c: Do not include py-ref.h.
9101         * python/py-varobj.c: Do not include py-ref.h.
9102         * python/py-xmethods.c: Do not include py-ref.h.
9103         * python/python.c: Do not include py-ref.h.
9104         * varobj.c: Do not include py-ref.h.
9105
9106 2019-01-22  Tom Tromey  <tom@tromey.com>
9107
9108         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9109         keyword for bcache.
9110
9111 2019-01-22  Tom Tromey  <tom@tromey.com>
9112
9113         * compile/compile-cplus-types.c: Remove a comment by #include.
9114
9115 2019-01-22  Tom Tromey  <tom@tromey.com>
9116
9117         * compile/gcc-c-plugin.h: Include compile-internal.h.
9118
9119 2019-01-22  Tom Tromey  <tom@tromey.com>
9120
9121         * stabsread.c (EXTERN): Do not define.
9122         (symnum, next_symbol_text_func, processing_gcc_compilation)
9123         (within_function, global_sym_chain, global_stabs)
9124         (previous_stab_code, this_object_header_files)
9125         (n_this_object_header_files)
9126         (n_allocated_this_object_header_files): Define.
9127         * stabsread.h (EXTERN): Never define.  Use "extern".
9128
9129 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9130
9131         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9132         history_value.
9133
9134 2019-01-21  Tom Tromey  <tom@tromey.com>
9135
9136         * ui-out.c: Fix includes.
9137         * tui/tui-source.c: Fix includes.
9138         * target.c: Fix includes.
9139         * remote.c: Fix includes.
9140         * regcache.c: Fix includes.
9141         * python/py-block.c: Fix includes.
9142         * printcmd.c: Fix includes.
9143         * or1k-tdep.c: Fix includes.
9144         * mi/mi-main.c: Fix includes.
9145         * m32r-tdep.c: Fix includes.
9146         * csky-tdep.c: Fix includes.
9147         * compile/compile-cplus-types.c: Fix includes.
9148         * cli/cli-interp.c: Fix includes.
9149
9150 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9151
9152         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9153         for padding.
9154
9155 2019-01-16  Tom Tromey  <tom@tromey.com>
9156
9157         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9158         earlier.
9159         (struct objfile) <msymbols_range>: Move from top level.
9160         <msymbols>: New method.
9161         (class objfile_msymbols): Remove.
9162         * symtab.c (default_collect_symbol_completion_matches_break_on):
9163         Update.
9164         * symmisc.c (dump_msymbols): Update.
9165         * stabsread.c (scan_file_globals): Update.
9166         * objc-lang.c (info_selectors_command, info_classes_command)
9167         (find_methods): Update.
9168         * minsyms.c (find_solib_trampoline_target): Update.
9169         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9170         * coffread.c (coff_symfile_read): Update.
9171         * ada-lang.c (ada_lookup_simple_minsym)
9172         (ada_collect_symbol_completion_matches): Update.
9173
9174 2019-01-16  Tom Tromey  <tom@tromey.com>
9175
9176         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9177         type.  Remove no-argument constructor.
9178         <iterator::operator++>: Simplify.
9179         <begin>: Update.
9180         <end>: Use minimal_symbol_count.
9181
9182 2019-01-16  Tom Tromey  <tom@tromey.com>
9183
9184         * objfiles.h (struct objfile) <psymtabs>: New method.
9185         (class objfile_psymtabs): Remove.
9186         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9187         typedef.
9188         <range>: New method.
9189         (require_partial_symbols): Change return type.
9190         * psymtab.c (require_partial_symbols)
9191         (psym_expand_symtabs_matching): Update.
9192         * mdebugread.c (parse_partial_symbols): Update.
9193         * dbxread.c (dbx_end_psymtab): Update.
9194
9195 2019-01-15  Tom Tromey  <tom@tromey.com>
9196
9197         * symtab.c (lookup_objfile_from_block)
9198         (lookup_symbol_in_objfile_symtabs)
9199         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9200         (find_line_symtab, info_sources_command)
9201         (default_collect_symbol_completion_matches_break_on)
9202         (make_source_files_completion_list): Update.
9203         * symmisc.c (print_objfile_statistics, dump_objfile)
9204         (maintenance_print_symbols, maintenance_info_symtabs)
9205         (maintenance_check_symtabs, maintenance_info_line_tables):
9206         Update.
9207         * source.c (select_source_symtab)
9208         (forget_cached_source_info_for_objfile): Update.
9209         * objfiles.h (class objfile_compunits): Remove.
9210         (struct objfile) <compunits_range>: New typedef.
9211         (compunits): New method.
9212         * objfiles.c (objfile_relocate1): Update.
9213         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9214         * maint.c (count_symtabs_and_blocks): Update.
9215         * linespec.c (iterate_over_all_matching_symtabs): Update.
9216         * cp-support.c (add_symbol_overload_list_qualified): Update.
9217         * coffread.c (coff_symtab_read): Update.
9218         * ada-lang.c (add_nonlocal_symbols)
9219         (ada_collect_symbol_completion_matches)
9220         (ada_add_global_exceptions): Update.
9221
9222 2019-01-15  Tom Tromey  <tom@tromey.com>
9223
9224         * progspace.h (program_space) <objfiles_safe_range>: New
9225         typedef.
9226         <objfiles_safe>: New method.
9227         * objfiles.h (class all_objfiles_safe): Remove.
9228         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9229         * jit.c (jit_inferior_exit_hook): Update.
9230
9231 2019-01-17  Tom Tromey  <tom@tromey.com>
9232
9233         * progspace.h (program_space) <objfiles_range>: New typedef.
9234         <objfiles>: New method.
9235         <objfiles_head>: Rename from objfiles.
9236         (object_files): Update.
9237         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9238         * guile/scm-pretty-print.c
9239         (ppscm_find_pretty_printer_from_objfiles): Update.
9240         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9241         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9242         Update.
9243         * python/py-progspace.c (pspy_get_objfiles): Update.
9244         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9245         Update.
9246         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9247         (objfpy_lookup_objfile_by_build_id): Update.
9248         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9249         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9250         Update.
9251         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9252         (expand_symtab_containing_pc, lookup_objfile_from_block)
9253         (lookup_static_symbol, basic_lookup_transparent_type)
9254         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9255         (find_line_symtab, info_sources_command)
9256         (default_collect_symbol_completion_matches_break_on)
9257         (make_source_files_completion_list, find_main_name): Update.
9258         * symmisc.c (print_symbol_bcache_statistics)
9259         (print_objfile_statistics, maintenance_print_symbols)
9260         (maintenance_print_msymbols, maintenance_print_objfiles)
9261         (maintenance_info_symtabs, maintenance_check_symtabs)
9262         (maintenance_expand_symtabs, maintenance_info_line_tables):
9263         Update.
9264         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9265         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9266         (map_overlay_command, unmap_overlay_command)
9267         (simple_overlay_update, expand_symtabs_matching)
9268         (map_symbol_filenames): Update.
9269         * symfile-debug.c (set_debug_symfile): Update.
9270         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9271         Update.
9272         * source.c (select_source_symtab, forget_cached_source_info):
9273         Update.
9274         * solib.c (solib_read_symbols): Update.
9275         * solib-spu.c (append_ocl_sos): Update.
9276         * psymtab.c (maintenance_print_psymbols)
9277         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9278         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9279         * printcmd.c (info_symbol_command): Update.
9280         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9281         Update.
9282         * objfiles.h (class all_objfiles): Remove.
9283         * objfiles.c (have_partial_symbols, have_full_symbols)
9284         (have_minimal_symbols, qsort_cmp, update_section_map)
9285         (shared_objfile_contains_address_p)
9286         (default_iterate_over_objfiles_in_search_order): Update.
9287         * objc-lang.c (info_selectors_command, info_classes_command)
9288         (find_methods): Update.
9289         * minsyms.c (find_solib_trampoline_target): Update.
9290         * maint.c (maintenance_info_sections)
9291         (maintenance_translate_address, count_symtabs_and_blocks):
9292         Update.
9293         * main.c (captured_main_1): Update.
9294         * linux-thread-db.c (try_thread_db_load_from_pdir)
9295         (has_libpthread): Update.
9296         * linespec.c (iterate_over_all_matching_symtabs)
9297         (search_minsyms_for_name): Update.
9298         * jit.c (jit_find_objf_with_entry_addr): Update.
9299         * hppa-tdep.c (find_unwind_entry)
9300         (hppa_lookup_stub_minimal_symbol): Update.
9301         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9302         Update.
9303         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9304         (elf_gnu_ifunc_resolve_by_got): Update.
9305         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9306         * dwarf-index-write.c (save_gdb_index_command): Update.
9307         * cp-support.c (add_symbol_overload_list_qualified): Update.
9308         * breakpoint.c (create_overlay_event_breakpoint)
9309         (create_longjmp_master_breakpoint)
9310         (create_std_terminate_master_breakpoint)
9311         (create_exception_master_breakpoint): Update.
9312         * blockframe.c (find_pc_partial_function): Update.
9313         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9314         (ada_collect_symbol_completion_matches)
9315         (ada_add_global_exceptions): Update.
9316
9317 2019-01-17  Tom Tromey  <tom@tromey.com>
9318
9319         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9320         declare VEC.
9321         (solib_target_parse_libraries): Change return type.
9322         (library_list_start_segment, library_list_start_section)
9323         (library_list_end_library, library_list_start_library); Update.
9324         (solib_target_free_library_list): Remove.
9325         (solib_target_parse_libraries): Remove cleanup.  Change return
9326         type.
9327         (solib_target_current_sos): Update.
9328
9329 2019-01-17  Tom Tromey  <tromey@bapiya>
9330
9331         * valprint.c: Replace "the the" with "the".
9332         * symtab.c: Replace "the the" with "the".
9333         * solib.c: Replace "the the" with "the".
9334         * solib-dsbt.c: Replace "the the" with "the".
9335         * linespec.c: Replace "the the" with "the".
9336         * dwarf2loc.h: Replace "the the" with "the".
9337         * amd64-windows-tdep.c: Replace "the the" with "the".
9338         * aarch64-tdep.c: Replace "the the" with "the".
9339
9340 2019-01-16  Keith Seitz  <keiths@redhat.com>
9341
9342         PR gdb/23773
9343         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9344         <builder>: Rename to ..
9345         <m_builder>: ... this and make private.
9346         (dwarf2_cu::get_builder): New method.  Change all users of
9347         `builder' to use this method.
9348         (dwarf2_start_symtab): Move to ...
9349         (dwarf2_cu::start_symtab): ... here.  Update all callers
9350         (setup_type_unit_groups): Move to ...
9351         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9352         callers.
9353         (dwarf2_cu::reset_builder): New method.
9354         (process_full_compunit, process_full_type_unit): Use
9355         dwarf2_cu::reset_builder.
9356         (follow_die_offset): Record the ancestor CU if it is different
9357         from the followed DIE's CU.
9358         (follow_die_sig_1): Likewise.
9359
9360 2019-01-15  Tom Tromey  <tom@tromey.com>
9361
9362         * remote.c (class remote_state) <buf>: Now a char_vector.
9363         <buf_size>: Remove.
9364         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9365         parameter.
9366         (remote_target::getpkt_or_notif_sane_1)
9367         (remote_target::getpkt_sane)
9368         (remote_target::getpkt_or_notif_sane): Likewise.
9369         (class remote_target) <putpkt>: New overload.
9370         (remote_target::read_frame): Change type of "buf_p".  Remove
9371         sizeof_p parameter.
9372         (packet_ok): New overload.
9373         (packet_check_result): New overload.
9374         Update all uses.
9375
9376 2019-01-14  Tom Tromey  <tom@tromey.com>
9377
9378         * remote-notif.c (handle_notification, remote_notif_ack)
9379         (remote_notif_parse): Make "buf" const.
9380         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9381         const.
9382         (remote_notif_parse, remote_notif_ack, handle_notification):
9383         Likewise.
9384         * remote.c (remote_notif_stop_parse): Make "buf" const.
9385         (remote_target::remote_parse_stop_reply): Make "buf" const.
9386         (remote_notif_stop_ack): Make "buf" const.
9387
9388 2019-01-14  Tom Tromey  <tom@tromey.com>
9389
9390         * remote.c (remote_console_output): Make parameter const.
9391
9392 2019-01-14  Tom Tromey  <tom@tromey.com>
9393
9394         * target-debug.h (target_debug_print_signals): Constify.
9395         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9396         * procfs.c (procfs_target::pass_signals): Update.
9397         * linux-nat.c (linux_nat_target::pass_signals): Update.
9398         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9399         * target-delegates.c: Rebuild.
9400         * remote.c (remote_target::program_signals): Update.
9401         (remote_target::pass_signals): Update.
9402         * target.c (target_pass_signals): Constify argument.
9403         (target_program_signals): Likewise.
9404         * target.h (struct target_ops) <pass_signals, program_signals>:
9405         Constify argument.
9406         (target_pass_signals, target_program_signals): Constify argument.
9407
9408 2019-01-14  Tom Tromey  <tom@tromey.com>
9409
9410         PR tui/28819:
9411         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9412
9413 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9414
9415         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9416         field.
9417         * rs6000-tdep.c: Include reggroups.h.
9418         (IS_V_ALIAS_PSEUDOREG): Define.
9419         (rs6000_register_name): Return names for the "vX" aliases.
9420         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9421         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9422         aliases.  Call default_register_reggroup_p for all other
9423         pseudo-registers.
9424         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9425         New functions.
9426         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9427         Handle "vX" aliases.
9428         (v_alias_pseudo_register_collect): New function.
9429         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9430         (rs6000_gdbarch_init): Initialize "vX" aliases as
9431         pseudo-registers.  Restore registration of
9432         rs6000_pseudo_register_reggroup_p with
9433         set_tdesc_pseudo_register_reggroup_p.
9434
9435 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9436
9437         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9438         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9439         set_gdbarch_num_pseudo_regs.
9440
9441 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9442
9443         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9444         Remove arg prefixname, add do_set and do_show.
9445         Add member functions set_list and show_list.
9446         * cli/cli-style.c (class cli_style_option): Update accordingly.
9447         (style_set_list): Move to file scope.
9448         (style_show_list): Likewise.
9449         (set_style): Call help_list.
9450         (show_style): Call cmd_show_list.
9451         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9452         Update to use the new macro.
9453
9454 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9455
9456         * ada-lang.c (_initialize_ada_language): Expand the help text
9457         for the "catch exception" command.
9458
9459 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9460
9461         * symtab.c (matching_obj_sections): Initialize obj,
9462         declare it closer to its usage.
9463
9464 2019-01-10  Tom Tromey  <tom@tromey.com>
9465
9466         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9467         (basic_inf_threads_range): Remove.
9468         (inf_threads_range, inf_non_exited_threads_range)
9469         (safe_inf_threads_range): Use next_adapter.
9470
9471 2019-01-10  Keith Seitz  <keiths@redhat.com>
9472
9473         PR gdb/23712
9474         PR symtab/23010
9475         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9476         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9477
9478 2019-01-10  Keith Seitz  <keiths@redhat.com>
9479
9480         PR gdb/23712
9481         PR symtab/23010
9482         * dictionary.c (pending_to_vector): Remove.
9483         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9484         Remove _1 suffix, replacing functions of the same name.  Update
9485         all callers.
9486         (dict_create_hashed, dict_create_hashed_expandable)
9487         (dict_create_linear, dict_create_linear_expandable, dict_free)
9488         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9489         Make functions static.
9490
9491 2019-01-10  Keith Seitz  <keiths@redhat.com>
9492
9493         PR gdb/23712
9494         PR symtab/23010
9495         * dictionary.h (struct dictionary): Replace declaration with
9496         multidictionary.
9497         (dict_create_hashed, dict_create_hashed_expandable)
9498         (dict_create_linear, dict_create_linear_expandable)
9499         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9500         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9501         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9502         taking multidictionary argument.
9503         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9504         * block.h (struct block) <dict>: Change to multidictionary
9505         and rename `multidict'.
9506         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9507         symmisc.c: Update all dictionary references to multidictionary.
9508
9509 2019-01-10  Keith Seitz  <keiths@redhat.com>
9510
9511         PR gdb/23712
9512         PR symtab/23010
9513         * dictionary.c: Include unordered_map.
9514         (pending_to_vector): New function.
9515         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9516         Rewrite the non-"_1" functions to take vector instead
9517         of linked list.
9518         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9519         "new" _1 versions of the same name.
9520         (multidictionary): Define.
9521         (std::hash<enum language): New definition.
9522         (collate_pending_symbols_by_language, mdict_create_hashed)
9523         (mdict_create_hashed_expandable, mdict_create_linear)
9524         (mdict_create_linear_expandable, mdict_free)
9525         (find_language_dictionary, create_new_language_dictionary)
9526         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9527         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9528         (mdict_size, mdict_empty): New functions.
9529         * dictionary.h (mdict_iterator): Define.
9530
9531 2019-01-10  Pedro Alves  <palves@redhat.com>
9532
9533         * breakpoint.c (read_uploaded_action)
9534         (create_tracepoint_from_upload): Adjust to use
9535         gdb::unique_xmalloc_ptr.
9536         * ctf.c (ctf_write_uploaded_tp):
9537         (SET_ARRAY_FIELD): Use emplace_back.
9538         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9539         * tracefile-tfile.c (tfile_write_uploaded_tp):
9540         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9541         gdb::unique_xmalloc_ptr.
9542         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9543         at_string, cond_string, cmd_strings>: Replace char pointers
9544         with gdb::unique_xmalloc_ptr.
9545
9546 2019-01-10  Pedro Alves  <palves@redhat.com>
9547
9548         * solib-target.c (library_list_start_library): Don't xstrdup name.
9549
9550 2019-01-10  Pedro Alves  <palves@redhat.com>
9551
9552         * mdebugread.c (parse_partial_symbols): Use
9553         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9554
9555 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9556
9557         * linux-fork.c (scoped_switch_fork_info)
9558         <~scoped_switch_fork_info>: Fix incorrect variable name.
9559
9560 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9561
9562         * linux-fork.c (scoped_switch_fork_info)
9563         <scoped_switch_fork_info>: Make explicit.
9564         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9565
9566 2019-01-10  Tom Tromey  <tom@tromey.com>
9567
9568         * objfiles.h (objfile::reset_psymtabs): Update.
9569         * objfiles.c (objfile::objfile): Update.
9570         * psymtab.h (psymtab_storage::obstack): Update.
9571         (psymtab_storage::m_obstack): Use gdb::optional.
9572         (class psymtab_storage): Update comment.  Remove objfile
9573         parameter.
9574         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9575
9576 2019-01-10  Tom Tromey  <tom@tromey.com>
9577
9578         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9579         <free_psymtabs>: Now private.
9580         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9581         (allocate_psymtab): Use new method.
9582
9583 2019-01-10  Tom Tromey  <tom@tromey.com>
9584
9585         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9586         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9587         * mdebugread.c (parse_partial_symbols): Use
9588         allocate_dependencies.
9589         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9590         allocate_dependencies.
9591         (process_psymtab_comp_unit_reader)
9592         (build_type_psymtab_dependencies): Likewise.
9593         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9594
9595 2019-01-10  Tom Tromey  <tom@tromey.com>
9596
9597         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9598         PSYMBOL_SET_LANGUAGE.
9599         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9600
9601 2019-01-10  Tom Tromey  <tom@tromey.com>
9602
9603         * psymtab.h (psymtab_storage::obstack): New method.
9604         <m_obstack>: Rename from obstack; now private.
9605         * psymtab.c (psymtab_storage): Update.
9606         * dwarf2read.c (create_addrmap_from_index)
9607         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9608         Update.
9609
9610 2019-01-10  Tom Tromey  <tom@tromey.com>
9611
9612         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9613         * objfiles.h (objfile::reset_psymtabs): New method.
9614
9615 2019-01-10  Tom Tromey  <tom@tromey.com>
9616
9617         * symmisc.c (print_symbol_bcache_statistics): Update.
9618         (print_objfile_statistics): Update.
9619         * symfile.c (reread_symbols): Update.
9620         * psymtab.h (class psymtab_storage): New.
9621         * psymtab.c (psymtab_storage): New constructor.
9622         (~psymtab_storage): New destructor.
9623         (require_partial_symbols): Update.
9624         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9625         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9626         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9627         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9628         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9629         (start_psymtab_common, end_psymtab_common)
9630         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9631         (allocate_psymtab): Update.
9632         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9633         Update.
9634         (dump_psymtab_addrmap, maintenance_print_psymbols)
9635         (maintenance_check_psymtabs): Update.
9636         (class objfile_psymtabs): Move to objfiles.h.
9637         * psympriv.h (discard_psymtab): Now inline.
9638         (psymtab_discarder::psymtab_discarder): Update.
9639         (psymtab_discarder::~psymtab_discarder): Update.
9640         (ALL_OBJFILE_PSYMTABS): Rewrite.
9641         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9642         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9643         Remove fields.
9644         <partial_symtabs>: New field.
9645         (class objfile_psymtabs): Move from psymtab.h.  Update.
9646         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9647         psymbol_cache.
9648         (objfile::~objfile): Don't destroy psymbol_cache.
9649         * mdebugread.c (parse_partial_symbols): Update.
9650         * dwarf2read.c (create_addrmap_from_index)
9651         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9652         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9653         (add_partial_subprogram, dwarf2_ranges_read): Update.
9654         * dwarf-index-write.c (write_address_map)
9655         (write_one_signatured_type, recursively_write_psymbols)
9656         (class debug_names, class debug_names, write_psymtabs_to_index):
9657         Update.
9658
9659 2019-01-10  Tom Tromey  <tom@tromey.com>
9660
9661         * symtab.h (SYMBOL_SET_NAMES): Update.
9662         (symbol_set_names): Update.
9663         (MSYMBOL_SET_NAMES): Update.
9664         * symtab.c (symbol_set_names): Change argument to be an
9665         objfile_per_bfd_storage.
9666         * psymtab.c (add_psymbol_to_bcache): Update.
9667         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9668
9669 2019-01-10  Tom Tromey  <tom@tromey.com>
9670
9671         * symtab.c (create_demangled_names_hash): Change argument to be an
9672         objfile_per_bfd_storage.
9673         (symbol_set_names): Update.
9674
9675 2019-01-10  Tom Tromey  <tom@tromey.com>
9676
9677         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9678         init_psymbol_list.
9679         * psymtab.c (init_psymbol_list): Do nothing if already called.
9680         * psympriv.h (init_psymbol_list): Add comment.
9681         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9682         init_psymbol_list.
9683         * dbxread.c (dbx_symfile_read): Unconditionally call
9684         init_psymbol_list.
9685
9686 2019-01-10  Tom Tromey  <tom@tromey.com>
9687
9688         * xcoffread.c (scan_xcoff_symtab): Update.
9689         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9690         "where".
9691         * mdebugread.c (parse_partial_symbols)
9692         (handle_psymbol_enumerators): Update.
9693         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9694         * dbxread.c (read_dbx_symtab): Update.
9695         * psympriv.h (psymbol_placement): New enum.
9696         (add_psymbol_to_list): Update.
9697
9698 2019-01-10  Tom Tromey  <tom@tromey.com>
9699
9700         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9701         static_psymbols parameters.
9702         (scan_xcoff_symtab): Update.
9703         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9704         static_psymbols parameters.
9705         * psympriv.h (start_psymtab_common): Update.
9706         * mdebugread.c (parse_partial_symbols): Update.
9707         * dwarf2read.c (create_partial_symtab): Update.
9708         * dbxread.c (read_dbx_symtab): Update.
9709         (start_psymtab): Remove global_psymbols and static_psymbols
9710         parameters.
9711
9712 2019-01-10  Tom Tromey  <tom@tromey.com>
9713
9714         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9715         * psymtab.c (allocate_psymtab): Add comment.
9716         * psympriv.h (allocate_psymtab): Add comment.
9717         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9718         initializations.
9719         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9720
9721 2019-01-10  Tom Tromey  <tom@tromey.com>
9722
9723         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9724         Don't declare.
9725         * mipsread.c: Include mdebugread.h.
9726         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9727         Declare.
9728         * elfread.c: Include mdebugread.h.
9729
9730 2019-01-09  Tom Tromey  <tom@tromey.com>
9731
9732         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9733         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9734         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9735         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9736         (psym_lookup_symbol, psym_find_last_source_symtab)
9737         (psym_forget_cached_source_info, psym_print_stats)
9738         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9739         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9740         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9741         (psym_find_compunit_symtab_by_address)
9742         (maintenance_print_psymbols, maintenance_info_psymtabs)
9743         (maintenance_check_psymtabs): Use ranged for.
9744         * psymtab.h (class objfile_psymtabs): New.
9745         (require_partial_symbols): Return objfile_psymtabs.
9746         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9747
9748 2019-01-09  Tom Tromey  <tom@tromey.com>
9749
9750         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9751         (find_pc_mapped_section, list_overlays_command)
9752         (map_overlay_command, unmap_overlay_command)
9753         (simple_overlay_update): Use all_objfiles.
9754         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9755         * printcmd.c (info_symbol_command): Use all_objfiles.
9756         * objfiles.h (ALL_OBJSECTIONS): Remove.
9757         * maint.c (maintenance_translate_address): Use all_objfiles.
9758         * gcore.c (gcore_create_callback): Use all_objfiles.
9759         (objfile_find_memory_regions): Likewise.
9760
9761 2019-01-09  Tom Tromey  <tom@tromey.com>
9762
9763         * symtab.c (find_line_symtab, info_sources_command)
9764         (make_source_files_completion_list): Use objfile_compunits.
9765         * source.c (select_source_symtab): Use objfile_compunits.
9766         * objfiles.h (struct objfile): Update comment.
9767         (ALL_OBJFILES): Remove.
9768         (ALL_FILETABS): Remove.
9769         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9770         objfile_compunits.
9771
9772 2019-01-09  Tom Tromey  <tom@tromey.com>
9773
9774         * symmisc.c (print_objfile_statistics, dump_objfile)
9775         (maintenance_print_symbols): Use compunit_filetabs.
9776         * source.c (forget_cached_source_info_for_objfile): Use
9777         compunit_filetabs.
9778         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9779         (ALL_FILETABS): Use compunit_filetabs.
9780         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9781         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9782
9783 2019-01-09  Tom Tromey  <tom@tromey.com>
9784
9785         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9786         (compunit_filetabs): New.
9787         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9788         compunit_filetabs.
9789         (info_sources_command, make_source_files_completion_list): Remove
9790         declaration.
9791         * symmisc.c (print_objfile_statistics, dump_objfile)
9792         (maintenance_print_symbols): Remove declaration.
9793         (maintenance_info_symtabs): Use compunit_filetabs.
9794         (maintenance_info_line_tables): Likewise.
9795         * source.c (select_source_symtab): Change local variable name.
9796         (forget_cached_source_info_for_objfile): Remove declaration.
9797         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9798         * objfiles.c (objfile_relocate1): Remove declaration.
9799         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9800         declaration.
9801         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9802         * coffread.c (coff_symtab_read): Remove declaration.
9803         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9804         compunit_filetabs.
9805
9806 2019-01-09  Tom Tromey  <tom@tromey.com>
9807
9808         * symtab.c (lookup_objfile_from_block)
9809         (find_pc_sect_compunit_symtab, search_symbols)
9810         (default_collect_symbol_completion_matches_break_on): Use
9811         objfile_compunits.
9812         * objfiles.h (ALL_COMPUNITS): Remove.
9813         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9814         * cp-support.c (add_symbol_overload_list_qualified): Use
9815         objfile_compunits.
9816         * ada-lang.c (ada_collect_symbol_completion_matches)
9817         (ada_add_global_exceptions): Use objfile_compunits.
9818
9819 2019-01-09  Tom Tromey  <tom@tromey.com>
9820
9821         * source.c (select_source_symtab)
9822         (forget_cached_source_info_for_objfile): Remove declaration.
9823         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9824         declaration.
9825         * maint.c (count_symtabs_and_blocks): Remove declaration.
9826         * cp-support.c (add_symbol_overload_list_qualified): Remove
9827         declaration.
9828         * coffread.c (coff_symtab_read): Remove declaration.
9829         * symtab.c (lookup_symbol_in_objfile_symtabs)
9830         (basic_lookup_transparent_type_1): Use objfile_compunits.
9831         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9832         (info_sources_command, search_symbols)
9833         (default_collect_symbol_completion_matches_break_on)
9834         (make_source_files_completion_list): Remove declaration.
9835         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9836         (ada_collect_symbol_completion_matches)
9837         (ada_add_global_exceptions): Remove declaration.
9838         * linespec.c (iterate_over_all_matching_symtabs): Use
9839         objfile_compunits.
9840         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9841         (class objfile_compunits): New.
9842         (ALL_COMPUNITS): Use objfile_compunits.
9843         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9844         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9845         objfile_compunits.
9846         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9847
9848 2019-01-09  Tom Tromey  <tom@tromey.com>
9849
9850         * symtab.c (search_symbols)
9851         (default_collect_symbol_completion_matches_break_on): Use
9852         objfile_msymbols.
9853         * ada-lang.c (ada_lookup_simple_minsym)
9854         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9855         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9856         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9857         objfile_msymbols.
9858         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9859         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9860         * objc-lang.c (find_methods): Use objfile_msymbols.
9861         (info_selectors_command, info_classes_command): Likewise.
9862         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9863         * objfiles.h (class objfile_msymbols): New.
9864         (ALL_OBJFILE_MSYMBOLS): Remove.
9865         (ALL_MSYMBOLS): Remove.
9866
9867 2019-01-09  Tom Tromey  <tom@tromey.com>
9868
9869         * common/next-iterator.h (next_adapter): Add Iterator template
9870         parameter.
9871         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9872         (class all_objfiles_safe): New.
9873         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9874         * objfiles.c (put_objfile_before): Update comment.
9875         (add_separate_debug_objfile): Likewise.
9876         (free_all_objfiles): Use all_objfiles_safe.
9877         (objfile_purge_solibs): Likewise.
9878
9879 2019-01-09  Tom Tromey  <tom@tromey.com>
9880
9881         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9882         (expand_symtab_containing_pc, lookup_static_symbol)
9883         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9884         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9885         all_objfiles.
9886         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9887         * breakpoint.c (create_overlay_event_breakpoint)
9888         (create_longjmp_master_breakpoint)
9889         (create_std_terminate_master_breakpoint)
9890         (create_exception_master_breakpoint): Use all_objfiles.
9891         * linux-thread-db.c (try_thread_db_load_from_pdir)
9892         (has_libpthread): Use all_objfiles.
9893         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9894         * linespec.c (iterate_over_all_matching_symtabs)
9895         (search_minsyms_for_name): Use all_objfiles.
9896         * maint.c (maintenance_info_sections): Use all_objfiles.
9897         * main.c (captured_main_1): Use all_objfiles.
9898         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9899         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9900         * guile/scm-pretty-print.c
9901         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9902         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9903         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9904         (maintenance_print_msymbols): Use all_objfiles.
9905         * source.c (select_source_symtab): Use all_objfiles.
9906         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9907         * symfile.c (remove_symbol_file_command)
9908         (expand_symtabs_matching, map_symbol_filenames): Use
9909         all_objfiles.
9910         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9911         all_objfiles.
9912         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9913         * objc-lang.c (find_methods): Use all_objfiles.
9914         * objfiles.c (have_partial_symbols, have_full_symbols)
9915         (have_minimal_symbols, qsort_cmp)
9916         (default_iterate_over_objfiles_in_search_order): Use
9917         all_objfiles.
9918         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9919         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9920         (maintenance_check_psymtabs): Use all_objfiles.
9921         (ALL_PSYMTABS): Remove.
9922         * compile/compile-object-run.c (do_module_cleanup): Use
9923         all_objfiles.
9924         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9925         * cp-support.c (add_symbol_overload_list_qualified): Use
9926         all_objfiles.
9927         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9928         Use all_objfiles.
9929         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9930         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9931         all_objfiles.
9932         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9933         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9934         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9935         Uses all_objfiles.
9936         * solib.c (solib_read_symbols): Use all_objfiles
9937
9938 2019-01-09  Tom Tromey  <tom@tromey.com>
9939
9940         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9941         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9942         all_objfiles.
9943         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9944         * symmisc.c (print_symbol_bcache_statistics)
9945         (print_objfile_statistics, maintenance_print_objfiles)
9946         (maintenance_info_symtabs, maintenance_check_symtabs)
9947         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9948         all_objfiles.
9949         * source.c (forget_cached_source_info): Use all_objfiles.
9950         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9951         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9952         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9953         * objfiles.c (update_section_map): Use all_objfiles.
9954         (shared_objfile_contains_address_p): Likewise.
9955         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9956         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9957
9958 2019-01-09  Tom Tromey  <tom@tromey.com>
9959
9960         * common/next-iterator.h: New file.
9961         * objfiles.h (class all_objfiles): New.
9962         (struct objfile_iterator): New.
9963
9964 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9965
9966         * NEWS: Move the description of the changed "frame", "select-frame",
9967          and "info frame" commands to the Changed commands section.
9968
9969 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9970
9971         * gdbtypes.c (check_stub_method_group): Remove handling of old
9972         mangling schemes.
9973         * linespec.c (find_methods): Likewise.
9974         * stabsread.c (read_member_functions): Likewise.
9975         * valops.c (search_struct_method): Likewise.
9976         (value_struct_elt_for_reference): Likewise.
9977         * NEWS: Mention this change.
9978
9979 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9980
9981         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9982         print_source_lines.
9983         * source.c (print_source_lines_base): Update line number check.
9984         (print_source_lines): New function.
9985         (source_lines_range::source_lines_range): New function.
9986         * source.h (class source_lines_range): New class.
9987         (print_source_lines): New declaration.
9988
9989 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9990
9991         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9992
9993 2019-01-08  Tom Tromey  <tom@tromey.com>
9994             Simon Marchi  <simon.marchi@ericsson.com>
9995
9996         PR gdb/24060
9997         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9998         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9999         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10000         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10001         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10002         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10003
10004 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10005
10006         * source.c (select_source_symtab): Move header comment to
10007         declaration in source.h.
10008         (forget_cached_source_info_for_objfile): Likewise.
10009         (forget_cached_source_info): Likewise.
10010         (identify_source_line): Likewise.
10011         * source.h (identify_source_line): Move declaration from symtab.h
10012         and add comment from source.c
10013         (print_source_lines): Likewise.
10014         (forget_cached_source_info_for_objfile): Likewise.
10015         (forget_cached_source_info): Likewise.
10016         (select_source_symtab): Likewise.
10017         (enum print_source_lines_flag): Move definition from symtab.h.
10018         * symtab.h (identify_source_line): Move declaration to source.h.
10019         (print_source_lines): Likewise.
10020         (forget_cached_source_info_for_objfile): Likewise.
10021         (forget_cached_source_info): Likewise.
10022         (select_source_symtab): Likewise.
10023         (enum print_source_lines_flag): Move definition to source.h.
10024         * tui/tui-hooks.c: Add 'source.h' include.
10025
10026 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10027
10028         * source.c (print_source_lines_base): Handle requests to print
10029         reverse line number sequences, and guard against empty lines
10030         string.
10031
10032 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10033
10034         * source.c (print_source_lines_base): Fix skip of '\r' if next
10035         character is '\n'.
10036
10037 2019-01-06  Tom Tromey  <tom@tromey.com>
10038
10039         * c-exp.y (struct c_parse_state) <macro_original_text,
10040         expansion_obstack>: New member.
10041         (macro_original_text, expansion_obstack): Remove globals.
10042         (scan_macro_expansion, scanning_macro_expansion)
10043         (finished_macro_expansion): Update.
10044         (scan_macro_cleanup): Remove.
10045         (yylex, c_parse): Update.
10046
10047 2019-01-06  Tom Tromey  <tom@tromey.com>
10048
10049         * c-exp.y (struct c_parse_state) <strings>: New member.
10050         (operator_stoken): Update.
10051
10052 2019-01-06  Tom Tromey  <tom@tromey.com>
10053
10054         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10055         (union type_stack_elt) <typelist_val>: Now a pointer to
10056         std::vector.
10057         (type_stack_cleanup): Don't declare.
10058         (push_typelist): Update.
10059         * parse.c (pop_typelist): Return a std::vector.
10060         (push_typelist): Take a std::vector.
10061         (follow_types): Update.  Do not free args.
10062         (type_stack_cleanup): Remove.
10063         * c-exp.y (struct c_parse_state): New.
10064         (cpstate): New global.
10065         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10066         (nonempty_typelist): Update.
10067         (func_mod): Create a new vector.
10068         (c_parse): Create a c_parse_state.
10069         (check_parameter_typelist): Do not delete params.
10070         (function_method): Update.  Do not delete type_list.
10071
10072 2019-01-06  Tom Tromey  <tom@tromey.com>
10073
10074         PR gdb/28155:
10075         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10076         check_typedef.
10077         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10078         (print_return_value): Likewise.
10079
10080 2019-01-05  Tom Tromey  <tom@tromey.com>
10081
10082         * contrib/cleanup_check.py: Remove.
10083         * contrib/gcc-with-excheck: Remove.
10084         * contrib/exsummary.py: Remove.
10085         * contrib/excheck.py: Remove.
10086
10087 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10088
10089         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10090         NULL. Initialize tpprev to NULL instead of assigning it
10091         to NULL on the next statement.
10092         * windows-nat.c (windows_delete_thread): Remove check for
10093         main_thread_id before printing thread exit notifications.
10094         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10095         Remove thread ID check against main_thread_id.
10096         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10097         windows_delete_thread.
10098         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10099
10100 2019-01-04  Tom Tromey  <tom@tromey.com>
10101
10102         * compile/compile.c (_initialize_compile): Use upper case for
10103         metasyntactic variables.
10104         * symmisc.c (_initialize_symmisc): Use upper case for
10105         metasyntactic variables.
10106         * psymtab.c (_initialize_psymtab): Use upper case for
10107         metasyntactic variables.
10108         * demangle.c (demangle_command): Use upper case for metasyntactic
10109         variables.
10110         (_initialize_demangler): Likewise.
10111         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10112         variables.
10113
10114 2019-01-03  Tom Tromey  <tom@tromey.com>
10115
10116         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10117
10118 2019-01-03  Tom Tromey  <tom@tromey.com>
10119
10120         * python/py-symtab.c (salpy_str): Update.
10121         (struct salpy_sal_object) <symtab>: Now a PyObject.
10122         (salpy_dealloc): Update.
10123         (del_objfile_sal): Use gdbpy_ref.
10124
10125 2019-01-03  Tom Tromey  <tom@tromey.com>
10126
10127         * python/py-type.c (convert_field): Use new_reference.  Return
10128         gdbpy_ref.
10129         (make_fielditem): Return gdbpy_ref.
10130         (typy_fields): Update.
10131         (typy_getitem): Update.
10132         (field_name): Return gdbpy_ref.  Use new_reference.
10133         (typy_iterator_iternext): Update.
10134
10135 2019-01-03  Tom Tromey  <tom@tromey.com>
10136
10137         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10138
10139 2019-01-03  Tom Tromey  <tom@tromey.com>
10140
10141         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10142         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10143         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10144         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10145         (pspy_set_type_printers): Likewise.
10146         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10147         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10148         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10149         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10150         (objfpy_set_type_printers): Likewise.
10151
10152 2019-01-03  Tom Tromey  <tom@tromey.com>
10153
10154         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10155         (gdbpy_print_stack): Use gdbpy_err_fetch.
10156         * python/python-internal.h (class gdbpy_err_fetch): New class.
10157         (class gdbpy_enter) <m_error_type, m_error_value,
10158         m_error_traceback>: Remove.
10159         <m_error>: New member.
10160         (gdbpy_exception_to_string): Don't declare.
10161         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10162         * python/py-value.c (convert_value_from_python): Use
10163         gdbpy_err_fetch.
10164         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10165         gdbpy_exception_to_string.
10166         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10167         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10168         gdbpy_err_fetch.
10169
10170 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10171
10172         * linux-nat.c (delete_lwp_cleanup): Delete.
10173         (struct lwp_deleter): New struct.
10174         (lwp_info_up): New typedef.
10175         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10176         lwp_info_up.
10177
10178 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10179
10180         * linux-fork.c (class scoped_switch_fork_info): New class.
10181         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10182
10183 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10184
10185         * valops.c (find_overload_match): Remove use of null_cleanup, and
10186         calls to do_cleanups.
10187
10188 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10189
10190         * compile/compile-cplus-types.c
10191         (compile_cplus_instance::decl_name): Handle changes to
10192         cp_func_name.
10193         * cp-support.c (cp_func_name): Update header comment, update
10194         return type.
10195         * cp-support.h (cp_func_name): Update return type in declaration.
10196         * valops.c (find_overload_match): Move temp_func local to top
10197         level of function and change its type.  Use temp_func to hold and
10198         delete temporary string obtained from cp_func_name.
10199
10200 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10201
10202         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10203         gdb::char_vector, remove cleanup, and update uses of `msg`.
10204
10205 2019-01-03  Jim Wilson  <jimw@sifive.com>
10206
10207         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10208
10209 2019-01-02  Tom Tromey  <tom@tromey.com>
10210
10211         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10212         (tdesc_parse_xml): Remove cleanups.
10213         * target-descriptions.h (make_cleanup_free_target_description):
10214         Don't declare.
10215         (target_desc_deleter): New struct.
10216         (target_desc_up): New typedef.
10217         * target-descriptions.c (target_desc_deleter::operator()): Rename
10218         from free_target_description.
10219         (make_cleanup_free_target_description): Remove.
10220
10221 2019-01-02  Tom Tromey  <tom@tromey.com>
10222
10223         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10224         constructor, destructor.
10225         (linespec_parser): Remove typedef.
10226         (~linespec_parser): Rename from linespec_parser_delete.
10227         (linespec_lex_to_end, linespec_complete_label)
10228         (linespec_complete): Update.
10229         (decode_line_full): Remove cleanups.
10230         (decode_line_1): Update.
10231
10232 2019-01-02  Tom Tromey  <tom@tromey.com>
10233
10234         * python/python-internal.h (inferior_to_inferior_object): Change
10235         return type.
10236         * python/py-exitedevent.c (create_exited_event_object): Update.
10237         * python/py-inferior.c (inferior_to_inferior_object): Return
10238         gdbpy_ref.
10239         (python_new_inferior, python_inferior_deleted)
10240         (thread_to_thread_object, delete_thread_object)
10241         (build_inferior_list, gdbpy_selected_inferior): Update.
10242         * python/py-infthread.c (create_thread_object): Update.  Also fail
10243         if inferior_to_inferior_object fails.
10244
10245 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10246
10247         * inferior.h (class inferior) <displaced_step_state>: New field.
10248         * infrun.h (struct displaced_step_state): Move here from
10249         infrun.c.  Initialize fields, add constructor.
10250         <inf>: Remove field.
10251         <reset>: New method.
10252         * infrun.c (struct displaced_step_inferior_state): Move to
10253         infrun.h.
10254         (displaced_step_inferior_states): Remove.
10255         (get_displaced_stepping_state): Adust.
10256         (displaced_step_in_progress_any_inferior): Adjust.
10257         (displaced_step_in_progress_thread): Adjust.
10258         (displaced_step_in_progress): Adjust.
10259         (add_displaced_stepping_state): Remove.
10260         (get_displaced_step_closure_by_addr): Adjust.
10261         (remove_displaced_stepping_state): Remove.
10262         (infrun_inferior_exit): Call displaced_step_state.reset.
10263         (use_displaced_stepping): Don't check for NULL.
10264         (displaced_step_prepare_throw): Call
10265         get_displaced_stepping_state.
10266         (displaced_step_fixup): Don't check for NULL.
10267         (prepare_for_detach): Don't check for NULL.
10268
10269 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10270
10271         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10272          in case of call that did not complete.
10273
10274 2019-01-02  Andrey Utkin  <autkin@undo.io>
10275
10276         * symfile.c (find_separate_debug_file): Fix search of debug files for
10277         remote debuggee.
10278
10279 2019-01-02  Tom Tromey  <tom@tromey.com>
10280
10281         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10282         indentation.
10283         * python/py-frame.c (frapy_older): Remove cast.
10284         (frapy_newer): Likewise.
10285         * python/py-breakpoint.c (local_setattro): Remove cast.
10286         * python/py-arch.c (archpy_name): Remove local variable.
10287         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10288
10289 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10290
10291         * unittests/basic_string_view/element_access/char/empty.cc:
10292         Fix year range in copyright header.
10293
10294 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10295
10296         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10297         Delete.
10298         <operator==>: Update with for removed field.
10299         <hash>: Likewise.
10300         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10301         <isa_features>: ...this.
10302         <abi_features>: New field.
10303         (riscv_isa_flen): Update comment.
10304         (riscv_abi_xlen): New declaration.
10305         (riscv_abi_flen): New declaration.
10306         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10307         isa_features.
10308         (riscv_abi_xlen): New function.
10309         (riscv_isa_flen): Update to get answer from isa_features.
10310         (riscv_abi_flen): New function.
10311         (riscv_has_fp_abi): Update to get answer from abi_features.
10312         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10313         xlen and flen.
10314         (riscv_call_info) <xlen, flen>: Update comment.
10315         (riscv_call_arg_struct): Remove invalid assertions
10316         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10317         is removed.
10318         (riscv_gdbarch_init): Gather isa features and abi features
10319         separately, ensure both match on the gdbarch when reusing an old
10320         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10321         a target with 64-bit float hardware.
10322
10323 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10324
10325         * source.c (search_command_helper): Stop reverse search
10326         when line 1 has been searched.
10327
10328 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10329
10330         * record-full.c (record_full_base_target::close): Rewrite
10331         record_full_core_buf_list free logic.
10332
10333 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10334
10335         * break-catch-syscall.c (print_one_catch_syscall): xfree
10336         the last text.
10337
10338 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10339
10340         * top.c (print_gdb_version): Update Copyright year in version
10341         message.
10342
10343 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10344
10345         Update copyright year range in all GDB files.
10346
10347 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10348
10349         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10350
10351 For older changes see ChangeLog-2018.
10352 \f
10353 Local Variables:
10354 mode: change-log
10355 left-margin: 8
10356 fill-column: 74
10357 version-control: never
10358 coding: utf-8
10359 End:
10360