Remove an include of common/queue.h
[external/binutils.git] / gdb / ChangeLog
1 2019-04-19  Tom Tromey  <tom@tromey.com>
2
3         * event-loop.c: Don't include "common/queue.h".
4
5 2019-04-19  Tom Tromey  <tom@tromey.com>
6
7         * remote.c (remote_target): Use delete.
8         * remote-notif.h: Include <list>, not "common/queue.h".
9         (notif_client_p): Remove typedef.
10         (remote_notif_state): Add constructor, destructor, initializer.
11         <notif_queue>: Now a std::list.
12         (remote_notif_state_xfree): Don't declare.
13         * remote-notif.c (remote_notif_process, handle_notification)
14         (remote_notif_state_allocate): Update.
15         (~remote_notif_state): Rename from remote_notif_state_xfree.
16
17 2019-04-19  Tom Tromey  <tom@tromey.com>
18
19         * symfile.c (reread_symbols): Update.
20         * objfiles.c (objfile_register_static_link)
21         (objfile_lookup_static_link): Update
22         (~objfile) Don't delete static_links.
23         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
24
25 2019-04-19  Tom Tromey  <tom@tromey.com>
26
27         * type-stack.h (struct type_stack) <insert>: Constify string.
28         * type-stack.c (type_stack::insert): Constify string.
29         * gdbtypes.h (lookup_template_type): Update.
30         (address_space_name_to_int): Update.
31         * gdbtypes.c (address_space_name_to_int): Make space_identifier
32         const.
33         (lookup_template_type): Make name const.
34         * c-exp.y: Update rules.
35         (lex_one_token, classify_name, classify_inner_name)
36         (c_print_token): Update.
37         * p-exp.y: Update rules.
38         (yylex): Update.
39         * f-exp.y: Update rules.
40         (yylex): Update.
41         * d-exp.y: Update rules.
42         (lex_one_token, classify_name, classify_inner_name): Update.
43         * parse.c (write_dollar_variable, copy_name): Return std::string.
44         * parser-defs.h (copy_name): Change return type.
45         * m2-exp.y: Update rules.
46         (yylex): Update.
47         * go-exp.y (lex_one_token): Update.
48         Update rules.
49         (classify_unsafe_function, classify_packaged_name)
50         (classify_name, yylex): Update.
51
52 2019-04-19  Sergei Trofimovich <siarheit@google.com>
53
54         * configure.ac: add --enable-source-highlight switch.
55         * configure: Regenerate.
56         * top.c (print_gdb_version): plumb --enable-source-highlight
57         status to "show configuration".
58
59 2019-04-19  Tom Tromey  <tromey@adacore.com>
60
61         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
62         Check ADA_TYPE_P.
63         (empty_record, ada_template_to_fixed_record_type_1)
64         (template_to_static_fixed_type)
65         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
66         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
67         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
68         macros.
69
70 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
71
72         PR symtab/24423:
73         * source.c (print_source_lines_base): Advance "iter" when a
74         control character is seen.
75
76 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
77
78         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
79         close to the add_com "shell".
80
81 2019-04-18  Tom Tromey  <tromey@adacore.com>
82
83         * process-stratum-target.h (class process_stratum_target)
84         <stratum>: Add "final".
85
86 2019-04-17  Tom Tromey  <tromey@adacore.com>
87
88         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
89         against nullptr before use.
90
91 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
92
93         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
94
95 2019-04-17  Jim Wilson  <jimw@sifive.com>
96             Andrew Burgess  <andrew.burgess@embecosm.com>
97
98         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
99         code read might fail, assume 4-byte breakpoint in that case.
100
101 2019-04-15  Leszek Swirski  <leszeks@google.com>
102
103         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
104         rather than a hand-rolled POD check when checking for forced MEMORY
105         classification.
106
107 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
108
109         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
110         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
111         function.
112         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
113         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
114         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
115         declaration.
116
117 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
118
119         * aarch64-linux-nat.c
120         (aarch64_linux_nat_target::thread_architecture): Add override.
121         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
122         each VQ.
123
124 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
125
126         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
127
128 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
129
130         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
131         target types of size 96-bits, add some additional comments, and
132         check that the builtin type we found was the correct size.
133
134 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
135
136         * utils.c (prompt_for_continue): Don't restore the styling at the
137         end, as applied_style has the wrong value.  This fixes styling in
138         long lists of file names that are interrupted by the "Continue?"
139         prompt.
140
141 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
142
143         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
144         * c-lang.c (c_language_defn): Likewise.
145         (cplus_language_defn): Likewise.
146         (asm_language_defn): Likewise.
147         (minimal_language_defn): Likewise.
148         * d-lang.c (d_language_defn): Likewise.
149         * f-lang.c (f_language_defn): Likewise.
150         * go-lang.c (go_language_defn): Likewise.
151         * language.c (unknown_language_defn): Likewise.
152         (auto_language_defn): Likewise.
153         * language.h (struct language_defn): Remove la_magic field.
154         (LANG_MAGIC): Delete.
155         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
156         * objc-lang.c (objc_language_defn): Likewise.
157         * opencl-lang.c (opencl_language_defn): Likewise.
158         * p-lang.c (pascal_language_defn): Likewise.
159         * rust-lang.c (rust_language_defn): Likewise.
160
161 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
162
163         * riscv-tdep.c (riscv_type_align): New function.
164         (riscv_type_alignment): Delete.
165         (riscv_arg_location): Use 'type_align'.
166         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
167
168 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
169
170         * gdbtypes.c (type_align): A struct with no non-static fields also
171         has alignment of 1.
172
173 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
174
175         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
176         component to 0.
177         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
178         member.
179         (riscv_struct_info::analyse): New implementation using new
180         analyse_inner member function.
181         (riscv_struct_info::field_offset): New member function.
182         (riscv_struct_info::m_offsets): New member variable.
183         (riscv_struct_info::analyse_inner): New private member function,
184         takes the old implementation of riscv_struct_info::analyse but
185         extended to track field offsets.
186         (riscv_call_arg_struct): Update the struct folding special cases
187         to handle cases where empty C++ structs, which are non-zero
188         length, are found.
189         (riscv_arg_location): Initialise the length of each location, a
190         non-zero length now indicates the location is in use.
191         (riscv_push_dummy_call): Allow for the first location having a
192         non-zero offset when setting up arguments.
193         (riscv_return_value): Likewise, but for return values.
194
195 2019-04-11  Tom Tromey  <tromey@adacore.com>
196
197         * utils.c (internal_vproblem): Make "msg" const.
198
199 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
200
201         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
202         * trad-frame.c (trad_frame_reset_saved_regs): New function.
203         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
204         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
205
206 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
207
208         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
209         function.
210         (fill_gregset): Call amd64_linux_collect_native_gregset instead
211         of amd64_collect_native_gregset.
212         (amd64_linux_nat_target::store_registers): Likewise.
213
214 2019-04-10  Tom Tromey  <tom@tromey.com>
215
216         * symtab.c (lookup_global_symbol_from_objfile)
217         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
218         * objfiles.h (class separate_debug_iterator): New.
219         (class separate_debug_range): New.
220         (struct objfile) <separate_debug_objfiles>: New method.
221         (objfile_separate_debug_iterate): Don't declare.
222         * objfiles.c (separate_debug_iterator::operator++): Rename from
223         objfile_separate_debug_iterate.
224         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
225         iterator.
226         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
227         iterator.
228
229 2019-04-10  Tom Tromey  <tom@tromey.com>
230
231         * symfile.c (reread_symbols): Remove old comment.
232         * objfiles.c (free_all_objfiles): Fix a typo.
233
234 2019-04-10  Tom Tromey  <tom@tromey.com>
235
236         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
237         * minsyms.c (lookup_minimal_symbol): Use foreach.
238         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
239         (lookup_minimal_symbol_solib_trampoline): Likewise.
240         * symfile.c (reread_symbols): Use foreach.
241
242 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
243             Tom Tromey  <tromey@adacore.com>
244
245         PR rust/24414:
246         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
247         (rust_lex_int_test): Change "value" to be LONGEST.
248         (rust_lex_tests): Add test for long integer literal.
249
250 2019-04-09  Tom Tromey  <tromey@adacore.com>
251
252         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
253         to bool.
254         (extended_remote_target::attach): Update.
255         (remote_target::remote_notice_new_inferior): Update.
256         (remote_target::add_current_inferior_and_thread): Update.
257         * inferior.c (exit_inferior_1): Use "false".
258         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
259
260 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
261
262         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
263         the "start" command.
264
265 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
266
267         * python/py-inferior.c (infpy_thread_from_thread_handle):
268         Adjust comments to reflect renaming of thread_from_thread_handle
269         to thread_from_handle.  Adjust keywords.  Fix type error message.
270         (inferior_object_methods): Add thread_from_handle.  Retain
271         thread_from_thread_handle, but mark it as deprecated.
272
273 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
274
275         * gdbthread.h (find_thread_by_handle): Revise declaration.
276         * thread.c (find_thread_by_handle): Likewise.  Adjust
277         implementation too.
278         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
279         support for buffer objects as handles.
280
281 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
282
283         * python/py-infthread.c (thpy_thread_handle): New function.
284         (thread_object_methods): Register thpy_thread_handle.
285
286 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
287
288         * gdbthread.h (thread_to_thread_handle): Declare.
289         * thread.c (gdbtypes.h): Include.
290         (thread_to_thread_handle): New function.
291
292         * target.h (struct target_ops): Add thread_info_to_thread_handle.
293         (target_thread_info_to_thread_handle): Declare.
294         * target.c (target_thread_info_to_thread_handle): New function.
295         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
296         * target-delegates.c: Regenerate.
297
298         * linux-thread-db.c (class thread_db_target): Add method
299         thread_info_to_thread_handle.
300         (thread_db_target::thread_info_to_thread_handle): Define.
301         * remote.c (class remote_target): Add new method
302         thread_info_to_thread_handle.
303         (remote_target::thread_info_to_thread_handle): Define.
304
305 2019-04-08  Pedro Alves  <palves@redhat.com>
306
307         * common/common-exceptions.c (throw_exception): Don't create
308         named object to throw; throw directly.
309         (throw_it): Likewise.  Don't initialize gdb_exception::message
310         here, with new; pass FMT and AP to the ctor instead.
311         * common/common-exceptions.h: Include <string>.
312         (gdb_exception::gdb_exception(enum return_reason, enum errors,
313         const char *, va_list)): New ctor.  Use std::make_shared.
314         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
315         errors)): Delete.
316         (gdb_exception_error::gdb_exception_error(enum errors, const char
317         *, va_list)): New.
318         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
319         Add assertion.
320         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
321         errors)): Delete.
322         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
323         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
324         Add assertion.
325
326 2019-04-08  Tom Tromey  <tom@tromey.com>
327
328         * valops.c (value_rtti_indirect_type): Replace throw_exception
329         with throw.
330         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
331         with throw.
332         * thread.c (thr_try_catch_cmd): Replace throw_exception with
333         throw.
334         * target.c (target_translate_tls_address): Replace throw_exception
335         with throw.
336         * stack.c (frame_apply_command_count): Replace throw_exception
337         with throw.
338         * solib-spu.c (append_ocl_sos): Replace throw_exception with
339         throw.
340         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
341         with throw.
342         * rs6000-tdep.c (rs6000_frame_cache)
343         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
344         * remote.c: Replace throw_exception with throw.
345         * record-full.c (record_full_message, record_full_wait_1)
346         (record_full_restore): Replace throw_exception with throw.
347         * record-btrace.c:
348         (get_thread_current_frame_id, record_btrace_start_replaying)
349         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
350         (cmd_record_btrace_start): Replace throw_exception with throw.
351         * parse.c (parse_exp_in_context_1): Replace throw_exception with
352         throw.
353         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
354         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
355         * linespec.c:
356         (find_linespec_symbols): Replace throw_exception with throw.
357         * infrun.c (displaced_step_prepare, resume): Replace
358         throw_exception with throw.
359         * infcmd.c (post_create_inferior): Replace throw_exception with
360         throw.
361         * inf-loop.c (inferior_event_handler): Replace throw_exception
362         with throw.
363         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
364         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
365         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
366         (get_prev_frame_always, get_frame_pc_if_available)
367         (get_frame_address_in_block_if_available, get_frame_language):
368         Replace throw_exception with throw.
369         * frame-unwind.c (frame_unwind_try_unwinder): Replace
370         throw_exception with throw.
371         * eval.c (fetch_subexp_value, evaluate_var_value)
372         (evaluate_funcall, evaluate_subexp_standard): Replace
373         throw_exception with throw.
374         * dwarf2loc.c (call_site_find_chain)
375         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
376         Replace throw_exception with throw.
377         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
378         with throw.
379         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
380         throw.
381         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
382         * completer.c (complete_line_internal): Replace throw_exception
383         with throw.
384         * compile/compile-object-run.c (compile_object_run): Replace
385         throw_exception with throw.
386         * cli/cli-script.c (process_next_line): Replace throw_exception
387         with throw.
388         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
389         (btrace_enable, btrace_maint_update_pt_packets): Replace
390         throw_exception with throw.
391         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
392         throw_exception with throw.
393         * break-catch-throw.c (re_set_exception_catchpoint): Replace
394         throw_exception with throw.
395         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
396         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
397         * aarch64-tdep.c (aarch64_make_prologue_cache)
398         (aarch64_make_stub_cache): Replace throw_exception with throw.
399
400 2019-04-08  Tom Tromey  <tom@tromey.com>
401
402         * common/common-exceptions.c (throw_exception): Rename from
403         throw_exception_cxx.  Remove old copy.  Make argument const.
404         (throw_it): Create and throw exception objects directly.
405         * common/common-exceptions.h (throw_exception): Make argument
406         const.
407         (struct gdb_exception_error): Add constructor.
408         (struct gdb_exception_quit): Add constructor.
409
410 2019-04-08  Tom Tromey  <tom@tromey.com>
411
412         * common/common-exceptions.h (exception_rethrow): Don't declare.
413         (TRY_SJLJ): Update comment.
414         (TRY, CATCH, END_CATCH): Remove.
415         * common/common-exceptions.c (exception_rethrow): Remove.
416
417 2019-04-08  Tom Tromey  <tom@tromey.com>
418
419         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
420         Remove.
421         (gdb_exception_error): Rename from
422         gdb_exception_RETURN_MASK_ERROR.
423         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
424         (gdb_quit_bad_alloc): Update.
425         * aarch64-tdep.c: Update.
426         * ada-lang.c: Update.
427         * ada-typeprint.c: Update.
428         * ada-valprint.c: Update.
429         * amd64-tdep.c: Update.
430         * arch-utils.c: Update.
431         * break-catch-throw.c: Update.
432         * breakpoint.c: Update.
433         * btrace.c: Update.
434         * c-varobj.c: Update.
435         * cli/cli-cmds.c: Update.
436         * cli/cli-interp.c: Update.
437         * cli/cli-script.c: Update.
438         * common/common-exceptions.c: Update.
439         * common/new-op.c: Update.
440         * common/selftest.c: Update.
441         * compile/compile-c-symbols.c: Update.
442         * compile/compile-cplus-symbols.c: Update.
443         * compile/compile-object-load.c: Update.
444         * compile/compile-object-run.c: Update.
445         * completer.c: Update.
446         * corelow.c: Update.
447         * cp-abi.c: Update.
448         * cp-support.c: Update.
449         * cp-valprint.c: Update.
450         * darwin-nat.c: Update.
451         * disasm-selftests.c: Update.
452         * dtrace-probe.c: Update.
453         * dwarf-index-cache.c: Update.
454         * dwarf-index-write.c: Update.
455         * dwarf2-frame-tailcall.c: Update.
456         * dwarf2-frame.c: Update.
457         * dwarf2loc.c: Update.
458         * dwarf2read.c: Update.
459         * eval.c: Update.
460         * event-loop.c: Update.
461         * event-top.c: Update.
462         * exec.c: Update.
463         * f-valprint.c: Update.
464         * fbsd-tdep.c: Update.
465         * frame-unwind.c: Update.
466         * frame.c: Update.
467         * gdbtypes.c: Update.
468         * gnu-v3-abi.c: Update.
469         * guile/guile-internal.h: Update.
470         * guile/scm-block.c: Update.
471         * guile/scm-breakpoint.c: Update.
472         * guile/scm-cmd.c: Update.
473         * guile/scm-disasm.c: Update.
474         * guile/scm-frame.c: Update.
475         * guile/scm-lazy-string.c: Update.
476         * guile/scm-math.c: Update.
477         * guile/scm-param.c: Update.
478         * guile/scm-ports.c: Update.
479         * guile/scm-pretty-print.c: Update.
480         * guile/scm-symbol.c: Update.
481         * guile/scm-symtab.c: Update.
482         * guile/scm-type.c: Update.
483         * guile/scm-value.c: Update.
484         * i386-linux-tdep.c: Update.
485         * i386-tdep.c: Update.
486         * inf-loop.c: Update.
487         * infcall.c: Update.
488         * infcmd.c: Update.
489         * infrun.c: Update.
490         * jit.c: Update.
491         * language.c: Update.
492         * linespec.c: Update.
493         * linux-fork.c: Update.
494         * linux-nat.c: Update.
495         * linux-tdep.c: Update.
496         * linux-thread-db.c: Update.
497         * main.c: Update.
498         * mi/mi-cmd-break.c: Update.
499         * mi/mi-cmd-stack.c: Update.
500         * mi/mi-interp.c: Update.
501         * mi/mi-main.c: Update.
502         * objc-lang.c: Update.
503         * p-valprint.c: Update.
504         * parse.c: Update.
505         * ppc-linux-tdep.c: Update.
506         * printcmd.c: Update.
507         * python/py-arch.c: Update.
508         * python/py-breakpoint.c: Update.
509         * python/py-cmd.c: Update.
510         * python/py-finishbreakpoint.c: Update.
511         * python/py-frame.c: Update.
512         * python/py-framefilter.c: Update.
513         * python/py-gdb-readline.c: Update.
514         * python/py-inferior.c: Update.
515         * python/py-infthread.c: Update.
516         * python/py-lazy-string.c: Update.
517         * python/py-linetable.c: Update.
518         * python/py-objfile.c: Update.
519         * python/py-param.c: Update.
520         * python/py-prettyprint.c: Update.
521         * python/py-progspace.c: Update.
522         * python/py-record-btrace.c: Update.
523         * python/py-record.c: Update.
524         * python/py-symbol.c: Update.
525         * python/py-type.c: Update.
526         * python/py-unwind.c: Update.
527         * python/py-utils.c: Update.
528         * python/py-value.c: Update.
529         * python/python.c: Update.
530         * record-btrace.c: Update.
531         * record-full.c: Update.
532         * remote-fileio.c: Update.
533         * remote.c: Update.
534         * riscv-tdep.c: Update.
535         * rs6000-aix-tdep.c: Update.
536         * rs6000-tdep.c: Update.
537         * rust-exp.y: Update.
538         * rust-lang.c: Update.
539         * s390-tdep.c: Update.
540         * selftest-arch.c: Update.
541         * solib-dsbt.c: Update.
542         * solib-frv.c: Update.
543         * solib-spu.c: Update.
544         * solib-svr4.c: Update.
545         * solib.c: Update.
546         * sparc64-linux-tdep.c: Update.
547         * stack.c: Update.
548         * symfile-mem.c: Update.
549         * symmisc.c: Update.
550         * target.c: Update.
551         * thread.c: Update.
552         * top.c: Update.
553         * tracefile-tfile.c: Update.
554         * tui/tui.c: Update.
555         * typeprint.c: Update.
556         * unittests/cli-utils-selftests.c: Update.
557         * unittests/parse-connection-spec-selftests.c: Update.
558         * valops.c: Update.
559         * valprint.c: Update.
560         * value.c: Update.
561         * varobj.c: Update.
562         * windows-nat.c: Update.
563         * x86-linux-nat.c: Update.
564         * xml-support.c: Update.
565
566 2019-04-08  Tom Tromey  <tom@tromey.com>
567
568         * xml-support.c: Use C++ exception handling.
569         * x86-linux-nat.c: Use C++ exception handling.
570         * windows-nat.c: Use C++ exception handling.
571         * varobj.c: Use C++ exception handling.
572         * value.c: Use C++ exception handling.
573         * valprint.c: Use C++ exception handling.
574         * valops.c: Use C++ exception handling.
575         * unittests/parse-connection-spec-selftests.c: Use C++ exception
576         handling.
577         * unittests/cli-utils-selftests.c: Use C++ exception handling.
578         * typeprint.c: Use C++ exception handling.
579         * tui/tui.c: Use C++ exception handling.
580         * tracefile-tfile.c: Use C++ exception handling.
581         * top.c: Use C++ exception handling.
582         * thread.c: Use C++ exception handling.
583         * target.c: Use C++ exception handling.
584         * symmisc.c: Use C++ exception handling.
585         * symfile-mem.c: Use C++ exception handling.
586         * stack.c: Use C++ exception handling.
587         * sparc64-linux-tdep.c: Use C++ exception handling.
588         * solib.c: Use C++ exception handling.
589         * solib-svr4.c: Use C++ exception handling.
590         * solib-spu.c: Use C++ exception handling.
591         * solib-frv.c: Use C++ exception handling.
592         * solib-dsbt.c: Use C++ exception handling.
593         * selftest-arch.c: Use C++ exception handling.
594         * s390-tdep.c: Use C++ exception handling.
595         * rust-lang.c: Use C++ exception handling.
596         * rust-exp.y: Use C++ exception handling.
597         * rs6000-tdep.c: Use C++ exception handling.
598         * rs6000-aix-tdep.c: Use C++ exception handling.
599         * riscv-tdep.c: Use C++ exception handling.
600         * remote.c: Use C++ exception handling.
601         * remote-fileio.c: Use C++ exception handling.
602         * record-full.c: Use C++ exception handling.
603         * record-btrace.c: Use C++ exception handling.
604         * python/python.c: Use C++ exception handling.
605         * python/py-value.c: Use C++ exception handling.
606         * python/py-utils.c: Use C++ exception handling.
607         * python/py-unwind.c: Use C++ exception handling.
608         * python/py-type.c: Use C++ exception handling.
609         * python/py-symbol.c: Use C++ exception handling.
610         * python/py-record.c: Use C++ exception handling.
611         * python/py-record-btrace.c: Use C++ exception handling.
612         * python/py-progspace.c: Use C++ exception handling.
613         * python/py-prettyprint.c: Use C++ exception handling.
614         * python/py-param.c: Use C++ exception handling.
615         * python/py-objfile.c: Use C++ exception handling.
616         * python/py-linetable.c: Use C++ exception handling.
617         * python/py-lazy-string.c: Use C++ exception handling.
618         * python/py-infthread.c: Use C++ exception handling.
619         * python/py-inferior.c: Use C++ exception handling.
620         * python/py-gdb-readline.c: Use C++ exception handling.
621         * python/py-framefilter.c: Use C++ exception handling.
622         * python/py-frame.c: Use C++ exception handling.
623         * python/py-finishbreakpoint.c: Use C++ exception handling.
624         * python/py-cmd.c: Use C++ exception handling.
625         * python/py-breakpoint.c: Use C++ exception handling.
626         * python/py-arch.c: Use C++ exception handling.
627         * printcmd.c: Use C++ exception handling.
628         * ppc-linux-tdep.c: Use C++ exception handling.
629         * parse.c: Use C++ exception handling.
630         * p-valprint.c: Use C++ exception handling.
631         * objc-lang.c: Use C++ exception handling.
632         * mi/mi-main.c: Use C++ exception handling.
633         * mi/mi-interp.c: Use C++ exception handling.
634         * mi/mi-cmd-stack.c: Use C++ exception handling.
635         * mi/mi-cmd-break.c: Use C++ exception handling.
636         * main.c: Use C++ exception handling.
637         * linux-thread-db.c: Use C++ exception handling.
638         * linux-tdep.c: Use C++ exception handling.
639         * linux-nat.c: Use C++ exception handling.
640         * linux-fork.c: Use C++ exception handling.
641         * linespec.c: Use C++ exception handling.
642         * language.c: Use C++ exception handling.
643         * jit.c: Use C++ exception handling.
644         * infrun.c: Use C++ exception handling.
645         * infcmd.c: Use C++ exception handling.
646         * infcall.c: Use C++ exception handling.
647         * inf-loop.c: Use C++ exception handling.
648         * i386-tdep.c: Use C++ exception handling.
649         * i386-linux-tdep.c: Use C++ exception handling.
650         * guile/scm-value.c: Use C++ exception handling.
651         * guile/scm-type.c: Use C++ exception handling.
652         * guile/scm-symtab.c: Use C++ exception handling.
653         * guile/scm-symbol.c: Use C++ exception handling.
654         * guile/scm-pretty-print.c: Use C++ exception handling.
655         * guile/scm-ports.c: Use C++ exception handling.
656         * guile/scm-param.c: Use C++ exception handling.
657         * guile/scm-math.c: Use C++ exception handling.
658         * guile/scm-lazy-string.c: Use C++ exception handling.
659         * guile/scm-frame.c: Use C++ exception handling.
660         * guile/scm-disasm.c: Use C++ exception handling.
661         * guile/scm-cmd.c: Use C++ exception handling.
662         * guile/scm-breakpoint.c: Use C++ exception handling.
663         * guile/scm-block.c: Use C++ exception handling.
664         * guile/guile-internal.h: Use C++ exception handling.
665         * gnu-v3-abi.c: Use C++ exception handling.
666         * gdbtypes.c: Use C++ exception handling.
667         * frame.c: Use C++ exception handling.
668         * frame-unwind.c: Use C++ exception handling.
669         * fbsd-tdep.c: Use C++ exception handling.
670         * f-valprint.c: Use C++ exception handling.
671         * exec.c: Use C++ exception handling.
672         * event-top.c: Use C++ exception handling.
673         * event-loop.c: Use C++ exception handling.
674         * eval.c: Use C++ exception handling.
675         * dwarf2read.c: Use C++ exception handling.
676         * dwarf2loc.c: Use C++ exception handling.
677         * dwarf2-frame.c: Use C++ exception handling.
678         * dwarf2-frame-tailcall.c: Use C++ exception handling.
679         * dwarf-index-write.c: Use C++ exception handling.
680         * dwarf-index-cache.c: Use C++ exception handling.
681         * dtrace-probe.c: Use C++ exception handling.
682         * disasm-selftests.c: Use C++ exception handling.
683         * darwin-nat.c: Use C++ exception handling.
684         * cp-valprint.c: Use C++ exception handling.
685         * cp-support.c: Use C++ exception handling.
686         * cp-abi.c: Use C++ exception handling.
687         * corelow.c: Use C++ exception handling.
688         * completer.c: Use C++ exception handling.
689         * compile/compile-object-run.c: Use C++ exception handling.
690         * compile/compile-object-load.c: Use C++ exception handling.
691         * compile/compile-cplus-symbols.c: Use C++ exception handling.
692         * compile/compile-c-symbols.c: Use C++ exception handling.
693         * common/selftest.c: Use C++ exception handling.
694         * common/new-op.c: Use C++ exception handling.
695         * cli/cli-script.c: Use C++ exception handling.
696         * cli/cli-interp.c: Use C++ exception handling.
697         * cli/cli-cmds.c: Use C++ exception handling.
698         * c-varobj.c: Use C++ exception handling.
699         * btrace.c: Use C++ exception handling.
700         * breakpoint.c: Use C++ exception handling.
701         * break-catch-throw.c: Use C++ exception handling.
702         * arch-utils.c: Use C++ exception handling.
703         * amd64-tdep.c: Use C++ exception handling.
704         * ada-valprint.c: Use C++ exception handling.
705         * ada-typeprint.c: Use C++ exception handling.
706         * ada-lang.c: Use C++ exception handling.
707         * aarch64-tdep.c: Use C++ exception handling.
708
709 2019-04-08  Tom Tromey  <tom@tromey.com>
710
711         * xml-support.c (gdb_xml_parser::parse): Update.
712         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
713         * value.c (show_convenience): Update.
714         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
715         (test_parse_flags_qcs): Update.
716         * thread.c (thr_try_catch_cmd): Update.
717         * target.c (target_translate_tls_address): Update.
718         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
719         (info_frame_command_core, frame_apply_command_count): Update.
720         * rust-exp.y (rust_lex_exception_test): Update.
721         * riscv-tdep.c (riscv_print_one_register_info): Update.
722         * remote.c (remote_target::enable_btrace): Update.
723         * record-btrace.c (record_btrace_enable_warn): Update.
724         * python/py-utils.c (gdbpy_convert_exception): Update.
725         * printcmd.c (do_one_display, print_variable_and_value): Update.
726         * mi/mi-main.c (mi_print_exception): Update.
727         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
728         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
729         * linux-nat.c (linux_nat_target::attach): Update.
730         * linux-fork.c (class scoped_switch_fork_info): Update.
731         * infrun.c (displaced_step_prepare): Update.
732         * infcall.c (call_function_by_hand_dummy): Update.
733         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
734         * gnu-v3-abi.c (print_one_vtable): Update.
735         * frame.c (get_prev_frame_always): Update.
736         * f-valprint.c (info_common_command_for_block): Update.
737         * exec.c (try_open_exec_file): Update.
738         * exceptions.c (print_exception, exception_print)
739         (exception_fprintf, exception_print_same): Update.
740         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
741         * dwarf-index-cache.c (index_cache::store)
742         (index_cache::lookup_gdb_index): Update.
743         * darwin-nat.c (maybe_cache_shell): Update.
744         * cp-valprint.c (cp_print_value_fields): Update.
745         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
746         (gcc_cplus_symbol_address): Update.
747         * compile/compile-c-symbols.c (gcc_convert_symbol)
748         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
749         * common/selftest.c: Update.
750         * common/common-exceptions.h (struct gdb_exception) <message>: Now
751         a std::string.
752         (exception_try_scope_entry, exception_try_scope_exit): Don't
753         declare.
754         (struct exception_try_scope): Remove.
755         (TRY): Don't use exception_try_scope.
756         (struct gdb_exception): Add constructor, operator=.
757         <what>: New method.
758         (struct gdb_exception_RETURN_MASK_ALL)
759         (struct gdb_exception_RETURN_MASK_ERROR)
760         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
761         (struct gdb_quit_bad_alloc): Update.
762         * common/common-exceptions.c (exception_none): Change
763         initializer.
764         (struct catcher) <state, exception>: Initialize inline.
765         <prev>: Remove member.
766         (current_catcher): Remove.
767         (catchers): New global.
768         (exceptions_state_mc_init): Simplify.
769         (catcher_pop): Remove.
770         (exceptions_state_mc, exceptions_state_mc_catch): Update.
771         (try_scope_depth, exception_try_scope_entry)
772         (exception_try_scope_exit): Remove.
773         (throw_exception_sjlj): Update.
774         (exception_messages, exception_messages_size): Remove.
775         (throw_it): Simplify.
776         (gdb_exception_sliced_copy): Remove.
777         (throw_exception_cxx): Update.
778         * cli/cli-script.c (script_from_file): Update.
779         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
780         Update.
781         * ada-valprint.c (ada_val_print): Update.
782         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
783         (create_excep_cond_exprs): Update.
784
785 2019-04-08  Tom Tromey  <tom@tromey.com>
786
787         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
788         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
789         (TRY, CATCH, END_CATCH): Remove some definitions.
790         * common/common-exceptions.c: Don't use GDB_XCPT.
791         (catcher_list_size): Remove.
792         (throw_exception, throw_it): Simplify.
793
794 2019-04-05  Tom Tromey  <tom@tromey.com>
795
796         Revert the header-sorting patch.
797         * ft32-tdep.c: Revert.
798         * frv-tdep.c: Revert.
799         * frv-linux-tdep.c: Revert.
800         * frame.c: Revert.
801         * frame-unwind.c: Revert.
802         * frame-base.c: Revert.
803         * fork-child.c: Revert.
804         * findvar.c: Revert.
805         * findcmd.c: Revert.
806         * filesystem.c: Revert.
807         * filename-seen-cache.h: Revert.
808         * filename-seen-cache.c: Revert.
809         * fbsd-tdep.c: Revert.
810         * fbsd-nat.h: Revert.
811         * fbsd-nat.c: Revert.
812         * f-valprint.c: Revert.
813         * f-typeprint.c: Revert.
814         * f-lang.c: Revert.
815         * extension.h: Revert.
816         * extension.c: Revert.
817         * extension-priv.h: Revert.
818         * expprint.c: Revert.
819         * exec.h: Revert.
820         * exec.c: Revert.
821         * exceptions.c: Revert.
822         * event-top.c: Revert.
823         * event-loop.c: Revert.
824         * eval.c: Revert.
825         * elfread.c: Revert.
826         * dwarf2read.h: Revert.
827         * dwarf2read.c: Revert.
828         * dwarf2loc.c: Revert.
829         * dwarf2expr.h: Revert.
830         * dwarf2expr.c: Revert.
831         * dwarf2-frame.c: Revert.
832         * dwarf2-frame-tailcall.c: Revert.
833         * dwarf-index-write.h: Revert.
834         * dwarf-index-write.c: Revert.
835         * dwarf-index-common.c: Revert.
836         * dwarf-index-cache.h: Revert.
837         * dwarf-index-cache.c: Revert.
838         * dummy-frame.c: Revert.
839         * dtrace-probe.c: Revert.
840         * disasm.h: Revert.
841         * disasm.c: Revert.
842         * disasm-selftests.c: Revert.
843         * dictionary.c: Revert.
844         * dicos-tdep.c: Revert.
845         * demangle.c: Revert.
846         * dcache.h: Revert.
847         * dcache.c: Revert.
848         * darwin-nat.h: Revert.
849         * darwin-nat.c: Revert.
850         * darwin-nat-info.c: Revert.
851         * d-valprint.c: Revert.
852         * d-namespace.c: Revert.
853         * d-lang.c: Revert.
854         * ctf.c: Revert.
855         * csky-tdep.c: Revert.
856         * csky-linux-tdep.c: Revert.
857         * cris-tdep.c: Revert.
858         * cris-linux-tdep.c: Revert.
859         * cp-valprint.c: Revert.
860         * cp-support.c: Revert.
861         * cp-namespace.c: Revert.
862         * cp-abi.c: Revert.
863         * corelow.c: Revert.
864         * corefile.c: Revert.
865         * continuations.c: Revert.
866         * completer.h: Revert.
867         * completer.c: Revert.
868         * complaints.c: Revert.
869         * coffread.c: Revert.
870         * coff-pe-read.c: Revert.
871         * cli-out.h: Revert.
872         * cli-out.c: Revert.
873         * charset.c: Revert.
874         * c-varobj.c: Revert.
875         * c-valprint.c: Revert.
876         * c-typeprint.c: Revert.
877         * c-lang.c: Revert.
878         * buildsym.c: Revert.
879         * buildsym-legacy.c: Revert.
880         * build-id.h: Revert.
881         * build-id.c: Revert.
882         * btrace.c: Revert.
883         * bsd-uthread.c: Revert.
884         * breakpoint.h: Revert.
885         * breakpoint.c: Revert.
886         * break-catch-throw.c: Revert.
887         * break-catch-syscall.c: Revert.
888         * break-catch-sig.c: Revert.
889         * blockframe.c: Revert.
890         * block.c: Revert.
891         * bfin-tdep.c: Revert.
892         * bfin-linux-tdep.c: Revert.
893         * bfd-target.c: Revert.
894         * bcache.c: Revert.
895         * ax-general.c: Revert.
896         * ax-gdb.h: Revert.
897         * ax-gdb.c: Revert.
898         * avr-tdep.c: Revert.
899         * auxv.c: Revert.
900         * auto-load.c: Revert.
901         * arm-wince-tdep.c: Revert.
902         * arm-tdep.c: Revert.
903         * arm-symbian-tdep.c: Revert.
904         * arm-pikeos-tdep.c: Revert.
905         * arm-obsd-tdep.c: Revert.
906         * arm-nbsd-tdep.c: Revert.
907         * arm-nbsd-nat.c: Revert.
908         * arm-linux-tdep.c: Revert.
909         * arm-linux-nat.c: Revert.
910         * arm-fbsd-tdep.c: Revert.
911         * arm-fbsd-nat.c: Revert.
912         * arm-bsd-tdep.c: Revert.
913         * arch-utils.c: Revert.
914         * arc-tdep.c: Revert.
915         * arc-newlib-tdep.c: Revert.
916         * annotate.h: Revert.
917         * annotate.c: Revert.
918         * amd64-windows-tdep.c: Revert.
919         * amd64-windows-nat.c: Revert.
920         * amd64-tdep.c: Revert.
921         * amd64-sol2-tdep.c: Revert.
922         * amd64-obsd-tdep.c: Revert.
923         * amd64-obsd-nat.c: Revert.
924         * amd64-nbsd-tdep.c: Revert.
925         * amd64-nbsd-nat.c: Revert.
926         * amd64-nat.c: Revert.
927         * amd64-linux-tdep.c: Revert.
928         * amd64-linux-nat.c: Revert.
929         * amd64-fbsd-tdep.c: Revert.
930         * amd64-fbsd-nat.c: Revert.
931         * amd64-dicos-tdep.c: Revert.
932         * amd64-darwin-tdep.c: Revert.
933         * amd64-bsd-nat.c: Revert.
934         * alpha-tdep.c: Revert.
935         * alpha-obsd-tdep.c: Revert.
936         * alpha-nbsd-tdep.c: Revert.
937         * alpha-mdebug-tdep.c: Revert.
938         * alpha-linux-tdep.c: Revert.
939         * alpha-linux-nat.c: Revert.
940         * alpha-bsd-tdep.c: Revert.
941         * alpha-bsd-nat.c: Revert.
942         * aix-thread.c: Revert.
943         * agent.c: Revert.
944         * addrmap.c: Revert.
945         * ada-varobj.c: Revert.
946         * ada-valprint.c: Revert.
947         * ada-typeprint.c: Revert.
948         * ada-tasks.c: Revert.
949         * ada-lang.c: Revert.
950         * aarch64-tdep.c: Revert.
951         * aarch64-ravenscar-thread.c: Revert.
952         * aarch64-newlib-tdep.c: Revert.
953         * aarch64-linux-tdep.c: Revert.
954         * aarch64-linux-nat.c: Revert.
955         * aarch64-fbsd-tdep.c: Revert.
956         * aarch64-fbsd-nat.c: Revert.
957         * aarch32-linux-nat.c: Revert.
958
959 2019-04-05  Tom Tromey  <tom@tromey.com>
960
961         * ft32-tdep.c: Sort headers.
962         * frv-tdep.c: Sort headers.
963         * frv-linux-tdep.c: Sort headers.
964         * frame.c: Sort headers.
965         * frame-unwind.c: Sort headers.
966         * frame-base.c: Sort headers.
967         * fork-child.c: Sort headers.
968         * findvar.c: Sort headers.
969         * findcmd.c: Sort headers.
970         * filesystem.c: Sort headers.
971         * filename-seen-cache.h: Sort headers.
972         * filename-seen-cache.c: Sort headers.
973         * fbsd-tdep.c: Sort headers.
974         * fbsd-nat.h: Sort headers.
975         * fbsd-nat.c: Sort headers.
976         * f-valprint.c: Sort headers.
977         * f-typeprint.c: Sort headers.
978         * f-lang.c: Sort headers.
979         * extension.h: Sort headers.
980         * extension.c: Sort headers.
981         * extension-priv.h: Sort headers.
982         * expprint.c: Sort headers.
983         * exec.h: Sort headers.
984         * exec.c: Sort headers.
985         * exceptions.c: Sort headers.
986         * event-top.c: Sort headers.
987         * event-loop.c: Sort headers.
988         * eval.c: Sort headers.
989         * elfread.c: Sort headers.
990         * dwarf2read.h: Sort headers.
991         * dwarf2read.c: Sort headers.
992         * dwarf2loc.c: Sort headers.
993         * dwarf2expr.h: Sort headers.
994         * dwarf2expr.c: Sort headers.
995         * dwarf2-frame.c: Sort headers.
996         * dwarf2-frame-tailcall.c: Sort headers.
997         * dwarf-index-write.h: Sort headers.
998         * dwarf-index-write.c: Sort headers.
999         * dwarf-index-common.c: Sort headers.
1000         * dwarf-index-cache.h: Sort headers.
1001         * dwarf-index-cache.c: Sort headers.
1002         * dummy-frame.c: Sort headers.
1003         * dtrace-probe.c: Sort headers.
1004         * disasm.h: Sort headers.
1005         * disasm.c: Sort headers.
1006         * disasm-selftests.c: Sort headers.
1007         * dictionary.c: Sort headers.
1008         * dicos-tdep.c: Sort headers.
1009         * demangle.c: Sort headers.
1010         * dcache.h: Sort headers.
1011         * dcache.c: Sort headers.
1012         * darwin-nat.h: Sort headers.
1013         * darwin-nat.c: Sort headers.
1014         * darwin-nat-info.c: Sort headers.
1015         * d-valprint.c: Sort headers.
1016         * d-namespace.c: Sort headers.
1017         * d-lang.c: Sort headers.
1018         * ctf.c: Sort headers.
1019         * csky-tdep.c: Sort headers.
1020         * csky-linux-tdep.c: Sort headers.
1021         * cris-tdep.c: Sort headers.
1022         * cris-linux-tdep.c: Sort headers.
1023         * cp-valprint.c: Sort headers.
1024         * cp-support.c: Sort headers.
1025         * cp-namespace.c: Sort headers.
1026         * cp-abi.c: Sort headers.
1027         * corelow.c: Sort headers.
1028         * corefile.c: Sort headers.
1029         * continuations.c: Sort headers.
1030         * completer.h: Sort headers.
1031         * completer.c: Sort headers.
1032         * complaints.c: Sort headers.
1033         * coffread.c: Sort headers.
1034         * coff-pe-read.c: Sort headers.
1035         * cli-out.h: Sort headers.
1036         * cli-out.c: Sort headers.
1037         * charset.c: Sort headers.
1038         * c-varobj.c: Sort headers.
1039         * c-valprint.c: Sort headers.
1040         * c-typeprint.c: Sort headers.
1041         * c-lang.c: Sort headers.
1042         * buildsym.c: Sort headers.
1043         * buildsym-legacy.c: Sort headers.
1044         * build-id.h: Sort headers.
1045         * build-id.c: Sort headers.
1046         * btrace.c: Sort headers.
1047         * bsd-uthread.c: Sort headers.
1048         * breakpoint.h: Sort headers.
1049         * breakpoint.c: Sort headers.
1050         * break-catch-throw.c: Sort headers.
1051         * break-catch-syscall.c: Sort headers.
1052         * break-catch-sig.c: Sort headers.
1053         * blockframe.c: Sort headers.
1054         * block.c: Sort headers.
1055         * bfin-tdep.c: Sort headers.
1056         * bfin-linux-tdep.c: Sort headers.
1057         * bfd-target.c: Sort headers.
1058         * bcache.c: Sort headers.
1059         * ax-general.c: Sort headers.
1060         * ax-gdb.h: Sort headers.
1061         * ax-gdb.c: Sort headers.
1062         * avr-tdep.c: Sort headers.
1063         * auxv.c: Sort headers.
1064         * auto-load.c: Sort headers.
1065         * arm-wince-tdep.c: Sort headers.
1066         * arm-tdep.c: Sort headers.
1067         * arm-symbian-tdep.c: Sort headers.
1068         * arm-pikeos-tdep.c: Sort headers.
1069         * arm-obsd-tdep.c: Sort headers.
1070         * arm-nbsd-tdep.c: Sort headers.
1071         * arm-nbsd-nat.c: Sort headers.
1072         * arm-linux-tdep.c: Sort headers.
1073         * arm-linux-nat.c: Sort headers.
1074         * arm-fbsd-tdep.c: Sort headers.
1075         * arm-fbsd-nat.c: Sort headers.
1076         * arm-bsd-tdep.c: Sort headers.
1077         * arch-utils.c: Sort headers.
1078         * arc-tdep.c: Sort headers.
1079         * arc-newlib-tdep.c: Sort headers.
1080         * annotate.h: Sort headers.
1081         * annotate.c: Sort headers.
1082         * amd64-windows-tdep.c: Sort headers.
1083         * amd64-windows-nat.c: Sort headers.
1084         * amd64-tdep.c: Sort headers.
1085         * amd64-sol2-tdep.c: Sort headers.
1086         * amd64-obsd-tdep.c: Sort headers.
1087         * amd64-obsd-nat.c: Sort headers.
1088         * amd64-nbsd-tdep.c: Sort headers.
1089         * amd64-nbsd-nat.c: Sort headers.
1090         * amd64-nat.c: Sort headers.
1091         * amd64-linux-tdep.c: Sort headers.
1092         * amd64-linux-nat.c: Sort headers.
1093         * amd64-fbsd-tdep.c: Sort headers.
1094         * amd64-fbsd-nat.c: Sort headers.
1095         * amd64-dicos-tdep.c: Sort headers.
1096         * amd64-darwin-tdep.c: Sort headers.
1097         * amd64-bsd-nat.c: Sort headers.
1098         * alpha-tdep.c: Sort headers.
1099         * alpha-obsd-tdep.c: Sort headers.
1100         * alpha-nbsd-tdep.c: Sort headers.
1101         * alpha-mdebug-tdep.c: Sort headers.
1102         * alpha-linux-tdep.c: Sort headers.
1103         * alpha-linux-nat.c: Sort headers.
1104         * alpha-bsd-tdep.c: Sort headers.
1105         * alpha-bsd-nat.c: Sort headers.
1106         * aix-thread.c: Sort headers.
1107         * agent.c: Sort headers.
1108         * addrmap.c: Sort headers.
1109         * ada-varobj.c: Sort headers.
1110         * ada-valprint.c: Sort headers.
1111         * ada-typeprint.c: Sort headers.
1112         * ada-tasks.c: Sort headers.
1113         * ada-lang.c: Sort headers.
1114         * aarch64-tdep.c: Sort headers.
1115         * aarch64-ravenscar-thread.c: Sort headers.
1116         * aarch64-newlib-tdep.c: Sort headers.
1117         * aarch64-linux-tdep.c: Sort headers.
1118         * aarch64-linux-nat.c: Sort headers.
1119         * aarch64-fbsd-tdep.c: Sort headers.
1120         * aarch64-fbsd-nat.c: Sort headers.
1121         * aarch32-linux-nat.c: Sort headers.
1122
1123 2019-04-04  Tom Tromey  <tom@tromey.com>
1124
1125         * varobj.c (varobj_create): Update.
1126         * rust-exp.y (struct rust_parser) <update_innermost_block,
1127         lookup_symbol>: New methods.
1128         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
1129         Rename.
1130         (rust_parser::rust_lookup_type)
1131         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1132         * printcmd.c (display_command, do_one_display): Update.
1133         * parser-defs.h (struct parser_state) <parser_state>: Add
1134         "tracker" parameter.
1135         (block_tracker): New member.
1136         (class innermost_block_tracker) <innermost_block_tracker>: Add
1137         "types" parameter.
1138         <reset>: Remove method.
1139         (innermost_block): Don't declare.
1140         (null_post_parser): Update.
1141         * parse.c (innermost_block): Remove global.
1142         (write_dollar_variable): Update.
1143         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
1144         Remove "tracker_types" parameter.
1145         (parse_expression): Add "tracker" parameter.
1146         (parse_expression_for_completion): Update.
1147         (null_post_parser): Add "tracker" parameter.
1148         * p-exp.y: Update rules.
1149         * m2-exp.y: Update rules.
1150         * language.h (struct language_defn) <la_post_parser>: Add
1151         "tracker" parameter.
1152         * go-exp.y: Update rules.
1153         * f-exp.y: Update rules.
1154         * expression.h (parse_expression, parse_exp_1): Add "tracker"
1155         parameter.
1156         * d-exp.y: Update rules.
1157         * c-exp.y: Update rules.
1158         * breakpoint.c (set_breakpoint_condition): Create an
1159         innermost_block_tracker.
1160         (watch_command_1): Likewise.
1161         * ada-lang.c (resolve): Add "tracker" parameter.
1162         (resolve_subexp): Likewise.
1163         * ada-exp.y (write_var_from_sym): Update.
1164
1165 2019-04-04  Tom Tromey  <tom@tromey.com>
1166
1167         * type-stack.h: New file.
1168         * type-stack.c: New file.
1169         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
1170         type-stack.h.
1171         (insert_into_type_stack, insert_type, push_type, push_type_int)
1172         (insert_type_address_space, pop_type, pop_type_int)
1173         (pop_typelist, pop_type_stack, append_type_stack)
1174         (push_type_stack, get_type_stack, push_typelist)
1175         (follow_type_instance_flags, follow_types): Don't declare.
1176         * parse.c (type_stack): Remove global.
1177         (parse_exp_in_context): Update.
1178         (insert_into_type_stack, insert_type, push_type, push_type_int)
1179         (insert_type_address_space, pop_type, pop_type_int)
1180         (pop_typelist, pop_type_stack, append_type_stack)
1181         (push_type_stack, get_type_stack, push_typelist)
1182         (follow_type_instance_flags, follow_types): Remove (moved to
1183         type-stack.c).
1184         * f-exp.y (type_stack): New global.
1185         Update rules.
1186         (push_kind_type, f_parse): Update.
1187         * d-exp.y (type_stack): New global.
1188         Update rules.
1189         (d_parse): Update.
1190         * c-exp.y (struct c_parse_state) <type_stack>: New member.
1191         Update rules.
1192         * Makefile.in (COMMON_SFILES): Add type-stack.c.
1193         (HFILES_NO_SRCDIR): Add type-stack.h.
1194
1195 2019-04-04  Tom Tromey  <tom@tromey.com>
1196
1197         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
1198         (rust_parser::convert_ast_to_expression, rust_parse)
1199         (rust_lex_test_completion, rust_lex_tests): Update.
1200         * parser-defs.h (struct expr_completion_state): New.
1201         (struct parser_state) <parser_state>: Add completion parameter.
1202         <mark_struct_expression, mark_completion_tag>: New methods.
1203         <parse_completion, m_completion_state>: New members.
1204         (prefixify_expression, null_post_parser): Update.
1205         (mark_struct_expression, mark_completion_tag): Don't declare.
1206         * parse.c (parse_completion, expout_last_struct)
1207         (expout_tag_completion_type, expout_completion_name): Remove
1208         globals.
1209         (parser_state::mark_struct_expression)
1210         (parser_state::mark_completion_tag): Now methods.
1211         (prefixify_expression): Add last_struct parameter.
1212         (prefixify_subexp): Likewise.
1213         (parse_exp_1): Update.
1214         (parse_exp_in_context): Add cstate parameter.  Update.
1215         (parse_expression_for_completion): Create an
1216         expr_completion_state.
1217         (null_post_parser): Add "completion" parameter.
1218         * p-exp.y: Update rules.
1219         (yylex): Update.
1220         * language.h (struct language_defn) <la_post_parser>: Add
1221         "completing" parameter.
1222         * go-exp.y: Update rules.
1223         (lex_one_token): Update.
1224         * expression.h (parse_completion): Don't declare.
1225         * d-exp.y: Update rules.
1226         (lex_one_token): Update rules.
1227         * c-exp.y: Update rules.
1228         (lex_one_token): Update.
1229         * ada-lang.c (resolve): Add "parse_completion" parameter.
1230         (resolve_subexp): Likewise.
1231         (ada_resolve_function): Likewise.
1232
1233 2019-04-04  Tom Tromey  <tom@tromey.com>
1234
1235         * parser-defs.h (struct parser_state) <start_arglist,
1236         end_arglist>: New methods.
1237         <arglist_len, m_funcall_chain>: New members.
1238         (arglist_len, start_arglist, end_arglist): Don't declare.
1239         * parse.c (arglist_len, funcall_chain): Remove global.
1240         (start_arglist, end_arglist): Remove functions.
1241         (parse_exp_in_context): Update.
1242         * p-exp.y: Update rules.
1243         * m2-exp.y: Update rules.
1244         * go-exp.y: Update rules.
1245         * f-exp.y: Update rules.
1246         * d-exp.y: Update rules.
1247         * c-exp.y: Update rules.
1248
1249 2019-04-04  Tom Tromey  <tom@tromey.com>
1250
1251         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
1252         lex_operator, push_back>: New methods.
1253         Update all rules.
1254         (rust_parser::lex_hex, lex_escape): Rename and update.
1255         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
1256         (rust_parser::lex_operator): Rename and update.
1257         (rust_parser::lex_number, rustyylex, rustyyerror)
1258         (rust_lex_test_init, rust_lex_test_sequence)
1259         (rust_lex_test_push_back, rust_lex_tests): Update.
1260         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
1261         parameter.
1262         <lexptr, prev_lexptr>: New members.
1263         (lexptr, prev_lexptr): Don't declare.
1264         * parse.c (lexptr, prev_lexptr): Remove globals.
1265         (parse_exp_in_context): Update.
1266         * p-exp.y (yylex, yyerror): Update.
1267         * m2-exp.y (parse_number, yylex, yyerror): Update.
1268         * go-exp.y (lex_one_token, yyerror): Update.
1269         * f-exp.y (match_string_literal, yylex, yyerror): Update.
1270         * d-exp.y (lex_one_token, yyerror): Update.
1271         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
1272         (lex_one_token, yyerror): Update.
1273         * ada-lex.l (YY_INPUT): Update.
1274         (rewind_to_char): Update.
1275         * ada-exp.y (yyerror): Update.
1276
1277 2019-04-04  Tom Tromey  <tom@tromey.com>
1278
1279         * rust-exp.y (rustyylex, rust_lex_tests): Update.
1280         * parser-defs.h (struct parser_state) <parser_state>: Add new
1281         parameter.
1282         <comma_terminates>: New member.
1283         (comma_terminates): Don't declare global.
1284         * parse.c (comma_terminates): Remove global.
1285         (parse_exp_in_context): Update.
1286         * p-exp.y (yylex): Update.
1287         * m2-exp.y (yylex): Update.
1288         * go-exp.y (lex_one_token): Update.
1289         * f-exp.y (yylex): Update.
1290         * d-exp.y (lex_one_token): Update.
1291         * c-exp.y (lex_one_token): Update.
1292         * ada-lex.l: Update.
1293
1294 2019-04-04  Tom Tromey  <tom@tromey.com>
1295
1296         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
1297         (rustyylex, rust_lex_test_init, rust_lex_test_one)
1298         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
1299         * parser-defs.h (paren_depth): Don't declare.
1300         * parse.c (paren_depth): Remove global.
1301         (parse_exp_in_context): Update.
1302         * p-exp.y (paren_depth): New global.
1303         (pascal_parse): Initialize it.
1304         * m2-exp.y (paren_depth): New global.
1305         (m2_parse): Initialize it.
1306         * go-exp.y (paren_depth): New global.
1307         (go_parse): Initialize it.
1308         * f-exp.y (paren_depth): New global.
1309         (f_parse): Initialize it.
1310         * d-exp.y (paren_depth): New global.
1311         (d_parse): Initialize it.
1312         * c-exp.y (paren_depth): New global.
1313         (c_parse): Initialize it.
1314         * ada-lex.l (paren_depth): New global.
1315         (lexer_init): Initialize it.
1316
1317 2019-04-04  Tom Tromey  <tom@tromey.com>
1318
1319         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
1320         (rust_parser::convert_ast_to_type)
1321         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1322         * parser-defs.h (struct parser_state) <parser_state>: Add
1323         parameters.  Initialize new members.
1324         <expression_context_block, expression_context_pc>: New members.
1325         * parse.c (expression_context_block, expression_context_pc):
1326         Remove globals.
1327         (parse_exp_in_context): Update.
1328         * p-exp.y: Update all rules.
1329         (yylex): Update.
1330         * m2-exp.y: Update all rules.
1331         (yylex): Update.
1332         * go-exp.y (yylex): Update.
1333         * f-exp.y (yylex): Update.
1334         * d-exp.y: Update all rules.
1335         (yylex): Update.
1336         * c-exp.y: Update all rules.
1337         (lex_one_token, classify_name, yylex, c_parse): Update.
1338         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
1339
1340 2019-04-04  Tom Tromey  <tom@tromey.com>
1341
1342         * gdbarch.h, gdbarch.c: Rebuild.
1343         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
1344         * stap-probe.h: 
1345         (struct stap_parse_info): Replace "parser_state" with
1346         "expr_builder".
1347         * parser-defs.h (struct expr_builder): Rename from "parser_state".
1348         (parser_state): New class.
1349         * parse.c (expr_builder): Rename.
1350         (expr_builder::release): Rename.
1351         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
1352         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
1353         (write_exp_elt_longcst, write_exp_elt_floatcst)
1354         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
1355         (write_exp_string_vector, write_exp_bitstring)
1356         (write_exp_msymbol, mark_struct_expression)
1357         (write_dollar_variable)
1358         (insert_type_address_space, increase_expout_size): Replace
1359         "parser_state" with "expr_builder".
1360         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
1361         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
1362         "parser_state" with "expr_builder".
1363
1364 2019-04-04  Tom Tromey  <tom@tromey.com>
1365
1366         * rust-exp.y: Replace "parse_language" with method call.
1367         * p-exp.y: 
1368         (yylex): Replace "parse_language" with method call.
1369         * m2-exp.y: 
1370         (yylex): Replace "parse_language" with method call.
1371         * go-exp.y (classify_name): Replace "parse_language" with method
1372         call.
1373         * f-exp.y (yylex): Replace "parse_language" with method call.
1374         * d-exp.y (lex_one_token): Replace "parse_language" with method
1375         call.
1376         * c-exp.y: 
1377         (lex_one_token, classify_name, yylex): Replace "parse_language"
1378         with method call.
1379         * ada-exp.y (find_primitive_type, type_char)
1380         (type_system_address): Replace "parse_language" with method call.
1381
1382 2019-04-04  Tom Tromey  <tom@tromey.com>
1383
1384         * rust-exp.y: Replace "parse_gdbarch" with method call.
1385         * parse.c (write_dollar_variable, insert_type_address_space):
1386         Replace "parse_gdbarch" with method call.
1387         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
1388         call.
1389         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
1390         call.
1391         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
1392         "parse_gdbarch" with method call.
1393         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
1394         with method call.
1395         * f-exp.y (parse_type, parse_f_type, yylex): Replace
1396         "parse_gdbarch" with method call.
1397         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
1398         "parse_gdbarch" with method call.
1399         * c-exp.y (parse_type, parse_number, classify_name): Replace
1400         "parse_gdbarch" with method call.
1401         * ada-lex.l: Replace "parse_gdbarch" with method call.
1402         * ada-exp.y (parse_type, find_primitive_type, type_char)
1403         (type_system_address): Replace "parse_gdbarch" with method call.
1404
1405 2019-04-04  Tom Tromey  <tom@tromey.com>
1406
1407         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
1408         * stap-probe.c (stap_parse_argument): Update.
1409         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
1410         initial_size parameter.
1411         * rust-exp.y (rust_lex_tests): Update.
1412         * parse.c (parser_state): Update.
1413         (parse_exp_in_context): Update.
1414         * parser-defs.h (struct parser_state) <parser_state>: Remove
1415         "initial_size" parameter.
1416
1417 2019-04-04  Tom Tromey  <tom@tromey.com>
1418
1419         * parser-defs.h (increase_expout_size): Don't declare.
1420         * parse.c (increase_expout_size): Now static.
1421
1422 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
1423
1424         * gnu-nat.c (gnu_nat_target::wait): Fix
1425         target_waitstatus_to_string call.
1426
1427 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1428
1429         * eval.c (evaluate_subexp_standard): Handle internal functions
1430         during Fortran function call handling.
1431
1432 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1433
1434         * NEWS: Mention new internal functions.
1435         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
1436         (read_base_type): Use dwarf2_init_complex_target_type.
1437         * value.c (creal_internal_fn): New function.
1438         (cimag_internal_fn): New function.
1439         (_initialize_values): Register new internal functions.
1440
1441 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1442
1443         * infrun.c (stop_all_threads): If debug_infrun, always
1444         trace the wait status after wait_one, using
1445         target_waitstatus_to_string and target_pid_to_str.
1446         (handle_inferior_event): Replace various trace of
1447         wait status kind by a single trace.
1448         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
1449         wait status kind image by target_waitstatus_to_string.
1450         * target/waitstatus.c (target_waitstatus_to_string): Fix
1451         obsolete comment.
1452
1453 2019-04-01  Tom Tromey  <tromey@adacore.com>
1454
1455         PR symtab/23331:
1456         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
1457
1458 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
1459             Pedro Alves  <palves@redhat.com>
1460
1461         * top.c (quit_force): Call 'finalize_values'.
1462         * value.c (finalize_values): New function.
1463         * value.h (finalize_values): Declare.
1464
1465 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
1466
1467         * NEWS: Announce $_gdb_major and $_gdb_minor.
1468
1469         * top.c (init_gdb_version_vars): New function.
1470         (gdb_init): Call init_gdb_version_vars.
1471
1472 2019-03-29  Tom Tromey  <tromey@adacore.com>
1473
1474         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
1475         help text.  Remove dead code.
1476
1477 2019-03-29  Keith Seitz  <keiths@redhat.com>
1478
1479         From Siddhesh Poyarekar:
1480         * f-lang.h (f77_get_upperbound): Return LONGEST.
1481         (f77_get_lowerbound): Likewise.
1482         * f-typeprint.c (f_type_print_varspec_suffix): Expand
1483         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
1484         print them.
1485         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
1486         plongest to format print it.
1487         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
1488         (f77_get_upperbound): Likewise.
1489         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
1490         LOWER_BOUND to LONGEST.
1491         (f77_create_arrayprint_offset_tbl): Likewise.
1492
1493 2019-03-29  Keith Seitz  <keiths@redhat.com>
1494
1495         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
1496         %s/pulongest for TYPE_LENGTH instead of %d in format
1497         strings.
1498         * ada-typerint.c (ada_print_type): Likewise.
1499         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
1500         * compile/compile-c-support.c (generate_register_struct): Likewise.
1501         * gdbtypes.c (recursive_dump_type): Likewise.
1502         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
1503         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
1504         instead of %d in format strings.
1505         * riscv-tdep.c (riscv_type_alignment): Cast second argument
1506         to std::min to ULONGEST.
1507         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
1508         instead of %d in format strings.
1509         * tracepoint.c (info_scope_command): Likewise.
1510         * typeprint.c (print_offset_data::update)
1511         (print_offset_data::finish): Likewise.
1512         * xtensa-tdep.c (xtensa_store_return_value)
1513         (xtensa_push_dummy_call): Likewise.
1514
1515 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
1516
1517         * windows-nat.c (display_selector): Fixed format specifications
1518         for 64-bit Cygwin.
1519
1520 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1521
1522         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
1523
1524 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
1525
1526         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
1527         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
1528         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
1529         (nios2_linux_init_abi): Install it.
1530
1531 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1532
1533         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
1534
1535 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1536
1537         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
1538
1539 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1540             Tom Tromey  <tromey@adacore.com>
1541
1542         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
1543
1544 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
1545
1546         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
1547         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
1548         method to compute the bounds of range types. Also print "[evaluated]"
1549         if the bounds' values come from a dynamic evaluation.
1550
1551 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1552
1553         * cp-valprint.c (cp_print_value_fields): Don't print trailing
1554         whitespace when pretty printing is on.
1555
1556 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1557
1558         * ppc-linux-nat.c: Add include.
1559
1560 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1561
1562         * NEWS: Mention AArch64 Pointer Authentication.
1563
1564 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1565
1566         * arm-linux-nat.c: Add include.
1567
1568 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
1569
1570         * source-cache.c (source_cache::get_source_lines): Re-read
1571         fullname after calling open_source_file.
1572
1573 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
1574
1575         * NEWS: Mention TLS support for FreeBSD.
1576
1577 2019-03-25  Tom Tromey  <tromey@adacore.com>
1578
1579         * minsyms.c (BUNCH_SIZE): Update comment.
1580         (~minimal_symbol_reader): Remove old comment.
1581         (compact_minimal_symbols): Update comment.
1582         (minimal_symbol_reader::install): Remove old comment.  Update
1583         other comments.
1584
1585 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1586
1587         * s390-linux-nat.c: Add include.
1588
1589 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1590
1591         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1592         Call linux_get_hwcap.
1593         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
1594         Likewise.
1595         (aarch64_linux_get_hwcap): Remove function.
1596         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
1597         declaration.
1598         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
1599         linux_get_hwcap.
1600         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1601         * linux-tdep.c (linux_get_hwcap): Add function.
1602         (linux_get_hwcap2): Likewise.
1603         * linux-tdep.h (linux_get_hwcap): Add declaration.
1604         (linux_get_hwcap2): Likewise.
1605         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
1606         (ppc_linux_get_hwcap2): Likewise.
1607         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
1608         linux_get_hwcap.
1609         (ppc_linux_nat_target::insert_watchpoint): Likewise.
1610         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
1611         (ppc_linux_nat_target::read_description): Likewise.
1612         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
1613         * s390-linux-nat.c: Likewise.
1614         * s390-linux-tdep.c (s390_core_read_description): Likewise.
1615
1616 2019-03-24  Tom Tromey  <tom@tromey.com>
1617
1618         * ada-lang.c (standard_lookup): Simplify initialization.
1619         (ada_lookup_symbol_nonlocal): Simplify return.
1620         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
1621         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
1622         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
1623         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
1624         initialization.
1625         * solib.c (solib_global_lookup): Simplify.
1626         * symtab.c (null_block_symbol): Remove.
1627         (symbol_cache_lookup): Simplify returns.
1628         (lookup_language_this): Simplify returns.
1629         (lookup_symbol_aux): Simplify return.
1630         (lookup_local_symbol): Simplify returns.
1631         (lookup_global_symbol_from_objfile): Simplify return.
1632         (lookup_symbol_in_objfile_symtabs)
1633         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
1634         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
1635         (lookup_static_symbol, lookup_global_symbol): Simplify return.
1636         * cp-namespace.c (cp_lookup_bare_symbol)
1637         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
1638         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
1639         (cp_lookup_nested_symbol): Don't use null_block_symbol.
1640         (cp_lookup_symbol_via_imports): Simplify initialization.
1641         (find_symbol_in_baseclass): Likewise.
1642         * symtab.h (null_block_symbol): Remove.
1643         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
1644         (d_lookup_nested_symbol, d_lookup_symbol_imports)
1645         (d_lookup_symbol_module): Likewise.
1646         (find_symbol_in_baseclass): Simplify initialization.
1647
1648 2019-03-24  Tom Tromey  <tom@tromey.com>
1649
1650         * expression.h: Don't include symtab.h.
1651         (struct block): Forward declare.
1652
1653 2019-03-24  Tom Tromey  <tom@tromey.com>
1654
1655         * c-exp.y (typebase): Remove casts.
1656         * gdbtypes.c (lookup_unsigned_typename, )
1657         (lookup_signed_typename): Remove cast.
1658         * eval.c (parse_to_comma_and_eval): Remove cast.
1659         * parse.c (write_dollar_variable): Remove cast.
1660         * block.h (struct block) <superblock>: Now const.
1661         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
1662         * psymtab.c (psym_map_matching_symbols): Make "block" const.
1663         (map_block): Make "block" const.
1664         * symfile.h (struct quick_symbol_functions)
1665         <map_matching_symbols>: Constify block argument to "callback".
1666         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
1667         const.
1668         (find_pc_sect_compunit_symtab): Make "b" const.
1669         (find_symbol_at_address): Likewise.
1670         (search_symbols): Likewise.
1671         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
1672         (dw2_debug_names_lookup_symbol): Likewise.
1673         (dw2_map_matching_symbols): Update.
1674         * p-valprint.c (pascal_val_print): Remove "block".
1675         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
1676         (aux_add_nonlocal_symbols): Make "block" const.
1677         (resolve_subexp): Remove cast.
1678         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
1679         const.
1680         (iterate_over_file_blocks): Likewise.
1681         * f-exp.y (%union) <bval>: Remove.
1682         * coffread.c (patch_opaque_types): Make "b" const.
1683         * spu-tdep.c (spu_catch_start): Make "block" const.
1684         * c-valprint.c (print_unpacked_pointer): Remove "block".
1685         * symmisc.c (dump_symtab_1): Make "b" const.
1686         (block_depth): Make "block" const.
1687         * d-exp.y (%union) <bval>: Remove.
1688         * cp-support.h (cp_lookup_rtti_type): Update.
1689         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
1690         * psymtab.c (psym_lookup_symbol): Make "block" const.
1691         (maintenance_check_psymtabs): Make "b" const.
1692         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
1693         (enumerate_locals, enumerate_args): Update.
1694         * python/py-symtab.c (stpy_global_block): Make "block" const.
1695         (stpy_static_block): Likewise.
1696         * inline-frame.c (block_starting_point_at): Make "new_block"
1697         const.
1698         * block.c (find_block_in_blockvector): Make return type const.
1699         (blockvector_for_pc_sect): Make "b" const.
1700         (find_block_in_blockvector): Make "b" const.
1701
1702 2019-03-23  Tom Tromey  <tom@tromey.com>
1703
1704         * varobj.c (varobj_create): Update.
1705         * symfile.c (clear_symtab_users): Don't reset innermost_block.
1706         * printcmd.c (display_command, do_one_display): Don't reset
1707         innermost_block.
1708         * parser-defs.h (enum innermost_block_tracker_type): Move to
1709         expression.h.
1710         (innermost_block): Update comment.
1711         * parse.c (parse_exp_1): Add tracker_types parameter.
1712         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
1713         tracker_types parameter.  Reset innermost_block.
1714         (parse_exp_in_context): Remove.
1715         (parse_expression_for_completion): Update.
1716         * objfiles.c (~objfile): Don't reset expression_context_block or
1717         innermost_block.
1718         * expression.h (enum innermost_block_tracker_type): Move from
1719         parser-defs.h.
1720         (parse_exp_1): Add tracker_types parameter.
1721         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
1722         reset innermost_block.
1723
1724 2019-03-23  Tom Tromey  <tom@tromey.com>
1725
1726         * objfiles.h: Include bcache.h.
1727
1728 2019-03-23  Tom Tromey  <tom@tromey.com>
1729
1730         * linespec.c (get_current_search_block): Use
1731         scoped_restore_current_language.
1732         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
1733
1734 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1735             Jiong Wang  <jiong.wang@arm.com>
1736
1737         * aarch64-linux-tdep.c
1738         (aarch64_linux_iterate_over_regset_sections): Check for pauth
1739         section.
1740         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
1741
1742 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1743             Jiong Wang  <jiong.wang@arm.com>
1744
1745         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
1746         instructions.
1747         (aarch64_analyze_prologue_test): Add PACIASP test.
1748         (aarch64_prologue_prev_register): Unmask PC value.
1749
1750 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1751             Jiong Wang  <jiong.wang@arm.com>
1752
1753         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
1754         (aarch64_dwarf2_prev_register): Unmask PC value.
1755         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
1756         (aarch64_execute_dwarf_cfa_vendor_op): Check for
1757         DW_CFA_AARCH64_negate_ra_state.
1758         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
1759
1760 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1761             Jiong Wang  <jiong.wang@arm.com>
1762
1763         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
1764         registers.
1765         (aarch64_pseudo_register_name): Likewise.
1766         (aarch64_pseudo_register_type): Likewise.
1767         (aarch64_pseudo_register_reggroup_p): Likewise.
1768         (aarch64_gdbarch_init): Add pauth registers.
1769         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
1770         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
1771         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
1772         (struct gdbarch_tdep): Add regnum for ra_state.
1773
1774 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1775             Jiong Wang  <jiong.wang@arm.com>
1776
1777         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
1778
1779 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1780             Jiong Wang  <jiong.wang@arm.com>
1781
1782         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
1783         function.
1784         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
1785         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
1786         (aarch64_gdbarch_init): Add puth registers.
1787         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
1788         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
1789         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
1790
1791 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1792             Jiong Wang  <jiong.wang@arm.com>
1793
1794         * aarch64-linux-nat.c
1795         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
1796         * aarch64-linux-tdep.c
1797         (aarch64_linux_core_read_description): Likewise.
1798         (aarch64_linux_get_hwcap): New function.
1799         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
1800         (aarch64_linux_get_hwcap): New declaration.
1801
1802 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1803             Jiong Wang  <jiong.wang@arm.com>
1804
1805         * aarch64-linux-nat.c
1806         (aarch64_linux_nat_target::read_description): Add pauth param.
1807         * aarch64-linux-tdep.c
1808         (aarch64_linux_core_read_description): Likewise.
1809         * aarch64-tdep.c (struct target_desc): Add in pauth.
1810         (aarch64_read_description): Add pauth param.
1811         (aarch64_gdbarch_init): Likewise.
1812         * aarch64-tdep.h (aarch64_read_description): Likewise.
1813         * arch/aarch64.c (aarch64_create_target_description): Likewise.
1814         * arch/aarch64.h (aarch64_create_target_description): Likewise.
1815         * features/Makefile: Add new files.
1816         * features/aarch64-pauth.c: New file.
1817         * features/aarch64-pauth.xml: New file.
1818
1819 2019-03-20  Tom Tromey  <tromey@adacore.com>
1820
1821         * infrun.c (handle_inferior_event): Rename from
1822         handle_inferior_event_1.  Create a scoped_value_mark.
1823         (handle_inferior_event): Remove.
1824
1825 2019-03-19  Tom Tromey  <tromey@adacore.com>
1826
1827         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
1828         * infrun.h (print_stop_event): Add "displays" parameter.
1829         * infrun.c (print_stop_event): Add "displays" parameter.
1830
1831 2019-03-19  Pedro Alves  <palves@redhat.com>
1832
1833         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
1834         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
1835         to -1.  Fix TABs vs spaces.
1836         (tui_ui_out::tui_ui_out): Don't initialize fields here.
1837         * tui/tui-out.h (tui_ui_out) Add intro comments.
1838         <m_line, m_start_of_line>: In-class initialize, and add describing
1839         comment.
1840
1841 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
1842
1843         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
1844         variable names.
1845         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
1846
1847 2019-03-18  Pedro Alves  <palves@redhat.com>
1848             Eli Zaretskii <eliz@gnu.org>
1849
1850         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
1851         m_line and m_start_of_line.
1852
1853 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
1854
1855         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
1856         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
1857         it returns a newline.  This fixes a regression in TU mode, whereby
1858         the next line is output on the same screen line as the user input.
1859
1860 2019-03-18  Tom Tromey  <tromey@adacore.com>
1861
1862         * minsyms.c (minimal_symbol_reader::install): Remove call to
1863         obstack_blank.
1864
1865 2019-03-18  Pedro Alves  <palves@redhat.com>
1866
1867         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
1868         New globals.
1869         (apply_style): New, factored out from ...
1870         (apply_ansi_escape): ... this.  Handle reverse video mode.
1871         (tui_set_reverse_mode): New function.
1872         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
1873         * tui/tui-winsource.c (tui_show_source_line): Use
1874         tui_set_reverse_mode instead of setting A_STANDOUT.
1875         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
1876         New setter methods.
1877
1878 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
1879
1880         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
1881         Handle tabs.
1882
1883 2019-03-18  Tom Tromey  <tromey@adacore.com>
1884
1885         * ada-lang.c (empty_array): Add "high" parameter.
1886         (ada_evaluate_subexp): Update.
1887
1888 2019-03-17  Sergei Trofimovich <siarheit@google.com>
1889
1890         * unittests/string_view-selftests.c: Define
1891         _initialize_string_view_selftests unconditionally.
1892
1893 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
1894
1895         PR gdb/24350
1896         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
1897
1898 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
1899
1900         PR gdb/24351
1901         * windows-nat.c (display_selector): Fix format specifiers.
1902
1903 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
1904
1905         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
1906         tui_refill_source_window instead of tui_refresh_win, to update the
1907         current execution line.  This fixes redisplay of the current line
1908         when stepping through the code with "next" or "step".
1909
1910 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
1911
1912         * source-cache.c (source_cache::get_source_lines): Call
1913         find_source_lines to initialize s->nlines.  This fixes vertical
1914         scrolling of TUI source window when the DOWN arrow is pressed.
1915
1916 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1917
1918         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
1919         linux-thread-db.c (_initialize_thread_db): Likewise.
1920
1921 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
1922
1923         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
1924         wclrtoeol in tui_show_source_line".  This reverts changes made in
1925         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
1926
1927 2019-03-15  Tom Tromey  <tom@tromey.com>
1928
1929         * symtab.h (struct minimal_symbol): Derive from
1930         general_symbol_info.
1931         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
1932         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
1933         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
1934         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
1935         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
1936         (MSYMBOL_SEARCH_NAME): Update.
1937         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
1938         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
1939         * minsyms.c (minimal_symbol_reader::record_full): Update.
1940
1941 2019-03-15  Tom Tromey  <tom@tromey.com>
1942
1943         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
1944
1945 2019-03-15  Tom Tromey  <tom@tromey.com>
1946
1947         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
1948         unique_xmalloc_ptr.
1949         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
1950         Update.
1951         * minsyms.c (lookup_minimal_symbol_by_pc_section)
1952         (build_minimal_symbol_hash_tables)
1953         (minimal_symbol_reader::install): Update.
1954
1955 2019-03-15  Tom Tromey  <tom@tromey.com>
1956
1957         * symtab.c (create_demangled_names_hash): Update.
1958         (symbol_set_names): Update.
1959         * objfiles.h (struct objfile_per_bfd_storage)
1960         <demangled_names_hash>: Now an htab_up.
1961         * objfiles.c (objfile_per_bfd_storage): Simplify.
1962
1963 2019-03-15  Tom Tromey  <tom@tromey.com>
1964
1965         * objfiles.h (struct objfile_per_bfd_storage): Declare
1966         destructor.
1967         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
1968         New.
1969         (get_objfile_bfd_data): Use new.  Don't initialize
1970         language_of_main.
1971         (free_objfile_per_bfd_storage): Remove.
1972         (objfile_bfd_data_free, objfile::~objfile): Use delete.
1973
1974 2019-03-15  Tom Tromey  <tom@tromey.com>
1975
1976         * symfile.c (reread_symbols): Update.
1977         * objfiles.c (objfile::objfile): Update.
1978         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
1979         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
1980         comment.
1981         (minimal_symbol_reader::install): Update.
1982         (terminate_minimal_symbol_table): Remove.
1983         * jit.c (jit_object_close_impl): Update.
1984
1985 2019-03-15  Tom Tromey  <tom@tromey.com>
1986
1987         * minsyms.c (minimal_symbol_reader::record_full): Remove some
1988         initializations.
1989
1990 2019-03-15  Tom Tromey  <tom@tromey.com>
1991
1992         * objfiles.h (struct objfile_per_bfd_storage)
1993         <demangled_hash_languages>: Now a bitset.
1994         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
1995         (lookup_minimal_symbol): Update.
1996
1997 2019-03-15  Tom Tromey  <tom@tromey.com>
1998
1999         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
2000         Don't return the symbol.
2001         * coffread.c (record_minimal_symbol): Use record_full.
2002
2003 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
2004
2005         The MS-Windows port of ncurses fails to switch to a color pair if
2006         one or both of the colors are the implicit default colors.  This
2007         change records the default colors when TUI is initialized, and
2008         then specifies them explicitly when a color pair uses the default
2009         colors.  This allows color styling in TUI mode on MS-Windows.
2010
2011         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
2012         ncurses_norm_attr.
2013         (tui_initialize_io) [__MINGW32__]: Record the default terminal
2014         colors in ncurses_norm_attr.
2015         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
2016         "none", replace it with the default color recorded in
2017         ncurses_norm_attr.
2018
2019 2019-03-14  Tom Tromey  <tromey@adacore.com>
2020
2021         * source-cache.h (class source_cache) <get_source_lines>: Return
2022         std::string.
2023         * source-cache.c (source_cache::extract_lines): Handle case where
2024         first_pos==npos.  Return std::string.
2025         (source_cache::get_source_lines): Update.
2026
2027 2019-03-14  Tom Tromey  <tromey@adacore.com>
2028
2029         * NEWS: Add item for "style sources" commands.
2030         * source-cache.c (source_cache::get_source_lines): Check
2031         source_styling.
2032         * cli/cli-style.c (source_styling): New global.
2033         (_initialize_cli_style): Add "style sources" commands.
2034         (show_style_sources): New function.
2035         * cli/cli-style.h (source_styling): Declare.
2036
2037 2019-03-14  Pedro Alves  <palves@redhat.com>
2038             Tom Tromey  <tromey@adacore.com>
2039
2040         * tui/tui-winsource.h (tui_refill_source_window): Declare.
2041         * tui/tui-winsource.c (tui_refill_source_window): New function,
2042         from...
2043         (tui_horizontal_source_scroll): ... here.  Move some logic.
2044         * cli/cli-style.c (set_style_enabled): Notify new observable.
2045         * tui/tui-hooks.c (tui_redisplay_source): New function.
2046         (tui_attach_detach_observers): Attach or detach
2047         tui_redisplay_source.
2048         * observable.h (source_styling_changed): New observable.
2049         * observable.c: Define source_styling_changed observable.
2050
2051 2019-03-13  Tom Tromey  <tromey@adacore.com>
2052
2053         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
2054         (i386_gnu_nat_target::store_registers): Update.
2055         * target-debug.h (target_debug_print_std_string): New macro.
2056         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2057         * windows-tdep.c (display_one_tib): Update.
2058         * tui/tui-stack.c (tui_make_status_line): Update.
2059         * top.c (print_inferior_quit_action): Update.
2060         * thread.c (thr_try_catch_cmd): Update.
2061         (add_thread_with_info): Update.
2062         (thread_target_id_str): Update.
2063         (thr_try_catch_cmd): Update.
2064         (thread_command): Update.
2065         (thread_find_command): Update.
2066         * record-btrace.c (record_btrace_target::info_record)
2067         (record_btrace_resume_thread, record_btrace_target::resume)
2068         (record_btrace_cancel_resume, record_btrace_step_thread)
2069         (record_btrace_target::wait, record_btrace_target::wait)
2070         (record_btrace_target::wait, record_btrace_target::stop): Update.
2071         * progspace.c (print_program_space): Update.
2072         * process-stratum-target.c
2073         (process_stratum_target::thread_address_space): Update.
2074         * linux-fork.c (linux_fork_mourn_inferior)
2075         (detach_checkpoint_command, info_checkpoints_command)
2076         (linux_fork_context): Update.
2077         (linux_fork_detach): Update.
2078         (class scoped_switch_fork_info): Update.
2079         (delete_checkpoint_command): Update.
2080         * infrun.c (follow_fork_inferior): Update.
2081         (follow_fork_inferior): Update.
2082         (proceed_after_vfork_done): Update.
2083         (handle_vfork_child_exec_or_exit): Update.
2084         (follow_exec): Update.
2085         (displaced_step_prepare_throw): Update.
2086         (displaced_step_restore): Update.
2087         (start_step_over): Update.
2088         (resume_1): Update.
2089         (clear_proceed_status_thread): Update.
2090         (proceed): Update.
2091         (print_target_wait_results): Update.
2092         (do_target_wait): Update.
2093         (context_switch): Update.
2094         (stop_all_threads): Update.
2095         (restart_threads): Update.
2096         (finish_step_over): Update.
2097         (handle_signal_stop): Update.
2098         (switch_back_to_stepped_thread): Update.
2099         (keep_going_pass_signal): Update.
2100         (print_exited_reason): Update.
2101         (normal_stop): Update.
2102         * inferior.c (inferior_pid_to_str): Change return type.
2103         (print_selected_inferior): Update.
2104         (add_inferior): Update.
2105         (detach_inferior): Update.
2106         * dummy-frame.c (fprint_dummy_frames): Update.
2107         * dcache.c (dcache_info_1): Update.
2108         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
2109         (btrace_fetch, btrace_clear): Update.
2110         * linux-tdep.c (linux_core_pid_to_str): Change return type.
2111         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
2112         type.
2113         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
2114         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
2115         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
2116         * gdbarch.c, gdbarch.h: Rebuild.
2117         * gdbarch.sh (core_pid_to_str): Change return type.
2118         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
2119         return type.
2120         (windows_nat_target::pid_to_str): Change return type.
2121         (windows_delete_thread): Update.
2122         (windows_nat_target::attach): Update.
2123         (windows_nat_target::files_info): Update.
2124         * target-delegates.c: Rebuild.
2125         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
2126         return type.
2127         (sol_thread_target::pid_to_str): Change return type.
2128         * remote.c (class remote_target) <pid_to_str>: Change return
2129         type.
2130         (remote_target::pid_to_str): Change return type.
2131         (extended_remote_target::attach, remote_target::remote_stop_ns)
2132         (remote_target::remote_notif_remove_queued_reply)
2133         (remote_target::push_stop_reply, remote_target::disable_btrace):
2134         Update.
2135         (extended_remote_target::attach): Update.
2136         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
2137         type.
2138         (gdbsim_target::pid_to_str): Change return type.
2139         * ravenscar-thread.c (struct ravenscar_thread_target)
2140         <pid_to_str>: Change return type.
2141         (ravenscar_thread_target::pid_to_str): Change return type.
2142         * procfs.c (class procfs_target) <pid_to_str>: Change return
2143         type.
2144         (procfs_target::pid_to_str): Change return type.
2145         (procfs_target::attach): Update.
2146         (procfs_target::detach): Update.
2147         (procfs_target::fetch_registers): Update.
2148         (procfs_target::store_registers): Update.
2149         (procfs_target::wait): Update.
2150         (procfs_target::files_info): Update.
2151         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
2152         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
2153         return type.
2154         (nto_procfs_target::pid_to_str): Change return type.
2155         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
2156         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
2157         return type.
2158         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
2159         (exit_lwp): Update.
2160         (attach_proc_task_lwp_callback, get_detach_signal)
2161         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
2162         (linux_nat_target::resume, wait_lwp, stop_callback)
2163         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
2164         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
2165         (linux_nat_wait_1, resume_stopped_resumed_lwps)
2166         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
2167         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
2168         type.
2169         (inf_ptrace_target::attach): Update.
2170         (inf_ptrace_target::files_info): Update.
2171         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
2172         type.
2173         (go32_nat_target::pid_to_str): Change return type.
2174         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
2175         (gnu_nat_target::wait): Update.
2176         (gnu_nat_target::wait): Update.
2177         (gnu_nat_target::resume): Update.
2178         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
2179         (fbsd_nat_target::wait): Update.
2180         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
2181         type.
2182         (darwin_nat_target::attach): Update.
2183         * corelow.c (class core_target) <pid_to_str>: Change return type.
2184         (core_target::pid_to_str): Change return type.
2185         * target.c (normal_pid_to_str): Change return type.
2186         (default_pid_to_str): Likewise.
2187         (target_pid_to_str): Change return type.
2188         (target_translate_tls_address): Update.
2189         (target_announce_detach): Update.
2190         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
2191         return type.
2192         (bsd_uthread_target::pid_to_str): Change return type.
2193         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
2194         type.
2195         (bsd_kvm_target::pid_to_str): Change return type.
2196         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
2197         return type.
2198         (aix_thread_target::pid_to_str): Change return type.
2199         * target.h (struct target_ops) <pid_to_str>: Change return type.
2200         (target_pid_to_str, normal_pid_to_str): Likewise.
2201         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
2202         type.
2203         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
2204         type.
2205         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
2206         return type.
2207         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
2208         type.
2209         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
2210         type.
2211         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
2212         return type.
2213
2214 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
2215
2216         * NEWS: Mention that the new default MI version is 3.  Mention
2217         changes to the output of commands and events that deal with
2218         multi-location breakpoints.
2219         * breakpoint.c: Include "mi/mi-out.h".
2220         (print_one_breakpoint): Change output syntax if using MI version
2221         >= 3.
2222         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
2223         New.
2224         (mi_multi_location_breakpoint_output_fixed): New.
2225         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
2226         (mi_cmd_fix_multi_location_breakpoint_output): New.
2227         (mi_multi_location_breakpoint_output_fixed): New.
2228         * mi/mi-cmds.c (mi_cmds): Register command
2229         -fix-multi-location-breakpoint-output.
2230         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
2231         interpreter "mi".
2232
2233 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
2234
2235         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
2236         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
2237         instantiate mi_ui_out based on interpreter name.
2238         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
2239         * mi/mi-main.c (mi_load_progress): Likewise.
2240
2241 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2242
2243         * NEWS: Combine separate "New targets" sections for 8.3.
2244
2245 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2246
2247         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
2248         (ppcfbsd_init_abi): Install gdbarch
2249         "fetch_tls_load_module_address" and "get_thread_local_address"
2250         methods.
2251
2252 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2253
2254         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
2255         (riscv_fbsd_init_abi): Install gdbarch
2256         "fetch_tls_load_module_address" and "get_thread_local_address"
2257         methods.
2258
2259 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2260
2261         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
2262         (i386fbsd_init_abi): Install gdbarch
2263         "fetch_tls_load_module_address" and "get_thread_local_address"
2264         methods.
2265
2266 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2267
2268         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
2269         (amd64fbsd_init_abi): Install gdbarch
2270         "fetch_tls_load_module_address" and "get_thread_local_address"
2271         methods.
2272
2273 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2274
2275         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
2276         (struct fbsd_pspace_data): New type.
2277         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
2278         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
2279         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
2280         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
2281         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
2282
2283 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2284
2285         * gdbtypes.c (lookup_struct_elt): New function.
2286         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
2287         * gdbtypes.h (struct struct_elt): New type.
2288         (lookup_struct_elt): New prototype.
2289
2290 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2291
2292         * gdbtypes.c (lookup_struct_elt_type): Update comment and
2293         remove disabled code block.
2294
2295 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2296
2297         * gdbarch.sh (get_thread_local_address): New method.
2298         * gdbarch.h, gdbarch.c: Regenerate.
2299         * target.c (target_translate_tls_address): Use
2300         gdbarch_get_thread_local_address if present instead of
2301         target::get_thread_local_address.
2302
2303 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2304
2305         * target.h (target::get_thread_local_address): Update comment.
2306
2307 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2308
2309         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
2310         objfile->separate_debug_objfile_backlink if not NULL.
2311
2312 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2313
2314         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
2315         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
2316         (amd64bsd_store_inferior_registers): Likewise.
2317         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2318         Enable segment base registers.
2319         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
2320         PT_GETFSBASE and PT_GETGSBASE.
2321         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
2322         PT_SETGSBASE.
2323         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
2324         segment base registers.
2325         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2326
2327 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2328
2329         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2330         Update calls to i386_target_description to add 'segments'
2331         parameter.
2332         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
2333         add segment base registers.
2334         * arch/i386.c (i386_create_target_description): Add 'segments'
2335         parameter to enable segment base registers.
2336         * arch/i386.h (i386_create_target_description): Likewise.
2337         * features/i386/32bit-segments.xml: New file.
2338         * features/i386/32bit-segments.c: Generate.
2339         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
2340         call to i386_target_description to add 'segments' parameter.
2341         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2342         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
2343         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
2344         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
2345         if feature is present.
2346         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
2347         Add 'segments' parameter to call to i386_target_description.
2348         (i386_target_description): Add 'segments' parameter to enable
2349         segment base registers.
2350         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
2351         to call to i386_target_description.
2352         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
2353         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
2354         Define I386_NUM_REGS.
2355         (i386_target_description): Add 'segments' parameter to enable
2356         segment base registers.
2357
2358 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
2359
2360         PR/24325
2361         * source-cache.c: #undef open and close, to avoid unresolved
2362         externals during linking.
2363
2364 2019-03-12  Tom Tromey  <tromey@adacore.com>
2365
2366         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
2367         const.  Add initializers.
2368         (_initialize_remote): Don't initialize ptid globals.
2369
2370 2019-03-12  Pedro Alves  <palves@redhat.com>
2371
2372         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
2373
2374 2019-03-12  Pedro Alves  <palves@redhat.com>
2375
2376         * cp-name-parser.y (main): Remove unused 'len' variable.
2377
2378 2019-03-12  Tom Tromey  <tromey@adacore.com>
2379
2380         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
2381         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
2382
2383 2019-03-12  Tom Tromey  <tromey@adacore.com>
2384
2385         * linux-nat.c (iterate_over_lwps): Update.
2386         (stop_callback): Remove parameter.
2387         (stop_wait_callback, detach_callback, resume_set_callback)
2388         (select_singlestep_lwp_callback, set_ignore_sigint)
2389         (status_callback, resumed_callback, resume_clear_callback)
2390         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
2391         data parameter.
2392         (linux_nat_target::detach, linux_nat_target::resume)
2393         (linux_stop_and_wait_all_lwps, select_event_lwp)
2394         (linux_nat_filter_event, linux_nat_wait_1)
2395         (linux_nat_target::kill, linux_nat_target::stop)
2396         (linux_nat_target::stop): Update.
2397         (linux_nat_resume_callback): Change type.
2398         (resume_stopped_resumed_lwps, count_events_callback)
2399         (select_event_lwp_callback): Likewise.
2400         (linux_stop_lwp, linux_nat_stop_lwp): Update.
2401         * arm-linux-nat.c (struct update_registers_data): Remove.
2402         (update_registers_callback): Change type.
2403         (arm_linux_insert_hw_breakpoint1): Update.
2404         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
2405         parameter.
2406         (x86_linux_dr_set_addr): Update.
2407         (x86_linux_dr_set_control): Update.
2408         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
2409         (iterate_over_lwps): Use gdb::function_view.
2410         * nat/aarch64-linux-hw-point.c (struct
2411         aarch64_dr_update_callback_param): Remove.
2412         (debug_reg_change_callback): Change type.
2413         (aarch64_notify_debug_reg_change): Update.
2414         * s390-linux-nat.c (s390_refresh_per_info): Update.
2415
2416 2019-03-11  Tom Tromey  <tromey@adacore.com>
2417
2418         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
2419         redundant assignment to "this_cu".
2420
2421 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2422
2423         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
2424
2425 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2426
2427         * gdbtypes.c (rank_one_type_parm_set): New function extracted
2428         from...
2429         (rank_one_type): ... this.
2430
2431 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2432
2433         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
2434         from...
2435         (rank_one_type): ... this.
2436
2437 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2438
2439         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
2440         from...
2441         (rank_one_type): ... this.
2442
2443 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2444
2445         * gdbtypes.c (rank_one_type_parm_float): New function extracted
2446         from...
2447         (rank_one_type): ... this.
2448
2449 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2450
2451         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
2452         from...
2453         (rank_one_type): ... this.
2454
2455 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2456
2457         * gdbtypes.c (rank_one_type_parm_range): New function extracted
2458         from...
2459         (rank_one_type): ... this.
2460
2461 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2462
2463         * gdbtypes.c (rank_one_type_parm_char): New function extracted
2464         from...
2465         (rank_one_type): ... this.
2466
2467 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2468
2469         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
2470         from...
2471         (rank_one_type): ... this.
2472
2473 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2474
2475         * gdbtypes.c (rank_one_type_parm_int): New function extracted
2476         from...
2477         (rank_one_type): ... this.
2478
2479 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2480
2481         * gdbtypes.c (rank_one_type_parm_func): New function extracted
2482         from...
2483         (rank_one_type): ... this.
2484
2485 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2486
2487         * gdbtypes.c (rank_one_type_parm_array): New function extracted
2488         from...
2489         (rank_one_type): ... this.
2490
2491 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2492
2493         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
2494         from...
2495         (rank_one_type): ... this.
2496
2497 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2498
2499         * inferior.c (initialize_inferiors): Ensure 'help set/show print
2500         inferior-events' shows the example events.
2501
2502 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
2503
2504         Support styling on native MS-Windows console
2505
2506         PR/24315
2507         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
2508         on MS-Windows if $TERM is not defined.
2509
2510         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
2511
2512         * posix-hdep.c (gdb_console_fputs):
2513         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
2514         functions.
2515         * ui-file.h (gdb_console_fputs): Add prototype.
2516
2517         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
2518         back to fputs only if the former returns zero.
2519
2520 2019-03-07  Tom Tromey  <tom@tromey.com>
2521
2522         * symmisc.c (print_symbol_bcache_statistics): Update.
2523         (print_objfile_statistics): Update.
2524         * symfile.c (allocate_symtab): Update.
2525         * stabsread.c: Don't include bcache.h.
2526         * psymtab.h (struct psymbol_bcache): Don't declare.
2527         (class psymtab_storage) <psymbol_cache>: Now a bcache.
2528         (psymbol_bcache_init, psymbol_bcache_free)
2529         (psymbol_bcache_get_bcache): Don't declare.
2530         * psymtab.c (struct psymbol_bcache): Remove.
2531         (psymtab_storage::psymtab_storage): Update.
2532         (psymtab_storage::~psymtab_storage): Update.
2533         (psymbol_bcache_init, psymbol_bcache_free)
2534         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
2535         (add_psymbol_to_bcache): Update.
2536         (allocate_psymtab): Update.
2537         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
2538         macro_cache>: No longer pointers.
2539         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
2540         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
2541         * macrotab.c (macro_bcache): Update.
2542         * macroexp.c: Don't include bcache.h.
2543         * gdbtypes.c (check_types_worklist): Update.
2544         (types_deeply_equal): Remove TRY/CATCH.  Update.
2545         * elfread.c (elf_symtab_read): Update.
2546         * dwarf2read.c: Don't include bcache.h.
2547         * buildsym.c (buildsym_compunit::get_macro_table): Update.
2548         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
2549         (print_bcache_statistics, bcache_memory_used): Don't declare.
2550         (struct bcache): Move from bcache.c.  Add constructor, destructor,
2551         methods.  Rename all data members.
2552         * bcache.c (struct bcache): Move to bcache.h.
2553         (bcache::expand_hash_table): Rename from expand_hash_table.
2554         (bcache): Remove.
2555         (bcache::insert): Rename from bcache_full.
2556         (bcache::compare): Rename from bcache_compare.
2557         (bcache_xmalloc): Remove.
2558         (bcache::~bcache): Rename from bcache_xfree.
2559         (bcache::print_statistics): Rename from print_bcache_statistics.
2560         (bcache::memory_used): Rename from bcache_memory_used.
2561
2562 2019-03-07  Pedro Alves  <palves@redhat.com>
2563
2564         * infrun.c (normal_stop): Also check for
2565         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
2566
2567 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
2568
2569         * f-lang.c (value_from_host_double): Moved to...
2570         * value.c (value_from_host_double): ...here.
2571         * value.h (value_from_host_double): Declare.
2572         * guile/scm-math.c (vlscm_convert_typed_number): Use
2573         value_from_host_double.
2574         (vlscm_convert_number): Likewise.
2575         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
2576         * python/py-value.c (convert_value_from_python): Likewise.
2577
2578 2019-03-06  Tom Tromey  <tom@tromey.com>
2579
2580         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
2581
2582 2019-03-06  Tom Tromey  <tom@tromey.com>
2583
2584         * utils.h (free_current_contents): Don't declare.
2585         * utils.c (free_current_contents): Remove.
2586
2587 2019-03-06  Tom Tromey  <tom@tromey.com>
2588
2589         * top.c (quit_force): Update.
2590         * main.c (captured_command_loop): Update.
2591         * common/new-op.c (operator new): Update.
2592         * common/common-exceptions.c (struct catcher)
2593         <save_cleanup_chain>: Remove member.
2594         (exceptions_state_mc_init): Update.
2595         (exception_try_scope_entry): Return nullptr.
2596         (exception_try_scope_exit, exception_rethrow)
2597         (throw_exception_sjlj, throw_exception_cxx): Update.
2598         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
2599         (all_cleanups, do_cleanups, discard_cleanups)
2600         (discard_final_cleanups, save_cleanups, save_final_cleanups)
2601         (restore_cleanups, restore_final_cleanups): Don't declare.
2602         (do_final_cleanups): Remove parameter.
2603         * common/cleanups.c (cleanup_chain, make_cleanup)
2604         (make_cleanup_dtor, all_cleanups, do_cleanups)
2605         (discard_my_cleanups, discard_cleanups)
2606         (discard_final_cleanups, save_my_cleanups, save_cleanups)
2607         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
2608         (null_cleanup): Remove.
2609         (do_final_cleanups): Remove parameter.
2610
2611 2019-03-06  Tom Tromey  <tom@tromey.com>
2612
2613         * remote.c (remote_target::remote_parse_stop_reply): Use
2614         unique_xmalloc_ptr.
2615
2616 2019-03-06  Tom Tromey  <tom@tromey.com>
2617
2618         * stabsread.c (struct stabs_field_info): Rename from field_info.
2619         <list, fnlist>: Add initializers.
2620         <obstack>: New member.
2621         (read_member_functions, read_struct_fields, read_baseclasses):
2622         Allocate on obstack.  Don't use cleanups.
2623         (read_one_struct_field, read_member_functions, read_struct_fields)
2624         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
2625         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
2626         (read_struct_type): Update.
2627
2628 2019-03-06  Tom Tromey  <tom@tromey.com>
2629
2630         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
2631         * common/filestuff.h (make_cleanup_close): Don't declare.
2632         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
2633         Remove.
2634
2635 2019-03-06  Tom Tromey  <tom@tromey.com>
2636
2637         * solib-aix.c: Use make_scope_exit.
2638
2639 2019-03-06  Tom Tromey  <tom@tromey.com>
2640
2641         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
2642         Use make_scope_exit.
2643
2644 2019-03-06  Tom Tromey  <tom@tromey.com>
2645
2646         * solib-svr4.c (disable_probes_interface): Remove parameter.
2647         (svr4_handle_solib_event): Use make_scope_exit.
2648
2649 2019-03-06  Tom Tromey  <tom@tromey.com>
2650
2651         * remote.c (struct stop_reply_deleter): Remove.
2652         (stop_reply_up): Update.
2653         (struct stop_reply): Derive from notif_event.  Don't typedef.
2654         <regcache>: Now a std::vector.
2655         (stop_reply_xfree): Remove.
2656         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
2657         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
2658         (remote_target::discard_pending_stop_replies): Use delete.
2659         (remote_target::remote_parse_stop_reply): Update.
2660         (remote_target::process_stop_reply): Update.
2661         * remote-notif.h (struct notif_event): Add virtual destructor.
2662         Remove "dtr" member.
2663         (struct notif_client) <alloc_event>: Return a unique_ptr.
2664         (notif_event_xfree): Don't declare.
2665         (notif_event_up): New typedef.
2666         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
2667         (notif_event_xfree, do_notif_event_xfree): Remove.
2668         (remote_notif_state_xfree): Update.
2669
2670 2019-03-06  Tom Tromey  <tom@tromey.com>
2671
2672         * infrun.c (displaced_step_clear_cleanup): Now a
2673         forward_scope_exit type.
2674         (displaced_step_prepare_throw): Update.
2675         (displaced_step_fixup): Update.
2676
2677 2019-03-06  Tom Tromey  <tom@tromey.com>
2678
2679         * inferior.h (class inferior): Update comment.
2680         * gdbthread.h (class thread_info): Update comment.
2681
2682 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
2683             Tom Tromey  <tom@tromey.com>
2684
2685         * stabsread.h (struct stab_section_list): Remove.
2686         (coffstab_build_psymtabs): Update.
2687         * dbxread.c (symbuf_sections): Now a std::vector.
2688         (sect_idx): New global.
2689         (fill_symbuf): Update.
2690         (coffstab_build_psymtabs): Change type of stabsects parameter.
2691         Update.
2692         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
2693         std::vector.
2694         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
2695         (coff_locate_sections): Update.
2696         (coff_symfile_read): Remove cleanups.  Update.
2697         (init_stringtab): Add storage parameter.
2698         (free_stringtab, free_stringtab_cleanup): Remove.
2699         (init_lineno): Add storage parameter.
2700         (free_linetab, free_linetab_cleanup): Remove.
2701
2702 2019-03-06  Pedro Alves  <palves@redhat.com>
2703
2704         * linux-fork.c (fork_info::clobber_regs): Delete.
2705         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
2706         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
2707         comment.  Adjust.
2708         (scoped_switch_fork_info::scoped_switch_fork_info)
2709         (checkpoint_command, linux_fork_context): Adjust
2710         fork_save_infrun_state calls.
2711
2712 2019-03-06  Pedro Alves  <palves@redhat.com>
2713
2714         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
2715         (inf_has_multiple_threads): Return 'bool' and rewrite using
2716         inferior_info::threads().
2717
2718 2019-03-06  Pedro Alves  <palves@redhat.com>
2719
2720         * linux-fork.c: Include <list>.
2721         (fork_list): Now a std::list instance.
2722         (fork_info): Add ctor, dtor, and in-class initialize all fields.
2723         (forks_exist_p, find_last_fork): Adjust.
2724         (new_fork): Delete.
2725         (one_fork_p): New.
2726         (add_fork): Adjust.
2727         (free_fork): Delete, folded into fork_info::~fork_info().
2728         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
2729         Adjust.
2730         (init_fork_list): Delete.
2731         (linux_fork_killall, linux_fork_mourn_inferior)
2732         (linux_fork_detach, info_checkpoints_command): Adjust.
2733         (_initialize_linux_fork): No longer call init_fork_list.
2734
2735 2019-03-06  Pedro Alves  <palves@redhat.com>
2736
2737         * linux-fork.c (new_fork): New, split out of ...
2738         (add_fork): ... this.  Return void.  Move "first fork" special
2739         case from here, to ...
2740         (checkpoint_command): ... here.
2741         * linux-linux.h (add_fork): Return void.
2742
2743 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2744
2745         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
2746
2747 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2748             Chris January  <chris.january@arm.com>
2749             David Lecomber  <david.lecomber@arm.com>
2750
2751         * f-exp.y: New token, UNOP_INTRINSIC.
2752         (exp): New pattern using UNOP_INTRINSIC token.
2753         (f77_keywords): Add 'abs' keyword.
2754         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
2755         (value_from_host_double): New function.
2756         (evaluate_subexp_f): Support UNOP_ABS.
2757
2758 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2759
2760         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
2761         types.
2762
2763 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2764
2765         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
2766         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
2767         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
2768
2769 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2770
2771         * f-exp.y (convert_to_kind_type): Handle more type kinds.
2772
2773 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2774             Chris January  <chris.january@arm.com>
2775
2776         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
2777         * f-exp.y: Define 'KIND' token.
2778         (exp): New pattern for KIND expressions.
2779         (ptype): Handle types with a kind extension.
2780         (direct_abs_decl): Extend to spot kind extensions.
2781         (f77_keywords): Add 'kind' to the list.
2782         (push_kind_type): New function.
2783         (convert_to_kind_type): New function.
2784         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
2785         * parse.c (operator_length_standard): Likewise.
2786         * parser-defs.h (enum type_pieces): Add tp_kind.
2787         * std-operator.def: Add UNOP_KIND.
2788
2789 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2790
2791         * f-exp.y (f_parse): Set yydebug.
2792
2793 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2794
2795         * f-lang.c (evaluate_subexp_f): New function.
2796         (exp_descriptor_f): New global.
2797         (f_language_defn): Use exp_descriptor_f instead of
2798         exp_descriptor_standard.
2799
2800 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2801
2802         * f-exp.y (struct token): Add comments.
2803         (dot_ops): Remove uppercase versions and the end marker.
2804         (f77_keywords): Likewise.
2805         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
2806         entries in the dot_ops array are case insensitive, and use
2807         strncasecmp to compare strings.  Also some whitespace cleanup in
2808         this area.  Similar for the f77_keywords array, except entries in
2809         this list might be case sensitive.
2810
2811 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2812
2813         * f-exp.y (struct f77_boolean_val): Add comments.
2814         (boolean_values): Remove uppercase versions, and end marker.
2815         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
2816         and use strncasecmp to achieve case insensitivity.  Additionally,
2817         perform whitespace cleanup around this code.
2818
2819 2019-03-06  Tom Tromey  <tromey@adacore.com>
2820
2821         * remote-sim.c (gdbsim_target_open): Use result of
2822         gdb_argv::release.
2823
2824 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
2825         Dirk Schubert  <dirk.schubert@arm.com>
2826         Chris January  <chris.january@arm.com>
2827
2828         * eval.c (evaluate_subexp_standard): Call Fortran argument
2829         wrapping logic.
2830         * f-lang.c (struct value): A value which can be passed into a
2831         Fortran function call.
2832         (fortran_argument_convert): Wrap Fortran arguments in a pointer
2833         where appropriate.
2834         (struct type): Value ready for a Fortran function call.
2835         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
2836         is needed.
2837         * f-lang.h (fortran_argument_convert): Declaration.
2838         (fortran_preserve_arg_pointer): Declaration.
2839         * infcall.c (value_arg_coerce): Call Fortran argument logic.
2840
2841 2019-03-05  Tom Tromey  <tromey@adacore.com>
2842
2843         * python/py-prettyprint.c (print_string_repr): Remove #if.
2844         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
2845
2846 2019-03-05  Tom Tromey  <tromey@adacore.com>
2847
2848         * target.c (the_dummy_target): Move later.  Change type to
2849         "dummy_target".
2850         (initialize_targets): Don't initialize the_dummy_target.
2851
2852 2019-03-05  Tom Tromey  <tromey@adacore.com>
2853
2854         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
2855         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
2856
2857 2019-03-05  Tom Tromey  <tromey@adacore.com>
2858
2859         * windows-nat.c (windows_nat_target::attach)
2860         (windows_nat_target::detach): Don't call gdb_flush.
2861         * valprint.c (generic_val_print, val_print, val_print_string):
2862         Don't call gdb_flush.
2863         * utils.c (defaulted_query): Don't call gdb_flush.
2864         * typeprint.c (print_type_scalar): Don't call gdb_flush.
2865         * target.c (target_announce_detach): Don't call gdb_flush.
2866         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
2867         * remote.c (extended_remote_target::attach): Don't call
2868         gdb_flush.
2869         * procfs.c (procfs_target::detach): Don't call gdb_flush.
2870         * printcmd.c (do_examine): Don't call gdb_flush.
2871         (info_display_command): Don't call gdb_flush.
2872         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
2873         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
2874         * memattr.c (info_mem_command): Don't call gdb_flush.
2875         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
2876         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
2877         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
2878         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
2879         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
2880         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
2881         (gnu_nat_target::detach): Don't call gdb_flush.
2882         * f-valprint.c (f_val_print): Don't call gdb_flush.
2883         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
2884         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
2885         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
2886         gdb_flush.
2887         * c-valprint.c (c_val_print): Don't call gdb_flush.
2888         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
2889
2890 2019-03-05  Tom Tromey  <tromey@adacore.com>
2891
2892         * varobj.c (update_dynamic_varobj_children): Update.
2893         (install_default_visualizer): Use reset, not release.
2894         * value.c (set_internalvar): Update.
2895         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
2896         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
2897         ATTRIBUTE_UNUSED_RESULT.
2898
2899 2019-03-05  Tom Tromey  <tromey@adacore.com>
2900
2901         * remote.c (class scoped_remote_fd) <release>: Add
2902         ATTRIBUTE_UNUSED_RESULT.
2903
2904 2019-03-05  Tom Tromey  <tromey@adacore.com>
2905
2906         * macroexp.c (struct macro_buffer) <release>: Add
2907         ATTRIBUTE_UNUSED_RESULT.
2908
2909 2019-03-05  Tom Tromey  <tromey@adacore.com>
2910
2911         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
2912         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
2913         ATTRIBUTE_UNUSED_RESULT.
2914
2915 2019-03-05  Tom Tromey  <tromey@adacore.com>
2916
2917         * common/scoped_fd.h (class scoped_fd) <release>: Add
2918         ATTRIBUTE_UNUSED_RESULT.
2919
2920 2019-03-05  Tom Tromey  <tromey@adacore.com>
2921
2922         * parser-defs.h (struct parser_state) <release>: Add
2923         ATTRIBUTE_UNUSED_RESULT.
2924
2925 2019-03-05  Tom Tromey  <tromey@adacore.com>
2926
2927         * utils.h (class gdb_argv) <release>: Add
2928         ATTRIBUTE_UNUSED_RESULT.
2929         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
2930
2931 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
2932
2933         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
2934         for-loop range, to avoid compiler warnings.
2935
2936         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
2937         avoid compiler warnings about unused variables.
2938
2939         * NEWS: Mention end of support for native debugging on MS-Windows
2940         before XP.
2941
2942         PR gdb/24292
2943         * common/netstuff.c:
2944         * gdbserver/gdbreplay.c
2945         * gdbserver/remote-utils.c:
2946         * ser-tcp.c:
2947         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
2948         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
2949         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
2950         'getaddrinfo' and 'freeaddrinfo' were not available before
2951         Windows XP, and mingw.org's MinGW headers by default define
2952         _WIN32_WINNT to 0x500.
2953
2954 2019-03-01  Gary Benson <gbenson@redhat.com>
2955
2956         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
2957
2958 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
2959             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2960
2961         PR gdb/8527
2962         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
2963         set_sigint_trap, clear_sigint_trap.
2964
2965 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2966
2967         * target.c (target_detach): Clear the regcache and the
2968         frame cache.
2969
2970 2019-02-27  Pedro Alves  <palves@redhat.com>
2971
2972         * utils.c (set_screen_size): When we cap the height/width sizes,
2973         tweak the corresponding command variable to show "unlimited":
2974
2975 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
2976             Pedro Alves  <palves@redhat.com>
2977
2978         * utils.c (set_screen_size): Reduce "infinite" rows and columns
2979         before calling rl_set_screen_size.
2980
2981 2019-02-27  Tom Tromey  <tromey@adacore.com>
2982
2983         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
2984         define.
2985         * python/py-value.c: Remove Python 2.4 workaround.
2986         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
2987         workaround.
2988         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
2989         Python 2.4 workaround.
2990         * python/python-internal.h: Remove Python 2.4 comment.
2991         (Py_ssize_t): Don't define.
2992         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
2993         (gdb_Py_DECREF): Remove Python 2.4 workaround.
2994         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
2995         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
2996         * python/python.c (do_start_initialization): Remove Python 2.4
2997         workaround.
2998         * python/py-prettyprint.c (class dummy_python_frame): Remove.
2999         (print_children): Remove Python 2.4 workaround.
3000         * python/py-inferior.c (buffer_procs): Remove Python 2.4
3001         workaround.
3002         (CHARBUFFERPROC_NAME): Remove.
3003         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
3004         Python 2.4 workaround.
3005
3006 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3007
3008         * NEWS: Note minimum Python version.
3009
3010 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3011
3012         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
3013         code from these functions.  Remove corresponding ifdefs.  Use
3014         Py_buffer_up instead of explicit calls to PyBuffer_Release.
3015         Remove gotos and target of gotos.
3016         (infpy_search_memory): Likewise.
3017
3018 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3019
3020         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
3021         (hppa_gdbarch_init): Don't register deleted functions with
3022         gdbarch.
3023
3024 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3025
3026         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
3027         (h8300_unwind_sp): Delete.
3028         (h8300_dummy_id): Delete.
3029         (h8300_gdbarch_init): Don't register deleted functions with
3030         gdbarch.
3031
3032 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3033
3034         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
3035         (ft32_unwind_pc): Delete.
3036         (ft32_unwind_sp): Delete.
3037         (ft32_gdbarch_init): Don't register deleted functions with
3038         gdbarch.
3039
3040 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3041
3042         * gdb/frv-tdep.c (frv_dummy_id): Delete.
3043         (frv_unwind_pc): Delete.
3044         (frv_unwind_sp): Delete.
3045         (frv_gdbarch_init): Don't register deleted functions with
3046         gdbarch.
3047
3048 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3049
3050         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
3051         (riscv_unwind_pc): Delete.
3052         (riscv_unwind_sp): Delete.
3053         (riscv_gdbarch_init): Don't register deleted functions with
3054         gdbarch.
3055
3056 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3057
3058         * gdb/csky-tdep.c (csky_dummy_id): Delete.
3059         (csky_unwind_pc): Delete.
3060         (csky_unwind_sp): Delete.
3061         (csky_gdbarch_init): Don't register deleted functions with
3062         gdbarch.
3063
3064 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3065
3066         * gdb/cris-tdep.c (cris_dummy_id): Delete.
3067         (cris_unwind_pc): Delete.
3068         (cris_unwind_sp): Delete.
3069         (cris_gdbarch_init): Don't register deleted functions with
3070         gdbarch.
3071
3072 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3073
3074         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
3075         (bfin_unwind_pc): Delete.
3076         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
3077
3078 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3079
3080         * gdb/arm-tdep.c (arm_dummy_id): Delete.
3081         (arm_unwind_pc): Delete.
3082         (arm_unwind_sp): Delete.
3083         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
3084
3085 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3086
3087         * gdb/arc-tdep.c (arc_dummy_id): Delete.
3088         (arc_unwind_pc): Delete.
3089         (arc_unwind_sp): Delete.
3090         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
3091
3092 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3093
3094         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
3095         (alpha_unwind_pc): Delete.
3096         (alpha_gdbarch_init): Don't register deleted functions with
3097         gdbarch.
3098
3099 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3100
3101         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
3102         (aarch64_unwind_pc): Delete.
3103         (aarch64_unwind_sp): Delete.
3104         (aarch64_gdbarch_init): Don't register deleted functions with
3105         gdbarch.
3106
3107 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3108
3109         * gdbtypes.c (type_align): Don't consider static members when
3110         computing structure alignment.
3111
3112 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3113
3114         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
3115         return 0 for other types.
3116         * arch-utils.c (default_type_align): Always return 0.
3117         * gdbarch.h: Regenerate.
3118         * gdbarch.sh (type_align): Extend comment.
3119         * gdbtypes.c (type_align): Add additional comments, always call
3120         gdbarch_type_align before applying the default rules.
3121         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
3122         generic code will then apply a suitable default.
3123         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
3124         types, return 0 for other types.
3125
3126 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3127
3128         * NEWS: Create a new section for the next release branch.
3129         Rename the section of the current branch, now that it has
3130         been cut.
3131
3132 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3133
3134         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
3135         * version.in: Bump version to 8.3.50.DATE-git.
3136
3137 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
3138
3139         * aix-thread.c (ptid_cmp): Remove unused variable.
3140         (get_signaled_thread): Likewise.
3141         (store_regs_user_thread): Likewise.
3142         (store_regs_kernel_thread): Likewise.
3143         (fetch_regs_kernel_thread): Remove shadowed variable.
3144
3145 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3146
3147         * features/riscv/32bit-cpu.xml: Add register numbers.
3148         * features/riscv/32bit-fpu.c: Regenerate.
3149         * features/riscv/32bit-fpu.xml: Add register numbers.
3150         * features/riscv/64bit-cpu.xml: Add register numbers.
3151         * features/riscv/64bit-fpu.c: Regenerate.
3152         * features/riscv/64bit-fpu.xml: Add register numbers.
3153
3154 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
3155
3156         * NEWS: Mention two argument form of gdb.Value constructor.
3157         * python/py-value.c (convert_buffer_and_type_to_value): New
3158         function.
3159         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
3160         Add support for handling an optional second argument.  Call
3161         convert_buffer_and_type_to_value as appropriate.
3162         * python/python-internal.h (Py_buffer_deleter): New struct.
3163         (Py_buffer_up): New typedef.
3164
3165 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
3166
3167         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
3168         instead of releasing ownership.
3169
3170 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
3171
3172         * dwarf2read.c (open_and_init_dwp_file): Call
3173         elf_numsections instead of bfd_count_sections to initialize
3174         dwp_file->num_sections.
3175
3176 2019-02-25  Tom Tromey  <tromey@adacore.com>
3177
3178         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
3179
3180 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
3181
3182         * gcore.in: Add '--readnever' option when invoking GDB.
3183
3184 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3185
3186         * MAINTAINERS: Update my email address.
3187
3188 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3189
3190         * build-id.c (build_id_to_debug_bfd_1): New function.
3191         (build_id_to_debug_bfd): Look for separate debug file in
3192         sysroot.
3193
3194 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3195
3196         * gdbarch.sh: Update the copyright year range that is placed into
3197         generated files.
3198
3199 2019-02-22  Keith Seitz  <keiths@redhat.com>
3200
3201         PR symtab/23853
3202         * linespec.c (create_sals_line_offset): Search for the default
3203         symtab's filename instead of its fullname.
3204
3205 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3206
3207         * NEWS: Update style defaults.
3208
3209 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3210
3211         * main.c (captured_main_1): Disable styling in batch mode.
3212
3213 2019-02-20  Tom Tromey  <tom@tromey.com>
3214
3215         * symtab.c (symtab_symbol_info): Fix typos.
3216
3217 2019-02-20  Tom Tromey  <tromey@adacore.com>
3218
3219         * findcmd.c (_initialize_mem_search): Use upper case for
3220         metasyntactic variables.
3221
3222 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
3223
3224         * aarch64-tdep.c (aarch64_add_reggroups): New function.
3225         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
3226
3227 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
3228
3229         * top.h (source_file_name): Change to std::string.
3230         * top.c (source_file_name): Likewise.
3231         (command_line_input): Adjust.
3232         * cli/cli-script.c (script_from_file): Adjust.
3233
3234 2019-02-19  Tom Tromey  <tromey@adacore.com>
3235
3236         * ravenscar-thread.c
3237         (ravenscar_thread_target::update_thread_list): Don't call
3238         ada_build_task_list.
3239         * ada-lang.h (ada_build_task_list): Don't declare.
3240         * ada-tasks.c (struct ada_tasks_inferior_data)
3241         <task_list_valid_p>: Now bool.
3242         (read_known_tasks, ada_task_list_changed)
3243         (ada_tasks_invalidate_inferior_data): Update.
3244         (read_known_tasks_array): Return bool.
3245         (read_known_tasks_list): Likewise.
3246         (read_known_tasks): Return void.
3247         (ada_build_task_list): Now static.
3248
3249 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3250
3251         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
3252         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
3253
3254 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3255
3256         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
3257         variant for ada_tasks_pspace_data_handle and
3258         ada_tasks_inferior_data_handle.
3259         (ada_tasks_pspace_data_cleanup): New function.
3260         (ada_tasks_inferior_data_cleanup): New function.
3261
3262 2019-02-17  Tom Tromey  <tom@tromey.com>
3263
3264         * macrotab.h (macro_source_fullname): Return a std::string.
3265         * macrotab.c (macro_include, check_for_redefinition)
3266         (macro_undef, macro_lookup_definition, foreach_macro)
3267         (foreach_macro_in_scope): Update.
3268         (macro_source_fullname): Return a std::string.
3269         * macrocmd.c (show_pp_source_pos): Update.
3270
3271 2019-02-17  Tom Tromey  <tom@tromey.com>
3272
3273         * macrocmd.c (show_pp_source_pos): Style the file names.
3274
3275 2019-02-17  Tom Tromey  <tom@tromey.com>
3276
3277         PR tui/24197:
3278         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
3279
3280 2019-02-17  Tom Tromey  <tom@tromey.com>
3281
3282         * ada-lang.c (user_select_syms): Use filtered printing.
3283         * utils.c (wrap_style): New global.
3284         (desired_style): Remove.
3285         (emit_style_escape): Add stream parameter.
3286         (set_output_style, reset_terminal_style, prompt_for_continue):
3287         Update.
3288         (flush_wrap_buffer): Only flush gdb_stdout.
3289         (wrap_here): Set wrap_style.
3290         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
3291         treat escape sequences as a character.  Change when wrap buffer is
3292         flushed.
3293         (fputs_styled): Do not set the output style when the default is
3294         requested.
3295         * ui-style.h (struct ui_file_style) <is_default>: New method.
3296         * source.c (print_source_lines_base): Emit escape sequences in one
3297         piece.
3298
3299 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3300
3301         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
3302         integers and enumeration types.
3303
3304 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3305
3306         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
3307         instead of lookup_symbol_in_language
3308         (do_exact_match): New function.
3309         (ada_get_symbol_name_matcher): Return do_exact_match when
3310         doing a verbatim match.
3311
3312 2019-02-15  Tom Tromey  <tromey@adacore.com>
3313
3314         * ravenscar-thread.c (ravenscar_thread_target::resume)
3315         (ravenscar_thread_target::wait): Special case wildcard requests.
3316
3317 2019-02-15  Tom Tromey  <tromey@adacore.com>
3318
3319         * ravenscar-thread.c (base_ptid): Remove.
3320         (struct ravenscar_thread_target) <close>: New method.
3321         <m_base_ptid>: New member.
3322         <update_inferior_ptid, active_task, task_is_currently_active,
3323         runtime_initialized>: Declare methods.
3324         <ravenscar_thread_target>: Add constructor.
3325         (ravenscar_thread_target::task_is_currently_active)
3326         (ravenscar_thread_target::update_inferior_ptid)
3327         (ravenscar_runtime_initialized): Rename.  Now methods.
3328         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
3329         (ravenscar_thread_target::update_thread_list): Update.
3330         (ravenscar_thread_target::active_task): Now method.
3331         (ravenscar_thread_target::store_registers)
3332         (ravenscar_thread_target::prepare_to_store)
3333         (ravenscar_thread_target::prepare_to_store)
3334         (ravenscar_thread_target::mourn_inferior): Update.
3335         (ravenscar_inferior_created): Use "new" to create target.
3336         (ravenscar_thread_target::get_ada_task_ptid): Update.
3337         (_initialize_ravenscar): Don't initialize base_ptid.
3338         (ravenscar_ops): Remove global.
3339
3340 2019-02-15  Tom Tromey  <tromey@adacore.com>
3341
3342         * target.h (push_target): Declare new overload.
3343         * target.c (push_target): New overload, taking an rvalue reference.
3344         * remote.c (remote_target::open_1): Use push_target overload.
3345         * corelow.c (core_target_open): Use push_target overload.
3346
3347 2019-02-15  Tom Tromey  <tromey@adacore.com>
3348
3349         * ravenscar-thread.c (is_ravenscar_task)
3350         (ravenscar_task_is_currently_active): Return bool.
3351         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
3352         (_initialize_ravenscar): Remove "(void)".
3353         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
3354         Return bool.
3355
3356 2019-02-15  Tom Tromey  <tromey@adacore.com>
3357
3358         * ravenscar-thread.c (ravenscar_runtime_initializer)
3359         (has_ravenscar_runtime, get_running_thread_id)
3360         (ravenscar_thread_target::resume): Fix indentation.
3361
3362 2019-02-15  Tom Tromey  <tromey@adacore.com>
3363
3364         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
3365         from ravenscar_arch_ops.
3366         (sparc_ravenscar_ops::fetch_registers)
3367         (sparc_ravenscar_ops::store_registers): Now methods.
3368         (sparc_ravenscar_prepare_to_store): Remove.
3369         (sparc_ravenscar_ops): Redefine.
3370         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
3371         methods and destructor.  Remove members.
3372         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
3373         (ravenscar_thread_target::store_registers)
3374         (ravenscar_thread_target::prepare_to_store): Update.
3375         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
3376         Remove.
3377         (struct ppc_ravenscar_powerpc_ops): Derive from
3378         ravenscar_arch_ops.
3379         (ppc_ravenscar_powerpc_ops::fetch_registers)
3380         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
3381         (ppc_ravenscar_powerpc_ops): Redefine.
3382         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
3383         (ppc_ravenscar_e500_ops::fetch_registers)
3384         (ppc_ravenscar_e500_ops::store_registers): Now methods.
3385         (ppc_ravenscar_e500_ops): Redefine.
3386         * aarch64-ravenscar-thread.c
3387         (aarch64_ravenscar_generic_prepare_to_store): Remove.
3388         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
3389         (aarch64_ravenscar_fetch_registers)
3390         (aarch64_ravenscar_store_registers): Now methods.
3391         (aarch64_ravenscar_ops): Redefine.
3392
3393 2019-02-15  Tom Tromey  <tromey@adacore.com>
3394
3395         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
3396         (ravenscar_thread_target::stopped_by_hw_breakpoint)
3397         (ravenscar_thread_target::stopped_by_watchpoint)
3398         (ravenscar_thread_target::stopped_data_address)
3399         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
3400
3401 2019-02-15  Tom Tromey  <tromey@adacore.com>
3402
3403         * ravenscar-thread.c: Fix some typos.
3404
3405 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3406             Tom Tromey  <tromey@adacore.com>
3407
3408         * ada-lang.c (ada_exception_sal): Change addr_string to a
3409         std::string.
3410         (create_ada_exception_catchpoint): Update.
3411
3412 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3413             Tom Tromey  <tromey@adacore.com>
3414
3415         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
3416         (bp_location_ops): Remove.
3417         (base_breakpoint_allocate_location): Update.
3418         (free_bp_location): Update.
3419         * ada-lang.c (class ada_catchpoint_location)
3420         <ada_catchpoint_location>: Remove ops parameter.
3421         (ada_catchpoint_location_dtor): Remove.
3422         (ada_catchpoint_location_ops): Remove.
3423         (allocate_location_exception): Update.
3424         * breakpoint.h (struct bp_location_ops): Remove.
3425         (class bp_location) <bp_location>: Remove bp_location_ops
3426         parameter.
3427         <~bp_location>: Add destructor.
3428         <ops>: Remove.
3429
3430 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3431             Pedro Alves  <palves@redhat.com>
3432
3433         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
3434         'PATH_MAX'.
3435
3436 2019-02-14  David Michael  <fedora.dm0@gmail.com>
3437             Samuel Thibault  <samuel.thibault@gnu.org>
3438             Thomas Schwinge  <thomas@codesourcery.com>
3439
3440         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
3441         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
3442
3443 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3444
3445         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
3446         (check_empty): Use "const char *".
3447
3448         * gnu-nat.c (gnu_nat_target::detach): Instead of
3449         'detach_inferior (pid)' call
3450         'detach_inferior (find_inferior_pid (pid))'.
3451
3452         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
3453         'nat/fork-inferior.o'.
3454         * gnu-nat.c: #include "nat/fork-inferior.h".
3455
3456         * gnu-nat.c (gnu_nat_target::detach): Instead of
3457         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
3458         * gnu-nat.h: #include "inf-child.h".
3459         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
3460         'i386_gnu_nat_target::fetch_registers'.
3461         (gnu_store_registers): Rename/move to
3462         'i386_gnu_nat_target::store_registers'.
3463
3464         * config/i386/nm-i386gnu.h: Don't "#include" any files.
3465         * gnu-nat.h (mach_thread_info): New function.
3466         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
3467
3468         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
3469
3470 2019-02-14  Frederic Konrad  <konrad@adacore.com>
3471
3472         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
3473
3474 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
3475
3476         * windows-nat.c (windows_add_thread): Add new parameter
3477         "main_thread_p" with default value set to false.  Update
3478         function documentation as well as all callers.
3479         (windows_delete_thread): Likewise.
3480         (fake_create_process): Update call to windows_add_thread.
3481         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
3482         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
3483         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
3484         call to windows_delete_thread.
3485
3486 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
3487
3488         * MAINTAINERS: Add Andrew Burgess as global maintainer.
3489
3490 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3491
3492         * symfile.c (find_separate_debug_file): Use canonical path of
3493         sysroot with child_path instead of gdb_sysroot if it is valid.
3494
3495 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3496
3497         * symfile.c (find_separate_debug_file): Use child_path to
3498         determine if an object file is under a sysroot.
3499
3500 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3501
3502         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
3503         unittests/child-path-selftests.c.
3504         * common/pathstuff.c (child_path): New function.
3505         * common/pathstuff.h (child_path): New prototype.
3506         * unittests/child-path-selftests.c: New file.
3507
3508 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3509
3510         * symfile.c (find_separate_debug_file): Look for separate debug
3511         files in debug directories under the sysroot.
3512
3513 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3514
3515         * symtab.h (struct minimal_symbol data_p): New const method.
3516         (struct minimal_symbol text_p): Likewise.
3517         * symtab.c (output_source_filename): Use file name style
3518         to print file name.
3519         (print_symbol_info): Likewise.
3520         (print_msymbol_info): Use address style to print addresses.
3521         Use function name style to print executable text symbols.
3522         (expand_symtab_containing_pc): Use data_p.
3523         (find_pc_sect_compunit_symtab): Likewise.
3524
3525 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3526
3527         * breakpoint.c (describe_other_breakpoints): Use address style
3528         to print addresses.
3529         (say_where): Likewise.
3530
3531 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3532
3533         * ada-typeprint.c (print_func_type): Print function name
3534         style to print function name.
3535         * c-typeprint.c (c_print_type_1): Likewise.
3536
3537 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
3538
3539         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
3540         for execve.
3541
3542 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3543
3544         * c-exp.y (direct_abs_decl): Use emplace_back to record the
3545         type_stack.
3546
3547 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
3548
3549         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
3550         TYPE_CODE_REF types.
3551
3552 2019-02-08  Jim Wilson  <jimw@sifive.com>
3553
3554         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
3555         (riscv_linux_fregset): New.
3556         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
3557
3558 2019-02-07  Tom Tromey  <tom@tromey.com>
3559
3560         * thread.c (thread_cancel_execution_command): Update.
3561         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
3562         methods.
3563         (struct thread_fsm_ops): Remove.
3564         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
3565         (thread_fsm_should_stop, thread_fsm_return_value)
3566         (thread_fsm_set_finished, thread_fsm_finished_p)
3567         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
3568         Don't declare.
3569         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
3570         * infrun.c (clear_proceed_status_thread)
3571         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
3572         (print_stop_event): Update.
3573         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
3574         Add constructor.
3575         (step_command_fsm_ops): Remove.
3576         (new_step_command_fsm): Remove.
3577         (step_1): Update.
3578         (step_command_fsm::should_stop): Rename from
3579         step_command_fsm_should_stop.
3580         (step_command_fsm::clean_up): Rename from
3581         step_command_fsm_clean_up.
3582         (step_command_fsm::do_async_reply_reason): Rename from
3583         step_command_fsm_async_reply_reason.
3584         (struct until_next_fsm): Inherit from thread_fsm.  Add
3585         constructor.
3586         (until_next_fsm_ops): Remove.
3587         (new_until_next_fsm): Remove.
3588         (until_next_fsm::should_stop): Rename from
3589         until_next_fsm_should_stop.
3590         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
3591         (until_next_fsm::do_async_reply_reason): Rename from
3592         until_next_fsm_async_reply_reason.
3593         (struct finish_command_fsm): Inherit from thread_fsm.  Add
3594         constructor.  Change type of breakpoint.
3595         (finish_command_fsm_ops): Remove.
3596         (new_finish_command_fsm): Remove.
3597         (finish_command_fsm::should_stop): Rename from
3598         finish_command_fsm_should_stop.
3599         (finish_command_fsm::clean_up): Rename from
3600         finish_command_fsm_clean_up.
3601         (finish_command_fsm::return_value): Rename from
3602         finish_command_fsm_return_value.
3603         (finish_command_fsm::do_async_reply_reason): Rename from
3604         finish_command_fsm_async_reply_reason.
3605         (finish_command): Update.
3606         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
3607         Add constructor.
3608         (call_thread_fsm_ops): Remove.
3609         (call_thread_fsm::call_thread_fsm): Rename from
3610         new_call_thread_fsm.
3611         (call_thread_fsm::should_stop): Rename from
3612         call_thread_fsm_should_stop.
3613         (call_thread_fsm::should_notify_stop): Rename from
3614         call_thread_fsm_should_notify_stop.
3615         (run_inferior_call, call_function_by_hand_dummy): Update.
3616         * cli/cli-interp.c (should_print_stop_to_console): Update.
3617         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
3618         Add constructor.  Change type of location_breakpoint,
3619         caller_breakpoint.
3620         (until_break_fsm_ops): Remove.
3621         (new_until_break_fsm): Remove.
3622         (until_break_fsm::should_stop): Rename from
3623         until_break_fsm_should_stop.
3624         (until_break_fsm::clean_up): Rename from
3625         until_break_fsm_clean_up.
3626         (until_break_fsm::do_async_reply_reason): Rename from
3627         until_break_fsm_async_reply_reason.
3628         (until_break_command): Update.
3629         * thread-fsm.c: Remove.
3630         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
3631
3632 2019-02-07  Tom Tromey  <tom@tromey.com>
3633
3634         * yy-remap.h: Add include guard.
3635         * xtensa-tdep.h: Add include guard.
3636         * xcoffread.h: Rename include guard.
3637         * varobj-iter.h: Add include guard.
3638         * tui/tui.h: Rename include guard.
3639         * tui/tui-winsource.h: Rename include guard.
3640         * tui/tui-wingeneral.h: Rename include guard.
3641         * tui/tui-windata.h: Rename include guard.
3642         * tui/tui-win.h: Rename include guard.
3643         * tui/tui-stack.h: Rename include guard.
3644         * tui/tui-source.h: Rename include guard.
3645         * tui/tui-regs.h: Rename include guard.
3646         * tui/tui-out.h: Rename include guard.
3647         * tui/tui-layout.h: Rename include guard.
3648         * tui/tui-io.h: Rename include guard.
3649         * tui/tui-hooks.h: Rename include guard.
3650         * tui/tui-file.h: Rename include guard.
3651         * tui/tui-disasm.h: Rename include guard.
3652         * tui/tui-data.h: Rename include guard.
3653         * tui/tui-command.h: Rename include guard.
3654         * tic6x-tdep.h: Add include guard.
3655         * target/waitstatus.h: Rename include guard.
3656         * target/wait.h: Rename include guard.
3657         * target/target.h: Rename include guard.
3658         * target/resume.h: Rename include guard.
3659         * target-float.h: Rename include guard.
3660         * stabsread.h: Add include guard.
3661         * rs6000-tdep.h: Add include guard.
3662         * riscv-fbsd-tdep.h: Add include guard.
3663         * regformats/regdef.h: Rename include guard.
3664         * record.h: Rename include guard.
3665         * python/python.h: Rename include guard.
3666         * python/python-internal.h: Rename include guard.
3667         * python/py-stopevent.h: Rename include guard.
3668         * python/py-ref.h: Rename include guard.
3669         * python/py-record.h: Rename include guard.
3670         * python/py-record-full.h: Rename include guard.
3671         * python/py-record-btrace.h: Rename include guard.
3672         * python/py-instruction.h: Rename include guard.
3673         * python/py-events.h: Rename include guard.
3674         * python/py-event.h: Rename include guard.
3675         * procfs.h: Add include guard.
3676         * proc-utils.h: Add include guard.
3677         * p-lang.h: Add include guard.
3678         * or1k-tdep.h: Rename include guard.
3679         * observable.h: Rename include guard.
3680         * nto-tdep.h: Rename include guard.
3681         * nat/x86-linux.h: Rename include guard.
3682         * nat/x86-linux-dregs.h: Rename include guard.
3683         * nat/x86-gcc-cpuid.h: Add include guard.
3684         * nat/x86-dregs.h: Rename include guard.
3685         * nat/x86-cpuid.h: Rename include guard.
3686         * nat/ppc-linux.h: Rename include guard.
3687         * nat/mips-linux-watch.h: Rename include guard.
3688         * nat/linux-waitpid.h: Rename include guard.
3689         * nat/linux-ptrace.h: Rename include guard.
3690         * nat/linux-procfs.h: Rename include guard.
3691         * nat/linux-osdata.h: Rename include guard.
3692         * nat/linux-nat.h: Rename include guard.
3693         * nat/linux-namespaces.h: Rename include guard.
3694         * nat/linux-btrace.h: Rename include guard.
3695         * nat/glibc_thread_db.h: Rename include guard.
3696         * nat/gdb_thread_db.h: Rename include guard.
3697         * nat/gdb_ptrace.h: Rename include guard.
3698         * nat/fork-inferior.h: Rename include guard.
3699         * nat/amd64-linux-siginfo.h: Rename include guard.
3700         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
3701         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
3702         * nat/aarch64-linux.h: Rename include guard.
3703         * nat/aarch64-linux-hw-point.h: Rename include guard.
3704         * mn10300-tdep.h: Add include guard.
3705         * mips-linux-tdep.h: Add include guard.
3706         * mi/mi-parse.h: Rename include guard.
3707         * mi/mi-out.h: Rename include guard.
3708         * mi/mi-main.h: Rename include guard.
3709         * mi/mi-interp.h: Rename include guard.
3710         * mi/mi-getopt.h: Rename include guard.
3711         * mi/mi-console.h: Rename include guard.
3712         * mi/mi-common.h: Rename include guard.
3713         * mi/mi-cmds.h: Rename include guard.
3714         * mi/mi-cmd-break.h: Rename include guard.
3715         * m2-lang.h: Add include guard.
3716         * location.h: Rename include guard.
3717         * linux-record.h: Rename include guard.
3718         * linux-nat.h: Add include guard.
3719         * linux-fork.h: Add include guard.
3720         * i386-darwin-tdep.h: Rename include guard.
3721         * hppa-linux-offsets.h: Add include guard.
3722         * guile/guile.h: Rename include guard.
3723         * guile/guile-internal.h: Rename include guard.
3724         * gnu-nat.h: Rename include guard.
3725         * gdb-stabs.h: Rename include guard.
3726         * frv-tdep.h: Add include guard.
3727         * f-lang.h: Add include guard.
3728         * event-loop.h: Add include guard.
3729         * darwin-nat.h: Rename include guard.
3730         * cp-abi.h: Rename include guard.
3731         * config/sparc/nm-sol2.h: Rename include guard.
3732         * config/nm-nto.h: Rename include guard.
3733         * config/nm-linux.h: Add include guard.
3734         * config/i386/nm-i386gnu.h: Rename include guard.
3735         * config/djgpp/nl_types.h: Rename include guard.
3736         * config/djgpp/langinfo.h: Rename include guard.
3737         * compile/gcc-cp-plugin.h: Add include guard.
3738         * compile/gcc-c-plugin.h: Add include guard.
3739         * compile/compile.h: Rename include guard.
3740         * compile/compile-object-run.h: Rename include guard.
3741         * compile/compile-object-load.h: Rename include guard.
3742         * compile/compile-internal.h: Rename include guard.
3743         * compile/compile-cplus.h: Rename include guard.
3744         * compile/compile-c.h: Rename include guard.
3745         * common/xml-utils.h: Rename include guard.
3746         * common/x86-xstate.h: Rename include guard.
3747         * common/version.h: Rename include guard.
3748         * common/vec.h: Rename include guard.
3749         * common/tdesc.h: Rename include guard.
3750         * common/selftest.h: Rename include guard.
3751         * common/scoped_restore.h: Rename include guard.
3752         * common/scoped_mmap.h: Rename include guard.
3753         * common/scoped_fd.h: Rename include guard.
3754         * common/safe-iterator.h: Rename include guard.
3755         * common/run-time-clock.h: Rename include guard.
3756         * common/refcounted-object.h: Rename include guard.
3757         * common/queue.h: Rename include guard.
3758         * common/ptid.h: Rename include guard.
3759         * common/print-utils.h: Rename include guard.
3760         * common/preprocessor.h: Rename include guard.
3761         * common/pathstuff.h: Rename include guard.
3762         * common/observable.h: Rename include guard.
3763         * common/netstuff.h: Rename include guard.
3764         * common/job-control.h: Rename include guard.
3765         * common/host-defs.h: Rename include guard.
3766         * common/gdb_wait.h: Rename include guard.
3767         * common/gdb_vecs.h: Rename include guard.
3768         * common/gdb_unlinker.h: Rename include guard.
3769         * common/gdb_unique_ptr.h: Rename include guard.
3770         * common/gdb_tilde_expand.h: Rename include guard.
3771         * common/gdb_sys_time.h: Rename include guard.
3772         * common/gdb_string_view.h: Rename include guard.
3773         * common/gdb_splay_tree.h: Rename include guard.
3774         * common/gdb_setjmp.h: Rename include guard.
3775         * common/gdb_ref_ptr.h: Rename include guard.
3776         * common/gdb_optional.h: Rename include guard.
3777         * common/gdb_locale.h: Rename include guard.
3778         * common/gdb_assert.h: Rename include guard.
3779         * common/filtered-iterator.h: Rename include guard.
3780         * common/filestuff.h: Rename include guard.
3781         * common/fileio.h: Rename include guard.
3782         * common/environ.h: Rename include guard.
3783         * common/common-utils.h: Rename include guard.
3784         * common/common-types.h: Rename include guard.
3785         * common/common-regcache.h: Rename include guard.
3786         * common/common-inferior.h: Rename include guard.
3787         * common/common-gdbthread.h: Rename include guard.
3788         * common/common-exceptions.h: Rename include guard.
3789         * common/common-defs.h: Rename include guard.
3790         * common/common-debug.h: Rename include guard.
3791         * common/cleanups.h: Rename include guard.
3792         * common/buffer.h: Rename include guard.
3793         * common/btrace-common.h: Rename include guard.
3794         * common/break-common.h: Rename include guard.
3795         * cli/cli-utils.h: Rename include guard.
3796         * cli/cli-style.h: Rename include guard.
3797         * cli/cli-setshow.h: Rename include guard.
3798         * cli/cli-script.h: Rename include guard.
3799         * cli/cli-interp.h: Rename include guard.
3800         * cli/cli-decode.h: Rename include guard.
3801         * cli/cli-cmds.h: Rename include guard.
3802         * charset-list.h: Add include guard.
3803         * buildsym-legacy.h: Rename include guard.
3804         * bfin-tdep.h: Add include guard.
3805         * ax.h: Rename include guard.
3806         * arm-linux-tdep.h: Add include guard.
3807         * arm-fbsd-tdep.h: Add include guard.
3808         * arch/xtensa.h: Rename include guard.
3809         * arch/tic6x.h: Add include guard.
3810         * arch/i386.h: Add include guard.
3811         * arch/arm.h: Rename include guard.
3812         * arch/arm-linux.h: Rename include guard.
3813         * arch/arm-get-next-pcs.h: Rename include guard.
3814         * arch/amd64.h: Add include guard.
3815         * arch/aarch64-insn.h: Rename include guard.
3816         * arch-utils.h: Rename include guard.
3817         * annotate.h: Add include guard.
3818         * amd64-darwin-tdep.h: Rename include guard.
3819         * aarch64-linux-tdep.h: Add include guard.
3820         * aarch64-fbsd-tdep.h: Add include guard.
3821         * aarch32-linux-nat.h: Add include guard.
3822
3823 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3824
3825         * macrotab.c (macro_define_internal): New function that
3826         factorizes macro_define_object_internal and macro_define_function
3827         code.
3828         (macro_define_object_internal): Use macro_define_internal.
3829         (macro_define_function): Likewise.
3830
3831 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3832
3833         * macrocmd.c (extract_identifier): Return
3834         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
3835         callers.
3836
3837 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
3838
3839         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
3840
3841 2019-02-05  Tom Tromey  <tom@tromey.com>
3842
3843         * target.c (target_stack::unpush): Move assertion earlier.
3844
3845 2019-01-30  Tom Tromey  <tom@tromey.com>
3846
3847         PR python/23615:
3848         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
3849         (gdbpy_parse_and_eval): Likewise.
3850         * python/python-internal.h (gdbpy_allow_threads): New class.
3851
3852 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
3853
3854         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
3855         (aarch64_fbsd_fpregmap): Move earlier.
3856         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
3857         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3858         instead of individual calls to trad_frame_set_reg_addr.
3859         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
3860         earlier.
3861         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
3862         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3863         instead of individual calls to trad_frame_set_reg_addr.
3864
3865 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
3866
3867         * CONTRIBUTE: Replace contribution list with wiki link.
3868
3869 2019-01-25  Tom Tromey  <tom@tromey.com>
3870
3871         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
3872
3873 2019-01-25  Tom Tromey  <tom@tromey.com>
3874
3875         * xtensa-linux-nat.c: Fix common/ includes.
3876         * xml-support.h: Fix common/ includes.
3877         * xml-support.c: Fix common/ includes.
3878         * x86-linux-nat.c: Fix common/ includes.
3879         * windows-nat.c: Fix common/ includes.
3880         * varobj.h: Fix common/ includes.
3881         * varobj.c: Fix common/ includes.
3882         * value.c: Fix common/ includes.
3883         * valops.c: Fix common/ includes.
3884         * utils.c: Fix common/ includes.
3885         * unittests/xml-utils-selftests.c: Fix common/ includes.
3886         * unittests/utils-selftests.c: Fix common/ includes.
3887         * unittests/unpack-selftests.c: Fix common/ includes.
3888         * unittests/tracepoint-selftests.c: Fix common/ includes.
3889         * unittests/style-selftests.c: Fix common/ includes.
3890         * unittests/string_view-selftests.c: Fix common/ includes.
3891         * unittests/scoped_restore-selftests.c: Fix common/ includes.
3892         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
3893         * unittests/scoped_fd-selftests.c: Fix common/ includes.
3894         * unittests/rsp-low-selftests.c: Fix common/ includes.
3895         * unittests/parse-connection-spec-selftests.c: Fix common/
3896         includes.
3897         * unittests/optional-selftests.c: Fix common/ includes.
3898         * unittests/offset-type-selftests.c: Fix common/ includes.
3899         * unittests/observable-selftests.c: Fix common/ includes.
3900         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
3901         * unittests/memrange-selftests.c: Fix common/ includes.
3902         * unittests/memory-map-selftests.c: Fix common/ includes.
3903         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
3904         * unittests/function-view-selftests.c: Fix common/ includes.
3905         * unittests/environ-selftests.c: Fix common/ includes.
3906         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
3907         * unittests/common-utils-selftests.c: Fix common/ includes.
3908         * unittests/cli-utils-selftests.c: Fix common/ includes.
3909         * unittests/array-view-selftests.c: Fix common/ includes.
3910         * ui-file.c: Fix common/ includes.
3911         * tui/tui-io.c: Fix common/ includes.
3912         * tracepoint.h: Fix common/ includes.
3913         * tracepoint.c: Fix common/ includes.
3914         * tracefile-tfile.c: Fix common/ includes.
3915         * top.h: Fix common/ includes.
3916         * top.c: Fix common/ includes.
3917         * thread.c: Fix common/ includes.
3918         * target/waitstatus.h: Fix common/ includes.
3919         * target/waitstatus.c: Fix common/ includes.
3920         * target.h: Fix common/ includes.
3921         * target.c: Fix common/ includes.
3922         * target-memory.c: Fix common/ includes.
3923         * target-descriptions.c: Fix common/ includes.
3924         * symtab.h: Fix common/ includes.
3925         * symfile.c: Fix common/ includes.
3926         * stap-probe.c: Fix common/ includes.
3927         * spu-linux-nat.c: Fix common/ includes.
3928         * sparc-nat.c: Fix common/ includes.
3929         * source.c: Fix common/ includes.
3930         * solib.c: Fix common/ includes.
3931         * solib-target.c: Fix common/ includes.
3932         * ser-unix.c: Fix common/ includes.
3933         * ser-tcp.c: Fix common/ includes.
3934         * ser-pipe.c: Fix common/ includes.
3935         * ser-base.c: Fix common/ includes.
3936         * selftest-arch.c: Fix common/ includes.
3937         * s12z-tdep.c: Fix common/ includes.
3938         * rust-exp.y: Fix common/ includes.
3939         * rs6000-aix-tdep.c: Fix common/ includes.
3940         * riscv-tdep.c: Fix common/ includes.
3941         * remote.c: Fix common/ includes.
3942         * remote-notif.h: Fix common/ includes.
3943         * remote-fileio.h: Fix common/ includes.
3944         * remote-fileio.c: Fix common/ includes.
3945         * regcache.h: Fix common/ includes.
3946         * regcache.c: Fix common/ includes.
3947         * record-btrace.c: Fix common/ includes.
3948         * python/python.c: Fix common/ includes.
3949         * python/py-type.c: Fix common/ includes.
3950         * python/py-inferior.c: Fix common/ includes.
3951         * progspace.h: Fix common/ includes.
3952         * producer.c: Fix common/ includes.
3953         * procfs.c: Fix common/ includes.
3954         * proc-api.c: Fix common/ includes.
3955         * printcmd.c: Fix common/ includes.
3956         * ppc-linux-nat.c: Fix common/ includes.
3957         * parser-defs.h: Fix common/ includes.
3958         * osdata.c: Fix common/ includes.
3959         * obsd-nat.c: Fix common/ includes.
3960         * nat/x86-linux.c: Fix common/ includes.
3961         * nat/x86-linux-dregs.c: Fix common/ includes.
3962         * nat/x86-dregs.h: Fix common/ includes.
3963         * nat/x86-dregs.c: Fix common/ includes.
3964         * nat/ppc-linux.c: Fix common/ includes.
3965         * nat/mips-linux-watch.h: Fix common/ includes.
3966         * nat/mips-linux-watch.c: Fix common/ includes.
3967         * nat/linux-waitpid.c: Fix common/ includes.
3968         * nat/linux-ptrace.h: Fix common/ includes.
3969         * nat/linux-ptrace.c: Fix common/ includes.
3970         * nat/linux-procfs.c: Fix common/ includes.
3971         * nat/linux-personality.c: Fix common/ includes.
3972         * nat/linux-osdata.c: Fix common/ includes.
3973         * nat/linux-namespaces.c: Fix common/ includes.
3974         * nat/linux-btrace.h: Fix common/ includes.
3975         * nat/linux-btrace.c: Fix common/ includes.
3976         * nat/fork-inferior.c: Fix common/ includes.
3977         * nat/amd64-linux-siginfo.c: Fix common/ includes.
3978         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
3979         * nat/aarch64-linux.c: Fix common/ includes.
3980         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
3981         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
3982         * namespace.h: Fix common/ includes.
3983         * mips-linux-tdep.c: Fix common/ includes.
3984         * minsyms.c: Fix common/ includes.
3985         * mi/mi-parse.h: Fix common/ includes.
3986         * mi/mi-main.c: Fix common/ includes.
3987         * mi/mi-cmd-env.c: Fix common/ includes.
3988         * memrange.h: Fix common/ includes.
3989         * memattr.c: Fix common/ includes.
3990         * maint.h: Fix common/ includes.
3991         * maint.c: Fix common/ includes.
3992         * main.c: Fix common/ includes.
3993         * machoread.c: Fix common/ includes.
3994         * location.c: Fix common/ includes.
3995         * linux-thread-db.c: Fix common/ includes.
3996         * linux-nat.c: Fix common/ includes.
3997         * linux-fork.c: Fix common/ includes.
3998         * inline-frame.c: Fix common/ includes.
3999         * infrun.c: Fix common/ includes.
4000         * inflow.c: Fix common/ includes.
4001         * inferior.h: Fix common/ includes.
4002         * inferior.c: Fix common/ includes.
4003         * infcmd.c: Fix common/ includes.
4004         * inf-ptrace.c: Fix common/ includes.
4005         * inf-child.c: Fix common/ includes.
4006         * ia64-linux-nat.c: Fix common/ includes.
4007         * i387-tdep.c: Fix common/ includes.
4008         * i386-tdep.c: Fix common/ includes.
4009         * i386-linux-tdep.c: Fix common/ includes.
4010         * i386-linux-nat.c: Fix common/ includes.
4011         * i386-go32-tdep.c: Fix common/ includes.
4012         * i386-fbsd-tdep.c: Fix common/ includes.
4013         * i386-fbsd-nat.c: Fix common/ includes.
4014         * guile/scm-type.c: Fix common/ includes.
4015         * guile/guile.c: Fix common/ includes.
4016         * go32-nat.c: Fix common/ includes.
4017         * gnu-nat.c: Fix common/ includes.
4018         * gdbthread.h: Fix common/ includes.
4019         * gdbarch-selftests.c: Fix common/ includes.
4020         * gdb_usleep.c: Fix common/ includes.
4021         * gdb_select.h: Fix common/ includes.
4022         * gdb_bfd.c: Fix common/ includes.
4023         * gcore.c: Fix common/ includes.
4024         * fork-child.c: Fix common/ includes.
4025         * findvar.c: Fix common/ includes.
4026         * fbsd-nat.c: Fix common/ includes.
4027         * event-top.c: Fix common/ includes.
4028         * event-loop.c: Fix common/ includes.
4029         * dwarf2read.c: Fix common/ includes.
4030         * dwarf2loc.c: Fix common/ includes.
4031         * dwarf2-frame.c: Fix common/ includes.
4032         * dwarf-index-cache.c: Fix common/ includes.
4033         * dtrace-probe.c: Fix common/ includes.
4034         * disasm-selftests.c: Fix common/ includes.
4035         * defs.h: Fix common/ includes.
4036         * csky-tdep.c: Fix common/ includes.
4037         * cp-valprint.c: Fix common/ includes.
4038         * cp-support.h: Fix common/ includes.
4039         * cp-support.c: Fix common/ includes.
4040         * corelow.c: Fix common/ includes.
4041         * completer.h: Fix common/ includes.
4042         * completer.c: Fix common/ includes.
4043         * compile/compile.c: Fix common/ includes.
4044         * compile/compile-loc2c.c: Fix common/ includes.
4045         * compile/compile-cplus-types.c: Fix common/ includes.
4046         * compile/compile-cplus-symbols.c: Fix common/ includes.
4047         * command.h: Fix common/ includes.
4048         * cli/cli-dump.c: Fix common/ includes.
4049         * cli/cli-cmds.c: Fix common/ includes.
4050         * charset.c: Fix common/ includes.
4051         * build-id.c: Fix common/ includes.
4052         * btrace.h: Fix common/ includes.
4053         * btrace.c: Fix common/ includes.
4054         * breakpoint.h: Fix common/ includes.
4055         * breakpoint.c: Fix common/ includes.
4056         * ax.h: 
4057         (enum agent_op): Fix common/ includes.
4058         * ax-general.c (struct aop_map): Fix common/ includes.
4059         * ax-gdb.c: Fix common/ includes.
4060         * auxv.c: Fix common/ includes.
4061         * auto-load.c: Fix common/ includes.
4062         * arm-tdep.c: Fix common/ includes.
4063         * arch/riscv.c: Fix common/ includes.
4064         * arch/ppc-linux-common.c: Fix common/ includes.
4065         * arch/i386.c: Fix common/ includes.
4066         * arch/arm.c: Fix common/ includes.
4067         * arch/arm-linux.c: Fix common/ includes.
4068         * arch/arm-get-next-pcs.c: Fix common/ includes.
4069         * arch/amd64.c: Fix common/ includes.
4070         * arch/aarch64.c: Fix common/ includes.
4071         * arch/aarch64-insn.c: Fix common/ includes.
4072         * arch-utils.c: Fix common/ includes.
4073         * amd64-windows-tdep.c: Fix common/ includes.
4074         * amd64-tdep.c: Fix common/ includes.
4075         * amd64-sol2-tdep.c: Fix common/ includes.
4076         * amd64-obsd-tdep.c: Fix common/ includes.
4077         * amd64-nbsd-tdep.c: Fix common/ includes.
4078         * amd64-linux-tdep.c: Fix common/ includes.
4079         * amd64-linux-nat.c: Fix common/ includes.
4080         * amd64-fbsd-tdep.c: Fix common/ includes.
4081         * amd64-fbsd-nat.c: Fix common/ includes.
4082         * amd64-dicos-tdep.c: Fix common/ includes.
4083         * amd64-darwin-tdep.c: Fix common/ includes.
4084         * agent.c: Fix common/ includes.
4085         * ada-lang.h: Fix common/ includes.
4086         * ada-lang.c: Fix common/ includes.
4087         * aarch64-tdep.c: Fix common/ includes.
4088
4089 2019-01-25  Tom Tromey  <tom@tromey.com>
4090
4091         * common/create-version.sh: Use common/version.h.
4092
4093 2019-01-24  Pedro Alves  <palves@redhat.com>
4094
4095         * infrun.c (signal_stop, signal_print, signal_program)
4096         (signal_catch, signal_pass): Now arrays instead of pointers.
4097         (update_signals_program_target, do_target_resume)
4098         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
4099         * linux-nat.c (linux_nat_target::pass_signals)
4100         (linux_nat_target::create_inferior, linux_nat_target::attach):
4101         Adjust.
4102         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
4103         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
4104         * procfs.c (procfs_target::pass_signals): Adjust.
4105         * record-full.c (record_full_target::resume): Adjust.
4106         * remote.c (remote_target::pass_signals)
4107         (remote_target::program_signals): Adjust.
4108         * target-debug.h (target_debug_print_signals): Now takes a
4109         gdb::array_view as parameter.  Adjust.
4110         * target.h (target_ops) <pass_signals, program_signals>: Replace
4111         pointer and length parameters with gdb::array_view.
4112         (target_pass_signals, target_program_signals): Likewise.
4113         * target-delegates.c: Regenerate.
4114
4115 2019-01-24  Pedro Alves  <palves@redhat.com>
4116
4117         * common/forward-scope-exit.h
4118         (forward_scope_exit::forward_scope_exit): Pass arguments to
4119         m_bind_function directly, instead of creating a std::bind and
4120         copying that.
4121
4122 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
4123
4124         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4125         for static members.
4126         (pass_in_v_vfp_candidate): Likewise.
4127
4128 2019-01-23  Tom Tromey  <tom@tromey.com>
4129             Pedro Alves  <palves@redhat.com>
4130
4131         * regcache.c (class regcache_invalidator): Remove.
4132         (regcache::raw_write): Use make_scope_exit.
4133
4134 2019-01-23  Tom Tromey  <tom@tromey.com>
4135
4136         * ui-out.h (class ui_out_emit_type): Update comment.
4137
4138 2019-01-23  Tom Tromey  <tom@tromey.com>
4139
4140         * infrun.c (fetch_inferior_event): Update comment.
4141
4142 2019-01-23  Tom Tromey  <tom@tromey.com>
4143             Pedro Alves  <palves@redhat.com>
4144
4145         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
4146         parameter.
4147         (fetch_inferior_event): Use SCOPE_EXIT.
4148
4149
4150 2019-01-23  Tom Tromey  <tom@tromey.com>
4151             Pedro Alves  <palves@redhat.com>
4152
4153         * infrun.c (disable_thread_events): Delete.
4154         (stop_all_threads): Use SCOPE_EXIT.
4155
4156 2019-01-23  Tom Tromey  <tom@tromey.com>
4157             Pedro Alves  <palves@redhat.com>
4158
4159         * symfile.c: Include forward-scope-exit.h.
4160         (clear_symtab_users_cleanup): Replace forward declaration with
4161         a FORWARD_SCOPE_EXIT.
4162         (syms_from_objfile_1): Use the forward_scope_exit and
4163         gdb::optional instead of cleanup_function.
4164         (reread_symbols): Use the forward_scope_exit instead of
4165         cleanup_function.
4166         (clear_symtab_users_cleanup): Remove function.
4167
4168 2019-01-23  Tom Tromey  <tom@tromey.com>
4169             Pedro Alves  <palves@redhat.com>
4170
4171         * linux-nat.c: Include scope-exit.h.
4172         (cleanup_target_stop): Remove.
4173         (linux_nat_target::static_tracepoint_markers_by_strid): Use
4174         SCOPE_EXIT.
4175
4176 2019-01-23  Tom Tromey  <tom@tromey.com>
4177             Pedro Alves  <palves@redhat.com>
4178
4179         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
4180         (call_function_by_hand_dummy): Use SCOPE_EXIT.
4181
4182 2019-01-23  Tom Tromey  <tom@tromey.com>
4183             Andrew Burgess  <andrew.burgess@embecosm.com>
4184             Pedro Alves  <palves@redhat.com>
4185
4186         * infrun.c (fetch_inferior_event): Use scope_exit.
4187         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
4188         * top.c (execute_command): Use scope_exit.
4189         * breakpoint.c (bpstat_do_actions): Use scope_exit.
4190         * utils.c (do_bpstat_clear_actions_cleanup)
4191         (make_bpstat_clear_actions_cleanup): Remove.
4192
4193 2019-01-23  Tom Tromey  <tom@tromey.com>
4194             Pedro Alves  <palves@redhat.com>
4195
4196         * infrun.c: Include "common/scope-exit.h"
4197         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
4198         (wait_for_inferior): Use SCOPE_EXIT.
4199         (fetch_inferior_event): Use scope_exit.
4200
4201 2019-01-23  Tom Tromey  <tom@tromey.com>
4202             Pedro Alves  <palves@redhat.com>
4203
4204         * breakpoint.c (create_breakpoint): Remove cleanup.
4205
4206 2019-01-23  Tom Tromey  <tom@tromey.com>
4207             Andrew Burgess  <andrew.burgess@embecosm.com>
4208             Pedro Alves  <palves@redhat.com>
4209
4210 2019-01-23  Pedro Alves  <palves@redhat.com>
4211
4212         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
4213
4214 2019-01-23  Pedro Alves  <palves@redhat.com>
4215             Andrew Burgess  <andrew.burgess@embecosm.com>
4216
4217         * gdbthread.h: Include "common/forward-scope-exit.h".
4218         (scoped_finish_thread_state): Redefine custom class in terms of
4219         forward_scope_exit.
4220
4221 2019-01-23  Pedro Alves  <palves@redhat.com>
4222             Andrew Burgess  <andrew.burgess@embecosm.com>
4223
4224         * common/forward-scope-exit.h: New file.
4225
4226 2019-01-23  Pedro Alves  <palves@redhat.com>
4227             Andrew Burgess  <andrew.burgess@embecosm.com>
4228             Tom Tromey  <tom@tromey.com>
4229
4230         * common/scope-exit.h: New file.
4231
4232 2019-01-23  Pedro Alves  <palves@redhat.com>
4233
4234         * common/preprocessor.h (ESC): Rename to ...
4235         (ESC_PARENS): ... this.
4236         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
4237         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
4238
4239 2019-01-23  Tom Tromey  <tom@tromey.com>
4240
4241         * language.h (class scoped_switch_to_sym_language_if_auto):
4242         Initialize m_lang in both cases.
4243
4244 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
4245
4246         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
4247         with XCNEW.
4248
4249 2019-01-22  Tom Tromey  <tom@tromey.com>
4250
4251         * corelow.c: Do not include sys/file.h.
4252
4253 2019-01-22  Tom Tromey  <tom@tromey.com>
4254
4255         * tui/tui-wingeneral.h: Include gdb_curses.h.
4256
4257 2019-01-22  Tom Tromey  <tom@tromey.com>
4258
4259         * source-cache.h (class source_cache) <get_source_lines,
4260         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
4261
4262 2019-01-22  Tom Tromey  <tom@tromey.com>
4263
4264         * remote-fileio.h (struct remote_target): Declare.
4265
4266 2019-01-22  Tom Tromey  <tom@tromey.com>
4267
4268         * python/py-arch.c: Do not include py-ref.h.
4269         * python/py-bpevent.c: Do not include py-ref.h.
4270         * python/py-cmd.c: Do not include py-ref.h.
4271         * python/py-continueevent.c: Do not include py-ref.h.
4272         * python/py-event.h: Do not include py-ref.h.
4273         * python/py-evtregistry.c: Do not include py-ref.h.
4274         * python/py-finishbreakpoint.c: Do not include py-ref.h.
4275         * python/py-frame.c: Do not include py-ref.h.
4276         * python/py-framefilter.c: Do not include py-ref.h.
4277         * python/py-function.c: Do not include py-ref.h.
4278         * python/py-infevents.c: Do not include py-ref.h.
4279         * python/py-linetable.c: Do not include py-ref.h.
4280         * python/py-objfile.c: Do not include py-ref.h.
4281         * python/py-param.c: Do not include py-ref.h.
4282         * python/py-prettyprint.c: Do not include py-ref.h.
4283         * python/py-progspace.c: Do not include py-ref.h.
4284         * python/py-symbol.c: Do not include py-ref.h.
4285         * python/py-symtab.c: Do not include py-ref.h.
4286         * python/py-type.c: Do not include py-ref.h.
4287         * python/py-unwind.c: Do not include py-ref.h.
4288         * python/py-utils.c: Do not include py-ref.h.
4289         * python/py-value.c: Do not include py-ref.h.
4290         * python/py-varobj.c: Do not include py-ref.h.
4291         * python/py-xmethods.c: Do not include py-ref.h.
4292         * python/python.c: Do not include py-ref.h.
4293         * varobj.c: Do not include py-ref.h.
4294
4295 2019-01-22  Tom Tromey  <tom@tromey.com>
4296
4297         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
4298         keyword for bcache.
4299
4300 2019-01-22  Tom Tromey  <tom@tromey.com>
4301
4302         * compile/compile-cplus-types.c: Remove a comment by #include.
4303
4304 2019-01-22  Tom Tromey  <tom@tromey.com>
4305
4306         * compile/gcc-c-plugin.h: Include compile-internal.h.
4307
4308 2019-01-22  Tom Tromey  <tom@tromey.com>
4309
4310         * stabsread.c (EXTERN): Do not define.
4311         (symnum, next_symbol_text_func, processing_gcc_compilation)
4312         (within_function, global_sym_chain, global_stabs)
4313         (previous_stab_code, this_object_header_files)
4314         (n_this_object_header_files)
4315         (n_allocated_this_object_header_files): Define.
4316         * stabsread.h (EXTERN): Never define.  Use "extern".
4317
4318 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4319
4320         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
4321         history_value.
4322
4323 2019-01-21  Tom Tromey  <tom@tromey.com>
4324
4325         * ui-out.c: Fix includes.
4326         * tui/tui-source.c: Fix includes.
4327         * target.c: Fix includes.
4328         * remote.c: Fix includes.
4329         * regcache.c: Fix includes.
4330         * python/py-block.c: Fix includes.
4331         * printcmd.c: Fix includes.
4332         * or1k-tdep.c: Fix includes.
4333         * mi/mi-main.c: Fix includes.
4334         * m32r-tdep.c: Fix includes.
4335         * csky-tdep.c: Fix includes.
4336         * compile/compile-cplus-types.c: Fix includes.
4337         * cli/cli-interp.c: Fix includes.
4338
4339 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
4340
4341         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4342         for padding.
4343
4344 2019-01-16  Tom Tromey  <tom@tromey.com>
4345
4346         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
4347         earlier.
4348         (struct objfile) <msymbols_range>: Move from top level.
4349         <msymbols>: New method.
4350         (class objfile_msymbols): Remove.
4351         * symtab.c (default_collect_symbol_completion_matches_break_on):
4352         Update.
4353         * symmisc.c (dump_msymbols): Update.
4354         * stabsread.c (scan_file_globals): Update.
4355         * objc-lang.c (info_selectors_command, info_classes_command)
4356         (find_methods): Update.
4357         * minsyms.c (find_solib_trampoline_target): Update.
4358         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
4359         * coffread.c (coff_symfile_read): Update.
4360         * ada-lang.c (ada_lookup_simple_minsym)
4361         (ada_collect_symbol_completion_matches): Update.
4362
4363 2019-01-16  Tom Tromey  <tom@tromey.com>
4364
4365         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
4366         type.  Remove no-argument constructor.
4367         <iterator::operator++>: Simplify.
4368         <begin>: Update.
4369         <end>: Use minimal_symbol_count.
4370
4371 2019-01-16  Tom Tromey  <tom@tromey.com>
4372
4373         * objfiles.h (struct objfile) <psymtabs>: New method.
4374         (class objfile_psymtabs): Remove.
4375         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
4376         typedef.
4377         <range>: New method.
4378         (require_partial_symbols): Change return type.
4379         * psymtab.c (require_partial_symbols)
4380         (psym_expand_symtabs_matching): Update.
4381         * mdebugread.c (parse_partial_symbols): Update.
4382         * dbxread.c (dbx_end_psymtab): Update.
4383
4384 2019-01-15  Tom Tromey  <tom@tromey.com>
4385
4386         * symtab.c (lookup_objfile_from_block)
4387         (lookup_symbol_in_objfile_symtabs)
4388         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
4389         (find_line_symtab, info_sources_command)
4390         (default_collect_symbol_completion_matches_break_on)
4391         (make_source_files_completion_list): Update.
4392         * symmisc.c (print_objfile_statistics, dump_objfile)
4393         (maintenance_print_symbols, maintenance_info_symtabs)
4394         (maintenance_check_symtabs, maintenance_info_line_tables):
4395         Update.
4396         * source.c (select_source_symtab)
4397         (forget_cached_source_info_for_objfile): Update.
4398         * objfiles.h (class objfile_compunits): Remove.
4399         (struct objfile) <compunits_range>: New typedef.
4400         (compunits): New method.
4401         * objfiles.c (objfile_relocate1): Update.
4402         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4403         * maint.c (count_symtabs_and_blocks): Update.
4404         * linespec.c (iterate_over_all_matching_symtabs): Update.
4405         * cp-support.c (add_symbol_overload_list_qualified): Update.
4406         * coffread.c (coff_symtab_read): Update.
4407         * ada-lang.c (add_nonlocal_symbols)
4408         (ada_collect_symbol_completion_matches)
4409         (ada_add_global_exceptions): Update.
4410
4411 2019-01-15  Tom Tromey  <tom@tromey.com>
4412
4413         * progspace.h (program_space) <objfiles_safe_range>: New
4414         typedef.
4415         <objfiles_safe>: New method.
4416         * objfiles.h (class all_objfiles_safe): Remove.
4417         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
4418         * jit.c (jit_inferior_exit_hook): Update.
4419
4420 2019-01-17  Tom Tromey  <tom@tromey.com>
4421
4422         * progspace.h (program_space) <objfiles_range>: New typedef.
4423         <objfiles>: New method.
4424         <objfiles_head>: Rename from objfiles.
4425         (object_files): Update.
4426         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
4427         * guile/scm-pretty-print.c
4428         (ppscm_find_pretty_printer_from_objfiles): Update.
4429         * guile/scm-objfile.c (gdbscm_objfiles): Update.
4430         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
4431         Update.
4432         * python/py-progspace.c (pspy_get_objfiles): Update.
4433         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
4434         Update.
4435         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
4436         (objfpy_lookup_objfile_by_build_id): Update.
4437         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4438         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
4439         Update.
4440         * symtab.c (iterate_over_symtabs, matching_obj_sections)
4441         (expand_symtab_containing_pc, lookup_objfile_from_block)
4442         (lookup_static_symbol, basic_lookup_transparent_type)
4443         (find_pc_sect_compunit_symtab, find_symbol_at_address)
4444         (find_line_symtab, info_sources_command)
4445         (default_collect_symbol_completion_matches_break_on)
4446         (make_source_files_completion_list, find_main_name): Update.
4447         * symmisc.c (print_symbol_bcache_statistics)
4448         (print_objfile_statistics, maintenance_print_symbols)
4449         (maintenance_print_msymbols, maintenance_print_objfiles)
4450         (maintenance_info_symtabs, maintenance_check_symtabs)
4451         (maintenance_expand_symtabs, maintenance_info_line_tables):
4452         Update.
4453         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
4454         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
4455         (map_overlay_command, unmap_overlay_command)
4456         (simple_overlay_update, expand_symtabs_matching)
4457         (map_symbol_filenames): Update.
4458         * symfile-debug.c (set_debug_symfile): Update.
4459         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
4460         Update.
4461         * source.c (select_source_symtab, forget_cached_source_info):
4462         Update.
4463         * solib.c (solib_read_symbols): Update.
4464         * solib-spu.c (append_ocl_sos): Update.
4465         * psymtab.c (maintenance_print_psymbols)
4466         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
4467         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
4468         * printcmd.c (info_symbol_command): Update.
4469         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
4470         Update.
4471         * objfiles.h (class all_objfiles): Remove.
4472         * objfiles.c (have_partial_symbols, have_full_symbols)
4473         (have_minimal_symbols, qsort_cmp, update_section_map)
4474         (shared_objfile_contains_address_p)
4475         (default_iterate_over_objfiles_in_search_order): Update.
4476         * objc-lang.c (info_selectors_command, info_classes_command)
4477         (find_methods): Update.
4478         * minsyms.c (find_solib_trampoline_target): Update.
4479         * maint.c (maintenance_info_sections)
4480         (maintenance_translate_address, count_symtabs_and_blocks):
4481         Update.
4482         * main.c (captured_main_1): Update.
4483         * linux-thread-db.c (try_thread_db_load_from_pdir)
4484         (has_libpthread): Update.
4485         * linespec.c (iterate_over_all_matching_symtabs)
4486         (search_minsyms_for_name): Update.
4487         * jit.c (jit_find_objf_with_entry_addr): Update.
4488         * hppa-tdep.c (find_unwind_entry)
4489         (hppa_lookup_stub_minimal_symbol): Update.
4490         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
4491         Update.
4492         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
4493         (elf_gnu_ifunc_resolve_by_got): Update.
4494         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
4495         * dwarf-index-write.c (save_gdb_index_command): Update.
4496         * cp-support.c (add_symbol_overload_list_qualified): Update.
4497         * breakpoint.c (create_overlay_event_breakpoint)
4498         (create_longjmp_master_breakpoint)
4499         (create_std_terminate_master_breakpoint)
4500         (create_exception_master_breakpoint): Update.
4501         * blockframe.c (find_pc_partial_function): Update.
4502         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
4503         (ada_collect_symbol_completion_matches)
4504         (ada_add_global_exceptions): Update.
4505
4506 2019-01-17  Tom Tromey  <tom@tromey.com>
4507
4508         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
4509         declare VEC.
4510         (solib_target_parse_libraries): Change return type.
4511         (library_list_start_segment, library_list_start_section)
4512         (library_list_end_library, library_list_start_library); Update.
4513         (solib_target_free_library_list): Remove.
4514         (solib_target_parse_libraries): Remove cleanup.  Change return
4515         type.
4516         (solib_target_current_sos): Update.
4517
4518 2019-01-17  Tom Tromey  <tromey@bapiya>
4519
4520         * valprint.c: Replace "the the" with "the".
4521         * symtab.c: Replace "the the" with "the".
4522         * solib.c: Replace "the the" with "the".
4523         * solib-dsbt.c: Replace "the the" with "the".
4524         * linespec.c: Replace "the the" with "the".
4525         * dwarf2loc.h: Replace "the the" with "the".
4526         * amd64-windows-tdep.c: Replace "the the" with "the".
4527         * aarch64-tdep.c: Replace "the the" with "the".
4528
4529 2019-01-16  Keith Seitz  <keiths@redhat.com>
4530
4531         PR gdb/23773
4532         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
4533         <builder>: Rename to ..
4534         <m_builder>: ... this and make private.
4535         (dwarf2_cu::get_builder): New method.  Change all users of
4536         `builder' to use this method.
4537         (dwarf2_start_symtab): Move to ...
4538         (dwarf2_cu::start_symtab): ... here.  Update all callers
4539         (setup_type_unit_groups): Move to ...
4540         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
4541         callers.
4542         (dwarf2_cu::reset_builder): New method.
4543         (process_full_compunit, process_full_type_unit): Use
4544         dwarf2_cu::reset_builder.
4545         (follow_die_offset): Record the ancestor CU if it is different
4546         from the followed DIE's CU.
4547         (follow_die_sig_1): Likewise.
4548
4549 2019-01-15  Tom Tromey  <tom@tromey.com>
4550
4551         * remote.c (class remote_state) <buf>: Now a char_vector.
4552         <buf_size>: Remove.
4553         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
4554         parameter.
4555         (remote_target::getpkt_or_notif_sane_1)
4556         (remote_target::getpkt_sane)
4557         (remote_target::getpkt_or_notif_sane): Likewise.
4558         (class remote_target) <putpkt>: New overload.
4559         (remote_target::read_frame): Change type of "buf_p".  Remove
4560         sizeof_p parameter.
4561         (packet_ok): New overload.
4562         (packet_check_result): New overload.
4563         Update all uses.
4564
4565 2019-01-14  Tom Tromey  <tom@tromey.com>
4566
4567         * remote-notif.c (handle_notification, remote_notif_ack)
4568         (remote_notif_parse): Make "buf" const.
4569         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
4570         const.
4571         (remote_notif_parse, remote_notif_ack, handle_notification):
4572         Likewise.
4573         * remote.c (remote_notif_stop_parse): Make "buf" const.
4574         (remote_target::remote_parse_stop_reply): Make "buf" const.
4575         (remote_notif_stop_ack): Make "buf" const.
4576
4577 2019-01-14  Tom Tromey  <tom@tromey.com>
4578
4579         * remote.c (remote_console_output): Make parameter const.
4580
4581 2019-01-14  Tom Tromey  <tom@tromey.com>
4582
4583         * target-debug.h (target_debug_print_signals): Constify.
4584         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
4585         * procfs.c (procfs_target::pass_signals): Update.
4586         * linux-nat.c (linux_nat_target::pass_signals): Update.
4587         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
4588         * target-delegates.c: Rebuild.
4589         * remote.c (remote_target::program_signals): Update.
4590         (remote_target::pass_signals): Update.
4591         * target.c (target_pass_signals): Constify argument.
4592         (target_program_signals): Likewise.
4593         * target.h (struct target_ops) <pass_signals, program_signals>:
4594         Constify argument.
4595         (target_pass_signals, target_program_signals): Constify argument.
4596
4597 2019-01-14  Tom Tromey  <tom@tromey.com>
4598
4599         PR tui/28819:
4600         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
4601
4602 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
4603
4604         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
4605         field.
4606         * rs6000-tdep.c: Include reggroups.h.
4607         (IS_V_ALIAS_PSEUDOREG): Define.
4608         (rs6000_register_name): Return names for the "vX" aliases.
4609         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
4610         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
4611         aliases.  Call default_register_reggroup_p for all other
4612         pseudo-registers.
4613         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
4614         New functions.
4615         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
4616         Handle "vX" aliases.
4617         (v_alias_pseudo_register_collect): New function.
4618         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
4619         (rs6000_gdbarch_init): Initialize "vX" aliases as
4620         pseudo-registers.  Restore registration of
4621         rs6000_pseudo_register_reggroup_p with
4622         set_tdesc_pseudo_register_reggroup_p.
4623
4624 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
4625
4626         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
4627         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
4628         set_gdbarch_num_pseudo_regs.
4629
4630 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4631
4632         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
4633         Remove arg prefixname, add do_set and do_show.
4634         Add member functions set_list and show_list.
4635         * cli/cli-style.c (class cli_style_option): Update accordingly.
4636         (style_set_list): Move to file scope.
4637         (style_show_list): Likewise.
4638         (set_style): Call help_list.
4639         (show_style): Call cmd_show_list.
4640         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
4641         Update to use the new macro.
4642
4643 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
4644
4645         * ada-lang.c (_initialize_ada_language): Expand the help text
4646         for the "catch exception" command.
4647
4648 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4649
4650         * symtab.c (matching_obj_sections): Initialize obj,
4651         declare it closer to its usage.
4652
4653 2019-01-10  Tom Tromey  <tom@tromey.com>
4654
4655         * thread-iter.h (inf_threads_iterator): Use next_iterator.
4656         (basic_inf_threads_range): Remove.
4657         (inf_threads_range, inf_non_exited_threads_range)
4658         (safe_inf_threads_range): Use next_adapter.
4659
4660 2019-01-10  Keith Seitz  <keiths@redhat.com>
4661
4662         PR gdb/23712
4663         PR symtab/23010
4664         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
4665         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
4666
4667 2019-01-10  Keith Seitz  <keiths@redhat.com>
4668
4669         PR gdb/23712
4670         PR symtab/23010
4671         * dictionary.c (pending_to_vector): Remove.
4672         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4673         Remove _1 suffix, replacing functions of the same name.  Update
4674         all callers.
4675         (dict_create_hashed, dict_create_hashed_expandable)
4676         (dict_create_linear, dict_create_linear_expandable, dict_free)
4677         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
4678         Make functions static.
4679
4680 2019-01-10  Keith Seitz  <keiths@redhat.com>
4681
4682         PR gdb/23712
4683         PR symtab/23010
4684         * dictionary.h (struct dictionary): Replace declaration with
4685         multidictionary.
4686         (dict_create_hashed, dict_create_hashed_expandable)
4687         (dict_create_linear, dict_create_linear_expandable)
4688         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
4689         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
4690         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
4691         taking multidictionary argument.
4692         [ALL_DICT_SYMBOLS]: Update for multidictionary.
4693         * block.h (struct block) <dict>: Change to multidictionary
4694         and rename `multidict'.
4695         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
4696         symmisc.c: Update all dictionary references to multidictionary.
4697
4698 2019-01-10  Keith Seitz  <keiths@redhat.com>
4699
4700         PR gdb/23712
4701         PR symtab/23010
4702         * dictionary.c: Include unordered_map.
4703         (pending_to_vector): New function.
4704         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4705         Rewrite the non-"_1" functions to take vector instead
4706         of linked list.
4707         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
4708         "new" _1 versions of the same name.
4709         (multidictionary): Define.
4710         (std::hash<enum language): New definition.
4711         (collate_pending_symbols_by_language, mdict_create_hashed)
4712         (mdict_create_hashed_expandable, mdict_create_linear)
4713         (mdict_create_linear_expandable, mdict_free)
4714         (find_language_dictionary, create_new_language_dictionary)
4715         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
4716         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
4717         (mdict_size, mdict_empty): New functions.
4718         * dictionary.h (mdict_iterator): Define.
4719
4720 2019-01-10  Pedro Alves  <palves@redhat.com>
4721
4722         * breakpoint.c (read_uploaded_action)
4723         (create_tracepoint_from_upload): Adjust to use
4724         gdb::unique_xmalloc_ptr.
4725         * ctf.c (ctf_write_uploaded_tp):
4726         (SET_ARRAY_FIELD): Use emplace_back.
4727         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
4728         * tracefile-tfile.c (tfile_write_uploaded_tp):
4729         * tracepoint.c (parse_tracepoint_definition): Adjust to use
4730         gdb::unique_xmalloc_ptr.
4731         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
4732         at_string, cond_string, cmd_strings>: Replace char pointers
4733         with gdb::unique_xmalloc_ptr.
4734
4735 2019-01-10  Pedro Alves  <palves@redhat.com>
4736
4737         * solib-target.c (library_list_start_library): Don't xstrdup name.
4738
4739 2019-01-10  Pedro Alves  <palves@redhat.com>
4740
4741         * mdebugread.c (parse_partial_symbols): Use
4742         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
4743
4744 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4745
4746         * linux-fork.c (scoped_switch_fork_info)
4747         <~scoped_switch_fork_info>: Fix incorrect variable name.
4748
4749 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4750
4751         * linux-fork.c (scoped_switch_fork_info)
4752         <scoped_switch_fork_info>: Make explicit.
4753         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
4754
4755 2019-01-10  Tom Tromey  <tom@tromey.com>
4756
4757         * objfiles.h (objfile::reset_psymtabs): Update.
4758         * objfiles.c (objfile::objfile): Update.
4759         * psymtab.h (psymtab_storage::obstack): Update.
4760         (psymtab_storage::m_obstack): Use gdb::optional.
4761         (class psymtab_storage): Update comment.  Remove objfile
4762         parameter.
4763         * psymtab.c (psymtab_storage::psymtab_storage): Update.
4764
4765 2019-01-10  Tom Tromey  <tom@tromey.com>
4766
4767         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
4768         <free_psymtabs>: Now private.
4769         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
4770         (allocate_psymtab): Use new method.
4771
4772 2019-01-10  Tom Tromey  <tom@tromey.com>
4773
4774         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
4775         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
4776         * mdebugread.c (parse_partial_symbols): Use
4777         allocate_dependencies.
4778         * dwarf2read.c (dwarf2_create_include_psymtab): Use
4779         allocate_dependencies.
4780         (process_psymtab_comp_unit_reader)
4781         (build_type_psymtab_dependencies): Likewise.
4782         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
4783
4784 2019-01-10  Tom Tromey  <tom@tromey.com>
4785
4786         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
4787         PSYMBOL_SET_LANGUAGE.
4788         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
4789
4790 2019-01-10  Tom Tromey  <tom@tromey.com>
4791
4792         * psymtab.h (psymtab_storage::obstack): New method.
4793         <m_obstack>: Rename from obstack; now private.
4794         * psymtab.c (psymtab_storage): Update.
4795         * dwarf2read.c (create_addrmap_from_index)
4796         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
4797         Update.
4798
4799 2019-01-10  Tom Tromey  <tom@tromey.com>
4800
4801         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
4802         * objfiles.h (objfile::reset_psymtabs): New method.
4803
4804 2019-01-10  Tom Tromey  <tom@tromey.com>
4805
4806         * symmisc.c (print_symbol_bcache_statistics): Update.
4807         (print_objfile_statistics): Update.
4808         * symfile.c (reread_symbols): Update.
4809         * psymtab.h (class psymtab_storage): New.
4810         * psymtab.c (psymtab_storage): New constructor.
4811         (~psymtab_storage): New destructor.
4812         (require_partial_symbols): Update.
4813         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
4814         (find_pc_sect_psymtab, find_pc_sect_psymbol)
4815         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
4816         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
4817         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
4818         (start_psymtab_common, end_psymtab_common)
4819         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
4820         (allocate_psymtab): Update.
4821         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
4822         Update.
4823         (dump_psymtab_addrmap, maintenance_print_psymbols)
4824         (maintenance_check_psymtabs): Update.
4825         (class objfile_psymtabs): Move to objfiles.h.
4826         * psympriv.h (discard_psymtab): Now inline.
4827         (psymtab_discarder::psymtab_discarder): Update.
4828         (psymtab_discarder::~psymtab_discarder): Update.
4829         (ALL_OBJFILE_PSYMTABS): Rewrite.
4830         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
4831         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
4832         Remove fields.
4833         <partial_symtabs>: New field.
4834         (class objfile_psymtabs): Move from psymtab.h.  Update.
4835         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
4836         psymbol_cache.
4837         (objfile::~objfile): Don't destroy psymbol_cache.
4838         * mdebugread.c (parse_partial_symbols): Update.
4839         * dwarf2read.c (create_addrmap_from_index)
4840         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
4841         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
4842         (add_partial_subprogram, dwarf2_ranges_read): Update.
4843         * dwarf-index-write.c (write_address_map)
4844         (write_one_signatured_type, recursively_write_psymbols)
4845         (class debug_names, class debug_names, write_psymtabs_to_index):
4846         Update.
4847
4848 2019-01-10  Tom Tromey  <tom@tromey.com>
4849
4850         * symtab.h (SYMBOL_SET_NAMES): Update.
4851         (symbol_set_names): Update.
4852         (MSYMBOL_SET_NAMES): Update.
4853         * symtab.c (symbol_set_names): Change argument to be an
4854         objfile_per_bfd_storage.
4855         * psymtab.c (add_psymbol_to_bcache): Update.
4856         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
4857
4858 2019-01-10  Tom Tromey  <tom@tromey.com>
4859
4860         * symtab.c (create_demangled_names_hash): Change argument to be an
4861         objfile_per_bfd_storage.
4862         (symbol_set_names): Update.
4863
4864 2019-01-10  Tom Tromey  <tom@tromey.com>
4865
4866         * xcoffread.c (xcoff_initial_scan): Unconditionally call
4867         init_psymbol_list.
4868         * psymtab.c (init_psymbol_list): Do nothing if already called.
4869         * psympriv.h (init_psymbol_list): Add comment.
4870         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
4871         init_psymbol_list.
4872         * dbxread.c (dbx_symfile_read): Unconditionally call
4873         init_psymbol_list.
4874
4875 2019-01-10  Tom Tromey  <tom@tromey.com>
4876
4877         * xcoffread.c (scan_xcoff_symtab): Update.
4878         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
4879         "where".
4880         * mdebugread.c (parse_partial_symbols)
4881         (handle_psymbol_enumerators): Update.
4882         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
4883         * dbxread.c (read_dbx_symtab): Update.
4884         * psympriv.h (psymbol_placement): New enum.
4885         (add_psymbol_to_list): Update.
4886
4887 2019-01-10  Tom Tromey  <tom@tromey.com>
4888
4889         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
4890         static_psymbols parameters.
4891         (scan_xcoff_symtab): Update.
4892         * psymtab.c (start_psymtab_common): Remove global_psymbols and
4893         static_psymbols parameters.
4894         * psympriv.h (start_psymtab_common): Update.
4895         * mdebugread.c (parse_partial_symbols): Update.
4896         * dwarf2read.c (create_partial_symtab): Update.
4897         * dbxread.c (read_dbx_symtab): Update.
4898         (start_psymtab): Remove global_psymbols and static_psymbols
4899         parameters.
4900
4901 2019-01-10  Tom Tromey  <tom@tromey.com>
4902
4903         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
4904         * psymtab.c (allocate_psymtab): Add comment.
4905         * psympriv.h (allocate_psymtab): Add comment.
4906         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
4907         initializations.
4908         * dbxread.c (dbx_end_psymtab): Remove some initializations.
4909
4910 2019-01-10  Tom Tromey  <tom@tromey.com>
4911
4912         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
4913         Don't declare.
4914         * mipsread.c: Include mdebugread.h.
4915         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
4916         Declare.
4917         * elfread.c: Include mdebugread.h.
4918
4919 2019-01-09  Tom Tromey  <tom@tromey.com>
4920
4921         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
4922         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
4923         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
4924         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
4925         (psym_lookup_symbol, psym_find_last_source_symtab)
4926         (psym_forget_cached_source_info, psym_print_stats)
4927         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
4928         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
4929         (psym_map_matching_symbols, psym_expand_symtabs_matching)
4930         (psym_find_compunit_symtab_by_address)
4931         (maintenance_print_psymbols, maintenance_info_psymtabs)
4932         (maintenance_check_psymtabs): Use ranged for.
4933         * psymtab.h (class objfile_psymtabs): New.
4934         (require_partial_symbols): Return objfile_psymtabs.
4935         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
4936
4937 2019-01-09  Tom Tromey  <tom@tromey.com>
4938
4939         * symfile.c (overlay_invalidate_all, find_pc_overlay)
4940         (find_pc_mapped_section, list_overlays_command)
4941         (map_overlay_command, unmap_overlay_command)
4942         (simple_overlay_update): Use all_objfiles.
4943         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
4944         * printcmd.c (info_symbol_command): Use all_objfiles.
4945         * objfiles.h (ALL_OBJSECTIONS): Remove.
4946         * maint.c (maintenance_translate_address): Use all_objfiles.
4947         * gcore.c (gcore_create_callback): Use all_objfiles.
4948         (objfile_find_memory_regions): Likewise.
4949
4950 2019-01-09  Tom Tromey  <tom@tromey.com>
4951
4952         * symtab.c (find_line_symtab, info_sources_command)
4953         (make_source_files_completion_list): Use objfile_compunits.
4954         * source.c (select_source_symtab): Use objfile_compunits.
4955         * objfiles.h (struct objfile): Update comment.
4956         (ALL_OBJFILES): Remove.
4957         (ALL_FILETABS): Remove.
4958         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
4959         objfile_compunits.
4960
4961 2019-01-09  Tom Tromey  <tom@tromey.com>
4962
4963         * symmisc.c (print_objfile_statistics, dump_objfile)
4964         (maintenance_print_symbols): Use compunit_filetabs.
4965         * source.c (forget_cached_source_info_for_objfile): Use
4966         compunit_filetabs.
4967         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
4968         (ALL_FILETABS): Use compunit_filetabs.
4969         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
4970         * coffread.c (coff_symtab_read): Use compunit_filetabs.
4971
4972 2019-01-09  Tom Tromey  <tom@tromey.com>
4973
4974         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
4975         (compunit_filetabs): New.
4976         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
4977         compunit_filetabs.
4978         (info_sources_command, make_source_files_completion_list): Remove
4979         declaration.
4980         * symmisc.c (print_objfile_statistics, dump_objfile)
4981         (maintenance_print_symbols): Remove declaration.
4982         (maintenance_info_symtabs): Use compunit_filetabs.
4983         (maintenance_info_line_tables): Likewise.
4984         * source.c (select_source_symtab): Change local variable name.
4985         (forget_cached_source_info_for_objfile): Remove declaration.
4986         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
4987         * objfiles.c (objfile_relocate1): Remove declaration.
4988         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
4989         declaration.
4990         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
4991         * coffread.c (coff_symtab_read): Remove declaration.
4992         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
4993         compunit_filetabs.
4994
4995 2019-01-09  Tom Tromey  <tom@tromey.com>
4996
4997         * symtab.c (lookup_objfile_from_block)
4998         (find_pc_sect_compunit_symtab, search_symbols)
4999         (default_collect_symbol_completion_matches_break_on): Use
5000         objfile_compunits.
5001         * objfiles.h (ALL_COMPUNITS): Remove.
5002         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
5003         * cp-support.c (add_symbol_overload_list_qualified): Use
5004         objfile_compunits.
5005         * ada-lang.c (ada_collect_symbol_completion_matches)
5006         (ada_add_global_exceptions): Use objfile_compunits.
5007
5008 2019-01-09  Tom Tromey  <tom@tromey.com>
5009
5010         * source.c (select_source_symtab)
5011         (forget_cached_source_info_for_objfile): Remove declaration.
5012         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5013         declaration.
5014         * maint.c (count_symtabs_and_blocks): Remove declaration.
5015         * cp-support.c (add_symbol_overload_list_qualified): Remove
5016         declaration.
5017         * coffread.c (coff_symtab_read): Remove declaration.
5018         * symtab.c (lookup_symbol_in_objfile_symtabs)
5019         (basic_lookup_transparent_type_1): Use objfile_compunits.
5020         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
5021         (info_sources_command, search_symbols)
5022         (default_collect_symbol_completion_matches_break_on)
5023         (make_source_files_completion_list): Remove declaration.
5024         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
5025         (ada_collect_symbol_completion_matches)
5026         (ada_add_global_exceptions): Remove declaration.
5027         * linespec.c (iterate_over_all_matching_symtabs): Use
5028         objfile_compunits.
5029         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
5030         (class objfile_compunits): New.
5031         (ALL_COMPUNITS): Use objfile_compunits.
5032         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
5033         (maintenance_check_symtabs, maintenance_info_line_tables): Use
5034         objfile_compunits.
5035         * objfiles.c (objfile_relocate1): Use objfile_compunits.
5036
5037 2019-01-09  Tom Tromey  <tom@tromey.com>
5038
5039         * symtab.c (search_symbols)
5040         (default_collect_symbol_completion_matches_break_on): Use
5041         objfile_msymbols.
5042         * ada-lang.c (ada_lookup_simple_minsym)
5043         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
5044         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
5045         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
5046         objfile_msymbols.
5047         * coffread.c (coff_symfile_read): Use objfile_msymbols.
5048         * symmisc.c (dump_msymbols): Use objfile_msymbols.
5049         * objc-lang.c (find_methods): Use objfile_msymbols.
5050         (info_selectors_command, info_classes_command): Likewise.
5051         * stabsread.c (scan_file_globals): Use objfile_msymbols.
5052         * objfiles.h (class objfile_msymbols): New.
5053         (ALL_OBJFILE_MSYMBOLS): Remove.
5054         (ALL_MSYMBOLS): Remove.
5055
5056 2019-01-09  Tom Tromey  <tom@tromey.com>
5057
5058         * common/next-iterator.h (next_adapter): Add Iterator template
5059         parameter.
5060         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
5061         (class all_objfiles_safe): New.
5062         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
5063         * objfiles.c (put_objfile_before): Update comment.
5064         (add_separate_debug_objfile): Likewise.
5065         (free_all_objfiles): Use all_objfiles_safe.
5066         (objfile_purge_solibs): Likewise.
5067
5068 2019-01-09  Tom Tromey  <tom@tromey.com>
5069
5070         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5071         (expand_symtab_containing_pc, lookup_static_symbol)
5072         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
5073         (find_symbol_at_address, find_line_symtab, find_main_name): Use
5074         all_objfiles.
5075         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
5076         * breakpoint.c (create_overlay_event_breakpoint)
5077         (create_longjmp_master_breakpoint)
5078         (create_std_terminate_master_breakpoint)
5079         (create_exception_master_breakpoint): Use all_objfiles.
5080         * linux-thread-db.c (try_thread_db_load_from_pdir)
5081         (has_libpthread): Use all_objfiles.
5082         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
5083         * linespec.c (iterate_over_all_matching_symtabs)
5084         (search_minsyms_for_name): Use all_objfiles.
5085         * maint.c (maintenance_info_sections): Use all_objfiles.
5086         * main.c (captured_main_1): Use all_objfiles.
5087         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
5088         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
5089         * guile/scm-pretty-print.c
5090         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
5091         * solib-spu.c (append_ocl_sos): Use all_objfiles.
5092         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
5093         (maintenance_print_msymbols): Use all_objfiles.
5094         * source.c (select_source_symtab): Use all_objfiles.
5095         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
5096         * symfile.c (remove_symbol_file_command)
5097         (expand_symtabs_matching, map_symbol_filenames): Use
5098         all_objfiles.
5099         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
5100         all_objfiles.
5101         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
5102         * objc-lang.c (find_methods): Use all_objfiles.
5103         * objfiles.c (have_partial_symbols, have_full_symbols)
5104         (have_minimal_symbols, qsort_cmp)
5105         (default_iterate_over_objfiles_in_search_order): Use
5106         all_objfiles.
5107         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
5108         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
5109         (maintenance_check_psymtabs): Use all_objfiles.
5110         (ALL_PSYMTABS): Remove.
5111         * compile/compile-object-run.c (do_module_cleanup): Use
5112         all_objfiles.
5113         * blockframe.c (find_pc_partial_function): Use all_objfiles.
5114         * cp-support.c (add_symbol_overload_list_qualified): Use
5115         all_objfiles.
5116         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5117         Use all_objfiles.
5118         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
5119         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
5120         all_objfiles.
5121         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5122         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
5123         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5124         Uses all_objfiles.
5125         * solib.c (solib_read_symbols): Use all_objfiles
5126
5127 2019-01-09  Tom Tromey  <tom@tromey.com>
5128
5129         * probe.c (parse_probes_in_pspace): Use all_objfiles.
5130         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
5131         all_objfiles.
5132         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
5133         * symmisc.c (print_symbol_bcache_statistics)
5134         (print_objfile_statistics, maintenance_print_objfiles)
5135         (maintenance_info_symtabs, maintenance_check_symtabs)
5136         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
5137         all_objfiles.
5138         * source.c (forget_cached_source_info): Use all_objfiles.
5139         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
5140         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5141         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
5142         * objfiles.c (update_section_map): Use all_objfiles.
5143         (shared_objfile_contains_address_p): Likewise.
5144         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
5145         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
5146
5147 2019-01-09  Tom Tromey  <tom@tromey.com>
5148
5149         * common/next-iterator.h: New file.
5150         * objfiles.h (class all_objfiles): New.
5151         (struct objfile_iterator): New.
5152
5153 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5154
5155         * NEWS: Move the description of the changed "frame", "select-frame",
5156          and "info frame" commands to the Changed commands section.
5157
5158 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
5159
5160         * gdbtypes.c (check_stub_method_group): Remove handling of old
5161         mangling schemes.
5162         * linespec.c (find_methods): Likewise.
5163         * stabsread.c (read_member_functions): Likewise.
5164         * valops.c (search_struct_method): Likewise.
5165         (value_struct_elt_for_reference): Likewise.
5166         * NEWS: Mention this change.
5167
5168 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5169
5170         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
5171         print_source_lines.
5172         * source.c (print_source_lines_base): Update line number check.
5173         (print_source_lines): New function.
5174         (source_lines_range::source_lines_range): New function.
5175         * source.h (class source_lines_range): New class.
5176         (print_source_lines): New declaration.
5177
5178 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5179
5180         * linespec.c (linespec_state_destructor): Free self->canonical_names.
5181
5182 2019-01-08  Tom Tromey  <tom@tromey.com>
5183             Simon Marchi  <simon.marchi@ericsson.com>
5184
5185         PR gdb/24060
5186         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
5187         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
5188         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5189         * f-exp.y (DOLLAR_VARIABLE): Likewise.
5190         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
5191         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5192
5193 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5194
5195         * source.c (select_source_symtab): Move header comment to
5196         declaration in source.h.
5197         (forget_cached_source_info_for_objfile): Likewise.
5198         (forget_cached_source_info): Likewise.
5199         (identify_source_line): Likewise.
5200         * source.h (identify_source_line): Move declaration from symtab.h
5201         and add comment from source.c
5202         (print_source_lines): Likewise.
5203         (forget_cached_source_info_for_objfile): Likewise.
5204         (forget_cached_source_info): Likewise.
5205         (select_source_symtab): Likewise.
5206         (enum print_source_lines_flag): Move definition from symtab.h.
5207         * symtab.h (identify_source_line): Move declaration to source.h.
5208         (print_source_lines): Likewise.
5209         (forget_cached_source_info_for_objfile): Likewise.
5210         (forget_cached_source_info): Likewise.
5211         (select_source_symtab): Likewise.
5212         (enum print_source_lines_flag): Move definition to source.h.
5213         * tui/tui-hooks.c: Add 'source.h' include.
5214
5215 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5216
5217         * source.c (print_source_lines_base): Handle requests to print
5218         reverse line number sequences, and guard against empty lines
5219         string.
5220
5221 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5222
5223         * source.c (print_source_lines_base): Fix skip of '\r' if next
5224         character is '\n'.
5225
5226 2019-01-06  Tom Tromey  <tom@tromey.com>
5227
5228         * c-exp.y (struct c_parse_state) <macro_original_text,
5229         expansion_obstack>: New member.
5230         (macro_original_text, expansion_obstack): Remove globals.
5231         (scan_macro_expansion, scanning_macro_expansion)
5232         (finished_macro_expansion): Update.
5233         (scan_macro_cleanup): Remove.
5234         (yylex, c_parse): Update.
5235
5236 2019-01-06  Tom Tromey  <tom@tromey.com>
5237
5238         * c-exp.y (struct c_parse_state) <strings>: New member.
5239         (operator_stoken): Update.
5240
5241 2019-01-06  Tom Tromey  <tom@tromey.com>
5242
5243         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
5244         (union type_stack_elt) <typelist_val>: Now a pointer to
5245         std::vector.
5246         (type_stack_cleanup): Don't declare.
5247         (push_typelist): Update.
5248         * parse.c (pop_typelist): Return a std::vector.
5249         (push_typelist): Take a std::vector.
5250         (follow_types): Update.  Do not free args.
5251         (type_stack_cleanup): Remove.
5252         * c-exp.y (struct c_parse_state): New.
5253         (cpstate): New global.
5254         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
5255         (nonempty_typelist): Update.
5256         (func_mod): Create a new vector.
5257         (c_parse): Create a c_parse_state.
5258         (check_parameter_typelist): Do not delete params.
5259         (function_method): Update.  Do not delete type_list.
5260
5261 2019-01-06  Tom Tromey  <tom@tromey.com>
5262
5263         PR gdb/28155:
5264         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
5265         check_typedef.
5266         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
5267         (print_return_value): Likewise.
5268
5269 2019-01-05  Tom Tromey  <tom@tromey.com>
5270
5271         * contrib/cleanup_check.py: Remove.
5272         * contrib/gcc-with-excheck: Remove.
5273         * contrib/exsummary.py: Remove.
5274         * contrib/excheck.py: Remove.
5275
5276 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
5277
5278         * thread.c (delete_thread_1): Add gdb_assert that THR is not
5279         NULL. Initialize tpprev to NULL instead of assigning it
5280         to NULL on the next statement.
5281         * windows-nat.c (windows_delete_thread): Remove check for
5282         main_thread_id before printing thread exit notifications.
5283         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
5284         Remove thread ID check against main_thread_id.
5285         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
5286         windows_delete_thread.
5287         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
5288
5289 2019-01-04  Tom Tromey  <tom@tromey.com>
5290
5291         * compile/compile.c (_initialize_compile): Use upper case for
5292         metasyntactic variables.
5293         * symmisc.c (_initialize_symmisc): Use upper case for
5294         metasyntactic variables.
5295         * psymtab.c (_initialize_psymtab): Use upper case for
5296         metasyntactic variables.
5297         * demangle.c (demangle_command): Use upper case for metasyntactic
5298         variables.
5299         (_initialize_demangler): Likewise.
5300         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
5301         variables.
5302
5303 2019-01-03  Tom Tromey  <tom@tromey.com>
5304
5305         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
5306
5307 2019-01-03  Tom Tromey  <tom@tromey.com>
5308
5309         * python/py-symtab.c (salpy_str): Update.
5310         (struct salpy_sal_object) <symtab>: Now a PyObject.
5311         (salpy_dealloc): Update.
5312         (del_objfile_sal): Use gdbpy_ref.
5313
5314 2019-01-03  Tom Tromey  <tom@tromey.com>
5315
5316         * python/py-type.c (convert_field): Use new_reference.  Return
5317         gdbpy_ref.
5318         (make_fielditem): Return gdbpy_ref.
5319         (typy_fields): Update.
5320         (typy_getitem): Update.
5321         (field_name): Return gdbpy_ref.  Use new_reference.
5322         (typy_iterator_iternext): Update.
5323
5324 2019-01-03  Tom Tromey  <tom@tromey.com>
5325
5326         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
5327
5328 2019-01-03  Tom Tromey  <tom@tromey.com>
5329
5330         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
5331         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
5332         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
5333         (pspy_set_frame_filters, pspy_set_frame_unwinders)
5334         (pspy_set_type_printers): Likewise.
5335         * python/py-function.c (fnpy_init): Use gdbpy_ref.
5336         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
5337         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
5338         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
5339         (objfpy_set_type_printers): Likewise.
5340
5341 2019-01-03  Tom Tromey  <tom@tromey.com>
5342
5343         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
5344         (gdbpy_print_stack): Use gdbpy_err_fetch.
5345         * python/python-internal.h (class gdbpy_err_fetch): New class.
5346         (class gdbpy_enter) <m_error_type, m_error_value,
5347         m_error_traceback>: Remove.
5348         <m_error>: New member.
5349         (gdbpy_exception_to_string): Don't declare.
5350         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
5351         * python/py-value.c (convert_value_from_python): Use
5352         gdbpy_err_fetch.
5353         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
5354         gdbpy_exception_to_string.
5355         (gdbpy_handle_exception): Use gdbpy_err_fetch.
5356         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
5357         gdbpy_err_fetch.
5358
5359 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5360
5361         * linux-nat.c (delete_lwp_cleanup): Delete.
5362         (struct lwp_deleter): New struct.
5363         (lwp_info_up): New typedef.
5364         (linux_nat_target::follow_fork): Delete cleanup, and make use of
5365         lwp_info_up.
5366
5367 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5368
5369         * linux-fork.c (class scoped_switch_fork_info): New class.
5370         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
5371
5372 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5373
5374         * valops.c (find_overload_match): Remove use of null_cleanup, and
5375         calls to do_cleanups.
5376
5377 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5378
5379         * compile/compile-cplus-types.c
5380         (compile_cplus_instance::decl_name): Handle changes to
5381         cp_func_name.
5382         * cp-support.c (cp_func_name): Update header comment, update
5383         return type.
5384         * cp-support.h (cp_func_name): Update return type in declaration.
5385         * valops.c (find_overload_match): Move temp_func local to top
5386         level of function and change its type.  Use temp_func to hold and
5387         delete temporary string obtained from cp_func_name.
5388
5389 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5390
5391         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
5392         gdb::char_vector, remove cleanup, and update uses of `msg`.
5393
5394 2019-01-03  Jim Wilson  <jimw@sifive.com>
5395
5396         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
5397
5398 2019-01-02  Tom Tromey  <tom@tromey.com>
5399
5400         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
5401         (tdesc_parse_xml): Remove cleanups.
5402         * target-descriptions.h (make_cleanup_free_target_description):
5403         Don't declare.
5404         (target_desc_deleter): New struct.
5405         (target_desc_up): New typedef.
5406         * target-descriptions.c (target_desc_deleter::operator()): Rename
5407         from free_target_description.
5408         (make_cleanup_free_target_description): Remove.
5409
5410 2019-01-02  Tom Tromey  <tom@tromey.com>
5411
5412         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
5413         constructor, destructor.
5414         (linespec_parser): Remove typedef.
5415         (~linespec_parser): Rename from linespec_parser_delete.
5416         (linespec_lex_to_end, linespec_complete_label)
5417         (linespec_complete): Update.
5418         (decode_line_full): Remove cleanups.
5419         (decode_line_1): Update.
5420
5421 2019-01-02  Tom Tromey  <tom@tromey.com>
5422
5423         * python/python-internal.h (inferior_to_inferior_object): Change
5424         return type.
5425         * python/py-exitedevent.c (create_exited_event_object): Update.
5426         * python/py-inferior.c (inferior_to_inferior_object): Return
5427         gdbpy_ref.
5428         (python_new_inferior, python_inferior_deleted)
5429         (thread_to_thread_object, delete_thread_object)
5430         (build_inferior_list, gdbpy_selected_inferior): Update.
5431         * python/py-infthread.c (create_thread_object): Update.  Also fail
5432         if inferior_to_inferior_object fails.
5433
5434 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
5435
5436         * inferior.h (class inferior) <displaced_step_state>: New field.
5437         * infrun.h (struct displaced_step_state): Move here from
5438         infrun.c.  Initialize fields, add constructor.
5439         <inf>: Remove field.
5440         <reset>: New method.
5441         * infrun.c (struct displaced_step_inferior_state): Move to
5442         infrun.h.
5443         (displaced_step_inferior_states): Remove.
5444         (get_displaced_stepping_state): Adust.
5445         (displaced_step_in_progress_any_inferior): Adjust.
5446         (displaced_step_in_progress_thread): Adjust.
5447         (displaced_step_in_progress): Adjust.
5448         (add_displaced_stepping_state): Remove.
5449         (get_displaced_step_closure_by_addr): Adjust.
5450         (remove_displaced_stepping_state): Remove.
5451         (infrun_inferior_exit): Call displaced_step_state.reset.
5452         (use_displaced_stepping): Don't check for NULL.
5453         (displaced_step_prepare_throw): Call
5454         get_displaced_stepping_state.
5455         (displaced_step_fixup): Don't check for NULL.
5456         (prepare_for_detach): Don't check for NULL.
5457
5458 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5459
5460         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
5461          in case of call that did not complete.
5462
5463 2019-01-02  Andrey Utkin  <autkin@undo.io>
5464
5465         * symfile.c (find_separate_debug_file): Fix search of debug files for
5466         remote debuggee.
5467
5468 2019-01-02  Tom Tromey  <tom@tromey.com>
5469
5470         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
5471         indentation.
5472         * python/py-frame.c (frapy_older): Remove cast.
5473         (frapy_newer): Likewise.
5474         * python/py-breakpoint.c (local_setattro): Remove cast.
5475         * python/py-arch.c (archpy_name): Remove local variable.
5476         * python/py-type.c (gdbpy_lookup_type): Remove cast.
5477
5478 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
5479
5480         * unittests/basic_string_view/element_access/char/empty.cc:
5481         Fix year range in copyright header.
5482
5483 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5484
5485         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
5486         Delete.
5487         <operator==>: Update with for removed field.
5488         <hash>: Likewise.
5489         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
5490         <isa_features>: ...this.
5491         <abi_features>: New field.
5492         (riscv_isa_flen): Update comment.
5493         (riscv_abi_xlen): New declaration.
5494         (riscv_abi_flen): New declaration.
5495         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
5496         isa_features.
5497         (riscv_abi_xlen): New function.
5498         (riscv_isa_flen): Update to get answer from isa_features.
5499         (riscv_abi_flen): New function.
5500         (riscv_has_fp_abi): Update to get answer from abi_features.
5501         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
5502         xlen and flen.
5503         (riscv_call_info) <xlen, flen>: Update comment.
5504         (riscv_call_arg_struct): Remove invalid assertions
5505         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
5506         is removed.
5507         (riscv_gdbarch_init): Gather isa features and abi features
5508         separately, ensure both match on the gdbarch when reusing an old
5509         gdbarch.  Relax an error check to allow 32-bit abi float to run on
5510         a target with 64-bit float hardware.
5511
5512 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5513
5514         * source.c (search_command_helper): Stop reverse search
5515         when line 1 has been searched.
5516
5517 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5518
5519         * record-full.c (record_full_base_target::close): Rewrite
5520         record_full_core_buf_list free logic.
5521
5522 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5523
5524         * break-catch-syscall.c (print_one_catch_syscall): xfree
5525         the last text.
5526
5527 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5528
5529         * top.c (print_gdb_version): Update Copyright year in version
5530         message.
5531
5532 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5533
5534         Update copyright year range in all GDB files.
5535
5536 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
5537
5538         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
5539
5540 For older changes see ChangeLog-2018.
5541 \f
5542 Local Variables:
5543 mode: change-log
5544 left-margin: 8
5545 fill-column: 74
5546 version-control: never
5547 coding: utf-8
5548 End:
5549