1 2009-03-23 Joel Brobecker <brobecker@adacore.com>
3 * ada-lang.c (ada_get_field_index): Add handling of the case
4 when TYPE is a typedef of a struct.
6 2009-03-23 Joel Brobecker <brobecker@adacore.com>
8 Add gdb_usleep as a portable version of sleep based on gdb_select.
9 * gdb_usleep.h, gdb_usleep.c: New files.
10 * Makefile.in (SFILES): Add gdb_usleep.c.
11 (HFILES_NO_SRCDIR): Add gdb_usleep.h.
12 (COMMON_OBS): Add gdb_usleep.o.
13 * ser-unix.c (hardwire_send_break): Replace call to gdb_select
14 by call to gdb_usleep.
16 2009-03-23 Joel Brobecker <brobecker@adacore.com>
18 * buildsym.c (end_symtab): If we ignore the subfiles, then
19 unlink the associated symtabs if they were already allocated.
21 2009-03-23 Jerome Guitton <guitton@adacore.com>
23 Provide a way to force building of GDB with libcurses.
24 * configure.ac: Add --with-curses.
25 * configure: Regenerated.
27 2009-03-23 Tom Tromey <tromey@redhat.com>
29 * dwarf2expr.c (execute_stack_op) <DW_OP_GNU_uninit>: Fix typo in
32 2009-03-23 Paul Pluzhnikov <ppluzhnikov@google.com>
34 * breakpoint.c (disable_breakpoints_in_unloaded_shlib): Use
35 solib_contains_address_p instead of searching.
37 2009-03-23 Tom Tromey <tromey@redhat.com>
39 * charset.c (ICONV_CONST) <PHONY_ICONV>: Define.
40 (iconv): Make 'inbuf' argument const.
41 (convert_between_encodings): Use ICONV_CONST.
42 (wchar_iterate): Likewise.
44 2009-03-22 Christopher Faylor <me+cygwin@cgf.cx>
46 * windows-nat.c (AdjustTokenPrivileges): Implement macro wraparound for
47 dynamically loaded function.
48 (LookupPrivilegeValueA): Ditto.
49 (OpenProcessToken): Ditto.
50 (AdjustTokenPrivileges): Rename and define placeholder for address of
51 dynamically loaded function.
52 (LookupPrivilegeValueA): Ditto.
53 (OpenProcessToken): Ditto.
54 (set_process_privilege): Remove check for loaded functions.
55 (bad_OpenProcessToken): Define.
56 (_initialize_loadable): Load token functions from advapi here, setting
57 OpenProcessToken function to a dummy static function which always return
58 error if OS doesn't support this functionality.
60 2009-03-22 Nicolas Roche <roche@adacore.com>
61 Christopher Faylor <me+cygwin@cgf.cx>
63 * win32-nat.c (ctrl_c_handler): New function.
64 (win32_wait): Register ctrl_c_handler as Ctrl-C handler if the inferior
65 is run in a separate console.
67 2009-03-22 Christopher Faylor <me+cygwin@cgf.cx>
69 * windows-nat.c (DebugActiveProcessStop): Implement macro wraparound
70 for dynamically loaded function.
71 (DebugBreakProcess): Ditto.
72 (DebugSetProcessKillOnExit): Ditto.
73 (EnumProcessModules): Ditto.
74 (GetModuleFileNameExA): Ditto.
75 (GetModuleInformation): Ditto.
76 (DebugActiveProcessStop): Rename and define placeholder for address of
77 dynamically loaded function.
78 (DebugBreakProcess): Ditto.
79 (DebugSetProcessKillOnExit): Ditto.
80 (EnumProcessModules): Ditto.
81 (GetModuleFileNameExA): Ditto.
82 (GetModuleInformation): Ditto.
83 (psapi_loaded): Delete.
84 (get_module_name): Don't check psapi_loaded, just rely on the fact that
85 dynamically loaded functions will return failure if they weren't
87 (has_detach_ability): Delete.
88 (windows_attach): Remove call to has_detach_ability (). Just rely on
89 functions being callable.
90 (bad_DebugActiveProcessStop): Define.
91 (bad_DebugBreakProcess): Ditto.
92 (bad_DebugSetProcessKillOnExit): Ditto.
93 (bad_EnumProcessModules): Ditto.
94 (bad_GetModuleFileNameExA): Ditto.
95 (bad_GetModuleInformation): Ditto.
96 (_initialize_loadable): Rename from _initialize_psapi. Initialize all
97 dynamic storage here, setting nonexistent functions to dummy static
98 functions which always return error.
100 2009-03-22 Pedro Alves <pedro@codesourcery.com>
102 * mi/mi-interp.c (mi_interpreter_init): Attach mi_about_to_proceed
103 to the about_to_proceed observer notification.
104 (mi_about_to_proceed): New.
105 (mi_on_resume): Only output ^running and the prompt here if the
106 target was proceeded.
107 * breakpoint.c (breakpoint_proceeded): New static.
108 (breakpoint_about_to_proceed): New.
109 (_initialize_breakpoints): Attach breakpoint_about_to_proceed to
110 the about_to_proceed observer notification.
111 * inferior.h (breakpoint_proceeded): Delete declaration.
112 * infrun.c (clear_proceed_status): Don't set breakpoint_proceeded.
113 Notify the about_to_proceed observers.
114 (struct inferior_status): Delete breakpoint_proceeded member.
115 (save_inferior_status): Don't save it.
116 (restore_inferior_status): Don't restore it.
117 * mi-main.h (mi_proceeded): Declare.
118 * mi/mi-main.c (mi_cmd_execute): Clear mi_proceeded before running
121 2009-03-22 Pedro Alves <pedro@codesourcery.com>
123 * gdbthread.h (struct thread_info): Add in_infcall member.
124 * infcall.c (run_inferior_call): Save, set and restore in_infcall.
125 Remove reverences to suppress_resume_observer. Refresh
126 `call_thread' after returning from `proceed'.
127 * infcmd.c (suppress_resume_observer): Delete.
128 * inferior.h (suppress_resume_observer): Delete declaration.
129 * mi/mi-interp.c (mi_on_resume): Suppress output while calling an
131 * thread.c (set_running): Remove references to
132 suppress_resume_observer.
133 * infrun.c (struct inferior_status): Add in_infcall member.
134 (save_inferior_status): Save it.
135 (restore_inferior_status): Restore it.
137 2009-03-22 Pedro Alves <pedro@codesourcery.com>
139 * infcall.c (run_inferior_call): Remove references to
140 suppress_stop_observer.
141 * infcmd.c (suppress_stop_observer): Delete.
142 (finish_command_continuation): Remove NOTE. Don't clear
143 suppress_stop_observer anymore.
144 (finish_command_continuation_free_arg): Likewise.
145 (finish_forward): Remove references to suppress_stop_observer.
146 Call normal_stop observer if we haven't already.
147 * inferior.h (suppress_stop_observer): Delete.
148 * infrun.c (normal_stop): When deciding to suppress the
149 normal_stop observer, check for proceed_to_finish instead of
150 suppress_stop_observer.
152 2009-03-22 Pedro Alves <pedro@codesourcery.com>
154 * symfile.c (symfile_relocate_debug_section): Remove check for
157 2009-03-21 Jan Kratochvil <jan.kratochvil@redhat.com>
158 Jim Blandy <jimb@red-bean.com>
159 Thiago Jung Bauermann <bauerman@br.ibm.com>
160 Tom Tromey <tromey@redhat.com>
162 Miscellaneous fixes to the Python code.
163 * python/python-cmd.c (cmdpy_init): Accept keyword
165 * python/python-value.c (valpy_string): Accept keyword
167 (valpy_binop): Use `break' to exit from the TRY_CATCH block.
168 Do not call value_to_value_object on NULL RES_VAL.
169 (value_object_methods): Change `string' entry to also accept
171 (convert_value_from_python): Return a copy of the value if obj is
173 (value_object_methods): Mark the `string' method as accepting
174 keywords, and show method "prototype" in the doc string.
175 * python/python.c (get_parameter): Don't return inside a
178 2009-03-20 Tom Tromey <tromey@redhat.com>
180 Add support for convenience functions in Python.
181 * Makefile.in (SUBDIR_PYTHON_OBS): Add python-function.o.
182 (SUBDIR_PYTHON_SRCS): Add python-function.c.
183 (python-function.o): New target.
184 * eval.c: Include "python/python.h" and <ctype.h>.
185 (evaluate_subexp_standard): Handle values of type
186 TYPE_CODE_INTERNAL_FUNCTION.
187 * gdbtypes.h (type_code): Add TYPE_CODE_INTERNAL_FUNCTION.
188 * parse.c (write_exp_string): Remove duplicate word in comment.
189 * python/python-function.c: New file.
190 * python/python-internal.h (gdbpy_initialize_functions): Add
192 * python/python.c (_initialize_python): Call
193 gdbpy_initialize_functions.
194 * valprint.c (value_check_printable): Handle values of type
195 TYPE_CODE_INTERNAL_FUNCTION.
196 * value.c: Include "cli/cli-decode.h".
197 (internal_function): New struct.
198 (functionlist, internal_fn_type): New static variables.
199 (lookup_only_internalvar,
200 lookup_internalvar): Add const qualifier to name argument.
201 (create_internalvar): Likewise. Initialize new field.
202 (set_internal_var): Fix typo in comment. Don't allow assignment
203 to canonical variable.
204 (value_create_internal_function, value_internal_function_name,
205 call_internal_function, function_command, function_destroyer,
206 add_internal_function): New functions.
207 (_initialize_values): Create `function' placeholder command.
208 Initialize internal_fn_type.
209 * value.h (lookup_only_internalvar, create_internalvar,
210 lookup_internalvar): Add const qualifier to name argument.
211 (internal_function_fn, add_internal_function, call_internal_function,
212 value_internal_function_name): Add prototypes.
213 (struct internalvar) <canonical>: New field.
215 2009-03-20 Tom Tromey <tromey@redhat.com>
217 * c-lang.c (evaluate_subexp_c): Call check_typedef.
219 2009-03-20 Tom Tromey <tromey@redhat.com>
220 Julian Brown <julian@codesourcery.com>
222 PR i18n/7220, PR i18n/7821, PR exp/8815, PR exp/9103,
223 PR i18n/9401, PR exp/9613:
225 * value.h (value_typed_string): Declare.
226 (val_print_string): Update.
227 * valprint.h (print_char_chars): Update.
228 * valprint.c (print_char_chars): Add type argument. Update.
229 (val_print_string): Likewise.
230 * valops.c (value_typed_string): New function.
231 * utils.c (host_char_to_target): New function.
232 (parse_escape): Use host_char_to_target, host_hex_value. Update.
234 (no_control_char_error): Remove.
235 * typeprint.c (print_type_scalar): Update.
236 * scm-valprint.c (scm_scmval_print): Update.
237 * scm-lang.h (scm_printchar, scm_printstr): Update.
238 * scm-lang.c (scm_printchar): Add type argument.
239 (scm_printstr): Likewise.
240 * printcmd.c (print_formatted): Update.
241 (print_scalar_formatted): Update.
242 (printf_command) <wide_string_arg, wide_char_arg>: New constants.
243 Handle '%lc' and '%ls'.
244 * parser-defs.h (struct typed_stoken): New type.
245 (struct stoken_vector): Likewise.
246 (write_exp_string_vector): Declare.
247 * parse.c (write_exp_string_vector): New function.
248 * p-valprint.c (pascal_val_print): Update.
249 * p-lang.h (is_pascal_string_type, pascal_printchar,
250 pascal_printstr): Update.
251 * p-lang.c (is_pascal_string_type): Remove 'char_size' argument.
252 Add 'char_type' argument.
253 (pascal_emit_char): Add type argument.
254 (pascal_printchar): Likewise.
255 (pascal_printstr): Likewise.
256 * objc-lang.c (objc_emit_char): Add type argument.
257 (objc_printchar): Likewise.
258 (objc_printstr): Likewise.
259 * macroexp.c (get_character_constant): Handle unicode characters.
261 (get_string_literal): Handle unicode strings. Use
263 * m2-valprint.c (print_unpacked_pointer): Update.
264 (m2_print_array_contents): Update.
265 (m2_val_print): Update.
266 * m2-lang.c (m2_emit_char): Add type argument.
267 (m2_printchar): Likewise.
268 (m2_printstr): Likewise.
269 * language.h (struct language_defn) <la_printchar>: Add type
271 <la_printstr, la_emitchar>: Likewise.
272 (LA_PRINT_CHAR): Likewise.
273 (LA_PRINT_STRING): Likewise.
274 (LA_EMIT_CHAR): Likewise.
275 * language.c (unk_lang_emit_char): Add type argument.
276 (unk_lang_printchar): Likewise.
277 (unk_lang_printstr): Likewise.
278 * jv-valprint.c (java_val_print): Update.
279 * jv-lang.c (java_emit_char): Add type argument.
280 * f-valprint.c (f_val_print): Update.
281 * f-lang.c (f_emit_char): Add type argument.
282 (f_printchar): Likewise.
283 (f_printstr): Likewise.
284 * expprint.c (print_subexp_standard): Update.
285 * charset.h (target_wide_charset): Declare.
286 (c_target_char_has_backslash_escape, c_parse_backslash,
287 host_char_print_literally, host_char_to_target,
288 target_char_to_host, target_char_to_control_char): Remove.
289 (enum transliterations): New type.
290 (convert_between_encodings): Declare.
291 (HOST_ESCAPE_CHAR): New define.
292 (host_letter_to_control_character, host_hex_value): Declare.
293 (enum wchar_iterate_result): New enum.
294 (struct wchar_iterator): Declare.
295 (make_wchar_iterator, make_cleanup_wchar_iterator, wchar_iterator,
296 wchar_push_back): Declare.
297 * charset-list.h: New file.
298 * c-valprint.c (textual_name): New function.
299 (textual_element_type): Handle wide character types.
300 (c_val_print): Pass original type to textual_element_type. Handle
301 wide character types.
302 (c_value_print): Use textual_element_type. Pass original type of
304 * c-lang.h (enum c_string_type): New type.
305 (c_printchar, c_printstr): Update.
306 * c-lang.c (classify_type): New function.
307 (print_wchar): Likewise.
308 (c_emit_char): Add type argument. Handle wide characters.
309 (c_printchar): Likewise.
310 (c_printstr): Add type argument. Handle wide and multibyte
312 (convert_ucn): New function.
313 (emit_numeric_character): Likewise.
314 (convert_octal): Likewise.
315 (convert_hex): Likewise.
316 (ADVANCE): New macro.
317 (convert_escape): New function.
318 (parse_one_string): Likewise.
319 (evaluate_subexp_c): Likewise.
320 (exp_descriptor_c): New global.
321 (c_language_defn): Use exp_descriptor_c.
322 (cplus_language_defn): Likewise.
323 (asm_language_defn): Likewise.
324 (minimal_language_defn): Likewise.
325 (charset_for_string_type): New function.
326 * c-exp.y (%union): Add 'svec' and 'tsval'.
328 (exp): Add CHAR production.
329 (string_exp): Rewrite.
330 (exp) <string_exp>: Rewrite.
331 (tempbuf): Now global.
332 (tempbuf_init): New global.
333 (parse_string_or_char): New function.
334 (yylex) <tempbuf>: Now global.
335 <tokptr, tempbufindex, tempbufsize, token_string, class_prefix>:
337 Handle 'u', 'U', and 'L' prefixes. Call parse_string_or_char.
338 (c_parse_escape): New function.
339 * auxv.c (fprint_target_auxv): Update.
340 * ada-valprint.c (ada_emit_char): Add type argument.
341 (ada_printchar): Likewise.
342 (ada_print_scalar): Update.
343 (printstr): Add type argument. Update calls to ada_emit_char.
344 (ada_printstr): Add type argument.
345 (ada_val_print_array): Update.
346 (ada_val_print_1): Likewise.
347 * ada-lang.c (emit_char): Add type argument.
348 * ada-lang.h (ada_emit_char, ada_printchar, ada_printstr): Add
350 * gdb_locale.h: Include langinfo.h.
351 * charset.c (_initialize_charset): Set default host charset from
352 the locale. Don't register charsets. Add target-wide-charset
353 commands. Call find_charset_names.
354 (struct charset, struct translation): Remove.
355 (GDB_DEFAULT_HOST_CHARSET): Remove.
356 (GDB_DEFAULT_TARGET_WIDE_CHARSET): New define.
357 (target_wide_charset_name): New global.
358 (show_host_charset_name): Handle "auto".
359 (show_target_wide_charset_name): New function.
360 (host_charset_enum, target_charset_enum): Remove.
361 (charset_enum): New global.
362 (all_charsets, register_charset, lookup_charset, all_translations,
363 register_translation, lookup_translation): Remove.
364 (simple_charset, ascii_print_literally, ascii_to_control): Remove.
365 (iso_8859_print_literally, iso_8859_to_control,
366 iso_8859_family_charset): Remove.
367 (ebcdic_print_literally, ebcdic_to_control,
368 ebcdic_family_charset): Remove.
369 (struct cached_iconv, check_iconv_cache, cached_iconv_convert,
370 register_iconv_charsets): Remove.
371 (target_wide_charset_be_name, target_wide_charset_le_name): New
373 (identity_either_char_to_other): Remove.
374 (set_be_le_names, validate): New functions.
375 (backslashable, backslashed, represented): Remove.
376 (default_c_target_char_has_backslash_escape): Remove.
377 (default_c_parse_backslash, iconv_convert): Remove.
378 (ascii_to_iso_8859_1_table, ascii_to_ebcdic_us_table,
379 ascii_to_ibm1047_table, iso_8859_1_to_ascii_table,
380 iso_8859_1_to_ebcdic_us_table, iso_8859_1_to_ibm1047_table,
381 ebcdic_us_to_ascii_table, ebcdic_us_to_iso_8859_1_table,
382 ebcdic_us_to_ibm1047_table, ibm1047_to_ascii_table,
383 ibm1047_to_iso_8859_1_table, ibm1047_to_ebcdic_us_table): Remove.
384 (table_convert_char, table_translation, simple_table_translation):
386 (current_host_charset, current_target_charset,
387 c_target_char_has_backslash_escape_func,
388 c_target_char_has_backslash_escape_baton): Remove.
389 (c_parse_backslash_func, c_parse_backslash_baton): Remove.
390 (host_char_to_target_func, host_char_to_target_baton): Remove.
391 (target_char_to_host_func, target_char_to_host_baton): Remove.
392 (cached_iconv_host_to_target, cached_iconv_target_to_host):
394 (lookup_charset_or_error, check_valid_host_charset): Remove.
395 (set_host_and_target_charsets): Remove.
396 (set_host_charset, set_target_charset): Remove.
397 (set_host_charset_sfunc, set_target_charset_sfunc): Rewrite.
398 (set_target_wide_charset_sfunc): New function.
399 (show_charset): Print target wide character set.
400 (host_charset, target_charset): Rewrite.
401 (target_wide_charset): New function.
402 (c_target_char_has_backslash_escape): Remove.
403 (c_parse_backslash): Remove.
404 (host_letter_to_control_character): New function.
405 (host_char_print_literally): Remove.
406 (host_hex_value): New function.
407 (target_char_to_control_char): Remove.
408 (cleanup_iconv): New function.
409 (convert_between_encodings): New function.
410 (target_char_to_host): Remove.
411 (struct wchar_iterator): Define.
412 (make_wchar_iterator, make_cleanup_wchar_iterator, wchar_iterator,
413 wchar_push_back): New functions.
414 (do_cleanup_iterator): New function.
415 (char_ptr): New typedef.
416 (charsets): New global.
417 (add_one, find_charset_names): New functions.
418 (default_charset_names): New global.
419 (auto_host_charset_name): Likewise.
420 * aclocal.m4, config.in, configure: Rebuild.
421 * configure.ac: Call AM_LANGINFO_CODESET.
422 (GDB_DEFAULT_HOST_CHARSET): Default to UTF-8.
423 (AM_ICONV): Invoke earlier.
424 * acinclude.m4: Include codeset.m4. Subst LIBICONV_INCLUDE and
425 LIBICONV_LIBDIR. Check for libiconv in build tree.
426 * Makefile.in (LIBICONV_LIBDIR, LIBICONV_INCLUDE): New macros.
427 (INTERNAL_CFLAGS_BASE): Add LIBICONV_INCLUDE.
428 (INTERNAL_LDFLAGS): Add LIBICONV_LIBDIR.
429 * gdb_obstack.h (obstack_grow_wstr): New define.
430 * gdb_wchar.h: New file.
431 * defs.h: Include it.
433 2009-03-20 Tom Tromey <tromey@redhat.com>
434 Jan Kratochvil <jan.kratochvil@redhat.com>
436 * dwarf2read.c (process_die): Handle DW_TAG_typedef.
437 * eval.c (evaluate_subexp_standard) <OP_TYPE>: Strip a single
439 * ada-lang.c (decode_packed_array_type): Call CHECK_TYPEDEF on the
441 * ada-typeprint.c (print_array_type): Do the NULL check
444 2009-03-19 Tom Tromey <tromey@redhat.com>
446 * utils.c (do_obstack_free): New function.
447 (make_cleanup_obstack_free): Likewise.
448 * defs.h (make_cleanup_obstack_free): Declare.
450 2009-03-18 Doug Evans <dje@google.com>
452 * linux-nat.c (linux_nat_find_memory_regions): Result of PIDGET is an
453 int, not a long long.
454 (linux_nat_info_proc_cmd): Store pid in long instead of long long.
456 * expprint.c (dump_raw_expression): Print note if non-NULL.
458 * printcmd.c (display_uses_solib_p): Redo loop, scan element list
461 2009-03-18 Nathan Sidwell <nathan@codesourcery.com>
463 * Makefile.in: Update license to GPLv3.
464 * ada-exp.y: Update license to GPLv3.
465 * ada-lex.l: Update license to GPLv3.
466 * c-exp.y: Update license to GPLv3.
467 * cp-name-parser.y: Update license to GPLv3.
468 * darwin-nat-info.c: Update license to GPLv3.
469 * f-exp.y: Update license to GPLv3.
470 * gdb_thread_db.h: Update license to GPLv3.
471 * hppanbsd-nat.c: Update license to GPLv3.
472 * hppanbsd-tdep.c: Update license to GPLv3.
473 * hppaobsd-tdep.c: Update license to GPLv3.
474 * jv-exp.y: Update license to GPLv3.
475 * m2-exp.y: Update license to GPLv3.
476 * objc-exp.y: Update license to GPLv3.
477 * p-exp.y: Update license to GPLv3.
478 * reply_mig_hack.awk: Update license to GPLv3.
479 * reverse.c: Update license to GPLv3.
480 * xtensa-xtregs.c: Update license to GPLv3.
482 2009-03-18 Pedro Alves <pedro@codesourcery.com>
484 * remote.c (remote_close): Don't call generic_mourn_inferior.
485 (remote_mourn_1): Call generic_mourn_inferior after closing the
488 2009-03-18 Pedro Alves <pedro@codesourcery.com>
490 * remote.c (remote_start_remote): Add missing call to
491 init_wait_for_inferior in non-stop mode.
493 2009-03-18 Pedro Alves <pedro@codesourcery.com>
495 * breakpoint.c (bpstat_should_step): Only consider software
496 watchpoints that have a location.
498 2009-03-17 Joel Brobecker <brobecker@adacore.com>
500 Add a target_ops parameter to the to_kill method in struct target_ops.
502 * target.h (struct target_ops): Add a "target_ops *" parameter to
504 (target_kill): Remove macro. Add declaration.
505 * target.c (debug_to_kill): Delete, no longer necessary.
506 (target_kill): New function.
507 (update_current_target): Stop inheriting the to_kill method.
508 Do not de_fault it to no_process either.
509 (setup_target_debug): Do not set current_target.to_kill.
510 * gnu-nat.c, go32-nat.c, hpux-thread.c, inf-ptrace.c, inf-ttrace.c,
511 linux-nat.c, monitor.c, nto-procfs.c, procfs.c, remote-m32r-sdi.c,
512 remote-mips.c, remote-sim.c, remote.c, windows-nat.c: Update
515 2009-03-17 Doug Evans <dje@google.com>
517 * amd64-linux-nat.c (si_timerid,si_overrun): Provide definition for
518 glibc 2.3.2 and earlier.
520 2009-03-17 Joel Brobecker <brobecker@adacore.com>
522 * frame.c (get_prev_frame_1): Do not perform the inner_frame
523 sanity check if this_frame is not NORMAL.
524 (frame_id_inner): Update the description of this function.
526 2009-03-17 Hui Zhu <teawater@gmail.com>
528 * stack.c: Change the introduce of "disassemble-next-line".
530 2009-03-17 Pedro Alves <pedro@codesourcery.com>
532 * mi/mi-main.h (mi_print_timing_maybe): Add strict prototype,
535 2009-03-17 Hui Zhu <teawater@gmail.com>
537 * stack.c: Include valprint.h.
538 (disassemble_next_line): New enum.
539 (show_disassemble_next_line): New function. Show the current
540 value of disassemble-next-line.
541 (gdb_disassembly_stub_args): New struct for argument passing
542 between function do_gdb_disassembly and function
543 gdb_disassembly_stub.
544 (gdb_disassembly_stub): New function. Helper for
546 (do_gdb_disassembly): New function. Use TRY_CATCH to catch
547 the exception from the gdb_disassembly because it will be
548 broken by filter sometime.
549 (print_frame_info): If disassemble-next-line is set to auto
550 or on and doesn't have the line debug messages for $pc,
551 output the next instruction.
552 If disassemble-next-line is set to on and there is line debug
553 messages, output assembly codes for next line.
554 (_initialize_stack): Make the "set disassemble-next-line"
555 command an auto-boolean command. Change its class to
556 class_stack. Place it in the top level set list. Extend help
557 to describe the auto mode.
559 2009-03-17 Pedro Alves <pedro@codesourcery.com>
561 * infrun.c (normal_stop): Don't overwrite old_chain.
563 2009-03-16 Joel Brobecker <brobecker@adacore.com>
565 * remote-mips.c (mips_load): Replace call to regcache_set_valid_p,
566 which is undefined, by call to regcache_invalidate, which should
567 do what the original author wanted to do.
569 2009-03-16 Joel Brobecker <brobecker@adacore.com>
571 * remote-mips.c (mips_mourn_inferior): Add missing ops parameter.
572 (mips_create_inferior): Likewise.
574 2009-03-16 Joel Brobecker <brobecker@adacore.com>
576 * go32-nat.c (go32_create_inferior): Add missing ops parameter.
578 2009-03-16 Joel Brobecker <brobecker@adacore.com>
580 * darwin-nat.c (darwin_resume): Fix a compiler warning when
581 building on x86_64-darwin.
583 2009-03-16 Tristan Gingold <gingold@adacore.com>
585 * configure.tgt: Add handling for x86_64-darwin.
587 2009-03-16 Jan Kratochvil <jan.kratochvil@redhat.com>
589 * auxv.c (fprint_target_auxv): New TAG for AT_RANDOM.
591 2009-03-15 Joel Brobecker <brobecker@adacore.com>
593 * aix-thread.c (aix_thread_thread_alive, aix_thread_pid_to_str):
594 Use the ops parameter to get to the target beneath, rather than
595 using the current_target global. Using the current_target global
596 was an unintended accident.
598 2009-03-15 Joel Brobecker <brobecker@adacore.com>
600 Fix an error happening while loading symbols from a core file
603 * rs6000-nat.c (xcoff_relocate_symtab): Use target_has_execution
604 to detect whether we're debugging a core file or not.
606 2009-03-15 Joel Brobecker <brobecker@adacore.com>
608 Modernize the aix-thread later by getting rid of the base_target
609 global. This brings back to life the AIX port which was otherwise
610 crashing all the time.
612 * aix-thread.c (base_target): Delete.
613 (pd_enable): Do not set base_target.
614 (aix_thread_attach): Use find_target_beneath instead of base_target.
615 (aix_thread_detach, aix_thread_resume, aix_thread_wait)
616 (aix_thread_fetch_registers, aix_thread_store_registers),
617 (aix_thread_xfer_partial, aix_thread_mourn_inferior)
618 (aix_thread_thread_alive, aix_thread_pid_to_str): Likewise.
619 (aix_thread_kill): Delete. Does not seem necessary.
620 (init_aix_thread_ops): Do not set aix_thread_ops.to_kill.
622 2009-03-15 Jan Kratochvil <jan.kratochvil@redhat.com>
624 * stack.c (return_command <retval_exp>): New variables retval_expr
625 and old_chain. Inline parse_and_eval to initialize retval_expr. Check
626 RETVAL_EXPR for UNOP_CAST and set RETURN_TYPE to the RETURN_VALUE type
627 if RETURN_TYPE is NULL.
630 2009-03-14 Pedro Alves <pedro@codesourcery.com>
632 * remote.c (PACKET_qAttached): New.
633 (remote_query_attached): New.
634 (remote_add_inferior): Add new `attached' argument. Handle it.
635 (remote_notice_new_inferior, remote_start_remote): Adjust to pass
636 -1 to remote_add_inferior in new parameter.
637 (extended_remote_attach_1): Adjust to pass 1 to
638 remote_add_inferior in the new parameter.
639 (extended_remote_create_inferior_1): Adjust to pass 0 to
640 remote_add_inferior in the new parameter.
641 (_initialize_remote): Add "set/show remote query-attached-packet"
644 2009-03-13 Tom Tromey <tromey@redhat.com>
646 * symtab.c (lookup_symbol_in_language): Use a cleanup.
648 2009-03-13 Doug Evans <dje@google.com>
650 * exceptions.h: Clean up some comments on catch_exceptions usage.
651 * exceptions.c: Ditto. Plus mark catch_errors as superseded by
654 2009-02-17 Joel Brobecker <brobecker@adacore.com>
656 The following patch helps getting rid of a warning inside solib-som.c.
658 * source.c (source_full_path_of): Constify parameter filename.
659 * defs.h (source_full_path_of): Update declaration accordingly.
661 2009-03-12 Joel Brobecker <brobecker@adacore.com>
663 * ada-lang.c (ada_evaluate_subexp): Merge case BINOP_REM and
664 BINOP_MOD cases with the handling of case BINOP_DIV and BINOP_MUL.
665 Remove useless op value checks when EVAL_AVOID_SIDE_EFFECTS.
667 2009-03-12 Joel Brobecker <brobecker@adacore.com>
669 * ada-lang.c (ada_evaluate_subexp) <BINOP_DIV>: make sure to
670 promote the operands when noside is EVAL_AVOID_SIDE_EFFECTS.
672 2009-03-12 Joel Brobecker <brobecker@adacore.com>
674 * ada-tasks.c (ada_task_is_alive): Move up and make static.
675 * ada-lang.h (ada_task_is_alive): Remove declaration.
677 2009-03-12 Jerome Guitton <guitton@adacore.com>
679 * ada-lang.c (ada_delta): Change the type of numerators and
680 denominators to DOUBLEST, as they may not fit into a long.
681 (scaling_factor): Ditto.
683 2009-03-12 Jerome Guitton <guitton@adacore.com>
685 * language.c (lang_bool_type): Set lai->bool_type_symbol to NULL.
687 2009-03-12 Joel Brobecker <brobecker@adacore.com>
689 * ada-lang.c (ada_evaluate_subexp) [OP_VAR_VALUE]: For tagged
690 types, if we are unable to determine the actual symbol type
691 from its tag, then use the static approximation instead.
693 2009-03-12 Joel Brobecker <brobecker@adacore.com>
695 Fix crash printing packed record with packed array.
697 * ada-lang.c (ada_modulus_from_name): New function.
698 (ada_modulus): In the case where the type length is bigger than
699 the size of the type used to hold the bounds, try determining
700 the modulus from the type name.
701 (ada_value_primitive_packed_val): Fix bug in the computation of
702 ntarg causing an out-of-buffer invalid access.
704 2009-03-12 Joel Brobecker <brobecker@adacore.com>
706 Fix segfault when printing short_integer'last.
708 * ada-lang.c (ada_find_any_type): Search in the primitive types
709 if a symbol could not be found.
711 2009-03-12 Joel Brobecker <brobecker@adacore.com>
713 * ada-tasks.c (task_states,long_task_states): Add new states
714 Activating and Acceptor_Delay_Sleep. Update the description
715 of state Acceptor_Sleep.
717 2009-03-12 Jonas Maebe <jonas.maebe@elis.ugent.be> (obvious change)
719 Fix a build failure on Darwin following some changes in
720 the profile of some target_ops methods.
722 * darwin-nat.c (darwin_kill_inferior): Add target_ops parameter
724 (darwin_stop_inferior, darwin_detach): Likewise.
726 2009-03-12 Vladimir Prus <vladimir@codesourcery.com>
728 Include token in ^running notification for CLI commands.
730 * mi/mi-main.c (mi_execute_command): Set current_token here.
731 (mi_cmd_execute): Do not set current_token here.
733 2009-03-12 Vladimir Prus <vladimir@codesourcery.com>
737 * mi/mi-main.c (mi_print_timing_maybe): New.
738 (captured_mi_execute_command): Simplify. Output timings to
740 (mi_execute_async_cli_command): Do not print timings.
741 * mi/mi-main.h (mi_print_timing_maybe): Declare.
742 * mi/mi-interp.c (mi_on_normal_stop): Call mi_print_timing_maybe.
744 2009-03-12 Jerome Guitton <guitton@adacore.com>
746 * xcoffread.c (process_linenos): Check if the line in the
747 include table refers to the main source file and, if so,
748 add them to the main subfile.
750 2009-03-12 Joel Brobecker <brobecker@adacore.com>
752 Fix a build failure on AIX introduced after a change in the profile
753 of some of the "methods" in the target_ops structure.
754 * aix-thread.c: Add missing target_ops parameter throughout.
756 Implement Ada task switching on AIX.
757 * aix-thread.c (aix_thread_get_ada_task_ptid): New function.
758 (init_aix_thread_ops): Set aix_thread_ops.to_get_ada_task_ptid.
760 2009-03-11 Daniel Jacobowitz <dan@codesourcery.com>
762 * breakpoint.c (bpstat_check_breakpoint_conditions): Use
763 value_mark and value_free_to_mark.
764 * objfiles.c (free_objfile): Call objfile_free_data before
767 2009-03-10 Hui Zhu <teawater@gmail.com>
769 * disasm.c (gdb_disassembly): Remove unused argument
771 * disasm.h (gdb_disassembly): Ditto.
772 * cli/cli-cmds.c (print_disassembly): Ditto.
773 * mi/mi-cmd-disas.c (mi_cmd_disassemble): Ditto.
775 2009-03-09 Paul Pluzhnikov <ppluzhnikov@google.com>
777 * solib.c (solib_contains_address_p): New function.
778 (solib_name_from_address): Use it.
779 * printcmd.c (display_uses_solib_p): Use it.
780 * solib.h (solib_contains_address_p): Declare it.
782 2009-03-09 Jan Kratochvil <jan.kratochvil@redhat.com>
784 * varobj.c (free_variable): Call value_free.
786 2009-03-09 Jan Kratochvil <jan.kratochvil@redhat.com>
789 * dwarf2read.c (dwarf_decode_macros): New variable `at_commandline'.
790 Move the variable `macinfo_type' out of the loop. Create a new
791 processing pass before the current one to pre-create `current_file'.
792 New complaint on misplaced zero/non-zero definitions/includes.
793 Skip first DW_MACINFO_start_file with `at_commandline' set.
795 2008-03-09 Vladimir Prus <vladimir@codesourcery.com>
797 * solib.c (reload_shared_libraries): Give
798 inferior a chance to reset solib breakpoint.
801 2009-03-08 Christopher Faylor <me+cygwin@cgf.cx>
803 * windows-nat.c (dr): Redefine to use largest possible integer which
805 (cygwin_set_dr): Avoid coercion.
807 2009-03-08 Oswald Buddenhagen <oswald.buddenhagen@trolltech.de>
809 * windows-nat.c (windows_create_inferior): Implement --tty handling on
812 2009-03-06 Paul Pluzhnikov <ppluzhnikov@google.com>
814 Rename solib_address to solib_name_from_address.
815 * breakpoint.c (insert_bp_location, disable_breakpoints_in_shlibs)
816 (disable_breakpoints_in_unloaded_shlib): Update.
817 * printcmd.c (display_uses_solib_p): Likewise.
818 * stack.c (print_frame): Likewise.
822 2009-03-05 Paul Pluzhnikov <ppluzhnikov@google.com>
824 * printcmd.c (do_one_display): Reparse exp_string.
825 (display_uses_solib_p): New function.
826 (clear_dangling_display_expressions): New function.
827 (_initialize_printcmd): Add observer.
828 * solib.c (no_shared_libraries): Swap order of calls to
829 clear_solib and objfile_purge_solibs.
831 2009-03-05 Joel Brobecker <brobecker@adacore.com>
833 Implement the target-specific part of Ada tasking support
836 * dec-thread.c (dec_thread_get_ada_task_ptid): New function.
837 (init_dec_thread_ops): Set the to_get_ada_task_ptid method.
839 2009-03-05 Joel Brobecker <brobecker@adacore.com>
841 Get rid of the global "base_target" and use "find_target_beneath"
842 to find the underlying target.
843 * dec-thread.c (base_target): Delete.
844 (enable_dec_thread): Remove assignement to base_target.
845 (dec_thread_detach, dec_thread_wait, dec_thread_wait)
846 (dec_thread_fetch_registers, dec_thread_store_registers)
847 (dec_thread_mourn_inferior, dec_thread_pid_to_str):
848 Update the function profile if necessary.
849 Use find_target_beneath to call the same method but from
850 the underlying target, removing the need for "base_target".
852 * dec-thread.c (dec_thread_get_regsets, dec_thread_set_regsets):
853 Fix a copy/paste error in a few debug traces...
855 * solib-osf.c (init_so): Use a simpler method for computing
856 the size of lm_info structure. This also gets rid of warning
857 emitted by the compiler.
859 2009-03-05 Pedro Alves <pedro@codesourcery.com>
861 * breakpoint.c (check_duplicates_for): Skip permanent breakpoints
862 duplicates of permanent breakpoints.
864 2009-03-04 Pedro Alves <pedro@codesourcery.com>
866 * inferior.h (notice_new_inferior): Declare.
867 * infcmd.c (notice_new_inferior): New.
868 * remote.c (remote_add_inferior, remote_add_thread): New.
869 (notice_new_inferiors): Rename to...
870 (remote_notice_new_inferior): ... this. Add RUNNING argument.
871 Use remote_add_thread instead of add_thread, passing it the
872 RUNNING argument. Add an inferior with remote_add_inferior. If
873 we just learned about an inferior, call notice_new_inferior.
874 (record_currthread): Adjust.
875 (remote_threads_info): Adjust to use remote_notice_new_inferior.
876 (remote_start_remote, extended_remote_attach_1): Use
878 (process_stop_reply): Adjust. Call remote_notice_new_inferior
879 after handling expedited registers and watchpoint state.
880 (extended_remote_create_inferior_1): Use remote_add_inferior.
882 2009-03-04 Aleksandar Ristovski <aristovski@qnx.com>
884 * infcmd.c (registers_info): Remove register number case.
886 2009-03-03 Pedro Alves <pedro@codesourcery.com>
888 * top.c (quit_target): Check for target_has_execution before
889 killing or detaching from inferiors.
891 2009-03-02 Joel Brobecker <brobecker@adacore.com>
893 Remove some unused routines.
895 * ada-lang.c (is_suppressed_name, ada_suppress_symbol_printing):
897 * ada-lang.c (ada_task_list_iterator_ftype)
898 (iterate_over_live_ada_tasks): Delete.
899 * ada-tasks.c (ada_get_environment_task, iterate_over_live_ada_tasks):
902 2009-03-01 Doug Evans <dje@google.com>
904 * symtab.c: Remove trailing whitespace throughout the file.
905 (expand_line_sal): Fix some typos and whitespace.
907 * Makefile.in (clean): rm -f $(DEPDIR)/*.
909 * Makefile.in (GDB_CFLAGS): Add -I$(srcdir)/common.
910 (init.c): signals/ -> common/.
912 * target.h (target_signal_to_string,target_signal_to_string)
913 (target_signal_from_name,target_signal_to_host_p)
914 (target_signal_from_host,target_signal_to_host): Move to ...
915 * common/gdb_signals.h: ... here. New file.
916 * common/signals.c: Moved here from signals/signals.c.
917 #include gdb_signals.h, remove #include of target.h in gdb case.
918 (target_signal_from_command,default_target_signal_to_host)
919 (default_target_signal_from_host): Move inside #ifndef GDBSERVER.
921 Include thread ID in target_wait debugging output.
922 * infrun.c (print_target_wait_results): New function.
923 (wait_for_inferior,fetch_inferior_event): Call it.
925 2009-02-27 Pedro Alves <pedro@codesourcery.com>
927 * gdb_proc_service.h (struct ps_prochandle): Replace pid_t field
929 * linux-thread-db.c (thread_get_info_callback): Build the ptid
930 using the pid stored in proc_handle.ptid.
931 (thread_from_lwp, thread_db_attach_lwp, enable_thread_event)
932 (check_for_thread_db, thread_db_detach, check_event)
933 (thread_db_mourn_inferior, find_new_threads_callback)
934 (thread_db_find_new_threads_1): Adjust.
935 * proc-service.c (ps_xfer_memory, ps_lgetregs, ps_lsetregs)
936 (ps_lgetfpregs, ps_lsetfpregs, ps_getpid): Adjust.
938 2009-02-27 Phil Muldoon <pmuldoon@redhat.com>
940 * valprint.c (read_string): Rework clean-up logic. Use
941 free_current_contents to clean-up buffer.
943 2009-02-27 Andreas Schwab <schwab@linux-m68k.org>
945 * MAINTAINERS: Update e-mail address.
947 2009-02-26 Phil Muldoon <pmuldoon@redhat.com>
949 * python/python-utils.c (python_string_to_unicode): Always return
951 (python_string_to_target_string): Decrement transient python
953 (python_string_to_host_string): Likewise.
955 2007-02-26 Pedro Alves <pedro@codesourcery.com>
957 * mips-linux-nat.c (mips64_linux_fetch_registers): Pass `ops' to
958 call to super_fetch_registers.
959 (mips64_linux_store_registers): Pass `ops' to call to
960 super_store_registers.
962 2009-02-25 Doug Evans <dje@google.com>
964 * breakpoint.c (insert_bp_location): Add \n to overlay breakpoint
967 * breakpoint.c (disable_breakpoints_in_shlibs): Delete local
968 disabled_shlib_breaks, unused.
970 * printcmd.c (build_address_symbolic): Fix comment.
972 2009-02-25 Hui Zhu <teawater@gmail.com>
974 * cli/cli-script.c (define_command): Add _() to query.
975 * gnu-nat.c (inf_validate_task_sc): Ditto.
976 * infcmd.c (kill_if_already_running): Ditto.
977 (jump_command): Ditto.
978 (attach_command): Ditto.
979 * inflow.c (kill_command): Ditto.
980 * infrun.c (handle_command): Ditto.
981 * maint.c (maintenance_dump_me): Ditto.
982 * memattr.c (mem_delete_command): Ditto.
983 * monitor.c (monitor_interrupt_query): Ditto.
984 * nto-procfs.c (interrupt_query): Ditto.
985 * printcmd.c (undisplay_command): Ditto.
986 * remote-mips.c (mips_kill): Ditto.
987 * remote.c (interrupt_query): Ditto.
988 * solib-irix.c (irix_open_symbol_file_object): Ditto.
989 * solib-osf.c (osf_open_symbol_file_object): Ditto.
990 * solib-pa64.c (pa64_open_symbol_file_object): Ditto.
991 * solib-som.c (som_open_symbol_file_object): Ditto.
992 * solib-svr4.c (open_symbol_file_object): Ditto.
993 * symfile.c (symbol_file_add_with_addrs_or_offsets): Ditto.
994 * target.c (kill_or_be_killed): Ditto.
995 * tracepoint.c (delete_trace_command): Ditto.
996 * top.c (quit_confirm): Add _() to s that will be used
999 2009-02-24 Pierre Muller <muller@ics.u-strasbg.fr>
1001 Fix windows-nat.c compilation failure.
1003 * windows-nat.c (windows_thread_alive): Fix forward declaration.
1004 (get_windows_debug_event): Add ops parameter to call to windows_resume.
1006 2009-02-23 Pedro Alves <pedro@codesourcery.com>
1008 * remote-sim.c (gdbsim_resume): Add target_ops* argument.
1010 2009-02-23 Jay Krell <jay.krell@cornell.edu> (tiny change)
1012 * symtab.c (find_line_symtab): Initialize exact to avoid
1015 2009-02-23 Pedro Alves <pedro@codesourcery.com>
1017 * i386-linux-nat.c (i386_linux_fetch_inferior_registers): Pass
1018 `ops' to recursive call.
1020 2009-02-23 Pedro Alves <pedro@codesourcery.com>
1022 * corelow.c (get_core_registers): Adjust.
1023 (core_file_thread_alive): Rename to...
1024 (core_thread_alive): ... this.
1025 (core_pid_to_str): Try gdbarch_core_pid_to_str first.
1026 (init_core_ops): Adjust.
1027 (coreops_suppress_target): Delete.
1028 (_initialize_corelow): Unconditionally add core_ops.
1029 * procfs.c: Include "inf-child.h".
1030 (procfs_ops): Delete.
1031 (init_procfs_ops): Delete. Reimplement as...
1032 (procfs_target): ... this, inheriting from inf-child.
1033 (procfs_attach, procfs_detach, procfs_fetch_registers): Adjust.
1034 (procfs_prepare_to_store): Delete.
1035 (procfs_store_registers, procfs_resume): Adjust.
1036 (procfs_open): Delete.
1037 (procfs_suppress_run): Delete.
1038 (procfs_can_run): Delete.
1039 (procfs_mourn_inferior): Adjust.
1040 (procfs_init_inferior): Add target_ops parameter. Adjust.
1041 (procfs_create_inferior): Don't pass procfs_init_inferior to
1042 fork_inferior. Instead call it after fork_inferior returns.
1043 (procfs_find_new_threads): Adjust.
1044 (_initialize_procfs): Adjust to use procfs_target instead of
1046 * sol-thread.c (orig_core_ops, sol_core_ops): Delete.
1047 (lwp_to_thread): Use target_thread_alive.
1048 (sol_thread_open): Delete.
1049 (sol_thread_attach): Delete.
1050 (sol_thread_detach, sol_thread_resume, sol_thread_wait)
1051 (sol_thread_fetch_registers, sol_thread_store_registers): Adjust
1052 to use find_target_beneath.
1053 (sol_thread_prepare_to_store, sol_thread_xfer_memory): Delete.
1054 (sol_thread_xfer_partial): Adjust to use find_target_beneath.
1055 (sol_thread_files_info, sol_thread_kill_inferior): Delete.
1056 (check_for_thread_db): New.
1057 (sol_thread_notice_signals, sol_thread_create_inferior): Delete.
1058 (sol_thread_new_objfile): Call check_for_thread_db.
1059 (sol_thread_mourn_inferior): Adjust to use find_target_beneath.
1060 (sol_thread_can_run): Delete.
1061 (sol_thread_alive): Adjust to use find_target_beneath.
1062 (sol_thread_stop): Delete.
1063 (rw_common): Use target_write_memory or target_read_memory.
1064 (ps_lgetregs, ps_lgetfpregs): Use target_fetch_registers.
1065 (ps_lsetregs, ps_lsetfpregs): Use target_store_registers.
1066 (solaris_pid_to_str): Remove check for libthread_db initialization
1068 (sol_find_new_threads): Remove check for libthread_db
1069 initialization failing, or for an invalid inferior_ptid. Adjust
1070 to use find_target_beneath.
1071 (sol_core_open, sol_core_close, sol_core_detach,
1072 sol_core_files_info, sol_find_memory_regions,
1073 sol_make_note_section, ignore): Delete.
1074 (init_sol_thread_ops): Make it a thread_stratum target. Remove
1075 unneeded callback settings.
1076 (init_sol_core_ops): Delete.
1077 (_initialize_sol_thread): No longer call init_sol_core_ops, set
1078 procfs_suppress_run, or hack with core_ops.
1080 * target.h (struct target_ops): Add a target_ops * parameter to
1081 to_resume, to_fetch_registers, to_store_registers, to_thread_alive
1082 and to_find_new_threads.
1083 (target_fetch_registers, target_store_registers)
1084 (target_thread_alive, target_find_new_threads): Redeclare as
1087 * target.c (update_current_target): Do not inherit or de_fault
1088 to_resume, to_fetch_registers, to_store_registers,
1089 to_thread_alive, to_find_new_threads.
1090 (target_resume): Adjust.
1091 (target_thread_alive, target_find_new_threads): New.
1092 (debug_to_resume, debug_to_fetch_registers): Delete.
1093 (target_fetch_registers): New.
1094 (debug_to_store_registers): Delete.
1095 (target_store_registers): New.
1096 (debug_to_thread_alive, debug_to_find_new_threads): Delete.
1097 (setup_target_debug): Adjust.
1099 * gdbcore.h (core_ops): Delete declaration.
1101 * inf-ptrace.c, linux-nat.c, remote.c, amd64-linux-nat.c,
1102 inf-child.c, linux-thread-db.c, bsd-uthread.c, inf-ttrace.c,
1103 i386-sol2-tdep.c, darwin-nat.c, gnu-nat.c, go32-nat.c,
1104 hpux-thread.c, i386-linux-nat.c, i386fbsd-nat.c, monitor.c,
1105 nto-procfs.c, remote-m32r-sdi.c, remote-mips.c, windows-nat.c,
1106 alphabsd-nat.c, amd64bsd-nat.c, arm-linux-nat.c, armnbsd-nat.c,
1107 bsd-kvm.c, hppa-hpux-nat.c, hppa-linux-nat.c, hppabsd-nat.c,
1108 hppanbsd-nat.c, i386-darwin-nat.c, i386bsd-nat.c,
1109 ia64-linux-nat.c, m32r-linux-nat.c, m68kbsd-nat.c,
1110 m68klinux-nat.c, m88kbsd-nat.c, mips-linux-nat.c,
1111 mips64obsd-nat.c, mipsnbsd-nat.c, ppc-linux-nat.c, ppcnbsd-nat.c,
1112 ppcobsd-nat.c, remote-sim.c, rs6000-nat.c, s390-nat.c,
1113 shnbsd-nat.c, sparc-nat.c, sparc-nat.h, spu-linux-nat.c,
1114 vaxbsd-nat.c, xtensa-linux-nat.c: Adjust to target_ops changes.
1116 * gdbarch.sh (core_pid_to_str): New gdbarch callback.
1117 * gdbarch.h, gdbarch.c: Regenerate.
1119 * sol2-tdep.c: Include "inferior.h".
1120 (sol2_core_pid_to_str): New.
1121 * sol2-tdep.h (sol2_core_pid_to_str): Declare.
1123 * amd64-sol2-tdep.c (amd64_sol2_init_abi): Set it.
1124 * sparc-sol2-tdep.c (sparc32_sol2_init_abi): Set it.
1125 * sparc64-sol2-tdep.c (sparc64_sol2_init_abi): Set it.
1126 * i386-sol2-tdep.c (i386_sol2_init_abi): Set it.
1128 2009-02-22 Doug Evans <dje@google.com>
1130 * exec.c (exec_file_attach): Fix comment.
1132 2009-02-22 Pedro Alves <pedro@codesourcery.com>
1134 Silence a few -Wmissing-prototypes warnings.
1137 * alpha-linux-tdep.c (alpha_linux_regset_from_core_section): Make
1139 * alpha-osf1-tdep.c (_initialize_alpha_osf1_tdep): Declare.
1140 * amd64fbsd-tdep.c (amd64fbsd_init_abi): Make it static.
1141 * amd64nbsd-tdep.c (_initialize_amd64nbsd_ndep): Rename to ...
1142 (_initialize_amd64nbsd_tdep): ... this.
1143 * arm-linux-tdep.c (arm_linux_software_single_step): Make it static.
1144 (_initialize_arm_linux_tdep): Declare.
1145 * armbsd-tdep.c (armbsd_fpreg_offset): Make it static.
1146 * armnbsd-tdep.c (_initialize_arm_netbsd_tdep): Declare.
1147 * armobsd-tdep.c (_initialize_armobsd_tdep): Declare.
1148 * avr-tdep.c (avr_return_value): Make it static.
1149 (avr_frame_unwind_cache): Ditto.
1150 * bsd-uthread.c (bsd_uthread_inferior_created): Ditto.
1151 (bsd_uthread_solib_loaded): Ditto.
1152 (bsd_uthread_solib_unloaded): Ditto.
1153 (bsd_uthread_target): Ditto.
1154 (_initialize_bsd_uthread): Declare.
1155 * cris-tdep.c (crisv32_single_step_through_delay): Make it static.
1156 (cris_frame_unwind_cache): Ditto.
1157 * frv-tdep.c (frv_return_value): Ditto.
1158 * h8300-tdep.c (h8300_use_struct_convention): Ditto.
1159 (h8300h_use_struct_convention): Ditto.
1160 * hppa-tdep.c (hppa_sign_extend, hppa_low_hppa_sign_extend):
1162 * hppa-tdep.h (hppa_low_sign_extend, hppa_sign_extend): Delete
1164 * hppabsd-tdep.c: Include hppabsd-tdep.h.
1165 (hppabsd_find_global_pointer): Make it static.
1166 * hppabsd-tdep.h: New.
1167 * hppanbsd-tdep.c: Include hppabsd-tdep.h.
1168 (hppabsd_init_abi): Remove declaration.
1169 (_initialize_hppabsd_tdep): Remove declaration.
1170 (_initialize_hppanbsd_tdep): Declare.
1171 * hppaobsd-tdep.c: Include hppabsd-tdep.h.
1172 (hppabsd_init_abi): Delete declaration.
1173 (hppaobsd_init_abi): Make it static.
1174 * i386-nto-tdep.c (_initialize_i386nto_tdep): Declare.
1175 * i386nbsd-tdep.c (_initialize_i386nbsd_tdep): Declare.
1176 * ia64-linux-tdep.c (_initialize_ia64_linux_tdep): Declare.
1177 * ia64-tdep.c (ia64_register_reggroup_p): Make it static.
1178 * iq2000-tdep.c (_initialize_iq2000_tdep): Declare.
1179 * m32c-tdep.c (m32c_register_reggroup_p): Make it static.
1180 (m32c_analyze_prologue, m32c_virtual_frame_pointer): Ditto.
1181 (_initialize_m32c_tdep): Declare.
1182 * m32r-rom.c (_initialize_m32r_rom): Declare.
1183 * m32r-tdep.c (m32r_skip_prologue): Make it static.
1184 (m32r_return_value): Ditto.
1185 * m68hc11-tdep.c (m68hc11_frame_unwind_cache): Make it static.
1186 (m68hc11_return_value): Ditto.
1187 * m68klinux-tdep.c (_initialize_m68k_linux_tdep): Declare.
1188 * m88k-tdep.c (m88k_frame_cache): Make it static.
1189 * mep-tdep.c (mep_gdb_print_insn): Ditto.
1190 (mep_return_value): Ditto.
1191 (_initialize_mep_tdep): Declare.
1192 * mips-irix-tdep.c (_initialize_mips_irix_tdep): Declare.
1193 * mips-linux-tdep.c (supply_64bit_reg): Make it static.
1194 (mips_linux_syscall_next_pc): Ditto.
1195 (_initialize_mips_linux_tdep): Declare.
1196 * mips-tdep.c (mips_single_step_through_delay): Make it static.
1197 * mipsnbsd-tdep.c (_initialize_mipsnbsd_tdep): Declare.
1198 * mn10300-linux-tdep.c (_initialize_mn10300_linux_tdep): Declare.
1199 * mn10300-tdep.c (_initialize_mn10300_tdep): Declare.
1200 * mt-tdep.c (_initialize_mt_tdep): Declare.
1201 * nbsd-tdep.c: Include nbsd-tdep.h.
1202 * nto-tdep.c (find_load_phdr): Make it static.
1203 (_initialize_nto_tdep): Declare.
1204 * ppc-linux-tdep.c (ppc_linux_memory_remove_breakpoint): Make it
1206 (_initialize_ppc_linux_tdep): Declare.
1207 * remote-m32r-sdi.c (m32r_can_use_hw_watchpoint)
1208 (m32r_insert_watchpoint, m32r_remove_watchpoint)
1209 (m32r_stopped_data_address, m32r_stopped_by_watchpoint): Make
1211 * rs6000-aix-tdep.c (_initialize_rs6000_aix_tdep): Declare.
1212 * rs6000-nat.c: Include xcoffread.h.
1213 (find_toc_address): Don't extern declare get_toc_offset. Adjust
1214 to call xcoff_get_to_offset.
1215 * rs6000-tdep.c (ppc_vsx_support_p, ppc_displaced_step_fixup)
1216 (rs6000_skip_main_prologue, rs6000_in_solib_return_trampoline)
1217 (rs6000_skip_trampoline_code): Make static.
1218 * s390-tdep.c (s390_regset_from_core_section): Ditto.
1219 * sh-tdep.c (sh_register_reggroup_p): Ditto.
1220 * shnbsd-tdep.c (shnbsd_regset_from_core_section): Ditto.
1221 (_initialize_shnbsd_tdep): Declare.
1222 * solib-frv.c (displacement_from_map): Make static.
1223 (_initialize_frv_solib): Declare.
1224 * solib-irix.c (fetch_lm_info): Make static.
1225 (_initialize_irix_solib): Declare.
1226 * solib-som.c: Include solib-som.h.
1227 (som_solib_select): Line break.
1228 * sparc-tdep.c (sparc_regset_from_core_section): Make static.
1229 * sparcnbsd-tdep.c (_initialize_sparnbsd_tdep): Rename to ...
1230 (_initialize_sparcnbsd_tdep): ... this.
1231 * spu-tdep.c (spu_software_single_step): Make it static.
1232 (_initialize_spu_tdep): Declare.
1233 * vax-tdep.c (vax_frame_cache): Make it static.
1234 * xcoffread.c: Include xcoffread.h.
1235 (get_toc_offset): Rename to ...
1236 (xcoff_get_toc_offset): ... this.
1237 (_initialize_xcoffread): Declare.
1239 * xtensa-linux-tdep.c (_initialize_xtensa_linux_tdep): Declare.
1240 * xtensa-tdep.c (xtensa_skip_prologue, xtensa_derive_tdep): Make
1242 (_initialize_xtensa_tdep): Declare.
1244 2008-02-21 Pedro Alves <pedro@codesorcery.com>
1246 Silence a few -Wmissing-prototypes warnings.
1249 * amd64-nat.c: Include "amd64-nat.h".
1250 * fork-child.c (_initialize_fork_child): Ditto.
1251 * gcore.c (_initialize_gcore): Ditto.
1252 * inf-ptrace.c: Include "inf-ptrace.h".
1253 (inf_ptrace_store_registers): Make it static.
1254 * linux-nat.c (linux_nat_terminal_ours): Make it static.
1255 (_initialize_linux_nat): Declare before definition.
1256 * linux-tdep.c: Include "linux-tdep.h".
1257 * linux-thread-db.c (_initialize_thread_db): Declare before
1259 * proc-service.c (_initialize_proc_service): Ditto.
1260 * remote.c (remote_send_printf): Make it static.
1261 * solib.c: Include "solib.h".
1262 * symfile-mem.c (_initialize_symfile_mem): Declare before
1264 * ada-lang.c (ada_la_decode, ada_match_name)
1265 (ada_suppress_symbol_printing, ada_is_array_type)
1266 (ada_value_ptr_subscript, ada_array_length)
1267 (ada_to_static_fixed_value): Make them static.
1268 (_initialize_ada_language): Declare before definition.
1269 * ada-tasks.c (ada_get_task_number, ada_get_environment_task)
1270 (ada_task_list_changed, ada_new_objfile_observer): Make them
1272 (_initialize_tasks): Declare before definition.
1273 * addrmap.c (_initialize_addrmap): Declare before definition.
1274 * auxv.c (default_auxv_parse): Make it static.
1275 * bfd-target.c (target_bfd_xfer_partial, target_bfd_xclose): Make
1277 * breakpoint.c (remove_sal): Add line break.
1278 (expand_line_sal_maybe): Make it static.
1279 * cp-name-parser.y: Include "cp-support.h".
1280 * cp-valprint.c (cp_find_class_member): Make it static.
1281 * eval.c (value_f90_subarray): Ditto.
1282 * exceptions.c (print_any_exception): Ditto.
1283 * findcmd.c (_initialize_mem_search): Declare before definition.
1284 * frame.c (frame_observer_target_changed): Make it static.
1285 * gnu-v3-abi.c (gnuv3_find_method_in): Make it static.
1286 * inf-child.c: Include "inf-child.h".
1287 * inferior.h (valid_inferior_id): Rename to ...
1288 (valid_gdb_inferior_id): ... this.
1289 * infrun.c (infrun_thread_stop_requested, siginfo_make_value):
1291 * jv-lang.c (java_language_arch_info): Make it static.
1292 * m2-typeprint.c (m2_get_discrete_bounds): Ditto.
1293 * osdata.c (info_osdata_command): Make it static.
1294 * regcache.c (regcache_observer_target_changed): Make it static.
1295 * reverse.c (_initialize_reverse): Declare before definition.
1296 * stabsread.c (cleanup_undefined_types_noname)
1297 (cleanup_undefined_types_1): Make them static.
1298 * symfile.c (place_section): Make it static.
1299 * symtab.c (find_pc_sect_psymtab_closer): Make it static.
1300 * target-descriptions.c (_initialize_target_descriptions): Declare
1302 * target.c (default_get_ada_task_ptid, find_default_can_async_p)
1303 (find_default_is_async_p, find_default_supports_non_stop): Make
1305 (target_supports_non_stop): Add prototype.
1306 (dummy_pid_to_str): Make it static.
1307 * utils.c (_initialize_utils): Declare before definition.
1308 * ada-exp.y (_initialize_ada_exp): Declare before definition.
1309 * solib-svr4.c (HAS_LM_DYNAMIC_FROM_LINK_MAP): Add a prototype.
1310 * target.h (struct target_ops): Add a prototype to the
1311 to_can_execute_reverse callback.
1312 * macroscope.c (_initialize_macroscope): Declare before definition.
1313 * cp-namespace.c (_initialize_cp_namespace): Declare before definition.
1314 * python/python.c (_initialize_python): Declare before definition.
1315 * tui/tui-command.c: Include "tui/tui-command.h".
1316 * tui/tui-data.c (init_content_element, init_win_info): Make them
1318 * tui/tui-disasm.c: Include "tui/tui-disasm.h".
1319 * tui/tui-interp.c (_initialize_tui_interp): Declare before
1321 * tui/tui-layout.c: Include "tui/tui-layout.h".
1322 (_initialize_tui_layout): Declare before definition.
1323 * tui/tui-regs.c: Include "tui/tui-regs.h".
1324 (tui_display_reg_element_at_line): Make it static.
1325 (_initialize_tui_regs): Declare before definition.
1326 * tui/tui-stack.c (_initialize_tui_stack): Declare before
1328 * tui/tui-win.c: Include "tui/tui-win.h".
1329 (_initialize_tui_win): Declare before definition.
1330 (tui_sigwinch_handler): Make it static. Wrap in ifdef SIGWINCH.
1331 * tui/tui-win.h (tui_sigwinch_handler): Delete declaration.
1332 (tui_get_cmd_list): Add a prototype.
1333 * tui/tui-windata.c: Include tui-windata.h.
1334 * tui/tui-wingeneral.c (box_win): Make it static.
1335 * cli/cli-logging.c (show_logging_command): Make it static.
1336 (_initialize_cli_logging): Declare before definition.
1337 * mi/mi-common.c (_initialize_gdb_mi_common): Declare before
1340 2009-02-20 Pierre Muller <muller@ics.u-strasbg.fr>
1342 Extend use of i386_use_watchpoints to all i386 native files
1343 using hardware watchpoints.
1344 * go32-nat.c (init_go32_ops): Call i386_use_watchpoints.
1345 * i386fbsd-nat.c (_initialize_i386fbsd_nat): Ditto.
1346 * windows-nat.c (init_windows_ops): Ditto.
1347 * config/i386/nm-cygwin.h: Define I386_WATCHPOINTS_IN_TARGET_VECTOR.
1348 * config/i386/nm-cygwin64.h: Ditto.
1349 * config/i386/nm-fbsd.h: Ditto.
1350 * config/i386/nm-go32.h: Ditto.
1352 2009-02-19 Joel Brobecker <brobecker@adacore.com>
1354 * ada-typeprint.c (ada_typedef_print): Remove. Unused.
1356 2009-02-18 Vladimir Prus <vladimir@codesourcery.com>
1358 * mi/mi-interp.c (mi_solib_loaded, mi_solib_unloaded): New.
1359 (mi_interpreter_init): Register the above.
1360 * solib.c (clear_solib): Notify solib unload.
1361 * breakpoint.c (disable_breakpoints_in_unloaded_shlib): Do not
1362 disable breakpoints on a.out targets.
1364 2009-02-17 Vladimir Prus <vladimir@codesourcery.com>
1366 * observer.c (observer_test_first_notification_function)
1367 (observer_test_second_notification_function)
1368 (observer_test_third_notification_function): Adjust prototype.
1370 2009-02-17 Pedro Alves <pedro@codesourcery.com>
1372 * Makefile.in (ALL_64_TARGET_OBS): Add amd64-dicos-tdep.o.
1373 (ALL_TARGET_OBS): Add dicos-tdep.o.
1374 (ALLDEPFILES): Add amd64-dicos-tdep.c and dicos-tdep.c.
1375 * configure.tgt (i[34567]86-*-dicos*): Add dicos-tdep.o to
1377 (x86_64-*-dicos*): Add dicos-tdep.o and amd64-dicos-tdep.o to
1379 * dicos-tdep.h, dicos-tdep.c: New.
1380 * amd64-dicos-tdep.c: New.
1381 * i386-dicos-tdep.c: Don't include solib.h, solib-target.h or
1382 inferior.h. Include dicos-tdep.h.
1383 (i386_dicos_init_abi): Call dicos_init_abi.
1384 (i386_dicos_bfd_has_symbol_p): Delete.
1385 (i386_dicos_osabi_sniffer): Use dicos_load_module_p.
1387 * NEWS: Mention x86-64 DICOS target support.
1389 2009-02-16 Doug Evans <dje@google.com>
1391 * amd64-tdep.c (amd64_skip_prefixes): Renamed from skip_prefixes.
1392 All callers updated.
1393 (amd64_get_insn_details): Handle more 3-byte opcode insns.
1394 (amd64_breakpoint_p): Delete.
1395 (amd64_displaced_step_fixup): When fixing up after stepping an int3,
1396 don't back up pc to the start of the int3.
1397 * i386-tdep.c: #include opcode/i386.h.
1398 (i386_skip_prefixes): New function.
1399 (i386_absolute_jmp_p): Constify argument.
1400 (i386_absolute_call_p,i386_ret_p,i386_call_p,i386_syscall_p): Ditto.
1401 (i386_breakpoint_p): Delete.
1402 (i386_displaced_step_fixup): Handle unnecessary or redundant prefixes.
1403 When fixing up after stepping an int3, don't back up pc to the start
1406 2009-02-16 Pedro Alves <pedro@codesourcery.com>
1408 * corelow.c (core_close): Don't hardcode the core's pid.
1409 (core_open): Find core threads before calling
1410 post_create_inferior.
1411 (add_to_thread_list, get_core_register_section): Take into account
1412 systems where the regset section names encode the pid of the
1415 * gdbarch.sh (core_reg_section_encodes_pid): New gdbarch setting.
1416 * gdbarch.h, gdbarch.c: Regenerate.
1418 * amd64-sol2-tdep.c (amd64_sol2_init_abi): Set it.
1419 * i386-sol2-tdep.c (i386_sol2_init_abi): Set it.
1420 * sparc-sol2-tdep.c (sparc32_sol2_init_abi): Set it.
1421 * sparc64-sol2-tdep.c (sparc64_sol2_init_abi): Set it.
1423 2009-02-14 Vladimir Prus <vladimir@codesourcery.com>
1425 Include frame information for *stopped due to CLI commands.
1427 * ada-tasks.c (ada_normal_stop_observer): Adjust prototype.
1428 * infcmd.c (finish_command_continuation): Pass '1' for
1429 'print_frame' parameter to the observer.
1430 * infrun.c (normal_stop): Don't print mi-specific information
1431 here. Pass 'stop_print_frame' to the 'print_frame' parameter
1433 * mi/mi-interp.c (mi_on_normal_stop): Adjust prototype.
1434 If we need to print frame, and current uiout is not the MI one,
1437 2009-02-13 Pierre Muller <muller@ics.u-strasbg.fr>
1439 * xtensa-tdep.c (call0_analyze_prologue): Delete BSZ macro.
1440 Replace BSZ macro uses by XTENSA_ISA_BSZ macro.
1442 2009-02-12 Jan Kratochvil <jan.kratochvil@redhat.com>
1445 * dwarf2read.c (process_die <DW_TAG_module>, read_module)
1446 (scan_partial_symbols <DW_TAG_module>, add_partial_module): New.
1448 2009-02-11 Pierre Muller <muller@ics.u-strasbg.fr>
1450 * dwarf2read.c (read_base_type): Set code to TYPE_CODE_CHAR
1451 for DW_ATE_signed_char and DW_ATE_unsigned_char
1452 for pascal language.
1454 2009-02-11 Jim Meyering <meyering@redhat.com>
1455 Jan Kratochvil <jan.kratochvil@redhat.com>
1457 Avoid NULL dereference.
1458 * stack.c (return_command): Guard use of SYMBOL_TYPE (thisfun).
1459 New variable func_type.
1461 2009-02-11 Pedro Alves <pedro@codesourcery.com>
1463 * gdbarch.c: Regenerate.
1465 2009-02-10 Pierre Muller <muller@ics.u-strasbg.fr>
1467 * p-lang.c (is_pascal_string_type): Fix comment.
1468 Determine exact size of char elements for GPC
1470 (pascal_printstr): Handle char width of 2 or 4.
1471 * p-valprint.c (pascal_val_print): Handle char
1474 2009-02-07 Daniel Jacobowitz <dan@codesourcery.com>
1476 * dwarf2read.c (dwarf2_build_psymtabs_hard): Move lowpc and highpc
1477 inside the loop. Only call addrmap_set_empty if the compilation unit
1478 had DW_AT_high_pc and DW_AT_low_pc. Update call to
1479 scan_partial_symbols.
1480 (scan_partial_symbols): Take NEED_PC argument and pass it along with
1482 (add_partial_namespace): Take NEED_PC argument and pass it through.
1483 (add_partial_subprogram): Take NEED_PC argument. Update the addrmap
1486 2009-02-07 Pedro Alves <pedro@codesourcery.com>
1488 * NEWS: Mention inspecting extra signal information, $_siginfo,
1489 and the qXfer:siginfo:read and qXfer:siginfo:write packets.
1491 2009-02-07 Pedro Alves <pedro@codesourcery.com>
1493 * linux-nat.c (PTRACE_SETSIGINFO): Define if PTRACE_GETSIGINFO
1496 2009-02-06 Pedro Alves <pedro@codesourcery.com>
1498 * amd64-linux-nat.c (compat_int_t, compat_uptr_t, compat_time_t)
1499 (compat_timer_t, compat_clock_t, struct compat_timeval)
1500 (compat_sigval_t, compat_siginfo_t): New types.
1501 (cpt_si_pid, cpt_si_uid, cpt_si_timerid, cpt_si_overrun)
1502 (cpt_si_status, cpt_si_utime, cpt_si_stime, cpt_si_ptr)
1503 (cpt_si_addr, cpt_si_band, cpt_si_fd): New defines.
1504 (compat_siginfo_from_siginfo, siginfo_from_compat_siginfo)
1505 (amd64_linux_siginfo_fixup): New.
1506 * linux-nat.c (linux_nat_siginfo_fixup): New.
1507 (siginfo_fixup): New.
1508 (linux_xfer_siginfo): Use siginfo_fixup to convert between the
1509 siginfo layout expected by ptrace and the siginfo layout of the
1511 (linux_nat_set_siginfo_fixup): New.
1512 * linux-nat.h (linux_nat_set_siginfo_fixup): Declare.
1514 2009-02-06 Pedro Alves <pedro@codesourcery.com>
1516 * target.h (enum target_object): Add new TARGET_OBJECT_SIGNAL_INFO.
1517 * infrun.c (siginfo_value_read, siginfo_value_write): New.
1518 (siginfo_value_funcs): New.
1519 (siginfo_make_value): New.
1520 (_initialize_infrun): Create the $_siginfo convenience variable.
1521 * gdbtypes.h (append_composite_type_field_aligned): Declare.
1522 * gdbtypes.c (append_composite_type_field): Rename to...
1523 (append_composite_type_field_aligned): ... this. Add ALIGNMENT
1524 argument. Handle it.
1525 (append_composite_type_field): Rewrite on top of
1526 append_composite_type_field_aligned.
1527 * value.h (internalvar_make_value): New typedef.
1528 (struct internalvar) <make_value>: New field.
1529 (create_internalvar_type_lazy): Declare.
1530 * value.c (create_internalvar): Clear make_value.
1531 (create_internalvar_type_lazy): New.
1532 (value_of_internalvar): If make_value is set use it.
1533 (preserve_values): Skip internal variables that don't have a
1535 * gdbarch.sh (get_siginfo_type): New.
1536 * gdbarch.h, gdbarch.c: Regenerate.
1538 * linux-tdep.h, linux-tdep.c: New.
1539 * amd64-linux-tdep.c: Include "linux-tdep.h".
1540 (amd64_linux_init_abi): Register linux_get_siginfo_type and
1541 linux_get_siginfo_mapper.
1542 * i386-linux-tdep.c: Include "linux-tdep.h".
1543 (i386_linux_init_abi): Register linux_get_siginfo_type and
1544 linux_get_siginfo_mapper.
1545 * arm-linux-tdep.c: Include "linux-tdep.h".
1546 (i386_linux_init_abi): Register linux_get_siginfo_type and
1547 linux_get_siginfo_mapper.
1549 * linux-nat.c (linux_xfer_siginfo): New.
1550 (linux_nat_xfer_partial): Handle TARGET_OBJECT_SIGNAL_INFO.
1551 * remote.c (PACKET_qXfer_siginfo_read)
1552 (PACKET_qXfer_siginfo_write): New.
1553 (feature remote_protocol_features): Add "qXfer:siginfo:read" and
1554 "qXfer:siginfo:write" features.
1555 (remote_xfer_partial): Handle TARGET_OBJECT_SIGNAL_INFO.
1556 (_initialize_remote): Add "set/show remote read-siginfo-object"
1557 and "set/show remote write-siginfo-object" commands.
1559 * Makefile.in (ALL_TARGET_OBS): Add linux-tdep.o.
1560 (HFILES_NO_SRCDIR): Add linux-tdep.h.
1561 (ALLDEPFILES): Add linux-tdep.c.
1563 * configure.tgt (arm*-*-linux* | arm*-*-uclinux*)
1564 (i[34567]86-*-linux*, x86_64-*-linux*): Add linux-tdep.o to
1567 2009-02-06 Jim Blandy <jimb@codesourcery.com>
1568 Daniel Jacobowitz <dan@codesourcery.com>
1569 Vladimir Prus <vladimir@codesourcery.com>
1570 Pedro Alves <pedro@codesourcery.com>
1572 * defs.h (enum lval_type): New value: lval_computed.
1573 * value.h (struct lval_funcs): New type.
1574 (allocate_computed_value, value_computed_funcs)
1575 (value_computed_closure): New declarations.
1576 * value.c (struct value): Add a structure to the location union
1577 for computed lvalues, containing 'funcs' and 'closure' members.
1578 (allocate_computed_value, value_computed_funcs)
1579 (value_computed_closure): New functions.
1580 (value_free): For computed lvalues, call the closure's
1581 'free_closure' function before freeing the value itself.
1582 (value_copy): If we're copying an lval_computed value, call the
1583 closure's 'copy_closure' function.
1584 (set_value_component_location): If the original value is a
1585 computed lvalue, then call the closure's 'copy_closure' function.
1586 (value_of_internalvar): If an internal variable's value is a
1587 computed lvalue, make retrieving its value produce an equivalent
1589 * valops.c (value_fetch_lazy): Unlazy computed lvalues by calling
1590 their read function.
1591 (value_assign): Assign to computed lvalues by calling their write
1594 2009-02-06 Pedro Alves <pedro@codesourcery.com>
1596 * linux-nat.c (linux_nat_wait): Adjust.
1597 (linux_nat_pid_to_str): Adjust. Remove call to thread_db_init.
1598 * linux-nat.h (thread_db_init): Delete declaration.
1599 * linux-thread-db.c (target_beneath): Delete.
1600 (thread_db_init): Delete.
1601 (thread_db_detach): Use find_target_beneath.
1602 (thread_db_wait): Adjust interface. Use find_target_beneath.
1603 (thread_db_mourn_inferior): Use find_target_beneath.
1604 (thread_db_can_async_p, thread_db_is_async_p, thread_db_async)
1605 (thread_db_async_mask): Delete.
1606 (thread_db_pid_to_str): Adjust interface. Use
1607 find_target_beneath.
1608 (thread_db_get_thread_local_address): Adjust interface. Use
1609 find_target_beneath.
1610 (init_thread_db_ops): Delete references to delete functions.
1611 * target.c (update_current_target): Don't inherit or default
1612 to_wait. Don't inherit to_pid_to_str and
1613 to_get_thread_local_address.
1614 (target_translate_tls_address): Look for a pushed target that
1615 implements to_get_thread_local_address, and use it instead of
1616 checking for target_get_thread_local_address_p.
1617 (target_wait, target_pid_to_str): Reimplement as functions.
1618 (dummy_pid_to_str): New.
1619 (init_dummy_target): Register it.
1620 (debug_to_wait): Delete.
1621 * target.h (struct target_ops): Make to_wait, to_pid_to_str and
1622 to_get_thread_local_address accept a pointer to struct target_ops.
1623 (target_wait): Delete macro, and declare as function.
1624 (target_pid_to_str): Likewise.
1625 (target_get_thread_local_address)
1626 (target_get_thread_local_address_p): Delete.
1627 (noprocess): Add NORETURN and ATTR_NORETURN tags.
1628 * inf-ptrace.c (inf_ptrace_wait): Adjust.
1629 (inf_ptrace_pid_to_str): New.
1630 (inf_ptrace_target): Use inf_ptrace_pid_to_str.
1631 * aix-thread.c (aix_thread_wait, aix_thread_pid_to_str): Adjust.
1632 * bsd-kvm.c (bsd_kvm_pid_to_str): Adjust.
1633 * bsd-uthread.c (bsd_uthread_wait, bsd_uthread_pid_to_str):
1635 * corelow.c (core_pid_to_str): Adjust.
1636 * darwin-nat.c (darwin_wait, darwin_pid_to_str): Adjust.
1637 * dec-thread.c (dec_thread_wait, dec_thread_pid_to_str): Adjust.
1638 * gnu-nat.c (gnu_wait, gnu_pid_to_str): Adjust.
1639 * go32-nat.c (go32_wait, go32_pid_to_str): Adjust.
1640 * hpux-thread.c (hpux_thread_wait): Adjust.
1641 * inf-ttrace.c (inf_ttrace_wait, inf_ttrace_pid_to_str): Adjust.
1642 * monitor.c (monitor_wait, monitor_pid_to_str): Adjust.
1643 * nto-procfs.c (procfs_wait, procfs_pid_to_str): Adjust.
1644 * procfs.c (procfs_pid_to_str): Adjust.
1645 * remote-m32r-sdi.c (m32r_wait, m32r_pid_to_str): Adjust.
1646 * remote-mips.c (mips_wait): Adjust.
1647 * remote-sim.c (gdbsim_wait, gdbsim_pid_to_str): Adjust.
1648 * remote.c (remote_wait, remote_pid_to_str)
1649 (remote_get_thread_local_address): Adjust.
1650 * rs6000-nat.c (rs6000_wait): Adjust.
1651 * sol-thread.c (procfs_pid_to_str): Adjust declaration.
1652 (sol_thread_wait, solaris_pid_to_str): Adjust.
1653 * spu-linux-nat.c (spu_child_wait): Adjust.
1654 * windows-nat.c (windows_wait, windows_pid_to_str): Adjust.
1656 2009-02-06 Tom Tromey <tromey@redhat.com>
1658 * Makefile.in (SUBDIR_PYTHON_OBS): Add python-cmd.o.
1659 (SUBDIR_PYTHON_SRCS): Add python-cmd.c.
1660 (python-cmd.o): New target.
1661 * cli/cli-decode.c (set_cmd_completer): Add self parameter to
1662 completer prototype.
1663 (add_cmd): Initialize destroyer member of cmd_list_element. Use
1664 make_symbol_completion_list_fn as completer.
1665 (delete_cmd): Call destroyer if one is set.
1666 * cli/cli-decode.h (cmd_list_element): Add cmd parameter to
1667 completer member. Add destroyer member.
1668 (set_cmd_completer): Add self parameter to
1669 completer prototype.
1670 * command.h (set_cmd_completer): Add cmd parameter to
1671 completer prototype.
1672 * completer.c (noop_completer, filename_completer,
1673 location_completer, expression_completer, command_completer): Adapt
1674 to new completer prototype.
1675 (complete_line_internal): Pass new parameter to completer function.
1676 * completer.h (noop_completer, filename_completer,
1677 location_completer, expression_completer, command_completer): Adapt
1678 prototypes to new completer prototype.
1679 * interps.c (interpreter_completer): Adapt to new completer
1681 * python/python-cmd.c: New file.
1682 * python/python-internal.h (gdbpy_initialize_commands): Add
1684 (gdbpy_doc_cst): Add forward declaration.
1685 * python/python.c (gdbpy_doc_cst): Declare.
1686 (_initialize_python): Call gdbpy_initialize_commands. Initialize
1688 * symtab.c (make_symbol_completion_list_fn): New function.
1689 * symtab.h (make_symbol_completion_list_fn): Add prototype.
1691 2009-02-06 Pedro Alves <pedro@codesourcery.com>
1693 * target.c (target_get_osdata): Check for equal or higher than
1694 process_stratum, not dummy_stratum.
1696 2009-02-06 Pedro Alves <pedro@codesourcery.com>
1698 * remote.c (extended_remote_can_run): Delete.
1699 (init_remote_ops): Don't register it.
1700 * target.c (target_get_osdata): Don't check for target_can_run.
1701 Instead any target that has already been pushed, otherwise
1702 fallback to the default run target.
1704 2009-02-06 Pedro Alves <pedro@codesourcery.com>
1706 * target.c (target_create_inferior, target_detach)
1707 (target_mourn_inferior, target_attach, target_close): Do target
1709 (debug_to_attach, debug_to_detach, debug_to_create_inferior)
1710 (debug_to_mourn_inferior, debug_to_close): Delete.
1711 (setup_target_debug): Adjust.
1713 2009-02-05 Pedro Alves <pedro@codesourcery.com>
1715 * target.h (target_stopped_data_address_p): Delete declaration,
1716 and don't define as macro.
1717 * target.c (target_stopped_data_address_p): Delete.
1719 2009-02-05 Thiago Jung Bauermann <bauerman@br.ibm.com>
1720 Tom Tromey <tromey@redhat.com>
1722 * python/python-utils.c (target_string_to_unicode): New function.
1723 * python/python-internal.h (target_string_to_unicode): New prototype.
1724 * python/python-value.c (valpy_string): New function.
1725 (value_object_methods): Add `string' entry.
1727 2009-02-05 Pedro Alves <pedro@codesourcery.com>
1729 * target.h (target_tid_to_str): Delete.
1730 * thread.c (print_thread_info, thread_apply_all_command)
1731 (thread_apply_command, thread_command, do_captured_thread_select):
1732 Use target_pid_to_str instead of target_tid_to_str.
1733 * linux-fork.c (delete_fork_command): Likewise.
1735 2009-02-05 Pedro Alves <pedro@codesourcery.com>
1737 * frame.c (has_stack_frames): Make public.
1738 (get_prev_frame): Don't allow a NULL this_frame anymore.
1739 * frame.h (has_stack_frames): Declare.
1740 * varobj.c (find_frame_addr_in_frame_chain): Don't ever pass NULL
1741 to get_prev_frame, instead start at get_current_frame.
1742 (varobj_create): Check has_stack_frames before getting any frame;
1743 eliminate one usage of deprecated_safe_get_selected_frame.
1745 2009-02-05 Tom Tromey <tromey@redhat.com>
1746 Thiago Jung Bauermann <bauerman@br.ibm.com>
1748 * python/python.c (GdbMethods): Move to bottom of file.
1749 (get_parameter, execute_gdb_command, gdbpy_write,
1750 gdbpy_flush): Remove forward declarations.
1751 (eval_python_from_control_command): Fix error checking of function
1752 PyRun_SimpleString. Fix error string.
1753 (python_command): Likewise.
1754 (execute_gdb_command): Added from_tty argument.
1756 2009-02-05 Thiago Jung Bauermann <bauerman@br.ibm.com>
1758 * language.h (language_dfn): Add la_get_string member.
1759 (LA_GET_STRING): New macro.
1760 (default_get_string): New prototype.
1761 * language.c (default_get_string): New function.
1762 (unknown_language_defn, auto_language_defn, local_language_defn): Use
1763 default_get_string for la_get_string.
1764 * c-lang.c (c_get_string): New function.
1765 (c_language_defn, cplus_language_defn, asm_language_defn): Use
1766 c_get_string for la_get_string.
1767 (minimal_language_defn): Likewise
1768 * ada-lang.c (ada_language_defn): Likewise.
1769 * f-lang.c (f_language_defn): Use default_get_string for
1771 * jv-lang.c (java_language_defn): Likewise.
1772 * m2-lang.c (m2_language_defn): Likewise.
1773 * objc-lang.c (objc_language_defn): Likewise.
1774 * p-lang.c (p_language_defn): Likewise.
1775 * scm-lang.c (scm_language_defn): Likewise.
1776 * typeprint.c (type_to_string): New function.
1777 * value.h (type_to_string): New prototype.
1778 * valprint.c (val_print_string): Factor out code for reading string
1779 from the inferior into its own function. Put 2 spaces after period
1781 (read_string): New function.
1782 * valprint.h (read_string): New prototype.
1784 2009-01-07 Pierre Muller <muller@ics.u-strasbg.fr>
1785 Tom Tromey <tromey@redhat.com>
1787 PR breakpoints/8079:
1788 * breakpoint.c (print_one_breakpoint): Use exp_string field
1789 to display expression of watchpoints.
1790 (mention): Likewise.
1791 (watch_command_1): Remove trailing whitespace from expression.
1792 * printcmd.c (struct display) <exp_string>: New field.
1793 (display_command): Set exp_string.
1794 (free_display): Free exp_string.
1795 (clear_displays): Use free_display.
1796 (do_one_display): Print exp_string.
1797 (display_info): Likewise.
1799 2009-02-04 Tom Tromey <tromey@redhat.com>
1800 Thiago Jung Bauermann <bauerman@br.ibm.com>
1801 Phil Muldoon <pmuldoon@redhat.com>
1803 * python/python-internal.h (gdbpy_get_value_from_history): Rename
1804 prototype to gdbpy_history.
1805 (gdbpy_is_string): Declare.
1806 (python_string_to_host_string): Declare.
1807 * python/python-utils.c (gdbpy_is_string): New function.
1808 (unicode_to_encoded_string): New function.
1809 (unicode_to_target_string): Use it.
1810 (python_string_to_host_string): New function.
1811 * python/python-value.c (valpy_address): New function.
1812 (convert_value_from_python): Use gdbpy_is_string. Change to throw
1813 Python exception instead of a GDB exception on error. Properly check
1815 (valpy_getitem): Convert field name to host string. Handle array
1816 accesses. Adapt to new behaviour of convert_value_from_python.
1817 (valpy_new): Adapt to new behaviour of convert_value_from_python.
1818 (enum valpy_opcode) <VALPY_LSH, VALPY_RSH, VALPY_BITAND,
1819 VALPY_BITXOR, VALPY_BITOR>: New constants.
1820 (valpy_binop): Update. Adapt to new behaviour of
1821 convert_value_from_python.
1822 (valpy_invert): New function.
1823 (valpy_lsh): Likewise.
1824 (valpy_rsh): Likewise.
1825 (valpy_and): Likewise.
1826 (valpy_or): Likewise.
1827 (valpy_xor): Likewise.
1828 (valpy_richcompare): Call convert_value_from_python instead of doing
1830 (is_intlike, valpy_int, valpy_long, valpy_float): New functions.
1831 (gdbpy_get_value_from_history): Rename
1832 function to gdbpy_history.
1833 (gdbpy_initialize_values): Don't set tp_new.
1834 (value_object_type): Add valpy_new.
1835 (value_object_methods): Add `address' entry.
1836 (value_object_as_number): Update for new methods.
1837 * python/python.c (GdbMethods): Rename entry from
1838 `get_value_from_history' to `history'.
1840 2009-02-04 Jerome Guitton <guitton@adacore.com>
1842 * ada-lang.c (ada_template_to_fixed_record_type_1): Check size
1843 of type to guard against a crash.
1845 2009-02-04 Jerome Guitton <guitton@adacore.com>
1847 * value.c (value_from_contents_and_address): Always return
1848 a lval_memory value, even if address is null.
1850 2009-02-04 Tristan Gingold <gingold@adacore.com>
1852 * i386-darwin-tdep.c (i386_darwin_sigcontext_addr): New function.
1853 (amd64_darwin_sigcontext_addr): Ditto.
1854 (darwin_dwarf_signal_frame_p): Ditto.
1855 (i386_darwin_init_abi): Handle signal frames, use the const for
1857 (x86_darwin_init_abi_64): Ditto.
1859 2009-02-04 Tristan Gingold <gingold@adacore.com>
1861 * i386-tdep.c (i386_sigtramp_p): Make it public.
1862 * i386-tdep.h (i386_sigtramp_p): Declare.
1864 2009-02-04 Tristan Gingold <gingold@adacore.com>
1866 * machoread.c (macho_symfile_read): Read minsymtab also from
1868 (macho_symfile_read): Try to read dwarf2 frame info from main
1869 object file, but not from OSO files.
1870 (macho_symfile_offsets): Update section names for latest BFD
1872 * i386-darwin-tdep.c (i386_darwin_init_abi): Call set_solib_ops.
1873 (x86_darwin_init_abi_64): Ditto.
1874 * solib-darwin.c: New file.
1875 * solib-darwin.h: New file.
1876 * configure.tgt: Add solib.o solib-darwin.o for Darwin.
1878 2009-02-04 Tristan Gingold <gingold@adacore.com>
1880 * solist.h (struct target_so_ops): Comment fallback behavior for
1883 2009-02-03 Tom Tromey <tromey@redhat.com>
1885 * completer.c (add_struct_fields): Check type_name against NULL
1888 2009-02-03 Joel Brobecker <brobecker@adacore.com>
1890 * MAINTAINERS: Update Elena's email address.
1892 2009-02-02 Joel Brobecker <brobecker@adacore.com>
1894 * breakpoint (update_watchpoint): Minor comment adjustment.
1896 2009-02-02 Tom Tromey <tromey@redhat.com>
1899 * completer.c (count_struct_fields): Count method names.
1900 (add_struct_fields): Add matching method names.
1902 2009-02-02 Doug Evans <dje@google.com>
1904 * configure.ac (gdbkt): Check both no_tcl/no_tk first, before
1905 doing any further tcl/tk configury. Don't configure gdbtk if
1906 tcl or tk check fails.
1907 * aclocal.m4: Regenerate.
1908 * configure: Regenerate.
1910 2009-02-02 Tom Tromey <tromey@redhat.com>
1913 * valops.c (find_overload_match): Follow typedefs before taking
1914 address of object argument.
1916 2009-02-01 Doug Evans <dje@google.com>
1918 * target.h (target_waitstatus_to_string): Declare.
1919 * target.c (target_waitstatus_to_string): New function. Copied from
1920 debug_to_wait. Add missing entries for TARGET_WAITKIND_SYSCALL_ENTRY,
1921 TARGET_WAITKIND_SYSCALL_RETURN, TARGET_WAITKIND_IGNORE,
1922 TARGET_WAITKIND_NO_HISTORY.
1923 (debug_to_wait): Call it.
1924 * infrun.c (wait_for_inferior): If debug_infrun, print result of
1926 (fetch_inferior_event): Ditto.
1928 2009-01-30 Tom Tromey <tromey@redhat.com>
1930 * Makefile.in (HFILES_NO_SRCDIR): Remove i386-cygwin-tdep.h.
1932 2009-01-30 Vladimir Prus <vladimir@codesourcery.com>
1935 * thread.c (do_captured_list_thread_ids): Report the current
1938 2009-01-30 Vladimir Prus <vladimir@codesourcery.com>
1940 * breakpoint.c (create_breakpoint, create_breakpoints)
1941 (break_command_really, set_breakpoint): New parameter enabled.
1942 (create_breakpoint, break_command_really): Make breakpoint
1943 disabled if so requested.
1944 * breakpoint.h (set_breakpoint): New parameter enabled.
1945 * mi/mi-cmd-break.c (mi_cmd_break_insert): Handle the -d option.
1947 2009-01-28 Doug Evans <dje@google.com>
1949 * amd64-tdep.h (amd64_displaced_step_copy_insn): Declare.
1950 (amd64_displaced_step_fixup): Declare.
1951 * amd64-tdep.c: #include opcode/i386.h, dis-asm.h.
1952 (amd64_arch_regmap): Move out of amd64_analyze_stack_align
1953 and make static global.
1954 (amd64_arch_regmap_len): New static global.
1955 (amd64_arch_reg_to_regnum): New function.
1956 (struct amd64_insn): New struct.
1957 (struct displaced_step_closure): New struct.
1958 (onebyte_has_modrm,twobyte_has_modrm): New static globals.
1959 (rex_prefix_p,skip_prefixes)
1960 (amd64_insn_length_fprintf,amd64_insn_length_init_dis)
1961 (amd64_insn_length,amd64_get_unused_input_int_reg)
1962 (amd64_get_insn_details,fixup_riprel,fixup_displaced_copy)
1963 (amd64_displaced_step_copy_insn)
1964 (amd64_absolute_jmp_p,amd64_absolute_call_p,amd64_ret_p)
1965 (amd64_call_p,amd64_breakpoint_p,amd64_syscall_p)
1966 (amd64_displaced_step_fixup): New functions.
1967 * amd64-linux-tdep.c: #include arch-utils.h.
1968 (amd64_linux_init_abi): Install displaced stepping support.
1970 2009-01-28 Daniel Jacobowitz <dan@codesourcery.com>
1971 Jerome Guitton <guitton@adacore.com>
1973 * configure, config.in: Regenerated.
1974 * configure.ac: Add --with-system-gdbinit.
1975 * main.c (get_init_files): New.
1976 (captured_main): Use get_init_files. Load system gdbinit before
1978 (print_gdb_help): Print location of init files.
1980 2009-01-28 Pedro Alves <pedro@codesourcery.com>
1982 * corefile.c (generic_search): Delete disabled code.
1983 * gdbcore.h (generic_search): Delete declaration.
1985 2009-01-26 Pedro Alves <pedro@codesourcery.com>
1987 * linux-nat.c (linux_child_follow_fork): Copy attach_flag from the
1988 parent to the child.
1989 * inf-ttrace.c (inf_ttrace_follow_fork): Likewise.
1990 * inf-ptrace.c (inf_ptrace_follow_fork): Likewise. Use
1991 remove_breakpoints to remove breakpoints from the parent.
1993 2009-01-26 Pedro Alves <pedro@codesourcery.com>
1995 PR backtrace/9458, PR backtrace/8864:
1996 * frame.c (create_new_frame): Update the frame's cached PC before
1997 finding its unwinder. Use frame_id_build to build the new frame's
1999 * stack.c (parse_frame_specification_1): Correct setting ``addrs''
2000 array values from the ``args'' array values.
2002 2009-01-26 Pedro Alves <pedro@codesourcery.com>
2004 * gdbtypes.c (alloc_type, alloc_type_instance, create_range_type)
2005 (create_array_type, create_set_type, init_flags_type)
2006 (copy_type_recursive): Replace pairs of calls to XALLOC and memset
2007 with a call to XZALLOC or XCALLOC, and pairs of calls to
2008 obstack_alloc and memset with a call to OBSTACK_ZALLOC.
2010 2009-01-26 Pedro Alves <pedro@codesourcery.com>
2012 Add "maint set|show internal-error|internal-warning quit|corefile
2013 ask|yes|no" commands.
2016 * utils.c (internal_problem_ask, internal_problem_yes)
2017 (internal_problem_no, internal_problem_modes): New.
2018 (struct internal_problem): Remove FIXME. Make should_quit and
2019 should_dump_core types to char *.
2020 (internal_vproblem, internal_error_problem)
2021 (internal_warning_problem): Adjust.
2022 (set_internal_problem_cmd, show_internal_problem_cmd): New dummy
2024 (add_internal_problem_command): New.
2025 (_initialize_utils): New.
2027 2009-01-25 Pedro Alves <pedro@codesourcery.com>
2029 * infcmd.c (program_info): Use paddress instead of casting stop_pc
2032 2009-01-24 Pedro Alves <pedro@codesourcery.com>
2034 * infrun.c (normal_stop): Don't call
2035 deprecated_update_frame_pc_hack.
2036 * frame.c (deprecated_update_frame_pc_hack)
2037 (deprecated_update_frame_base_hack): Delete, and ...
2038 (create_new_frame): ... inline here.
2039 * frame.h (deprecated_update_frame_pc_hack)
2040 (deprecated_update_frame_base_hack): Delete declarations.
2042 2009-01-23 Pedro Alves <pedro@codesourcery.com>
2044 * cli/cli-decode.c (add_setshow_zuinteger_cmd): New.
2045 * cli/cli-setshow.c (do_setshow_command): Handle it.
2046 * command.h (enum var_types): Add var_zuinteger.
2047 (add_setshow_zuinteger_cmd): Declare.
2049 * valprint.c (_initialize_valprint): Change the set input-radix
2050 and set output-radix commands to zuinteger type.
2052 2009-01-23 Pedro Alves <pedro@codesourcery.com>
2055 * infrun.c (normal_stop): Tag threads as stopped, and run the
2056 hook-stop before printing the stack frame.
2058 2009-01-22 Pedro Alves <pedro@codesourcery.com>
2061 * gnu-v3-abi.c (gnuv3_baseclass_offset): Call check_typedef on
2064 2009-01-20 Kazu Hirata <kazu@codesourcery.com>
2066 * gdb/procfs.c (info_mappings_callback): Cast map->pr_size to
2069 2009-01-20 Daniel Jacobowitz <dan@codesourcery.com>
2072 * infcmd.c (signal_command): Do not specify a resume PC.
2074 2009-01-19 Doug Evans <dje@google.com>
2076 * dummy-frame.c (dummy_frame): Replace regcache member with
2078 (dummy_frame_push): Replace caller_regcache arg with caller_state.
2079 All callers updated.
2080 (remove_dummy_frame,pop_dummy_frame,lookup_dummy_frame): New fns.
2081 (dummy_frame_pop): Rewrite. Verify requested frame is in the
2082 dummy frame stack. Restore program state.
2083 (cleanup_dummy_frames): Rewrite.
2084 (dummy_frame_sniffer): Update. Make static.
2085 * dummy-frame.h (regcache,frame_info): Delete forward decls.
2086 (inferior_thread_state): New forward decl.
2087 (dummy_frame_push): Update prototype.
2088 * frame.c (frame_pop): dummy_frame_pop now does all the work for
2090 * infcall.c (breakpoint_auto_delete_contents): Delete.
2091 (get_function_name,run_inferior_call): New fns.
2092 (call_function_by_hand): Simplify by moving some code to
2093 get_function_name, run_inferior_call. Inferior function call wrapped
2094 in TRY_CATCH so there's less need for cleanups and all exits from
2095 proceed are handled similarily. Detect program exit.
2096 Detect program stopping in a different thread.
2097 Make error messages more consistent.
2098 * inferior.h (inferior_thread_state): Declare (opaque type).
2099 (save_inferior_thread_state,restore_inferior_thread_state,
2100 make_cleanup_restore_inferior_thread_state,
2101 discard_inferior_thread_state, get_inferior_thread_state_regcache):
2103 (save_inferior_status): Update prototype.
2104 * infrun.c: (normal_stop): When stopped for the completion of an
2105 inferior function call, verify the expected stack frame kind.
2106 (inferior_thread_state): New struct.
2107 (save_inferior_thread_state,restore_inferior_thread_state,
2108 do_restore_inferior_thread_state_cleanup,
2109 make_cleanup_restore_inferior_thread_state,
2110 discard_inferior_thread_state,
2111 get_inferior_thread_state_regcache): New functions.
2112 (inferior_status): Move stop_signal, stop_pc, registers to
2113 inferior_thread_state. Remove restore_stack_info.
2114 (save_inferior_status): Remove arg restore_stack_info.
2115 All callers updated. Remove saving of state now saved by
2116 save_inferior_thread_state.
2117 (restore_inferior_status): Remove restoration of state now done by
2118 restore_inferior_thread_state.
2119 (discard_inferior_status): Remove freeing of registers, now done by
2120 discard_inferior_thread_state.
2122 2009-01-18 Pedro Alves <pedro@codesourcery.com>
2124 * tui/tui-disasm.c (tui_vertical_disassem_scroll): Scroll one line
2125 at a time, times NUM_TO_SCROLL.
2126 * tui/tui-winsource.c (tui_horizontal_source_scroll): Don't try to
2127 fetch the selected frame if there is no stack.
2129 2009-01-18 Pedro Alves <pedro@codesourcery.com>
2132 * gdbthread.h (finish_thread_state, finish_thread_state_cleanup):
2134 * thread.c (finish_thread_state, finish_thread_state_cleanup): New.
2135 * infrun.c (wait_for_inferior, fetch_inferior_event): If an error
2136 is thrown while handling an event, finish the thread state.
2137 (normal_stop): Use finish_thread_state cleanup.
2138 * infcmd.c (run_command_1): If an error is thrown while starting
2139 the inferior, finish the thread state.
2141 2009-01-18 Pedro Alves <pedro@codesourcery.com>
2143 * tui/tui-winsource.c (tui_update_breakpoint_info): In asm layout,
2144 skip breakpoints without a location (pending breakpoints).
2146 2009-01-18 Pedro Alves <pedro@codesourcery.com>
2149 * hppa-hpux-tdep.c (hppa_hpux_write_pc): Remove 'return'.
2151 2009-01-18 Nick Roberts <nickrob@snap.net.nz>
2153 * thread.c (thread_command): Move call to annotate_thread_changed
2155 (do_captured_thread_select): ... here, to avoid printing an
2156 annotation if the thread change generates an exception.
2158 2009-01-16 Joel Brobecker <brobecker@adacore.com>
2160 * NEWS: Document x86_64/MinGW as a new native configuration.
2162 2009-01-16 Joel Brobecker <brobecker@adacore.com>
2164 * NEWS: Move the documentation of "info os processes" to
2165 the appropriate section (documenting the new commands).
2167 2009-01-15 Doug Evans <dje@google.com>
2169 * target.h (target_signal_to_string): Make return type const char *.
2170 (target_signal_to_name): Ditto.
2171 (target_signal_from_name): Make arg const char *.
2172 * infrun.c (sig_print_info): Update.
2173 * signals/signals.c (signals): Make array and struct members const.
2174 (target_signal_to_string): Make return type const char *.
2175 (target_signal_to_name): Ditto.
2176 (target_signal_from_name): Make arg const char *.
2178 2009-01-15 Ulrich Weigand <uweigand@de.ibm.com>
2179 Tristan Gingold <gingold@adacore.com>
2181 * solist.h (struct target_so_ops): New member bfd_open.
2182 (solib_find): Add prototype.
2183 (solib_bfd_fopen): Add prototype.
2184 * solib.c (solib_find, solib_bfd_fopen): New functions, extracted
2185 from solib_bfd_open.
2186 (solib_bfd_open): Use ops->bfd_open override if present. Call
2187 solib_find and solib_bfd_open otherwise.
2189 * objfiles.h (OBJF_KEEPBFD): New define.
2190 * objfiles.c (free_objfile): Do not close BFD if OBJF_KEEPBFD
2191 objfile flag is set.
2192 * solib.c (symbol_add_stub): Do not allocate second BFD for
2193 shared library; use OBJF_KEEPBFD flag on solib objfile.
2195 2009-01-15 Ulrich Weigand <uweigand@de.ibm.com>
2197 * frame.c (get_frame_arch): Abort if called with NULL this_frame.
2199 2009-01-15 Ulrich Weigand <uweigand@de.ibm.com>
2201 * value.h (address_of_variable): Add prototype.
2202 (locate_var_value): Remove prototype.
2204 * findvar.c (read_var_value): Do not attempt to default frame
2206 (locate_var_value): Remove function.
2207 * valops.c (value_of_variable): Retrieve selected frame for
2208 symbols that require a frame when called with NULL block.
2209 * valops.c (address_of_variable): New function.
2211 * eval.c (evaluate_subexp_for_address): Call address_of_variable
2212 instead of calling locate_var_value.
2213 (evaluate_subexp_with_coercion): Likewise.
2215 2009-01-14 Daniel Jacobowitz <dan@codesourcery.com>
2217 * NEWS: Document "define" for prefixed commands.
2218 * cli/cli-cmds.c (show_user): Update calls to show_user_1. Call
2219 show_user_1 for prefix commands.
2220 * cli/cli-decode.c (help_cmd_list): Recurse for "help user-defined".
2221 * cli/cli-script.c (validate_comname): Rewrite to handle prefix
2222 commands. Return the containing command list.
2223 (define_command, document_command): Update to handle prefix commands.
2224 (show_user_1): Add prefix and name arguments. Handle prefix
2226 * cli/cli-script.h (show_user_1): Update prototype.
2228 2009-01-14 Kai Tietz <kai.tietz@onevision.com>
2230 * mingw-ser.c (console_select_thread): Add return to make
2232 (pipe_select_thread): Likewise.
2233 (file_select_thread): Likewise.
2235 2009-01-14 Pedro Alves <pedro@codesourcery.com>
2237 * mi/mi-main.c (mi_cmd_execute): Clean up parenthesis mess from
2240 2009-01-14 Pedro Alves <pedro@codesourcery.com>
2242 * remote.c (extended_remote_mourn_1): Invalidate our notion of
2243 current general thread.
2245 2009-01-14 Pedro Alves <pedro@codesourcery.com>
2247 * mi/mi-main.c (mi_cmd_execute): Also allow -list-thread-groups
2248 without a live selected thread.
2250 2009-01-14 Joel Brobecker <brobecker@adacore.com>
2252 Update the copyright notice of some of the files I missed
2253 in the previous copyright update.
2255 2009-01-14 Joel Brobecker <brobecker@adacore.com>
2257 * windows-nat.c (handle_unload_dll): Use %p to print the DLL
2258 base address instead of casting it to DWORD.
2260 2009-01-13 Ulrich Weigand <uweigand@de.ibm.com>
2262 * dwarf2loc.c (dwarf2_evaluate_loc_desc): Do not call get_frame_arch
2263 for NULL frame pointers.
2265 2009-01-13 Mark Kettenis <kettenis@gnu.org>
2267 * utils.c (host_address_to_string): Reimplement in a way that
2268 avoids the cast of the address to long.
2270 2009-01-13 Joel Brobecker <brobecker@adacore.com>
2272 * mdebugread.c (parse_symbol): Save the symbol private data
2273 using SYMBOL_VALUE_BYTES instead of SYMBOL_VALUE.
2274 (psymtab_to_symtab_1): Likewise.
2275 (parse_procedure): Declare variable "e" only in the scope
2276 where it is used. Extract the symbol private data using
2279 2009-01-13 Jim Blandy <jimb@codesourcery.com>
2281 Abstract out common code for copying value locations.
2283 * value.h (set_value_component_location): New declaration.
2284 * value.c (set_value_component_location): New function.
2285 (value_primitive_field): Use it.
2286 * valarith.c (value_subscript, value_subscripted_rvalue): Same.
2287 * valops.c (search_struct_field, value_slice): Same.
2288 * ada-lang.c (coerce_unspec_val_to_type)
2289 (ada_value_primitive_packed_val): Same.
2291 2009-01-13 Joel Brobecker <brobecker@adacore.com>
2293 * MAINTAINERS (GLOBAL MAINTAINERS): Add Tom Tromey.
2295 2009-01-12 Christopher Faylor <me+cygwin@cgf.cx>
2297 * amd64-windows-nat.c Rename gdb-specific win32_* to windows_*
2299 * i386-cygwin-tdep.c: Ditto.
2300 * i386-windows-nat.c: Ditto.
2301 * windows-nat.h: Ditto.
2302 * windows-tdep.c: Ditto.
2303 * windows-tdep.h: Ditto.
2304 * windows-nat.c: Ditto.
2305 (cygwin_load_start): Redefine as CORE_ADDR.
2306 (cygwin_load_end): Ditto.
2307 (windows_make_so): Coerce result of address arithmetic to uintptr_t
2308 before coercing to CORE_ADDR to avoid a compiler warning.
2309 (handle_exception): Define addr as CORE_ADDR and coerce
2310 ExceptionAddress to uintptr_t before assigining to avoid a compiler
2312 * config/djgpp/fnchange.lst: Add mappings for recently renamed windows
2315 2009-01-11 Jan Kratochvil <jan.kratochvil@redhat.com>
2317 Fix linking with --enable-targets=all:
2318 * Makefile.in (ALL_TARGET_OBS): Add windows-tdep.o.
2319 (HFILES_NO_SRCDIR): Add windows-tdep.h.
2320 (ALLDEPFILES): Add windows-tdep.c.
2322 2009-01-11 Chris Faylor <me.gdb@cgf.cx>
2324 * win32-nat.h: Delete.
2325 * windows-nat.h: Rename from win32-nat.h.
2326 * win32-nat.c: Delete.
2327 * windows-nat.c: Rename from win32-nat.c.
2328 * win32-termcap.c: Delete.
2329 * windows-termcap.c: Rename from win32-termcap.c.
2330 * amd64-windows-nat.c: Handle rename from win32-nat.h -> windows-nat.h.
2331 * configure.ac: Handle rename from win32-termcap.c ->
2333 * configure: Regenerate.
2334 * gdb_curses.h: Change comment to reflect rename from win32-termcap.c
2335 -> windows-termcap.c.
2336 * i386-cygwin-tdep.c: Handle rename from win32-tdep.h ->
2338 * i386-windows-nat.c: Refect rename from win32-nat.h -> windows-nat.h.
2339 * windows-nat.c: Ditto. Also reflect rename from from win32-tdep.h ->
2341 (win32_make_so): Handle cygwin compiler warning due to change of
2342 load_addr from DWORD to LPVOID.
2343 (handle_load_dll): Use %p in format string to properly print address
2344 and avoid a compiler warning.
2345 (DEBUG_EXCEPTION_SIMPLE): Ditto.
2346 (handle_exception): Ditto.
2347 * windows-tdep.c: Handle rename from win32-tdep.h -> windows-tdep.h.
2348 * config/i386/cygwin.mh: Handle rename from win32-nat.o ->
2350 * config/i386/mingw.mh: Ditto.
2351 * config/i386/mingw64.mh: Ditto.
2353 2009-01-11 Jan Kratochvil <jan.kratochvil@redhat.com>
2355 * f-typeprint.c (f_type_print_varspec_suffix): Convert the autovariable
2356 arrayprint_recurse_level to a parameter. Update all the callers. New
2357 comment at autovariables.
2359 2009-01-11 Jan Kratochvil <jan.kratochvil@redhat.com>
2361 * gdbtypes.c (make_qualified_type, replace_type): Reformat to the GNU
2364 2009-01-11 Joel Brobecker <brobecker@adacore.com>
2366 * target.c (target_xfer_partial): Use host_address_to_string to
2367 print the address of readbuf and writebuf. Cast the address of
2368 elements inside the myaddr buffer into intptr_t.
2369 (deprecated_debug_xfer_memory): Use paddress to print memaddr.
2370 Cast the address of elements inside the myaddr buffer into
2373 2009-01-11 Joel Brobecker <brobecker@adacore.com>
2375 * amd64-windows-nat.c, amd64-windows-tdep.c: New files.
2376 * config/i386/mingw64.mh, config/i386/nm-cygwin64.h: New files.
2377 * configure.host, configure.tgt: Add handling for x86_64/windows.
2378 * config/djgpp/fnchange.lst: Add entries for amd64-windows-nat.c
2379 and amd64-windows-tdep.c.
2381 2009-01-11 Joel Brobecker <brobecker@adacore.com>
2383 * win32-tdep.h, win32-tdep.c: New files.
2384 * i386-cygwin-tdep.h: Delete.
2385 * i386-cygwin-tdep.c: Include win32-tdep.h instead of
2387 (win32_xfer_shared_library): Delete. Moved to win32-tdep.c.
2388 * win32-nat.c: Likewise.
2389 * configure.tgt: Add win32-tdep.o to the list of target object
2390 files for i386-cygwin and i386-mingw targets.
2392 2009-01-11 Joel Brobecker <brobecker@adacore.com>
2394 * win32-nat.h: New file.
2395 * win32-nat.c (mappings): Initialize to NULL.
2396 (win32_set_context_register_offsets): New function.
2397 * i386-windows-nat.c: New file.
2398 (mappings): Moved here from win32-nat.c.
2399 (_initialize_i386_windows_nat): New function.
2400 * config/i386/mingw.mh (NATDEPFILES): Add i386-windows-nat.o.
2401 * config/i386/cygwin.mh (NATDEPFILES): Likewise.
2403 2009-01-09 Andreas Schwab <schwab@suse.de>
2405 * Makefile.in (init.c): Set LANG/LC_ALL to C, not c.
2407 2009-01-09 Daniel Jacobowitz <dan@codesourcery.com>
2409 * gdbtypes.c (append_composite_type_field): Correct the location of
2412 2009-01-09 Pedro Alves <pedro@codesourcery.com>
2414 * defs.h (deprecated_error_hook): Delete declaration.
2415 * interps.c (clear_interpreter_hooks): Adjust.
2416 * remote-sim.c (gdb_os_error): Don't try to call
2417 deprecated_error_hook. No need to call exit anymore.
2418 * top.c (deprecated_error_hook): Delete.
2420 2009-01-09 Joel Brobecker <brobecker@adacore.com>
2422 * arch-utils.c (gdbarch_update_p): Use host_address_to_string
2423 to print the address of the gdbarch pointer.
2425 2009-01-09 Joel Brobecker <brobecker@adacore.com>
2427 * gdbarch.sh: Fix all the compilation errors on amd64-windows
2428 due to casting a pointer to a long when printing a function
2429 address. Instead, use host_address_to_string to convert our
2430 address to a string.
2431 * gdbarch.c: Regenerate.
2433 2009-01-09 Joel Brobecker <brobecker@adacore.com>
2435 * event-top.c (async_disconnect, async_stop_sig): use "raise"
2436 instead of "kill" to raise a signal.
2438 2009-01-09 Joel Brobecker <brobecker@adacore.com>
2440 * win32-nat.c (get_module_name): Change the type of parameter
2441 "base_address" to LPVOID. Remove unnecessary cast.
2442 (struct lm_info): Change type of load_addr to LPVOID.
2443 (win32_make_so): Change the type of parameter "load_addr"
2444 to LPVOID. Remove some unnecessary casts.
2445 (handle_unload_dll): Change the type of "lpBaseOfDll" to LPVOID.
2446 (win32_xfer_shared_libraries): Add missing cast.
2448 2009-01-09 Joel Brobecker <brobecker@adacore.com>
2450 * win32-nat.c (has_detach_ability, set_process_privilege):
2451 Cast the result of GetProcAddress to (void *) to avoid
2452 a compilation warning.
2454 2009-01-09 Joel Brobecker <brobecker@adacore.com>
2456 * win32-nat.c (CONTEXT_EXTENDED_REGISTERS): Define to 0 if not
2459 2009-01-09 Joel Brobecker <brobecker@adacore.com>
2461 * win32-nat.c (get_image_name, win32_xfer_memory): Fix type
2462 definition of local variable "done".
2463 (info_w32_command, handle_exception): Remove unnecessary cast.
2465 2009-01-09 Joel Brobecker <brobecker@adacore.com>
2467 * win32-nat.c (kernel32_DebugSetProcessKillOnExit): Renames
2468 DebugSetProcessKillOnExit. Update all uses in this file.
2469 (kernel32_DebugActiveProcessStop): Renames DebugActiveProcessStop.
2470 Update all uses in this file.
2472 2009-01-09 Joel Brobecker <brobecker@adacore.com>
2474 * win32-nat.c (do_initial_win32_stuff): Add new ops parameter,
2475 and use it when pushing the target.
2476 (win32_attach, win32_create_inferior): Update call to
2477 do_initial_win32_stuff.
2478 (win32_detach, win32_mourn_inferior): Use our ops parameter
2479 instead of the global win32_ops to unpush the target.
2481 2009-01-09 Joel Brobecker <brobecker@adacore.com>
2483 * ser-mingw.c (ser_windows_open): Use proper type when casting
2484 in call to _open_osfhandle.
2486 2009-01-09 Kai Tietz <kai.tietz@onevision.com>
2488 * coff-pe-read.c (read_pe_exported_syms): Fix typo.
2490 2009-01-09 Joel Brobecker <brobecker@adacore.com>
2492 * CONTRIBUTE: Minor reformatting.
2494 2009-01-08 Kai Tietz <kai.tietz@onevision.com>
2496 * MAINTAINERS: Add myself to Write After Approval.
2497 * coff-pe-read.c (read_pe_exported_syms): Enable read of PE+
2500 2009-01-08 Nathan Froyd <froydnj@codesourcery.com>
2502 * remote-sim.c (gdb_os_error): Mark as a noreturn function.
2503 Call exit to make it obvious to GCC.
2505 2009-01-08 Tom Tromey <tromey@redhat.com>
2507 PR breakpoints/9350:
2508 * varobj.c (varobj_invalidate): Unconditionally free
2510 * symfile.c (syms_from_objfile): Free local_addr when returning
2512 * exec.c (exec_file_attach): Do cleanups before returning.
2513 (exec_file_command): Likewise.
2514 * corefile.c (reopen_exec_file): Do cleanups before returning.
2515 * breakpoint.c (insert_breakpoint_locations): Do cleanups before
2517 (do_vec_free): New function.
2518 (update_global_location_list): Make a cleanup for old_locations.
2519 Do cleanups before returning. Remove unused variable 'e'.
2520 (find_condition_and_thread): Free result of parsing the
2522 (print_it_typical): Do cleanups before returning.
2523 (breakpoint_re_set_one): Always free sals.sals.
2525 2009-01-08 Joel Brobecker <brobecker@adacore.com>
2526 Emi Suzuki <emi-suzuki@tjsys.co.jp>
2528 * breakpoint.c (do_enable_breakpoint): Use update_watchpoint for
2531 2009-01-07 Doug Evans <dje@google.com>
2533 * top.c (gdb_prompt_string): Delete, unused.
2535 2009-01-07 Pedro Alves <pedro@codesourcery.com>
2537 Delete ONE_PROCESS_WRITETEXT leftovers.
2539 * breakpoint.c (insert_bp_location): Delete process_warning
2541 (insert_breakpoint_locations): Adjust.
2542 (reattach_breakpoints): Adjust.
2543 * infrun.c (normal_stop): Drop "It might be running in another
2546 2009-01-07 Stan Shebs <stan@codesourcery.com>
2548 * config/pa/linux.mh (XDEPFILES): Remove.
2550 2009-01-07 Doug Evans <dje@google.com>
2552 * cli/cli-cmds.c (set_debug): Fix cut-n-paste error.
2554 2009-01-07 Jan Kratochvil <jan.kratochvil@redhat.com>
2556 * f-typeprint.c (f_type_print_base <TYPE_CODE_STRUCT>): Fix output
2557 spacing, a regression from 2008-04-22.
2559 2009-01-07 Joel Brobecker <brobecker@adacore.com>
2561 * utils.c (gdb_print_host_address): Adjust implementation to
2562 reuse host_address_to_string. Move comment explaining the conversion
2563 from host address to string from here...
2564 (host_address_to_string): ... to there.
2566 2009-01-07 Emi Suzuki <emi-suzuki@tjsys.co.jp>
2568 * MAINTAINERS: Add myself for write after approval privileges.
2570 2009-01-06 Tom Tromey <tromey@redhat.com>
2572 * value.c (set_internalvar): Use value_free, not xfree.
2574 2009-01-06 Jim Blandy <jimb@red-bean.com>
2576 Check return values of functions declared with warn_unused_result
2577 attribute in GLIBC 2.8.
2578 * cli/cli-cmds.c (pwd_command): Check return value from getcwd.
2579 * inflow.c (check_syscall): New function.
2580 (new_tty): Use check_syscall to check return values from open and dup.
2581 * linux-nat.c (linux_nat_info_proc_cmd): Check return value from fgets.
2582 * main.c (captured_main): Call cwd after setting up gdb_stderr;
2583 check for errors from getcwd.
2584 * mi/mi-cmd-env.c (mi_cmd_env_pwd): Check return value from getcwd.
2585 * ui-file.c (stdio_file_write): Ignore return value from fwrite.
2586 (stdio_file_fputs): Same.
2587 * utils.c (internal_vproblem): abort if last-ditch error message
2590 * top.c (gdb_init): Don't set the current directory here; that's
2591 already been done in captured_main.
2593 2009-01-06 Sandra Loosemore <sandra@codesourcery.com>
2595 * ser-tcp.c: Adjust includes.
2596 (tcp_set_cmdlist, tcp_show_cmdlist): Declare.
2597 (tcp_auto_retry, tcp_retry_limit): Declare.
2598 (TIMEOUT): Remove, in favor of tcp_retry_limit.
2599 (POLL_INTERVAL): Increase to 5, in favor of backoff logic.
2600 (wait_for_connect): New function.
2601 (net_open): Use it. Add auto-retry logic.
2602 (set_tcp_cmd, show_tcp_cmd): New functions.
2603 (_initialize_ser_tcp): Initialize new "set/show tcp auto-retry"
2604 and "set/show tcp connect-timeout" commands.
2605 * NEWS: Document new commands.
2607 2009-01-05 Tom Tromey <tromey@redhat.com>
2609 * python/python-internal.h (Py_ssize_t): Define as int.
2611 2009-01-05 Jim Blandy <jimb@red-bean.com>
2613 * MAINTAINERS: Fix my e-mail address as steering committee member.
2615 2009-01-03 Joel Brobecker <brobecker@adacore.com>
2617 Updated copyright notices for most files.
2619 2009-01-03 Joel Brobecker <brobecker@adacore.com>
2621 * top.c (print_gdb_version): Update copyright year.
2623 2009-01-03 Joel Brobecker <brobecker@adacore.com>
2625 * config/djgpp/fnchange.lst: Add entry for ChangeLog-2008.
2627 2009-01-01 Pedro Alves <pedro@codesourcery.com>
2629 PR breakpoints/9681:
2630 * exceptions.h (enum errors): New error type, MEMORY_ERROR.
2631 * corefile.c (memory_error): Rewrite to throw a MEMORY_ERROR.
2632 * breakpoint.c (fetch_watchpoint_value): Ignore MEMORY_ERRORs, but
2633 retrow all other exceptions.
2635 For older changes see ChangeLog-2008.
2641 version-control: never